Document the GDB 8.3 release in gdb/ChangeLog
[external/binutils.git] / gdb / ChangeLog
1 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2
3         GDB 8.3 released.
4
5 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6
7         * version.in: Set GDB version number to 8.3.
8
9 2019-05-08  Tom Tromey  <tromey@adacore.com>
10
11         * utils.c (fputs_maybe_filtered): Reset style after paging, even
12         when no wrap column is set.
13
14 2019-05-04  Tom Tromey  <tom@tromey.com>
15
16         * psymtab.c (psymbol_name_matches, match_partial_symbol)
17         (lookup_partial_symbol, print_partial_symbols)
18         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
19         (psymbol_compare): Update.
20         (add_psymbol_to_bcache): Clear the entire psymbol.
21         (maintenance_check_psymtabs): Update.
22         * psympriv.h (struct partial_symbol): Don't derive from
23         general_symbol_info.
24         <obj_section, unrelocated_address, address,
25         set_unrelocated_address>: Update.
26         <ginfo>: New member.
27         * dwarf-index-write.c (write_psymbols, debug_names::insert)
28         (debug_names::write_psymbols): Update.
29
30 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
31
32         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
33         level, so that various Windows header files expose the necessary
34         declarations and definitions.
35
36         * symfile.c (find_separate_debug_file): Remove colon from the
37         drive spec of DOS/Windows file names of the target, so that the
38         file name produced from DEBUGDIR and the target's directory will
39         be valid on DOS/Windows systems.
40
41 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
42
43         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
44         Use current_event.dwThreadId instead of main_thread_id.
45
46 2019-04-30  Tom Tromey  <tromey@adacore.com>
47
48         PR c++/24470:
49         * dwarf2read.c (process_structure_scope): Handle case where type
50         has template parameters but no symbol was created.
51
52 2019-04-19  Sergei Trofimovich <siarheit@google.com>
53
54         * configure.ac: add --enable-source-highlight switch.
55         * configure: Regenerate.
56         * top.c (print_gdb_version): plumb --enable-source-highlight
57         status to "show configuration".
58
59 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
60
61         PR symtab/24423:
62         * source.c (print_source_lines_base): Advance "iter" when a
63         control character is seen.
64
65 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
66
67         * inferior.h (struct infcall_suspend_state_deleter):
68         Catch exception in destructor to avoid crash.
69
70 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
71
72         * utils.c (prompt_for_continue): Don't restore the styling at the
73         end, as applied_style has the wrong value.  This fixes styling in
74         long lists of file names that are interrupted by the "Continue?"
75         prompt.
76
77 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
78
79         * version.in: Set GDB version number to 8.2.91.DATE-git.
80
81 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
82
83         GDB 8.2.91 released.
84
85 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
86
87         * version.in: Set GDB version number to 8.2.91.
88
89 2019-03-20  Tom Tromey  <tromey@adacore.com>
90
91         PR gdb/24391
92         * infrun.c (handle_inferior_event): Rename from
93         handle_inferior_event_1.  Create a scoped_value_mark.
94         (handle_inferior_event): Remove.
95
96 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
97
98         * source-cache.c (source_cache::get_source_lines): Re-read
99         fullname after calling open_source_file.
100
101 2019-03-18  Pedro Alves  <palves@redhat.com>
102             Eli Zaretskii <eliz@gnu.org>
103
104         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
105         m_line and m_start_of_line.
106
107 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
108
109         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
110         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
111         it returns a newline.  This fixes a regression in TU mode, whereby
112         the next line is output on the same screen line as the user input.
113
114 2019-03-18  Pedro Alves  <palves@redhat.com>
115
116         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
117         New globals.
118         (apply_style): New, factored out from ...
119         (apply_ansi_escape): ... this.  Handle reverse video mode.
120         (tui_set_reverse_mode): New function.
121         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
122         * tui/tui-winsource.c (tui_show_source_line): Use
123         tui_set_reverse_mode instead of setting A_STANDOUT.
124         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
125         New setter methods.
126
127 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
128
129         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
130         Handle tabs.
131
132 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
133
134         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
135         tui_refill_source_window instead of tui_refresh_win, to update the
136         current execution line.  This fixes redisplay of the current line
137         when stepping through the code with "next" or "step".
138
139 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
140
141         * source-cache.c (source_cache::get_source_lines): Call
142         find_source_lines to initialize s->nlines.  This fixes vertical
143         scrolling of TUI source window when the DOWN arrow is pressed.
144
145 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
146
147         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
148         wclrtoeol in tui_show_source_line".  This reverts changes made in
149         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
150
151 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
152
153         * NEWS: Combine separate "New targets" sections for 8.3.
154
155 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
156
157         The MS-Windows port of ncurses fails to switch to a color pair if
158         one or both of the colors are the implicit default colors.  This
159         change records the default colors when TUI is initialized, and
160         then specifies them explicitly when a color pair uses the default
161         colors.  This allows color styling in TUI mode on MS-Windows.
162
163         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
164         ncurses_norm_attr.
165         (tui_initialize_io) [__MINGW32__]: Record the default terminal
166         colors in ncurses_norm_attr.
167         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
168         "none", replace it with the default color recorded in
169         ncurses_norm_attr.
170
171 2019-03-14  Tom Tromey  <tromey@adacore.com>
172
173         * source-cache.h (class source_cache) <get_source_lines>: Return
174         std::string.
175         * source-cache.c (source_cache::extract_lines): Handle case where
176         first_pos==npos.  Return std::string.
177         (source_cache::get_source_lines): Update.
178
179 2019-03-14  Tom Tromey  <tromey@adacore.com>
180
181         * NEWS: Add item for "style sources" commands.
182         * source-cache.c (source_cache::get_source_lines): Check
183         source_styling.
184         * cli/cli-style.c (source_styling): New global.
185         (_initialize_cli_style): Add "style sources" commands.
186         (show_style_sources): New function.
187         * cli/cli-style.h (source_styling): Declare.
188
189 2019-03-14  Pedro Alves  <palves@redhat.com>
190             Tom Tromey  <tromey@adacore.com>
191
192         * tui/tui-winsource.h (tui_refill_source_window): Declare.
193         * tui/tui-winsource.c (tui_refill_source_window): New function,
194         from...
195         (tui_horizontal_source_scroll): ... here.  Move some logic.
196         * cli/cli-style.c (set_style_enabled): Notify new observable.
197         * tui/tui-hooks.c (tui_redisplay_source): New function.
198         (tui_attach_detach_observers): Attach or detach
199         tui_redisplay_source.
200         * observable.h (source_styling_changed): New observable.
201         * observable.c: Define source_styling_changed observable.
202
203 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
204
205         PR/24325
206         * source-cache.c: #undef open and close, to avoid unresolved
207         externals during linking.
208
209 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
210
211         Support styling on native MS-Windows console
212
213         PR/24315
214         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
215         on MS-Windows if $TERM is not defined.
216
217         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
218
219         * posix-hdep.c (gdb_console_fputs):
220         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
221         functions.
222         * ui-file.h (gdb_console_fputs): Add prototype.
223
224         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
225         back to fputs only if the former returns zero.
226
227 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
228             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
229
230         PR gdb/8527
231         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
232         set_sigint_trap, clear_sigint_trap.
233
234 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
235
236         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
237         for-loop range, to avoid compiler warnings.
238
239         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
240         avoid compiler warnings about unused variables.
241
242 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
243
244         * NEWS: Mention end of support for native debugging on MS-Windows
245         before XP.
246
247 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
248
249         PR gdb/24292
250         * common/netstuff.c:
251         * gdbserver/gdbreplay.c
252         * gdbserver/remote-utils.c:
253         * ser-tcp.c:
254         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
255         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
256         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
257         'getaddrinfo' and 'freeaddrinfo' were not available before
258         Windows XP, and mingw.org's MinGW headers by default define
259         _WIN32_WINNT to 0x500.
260
261 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
262     
263         * NEWS: Note minimum Python version.
264
265 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
266
267         * version.in: Set GDB version number to 8.2.90.DATE-git.
268
269 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
270
271         GDB 8.2.90 released.
272
273 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
274
275         * version.in: Set GDB version number to 8.2.90.
276
277 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
278
279         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
280
281 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
282
283         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
284         * version.in: Bump version to 8.2.90.DATE-git.
285
286 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
287
288         * aix-thread.c (ptid_cmp): Remove unused variable.
289         (get_signaled_thread): Likewise.
290         (store_regs_user_thread): Likewise.
291         (store_regs_kernel_thread): Likewise.
292         (fetch_regs_kernel_thread): Remove shadowed variable.
293
294 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
295
296         * features/riscv/32bit-cpu.xml: Add register numbers.
297         * features/riscv/32bit-fpu.c: Regenerate.
298         * features/riscv/32bit-fpu.xml: Add register numbers.
299         * features/riscv/64bit-cpu.xml: Add register numbers.
300         * features/riscv/64bit-fpu.c: Regenerate.
301         * features/riscv/64bit-fpu.xml: Add register numbers.
302
303 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
304
305         * NEWS: Mention two argument form of gdb.Value constructor.
306         * python/py-value.c (convert_buffer_and_type_to_value): New
307         function.
308         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
309         Add support for handling an optional second argument.  Call
310         convert_buffer_and_type_to_value as appropriate.
311         * python/python-internal.h (Py_buffer_deleter): New struct.
312         (Py_buffer_up): New typedef.
313
314 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
315
316         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
317         instead of releasing ownership.
318
319 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
320
321         * dwarf2read.c (open_and_init_dwp_file): Call
322         elf_numsections instead of bfd_count_sections to initialize
323         dwp_file->num_sections.
324
325 2019-02-25  Tom Tromey  <tromey@adacore.com>
326
327         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
328
329 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
330
331         * gcore.in: Add '--readnever' option when invoking GDB.
332
333 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
334
335         * MAINTAINERS: Update my email address.
336
337 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
338
339         * build-id.c (build_id_to_debug_bfd_1): New function.
340         (build_id_to_debug_bfd): Look for separate debug file in
341         sysroot.
342
343 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
344
345         * gdbarch.sh: Update the copyright year range that is placed into
346         generated files.
347
348 2019-02-22  Keith Seitz  <keiths@redhat.com>
349
350         PR symtab/23853
351         * linespec.c (create_sals_line_offset): Search for the default
352         symtab's filename instead of its fullname.
353
354 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
355
356         * NEWS: Update style defaults.
357
358 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
359
360         * main.c (captured_main_1): Disable styling in batch mode.
361
362 2019-02-20  Tom Tromey  <tom@tromey.com>
363
364         * symtab.c (symtab_symbol_info): Fix typos.
365
366 2019-02-20  Tom Tromey  <tromey@adacore.com>
367
368         * findcmd.c (_initialize_mem_search): Use upper case for
369         metasyntactic variables.
370
371 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
372
373         * aarch64-tdep.c (aarch64_add_reggroups): New function.
374         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
375
376 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
377
378         * top.h (source_file_name): Change to std::string.
379         * top.c (source_file_name): Likewise.
380         (command_line_input): Adjust.
381         * cli/cli-script.c (script_from_file): Adjust.
382
383 2019-02-19  Tom Tromey  <tromey@adacore.com>
384
385         * ravenscar-thread.c
386         (ravenscar_thread_target::update_thread_list): Don't call
387         ada_build_task_list.
388         * ada-lang.h (ada_build_task_list): Don't declare.
389         * ada-tasks.c (struct ada_tasks_inferior_data)
390         <task_list_valid_p>: Now bool.
391         (read_known_tasks, ada_task_list_changed)
392         (ada_tasks_invalidate_inferior_data): Update.
393         (read_known_tasks_array): Return bool.
394         (read_known_tasks_list): Likewise.
395         (read_known_tasks): Return void.
396         (ada_build_task_list): Now static.
397
398 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
399
400         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
401         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
402
403 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
404
405         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
406         variant for ada_tasks_pspace_data_handle and
407         ada_tasks_inferior_data_handle.
408         (ada_tasks_pspace_data_cleanup): New function.
409         (ada_tasks_inferior_data_cleanup): New function.
410
411 2019-02-17  Tom Tromey  <tom@tromey.com>
412
413         * macrotab.h (macro_source_fullname): Return a std::string.
414         * macrotab.c (macro_include, check_for_redefinition)
415         (macro_undef, macro_lookup_definition, foreach_macro)
416         (foreach_macro_in_scope): Update.
417         (macro_source_fullname): Return a std::string.
418         * macrocmd.c (show_pp_source_pos): Update.
419
420 2019-02-17  Tom Tromey  <tom@tromey.com>
421
422         * macrocmd.c (show_pp_source_pos): Style the file names.
423
424 2019-02-17  Tom Tromey  <tom@tromey.com>
425
426         PR tui/24197:
427         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
428
429 2019-02-17  Tom Tromey  <tom@tromey.com>
430
431         * ada-lang.c (user_select_syms): Use filtered printing.
432         * utils.c (wrap_style): New global.
433         (desired_style): Remove.
434         (emit_style_escape): Add stream parameter.
435         (set_output_style, reset_terminal_style, prompt_for_continue):
436         Update.
437         (flush_wrap_buffer): Only flush gdb_stdout.
438         (wrap_here): Set wrap_style.
439         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
440         treat escape sequences as a character.  Change when wrap buffer is
441         flushed.
442         (fputs_styled): Do not set the output style when the default is
443         requested.
444         * ui-style.h (struct ui_file_style) <is_default>: New method.
445         * source.c (print_source_lines_base): Emit escape sequences in one
446         piece.
447
448 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
449
450         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
451         integers and enumeration types.
452
453 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
454
455         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
456         instead of lookup_symbol_in_language
457         (do_exact_match): New function.
458         (ada_get_symbol_name_matcher): Return do_exact_match when
459         doing a verbatim match.
460
461 2019-02-15  Tom Tromey  <tromey@adacore.com>
462
463         * ravenscar-thread.c (ravenscar_thread_target::resume)
464         (ravenscar_thread_target::wait): Special case wildcard requests.
465
466 2019-02-15  Tom Tromey  <tromey@adacore.com>
467
468         * ravenscar-thread.c (base_ptid): Remove.
469         (struct ravenscar_thread_target) <close>: New method.
470         <m_base_ptid>: New member.
471         <update_inferior_ptid, active_task, task_is_currently_active,
472         runtime_initialized>: Declare methods.
473         <ravenscar_thread_target>: Add constructor.
474         (ravenscar_thread_target::task_is_currently_active)
475         (ravenscar_thread_target::update_inferior_ptid)
476         (ravenscar_runtime_initialized): Rename.  Now methods.
477         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
478         (ravenscar_thread_target::update_thread_list): Update.
479         (ravenscar_thread_target::active_task): Now method.
480         (ravenscar_thread_target::store_registers)
481         (ravenscar_thread_target::prepare_to_store)
482         (ravenscar_thread_target::prepare_to_store)
483         (ravenscar_thread_target::mourn_inferior): Update.
484         (ravenscar_inferior_created): Use "new" to create target.
485         (ravenscar_thread_target::get_ada_task_ptid): Update.
486         (_initialize_ravenscar): Don't initialize base_ptid.
487         (ravenscar_ops): Remove global.
488
489 2019-02-15  Tom Tromey  <tromey@adacore.com>
490
491         * target.h (push_target): Declare new overload.
492         * target.c (push_target): New overload, taking an rvalue reference.
493         * remote.c (remote_target::open_1): Use push_target overload.
494         * corelow.c (core_target_open): Use push_target overload.
495
496 2019-02-15  Tom Tromey  <tromey@adacore.com>
497
498         * ravenscar-thread.c (is_ravenscar_task)
499         (ravenscar_task_is_currently_active): Return bool.
500         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
501         (_initialize_ravenscar): Remove "(void)".
502         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
503         Return bool.
504
505 2019-02-15  Tom Tromey  <tromey@adacore.com>
506
507         * ravenscar-thread.c (ravenscar_runtime_initializer)
508         (has_ravenscar_runtime, get_running_thread_id)
509         (ravenscar_thread_target::resume): Fix indentation.
510
511 2019-02-15  Tom Tromey  <tromey@adacore.com>
512
513         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
514         from ravenscar_arch_ops.
515         (sparc_ravenscar_ops::fetch_registers)
516         (sparc_ravenscar_ops::store_registers): Now methods.
517         (sparc_ravenscar_prepare_to_store): Remove.
518         (sparc_ravenscar_ops): Redefine.
519         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
520         methods and destructor.  Remove members.
521         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
522         (ravenscar_thread_target::store_registers)
523         (ravenscar_thread_target::prepare_to_store): Update.
524         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
525         Remove.
526         (struct ppc_ravenscar_powerpc_ops): Derive from
527         ravenscar_arch_ops.
528         (ppc_ravenscar_powerpc_ops::fetch_registers)
529         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
530         (ppc_ravenscar_powerpc_ops): Redefine.
531         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
532         (ppc_ravenscar_e500_ops::fetch_registers)
533         (ppc_ravenscar_e500_ops::store_registers): Now methods.
534         (ppc_ravenscar_e500_ops): Redefine.
535         * aarch64-ravenscar-thread.c
536         (aarch64_ravenscar_generic_prepare_to_store): Remove.
537         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
538         (aarch64_ravenscar_fetch_registers)
539         (aarch64_ravenscar_store_registers): Now methods.
540         (aarch64_ravenscar_ops): Redefine.
541
542 2019-02-15  Tom Tromey  <tromey@adacore.com>
543
544         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
545         (ravenscar_thread_target::stopped_by_hw_breakpoint)
546         (ravenscar_thread_target::stopped_by_watchpoint)
547         (ravenscar_thread_target::stopped_data_address)
548         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
549
550 2019-02-15  Tom Tromey  <tromey@adacore.com>
551
552         * ravenscar-thread.c: Fix some typos.
553
554 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
555             Tom Tromey  <tromey@adacore.com>
556
557         * ada-lang.c (ada_exception_sal): Change addr_string to a
558         std::string.
559         (create_ada_exception_catchpoint): Update.
560
561 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
562             Tom Tromey  <tromey@adacore.com>
563
564         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
565         (bp_location_ops): Remove.
566         (base_breakpoint_allocate_location): Update.
567         (free_bp_location): Update.
568         * ada-lang.c (class ada_catchpoint_location)
569         <ada_catchpoint_location>: Remove ops parameter.
570         (ada_catchpoint_location_dtor): Remove.
571         (ada_catchpoint_location_ops): Remove.
572         (allocate_location_exception): Update.
573         * breakpoint.h (struct bp_location_ops): Remove.
574         (class bp_location) <bp_location>: Remove bp_location_ops
575         parameter.
576         <~bp_location>: Add destructor.
577         <ops>: Remove.
578
579 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
580             Pedro Alves  <palves@redhat.com>
581
582         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
583         'PATH_MAX'.
584
585 2019-02-14  David Michael  <fedora.dm0@gmail.com>
586             Samuel Thibault  <samuel.thibault@gnu.org>
587             Thomas Schwinge  <thomas@codesourcery.com>
588
589         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
590         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
591
592 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
593
594         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
595         (check_empty): Use "const char *".
596
597         * gnu-nat.c (gnu_nat_target::detach): Instead of
598         'detach_inferior (pid)' call
599         'detach_inferior (find_inferior_pid (pid))'.
600
601         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
602         'nat/fork-inferior.o'.
603         * gnu-nat.c: #include "nat/fork-inferior.h".
604
605         * gnu-nat.c (gnu_nat_target::detach): Instead of
606         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
607         * gnu-nat.h: #include "inf-child.h".
608         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
609         'i386_gnu_nat_target::fetch_registers'.
610         (gnu_store_registers): Rename/move to
611         'i386_gnu_nat_target::store_registers'.
612
613         * config/i386/nm-i386gnu.h: Don't "#include" any files.
614         * gnu-nat.h (mach_thread_info): New function.
615         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
616
617         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
618
619 2019-02-14  Frederic Konrad  <konrad@adacore.com>
620
621         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
622
623 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
624
625         * windows-nat.c (windows_add_thread): Add new parameter
626         "main_thread_p" with default value set to false.  Update
627         function documentation as well as all callers.
628         (windows_delete_thread): Likewise.
629         (fake_create_process): Update call to windows_add_thread.
630         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
631         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
632         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
633         call to windows_delete_thread.
634
635 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
636
637         * MAINTAINERS: Add Andrew Burgess as global maintainer.
638
639 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
640
641         * symfile.c (find_separate_debug_file): Use canonical path of
642         sysroot with child_path instead of gdb_sysroot if it is valid.
643
644 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
645
646         * symfile.c (find_separate_debug_file): Use child_path to
647         determine if an object file is under a sysroot.
648
649 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
650
651         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
652         unittests/child-path-selftests.c.
653         * common/pathstuff.c (child_path): New function.
654         * common/pathstuff.h (child_path): New prototype.
655         * unittests/child-path-selftests.c: New file.
656
657 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
658
659         * symfile.c (find_separate_debug_file): Look for separate debug
660         files in debug directories under the sysroot.
661
662 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
663
664         * symtab.h (struct minimal_symbol data_p): New const method.
665         (struct minimal_symbol text_p): Likewise.
666         * symtab.c (output_source_filename): Use file name style
667         to print file name.
668         (print_symbol_info): Likewise.
669         (print_msymbol_info): Use address style to print addresses.
670         Use function name style to print executable text symbols.
671         (expand_symtab_containing_pc): Use data_p.
672         (find_pc_sect_compunit_symtab): Likewise.
673
674 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
675
676         * breakpoint.c (describe_other_breakpoints): Use address style
677         to print addresses.
678         (say_where): Likewise.
679
680 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
681
682         * ada-typeprint.c (print_func_type): Print function name
683         style to print function name.
684         * c-typeprint.c (c_print_type_1): Likewise.
685
686 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
687
688         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
689         for execve.
690
691 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
692
693         * c-exp.y (direct_abs_decl): Use emplace_back to record the
694         type_stack.
695
696 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
697
698         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
699         TYPE_CODE_REF types.
700
701 2019-02-08  Jim Wilson  <jimw@sifive.com>
702
703         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
704         (riscv_linux_fregset): New.
705         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
706
707 2019-02-07  Tom Tromey  <tom@tromey.com>
708
709         * thread.c (thread_cancel_execution_command): Update.
710         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
711         methods.
712         (struct thread_fsm_ops): Remove.
713         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
714         (thread_fsm_should_stop, thread_fsm_return_value)
715         (thread_fsm_set_finished, thread_fsm_finished_p)
716         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
717         Don't declare.
718         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
719         * infrun.c (clear_proceed_status_thread)
720         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
721         (print_stop_event): Update.
722         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
723         Add constructor.
724         (step_command_fsm_ops): Remove.
725         (new_step_command_fsm): Remove.
726         (step_1): Update.
727         (step_command_fsm::should_stop): Rename from
728         step_command_fsm_should_stop.
729         (step_command_fsm::clean_up): Rename from
730         step_command_fsm_clean_up.
731         (step_command_fsm::do_async_reply_reason): Rename from
732         step_command_fsm_async_reply_reason.
733         (struct until_next_fsm): Inherit from thread_fsm.  Add
734         constructor.
735         (until_next_fsm_ops): Remove.
736         (new_until_next_fsm): Remove.
737         (until_next_fsm::should_stop): Rename from
738         until_next_fsm_should_stop.
739         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
740         (until_next_fsm::do_async_reply_reason): Rename from
741         until_next_fsm_async_reply_reason.
742         (struct finish_command_fsm): Inherit from thread_fsm.  Add
743         constructor.  Change type of breakpoint.
744         (finish_command_fsm_ops): Remove.
745         (new_finish_command_fsm): Remove.
746         (finish_command_fsm::should_stop): Rename from
747         finish_command_fsm_should_stop.
748         (finish_command_fsm::clean_up): Rename from
749         finish_command_fsm_clean_up.
750         (finish_command_fsm::return_value): Rename from
751         finish_command_fsm_return_value.
752         (finish_command_fsm::do_async_reply_reason): Rename from
753         finish_command_fsm_async_reply_reason.
754         (finish_command): Update.
755         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
756         Add constructor.
757         (call_thread_fsm_ops): Remove.
758         (call_thread_fsm::call_thread_fsm): Rename from
759         new_call_thread_fsm.
760         (call_thread_fsm::should_stop): Rename from
761         call_thread_fsm_should_stop.
762         (call_thread_fsm::should_notify_stop): Rename from
763         call_thread_fsm_should_notify_stop.
764         (run_inferior_call, call_function_by_hand_dummy): Update.
765         * cli/cli-interp.c (should_print_stop_to_console): Update.
766         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
767         Add constructor.  Change type of location_breakpoint,
768         caller_breakpoint.
769         (until_break_fsm_ops): Remove.
770         (new_until_break_fsm): Remove.
771         (until_break_fsm::should_stop): Rename from
772         until_break_fsm_should_stop.
773         (until_break_fsm::clean_up): Rename from
774         until_break_fsm_clean_up.
775         (until_break_fsm::do_async_reply_reason): Rename from
776         until_break_fsm_async_reply_reason.
777         (until_break_command): Update.
778         * thread-fsm.c: Remove.
779         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
780
781 2019-02-07  Tom Tromey  <tom@tromey.com>
782
783         * yy-remap.h: Add include guard.
784         * xtensa-tdep.h: Add include guard.
785         * xcoffread.h: Rename include guard.
786         * varobj-iter.h: Add include guard.
787         * tui/tui.h: Rename include guard.
788         * tui/tui-winsource.h: Rename include guard.
789         * tui/tui-wingeneral.h: Rename include guard.
790         * tui/tui-windata.h: Rename include guard.
791         * tui/tui-win.h: Rename include guard.
792         * tui/tui-stack.h: Rename include guard.
793         * tui/tui-source.h: Rename include guard.
794         * tui/tui-regs.h: Rename include guard.
795         * tui/tui-out.h: Rename include guard.
796         * tui/tui-layout.h: Rename include guard.
797         * tui/tui-io.h: Rename include guard.
798         * tui/tui-hooks.h: Rename include guard.
799         * tui/tui-file.h: Rename include guard.
800         * tui/tui-disasm.h: Rename include guard.
801         * tui/tui-data.h: Rename include guard.
802         * tui/tui-command.h: Rename include guard.
803         * tic6x-tdep.h: Add include guard.
804         * target/waitstatus.h: Rename include guard.
805         * target/wait.h: Rename include guard.
806         * target/target.h: Rename include guard.
807         * target/resume.h: Rename include guard.
808         * target-float.h: Rename include guard.
809         * stabsread.h: Add include guard.
810         * rs6000-tdep.h: Add include guard.
811         * riscv-fbsd-tdep.h: Add include guard.
812         * regformats/regdef.h: Rename include guard.
813         * record.h: Rename include guard.
814         * python/python.h: Rename include guard.
815         * python/python-internal.h: Rename include guard.
816         * python/py-stopevent.h: Rename include guard.
817         * python/py-ref.h: Rename include guard.
818         * python/py-record.h: Rename include guard.
819         * python/py-record-full.h: Rename include guard.
820         * python/py-record-btrace.h: Rename include guard.
821         * python/py-instruction.h: Rename include guard.
822         * python/py-events.h: Rename include guard.
823         * python/py-event.h: Rename include guard.
824         * procfs.h: Add include guard.
825         * proc-utils.h: Add include guard.
826         * p-lang.h: Add include guard.
827         * or1k-tdep.h: Rename include guard.
828         * observable.h: Rename include guard.
829         * nto-tdep.h: Rename include guard.
830         * nat/x86-linux.h: Rename include guard.
831         * nat/x86-linux-dregs.h: Rename include guard.
832         * nat/x86-gcc-cpuid.h: Add include guard.
833         * nat/x86-dregs.h: Rename include guard.
834         * nat/x86-cpuid.h: Rename include guard.
835         * nat/ppc-linux.h: Rename include guard.
836         * nat/mips-linux-watch.h: Rename include guard.
837         * nat/linux-waitpid.h: Rename include guard.
838         * nat/linux-ptrace.h: Rename include guard.
839         * nat/linux-procfs.h: Rename include guard.
840         * nat/linux-osdata.h: Rename include guard.
841         * nat/linux-nat.h: Rename include guard.
842         * nat/linux-namespaces.h: Rename include guard.
843         * nat/linux-btrace.h: Rename include guard.
844         * nat/glibc_thread_db.h: Rename include guard.
845         * nat/gdb_thread_db.h: Rename include guard.
846         * nat/gdb_ptrace.h: Rename include guard.
847         * nat/fork-inferior.h: Rename include guard.
848         * nat/amd64-linux-siginfo.h: Rename include guard.
849         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
850         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
851         * nat/aarch64-linux.h: Rename include guard.
852         * nat/aarch64-linux-hw-point.h: Rename include guard.
853         * mn10300-tdep.h: Add include guard.
854         * mips-linux-tdep.h: Add include guard.
855         * mi/mi-parse.h: Rename include guard.
856         * mi/mi-out.h: Rename include guard.
857         * mi/mi-main.h: Rename include guard.
858         * mi/mi-interp.h: Rename include guard.
859         * mi/mi-getopt.h: Rename include guard.
860         * mi/mi-console.h: Rename include guard.
861         * mi/mi-common.h: Rename include guard.
862         * mi/mi-cmds.h: Rename include guard.
863         * mi/mi-cmd-break.h: Rename include guard.
864         * m2-lang.h: Add include guard.
865         * location.h: Rename include guard.
866         * linux-record.h: Rename include guard.
867         * linux-nat.h: Add include guard.
868         * linux-fork.h: Add include guard.
869         * i386-darwin-tdep.h: Rename include guard.
870         * hppa-linux-offsets.h: Add include guard.
871         * guile/guile.h: Rename include guard.
872         * guile/guile-internal.h: Rename include guard.
873         * gnu-nat.h: Rename include guard.
874         * gdb-stabs.h: Rename include guard.
875         * frv-tdep.h: Add include guard.
876         * f-lang.h: Add include guard.
877         * event-loop.h: Add include guard.
878         * darwin-nat.h: Rename include guard.
879         * cp-abi.h: Rename include guard.
880         * config/sparc/nm-sol2.h: Rename include guard.
881         * config/nm-nto.h: Rename include guard.
882         * config/nm-linux.h: Add include guard.
883         * config/i386/nm-i386gnu.h: Rename include guard.
884         * config/djgpp/nl_types.h: Rename include guard.
885         * config/djgpp/langinfo.h: Rename include guard.
886         * compile/gcc-cp-plugin.h: Add include guard.
887         * compile/gcc-c-plugin.h: Add include guard.
888         * compile/compile.h: Rename include guard.
889         * compile/compile-object-run.h: Rename include guard.
890         * compile/compile-object-load.h: Rename include guard.
891         * compile/compile-internal.h: Rename include guard.
892         * compile/compile-cplus.h: Rename include guard.
893         * compile/compile-c.h: Rename include guard.
894         * common/xml-utils.h: Rename include guard.
895         * common/x86-xstate.h: Rename include guard.
896         * common/version.h: Rename include guard.
897         * common/vec.h: Rename include guard.
898         * common/tdesc.h: Rename include guard.
899         * common/selftest.h: Rename include guard.
900         * common/scoped_restore.h: Rename include guard.
901         * common/scoped_mmap.h: Rename include guard.
902         * common/scoped_fd.h: Rename include guard.
903         * common/safe-iterator.h: Rename include guard.
904         * common/run-time-clock.h: Rename include guard.
905         * common/refcounted-object.h: Rename include guard.
906         * common/queue.h: Rename include guard.
907         * common/ptid.h: Rename include guard.
908         * common/print-utils.h: Rename include guard.
909         * common/preprocessor.h: Rename include guard.
910         * common/pathstuff.h: Rename include guard.
911         * common/observable.h: Rename include guard.
912         * common/netstuff.h: Rename include guard.
913         * common/job-control.h: Rename include guard.
914         * common/host-defs.h: Rename include guard.
915         * common/gdb_wait.h: Rename include guard.
916         * common/gdb_vecs.h: Rename include guard.
917         * common/gdb_unlinker.h: Rename include guard.
918         * common/gdb_unique_ptr.h: Rename include guard.
919         * common/gdb_tilde_expand.h: Rename include guard.
920         * common/gdb_sys_time.h: Rename include guard.
921         * common/gdb_string_view.h: Rename include guard.
922         * common/gdb_splay_tree.h: Rename include guard.
923         * common/gdb_setjmp.h: Rename include guard.
924         * common/gdb_ref_ptr.h: Rename include guard.
925         * common/gdb_optional.h: Rename include guard.
926         * common/gdb_locale.h: Rename include guard.
927         * common/gdb_assert.h: Rename include guard.
928         * common/filtered-iterator.h: Rename include guard.
929         * common/filestuff.h: Rename include guard.
930         * common/fileio.h: Rename include guard.
931         * common/environ.h: Rename include guard.
932         * common/common-utils.h: Rename include guard.
933         * common/common-types.h: Rename include guard.
934         * common/common-regcache.h: Rename include guard.
935         * common/common-inferior.h: Rename include guard.
936         * common/common-gdbthread.h: Rename include guard.
937         * common/common-exceptions.h: Rename include guard.
938         * common/common-defs.h: Rename include guard.
939         * common/common-debug.h: Rename include guard.
940         * common/cleanups.h: Rename include guard.
941         * common/buffer.h: Rename include guard.
942         * common/btrace-common.h: Rename include guard.
943         * common/break-common.h: Rename include guard.
944         * cli/cli-utils.h: Rename include guard.
945         * cli/cli-style.h: Rename include guard.
946         * cli/cli-setshow.h: Rename include guard.
947         * cli/cli-script.h: Rename include guard.
948         * cli/cli-interp.h: Rename include guard.
949         * cli/cli-decode.h: Rename include guard.
950         * cli/cli-cmds.h: Rename include guard.
951         * charset-list.h: Add include guard.
952         * buildsym-legacy.h: Rename include guard.
953         * bfin-tdep.h: Add include guard.
954         * ax.h: Rename include guard.
955         * arm-linux-tdep.h: Add include guard.
956         * arm-fbsd-tdep.h: Add include guard.
957         * arch/xtensa.h: Rename include guard.
958         * arch/tic6x.h: Add include guard.
959         * arch/i386.h: Add include guard.
960         * arch/arm.h: Rename include guard.
961         * arch/arm-linux.h: Rename include guard.
962         * arch/arm-get-next-pcs.h: Rename include guard.
963         * arch/amd64.h: Add include guard.
964         * arch/aarch64-insn.h: Rename include guard.
965         * arch-utils.h: Rename include guard.
966         * annotate.h: Add include guard.
967         * amd64-darwin-tdep.h: Rename include guard.
968         * aarch64-linux-tdep.h: Add include guard.
969         * aarch64-fbsd-tdep.h: Add include guard.
970         * aarch32-linux-nat.h: Add include guard.
971
972 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
973
974         * macrotab.c (macro_define_internal): New function that
975         factorizes macro_define_object_internal and macro_define_function
976         code.
977         (macro_define_object_internal): Use macro_define_internal.
978         (macro_define_function): Likewise.
979
980 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
981
982         * macrocmd.c (extract_identifier): Return
983         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
984         callers.
985
986 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
987
988         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
989
990 2019-02-05  Tom Tromey  <tom@tromey.com>
991
992         * target.c (target_stack::unpush): Move assertion earlier.
993
994 2019-01-30  Tom Tromey  <tom@tromey.com>
995
996         PR python/23615:
997         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
998         (gdbpy_parse_and_eval): Likewise.
999         * python/python-internal.h (gdbpy_allow_threads): New class.
1000
1001 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1002
1003         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1004         (aarch64_fbsd_fpregmap): Move earlier.
1005         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1006         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1007         instead of individual calls to trad_frame_set_reg_addr.
1008         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1009         earlier.
1010         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1011         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1012         instead of individual calls to trad_frame_set_reg_addr.
1013
1014 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1015
1016         * CONTRIBUTE: Replace contribution list with wiki link.
1017
1018 2019-01-25  Tom Tromey  <tom@tromey.com>
1019
1020         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1021
1022 2019-01-25  Tom Tromey  <tom@tromey.com>
1023
1024         * xtensa-linux-nat.c: Fix common/ includes.
1025         * xml-support.h: Fix common/ includes.
1026         * xml-support.c: Fix common/ includes.
1027         * x86-linux-nat.c: Fix common/ includes.
1028         * windows-nat.c: Fix common/ includes.
1029         * varobj.h: Fix common/ includes.
1030         * varobj.c: Fix common/ includes.
1031         * value.c: Fix common/ includes.
1032         * valops.c: Fix common/ includes.
1033         * utils.c: Fix common/ includes.
1034         * unittests/xml-utils-selftests.c: Fix common/ includes.
1035         * unittests/utils-selftests.c: Fix common/ includes.
1036         * unittests/unpack-selftests.c: Fix common/ includes.
1037         * unittests/tracepoint-selftests.c: Fix common/ includes.
1038         * unittests/style-selftests.c: Fix common/ includes.
1039         * unittests/string_view-selftests.c: Fix common/ includes.
1040         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1041         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1042         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1043         * unittests/rsp-low-selftests.c: Fix common/ includes.
1044         * unittests/parse-connection-spec-selftests.c: Fix common/
1045         includes.
1046         * unittests/optional-selftests.c: Fix common/ includes.
1047         * unittests/offset-type-selftests.c: Fix common/ includes.
1048         * unittests/observable-selftests.c: Fix common/ includes.
1049         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1050         * unittests/memrange-selftests.c: Fix common/ includes.
1051         * unittests/memory-map-selftests.c: Fix common/ includes.
1052         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1053         * unittests/function-view-selftests.c: Fix common/ includes.
1054         * unittests/environ-selftests.c: Fix common/ includes.
1055         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1056         * unittests/common-utils-selftests.c: Fix common/ includes.
1057         * unittests/cli-utils-selftests.c: Fix common/ includes.
1058         * unittests/array-view-selftests.c: Fix common/ includes.
1059         * ui-file.c: Fix common/ includes.
1060         * tui/tui-io.c: Fix common/ includes.
1061         * tracepoint.h: Fix common/ includes.
1062         * tracepoint.c: Fix common/ includes.
1063         * tracefile-tfile.c: Fix common/ includes.
1064         * top.h: Fix common/ includes.
1065         * top.c: Fix common/ includes.
1066         * thread.c: Fix common/ includes.
1067         * target/waitstatus.h: Fix common/ includes.
1068         * target/waitstatus.c: Fix common/ includes.
1069         * target.h: Fix common/ includes.
1070         * target.c: Fix common/ includes.
1071         * target-memory.c: Fix common/ includes.
1072         * target-descriptions.c: Fix common/ includes.
1073         * symtab.h: Fix common/ includes.
1074         * symfile.c: Fix common/ includes.
1075         * stap-probe.c: Fix common/ includes.
1076         * spu-linux-nat.c: Fix common/ includes.
1077         * sparc-nat.c: Fix common/ includes.
1078         * source.c: Fix common/ includes.
1079         * solib.c: Fix common/ includes.
1080         * solib-target.c: Fix common/ includes.
1081         * ser-unix.c: Fix common/ includes.
1082         * ser-tcp.c: Fix common/ includes.
1083         * ser-pipe.c: Fix common/ includes.
1084         * ser-base.c: Fix common/ includes.
1085         * selftest-arch.c: Fix common/ includes.
1086         * s12z-tdep.c: Fix common/ includes.
1087         * rust-exp.y: Fix common/ includes.
1088         * rs6000-aix-tdep.c: Fix common/ includes.
1089         * riscv-tdep.c: Fix common/ includes.
1090         * remote.c: Fix common/ includes.
1091         * remote-notif.h: Fix common/ includes.
1092         * remote-fileio.h: Fix common/ includes.
1093         * remote-fileio.c: Fix common/ includes.
1094         * regcache.h: Fix common/ includes.
1095         * regcache.c: Fix common/ includes.
1096         * record-btrace.c: Fix common/ includes.
1097         * python/python.c: Fix common/ includes.
1098         * python/py-type.c: Fix common/ includes.
1099         * python/py-inferior.c: Fix common/ includes.
1100         * progspace.h: Fix common/ includes.
1101         * producer.c: Fix common/ includes.
1102         * procfs.c: Fix common/ includes.
1103         * proc-api.c: Fix common/ includes.
1104         * printcmd.c: Fix common/ includes.
1105         * ppc-linux-nat.c: Fix common/ includes.
1106         * parser-defs.h: Fix common/ includes.
1107         * osdata.c: Fix common/ includes.
1108         * obsd-nat.c: Fix common/ includes.
1109         * nat/x86-linux.c: Fix common/ includes.
1110         * nat/x86-linux-dregs.c: Fix common/ includes.
1111         * nat/x86-dregs.h: Fix common/ includes.
1112         * nat/x86-dregs.c: Fix common/ includes.
1113         * nat/ppc-linux.c: Fix common/ includes.
1114         * nat/mips-linux-watch.h: Fix common/ includes.
1115         * nat/mips-linux-watch.c: Fix common/ includes.
1116         * nat/linux-waitpid.c: Fix common/ includes.
1117         * nat/linux-ptrace.h: Fix common/ includes.
1118         * nat/linux-ptrace.c: Fix common/ includes.
1119         * nat/linux-procfs.c: Fix common/ includes.
1120         * nat/linux-personality.c: Fix common/ includes.
1121         * nat/linux-osdata.c: Fix common/ includes.
1122         * nat/linux-namespaces.c: Fix common/ includes.
1123         * nat/linux-btrace.h: Fix common/ includes.
1124         * nat/linux-btrace.c: Fix common/ includes.
1125         * nat/fork-inferior.c: Fix common/ includes.
1126         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1127         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1128         * nat/aarch64-linux.c: Fix common/ includes.
1129         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1130         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1131         * namespace.h: Fix common/ includes.
1132         * mips-linux-tdep.c: Fix common/ includes.
1133         * minsyms.c: Fix common/ includes.
1134         * mi/mi-parse.h: Fix common/ includes.
1135         * mi/mi-main.c: Fix common/ includes.
1136         * mi/mi-cmd-env.c: Fix common/ includes.
1137         * memrange.h: Fix common/ includes.
1138         * memattr.c: Fix common/ includes.
1139         * maint.h: Fix common/ includes.
1140         * maint.c: Fix common/ includes.
1141         * main.c: Fix common/ includes.
1142         * machoread.c: Fix common/ includes.
1143         * location.c: Fix common/ includes.
1144         * linux-thread-db.c: Fix common/ includes.
1145         * linux-nat.c: Fix common/ includes.
1146         * linux-fork.c: Fix common/ includes.
1147         * inline-frame.c: Fix common/ includes.
1148         * infrun.c: Fix common/ includes.
1149         * inflow.c: Fix common/ includes.
1150         * inferior.h: Fix common/ includes.
1151         * inferior.c: Fix common/ includes.
1152         * infcmd.c: Fix common/ includes.
1153         * inf-ptrace.c: Fix common/ includes.
1154         * inf-child.c: Fix common/ includes.
1155         * ia64-linux-nat.c: Fix common/ includes.
1156         * i387-tdep.c: Fix common/ includes.
1157         * i386-tdep.c: Fix common/ includes.
1158         * i386-linux-tdep.c: Fix common/ includes.
1159         * i386-linux-nat.c: Fix common/ includes.
1160         * i386-go32-tdep.c: Fix common/ includes.
1161         * i386-fbsd-tdep.c: Fix common/ includes.
1162         * i386-fbsd-nat.c: Fix common/ includes.
1163         * guile/scm-type.c: Fix common/ includes.
1164         * guile/guile.c: Fix common/ includes.
1165         * go32-nat.c: Fix common/ includes.
1166         * gnu-nat.c: Fix common/ includes.
1167         * gdbthread.h: Fix common/ includes.
1168         * gdbarch-selftests.c: Fix common/ includes.
1169         * gdb_usleep.c: Fix common/ includes.
1170         * gdb_select.h: Fix common/ includes.
1171         * gdb_bfd.c: Fix common/ includes.
1172         * gcore.c: Fix common/ includes.
1173         * fork-child.c: Fix common/ includes.
1174         * findvar.c: Fix common/ includes.
1175         * fbsd-nat.c: Fix common/ includes.
1176         * event-top.c: Fix common/ includes.
1177         * event-loop.c: Fix common/ includes.
1178         * dwarf2read.c: Fix common/ includes.
1179         * dwarf2loc.c: Fix common/ includes.
1180         * dwarf2-frame.c: Fix common/ includes.
1181         * dwarf-index-cache.c: Fix common/ includes.
1182         * dtrace-probe.c: Fix common/ includes.
1183         * disasm-selftests.c: Fix common/ includes.
1184         * defs.h: Fix common/ includes.
1185         * csky-tdep.c: Fix common/ includes.
1186         * cp-valprint.c: Fix common/ includes.
1187         * cp-support.h: Fix common/ includes.
1188         * cp-support.c: Fix common/ includes.
1189         * corelow.c: Fix common/ includes.
1190         * completer.h: Fix common/ includes.
1191         * completer.c: Fix common/ includes.
1192         * compile/compile.c: Fix common/ includes.
1193         * compile/compile-loc2c.c: Fix common/ includes.
1194         * compile/compile-cplus-types.c: Fix common/ includes.
1195         * compile/compile-cplus-symbols.c: Fix common/ includes.
1196         * command.h: Fix common/ includes.
1197         * cli/cli-dump.c: Fix common/ includes.
1198         * cli/cli-cmds.c: Fix common/ includes.
1199         * charset.c: Fix common/ includes.
1200         * build-id.c: Fix common/ includes.
1201         * btrace.h: Fix common/ includes.
1202         * btrace.c: Fix common/ includes.
1203         * breakpoint.h: Fix common/ includes.
1204         * breakpoint.c: Fix common/ includes.
1205         * ax.h: 
1206         (enum agent_op): Fix common/ includes.
1207         * ax-general.c (struct aop_map): Fix common/ includes.
1208         * ax-gdb.c: Fix common/ includes.
1209         * auxv.c: Fix common/ includes.
1210         * auto-load.c: Fix common/ includes.
1211         * arm-tdep.c: Fix common/ includes.
1212         * arch/riscv.c: Fix common/ includes.
1213         * arch/ppc-linux-common.c: Fix common/ includes.
1214         * arch/i386.c: Fix common/ includes.
1215         * arch/arm.c: Fix common/ includes.
1216         * arch/arm-linux.c: Fix common/ includes.
1217         * arch/arm-get-next-pcs.c: Fix common/ includes.
1218         * arch/amd64.c: Fix common/ includes.
1219         * arch/aarch64.c: Fix common/ includes.
1220         * arch/aarch64-insn.c: Fix common/ includes.
1221         * arch-utils.c: Fix common/ includes.
1222         * amd64-windows-tdep.c: Fix common/ includes.
1223         * amd64-tdep.c: Fix common/ includes.
1224         * amd64-sol2-tdep.c: Fix common/ includes.
1225         * amd64-obsd-tdep.c: Fix common/ includes.
1226         * amd64-nbsd-tdep.c: Fix common/ includes.
1227         * amd64-linux-tdep.c: Fix common/ includes.
1228         * amd64-linux-nat.c: Fix common/ includes.
1229         * amd64-fbsd-tdep.c: Fix common/ includes.
1230         * amd64-fbsd-nat.c: Fix common/ includes.
1231         * amd64-dicos-tdep.c: Fix common/ includes.
1232         * amd64-darwin-tdep.c: Fix common/ includes.
1233         * agent.c: Fix common/ includes.
1234         * ada-lang.h: Fix common/ includes.
1235         * ada-lang.c: Fix common/ includes.
1236         * aarch64-tdep.c: Fix common/ includes.
1237
1238 2019-01-25  Tom Tromey  <tom@tromey.com>
1239
1240         * common/create-version.sh: Use common/version.h.
1241
1242 2019-01-24  Pedro Alves  <palves@redhat.com>
1243
1244         * infrun.c (signal_stop, signal_print, signal_program)
1245         (signal_catch, signal_pass): Now arrays instead of pointers.
1246         (update_signals_program_target, do_target_resume)
1247         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1248         * linux-nat.c (linux_nat_target::pass_signals)
1249         (linux_nat_target::create_inferior, linux_nat_target::attach):
1250         Adjust.
1251         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1252         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1253         * procfs.c (procfs_target::pass_signals): Adjust.
1254         * record-full.c (record_full_target::resume): Adjust.
1255         * remote.c (remote_target::pass_signals)
1256         (remote_target::program_signals): Adjust.
1257         * target-debug.h (target_debug_print_signals): Now takes a
1258         gdb::array_view as parameter.  Adjust.
1259         * target.h (target_ops) <pass_signals, program_signals>: Replace
1260         pointer and length parameters with gdb::array_view.
1261         (target_pass_signals, target_program_signals): Likewise.
1262         * target-delegates.c: Regenerate.
1263
1264 2019-01-24  Pedro Alves  <palves@redhat.com>
1265
1266         * common/forward-scope-exit.h
1267         (forward_scope_exit::forward_scope_exit): Pass arguments to
1268         m_bind_function directly, instead of creating a std::bind and
1269         copying that.
1270
1271 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1272
1273         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1274         for static members.
1275         (pass_in_v_vfp_candidate): Likewise.
1276
1277 2019-01-23  Tom Tromey  <tom@tromey.com>
1278             Pedro Alves  <palves@redhat.com>
1279
1280         * regcache.c (class regcache_invalidator): Remove.
1281         (regcache::raw_write): Use make_scope_exit.
1282
1283 2019-01-23  Tom Tromey  <tom@tromey.com>
1284
1285         * ui-out.h (class ui_out_emit_type): Update comment.
1286
1287 2019-01-23  Tom Tromey  <tom@tromey.com>
1288
1289         * infrun.c (fetch_inferior_event): Update comment.
1290
1291 2019-01-23  Tom Tromey  <tom@tromey.com>
1292             Pedro Alves  <palves@redhat.com>
1293
1294         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1295         parameter.
1296         (fetch_inferior_event): Use SCOPE_EXIT.
1297
1298
1299 2019-01-23  Tom Tromey  <tom@tromey.com>
1300             Pedro Alves  <palves@redhat.com>
1301
1302         * infrun.c (disable_thread_events): Delete.
1303         (stop_all_threads): Use SCOPE_EXIT.
1304
1305 2019-01-23  Tom Tromey  <tom@tromey.com>
1306             Pedro Alves  <palves@redhat.com>
1307
1308         * symfile.c: Include forward-scope-exit.h.
1309         (clear_symtab_users_cleanup): Replace forward declaration with
1310         a FORWARD_SCOPE_EXIT.
1311         (syms_from_objfile_1): Use the forward_scope_exit and
1312         gdb::optional instead of cleanup_function.
1313         (reread_symbols): Use the forward_scope_exit instead of
1314         cleanup_function.
1315         (clear_symtab_users_cleanup): Remove function.
1316
1317 2019-01-23  Tom Tromey  <tom@tromey.com>
1318             Pedro Alves  <palves@redhat.com>
1319
1320         * linux-nat.c: Include scope-exit.h.
1321         (cleanup_target_stop): Remove.
1322         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1323         SCOPE_EXIT.
1324
1325 2019-01-23  Tom Tromey  <tom@tromey.com>
1326             Pedro Alves  <palves@redhat.com>
1327
1328         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1329         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1330
1331 2019-01-23  Tom Tromey  <tom@tromey.com>
1332             Andrew Burgess  <andrew.burgess@embecosm.com>
1333             Pedro Alves  <palves@redhat.com>
1334
1335         * infrun.c (fetch_inferior_event): Use scope_exit.
1336         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1337         * top.c (execute_command): Use scope_exit.
1338         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1339         * utils.c (do_bpstat_clear_actions_cleanup)
1340         (make_bpstat_clear_actions_cleanup): Remove.
1341
1342 2019-01-23  Tom Tromey  <tom@tromey.com>
1343             Pedro Alves  <palves@redhat.com>
1344
1345         * infrun.c: Include "common/scope-exit.h"
1346         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1347         (wait_for_inferior): Use SCOPE_EXIT.
1348         (fetch_inferior_event): Use scope_exit.
1349
1350 2019-01-23  Tom Tromey  <tom@tromey.com>
1351             Pedro Alves  <palves@redhat.com>
1352
1353         * breakpoint.c (create_breakpoint): Remove cleanup.
1354
1355 2019-01-23  Tom Tromey  <tom@tromey.com>
1356             Andrew Burgess  <andrew.burgess@embecosm.com>
1357             Pedro Alves  <palves@redhat.com>
1358
1359 2019-01-23  Pedro Alves  <palves@redhat.com>
1360
1361         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1362
1363 2019-01-23  Pedro Alves  <palves@redhat.com>
1364             Andrew Burgess  <andrew.burgess@embecosm.com>
1365
1366         * gdbthread.h: Include "common/forward-scope-exit.h".
1367         (scoped_finish_thread_state): Redefine custom class in terms of
1368         forward_scope_exit.
1369
1370 2019-01-23  Pedro Alves  <palves@redhat.com>
1371             Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * common/forward-scope-exit.h: New file.
1374
1375 2019-01-23  Pedro Alves  <palves@redhat.com>
1376             Andrew Burgess  <andrew.burgess@embecosm.com>
1377             Tom Tromey  <tom@tromey.com>
1378
1379         * common/scope-exit.h: New file.
1380
1381 2019-01-23  Pedro Alves  <palves@redhat.com>
1382
1383         * common/preprocessor.h (ESC): Rename to ...
1384         (ESC_PARENS): ... this.
1385         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1386         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1387
1388 2019-01-23  Tom Tromey  <tom@tromey.com>
1389
1390         * language.h (class scoped_switch_to_sym_language_if_auto):
1391         Initialize m_lang in both cases.
1392
1393 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1394
1395         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1396         with XCNEW.
1397
1398 2019-01-22  Tom Tromey  <tom@tromey.com>
1399
1400         * corelow.c: Do not include sys/file.h.
1401
1402 2019-01-22  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-wingeneral.h: Include gdb_curses.h.
1405
1406 2019-01-22  Tom Tromey  <tom@tromey.com>
1407
1408         * source-cache.h (class source_cache) <get_source_lines,
1409         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1410
1411 2019-01-22  Tom Tromey  <tom@tromey.com>
1412
1413         * remote-fileio.h (struct remote_target): Declare.
1414
1415 2019-01-22  Tom Tromey  <tom@tromey.com>
1416
1417         * python/py-arch.c: Do not include py-ref.h.
1418         * python/py-bpevent.c: Do not include py-ref.h.
1419         * python/py-cmd.c: Do not include py-ref.h.
1420         * python/py-continueevent.c: Do not include py-ref.h.
1421         * python/py-event.h: Do not include py-ref.h.
1422         * python/py-evtregistry.c: Do not include py-ref.h.
1423         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1424         * python/py-frame.c: Do not include py-ref.h.
1425         * python/py-framefilter.c: Do not include py-ref.h.
1426         * python/py-function.c: Do not include py-ref.h.
1427         * python/py-infevents.c: Do not include py-ref.h.
1428         * python/py-linetable.c: Do not include py-ref.h.
1429         * python/py-objfile.c: Do not include py-ref.h.
1430         * python/py-param.c: Do not include py-ref.h.
1431         * python/py-prettyprint.c: Do not include py-ref.h.
1432         * python/py-progspace.c: Do not include py-ref.h.
1433         * python/py-symbol.c: Do not include py-ref.h.
1434         * python/py-symtab.c: Do not include py-ref.h.
1435         * python/py-type.c: Do not include py-ref.h.
1436         * python/py-unwind.c: Do not include py-ref.h.
1437         * python/py-utils.c: Do not include py-ref.h.
1438         * python/py-value.c: Do not include py-ref.h.
1439         * python/py-varobj.c: Do not include py-ref.h.
1440         * python/py-xmethods.c: Do not include py-ref.h.
1441         * python/python.c: Do not include py-ref.h.
1442         * varobj.c: Do not include py-ref.h.
1443
1444 2019-01-22  Tom Tromey  <tom@tromey.com>
1445
1446         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1447         keyword for bcache.
1448
1449 2019-01-22  Tom Tromey  <tom@tromey.com>
1450
1451         * compile/compile-cplus-types.c: Remove a comment by #include.
1452
1453 2019-01-22  Tom Tromey  <tom@tromey.com>
1454
1455         * compile/gcc-c-plugin.h: Include compile-internal.h.
1456
1457 2019-01-22  Tom Tromey  <tom@tromey.com>
1458
1459         * stabsread.c (EXTERN): Do not define.
1460         (symnum, next_symbol_text_func, processing_gcc_compilation)
1461         (within_function, global_sym_chain, global_stabs)
1462         (previous_stab_code, this_object_header_files)
1463         (n_this_object_header_files)
1464         (n_allocated_this_object_header_files): Define.
1465         * stabsread.h (EXTERN): Never define.  Use "extern".
1466
1467 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1468
1469         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1470         history_value.
1471
1472 2019-01-21  Tom Tromey  <tom@tromey.com>
1473
1474         * ui-out.c: Fix includes.
1475         * tui/tui-source.c: Fix includes.
1476         * target.c: Fix includes.
1477         * remote.c: Fix includes.
1478         * regcache.c: Fix includes.
1479         * python/py-block.c: Fix includes.
1480         * printcmd.c: Fix includes.
1481         * or1k-tdep.c: Fix includes.
1482         * mi/mi-main.c: Fix includes.
1483         * m32r-tdep.c: Fix includes.
1484         * csky-tdep.c: Fix includes.
1485         * compile/compile-cplus-types.c: Fix includes.
1486         * cli/cli-interp.c: Fix includes.
1487
1488 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1489
1490         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1491         for padding.
1492
1493 2019-01-16  Tom Tromey  <tom@tromey.com>
1494
1495         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1496         earlier.
1497         (struct objfile) <msymbols_range>: Move from top level.
1498         <msymbols>: New method.
1499         (class objfile_msymbols): Remove.
1500         * symtab.c (default_collect_symbol_completion_matches_break_on):
1501         Update.
1502         * symmisc.c (dump_msymbols): Update.
1503         * stabsread.c (scan_file_globals): Update.
1504         * objc-lang.c (info_selectors_command, info_classes_command)
1505         (find_methods): Update.
1506         * minsyms.c (find_solib_trampoline_target): Update.
1507         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1508         * coffread.c (coff_symfile_read): Update.
1509         * ada-lang.c (ada_lookup_simple_minsym)
1510         (ada_collect_symbol_completion_matches): Update.
1511
1512 2019-01-16  Tom Tromey  <tom@tromey.com>
1513
1514         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1515         type.  Remove no-argument constructor.
1516         <iterator::operator++>: Simplify.
1517         <begin>: Update.
1518         <end>: Use minimal_symbol_count.
1519
1520 2019-01-16  Tom Tromey  <tom@tromey.com>
1521
1522         * objfiles.h (struct objfile) <psymtabs>: New method.
1523         (class objfile_psymtabs): Remove.
1524         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1525         typedef.
1526         <range>: New method.
1527         (require_partial_symbols): Change return type.
1528         * psymtab.c (require_partial_symbols)
1529         (psym_expand_symtabs_matching): Update.
1530         * mdebugread.c (parse_partial_symbols): Update.
1531         * dbxread.c (dbx_end_psymtab): Update.
1532
1533 2019-01-15  Tom Tromey  <tom@tromey.com>
1534
1535         * symtab.c (lookup_objfile_from_block)
1536         (lookup_symbol_in_objfile_symtabs)
1537         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1538         (find_line_symtab, info_sources_command)
1539         (default_collect_symbol_completion_matches_break_on)
1540         (make_source_files_completion_list): Update.
1541         * symmisc.c (print_objfile_statistics, dump_objfile)
1542         (maintenance_print_symbols, maintenance_info_symtabs)
1543         (maintenance_check_symtabs, maintenance_info_line_tables):
1544         Update.
1545         * source.c (select_source_symtab)
1546         (forget_cached_source_info_for_objfile): Update.
1547         * objfiles.h (class objfile_compunits): Remove.
1548         (struct objfile) <compunits_range>: New typedef.
1549         (compunits): New method.
1550         * objfiles.c (objfile_relocate1): Update.
1551         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1552         * maint.c (count_symtabs_and_blocks): Update.
1553         * linespec.c (iterate_over_all_matching_symtabs): Update.
1554         * cp-support.c (add_symbol_overload_list_qualified): Update.
1555         * coffread.c (coff_symtab_read): Update.
1556         * ada-lang.c (add_nonlocal_symbols)
1557         (ada_collect_symbol_completion_matches)
1558         (ada_add_global_exceptions): Update.
1559
1560 2019-01-15  Tom Tromey  <tom@tromey.com>
1561
1562         * progspace.h (program_space) <objfiles_safe_range>: New
1563         typedef.
1564         <objfiles_safe>: New method.
1565         * objfiles.h (class all_objfiles_safe): Remove.
1566         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1567         * jit.c (jit_inferior_exit_hook): Update.
1568
1569 2019-01-17  Tom Tromey  <tom@tromey.com>
1570
1571         * progspace.h (program_space) <objfiles_range>: New typedef.
1572         <objfiles>: New method.
1573         <objfiles_head>: Rename from objfiles.
1574         (object_files): Update.
1575         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1576         * guile/scm-pretty-print.c
1577         (ppscm_find_pretty_printer_from_objfiles): Update.
1578         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1579         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1580         Update.
1581         * python/py-progspace.c (pspy_get_objfiles): Update.
1582         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1583         Update.
1584         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1585         (objfpy_lookup_objfile_by_build_id): Update.
1586         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1587         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1588         Update.
1589         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1590         (expand_symtab_containing_pc, lookup_objfile_from_block)
1591         (lookup_static_symbol, basic_lookup_transparent_type)
1592         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1593         (find_line_symtab, info_sources_command)
1594         (default_collect_symbol_completion_matches_break_on)
1595         (make_source_files_completion_list, find_main_name): Update.
1596         * symmisc.c (print_symbol_bcache_statistics)
1597         (print_objfile_statistics, maintenance_print_symbols)
1598         (maintenance_print_msymbols, maintenance_print_objfiles)
1599         (maintenance_info_symtabs, maintenance_check_symtabs)
1600         (maintenance_expand_symtabs, maintenance_info_line_tables):
1601         Update.
1602         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1603         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1604         (map_overlay_command, unmap_overlay_command)
1605         (simple_overlay_update, expand_symtabs_matching)
1606         (map_symbol_filenames): Update.
1607         * symfile-debug.c (set_debug_symfile): Update.
1608         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1609         Update.
1610         * source.c (select_source_symtab, forget_cached_source_info):
1611         Update.
1612         * solib.c (solib_read_symbols): Update.
1613         * solib-spu.c (append_ocl_sos): Update.
1614         * psymtab.c (maintenance_print_psymbols)
1615         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1616         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1617         * printcmd.c (info_symbol_command): Update.
1618         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1619         Update.
1620         * objfiles.h (class all_objfiles): Remove.
1621         * objfiles.c (have_partial_symbols, have_full_symbols)
1622         (have_minimal_symbols, qsort_cmp, update_section_map)
1623         (shared_objfile_contains_address_p)
1624         (default_iterate_over_objfiles_in_search_order): Update.
1625         * objc-lang.c (info_selectors_command, info_classes_command)
1626         (find_methods): Update.
1627         * minsyms.c (find_solib_trampoline_target): Update.
1628         * maint.c (maintenance_info_sections)
1629         (maintenance_translate_address, count_symtabs_and_blocks):
1630         Update.
1631         * main.c (captured_main_1): Update.
1632         * linux-thread-db.c (try_thread_db_load_from_pdir)
1633         (has_libpthread): Update.
1634         * linespec.c (iterate_over_all_matching_symtabs)
1635         (search_minsyms_for_name): Update.
1636         * jit.c (jit_find_objf_with_entry_addr): Update.
1637         * hppa-tdep.c (find_unwind_entry)
1638         (hppa_lookup_stub_minimal_symbol): Update.
1639         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1640         Update.
1641         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1642         (elf_gnu_ifunc_resolve_by_got): Update.
1643         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1644         * dwarf-index-write.c (save_gdb_index_command): Update.
1645         * cp-support.c (add_symbol_overload_list_qualified): Update.
1646         * breakpoint.c (create_overlay_event_breakpoint)
1647         (create_longjmp_master_breakpoint)
1648         (create_std_terminate_master_breakpoint)
1649         (create_exception_master_breakpoint): Update.
1650         * blockframe.c (find_pc_partial_function): Update.
1651         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1652         (ada_collect_symbol_completion_matches)
1653         (ada_add_global_exceptions): Update.
1654
1655 2019-01-17  Tom Tromey  <tom@tromey.com>
1656
1657         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1658         declare VEC.
1659         (solib_target_parse_libraries): Change return type.
1660         (library_list_start_segment, library_list_start_section)
1661         (library_list_end_library, library_list_start_library); Update.
1662         (solib_target_free_library_list): Remove.
1663         (solib_target_parse_libraries): Remove cleanup.  Change return
1664         type.
1665         (solib_target_current_sos): Update.
1666
1667 2019-01-17  Tom Tromey  <tromey@bapiya>
1668
1669         * valprint.c: Replace "the the" with "the".
1670         * symtab.c: Replace "the the" with "the".
1671         * solib.c: Replace "the the" with "the".
1672         * solib-dsbt.c: Replace "the the" with "the".
1673         * linespec.c: Replace "the the" with "the".
1674         * dwarf2loc.h: Replace "the the" with "the".
1675         * amd64-windows-tdep.c: Replace "the the" with "the".
1676         * aarch64-tdep.c: Replace "the the" with "the".
1677
1678 2019-01-16  Keith Seitz  <keiths@redhat.com>
1679
1680         PR gdb/23773
1681         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1682         <builder>: Rename to ..
1683         <m_builder>: ... this and make private.
1684         (dwarf2_cu::get_builder): New method.  Change all users of
1685         `builder' to use this method.
1686         (dwarf2_start_symtab): Move to ...
1687         (dwarf2_cu::start_symtab): ... here.  Update all callers
1688         (setup_type_unit_groups): Move to ...
1689         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1690         callers.
1691         (dwarf2_cu::reset_builder): New method.
1692         (process_full_compunit, process_full_type_unit): Use
1693         dwarf2_cu::reset_builder.
1694         (follow_die_offset): Record the ancestor CU if it is different
1695         from the followed DIE's CU.
1696         (follow_die_sig_1): Likewise.
1697
1698 2019-01-15  Tom Tromey  <tom@tromey.com>
1699
1700         * remote.c (class remote_state) <buf>: Now a char_vector.
1701         <buf_size>: Remove.
1702         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1703         parameter.
1704         (remote_target::getpkt_or_notif_sane_1)
1705         (remote_target::getpkt_sane)
1706         (remote_target::getpkt_or_notif_sane): Likewise.
1707         (class remote_target) <putpkt>: New overload.
1708         (remote_target::read_frame): Change type of "buf_p".  Remove
1709         sizeof_p parameter.
1710         (packet_ok): New overload.
1711         (packet_check_result): New overload.
1712         Update all uses.
1713
1714 2019-01-14  Tom Tromey  <tom@tromey.com>
1715
1716         * remote-notif.c (handle_notification, remote_notif_ack)
1717         (remote_notif_parse): Make "buf" const.
1718         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1719         const.
1720         (remote_notif_parse, remote_notif_ack, handle_notification):
1721         Likewise.
1722         * remote.c (remote_notif_stop_parse): Make "buf" const.
1723         (remote_target::remote_parse_stop_reply): Make "buf" const.
1724         (remote_notif_stop_ack): Make "buf" const.
1725
1726 2019-01-14  Tom Tromey  <tom@tromey.com>
1727
1728         * remote.c (remote_console_output): Make parameter const.
1729
1730 2019-01-14  Tom Tromey  <tom@tromey.com>
1731
1732         * target-debug.h (target_debug_print_signals): Constify.
1733         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1734         * procfs.c (procfs_target::pass_signals): Update.
1735         * linux-nat.c (linux_nat_target::pass_signals): Update.
1736         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1737         * target-delegates.c: Rebuild.
1738         * remote.c (remote_target::program_signals): Update.
1739         (remote_target::pass_signals): Update.
1740         * target.c (target_pass_signals): Constify argument.
1741         (target_program_signals): Likewise.
1742         * target.h (struct target_ops) <pass_signals, program_signals>:
1743         Constify argument.
1744         (target_pass_signals, target_program_signals): Constify argument.
1745
1746 2019-01-14  Tom Tromey  <tom@tromey.com>
1747
1748         PR tui/28819:
1749         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1750
1751 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1752
1753         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1754         field.
1755         * rs6000-tdep.c: Include reggroups.h.
1756         (IS_V_ALIAS_PSEUDOREG): Define.
1757         (rs6000_register_name): Return names for the "vX" aliases.
1758         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1759         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1760         aliases.  Call default_register_reggroup_p for all other
1761         pseudo-registers.
1762         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1763         New functions.
1764         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1765         Handle "vX" aliases.
1766         (v_alias_pseudo_register_collect): New function.
1767         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1768         (rs6000_gdbarch_init): Initialize "vX" aliases as
1769         pseudo-registers.  Restore registration of
1770         rs6000_pseudo_register_reggroup_p with
1771         set_tdesc_pseudo_register_reggroup_p.
1772
1773 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1774
1775         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1776         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1777         set_gdbarch_num_pseudo_regs.
1778
1779 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1780
1781         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1782         Remove arg prefixname, add do_set and do_show.
1783         Add member functions set_list and show_list.
1784         * cli/cli-style.c (class cli_style_option): Update accordingly.
1785         (style_set_list): Move to file scope.
1786         (style_show_list): Likewise.
1787         (set_style): Call help_list.
1788         (show_style): Call cmd_show_list.
1789         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1790         Update to use the new macro.
1791
1792 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1793
1794         * ada-lang.c (_initialize_ada_language): Expand the help text
1795         for the "catch exception" command.
1796
1797 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1798
1799         * symtab.c (matching_obj_sections): Initialize obj,
1800         declare it closer to its usage.
1801
1802 2019-01-10  Tom Tromey  <tom@tromey.com>
1803
1804         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1805         (basic_inf_threads_range): Remove.
1806         (inf_threads_range, inf_non_exited_threads_range)
1807         (safe_inf_threads_range): Use next_adapter.
1808
1809 2019-01-10  Keith Seitz  <keiths@redhat.com>
1810
1811         PR gdb/23712
1812         PR symtab/23010
1813         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1814         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1815
1816 2019-01-10  Keith Seitz  <keiths@redhat.com>
1817
1818         PR gdb/23712
1819         PR symtab/23010
1820         * dictionary.c (pending_to_vector): Remove.
1821         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1822         Remove _1 suffix, replacing functions of the same name.  Update
1823         all callers.
1824         (dict_create_hashed, dict_create_hashed_expandable)
1825         (dict_create_linear, dict_create_linear_expandable, dict_free)
1826         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1827         Make functions static.
1828
1829 2019-01-10  Keith Seitz  <keiths@redhat.com>
1830
1831         PR gdb/23712
1832         PR symtab/23010
1833         * dictionary.h (struct dictionary): Replace declaration with
1834         multidictionary.
1835         (dict_create_hashed, dict_create_hashed_expandable)
1836         (dict_create_linear, dict_create_linear_expandable)
1837         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1838         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1839         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1840         taking multidictionary argument.
1841         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1842         * block.h (struct block) <dict>: Change to multidictionary
1843         and rename `multidict'.
1844         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1845         symmisc.c: Update all dictionary references to multidictionary.
1846
1847 2019-01-10  Keith Seitz  <keiths@redhat.com>
1848
1849         PR gdb/23712
1850         PR symtab/23010
1851         * dictionary.c: Include unordered_map.
1852         (pending_to_vector): New function.
1853         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1854         Rewrite the non-"_1" functions to take vector instead
1855         of linked list.
1856         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1857         "new" _1 versions of the same name.
1858         (multidictionary): Define.
1859         (std::hash<enum language): New definition.
1860         (collate_pending_symbols_by_language, mdict_create_hashed)
1861         (mdict_create_hashed_expandable, mdict_create_linear)
1862         (mdict_create_linear_expandable, mdict_free)
1863         (find_language_dictionary, create_new_language_dictionary)
1864         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1865         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1866         (mdict_size, mdict_empty): New functions.
1867         * dictionary.h (mdict_iterator): Define.
1868
1869 2019-01-10  Pedro Alves  <palves@redhat.com>
1870
1871         * breakpoint.c (read_uploaded_action)
1872         (create_tracepoint_from_upload): Adjust to use
1873         gdb::unique_xmalloc_ptr.
1874         * ctf.c (ctf_write_uploaded_tp):
1875         (SET_ARRAY_FIELD): Use emplace_back.
1876         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1877         * tracefile-tfile.c (tfile_write_uploaded_tp):
1878         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1879         gdb::unique_xmalloc_ptr.
1880         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1881         at_string, cond_string, cmd_strings>: Replace char pointers
1882         with gdb::unique_xmalloc_ptr.
1883
1884 2019-01-10  Pedro Alves  <palves@redhat.com>
1885
1886         * solib-target.c (library_list_start_library): Don't xstrdup name.
1887
1888 2019-01-10  Pedro Alves  <palves@redhat.com>
1889
1890         * mdebugread.c (parse_partial_symbols): Use
1891         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1892
1893 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1894
1895         * linux-fork.c (scoped_switch_fork_info)
1896         <~scoped_switch_fork_info>: Fix incorrect variable name.
1897
1898 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * linux-fork.c (scoped_switch_fork_info)
1901         <scoped_switch_fork_info>: Make explicit.
1902         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1903
1904 2019-01-10  Tom Tromey  <tom@tromey.com>
1905
1906         * objfiles.h (objfile::reset_psymtabs): Update.
1907         * objfiles.c (objfile::objfile): Update.
1908         * psymtab.h (psymtab_storage::obstack): Update.
1909         (psymtab_storage::m_obstack): Use gdb::optional.
1910         (class psymtab_storage): Update comment.  Remove objfile
1911         parameter.
1912         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1913
1914 2019-01-10  Tom Tromey  <tom@tromey.com>
1915
1916         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1917         <free_psymtabs>: Now private.
1918         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1919         (allocate_psymtab): Use new method.
1920
1921 2019-01-10  Tom Tromey  <tom@tromey.com>
1922
1923         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1924         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1925         * mdebugread.c (parse_partial_symbols): Use
1926         allocate_dependencies.
1927         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1928         allocate_dependencies.
1929         (process_psymtab_comp_unit_reader)
1930         (build_type_psymtab_dependencies): Likewise.
1931         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1932
1933 2019-01-10  Tom Tromey  <tom@tromey.com>
1934
1935         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1936         PSYMBOL_SET_LANGUAGE.
1937         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1938
1939 2019-01-10  Tom Tromey  <tom@tromey.com>
1940
1941         * psymtab.h (psymtab_storage::obstack): New method.
1942         <m_obstack>: Rename from obstack; now private.
1943         * psymtab.c (psymtab_storage): Update.
1944         * dwarf2read.c (create_addrmap_from_index)
1945         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1946         Update.
1947
1948 2019-01-10  Tom Tromey  <tom@tromey.com>
1949
1950         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1951         * objfiles.h (objfile::reset_psymtabs): New method.
1952
1953 2019-01-10  Tom Tromey  <tom@tromey.com>
1954
1955         * symmisc.c (print_symbol_bcache_statistics): Update.
1956         (print_objfile_statistics): Update.
1957         * symfile.c (reread_symbols): Update.
1958         * psymtab.h (class psymtab_storage): New.
1959         * psymtab.c (psymtab_storage): New constructor.
1960         (~psymtab_storage): New destructor.
1961         (require_partial_symbols): Update.
1962         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1963         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1964         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1965         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1966         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1967         (start_psymtab_common, end_psymtab_common)
1968         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1969         (allocate_psymtab): Update.
1970         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1971         Update.
1972         (dump_psymtab_addrmap, maintenance_print_psymbols)
1973         (maintenance_check_psymtabs): Update.
1974         (class objfile_psymtabs): Move to objfiles.h.
1975         * psympriv.h (discard_psymtab): Now inline.
1976         (psymtab_discarder::psymtab_discarder): Update.
1977         (psymtab_discarder::~psymtab_discarder): Update.
1978         (ALL_OBJFILE_PSYMTABS): Rewrite.
1979         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1980         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1981         Remove fields.
1982         <partial_symtabs>: New field.
1983         (class objfile_psymtabs): Move from psymtab.h.  Update.
1984         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1985         psymbol_cache.
1986         (objfile::~objfile): Don't destroy psymbol_cache.
1987         * mdebugread.c (parse_partial_symbols): Update.
1988         * dwarf2read.c (create_addrmap_from_index)
1989         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1990         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1991         (add_partial_subprogram, dwarf2_ranges_read): Update.
1992         * dwarf-index-write.c (write_address_map)
1993         (write_one_signatured_type, recursively_write_psymbols)
1994         (class debug_names, class debug_names, write_psymtabs_to_index):
1995         Update.
1996
1997 2019-01-10  Tom Tromey  <tom@tromey.com>
1998
1999         * symtab.h (SYMBOL_SET_NAMES): Update.
2000         (symbol_set_names): Update.
2001         (MSYMBOL_SET_NAMES): Update.
2002         * symtab.c (symbol_set_names): Change argument to be an
2003         objfile_per_bfd_storage.
2004         * psymtab.c (add_psymbol_to_bcache): Update.
2005         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2006
2007 2019-01-10  Tom Tromey  <tom@tromey.com>
2008
2009         * symtab.c (create_demangled_names_hash): Change argument to be an
2010         objfile_per_bfd_storage.
2011         (symbol_set_names): Update.
2012
2013 2019-01-10  Tom Tromey  <tom@tromey.com>
2014
2015         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2016         init_psymbol_list.
2017         * psymtab.c (init_psymbol_list): Do nothing if already called.
2018         * psympriv.h (init_psymbol_list): Add comment.
2019         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2020         init_psymbol_list.
2021         * dbxread.c (dbx_symfile_read): Unconditionally call
2022         init_psymbol_list.
2023
2024 2019-01-10  Tom Tromey  <tom@tromey.com>
2025
2026         * xcoffread.c (scan_xcoff_symtab): Update.
2027         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2028         "where".
2029         * mdebugread.c (parse_partial_symbols)
2030         (handle_psymbol_enumerators): Update.
2031         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2032         * dbxread.c (read_dbx_symtab): Update.
2033         * psympriv.h (psymbol_placement): New enum.
2034         (add_psymbol_to_list): Update.
2035
2036 2019-01-10  Tom Tromey  <tom@tromey.com>
2037
2038         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2039         static_psymbols parameters.
2040         (scan_xcoff_symtab): Update.
2041         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2042         static_psymbols parameters.
2043         * psympriv.h (start_psymtab_common): Update.
2044         * mdebugread.c (parse_partial_symbols): Update.
2045         * dwarf2read.c (create_partial_symtab): Update.
2046         * dbxread.c (read_dbx_symtab): Update.
2047         (start_psymtab): Remove global_psymbols and static_psymbols
2048         parameters.
2049
2050 2019-01-10  Tom Tromey  <tom@tromey.com>
2051
2052         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2053         * psymtab.c (allocate_psymtab): Add comment.
2054         * psympriv.h (allocate_psymtab): Add comment.
2055         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2056         initializations.
2057         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2058
2059 2019-01-10  Tom Tromey  <tom@tromey.com>
2060
2061         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2062         Don't declare.
2063         * mipsread.c: Include mdebugread.h.
2064         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2065         Declare.
2066         * elfread.c: Include mdebugread.h.
2067
2068 2019-01-09  Tom Tromey  <tom@tromey.com>
2069
2070         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2071         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2072         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2073         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2074         (psym_lookup_symbol, psym_find_last_source_symtab)
2075         (psym_forget_cached_source_info, psym_print_stats)
2076         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2077         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2078         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2079         (psym_find_compunit_symtab_by_address)
2080         (maintenance_print_psymbols, maintenance_info_psymtabs)
2081         (maintenance_check_psymtabs): Use ranged for.
2082         * psymtab.h (class objfile_psymtabs): New.
2083         (require_partial_symbols): Return objfile_psymtabs.
2084         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2085
2086 2019-01-09  Tom Tromey  <tom@tromey.com>
2087
2088         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2089         (find_pc_mapped_section, list_overlays_command)
2090         (map_overlay_command, unmap_overlay_command)
2091         (simple_overlay_update): Use all_objfiles.
2092         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2093         * printcmd.c (info_symbol_command): Use all_objfiles.
2094         * objfiles.h (ALL_OBJSECTIONS): Remove.
2095         * maint.c (maintenance_translate_address): Use all_objfiles.
2096         * gcore.c (gcore_create_callback): Use all_objfiles.
2097         (objfile_find_memory_regions): Likewise.
2098
2099 2019-01-09  Tom Tromey  <tom@tromey.com>
2100
2101         * symtab.c (find_line_symtab, info_sources_command)
2102         (make_source_files_completion_list): Use objfile_compunits.
2103         * source.c (select_source_symtab): Use objfile_compunits.
2104         * objfiles.h (struct objfile): Update comment.
2105         (ALL_OBJFILES): Remove.
2106         (ALL_FILETABS): Remove.
2107         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2108         objfile_compunits.
2109
2110 2019-01-09  Tom Tromey  <tom@tromey.com>
2111
2112         * symmisc.c (print_objfile_statistics, dump_objfile)
2113         (maintenance_print_symbols): Use compunit_filetabs.
2114         * source.c (forget_cached_source_info_for_objfile): Use
2115         compunit_filetabs.
2116         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2117         (ALL_FILETABS): Use compunit_filetabs.
2118         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2119         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2120
2121 2019-01-09  Tom Tromey  <tom@tromey.com>
2122
2123         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2124         (compunit_filetabs): New.
2125         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2126         compunit_filetabs.
2127         (info_sources_command, make_source_files_completion_list): Remove
2128         declaration.
2129         * symmisc.c (print_objfile_statistics, dump_objfile)
2130         (maintenance_print_symbols): Remove declaration.
2131         (maintenance_info_symtabs): Use compunit_filetabs.
2132         (maintenance_info_line_tables): Likewise.
2133         * source.c (select_source_symtab): Change local variable name.
2134         (forget_cached_source_info_for_objfile): Remove declaration.
2135         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2136         * objfiles.c (objfile_relocate1): Remove declaration.
2137         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2138         declaration.
2139         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2140         * coffread.c (coff_symtab_read): Remove declaration.
2141         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2142         compunit_filetabs.
2143
2144 2019-01-09  Tom Tromey  <tom@tromey.com>
2145
2146         * symtab.c (lookup_objfile_from_block)
2147         (find_pc_sect_compunit_symtab, search_symbols)
2148         (default_collect_symbol_completion_matches_break_on): Use
2149         objfile_compunits.
2150         * objfiles.h (ALL_COMPUNITS): Remove.
2151         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2152         * cp-support.c (add_symbol_overload_list_qualified): Use
2153         objfile_compunits.
2154         * ada-lang.c (ada_collect_symbol_completion_matches)
2155         (ada_add_global_exceptions): Use objfile_compunits.
2156
2157 2019-01-09  Tom Tromey  <tom@tromey.com>
2158
2159         * source.c (select_source_symtab)
2160         (forget_cached_source_info_for_objfile): Remove declaration.
2161         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2162         declaration.
2163         * maint.c (count_symtabs_and_blocks): Remove declaration.
2164         * cp-support.c (add_symbol_overload_list_qualified): Remove
2165         declaration.
2166         * coffread.c (coff_symtab_read): Remove declaration.
2167         * symtab.c (lookup_symbol_in_objfile_symtabs)
2168         (basic_lookup_transparent_type_1): Use objfile_compunits.
2169         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2170         (info_sources_command, search_symbols)
2171         (default_collect_symbol_completion_matches_break_on)
2172         (make_source_files_completion_list): Remove declaration.
2173         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2174         (ada_collect_symbol_completion_matches)
2175         (ada_add_global_exceptions): Remove declaration.
2176         * linespec.c (iterate_over_all_matching_symtabs): Use
2177         objfile_compunits.
2178         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2179         (class objfile_compunits): New.
2180         (ALL_COMPUNITS): Use objfile_compunits.
2181         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2182         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2183         objfile_compunits.
2184         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2185
2186 2019-01-09  Tom Tromey  <tom@tromey.com>
2187
2188         * symtab.c (search_symbols)
2189         (default_collect_symbol_completion_matches_break_on): Use
2190         objfile_msymbols.
2191         * ada-lang.c (ada_lookup_simple_minsym)
2192         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2193         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2194         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2195         objfile_msymbols.
2196         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2197         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2198         * objc-lang.c (find_methods): Use objfile_msymbols.
2199         (info_selectors_command, info_classes_command): Likewise.
2200         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2201         * objfiles.h (class objfile_msymbols): New.
2202         (ALL_OBJFILE_MSYMBOLS): Remove.
2203         (ALL_MSYMBOLS): Remove.
2204
2205 2019-01-09  Tom Tromey  <tom@tromey.com>
2206
2207         * common/next-iterator.h (next_adapter): Add Iterator template
2208         parameter.
2209         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2210         (class all_objfiles_safe): New.
2211         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2212         * objfiles.c (put_objfile_before): Update comment.
2213         (add_separate_debug_objfile): Likewise.
2214         (free_all_objfiles): Use all_objfiles_safe.
2215         (objfile_purge_solibs): Likewise.
2216
2217 2019-01-09  Tom Tromey  <tom@tromey.com>
2218
2219         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2220         (expand_symtab_containing_pc, lookup_static_symbol)
2221         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2222         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2223         all_objfiles.
2224         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2225         * breakpoint.c (create_overlay_event_breakpoint)
2226         (create_longjmp_master_breakpoint)
2227         (create_std_terminate_master_breakpoint)
2228         (create_exception_master_breakpoint): Use all_objfiles.
2229         * linux-thread-db.c (try_thread_db_load_from_pdir)
2230         (has_libpthread): Use all_objfiles.
2231         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2232         * linespec.c (iterate_over_all_matching_symtabs)
2233         (search_minsyms_for_name): Use all_objfiles.
2234         * maint.c (maintenance_info_sections): Use all_objfiles.
2235         * main.c (captured_main_1): Use all_objfiles.
2236         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2237         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2238         * guile/scm-pretty-print.c
2239         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2240         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2241         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2242         (maintenance_print_msymbols): Use all_objfiles.
2243         * source.c (select_source_symtab): Use all_objfiles.
2244         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2245         * symfile.c (remove_symbol_file_command)
2246         (expand_symtabs_matching, map_symbol_filenames): Use
2247         all_objfiles.
2248         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2249         all_objfiles.
2250         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2251         * objc-lang.c (find_methods): Use all_objfiles.
2252         * objfiles.c (have_partial_symbols, have_full_symbols)
2253         (have_minimal_symbols, qsort_cmp)
2254         (default_iterate_over_objfiles_in_search_order): Use
2255         all_objfiles.
2256         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2257         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2258         (maintenance_check_psymtabs): Use all_objfiles.
2259         (ALL_PSYMTABS): Remove.
2260         * compile/compile-object-run.c (do_module_cleanup): Use
2261         all_objfiles.
2262         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2263         * cp-support.c (add_symbol_overload_list_qualified): Use
2264         all_objfiles.
2265         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2266         Use all_objfiles.
2267         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2268         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2269         all_objfiles.
2270         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2271         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2272         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2273         Uses all_objfiles.
2274         * solib.c (solib_read_symbols): Use all_objfiles
2275
2276 2019-01-09  Tom Tromey  <tom@tromey.com>
2277
2278         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2279         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2280         all_objfiles.
2281         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2282         * symmisc.c (print_symbol_bcache_statistics)
2283         (print_objfile_statistics, maintenance_print_objfiles)
2284         (maintenance_info_symtabs, maintenance_check_symtabs)
2285         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2286         all_objfiles.
2287         * source.c (forget_cached_source_info): Use all_objfiles.
2288         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2289         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2290         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2291         * objfiles.c (update_section_map): Use all_objfiles.
2292         (shared_objfile_contains_address_p): Likewise.
2293         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2294         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2295
2296 2019-01-09  Tom Tromey  <tom@tromey.com>
2297
2298         * common/next-iterator.h: New file.
2299         * objfiles.h (class all_objfiles): New.
2300         (struct objfile_iterator): New.
2301
2302 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2303
2304         * NEWS: Move the description of the changed "frame", "select-frame",
2305          and "info frame" commands to the Changed commands section.
2306
2307 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2308
2309         * gdbtypes.c (check_stub_method_group): Remove handling of old
2310         mangling schemes.
2311         * linespec.c (find_methods): Likewise.
2312         * stabsread.c (read_member_functions): Likewise.
2313         * valops.c (search_struct_method): Likewise.
2314         (value_struct_elt_for_reference): Likewise.
2315         * NEWS: Mention this change.
2316
2317 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2318
2319         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2320         print_source_lines.
2321         * source.c (print_source_lines_base): Update line number check.
2322         (print_source_lines): New function.
2323         (source_lines_range::source_lines_range): New function.
2324         * source.h (class source_lines_range): New class.
2325         (print_source_lines): New declaration.
2326
2327 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2328
2329         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2330
2331 2019-01-08  Tom Tromey  <tom@tromey.com>
2332             Simon Marchi  <simon.marchi@ericsson.com>
2333
2334         PR gdb/24060
2335         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2336         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2337         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2338         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2339         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2340         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2341
2342 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2343
2344         * source.c (select_source_symtab): Move header comment to
2345         declaration in source.h.
2346         (forget_cached_source_info_for_objfile): Likewise.
2347         (forget_cached_source_info): Likewise.
2348         (identify_source_line): Likewise.
2349         * source.h (identify_source_line): Move declaration from symtab.h
2350         and add comment from source.c
2351         (print_source_lines): Likewise.
2352         (forget_cached_source_info_for_objfile): Likewise.
2353         (forget_cached_source_info): Likewise.
2354         (select_source_symtab): Likewise.
2355         (enum print_source_lines_flag): Move definition from symtab.h.
2356         * symtab.h (identify_source_line): Move declaration to source.h.
2357         (print_source_lines): Likewise.
2358         (forget_cached_source_info_for_objfile): Likewise.
2359         (forget_cached_source_info): Likewise.
2360         (select_source_symtab): Likewise.
2361         (enum print_source_lines_flag): Move definition to source.h.
2362         * tui/tui-hooks.c: Add 'source.h' include.
2363
2364 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2365
2366         * source.c (print_source_lines_base): Handle requests to print
2367         reverse line number sequences, and guard against empty lines
2368         string.
2369
2370 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2371
2372         * source.c (print_source_lines_base): Fix skip of '\r' if next
2373         character is '\n'.
2374
2375 2019-01-06  Tom Tromey  <tom@tromey.com>
2376
2377         * c-exp.y (struct c_parse_state) <macro_original_text,
2378         expansion_obstack>: New member.
2379         (macro_original_text, expansion_obstack): Remove globals.
2380         (scan_macro_expansion, scanning_macro_expansion)
2381         (finished_macro_expansion): Update.
2382         (scan_macro_cleanup): Remove.
2383         (yylex, c_parse): Update.
2384
2385 2019-01-06  Tom Tromey  <tom@tromey.com>
2386
2387         * c-exp.y (struct c_parse_state) <strings>: New member.
2388         (operator_stoken): Update.
2389
2390 2019-01-06  Tom Tromey  <tom@tromey.com>
2391
2392         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2393         (union type_stack_elt) <typelist_val>: Now a pointer to
2394         std::vector.
2395         (type_stack_cleanup): Don't declare.
2396         (push_typelist): Update.
2397         * parse.c (pop_typelist): Return a std::vector.
2398         (push_typelist): Take a std::vector.
2399         (follow_types): Update.  Do not free args.
2400         (type_stack_cleanup): Remove.
2401         * c-exp.y (struct c_parse_state): New.
2402         (cpstate): New global.
2403         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2404         (nonempty_typelist): Update.
2405         (func_mod): Create a new vector.
2406         (c_parse): Create a c_parse_state.
2407         (check_parameter_typelist): Do not delete params.
2408         (function_method): Update.  Do not delete type_list.
2409
2410 2019-01-06  Tom Tromey  <tom@tromey.com>
2411
2412         PR gdb/28155:
2413         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2414         check_typedef.
2415         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2416         (print_return_value): Likewise.
2417
2418 2019-01-05  Tom Tromey  <tom@tromey.com>
2419
2420         * contrib/cleanup_check.py: Remove.
2421         * contrib/gcc-with-excheck: Remove.
2422         * contrib/exsummary.py: Remove.
2423         * contrib/excheck.py: Remove.
2424
2425 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2426
2427         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2428         NULL. Initialize tpprev to NULL instead of assigning it
2429         to NULL on the next statement.
2430         * windows-nat.c (windows_delete_thread): Remove check for
2431         main_thread_id before printing thread exit notifications.
2432         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2433         Remove thread ID check against main_thread_id.
2434         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2435         windows_delete_thread.
2436         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2437
2438 2019-01-04  Tom Tromey  <tom@tromey.com>
2439
2440         * compile/compile.c (_initialize_compile): Use upper case for
2441         metasyntactic variables.
2442         * symmisc.c (_initialize_symmisc): Use upper case for
2443         metasyntactic variables.
2444         * psymtab.c (_initialize_psymtab): Use upper case for
2445         metasyntactic variables.
2446         * demangle.c (demangle_command): Use upper case for metasyntactic
2447         variables.
2448         (_initialize_demangler): Likewise.
2449         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2450         variables.
2451
2452 2019-01-03  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2455
2456 2019-01-03  Tom Tromey  <tom@tromey.com>
2457
2458         * python/py-symtab.c (salpy_str): Update.
2459         (struct salpy_sal_object) <symtab>: Now a PyObject.
2460         (salpy_dealloc): Update.
2461         (del_objfile_sal): Use gdbpy_ref.
2462
2463 2019-01-03  Tom Tromey  <tom@tromey.com>
2464
2465         * python/py-type.c (convert_field): Use new_reference.  Return
2466         gdbpy_ref.
2467         (make_fielditem): Return gdbpy_ref.
2468         (typy_fields): Update.
2469         (typy_getitem): Update.
2470         (field_name): Return gdbpy_ref.  Use new_reference.
2471         (typy_iterator_iternext): Update.
2472
2473 2019-01-03  Tom Tromey  <tom@tromey.com>
2474
2475         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2476
2477 2019-01-03  Tom Tromey  <tom@tromey.com>
2478
2479         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2480         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2481         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2482         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2483         (pspy_set_type_printers): Likewise.
2484         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2485         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2486         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2487         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2488         (objfpy_set_type_printers): Likewise.
2489
2490 2019-01-03  Tom Tromey  <tom@tromey.com>
2491
2492         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2493         (gdbpy_print_stack): Use gdbpy_err_fetch.
2494         * python/python-internal.h (class gdbpy_err_fetch): New class.
2495         (class gdbpy_enter) <m_error_type, m_error_value,
2496         m_error_traceback>: Remove.
2497         <m_error>: New member.
2498         (gdbpy_exception_to_string): Don't declare.
2499         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2500         * python/py-value.c (convert_value_from_python): Use
2501         gdbpy_err_fetch.
2502         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2503         gdbpy_exception_to_string.
2504         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2505         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2506         gdbpy_err_fetch.
2507
2508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         * linux-nat.c (delete_lwp_cleanup): Delete.
2511         (struct lwp_deleter): New struct.
2512         (lwp_info_up): New typedef.
2513         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2514         lwp_info_up.
2515
2516 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2517
2518         * linux-fork.c (class scoped_switch_fork_info): New class.
2519         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2520
2521 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * valops.c (find_overload_match): Remove use of null_cleanup, and
2524         calls to do_cleanups.
2525
2526 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2527
2528         * compile/compile-cplus-types.c
2529         (compile_cplus_instance::decl_name): Handle changes to
2530         cp_func_name.
2531         * cp-support.c (cp_func_name): Update header comment, update
2532         return type.
2533         * cp-support.h (cp_func_name): Update return type in declaration.
2534         * valops.c (find_overload_match): Move temp_func local to top
2535         level of function and change its type.  Use temp_func to hold and
2536         delete temporary string obtained from cp_func_name.
2537
2538 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2539
2540         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2541         gdb::char_vector, remove cleanup, and update uses of `msg`.
2542
2543 2019-01-03  Jim Wilson  <jimw@sifive.com>
2544
2545         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2546
2547 2019-01-02  Tom Tromey  <tom@tromey.com>
2548
2549         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2550         (tdesc_parse_xml): Remove cleanups.
2551         * target-descriptions.h (make_cleanup_free_target_description):
2552         Don't declare.
2553         (target_desc_deleter): New struct.
2554         (target_desc_up): New typedef.
2555         * target-descriptions.c (target_desc_deleter::operator()): Rename
2556         from free_target_description.
2557         (make_cleanup_free_target_description): Remove.
2558
2559 2019-01-02  Tom Tromey  <tom@tromey.com>
2560
2561         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2562         constructor, destructor.
2563         (linespec_parser): Remove typedef.
2564         (~linespec_parser): Rename from linespec_parser_delete.
2565         (linespec_lex_to_end, linespec_complete_label)
2566         (linespec_complete): Update.
2567         (decode_line_full): Remove cleanups.
2568         (decode_line_1): Update.
2569
2570 2019-01-02  Tom Tromey  <tom@tromey.com>
2571
2572         * python/python-internal.h (inferior_to_inferior_object): Change
2573         return type.
2574         * python/py-exitedevent.c (create_exited_event_object): Update.
2575         * python/py-inferior.c (inferior_to_inferior_object): Return
2576         gdbpy_ref.
2577         (python_new_inferior, python_inferior_deleted)
2578         (thread_to_thread_object, delete_thread_object)
2579         (build_inferior_list, gdbpy_selected_inferior): Update.
2580         * python/py-infthread.c (create_thread_object): Update.  Also fail
2581         if inferior_to_inferior_object fails.
2582
2583 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2584
2585         * inferior.h (class inferior) <displaced_step_state>: New field.
2586         * infrun.h (struct displaced_step_state): Move here from
2587         infrun.c.  Initialize fields, add constructor.
2588         <inf>: Remove field.
2589         <reset>: New method.
2590         * infrun.c (struct displaced_step_inferior_state): Move to
2591         infrun.h.
2592         (displaced_step_inferior_states): Remove.
2593         (get_displaced_stepping_state): Adust.
2594         (displaced_step_in_progress_any_inferior): Adjust.
2595         (displaced_step_in_progress_thread): Adjust.
2596         (displaced_step_in_progress): Adjust.
2597         (add_displaced_stepping_state): Remove.
2598         (get_displaced_step_closure_by_addr): Adjust.
2599         (remove_displaced_stepping_state): Remove.
2600         (infrun_inferior_exit): Call displaced_step_state.reset.
2601         (use_displaced_stepping): Don't check for NULL.
2602         (displaced_step_prepare_throw): Call
2603         get_displaced_stepping_state.
2604         (displaced_step_fixup): Don't check for NULL.
2605         (prepare_for_detach): Don't check for NULL.
2606
2607 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2608
2609         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2610          in case of call that did not complete.
2611
2612 2019-01-02  Andrey Utkin  <autkin@undo.io>
2613
2614         * symfile.c (find_separate_debug_file): Fix search of debug files for
2615         remote debuggee.
2616
2617 2019-01-02  Tom Tromey  <tom@tromey.com>
2618
2619         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2620         indentation.
2621         * python/py-frame.c (frapy_older): Remove cast.
2622         (frapy_newer): Likewise.
2623         * python/py-breakpoint.c (local_setattro): Remove cast.
2624         * python/py-arch.c (archpy_name): Remove local variable.
2625         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2626
2627 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2628
2629         * unittests/basic_string_view/element_access/char/empty.cc:
2630         Fix year range in copyright header.
2631
2632 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2633
2634         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2635         Delete.
2636         <operator==>: Update with for removed field.
2637         <hash>: Likewise.
2638         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2639         <isa_features>: ...this.
2640         <abi_features>: New field.
2641         (riscv_isa_flen): Update comment.
2642         (riscv_abi_xlen): New declaration.
2643         (riscv_abi_flen): New declaration.
2644         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2645         isa_features.
2646         (riscv_abi_xlen): New function.
2647         (riscv_isa_flen): Update to get answer from isa_features.
2648         (riscv_abi_flen): New function.
2649         (riscv_has_fp_abi): Update to get answer from abi_features.
2650         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2651         xlen and flen.
2652         (riscv_call_info) <xlen, flen>: Update comment.
2653         (riscv_call_arg_struct): Remove invalid assertions
2654         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2655         is removed.
2656         (riscv_gdbarch_init): Gather isa features and abi features
2657         separately, ensure both match on the gdbarch when reusing an old
2658         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2659         a target with 64-bit float hardware.
2660
2661 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2662
2663         * source.c (search_command_helper): Stop reverse search
2664         when line 1 has been searched.
2665
2666 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2667
2668         * record-full.c (record_full_base_target::close): Rewrite
2669         record_full_core_buf_list free logic.
2670
2671 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2672
2673         * break-catch-syscall.c (print_one_catch_syscall): xfree
2674         the last text.
2675
2676 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2677
2678         * top.c (print_gdb_version): Update Copyright year in version
2679         message.
2680
2681 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2682
2683         Update copyright year range in all GDB files.
2684
2685 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2686
2687         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2688
2689 For older changes see ChangeLog-2018.
2690 \f
2691 Local Variables:
2692 mode: change-log
2693 left-margin: 8
2694 fill-column: 74
2695 version-control: never
2696 coding: utf-8
2697 End:
2698