2f406ae2bd044c2ce19e4c45fa7919b52fb0ee67
[external/binutils.git] / gdb / ChangeLog
1 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2
3         * NEWS: Mention that GDB printf and eval commands can now print
4         C-style and Ada-style convenience var strings without
5         calling the inferior.
6         * printcmd.c (printf_c_string): Locally print GDB internal var
7         instead of transiting via the inferior.
8         (printf_wide_c_string): Likewise.
9
10 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
11
12         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
13
14 2019-07-04  Tom Tromey  <tom@tromey.com>
15
16         PR tui/24724:
17         * tui/tui-winsource.c (tui_clear_source_content): Update.
18         (tui_source_window_base::set_is_exec_point_at): Fix comment.
19         (tui_update_breakpoint_info): Update.
20         (tui_set_exec_info_content): Update.
21         * tui/tui-source.c (tui_set_source_content_nil): Update.
22         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
23         has_break.
24         * tui/tui-data.h (enum tui_bp_flag): New.
25         (tui_bp_flags): New enum flags type.
26         (struct tui_source_element) <break_mode>: Change type.  Rename
27         from has_break.
28         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
29         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
30         constants.
31         * tui/tui-winsource.h: Fix comment.
32
33 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
34
35         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
36         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
37         (store_fpregs_to_thread)
38         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
39         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
40         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
41         (IWMMXT_REGS_SIZE): Add define.
42         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
43         (fetch_vfp_regs, store_vfp_regs)
44         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
45         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
46
47 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
48
49         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
50         defines.
51         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
52         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
53         (ARM_INT_REGISTER_SIZE): ...to this.
54         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
55         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
56         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
57         (arm_linux_collect_gregset, supply_nwfpe_register)
58         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
59         defines.
60         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
61         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
62         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
63         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
64         (arm_return_in_memory, arm_store_return_value)
65         (arm_get_longjmp_target, arm_register_g_packet_guesses)
66         (arm_record_ld_st_multiple): Likewise.
67         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
68         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
69
70 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
71
72         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
73         AARCH64_DISPLACED_MODIFIED_INSNS.
74         * aarch64-tdep.c (struct aarch64_displaced_step_data)
75         (aarch64_displaced_step_copy_insn): Likewise.
76         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
77         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
78         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
79         ARM_DISPLACED_MODIFIED_INSNS.
80         * arm-tdep.c (arm_gdbarch_init): Likewise.
81         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
82         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
83         (struct arm_displaced_step_closure): Use
84         ARM_DISPLACED_MODIFIED_INSNS.
85
86 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
87
88         * features/Makefile: Remove unused xml files.
89         * features/aarch64.xml: Remove.
90         * features/i386/amd64-avx-avx512-linux.xml: Remove.
91         * features/i386/amd64-avx-avx512.xml: Remove.
92         * features/i386/amd64-avx-linux.xml: Remove.
93         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
94         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
95         * features/i386/amd64-avx-mpx-linux.xml: Remove.
96         * features/i386/amd64-avx-mpx.xml: Remove.
97         * features/i386/amd64-avx.xml: Remove.
98         * features/i386/amd64-linux.xml: Remove.
99         * features/i386/amd64-mpx-linux.xml: Remove.
100         * features/i386/amd64-mpx.xml: Remove.
101         * features/i386/amd64.xml: Remove.
102         * features/i386/i386-avx-avx512-linux.xml: Remove.
103         * features/i386/i386-avx-avx512.xml: Remove.
104         * features/i386/i386-avx-linux.xml: Remove.
105         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
106         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
107         * features/i386/i386-avx-mpx-linux.xml: Remove.
108         * features/i386/i386-avx-mpx.xml: Remove.
109         * features/i386/i386-avx.xml: Remove.
110         * features/i386/i386-linux.xml: Remove.
111         * features/i386/i386-mmx-linux.xml: Remove.
112         * features/i386/i386-mmx.xml: Remove.
113         * features/i386/i386-mpx-linux.xml: Remove.
114         * features/i386/i386-mpx.xml: Remove.
115         * features/i386/i386.xml: Remove.
116         * features/i386/x32-avx-avx512-linux.xml: Remove.
117         * features/i386/x32-avx-linux.xml: Remove.
118         * features/i386/x32-linux.xml: Remove.
119
120 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
121
122         * regformats/aarch64.dat: Remove.
123         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
124         * regformats/i386/amd64-avx-linux.dat: Remove.
125         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
126         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
127         * regformats/i386/amd64-linux.dat: Remove.
128         * regformats/i386/amd64-mpx-linux.dat: Remove.
129         * regformats/i386/amd64.dat: Remove.
130         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
131         * regformats/i386/i386-avx-linux.dat: Remove.
132         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
133         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
134         * regformats/i386/i386-linux.dat: Remove.
135         * regformats/i386/i386-mmx-linux.dat: Remove.
136         * regformats/i386/i386-mpx-linux.dat: Remove.
137         * regformats/i386/i386.dat: Remove.
138         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
139         * regformats/i386/x32-avx-linux.dat: Remove.
140         * regformats/i386/x32-linux.dat: Remove.
141
142 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
143
144         * aarch64-tdep.c: Remove xml self tests.
145         * amd64-linux-tdep.c: Likewise.
146         * amd64-tdep.c: Likewise.
147         * i386-linux-tdep.c: Likewise.
148         * i386-tdep.c: Likewise.
149
150 2019-07-03  Pedro Alves  <palves@redhat.com>
151
152         PR cli/24732
153         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
154         (pipe_cmd_option_defs): New.
155         (make_pipe_cmd_options_def_group): New.
156         (pipe_command): Use gdb::option::process_options.
157         (pipe_command_completer): New function.
158         (_initialize_cli_cmds): Install completer for "pipe" command.
159
160 2019-07-03  Pedro Alves  <palves@redhat.com>
161
162         * cli/cli-option.c (union option_value) <string>: New field.
163         (struct option_def_and_value): Add ctor, move ctor, dtor and
164         use DISABLE_COPY_AND_ASSIGN.
165         (option_def_and_value::clear_value): New.
166         (parse_option, save_option_value_in_ctx, get_val_type_str)
167         (add_setshow_cmds_for_options): Handle var_string.
168         * cli-option.h (union option_def::var_address) <string>: New
169         field.
170         (struct string_option_def): New.
171         * maint-test-options.c (struct test_options_opts): Add default
172         ctor and use DISABLE_COPY_AND_ASSIGN.
173         <string_opt>: New field.
174         (test_options_opts::~test_options_opts): New.
175         (test_options_opts::dump): Also dump "-string".
176         (test_options_option_defs): Install "string.
177
178 2019-07-03  Pedro Alves  <palves@redhat.com>
179
180         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
181         option_value with a null enumeration.
182         (complete_options): Save the option values in the context.
183         (save_option_value_in_ctx): New, factored out from ...
184         (process_options): ... here.
185         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
186         of the function.
187         * maint-test-options.c (test_options_opts::dump): New, factored
188         out from ...
189         (maintenance_test_options_command_mode): ... here.
190         (maintenance_test_options_command_completion_result): Delete.
191         (maintenance_test_options_command_completion_text): Update
192         comment.
193         (maintenance_show_test_options_completion_result): Change
194         prototype.  Just print
195         maintenance_test_options_command_completion_text.
196         (save_completion_result): New.
197         (maintenance_test_options_completer_mode): Pass options context to
198         complete_options, and then save a dump.
199         (_initialize_maint_test_options): Use add_cmd to install "maint
200         show test-options-completion-result".
201
202 2019-07-03  Pedro Alves  <palves@redhat.com>
203
204         * NEWS (New commands): Mention "with" and "maint with".
205         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
206         (with_command, with_command_completer): New.
207         (pipe_command): Adjust to new repeat_previous
208         interface.
209         (_initialize_cli_cmds): Install the "with" command and its "w"
210         alias.
211         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
212         declarations.
213         * cli/cli-setshow.c (parse_cli_var_uinteger)
214         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
215         argument strings for all var_types.
216         (get_setshow_command_value_string): New, factored out from ...
217         (do_show_command): ... this.
218         * cli/cli-setshow.h: Include <string>.
219         (get_setshow_command_value_string): Declare.
220         * command.h (repeat_previous): Now returns const char *.  Adjust
221         comment.
222         * maint.c: Include "cli/cli-cmds.h".
223         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
224         (_initialize_maint_cmds): Register the "maintenance with" command.
225         * top.c (repeat_previous): Move bits from pipe_command here:
226         Return the saved command line, if any; error out if there's no
227         command to relaunch.
228
229 2019-07-03  Pedro Alves  <palves@redhat.com>
230
231         * NEWS (New commands): Mention "maint set/show test-settings"
232         instead of "maint test-settings".
233         * maint-test-settings.c (maintenance_test_settings_list): Delete.
234         (maintenance_test_settings_set_list): Rename to ...
235         (maintenance_set_test_settings_list): ... this.
236         (maintenance_test_settings_show_list): Rename to  ...
237         (maintenance_show_test_settings_list): ... this.
238         (maintenance_test_settings_cmd): Delete.
239         (maintenance_test_settings_set_cmd): ...
240         (maintenance_set_test_settings_cmd): ... this.
241         (maintenance_test_settings_show_cmd): ...
242         (maintenance_show_test_settings_cmd): ... this.
243         (maintenance_test_settings_show_value_cmd):
244         (maintenance_show_test_settings_value_cmd): ... this.
245         (_initialize_maint_test_settings): No longer install the "maint
246         test-settings" prefix command.  Rename "maint test-settings set"
247         to "maint set test-settings", and "maint test-settings show" to
248         "maint show test-settings".  Adjust all subcommands.
249
250 2019-07-03  Pedro Alves  <palves@redhat.com>
251
252         * maint-test-settings.c: Fix file's intro comment.  Replace all
253         references to "test-options" with references to "test-settings",
254         in comments.
255
256 2019-07-03  Pedro Alves  <palves@redhat.com>
257
258         * maint-test-settings.c (maintenance_test_settings_xxx)
259         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
260         New.
261         (maintenance_test_settings_enums): Use them.
262         (maintenance_test_settings_enum): Default to
263         maintenance_test_settings_xxx.
264         (_initialize_maint_test_settings): Initialize
265         MAINTENANCE_TEST_SETTINGS_FILENAME.
266
267 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
268
269         * breakpoint.h (remove_breakpoints_inf): Change return type to
270         void, move function documentation here.
271         * breakpoint.c (remove_breakpoints_inf): Change return type to
272         void, move function documentation to header.
273
274 2019-07-02  Pedro Alves  <palves@redhat.com>
275
276         * NEWS (Completion improvements): Mention "info threads".
277         * thread.c (struct info_threads_opts, info_threads_option_defs)
278         (make_info_threads_options_def_group): New.
279         (info_threads_command): Use gdb::option::process_options.
280         (info_threads_command_completer): New.
281         (_initialize_thread): Use gdb::option::build_help to build the
282         help text for "info threads".
283
284 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
285
286         * defs.h (generic_load): Move from here...
287         * symfile.h (generic_load): ... to here.  Rename name parameter
288         to args.
289         * symfile.c (generic_load): Add comment.
290
291 2019-07-01  Tom Tromey  <tromey@adacore.com>
292
293         * dwarf2read.c
294         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
295         declaration of without_params.  Fix formatting.
296
297 2019-07-01  Tom Tromey  <tromey@adacore.com>
298
299         * ada-exp.y (find_primitive_type): Update.
300         * ada-lang.h (ada_lookup_symbol): Update.
301         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
302         parameter.
303         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
304
305 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
306
307         PR breakpoints/24541
308         * gdbarch.c: Regenerate.
309         * gdbarch.h: Regenerate.
310         * gdbarch.sh: Add 'stap_adjust_register'.
311         * i386-tdep.c: Include '<unordered_set>'.
312         (i386_stap_adjust_register): New function.
313         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
314         * stap-probe.c (stap_parse_register_operand): Call
315         'gdbarch_stap_adjust_register'.
316
317 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
318
319         PR python/24742
320         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
321         * python/python.c (do_start_initialization): Use 'xmalloc'
322         instead of 'PyMem_Malloc'.
323
324 2019-06-28  Tom Tromey  <tromey@adacore.com>
325
326         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
327         for Ada.
328
329 2019-06-27  Tom Tromey  <tromey@adacore.com>
330
331         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
332         objfile_key.
333         (arm_find_mapping_symbol, arm_record_special_symbol)
334         (_initialize_arm_tdep): Update.
335         (arm_objfile_data_free): Remove.
336
337 2019-06-27  Tom Tromey  <tromey@adacore.com>
338
339         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
340         to cp_print_static_field.
341
342 2019-06-26  Tom Tromey  <tromey@adacore.com>
343
344         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
345         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
346         declare.
347
348 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
349
350         * features/aarch64-core.c (create_feature_aarch64_core):
351         Regenerate.
352         * features/aarch64-core.xml: Add cpsr flags.
353
354 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
355
356         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
357         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
358
359 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
360
361         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
362         field.
363         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
364         use.
365         (arm_record_special_symbol): Don't insert new symbol in sorted
366         position, push it at the end.
367
368 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
369
370         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
371         (arm_mapping_symbol_s): Remove.
372         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
373         (arm_mapping_symbol_vec): New typedef.
374         (struct arm_per_objfile): Add constructor.
375         <section_maps>: Change type to
376         std::unique_ptr<arm_mapping_symbol_vec[]>.
377         (arm_compare_mapping_symbols): Remove.
378         (arm_find_mapping_symbol): Adjust to section_maps type change.
379         (arm_objfile_data_free): Call delete on arm_per_objfile.
380         (arm_record_special_symbol): Adjust to section_maps type change.
381         Allocate arm_per_objfile with new.
382
383 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
384
385         * cli/cli-cmds.c (alias_command): Compare the alias prefix
386         with the command prefix.
387
388 2019-06-25  Tom Tromey  <tom@tromey.com>
389
390         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
391         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
392
393 2019-06-25  Tom Tromey  <tom@tromey.com>
394
395         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
396         type.
397         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
398         protected.
399
400 2019-06-25  Tom Tromey  <tom@tromey.com>
401
402         * tui/tui-winsource.c
403         (tui_source_window_base::set_is_exec_point_at): Add check against
404         LOA_ADDRESS.
405
406 2019-06-25  Tom Tromey  <tom@tromey.com>
407
408         * tui/tui-source.c (tui_set_source_content): Don't check before
409         xfree.
410         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
411
412 2019-06-25  Tom Tromey  <tom@tromey.com>
413
414         * tui/tui-winsource.h (tui_update_source_window_as_is)
415         (tui_alloc_source_buffer, tui_line_is_displayed)
416         (tui_addr_is_displayed): Change type of win_info.
417         * tui/tui-winsource.c (tui_update_source_window_as_is)
418         (tui_clear_source_content, tui_show_source_line)
419         (tui_show_source_content, tui_source_window_base::refill)
420         (tui_source_window_base::set_is_exec_point_at)
421         (tui_source_window_base::set_is_exec_point_at)
422         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
423         (tui_alloc_source_buffer, tui_line_is_displayed)
424         (tui_addr_is_displayed): Change type of win_info.  Update.
425         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
426         (tui_source_window_base::do_make_visible_with_new_height):
427         Update.
428         * tui/tui-source.c (tui_set_source_content)
429         (tui_set_source_content_nil)
430         (tui_source_window::do_scroll_vertical): Update.
431         * tui/tui-layout.c (show_layout): Update.
432         * tui/tui-disasm.c (tui_set_disassem_content)
433         (tui_disasm_window::do_scroll_vertical): Update.
434         * tui/tui-data.h (tui_win_content): Remove.
435         (struct tui_gen_win_info) <content, content_size>: Remove.
436         (struct tui_source_element): Add initializers and destructor.
437         (union tui_which_element, struct tui_win_element): Remove.
438         (struct tui_source_window_base) <content>: New field.
439         (struct tui_data_window): Remove destructor.
440         (tui_alloc_content, tui_free_win_content)
441         (tui_free_all_source_wins_content): Don't declare.
442         * tui/tui-data.c (tui_initialize_static_data): Update.
443         (init_content_element, tui_alloc_content): Remove.
444         (~tui_gen_win_info): Update.
445         (~tui_data_window, tui_free_all_source_wins_content)
446         (tui_free_win_content, free_content, free_content_elements):
447         Remove.
448
449 2019-06-25  Tom Tromey  <tom@tromey.com>
450
451         * tui/tui-winsource.h (tui_clear_source_content)
452         (tui_erase_source_content, tui_show_source_content): Change type
453         of win_info.
454         * tui/tui-winsource.c (tui_clear_source_content)
455         (tui_erase_source_content, tui_show_source_content): Change type
456         of win_info.
457         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
458         * tui/tui-source.h (tui_set_source_content_nil): Change type of
459         win_info.
460         * tui/tui-source.c (tui_set_source_content_nil): Change type of
461         win_info.
462         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
463
464 2019-06-25  Tom Tromey  <tom@tromey.com>
465
466         * tui/tui-winsource.c (tui_clear_source_content)
467         (tui_source_window_base::set_is_exec_point_at): Update.
468         * tui/tui-source.c (tui_set_source_content_nil): Update.
469         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
470         a bool.
471         * tui/tui-data.c (init_content_element): Update.
472
473 2019-06-25  Tom Tromey  <tom@tromey.com>
474
475         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
476         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
477         * tui/tui-layout.c (init_and_make_win): Update.
478         * tui/tui.h (enum tui_win_type): Update.
479         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
480         tui_win_is_auxillary.
481         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
482         tui_win_is_auxillary.
483
484 2019-06-25  Tom Tromey  <tom@tromey.com>
485
486         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
487         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
488         (tui_delete_data_content_windows, tui_display_all_data)
489         (tui_data_window::do_scroll_vertical, tui_display_data_from):
490         Update.
491         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
492         * tui/tui-regs.c (tui_last_regs_line_no)
493         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
494         (tui_show_registers): Update.
495         (tui_show_register_group): Return void.  Update.
496         (tui_display_registers_from, tui_display_reg_element_at_line)
497         (tui_display_registers_from_line, tui_check_register_values):
498         Update.
499         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
500         member.
501         (struct tui_data_window) <regs_content>: Now a std::vector.
502         <regs_content_count>: Remove.
503         (tui_add_content_elements, tui_free_data_content): Don't declare.
504         * tui/tui-data.c (tui_data_window::clear_detail): Update.
505         (init_content_element): Remove DATA_WIN case.  Add assert.
506         (tui_add_content_elements): Remove.
507         (tui_data_window): Update.
508         (tui_free_data_content): Remove.
509         (free_content_elements): Remove DATA_WIN case.
510
511 2019-06-25  Tom Tromey  <tom@tromey.com>
512
513         * tui/tui-data.c (tui_data_item_window): Update.
514         * tui/tui-windata.h (tui_check_data_values): Don't declare.
515         * tui/tui-windata.c (tui_display_all_data)
516         (tui_display_data_from_line): Update.
517         (tui_check_data_values): Remove.
518         * tui/tui-regs.c (tui_show_register_group)
519         (tui_display_reg_element_at_line): Update.
520         * tui/tui-hooks.c (tui_register_changed)
521         (tui_refresh_frame_and_register_information): Call
522         tui_check_register_values.
523         * tui/tui-data.h (struct tui_data_window) <data_content,
524         data_content_count, data_type>: Remove.
525         (enum tui_data_type): Remove.
526
527         * tui/tui-data.c (tui_data_window::clear_detail)
528         (~tui_data_window): Update.
529
530 2019-06-25  Tom Tromey  <tom@tromey.com>
531
532         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
533         declare.
534         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
535         Rename from tui_first_data_item_displayed.  Update.
536         (tui_data_window::refresh_all)
537         (tui_data_window::do_scroll_vertical): Update.
538         * tui/tui-data.h (struct tui_data_window)
539         <first_data_item_displayed>: Declare new method.
540
541 2019-06-25  Tom Tromey  <tom@tromey.com>
542
543         * tui/tui-data.h (tui_init_generic_part): Don't declare.
544         * tui/tui-data.c (tui_init_generic_part): Remove, moving
545         contents...
546         (tui_initialize_static_data): ...here.
547
548 2019-06-25  Tom Tromey  <tom@tromey.com>
549
550         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
551         (tui_display_registers_from, tui_check_register_values): Update.
552         (tui_display_register): Remove win_info parameter; update.
553         (tui_get_register): Change type of parameters.
554         * tui/tui-data.h (struct tui_data_element): Remove.
555         (union tui_which_element) <data>: Remove.
556         <data_window>: Change type.
557         (struct tui_data_item_window): New.
558         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
559         case.  Add assert.
560         (~tui_data_item_window): New destructor.
561         (free_content_elements): Remove DATA_ITEM_WIN case.
562
563 2019-06-25  Tom Tromey  <tom@tromey.com>
564
565         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
566         Remove.
567
568 2019-06-25  Tom Tromey  <tom@tromey.com>
569
570         * tui/tui-data.h (struct tui_command_element): Remove.
571         (union tui_which_element) <command>: Remove.
572         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
573         assert.
574         (free_content_elements): Remove CMD_WIN case.
575
576 2019-06-25  Tom Tromey  <tom@tromey.com>
577
578         * tui/tui-layout.c (tui_set_layout): Update.
579         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
580         * tui/tui-data.c (layout_def): Update.
581
582 2019-06-25  Tom Tromey  <tom@tromey.com>
583
584         * tui/tui-wingeneral.c (tui_refresh_all): Update.
585         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
586         (tui_source_window_base::set_new_height): Update.
587         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
588         Update.
589         (tui_set_locator_fullname, tui_set_locator_info)
590         (tui_show_frame_info): Update.
591         * tui/tui-source.c (tui_set_source_content)
592         (tui_source_is_displayed): Update.
593         * tui/tui-layout.c (show_source_disasm_command, show_data)
594         (show_source_or_disasm_and_command): Update.
595         * tui/tui-disasm.c (tui_set_disassem_content)
596         (tui_get_begin_asm_address): Update.
597         * tui/tui-data.h (struct tui_locator_element): Remove.
598         (union tui_which_element) <locator>: Remove.
599         (struct tui_locator_window): New.
600         (tui_locator_win_info_ptr): Change return type.
601         * tui/tui-data.c (_locator): Change type.
602         (tui_locator_win_info_ptr): Change return type.
603         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
604         (tui_alloc_content): Add assert.
605
606 2019-06-25  Tom Tromey  <tom@tromey.com>
607
608         * tui/tui-winsource.c
609         (tui_exec_info_window::maybe_allocate_content): New method.
610         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
611         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
612         (make_source_or_disasm_window): Add cast.
613         * tui/tui-data.h (union tui_which_element) <simple_string>:
614         Remove.
615         (struct tui_source_info): New.
616         (struct tui_source_window_base) <execution_info>: Change type.
617         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
618         case, and add assert.
619         (tui_alloc_content): Add assert.
620
621 2019-06-25  Tom Tromey  <tom@tromey.com>
622
623         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
624         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
625         * tui/tui-data.c (tui_alloc_win_info): Remove.
626
627 2019-06-25  Tom Tromey  <tom@tromey.com>
628
629         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
630         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
631         can_highlight.
632
633 2019-06-25  Tom Tromey  <tom@tromey.com>
634
635         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
636         make_visible_with_new_height method.
637         (tui_win_info::make_visible_with_new_height): New method.
638         (tui_source_window_base::do_make_visible_with_new_height)
639         (tui_data_window::do_make_visible_with_new_height)
640         (tui_cmd_window::do_make_visible_with_new_height): New methods.
641         (make_visible_with_new_height): Remove.
642         (tui_resize_all, tui_adjust_win_heights): Use
643         make_visible_with_new_height method.
644         * tui/tui-data.h (struct tui_win_info)
645         <do_make_visible_with_new_height, make_visible_with_new_height>:
646         New methods.
647         (struct tui_source_window_base, struct tui_data_window)
648         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
649         methods.
650
651 2019-06-25  Tom Tromey  <tom@tromey.com>
652
653         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
654         method.
655         (update_tab_width): Call update_tab_width method.
656         * tui/tui-data.h (struct tui_win_info)
657         (struct tui_source_window_base) <update_tab_width>: New methods.
658
659 2019-06-25  Tom Tromey  <tom@tromey.com>
660
661         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
662         parameter.
663         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
664         parameter.
665         (tui_gen_win_info::make_visible): Update.
666         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
667         parameter.
668         * tui/tui-data.h (enum tui_box): New enum.
669         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
670
671 2019-06-25  Tom Tromey  <tom@tromey.com>
672
673         * tui/tui-layout.c (make_source_or_disasm_window): Always use
674         init_and_make_win for EXEC_INFO_WIN.
675         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
676         longer inline.
677         (struct tui_win_info) <~tui_win_info>: Inline.
678         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
679         Don't declare.
680         * tui/tui-data.c (source_win, disasm_win): Remove globals.
681         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
682         Remove.
683         (tui_initialize_static_data): Update.
684         (~tui_gen_win_info): Handle more cleanup here.
685         (~tui_source_window_base): Delete "execution_info".
686         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
687
688 2019-06-25  Tom Tromey  <tom@tromey.com>
689
690         * tui/tui-layout.c (make_command_window): Don't set
691         can_highlight.
692         (show_source_disasm_command): Call the reset method.
693         (show_data): Don't set can_highlight.  Call the reset method.
694         (tui_gen_win_info::reset): Rename from init_gen_win_info
695         (init_and_make_win): Simplify.  Return tui_gen_win_info.
696         (show_source_or_disasm_and_command): Call the reset method.
697         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
698         (struct tui_cmd_window): Set can_highlight.
699
700 2019-06-25  Tom Tromey  <tom@tromey.com>
701
702         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
703         from make_visible.
704         (tui_make_visible, tui_make_invisible): Rewrite.
705         (tui_win_info::make_visible): Remove.
706         (tui_source_window_base::make_visible): Update.
707         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
708         method.  Moved from...
709         (struct tui_win_info) <make_visible>: ...here.
710
711 2019-06-25  Tom Tromey  <tom@tromey.com>
712
713         * tui/tui-winsource.c
714         (tui_source_window_base::do_scroll_horizontal): Remove direction
715         parameter.
716         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
717         direction parameter.
718         * tui/tui-win.c (tui_win_info::forward_scroll)
719         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
720         (tui_win_info::right_scroll): Update.
721         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
722         direction parameter.
723         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
724         direction parameter.
725         * tui/tui-data.h (enum tui_scroll_direction): Remove.
726         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
727         Remove direction parameter.
728         (struct tui_source_window_base, struct tui_source_window)
729         (struct tui_disasm_window, struct tui_data_window)
730         (struct tui_cmd_window): Update.
731
732 2019-06-25  Tom Tromey  <tom@tromey.com>
733
734         * tui/tui-winsource.h (tui_set_exec_info_content)
735         (tui_show_exec_info_content, tui_erase_exec_info_content)
736         (tui_clear_exec_info_content, tui_update_exec_info): Change
737         argument to tui_source_window_base.
738         * tui/tui-winsource.c (tui_set_exec_info_content)
739         (tui_show_exec_info_content, tui_erase_exec_info_content)
740         (tui_clear_exec_info_content, tui_update_exec_info): Change
741         argument to tui_source_window_base.
742
743 2019-06-25  Tom Tromey  <tom@tromey.com>
744
745         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
746         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
747
748 2019-06-25  Tom Tromey  <tom@tromey.com>
749
750         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
751         check.
752
753 2019-06-25  Tom Tromey  <tom@tromey.com>
754
755         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
756         type to void.
757         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
758         type to void.
759         * tui/tui-source.c (tui_set_source_content): Update.
760         * tui/tui-disasm.c (tui_set_disassem_content): Update.
761
762 2019-06-25  Tom Tromey  <tom@tromey.com>
763
764         * tui/tui-win.c (window_name_completer, tui_set_focus)
765         (tui_all_windows_info): Use name method.
766         * tui/tui-data.h (struct tui_gen_win_info)
767         (struct tui_source_window, struct tui_disasm_window)
768         (struct tui_data_window, struct tui_cmd_window) <name>: New
769         method.
770         (tui_win_name): Don't declare.
771         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
772         (tui_win_name): Remove.
773
774 2019-06-25  Tom Tromey  <tom@tromey.com>
775
776         * tui/tui-winsource.h (tui_update_source_window)
777         (tui_update_source_window_as_is): Change parameter type.
778         * tui/tui-winsource.c (tui_update_source_window): Change win_info
779         to be a tui_source_window_base.
780         (tui_update_source_window_as_is): Likewise.
781         * tui/tui-win.c (make_visible_with_new_height): Update.
782
783 2019-06-25  Tom Tromey  <tom@tromey.com>
784
785         * tui/tui-winsource.c (tui_erase_source_content)
786         (tui_show_source_content, tui_show_exec_info_content)
787         (tui_erase_exec_info_content): Use refresh_window method.
788         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
789         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
790         from tui_refresh_win.
791         (tui_data_window::refresh_window): New method.
792         (tui_win_info::refresh, tui_source_window_base::refresh)
793         (tui_refresh_all): Use refresh_window method.
794         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
795         method.
796         * tui/tui-regs.c (tui_display_register): Call refresh_window
797         method.
798         * tui/tui-layout.c (show_source_disasm_command)
799         (show_source_or_disasm_and_command): Call refresh_window method.
800         * tui/tui-data.h (struct tui_gen_win_info)
801         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
802         New method.
803
804 2019-06-25  Tom Tromey  <tom@tromey.com>
805
806         * tui/tui.c (tui_rl_other_window, tui_enable)
807         (tui_is_window_visible, tui_get_command_dimension): Update.
808         * tui/tui-winsource.c (tui_update_source_window_as_is)
809         (tui_clear_source_content, tui_erase_source_content)
810         (tui_show_source_line, tui_source_window_base::refill)
811         (tui_source_window_base::do_scroll_horizontal)
812         (tui_source_window_base::set_is_exec_point_at)
813         (tui_update_breakpoint_info, tui_set_exec_info_content)
814         (tui_alloc_source_buffer, tui_line_is_displayed)
815         (tui_addr_is_displayed): Update.
816         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
817         (tui_check_and_display_highlight_if_needed)
818         (tui_win_info::make_visible, tui_win_info::refresh)
819         (tui_refresh_all): Update.
820         * tui/tui-windata.c (tui_first_data_item_displayed)
821         (tui_delete_data_content_windows, tui_erase_data_content)
822         (tui_display_all_data, tui_data_window::refresh_all)
823         (tui_check_data_values): Update.
824         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
825         (tui_set_win_focus_to, tui_win_info::forward_scroll)
826         (tui_win_info::backward_scroll, tui_refresh_all_win)
827         (tui_resize_all, tui_set_focus, tui_all_windows_info)
828         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
829         (tui_source_window_base::set_new_height)
830         (tui_data_window::set_new_height)
831         (make_invisible_and_set_new_height)
832         (make_visible_with_new_height, new_height_ok)
833         (parse_scrolling_args): Update.
834         * tui/tui-stack.c (tui_show_frame_info): Update.
835         * tui/tui-source.c (tui_set_source_content)
836         (tui_set_source_content_nil, tui_source_is_displayed)
837         (tui_source_window::do_scroll_vertical): Update.
838         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
839         (tui_display_registers_from, tui_display_reg_element_at_line)
840         (tui_check_register_values, tui_reg_command): Update.
841         * tui/tui-layout.c (tui_default_win_height)
842         (show_source_disasm_command, show_data, init_and_make_win)
843         (show_source_or_disasm_and_command): Update.
844         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
845         (tui_redisplay_readline, tui_mld_flush)
846         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
847         (tui_getc): Update.
848         * tui/tui-disasm.c (tui_set_disassem_content)
849         (tui_disasm_window::do_scroll_vertical): Update.
850         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
851         Now virtual.
852         (struct tui_win_info): Derive from tui_gen_win_info.
853         <~tui_win_info>: Mark as override.
854         <generic>: Remove member.
855         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
856         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
857         (~tui_data_window, ~tui_win_info)
858         (tui_free_all_source_wins_content): Update.
859         * tui/tui-command.c (tui_refresh_cmd_win): Update.
860
861 2019-06-25  Tom Tromey  <tom@tromey.com>
862
863         * tui/tui-layout.c (init_and_make_win): Use new.
864         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
865         destructor, initializers.
866         (tui_alloc_generic_win_info): Don't declare.
867         * tui/tui-data.c (_locator): Add argument to constructor.
868         (source_win, disasm_win): New globals.
869         (exec_info): Remove.
870         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
871         Update.
872         (tui_alloc_generic_win_info): Remove.
873         (init_content_element): Use new.
874         (tui_win_info::tui_win_info): Update.
875         (free_content_elements) <case DATA_WIN>: Use delete.
876
877 2019-06-25  Tom Tromey  <tom@tromey.com>
878
879         * tui/tui-wingeneral.c (tui_refresh_win): Update.
880         * tui/tui-windata.c (tui_first_data_item_displayed)
881         (tui_delete_data_content_windows): Update.
882         * tui/tui-win.c (tui_data_window::set_new_height): Update.
883         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
884         (tui_display_registers_from, tui_check_register_values): Update.
885         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
886         pointer.
887         * tui/tui-data.c (init_content_element): Update.  Allocate the new
888         window.
889         (tui_free_data_content): Update.
890         (free_content_elements) <case DATA_WIN>: Free the window.
891
892 2019-06-25  Tom Tromey  <tom@tromey.com>
893
894         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
895         Update.
896         * tui/tui-layout.c (make_command_window)
897         (show_source_disasm_command, show_data, init_and_make_win)
898         (show_source_or_disasm_and_command): Update.
899         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
900         method.
901         <can_highight, is_highlighted>: Now bool.
902         (tui_set_win_highlight): Don't declare.
903         * tui/tui-data.c (tui_set_win_highlight): Remove.
904
905 2019-06-25  Tom Tromey  <tom@tromey.com>
906
907         * tui/tui-wingeneral.c (make_visible): Remove check of window
908         type.
909
910 2019-06-25  Tom Tromey  <tom@tromey.com>
911
912         * tui/tui-win.c (tui_win_info::max_height)
913         (tui_cmd_window::max_height): New methods.
914         (new_height_ok): Call max_height.
915         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
916         <max_height>: New method.
917
918 2019-06-25  Tom Tromey  <tom@tromey.com>
919
920         * tui/tui-win.c (tui_source_window_base::set_new_height)
921         (tui_data_window::set_new_height): New methods.
922         (make_invisible_and_set_new_height): Call set_new_height method.
923         * tui/tui-data.h (struct tui_win_info)
924         (struct tui_source_window_base, struct tui_data_window)
925         <set_new_height>: New method.
926
927 2019-06-25  Tom Tromey  <tom@tromey.com>
928
929         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
930         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
931         tui_refresh_data_win.
932         * tui/tui-win.c (tui_source_window_base::refresh_all): New
933         method.
934         (tui_refresh_all_win): Call the refresh_all method.
935         (tui_set_focus): Likewise.
936         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
937         (struct tui_source_window_base, struct tui_data_window) <refresh>:
938         Likewise.
939
940 2019-06-25  Tom Tromey  <tom@tromey.com>
941
942         * tui/tui-winsource.h (tui_refill_source_window)
943         (tui_set_is_exec_point_at): Don't declare.
944         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
945         (tui_source_window_base::refill): Rename from
946         tui_refill_source_window.
947         (tui_source_window_base::do_scroll_horizontal): Update.
948         (tui_source_window_base::set_is_exec_point_at): Rename from
949         tui_set_is_exec_point_at.
950         (tui_update_all_breakpoint_info): Update.
951         * tui/tui-stack.c (tui_show_frame_info): Update.
952         * tui/tui-layout.c (show_data): Add cast.
953         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
954         * tui/tui-data.h (struct tui_source_window_base) <refill,
955         set_is_exec_point_at>: New methods.
956         (tui_source_windows, tui_add_to_source_windows): Update types.
957         (tui_add_to_source_windows): Remove redundant declaration.
958         * tui/tui-data.c (source_windows): Store tui_source_window_base.
959         (tui_source_windows): Change return type.
960         (tui_clear_source_windows_detail): Update.
961         (tui_add_to_source_windows): Change type of parameter.
962         (tui_free_all_source_wins_content): Update.
963
964 2019-06-25  Tom Tromey  <tom@tromey.com>
965
966         * tui/tui-wingeneral.c (tui_win_info::refresh)
967         (tui_source_window_base::refresh): New methods.
968         (tui_refresh_all): Call the refresh method.
969         * tui/tui-data.h (struct tui_win_info)
970         (struct tui_source_window_base) <refresh>: New method.
971
972 2019-06-25  Tom Tromey  <tom@tromey.com>
973
974         * tui/tui.h (tui_is_window_visible): Return bool.
975         * tui/tui.c (tui_is_window_visible): Return bool.
976         * tui/tui-wingeneral.c (tui_make_window, make_visible)
977         (tui_make_visible, tui_make_invisible)
978         (tui_win_info::make_visible)
979         (tui_source_window_base::make_visible, make_all_visible)
980         (tui_make_all_visible, tui_make_all_invisible): Update.
981         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
982         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
983         bool.
984         (struct tui_win_info, struct tui_source_window_base)
985         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
986         * tui/tui-data.c (tui_init_generic_part): Update.
987
988 2019-06-25  Tom Tromey  <tom@tromey.com>
989
990         * tui/tui-wingeneral.c (tui_win_info::make_visible)
991         (tui_source_window_base::make_visible): New methods.
992         (make_all_visible): Make method call.
993         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
994         (struct tui_source_window_base, struct tui_cmd_window): Override
995         make_visible.
996         (tui_win_is_source_type): Don't declare.
997         * tui/tui-data.c (tui_win_is_source_type): Remove.
998
999 2019-06-25  Tom Tromey  <tom@tromey.com>
1000
1001         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1002         NULL check.
1003
1004 2019-06-25  Tom Tromey  <tom@tromey.com>
1005
1006         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1007         Inline constructor.  Add initializers for members.
1008         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1009         constructors; now inline in class.
1010
1011 2019-06-25  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-regs.c (tui_show_registers): Update.
1014         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1015         bool.
1016         * tui/tui-data.c (tui_data_window::clear_detail)
1017         (tui_data_window): Update.
1018
1019 2019-06-25  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-windata.c (tui_display_all_data)
1022         (tui_display_data_from_line, tui_display_data_from)
1023         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1024         Update.
1025         * tui/tui-regs.c (tui_last_regs_line_no)
1026         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1027         (tui_show_registers, tui_show_register_group)
1028         (tui_display_registers_from, tui_display_reg_element_at_line)
1029         (tui_display_registers_from_line, tui_check_register_values)
1030         (tui_reg_next, tui_reg_prev): Update.
1031         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1032         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1033         tui_data_window.
1034         (struct tui_win_info) <detail>: Remove.  Add new fields from
1035         tui_data_info.
1036         (TUI_DATA_WIN): Add cast.
1037         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1038         (~tui_data_window): Simplify.
1039
1040 2019-06-25  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-layout.c (show_source_disasm_command)
1043         (show_source_or_disasm_and_command): Update.
1044         * tui/tui-io.c (update_cmdwin_start_line)
1045         (tui_redisplay_readline): Update.
1046         * tui/tui-data.h (struct tui_command_info): Remove.
1047         (struct tui_win_info) <detail>: Remove command_info member.
1048         (struct tui_data_window) <start_line>: New member, from
1049         tui_command_info.
1050         (TUI_CMD_WIN): Add casts.
1051
1052 2019-06-25  Tom Tromey  <tom@tromey.com>
1053
1054         * tui/tui-winsource.c (tui_update_source_window)
1055         (tui_refill_source_window)
1056         (tui_source_window_base::do_scroll_horizontal)
1057         (tui_update_breakpoint_info, tui_set_exec_info_content)
1058         (tui_show_exec_info_content, tui_erase_exec_info_content)
1059         (tui_clear_exec_info_content): Update.
1060         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1061         Update.
1062         * tui/tui-win.c (make_invisible_and_set_new_height)
1063         (make_visible_with_new_height): Update.
1064         * tui/tui-source.c (tui_set_source_content)
1065         (tui_show_symtab_source): Update.
1066         * tui/tui-layout.c (extract_display_start_addr)
1067         (show_source_disasm_command, show_data)
1068         (make_source_or_disasm_window)
1069         (show_source_or_disasm_and_command): Update.
1070         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1071         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1072         "gdbarch".
1073         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1074         to tui_source_window_base.
1075         (struct tui_win_info) <detail>: Remove source_info member.
1076         (struct tui_source_window_base) <has_locator>: Inline.
1077         Move contents from tui_source_info; rename has_locator member to
1078         m_has_locator.
1079         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1080         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1081         header file.
1082         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1083         Simplify.
1084         (tui_free_all_source_wins_content): Cast to
1085         tui_source_window_base.
1086
1087 2019-06-25  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-win.c (make_invisible_and_set_new_height)
1090         (make_visible_with_new_height): Call has_locator method.
1091         * tui/tui-layout.c (show_source_disasm_command, show_data)
1092         (show_source_or_disasm_and_command): Update for bool change.
1093         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1094         (tui_win_info) <has_locator>: New method.
1095         (struct tui_source_window_base) <has_locator>: New method.
1096         (tui_win_has_locator): Don't declare.
1097         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1098         from tui_win_has_locator.
1099         (tui_source_window_base): Use false, not FALSE.
1100
1101 2019-06-25  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1104         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1105         clear_detail method directly.
1106         (tui_clear_win_detail): Remove.
1107
1108 2019-06-25  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1111         "this", not TUI_DISASM_WIN.
1112
1113 2019-06-25  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1116         declare.
1117         * tui/tui-winsource.c
1118         (tui_source_window_base::do_scroll_horizontal): Rename from
1119         tui_horizontal_source_scroll.
1120         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1121         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1122         from tui_vertical_data_scroll.
1123         * tui/tui-win.h (tui_scroll): Don't declare.
1124         * tui/tui-win.c (tui_win_info::forward_scroll)
1125         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1126         (tui_win_info::right_scroll): Rename and update.
1127         (tui_scroll_forward_command, tui_scroll_backward_command)
1128         (tui_scroll_left_command, tui_scroll_right_command): Update.
1129         (tui_scroll): Remove.
1130         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1131         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1132         from tui_vertical_source_scroll.
1133         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1134         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1135         from tui_vertical_disassem_scroll.
1136         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1137         do_scroll_horizontal>: New methods.
1138         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1139         Likewise.
1140         (struct tui_source_window_base): Add do_scroll_horizontal.
1141         (struct tui_source_window, struct tui_disasm_window): Add
1142         do_scroll_vertical.
1143         (struct tui_data_window, struct tui_cmd_window): Add
1144         do_scroll_horizontal and do_scroll_vertical.
1145         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1146
1147 2019-06-25  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-data.h (struct tui_source_window_base): New struct.
1150         (struct tui_source_window): Derive from tui_source_window_base.
1151         (struct tui_disasm_window): New struct.
1152         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1153         from tui_source_window::clear_detail.
1154         (tui_source_window_base): Rename from tui_source_window.
1155         (~tui_source_window_base): Rename from ~tui_source_window.
1156         (tui_alloc_win_info): Create a tui_disasm_window.
1157
1158 2019-06-25  Tom Tromey  <tom@tromey.com>
1159
1160         * tui/tui-data.h (struct tui_source_window)
1161         (struct tui_data_window): Declare destructors.
1162         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1163         destructors.
1164         (tui_win_info): Simplify.
1165
1166 2019-06-25  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-winsource.c (tui_display_main)
1169         (tui_update_source_windows_with_addr)
1170         (tui_update_all_breakpoint_info): Update.
1171         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1172         (new_height_ok, parse_scrolling_args): Update.
1173         * tui/tui-stack.c (tui_show_frame_info): Update.
1174         * tui/tui-data.h (struct tui_list): Remove.
1175         (tui_source_windows): Return a reference to a std::vector.
1176         * tui/tui-data.c (source_windows): Now a std::vector.
1177         (tui_source_windows): Change return type.
1178         (tui_clear_source_windows): Rewrite.
1179         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1180         (tui_free_all_source_wins_content): Rewrite.
1181
1182 2019-06-25  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1185         (struct tui_data_window, struct tui_cmd_window): Declare
1186         clear_detail method.
1187         * tui/tui-data.c (tui_source_window::clear_detail)
1188         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1189         methods.
1190         (tui_clear_win_detail): Simplify.
1191
1192 2019-06-25  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-layout.c (make_source_window, make_disasm_window)
1195         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1196         Return the new window.
1197         (show_source_disasm_command, show_data)
1198         (show_source_or_disasm_and_command): Update.
1199
1200 2019-06-25  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1203         parameter.  Return the new window.
1204         (show_source_disasm_command): Update and remove NULL check.
1205         (show_source_or_disasm_and_command): Update.
1206
1207 2019-06-25  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1210
1211 2019-06-25  Tom Tromey  <tom@tromey.com>
1212
1213         * tui/tui-data.h (struct tui_win_info): Make constructor
1214         protected.  Make destructor virtual.  Add initializers.
1215         (tui_source_window, tui_data_window, tui_cmd_window): New
1216         classes.
1217         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1218         constructor.  Add "type" parameter.
1219         (tui_source_window, tui_data_window, tui_cmd_window): New
1220         constructors.
1221         (tui_alloc_win_info): Instantiate the appropriate subclass.
1222
1223 2019-06-25  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-win.c (tui_resize_all): Use delete.
1226         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1227         destructor.
1228         (tui_free_window): Don't declare.
1229         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1230         Update.
1231
1232 2019-06-25  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui-data.h (struct tui_win_info): Add constructor.
1235         * tui/tui-data.c (tui_alloc_win_info): Use new.
1236         (tui_free_window): Use delete.
1237
1238 2019-06-22  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1241         declare.
1242         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1243
1244 2019-06-22  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1247         declare.
1248         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1249
1250 2019-06-22  Tom de Vries  <tdevries@suse.de>
1251
1252         * dwarf2read.c (create_addrmap_from_aranges)
1253         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1254         instead of '%zu'.
1255
1256 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1257
1258         * dwarf2read.h (dwarf2_section_info_def): Remove.
1259         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1260         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1261         std::vector<dwarf2_section_info>.
1262         (struct dwo_file) <~dwo_file>: Remove.
1263         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1264         types field.
1265         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1266         (dwarf2_read_debug_names): Likewise.
1267         (create_debug_types_hash_table): Change parameter type to
1268         array_view, adjust code accordingly.
1269         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1270         (partial_die_info::fixup): Likewise.
1271         (determine_prefix): Likewise.
1272         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1273
1274 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1275
1276         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1277         gdb_bfd_ref_ptr.
1278         <~dwo_file>: Remove call to gdb_bfd_unref.
1279         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1280         gdb_bfd_ref_ptr::get.
1281
1282 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1283
1284         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1285         type to htab_up.
1286         * dwarf2read.c (struct dwo_file): Initialize fields.
1287         <~dwo_file>: New.
1288         (free_dwo_file): Remove, move content to ~dwo_file.
1289         (struct dwo_file_deleter): Remove.
1290         (dwo_file_up>: Remove custom deleter.
1291         (free_dwo_files): Remove.
1292         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1293         dwo_files.
1294         (process_skeletonless_type_units): Call unique_ptr::get.
1295         (allocate_dwo_file_hash_table): Add deleter to created hash
1296         table.  Change return type to htab_up.
1297         (lookup_dwo_file_slot): Don't memset dwo_file, call
1298         unique_ptr::get.
1299         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1300         (create_dwo_unit_in_dwp_v2): Likewise.
1301         (open_and_init_dwo_file): Likewise.
1302         (free_dwo_file_from_slot): Remove.
1303
1304 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1305
1306         * dwarf2read.h (struct dwarf2_section_info) <readin,
1307         is_virtual>: Change type to bool.
1308         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1309         true instead of 1.
1310
1311 2019-06-19  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-data.h (tui_init_content_element): Don't declare.
1314
1315 2019-06-19  Tom Tromey  <tom@tromey.com>
1316
1317         * tui/tui-data.h (tui_init_win_info): Don't declare.
1318
1319 2019-06-19  Tom de Vries  <tdevries@suse.de>
1320
1321         * dwarf2read.h (abstract_to_concrete): Change type to
1322         std::unordered_map<sect_offset, std::vector<sect_offset>,
1323         gdb::hash_enum<sect_offset>>.
1324
1325 2019-06-19  Tom Tromey  <tromey@adacore.com>
1326
1327         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1328         EVAL_AVOID_SIDE_EFFECTS specially.
1329
1330 2019-06-19  Tom Tromey  <tromey@adacore.com>
1331
1332         * source-cache.c (highlighter): New global.
1333         (source_cache::get_source_lines): Create a highlighter on demand.
1334
1335 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * defs.h (deprecated_interactive_hook): Delete declaration.
1338         * interps.c (clear_interpreter_hooks): Remove use of
1339         deprecated_interactive_hook.
1340         * top.c (deprecated_interactive_hook): Delete definition.
1341         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1342
1343 2019-06-18  Tom de Vries  <tdevries@suse.de>
1344
1345         PR gdb/24515
1346         * dwarf2read.h (abstract_to_concrete): Change type from
1347         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1348         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1349         * dwarf2read.c (read_variable): Update.
1350         (dwarf2_fetch_die_loc_sect_off): Update.
1351
1352 2019-06-17  Tom de Vries  <tdevries@suse.de>
1353
1354         PR gdb/24617
1355         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1356         accessing parent[parent_len - 1].
1357
1358 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1359
1360         PR gdb/24364
1361         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1362         call dtrace_process_dof with NULL dof.
1363
1364 2019-06-16  Tom de Vries  <tdevries@suse.de>
1365
1366         PR gdb/24445
1367         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1368
1369 2019-06-16  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1372         (make_all_visible): Use address of member.
1373
1374 2019-06-16  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1377         (tui_free_window, free_content, free_content_elements): Remove
1378         unnecessary cast.
1379         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1380         cast.
1381         * tui/tui-regs.c (tui_show_register_group)
1382         (tui_display_registers_from, tui_display_reg_element_at_line):
1383         Remove unnecessary cast.
1384
1385 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * linux-nat.c (normal_mask): Delete.
1388         (_initialize_linux_nat): Don't initialise normal_mask.
1389
1390 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1391
1392         PR gdb/24445
1393         * dwarf-index-write.h (write_psymtabs_to_index): Add
1394         dwz_basename parameter.
1395         * dwarf-index-write.c (write_gdbindex): Move file writing to
1396         write_gdbindex_1.  Change return type void.
1397         (assert_file_size): Move up, remove filename parameter.
1398         (write_gdbindex_1): New function.
1399         (write_debug_names): Change return type to void, call
1400         assert_file_size.
1401         (struct index_wip_file): New struct.
1402         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1403         file logic to index_wip_file.  Write index for dwz file if
1404         needed.
1405         (save_gdb_index_command): Pass basename of dwz file, if present.
1406         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1407         build-id of dwz file, if present.
1408         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1409         (dwarf2_get_dwz_file): Likewise.
1410         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1411         (dwarf2_get_dwz_file): Likewise.
1412
1413 2019-06-16  Tom Tromey  <tom@tromey.com>
1414
1415         * coffread.c (process_coff_symbol): Use xstrdup.
1416         * value.c (create_internalvar): Use xstrdup.
1417
1418 2019-06-16  Tom Tromey  <tom@tromey.com>
1419
1420         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1421         * breakpoint.c (stopin_command, stopat_command)
1422         (until_break_command, decode_location_default): Remove unnecessary
1423         cast.
1424         * utils.c (subset_compare): Remove unnecessary cast.
1425         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1426         cast.
1427         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1428         cast.
1429         * infcmd.c (path_command): Remove unnecessary cast.
1430         * coffread.c (decode_type): Remove unnecessary cast.
1431         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1432         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1433         * tui/tui-stack.c (tui_show_locator_content)
1434         (tui_show_frame_info): Remove unnecessary cast.
1435         * tui/tui-win.c (tui_scroll_forward_command)
1436         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1437         (parse_scrolling_args): Remove unnecessary cast.
1438         * tui/tui-data.c (init_win_info, tui_del_window)
1439         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1440         (free_content_elements): Remove unnecessary cast.
1441         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1442         unnecessary cast.
1443         * tui/tui-source.c (tui_set_source_content)
1444         (tui_vertical_source_scroll): Remove unnecessary cast.
1445         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1446         cast.
1447         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1448         * tui/tui-regs.c (tui_display_registers_from)
1449         (tui_display_register): Remove unnecessary cast.
1450         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1451         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1452         (make_visible): Remove unnecessary cast.
1453         * tui/tui-winsource.c (tui_erase_source_content)
1454         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1455         unnecessary cast.
1456         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1457         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1458         * stabsread.c (read_type, read_array_type, read_range_type):
1459         Remove unnecessary cast.
1460         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1461         (parse_symbol, parse_type, upgrade_type, parse_external)
1462         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1463         unnecessary cast.
1464         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1465
1466 2019-06-16  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-data.c (tui_alloc_generic_win_info)
1469         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1470         checks.
1471
1472 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1473             Andrew Burgess  <andrew.burgess@embecosm.com>
1474
1475         * f-typeprint.c (f_print_type): Don't return early for not
1476         associated or not allocated types.
1477         (f_type_print_varspec_suffix): Add print_rank parameter and print
1478         ranks of array types in case they dangling.
1479         (f_type_print_base): Add print_rank parameter.
1480
1481 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1482
1483         * NEWS: Mention new MI commands.
1484         * break-catch-throw.c (enum exception_event_kind): Move to
1485         breakpoint.h.
1486         (print_mention_exception_catchpoint): Output text as a single
1487         message.
1488         (catch_exception_command_1): Rename to...
1489         (catch_exception_event): ...this, make non-static, update header
1490         command, and change some parameter types.
1491         (catch_catch_command): Update for changes to
1492         catch_exception_command_1.
1493         (catch_throw_command): Likewise.
1494         (catch_rethrow_command): Likewise.
1495         * breakpoint.c (enum exception_event_kind): Delete.
1496         * breakpoint.h (enum exception_event_kind): Moved here from
1497         break-catch-throw.c.
1498         (catch_exception_event): Declare.
1499         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1500         (mi_cmd_catch_throw): New function.
1501         (mi_cmd_catch_rethrow): New function.
1502         (mi_cmd_catch_catch): New function.
1503         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1504         'catch-catch' entries.
1505         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1506         (mi_cmd_catch_rethrow): Declare.
1507         (mi_cmd_catch_catch): Declare.
1508
1509 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1510
1511         * annotate.c (annotate_source_line): Change return type to void,
1512         update implementation to match.
1513         * annotate.h (annotate_source_line): Change return type to void,
1514         update header comment.
1515         * stack.c (print_frame_info): Don't change what frame information
1516         is printed based on whether annotations are on or not.
1517
1518 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1521         (annotate_source): Make static.
1522         (annotate_source_line): Moved from source.c and renamed from
1523         identify_source_line.  Update the return type.
1524         * annotate.h (annotate_source): Delete declaration.
1525         (annotate_source_line): Declaration moved from source.h, and
1526         renamed from identify_source_line.  Return type updated.
1527         * source.c (identify_source_line): Moved to annotate.c and renamed
1528         to annotate_source_line.
1529         (info_line_command): Remove check of annotation_level.
1530         * source.h (identify_source_line): Move declaration to annotate.h
1531         and rename to annotate_source_line.
1532         * stack.c: Add 'annotate.h' include.
1533         (print_frame_info): Remove check of annotation_level before
1534         calling annotate_source_line.
1535
1536 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * source-cache.c (source_cache::get_plain_source_lines): Use
1539         open_source_file_with_line_charpos instead of just
1540         open_source_file, remove call to find_source_lines.
1541         (source_cache::get_source_lines): Likewise.
1542         * source.c (find_source_lines): Make static.
1543         (get_filename_and_charpos): Renamed into...
1544         (open_source_file_with_line_charpos): ..this along with changes to
1545         return a scoped_fd, and some other minor clean ups.
1546         (identify_source_line): Use open_source_file_with_line_charpos.
1547         (search_command_helper): Use open_source_file_with_line_charpos
1548         instead of just open_source_file, remove call to
1549         find_source_lines.
1550         * source.h (open_source_file_with_line_charpos): Declare new
1551         function.
1552         (find_source_lines): Delete declaration.
1553
1554 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1555
1556         * source.c (get_filename_and_charpos): Remove fullname
1557         parameter.
1558         (identify_source_line): Update call to get_filename_and_charpos.
1559
1560 2019-06-14  Tom Tromey  <tromey@adacore.com>
1561
1562         PR gdb/24502:
1563         * ui-style.h (skip_ansi_escape): Update comment.
1564         * ui-file.h (class no_terminal_escape_file): New class.
1565         * ui-file.c (no_terminal_escape_file::write)
1566         (no_terminal_escape_file::puts): New methods.
1567         * cli/cli-logging.c (handle_redirections): Use
1568         no_terminal_escape_file.
1569
1570 2019-06-14  Tom Tromey  <tromey@adacore.com>
1571
1572         * NEWS: Move convenience variable news above Python news.
1573
1574 2019-06-14  Tom Tromey  <tom@tromey.com>
1575
1576         * gnulib: Move directory to top-level.
1577         * configure.ac: Don't configure gnulib.
1578         * configure: Rebuild.
1579         * common/common-defs.h: Use new path to gnulib.
1580         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1581         (GNULIB_H): Remove.
1582         (INCGNU): Look in new gnulib location.
1583         (HFILES_NO_SRCDIR): Remove gnulib files.
1584         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1585         (generated_files): Remove GNULIB_H.
1586         ($(LIBGNU), all-lib): Remove targets.
1587         (distclean): Don't mention GNULIB_BUILDDIR.
1588         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1589
1590 2019-06-14  Tom Tromey  <tromey@adacore.com>
1591
1592         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1593         Warn if symbol file does not provide any symbols.
1594
1595 2019-06-14  Tom Tromey  <tromey@adacore.com>
1596
1597         * source.c (find_and_open_source): Respect basenames_may_differ.
1598
1599 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         * annotate.c (annotate_breakpoints_invalid): Make use of
1602         scoped_restore_terminal_state.
1603         (annotate_frames_invalid): Likewise.
1604
1605 2019-06-14  Tom Tromey  <tromey@adacore.com>
1606
1607         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1608         allow assignment to an internalvar.
1609
1610 2019-06-14  Tom Tromey  <tromey@adacore.com>
1611
1612         * ada-lex.l: Allow "_" in attribute names.
1613
1614 2019-06-14  Tom Tromey  <tromey@adacore.com>
1615
1616         PR gdb/24653:
1617         * regcache.c (registers_changed): Don't call alloca.
1618         * top.c (execute_command): Don't call alloca.
1619
1620 2019-06-13  Pedro Alves  <palves@redhat.com>
1621
1622         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1623         'expression'.  When parsing an expression, error out if there's
1624         junk after "unlimited".
1625         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1626         (do_set_command): Adjust calls to is_unlimited_literal.
1627
1628 2019-06-13  Pedro Alves  <palves@redhat.com>
1629
1630         * compile/compile.c (make_compile_options_def_group): Add braces
1631         around array_view initializer.
1632         * thread.c (make_thread_apply_all_options_def_group)
1633         (make_thread_apply_all_options_def_group): Likewise.
1634
1635 2019-06-13  Pedro Alves  <palves@redhat.com>
1636
1637         * NEWS (New commands): Mention "maint test-options
1638         require-delimiter", "maint test-options unknown-is-error", "maint
1639         test-options unknown-is-operand" and "maint show
1640         test-options-completion-result".
1641         (New command options, command completion): New section.
1642         (Completion improvements): New section.
1643         Mention that you can abbreviate "unlimited".
1644
1645 2019-06-13  Pedro Alves  <palves@redhat.com>
1646
1647         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1648         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1649         * unittests/cli-utils-selftests.c (test_parse_flags)
1650         (test_parse_flags_qcs): Delete.
1651         (test_cli_utils): Don't call deleted functions.
1652
1653 2019-06-13  Pedro Alves  <palves@redhat.com>
1654
1655         * thread.c: Include "cli/cli-option.h".
1656         (tp_array_compar_ascending): Global.
1657         (tp_array_compar): Delete function.
1658         (tp_array_compar_ascending, tp_array_compar_descending): New
1659         functions.
1660         (ascending_option_def, qcs_flag_option_def)
1661         (thr_qcs_flags_option_defs)
1662         (make_thread_apply_all_options_def_group)
1663         (make_thread_apply_options_def_group): New.
1664         (thread_apply_all_command): Use gdb::option::process_options.
1665         (thread_apply_command_completer)
1666         (thread_apply_all_command_completer): New.
1667         (thread_apply_command): Use gdb::option::process_options.
1668         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1669         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1670         to generate help text of "thread apply".  Adjust "taas"'s help.
1671         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1672         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1673
1674 2019-06-13  Pedro Alves  <palves@redhat.com>
1675
1676         * thread.c (thread_apply_command): Check for invalid TID with
1677         isdigit instead of !isalpha.
1678
1679 2019-06-13  Pedro Alves  <palves@redhat.com>
1680
1681         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1682         (validate_flags_qcs): New.
1683         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1684         (validate_flags_qcs): Declare.
1685         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1686         (make_frame_apply_options_def_group): New.
1687         (frame_apply_command_count): Process options with
1688         gdb::option::process_options.
1689         (frame_apply_completer): New.
1690         (frame_apply_level_completer, frame_apply_all_completer)
1691         (frame_apply_completer): New.
1692         (_initialize_stack): Update help of "frame apply", "frame apply
1693         level", "frame apply all" and "faas" to mention supported options
1694         and install command completers.
1695         * stack.h (frame_apply_all_completer): Declare.
1696         * thread.c: Include "stack.h".
1697         (tfaas_command): Add "--".
1698         (_initialize_thread): Update help "tfaas" to mention supported
1699         options and install command completer.
1700
1701 2019-06-13  Pedro Alves  <palves@redhat.com>
1702
1703         * completer.c (complete_nested_command_line): New.
1704         (gdb_completion_word_break_characters_throw): Add assertion.
1705         * completer.h (complete_nested_command_line): Declare.
1706
1707 2019-06-13  Pedro Alves  <palves@redhat.com>
1708
1709         * stack.c (parse_backtrace_qualifiers): New.
1710         (backtrace_command): Use it.
1711         (backtrace_command_completer): Complete on qualifiers.
1712
1713 2019-06-13  Pedro Alves  <palves@redhat.com>
1714
1715         * frame.c: Include "cli/cli-option.h.
1716         (user_set_backtrace_options): New.
1717         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1718         Delete.
1719         (get_prev_frame): Adjust.
1720         (boolean_option_def, uinteger_option_def)
1721         (set_backtrace_option_defs): New.
1722         (_initialize_frame): Adjust and use
1723         gdb::option::add_setshow_cmds_for_options to install "set
1724         backtrace past-main" and "set backtrace past-entry".
1725         * frame.h: Include "cli/cli-option.h".
1726         (struct frame_print_options): Forward declare.
1727         (print_frame_arguments_all, print_frame_arguments_scalars)
1728         (print_frame_arguments_none): Declare.
1729         (print_entry_values): Delete declaration.
1730         (struct frame_print_options, user_frame_print_options): New.
1731         (struct set_backtrace_options): New.
1732         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1733         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1734         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1735         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1736         (list_args_or_locals): Add frame_print_options parameter.
1737         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1738         * python/py-framefilter.c (enumerate_args): Pass down
1739         USER_FRAME_PRINT_OPTIONS.
1740         * stack.c: Include "cli/cli-option.h".
1741         (print_frame_arguments_all, print_frame_arguments_scalars)
1742         (print_frame_arguments_none): Declare.
1743         (print_raw_frame_arguments, print_entry_values): Delete.
1744         (user_frame_print_options): New.
1745         (boolean_option_def, enum_option_def, frame_print_option_defs):
1746         New.
1747         (struct backtrace_cmd_options): New.
1748         (bt_flag_option_def): New.
1749         (backtrace_command_option_defs): New.
1750         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1751         (print_frame_arg, read_frame_arg, print_frame_args)
1752         (print_frame_info, print_frame): Add frame_print_options parameter
1753         and use it.
1754         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1755         (backtrace_command_1): Add frame_print_options and
1756         backtrace_cmd_options parameters and use them.
1757         (make_backtrace_options_def_group): New.
1758         (backtrace_command): Process command options with
1759         gdb::option::process_options.
1760         (backtrace_command_completer): New.
1761         (_initialize_stack): Extend "backtrace"'s help to mention
1762         supported options.  Install completer for "backtrace".
1763         Install some settings commands with add_setshow_cmds_for_options.
1764
1765 2019-06-13  Pedro Alves  <palves@redhat.com>
1766
1767         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1768         and that "set/show print raw frame-arguments" are now deprecated.
1769
1770         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1771         command.
1772         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1773         * stack.c (_initialize_stack): Install "set/show print
1774         raw-frame-arguments", and deprecate "set/show print raw
1775         frame-arguments".
1776         * valprint.c (_initialize_valprint): Deprecate "set/show print
1777         raw".
1778
1779 2019-06-13  Pedro Alves  <palves@redhat.com>
1780
1781         * compile/compile.c (struct compile_options): New.
1782         (compile_flag_option_def, compile_command_option_defs)
1783         (make_compile_options_def_group): New.
1784         (compile_file_command): Handle options with
1785         gdb::option::process_options.
1786         (compile_file_command_completer): New function.
1787         (compile_code_command): Handle options with
1788         gdb::option::process_options.
1789         (compile_code_command_completer): New function.
1790         (_initialize_compiler): Install completers for "compile code" and
1791         "compile file".  Mention available options in "compile code" and
1792         "compile code"'s help.
1793         * completer.c (advance_to_completion_word): New, factored out from
1794         ...
1795         (advance_to_expression_complete_word_point): ... this.
1796         (advance_to_filename_complete_word_point): New.
1797         * completer.h (advance_to_filename_complete_word_point): New
1798         declaration.
1799
1800 2019-06-13  Pedro Alves  <palves@redhat.com>
1801
1802         * compile/compile.c: Include "cli/cli-option.h".
1803         (compile_print_value): Scope data pointer is now a
1804         value_print_options pointer; adjust.
1805         (compile_print_command): Process options.  Scope data pointer is
1806         now a value_print_options pointer; adjust.
1807         (_initialize_compile): Update "compile print"'s help to include
1808         supported options.  Install a completer for "compile print".
1809         * cp-valprint.c (show_vtblprint, show_objectprint)
1810         (show_static_field_print): Delete.
1811         (_initialize_cp_valprint): Don't install "set print
1812         static-members", "set print vtbl", "set print object" here.
1813         * printcmd.c: Include "cli/cli-option.h" and
1814         "common/gdb_optional.h".
1815         (print_command_parse_format): Rework to fill in a
1816         value_print_options instead of a format_data.
1817         (print_value): Change parameter type from format_data pointer to
1818         value_print_options reference.  Adjust.
1819         (print_command_1): Process options.  Adjust to pass down a
1820         value_print_options.
1821         (print_command_completer): New.
1822         (_initialize_printcmd): Install print_command_completer as
1823         handle_brkchars completer for the "print" command.  Update
1824         "print"'s help to include supported options.
1825         * valprint.c: Include "cli/cli-option.h".
1826         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1827         here from cp-valprint.c.
1828         (boolean_option_def, uinteger_option_def)
1829         (value_print_option_defs, make_value_print_options_def_group):
1830         New.  Use gdb::option::add_setshow_cmds_for_options to install
1831         "set print elements", "set print null-stop", "set print repeats",
1832         "set print pretty", "set print union", "set print array", "set
1833         print address", "set print symbol", "set print array-indexes".
1834         * valprint.h: Include <string> and "cli/cli-option.h".
1835         (make_value_print_options_def_group): Declare.
1836         (print_value): Change parameter type from format_data pointer to
1837         value_print_options reference.
1838         (print_command_completer): Declare.
1839
1840 2019-06-13  Pedro Alves  <palves@redhat.com>
1841
1842         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1843         (COMMON_SFILES): Add maint-test-settings.c.
1844         * cli/cli-decode.c (boolean_enums): New global, factored out from
1845         ...
1846         (add_setshow_boolean_cmd): ... here.
1847         * cli/cli-decode.h (boolean_enums): Declare.
1848         * cli/cli-option.c: New file.
1849         * cli/cli-option.h: New file.
1850         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1851         factored out from ...
1852         (parse_cli_boolean_value(const char *)): ... this.
1853         (is_unlimited_literal): Change parameter type to pointer to
1854         pointer.  Adjust and advance ARG pointer.
1855         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1856         (parse_cli_var_enum): New, factored out from ...
1857         (do_set_command): ... this.  Adjust.
1858         * cli/cli-setshow.h (parse_cli_boolean_value)
1859         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1860         (parse_cli_var_enum): Declare.
1861         * cli/cli-utils.c: Include "cli/cli-option.h".
1862         (get_ulongest): New.
1863         * cli/cli-utils.h (get_ulongest): Declare.
1864         (check_for_argument): New overloads.
1865         * maint-test-options.c: New file.
1866
1867 2019-06-13  Pedro Alves  <palves@redhat.com>
1868
1869         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1870         parse a range if "-" is at the end of the string.
1871
1872 2019-06-13  Pedro Alves  <palves@redhat.com>
1873
1874         * cli/cli-setshow.c (parse_auto_binary_operation)
1875         (parse_cli_boolean_value): Don't allow "o".
1876
1877 2019-06-13  Pedro Alves  <palves@redhat.com>
1878
1879         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1880         * NEWS: Mention maint test-settings KIND.
1881         * maint-test-settings.c: New file.
1882
1883 2019-06-13  Pedro Alves  <palves@redhat.com>
1884
1885         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1886         completer.
1887         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1888         "set" completers.
1889
1890 2019-06-13  Pedro Alves  <palves@redhat.com>
1891
1892         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1893         after item.
1894
1895 2019-06-13  Pedro Alves  <palves@redhat.com>
1896
1897         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1898
1899 2019-06-13  Pedro Alves <palves@redhat.com>
1900
1901         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1902         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1903         call.
1904         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1905         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1906         calls.
1907         (check_for_argument): Skip spaces after argument.
1908
1909 2019-06-13  Pedro Alves  <palves@redhat.com>
1910
1911         * thread.c (thread_apply_command): Adjust TID parsing.
1912         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1913         detected before end of string.
1914         (tid_is_in_list): Error out if LIST is invalid.
1915
1916 2019-06-13  Pedro Alves  <palves@redhat.com>
1917
1918         * completer.c (complete_line_internal_1): Rewind completion word
1919         point.
1920         (completion_tracker::advance_custom_word_point_by): Change
1921         parameter type to int.
1922         * completer.h (completion_tracker::advance_custom_word_point_by):
1923         Likewise.
1924
1925 2019-06-13  Pedro Alves  <palves@redhat.com>
1926
1927         * completer.c (advance_to_completion_word): Handle delimiters.
1928
1929 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1930
1931         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1932
1933 2019-06-11  Tom Tromey  <tom@tromey.com>
1934
1935         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1936         (xmalloc_failed): Move to alloc.c.
1937         * alloc.c: New file.
1938         * Makefile.in (COMMON_SFILES): Add alloc.c.
1939
1940 2019-06-11  Tom Tromey  <tom@tromey.com>
1941
1942         * nat/linux-waitpid.c: Don't include server.h.
1943         (linux_debug): Remove.
1944         (my_waitpid): Update.
1945
1946 2019-06-11  Tom Tromey  <tromey@adacore.com>
1947
1948         * infcall.c (_initialize_infcall): Remove trailing newline from
1949         help.
1950         * user-regs.c (_initialize_user_regs): Remove trailing newline
1951         from help.
1952         * typeprint.c (_initialize_typeprint): Remove trailing newline
1953         from help.
1954         * reverse.c (_initialize_reverse): Remove trailing newlines from
1955         help.
1956         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1957         from help.
1958         * language.c (add_set_language_command): Remove trailing newline
1959         from help.
1960         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1961         help.
1962         * disasm.c (_initialize_disasm): Remove trailing newline from
1963         help.
1964         * top.c (init_main): Remove trailing newline from help.
1965         * interps.c (_initialize_interpreter): Remove trailing newline
1966         from help.
1967         * btrace.c (_initialize_btrace): Remove trailing newlines from
1968         help.
1969         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1970         from help.
1971         * python/python.c (_initialize_python): Remove trailing newline
1972         from help.
1973         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1974         help.
1975         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1976         from help.  Reformat some text.
1977         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1978         from help.
1979         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1980         newline from help.
1981
1982 2019-06-11  Tom Tromey  <tromey@adacore.com>
1983
1984         * darwin-nat.c (darwin_decode_exception_message)
1985         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1986
1987 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1988
1989         * valops.c (value_slice): Check for not allocated or not
1990         associated values.
1991
1992 2019-06-10  Tom de Vries  <tdevries@suse.de>
1993
1994         PR gdb/24618
1995         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1996         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1997         invalid.
1998
1999 2019-06-10  Tom de Vries  <tdevries@suse.de>
2000
2001         PR gdb/24611
2002         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2003         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2004
2005 2019-06-10  Tom de Vries  <tdevries@suse.de>
2006
2007         PR symtab/24545
2008         * symtab.c (struct demangled_name_entry): Add language field.
2009         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2010         static minimal symbol".  Set and use language field.
2011
2012 2019-06-10  Tom Tromey  <tromey@adacore.com>
2013
2014         * ada-lang.c (_initialize_ada_language): Update help text.
2015
2016 2019-06-10  Tom Tromey  <tromey@adacore.com>
2017
2018         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2019         with a newline.
2020         * guile/guile.c (handle_boot_error): Don't end warning with a
2021         newline.
2022         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2023         warning with a newline.
2024         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2025         newline.
2026         (s12z_frame_cache): Likewise.
2027         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2028         a newline.
2029         * solib-svr4.c (disable_probes_interface): Don't end warning with
2030         a newline.
2031         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2032         newline.
2033         * python/python.c (do_finish_initialization): Don't end warning
2034         with a newline.
2035
2036 2019-06-10  Tom Tromey  <tom@tromey.com>
2037
2038         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2039         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2040         gdbpy_enter.
2041
2042 2019-06-10  Tom Tromey  <tromey@adacore.com>
2043
2044         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2045         data.
2046         (elf_new_init): Don't call stabsread_new_init.
2047         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2048         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2049         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2050
2051 2019-06-10  Tom de Vries  <tdevries@suse.de>
2052
2053         PR symtab/16264
2054         PR symtab/24517
2055         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2056
2057 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2058
2059         * source.c (find_and_open_source): Also rewrite relative file
2060         names.
2061
2062 2019-04-26  Amos Bird  <amosbird@gmail.com>
2063
2064         * annotate.c (annotate_thread_exited): Add "thread-exited"
2065         annotation.
2066
2067 2019-06-06  Tom Tromey  <tromey@adacore.com>
2068
2069         * maint.h (class scoped_command_stats): Use
2070         DISABLE_COPY_AND_ASSIGN.
2071         <print_time>: New method.
2072         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2073         print_time.
2074         (scoped_command_stats::print_time): New method.
2075
2076 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2077
2078         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2079         instructions of lengths 6 or 8 bytes.
2080
2081 2019-06-04  Pedro Alves  <palves@redhat.com>
2082
2083         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2084
2085         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2086         * breakpoint.c (condition_completer): Likewise.
2087         * cli/cli-dump.c (scan_expression): Likewise.
2088         * common/filestuff.c (mkdir_recursive): Likewise.
2089         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2090         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2091         (gdb_abspath): Likewise.
2092         * compile/compile-cplus-types.c
2093         (compile_cplus_instance::decl_name): Likewise.
2094         * completer.c (complete_explicit_location):
2095         (signal_completer, reg_or_group_completer_1): Likewise.
2096         * cp-support.c (cp_remove_params_if_any): Likewise.
2097         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2098         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2099         * infcmd.c (strip_bg_char): Likewise.
2100         * linespec.c (copy_token_string): Likewise.
2101         * mi/mi-main.c (output_cores): Likewise.
2102         * psymtab.c (psymtab_search_name):
2103         * symfile.c (test_set_ext_lang_command): Likewise.
2104         * target.c (target_fileio_read_stralloc): Likewise.
2105         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2106         * value.c (complete_internalvar): Likewise.
2107
2108 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2109
2110         Add objfile property to gdb.Type.
2111         * NEWS: Mention Python API addition.
2112         * python/py-type.c (typy_get_objfile): New method.
2113
2114 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2115
2116         * NEWS: Mention the new set|show style [title|highlight].
2117         Mention changes to "show style", "help" and "apropos".
2118
2119 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2120
2121         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2122         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2123         instead of print_help_for_command.
2124         (print_doc_of_command): New function.
2125         (help_list): Add 'apropos -v word' suggestion.
2126         (print_help_for_command): Style the command name using title style.
2127         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2128         (_initialize_cli_cmds): Describe -v in apropos_command help.
2129
2130 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2131
2132         * cli/cli-style.h (cli_style_option): Add name in constructor,
2133         add m_name class member, add constructor with intensity,
2134         add name class function.
2135         (cli_style_option::add_setshow_commands): Remove name argument.
2136         (highlight_style, title_style): New styles.
2137         * cli/cli-style.c (do_show): New function that shows a style
2138         characteristic styling the style name with itself.
2139         (set_style_name): New function.
2140         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2141         Update all callers according to the changes in cli/cli-style.h.
2142         * utils.h (fputs_highlighted): New function.
2143         * utils.c (fputs_highlighted): Likewise.
2144
2145 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2146
2147         * NEWS: Mention new pipe command and new convenience variables.
2148
2149 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2150
2151         * cli/cli-cmds.c (pipe_command): New function.
2152         (_initialize_cli_cmds): Call add_com for pipe_command.
2153         Define | as an alias for pipe.
2154         (exit_status_set_internal_vars): New function.
2155         (shell_escape): Call exit_status_set_internal_vars.
2156         cli/cli-decode.c (find_command_name_length): Recognize | as
2157         a single character command.
2158
2159 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2160
2161         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2162         top.c (execute_command_to_ui_file): New function, mostly a copy
2163         of execute_command_to_string.
2164         (execute_command_to_string): Implement by calling
2165         execute_command_to_ui_file.
2166
2167 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2168
2169         * top.h (saved_command_line): Remove declaration.
2170         * top.c (previous_saved_command_line, previous_repeat_arguments):
2171         New variables.
2172         (saved_command_line): Make static, define together with other
2173         'repeat variables'.
2174         (dont_repeat): Clear repeat_arguments.
2175         (repeat_previous, get_saved_command_line, save_command_line):
2176         New functions.
2177         (gdb_init): Initialize saved_command_line
2178         and previous_saved_command_line.
2179         * main.c (captured_main_1): Remove saved_command_line initialization.
2180         * event-top.c (handle_line_of_input): Update to use
2181         the new 'repeat' related functions instead of direct access to
2182         saved_command_line.
2183         * command.h (repeat_previous, get_saved_command_line,
2184         save_command_line): New declarations.
2185         (dont_repeat): Add comment.
2186
2187 2019-05-30  Tom Tromey  <tromey@adacore.com>
2188
2189         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2190         Fix comment.
2191         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2192
2193 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2194
2195         PR cli/24587
2196         * completer.c (complete): Initialize variable word.
2197
2198 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2199
2200         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2201         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2202         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2203         'body' is NULL to the outter 'if', protecting the '!is_define'
2204         situation as well.
2205
2206 2019-05-29  Tom Tromey  <tromey@adacore.com>
2207
2208         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2209         (dwarf_unknown): New function.
2210         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2211         (dwarf_type_encoding_name): Use dwarf_unknown.
2212
2213 2019-05-29  Tom Tromey  <tromey@adacore.com>
2214
2215         PR c++/20020:
2216         * cp-valprint.c (cp_print_value_fields): Call
2217         cp_print_static_field inside "try".
2218
2219 2019-05-29  Tom Tromey  <tromey@adacore.com>
2220
2221         * inflow.c (struct terminal_info): Add default operator=.
2222         * configure: Rebuild.
2223         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2224         -Wdeprecated-copy-dtor, -Wredundant-move.
2225
2226 2019-05-29  Tom Tromey  <tromey@adacore.com>
2227
2228         * NEWS: Add entry.
2229         * infcmd.c (print_return_value_1): Handle finish_print
2230         option.
2231         (show_print_finish): New function.
2232         (_initialize_infcmd): Add "set/show print finish" commands.
2233         * valprint.c (user_print_options): Initialize new member.
2234         * valprint.h (struct value_print_options) <finish_print>: New
2235         member.
2236
2237 2019-05-28  Tom Tromey  <tromey@adacore.com>
2238
2239         * ada-lang.c (ada_remove_Xbn_suffix)
2240         (find_old_style_renaming_symbol)
2241         (parse_old_style_renaming): Remove.
2242         (ada_find_renaming_symbol): Don't call
2243         find_old_style_renaming_symbol.
2244         (ada_is_renaming_symbol): Rename from
2245         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2246         bool.  Now static.
2247         (ada_read_var_value): Update and simplify.
2248         * ada-exp.y (write_var_or_type): Remove old code.
2249
2250 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2251
2252         * event-top.c: Remove include comment.
2253         * inflow.c (class scoped_ignore_sigttou): Move from here...
2254         * inflow.h (class scoped_ignore_sigttou): ...to here.
2255         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2256         * top.c:  Remove include comment.
2257
2258 2019-05-27  Tom Tromey  <tom@tromey.com>
2259
2260         * NEWS: Fix typo.
2261
2262 2019-05-22  Tom Tromey  <tromey@adacore.com>
2263
2264         * target.c (target_follow_exec): Constify parameter.
2265         * target-delegates.c: Rebuild.
2266         * remote.c (remote_target::follow_exec): Constify parameter.
2267         * infrun.c (follow_exec): Constify parameter.
2268         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2269         (target_follow_exec): Likewise.
2270
2271 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2272
2273         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2274         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2275
2276 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2277
2278         * NEWS: Add debugredirect and testsuite sections.
2279
2280 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2281
2282         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2283         target descriptions using exclusively floating point register name
2284         aliases.
2285
2286 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         PR gdb/18644:
2289         * f-lang.c (build_fortran_types): Handle the case where
2290         gdbarch_floatformat_for_type returns a nullptr.
2291
2292 2019-05-21  Tom de Vries  <tdevries@suse.de>
2293
2294         PR cli/24587
2295         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2296
2297 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         PR gdb/18644:
2300         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2301         16-byte floats.
2302         * i386-tdep.c (i386_floatformat_for_type): Use
2303         floatformats_ia64_quad for the 16-byte floating point component
2304         within a fortran 32-byte complex number.
2305
2306 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2309         delete default constructor.
2310         (find_partial_die): Update to return const struct.
2311         (partial_die_parent_scope): Move variable declaration into scope
2312         of its use and change its type to auto.
2313         (guess_partial_die_structure_name): Likewise.
2314         (partial_die_info::fixup): Likewise.
2315
2316 2019-05-17  Tom Tromey  <tromey@adacore.com>
2317
2318         * source.c (find_and_open_source): Remove cast.
2319
2320 2019-05-17  Tom Tromey  <tromey@adacore.com>
2321
2322         * annotate.c (annotate_source): Make "filename" const.
2323         * annotate.h (annotate_source): Use const.
2324
2325 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2326
2327         * disasm.c (set_disassembler_options): Send errors to stderr.
2328
2329 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2330
2331         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2332         (cli_interp_base::set_logging): Check debug_redirect.
2333         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2334         * cli/cli-logging.c (debug_redirect): Add static variable.
2335         (pop_output_files): Add default param.
2336         (handle_redirections): Print debug setting.
2337         (show_logging_command): Likewise.
2338         (_initialize_cli_logging): Add debugredirect command.
2339         * interps.c (current_interp_set_logging): Add debug_redirect
2340         parameter.
2341         * interps.h (set_logging): Add debug_redirect parameter.
2342         (current_interp_set_logging): Likewise.
2343         * mi/mi-common.h: Likewise.
2344         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2345
2346 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2347             Tom Tromey  <tromey@adacore.com>
2348
2349         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2350         directly.
2351         * cli/cli-interp.h (make_logging_output): Remove declaration.
2352         * cli/cli-logging.c (make_logging_output): Remove function.
2353         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2354         directly.
2355         * ui-file.c (tee_file::tee_file): Remove bools.
2356         (tee_file::~tee_file): Remove deletes.
2357         * ui-file.h (tee_file): Remove bools.
2358
2359 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2360
2361         * mi/mi-cmds.h (mi_cmd_complete): New function.
2362         * mi/mi-main.c (mi_cmd_complete): Likewise.
2363         * mi/mi-cmds.c: Define new MI command -complete.
2364         * NEWS: Mention new -complete command.
2365
2366 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2367
2368         * completer.h (complete): New function.
2369         * completer.c (complete): Likewise.
2370         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2371         function defined in completer.h.
2372
2373 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2374
2375         * MAINTAINERS (Write After Approval): Add myself.
2376
2377 2019-05-17  Tom de Vries  <tdevries@suse.de>
2378
2379         PR gdb/24094
2380         * dwarf2read.c (struct cu_partial_die_info): New struct.
2381         (find_partial_die): Return cu_partial_die_info.
2382         (partial_die_parent_scope, guess_partial_die_structure_name)
2383         (partial_die_info::fixup): Handle new return type of find_partial_die.
2384
2385 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2386
2387         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2388         "std::string", simplifying the algorithm.
2389
2390 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2391
2392         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2393         (stap_static_probe_ops::get_probes): Likewise.
2394
2395 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2396
2397         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2398         '-')" and "else if".
2399         (stap_parse_single_operand): Join checks for
2400         "gdbarch_stap_parse_special_token_p" and
2401         "gdbarch_stap_parse_special_token" in the same "if" statement.
2402         Invert check when verifying for operation on register
2403         displacement.
2404
2405 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2406
2407         * stap-probe.c (stap_get_opcode): Update comment.
2408         (stap_get_expected_argument_type): Likewise.
2409         (handle_stap_probe): Likewise.
2410
2411 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2412
2413         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2414         return type to 'bool'.  Adjust comment.  Use 'bool' when
2415         appropriate.
2416         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2417         * stap-probe.c (stap_parse_argument_1): Likewise.
2418         (stap_is_operator): Likewise.
2419         (stap_is_generic_prefix): Likewise.
2420         (stap_is_register_prefix): Likewise.
2421         (stap_is_register_indirection_prefix): Likewise.
2422         (stap_is_integer_prefix): Likewise.
2423         (stap_generic_check_suffix): Likewise.
2424         (stap_check_integer_suffix): Likewise.
2425         (stap_check_register_suffix): Likewise.
2426         (stap_check_register_indirection_suffix): Likewise.
2427         (stap_parse_register_operand): Likewise.
2428         (stap_parse_single_operand): Likewise.
2429         (stap_parse_argument_1): Likewise.
2430         (stap_probe::get_argument_count): Likewise.
2431         (stap_is_operator): Likewise.
2432
2433 2019-05-16  Tom Tromey  <tromey@adacore.com>
2434
2435         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2436         keyword to foreach.
2437
2438 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2439
2440         * linux-thread-db.c (try_thread_db_load_1): Change return type
2441         to bool.
2442         (try_thread_db_load): Likewise.
2443         (try_thread_db_load_from_pdir_1): Likewise.
2444         (try_thread_db_load_from_pdir): Likewise.
2445         (try_thread_db_load_from_sdir): Likewise.
2446         (try_thread_db_load_from_dir): Likewise.
2447         (thread_db_load_search): Likewise.
2448         (has_libpthread): Likewise.
2449         (thread_db_load): Likewise.
2450
2451 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2452
2453         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2454         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2455         NULL, and complain/return if that's the case.
2456
2457 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2458
2459         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2460         (advance, posn, abstract_read_memory): New functions.
2461         [struct mem_read_abstraction]: New struct.
2462         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2463
2464 2019-05-14  Tom Tromey  <tromey@adacore.com>
2465
2466         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2467         value is not lval_memory.
2468
2469 2019-05-14  Tom Tromey  <tromey@adacore.com>
2470
2471         * solib.c (info_sharedlibrary_command): Style the file name.
2472
2473 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2474
2475         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2476         (aarch64_vnv_type): Likewise.
2477         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2478         * common/tdesc.c: Likewise.
2479         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2480         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2481         * features/aarch64-fpu.xml: Add ieee half view.
2482         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2483         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2484         * gdbtypes.h (struct builtin_type): Likewise.
2485         (struct objfile_type): Likewise.
2486
2487 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2488
2489         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2490         typo.
2491         * location.h (string_to_event_location): Likewise.
2492
2493 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2494
2495         GDB 8.3 released.
2496
2497 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2498
2499         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2500         New variable declaration.
2501         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2502         New variable.
2503         (print_one_breakpoint): Use ui_out::test_flags and new global
2504         variable to compute use_fixed_output.
2505         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2506         Remove.
2507         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2508         (mi_multi_location_breakpoint_output_fixed): Remove.
2509         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2510         new variable.
2511         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2512         fix_multi_location_breakpoint_output flag if version >= 3.
2513         * ui-out.h (enum ui_out_flag)
2514         <fix_multi_location_breakpoint_output>: New enumerator.
2515
2516 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2517
2518         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2519
2520 2019-05-10  Tom Tromey  <tromey@adacore.com>
2521
2522         * ada-lang.c (catch_ada_completer): New function.
2523         (_initialize_ada_language): Use it.
2524
2525 2019-05-10  Tom Tromey  <tromey@adacore.com>
2526
2527         * thread.c (print_thread_info): Make "requested_threads" const.
2528         * gdbthread.h (print_thread_info): Make "requested_threads"
2529         const.
2530         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2531         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2532
2533 2019-05-08  Tom Tromey  <tom@tromey.com>
2534
2535         * gdbtypes.c (objfile_type_data): Change type.
2536         (objfile_type, _initialize_gdbtypes): Update.
2537
2538 2019-05-08  Tom Tromey  <tom@tromey.com>
2539
2540         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2541         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2542         (_initialize_dwarf2_frame): Update.
2543
2544 2019-05-08  Tom Tromey  <tom@tromey.com>
2545
2546         * objc-lang.c (objc_objfile_data): Change type.
2547         (find_methods): Update.
2548         (_initialize_objc_lang): Remove.
2549
2550 2019-05-08  Tom Tromey  <tom@tromey.com>
2551
2552         * stabsread.c (rs6000_builtin_type_data): Change type.
2553         (rs6000_builtin_type, _initialize_stabsread): Update.
2554
2555 2019-05-08  Tom Tromey  <tom@tromey.com>
2556
2557         * mips-tdep.c (mips_pdr_data): Remove.
2558         (_initialize_mips_tdep): Update.
2559
2560 2019-05-08  Tom Tromey  <tom@tromey.com>
2561
2562         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2563         (hppa_init_objfile_priv_data, read_unwind_info)
2564         (find_unwind_entry, _initialize_hppa_tdep): Update.
2565
2566 2019-05-08  Tom Tromey  <tom@tromey.com>
2567
2568         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2569         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2570         on obstack.
2571         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2572
2573 2019-05-08  Tom Tromey  <tom@tromey.com>
2574
2575         * mdebugread.c (basic_type_data): Change type.
2576         (basic_type, _initialize_mdebugread): Update.
2577
2578 2019-05-08  Tom Tromey  <tom@tromey.com>
2579
2580         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2581
2582 2019-05-08  Tom Tromey  <tom@tromey.com>
2583
2584         * nto-tdep.c (nto_inferior_data_reg): Change type.
2585         (nto_inferior_data): Update.
2586         (nto_inferior_data_cleanup, nto_new_inferior_data)
2587         (_initialize_nto_tdep): Remove.
2588         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2589
2590 2019-05-08  Tom Tromey  <tom@tromey.com>
2591
2592         * ada-lang.c (struct ada_inferior_data): Add initializers.
2593         (ada_inferior_data): Change type.
2594         (ada_inferior_data_cleanup): Remove.
2595         (get_ada_inferior_data, ada_inferior_exit)
2596         (struct ada_pspace_data): Add initializers, destructor.
2597         (ada_pspace_data_handle): Change type.
2598         (get_ada_pspace_data): Update.
2599         (ada_pspace_data_cleanup): Remove.
2600
2601 2019-05-08  Tom Tromey  <tom@tromey.com>
2602
2603         * coffread.c (struct coff_symfile_info): Add initializers.
2604         (coff_objfile_data_key): Move lower.  Change type.
2605         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2606         Update.
2607         (coff_free_info): Remove.
2608
2609 2019-05-08  Tom Tromey  <tom@tromey.com>
2610
2611         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2612         (fbsd_pspace_data_handle): Move lower.  Change type.
2613         (get_fbsd_pspace_data): Update.
2614         (fbsd_pspace_data_cleanup): Remove.
2615         (_initialize_fbsd_tdep): Update.
2616
2617 2019-05-08  Tom Tromey  <tom@tromey.com>
2618
2619         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2620         (get_ada_tasks_pspace_data): Update.
2621         (ada_tasks_pspace_data_cleanup): Remove.
2622         (_initialize_tasks): Update.
2623         (ada_tasks_inferior_data_handle): Change type.
2624         (get_ada_tasks_inferior_data): Update.
2625         (ada_tasks_inferior_data_cleanup): Remove.
2626         (struct ada_tasks_pspace_data): Add initializers.
2627
2628 2019-05-08  Tom Tromey  <tom@tromey.com>
2629
2630         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2631         * symfile-debug.c (debug_sym_get_probes): Change type.
2632         * stap-probe.c (handle_stap_probe):
2633         (stap_static_probe_ops::get_probes): Change type.
2634         * probe.h (class static_probe_ops) <get_probes>: Change type.
2635         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2636         (parse_probes_in_pspace): Update.
2637         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2638         Update.
2639         (any_static_probe_ops::get_probes): Change type.
2640         * elfread.c (elfread_data): New typedef.
2641         (probe_key): Change type.
2642         (elf_get_probes): Likewise.  Update.
2643         (probe_key_free): Remove.
2644         (_initialize_elfread): Update.
2645         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2646         Change type.
2647         (dtrace_process_dof_probe, dtrace_process_dof)
2648         (dtrace_static_probe_ops::get_probe): Change type.
2649
2650 2019-05-08  Tom Tromey  <tom@tromey.com>
2651
2652         * xcoffread.c (struct xcoff_symfile_info): Rename from
2653         coff_symfile_info.  Add initializers.
2654         (xcoff_objfile_data_key): Move lower.  Change type.
2655         (XCOFF_DATA): Rewrite.
2656         (xcoff_free_info): Remove.
2657         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2658         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2659         (xcoff_initial_scan): Update.
2660
2661 2019-05-08  Tom Tromey  <tom@tromey.com>
2662
2663         * solib-svr4.c (struct svr4_info): Add initializers and
2664         destructor.
2665         <probes_table>: Now an htab_up.
2666         (solib_svr4_pspace_data): Change type.
2667         (free_probes_table): Simplify.
2668         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2669         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2670         (probes_table_remove_objfile_probes, register_solib_event_probe)
2671         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2672         (_initialize_svr4_solib): Update.
2673
2674 2019-05-08  Tom Tromey  <tom@tromey.com>
2675
2676         * remote.c (remote_pspace_data): Change type.
2677         (remote_pspace_data_cleanup): Remove.
2678         (get_remote_exec_file, set_pspace_remote_exec_file)
2679         (_initialize_remote): Update.
2680
2681 2019-05-08  Tom Tromey  <tom@tromey.com>
2682
2683         * breakpoint.c (breakpoint_objfile_key): Change type.
2684         (get_breakpoint_objfile_data): Update.
2685         (free_breakpoint_objfile_data): Remove.
2686         (_initialize_breakpoint): Update.
2687
2688 2019-05-08  Tom Tromey  <tom@tromey.com>
2689
2690         * linux-tdep.c (struct linux_info): Add initializers.
2691         (linux_inferior_data): Move.  Change type.
2692         (invalidate_linux_cache_inf): Update.
2693         (linux_inferior_data_cleanup): Remove.
2694         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2695
2696 2019-05-08  Tom Tromey  <tom@tromey.com>
2697
2698         * auxv.c (auxv_inferior_data): Move.  Change type.
2699         (auxv_inferior_data_cleanup): Remove.
2700         (invalidate_auxv_cache_inf): Rewrite.
2701         (get_auxv_inferior_data, _initialize_auxv): Update.
2702
2703 2019-05-08  Tom Tromey  <tom@tromey.com>
2704
2705         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2706         (symfile_debug_objfile_data_key): Change type.
2707         (symfile_debug_installed, debug_qf_has_symbols)
2708         (debug_qf_find_last_source_symtab)
2709         (debug_qf_forget_cached_source_info)
2710         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2711         (debug_qf_print_stats, debug_qf_dump)
2712         (debug_qf_expand_symtabs_for_function)
2713         (debug_qf_expand_all_symtabs)
2714         (debug_qf_expand_symtabs_with_fullname)
2715         (debug_qf_map_matching_symbols)
2716         (debug_qf_expand_symtabs_matching)
2717         (debug_qf_find_pc_sect_compunit_symtab)
2718         (debug_qf_map_symbol_filenames)
2719         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2720         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2721         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2722         (debug_sym_read_linetable, debug_sym_relocate): Update.
2723         (symfile_debug_free_objfile): Remove.
2724         (install_symfile_debug_logging, _initialize_symfile_debug):
2725         Update.
2726
2727 2019-05-08  Tom Tromey  <tom@tromey.com>
2728
2729         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2730         allocate_on_obstack.
2731         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2732         (get_dwarf2_per_objfile): Update.
2733         (set_dwarf2_per_objfile): Remove.
2734         (dwarf2_has_info, dwarf2_get_section_info): Update.
2735         (dwarf2_free_objfile): Remove.
2736         (_initialize_dwarf2_read): Update.
2737
2738 2019-05-08  Tom Tromey  <tom@tromey.com>
2739
2740         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2741         initializers.
2742         <unsupported_script_warning_printed,
2743         script_not_found_warning_printed>: Now bool.
2744         (auto_load_pspace_data): Change type.
2745         (~auto_load_pspace_info): Rename from
2746         auto_load_pspace_data_cleanup.
2747         (get_auto_load_pspace_data, init_loaded_scripts_info)
2748         (clear_section_scripts, maybe_print_unsupported_script_warning)
2749         (maybe_print_script_not_found_warning, _initialize_auto_load):
2750         Update.
2751
2752 2019-05-08  Tom Tromey  <tom@tromey.com>
2753
2754         * objfiles.c (objfile_pspace_info): Add destructor and
2755         initializers.
2756         (objfiles_pspace_data): Change type.
2757         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2758         (get_objfile_pspace_data): Update.
2759         (objfiles_bfd_data): Change type.
2760         (get_objfile_bfd_data): Update.
2761         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2762
2763 2019-05-08  Tom Tromey  <tom@tromey.com>
2764
2765         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2766         Change type.
2767         (get_catch_syscall_inferior_data): Update.
2768         (catch_syscall_inferior_data_cleanup): Remove.
2769         (_initialize_break_catch_syscall): Update.
2770
2771 2019-05-08  Tom Tromey  <tom@tromey.com>
2772
2773         * inflow.c (struct terminal_info): Add destructor and
2774         initializers.
2775         (inflow_inferior_data): Change type.
2776         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2777         (get_inflow_inferior_data, inflow_inferior_exit)
2778         (swap_terminal_info, _initialize_inflow): Update.
2779
2780 2019-05-08  Tom Tromey  <tom@tromey.com>
2781
2782         * target-dcache.c (target_dcache_cleanup): Remove.
2783         (target_dcache_aspace_key): Change type.
2784         (target_dcache_init_p, target_dcache_invalidate)
2785         (target_dcache_get, target_dcache_get_or_init)
2786         (_initialize_target_dcache): Update.
2787         * dcache.h (struct dcache_deleter): New.
2788
2789 2019-05-08  Tom Tromey  <tom@tromey.com>
2790
2791         * symtab.c (struct symbol_cache): Add destructor and
2792         initializers.
2793         (symbol_cache_key): Move.  Change type.
2794         (make_symbol_cache, free_symbol_cache): Remove.
2795         (get_symbol_cache): Update.
2796         (symbol_cache_cleanup): Remove.
2797         (ALL_PSPACES, symbol_cache_flush)
2798         (maintenance_print_symbol_cache)
2799         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2800         Update.
2801
2802 2019-05-08  Tom Tromey  <tom@tromey.com>
2803
2804         * symtab.c (struct main_info): Add destructor and initializers.
2805         (main_progspace_key): Move.  Change type.
2806         (get_main_info): Update.
2807         (main_info_cleanup): Remove.
2808         (_initialize_symtab): Update.
2809
2810 2019-05-08  Tom Tromey  <tom@tromey.com>
2811
2812         * registry.h (DECLARE_REGISTRY): Define the _key class.
2813
2814 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         * NEWS: Merge two 'New commands' sections.
2817
2818 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2819
2820         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2821         parameter and use Ada language definition instead.
2822         (ada_val_print_ptr): Remove unused language parameter.
2823         (ada_val_print_num): Remove language parameter and use Ada language
2824         definition instead.
2825         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2826         parameter.
2827         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2828         parameter and use Ada language definition instead.
2829         (ada_val_print_1): Update all ada_val_print_xxx calls.
2830         Remove language parameter.
2831         (ada_val_print): Update ada_val_print_1 call.
2832
2833 2019-05-08  Tom Tromey  <tromey@adacore.com>
2834
2835         * remote.c (remote_hw_watchpoint_limit)
2836         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2837         Now static.
2838
2839 2019-05-08  Tom Tromey  <tromey@adacore.com>
2840
2841         * maint.c (_initialize_maint_cmds): Move initialization code to
2842         remote.c.
2843         (watchdog, show_watchdog): Move to remote.c.
2844         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2845         "watchdog" static.
2846         (_initialize_remote): Move initialization code from maint.c.
2847         * defs.h (watchdog): Don't declare.
2848
2849 2019-05-08  Tom Tromey  <tromey@adacore.com>
2850
2851         * tui/tui-interp.c: Include main.h.
2852         * interps.c: Include main.h.
2853         * main.h (interpreter_p): Declare.
2854         * defs.h (interpreter_p): Don't declare.
2855
2856 2019-05-08  Tom Tromey  <tromey@adacore.com>
2857
2858         * dwarf2loc.c: Include dwarf2read.h.
2859         * defs.h (read_unsigned_leb128): Don't declare.
2860         * dwarf2read.h (read_unsigned_leb128): Declare.
2861
2862 2019-05-08  Tom Tromey  <tromey@adacore.com>
2863
2864         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2865         method.
2866
2867 2019-05-08  Tom Tromey  <tromey@adacore.com>
2868
2869         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2870         when no wrap column is set.
2871
2872 2019-05-08  Tom Tromey  <tromey@adacore.com>
2873
2874         * c-lang.c (c_get_string): Handle non-C-style arrays.
2875
2876 2019-05-08  Tom Tromey  <tromey@adacore.com>
2877
2878         * typeprint.c (print_offset_data::update): Print the bit offset,
2879         not the number of bits remaining.
2880
2881 2019-05-08  Tom Tromey  <tromey@adacore.com>
2882
2883         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2884         padding at end of comment.
2885
2886 2019-05-08  Tom Tromey  <tromey@adacore.com>
2887
2888         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2889         Compare main types.
2890
2891 2019-05-06  Tom Tromey  <tom@tromey.com>
2892
2893         * common/scoped_mmap.c: Include common-defs.h.
2894         * common/scoped_mmap.h: Don't include config.h.
2895
2896 2019-05-04  Tom Tromey  <tom@tromey.com>
2897
2898         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2899         (struct aarch64_call_info): Add initializers.
2900         <si>: Now a std::vector.
2901         (pass_on_stack, aarch64_push_dummy_call): Update.
2902
2903 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2904             Tom Tromey  <tom@tromey.com>
2905
2906         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2907         (ppc_threads): Now a std::vector.  Now static.
2908         (hwdebug_find_thread_points_by_tid)
2909         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2910         Update.
2911
2912 2019-05-04  Tom Tromey  <tom@tromey.com>
2913
2914         * arc-tdep.c (arc_tdesc_init): Return bool.
2915
2916 2019-05-04  Tom Tromey  <tom@tromey.com>
2917
2918         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2919         Use gdb_assert_not_reached.
2920
2921 2019-05-04  Tom Tromey  <tom@tromey.com>
2922
2923         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2924         "false".
2925
2926 2019-05-04  Tom Tromey  <tom@tromey.com>
2927
2928         * arc-tdep.c (arc_tdesc_init): Use bool.
2929
2930 2019-05-04  Tom Tromey  <tom@tromey.com>
2931
2932         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2933
2934 2019-05-04  Tom Tromey  <tom@tromey.com>
2935
2936         * cli/cli-cmds.c (valid_command_p): Return bool.
2937
2938 2019-05-04  Tom Tromey  <tom@tromey.com>
2939
2940         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2941         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2942
2943 2019-05-04  Raul Tambre  <raul@tambre.ee>
2944
2945         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2946         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2947         operator for comparison.
2948
2949 2019-05-04  Tom Tromey  <tom@tromey.com>
2950
2951         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2952         (lookup_partial_symbol, print_partial_symbols)
2953         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2954         (psymbol_compare): Update.
2955         (add_psymbol_to_bcache): Clear the entire psymbol.
2956         (maintenance_check_psymtabs): Update.
2957         * psympriv.h (struct partial_symbol): Don't derive from
2958         general_symbol_info.
2959         <obj_section, unrelocated_address, address,
2960         set_unrelocated_address>: Update.
2961         <ginfo>: New member.
2962         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2963         (debug_names::write_psymbols): Update.
2964
2965 2019-05-04  Tom de Vries  <tdevries@suse.de>
2966
2967         * contrib/cc-with-tweaks.sh: Support -n arg.
2968
2969 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2970
2971         * corelow.c (core_target::detach): Ensure frame cache and
2972         register caches are cleared.
2973         inferior.c (exit_inferior_1): Likewise.
2974
2975 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2976             Tom Tromey  <tom@tromey.com>
2977
2978         * dictionary.c (collate_pending_symbols_by_language): Remove
2979         "struct" from foreach.
2980         * symtab.c (lookup_global_symbol_from_objfile)
2981         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2982         foreach.
2983         * ser-tcp.c (net_open): Remove "struct" from foreach.
2984         * objfiles.c (objfile_relocate, objfile_rebase)
2985         (objfile_has_symbols): Remove "struct" from foreach.
2986         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2987         from foreach.
2988         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2989         foreach.
2990         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2991         "struct" from foreach.
2992         * ada-lang.c (create_excep_cond_exprs)
2993         (ada_exception_catchpoint_cond_string): Remove "struct" from
2994         foreach.
2995
2996 2019-05-03  Tom Tromey  <tromey@adacore.com>
2997
2998         * ada-exp.y (convert_char_literal): Check suffix of each
2999         enumerator.
3000
3001 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3002
3003         PR ada/21406:
3004         * ada-exp.y (yywrap): Don't define.
3005         * ada-lex.l (%option): Add noyywrap
3006         (yywrap): Remove.
3007
3008 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3009
3010         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3011         _WIN32_WINNT to the XP level, unless already defined to a higher
3012         level.
3013
3014         * unittests/parse-connection-spec-selftests.c:
3015         * ser-tcp.c:
3016         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3017         override.
3018
3019         * symfile.c (find_separate_debug_file): Remove colon from the
3020         drive spec of DOS/Windows file names of the target, so that the
3021         file name produced from DEBUGDIR and the target's directory will
3022         be valid on DOS/Windows systems.
3023
3024 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3025
3026         * rust-lang.c (val_print_struct): Handle printing structures
3027         containing strings.
3028
3029 2019-05-02  Tom Tromey  <tromey@adacore.com>
3030
3031         * valarith.c (_initialize_valarith): Remove.
3032
3033 2019-05-01  Tom Tromey  <tromey@adacore.com>
3034
3035         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3036         bitfields.
3037
3038 2019-05-01  Tom Tromey  <tromey@adacore.com>
3039
3040         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3041         for big-endian copies.
3042
3043 2019-04-30  Ali Tamur  <tamur@google.com>
3044         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3045         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3046         (read_3_bytes): New function.
3047
3048 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3049
3050         * windows-nat.c (main_thread_id): Delete.
3051         (handle_output_debug_string): Replace main_thread_id by
3052         current_event.dwThreadId.
3053         (fake_create_process): Likewise.
3054         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3055         Do not set main_thread_id.
3056         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3057         current_event.dwThreadId.
3058         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3059
3060 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3061
3062         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3063         Use current_event.dwThreadId instead of main_thread_id.
3064
3065 2019-04-30  Tom Tromey  <tromey@adacore.com>
3066
3067         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3068         (create_excep_cond_exprs): Iterate over program spaces.
3069         (ada_exception_catchpoint_cond_string): Examine all minimal
3070         symbols for exception types.
3071
3072 2019-04-30  Tom Tromey  <tromey@adacore.com>
3073
3074         PR c++/24470:
3075         * dwarf2read.c (process_structure_scope): Handle case where type
3076         has template parameters but no symbol was created.
3077
3078 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3079             Chris January  <chris.january@arm.com>
3080
3081         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3082         qualifier.
3083         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3084
3085 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3086
3087         * f-typeprint.c (f_print_type): Update rules for printing
3088         whitespace.
3089         (f_type_print_varspec_suffix): Likewise.
3090
3091 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3092             Chris January  <chris.january@arm.com>
3093
3094         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3095         function arguments.
3096
3097 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3098
3099         * f-lang.c (build_fortran_types): Change name of void type to
3100         lower case.
3101         * f-typeprint.c (f_type_print_base): Print the name of the void
3102         type, rather than a fixed string.
3103         * f-valprint.c (f_decorations): Use lower case void string.
3104
3105 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3106             Chris January  <chris.january@arm.com>
3107
3108         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3109         types for Fortran.
3110
3111 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3112             Chris January  <chris.january@arm.com>
3113             David Lecomber  <david.lecomber@arm.com>
3114
3115         * f-exp.y (BINOP_INTRINSIC): New token.
3116         (exp): New parser rule handling BINOP_INTRINSIC.
3117         (f77_keywords): Add new builtin procedures.
3118         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3119         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3120         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3121         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3122         (print_unop_subexp_f): New function.
3123         (print_binop_subexp_f): New function.
3124         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3125         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3126         (dump_subexp_body_f): Likewise.
3127         (operator_check_f): Likewise.
3128         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3129         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3130
3131 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3132
3133         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3134         UNOP_KIND.
3135         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3136         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3137         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3138         (operator_length_f): New fuction.
3139         (print_subexp_f): New function.
3140         (op_name_f): New function.
3141         (dump_subexp_body_f): New function.
3142         (operator_check_f): New function.
3143         (exp_descriptor_f): Replace standard expression handling functions
3144         with new functions.
3145         * gdb/fortran-operator.def: New file.
3146         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3147         * gdb/std-operator.def: Remove UNOP_KIND.
3148
3149 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3150
3151         * std-operator.def: Remove unbalanced, stray double quote
3152         character.
3153
3154 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3155             Chris January  <chris.january@arm.com>
3156             Daniel Everett  <daniel.everett@arm.com>
3157             Nick Forrington  <nick.forrington@arm.com>
3158             Richard Bunt  <richard.bunt@arm.com>
3159
3160         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3161         of depth when printing anonymous structs or unions.
3162         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3163         Don't print either the top-level value, or the children if the
3164         max-depth is exceeded.
3165         (ppscm_print_children): When printing the key of a map, allow one
3166         extra level of depth.
3167         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3168         print either the top-level value, or the children if the max-depth
3169         is exceeded.
3170         (print_children): When printing the key of a map, allow one extra
3171         level of depth.
3172         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3173         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3174         (user_print_options): Initialise max_depth field.
3175         (val_print_scalar_or_string_type_p): New function.
3176         (val_print): Check to see if the max depth has been reached.
3177         (val_print_check_max_depth): Define new function.
3178         (show_print_max_depth): New function.
3179         (_initialize_valprint): Add 'print max-depth' option.
3180         * valprint.h (struct value_print_options) <max_depth>: New field.
3181         (val_print_check_max_depth): Declare new function.
3182         * NEWS: Document new feature.
3183
3184 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * ada-lang.c (ada_language_defn): Initialise new field.
3187         * c-lang.c (c_is_string_type_p): New function.
3188         (c_language_defn): Initialise new field.
3189         (cplus_language_defn): Initialise new field.
3190         (asm_language_defn): Initialise new field.
3191         (minimal_language_defn): Initialise new field.
3192         * c-lang.h (c_is_string_type_p): Declare new function.
3193         * d-lang.c (d_language_defn): Initialise new field.
3194         * f-lang.c (f_is_string_type_p): New function.
3195         (f_language_defn): Initialise new field.
3196         * go-lang.c (go_is_string_type_p): New function.
3197         (go_language_defn): Initialise new field.
3198         * language.c (default_is_string_type_p): New function.
3199         (unknown_language_defn): Initialise new field.
3200         (auto_language_defn): Initialise new field.
3201         * language.h (struct language_defn) <la_is_string_type_p>: New
3202         member variable.
3203         (default_is_string_type_p): Declare new function.
3204         * m2-lang.c (m2_language_defn): Initialise new field.
3205         * objc-lang.c (objc_language_defn): Initialise new field.
3206         * opencl-lang.c (opencl_language_defn): Initialise new field.
3207         * p-lang.c (pascal_is_string_type_p): New function.
3208         (pascal_language_defn): Initialise new field.
3209         * rust-lang.c (rust_is_string_type_p): New function.
3210         (rust_language_defn): Initialise new field.
3211
3212 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3215         New field.
3216         * ada-lang.c (ada_language_defn): Initialise new field.
3217         * c-lang.c (c_language_defn): Likewise.
3218         (cplus_language_defn): Likewise.
3219         (asm_language_defn): Likewise.
3220         (minimal_language_defn): Likewise.
3221         * d-lang.c (d_language_defn): Likewise.
3222         * f-lang.c (f_language_defn): Likewise.
3223         * go-lang.c (go_language_defn): Likewise.
3224         * language.c (unknown_language_defn): Likewise.
3225         (auto_language_defn): Likewise.
3226         * m2-lang.c (m2_language_defn): Likewise.
3227         * objc-lang.c (objc_language_defn): Likewise.
3228         * opencl-lang.c (opencl_language_defn): Likewise.
3229         * p-lang.c (pascal_language_defn): Likewise.
3230         * rust-lang.c (rust_language_defn): Likewise.
3231
3232 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3233
3234         * ada-lang.c (ada_is_character_type): Change return type to bool.
3235         (ada_is_string_type): Likewise.
3236         * ada-lang.h (ada_is_character_type): Update declaration
3237         (ada_is_string_type): Likewise.
3238
3239 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3240
3241         Support style in 'frame|thread apply'
3242
3243         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3244         * record.c (record_start, record_stop): Update callers of
3245         execute_command_to_string with false.
3246         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3247         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3248         methods.
3249         (class string_file): New constructor with term_out parameter.
3250         Override methods term_out and can_emit_style_escape.  New member
3251         term_out.
3252         (class stdio_file): Override can_emit_style_escape.
3253         (class tee_file): Override term_out and can_emit_style_escape.
3254         * utils.h (can_emit_style_escape): Remove.
3255         * utils.c (can_emit_style_escape): Likewise.
3256         Update all callers of can_emit_style_escape (SOMESTREAM) to
3257         SOMESTREAM->can_emit_style_escape.
3258         * source-cache.c (source_cache::get_source_lines): Likewise.
3259         * stack.c (frame_apply_command_count): Call execute_command_to_string
3260         passing the term_out characteristic of the current gdb_stdout.
3261         * thread.c (thr_try_catch_cmd): Likewise.
3262         * top.c (execute_command_to_string): pass term_out parameter
3263         to construct the string_file for the command output.
3264         * ui-file.c (term_cli_styling): New function (most code moved
3265         from utils.c can_emit_style_escape).
3266         (string_file::string_file, string_file::can_emit_style_escape,
3267         stdio_file::can_emit_style_escape, tee_file::term_out,
3268         tee_file::can_emit_style_escape): New functions.
3269
3270 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3271
3272         * NEWS: Mention the new set|show may-call-functions.
3273         * infcall.c (may_call_functions_p): New variable.
3274         (show_may_call_functions_p): New function.
3275         (call_function_by_hand_dummy): Throws an error if not
3276         may-call-functions.
3277         (_initialize_infcall): Call add_setshow_boolean_cmd for
3278         may-call-functions.
3279
3280 2019-04-25  Keith Seitz  <keiths@redhat.com>
3281
3282         PR c++/24367
3283         * cp-support.c (inspect_type): Don't attempt substitutions
3284         of symbol with the same name.
3285
3286 2019-04-25  Tom Tromey  <tromey@adacore.com>
3287
3288         PR gdb/24475:
3289         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3290         static.
3291
3292 2019-04-25  Tom Tromey  <tromey@adacore.com>
3293
3294         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3295         rvalue reference.
3296         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3297         (gdb_xml_parser::parse): Use std::move.
3298         * python/python-internal.h (gdbpy_convert_exception): Take a const
3299         reference.
3300         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3301         std::move.
3302         * python/py-utils.c (gdbpy_convert_exception): Take a const
3303         reference.
3304         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3305         Use std::move.
3306         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3307         Use std::move.
3308         * mi/mi-main.c (mi_print_exception): Take a const reference.
3309         * main.c (handle_command_errors): Take a const reference.
3310         * linespec.c (parse_linespec): Use std::move.
3311         * infcall.c (run_inferior_call): Use std::move.
3312         (call_function_by_hand_dummy): Use std::move.
3313         * exec.c (try_open_exec_file): Use std::move.
3314         * exceptions.h (exception_print, exception_fprintf)
3315         (exception_print_same): Update.
3316         * exceptions.c (print_exception, exception_print)
3317         (exception_fprintf, exception_print_same): Change parameters to
3318         const reference.
3319         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3320         * common/new-op.c: Use std::move.
3321         * common/common-exceptions.h (struct gdb_exception): Add move
3322         constructor.
3323         (struct gdb_exception_error, struct gdb_exception_quit, struct
3324         gdb_quit_bad_alloc): Change constructor to move constructor.
3325         (throw_exception): Change parameter to rvalue reference.
3326         * common/common-exceptions.c (throw_exception): Take rvalue
3327         reference.
3328         * cli/cli-interp.c (safe_execute_command): Use std::move.
3329         * breakpoint.c (insert_bp_location, location_to_sals): Use
3330         std::move.
3331
3332 2019-04-25  Tom Tromey  <tromey@adacore.com>
3333
3334         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3335         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3336         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3337         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3338         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3339         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3340         guile/scm-value.c: Use unpack.
3341         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3342         gdbscm_gdb_exception.
3343         (gdbscm_throw_gdb_exception): Likewise.
3344         (struct gdbscm_gdb_exception): New.
3345         (unpack): New function.
3346         (gdbscm_wrap): Use unpack.
3347
3348 2019-04-25  Tom Tromey  <tromey@adacore.com>
3349
3350         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3351         (gdb_rl_callback_handler): Use std::move.
3352         * common/common-exceptions.h (struct gdb_exception): Add move
3353         assignment operator.
3354         (throw_exception_sjlj): Change "exception" to const reference.
3355         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3356         (throw_exception_sjlj): Change "exception" to const reference.
3357
3358 2019-04-25  Tom Tromey  <tromey@adacore.com>
3359
3360         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3361         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3362         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3363         Update.
3364         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3365         Update.
3366         * mi/mi-interp.c (mi_interp::exec): Update.
3367         * linespec.c (parse_linespec): Update.
3368         * infcall.c (run_inferior_call): Update.
3369         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3370         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3371         (gdbscm_lookup_global_symbol): Update.
3372         * guile/scm-param.c (gdbscm_parameter_value): Update.
3373         * guile/scm-frame.c (gdbscm_frame_read_register)
3374         (gdbscm_frame_read_var): Update.
3375         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3376         * exec.c (try_open_exec_file): Update.
3377         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3378         (gdb_rl_callback_handler): Update.
3379         * common/common-exceptions.h (exception_none): Don't declare.
3380         * common/common-exceptions.c (exception_none): Don't define.
3381         (struct catcher) <exception>: Update.
3382         * cli/cli-interp.c (safe_execute_command): Update.
3383         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3384
3385 2019-04-25  Ali Tamur  <tamur@google.com>
3386
3387         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3388         (read_attribute_value): Likewise.
3389         (dwarf2_read_addr_index): Update comment.
3390         (read_str_index): Add DW_FORM_strx.
3391         (dwarf2_string_attr): Likewise.
3392         (dwarf2_const_value_attr): Likewise.
3393         (dump_die_shallow): Likewise.
3394         (dwarf2_fetch_constant_bytes): Likewise.
3395         (skip_form_bytes): Likewise.
3396         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3397
3398 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3399
3400         PR corefiles/11608
3401         PR corefiles/18187
3402         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3403         OFFSET.  Verify if current mapping contains an ELF header.
3404         (linux_find_memory_regions_full): Adjust call to
3405         dump_mapping_p.
3406
3407 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3408             Kang Li <kanglictf@gmail.com>
3409
3410         PR gdb/21600
3411
3412         * dwarf2-frame.c (read_initial_length): Be consistent about using
3413         unsigned representation of length.
3414         (decode_frame_entry_1): Likewise.  Check for wraparound of
3415         end pointer as well as buffer overflow.
3416
3417 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3418
3419         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3420         "vq".
3421
3422 2019-04-24  Tom Tromey  <tromey@adacore.com>
3423
3424         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3425
3426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3427
3428         * s12z-tdep.c (s12z_unwind_pc): Delete.
3429         (s12z_unwind_sp): Delete.
3430         (s12z_gdbarch_init): Don't register deleted functions with
3431         gdbarch.
3432
3433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3434
3435         * rl78-tdep.c (rl78_unwind_sp): Delete.
3436         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3437
3438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3439
3440         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3441         (xstormy16_unwind_pc): Delete.
3442         (xstormy16_dummy_id): Delete.
3443         (xstormy16_gdbarch_init): Don't register deleted functions with
3444         gdbarch.
3445
3446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3447
3448         * vax-tdep.c (vax_unwind_pc): Delete.
3449         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3450
3451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3452
3453         * v850-tdep.c (v850_unwind_sp): Delete.
3454         (v850_unwind_pc): Delete.
3455         (v850_dummy_id): Delete.
3456         (v850_gdbarch_init): Don't register deleted functions with
3457         gdbarch.
3458
3459 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3460
3461         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3462         (tilegx_unwind_pc): Delete.
3463         (tilegx_unwind_dummy_id): Delete.
3464         (tilegx_gdbarch_init): Don't register deleted functions with
3465         gdbarch.
3466
3467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3468
3469         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3470         (tic6x_dummy_id): Delete.
3471         (tic6x_gdbarch_init): Don't register deleted functions with
3472         gdbarch.
3473
3474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3475
3476         * sparc-tdep.c (sparc_unwind_pc): Delete.
3477         (sparc32_gdbarch_init): Don't register deleted function with
3478         gdbarch.
3479
3480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * sh-tdep.c (sh_unwind_sp): Delete.
3483         (sh_unwind_pc): Delete.
3484         (sh_dummy_id): Delete.
3485         (sh_gdbarch_init): Don't register deleted functions with
3486         gdbarch.
3487
3488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * score-tdep.c (score_unwind_sp): Delete.
3491         (score_unwind_pc): Delete.
3492         (score_dummy_id): Delete.
3493         (score_gdbarch_init): Don't register deleted functions with
3494         gdbarch.
3495
3496 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3497
3498         * rx-tdep.c (rx_unwind_pc): Delete.
3499         (rx_unwind_sp): Delete.
3500         (rx_dummy_id): Delete.
3501         (rx_gdbarch_init): Don't register deleted functions with
3502         gdbarch.  Update comment.
3503
3504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3505
3506         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3507         (rs6000_dummy_id): Delete.
3508         (rs6000_gdbarch_init): Don't register deleted functions with
3509         gdbarch.
3510
3511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         * or1k-tdep.c (or1k_dummy_id): Delete.
3514         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3515
3516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3517
3518         * nios2-tdep.c (nios2_dummy_id): Delete.
3519         (nios2_unwind_sp): Delete.
3520         (nios2_gdbarch_init): Don't register deleted functions with
3521         gdbarch.
3522
3523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3524
3525         * nds32-tdep.c (nds32_dummy_id): Delete.
3526         (nds32_unwind_pc): Delete.
3527         (nds32_unwind_sp): Delete.
3528         (nds32_gdbarch_init): Don't register deleted functions with
3529         gdbarch.
3530
3531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3532
3533         * msp430-tdep.c (msp430_unwind_pc): Delete.
3534         (msp430_unwind_sp): Delete.
3535         (msp430_dummy_id): Delete.
3536         (msp430_gdbarch_init): Don't register deleted functions with
3537         gdbarch.
3538
3539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3540
3541         * moxie-tdep.c (moxie_unwind_sp): Delete.
3542         (moxie_unwind_pc): Delete.
3543         (moxie_dummy_id): Delete.
3544         (moxie_gdbarch_init): Don't register deleted functions with
3545         gdbarch.
3546
3547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3550         (mn10300_unwind_pc): Delete.
3551         (mn10300_unwind_sp): Delete.
3552         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3553         mn10300_unwind_sp.
3554         (mn10300_frame_unwind_init): Don't register deleted functions with
3555         gdbarch.
3556
3557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3558
3559         * mep-tdep.c (mep_unwind_pc): Delete.
3560         (mep_unwind_sp): Delete.
3561         (mep_dummy_id): Delete.
3562         (mep_gdbarch_init): Don't register deleted functions with
3563         gdbarch.
3564
3565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3566
3567         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3568         (m68hc11_unwind_sp): Delete.
3569         (m68hc11_gdbarch_init): Don't register deleted functions with
3570         gdbarch.
3571
3572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * m32r-tdep.c (m32r_unwind_sp): Delete.
3575         (m32r_unwind_pc): Delete.
3576         (m32r_dummy_id): Delete.
3577         (m32r_gdbarch_init): Don't register deleted functions with
3578         gdbarch.
3579
3580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3581
3582         * m32c-tdep.c (m32c_unwind_pc): Delete.
3583         (m32c_unwind_sp): Delete.
3584         (m32c_dummy_id): Delete.
3585         (m32c_gdbarch_init): Don't register deleted functions with
3586         gdbarch.
3587
3588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3589
3590         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3591         (lm32_unwind_pc): Delete.
3592         (lm32_dummy_id): Delete.
3593         (lm32_gdbarch_init): Don't register deleted functions with
3594         gdbarch.
3595
3596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3599         (iq2000_unwind_pc): Delete.
3600         (iq2000_dummy_id): Delete.
3601         (iq2000_gdbarch_init): Don't register deleted functions with
3602         gdbarch.
3603
3604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3605
3606         * nds32-tdep.c (nds32_type_align): Delete.
3607         (nds32_push_dummy_call): Use type_align instead.
3608
3609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         * arm-tdep.c (arm_type_align): Only handle vector override case.
3612         (arm_push_dummy_call): Use type_align.
3613         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3614
3615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3616
3617         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3618         case.
3619         (pass_on_stack): Use type_align.
3620         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3621         function.
3622
3623 2019-04-23  Tom Tromey  <tromey@adacore.com>
3624
3625         * dwarf2read.c (line_header::file_name_at): Remove unused
3626         overload.
3627
3628 2019-04-23  Tom de Vries  <tdevries@suse.de>
3629
3630         PR gdb/24438
3631         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3632         invocation.
3633
3634
3635 2019-03-27  Ali Tamur  <tamur@google.com>
3636
3637         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3638         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3639         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3640         (dwarf_expr_context::get_addr_index): Likewise
3641         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3642         (symbol_needs_eval_context::get_addr_index): Likewise
3643         (disassemble_dwarf_expression): Add DW_OP_addrx
3644         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3645         (read_cutu_die_from_dwo): Update comment
3646         (skip_one_die): Add DW_FORM_addrx
3647         (read_attribute_value): Likewise
3648         (var_decode_location): Add DW_OP_addrx
3649         (dwarf2_const_value_attr): Add DW_FORM_addrx
3650         (dump_die_shallow): Likewise
3651         (dwarf2_fetch_constant_bytes): Likewise
3652         (decode_locdesc): Add DW_OP_addrx
3653         (skip_form_bytes): Add DW_FORM_addrx
3654
3655 2019-04-22  Ali Tamur  <tamur@google.com>
3656
3657         * MAINTAINERS (Write After Approval): Add self.
3658
3659 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3660
3661         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3662         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3663         (open_symbol_file_object): Likewise.
3664         (svr4_default_sos): Add info parameter.
3665         (svr4_read_so_list): Likewise.
3666         (svr4_current_sos_direct): Adjust functions calls to pass down
3667         info.
3668         (svr4_current_sos_1): Add info parameter.
3669         (svr4_current_sos): Call get_svr4_info, pass info down to
3670         svr4_current_sos_1.
3671         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3672         get_svr4_info.
3673         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3674         get_svr4_info.
3675         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3676         to get_svr4_info.
3677         (probes_table_remove_objfile_probes): Likewise.
3678         (register_solib_event_probe): Add info parameter.
3679         (solist_update_incremental): Pass info parameter down to
3680         svr4_read_so_list.
3681         (disable_probes_interface): Add info parameter.
3682         (svr4_handle_solib_event): Pass current_program_space to
3683         get_svr4_info.  Adjust disable_probes_interface cleanup.
3684         (svr4_create_probe_breakpoints): Add info parameter, pass it
3685         down to register_solib_event_probe.
3686         (svr4_create_solib_event_breakpoints): Add info parameter,
3687         pass it down to svr4_create_probe_breakpoints.
3688         (enable_break): Pass info down to
3689         svr4_create_solib_event_breakpoints.
3690         (svr4_solib_create_inferior_hook): Pass current_program_space to
3691         get_svr4_info.
3692         (svr4_clear_solib): Likewise.
3693
3694 2019-04-22  Pedro Alves  <palves@redhat.com>
3695
3696         * solib-svr4.c (svr4_free_objfile_observer): New.
3697         (probe_and_action::objfile): New field.
3698         (probes_table_htab_remove_objfile_probes)
3699         (probes_table_remove_objfile_probes): New functions.
3700         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3701         in the new probe_and_action.  Don't store the probe in 'lookup'.
3702         (svr4_create_probe_breakpoints): Pass objfile to
3703         register_solib_event_probe.
3704         (_initialize_svr4_solib): Register a free_objfile observer.
3705
3706 2019-04-19  Tom Tromey  <tom@tromey.com>
3707
3708         * common/queue.h: Remove.
3709
3710 2019-04-19  Tom Tromey  <tom@tromey.com>
3711
3712         * event-loop.c: Don't include "common/queue.h".
3713
3714 2019-04-19  Tom Tromey  <tom@tromey.com>
3715
3716         * remote.c (remote_target): Use delete.
3717         * remote-notif.h: Include <list>, not "common/queue.h".
3718         (notif_client_p): Remove typedef.
3719         (remote_notif_state): Add constructor, destructor, initializer.
3720         <notif_queue>: Now a std::list.
3721         (remote_notif_state_xfree): Don't declare.
3722         * remote-notif.c (remote_notif_process, handle_notification)
3723         (remote_notif_state_allocate): Update.
3724         (~remote_notif_state): Rename from remote_notif_state_xfree.
3725
3726 2019-04-19  Tom Tromey  <tom@tromey.com>
3727
3728         * symfile.c (reread_symbols): Update.
3729         * objfiles.c (objfile_register_static_link)
3730         (objfile_lookup_static_link): Update
3731         (~objfile) Don't delete static_links.
3732         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3733
3734 2019-04-19  Tom Tromey  <tom@tromey.com>
3735
3736         * type-stack.h (struct type_stack) <insert>: Constify string.
3737         * type-stack.c (type_stack::insert): Constify string.
3738         * gdbtypes.h (lookup_template_type): Update.
3739         (address_space_name_to_int): Update.
3740         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3741         const.
3742         (lookup_template_type): Make name const.
3743         * c-exp.y: Update rules.
3744         (lex_one_token, classify_name, classify_inner_name)
3745         (c_print_token): Update.
3746         * p-exp.y: Update rules.
3747         (yylex): Update.
3748         * f-exp.y: Update rules.
3749         (yylex): Update.
3750         * d-exp.y: Update rules.
3751         (lex_one_token, classify_name, classify_inner_name): Update.
3752         * parse.c (write_dollar_variable, copy_name): Return std::string.
3753         * parser-defs.h (copy_name): Change return type.
3754         * m2-exp.y: Update rules.
3755         (yylex): Update.
3756         * go-exp.y (lex_one_token): Update.
3757         Update rules.
3758         (classify_unsafe_function, classify_packaged_name)
3759         (classify_name, yylex): Update.
3760
3761 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3762
3763         * configure.ac: add --enable-source-highlight switch.
3764         * configure: Regenerate.
3765         * top.c (print_gdb_version): plumb --enable-source-highlight
3766         status to "show configuration".
3767
3768 2019-04-19  Tom Tromey  <tromey@adacore.com>
3769
3770         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3771         Check ADA_TYPE_P.
3772         (empty_record, ada_template_to_fixed_record_type_1)
3773         (template_to_static_fixed_type)
3774         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3775         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3776         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3777         macros.
3778
3779 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3780
3781         PR symtab/24423:
3782         * source.c (print_source_lines_base): Advance "iter" when a
3783         control character is seen.
3784
3785 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3786
3787         * inferior.h (struct infcall_suspend_state_deleter):
3788         Catch exception in destructor to avoid crash.
3789
3790 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3791
3792         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3793         close to the add_com "shell".
3794
3795 2019-04-18  Tom Tromey  <tromey@adacore.com>
3796
3797         * process-stratum-target.h (class process_stratum_target)
3798         <stratum>: Add "final".
3799
3800 2019-04-17  Tom Tromey  <tromey@adacore.com>
3801
3802         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3803         against nullptr before use.
3804
3805 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3806
3807         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3808
3809 2019-04-17  Jim Wilson  <jimw@sifive.com>
3810             Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3813         code read might fail, assume 4-byte breakpoint in that case.
3814
3815 2019-04-15  Leszek Swirski  <leszeks@google.com>
3816
3817         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3818         rather than a hand-rolled POD check when checking for forced MEMORY
3819         classification.
3820
3821 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3822
3823         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3824         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3825         function.
3826         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3827         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3828         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3829         declaration.
3830
3831 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3832
3833         * aarch64-linux-nat.c
3834         (aarch64_linux_nat_target::thread_architecture): Add override.
3835         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3836         each VQ.
3837
3838 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3839
3840         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3841
3842 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3843
3844         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3845         target types of size 96-bits, add some additional comments, and
3846         check that the builtin type we found was the correct size.
3847
3848 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3849
3850         * utils.c (prompt_for_continue): Don't restore the styling at the
3851         end, as applied_style has the wrong value.  This fixes styling in
3852         long lists of file names that are interrupted by the "Continue?"
3853         prompt.
3854
3855 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3858         * c-lang.c (c_language_defn): Likewise.
3859         (cplus_language_defn): Likewise.
3860         (asm_language_defn): Likewise.
3861         (minimal_language_defn): Likewise.
3862         * d-lang.c (d_language_defn): Likewise.
3863         * f-lang.c (f_language_defn): Likewise.
3864         * go-lang.c (go_language_defn): Likewise.
3865         * language.c (unknown_language_defn): Likewise.
3866         (auto_language_defn): Likewise.
3867         * language.h (struct language_defn): Remove la_magic field.
3868         (LANG_MAGIC): Delete.
3869         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3870         * objc-lang.c (objc_language_defn): Likewise.
3871         * opencl-lang.c (opencl_language_defn): Likewise.
3872         * p-lang.c (pascal_language_defn): Likewise.
3873         * rust-lang.c (rust_language_defn): Likewise.
3874
3875 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3876
3877         * riscv-tdep.c (riscv_type_align): New function.
3878         (riscv_type_alignment): Delete.
3879         (riscv_arg_location): Use 'type_align'.
3880         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3881
3882 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         * gdbtypes.c (type_align): A struct with no non-static fields also
3885         has alignment of 1.
3886
3887 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3888
3889         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3890         component to 0.
3891         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3892         member.
3893         (riscv_struct_info::analyse): New implementation using new
3894         analyse_inner member function.
3895         (riscv_struct_info::field_offset): New member function.
3896         (riscv_struct_info::m_offsets): New member variable.
3897         (riscv_struct_info::analyse_inner): New private member function,
3898         takes the old implementation of riscv_struct_info::analyse but
3899         extended to track field offsets.
3900         (riscv_call_arg_struct): Update the struct folding special cases
3901         to handle cases where empty C++ structs, which are non-zero
3902         length, are found.
3903         (riscv_arg_location): Initialise the length of each location, a
3904         non-zero length now indicates the location is in use.
3905         (riscv_push_dummy_call): Allow for the first location having a
3906         non-zero offset when setting up arguments.
3907         (riscv_return_value): Likewise, but for return values.
3908
3909 2019-04-11  Tom Tromey  <tromey@adacore.com>
3910
3911         * utils.c (internal_vproblem): Make "msg" const.
3912
3913 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3914
3915         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3916         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3917         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3918         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3919
3920 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3921
3922         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3923         function.
3924         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3925         of amd64_collect_native_gregset.
3926         (amd64_linux_nat_target::store_registers): Likewise.
3927
3928 2019-04-10  Tom Tromey  <tom@tromey.com>
3929
3930         * symtab.c (lookup_global_symbol_from_objfile)
3931         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3932         * objfiles.h (class separate_debug_iterator): New.
3933         (class separate_debug_range): New.
3934         (struct objfile) <separate_debug_objfiles>: New method.
3935         (objfile_separate_debug_iterate): Don't declare.
3936         * objfiles.c (separate_debug_iterator::operator++): Rename from
3937         objfile_separate_debug_iterate.
3938         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3939         iterator.
3940         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3941         iterator.
3942
3943 2019-04-10  Tom Tromey  <tom@tromey.com>
3944
3945         * symfile.c (reread_symbols): Remove old comment.
3946         * objfiles.c (free_all_objfiles): Fix a typo.
3947
3948 2019-04-10  Tom Tromey  <tom@tromey.com>
3949
3950         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3951         * minsyms.c (lookup_minimal_symbol): Use foreach.
3952         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3953         (lookup_minimal_symbol_solib_trampoline): Likewise.
3954         * symfile.c (reread_symbols): Use foreach.
3955
3956 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3957             Tom Tromey  <tromey@adacore.com>
3958
3959         PR rust/24414:
3960         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3961         (rust_lex_int_test): Change "value" to be LONGEST.
3962         (rust_lex_tests): Add test for long integer literal.
3963
3964 2019-04-09  Tom Tromey  <tromey@adacore.com>
3965
3966         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3967         to bool.
3968         (extended_remote_target::attach): Update.
3969         (remote_target::remote_notice_new_inferior): Update.
3970         (remote_target::add_current_inferior_and_thread): Update.
3971         * inferior.c (exit_inferior_1): Use "false".
3972         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3973
3974 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3975
3976         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3977         the "start" command.
3978
3979 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3980
3981         * python/py-inferior.c (infpy_thread_from_thread_handle):
3982         Adjust comments to reflect renaming of thread_from_thread_handle
3983         to thread_from_handle.  Adjust keywords.  Fix type error message.
3984         (inferior_object_methods): Add thread_from_handle.  Retain
3985         thread_from_thread_handle, but mark it as deprecated.
3986
3987 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3988
3989         * gdbthread.h (find_thread_by_handle): Revise declaration.
3990         * thread.c (find_thread_by_handle): Likewise.  Adjust
3991         implementation too.
3992         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3993         support for buffer objects as handles.
3994
3995 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3996
3997         * python/py-infthread.c (thpy_thread_handle): New function.
3998         (thread_object_methods): Register thpy_thread_handle.
3999
4000 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4001
4002         * gdbthread.h (thread_to_thread_handle): Declare.
4003         * thread.c (gdbtypes.h): Include.
4004         (thread_to_thread_handle): New function.
4005
4006         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4007         (target_thread_info_to_thread_handle): Declare.
4008         * target.c (target_thread_info_to_thread_handle): New function.
4009         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4010         * target-delegates.c: Regenerate.
4011
4012         * linux-thread-db.c (class thread_db_target): Add method
4013         thread_info_to_thread_handle.
4014         (thread_db_target::thread_info_to_thread_handle): Define.
4015         * remote.c (class remote_target): Add new method
4016         thread_info_to_thread_handle.
4017         (remote_target::thread_info_to_thread_handle): Define.
4018
4019 2019-04-08  Pedro Alves  <palves@redhat.com>
4020
4021         * common/common-exceptions.c (throw_exception): Don't create
4022         named object to throw; throw directly.
4023         (throw_it): Likewise.  Don't initialize gdb_exception::message
4024         here, with new; pass FMT and AP to the ctor instead.
4025         * common/common-exceptions.h: Include <string>.
4026         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4027         const char *, va_list)): New ctor.  Use std::make_shared.
4028         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4029         errors)): Delete.
4030         (gdb_exception_error::gdb_exception_error(enum errors, const char
4031         *, va_list)): New.
4032         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4033         Add assertion.
4034         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4035         errors)): Delete.
4036         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4037         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4038         Add assertion.
4039
4040 2019-04-08  Tom Tromey  <tom@tromey.com>
4041
4042         * valops.c (value_rtti_indirect_type): Replace throw_exception
4043         with throw.
4044         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4045         with throw.
4046         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4047         throw.
4048         * target.c (target_translate_tls_address): Replace throw_exception
4049         with throw.
4050         * stack.c (frame_apply_command_count): Replace throw_exception
4051         with throw.
4052         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4053         throw.
4054         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4055         with throw.
4056         * rs6000-tdep.c (rs6000_frame_cache)
4057         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4058         * remote.c: Replace throw_exception with throw.
4059         * record-full.c (record_full_message, record_full_wait_1)
4060         (record_full_restore): Replace throw_exception with throw.
4061         * record-btrace.c:
4062         (get_thread_current_frame_id, record_btrace_start_replaying)
4063         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4064         (cmd_record_btrace_start): Replace throw_exception with throw.
4065         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4066         throw.
4067         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4068         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4069         * linespec.c:
4070         (find_linespec_symbols): Replace throw_exception with throw.
4071         * infrun.c (displaced_step_prepare, resume): Replace
4072         throw_exception with throw.
4073         * infcmd.c (post_create_inferior): Replace throw_exception with
4074         throw.
4075         * inf-loop.c (inferior_event_handler): Replace throw_exception
4076         with throw.
4077         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4078         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4079         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4080         (get_prev_frame_always, get_frame_pc_if_available)
4081         (get_frame_address_in_block_if_available, get_frame_language):
4082         Replace throw_exception with throw.
4083         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4084         throw_exception with throw.
4085         * eval.c (fetch_subexp_value, evaluate_var_value)
4086         (evaluate_funcall, evaluate_subexp_standard): Replace
4087         throw_exception with throw.
4088         * dwarf2loc.c (call_site_find_chain)
4089         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4090         Replace throw_exception with throw.
4091         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4092         with throw.
4093         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4094         throw.
4095         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4096         * completer.c (complete_line_internal): Replace throw_exception
4097         with throw.
4098         * compile/compile-object-run.c (compile_object_run): Replace
4099         throw_exception with throw.
4100         * cli/cli-script.c (process_next_line): Replace throw_exception
4101         with throw.
4102         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4103         (btrace_enable, btrace_maint_update_pt_packets): Replace
4104         throw_exception with throw.
4105         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4106         throw_exception with throw.
4107         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4108         throw_exception with throw.
4109         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4110         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4111         * aarch64-tdep.c (aarch64_make_prologue_cache)
4112         (aarch64_make_stub_cache): Replace throw_exception with throw.
4113
4114 2019-04-08  Tom Tromey  <tom@tromey.com>
4115
4116         * common/common-exceptions.c (throw_exception): Rename from
4117         throw_exception_cxx.  Remove old copy.  Make argument const.
4118         (throw_it): Create and throw exception objects directly.
4119         * common/common-exceptions.h (throw_exception): Make argument
4120         const.
4121         (struct gdb_exception_error): Add constructor.
4122         (struct gdb_exception_quit): Add constructor.
4123
4124 2019-04-08  Tom Tromey  <tom@tromey.com>
4125
4126         * common/common-exceptions.h (exception_rethrow): Don't declare.
4127         (TRY_SJLJ): Update comment.
4128         (TRY, CATCH, END_CATCH): Remove.
4129         * common/common-exceptions.c (exception_rethrow): Remove.
4130
4131 2019-04-08  Tom Tromey  <tom@tromey.com>
4132
4133         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4134         Remove.
4135         (gdb_exception_error): Rename from
4136         gdb_exception_RETURN_MASK_ERROR.
4137         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4138         (gdb_quit_bad_alloc): Update.
4139         * aarch64-tdep.c: Update.
4140         * ada-lang.c: Update.
4141         * ada-typeprint.c: Update.
4142         * ada-valprint.c: Update.
4143         * amd64-tdep.c: Update.
4144         * arch-utils.c: Update.
4145         * break-catch-throw.c: Update.
4146         * breakpoint.c: Update.
4147         * btrace.c: Update.
4148         * c-varobj.c: Update.
4149         * cli/cli-cmds.c: Update.
4150         * cli/cli-interp.c: Update.
4151         * cli/cli-script.c: Update.
4152         * common/common-exceptions.c: Update.
4153         * common/new-op.c: Update.
4154         * common/selftest.c: Update.
4155         * compile/compile-c-symbols.c: Update.
4156         * compile/compile-cplus-symbols.c: Update.
4157         * compile/compile-object-load.c: Update.
4158         * compile/compile-object-run.c: Update.
4159         * completer.c: Update.
4160         * corelow.c: Update.
4161         * cp-abi.c: Update.
4162         * cp-support.c: Update.
4163         * cp-valprint.c: Update.
4164         * darwin-nat.c: Update.
4165         * disasm-selftests.c: Update.
4166         * dtrace-probe.c: Update.
4167         * dwarf-index-cache.c: Update.
4168         * dwarf-index-write.c: Update.
4169         * dwarf2-frame-tailcall.c: Update.
4170         * dwarf2-frame.c: Update.
4171         * dwarf2loc.c: Update.
4172         * dwarf2read.c: Update.
4173         * eval.c: Update.
4174         * event-loop.c: Update.
4175         * event-top.c: Update.
4176         * exec.c: Update.
4177         * f-valprint.c: Update.
4178         * fbsd-tdep.c: Update.
4179         * frame-unwind.c: Update.
4180         * frame.c: Update.
4181         * gdbtypes.c: Update.
4182         * gnu-v3-abi.c: Update.
4183         * guile/guile-internal.h: Update.
4184         * guile/scm-block.c: Update.
4185         * guile/scm-breakpoint.c: Update.
4186         * guile/scm-cmd.c: Update.
4187         * guile/scm-disasm.c: Update.
4188         * guile/scm-frame.c: Update.
4189         * guile/scm-lazy-string.c: Update.
4190         * guile/scm-math.c: Update.
4191         * guile/scm-param.c: Update.
4192         * guile/scm-ports.c: Update.
4193         * guile/scm-pretty-print.c: Update.
4194         * guile/scm-symbol.c: Update.
4195         * guile/scm-symtab.c: Update.
4196         * guile/scm-type.c: Update.
4197         * guile/scm-value.c: Update.
4198         * i386-linux-tdep.c: Update.
4199         * i386-tdep.c: Update.
4200         * inf-loop.c: Update.
4201         * infcall.c: Update.
4202         * infcmd.c: Update.
4203         * infrun.c: Update.
4204         * jit.c: Update.
4205         * language.c: Update.
4206         * linespec.c: Update.
4207         * linux-fork.c: Update.
4208         * linux-nat.c: Update.
4209         * linux-tdep.c: Update.
4210         * linux-thread-db.c: Update.
4211         * main.c: Update.
4212         * mi/mi-cmd-break.c: Update.
4213         * mi/mi-cmd-stack.c: Update.
4214         * mi/mi-interp.c: Update.
4215         * mi/mi-main.c: Update.
4216         * objc-lang.c: Update.
4217         * p-valprint.c: Update.
4218         * parse.c: Update.
4219         * ppc-linux-tdep.c: Update.
4220         * printcmd.c: Update.
4221         * python/py-arch.c: Update.
4222         * python/py-breakpoint.c: Update.
4223         * python/py-cmd.c: Update.
4224         * python/py-finishbreakpoint.c: Update.
4225         * python/py-frame.c: Update.
4226         * python/py-framefilter.c: Update.
4227         * python/py-gdb-readline.c: Update.
4228         * python/py-inferior.c: Update.
4229         * python/py-infthread.c: Update.
4230         * python/py-lazy-string.c: Update.
4231         * python/py-linetable.c: Update.
4232         * python/py-objfile.c: Update.
4233         * python/py-param.c: Update.
4234         * python/py-prettyprint.c: Update.
4235         * python/py-progspace.c: Update.
4236         * python/py-record-btrace.c: Update.
4237         * python/py-record.c: Update.
4238         * python/py-symbol.c: Update.
4239         * python/py-type.c: Update.
4240         * python/py-unwind.c: Update.
4241         * python/py-utils.c: Update.
4242         * python/py-value.c: Update.
4243         * python/python.c: Update.
4244         * record-btrace.c: Update.
4245         * record-full.c: Update.
4246         * remote-fileio.c: Update.
4247         * remote.c: Update.
4248         * riscv-tdep.c: Update.
4249         * rs6000-aix-tdep.c: Update.
4250         * rs6000-tdep.c: Update.
4251         * rust-exp.y: Update.
4252         * rust-lang.c: Update.
4253         * s390-tdep.c: Update.
4254         * selftest-arch.c: Update.
4255         * solib-dsbt.c: Update.
4256         * solib-frv.c: Update.
4257         * solib-spu.c: Update.
4258         * solib-svr4.c: Update.
4259         * solib.c: Update.
4260         * sparc64-linux-tdep.c: Update.
4261         * stack.c: Update.
4262         * symfile-mem.c: Update.
4263         * symmisc.c: Update.
4264         * target.c: Update.
4265         * thread.c: Update.
4266         * top.c: Update.
4267         * tracefile-tfile.c: Update.
4268         * tui/tui.c: Update.
4269         * typeprint.c: Update.
4270         * unittests/cli-utils-selftests.c: Update.
4271         * unittests/parse-connection-spec-selftests.c: Update.
4272         * valops.c: Update.
4273         * valprint.c: Update.
4274         * value.c: Update.
4275         * varobj.c: Update.
4276         * windows-nat.c: Update.
4277         * x86-linux-nat.c: Update.
4278         * xml-support.c: Update.
4279
4280 2019-04-08  Tom Tromey  <tom@tromey.com>
4281
4282         * xml-support.c: Use C++ exception handling.
4283         * x86-linux-nat.c: Use C++ exception handling.
4284         * windows-nat.c: Use C++ exception handling.
4285         * varobj.c: Use C++ exception handling.
4286         * value.c: Use C++ exception handling.
4287         * valprint.c: Use C++ exception handling.
4288         * valops.c: Use C++ exception handling.
4289         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4290         handling.
4291         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4292         * typeprint.c: Use C++ exception handling.
4293         * tui/tui.c: Use C++ exception handling.
4294         * tracefile-tfile.c: Use C++ exception handling.
4295         * top.c: Use C++ exception handling.
4296         * thread.c: Use C++ exception handling.
4297         * target.c: Use C++ exception handling.
4298         * symmisc.c: Use C++ exception handling.
4299         * symfile-mem.c: Use C++ exception handling.
4300         * stack.c: Use C++ exception handling.
4301         * sparc64-linux-tdep.c: Use C++ exception handling.
4302         * solib.c: Use C++ exception handling.
4303         * solib-svr4.c: Use C++ exception handling.
4304         * solib-spu.c: Use C++ exception handling.
4305         * solib-frv.c: Use C++ exception handling.
4306         * solib-dsbt.c: Use C++ exception handling.
4307         * selftest-arch.c: Use C++ exception handling.
4308         * s390-tdep.c: Use C++ exception handling.
4309         * rust-lang.c: Use C++ exception handling.
4310         * rust-exp.y: Use C++ exception handling.
4311         * rs6000-tdep.c: Use C++ exception handling.
4312         * rs6000-aix-tdep.c: Use C++ exception handling.
4313         * riscv-tdep.c: Use C++ exception handling.
4314         * remote.c: Use C++ exception handling.
4315         * remote-fileio.c: Use C++ exception handling.
4316         * record-full.c: Use C++ exception handling.
4317         * record-btrace.c: Use C++ exception handling.
4318         * python/python.c: Use C++ exception handling.
4319         * python/py-value.c: Use C++ exception handling.
4320         * python/py-utils.c: Use C++ exception handling.
4321         * python/py-unwind.c: Use C++ exception handling.
4322         * python/py-type.c: Use C++ exception handling.
4323         * python/py-symbol.c: Use C++ exception handling.
4324         * python/py-record.c: Use C++ exception handling.
4325         * python/py-record-btrace.c: Use C++ exception handling.
4326         * python/py-progspace.c: Use C++ exception handling.
4327         * python/py-prettyprint.c: Use C++ exception handling.
4328         * python/py-param.c: Use C++ exception handling.
4329         * python/py-objfile.c: Use C++ exception handling.
4330         * python/py-linetable.c: Use C++ exception handling.
4331         * python/py-lazy-string.c: Use C++ exception handling.
4332         * python/py-infthread.c: Use C++ exception handling.
4333         * python/py-inferior.c: Use C++ exception handling.
4334         * python/py-gdb-readline.c: Use C++ exception handling.
4335         * python/py-framefilter.c: Use C++ exception handling.
4336         * python/py-frame.c: Use C++ exception handling.
4337         * python/py-finishbreakpoint.c: Use C++ exception handling.
4338         * python/py-cmd.c: Use C++ exception handling.
4339         * python/py-breakpoint.c: Use C++ exception handling.
4340         * python/py-arch.c: Use C++ exception handling.
4341         * printcmd.c: Use C++ exception handling.
4342         * ppc-linux-tdep.c: Use C++ exception handling.
4343         * parse.c: Use C++ exception handling.
4344         * p-valprint.c: Use C++ exception handling.
4345         * objc-lang.c: Use C++ exception handling.
4346         * mi/mi-main.c: Use C++ exception handling.
4347         * mi/mi-interp.c: Use C++ exception handling.
4348         * mi/mi-cmd-stack.c: Use C++ exception handling.
4349         * mi/mi-cmd-break.c: Use C++ exception handling.
4350         * main.c: Use C++ exception handling.
4351         * linux-thread-db.c: Use C++ exception handling.
4352         * linux-tdep.c: Use C++ exception handling.
4353         * linux-nat.c: Use C++ exception handling.
4354         * linux-fork.c: Use C++ exception handling.
4355         * linespec.c: Use C++ exception handling.
4356         * language.c: Use C++ exception handling.
4357         * jit.c: Use C++ exception handling.
4358         * infrun.c: Use C++ exception handling.
4359         * infcmd.c: Use C++ exception handling.
4360         * infcall.c: Use C++ exception handling.
4361         * inf-loop.c: Use C++ exception handling.
4362         * i386-tdep.c: Use C++ exception handling.
4363         * i386-linux-tdep.c: Use C++ exception handling.
4364         * guile/scm-value.c: Use C++ exception handling.
4365         * guile/scm-type.c: Use C++ exception handling.
4366         * guile/scm-symtab.c: Use C++ exception handling.
4367         * guile/scm-symbol.c: Use C++ exception handling.
4368         * guile/scm-pretty-print.c: Use C++ exception handling.
4369         * guile/scm-ports.c: Use C++ exception handling.
4370         * guile/scm-param.c: Use C++ exception handling.
4371         * guile/scm-math.c: Use C++ exception handling.
4372         * guile/scm-lazy-string.c: Use C++ exception handling.
4373         * guile/scm-frame.c: Use C++ exception handling.
4374         * guile/scm-disasm.c: Use C++ exception handling.
4375         * guile/scm-cmd.c: Use C++ exception handling.
4376         * guile/scm-breakpoint.c: Use C++ exception handling.
4377         * guile/scm-block.c: Use C++ exception handling.
4378         * guile/guile-internal.h: Use C++ exception handling.
4379         * gnu-v3-abi.c: Use C++ exception handling.
4380         * gdbtypes.c: Use C++ exception handling.
4381         * frame.c: Use C++ exception handling.
4382         * frame-unwind.c: Use C++ exception handling.
4383         * fbsd-tdep.c: Use C++ exception handling.
4384         * f-valprint.c: Use C++ exception handling.
4385         * exec.c: Use C++ exception handling.
4386         * event-top.c: Use C++ exception handling.
4387         * event-loop.c: Use C++ exception handling.
4388         * eval.c: Use C++ exception handling.
4389         * dwarf2read.c: Use C++ exception handling.
4390         * dwarf2loc.c: Use C++ exception handling.
4391         * dwarf2-frame.c: Use C++ exception handling.
4392         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4393         * dwarf-index-write.c: Use C++ exception handling.
4394         * dwarf-index-cache.c: Use C++ exception handling.
4395         * dtrace-probe.c: Use C++ exception handling.
4396         * disasm-selftests.c: Use C++ exception handling.
4397         * darwin-nat.c: Use C++ exception handling.
4398         * cp-valprint.c: Use C++ exception handling.
4399         * cp-support.c: Use C++ exception handling.
4400         * cp-abi.c: Use C++ exception handling.
4401         * corelow.c: Use C++ exception handling.
4402         * completer.c: Use C++ exception handling.
4403         * compile/compile-object-run.c: Use C++ exception handling.
4404         * compile/compile-object-load.c: Use C++ exception handling.
4405         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4406         * compile/compile-c-symbols.c: Use C++ exception handling.
4407         * common/selftest.c: Use C++ exception handling.
4408         * common/new-op.c: Use C++ exception handling.
4409         * cli/cli-script.c: Use C++ exception handling.
4410         * cli/cli-interp.c: Use C++ exception handling.
4411         * cli/cli-cmds.c: Use C++ exception handling.
4412         * c-varobj.c: Use C++ exception handling.
4413         * btrace.c: Use C++ exception handling.
4414         * breakpoint.c: Use C++ exception handling.
4415         * break-catch-throw.c: Use C++ exception handling.
4416         * arch-utils.c: Use C++ exception handling.
4417         * amd64-tdep.c: Use C++ exception handling.
4418         * ada-valprint.c: Use C++ exception handling.
4419         * ada-typeprint.c: Use C++ exception handling.
4420         * ada-lang.c: Use C++ exception handling.
4421         * aarch64-tdep.c: Use C++ exception handling.
4422
4423 2019-04-08  Tom Tromey  <tom@tromey.com>
4424
4425         * xml-support.c (gdb_xml_parser::parse): Update.
4426         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4427         * value.c (show_convenience): Update.
4428         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4429         (test_parse_flags_qcs): Update.
4430         * thread.c (thr_try_catch_cmd): Update.
4431         * target.c (target_translate_tls_address): Update.
4432         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4433         (info_frame_command_core, frame_apply_command_count): Update.
4434         * rust-exp.y (rust_lex_exception_test): Update.
4435         * riscv-tdep.c (riscv_print_one_register_info): Update.
4436         * remote.c (remote_target::enable_btrace): Update.
4437         * record-btrace.c (record_btrace_enable_warn): Update.
4438         * python/py-utils.c (gdbpy_convert_exception): Update.
4439         * printcmd.c (do_one_display, print_variable_and_value): Update.
4440         * mi/mi-main.c (mi_print_exception): Update.
4441         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4442         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4443         * linux-nat.c (linux_nat_target::attach): Update.
4444         * linux-fork.c (class scoped_switch_fork_info): Update.
4445         * infrun.c (displaced_step_prepare): Update.
4446         * infcall.c (call_function_by_hand_dummy): Update.
4447         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4448         * gnu-v3-abi.c (print_one_vtable): Update.
4449         * frame.c (get_prev_frame_always): Update.
4450         * f-valprint.c (info_common_command_for_block): Update.
4451         * exec.c (try_open_exec_file): Update.
4452         * exceptions.c (print_exception, exception_print)
4453         (exception_fprintf, exception_print_same): Update.
4454         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4455         * dwarf-index-cache.c (index_cache::store)
4456         (index_cache::lookup_gdb_index): Update.
4457         * darwin-nat.c (maybe_cache_shell): Update.
4458         * cp-valprint.c (cp_print_value_fields): Update.
4459         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4460         (gcc_cplus_symbol_address): Update.
4461         * compile/compile-c-symbols.c (gcc_convert_symbol)
4462         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4463         * common/selftest.c: Update.
4464         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4465         a std::string.
4466         (exception_try_scope_entry, exception_try_scope_exit): Don't
4467         declare.
4468         (struct exception_try_scope): Remove.
4469         (TRY): Don't use exception_try_scope.
4470         (struct gdb_exception): Add constructor, operator=.
4471         <what>: New method.
4472         (struct gdb_exception_RETURN_MASK_ALL)
4473         (struct gdb_exception_RETURN_MASK_ERROR)
4474         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4475         (struct gdb_quit_bad_alloc): Update.
4476         * common/common-exceptions.c (exception_none): Change
4477         initializer.
4478         (struct catcher) <state, exception>: Initialize inline.
4479         <prev>: Remove member.
4480         (current_catcher): Remove.
4481         (catchers): New global.
4482         (exceptions_state_mc_init): Simplify.
4483         (catcher_pop): Remove.
4484         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4485         (try_scope_depth, exception_try_scope_entry)
4486         (exception_try_scope_exit): Remove.
4487         (throw_exception_sjlj): Update.
4488         (exception_messages, exception_messages_size): Remove.
4489         (throw_it): Simplify.
4490         (gdb_exception_sliced_copy): Remove.
4491         (throw_exception_cxx): Update.
4492         * cli/cli-script.c (script_from_file): Update.
4493         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4494         Update.
4495         * ada-valprint.c (ada_val_print): Update.
4496         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4497         (create_excep_cond_exprs): Update.
4498
4499 2019-04-08  Tom Tromey  <tom@tromey.com>
4500
4501         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4502         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4503         (TRY, CATCH, END_CATCH): Remove some definitions.
4504         * common/common-exceptions.c: Don't use GDB_XCPT.
4505         (catcher_list_size): Remove.
4506         (throw_exception, throw_it): Simplify.
4507
4508 2019-04-05  Tom Tromey  <tom@tromey.com>
4509
4510         Revert the header-sorting patch.
4511         * ft32-tdep.c: Revert.
4512         * frv-tdep.c: Revert.
4513         * frv-linux-tdep.c: Revert.
4514         * frame.c: Revert.
4515         * frame-unwind.c: Revert.
4516         * frame-base.c: Revert.
4517         * fork-child.c: Revert.
4518         * findvar.c: Revert.
4519         * findcmd.c: Revert.
4520         * filesystem.c: Revert.
4521         * filename-seen-cache.h: Revert.
4522         * filename-seen-cache.c: Revert.
4523         * fbsd-tdep.c: Revert.
4524         * fbsd-nat.h: Revert.
4525         * fbsd-nat.c: Revert.
4526         * f-valprint.c: Revert.
4527         * f-typeprint.c: Revert.
4528         * f-lang.c: Revert.
4529         * extension.h: Revert.
4530         * extension.c: Revert.
4531         * extension-priv.h: Revert.
4532         * expprint.c: Revert.
4533         * exec.h: Revert.
4534         * exec.c: Revert.
4535         * exceptions.c: Revert.
4536         * event-top.c: Revert.
4537         * event-loop.c: Revert.
4538         * eval.c: Revert.
4539         * elfread.c: Revert.
4540         * dwarf2read.h: Revert.
4541         * dwarf2read.c: Revert.
4542         * dwarf2loc.c: Revert.
4543         * dwarf2expr.h: Revert.
4544         * dwarf2expr.c: Revert.
4545         * dwarf2-frame.c: Revert.
4546         * dwarf2-frame-tailcall.c: Revert.
4547         * dwarf-index-write.h: Revert.
4548         * dwarf-index-write.c: Revert.
4549         * dwarf-index-common.c: Revert.
4550         * dwarf-index-cache.h: Revert.
4551         * dwarf-index-cache.c: Revert.
4552         * dummy-frame.c: Revert.
4553         * dtrace-probe.c: Revert.
4554         * disasm.h: Revert.
4555         * disasm.c: Revert.
4556         * disasm-selftests.c: Revert.
4557         * dictionary.c: Revert.
4558         * dicos-tdep.c: Revert.
4559         * demangle.c: Revert.
4560         * dcache.h: Revert.
4561         * dcache.c: Revert.
4562         * darwin-nat.h: Revert.
4563         * darwin-nat.c: Revert.
4564         * darwin-nat-info.c: Revert.
4565         * d-valprint.c: Revert.
4566         * d-namespace.c: Revert.
4567         * d-lang.c: Revert.
4568         * ctf.c: Revert.
4569         * csky-tdep.c: Revert.
4570         * csky-linux-tdep.c: Revert.
4571         * cris-tdep.c: Revert.
4572         * cris-linux-tdep.c: Revert.
4573         * cp-valprint.c: Revert.
4574         * cp-support.c: Revert.
4575         * cp-namespace.c: Revert.
4576         * cp-abi.c: Revert.
4577         * corelow.c: Revert.
4578         * corefile.c: Revert.
4579         * continuations.c: Revert.
4580         * completer.h: Revert.
4581         * completer.c: Revert.
4582         * complaints.c: Revert.
4583         * coffread.c: Revert.
4584         * coff-pe-read.c: Revert.
4585         * cli-out.h: Revert.
4586         * cli-out.c: Revert.
4587         * charset.c: Revert.
4588         * c-varobj.c: Revert.
4589         * c-valprint.c: Revert.
4590         * c-typeprint.c: Revert.
4591         * c-lang.c: Revert.
4592         * buildsym.c: Revert.
4593         * buildsym-legacy.c: Revert.
4594         * build-id.h: Revert.
4595         * build-id.c: Revert.
4596         * btrace.c: Revert.
4597         * bsd-uthread.c: Revert.
4598         * breakpoint.h: Revert.
4599         * breakpoint.c: Revert.
4600         * break-catch-throw.c: Revert.
4601         * break-catch-syscall.c: Revert.
4602         * break-catch-sig.c: Revert.
4603         * blockframe.c: Revert.
4604         * block.c: Revert.
4605         * bfin-tdep.c: Revert.
4606         * bfin-linux-tdep.c: Revert.
4607         * bfd-target.c: Revert.
4608         * bcache.c: Revert.
4609         * ax-general.c: Revert.
4610         * ax-gdb.h: Revert.
4611         * ax-gdb.c: Revert.
4612         * avr-tdep.c: Revert.
4613         * auxv.c: Revert.
4614         * auto-load.c: Revert.
4615         * arm-wince-tdep.c: Revert.
4616         * arm-tdep.c: Revert.
4617         * arm-symbian-tdep.c: Revert.
4618         * arm-pikeos-tdep.c: Revert.
4619         * arm-obsd-tdep.c: Revert.
4620         * arm-nbsd-tdep.c: Revert.
4621         * arm-nbsd-nat.c: Revert.
4622         * arm-linux-tdep.c: Revert.
4623         * arm-linux-nat.c: Revert.
4624         * arm-fbsd-tdep.c: Revert.
4625         * arm-fbsd-nat.c: Revert.
4626         * arm-bsd-tdep.c: Revert.
4627         * arch-utils.c: Revert.
4628         * arc-tdep.c: Revert.
4629         * arc-newlib-tdep.c: Revert.
4630         * annotate.h: Revert.
4631         * annotate.c: Revert.
4632         * amd64-windows-tdep.c: Revert.
4633         * amd64-windows-nat.c: Revert.
4634         * amd64-tdep.c: Revert.
4635         * amd64-sol2-tdep.c: Revert.
4636         * amd64-obsd-tdep.c: Revert.
4637         * amd64-obsd-nat.c: Revert.
4638         * amd64-nbsd-tdep.c: Revert.
4639         * amd64-nbsd-nat.c: Revert.
4640         * amd64-nat.c: Revert.
4641         * amd64-linux-tdep.c: Revert.
4642         * amd64-linux-nat.c: Revert.
4643         * amd64-fbsd-tdep.c: Revert.
4644         * amd64-fbsd-nat.c: Revert.
4645         * amd64-dicos-tdep.c: Revert.
4646         * amd64-darwin-tdep.c: Revert.
4647         * amd64-bsd-nat.c: Revert.
4648         * alpha-tdep.c: Revert.
4649         * alpha-obsd-tdep.c: Revert.
4650         * alpha-nbsd-tdep.c: Revert.
4651         * alpha-mdebug-tdep.c: Revert.
4652         * alpha-linux-tdep.c: Revert.
4653         * alpha-linux-nat.c: Revert.
4654         * alpha-bsd-tdep.c: Revert.
4655         * alpha-bsd-nat.c: Revert.
4656         * aix-thread.c: Revert.
4657         * agent.c: Revert.
4658         * addrmap.c: Revert.
4659         * ada-varobj.c: Revert.
4660         * ada-valprint.c: Revert.
4661         * ada-typeprint.c: Revert.
4662         * ada-tasks.c: Revert.
4663         * ada-lang.c: Revert.
4664         * aarch64-tdep.c: Revert.
4665         * aarch64-ravenscar-thread.c: Revert.
4666         * aarch64-newlib-tdep.c: Revert.
4667         * aarch64-linux-tdep.c: Revert.
4668         * aarch64-linux-nat.c: Revert.
4669         * aarch64-fbsd-tdep.c: Revert.
4670         * aarch64-fbsd-nat.c: Revert.
4671         * aarch32-linux-nat.c: Revert.
4672
4673 2019-04-05  Tom Tromey  <tom@tromey.com>
4674
4675         * ft32-tdep.c: Sort headers.
4676         * frv-tdep.c: Sort headers.
4677         * frv-linux-tdep.c: Sort headers.
4678         * frame.c: Sort headers.
4679         * frame-unwind.c: Sort headers.
4680         * frame-base.c: Sort headers.
4681         * fork-child.c: Sort headers.
4682         * findvar.c: Sort headers.
4683         * findcmd.c: Sort headers.
4684         * filesystem.c: Sort headers.
4685         * filename-seen-cache.h: Sort headers.
4686         * filename-seen-cache.c: Sort headers.
4687         * fbsd-tdep.c: Sort headers.
4688         * fbsd-nat.h: Sort headers.
4689         * fbsd-nat.c: Sort headers.
4690         * f-valprint.c: Sort headers.
4691         * f-typeprint.c: Sort headers.
4692         * f-lang.c: Sort headers.
4693         * extension.h: Sort headers.
4694         * extension.c: Sort headers.
4695         * extension-priv.h: Sort headers.
4696         * expprint.c: Sort headers.
4697         * exec.h: Sort headers.
4698         * exec.c: Sort headers.
4699         * exceptions.c: Sort headers.
4700         * event-top.c: Sort headers.
4701         * event-loop.c: Sort headers.
4702         * eval.c: Sort headers.
4703         * elfread.c: Sort headers.
4704         * dwarf2read.h: Sort headers.
4705         * dwarf2read.c: Sort headers.
4706         * dwarf2loc.c: Sort headers.
4707         * dwarf2expr.h: Sort headers.
4708         * dwarf2expr.c: Sort headers.
4709         * dwarf2-frame.c: Sort headers.
4710         * dwarf2-frame-tailcall.c: Sort headers.
4711         * dwarf-index-write.h: Sort headers.
4712         * dwarf-index-write.c: Sort headers.
4713         * dwarf-index-common.c: Sort headers.
4714         * dwarf-index-cache.h: Sort headers.
4715         * dwarf-index-cache.c: Sort headers.
4716         * dummy-frame.c: Sort headers.
4717         * dtrace-probe.c: Sort headers.
4718         * disasm.h: Sort headers.
4719         * disasm.c: Sort headers.
4720         * disasm-selftests.c: Sort headers.
4721         * dictionary.c: Sort headers.
4722         * dicos-tdep.c: Sort headers.
4723         * demangle.c: Sort headers.
4724         * dcache.h: Sort headers.
4725         * dcache.c: Sort headers.
4726         * darwin-nat.h: Sort headers.
4727         * darwin-nat.c: Sort headers.
4728         * darwin-nat-info.c: Sort headers.
4729         * d-valprint.c: Sort headers.
4730         * d-namespace.c: Sort headers.
4731         * d-lang.c: Sort headers.
4732         * ctf.c: Sort headers.
4733         * csky-tdep.c: Sort headers.
4734         * csky-linux-tdep.c: Sort headers.
4735         * cris-tdep.c: Sort headers.
4736         * cris-linux-tdep.c: Sort headers.
4737         * cp-valprint.c: Sort headers.
4738         * cp-support.c: Sort headers.
4739         * cp-namespace.c: Sort headers.
4740         * cp-abi.c: Sort headers.
4741         * corelow.c: Sort headers.
4742         * corefile.c: Sort headers.
4743         * continuations.c: Sort headers.
4744         * completer.h: Sort headers.
4745         * completer.c: Sort headers.
4746         * complaints.c: Sort headers.
4747         * coffread.c: Sort headers.
4748         * coff-pe-read.c: Sort headers.
4749         * cli-out.h: Sort headers.
4750         * cli-out.c: Sort headers.
4751         * charset.c: Sort headers.
4752         * c-varobj.c: Sort headers.
4753         * c-valprint.c: Sort headers.
4754         * c-typeprint.c: Sort headers.
4755         * c-lang.c: Sort headers.
4756         * buildsym.c: Sort headers.
4757         * buildsym-legacy.c: Sort headers.
4758         * build-id.h: Sort headers.
4759         * build-id.c: Sort headers.
4760         * btrace.c: Sort headers.
4761         * bsd-uthread.c: Sort headers.
4762         * breakpoint.h: Sort headers.
4763         * breakpoint.c: Sort headers.
4764         * break-catch-throw.c: Sort headers.
4765         * break-catch-syscall.c: Sort headers.
4766         * break-catch-sig.c: Sort headers.
4767         * blockframe.c: Sort headers.
4768         * block.c: Sort headers.
4769         * bfin-tdep.c: Sort headers.
4770         * bfin-linux-tdep.c: Sort headers.
4771         * bfd-target.c: Sort headers.
4772         * bcache.c: Sort headers.
4773         * ax-general.c: Sort headers.
4774         * ax-gdb.h: Sort headers.
4775         * ax-gdb.c: Sort headers.
4776         * avr-tdep.c: Sort headers.
4777         * auxv.c: Sort headers.
4778         * auto-load.c: Sort headers.
4779         * arm-wince-tdep.c: Sort headers.
4780         * arm-tdep.c: Sort headers.
4781         * arm-symbian-tdep.c: Sort headers.
4782         * arm-pikeos-tdep.c: Sort headers.
4783         * arm-obsd-tdep.c: Sort headers.
4784         * arm-nbsd-tdep.c: Sort headers.
4785         * arm-nbsd-nat.c: Sort headers.
4786         * arm-linux-tdep.c: Sort headers.
4787         * arm-linux-nat.c: Sort headers.
4788         * arm-fbsd-tdep.c: Sort headers.
4789         * arm-fbsd-nat.c: Sort headers.
4790         * arm-bsd-tdep.c: Sort headers.
4791         * arch-utils.c: Sort headers.
4792         * arc-tdep.c: Sort headers.
4793         * arc-newlib-tdep.c: Sort headers.
4794         * annotate.h: Sort headers.
4795         * annotate.c: Sort headers.
4796         * amd64-windows-tdep.c: Sort headers.
4797         * amd64-windows-nat.c: Sort headers.
4798         * amd64-tdep.c: Sort headers.
4799         * amd64-sol2-tdep.c: Sort headers.
4800         * amd64-obsd-tdep.c: Sort headers.
4801         * amd64-obsd-nat.c: Sort headers.
4802         * amd64-nbsd-tdep.c: Sort headers.
4803         * amd64-nbsd-nat.c: Sort headers.
4804         * amd64-nat.c: Sort headers.
4805         * amd64-linux-tdep.c: Sort headers.
4806         * amd64-linux-nat.c: Sort headers.
4807         * amd64-fbsd-tdep.c: Sort headers.
4808         * amd64-fbsd-nat.c: Sort headers.
4809         * amd64-dicos-tdep.c: Sort headers.
4810         * amd64-darwin-tdep.c: Sort headers.
4811         * amd64-bsd-nat.c: Sort headers.
4812         * alpha-tdep.c: Sort headers.
4813         * alpha-obsd-tdep.c: Sort headers.
4814         * alpha-nbsd-tdep.c: Sort headers.
4815         * alpha-mdebug-tdep.c: Sort headers.
4816         * alpha-linux-tdep.c: Sort headers.
4817         * alpha-linux-nat.c: Sort headers.
4818         * alpha-bsd-tdep.c: Sort headers.
4819         * alpha-bsd-nat.c: Sort headers.
4820         * aix-thread.c: Sort headers.
4821         * agent.c: Sort headers.
4822         * addrmap.c: Sort headers.
4823         * ada-varobj.c: Sort headers.
4824         * ada-valprint.c: Sort headers.
4825         * ada-typeprint.c: Sort headers.
4826         * ada-tasks.c: Sort headers.
4827         * ada-lang.c: Sort headers.
4828         * aarch64-tdep.c: Sort headers.
4829         * aarch64-ravenscar-thread.c: Sort headers.
4830         * aarch64-newlib-tdep.c: Sort headers.
4831         * aarch64-linux-tdep.c: Sort headers.
4832         * aarch64-linux-nat.c: Sort headers.
4833         * aarch64-fbsd-tdep.c: Sort headers.
4834         * aarch64-fbsd-nat.c: Sort headers.
4835         * aarch32-linux-nat.c: Sort headers.
4836
4837 2019-04-04  Tom Tromey  <tom@tromey.com>
4838
4839         * varobj.c (varobj_create): Update.
4840         * rust-exp.y (struct rust_parser) <update_innermost_block,
4841         lookup_symbol>: New methods.
4842         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4843         Rename.
4844         (rust_parser::rust_lookup_type)
4845         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4846         * printcmd.c (display_command, do_one_display): Update.
4847         * parser-defs.h (struct parser_state) <parser_state>: Add
4848         "tracker" parameter.
4849         (block_tracker): New member.
4850         (class innermost_block_tracker) <innermost_block_tracker>: Add
4851         "types" parameter.
4852         <reset>: Remove method.
4853         (innermost_block): Don't declare.
4854         (null_post_parser): Update.
4855         * parse.c (innermost_block): Remove global.
4856         (write_dollar_variable): Update.
4857         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4858         Remove "tracker_types" parameter.
4859         (parse_expression): Add "tracker" parameter.
4860         (parse_expression_for_completion): Update.
4861         (null_post_parser): Add "tracker" parameter.
4862         * p-exp.y: Update rules.
4863         * m2-exp.y: Update rules.
4864         * language.h (struct language_defn) <la_post_parser>: Add
4865         "tracker" parameter.
4866         * go-exp.y: Update rules.
4867         * f-exp.y: Update rules.
4868         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4869         parameter.
4870         * d-exp.y: Update rules.
4871         * c-exp.y: Update rules.
4872         * breakpoint.c (set_breakpoint_condition): Create an
4873         innermost_block_tracker.
4874         (watch_command_1): Likewise.
4875         * ada-lang.c (resolve): Add "tracker" parameter.
4876         (resolve_subexp): Likewise.
4877         * ada-exp.y (write_var_from_sym): Update.
4878
4879 2019-04-04  Tom Tromey  <tom@tromey.com>
4880
4881         * type-stack.h: New file.
4882         * type-stack.c: New file.
4883         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4884         type-stack.h.
4885         (insert_into_type_stack, insert_type, push_type, push_type_int)
4886         (insert_type_address_space, pop_type, pop_type_int)
4887         (pop_typelist, pop_type_stack, append_type_stack)
4888         (push_type_stack, get_type_stack, push_typelist)
4889         (follow_type_instance_flags, follow_types): Don't declare.
4890         * parse.c (type_stack): Remove global.
4891         (parse_exp_in_context): Update.
4892         (insert_into_type_stack, insert_type, push_type, push_type_int)
4893         (insert_type_address_space, pop_type, pop_type_int)
4894         (pop_typelist, pop_type_stack, append_type_stack)
4895         (push_type_stack, get_type_stack, push_typelist)
4896         (follow_type_instance_flags, follow_types): Remove (moved to
4897         type-stack.c).
4898         * f-exp.y (type_stack): New global.
4899         Update rules.
4900         (push_kind_type, f_parse): Update.
4901         * d-exp.y (type_stack): New global.
4902         Update rules.
4903         (d_parse): Update.
4904         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4905         Update rules.
4906         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4907         (HFILES_NO_SRCDIR): Add type-stack.h.
4908
4909 2019-04-04  Tom Tromey  <tom@tromey.com>
4910
4911         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4912         (rust_parser::convert_ast_to_expression, rust_parse)
4913         (rust_lex_test_completion, rust_lex_tests): Update.
4914         * parser-defs.h (struct expr_completion_state): New.
4915         (struct parser_state) <parser_state>: Add completion parameter.
4916         <mark_struct_expression, mark_completion_tag>: New methods.
4917         <parse_completion, m_completion_state>: New members.
4918         (prefixify_expression, null_post_parser): Update.
4919         (mark_struct_expression, mark_completion_tag): Don't declare.
4920         * parse.c (parse_completion, expout_last_struct)
4921         (expout_tag_completion_type, expout_completion_name): Remove
4922         globals.
4923         (parser_state::mark_struct_expression)
4924         (parser_state::mark_completion_tag): Now methods.
4925         (prefixify_expression): Add last_struct parameter.
4926         (prefixify_subexp): Likewise.
4927         (parse_exp_1): Update.
4928         (parse_exp_in_context): Add cstate parameter.  Update.
4929         (parse_expression_for_completion): Create an
4930         expr_completion_state.
4931         (null_post_parser): Add "completion" parameter.
4932         * p-exp.y: Update rules.
4933         (yylex): Update.
4934         * language.h (struct language_defn) <la_post_parser>: Add
4935         "completing" parameter.
4936         * go-exp.y: Update rules.
4937         (lex_one_token): Update.
4938         * expression.h (parse_completion): Don't declare.
4939         * d-exp.y: Update rules.
4940         (lex_one_token): Update rules.
4941         * c-exp.y: Update rules.
4942         (lex_one_token): Update.
4943         * ada-lang.c (resolve): Add "parse_completion" parameter.
4944         (resolve_subexp): Likewise.
4945         (ada_resolve_function): Likewise.
4946
4947 2019-04-04  Tom Tromey  <tom@tromey.com>
4948
4949         * parser-defs.h (struct parser_state) <start_arglist,
4950         end_arglist>: New methods.
4951         <arglist_len, m_funcall_chain>: New members.
4952         (arglist_len, start_arglist, end_arglist): Don't declare.
4953         * parse.c (arglist_len, funcall_chain): Remove global.
4954         (start_arglist, end_arglist): Remove functions.
4955         (parse_exp_in_context): Update.
4956         * p-exp.y: Update rules.
4957         * m2-exp.y: Update rules.
4958         * go-exp.y: Update rules.
4959         * f-exp.y: Update rules.
4960         * d-exp.y: Update rules.
4961         * c-exp.y: Update rules.
4962
4963 2019-04-04  Tom Tromey  <tom@tromey.com>
4964
4965         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4966         lex_operator, push_back>: New methods.
4967         Update all rules.
4968         (rust_parser::lex_hex, lex_escape): Rename and update.
4969         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4970         (rust_parser::lex_operator): Rename and update.
4971         (rust_parser::lex_number, rustyylex, rustyyerror)
4972         (rust_lex_test_init, rust_lex_test_sequence)
4973         (rust_lex_test_push_back, rust_lex_tests): Update.
4974         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4975         parameter.
4976         <lexptr, prev_lexptr>: New members.
4977         (lexptr, prev_lexptr): Don't declare.
4978         * parse.c (lexptr, prev_lexptr): Remove globals.
4979         (parse_exp_in_context): Update.
4980         * p-exp.y (yylex, yyerror): Update.
4981         * m2-exp.y (parse_number, yylex, yyerror): Update.
4982         * go-exp.y (lex_one_token, yyerror): Update.
4983         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4984         * d-exp.y (lex_one_token, yyerror): Update.
4985         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4986         (lex_one_token, yyerror): Update.
4987         * ada-lex.l (YY_INPUT): Update.
4988         (rewind_to_char): Update.
4989         * ada-exp.y (yyerror): Update.
4990
4991 2019-04-04  Tom Tromey  <tom@tromey.com>
4992
4993         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4994         * parser-defs.h (struct parser_state) <parser_state>: Add new
4995         parameter.
4996         <comma_terminates>: New member.
4997         (comma_terminates): Don't declare global.
4998         * parse.c (comma_terminates): Remove global.
4999         (parse_exp_in_context): Update.
5000         * p-exp.y (yylex): Update.
5001         * m2-exp.y (yylex): Update.
5002         * go-exp.y (lex_one_token): Update.
5003         * f-exp.y (yylex): Update.
5004         * d-exp.y (lex_one_token): Update.
5005         * c-exp.y (lex_one_token): Update.
5006         * ada-lex.l: Update.
5007
5008 2019-04-04  Tom Tromey  <tom@tromey.com>
5009
5010         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5011         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5012         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5013         * parser-defs.h (paren_depth): Don't declare.
5014         * parse.c (paren_depth): Remove global.
5015         (parse_exp_in_context): Update.
5016         * p-exp.y (paren_depth): New global.
5017         (pascal_parse): Initialize it.
5018         * m2-exp.y (paren_depth): New global.
5019         (m2_parse): Initialize it.
5020         * go-exp.y (paren_depth): New global.
5021         (go_parse): Initialize it.
5022         * f-exp.y (paren_depth): New global.
5023         (f_parse): Initialize it.
5024         * d-exp.y (paren_depth): New global.
5025         (d_parse): Initialize it.
5026         * c-exp.y (paren_depth): New global.
5027         (c_parse): Initialize it.
5028         * ada-lex.l (paren_depth): New global.
5029         (lexer_init): Initialize it.
5030
5031 2019-04-04  Tom Tromey  <tom@tromey.com>
5032
5033         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5034         (rust_parser::convert_ast_to_type)
5035         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5036         * parser-defs.h (struct parser_state) <parser_state>: Add
5037         parameters.  Initialize new members.
5038         <expression_context_block, expression_context_pc>: New members.
5039         * parse.c (expression_context_block, expression_context_pc):
5040         Remove globals.
5041         (parse_exp_in_context): Update.
5042         * p-exp.y: Update all rules.
5043         (yylex): Update.
5044         * m2-exp.y: Update all rules.
5045         (yylex): Update.
5046         * go-exp.y (yylex): Update.
5047         * f-exp.y (yylex): Update.
5048         * d-exp.y: Update all rules.
5049         (yylex): Update.
5050         * c-exp.y: Update all rules.
5051         (lex_one_token, classify_name, yylex, c_parse): Update.
5052         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5053
5054 2019-04-04  Tom Tromey  <tom@tromey.com>
5055
5056         * gdbarch.h, gdbarch.c: Rebuild.
5057         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5058         * stap-probe.h: 
5059         (struct stap_parse_info): Replace "parser_state" with
5060         "expr_builder".
5061         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5062         (parser_state): New class.
5063         * parse.c (expr_builder): Rename.
5064         (expr_builder::release): Rename.
5065         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5066         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5067         (write_exp_elt_longcst, write_exp_elt_floatcst)
5068         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5069         (write_exp_string_vector, write_exp_bitstring)
5070         (write_exp_msymbol, mark_struct_expression)
5071         (write_dollar_variable)
5072         (insert_type_address_space, increase_expout_size): Replace
5073         "parser_state" with "expr_builder".
5074         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5075         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5076         "parser_state" with "expr_builder".
5077
5078 2019-04-04  Tom Tromey  <tom@tromey.com>
5079
5080         * rust-exp.y: Replace "parse_language" with method call.
5081         * p-exp.y: 
5082         (yylex): Replace "parse_language" with method call.
5083         * m2-exp.y: 
5084         (yylex): Replace "parse_language" with method call.
5085         * go-exp.y (classify_name): Replace "parse_language" with method
5086         call.
5087         * f-exp.y (yylex): Replace "parse_language" with method call.
5088         * d-exp.y (lex_one_token): Replace "parse_language" with method
5089         call.
5090         * c-exp.y: 
5091         (lex_one_token, classify_name, yylex): Replace "parse_language"
5092         with method call.
5093         * ada-exp.y (find_primitive_type, type_char)
5094         (type_system_address): Replace "parse_language" with method call.
5095
5096 2019-04-04  Tom Tromey  <tom@tromey.com>
5097
5098         * rust-exp.y: Replace "parse_gdbarch" with method call.
5099         * parse.c (write_dollar_variable, insert_type_address_space):
5100         Replace "parse_gdbarch" with method call.
5101         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5102         call.
5103         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5104         call.
5105         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5106         "parse_gdbarch" with method call.
5107         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5108         with method call.
5109         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5110         "parse_gdbarch" with method call.
5111         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5112         "parse_gdbarch" with method call.
5113         * c-exp.y (parse_type, parse_number, classify_name): Replace
5114         "parse_gdbarch" with method call.
5115         * ada-lex.l: Replace "parse_gdbarch" with method call.
5116         * ada-exp.y (parse_type, find_primitive_type, type_char)
5117         (type_system_address): Replace "parse_gdbarch" with method call.
5118
5119 2019-04-04  Tom Tromey  <tom@tromey.com>
5120
5121         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5122         * stap-probe.c (stap_parse_argument): Update.
5123         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5124         initial_size parameter.
5125         * rust-exp.y (rust_lex_tests): Update.
5126         * parse.c (parser_state): Update.
5127         (parse_exp_in_context): Update.
5128         * parser-defs.h (struct parser_state) <parser_state>: Remove
5129         "initial_size" parameter.
5130
5131 2019-04-04  Tom Tromey  <tom@tromey.com>
5132
5133         * parser-defs.h (increase_expout_size): Don't declare.
5134         * parse.c (increase_expout_size): Now static.
5135
5136 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5137
5138         * gnu-nat.c (gnu_nat_target::wait): Fix
5139         target_waitstatus_to_string call.
5140
5141 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5142
5143         * eval.c (evaluate_subexp_standard): Handle internal functions
5144         during Fortran function call handling.
5145
5146 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5147
5148         * NEWS: Mention new internal functions.
5149         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5150         (read_base_type): Use dwarf2_init_complex_target_type.
5151         * value.c (creal_internal_fn): New function.
5152         (cimag_internal_fn): New function.
5153         (_initialize_values): Register new internal functions.
5154
5155 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5156
5157         * infrun.c (stop_all_threads): If debug_infrun, always
5158         trace the wait status after wait_one, using
5159         target_waitstatus_to_string and target_pid_to_str.
5160         (handle_inferior_event): Replace various trace of
5161         wait status kind by a single trace.
5162         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5163         wait status kind image by target_waitstatus_to_string.
5164         * target/waitstatus.c (target_waitstatus_to_string): Fix
5165         obsolete comment.
5166
5167 2019-04-01  Tom Tromey  <tromey@adacore.com>
5168
5169         PR symtab/23331:
5170         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5171
5172 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5173             Pedro Alves  <palves@redhat.com>
5174
5175         * top.c (quit_force): Call 'finalize_values'.
5176         * value.c (finalize_values): New function.
5177         * value.h (finalize_values): Declare.
5178
5179 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5180
5181         * NEWS: Announce $_gdb_major and $_gdb_minor.
5182
5183         * top.c (init_gdb_version_vars): New function.
5184         (gdb_init): Call init_gdb_version_vars.
5185
5186 2019-03-29  Tom Tromey  <tromey@adacore.com>
5187
5188         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5189         help text.  Remove dead code.
5190
5191 2019-03-29  Keith Seitz  <keiths@redhat.com>
5192
5193         From Siddhesh Poyarekar:
5194         * f-lang.h (f77_get_upperbound): Return LONGEST.
5195         (f77_get_lowerbound): Likewise.
5196         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5197         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5198         print them.
5199         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5200         plongest to format print it.
5201         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5202         (f77_get_upperbound): Likewise.
5203         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5204         LOWER_BOUND to LONGEST.
5205         (f77_create_arrayprint_offset_tbl): Likewise.
5206
5207 2019-03-29  Keith Seitz  <keiths@redhat.com>
5208
5209         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5210         %s/pulongest for TYPE_LENGTH instead of %d in format
5211         strings.
5212         * ada-typerint.c (ada_print_type): Likewise.
5213         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5214         * compile/compile-c-support.c (generate_register_struct): Likewise.
5215         * gdbtypes.c (recursive_dump_type): Likewise.
5216         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5217         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5218         instead of %d in format strings.
5219         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5220         to std::min to ULONGEST.
5221         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5222         instead of %d in format strings.
5223         * tracepoint.c (info_scope_command): Likewise.
5224         * typeprint.c (print_offset_data::update)
5225         (print_offset_data::finish): Likewise.
5226         * xtensa-tdep.c (xtensa_store_return_value)
5227         (xtensa_push_dummy_call): Likewise.
5228
5229 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5230
5231         * windows-nat.c (display_selector): Fixed format specifications
5232         for 64-bit Cygwin.
5233
5234 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5235
5236         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5237
5238 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5239
5240         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5241         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5242         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5243         (nios2_linux_init_abi): Install it.
5244
5245 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5246
5247         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5248
5249 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5250
5251         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5252
5253 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5254             Tom Tromey  <tromey@adacore.com>
5255
5256         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5257
5258 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5259
5260         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5261         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5262         method to compute the bounds of range types. Also print "[evaluated]"
5263         if the bounds' values come from a dynamic evaluation.
5264
5265 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5266
5267         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5268         whitespace when pretty printing is on.
5269
5270 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5271
5272         * ppc-linux-nat.c: Add include.
5273
5274 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5275
5276         * NEWS: Mention AArch64 Pointer Authentication.
5277
5278 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5279
5280         * arm-linux-nat.c: Add include.
5281
5282 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5283
5284         * source-cache.c (source_cache::get_source_lines): Re-read
5285         fullname after calling open_source_file.
5286
5287 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5288
5289         * NEWS: Mention TLS support for FreeBSD.
5290
5291 2019-03-25  Tom Tromey  <tromey@adacore.com>
5292
5293         * minsyms.c (BUNCH_SIZE): Update comment.
5294         (~minimal_symbol_reader): Remove old comment.
5295         (compact_minimal_symbols): Update comment.
5296         (minimal_symbol_reader::install): Remove old comment.  Update
5297         other comments.
5298
5299 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5300
5301         * s390-linux-nat.c: Add include.
5302
5303 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5304
5305         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5306         Call linux_get_hwcap.
5307         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5308         Likewise.
5309         (aarch64_linux_get_hwcap): Remove function.
5310         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5311         declaration.
5312         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5313         linux_get_hwcap.
5314         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5315         * linux-tdep.c (linux_get_hwcap): Add function.
5316         (linux_get_hwcap2): Likewise.
5317         * linux-tdep.h (linux_get_hwcap): Add declaration.
5318         (linux_get_hwcap2): Likewise.
5319         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5320         (ppc_linux_get_hwcap2): Likewise.
5321         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5322         linux_get_hwcap.
5323         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5324         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5325         (ppc_linux_nat_target::read_description): Likewise.
5326         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5327         * s390-linux-nat.c: Likewise.
5328         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5329
5330 2019-03-24  Tom Tromey  <tom@tromey.com>
5331
5332         * ada-lang.c (standard_lookup): Simplify initialization.
5333         (ada_lookup_symbol_nonlocal): Simplify return.
5334         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5335         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5336         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5337         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5338         initialization.
5339         * solib.c (solib_global_lookup): Simplify.
5340         * symtab.c (null_block_symbol): Remove.
5341         (symbol_cache_lookup): Simplify returns.
5342         (lookup_language_this): Simplify returns.
5343         (lookup_symbol_aux): Simplify return.
5344         (lookup_local_symbol): Simplify returns.
5345         (lookup_global_symbol_from_objfile): Simplify return.
5346         (lookup_symbol_in_objfile_symtabs)
5347         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5348         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5349         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5350         * cp-namespace.c (cp_lookup_bare_symbol)
5351         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5352         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5353         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5354         (cp_lookup_symbol_via_imports): Simplify initialization.
5355         (find_symbol_in_baseclass): Likewise.
5356         * symtab.h (null_block_symbol): Remove.
5357         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5358         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5359         (d_lookup_symbol_module): Likewise.
5360         (find_symbol_in_baseclass): Simplify initialization.
5361
5362 2019-03-24  Tom Tromey  <tom@tromey.com>
5363
5364         * expression.h: Don't include symtab.h.
5365         (struct block): Forward declare.
5366
5367 2019-03-24  Tom Tromey  <tom@tromey.com>
5368
5369         * c-exp.y (typebase): Remove casts.
5370         * gdbtypes.c (lookup_unsigned_typename, )
5371         (lookup_signed_typename): Remove cast.
5372         * eval.c (parse_to_comma_and_eval): Remove cast.
5373         * parse.c (write_dollar_variable): Remove cast.
5374         * block.h (struct block) <superblock>: Now const.
5375         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5376         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5377         (map_block): Make "block" const.
5378         * symfile.h (struct quick_symbol_functions)
5379         <map_matching_symbols>: Constify block argument to "callback".
5380         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5381         const.
5382         (find_pc_sect_compunit_symtab): Make "b" const.
5383         (find_symbol_at_address): Likewise.
5384         (search_symbols): Likewise.
5385         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5386         (dw2_debug_names_lookup_symbol): Likewise.
5387         (dw2_map_matching_symbols): Update.
5388         * p-valprint.c (pascal_val_print): Remove "block".
5389         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5390         (aux_add_nonlocal_symbols): Make "block" const.
5391         (resolve_subexp): Remove cast.
5392         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5393         const.
5394         (iterate_over_file_blocks): Likewise.
5395         * f-exp.y (%union) <bval>: Remove.
5396         * coffread.c (patch_opaque_types): Make "b" const.
5397         * spu-tdep.c (spu_catch_start): Make "block" const.
5398         * c-valprint.c (print_unpacked_pointer): Remove "block".
5399         * symmisc.c (dump_symtab_1): Make "b" const.
5400         (block_depth): Make "block" const.
5401         * d-exp.y (%union) <bval>: Remove.
5402         * cp-support.h (cp_lookup_rtti_type): Update.
5403         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5404         * psymtab.c (psym_lookup_symbol): Make "block" const.
5405         (maintenance_check_psymtabs): Make "b" const.
5406         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5407         (enumerate_locals, enumerate_args): Update.
5408         * python/py-symtab.c (stpy_global_block): Make "block" const.
5409         (stpy_static_block): Likewise.
5410         * inline-frame.c (block_starting_point_at): Make "new_block"
5411         const.
5412         * block.c (find_block_in_blockvector): Make return type const.
5413         (blockvector_for_pc_sect): Make "b" const.
5414         (find_block_in_blockvector): Make "b" const.
5415
5416 2019-03-23  Tom Tromey  <tom@tromey.com>
5417
5418         * varobj.c (varobj_create): Update.
5419         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5420         * printcmd.c (display_command, do_one_display): Don't reset
5421         innermost_block.
5422         * parser-defs.h (enum innermost_block_tracker_type): Move to
5423         expression.h.
5424         (innermost_block): Update comment.
5425         * parse.c (parse_exp_1): Add tracker_types parameter.
5426         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5427         tracker_types parameter.  Reset innermost_block.
5428         (parse_exp_in_context): Remove.
5429         (parse_expression_for_completion): Update.
5430         * objfiles.c (~objfile): Don't reset expression_context_block or
5431         innermost_block.
5432         * expression.h (enum innermost_block_tracker_type): Move from
5433         parser-defs.h.
5434         (parse_exp_1): Add tracker_types parameter.
5435         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5436         reset innermost_block.
5437
5438 2019-03-23  Tom Tromey  <tom@tromey.com>
5439
5440         * objfiles.h: Include bcache.h.
5441
5442 2019-03-23  Tom Tromey  <tom@tromey.com>
5443
5444         * linespec.c (get_current_search_block): Use
5445         scoped_restore_current_language.
5446         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5447
5448 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5449             Jiong Wang  <jiong.wang@arm.com>
5450
5451         * aarch64-linux-tdep.c
5452         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5453         section.
5454         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5455
5456 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5457             Jiong Wang  <jiong.wang@arm.com>
5458
5459         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5460         instructions.
5461         (aarch64_analyze_prologue_test): Add PACIASP test.
5462         (aarch64_prologue_prev_register): Unmask PC value.
5463
5464 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5465             Jiong Wang  <jiong.wang@arm.com>
5466
5467         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5468         (aarch64_dwarf2_prev_register): Unmask PC value.
5469         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5470         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5471         DW_CFA_AARCH64_negate_ra_state.
5472         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5473
5474 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5475             Jiong Wang  <jiong.wang@arm.com>
5476
5477         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5478         registers.
5479         (aarch64_pseudo_register_name): Likewise.
5480         (aarch64_pseudo_register_type): Likewise.
5481         (aarch64_pseudo_register_reggroup_p): Likewise.
5482         (aarch64_gdbarch_init): Add pauth registers.
5483         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5484         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5485         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5486         (struct gdbarch_tdep): Add regnum for ra_state.
5487
5488 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5489             Jiong Wang  <jiong.wang@arm.com>
5490
5491         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5492
5493 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5494             Jiong Wang  <jiong.wang@arm.com>
5495
5496         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5497         function.
5498         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5499         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5500         (aarch64_gdbarch_init): Add puth registers.
5501         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5502         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5503         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5504
5505 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5506             Jiong Wang  <jiong.wang@arm.com>
5507
5508         * aarch64-linux-nat.c
5509         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5510         * aarch64-linux-tdep.c
5511         (aarch64_linux_core_read_description): Likewise.
5512         (aarch64_linux_get_hwcap): New function.
5513         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5514         (aarch64_linux_get_hwcap): New declaration.
5515
5516 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5517             Jiong Wang  <jiong.wang@arm.com>
5518
5519         * aarch64-linux-nat.c
5520         (aarch64_linux_nat_target::read_description): Add pauth param.
5521         * aarch64-linux-tdep.c
5522         (aarch64_linux_core_read_description): Likewise.
5523         * aarch64-tdep.c (struct target_desc): Add in pauth.
5524         (aarch64_read_description): Add pauth param.
5525         (aarch64_gdbarch_init): Likewise.
5526         * aarch64-tdep.h (aarch64_read_description): Likewise.
5527         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5528         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5529         * features/Makefile: Add new files.
5530         * features/aarch64-pauth.c: New file.
5531         * features/aarch64-pauth.xml: New file.
5532
5533 2019-03-20  Tom Tromey  <tromey@adacore.com>
5534
5535         * infrun.c (handle_inferior_event): Rename from
5536         handle_inferior_event_1.  Create a scoped_value_mark.
5537         (handle_inferior_event): Remove.
5538
5539 2019-03-19  Tom Tromey  <tromey@adacore.com>
5540
5541         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5542         * infrun.h (print_stop_event): Add "displays" parameter.
5543         * infrun.c (print_stop_event): Add "displays" parameter.
5544
5545 2019-03-19  Pedro Alves  <palves@redhat.com>
5546
5547         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5548         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5549         to -1.  Fix TABs vs spaces.
5550         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5551         * tui/tui-out.h (tui_ui_out) Add intro comments.
5552         <m_line, m_start_of_line>: In-class initialize, and add describing
5553         comment.
5554
5555 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5556
5557         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5558         variable names.
5559         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5560
5561 2019-03-18  Pedro Alves  <palves@redhat.com>
5562             Eli Zaretskii <eliz@gnu.org>
5563
5564         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5565         m_line and m_start_of_line.
5566
5567 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5568
5569         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5570         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5571         it returns a newline.  This fixes a regression in TU mode, whereby
5572         the next line is output on the same screen line as the user input.
5573
5574 2019-03-18  Tom Tromey  <tromey@adacore.com>
5575
5576         * minsyms.c (minimal_symbol_reader::install): Remove call to
5577         obstack_blank.
5578
5579 2019-03-18  Pedro Alves  <palves@redhat.com>
5580
5581         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5582         New globals.
5583         (apply_style): New, factored out from ...
5584         (apply_ansi_escape): ... this.  Handle reverse video mode.
5585         (tui_set_reverse_mode): New function.
5586         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5587         * tui/tui-winsource.c (tui_show_source_line): Use
5588         tui_set_reverse_mode instead of setting A_STANDOUT.
5589         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5590         New setter methods.
5591
5592 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5593
5594         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5595         Handle tabs.
5596
5597 2019-03-18  Tom Tromey  <tromey@adacore.com>
5598
5599         * ada-lang.c (empty_array): Add "high" parameter.
5600         (ada_evaluate_subexp): Update.
5601
5602 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5603
5604         * unittests/string_view-selftests.c: Define
5605         _initialize_string_view_selftests unconditionally.
5606
5607 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5608
5609         PR gdb/24350
5610         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5611
5612 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5613
5614         PR gdb/24351
5615         * windows-nat.c (display_selector): Fix format specifiers.
5616
5617 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5618
5619         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5620         tui_refill_source_window instead of tui_refresh_win, to update the
5621         current execution line.  This fixes redisplay of the current line
5622         when stepping through the code with "next" or "step".
5623
5624 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5625
5626         * source-cache.c (source_cache::get_source_lines): Call
5627         find_source_lines to initialize s->nlines.  This fixes vertical
5628         scrolling of TUI source window when the DOWN arrow is pressed.
5629
5630 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5631
5632         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5633         linux-thread-db.c (_initialize_thread_db): Likewise.
5634
5635 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5636
5637         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5638         wclrtoeol in tui_show_source_line".  This reverts changes made in
5639         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5640
5641 2019-03-15  Tom Tromey  <tom@tromey.com>
5642
5643         * symtab.h (struct minimal_symbol): Derive from
5644         general_symbol_info.
5645         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5646         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5647         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5648         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5649         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5650         (MSYMBOL_SEARCH_NAME): Update.
5651         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5652         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5653         * minsyms.c (minimal_symbol_reader::record_full): Update.
5654
5655 2019-03-15  Tom Tromey  <tom@tromey.com>
5656
5657         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5658
5659 2019-03-15  Tom Tromey  <tom@tromey.com>
5660
5661         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5662         unique_xmalloc_ptr.
5663         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5664         Update.
5665         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5666         (build_minimal_symbol_hash_tables)
5667         (minimal_symbol_reader::install): Update.
5668
5669 2019-03-15  Tom Tromey  <tom@tromey.com>
5670
5671         * symtab.c (create_demangled_names_hash): Update.
5672         (symbol_set_names): Update.
5673         * objfiles.h (struct objfile_per_bfd_storage)
5674         <demangled_names_hash>: Now an htab_up.
5675         * objfiles.c (objfile_per_bfd_storage): Simplify.
5676
5677 2019-03-15  Tom Tromey  <tom@tromey.com>
5678
5679         * objfiles.h (struct objfile_per_bfd_storage): Declare
5680         destructor.
5681         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5682         New.
5683         (get_objfile_bfd_data): Use new.  Don't initialize
5684         language_of_main.
5685         (free_objfile_per_bfd_storage): Remove.
5686         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5687
5688 2019-03-15  Tom Tromey  <tom@tromey.com>
5689
5690         * symfile.c (reread_symbols): Update.
5691         * objfiles.c (objfile::objfile): Update.
5692         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5693         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5694         comment.
5695         (minimal_symbol_reader::install): Update.
5696         (terminate_minimal_symbol_table): Remove.
5697         * jit.c (jit_object_close_impl): Update.
5698
5699 2019-03-15  Tom Tromey  <tom@tromey.com>
5700
5701         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5702         initializations.
5703
5704 2019-03-15  Tom Tromey  <tom@tromey.com>
5705
5706         * objfiles.h (struct objfile_per_bfd_storage)
5707         <demangled_hash_languages>: Now a bitset.
5708         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5709         (lookup_minimal_symbol): Update.
5710
5711 2019-03-15  Tom Tromey  <tom@tromey.com>
5712
5713         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5714         Don't return the symbol.
5715         * coffread.c (record_minimal_symbol): Use record_full.
5716
5717 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5718
5719         The MS-Windows port of ncurses fails to switch to a color pair if
5720         one or both of the colors are the implicit default colors.  This
5721         change records the default colors when TUI is initialized, and
5722         then specifies them explicitly when a color pair uses the default
5723         colors.  This allows color styling in TUI mode on MS-Windows.
5724
5725         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5726         ncurses_norm_attr.
5727         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5728         colors in ncurses_norm_attr.
5729         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5730         "none", replace it with the default color recorded in
5731         ncurses_norm_attr.
5732
5733 2019-03-14  Tom Tromey  <tromey@adacore.com>
5734
5735         * source-cache.h (class source_cache) <get_source_lines>: Return
5736         std::string.
5737         * source-cache.c (source_cache::extract_lines): Handle case where
5738         first_pos==npos.  Return std::string.
5739         (source_cache::get_source_lines): Update.
5740
5741 2019-03-14  Tom Tromey  <tromey@adacore.com>
5742
5743         * NEWS: Add item for "style sources" commands.
5744         * source-cache.c (source_cache::get_source_lines): Check
5745         source_styling.
5746         * cli/cli-style.c (source_styling): New global.
5747         (_initialize_cli_style): Add "style sources" commands.
5748         (show_style_sources): New function.
5749         * cli/cli-style.h (source_styling): Declare.
5750
5751 2019-03-14  Pedro Alves  <palves@redhat.com>
5752             Tom Tromey  <tromey@adacore.com>
5753
5754         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5755         * tui/tui-winsource.c (tui_refill_source_window): New function,
5756         from...
5757         (tui_horizontal_source_scroll): ... here.  Move some logic.
5758         * cli/cli-style.c (set_style_enabled): Notify new observable.
5759         * tui/tui-hooks.c (tui_redisplay_source): New function.
5760         (tui_attach_detach_observers): Attach or detach
5761         tui_redisplay_source.
5762         * observable.h (source_styling_changed): New observable.
5763         * observable.c: Define source_styling_changed observable.
5764
5765 2019-03-13  Tom Tromey  <tromey@adacore.com>
5766
5767         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5768         (i386_gnu_nat_target::store_registers): Update.
5769         * target-debug.h (target_debug_print_std_string): New macro.
5770         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5771         * windows-tdep.c (display_one_tib): Update.
5772         * tui/tui-stack.c (tui_make_status_line): Update.
5773         * top.c (print_inferior_quit_action): Update.
5774         * thread.c (thr_try_catch_cmd): Update.
5775         (add_thread_with_info): Update.
5776         (thread_target_id_str): Update.
5777         (thr_try_catch_cmd): Update.
5778         (thread_command): Update.
5779         (thread_find_command): Update.
5780         * record-btrace.c (record_btrace_target::info_record)
5781         (record_btrace_resume_thread, record_btrace_target::resume)
5782         (record_btrace_cancel_resume, record_btrace_step_thread)
5783         (record_btrace_target::wait, record_btrace_target::wait)
5784         (record_btrace_target::wait, record_btrace_target::stop): Update.
5785         * progspace.c (print_program_space): Update.
5786         * process-stratum-target.c
5787         (process_stratum_target::thread_address_space): Update.
5788         * linux-fork.c (linux_fork_mourn_inferior)
5789         (detach_checkpoint_command, info_checkpoints_command)
5790         (linux_fork_context): Update.
5791         (linux_fork_detach): Update.
5792         (class scoped_switch_fork_info): Update.
5793         (delete_checkpoint_command): Update.
5794         * infrun.c (follow_fork_inferior): Update.
5795         (follow_fork_inferior): Update.
5796         (proceed_after_vfork_done): Update.
5797         (handle_vfork_child_exec_or_exit): Update.
5798         (follow_exec): Update.
5799         (displaced_step_prepare_throw): Update.
5800         (displaced_step_restore): Update.
5801         (start_step_over): Update.
5802         (resume_1): Update.
5803         (clear_proceed_status_thread): Update.
5804         (proceed): Update.
5805         (print_target_wait_results): Update.
5806         (do_target_wait): Update.
5807         (context_switch): Update.
5808         (stop_all_threads): Update.
5809         (restart_threads): Update.
5810         (finish_step_over): Update.
5811         (handle_signal_stop): Update.
5812         (switch_back_to_stepped_thread): Update.
5813         (keep_going_pass_signal): Update.
5814         (print_exited_reason): Update.
5815         (normal_stop): Update.
5816         * inferior.c (inferior_pid_to_str): Change return type.
5817         (print_selected_inferior): Update.
5818         (add_inferior): Update.
5819         (detach_inferior): Update.
5820         * dummy-frame.c (fprint_dummy_frames): Update.
5821         * dcache.c (dcache_info_1): Update.
5822         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5823         (btrace_fetch, btrace_clear): Update.
5824         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5825         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5826         type.
5827         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5828         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5829         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5830         * gdbarch.c, gdbarch.h: Rebuild.
5831         * gdbarch.sh (core_pid_to_str): Change return type.
5832         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5833         return type.
5834         (windows_nat_target::pid_to_str): Change return type.
5835         (windows_delete_thread): Update.
5836         (windows_nat_target::attach): Update.
5837         (windows_nat_target::files_info): Update.
5838         * target-delegates.c: Rebuild.
5839         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5840         return type.
5841         (sol_thread_target::pid_to_str): Change return type.
5842         * remote.c (class remote_target) <pid_to_str>: Change return
5843         type.
5844         (remote_target::pid_to_str): Change return type.
5845         (extended_remote_target::attach, remote_target::remote_stop_ns)
5846         (remote_target::remote_notif_remove_queued_reply)
5847         (remote_target::push_stop_reply, remote_target::disable_btrace):
5848         Update.
5849         (extended_remote_target::attach): Update.
5850         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5851         type.
5852         (gdbsim_target::pid_to_str): Change return type.
5853         * ravenscar-thread.c (struct ravenscar_thread_target)
5854         <pid_to_str>: Change return type.
5855         (ravenscar_thread_target::pid_to_str): Change return type.
5856         * procfs.c (class procfs_target) <pid_to_str>: Change return
5857         type.
5858         (procfs_target::pid_to_str): Change return type.
5859         (procfs_target::attach): Update.
5860         (procfs_target::detach): Update.
5861         (procfs_target::fetch_registers): Update.
5862         (procfs_target::store_registers): Update.
5863         (procfs_target::wait): Update.
5864         (procfs_target::files_info): Update.
5865         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5866         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5867         return type.
5868         (nto_procfs_target::pid_to_str): Change return type.
5869         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5870         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5871         return type.
5872         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5873         (exit_lwp): Update.
5874         (attach_proc_task_lwp_callback, get_detach_signal)
5875         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5876         (linux_nat_target::resume, wait_lwp, stop_callback)
5877         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5878         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5879         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5880         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5881         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5882         type.
5883         (inf_ptrace_target::attach): Update.
5884         (inf_ptrace_target::files_info): Update.
5885         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5886         type.
5887         (go32_nat_target::pid_to_str): Change return type.
5888         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5889         (gnu_nat_target::wait): Update.
5890         (gnu_nat_target::wait): Update.
5891         (gnu_nat_target::resume): Update.
5892         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5893         (fbsd_nat_target::wait): Update.
5894         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5895         type.
5896         (darwin_nat_target::attach): Update.
5897         * corelow.c (class core_target) <pid_to_str>: Change return type.
5898         (core_target::pid_to_str): Change return type.
5899         * target.c (normal_pid_to_str): Change return type.
5900         (default_pid_to_str): Likewise.
5901         (target_pid_to_str): Change return type.
5902         (target_translate_tls_address): Update.
5903         (target_announce_detach): Update.
5904         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5905         return type.
5906         (bsd_uthread_target::pid_to_str): Change return type.
5907         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5908         type.
5909         (bsd_kvm_target::pid_to_str): Change return type.
5910         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5911         return type.
5912         (aix_thread_target::pid_to_str): Change return type.
5913         * target.h (struct target_ops) <pid_to_str>: Change return type.
5914         (target_pid_to_str, normal_pid_to_str): Likewise.
5915         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5916         type.
5917         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5918         type.
5919         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5920         return type.
5921         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5922         type.
5923         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5924         type.
5925         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5926         return type.
5927
5928 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5929
5930         * NEWS: Mention that the new default MI version is 3.  Mention
5931         changes to the output of commands and events that deal with
5932         multi-location breakpoints.
5933         * breakpoint.c: Include "mi/mi-out.h".
5934         (print_one_breakpoint): Change output syntax if using MI version
5935         >= 3.
5936         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5937         New.
5938         (mi_multi_location_breakpoint_output_fixed): New.
5939         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5940         (mi_cmd_fix_multi_location_breakpoint_output): New.
5941         (mi_multi_location_breakpoint_output_fixed): New.
5942         * mi/mi-cmds.c (mi_cmds): Register command
5943         -fix-multi-location-breakpoint-output.
5944         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5945         interpreter "mi".
5946
5947 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5948
5949         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5950         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5951         instantiate mi_ui_out based on interpreter name.
5952         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5953         * mi/mi-main.c (mi_load_progress): Likewise.
5954
5955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5956
5957         * NEWS: Combine separate "New targets" sections for 8.3.
5958
5959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5960
5961         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5962         (ppcfbsd_init_abi): Install gdbarch
5963         "fetch_tls_load_module_address" and "get_thread_local_address"
5964         methods.
5965
5966 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5967
5968         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5969         (riscv_fbsd_init_abi): Install gdbarch
5970         "fetch_tls_load_module_address" and "get_thread_local_address"
5971         methods.
5972
5973 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5974
5975         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5976         (i386fbsd_init_abi): Install gdbarch
5977         "fetch_tls_load_module_address" and "get_thread_local_address"
5978         methods.
5979
5980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5981
5982         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5983         (amd64fbsd_init_abi): Install gdbarch
5984         "fetch_tls_load_module_address" and "get_thread_local_address"
5985         methods.
5986
5987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5988
5989         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5990         (struct fbsd_pspace_data): New type.
5991         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5992         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5993         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5994         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5995         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5996
5997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5998
5999         * gdbtypes.c (lookup_struct_elt): New function.
6000         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6001         * gdbtypes.h (struct struct_elt): New type.
6002         (lookup_struct_elt): New prototype.
6003
6004 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6005
6006         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6007         remove disabled code block.
6008
6009 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6010
6011         * gdbarch.sh (get_thread_local_address): New method.
6012         * gdbarch.h, gdbarch.c: Regenerate.
6013         * target.c (target_translate_tls_address): Use
6014         gdbarch_get_thread_local_address if present instead of
6015         target::get_thread_local_address.
6016
6017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6018
6019         * target.h (target::get_thread_local_address): Update comment.
6020
6021 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6022
6023         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6024         objfile->separate_debug_objfile_backlink if not NULL.
6025
6026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6027
6028         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6029         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6030         (amd64bsd_store_inferior_registers): Likewise.
6031         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6032         Enable segment base registers.
6033         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6034         PT_GETFSBASE and PT_GETGSBASE.
6035         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6036         PT_SETGSBASE.
6037         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6038         segment base registers.
6039         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6040
6041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6042
6043         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6044         Update calls to i386_target_description to add 'segments'
6045         parameter.
6046         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6047         add segment base registers.
6048         * arch/i386.c (i386_create_target_description): Add 'segments'
6049         parameter to enable segment base registers.
6050         * arch/i386.h (i386_create_target_description): Likewise.
6051         * features/i386/32bit-segments.xml: New file.
6052         * features/i386/32bit-segments.c: Generate.
6053         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6054         call to i386_target_description to add 'segments' parameter.
6055         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6056         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6057         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6058         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6059         if feature is present.
6060         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6061         Add 'segments' parameter to call to i386_target_description.
6062         (i386_target_description): Add 'segments' parameter to enable
6063         segment base registers.
6064         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6065         to call to i386_target_description.
6066         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6067         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6068         Define I386_NUM_REGS.
6069         (i386_target_description): Add 'segments' parameter to enable
6070         segment base registers.
6071
6072 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6073
6074         PR/24325
6075         * source-cache.c: #undef open and close, to avoid unresolved
6076         externals during linking.
6077
6078 2019-03-12  Tom Tromey  <tromey@adacore.com>
6079
6080         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6081         const.  Add initializers.
6082         (_initialize_remote): Don't initialize ptid globals.
6083
6084 2019-03-12  Pedro Alves  <palves@redhat.com>
6085
6086         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6087
6088 2019-03-12  Pedro Alves  <palves@redhat.com>
6089
6090         * cp-name-parser.y (main): Remove unused 'len' variable.
6091
6092 2019-03-12  Tom Tromey  <tromey@adacore.com>
6093
6094         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6095         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6096
6097 2019-03-12  Tom Tromey  <tromey@adacore.com>
6098
6099         * linux-nat.c (iterate_over_lwps): Update.
6100         (stop_callback): Remove parameter.
6101         (stop_wait_callback, detach_callback, resume_set_callback)
6102         (select_singlestep_lwp_callback, set_ignore_sigint)
6103         (status_callback, resumed_callback, resume_clear_callback)
6104         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6105         data parameter.
6106         (linux_nat_target::detach, linux_nat_target::resume)
6107         (linux_stop_and_wait_all_lwps, select_event_lwp)
6108         (linux_nat_filter_event, linux_nat_wait_1)
6109         (linux_nat_target::kill, linux_nat_target::stop)
6110         (linux_nat_target::stop): Update.
6111         (linux_nat_resume_callback): Change type.
6112         (resume_stopped_resumed_lwps, count_events_callback)
6113         (select_event_lwp_callback): Likewise.
6114         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6115         * arm-linux-nat.c (struct update_registers_data): Remove.
6116         (update_registers_callback): Change type.
6117         (arm_linux_insert_hw_breakpoint1): Update.
6118         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6119         parameter.
6120         (x86_linux_dr_set_addr): Update.
6121         (x86_linux_dr_set_control): Update.
6122         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6123         (iterate_over_lwps): Use gdb::function_view.
6124         * nat/aarch64-linux-hw-point.c (struct
6125         aarch64_dr_update_callback_param): Remove.
6126         (debug_reg_change_callback): Change type.
6127         (aarch64_notify_debug_reg_change): Update.
6128         * s390-linux-nat.c (s390_refresh_per_info): Update.
6129
6130 2019-03-11  Tom Tromey  <tromey@adacore.com>
6131
6132         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6133         redundant assignment to "this_cu".
6134
6135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6136
6137         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6138
6139 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6140
6141         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6142         from...
6143         (rank_one_type): ... this.
6144
6145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6146
6147         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6148         from...
6149         (rank_one_type): ... this.
6150
6151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6152
6153         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6154         from...
6155         (rank_one_type): ... this.
6156
6157 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6158
6159         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6160         from...
6161         (rank_one_type): ... this.
6162
6163 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6164
6165         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6166         from...
6167         (rank_one_type): ... this.
6168
6169 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6170
6171         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6172         from...
6173         (rank_one_type): ... this.
6174
6175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6176
6177         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6178         from...
6179         (rank_one_type): ... this.
6180
6181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6182
6183         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6184         from...
6185         (rank_one_type): ... this.
6186
6187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6188
6189         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6190         from...
6191         (rank_one_type): ... this.
6192
6193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6194
6195         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6196         from...
6197         (rank_one_type): ... this.
6198
6199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6200
6201         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6202         from...
6203         (rank_one_type): ... this.
6204
6205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6206
6207         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6208         from...
6209         (rank_one_type): ... this.
6210
6211 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6212
6213         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6214         inferior-events' shows the example events.
6215
6216 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6217
6218         Support styling on native MS-Windows console
6219
6220         PR/24315
6221         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6222         on MS-Windows if $TERM is not defined.
6223
6224         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6225
6226         * posix-hdep.c (gdb_console_fputs):
6227         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6228         functions.
6229         * ui-file.h (gdb_console_fputs): Add prototype.
6230
6231         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6232         back to fputs only if the former returns zero.
6233
6234 2019-03-07  Tom Tromey  <tom@tromey.com>
6235
6236         * symmisc.c (print_symbol_bcache_statistics): Update.
6237         (print_objfile_statistics): Update.
6238         * symfile.c (allocate_symtab): Update.
6239         * stabsread.c: Don't include bcache.h.
6240         * psymtab.h (struct psymbol_bcache): Don't declare.
6241         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6242         (psymbol_bcache_init, psymbol_bcache_free)
6243         (psymbol_bcache_get_bcache): Don't declare.
6244         * psymtab.c (struct psymbol_bcache): Remove.
6245         (psymtab_storage::psymtab_storage): Update.
6246         (psymtab_storage::~psymtab_storage): Update.
6247         (psymbol_bcache_init, psymbol_bcache_free)
6248         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6249         (add_psymbol_to_bcache): Update.
6250         (allocate_psymtab): Update.
6251         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6252         macro_cache>: No longer pointers.
6253         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6254         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6255         * macrotab.c (macro_bcache): Update.
6256         * macroexp.c: Don't include bcache.h.
6257         * gdbtypes.c (check_types_worklist): Update.
6258         (types_deeply_equal): Remove TRY/CATCH.  Update.
6259         * elfread.c (elf_symtab_read): Update.
6260         * dwarf2read.c: Don't include bcache.h.
6261         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6262         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6263         (print_bcache_statistics, bcache_memory_used): Don't declare.
6264         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6265         methods.  Rename all data members.
6266         * bcache.c (struct bcache): Move to bcache.h.
6267         (bcache::expand_hash_table): Rename from expand_hash_table.
6268         (bcache): Remove.
6269         (bcache::insert): Rename from bcache_full.
6270         (bcache::compare): Rename from bcache_compare.
6271         (bcache_xmalloc): Remove.
6272         (bcache::~bcache): Rename from bcache_xfree.
6273         (bcache::print_statistics): Rename from print_bcache_statistics.
6274         (bcache::memory_used): Rename from bcache_memory_used.
6275
6276 2019-03-07  Pedro Alves  <palves@redhat.com>
6277
6278         * infrun.c (normal_stop): Also check for
6279         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6280
6281 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6282
6283         * f-lang.c (value_from_host_double): Moved to...
6284         * value.c (value_from_host_double): ...here.
6285         * value.h (value_from_host_double): Declare.
6286         * guile/scm-math.c (vlscm_convert_typed_number): Use
6287         value_from_host_double.
6288         (vlscm_convert_number): Likewise.
6289         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6290         * python/py-value.c (convert_value_from_python): Likewise.
6291
6292 2019-03-06  Tom Tromey  <tom@tromey.com>
6293
6294         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6295
6296 2019-03-06  Tom Tromey  <tom@tromey.com>
6297
6298         * utils.h (free_current_contents): Don't declare.
6299         * utils.c (free_current_contents): Remove.
6300
6301 2019-03-06  Tom Tromey  <tom@tromey.com>
6302
6303         * top.c (quit_force): Update.
6304         * main.c (captured_command_loop): Update.
6305         * common/new-op.c (operator new): Update.
6306         * common/common-exceptions.c (struct catcher)
6307         <save_cleanup_chain>: Remove member.
6308         (exceptions_state_mc_init): Update.
6309         (exception_try_scope_entry): Return nullptr.
6310         (exception_try_scope_exit, exception_rethrow)
6311         (throw_exception_sjlj, throw_exception_cxx): Update.
6312         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6313         (all_cleanups, do_cleanups, discard_cleanups)
6314         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6315         (restore_cleanups, restore_final_cleanups): Don't declare.
6316         (do_final_cleanups): Remove parameter.
6317         * common/cleanups.c (cleanup_chain, make_cleanup)
6318         (make_cleanup_dtor, all_cleanups, do_cleanups)
6319         (discard_my_cleanups, discard_cleanups)
6320         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6321         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6322         (null_cleanup): Remove.
6323         (do_final_cleanups): Remove parameter.
6324
6325 2019-03-06  Tom Tromey  <tom@tromey.com>
6326
6327         * remote.c (remote_target::remote_parse_stop_reply): Use
6328         unique_xmalloc_ptr.
6329
6330 2019-03-06  Tom Tromey  <tom@tromey.com>
6331
6332         * stabsread.c (struct stabs_field_info): Rename from field_info.
6333         <list, fnlist>: Add initializers.
6334         <obstack>: New member.
6335         (read_member_functions, read_struct_fields, read_baseclasses):
6336         Allocate on obstack.  Don't use cleanups.
6337         (read_one_struct_field, read_member_functions, read_struct_fields)
6338         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6339         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6340         (read_struct_type): Update.
6341
6342 2019-03-06  Tom Tromey  <tom@tromey.com>
6343
6344         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6345         * common/filestuff.h (make_cleanup_close): Don't declare.
6346         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6347         Remove.
6348
6349 2019-03-06  Tom Tromey  <tom@tromey.com>
6350
6351         * solib-aix.c: Use make_scope_exit.
6352
6353 2019-03-06  Tom Tromey  <tom@tromey.com>
6354
6355         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6356         Use make_scope_exit.
6357
6358 2019-03-06  Tom Tromey  <tom@tromey.com>
6359
6360         * solib-svr4.c (disable_probes_interface): Remove parameter.
6361         (svr4_handle_solib_event): Use make_scope_exit.
6362
6363 2019-03-06  Tom Tromey  <tom@tromey.com>
6364
6365         * remote.c (struct stop_reply_deleter): Remove.
6366         (stop_reply_up): Update.
6367         (struct stop_reply): Derive from notif_event.  Don't typedef.
6368         <regcache>: Now a std::vector.
6369         (stop_reply_xfree): Remove.
6370         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6371         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6372         (remote_target::discard_pending_stop_replies): Use delete.
6373         (remote_target::remote_parse_stop_reply): Update.
6374         (remote_target::process_stop_reply): Update.
6375         * remote-notif.h (struct notif_event): Add virtual destructor.
6376         Remove "dtr" member.
6377         (struct notif_client) <alloc_event>: Return a unique_ptr.
6378         (notif_event_xfree): Don't declare.
6379         (notif_event_up): New typedef.
6380         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6381         (notif_event_xfree, do_notif_event_xfree): Remove.
6382         (remote_notif_state_xfree): Update.
6383
6384 2019-03-06  Tom Tromey  <tom@tromey.com>
6385
6386         * infrun.c (displaced_step_clear_cleanup): Now a
6387         forward_scope_exit type.
6388         (displaced_step_prepare_throw): Update.
6389         (displaced_step_fixup): Update.
6390
6391 2019-03-06  Tom Tromey  <tom@tromey.com>
6392
6393         * inferior.h (class inferior): Update comment.
6394         * gdbthread.h (class thread_info): Update comment.
6395
6396 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6397             Tom Tromey  <tom@tromey.com>
6398
6399         * stabsread.h (struct stab_section_list): Remove.
6400         (coffstab_build_psymtabs): Update.
6401         * dbxread.c (symbuf_sections): Now a std::vector.
6402         (sect_idx): New global.
6403         (fill_symbuf): Update.
6404         (coffstab_build_psymtabs): Change type of stabsects parameter.
6405         Update.
6406         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6407         std::vector.
6408         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6409         (coff_locate_sections): Update.
6410         (coff_symfile_read): Remove cleanups.  Update.
6411         (init_stringtab): Add storage parameter.
6412         (free_stringtab, free_stringtab_cleanup): Remove.
6413         (init_lineno): Add storage parameter.
6414         (free_linetab, free_linetab_cleanup): Remove.
6415
6416 2019-03-06  Pedro Alves  <palves@redhat.com>
6417
6418         * linux-fork.c (fork_info::clobber_regs): Delete.
6419         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6420         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6421         comment.  Adjust.
6422         (scoped_switch_fork_info::scoped_switch_fork_info)
6423         (checkpoint_command, linux_fork_context): Adjust
6424         fork_save_infrun_state calls.
6425
6426 2019-03-06  Pedro Alves  <palves@redhat.com>
6427
6428         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6429         (inf_has_multiple_threads): Return 'bool' and rewrite using
6430         inferior_info::threads().
6431
6432 2019-03-06  Pedro Alves  <palves@redhat.com>
6433
6434         * linux-fork.c: Include <list>.
6435         (fork_list): Now a std::list instance.
6436         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6437         (forks_exist_p, find_last_fork): Adjust.
6438         (new_fork): Delete.
6439         (one_fork_p): New.
6440         (add_fork): Adjust.
6441         (free_fork): Delete, folded into fork_info::~fork_info().
6442         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6443         Adjust.
6444         (init_fork_list): Delete.
6445         (linux_fork_killall, linux_fork_mourn_inferior)
6446         (linux_fork_detach, info_checkpoints_command): Adjust.
6447         (_initialize_linux_fork): No longer call init_fork_list.
6448
6449 2019-03-06  Pedro Alves  <palves@redhat.com>
6450
6451         * linux-fork.c (new_fork): New, split out of ...
6452         (add_fork): ... this.  Return void.  Move "first fork" special
6453         case from here, to ...
6454         (checkpoint_command): ... here.
6455         * linux-linux.h (add_fork): Return void.
6456
6457 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6458
6459         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6460
6461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6462             Chris January  <chris.january@arm.com>
6463             David Lecomber  <david.lecomber@arm.com>
6464
6465         * f-exp.y: New token, UNOP_INTRINSIC.
6466         (exp): New pattern using UNOP_INTRINSIC token.
6467         (f77_keywords): Add 'abs' keyword.
6468         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6469         (value_from_host_double): New function.
6470         (evaluate_subexp_f): Support UNOP_ABS.
6471
6472 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6473
6474         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6475         types.
6476
6477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6478
6479         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6480         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6481         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6482
6483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6486
6487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6488             Chris January  <chris.january@arm.com>
6489
6490         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6491         * f-exp.y: Define 'KIND' token.
6492         (exp): New pattern for KIND expressions.
6493         (ptype): Handle types with a kind extension.
6494         (direct_abs_decl): Extend to spot kind extensions.
6495         (f77_keywords): Add 'kind' to the list.
6496         (push_kind_type): New function.
6497         (convert_to_kind_type): New function.
6498         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6499         * parse.c (operator_length_standard): Likewise.
6500         * parser-defs.h (enum type_pieces): Add tp_kind.
6501         * std-operator.def: Add UNOP_KIND.
6502
6503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6504
6505         * f-exp.y (f_parse): Set yydebug.
6506
6507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6508
6509         * f-lang.c (evaluate_subexp_f): New function.
6510         (exp_descriptor_f): New global.
6511         (f_language_defn): Use exp_descriptor_f instead of
6512         exp_descriptor_standard.
6513
6514 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * f-exp.y (struct token): Add comments.
6517         (dot_ops): Remove uppercase versions and the end marker.
6518         (f77_keywords): Likewise.
6519         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6520         entries in the dot_ops array are case insensitive, and use
6521         strncasecmp to compare strings.  Also some whitespace cleanup in
6522         this area.  Similar for the f77_keywords array, except entries in
6523         this list might be case sensitive.
6524
6525 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6526
6527         * f-exp.y (struct f77_boolean_val): Add comments.
6528         (boolean_values): Remove uppercase versions, and end marker.
6529         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6530         and use strncasecmp to achieve case insensitivity.  Additionally,
6531         perform whitespace cleanup around this code.
6532
6533 2019-03-06  Tom Tromey  <tromey@adacore.com>
6534
6535         * remote-sim.c (gdbsim_target_open): Use result of
6536         gdb_argv::release.
6537
6538 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6539         Dirk Schubert  <dirk.schubert@arm.com>
6540         Chris January  <chris.january@arm.com>
6541
6542         * eval.c (evaluate_subexp_standard): Call Fortran argument
6543         wrapping logic.
6544         * f-lang.c (struct value): A value which can be passed into a
6545         Fortran function call.
6546         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6547         where appropriate.
6548         (struct type): Value ready for a Fortran function call.
6549         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6550         is needed.
6551         * f-lang.h (fortran_argument_convert): Declaration.
6552         (fortran_preserve_arg_pointer): Declaration.
6553         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6554
6555 2019-03-05  Tom Tromey  <tromey@adacore.com>
6556
6557         * python/py-prettyprint.c (print_string_repr): Remove #if.
6558         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6559
6560 2019-03-05  Tom Tromey  <tromey@adacore.com>
6561
6562         * target.c (the_dummy_target): Move later.  Change type to
6563         "dummy_target".
6564         (initialize_targets): Don't initialize the_dummy_target.
6565
6566 2019-03-05  Tom Tromey  <tromey@adacore.com>
6567
6568         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6569         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6570
6571 2019-03-05  Tom Tromey  <tromey@adacore.com>
6572
6573         * windows-nat.c (windows_nat_target::attach)
6574         (windows_nat_target::detach): Don't call gdb_flush.
6575         * valprint.c (generic_val_print, val_print, val_print_string):
6576         Don't call gdb_flush.
6577         * utils.c (defaulted_query): Don't call gdb_flush.
6578         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6579         * target.c (target_announce_detach): Don't call gdb_flush.
6580         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6581         * remote.c (extended_remote_target::attach): Don't call
6582         gdb_flush.
6583         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6584         * printcmd.c (do_examine): Don't call gdb_flush.
6585         (info_display_command): Don't call gdb_flush.
6586         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6587         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6588         * memattr.c (info_mem_command): Don't call gdb_flush.
6589         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6590         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6591         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6592         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6593         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6594         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6595         (gnu_nat_target::detach): Don't call gdb_flush.
6596         * f-valprint.c (f_val_print): Don't call gdb_flush.
6597         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6598         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6599         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6600         gdb_flush.
6601         * c-valprint.c (c_val_print): Don't call gdb_flush.
6602         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6603
6604 2019-03-05  Tom Tromey  <tromey@adacore.com>
6605
6606         * varobj.c (update_dynamic_varobj_children): Update.
6607         (install_default_visualizer): Use reset, not release.
6608         * value.c (set_internalvar): Update.
6609         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6610         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6611         ATTRIBUTE_UNUSED_RESULT.
6612
6613 2019-03-05  Tom Tromey  <tromey@adacore.com>
6614
6615         * remote.c (class scoped_remote_fd) <release>: Add
6616         ATTRIBUTE_UNUSED_RESULT.
6617
6618 2019-03-05  Tom Tromey  <tromey@adacore.com>
6619
6620         * macroexp.c (struct macro_buffer) <release>: Add
6621         ATTRIBUTE_UNUSED_RESULT.
6622
6623 2019-03-05  Tom Tromey  <tromey@adacore.com>
6624
6625         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6626         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6627         ATTRIBUTE_UNUSED_RESULT.
6628
6629 2019-03-05  Tom Tromey  <tromey@adacore.com>
6630
6631         * common/scoped_fd.h (class scoped_fd) <release>: Add
6632         ATTRIBUTE_UNUSED_RESULT.
6633
6634 2019-03-05  Tom Tromey  <tromey@adacore.com>
6635
6636         * parser-defs.h (struct parser_state) <release>: Add
6637         ATTRIBUTE_UNUSED_RESULT.
6638
6639 2019-03-05  Tom Tromey  <tromey@adacore.com>
6640
6641         * utils.h (class gdb_argv) <release>: Add
6642         ATTRIBUTE_UNUSED_RESULT.
6643         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6644
6645 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6646
6647         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6648         for-loop range, to avoid compiler warnings.
6649
6650         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6651         avoid compiler warnings about unused variables.
6652
6653         * NEWS: Mention end of support for native debugging on MS-Windows
6654         before XP.
6655
6656         PR gdb/24292
6657         * common/netstuff.c:
6658         * gdbserver/gdbreplay.c
6659         * gdbserver/remote-utils.c:
6660         * ser-tcp.c:
6661         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6662         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6663         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6664         'getaddrinfo' and 'freeaddrinfo' were not available before
6665         Windows XP, and mingw.org's MinGW headers by default define
6666         _WIN32_WINNT to 0x500.
6667
6668 2019-03-01  Gary Benson <gbenson@redhat.com>
6669
6670         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6671
6672 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6673             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6674
6675         PR gdb/8527
6676         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6677         set_sigint_trap, clear_sigint_trap.
6678
6679 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6680
6681         * target.c (target_detach): Clear the regcache and the
6682         frame cache.
6683
6684 2019-02-27  Pedro Alves  <palves@redhat.com>
6685
6686         * utils.c (set_screen_size): When we cap the height/width sizes,
6687         tweak the corresponding command variable to show "unlimited":
6688
6689 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6690             Pedro Alves  <palves@redhat.com>
6691
6692         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6693         before calling rl_set_screen_size.
6694
6695 2019-02-27  Tom Tromey  <tromey@adacore.com>
6696
6697         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6698         define.
6699         * python/py-value.c: Remove Python 2.4 workaround.
6700         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6701         workaround.
6702         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6703         Python 2.4 workaround.
6704         * python/python-internal.h: Remove Python 2.4 comment.
6705         (Py_ssize_t): Don't define.
6706         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6707         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6708         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6709         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6710         * python/python.c (do_start_initialization): Remove Python 2.4
6711         workaround.
6712         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6713         (print_children): Remove Python 2.4 workaround.
6714         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6715         workaround.
6716         (CHARBUFFERPROC_NAME): Remove.
6717         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6718         Python 2.4 workaround.
6719
6720 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6721
6722         * NEWS: Note minimum Python version.
6723
6724 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6725
6726         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6727         code from these functions.  Remove corresponding ifdefs.  Use
6728         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6729         Remove gotos and target of gotos.
6730         (infpy_search_memory): Likewise.
6731
6732 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6733
6734         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6735         (hppa_gdbarch_init): Don't register deleted functions with
6736         gdbarch.
6737
6738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6741         (h8300_unwind_sp): Delete.
6742         (h8300_dummy_id): Delete.
6743         (h8300_gdbarch_init): Don't register deleted functions with
6744         gdbarch.
6745
6746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6747
6748         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6749         (ft32_unwind_pc): Delete.
6750         (ft32_unwind_sp): Delete.
6751         (ft32_gdbarch_init): Don't register deleted functions with
6752         gdbarch.
6753
6754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6755
6756         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6757         (frv_unwind_pc): Delete.
6758         (frv_unwind_sp): Delete.
6759         (frv_gdbarch_init): Don't register deleted functions with
6760         gdbarch.
6761
6762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6763
6764         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6765         (riscv_unwind_pc): Delete.
6766         (riscv_unwind_sp): Delete.
6767         (riscv_gdbarch_init): Don't register deleted functions with
6768         gdbarch.
6769
6770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6771
6772         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6773         (csky_unwind_pc): Delete.
6774         (csky_unwind_sp): Delete.
6775         (csky_gdbarch_init): Don't register deleted functions with
6776         gdbarch.
6777
6778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6779
6780         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6781         (cris_unwind_pc): Delete.
6782         (cris_unwind_sp): Delete.
6783         (cris_gdbarch_init): Don't register deleted functions with
6784         gdbarch.
6785
6786 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6787
6788         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6789         (bfin_unwind_pc): Delete.
6790         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6791
6792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6793
6794         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6795         (arm_unwind_pc): Delete.
6796         (arm_unwind_sp): Delete.
6797         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6798
6799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6800
6801         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6802         (arc_unwind_pc): Delete.
6803         (arc_unwind_sp): Delete.
6804         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6805
6806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6807
6808         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6809         (alpha_unwind_pc): Delete.
6810         (alpha_gdbarch_init): Don't register deleted functions with
6811         gdbarch.
6812
6813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6814
6815         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6816         (aarch64_unwind_pc): Delete.
6817         (aarch64_unwind_sp): Delete.
6818         (aarch64_gdbarch_init): Don't register deleted functions with
6819         gdbarch.
6820
6821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6822
6823         * gdbtypes.c (type_align): Don't consider static members when
6824         computing structure alignment.
6825
6826 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6827
6828         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6829         return 0 for other types.
6830         * arch-utils.c (default_type_align): Always return 0.
6831         * gdbarch.h: Regenerate.
6832         * gdbarch.sh (type_align): Extend comment.
6833         * gdbtypes.c (type_align): Add additional comments, always call
6834         gdbarch_type_align before applying the default rules.
6835         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6836         generic code will then apply a suitable default.
6837         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6838         types, return 0 for other types.
6839
6840 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6841
6842         * NEWS: Create a new section for the next release branch.
6843         Rename the section of the current branch, now that it has
6844         been cut.
6845
6846 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6847
6848         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6849         * version.in: Bump version to 8.3.50.DATE-git.
6850
6851 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6852
6853         * aix-thread.c (ptid_cmp): Remove unused variable.
6854         (get_signaled_thread): Likewise.
6855         (store_regs_user_thread): Likewise.
6856         (store_regs_kernel_thread): Likewise.
6857         (fetch_regs_kernel_thread): Remove shadowed variable.
6858
6859 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6860
6861         * features/riscv/32bit-cpu.xml: Add register numbers.
6862         * features/riscv/32bit-fpu.c: Regenerate.
6863         * features/riscv/32bit-fpu.xml: Add register numbers.
6864         * features/riscv/64bit-cpu.xml: Add register numbers.
6865         * features/riscv/64bit-fpu.c: Regenerate.
6866         * features/riscv/64bit-fpu.xml: Add register numbers.
6867
6868 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6869
6870         * NEWS: Mention two argument form of gdb.Value constructor.
6871         * python/py-value.c (convert_buffer_and_type_to_value): New
6872         function.
6873         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6874         Add support for handling an optional second argument.  Call
6875         convert_buffer_and_type_to_value as appropriate.
6876         * python/python-internal.h (Py_buffer_deleter): New struct.
6877         (Py_buffer_up): New typedef.
6878
6879 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6880
6881         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6882         instead of releasing ownership.
6883
6884 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6885
6886         * dwarf2read.c (open_and_init_dwp_file): Call
6887         elf_numsections instead of bfd_count_sections to initialize
6888         dwp_file->num_sections.
6889
6890 2019-02-25  Tom Tromey  <tromey@adacore.com>
6891
6892         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6893
6894 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6895
6896         * gcore.in: Add '--readnever' option when invoking GDB.
6897
6898 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6899
6900         * MAINTAINERS: Update my email address.
6901
6902 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6903
6904         * build-id.c (build_id_to_debug_bfd_1): New function.
6905         (build_id_to_debug_bfd): Look for separate debug file in
6906         sysroot.
6907
6908 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6909
6910         * gdbarch.sh: Update the copyright year range that is placed into
6911         generated files.
6912
6913 2019-02-22  Keith Seitz  <keiths@redhat.com>
6914
6915         PR symtab/23853
6916         * linespec.c (create_sals_line_offset): Search for the default
6917         symtab's filename instead of its fullname.
6918
6919 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6920
6921         * NEWS: Update style defaults.
6922
6923 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6924
6925         * main.c (captured_main_1): Disable styling in batch mode.
6926
6927 2019-02-20  Tom Tromey  <tom@tromey.com>
6928
6929         * symtab.c (symtab_symbol_info): Fix typos.
6930
6931 2019-02-20  Tom Tromey  <tromey@adacore.com>
6932
6933         * findcmd.c (_initialize_mem_search): Use upper case for
6934         metasyntactic variables.
6935
6936 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6937
6938         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6939         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6940
6941 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6942
6943         * top.h (source_file_name): Change to std::string.
6944         * top.c (source_file_name): Likewise.
6945         (command_line_input): Adjust.
6946         * cli/cli-script.c (script_from_file): Adjust.
6947
6948 2019-02-19  Tom Tromey  <tromey@adacore.com>
6949
6950         * ravenscar-thread.c
6951         (ravenscar_thread_target::update_thread_list): Don't call
6952         ada_build_task_list.
6953         * ada-lang.h (ada_build_task_list): Don't declare.
6954         * ada-tasks.c (struct ada_tasks_inferior_data)
6955         <task_list_valid_p>: Now bool.
6956         (read_known_tasks, ada_task_list_changed)
6957         (ada_tasks_invalidate_inferior_data): Update.
6958         (read_known_tasks_array): Return bool.
6959         (read_known_tasks_list): Likewise.
6960         (read_known_tasks): Return void.
6961         (ada_build_task_list): Now static.
6962
6963 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6964
6965         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6966         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6967
6968 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6969
6970         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6971         variant for ada_tasks_pspace_data_handle and
6972         ada_tasks_inferior_data_handle.
6973         (ada_tasks_pspace_data_cleanup): New function.
6974         (ada_tasks_inferior_data_cleanup): New function.
6975
6976 2019-02-17  Tom Tromey  <tom@tromey.com>
6977
6978         * macrotab.h (macro_source_fullname): Return a std::string.
6979         * macrotab.c (macro_include, check_for_redefinition)
6980         (macro_undef, macro_lookup_definition, foreach_macro)
6981         (foreach_macro_in_scope): Update.
6982         (macro_source_fullname): Return a std::string.
6983         * macrocmd.c (show_pp_source_pos): Update.
6984
6985 2019-02-17  Tom Tromey  <tom@tromey.com>
6986
6987         * macrocmd.c (show_pp_source_pos): Style the file names.
6988
6989 2019-02-17  Tom Tromey  <tom@tromey.com>
6990
6991         PR tui/24197:
6992         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6993
6994 2019-02-17  Tom Tromey  <tom@tromey.com>
6995
6996         * ada-lang.c (user_select_syms): Use filtered printing.
6997         * utils.c (wrap_style): New global.
6998         (desired_style): Remove.
6999         (emit_style_escape): Add stream parameter.
7000         (set_output_style, reset_terminal_style, prompt_for_continue):
7001         Update.
7002         (flush_wrap_buffer): Only flush gdb_stdout.
7003         (wrap_here): Set wrap_style.
7004         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7005         treat escape sequences as a character.  Change when wrap buffer is
7006         flushed.
7007         (fputs_styled): Do not set the output style when the default is
7008         requested.
7009         * ui-style.h (struct ui_file_style) <is_default>: New method.
7010         * source.c (print_source_lines_base): Emit escape sequences in one
7011         piece.
7012
7013 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7014
7015         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7016         integers and enumeration types.
7017
7018 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7019
7020         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7021         instead of lookup_symbol_in_language
7022         (do_exact_match): New function.
7023         (ada_get_symbol_name_matcher): Return do_exact_match when
7024         doing a verbatim match.
7025
7026 2019-02-15  Tom Tromey  <tromey@adacore.com>
7027
7028         * ravenscar-thread.c (ravenscar_thread_target::resume)
7029         (ravenscar_thread_target::wait): Special case wildcard requests.
7030
7031 2019-02-15  Tom Tromey  <tromey@adacore.com>
7032
7033         * ravenscar-thread.c (base_ptid): Remove.
7034         (struct ravenscar_thread_target) <close>: New method.
7035         <m_base_ptid>: New member.
7036         <update_inferior_ptid, active_task, task_is_currently_active,
7037         runtime_initialized>: Declare methods.
7038         <ravenscar_thread_target>: Add constructor.
7039         (ravenscar_thread_target::task_is_currently_active)
7040         (ravenscar_thread_target::update_inferior_ptid)
7041         (ravenscar_runtime_initialized): Rename.  Now methods.
7042         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7043         (ravenscar_thread_target::update_thread_list): Update.
7044         (ravenscar_thread_target::active_task): Now method.
7045         (ravenscar_thread_target::store_registers)
7046         (ravenscar_thread_target::prepare_to_store)
7047         (ravenscar_thread_target::prepare_to_store)
7048         (ravenscar_thread_target::mourn_inferior): Update.
7049         (ravenscar_inferior_created): Use "new" to create target.
7050         (ravenscar_thread_target::get_ada_task_ptid): Update.
7051         (_initialize_ravenscar): Don't initialize base_ptid.
7052         (ravenscar_ops): Remove global.
7053
7054 2019-02-15  Tom Tromey  <tromey@adacore.com>
7055
7056         * target.h (push_target): Declare new overload.
7057         * target.c (push_target): New overload, taking an rvalue reference.
7058         * remote.c (remote_target::open_1): Use push_target overload.
7059         * corelow.c (core_target_open): Use push_target overload.
7060
7061 2019-02-15  Tom Tromey  <tromey@adacore.com>
7062
7063         * ravenscar-thread.c (is_ravenscar_task)
7064         (ravenscar_task_is_currently_active): Return bool.
7065         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7066         (_initialize_ravenscar): Remove "(void)".
7067         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7068         Return bool.
7069
7070 2019-02-15  Tom Tromey  <tromey@adacore.com>
7071
7072         * ravenscar-thread.c (ravenscar_runtime_initializer)
7073         (has_ravenscar_runtime, get_running_thread_id)
7074         (ravenscar_thread_target::resume): Fix indentation.
7075
7076 2019-02-15  Tom Tromey  <tromey@adacore.com>
7077
7078         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7079         from ravenscar_arch_ops.
7080         (sparc_ravenscar_ops::fetch_registers)
7081         (sparc_ravenscar_ops::store_registers): Now methods.
7082         (sparc_ravenscar_prepare_to_store): Remove.
7083         (sparc_ravenscar_ops): Redefine.
7084         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7085         methods and destructor.  Remove members.
7086         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7087         (ravenscar_thread_target::store_registers)
7088         (ravenscar_thread_target::prepare_to_store): Update.
7089         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7090         Remove.
7091         (struct ppc_ravenscar_powerpc_ops): Derive from
7092         ravenscar_arch_ops.
7093         (ppc_ravenscar_powerpc_ops::fetch_registers)
7094         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7095         (ppc_ravenscar_powerpc_ops): Redefine.
7096         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7097         (ppc_ravenscar_e500_ops::fetch_registers)
7098         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7099         (ppc_ravenscar_e500_ops): Redefine.
7100         * aarch64-ravenscar-thread.c
7101         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7102         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7103         (aarch64_ravenscar_fetch_registers)
7104         (aarch64_ravenscar_store_registers): Now methods.
7105         (aarch64_ravenscar_ops): Redefine.
7106
7107 2019-02-15  Tom Tromey  <tromey@adacore.com>
7108
7109         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7110         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7111         (ravenscar_thread_target::stopped_by_watchpoint)
7112         (ravenscar_thread_target::stopped_data_address)
7113         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7114
7115 2019-02-15  Tom Tromey  <tromey@adacore.com>
7116
7117         * ravenscar-thread.c: Fix some typos.
7118
7119 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7120             Tom Tromey  <tromey@adacore.com>
7121
7122         * ada-lang.c (ada_exception_sal): Change addr_string to a
7123         std::string.
7124         (create_ada_exception_catchpoint): Update.
7125
7126 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7127             Tom Tromey  <tromey@adacore.com>
7128
7129         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7130         (bp_location_ops): Remove.
7131         (base_breakpoint_allocate_location): Update.
7132         (free_bp_location): Update.
7133         * ada-lang.c (class ada_catchpoint_location)
7134         <ada_catchpoint_location>: Remove ops parameter.
7135         (ada_catchpoint_location_dtor): Remove.
7136         (ada_catchpoint_location_ops): Remove.
7137         (allocate_location_exception): Update.
7138         * breakpoint.h (struct bp_location_ops): Remove.
7139         (class bp_location) <bp_location>: Remove bp_location_ops
7140         parameter.
7141         <~bp_location>: Add destructor.
7142         <ops>: Remove.
7143
7144 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7145             Pedro Alves  <palves@redhat.com>
7146
7147         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7148         'PATH_MAX'.
7149
7150 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7151             Samuel Thibault  <samuel.thibault@gnu.org>
7152             Thomas Schwinge  <thomas@codesourcery.com>
7153
7154         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7155         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7156
7157 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7158
7159         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7160         (check_empty): Use "const char *".
7161
7162         * gnu-nat.c (gnu_nat_target::detach): Instead of
7163         'detach_inferior (pid)' call
7164         'detach_inferior (find_inferior_pid (pid))'.
7165
7166         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7167         'nat/fork-inferior.o'.
7168         * gnu-nat.c: #include "nat/fork-inferior.h".
7169
7170         * gnu-nat.c (gnu_nat_target::detach): Instead of
7171         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7172         * gnu-nat.h: #include "inf-child.h".
7173         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7174         'i386_gnu_nat_target::fetch_registers'.
7175         (gnu_store_registers): Rename/move to
7176         'i386_gnu_nat_target::store_registers'.
7177
7178         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7179         * gnu-nat.h (mach_thread_info): New function.
7180         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7181
7182         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7183
7184 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7185
7186         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7187
7188 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7189
7190         * windows-nat.c (windows_add_thread): Add new parameter
7191         "main_thread_p" with default value set to false.  Update
7192         function documentation as well as all callers.
7193         (windows_delete_thread): Likewise.
7194         (fake_create_process): Update call to windows_add_thread.
7195         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7196         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7197         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7198         call to windows_delete_thread.
7199
7200 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7201
7202         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7203
7204 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7205
7206         * symfile.c (find_separate_debug_file): Use canonical path of
7207         sysroot with child_path instead of gdb_sysroot if it is valid.
7208
7209 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7210
7211         * symfile.c (find_separate_debug_file): Use child_path to
7212         determine if an object file is under a sysroot.
7213
7214 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7215
7216         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7217         unittests/child-path-selftests.c.
7218         * common/pathstuff.c (child_path): New function.
7219         * common/pathstuff.h (child_path): New prototype.
7220         * unittests/child-path-selftests.c: New file.
7221
7222 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7223
7224         * symfile.c (find_separate_debug_file): Look for separate debug
7225         files in debug directories under the sysroot.
7226
7227 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7228
7229         * symtab.h (struct minimal_symbol data_p): New const method.
7230         (struct minimal_symbol text_p): Likewise.
7231         * symtab.c (output_source_filename): Use file name style
7232         to print file name.
7233         (print_symbol_info): Likewise.
7234         (print_msymbol_info): Use address style to print addresses.
7235         Use function name style to print executable text symbols.
7236         (expand_symtab_containing_pc): Use data_p.
7237         (find_pc_sect_compunit_symtab): Likewise.
7238
7239 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7240
7241         * breakpoint.c (describe_other_breakpoints): Use address style
7242         to print addresses.
7243         (say_where): Likewise.
7244
7245 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7246
7247         * ada-typeprint.c (print_func_type): Print function name
7248         style to print function name.
7249         * c-typeprint.c (c_print_type_1): Likewise.
7250
7251 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7252
7253         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7254         for execve.
7255
7256 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7257
7258         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7259         type_stack.
7260
7261 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7262
7263         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7264         TYPE_CODE_REF types.
7265
7266 2019-02-08  Jim Wilson  <jimw@sifive.com>
7267
7268         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7269         (riscv_linux_fregset): New.
7270         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7271
7272 2019-02-07  Tom Tromey  <tom@tromey.com>
7273
7274         * thread.c (thread_cancel_execution_command): Update.
7275         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7276         methods.
7277         (struct thread_fsm_ops): Remove.
7278         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7279         (thread_fsm_should_stop, thread_fsm_return_value)
7280         (thread_fsm_set_finished, thread_fsm_finished_p)
7281         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7282         Don't declare.
7283         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7284         * infrun.c (clear_proceed_status_thread)
7285         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7286         (print_stop_event): Update.
7287         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7288         Add constructor.
7289         (step_command_fsm_ops): Remove.
7290         (new_step_command_fsm): Remove.
7291         (step_1): Update.
7292         (step_command_fsm::should_stop): Rename from
7293         step_command_fsm_should_stop.
7294         (step_command_fsm::clean_up): Rename from
7295         step_command_fsm_clean_up.
7296         (step_command_fsm::do_async_reply_reason): Rename from
7297         step_command_fsm_async_reply_reason.
7298         (struct until_next_fsm): Inherit from thread_fsm.  Add
7299         constructor.
7300         (until_next_fsm_ops): Remove.
7301         (new_until_next_fsm): Remove.
7302         (until_next_fsm::should_stop): Rename from
7303         until_next_fsm_should_stop.
7304         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7305         (until_next_fsm::do_async_reply_reason): Rename from
7306         until_next_fsm_async_reply_reason.
7307         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7308         constructor.  Change type of breakpoint.
7309         (finish_command_fsm_ops): Remove.
7310         (new_finish_command_fsm): Remove.
7311         (finish_command_fsm::should_stop): Rename from
7312         finish_command_fsm_should_stop.
7313         (finish_command_fsm::clean_up): Rename from
7314         finish_command_fsm_clean_up.
7315         (finish_command_fsm::return_value): Rename from
7316         finish_command_fsm_return_value.
7317         (finish_command_fsm::do_async_reply_reason): Rename from
7318         finish_command_fsm_async_reply_reason.
7319         (finish_command): Update.
7320         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7321         Add constructor.
7322         (call_thread_fsm_ops): Remove.
7323         (call_thread_fsm::call_thread_fsm): Rename from
7324         new_call_thread_fsm.
7325         (call_thread_fsm::should_stop): Rename from
7326         call_thread_fsm_should_stop.
7327         (call_thread_fsm::should_notify_stop): Rename from
7328         call_thread_fsm_should_notify_stop.
7329         (run_inferior_call, call_function_by_hand_dummy): Update.
7330         * cli/cli-interp.c (should_print_stop_to_console): Update.
7331         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7332         Add constructor.  Change type of location_breakpoint,
7333         caller_breakpoint.
7334         (until_break_fsm_ops): Remove.
7335         (new_until_break_fsm): Remove.
7336         (until_break_fsm::should_stop): Rename from
7337         until_break_fsm_should_stop.
7338         (until_break_fsm::clean_up): Rename from
7339         until_break_fsm_clean_up.
7340         (until_break_fsm::do_async_reply_reason): Rename from
7341         until_break_fsm_async_reply_reason.
7342         (until_break_command): Update.
7343         * thread-fsm.c: Remove.
7344         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7345
7346 2019-02-07  Tom Tromey  <tom@tromey.com>
7347
7348         * yy-remap.h: Add include guard.
7349         * xtensa-tdep.h: Add include guard.
7350         * xcoffread.h: Rename include guard.
7351         * varobj-iter.h: Add include guard.
7352         * tui/tui.h: Rename include guard.
7353         * tui/tui-winsource.h: Rename include guard.
7354         * tui/tui-wingeneral.h: Rename include guard.
7355         * tui/tui-windata.h: Rename include guard.
7356         * tui/tui-win.h: Rename include guard.
7357         * tui/tui-stack.h: Rename include guard.
7358         * tui/tui-source.h: Rename include guard.
7359         * tui/tui-regs.h: Rename include guard.
7360         * tui/tui-out.h: Rename include guard.
7361         * tui/tui-layout.h: Rename include guard.
7362         * tui/tui-io.h: Rename include guard.
7363         * tui/tui-hooks.h: Rename include guard.
7364         * tui/tui-file.h: Rename include guard.
7365         * tui/tui-disasm.h: Rename include guard.
7366         * tui/tui-data.h: Rename include guard.
7367         * tui/tui-command.h: Rename include guard.
7368         * tic6x-tdep.h: Add include guard.
7369         * target/waitstatus.h: Rename include guard.
7370         * target/wait.h: Rename include guard.
7371         * target/target.h: Rename include guard.
7372         * target/resume.h: Rename include guard.
7373         * target-float.h: Rename include guard.
7374         * stabsread.h: Add include guard.
7375         * rs6000-tdep.h: Add include guard.
7376         * riscv-fbsd-tdep.h: Add include guard.
7377         * regformats/regdef.h: Rename include guard.
7378         * record.h: Rename include guard.
7379         * python/python.h: Rename include guard.
7380         * python/python-internal.h: Rename include guard.
7381         * python/py-stopevent.h: Rename include guard.
7382         * python/py-ref.h: Rename include guard.
7383         * python/py-record.h: Rename include guard.
7384         * python/py-record-full.h: Rename include guard.
7385         * python/py-record-btrace.h: Rename include guard.
7386         * python/py-instruction.h: Rename include guard.
7387         * python/py-events.h: Rename include guard.
7388         * python/py-event.h: Rename include guard.
7389         * procfs.h: Add include guard.
7390         * proc-utils.h: Add include guard.
7391         * p-lang.h: Add include guard.
7392         * or1k-tdep.h: Rename include guard.
7393         * observable.h: Rename include guard.
7394         * nto-tdep.h: Rename include guard.
7395         * nat/x86-linux.h: Rename include guard.
7396         * nat/x86-linux-dregs.h: Rename include guard.
7397         * nat/x86-gcc-cpuid.h: Add include guard.
7398         * nat/x86-dregs.h: Rename include guard.
7399         * nat/x86-cpuid.h: Rename include guard.
7400         * nat/ppc-linux.h: Rename include guard.
7401         * nat/mips-linux-watch.h: Rename include guard.
7402         * nat/linux-waitpid.h: Rename include guard.
7403         * nat/linux-ptrace.h: Rename include guard.
7404         * nat/linux-procfs.h: Rename include guard.
7405         * nat/linux-osdata.h: Rename include guard.
7406         * nat/linux-nat.h: Rename include guard.
7407         * nat/linux-namespaces.h: Rename include guard.
7408         * nat/linux-btrace.h: Rename include guard.
7409         * nat/glibc_thread_db.h: Rename include guard.
7410         * nat/gdb_thread_db.h: Rename include guard.
7411         * nat/gdb_ptrace.h: Rename include guard.
7412         * nat/fork-inferior.h: Rename include guard.
7413         * nat/amd64-linux-siginfo.h: Rename include guard.
7414         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7415         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7416         * nat/aarch64-linux.h: Rename include guard.
7417         * nat/aarch64-linux-hw-point.h: Rename include guard.
7418         * mn10300-tdep.h: Add include guard.
7419         * mips-linux-tdep.h: Add include guard.
7420         * mi/mi-parse.h: Rename include guard.
7421         * mi/mi-out.h: Rename include guard.
7422         * mi/mi-main.h: Rename include guard.
7423         * mi/mi-interp.h: Rename include guard.
7424         * mi/mi-getopt.h: Rename include guard.
7425         * mi/mi-console.h: Rename include guard.
7426         * mi/mi-common.h: Rename include guard.
7427         * mi/mi-cmds.h: Rename include guard.
7428         * mi/mi-cmd-break.h: Rename include guard.
7429         * m2-lang.h: Add include guard.
7430         * location.h: Rename include guard.
7431         * linux-record.h: Rename include guard.
7432         * linux-nat.h: Add include guard.
7433         * linux-fork.h: Add include guard.
7434         * i386-darwin-tdep.h: Rename include guard.
7435         * hppa-linux-offsets.h: Add include guard.
7436         * guile/guile.h: Rename include guard.
7437         * guile/guile-internal.h: Rename include guard.
7438         * gnu-nat.h: Rename include guard.
7439         * gdb-stabs.h: Rename include guard.
7440         * frv-tdep.h: Add include guard.
7441         * f-lang.h: Add include guard.
7442         * event-loop.h: Add include guard.
7443         * darwin-nat.h: Rename include guard.
7444         * cp-abi.h: Rename include guard.
7445         * config/sparc/nm-sol2.h: Rename include guard.
7446         * config/nm-nto.h: Rename include guard.
7447         * config/nm-linux.h: Add include guard.
7448         * config/i386/nm-i386gnu.h: Rename include guard.
7449         * config/djgpp/nl_types.h: Rename include guard.
7450         * config/djgpp/langinfo.h: Rename include guard.
7451         * compile/gcc-cp-plugin.h: Add include guard.
7452         * compile/gcc-c-plugin.h: Add include guard.
7453         * compile/compile.h: Rename include guard.
7454         * compile/compile-object-run.h: Rename include guard.
7455         * compile/compile-object-load.h: Rename include guard.
7456         * compile/compile-internal.h: Rename include guard.
7457         * compile/compile-cplus.h: Rename include guard.
7458         * compile/compile-c.h: Rename include guard.
7459         * common/xml-utils.h: Rename include guard.
7460         * common/x86-xstate.h: Rename include guard.
7461         * common/version.h: Rename include guard.
7462         * common/vec.h: Rename include guard.
7463         * common/tdesc.h: Rename include guard.
7464         * common/selftest.h: Rename include guard.
7465         * common/scoped_restore.h: Rename include guard.
7466         * common/scoped_mmap.h: Rename include guard.
7467         * common/scoped_fd.h: Rename include guard.
7468         * common/safe-iterator.h: Rename include guard.
7469         * common/run-time-clock.h: Rename include guard.
7470         * common/refcounted-object.h: Rename include guard.
7471         * common/queue.h: Rename include guard.
7472         * common/ptid.h: Rename include guard.
7473         * common/print-utils.h: Rename include guard.
7474         * common/preprocessor.h: Rename include guard.
7475         * common/pathstuff.h: Rename include guard.
7476         * common/observable.h: Rename include guard.
7477         * common/netstuff.h: Rename include guard.
7478         * common/job-control.h: Rename include guard.
7479         * common/host-defs.h: Rename include guard.
7480         * common/gdb_wait.h: Rename include guard.
7481         * common/gdb_vecs.h: Rename include guard.
7482         * common/gdb_unlinker.h: Rename include guard.
7483         * common/gdb_unique_ptr.h: Rename include guard.
7484         * common/gdb_tilde_expand.h: Rename include guard.
7485         * common/gdb_sys_time.h: Rename include guard.
7486         * common/gdb_string_view.h: Rename include guard.
7487         * common/gdb_splay_tree.h: Rename include guard.
7488         * common/gdb_setjmp.h: Rename include guard.
7489         * common/gdb_ref_ptr.h: Rename include guard.
7490         * common/gdb_optional.h: Rename include guard.
7491         * common/gdb_locale.h: Rename include guard.
7492         * common/gdb_assert.h: Rename include guard.
7493         * common/filtered-iterator.h: Rename include guard.
7494         * common/filestuff.h: Rename include guard.
7495         * common/fileio.h: Rename include guard.
7496         * common/environ.h: Rename include guard.
7497         * common/common-utils.h: Rename include guard.
7498         * common/common-types.h: Rename include guard.
7499         * common/common-regcache.h: Rename include guard.
7500         * common/common-inferior.h: Rename include guard.
7501         * common/common-gdbthread.h: Rename include guard.
7502         * common/common-exceptions.h: Rename include guard.
7503         * common/common-defs.h: Rename include guard.
7504         * common/common-debug.h: Rename include guard.
7505         * common/cleanups.h: Rename include guard.
7506         * common/buffer.h: Rename include guard.
7507         * common/btrace-common.h: Rename include guard.
7508         * common/break-common.h: Rename include guard.
7509         * cli/cli-utils.h: Rename include guard.
7510         * cli/cli-style.h: Rename include guard.
7511         * cli/cli-setshow.h: Rename include guard.
7512         * cli/cli-script.h: Rename include guard.
7513         * cli/cli-interp.h: Rename include guard.
7514         * cli/cli-decode.h: Rename include guard.
7515         * cli/cli-cmds.h: Rename include guard.
7516         * charset-list.h: Add include guard.
7517         * buildsym-legacy.h: Rename include guard.
7518         * bfin-tdep.h: Add include guard.
7519         * ax.h: Rename include guard.
7520         * arm-linux-tdep.h: Add include guard.
7521         * arm-fbsd-tdep.h: Add include guard.
7522         * arch/xtensa.h: Rename include guard.
7523         * arch/tic6x.h: Add include guard.
7524         * arch/i386.h: Add include guard.
7525         * arch/arm.h: Rename include guard.
7526         * arch/arm-linux.h: Rename include guard.
7527         * arch/arm-get-next-pcs.h: Rename include guard.
7528         * arch/amd64.h: Add include guard.
7529         * arch/aarch64-insn.h: Rename include guard.
7530         * arch-utils.h: Rename include guard.
7531         * annotate.h: Add include guard.
7532         * amd64-darwin-tdep.h: Rename include guard.
7533         * aarch64-linux-tdep.h: Add include guard.
7534         * aarch64-fbsd-tdep.h: Add include guard.
7535         * aarch32-linux-nat.h: Add include guard.
7536
7537 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7538
7539         * macrotab.c (macro_define_internal): New function that
7540         factorizes macro_define_object_internal and macro_define_function
7541         code.
7542         (macro_define_object_internal): Use macro_define_internal.
7543         (macro_define_function): Likewise.
7544
7545 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7546
7547         * macrocmd.c (extract_identifier): Return
7548         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7549         callers.
7550
7551 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7552
7553         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7554
7555 2019-02-05  Tom Tromey  <tom@tromey.com>
7556
7557         * target.c (target_stack::unpush): Move assertion earlier.
7558
7559 2019-01-30  Tom Tromey  <tom@tromey.com>
7560
7561         PR python/23615:
7562         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7563         (gdbpy_parse_and_eval): Likewise.
7564         * python/python-internal.h (gdbpy_allow_threads): New class.
7565
7566 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7567
7568         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7569         (aarch64_fbsd_fpregmap): Move earlier.
7570         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7571         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7572         instead of individual calls to trad_frame_set_reg_addr.
7573         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7574         earlier.
7575         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7576         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7577         instead of individual calls to trad_frame_set_reg_addr.
7578
7579 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7580
7581         * CONTRIBUTE: Replace contribution list with wiki link.
7582
7583 2019-01-25  Tom Tromey  <tom@tromey.com>
7584
7585         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7586
7587 2019-01-25  Tom Tromey  <tom@tromey.com>
7588
7589         * xtensa-linux-nat.c: Fix common/ includes.
7590         * xml-support.h: Fix common/ includes.
7591         * xml-support.c: Fix common/ includes.
7592         * x86-linux-nat.c: Fix common/ includes.
7593         * windows-nat.c: Fix common/ includes.
7594         * varobj.h: Fix common/ includes.
7595         * varobj.c: Fix common/ includes.
7596         * value.c: Fix common/ includes.
7597         * valops.c: Fix common/ includes.
7598         * utils.c: Fix common/ includes.
7599         * unittests/xml-utils-selftests.c: Fix common/ includes.
7600         * unittests/utils-selftests.c: Fix common/ includes.
7601         * unittests/unpack-selftests.c: Fix common/ includes.
7602         * unittests/tracepoint-selftests.c: Fix common/ includes.
7603         * unittests/style-selftests.c: Fix common/ includes.
7604         * unittests/string_view-selftests.c: Fix common/ includes.
7605         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7606         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7607         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7608         * unittests/rsp-low-selftests.c: Fix common/ includes.
7609         * unittests/parse-connection-spec-selftests.c: Fix common/
7610         includes.
7611         * unittests/optional-selftests.c: Fix common/ includes.
7612         * unittests/offset-type-selftests.c: Fix common/ includes.
7613         * unittests/observable-selftests.c: Fix common/ includes.
7614         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7615         * unittests/memrange-selftests.c: Fix common/ includes.
7616         * unittests/memory-map-selftests.c: Fix common/ includes.
7617         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7618         * unittests/function-view-selftests.c: Fix common/ includes.
7619         * unittests/environ-selftests.c: Fix common/ includes.
7620         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7621         * unittests/common-utils-selftests.c: Fix common/ includes.
7622         * unittests/cli-utils-selftests.c: Fix common/ includes.
7623         * unittests/array-view-selftests.c: Fix common/ includes.
7624         * ui-file.c: Fix common/ includes.
7625         * tui/tui-io.c: Fix common/ includes.
7626         * tracepoint.h: Fix common/ includes.
7627         * tracepoint.c: Fix common/ includes.
7628         * tracefile-tfile.c: Fix common/ includes.
7629         * top.h: Fix common/ includes.
7630         * top.c: Fix common/ includes.
7631         * thread.c: Fix common/ includes.
7632         * target/waitstatus.h: Fix common/ includes.
7633         * target/waitstatus.c: Fix common/ includes.
7634         * target.h: Fix common/ includes.
7635         * target.c: Fix common/ includes.
7636         * target-memory.c: Fix common/ includes.
7637         * target-descriptions.c: Fix common/ includes.
7638         * symtab.h: Fix common/ includes.
7639         * symfile.c: Fix common/ includes.
7640         * stap-probe.c: Fix common/ includes.
7641         * spu-linux-nat.c: Fix common/ includes.
7642         * sparc-nat.c: Fix common/ includes.
7643         * source.c: Fix common/ includes.
7644         * solib.c: Fix common/ includes.
7645         * solib-target.c: Fix common/ includes.
7646         * ser-unix.c: Fix common/ includes.
7647         * ser-tcp.c: Fix common/ includes.
7648         * ser-pipe.c: Fix common/ includes.
7649         * ser-base.c: Fix common/ includes.
7650         * selftest-arch.c: Fix common/ includes.
7651         * s12z-tdep.c: Fix common/ includes.
7652         * rust-exp.y: Fix common/ includes.
7653         * rs6000-aix-tdep.c: Fix common/ includes.
7654         * riscv-tdep.c: Fix common/ includes.
7655         * remote.c: Fix common/ includes.
7656         * remote-notif.h: Fix common/ includes.
7657         * remote-fileio.h: Fix common/ includes.
7658         * remote-fileio.c: Fix common/ includes.
7659         * regcache.h: Fix common/ includes.
7660         * regcache.c: Fix common/ includes.
7661         * record-btrace.c: Fix common/ includes.
7662         * python/python.c: Fix common/ includes.
7663         * python/py-type.c: Fix common/ includes.
7664         * python/py-inferior.c: Fix common/ includes.
7665         * progspace.h: Fix common/ includes.
7666         * producer.c: Fix common/ includes.
7667         * procfs.c: Fix common/ includes.
7668         * proc-api.c: Fix common/ includes.
7669         * printcmd.c: Fix common/ includes.
7670         * ppc-linux-nat.c: Fix common/ includes.
7671         * parser-defs.h: Fix common/ includes.
7672         * osdata.c: Fix common/ includes.
7673         * obsd-nat.c: Fix common/ includes.
7674         * nat/x86-linux.c: Fix common/ includes.
7675         * nat/x86-linux-dregs.c: Fix common/ includes.
7676         * nat/x86-dregs.h: Fix common/ includes.
7677         * nat/x86-dregs.c: Fix common/ includes.
7678         * nat/ppc-linux.c: Fix common/ includes.
7679         * nat/mips-linux-watch.h: Fix common/ includes.
7680         * nat/mips-linux-watch.c: Fix common/ includes.
7681         * nat/linux-waitpid.c: Fix common/ includes.
7682         * nat/linux-ptrace.h: Fix common/ includes.
7683         * nat/linux-ptrace.c: Fix common/ includes.
7684         * nat/linux-procfs.c: Fix common/ includes.
7685         * nat/linux-personality.c: Fix common/ includes.
7686         * nat/linux-osdata.c: Fix common/ includes.
7687         * nat/linux-namespaces.c: Fix common/ includes.
7688         * nat/linux-btrace.h: Fix common/ includes.
7689         * nat/linux-btrace.c: Fix common/ includes.
7690         * nat/fork-inferior.c: Fix common/ includes.
7691         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7692         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7693         * nat/aarch64-linux.c: Fix common/ includes.
7694         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7695         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7696         * namespace.h: Fix common/ includes.
7697         * mips-linux-tdep.c: Fix common/ includes.
7698         * minsyms.c: Fix common/ includes.
7699         * mi/mi-parse.h: Fix common/ includes.
7700         * mi/mi-main.c: Fix common/ includes.
7701         * mi/mi-cmd-env.c: Fix common/ includes.
7702         * memrange.h: Fix common/ includes.
7703         * memattr.c: Fix common/ includes.
7704         * maint.h: Fix common/ includes.
7705         * maint.c: Fix common/ includes.
7706         * main.c: Fix common/ includes.
7707         * machoread.c: Fix common/ includes.
7708         * location.c: Fix common/ includes.
7709         * linux-thread-db.c: Fix common/ includes.
7710         * linux-nat.c: Fix common/ includes.
7711         * linux-fork.c: Fix common/ includes.
7712         * inline-frame.c: Fix common/ includes.
7713         * infrun.c: Fix common/ includes.
7714         * inflow.c: Fix common/ includes.
7715         * inferior.h: Fix common/ includes.
7716         * inferior.c: Fix common/ includes.
7717         * infcmd.c: Fix common/ includes.
7718         * inf-ptrace.c: Fix common/ includes.
7719         * inf-child.c: Fix common/ includes.
7720         * ia64-linux-nat.c: Fix common/ includes.
7721         * i387-tdep.c: Fix common/ includes.
7722         * i386-tdep.c: Fix common/ includes.
7723         * i386-linux-tdep.c: Fix common/ includes.
7724         * i386-linux-nat.c: Fix common/ includes.
7725         * i386-go32-tdep.c: Fix common/ includes.
7726         * i386-fbsd-tdep.c: Fix common/ includes.
7727         * i386-fbsd-nat.c: Fix common/ includes.
7728         * guile/scm-type.c: Fix common/ includes.
7729         * guile/guile.c: Fix common/ includes.
7730         * go32-nat.c: Fix common/ includes.
7731         * gnu-nat.c: Fix common/ includes.
7732         * gdbthread.h: Fix common/ includes.
7733         * gdbarch-selftests.c: Fix common/ includes.
7734         * gdb_usleep.c: Fix common/ includes.
7735         * gdb_select.h: Fix common/ includes.
7736         * gdb_bfd.c: Fix common/ includes.
7737         * gcore.c: Fix common/ includes.
7738         * fork-child.c: Fix common/ includes.
7739         * findvar.c: Fix common/ includes.
7740         * fbsd-nat.c: Fix common/ includes.
7741         * event-top.c: Fix common/ includes.
7742         * event-loop.c: Fix common/ includes.
7743         * dwarf2read.c: Fix common/ includes.
7744         * dwarf2loc.c: Fix common/ includes.
7745         * dwarf2-frame.c: Fix common/ includes.
7746         * dwarf-index-cache.c: Fix common/ includes.
7747         * dtrace-probe.c: Fix common/ includes.
7748         * disasm-selftests.c: Fix common/ includes.
7749         * defs.h: Fix common/ includes.
7750         * csky-tdep.c: Fix common/ includes.
7751         * cp-valprint.c: Fix common/ includes.
7752         * cp-support.h: Fix common/ includes.
7753         * cp-support.c: Fix common/ includes.
7754         * corelow.c: Fix common/ includes.
7755         * completer.h: Fix common/ includes.
7756         * completer.c: Fix common/ includes.
7757         * compile/compile.c: Fix common/ includes.
7758         * compile/compile-loc2c.c: Fix common/ includes.
7759         * compile/compile-cplus-types.c: Fix common/ includes.
7760         * compile/compile-cplus-symbols.c: Fix common/ includes.
7761         * command.h: Fix common/ includes.
7762         * cli/cli-dump.c: Fix common/ includes.
7763         * cli/cli-cmds.c: Fix common/ includes.
7764         * charset.c: Fix common/ includes.
7765         * build-id.c: Fix common/ includes.
7766         * btrace.h: Fix common/ includes.
7767         * btrace.c: Fix common/ includes.
7768         * breakpoint.h: Fix common/ includes.
7769         * breakpoint.c: Fix common/ includes.
7770         * ax.h: 
7771         (enum agent_op): Fix common/ includes.
7772         * ax-general.c (struct aop_map): Fix common/ includes.
7773         * ax-gdb.c: Fix common/ includes.
7774         * auxv.c: Fix common/ includes.
7775         * auto-load.c: Fix common/ includes.
7776         * arm-tdep.c: Fix common/ includes.
7777         * arch/riscv.c: Fix common/ includes.
7778         * arch/ppc-linux-common.c: Fix common/ includes.
7779         * arch/i386.c: Fix common/ includes.
7780         * arch/arm.c: Fix common/ includes.
7781         * arch/arm-linux.c: Fix common/ includes.
7782         * arch/arm-get-next-pcs.c: Fix common/ includes.
7783         * arch/amd64.c: Fix common/ includes.
7784         * arch/aarch64.c: Fix common/ includes.
7785         * arch/aarch64-insn.c: Fix common/ includes.
7786         * arch-utils.c: Fix common/ includes.
7787         * amd64-windows-tdep.c: Fix common/ includes.
7788         * amd64-tdep.c: Fix common/ includes.
7789         * amd64-sol2-tdep.c: Fix common/ includes.
7790         * amd64-obsd-tdep.c: Fix common/ includes.
7791         * amd64-nbsd-tdep.c: Fix common/ includes.
7792         * amd64-linux-tdep.c: Fix common/ includes.
7793         * amd64-linux-nat.c: Fix common/ includes.
7794         * amd64-fbsd-tdep.c: Fix common/ includes.
7795         * amd64-fbsd-nat.c: Fix common/ includes.
7796         * amd64-dicos-tdep.c: Fix common/ includes.
7797         * amd64-darwin-tdep.c: Fix common/ includes.
7798         * agent.c: Fix common/ includes.
7799         * ada-lang.h: Fix common/ includes.
7800         * ada-lang.c: Fix common/ includes.
7801         * aarch64-tdep.c: Fix common/ includes.
7802
7803 2019-01-25  Tom Tromey  <tom@tromey.com>
7804
7805         * common/create-version.sh: Use common/version.h.
7806
7807 2019-01-24  Pedro Alves  <palves@redhat.com>
7808
7809         * infrun.c (signal_stop, signal_print, signal_program)
7810         (signal_catch, signal_pass): Now arrays instead of pointers.
7811         (update_signals_program_target, do_target_resume)
7812         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7813         * linux-nat.c (linux_nat_target::pass_signals)
7814         (linux_nat_target::create_inferior, linux_nat_target::attach):
7815         Adjust.
7816         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7817         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7818         * procfs.c (procfs_target::pass_signals): Adjust.
7819         * record-full.c (record_full_target::resume): Adjust.
7820         * remote.c (remote_target::pass_signals)
7821         (remote_target::program_signals): Adjust.
7822         * target-debug.h (target_debug_print_signals): Now takes a
7823         gdb::array_view as parameter.  Adjust.
7824         * target.h (target_ops) <pass_signals, program_signals>: Replace
7825         pointer and length parameters with gdb::array_view.
7826         (target_pass_signals, target_program_signals): Likewise.
7827         * target-delegates.c: Regenerate.
7828
7829 2019-01-24  Pedro Alves  <palves@redhat.com>
7830
7831         * common/forward-scope-exit.h
7832         (forward_scope_exit::forward_scope_exit): Pass arguments to
7833         m_bind_function directly, instead of creating a std::bind and
7834         copying that.
7835
7836 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7837
7838         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7839         for static members.
7840         (pass_in_v_vfp_candidate): Likewise.
7841
7842 2019-01-23  Tom Tromey  <tom@tromey.com>
7843             Pedro Alves  <palves@redhat.com>
7844
7845         * regcache.c (class regcache_invalidator): Remove.
7846         (regcache::raw_write): Use make_scope_exit.
7847
7848 2019-01-23  Tom Tromey  <tom@tromey.com>
7849
7850         * ui-out.h (class ui_out_emit_type): Update comment.
7851
7852 2019-01-23  Tom Tromey  <tom@tromey.com>
7853
7854         * infrun.c (fetch_inferior_event): Update comment.
7855
7856 2019-01-23  Tom Tromey  <tom@tromey.com>
7857             Pedro Alves  <palves@redhat.com>
7858
7859         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7860         parameter.
7861         (fetch_inferior_event): Use SCOPE_EXIT.
7862
7863
7864 2019-01-23  Tom Tromey  <tom@tromey.com>
7865             Pedro Alves  <palves@redhat.com>
7866
7867         * infrun.c (disable_thread_events): Delete.
7868         (stop_all_threads): Use SCOPE_EXIT.
7869
7870 2019-01-23  Tom Tromey  <tom@tromey.com>
7871             Pedro Alves  <palves@redhat.com>
7872
7873         * symfile.c: Include forward-scope-exit.h.
7874         (clear_symtab_users_cleanup): Replace forward declaration with
7875         a FORWARD_SCOPE_EXIT.
7876         (syms_from_objfile_1): Use the forward_scope_exit and
7877         gdb::optional instead of cleanup_function.
7878         (reread_symbols): Use the forward_scope_exit instead of
7879         cleanup_function.
7880         (clear_symtab_users_cleanup): Remove function.
7881
7882 2019-01-23  Tom Tromey  <tom@tromey.com>
7883             Pedro Alves  <palves@redhat.com>
7884
7885         * linux-nat.c: Include scope-exit.h.
7886         (cleanup_target_stop): Remove.
7887         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7888         SCOPE_EXIT.
7889
7890 2019-01-23  Tom Tromey  <tom@tromey.com>
7891             Pedro Alves  <palves@redhat.com>
7892
7893         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7894         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7895
7896 2019-01-23  Tom Tromey  <tom@tromey.com>
7897             Andrew Burgess  <andrew.burgess@embecosm.com>
7898             Pedro Alves  <palves@redhat.com>
7899
7900         * infrun.c (fetch_inferior_event): Use scope_exit.
7901         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7902         * top.c (execute_command): Use scope_exit.
7903         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7904         * utils.c (do_bpstat_clear_actions_cleanup)
7905         (make_bpstat_clear_actions_cleanup): Remove.
7906
7907 2019-01-23  Tom Tromey  <tom@tromey.com>
7908             Pedro Alves  <palves@redhat.com>
7909
7910         * infrun.c: Include "common/scope-exit.h"
7911         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7912         (wait_for_inferior): Use SCOPE_EXIT.
7913         (fetch_inferior_event): Use scope_exit.
7914
7915 2019-01-23  Tom Tromey  <tom@tromey.com>
7916             Pedro Alves  <palves@redhat.com>
7917
7918         * breakpoint.c (create_breakpoint): Remove cleanup.
7919
7920 2019-01-23  Tom Tromey  <tom@tromey.com>
7921             Andrew Burgess  <andrew.burgess@embecosm.com>
7922             Pedro Alves  <palves@redhat.com>
7923
7924 2019-01-23  Pedro Alves  <palves@redhat.com>
7925
7926         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7927
7928 2019-01-23  Pedro Alves  <palves@redhat.com>
7929             Andrew Burgess  <andrew.burgess@embecosm.com>
7930
7931         * gdbthread.h: Include "common/forward-scope-exit.h".
7932         (scoped_finish_thread_state): Redefine custom class in terms of
7933         forward_scope_exit.
7934
7935 2019-01-23  Pedro Alves  <palves@redhat.com>
7936             Andrew Burgess  <andrew.burgess@embecosm.com>
7937
7938         * common/forward-scope-exit.h: New file.
7939
7940 2019-01-23  Pedro Alves  <palves@redhat.com>
7941             Andrew Burgess  <andrew.burgess@embecosm.com>
7942             Tom Tromey  <tom@tromey.com>
7943
7944         * common/scope-exit.h: New file.
7945
7946 2019-01-23  Pedro Alves  <palves@redhat.com>
7947
7948         * common/preprocessor.h (ESC): Rename to ...
7949         (ESC_PARENS): ... this.
7950         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7951         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7952
7953 2019-01-23  Tom Tromey  <tom@tromey.com>
7954
7955         * language.h (class scoped_switch_to_sym_language_if_auto):
7956         Initialize m_lang in both cases.
7957
7958 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7959
7960         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7961         with XCNEW.
7962
7963 2019-01-22  Tom Tromey  <tom@tromey.com>
7964
7965         * corelow.c: Do not include sys/file.h.
7966
7967 2019-01-22  Tom Tromey  <tom@tromey.com>
7968
7969         * tui/tui-wingeneral.h: Include gdb_curses.h.
7970
7971 2019-01-22  Tom Tromey  <tom@tromey.com>
7972
7973         * source-cache.h (class source_cache) <get_source_lines,
7974         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7975
7976 2019-01-22  Tom Tromey  <tom@tromey.com>
7977
7978         * remote-fileio.h (struct remote_target): Declare.
7979
7980 2019-01-22  Tom Tromey  <tom@tromey.com>
7981
7982         * python/py-arch.c: Do not include py-ref.h.
7983         * python/py-bpevent.c: Do not include py-ref.h.
7984         * python/py-cmd.c: Do not include py-ref.h.
7985         * python/py-continueevent.c: Do not include py-ref.h.
7986         * python/py-event.h: Do not include py-ref.h.
7987         * python/py-evtregistry.c: Do not include py-ref.h.
7988         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7989         * python/py-frame.c: Do not include py-ref.h.
7990         * python/py-framefilter.c: Do not include py-ref.h.
7991         * python/py-function.c: Do not include py-ref.h.
7992         * python/py-infevents.c: Do not include py-ref.h.
7993         * python/py-linetable.c: Do not include py-ref.h.
7994         * python/py-objfile.c: Do not include py-ref.h.
7995         * python/py-param.c: Do not include py-ref.h.
7996         * python/py-prettyprint.c: Do not include py-ref.h.
7997         * python/py-progspace.c: Do not include py-ref.h.
7998         * python/py-symbol.c: Do not include py-ref.h.
7999         * python/py-symtab.c: Do not include py-ref.h.
8000         * python/py-type.c: Do not include py-ref.h.
8001         * python/py-unwind.c: Do not include py-ref.h.
8002         * python/py-utils.c: Do not include py-ref.h.
8003         * python/py-value.c: Do not include py-ref.h.
8004         * python/py-varobj.c: Do not include py-ref.h.
8005         * python/py-xmethods.c: Do not include py-ref.h.
8006         * python/python.c: Do not include py-ref.h.
8007         * varobj.c: Do not include py-ref.h.
8008
8009 2019-01-22  Tom Tromey  <tom@tromey.com>
8010
8011         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8012         keyword for bcache.
8013
8014 2019-01-22  Tom Tromey  <tom@tromey.com>
8015
8016         * compile/compile-cplus-types.c: Remove a comment by #include.
8017
8018 2019-01-22  Tom Tromey  <tom@tromey.com>
8019
8020         * compile/gcc-c-plugin.h: Include compile-internal.h.
8021
8022 2019-01-22  Tom Tromey  <tom@tromey.com>
8023
8024         * stabsread.c (EXTERN): Do not define.
8025         (symnum, next_symbol_text_func, processing_gcc_compilation)
8026         (within_function, global_sym_chain, global_stabs)
8027         (previous_stab_code, this_object_header_files)
8028         (n_this_object_header_files)
8029         (n_allocated_this_object_header_files): Define.
8030         * stabsread.h (EXTERN): Never define.  Use "extern".
8031
8032 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8033
8034         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8035         history_value.
8036
8037 2019-01-21  Tom Tromey  <tom@tromey.com>
8038
8039         * ui-out.c: Fix includes.
8040         * tui/tui-source.c: Fix includes.
8041         * target.c: Fix includes.
8042         * remote.c: Fix includes.
8043         * regcache.c: Fix includes.
8044         * python/py-block.c: Fix includes.
8045         * printcmd.c: Fix includes.
8046         * or1k-tdep.c: Fix includes.
8047         * mi/mi-main.c: Fix includes.
8048         * m32r-tdep.c: Fix includes.
8049         * csky-tdep.c: Fix includes.
8050         * compile/compile-cplus-types.c: Fix includes.
8051         * cli/cli-interp.c: Fix includes.
8052
8053 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8054
8055         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8056         for padding.
8057
8058 2019-01-16  Tom Tromey  <tom@tromey.com>
8059
8060         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8061         earlier.
8062         (struct objfile) <msymbols_range>: Move from top level.
8063         <msymbols>: New method.
8064         (class objfile_msymbols): Remove.
8065         * symtab.c (default_collect_symbol_completion_matches_break_on):
8066         Update.
8067         * symmisc.c (dump_msymbols): Update.
8068         * stabsread.c (scan_file_globals): Update.
8069         * objc-lang.c (info_selectors_command, info_classes_command)
8070         (find_methods): Update.
8071         * minsyms.c (find_solib_trampoline_target): Update.
8072         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8073         * coffread.c (coff_symfile_read): Update.
8074         * ada-lang.c (ada_lookup_simple_minsym)
8075         (ada_collect_symbol_completion_matches): Update.
8076
8077 2019-01-16  Tom Tromey  <tom@tromey.com>
8078
8079         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8080         type.  Remove no-argument constructor.
8081         <iterator::operator++>: Simplify.
8082         <begin>: Update.
8083         <end>: Use minimal_symbol_count.
8084
8085 2019-01-16  Tom Tromey  <tom@tromey.com>
8086
8087         * objfiles.h (struct objfile) <psymtabs>: New method.
8088         (class objfile_psymtabs): Remove.
8089         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8090         typedef.
8091         <range>: New method.
8092         (require_partial_symbols): Change return type.
8093         * psymtab.c (require_partial_symbols)
8094         (psym_expand_symtabs_matching): Update.
8095         * mdebugread.c (parse_partial_symbols): Update.
8096         * dbxread.c (dbx_end_psymtab): Update.
8097
8098 2019-01-15  Tom Tromey  <tom@tromey.com>
8099
8100         * symtab.c (lookup_objfile_from_block)
8101         (lookup_symbol_in_objfile_symtabs)
8102         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8103         (find_line_symtab, info_sources_command)
8104         (default_collect_symbol_completion_matches_break_on)
8105         (make_source_files_completion_list): Update.
8106         * symmisc.c (print_objfile_statistics, dump_objfile)
8107         (maintenance_print_symbols, maintenance_info_symtabs)
8108         (maintenance_check_symtabs, maintenance_info_line_tables):
8109         Update.
8110         * source.c (select_source_symtab)
8111         (forget_cached_source_info_for_objfile): Update.
8112         * objfiles.h (class objfile_compunits): Remove.
8113         (struct objfile) <compunits_range>: New typedef.
8114         (compunits): New method.
8115         * objfiles.c (objfile_relocate1): Update.
8116         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8117         * maint.c (count_symtabs_and_blocks): Update.
8118         * linespec.c (iterate_over_all_matching_symtabs): Update.
8119         * cp-support.c (add_symbol_overload_list_qualified): Update.
8120         * coffread.c (coff_symtab_read): Update.
8121         * ada-lang.c (add_nonlocal_symbols)
8122         (ada_collect_symbol_completion_matches)
8123         (ada_add_global_exceptions): Update.
8124
8125 2019-01-15  Tom Tromey  <tom@tromey.com>
8126
8127         * progspace.h (program_space) <objfiles_safe_range>: New
8128         typedef.
8129         <objfiles_safe>: New method.
8130         * objfiles.h (class all_objfiles_safe): Remove.
8131         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8132         * jit.c (jit_inferior_exit_hook): Update.
8133
8134 2019-01-17  Tom Tromey  <tom@tromey.com>
8135
8136         * progspace.h (program_space) <objfiles_range>: New typedef.
8137         <objfiles>: New method.
8138         <objfiles_head>: Rename from objfiles.
8139         (object_files): Update.
8140         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8141         * guile/scm-pretty-print.c
8142         (ppscm_find_pretty_printer_from_objfiles): Update.
8143         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8144         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8145         Update.
8146         * python/py-progspace.c (pspy_get_objfiles): Update.
8147         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8148         Update.
8149         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8150         (objfpy_lookup_objfile_by_build_id): Update.
8151         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8152         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8153         Update.
8154         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8155         (expand_symtab_containing_pc, lookup_objfile_from_block)
8156         (lookup_static_symbol, basic_lookup_transparent_type)
8157         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8158         (find_line_symtab, info_sources_command)
8159         (default_collect_symbol_completion_matches_break_on)
8160         (make_source_files_completion_list, find_main_name): Update.
8161         * symmisc.c (print_symbol_bcache_statistics)
8162         (print_objfile_statistics, maintenance_print_symbols)
8163         (maintenance_print_msymbols, maintenance_print_objfiles)
8164         (maintenance_info_symtabs, maintenance_check_symtabs)
8165         (maintenance_expand_symtabs, maintenance_info_line_tables):
8166         Update.
8167         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8168         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8169         (map_overlay_command, unmap_overlay_command)
8170         (simple_overlay_update, expand_symtabs_matching)
8171         (map_symbol_filenames): Update.
8172         * symfile-debug.c (set_debug_symfile): Update.
8173         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8174         Update.
8175         * source.c (select_source_symtab, forget_cached_source_info):
8176         Update.
8177         * solib.c (solib_read_symbols): Update.
8178         * solib-spu.c (append_ocl_sos): Update.
8179         * psymtab.c (maintenance_print_psymbols)
8180         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8181         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8182         * printcmd.c (info_symbol_command): Update.
8183         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8184         Update.
8185         * objfiles.h (class all_objfiles): Remove.
8186         * objfiles.c (have_partial_symbols, have_full_symbols)
8187         (have_minimal_symbols, qsort_cmp, update_section_map)
8188         (shared_objfile_contains_address_p)
8189         (default_iterate_over_objfiles_in_search_order): Update.
8190         * objc-lang.c (info_selectors_command, info_classes_command)
8191         (find_methods): Update.
8192         * minsyms.c (find_solib_trampoline_target): Update.
8193         * maint.c (maintenance_info_sections)
8194         (maintenance_translate_address, count_symtabs_and_blocks):
8195         Update.
8196         * main.c (captured_main_1): Update.
8197         * linux-thread-db.c (try_thread_db_load_from_pdir)
8198         (has_libpthread): Update.
8199         * linespec.c (iterate_over_all_matching_symtabs)
8200         (search_minsyms_for_name): Update.
8201         * jit.c (jit_find_objf_with_entry_addr): Update.
8202         * hppa-tdep.c (find_unwind_entry)
8203         (hppa_lookup_stub_minimal_symbol): Update.
8204         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8205         Update.
8206         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8207         (elf_gnu_ifunc_resolve_by_got): Update.
8208         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8209         * dwarf-index-write.c (save_gdb_index_command): Update.
8210         * cp-support.c (add_symbol_overload_list_qualified): Update.
8211         * breakpoint.c (create_overlay_event_breakpoint)
8212         (create_longjmp_master_breakpoint)
8213         (create_std_terminate_master_breakpoint)
8214         (create_exception_master_breakpoint): Update.
8215         * blockframe.c (find_pc_partial_function): Update.
8216         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8217         (ada_collect_symbol_completion_matches)
8218         (ada_add_global_exceptions): Update.
8219
8220 2019-01-17  Tom Tromey  <tom@tromey.com>
8221
8222         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8223         declare VEC.
8224         (solib_target_parse_libraries): Change return type.
8225         (library_list_start_segment, library_list_start_section)
8226         (library_list_end_library, library_list_start_library); Update.
8227         (solib_target_free_library_list): Remove.
8228         (solib_target_parse_libraries): Remove cleanup.  Change return
8229         type.
8230         (solib_target_current_sos): Update.
8231
8232 2019-01-17  Tom Tromey  <tromey@bapiya>
8233
8234         * valprint.c: Replace "the the" with "the".
8235         * symtab.c: Replace "the the" with "the".
8236         * solib.c: Replace "the the" with "the".
8237         * solib-dsbt.c: Replace "the the" with "the".
8238         * linespec.c: Replace "the the" with "the".
8239         * dwarf2loc.h: Replace "the the" with "the".
8240         * amd64-windows-tdep.c: Replace "the the" with "the".
8241         * aarch64-tdep.c: Replace "the the" with "the".
8242
8243 2019-01-16  Keith Seitz  <keiths@redhat.com>
8244
8245         PR gdb/23773
8246         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8247         <builder>: Rename to ..
8248         <m_builder>: ... this and make private.
8249         (dwarf2_cu::get_builder): New method.  Change all users of
8250         `builder' to use this method.
8251         (dwarf2_start_symtab): Move to ...
8252         (dwarf2_cu::start_symtab): ... here.  Update all callers
8253         (setup_type_unit_groups): Move to ...
8254         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8255         callers.
8256         (dwarf2_cu::reset_builder): New method.
8257         (process_full_compunit, process_full_type_unit): Use
8258         dwarf2_cu::reset_builder.
8259         (follow_die_offset): Record the ancestor CU if it is different
8260         from the followed DIE's CU.
8261         (follow_die_sig_1): Likewise.
8262
8263 2019-01-15  Tom Tromey  <tom@tromey.com>
8264
8265         * remote.c (class remote_state) <buf>: Now a char_vector.
8266         <buf_size>: Remove.
8267         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8268         parameter.
8269         (remote_target::getpkt_or_notif_sane_1)
8270         (remote_target::getpkt_sane)
8271         (remote_target::getpkt_or_notif_sane): Likewise.
8272         (class remote_target) <putpkt>: New overload.
8273         (remote_target::read_frame): Change type of "buf_p".  Remove
8274         sizeof_p parameter.
8275         (packet_ok): New overload.
8276         (packet_check_result): New overload.
8277         Update all uses.
8278
8279 2019-01-14  Tom Tromey  <tom@tromey.com>
8280
8281         * remote-notif.c (handle_notification, remote_notif_ack)
8282         (remote_notif_parse): Make "buf" const.
8283         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8284         const.
8285         (remote_notif_parse, remote_notif_ack, handle_notification):
8286         Likewise.
8287         * remote.c (remote_notif_stop_parse): Make "buf" const.
8288         (remote_target::remote_parse_stop_reply): Make "buf" const.
8289         (remote_notif_stop_ack): Make "buf" const.
8290
8291 2019-01-14  Tom Tromey  <tom@tromey.com>
8292
8293         * remote.c (remote_console_output): Make parameter const.
8294
8295 2019-01-14  Tom Tromey  <tom@tromey.com>
8296
8297         * target-debug.h (target_debug_print_signals): Constify.
8298         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8299         * procfs.c (procfs_target::pass_signals): Update.
8300         * linux-nat.c (linux_nat_target::pass_signals): Update.
8301         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8302         * target-delegates.c: Rebuild.
8303         * remote.c (remote_target::program_signals): Update.
8304         (remote_target::pass_signals): Update.
8305         * target.c (target_pass_signals): Constify argument.
8306         (target_program_signals): Likewise.
8307         * target.h (struct target_ops) <pass_signals, program_signals>:
8308         Constify argument.
8309         (target_pass_signals, target_program_signals): Constify argument.
8310
8311 2019-01-14  Tom Tromey  <tom@tromey.com>
8312
8313         PR tui/28819:
8314         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8315
8316 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8317
8318         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8319         field.
8320         * rs6000-tdep.c: Include reggroups.h.
8321         (IS_V_ALIAS_PSEUDOREG): Define.
8322         (rs6000_register_name): Return names for the "vX" aliases.
8323         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8324         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8325         aliases.  Call default_register_reggroup_p for all other
8326         pseudo-registers.
8327         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8328         New functions.
8329         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8330         Handle "vX" aliases.
8331         (v_alias_pseudo_register_collect): New function.
8332         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8333         (rs6000_gdbarch_init): Initialize "vX" aliases as
8334         pseudo-registers.  Restore registration of
8335         rs6000_pseudo_register_reggroup_p with
8336         set_tdesc_pseudo_register_reggroup_p.
8337
8338 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8339
8340         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8341         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8342         set_gdbarch_num_pseudo_regs.
8343
8344 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8345
8346         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8347         Remove arg prefixname, add do_set and do_show.
8348         Add member functions set_list and show_list.
8349         * cli/cli-style.c (class cli_style_option): Update accordingly.
8350         (style_set_list): Move to file scope.
8351         (style_show_list): Likewise.
8352         (set_style): Call help_list.
8353         (show_style): Call cmd_show_list.
8354         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8355         Update to use the new macro.
8356
8357 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8358
8359         * ada-lang.c (_initialize_ada_language): Expand the help text
8360         for the "catch exception" command.
8361
8362 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8363
8364         * symtab.c (matching_obj_sections): Initialize obj,
8365         declare it closer to its usage.
8366
8367 2019-01-10  Tom Tromey  <tom@tromey.com>
8368
8369         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8370         (basic_inf_threads_range): Remove.
8371         (inf_threads_range, inf_non_exited_threads_range)
8372         (safe_inf_threads_range): Use next_adapter.
8373
8374 2019-01-10  Keith Seitz  <keiths@redhat.com>
8375
8376         PR gdb/23712
8377         PR symtab/23010
8378         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8379         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8380
8381 2019-01-10  Keith Seitz  <keiths@redhat.com>
8382
8383         PR gdb/23712
8384         PR symtab/23010
8385         * dictionary.c (pending_to_vector): Remove.
8386         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8387         Remove _1 suffix, replacing functions of the same name.  Update
8388         all callers.
8389         (dict_create_hashed, dict_create_hashed_expandable)
8390         (dict_create_linear, dict_create_linear_expandable, dict_free)
8391         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8392         Make functions static.
8393
8394 2019-01-10  Keith Seitz  <keiths@redhat.com>
8395
8396         PR gdb/23712
8397         PR symtab/23010
8398         * dictionary.h (struct dictionary): Replace declaration with
8399         multidictionary.
8400         (dict_create_hashed, dict_create_hashed_expandable)
8401         (dict_create_linear, dict_create_linear_expandable)
8402         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8403         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8404         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8405         taking multidictionary argument.
8406         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8407         * block.h (struct block) <dict>: Change to multidictionary
8408         and rename `multidict'.
8409         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8410         symmisc.c: Update all dictionary references to multidictionary.
8411
8412 2019-01-10  Keith Seitz  <keiths@redhat.com>
8413
8414         PR gdb/23712
8415         PR symtab/23010
8416         * dictionary.c: Include unordered_map.
8417         (pending_to_vector): New function.
8418         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8419         Rewrite the non-"_1" functions to take vector instead
8420         of linked list.
8421         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8422         "new" _1 versions of the same name.
8423         (multidictionary): Define.
8424         (std::hash<enum language): New definition.
8425         (collate_pending_symbols_by_language, mdict_create_hashed)
8426         (mdict_create_hashed_expandable, mdict_create_linear)
8427         (mdict_create_linear_expandable, mdict_free)
8428         (find_language_dictionary, create_new_language_dictionary)
8429         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8430         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8431         (mdict_size, mdict_empty): New functions.
8432         * dictionary.h (mdict_iterator): Define.
8433
8434 2019-01-10  Pedro Alves  <palves@redhat.com>
8435
8436         * breakpoint.c (read_uploaded_action)
8437         (create_tracepoint_from_upload): Adjust to use
8438         gdb::unique_xmalloc_ptr.
8439         * ctf.c (ctf_write_uploaded_tp):
8440         (SET_ARRAY_FIELD): Use emplace_back.
8441         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8442         * tracefile-tfile.c (tfile_write_uploaded_tp):
8443         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8444         gdb::unique_xmalloc_ptr.
8445         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8446         at_string, cond_string, cmd_strings>: Replace char pointers
8447         with gdb::unique_xmalloc_ptr.
8448
8449 2019-01-10  Pedro Alves  <palves@redhat.com>
8450
8451         * solib-target.c (library_list_start_library): Don't xstrdup name.
8452
8453 2019-01-10  Pedro Alves  <palves@redhat.com>
8454
8455         * mdebugread.c (parse_partial_symbols): Use
8456         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8457
8458 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * linux-fork.c (scoped_switch_fork_info)
8461         <~scoped_switch_fork_info>: Fix incorrect variable name.
8462
8463 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8464
8465         * linux-fork.c (scoped_switch_fork_info)
8466         <scoped_switch_fork_info>: Make explicit.
8467         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8468
8469 2019-01-10  Tom Tromey  <tom@tromey.com>
8470
8471         * objfiles.h (objfile::reset_psymtabs): Update.
8472         * objfiles.c (objfile::objfile): Update.
8473         * psymtab.h (psymtab_storage::obstack): Update.
8474         (psymtab_storage::m_obstack): Use gdb::optional.
8475         (class psymtab_storage): Update comment.  Remove objfile
8476         parameter.
8477         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8478
8479 2019-01-10  Tom Tromey  <tom@tromey.com>
8480
8481         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8482         <free_psymtabs>: Now private.
8483         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8484         (allocate_psymtab): Use new method.
8485
8486 2019-01-10  Tom Tromey  <tom@tromey.com>
8487
8488         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8489         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8490         * mdebugread.c (parse_partial_symbols): Use
8491         allocate_dependencies.
8492         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8493         allocate_dependencies.
8494         (process_psymtab_comp_unit_reader)
8495         (build_type_psymtab_dependencies): Likewise.
8496         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8497
8498 2019-01-10  Tom Tromey  <tom@tromey.com>
8499
8500         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8501         PSYMBOL_SET_LANGUAGE.
8502         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8503
8504 2019-01-10  Tom Tromey  <tom@tromey.com>
8505
8506         * psymtab.h (psymtab_storage::obstack): New method.
8507         <m_obstack>: Rename from obstack; now private.
8508         * psymtab.c (psymtab_storage): Update.
8509         * dwarf2read.c (create_addrmap_from_index)
8510         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8511         Update.
8512
8513 2019-01-10  Tom Tromey  <tom@tromey.com>
8514
8515         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8516         * objfiles.h (objfile::reset_psymtabs): New method.
8517
8518 2019-01-10  Tom Tromey  <tom@tromey.com>
8519
8520         * symmisc.c (print_symbol_bcache_statistics): Update.
8521         (print_objfile_statistics): Update.
8522         * symfile.c (reread_symbols): Update.
8523         * psymtab.h (class psymtab_storage): New.
8524         * psymtab.c (psymtab_storage): New constructor.
8525         (~psymtab_storage): New destructor.
8526         (require_partial_symbols): Update.
8527         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8528         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8529         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8530         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8531         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8532         (start_psymtab_common, end_psymtab_common)
8533         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8534         (allocate_psymtab): Update.
8535         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8536         Update.
8537         (dump_psymtab_addrmap, maintenance_print_psymbols)
8538         (maintenance_check_psymtabs): Update.
8539         (class objfile_psymtabs): Move to objfiles.h.
8540         * psympriv.h (discard_psymtab): Now inline.
8541         (psymtab_discarder::psymtab_discarder): Update.
8542         (psymtab_discarder::~psymtab_discarder): Update.
8543         (ALL_OBJFILE_PSYMTABS): Rewrite.
8544         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8545         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8546         Remove fields.
8547         <partial_symtabs>: New field.
8548         (class objfile_psymtabs): Move from psymtab.h.  Update.
8549         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8550         psymbol_cache.
8551         (objfile::~objfile): Don't destroy psymbol_cache.
8552         * mdebugread.c (parse_partial_symbols): Update.
8553         * dwarf2read.c (create_addrmap_from_index)
8554         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8555         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8556         (add_partial_subprogram, dwarf2_ranges_read): Update.
8557         * dwarf-index-write.c (write_address_map)
8558         (write_one_signatured_type, recursively_write_psymbols)
8559         (class debug_names, class debug_names, write_psymtabs_to_index):
8560         Update.
8561
8562 2019-01-10  Tom Tromey  <tom@tromey.com>
8563
8564         * symtab.h (SYMBOL_SET_NAMES): Update.
8565         (symbol_set_names): Update.
8566         (MSYMBOL_SET_NAMES): Update.
8567         * symtab.c (symbol_set_names): Change argument to be an
8568         objfile_per_bfd_storage.
8569         * psymtab.c (add_psymbol_to_bcache): Update.
8570         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8571
8572 2019-01-10  Tom Tromey  <tom@tromey.com>
8573
8574         * symtab.c (create_demangled_names_hash): Change argument to be an
8575         objfile_per_bfd_storage.
8576         (symbol_set_names): Update.
8577
8578 2019-01-10  Tom Tromey  <tom@tromey.com>
8579
8580         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8581         init_psymbol_list.
8582         * psymtab.c (init_psymbol_list): Do nothing if already called.
8583         * psympriv.h (init_psymbol_list): Add comment.
8584         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8585         init_psymbol_list.
8586         * dbxread.c (dbx_symfile_read): Unconditionally call
8587         init_psymbol_list.
8588
8589 2019-01-10  Tom Tromey  <tom@tromey.com>
8590
8591         * xcoffread.c (scan_xcoff_symtab): Update.
8592         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8593         "where".
8594         * mdebugread.c (parse_partial_symbols)
8595         (handle_psymbol_enumerators): Update.
8596         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8597         * dbxread.c (read_dbx_symtab): Update.
8598         * psympriv.h (psymbol_placement): New enum.
8599         (add_psymbol_to_list): Update.
8600
8601 2019-01-10  Tom Tromey  <tom@tromey.com>
8602
8603         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8604         static_psymbols parameters.
8605         (scan_xcoff_symtab): Update.
8606         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8607         static_psymbols parameters.
8608         * psympriv.h (start_psymtab_common): Update.
8609         * mdebugread.c (parse_partial_symbols): Update.
8610         * dwarf2read.c (create_partial_symtab): Update.
8611         * dbxread.c (read_dbx_symtab): Update.
8612         (start_psymtab): Remove global_psymbols and static_psymbols
8613         parameters.
8614
8615 2019-01-10  Tom Tromey  <tom@tromey.com>
8616
8617         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8618         * psymtab.c (allocate_psymtab): Add comment.
8619         * psympriv.h (allocate_psymtab): Add comment.
8620         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8621         initializations.
8622         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8623
8624 2019-01-10  Tom Tromey  <tom@tromey.com>
8625
8626         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8627         Don't declare.
8628         * mipsread.c: Include mdebugread.h.
8629         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8630         Declare.
8631         * elfread.c: Include mdebugread.h.
8632
8633 2019-01-09  Tom Tromey  <tom@tromey.com>
8634
8635         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8636         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8637         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8638         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8639         (psym_lookup_symbol, psym_find_last_source_symtab)
8640         (psym_forget_cached_source_info, psym_print_stats)
8641         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8642         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8643         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8644         (psym_find_compunit_symtab_by_address)
8645         (maintenance_print_psymbols, maintenance_info_psymtabs)
8646         (maintenance_check_psymtabs): Use ranged for.
8647         * psymtab.h (class objfile_psymtabs): New.
8648         (require_partial_symbols): Return objfile_psymtabs.
8649         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8650
8651 2019-01-09  Tom Tromey  <tom@tromey.com>
8652
8653         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8654         (find_pc_mapped_section, list_overlays_command)
8655         (map_overlay_command, unmap_overlay_command)
8656         (simple_overlay_update): Use all_objfiles.
8657         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8658         * printcmd.c (info_symbol_command): Use all_objfiles.
8659         * objfiles.h (ALL_OBJSECTIONS): Remove.
8660         * maint.c (maintenance_translate_address): Use all_objfiles.
8661         * gcore.c (gcore_create_callback): Use all_objfiles.
8662         (objfile_find_memory_regions): Likewise.
8663
8664 2019-01-09  Tom Tromey  <tom@tromey.com>
8665
8666         * symtab.c (find_line_symtab, info_sources_command)
8667         (make_source_files_completion_list): Use objfile_compunits.
8668         * source.c (select_source_symtab): Use objfile_compunits.
8669         * objfiles.h (struct objfile): Update comment.
8670         (ALL_OBJFILES): Remove.
8671         (ALL_FILETABS): Remove.
8672         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8673         objfile_compunits.
8674
8675 2019-01-09  Tom Tromey  <tom@tromey.com>
8676
8677         * symmisc.c (print_objfile_statistics, dump_objfile)
8678         (maintenance_print_symbols): Use compunit_filetabs.
8679         * source.c (forget_cached_source_info_for_objfile): Use
8680         compunit_filetabs.
8681         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8682         (ALL_FILETABS): Use compunit_filetabs.
8683         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8684         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8685
8686 2019-01-09  Tom Tromey  <tom@tromey.com>
8687
8688         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8689         (compunit_filetabs): New.
8690         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8691         compunit_filetabs.
8692         (info_sources_command, make_source_files_completion_list): Remove
8693         declaration.
8694         * symmisc.c (print_objfile_statistics, dump_objfile)
8695         (maintenance_print_symbols): Remove declaration.
8696         (maintenance_info_symtabs): Use compunit_filetabs.
8697         (maintenance_info_line_tables): Likewise.
8698         * source.c (select_source_symtab): Change local variable name.
8699         (forget_cached_source_info_for_objfile): Remove declaration.
8700         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8701         * objfiles.c (objfile_relocate1): Remove declaration.
8702         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8703         declaration.
8704         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8705         * coffread.c (coff_symtab_read): Remove declaration.
8706         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8707         compunit_filetabs.
8708
8709 2019-01-09  Tom Tromey  <tom@tromey.com>
8710
8711         * symtab.c (lookup_objfile_from_block)
8712         (find_pc_sect_compunit_symtab, search_symbols)
8713         (default_collect_symbol_completion_matches_break_on): Use
8714         objfile_compunits.
8715         * objfiles.h (ALL_COMPUNITS): Remove.
8716         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8717         * cp-support.c (add_symbol_overload_list_qualified): Use
8718         objfile_compunits.
8719         * ada-lang.c (ada_collect_symbol_completion_matches)
8720         (ada_add_global_exceptions): Use objfile_compunits.
8721
8722 2019-01-09  Tom Tromey  <tom@tromey.com>
8723
8724         * source.c (select_source_symtab)
8725         (forget_cached_source_info_for_objfile): Remove declaration.
8726         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8727         declaration.
8728         * maint.c (count_symtabs_and_blocks): Remove declaration.
8729         * cp-support.c (add_symbol_overload_list_qualified): Remove
8730         declaration.
8731         * coffread.c (coff_symtab_read): Remove declaration.
8732         * symtab.c (lookup_symbol_in_objfile_symtabs)
8733         (basic_lookup_transparent_type_1): Use objfile_compunits.
8734         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8735         (info_sources_command, search_symbols)
8736         (default_collect_symbol_completion_matches_break_on)
8737         (make_source_files_completion_list): Remove declaration.
8738         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8739         (ada_collect_symbol_completion_matches)
8740         (ada_add_global_exceptions): Remove declaration.
8741         * linespec.c (iterate_over_all_matching_symtabs): Use
8742         objfile_compunits.
8743         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8744         (class objfile_compunits): New.
8745         (ALL_COMPUNITS): Use objfile_compunits.
8746         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8747         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8748         objfile_compunits.
8749         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8750
8751 2019-01-09  Tom Tromey  <tom@tromey.com>
8752
8753         * symtab.c (search_symbols)
8754         (default_collect_symbol_completion_matches_break_on): Use
8755         objfile_msymbols.
8756         * ada-lang.c (ada_lookup_simple_minsym)
8757         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8758         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8759         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8760         objfile_msymbols.
8761         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8762         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8763         * objc-lang.c (find_methods): Use objfile_msymbols.
8764         (info_selectors_command, info_classes_command): Likewise.
8765         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8766         * objfiles.h (class objfile_msymbols): New.
8767         (ALL_OBJFILE_MSYMBOLS): Remove.
8768         (ALL_MSYMBOLS): Remove.
8769
8770 2019-01-09  Tom Tromey  <tom@tromey.com>
8771
8772         * common/next-iterator.h (next_adapter): Add Iterator template
8773         parameter.
8774         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8775         (class all_objfiles_safe): New.
8776         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8777         * objfiles.c (put_objfile_before): Update comment.
8778         (add_separate_debug_objfile): Likewise.
8779         (free_all_objfiles): Use all_objfiles_safe.
8780         (objfile_purge_solibs): Likewise.
8781
8782 2019-01-09  Tom Tromey  <tom@tromey.com>
8783
8784         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8785         (expand_symtab_containing_pc, lookup_static_symbol)
8786         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8787         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8788         all_objfiles.
8789         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8790         * breakpoint.c (create_overlay_event_breakpoint)
8791         (create_longjmp_master_breakpoint)
8792         (create_std_terminate_master_breakpoint)
8793         (create_exception_master_breakpoint): Use all_objfiles.
8794         * linux-thread-db.c (try_thread_db_load_from_pdir)
8795         (has_libpthread): Use all_objfiles.
8796         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8797         * linespec.c (iterate_over_all_matching_symtabs)
8798         (search_minsyms_for_name): Use all_objfiles.
8799         * maint.c (maintenance_info_sections): Use all_objfiles.
8800         * main.c (captured_main_1): Use all_objfiles.
8801         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8802         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8803         * guile/scm-pretty-print.c
8804         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8805         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8806         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8807         (maintenance_print_msymbols): Use all_objfiles.
8808         * source.c (select_source_symtab): Use all_objfiles.
8809         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8810         * symfile.c (remove_symbol_file_command)
8811         (expand_symtabs_matching, map_symbol_filenames): Use
8812         all_objfiles.
8813         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8814         all_objfiles.
8815         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8816         * objc-lang.c (find_methods): Use all_objfiles.
8817         * objfiles.c (have_partial_symbols, have_full_symbols)
8818         (have_minimal_symbols, qsort_cmp)
8819         (default_iterate_over_objfiles_in_search_order): Use
8820         all_objfiles.
8821         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8822         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8823         (maintenance_check_psymtabs): Use all_objfiles.
8824         (ALL_PSYMTABS): Remove.
8825         * compile/compile-object-run.c (do_module_cleanup): Use
8826         all_objfiles.
8827         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8828         * cp-support.c (add_symbol_overload_list_qualified): Use
8829         all_objfiles.
8830         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8831         Use all_objfiles.
8832         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8833         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8834         all_objfiles.
8835         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8836         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8837         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8838         Uses all_objfiles.
8839         * solib.c (solib_read_symbols): Use all_objfiles
8840
8841 2019-01-09  Tom Tromey  <tom@tromey.com>
8842
8843         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8844         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8845         all_objfiles.
8846         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8847         * symmisc.c (print_symbol_bcache_statistics)
8848         (print_objfile_statistics, maintenance_print_objfiles)
8849         (maintenance_info_symtabs, maintenance_check_symtabs)
8850         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8851         all_objfiles.
8852         * source.c (forget_cached_source_info): Use all_objfiles.
8853         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8854         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8855         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8856         * objfiles.c (update_section_map): Use all_objfiles.
8857         (shared_objfile_contains_address_p): Likewise.
8858         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8859         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8860
8861 2019-01-09  Tom Tromey  <tom@tromey.com>
8862
8863         * common/next-iterator.h: New file.
8864         * objfiles.h (class all_objfiles): New.
8865         (struct objfile_iterator): New.
8866
8867 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8868
8869         * NEWS: Move the description of the changed "frame", "select-frame",
8870          and "info frame" commands to the Changed commands section.
8871
8872 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8873
8874         * gdbtypes.c (check_stub_method_group): Remove handling of old
8875         mangling schemes.
8876         * linespec.c (find_methods): Likewise.
8877         * stabsread.c (read_member_functions): Likewise.
8878         * valops.c (search_struct_method): Likewise.
8879         (value_struct_elt_for_reference): Likewise.
8880         * NEWS: Mention this change.
8881
8882 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8883
8884         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8885         print_source_lines.
8886         * source.c (print_source_lines_base): Update line number check.
8887         (print_source_lines): New function.
8888         (source_lines_range::source_lines_range): New function.
8889         * source.h (class source_lines_range): New class.
8890         (print_source_lines): New declaration.
8891
8892 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8893
8894         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8895
8896 2019-01-08  Tom Tromey  <tom@tromey.com>
8897             Simon Marchi  <simon.marchi@ericsson.com>
8898
8899         PR gdb/24060
8900         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8901         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8902         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8903         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8904         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8905         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8906
8907 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8908
8909         * source.c (select_source_symtab): Move header comment to
8910         declaration in source.h.
8911         (forget_cached_source_info_for_objfile): Likewise.
8912         (forget_cached_source_info): Likewise.
8913         (identify_source_line): Likewise.
8914         * source.h (identify_source_line): Move declaration from symtab.h
8915         and add comment from source.c
8916         (print_source_lines): Likewise.
8917         (forget_cached_source_info_for_objfile): Likewise.
8918         (forget_cached_source_info): Likewise.
8919         (select_source_symtab): Likewise.
8920         (enum print_source_lines_flag): Move definition from symtab.h.
8921         * symtab.h (identify_source_line): Move declaration to source.h.
8922         (print_source_lines): Likewise.
8923         (forget_cached_source_info_for_objfile): Likewise.
8924         (forget_cached_source_info): Likewise.
8925         (select_source_symtab): Likewise.
8926         (enum print_source_lines_flag): Move definition to source.h.
8927         * tui/tui-hooks.c: Add 'source.h' include.
8928
8929 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8930
8931         * source.c (print_source_lines_base): Handle requests to print
8932         reverse line number sequences, and guard against empty lines
8933         string.
8934
8935 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8936
8937         * source.c (print_source_lines_base): Fix skip of '\r' if next
8938         character is '\n'.
8939
8940 2019-01-06  Tom Tromey  <tom@tromey.com>
8941
8942         * c-exp.y (struct c_parse_state) <macro_original_text,
8943         expansion_obstack>: New member.
8944         (macro_original_text, expansion_obstack): Remove globals.
8945         (scan_macro_expansion, scanning_macro_expansion)
8946         (finished_macro_expansion): Update.
8947         (scan_macro_cleanup): Remove.
8948         (yylex, c_parse): Update.
8949
8950 2019-01-06  Tom Tromey  <tom@tromey.com>
8951
8952         * c-exp.y (struct c_parse_state) <strings>: New member.
8953         (operator_stoken): Update.
8954
8955 2019-01-06  Tom Tromey  <tom@tromey.com>
8956
8957         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8958         (union type_stack_elt) <typelist_val>: Now a pointer to
8959         std::vector.
8960         (type_stack_cleanup): Don't declare.
8961         (push_typelist): Update.
8962         * parse.c (pop_typelist): Return a std::vector.
8963         (push_typelist): Take a std::vector.
8964         (follow_types): Update.  Do not free args.
8965         (type_stack_cleanup): Remove.
8966         * c-exp.y (struct c_parse_state): New.
8967         (cpstate): New global.
8968         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8969         (nonempty_typelist): Update.
8970         (func_mod): Create a new vector.
8971         (c_parse): Create a c_parse_state.
8972         (check_parameter_typelist): Do not delete params.
8973         (function_method): Update.  Do not delete type_list.
8974
8975 2019-01-06  Tom Tromey  <tom@tromey.com>
8976
8977         PR gdb/28155:
8978         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8979         check_typedef.
8980         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8981         (print_return_value): Likewise.
8982
8983 2019-01-05  Tom Tromey  <tom@tromey.com>
8984
8985         * contrib/cleanup_check.py: Remove.
8986         * contrib/gcc-with-excheck: Remove.
8987         * contrib/exsummary.py: Remove.
8988         * contrib/excheck.py: Remove.
8989
8990 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8991
8992         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8993         NULL. Initialize tpprev to NULL instead of assigning it
8994         to NULL on the next statement.
8995         * windows-nat.c (windows_delete_thread): Remove check for
8996         main_thread_id before printing thread exit notifications.
8997         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8998         Remove thread ID check against main_thread_id.
8999         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9000         windows_delete_thread.
9001         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9002
9003 2019-01-04  Tom Tromey  <tom@tromey.com>
9004
9005         * compile/compile.c (_initialize_compile): Use upper case for
9006         metasyntactic variables.
9007         * symmisc.c (_initialize_symmisc): Use upper case for
9008         metasyntactic variables.
9009         * psymtab.c (_initialize_psymtab): Use upper case for
9010         metasyntactic variables.
9011         * demangle.c (demangle_command): Use upper case for metasyntactic
9012         variables.
9013         (_initialize_demangler): Likewise.
9014         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9015         variables.
9016
9017 2019-01-03  Tom Tromey  <tom@tromey.com>
9018
9019         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9020
9021 2019-01-03  Tom Tromey  <tom@tromey.com>
9022
9023         * python/py-symtab.c (salpy_str): Update.
9024         (struct salpy_sal_object) <symtab>: Now a PyObject.
9025         (salpy_dealloc): Update.
9026         (del_objfile_sal): Use gdbpy_ref.
9027
9028 2019-01-03  Tom Tromey  <tom@tromey.com>
9029
9030         * python/py-type.c (convert_field): Use new_reference.  Return
9031         gdbpy_ref.
9032         (make_fielditem): Return gdbpy_ref.
9033         (typy_fields): Update.
9034         (typy_getitem): Update.
9035         (field_name): Return gdbpy_ref.  Use new_reference.
9036         (typy_iterator_iternext): Update.
9037
9038 2019-01-03  Tom Tromey  <tom@tromey.com>
9039
9040         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9041
9042 2019-01-03  Tom Tromey  <tom@tromey.com>
9043
9044         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9045         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9046         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9047         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9048         (pspy_set_type_printers): Likewise.
9049         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9050         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9051         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9052         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9053         (objfpy_set_type_printers): Likewise.
9054
9055 2019-01-03  Tom Tromey  <tom@tromey.com>
9056
9057         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9058         (gdbpy_print_stack): Use gdbpy_err_fetch.
9059         * python/python-internal.h (class gdbpy_err_fetch): New class.
9060         (class gdbpy_enter) <m_error_type, m_error_value,
9061         m_error_traceback>: Remove.
9062         <m_error>: New member.
9063         (gdbpy_exception_to_string): Don't declare.
9064         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9065         * python/py-value.c (convert_value_from_python): Use
9066         gdbpy_err_fetch.
9067         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9068         gdbpy_exception_to_string.
9069         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9070         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9071         gdbpy_err_fetch.
9072
9073 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9074
9075         * linux-nat.c (delete_lwp_cleanup): Delete.
9076         (struct lwp_deleter): New struct.
9077         (lwp_info_up): New typedef.
9078         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9079         lwp_info_up.
9080
9081 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9082
9083         * linux-fork.c (class scoped_switch_fork_info): New class.
9084         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9085
9086 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9087
9088         * valops.c (find_overload_match): Remove use of null_cleanup, and
9089         calls to do_cleanups.
9090
9091 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9092
9093         * compile/compile-cplus-types.c
9094         (compile_cplus_instance::decl_name): Handle changes to
9095         cp_func_name.
9096         * cp-support.c (cp_func_name): Update header comment, update
9097         return type.
9098         * cp-support.h (cp_func_name): Update return type in declaration.
9099         * valops.c (find_overload_match): Move temp_func local to top
9100         level of function and change its type.  Use temp_func to hold and
9101         delete temporary string obtained from cp_func_name.
9102
9103 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9104
9105         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9106         gdb::char_vector, remove cleanup, and update uses of `msg`.
9107
9108 2019-01-03  Jim Wilson  <jimw@sifive.com>
9109
9110         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9111
9112 2019-01-02  Tom Tromey  <tom@tromey.com>
9113
9114         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9115         (tdesc_parse_xml): Remove cleanups.
9116         * target-descriptions.h (make_cleanup_free_target_description):
9117         Don't declare.
9118         (target_desc_deleter): New struct.
9119         (target_desc_up): New typedef.
9120         * target-descriptions.c (target_desc_deleter::operator()): Rename
9121         from free_target_description.
9122         (make_cleanup_free_target_description): Remove.
9123
9124 2019-01-02  Tom Tromey  <tom@tromey.com>
9125
9126         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9127         constructor, destructor.
9128         (linespec_parser): Remove typedef.
9129         (~linespec_parser): Rename from linespec_parser_delete.
9130         (linespec_lex_to_end, linespec_complete_label)
9131         (linespec_complete): Update.
9132         (decode_line_full): Remove cleanups.
9133         (decode_line_1): Update.
9134
9135 2019-01-02  Tom Tromey  <tom@tromey.com>
9136
9137         * python/python-internal.h (inferior_to_inferior_object): Change
9138         return type.
9139         * python/py-exitedevent.c (create_exited_event_object): Update.
9140         * python/py-inferior.c (inferior_to_inferior_object): Return
9141         gdbpy_ref.
9142         (python_new_inferior, python_inferior_deleted)
9143         (thread_to_thread_object, delete_thread_object)
9144         (build_inferior_list, gdbpy_selected_inferior): Update.
9145         * python/py-infthread.c (create_thread_object): Update.  Also fail
9146         if inferior_to_inferior_object fails.
9147
9148 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9149
9150         * inferior.h (class inferior) <displaced_step_state>: New field.
9151         * infrun.h (struct displaced_step_state): Move here from
9152         infrun.c.  Initialize fields, add constructor.
9153         <inf>: Remove field.
9154         <reset>: New method.
9155         * infrun.c (struct displaced_step_inferior_state): Move to
9156         infrun.h.
9157         (displaced_step_inferior_states): Remove.
9158         (get_displaced_stepping_state): Adust.
9159         (displaced_step_in_progress_any_inferior): Adjust.
9160         (displaced_step_in_progress_thread): Adjust.
9161         (displaced_step_in_progress): Adjust.
9162         (add_displaced_stepping_state): Remove.
9163         (get_displaced_step_closure_by_addr): Adjust.
9164         (remove_displaced_stepping_state): Remove.
9165         (infrun_inferior_exit): Call displaced_step_state.reset.
9166         (use_displaced_stepping): Don't check for NULL.
9167         (displaced_step_prepare_throw): Call
9168         get_displaced_stepping_state.
9169         (displaced_step_fixup): Don't check for NULL.
9170         (prepare_for_detach): Don't check for NULL.
9171
9172 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9173
9174         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9175          in case of call that did not complete.
9176
9177 2019-01-02  Andrey Utkin  <autkin@undo.io>
9178
9179         * symfile.c (find_separate_debug_file): Fix search of debug files for
9180         remote debuggee.
9181
9182 2019-01-02  Tom Tromey  <tom@tromey.com>
9183
9184         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9185         indentation.
9186         * python/py-frame.c (frapy_older): Remove cast.
9187         (frapy_newer): Likewise.
9188         * python/py-breakpoint.c (local_setattro): Remove cast.
9189         * python/py-arch.c (archpy_name): Remove local variable.
9190         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9191
9192 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9193
9194         * unittests/basic_string_view/element_access/char/empty.cc:
9195         Fix year range in copyright header.
9196
9197 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9198
9199         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9200         Delete.
9201         <operator==>: Update with for removed field.
9202         <hash>: Likewise.
9203         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9204         <isa_features>: ...this.
9205         <abi_features>: New field.
9206         (riscv_isa_flen): Update comment.
9207         (riscv_abi_xlen): New declaration.
9208         (riscv_abi_flen): New declaration.
9209         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9210         isa_features.
9211         (riscv_abi_xlen): New function.
9212         (riscv_isa_flen): Update to get answer from isa_features.
9213         (riscv_abi_flen): New function.
9214         (riscv_has_fp_abi): Update to get answer from abi_features.
9215         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9216         xlen and flen.
9217         (riscv_call_info) <xlen, flen>: Update comment.
9218         (riscv_call_arg_struct): Remove invalid assertions
9219         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9220         is removed.
9221         (riscv_gdbarch_init): Gather isa features and abi features
9222         separately, ensure both match on the gdbarch when reusing an old
9223         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9224         a target with 64-bit float hardware.
9225
9226 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9227
9228         * source.c (search_command_helper): Stop reverse search
9229         when line 1 has been searched.
9230
9231 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9232
9233         * record-full.c (record_full_base_target::close): Rewrite
9234         record_full_core_buf_list free logic.
9235
9236 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9237
9238         * break-catch-syscall.c (print_one_catch_syscall): xfree
9239         the last text.
9240
9241 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9242
9243         * top.c (print_gdb_version): Update Copyright year in version
9244         message.
9245
9246 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9247
9248         Update copyright year range in all GDB files.
9249
9250 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9251
9252         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9253
9254 For older changes see ChangeLog-2018.
9255 \f
9256 Local Variables:
9257 mode: change-log
9258 left-margin: 8
9259 fill-column: 74
9260 version-control: never
9261 coding: utf-8
9262 End:
9263