gdb/ChangeLog

   1 2019-05-27  Tom Tromey  <tom@tromey.com>
   2
   3         * NEWS: Fix typo.
   4
   5 2019-05-22  Tom Tromey  <tromey@adacore.com>
   6
   7         * target.c (target_follow_exec): Constify parameter.
   8         * target-delegates.c: Rebuild.
   9         * remote.c (remote_target::follow_exec): Constify parameter.
  10         * infrun.c (follow_exec): Constify parameter.
  11         * target.h (struct target_ops) <follow_exec>: Constify parameter.
  12         (target_follow_exec): Likewise.
  13
  14 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  15
  16         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
  17         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
  18
  19 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  20
  21         * NEWS: Add debugredirect and testsuite sections.
  22
  23 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
  24
  25         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
  26         target descriptions using exclusively floating point register name
  27         aliases.
  28
  29 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  30
  31         PR gdb/18644:
  32         * f-lang.c (build_fortran_types): Handle the case where
  33         gdbarch_floatformat_for_type returns a nullptr.
  34
  35 2019-05-21  Tom de Vries  <tdevries@suse.de>
  36
  37         PR cli/24587
  38         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  39
  40 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  41
  42         PR gdb/18644:
  43         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
  44         16-byte floats.
  45         * i386-tdep.c (i386_floatformat_for_type): Use
  46         floatformats_ia64_quad for the 16-byte floating point component
  47         within a fortran 32-byte complex number.
  48
  49 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  50
  51         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
  52         delete default constructor.
  53         (find_partial_die): Update to return const struct.
  54         (partial_die_parent_scope): Move variable declaration into scope
  55         of its use and change its type to auto.
  56         (guess_partial_die_structure_name): Likewise.
  57         (partial_die_info::fixup): Likewise.
  58
  59 2019-05-17  Tom Tromey  <tromey@adacore.com>
  60
  61         * source.c (find_and_open_source): Remove cast.
  62
  63 2019-05-17  Tom Tromey  <tromey@adacore.com>
  64
  65         * annotate.c (annotate_source): Make "filename" const.
  66         * annotate.h (annotate_source): Use const.
  67
  68 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  69
  70         * disasm.c (set_disassembler_options): Send errors to stderr.
  71
  72 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  73
  74         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  75         (cli_interp_base::set_logging): Check debug_redirect.
  76         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  77         * cli/cli-logging.c (debug_redirect): Add static variable.
  78         (pop_output_files): Add default param.
  79         (handle_redirections): Print debug setting.
  80         (show_logging_command): Likewise.
  81         (_initialize_cli_logging): Add debugredirect command.
  82         * interps.c (current_interp_set_logging): Add debug_redirect
  83         parameter.
  84         * interps.h (set_logging): Add debug_redirect parameter.
  85         (current_interp_set_logging): Likewise.
  86         * mi/mi-common.h: Likewise.
  87         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  88
  89 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  90             Tom Tromey  <tromey@adacore.com>
  91
  92         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  93         directly.
  94         * cli/cli-interp.h (make_logging_output): Remove declaration.
  95         * cli/cli-logging.c (make_logging_output): Remove function.
  96         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  97         directly.
  98         * ui-file.c (tee_file::tee_file): Remove bools.
  99         (tee_file::~tee_file): Remove deletes.
 100         * ui-file.h (tee_file): Remove bools.
 101
 102 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 103
 104         * mi/mi-cmds.h (mi_cmd_complete): New function.
 105         * mi/mi-main.c (mi_cmd_complete): Likewise.
 106         * mi/mi-cmds.c: Define new MI command -complete.
 107         * NEWS: Mention new -complete command.
 108
 109 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 110
 111         * completer.h (complete): New function.
 112         * completer.c (complete): Likewise.
 113         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 114         function defined in completer.h.
 115
 116 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 117
 118        * MAINTAINERS (Write After Approval): Add myself.
 119
 120 2019-05-17  Tom de Vries  <tdevries@suse.de>
 121
 122         PR gdb/24094
 123         * dwarf2read.c (struct cu_partial_die_info): New struct.
 124         (find_partial_die): Return cu_partial_die_info.
 125         (partial_die_parent_scope, guess_partial_die_structure_name)
 126         (partial_die_info::fixup): Handle new return type of find_partial_die.
 127
 128 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 129
 130         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 131         "std::string", simplifying the algorithm.
 132
 133 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 134
 135         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 136         (stap_static_probe_ops::get_probes): Likewise.
 137
 138 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 139
 140         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 141         '-')" and "else if".
 142         (stap_parse_single_operand): Join checks for
 143         "gdbarch_stap_parse_special_token_p" and
 144         "gdbarch_stap_parse_special_token" in the same "if" statement.
 145         Invert check when verifying for operation on register
 146         displacement.
 147
 148 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 149
 150         * stap-probe.c (stap_get_opcode): Update comment.
 151         (stap_get_expected_argument_type): Likewise.
 152         (handle_stap_probe): Likewise.
 153
 154 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 155
 156         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 157         return type to 'bool'.  Adjust comment.  Use 'bool' when
 158         appropriate.
 159         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 160         * stap-probe.c (stap_parse_argument_1): Likewise.
 161         (stap_is_operator): Likewise.
 162         (stap_is_generic_prefix): Likewise.
 163         (stap_is_register_prefix): Likewise.
 164         (stap_is_register_indirection_prefix): Likewise.
 165         (stap_is_integer_prefix): Likewise.
 166         (stap_generic_check_suffix): Likewise.
 167         (stap_check_integer_suffix): Likewise.
 168         (stap_check_register_suffix): Likewise.
 169         (stap_check_register_indirection_suffix): Likewise.
 170         (stap_parse_register_operand): Likewise.
 171         (stap_parse_single_operand): Likewise.
 172         (stap_parse_argument_1): Likewise.
 173         (stap_probe::get_argument_count): Likewise.
 174         (stap_is_operator): Likewise.
 175
 176 2019-05-16  Tom Tromey  <tromey@adacore.com>
 177
 178         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 179         keyword to foreach.
 180
 181 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 182
 183         * linux-thread-db.c (try_thread_db_load_1): Change return type
 184         to bool.
 185         (try_thread_db_load): Likewise.
 186         (try_thread_db_load_from_pdir_1): Likewise.
 187         (try_thread_db_load_from_pdir): Likewise.
 188         (try_thread_db_load_from_sdir): Likewise.
 189         (try_thread_db_load_from_dir): Likewise.
 190         (thread_db_load_search): Likewise.
 191         (has_libpthread): Likewise.
 192         (thread_db_load): Likewise.
 193
 194 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 195
 196         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 197         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 198         NULL, and complain/return if that's the case.
 199
 200 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 201
 202         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 203         (advance, posn, abstract_read_memory): New functions.
 204         [struct mem_read_abstraction]: New struct.
 205         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 206
 207 2019-05-14  Tom Tromey  <tromey@adacore.com>
 208
 209         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 210         value is not lval_memory.
 211
 212 2019-05-14  Tom Tromey  <tromey@adacore.com>
 213
 214         * solib.c (info_sharedlibrary_command): Style the file name.
 215
 216 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 217
 218         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 219         (aarch64_vnv_type): Likewise.
 220         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 221         * common/tdesc.c: Likewise.
 222         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 223         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 224         * features/aarch64-fpu.xml: Add ieee half view.
 225         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 226         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 227         * gdbtypes.h (struct builtin_type): Likewise.
 228         (struct objfile_type): Likewise.
 229
 230 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 231
 232         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 233         typo.
 234         * location.h (string_to_event_location): Likewise.
 235
 236 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 237
 238         GDB 8.3 released.
 239
 240 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 241
 242         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 243         New variable declaration.
 244         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 245         New variable.
 246         (print_one_breakpoint): Use ui_out::test_flags and new global
 247         variable to compute use_fixed_output.
 248         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 249         Remove.
 250         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 251         (mi_multi_location_breakpoint_output_fixed): Remove.
 252         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 253         new variable.
 254         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 255         fix_multi_location_breakpoint_output flag if version >= 3.
 256         * ui-out.h (enum ui_out_flag)
 257         <fix_multi_location_breakpoint_output>: New enumerator.
 258
 259 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 260
 261         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 262
 263 2019-05-10  Tom Tromey  <tromey@adacore.com>
 264
 265         * ada-lang.c (catch_ada_completer): New function.
 266         (_initialize_ada_language): Use it.
 267
 268 2019-05-10  Tom Tromey  <tromey@adacore.com>
 269
 270         * thread.c (print_thread_info): Make "requested_threads" const.
 271         * gdbthread.h (print_thread_info): Make "requested_threads"
 272         const.
 273         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 274         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 275
 276 2019-05-08  Tom Tromey  <tom@tromey.com>
 277
 278         * gdbtypes.c (objfile_type_data): Change type.
 279         (objfile_type, _initialize_gdbtypes): Update.
 280
 281 2019-05-08  Tom Tromey  <tom@tromey.com>
 282
 283         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 284         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 285         (_initialize_dwarf2_frame): Update.
 286
 287 2019-05-08  Tom Tromey  <tom@tromey.com>
 288
 289         * objc-lang.c (objc_objfile_data): Change type.
 290         (find_methods): Update.
 291         (_initialize_objc_lang): Remove.
 292
 293 2019-05-08  Tom Tromey  <tom@tromey.com>
 294
 295         * stabsread.c (rs6000_builtin_type_data): Change type.
 296         (rs6000_builtin_type, _initialize_stabsread): Update.
 297
 298 2019-05-08  Tom Tromey  <tom@tromey.com>
 299
 300         * mips-tdep.c (mips_pdr_data): Remove.
 301         (_initialize_mips_tdep): Update.
 302
 303 2019-05-08  Tom Tromey  <tom@tromey.com>
 304
 305         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 306         (hppa_init_objfile_priv_data, read_unwind_info)
 307         (find_unwind_entry, _initialize_hppa_tdep): Update.
 308
 309 2019-05-08  Tom Tromey  <tom@tromey.com>
 310
 311         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 312         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 313         on obstack.
 314         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 315
 316 2019-05-08  Tom Tromey  <tom@tromey.com>
 317
 318         * mdebugread.c (basic_type_data): Change type.
 319         (basic_type, _initialize_mdebugread): Update.
 320
 321 2019-05-08  Tom Tromey  <tom@tromey.com>
 322
 323         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 324
 325 2019-05-08  Tom Tromey  <tom@tromey.com>
 326
 327         * nto-tdep.c (nto_inferior_data_reg): Change type.
 328         (nto_inferior_data): Update.
 329         (nto_inferior_data_cleanup, nto_new_inferior_data)
 330         (_initialize_nto_tdep): Remove.
 331         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 332
 333 2019-05-08  Tom Tromey  <tom@tromey.com>
 334
 335         * ada-lang.c (struct ada_inferior_data): Add initializers.
 336         (ada_inferior_data): Change type.
 337         (ada_inferior_data_cleanup): Remove.
 338         (get_ada_inferior_data, ada_inferior_exit)
 339         (struct ada_pspace_data): Add initializers, destructor.
 340         (ada_pspace_data_handle): Change type.
 341         (get_ada_pspace_data): Update.
 342         (ada_pspace_data_cleanup): Remove.
 343
 344 2019-05-08  Tom Tromey  <tom@tromey.com>
 345
 346         * coffread.c (struct coff_symfile_info): Add initializers.
 347         (coff_objfile_data_key): Move lower.  Change type.
 348         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 349         Update.
 350         (coff_free_info): Remove.
 351
 352 2019-05-08  Tom Tromey  <tom@tromey.com>
 353
 354         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 355         (fbsd_pspace_data_handle): Move lower.  Change type.
 356         (get_fbsd_pspace_data): Update.
 357         (fbsd_pspace_data_cleanup): Remove.
 358         (_initialize_fbsd_tdep): Update.
 359
 360 2019-05-08  Tom Tromey  <tom@tromey.com>
 361
 362         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 363         (get_ada_tasks_pspace_data): Update.
 364         (ada_tasks_pspace_data_cleanup): Remove.
 365         (_initialize_tasks): Update.
 366         (ada_tasks_inferior_data_handle): Change type.
 367         (get_ada_tasks_inferior_data): Update.
 368         (ada_tasks_inferior_data_cleanup): Remove.
 369         (struct ada_tasks_pspace_data): Add initializers.
 370
 371 2019-05-08  Tom Tromey  <tom@tromey.com>
 372
 373         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 374         * symfile-debug.c (debug_sym_get_probes): Change type.
 375         * stap-probe.c (handle_stap_probe):
 376         (stap_static_probe_ops::get_probes): Change type.
 377         * probe.h (class static_probe_ops) <get_probes>: Change type.
 378         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 379         (parse_probes_in_pspace): Update.
 380         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 381         Update.
 382         (any_static_probe_ops::get_probes): Change type.
 383         * elfread.c (elfread_data): New typedef.
 384         (probe_key): Change type.
 385         (elf_get_probes): Likewise.  Update.
 386         (probe_key_free): Remove.
 387         (_initialize_elfread): Update.
 388         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 389         Change type.
 390         (dtrace_process_dof_probe, dtrace_process_dof)
 391         (dtrace_static_probe_ops::get_probe): Change type.
 392
 393 2019-05-08  Tom Tromey  <tom@tromey.com>
 394
 395         * xcoffread.c (struct xcoff_symfile_info): Rename from
 396         coff_symfile_info.  Add initializers.
 397         (xcoff_objfile_data_key): Move lower.  Change type.
 398         (XCOFF_DATA): Rewrite.
 399         (xcoff_free_info): Remove.
 400         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 401         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 402         (xcoff_initial_scan): Update.
 403
 404 2019-05-08  Tom Tromey  <tom@tromey.com>
 405
 406         * solib-svr4.c (struct svr4_info): Add initializers and
 407         destructor.
 408         <probes_table>: Now an htab_up.
 409         (solib_svr4_pspace_data): Change type.
 410         (free_probes_table): Simplify.
 411         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 412         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 413         (probes_table_remove_objfile_probes, register_solib_event_probe)
 414         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 415         (_initialize_svr4_solib): Update.
 416
 417 2019-05-08  Tom Tromey  <tom@tromey.com>
 418
 419         * remote.c (remote_pspace_data): Change type.
 420         (remote_pspace_data_cleanup): Remove.
 421         (get_remote_exec_file, set_pspace_remote_exec_file)
 422         (_initialize_remote): Update.
 423
 424 2019-05-08  Tom Tromey  <tom@tromey.com>
 425
 426         * breakpoint.c (breakpoint_objfile_key): Change type.
 427         (get_breakpoint_objfile_data): Update.
 428         (free_breakpoint_objfile_data): Remove.
 429         (_initialize_breakpoint): Update.
 430
 431 2019-05-08  Tom Tromey  <tom@tromey.com>
 432
 433         * linux-tdep.c (struct linux_info): Add initializers.
 434         (linux_inferior_data): Move.  Change type.
 435         (invalidate_linux_cache_inf): Update.
 436         (linux_inferior_data_cleanup): Remove.
 437         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 438
 439 2019-05-08  Tom Tromey  <tom@tromey.com>
 440
 441         * auxv.c (auxv_inferior_data): Move.  Change type.
 442         (auxv_inferior_data_cleanup): Remove.
 443         (invalidate_auxv_cache_inf): Rewrite.
 444         (get_auxv_inferior_data, _initialize_auxv): Update.
 445
 446 2019-05-08  Tom Tromey  <tom@tromey.com>
 447
 448         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 449         (symfile_debug_objfile_data_key): Change type.
 450         (symfile_debug_installed, debug_qf_has_symbols)
 451         (debug_qf_find_last_source_symtab)
 452         (debug_qf_forget_cached_source_info)
 453         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 454         (debug_qf_print_stats, debug_qf_dump)
 455         (debug_qf_expand_symtabs_for_function)
 456         (debug_qf_expand_all_symtabs)
 457         (debug_qf_expand_symtabs_with_fullname)
 458         (debug_qf_map_matching_symbols)
 459         (debug_qf_expand_symtabs_matching)
 460         (debug_qf_find_pc_sect_compunit_symtab)
 461         (debug_qf_map_symbol_filenames)
 462         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 463         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 464         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 465         (debug_sym_read_linetable, debug_sym_relocate): Update.
 466         (symfile_debug_free_objfile): Remove.
 467         (install_symfile_debug_logging, _initialize_symfile_debug):
 468         Update.
 469
 470 2019-05-08  Tom Tromey  <tom@tromey.com>
 471
 472         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 473         allocate_on_obstack.
 474         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 475         (get_dwarf2_per_objfile): Update.
 476         (set_dwarf2_per_objfile): Remove.
 477         (dwarf2_has_info, dwarf2_get_section_info): Update.
 478         (dwarf2_free_objfile): Remove.
 479         (_initialize_dwarf2_read): Update.
 480
 481 2019-05-08  Tom Tromey  <tom@tromey.com>
 482
 483         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 484         initializers.
 485         <unsupported_script_warning_printed,
 486         script_not_found_warning_printed>: Now bool.
 487         (auto_load_pspace_data): Change type.
 488         (~auto_load_pspace_info): Rename from
 489         auto_load_pspace_data_cleanup.
 490         (get_auto_load_pspace_data, init_loaded_scripts_info)
 491         (clear_section_scripts, maybe_print_unsupported_script_warning)
 492         (maybe_print_script_not_found_warning, _initialize_auto_load):
 493         Update.
 494
 495 2019-05-08  Tom Tromey  <tom@tromey.com>
 496
 497         * objfiles.c (objfile_pspace_info): Add destructor and
 498         initializers.
 499         (objfiles_pspace_data): Change type.
 500         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 501         (get_objfile_pspace_data): Update.
 502         (objfiles_bfd_data): Change type.
 503         (get_objfile_bfd_data): Update.
 504         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 505
 506 2019-05-08  Tom Tromey  <tom@tromey.com>
 507
 508         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 509         Change type.
 510         (get_catch_syscall_inferior_data): Update.
 511         (catch_syscall_inferior_data_cleanup): Remove.
 512         (_initialize_break_catch_syscall): Update.
 513
 514 2019-05-08  Tom Tromey  <tom@tromey.com>
 515
 516         * inflow.c (struct terminal_info): Add destructor and
 517         initializers.
 518         (inflow_inferior_data): Change type.
 519         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 520         (get_inflow_inferior_data, inflow_inferior_exit)
 521         (swap_terminal_info, _initialize_inflow): Update.
 522
 523 2019-05-08  Tom Tromey  <tom@tromey.com>
 524
 525         * target-dcache.c (target_dcache_cleanup): Remove.
 526         (target_dcache_aspace_key): Change type.
 527         (target_dcache_init_p, target_dcache_invalidate)
 528         (target_dcache_get, target_dcache_get_or_init)
 529         (_initialize_target_dcache): Update.
 530         * dcache.h (struct dcache_deleter): New.
 531
 532 2019-05-08  Tom Tromey  <tom@tromey.com>
 533
 534         * symtab.c (struct symbol_cache): Add destructor and
 535         initializers.
 536         (symbol_cache_key): Move.  Change type.
 537         (make_symbol_cache, free_symbol_cache): Remove.
 538         (get_symbol_cache): Update.
 539         (symbol_cache_cleanup): Remove.
 540         (ALL_PSPACES, symbol_cache_flush)
 541         (maintenance_print_symbol_cache)
 542         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 543         Update.
 544
 545 2019-05-08  Tom Tromey  <tom@tromey.com>
 546
 547         * symtab.c (struct main_info): Add destructor and initializers.
 548         (main_progspace_key): Move.  Change type.
 549         (get_main_info): Update.
 550         (main_info_cleanup): Remove.
 551         (_initialize_symtab): Update.
 552
 553 2019-05-08  Tom Tromey  <tom@tromey.com>
 554
 555         * registry.h (DECLARE_REGISTRY): Define the _key class.
 556
 557 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 558
 559         * NEWS: Merge two 'New commands' sections.
 560
 561 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 562
 563         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 564         parameter and use Ada language definition instead.
 565         (ada_val_print_ptr): Remove unused language parameter.
 566         (ada_val_print_num): Remove language parameter and use Ada language
 567         definition instead.
 568         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 569         parameter.
 570         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 571         parameter and use Ada language definition instead.
 572         (ada_val_print_1): Update all ada_val_print_xxx calls.
 573         Remove language parameter.
 574         (ada_val_print): Update ada_val_print_1 call.
 575
 576 2019-05-08  Tom Tromey  <tromey@adacore.com>
 577
 578         * remote.c (remote_hw_watchpoint_limit)
 579         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 580         Now static.
 581
 582 2019-05-08  Tom Tromey  <tromey@adacore.com>
 583
 584         * maint.c (_initialize_maint_cmds): Move initialization code to
 585         remote.c.
 586         (watchdog, show_watchdog): Move to remote.c.
 587         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 588         "watchdog" static.
 589         (_initialize_remote): Move initialization code from maint.c.
 590         * defs.h (watchdog): Don't declare.
 591
 592 2019-05-08  Tom Tromey  <tromey@adacore.com>
 593
 594         * tui/tui-interp.c: Include main.h.
 595         * interps.c: Include main.h.
 596         * main.h (interpreter_p): Declare.
 597         * defs.h (interpreter_p): Don't declare.
 598
 599 2019-05-08  Tom Tromey  <tromey@adacore.com>
 600
 601         * dwarf2loc.c: Include dwarf2read.h.
 602         * defs.h (read_unsigned_leb128): Don't declare.
 603         * dwarf2read.h (read_unsigned_leb128): Declare.
 604
 605 2019-05-08  Tom Tromey  <tromey@adacore.com>
 606
 607         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 608         method.
 609
 610 2019-05-08  Tom Tromey  <tromey@adacore.com>
 611
 612         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 613         when no wrap column is set.
 614
 615 2019-05-08  Tom Tromey  <tromey@adacore.com>
 616
 617         * c-lang.c (c_get_string): Handle non-C-style arrays.
 618
 619 2019-05-08  Tom Tromey  <tromey@adacore.com>
 620
 621         * typeprint.c (print_offset_data::update): Print the bit offset,
 622         not the number of bits remaining.
 623
 624 2019-05-08  Tom Tromey  <tromey@adacore.com>
 625
 626         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 627         padding at end of comment.
 628
 629 2019-05-08  Tom Tromey  <tromey@adacore.com>
 630
 631         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 632         Compare main types.
 633
 634 2019-05-06  Tom Tromey  <tom@tromey.com>
 635
 636         * common/scoped_mmap.c: Include common-defs.h.
 637         * common/scoped_mmap.h: Don't include config.h.
 638
 639 2019-05-04  Tom Tromey  <tom@tromey.com>
 640
 641         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 642         (struct aarch64_call_info): Add initializers.
 643         <si>: Now a std::vector.
 644         (pass_on_stack, aarch64_push_dummy_call): Update.
 645
 646 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 647             Tom Tromey  <tom@tromey.com>
 648
 649         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 650         (ppc_threads): Now a std::vector.  Now static.
 651         (hwdebug_find_thread_points_by_tid)
 652         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 653         Update.
 654
 655 2019-05-04  Tom Tromey  <tom@tromey.com>
 656
 657         * arc-tdep.c (arc_tdesc_init): Return bool.
 658
 659 2019-05-04  Tom Tromey  <tom@tromey.com>
 660
 661         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 662         Use gdb_assert_not_reached.
 663
 664 2019-05-04  Tom Tromey  <tom@tromey.com>
 665
 666         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 667         "false".
 668
 669 2019-05-04  Tom Tromey  <tom@tromey.com>
 670
 671         * arc-tdep.c (arc_tdesc_init): Use bool.
 672
 673 2019-05-04  Tom Tromey  <tom@tromey.com>
 674
 675         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 676
 677 2019-05-04  Tom Tromey  <tom@tromey.com>
 678
 679         * cli/cli-cmds.c (valid_command_p): Return bool.
 680
 681 2019-05-04  Tom Tromey  <tom@tromey.com>
 682
 683         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 684         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 685
 686 2019-05-04  Raul Tambre  <raul@tambre.ee>
 687
 688         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 689         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 690         operator for comparison.
 691
 692 2019-05-04  Tom Tromey  <tom@tromey.com>
 693
 694         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 695         (lookup_partial_symbol, print_partial_symbols)
 696         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 697         (psymbol_compare): Update.
 698         (add_psymbol_to_bcache): Clear the entire psymbol.
 699         (maintenance_check_psymtabs): Update.
 700         * psympriv.h (struct partial_symbol): Don't derive from
 701         general_symbol_info.
 702         <obj_section, unrelocated_address, address,
 703         set_unrelocated_address>: Update.
 704         <ginfo>: New member.
 705         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 706         (debug_names::write_psymbols): Update.
 707
 708 2019-05-04  Tom de Vries  <tdevries@suse.de>
 709
 710         * contrib/cc-with-tweaks.sh: Support -n arg.
 711
 712 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 713
 714         * corelow.c (core_target::detach): Ensure frame cache and
 715         register caches are cleared.
 716         inferior.c (exit_inferior_1): Likewise.
 717
 718 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 719             Tom Tromey  <tom@tromey.com>
 720
 721         * dictionary.c (collate_pending_symbols_by_language): Remove
 722         "struct" from foreach.
 723         * symtab.c (lookup_global_symbol_from_objfile)
 724         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 725         foreach.
 726         * ser-tcp.c (net_open): Remove "struct" from foreach.
 727         * objfiles.c (objfile_relocate, objfile_rebase)
 728         (objfile_has_symbols): Remove "struct" from foreach.
 729         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 730         from foreach.
 731         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 732         foreach.
 733         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 734         "struct" from foreach.
 735         * ada-lang.c (create_excep_cond_exprs)
 736         (ada_exception_catchpoint_cond_string): Remove "struct" from
 737         foreach.
 738
 739 2019-05-03  Tom Tromey  <tromey@adacore.com>
 740
 741         * ada-exp.y (convert_char_literal): Check suffix of each
 742         enumerator.
 743
 744 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 745
 746         PR ada/21406:
 747         * ada-exp.y (yywrap): Don't define.
 748         * ada-lex.l (%option): Add noyywrap
 749         (yywrap): Remove.
 750
 751 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 752
 753         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 754         _WIN32_WINNT to the XP level, unless already defined to a higher
 755         level.
 756
 757         * unittests/parse-connection-spec-selftests.c:
 758         * ser-tcp.c:
 759         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 760         override.
 761
 762         * symfile.c (find_separate_debug_file): Remove colon from the
 763         drive spec of DOS/Windows file names of the target, so that the
 764         file name produced from DEBUGDIR and the target's directory will
 765         be valid on DOS/Windows systems.
 766
 767 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * rust-lang.c (val_print_struct): Handle printing structures
 770         containing strings.
 771
 772 2019-05-02  Tom Tromey  <tromey@adacore.com>
 773
 774         * valarith.c (_initialize_valarith): Remove.
 775
 776 2019-05-01  Tom Tromey  <tromey@adacore.com>
 777
 778         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 779         bitfields.
 780
 781 2019-05-01  Tom Tromey  <tromey@adacore.com>
 782
 783         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 784         for big-endian copies.
 785
 786 2019-04-30  Ali Tamur  <tamur@google.com>
 787         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 788         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 789         (read_3_bytes): New function.
 790
 791 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 792
 793         * windows-nat.c (main_thread_id): Delete.
 794         (handle_output_debug_string): Replace main_thread_id by
 795         current_event.dwThreadId.
 796         (fake_create_process): Likewise.
 797         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 798         Do not set main_thread_id.
 799         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 800         current_event.dwThreadId.
 801         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 802
 803 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 804
 805         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 806         Use current_event.dwThreadId instead of main_thread_id.
 807
 808 2019-04-30  Tom Tromey  <tromey@adacore.com>
 809
 810         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 811         (create_excep_cond_exprs): Iterate over program spaces.
 812         (ada_exception_catchpoint_cond_string): Examine all minimal
 813         symbols for exception types.
 814
 815 2019-04-30  Tom Tromey  <tromey@adacore.com>
 816
 817         PR c++/24470:
 818         * dwarf2read.c (process_structure_scope): Handle case where type
 819         has template parameters but no symbol was created.
 820
 821 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 822             Chris January  <chris.january@arm.com>
 823
 824         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 825         qualifier.
 826         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 827
 828 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         * f-typeprint.c (f_print_type): Update rules for printing
 831         whitespace.
 832         (f_type_print_varspec_suffix): Likewise.
 833
 834 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 835             Chris January  <chris.january@arm.com>
 836
 837         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 838         function arguments.
 839
 840 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         * f-lang.c (build_fortran_types): Change name of void type to
 843         lower case.
 844         * f-typeprint.c (f_type_print_base): Print the name of the void
 845         type, rather than a fixed string.
 846         * f-valprint.c (f_decorations): Use lower case void string.
 847
 848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 849             Chris January  <chris.january@arm.com>
 850
 851         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 852         types for Fortran.
 853
 854 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 855             Chris January  <chris.january@arm.com>
 856             David Lecomber  <david.lecomber@arm.com>
 857
 858         * f-exp.y (BINOP_INTRINSIC): New token.
 859         (exp): New parser rule handling BINOP_INTRINSIC.
 860         (f77_keywords): Add new builtin procedures.
 861         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 862         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 863         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 864         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 865         (print_unop_subexp_f): New function.
 866         (print_binop_subexp_f): New function.
 867         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 868         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 869         (dump_subexp_body_f): Likewise.
 870         (operator_check_f): Likewise.
 871         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 872         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 873
 874 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 877         UNOP_KIND.
 878         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 879         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 880         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 881         (operator_length_f): New fuction.
 882         (print_subexp_f): New function.
 883         (op_name_f): New function.
 884         (dump_subexp_body_f): New function.
 885         (operator_check_f): New function.
 886         (exp_descriptor_f): Replace standard expression handling functions
 887         with new functions.
 888         * gdb/fortran-operator.def: New file.
 889         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 890         * gdb/std-operator.def: Remove UNOP_KIND.
 891
 892 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 893
 894         * std-operator.def: Remove unbalanced, stray double quote
 895         character.
 896
 897 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 898             Chris January  <chris.january@arm.com>
 899             Daniel Everett  <daniel.everett@arm.com>
 900             Nick Forrington  <nick.forrington@arm.com>
 901             Richard Bunt  <richard.bunt@arm.com>
 902
 903         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 904         of depth when printing anonymous structs or unions.
 905         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 906         Don't print either the top-level value, or the children if the
 907         max-depth is exceeded.
 908         (ppscm_print_children): When printing the key of a map, allow one
 909         extra level of depth.
 910         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 911         print either the top-level value, or the children if the max-depth
 912         is exceeded.
 913         (print_children): When printing the key of a map, allow one extra
 914         level of depth.
 915         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 916         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 917         (user_print_options): Initialise max_depth field.
 918         (val_print_scalar_or_string_type_p): New function.
 919         (val_print): Check to see if the max depth has been reached.
 920         (val_print_check_max_depth): Define new function.
 921         (show_print_max_depth): New function.
 922         (_initialize_valprint): Add 'print max-depth' option.
 923         * valprint.h (struct value_print_options) <max_depth>: New field.
 924         (val_print_check_max_depth): Declare new function.
 925         * NEWS: Document new feature.
 926
 927 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * ada-lang.c (ada_language_defn): Initialise new field.
 930         * c-lang.c (c_is_string_type_p): New function.
 931         (c_language_defn): Initialise new field.
 932         (cplus_language_defn): Initialise new field.
 933         (asm_language_defn): Initialise new field.
 934         (minimal_language_defn): Initialise new field.
 935         * c-lang.h (c_is_string_type_p): Declare new function.
 936         * d-lang.c (d_language_defn): Initialise new field.
 937         * f-lang.c (f_is_string_type_p): New function.
 938         (f_language_defn): Initialise new field.
 939         * go-lang.c (go_is_string_type_p): New function.
 940         (go_language_defn): Initialise new field.
 941         * language.c (default_is_string_type_p): New function.
 942         (unknown_language_defn): Initialise new field.
 943         (auto_language_defn): Initialise new field.
 944         * language.h (struct language_defn) <la_is_string_type_p>: New
 945         member variable.
 946         (default_is_string_type_p): Declare new function.
 947         * m2-lang.c (m2_language_defn): Initialise new field.
 948         * objc-lang.c (objc_language_defn): Initialise new field.
 949         * opencl-lang.c (opencl_language_defn): Initialise new field.
 950         * p-lang.c (pascal_is_string_type_p): New function.
 951         (pascal_language_defn): Initialise new field.
 952         * rust-lang.c (rust_is_string_type_p): New function.
 953         (rust_language_defn): Initialise new field.
 954
 955 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 956
 957         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 958         New field.
 959         * ada-lang.c (ada_language_defn): Initialise new field.
 960         * c-lang.c (c_language_defn): Likewise.
 961         (cplus_language_defn): Likewise.
 962         (asm_language_defn): Likewise.
 963         (minimal_language_defn): Likewise.
 964         * d-lang.c (d_language_defn): Likewise.
 965         * f-lang.c (f_language_defn): Likewise.
 966         * go-lang.c (go_language_defn): Likewise.
 967         * language.c (unknown_language_defn): Likewise.
 968         (auto_language_defn): Likewise.
 969         * m2-lang.c (m2_language_defn): Likewise.
 970         * objc-lang.c (objc_language_defn): Likewise.
 971         * opencl-lang.c (opencl_language_defn): Likewise.
 972         * p-lang.c (pascal_language_defn): Likewise.
 973         * rust-lang.c (rust_language_defn): Likewise.
 974
 975 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 976
 977         * ada-lang.c (ada_is_character_type): Change return type to bool.
 978         (ada_is_string_type): Likewise.
 979         * ada-lang.h (ada_is_character_type): Update declaration
 980         (ada_is_string_type): Likewise.
 981
 982 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 983
 984         Support style in 'frame|thread apply'
 985
 986         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 987         * record.c (record_start, record_stop): Update callers of
 988         execute_command_to_string with false.
 989         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 990         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 991         methods.
 992         (class string_file): New constructor with term_out parameter.
 993         Override methods term_out and can_emit_style_escape.  New member
 994         term_out.
 995         (class stdio_file): Override can_emit_style_escape.
 996         (class tee_file): Override term_out and can_emit_style_escape.
 997         * utils.h (can_emit_style_escape): Remove.
 998         * utils.c (can_emit_style_escape): Likewise.
 999         Update all callers of can_emit_style_escape (SOMESTREAM) to
1000         SOMESTREAM->can_emit_style_escape.
1001         * source-cache.c (source_cache::get_source_lines): Likewise.
1002         * stack.c (frame_apply_command_count): Call execute_command_to_string
1003         passing the term_out characteristic of the current gdb_stdout.
1004         * thread.c (thr_try_catch_cmd): Likewise.
1005         * top.c (execute_command_to_string): pass term_out parameter
1006         to construct the string_file for the command output.
1007         * ui-file.c (term_cli_styling): New function (most code moved
1008         from utils.c can_emit_style_escape).
1009         (string_file::string_file, string_file::can_emit_style_escape,
1010         stdio_file::can_emit_style_escape, tee_file::term_out,
1011         tee_file::can_emit_style_escape): New functions.
1012
1013 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1014
1015         * NEWS: Mention the new set|show may-call-functions.
1016         * infcall.c (may_call_functions_p): New variable.
1017         (show_may_call_functions_p): New function.
1018         (call_function_by_hand_dummy): Throws an error if not
1019         may-call-functions.
1020         (_initialize_infcall): Call add_setshow_boolean_cmd for
1021         may-call-functions.
1022
1023 2019-04-25  Keith Seitz  <keiths@redhat.com>
1024
1025         PR c++/24367
1026         * cp-support.c (inspect_type): Don't attempt substitutions
1027         of symbol with the same name.
1028
1029 2019-04-25  Tom Tromey  <tromey@adacore.com>
1030
1031         PR gdb/24475:
1032         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1033         static.
1034
1035 2019-04-25  Tom Tromey  <tromey@adacore.com>
1036
1037         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1038         rvalue reference.
1039         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1040         (gdb_xml_parser::parse): Use std::move.
1041         * python/python-internal.h (gdbpy_convert_exception): Take a const
1042         reference.
1043         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1044         std::move.
1045         * python/py-utils.c (gdbpy_convert_exception): Take a const
1046         reference.
1047         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1048         Use std::move.
1049         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1050         Use std::move.
1051         * mi/mi-main.c (mi_print_exception): Take a const reference.
1052         * main.c (handle_command_errors): Take a const reference.
1053         * linespec.c (parse_linespec): Use std::move.
1054         * infcall.c (run_inferior_call): Use std::move.
1055         (call_function_by_hand_dummy): Use std::move.
1056         * exec.c (try_open_exec_file): Use std::move.
1057         * exceptions.h (exception_print, exception_fprintf)
1058         (exception_print_same): Update.
1059         * exceptions.c (print_exception, exception_print)
1060         (exception_fprintf, exception_print_same): Change parameters to
1061         const reference.
1062         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1063         * common/new-op.c: Use std::move.
1064         * common/common-exceptions.h (struct gdb_exception): Add move
1065         constructor.
1066         (struct gdb_exception_error, struct gdb_exception_quit, struct
1067         gdb_quit_bad_alloc): Change constructor to move constructor.
1068         (throw_exception): Change parameter to rvalue reference.
1069         * common/common-exceptions.c (throw_exception): Take rvalue
1070         reference.
1071         * cli/cli-interp.c (safe_execute_command): Use std::move.
1072         * breakpoint.c (insert_bp_location, location_to_sals): Use
1073         std::move.
1074
1075 2019-04-25  Tom Tromey  <tromey@adacore.com>
1076
1077         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1078         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1079         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1080         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1081         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1082         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1083         guile/scm-value.c: Use unpack.
1084         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1085         gdbscm_gdb_exception.
1086         (gdbscm_throw_gdb_exception): Likewise.
1087         (struct gdbscm_gdb_exception): New.
1088         (unpack): New function.
1089         (gdbscm_wrap): Use unpack.
1090
1091 2019-04-25  Tom Tromey  <tromey@adacore.com>
1092
1093         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1094         (gdb_rl_callback_handler): Use std::move.
1095         * common/common-exceptions.h (struct gdb_exception): Add move
1096         assignment operator.
1097         (throw_exception_sjlj): Change "exception" to const reference.
1098         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1099         (throw_exception_sjlj): Change "exception" to const reference.
1100
1101 2019-04-25  Tom Tromey  <tromey@adacore.com>
1102
1103         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1104         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1105         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1106         Update.
1107         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1108         Update.
1109         * mi/mi-interp.c (mi_interp::exec): Update.
1110         * linespec.c (parse_linespec): Update.
1111         * infcall.c (run_inferior_call): Update.
1112         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1113         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1114         (gdbscm_lookup_global_symbol): Update.
1115         * guile/scm-param.c (gdbscm_parameter_value): Update.
1116         * guile/scm-frame.c (gdbscm_frame_read_register)
1117         (gdbscm_frame_read_var): Update.
1118         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1119         * exec.c (try_open_exec_file): Update.
1120         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1121         (gdb_rl_callback_handler): Update.
1122         * common/common-exceptions.h (exception_none): Don't declare.
1123         * common/common-exceptions.c (exception_none): Don't define.
1124         (struct catcher) <exception>: Update.
1125         * cli/cli-interp.c (safe_execute_command): Update.
1126         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1127
1128 2019-04-25  Ali Tamur  <tamur@google.com>
1129
1130         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1131         (read_attribute_value): Likewise.
1132         (dwarf2_read_addr_index): Update comment.
1133         (read_str_index): Add DW_FORM_strx.
1134         (dwarf2_string_attr): Likewise.
1135         (dwarf2_const_value_attr): Likewise.
1136         (dump_die_shallow): Likewise.
1137         (dwarf2_fetch_constant_bytes): Likewise.
1138         (skip_form_bytes): Likewise.
1139         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1140
1141 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1142
1143         PR corefiles/11608
1144         PR corefiles/18187
1145         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1146         OFFSET.  Verify if current mapping contains an ELF header.
1147         (linux_find_memory_regions_full): Adjust call to
1148         dump_mapping_p.
1149
1150 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1151             Kang Li <kanglictf@gmail.com>
1152
1153         PR gdb/21600
1154
1155         * dwarf2-frame.c (read_initial_length): Be consistent about using
1156         unsigned representation of length.
1157         (decode_frame_entry_1): Likewise.  Check for wraparound of
1158         end pointer as well as buffer overflow.
1159
1160 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1161
1162         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1163         "vq".
1164
1165 2019-04-24  Tom Tromey  <tromey@adacore.com>
1166
1167         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1168
1169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * s12z-tdep.c (s12z_unwind_pc): Delete.
1172         (s12z_unwind_sp): Delete.
1173         (s12z_gdbarch_init): Don't register deleted functions with
1174         gdbarch.
1175
1176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * rl78-tdep.c (rl78_unwind_sp): Delete.
1179         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1180
1181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1182
1183         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1184         (xstormy16_unwind_pc): Delete.
1185         (xstormy16_dummy_id): Delete.
1186         (xstormy16_gdbarch_init): Don't register deleted functions with
1187         gdbarch.
1188
1189 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * vax-tdep.c (vax_unwind_pc): Delete.
1192         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1193
1194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1195
1196         * v850-tdep.c (v850_unwind_sp): Delete.
1197         (v850_unwind_pc): Delete.
1198         (v850_dummy_id): Delete.
1199         (v850_gdbarch_init): Don't register deleted functions with
1200         gdbarch.
1201
1202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1203
1204         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1205         (tilegx_unwind_pc): Delete.
1206         (tilegx_unwind_dummy_id): Delete.
1207         (tilegx_gdbarch_init): Don't register deleted functions with
1208         gdbarch.
1209
1210 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1213         (tic6x_dummy_id): Delete.
1214         (tic6x_gdbarch_init): Don't register deleted functions with
1215         gdbarch.
1216
1217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1218
1219         * sparc-tdep.c (sparc_unwind_pc): Delete.
1220         (sparc32_gdbarch_init): Don't register deleted function with
1221         gdbarch.
1222
1223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1224
1225         * sh-tdep.c (sh_unwind_sp): Delete.
1226         (sh_unwind_pc): Delete.
1227         (sh_dummy_id): Delete.
1228         (sh_gdbarch_init): Don't register deleted functions with
1229         gdbarch.
1230
1231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * score-tdep.c (score_unwind_sp): Delete.
1234         (score_unwind_pc): Delete.
1235         (score_dummy_id): Delete.
1236         (score_gdbarch_init): Don't register deleted functions with
1237         gdbarch.
1238
1239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * rx-tdep.c (rx_unwind_pc): Delete.
1242         (rx_unwind_sp): Delete.
1243         (rx_dummy_id): Delete.
1244         (rx_gdbarch_init): Don't register deleted functions with
1245         gdbarch.  Update comment.
1246
1247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1248
1249         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1250         (rs6000_dummy_id): Delete.
1251         (rs6000_gdbarch_init): Don't register deleted functions with
1252         gdbarch.
1253
1254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1255
1256         * or1k-tdep.c (or1k_dummy_id): Delete.
1257         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1258
1259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1260
1261         * nios2-tdep.c (nios2_dummy_id): Delete.
1262         (nios2_unwind_sp): Delete.
1263         (nios2_gdbarch_init): Don't register deleted functions with
1264         gdbarch.
1265
1266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1267
1268         * nds32-tdep.c (nds32_dummy_id): Delete.
1269         (nds32_unwind_pc): Delete.
1270         (nds32_unwind_sp): Delete.
1271         (nds32_gdbarch_init): Don't register deleted functions with
1272         gdbarch.
1273
1274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * msp430-tdep.c (msp430_unwind_pc): Delete.
1277         (msp430_unwind_sp): Delete.
1278         (msp430_dummy_id): Delete.
1279         (msp430_gdbarch_init): Don't register deleted functions with
1280         gdbarch.
1281
1282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * moxie-tdep.c (moxie_unwind_sp): Delete.
1285         (moxie_unwind_pc): Delete.
1286         (moxie_dummy_id): Delete.
1287         (moxie_gdbarch_init): Don't register deleted functions with
1288         gdbarch.
1289
1290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1291
1292         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1293         (mn10300_unwind_pc): Delete.
1294         (mn10300_unwind_sp): Delete.
1295         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1296         mn10300_unwind_sp.
1297         (mn10300_frame_unwind_init): Don't register deleted functions with
1298         gdbarch.
1299
1300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * mep-tdep.c (mep_unwind_pc): Delete.
1303         (mep_unwind_sp): Delete.
1304         (mep_dummy_id): Delete.
1305         (mep_gdbarch_init): Don't register deleted functions with
1306         gdbarch.
1307
1308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1311         (m68hc11_unwind_sp): Delete.
1312         (m68hc11_gdbarch_init): Don't register deleted functions with
1313         gdbarch.
1314
1315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         * m32r-tdep.c (m32r_unwind_sp): Delete.
1318         (m32r_unwind_pc): Delete.
1319         (m32r_dummy_id): Delete.
1320         (m32r_gdbarch_init): Don't register deleted functions with
1321         gdbarch.
1322
1323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * m32c-tdep.c (m32c_unwind_pc): Delete.
1326         (m32c_unwind_sp): Delete.
1327         (m32c_dummy_id): Delete.
1328         (m32c_gdbarch_init): Don't register deleted functions with
1329         gdbarch.
1330
1331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1334         (lm32_unwind_pc): Delete.
1335         (lm32_dummy_id): Delete.
1336         (lm32_gdbarch_init): Don't register deleted functions with
1337         gdbarch.
1338
1339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1340
1341         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1342         (iq2000_unwind_pc): Delete.
1343         (iq2000_dummy_id): Delete.
1344         (iq2000_gdbarch_init): Don't register deleted functions with
1345         gdbarch.
1346
1347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * nds32-tdep.c (nds32_type_align): Delete.
1350         (nds32_push_dummy_call): Use type_align instead.
1351
1352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1353
1354         * arm-tdep.c (arm_type_align): Only handle vector override case.
1355         (arm_push_dummy_call): Use type_align.
1356         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1357
1358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1359
1360         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1361         case.
1362         (pass_on_stack): Use type_align.
1363         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1364         function.
1365
1366 2019-04-23  Tom Tromey  <tromey@adacore.com>
1367
1368         * dwarf2read.c (line_header::file_name_at): Remove unused
1369         overload.
1370
1371 2019-04-23  Tom de Vries  <tdevries@suse.de>
1372
1373         PR gdb/24438
1374         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1375         invocation.
1376
1377
1378 2019-03-27  Ali Tamur  <tamur@google.com>
1379
1380         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1381         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1382         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1383         (dwarf_expr_context::get_addr_index): Likewise
1384         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1385         (symbol_needs_eval_context::get_addr_index): Likewise
1386         (disassemble_dwarf_expression): Add DW_OP_addrx
1387         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1388         (read_cutu_die_from_dwo): Update comment
1389         (skip_one_die): Add DW_FORM_addrx
1390         (read_attribute_value): Likewise
1391         (var_decode_location): Add DW_OP_addrx
1392         (dwarf2_const_value_attr): Add DW_FORM_addrx
1393         (dump_die_shallow): Likewise
1394         (dwarf2_fetch_constant_bytes): Likewise
1395         (decode_locdesc): Add DW_OP_addrx
1396         (skip_form_bytes): Add DW_FORM_addrx
1397
1398 2019-04-22  Ali Tamur  <tamur@google.com>
1399
1400         * MAINTAINERS (Write After Approval): Add self.
1401
1402 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1403
1404         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1405         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1406         (open_symbol_file_object): Likewise.
1407         (svr4_default_sos): Add info parameter.
1408         (svr4_read_so_list): Likewise.
1409         (svr4_current_sos_direct): Adjust functions calls to pass down
1410         info.
1411         (svr4_current_sos_1): Add info parameter.
1412         (svr4_current_sos): Call get_svr4_info, pass info down to
1413         svr4_current_sos_1.
1414         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1415         get_svr4_info.
1416         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1417         get_svr4_info.
1418         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1419         to get_svr4_info.
1420         (probes_table_remove_objfile_probes): Likewise.
1421         (register_solib_event_probe): Add info parameter.
1422         (solist_update_incremental): Pass info parameter down to
1423         svr4_read_so_list.
1424         (disable_probes_interface): Add info parameter.
1425         (svr4_handle_solib_event): Pass current_program_space to
1426         get_svr4_info.  Adjust disable_probes_interface cleanup.
1427         (svr4_create_probe_breakpoints): Add info parameter, pass it
1428         down to register_solib_event_probe.
1429         (svr4_create_solib_event_breakpoints): Add info parameter,
1430         pass it down to svr4_create_probe_breakpoints.
1431         (enable_break): Pass info down to
1432         svr4_create_solib_event_breakpoints.
1433         (svr4_solib_create_inferior_hook): Pass current_program_space to
1434         get_svr4_info.
1435         (svr4_clear_solib): Likewise.
1436
1437 2019-04-22  Pedro Alves  <palves@redhat.com>
1438
1439         * solib-svr4.c (svr4_free_objfile_observer): New.
1440         (probe_and_action::objfile): New field.
1441         (probes_table_htab_remove_objfile_probes)
1442         (probes_table_remove_objfile_probes): New functions.
1443         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1444         in the new probe_and_action.  Don't store the probe in 'lookup'.
1445         (svr4_create_probe_breakpoints): Pass objfile to
1446         register_solib_event_probe.
1447         (_initialize_svr4_solib): Register a free_objfile observer.
1448
1449 2019-04-19  Tom Tromey  <tom@tromey.com>
1450
1451         * common/queue.h: Remove.
1452
1453 2019-04-19  Tom Tromey  <tom@tromey.com>
1454
1455         * event-loop.c: Don't include "common/queue.h".
1456
1457 2019-04-19  Tom Tromey  <tom@tromey.com>
1458
1459         * remote.c (remote_target): Use delete.
1460         * remote-notif.h: Include <list>, not "common/queue.h".
1461         (notif_client_p): Remove typedef.
1462         (remote_notif_state): Add constructor, destructor, initializer.
1463         <notif_queue>: Now a std::list.
1464         (remote_notif_state_xfree): Don't declare.
1465         * remote-notif.c (remote_notif_process, handle_notification)
1466         (remote_notif_state_allocate): Update.
1467         (~remote_notif_state): Rename from remote_notif_state_xfree.
1468
1469 2019-04-19  Tom Tromey  <tom@tromey.com>
1470
1471         * symfile.c (reread_symbols): Update.
1472         * objfiles.c (objfile_register_static_link)
1473         (objfile_lookup_static_link): Update
1474         (~objfile) Don't delete static_links.
1475         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1476
1477 2019-04-19  Tom Tromey  <tom@tromey.com>
1478
1479         * type-stack.h (struct type_stack) <insert>: Constify string.
1480         * type-stack.c (type_stack::insert): Constify string.
1481         * gdbtypes.h (lookup_template_type): Update.
1482         (address_space_name_to_int): Update.
1483         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1484         const.
1485         (lookup_template_type): Make name const.
1486         * c-exp.y: Update rules.
1487         (lex_one_token, classify_name, classify_inner_name)
1488         (c_print_token): Update.
1489         * p-exp.y: Update rules.
1490         (yylex): Update.
1491         * f-exp.y: Update rules.
1492         (yylex): Update.
1493         * d-exp.y: Update rules.
1494         (lex_one_token, classify_name, classify_inner_name): Update.
1495         * parse.c (write_dollar_variable, copy_name): Return std::string.
1496         * parser-defs.h (copy_name): Change return type.
1497         * m2-exp.y: Update rules.
1498         (yylex): Update.
1499         * go-exp.y (lex_one_token): Update.
1500         Update rules.
1501         (classify_unsafe_function, classify_packaged_name)
1502         (classify_name, yylex): Update.
1503
1504 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1505
1506         * configure.ac: add --enable-source-highlight switch.
1507         * configure: Regenerate.
1508         * top.c (print_gdb_version): plumb --enable-source-highlight
1509         status to "show configuration".
1510
1511 2019-04-19  Tom Tromey  <tromey@adacore.com>
1512
1513         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1514         Check ADA_TYPE_P.
1515         (empty_record, ada_template_to_fixed_record_type_1)
1516         (template_to_static_fixed_type)
1517         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1518         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1519         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1520         macros.
1521
1522 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1523
1524         PR symtab/24423:
1525         * source.c (print_source_lines_base): Advance "iter" when a
1526         control character is seen.
1527
1528 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1529
1530         * inferior.h (struct infcall_suspend_state_deleter):
1531         Catch exception in destructor to avoid crash.
1532
1533 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1534
1535         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1536         close to the add_com "shell".
1537
1538 2019-04-18  Tom Tromey  <tromey@adacore.com>
1539
1540         * process-stratum-target.h (class process_stratum_target)
1541         <stratum>: Add "final".
1542
1543 2019-04-17  Tom Tromey  <tromey@adacore.com>
1544
1545         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1546         against nullptr before use.
1547
1548 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1549
1550         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1551
1552 2019-04-17  Jim Wilson  <jimw@sifive.com>
1553             Andrew Burgess  <andrew.burgess@embecosm.com>
1554
1555         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1556         code read might fail, assume 4-byte breakpoint in that case.
1557
1558 2019-04-15  Leszek Swirski  <leszeks@google.com>
1559
1560         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1561         rather than a hand-rolled POD check when checking for forced MEMORY
1562         classification.
1563
1564 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1565
1566         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1567         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1568         function.
1569         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1570         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1571         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1572         declaration.
1573
1574 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1575
1576         * aarch64-linux-nat.c
1577         (aarch64_linux_nat_target::thread_architecture): Add override.
1578         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1579         each VQ.
1580
1581 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1582
1583         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1584
1585 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1588         target types of size 96-bits, add some additional comments, and
1589         check that the builtin type we found was the correct size.
1590
1591 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1592
1593         * utils.c (prompt_for_continue): Don't restore the styling at the
1594         end, as applied_style has the wrong value.  This fixes styling in
1595         long lists of file names that are interrupted by the "Continue?"
1596         prompt.
1597
1598 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1599
1600         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1601         * c-lang.c (c_language_defn): Likewise.
1602         (cplus_language_defn): Likewise.
1603         (asm_language_defn): Likewise.
1604         (minimal_language_defn): Likewise.
1605         * d-lang.c (d_language_defn): Likewise.
1606         * f-lang.c (f_language_defn): Likewise.
1607         * go-lang.c (go_language_defn): Likewise.
1608         * language.c (unknown_language_defn): Likewise.
1609         (auto_language_defn): Likewise.
1610         * language.h (struct language_defn): Remove la_magic field.
1611         (LANG_MAGIC): Delete.
1612         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1613         * objc-lang.c (objc_language_defn): Likewise.
1614         * opencl-lang.c (opencl_language_defn): Likewise.
1615         * p-lang.c (pascal_language_defn): Likewise.
1616         * rust-lang.c (rust_language_defn): Likewise.
1617
1618 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1619
1620         * riscv-tdep.c (riscv_type_align): New function.
1621         (riscv_type_alignment): Delete.
1622         (riscv_arg_location): Use 'type_align'.
1623         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1624
1625 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * gdbtypes.c (type_align): A struct with no non-static fields also
1628         has alignment of 1.
1629
1630 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1631
1632         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1633         component to 0.
1634         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1635         member.
1636         (riscv_struct_info::analyse): New implementation using new
1637         analyse_inner member function.
1638         (riscv_struct_info::field_offset): New member function.
1639         (riscv_struct_info::m_offsets): New member variable.
1640         (riscv_struct_info::analyse_inner): New private member function,
1641         takes the old implementation of riscv_struct_info::analyse but
1642         extended to track field offsets.
1643         (riscv_call_arg_struct): Update the struct folding special cases
1644         to handle cases where empty C++ structs, which are non-zero
1645         length, are found.
1646         (riscv_arg_location): Initialise the length of each location, a
1647         non-zero length now indicates the location is in use.
1648         (riscv_push_dummy_call): Allow for the first location having a
1649         non-zero offset when setting up arguments.
1650         (riscv_return_value): Likewise, but for return values.
1651
1652 2019-04-11  Tom Tromey  <tromey@adacore.com>
1653
1654         * utils.c (internal_vproblem): Make "msg" const.
1655
1656 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1657
1658         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1659         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1660         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1661         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1662
1663 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1664
1665         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1666         function.
1667         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1668         of amd64_collect_native_gregset.
1669         (amd64_linux_nat_target::store_registers): Likewise.
1670
1671 2019-04-10  Tom Tromey  <tom@tromey.com>
1672
1673         * symtab.c (lookup_global_symbol_from_objfile)
1674         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1675         * objfiles.h (class separate_debug_iterator): New.
1676         (class separate_debug_range): New.
1677         (struct objfile) <separate_debug_objfiles>: New method.
1678         (objfile_separate_debug_iterate): Don't declare.
1679         * objfiles.c (separate_debug_iterator::operator++): Rename from
1680         objfile_separate_debug_iterate.
1681         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1682         iterator.
1683         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1684         iterator.
1685
1686 2019-04-10  Tom Tromey  <tom@tromey.com>
1687
1688         * symfile.c (reread_symbols): Remove old comment.
1689         * objfiles.c (free_all_objfiles): Fix a typo.
1690
1691 2019-04-10  Tom Tromey  <tom@tromey.com>
1692
1693         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1694         * minsyms.c (lookup_minimal_symbol): Use foreach.
1695         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1696         (lookup_minimal_symbol_solib_trampoline): Likewise.
1697         * symfile.c (reread_symbols): Use foreach.
1698
1699 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1700             Tom Tromey  <tromey@adacore.com>
1701
1702         PR rust/24414:
1703         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1704         (rust_lex_int_test): Change "value" to be LONGEST.
1705         (rust_lex_tests): Add test for long integer literal.
1706
1707 2019-04-09  Tom Tromey  <tromey@adacore.com>
1708
1709         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1710         to bool.
1711         (extended_remote_target::attach): Update.
1712         (remote_target::remote_notice_new_inferior): Update.
1713         (remote_target::add_current_inferior_and_thread): Update.
1714         * inferior.c (exit_inferior_1): Use "false".
1715         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1716
1717 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1718
1719         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1720         the "start" command.
1721
1722 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1723
1724         * python/py-inferior.c (infpy_thread_from_thread_handle):
1725         Adjust comments to reflect renaming of thread_from_thread_handle
1726         to thread_from_handle.  Adjust keywords.  Fix type error message.
1727         (inferior_object_methods): Add thread_from_handle.  Retain
1728         thread_from_thread_handle, but mark it as deprecated.
1729
1730 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1731
1732         * gdbthread.h (find_thread_by_handle): Revise declaration.
1733         * thread.c (find_thread_by_handle): Likewise.  Adjust
1734         implementation too.
1735         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1736         support for buffer objects as handles.
1737
1738 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1739
1740         * python/py-infthread.c (thpy_thread_handle): New function.
1741         (thread_object_methods): Register thpy_thread_handle.
1742
1743 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1744
1745         * gdbthread.h (thread_to_thread_handle): Declare.
1746         * thread.c (gdbtypes.h): Include.
1747         (thread_to_thread_handle): New function.
1748
1749         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1750         (target_thread_info_to_thread_handle): Declare.
1751         * target.c (target_thread_info_to_thread_handle): New function.
1752         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1753         * target-delegates.c: Regenerate.
1754
1755         * linux-thread-db.c (class thread_db_target): Add method
1756         thread_info_to_thread_handle.
1757         (thread_db_target::thread_info_to_thread_handle): Define.
1758         * remote.c (class remote_target): Add new method
1759         thread_info_to_thread_handle.
1760         (remote_target::thread_info_to_thread_handle): Define.
1761
1762 2019-04-08  Pedro Alves  <palves@redhat.com>
1763
1764         * common/common-exceptions.c (throw_exception): Don't create
1765         named object to throw; throw directly.
1766         (throw_it): Likewise.  Don't initialize gdb_exception::message
1767         here, with new; pass FMT and AP to the ctor instead.
1768         * common/common-exceptions.h: Include <string>.
1769         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1770         const char *, va_list)): New ctor.  Use std::make_shared.
1771         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1772         errors)): Delete.
1773         (gdb_exception_error::gdb_exception_error(enum errors, const char
1774         *, va_list)): New.
1775         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1776         Add assertion.
1777         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1778         errors)): Delete.
1779         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1780         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1781         Add assertion.
1782
1783 2019-04-08  Tom Tromey  <tom@tromey.com>
1784
1785         * valops.c (value_rtti_indirect_type): Replace throw_exception
1786         with throw.
1787         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1788         with throw.
1789         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1790         throw.
1791         * target.c (target_translate_tls_address): Replace throw_exception
1792         with throw.
1793         * stack.c (frame_apply_command_count): Replace throw_exception
1794         with throw.
1795         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1796         throw.
1797         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1798         with throw.
1799         * rs6000-tdep.c (rs6000_frame_cache)
1800         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1801         * remote.c: Replace throw_exception with throw.
1802         * record-full.c (record_full_message, record_full_wait_1)
1803         (record_full_restore): Replace throw_exception with throw.
1804         * record-btrace.c:
1805         (get_thread_current_frame_id, record_btrace_start_replaying)
1806         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1807         (cmd_record_btrace_start): Replace throw_exception with throw.
1808         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1809         throw.
1810         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1811         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1812         * linespec.c:
1813         (find_linespec_symbols): Replace throw_exception with throw.
1814         * infrun.c (displaced_step_prepare, resume): Replace
1815         throw_exception with throw.
1816         * infcmd.c (post_create_inferior): Replace throw_exception with
1817         throw.
1818         * inf-loop.c (inferior_event_handler): Replace throw_exception
1819         with throw.
1820         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1821         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1822         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1823         (get_prev_frame_always, get_frame_pc_if_available)
1824         (get_frame_address_in_block_if_available, get_frame_language):
1825         Replace throw_exception with throw.
1826         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1827         throw_exception with throw.
1828         * eval.c (fetch_subexp_value, evaluate_var_value)
1829         (evaluate_funcall, evaluate_subexp_standard): Replace
1830         throw_exception with throw.
1831         * dwarf2loc.c (call_site_find_chain)
1832         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1833         Replace throw_exception with throw.
1834         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1835         with throw.
1836         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1837         throw.
1838         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1839         * completer.c (complete_line_internal): Replace throw_exception
1840         with throw.
1841         * compile/compile-object-run.c (compile_object_run): Replace
1842         throw_exception with throw.
1843         * cli/cli-script.c (process_next_line): Replace throw_exception
1844         with throw.
1845         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1846         (btrace_enable, btrace_maint_update_pt_packets): Replace
1847         throw_exception with throw.
1848         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1849         throw_exception with throw.
1850         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1851         throw_exception with throw.
1852         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1853         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1854         * aarch64-tdep.c (aarch64_make_prologue_cache)
1855         (aarch64_make_stub_cache): Replace throw_exception with throw.
1856
1857 2019-04-08  Tom Tromey  <tom@tromey.com>
1858
1859         * common/common-exceptions.c (throw_exception): Rename from
1860         throw_exception_cxx.  Remove old copy.  Make argument const.
1861         (throw_it): Create and throw exception objects directly.
1862         * common/common-exceptions.h (throw_exception): Make argument
1863         const.
1864         (struct gdb_exception_error): Add constructor.
1865         (struct gdb_exception_quit): Add constructor.
1866
1867 2019-04-08  Tom Tromey  <tom@tromey.com>
1868
1869         * common/common-exceptions.h (exception_rethrow): Don't declare.
1870         (TRY_SJLJ): Update comment.
1871         (TRY, CATCH, END_CATCH): Remove.
1872         * common/common-exceptions.c (exception_rethrow): Remove.
1873
1874 2019-04-08  Tom Tromey  <tom@tromey.com>
1875
1876         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1877         Remove.
1878         (gdb_exception_error): Rename from
1879         gdb_exception_RETURN_MASK_ERROR.
1880         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1881         (gdb_quit_bad_alloc): Update.
1882         * aarch64-tdep.c: Update.
1883         * ada-lang.c: Update.
1884         * ada-typeprint.c: Update.
1885         * ada-valprint.c: Update.
1886         * amd64-tdep.c: Update.
1887         * arch-utils.c: Update.
1888         * break-catch-throw.c: Update.
1889         * breakpoint.c: Update.
1890         * btrace.c: Update.
1891         * c-varobj.c: Update.
1892         * cli/cli-cmds.c: Update.
1893         * cli/cli-interp.c: Update.
1894         * cli/cli-script.c: Update.
1895         * common/common-exceptions.c: Update.
1896         * common/new-op.c: Update.
1897         * common/selftest.c: Update.
1898         * compile/compile-c-symbols.c: Update.
1899         * compile/compile-cplus-symbols.c: Update.
1900         * compile/compile-object-load.c: Update.
1901         * compile/compile-object-run.c: Update.
1902         * completer.c: Update.
1903         * corelow.c: Update.
1904         * cp-abi.c: Update.
1905         * cp-support.c: Update.
1906         * cp-valprint.c: Update.
1907         * darwin-nat.c: Update.
1908         * disasm-selftests.c: Update.
1909         * dtrace-probe.c: Update.
1910         * dwarf-index-cache.c: Update.
1911         * dwarf-index-write.c: Update.
1912         * dwarf2-frame-tailcall.c: Update.
1913         * dwarf2-frame.c: Update.
1914         * dwarf2loc.c: Update.
1915         * dwarf2read.c: Update.
1916         * eval.c: Update.
1917         * event-loop.c: Update.
1918         * event-top.c: Update.
1919         * exec.c: Update.
1920         * f-valprint.c: Update.
1921         * fbsd-tdep.c: Update.
1922         * frame-unwind.c: Update.
1923         * frame.c: Update.
1924         * gdbtypes.c: Update.
1925         * gnu-v3-abi.c: Update.
1926         * guile/guile-internal.h: Update.
1927         * guile/scm-block.c: Update.
1928         * guile/scm-breakpoint.c: Update.
1929         * guile/scm-cmd.c: Update.
1930         * guile/scm-disasm.c: Update.
1931         * guile/scm-frame.c: Update.
1932         * guile/scm-lazy-string.c: Update.
1933         * guile/scm-math.c: Update.
1934         * guile/scm-param.c: Update.
1935         * guile/scm-ports.c: Update.
1936         * guile/scm-pretty-print.c: Update.
1937         * guile/scm-symbol.c: Update.
1938         * guile/scm-symtab.c: Update.
1939         * guile/scm-type.c: Update.
1940         * guile/scm-value.c: Update.
1941         * i386-linux-tdep.c: Update.
1942         * i386-tdep.c: Update.
1943         * inf-loop.c: Update.
1944         * infcall.c: Update.
1945         * infcmd.c: Update.
1946         * infrun.c: Update.
1947         * jit.c: Update.
1948         * language.c: Update.
1949         * linespec.c: Update.
1950         * linux-fork.c: Update.
1951         * linux-nat.c: Update.
1952         * linux-tdep.c: Update.
1953         * linux-thread-db.c: Update.
1954         * main.c: Update.
1955         * mi/mi-cmd-break.c: Update.
1956         * mi/mi-cmd-stack.c: Update.
1957         * mi/mi-interp.c: Update.
1958         * mi/mi-main.c: Update.
1959         * objc-lang.c: Update.
1960         * p-valprint.c: Update.
1961         * parse.c: Update.
1962         * ppc-linux-tdep.c: Update.
1963         * printcmd.c: Update.
1964         * python/py-arch.c: Update.
1965         * python/py-breakpoint.c: Update.
1966         * python/py-cmd.c: Update.
1967         * python/py-finishbreakpoint.c: Update.
1968         * python/py-frame.c: Update.
1969         * python/py-framefilter.c: Update.
1970         * python/py-gdb-readline.c: Update.
1971         * python/py-inferior.c: Update.
1972         * python/py-infthread.c: Update.
1973         * python/py-lazy-string.c: Update.
1974         * python/py-linetable.c: Update.
1975         * python/py-objfile.c: Update.
1976         * python/py-param.c: Update.
1977         * python/py-prettyprint.c: Update.
1978         * python/py-progspace.c: Update.
1979         * python/py-record-btrace.c: Update.
1980         * python/py-record.c: Update.
1981         * python/py-symbol.c: Update.
1982         * python/py-type.c: Update.
1983         * python/py-unwind.c: Update.
1984         * python/py-utils.c: Update.
1985         * python/py-value.c: Update.
1986         * python/python.c: Update.
1987         * record-btrace.c: Update.
1988         * record-full.c: Update.
1989         * remote-fileio.c: Update.
1990         * remote.c: Update.
1991         * riscv-tdep.c: Update.
1992         * rs6000-aix-tdep.c: Update.
1993         * rs6000-tdep.c: Update.
1994         * rust-exp.y: Update.
1995         * rust-lang.c: Update.
1996         * s390-tdep.c: Update.
1997         * selftest-arch.c: Update.
1998         * solib-dsbt.c: Update.
1999         * solib-frv.c: Update.
2000         * solib-spu.c: Update.
2001         * solib-svr4.c: Update.
2002         * solib.c: Update.
2003         * sparc64-linux-tdep.c: Update.
2004         * stack.c: Update.
2005         * symfile-mem.c: Update.
2006         * symmisc.c: Update.
2007         * target.c: Update.
2008         * thread.c: Update.
2009         * top.c: Update.
2010         * tracefile-tfile.c: Update.
2011         * tui/tui.c: Update.
2012         * typeprint.c: Update.
2013         * unittests/cli-utils-selftests.c: Update.
2014         * unittests/parse-connection-spec-selftests.c: Update.
2015         * valops.c: Update.
2016         * valprint.c: Update.
2017         * value.c: Update.
2018         * varobj.c: Update.
2019         * windows-nat.c: Update.
2020         * x86-linux-nat.c: Update.
2021         * xml-support.c: Update.
2022
2023 2019-04-08  Tom Tromey  <tom@tromey.com>
2024
2025         * xml-support.c: Use C++ exception handling.
2026         * x86-linux-nat.c: Use C++ exception handling.
2027         * windows-nat.c: Use C++ exception handling.
2028         * varobj.c: Use C++ exception handling.
2029         * value.c: Use C++ exception handling.
2030         * valprint.c: Use C++ exception handling.
2031         * valops.c: Use C++ exception handling.
2032         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2033         handling.
2034         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2035         * typeprint.c: Use C++ exception handling.
2036         * tui/tui.c: Use C++ exception handling.
2037         * tracefile-tfile.c: Use C++ exception handling.
2038         * top.c: Use C++ exception handling.
2039         * thread.c: Use C++ exception handling.
2040         * target.c: Use C++ exception handling.
2041         * symmisc.c: Use C++ exception handling.
2042         * symfile-mem.c: Use C++ exception handling.
2043         * stack.c: Use C++ exception handling.
2044         * sparc64-linux-tdep.c: Use C++ exception handling.
2045         * solib.c: Use C++ exception handling.
2046         * solib-svr4.c: Use C++ exception handling.
2047         * solib-spu.c: Use C++ exception handling.
2048         * solib-frv.c: Use C++ exception handling.
2049         * solib-dsbt.c: Use C++ exception handling.
2050         * selftest-arch.c: Use C++ exception handling.
2051         * s390-tdep.c: Use C++ exception handling.
2052         * rust-lang.c: Use C++ exception handling.
2053         * rust-exp.y: Use C++ exception handling.
2054         * rs6000-tdep.c: Use C++ exception handling.
2055         * rs6000-aix-tdep.c: Use C++ exception handling.
2056         * riscv-tdep.c: Use C++ exception handling.
2057         * remote.c: Use C++ exception handling.
2058         * remote-fileio.c: Use C++ exception handling.
2059         * record-full.c: Use C++ exception handling.
2060         * record-btrace.c: Use C++ exception handling.
2061         * python/python.c: Use C++ exception handling.
2062         * python/py-value.c: Use C++ exception handling.
2063         * python/py-utils.c: Use C++ exception handling.
2064         * python/py-unwind.c: Use C++ exception handling.
2065         * python/py-type.c: Use C++ exception handling.
2066         * python/py-symbol.c: Use C++ exception handling.
2067         * python/py-record.c: Use C++ exception handling.
2068         * python/py-record-btrace.c: Use C++ exception handling.
2069         * python/py-progspace.c: Use C++ exception handling.
2070         * python/py-prettyprint.c: Use C++ exception handling.
2071         * python/py-param.c: Use C++ exception handling.
2072         * python/py-objfile.c: Use C++ exception handling.
2073         * python/py-linetable.c: Use C++ exception handling.
2074         * python/py-lazy-string.c: Use C++ exception handling.
2075         * python/py-infthread.c: Use C++ exception handling.
2076         * python/py-inferior.c: Use C++ exception handling.
2077         * python/py-gdb-readline.c: Use C++ exception handling.
2078         * python/py-framefilter.c: Use C++ exception handling.
2079         * python/py-frame.c: Use C++ exception handling.
2080         * python/py-finishbreakpoint.c: Use C++ exception handling.
2081         * python/py-cmd.c: Use C++ exception handling.
2082         * python/py-breakpoint.c: Use C++ exception handling.
2083         * python/py-arch.c: Use C++ exception handling.
2084         * printcmd.c: Use C++ exception handling.
2085         * ppc-linux-tdep.c: Use C++ exception handling.
2086         * parse.c: Use C++ exception handling.
2087         * p-valprint.c: Use C++ exception handling.
2088         * objc-lang.c: Use C++ exception handling.
2089         * mi/mi-main.c: Use C++ exception handling.
2090         * mi/mi-interp.c: Use C++ exception handling.
2091         * mi/mi-cmd-stack.c: Use C++ exception handling.
2092         * mi/mi-cmd-break.c: Use C++ exception handling.
2093         * main.c: Use C++ exception handling.
2094         * linux-thread-db.c: Use C++ exception handling.
2095         * linux-tdep.c: Use C++ exception handling.
2096         * linux-nat.c: Use C++ exception handling.
2097         * linux-fork.c: Use C++ exception handling.
2098         * linespec.c: Use C++ exception handling.
2099         * language.c: Use C++ exception handling.
2100         * jit.c: Use C++ exception handling.
2101         * infrun.c: Use C++ exception handling.
2102         * infcmd.c: Use C++ exception handling.
2103         * infcall.c: Use C++ exception handling.
2104         * inf-loop.c: Use C++ exception handling.
2105         * i386-tdep.c: Use C++ exception handling.
2106         * i386-linux-tdep.c: Use C++ exception handling.
2107         * guile/scm-value.c: Use C++ exception handling.
2108         * guile/scm-type.c: Use C++ exception handling.
2109         * guile/scm-symtab.c: Use C++ exception handling.
2110         * guile/scm-symbol.c: Use C++ exception handling.
2111         * guile/scm-pretty-print.c: Use C++ exception handling.
2112         * guile/scm-ports.c: Use C++ exception handling.
2113         * guile/scm-param.c: Use C++ exception handling.
2114         * guile/scm-math.c: Use C++ exception handling.
2115         * guile/scm-lazy-string.c: Use C++ exception handling.
2116         * guile/scm-frame.c: Use C++ exception handling.
2117         * guile/scm-disasm.c: Use C++ exception handling.
2118         * guile/scm-cmd.c: Use C++ exception handling.
2119         * guile/scm-breakpoint.c: Use C++ exception handling.
2120         * guile/scm-block.c: Use C++ exception handling.
2121         * guile/guile-internal.h: Use C++ exception handling.
2122         * gnu-v3-abi.c: Use C++ exception handling.
2123         * gdbtypes.c: Use C++ exception handling.
2124         * frame.c: Use C++ exception handling.
2125         * frame-unwind.c: Use C++ exception handling.
2126         * fbsd-tdep.c: Use C++ exception handling.
2127         * f-valprint.c: Use C++ exception handling.
2128         * exec.c: Use C++ exception handling.
2129         * event-top.c: Use C++ exception handling.
2130         * event-loop.c: Use C++ exception handling.
2131         * eval.c: Use C++ exception handling.
2132         * dwarf2read.c: Use C++ exception handling.
2133         * dwarf2loc.c: Use C++ exception handling.
2134         * dwarf2-frame.c: Use C++ exception handling.
2135         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2136         * dwarf-index-write.c: Use C++ exception handling.
2137         * dwarf-index-cache.c: Use C++ exception handling.
2138         * dtrace-probe.c: Use C++ exception handling.
2139         * disasm-selftests.c: Use C++ exception handling.
2140         * darwin-nat.c: Use C++ exception handling.
2141         * cp-valprint.c: Use C++ exception handling.
2142         * cp-support.c: Use C++ exception handling.
2143         * cp-abi.c: Use C++ exception handling.
2144         * corelow.c: Use C++ exception handling.
2145         * completer.c: Use C++ exception handling.
2146         * compile/compile-object-run.c: Use C++ exception handling.
2147         * compile/compile-object-load.c: Use C++ exception handling.
2148         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2149         * compile/compile-c-symbols.c: Use C++ exception handling.
2150         * common/selftest.c: Use C++ exception handling.
2151         * common/new-op.c: Use C++ exception handling.
2152         * cli/cli-script.c: Use C++ exception handling.
2153         * cli/cli-interp.c: Use C++ exception handling.
2154         * cli/cli-cmds.c: Use C++ exception handling.
2155         * c-varobj.c: Use C++ exception handling.
2156         * btrace.c: Use C++ exception handling.
2157         * breakpoint.c: Use C++ exception handling.
2158         * break-catch-throw.c: Use C++ exception handling.
2159         * arch-utils.c: Use C++ exception handling.
2160         * amd64-tdep.c: Use C++ exception handling.
2161         * ada-valprint.c: Use C++ exception handling.
2162         * ada-typeprint.c: Use C++ exception handling.
2163         * ada-lang.c: Use C++ exception handling.
2164         * aarch64-tdep.c: Use C++ exception handling.
2165
2166 2019-04-08  Tom Tromey  <tom@tromey.com>
2167
2168         * xml-support.c (gdb_xml_parser::parse): Update.
2169         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2170         * value.c (show_convenience): Update.
2171         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2172         (test_parse_flags_qcs): Update.
2173         * thread.c (thr_try_catch_cmd): Update.
2174         * target.c (target_translate_tls_address): Update.
2175         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2176         (info_frame_command_core, frame_apply_command_count): Update.
2177         * rust-exp.y (rust_lex_exception_test): Update.
2178         * riscv-tdep.c (riscv_print_one_register_info): Update.
2179         * remote.c (remote_target::enable_btrace): Update.
2180         * record-btrace.c (record_btrace_enable_warn): Update.
2181         * python/py-utils.c (gdbpy_convert_exception): Update.
2182         * printcmd.c (do_one_display, print_variable_and_value): Update.
2183         * mi/mi-main.c (mi_print_exception): Update.
2184         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2185         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2186         * linux-nat.c (linux_nat_target::attach): Update.
2187         * linux-fork.c (class scoped_switch_fork_info): Update.
2188         * infrun.c (displaced_step_prepare): Update.
2189         * infcall.c (call_function_by_hand_dummy): Update.
2190         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2191         * gnu-v3-abi.c (print_one_vtable): Update.
2192         * frame.c (get_prev_frame_always): Update.
2193         * f-valprint.c (info_common_command_for_block): Update.
2194         * exec.c (try_open_exec_file): Update.
2195         * exceptions.c (print_exception, exception_print)
2196         (exception_fprintf, exception_print_same): Update.
2197         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2198         * dwarf-index-cache.c (index_cache::store)
2199         (index_cache::lookup_gdb_index): Update.
2200         * darwin-nat.c (maybe_cache_shell): Update.
2201         * cp-valprint.c (cp_print_value_fields): Update.
2202         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2203         (gcc_cplus_symbol_address): Update.
2204         * compile/compile-c-symbols.c (gcc_convert_symbol)
2205         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2206         * common/selftest.c: Update.
2207         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2208         a std::string.
2209         (exception_try_scope_entry, exception_try_scope_exit): Don't
2210         declare.
2211         (struct exception_try_scope): Remove.
2212         (TRY): Don't use exception_try_scope.
2213         (struct gdb_exception): Add constructor, operator=.
2214         <what>: New method.
2215         (struct gdb_exception_RETURN_MASK_ALL)
2216         (struct gdb_exception_RETURN_MASK_ERROR)
2217         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2218         (struct gdb_quit_bad_alloc): Update.
2219         * common/common-exceptions.c (exception_none): Change
2220         initializer.
2221         (struct catcher) <state, exception>: Initialize inline.
2222         <prev>: Remove member.
2223         (current_catcher): Remove.
2224         (catchers): New global.
2225         (exceptions_state_mc_init): Simplify.
2226         (catcher_pop): Remove.
2227         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2228         (try_scope_depth, exception_try_scope_entry)
2229         (exception_try_scope_exit): Remove.
2230         (throw_exception_sjlj): Update.
2231         (exception_messages, exception_messages_size): Remove.
2232         (throw_it): Simplify.
2233         (gdb_exception_sliced_copy): Remove.
2234         (throw_exception_cxx): Update.
2235         * cli/cli-script.c (script_from_file): Update.
2236         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2237         Update.
2238         * ada-valprint.c (ada_val_print): Update.
2239         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2240         (create_excep_cond_exprs): Update.
2241
2242 2019-04-08  Tom Tromey  <tom@tromey.com>
2243
2244         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2245         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2246         (TRY, CATCH, END_CATCH): Remove some definitions.
2247         * common/common-exceptions.c: Don't use GDB_XCPT.
2248         (catcher_list_size): Remove.
2249         (throw_exception, throw_it): Simplify.
2250
2251 2019-04-05  Tom Tromey  <tom@tromey.com>
2252
2253         Revert the header-sorting patch.
2254         * ft32-tdep.c: Revert.
2255         * frv-tdep.c: Revert.
2256         * frv-linux-tdep.c: Revert.
2257         * frame.c: Revert.
2258         * frame-unwind.c: Revert.
2259         * frame-base.c: Revert.
2260         * fork-child.c: Revert.
2261         * findvar.c: Revert.
2262         * findcmd.c: Revert.
2263         * filesystem.c: Revert.
2264         * filename-seen-cache.h: Revert.
2265         * filename-seen-cache.c: Revert.
2266         * fbsd-tdep.c: Revert.
2267         * fbsd-nat.h: Revert.
2268         * fbsd-nat.c: Revert.
2269         * f-valprint.c: Revert.
2270         * f-typeprint.c: Revert.
2271         * f-lang.c: Revert.
2272         * extension.h: Revert.
2273         * extension.c: Revert.
2274         * extension-priv.h: Revert.
2275         * expprint.c: Revert.
2276         * exec.h: Revert.
2277         * exec.c: Revert.
2278         * exceptions.c: Revert.
2279         * event-top.c: Revert.
2280         * event-loop.c: Revert.
2281         * eval.c: Revert.
2282         * elfread.c: Revert.
2283         * dwarf2read.h: Revert.
2284         * dwarf2read.c: Revert.
2285         * dwarf2loc.c: Revert.
2286         * dwarf2expr.h: Revert.
2287         * dwarf2expr.c: Revert.
2288         * dwarf2-frame.c: Revert.
2289         * dwarf2-frame-tailcall.c: Revert.
2290         * dwarf-index-write.h: Revert.
2291         * dwarf-index-write.c: Revert.
2292         * dwarf-index-common.c: Revert.
2293         * dwarf-index-cache.h: Revert.
2294         * dwarf-index-cache.c: Revert.
2295         * dummy-frame.c: Revert.
2296         * dtrace-probe.c: Revert.
2297         * disasm.h: Revert.
2298         * disasm.c: Revert.
2299         * disasm-selftests.c: Revert.
2300         * dictionary.c: Revert.
2301         * dicos-tdep.c: Revert.
2302         * demangle.c: Revert.
2303         * dcache.h: Revert.
2304         * dcache.c: Revert.
2305         * darwin-nat.h: Revert.
2306         * darwin-nat.c: Revert.
2307         * darwin-nat-info.c: Revert.
2308         * d-valprint.c: Revert.
2309         * d-namespace.c: Revert.
2310         * d-lang.c: Revert.
2311         * ctf.c: Revert.
2312         * csky-tdep.c: Revert.
2313         * csky-linux-tdep.c: Revert.
2314         * cris-tdep.c: Revert.
2315         * cris-linux-tdep.c: Revert.
2316         * cp-valprint.c: Revert.
2317         * cp-support.c: Revert.
2318         * cp-namespace.c: Revert.
2319         * cp-abi.c: Revert.
2320         * corelow.c: Revert.
2321         * corefile.c: Revert.
2322         * continuations.c: Revert.
2323         * completer.h: Revert.
2324         * completer.c: Revert.
2325         * complaints.c: Revert.
2326         * coffread.c: Revert.
2327         * coff-pe-read.c: Revert.
2328         * cli-out.h: Revert.
2329         * cli-out.c: Revert.
2330         * charset.c: Revert.
2331         * c-varobj.c: Revert.
2332         * c-valprint.c: Revert.
2333         * c-typeprint.c: Revert.
2334         * c-lang.c: Revert.
2335         * buildsym.c: Revert.
2336         * buildsym-legacy.c: Revert.
2337         * build-id.h: Revert.
2338         * build-id.c: Revert.
2339         * btrace.c: Revert.
2340         * bsd-uthread.c: Revert.
2341         * breakpoint.h: Revert.
2342         * breakpoint.c: Revert.
2343         * break-catch-throw.c: Revert.
2344         * break-catch-syscall.c: Revert.
2345         * break-catch-sig.c: Revert.
2346         * blockframe.c: Revert.
2347         * block.c: Revert.
2348         * bfin-tdep.c: Revert.
2349         * bfin-linux-tdep.c: Revert.
2350         * bfd-target.c: Revert.
2351         * bcache.c: Revert.
2352         * ax-general.c: Revert.
2353         * ax-gdb.h: Revert.
2354         * ax-gdb.c: Revert.
2355         * avr-tdep.c: Revert.
2356         * auxv.c: Revert.
2357         * auto-load.c: Revert.
2358         * arm-wince-tdep.c: Revert.
2359         * arm-tdep.c: Revert.
2360         * arm-symbian-tdep.c: Revert.
2361         * arm-pikeos-tdep.c: Revert.
2362         * arm-obsd-tdep.c: Revert.
2363         * arm-nbsd-tdep.c: Revert.
2364         * arm-nbsd-nat.c: Revert.
2365         * arm-linux-tdep.c: Revert.
2366         * arm-linux-nat.c: Revert.
2367         * arm-fbsd-tdep.c: Revert.
2368         * arm-fbsd-nat.c: Revert.
2369         * arm-bsd-tdep.c: Revert.
2370         * arch-utils.c: Revert.
2371         * arc-tdep.c: Revert.
2372         * arc-newlib-tdep.c: Revert.
2373         * annotate.h: Revert.
2374         * annotate.c: Revert.
2375         * amd64-windows-tdep.c: Revert.
2376         * amd64-windows-nat.c: Revert.
2377         * amd64-tdep.c: Revert.
2378         * amd64-sol2-tdep.c: Revert.
2379         * amd64-obsd-tdep.c: Revert.
2380         * amd64-obsd-nat.c: Revert.
2381         * amd64-nbsd-tdep.c: Revert.
2382         * amd64-nbsd-nat.c: Revert.
2383         * amd64-nat.c: Revert.
2384         * amd64-linux-tdep.c: Revert.
2385         * amd64-linux-nat.c: Revert.
2386         * amd64-fbsd-tdep.c: Revert.
2387         * amd64-fbsd-nat.c: Revert.
2388         * amd64-dicos-tdep.c: Revert.
2389         * amd64-darwin-tdep.c: Revert.
2390         * amd64-bsd-nat.c: Revert.
2391         * alpha-tdep.c: Revert.
2392         * alpha-obsd-tdep.c: Revert.
2393         * alpha-nbsd-tdep.c: Revert.
2394         * alpha-mdebug-tdep.c: Revert.
2395         * alpha-linux-tdep.c: Revert.
2396         * alpha-linux-nat.c: Revert.
2397         * alpha-bsd-tdep.c: Revert.
2398         * alpha-bsd-nat.c: Revert.
2399         * aix-thread.c: Revert.
2400         * agent.c: Revert.
2401         * addrmap.c: Revert.
2402         * ada-varobj.c: Revert.
2403         * ada-valprint.c: Revert.
2404         * ada-typeprint.c: Revert.
2405         * ada-tasks.c: Revert.
2406         * ada-lang.c: Revert.
2407         * aarch64-tdep.c: Revert.
2408         * aarch64-ravenscar-thread.c: Revert.
2409         * aarch64-newlib-tdep.c: Revert.
2410         * aarch64-linux-tdep.c: Revert.
2411         * aarch64-linux-nat.c: Revert.
2412         * aarch64-fbsd-tdep.c: Revert.
2413         * aarch64-fbsd-nat.c: Revert.
2414         * aarch32-linux-nat.c: Revert.
2415
2416 2019-04-05  Tom Tromey  <tom@tromey.com>
2417
2418         * ft32-tdep.c: Sort headers.
2419         * frv-tdep.c: Sort headers.
2420         * frv-linux-tdep.c: Sort headers.
2421         * frame.c: Sort headers.
2422         * frame-unwind.c: Sort headers.
2423         * frame-base.c: Sort headers.
2424         * fork-child.c: Sort headers.
2425         * findvar.c: Sort headers.
2426         * findcmd.c: Sort headers.
2427         * filesystem.c: Sort headers.
2428         * filename-seen-cache.h: Sort headers.
2429         * filename-seen-cache.c: Sort headers.
2430         * fbsd-tdep.c: Sort headers.
2431         * fbsd-nat.h: Sort headers.
2432         * fbsd-nat.c: Sort headers.
2433         * f-valprint.c: Sort headers.
2434         * f-typeprint.c: Sort headers.
2435         * f-lang.c: Sort headers.
2436         * extension.h: Sort headers.
2437         * extension.c: Sort headers.
2438         * extension-priv.h: Sort headers.
2439         * expprint.c: Sort headers.
2440         * exec.h: Sort headers.
2441         * exec.c: Sort headers.
2442         * exceptions.c: Sort headers.
2443         * event-top.c: Sort headers.
2444         * event-loop.c: Sort headers.
2445         * eval.c: Sort headers.
2446         * elfread.c: Sort headers.
2447         * dwarf2read.h: Sort headers.
2448         * dwarf2read.c: Sort headers.
2449         * dwarf2loc.c: Sort headers.
2450         * dwarf2expr.h: Sort headers.
2451         * dwarf2expr.c: Sort headers.
2452         * dwarf2-frame.c: Sort headers.
2453         * dwarf2-frame-tailcall.c: Sort headers.
2454         * dwarf-index-write.h: Sort headers.
2455         * dwarf-index-write.c: Sort headers.
2456         * dwarf-index-common.c: Sort headers.
2457         * dwarf-index-cache.h: Sort headers.
2458         * dwarf-index-cache.c: Sort headers.
2459         * dummy-frame.c: Sort headers.
2460         * dtrace-probe.c: Sort headers.
2461         * disasm.h: Sort headers.
2462         * disasm.c: Sort headers.
2463         * disasm-selftests.c: Sort headers.
2464         * dictionary.c: Sort headers.
2465         * dicos-tdep.c: Sort headers.
2466         * demangle.c: Sort headers.
2467         * dcache.h: Sort headers.
2468         * dcache.c: Sort headers.
2469         * darwin-nat.h: Sort headers.
2470         * darwin-nat.c: Sort headers.
2471         * darwin-nat-info.c: Sort headers.
2472         * d-valprint.c: Sort headers.
2473         * d-namespace.c: Sort headers.
2474         * d-lang.c: Sort headers.
2475         * ctf.c: Sort headers.
2476         * csky-tdep.c: Sort headers.
2477         * csky-linux-tdep.c: Sort headers.
2478         * cris-tdep.c: Sort headers.
2479         * cris-linux-tdep.c: Sort headers.
2480         * cp-valprint.c: Sort headers.
2481         * cp-support.c: Sort headers.
2482         * cp-namespace.c: Sort headers.
2483         * cp-abi.c: Sort headers.
2484         * corelow.c: Sort headers.
2485         * corefile.c: Sort headers.
2486         * continuations.c: Sort headers.
2487         * completer.h: Sort headers.
2488         * completer.c: Sort headers.
2489         * complaints.c: Sort headers.
2490         * coffread.c: Sort headers.
2491         * coff-pe-read.c: Sort headers.
2492         * cli-out.h: Sort headers.
2493         * cli-out.c: Sort headers.
2494         * charset.c: Sort headers.
2495         * c-varobj.c: Sort headers.
2496         * c-valprint.c: Sort headers.
2497         * c-typeprint.c: Sort headers.
2498         * c-lang.c: Sort headers.
2499         * buildsym.c: Sort headers.
2500         * buildsym-legacy.c: Sort headers.
2501         * build-id.h: Sort headers.
2502         * build-id.c: Sort headers.
2503         * btrace.c: Sort headers.
2504         * bsd-uthread.c: Sort headers.
2505         * breakpoint.h: Sort headers.
2506         * breakpoint.c: Sort headers.
2507         * break-catch-throw.c: Sort headers.
2508         * break-catch-syscall.c: Sort headers.
2509         * break-catch-sig.c: Sort headers.
2510         * blockframe.c: Sort headers.
2511         * block.c: Sort headers.
2512         * bfin-tdep.c: Sort headers.
2513         * bfin-linux-tdep.c: Sort headers.
2514         * bfd-target.c: Sort headers.
2515         * bcache.c: Sort headers.
2516         * ax-general.c: Sort headers.
2517         * ax-gdb.h: Sort headers.
2518         * ax-gdb.c: Sort headers.
2519         * avr-tdep.c: Sort headers.
2520         * auxv.c: Sort headers.
2521         * auto-load.c: Sort headers.
2522         * arm-wince-tdep.c: Sort headers.
2523         * arm-tdep.c: Sort headers.
2524         * arm-symbian-tdep.c: Sort headers.
2525         * arm-pikeos-tdep.c: Sort headers.
2526         * arm-obsd-tdep.c: Sort headers.
2527         * arm-nbsd-tdep.c: Sort headers.
2528         * arm-nbsd-nat.c: Sort headers.
2529         * arm-linux-tdep.c: Sort headers.
2530         * arm-linux-nat.c: Sort headers.
2531         * arm-fbsd-tdep.c: Sort headers.
2532         * arm-fbsd-nat.c: Sort headers.
2533         * arm-bsd-tdep.c: Sort headers.
2534         * arch-utils.c: Sort headers.
2535         * arc-tdep.c: Sort headers.
2536         * arc-newlib-tdep.c: Sort headers.
2537         * annotate.h: Sort headers.
2538         * annotate.c: Sort headers.
2539         * amd64-windows-tdep.c: Sort headers.
2540         * amd64-windows-nat.c: Sort headers.
2541         * amd64-tdep.c: Sort headers.
2542         * amd64-sol2-tdep.c: Sort headers.
2543         * amd64-obsd-tdep.c: Sort headers.
2544         * amd64-obsd-nat.c: Sort headers.
2545         * amd64-nbsd-tdep.c: Sort headers.
2546         * amd64-nbsd-nat.c: Sort headers.
2547         * amd64-nat.c: Sort headers.
2548         * amd64-linux-tdep.c: Sort headers.
2549         * amd64-linux-nat.c: Sort headers.
2550         * amd64-fbsd-tdep.c: Sort headers.
2551         * amd64-fbsd-nat.c: Sort headers.
2552         * amd64-dicos-tdep.c: Sort headers.
2553         * amd64-darwin-tdep.c: Sort headers.
2554         * amd64-bsd-nat.c: Sort headers.
2555         * alpha-tdep.c: Sort headers.
2556         * alpha-obsd-tdep.c: Sort headers.
2557         * alpha-nbsd-tdep.c: Sort headers.
2558         * alpha-mdebug-tdep.c: Sort headers.
2559         * alpha-linux-tdep.c: Sort headers.
2560         * alpha-linux-nat.c: Sort headers.
2561         * alpha-bsd-tdep.c: Sort headers.
2562         * alpha-bsd-nat.c: Sort headers.
2563         * aix-thread.c: Sort headers.
2564         * agent.c: Sort headers.
2565         * addrmap.c: Sort headers.
2566         * ada-varobj.c: Sort headers.
2567         * ada-valprint.c: Sort headers.
2568         * ada-typeprint.c: Sort headers.
2569         * ada-tasks.c: Sort headers.
2570         * ada-lang.c: Sort headers.
2571         * aarch64-tdep.c: Sort headers.
2572         * aarch64-ravenscar-thread.c: Sort headers.
2573         * aarch64-newlib-tdep.c: Sort headers.
2574         * aarch64-linux-tdep.c: Sort headers.
2575         * aarch64-linux-nat.c: Sort headers.
2576         * aarch64-fbsd-tdep.c: Sort headers.
2577         * aarch64-fbsd-nat.c: Sort headers.
2578         * aarch32-linux-nat.c: Sort headers.
2579
2580 2019-04-04  Tom Tromey  <tom@tromey.com>
2581
2582         * varobj.c (varobj_create): Update.
2583         * rust-exp.y (struct rust_parser) <update_innermost_block,
2584         lookup_symbol>: New methods.
2585         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2586         Rename.
2587         (rust_parser::rust_lookup_type)
2588         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2589         * printcmd.c (display_command, do_one_display): Update.
2590         * parser-defs.h (struct parser_state) <parser_state>: Add
2591         "tracker" parameter.
2592         (block_tracker): New member.
2593         (class innermost_block_tracker) <innermost_block_tracker>: Add
2594         "types" parameter.
2595         <reset>: Remove method.
2596         (innermost_block): Don't declare.
2597         (null_post_parser): Update.
2598         * parse.c (innermost_block): Remove global.
2599         (write_dollar_variable): Update.
2600         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2601         Remove "tracker_types" parameter.
2602         (parse_expression): Add "tracker" parameter.
2603         (parse_expression_for_completion): Update.
2604         (null_post_parser): Add "tracker" parameter.
2605         * p-exp.y: Update rules.
2606         * m2-exp.y: Update rules.
2607         * language.h (struct language_defn) <la_post_parser>: Add
2608         "tracker" parameter.
2609         * go-exp.y: Update rules.
2610         * f-exp.y: Update rules.
2611         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2612         parameter.
2613         * d-exp.y: Update rules.
2614         * c-exp.y: Update rules.
2615         * breakpoint.c (set_breakpoint_condition): Create an
2616         innermost_block_tracker.
2617         (watch_command_1): Likewise.
2618         * ada-lang.c (resolve): Add "tracker" parameter.
2619         (resolve_subexp): Likewise.
2620         * ada-exp.y (write_var_from_sym): Update.
2621
2622 2019-04-04  Tom Tromey  <tom@tromey.com>
2623
2624         * type-stack.h: New file.
2625         * type-stack.c: New file.
2626         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2627         type-stack.h.
2628         (insert_into_type_stack, insert_type, push_type, push_type_int)
2629         (insert_type_address_space, pop_type, pop_type_int)
2630         (pop_typelist, pop_type_stack, append_type_stack)
2631         (push_type_stack, get_type_stack, push_typelist)
2632         (follow_type_instance_flags, follow_types): Don't declare.
2633         * parse.c (type_stack): Remove global.
2634         (parse_exp_in_context): Update.
2635         (insert_into_type_stack, insert_type, push_type, push_type_int)
2636         (insert_type_address_space, pop_type, pop_type_int)
2637         (pop_typelist, pop_type_stack, append_type_stack)
2638         (push_type_stack, get_type_stack, push_typelist)
2639         (follow_type_instance_flags, follow_types): Remove (moved to
2640         type-stack.c).
2641         * f-exp.y (type_stack): New global.
2642         Update rules.
2643         (push_kind_type, f_parse): Update.
2644         * d-exp.y (type_stack): New global.
2645         Update rules.
2646         (d_parse): Update.
2647         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2648         Update rules.
2649         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2650         (HFILES_NO_SRCDIR): Add type-stack.h.
2651
2652 2019-04-04  Tom Tromey  <tom@tromey.com>
2653
2654         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2655         (rust_parser::convert_ast_to_expression, rust_parse)
2656         (rust_lex_test_completion, rust_lex_tests): Update.
2657         * parser-defs.h (struct expr_completion_state): New.
2658         (struct parser_state) <parser_state>: Add completion parameter.
2659         <mark_struct_expression, mark_completion_tag>: New methods.
2660         <parse_completion, m_completion_state>: New members.
2661         (prefixify_expression, null_post_parser): Update.
2662         (mark_struct_expression, mark_completion_tag): Don't declare.
2663         * parse.c (parse_completion, expout_last_struct)
2664         (expout_tag_completion_type, expout_completion_name): Remove
2665         globals.
2666         (parser_state::mark_struct_expression)
2667         (parser_state::mark_completion_tag): Now methods.
2668         (prefixify_expression): Add last_struct parameter.
2669         (prefixify_subexp): Likewise.
2670         (parse_exp_1): Update.
2671         (parse_exp_in_context): Add cstate parameter.  Update.
2672         (parse_expression_for_completion): Create an
2673         expr_completion_state.
2674         (null_post_parser): Add "completion" parameter.
2675         * p-exp.y: Update rules.
2676         (yylex): Update.
2677         * language.h (struct language_defn) <la_post_parser>: Add
2678         "completing" parameter.
2679         * go-exp.y: Update rules.
2680         (lex_one_token): Update.
2681         * expression.h (parse_completion): Don't declare.
2682         * d-exp.y: Update rules.
2683         (lex_one_token): Update rules.
2684         * c-exp.y: Update rules.
2685         (lex_one_token): Update.
2686         * ada-lang.c (resolve): Add "parse_completion" parameter.
2687         (resolve_subexp): Likewise.
2688         (ada_resolve_function): Likewise.
2689
2690 2019-04-04  Tom Tromey  <tom@tromey.com>
2691
2692         * parser-defs.h (struct parser_state) <start_arglist,
2693         end_arglist>: New methods.
2694         <arglist_len, m_funcall_chain>: New members.
2695         (arglist_len, start_arglist, end_arglist): Don't declare.
2696         * parse.c (arglist_len, funcall_chain): Remove global.
2697         (start_arglist, end_arglist): Remove functions.
2698         (parse_exp_in_context): Update.
2699         * p-exp.y: Update rules.
2700         * m2-exp.y: Update rules.
2701         * go-exp.y: Update rules.
2702         * f-exp.y: Update rules.
2703         * d-exp.y: Update rules.
2704         * c-exp.y: Update rules.
2705
2706 2019-04-04  Tom Tromey  <tom@tromey.com>
2707
2708         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2709         lex_operator, push_back>: New methods.
2710         Update all rules.
2711         (rust_parser::lex_hex, lex_escape): Rename and update.
2712         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2713         (rust_parser::lex_operator): Rename and update.
2714         (rust_parser::lex_number, rustyylex, rustyyerror)
2715         (rust_lex_test_init, rust_lex_test_sequence)
2716         (rust_lex_test_push_back, rust_lex_tests): Update.
2717         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2718         parameter.
2719         <lexptr, prev_lexptr>: New members.
2720         (lexptr, prev_lexptr): Don't declare.
2721         * parse.c (lexptr, prev_lexptr): Remove globals.
2722         (parse_exp_in_context): Update.
2723         * p-exp.y (yylex, yyerror): Update.
2724         * m2-exp.y (parse_number, yylex, yyerror): Update.
2725         * go-exp.y (lex_one_token, yyerror): Update.
2726         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2727         * d-exp.y (lex_one_token, yyerror): Update.
2728         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2729         (lex_one_token, yyerror): Update.
2730         * ada-lex.l (YY_INPUT): Update.
2731         (rewind_to_char): Update.
2732         * ada-exp.y (yyerror): Update.
2733
2734 2019-04-04  Tom Tromey  <tom@tromey.com>
2735
2736         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2737         * parser-defs.h (struct parser_state) <parser_state>: Add new
2738         parameter.
2739         <comma_terminates>: New member.
2740         (comma_terminates): Don't declare global.
2741         * parse.c (comma_terminates): Remove global.
2742         (parse_exp_in_context): Update.
2743         * p-exp.y (yylex): Update.
2744         * m2-exp.y (yylex): Update.
2745         * go-exp.y (lex_one_token): Update.
2746         * f-exp.y (yylex): Update.
2747         * d-exp.y (lex_one_token): Update.
2748         * c-exp.y (lex_one_token): Update.
2749         * ada-lex.l: Update.
2750
2751 2019-04-04  Tom Tromey  <tom@tromey.com>
2752
2753         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2754         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2755         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2756         * parser-defs.h (paren_depth): Don't declare.
2757         * parse.c (paren_depth): Remove global.
2758         (parse_exp_in_context): Update.
2759         * p-exp.y (paren_depth): New global.
2760         (pascal_parse): Initialize it.
2761         * m2-exp.y (paren_depth): New global.
2762         (m2_parse): Initialize it.
2763         * go-exp.y (paren_depth): New global.
2764         (go_parse): Initialize it.
2765         * f-exp.y (paren_depth): New global.
2766         (f_parse): Initialize it.
2767         * d-exp.y (paren_depth): New global.
2768         (d_parse): Initialize it.
2769         * c-exp.y (paren_depth): New global.
2770         (c_parse): Initialize it.
2771         * ada-lex.l (paren_depth): New global.
2772         (lexer_init): Initialize it.
2773
2774 2019-04-04  Tom Tromey  <tom@tromey.com>
2775
2776         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2777         (rust_parser::convert_ast_to_type)
2778         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2779         * parser-defs.h (struct parser_state) <parser_state>: Add
2780         parameters.  Initialize new members.
2781         <expression_context_block, expression_context_pc>: New members.
2782         * parse.c (expression_context_block, expression_context_pc):
2783         Remove globals.
2784         (parse_exp_in_context): Update.
2785         * p-exp.y: Update all rules.
2786         (yylex): Update.
2787         * m2-exp.y: Update all rules.
2788         (yylex): Update.
2789         * go-exp.y (yylex): Update.
2790         * f-exp.y (yylex): Update.
2791         * d-exp.y: Update all rules.
2792         (yylex): Update.
2793         * c-exp.y: Update all rules.
2794         (lex_one_token, classify_name, yylex, c_parse): Update.
2795         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2796
2797 2019-04-04  Tom Tromey  <tom@tromey.com>
2798
2799         * gdbarch.h, gdbarch.c: Rebuild.
2800         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2801         * stap-probe.h:
2802         (struct stap_parse_info): Replace "parser_state" with
2803         "expr_builder".
2804         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2805         (parser_state): New class.
2806         * parse.c (expr_builder): Rename.
2807         (expr_builder::release): Rename.
2808         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2809         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2810         (write_exp_elt_longcst, write_exp_elt_floatcst)
2811         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2812         (write_exp_string_vector, write_exp_bitstring)
2813         (write_exp_msymbol, mark_struct_expression)
2814         (write_dollar_variable)
2815         (insert_type_address_space, increase_expout_size): Replace
2816         "parser_state" with "expr_builder".
2817         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2818         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2819         "parser_state" with "expr_builder".
2820
2821 2019-04-04  Tom Tromey  <tom@tromey.com>
2822
2823         * rust-exp.y: Replace "parse_language" with method call.
2824         * p-exp.y:
2825         (yylex): Replace "parse_language" with method call.
2826         * m2-exp.y:
2827         (yylex): Replace "parse_language" with method call.
2828         * go-exp.y (classify_name): Replace "parse_language" with method
2829         call.
2830         * f-exp.y (yylex): Replace "parse_language" with method call.
2831         * d-exp.y (lex_one_token): Replace "parse_language" with method
2832         call.
2833         * c-exp.y:
2834         (lex_one_token, classify_name, yylex): Replace "parse_language"
2835         with method call.
2836         * ada-exp.y (find_primitive_type, type_char)
2837         (type_system_address): Replace "parse_language" with method call.
2838
2839 2019-04-04  Tom Tromey  <tom@tromey.com>
2840
2841         * rust-exp.y: Replace "parse_gdbarch" with method call.
2842         * parse.c (write_dollar_variable, insert_type_address_space):
2843         Replace "parse_gdbarch" with method call.
2844         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2845         call.
2846         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2847         call.
2848         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2849         "parse_gdbarch" with method call.
2850         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2851         with method call.
2852         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2853         "parse_gdbarch" with method call.
2854         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2855         "parse_gdbarch" with method call.
2856         * c-exp.y (parse_type, parse_number, classify_name): Replace
2857         "parse_gdbarch" with method call.
2858         * ada-lex.l: Replace "parse_gdbarch" with method call.
2859         * ada-exp.y (parse_type, find_primitive_type, type_char)
2860         (type_system_address): Replace "parse_gdbarch" with method call.
2861
2862 2019-04-04  Tom Tromey  <tom@tromey.com>
2863
2864         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2865         * stap-probe.c (stap_parse_argument): Update.
2866         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2867         initial_size parameter.
2868         * rust-exp.y (rust_lex_tests): Update.
2869         * parse.c (parser_state): Update.
2870         (parse_exp_in_context): Update.
2871         * parser-defs.h (struct parser_state) <parser_state>: Remove
2872         "initial_size" parameter.
2873
2874 2019-04-04  Tom Tromey  <tom@tromey.com>
2875
2876         * parser-defs.h (increase_expout_size): Don't declare.
2877         * parse.c (increase_expout_size): Now static.
2878
2879 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2880
2881         * gnu-nat.c (gnu_nat_target::wait): Fix
2882         target_waitstatus_to_string call.
2883
2884 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * eval.c (evaluate_subexp_standard): Handle internal functions
2887         during Fortran function call handling.
2888
2889 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2890
2891         * NEWS: Mention new internal functions.
2892         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2893         (read_base_type): Use dwarf2_init_complex_target_type.
2894         * value.c (creal_internal_fn): New function.
2895         (cimag_internal_fn): New function.
2896         (_initialize_values): Register new internal functions.
2897
2898 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2899
2900         * infrun.c (stop_all_threads): If debug_infrun, always
2901         trace the wait status after wait_one, using
2902         target_waitstatus_to_string and target_pid_to_str.
2903         (handle_inferior_event): Replace various trace of
2904         wait status kind by a single trace.
2905         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2906         wait status kind image by target_waitstatus_to_string.
2907         * target/waitstatus.c (target_waitstatus_to_string): Fix
2908         obsolete comment.
2909
2910 2019-04-01  Tom Tromey  <tromey@adacore.com>
2911
2912         PR symtab/23331:
2913         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2914
2915 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2916             Pedro Alves  <palves@redhat.com>
2917
2918         * top.c (quit_force): Call 'finalize_values'.
2919         * value.c (finalize_values): New function.
2920         * value.h (finalize_values): Declare.
2921
2922 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2923
2924         * NEWS: Announce $_gdb_major and $_gdb_minor.
2925
2926         * top.c (init_gdb_version_vars): New function.
2927         (gdb_init): Call init_gdb_version_vars.
2928
2929 2019-03-29  Tom Tromey  <tromey@adacore.com>
2930
2931         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2932         help text.  Remove dead code.
2933
2934 2019-03-29  Keith Seitz  <keiths@redhat.com>
2935
2936         From Siddhesh Poyarekar:
2937         * f-lang.h (f77_get_upperbound): Return LONGEST.
2938         (f77_get_lowerbound): Likewise.
2939         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2940         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2941         print them.
2942         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2943         plongest to format print it.
2944         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2945         (f77_get_upperbound): Likewise.
2946         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2947         LOWER_BOUND to LONGEST.
2948         (f77_create_arrayprint_offset_tbl): Likewise.
2949
2950 2019-03-29  Keith Seitz  <keiths@redhat.com>
2951
2952         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2953         %s/pulongest for TYPE_LENGTH instead of %d in format
2954         strings.
2955         * ada-typerint.c (ada_print_type): Likewise.
2956         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2957         * compile/compile-c-support.c (generate_register_struct): Likewise.
2958         * gdbtypes.c (recursive_dump_type): Likewise.
2959         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2960         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2961         instead of %d in format strings.
2962         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2963         to std::min to ULONGEST.
2964         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2965         instead of %d in format strings.
2966         * tracepoint.c (info_scope_command): Likewise.
2967         * typeprint.c (print_offset_data::update)
2968         (print_offset_data::finish): Likewise.
2969         * xtensa-tdep.c (xtensa_store_return_value)
2970         (xtensa_push_dummy_call): Likewise.
2971
2972 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2973
2974         * windows-nat.c (display_selector): Fixed format specifications
2975         for 64-bit Cygwin.
2976
2977 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2978
2979         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2980
2981 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2982
2983         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2984         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2985         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2986         (nios2_linux_init_abi): Install it.
2987
2988 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2989
2990         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2991
2992 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2993
2994         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2995
2996 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2997             Tom Tromey  <tromey@adacore.com>
2998
2999         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3000
3001 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3002
3003         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3004         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3005         method to compute the bounds of range types. Also print "[evaluated]"
3006         if the bounds' values come from a dynamic evaluation.
3007
3008 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3011         whitespace when pretty printing is on.
3012
3013 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3014
3015         * ppc-linux-nat.c: Add include.
3016
3017 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3018
3019         * NEWS: Mention AArch64 Pointer Authentication.
3020
3021 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3022
3023         * arm-linux-nat.c: Add include.
3024
3025 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3026
3027         * source-cache.c (source_cache::get_source_lines): Re-read
3028         fullname after calling open_source_file.
3029
3030 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3031
3032         * NEWS: Mention TLS support for FreeBSD.
3033
3034 2019-03-25  Tom Tromey  <tromey@adacore.com>
3035
3036         * minsyms.c (BUNCH_SIZE): Update comment.
3037         (~minimal_symbol_reader): Remove old comment.
3038         (compact_minimal_symbols): Update comment.
3039         (minimal_symbol_reader::install): Remove old comment.  Update
3040         other comments.
3041
3042 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3043
3044         * s390-linux-nat.c: Add include.
3045
3046 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3047
3048         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3049         Call linux_get_hwcap.
3050         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3051         Likewise.
3052         (aarch64_linux_get_hwcap): Remove function.
3053         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3054         declaration.
3055         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3056         linux_get_hwcap.
3057         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3058         * linux-tdep.c (linux_get_hwcap): Add function.
3059         (linux_get_hwcap2): Likewise.
3060         * linux-tdep.h (linux_get_hwcap): Add declaration.
3061         (linux_get_hwcap2): Likewise.
3062         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3063         (ppc_linux_get_hwcap2): Likewise.
3064         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3065         linux_get_hwcap.
3066         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3067         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3068         (ppc_linux_nat_target::read_description): Likewise.
3069         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3070         * s390-linux-nat.c: Likewise.
3071         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3072
3073 2019-03-24  Tom Tromey  <tom@tromey.com>
3074
3075         * ada-lang.c (standard_lookup): Simplify initialization.
3076         (ada_lookup_symbol_nonlocal): Simplify return.
3077         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3078         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3079         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3080         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3081         initialization.
3082         * solib.c (solib_global_lookup): Simplify.
3083         * symtab.c (null_block_symbol): Remove.
3084         (symbol_cache_lookup): Simplify returns.
3085         (lookup_language_this): Simplify returns.
3086         (lookup_symbol_aux): Simplify return.
3087         (lookup_local_symbol): Simplify returns.
3088         (lookup_global_symbol_from_objfile): Simplify return.
3089         (lookup_symbol_in_objfile_symtabs)
3090         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3091         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3092         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3093         * cp-namespace.c (cp_lookup_bare_symbol)
3094         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3095         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3096         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3097         (cp_lookup_symbol_via_imports): Simplify initialization.
3098         (find_symbol_in_baseclass): Likewise.
3099         * symtab.h (null_block_symbol): Remove.
3100         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3101         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3102         (d_lookup_symbol_module): Likewise.
3103         (find_symbol_in_baseclass): Simplify initialization.
3104
3105 2019-03-24  Tom Tromey  <tom@tromey.com>
3106
3107         * expression.h: Don't include symtab.h.
3108         (struct block): Forward declare.
3109
3110 2019-03-24  Tom Tromey  <tom@tromey.com>
3111
3112         * c-exp.y (typebase): Remove casts.
3113         * gdbtypes.c (lookup_unsigned_typename, )
3114         (lookup_signed_typename): Remove cast.
3115         * eval.c (parse_to_comma_and_eval): Remove cast.
3116         * parse.c (write_dollar_variable): Remove cast.
3117         * block.h (struct block) <superblock>: Now const.
3118         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3119         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3120         (map_block): Make "block" const.
3121         * symfile.h (struct quick_symbol_functions)
3122         <map_matching_symbols>: Constify block argument to "callback".
3123         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3124         const.
3125         (find_pc_sect_compunit_symtab): Make "b" const.
3126         (find_symbol_at_address): Likewise.
3127         (search_symbols): Likewise.
3128         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3129         (dw2_debug_names_lookup_symbol): Likewise.
3130         (dw2_map_matching_symbols): Update.
3131         * p-valprint.c (pascal_val_print): Remove "block".
3132         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3133         (aux_add_nonlocal_symbols): Make "block" const.
3134         (resolve_subexp): Remove cast.
3135         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3136         const.
3137         (iterate_over_file_blocks): Likewise.
3138         * f-exp.y (%union) <bval>: Remove.
3139         * coffread.c (patch_opaque_types): Make "b" const.
3140         * spu-tdep.c (spu_catch_start): Make "block" const.
3141         * c-valprint.c (print_unpacked_pointer): Remove "block".
3142         * symmisc.c (dump_symtab_1): Make "b" const.
3143         (block_depth): Make "block" const.
3144         * d-exp.y (%union) <bval>: Remove.
3145         * cp-support.h (cp_lookup_rtti_type): Update.
3146         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3147         * psymtab.c (psym_lookup_symbol): Make "block" const.
3148         (maintenance_check_psymtabs): Make "b" const.
3149         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3150         (enumerate_locals, enumerate_args): Update.
3151         * python/py-symtab.c (stpy_global_block): Make "block" const.
3152         (stpy_static_block): Likewise.
3153         * inline-frame.c (block_starting_point_at): Make "new_block"
3154         const.
3155         * block.c (find_block_in_blockvector): Make return type const.
3156         (blockvector_for_pc_sect): Make "b" const.
3157         (find_block_in_blockvector): Make "b" const.
3158
3159 2019-03-23  Tom Tromey  <tom@tromey.com>
3160
3161         * varobj.c (varobj_create): Update.
3162         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3163         * printcmd.c (display_command, do_one_display): Don't reset
3164         innermost_block.
3165         * parser-defs.h (enum innermost_block_tracker_type): Move to
3166         expression.h.
3167         (innermost_block): Update comment.
3168         * parse.c (parse_exp_1): Add tracker_types parameter.
3169         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3170         tracker_types parameter.  Reset innermost_block.
3171         (parse_exp_in_context): Remove.
3172         (parse_expression_for_completion): Update.
3173         * objfiles.c (~objfile): Don't reset expression_context_block or
3174         innermost_block.
3175         * expression.h (enum innermost_block_tracker_type): Move from
3176         parser-defs.h.
3177         (parse_exp_1): Add tracker_types parameter.
3178         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3179         reset innermost_block.
3180
3181 2019-03-23  Tom Tromey  <tom@tromey.com>
3182
3183         * objfiles.h: Include bcache.h.
3184
3185 2019-03-23  Tom Tromey  <tom@tromey.com>
3186
3187         * linespec.c (get_current_search_block): Use
3188         scoped_restore_current_language.
3189         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3190
3191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3192             Jiong Wang  <jiong.wang@arm.com>
3193
3194         * aarch64-linux-tdep.c
3195         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3196         section.
3197         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3198
3199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3200             Jiong Wang  <jiong.wang@arm.com>
3201
3202         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3203         instructions.
3204         (aarch64_analyze_prologue_test): Add PACIASP test.
3205         (aarch64_prologue_prev_register): Unmask PC value.
3206
3207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3208             Jiong Wang  <jiong.wang@arm.com>
3209
3210         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3211         (aarch64_dwarf2_prev_register): Unmask PC value.
3212         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3213         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3214         DW_CFA_AARCH64_negate_ra_state.
3215         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3216
3217 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3218             Jiong Wang  <jiong.wang@arm.com>
3219
3220         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3221         registers.
3222         (aarch64_pseudo_register_name): Likewise.
3223         (aarch64_pseudo_register_type): Likewise.
3224         (aarch64_pseudo_register_reggroup_p): Likewise.
3225         (aarch64_gdbarch_init): Add pauth registers.
3226         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3227         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3228         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3229         (struct gdbarch_tdep): Add regnum for ra_state.
3230
3231 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3232             Jiong Wang  <jiong.wang@arm.com>
3233
3234         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3235
3236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3237             Jiong Wang  <jiong.wang@arm.com>
3238
3239         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3240         function.
3241         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3242         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3243         (aarch64_gdbarch_init): Add puth registers.
3244         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3245         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3246         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3247
3248 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3249             Jiong Wang  <jiong.wang@arm.com>
3250
3251         * aarch64-linux-nat.c
3252         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3253         * aarch64-linux-tdep.c
3254         (aarch64_linux_core_read_description): Likewise.
3255         (aarch64_linux_get_hwcap): New function.
3256         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3257         (aarch64_linux_get_hwcap): New declaration.
3258
3259 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3260             Jiong Wang  <jiong.wang@arm.com>
3261
3262         * aarch64-linux-nat.c
3263         (aarch64_linux_nat_target::read_description): Add pauth param.
3264         * aarch64-linux-tdep.c
3265         (aarch64_linux_core_read_description): Likewise.
3266         * aarch64-tdep.c (struct target_desc): Add in pauth.
3267         (aarch64_read_description): Add pauth param.
3268         (aarch64_gdbarch_init): Likewise.
3269         * aarch64-tdep.h (aarch64_read_description): Likewise.
3270         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3271         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3272         * features/Makefile: Add new files.
3273         * features/aarch64-pauth.c: New file.
3274         * features/aarch64-pauth.xml: New file.
3275
3276 2019-03-20  Tom Tromey  <tromey@adacore.com>
3277
3278         * infrun.c (handle_inferior_event): Rename from
3279         handle_inferior_event_1.  Create a scoped_value_mark.
3280         (handle_inferior_event): Remove.
3281
3282 2019-03-19  Tom Tromey  <tromey@adacore.com>
3283
3284         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3285         * infrun.h (print_stop_event): Add "displays" parameter.
3286         * infrun.c (print_stop_event): Add "displays" parameter.
3287
3288 2019-03-19  Pedro Alves  <palves@redhat.com>
3289
3290         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3291         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3292         to -1.  Fix TABs vs spaces.
3293         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3294         * tui/tui-out.h (tui_ui_out) Add intro comments.
3295         <m_line, m_start_of_line>: In-class initialize, and add describing
3296         comment.
3297
3298 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3299
3300         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3301         variable names.
3302         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3303
3304 2019-03-18  Pedro Alves  <palves@redhat.com>
3305             Eli Zaretskii <eliz@gnu.org>
3306
3307         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3308         m_line and m_start_of_line.
3309
3310 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3311
3312         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3313         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3314         it returns a newline.  This fixes a regression in TU mode, whereby
3315         the next line is output on the same screen line as the user input.
3316
3317 2019-03-18  Tom Tromey  <tromey@adacore.com>
3318
3319         * minsyms.c (minimal_symbol_reader::install): Remove call to
3320         obstack_blank.
3321
3322 2019-03-18  Pedro Alves  <palves@redhat.com>
3323
3324         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3325         New globals.
3326         (apply_style): New, factored out from ...
3327         (apply_ansi_escape): ... this.  Handle reverse video mode.
3328         (tui_set_reverse_mode): New function.
3329         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3330         * tui/tui-winsource.c (tui_show_source_line): Use
3331         tui_set_reverse_mode instead of setting A_STANDOUT.
3332         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3333         New setter methods.
3334
3335 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3336
3337         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3338         Handle tabs.
3339
3340 2019-03-18  Tom Tromey  <tromey@adacore.com>
3341
3342         * ada-lang.c (empty_array): Add "high" parameter.
3343         (ada_evaluate_subexp): Update.
3344
3345 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3346
3347         * unittests/string_view-selftests.c: Define
3348         _initialize_string_view_selftests unconditionally.
3349
3350 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3351
3352         PR gdb/24350
3353         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3354
3355 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3356
3357         PR gdb/24351
3358         * windows-nat.c (display_selector): Fix format specifiers.
3359
3360 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3361
3362         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3363         tui_refill_source_window instead of tui_refresh_win, to update the
3364         current execution line.  This fixes redisplay of the current line
3365         when stepping through the code with "next" or "step".
3366
3367 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3368
3369         * source-cache.c (source_cache::get_source_lines): Call
3370         find_source_lines to initialize s->nlines.  This fixes vertical
3371         scrolling of TUI source window when the DOWN arrow is pressed.
3372
3373 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3374
3375         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3376         linux-thread-db.c (_initialize_thread_db): Likewise.
3377
3378 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3379
3380         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3381         wclrtoeol in tui_show_source_line".  This reverts changes made in
3382         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3383
3384 2019-03-15  Tom Tromey  <tom@tromey.com>
3385
3386         * symtab.h (struct minimal_symbol): Derive from
3387         general_symbol_info.
3388         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3389         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3390         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3391         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3392         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3393         (MSYMBOL_SEARCH_NAME): Update.
3394         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3395         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3396         * minsyms.c (minimal_symbol_reader::record_full): Update.
3397
3398 2019-03-15  Tom Tromey  <tom@tromey.com>
3399
3400         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3401
3402 2019-03-15  Tom Tromey  <tom@tromey.com>
3403
3404         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3405         unique_xmalloc_ptr.
3406         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3407         Update.
3408         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3409         (build_minimal_symbol_hash_tables)
3410         (minimal_symbol_reader::install): Update.
3411
3412 2019-03-15  Tom Tromey  <tom@tromey.com>
3413
3414         * symtab.c (create_demangled_names_hash): Update.
3415         (symbol_set_names): Update.
3416         * objfiles.h (struct objfile_per_bfd_storage)
3417         <demangled_names_hash>: Now an htab_up.
3418         * objfiles.c (objfile_per_bfd_storage): Simplify.
3419
3420 2019-03-15  Tom Tromey  <tom@tromey.com>
3421
3422         * objfiles.h (struct objfile_per_bfd_storage): Declare
3423         destructor.
3424         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3425         New.
3426         (get_objfile_bfd_data): Use new.  Don't initialize
3427         language_of_main.
3428         (free_objfile_per_bfd_storage): Remove.
3429         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3430
3431 2019-03-15  Tom Tromey  <tom@tromey.com>
3432
3433         * symfile.c (reread_symbols): Update.
3434         * objfiles.c (objfile::objfile): Update.
3435         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3436         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3437         comment.
3438         (minimal_symbol_reader::install): Update.
3439         (terminate_minimal_symbol_table): Remove.
3440         * jit.c (jit_object_close_impl): Update.
3441
3442 2019-03-15  Tom Tromey  <tom@tromey.com>
3443
3444         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3445         initializations.
3446
3447 2019-03-15  Tom Tromey  <tom@tromey.com>
3448
3449         * objfiles.h (struct objfile_per_bfd_storage)
3450         <demangled_hash_languages>: Now a bitset.
3451         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3452         (lookup_minimal_symbol): Update.
3453
3454 2019-03-15  Tom Tromey  <tom@tromey.com>
3455
3456         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3457         Don't return the symbol.
3458         * coffread.c (record_minimal_symbol): Use record_full.
3459
3460 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3461
3462         The MS-Windows port of ncurses fails to switch to a color pair if
3463         one or both of the colors are the implicit default colors.  This
3464         change records the default colors when TUI is initialized, and
3465         then specifies them explicitly when a color pair uses the default
3466         colors.  This allows color styling in TUI mode on MS-Windows.
3467
3468         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3469         ncurses_norm_attr.
3470         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3471         colors in ncurses_norm_attr.
3472         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3473         "none", replace it with the default color recorded in
3474         ncurses_norm_attr.
3475
3476 2019-03-14  Tom Tromey  <tromey@adacore.com>
3477
3478         * source-cache.h (class source_cache) <get_source_lines>: Return
3479         std::string.
3480         * source-cache.c (source_cache::extract_lines): Handle case where
3481         first_pos==npos.  Return std::string.
3482         (source_cache::get_source_lines): Update.
3483
3484 2019-03-14  Tom Tromey  <tromey@adacore.com>
3485
3486         * NEWS: Add item for "style sources" commands.
3487         * source-cache.c (source_cache::get_source_lines): Check
3488         source_styling.
3489         * cli/cli-style.c (source_styling): New global.
3490         (_initialize_cli_style): Add "style sources" commands.
3491         (show_style_sources): New function.
3492         * cli/cli-style.h (source_styling): Declare.
3493
3494 2019-03-14  Pedro Alves  <palves@redhat.com>
3495             Tom Tromey  <tromey@adacore.com>
3496
3497         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3498         * tui/tui-winsource.c (tui_refill_source_window): New function,
3499         from...
3500         (tui_horizontal_source_scroll): ... here.  Move some logic.
3501         * cli/cli-style.c (set_style_enabled): Notify new observable.
3502         * tui/tui-hooks.c (tui_redisplay_source): New function.
3503         (tui_attach_detach_observers): Attach or detach
3504         tui_redisplay_source.
3505         * observable.h (source_styling_changed): New observable.
3506         * observable.c: Define source_styling_changed observable.
3507
3508 2019-03-13  Tom Tromey  <tromey@adacore.com>
3509
3510         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3511         (i386_gnu_nat_target::store_registers): Update.
3512         * target-debug.h (target_debug_print_std_string): New macro.
3513         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3514         * windows-tdep.c (display_one_tib): Update.
3515         * tui/tui-stack.c (tui_make_status_line): Update.
3516         * top.c (print_inferior_quit_action): Update.
3517         * thread.c (thr_try_catch_cmd): Update.
3518         (add_thread_with_info): Update.
3519         (thread_target_id_str): Update.
3520         (thr_try_catch_cmd): Update.
3521         (thread_command): Update.
3522         (thread_find_command): Update.
3523         * record-btrace.c (record_btrace_target::info_record)
3524         (record_btrace_resume_thread, record_btrace_target::resume)
3525         (record_btrace_cancel_resume, record_btrace_step_thread)
3526         (record_btrace_target::wait, record_btrace_target::wait)
3527         (record_btrace_target::wait, record_btrace_target::stop): Update.
3528         * progspace.c (print_program_space): Update.
3529         * process-stratum-target.c
3530         (process_stratum_target::thread_address_space): Update.
3531         * linux-fork.c (linux_fork_mourn_inferior)
3532         (detach_checkpoint_command, info_checkpoints_command)
3533         (linux_fork_context): Update.
3534         (linux_fork_detach): Update.
3535         (class scoped_switch_fork_info): Update.
3536         (delete_checkpoint_command): Update.
3537         * infrun.c (follow_fork_inferior): Update.
3538         (follow_fork_inferior): Update.
3539         (proceed_after_vfork_done): Update.
3540         (handle_vfork_child_exec_or_exit): Update.
3541         (follow_exec): Update.
3542         (displaced_step_prepare_throw): Update.
3543         (displaced_step_restore): Update.
3544         (start_step_over): Update.
3545         (resume_1): Update.
3546         (clear_proceed_status_thread): Update.
3547         (proceed): Update.
3548         (print_target_wait_results): Update.
3549         (do_target_wait): Update.
3550         (context_switch): Update.
3551         (stop_all_threads): Update.
3552         (restart_threads): Update.
3553         (finish_step_over): Update.
3554         (handle_signal_stop): Update.
3555         (switch_back_to_stepped_thread): Update.
3556         (keep_going_pass_signal): Update.
3557         (print_exited_reason): Update.
3558         (normal_stop): Update.
3559         * inferior.c (inferior_pid_to_str): Change return type.
3560         (print_selected_inferior): Update.
3561         (add_inferior): Update.
3562         (detach_inferior): Update.
3563         * dummy-frame.c (fprint_dummy_frames): Update.
3564         * dcache.c (dcache_info_1): Update.
3565         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3566         (btrace_fetch, btrace_clear): Update.
3567         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3568         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3569         type.
3570         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3571         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3572         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3573         * gdbarch.c, gdbarch.h: Rebuild.
3574         * gdbarch.sh (core_pid_to_str): Change return type.
3575         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3576         return type.
3577         (windows_nat_target::pid_to_str): Change return type.
3578         (windows_delete_thread): Update.
3579         (windows_nat_target::attach): Update.
3580         (windows_nat_target::files_info): Update.
3581         * target-delegates.c: Rebuild.
3582         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3583         return type.
3584         (sol_thread_target::pid_to_str): Change return type.
3585         * remote.c (class remote_target) <pid_to_str>: Change return
3586         type.
3587         (remote_target::pid_to_str): Change return type.
3588         (extended_remote_target::attach, remote_target::remote_stop_ns)
3589         (remote_target::remote_notif_remove_queued_reply)
3590         (remote_target::push_stop_reply, remote_target::disable_btrace):
3591         Update.
3592         (extended_remote_target::attach): Update.
3593         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3594         type.
3595         (gdbsim_target::pid_to_str): Change return type.
3596         * ravenscar-thread.c (struct ravenscar_thread_target)
3597         <pid_to_str>: Change return type.
3598         (ravenscar_thread_target::pid_to_str): Change return type.
3599         * procfs.c (class procfs_target) <pid_to_str>: Change return
3600         type.
3601         (procfs_target::pid_to_str): Change return type.
3602         (procfs_target::attach): Update.
3603         (procfs_target::detach): Update.
3604         (procfs_target::fetch_registers): Update.
3605         (procfs_target::store_registers): Update.
3606         (procfs_target::wait): Update.
3607         (procfs_target::files_info): Update.
3608         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3609         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3610         return type.
3611         (nto_procfs_target::pid_to_str): Change return type.
3612         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3613         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3614         return type.
3615         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3616         (exit_lwp): Update.
3617         (attach_proc_task_lwp_callback, get_detach_signal)
3618         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3619         (linux_nat_target::resume, wait_lwp, stop_callback)
3620         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3621         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3622         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3623         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3624         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3625         type.
3626         (inf_ptrace_target::attach): Update.
3627         (inf_ptrace_target::files_info): Update.
3628         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3629         type.
3630         (go32_nat_target::pid_to_str): Change return type.
3631         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3632         (gnu_nat_target::wait): Update.
3633         (gnu_nat_target::wait): Update.
3634         (gnu_nat_target::resume): Update.
3635         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3636         (fbsd_nat_target::wait): Update.
3637         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3638         type.
3639         (darwin_nat_target::attach): Update.
3640         * corelow.c (class core_target) <pid_to_str>: Change return type.
3641         (core_target::pid_to_str): Change return type.
3642         * target.c (normal_pid_to_str): Change return type.
3643         (default_pid_to_str): Likewise.
3644         (target_pid_to_str): Change return type.
3645         (target_translate_tls_address): Update.
3646         (target_announce_detach): Update.
3647         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3648         return type.
3649         (bsd_uthread_target::pid_to_str): Change return type.
3650         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3651         type.
3652         (bsd_kvm_target::pid_to_str): Change return type.
3653         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3654         return type.
3655         (aix_thread_target::pid_to_str): Change return type.
3656         * target.h (struct target_ops) <pid_to_str>: Change return type.
3657         (target_pid_to_str, normal_pid_to_str): Likewise.
3658         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3659         type.
3660         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3661         type.
3662         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3663         return type.
3664         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3665         type.
3666         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3667         type.
3668         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3669         return type.
3670
3671 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3672
3673         * NEWS: Mention that the new default MI version is 3.  Mention
3674         changes to the output of commands and events that deal with
3675         multi-location breakpoints.
3676         * breakpoint.c: Include "mi/mi-out.h".
3677         (print_one_breakpoint): Change output syntax if using MI version
3678         >= 3.
3679         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3680         New.
3681         (mi_multi_location_breakpoint_output_fixed): New.
3682         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3683         (mi_cmd_fix_multi_location_breakpoint_output): New.
3684         (mi_multi_location_breakpoint_output_fixed): New.
3685         * mi/mi-cmds.c (mi_cmds): Register command
3686         -fix-multi-location-breakpoint-output.
3687         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3688         interpreter "mi".
3689
3690 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3691
3692         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3693         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3694         instantiate mi_ui_out based on interpreter name.
3695         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3696         * mi/mi-main.c (mi_load_progress): Likewise.
3697
3698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3699
3700         * NEWS: Combine separate "New targets" sections for 8.3.
3701
3702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3703
3704         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3705         (ppcfbsd_init_abi): Install gdbarch
3706         "fetch_tls_load_module_address" and "get_thread_local_address"
3707         methods.
3708
3709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3710
3711         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3712         (riscv_fbsd_init_abi): Install gdbarch
3713         "fetch_tls_load_module_address" and "get_thread_local_address"
3714         methods.
3715
3716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3717
3718         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3719         (i386fbsd_init_abi): Install gdbarch
3720         "fetch_tls_load_module_address" and "get_thread_local_address"
3721         methods.
3722
3723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3724
3725         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3726         (amd64fbsd_init_abi): Install gdbarch
3727         "fetch_tls_load_module_address" and "get_thread_local_address"
3728         methods.
3729
3730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3731
3732         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3733         (struct fbsd_pspace_data): New type.
3734         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3735         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3736         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3737         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3738         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3739
3740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3741
3742         * gdbtypes.c (lookup_struct_elt): New function.
3743         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3744         * gdbtypes.h (struct struct_elt): New type.
3745         (lookup_struct_elt): New prototype.
3746
3747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3748
3749         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3750         remove disabled code block.
3751
3752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3753
3754         * gdbarch.sh (get_thread_local_address): New method.
3755         * gdbarch.h, gdbarch.c: Regenerate.
3756         * target.c (target_translate_tls_address): Use
3757         gdbarch_get_thread_local_address if present instead of
3758         target::get_thread_local_address.
3759
3760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3761
3762         * target.h (target::get_thread_local_address): Update comment.
3763
3764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3765
3766         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3767         objfile->separate_debug_objfile_backlink if not NULL.
3768
3769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3770
3771         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3772         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3773         (amd64bsd_store_inferior_registers): Likewise.
3774         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3775         Enable segment base registers.
3776         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3777         PT_GETFSBASE and PT_GETGSBASE.
3778         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3779         PT_SETGSBASE.
3780         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3781         segment base registers.
3782         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3783
3784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3785
3786         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3787         Update calls to i386_target_description to add 'segments'
3788         parameter.
3789         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3790         add segment base registers.
3791         * arch/i386.c (i386_create_target_description): Add 'segments'
3792         parameter to enable segment base registers.
3793         * arch/i386.h (i386_create_target_description): Likewise.
3794         * features/i386/32bit-segments.xml: New file.
3795         * features/i386/32bit-segments.c: Generate.
3796         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3797         call to i386_target_description to add 'segments' parameter.
3798         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3799         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3800         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3801         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3802         if feature is present.
3803         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3804         Add 'segments' parameter to call to i386_target_description.
3805         (i386_target_description): Add 'segments' parameter to enable
3806         segment base registers.
3807         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3808         to call to i386_target_description.
3809         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3810         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3811         Define I386_NUM_REGS.
3812         (i386_target_description): Add 'segments' parameter to enable
3813         segment base registers.
3814
3815 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3816
3817         PR/24325
3818         * source-cache.c: #undef open and close, to avoid unresolved
3819         externals during linking.
3820
3821 2019-03-12  Tom Tromey  <tromey@adacore.com>
3822
3823         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3824         const.  Add initializers.
3825         (_initialize_remote): Don't initialize ptid globals.
3826
3827 2019-03-12  Pedro Alves  <palves@redhat.com>
3828
3829         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3830
3831 2019-03-12  Pedro Alves  <palves@redhat.com>
3832
3833         * cp-name-parser.y (main): Remove unused 'len' variable.
3834
3835 2019-03-12  Tom Tromey  <tromey@adacore.com>
3836
3837         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3838         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3839
3840 2019-03-12  Tom Tromey  <tromey@adacore.com>
3841
3842         * linux-nat.c (iterate_over_lwps): Update.
3843         (stop_callback): Remove parameter.
3844         (stop_wait_callback, detach_callback, resume_set_callback)
3845         (select_singlestep_lwp_callback, set_ignore_sigint)
3846         (status_callback, resumed_callback, resume_clear_callback)
3847         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3848         data parameter.
3849         (linux_nat_target::detach, linux_nat_target::resume)
3850         (linux_stop_and_wait_all_lwps, select_event_lwp)
3851         (linux_nat_filter_event, linux_nat_wait_1)
3852         (linux_nat_target::kill, linux_nat_target::stop)
3853         (linux_nat_target::stop): Update.
3854         (linux_nat_resume_callback): Change type.
3855         (resume_stopped_resumed_lwps, count_events_callback)
3856         (select_event_lwp_callback): Likewise.
3857         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3858         * arm-linux-nat.c (struct update_registers_data): Remove.
3859         (update_registers_callback): Change type.
3860         (arm_linux_insert_hw_breakpoint1): Update.
3861         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3862         parameter.
3863         (x86_linux_dr_set_addr): Update.
3864         (x86_linux_dr_set_control): Update.
3865         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3866         (iterate_over_lwps): Use gdb::function_view.
3867         * nat/aarch64-linux-hw-point.c (struct
3868         aarch64_dr_update_callback_param): Remove.
3869         (debug_reg_change_callback): Change type.
3870         (aarch64_notify_debug_reg_change): Update.
3871         * s390-linux-nat.c (s390_refresh_per_info): Update.
3872
3873 2019-03-11  Tom Tromey  <tromey@adacore.com>
3874
3875         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3876         redundant assignment to "this_cu".
3877
3878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3879
3880         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3881
3882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3883
3884         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3885         from...
3886         (rank_one_type): ... this.
3887
3888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3889
3890         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3891         from...
3892         (rank_one_type): ... this.
3893
3894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3895
3896         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3897         from...
3898         (rank_one_type): ... this.
3899
3900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3901
3902         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3903         from...
3904         (rank_one_type): ... this.
3905
3906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3907
3908         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3909         from...
3910         (rank_one_type): ... this.
3911
3912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3913
3914         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3915         from...
3916         (rank_one_type): ... this.
3917
3918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3919
3920         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3921         from...
3922         (rank_one_type): ... this.
3923
3924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3925
3926         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3927         from...
3928         (rank_one_type): ... this.
3929
3930 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3931
3932         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3933         from...
3934         (rank_one_type): ... this.
3935
3936 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3937
3938         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3939         from...
3940         (rank_one_type): ... this.
3941
3942 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3943
3944         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3945         from...
3946         (rank_one_type): ... this.
3947
3948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3949
3950         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3951         from...
3952         (rank_one_type): ... this.
3953
3954 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3955
3956         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3957         inferior-events' shows the example events.
3958
3959 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3960
3961         Support styling on native MS-Windows console
3962
3963         PR/24315
3964         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3965         on MS-Windows if $TERM is not defined.
3966
3967         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3968
3969         * posix-hdep.c (gdb_console_fputs):
3970         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3971         functions.
3972         * ui-file.h (gdb_console_fputs): Add prototype.
3973
3974         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3975         back to fputs only if the former returns zero.
3976
3977 2019-03-07  Tom Tromey  <tom@tromey.com>
3978
3979         * symmisc.c (print_symbol_bcache_statistics): Update.
3980         (print_objfile_statistics): Update.
3981         * symfile.c (allocate_symtab): Update.
3982         * stabsread.c: Don't include bcache.h.
3983         * psymtab.h (struct psymbol_bcache): Don't declare.
3984         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3985         (psymbol_bcache_init, psymbol_bcache_free)
3986         (psymbol_bcache_get_bcache): Don't declare.
3987         * psymtab.c (struct psymbol_bcache): Remove.
3988         (psymtab_storage::psymtab_storage): Update.
3989         (psymtab_storage::~psymtab_storage): Update.
3990         (psymbol_bcache_init, psymbol_bcache_free)
3991         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3992         (add_psymbol_to_bcache): Update.
3993         (allocate_psymtab): Update.
3994         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3995         macro_cache>: No longer pointers.
3996         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3997         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3998         * macrotab.c (macro_bcache): Update.
3999         * macroexp.c: Don't include bcache.h.
4000         * gdbtypes.c (check_types_worklist): Update.
4001         (types_deeply_equal): Remove TRY/CATCH.  Update.
4002         * elfread.c (elf_symtab_read): Update.
4003         * dwarf2read.c: Don't include bcache.h.
4004         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4005         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4006         (print_bcache_statistics, bcache_memory_used): Don't declare.
4007         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4008         methods.  Rename all data members.
4009         * bcache.c (struct bcache): Move to bcache.h.
4010         (bcache::expand_hash_table): Rename from expand_hash_table.
4011         (bcache): Remove.
4012         (bcache::insert): Rename from bcache_full.
4013         (bcache::compare): Rename from bcache_compare.
4014         (bcache_xmalloc): Remove.
4015         (bcache::~bcache): Rename from bcache_xfree.
4016         (bcache::print_statistics): Rename from print_bcache_statistics.
4017         (bcache::memory_used): Rename from bcache_memory_used.
4018
4019 2019-03-07  Pedro Alves  <palves@redhat.com>
4020
4021         * infrun.c (normal_stop): Also check for
4022         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4023
4024 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4025
4026         * f-lang.c (value_from_host_double): Moved to...
4027         * value.c (value_from_host_double): ...here.
4028         * value.h (value_from_host_double): Declare.
4029         * guile/scm-math.c (vlscm_convert_typed_number): Use
4030         value_from_host_double.
4031         (vlscm_convert_number): Likewise.
4032         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4033         * python/py-value.c (convert_value_from_python): Likewise.
4034
4035 2019-03-06  Tom Tromey  <tom@tromey.com>
4036
4037         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4038
4039 2019-03-06  Tom Tromey  <tom@tromey.com>
4040
4041         * utils.h (free_current_contents): Don't declare.
4042         * utils.c (free_current_contents): Remove.
4043
4044 2019-03-06  Tom Tromey  <tom@tromey.com>
4045
4046         * top.c (quit_force): Update.
4047         * main.c (captured_command_loop): Update.
4048         * common/new-op.c (operator new): Update.
4049         * common/common-exceptions.c (struct catcher)
4050         <save_cleanup_chain>: Remove member.
4051         (exceptions_state_mc_init): Update.
4052         (exception_try_scope_entry): Return nullptr.
4053         (exception_try_scope_exit, exception_rethrow)
4054         (throw_exception_sjlj, throw_exception_cxx): Update.
4055         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4056         (all_cleanups, do_cleanups, discard_cleanups)
4057         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4058         (restore_cleanups, restore_final_cleanups): Don't declare.
4059         (do_final_cleanups): Remove parameter.
4060         * common/cleanups.c (cleanup_chain, make_cleanup)
4061         (make_cleanup_dtor, all_cleanups, do_cleanups)
4062         (discard_my_cleanups, discard_cleanups)
4063         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4064         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4065         (null_cleanup): Remove.
4066         (do_final_cleanups): Remove parameter.
4067
4068 2019-03-06  Tom Tromey  <tom@tromey.com>
4069
4070         * remote.c (remote_target::remote_parse_stop_reply): Use
4071         unique_xmalloc_ptr.
4072
4073 2019-03-06  Tom Tromey  <tom@tromey.com>
4074
4075         * stabsread.c (struct stabs_field_info): Rename from field_info.
4076         <list, fnlist>: Add initializers.
4077         <obstack>: New member.
4078         (read_member_functions, read_struct_fields, read_baseclasses):
4079         Allocate on obstack.  Don't use cleanups.
4080         (read_one_struct_field, read_member_functions, read_struct_fields)
4081         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4082         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4083         (read_struct_type): Update.
4084
4085 2019-03-06  Tom Tromey  <tom@tromey.com>
4086
4087         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4088         * common/filestuff.h (make_cleanup_close): Don't declare.
4089         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4090         Remove.
4091
4092 2019-03-06  Tom Tromey  <tom@tromey.com>
4093
4094         * solib-aix.c: Use make_scope_exit.
4095
4096 2019-03-06  Tom Tromey  <tom@tromey.com>
4097
4098         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4099         Use make_scope_exit.
4100
4101 2019-03-06  Tom Tromey  <tom@tromey.com>
4102
4103         * solib-svr4.c (disable_probes_interface): Remove parameter.
4104         (svr4_handle_solib_event): Use make_scope_exit.
4105
4106 2019-03-06  Tom Tromey  <tom@tromey.com>
4107
4108         * remote.c (struct stop_reply_deleter): Remove.
4109         (stop_reply_up): Update.
4110         (struct stop_reply): Derive from notif_event.  Don't typedef.
4111         <regcache>: Now a std::vector.
4112         (stop_reply_xfree): Remove.
4113         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4114         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4115         (remote_target::discard_pending_stop_replies): Use delete.
4116         (remote_target::remote_parse_stop_reply): Update.
4117         (remote_target::process_stop_reply): Update.
4118         * remote-notif.h (struct notif_event): Add virtual destructor.
4119         Remove "dtr" member.
4120         (struct notif_client) <alloc_event>: Return a unique_ptr.
4121         (notif_event_xfree): Don't declare.
4122         (notif_event_up): New typedef.
4123         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4124         (notif_event_xfree, do_notif_event_xfree): Remove.
4125         (remote_notif_state_xfree): Update.
4126
4127 2019-03-06  Tom Tromey  <tom@tromey.com>
4128
4129         * infrun.c (displaced_step_clear_cleanup): Now a
4130         forward_scope_exit type.
4131         (displaced_step_prepare_throw): Update.
4132         (displaced_step_fixup): Update.
4133
4134 2019-03-06  Tom Tromey  <tom@tromey.com>
4135
4136         * inferior.h (class inferior): Update comment.
4137         * gdbthread.h (class thread_info): Update comment.
4138
4139 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4140             Tom Tromey  <tom@tromey.com>
4141
4142         * stabsread.h (struct stab_section_list): Remove.
4143         (coffstab_build_psymtabs): Update.
4144         * dbxread.c (symbuf_sections): Now a std::vector.
4145         (sect_idx): New global.
4146         (fill_symbuf): Update.
4147         (coffstab_build_psymtabs): Change type of stabsects parameter.
4148         Update.
4149         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4150         std::vector.
4151         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4152         (coff_locate_sections): Update.
4153         (coff_symfile_read): Remove cleanups.  Update.
4154         (init_stringtab): Add storage parameter.
4155         (free_stringtab, free_stringtab_cleanup): Remove.
4156         (init_lineno): Add storage parameter.
4157         (free_linetab, free_linetab_cleanup): Remove.
4158
4159 2019-03-06  Pedro Alves  <palves@redhat.com>
4160
4161         * linux-fork.c (fork_info::clobber_regs): Delete.
4162         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4163         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4164         comment.  Adjust.
4165         (scoped_switch_fork_info::scoped_switch_fork_info)
4166         (checkpoint_command, linux_fork_context): Adjust
4167         fork_save_infrun_state calls.
4168
4169 2019-03-06  Pedro Alves  <palves@redhat.com>
4170
4171         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4172         (inf_has_multiple_threads): Return 'bool' and rewrite using
4173         inferior_info::threads().
4174
4175 2019-03-06  Pedro Alves  <palves@redhat.com>
4176
4177         * linux-fork.c: Include <list>.
4178         (fork_list): Now a std::list instance.
4179         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4180         (forks_exist_p, find_last_fork): Adjust.
4181         (new_fork): Delete.
4182         (one_fork_p): New.
4183         (add_fork): Adjust.
4184         (free_fork): Delete, folded into fork_info::~fork_info().
4185         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4186         Adjust.
4187         (init_fork_list): Delete.
4188         (linux_fork_killall, linux_fork_mourn_inferior)
4189         (linux_fork_detach, info_checkpoints_command): Adjust.
4190         (_initialize_linux_fork): No longer call init_fork_list.
4191
4192 2019-03-06  Pedro Alves  <palves@redhat.com>
4193
4194         * linux-fork.c (new_fork): New, split out of ...
4195         (add_fork): ... this.  Return void.  Move "first fork" special
4196         case from here, to ...
4197         (checkpoint_command): ... here.
4198         * linux-linux.h (add_fork): Return void.
4199
4200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4201
4202         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4203
4204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4205             Chris January  <chris.january@arm.com>
4206             David Lecomber  <david.lecomber@arm.com>
4207
4208         * f-exp.y: New token, UNOP_INTRINSIC.
4209         (exp): New pattern using UNOP_INTRINSIC token.
4210         (f77_keywords): Add 'abs' keyword.
4211         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4212         (value_from_host_double): New function.
4213         (evaluate_subexp_f): Support UNOP_ABS.
4214
4215 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4216
4217         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4218         types.
4219
4220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4221
4222         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4223         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4224         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4225
4226 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4227
4228         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4229
4230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4231             Chris January  <chris.january@arm.com>
4232
4233         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4234         * f-exp.y: Define 'KIND' token.
4235         (exp): New pattern for KIND expressions.
4236         (ptype): Handle types with a kind extension.
4237         (direct_abs_decl): Extend to spot kind extensions.
4238         (f77_keywords): Add 'kind' to the list.
4239         (push_kind_type): New function.
4240         (convert_to_kind_type): New function.
4241         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4242         * parse.c (operator_length_standard): Likewise.
4243         * parser-defs.h (enum type_pieces): Add tp_kind.
4244         * std-operator.def: Add UNOP_KIND.
4245
4246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * f-exp.y (f_parse): Set yydebug.
4249
4250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * f-lang.c (evaluate_subexp_f): New function.
4253         (exp_descriptor_f): New global.
4254         (f_language_defn): Use exp_descriptor_f instead of
4255         exp_descriptor_standard.
4256
4257 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * f-exp.y (struct token): Add comments.
4260         (dot_ops): Remove uppercase versions and the end marker.
4261         (f77_keywords): Likewise.
4262         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4263         entries in the dot_ops array are case insensitive, and use
4264         strncasecmp to compare strings.  Also some whitespace cleanup in
4265         this area.  Similar for the f77_keywords array, except entries in
4266         this list might be case sensitive.
4267
4268 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4269
4270         * f-exp.y (struct f77_boolean_val): Add comments.
4271         (boolean_values): Remove uppercase versions, and end marker.
4272         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4273         and use strncasecmp to achieve case insensitivity.  Additionally,
4274         perform whitespace cleanup around this code.
4275
4276 2019-03-06  Tom Tromey  <tromey@adacore.com>
4277
4278         * remote-sim.c (gdbsim_target_open): Use result of
4279         gdb_argv::release.
4280
4281 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4282         Dirk Schubert  <dirk.schubert@arm.com>
4283         Chris January  <chris.january@arm.com>
4284
4285         * eval.c (evaluate_subexp_standard): Call Fortran argument
4286         wrapping logic.
4287         * f-lang.c (struct value): A value which can be passed into a
4288         Fortran function call.
4289         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4290         where appropriate.
4291         (struct type): Value ready for a Fortran function call.
4292         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4293         is needed.
4294         * f-lang.h (fortran_argument_convert): Declaration.
4295         (fortran_preserve_arg_pointer): Declaration.
4296         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4297
4298 2019-03-05  Tom Tromey  <tromey@adacore.com>
4299
4300         * python/py-prettyprint.c (print_string_repr): Remove #if.
4301         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4302
4303 2019-03-05  Tom Tromey  <tromey@adacore.com>
4304
4305         * target.c (the_dummy_target): Move later.  Change type to
4306         "dummy_target".
4307         (initialize_targets): Don't initialize the_dummy_target.
4308
4309 2019-03-05  Tom Tromey  <tromey@adacore.com>
4310
4311         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4312         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4313
4314 2019-03-05  Tom Tromey  <tromey@adacore.com>
4315
4316         * windows-nat.c (windows_nat_target::attach)
4317         (windows_nat_target::detach): Don't call gdb_flush.
4318         * valprint.c (generic_val_print, val_print, val_print_string):
4319         Don't call gdb_flush.
4320         * utils.c (defaulted_query): Don't call gdb_flush.
4321         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4322         * target.c (target_announce_detach): Don't call gdb_flush.
4323         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4324         * remote.c (extended_remote_target::attach): Don't call
4325         gdb_flush.
4326         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4327         * printcmd.c (do_examine): Don't call gdb_flush.
4328         (info_display_command): Don't call gdb_flush.
4329         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4330         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4331         * memattr.c (info_mem_command): Don't call gdb_flush.
4332         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4333         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4334         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4335         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4336         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4337         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4338         (gnu_nat_target::detach): Don't call gdb_flush.
4339         * f-valprint.c (f_val_print): Don't call gdb_flush.
4340         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4341         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4342         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4343         gdb_flush.
4344         * c-valprint.c (c_val_print): Don't call gdb_flush.
4345         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4346
4347 2019-03-05  Tom Tromey  <tromey@adacore.com>
4348
4349         * varobj.c (update_dynamic_varobj_children): Update.
4350         (install_default_visualizer): Use reset, not release.
4351         * value.c (set_internalvar): Update.
4352         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4353         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4354         ATTRIBUTE_UNUSED_RESULT.
4355
4356 2019-03-05  Tom Tromey  <tromey@adacore.com>
4357
4358         * remote.c (class scoped_remote_fd) <release>: Add
4359         ATTRIBUTE_UNUSED_RESULT.
4360
4361 2019-03-05  Tom Tromey  <tromey@adacore.com>
4362
4363         * macroexp.c (struct macro_buffer) <release>: Add
4364         ATTRIBUTE_UNUSED_RESULT.
4365
4366 2019-03-05  Tom Tromey  <tromey@adacore.com>
4367
4368         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4369         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4370         ATTRIBUTE_UNUSED_RESULT.
4371
4372 2019-03-05  Tom Tromey  <tromey@adacore.com>
4373
4374         * common/scoped_fd.h (class scoped_fd) <release>: Add
4375         ATTRIBUTE_UNUSED_RESULT.
4376
4377 2019-03-05  Tom Tromey  <tromey@adacore.com>
4378
4379         * parser-defs.h (struct parser_state) <release>: Add
4380         ATTRIBUTE_UNUSED_RESULT.
4381
4382 2019-03-05  Tom Tromey  <tromey@adacore.com>
4383
4384         * utils.h (class gdb_argv) <release>: Add
4385         ATTRIBUTE_UNUSED_RESULT.
4386         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4387
4388 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4389
4390         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4391         for-loop range, to avoid compiler warnings.
4392
4393         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4394         avoid compiler warnings about unused variables.
4395
4396         * NEWS: Mention end of support for native debugging on MS-Windows
4397         before XP.
4398
4399         PR gdb/24292
4400         * common/netstuff.c:
4401         * gdbserver/gdbreplay.c
4402         * gdbserver/remote-utils.c:
4403         * ser-tcp.c:
4404         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4405         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4406         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4407         'getaddrinfo' and 'freeaddrinfo' were not available before
4408         Windows XP, and mingw.org's MinGW headers by default define
4409         _WIN32_WINNT to 0x500.
4410
4411 2019-03-01  Gary Benson <gbenson@redhat.com>
4412
4413         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4414
4415 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4416             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4417
4418         PR gdb/8527
4419         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4420         set_sigint_trap, clear_sigint_trap.
4421
4422 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4423
4424         * target.c (target_detach): Clear the regcache and the
4425         frame cache.
4426
4427 2019-02-27  Pedro Alves  <palves@redhat.com>
4428
4429         * utils.c (set_screen_size): When we cap the height/width sizes,
4430         tweak the corresponding command variable to show "unlimited":
4431
4432 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4433             Pedro Alves  <palves@redhat.com>
4434
4435         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4436         before calling rl_set_screen_size.
4437
4438 2019-02-27  Tom Tromey  <tromey@adacore.com>
4439
4440         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4441         define.
4442         * python/py-value.c: Remove Python 2.4 workaround.
4443         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4444         workaround.
4445         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4446         Python 2.4 workaround.
4447         * python/python-internal.h: Remove Python 2.4 comment.
4448         (Py_ssize_t): Don't define.
4449         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4450         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4451         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4452         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4453         * python/python.c (do_start_initialization): Remove Python 2.4
4454         workaround.
4455         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4456         (print_children): Remove Python 2.4 workaround.
4457         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4458         workaround.
4459         (CHARBUFFERPROC_NAME): Remove.
4460         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4461         Python 2.4 workaround.
4462
4463 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4464
4465         * NEWS: Note minimum Python version.
4466
4467 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4468
4469         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4470         code from these functions.  Remove corresponding ifdefs.  Use
4471         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4472         Remove gotos and target of gotos.
4473         (infpy_search_memory): Likewise.
4474
4475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4476
4477         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4478         (hppa_gdbarch_init): Don't register deleted functions with
4479         gdbarch.
4480
4481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4482
4483         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4484         (h8300_unwind_sp): Delete.
4485         (h8300_dummy_id): Delete.
4486         (h8300_gdbarch_init): Don't register deleted functions with
4487         gdbarch.
4488
4489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4490
4491         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4492         (ft32_unwind_pc): Delete.
4493         (ft32_unwind_sp): Delete.
4494         (ft32_gdbarch_init): Don't register deleted functions with
4495         gdbarch.
4496
4497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4498
4499         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4500         (frv_unwind_pc): Delete.
4501         (frv_unwind_sp): Delete.
4502         (frv_gdbarch_init): Don't register deleted functions with
4503         gdbarch.
4504
4505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4506
4507         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4508         (riscv_unwind_pc): Delete.
4509         (riscv_unwind_sp): Delete.
4510         (riscv_gdbarch_init): Don't register deleted functions with
4511         gdbarch.
4512
4513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4516         (csky_unwind_pc): Delete.
4517         (csky_unwind_sp): Delete.
4518         (csky_gdbarch_init): Don't register deleted functions with
4519         gdbarch.
4520
4521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4524         (cris_unwind_pc): Delete.
4525         (cris_unwind_sp): Delete.
4526         (cris_gdbarch_init): Don't register deleted functions with
4527         gdbarch.
4528
4529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4530
4531         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4532         (bfin_unwind_pc): Delete.
4533         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4534
4535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4538         (arm_unwind_pc): Delete.
4539         (arm_unwind_sp): Delete.
4540         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4541
4542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4543
4544         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4545         (arc_unwind_pc): Delete.
4546         (arc_unwind_sp): Delete.
4547         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4548
4549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4550
4551         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4552         (alpha_unwind_pc): Delete.
4553         (alpha_gdbarch_init): Don't register deleted functions with
4554         gdbarch.
4555
4556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4559         (aarch64_unwind_pc): Delete.
4560         (aarch64_unwind_sp): Delete.
4561         (aarch64_gdbarch_init): Don't register deleted functions with
4562         gdbarch.
4563
4564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4565
4566         * gdbtypes.c (type_align): Don't consider static members when
4567         computing structure alignment.
4568
4569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4570
4571         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4572         return 0 for other types.
4573         * arch-utils.c (default_type_align): Always return 0.
4574         * gdbarch.h: Regenerate.
4575         * gdbarch.sh (type_align): Extend comment.
4576         * gdbtypes.c (type_align): Add additional comments, always call
4577         gdbarch_type_align before applying the default rules.
4578         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4579         generic code will then apply a suitable default.
4580         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4581         types, return 0 for other types.
4582
4583 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4584
4585         * NEWS: Create a new section for the next release branch.
4586         Rename the section of the current branch, now that it has
4587         been cut.
4588
4589 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4590
4591         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4592         * version.in: Bump version to 8.3.50.DATE-git.
4593
4594 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4595
4596         * aix-thread.c (ptid_cmp): Remove unused variable.
4597         (get_signaled_thread): Likewise.
4598         (store_regs_user_thread): Likewise.
4599         (store_regs_kernel_thread): Likewise.
4600         (fetch_regs_kernel_thread): Remove shadowed variable.
4601
4602 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4603
4604         * features/riscv/32bit-cpu.xml: Add register numbers.
4605         * features/riscv/32bit-fpu.c: Regenerate.
4606         * features/riscv/32bit-fpu.xml: Add register numbers.
4607         * features/riscv/64bit-cpu.xml: Add register numbers.
4608         * features/riscv/64bit-fpu.c: Regenerate.
4609         * features/riscv/64bit-fpu.xml: Add register numbers.
4610
4611 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4612
4613         * NEWS: Mention two argument form of gdb.Value constructor.
4614         * python/py-value.c (convert_buffer_and_type_to_value): New
4615         function.
4616         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4617         Add support for handling an optional second argument.  Call
4618         convert_buffer_and_type_to_value as appropriate.
4619         * python/python-internal.h (Py_buffer_deleter): New struct.
4620         (Py_buffer_up): New typedef.
4621
4622 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4623
4624         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4625         instead of releasing ownership.
4626
4627 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4628
4629         * dwarf2read.c (open_and_init_dwp_file): Call
4630         elf_numsections instead of bfd_count_sections to initialize
4631         dwp_file->num_sections.
4632
4633 2019-02-25  Tom Tromey  <tromey@adacore.com>
4634
4635         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4636
4637 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4638
4639         * gcore.in: Add '--readnever' option when invoking GDB.
4640
4641 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4642
4643         * MAINTAINERS: Update my email address.
4644
4645 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4646
4647         * build-id.c (build_id_to_debug_bfd_1): New function.
4648         (build_id_to_debug_bfd): Look for separate debug file in
4649         sysroot.
4650
4651 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4652
4653         * gdbarch.sh: Update the copyright year range that is placed into
4654         generated files.
4655
4656 2019-02-22  Keith Seitz  <keiths@redhat.com>
4657
4658         PR symtab/23853
4659         * linespec.c (create_sals_line_offset): Search for the default
4660         symtab's filename instead of its fullname.
4661
4662 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4663
4664         * NEWS: Update style defaults.
4665
4666 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4667
4668         * main.c (captured_main_1): Disable styling in batch mode.
4669
4670 2019-02-20  Tom Tromey  <tom@tromey.com>
4671
4672         * symtab.c (symtab_symbol_info): Fix typos.
4673
4674 2019-02-20  Tom Tromey  <tromey@adacore.com>
4675
4676         * findcmd.c (_initialize_mem_search): Use upper case for
4677         metasyntactic variables.
4678
4679 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4680
4681         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4682         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4683
4684 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4685
4686         * top.h (source_file_name): Change to std::string.
4687         * top.c (source_file_name): Likewise.
4688         (command_line_input): Adjust.
4689         * cli/cli-script.c (script_from_file): Adjust.
4690
4691 2019-02-19  Tom Tromey  <tromey@adacore.com>
4692
4693         * ravenscar-thread.c
4694         (ravenscar_thread_target::update_thread_list): Don't call
4695         ada_build_task_list.
4696         * ada-lang.h (ada_build_task_list): Don't declare.
4697         * ada-tasks.c (struct ada_tasks_inferior_data)
4698         <task_list_valid_p>: Now bool.
4699         (read_known_tasks, ada_task_list_changed)
4700         (ada_tasks_invalidate_inferior_data): Update.
4701         (read_known_tasks_array): Return bool.
4702         (read_known_tasks_list): Likewise.
4703         (read_known_tasks): Return void.
4704         (ada_build_task_list): Now static.
4705
4706 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4707
4708         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4709         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4710
4711 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4712
4713         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4714         variant for ada_tasks_pspace_data_handle and
4715         ada_tasks_inferior_data_handle.
4716         (ada_tasks_pspace_data_cleanup): New function.
4717         (ada_tasks_inferior_data_cleanup): New function.
4718
4719 2019-02-17  Tom Tromey  <tom@tromey.com>
4720
4721         * macrotab.h (macro_source_fullname): Return a std::string.
4722         * macrotab.c (macro_include, check_for_redefinition)
4723         (macro_undef, macro_lookup_definition, foreach_macro)
4724         (foreach_macro_in_scope): Update.
4725         (macro_source_fullname): Return a std::string.
4726         * macrocmd.c (show_pp_source_pos): Update.
4727
4728 2019-02-17  Tom Tromey  <tom@tromey.com>
4729
4730         * macrocmd.c (show_pp_source_pos): Style the file names.
4731
4732 2019-02-17  Tom Tromey  <tom@tromey.com>
4733
4734         PR tui/24197:
4735         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4736
4737 2019-02-17  Tom Tromey  <tom@tromey.com>
4738
4739         * ada-lang.c (user_select_syms): Use filtered printing.
4740         * utils.c (wrap_style): New global.
4741         (desired_style): Remove.
4742         (emit_style_escape): Add stream parameter.
4743         (set_output_style, reset_terminal_style, prompt_for_continue):
4744         Update.
4745         (flush_wrap_buffer): Only flush gdb_stdout.
4746         (wrap_here): Set wrap_style.
4747         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4748         treat escape sequences as a character.  Change when wrap buffer is
4749         flushed.
4750         (fputs_styled): Do not set the output style when the default is
4751         requested.
4752         * ui-style.h (struct ui_file_style) <is_default>: New method.
4753         * source.c (print_source_lines_base): Emit escape sequences in one
4754         piece.
4755
4756 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4757
4758         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4759         integers and enumeration types.
4760
4761 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4762
4763         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4764         instead of lookup_symbol_in_language
4765         (do_exact_match): New function.
4766         (ada_get_symbol_name_matcher): Return do_exact_match when
4767         doing a verbatim match.
4768
4769 2019-02-15  Tom Tromey  <tromey@adacore.com>
4770
4771         * ravenscar-thread.c (ravenscar_thread_target::resume)
4772         (ravenscar_thread_target::wait): Special case wildcard requests.
4773
4774 2019-02-15  Tom Tromey  <tromey@adacore.com>
4775
4776         * ravenscar-thread.c (base_ptid): Remove.
4777         (struct ravenscar_thread_target) <close>: New method.
4778         <m_base_ptid>: New member.
4779         <update_inferior_ptid, active_task, task_is_currently_active,
4780         runtime_initialized>: Declare methods.
4781         <ravenscar_thread_target>: Add constructor.
4782         (ravenscar_thread_target::task_is_currently_active)
4783         (ravenscar_thread_target::update_inferior_ptid)
4784         (ravenscar_runtime_initialized): Rename.  Now methods.
4785         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4786         (ravenscar_thread_target::update_thread_list): Update.
4787         (ravenscar_thread_target::active_task): Now method.
4788         (ravenscar_thread_target::store_registers)
4789         (ravenscar_thread_target::prepare_to_store)
4790         (ravenscar_thread_target::prepare_to_store)
4791         (ravenscar_thread_target::mourn_inferior): Update.
4792         (ravenscar_inferior_created): Use "new" to create target.
4793         (ravenscar_thread_target::get_ada_task_ptid): Update.
4794         (_initialize_ravenscar): Don't initialize base_ptid.
4795         (ravenscar_ops): Remove global.
4796
4797 2019-02-15  Tom Tromey  <tromey@adacore.com>
4798
4799         * target.h (push_target): Declare new overload.
4800         * target.c (push_target): New overload, taking an rvalue reference.
4801         * remote.c (remote_target::open_1): Use push_target overload.
4802         * corelow.c (core_target_open): Use push_target overload.
4803
4804 2019-02-15  Tom Tromey  <tromey@adacore.com>
4805
4806         * ravenscar-thread.c (is_ravenscar_task)
4807         (ravenscar_task_is_currently_active): Return bool.
4808         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4809         (_initialize_ravenscar): Remove "(void)".
4810         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4811         Return bool.
4812
4813 2019-02-15  Tom Tromey  <tromey@adacore.com>
4814
4815         * ravenscar-thread.c (ravenscar_runtime_initializer)
4816         (has_ravenscar_runtime, get_running_thread_id)
4817         (ravenscar_thread_target::resume): Fix indentation.
4818
4819 2019-02-15  Tom Tromey  <tromey@adacore.com>
4820
4821         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4822         from ravenscar_arch_ops.
4823         (sparc_ravenscar_ops::fetch_registers)
4824         (sparc_ravenscar_ops::store_registers): Now methods.
4825         (sparc_ravenscar_prepare_to_store): Remove.
4826         (sparc_ravenscar_ops): Redefine.
4827         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4828         methods and destructor.  Remove members.
4829         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4830         (ravenscar_thread_target::store_registers)
4831         (ravenscar_thread_target::prepare_to_store): Update.
4832         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4833         Remove.
4834         (struct ppc_ravenscar_powerpc_ops): Derive from
4835         ravenscar_arch_ops.
4836         (ppc_ravenscar_powerpc_ops::fetch_registers)
4837         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4838         (ppc_ravenscar_powerpc_ops): Redefine.
4839         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4840         (ppc_ravenscar_e500_ops::fetch_registers)
4841         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4842         (ppc_ravenscar_e500_ops): Redefine.
4843         * aarch64-ravenscar-thread.c
4844         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4845         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4846         (aarch64_ravenscar_fetch_registers)
4847         (aarch64_ravenscar_store_registers): Now methods.
4848         (aarch64_ravenscar_ops): Redefine.
4849
4850 2019-02-15  Tom Tromey  <tromey@adacore.com>
4851
4852         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4853         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4854         (ravenscar_thread_target::stopped_by_watchpoint)
4855         (ravenscar_thread_target::stopped_data_address)
4856         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4857
4858 2019-02-15  Tom Tromey  <tromey@adacore.com>
4859
4860         * ravenscar-thread.c: Fix some typos.
4861
4862 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4863             Tom Tromey  <tromey@adacore.com>
4864
4865         * ada-lang.c (ada_exception_sal): Change addr_string to a
4866         std::string.
4867         (create_ada_exception_catchpoint): Update.
4868
4869 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4870             Tom Tromey  <tromey@adacore.com>
4871
4872         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4873         (bp_location_ops): Remove.
4874         (base_breakpoint_allocate_location): Update.
4875         (free_bp_location): Update.
4876         * ada-lang.c (class ada_catchpoint_location)
4877         <ada_catchpoint_location>: Remove ops parameter.
4878         (ada_catchpoint_location_dtor): Remove.
4879         (ada_catchpoint_location_ops): Remove.
4880         (allocate_location_exception): Update.
4881         * breakpoint.h (struct bp_location_ops): Remove.
4882         (class bp_location) <bp_location>: Remove bp_location_ops
4883         parameter.
4884         <~bp_location>: Add destructor.
4885         <ops>: Remove.
4886
4887 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4888             Pedro Alves  <palves@redhat.com>
4889
4890         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4891         'PATH_MAX'.
4892
4893 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4894             Samuel Thibault  <samuel.thibault@gnu.org>
4895             Thomas Schwinge  <thomas@codesourcery.com>
4896
4897         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4898         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4899
4900 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4901
4902         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4903         (check_empty): Use "const char *".
4904
4905         * gnu-nat.c (gnu_nat_target::detach): Instead of
4906         'detach_inferior (pid)' call
4907         'detach_inferior (find_inferior_pid (pid))'.
4908
4909         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4910         'nat/fork-inferior.o'.
4911         * gnu-nat.c: #include "nat/fork-inferior.h".
4912
4913         * gnu-nat.c (gnu_nat_target::detach): Instead of
4914         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4915         * gnu-nat.h: #include "inf-child.h".
4916         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4917         'i386_gnu_nat_target::fetch_registers'.
4918         (gnu_store_registers): Rename/move to
4919         'i386_gnu_nat_target::store_registers'.
4920
4921         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4922         * gnu-nat.h (mach_thread_info): New function.
4923         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4924
4925         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4926
4927 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4928
4929         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4930
4931 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4932
4933         * windows-nat.c (windows_add_thread): Add new parameter
4934         "main_thread_p" with default value set to false.  Update
4935         function documentation as well as all callers.
4936         (windows_delete_thread): Likewise.
4937         (fake_create_process): Update call to windows_add_thread.
4938         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4939         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4940         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4941         call to windows_delete_thread.
4942
4943 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4944
4945         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4946
4947 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4948
4949         * symfile.c (find_separate_debug_file): Use canonical path of
4950         sysroot with child_path instead of gdb_sysroot if it is valid.
4951
4952 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4953
4954         * symfile.c (find_separate_debug_file): Use child_path to
4955         determine if an object file is under a sysroot.
4956
4957 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4958
4959         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4960         unittests/child-path-selftests.c.
4961         * common/pathstuff.c (child_path): New function.
4962         * common/pathstuff.h (child_path): New prototype.
4963         * unittests/child-path-selftests.c: New file.
4964
4965 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4966
4967         * symfile.c (find_separate_debug_file): Look for separate debug
4968         files in debug directories under the sysroot.
4969
4970 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4971
4972         * symtab.h (struct minimal_symbol data_p): New const method.
4973         (struct minimal_symbol text_p): Likewise.
4974         * symtab.c (output_source_filename): Use file name style
4975         to print file name.
4976         (print_symbol_info): Likewise.
4977         (print_msymbol_info): Use address style to print addresses.
4978         Use function name style to print executable text symbols.
4979         (expand_symtab_containing_pc): Use data_p.
4980         (find_pc_sect_compunit_symtab): Likewise.
4981
4982 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4983
4984         * breakpoint.c (describe_other_breakpoints): Use address style
4985         to print addresses.
4986         (say_where): Likewise.
4987
4988 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4989
4990         * ada-typeprint.c (print_func_type): Print function name
4991         style to print function name.
4992         * c-typeprint.c (c_print_type_1): Likewise.
4993
4994 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4995
4996         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4997         for execve.
4998
4999 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5000
5001         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5002         type_stack.
5003
5004 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5005
5006         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5007         TYPE_CODE_REF types.
5008
5009 2019-02-08  Jim Wilson  <jimw@sifive.com>
5010
5011         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5012         (riscv_linux_fregset): New.
5013         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5014
5015 2019-02-07  Tom Tromey  <tom@tromey.com>
5016
5017         * thread.c (thread_cancel_execution_command): Update.
5018         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5019         methods.
5020         (struct thread_fsm_ops): Remove.
5021         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5022         (thread_fsm_should_stop, thread_fsm_return_value)
5023         (thread_fsm_set_finished, thread_fsm_finished_p)
5024         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5025         Don't declare.
5026         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5027         * infrun.c (clear_proceed_status_thread)
5028         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5029         (print_stop_event): Update.
5030         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5031         Add constructor.
5032         (step_command_fsm_ops): Remove.
5033         (new_step_command_fsm): Remove.
5034         (step_1): Update.
5035         (step_command_fsm::should_stop): Rename from
5036         step_command_fsm_should_stop.
5037         (step_command_fsm::clean_up): Rename from
5038         step_command_fsm_clean_up.
5039         (step_command_fsm::do_async_reply_reason): Rename from
5040         step_command_fsm_async_reply_reason.
5041         (struct until_next_fsm): Inherit from thread_fsm.  Add
5042         constructor.
5043         (until_next_fsm_ops): Remove.
5044         (new_until_next_fsm): Remove.
5045         (until_next_fsm::should_stop): Rename from
5046         until_next_fsm_should_stop.
5047         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5048         (until_next_fsm::do_async_reply_reason): Rename from
5049         until_next_fsm_async_reply_reason.
5050         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5051         constructor.  Change type of breakpoint.
5052         (finish_command_fsm_ops): Remove.
5053         (new_finish_command_fsm): Remove.
5054         (finish_command_fsm::should_stop): Rename from
5055         finish_command_fsm_should_stop.
5056         (finish_command_fsm::clean_up): Rename from
5057         finish_command_fsm_clean_up.
5058         (finish_command_fsm::return_value): Rename from
5059         finish_command_fsm_return_value.
5060         (finish_command_fsm::do_async_reply_reason): Rename from
5061         finish_command_fsm_async_reply_reason.
5062         (finish_command): Update.
5063         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5064         Add constructor.
5065         (call_thread_fsm_ops): Remove.
5066         (call_thread_fsm::call_thread_fsm): Rename from
5067         new_call_thread_fsm.
5068         (call_thread_fsm::should_stop): Rename from
5069         call_thread_fsm_should_stop.
5070         (call_thread_fsm::should_notify_stop): Rename from
5071         call_thread_fsm_should_notify_stop.
5072         (run_inferior_call, call_function_by_hand_dummy): Update.
5073         * cli/cli-interp.c (should_print_stop_to_console): Update.
5074         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5075         Add constructor.  Change type of location_breakpoint,
5076         caller_breakpoint.
5077         (until_break_fsm_ops): Remove.
5078         (new_until_break_fsm): Remove.
5079         (until_break_fsm::should_stop): Rename from
5080         until_break_fsm_should_stop.
5081         (until_break_fsm::clean_up): Rename from
5082         until_break_fsm_clean_up.
5083         (until_break_fsm::do_async_reply_reason): Rename from
5084         until_break_fsm_async_reply_reason.
5085         (until_break_command): Update.
5086         * thread-fsm.c: Remove.
5087         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5088
5089 2019-02-07  Tom Tromey  <tom@tromey.com>
5090
5091         * yy-remap.h: Add include guard.
5092         * xtensa-tdep.h: Add include guard.
5093         * xcoffread.h: Rename include guard.
5094         * varobj-iter.h: Add include guard.
5095         * tui/tui.h: Rename include guard.
5096         * tui/tui-winsource.h: Rename include guard.
5097         * tui/tui-wingeneral.h: Rename include guard.
5098         * tui/tui-windata.h: Rename include guard.
5099         * tui/tui-win.h: Rename include guard.
5100         * tui/tui-stack.h: Rename include guard.
5101         * tui/tui-source.h: Rename include guard.
5102         * tui/tui-regs.h: Rename include guard.
5103         * tui/tui-out.h: Rename include guard.
5104         * tui/tui-layout.h: Rename include guard.
5105         * tui/tui-io.h: Rename include guard.
5106         * tui/tui-hooks.h: Rename include guard.
5107         * tui/tui-file.h: Rename include guard.
5108         * tui/tui-disasm.h: Rename include guard.
5109         * tui/tui-data.h: Rename include guard.
5110         * tui/tui-command.h: Rename include guard.
5111         * tic6x-tdep.h: Add include guard.
5112         * target/waitstatus.h: Rename include guard.
5113         * target/wait.h: Rename include guard.
5114         * target/target.h: Rename include guard.
5115         * target/resume.h: Rename include guard.
5116         * target-float.h: Rename include guard.
5117         * stabsread.h: Add include guard.
5118         * rs6000-tdep.h: Add include guard.
5119         * riscv-fbsd-tdep.h: Add include guard.
5120         * regformats/regdef.h: Rename include guard.
5121         * record.h: Rename include guard.
5122         * python/python.h: Rename include guard.
5123         * python/python-internal.h: Rename include guard.
5124         * python/py-stopevent.h: Rename include guard.
5125         * python/py-ref.h: Rename include guard.
5126         * python/py-record.h: Rename include guard.
5127         * python/py-record-full.h: Rename include guard.
5128         * python/py-record-btrace.h: Rename include guard.
5129         * python/py-instruction.h: Rename include guard.
5130         * python/py-events.h: Rename include guard.
5131         * python/py-event.h: Rename include guard.
5132         * procfs.h: Add include guard.
5133         * proc-utils.h: Add include guard.
5134         * p-lang.h: Add include guard.
5135         * or1k-tdep.h: Rename include guard.
5136         * observable.h: Rename include guard.
5137         * nto-tdep.h: Rename include guard.
5138         * nat/x86-linux.h: Rename include guard.
5139         * nat/x86-linux-dregs.h: Rename include guard.
5140         * nat/x86-gcc-cpuid.h: Add include guard.
5141         * nat/x86-dregs.h: Rename include guard.
5142         * nat/x86-cpuid.h: Rename include guard.
5143         * nat/ppc-linux.h: Rename include guard.
5144         * nat/mips-linux-watch.h: Rename include guard.
5145         * nat/linux-waitpid.h: Rename include guard.
5146         * nat/linux-ptrace.h: Rename include guard.
5147         * nat/linux-procfs.h: Rename include guard.
5148         * nat/linux-osdata.h: Rename include guard.
5149         * nat/linux-nat.h: Rename include guard.
5150         * nat/linux-namespaces.h: Rename include guard.
5151         * nat/linux-btrace.h: Rename include guard.
5152         * nat/glibc_thread_db.h: Rename include guard.
5153         * nat/gdb_thread_db.h: Rename include guard.
5154         * nat/gdb_ptrace.h: Rename include guard.
5155         * nat/fork-inferior.h: Rename include guard.
5156         * nat/amd64-linux-siginfo.h: Rename include guard.
5157         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5158         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5159         * nat/aarch64-linux.h: Rename include guard.
5160         * nat/aarch64-linux-hw-point.h: Rename include guard.
5161         * mn10300-tdep.h: Add include guard.
5162         * mips-linux-tdep.h: Add include guard.
5163         * mi/mi-parse.h: Rename include guard.
5164         * mi/mi-out.h: Rename include guard.
5165         * mi/mi-main.h: Rename include guard.
5166         * mi/mi-interp.h: Rename include guard.
5167         * mi/mi-getopt.h: Rename include guard.
5168         * mi/mi-console.h: Rename include guard.
5169         * mi/mi-common.h: Rename include guard.
5170         * mi/mi-cmds.h: Rename include guard.
5171         * mi/mi-cmd-break.h: Rename include guard.
5172         * m2-lang.h: Add include guard.
5173         * location.h: Rename include guard.
5174         * linux-record.h: Rename include guard.
5175         * linux-nat.h: Add include guard.
5176         * linux-fork.h: Add include guard.
5177         * i386-darwin-tdep.h: Rename include guard.
5178         * hppa-linux-offsets.h: Add include guard.
5179         * guile/guile.h: Rename include guard.
5180         * guile/guile-internal.h: Rename include guard.
5181         * gnu-nat.h: Rename include guard.
5182         * gdb-stabs.h: Rename include guard.
5183         * frv-tdep.h: Add include guard.
5184         * f-lang.h: Add include guard.
5185         * event-loop.h: Add include guard.
5186         * darwin-nat.h: Rename include guard.
5187         * cp-abi.h: Rename include guard.
5188         * config/sparc/nm-sol2.h: Rename include guard.
5189         * config/nm-nto.h: Rename include guard.
5190         * config/nm-linux.h: Add include guard.
5191         * config/i386/nm-i386gnu.h: Rename include guard.
5192         * config/djgpp/nl_types.h: Rename include guard.
5193         * config/djgpp/langinfo.h: Rename include guard.
5194         * compile/gcc-cp-plugin.h: Add include guard.
5195         * compile/gcc-c-plugin.h: Add include guard.
5196         * compile/compile.h: Rename include guard.
5197         * compile/compile-object-run.h: Rename include guard.
5198         * compile/compile-object-load.h: Rename include guard.
5199         * compile/compile-internal.h: Rename include guard.
5200         * compile/compile-cplus.h: Rename include guard.
5201         * compile/compile-c.h: Rename include guard.
5202         * common/xml-utils.h: Rename include guard.
5203         * common/x86-xstate.h: Rename include guard.
5204         * common/version.h: Rename include guard.
5205         * common/vec.h: Rename include guard.
5206         * common/tdesc.h: Rename include guard.
5207         * common/selftest.h: Rename include guard.
5208         * common/scoped_restore.h: Rename include guard.
5209         * common/scoped_mmap.h: Rename include guard.
5210         * common/scoped_fd.h: Rename include guard.
5211         * common/safe-iterator.h: Rename include guard.
5212         * common/run-time-clock.h: Rename include guard.
5213         * common/refcounted-object.h: Rename include guard.
5214         * common/queue.h: Rename include guard.
5215         * common/ptid.h: Rename include guard.
5216         * common/print-utils.h: Rename include guard.
5217         * common/preprocessor.h: Rename include guard.
5218         * common/pathstuff.h: Rename include guard.
5219         * common/observable.h: Rename include guard.
5220         * common/netstuff.h: Rename include guard.
5221         * common/job-control.h: Rename include guard.
5222         * common/host-defs.h: Rename include guard.
5223         * common/gdb_wait.h: Rename include guard.
5224         * common/gdb_vecs.h: Rename include guard.
5225         * common/gdb_unlinker.h: Rename include guard.
5226         * common/gdb_unique_ptr.h: Rename include guard.
5227         * common/gdb_tilde_expand.h: Rename include guard.
5228         * common/gdb_sys_time.h: Rename include guard.
5229         * common/gdb_string_view.h: Rename include guard.
5230         * common/gdb_splay_tree.h: Rename include guard.
5231         * common/gdb_setjmp.h: Rename include guard.
5232         * common/gdb_ref_ptr.h: Rename include guard.
5233         * common/gdb_optional.h: Rename include guard.
5234         * common/gdb_locale.h: Rename include guard.
5235         * common/gdb_assert.h: Rename include guard.
5236         * common/filtered-iterator.h: Rename include guard.
5237         * common/filestuff.h: Rename include guard.
5238         * common/fileio.h: Rename include guard.
5239         * common/environ.h: Rename include guard.
5240         * common/common-utils.h: Rename include guard.
5241         * common/common-types.h: Rename include guard.
5242         * common/common-regcache.h: Rename include guard.
5243         * common/common-inferior.h: Rename include guard.
5244         * common/common-gdbthread.h: Rename include guard.
5245         * common/common-exceptions.h: Rename include guard.
5246         * common/common-defs.h: Rename include guard.
5247         * common/common-debug.h: Rename include guard.
5248         * common/cleanups.h: Rename include guard.
5249         * common/buffer.h: Rename include guard.
5250         * common/btrace-common.h: Rename include guard.
5251         * common/break-common.h: Rename include guard.
5252         * cli/cli-utils.h: Rename include guard.
5253         * cli/cli-style.h: Rename include guard.
5254         * cli/cli-setshow.h: Rename include guard.
5255         * cli/cli-script.h: Rename include guard.
5256         * cli/cli-interp.h: Rename include guard.
5257         * cli/cli-decode.h: Rename include guard.
5258         * cli/cli-cmds.h: Rename include guard.
5259         * charset-list.h: Add include guard.
5260         * buildsym-legacy.h: Rename include guard.
5261         * bfin-tdep.h: Add include guard.
5262         * ax.h: Rename include guard.
5263         * arm-linux-tdep.h: Add include guard.
5264         * arm-fbsd-tdep.h: Add include guard.
5265         * arch/xtensa.h: Rename include guard.
5266         * arch/tic6x.h: Add include guard.
5267         * arch/i386.h: Add include guard.
5268         * arch/arm.h: Rename include guard.
5269         * arch/arm-linux.h: Rename include guard.
5270         * arch/arm-get-next-pcs.h: Rename include guard.
5271         * arch/amd64.h: Add include guard.
5272         * arch/aarch64-insn.h: Rename include guard.
5273         * arch-utils.h: Rename include guard.
5274         * annotate.h: Add include guard.
5275         * amd64-darwin-tdep.h: Rename include guard.
5276         * aarch64-linux-tdep.h: Add include guard.
5277         * aarch64-fbsd-tdep.h: Add include guard.
5278         * aarch32-linux-nat.h: Add include guard.
5279
5280 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5281
5282         * macrotab.c (macro_define_internal): New function that
5283         factorizes macro_define_object_internal and macro_define_function
5284         code.
5285         (macro_define_object_internal): Use macro_define_internal.
5286         (macro_define_function): Likewise.
5287
5288 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5289
5290         * macrocmd.c (extract_identifier): Return
5291         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5292         callers.
5293
5294 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5295
5296         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5297
5298 2019-02-05  Tom Tromey  <tom@tromey.com>
5299
5300         * target.c (target_stack::unpush): Move assertion earlier.
5301
5302 2019-01-30  Tom Tromey  <tom@tromey.com>
5303
5304         PR python/23615:
5305         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5306         (gdbpy_parse_and_eval): Likewise.
5307         * python/python-internal.h (gdbpy_allow_threads): New class.
5308
5309 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5310
5311         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5312         (aarch64_fbsd_fpregmap): Move earlier.
5313         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5314         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5315         instead of individual calls to trad_frame_set_reg_addr.
5316         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5317         earlier.
5318         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5319         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5320         instead of individual calls to trad_frame_set_reg_addr.
5321
5322 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5323
5324         * CONTRIBUTE: Replace contribution list with wiki link.
5325
5326 2019-01-25  Tom Tromey  <tom@tromey.com>
5327
5328         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5329
5330 2019-01-25  Tom Tromey  <tom@tromey.com>
5331
5332         * xtensa-linux-nat.c: Fix common/ includes.
5333         * xml-support.h: Fix common/ includes.
5334         * xml-support.c: Fix common/ includes.
5335         * x86-linux-nat.c: Fix common/ includes.
5336         * windows-nat.c: Fix common/ includes.
5337         * varobj.h: Fix common/ includes.
5338         * varobj.c: Fix common/ includes.
5339         * value.c: Fix common/ includes.
5340         * valops.c: Fix common/ includes.
5341         * utils.c: Fix common/ includes.
5342         * unittests/xml-utils-selftests.c: Fix common/ includes.
5343         * unittests/utils-selftests.c: Fix common/ includes.
5344         * unittests/unpack-selftests.c: Fix common/ includes.
5345         * unittests/tracepoint-selftests.c: Fix common/ includes.
5346         * unittests/style-selftests.c: Fix common/ includes.
5347         * unittests/string_view-selftests.c: Fix common/ includes.
5348         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5349         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5350         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5351         * unittests/rsp-low-selftests.c: Fix common/ includes.
5352         * unittests/parse-connection-spec-selftests.c: Fix common/
5353         includes.
5354         * unittests/optional-selftests.c: Fix common/ includes.
5355         * unittests/offset-type-selftests.c: Fix common/ includes.
5356         * unittests/observable-selftests.c: Fix common/ includes.
5357         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5358         * unittests/memrange-selftests.c: Fix common/ includes.
5359         * unittests/memory-map-selftests.c: Fix common/ includes.
5360         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5361         * unittests/function-view-selftests.c: Fix common/ includes.
5362         * unittests/environ-selftests.c: Fix common/ includes.
5363         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5364         * unittests/common-utils-selftests.c: Fix common/ includes.
5365         * unittests/cli-utils-selftests.c: Fix common/ includes.
5366         * unittests/array-view-selftests.c: Fix common/ includes.
5367         * ui-file.c: Fix common/ includes.
5368         * tui/tui-io.c: Fix common/ includes.
5369         * tracepoint.h: Fix common/ includes.
5370         * tracepoint.c: Fix common/ includes.
5371         * tracefile-tfile.c: Fix common/ includes.
5372         * top.h: Fix common/ includes.
5373         * top.c: Fix common/ includes.
5374         * thread.c: Fix common/ includes.
5375         * target/waitstatus.h: Fix common/ includes.
5376         * target/waitstatus.c: Fix common/ includes.
5377         * target.h: Fix common/ includes.
5378         * target.c: Fix common/ includes.
5379         * target-memory.c: Fix common/ includes.
5380         * target-descriptions.c: Fix common/ includes.
5381         * symtab.h: Fix common/ includes.
5382         * symfile.c: Fix common/ includes.
5383         * stap-probe.c: Fix common/ includes.
5384         * spu-linux-nat.c: Fix common/ includes.
5385         * sparc-nat.c: Fix common/ includes.
5386         * source.c: Fix common/ includes.
5387         * solib.c: Fix common/ includes.
5388         * solib-target.c: Fix common/ includes.
5389         * ser-unix.c: Fix common/ includes.
5390         * ser-tcp.c: Fix common/ includes.
5391         * ser-pipe.c: Fix common/ includes.
5392         * ser-base.c: Fix common/ includes.
5393         * selftest-arch.c: Fix common/ includes.
5394         * s12z-tdep.c: Fix common/ includes.
5395         * rust-exp.y: Fix common/ includes.
5396         * rs6000-aix-tdep.c: Fix common/ includes.
5397         * riscv-tdep.c: Fix common/ includes.
5398         * remote.c: Fix common/ includes.
5399         * remote-notif.h: Fix common/ includes.
5400         * remote-fileio.h: Fix common/ includes.
5401         * remote-fileio.c: Fix common/ includes.
5402         * regcache.h: Fix common/ includes.
5403         * regcache.c: Fix common/ includes.
5404         * record-btrace.c: Fix common/ includes.
5405         * python/python.c: Fix common/ includes.
5406         * python/py-type.c: Fix common/ includes.
5407         * python/py-inferior.c: Fix common/ includes.
5408         * progspace.h: Fix common/ includes.
5409         * producer.c: Fix common/ includes.
5410         * procfs.c: Fix common/ includes.
5411         * proc-api.c: Fix common/ includes.
5412         * printcmd.c: Fix common/ includes.
5413         * ppc-linux-nat.c: Fix common/ includes.
5414         * parser-defs.h: Fix common/ includes.
5415         * osdata.c: Fix common/ includes.
5416         * obsd-nat.c: Fix common/ includes.
5417         * nat/x86-linux.c: Fix common/ includes.
5418         * nat/x86-linux-dregs.c: Fix common/ includes.
5419         * nat/x86-dregs.h: Fix common/ includes.
5420         * nat/x86-dregs.c: Fix common/ includes.
5421         * nat/ppc-linux.c: Fix common/ includes.
5422         * nat/mips-linux-watch.h: Fix common/ includes.
5423         * nat/mips-linux-watch.c: Fix common/ includes.
5424         * nat/linux-waitpid.c: Fix common/ includes.
5425         * nat/linux-ptrace.h: Fix common/ includes.
5426         * nat/linux-ptrace.c: Fix common/ includes.
5427         * nat/linux-procfs.c: Fix common/ includes.
5428         * nat/linux-personality.c: Fix common/ includes.
5429         * nat/linux-osdata.c: Fix common/ includes.
5430         * nat/linux-namespaces.c: Fix common/ includes.
5431         * nat/linux-btrace.h: Fix common/ includes.
5432         * nat/linux-btrace.c: Fix common/ includes.
5433         * nat/fork-inferior.c: Fix common/ includes.
5434         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5435         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5436         * nat/aarch64-linux.c: Fix common/ includes.
5437         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5438         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5439         * namespace.h: Fix common/ includes.
5440         * mips-linux-tdep.c: Fix common/ includes.
5441         * minsyms.c: Fix common/ includes.
5442         * mi/mi-parse.h: Fix common/ includes.
5443         * mi/mi-main.c: Fix common/ includes.
5444         * mi/mi-cmd-env.c: Fix common/ includes.
5445         * memrange.h: Fix common/ includes.
5446         * memattr.c: Fix common/ includes.
5447         * maint.h: Fix common/ includes.
5448         * maint.c: Fix common/ includes.
5449         * main.c: Fix common/ includes.
5450         * machoread.c: Fix common/ includes.
5451         * location.c: Fix common/ includes.
5452         * linux-thread-db.c: Fix common/ includes.
5453         * linux-nat.c: Fix common/ includes.
5454         * linux-fork.c: Fix common/ includes.
5455         * inline-frame.c: Fix common/ includes.
5456         * infrun.c: Fix common/ includes.
5457         * inflow.c: Fix common/ includes.
5458         * inferior.h: Fix common/ includes.
5459         * inferior.c: Fix common/ includes.
5460         * infcmd.c: Fix common/ includes.
5461         * inf-ptrace.c: Fix common/ includes.
5462         * inf-child.c: Fix common/ includes.
5463         * ia64-linux-nat.c: Fix common/ includes.
5464         * i387-tdep.c: Fix common/ includes.
5465         * i386-tdep.c: Fix common/ includes.
5466         * i386-linux-tdep.c: Fix common/ includes.
5467         * i386-linux-nat.c: Fix common/ includes.
5468         * i386-go32-tdep.c: Fix common/ includes.
5469         * i386-fbsd-tdep.c: Fix common/ includes.
5470         * i386-fbsd-nat.c: Fix common/ includes.
5471         * guile/scm-type.c: Fix common/ includes.
5472         * guile/guile.c: Fix common/ includes.
5473         * go32-nat.c: Fix common/ includes.
5474         * gnu-nat.c: Fix common/ includes.
5475         * gdbthread.h: Fix common/ includes.
5476         * gdbarch-selftests.c: Fix common/ includes.
5477         * gdb_usleep.c: Fix common/ includes.
5478         * gdb_select.h: Fix common/ includes.
5479         * gdb_bfd.c: Fix common/ includes.
5480         * gcore.c: Fix common/ includes.
5481         * fork-child.c: Fix common/ includes.
5482         * findvar.c: Fix common/ includes.
5483         * fbsd-nat.c: Fix common/ includes.
5484         * event-top.c: Fix common/ includes.
5485         * event-loop.c: Fix common/ includes.
5486         * dwarf2read.c: Fix common/ includes.
5487         * dwarf2loc.c: Fix common/ includes.
5488         * dwarf2-frame.c: Fix common/ includes.
5489         * dwarf-index-cache.c: Fix common/ includes.
5490         * dtrace-probe.c: Fix common/ includes.
5491         * disasm-selftests.c: Fix common/ includes.
5492         * defs.h: Fix common/ includes.
5493         * csky-tdep.c: Fix common/ includes.
5494         * cp-valprint.c: Fix common/ includes.
5495         * cp-support.h: Fix common/ includes.
5496         * cp-support.c: Fix common/ includes.
5497         * corelow.c: Fix common/ includes.
5498         * completer.h: Fix common/ includes.
5499         * completer.c: Fix common/ includes.
5500         * compile/compile.c: Fix common/ includes.
5501         * compile/compile-loc2c.c: Fix common/ includes.
5502         * compile/compile-cplus-types.c: Fix common/ includes.
5503         * compile/compile-cplus-symbols.c: Fix common/ includes.
5504         * command.h: Fix common/ includes.
5505         * cli/cli-dump.c: Fix common/ includes.
5506         * cli/cli-cmds.c: Fix common/ includes.
5507         * charset.c: Fix common/ includes.
5508         * build-id.c: Fix common/ includes.
5509         * btrace.h: Fix common/ includes.
5510         * btrace.c: Fix common/ includes.
5511         * breakpoint.h: Fix common/ includes.
5512         * breakpoint.c: Fix common/ includes.
5513         * ax.h:
5514         (enum agent_op): Fix common/ includes.
5515         * ax-general.c (struct aop_map): Fix common/ includes.
5516         * ax-gdb.c: Fix common/ includes.
5517         * auxv.c: Fix common/ includes.
5518         * auto-load.c: Fix common/ includes.
5519         * arm-tdep.c: Fix common/ includes.
5520         * arch/riscv.c: Fix common/ includes.
5521         * arch/ppc-linux-common.c: Fix common/ includes.
5522         * arch/i386.c: Fix common/ includes.
5523         * arch/arm.c: Fix common/ includes.
5524         * arch/arm-linux.c: Fix common/ includes.
5525         * arch/arm-get-next-pcs.c: Fix common/ includes.
5526         * arch/amd64.c: Fix common/ includes.
5527         * arch/aarch64.c: Fix common/ includes.
5528         * arch/aarch64-insn.c: Fix common/ includes.
5529         * arch-utils.c: Fix common/ includes.
5530         * amd64-windows-tdep.c: Fix common/ includes.
5531         * amd64-tdep.c: Fix common/ includes.
5532         * amd64-sol2-tdep.c: Fix common/ includes.
5533         * amd64-obsd-tdep.c: Fix common/ includes.
5534         * amd64-nbsd-tdep.c: Fix common/ includes.
5535         * amd64-linux-tdep.c: Fix common/ includes.
5536         * amd64-linux-nat.c: Fix common/ includes.
5537         * amd64-fbsd-tdep.c: Fix common/ includes.
5538         * amd64-fbsd-nat.c: Fix common/ includes.
5539         * amd64-dicos-tdep.c: Fix common/ includes.
5540         * amd64-darwin-tdep.c: Fix common/ includes.
5541         * agent.c: Fix common/ includes.
5542         * ada-lang.h: Fix common/ includes.
5543         * ada-lang.c: Fix common/ includes.
5544         * aarch64-tdep.c: Fix common/ includes.
5545
5546 2019-01-25  Tom Tromey  <tom@tromey.com>
5547
5548         * common/create-version.sh: Use common/version.h.
5549
5550 2019-01-24  Pedro Alves  <palves@redhat.com>
5551
5552         * infrun.c (signal_stop, signal_print, signal_program)
5553         (signal_catch, signal_pass): Now arrays instead of pointers.
5554         (update_signals_program_target, do_target_resume)
5555         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5556         * linux-nat.c (linux_nat_target::pass_signals)
5557         (linux_nat_target::create_inferior, linux_nat_target::attach):
5558         Adjust.
5559         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5560         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5561         * procfs.c (procfs_target::pass_signals): Adjust.
5562         * record-full.c (record_full_target::resume): Adjust.
5563         * remote.c (remote_target::pass_signals)
5564         (remote_target::program_signals): Adjust.
5565         * target-debug.h (target_debug_print_signals): Now takes a
5566         gdb::array_view as parameter.  Adjust.
5567         * target.h (target_ops) <pass_signals, program_signals>: Replace
5568         pointer and length parameters with gdb::array_view.
5569         (target_pass_signals, target_program_signals): Likewise.
5570         * target-delegates.c: Regenerate.
5571
5572 2019-01-24  Pedro Alves  <palves@redhat.com>
5573
5574         * common/forward-scope-exit.h
5575         (forward_scope_exit::forward_scope_exit): Pass arguments to
5576         m_bind_function directly, instead of creating a std::bind and
5577         copying that.
5578
5579 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5580
5581         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5582         for static members.
5583         (pass_in_v_vfp_candidate): Likewise.
5584
5585 2019-01-23  Tom Tromey  <tom@tromey.com>
5586             Pedro Alves  <palves@redhat.com>
5587
5588         * regcache.c (class regcache_invalidator): Remove.
5589         (regcache::raw_write): Use make_scope_exit.
5590
5591 2019-01-23  Tom Tromey  <tom@tromey.com>
5592
5593         * ui-out.h (class ui_out_emit_type): Update comment.
5594
5595 2019-01-23  Tom Tromey  <tom@tromey.com>
5596
5597         * infrun.c (fetch_inferior_event): Update comment.
5598
5599 2019-01-23  Tom Tromey  <tom@tromey.com>
5600             Pedro Alves  <palves@redhat.com>
5601
5602         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5603         parameter.
5604         (fetch_inferior_event): Use SCOPE_EXIT.
5605
5606
5607 2019-01-23  Tom Tromey  <tom@tromey.com>
5608             Pedro Alves  <palves@redhat.com>
5609
5610         * infrun.c (disable_thread_events): Delete.
5611         (stop_all_threads): Use SCOPE_EXIT.
5612
5613 2019-01-23  Tom Tromey  <tom@tromey.com>
5614             Pedro Alves  <palves@redhat.com>
5615
5616         * symfile.c: Include forward-scope-exit.h.
5617         (clear_symtab_users_cleanup): Replace forward declaration with
5618         a FORWARD_SCOPE_EXIT.
5619         (syms_from_objfile_1): Use the forward_scope_exit and
5620         gdb::optional instead of cleanup_function.
5621         (reread_symbols): Use the forward_scope_exit instead of
5622         cleanup_function.
5623         (clear_symtab_users_cleanup): Remove function.
5624
5625 2019-01-23  Tom Tromey  <tom@tromey.com>
5626             Pedro Alves  <palves@redhat.com>
5627
5628         * linux-nat.c: Include scope-exit.h.
5629         (cleanup_target_stop): Remove.
5630         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5631         SCOPE_EXIT.
5632
5633 2019-01-23  Tom Tromey  <tom@tromey.com>
5634             Pedro Alves  <palves@redhat.com>
5635
5636         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5637         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5638
5639 2019-01-23  Tom Tromey  <tom@tromey.com>
5640             Andrew Burgess  <andrew.burgess@embecosm.com>
5641             Pedro Alves  <palves@redhat.com>
5642
5643         * infrun.c (fetch_inferior_event): Use scope_exit.
5644         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5645         * top.c (execute_command): Use scope_exit.
5646         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5647         * utils.c (do_bpstat_clear_actions_cleanup)
5648         (make_bpstat_clear_actions_cleanup): Remove.
5649
5650 2019-01-23  Tom Tromey  <tom@tromey.com>
5651             Pedro Alves  <palves@redhat.com>
5652
5653         * infrun.c: Include "common/scope-exit.h"
5654         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5655         (wait_for_inferior): Use SCOPE_EXIT.
5656         (fetch_inferior_event): Use scope_exit.
5657
5658 2019-01-23  Tom Tromey  <tom@tromey.com>
5659             Pedro Alves  <palves@redhat.com>
5660
5661         * breakpoint.c (create_breakpoint): Remove cleanup.
5662
5663 2019-01-23  Tom Tromey  <tom@tromey.com>
5664             Andrew Burgess  <andrew.burgess@embecosm.com>
5665             Pedro Alves  <palves@redhat.com>
5666
5667 2019-01-23  Pedro Alves  <palves@redhat.com>
5668
5669         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5670
5671 2019-01-23  Pedro Alves  <palves@redhat.com>
5672             Andrew Burgess  <andrew.burgess@embecosm.com>
5673
5674         * gdbthread.h: Include "common/forward-scope-exit.h".
5675         (scoped_finish_thread_state): Redefine custom class in terms of
5676         forward_scope_exit.
5677
5678 2019-01-23  Pedro Alves  <palves@redhat.com>
5679             Andrew Burgess  <andrew.burgess@embecosm.com>
5680
5681         * common/forward-scope-exit.h: New file.
5682
5683 2019-01-23  Pedro Alves  <palves@redhat.com>
5684             Andrew Burgess  <andrew.burgess@embecosm.com>
5685             Tom Tromey  <tom@tromey.com>
5686
5687         * common/scope-exit.h: New file.
5688
5689 2019-01-23  Pedro Alves  <palves@redhat.com>
5690
5691         * common/preprocessor.h (ESC): Rename to ...
5692         (ESC_PARENS): ... this.
5693         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5694         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5695
5696 2019-01-23  Tom Tromey  <tom@tromey.com>
5697
5698         * language.h (class scoped_switch_to_sym_language_if_auto):
5699         Initialize m_lang in both cases.
5700
5701 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5702
5703         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5704         with XCNEW.
5705
5706 2019-01-22  Tom Tromey  <tom@tromey.com>
5707
5708         * corelow.c: Do not include sys/file.h.
5709
5710 2019-01-22  Tom Tromey  <tom@tromey.com>
5711
5712         * tui/tui-wingeneral.h: Include gdb_curses.h.
5713
5714 2019-01-22  Tom Tromey  <tom@tromey.com>
5715
5716         * source-cache.h (class source_cache) <get_source_lines,
5717         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5718
5719 2019-01-22  Tom Tromey  <tom@tromey.com>
5720
5721         * remote-fileio.h (struct remote_target): Declare.
5722
5723 2019-01-22  Tom Tromey  <tom@tromey.com>
5724
5725         * python/py-arch.c: Do not include py-ref.h.
5726         * python/py-bpevent.c: Do not include py-ref.h.
5727         * python/py-cmd.c: Do not include py-ref.h.
5728         * python/py-continueevent.c: Do not include py-ref.h.
5729         * python/py-event.h: Do not include py-ref.h.
5730         * python/py-evtregistry.c: Do not include py-ref.h.
5731         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5732         * python/py-frame.c: Do not include py-ref.h.
5733         * python/py-framefilter.c: Do not include py-ref.h.
5734         * python/py-function.c: Do not include py-ref.h.
5735         * python/py-infevents.c: Do not include py-ref.h.
5736         * python/py-linetable.c: Do not include py-ref.h.
5737         * python/py-objfile.c: Do not include py-ref.h.
5738         * python/py-param.c: Do not include py-ref.h.
5739         * python/py-prettyprint.c: Do not include py-ref.h.
5740         * python/py-progspace.c: Do not include py-ref.h.
5741         * python/py-symbol.c: Do not include py-ref.h.
5742         * python/py-symtab.c: Do not include py-ref.h.
5743         * python/py-type.c: Do not include py-ref.h.
5744         * python/py-unwind.c: Do not include py-ref.h.
5745         * python/py-utils.c: Do not include py-ref.h.
5746         * python/py-value.c: Do not include py-ref.h.
5747         * python/py-varobj.c: Do not include py-ref.h.
5748         * python/py-xmethods.c: Do not include py-ref.h.
5749         * python/python.c: Do not include py-ref.h.
5750         * varobj.c: Do not include py-ref.h.
5751
5752 2019-01-22  Tom Tromey  <tom@tromey.com>
5753
5754         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5755         keyword for bcache.
5756
5757 2019-01-22  Tom Tromey  <tom@tromey.com>
5758
5759         * compile/compile-cplus-types.c: Remove a comment by #include.
5760
5761 2019-01-22  Tom Tromey  <tom@tromey.com>
5762
5763         * compile/gcc-c-plugin.h: Include compile-internal.h.
5764
5765 2019-01-22  Tom Tromey  <tom@tromey.com>
5766
5767         * stabsread.c (EXTERN): Do not define.
5768         (symnum, next_symbol_text_func, processing_gcc_compilation)
5769         (within_function, global_sym_chain, global_stabs)
5770         (previous_stab_code, this_object_header_files)
5771         (n_this_object_header_files)
5772         (n_allocated_this_object_header_files): Define.
5773         * stabsread.h (EXTERN): Never define.  Use "extern".
5774
5775 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5776
5777         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5778         history_value.
5779
5780 2019-01-21  Tom Tromey  <tom@tromey.com>
5781
5782         * ui-out.c: Fix includes.
5783         * tui/tui-source.c: Fix includes.
5784         * target.c: Fix includes.
5785         * remote.c: Fix includes.
5786         * regcache.c: Fix includes.
5787         * python/py-block.c: Fix includes.
5788         * printcmd.c: Fix includes.
5789         * or1k-tdep.c: Fix includes.
5790         * mi/mi-main.c: Fix includes.
5791         * m32r-tdep.c: Fix includes.
5792         * csky-tdep.c: Fix includes.
5793         * compile/compile-cplus-types.c: Fix includes.
5794         * cli/cli-interp.c: Fix includes.
5795
5796 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5797
5798         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5799         for padding.
5800
5801 2019-01-16  Tom Tromey  <tom@tromey.com>
5802
5803         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5804         earlier.
5805         (struct objfile) <msymbols_range>: Move from top level.
5806         <msymbols>: New method.
5807         (class objfile_msymbols): Remove.
5808         * symtab.c (default_collect_symbol_completion_matches_break_on):
5809         Update.
5810         * symmisc.c (dump_msymbols): Update.
5811         * stabsread.c (scan_file_globals): Update.
5812         * objc-lang.c (info_selectors_command, info_classes_command)
5813         (find_methods): Update.
5814         * minsyms.c (find_solib_trampoline_target): Update.
5815         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5816         * coffread.c (coff_symfile_read): Update.
5817         * ada-lang.c (ada_lookup_simple_minsym)
5818         (ada_collect_symbol_completion_matches): Update.
5819
5820 2019-01-16  Tom Tromey  <tom@tromey.com>
5821
5822         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5823         type.  Remove no-argument constructor.
5824         <iterator::operator++>: Simplify.
5825         <begin>: Update.
5826         <end>: Use minimal_symbol_count.
5827
5828 2019-01-16  Tom Tromey  <tom@tromey.com>
5829
5830         * objfiles.h (struct objfile) <psymtabs>: New method.
5831         (class objfile_psymtabs): Remove.
5832         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5833         typedef.
5834         <range>: New method.
5835         (require_partial_symbols): Change return type.
5836         * psymtab.c (require_partial_symbols)
5837         (psym_expand_symtabs_matching): Update.
5838         * mdebugread.c (parse_partial_symbols): Update.
5839         * dbxread.c (dbx_end_psymtab): Update.
5840
5841 2019-01-15  Tom Tromey  <tom@tromey.com>
5842
5843         * symtab.c (lookup_objfile_from_block)
5844         (lookup_symbol_in_objfile_symtabs)
5845         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5846         (find_line_symtab, info_sources_command)
5847         (default_collect_symbol_completion_matches_break_on)
5848         (make_source_files_completion_list): Update.
5849         * symmisc.c (print_objfile_statistics, dump_objfile)
5850         (maintenance_print_symbols, maintenance_info_symtabs)
5851         (maintenance_check_symtabs, maintenance_info_line_tables):
5852         Update.
5853         * source.c (select_source_symtab)
5854         (forget_cached_source_info_for_objfile): Update.
5855         * objfiles.h (class objfile_compunits): Remove.
5856         (struct objfile) <compunits_range>: New typedef.
5857         (compunits): New method.
5858         * objfiles.c (objfile_relocate1): Update.
5859         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5860         * maint.c (count_symtabs_and_blocks): Update.
5861         * linespec.c (iterate_over_all_matching_symtabs): Update.
5862         * cp-support.c (add_symbol_overload_list_qualified): Update.
5863         * coffread.c (coff_symtab_read): Update.
5864         * ada-lang.c (add_nonlocal_symbols)
5865         (ada_collect_symbol_completion_matches)
5866         (ada_add_global_exceptions): Update.
5867
5868 2019-01-15  Tom Tromey  <tom@tromey.com>
5869
5870         * progspace.h (program_space) <objfiles_safe_range>: New
5871         typedef.
5872         <objfiles_safe>: New method.
5873         * objfiles.h (class all_objfiles_safe): Remove.
5874         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5875         * jit.c (jit_inferior_exit_hook): Update.
5876
5877 2019-01-17  Tom Tromey  <tom@tromey.com>
5878
5879         * progspace.h (program_space) <objfiles_range>: New typedef.
5880         <objfiles>: New method.
5881         <objfiles_head>: Rename from objfiles.
5882         (object_files): Update.
5883         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5884         * guile/scm-pretty-print.c
5885         (ppscm_find_pretty_printer_from_objfiles): Update.
5886         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5887         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5888         Update.
5889         * python/py-progspace.c (pspy_get_objfiles): Update.
5890         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5891         Update.
5892         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5893         (objfpy_lookup_objfile_by_build_id): Update.
5894         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5895         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5896         Update.
5897         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5898         (expand_symtab_containing_pc, lookup_objfile_from_block)
5899         (lookup_static_symbol, basic_lookup_transparent_type)
5900         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5901         (find_line_symtab, info_sources_command)
5902         (default_collect_symbol_completion_matches_break_on)
5903         (make_source_files_completion_list, find_main_name): Update.
5904         * symmisc.c (print_symbol_bcache_statistics)
5905         (print_objfile_statistics, maintenance_print_symbols)
5906         (maintenance_print_msymbols, maintenance_print_objfiles)
5907         (maintenance_info_symtabs, maintenance_check_symtabs)
5908         (maintenance_expand_symtabs, maintenance_info_line_tables):
5909         Update.
5910         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5911         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5912         (map_overlay_command, unmap_overlay_command)
5913         (simple_overlay_update, expand_symtabs_matching)
5914         (map_symbol_filenames): Update.
5915         * symfile-debug.c (set_debug_symfile): Update.
5916         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5917         Update.
5918         * source.c (select_source_symtab, forget_cached_source_info):
5919         Update.
5920         * solib.c (solib_read_symbols): Update.
5921         * solib-spu.c (append_ocl_sos): Update.
5922         * psymtab.c (maintenance_print_psymbols)
5923         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5924         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5925         * printcmd.c (info_symbol_command): Update.
5926         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5927         Update.
5928         * objfiles.h (class all_objfiles): Remove.
5929         * objfiles.c (have_partial_symbols, have_full_symbols)
5930         (have_minimal_symbols, qsort_cmp, update_section_map)
5931         (shared_objfile_contains_address_p)
5932         (default_iterate_over_objfiles_in_search_order): Update.
5933         * objc-lang.c (info_selectors_command, info_classes_command)
5934         (find_methods): Update.
5935         * minsyms.c (find_solib_trampoline_target): Update.
5936         * maint.c (maintenance_info_sections)
5937         (maintenance_translate_address, count_symtabs_and_blocks):
5938         Update.
5939         * main.c (captured_main_1): Update.
5940         * linux-thread-db.c (try_thread_db_load_from_pdir)
5941         (has_libpthread): Update.
5942         * linespec.c (iterate_over_all_matching_symtabs)
5943         (search_minsyms_for_name): Update.
5944         * jit.c (jit_find_objf_with_entry_addr): Update.
5945         * hppa-tdep.c (find_unwind_entry)
5946         (hppa_lookup_stub_minimal_symbol): Update.
5947         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5948         Update.
5949         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5950         (elf_gnu_ifunc_resolve_by_got): Update.
5951         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5952         * dwarf-index-write.c (save_gdb_index_command): Update.
5953         * cp-support.c (add_symbol_overload_list_qualified): Update.
5954         * breakpoint.c (create_overlay_event_breakpoint)
5955         (create_longjmp_master_breakpoint)
5956         (create_std_terminate_master_breakpoint)
5957         (create_exception_master_breakpoint): Update.
5958         * blockframe.c (find_pc_partial_function): Update.
5959         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5960         (ada_collect_symbol_completion_matches)
5961         (ada_add_global_exceptions): Update.
5962
5963 2019-01-17  Tom Tromey  <tom@tromey.com>
5964
5965         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5966         declare VEC.
5967         (solib_target_parse_libraries): Change return type.
5968         (library_list_start_segment, library_list_start_section)
5969         (library_list_end_library, library_list_start_library); Update.
5970         (solib_target_free_library_list): Remove.
5971         (solib_target_parse_libraries): Remove cleanup.  Change return
5972         type.
5973         (solib_target_current_sos): Update.
5974
5975 2019-01-17  Tom Tromey  <tromey@bapiya>
5976
5977         * valprint.c: Replace "the the" with "the".
5978         * symtab.c: Replace "the the" with "the".
5979         * solib.c: Replace "the the" with "the".
5980         * solib-dsbt.c: Replace "the the" with "the".
5981         * linespec.c: Replace "the the" with "the".
5982         * dwarf2loc.h: Replace "the the" with "the".
5983         * amd64-windows-tdep.c: Replace "the the" with "the".
5984         * aarch64-tdep.c: Replace "the the" with "the".
5985
5986 2019-01-16  Keith Seitz  <keiths@redhat.com>
5987
5988         PR gdb/23773
5989         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5990         <builder>: Rename to ..
5991         <m_builder>: ... this and make private.
5992         (dwarf2_cu::get_builder): New method.  Change all users of
5993         `builder' to use this method.
5994         (dwarf2_start_symtab): Move to ...
5995         (dwarf2_cu::start_symtab): ... here.  Update all callers
5996         (setup_type_unit_groups): Move to ...
5997         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5998         callers.
5999         (dwarf2_cu::reset_builder): New method.
6000         (process_full_compunit, process_full_type_unit): Use
6001         dwarf2_cu::reset_builder.
6002         (follow_die_offset): Record the ancestor CU if it is different
6003         from the followed DIE's CU.
6004         (follow_die_sig_1): Likewise.
6005
6006 2019-01-15  Tom Tromey  <tom@tromey.com>
6007
6008         * remote.c (class remote_state) <buf>: Now a char_vector.
6009         <buf_size>: Remove.
6010         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6011         parameter.
6012         (remote_target::getpkt_or_notif_sane_1)
6013         (remote_target::getpkt_sane)
6014         (remote_target::getpkt_or_notif_sane): Likewise.
6015         (class remote_target) <putpkt>: New overload.
6016         (remote_target::read_frame): Change type of "buf_p".  Remove
6017         sizeof_p parameter.
6018         (packet_ok): New overload.
6019         (packet_check_result): New overload.
6020         Update all uses.
6021
6022 2019-01-14  Tom Tromey  <tom@tromey.com>
6023
6024         * remote-notif.c (handle_notification, remote_notif_ack)
6025         (remote_notif_parse): Make "buf" const.
6026         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6027         const.
6028         (remote_notif_parse, remote_notif_ack, handle_notification):
6029         Likewise.
6030         * remote.c (remote_notif_stop_parse): Make "buf" const.
6031         (remote_target::remote_parse_stop_reply): Make "buf" const.
6032         (remote_notif_stop_ack): Make "buf" const.
6033
6034 2019-01-14  Tom Tromey  <tom@tromey.com>
6035
6036         * remote.c (remote_console_output): Make parameter const.
6037
6038 2019-01-14  Tom Tromey  <tom@tromey.com>
6039
6040         * target-debug.h (target_debug_print_signals): Constify.
6041         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6042         * procfs.c (procfs_target::pass_signals): Update.
6043         * linux-nat.c (linux_nat_target::pass_signals): Update.
6044         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6045         * target-delegates.c: Rebuild.
6046         * remote.c (remote_target::program_signals): Update.
6047         (remote_target::pass_signals): Update.
6048         * target.c (target_pass_signals): Constify argument.
6049         (target_program_signals): Likewise.
6050         * target.h (struct target_ops) <pass_signals, program_signals>:
6051         Constify argument.
6052         (target_pass_signals, target_program_signals): Constify argument.
6053
6054 2019-01-14  Tom Tromey  <tom@tromey.com>
6055
6056         PR tui/28819:
6057         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6058
6059 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6060
6061         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6062         field.
6063         * rs6000-tdep.c: Include reggroups.h.
6064         (IS_V_ALIAS_PSEUDOREG): Define.
6065         (rs6000_register_name): Return names for the "vX" aliases.
6066         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6067         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6068         aliases.  Call default_register_reggroup_p for all other
6069         pseudo-registers.
6070         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6071         New functions.
6072         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6073         Handle "vX" aliases.
6074         (v_alias_pseudo_register_collect): New function.
6075         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6076         (rs6000_gdbarch_init): Initialize "vX" aliases as
6077         pseudo-registers.  Restore registration of
6078         rs6000_pseudo_register_reggroup_p with
6079         set_tdesc_pseudo_register_reggroup_p.
6080
6081 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6082
6083         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6084         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6085         set_gdbarch_num_pseudo_regs.
6086
6087 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6088
6089         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6090         Remove arg prefixname, add do_set and do_show.
6091         Add member functions set_list and show_list.
6092         * cli/cli-style.c (class cli_style_option): Update accordingly.
6093         (style_set_list): Move to file scope.
6094         (style_show_list): Likewise.
6095         (set_style): Call help_list.
6096         (show_style): Call cmd_show_list.
6097         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6098         Update to use the new macro.
6099
6100 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6101
6102         * ada-lang.c (_initialize_ada_language): Expand the help text
6103         for the "catch exception" command.
6104
6105 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6106
6107         * symtab.c (matching_obj_sections): Initialize obj,
6108         declare it closer to its usage.
6109
6110 2019-01-10  Tom Tromey  <tom@tromey.com>
6111
6112         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6113         (basic_inf_threads_range): Remove.
6114         (inf_threads_range, inf_non_exited_threads_range)
6115         (safe_inf_threads_range): Use next_adapter.
6116
6117 2019-01-10  Keith Seitz  <keiths@redhat.com>
6118
6119         PR gdb/23712
6120         PR symtab/23010
6121         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6122         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6123
6124 2019-01-10  Keith Seitz  <keiths@redhat.com>
6125
6126         PR gdb/23712
6127         PR symtab/23010
6128         * dictionary.c (pending_to_vector): Remove.
6129         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6130         Remove _1 suffix, replacing functions of the same name.  Update
6131         all callers.
6132         (dict_create_hashed, dict_create_hashed_expandable)
6133         (dict_create_linear, dict_create_linear_expandable, dict_free)
6134         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6135         Make functions static.
6136
6137 2019-01-10  Keith Seitz  <keiths@redhat.com>
6138
6139         PR gdb/23712
6140         PR symtab/23010
6141         * dictionary.h (struct dictionary): Replace declaration with
6142         multidictionary.
6143         (dict_create_hashed, dict_create_hashed_expandable)
6144         (dict_create_linear, dict_create_linear_expandable)
6145         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6146         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6147         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6148         taking multidictionary argument.
6149         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6150         * block.h (struct block) <dict>: Change to multidictionary
6151         and rename `multidict'.
6152         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6153         symmisc.c: Update all dictionary references to multidictionary.
6154
6155 2019-01-10  Keith Seitz  <keiths@redhat.com>
6156
6157         PR gdb/23712
6158         PR symtab/23010
6159         * dictionary.c: Include unordered_map.
6160         (pending_to_vector): New function.
6161         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6162         Rewrite the non-"_1" functions to take vector instead
6163         of linked list.
6164         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6165         "new" _1 versions of the same name.
6166         (multidictionary): Define.
6167         (std::hash<enum language): New definition.
6168         (collate_pending_symbols_by_language, mdict_create_hashed)
6169         (mdict_create_hashed_expandable, mdict_create_linear)
6170         (mdict_create_linear_expandable, mdict_free)
6171         (find_language_dictionary, create_new_language_dictionary)
6172         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6173         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6174         (mdict_size, mdict_empty): New functions.
6175         * dictionary.h (mdict_iterator): Define.
6176
6177 2019-01-10  Pedro Alves  <palves@redhat.com>
6178
6179         * breakpoint.c (read_uploaded_action)
6180         (create_tracepoint_from_upload): Adjust to use
6181         gdb::unique_xmalloc_ptr.
6182         * ctf.c (ctf_write_uploaded_tp):
6183         (SET_ARRAY_FIELD): Use emplace_back.
6184         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6185         * tracefile-tfile.c (tfile_write_uploaded_tp):
6186         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6187         gdb::unique_xmalloc_ptr.
6188         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6189         at_string, cond_string, cmd_strings>: Replace char pointers
6190         with gdb::unique_xmalloc_ptr.
6191
6192 2019-01-10  Pedro Alves  <palves@redhat.com>
6193
6194         * solib-target.c (library_list_start_library): Don't xstrdup name.
6195
6196 2019-01-10  Pedro Alves  <palves@redhat.com>
6197
6198         * mdebugread.c (parse_partial_symbols): Use
6199         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6200
6201 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * linux-fork.c (scoped_switch_fork_info)
6204         <~scoped_switch_fork_info>: Fix incorrect variable name.
6205
6206 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6207
6208         * linux-fork.c (scoped_switch_fork_info)
6209         <scoped_switch_fork_info>: Make explicit.
6210         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6211
6212 2019-01-10  Tom Tromey  <tom@tromey.com>
6213
6214         * objfiles.h (objfile::reset_psymtabs): Update.
6215         * objfiles.c (objfile::objfile): Update.
6216         * psymtab.h (psymtab_storage::obstack): Update.
6217         (psymtab_storage::m_obstack): Use gdb::optional.
6218         (class psymtab_storage): Update comment.  Remove objfile
6219         parameter.
6220         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6221
6222 2019-01-10  Tom Tromey  <tom@tromey.com>
6223
6224         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6225         <free_psymtabs>: Now private.
6226         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6227         (allocate_psymtab): Use new method.
6228
6229 2019-01-10  Tom Tromey  <tom@tromey.com>
6230
6231         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6232         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6233         * mdebugread.c (parse_partial_symbols): Use
6234         allocate_dependencies.
6235         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6236         allocate_dependencies.
6237         (process_psymtab_comp_unit_reader)
6238         (build_type_psymtab_dependencies): Likewise.
6239         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6240
6241 2019-01-10  Tom Tromey  <tom@tromey.com>
6242
6243         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6244         PSYMBOL_SET_LANGUAGE.
6245         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6246
6247 2019-01-10  Tom Tromey  <tom@tromey.com>
6248
6249         * psymtab.h (psymtab_storage::obstack): New method.
6250         <m_obstack>: Rename from obstack; now private.
6251         * psymtab.c (psymtab_storage): Update.
6252         * dwarf2read.c (create_addrmap_from_index)
6253         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6254         Update.
6255
6256 2019-01-10  Tom Tromey  <tom@tromey.com>
6257
6258         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6259         * objfiles.h (objfile::reset_psymtabs): New method.
6260
6261 2019-01-10  Tom Tromey  <tom@tromey.com>
6262
6263         * symmisc.c (print_symbol_bcache_statistics): Update.
6264         (print_objfile_statistics): Update.
6265         * symfile.c (reread_symbols): Update.
6266         * psymtab.h (class psymtab_storage): New.
6267         * psymtab.c (psymtab_storage): New constructor.
6268         (~psymtab_storage): New destructor.
6269         (require_partial_symbols): Update.
6270         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6271         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6272         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6273         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6274         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6275         (start_psymtab_common, end_psymtab_common)
6276         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6277         (allocate_psymtab): Update.
6278         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6279         Update.
6280         (dump_psymtab_addrmap, maintenance_print_psymbols)
6281         (maintenance_check_psymtabs): Update.
6282         (class objfile_psymtabs): Move to objfiles.h.
6283         * psympriv.h (discard_psymtab): Now inline.
6284         (psymtab_discarder::psymtab_discarder): Update.
6285         (psymtab_discarder::~psymtab_discarder): Update.
6286         (ALL_OBJFILE_PSYMTABS): Rewrite.
6287         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6288         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6289         Remove fields.
6290         <partial_symtabs>: New field.
6291         (class objfile_psymtabs): Move from psymtab.h.  Update.
6292         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6293         psymbol_cache.
6294         (objfile::~objfile): Don't destroy psymbol_cache.
6295         * mdebugread.c (parse_partial_symbols): Update.
6296         * dwarf2read.c (create_addrmap_from_index)
6297         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6298         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6299         (add_partial_subprogram, dwarf2_ranges_read): Update.
6300         * dwarf-index-write.c (write_address_map)
6301         (write_one_signatured_type, recursively_write_psymbols)
6302         (class debug_names, class debug_names, write_psymtabs_to_index):
6303         Update.
6304
6305 2019-01-10  Tom Tromey  <tom@tromey.com>
6306
6307         * symtab.h (SYMBOL_SET_NAMES): Update.
6308         (symbol_set_names): Update.
6309         (MSYMBOL_SET_NAMES): Update.
6310         * symtab.c (symbol_set_names): Change argument to be an
6311         objfile_per_bfd_storage.
6312         * psymtab.c (add_psymbol_to_bcache): Update.
6313         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6314
6315 2019-01-10  Tom Tromey  <tom@tromey.com>
6316
6317         * symtab.c (create_demangled_names_hash): Change argument to be an
6318         objfile_per_bfd_storage.
6319         (symbol_set_names): Update.
6320
6321 2019-01-10  Tom Tromey  <tom@tromey.com>
6322
6323         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6324         init_psymbol_list.
6325         * psymtab.c (init_psymbol_list): Do nothing if already called.
6326         * psympriv.h (init_psymbol_list): Add comment.
6327         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6328         init_psymbol_list.
6329         * dbxread.c (dbx_symfile_read): Unconditionally call
6330         init_psymbol_list.
6331
6332 2019-01-10  Tom Tromey  <tom@tromey.com>
6333
6334         * xcoffread.c (scan_xcoff_symtab): Update.
6335         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6336         "where".
6337         * mdebugread.c (parse_partial_symbols)
6338         (handle_psymbol_enumerators): Update.
6339         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6340         * dbxread.c (read_dbx_symtab): Update.
6341         * psympriv.h (psymbol_placement): New enum.
6342         (add_psymbol_to_list): Update.
6343
6344 2019-01-10  Tom Tromey  <tom@tromey.com>
6345
6346         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6347         static_psymbols parameters.
6348         (scan_xcoff_symtab): Update.
6349         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6350         static_psymbols parameters.
6351         * psympriv.h (start_psymtab_common): Update.
6352         * mdebugread.c (parse_partial_symbols): Update.
6353         * dwarf2read.c (create_partial_symtab): Update.
6354         * dbxread.c (read_dbx_symtab): Update.
6355         (start_psymtab): Remove global_psymbols and static_psymbols
6356         parameters.
6357
6358 2019-01-10  Tom Tromey  <tom@tromey.com>
6359
6360         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6361         * psymtab.c (allocate_psymtab): Add comment.
6362         * psympriv.h (allocate_psymtab): Add comment.
6363         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6364         initializations.
6365         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6366
6367 2019-01-10  Tom Tromey  <tom@tromey.com>
6368
6369         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6370         Don't declare.
6371         * mipsread.c: Include mdebugread.h.
6372         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6373         Declare.
6374         * elfread.c: Include mdebugread.h.
6375
6376 2019-01-09  Tom Tromey  <tom@tromey.com>
6377
6378         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6379         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6380         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6381         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6382         (psym_lookup_symbol, psym_find_last_source_symtab)
6383         (psym_forget_cached_source_info, psym_print_stats)
6384         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6385         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6386         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6387         (psym_find_compunit_symtab_by_address)
6388         (maintenance_print_psymbols, maintenance_info_psymtabs)
6389         (maintenance_check_psymtabs): Use ranged for.
6390         * psymtab.h (class objfile_psymtabs): New.
6391         (require_partial_symbols): Return objfile_psymtabs.
6392         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6393
6394 2019-01-09  Tom Tromey  <tom@tromey.com>
6395
6396         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6397         (find_pc_mapped_section, list_overlays_command)
6398         (map_overlay_command, unmap_overlay_command)
6399         (simple_overlay_update): Use all_objfiles.
6400         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6401         * printcmd.c (info_symbol_command): Use all_objfiles.
6402         * objfiles.h (ALL_OBJSECTIONS): Remove.
6403         * maint.c (maintenance_translate_address): Use all_objfiles.
6404         * gcore.c (gcore_create_callback): Use all_objfiles.
6405         (objfile_find_memory_regions): Likewise.
6406
6407 2019-01-09  Tom Tromey  <tom@tromey.com>
6408
6409         * symtab.c (find_line_symtab, info_sources_command)
6410         (make_source_files_completion_list): Use objfile_compunits.
6411         * source.c (select_source_symtab): Use objfile_compunits.
6412         * objfiles.h (struct objfile): Update comment.
6413         (ALL_OBJFILES): Remove.
6414         (ALL_FILETABS): Remove.
6415         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6416         objfile_compunits.
6417
6418 2019-01-09  Tom Tromey  <tom@tromey.com>
6419
6420         * symmisc.c (print_objfile_statistics, dump_objfile)
6421         (maintenance_print_symbols): Use compunit_filetabs.
6422         * source.c (forget_cached_source_info_for_objfile): Use
6423         compunit_filetabs.
6424         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6425         (ALL_FILETABS): Use compunit_filetabs.
6426         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6427         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6428
6429 2019-01-09  Tom Tromey  <tom@tromey.com>
6430
6431         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6432         (compunit_filetabs): New.
6433         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6434         compunit_filetabs.
6435         (info_sources_command, make_source_files_completion_list): Remove
6436         declaration.
6437         * symmisc.c (print_objfile_statistics, dump_objfile)
6438         (maintenance_print_symbols): Remove declaration.
6439         (maintenance_info_symtabs): Use compunit_filetabs.
6440         (maintenance_info_line_tables): Likewise.
6441         * source.c (select_source_symtab): Change local variable name.
6442         (forget_cached_source_info_for_objfile): Remove declaration.
6443         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6444         * objfiles.c (objfile_relocate1): Remove declaration.
6445         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6446         declaration.
6447         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6448         * coffread.c (coff_symtab_read): Remove declaration.
6449         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6450         compunit_filetabs.
6451
6452 2019-01-09  Tom Tromey  <tom@tromey.com>
6453
6454         * symtab.c (lookup_objfile_from_block)
6455         (find_pc_sect_compunit_symtab, search_symbols)
6456         (default_collect_symbol_completion_matches_break_on): Use
6457         objfile_compunits.
6458         * objfiles.h (ALL_COMPUNITS): Remove.
6459         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6460         * cp-support.c (add_symbol_overload_list_qualified): Use
6461         objfile_compunits.
6462         * ada-lang.c (ada_collect_symbol_completion_matches)
6463         (ada_add_global_exceptions): Use objfile_compunits.
6464
6465 2019-01-09  Tom Tromey  <tom@tromey.com>
6466
6467         * source.c (select_source_symtab)
6468         (forget_cached_source_info_for_objfile): Remove declaration.
6469         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6470         declaration.
6471         * maint.c (count_symtabs_and_blocks): Remove declaration.
6472         * cp-support.c (add_symbol_overload_list_qualified): Remove
6473         declaration.
6474         * coffread.c (coff_symtab_read): Remove declaration.
6475         * symtab.c (lookup_symbol_in_objfile_symtabs)
6476         (basic_lookup_transparent_type_1): Use objfile_compunits.
6477         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6478         (info_sources_command, search_symbols)
6479         (default_collect_symbol_completion_matches_break_on)
6480         (make_source_files_completion_list): Remove declaration.
6481         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6482         (ada_collect_symbol_completion_matches)
6483         (ada_add_global_exceptions): Remove declaration.
6484         * linespec.c (iterate_over_all_matching_symtabs): Use
6485         objfile_compunits.
6486         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6487         (class objfile_compunits): New.
6488         (ALL_COMPUNITS): Use objfile_compunits.
6489         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6490         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6491         objfile_compunits.
6492         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6493
6494 2019-01-09  Tom Tromey  <tom@tromey.com>
6495
6496         * symtab.c (search_symbols)
6497         (default_collect_symbol_completion_matches_break_on): Use
6498         objfile_msymbols.
6499         * ada-lang.c (ada_lookup_simple_minsym)
6500         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6501         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6502         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6503         objfile_msymbols.
6504         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6505         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6506         * objc-lang.c (find_methods): Use objfile_msymbols.
6507         (info_selectors_command, info_classes_command): Likewise.
6508         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6509         * objfiles.h (class objfile_msymbols): New.
6510         (ALL_OBJFILE_MSYMBOLS): Remove.
6511         (ALL_MSYMBOLS): Remove.
6512
6513 2019-01-09  Tom Tromey  <tom@tromey.com>
6514
6515         * common/next-iterator.h (next_adapter): Add Iterator template
6516         parameter.
6517         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6518         (class all_objfiles_safe): New.
6519         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6520         * objfiles.c (put_objfile_before): Update comment.
6521         (add_separate_debug_objfile): Likewise.
6522         (free_all_objfiles): Use all_objfiles_safe.
6523         (objfile_purge_solibs): Likewise.
6524
6525 2019-01-09  Tom Tromey  <tom@tromey.com>
6526
6527         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6528         (expand_symtab_containing_pc, lookup_static_symbol)
6529         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6530         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6531         all_objfiles.
6532         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6533         * breakpoint.c (create_overlay_event_breakpoint)
6534         (create_longjmp_master_breakpoint)
6535         (create_std_terminate_master_breakpoint)
6536         (create_exception_master_breakpoint): Use all_objfiles.
6537         * linux-thread-db.c (try_thread_db_load_from_pdir)
6538         (has_libpthread): Use all_objfiles.
6539         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6540         * linespec.c (iterate_over_all_matching_symtabs)
6541         (search_minsyms_for_name): Use all_objfiles.
6542         * maint.c (maintenance_info_sections): Use all_objfiles.
6543         * main.c (captured_main_1): Use all_objfiles.
6544         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6545         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6546         * guile/scm-pretty-print.c
6547         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6548         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6549         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6550         (maintenance_print_msymbols): Use all_objfiles.
6551         * source.c (select_source_symtab): Use all_objfiles.
6552         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6553         * symfile.c (remove_symbol_file_command)
6554         (expand_symtabs_matching, map_symbol_filenames): Use
6555         all_objfiles.
6556         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6557         all_objfiles.
6558         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6559         * objc-lang.c (find_methods): Use all_objfiles.
6560         * objfiles.c (have_partial_symbols, have_full_symbols)
6561         (have_minimal_symbols, qsort_cmp)
6562         (default_iterate_over_objfiles_in_search_order): Use
6563         all_objfiles.
6564         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6565         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6566         (maintenance_check_psymtabs): Use all_objfiles.
6567         (ALL_PSYMTABS): Remove.
6568         * compile/compile-object-run.c (do_module_cleanup): Use
6569         all_objfiles.
6570         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6571         * cp-support.c (add_symbol_overload_list_qualified): Use
6572         all_objfiles.
6573         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6574         Use all_objfiles.
6575         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6576         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6577         all_objfiles.
6578         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6579         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6580         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6581         Uses all_objfiles.
6582         * solib.c (solib_read_symbols): Use all_objfiles
6583
6584 2019-01-09  Tom Tromey  <tom@tromey.com>
6585
6586         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6587         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6588         all_objfiles.
6589         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6590         * symmisc.c (print_symbol_bcache_statistics)
6591         (print_objfile_statistics, maintenance_print_objfiles)
6592         (maintenance_info_symtabs, maintenance_check_symtabs)
6593         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6594         all_objfiles.
6595         * source.c (forget_cached_source_info): Use all_objfiles.
6596         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6597         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6598         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6599         * objfiles.c (update_section_map): Use all_objfiles.
6600         (shared_objfile_contains_address_p): Likewise.
6601         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6602         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6603
6604 2019-01-09  Tom Tromey  <tom@tromey.com>
6605
6606         * common/next-iterator.h: New file.
6607         * objfiles.h (class all_objfiles): New.
6608         (struct objfile_iterator): New.
6609
6610 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6611
6612         * NEWS: Move the description of the changed "frame", "select-frame",
6613          and "info frame" commands to the Changed commands section.
6614
6615 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6616
6617         * gdbtypes.c (check_stub_method_group): Remove handling of old
6618         mangling schemes.
6619         * linespec.c (find_methods): Likewise.
6620         * stabsread.c (read_member_functions): Likewise.
6621         * valops.c (search_struct_method): Likewise.
6622         (value_struct_elt_for_reference): Likewise.
6623         * NEWS: Mention this change.
6624
6625 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6626
6627         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6628         print_source_lines.
6629         * source.c (print_source_lines_base): Update line number check.
6630         (print_source_lines): New function.
6631         (source_lines_range::source_lines_range): New function.
6632         * source.h (class source_lines_range): New class.
6633         (print_source_lines): New declaration.
6634
6635 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6636
6637         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6638
6639 2019-01-08  Tom Tromey  <tom@tromey.com>
6640             Simon Marchi  <simon.marchi@ericsson.com>
6641
6642         PR gdb/24060
6643         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6644         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6645         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6646         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6647         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6648         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6649
6650 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6651
6652         * source.c (select_source_symtab): Move header comment to
6653         declaration in source.h.
6654         (forget_cached_source_info_for_objfile): Likewise.
6655         (forget_cached_source_info): Likewise.
6656         (identify_source_line): Likewise.
6657         * source.h (identify_source_line): Move declaration from symtab.h
6658         and add comment from source.c
6659         (print_source_lines): Likewise.
6660         (forget_cached_source_info_for_objfile): Likewise.
6661         (forget_cached_source_info): Likewise.
6662         (select_source_symtab): Likewise.
6663         (enum print_source_lines_flag): Move definition from symtab.h.
6664         * symtab.h (identify_source_line): Move declaration to source.h.
6665         (print_source_lines): Likewise.
6666         (forget_cached_source_info_for_objfile): Likewise.
6667         (forget_cached_source_info): Likewise.
6668         (select_source_symtab): Likewise.
6669         (enum print_source_lines_flag): Move definition to source.h.
6670         * tui/tui-hooks.c: Add 'source.h' include.
6671
6672 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6673
6674         * source.c (print_source_lines_base): Handle requests to print
6675         reverse line number sequences, and guard against empty lines
6676         string.
6677
6678 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6679
6680         * source.c (print_source_lines_base): Fix skip of '\r' if next
6681         character is '\n'.
6682
6683 2019-01-06  Tom Tromey  <tom@tromey.com>
6684
6685         * c-exp.y (struct c_parse_state) <macro_original_text,
6686         expansion_obstack>: New member.
6687         (macro_original_text, expansion_obstack): Remove globals.
6688         (scan_macro_expansion, scanning_macro_expansion)
6689         (finished_macro_expansion): Update.
6690         (scan_macro_cleanup): Remove.
6691         (yylex, c_parse): Update.
6692
6693 2019-01-06  Tom Tromey  <tom@tromey.com>
6694
6695         * c-exp.y (struct c_parse_state) <strings>: New member.
6696         (operator_stoken): Update.
6697
6698 2019-01-06  Tom Tromey  <tom@tromey.com>
6699
6700         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6701         (union type_stack_elt) <typelist_val>: Now a pointer to
6702         std::vector.
6703         (type_stack_cleanup): Don't declare.
6704         (push_typelist): Update.
6705         * parse.c (pop_typelist): Return a std::vector.
6706         (push_typelist): Take a std::vector.
6707         (follow_types): Update.  Do not free args.
6708         (type_stack_cleanup): Remove.
6709         * c-exp.y (struct c_parse_state): New.
6710         (cpstate): New global.
6711         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6712         (nonempty_typelist): Update.
6713         (func_mod): Create a new vector.
6714         (c_parse): Create a c_parse_state.
6715         (check_parameter_typelist): Do not delete params.
6716         (function_method): Update.  Do not delete type_list.
6717
6718 2019-01-06  Tom Tromey  <tom@tromey.com>
6719
6720         PR gdb/28155:
6721         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6722         check_typedef.
6723         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6724         (print_return_value): Likewise.
6725
6726 2019-01-05  Tom Tromey  <tom@tromey.com>
6727
6728         * contrib/cleanup_check.py: Remove.
6729         * contrib/gcc-with-excheck: Remove.
6730         * contrib/exsummary.py: Remove.
6731         * contrib/excheck.py: Remove.
6732
6733 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6734
6735         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6736         NULL. Initialize tpprev to NULL instead of assigning it
6737         to NULL on the next statement.
6738         * windows-nat.c (windows_delete_thread): Remove check for
6739         main_thread_id before printing thread exit notifications.
6740         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6741         Remove thread ID check against main_thread_id.
6742         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6743         windows_delete_thread.
6744         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6745
6746 2019-01-04  Tom Tromey  <tom@tromey.com>
6747
6748         * compile/compile.c (_initialize_compile): Use upper case for
6749         metasyntactic variables.
6750         * symmisc.c (_initialize_symmisc): Use upper case for
6751         metasyntactic variables.
6752         * psymtab.c (_initialize_psymtab): Use upper case for
6753         metasyntactic variables.
6754         * demangle.c (demangle_command): Use upper case for metasyntactic
6755         variables.
6756         (_initialize_demangler): Likewise.
6757         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6758         variables.
6759
6760 2019-01-03  Tom Tromey  <tom@tromey.com>
6761
6762         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6763
6764 2019-01-03  Tom Tromey  <tom@tromey.com>
6765
6766         * python/py-symtab.c (salpy_str): Update.
6767         (struct salpy_sal_object) <symtab>: Now a PyObject.
6768         (salpy_dealloc): Update.
6769         (del_objfile_sal): Use gdbpy_ref.
6770
6771 2019-01-03  Tom Tromey  <tom@tromey.com>
6772
6773         * python/py-type.c (convert_field): Use new_reference.  Return
6774         gdbpy_ref.
6775         (make_fielditem): Return gdbpy_ref.
6776         (typy_fields): Update.
6777         (typy_getitem): Update.
6778         (field_name): Return gdbpy_ref.  Use new_reference.
6779         (typy_iterator_iternext): Update.
6780
6781 2019-01-03  Tom Tromey  <tom@tromey.com>
6782
6783         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6784
6785 2019-01-03  Tom Tromey  <tom@tromey.com>
6786
6787         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6788         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6789         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6790         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6791         (pspy_set_type_printers): Likewise.
6792         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6793         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6794         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6795         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6796         (objfpy_set_type_printers): Likewise.
6797
6798 2019-01-03  Tom Tromey  <tom@tromey.com>
6799
6800         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6801         (gdbpy_print_stack): Use gdbpy_err_fetch.
6802         * python/python-internal.h (class gdbpy_err_fetch): New class.
6803         (class gdbpy_enter) <m_error_type, m_error_value,
6804         m_error_traceback>: Remove.
6805         <m_error>: New member.
6806         (gdbpy_exception_to_string): Don't declare.
6807         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6808         * python/py-value.c (convert_value_from_python): Use
6809         gdbpy_err_fetch.
6810         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6811         gdbpy_exception_to_string.
6812         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6813         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6814         gdbpy_err_fetch.
6815
6816 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6817
6818         * linux-nat.c (delete_lwp_cleanup): Delete.
6819         (struct lwp_deleter): New struct.
6820         (lwp_info_up): New typedef.
6821         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6822         lwp_info_up.
6823
6824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6825
6826         * linux-fork.c (class scoped_switch_fork_info): New class.
6827         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6828
6829 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6830
6831         * valops.c (find_overload_match): Remove use of null_cleanup, and
6832         calls to do_cleanups.
6833
6834 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6835
6836         * compile/compile-cplus-types.c
6837         (compile_cplus_instance::decl_name): Handle changes to
6838         cp_func_name.
6839         * cp-support.c (cp_func_name): Update header comment, update
6840         return type.
6841         * cp-support.h (cp_func_name): Update return type in declaration.
6842         * valops.c (find_overload_match): Move temp_func local to top
6843         level of function and change its type.  Use temp_func to hold and
6844         delete temporary string obtained from cp_func_name.
6845
6846 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6847
6848         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6849         gdb::char_vector, remove cleanup, and update uses of `msg`.
6850
6851 2019-01-03  Jim Wilson  <jimw@sifive.com>
6852
6853         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6854
6855 2019-01-02  Tom Tromey  <tom@tromey.com>
6856
6857         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6858         (tdesc_parse_xml): Remove cleanups.
6859         * target-descriptions.h (make_cleanup_free_target_description):
6860         Don't declare.
6861         (target_desc_deleter): New struct.
6862         (target_desc_up): New typedef.
6863         * target-descriptions.c (target_desc_deleter::operator()): Rename
6864         from free_target_description.
6865         (make_cleanup_free_target_description): Remove.
6866
6867 2019-01-02  Tom Tromey  <tom@tromey.com>
6868
6869         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6870         constructor, destructor.
6871         (linespec_parser): Remove typedef.
6872         (~linespec_parser): Rename from linespec_parser_delete.
6873         (linespec_lex_to_end, linespec_complete_label)
6874         (linespec_complete): Update.
6875         (decode_line_full): Remove cleanups.
6876         (decode_line_1): Update.
6877
6878 2019-01-02  Tom Tromey  <tom@tromey.com>
6879
6880         * python/python-internal.h (inferior_to_inferior_object): Change
6881         return type.
6882         * python/py-exitedevent.c (create_exited_event_object): Update.
6883         * python/py-inferior.c (inferior_to_inferior_object): Return
6884         gdbpy_ref.
6885         (python_new_inferior, python_inferior_deleted)
6886         (thread_to_thread_object, delete_thread_object)
6887         (build_inferior_list, gdbpy_selected_inferior): Update.
6888         * python/py-infthread.c (create_thread_object): Update.  Also fail
6889         if inferior_to_inferior_object fails.
6890
6891 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6892
6893         * inferior.h (class inferior) <displaced_step_state>: New field.
6894         * infrun.h (struct displaced_step_state): Move here from
6895         infrun.c.  Initialize fields, add constructor.
6896         <inf>: Remove field.
6897         <reset>: New method.
6898         * infrun.c (struct displaced_step_inferior_state): Move to
6899         infrun.h.
6900         (displaced_step_inferior_states): Remove.
6901         (get_displaced_stepping_state): Adust.
6902         (displaced_step_in_progress_any_inferior): Adjust.
6903         (displaced_step_in_progress_thread): Adjust.
6904         (displaced_step_in_progress): Adjust.
6905         (add_displaced_stepping_state): Remove.
6906         (get_displaced_step_closure_by_addr): Adjust.
6907         (remove_displaced_stepping_state): Remove.
6908         (infrun_inferior_exit): Call displaced_step_state.reset.
6909         (use_displaced_stepping): Don't check for NULL.
6910         (displaced_step_prepare_throw): Call
6911         get_displaced_stepping_state.
6912         (displaced_step_fixup): Don't check for NULL.
6913         (prepare_for_detach): Don't check for NULL.
6914
6915 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6916
6917         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6918          in case of call that did not complete.
6919
6920 2019-01-02  Andrey Utkin  <autkin@undo.io>
6921
6922         * symfile.c (find_separate_debug_file): Fix search of debug files for
6923         remote debuggee.
6924
6925 2019-01-02  Tom Tromey  <tom@tromey.com>
6926
6927         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6928         indentation.
6929         * python/py-frame.c (frapy_older): Remove cast.
6930         (frapy_newer): Likewise.
6931         * python/py-breakpoint.c (local_setattro): Remove cast.
6932         * python/py-arch.c (archpy_name): Remove local variable.
6933         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6934
6935 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6936
6937         * unittests/basic_string_view/element_access/char/empty.cc:
6938         Fix year range in copyright header.
6939
6940 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6941
6942         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6943         Delete.
6944         <operator==>: Update with for removed field.
6945         <hash>: Likewise.
6946         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6947         <isa_features>: ...this.
6948         <abi_features>: New field.
6949         (riscv_isa_flen): Update comment.
6950         (riscv_abi_xlen): New declaration.
6951         (riscv_abi_flen): New declaration.
6952         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6953         isa_features.
6954         (riscv_abi_xlen): New function.
6955         (riscv_isa_flen): Update to get answer from isa_features.
6956         (riscv_abi_flen): New function.
6957         (riscv_has_fp_abi): Update to get answer from abi_features.
6958         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6959         xlen and flen.
6960         (riscv_call_info) <xlen, flen>: Update comment.
6961         (riscv_call_arg_struct): Remove invalid assertions
6962         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6963         is removed.
6964         (riscv_gdbarch_init): Gather isa features and abi features
6965         separately, ensure both match on the gdbarch when reusing an old
6966         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6967         a target with 64-bit float hardware.
6968
6969 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6970
6971         * source.c (search_command_helper): Stop reverse search
6972         when line 1 has been searched.
6973
6974 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6975
6976         * record-full.c (record_full_base_target::close): Rewrite
6977         record_full_core_buf_list free logic.
6978
6979 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6980
6981         * break-catch-syscall.c (print_one_catch_syscall): xfree
6982         the last text.
6983
6984 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6985
6986         * top.c (print_gdb_version): Update Copyright year in version
6987         message.
6988
6989 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6990
6991         Update copyright year range in all GDB files.
6992
6993 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6994
6995         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6996
6997 For older changes see ChangeLog-2018.
6998 \f
6999 Local Variables:
7000 mode: change-log
7001 left-margin: 8
7002 fill-column: 74
7003 version-control: never
7004 coding: utf-8
7005 End:
7006