gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <refresh_all>: Don't declare.
   5         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
   6         Remove.
   7         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
   8         tui_show_locator_content.
   9         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
  10         declare.
  11         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
  12         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
  13         declare.
  14
  15 2019-08-30  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
  18
  19 2019-08-30  Tom Tromey  <tom@tromey.com>
  20
  21         * tui/tui-stack.c (_initialize_tui_stack): Move later.
  22         Remove unnecessary forward declarations.
  23
  24 2019-08-30  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
  27         rerender.
  28         (tui_update_locator_fullname, tui_show_frame_info): Don't call
  29         tui_show_locator_content.
  30
  31 2019-08-30  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
  34         (tui_locator_window::rerender): Rewrite using body of previous
  35         tui_show_locator_content.
  36
  37 2019-08-30  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
  40         set_locator_fullname>: New methods.
  41         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
  42         Rename from tui_set_locator_fullname.
  43         (tui_locator_window::set_locator_info): Rename from
  44         tui_set_locator_info.  Return bool.
  45         (tui_update_locator_fullname, tui_show_frame_info): Update.
  46
  47 2019-08-30  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
  50
  51 2019-08-30  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
  54         call touchwin.
  55
  56 2019-08-30  Tom Tromey  <tom@tromey.com>
  57
  58         * tui/tui-wingeneral.c (box_win): Assume win_info and
  59         win_info->handle cannot be NULL.
  60
  61 2019-08-30  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
  64         refresh_window>: Declare.
  65         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
  66         resize.
  67         (tui_data_item_window::rerender): Rename from
  68         tui_display_register.
  69         (tui_data_item_window::refresh_window): New method.
  70         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
  71         no-op.
  72
  73 2019-08-30  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-regs.h (struct tui_data_window) <regs_content,
  76         regs_column_count, current_group>: Move later.  Now private.
  77         <get_current_group>: New method.
  78         * tui/tui-regs.c (tui_reg_command): Update.
  79         * tui/tui-layout.c (tui_set_layout): Update.
  80
  81 2019-08-30  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
  84         (tui_data_window::rerender): Don't call
  85         check_and_display_highlight_if_needed.
  86         (tui_data_window::refresh_all): Remove call to
  87         erase_data_content.
  88
  89 2019-08-30  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  92         (tui_data_window::display_registers_from)
  93         (tui_data_window::display_reg_element_at_line)
  94         (tui_data_window::display_registers_from_line): Remove checks of
  95         "empty".
  96
  97 2019-08-30  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 100         Don't declare.
 101         * tui/tui-regs.c (tui_data_window::show_registers): Call
 102         rerender.
 103         (tui_data_window::rerender): Rename from display_all_data.
 104         (tui_data_window::rerender): Remove old implementation.
 105
 106 2019-08-30  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 109         text.
 110         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 111
 112 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 113             Sergio Durigan Junior  <sergiodj@redhat.com>
 114
 115         PR win32/24284
 116         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 117
 118 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 119
 120         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 121         when searching for types.
 122
 123 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 124
 125         * f-lang.c (f_language_defn): Use f_print_typedef.
 126         * f-lang.h (f_print_typedef): Declare.
 127         * f-typeprint.c (f_print_typedef): Define.
 128
 129 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 130
 131         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 132
 133 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 134
 135         * cli/cli-utils.c (info_print_options_defs): Delete.
 136         (make_info_print_options_def_group): Delete.
 137         (extract_info_print_options): Delete.
 138         (info_print_command_completer): Delete.
 139         (info_print_args_help): Add extra parameter, and optionally
 140         include text about -n flag.
 141         * cli/cli-utils.h (struct info_print_options): Delete.
 142         (extract_info_print_options): Delete declaration.
 143         (info_print_command_completer): Delete declaration.
 144         (info_print_args_help): Add extra parameter, extend header
 145         comment.
 146         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 147         search_symbols.
 148         * stack.c (struct info_print_options): New type.
 149         (info_print_options_defs): New file scoped variable.
 150         (make_info_print_options_def_group): New static function.
 151         (info_print_command_completer): New static function.
 152         (info_locals_command): Update to use new local functions.
 153         (info_args_command): Likewise.
 154         (_initialize_stack): Add extra parameter to calls to
 155         info_print_args_help.
 156         * symtab.c (search_symbols): Add extra parameter, use this to
 157         possibly excluse non-debug symbols.
 158         (symtab_symbol_info): Add extra parameter, which is passed on to
 159         search_symbols.
 160         (struct info_print_options): New type.
 161         (info_print_options_defs): New file scoped variable.
 162         (make_info_print_options_def_group): New static function.
 163         (info_print_command_completer): New static function.
 164         (info_variables_command): Update to use local functions, and pass
 165         extra parameter through to symtab_symbol_info.
 166         (info_functions_command): Likewise.
 167         (info_types_command): Pass additional argument through to
 168         symtab_symbol_info.
 169         (rbreak_command): Pass extra argument to search_symbols.
 170         (_initialize_symtab): Add extra arguments for calls to
 171         info_print_args_help, and update help text for 'info variables',
 172         'whereis', and 'info functions' commands.
 173         * symtab.h (search_symbols): Add extra argument to declaration.
 174         * NEWS: Mention new flags.
 175
 176 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 177
 178         * symtab.c (lookup_static_symbol): Call the new function (and move
 179         it down to be next to lookup_global_symbol).
 180         (struct global_sym_lookup_data): Add block_enum member and rename to...
 181         (struct global_or_static_sym_lookup_data): ...this.
 182         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 183         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 184         (lookup_symbol_global_or_static_iterator_cb): ...this.
 185         (lookup_global_or_static_symbol): New function.
 186         (lookup_global_symbol): Call new function.
 187
 188 2019-08-26  Tom de Vries  <tdevries@suse.de>
 189
 190         PR c++/24852
 191         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 192         when pc_probe.prob == NULL.
 193
 194 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 195
 196         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 197         variable symbol_linkage to symbol_linkage_.
 198
 199 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 200
 201         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 202         represent whether the symbol is static, dynamic, or we don't
 203         know.
 204
 205 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 206
 207         * gdb/rx-tdep.c (rx_register_names): New.
 208         (rx_register_name): Delete.
 209         (rx_psw_type): Delete.
 210         (rx_fpsw_type): Delete.
 211         (rx_register_type): Delete.
 212         (rx_gdbarch_init): Convert target-descriptions.
 213         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 214         * gdb/features/Makefile: Add rx.xml.
 215         * gdb/features/rx.xml: New.
 216         * gdb/features/rx.c: Generated.
 217         * gdb/NEWS: Mention target description support.
 218
 219 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 220
 221         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 222         *slot_ptr.
 223
 224 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 225
 226         * configure.ac: Don't check for 'dlfcn.h' (moved to
 227         gdbsupport/common.m4).
 228         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 229         'gdbsupport/'.
 230         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 231         * compile/compile-c-support.c: Include
 232         'gdbsupport/gdb-dlfcn.h'.
 233         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 234         * gdb-dlfcn.c: Move to...
 235         * gdbsupport/gdb-dlfcn.c: ... here.
 236         * gdb-dlfcn.h: Move to...
 237         * gdbsupport/gdb-dlfcn.h: ... here.
 238
 239 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 240
 241         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 242         the offset field signed.
 243
 244 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 245
 246         * python/lib/gdb/__init__.py (_execute_file): New function.
 247         * python/python.c (python_run_simple_file): Call gdb._execute_file
 248         on Windows.
 249
 250 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 251
 252         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 253         all uses as this was never set to anything but a zero value.
 254
 255 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 256
 257         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 258
 259 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 260
 261         * tui/tui-data.h (tui_gen_win_info): Add an =default
 262         move constructor, required by some GCC versions.
 263
 264 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 265
 266         * go32-nat.c (go32_sysinfo): Add hygon_p.
 267
 268 2019-08-20  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 271         line_from_reg_element_no, first_reg_element_no_inline,
 272         display_all_data, delete_data_content_windows,
 273         erase_data_content>: Now private.
 274
 275 2019-08-20  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 278         (tui_unhighlight_win, tui_highlight_win)
 279         (tui_win_info::make_window): Update.
 280         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 281
 282 2019-08-20  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 285         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 286         (MAX_PID_WIDTH): Move to tui-stack.c.
 287         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 288         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 289         (MAX_PID_WIDTH): Move from tui-data.h.
 290
 291 2019-08-20  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 294         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 295         (box_win): Update.
 296         (tui_gen_win_info::make_window): Rename from tui_make_window.
 297         (tui_win_info::make_window): New method.
 298         (tui_gen_win_info::make_visible): Update.
 299         * tui/tui-source.c (tui_source_window::set_contents): Update.
 300         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 301         (tui_data_window::display_registers_from): Update.
 302         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 303         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 304         Declare.
 305         <can_box>: Remove.
 306         <title>: Remove.
 307         (struct tui_win_info) <make_window>: Declare.
 308         <can_box>: Now virtual.
 309         <title>: New member.
 310         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 311         * tui/tui-command.c (tui_cmd_window::resize): Update.
 312
 313 2019-08-20  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 316         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 317         (tui_data_window::check_register_values): Update.
 318
 319 2019-08-20  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-regs.h (struct tui_data_window): Use
 322         DISABLE_COPY_AND_ASSIGN.
 323         <regs_content>: Change type, removing unique_ptr.
 324         <tui_data_window>: Add move constructor.
 325         * tui/tui-regs.c (tui_data_window::show_registers)
 326         (tui_data_window::show_register_group)
 327         (tui_data_window::display_registers_from)
 328         (tui_data_window::display_registers_from)
 329         (tui_data_window::first_data_item_displayed)
 330         (tui_data_window::delete_data_content_windows)
 331         (tui_data_window::rerender, tui_data_window::refresh_window)
 332         (tui_data_window::check_register_values): Update.
 333
 334 2019-08-20  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 337         show_register_group>: Declare.
 338         (tui_show_register_group): Don't declare.
 339         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 340         tui_show_registers.
 341         (tui_data_window::show_register_group): Rename from
 342         tui_show_register_group.
 343         (tui_data_window::check_register_values, tui_reg_command):
 344         Update.
 345         * tui/tui-layout.c (tui_set_layout): Update.
 346
 347 2019-08-20  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 350         Declare.
 351         (tui_check_register_values): Don't declare.
 352         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 353         from tui_check_register_values.
 354         * tui/tui-hooks.c (tui_register_changed): Update.
 355
 356 2019-08-20  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-regs.c (tui_reg_layout): Move later.
 359         (tui_show_registers): Don't enable TUI mode or change layout.
 360
 361 2019-08-20  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-regs.h (struct tui_data_item_window)
 364         <~tui_data_item_window>: Remove.
 365         <content>: Now a unique_xmalloc_ptr.
 366         * tui/tui-regs.c (tui_register_format): Return a
 367         unique_xmalloc_ptr.
 368         (tui_get_register): Update.
 369         (~tui_data_item_window): Remove.
 370         (tui_data_window::display_registers_from, tui_display_register):
 371         Update.
 372         * tui/tui-io.h (tui_expand_tabs): Update.
 373         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 374         Remove "col" parameter.
 375
 376 2019-08-20  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 379         field.
 380         * tui/tui-regs.c (~tui_data_item_window): Update.
 381
 382 2019-08-20  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 385         earlier.
 386
 387 2019-08-20  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 390
 391 2019-08-20  Tom Tromey  <tom@tromey.com>
 392
 393         * tui/tui-source.h (struct tui_source_window): Update.
 394         * tui/tui-regs.c (tui_show_registers): Update.
 395         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 396         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 397         (NO_REGS_STRING): Remove defines.
 398
 399 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 400
 401         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 402         unnecessary thread walk if remote doesn't support the packet.
 403
 404 2019-08-19  Tom Tromey  <tromey@adacore.com>
 405
 406         * python/py-value.c (value_has_field): Fix indentation.
 407
 408 2019-08-19  Tom Tromey  <tromey@adacore.com>
 409
 410         * printcmd.c (do_one_display, info_display_command): Update.
 411         * block.h (contained_in): Return bool.  Add allow_nested
 412         parameter.
 413         * block.c (contained_in): Return bool.  Add allow_nested
 414         parameter.
 415
 416 2019-08-19  Tom Tromey  <tom@tromey.com>
 417
 418         * configure: Rebuild.
 419         * configure.ac: Disallow the combination of -static-libstdc++ and
 420         source highlight.
 421         * source-cache.c (get_language_name): Handle rust.
 422         (source_cache::get_source_lines): Ignore highlighting exceptions.
 423
 424 2019-08-16  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 427         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 428         (struct tui_source_window_base) <make_visible, refresh_window,
 429         resize>: Remove methods.
 430         <execution_info>: Remove field.
 431         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 432         (tui_show_source_line, tui_source_window_base)
 433         (~tui_source_window_base): Update.
 434         (tui_source_window_base::resize)
 435         (tui_source_window_base::make_visible)
 436         (tui_source_window_base::refresh_window): Remove.
 437         (tui_source_window_base::update_exec_info): Update.
 438         * tui/tui-source.c (tui_source_window::set_contents): Update.
 439         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 440
 441 2019-08-16  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 444         deprecated_query_hook.
 445
 446 2019-08-16  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 449         (tui_update_source_windows_with_line): Update.
 450         * tui/tui-source.h (struct tui_source_window)
 451         <show_symtab_source>: Declare.
 452         (tui_show_symtab_source): Don't declare.
 453         * tui/tui-source.c (tui_show_symtab_source): Rename from
 454         tui_show_symtab_source.
 455
 456 2019-08-16  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-winsource.h (struct tui_source_window_base)
 459         <set_contents>: Declare.
 460         * tui/tui-winsource.c
 461         (tui_source_window_base::update_source_window_as_is): Update.
 462         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 463         Declare.
 464         (tui_set_source_content): Don't declare.
 465         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 466         tui_set_source_content.
 467         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 468         Declare.
 469         (tui_set_disassem_content): Don't declare.
 470         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 471         tui_set_disassem_content.
 472
 473 2019-08-16  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-winsource.h (struct tui_source_window_base)
 476         <update_breakpoint_info>: Declare.
 477         (tui_update_breakpoint_info): Don't declare.
 478         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 479         (tui_update_all_breakpoint_info): Update.
 480         (tui_source_window_base::update_breakpoint_info): Rename from
 481         tui_update_breakpoint_info.
 482         (tui_source_window_base::update_exec_info): Update.
 483
 484 2019-08-16  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-winsource.h (struct tui_source_window_base)
 487         <update_source_window>: Declare.
 488         (tui_update_source_window): Don't declare.
 489         * tui/tui-winsource.c
 490         (tui_source_window_base::update_source_window): Rename from
 491         tui_update_source_window.
 492         (tui_source_window_base::rerender): Update.
 493         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 494         * tui/tui-disasm.c (tui_show_disassem)
 495         (tui_show_disassem_and_update_source)
 496         (tui_disasm_window::maybe_update): Update.
 497
 498 2019-08-16  Tom Tromey  <tom@tromey.com>
 499
 500         * tui/tui-winsource.h (struct tui_source_window_base)
 501         <update_source_window_as_is>: Declare.
 502         (tui_update_source_window_as_is): Don't declare.
 503         * tui/tui-winsource.c (tui_update_source_window): Update
 504         (tui_source_window_base::update_source_window_as_is): Rename from
 505         tui_update_source_window_as_is.
 506         (tui_source_window_base::refill): Update.
 507         * tui/tui-source.c (tui_show_symtab_source): Update.
 508         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 509         Update.
 510
 511 2019-08-16  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-winsource.h (tui_update_source_window)
 514         (tui_update_source_window_as_is): Remove "noerror" parameter.
 515         * tui/tui-winsource.c (tui_update_source_window)
 516         (tui_update_source_window_as_is): Remove "noerror" parameter.
 517         (tui_update_source_windows_with_addr)
 518         (tui_update_source_windows_with_line)
 519         (tui_source_window_base::rerender)
 520         (tui_source_window_base::refill): Update.
 521         * tui/tui-source.h (tui_set_source_content)
 522         (tui_show_symtab_source): Remove "noerror" parameter.
 523         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 524         parameter.
 525         (tui_show_symtab_source): Likewise.
 526         (tui_source_window::maybe_update): Update.
 527         * tui/tui-disasm.c (tui_show_disassem)
 528         (tui_show_disassem_and_update_source)
 529         (tui_disasm_window::do_scroll_vertical)
 530         (tui_disasm_window::maybe_update): Update.
 531
 532 2019-08-16  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui.c (tui_is_window_visible): Update.
 535         * tui/tui-wingeneral.c (tui_make_window)
 536         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 537         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 538         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 539         (tui_set_win_height_command, parse_scrolling_args): Update.
 540         * tui/tui-source.c (tui_source_window::style_changed): Update.
 541         * tui/tui-regs.c (tui_show_registers)
 542         (tui_data_window::first_data_item_displayed)
 543         (tui_data_window::delete_data_content_windows)
 544         (tui_check_register_values, tui_reg_command): Update.
 545         * tui/tui-disasm.c (tui_show_disassem): Update.
 546         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 547         method.
 548         <is_visible>: Remove field.
 549         * tui/tui-data.c (tui_next_win, tui_prev_win)
 550         (tui_delete_invisible_windows): Update.
 551
 552 2019-08-16  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-winsource.h (struct tui_source_window_base)
 555         <m_has_locator>: Remove.
 556         * tui/tui-layout.c (show_source_disasm_command, show_data)
 557         (show_source_or_disasm_and_command): Update.
 558
 559 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 560
 561         * NEWS (Other MI changes): New subsection.
 562         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 563         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 564         * arch-utils.c (default_get_pc_address_flags): New function.
 565         * arch-utils.h (default_get_pc_address_flags): New declaration.
 566         * gdbarch.sh: Add get_pc_address_flags.
 567         * gdbarch.c: Regenerate.
 568         * gdbarch.h: Likewise.
 569         * stack.c (print_pc): New function.
 570         (print_frame_info) (print_frame): Call print_pc.
 571
 572 2019-08-16  Tom de Vries  <tdevries@suse.de>
 573
 574         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 575         print_objfile_section_info.
 576
 577 2019-08-15  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 580         calling update_cmdwin_start_line.
 581         * tui/tui-winsource.h (struct tui_source_window_base)
 582         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 583         <rerender>: Declare.
 584         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 585         Call rerender.
 586         (tui_source_window_base::set_new_height): Remove.
 587         (tui_source_window_base::rerender): Rename from
 588         do_make_visible_with_new_height.
 589         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 590         resize method.
 591         (tui_win_info::make_invisible_and_set_new_height)
 592         (tui_win_info::make_visible_with_new_height): Remove.
 593         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 594         Declare.
 595         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 596         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 597         do_make_visible_with_new_height>: Don't declare.
 598         <rerender>: Declare.
 599         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 600         set_new_height.
 601         (tui_data_window::do_make_visible_with_new_height): Remove.
 602         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 603         call tui_show_locator_content.
 604         (tui_gen_win_info::resize): Call rerender.
 605         (show_source_or_disasm_and_command): Don't call
 606         tui_show_locator_content.
 607         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 608         method.
 609         (struct tui_win_info) <rerender>: Declare.
 610         <set_new_height, make_invisible_and_set_new_height,
 611         make_visible_with_new_height>: Don't declare.
 612         * tui/tui-data.c (tui_win_list::rerender): New method.
 613         * tui/tui-command.h (struct tui_cmd_window)
 614         <do_make_visible_with_new_height>: Don't declare.
 615         * tui/tui-command.c
 616         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 617
 618 2019-08-15  Tom Tromey  <tromey@adacore.com>
 619
 620         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 621         * ada-lang.c (ada_enum_name): Likewise.
 622
 623 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 624
 625         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 626         leading underscore.
 627         (GdbOutputErrorFile): Likewise.
 628         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 629         accordingly.
 630         (execute_unwinders): Rename to have a leading underscore.
 631         (auto_load_packages): Likewise.
 632         (global scope): Adjust call to auto_load_packages accordingly.
 633         (GdbSetPythonDirectory): Likewise.
 634         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 635         instead of execute_unwinders.
 636
 637 2019-08-15  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 640         (show_data): Don't change window visibility.
 641         (tui_gen_win_info::resize): Remove special case for command
 642         window.  Use wresize, when available.
 643         (show_source_or_disasm_and_command): Don't change window
 644         visibility.
 645         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 646         <make_visible>: New method.
 647         * tui/tui-command.c (tui_cmd_window::resize): New method.
 648
 649 2019-08-15  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 652         (struct tui_source_windows): New.
 653         * tui/tui-winsource.c (tui_display_main): Update.
 654         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 655         (new_height_ok, parse_scrolling_args): Update.
 656         * tui/tui-layout.c (show_layout, show_data): Update.
 657         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 658         (tui_add_to_source_windows): Don't declare.
 659         * tui/tui-data.c (source_windows, tui_source_windows)
 660         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 661
 662 2019-08-15  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 665         Rename from reset.
 666         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 667         * tui/tui-layout.c (show_source_disasm_command, show_data):
 668         Update.
 669         (tui_gen_win_info::resize): Rename.
 670         (show_source_or_disasm_and_command): Update.
 671         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 672         reset.
 673
 674 2019-08-15  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 677         * tui/tui-interp.c (tui_interp::init): Don't call
 678         tui_initialize_static_data.
 679         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 680
 681 2019-08-15  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 684         examine tui_win_list.
 685
 686 2019-08-15  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 689         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 690         tui_clear_source_content.
 691         (tui_clear_source_content): Remove.
 692         (tui_source_window_base::do_erase_source_content): Hoist call to
 693         content.clear().
 694         * tui/tui-stack.c (tui_show_frame_info): Don't call
 695         tui_clear_source_content.
 696
 697 2019-08-15  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-winsource.h (struct tui_source_window_base)
 700         <do_erase_source_content>: New method.
 701         <erase_source_content>: New method.
 702         (tui_erase_source_content): Don't declare.
 703         * tui/tui-winsource.c (tui_clear_source_content): Update.
 704         (tui_source_window_base::do_erase_source_content): Rename from
 705         tui_erase_source_content.
 706         (tui_source_window_base::show_source_content): Update.
 707         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 708         * tui/tui-source.h (struct tui_source_window)
 709         <erase_source_content>: New method.
 710         * tui/tui-disasm.h (struct tui_disasm_window)
 711         <erase_source_content>: New method.
 712
 713 2019-08-15  Tom Tromey  <tom@tromey.com>
 714
 715         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 716         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 717         constructor.
 718         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 719         * tui/tui-source.c (tui_set_source_content): Update.
 720         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 721
 722 2019-08-15  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 725         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 726         tui-source.c.
 727         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 728         Declare.
 729         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 730         method.
 731         (tui_source_window::maybe_update): Update.
 732
 733 2019-08-15  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 736         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 737         tui-disasm.c.
 738         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 739         Declare.
 740         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 741         method.
 742         (tui_disasm_window::maybe_update): Update.
 743
 744 2019-08-15  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-winsource.h (struct tui_source_window_base)
 747         <maybe_update>: Declare.
 748         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 749         method.
 750         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 751         Declare.
 752         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 753         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 754         Declare.
 755         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 756
 757 2019-08-15  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 760
 761 2019-08-15  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-wingeneral.c: Include tui-stack.h.
 764         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 765         (struct tui_locator_window): Move from tui-data.h.
 766         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 767         (tui_initialize_static_data): Move from tui-data.c.
 768         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 769         (struct tui_locator_window): Move to tui-stack.c.
 770         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 771         (tui_initialize_static_data): Move to tui-stack.c.
 772
 773 2019-08-15  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-layout.c (show_source_disasm_command)
 776         (show_source_or_disasm_and_command): Use make_visible method, not
 777         tui_make_window.
 778         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 779         Remove.
 780
 781 2019-08-15  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-wingeneral.h (tui_make_window): Update.
 784         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 785         parameter.
 786         (tui_gen_win_info::make_visible): Update.
 787         * tui/tui-regs.c (tui_data_window::display_registers_from):
 788         Update.
 789         * tui/tui-layout.c (show_source_disasm_command)
 790         (show_source_or_disasm_and_command): Update.
 791         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 792         (enum tui_box): Remove.
 793         (struct tui_win_info) <can_box>: New method.
 794         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 795         method.
 796
 797 2019-08-15  Tom de Vries  <tdevries@suse.de>
 798
 799         * linux-nat-trad.c: Include gdbarch.h.
 800
 801 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 802
 803         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 804         register sizes.
 805
 806 2019-08-14  Tom Tromey  <tromey@adacore.com>
 807
 808         * darwin-nat.c: Include gdbarch.h.
 809         * darwin-nat-info.c: Include gdbarch.h.
 810
 811 2019-08-13  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 814         Remove.
 815         * tui/tui-data.c (tui_initialize_static_data): Update.
 816
 817 2019-08-13  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-winsource.h (struct tui_exec_info_window)
 820         <~tui_exec_info_window, maybe_allocate_content, get_content,
 821         m_content>: Remove.
 822         (struct tui_source_window_base) <set_exec_info_content,
 823         show_exec_info_content>: Don't declare.
 824         * tui/tui-winsource.c
 825         (tui_exec_info_window::maybe_allocate_content): Remove.
 826         (tui_source_window_base::update_exec_info): Rename from
 827         set_exec_info_content.
 828         (tui_source_window_base::show_exec_info_content)
 829         (tui_source_window_base::update_exec_info): Remove.
 830
 831 2019-08-13  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 834         declare.
 835         * tui/tui-winsource.c (tui_update_source_window_as_is)
 836         (tui_update_source_windows_with_addr, tui_erase_source_content):
 837         Update.
 838         (tui_clear_exec_info_content): Remove.
 839
 840 2019-08-13  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 843         declare.
 844         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 845         call tui_erase_exec_info_content.
 846         (tui_clear_exec_info_content): Rename from
 847         tui_erase_exec_info_content.
 848         (tui_clear_exec_info_content): Delete.
 849
 850 2019-08-13  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-winsource.h (struct tui_source_window_base)
 853         <show_exec_info_content>: Declare.
 854         (tui_show_exec_info_content): Don't declare.
 855         * tui/tui-winsource.c
 856         (tui_source_window_base::show_exec_info_content): Rename from
 857         tui_show_exec_info_content.
 858         (tui_source_window_base::update_exec_info): Update.
 859
 860 2019-08-13  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 863         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 864         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 865         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 866         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 867         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 868         ... here.
 869
 870 2019-08-13  Tom Tromey  <tom@tromey.com>
 871
 872         * tui/tui-winsource.h (struct tui_source_window_base)
 873         <update_exec_info>: Declare.
 874         (tui_update_exec_info): Don't declare.
 875         * tui/tui-winsource.c (tui_update_source_window_as_is)
 876         (tui_source_window_base::refresh_all)
 877         (tui_update_all_breakpoint_info): Update.
 878         (tui_source_window_base::update_exec_info): Rename from
 879         tui_update_exec_info.
 880         * tui/tui-stack.c (tui_show_frame_info): Update.
 881
 882 2019-08-13  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui-winsource.h (struct tui_source_window_base)
 885         <set_exec_info_content>: Declare.
 886         (tui_set_exec_info_content): Don't declare.
 887         * tui/tui-winsource.c
 888         (tui_source_window_base::set_exec_info_content): Rename from
 889         tui_set_exec_info_content.
 890         (tui_update_exec_info): Update.
 891
 892 2019-08-13  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-winsource.h (struct tui_source_window_base)
 895         <show_source_content>: Declare.
 896         (tui_show_source_content): Don't declare.
 897         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 898         (tui_source_window_base::show_source_content): Rename from
 899         tui_show_source_content.
 900         (tui_source_window_base::refresh_all): Update.
 901         * tui/tui-layout.c (show_source_disasm_command)
 902         (show_source_or_disasm_and_command): Update.
 903
 904 2019-08-13  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-winsource.c (tui_erase_source_content)
 907         (tui_show_source_content, tui_source_window_base::refresh_all):
 908         Update.
 909         * tui/tui-wingeneral.h
 910         (tui_check_and_display_highlight_if_needed): Don't declare.
 911         * tui/tui-wingeneral.c
 912         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 913         check_and_display_highlight_if_needed.
 914         * tui/tui-win.c (tui_rehighlight_all)
 915         (tui_win_info::make_visible_with_new_height): Update.
 916         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 917         (tui_data_window::erase_data_content)
 918         (tui_data_window::display_all_data): Update.
 919         * tui/tui-data.h (struct tui_win_info)
 920         <check_and_display_highlight_if_needed>: Declare.
 921
 922 2019-08-13  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-win.c (tui_resize_all): Call
 925         tui_delete_invisible_windows.
 926         * tui/tui-layout.c (show_layout): Call
 927         tui_delete_invisible_windows.
 928         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 929         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 930
 931 2019-08-13  Tom Tromey  <tom@tromey.com>
 932
 933         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 934         tui_add_win_to_layout.
 935
 936 2019-08-13  Tom Tromey  <tom@tromey.com>
 937
 938         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 939         * tui/tui-layout.c (tui_default_win_height): Now static.
 940
 941 2019-08-13  Tom Tromey  <tom@tromey.com>
 942
 943         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 944         single switch.
 945         (show_source_disasm_command, show_source_or_disasm_and_command):
 946         Don't check current layout.
 947
 948 2019-08-13  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-wingeneral.c (make_all_visible): Remove.
 951         (tui_make_all_invisible): Simplify.
 952         * tui/tui-layout.c (tui_make_all_invisible): Move from
 953         tui-wingeneral.c; simplify.
 954         (show_layout): Hoist call to tui_make_all_invisible.
 955         (show_data): Don't call tui_make_all_invisible.
 956
 957 2019-08-13  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 960         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 961
 962 2019-08-13  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 965         tui-data.c.
 966         (show_source_disasm_command, show_data)
 967         (show_source_or_disasm_and_command): Don't use
 968         tui_set_current_layout_to.
 969         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 970         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 971         tui-layout.c.
 972         (tui_set_current_layout_to): Remove.
 973
 974 2019-08-13  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-layout.c (tui_set_layout): Update.
 977         * tui/tui-data.h (struct tui_layout_def): Remove.
 978         (tui_layout_def): Don't declare.
 979         * tui/tui-data.c (layout_def): Remove.
 980         (tui_layout_def): Remove.
 981
 982 2019-08-13  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-winsource.h (struct tui_source_window_base)
 985         <clear_detail>: No longer "override".
 986         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 987         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 988         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 989         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 990         Remove.
 991         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 992
 993 2019-08-13  Tom Tromey  <tromey@adacore.com>
 994
 995         * tracepoint.c: Don't include readline.h or history.h.
 996
 997 2019-08-12  Tom Tromey  <tom@tromey.com>
 998
 999         * configure: Rebuild.
1000         * configure.ac: Check for readline 7.
1001         * NEWS: Mention readline 7 requirement.
1002         * README: Update.
1003
1004 2019-08-12  Tom Tromey  <tom@tromey.com>
1005
1006         * mingw-hdep.c (gdb_select): Remove readline hack.
1007
1008 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1009
1010         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1011         when the function fails.
1012
1013 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1014
1015         * s390-tdep.c (s390_type_align): New function.
1016         (s390_gdbarch_init): Set it as type_align gdbarch method.
1017
1018 2019-08-09  Tom de Vries  <tdevries@suse.de>
1019
1020         PR gdb/24591
1021         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1022         pc_low with relocation offset.
1023
1024 2019-08-07  Tom Tromey  <tromey@adacore.com>
1025
1026         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1027         (print_frame_args): Update.
1028         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1029         Update.
1030         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1031         * frame.h (struct frame_arg): Add initializers.
1032         <error>: Now a unique_xmalloc_ptr.
1033
1034 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1035
1036         * NEWS: Expand the Pointer Authentication entry.
1037         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1038         (aarch64_frame_unmask_lr): ... to this.
1039         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1040         Call aarch64_frame_unmask_lr.
1041         * frame.c (struct frame_info): Add "masked" variable.
1042         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1043         (fprint_frame): Check for masked pc.
1044         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1045         declarations.
1046         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1047         * stack.c (print_frame): Check for masked pc.
1048
1049 2019-08-06  Tom Tromey  <tom@tromey.com>
1050
1051         * stabsread.c (patch_block_stabs, read_one_struct_field)
1052         (read_enum_type): Use obstack_strndup.
1053         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1054         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1055         * dwarf2read.c (guess_full_die_structure_name)
1056         (anonymous_struct_prefix): Use obstack_strndup.
1057         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1058         * c-exp.y (yylex): Use obstack_strndup.
1059         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1060         (write_var_or_type): Use obstack_strndup.
1061
1062 2019-08-06  Tom Tromey  <tom@tromey.com>
1063
1064         * symfile.c (reread_symbols): Use obstack_strdup.
1065         * stabsread.c (read_type): Use obstack_strdup.
1066         * gdb_obstack.h (obstack_strdup): New overload.
1067         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1068         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1069         (dwarf2_canonicalize_name): Use obstack_strdup.
1070         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1071         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1072         Use obstack_strdup.
1073
1074 2019-08-06  Tom Tromey  <tom@tromey.com>
1075
1076         * gdb_obstack.h (obstack_strdup): Define.
1077         * gdb_obstack.c (obstack_strdup): Don't define.
1078
1079 2019-08-06  Tom Tromey  <tom@tromey.com>
1080
1081         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1082         obstack_strdup.
1083         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1084         obstack_strdup.
1085         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1086         * stabsread.c (common_block_start): Use obstack_strdup.
1087         * objfiles.c (set_objfile_main_name, objfile): Use
1088         obstack_strdup.
1089         * namespace.c (add_using_directive): Use obstack_strdup.
1090         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1091         * jit.c (finalize_symtab): Use obstack_strdup.
1092         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1093         (guess_partial_die_structure_name, partial_die_info::fixup)
1094         (dwarf2_name): Use obstack_strdup.
1095         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1096         obstack_strdup.
1097         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1098         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1099         obstack_strdup.
1100         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1101
1102 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1103
1104         * unittests/help-doc-selftests.c: New file.
1105         * Makefile.in: Add the new file.
1106
1107 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1108
1109         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1110         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1111         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1112         the trailing '.' is not output, and the first character is uppercased.
1113         (print_help_for_command): Update call to print_doc_line.
1114         (print_doc_of_command): Likewise.
1115         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1116         * cli/cli-option.c (append_indented_doc): Do not append newline.
1117         (build_help_option): Append newline after first appended_indented_doc
1118         only if a second call is done.
1119         (build_help): Append 2 new lines before each option, except the first
1120         one.
1121         * compile/compile.c (_initialize_compile): Add new lines after
1122         %OPTIONS%, when not at the end of the help.
1123         Change help doc or code
1124         producing the help doc to respect the invariants.
1125         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1126         Also removed the new line after 'Options:', as all other commands
1127         do not put an empty line between 'Options:' and the first option.
1128         * printcmd.c (_initialize_printcmd): Likewise.
1129         * stack.c (_initialize_stack): Likewise.
1130         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1131         incorrectly telling COMMAND is optional.
1132         * ada-lang.c (_initialize_ada_language): Change help doc or code
1133         producing the help doc to respect the invariants.
1134         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1135         * breakpoint.c (_initialize_breakpoint): Likewise.
1136         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1137         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1138         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1139         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1140         _initialize_cli_style): Likewise.
1141         * corelow.c (core_target_info): Likewise.
1142         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1143         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1144         * filesystem.c (_initialize_filesystem): Likewise.
1145         * frame.c (_initialize_frame): Likewise.
1146         * gnu-nat.c (add_task_commands): Likewise.
1147         * infcall.c (_initialize_infcall): Likewise.
1148         * infcmd.c (_initialize_infcmd): Likewise.
1149         * interps.c (_initialize_interpreter): Likewise.
1150         * language.c (_initialize_language): Likewise.
1151         * linux-fork.c (_initialize_linux_fork): Likewise.
1152         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1153         * maint.c (_initialize_maint_cmds): Likewise.
1154         * memattr.c (_initialize_mem): Likewise.
1155         * printcmd.c (_initialize_printcmd): Likewise.
1156         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1157         _RegEx): Likewise.
1158         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1159         * record-btrace.c (_initialize_record_btrace): Likewise.
1160         * record-full.c (_initialize_record_full): Likewise.
1161         * record.c (_initialize_record): Likewise.
1162         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1163         * regcache.c (_initialize_regcache): Likewise.
1164         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1165         _initialize_remote): Likewise.
1166         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1167         * serial.c (_initialize_serial): Likewise.
1168         * skip.c (_initialize_step_skip): Likewise.
1169         * source.c (_initialize_source): Likewise.
1170         * stack.c (_initialize_stack): Likewise.
1171         * symfile.c (_initialize_symfile): Likewise.
1172         * symtab.c (_initialize_symtab): Likewise.
1173         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1174         * top.c (init_main): Likewise.
1175         * tracefile-tfile.c (tfile_target_info): Likewise.
1176         * tracepoint.c (_initialize_tracepoint): Likewise.
1177         * tui/tui-win.c (_initialize_tui_win): Likewise.
1178         * utils.c (add_internal_problem_command): Likewise.
1179         * valprint.c (value_print_option_defs): Likewise.
1180
1181 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1182
1183         PR build/24886
1184         * configure.ac: Drop enable-libmcheck support.
1185         * configure, config.in: Rebuild.
1186         * libmcheck.m4: Remove.
1187         * acinclude.m4: Don't include it.
1188         * Makefile.in: Don't distribute it.
1189         * top.c (print_gdb_configuration): Don't mention it.
1190
1191 2019-08-06  Tom Tromey  <tom@tromey.com>
1192
1193         * utils.c (set_output_style): Sometimes pass stream to
1194         emit_style_escape.
1195         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1196         * record-btrace.c (btrace_insn_history): Update.
1197         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1198         method.
1199         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1200         Update initializers.
1201         <m_uiout>: New field.
1202         <m_di>: Move lower.
1203         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1204         Remove "uiout" parameter.
1205         (dump_insns): Update.
1206         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1207         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1208
1209 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1210
1211         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1212         (error_in_psymtab_expansion): Likewise.
1213         (lookup_symbol_via_quick_fns): Likewise.
1214         (basic_lookup_transparent_type_quick): Likewise.
1215         (basic_lookup_transparent_type_1): Likewise.
1216
1217 2019-08-06  Tom Tromey  <tromey@adacore.com>
1218
1219         * source.c (last_source_error): Now bool.
1220         (print_source_lines_base): Make "noprint" bool.  Only open
1221         source file when last_source_visited changes.
1222
1223 2019-08-06  Tom Tromey  <tromey@adacore.com>
1224
1225         * annotate.c (annotate_source_line): Use g_source_cache.
1226         * source-cache.c (source_cache::get_plain_source_lines): Change
1227         parameters.  Populate m_offset_cache.
1228         (source_cache::ensure): New method.
1229         (source_cache::get_line_charpos): New method.
1230         (extract_lines): Move lower.  Change parameters.
1231         (source_cache::get_source_lines): Move lower.
1232         * source-cache.h (class source_cache): Update comment.
1233         <get_line_charpos>: New method.
1234         <get_source_lines>: Update comment.
1235         <clear>: Clear m_offset_cache.
1236         <get_plain_source_lines>: Change parameters.
1237         <ensure>: New method
1238         <m_offset_cache>: New member.
1239         * source.c (forget_cached_source_info_for_objfile): Update.
1240         (info_source_command): Use g_source_cache.
1241         (find_source_lines, open_source_file_with_line_charpos): Remove.
1242         (print_source_lines_base, search_command_helper): Use g_source_cache.
1243         * source.h (open_source_file_with_line_charpos): Don't declare.
1244         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1245         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1246         Use g_source_cache.
1247
1248 2019-08-06  Tom Tromey  <tromey@adacore.com>
1249
1250         * source-cache.c (source_cache::get_plain_source_lines):
1251         Remove "first_line" and "last_line" parameters.
1252         (source_cache::get_source_lines): Cache plain text.
1253         * source-cache.h (class source_cache)
1254         <get_plain_source_lines>: Update.
1255
1256 2019-08-06  Tom Tromey  <tromey@adacore.com>
1257
1258         * source-cache.c (extract_lines): No longer a method.
1259         Changed type of parameter.  Include final newline.
1260         (selftests::extract_lines_test): New function.
1261         (_initialize_source_cache): Likewise.
1262         * source-cache.h (class source_cache)
1263         <extract_lines>: Don't declare.
1264
1265 2019-08-06  Tom Tromey  <tromey@adacore.com>
1266
1267         * breakpoint.c (init_breakpoint_sal): Update.
1268         (breakpoint): Update.
1269         * breakpoint.h (struct breakpoint) <filter>: Now a
1270         unique_xmalloc_ptr.
1271
1272 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1273
1274         * NEWS: Mention dictionary access on blocks.
1275         * python/py-block.c (blpy_getitem): New function.
1276         (block_object_as_mapping): New struct.
1277         (block_object_type): Use new struct for tp_as_mapping field.
1278
1279 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1280
1281         * objfiles.h (objfile): Add a comment describing partial symbols.
1282
1283 2019-08-05  Tom Tromey  <tromey@adacore.com>
1284
1285         * compile/compile.c (_initialize_compile): Use _(), not N_().
1286         * thread.c (_initialize_thread): Use _(), not N_().
1287         * stack.c (_initialize_stack): Use _(), not N_().
1288         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1289
1290 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1291
1292         * dwarf2read.c (struct dw2_symtab_iterator):
1293         <want_specific_block>: Remove.
1294         <block_index>: Change type to gdb::optional.
1295         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1296         change type of BLOCK_INDEX parameter to gdb::optional.
1297         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1298         (dw2_lookup_symbol): Don't pass argument for
1299         WANT_SPECIFIC_BLOCK.
1300         (dw2_expand_symtabs_for_function): Don't pass argument for
1301         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1302         (class dw2_debug_names_iterator)
1303         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1304         parameter, change BLOCK_INDEX type to gdb::optional.
1305         <m_want_specific_block>: Remove.
1306         <m_block_index>: Change type to gdb::optional.
1307         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1308         gdb::optional.  Re-write in function of gdb::optional.
1309         (dw2_debug_names_lookup_symbol): Don't pass argument for
1310         WANT_SPECIFIC_BLOCK.
1311         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1312         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1313         BLOCK_INDEX.
1314
1315 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1316
1317         * NEWS: Mention changes to "info sources" command.
1318
1319 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1320
1321         * symtab.c (filename_partial_match_opts): New struct type.
1322         (struct output_source_filename_data): New members
1323         regexp, c_regexp, partial_match.
1324         (output_source_filename): Use new members to decide to print file.
1325         (info_sources_option_defs): New variable.
1326         (make_info_sources_options_def_group, print_info_sources_header,
1327         info_sources_command_completer):
1328         New functions.
1329         (info_sources_command): Read new optional arguments.
1330         (_initialize_symtab): Update info sources help.
1331
1332 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1333
1334         * ada-lang.c (exception_support_info_v0): Renamed from...
1335         (default_exception_support_info): ... this.  Create new
1336         definition for v1.
1337         (ada_has_this_exception_support): Look up catch_handlers_sym.
1338         (ada_exception_support_info_sniffer): Try v0 after default.
1339
1340 2019-08-01  Tom Tromey  <tromey@adacore.com>
1341
1342         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1343         gdbarch.h.
1344
1345 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1346
1347         * s12z-tdep.c: Fix include path for s12z-opc.h.
1348
1349 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1350
1351         * NEWS: Require GNU make 3.82.
1352
1353 2019-07-16  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1356         declare.
1357
1358 2019-07-30  Tom Tromey  <tromey@adacore.com>
1359
1360         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1361
1362 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1363
1364         * printcmd.c (print_address_symbolic): Print negative offsets.
1365         (build_address_symbolic): Force signed arithmetic when computing
1366         offset.
1367
1368 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1369
1370         PR/24474: Add a function to lookup static variables.
1371         * NEWS: Mention this new function.
1372         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1373         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1374         * python/python.c (python_GdbMethods): Add new function.
1375
1376 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1377
1378         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1379         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1380         (objfpy_lookup_static_symbol): New function.
1381         (objfile_object_methods): Add new functions.
1382
1383 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1384
1385         * NEWS: Mention 'set|show print frame-info'.  Mention new
1386         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1387         backtrace argument.  Mention that python frame filtering code
1388         is now consistent with what 'backtrace' command prints.
1389
1390 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1391
1392         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1393         comments.
1394         (print_frame_info_auto, print_frame_info_source_line,
1395         print_frame_info_location, print_frame_info_source_and_location,
1396         print_frame_info_location_and_address, print_frame_info_short_location):
1397         New declarations.
1398         (struct frame_print_options): New member print_frame_info.
1399         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1400         * stack.h (get_user_print_what_frame_info): New declaration.
1401         (frame_show_address): New declaration.
1402         * stack.c (print_frame_arguments_choices): New value 'presence'.
1403         (print_frame_info_auto, print_frame_info_source_line,
1404         print_frame_info_location, print_frame_info_source_and_location,
1405         print_frame_info_location_and_address, print_frame_info_short_location,
1406         print_frame_info_choices, print_frame_info_print_what): New definitions.
1407         (print_frame_args): Only print dots for args if print frame-arguments
1408         is 'presence'.
1409         (frame_print_option_defs): New element for "frame-info".
1410         (get_user_print_what_frame_info): New function.
1411         (frame_show_address): Make non static.  Move comment to stack.h.
1412         (print_frame_info_to_print_what): New function.
1413         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1414         to decide what to print.
1415         (backtrace_command_1): Handle the new print_frame_arguments_presence
1416         value.
1417         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1418         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1419         (py_print_frame): In non-mi mode, use LOCATION as default for
1420         print_what, similarly to frame information printed directly by
1421         backtrace command. Handle frame-info user option in non MI mode.
1422
1423 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1424
1425         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1426         Add case for debugging 32-bit target on 64-bit host.  Revise
1427         comment.
1428
1429 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1430
1431         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1432         instead of find_function_entry_range_from_pc.
1433
1434 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1435
1436         * stack.c (find_frame_funname): Remove code which preferred
1437         minsym over symtab sym in "certain pathological cases".
1438
1439         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1440         parameter.  Change type of "do_demangle" to bool.
1441         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1442         Pass suitable "prefer_sym_over_minsym" flag to
1443         build_address_symbolic().  Don't output "+" for negative offsets.
1444         * printcmd.c (print_address_symbolic): Update invocation of
1445         build_address_symbolic to include a "prefer_sym_over_minsym"
1446         flag.
1447         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1448         Restrict cases in which use of minimal symbol is preferred to that
1449         of a found symbol.  Update comments.
1450
1451         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1452         for entry pc when entry pc is out of range for that FDE.
1453
1454 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1455
1456         PR gdb/24839:
1457         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1458         type.
1459
1460 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1461
1462         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1463         this function's Python signature.
1464
1465
1466 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1467
1468         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1469         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1470         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1471         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1472         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1473
1474
1475 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1476
1477         * h8300-tdep.c (h8300_register_name_common): New.
1478         h8300_register_name): Use h8300_register_name_common.
1479         (h8300s_register_name): Likewise.
1480         (h8300sx_register_name): Likewise.
1481         (h8300h_register_nam): New.
1482         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1483
1484
1485 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1486
1487         * arm-tdep.c (arm_skip_cmse_entry): New function.
1488         (arm_is_sgstubs_section): New function.
1489         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1490
1491 2019-07-22  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1494         Don't self-assign.
1495
1496 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1499         type_print.
1500
1501 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1504         so that GDB doesn't match any msymbols when searching in the
1505         TYPES_DOMAIN.
1506         (print_symbol_info): Print using typedef_print or type_print based
1507         on the type of the symbol.  Add updated FIXME comment moved from...
1508         (_initialize_symtab): ... move and update FIXME comment to above.
1509
1510 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1511
1512         * NEWS: Mention adding -q option to "info types".
1513         * symtab.c (struct info_types_options): New struct.
1514         (info_types_options_defs): New variable.
1515         (make_info_types_options_def_group): New function.
1516         (info_types_command): Use gdb::option framework to parse options.
1517         (info_types_command_completer): New function.
1518         (_initialize_symtab): Extend the help text on "info types" and
1519         register command completer.
1520
1521 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1522
1523         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1524         (lookup_symbol_in_objfile): Change int to block_enum and add a
1525         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1526
1527 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1528
1529         * MAINTAINERS (Write After Approval): Add self.
1530
1531 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1532
1533         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1534         instruction to the dummy code region.
1535
1536 2019-07-19  Tom Tromey  <tromey@adacore.com>
1537
1538         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1539         (ARGSUSED, PARAMS, __func__): Remove rules.
1540
1541 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1542
1543         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1544         * features/arm/arm-with-iwmmxt.c: Remove.
1545         * features/arm/arm-with-iwmmxt.xml: Remove.
1546         * features/arm/arm-with-m-fpa-layout.c: Remove.
1547         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1548         * features/arm/arm-with-m-vfp-d16.c: Remove.
1549         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1550         * features/arm/arm-with-m.c: Remove.
1551         * features/arm/arm-with-m.xml: Remove.
1552         * features/arm/arm-with-neon.c: Remove.
1553         * features/arm/arm-with-neon.xml: Remove.
1554         * features/arm/arm-with-vfpv2.c: Remove.
1555         * features/arm/arm-with-vfpv2.xml: Remove.
1556         * features/arm/arm-with-vfpv3.c: Remove.
1557         * features/arm/arm-with-vfpv3.xml: Remove.
1558
1559 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1560
1561         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1562
1563 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1564
1565         * arch/aarch32.c (aarch32_create_target_description): Create
1566         target descriptions using features.
1567         * arch/arm.c (arm_create_target_description)
1568         (arm_create_mprofile_target_description): Likewise.
1569         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1570
1571 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1572
1573         * Makefile.in: Add new files.
1574         * aarch32-tdep.c: New file.
1575         * aarch32-tdep.h: New file.
1576         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1577         Call aarch32_read_description.
1578         * arch/aarch32.c: New file.
1579         * arch/aarch32.h: New file.
1580         * arch/arm.c (arm_create_target_description)
1581         (arm_create_mprofile_target_description): New function.
1582         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1583         (arm_create_target_description)
1584         (arm_create_mprofile_target_description): New declaration.
1585         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1586         read_description functions.
1587         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1588         Likewise.
1589         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1590         * arm-tdep.c (tdesc_arm_list): New variable.
1591         (arm_register_g_packet_guesses): Call create description functions.
1592         (arm_read_description) (arm_read_mprofile_description): New
1593         function.
1594         * arm-tdep.h (arm_read_description)
1595         (arm_read_mprofile_description): Add declaration.
1596         * configure.tgt: Add new files.
1597
1598 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1599
1600         * top.c (new_ui_command): Open specified terminal just once.
1601
1602 2019-07-18  Tom Tromey  <tromey@adacore.com>
1603
1604         * symtab.c (main_name): Constify return type.
1605         * symfile.c (set_initial_language): Update.
1606         * symtab.h (main_name): Constify return type.
1607
1608 2019-07-17  Tom Tromey  <tom@tromey.com>
1609
1610         * tui/tui-winsource.c (tui_update_source_window)
1611         (tui_update_source_window_as_is)
1612         (tui_update_source_windows_with_line): Remove return.
1613         * tui/tui-disasm.c (tui_show_disassem)
1614         (tui_show_disassem_and_update_source): Remove return.
1615         * tui/tui.c (tui_reset): Remove return.
1616         * tui/tui-wingeneral.c
1617         (tui_check_and_display_highlight_if_needed): Remove return.
1618
1619 2019-07-17  Tom Tromey  <tom@tromey.com>
1620
1621         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1622
1623 2019-07-17  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-winsource.h (struct tui_exec_info_window)
1626         (struct tui_source_window_base): Move from tui-data.h.
1627         * tui/tui-winsource.c: Move many method definitions from
1628         elsewhere.  Remove "structuring" comments.
1629         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1630         (tui_source_window_base::refresh_window): Move to
1631         tui-winsource.c.
1632         * tui/tui-win.c (tui_source_window_base::refresh_all)
1633         (tui_source_window_base::update_tab_width)
1634         (tui_source_window_base::set_new_height)
1635         (tui_source_window_base::do_make_visible_with_new_height): Move to
1636         tui-winsource.c.
1637         * tui/tui-source.h: Update.
1638         * tui/tui-source.c (tui_source_window_base::reset): Move to
1639         tui-winsource.c.
1640         * tui/tui-disasm.h: Update.
1641         * tui/tui-data.h (struct tui_exec_info_window): Move to
1642         tui-winsource.h.
1643         (struct tui_source_window_base): Likewise.
1644         * tui/tui-data.c (tui_source_window_base::clear_detail)
1645         (tui_source_window_base, ~tui_source_window_base): Move to
1646         tui-winsource.c.
1647
1648 2019-07-17  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-win.c (tui_resize_all)
1651         (tui_source_window_base::update_tab_width)
1652         (tui_adjust_win_heights): Update.
1653         (tui_win_info::make_invisible_and_set_new_height): Rename from
1654         make_invisible_and_set_new_height.
1655         * tui/tui-data.h (struct tui_win_info)
1656         <make_invisible_and_set_new_height>: New method.
1657
1658 2019-07-17  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui.c: Update.
1661         * tui/tui-source.h (struct tui_source_window): Move from
1662         tui-data.h.
1663         * tui/tui-layout.c: Update.
1664         * tui/tui-disasm.c: Update.
1665         * tui/tui-data.h (struct tui_source_window): Move to
1666         tui-source.h.
1667
1668 2019-07-17  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1671         tui-data.h.
1672         * tui/tui-data.h (struct tui_disasm_window): Move to
1673         tui-disasm.h.
1674
1675 2019-07-17  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-regs.h (struct tui_data_item_window): Move from
1678         tui-data.h.
1679         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1680         * tui/tui-data.h (struct tui_data_item_window): Move to
1681         tui-regs.h.
1682         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1683
1684 2019-07-17  Tom Tromey  <tom@tromey.com>
1685
1686         * tui/tui.c: Update.
1687         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1688         (tui_cmd_window::max_height): Move to tui-command.c.
1689         * tui/tui-layout.c: Update.
1690         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1691         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1692         tui-command.c.
1693         * tui/tui-command.h (struct tui_cmd_window): Move from
1694         tui-data.h.
1695         * tui/tui-command.c: Remove "structuring" comments.
1696         (tui_cmd_window::clear_detail)
1697         (tui_cmd_window::do_make_visible_with_new_height)
1698         (tui_cmd_window::max_height): Move from elsewhere.
1699
1700 2019-07-17  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1703         Now static.
1704         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1705         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1706
1707 2019-07-17  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui.c: Update.
1710         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1711         tui-regs.c.
1712         * tui/tui-windata.h: Remove file.
1713         * tui/tui-windata.c: Remove file.
1714         * tui/tui-win.c (tui_data_window::set_new_height)
1715         (tui_data_window::do_make_visible_with_new_height): Move to
1716         tui-regs.c.
1717         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1718         * tui/tui-regs.c: Remove "structuring" comments.
1719         (tui_data_window::first_data_item_displayed)
1720         (tui_data_window::delete_data_content_windows)
1721         (tui_data_window::erase_data_content)
1722         (tui_data_window::display_all_data)
1723         (tui_data_window::refresh_all)
1724         (tui_data_window::do_scroll_vertical)
1725         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1726         (tui_data_window::do_make_visible_with_new_height)
1727         (tui_data_window::refresh_window): Move from elsewhere.
1728         (_initialize_tui_regs): Move to end of file.
1729         * tui/tui-layout.c: Update.
1730         * tui/tui-hooks.c: Update.
1731         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1732         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1733         tui-regs.c.
1734         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1735
1736 2019-07-17  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1739         seen.
1740
1741 2019-07-17  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-win.c (tui_source_window_base::set_new_height)
1744         (tui_source_window_base::do_make_visible_with_new_height): Use
1745         m_has_locator field directly.
1746         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1747         method.
1748         (struct tui_source_window_base) <has_locator>: Likewise.
1749
1750 2019-07-17  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1753         Don't declare.
1754         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1755         Remove.
1756         * tui/tui-win.c (tui_source_window_base::set_new_height)
1757         (tui_source_window_base::set_new_height)
1758         (make_invisible_and_set_new_height)
1759         (tui_source_window_base::do_make_visible_with_new_height)
1760         (tui_source_window_base::do_make_visible_with_new_height):
1761         Update.
1762         * tui/tui-layout.c (show_source_disasm_command, show_data)
1763         (show_source_or_disasm_and_command): Update.
1764         * tui/tui-layout.c (show_layout): Update.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-layout.c (make_data_window): Remove.
1769         (show_data): Unify creation and re-initialization cases.
1770
1771 2019-07-17  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-layout.c (make_source_window, make_disasm_window):
1774         Remove.
1775         (show_data): Unify creation and re-initialization cases.
1776
1777 2019-07-17  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-layout.c (make_command_window): Remove.
1780         (show_source_disasm_command, show_source_or_disasm_and_command):
1781         Unify creation and re-initialization cases.
1782
1783 2019-07-17  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1786         creation and re-initialization cases.
1787
1788 2019-07-17  Tom Tromey  <tom@tromey.com>
1789
1790         * tui/tui-regs.c (tui_get_register): Return void.
1791
1792 2019-07-17  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1795         Simplify.
1796
1797 2019-07-17  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1800         resetting.
1801
1802 2019-07-17  Tom Tromey  <tom@tromey.com>
1803
1804         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1805         * tui/tui-regs.c (tui_reg_layout): New function.
1806         (tui_show_registers, tui_reg_command): Use it.
1807         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1808         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1809         parameters.
1810         (tui_layout_command): Remove.
1811
1812 2019-07-17  Tom Tromey  <tom@tromey.com>
1813
1814         * tui/tui-layout.h (tui/tui-layout): Return void.
1815         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1816
1817 2019-07-17  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-layout.c (show_source_disasm_command, show_data):
1820         Update.
1821         (reset_locator): Remove.
1822         (show_source_or_disasm_and_command): Update.
1823
1824 2019-07-17  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-source.c (tui_source_window_base::reset): Remove
1827         win_type parameter.
1828         * tui/tui-layout.c (make_command_window, make_source_window)
1829         (make_disasm_window, make_data_window)
1830         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1831         (reset_locator, show_source_or_disasm_and_command): Update.
1832         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1833         win_type parameter.
1834         (struct tui_source_window_base) <reset>: Likewise.
1835
1836 2019-07-17  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-layout.c (show_source_disasm_command): Use
1839         reset_locator.
1840         (reset_locator): New function.
1841         (init_and_make_win): Remove.
1842         (show_source_or_disasm_and_command): Use reset_locator.
1843
1844 2019-07-17  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1847         condition.
1848         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1849         Remove condition.
1850         * tui/tui-source.c (tui_source_window_base::reset): New method.
1851         * tui/tui-layout.c (make_command_window): Don't call
1852         init_and_make_win.
1853         (make_source_window, make_disasm_window): Don't call
1854         make_source_or_disasm_window.
1855         (make_data_window): Don't call init_and_make_win.  Change calling
1856         convention.
1857         (show_source_disasm_command, show_data): Simplify.
1858         (make_source_or_disasm_window): Remove.
1859         (show_source_or_disasm_and_command): Simplify.
1860         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1861         (struct tui_source_window_base) <reset>: Likewise.
1862         <execution_info>: Remove initializer.
1863         * tui/tui-data.c (tui_source_window_base): Initialize
1864         execution_info.
1865
1866 2019-07-17  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1869         variable.
1870
1871 2019-07-17  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui.c (tui_rl_other_window): Update.
1874         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1875         superclass method first.  Always iterate over regs_content.
1876         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1877         method.
1878         * tui/tui-win.c (tui_set_focus_command): Update.
1879
1880 2019-07-17  Tom Tromey  <tom@tromey.com>
1881
1882         * tui/tui-win.c (tui_set_focus_command): Rename from
1883         tui_set_focus.  Call tui_enable.
1884         (tui_set_focus_command): Remove.
1885
1886 2019-07-17  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1889         refresh_window.
1890         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1891         touchwin.
1892         (tui_data_window::refresh_window): Call refresh_window on data
1893         items.  Always call superclass refresh_window.
1894         (tui_win_info::refresh): Remove.
1895         (tui_source_window_base::refresh_window): Update.
1896         (tui_refresh_all): Update.
1897         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1898         refresh_window.
1899         (show_source_or_disasm_and_command): Likewise.
1900         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1901         (struct tui_source_window_base) <refresh>: Likewise.
1902
1903 2019-07-17  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-winsource.c (tui_clear_source_content)
1906         (tui_show_source_content): Update.
1907         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1908         whether content is empty.
1909         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1910         Remove.
1911
1912 2019-07-17  Tom Tromey  <tom@tromey.com>
1913
1914         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1915         window's contents.
1916         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1917         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1918
1919 2019-07-17  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1922         (struct tui_data_item_window): Update.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1927         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1928         defines.
1929
1930 2019-07-17  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-winsource.h (tui_erase_source_content)
1933         (tui_clear_source_content): Remove "display_prompt" parameter.
1934         * tui/tui-winsource.c (tui_update_source_window_as_is)
1935         (tui_update_source_windows_with_addr): Update.
1936         (tui_clear_source_content): Remove "display_prompt" parameter.
1937         (tui_erase_source_content): Likewise.  Simplify.
1938         (tui_show_source_content): Update.
1939         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1940         * tui/tui-stack.c (tui_show_frame_info): Update.
1941         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1942         Remove defines.
1943
1944 2019-07-17  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1947         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1948         parameter.
1949         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1950         parameter.
1951
1952 2019-07-17  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-winsource.c (tui_clear_source_content)
1955         (tui_show_source_content, tui_show_exec_info_content)
1956         (tui_clear_exec_info_content): Update.
1957         * tui/tui-stack.c (tui_show_locator_content): Update.
1958         (tui_show_frame_info): Update.
1959         * tui/tui-source.h (tui_source_window): Don't declare.
1960         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1961         from tui_source_is_displayed.
1962         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1963         Remove field.
1964         (struct tui_source_window_base) <content_in_use>: New field.  Now
1965         bool.
1966         (struct tui_source_window) <showing_source_p>: New method.
1967         (TUI_SRC_WIN): Change cast.
1968         * tui/tui-data.c (tui_initialize_static_data): Update.
1969
1970 2019-07-17  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1973         location_matches_p.
1974         * tui/tui-source.c (tui_source_window::location_matches_p): New
1975         method.
1976         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1977         method.
1978         * tui/tui-data.h (struct tui_source_window_base)
1979         <location_matches_p>: New method.
1980         (struct tui_source_window, struct tui_disasm_window)
1981         <location_matches_p>: Likewise.
1982
1983 2019-07-17  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-win.c (tui_set_win_height_command): Rename from
1986         tui_set_win_height.
1987         (tui_set_win_height_command): Remove.
1988
1989 2019-07-17  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-source.c (tui_source_window): New constructor.  Add
1992         observer.
1993         (~tui_source_window): New destructor.
1994         (tui_source_window::style_changed): New method.
1995         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1996         (tui_attach_detach_observers): Update.
1997         * tui/tui-data.h (struct tui_source_window): Make constructor not
1998         inline.  Add destructor.
1999         (struct tui_source_window) <style_changed>: New method.
2000         <m_observable>: New member.
2001
2002 2019-07-17  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2005         * tui/tui-win.c (tui_resize_all): Fix typo.
2006
2007 2019-07-17  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2010         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2011         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2012         * tui/tui-win.c (window_name_completer): Use foreach.
2013         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2014         (update_tab_width): Likewise.
2015         * tui/tui-layout.c (show_layout): Update.
2016         * tui/tui-data.h (class tui_window_iterator): New.
2017         (struct all_tui_windows): New.
2018         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2019
2020 2019-07-17  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2023         parameter.  Don't reference globals.
2024         (tui_reg_command): Update.
2025
2026 2019-07-17  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-regs.c (tui_show_registers): Simplify.
2029
2030 2019-07-17  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-regs.c (tui_show_registers): Update.
2033         (tui_show_register_group): Add win_info parameter.
2034
2035 2019-07-17  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2038         Rename from tui_display_reg_element_at_line.
2039         (tui_data_window::display_registers_from_line): Update.
2040         * tui/tui-data.h (struct tui_data_window)
2041         <display_reg_element_at_line>: New method.
2042
2043 2019-07-17  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-regs.h (tui_display_registers_from)
2046         (tui_display_registers_from_line): Don't declare.
2047         * tui/tui-windata.c (tui_data_window::display_all_data)
2048         (tui_data_window::refresh_all)
2049         (tui_data_window::do_scroll_vertical): Update.
2050         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2051         from tui_display_registers_from.
2052         (tui_display_reg_element_at_line): Update.
2053         (tui_data_window::display_registers_from_line): Rename from
2054         tui_display_registers_from_line.
2055         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2056         display_registers_from_line>: New methods.
2057
2058 2019-07-17  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2061         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2062         from tui_erase_data_content.
2063         (tui_data_window::display_all_data)
2064         (tui_data_window::refresh_all)
2065         (tui_data_window::do_scroll_vertical): Update.
2066         * tui/tui-regs.c (tui_show_registers): Update.
2067         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2068         New method.
2069
2070 2019-07-17  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2073         declare.
2074         * tui/tui-windata.c
2075         (tui_data_window::delete_data_content_windows): Rename from
2076         tui_delete_data_content_windows.
2077         (tui_data_window::display_all_data)
2078         (tui_data_window::do_scroll_vertical): Update.
2079         * tui/tui-data.h (struct tui_data_window)
2080         <delete_data_content_windows>: New method.
2081
2082 2019-07-17  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2085         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2086
2087 2019-07-17  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2090         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2091         from tui_display_all_data.
2092         * tui/tui-win.c
2093         (tui_data_window::do_make_visible_with_new_height): Update.
2094         * tui/tui-regs.c (tui_show_registers): Update.
2095         * tui/tui-layout.c (tui_set_layout): Update.
2096         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2097         method.
2098
2099 2019-07-17  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2102         * tui/tui-windata.c (tui_display_data_from): Remove.
2103         (tui_data_window::refresh_all): Update.
2104
2105 2019-07-17  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2108         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2109         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2110         tui_display_registers_from_line.
2111         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2112         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2113         "force_display" parameter.
2114
2115 2019-07-17  Tom Tromey  <tom@tromey.com>
2116
2117         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2118         declare.
2119         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2120         Rename from tui_first_reg_element_no_inline.
2121         (tui_display_reg_element_at_line)
2122         (tui_display_registers_from_line): Update.
2123         * tui/tui-data.h (struct tui_data_window)
2124         <first_reg_element_no_inline>: New method.
2125
2126 2019-07-17  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-windata.c (tui_display_data_from)
2129         (tui_data_window::do_scroll_vertical): Update.
2130         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2131         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2132         Rename from tui_line_from_reg_element_no.
2133         (tui_display_registers_from_line): Update.
2134         * tui/tui-data.h (struct tui_data_window)
2135         <line_from_reg_element_no>: New method.
2136
2137 2019-07-17  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2140         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2141         tui_last_regs_line_no.
2142         (tui_display_reg_element_at_line)
2143         (tui_display_registers_from_line): Update.
2144         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2145         method.
2146
2147 2019-07-17  Tom Tromey  <tom@tromey.com>
2148
2149         PR tui/24722:
2150         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2151         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2152         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2153         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2154         (tui_update_breakpoint_info): Likewise.
2155         * tui/tui-hooks.c (tui_event_create_breakpoint)
2156         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2157         Update.
2158
2159 2019-07-17  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2162
2163 2019-07-17  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-winsource.c (tui_update_source_window_as_is)
2166         (tui_update_source_windows_with_addr): Update.
2167         * tui/tui-source.h (tui_set_source_content)
2168         (tui_show_symtab_source): Add "win_info" parameter.
2169         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2170         parameter.
2171         (tui_show_symtab_source): Likewise.
2172
2173 2019-07-17  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-wingeneral.c
2176         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2177
2178 2019-07-17  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2181         (struct tui_cmd_window) <can_scroll>: New method.
2182         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2183         method.
2184
2185 2019-07-17  Tom Tromey  <tromey@adacore.com>
2186
2187         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2188         do_field_signed>: Rename.  Change type of "value".
2189         * ui-out.c (ui_out::field_signed): Rename from field_int.
2190         Change type of "value".
2191         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2192         type of "value".
2193         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2194         do_field_int.  Change type of "value".
2195         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2196         do_field_int.  Change type of "value".
2197         * tracepoint.c (trace_status_mi, tfind_1)
2198         (print_one_static_tracepoint_marker): Update.
2199         * thread.c (print_thread_info_1, print_selected_thread_frame):
2200         Update.
2201         * stack.c (print_frame, print_frame_info): Update.
2202         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2203         Update.
2204         * source.c (print_source_lines_base): Update.
2205         * skip.c (info_skip_command): Update.
2206         * record-btrace.c (btrace_ui_out_decode_error)
2207         (btrace_call_history_src_line): Update.
2208         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2209         Update.
2210         * progspace.c (print_program_space): Update.
2211         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2212         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2213         do_field_int.  Change type of "value".
2214         * mi/mi-out.c (mi_ui_out::do_table_begin)
2215         (mi_ui_out::do_table_header): Update.
2216         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2217         type of "value".
2218         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2219         (mi_cmd_data_list_changed_registers, output_register)
2220         (mi_cmd_data_read_memory, mi_load_progress)
2221         (mi_cmd_trace_frame_collected): Update.
2222         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2223         Update.
2224         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2225         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2226         (mi_cmd_var_list_children, varobj_update_one): Update.
2227         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2228         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2229         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2230         * inferior.c (print_inferior): Update.
2231         * gdb_bfd.c (print_one_bfd): Update.
2232         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2233         Update.
2234         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2235         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2236         do_field_int.  Change type of "value".
2237         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2238         do_field_int.  Change type of "value".
2239         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2240         (print_one_breakpoint_location, print_it_catch_fork)
2241         (print_one_catch_fork, print_it_catch_vfork)
2242         (print_one_catch_vfork, print_it_catch_solib)
2243         (print_it_catch_exec, print_it_ranged_breakpoint)
2244         (print_mention_watchpoint, print_mention_masked_watchpoint)
2245         (bkpt_print_it, update_static_tracepoint): Update.
2246         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2247         * break-catch-syscall.c (print_it_catch_syscall): Update.
2248         * ada-tasks.c (print_ada_task_info): Update.
2249         * ada-lang.c (print_it_exception, print_mention_exception):
2250         Update.
2251
2252 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2253
2254         PR breakpoints/24541
2255         * gdbarch.c: Regenerate.
2256         * gdbarch.h: Regenerate.
2257         * gdbarch.sh: Adjust return type and parameter types for
2258         'stap_adjust_register'.
2259         (i386_stap_adjust_register): Adjust signature and return new
2260         register name.
2261         * stap-probe.c (stap_parse_register_operand): Adjust use of
2262         'gdbarch_stap_adjust_register'.
2263
2264 2019-07-17  Tom Tromey  <tromey@adacore.com>
2265
2266         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2267         declare VEC.
2268         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2269         std::vector.
2270         (struct s390_process_info): Add initializers.
2271         (s390_add_process): Use new.
2272         (s390_linux_nat_target::low_forget_process): Use delete.
2273         (s390_linux_nat_target::low_new_fork)
2274         (s390_linux_nat_target::stopped_by_watchpoint)
2275         (s390_linux_nat_target::low_prepare_to_resume)
2276         (s390_linux_nat_target::insert_watchpoint)
2277         (s390_linux_nat_target::insert_hw_breakpoint)
2278         (s390_linux_nat_target::remove_watchpoint)
2279         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2280
2281 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2282
2283         * aarch64-fbsd-nat.c: Include regcache.h.
2284         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2285         argument.
2286         (aarch64_fbsd_nat_target::fetch_registers)
2287         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2288         variable.
2289         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2290
2291 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2292
2293         * fbsd-nat.c: Include gdbarch.h.
2294
2295 2019-07-15  Tom Tromey  <tromey@adacore.com>
2296
2297         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2298
2299 2019-07-15  Tom Tromey  <tromey@adacore.com>
2300
2301         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2302         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2303         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2304         * cli-out.c (cli_ui_out::do_field_int): New method.
2305         * ui-out.c (ui_out::field_unsigned): New method.
2306         * symfile.c (generic_load): Use field_unsigned.
2307         (print_transfer_performance): Likewise.
2308         * record-btrace.c (ui_out_field_uint): Remove.
2309         (btrace_call_history_insn_range, btrace_call_history): Use
2310         field_unsigned.
2311         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2312         field_unsigned.
2313         * ui-out.h (class ui_out) <field_unsigned>: New method.
2314         <do_field_unsigned>: Likewise.
2315
2316 2019-07-15  Tom Tromey  <tromey@adacore.com>
2317
2318         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2319         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2320         * target.c (flash_erase_command): Use field_string.
2321         * infrun.c (print_signal_received_reason): Use field_string.
2322         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2323         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2324         field_string.
2325         * ada-tasks.c (print_ada_task_info): Use field_string.
2326
2327 2019-07-15  Tom Tromey  <tromey@adacore.com>
2328
2329         * target.c (flash_erase_command): Use field_core_addr.
2330         * symfile.c (generic_load): Use field_core_addr.
2331         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2332         Use field_core_addr.
2333         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2334         field_core_addr.
2335
2336 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2337
2338         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2339         value if its desired type is smaller than a CORE_ADDR and signed.
2340
2341 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2342
2343         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2344         of changes to field names, and use new is_reference field to
2345         decide if a property is a reference or not.
2346         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2347         field.
2348         (struct dwarf2_property_baton): Update header comment, rename
2349         'referenced_type' to 'property_type' and update comments.
2350         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2351         default property type, store in property baton, update to take
2352         accound of renamed field.
2353         (read_func_scope): Update call to attr_to_dynamic_prop.
2354         (read_array_type): Likewise.
2355         (dwarf2_per_cu_addr_sized_int_type): New function.
2356         (read_subrange_index_type): Move type finding code to
2357         dwarf2_per_cu_addr_sized_int_type.
2358         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2359         (dwarf2_per_cu_addr_type): New function.
2360         (set_die_type): Update calls to attr_to_dynamic_prop.
2361
2362 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * dwarf2read.c (read_subrange_index_type): New function.
2365         (read_subrange_type): Move code into new function and call it.
2366         * gdbtypes.c (create_range_type): Add some asserts.
2367
2368 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2369
2370         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2371         update return statements.
2372         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2373         declaration, and update comment to match.
2374         * gdbtypes.c (resolve_dynamic_array): Update call to
2375         dwarf2_evaluate_property to match new return type.
2376
2377 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2378
2379         * valarith.c (value_subscripted_rvalue): Change lowerbound
2380         parameter type from int to LONGEST.
2381         * value.h (value_subscripted_rvalue): Likewise in declaration.
2382
2383 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2384
2385         * cli/cli-utils.c (info_print_command_completer): New function.
2386         * cli/cli-utils.h: Add 'completer.h' include, and forward
2387         declaration for 'struct cmd_list_element'.
2388         (info_print_command_completer): Declare.
2389         * stack.c (_initialize_stack): Add completer for 'info locals' and
2390         'info args'.
2391         * symtab.c (_initialize_symtab): Add completer for 'info
2392         variables' and 'info functions'.
2393         * NEWS: Mention completion for additional info commands.
2394
2395 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * cli/cli-utils.c (extract_info_print_args): Delete.
2398         (extract_arg_maybe_quoted): Delete.
2399         (info_print_options_defs): New variable.
2400         (make_info_print_options_def_group): New function.
2401         (extract_info_print_options): Define new function.
2402         * cli/cli-utils.h (extract_info_print_args): Delete.
2403         (struct info_print_options): New structure.
2404         (extract_info_print_options): Declare new function.
2405         * stack.c (info_locals_command): Update to use new
2406         extract_info_print_options, also add a header comment.
2407         (info_args_command): Likewise.
2408         * symtab.c (info_variables_command): Likewise.
2409         (info_functions_command): Likewise.
2410
2411 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2412
2413         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2414         to extract string arguments.
2415         * common/common-utils.c (extract_string_maybe_quoted): New function.
2416         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2417
2418 2019-07-11  Tom Tromey  <tromey@adacore.com>
2419
2420         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2421         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2422         * top.h (gdbinit): Don't declare.
2423         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2424         into...
2425         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2426         * top.c (gdb_init): Don't call init_cli_cmds.
2427         (gdbinit): Remove.
2428         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2429
2430 2019-07-11  Tom Tromey  <tromey@adacore.com>
2431
2432         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2433         after it has been moved.
2434
2435 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2436
2437         * valops.c (value_must_coerce_to_target): Change return type to
2438         bool.
2439         * value.h (value_must_coerce_to_target): Likewise.
2440
2441 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2442
2443         * breakpoint.c (is_hardware_watchpoint): Remove
2444         forward-declaration.
2445         (is_masked_watchpoint): Change return type to bool.
2446         (is_tracepoint): Likewise.
2447         (is_breakpoint): Likewise.
2448         (is_hardware_watchpoint): Likewise.
2449         (is_watchpoint): Likewise.
2450         (is_no_memory_software_watchpoint): Likewise.
2451         (is_catchpoint): Likewise.
2452         (breakpoint_1): Make FILTER parameter's return type bool.
2453         is_masked_watchpoint): Change return type to bool.
2454         (save_breakpoints): Make FILTER parameter's return type bool.
2455         * breakpoint.h (is_breakpoint): Change return type to bool.
2456         (is_watchpoint): Likewise.
2457         (is_catchpoint): Likewise.
2458         (is_tracepoint): Likewise.
2459
2460 2019-07-10  Tom Tromey  <tom@tromey.com>
2461
2462         * defs.h: Don't include gdbarch.h.
2463         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2464         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2465         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2466         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2467         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2468         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2469         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2470         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2471         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2472         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2473         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2474         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2475         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2476         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2477         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2478         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2479         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2480         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2481         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2482         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2483         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2484         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2485         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2486         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2487         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2488         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2489         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2490
2491 2019-07-10  Tom Tromey  <tromey@adacore.com>
2492
2493         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2494         * breakpoint.c (init_ada_exception_breakpoint): Register as
2495         bp_catchpoint.
2496         (print_one_breakpoint_location, print_one_breakpoint): Use
2497         is_ada_exception_catchpoint.
2498         * ada-lang.c (class ada_catchpoint_location): Pass
2499         bp_loc_software_breakpoint to bp_location constructor.
2500         (is_ada_exception_catchpoint): New function.
2501
2502 2019-07-10  Tom Tromey  <tromey@adacore.com>
2503
2504         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2505         VEC.
2506         (struct arm_exidx_entry): New method operator<.
2507         (struct arm_exidx_data) <section_maps>: Change type.
2508         (arm_exidx_data_free): Remove.
2509         (arm_exidx_data_key): Change type.  Move lower.
2510         (arm_exidx_new_objfile): Update.
2511         (arm_compare_exidx_entries): Remove.
2512         (arm_find_exidx_entry, _initialize_arm_tdep)
2513
2514 2019-07-10  Tom Tromey  <tromey@adacore.com>
2515
2516         * solib-spu.c (ocl_program_data_key): Change type.
2517         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2518         Update.
2519
2520 2019-07-10  Tom Tromey  <tromey@adacore.com>
2521
2522         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2523         (struct solib_aix_inferior_data) <library_list>: Change type.
2524         (solib_aix_inferior_data_handle): Change type.
2525         (get_solib_aix_inferior_data): Update.
2526         (solib_aix_free_library_list): Remove.
2527         (library_list_start_library): Update.
2528         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2529         return type.
2530         (solib_aix_get_library_list)
2531         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2532         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2533
2534 2019-07-10  Tom Tromey  <tromey@adacore.com>
2535
2536         * solib-dsbt.c (struct dsbt_info): Add initializers.
2537         (solib_dsbt_pspace_data): Change type.
2538         (dsbt_pspace_data_cleanup): Remove.
2539         (get_dsbt_info, _initialize_dsbt_solib): Update.
2540
2541 2019-07-10  Tom Tromey  <tromey@adacore.com>
2542
2543         * spu-tdep.c (spu_overlay_data): Change type.
2544         (spu_get_overlay_table, spu_overlay_new_objfile)
2545         (_initialize_spu_tdep): Update.
2546
2547 2019-07-10  Tom Tromey  <tromey@adacore.com>
2548
2549         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2550         destructor.
2551         (dbx_objfile_data_key): Change type and declare later.
2552         (DBX_SYMFILE_INFO): Rewrite.
2553         * dbxread.c (dbx_objfile_data_key): Change type.
2554         (dbx_symfile_init): Update.
2555         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2556         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2557         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2558
2559 2019-07-10  Tom Tromey  <tromey@adacore.com>
2560
2561         * jit.c (jit_program_space_key): Change type.  Move lower.
2562         (get_jit_program_space_data): Update.
2563         (jit_program_space_data_cleanup): Remove.
2564         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2565         Update.
2566         (struct jit_program_space_data): Add initializers.
2567
2568 2019-07-10  Tom Tromey  <tromey@adacore.com>
2569
2570         * solib-darwin.c (struct darwin_info): Add initializers.
2571         (solib_darwin_pspace_data): Change type.
2572         (darwin_pspace_data_cleanup): Remove.
2573         (get_darwin_info, _initialize_darwin_solib): Update.
2574
2575 2019-07-10  Tom Tromey  <tromey@adacore.com>
2576
2577         * remote-sim.c (struct sim_inferior_data): Add initializers,
2578         constructor, and destructor.
2579         (sim_inferior_data_key): Change type.  Move lower.
2580         (check_for_duplicate_sim_descriptor): Update.
2581         (get_sim_inferior_data): Use new.  Update.
2582         (~sim_inferior_data_cleanup): Rename from
2583         sim_inferior_data_cleanup.  Simplify.
2584         (gdbsim_close_inferior, simulator_command)
2585         (sim_command_completer, _initialize_remote_sim): Update.
2586         (next_pid, INITIAL_PID): Move earlier.
2587
2588 2019-07-10  Tom Tromey  <tromey@adacore.com>
2589
2590         * python/python-internal.h (create_thread_object): Return
2591         gdbpy_ref.
2592         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2593         * python/py-inferior.c (struct threadlist_entry): Add
2594         constructor.
2595         <thread_obj>: Now a gdbpy_ref.
2596         (thread_to_thread_object): Update.
2597         (add_thread_object): Use new.
2598         (delete_thread_object): Use delete.
2599         (infpy_threads): Update.
2600         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2601         GIL.
2602
2603 2019-07-10  Tom Tromey  <tromey@adacore.com>
2604
2605         * valops.c (value_cast): Specialize error message for Ada.
2606
2607 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2608
2609         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2610
2611 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2612
2613         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2614         bpstat_should_step): Return bool, adjust comments.
2615         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2616         bpstat_should_step): Likewise.
2617
2618 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2619
2620         * features/Makefile: Use feature target descriptions for Arm.
2621         * features/arm/arm-core.c: Generate new file.
2622         * features/arm/arm-fpa.c: Likewise.
2623         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2624         * features/arm/arm-m-profile.c: Likewise.
2625         * features/arm/arm-vfpv2.c: Likewise.
2626         * features/arm/arm-vfpv3.c: Likewise.
2627         * features/arm/xscale-iwmmxt.c: Likewise.
2628         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2629
2630 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2631
2632         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2633         ptrace earlier.
2634
2635 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2636
2637         * features/aarch64-pauth.c: Regenerate.
2638
2639 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2640
2641         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2642         bool.
2643         (bpstat_what): Use false instead of 0.
2644
2645 2019-07-09  Pedro Alves  <palves@redhat.com>
2646
2647         * break-catch-throw.c (is_exception_catchpoint): New.
2648         * breakpoint.c (print_one_breakpoint_location): New parameter
2649         'raw_loc'.  Handle it.  Use
2650         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2651         looking at the breakpoint's type.
2652         (print_one_breakpoint): If handling "maint info breakpoints", also
2653         print locations of exception catchpoints.
2654         * breakpoint.h (is_exception_catchpoint): Declare.
2655
2656 2019-07-09  Pedro Alves  <palves@redhat.com>
2657
2658         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2659         "addr" field.
2660         (allocate_location_exception_catchpoint): New.
2661         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2662         (initialize_throw_catchpoint_ops): Install
2663         allocate_location_exception_catchpoint as allocate_location
2664         method.
2665         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2666         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2667         bp_loc_other.
2668         (breakpoint_address_is_meaningful): Delete.
2669         (bl_address_is_meaningful): New.
2670         (breakpoint_locations_match): Adjust comment.
2671         (bp_location_from_bp_type): New, factored out of...
2672         (bp_location::bp_location(breakpoint *)): ... this.
2673         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2674         factored out of...
2675         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2676         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2677         breakpoint_address_is_meaningful.
2678         (bp_locations_compare): Adjust comment.
2679         (update_global_location_list): Use bl_address_is_meaningful
2680         instead of breakpoint_address_is_meaningful.
2681         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2682         explicit.
2683         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2684         * python/py-breakpoint.c (bppy_get_location): No longer check
2685         whether location is null.
2686
2687 2019-07-09  Pedro Alves  <palves@redhat.com>
2688
2689         PR c++/15468
2690         * breakpoint.c (print_one_breakpoint_location): Remove
2691         single-location assert.
2692
2693 2019-07-09  Tom Tromey  <tom@tromey.com>
2694
2695         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2696         * configure: Rebuild.
2697         * configure.ac: Change common to gdbsupport.
2698         * gdbsupport: Rename from common.
2699         * acinclude.m4: Change common to gdbsupport.
2700         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2701         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2702         gdbsupport.
2703         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2704         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2705         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2706         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2707         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2708         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2709         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2710         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2711         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2712         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2713         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2714         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2715         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2716         coff-pe-read.c, command.h, compile/compile-c-support.c,
2717         compile/compile-c.h, compile/compile-cplus-symbols.c,
2718         compile/compile-cplus-types.c, compile/compile-cplus.h,
2719         compile/compile-loc2c.c, compile/compile.c, completer.c,
2720         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2721         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2722         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2723         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2724         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2725         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2726         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2727         features/aarch64-core.c, features/aarch64-fpu.c,
2728         features/aarch64-pauth.c, features/aarch64-sve.c,
2729         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2730         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2731         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2732         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2733         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2734         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2735         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2736         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2737         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2738         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2739         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2740         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2741         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2742         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2743         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2744         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2745         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2746         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2747         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2748         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2749         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2750         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2751         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2752         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2753         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2754         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2755         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2756         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2757         minsyms.c, mips-linux-tdep.c, namespace.h,
2758         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2759         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2760         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2761         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2762         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2763         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2764         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2765         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2766         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2767         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2768         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2769         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2770         procfs.c, producer.c, progspace.h, psymtab.h,
2771         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2772         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2773         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2774         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2775         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2776         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2777         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2778         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2779         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2780         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2781         target-memory.c, target.c, target.h, target/waitstatus.c,
2782         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2783         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2784         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2785         unittests/array-view-selftests.c,
2786         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2787         unittests/common-utils-selftests.c,
2788         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2789         unittests/format_pieces-selftests.c,
2790         unittests/function-view-selftests.c,
2791         unittests/lookup_name_info-selftests.c,
2792         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2793         unittests/mkdir-recursive-selftests.c,
2794         unittests/observable-selftests.c,
2795         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2796         unittests/parse-connection-spec-selftests.c,
2797         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2798         unittests/scoped_fd-selftests.c,
2799         unittests/scoped_mmap-selftests.c,
2800         unittests/scoped_restore-selftests.c,
2801         unittests/string_view-selftests.c, unittests/style-selftests.c,
2802         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2803         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2804         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2805         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2806         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2807         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2808
2809 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2810
2811         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2812         bool value.
2813         (decode_digits_ordinary): Set explicit_line field in sal.
2814         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2815         symtab_and_line that was set on an explicit line number in
2816         assembler code.  Do always update the recorded symtab and line if
2817         we do skip the prologue.
2818
2819 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2820
2821         * breakpoint.c (set_breakpoint_location_function): Remove
2822         explicit_loc parameter.
2823         (momentary_breakpoint_from_master): Update call to
2824         set_breakpoint_location_function.
2825         (add_location_to_breakpoint): Likewise.
2826
2827 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2828
2829         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2830         required features based on default bfd type when no specific bfd
2831         is present.
2832
2833 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2834
2835         * NEWS: Mention that GDB printf and eval commands can now print
2836         C-style and Ada-style convenience var strings without
2837         calling the inferior.
2838         * printcmd.c (printf_c_string): Locally print GDB internal var
2839         instead of transiting via the inferior.
2840         (printf_wide_c_string): Likewise.
2841
2842 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2843
2844         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2845
2846 2019-07-04  Tom Tromey  <tom@tromey.com>
2847
2848         PR tui/24724:
2849         * tui/tui-winsource.c (tui_clear_source_content): Update.
2850         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2851         (tui_update_breakpoint_info): Update.
2852         (tui_set_exec_info_content): Update.
2853         * tui/tui-source.c (tui_set_source_content_nil): Update.
2854         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2855         has_break.
2856         * tui/tui-data.h (enum tui_bp_flag): New.
2857         (tui_bp_flags): New enum flags type.
2858         (struct tui_source_element) <break_mode>: Change type.  Rename
2859         from has_break.
2860         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2861         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2862         constants.
2863         * tui/tui-winsource.h: Fix comment.
2864
2865 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2866
2867         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2868         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2869         (store_fpregs_to_thread)
2870         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2871         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2872         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2873         (IWMMXT_REGS_SIZE): Add define.
2874         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2875         (fetch_vfp_regs, store_vfp_regs)
2876         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2877         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2878
2879 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2880
2881         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2882         defines.
2883         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2884         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2885         (ARM_INT_REGISTER_SIZE): ...to this.
2886         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2887         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2888         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2889         (arm_linux_collect_gregset, supply_nwfpe_register)
2890         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2891         defines.
2892         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2893         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2894         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2895         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2896         (arm_return_in_memory, arm_store_return_value)
2897         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2898         (arm_record_ld_st_multiple): Likewise.
2899         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2900         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2901
2902 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2903
2904         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2905         AARCH64_DISPLACED_MODIFIED_INSNS.
2906         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2907         (aarch64_displaced_step_copy_insn): Likewise.
2908         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2909         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2910         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2911         ARM_DISPLACED_MODIFIED_INSNS.
2912         * arm-tdep.c (arm_gdbarch_init): Likewise.
2913         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2914         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2915         (struct arm_displaced_step_closure): Use
2916         ARM_DISPLACED_MODIFIED_INSNS.
2917
2918 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2919
2920         * features/Makefile: Remove unused xml files.
2921         * features/aarch64.xml: Remove.
2922         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2923         * features/i386/amd64-avx-avx512.xml: Remove.
2924         * features/i386/amd64-avx-linux.xml: Remove.
2925         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2926         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2927         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2928         * features/i386/amd64-avx-mpx.xml: Remove.
2929         * features/i386/amd64-avx.xml: Remove.
2930         * features/i386/amd64-linux.xml: Remove.
2931         * features/i386/amd64-mpx-linux.xml: Remove.
2932         * features/i386/amd64-mpx.xml: Remove.
2933         * features/i386/amd64.xml: Remove.
2934         * features/i386/i386-avx-avx512-linux.xml: Remove.
2935         * features/i386/i386-avx-avx512.xml: Remove.
2936         * features/i386/i386-avx-linux.xml: Remove.
2937         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2938         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2939         * features/i386/i386-avx-mpx-linux.xml: Remove.
2940         * features/i386/i386-avx-mpx.xml: Remove.
2941         * features/i386/i386-avx.xml: Remove.
2942         * features/i386/i386-linux.xml: Remove.
2943         * features/i386/i386-mmx-linux.xml: Remove.
2944         * features/i386/i386-mmx.xml: Remove.
2945         * features/i386/i386-mpx-linux.xml: Remove.
2946         * features/i386/i386-mpx.xml: Remove.
2947         * features/i386/i386.xml: Remove.
2948         * features/i386/x32-avx-avx512-linux.xml: Remove.
2949         * features/i386/x32-avx-linux.xml: Remove.
2950         * features/i386/x32-linux.xml: Remove.
2951
2952 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2953
2954         * regformats/aarch64.dat: Remove.
2955         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2956         * regformats/i386/amd64-avx-linux.dat: Remove.
2957         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2958         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2959         * regformats/i386/amd64-linux.dat: Remove.
2960         * regformats/i386/amd64-mpx-linux.dat: Remove.
2961         * regformats/i386/amd64.dat: Remove.
2962         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2963         * regformats/i386/i386-avx-linux.dat: Remove.
2964         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2965         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2966         * regformats/i386/i386-linux.dat: Remove.
2967         * regformats/i386/i386-mmx-linux.dat: Remove.
2968         * regformats/i386/i386-mpx-linux.dat: Remove.
2969         * regformats/i386/i386.dat: Remove.
2970         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2971         * regformats/i386/x32-avx-linux.dat: Remove.
2972         * regformats/i386/x32-linux.dat: Remove.
2973
2974 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2975
2976         * aarch64-tdep.c: Remove xml self tests.
2977         * amd64-linux-tdep.c: Likewise.
2978         * amd64-tdep.c: Likewise.
2979         * i386-linux-tdep.c: Likewise.
2980         * i386-tdep.c: Likewise.
2981
2982 2019-07-03  Pedro Alves  <palves@redhat.com>
2983
2984         PR cli/24732
2985         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2986         (pipe_cmd_option_defs): New.
2987         (make_pipe_cmd_options_def_group): New.
2988         (pipe_command): Use gdb::option::process_options.
2989         (pipe_command_completer): New function.
2990         (_initialize_cli_cmds): Install completer for "pipe" command.
2991
2992 2019-07-03  Pedro Alves  <palves@redhat.com>
2993
2994         * cli/cli-option.c (union option_value) <string>: New field.
2995         (struct option_def_and_value): Add ctor, move ctor, dtor and
2996         use DISABLE_COPY_AND_ASSIGN.
2997         (option_def_and_value::clear_value): New.
2998         (parse_option, save_option_value_in_ctx, get_val_type_str)
2999         (add_setshow_cmds_for_options): Handle var_string.
3000         * cli-option.h (union option_def::var_address) <string>: New
3001         field.
3002         (struct string_option_def): New.
3003         * maint-test-options.c (struct test_options_opts): Add default
3004         ctor and use DISABLE_COPY_AND_ASSIGN.
3005         <string_opt>: New field.
3006         (test_options_opts::~test_options_opts): New.
3007         (test_options_opts::dump): Also dump "-string".
3008         (test_options_option_defs): Install "string.
3009
3010 2019-07-03  Pedro Alves  <palves@redhat.com>
3011
3012         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3013         option_value with a null enumeration.
3014         (complete_options): Save the option values in the context.
3015         (save_option_value_in_ctx): New, factored out from ...
3016         (process_options): ... here.
3017         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3018         of the function.
3019         * maint-test-options.c (test_options_opts::dump): New, factored
3020         out from ...
3021         (maintenance_test_options_command_mode): ... here.
3022         (maintenance_test_options_command_completion_result): Delete.
3023         (maintenance_test_options_command_completion_text): Update
3024         comment.
3025         (maintenance_show_test_options_completion_result): Change
3026         prototype.  Just print
3027         maintenance_test_options_command_completion_text.
3028         (save_completion_result): New.
3029         (maintenance_test_options_completer_mode): Pass options context to
3030         complete_options, and then save a dump.
3031         (_initialize_maint_test_options): Use add_cmd to install "maint
3032         show test-options-completion-result".
3033
3034 2019-07-03  Pedro Alves  <palves@redhat.com>
3035
3036         * NEWS (New commands): Mention "with" and "maint with".
3037         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3038         (with_command, with_command_completer): New.
3039         (pipe_command): Adjust to new repeat_previous
3040         interface.
3041         (_initialize_cli_cmds): Install the "with" command and its "w"
3042         alias.
3043         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3044         declarations.
3045         * cli/cli-setshow.c (parse_cli_var_uinteger)
3046         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3047         argument strings for all var_types.
3048         (get_setshow_command_value_string): New, factored out from ...
3049         (do_show_command): ... this.
3050         * cli/cli-setshow.h: Include <string>.
3051         (get_setshow_command_value_string): Declare.
3052         * command.h (repeat_previous): Now returns const char *.  Adjust
3053         comment.
3054         * maint.c: Include "cli/cli-cmds.h".
3055         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3056         (_initialize_maint_cmds): Register the "maintenance with" command.
3057         * top.c (repeat_previous): Move bits from pipe_command here:
3058         Return the saved command line, if any; error out if there's no
3059         command to relaunch.
3060
3061 2019-07-03  Pedro Alves  <palves@redhat.com>
3062
3063         * NEWS (New commands): Mention "maint set/show test-settings"
3064         instead of "maint test-settings".
3065         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3066         (maintenance_test_settings_set_list): Rename to ...
3067         (maintenance_set_test_settings_list): ... this.
3068         (maintenance_test_settings_show_list): Rename to  ...
3069         (maintenance_show_test_settings_list): ... this.
3070         (maintenance_test_settings_cmd): Delete.
3071         (maintenance_test_settings_set_cmd): ...
3072         (maintenance_set_test_settings_cmd): ... this.
3073         (maintenance_test_settings_show_cmd): ...
3074         (maintenance_show_test_settings_cmd): ... this.
3075         (maintenance_test_settings_show_value_cmd):
3076         (maintenance_show_test_settings_value_cmd): ... this.
3077         (_initialize_maint_test_settings): No longer install the "maint
3078         test-settings" prefix command.  Rename "maint test-settings set"
3079         to "maint set test-settings", and "maint test-settings show" to
3080         "maint show test-settings".  Adjust all subcommands.
3081
3082 2019-07-03  Pedro Alves  <palves@redhat.com>
3083
3084         * maint-test-settings.c: Fix file's intro comment.  Replace all
3085         references to "test-options" with references to "test-settings",
3086         in comments.
3087
3088 2019-07-03  Pedro Alves  <palves@redhat.com>
3089
3090         * maint-test-settings.c (maintenance_test_settings_xxx)
3091         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3092         New.
3093         (maintenance_test_settings_enums): Use them.
3094         (maintenance_test_settings_enum): Default to
3095         maintenance_test_settings_xxx.
3096         (_initialize_maint_test_settings): Initialize
3097         MAINTENANCE_TEST_SETTINGS_FILENAME.
3098
3099 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3100
3101         * breakpoint.h (remove_breakpoints_inf): Change return type to
3102         void, move function documentation here.
3103         * breakpoint.c (remove_breakpoints_inf): Change return type to
3104         void, move function documentation to header.
3105
3106 2019-07-02  Pedro Alves  <palves@redhat.com>
3107
3108         * NEWS (Completion improvements): Mention "info threads".
3109         * thread.c (struct info_threads_opts, info_threads_option_defs)
3110         (make_info_threads_options_def_group): New.
3111         (info_threads_command): Use gdb::option::process_options.
3112         (info_threads_command_completer): New.
3113         (_initialize_thread): Use gdb::option::build_help to build the
3114         help text for "info threads".
3115
3116 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3117
3118         * defs.h (generic_load): Move from here...
3119         * symfile.h (generic_load): ... to here.  Rename name parameter
3120         to args.
3121         * symfile.c (generic_load): Add comment.
3122
3123 2019-07-01  Tom Tromey  <tromey@adacore.com>
3124
3125         * dwarf2read.c
3126         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3127         declaration of without_params.  Fix formatting.
3128
3129 2019-07-01  Tom Tromey  <tromey@adacore.com>
3130
3131         * ada-exp.y (find_primitive_type): Update.
3132         * ada-lang.h (ada_lookup_symbol): Update.
3133         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3134         parameter.
3135         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3136
3137 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3138
3139         PR breakpoints/24541
3140         * gdbarch.c: Regenerate.
3141         * gdbarch.h: Regenerate.
3142         * gdbarch.sh: Add 'stap_adjust_register'.
3143         * i386-tdep.c: Include '<unordered_set>'.
3144         (i386_stap_adjust_register): New function.
3145         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3146         * stap-probe.c (stap_parse_register_operand): Call
3147         'gdbarch_stap_adjust_register'.
3148
3149 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3150
3151         PR python/24742
3152         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3153         * python/python.c (do_start_initialization): Use 'xmalloc'
3154         instead of 'PyMem_Malloc'.
3155
3156 2019-06-28  Tom Tromey  <tromey@adacore.com>
3157
3158         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3159         for Ada.
3160
3161 2019-06-27  Tom Tromey  <tromey@adacore.com>
3162
3163         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3164         objfile_key.
3165         (arm_find_mapping_symbol, arm_record_special_symbol)
3166         (_initialize_arm_tdep): Update.
3167         (arm_objfile_data_free): Remove.
3168
3169 2019-06-27  Tom Tromey  <tromey@adacore.com>
3170
3171         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3172         to cp_print_static_field.
3173
3174 2019-06-26  Tom Tromey  <tromey@adacore.com>
3175
3176         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3177         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3178         declare.
3179
3180 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3181
3182         * features/aarch64-core.c (create_feature_aarch64_core):
3183         Regenerate.
3184         * features/aarch64-core.xml: Add cpsr flags.
3185
3186 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3187
3188         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3189         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3190
3191 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3192
3193         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3194         field.
3195         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3196         use.
3197         (arm_record_special_symbol): Don't insert new symbol in sorted
3198         position, push it at the end.
3199
3200 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3201
3202         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3203         (arm_mapping_symbol_s): Remove.
3204         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3205         (arm_mapping_symbol_vec): New typedef.
3206         (struct arm_per_objfile): Add constructor.
3207         <section_maps>: Change type to
3208         std::unique_ptr<arm_mapping_symbol_vec[]>.
3209         (arm_compare_mapping_symbols): Remove.
3210         (arm_find_mapping_symbol): Adjust to section_maps type change.
3211         (arm_objfile_data_free): Call delete on arm_per_objfile.
3212         (arm_record_special_symbol): Adjust to section_maps type change.
3213         Allocate arm_per_objfile with new.
3214
3215 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3216
3217         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3218         with the command prefix.
3219
3220 2019-06-25  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3223         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3224
3225 2019-06-25  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3228         type.
3229         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3230         protected.
3231
3232 2019-06-25  Tom Tromey  <tom@tromey.com>
3233
3234         * tui/tui-winsource.c
3235         (tui_source_window_base::set_is_exec_point_at): Add check against
3236         LOA_ADDRESS.
3237
3238 2019-06-25  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-source.c (tui_set_source_content): Don't check before
3241         xfree.
3242         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3243
3244 2019-06-25  Tom Tromey  <tom@tromey.com>
3245
3246         * tui/tui-winsource.h (tui_update_source_window_as_is)
3247         (tui_alloc_source_buffer, tui_line_is_displayed)
3248         (tui_addr_is_displayed): Change type of win_info.
3249         * tui/tui-winsource.c (tui_update_source_window_as_is)
3250         (tui_clear_source_content, tui_show_source_line)
3251         (tui_show_source_content, tui_source_window_base::refill)
3252         (tui_source_window_base::set_is_exec_point_at)
3253         (tui_source_window_base::set_is_exec_point_at)
3254         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3255         (tui_alloc_source_buffer, tui_line_is_displayed)
3256         (tui_addr_is_displayed): Change type of win_info.  Update.
3257         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3258         (tui_source_window_base::do_make_visible_with_new_height):
3259         Update.
3260         * tui/tui-source.c (tui_set_source_content)
3261         (tui_set_source_content_nil)
3262         (tui_source_window::do_scroll_vertical): Update.
3263         * tui/tui-layout.c (show_layout): Update.
3264         * tui/tui-disasm.c (tui_set_disassem_content)
3265         (tui_disasm_window::do_scroll_vertical): Update.
3266         * tui/tui-data.h (tui_win_content): Remove.
3267         (struct tui_gen_win_info) <content, content_size>: Remove.
3268         (struct tui_source_element): Add initializers and destructor.
3269         (union tui_which_element, struct tui_win_element): Remove.
3270         (struct tui_source_window_base) <content>: New field.
3271         (struct tui_data_window): Remove destructor.
3272         (tui_alloc_content, tui_free_win_content)
3273         (tui_free_all_source_wins_content): Don't declare.
3274         * tui/tui-data.c (tui_initialize_static_data): Update.
3275         (init_content_element, tui_alloc_content): Remove.
3276         (~tui_gen_win_info): Update.
3277         (~tui_data_window, tui_free_all_source_wins_content)
3278         (tui_free_win_content, free_content, free_content_elements):
3279         Remove.
3280
3281 2019-06-25  Tom Tromey  <tom@tromey.com>
3282
3283         * tui/tui-winsource.h (tui_clear_source_content)
3284         (tui_erase_source_content, tui_show_source_content): Change type
3285         of win_info.
3286         * tui/tui-winsource.c (tui_clear_source_content)
3287         (tui_erase_source_content, tui_show_source_content): Change type
3288         of win_info.
3289         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3290         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3291         win_info.
3292         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3293         win_info.
3294         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3295
3296 2019-06-25  Tom Tromey  <tom@tromey.com>
3297
3298         * tui/tui-winsource.c (tui_clear_source_content)
3299         (tui_source_window_base::set_is_exec_point_at): Update.
3300         * tui/tui-source.c (tui_set_source_content_nil): Update.
3301         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3302         a bool.
3303         * tui/tui-data.c (init_content_element): Update.
3304
3305 2019-06-25  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3308         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3309         * tui/tui-layout.c (init_and_make_win): Update.
3310         * tui/tui.h (enum tui_win_type): Update.
3311         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3312         tui_win_is_auxillary.
3313         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3314         tui_win_is_auxillary.
3315
3316 2019-06-25  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3319         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3320         (tui_delete_data_content_windows, tui_display_all_data)
3321         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3322         Update.
3323         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3324         * tui/tui-regs.c (tui_last_regs_line_no)
3325         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3326         (tui_show_registers): Update.
3327         (tui_show_register_group): Return void.  Update.
3328         (tui_display_registers_from, tui_display_reg_element_at_line)
3329         (tui_display_registers_from_line, tui_check_register_values):
3330         Update.
3331         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3332         member.
3333         (struct tui_data_window) <regs_content>: Now a std::vector.
3334         <regs_content_count>: Remove.
3335         (tui_add_content_elements, tui_free_data_content): Don't declare.
3336         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3337         (init_content_element): Remove DATA_WIN case.  Add assert.
3338         (tui_add_content_elements): Remove.
3339         (tui_data_window): Update.
3340         (tui_free_data_content): Remove.
3341         (free_content_elements): Remove DATA_WIN case.
3342
3343 2019-06-25  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-data.c (tui_data_item_window): Update.
3346         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3347         * tui/tui-windata.c (tui_display_all_data)
3348         (tui_display_data_from_line): Update.
3349         (tui_check_data_values): Remove.
3350         * tui/tui-regs.c (tui_show_register_group)
3351         (tui_display_reg_element_at_line): Update.
3352         * tui/tui-hooks.c (tui_register_changed)
3353         (tui_refresh_frame_and_register_information): Call
3354         tui_check_register_values.
3355         * tui/tui-data.h (struct tui_data_window) <data_content,
3356         data_content_count, data_type>: Remove.
3357         (enum tui_data_type): Remove.
3358
3359         * tui/tui-data.c (tui_data_window::clear_detail)
3360         (~tui_data_window): Update.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3365         declare.
3366         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3367         Rename from tui_first_data_item_displayed.  Update.
3368         (tui_data_window::refresh_all)
3369         (tui_data_window::do_scroll_vertical): Update.
3370         * tui/tui-data.h (struct tui_data_window)
3371         <first_data_item_displayed>: Declare new method.
3372
3373 2019-06-25  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3376         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3377         contents...
3378         (tui_initialize_static_data): ...here.
3379
3380 2019-06-25  Tom Tromey  <tom@tromey.com>
3381
3382         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3383         (tui_display_registers_from, tui_check_register_values): Update.
3384         (tui_display_register): Remove win_info parameter; update.
3385         (tui_get_register): Change type of parameters.
3386         * tui/tui-data.h (struct tui_data_element): Remove.
3387         (union tui_which_element) <data>: Remove.
3388         <data_window>: Change type.
3389         (struct tui_data_item_window): New.
3390         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3391         case.  Add assert.
3392         (~tui_data_item_window): New destructor.
3393         (free_content_elements): Remove DATA_ITEM_WIN case.
3394
3395 2019-06-25  Tom Tromey  <tom@tromey.com>
3396
3397         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3398         Remove.
3399
3400 2019-06-25  Tom Tromey  <tom@tromey.com>
3401
3402         * tui/tui-data.h (struct tui_command_element): Remove.
3403         (union tui_which_element) <command>: Remove.
3404         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3405         assert.
3406         (free_content_elements): Remove CMD_WIN case.
3407
3408 2019-06-25  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-layout.c (tui_set_layout): Update.
3411         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3412         * tui/tui-data.c (layout_def): Update.
3413
3414 2019-06-25  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3417         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3418         (tui_source_window_base::set_new_height): Update.
3419         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3420         Update.
3421         (tui_set_locator_fullname, tui_set_locator_info)
3422         (tui_show_frame_info): Update.
3423         * tui/tui-source.c (tui_set_source_content)
3424         (tui_source_is_displayed): Update.
3425         * tui/tui-layout.c (show_source_disasm_command, show_data)
3426         (show_source_or_disasm_and_command): Update.
3427         * tui/tui-disasm.c (tui_set_disassem_content)
3428         (tui_get_begin_asm_address): Update.
3429         * tui/tui-data.h (struct tui_locator_element): Remove.
3430         (union tui_which_element) <locator>: Remove.
3431         (struct tui_locator_window): New.
3432         (tui_locator_win_info_ptr): Change return type.
3433         * tui/tui-data.c (_locator): Change type.
3434         (tui_locator_win_info_ptr): Change return type.
3435         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3436         (tui_alloc_content): Add assert.
3437
3438 2019-06-25  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-winsource.c
3441         (tui_exec_info_window::maybe_allocate_content): New method.
3442         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3443         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3444         (make_source_or_disasm_window): Add cast.
3445         * tui/tui-data.h (union tui_which_element) <simple_string>:
3446         Remove.
3447         (struct tui_source_info): New.
3448         (struct tui_source_window_base) <execution_info>: Change type.
3449         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3450         case, and add assert.
3451         (tui_alloc_content): Add assert.
3452
3453 2019-06-25  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3456         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3457         * tui/tui-data.c (tui_alloc_win_info): Remove.
3458
3459 2019-06-25  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3462         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3463         can_highlight.
3464
3465 2019-06-25  Tom Tromey  <tom@tromey.com>
3466
3467         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3468         make_visible_with_new_height method.
3469         (tui_win_info::make_visible_with_new_height): New method.
3470         (tui_source_window_base::do_make_visible_with_new_height)
3471         (tui_data_window::do_make_visible_with_new_height)
3472         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3473         (make_visible_with_new_height): Remove.
3474         (tui_resize_all, tui_adjust_win_heights): Use
3475         make_visible_with_new_height method.
3476         * tui/tui-data.h (struct tui_win_info)
3477         <do_make_visible_with_new_height, make_visible_with_new_height>:
3478         New methods.
3479         (struct tui_source_window_base, struct tui_data_window)
3480         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3481         methods.
3482
3483 2019-06-25  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3486         method.
3487         (update_tab_width): Call update_tab_width method.
3488         * tui/tui-data.h (struct tui_win_info)
3489         (struct tui_source_window_base) <update_tab_width>: New methods.
3490
3491 2019-06-25  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3494         parameter.
3495         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3496         parameter.
3497         (tui_gen_win_info::make_visible): Update.
3498         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3499         parameter.
3500         * tui/tui-data.h (enum tui_box): New enum.
3501         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3502
3503 2019-06-25  Tom Tromey  <tom@tromey.com>
3504
3505         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3506         init_and_make_win for EXEC_INFO_WIN.
3507         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3508         longer inline.
3509         (struct tui_win_info) <~tui_win_info>: Inline.
3510         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3511         Don't declare.
3512         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3513         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3514         Remove.
3515         (tui_initialize_static_data): Update.
3516         (~tui_gen_win_info): Handle more cleanup here.
3517         (~tui_source_window_base): Delete "execution_info".
3518         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3519
3520 2019-06-25  Tom Tromey  <tom@tromey.com>
3521
3522         * tui/tui-layout.c (make_command_window): Don't set
3523         can_highlight.
3524         (show_source_disasm_command): Call the reset method.
3525         (show_data): Don't set can_highlight.  Call the reset method.
3526         (tui_gen_win_info::reset): Rename from init_gen_win_info
3527         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3528         (show_source_or_disasm_and_command): Call the reset method.
3529         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3530         (struct tui_cmd_window): Set can_highlight.
3531
3532 2019-06-25  Tom Tromey  <tom@tromey.com>
3533
3534         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3535         from make_visible.
3536         (tui_make_visible, tui_make_invisible): Rewrite.
3537         (tui_win_info::make_visible): Remove.
3538         (tui_source_window_base::make_visible): Update.
3539         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3540         method.  Moved from...
3541         (struct tui_win_info) <make_visible>: ...here.
3542
3543 2019-06-25  Tom Tromey  <tom@tromey.com>
3544
3545         * tui/tui-winsource.c
3546         (tui_source_window_base::do_scroll_horizontal): Remove direction
3547         parameter.
3548         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3549         direction parameter.
3550         * tui/tui-win.c (tui_win_info::forward_scroll)
3551         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3552         (tui_win_info::right_scroll): Update.
3553         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3554         direction parameter.
3555         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3556         direction parameter.
3557         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3558         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3559         Remove direction parameter.
3560         (struct tui_source_window_base, struct tui_source_window)
3561         (struct tui_disasm_window, struct tui_data_window)
3562         (struct tui_cmd_window): Update.
3563
3564 2019-06-25  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-winsource.h (tui_set_exec_info_content)
3567         (tui_show_exec_info_content, tui_erase_exec_info_content)
3568         (tui_clear_exec_info_content, tui_update_exec_info): Change
3569         argument to tui_source_window_base.
3570         * tui/tui-winsource.c (tui_set_exec_info_content)
3571         (tui_show_exec_info_content, tui_erase_exec_info_content)
3572         (tui_clear_exec_info_content, tui_update_exec_info): Change
3573         argument to tui_source_window_base.
3574
3575 2019-06-25  Tom Tromey  <tom@tromey.com>
3576
3577         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3578         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3579
3580 2019-06-25  Tom Tromey  <tom@tromey.com>
3581
3582         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3583         check.
3584
3585 2019-06-25  Tom Tromey  <tom@tromey.com>
3586
3587         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3588         type to void.
3589         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3590         type to void.
3591         * tui/tui-source.c (tui_set_source_content): Update.
3592         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3593
3594 2019-06-25  Tom Tromey  <tom@tromey.com>
3595
3596         * tui/tui-win.c (window_name_completer, tui_set_focus)
3597         (tui_all_windows_info): Use name method.
3598         * tui/tui-data.h (struct tui_gen_win_info)
3599         (struct tui_source_window, struct tui_disasm_window)
3600         (struct tui_data_window, struct tui_cmd_window) <name>: New
3601         method.
3602         (tui_win_name): Don't declare.
3603         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3604         (tui_win_name): Remove.
3605
3606 2019-06-25  Tom Tromey  <tom@tromey.com>
3607
3608         * tui/tui-winsource.h (tui_update_source_window)
3609         (tui_update_source_window_as_is): Change parameter type.
3610         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3611         to be a tui_source_window_base.
3612         (tui_update_source_window_as_is): Likewise.
3613         * tui/tui-win.c (make_visible_with_new_height): Update.
3614
3615 2019-06-25  Tom Tromey  <tom@tromey.com>
3616
3617         * tui/tui-winsource.c (tui_erase_source_content)
3618         (tui_show_source_content, tui_show_exec_info_content)
3619         (tui_erase_exec_info_content): Use refresh_window method.
3620         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3621         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3622         from tui_refresh_win.
3623         (tui_data_window::refresh_window): New method.
3624         (tui_win_info::refresh, tui_source_window_base::refresh)
3625         (tui_refresh_all): Use refresh_window method.
3626         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3627         method.
3628         * tui/tui-regs.c (tui_display_register): Call refresh_window
3629         method.
3630         * tui/tui-layout.c (show_source_disasm_command)
3631         (show_source_or_disasm_and_command): Call refresh_window method.
3632         * tui/tui-data.h (struct tui_gen_win_info)
3633         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3634         New method.
3635
3636 2019-06-25  Tom Tromey  <tom@tromey.com>
3637
3638         * tui/tui.c (tui_rl_other_window, tui_enable)
3639         (tui_is_window_visible, tui_get_command_dimension): Update.
3640         * tui/tui-winsource.c (tui_update_source_window_as_is)
3641         (tui_clear_source_content, tui_erase_source_content)
3642         (tui_show_source_line, tui_source_window_base::refill)
3643         (tui_source_window_base::do_scroll_horizontal)
3644         (tui_source_window_base::set_is_exec_point_at)
3645         (tui_update_breakpoint_info, tui_set_exec_info_content)
3646         (tui_alloc_source_buffer, tui_line_is_displayed)
3647         (tui_addr_is_displayed): Update.
3648         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3649         (tui_check_and_display_highlight_if_needed)
3650         (tui_win_info::make_visible, tui_win_info::refresh)
3651         (tui_refresh_all): Update.
3652         * tui/tui-windata.c (tui_first_data_item_displayed)
3653         (tui_delete_data_content_windows, tui_erase_data_content)
3654         (tui_display_all_data, tui_data_window::refresh_all)
3655         (tui_check_data_values): Update.
3656         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3657         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3658         (tui_win_info::backward_scroll, tui_refresh_all_win)
3659         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3660         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3661         (tui_source_window_base::set_new_height)
3662         (tui_data_window::set_new_height)
3663         (make_invisible_and_set_new_height)
3664         (make_visible_with_new_height, new_height_ok)
3665         (parse_scrolling_args): Update.
3666         * tui/tui-stack.c (tui_show_frame_info): Update.
3667         * tui/tui-source.c (tui_set_source_content)
3668         (tui_set_source_content_nil, tui_source_is_displayed)
3669         (tui_source_window::do_scroll_vertical): Update.
3670         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3671         (tui_display_registers_from, tui_display_reg_element_at_line)
3672         (tui_check_register_values, tui_reg_command): Update.
3673         * tui/tui-layout.c (tui_default_win_height)
3674         (show_source_disasm_command, show_data, init_and_make_win)
3675         (show_source_or_disasm_and_command): Update.
3676         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3677         (tui_redisplay_readline, tui_mld_flush)
3678         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3679         (tui_getc): Update.
3680         * tui/tui-disasm.c (tui_set_disassem_content)
3681         (tui_disasm_window::do_scroll_vertical): Update.
3682         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3683         Now virtual.
3684         (struct tui_win_info): Derive from tui_gen_win_info.
3685         <~tui_win_info>: Mark as override.
3686         <generic>: Remove member.
3687         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3688         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3689         (~tui_data_window, ~tui_win_info)
3690         (tui_free_all_source_wins_content): Update.
3691         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3692
3693 2019-06-25  Tom Tromey  <tom@tromey.com>
3694
3695         * tui/tui-layout.c (init_and_make_win): Use new.
3696         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3697         destructor, initializers.
3698         (tui_alloc_generic_win_info): Don't declare.
3699         * tui/tui-data.c (_locator): Add argument to constructor.
3700         (source_win, disasm_win): New globals.
3701         (exec_info): Remove.
3702         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3703         Update.
3704         (tui_alloc_generic_win_info): Remove.
3705         (init_content_element): Use new.
3706         (tui_win_info::tui_win_info): Update.
3707         (free_content_elements) <case DATA_WIN>: Use delete.
3708
3709 2019-06-25  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3712         * tui/tui-windata.c (tui_first_data_item_displayed)
3713         (tui_delete_data_content_windows): Update.
3714         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3715         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3716         (tui_display_registers_from, tui_check_register_values): Update.
3717         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3718         pointer.
3719         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3720         window.
3721         (tui_free_data_content): Update.
3722         (free_content_elements) <case DATA_WIN>: Free the window.
3723
3724 2019-06-25  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3727         Update.
3728         * tui/tui-layout.c (make_command_window)
3729         (show_source_disasm_command, show_data, init_and_make_win)
3730         (show_source_or_disasm_and_command): Update.
3731         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3732         method.
3733         <can_highight, is_highlighted>: Now bool.
3734         (tui_set_win_highlight): Don't declare.
3735         * tui/tui-data.c (tui_set_win_highlight): Remove.
3736
3737 2019-06-25  Tom Tromey  <tom@tromey.com>
3738
3739         * tui/tui-wingeneral.c (make_visible): Remove check of window
3740         type.
3741
3742 2019-06-25  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-win.c (tui_win_info::max_height)
3745         (tui_cmd_window::max_height): New methods.
3746         (new_height_ok): Call max_height.
3747         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3748         <max_height>: New method.
3749
3750 2019-06-25  Tom Tromey  <tom@tromey.com>
3751
3752         * tui/tui-win.c (tui_source_window_base::set_new_height)
3753         (tui_data_window::set_new_height): New methods.
3754         (make_invisible_and_set_new_height): Call set_new_height method.
3755         * tui/tui-data.h (struct tui_win_info)
3756         (struct tui_source_window_base, struct tui_data_window)
3757         <set_new_height>: New method.
3758
3759 2019-06-25  Tom Tromey  <tom@tromey.com>
3760
3761         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3762         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3763         tui_refresh_data_win.
3764         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3765         method.
3766         (tui_refresh_all_win): Call the refresh_all method.
3767         (tui_set_focus): Likewise.
3768         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3769         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3770         Likewise.
3771
3772 2019-06-25  Tom Tromey  <tom@tromey.com>
3773
3774         * tui/tui-winsource.h (tui_refill_source_window)
3775         (tui_set_is_exec_point_at): Don't declare.
3776         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3777         (tui_source_window_base::refill): Rename from
3778         tui_refill_source_window.
3779         (tui_source_window_base::do_scroll_horizontal): Update.
3780         (tui_source_window_base::set_is_exec_point_at): Rename from
3781         tui_set_is_exec_point_at.
3782         (tui_update_all_breakpoint_info): Update.
3783         * tui/tui-stack.c (tui_show_frame_info): Update.
3784         * tui/tui-layout.c (show_data): Add cast.
3785         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3786         * tui/tui-data.h (struct tui_source_window_base) <refill,
3787         set_is_exec_point_at>: New methods.
3788         (tui_source_windows, tui_add_to_source_windows): Update types.
3789         (tui_add_to_source_windows): Remove redundant declaration.
3790         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3791         (tui_source_windows): Change return type.
3792         (tui_clear_source_windows_detail): Update.
3793         (tui_add_to_source_windows): Change type of parameter.
3794         (tui_free_all_source_wins_content): Update.
3795
3796 2019-06-25  Tom Tromey  <tom@tromey.com>
3797
3798         * tui/tui-wingeneral.c (tui_win_info::refresh)
3799         (tui_source_window_base::refresh): New methods.
3800         (tui_refresh_all): Call the refresh method.
3801         * tui/tui-data.h (struct tui_win_info)
3802         (struct tui_source_window_base) <refresh>: New method.
3803
3804 2019-06-25  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui.h (tui_is_window_visible): Return bool.
3807         * tui/tui.c (tui_is_window_visible): Return bool.
3808         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3809         (tui_make_visible, tui_make_invisible)
3810         (tui_win_info::make_visible)
3811         (tui_source_window_base::make_visible, make_all_visible)
3812         (tui_make_all_visible, tui_make_all_invisible): Update.
3813         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3814         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3815         bool.
3816         (struct tui_win_info, struct tui_source_window_base)
3817         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3818         * tui/tui-data.c (tui_init_generic_part): Update.
3819
3820 2019-06-25  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3823         (tui_source_window_base::make_visible): New methods.
3824         (make_all_visible): Make method call.
3825         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3826         (struct tui_source_window_base, struct tui_cmd_window): Override
3827         make_visible.
3828         (tui_win_is_source_type): Don't declare.
3829         * tui/tui-data.c (tui_win_is_source_type): Remove.
3830
3831 2019-06-25  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3834         NULL check.
3835
3836 2019-06-25  Tom Tromey  <tom@tromey.com>
3837
3838         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3839         Inline constructor.  Add initializers for members.
3840         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3841         constructors; now inline in class.
3842
3843 2019-06-25  Tom Tromey  <tom@tromey.com>
3844
3845         * tui/tui-regs.c (tui_show_registers): Update.
3846         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3847         bool.
3848         * tui/tui-data.c (tui_data_window::clear_detail)
3849         (tui_data_window): Update.
3850
3851 2019-06-25  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-windata.c (tui_display_all_data)
3854         (tui_display_data_from_line, tui_display_data_from)
3855         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3856         Update.
3857         * tui/tui-regs.c (tui_last_regs_line_no)
3858         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3859         (tui_show_registers, tui_show_register_group)
3860         (tui_display_registers_from, tui_display_reg_element_at_line)
3861         (tui_display_registers_from_line, tui_check_register_values)
3862         (tui_reg_next, tui_reg_prev): Update.
3863         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3864         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3865         tui_data_window.
3866         (struct tui_win_info) <detail>: Remove.  Add new fields from
3867         tui_data_info.
3868         (TUI_DATA_WIN): Add cast.
3869         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3870         (~tui_data_window): Simplify.
3871
3872 2019-06-25  Tom Tromey  <tom@tromey.com>
3873
3874         * tui/tui-layout.c (show_source_disasm_command)
3875         (show_source_or_disasm_and_command): Update.
3876         * tui/tui-io.c (update_cmdwin_start_line)
3877         (tui_redisplay_readline): Update.
3878         * tui/tui-data.h (struct tui_command_info): Remove.
3879         (struct tui_win_info) <detail>: Remove command_info member.
3880         (struct tui_data_window) <start_line>: New member, from
3881         tui_command_info.
3882         (TUI_CMD_WIN): Add casts.
3883
3884 2019-06-25  Tom Tromey  <tom@tromey.com>
3885
3886         * tui/tui-winsource.c (tui_update_source_window)
3887         (tui_refill_source_window)
3888         (tui_source_window_base::do_scroll_horizontal)
3889         (tui_update_breakpoint_info, tui_set_exec_info_content)
3890         (tui_show_exec_info_content, tui_erase_exec_info_content)
3891         (tui_clear_exec_info_content): Update.
3892         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3893         Update.
3894         * tui/tui-win.c (make_invisible_and_set_new_height)
3895         (make_visible_with_new_height): Update.
3896         * tui/tui-source.c (tui_set_source_content)
3897         (tui_show_symtab_source): Update.
3898         * tui/tui-layout.c (extract_display_start_addr)
3899         (show_source_disasm_command, show_data)
3900         (make_source_or_disasm_window)
3901         (show_source_or_disasm_and_command): Update.
3902         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3903         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3904         "gdbarch".
3905         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3906         to tui_source_window_base.
3907         (struct tui_win_info) <detail>: Remove source_info member.
3908         (struct tui_source_window_base) <has_locator>: Inline.
3909         Move contents from tui_source_info; rename has_locator member to
3910         m_has_locator.
3911         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3912         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3913         header file.
3914         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3915         Simplify.
3916         (tui_free_all_source_wins_content): Cast to
3917         tui_source_window_base.
3918
3919 2019-06-25  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui-win.c (make_invisible_and_set_new_height)
3922         (make_visible_with_new_height): Call has_locator method.
3923         * tui/tui-layout.c (show_source_disasm_command, show_data)
3924         (show_source_or_disasm_and_command): Update for bool change.
3925         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3926         (tui_win_info) <has_locator>: New method.
3927         (struct tui_source_window_base) <has_locator>: New method.
3928         (tui_win_has_locator): Don't declare.
3929         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3930         from tui_win_has_locator.
3931         (tui_source_window_base): Use false, not FALSE.
3932
3933 2019-06-25  Tom Tromey  <tom@tromey.com>
3934
3935         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3936         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3937         clear_detail method directly.
3938         (tui_clear_win_detail): Remove.
3939
3940 2019-06-25  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3943         "this", not TUI_DISASM_WIN.
3944
3945 2019-06-25  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3948         declare.
3949         * tui/tui-winsource.c
3950         (tui_source_window_base::do_scroll_horizontal): Rename from
3951         tui_horizontal_source_scroll.
3952         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3953         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3954         from tui_vertical_data_scroll.
3955         * tui/tui-win.h (tui_scroll): Don't declare.
3956         * tui/tui-win.c (tui_win_info::forward_scroll)
3957         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3958         (tui_win_info::right_scroll): Rename and update.
3959         (tui_scroll_forward_command, tui_scroll_backward_command)
3960         (tui_scroll_left_command, tui_scroll_right_command): Update.
3961         (tui_scroll): Remove.
3962         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3963         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3964         from tui_vertical_source_scroll.
3965         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3966         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3967         from tui_vertical_disassem_scroll.
3968         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3969         do_scroll_horizontal>: New methods.
3970         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3971         Likewise.
3972         (struct tui_source_window_base): Add do_scroll_horizontal.
3973         (struct tui_source_window, struct tui_disasm_window): Add
3974         do_scroll_vertical.
3975         (struct tui_data_window, struct tui_cmd_window): Add
3976         do_scroll_horizontal and do_scroll_vertical.
3977         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3978
3979 2019-06-25  Tom Tromey  <tom@tromey.com>
3980
3981         * tui/tui-data.h (struct tui_source_window_base): New struct.
3982         (struct tui_source_window): Derive from tui_source_window_base.
3983         (struct tui_disasm_window): New struct.
3984         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3985         from tui_source_window::clear_detail.
3986         (tui_source_window_base): Rename from tui_source_window.
3987         (~tui_source_window_base): Rename from ~tui_source_window.
3988         (tui_alloc_win_info): Create a tui_disasm_window.
3989
3990 2019-06-25  Tom Tromey  <tom@tromey.com>
3991
3992         * tui/tui-data.h (struct tui_source_window)
3993         (struct tui_data_window): Declare destructors.
3994         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3995         destructors.
3996         (tui_win_info): Simplify.
3997
3998 2019-06-25  Tom Tromey  <tom@tromey.com>
3999
4000         * tui/tui-winsource.c (tui_display_main)
4001         (tui_update_source_windows_with_addr)
4002         (tui_update_all_breakpoint_info): Update.
4003         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4004         (new_height_ok, parse_scrolling_args): Update.
4005         * tui/tui-stack.c (tui_show_frame_info): Update.
4006         * tui/tui-data.h (struct tui_list): Remove.
4007         (tui_source_windows): Return a reference to a std::vector.
4008         * tui/tui-data.c (source_windows): Now a std::vector.
4009         (tui_source_windows): Change return type.
4010         (tui_clear_source_windows): Rewrite.
4011         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4012         (tui_free_all_source_wins_content): Rewrite.
4013
4014 2019-06-25  Tom Tromey  <tom@tromey.com>
4015
4016         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4017         (struct tui_data_window, struct tui_cmd_window): Declare
4018         clear_detail method.
4019         * tui/tui-data.c (tui_source_window::clear_detail)
4020         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4021         methods.
4022         (tui_clear_win_detail): Simplify.
4023
4024 2019-06-25  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-layout.c (make_source_window, make_disasm_window)
4027         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4028         Return the new window.
4029         (show_source_disasm_command, show_data)
4030         (show_source_or_disasm_and_command): Update.
4031
4032 2019-06-25  Tom Tromey  <tom@tromey.com>
4033
4034         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4035         parameter.  Return the new window.
4036         (show_source_disasm_command): Update and remove NULL check.
4037         (show_source_or_disasm_and_command): Update.
4038
4039 2019-06-25  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4042
4043 2019-06-25  Tom Tromey  <tom@tromey.com>
4044
4045         * tui/tui-data.h (struct tui_win_info): Make constructor
4046         protected.  Make destructor virtual.  Add initializers.
4047         (tui_source_window, tui_data_window, tui_cmd_window): New
4048         classes.
4049         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4050         constructor.  Add "type" parameter.
4051         (tui_source_window, tui_data_window, tui_cmd_window): New
4052         constructors.
4053         (tui_alloc_win_info): Instantiate the appropriate subclass.
4054
4055 2019-06-25  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-win.c (tui_resize_all): Use delete.
4058         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4059         destructor.
4060         (tui_free_window): Don't declare.
4061         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4062         Update.
4063
4064 2019-06-25  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui-data.h (struct tui_win_info): Add constructor.
4067         * tui/tui-data.c (tui_alloc_win_info): Use new.
4068         (tui_free_window): Use delete.
4069
4070 2019-06-22  Tom Tromey  <tom@tromey.com>
4071
4072         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4073         declare.
4074         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4075
4076 2019-06-22  Tom Tromey  <tom@tromey.com>
4077
4078         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4079         declare.
4080         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4081
4082 2019-06-22  Tom de Vries  <tdevries@suse.de>
4083
4084         * dwarf2read.c (create_addrmap_from_aranges)
4085         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4086         instead of '%zu'.
4087
4088 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4089
4090         * dwarf2read.h (dwarf2_section_info_def): Remove.
4091         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4092         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4093         std::vector<dwarf2_section_info>.
4094         (struct dwo_file) <~dwo_file>: Remove.
4095         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4096         types field.
4097         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4098         (dwarf2_read_debug_names): Likewise.
4099         (create_debug_types_hash_table): Change parameter type to
4100         array_view, adjust code accordingly.
4101         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4102         (partial_die_info::fixup): Likewise.
4103         (determine_prefix): Likewise.
4104         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4105
4106 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4107
4108         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4109         gdb_bfd_ref_ptr.
4110         <~dwo_file>: Remove call to gdb_bfd_unref.
4111         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4112         gdb_bfd_ref_ptr::get.
4113
4114 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4115
4116         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4117         type to htab_up.
4118         * dwarf2read.c (struct dwo_file): Initialize fields.
4119         <~dwo_file>: New.
4120         (free_dwo_file): Remove, move content to ~dwo_file.
4121         (struct dwo_file_deleter): Remove.
4122         (dwo_file_up>: Remove custom deleter.
4123         (free_dwo_files): Remove.
4124         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4125         dwo_files.
4126         (process_skeletonless_type_units): Call unique_ptr::get.
4127         (allocate_dwo_file_hash_table): Add deleter to created hash
4128         table.  Change return type to htab_up.
4129         (lookup_dwo_file_slot): Don't memset dwo_file, call
4130         unique_ptr::get.
4131         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4132         (create_dwo_unit_in_dwp_v2): Likewise.
4133         (open_and_init_dwo_file): Likewise.
4134         (free_dwo_file_from_slot): Remove.
4135
4136 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4137
4138         * dwarf2read.h (struct dwarf2_section_info) <readin,
4139         is_virtual>: Change type to bool.
4140         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4141         true instead of 1.
4142
4143 2019-06-19  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui-data.h (tui_init_content_element): Don't declare.
4146
4147 2019-06-19  Tom Tromey  <tom@tromey.com>
4148
4149         * tui/tui-data.h (tui_init_win_info): Don't declare.
4150
4151 2019-06-19  Tom de Vries  <tdevries@suse.de>
4152
4153         * dwarf2read.h (abstract_to_concrete): Change type to
4154         std::unordered_map<sect_offset, std::vector<sect_offset>,
4155         gdb::hash_enum<sect_offset>>.
4156
4157 2019-06-19  Tom Tromey  <tromey@adacore.com>
4158
4159         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4160         EVAL_AVOID_SIDE_EFFECTS specially.
4161
4162 2019-06-19  Tom Tromey  <tromey@adacore.com>
4163
4164         * source-cache.c (highlighter): New global.
4165         (source_cache::get_source_lines): Create a highlighter on demand.
4166
4167 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * defs.h (deprecated_interactive_hook): Delete declaration.
4170         * interps.c (clear_interpreter_hooks): Remove use of
4171         deprecated_interactive_hook.
4172         * top.c (deprecated_interactive_hook): Delete definition.
4173         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4174
4175 2019-06-18  Tom de Vries  <tdevries@suse.de>
4176
4177         PR gdb/24515
4178         * dwarf2read.h (abstract_to_concrete): Change type from
4179         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4180         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4181         * dwarf2read.c (read_variable): Update.
4182         (dwarf2_fetch_die_loc_sect_off): Update.
4183
4184 2019-06-17  Tom de Vries  <tdevries@suse.de>
4185
4186         PR gdb/24617
4187         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4188         accessing parent[parent_len - 1].
4189
4190 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4191
4192         PR gdb/24364
4193         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4194         call dtrace_process_dof with NULL dof.
4195
4196 2019-06-16  Tom de Vries  <tdevries@suse.de>
4197
4198         PR gdb/24445
4199         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4200
4201 2019-06-16  Tom Tromey  <tom@tromey.com>
4202
4203         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4204         (make_all_visible): Use address of member.
4205
4206 2019-06-16  Tom Tromey  <tom@tromey.com>
4207
4208         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4209         (tui_free_window, free_content, free_content_elements): Remove
4210         unnecessary cast.
4211         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4212         cast.
4213         * tui/tui-regs.c (tui_show_register_group)
4214         (tui_display_registers_from, tui_display_reg_element_at_line):
4215         Remove unnecessary cast.
4216
4217 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4218
4219         * linux-nat.c (normal_mask): Delete.
4220         (_initialize_linux_nat): Don't initialise normal_mask.
4221
4222 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4223
4224         PR gdb/24445
4225         * dwarf-index-write.h (write_psymtabs_to_index): Add
4226         dwz_basename parameter.
4227         * dwarf-index-write.c (write_gdbindex): Move file writing to
4228         write_gdbindex_1.  Change return type void.
4229         (assert_file_size): Move up, remove filename parameter.
4230         (write_gdbindex_1): New function.
4231         (write_debug_names): Change return type to void, call
4232         assert_file_size.
4233         (struct index_wip_file): New struct.
4234         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4235         file logic to index_wip_file.  Write index for dwz file if
4236         needed.
4237         (save_gdb_index_command): Pass basename of dwz file, if present.
4238         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4239         build-id of dwz file, if present.
4240         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4241         (dwarf2_get_dwz_file): Likewise.
4242         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4243         (dwarf2_get_dwz_file): Likewise.
4244
4245 2019-06-16  Tom Tromey  <tom@tromey.com>
4246
4247         * coffread.c (process_coff_symbol): Use xstrdup.
4248         * value.c (create_internalvar): Use xstrdup.
4249
4250 2019-06-16  Tom Tromey  <tom@tromey.com>
4251
4252         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4253         * breakpoint.c (stopin_command, stopat_command)
4254         (until_break_command, decode_location_default): Remove unnecessary
4255         cast.
4256         * utils.c (subset_compare): Remove unnecessary cast.
4257         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4258         cast.
4259         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4260         cast.
4261         * infcmd.c (path_command): Remove unnecessary cast.
4262         * coffread.c (decode_type): Remove unnecessary cast.
4263         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4264         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4265         * tui/tui-stack.c (tui_show_locator_content)
4266         (tui_show_frame_info): Remove unnecessary cast.
4267         * tui/tui-win.c (tui_scroll_forward_command)
4268         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4269         (parse_scrolling_args): Remove unnecessary cast.
4270         * tui/tui-data.c (init_win_info, tui_del_window)
4271         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4272         (free_content_elements): Remove unnecessary cast.
4273         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4274         unnecessary cast.
4275         * tui/tui-source.c (tui_set_source_content)
4276         (tui_vertical_source_scroll): Remove unnecessary cast.
4277         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4278         cast.
4279         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4280         * tui/tui-regs.c (tui_display_registers_from)
4281         (tui_display_register): Remove unnecessary cast.
4282         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4283         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4284         (make_visible): Remove unnecessary cast.
4285         * tui/tui-winsource.c (tui_erase_source_content)
4286         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4287         unnecessary cast.
4288         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4289         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4290         * stabsread.c (read_type, read_array_type, read_range_type):
4291         Remove unnecessary cast.
4292         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4293         (parse_symbol, parse_type, upgrade_type, parse_external)
4294         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4295         unnecessary cast.
4296         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4297
4298 2019-06-16  Tom Tromey  <tom@tromey.com>
4299
4300         * tui/tui-data.c (tui_alloc_generic_win_info)
4301         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4302         checks.
4303
4304 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4305             Andrew Burgess  <andrew.burgess@embecosm.com>
4306
4307         * f-typeprint.c (f_print_type): Don't return early for not
4308         associated or not allocated types.
4309         (f_type_print_varspec_suffix): Add print_rank parameter and print
4310         ranks of array types in case they dangling.
4311         (f_type_print_base): Add print_rank parameter.
4312
4313 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4314
4315         * NEWS: Mention new MI commands.
4316         * break-catch-throw.c (enum exception_event_kind): Move to
4317         breakpoint.h.
4318         (print_mention_exception_catchpoint): Output text as a single
4319         message.
4320         (catch_exception_command_1): Rename to...
4321         (catch_exception_event): ...this, make non-static, update header
4322         command, and change some parameter types.
4323         (catch_catch_command): Update for changes to
4324         catch_exception_command_1.
4325         (catch_throw_command): Likewise.
4326         (catch_rethrow_command): Likewise.
4327         * breakpoint.c (enum exception_event_kind): Delete.
4328         * breakpoint.h (enum exception_event_kind): Moved here from
4329         break-catch-throw.c.
4330         (catch_exception_event): Declare.
4331         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4332         (mi_cmd_catch_throw): New function.
4333         (mi_cmd_catch_rethrow): New function.
4334         (mi_cmd_catch_catch): New function.
4335         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4336         'catch-catch' entries.
4337         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4338         (mi_cmd_catch_rethrow): Declare.
4339         (mi_cmd_catch_catch): Declare.
4340
4341 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4342
4343         * annotate.c (annotate_source_line): Change return type to void,
4344         update implementation to match.
4345         * annotate.h (annotate_source_line): Change return type to void,
4346         update header comment.
4347         * stack.c (print_frame_info): Don't change what frame information
4348         is printed based on whether annotations are on or not.
4349
4350 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4351
4352         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4353         (annotate_source): Make static.
4354         (annotate_source_line): Moved from source.c and renamed from
4355         identify_source_line.  Update the return type.
4356         * annotate.h (annotate_source): Delete declaration.
4357         (annotate_source_line): Declaration moved from source.h, and
4358         renamed from identify_source_line.  Return type updated.
4359         * source.c (identify_source_line): Moved to annotate.c and renamed
4360         to annotate_source_line.
4361         (info_line_command): Remove check of annotation_level.
4362         * source.h (identify_source_line): Move declaration to annotate.h
4363         and rename to annotate_source_line.
4364         * stack.c: Add 'annotate.h' include.
4365         (print_frame_info): Remove check of annotation_level before
4366         calling annotate_source_line.
4367
4368 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4369
4370         * source-cache.c (source_cache::get_plain_source_lines): Use
4371         open_source_file_with_line_charpos instead of just
4372         open_source_file, remove call to find_source_lines.
4373         (source_cache::get_source_lines): Likewise.
4374         * source.c (find_source_lines): Make static.
4375         (get_filename_and_charpos): Renamed into...
4376         (open_source_file_with_line_charpos): ..this along with changes to
4377         return a scoped_fd, and some other minor clean ups.
4378         (identify_source_line): Use open_source_file_with_line_charpos.
4379         (search_command_helper): Use open_source_file_with_line_charpos
4380         instead of just open_source_file, remove call to
4381         find_source_lines.
4382         * source.h (open_source_file_with_line_charpos): Declare new
4383         function.
4384         (find_source_lines): Delete declaration.
4385
4386 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4387
4388         * source.c (get_filename_and_charpos): Remove fullname
4389         parameter.
4390         (identify_source_line): Update call to get_filename_and_charpos.
4391
4392 2019-06-14  Tom Tromey  <tromey@adacore.com>
4393
4394         PR gdb/24502:
4395         * ui-style.h (skip_ansi_escape): Update comment.
4396         * ui-file.h (class no_terminal_escape_file): New class.
4397         * ui-file.c (no_terminal_escape_file::write)
4398         (no_terminal_escape_file::puts): New methods.
4399         * cli/cli-logging.c (handle_redirections): Use
4400         no_terminal_escape_file.
4401
4402 2019-06-14  Tom Tromey  <tromey@adacore.com>
4403
4404         * NEWS: Move convenience variable news above Python news.
4405
4406 2019-06-14  Tom Tromey  <tom@tromey.com>
4407
4408         * gnulib: Move directory to top-level.
4409         * configure.ac: Don't configure gnulib.
4410         * configure: Rebuild.
4411         * common/common-defs.h: Use new path to gnulib.
4412         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4413         (GNULIB_H): Remove.
4414         (INCGNU): Look in new gnulib location.
4415         (HFILES_NO_SRCDIR): Remove gnulib files.
4416         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4417         (generated_files): Remove GNULIB_H.
4418         ($(LIBGNU), all-lib): Remove targets.
4419         (distclean): Don't mention GNULIB_BUILDDIR.
4420         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4421
4422 2019-06-14  Tom Tromey  <tromey@adacore.com>
4423
4424         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4425         Warn if symbol file does not provide any symbols.
4426
4427 2019-06-14  Tom Tromey  <tromey@adacore.com>
4428
4429         * source.c (find_and_open_source): Respect basenames_may_differ.
4430
4431 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4432
4433         * annotate.c (annotate_breakpoints_invalid): Make use of
4434         scoped_restore_terminal_state.
4435         (annotate_frames_invalid): Likewise.
4436
4437 2019-06-14  Tom Tromey  <tromey@adacore.com>
4438
4439         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4440         allow assignment to an internalvar.
4441
4442 2019-06-14  Tom Tromey  <tromey@adacore.com>
4443
4444         * ada-lex.l: Allow "_" in attribute names.
4445
4446 2019-06-14  Tom Tromey  <tromey@adacore.com>
4447
4448         PR gdb/24653:
4449         * regcache.c (registers_changed): Don't call alloca.
4450         * top.c (execute_command): Don't call alloca.
4451
4452 2019-06-13  Pedro Alves  <palves@redhat.com>
4453
4454         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4455         'expression'.  When parsing an expression, error out if there's
4456         junk after "unlimited".
4457         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4458         (do_set_command): Adjust calls to is_unlimited_literal.
4459
4460 2019-06-13  Pedro Alves  <palves@redhat.com>
4461
4462         * compile/compile.c (make_compile_options_def_group): Add braces
4463         around array_view initializer.
4464         * thread.c (make_thread_apply_all_options_def_group)
4465         (make_thread_apply_all_options_def_group): Likewise.
4466
4467 2019-06-13  Pedro Alves  <palves@redhat.com>
4468
4469         * NEWS (New commands): Mention "maint test-options
4470         require-delimiter", "maint test-options unknown-is-error", "maint
4471         test-options unknown-is-operand" and "maint show
4472         test-options-completion-result".
4473         (New command options, command completion): New section.
4474         (Completion improvements): New section.
4475         Mention that you can abbreviate "unlimited".
4476
4477 2019-06-13  Pedro Alves  <palves@redhat.com>
4478
4479         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4480         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4481         * unittests/cli-utils-selftests.c (test_parse_flags)
4482         (test_parse_flags_qcs): Delete.
4483         (test_cli_utils): Don't call deleted functions.
4484
4485 2019-06-13  Pedro Alves  <palves@redhat.com>
4486
4487         * thread.c: Include "cli/cli-option.h".
4488         (tp_array_compar_ascending): Global.
4489         (tp_array_compar): Delete function.
4490         (tp_array_compar_ascending, tp_array_compar_descending): New
4491         functions.
4492         (ascending_option_def, qcs_flag_option_def)
4493         (thr_qcs_flags_option_defs)
4494         (make_thread_apply_all_options_def_group)
4495         (make_thread_apply_options_def_group): New.
4496         (thread_apply_all_command): Use gdb::option::process_options.
4497         (thread_apply_command_completer)
4498         (thread_apply_all_command_completer): New.
4499         (thread_apply_command): Use gdb::option::process_options.
4500         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4501         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4502         to generate help text of "thread apply".  Adjust "taas"'s help.
4503         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4504         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4505
4506 2019-06-13  Pedro Alves  <palves@redhat.com>
4507
4508         * thread.c (thread_apply_command): Check for invalid TID with
4509         isdigit instead of !isalpha.
4510
4511 2019-06-13  Pedro Alves  <palves@redhat.com>
4512
4513         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4514         (validate_flags_qcs): New.
4515         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4516         (validate_flags_qcs): Declare.
4517         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4518         (make_frame_apply_options_def_group): New.
4519         (frame_apply_command_count): Process options with
4520         gdb::option::process_options.
4521         (frame_apply_completer): New.
4522         (frame_apply_level_completer, frame_apply_all_completer)
4523         (frame_apply_completer): New.
4524         (_initialize_stack): Update help of "frame apply", "frame apply
4525         level", "frame apply all" and "faas" to mention supported options
4526         and install command completers.
4527         * stack.h (frame_apply_all_completer): Declare.
4528         * thread.c: Include "stack.h".
4529         (tfaas_command): Add "--".
4530         (_initialize_thread): Update help "tfaas" to mention supported
4531         options and install command completer.
4532
4533 2019-06-13  Pedro Alves  <palves@redhat.com>
4534
4535         * completer.c (complete_nested_command_line): New.
4536         (gdb_completion_word_break_characters_throw): Add assertion.
4537         * completer.h (complete_nested_command_line): Declare.
4538
4539 2019-06-13  Pedro Alves  <palves@redhat.com>
4540
4541         * stack.c (parse_backtrace_qualifiers): New.
4542         (backtrace_command): Use it.
4543         (backtrace_command_completer): Complete on qualifiers.
4544
4545 2019-06-13  Pedro Alves  <palves@redhat.com>
4546
4547         * frame.c: Include "cli/cli-option.h.
4548         (user_set_backtrace_options): New.
4549         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4550         Delete.
4551         (get_prev_frame): Adjust.
4552         (boolean_option_def, uinteger_option_def)
4553         (set_backtrace_option_defs): New.
4554         (_initialize_frame): Adjust and use
4555         gdb::option::add_setshow_cmds_for_options to install "set
4556         backtrace past-main" and "set backtrace past-entry".
4557         * frame.h: Include "cli/cli-option.h".
4558         (struct frame_print_options): Forward declare.
4559         (print_frame_arguments_all, print_frame_arguments_scalars)
4560         (print_frame_arguments_none): Declare.
4561         (print_entry_values): Delete declaration.
4562         (struct frame_print_options, user_frame_print_options): New.
4563         (struct set_backtrace_options): New.
4564         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4565         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4566         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4567         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4568         (list_args_or_locals): Add frame_print_options parameter.
4569         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4570         * python/py-framefilter.c (enumerate_args): Pass down
4571         USER_FRAME_PRINT_OPTIONS.
4572         * stack.c: Include "cli/cli-option.h".
4573         (print_frame_arguments_all, print_frame_arguments_scalars)
4574         (print_frame_arguments_none): Declare.
4575         (print_raw_frame_arguments, print_entry_values): Delete.
4576         (user_frame_print_options): New.
4577         (boolean_option_def, enum_option_def, frame_print_option_defs):
4578         New.
4579         (struct backtrace_cmd_options): New.
4580         (bt_flag_option_def): New.
4581         (backtrace_command_option_defs): New.
4582         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4583         (print_frame_arg, read_frame_arg, print_frame_args)
4584         (print_frame_info, print_frame): Add frame_print_options parameter
4585         and use it.
4586         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4587         (backtrace_command_1): Add frame_print_options and
4588         backtrace_cmd_options parameters and use them.
4589         (make_backtrace_options_def_group): New.
4590         (backtrace_command): Process command options with
4591         gdb::option::process_options.
4592         (backtrace_command_completer): New.
4593         (_initialize_stack): Extend "backtrace"'s help to mention
4594         supported options.  Install completer for "backtrace".
4595         Install some settings commands with add_setshow_cmds_for_options.
4596
4597 2019-06-13  Pedro Alves  <palves@redhat.com>
4598
4599         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4600         and that "set/show print raw frame-arguments" are now deprecated.
4601
4602         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4603         command.
4604         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4605         * stack.c (_initialize_stack): Install "set/show print
4606         raw-frame-arguments", and deprecate "set/show print raw
4607         frame-arguments".
4608         * valprint.c (_initialize_valprint): Deprecate "set/show print
4609         raw".
4610
4611 2019-06-13  Pedro Alves  <palves@redhat.com>
4612
4613         * compile/compile.c (struct compile_options): New.
4614         (compile_flag_option_def, compile_command_option_defs)
4615         (make_compile_options_def_group): New.
4616         (compile_file_command): Handle options with
4617         gdb::option::process_options.
4618         (compile_file_command_completer): New function.
4619         (compile_code_command): Handle options with
4620         gdb::option::process_options.
4621         (compile_code_command_completer): New function.
4622         (_initialize_compiler): Install completers for "compile code" and
4623         "compile file".  Mention available options in "compile code" and
4624         "compile code"'s help.
4625         * completer.c (advance_to_completion_word): New, factored out from
4626         ...
4627         (advance_to_expression_complete_word_point): ... this.
4628         (advance_to_filename_complete_word_point): New.
4629         * completer.h (advance_to_filename_complete_word_point): New
4630         declaration.
4631
4632 2019-06-13  Pedro Alves  <palves@redhat.com>
4633
4634         * compile/compile.c: Include "cli/cli-option.h".
4635         (compile_print_value): Scope data pointer is now a
4636         value_print_options pointer; adjust.
4637         (compile_print_command): Process options.  Scope data pointer is
4638         now a value_print_options pointer; adjust.
4639         (_initialize_compile): Update "compile print"'s help to include
4640         supported options.  Install a completer for "compile print".
4641         * cp-valprint.c (show_vtblprint, show_objectprint)
4642         (show_static_field_print): Delete.
4643         (_initialize_cp_valprint): Don't install "set print
4644         static-members", "set print vtbl", "set print object" here.
4645         * printcmd.c: Include "cli/cli-option.h" and
4646         "common/gdb_optional.h".
4647         (print_command_parse_format): Rework to fill in a
4648         value_print_options instead of a format_data.
4649         (print_value): Change parameter type from format_data pointer to
4650         value_print_options reference.  Adjust.
4651         (print_command_1): Process options.  Adjust to pass down a
4652         value_print_options.
4653         (print_command_completer): New.
4654         (_initialize_printcmd): Install print_command_completer as
4655         handle_brkchars completer for the "print" command.  Update
4656         "print"'s help to include supported options.
4657         * valprint.c: Include "cli/cli-option.h".
4658         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4659         here from cp-valprint.c.
4660         (boolean_option_def, uinteger_option_def)
4661         (value_print_option_defs, make_value_print_options_def_group):
4662         New.  Use gdb::option::add_setshow_cmds_for_options to install
4663         "set print elements", "set print null-stop", "set print repeats",
4664         "set print pretty", "set print union", "set print array", "set
4665         print address", "set print symbol", "set print array-indexes".
4666         * valprint.h: Include <string> and "cli/cli-option.h".
4667         (make_value_print_options_def_group): Declare.
4668         (print_value): Change parameter type from format_data pointer to
4669         value_print_options reference.
4670         (print_command_completer): Declare.
4671
4672 2019-06-13  Pedro Alves  <palves@redhat.com>
4673
4674         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4675         (COMMON_SFILES): Add maint-test-settings.c.
4676         * cli/cli-decode.c (boolean_enums): New global, factored out from
4677         ...
4678         (add_setshow_boolean_cmd): ... here.
4679         * cli/cli-decode.h (boolean_enums): Declare.
4680         * cli/cli-option.c: New file.
4681         * cli/cli-option.h: New file.
4682         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4683         factored out from ...
4684         (parse_cli_boolean_value(const char *)): ... this.
4685         (is_unlimited_literal): Change parameter type to pointer to
4686         pointer.  Adjust and advance ARG pointer.
4687         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4688         (parse_cli_var_enum): New, factored out from ...
4689         (do_set_command): ... this.  Adjust.
4690         * cli/cli-setshow.h (parse_cli_boolean_value)
4691         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4692         (parse_cli_var_enum): Declare.
4693         * cli/cli-utils.c: Include "cli/cli-option.h".
4694         (get_ulongest): New.
4695         * cli/cli-utils.h (get_ulongest): Declare.
4696         (check_for_argument): New overloads.
4697         * maint-test-options.c: New file.
4698
4699 2019-06-13  Pedro Alves  <palves@redhat.com>
4700
4701         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4702         parse a range if "-" is at the end of the string.
4703
4704 2019-06-13  Pedro Alves  <palves@redhat.com>
4705
4706         * cli/cli-setshow.c (parse_auto_binary_operation)
4707         (parse_cli_boolean_value): Don't allow "o".
4708
4709 2019-06-13  Pedro Alves  <palves@redhat.com>
4710
4711         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4712         * NEWS: Mention maint test-settings KIND.
4713         * maint-test-settings.c: New file.
4714
4715 2019-06-13  Pedro Alves  <palves@redhat.com>
4716
4717         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4718         completer.
4719         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4720         "set" completers.
4721
4722 2019-06-13  Pedro Alves  <palves@redhat.com>
4723
4724         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4725         after item.
4726
4727 2019-06-13  Pedro Alves  <palves@redhat.com>
4728
4729         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4730
4731 2019-06-13  Pedro Alves <palves@redhat.com>
4732
4733         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4734         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4735         call.
4736         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4737         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4738         calls.
4739         (check_for_argument): Skip spaces after argument.
4740
4741 2019-06-13  Pedro Alves  <palves@redhat.com>
4742
4743         * thread.c (thread_apply_command): Adjust TID parsing.
4744         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4745         detected before end of string.
4746         (tid_is_in_list): Error out if LIST is invalid.
4747
4748 2019-06-13  Pedro Alves  <palves@redhat.com>
4749
4750         * completer.c (complete_line_internal_1): Rewind completion word
4751         point.
4752         (completion_tracker::advance_custom_word_point_by): Change
4753         parameter type to int.
4754         * completer.h (completion_tracker::advance_custom_word_point_by):
4755         Likewise.
4756
4757 2019-06-13  Pedro Alves  <palves@redhat.com>
4758
4759         * completer.c (advance_to_completion_word): Handle delimiters.
4760
4761 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4762
4763         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4764
4765 2019-06-11  Tom Tromey  <tom@tromey.com>
4766
4767         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4768         (xmalloc_failed): Move to alloc.c.
4769         * alloc.c: New file.
4770         * Makefile.in (COMMON_SFILES): Add alloc.c.
4771
4772 2019-06-11  Tom Tromey  <tom@tromey.com>
4773
4774         * nat/linux-waitpid.c: Don't include server.h.
4775         (linux_debug): Remove.
4776         (my_waitpid): Update.
4777
4778 2019-06-11  Tom Tromey  <tromey@adacore.com>
4779
4780         * infcall.c (_initialize_infcall): Remove trailing newline from
4781         help.
4782         * user-regs.c (_initialize_user_regs): Remove trailing newline
4783         from help.
4784         * typeprint.c (_initialize_typeprint): Remove trailing newline
4785         from help.
4786         * reverse.c (_initialize_reverse): Remove trailing newlines from
4787         help.
4788         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4789         from help.
4790         * language.c (add_set_language_command): Remove trailing newline
4791         from help.
4792         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4793         help.
4794         * disasm.c (_initialize_disasm): Remove trailing newline from
4795         help.
4796         * top.c (init_main): Remove trailing newline from help.
4797         * interps.c (_initialize_interpreter): Remove trailing newline
4798         from help.
4799         * btrace.c (_initialize_btrace): Remove trailing newlines from
4800         help.
4801         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4802         from help.
4803         * python/python.c (_initialize_python): Remove trailing newline
4804         from help.
4805         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4806         help.
4807         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4808         from help.  Reformat some text.
4809         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4810         from help.
4811         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4812         newline from help.
4813
4814 2019-06-11  Tom Tromey  <tromey@adacore.com>
4815
4816         * darwin-nat.c (darwin_decode_exception_message)
4817         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4818
4819 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * valops.c (value_slice): Check for not allocated or not
4822         associated values.
4823
4824 2019-06-10  Tom de Vries  <tdevries@suse.de>
4825
4826         PR gdb/24618
4827         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4828         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4829         invalid.
4830
4831 2019-06-10  Tom de Vries  <tdevries@suse.de>
4832
4833         PR gdb/24611
4834         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4835         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4836
4837 2019-06-10  Tom de Vries  <tdevries@suse.de>
4838
4839         PR symtab/24545
4840         * symtab.c (struct demangled_name_entry): Add language field.
4841         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4842         static minimal symbol".  Set and use language field.
4843
4844 2019-06-10  Tom Tromey  <tromey@adacore.com>
4845
4846         * ada-lang.c (_initialize_ada_language): Update help text.
4847
4848 2019-06-10  Tom Tromey  <tromey@adacore.com>
4849
4850         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4851         with a newline.
4852         * guile/guile.c (handle_boot_error): Don't end warning with a
4853         newline.
4854         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4855         warning with a newline.
4856         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4857         newline.
4858         (s12z_frame_cache): Likewise.
4859         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4860         a newline.
4861         * solib-svr4.c (disable_probes_interface): Don't end warning with
4862         a newline.
4863         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4864         newline.
4865         * python/python.c (do_finish_initialization): Don't end warning
4866         with a newline.
4867
4868 2019-06-10  Tom Tromey  <tom@tromey.com>
4869
4870         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4871         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4872         gdbpy_enter.
4873
4874 2019-06-10  Tom Tromey  <tromey@adacore.com>
4875
4876         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4877         data.
4878         (elf_new_init): Don't call stabsread_new_init.
4879         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4880         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4881         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4882
4883 2019-06-10  Tom de Vries  <tdevries@suse.de>
4884
4885         PR symtab/16264
4886         PR symtab/24517
4887         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4888
4889 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4890
4891         * source.c (find_and_open_source): Also rewrite relative file
4892         names.
4893
4894 2019-04-26  Amos Bird  <amosbird@gmail.com>
4895
4896         * annotate.c (annotate_thread_exited): Add "thread-exited"
4897         annotation.
4898
4899 2019-06-06  Tom Tromey  <tromey@adacore.com>
4900
4901         * maint.h (class scoped_command_stats): Use
4902         DISABLE_COPY_AND_ASSIGN.
4903         <print_time>: New method.
4904         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4905         print_time.
4906         (scoped_command_stats::print_time): New method.
4907
4908 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4909
4910         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4911         instructions of lengths 6 or 8 bytes.
4912
4913 2019-06-04  Pedro Alves  <palves@redhat.com>
4914
4915         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4916
4917         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4918         * breakpoint.c (condition_completer): Likewise.
4919         * cli/cli-dump.c (scan_expression): Likewise.
4920         * common/filestuff.c (mkdir_recursive): Likewise.
4921         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4922         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4923         (gdb_abspath): Likewise.
4924         * compile/compile-cplus-types.c
4925         (compile_cplus_instance::decl_name): Likewise.
4926         * completer.c (complete_explicit_location):
4927         (signal_completer, reg_or_group_completer_1): Likewise.
4928         * cp-support.c (cp_remove_params_if_any): Likewise.
4929         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4930         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4931         * infcmd.c (strip_bg_char): Likewise.
4932         * linespec.c (copy_token_string): Likewise.
4933         * mi/mi-main.c (output_cores): Likewise.
4934         * psymtab.c (psymtab_search_name):
4935         * symfile.c (test_set_ext_lang_command): Likewise.
4936         * target.c (target_fileio_read_stralloc): Likewise.
4937         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4938         * value.c (complete_internalvar): Likewise.
4939
4940 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4941
4942         Add objfile property to gdb.Type.
4943         * NEWS: Mention Python API addition.
4944         * python/py-type.c (typy_get_objfile): New method.
4945
4946 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4947
4948         * NEWS: Mention the new set|show style [title|highlight].
4949         Mention changes to "show style", "help" and "apropos".
4950
4951 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4952
4953         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4954         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4955         instead of print_help_for_command.
4956         (print_doc_of_command): New function.
4957         (help_list): Add 'apropos -v word' suggestion.
4958         (print_help_for_command): Style the command name using title style.
4959         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4960         (_initialize_cli_cmds): Describe -v in apropos_command help.
4961
4962 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4963
4964         * cli/cli-style.h (cli_style_option): Add name in constructor,
4965         add m_name class member, add constructor with intensity,
4966         add name class function.
4967         (cli_style_option::add_setshow_commands): Remove name argument.
4968         (highlight_style, title_style): New styles.
4969         * cli/cli-style.c (do_show): New function that shows a style
4970         characteristic styling the style name with itself.
4971         (set_style_name): New function.
4972         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4973         Update all callers according to the changes in cli/cli-style.h.
4974         * utils.h (fputs_highlighted): New function.
4975         * utils.c (fputs_highlighted): Likewise.
4976
4977 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4978
4979         * NEWS: Mention new pipe command and new convenience variables.
4980
4981 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4982
4983         * cli/cli-cmds.c (pipe_command): New function.
4984         (_initialize_cli_cmds): Call add_com for pipe_command.
4985         Define | as an alias for pipe.
4986         (exit_status_set_internal_vars): New function.
4987         (shell_escape): Call exit_status_set_internal_vars.
4988         cli/cli-decode.c (find_command_name_length): Recognize | as
4989         a single character command.
4990
4991 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4992
4993         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4994         top.c (execute_command_to_ui_file): New function, mostly a copy
4995         of execute_command_to_string.
4996         (execute_command_to_string): Implement by calling
4997         execute_command_to_ui_file.
4998
4999 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5000
5001         * top.h (saved_command_line): Remove declaration.
5002         * top.c (previous_saved_command_line, previous_repeat_arguments):
5003         New variables.
5004         (saved_command_line): Make static, define together with other
5005         'repeat variables'.
5006         (dont_repeat): Clear repeat_arguments.
5007         (repeat_previous, get_saved_command_line, save_command_line):
5008         New functions.
5009         (gdb_init): Initialize saved_command_line
5010         and previous_saved_command_line.
5011         * main.c (captured_main_1): Remove saved_command_line initialization.
5012         * event-top.c (handle_line_of_input): Update to use
5013         the new 'repeat' related functions instead of direct access to
5014         saved_command_line.
5015         * command.h (repeat_previous, get_saved_command_line,
5016         save_command_line): New declarations.
5017         (dont_repeat): Add comment.
5018
5019 2019-05-30  Tom Tromey  <tromey@adacore.com>
5020
5021         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5022         Fix comment.
5023         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5024
5025 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5026
5027         PR cli/24587
5028         * completer.c (complete): Initialize variable word.
5029
5030 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5031
5032         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5033         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5034         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5035         'body' is NULL to the outter 'if', protecting the '!is_define'
5036         situation as well.
5037
5038 2019-05-29  Tom Tromey  <tromey@adacore.com>
5039
5040         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5041         (dwarf_unknown): New function.
5042         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5043         (dwarf_type_encoding_name): Use dwarf_unknown.
5044
5045 2019-05-29  Tom Tromey  <tromey@adacore.com>
5046
5047         PR c++/20020:
5048         * cp-valprint.c (cp_print_value_fields): Call
5049         cp_print_static_field inside "try".
5050
5051 2019-05-29  Tom Tromey  <tromey@adacore.com>
5052
5053         * inflow.c (struct terminal_info): Add default operator=.
5054         * configure: Rebuild.
5055         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5056         -Wdeprecated-copy-dtor, -Wredundant-move.
5057
5058 2019-05-29  Tom Tromey  <tromey@adacore.com>
5059
5060         * NEWS: Add entry.
5061         * infcmd.c (print_return_value_1): Handle finish_print
5062         option.
5063         (show_print_finish): New function.
5064         (_initialize_infcmd): Add "set/show print finish" commands.
5065         * valprint.c (user_print_options): Initialize new member.
5066         * valprint.h (struct value_print_options) <finish_print>: New
5067         member.
5068
5069 2019-05-28  Tom Tromey  <tromey@adacore.com>
5070
5071         * ada-lang.c (ada_remove_Xbn_suffix)
5072         (find_old_style_renaming_symbol)
5073         (parse_old_style_renaming): Remove.
5074         (ada_find_renaming_symbol): Don't call
5075         find_old_style_renaming_symbol.
5076         (ada_is_renaming_symbol): Rename from
5077         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5078         bool.  Now static.
5079         (ada_read_var_value): Update and simplify.
5080         * ada-exp.y (write_var_or_type): Remove old code.
5081
5082 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5083
5084         * event-top.c: Remove include comment.
5085         * inflow.c (class scoped_ignore_sigttou): Move from here...
5086         * inflow.h (class scoped_ignore_sigttou): ...to here.
5087         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5088         * top.c:  Remove include comment.
5089
5090 2019-05-27  Tom Tromey  <tom@tromey.com>
5091
5092         * NEWS: Fix typo.
5093
5094 2019-05-22  Tom Tromey  <tromey@adacore.com>
5095
5096         * target.c (target_follow_exec): Constify parameter.
5097         * target-delegates.c: Rebuild.
5098         * remote.c (remote_target::follow_exec): Constify parameter.
5099         * infrun.c (follow_exec): Constify parameter.
5100         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5101         (target_follow_exec): Likewise.
5102
5103 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5104
5105         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5106         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5107
5108 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5109
5110         * NEWS: Add debugredirect and testsuite sections.
5111
5112 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5113
5114         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5115         target descriptions using exclusively floating point register name
5116         aliases.
5117
5118 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5119
5120         PR gdb/18644:
5121         * f-lang.c (build_fortran_types): Handle the case where
5122         gdbarch_floatformat_for_type returns a nullptr.
5123
5124 2019-05-21  Tom de Vries  <tdevries@suse.de>
5125
5126         PR cli/24587
5127         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5128
5129 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5130
5131         PR gdb/18644:
5132         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5133         16-byte floats.
5134         * i386-tdep.c (i386_floatformat_for_type): Use
5135         floatformats_ia64_quad for the 16-byte floating point component
5136         within a fortran 32-byte complex number.
5137
5138 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5139
5140         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5141         delete default constructor.
5142         (find_partial_die): Update to return const struct.
5143         (partial_die_parent_scope): Move variable declaration into scope
5144         of its use and change its type to auto.
5145         (guess_partial_die_structure_name): Likewise.
5146         (partial_die_info::fixup): Likewise.
5147
5148 2019-05-17  Tom Tromey  <tromey@adacore.com>
5149
5150         * source.c (find_and_open_source): Remove cast.
5151
5152 2019-05-17  Tom Tromey  <tromey@adacore.com>
5153
5154         * annotate.c (annotate_source): Make "filename" const.
5155         * annotate.h (annotate_source): Use const.
5156
5157 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5158
5159         * disasm.c (set_disassembler_options): Send errors to stderr.
5160
5161 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5162
5163         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5164         (cli_interp_base::set_logging): Check debug_redirect.
5165         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5166         * cli/cli-logging.c (debug_redirect): Add static variable.
5167         (pop_output_files): Add default param.
5168         (handle_redirections): Print debug setting.
5169         (show_logging_command): Likewise.
5170         (_initialize_cli_logging): Add debugredirect command.
5171         * interps.c (current_interp_set_logging): Add debug_redirect
5172         parameter.
5173         * interps.h (set_logging): Add debug_redirect parameter.
5174         (current_interp_set_logging): Likewise.
5175         * mi/mi-common.h: Likewise.
5176         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5177
5178 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5179             Tom Tromey  <tromey@adacore.com>
5180
5181         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5182         directly.
5183         * cli/cli-interp.h (make_logging_output): Remove declaration.
5184         * cli/cli-logging.c (make_logging_output): Remove function.
5185         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5186         directly.
5187         * ui-file.c (tee_file::tee_file): Remove bools.
5188         (tee_file::~tee_file): Remove deletes.
5189         * ui-file.h (tee_file): Remove bools.
5190
5191 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5192
5193         * mi/mi-cmds.h (mi_cmd_complete): New function.
5194         * mi/mi-main.c (mi_cmd_complete): Likewise.
5195         * mi/mi-cmds.c: Define new MI command -complete.
5196         * NEWS: Mention new -complete command.
5197
5198 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5199
5200         * completer.h (complete): New function.
5201         * completer.c (complete): Likewise.
5202         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5203         function defined in completer.h.
5204
5205 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5206
5207         * MAINTAINERS (Write After Approval): Add myself.
5208
5209 2019-05-17  Tom de Vries  <tdevries@suse.de>
5210
5211         PR gdb/24094
5212         * dwarf2read.c (struct cu_partial_die_info): New struct.
5213         (find_partial_die): Return cu_partial_die_info.
5214         (partial_die_parent_scope, guess_partial_die_structure_name)
5215         (partial_die_info::fixup): Handle new return type of find_partial_die.
5216
5217 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5218
5219         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5220         "std::string", simplifying the algorithm.
5221
5222 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5223
5224         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5225         (stap_static_probe_ops::get_probes): Likewise.
5226
5227 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5228
5229         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5230         '-')" and "else if".
5231         (stap_parse_single_operand): Join checks for
5232         "gdbarch_stap_parse_special_token_p" and
5233         "gdbarch_stap_parse_special_token" in the same "if" statement.
5234         Invert check when verifying for operation on register
5235         displacement.
5236
5237 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5238
5239         * stap-probe.c (stap_get_opcode): Update comment.
5240         (stap_get_expected_argument_type): Likewise.
5241         (handle_stap_probe): Likewise.
5242
5243 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5244
5245         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5246         return type to 'bool'.  Adjust comment.  Use 'bool' when
5247         appropriate.
5248         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5249         * stap-probe.c (stap_parse_argument_1): Likewise.
5250         (stap_is_operator): Likewise.
5251         (stap_is_generic_prefix): Likewise.
5252         (stap_is_register_prefix): Likewise.
5253         (stap_is_register_indirection_prefix): Likewise.
5254         (stap_is_integer_prefix): Likewise.
5255         (stap_generic_check_suffix): Likewise.
5256         (stap_check_integer_suffix): Likewise.
5257         (stap_check_register_suffix): Likewise.
5258         (stap_check_register_indirection_suffix): Likewise.
5259         (stap_parse_register_operand): Likewise.
5260         (stap_parse_single_operand): Likewise.
5261         (stap_parse_argument_1): Likewise.
5262         (stap_probe::get_argument_count): Likewise.
5263         (stap_is_operator): Likewise.
5264
5265 2019-05-16  Tom Tromey  <tromey@adacore.com>
5266
5267         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5268         keyword to foreach.
5269
5270 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5271
5272         * linux-thread-db.c (try_thread_db_load_1): Change return type
5273         to bool.
5274         (try_thread_db_load): Likewise.
5275         (try_thread_db_load_from_pdir_1): Likewise.
5276         (try_thread_db_load_from_pdir): Likewise.
5277         (try_thread_db_load_from_sdir): Likewise.
5278         (try_thread_db_load_from_dir): Likewise.
5279         (thread_db_load_search): Likewise.
5280         (has_libpthread): Likewise.
5281         (thread_db_load): Likewise.
5282
5283 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5284
5285         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5286         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5287         NULL, and complain/return if that's the case.
5288
5289 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5290
5291         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5292         (advance, posn, abstract_read_memory): New functions.
5293         [struct mem_read_abstraction]: New struct.
5294         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5295
5296 2019-05-14  Tom Tromey  <tromey@adacore.com>
5297
5298         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5299         value is not lval_memory.
5300
5301 2019-05-14  Tom Tromey  <tromey@adacore.com>
5302
5303         * solib.c (info_sharedlibrary_command): Style the file name.
5304
5305 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5306
5307         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5308         (aarch64_vnv_type): Likewise.
5309         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5310         * common/tdesc.c: Likewise.
5311         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5312         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5313         * features/aarch64-fpu.xml: Add ieee half view.
5314         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5315         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5316         * gdbtypes.h (struct builtin_type): Likewise.
5317         (struct objfile_type): Likewise.
5318
5319 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5320
5321         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5322         typo.
5323         * location.h (string_to_event_location): Likewise.
5324
5325 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5326
5327         GDB 8.3 released.
5328
5329 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5330
5331         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5332         New variable declaration.
5333         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5334         New variable.
5335         (print_one_breakpoint): Use ui_out::test_flags and new global
5336         variable to compute use_fixed_output.
5337         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5338         Remove.
5339         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5340         (mi_multi_location_breakpoint_output_fixed): Remove.
5341         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5342         new variable.
5343         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5344         fix_multi_location_breakpoint_output flag if version >= 3.
5345         * ui-out.h (enum ui_out_flag)
5346         <fix_multi_location_breakpoint_output>: New enumerator.
5347
5348 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5349
5350         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5351
5352 2019-05-10  Tom Tromey  <tromey@adacore.com>
5353
5354         * ada-lang.c (catch_ada_completer): New function.
5355         (_initialize_ada_language): Use it.
5356
5357 2019-05-10  Tom Tromey  <tromey@adacore.com>
5358
5359         * thread.c (print_thread_info): Make "requested_threads" const.
5360         * gdbthread.h (print_thread_info): Make "requested_threads"
5361         const.
5362         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5363         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5364
5365 2019-05-08  Tom Tromey  <tom@tromey.com>
5366
5367         * gdbtypes.c (objfile_type_data): Change type.
5368         (objfile_type, _initialize_gdbtypes): Update.
5369
5370 2019-05-08  Tom Tromey  <tom@tromey.com>
5371
5372         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5373         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5374         (_initialize_dwarf2_frame): Update.
5375
5376 2019-05-08  Tom Tromey  <tom@tromey.com>
5377
5378         * objc-lang.c (objc_objfile_data): Change type.
5379         (find_methods): Update.
5380         (_initialize_objc_lang): Remove.
5381
5382 2019-05-08  Tom Tromey  <tom@tromey.com>
5383
5384         * stabsread.c (rs6000_builtin_type_data): Change type.
5385         (rs6000_builtin_type, _initialize_stabsread): Update.
5386
5387 2019-05-08  Tom Tromey  <tom@tromey.com>
5388
5389         * mips-tdep.c (mips_pdr_data): Remove.
5390         (_initialize_mips_tdep): Update.
5391
5392 2019-05-08  Tom Tromey  <tom@tromey.com>
5393
5394         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5395         (hppa_init_objfile_priv_data, read_unwind_info)
5396         (find_unwind_entry, _initialize_hppa_tdep): Update.
5397
5398 2019-05-08  Tom Tromey  <tom@tromey.com>
5399
5400         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5401         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5402         on obstack.
5403         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5404
5405 2019-05-08  Tom Tromey  <tom@tromey.com>
5406
5407         * mdebugread.c (basic_type_data): Change type.
5408         (basic_type, _initialize_mdebugread): Update.
5409
5410 2019-05-08  Tom Tromey  <tom@tromey.com>
5411
5412         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5413
5414 2019-05-08  Tom Tromey  <tom@tromey.com>
5415
5416         * nto-tdep.c (nto_inferior_data_reg): Change type.
5417         (nto_inferior_data): Update.
5418         (nto_inferior_data_cleanup, nto_new_inferior_data)
5419         (_initialize_nto_tdep): Remove.
5420         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5421
5422 2019-05-08  Tom Tromey  <tom@tromey.com>
5423
5424         * ada-lang.c (struct ada_inferior_data): Add initializers.
5425         (ada_inferior_data): Change type.
5426         (ada_inferior_data_cleanup): Remove.
5427         (get_ada_inferior_data, ada_inferior_exit)
5428         (struct ada_pspace_data): Add initializers, destructor.
5429         (ada_pspace_data_handle): Change type.
5430         (get_ada_pspace_data): Update.
5431         (ada_pspace_data_cleanup): Remove.
5432
5433 2019-05-08  Tom Tromey  <tom@tromey.com>
5434
5435         * coffread.c (struct coff_symfile_info): Add initializers.
5436         (coff_objfile_data_key): Move lower.  Change type.
5437         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5438         Update.
5439         (coff_free_info): Remove.
5440
5441 2019-05-08  Tom Tromey  <tom@tromey.com>
5442
5443         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5444         (fbsd_pspace_data_handle): Move lower.  Change type.
5445         (get_fbsd_pspace_data): Update.
5446         (fbsd_pspace_data_cleanup): Remove.
5447         (_initialize_fbsd_tdep): Update.
5448
5449 2019-05-08  Tom Tromey  <tom@tromey.com>
5450
5451         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5452         (get_ada_tasks_pspace_data): Update.
5453         (ada_tasks_pspace_data_cleanup): Remove.
5454         (_initialize_tasks): Update.
5455         (ada_tasks_inferior_data_handle): Change type.
5456         (get_ada_tasks_inferior_data): Update.
5457         (ada_tasks_inferior_data_cleanup): Remove.
5458         (struct ada_tasks_pspace_data): Add initializers.
5459
5460 2019-05-08  Tom Tromey  <tom@tromey.com>
5461
5462         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5463         * symfile-debug.c (debug_sym_get_probes): Change type.
5464         * stap-probe.c (handle_stap_probe):
5465         (stap_static_probe_ops::get_probes): Change type.
5466         * probe.h (class static_probe_ops) <get_probes>: Change type.
5467         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5468         (parse_probes_in_pspace): Update.
5469         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5470         Update.
5471         (any_static_probe_ops::get_probes): Change type.
5472         * elfread.c (elfread_data): New typedef.
5473         (probe_key): Change type.
5474         (elf_get_probes): Likewise.  Update.
5475         (probe_key_free): Remove.
5476         (_initialize_elfread): Update.
5477         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5478         Change type.
5479         (dtrace_process_dof_probe, dtrace_process_dof)
5480         (dtrace_static_probe_ops::get_probe): Change type.
5481
5482 2019-05-08  Tom Tromey  <tom@tromey.com>
5483
5484         * xcoffread.c (struct xcoff_symfile_info): Rename from
5485         coff_symfile_info.  Add initializers.
5486         (xcoff_objfile_data_key): Move lower.  Change type.
5487         (XCOFF_DATA): Rewrite.
5488         (xcoff_free_info): Remove.
5489         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5490         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5491         (xcoff_initial_scan): Update.
5492
5493 2019-05-08  Tom Tromey  <tom@tromey.com>
5494
5495         * solib-svr4.c (struct svr4_info): Add initializers and
5496         destructor.
5497         <probes_table>: Now an htab_up.
5498         (solib_svr4_pspace_data): Change type.
5499         (free_probes_table): Simplify.
5500         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5501         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5502         (probes_table_remove_objfile_probes, register_solib_event_probe)
5503         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5504         (_initialize_svr4_solib): Update.
5505
5506 2019-05-08  Tom Tromey  <tom@tromey.com>
5507
5508         * remote.c (remote_pspace_data): Change type.
5509         (remote_pspace_data_cleanup): Remove.
5510         (get_remote_exec_file, set_pspace_remote_exec_file)
5511         (_initialize_remote): Update.
5512
5513 2019-05-08  Tom Tromey  <tom@tromey.com>
5514
5515         * breakpoint.c (breakpoint_objfile_key): Change type.
5516         (get_breakpoint_objfile_data): Update.
5517         (free_breakpoint_objfile_data): Remove.
5518         (_initialize_breakpoint): Update.
5519
5520 2019-05-08  Tom Tromey  <tom@tromey.com>
5521
5522         * linux-tdep.c (struct linux_info): Add initializers.
5523         (linux_inferior_data): Move.  Change type.
5524         (invalidate_linux_cache_inf): Update.
5525         (linux_inferior_data_cleanup): Remove.
5526         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5527
5528 2019-05-08  Tom Tromey  <tom@tromey.com>
5529
5530         * auxv.c (auxv_inferior_data): Move.  Change type.
5531         (auxv_inferior_data_cleanup): Remove.
5532         (invalidate_auxv_cache_inf): Rewrite.
5533         (get_auxv_inferior_data, _initialize_auxv): Update.
5534
5535 2019-05-08  Tom Tromey  <tom@tromey.com>
5536
5537         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5538         (symfile_debug_objfile_data_key): Change type.
5539         (symfile_debug_installed, debug_qf_has_symbols)
5540         (debug_qf_find_last_source_symtab)
5541         (debug_qf_forget_cached_source_info)
5542         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5543         (debug_qf_print_stats, debug_qf_dump)
5544         (debug_qf_expand_symtabs_for_function)
5545         (debug_qf_expand_all_symtabs)
5546         (debug_qf_expand_symtabs_with_fullname)
5547         (debug_qf_map_matching_symbols)
5548         (debug_qf_expand_symtabs_matching)
5549         (debug_qf_find_pc_sect_compunit_symtab)
5550         (debug_qf_map_symbol_filenames)
5551         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5552         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5553         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5554         (debug_sym_read_linetable, debug_sym_relocate): Update.
5555         (symfile_debug_free_objfile): Remove.
5556         (install_symfile_debug_logging, _initialize_symfile_debug):
5557         Update.
5558
5559 2019-05-08  Tom Tromey  <tom@tromey.com>
5560
5561         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5562         allocate_on_obstack.
5563         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5564         (get_dwarf2_per_objfile): Update.
5565         (set_dwarf2_per_objfile): Remove.
5566         (dwarf2_has_info, dwarf2_get_section_info): Update.
5567         (dwarf2_free_objfile): Remove.
5568         (_initialize_dwarf2_read): Update.
5569
5570 2019-05-08  Tom Tromey  <tom@tromey.com>
5571
5572         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5573         initializers.
5574         <unsupported_script_warning_printed,
5575         script_not_found_warning_printed>: Now bool.
5576         (auto_load_pspace_data): Change type.
5577         (~auto_load_pspace_info): Rename from
5578         auto_load_pspace_data_cleanup.
5579         (get_auto_load_pspace_data, init_loaded_scripts_info)
5580         (clear_section_scripts, maybe_print_unsupported_script_warning)
5581         (maybe_print_script_not_found_warning, _initialize_auto_load):
5582         Update.
5583
5584 2019-05-08  Tom Tromey  <tom@tromey.com>
5585
5586         * objfiles.c (objfile_pspace_info): Add destructor and
5587         initializers.
5588         (objfiles_pspace_data): Change type.
5589         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5590         (get_objfile_pspace_data): Update.
5591         (objfiles_bfd_data): Change type.
5592         (get_objfile_bfd_data): Update.
5593         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5594
5595 2019-05-08  Tom Tromey  <tom@tromey.com>
5596
5597         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5598         Change type.
5599         (get_catch_syscall_inferior_data): Update.
5600         (catch_syscall_inferior_data_cleanup): Remove.
5601         (_initialize_break_catch_syscall): Update.
5602
5603 2019-05-08  Tom Tromey  <tom@tromey.com>
5604
5605         * inflow.c (struct terminal_info): Add destructor and
5606         initializers.
5607         (inflow_inferior_data): Change type.
5608         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5609         (get_inflow_inferior_data, inflow_inferior_exit)
5610         (swap_terminal_info, _initialize_inflow): Update.
5611
5612 2019-05-08  Tom Tromey  <tom@tromey.com>
5613
5614         * target-dcache.c (target_dcache_cleanup): Remove.
5615         (target_dcache_aspace_key): Change type.
5616         (target_dcache_init_p, target_dcache_invalidate)
5617         (target_dcache_get, target_dcache_get_or_init)
5618         (_initialize_target_dcache): Update.
5619         * dcache.h (struct dcache_deleter): New.
5620
5621 2019-05-08  Tom Tromey  <tom@tromey.com>
5622
5623         * symtab.c (struct symbol_cache): Add destructor and
5624         initializers.
5625         (symbol_cache_key): Move.  Change type.
5626         (make_symbol_cache, free_symbol_cache): Remove.
5627         (get_symbol_cache): Update.
5628         (symbol_cache_cleanup): Remove.
5629         (ALL_PSPACES, symbol_cache_flush)
5630         (maintenance_print_symbol_cache)
5631         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5632         Update.
5633
5634 2019-05-08  Tom Tromey  <tom@tromey.com>
5635
5636         * symtab.c (struct main_info): Add destructor and initializers.
5637         (main_progspace_key): Move.  Change type.
5638         (get_main_info): Update.
5639         (main_info_cleanup): Remove.
5640         (_initialize_symtab): Update.
5641
5642 2019-05-08  Tom Tromey  <tom@tromey.com>
5643
5644         * registry.h (DECLARE_REGISTRY): Define the _key class.
5645
5646 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5647
5648         * NEWS: Merge two 'New commands' sections.
5649
5650 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5651
5652         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5653         parameter and use Ada language definition instead.
5654         (ada_val_print_ptr): Remove unused language parameter.
5655         (ada_val_print_num): Remove language parameter and use Ada language
5656         definition instead.
5657         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5658         parameter.
5659         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5660         parameter and use Ada language definition instead.
5661         (ada_val_print_1): Update all ada_val_print_xxx calls.
5662         Remove language parameter.
5663         (ada_val_print): Update ada_val_print_1 call.
5664
5665 2019-05-08  Tom Tromey  <tromey@adacore.com>
5666
5667         * remote.c (remote_hw_watchpoint_limit)
5668         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5669         Now static.
5670
5671 2019-05-08  Tom Tromey  <tromey@adacore.com>
5672
5673         * maint.c (_initialize_maint_cmds): Move initialization code to
5674         remote.c.
5675         (watchdog, show_watchdog): Move to remote.c.
5676         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5677         "watchdog" static.
5678         (_initialize_remote): Move initialization code from maint.c.
5679         * defs.h (watchdog): Don't declare.
5680
5681 2019-05-08  Tom Tromey  <tromey@adacore.com>
5682
5683         * tui/tui-interp.c: Include main.h.
5684         * interps.c: Include main.h.
5685         * main.h (interpreter_p): Declare.
5686         * defs.h (interpreter_p): Don't declare.
5687
5688 2019-05-08  Tom Tromey  <tromey@adacore.com>
5689
5690         * dwarf2loc.c: Include dwarf2read.h.
5691         * defs.h (read_unsigned_leb128): Don't declare.
5692         * dwarf2read.h (read_unsigned_leb128): Declare.
5693
5694 2019-05-08  Tom Tromey  <tromey@adacore.com>
5695
5696         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5697         method.
5698
5699 2019-05-08  Tom Tromey  <tromey@adacore.com>
5700
5701         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5702         when no wrap column is set.
5703
5704 2019-05-08  Tom Tromey  <tromey@adacore.com>
5705
5706         * c-lang.c (c_get_string): Handle non-C-style arrays.
5707
5708 2019-05-08  Tom Tromey  <tromey@adacore.com>
5709
5710         * typeprint.c (print_offset_data::update): Print the bit offset,
5711         not the number of bits remaining.
5712
5713 2019-05-08  Tom Tromey  <tromey@adacore.com>
5714
5715         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5716         padding at end of comment.
5717
5718 2019-05-08  Tom Tromey  <tromey@adacore.com>
5719
5720         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5721         Compare main types.
5722
5723 2019-05-06  Tom Tromey  <tom@tromey.com>
5724
5725         * common/scoped_mmap.c: Include common-defs.h.
5726         * common/scoped_mmap.h: Don't include config.h.
5727
5728 2019-05-04  Tom Tromey  <tom@tromey.com>
5729
5730         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5731         (struct aarch64_call_info): Add initializers.
5732         <si>: Now a std::vector.
5733         (pass_on_stack, aarch64_push_dummy_call): Update.
5734
5735 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5736             Tom Tromey  <tom@tromey.com>
5737
5738         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5739         (ppc_threads): Now a std::vector.  Now static.
5740         (hwdebug_find_thread_points_by_tid)
5741         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5742         Update.
5743
5744 2019-05-04  Tom Tromey  <tom@tromey.com>
5745
5746         * arc-tdep.c (arc_tdesc_init): Return bool.
5747
5748 2019-05-04  Tom Tromey  <tom@tromey.com>
5749
5750         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5751         Use gdb_assert_not_reached.
5752
5753 2019-05-04  Tom Tromey  <tom@tromey.com>
5754
5755         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5756         "false".
5757
5758 2019-05-04  Tom Tromey  <tom@tromey.com>
5759
5760         * arc-tdep.c (arc_tdesc_init): Use bool.
5761
5762 2019-05-04  Tom Tromey  <tom@tromey.com>
5763
5764         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5765
5766 2019-05-04  Tom Tromey  <tom@tromey.com>
5767
5768         * cli/cli-cmds.c (valid_command_p): Return bool.
5769
5770 2019-05-04  Tom Tromey  <tom@tromey.com>
5771
5772         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5773         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5774
5775 2019-05-04  Raul Tambre  <raul@tambre.ee>
5776
5777         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5778         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5779         operator for comparison.
5780
5781 2019-05-04  Tom Tromey  <tom@tromey.com>
5782
5783         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5784         (lookup_partial_symbol, print_partial_symbols)
5785         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5786         (psymbol_compare): Update.
5787         (add_psymbol_to_bcache): Clear the entire psymbol.
5788         (maintenance_check_psymtabs): Update.
5789         * psympriv.h (struct partial_symbol): Don't derive from
5790         general_symbol_info.
5791         <obj_section, unrelocated_address, address,
5792         set_unrelocated_address>: Update.
5793         <ginfo>: New member.
5794         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5795         (debug_names::write_psymbols): Update.
5796
5797 2019-05-04  Tom de Vries  <tdevries@suse.de>
5798
5799         * contrib/cc-with-tweaks.sh: Support -n arg.
5800
5801 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5802
5803         * corelow.c (core_target::detach): Ensure frame cache and
5804         register caches are cleared.
5805         inferior.c (exit_inferior_1): Likewise.
5806
5807 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5808             Tom Tromey  <tom@tromey.com>
5809
5810         * dictionary.c (collate_pending_symbols_by_language): Remove
5811         "struct" from foreach.
5812         * symtab.c (lookup_global_symbol_from_objfile)
5813         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5814         foreach.
5815         * ser-tcp.c (net_open): Remove "struct" from foreach.
5816         * objfiles.c (objfile_relocate, objfile_rebase)
5817         (objfile_has_symbols): Remove "struct" from foreach.
5818         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5819         from foreach.
5820         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5821         foreach.
5822         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5823         "struct" from foreach.
5824         * ada-lang.c (create_excep_cond_exprs)
5825         (ada_exception_catchpoint_cond_string): Remove "struct" from
5826         foreach.
5827
5828 2019-05-03  Tom Tromey  <tromey@adacore.com>
5829
5830         * ada-exp.y (convert_char_literal): Check suffix of each
5831         enumerator.
5832
5833 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5834
5835         PR ada/21406:
5836         * ada-exp.y (yywrap): Don't define.
5837         * ada-lex.l (%option): Add noyywrap
5838         (yywrap): Remove.
5839
5840 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5841
5842         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5843         _WIN32_WINNT to the XP level, unless already defined to a higher
5844         level.
5845
5846         * unittests/parse-connection-spec-selftests.c:
5847         * ser-tcp.c:
5848         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5849         override.
5850
5851         * symfile.c (find_separate_debug_file): Remove colon from the
5852         drive spec of DOS/Windows file names of the target, so that the
5853         file name produced from DEBUGDIR and the target's directory will
5854         be valid on DOS/Windows systems.
5855
5856 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5857
5858         * rust-lang.c (val_print_struct): Handle printing structures
5859         containing strings.
5860
5861 2019-05-02  Tom Tromey  <tromey@adacore.com>
5862
5863         * valarith.c (_initialize_valarith): Remove.
5864
5865 2019-05-01  Tom Tromey  <tromey@adacore.com>
5866
5867         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5868         bitfields.
5869
5870 2019-05-01  Tom Tromey  <tromey@adacore.com>
5871
5872         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5873         for big-endian copies.
5874
5875 2019-04-30  Ali Tamur  <tamur@google.com>
5876         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5877         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5878         (read_3_bytes): New function.
5879
5880 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5881
5882         * windows-nat.c (main_thread_id): Delete.
5883         (handle_output_debug_string): Replace main_thread_id by
5884         current_event.dwThreadId.
5885         (fake_create_process): Likewise.
5886         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5887         Do not set main_thread_id.
5888         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5889         current_event.dwThreadId.
5890         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5891
5892 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5893
5894         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5895         Use current_event.dwThreadId instead of main_thread_id.
5896
5897 2019-04-30  Tom Tromey  <tromey@adacore.com>
5898
5899         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5900         (create_excep_cond_exprs): Iterate over program spaces.
5901         (ada_exception_catchpoint_cond_string): Examine all minimal
5902         symbols for exception types.
5903
5904 2019-04-30  Tom Tromey  <tromey@adacore.com>
5905
5906         PR c++/24470:
5907         * dwarf2read.c (process_structure_scope): Handle case where type
5908         has template parameters but no symbol was created.
5909
5910 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5911             Chris January  <chris.january@arm.com>
5912
5913         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5914         qualifier.
5915         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5916
5917 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5918
5919         * f-typeprint.c (f_print_type): Update rules for printing
5920         whitespace.
5921         (f_type_print_varspec_suffix): Likewise.
5922
5923 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5924             Chris January  <chris.january@arm.com>
5925
5926         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5927         function arguments.
5928
5929 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5930
5931         * f-lang.c (build_fortran_types): Change name of void type to
5932         lower case.
5933         * f-typeprint.c (f_type_print_base): Print the name of the void
5934         type, rather than a fixed string.
5935         * f-valprint.c (f_decorations): Use lower case void string.
5936
5937 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5938             Chris January  <chris.january@arm.com>
5939
5940         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5941         types for Fortran.
5942
5943 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5944             Chris January  <chris.january@arm.com>
5945             David Lecomber  <david.lecomber@arm.com>
5946
5947         * f-exp.y (BINOP_INTRINSIC): New token.
5948         (exp): New parser rule handling BINOP_INTRINSIC.
5949         (f77_keywords): Add new builtin procedures.
5950         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5951         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5952         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5953         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5954         (print_unop_subexp_f): New function.
5955         (print_binop_subexp_f): New function.
5956         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5957         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5958         (dump_subexp_body_f): Likewise.
5959         (operator_check_f): Likewise.
5960         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5961         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5962
5963 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5964
5965         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5966         UNOP_KIND.
5967         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5968         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5969         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5970         (operator_length_f): New fuction.
5971         (print_subexp_f): New function.
5972         (op_name_f): New function.
5973         (dump_subexp_body_f): New function.
5974         (operator_check_f): New function.
5975         (exp_descriptor_f): Replace standard expression handling functions
5976         with new functions.
5977         * gdb/fortran-operator.def: New file.
5978         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5979         * gdb/std-operator.def: Remove UNOP_KIND.
5980
5981 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5982
5983         * std-operator.def: Remove unbalanced, stray double quote
5984         character.
5985
5986 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5987             Chris January  <chris.january@arm.com>
5988             Daniel Everett  <daniel.everett@arm.com>
5989             Nick Forrington  <nick.forrington@arm.com>
5990             Richard Bunt  <richard.bunt@arm.com>
5991
5992         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5993         of depth when printing anonymous structs or unions.
5994         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5995         Don't print either the top-level value, or the children if the
5996         max-depth is exceeded.
5997         (ppscm_print_children): When printing the key of a map, allow one
5998         extra level of depth.
5999         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6000         print either the top-level value, or the children if the max-depth
6001         is exceeded.
6002         (print_children): When printing the key of a map, allow one extra
6003         level of depth.
6004         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6005         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6006         (user_print_options): Initialise max_depth field.
6007         (val_print_scalar_or_string_type_p): New function.
6008         (val_print): Check to see if the max depth has been reached.
6009         (val_print_check_max_depth): Define new function.
6010         (show_print_max_depth): New function.
6011         (_initialize_valprint): Add 'print max-depth' option.
6012         * valprint.h (struct value_print_options) <max_depth>: New field.
6013         (val_print_check_max_depth): Declare new function.
6014         * NEWS: Document new feature.
6015
6016 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6017
6018         * ada-lang.c (ada_language_defn): Initialise new field.
6019         * c-lang.c (c_is_string_type_p): New function.
6020         (c_language_defn): Initialise new field.
6021         (cplus_language_defn): Initialise new field.
6022         (asm_language_defn): Initialise new field.
6023         (minimal_language_defn): Initialise new field.
6024         * c-lang.h (c_is_string_type_p): Declare new function.
6025         * d-lang.c (d_language_defn): Initialise new field.
6026         * f-lang.c (f_is_string_type_p): New function.
6027         (f_language_defn): Initialise new field.
6028         * go-lang.c (go_is_string_type_p): New function.
6029         (go_language_defn): Initialise new field.
6030         * language.c (default_is_string_type_p): New function.
6031         (unknown_language_defn): Initialise new field.
6032         (auto_language_defn): Initialise new field.
6033         * language.h (struct language_defn) <la_is_string_type_p>: New
6034         member variable.
6035         (default_is_string_type_p): Declare new function.
6036         * m2-lang.c (m2_language_defn): Initialise new field.
6037         * objc-lang.c (objc_language_defn): Initialise new field.
6038         * opencl-lang.c (opencl_language_defn): Initialise new field.
6039         * p-lang.c (pascal_is_string_type_p): New function.
6040         (pascal_language_defn): Initialise new field.
6041         * rust-lang.c (rust_is_string_type_p): New function.
6042         (rust_language_defn): Initialise new field.
6043
6044 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6047         New field.
6048         * ada-lang.c (ada_language_defn): Initialise new field.
6049         * c-lang.c (c_language_defn): Likewise.
6050         (cplus_language_defn): Likewise.
6051         (asm_language_defn): Likewise.
6052         (minimal_language_defn): Likewise.
6053         * d-lang.c (d_language_defn): Likewise.
6054         * f-lang.c (f_language_defn): Likewise.
6055         * go-lang.c (go_language_defn): Likewise.
6056         * language.c (unknown_language_defn): Likewise.
6057         (auto_language_defn): Likewise.
6058         * m2-lang.c (m2_language_defn): Likewise.
6059         * objc-lang.c (objc_language_defn): Likewise.
6060         * opencl-lang.c (opencl_language_defn): Likewise.
6061         * p-lang.c (pascal_language_defn): Likewise.
6062         * rust-lang.c (rust_language_defn): Likewise.
6063
6064 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6065
6066         * ada-lang.c (ada_is_character_type): Change return type to bool.
6067         (ada_is_string_type): Likewise.
6068         * ada-lang.h (ada_is_character_type): Update declaration
6069         (ada_is_string_type): Likewise.
6070
6071 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6072
6073         Support style in 'frame|thread apply'
6074
6075         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6076         * record.c (record_start, record_stop): Update callers of
6077         execute_command_to_string with false.
6078         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6079         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6080         methods.
6081         (class string_file): New constructor with term_out parameter.
6082         Override methods term_out and can_emit_style_escape.  New member
6083         term_out.
6084         (class stdio_file): Override can_emit_style_escape.
6085         (class tee_file): Override term_out and can_emit_style_escape.
6086         * utils.h (can_emit_style_escape): Remove.
6087         * utils.c (can_emit_style_escape): Likewise.
6088         Update all callers of can_emit_style_escape (SOMESTREAM) to
6089         SOMESTREAM->can_emit_style_escape.
6090         * source-cache.c (source_cache::get_source_lines): Likewise.
6091         * stack.c (frame_apply_command_count): Call execute_command_to_string
6092         passing the term_out characteristic of the current gdb_stdout.
6093         * thread.c (thr_try_catch_cmd): Likewise.
6094         * top.c (execute_command_to_string): pass term_out parameter
6095         to construct the string_file for the command output.
6096         * ui-file.c (term_cli_styling): New function (most code moved
6097         from utils.c can_emit_style_escape).
6098         (string_file::string_file, string_file::can_emit_style_escape,
6099         stdio_file::can_emit_style_escape, tee_file::term_out,
6100         tee_file::can_emit_style_escape): New functions.
6101
6102 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6103
6104         * NEWS: Mention the new set|show may-call-functions.
6105         * infcall.c (may_call_functions_p): New variable.
6106         (show_may_call_functions_p): New function.
6107         (call_function_by_hand_dummy): Throws an error if not
6108         may-call-functions.
6109         (_initialize_infcall): Call add_setshow_boolean_cmd for
6110         may-call-functions.
6111
6112 2019-04-25  Keith Seitz  <keiths@redhat.com>
6113
6114         PR c++/24367
6115         * cp-support.c (inspect_type): Don't attempt substitutions
6116         of symbol with the same name.
6117
6118 2019-04-25  Tom Tromey  <tromey@adacore.com>
6119
6120         PR gdb/24475:
6121         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6122         static.
6123
6124 2019-04-25  Tom Tromey  <tromey@adacore.com>
6125
6126         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6127         rvalue reference.
6128         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6129         (gdb_xml_parser::parse): Use std::move.
6130         * python/python-internal.h (gdbpy_convert_exception): Take a const
6131         reference.
6132         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6133         std::move.
6134         * python/py-utils.c (gdbpy_convert_exception): Take a const
6135         reference.
6136         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6137         Use std::move.
6138         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6139         Use std::move.
6140         * mi/mi-main.c (mi_print_exception): Take a const reference.
6141         * main.c (handle_command_errors): Take a const reference.
6142         * linespec.c (parse_linespec): Use std::move.
6143         * infcall.c (run_inferior_call): Use std::move.
6144         (call_function_by_hand_dummy): Use std::move.
6145         * exec.c (try_open_exec_file): Use std::move.
6146         * exceptions.h (exception_print, exception_fprintf)
6147         (exception_print_same): Update.
6148         * exceptions.c (print_exception, exception_print)
6149         (exception_fprintf, exception_print_same): Change parameters to
6150         const reference.
6151         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6152         * common/new-op.c: Use std::move.
6153         * common/common-exceptions.h (struct gdb_exception): Add move
6154         constructor.
6155         (struct gdb_exception_error, struct gdb_exception_quit, struct
6156         gdb_quit_bad_alloc): Change constructor to move constructor.
6157         (throw_exception): Change parameter to rvalue reference.
6158         * common/common-exceptions.c (throw_exception): Take rvalue
6159         reference.
6160         * cli/cli-interp.c (safe_execute_command): Use std::move.
6161         * breakpoint.c (insert_bp_location, location_to_sals): Use
6162         std::move.
6163
6164 2019-04-25  Tom Tromey  <tromey@adacore.com>
6165
6166         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6167         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6168         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6169         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6170         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6171         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6172         guile/scm-value.c: Use unpack.
6173         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6174         gdbscm_gdb_exception.
6175         (gdbscm_throw_gdb_exception): Likewise.
6176         (struct gdbscm_gdb_exception): New.
6177         (unpack): New function.
6178         (gdbscm_wrap): Use unpack.
6179
6180 2019-04-25  Tom Tromey  <tromey@adacore.com>
6181
6182         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6183         (gdb_rl_callback_handler): Use std::move.
6184         * common/common-exceptions.h (struct gdb_exception): Add move
6185         assignment operator.
6186         (throw_exception_sjlj): Change "exception" to const reference.
6187         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6188         (throw_exception_sjlj): Change "exception" to const reference.
6189
6190 2019-04-25  Tom Tromey  <tromey@adacore.com>
6191
6192         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6193         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6194         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6195         Update.
6196         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6197         Update.
6198         * mi/mi-interp.c (mi_interp::exec): Update.
6199         * linespec.c (parse_linespec): Update.
6200         * infcall.c (run_inferior_call): Update.
6201         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6202         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6203         (gdbscm_lookup_global_symbol): Update.
6204         * guile/scm-param.c (gdbscm_parameter_value): Update.
6205         * guile/scm-frame.c (gdbscm_frame_read_register)
6206         (gdbscm_frame_read_var): Update.
6207         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6208         * exec.c (try_open_exec_file): Update.
6209         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6210         (gdb_rl_callback_handler): Update.
6211         * common/common-exceptions.h (exception_none): Don't declare.
6212         * common/common-exceptions.c (exception_none): Don't define.
6213         (struct catcher) <exception>: Update.
6214         * cli/cli-interp.c (safe_execute_command): Update.
6215         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6216
6217 2019-04-25  Ali Tamur  <tamur@google.com>
6218
6219         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6220         (read_attribute_value): Likewise.
6221         (dwarf2_read_addr_index): Update comment.
6222         (read_str_index): Add DW_FORM_strx.
6223         (dwarf2_string_attr): Likewise.
6224         (dwarf2_const_value_attr): Likewise.
6225         (dump_die_shallow): Likewise.
6226         (dwarf2_fetch_constant_bytes): Likewise.
6227         (skip_form_bytes): Likewise.
6228         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6229
6230 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6231
6232         PR corefiles/11608
6233         PR corefiles/18187
6234         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6235         OFFSET.  Verify if current mapping contains an ELF header.
6236         (linux_find_memory_regions_full): Adjust call to
6237         dump_mapping_p.
6238
6239 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6240             Kang Li <kanglictf@gmail.com>
6241
6242         PR gdb/21600
6243
6244         * dwarf2-frame.c (read_initial_length): Be consistent about using
6245         unsigned representation of length.
6246         (decode_frame_entry_1): Likewise.  Check for wraparound of
6247         end pointer as well as buffer overflow.
6248
6249 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6250
6251         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6252         "vq".
6253
6254 2019-04-24  Tom Tromey  <tromey@adacore.com>
6255
6256         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6257
6258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6259
6260         * s12z-tdep.c (s12z_unwind_pc): Delete.
6261         (s12z_unwind_sp): Delete.
6262         (s12z_gdbarch_init): Don't register deleted functions with
6263         gdbarch.
6264
6265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6266
6267         * rl78-tdep.c (rl78_unwind_sp): Delete.
6268         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6269
6270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6271
6272         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6273         (xstormy16_unwind_pc): Delete.
6274         (xstormy16_dummy_id): Delete.
6275         (xstormy16_gdbarch_init): Don't register deleted functions with
6276         gdbarch.
6277
6278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6279
6280         * vax-tdep.c (vax_unwind_pc): Delete.
6281         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6282
6283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6284
6285         * v850-tdep.c (v850_unwind_sp): Delete.
6286         (v850_unwind_pc): Delete.
6287         (v850_dummy_id): Delete.
6288         (v850_gdbarch_init): Don't register deleted functions with
6289         gdbarch.
6290
6291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6292
6293         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6294         (tilegx_unwind_pc): Delete.
6295         (tilegx_unwind_dummy_id): Delete.
6296         (tilegx_gdbarch_init): Don't register deleted functions with
6297         gdbarch.
6298
6299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6302         (tic6x_dummy_id): Delete.
6303         (tic6x_gdbarch_init): Don't register deleted functions with
6304         gdbarch.
6305
6306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * sparc-tdep.c (sparc_unwind_pc): Delete.
6309         (sparc32_gdbarch_init): Don't register deleted function with
6310         gdbarch.
6311
6312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6313
6314         * sh-tdep.c (sh_unwind_sp): Delete.
6315         (sh_unwind_pc): Delete.
6316         (sh_dummy_id): Delete.
6317         (sh_gdbarch_init): Don't register deleted functions with
6318         gdbarch.
6319
6320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6321
6322         * score-tdep.c (score_unwind_sp): Delete.
6323         (score_unwind_pc): Delete.
6324         (score_dummy_id): Delete.
6325         (score_gdbarch_init): Don't register deleted functions with
6326         gdbarch.
6327
6328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6329
6330         * rx-tdep.c (rx_unwind_pc): Delete.
6331         (rx_unwind_sp): Delete.
6332         (rx_dummy_id): Delete.
6333         (rx_gdbarch_init): Don't register deleted functions with
6334         gdbarch.  Update comment.
6335
6336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6337
6338         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6339         (rs6000_dummy_id): Delete.
6340         (rs6000_gdbarch_init): Don't register deleted functions with
6341         gdbarch.
6342
6343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6344
6345         * or1k-tdep.c (or1k_dummy_id): Delete.
6346         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6347
6348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * nios2-tdep.c (nios2_dummy_id): Delete.
6351         (nios2_unwind_sp): Delete.
6352         (nios2_gdbarch_init): Don't register deleted functions with
6353         gdbarch.
6354
6355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6356
6357         * nds32-tdep.c (nds32_dummy_id): Delete.
6358         (nds32_unwind_pc): Delete.
6359         (nds32_unwind_sp): Delete.
6360         (nds32_gdbarch_init): Don't register deleted functions with
6361         gdbarch.
6362
6363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6364
6365         * msp430-tdep.c (msp430_unwind_pc): Delete.
6366         (msp430_unwind_sp): Delete.
6367         (msp430_dummy_id): Delete.
6368         (msp430_gdbarch_init): Don't register deleted functions with
6369         gdbarch.
6370
6371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6372
6373         * moxie-tdep.c (moxie_unwind_sp): Delete.
6374         (moxie_unwind_pc): Delete.
6375         (moxie_dummy_id): Delete.
6376         (moxie_gdbarch_init): Don't register deleted functions with
6377         gdbarch.
6378
6379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6380
6381         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6382         (mn10300_unwind_pc): Delete.
6383         (mn10300_unwind_sp): Delete.
6384         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6385         mn10300_unwind_sp.
6386         (mn10300_frame_unwind_init): Don't register deleted functions with
6387         gdbarch.
6388
6389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6390
6391         * mep-tdep.c (mep_unwind_pc): Delete.
6392         (mep_unwind_sp): Delete.
6393         (mep_dummy_id): Delete.
6394         (mep_gdbarch_init): Don't register deleted functions with
6395         gdbarch.
6396
6397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6398
6399         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6400         (m68hc11_unwind_sp): Delete.
6401         (m68hc11_gdbarch_init): Don't register deleted functions with
6402         gdbarch.
6403
6404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6405
6406         * m32r-tdep.c (m32r_unwind_sp): Delete.
6407         (m32r_unwind_pc): Delete.
6408         (m32r_dummy_id): Delete.
6409         (m32r_gdbarch_init): Don't register deleted functions with
6410         gdbarch.
6411
6412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6413
6414         * m32c-tdep.c (m32c_unwind_pc): Delete.
6415         (m32c_unwind_sp): Delete.
6416         (m32c_dummy_id): Delete.
6417         (m32c_gdbarch_init): Don't register deleted functions with
6418         gdbarch.
6419
6420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6421
6422         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6423         (lm32_unwind_pc): Delete.
6424         (lm32_dummy_id): Delete.
6425         (lm32_gdbarch_init): Don't register deleted functions with
6426         gdbarch.
6427
6428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6429
6430         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6431         (iq2000_unwind_pc): Delete.
6432         (iq2000_dummy_id): Delete.
6433         (iq2000_gdbarch_init): Don't register deleted functions with
6434         gdbarch.
6435
6436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6437
6438         * nds32-tdep.c (nds32_type_align): Delete.
6439         (nds32_push_dummy_call): Use type_align instead.
6440
6441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6442
6443         * arm-tdep.c (arm_type_align): Only handle vector override case.
6444         (arm_push_dummy_call): Use type_align.
6445         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6446
6447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6448
6449         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6450         case.
6451         (pass_on_stack): Use type_align.
6452         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6453         function.
6454
6455 2019-04-23  Tom Tromey  <tromey@adacore.com>
6456
6457         * dwarf2read.c (line_header::file_name_at): Remove unused
6458         overload.
6459
6460 2019-04-23  Tom de Vries  <tdevries@suse.de>
6461
6462         PR gdb/24438
6463         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6464         invocation.
6465
6466
6467 2019-03-27  Ali Tamur  <tamur@google.com>
6468
6469         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6470         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6471         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6472         (dwarf_expr_context::get_addr_index): Likewise
6473         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6474         (symbol_needs_eval_context::get_addr_index): Likewise
6475         (disassemble_dwarf_expression): Add DW_OP_addrx
6476         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6477         (read_cutu_die_from_dwo): Update comment
6478         (skip_one_die): Add DW_FORM_addrx
6479         (read_attribute_value): Likewise
6480         (var_decode_location): Add DW_OP_addrx
6481         (dwarf2_const_value_attr): Add DW_FORM_addrx
6482         (dump_die_shallow): Likewise
6483         (dwarf2_fetch_constant_bytes): Likewise
6484         (decode_locdesc): Add DW_OP_addrx
6485         (skip_form_bytes): Add DW_FORM_addrx
6486
6487 2019-04-22  Ali Tamur  <tamur@google.com>
6488
6489         * MAINTAINERS (Write After Approval): Add self.
6490
6491 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6492
6493         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6494         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6495         (open_symbol_file_object): Likewise.
6496         (svr4_default_sos): Add info parameter.
6497         (svr4_read_so_list): Likewise.
6498         (svr4_current_sos_direct): Adjust functions calls to pass down
6499         info.
6500         (svr4_current_sos_1): Add info parameter.
6501         (svr4_current_sos): Call get_svr4_info, pass info down to
6502         svr4_current_sos_1.
6503         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6504         get_svr4_info.
6505         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6506         get_svr4_info.
6507         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6508         to get_svr4_info.
6509         (probes_table_remove_objfile_probes): Likewise.
6510         (register_solib_event_probe): Add info parameter.
6511         (solist_update_incremental): Pass info parameter down to
6512         svr4_read_so_list.
6513         (disable_probes_interface): Add info parameter.
6514         (svr4_handle_solib_event): Pass current_program_space to
6515         get_svr4_info.  Adjust disable_probes_interface cleanup.
6516         (svr4_create_probe_breakpoints): Add info parameter, pass it
6517         down to register_solib_event_probe.
6518         (svr4_create_solib_event_breakpoints): Add info parameter,
6519         pass it down to svr4_create_probe_breakpoints.
6520         (enable_break): Pass info down to
6521         svr4_create_solib_event_breakpoints.
6522         (svr4_solib_create_inferior_hook): Pass current_program_space to
6523         get_svr4_info.
6524         (svr4_clear_solib): Likewise.
6525
6526 2019-04-22  Pedro Alves  <palves@redhat.com>
6527
6528         * solib-svr4.c (svr4_free_objfile_observer): New.
6529         (probe_and_action::objfile): New field.
6530         (probes_table_htab_remove_objfile_probes)
6531         (probes_table_remove_objfile_probes): New functions.
6532         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6533         in the new probe_and_action.  Don't store the probe in 'lookup'.
6534         (svr4_create_probe_breakpoints): Pass objfile to
6535         register_solib_event_probe.
6536         (_initialize_svr4_solib): Register a free_objfile observer.
6537
6538 2019-04-19  Tom Tromey  <tom@tromey.com>
6539
6540         * common/queue.h: Remove.
6541
6542 2019-04-19  Tom Tromey  <tom@tromey.com>
6543
6544         * event-loop.c: Don't include "common/queue.h".
6545
6546 2019-04-19  Tom Tromey  <tom@tromey.com>
6547
6548         * remote.c (remote_target): Use delete.
6549         * remote-notif.h: Include <list>, not "common/queue.h".
6550         (notif_client_p): Remove typedef.
6551         (remote_notif_state): Add constructor, destructor, initializer.
6552         <notif_queue>: Now a std::list.
6553         (remote_notif_state_xfree): Don't declare.
6554         * remote-notif.c (remote_notif_process, handle_notification)
6555         (remote_notif_state_allocate): Update.
6556         (~remote_notif_state): Rename from remote_notif_state_xfree.
6557
6558 2019-04-19  Tom Tromey  <tom@tromey.com>
6559
6560         * symfile.c (reread_symbols): Update.
6561         * objfiles.c (objfile_register_static_link)
6562         (objfile_lookup_static_link): Update
6563         (~objfile) Don't delete static_links.
6564         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6565
6566 2019-04-19  Tom Tromey  <tom@tromey.com>
6567
6568         * type-stack.h (struct type_stack) <insert>: Constify string.
6569         * type-stack.c (type_stack::insert): Constify string.
6570         * gdbtypes.h (lookup_template_type): Update.
6571         (address_space_name_to_int): Update.
6572         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6573         const.
6574         (lookup_template_type): Make name const.
6575         * c-exp.y: Update rules.
6576         (lex_one_token, classify_name, classify_inner_name)
6577         (c_print_token): Update.
6578         * p-exp.y: Update rules.
6579         (yylex): Update.
6580         * f-exp.y: Update rules.
6581         (yylex): Update.
6582         * d-exp.y: Update rules.
6583         (lex_one_token, classify_name, classify_inner_name): Update.
6584         * parse.c (write_dollar_variable, copy_name): Return std::string.
6585         * parser-defs.h (copy_name): Change return type.
6586         * m2-exp.y: Update rules.
6587         (yylex): Update.
6588         * go-exp.y (lex_one_token): Update.
6589         Update rules.
6590         (classify_unsafe_function, classify_packaged_name)
6591         (classify_name, yylex): Update.
6592
6593 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6594
6595         * configure.ac: add --enable-source-highlight switch.
6596         * configure: Regenerate.
6597         * top.c (print_gdb_version): plumb --enable-source-highlight
6598         status to "show configuration".
6599
6600 2019-04-19  Tom Tromey  <tromey@adacore.com>
6601
6602         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6603         Check ADA_TYPE_P.
6604         (empty_record, ada_template_to_fixed_record_type_1)
6605         (template_to_static_fixed_type)
6606         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6607         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6608         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6609         macros.
6610
6611 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6612
6613         PR symtab/24423:
6614         * source.c (print_source_lines_base): Advance "iter" when a
6615         control character is seen.
6616
6617 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6618
6619         * inferior.h (struct infcall_suspend_state_deleter):
6620         Catch exception in destructor to avoid crash.
6621
6622 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6623
6624         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6625         close to the add_com "shell".
6626
6627 2019-04-18  Tom Tromey  <tromey@adacore.com>
6628
6629         * process-stratum-target.h (class process_stratum_target)
6630         <stratum>: Add "final".
6631
6632 2019-04-17  Tom Tromey  <tromey@adacore.com>
6633
6634         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6635         against nullptr before use.
6636
6637 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6638
6639         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6640
6641 2019-04-17  Jim Wilson  <jimw@sifive.com>
6642             Andrew Burgess  <andrew.burgess@embecosm.com>
6643
6644         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6645         code read might fail, assume 4-byte breakpoint in that case.
6646
6647 2019-04-15  Leszek Swirski  <leszeks@google.com>
6648
6649         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6650         rather than a hand-rolled POD check when checking for forced MEMORY
6651         classification.
6652
6653 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6654
6655         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6656         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6657         function.
6658         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6659         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6660         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6661         declaration.
6662
6663 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6664
6665         * aarch64-linux-nat.c
6666         (aarch64_linux_nat_target::thread_architecture): Add override.
6667         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6668         each VQ.
6669
6670 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6671
6672         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6673
6674 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6675
6676         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6677         target types of size 96-bits, add some additional comments, and
6678         check that the builtin type we found was the correct size.
6679
6680 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6681
6682         * utils.c (prompt_for_continue): Don't restore the styling at the
6683         end, as applied_style has the wrong value.  This fixes styling in
6684         long lists of file names that are interrupted by the "Continue?"
6685         prompt.
6686
6687 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6688
6689         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6690         * c-lang.c (c_language_defn): Likewise.
6691         (cplus_language_defn): Likewise.
6692         (asm_language_defn): Likewise.
6693         (minimal_language_defn): Likewise.
6694         * d-lang.c (d_language_defn): Likewise.
6695         * f-lang.c (f_language_defn): Likewise.
6696         * go-lang.c (go_language_defn): Likewise.
6697         * language.c (unknown_language_defn): Likewise.
6698         (auto_language_defn): Likewise.
6699         * language.h (struct language_defn): Remove la_magic field.
6700         (LANG_MAGIC): Delete.
6701         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6702         * objc-lang.c (objc_language_defn): Likewise.
6703         * opencl-lang.c (opencl_language_defn): Likewise.
6704         * p-lang.c (pascal_language_defn): Likewise.
6705         * rust-lang.c (rust_language_defn): Likewise.
6706
6707 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6708
6709         * riscv-tdep.c (riscv_type_align): New function.
6710         (riscv_type_alignment): Delete.
6711         (riscv_arg_location): Use 'type_align'.
6712         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6713
6714 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6715
6716         * gdbtypes.c (type_align): A struct with no non-static fields also
6717         has alignment of 1.
6718
6719 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6720
6721         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6722         component to 0.
6723         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6724         member.
6725         (riscv_struct_info::analyse): New implementation using new
6726         analyse_inner member function.
6727         (riscv_struct_info::field_offset): New member function.
6728         (riscv_struct_info::m_offsets): New member variable.
6729         (riscv_struct_info::analyse_inner): New private member function,
6730         takes the old implementation of riscv_struct_info::analyse but
6731         extended to track field offsets.
6732         (riscv_call_arg_struct): Update the struct folding special cases
6733         to handle cases where empty C++ structs, which are non-zero
6734         length, are found.
6735         (riscv_arg_location): Initialise the length of each location, a
6736         non-zero length now indicates the location is in use.
6737         (riscv_push_dummy_call): Allow for the first location having a
6738         non-zero offset when setting up arguments.
6739         (riscv_return_value): Likewise, but for return values.
6740
6741 2019-04-11  Tom Tromey  <tromey@adacore.com>
6742
6743         * utils.c (internal_vproblem): Make "msg" const.
6744
6745 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6746
6747         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6748         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6749         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6750         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6751
6752 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6753
6754         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6755         function.
6756         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6757         of amd64_collect_native_gregset.
6758         (amd64_linux_nat_target::store_registers): Likewise.
6759
6760 2019-04-10  Tom Tromey  <tom@tromey.com>
6761
6762         * symtab.c (lookup_global_symbol_from_objfile)
6763         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6764         * objfiles.h (class separate_debug_iterator): New.
6765         (class separate_debug_range): New.
6766         (struct objfile) <separate_debug_objfiles>: New method.
6767         (objfile_separate_debug_iterate): Don't declare.
6768         * objfiles.c (separate_debug_iterator::operator++): Rename from
6769         objfile_separate_debug_iterate.
6770         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6771         iterator.
6772         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6773         iterator.
6774
6775 2019-04-10  Tom Tromey  <tom@tromey.com>
6776
6777         * symfile.c (reread_symbols): Remove old comment.
6778         * objfiles.c (free_all_objfiles): Fix a typo.
6779
6780 2019-04-10  Tom Tromey  <tom@tromey.com>
6781
6782         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6783         * minsyms.c (lookup_minimal_symbol): Use foreach.
6784         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6785         (lookup_minimal_symbol_solib_trampoline): Likewise.
6786         * symfile.c (reread_symbols): Use foreach.
6787
6788 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6789             Tom Tromey  <tromey@adacore.com>
6790
6791         PR rust/24414:
6792         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6793         (rust_lex_int_test): Change "value" to be LONGEST.
6794         (rust_lex_tests): Add test for long integer literal.
6795
6796 2019-04-09  Tom Tromey  <tromey@adacore.com>
6797
6798         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6799         to bool.
6800         (extended_remote_target::attach): Update.
6801         (remote_target::remote_notice_new_inferior): Update.
6802         (remote_target::add_current_inferior_and_thread): Update.
6803         * inferior.c (exit_inferior_1): Use "false".
6804         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6805
6806 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6807
6808         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6809         the "start" command.
6810
6811 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6812
6813         * python/py-inferior.c (infpy_thread_from_thread_handle):
6814         Adjust comments to reflect renaming of thread_from_thread_handle
6815         to thread_from_handle.  Adjust keywords.  Fix type error message.
6816         (inferior_object_methods): Add thread_from_handle.  Retain
6817         thread_from_thread_handle, but mark it as deprecated.
6818
6819 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6820
6821         * gdbthread.h (find_thread_by_handle): Revise declaration.
6822         * thread.c (find_thread_by_handle): Likewise.  Adjust
6823         implementation too.
6824         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6825         support for buffer objects as handles.
6826
6827 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6828
6829         * python/py-infthread.c (thpy_thread_handle): New function.
6830         (thread_object_methods): Register thpy_thread_handle.
6831
6832 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6833
6834         * gdbthread.h (thread_to_thread_handle): Declare.
6835         * thread.c (gdbtypes.h): Include.
6836         (thread_to_thread_handle): New function.
6837
6838         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6839         (target_thread_info_to_thread_handle): Declare.
6840         * target.c (target_thread_info_to_thread_handle): New function.
6841         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6842         * target-delegates.c: Regenerate.
6843
6844         * linux-thread-db.c (class thread_db_target): Add method
6845         thread_info_to_thread_handle.
6846         (thread_db_target::thread_info_to_thread_handle): Define.
6847         * remote.c (class remote_target): Add new method
6848         thread_info_to_thread_handle.
6849         (remote_target::thread_info_to_thread_handle): Define.
6850
6851 2019-04-08  Pedro Alves  <palves@redhat.com>
6852
6853         * common/common-exceptions.c (throw_exception): Don't create
6854         named object to throw; throw directly.
6855         (throw_it): Likewise.  Don't initialize gdb_exception::message
6856         here, with new; pass FMT and AP to the ctor instead.
6857         * common/common-exceptions.h: Include <string>.
6858         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6859         const char *, va_list)): New ctor.  Use std::make_shared.
6860         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6861         errors)): Delete.
6862         (gdb_exception_error::gdb_exception_error(enum errors, const char
6863         *, va_list)): New.
6864         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6865         Add assertion.
6866         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6867         errors)): Delete.
6868         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6869         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6870         Add assertion.
6871
6872 2019-04-08  Tom Tromey  <tom@tromey.com>
6873
6874         * valops.c (value_rtti_indirect_type): Replace throw_exception
6875         with throw.
6876         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6877         with throw.
6878         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6879         throw.
6880         * target.c (target_translate_tls_address): Replace throw_exception
6881         with throw.
6882         * stack.c (frame_apply_command_count): Replace throw_exception
6883         with throw.
6884         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6885         throw.
6886         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6887         with throw.
6888         * rs6000-tdep.c (rs6000_frame_cache)
6889         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6890         * remote.c: Replace throw_exception with throw.
6891         * record-full.c (record_full_message, record_full_wait_1)
6892         (record_full_restore): Replace throw_exception with throw.
6893         * record-btrace.c:
6894         (get_thread_current_frame_id, record_btrace_start_replaying)
6895         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6896         (cmd_record_btrace_start): Replace throw_exception with throw.
6897         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6898         throw.
6899         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6900         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6901         * linespec.c:
6902         (find_linespec_symbols): Replace throw_exception with throw.
6903         * infrun.c (displaced_step_prepare, resume): Replace
6904         throw_exception with throw.
6905         * infcmd.c (post_create_inferior): Replace throw_exception with
6906         throw.
6907         * inf-loop.c (inferior_event_handler): Replace throw_exception
6908         with throw.
6909         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6910         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6911         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6912         (get_prev_frame_always, get_frame_pc_if_available)
6913         (get_frame_address_in_block_if_available, get_frame_language):
6914         Replace throw_exception with throw.
6915         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6916         throw_exception with throw.
6917         * eval.c (fetch_subexp_value, evaluate_var_value)
6918         (evaluate_funcall, evaluate_subexp_standard): Replace
6919         throw_exception with throw.
6920         * dwarf2loc.c (call_site_find_chain)
6921         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6922         Replace throw_exception with throw.
6923         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6924         with throw.
6925         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6926         throw.
6927         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6928         * completer.c (complete_line_internal): Replace throw_exception
6929         with throw.
6930         * compile/compile-object-run.c (compile_object_run): Replace
6931         throw_exception with throw.
6932         * cli/cli-script.c (process_next_line): Replace throw_exception
6933         with throw.
6934         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6935         (btrace_enable, btrace_maint_update_pt_packets): Replace
6936         throw_exception with throw.
6937         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6938         throw_exception with throw.
6939         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6940         throw_exception with throw.
6941         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6942         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6943         * aarch64-tdep.c (aarch64_make_prologue_cache)
6944         (aarch64_make_stub_cache): Replace throw_exception with throw.
6945
6946 2019-04-08  Tom Tromey  <tom@tromey.com>
6947
6948         * common/common-exceptions.c (throw_exception): Rename from
6949         throw_exception_cxx.  Remove old copy.  Make argument const.
6950         (throw_it): Create and throw exception objects directly.
6951         * common/common-exceptions.h (throw_exception): Make argument
6952         const.
6953         (struct gdb_exception_error): Add constructor.
6954         (struct gdb_exception_quit): Add constructor.
6955
6956 2019-04-08  Tom Tromey  <tom@tromey.com>
6957
6958         * common/common-exceptions.h (exception_rethrow): Don't declare.
6959         (TRY_SJLJ): Update comment.
6960         (TRY, CATCH, END_CATCH): Remove.
6961         * common/common-exceptions.c (exception_rethrow): Remove.
6962
6963 2019-04-08  Tom Tromey  <tom@tromey.com>
6964
6965         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6966         Remove.
6967         (gdb_exception_error): Rename from
6968         gdb_exception_RETURN_MASK_ERROR.
6969         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6970         (gdb_quit_bad_alloc): Update.
6971         * aarch64-tdep.c: Update.
6972         * ada-lang.c: Update.
6973         * ada-typeprint.c: Update.
6974         * ada-valprint.c: Update.
6975         * amd64-tdep.c: Update.
6976         * arch-utils.c: Update.
6977         * break-catch-throw.c: Update.
6978         * breakpoint.c: Update.
6979         * btrace.c: Update.
6980         * c-varobj.c: Update.
6981         * cli/cli-cmds.c: Update.
6982         * cli/cli-interp.c: Update.
6983         * cli/cli-script.c: Update.
6984         * common/common-exceptions.c: Update.
6985         * common/new-op.c: Update.
6986         * common/selftest.c: Update.
6987         * compile/compile-c-symbols.c: Update.
6988         * compile/compile-cplus-symbols.c: Update.
6989         * compile/compile-object-load.c: Update.
6990         * compile/compile-object-run.c: Update.
6991         * completer.c: Update.
6992         * corelow.c: Update.
6993         * cp-abi.c: Update.
6994         * cp-support.c: Update.
6995         * cp-valprint.c: Update.
6996         * darwin-nat.c: Update.
6997         * disasm-selftests.c: Update.
6998         * dtrace-probe.c: Update.
6999         * dwarf-index-cache.c: Update.
7000         * dwarf-index-write.c: Update.
7001         * dwarf2-frame-tailcall.c: Update.
7002         * dwarf2-frame.c: Update.
7003         * dwarf2loc.c: Update.
7004         * dwarf2read.c: Update.
7005         * eval.c: Update.
7006         * event-loop.c: Update.
7007         * event-top.c: Update.
7008         * exec.c: Update.
7009         * f-valprint.c: Update.
7010         * fbsd-tdep.c: Update.
7011         * frame-unwind.c: Update.
7012         * frame.c: Update.
7013         * gdbtypes.c: Update.
7014         * gnu-v3-abi.c: Update.
7015         * guile/guile-internal.h: Update.
7016         * guile/scm-block.c: Update.
7017         * guile/scm-breakpoint.c: Update.
7018         * guile/scm-cmd.c: Update.
7019         * guile/scm-disasm.c: Update.
7020         * guile/scm-frame.c: Update.
7021         * guile/scm-lazy-string.c: Update.
7022         * guile/scm-math.c: Update.
7023         * guile/scm-param.c: Update.
7024         * guile/scm-ports.c: Update.
7025         * guile/scm-pretty-print.c: Update.
7026         * guile/scm-symbol.c: Update.
7027         * guile/scm-symtab.c: Update.
7028         * guile/scm-type.c: Update.
7029         * guile/scm-value.c: Update.
7030         * i386-linux-tdep.c: Update.
7031         * i386-tdep.c: Update.
7032         * inf-loop.c: Update.
7033         * infcall.c: Update.
7034         * infcmd.c: Update.
7035         * infrun.c: Update.
7036         * jit.c: Update.
7037         * language.c: Update.
7038         * linespec.c: Update.
7039         * linux-fork.c: Update.
7040         * linux-nat.c: Update.
7041         * linux-tdep.c: Update.
7042         * linux-thread-db.c: Update.
7043         * main.c: Update.
7044         * mi/mi-cmd-break.c: Update.
7045         * mi/mi-cmd-stack.c: Update.
7046         * mi/mi-interp.c: Update.
7047         * mi/mi-main.c: Update.
7048         * objc-lang.c: Update.
7049         * p-valprint.c: Update.
7050         * parse.c: Update.
7051         * ppc-linux-tdep.c: Update.
7052         * printcmd.c: Update.
7053         * python/py-arch.c: Update.
7054         * python/py-breakpoint.c: Update.
7055         * python/py-cmd.c: Update.
7056         * python/py-finishbreakpoint.c: Update.
7057         * python/py-frame.c: Update.
7058         * python/py-framefilter.c: Update.
7059         * python/py-gdb-readline.c: Update.
7060         * python/py-inferior.c: Update.
7061         * python/py-infthread.c: Update.
7062         * python/py-lazy-string.c: Update.
7063         * python/py-linetable.c: Update.
7064         * python/py-objfile.c: Update.
7065         * python/py-param.c: Update.
7066         * python/py-prettyprint.c: Update.
7067         * python/py-progspace.c: Update.
7068         * python/py-record-btrace.c: Update.
7069         * python/py-record.c: Update.
7070         * python/py-symbol.c: Update.
7071         * python/py-type.c: Update.
7072         * python/py-unwind.c: Update.
7073         * python/py-utils.c: Update.
7074         * python/py-value.c: Update.
7075         * python/python.c: Update.
7076         * record-btrace.c: Update.
7077         * record-full.c: Update.
7078         * remote-fileio.c: Update.
7079         * remote.c: Update.
7080         * riscv-tdep.c: Update.
7081         * rs6000-aix-tdep.c: Update.
7082         * rs6000-tdep.c: Update.
7083         * rust-exp.y: Update.
7084         * rust-lang.c: Update.
7085         * s390-tdep.c: Update.
7086         * selftest-arch.c: Update.
7087         * solib-dsbt.c: Update.
7088         * solib-frv.c: Update.
7089         * solib-spu.c: Update.
7090         * solib-svr4.c: Update.
7091         * solib.c: Update.
7092         * sparc64-linux-tdep.c: Update.
7093         * stack.c: Update.
7094         * symfile-mem.c: Update.
7095         * symmisc.c: Update.
7096         * target.c: Update.
7097         * thread.c: Update.
7098         * top.c: Update.
7099         * tracefile-tfile.c: Update.
7100         * tui/tui.c: Update.
7101         * typeprint.c: Update.
7102         * unittests/cli-utils-selftests.c: Update.
7103         * unittests/parse-connection-spec-selftests.c: Update.
7104         * valops.c: Update.
7105         * valprint.c: Update.
7106         * value.c: Update.
7107         * varobj.c: Update.
7108         * windows-nat.c: Update.
7109         * x86-linux-nat.c: Update.
7110         * xml-support.c: Update.
7111
7112 2019-04-08  Tom Tromey  <tom@tromey.com>
7113
7114         * xml-support.c: Use C++ exception handling.
7115         * x86-linux-nat.c: Use C++ exception handling.
7116         * windows-nat.c: Use C++ exception handling.
7117         * varobj.c: Use C++ exception handling.
7118         * value.c: Use C++ exception handling.
7119         * valprint.c: Use C++ exception handling.
7120         * valops.c: Use C++ exception handling.
7121         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7122         handling.
7123         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7124         * typeprint.c: Use C++ exception handling.
7125         * tui/tui.c: Use C++ exception handling.
7126         * tracefile-tfile.c: Use C++ exception handling.
7127         * top.c: Use C++ exception handling.
7128         * thread.c: Use C++ exception handling.
7129         * target.c: Use C++ exception handling.
7130         * symmisc.c: Use C++ exception handling.
7131         * symfile-mem.c: Use C++ exception handling.
7132         * stack.c: Use C++ exception handling.
7133         * sparc64-linux-tdep.c: Use C++ exception handling.
7134         * solib.c: Use C++ exception handling.
7135         * solib-svr4.c: Use C++ exception handling.
7136         * solib-spu.c: Use C++ exception handling.
7137         * solib-frv.c: Use C++ exception handling.
7138         * solib-dsbt.c: Use C++ exception handling.
7139         * selftest-arch.c: Use C++ exception handling.
7140         * s390-tdep.c: Use C++ exception handling.
7141         * rust-lang.c: Use C++ exception handling.
7142         * rust-exp.y: Use C++ exception handling.
7143         * rs6000-tdep.c: Use C++ exception handling.
7144         * rs6000-aix-tdep.c: Use C++ exception handling.
7145         * riscv-tdep.c: Use C++ exception handling.
7146         * remote.c: Use C++ exception handling.
7147         * remote-fileio.c: Use C++ exception handling.
7148         * record-full.c: Use C++ exception handling.
7149         * record-btrace.c: Use C++ exception handling.
7150         * python/python.c: Use C++ exception handling.
7151         * python/py-value.c: Use C++ exception handling.
7152         * python/py-utils.c: Use C++ exception handling.
7153         * python/py-unwind.c: Use C++ exception handling.
7154         * python/py-type.c: Use C++ exception handling.
7155         * python/py-symbol.c: Use C++ exception handling.
7156         * python/py-record.c: Use C++ exception handling.
7157         * python/py-record-btrace.c: Use C++ exception handling.
7158         * python/py-progspace.c: Use C++ exception handling.
7159         * python/py-prettyprint.c: Use C++ exception handling.
7160         * python/py-param.c: Use C++ exception handling.
7161         * python/py-objfile.c: Use C++ exception handling.
7162         * python/py-linetable.c: Use C++ exception handling.
7163         * python/py-lazy-string.c: Use C++ exception handling.
7164         * python/py-infthread.c: Use C++ exception handling.
7165         * python/py-inferior.c: Use C++ exception handling.
7166         * python/py-gdb-readline.c: Use C++ exception handling.
7167         * python/py-framefilter.c: Use C++ exception handling.
7168         * python/py-frame.c: Use C++ exception handling.
7169         * python/py-finishbreakpoint.c: Use C++ exception handling.
7170         * python/py-cmd.c: Use C++ exception handling.
7171         * python/py-breakpoint.c: Use C++ exception handling.
7172         * python/py-arch.c: Use C++ exception handling.
7173         * printcmd.c: Use C++ exception handling.
7174         * ppc-linux-tdep.c: Use C++ exception handling.
7175         * parse.c: Use C++ exception handling.
7176         * p-valprint.c: Use C++ exception handling.
7177         * objc-lang.c: Use C++ exception handling.
7178         * mi/mi-main.c: Use C++ exception handling.
7179         * mi/mi-interp.c: Use C++ exception handling.
7180         * mi/mi-cmd-stack.c: Use C++ exception handling.
7181         * mi/mi-cmd-break.c: Use C++ exception handling.
7182         * main.c: Use C++ exception handling.
7183         * linux-thread-db.c: Use C++ exception handling.
7184         * linux-tdep.c: Use C++ exception handling.
7185         * linux-nat.c: Use C++ exception handling.
7186         * linux-fork.c: Use C++ exception handling.
7187         * linespec.c: Use C++ exception handling.
7188         * language.c: Use C++ exception handling.
7189         * jit.c: Use C++ exception handling.
7190         * infrun.c: Use C++ exception handling.
7191         * infcmd.c: Use C++ exception handling.
7192         * infcall.c: Use C++ exception handling.
7193         * inf-loop.c: Use C++ exception handling.
7194         * i386-tdep.c: Use C++ exception handling.
7195         * i386-linux-tdep.c: Use C++ exception handling.
7196         * guile/scm-value.c: Use C++ exception handling.
7197         * guile/scm-type.c: Use C++ exception handling.
7198         * guile/scm-symtab.c: Use C++ exception handling.
7199         * guile/scm-symbol.c: Use C++ exception handling.
7200         * guile/scm-pretty-print.c: Use C++ exception handling.
7201         * guile/scm-ports.c: Use C++ exception handling.
7202         * guile/scm-param.c: Use C++ exception handling.
7203         * guile/scm-math.c: Use C++ exception handling.
7204         * guile/scm-lazy-string.c: Use C++ exception handling.
7205         * guile/scm-frame.c: Use C++ exception handling.
7206         * guile/scm-disasm.c: Use C++ exception handling.
7207         * guile/scm-cmd.c: Use C++ exception handling.
7208         * guile/scm-breakpoint.c: Use C++ exception handling.
7209         * guile/scm-block.c: Use C++ exception handling.
7210         * guile/guile-internal.h: Use C++ exception handling.
7211         * gnu-v3-abi.c: Use C++ exception handling.
7212         * gdbtypes.c: Use C++ exception handling.
7213         * frame.c: Use C++ exception handling.
7214         * frame-unwind.c: Use C++ exception handling.
7215         * fbsd-tdep.c: Use C++ exception handling.
7216         * f-valprint.c: Use C++ exception handling.
7217         * exec.c: Use C++ exception handling.
7218         * event-top.c: Use C++ exception handling.
7219         * event-loop.c: Use C++ exception handling.
7220         * eval.c: Use C++ exception handling.
7221         * dwarf2read.c: Use C++ exception handling.
7222         * dwarf2loc.c: Use C++ exception handling.
7223         * dwarf2-frame.c: Use C++ exception handling.
7224         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7225         * dwarf-index-write.c: Use C++ exception handling.
7226         * dwarf-index-cache.c: Use C++ exception handling.
7227         * dtrace-probe.c: Use C++ exception handling.
7228         * disasm-selftests.c: Use C++ exception handling.
7229         * darwin-nat.c: Use C++ exception handling.
7230         * cp-valprint.c: Use C++ exception handling.
7231         * cp-support.c: Use C++ exception handling.
7232         * cp-abi.c: Use C++ exception handling.
7233         * corelow.c: Use C++ exception handling.
7234         * completer.c: Use C++ exception handling.
7235         * compile/compile-object-run.c: Use C++ exception handling.
7236         * compile/compile-object-load.c: Use C++ exception handling.
7237         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7238         * compile/compile-c-symbols.c: Use C++ exception handling.
7239         * common/selftest.c: Use C++ exception handling.
7240         * common/new-op.c: Use C++ exception handling.
7241         * cli/cli-script.c: Use C++ exception handling.
7242         * cli/cli-interp.c: Use C++ exception handling.
7243         * cli/cli-cmds.c: Use C++ exception handling.
7244         * c-varobj.c: Use C++ exception handling.
7245         * btrace.c: Use C++ exception handling.
7246         * breakpoint.c: Use C++ exception handling.
7247         * break-catch-throw.c: Use C++ exception handling.
7248         * arch-utils.c: Use C++ exception handling.
7249         * amd64-tdep.c: Use C++ exception handling.
7250         * ada-valprint.c: Use C++ exception handling.
7251         * ada-typeprint.c: Use C++ exception handling.
7252         * ada-lang.c: Use C++ exception handling.
7253         * aarch64-tdep.c: Use C++ exception handling.
7254
7255 2019-04-08  Tom Tromey  <tom@tromey.com>
7256
7257         * xml-support.c (gdb_xml_parser::parse): Update.
7258         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7259         * value.c (show_convenience): Update.
7260         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7261         (test_parse_flags_qcs): Update.
7262         * thread.c (thr_try_catch_cmd): Update.
7263         * target.c (target_translate_tls_address): Update.
7264         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7265         (info_frame_command_core, frame_apply_command_count): Update.
7266         * rust-exp.y (rust_lex_exception_test): Update.
7267         * riscv-tdep.c (riscv_print_one_register_info): Update.
7268         * remote.c (remote_target::enable_btrace): Update.
7269         * record-btrace.c (record_btrace_enable_warn): Update.
7270         * python/py-utils.c (gdbpy_convert_exception): Update.
7271         * printcmd.c (do_one_display, print_variable_and_value): Update.
7272         * mi/mi-main.c (mi_print_exception): Update.
7273         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7274         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7275         * linux-nat.c (linux_nat_target::attach): Update.
7276         * linux-fork.c (class scoped_switch_fork_info): Update.
7277         * infrun.c (displaced_step_prepare): Update.
7278         * infcall.c (call_function_by_hand_dummy): Update.
7279         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7280         * gnu-v3-abi.c (print_one_vtable): Update.
7281         * frame.c (get_prev_frame_always): Update.
7282         * f-valprint.c (info_common_command_for_block): Update.
7283         * exec.c (try_open_exec_file): Update.
7284         * exceptions.c (print_exception, exception_print)
7285         (exception_fprintf, exception_print_same): Update.
7286         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7287         * dwarf-index-cache.c (index_cache::store)
7288         (index_cache::lookup_gdb_index): Update.
7289         * darwin-nat.c (maybe_cache_shell): Update.
7290         * cp-valprint.c (cp_print_value_fields): Update.
7291         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7292         (gcc_cplus_symbol_address): Update.
7293         * compile/compile-c-symbols.c (gcc_convert_symbol)
7294         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7295         * common/selftest.c: Update.
7296         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7297         a std::string.
7298         (exception_try_scope_entry, exception_try_scope_exit): Don't
7299         declare.
7300         (struct exception_try_scope): Remove.
7301         (TRY): Don't use exception_try_scope.
7302         (struct gdb_exception): Add constructor, operator=.
7303         <what>: New method.
7304         (struct gdb_exception_RETURN_MASK_ALL)
7305         (struct gdb_exception_RETURN_MASK_ERROR)
7306         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7307         (struct gdb_quit_bad_alloc): Update.
7308         * common/common-exceptions.c (exception_none): Change
7309         initializer.
7310         (struct catcher) <state, exception>: Initialize inline.
7311         <prev>: Remove member.
7312         (current_catcher): Remove.
7313         (catchers): New global.
7314         (exceptions_state_mc_init): Simplify.
7315         (catcher_pop): Remove.
7316         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7317         (try_scope_depth, exception_try_scope_entry)
7318         (exception_try_scope_exit): Remove.
7319         (throw_exception_sjlj): Update.
7320         (exception_messages, exception_messages_size): Remove.
7321         (throw_it): Simplify.
7322         (gdb_exception_sliced_copy): Remove.
7323         (throw_exception_cxx): Update.
7324         * cli/cli-script.c (script_from_file): Update.
7325         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7326         Update.
7327         * ada-valprint.c (ada_val_print): Update.
7328         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7329         (create_excep_cond_exprs): Update.
7330
7331 2019-04-08  Tom Tromey  <tom@tromey.com>
7332
7333         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7334         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7335         (TRY, CATCH, END_CATCH): Remove some definitions.
7336         * common/common-exceptions.c: Don't use GDB_XCPT.
7337         (catcher_list_size): Remove.
7338         (throw_exception, throw_it): Simplify.
7339
7340 2019-04-05  Tom Tromey  <tom@tromey.com>
7341
7342         Revert the header-sorting patch.
7343         * ft32-tdep.c: Revert.
7344         * frv-tdep.c: Revert.
7345         * frv-linux-tdep.c: Revert.
7346         * frame.c: Revert.
7347         * frame-unwind.c: Revert.
7348         * frame-base.c: Revert.
7349         * fork-child.c: Revert.
7350         * findvar.c: Revert.
7351         * findcmd.c: Revert.
7352         * filesystem.c: Revert.
7353         * filename-seen-cache.h: Revert.
7354         * filename-seen-cache.c: Revert.
7355         * fbsd-tdep.c: Revert.
7356         * fbsd-nat.h: Revert.
7357         * fbsd-nat.c: Revert.
7358         * f-valprint.c: Revert.
7359         * f-typeprint.c: Revert.
7360         * f-lang.c: Revert.
7361         * extension.h: Revert.
7362         * extension.c: Revert.
7363         * extension-priv.h: Revert.
7364         * expprint.c: Revert.
7365         * exec.h: Revert.
7366         * exec.c: Revert.
7367         * exceptions.c: Revert.
7368         * event-top.c: Revert.
7369         * event-loop.c: Revert.
7370         * eval.c: Revert.
7371         * elfread.c: Revert.
7372         * dwarf2read.h: Revert.
7373         * dwarf2read.c: Revert.
7374         * dwarf2loc.c: Revert.
7375         * dwarf2expr.h: Revert.
7376         * dwarf2expr.c: Revert.
7377         * dwarf2-frame.c: Revert.
7378         * dwarf2-frame-tailcall.c: Revert.
7379         * dwarf-index-write.h: Revert.
7380         * dwarf-index-write.c: Revert.
7381         * dwarf-index-common.c: Revert.
7382         * dwarf-index-cache.h: Revert.
7383         * dwarf-index-cache.c: Revert.
7384         * dummy-frame.c: Revert.
7385         * dtrace-probe.c: Revert.
7386         * disasm.h: Revert.
7387         * disasm.c: Revert.
7388         * disasm-selftests.c: Revert.
7389         * dictionary.c: Revert.
7390         * dicos-tdep.c: Revert.
7391         * demangle.c: Revert.
7392         * dcache.h: Revert.
7393         * dcache.c: Revert.
7394         * darwin-nat.h: Revert.
7395         * darwin-nat.c: Revert.
7396         * darwin-nat-info.c: Revert.
7397         * d-valprint.c: Revert.
7398         * d-namespace.c: Revert.
7399         * d-lang.c: Revert.
7400         * ctf.c: Revert.
7401         * csky-tdep.c: Revert.
7402         * csky-linux-tdep.c: Revert.
7403         * cris-tdep.c: Revert.
7404         * cris-linux-tdep.c: Revert.
7405         * cp-valprint.c: Revert.
7406         * cp-support.c: Revert.
7407         * cp-namespace.c: Revert.
7408         * cp-abi.c: Revert.
7409         * corelow.c: Revert.
7410         * corefile.c: Revert.
7411         * continuations.c: Revert.
7412         * completer.h: Revert.
7413         * completer.c: Revert.
7414         * complaints.c: Revert.
7415         * coffread.c: Revert.
7416         * coff-pe-read.c: Revert.
7417         * cli-out.h: Revert.
7418         * cli-out.c: Revert.
7419         * charset.c: Revert.
7420         * c-varobj.c: Revert.
7421         * c-valprint.c: Revert.
7422         * c-typeprint.c: Revert.
7423         * c-lang.c: Revert.
7424         * buildsym.c: Revert.
7425         * buildsym-legacy.c: Revert.
7426         * build-id.h: Revert.
7427         * build-id.c: Revert.
7428         * btrace.c: Revert.
7429         * bsd-uthread.c: Revert.
7430         * breakpoint.h: Revert.
7431         * breakpoint.c: Revert.
7432         * break-catch-throw.c: Revert.
7433         * break-catch-syscall.c: Revert.
7434         * break-catch-sig.c: Revert.
7435         * blockframe.c: Revert.
7436         * block.c: Revert.
7437         * bfin-tdep.c: Revert.
7438         * bfin-linux-tdep.c: Revert.
7439         * bfd-target.c: Revert.
7440         * bcache.c: Revert.
7441         * ax-general.c: Revert.
7442         * ax-gdb.h: Revert.
7443         * ax-gdb.c: Revert.
7444         * avr-tdep.c: Revert.
7445         * auxv.c: Revert.
7446         * auto-load.c: Revert.
7447         * arm-wince-tdep.c: Revert.
7448         * arm-tdep.c: Revert.
7449         * arm-symbian-tdep.c: Revert.
7450         * arm-pikeos-tdep.c: Revert.
7451         * arm-obsd-tdep.c: Revert.
7452         * arm-nbsd-tdep.c: Revert.
7453         * arm-nbsd-nat.c: Revert.
7454         * arm-linux-tdep.c: Revert.
7455         * arm-linux-nat.c: Revert.
7456         * arm-fbsd-tdep.c: Revert.
7457         * arm-fbsd-nat.c: Revert.
7458         * arm-bsd-tdep.c: Revert.
7459         * arch-utils.c: Revert.
7460         * arc-tdep.c: Revert.
7461         * arc-newlib-tdep.c: Revert.
7462         * annotate.h: Revert.
7463         * annotate.c: Revert.
7464         * amd64-windows-tdep.c: Revert.
7465         * amd64-windows-nat.c: Revert.
7466         * amd64-tdep.c: Revert.
7467         * amd64-sol2-tdep.c: Revert.
7468         * amd64-obsd-tdep.c: Revert.
7469         * amd64-obsd-nat.c: Revert.
7470         * amd64-nbsd-tdep.c: Revert.
7471         * amd64-nbsd-nat.c: Revert.
7472         * amd64-nat.c: Revert.
7473         * amd64-linux-tdep.c: Revert.
7474         * amd64-linux-nat.c: Revert.
7475         * amd64-fbsd-tdep.c: Revert.
7476         * amd64-fbsd-nat.c: Revert.
7477         * amd64-dicos-tdep.c: Revert.
7478         * amd64-darwin-tdep.c: Revert.
7479         * amd64-bsd-nat.c: Revert.
7480         * alpha-tdep.c: Revert.
7481         * alpha-obsd-tdep.c: Revert.
7482         * alpha-nbsd-tdep.c: Revert.
7483         * alpha-mdebug-tdep.c: Revert.
7484         * alpha-linux-tdep.c: Revert.
7485         * alpha-linux-nat.c: Revert.
7486         * alpha-bsd-tdep.c: Revert.
7487         * alpha-bsd-nat.c: Revert.
7488         * aix-thread.c: Revert.
7489         * agent.c: Revert.
7490         * addrmap.c: Revert.
7491         * ada-varobj.c: Revert.
7492         * ada-valprint.c: Revert.
7493         * ada-typeprint.c: Revert.
7494         * ada-tasks.c: Revert.
7495         * ada-lang.c: Revert.
7496         * aarch64-tdep.c: Revert.
7497         * aarch64-ravenscar-thread.c: Revert.
7498         * aarch64-newlib-tdep.c: Revert.
7499         * aarch64-linux-tdep.c: Revert.
7500         * aarch64-linux-nat.c: Revert.
7501         * aarch64-fbsd-tdep.c: Revert.
7502         * aarch64-fbsd-nat.c: Revert.
7503         * aarch32-linux-nat.c: Revert.
7504
7505 2019-04-05  Tom Tromey  <tom@tromey.com>
7506
7507         * ft32-tdep.c: Sort headers.
7508         * frv-tdep.c: Sort headers.
7509         * frv-linux-tdep.c: Sort headers.
7510         * frame.c: Sort headers.
7511         * frame-unwind.c: Sort headers.
7512         * frame-base.c: Sort headers.
7513         * fork-child.c: Sort headers.
7514         * findvar.c: Sort headers.
7515         * findcmd.c: Sort headers.
7516         * filesystem.c: Sort headers.
7517         * filename-seen-cache.h: Sort headers.
7518         * filename-seen-cache.c: Sort headers.
7519         * fbsd-tdep.c: Sort headers.
7520         * fbsd-nat.h: Sort headers.
7521         * fbsd-nat.c: Sort headers.
7522         * f-valprint.c: Sort headers.
7523         * f-typeprint.c: Sort headers.
7524         * f-lang.c: Sort headers.
7525         * extension.h: Sort headers.
7526         * extension.c: Sort headers.
7527         * extension-priv.h: Sort headers.
7528         * expprint.c: Sort headers.
7529         * exec.h: Sort headers.
7530         * exec.c: Sort headers.
7531         * exceptions.c: Sort headers.
7532         * event-top.c: Sort headers.
7533         * event-loop.c: Sort headers.
7534         * eval.c: Sort headers.
7535         * elfread.c: Sort headers.
7536         * dwarf2read.h: Sort headers.
7537         * dwarf2read.c: Sort headers.
7538         * dwarf2loc.c: Sort headers.
7539         * dwarf2expr.h: Sort headers.
7540         * dwarf2expr.c: Sort headers.
7541         * dwarf2-frame.c: Sort headers.
7542         * dwarf2-frame-tailcall.c: Sort headers.
7543         * dwarf-index-write.h: Sort headers.
7544         * dwarf-index-write.c: Sort headers.
7545         * dwarf-index-common.c: Sort headers.
7546         * dwarf-index-cache.h: Sort headers.
7547         * dwarf-index-cache.c: Sort headers.
7548         * dummy-frame.c: Sort headers.
7549         * dtrace-probe.c: Sort headers.
7550         * disasm.h: Sort headers.
7551         * disasm.c: Sort headers.
7552         * disasm-selftests.c: Sort headers.
7553         * dictionary.c: Sort headers.
7554         * dicos-tdep.c: Sort headers.
7555         * demangle.c: Sort headers.
7556         * dcache.h: Sort headers.
7557         * dcache.c: Sort headers.
7558         * darwin-nat.h: Sort headers.
7559         * darwin-nat.c: Sort headers.
7560         * darwin-nat-info.c: Sort headers.
7561         * d-valprint.c: Sort headers.
7562         * d-namespace.c: Sort headers.
7563         * d-lang.c: Sort headers.
7564         * ctf.c: Sort headers.
7565         * csky-tdep.c: Sort headers.
7566         * csky-linux-tdep.c: Sort headers.
7567         * cris-tdep.c: Sort headers.
7568         * cris-linux-tdep.c: Sort headers.
7569         * cp-valprint.c: Sort headers.
7570         * cp-support.c: Sort headers.
7571         * cp-namespace.c: Sort headers.
7572         * cp-abi.c: Sort headers.
7573         * corelow.c: Sort headers.
7574         * corefile.c: Sort headers.
7575         * continuations.c: Sort headers.
7576         * completer.h: Sort headers.
7577         * completer.c: Sort headers.
7578         * complaints.c: Sort headers.
7579         * coffread.c: Sort headers.
7580         * coff-pe-read.c: Sort headers.
7581         * cli-out.h: Sort headers.
7582         * cli-out.c: Sort headers.
7583         * charset.c: Sort headers.
7584         * c-varobj.c: Sort headers.
7585         * c-valprint.c: Sort headers.
7586         * c-typeprint.c: Sort headers.
7587         * c-lang.c: Sort headers.
7588         * buildsym.c: Sort headers.
7589         * buildsym-legacy.c: Sort headers.
7590         * build-id.h: Sort headers.
7591         * build-id.c: Sort headers.
7592         * btrace.c: Sort headers.
7593         * bsd-uthread.c: Sort headers.
7594         * breakpoint.h: Sort headers.
7595         * breakpoint.c: Sort headers.
7596         * break-catch-throw.c: Sort headers.
7597         * break-catch-syscall.c: Sort headers.
7598         * break-catch-sig.c: Sort headers.
7599         * blockframe.c: Sort headers.
7600         * block.c: Sort headers.
7601         * bfin-tdep.c: Sort headers.
7602         * bfin-linux-tdep.c: Sort headers.
7603         * bfd-target.c: Sort headers.
7604         * bcache.c: Sort headers.
7605         * ax-general.c: Sort headers.
7606         * ax-gdb.h: Sort headers.
7607         * ax-gdb.c: Sort headers.
7608         * avr-tdep.c: Sort headers.
7609         * auxv.c: Sort headers.
7610         * auto-load.c: Sort headers.
7611         * arm-wince-tdep.c: Sort headers.
7612         * arm-tdep.c: Sort headers.
7613         * arm-symbian-tdep.c: Sort headers.
7614         * arm-pikeos-tdep.c: Sort headers.
7615         * arm-obsd-tdep.c: Sort headers.
7616         * arm-nbsd-tdep.c: Sort headers.
7617         * arm-nbsd-nat.c: Sort headers.
7618         * arm-linux-tdep.c: Sort headers.
7619         * arm-linux-nat.c: Sort headers.
7620         * arm-fbsd-tdep.c: Sort headers.
7621         * arm-fbsd-nat.c: Sort headers.
7622         * arm-bsd-tdep.c: Sort headers.
7623         * arch-utils.c: Sort headers.
7624         * arc-tdep.c: Sort headers.
7625         * arc-newlib-tdep.c: Sort headers.
7626         * annotate.h: Sort headers.
7627         * annotate.c: Sort headers.
7628         * amd64-windows-tdep.c: Sort headers.
7629         * amd64-windows-nat.c: Sort headers.
7630         * amd64-tdep.c: Sort headers.
7631         * amd64-sol2-tdep.c: Sort headers.
7632         * amd64-obsd-tdep.c: Sort headers.
7633         * amd64-obsd-nat.c: Sort headers.
7634         * amd64-nbsd-tdep.c: Sort headers.
7635         * amd64-nbsd-nat.c: Sort headers.
7636         * amd64-nat.c: Sort headers.
7637         * amd64-linux-tdep.c: Sort headers.
7638         * amd64-linux-nat.c: Sort headers.
7639         * amd64-fbsd-tdep.c: Sort headers.
7640         * amd64-fbsd-nat.c: Sort headers.
7641         * amd64-dicos-tdep.c: Sort headers.
7642         * amd64-darwin-tdep.c: Sort headers.
7643         * amd64-bsd-nat.c: Sort headers.
7644         * alpha-tdep.c: Sort headers.
7645         * alpha-obsd-tdep.c: Sort headers.
7646         * alpha-nbsd-tdep.c: Sort headers.
7647         * alpha-mdebug-tdep.c: Sort headers.
7648         * alpha-linux-tdep.c: Sort headers.
7649         * alpha-linux-nat.c: Sort headers.
7650         * alpha-bsd-tdep.c: Sort headers.
7651         * alpha-bsd-nat.c: Sort headers.
7652         * aix-thread.c: Sort headers.
7653         * agent.c: Sort headers.
7654         * addrmap.c: Sort headers.
7655         * ada-varobj.c: Sort headers.
7656         * ada-valprint.c: Sort headers.
7657         * ada-typeprint.c: Sort headers.
7658         * ada-tasks.c: Sort headers.
7659         * ada-lang.c: Sort headers.
7660         * aarch64-tdep.c: Sort headers.
7661         * aarch64-ravenscar-thread.c: Sort headers.
7662         * aarch64-newlib-tdep.c: Sort headers.
7663         * aarch64-linux-tdep.c: Sort headers.
7664         * aarch64-linux-nat.c: Sort headers.
7665         * aarch64-fbsd-tdep.c: Sort headers.
7666         * aarch64-fbsd-nat.c: Sort headers.
7667         * aarch32-linux-nat.c: Sort headers.
7668
7669 2019-04-04  Tom Tromey  <tom@tromey.com>
7670
7671         * varobj.c (varobj_create): Update.
7672         * rust-exp.y (struct rust_parser) <update_innermost_block,
7673         lookup_symbol>: New methods.
7674         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7675         Rename.
7676         (rust_parser::rust_lookup_type)
7677         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7678         * printcmd.c (display_command, do_one_display): Update.
7679         * parser-defs.h (struct parser_state) <parser_state>: Add
7680         "tracker" parameter.
7681         (block_tracker): New member.
7682         (class innermost_block_tracker) <innermost_block_tracker>: Add
7683         "types" parameter.
7684         <reset>: Remove method.
7685         (innermost_block): Don't declare.
7686         (null_post_parser): Update.
7687         * parse.c (innermost_block): Remove global.
7688         (write_dollar_variable): Update.
7689         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7690         Remove "tracker_types" parameter.
7691         (parse_expression): Add "tracker" parameter.
7692         (parse_expression_for_completion): Update.
7693         (null_post_parser): Add "tracker" parameter.
7694         * p-exp.y: Update rules.
7695         * m2-exp.y: Update rules.
7696         * language.h (struct language_defn) <la_post_parser>: Add
7697         "tracker" parameter.
7698         * go-exp.y: Update rules.
7699         * f-exp.y: Update rules.
7700         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7701         parameter.
7702         * d-exp.y: Update rules.
7703         * c-exp.y: Update rules.
7704         * breakpoint.c (set_breakpoint_condition): Create an
7705         innermost_block_tracker.
7706         (watch_command_1): Likewise.
7707         * ada-lang.c (resolve): Add "tracker" parameter.
7708         (resolve_subexp): Likewise.
7709         * ada-exp.y (write_var_from_sym): Update.
7710
7711 2019-04-04  Tom Tromey  <tom@tromey.com>
7712
7713         * type-stack.h: New file.
7714         * type-stack.c: New file.
7715         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7716         type-stack.h.
7717         (insert_into_type_stack, insert_type, push_type, push_type_int)
7718         (insert_type_address_space, pop_type, pop_type_int)
7719         (pop_typelist, pop_type_stack, append_type_stack)
7720         (push_type_stack, get_type_stack, push_typelist)
7721         (follow_type_instance_flags, follow_types): Don't declare.
7722         * parse.c (type_stack): Remove global.
7723         (parse_exp_in_context): Update.
7724         (insert_into_type_stack, insert_type, push_type, push_type_int)
7725         (insert_type_address_space, pop_type, pop_type_int)
7726         (pop_typelist, pop_type_stack, append_type_stack)
7727         (push_type_stack, get_type_stack, push_typelist)
7728         (follow_type_instance_flags, follow_types): Remove (moved to
7729         type-stack.c).
7730         * f-exp.y (type_stack): New global.
7731         Update rules.
7732         (push_kind_type, f_parse): Update.
7733         * d-exp.y (type_stack): New global.
7734         Update rules.
7735         (d_parse): Update.
7736         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7737         Update rules.
7738         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7739         (HFILES_NO_SRCDIR): Add type-stack.h.
7740
7741 2019-04-04  Tom Tromey  <tom@tromey.com>
7742
7743         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7744         (rust_parser::convert_ast_to_expression, rust_parse)
7745         (rust_lex_test_completion, rust_lex_tests): Update.
7746         * parser-defs.h (struct expr_completion_state): New.
7747         (struct parser_state) <parser_state>: Add completion parameter.
7748         <mark_struct_expression, mark_completion_tag>: New methods.
7749         <parse_completion, m_completion_state>: New members.
7750         (prefixify_expression, null_post_parser): Update.
7751         (mark_struct_expression, mark_completion_tag): Don't declare.
7752         * parse.c (parse_completion, expout_last_struct)
7753         (expout_tag_completion_type, expout_completion_name): Remove
7754         globals.
7755         (parser_state::mark_struct_expression)
7756         (parser_state::mark_completion_tag): Now methods.
7757         (prefixify_expression): Add last_struct parameter.
7758         (prefixify_subexp): Likewise.
7759         (parse_exp_1): Update.
7760         (parse_exp_in_context): Add cstate parameter.  Update.
7761         (parse_expression_for_completion): Create an
7762         expr_completion_state.
7763         (null_post_parser): Add "completion" parameter.
7764         * p-exp.y: Update rules.
7765         (yylex): Update.
7766         * language.h (struct language_defn) <la_post_parser>: Add
7767         "completing" parameter.
7768         * go-exp.y: Update rules.
7769         (lex_one_token): Update.
7770         * expression.h (parse_completion): Don't declare.
7771         * d-exp.y: Update rules.
7772         (lex_one_token): Update rules.
7773         * c-exp.y: Update rules.
7774         (lex_one_token): Update.
7775         * ada-lang.c (resolve): Add "parse_completion" parameter.
7776         (resolve_subexp): Likewise.
7777         (ada_resolve_function): Likewise.
7778
7779 2019-04-04  Tom Tromey  <tom@tromey.com>
7780
7781         * parser-defs.h (struct parser_state) <start_arglist,
7782         end_arglist>: New methods.
7783         <arglist_len, m_funcall_chain>: New members.
7784         (arglist_len, start_arglist, end_arglist): Don't declare.
7785         * parse.c (arglist_len, funcall_chain): Remove global.
7786         (start_arglist, end_arglist): Remove functions.
7787         (parse_exp_in_context): Update.
7788         * p-exp.y: Update rules.
7789         * m2-exp.y: Update rules.
7790         * go-exp.y: Update rules.
7791         * f-exp.y: Update rules.
7792         * d-exp.y: Update rules.
7793         * c-exp.y: Update rules.
7794
7795 2019-04-04  Tom Tromey  <tom@tromey.com>
7796
7797         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7798         lex_operator, push_back>: New methods.
7799         Update all rules.
7800         (rust_parser::lex_hex, lex_escape): Rename and update.
7801         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7802         (rust_parser::lex_operator): Rename and update.
7803         (rust_parser::lex_number, rustyylex, rustyyerror)
7804         (rust_lex_test_init, rust_lex_test_sequence)
7805         (rust_lex_test_push_back, rust_lex_tests): Update.
7806         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7807         parameter.
7808         <lexptr, prev_lexptr>: New members.
7809         (lexptr, prev_lexptr): Don't declare.
7810         * parse.c (lexptr, prev_lexptr): Remove globals.
7811         (parse_exp_in_context): Update.
7812         * p-exp.y (yylex, yyerror): Update.
7813         * m2-exp.y (parse_number, yylex, yyerror): Update.
7814         * go-exp.y (lex_one_token, yyerror): Update.
7815         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7816         * d-exp.y (lex_one_token, yyerror): Update.
7817         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7818         (lex_one_token, yyerror): Update.
7819         * ada-lex.l (YY_INPUT): Update.
7820         (rewind_to_char): Update.
7821         * ada-exp.y (yyerror): Update.
7822
7823 2019-04-04  Tom Tromey  <tom@tromey.com>
7824
7825         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7826         * parser-defs.h (struct parser_state) <parser_state>: Add new
7827         parameter.
7828         <comma_terminates>: New member.
7829         (comma_terminates): Don't declare global.
7830         * parse.c (comma_terminates): Remove global.
7831         (parse_exp_in_context): Update.
7832         * p-exp.y (yylex): Update.
7833         * m2-exp.y (yylex): Update.
7834         * go-exp.y (lex_one_token): Update.
7835         * f-exp.y (yylex): Update.
7836         * d-exp.y (lex_one_token): Update.
7837         * c-exp.y (lex_one_token): Update.
7838         * ada-lex.l: Update.
7839
7840 2019-04-04  Tom Tromey  <tom@tromey.com>
7841
7842         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7843         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7844         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7845         * parser-defs.h (paren_depth): Don't declare.
7846         * parse.c (paren_depth): Remove global.
7847         (parse_exp_in_context): Update.
7848         * p-exp.y (paren_depth): New global.
7849         (pascal_parse): Initialize it.
7850         * m2-exp.y (paren_depth): New global.
7851         (m2_parse): Initialize it.
7852         * go-exp.y (paren_depth): New global.
7853         (go_parse): Initialize it.
7854         * f-exp.y (paren_depth): New global.
7855         (f_parse): Initialize it.
7856         * d-exp.y (paren_depth): New global.
7857         (d_parse): Initialize it.
7858         * c-exp.y (paren_depth): New global.
7859         (c_parse): Initialize it.
7860         * ada-lex.l (paren_depth): New global.
7861         (lexer_init): Initialize it.
7862
7863 2019-04-04  Tom Tromey  <tom@tromey.com>
7864
7865         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7866         (rust_parser::convert_ast_to_type)
7867         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7868         * parser-defs.h (struct parser_state) <parser_state>: Add
7869         parameters.  Initialize new members.
7870         <expression_context_block, expression_context_pc>: New members.
7871         * parse.c (expression_context_block, expression_context_pc):
7872         Remove globals.
7873         (parse_exp_in_context): Update.
7874         * p-exp.y: Update all rules.
7875         (yylex): Update.
7876         * m2-exp.y: Update all rules.
7877         (yylex): Update.
7878         * go-exp.y (yylex): Update.
7879         * f-exp.y (yylex): Update.
7880         * d-exp.y: Update all rules.
7881         (yylex): Update.
7882         * c-exp.y: Update all rules.
7883         (lex_one_token, classify_name, yylex, c_parse): Update.
7884         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7885
7886 2019-04-04  Tom Tromey  <tom@tromey.com>
7887
7888         * gdbarch.h, gdbarch.c: Rebuild.
7889         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7890         * stap-probe.h:
7891         (struct stap_parse_info): Replace "parser_state" with
7892         "expr_builder".
7893         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7894         (parser_state): New class.
7895         * parse.c (expr_builder): Rename.
7896         (expr_builder::release): Rename.
7897         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7898         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7899         (write_exp_elt_longcst, write_exp_elt_floatcst)
7900         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7901         (write_exp_string_vector, write_exp_bitstring)
7902         (write_exp_msymbol, mark_struct_expression)
7903         (write_dollar_variable)
7904         (insert_type_address_space, increase_expout_size): Replace
7905         "parser_state" with "expr_builder".
7906         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7907         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7908         "parser_state" with "expr_builder".
7909
7910 2019-04-04  Tom Tromey  <tom@tromey.com>
7911
7912         * rust-exp.y: Replace "parse_language" with method call.
7913         * p-exp.y:
7914         (yylex): Replace "parse_language" with method call.
7915         * m2-exp.y:
7916         (yylex): Replace "parse_language" with method call.
7917         * go-exp.y (classify_name): Replace "parse_language" with method
7918         call.
7919         * f-exp.y (yylex): Replace "parse_language" with method call.
7920         * d-exp.y (lex_one_token): Replace "parse_language" with method
7921         call.
7922         * c-exp.y:
7923         (lex_one_token, classify_name, yylex): Replace "parse_language"
7924         with method call.
7925         * ada-exp.y (find_primitive_type, type_char)
7926         (type_system_address): Replace "parse_language" with method call.
7927
7928 2019-04-04  Tom Tromey  <tom@tromey.com>
7929
7930         * rust-exp.y: Replace "parse_gdbarch" with method call.
7931         * parse.c (write_dollar_variable, insert_type_address_space):
7932         Replace "parse_gdbarch" with method call.
7933         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7934         call.
7935         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7936         call.
7937         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7938         "parse_gdbarch" with method call.
7939         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7940         with method call.
7941         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7942         "parse_gdbarch" with method call.
7943         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7944         "parse_gdbarch" with method call.
7945         * c-exp.y (parse_type, parse_number, classify_name): Replace
7946         "parse_gdbarch" with method call.
7947         * ada-lex.l: Replace "parse_gdbarch" with method call.
7948         * ada-exp.y (parse_type, find_primitive_type, type_char)
7949         (type_system_address): Replace "parse_gdbarch" with method call.
7950
7951 2019-04-04  Tom Tromey  <tom@tromey.com>
7952
7953         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7954         * stap-probe.c (stap_parse_argument): Update.
7955         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7956         initial_size parameter.
7957         * rust-exp.y (rust_lex_tests): Update.
7958         * parse.c (parser_state): Update.
7959         (parse_exp_in_context): Update.
7960         * parser-defs.h (struct parser_state) <parser_state>: Remove
7961         "initial_size" parameter.
7962
7963 2019-04-04  Tom Tromey  <tom@tromey.com>
7964
7965         * parser-defs.h (increase_expout_size): Don't declare.
7966         * parse.c (increase_expout_size): Now static.
7967
7968 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7969
7970         * gnu-nat.c (gnu_nat_target::wait): Fix
7971         target_waitstatus_to_string call.
7972
7973 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7974
7975         * eval.c (evaluate_subexp_standard): Handle internal functions
7976         during Fortran function call handling.
7977
7978 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7979
7980         * NEWS: Mention new internal functions.
7981         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7982         (read_base_type): Use dwarf2_init_complex_target_type.
7983         * value.c (creal_internal_fn): New function.
7984         (cimag_internal_fn): New function.
7985         (_initialize_values): Register new internal functions.
7986
7987 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7988
7989         * infrun.c (stop_all_threads): If debug_infrun, always
7990         trace the wait status after wait_one, using
7991         target_waitstatus_to_string and target_pid_to_str.
7992         (handle_inferior_event): Replace various trace of
7993         wait status kind by a single trace.
7994         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7995         wait status kind image by target_waitstatus_to_string.
7996         * target/waitstatus.c (target_waitstatus_to_string): Fix
7997         obsolete comment.
7998
7999 2019-04-01  Tom Tromey  <tromey@adacore.com>
8000
8001         PR symtab/23331:
8002         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8003
8004 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8005             Pedro Alves  <palves@redhat.com>
8006
8007         * top.c (quit_force): Call 'finalize_values'.
8008         * value.c (finalize_values): New function.
8009         * value.h (finalize_values): Declare.
8010
8011 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8012
8013         * NEWS: Announce $_gdb_major and $_gdb_minor.
8014
8015         * top.c (init_gdb_version_vars): New function.
8016         (gdb_init): Call init_gdb_version_vars.
8017
8018 2019-03-29  Tom Tromey  <tromey@adacore.com>
8019
8020         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8021         help text.  Remove dead code.
8022
8023 2019-03-29  Keith Seitz  <keiths@redhat.com>
8024
8025         From Siddhesh Poyarekar:
8026         * f-lang.h (f77_get_upperbound): Return LONGEST.
8027         (f77_get_lowerbound): Likewise.
8028         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8029         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8030         print them.
8031         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8032         plongest to format print it.
8033         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8034         (f77_get_upperbound): Likewise.
8035         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8036         LOWER_BOUND to LONGEST.
8037         (f77_create_arrayprint_offset_tbl): Likewise.
8038
8039 2019-03-29  Keith Seitz  <keiths@redhat.com>
8040
8041         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8042         %s/pulongest for TYPE_LENGTH instead of %d in format
8043         strings.
8044         * ada-typerint.c (ada_print_type): Likewise.
8045         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8046         * compile/compile-c-support.c (generate_register_struct): Likewise.
8047         * gdbtypes.c (recursive_dump_type): Likewise.
8048         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8049         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8050         instead of %d in format strings.
8051         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8052         to std::min to ULONGEST.
8053         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8054         instead of %d in format strings.
8055         * tracepoint.c (info_scope_command): Likewise.
8056         * typeprint.c (print_offset_data::update)
8057         (print_offset_data::finish): Likewise.
8058         * xtensa-tdep.c (xtensa_store_return_value)
8059         (xtensa_push_dummy_call): Likewise.
8060
8061 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8062
8063         * windows-nat.c (display_selector): Fixed format specifications
8064         for 64-bit Cygwin.
8065
8066 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8067
8068         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8069
8070 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8071
8072         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8073         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8074         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8075         (nios2_linux_init_abi): Install it.
8076
8077 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8078
8079         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8080
8081 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8082
8083         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8084
8085 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8086             Tom Tromey  <tromey@adacore.com>
8087
8088         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8089
8090 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8091
8092         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8093         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8094         method to compute the bounds of range types. Also print "[evaluated]"
8095         if the bounds' values come from a dynamic evaluation.
8096
8097 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8098
8099         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8100         whitespace when pretty printing is on.
8101
8102 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8103
8104         * ppc-linux-nat.c: Add include.
8105
8106 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8107
8108         * NEWS: Mention AArch64 Pointer Authentication.
8109
8110 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8111
8112         * arm-linux-nat.c: Add include.
8113
8114 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8115
8116         * source-cache.c (source_cache::get_source_lines): Re-read
8117         fullname after calling open_source_file.
8118
8119 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8120
8121         * NEWS: Mention TLS support for FreeBSD.
8122
8123 2019-03-25  Tom Tromey  <tromey@adacore.com>
8124
8125         * minsyms.c (BUNCH_SIZE): Update comment.
8126         (~minimal_symbol_reader): Remove old comment.
8127         (compact_minimal_symbols): Update comment.
8128         (minimal_symbol_reader::install): Remove old comment.  Update
8129         other comments.
8130
8131 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8132
8133         * s390-linux-nat.c: Add include.
8134
8135 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8136
8137         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8138         Call linux_get_hwcap.
8139         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8140         Likewise.
8141         (aarch64_linux_get_hwcap): Remove function.
8142         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8143         declaration.
8144         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8145         linux_get_hwcap.
8146         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8147         * linux-tdep.c (linux_get_hwcap): Add function.
8148         (linux_get_hwcap2): Likewise.
8149         * linux-tdep.h (linux_get_hwcap): Add declaration.
8150         (linux_get_hwcap2): Likewise.
8151         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8152         (ppc_linux_get_hwcap2): Likewise.
8153         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8154         linux_get_hwcap.
8155         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8156         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8157         (ppc_linux_nat_target::read_description): Likewise.
8158         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8159         * s390-linux-nat.c: Likewise.
8160         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8161
8162 2019-03-24  Tom Tromey  <tom@tromey.com>
8163
8164         * ada-lang.c (standard_lookup): Simplify initialization.
8165         (ada_lookup_symbol_nonlocal): Simplify return.
8166         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8167         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8168         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8169         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8170         initialization.
8171         * solib.c (solib_global_lookup): Simplify.
8172         * symtab.c (null_block_symbol): Remove.
8173         (symbol_cache_lookup): Simplify returns.
8174         (lookup_language_this): Simplify returns.
8175         (lookup_symbol_aux): Simplify return.
8176         (lookup_local_symbol): Simplify returns.
8177         (lookup_global_symbol_from_objfile): Simplify return.
8178         (lookup_symbol_in_objfile_symtabs)
8179         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8180         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8181         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8182         * cp-namespace.c (cp_lookup_bare_symbol)
8183         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8184         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8185         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8186         (cp_lookup_symbol_via_imports): Simplify initialization.
8187         (find_symbol_in_baseclass): Likewise.
8188         * symtab.h (null_block_symbol): Remove.
8189         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8190         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8191         (d_lookup_symbol_module): Likewise.
8192         (find_symbol_in_baseclass): Simplify initialization.
8193
8194 2019-03-24  Tom Tromey  <tom@tromey.com>
8195
8196         * expression.h: Don't include symtab.h.
8197         (struct block): Forward declare.
8198
8199 2019-03-24  Tom Tromey  <tom@tromey.com>
8200
8201         * c-exp.y (typebase): Remove casts.
8202         * gdbtypes.c (lookup_unsigned_typename, )
8203         (lookup_signed_typename): Remove cast.
8204         * eval.c (parse_to_comma_and_eval): Remove cast.
8205         * parse.c (write_dollar_variable): Remove cast.
8206         * block.h (struct block) <superblock>: Now const.
8207         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8208         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8209         (map_block): Make "block" const.
8210         * symfile.h (struct quick_symbol_functions)
8211         <map_matching_symbols>: Constify block argument to "callback".
8212         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8213         const.
8214         (find_pc_sect_compunit_symtab): Make "b" const.
8215         (find_symbol_at_address): Likewise.
8216         (search_symbols): Likewise.
8217         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8218         (dw2_debug_names_lookup_symbol): Likewise.
8219         (dw2_map_matching_symbols): Update.
8220         * p-valprint.c (pascal_val_print): Remove "block".
8221         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8222         (aux_add_nonlocal_symbols): Make "block" const.
8223         (resolve_subexp): Remove cast.
8224         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8225         const.
8226         (iterate_over_file_blocks): Likewise.
8227         * f-exp.y (%union) <bval>: Remove.
8228         * coffread.c (patch_opaque_types): Make "b" const.
8229         * spu-tdep.c (spu_catch_start): Make "block" const.
8230         * c-valprint.c (print_unpacked_pointer): Remove "block".
8231         * symmisc.c (dump_symtab_1): Make "b" const.
8232         (block_depth): Make "block" const.
8233         * d-exp.y (%union) <bval>: Remove.
8234         * cp-support.h (cp_lookup_rtti_type): Update.
8235         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8236         * psymtab.c (psym_lookup_symbol): Make "block" const.
8237         (maintenance_check_psymtabs): Make "b" const.
8238         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8239         (enumerate_locals, enumerate_args): Update.
8240         * python/py-symtab.c (stpy_global_block): Make "block" const.
8241         (stpy_static_block): Likewise.
8242         * inline-frame.c (block_starting_point_at): Make "new_block"
8243         const.
8244         * block.c (find_block_in_blockvector): Make return type const.
8245         (blockvector_for_pc_sect): Make "b" const.
8246         (find_block_in_blockvector): Make "b" const.
8247
8248 2019-03-23  Tom Tromey  <tom@tromey.com>
8249
8250         * varobj.c (varobj_create): Update.
8251         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8252         * printcmd.c (display_command, do_one_display): Don't reset
8253         innermost_block.
8254         * parser-defs.h (enum innermost_block_tracker_type): Move to
8255         expression.h.
8256         (innermost_block): Update comment.
8257         * parse.c (parse_exp_1): Add tracker_types parameter.
8258         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8259         tracker_types parameter.  Reset innermost_block.
8260         (parse_exp_in_context): Remove.
8261         (parse_expression_for_completion): Update.
8262         * objfiles.c (~objfile): Don't reset expression_context_block or
8263         innermost_block.
8264         * expression.h (enum innermost_block_tracker_type): Move from
8265         parser-defs.h.
8266         (parse_exp_1): Add tracker_types parameter.
8267         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8268         reset innermost_block.
8269
8270 2019-03-23  Tom Tromey  <tom@tromey.com>
8271
8272         * objfiles.h: Include bcache.h.
8273
8274 2019-03-23  Tom Tromey  <tom@tromey.com>
8275
8276         * linespec.c (get_current_search_block): Use
8277         scoped_restore_current_language.
8278         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8279
8280 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8281             Jiong Wang  <jiong.wang@arm.com>
8282
8283         * aarch64-linux-tdep.c
8284         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8285         section.
8286         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8287
8288 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8289             Jiong Wang  <jiong.wang@arm.com>
8290
8291         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8292         instructions.
8293         (aarch64_analyze_prologue_test): Add PACIASP test.
8294         (aarch64_prologue_prev_register): Unmask PC value.
8295
8296 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8297             Jiong Wang  <jiong.wang@arm.com>
8298
8299         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8300         (aarch64_dwarf2_prev_register): Unmask PC value.
8301         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8302         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8303         DW_CFA_AARCH64_negate_ra_state.
8304         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8305
8306 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8307             Jiong Wang  <jiong.wang@arm.com>
8308
8309         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8310         registers.
8311         (aarch64_pseudo_register_name): Likewise.
8312         (aarch64_pseudo_register_type): Likewise.
8313         (aarch64_pseudo_register_reggroup_p): Likewise.
8314         (aarch64_gdbarch_init): Add pauth registers.
8315         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8316         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8317         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8318         (struct gdbarch_tdep): Add regnum for ra_state.
8319
8320 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8321             Jiong Wang  <jiong.wang@arm.com>
8322
8323         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8324
8325 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8326             Jiong Wang  <jiong.wang@arm.com>
8327
8328         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8329         function.
8330         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8331         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8332         (aarch64_gdbarch_init): Add puth registers.
8333         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8334         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8335         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8336
8337 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8338             Jiong Wang  <jiong.wang@arm.com>
8339
8340         * aarch64-linux-nat.c
8341         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8342         * aarch64-linux-tdep.c
8343         (aarch64_linux_core_read_description): Likewise.
8344         (aarch64_linux_get_hwcap): New function.
8345         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8346         (aarch64_linux_get_hwcap): New declaration.
8347
8348 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8349             Jiong Wang  <jiong.wang@arm.com>
8350
8351         * aarch64-linux-nat.c
8352         (aarch64_linux_nat_target::read_description): Add pauth param.
8353         * aarch64-linux-tdep.c
8354         (aarch64_linux_core_read_description): Likewise.
8355         * aarch64-tdep.c (struct target_desc): Add in pauth.
8356         (aarch64_read_description): Add pauth param.
8357         (aarch64_gdbarch_init): Likewise.
8358         * aarch64-tdep.h (aarch64_read_description): Likewise.
8359         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8360         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8361         * features/Makefile: Add new files.
8362         * features/aarch64-pauth.c: New file.
8363         * features/aarch64-pauth.xml: New file.
8364
8365 2019-03-20  Tom Tromey  <tromey@adacore.com>
8366
8367         * infrun.c (handle_inferior_event): Rename from
8368         handle_inferior_event_1.  Create a scoped_value_mark.
8369         (handle_inferior_event): Remove.
8370
8371 2019-03-19  Tom Tromey  <tromey@adacore.com>
8372
8373         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8374         * infrun.h (print_stop_event): Add "displays" parameter.
8375         * infrun.c (print_stop_event): Add "displays" parameter.
8376
8377 2019-03-19  Pedro Alves  <palves@redhat.com>
8378
8379         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8380         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8381         to -1.  Fix TABs vs spaces.
8382         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8383         * tui/tui-out.h (tui_ui_out) Add intro comments.
8384         <m_line, m_start_of_line>: In-class initialize, and add describing
8385         comment.
8386
8387 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8388
8389         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8390         variable names.
8391         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8392
8393 2019-03-18  Pedro Alves  <palves@redhat.com>
8394             Eli Zaretskii <eliz@gnu.org>
8395
8396         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8397         m_line and m_start_of_line.
8398
8399 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8400
8401         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8402         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8403         it returns a newline.  This fixes a regression in TU mode, whereby
8404         the next line is output on the same screen line as the user input.
8405
8406 2019-03-18  Tom Tromey  <tromey@adacore.com>
8407
8408         * minsyms.c (minimal_symbol_reader::install): Remove call to
8409         obstack_blank.
8410
8411 2019-03-18  Pedro Alves  <palves@redhat.com>
8412
8413         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8414         New globals.
8415         (apply_style): New, factored out from ...
8416         (apply_ansi_escape): ... this.  Handle reverse video mode.
8417         (tui_set_reverse_mode): New function.
8418         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8419         * tui/tui-winsource.c (tui_show_source_line): Use
8420         tui_set_reverse_mode instead of setting A_STANDOUT.
8421         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8422         New setter methods.
8423
8424 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8425
8426         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8427         Handle tabs.
8428
8429 2019-03-18  Tom Tromey  <tromey@adacore.com>
8430
8431         * ada-lang.c (empty_array): Add "high" parameter.
8432         (ada_evaluate_subexp): Update.
8433
8434 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8435
8436         * unittests/string_view-selftests.c: Define
8437         _initialize_string_view_selftests unconditionally.
8438
8439 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8440
8441         PR gdb/24350
8442         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8443
8444 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8445
8446         PR gdb/24351
8447         * windows-nat.c (display_selector): Fix format specifiers.
8448
8449 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8450
8451         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8452         tui_refill_source_window instead of tui_refresh_win, to update the
8453         current execution line.  This fixes redisplay of the current line
8454         when stepping through the code with "next" or "step".
8455
8456 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8457
8458         * source-cache.c (source_cache::get_source_lines): Call
8459         find_source_lines to initialize s->nlines.  This fixes vertical
8460         scrolling of TUI source window when the DOWN arrow is pressed.
8461
8462 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8463
8464         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8465         linux-thread-db.c (_initialize_thread_db): Likewise.
8466
8467 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8468
8469         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8470         wclrtoeol in tui_show_source_line".  This reverts changes made in
8471         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8472
8473 2019-03-15  Tom Tromey  <tom@tromey.com>
8474
8475         * symtab.h (struct minimal_symbol): Derive from
8476         general_symbol_info.
8477         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8478         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8479         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8480         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8481         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8482         (MSYMBOL_SEARCH_NAME): Update.
8483         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8484         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8485         * minsyms.c (minimal_symbol_reader::record_full): Update.
8486
8487 2019-03-15  Tom Tromey  <tom@tromey.com>
8488
8489         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8490
8491 2019-03-15  Tom Tromey  <tom@tromey.com>
8492
8493         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8494         unique_xmalloc_ptr.
8495         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8496         Update.
8497         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8498         (build_minimal_symbol_hash_tables)
8499         (minimal_symbol_reader::install): Update.
8500
8501 2019-03-15  Tom Tromey  <tom@tromey.com>
8502
8503         * symtab.c (create_demangled_names_hash): Update.
8504         (symbol_set_names): Update.
8505         * objfiles.h (struct objfile_per_bfd_storage)
8506         <demangled_names_hash>: Now an htab_up.
8507         * objfiles.c (objfile_per_bfd_storage): Simplify.
8508
8509 2019-03-15  Tom Tromey  <tom@tromey.com>
8510
8511         * objfiles.h (struct objfile_per_bfd_storage): Declare
8512         destructor.
8513         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8514         New.
8515         (get_objfile_bfd_data): Use new.  Don't initialize
8516         language_of_main.
8517         (free_objfile_per_bfd_storage): Remove.
8518         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8519
8520 2019-03-15  Tom Tromey  <tom@tromey.com>
8521
8522         * symfile.c (reread_symbols): Update.
8523         * objfiles.c (objfile::objfile): Update.
8524         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8525         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8526         comment.
8527         (minimal_symbol_reader::install): Update.
8528         (terminate_minimal_symbol_table): Remove.
8529         * jit.c (jit_object_close_impl): Update.
8530
8531 2019-03-15  Tom Tromey  <tom@tromey.com>
8532
8533         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8534         initializations.
8535
8536 2019-03-15  Tom Tromey  <tom@tromey.com>
8537
8538         * objfiles.h (struct objfile_per_bfd_storage)
8539         <demangled_hash_languages>: Now a bitset.
8540         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8541         (lookup_minimal_symbol): Update.
8542
8543 2019-03-15  Tom Tromey  <tom@tromey.com>
8544
8545         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8546         Don't return the symbol.
8547         * coffread.c (record_minimal_symbol): Use record_full.
8548
8549 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8550
8551         The MS-Windows port of ncurses fails to switch to a color pair if
8552         one or both of the colors are the implicit default colors.  This
8553         change records the default colors when TUI is initialized, and
8554         then specifies them explicitly when a color pair uses the default
8555         colors.  This allows color styling in TUI mode on MS-Windows.
8556
8557         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8558         ncurses_norm_attr.
8559         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8560         colors in ncurses_norm_attr.
8561         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8562         "none", replace it with the default color recorded in
8563         ncurses_norm_attr.
8564
8565 2019-03-14  Tom Tromey  <tromey@adacore.com>
8566
8567         * source-cache.h (class source_cache) <get_source_lines>: Return
8568         std::string.
8569         * source-cache.c (source_cache::extract_lines): Handle case where
8570         first_pos==npos.  Return std::string.
8571         (source_cache::get_source_lines): Update.
8572
8573 2019-03-14  Tom Tromey  <tromey@adacore.com>
8574
8575         * NEWS: Add item for "style sources" commands.
8576         * source-cache.c (source_cache::get_source_lines): Check
8577         source_styling.
8578         * cli/cli-style.c (source_styling): New global.
8579         (_initialize_cli_style): Add "style sources" commands.
8580         (show_style_sources): New function.
8581         * cli/cli-style.h (source_styling): Declare.
8582
8583 2019-03-14  Pedro Alves  <palves@redhat.com>
8584             Tom Tromey  <tromey@adacore.com>
8585
8586         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8587         * tui/tui-winsource.c (tui_refill_source_window): New function,
8588         from...
8589         (tui_horizontal_source_scroll): ... here.  Move some logic.
8590         * cli/cli-style.c (set_style_enabled): Notify new observable.
8591         * tui/tui-hooks.c (tui_redisplay_source): New function.
8592         (tui_attach_detach_observers): Attach or detach
8593         tui_redisplay_source.
8594         * observable.h (source_styling_changed): New observable.
8595         * observable.c: Define source_styling_changed observable.
8596
8597 2019-03-13  Tom Tromey  <tromey@adacore.com>
8598
8599         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8600         (i386_gnu_nat_target::store_registers): Update.
8601         * target-debug.h (target_debug_print_std_string): New macro.
8602         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8603         * windows-tdep.c (display_one_tib): Update.
8604         * tui/tui-stack.c (tui_make_status_line): Update.
8605         * top.c (print_inferior_quit_action): Update.
8606         * thread.c (thr_try_catch_cmd): Update.
8607         (add_thread_with_info): Update.
8608         (thread_target_id_str): Update.
8609         (thr_try_catch_cmd): Update.
8610         (thread_command): Update.
8611         (thread_find_command): Update.
8612         * record-btrace.c (record_btrace_target::info_record)
8613         (record_btrace_resume_thread, record_btrace_target::resume)
8614         (record_btrace_cancel_resume, record_btrace_step_thread)
8615         (record_btrace_target::wait, record_btrace_target::wait)
8616         (record_btrace_target::wait, record_btrace_target::stop): Update.
8617         * progspace.c (print_program_space): Update.
8618         * process-stratum-target.c
8619         (process_stratum_target::thread_address_space): Update.
8620         * linux-fork.c (linux_fork_mourn_inferior)
8621         (detach_checkpoint_command, info_checkpoints_command)
8622         (linux_fork_context): Update.
8623         (linux_fork_detach): Update.
8624         (class scoped_switch_fork_info): Update.
8625         (delete_checkpoint_command): Update.
8626         * infrun.c (follow_fork_inferior): Update.
8627         (follow_fork_inferior): Update.
8628         (proceed_after_vfork_done): Update.
8629         (handle_vfork_child_exec_or_exit): Update.
8630         (follow_exec): Update.
8631         (displaced_step_prepare_throw): Update.
8632         (displaced_step_restore): Update.
8633         (start_step_over): Update.
8634         (resume_1): Update.
8635         (clear_proceed_status_thread): Update.
8636         (proceed): Update.
8637         (print_target_wait_results): Update.
8638         (do_target_wait): Update.
8639         (context_switch): Update.
8640         (stop_all_threads): Update.
8641         (restart_threads): Update.
8642         (finish_step_over): Update.
8643         (handle_signal_stop): Update.
8644         (switch_back_to_stepped_thread): Update.
8645         (keep_going_pass_signal): Update.
8646         (print_exited_reason): Update.
8647         (normal_stop): Update.
8648         * inferior.c (inferior_pid_to_str): Change return type.
8649         (print_selected_inferior): Update.
8650         (add_inferior): Update.
8651         (detach_inferior): Update.
8652         * dummy-frame.c (fprint_dummy_frames): Update.
8653         * dcache.c (dcache_info_1): Update.
8654         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8655         (btrace_fetch, btrace_clear): Update.
8656         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8657         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8658         type.
8659         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8660         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8661         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8662         * gdbarch.c, gdbarch.h: Rebuild.
8663         * gdbarch.sh (core_pid_to_str): Change return type.
8664         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8665         return type.
8666         (windows_nat_target::pid_to_str): Change return type.
8667         (windows_delete_thread): Update.
8668         (windows_nat_target::attach): Update.
8669         (windows_nat_target::files_info): Update.
8670         * target-delegates.c: Rebuild.
8671         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8672         return type.
8673         (sol_thread_target::pid_to_str): Change return type.
8674         * remote.c (class remote_target) <pid_to_str>: Change return
8675         type.
8676         (remote_target::pid_to_str): Change return type.
8677         (extended_remote_target::attach, remote_target::remote_stop_ns)
8678         (remote_target::remote_notif_remove_queued_reply)
8679         (remote_target::push_stop_reply, remote_target::disable_btrace):
8680         Update.
8681         (extended_remote_target::attach): Update.
8682         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8683         type.
8684         (gdbsim_target::pid_to_str): Change return type.
8685         * ravenscar-thread.c (struct ravenscar_thread_target)
8686         <pid_to_str>: Change return type.
8687         (ravenscar_thread_target::pid_to_str): Change return type.
8688         * procfs.c (class procfs_target) <pid_to_str>: Change return
8689         type.
8690         (procfs_target::pid_to_str): Change return type.
8691         (procfs_target::attach): Update.
8692         (procfs_target::detach): Update.
8693         (procfs_target::fetch_registers): Update.
8694         (procfs_target::store_registers): Update.
8695         (procfs_target::wait): Update.
8696         (procfs_target::files_info): Update.
8697         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8698         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8699         return type.
8700         (nto_procfs_target::pid_to_str): Change return type.
8701         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8702         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8703         return type.
8704         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8705         (exit_lwp): Update.
8706         (attach_proc_task_lwp_callback, get_detach_signal)
8707         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8708         (linux_nat_target::resume, wait_lwp, stop_callback)
8709         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8710         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8711         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8712         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8713         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8714         type.
8715         (inf_ptrace_target::attach): Update.
8716         (inf_ptrace_target::files_info): Update.
8717         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8718         type.
8719         (go32_nat_target::pid_to_str): Change return type.
8720         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8721         (gnu_nat_target::wait): Update.
8722         (gnu_nat_target::wait): Update.
8723         (gnu_nat_target::resume): Update.
8724         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8725         (fbsd_nat_target::wait): Update.
8726         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8727         type.
8728         (darwin_nat_target::attach): Update.
8729         * corelow.c (class core_target) <pid_to_str>: Change return type.
8730         (core_target::pid_to_str): Change return type.
8731         * target.c (normal_pid_to_str): Change return type.
8732         (default_pid_to_str): Likewise.
8733         (target_pid_to_str): Change return type.
8734         (target_translate_tls_address): Update.
8735         (target_announce_detach): Update.
8736         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8737         return type.
8738         (bsd_uthread_target::pid_to_str): Change return type.
8739         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8740         type.
8741         (bsd_kvm_target::pid_to_str): Change return type.
8742         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8743         return type.
8744         (aix_thread_target::pid_to_str): Change return type.
8745         * target.h (struct target_ops) <pid_to_str>: Change return type.
8746         (target_pid_to_str, normal_pid_to_str): Likewise.
8747         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8748         type.
8749         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8750         type.
8751         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8752         return type.
8753         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8754         type.
8755         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8756         type.
8757         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8758         return type.
8759
8760 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8761
8762         * NEWS: Mention that the new default MI version is 3.  Mention
8763         changes to the output of commands and events that deal with
8764         multi-location breakpoints.
8765         * breakpoint.c: Include "mi/mi-out.h".
8766         (print_one_breakpoint): Change output syntax if using MI version
8767         >= 3.
8768         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8769         New.
8770         (mi_multi_location_breakpoint_output_fixed): New.
8771         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8772         (mi_cmd_fix_multi_location_breakpoint_output): New.
8773         (mi_multi_location_breakpoint_output_fixed): New.
8774         * mi/mi-cmds.c (mi_cmds): Register command
8775         -fix-multi-location-breakpoint-output.
8776         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8777         interpreter "mi".
8778
8779 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8780
8781         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8782         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8783         instantiate mi_ui_out based on interpreter name.
8784         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8785         * mi/mi-main.c (mi_load_progress): Likewise.
8786
8787 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8788
8789         * NEWS: Combine separate "New targets" sections for 8.3.
8790
8791 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8792
8793         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8794         (ppcfbsd_init_abi): Install gdbarch
8795         "fetch_tls_load_module_address" and "get_thread_local_address"
8796         methods.
8797
8798 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8799
8800         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8801         (riscv_fbsd_init_abi): Install gdbarch
8802         "fetch_tls_load_module_address" and "get_thread_local_address"
8803         methods.
8804
8805 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8806
8807         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8808         (i386fbsd_init_abi): Install gdbarch
8809         "fetch_tls_load_module_address" and "get_thread_local_address"
8810         methods.
8811
8812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8813
8814         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8815         (amd64fbsd_init_abi): Install gdbarch
8816         "fetch_tls_load_module_address" and "get_thread_local_address"
8817         methods.
8818
8819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8820
8821         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8822         (struct fbsd_pspace_data): New type.
8823         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8824         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8825         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8826         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8827         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8828
8829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8830
8831         * gdbtypes.c (lookup_struct_elt): New function.
8832         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8833         * gdbtypes.h (struct struct_elt): New type.
8834         (lookup_struct_elt): New prototype.
8835
8836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8837
8838         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8839         remove disabled code block.
8840
8841 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8842
8843         * gdbarch.sh (get_thread_local_address): New method.
8844         * gdbarch.h, gdbarch.c: Regenerate.
8845         * target.c (target_translate_tls_address): Use
8846         gdbarch_get_thread_local_address if present instead of
8847         target::get_thread_local_address.
8848
8849 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8850
8851         * target.h (target::get_thread_local_address): Update comment.
8852
8853 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8854
8855         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8856         objfile->separate_debug_objfile_backlink if not NULL.
8857
8858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8859
8860         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8861         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8862         (amd64bsd_store_inferior_registers): Likewise.
8863         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8864         Enable segment base registers.
8865         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8866         PT_GETFSBASE and PT_GETGSBASE.
8867         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8868         PT_SETGSBASE.
8869         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8870         segment base registers.
8871         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8872
8873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8874
8875         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8876         Update calls to i386_target_description to add 'segments'
8877         parameter.
8878         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8879         add segment base registers.
8880         * arch/i386.c (i386_create_target_description): Add 'segments'
8881         parameter to enable segment base registers.
8882         * arch/i386.h (i386_create_target_description): Likewise.
8883         * features/i386/32bit-segments.xml: New file.
8884         * features/i386/32bit-segments.c: Generate.
8885         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8886         call to i386_target_description to add 'segments' parameter.
8887         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8888         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8889         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8890         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8891         if feature is present.
8892         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8893         Add 'segments' parameter to call to i386_target_description.
8894         (i386_target_description): Add 'segments' parameter to enable
8895         segment base registers.
8896         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8897         to call to i386_target_description.
8898         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8899         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8900         Define I386_NUM_REGS.
8901         (i386_target_description): Add 'segments' parameter to enable
8902         segment base registers.
8903
8904 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8905
8906         PR/24325
8907         * source-cache.c: #undef open and close, to avoid unresolved
8908         externals during linking.
8909
8910 2019-03-12  Tom Tromey  <tromey@adacore.com>
8911
8912         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8913         const.  Add initializers.
8914         (_initialize_remote): Don't initialize ptid globals.
8915
8916 2019-03-12  Pedro Alves  <palves@redhat.com>
8917
8918         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8919
8920 2019-03-12  Pedro Alves  <palves@redhat.com>
8921
8922         * cp-name-parser.y (main): Remove unused 'len' variable.
8923
8924 2019-03-12  Tom Tromey  <tromey@adacore.com>
8925
8926         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8927         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8928
8929 2019-03-12  Tom Tromey  <tromey@adacore.com>
8930
8931         * linux-nat.c (iterate_over_lwps): Update.
8932         (stop_callback): Remove parameter.
8933         (stop_wait_callback, detach_callback, resume_set_callback)
8934         (select_singlestep_lwp_callback, set_ignore_sigint)
8935         (status_callback, resumed_callback, resume_clear_callback)
8936         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8937         data parameter.
8938         (linux_nat_target::detach, linux_nat_target::resume)
8939         (linux_stop_and_wait_all_lwps, select_event_lwp)
8940         (linux_nat_filter_event, linux_nat_wait_1)
8941         (linux_nat_target::kill, linux_nat_target::stop)
8942         (linux_nat_target::stop): Update.
8943         (linux_nat_resume_callback): Change type.
8944         (resume_stopped_resumed_lwps, count_events_callback)
8945         (select_event_lwp_callback): Likewise.
8946         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8947         * arm-linux-nat.c (struct update_registers_data): Remove.
8948         (update_registers_callback): Change type.
8949         (arm_linux_insert_hw_breakpoint1): Update.
8950         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8951         parameter.
8952         (x86_linux_dr_set_addr): Update.
8953         (x86_linux_dr_set_control): Update.
8954         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8955         (iterate_over_lwps): Use gdb::function_view.
8956         * nat/aarch64-linux-hw-point.c (struct
8957         aarch64_dr_update_callback_param): Remove.
8958         (debug_reg_change_callback): Change type.
8959         (aarch64_notify_debug_reg_change): Update.
8960         * s390-linux-nat.c (s390_refresh_per_info): Update.
8961
8962 2019-03-11  Tom Tromey  <tromey@adacore.com>
8963
8964         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8965         redundant assignment to "this_cu".
8966
8967 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8968
8969         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8970
8971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8972
8973         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8974         from...
8975         (rank_one_type): ... this.
8976
8977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8978
8979         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8980         from...
8981         (rank_one_type): ... this.
8982
8983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8984
8985         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8986         from...
8987         (rank_one_type): ... this.
8988
8989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8990
8991         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8992         from...
8993         (rank_one_type): ... this.
8994
8995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8996
8997         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8998         from...
8999         (rank_one_type): ... this.
9000
9001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9002
9003         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9004         from...
9005         (rank_one_type): ... this.
9006
9007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9008
9009         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9010         from...
9011         (rank_one_type): ... this.
9012
9013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9014
9015         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9016         from...
9017         (rank_one_type): ... this.
9018
9019 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9020
9021         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9022         from...
9023         (rank_one_type): ... this.
9024
9025 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9026
9027         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9028         from...
9029         (rank_one_type): ... this.
9030
9031 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9032
9033         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9034         from...
9035         (rank_one_type): ... this.
9036
9037 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9038
9039         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9040         from...
9041         (rank_one_type): ... this.
9042
9043 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9044
9045         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9046         inferior-events' shows the example events.
9047
9048 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9049
9050         Support styling on native MS-Windows console
9051
9052         PR/24315
9053         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9054         on MS-Windows if $TERM is not defined.
9055
9056         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9057
9058         * posix-hdep.c (gdb_console_fputs):
9059         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9060         functions.
9061         * ui-file.h (gdb_console_fputs): Add prototype.
9062
9063         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9064         back to fputs only if the former returns zero.
9065
9066 2019-03-07  Tom Tromey  <tom@tromey.com>
9067
9068         * symmisc.c (print_symbol_bcache_statistics): Update.
9069         (print_objfile_statistics): Update.
9070         * symfile.c (allocate_symtab): Update.
9071         * stabsread.c: Don't include bcache.h.
9072         * psymtab.h (struct psymbol_bcache): Don't declare.
9073         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9074         (psymbol_bcache_init, psymbol_bcache_free)
9075         (psymbol_bcache_get_bcache): Don't declare.
9076         * psymtab.c (struct psymbol_bcache): Remove.
9077         (psymtab_storage::psymtab_storage): Update.
9078         (psymtab_storage::~psymtab_storage): Update.
9079         (psymbol_bcache_init, psymbol_bcache_free)
9080         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9081         (add_psymbol_to_bcache): Update.
9082         (allocate_psymtab): Update.
9083         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9084         macro_cache>: No longer pointers.
9085         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9086         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9087         * macrotab.c (macro_bcache): Update.
9088         * macroexp.c: Don't include bcache.h.
9089         * gdbtypes.c (check_types_worklist): Update.
9090         (types_deeply_equal): Remove TRY/CATCH.  Update.
9091         * elfread.c (elf_symtab_read): Update.
9092         * dwarf2read.c: Don't include bcache.h.
9093         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9094         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9095         (print_bcache_statistics, bcache_memory_used): Don't declare.
9096         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9097         methods.  Rename all data members.
9098         * bcache.c (struct bcache): Move to bcache.h.
9099         (bcache::expand_hash_table): Rename from expand_hash_table.
9100         (bcache): Remove.
9101         (bcache::insert): Rename from bcache_full.
9102         (bcache::compare): Rename from bcache_compare.
9103         (bcache_xmalloc): Remove.
9104         (bcache::~bcache): Rename from bcache_xfree.
9105         (bcache::print_statistics): Rename from print_bcache_statistics.
9106         (bcache::memory_used): Rename from bcache_memory_used.
9107
9108 2019-03-07  Pedro Alves  <palves@redhat.com>
9109
9110         * infrun.c (normal_stop): Also check for
9111         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9112
9113 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9114
9115         * f-lang.c (value_from_host_double): Moved to...
9116         * value.c (value_from_host_double): ...here.
9117         * value.h (value_from_host_double): Declare.
9118         * guile/scm-math.c (vlscm_convert_typed_number): Use
9119         value_from_host_double.
9120         (vlscm_convert_number): Likewise.
9121         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9122         * python/py-value.c (convert_value_from_python): Likewise.
9123
9124 2019-03-06  Tom Tromey  <tom@tromey.com>
9125
9126         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9127
9128 2019-03-06  Tom Tromey  <tom@tromey.com>
9129
9130         * utils.h (free_current_contents): Don't declare.
9131         * utils.c (free_current_contents): Remove.
9132
9133 2019-03-06  Tom Tromey  <tom@tromey.com>
9134
9135         * top.c (quit_force): Update.
9136         * main.c (captured_command_loop): Update.
9137         * common/new-op.c (operator new): Update.
9138         * common/common-exceptions.c (struct catcher)
9139         <save_cleanup_chain>: Remove member.
9140         (exceptions_state_mc_init): Update.
9141         (exception_try_scope_entry): Return nullptr.
9142         (exception_try_scope_exit, exception_rethrow)
9143         (throw_exception_sjlj, throw_exception_cxx): Update.
9144         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9145         (all_cleanups, do_cleanups, discard_cleanups)
9146         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9147         (restore_cleanups, restore_final_cleanups): Don't declare.
9148         (do_final_cleanups): Remove parameter.
9149         * common/cleanups.c (cleanup_chain, make_cleanup)
9150         (make_cleanup_dtor, all_cleanups, do_cleanups)
9151         (discard_my_cleanups, discard_cleanups)
9152         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9153         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9154         (null_cleanup): Remove.
9155         (do_final_cleanups): Remove parameter.
9156
9157 2019-03-06  Tom Tromey  <tom@tromey.com>
9158
9159         * remote.c (remote_target::remote_parse_stop_reply): Use
9160         unique_xmalloc_ptr.
9161
9162 2019-03-06  Tom Tromey  <tom@tromey.com>
9163
9164         * stabsread.c (struct stabs_field_info): Rename from field_info.
9165         <list, fnlist>: Add initializers.
9166         <obstack>: New member.
9167         (read_member_functions, read_struct_fields, read_baseclasses):
9168         Allocate on obstack.  Don't use cleanups.
9169         (read_one_struct_field, read_member_functions, read_struct_fields)
9170         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9171         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9172         (read_struct_type): Update.
9173
9174 2019-03-06  Tom Tromey  <tom@tromey.com>
9175
9176         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9177         * common/filestuff.h (make_cleanup_close): Don't declare.
9178         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9179         Remove.
9180
9181 2019-03-06  Tom Tromey  <tom@tromey.com>
9182
9183         * solib-aix.c: Use make_scope_exit.
9184
9185 2019-03-06  Tom Tromey  <tom@tromey.com>
9186
9187         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9188         Use make_scope_exit.
9189
9190 2019-03-06  Tom Tromey  <tom@tromey.com>
9191
9192         * solib-svr4.c (disable_probes_interface): Remove parameter.
9193         (svr4_handle_solib_event): Use make_scope_exit.
9194
9195 2019-03-06  Tom Tromey  <tom@tromey.com>
9196
9197         * remote.c (struct stop_reply_deleter): Remove.
9198         (stop_reply_up): Update.
9199         (struct stop_reply): Derive from notif_event.  Don't typedef.
9200         <regcache>: Now a std::vector.
9201         (stop_reply_xfree): Remove.
9202         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9203         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9204         (remote_target::discard_pending_stop_replies): Use delete.
9205         (remote_target::remote_parse_stop_reply): Update.
9206         (remote_target::process_stop_reply): Update.
9207         * remote-notif.h (struct notif_event): Add virtual destructor.
9208         Remove "dtr" member.
9209         (struct notif_client) <alloc_event>: Return a unique_ptr.
9210         (notif_event_xfree): Don't declare.
9211         (notif_event_up): New typedef.
9212         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9213         (notif_event_xfree, do_notif_event_xfree): Remove.
9214         (remote_notif_state_xfree): Update.
9215
9216 2019-03-06  Tom Tromey  <tom@tromey.com>
9217
9218         * infrun.c (displaced_step_clear_cleanup): Now a
9219         forward_scope_exit type.
9220         (displaced_step_prepare_throw): Update.
9221         (displaced_step_fixup): Update.
9222
9223 2019-03-06  Tom Tromey  <tom@tromey.com>
9224
9225         * inferior.h (class inferior): Update comment.
9226         * gdbthread.h (class thread_info): Update comment.
9227
9228 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9229             Tom Tromey  <tom@tromey.com>
9230
9231         * stabsread.h (struct stab_section_list): Remove.
9232         (coffstab_build_psymtabs): Update.
9233         * dbxread.c (symbuf_sections): Now a std::vector.
9234         (sect_idx): New global.
9235         (fill_symbuf): Update.
9236         (coffstab_build_psymtabs): Change type of stabsects parameter.
9237         Update.
9238         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9239         std::vector.
9240         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9241         (coff_locate_sections): Update.
9242         (coff_symfile_read): Remove cleanups.  Update.
9243         (init_stringtab): Add storage parameter.
9244         (free_stringtab, free_stringtab_cleanup): Remove.
9245         (init_lineno): Add storage parameter.
9246         (free_linetab, free_linetab_cleanup): Remove.
9247
9248 2019-03-06  Pedro Alves  <palves@redhat.com>
9249
9250         * linux-fork.c (fork_info::clobber_regs): Delete.
9251         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9252         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9253         comment.  Adjust.
9254         (scoped_switch_fork_info::scoped_switch_fork_info)
9255         (checkpoint_command, linux_fork_context): Adjust
9256         fork_save_infrun_state calls.
9257
9258 2019-03-06  Pedro Alves  <palves@redhat.com>
9259
9260         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9261         (inf_has_multiple_threads): Return 'bool' and rewrite using
9262         inferior_info::threads().
9263
9264 2019-03-06  Pedro Alves  <palves@redhat.com>
9265
9266         * linux-fork.c: Include <list>.
9267         (fork_list): Now a std::list instance.
9268         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9269         (forks_exist_p, find_last_fork): Adjust.
9270         (new_fork): Delete.
9271         (one_fork_p): New.
9272         (add_fork): Adjust.
9273         (free_fork): Delete, folded into fork_info::~fork_info().
9274         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9275         Adjust.
9276         (init_fork_list): Delete.
9277         (linux_fork_killall, linux_fork_mourn_inferior)
9278         (linux_fork_detach, info_checkpoints_command): Adjust.
9279         (_initialize_linux_fork): No longer call init_fork_list.
9280
9281 2019-03-06  Pedro Alves  <palves@redhat.com>
9282
9283         * linux-fork.c (new_fork): New, split out of ...
9284         (add_fork): ... this.  Return void.  Move "first fork" special
9285         case from here, to ...
9286         (checkpoint_command): ... here.
9287         * linux-linux.h (add_fork): Return void.
9288
9289 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9292
9293 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9294             Chris January  <chris.january@arm.com>
9295             David Lecomber  <david.lecomber@arm.com>
9296
9297         * f-exp.y: New token, UNOP_INTRINSIC.
9298         (exp): New pattern using UNOP_INTRINSIC token.
9299         (f77_keywords): Add 'abs' keyword.
9300         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9301         (value_from_host_double): New function.
9302         (evaluate_subexp_f): Support UNOP_ABS.
9303
9304 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9305
9306         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9307         types.
9308
9309 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9310
9311         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9312         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9313         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9314
9315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9316
9317         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9318
9319 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9320             Chris January  <chris.january@arm.com>
9321
9322         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9323         * f-exp.y: Define 'KIND' token.
9324         (exp): New pattern for KIND expressions.
9325         (ptype): Handle types with a kind extension.
9326         (direct_abs_decl): Extend to spot kind extensions.
9327         (f77_keywords): Add 'kind' to the list.
9328         (push_kind_type): New function.
9329         (convert_to_kind_type): New function.
9330         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9331         * parse.c (operator_length_standard): Likewise.
9332         * parser-defs.h (enum type_pieces): Add tp_kind.
9333         * std-operator.def: Add UNOP_KIND.
9334
9335 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9336
9337         * f-exp.y (f_parse): Set yydebug.
9338
9339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9340
9341         * f-lang.c (evaluate_subexp_f): New function.
9342         (exp_descriptor_f): New global.
9343         (f_language_defn): Use exp_descriptor_f instead of
9344         exp_descriptor_standard.
9345
9346 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9347
9348         * f-exp.y (struct token): Add comments.
9349         (dot_ops): Remove uppercase versions and the end marker.
9350         (f77_keywords): Likewise.
9351         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9352         entries in the dot_ops array are case insensitive, and use
9353         strncasecmp to compare strings.  Also some whitespace cleanup in
9354         this area.  Similar for the f77_keywords array, except entries in
9355         this list might be case sensitive.
9356
9357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9358
9359         * f-exp.y (struct f77_boolean_val): Add comments.
9360         (boolean_values): Remove uppercase versions, and end marker.
9361         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9362         and use strncasecmp to achieve case insensitivity.  Additionally,
9363         perform whitespace cleanup around this code.
9364
9365 2019-03-06  Tom Tromey  <tromey@adacore.com>
9366
9367         * remote-sim.c (gdbsim_target_open): Use result of
9368         gdb_argv::release.
9369
9370 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9371         Dirk Schubert  <dirk.schubert@arm.com>
9372         Chris January  <chris.january@arm.com>
9373
9374         * eval.c (evaluate_subexp_standard): Call Fortran argument
9375         wrapping logic.
9376         * f-lang.c (struct value): A value which can be passed into a
9377         Fortran function call.
9378         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9379         where appropriate.
9380         (struct type): Value ready for a Fortran function call.
9381         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9382         is needed.
9383         * f-lang.h (fortran_argument_convert): Declaration.
9384         (fortran_preserve_arg_pointer): Declaration.
9385         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9386
9387 2019-03-05  Tom Tromey  <tromey@adacore.com>
9388
9389         * python/py-prettyprint.c (print_string_repr): Remove #if.
9390         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9391
9392 2019-03-05  Tom Tromey  <tromey@adacore.com>
9393
9394         * target.c (the_dummy_target): Move later.  Change type to
9395         "dummy_target".
9396         (initialize_targets): Don't initialize the_dummy_target.
9397
9398 2019-03-05  Tom Tromey  <tromey@adacore.com>
9399
9400         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9401         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9402
9403 2019-03-05  Tom Tromey  <tromey@adacore.com>
9404
9405         * windows-nat.c (windows_nat_target::attach)
9406         (windows_nat_target::detach): Don't call gdb_flush.
9407         * valprint.c (generic_val_print, val_print, val_print_string):
9408         Don't call gdb_flush.
9409         * utils.c (defaulted_query): Don't call gdb_flush.
9410         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9411         * target.c (target_announce_detach): Don't call gdb_flush.
9412         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9413         * remote.c (extended_remote_target::attach): Don't call
9414         gdb_flush.
9415         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9416         * printcmd.c (do_examine): Don't call gdb_flush.
9417         (info_display_command): Don't call gdb_flush.
9418         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9419         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9420         * memattr.c (info_mem_command): Don't call gdb_flush.
9421         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9422         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9423         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9424         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9425         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9426         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9427         (gnu_nat_target::detach): Don't call gdb_flush.
9428         * f-valprint.c (f_val_print): Don't call gdb_flush.
9429         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9430         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9431         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9432         gdb_flush.
9433         * c-valprint.c (c_val_print): Don't call gdb_flush.
9434         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9435
9436 2019-03-05  Tom Tromey  <tromey@adacore.com>
9437
9438         * varobj.c (update_dynamic_varobj_children): Update.
9439         (install_default_visualizer): Use reset, not release.
9440         * value.c (set_internalvar): Update.
9441         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9442         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9443         ATTRIBUTE_UNUSED_RESULT.
9444
9445 2019-03-05  Tom Tromey  <tromey@adacore.com>
9446
9447         * remote.c (class scoped_remote_fd) <release>: Add
9448         ATTRIBUTE_UNUSED_RESULT.
9449
9450 2019-03-05  Tom Tromey  <tromey@adacore.com>
9451
9452         * macroexp.c (struct macro_buffer) <release>: Add
9453         ATTRIBUTE_UNUSED_RESULT.
9454
9455 2019-03-05  Tom Tromey  <tromey@adacore.com>
9456
9457         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9458         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9459         ATTRIBUTE_UNUSED_RESULT.
9460
9461 2019-03-05  Tom Tromey  <tromey@adacore.com>
9462
9463         * common/scoped_fd.h (class scoped_fd) <release>: Add
9464         ATTRIBUTE_UNUSED_RESULT.
9465
9466 2019-03-05  Tom Tromey  <tromey@adacore.com>
9467
9468         * parser-defs.h (struct parser_state) <release>: Add
9469         ATTRIBUTE_UNUSED_RESULT.
9470
9471 2019-03-05  Tom Tromey  <tromey@adacore.com>
9472
9473         * utils.h (class gdb_argv) <release>: Add
9474         ATTRIBUTE_UNUSED_RESULT.
9475         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9476
9477 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9478
9479         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9480         for-loop range, to avoid compiler warnings.
9481
9482         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9483         avoid compiler warnings about unused variables.
9484
9485         * NEWS: Mention end of support for native debugging on MS-Windows
9486         before XP.
9487
9488         PR gdb/24292
9489         * common/netstuff.c:
9490         * gdbserver/gdbreplay.c
9491         * gdbserver/remote-utils.c:
9492         * ser-tcp.c:
9493         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9494         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9495         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9496         'getaddrinfo' and 'freeaddrinfo' were not available before
9497         Windows XP, and mingw.org's MinGW headers by default define
9498         _WIN32_WINNT to 0x500.
9499
9500 2019-03-01  Gary Benson <gbenson@redhat.com>
9501
9502         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9503
9504 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9505             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9506
9507         PR gdb/8527
9508         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9509         set_sigint_trap, clear_sigint_trap.
9510
9511 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9512
9513         * target.c (target_detach): Clear the regcache and the
9514         frame cache.
9515
9516 2019-02-27  Pedro Alves  <palves@redhat.com>
9517
9518         * utils.c (set_screen_size): When we cap the height/width sizes,
9519         tweak the corresponding command variable to show "unlimited":
9520
9521 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9522             Pedro Alves  <palves@redhat.com>
9523
9524         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9525         before calling rl_set_screen_size.
9526
9527 2019-02-27  Tom Tromey  <tromey@adacore.com>
9528
9529         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9530         define.
9531         * python/py-value.c: Remove Python 2.4 workaround.
9532         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9533         workaround.
9534         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9535         Python 2.4 workaround.
9536         * python/python-internal.h: Remove Python 2.4 comment.
9537         (Py_ssize_t): Don't define.
9538         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9539         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9540         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9541         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9542         * python/python.c (do_start_initialization): Remove Python 2.4
9543         workaround.
9544         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9545         (print_children): Remove Python 2.4 workaround.
9546         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9547         workaround.
9548         (CHARBUFFERPROC_NAME): Remove.
9549         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9550         Python 2.4 workaround.
9551
9552 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9553
9554         * NEWS: Note minimum Python version.
9555
9556 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9557
9558         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9559         code from these functions.  Remove corresponding ifdefs.  Use
9560         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9561         Remove gotos and target of gotos.
9562         (infpy_search_memory): Likewise.
9563
9564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9565
9566         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9567         (hppa_gdbarch_init): Don't register deleted functions with
9568         gdbarch.
9569
9570 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9571
9572         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9573         (h8300_unwind_sp): Delete.
9574         (h8300_dummy_id): Delete.
9575         (h8300_gdbarch_init): Don't register deleted functions with
9576         gdbarch.
9577
9578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9579
9580         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9581         (ft32_unwind_pc): Delete.
9582         (ft32_unwind_sp): Delete.
9583         (ft32_gdbarch_init): Don't register deleted functions with
9584         gdbarch.
9585
9586 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9587
9588         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9589         (frv_unwind_pc): Delete.
9590         (frv_unwind_sp): Delete.
9591         (frv_gdbarch_init): Don't register deleted functions with
9592         gdbarch.
9593
9594 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9595
9596         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9597         (riscv_unwind_pc): Delete.
9598         (riscv_unwind_sp): Delete.
9599         (riscv_gdbarch_init): Don't register deleted functions with
9600         gdbarch.
9601
9602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9603
9604         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9605         (csky_unwind_pc): Delete.
9606         (csky_unwind_sp): Delete.
9607         (csky_gdbarch_init): Don't register deleted functions with
9608         gdbarch.
9609
9610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9611
9612         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9613         (cris_unwind_pc): Delete.
9614         (cris_unwind_sp): Delete.
9615         (cris_gdbarch_init): Don't register deleted functions with
9616         gdbarch.
9617
9618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9619
9620         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9621         (bfin_unwind_pc): Delete.
9622         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9623
9624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9625
9626         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9627         (arm_unwind_pc): Delete.
9628         (arm_unwind_sp): Delete.
9629         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9630
9631 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9632
9633         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9634         (arc_unwind_pc): Delete.
9635         (arc_unwind_sp): Delete.
9636         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9637
9638 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9639
9640         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9641         (alpha_unwind_pc): Delete.
9642         (alpha_gdbarch_init): Don't register deleted functions with
9643         gdbarch.
9644
9645 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9646
9647         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9648         (aarch64_unwind_pc): Delete.
9649         (aarch64_unwind_sp): Delete.
9650         (aarch64_gdbarch_init): Don't register deleted functions with
9651         gdbarch.
9652
9653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9654
9655         * gdbtypes.c (type_align): Don't consider static members when
9656         computing structure alignment.
9657
9658 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9659
9660         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9661         return 0 for other types.
9662         * arch-utils.c (default_type_align): Always return 0.
9663         * gdbarch.h: Regenerate.
9664         * gdbarch.sh (type_align): Extend comment.
9665         * gdbtypes.c (type_align): Add additional comments, always call
9666         gdbarch_type_align before applying the default rules.
9667         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9668         generic code will then apply a suitable default.
9669         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9670         types, return 0 for other types.
9671
9672 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9673
9674         * NEWS: Create a new section for the next release branch.
9675         Rename the section of the current branch, now that it has
9676         been cut.
9677
9678 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9679
9680         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9681         * version.in: Bump version to 8.3.50.DATE-git.
9682
9683 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9684
9685         * aix-thread.c (ptid_cmp): Remove unused variable.
9686         (get_signaled_thread): Likewise.
9687         (store_regs_user_thread): Likewise.
9688         (store_regs_kernel_thread): Likewise.
9689         (fetch_regs_kernel_thread): Remove shadowed variable.
9690
9691 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9692
9693         * features/riscv/32bit-cpu.xml: Add register numbers.
9694         * features/riscv/32bit-fpu.c: Regenerate.
9695         * features/riscv/32bit-fpu.xml: Add register numbers.
9696         * features/riscv/64bit-cpu.xml: Add register numbers.
9697         * features/riscv/64bit-fpu.c: Regenerate.
9698         * features/riscv/64bit-fpu.xml: Add register numbers.
9699
9700 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9701
9702         * NEWS: Mention two argument form of gdb.Value constructor.
9703         * python/py-value.c (convert_buffer_and_type_to_value): New
9704         function.
9705         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9706         Add support for handling an optional second argument.  Call
9707         convert_buffer_and_type_to_value as appropriate.
9708         * python/python-internal.h (Py_buffer_deleter): New struct.
9709         (Py_buffer_up): New typedef.
9710
9711 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9712
9713         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9714         instead of releasing ownership.
9715
9716 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9717
9718         * dwarf2read.c (open_and_init_dwp_file): Call
9719         elf_numsections instead of bfd_count_sections to initialize
9720         dwp_file->num_sections.
9721
9722 2019-02-25  Tom Tromey  <tromey@adacore.com>
9723
9724         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9725
9726 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9727
9728         * gcore.in: Add '--readnever' option when invoking GDB.
9729
9730 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9731
9732         * MAINTAINERS: Update my email address.
9733
9734 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9735
9736         * build-id.c (build_id_to_debug_bfd_1): New function.
9737         (build_id_to_debug_bfd): Look for separate debug file in
9738         sysroot.
9739
9740 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9741
9742         * gdbarch.sh: Update the copyright year range that is placed into
9743         generated files.
9744
9745 2019-02-22  Keith Seitz  <keiths@redhat.com>
9746
9747         PR symtab/23853
9748         * linespec.c (create_sals_line_offset): Search for the default
9749         symtab's filename instead of its fullname.
9750
9751 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9752
9753         * NEWS: Update style defaults.
9754
9755 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9756
9757         * main.c (captured_main_1): Disable styling in batch mode.
9758
9759 2019-02-20  Tom Tromey  <tom@tromey.com>
9760
9761         * symtab.c (symtab_symbol_info): Fix typos.
9762
9763 2019-02-20  Tom Tromey  <tromey@adacore.com>
9764
9765         * findcmd.c (_initialize_mem_search): Use upper case for
9766         metasyntactic variables.
9767
9768 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9769
9770         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9771         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9772
9773 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9774
9775         * top.h (source_file_name): Change to std::string.
9776         * top.c (source_file_name): Likewise.
9777         (command_line_input): Adjust.
9778         * cli/cli-script.c (script_from_file): Adjust.
9779
9780 2019-02-19  Tom Tromey  <tromey@adacore.com>
9781
9782         * ravenscar-thread.c
9783         (ravenscar_thread_target::update_thread_list): Don't call
9784         ada_build_task_list.
9785         * ada-lang.h (ada_build_task_list): Don't declare.
9786         * ada-tasks.c (struct ada_tasks_inferior_data)
9787         <task_list_valid_p>: Now bool.
9788         (read_known_tasks, ada_task_list_changed)
9789         (ada_tasks_invalidate_inferior_data): Update.
9790         (read_known_tasks_array): Return bool.
9791         (read_known_tasks_list): Likewise.
9792         (read_known_tasks): Return void.
9793         (ada_build_task_list): Now static.
9794
9795 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9796
9797         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9798         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9799
9800 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9801
9802         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9803         variant for ada_tasks_pspace_data_handle and
9804         ada_tasks_inferior_data_handle.
9805         (ada_tasks_pspace_data_cleanup): New function.
9806         (ada_tasks_inferior_data_cleanup): New function.
9807
9808 2019-02-17  Tom Tromey  <tom@tromey.com>
9809
9810         * macrotab.h (macro_source_fullname): Return a std::string.
9811         * macrotab.c (macro_include, check_for_redefinition)
9812         (macro_undef, macro_lookup_definition, foreach_macro)
9813         (foreach_macro_in_scope): Update.
9814         (macro_source_fullname): Return a std::string.
9815         * macrocmd.c (show_pp_source_pos): Update.
9816
9817 2019-02-17  Tom Tromey  <tom@tromey.com>
9818
9819         * macrocmd.c (show_pp_source_pos): Style the file names.
9820
9821 2019-02-17  Tom Tromey  <tom@tromey.com>
9822
9823         PR tui/24197:
9824         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9825
9826 2019-02-17  Tom Tromey  <tom@tromey.com>
9827
9828         * ada-lang.c (user_select_syms): Use filtered printing.
9829         * utils.c (wrap_style): New global.
9830         (desired_style): Remove.
9831         (emit_style_escape): Add stream parameter.
9832         (set_output_style, reset_terminal_style, prompt_for_continue):
9833         Update.
9834         (flush_wrap_buffer): Only flush gdb_stdout.
9835         (wrap_here): Set wrap_style.
9836         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9837         treat escape sequences as a character.  Change when wrap buffer is
9838         flushed.
9839         (fputs_styled): Do not set the output style when the default is
9840         requested.
9841         * ui-style.h (struct ui_file_style) <is_default>: New method.
9842         * source.c (print_source_lines_base): Emit escape sequences in one
9843         piece.
9844
9845 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9846
9847         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9848         integers and enumeration types.
9849
9850 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9851
9852         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9853         instead of lookup_symbol_in_language
9854         (do_exact_match): New function.
9855         (ada_get_symbol_name_matcher): Return do_exact_match when
9856         doing a verbatim match.
9857
9858 2019-02-15  Tom Tromey  <tromey@adacore.com>
9859
9860         * ravenscar-thread.c (ravenscar_thread_target::resume)
9861         (ravenscar_thread_target::wait): Special case wildcard requests.
9862
9863 2019-02-15  Tom Tromey  <tromey@adacore.com>
9864
9865         * ravenscar-thread.c (base_ptid): Remove.
9866         (struct ravenscar_thread_target) <close>: New method.
9867         <m_base_ptid>: New member.
9868         <update_inferior_ptid, active_task, task_is_currently_active,
9869         runtime_initialized>: Declare methods.
9870         <ravenscar_thread_target>: Add constructor.
9871         (ravenscar_thread_target::task_is_currently_active)
9872         (ravenscar_thread_target::update_inferior_ptid)
9873         (ravenscar_runtime_initialized): Rename.  Now methods.
9874         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9875         (ravenscar_thread_target::update_thread_list): Update.
9876         (ravenscar_thread_target::active_task): Now method.
9877         (ravenscar_thread_target::store_registers)
9878         (ravenscar_thread_target::prepare_to_store)
9879         (ravenscar_thread_target::prepare_to_store)
9880         (ravenscar_thread_target::mourn_inferior): Update.
9881         (ravenscar_inferior_created): Use "new" to create target.
9882         (ravenscar_thread_target::get_ada_task_ptid): Update.
9883         (_initialize_ravenscar): Don't initialize base_ptid.
9884         (ravenscar_ops): Remove global.
9885
9886 2019-02-15  Tom Tromey  <tromey@adacore.com>
9887
9888         * target.h (push_target): Declare new overload.
9889         * target.c (push_target): New overload, taking an rvalue reference.
9890         * remote.c (remote_target::open_1): Use push_target overload.
9891         * corelow.c (core_target_open): Use push_target overload.
9892
9893 2019-02-15  Tom Tromey  <tromey@adacore.com>
9894
9895         * ravenscar-thread.c (is_ravenscar_task)
9896         (ravenscar_task_is_currently_active): Return bool.
9897         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9898         (_initialize_ravenscar): Remove "(void)".
9899         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9900         Return bool.
9901
9902 2019-02-15  Tom Tromey  <tromey@adacore.com>
9903
9904         * ravenscar-thread.c (ravenscar_runtime_initializer)
9905         (has_ravenscar_runtime, get_running_thread_id)
9906         (ravenscar_thread_target::resume): Fix indentation.
9907
9908 2019-02-15  Tom Tromey  <tromey@adacore.com>
9909
9910         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9911         from ravenscar_arch_ops.
9912         (sparc_ravenscar_ops::fetch_registers)
9913         (sparc_ravenscar_ops::store_registers): Now methods.
9914         (sparc_ravenscar_prepare_to_store): Remove.
9915         (sparc_ravenscar_ops): Redefine.
9916         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9917         methods and destructor.  Remove members.
9918         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9919         (ravenscar_thread_target::store_registers)
9920         (ravenscar_thread_target::prepare_to_store): Update.
9921         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9922         Remove.
9923         (struct ppc_ravenscar_powerpc_ops): Derive from
9924         ravenscar_arch_ops.
9925         (ppc_ravenscar_powerpc_ops::fetch_registers)
9926         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9927         (ppc_ravenscar_powerpc_ops): Redefine.
9928         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9929         (ppc_ravenscar_e500_ops::fetch_registers)
9930         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9931         (ppc_ravenscar_e500_ops): Redefine.
9932         * aarch64-ravenscar-thread.c
9933         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9934         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9935         (aarch64_ravenscar_fetch_registers)
9936         (aarch64_ravenscar_store_registers): Now methods.
9937         (aarch64_ravenscar_ops): Redefine.
9938
9939 2019-02-15  Tom Tromey  <tromey@adacore.com>
9940
9941         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9942         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9943         (ravenscar_thread_target::stopped_by_watchpoint)
9944         (ravenscar_thread_target::stopped_data_address)
9945         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9946
9947 2019-02-15  Tom Tromey  <tromey@adacore.com>
9948
9949         * ravenscar-thread.c: Fix some typos.
9950
9951 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9952             Tom Tromey  <tromey@adacore.com>
9953
9954         * ada-lang.c (ada_exception_sal): Change addr_string to a
9955         std::string.
9956         (create_ada_exception_catchpoint): Update.
9957
9958 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9959             Tom Tromey  <tromey@adacore.com>
9960
9961         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9962         (bp_location_ops): Remove.
9963         (base_breakpoint_allocate_location): Update.
9964         (free_bp_location): Update.
9965         * ada-lang.c (class ada_catchpoint_location)
9966         <ada_catchpoint_location>: Remove ops parameter.
9967         (ada_catchpoint_location_dtor): Remove.
9968         (ada_catchpoint_location_ops): Remove.
9969         (allocate_location_exception): Update.
9970         * breakpoint.h (struct bp_location_ops): Remove.
9971         (class bp_location) <bp_location>: Remove bp_location_ops
9972         parameter.
9973         <~bp_location>: Add destructor.
9974         <ops>: Remove.
9975
9976 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9977             Pedro Alves  <palves@redhat.com>
9978
9979         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9980         'PATH_MAX'.
9981
9982 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9983             Samuel Thibault  <samuel.thibault@gnu.org>
9984             Thomas Schwinge  <thomas@codesourcery.com>
9985
9986         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9987         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9988
9989 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9990
9991         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9992         (check_empty): Use "const char *".
9993
9994         * gnu-nat.c (gnu_nat_target::detach): Instead of
9995         'detach_inferior (pid)' call
9996         'detach_inferior (find_inferior_pid (pid))'.
9997
9998         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9999         'nat/fork-inferior.o'.
10000         * gnu-nat.c: #include "nat/fork-inferior.h".
10001
10002         * gnu-nat.c (gnu_nat_target::detach): Instead of
10003         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10004         * gnu-nat.h: #include "inf-child.h".
10005         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10006         'i386_gnu_nat_target::fetch_registers'.
10007         (gnu_store_registers): Rename/move to
10008         'i386_gnu_nat_target::store_registers'.
10009
10010         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10011         * gnu-nat.h (mach_thread_info): New function.
10012         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10013
10014         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10015
10016 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10017
10018         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10019
10020 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10021
10022         * windows-nat.c (windows_add_thread): Add new parameter
10023         "main_thread_p" with default value set to false.  Update
10024         function documentation as well as all callers.
10025         (windows_delete_thread): Likewise.
10026         (fake_create_process): Update call to windows_add_thread.
10027         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10028         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10029         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10030         call to windows_delete_thread.
10031
10032 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10033
10034         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10035
10036 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10037
10038         * symfile.c (find_separate_debug_file): Use canonical path of
10039         sysroot with child_path instead of gdb_sysroot if it is valid.
10040
10041 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10042
10043         * symfile.c (find_separate_debug_file): Use child_path to
10044         determine if an object file is under a sysroot.
10045
10046 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10047
10048         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10049         unittests/child-path-selftests.c.
10050         * common/pathstuff.c (child_path): New function.
10051         * common/pathstuff.h (child_path): New prototype.
10052         * unittests/child-path-selftests.c: New file.
10053
10054 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10055
10056         * symfile.c (find_separate_debug_file): Look for separate debug
10057         files in debug directories under the sysroot.
10058
10059 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10060
10061         * symtab.h (struct minimal_symbol data_p): New const method.
10062         (struct minimal_symbol text_p): Likewise.
10063         * symtab.c (output_source_filename): Use file name style
10064         to print file name.
10065         (print_symbol_info): Likewise.
10066         (print_msymbol_info): Use address style to print addresses.
10067         Use function name style to print executable text symbols.
10068         (expand_symtab_containing_pc): Use data_p.
10069         (find_pc_sect_compunit_symtab): Likewise.
10070
10071 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10072
10073         * breakpoint.c (describe_other_breakpoints): Use address style
10074         to print addresses.
10075         (say_where): Likewise.
10076
10077 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10078
10079         * ada-typeprint.c (print_func_type): Print function name
10080         style to print function name.
10081         * c-typeprint.c (c_print_type_1): Likewise.
10082
10083 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10084
10085         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10086         for execve.
10087
10088 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10089
10090         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10091         type_stack.
10092
10093 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10094
10095         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10096         TYPE_CODE_REF types.
10097
10098 2019-02-08  Jim Wilson  <jimw@sifive.com>
10099
10100         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10101         (riscv_linux_fregset): New.
10102         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10103
10104 2019-02-07  Tom Tromey  <tom@tromey.com>
10105
10106         * thread.c (thread_cancel_execution_command): Update.
10107         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10108         methods.
10109         (struct thread_fsm_ops): Remove.
10110         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10111         (thread_fsm_should_stop, thread_fsm_return_value)
10112         (thread_fsm_set_finished, thread_fsm_finished_p)
10113         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10114         Don't declare.
10115         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10116         * infrun.c (clear_proceed_status_thread)
10117         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10118         (print_stop_event): Update.
10119         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10120         Add constructor.
10121         (step_command_fsm_ops): Remove.
10122         (new_step_command_fsm): Remove.
10123         (step_1): Update.
10124         (step_command_fsm::should_stop): Rename from
10125         step_command_fsm_should_stop.
10126         (step_command_fsm::clean_up): Rename from
10127         step_command_fsm_clean_up.
10128         (step_command_fsm::do_async_reply_reason): Rename from
10129         step_command_fsm_async_reply_reason.
10130         (struct until_next_fsm): Inherit from thread_fsm.  Add
10131         constructor.
10132         (until_next_fsm_ops): Remove.
10133         (new_until_next_fsm): Remove.
10134         (until_next_fsm::should_stop): Rename from
10135         until_next_fsm_should_stop.
10136         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10137         (until_next_fsm::do_async_reply_reason): Rename from
10138         until_next_fsm_async_reply_reason.
10139         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10140         constructor.  Change type of breakpoint.
10141         (finish_command_fsm_ops): Remove.
10142         (new_finish_command_fsm): Remove.
10143         (finish_command_fsm::should_stop): Rename from
10144         finish_command_fsm_should_stop.
10145         (finish_command_fsm::clean_up): Rename from
10146         finish_command_fsm_clean_up.
10147         (finish_command_fsm::return_value): Rename from
10148         finish_command_fsm_return_value.
10149         (finish_command_fsm::do_async_reply_reason): Rename from
10150         finish_command_fsm_async_reply_reason.
10151         (finish_command): Update.
10152         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10153         Add constructor.
10154         (call_thread_fsm_ops): Remove.
10155         (call_thread_fsm::call_thread_fsm): Rename from
10156         new_call_thread_fsm.
10157         (call_thread_fsm::should_stop): Rename from
10158         call_thread_fsm_should_stop.
10159         (call_thread_fsm::should_notify_stop): Rename from
10160         call_thread_fsm_should_notify_stop.
10161         (run_inferior_call, call_function_by_hand_dummy): Update.
10162         * cli/cli-interp.c (should_print_stop_to_console): Update.
10163         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10164         Add constructor.  Change type of location_breakpoint,
10165         caller_breakpoint.
10166         (until_break_fsm_ops): Remove.
10167         (new_until_break_fsm): Remove.
10168         (until_break_fsm::should_stop): Rename from
10169         until_break_fsm_should_stop.
10170         (until_break_fsm::clean_up): Rename from
10171         until_break_fsm_clean_up.
10172         (until_break_fsm::do_async_reply_reason): Rename from
10173         until_break_fsm_async_reply_reason.
10174         (until_break_command): Update.
10175         * thread-fsm.c: Remove.
10176         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10177
10178 2019-02-07  Tom Tromey  <tom@tromey.com>
10179
10180         * yy-remap.h: Add include guard.
10181         * xtensa-tdep.h: Add include guard.
10182         * xcoffread.h: Rename include guard.
10183         * varobj-iter.h: Add include guard.
10184         * tui/tui.h: Rename include guard.
10185         * tui/tui-winsource.h: Rename include guard.
10186         * tui/tui-wingeneral.h: Rename include guard.
10187         * tui/tui-windata.h: Rename include guard.
10188         * tui/tui-win.h: Rename include guard.
10189         * tui/tui-stack.h: Rename include guard.
10190         * tui/tui-source.h: Rename include guard.
10191         * tui/tui-regs.h: Rename include guard.
10192         * tui/tui-out.h: Rename include guard.
10193         * tui/tui-layout.h: Rename include guard.
10194         * tui/tui-io.h: Rename include guard.
10195         * tui/tui-hooks.h: Rename include guard.
10196         * tui/tui-file.h: Rename include guard.
10197         * tui/tui-disasm.h: Rename include guard.
10198         * tui/tui-data.h: Rename include guard.
10199         * tui/tui-command.h: Rename include guard.
10200         * tic6x-tdep.h: Add include guard.
10201         * target/waitstatus.h: Rename include guard.
10202         * target/wait.h: Rename include guard.
10203         * target/target.h: Rename include guard.
10204         * target/resume.h: Rename include guard.
10205         * target-float.h: Rename include guard.
10206         * stabsread.h: Add include guard.
10207         * rs6000-tdep.h: Add include guard.
10208         * riscv-fbsd-tdep.h: Add include guard.
10209         * regformats/regdef.h: Rename include guard.
10210         * record.h: Rename include guard.
10211         * python/python.h: Rename include guard.
10212         * python/python-internal.h: Rename include guard.
10213         * python/py-stopevent.h: Rename include guard.
10214         * python/py-ref.h: Rename include guard.
10215         * python/py-record.h: Rename include guard.
10216         * python/py-record-full.h: Rename include guard.
10217         * python/py-record-btrace.h: Rename include guard.
10218         * python/py-instruction.h: Rename include guard.
10219         * python/py-events.h: Rename include guard.
10220         * python/py-event.h: Rename include guard.
10221         * procfs.h: Add include guard.
10222         * proc-utils.h: Add include guard.
10223         * p-lang.h: Add include guard.
10224         * or1k-tdep.h: Rename include guard.
10225         * observable.h: Rename include guard.
10226         * nto-tdep.h: Rename include guard.
10227         * nat/x86-linux.h: Rename include guard.
10228         * nat/x86-linux-dregs.h: Rename include guard.
10229         * nat/x86-gcc-cpuid.h: Add include guard.
10230         * nat/x86-dregs.h: Rename include guard.
10231         * nat/x86-cpuid.h: Rename include guard.
10232         * nat/ppc-linux.h: Rename include guard.
10233         * nat/mips-linux-watch.h: Rename include guard.
10234         * nat/linux-waitpid.h: Rename include guard.
10235         * nat/linux-ptrace.h: Rename include guard.
10236         * nat/linux-procfs.h: Rename include guard.
10237         * nat/linux-osdata.h: Rename include guard.
10238         * nat/linux-nat.h: Rename include guard.
10239         * nat/linux-namespaces.h: Rename include guard.
10240         * nat/linux-btrace.h: Rename include guard.
10241         * nat/glibc_thread_db.h: Rename include guard.
10242         * nat/gdb_thread_db.h: Rename include guard.
10243         * nat/gdb_ptrace.h: Rename include guard.
10244         * nat/fork-inferior.h: Rename include guard.
10245         * nat/amd64-linux-siginfo.h: Rename include guard.
10246         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10247         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10248         * nat/aarch64-linux.h: Rename include guard.
10249         * nat/aarch64-linux-hw-point.h: Rename include guard.
10250         * mn10300-tdep.h: Add include guard.
10251         * mips-linux-tdep.h: Add include guard.
10252         * mi/mi-parse.h: Rename include guard.
10253         * mi/mi-out.h: Rename include guard.
10254         * mi/mi-main.h: Rename include guard.
10255         * mi/mi-interp.h: Rename include guard.
10256         * mi/mi-getopt.h: Rename include guard.
10257         * mi/mi-console.h: Rename include guard.
10258         * mi/mi-common.h: Rename include guard.
10259         * mi/mi-cmds.h: Rename include guard.
10260         * mi/mi-cmd-break.h: Rename include guard.
10261         * m2-lang.h: Add include guard.
10262         * location.h: Rename include guard.
10263         * linux-record.h: Rename include guard.
10264         * linux-nat.h: Add include guard.
10265         * linux-fork.h: Add include guard.
10266         * i386-darwin-tdep.h: Rename include guard.
10267         * hppa-linux-offsets.h: Add include guard.
10268         * guile/guile.h: Rename include guard.
10269         * guile/guile-internal.h: Rename include guard.
10270         * gnu-nat.h: Rename include guard.
10271         * gdb-stabs.h: Rename include guard.
10272         * frv-tdep.h: Add include guard.
10273         * f-lang.h: Add include guard.
10274         * event-loop.h: Add include guard.
10275         * darwin-nat.h: Rename include guard.
10276         * cp-abi.h: Rename include guard.
10277         * config/sparc/nm-sol2.h: Rename include guard.
10278         * config/nm-nto.h: Rename include guard.
10279         * config/nm-linux.h: Add include guard.
10280         * config/i386/nm-i386gnu.h: Rename include guard.
10281         * config/djgpp/nl_types.h: Rename include guard.
10282         * config/djgpp/langinfo.h: Rename include guard.
10283         * compile/gcc-cp-plugin.h: Add include guard.
10284         * compile/gcc-c-plugin.h: Add include guard.
10285         * compile/compile.h: Rename include guard.
10286         * compile/compile-object-run.h: Rename include guard.
10287         * compile/compile-object-load.h: Rename include guard.
10288         * compile/compile-internal.h: Rename include guard.
10289         * compile/compile-cplus.h: Rename include guard.
10290         * compile/compile-c.h: Rename include guard.
10291         * common/xml-utils.h: Rename include guard.
10292         * common/x86-xstate.h: Rename include guard.
10293         * common/version.h: Rename include guard.
10294         * common/vec.h: Rename include guard.
10295         * common/tdesc.h: Rename include guard.
10296         * common/selftest.h: Rename include guard.
10297         * common/scoped_restore.h: Rename include guard.
10298         * common/scoped_mmap.h: Rename include guard.
10299         * common/scoped_fd.h: Rename include guard.
10300         * common/safe-iterator.h: Rename include guard.
10301         * common/run-time-clock.h: Rename include guard.
10302         * common/refcounted-object.h: Rename include guard.
10303         * common/queue.h: Rename include guard.
10304         * common/ptid.h: Rename include guard.
10305         * common/print-utils.h: Rename include guard.
10306         * common/preprocessor.h: Rename include guard.
10307         * common/pathstuff.h: Rename include guard.
10308         * common/observable.h: Rename include guard.
10309         * common/netstuff.h: Rename include guard.
10310         * common/job-control.h: Rename include guard.
10311         * common/host-defs.h: Rename include guard.
10312         * common/gdb_wait.h: Rename include guard.
10313         * common/gdb_vecs.h: Rename include guard.
10314         * common/gdb_unlinker.h: Rename include guard.
10315         * common/gdb_unique_ptr.h: Rename include guard.
10316         * common/gdb_tilde_expand.h: Rename include guard.
10317         * common/gdb_sys_time.h: Rename include guard.
10318         * common/gdb_string_view.h: Rename include guard.
10319         * common/gdb_splay_tree.h: Rename include guard.
10320         * common/gdb_setjmp.h: Rename include guard.
10321         * common/gdb_ref_ptr.h: Rename include guard.
10322         * common/gdb_optional.h: Rename include guard.
10323         * common/gdb_locale.h: Rename include guard.
10324         * common/gdb_assert.h: Rename include guard.
10325         * common/filtered-iterator.h: Rename include guard.
10326         * common/filestuff.h: Rename include guard.
10327         * common/fileio.h: Rename include guard.
10328         * common/environ.h: Rename include guard.
10329         * common/common-utils.h: Rename include guard.
10330         * common/common-types.h: Rename include guard.
10331         * common/common-regcache.h: Rename include guard.
10332         * common/common-inferior.h: Rename include guard.
10333         * common/common-gdbthread.h: Rename include guard.
10334         * common/common-exceptions.h: Rename include guard.
10335         * common/common-defs.h: Rename include guard.
10336         * common/common-debug.h: Rename include guard.
10337         * common/cleanups.h: Rename include guard.
10338         * common/buffer.h: Rename include guard.
10339         * common/btrace-common.h: Rename include guard.
10340         * common/break-common.h: Rename include guard.
10341         * cli/cli-utils.h: Rename include guard.
10342         * cli/cli-style.h: Rename include guard.
10343         * cli/cli-setshow.h: Rename include guard.
10344         * cli/cli-script.h: Rename include guard.
10345         * cli/cli-interp.h: Rename include guard.
10346         * cli/cli-decode.h: Rename include guard.
10347         * cli/cli-cmds.h: Rename include guard.
10348         * charset-list.h: Add include guard.
10349         * buildsym-legacy.h: Rename include guard.
10350         * bfin-tdep.h: Add include guard.
10351         * ax.h: Rename include guard.
10352         * arm-linux-tdep.h: Add include guard.
10353         * arm-fbsd-tdep.h: Add include guard.
10354         * arch/xtensa.h: Rename include guard.
10355         * arch/tic6x.h: Add include guard.
10356         * arch/i386.h: Add include guard.
10357         * arch/arm.h: Rename include guard.
10358         * arch/arm-linux.h: Rename include guard.
10359         * arch/arm-get-next-pcs.h: Rename include guard.
10360         * arch/amd64.h: Add include guard.
10361         * arch/aarch64-insn.h: Rename include guard.
10362         * arch-utils.h: Rename include guard.
10363         * annotate.h: Add include guard.
10364         * amd64-darwin-tdep.h: Rename include guard.
10365         * aarch64-linux-tdep.h: Add include guard.
10366         * aarch64-fbsd-tdep.h: Add include guard.
10367         * aarch32-linux-nat.h: Add include guard.
10368
10369 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10370
10371         * macrotab.c (macro_define_internal): New function that
10372         factorizes macro_define_object_internal and macro_define_function
10373         code.
10374         (macro_define_object_internal): Use macro_define_internal.
10375         (macro_define_function): Likewise.
10376
10377 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10378
10379         * macrocmd.c (extract_identifier): Return
10380         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10381         callers.
10382
10383 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10384
10385         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10386
10387 2019-02-05  Tom Tromey  <tom@tromey.com>
10388
10389         * target.c (target_stack::unpush): Move assertion earlier.
10390
10391 2019-01-30  Tom Tromey  <tom@tromey.com>
10392
10393         PR python/23615:
10394         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10395         (gdbpy_parse_and_eval): Likewise.
10396         * python/python-internal.h (gdbpy_allow_threads): New class.
10397
10398 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10399
10400         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10401         (aarch64_fbsd_fpregmap): Move earlier.
10402         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10403         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10404         instead of individual calls to trad_frame_set_reg_addr.
10405         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10406         earlier.
10407         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10408         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10409         instead of individual calls to trad_frame_set_reg_addr.
10410
10411 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10412
10413         * CONTRIBUTE: Replace contribution list with wiki link.
10414
10415 2019-01-25  Tom Tromey  <tom@tromey.com>
10416
10417         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10418
10419 2019-01-25  Tom Tromey  <tom@tromey.com>
10420
10421         * xtensa-linux-nat.c: Fix common/ includes.
10422         * xml-support.h: Fix common/ includes.
10423         * xml-support.c: Fix common/ includes.
10424         * x86-linux-nat.c: Fix common/ includes.
10425         * windows-nat.c: Fix common/ includes.
10426         * varobj.h: Fix common/ includes.
10427         * varobj.c: Fix common/ includes.
10428         * value.c: Fix common/ includes.
10429         * valops.c: Fix common/ includes.
10430         * utils.c: Fix common/ includes.
10431         * unittests/xml-utils-selftests.c: Fix common/ includes.
10432         * unittests/utils-selftests.c: Fix common/ includes.
10433         * unittests/unpack-selftests.c: Fix common/ includes.
10434         * unittests/tracepoint-selftests.c: Fix common/ includes.
10435         * unittests/style-selftests.c: Fix common/ includes.
10436         * unittests/string_view-selftests.c: Fix common/ includes.
10437         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10438         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10439         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10440         * unittests/rsp-low-selftests.c: Fix common/ includes.
10441         * unittests/parse-connection-spec-selftests.c: Fix common/
10442         includes.
10443         * unittests/optional-selftests.c: Fix common/ includes.
10444         * unittests/offset-type-selftests.c: Fix common/ includes.
10445         * unittests/observable-selftests.c: Fix common/ includes.
10446         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10447         * unittests/memrange-selftests.c: Fix common/ includes.
10448         * unittests/memory-map-selftests.c: Fix common/ includes.
10449         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10450         * unittests/function-view-selftests.c: Fix common/ includes.
10451         * unittests/environ-selftests.c: Fix common/ includes.
10452         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10453         * unittests/common-utils-selftests.c: Fix common/ includes.
10454         * unittests/cli-utils-selftests.c: Fix common/ includes.
10455         * unittests/array-view-selftests.c: Fix common/ includes.
10456         * ui-file.c: Fix common/ includes.
10457         * tui/tui-io.c: Fix common/ includes.
10458         * tracepoint.h: Fix common/ includes.
10459         * tracepoint.c: Fix common/ includes.
10460         * tracefile-tfile.c: Fix common/ includes.
10461         * top.h: Fix common/ includes.
10462         * top.c: Fix common/ includes.
10463         * thread.c: Fix common/ includes.
10464         * target/waitstatus.h: Fix common/ includes.
10465         * target/waitstatus.c: Fix common/ includes.
10466         * target.h: Fix common/ includes.
10467         * target.c: Fix common/ includes.
10468         * target-memory.c: Fix common/ includes.
10469         * target-descriptions.c: Fix common/ includes.
10470         * symtab.h: Fix common/ includes.
10471         * symfile.c: Fix common/ includes.
10472         * stap-probe.c: Fix common/ includes.
10473         * spu-linux-nat.c: Fix common/ includes.
10474         * sparc-nat.c: Fix common/ includes.
10475         * source.c: Fix common/ includes.
10476         * solib.c: Fix common/ includes.
10477         * solib-target.c: Fix common/ includes.
10478         * ser-unix.c: Fix common/ includes.
10479         * ser-tcp.c: Fix common/ includes.
10480         * ser-pipe.c: Fix common/ includes.
10481         * ser-base.c: Fix common/ includes.
10482         * selftest-arch.c: Fix common/ includes.
10483         * s12z-tdep.c: Fix common/ includes.
10484         * rust-exp.y: Fix common/ includes.
10485         * rs6000-aix-tdep.c: Fix common/ includes.
10486         * riscv-tdep.c: Fix common/ includes.
10487         * remote.c: Fix common/ includes.
10488         * remote-notif.h: Fix common/ includes.
10489         * remote-fileio.h: Fix common/ includes.
10490         * remote-fileio.c: Fix common/ includes.
10491         * regcache.h: Fix common/ includes.
10492         * regcache.c: Fix common/ includes.
10493         * record-btrace.c: Fix common/ includes.
10494         * python/python.c: Fix common/ includes.
10495         * python/py-type.c: Fix common/ includes.
10496         * python/py-inferior.c: Fix common/ includes.
10497         * progspace.h: Fix common/ includes.
10498         * producer.c: Fix common/ includes.
10499         * procfs.c: Fix common/ includes.
10500         * proc-api.c: Fix common/ includes.
10501         * printcmd.c: Fix common/ includes.
10502         * ppc-linux-nat.c: Fix common/ includes.
10503         * parser-defs.h: Fix common/ includes.
10504         * osdata.c: Fix common/ includes.
10505         * obsd-nat.c: Fix common/ includes.
10506         * nat/x86-linux.c: Fix common/ includes.
10507         * nat/x86-linux-dregs.c: Fix common/ includes.
10508         * nat/x86-dregs.h: Fix common/ includes.
10509         * nat/x86-dregs.c: Fix common/ includes.
10510         * nat/ppc-linux.c: Fix common/ includes.
10511         * nat/mips-linux-watch.h: Fix common/ includes.
10512         * nat/mips-linux-watch.c: Fix common/ includes.
10513         * nat/linux-waitpid.c: Fix common/ includes.
10514         * nat/linux-ptrace.h: Fix common/ includes.
10515         * nat/linux-ptrace.c: Fix common/ includes.
10516         * nat/linux-procfs.c: Fix common/ includes.
10517         * nat/linux-personality.c: Fix common/ includes.
10518         * nat/linux-osdata.c: Fix common/ includes.
10519         * nat/linux-namespaces.c: Fix common/ includes.
10520         * nat/linux-btrace.h: Fix common/ includes.
10521         * nat/linux-btrace.c: Fix common/ includes.
10522         * nat/fork-inferior.c: Fix common/ includes.
10523         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10524         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10525         * nat/aarch64-linux.c: Fix common/ includes.
10526         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10527         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10528         * namespace.h: Fix common/ includes.
10529         * mips-linux-tdep.c: Fix common/ includes.
10530         * minsyms.c: Fix common/ includes.
10531         * mi/mi-parse.h: Fix common/ includes.
10532         * mi/mi-main.c: Fix common/ includes.
10533         * mi/mi-cmd-env.c: Fix common/ includes.
10534         * memrange.h: Fix common/ includes.
10535         * memattr.c: Fix common/ includes.
10536         * maint.h: Fix common/ includes.
10537         * maint.c: Fix common/ includes.
10538         * main.c: Fix common/ includes.
10539         * machoread.c: Fix common/ includes.
10540         * location.c: Fix common/ includes.
10541         * linux-thread-db.c: Fix common/ includes.
10542         * linux-nat.c: Fix common/ includes.
10543         * linux-fork.c: Fix common/ includes.
10544         * inline-frame.c: Fix common/ includes.
10545         * infrun.c: Fix common/ includes.
10546         * inflow.c: Fix common/ includes.
10547         * inferior.h: Fix common/ includes.
10548         * inferior.c: Fix common/ includes.
10549         * infcmd.c: Fix common/ includes.
10550         * inf-ptrace.c: Fix common/ includes.
10551         * inf-child.c: Fix common/ includes.
10552         * ia64-linux-nat.c: Fix common/ includes.
10553         * i387-tdep.c: Fix common/ includes.
10554         * i386-tdep.c: Fix common/ includes.
10555         * i386-linux-tdep.c: Fix common/ includes.
10556         * i386-linux-nat.c: Fix common/ includes.
10557         * i386-go32-tdep.c: Fix common/ includes.
10558         * i386-fbsd-tdep.c: Fix common/ includes.
10559         * i386-fbsd-nat.c: Fix common/ includes.
10560         * guile/scm-type.c: Fix common/ includes.
10561         * guile/guile.c: Fix common/ includes.
10562         * go32-nat.c: Fix common/ includes.
10563         * gnu-nat.c: Fix common/ includes.
10564         * gdbthread.h: Fix common/ includes.
10565         * gdbarch-selftests.c: Fix common/ includes.
10566         * gdb_usleep.c: Fix common/ includes.
10567         * gdb_select.h: Fix common/ includes.
10568         * gdb_bfd.c: Fix common/ includes.
10569         * gcore.c: Fix common/ includes.
10570         * fork-child.c: Fix common/ includes.
10571         * findvar.c: Fix common/ includes.
10572         * fbsd-nat.c: Fix common/ includes.
10573         * event-top.c: Fix common/ includes.
10574         * event-loop.c: Fix common/ includes.
10575         * dwarf2read.c: Fix common/ includes.
10576         * dwarf2loc.c: Fix common/ includes.
10577         * dwarf2-frame.c: Fix common/ includes.
10578         * dwarf-index-cache.c: Fix common/ includes.
10579         * dtrace-probe.c: Fix common/ includes.
10580         * disasm-selftests.c: Fix common/ includes.
10581         * defs.h: Fix common/ includes.
10582         * csky-tdep.c: Fix common/ includes.
10583         * cp-valprint.c: Fix common/ includes.
10584         * cp-support.h: Fix common/ includes.
10585         * cp-support.c: Fix common/ includes.
10586         * corelow.c: Fix common/ includes.
10587         * completer.h: Fix common/ includes.
10588         * completer.c: Fix common/ includes.
10589         * compile/compile.c: Fix common/ includes.
10590         * compile/compile-loc2c.c: Fix common/ includes.
10591         * compile/compile-cplus-types.c: Fix common/ includes.
10592         * compile/compile-cplus-symbols.c: Fix common/ includes.
10593         * command.h: Fix common/ includes.
10594         * cli/cli-dump.c: Fix common/ includes.
10595         * cli/cli-cmds.c: Fix common/ includes.
10596         * charset.c: Fix common/ includes.
10597         * build-id.c: Fix common/ includes.
10598         * btrace.h: Fix common/ includes.
10599         * btrace.c: Fix common/ includes.
10600         * breakpoint.h: Fix common/ includes.
10601         * breakpoint.c: Fix common/ includes.
10602         * ax.h:
10603         (enum agent_op): Fix common/ includes.
10604         * ax-general.c (struct aop_map): Fix common/ includes.
10605         * ax-gdb.c: Fix common/ includes.
10606         * auxv.c: Fix common/ includes.
10607         * auto-load.c: Fix common/ includes.
10608         * arm-tdep.c: Fix common/ includes.
10609         * arch/riscv.c: Fix common/ includes.
10610         * arch/ppc-linux-common.c: Fix common/ includes.
10611         * arch/i386.c: Fix common/ includes.
10612         * arch/arm.c: Fix common/ includes.
10613         * arch/arm-linux.c: Fix common/ includes.
10614         * arch/arm-get-next-pcs.c: Fix common/ includes.
10615         * arch/amd64.c: Fix common/ includes.
10616         * arch/aarch64.c: Fix common/ includes.
10617         * arch/aarch64-insn.c: Fix common/ includes.
10618         * arch-utils.c: Fix common/ includes.
10619         * amd64-windows-tdep.c: Fix common/ includes.
10620         * amd64-tdep.c: Fix common/ includes.
10621         * amd64-sol2-tdep.c: Fix common/ includes.
10622         * amd64-obsd-tdep.c: Fix common/ includes.
10623         * amd64-nbsd-tdep.c: Fix common/ includes.
10624         * amd64-linux-tdep.c: Fix common/ includes.
10625         * amd64-linux-nat.c: Fix common/ includes.
10626         * amd64-fbsd-tdep.c: Fix common/ includes.
10627         * amd64-fbsd-nat.c: Fix common/ includes.
10628         * amd64-dicos-tdep.c: Fix common/ includes.
10629         * amd64-darwin-tdep.c: Fix common/ includes.
10630         * agent.c: Fix common/ includes.
10631         * ada-lang.h: Fix common/ includes.
10632         * ada-lang.c: Fix common/ includes.
10633         * aarch64-tdep.c: Fix common/ includes.
10634
10635 2019-01-25  Tom Tromey  <tom@tromey.com>
10636
10637         * common/create-version.sh: Use common/version.h.
10638
10639 2019-01-24  Pedro Alves  <palves@redhat.com>
10640
10641         * infrun.c (signal_stop, signal_print, signal_program)
10642         (signal_catch, signal_pass): Now arrays instead of pointers.
10643         (update_signals_program_target, do_target_resume)
10644         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10645         * linux-nat.c (linux_nat_target::pass_signals)
10646         (linux_nat_target::create_inferior, linux_nat_target::attach):
10647         Adjust.
10648         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10649         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10650         * procfs.c (procfs_target::pass_signals): Adjust.
10651         * record-full.c (record_full_target::resume): Adjust.
10652         * remote.c (remote_target::pass_signals)
10653         (remote_target::program_signals): Adjust.
10654         * target-debug.h (target_debug_print_signals): Now takes a
10655         gdb::array_view as parameter.  Adjust.
10656         * target.h (target_ops) <pass_signals, program_signals>: Replace
10657         pointer and length parameters with gdb::array_view.
10658         (target_pass_signals, target_program_signals): Likewise.
10659         * target-delegates.c: Regenerate.
10660
10661 2019-01-24  Pedro Alves  <palves@redhat.com>
10662
10663         * common/forward-scope-exit.h
10664         (forward_scope_exit::forward_scope_exit): Pass arguments to
10665         m_bind_function directly, instead of creating a std::bind and
10666         copying that.
10667
10668 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10669
10670         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10671         for static members.
10672         (pass_in_v_vfp_candidate): Likewise.
10673
10674 2019-01-23  Tom Tromey  <tom@tromey.com>
10675             Pedro Alves  <palves@redhat.com>
10676
10677         * regcache.c (class regcache_invalidator): Remove.
10678         (regcache::raw_write): Use make_scope_exit.
10679
10680 2019-01-23  Tom Tromey  <tom@tromey.com>
10681
10682         * ui-out.h (class ui_out_emit_type): Update comment.
10683
10684 2019-01-23  Tom Tromey  <tom@tromey.com>
10685
10686         * infrun.c (fetch_inferior_event): Update comment.
10687
10688 2019-01-23  Tom Tromey  <tom@tromey.com>
10689             Pedro Alves  <palves@redhat.com>
10690
10691         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10692         parameter.
10693         (fetch_inferior_event): Use SCOPE_EXIT.
10694
10695
10696 2019-01-23  Tom Tromey  <tom@tromey.com>
10697             Pedro Alves  <palves@redhat.com>
10698
10699         * infrun.c (disable_thread_events): Delete.
10700         (stop_all_threads): Use SCOPE_EXIT.
10701
10702 2019-01-23  Tom Tromey  <tom@tromey.com>
10703             Pedro Alves  <palves@redhat.com>
10704
10705         * symfile.c: Include forward-scope-exit.h.
10706         (clear_symtab_users_cleanup): Replace forward declaration with
10707         a FORWARD_SCOPE_EXIT.
10708         (syms_from_objfile_1): Use the forward_scope_exit and
10709         gdb::optional instead of cleanup_function.
10710         (reread_symbols): Use the forward_scope_exit instead of
10711         cleanup_function.
10712         (clear_symtab_users_cleanup): Remove function.
10713
10714 2019-01-23  Tom Tromey  <tom@tromey.com>
10715             Pedro Alves  <palves@redhat.com>
10716
10717         * linux-nat.c: Include scope-exit.h.
10718         (cleanup_target_stop): Remove.
10719         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10720         SCOPE_EXIT.
10721
10722 2019-01-23  Tom Tromey  <tom@tromey.com>
10723             Pedro Alves  <palves@redhat.com>
10724
10725         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10726         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10727
10728 2019-01-23  Tom Tromey  <tom@tromey.com>
10729             Andrew Burgess  <andrew.burgess@embecosm.com>
10730             Pedro Alves  <palves@redhat.com>
10731
10732         * infrun.c (fetch_inferior_event): Use scope_exit.
10733         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10734         * top.c (execute_command): Use scope_exit.
10735         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10736         * utils.c (do_bpstat_clear_actions_cleanup)
10737         (make_bpstat_clear_actions_cleanup): Remove.
10738
10739 2019-01-23  Tom Tromey  <tom@tromey.com>
10740             Pedro Alves  <palves@redhat.com>
10741
10742         * infrun.c: Include "common/scope-exit.h"
10743         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10744         (wait_for_inferior): Use SCOPE_EXIT.
10745         (fetch_inferior_event): Use scope_exit.
10746
10747 2019-01-23  Tom Tromey  <tom@tromey.com>
10748             Pedro Alves  <palves@redhat.com>
10749
10750         * breakpoint.c (create_breakpoint): Remove cleanup.
10751
10752 2019-01-23  Tom Tromey  <tom@tromey.com>
10753             Andrew Burgess  <andrew.burgess@embecosm.com>
10754             Pedro Alves  <palves@redhat.com>
10755
10756 2019-01-23  Pedro Alves  <palves@redhat.com>
10757
10758         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10759
10760 2019-01-23  Pedro Alves  <palves@redhat.com>
10761             Andrew Burgess  <andrew.burgess@embecosm.com>
10762
10763         * gdbthread.h: Include "common/forward-scope-exit.h".
10764         (scoped_finish_thread_state): Redefine custom class in terms of
10765         forward_scope_exit.
10766
10767 2019-01-23  Pedro Alves  <palves@redhat.com>
10768             Andrew Burgess  <andrew.burgess@embecosm.com>
10769
10770         * common/forward-scope-exit.h: New file.
10771
10772 2019-01-23  Pedro Alves  <palves@redhat.com>
10773             Andrew Burgess  <andrew.burgess@embecosm.com>
10774             Tom Tromey  <tom@tromey.com>
10775
10776         * common/scope-exit.h: New file.
10777
10778 2019-01-23  Pedro Alves  <palves@redhat.com>
10779
10780         * common/preprocessor.h (ESC): Rename to ...
10781         (ESC_PARENS): ... this.
10782         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10783         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10784
10785 2019-01-23  Tom Tromey  <tom@tromey.com>
10786
10787         * language.h (class scoped_switch_to_sym_language_if_auto):
10788         Initialize m_lang in both cases.
10789
10790 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10791
10792         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10793         with XCNEW.
10794
10795 2019-01-22  Tom Tromey  <tom@tromey.com>
10796
10797         * corelow.c: Do not include sys/file.h.
10798
10799 2019-01-22  Tom Tromey  <tom@tromey.com>
10800
10801         * tui/tui-wingeneral.h: Include gdb_curses.h.
10802
10803 2019-01-22  Tom Tromey  <tom@tromey.com>
10804
10805         * source-cache.h (class source_cache) <get_source_lines,
10806         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10807
10808 2019-01-22  Tom Tromey  <tom@tromey.com>
10809
10810         * remote-fileio.h (struct remote_target): Declare.
10811
10812 2019-01-22  Tom Tromey  <tom@tromey.com>
10813
10814         * python/py-arch.c: Do not include py-ref.h.
10815         * python/py-bpevent.c: Do not include py-ref.h.
10816         * python/py-cmd.c: Do not include py-ref.h.
10817         * python/py-continueevent.c: Do not include py-ref.h.
10818         * python/py-event.h: Do not include py-ref.h.
10819         * python/py-evtregistry.c: Do not include py-ref.h.
10820         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10821         * python/py-frame.c: Do not include py-ref.h.
10822         * python/py-framefilter.c: Do not include py-ref.h.
10823         * python/py-function.c: Do not include py-ref.h.
10824         * python/py-infevents.c: Do not include py-ref.h.
10825         * python/py-linetable.c: Do not include py-ref.h.
10826         * python/py-objfile.c: Do not include py-ref.h.
10827         * python/py-param.c: Do not include py-ref.h.
10828         * python/py-prettyprint.c: Do not include py-ref.h.
10829         * python/py-progspace.c: Do not include py-ref.h.
10830         * python/py-symbol.c: Do not include py-ref.h.
10831         * python/py-symtab.c: Do not include py-ref.h.
10832         * python/py-type.c: Do not include py-ref.h.
10833         * python/py-unwind.c: Do not include py-ref.h.
10834         * python/py-utils.c: Do not include py-ref.h.
10835         * python/py-value.c: Do not include py-ref.h.
10836         * python/py-varobj.c: Do not include py-ref.h.
10837         * python/py-xmethods.c: Do not include py-ref.h.
10838         * python/python.c: Do not include py-ref.h.
10839         * varobj.c: Do not include py-ref.h.
10840
10841 2019-01-22  Tom Tromey  <tom@tromey.com>
10842
10843         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10844         keyword for bcache.
10845
10846 2019-01-22  Tom Tromey  <tom@tromey.com>
10847
10848         * compile/compile-cplus-types.c: Remove a comment by #include.
10849
10850 2019-01-22  Tom Tromey  <tom@tromey.com>
10851
10852         * compile/gcc-c-plugin.h: Include compile-internal.h.
10853
10854 2019-01-22  Tom Tromey  <tom@tromey.com>
10855
10856         * stabsread.c (EXTERN): Do not define.
10857         (symnum, next_symbol_text_func, processing_gcc_compilation)
10858         (within_function, global_sym_chain, global_stabs)
10859         (previous_stab_code, this_object_header_files)
10860         (n_this_object_header_files)
10861         (n_allocated_this_object_header_files): Define.
10862         * stabsread.h (EXTERN): Never define.  Use "extern".
10863
10864 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10865
10866         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10867         history_value.
10868
10869 2019-01-21  Tom Tromey  <tom@tromey.com>
10870
10871         * ui-out.c: Fix includes.
10872         * tui/tui-source.c: Fix includes.
10873         * target.c: Fix includes.
10874         * remote.c: Fix includes.
10875         * regcache.c: Fix includes.
10876         * python/py-block.c: Fix includes.
10877         * printcmd.c: Fix includes.
10878         * or1k-tdep.c: Fix includes.
10879         * mi/mi-main.c: Fix includes.
10880         * m32r-tdep.c: Fix includes.
10881         * csky-tdep.c: Fix includes.
10882         * compile/compile-cplus-types.c: Fix includes.
10883         * cli/cli-interp.c: Fix includes.
10884
10885 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10886
10887         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10888         for padding.
10889
10890 2019-01-16  Tom Tromey  <tom@tromey.com>
10891
10892         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10893         earlier.
10894         (struct objfile) <msymbols_range>: Move from top level.
10895         <msymbols>: New method.
10896         (class objfile_msymbols): Remove.
10897         * symtab.c (default_collect_symbol_completion_matches_break_on):
10898         Update.
10899         * symmisc.c (dump_msymbols): Update.
10900         * stabsread.c (scan_file_globals): Update.
10901         * objc-lang.c (info_selectors_command, info_classes_command)
10902         (find_methods): Update.
10903         * minsyms.c (find_solib_trampoline_target): Update.
10904         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10905         * coffread.c (coff_symfile_read): Update.
10906         * ada-lang.c (ada_lookup_simple_minsym)
10907         (ada_collect_symbol_completion_matches): Update.
10908
10909 2019-01-16  Tom Tromey  <tom@tromey.com>
10910
10911         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10912         type.  Remove no-argument constructor.
10913         <iterator::operator++>: Simplify.
10914         <begin>: Update.
10915         <end>: Use minimal_symbol_count.
10916
10917 2019-01-16  Tom Tromey  <tom@tromey.com>
10918
10919         * objfiles.h (struct objfile) <psymtabs>: New method.
10920         (class objfile_psymtabs): Remove.
10921         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10922         typedef.
10923         <range>: New method.
10924         (require_partial_symbols): Change return type.
10925         * psymtab.c (require_partial_symbols)
10926         (psym_expand_symtabs_matching): Update.
10927         * mdebugread.c (parse_partial_symbols): Update.
10928         * dbxread.c (dbx_end_psymtab): Update.
10929
10930 2019-01-15  Tom Tromey  <tom@tromey.com>
10931
10932         * symtab.c (lookup_objfile_from_block)
10933         (lookup_symbol_in_objfile_symtabs)
10934         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10935         (find_line_symtab, info_sources_command)
10936         (default_collect_symbol_completion_matches_break_on)
10937         (make_source_files_completion_list): Update.
10938         * symmisc.c (print_objfile_statistics, dump_objfile)
10939         (maintenance_print_symbols, maintenance_info_symtabs)
10940         (maintenance_check_symtabs, maintenance_info_line_tables):
10941         Update.
10942         * source.c (select_source_symtab)
10943         (forget_cached_source_info_for_objfile): Update.
10944         * objfiles.h (class objfile_compunits): Remove.
10945         (struct objfile) <compunits_range>: New typedef.
10946         (compunits): New method.
10947         * objfiles.c (objfile_relocate1): Update.
10948         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10949         * maint.c (count_symtabs_and_blocks): Update.
10950         * linespec.c (iterate_over_all_matching_symtabs): Update.
10951         * cp-support.c (add_symbol_overload_list_qualified): Update.
10952         * coffread.c (coff_symtab_read): Update.
10953         * ada-lang.c (add_nonlocal_symbols)
10954         (ada_collect_symbol_completion_matches)
10955         (ada_add_global_exceptions): Update.
10956
10957 2019-01-15  Tom Tromey  <tom@tromey.com>
10958
10959         * progspace.h (program_space) <objfiles_safe_range>: New
10960         typedef.
10961         <objfiles_safe>: New method.
10962         * objfiles.h (class all_objfiles_safe): Remove.
10963         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10964         * jit.c (jit_inferior_exit_hook): Update.
10965
10966 2019-01-17  Tom Tromey  <tom@tromey.com>
10967
10968         * progspace.h (program_space) <objfiles_range>: New typedef.
10969         <objfiles>: New method.
10970         <objfiles_head>: Rename from objfiles.
10971         (object_files): Update.
10972         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10973         * guile/scm-pretty-print.c
10974         (ppscm_find_pretty_printer_from_objfiles): Update.
10975         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10976         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10977         Update.
10978         * python/py-progspace.c (pspy_get_objfiles): Update.
10979         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10980         Update.
10981         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10982         (objfpy_lookup_objfile_by_build_id): Update.
10983         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10984         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10985         Update.
10986         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10987         (expand_symtab_containing_pc, lookup_objfile_from_block)
10988         (lookup_static_symbol, basic_lookup_transparent_type)
10989         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10990         (find_line_symtab, info_sources_command)
10991         (default_collect_symbol_completion_matches_break_on)
10992         (make_source_files_completion_list, find_main_name): Update.
10993         * symmisc.c (print_symbol_bcache_statistics)
10994         (print_objfile_statistics, maintenance_print_symbols)
10995         (maintenance_print_msymbols, maintenance_print_objfiles)
10996         (maintenance_info_symtabs, maintenance_check_symtabs)
10997         (maintenance_expand_symtabs, maintenance_info_line_tables):
10998         Update.
10999         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11000         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11001         (map_overlay_command, unmap_overlay_command)
11002         (simple_overlay_update, expand_symtabs_matching)
11003         (map_symbol_filenames): Update.
11004         * symfile-debug.c (set_debug_symfile): Update.
11005         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11006         Update.
11007         * source.c (select_source_symtab, forget_cached_source_info):
11008         Update.
11009         * solib.c (solib_read_symbols): Update.
11010         * solib-spu.c (append_ocl_sos): Update.
11011         * psymtab.c (maintenance_print_psymbols)
11012         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11013         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11014         * printcmd.c (info_symbol_command): Update.
11015         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11016         Update.
11017         * objfiles.h (class all_objfiles): Remove.
11018         * objfiles.c (have_partial_symbols, have_full_symbols)
11019         (have_minimal_symbols, qsort_cmp, update_section_map)
11020         (shared_objfile_contains_address_p)
11021         (default_iterate_over_objfiles_in_search_order): Update.
11022         * objc-lang.c (info_selectors_command, info_classes_command)
11023         (find_methods): Update.
11024         * minsyms.c (find_solib_trampoline_target): Update.
11025         * maint.c (maintenance_info_sections)
11026         (maintenance_translate_address, count_symtabs_and_blocks):
11027         Update.
11028         * main.c (captured_main_1): Update.
11029         * linux-thread-db.c (try_thread_db_load_from_pdir)
11030         (has_libpthread): Update.
11031         * linespec.c (iterate_over_all_matching_symtabs)
11032         (search_minsyms_for_name): Update.
11033         * jit.c (jit_find_objf_with_entry_addr): Update.
11034         * hppa-tdep.c (find_unwind_entry)
11035         (hppa_lookup_stub_minimal_symbol): Update.
11036         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11037         Update.
11038         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11039         (elf_gnu_ifunc_resolve_by_got): Update.
11040         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11041         * dwarf-index-write.c (save_gdb_index_command): Update.
11042         * cp-support.c (add_symbol_overload_list_qualified): Update.
11043         * breakpoint.c (create_overlay_event_breakpoint)
11044         (create_longjmp_master_breakpoint)
11045         (create_std_terminate_master_breakpoint)
11046         (create_exception_master_breakpoint): Update.
11047         * blockframe.c (find_pc_partial_function): Update.
11048         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11049         (ada_collect_symbol_completion_matches)
11050         (ada_add_global_exceptions): Update.
11051
11052 2019-01-17  Tom Tromey  <tom@tromey.com>
11053
11054         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11055         declare VEC.
11056         (solib_target_parse_libraries): Change return type.
11057         (library_list_start_segment, library_list_start_section)
11058         (library_list_end_library, library_list_start_library); Update.
11059         (solib_target_free_library_list): Remove.
11060         (solib_target_parse_libraries): Remove cleanup.  Change return
11061         type.
11062         (solib_target_current_sos): Update.
11063
11064 2019-01-17  Tom Tromey  <tromey@bapiya>
11065
11066         * valprint.c: Replace "the the" with "the".
11067         * symtab.c: Replace "the the" with "the".
11068         * solib.c: Replace "the the" with "the".
11069         * solib-dsbt.c: Replace "the the" with "the".
11070         * linespec.c: Replace "the the" with "the".
11071         * dwarf2loc.h: Replace "the the" with "the".
11072         * amd64-windows-tdep.c: Replace "the the" with "the".
11073         * aarch64-tdep.c: Replace "the the" with "the".
11074
11075 2019-01-16  Keith Seitz  <keiths@redhat.com>
11076
11077         PR gdb/23773
11078         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11079         <builder>: Rename to ..
11080         <m_builder>: ... this and make private.
11081         (dwarf2_cu::get_builder): New method.  Change all users of
11082         `builder' to use this method.
11083         (dwarf2_start_symtab): Move to ...
11084         (dwarf2_cu::start_symtab): ... here.  Update all callers
11085         (setup_type_unit_groups): Move to ...
11086         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11087         callers.
11088         (dwarf2_cu::reset_builder): New method.
11089         (process_full_compunit, process_full_type_unit): Use
11090         dwarf2_cu::reset_builder.
11091         (follow_die_offset): Record the ancestor CU if it is different
11092         from the followed DIE's CU.
11093         (follow_die_sig_1): Likewise.
11094
11095 2019-01-15  Tom Tromey  <tom@tromey.com>
11096
11097         * remote.c (class remote_state) <buf>: Now a char_vector.
11098         <buf_size>: Remove.
11099         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11100         parameter.
11101         (remote_target::getpkt_or_notif_sane_1)
11102         (remote_target::getpkt_sane)
11103         (remote_target::getpkt_or_notif_sane): Likewise.
11104         (class remote_target) <putpkt>: New overload.
11105         (remote_target::read_frame): Change type of "buf_p".  Remove
11106         sizeof_p parameter.
11107         (packet_ok): New overload.
11108         (packet_check_result): New overload.
11109         Update all uses.
11110
11111 2019-01-14  Tom Tromey  <tom@tromey.com>
11112
11113         * remote-notif.c (handle_notification, remote_notif_ack)
11114         (remote_notif_parse): Make "buf" const.
11115         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11116         const.
11117         (remote_notif_parse, remote_notif_ack, handle_notification):
11118         Likewise.
11119         * remote.c (remote_notif_stop_parse): Make "buf" const.
11120         (remote_target::remote_parse_stop_reply): Make "buf" const.
11121         (remote_notif_stop_ack): Make "buf" const.
11122
11123 2019-01-14  Tom Tromey  <tom@tromey.com>
11124
11125         * remote.c (remote_console_output): Make parameter const.
11126
11127 2019-01-14  Tom Tromey  <tom@tromey.com>
11128
11129         * target-debug.h (target_debug_print_signals): Constify.
11130         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11131         * procfs.c (procfs_target::pass_signals): Update.
11132         * linux-nat.c (linux_nat_target::pass_signals): Update.
11133         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11134         * target-delegates.c: Rebuild.
11135         * remote.c (remote_target::program_signals): Update.
11136         (remote_target::pass_signals): Update.
11137         * target.c (target_pass_signals): Constify argument.
11138         (target_program_signals): Likewise.
11139         * target.h (struct target_ops) <pass_signals, program_signals>:
11140         Constify argument.
11141         (target_pass_signals, target_program_signals): Constify argument.
11142
11143 2019-01-14  Tom Tromey  <tom@tromey.com>
11144
11145         PR tui/28819:
11146         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11147
11148 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11149
11150         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11151         field.
11152         * rs6000-tdep.c: Include reggroups.h.
11153         (IS_V_ALIAS_PSEUDOREG): Define.
11154         (rs6000_register_name): Return names for the "vX" aliases.
11155         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11156         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11157         aliases.  Call default_register_reggroup_p for all other
11158         pseudo-registers.
11159         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11160         New functions.
11161         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11162         Handle "vX" aliases.
11163         (v_alias_pseudo_register_collect): New function.
11164         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11165         (rs6000_gdbarch_init): Initialize "vX" aliases as
11166         pseudo-registers.  Restore registration of
11167         rs6000_pseudo_register_reggroup_p with
11168         set_tdesc_pseudo_register_reggroup_p.
11169
11170 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11171
11172         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11173         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11174         set_gdbarch_num_pseudo_regs.
11175
11176 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11177
11178         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11179         Remove arg prefixname, add do_set and do_show.
11180         Add member functions set_list and show_list.
11181         * cli/cli-style.c (class cli_style_option): Update accordingly.
11182         (style_set_list): Move to file scope.
11183         (style_show_list): Likewise.
11184         (set_style): Call help_list.
11185         (show_style): Call cmd_show_list.
11186         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11187         Update to use the new macro.
11188
11189 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11190
11191         * ada-lang.c (_initialize_ada_language): Expand the help text
11192         for the "catch exception" command.
11193
11194 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11195
11196         * symtab.c (matching_obj_sections): Initialize obj,
11197         declare it closer to its usage.
11198
11199 2019-01-10  Tom Tromey  <tom@tromey.com>
11200
11201         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11202         (basic_inf_threads_range): Remove.
11203         (inf_threads_range, inf_non_exited_threads_range)
11204         (safe_inf_threads_range): Use next_adapter.
11205
11206 2019-01-10  Keith Seitz  <keiths@redhat.com>
11207
11208         PR gdb/23712
11209         PR symtab/23010
11210         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11211         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11212
11213 2019-01-10  Keith Seitz  <keiths@redhat.com>
11214
11215         PR gdb/23712
11216         PR symtab/23010
11217         * dictionary.c (pending_to_vector): Remove.
11218         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11219         Remove _1 suffix, replacing functions of the same name.  Update
11220         all callers.
11221         (dict_create_hashed, dict_create_hashed_expandable)
11222         (dict_create_linear, dict_create_linear_expandable, dict_free)
11223         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11224         Make functions static.
11225
11226 2019-01-10  Keith Seitz  <keiths@redhat.com>
11227
11228         PR gdb/23712
11229         PR symtab/23010
11230         * dictionary.h (struct dictionary): Replace declaration with
11231         multidictionary.
11232         (dict_create_hashed, dict_create_hashed_expandable)
11233         (dict_create_linear, dict_create_linear_expandable)
11234         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11235         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11236         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11237         taking multidictionary argument.
11238         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11239         * block.h (struct block) <dict>: Change to multidictionary
11240         and rename `multidict'.
11241         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11242         symmisc.c: Update all dictionary references to multidictionary.
11243
11244 2019-01-10  Keith Seitz  <keiths@redhat.com>
11245
11246         PR gdb/23712
11247         PR symtab/23010
11248         * dictionary.c: Include unordered_map.
11249         (pending_to_vector): New function.
11250         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11251         Rewrite the non-"_1" functions to take vector instead
11252         of linked list.
11253         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11254         "new" _1 versions of the same name.
11255         (multidictionary): Define.
11256         (std::hash<enum language): New definition.
11257         (collate_pending_symbols_by_language, mdict_create_hashed)
11258         (mdict_create_hashed_expandable, mdict_create_linear)
11259         (mdict_create_linear_expandable, mdict_free)
11260         (find_language_dictionary, create_new_language_dictionary)
11261         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11262         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11263         (mdict_size, mdict_empty): New functions.
11264         * dictionary.h (mdict_iterator): Define.
11265
11266 2019-01-10  Pedro Alves  <palves@redhat.com>
11267
11268         * breakpoint.c (read_uploaded_action)
11269         (create_tracepoint_from_upload): Adjust to use
11270         gdb::unique_xmalloc_ptr.
11271         * ctf.c (ctf_write_uploaded_tp):
11272         (SET_ARRAY_FIELD): Use emplace_back.
11273         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11274         * tracefile-tfile.c (tfile_write_uploaded_tp):
11275         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11276         gdb::unique_xmalloc_ptr.
11277         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11278         at_string, cond_string, cmd_strings>: Replace char pointers
11279         with gdb::unique_xmalloc_ptr.
11280
11281 2019-01-10  Pedro Alves  <palves@redhat.com>
11282
11283         * solib-target.c (library_list_start_library): Don't xstrdup name.
11284
11285 2019-01-10  Pedro Alves  <palves@redhat.com>
11286
11287         * mdebugread.c (parse_partial_symbols): Use
11288         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11289
11290 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11291
11292         * linux-fork.c (scoped_switch_fork_info)
11293         <~scoped_switch_fork_info>: Fix incorrect variable name.
11294
11295 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11296
11297         * linux-fork.c (scoped_switch_fork_info)
11298         <scoped_switch_fork_info>: Make explicit.
11299         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11300
11301 2019-01-10  Tom Tromey  <tom@tromey.com>
11302
11303         * objfiles.h (objfile::reset_psymtabs): Update.
11304         * objfiles.c (objfile::objfile): Update.
11305         * psymtab.h (psymtab_storage::obstack): Update.
11306         (psymtab_storage::m_obstack): Use gdb::optional.
11307         (class psymtab_storage): Update comment.  Remove objfile
11308         parameter.
11309         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11310
11311 2019-01-10  Tom Tromey  <tom@tromey.com>
11312
11313         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11314         <free_psymtabs>: Now private.
11315         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11316         (allocate_psymtab): Use new method.
11317
11318 2019-01-10  Tom Tromey  <tom@tromey.com>
11319
11320         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11321         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11322         * mdebugread.c (parse_partial_symbols): Use
11323         allocate_dependencies.
11324         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11325         allocate_dependencies.
11326         (process_psymtab_comp_unit_reader)
11327         (build_type_psymtab_dependencies): Likewise.
11328         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11329
11330 2019-01-10  Tom Tromey  <tom@tromey.com>
11331
11332         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11333         PSYMBOL_SET_LANGUAGE.
11334         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11335
11336 2019-01-10  Tom Tromey  <tom@tromey.com>
11337
11338         * psymtab.h (psymtab_storage::obstack): New method.
11339         <m_obstack>: Rename from obstack; now private.
11340         * psymtab.c (psymtab_storage): Update.
11341         * dwarf2read.c (create_addrmap_from_index)
11342         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11343         Update.
11344
11345 2019-01-10  Tom Tromey  <tom@tromey.com>
11346
11347         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11348         * objfiles.h (objfile::reset_psymtabs): New method.
11349
11350 2019-01-10  Tom Tromey  <tom@tromey.com>
11351
11352         * symmisc.c (print_symbol_bcache_statistics): Update.
11353         (print_objfile_statistics): Update.
11354         * symfile.c (reread_symbols): Update.
11355         * psymtab.h (class psymtab_storage): New.
11356         * psymtab.c (psymtab_storage): New constructor.
11357         (~psymtab_storage): New destructor.
11358         (require_partial_symbols): Update.
11359         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11360         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11361         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11362         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11363         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11364         (start_psymtab_common, end_psymtab_common)
11365         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11366         (allocate_psymtab): Update.
11367         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11368         Update.
11369         (dump_psymtab_addrmap, maintenance_print_psymbols)
11370         (maintenance_check_psymtabs): Update.
11371         (class objfile_psymtabs): Move to objfiles.h.
11372         * psympriv.h (discard_psymtab): Now inline.
11373         (psymtab_discarder::psymtab_discarder): Update.
11374         (psymtab_discarder::~psymtab_discarder): Update.
11375         (ALL_OBJFILE_PSYMTABS): Rewrite.
11376         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11377         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11378         Remove fields.
11379         <partial_symtabs>: New field.
11380         (class objfile_psymtabs): Move from psymtab.h.  Update.
11381         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11382         psymbol_cache.
11383         (objfile::~objfile): Don't destroy psymbol_cache.
11384         * mdebugread.c (parse_partial_symbols): Update.
11385         * dwarf2read.c (create_addrmap_from_index)
11386         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11387         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11388         (add_partial_subprogram, dwarf2_ranges_read): Update.
11389         * dwarf-index-write.c (write_address_map)
11390         (write_one_signatured_type, recursively_write_psymbols)
11391         (class debug_names, class debug_names, write_psymtabs_to_index):
11392         Update.
11393
11394 2019-01-10  Tom Tromey  <tom@tromey.com>
11395
11396         * symtab.h (SYMBOL_SET_NAMES): Update.
11397         (symbol_set_names): Update.
11398         (MSYMBOL_SET_NAMES): Update.
11399         * symtab.c (symbol_set_names): Change argument to be an
11400         objfile_per_bfd_storage.
11401         * psymtab.c (add_psymbol_to_bcache): Update.
11402         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11403
11404 2019-01-10  Tom Tromey  <tom@tromey.com>
11405
11406         * symtab.c (create_demangled_names_hash): Change argument to be an
11407         objfile_per_bfd_storage.
11408         (symbol_set_names): Update.
11409
11410 2019-01-10  Tom Tromey  <tom@tromey.com>
11411
11412         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11413         init_psymbol_list.
11414         * psymtab.c (init_psymbol_list): Do nothing if already called.
11415         * psympriv.h (init_psymbol_list): Add comment.
11416         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11417         init_psymbol_list.
11418         * dbxread.c (dbx_symfile_read): Unconditionally call
11419         init_psymbol_list.
11420
11421 2019-01-10  Tom Tromey  <tom@tromey.com>
11422
11423         * xcoffread.c (scan_xcoff_symtab): Update.
11424         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11425         "where".
11426         * mdebugread.c (parse_partial_symbols)
11427         (handle_psymbol_enumerators): Update.
11428         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11429         * dbxread.c (read_dbx_symtab): Update.
11430         * psympriv.h (psymbol_placement): New enum.
11431         (add_psymbol_to_list): Update.
11432
11433 2019-01-10  Tom Tromey  <tom@tromey.com>
11434
11435         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11436         static_psymbols parameters.
11437         (scan_xcoff_symtab): Update.
11438         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11439         static_psymbols parameters.
11440         * psympriv.h (start_psymtab_common): Update.
11441         * mdebugread.c (parse_partial_symbols): Update.
11442         * dwarf2read.c (create_partial_symtab): Update.
11443         * dbxread.c (read_dbx_symtab): Update.
11444         (start_psymtab): Remove global_psymbols and static_psymbols
11445         parameters.
11446
11447 2019-01-10  Tom Tromey  <tom@tromey.com>
11448
11449         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11450         * psymtab.c (allocate_psymtab): Add comment.
11451         * psympriv.h (allocate_psymtab): Add comment.
11452         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11453         initializations.
11454         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11455
11456 2019-01-10  Tom Tromey  <tom@tromey.com>
11457
11458         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11459         Don't declare.
11460         * mipsread.c: Include mdebugread.h.
11461         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11462         Declare.
11463         * elfread.c: Include mdebugread.h.
11464
11465 2019-01-09  Tom Tromey  <tom@tromey.com>
11466
11467         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11468         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11469         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11470         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11471         (psym_lookup_symbol, psym_find_last_source_symtab)
11472         (psym_forget_cached_source_info, psym_print_stats)
11473         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11474         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11475         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11476         (psym_find_compunit_symtab_by_address)
11477         (maintenance_print_psymbols, maintenance_info_psymtabs)
11478         (maintenance_check_psymtabs): Use ranged for.
11479         * psymtab.h (class objfile_psymtabs): New.
11480         (require_partial_symbols): Return objfile_psymtabs.
11481         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11482
11483 2019-01-09  Tom Tromey  <tom@tromey.com>
11484
11485         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11486         (find_pc_mapped_section, list_overlays_command)
11487         (map_overlay_command, unmap_overlay_command)
11488         (simple_overlay_update): Use all_objfiles.
11489         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11490         * printcmd.c (info_symbol_command): Use all_objfiles.
11491         * objfiles.h (ALL_OBJSECTIONS): Remove.
11492         * maint.c (maintenance_translate_address): Use all_objfiles.
11493         * gcore.c (gcore_create_callback): Use all_objfiles.
11494         (objfile_find_memory_regions): Likewise.
11495
11496 2019-01-09  Tom Tromey  <tom@tromey.com>
11497
11498         * symtab.c (find_line_symtab, info_sources_command)
11499         (make_source_files_completion_list): Use objfile_compunits.
11500         * source.c (select_source_symtab): Use objfile_compunits.
11501         * objfiles.h (struct objfile): Update comment.
11502         (ALL_OBJFILES): Remove.
11503         (ALL_FILETABS): Remove.
11504         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11505         objfile_compunits.
11506
11507 2019-01-09  Tom Tromey  <tom@tromey.com>
11508
11509         * symmisc.c (print_objfile_statistics, dump_objfile)
11510         (maintenance_print_symbols): Use compunit_filetabs.
11511         * source.c (forget_cached_source_info_for_objfile): Use
11512         compunit_filetabs.
11513         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11514         (ALL_FILETABS): Use compunit_filetabs.
11515         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11516         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11517
11518 2019-01-09  Tom Tromey  <tom@tromey.com>
11519
11520         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11521         (compunit_filetabs): New.
11522         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11523         compunit_filetabs.
11524         (info_sources_command, make_source_files_completion_list): Remove
11525         declaration.
11526         * symmisc.c (print_objfile_statistics, dump_objfile)
11527         (maintenance_print_symbols): Remove declaration.
11528         (maintenance_info_symtabs): Use compunit_filetabs.
11529         (maintenance_info_line_tables): Likewise.
11530         * source.c (select_source_symtab): Change local variable name.
11531         (forget_cached_source_info_for_objfile): Remove declaration.
11532         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11533         * objfiles.c (objfile_relocate1): Remove declaration.
11534         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11535         declaration.
11536         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11537         * coffread.c (coff_symtab_read): Remove declaration.
11538         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11539         compunit_filetabs.
11540
11541 2019-01-09  Tom Tromey  <tom@tromey.com>
11542
11543         * symtab.c (lookup_objfile_from_block)
11544         (find_pc_sect_compunit_symtab, search_symbols)
11545         (default_collect_symbol_completion_matches_break_on): Use
11546         objfile_compunits.
11547         * objfiles.h (ALL_COMPUNITS): Remove.
11548         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11549         * cp-support.c (add_symbol_overload_list_qualified): Use
11550         objfile_compunits.
11551         * ada-lang.c (ada_collect_symbol_completion_matches)
11552         (ada_add_global_exceptions): Use objfile_compunits.
11553
11554 2019-01-09  Tom Tromey  <tom@tromey.com>
11555
11556         * source.c (select_source_symtab)
11557         (forget_cached_source_info_for_objfile): Remove declaration.
11558         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11559         declaration.
11560         * maint.c (count_symtabs_and_blocks): Remove declaration.
11561         * cp-support.c (add_symbol_overload_list_qualified): Remove
11562         declaration.
11563         * coffread.c (coff_symtab_read): Remove declaration.
11564         * symtab.c (lookup_symbol_in_objfile_symtabs)
11565         (basic_lookup_transparent_type_1): Use objfile_compunits.
11566         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11567         (info_sources_command, search_symbols)
11568         (default_collect_symbol_completion_matches_break_on)
11569         (make_source_files_completion_list): Remove declaration.
11570         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11571         (ada_collect_symbol_completion_matches)
11572         (ada_add_global_exceptions): Remove declaration.
11573         * linespec.c (iterate_over_all_matching_symtabs): Use
11574         objfile_compunits.
11575         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11576         (class objfile_compunits): New.
11577         (ALL_COMPUNITS): Use objfile_compunits.
11578         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11579         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11580         objfile_compunits.
11581         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11582
11583 2019-01-09  Tom Tromey  <tom@tromey.com>
11584
11585         * symtab.c (search_symbols)
11586         (default_collect_symbol_completion_matches_break_on): Use
11587         objfile_msymbols.
11588         * ada-lang.c (ada_lookup_simple_minsym)
11589         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11590         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11591         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11592         objfile_msymbols.
11593         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11594         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11595         * objc-lang.c (find_methods): Use objfile_msymbols.
11596         (info_selectors_command, info_classes_command): Likewise.
11597         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11598         * objfiles.h (class objfile_msymbols): New.
11599         (ALL_OBJFILE_MSYMBOLS): Remove.
11600         (ALL_MSYMBOLS): Remove.
11601
11602 2019-01-09  Tom Tromey  <tom@tromey.com>
11603
11604         * common/next-iterator.h (next_adapter): Add Iterator template
11605         parameter.
11606         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11607         (class all_objfiles_safe): New.
11608         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11609         * objfiles.c (put_objfile_before): Update comment.
11610         (add_separate_debug_objfile): Likewise.
11611         (free_all_objfiles): Use all_objfiles_safe.
11612         (objfile_purge_solibs): Likewise.
11613
11614 2019-01-09  Tom Tromey  <tom@tromey.com>
11615
11616         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11617         (expand_symtab_containing_pc, lookup_static_symbol)
11618         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11619         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11620         all_objfiles.
11621         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11622         * breakpoint.c (create_overlay_event_breakpoint)
11623         (create_longjmp_master_breakpoint)
11624         (create_std_terminate_master_breakpoint)
11625         (create_exception_master_breakpoint): Use all_objfiles.
11626         * linux-thread-db.c (try_thread_db_load_from_pdir)
11627         (has_libpthread): Use all_objfiles.
11628         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11629         * linespec.c (iterate_over_all_matching_symtabs)
11630         (search_minsyms_for_name): Use all_objfiles.
11631         * maint.c (maintenance_info_sections): Use all_objfiles.
11632         * main.c (captured_main_1): Use all_objfiles.
11633         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11634         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11635         * guile/scm-pretty-print.c
11636         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11637         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11638         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11639         (maintenance_print_msymbols): Use all_objfiles.
11640         * source.c (select_source_symtab): Use all_objfiles.
11641         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11642         * symfile.c (remove_symbol_file_command)
11643         (expand_symtabs_matching, map_symbol_filenames): Use
11644         all_objfiles.
11645         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11646         all_objfiles.
11647         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11648         * objc-lang.c (find_methods): Use all_objfiles.
11649         * objfiles.c (have_partial_symbols, have_full_symbols)
11650         (have_minimal_symbols, qsort_cmp)
11651         (default_iterate_over_objfiles_in_search_order): Use
11652         all_objfiles.
11653         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11654         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11655         (maintenance_check_psymtabs): Use all_objfiles.
11656         (ALL_PSYMTABS): Remove.
11657         * compile/compile-object-run.c (do_module_cleanup): Use
11658         all_objfiles.
11659         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11660         * cp-support.c (add_symbol_overload_list_qualified): Use
11661         all_objfiles.
11662         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11663         Use all_objfiles.
11664         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11665         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11666         all_objfiles.
11667         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11668         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11669         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11670         Uses all_objfiles.
11671         * solib.c (solib_read_symbols): Use all_objfiles
11672
11673 2019-01-09  Tom Tromey  <tom@tromey.com>
11674
11675         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11676         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11677         all_objfiles.
11678         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11679         * symmisc.c (print_symbol_bcache_statistics)
11680         (print_objfile_statistics, maintenance_print_objfiles)
11681         (maintenance_info_symtabs, maintenance_check_symtabs)
11682         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11683         all_objfiles.
11684         * source.c (forget_cached_source_info): Use all_objfiles.
11685         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11686         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11687         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11688         * objfiles.c (update_section_map): Use all_objfiles.
11689         (shared_objfile_contains_address_p): Likewise.
11690         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11691         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11692
11693 2019-01-09  Tom Tromey  <tom@tromey.com>
11694
11695         * common/next-iterator.h: New file.
11696         * objfiles.h (class all_objfiles): New.
11697         (struct objfile_iterator): New.
11698
11699 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11700
11701         * NEWS: Move the description of the changed "frame", "select-frame",
11702          and "info frame" commands to the Changed commands section.
11703
11704 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11705
11706         * gdbtypes.c (check_stub_method_group): Remove handling of old
11707         mangling schemes.
11708         * linespec.c (find_methods): Likewise.
11709         * stabsread.c (read_member_functions): Likewise.
11710         * valops.c (search_struct_method): Likewise.
11711         (value_struct_elt_for_reference): Likewise.
11712         * NEWS: Mention this change.
11713
11714 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11715
11716         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11717         print_source_lines.
11718         * source.c (print_source_lines_base): Update line number check.
11719         (print_source_lines): New function.
11720         (source_lines_range::source_lines_range): New function.
11721         * source.h (class source_lines_range): New class.
11722         (print_source_lines): New declaration.
11723
11724 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11725
11726         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11727
11728 2019-01-08  Tom Tromey  <tom@tromey.com>
11729             Simon Marchi  <simon.marchi@ericsson.com>
11730
11731         PR gdb/24060
11732         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11733         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11734         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11735         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11736         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11737         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11738
11739 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11740
11741         * source.c (select_source_symtab): Move header comment to
11742         declaration in source.h.
11743         (forget_cached_source_info_for_objfile): Likewise.
11744         (forget_cached_source_info): Likewise.
11745         (identify_source_line): Likewise.
11746         * source.h (identify_source_line): Move declaration from symtab.h
11747         and add comment from source.c
11748         (print_source_lines): Likewise.
11749         (forget_cached_source_info_for_objfile): Likewise.
11750         (forget_cached_source_info): Likewise.
11751         (select_source_symtab): Likewise.
11752         (enum print_source_lines_flag): Move definition from symtab.h.
11753         * symtab.h (identify_source_line): Move declaration to source.h.
11754         (print_source_lines): Likewise.
11755         (forget_cached_source_info_for_objfile): Likewise.
11756         (forget_cached_source_info): Likewise.
11757         (select_source_symtab): Likewise.
11758         (enum print_source_lines_flag): Move definition to source.h.
11759         * tui/tui-hooks.c: Add 'source.h' include.
11760
11761 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11762
11763         * source.c (print_source_lines_base): Handle requests to print
11764         reverse line number sequences, and guard against empty lines
11765         string.
11766
11767 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11768
11769         * source.c (print_source_lines_base): Fix skip of '\r' if next
11770         character is '\n'.
11771
11772 2019-01-06  Tom Tromey  <tom@tromey.com>
11773
11774         * c-exp.y (struct c_parse_state) <macro_original_text,
11775         expansion_obstack>: New member.
11776         (macro_original_text, expansion_obstack): Remove globals.
11777         (scan_macro_expansion, scanning_macro_expansion)
11778         (finished_macro_expansion): Update.
11779         (scan_macro_cleanup): Remove.
11780         (yylex, c_parse): Update.
11781
11782 2019-01-06  Tom Tromey  <tom@tromey.com>
11783
11784         * c-exp.y (struct c_parse_state) <strings>: New member.
11785         (operator_stoken): Update.
11786
11787 2019-01-06  Tom Tromey  <tom@tromey.com>
11788
11789         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11790         (union type_stack_elt) <typelist_val>: Now a pointer to
11791         std::vector.
11792         (type_stack_cleanup): Don't declare.
11793         (push_typelist): Update.
11794         * parse.c (pop_typelist): Return a std::vector.
11795         (push_typelist): Take a std::vector.
11796         (follow_types): Update.  Do not free args.
11797         (type_stack_cleanup): Remove.
11798         * c-exp.y (struct c_parse_state): New.
11799         (cpstate): New global.
11800         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11801         (nonempty_typelist): Update.
11802         (func_mod): Create a new vector.
11803         (c_parse): Create a c_parse_state.
11804         (check_parameter_typelist): Do not delete params.
11805         (function_method): Update.  Do not delete type_list.
11806
11807 2019-01-06  Tom Tromey  <tom@tromey.com>
11808
11809         PR gdb/28155:
11810         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11811         check_typedef.
11812         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11813         (print_return_value): Likewise.
11814
11815 2019-01-05  Tom Tromey  <tom@tromey.com>
11816
11817         * contrib/cleanup_check.py: Remove.
11818         * contrib/gcc-with-excheck: Remove.
11819         * contrib/exsummary.py: Remove.
11820         * contrib/excheck.py: Remove.
11821
11822 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11823
11824         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11825         NULL. Initialize tpprev to NULL instead of assigning it
11826         to NULL on the next statement.
11827         * windows-nat.c (windows_delete_thread): Remove check for
11828         main_thread_id before printing thread exit notifications.
11829         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11830         Remove thread ID check against main_thread_id.
11831         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11832         windows_delete_thread.
11833         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11834
11835 2019-01-04  Tom Tromey  <tom@tromey.com>
11836
11837         * compile/compile.c (_initialize_compile): Use upper case for
11838         metasyntactic variables.
11839         * symmisc.c (_initialize_symmisc): Use upper case for
11840         metasyntactic variables.
11841         * psymtab.c (_initialize_psymtab): Use upper case for
11842         metasyntactic variables.
11843         * demangle.c (demangle_command): Use upper case for metasyntactic
11844         variables.
11845         (_initialize_demangler): Likewise.
11846         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11847         variables.
11848
11849 2019-01-03  Tom Tromey  <tom@tromey.com>
11850
11851         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11852
11853 2019-01-03  Tom Tromey  <tom@tromey.com>
11854
11855         * python/py-symtab.c (salpy_str): Update.
11856         (struct salpy_sal_object) <symtab>: Now a PyObject.
11857         (salpy_dealloc): Update.
11858         (del_objfile_sal): Use gdbpy_ref.
11859
11860 2019-01-03  Tom Tromey  <tom@tromey.com>
11861
11862         * python/py-type.c (convert_field): Use new_reference.  Return
11863         gdbpy_ref.
11864         (make_fielditem): Return gdbpy_ref.
11865         (typy_fields): Update.
11866         (typy_getitem): Update.
11867         (field_name): Return gdbpy_ref.  Use new_reference.
11868         (typy_iterator_iternext): Update.
11869
11870 2019-01-03  Tom Tromey  <tom@tromey.com>
11871
11872         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11873
11874 2019-01-03  Tom Tromey  <tom@tromey.com>
11875
11876         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11877         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11878         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11879         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11880         (pspy_set_type_printers): Likewise.
11881         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11882         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11883         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11884         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11885         (objfpy_set_type_printers): Likewise.
11886
11887 2019-01-03  Tom Tromey  <tom@tromey.com>
11888
11889         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11890         (gdbpy_print_stack): Use gdbpy_err_fetch.
11891         * python/python-internal.h (class gdbpy_err_fetch): New class.
11892         (class gdbpy_enter) <m_error_type, m_error_value,
11893         m_error_traceback>: Remove.
11894         <m_error>: New member.
11895         (gdbpy_exception_to_string): Don't declare.
11896         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11897         * python/py-value.c (convert_value_from_python): Use
11898         gdbpy_err_fetch.
11899         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11900         gdbpy_exception_to_string.
11901         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11902         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11903         gdbpy_err_fetch.
11904
11905 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11906
11907         * linux-nat.c (delete_lwp_cleanup): Delete.
11908         (struct lwp_deleter): New struct.
11909         (lwp_info_up): New typedef.
11910         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11911         lwp_info_up.
11912
11913 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11914
11915         * linux-fork.c (class scoped_switch_fork_info): New class.
11916         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11917
11918 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11919
11920         * valops.c (find_overload_match): Remove use of null_cleanup, and
11921         calls to do_cleanups.
11922
11923 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11924
11925         * compile/compile-cplus-types.c
11926         (compile_cplus_instance::decl_name): Handle changes to
11927         cp_func_name.
11928         * cp-support.c (cp_func_name): Update header comment, update
11929         return type.
11930         * cp-support.h (cp_func_name): Update return type in declaration.
11931         * valops.c (find_overload_match): Move temp_func local to top
11932         level of function and change its type.  Use temp_func to hold and
11933         delete temporary string obtained from cp_func_name.
11934
11935 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11936
11937         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11938         gdb::char_vector, remove cleanup, and update uses of `msg`.
11939
11940 2019-01-03  Jim Wilson  <jimw@sifive.com>
11941
11942         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11943
11944 2019-01-02  Tom Tromey  <tom@tromey.com>
11945
11946         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11947         (tdesc_parse_xml): Remove cleanups.
11948         * target-descriptions.h (make_cleanup_free_target_description):
11949         Don't declare.
11950         (target_desc_deleter): New struct.
11951         (target_desc_up): New typedef.
11952         * target-descriptions.c (target_desc_deleter::operator()): Rename
11953         from free_target_description.
11954         (make_cleanup_free_target_description): Remove.
11955
11956 2019-01-02  Tom Tromey  <tom@tromey.com>
11957
11958         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11959         constructor, destructor.
11960         (linespec_parser): Remove typedef.
11961         (~linespec_parser): Rename from linespec_parser_delete.
11962         (linespec_lex_to_end, linespec_complete_label)
11963         (linespec_complete): Update.
11964         (decode_line_full): Remove cleanups.
11965         (decode_line_1): Update.
11966
11967 2019-01-02  Tom Tromey  <tom@tromey.com>
11968
11969         * python/python-internal.h (inferior_to_inferior_object): Change
11970         return type.
11971         * python/py-exitedevent.c (create_exited_event_object): Update.
11972         * python/py-inferior.c (inferior_to_inferior_object): Return
11973         gdbpy_ref.
11974         (python_new_inferior, python_inferior_deleted)
11975         (thread_to_thread_object, delete_thread_object)
11976         (build_inferior_list, gdbpy_selected_inferior): Update.
11977         * python/py-infthread.c (create_thread_object): Update.  Also fail
11978         if inferior_to_inferior_object fails.
11979
11980 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11981
11982         * inferior.h (class inferior) <displaced_step_state>: New field.
11983         * infrun.h (struct displaced_step_state): Move here from
11984         infrun.c.  Initialize fields, add constructor.
11985         <inf>: Remove field.
11986         <reset>: New method.
11987         * infrun.c (struct displaced_step_inferior_state): Move to
11988         infrun.h.
11989         (displaced_step_inferior_states): Remove.
11990         (get_displaced_stepping_state): Adust.
11991         (displaced_step_in_progress_any_inferior): Adjust.
11992         (displaced_step_in_progress_thread): Adjust.
11993         (displaced_step_in_progress): Adjust.
11994         (add_displaced_stepping_state): Remove.
11995         (get_displaced_step_closure_by_addr): Adjust.
11996         (remove_displaced_stepping_state): Remove.
11997         (infrun_inferior_exit): Call displaced_step_state.reset.
11998         (use_displaced_stepping): Don't check for NULL.
11999         (displaced_step_prepare_throw): Call
12000         get_displaced_stepping_state.
12001         (displaced_step_fixup): Don't check for NULL.
12002         (prepare_for_detach): Don't check for NULL.
12003
12004 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12005
12006         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12007          in case of call that did not complete.
12008
12009 2019-01-02  Andrey Utkin  <autkin@undo.io>
12010
12011         * symfile.c (find_separate_debug_file): Fix search of debug files for
12012         remote debuggee.
12013
12014 2019-01-02  Tom Tromey  <tom@tromey.com>
12015
12016         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12017         indentation.
12018         * python/py-frame.c (frapy_older): Remove cast.
12019         (frapy_newer): Likewise.
12020         * python/py-breakpoint.c (local_setattro): Remove cast.
12021         * python/py-arch.c (archpy_name): Remove local variable.
12022         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12023
12024 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12025
12026         * unittests/basic_string_view/element_access/char/empty.cc:
12027         Fix year range in copyright header.
12028
12029 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12030
12031         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12032         Delete.
12033         <operator==>: Update with for removed field.
12034         <hash>: Likewise.
12035         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12036         <isa_features>: ...this.
12037         <abi_features>: New field.
12038         (riscv_isa_flen): Update comment.
12039         (riscv_abi_xlen): New declaration.
12040         (riscv_abi_flen): New declaration.
12041         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12042         isa_features.
12043         (riscv_abi_xlen): New function.
12044         (riscv_isa_flen): Update to get answer from isa_features.
12045         (riscv_abi_flen): New function.
12046         (riscv_has_fp_abi): Update to get answer from abi_features.
12047         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12048         xlen and flen.
12049         (riscv_call_info) <xlen, flen>: Update comment.
12050         (riscv_call_arg_struct): Remove invalid assertions
12051         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12052         is removed.
12053         (riscv_gdbarch_init): Gather isa features and abi features
12054         separately, ensure both match on the gdbarch when reusing an old
12055         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12056         a target with 64-bit float hardware.
12057
12058 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12059
12060         * source.c (search_command_helper): Stop reverse search
12061         when line 1 has been searched.
12062
12063 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12064
12065         * record-full.c (record_full_base_target::close): Rewrite
12066         record_full_core_buf_list free logic.
12067
12068 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12069
12070         * break-catch-syscall.c (print_one_catch_syscall): xfree
12071         the last text.
12072
12073 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12074
12075         * top.c (print_gdb_version): Update Copyright year in version
12076         message.
12077
12078 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12079
12080         Update copyright year range in all GDB files.
12081
12082 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12083
12084         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12085
12086 For older changes see ChangeLog-2018.
12087 \f
12088 Local Variables:
12089 mode: change-log
12090 left-margin: 8
12091 fill-column: 74
12092 version-control: never
12093 coding: utf-8
12094 End:
12095