Fix test-cp-name-parser build, parser_fprintf undefined
[external/binutils.git] / gdb / ChangeLog
1 2019-03-12  Pedro Alves  <palves@redhat.com>
2
3         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4
5 2019-03-12  Pedro Alves  <palves@redhat.com>
6
7         * cp-name-parser.y (main): Remove unused 'len' variable.
8
9 2019-03-12  Tom Tromey  <tromey@adacore.com>
10
11         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13
14 2019-03-12  Tom Tromey  <tromey@adacore.com>
15
16         * linux-nat.c (iterate_over_lwps): Update.
17         (stop_callback): Remove parameter.
18         (stop_wait_callback, detach_callback, resume_set_callback)
19         (select_singlestep_lwp_callback, set_ignore_sigint)
20         (status_callback, resumed_callback, resume_clear_callback)
21         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
22         data parameter.
23         (linux_nat_target::detach, linux_nat_target::resume)
24         (linux_stop_and_wait_all_lwps, select_event_lwp)
25         (linux_nat_filter_event, linux_nat_wait_1)
26         (linux_nat_target::kill, linux_nat_target::stop)
27         (linux_nat_target::stop): Update.
28         (linux_nat_resume_callback): Change type.
29         (resume_stopped_resumed_lwps, count_events_callback)
30         (select_event_lwp_callback): Likewise.
31         (linux_stop_lwp, linux_nat_stop_lwp): Update.
32         * arm-linux-nat.c (struct update_registers_data): Remove.
33         (update_registers_callback): Change type.
34         (arm_linux_insert_hw_breakpoint1): Update.
35         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
36         parameter.
37         (x86_linux_dr_set_addr): Update.
38         (x86_linux_dr_set_control): Update.
39         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
40         (iterate_over_lwps): Use gdb::function_view.
41         * nat/aarch64-linux-hw-point.c (struct
42         aarch64_dr_update_callback_param): Remove.
43         (debug_reg_change_callback): Change type.
44         (aarch64_notify_debug_reg_change): Update.
45         * s390-linux-nat.c (s390_refresh_per_info): Update.
46
47 2019-03-11  Tom Tromey  <tromey@adacore.com>
48
49         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
50         redundant assignment to "this_cu".
51
52 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
53
54         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
55
56 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
57
58         * gdbtypes.c (rank_one_type_parm_set): New function extracted
59         from...
60         (rank_one_type): ... this.
61
62 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
63
64         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
65         from...
66         (rank_one_type): ... this.
67
68 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
69
70         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
71         from...
72         (rank_one_type): ... this.
73
74 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
75
76         * gdbtypes.c (rank_one_type_parm_float): New function extracted
77         from...
78         (rank_one_type): ... this.
79
80 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
81
82         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
83         from...
84         (rank_one_type): ... this.
85
86 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
87
88         * gdbtypes.c (rank_one_type_parm_range): New function extracted
89         from...
90         (rank_one_type): ... this.
91
92 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
93
94         * gdbtypes.c (rank_one_type_parm_char): New function extracted
95         from...
96         (rank_one_type): ... this.
97
98 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
99
100         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
101         from...
102         (rank_one_type): ... this.
103
104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
105
106         * gdbtypes.c (rank_one_type_parm_int): New function extracted
107         from...
108         (rank_one_type): ... this.
109
110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
111
112         * gdbtypes.c (rank_one_type_parm_func): New function extracted
113         from...
114         (rank_one_type): ... this.
115
116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
117
118         * gdbtypes.c (rank_one_type_parm_array): New function extracted
119         from...
120         (rank_one_type): ... this.
121
122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
123
124         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
125         from...
126         (rank_one_type): ... this.
127
128 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
129
130         * inferior.c (initialize_inferiors): Ensure 'help set/show print
131         inferior-events' shows the example events.
132
133 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
134
135         Support styling on native MS-Windows console
136
137         PR/24315
138         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
139         on MS-Windows if $TERM is not defined.
140
141         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
142
143         * posix-hdep.c (gdb_console_fputs):
144         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
145         functions.
146         * ui-file.h (gdb_console_fputs): Add prototype.
147
148         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
149         back to fputs only if the former returns zero.
150
151 2019-03-07  Tom Tromey  <tom@tromey.com>
152
153         * symmisc.c (print_symbol_bcache_statistics): Update.
154         (print_objfile_statistics): Update.
155         * symfile.c (allocate_symtab): Update.
156         * stabsread.c: Don't include bcache.h.
157         * psymtab.h (struct psymbol_bcache): Don't declare.
158         (class psymtab_storage) <psymbol_cache>: Now a bcache.
159         (psymbol_bcache_init, psymbol_bcache_free)
160         (psymbol_bcache_get_bcache): Don't declare.
161         * psymtab.c (struct psymbol_bcache): Remove.
162         (psymtab_storage::psymtab_storage): Update.
163         (psymtab_storage::~psymtab_storage): Update.
164         (psymbol_bcache_init, psymbol_bcache_free)
165         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
166         (add_psymbol_to_bcache): Update.
167         (allocate_psymtab): Update.
168         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
169         macro_cache>: No longer pointers.
170         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
171         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
172         * macrotab.c (macro_bcache): Update.
173         * macroexp.c: Don't include bcache.h.
174         * gdbtypes.c (check_types_worklist): Update.
175         (types_deeply_equal): Remove TRY/CATCH.  Update.
176         * elfread.c (elf_symtab_read): Update.
177         * dwarf2read.c: Don't include bcache.h.
178         * buildsym.c (buildsym_compunit::get_macro_table): Update.
179         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
180         (print_bcache_statistics, bcache_memory_used): Don't declare.
181         (struct bcache): Move from bcache.c.  Add constructor, destructor,
182         methods.  Rename all data members.
183         * bcache.c (struct bcache): Move to bcache.h.
184         (bcache::expand_hash_table): Rename from expand_hash_table.
185         (bcache): Remove.
186         (bcache::insert): Rename from bcache_full.
187         (bcache::compare): Rename from bcache_compare.
188         (bcache_xmalloc): Remove.
189         (bcache::~bcache): Rename from bcache_xfree.
190         (bcache::print_statistics): Rename from print_bcache_statistics.
191         (bcache::memory_used): Rename from bcache_memory_used.
192
193 2019-03-07  Pedro Alves  <palves@redhat.com>
194
195         * infrun.c (normal_stop): Also check for
196         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
197
198 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
199
200         * f-lang.c (value_from_host_double): Moved to...
201         * value.c (value_from_host_double): ...here.
202         * value.h (value_from_host_double): Declare.
203         * guile/scm-math.c (vlscm_convert_typed_number): Use
204         value_from_host_double.
205         (vlscm_convert_number): Likewise.
206         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
207         * python/py-value.c (convert_value_from_python): Likewise.
208
209 2019-03-06  Tom Tromey  <tom@tromey.com>
210
211         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
212
213 2019-03-06  Tom Tromey  <tom@tromey.com>
214
215         * utils.h (free_current_contents): Don't declare.
216         * utils.c (free_current_contents): Remove.
217
218 2019-03-06  Tom Tromey  <tom@tromey.com>
219
220         * top.c (quit_force): Update.
221         * main.c (captured_command_loop): Update.
222         * common/new-op.c (operator new): Update.
223         * common/common-exceptions.c (struct catcher)
224         <save_cleanup_chain>: Remove member.
225         (exceptions_state_mc_init): Update.
226         (exception_try_scope_entry): Return nullptr.
227         (exception_try_scope_exit, exception_rethrow)
228         (throw_exception_sjlj, throw_exception_cxx): Update.
229         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
230         (all_cleanups, do_cleanups, discard_cleanups)
231         (discard_final_cleanups, save_cleanups, save_final_cleanups)
232         (restore_cleanups, restore_final_cleanups): Don't declare.
233         (do_final_cleanups): Remove parameter.
234         * common/cleanups.c (cleanup_chain, make_cleanup)
235         (make_cleanup_dtor, all_cleanups, do_cleanups)
236         (discard_my_cleanups, discard_cleanups)
237         (discard_final_cleanups, save_my_cleanups, save_cleanups)
238         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
239         (null_cleanup): Remove.
240         (do_final_cleanups): Remove parameter.
241
242 2019-03-06  Tom Tromey  <tom@tromey.com>
243
244         * remote.c (remote_target::remote_parse_stop_reply): Use
245         unique_xmalloc_ptr.
246
247 2019-03-06  Tom Tromey  <tom@tromey.com>
248
249         * stabsread.c (struct stabs_field_info): Rename from field_info.
250         <list, fnlist>: Add initializers.
251         <obstack>: New member.
252         (read_member_functions, read_struct_fields, read_baseclasses):
253         Allocate on obstack.  Don't use cleanups.
254         (read_one_struct_field, read_member_functions, read_struct_fields)
255         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
256         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
257         (read_struct_type): Update.
258
259 2019-03-06  Tom Tromey  <tom@tromey.com>
260
261         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
262         * common/filestuff.h (make_cleanup_close): Don't declare.
263         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
264         Remove.
265
266 2019-03-06  Tom Tromey  <tom@tromey.com>
267
268         * solib-aix.c: Use make_scope_exit.
269
270 2019-03-06  Tom Tromey  <tom@tromey.com>
271
272         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
273         Use make_scope_exit.
274
275 2019-03-06  Tom Tromey  <tom@tromey.com>
276
277         * solib-svr4.c (disable_probes_interface): Remove parameter.
278         (svr4_handle_solib_event): Use make_scope_exit.
279
280 2019-03-06  Tom Tromey  <tom@tromey.com>
281
282         * remote.c (struct stop_reply_deleter): Remove.
283         (stop_reply_up): Update.
284         (struct stop_reply): Derive from notif_event.  Don't typedef.
285         <regcache>: Now a std::vector.
286         (stop_reply_xfree): Remove.
287         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
288         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
289         (remote_target::discard_pending_stop_replies): Use delete.
290         (remote_target::remote_parse_stop_reply): Update.
291         (remote_target::process_stop_reply): Update.
292         * remote-notif.h (struct notif_event): Add virtual destructor.
293         Remove "dtr" member.
294         (struct notif_client) <alloc_event>: Return a unique_ptr.
295         (notif_event_xfree): Don't declare.
296         (notif_event_up): New typedef.
297         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
298         (notif_event_xfree, do_notif_event_xfree): Remove.
299         (remote_notif_state_xfree): Update.
300
301 2019-03-06  Tom Tromey  <tom@tromey.com>
302
303         * infrun.c (displaced_step_clear_cleanup): Now a
304         forward_scope_exit type.
305         (displaced_step_prepare_throw): Update.
306         (displaced_step_fixup): Update.
307
308 2019-03-06  Tom Tromey  <tom@tromey.com>
309
310         * inferior.h (class inferior): Update comment.
311         * gdbthread.h (class thread_info): Update comment.
312
313 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
314             Tom Tromey  <tom@tromey.com>
315
316         * stabsread.h (struct stab_section_list): Remove.
317         (coffstab_build_psymtabs): Update.
318         * dbxread.c (symbuf_sections): Now a std::vector.
319         (sect_idx): New global.
320         (fill_symbuf): Update.
321         (coffstab_build_psymtabs): Change type of stabsects parameter.
322         Update.
323         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
324         std::vector.
325         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
326         (coff_locate_sections): Update.
327         (coff_symfile_read): Remove cleanups.  Update.
328         (init_stringtab): Add storage parameter.
329         (free_stringtab, free_stringtab_cleanup): Remove.
330         (init_lineno): Add storage parameter.
331         (free_linetab, free_linetab_cleanup): Remove.
332
333 2019-03-06  Pedro Alves  <palves@redhat.com>
334
335         * linux-fork.c (fork_info::clobber_regs): Delete.
336         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
337         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
338         comment.  Adjust.
339         (scoped_switch_fork_info::scoped_switch_fork_info)
340         (checkpoint_command, linux_fork_context): Adjust
341         fork_save_infrun_state calls.
342
343 2019-03-06  Pedro Alves  <palves@redhat.com>
344
345         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
346         (inf_has_multiple_threads): Return 'bool' and rewrite using
347         inferior_info::threads().
348
349 2019-03-06  Pedro Alves  <palves@redhat.com>
350
351         * linux-fork.c: Include <list>.
352         (fork_list): Now a std::list instance.
353         (fork_info): Add ctor, dtor, and in-class initialize all fields.
354         (forks_exist_p, find_last_fork): Adjust.
355         (new_fork): Delete.
356         (one_fork_p): New.
357         (add_fork): Adjust.
358         (free_fork): Delete, folded into fork_info::~fork_info().
359         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
360         Adjust.
361         (init_fork_list): Delete.
362         (linux_fork_killall, linux_fork_mourn_inferior)
363         (linux_fork_detach, info_checkpoints_command): Adjust.
364         (_initialize_linux_fork): No longer call init_fork_list.
365
366 2019-03-06  Pedro Alves  <palves@redhat.com>
367
368         * linux-fork.c (new_fork): New, split out of ...
369         (add_fork): ... this.  Return void.  Move "first fork" special
370         case from here, to ...
371         (checkpoint_command): ... here.
372         * linux-linux.h (add_fork): Return void.
373
374 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
375
376         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
377
378 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
379             Chris January  <chris.january@arm.com>
380             David Lecomber  <david.lecomber@arm.com>
381
382         * f-exp.y: New token, UNOP_INTRINSIC.
383         (exp): New pattern using UNOP_INTRINSIC token.
384         (f77_keywords): Add 'abs' keyword.
385         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
386         (value_from_host_double): New function.
387         (evaluate_subexp_f): Support UNOP_ABS.
388
389 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
390
391         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
392         types.
393
394 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
395
396         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
397         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
398         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
399
400 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
401
402         * f-exp.y (convert_to_kind_type): Handle more type kinds.
403
404 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
405             Chris January  <chris.january@arm.com>
406
407         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
408         * f-exp.y: Define 'KIND' token.
409         (exp): New pattern for KIND expressions.
410         (ptype): Handle types with a kind extension.
411         (direct_abs_decl): Extend to spot kind extensions.
412         (f77_keywords): Add 'kind' to the list.
413         (push_kind_type): New function.
414         (convert_to_kind_type): New function.
415         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
416         * parse.c (operator_length_standard): Likewise.
417         * parser-defs.h (enum type_pieces): Add tp_kind.
418         * std-operator.def: Add UNOP_KIND.
419
420 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
421
422         * f-exp.y (f_parse): Set yydebug.
423
424 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
425
426         * f-lang.c (evaluate_subexp_f): New function.
427         (exp_descriptor_f): New global.
428         (f_language_defn): Use exp_descriptor_f instead of
429         exp_descriptor_standard.
430
431 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
432
433         * f-exp.y (struct token): Add comments.
434         (dot_ops): Remove uppercase versions and the end marker.
435         (f77_keywords): Likewise.
436         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
437         entries in the dot_ops array are case insensitive, and use
438         strncasecmp to compare strings.  Also some whitespace cleanup in
439         this area.  Similar for the f77_keywords array, except entries in
440         this list might be case sensitive.
441
442 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
443
444         * f-exp.y (struct f77_boolean_val): Add comments.
445         (boolean_values): Remove uppercase versions, and end marker.
446         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
447         and use strncasecmp to achieve case insensitivity.  Additionally,
448         perform whitespace cleanup around this code.
449
450 2019-03-06  Tom Tromey  <tromey@adacore.com>
451
452         * remote-sim.c (gdbsim_target_open): Use result of
453         gdb_argv::release.
454
455 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
456         Dirk Schubert  <dirk.schubert@arm.com>
457         Chris January  <chris.january@arm.com>
458
459         * eval.c (evaluate_subexp_standard): Call Fortran argument
460         wrapping logic.
461         * f-lang.c (struct value): A value which can be passed into a
462         Fortran function call.
463         (fortran_argument_convert): Wrap Fortran arguments in a pointer
464         where appropriate.
465         (struct type): Value ready for a Fortran function call.
466         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
467         is needed.
468         * f-lang.h (fortran_argument_convert): Declaration.
469         (fortran_preserve_arg_pointer): Declaration.
470         * infcall.c (value_arg_coerce): Call Fortran argument logic.
471
472 2019-03-05  Tom Tromey  <tromey@adacore.com>
473
474         * python/py-prettyprint.c (print_string_repr): Remove #if.
475         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
476
477 2019-03-05  Tom Tromey  <tromey@adacore.com>
478
479         * target.c (the_dummy_target): Move later.  Change type to
480         "dummy_target".
481         (initialize_targets): Don't initialize the_dummy_target.
482
483 2019-03-05  Tom Tromey  <tromey@adacore.com>
484
485         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
486         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
487
488 2019-03-05  Tom Tromey  <tromey@adacore.com>
489
490         * windows-nat.c (windows_nat_target::attach)
491         (windows_nat_target::detach): Don't call gdb_flush.
492         * valprint.c (generic_val_print, val_print, val_print_string):
493         Don't call gdb_flush.
494         * utils.c (defaulted_query): Don't call gdb_flush.
495         * typeprint.c (print_type_scalar): Don't call gdb_flush.
496         * target.c (target_announce_detach): Don't call gdb_flush.
497         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
498         * remote.c (extended_remote_target::attach): Don't call
499         gdb_flush.
500         * procfs.c (procfs_target::detach): Don't call gdb_flush.
501         * printcmd.c (do_examine): Don't call gdb_flush.
502         (info_display_command): Don't call gdb_flush.
503         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
504         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
505         * memattr.c (info_mem_command): Don't call gdb_flush.
506         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
507         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
508         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
509         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
510         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
511         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
512         (gnu_nat_target::detach): Don't call gdb_flush.
513         * f-valprint.c (f_val_print): Don't call gdb_flush.
514         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
515         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
516         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
517         gdb_flush.
518         * c-valprint.c (c_val_print): Don't call gdb_flush.
519         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
520
521 2019-03-05  Tom Tromey  <tromey@adacore.com>
522
523         * varobj.c (update_dynamic_varobj_children): Update.
524         (install_default_visualizer): Use reset, not release.
525         * value.c (set_internalvar): Update.
526         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
527         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
528         ATTRIBUTE_UNUSED_RESULT.
529
530 2019-03-05  Tom Tromey  <tromey@adacore.com>
531
532         * remote.c (class scoped_remote_fd) <release>: Add
533         ATTRIBUTE_UNUSED_RESULT.
534
535 2019-03-05  Tom Tromey  <tromey@adacore.com>
536
537         * macroexp.c (struct macro_buffer) <release>: Add
538         ATTRIBUTE_UNUSED_RESULT.
539
540 2019-03-05  Tom Tromey  <tromey@adacore.com>
541
542         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
543         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
544         ATTRIBUTE_UNUSED_RESULT.
545
546 2019-03-05  Tom Tromey  <tromey@adacore.com>
547
548         * common/scoped_fd.h (class scoped_fd) <release>: Add
549         ATTRIBUTE_UNUSED_RESULT.
550
551 2019-03-05  Tom Tromey  <tromey@adacore.com>
552
553         * parser-defs.h (struct parser_state) <release>: Add
554         ATTRIBUTE_UNUSED_RESULT.
555
556 2019-03-05  Tom Tromey  <tromey@adacore.com>
557
558         * utils.h (class gdb_argv) <release>: Add
559         ATTRIBUTE_UNUSED_RESULT.
560         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
561
562 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
563
564         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
565         for-loop range, to avoid compiler warnings.
566
567         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
568         avoid compiler warnings about unused variables.
569
570         * NEWS: Mention end of support for native debugging on MS-Windows
571         before XP.
572
573         PR gdb/24292
574         * common/netstuff.c:
575         * gdbserver/gdbreplay.c
576         * gdbserver/remote-utils.c:
577         * ser-tcp.c:
578         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
579         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
580         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
581         'getaddrinfo' and 'freeaddrinfo' were not available before
582         Windows XP, and mingw.org's MinGW headers by default define
583         _WIN32_WINNT to 0x500.
584
585 2019-03-01  Gary Benson <gbenson@redhat.com>
586
587         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
588
589 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
590             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
591
592         PR gdb/8527
593         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
594         set_sigint_trap, clear_sigint_trap.
595
596 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
597
598         * target.c (target_detach): Clear the regcache and the
599         frame cache.
600
601 2019-02-27  Pedro Alves  <palves@redhat.com>
602
603         * utils.c (set_screen_size): When we cap the height/width sizes,
604         tweak the corresponding command variable to show "unlimited":
605
606 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
607             Pedro Alves  <palves@redhat.com>
608
609         * utils.c (set_screen_size): Reduce "infinite" rows and columns
610         before calling rl_set_screen_size.
611
612 2019-02-27  Tom Tromey  <tromey@adacore.com>
613
614         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
615         define.
616         * python/py-value.c: Remove Python 2.4 workaround.
617         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
618         workaround.
619         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
620         Python 2.4 workaround.
621         * python/python-internal.h: Remove Python 2.4 comment.
622         (Py_ssize_t): Don't define.
623         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
624         (gdb_Py_DECREF): Remove Python 2.4 workaround.
625         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
626         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
627         * python/python.c (do_start_initialization): Remove Python 2.4
628         workaround.
629         * python/py-prettyprint.c (class dummy_python_frame): Remove.
630         (print_children): Remove Python 2.4 workaround.
631         * python/py-inferior.c (buffer_procs): Remove Python 2.4
632         workaround.
633         (CHARBUFFERPROC_NAME): Remove.
634         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
635         Python 2.4 workaround.
636
637 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
638
639         * NEWS: Note minimum Python version.
640
641 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
642
643         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
644         code from these functions.  Remove corresponding ifdefs.  Use
645         Py_buffer_up instead of explicit calls to PyBuffer_Release.
646         Remove gotos and target of gotos.
647         (infpy_search_memory): Likewise.
648
649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
650
651         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
652         (hppa_gdbarch_init): Don't register deleted functions with
653         gdbarch.
654
655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
656
657         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
658         (h8300_unwind_sp): Delete.
659         (h8300_dummy_id): Delete.
660         (h8300_gdbarch_init): Don't register deleted functions with
661         gdbarch.
662
663 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
664
665         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
666         (ft32_unwind_pc): Delete.
667         (ft32_unwind_sp): Delete.
668         (ft32_gdbarch_init): Don't register deleted functions with
669         gdbarch.
670
671 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
672
673         * gdb/frv-tdep.c (frv_dummy_id): Delete.
674         (frv_unwind_pc): Delete.
675         (frv_unwind_sp): Delete.
676         (frv_gdbarch_init): Don't register deleted functions with
677         gdbarch.
678
679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
680
681         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
682         (riscv_unwind_pc): Delete.
683         (riscv_unwind_sp): Delete.
684         (riscv_gdbarch_init): Don't register deleted functions with
685         gdbarch.
686
687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
688
689         * gdb/csky-tdep.c (csky_dummy_id): Delete.
690         (csky_unwind_pc): Delete.
691         (csky_unwind_sp): Delete.
692         (csky_gdbarch_init): Don't register deleted functions with
693         gdbarch.
694
695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
696
697         * gdb/cris-tdep.c (cris_dummy_id): Delete.
698         (cris_unwind_pc): Delete.
699         (cris_unwind_sp): Delete.
700         (cris_gdbarch_init): Don't register deleted functions with
701         gdbarch.
702
703 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
704
705         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
706         (bfin_unwind_pc): Delete.
707         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
708
709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
710
711         * gdb/arm-tdep.c (arm_dummy_id): Delete.
712         (arm_unwind_pc): Delete.
713         (arm_unwind_sp): Delete.
714         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
715
716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
717
718         * gdb/arc-tdep.c (arc_dummy_id): Delete.
719         (arc_unwind_pc): Delete.
720         (arc_unwind_sp): Delete.
721         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
722
723 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
724
725         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
726         (alpha_unwind_pc): Delete.
727         (alpha_gdbarch_init): Don't register deleted functions with
728         gdbarch.
729
730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
731
732         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
733         (aarch64_unwind_pc): Delete.
734         (aarch64_unwind_sp): Delete.
735         (aarch64_gdbarch_init): Don't register deleted functions with
736         gdbarch.
737
738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
739
740         * gdbtypes.c (type_align): Don't consider static members when
741         computing structure alignment.
742
743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
744
745         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
746         return 0 for other types.
747         * arch-utils.c (default_type_align): Always return 0.
748         * gdbarch.h: Regenerate.
749         * gdbarch.sh (type_align): Extend comment.
750         * gdbtypes.c (type_align): Add additional comments, always call
751         gdbarch_type_align before applying the default rules.
752         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
753         generic code will then apply a suitable default.
754         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
755         types, return 0 for other types.
756
757 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
758
759         * NEWS: Create a new section for the next release branch.
760         Rename the section of the current branch, now that it has
761         been cut.
762
763 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
764
765         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
766         * version.in: Bump version to 8.3.50.DATE-git.
767
768 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
769
770         * aix-thread.c (ptid_cmp): Remove unused variable.
771         (get_signaled_thread): Likewise.
772         (store_regs_user_thread): Likewise.
773         (store_regs_kernel_thread): Likewise.
774         (fetch_regs_kernel_thread): Remove shadowed variable.
775
776 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
777
778         * features/riscv/32bit-cpu.xml: Add register numbers.
779         * features/riscv/32bit-fpu.c: Regenerate.
780         * features/riscv/32bit-fpu.xml: Add register numbers.
781         * features/riscv/64bit-cpu.xml: Add register numbers.
782         * features/riscv/64bit-fpu.c: Regenerate.
783         * features/riscv/64bit-fpu.xml: Add register numbers.
784
785 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
786
787         * NEWS: Mention two argument form of gdb.Value constructor.
788         * python/py-value.c (convert_buffer_and_type_to_value): New
789         function.
790         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
791         Add support for handling an optional second argument.  Call
792         convert_buffer_and_type_to_value as appropriate.
793         * python/python-internal.h (Py_buffer_deleter): New struct.
794         (Py_buffer_up): New typedef.
795
796 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
797
798         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
799         instead of releasing ownership.
800
801 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
802
803         * dwarf2read.c (open_and_init_dwp_file): Call
804         elf_numsections instead of bfd_count_sections to initialize
805         dwp_file->num_sections.
806
807 2019-02-25  Tom Tromey  <tromey@adacore.com>
808
809         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
810
811 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
812
813         * gcore.in: Add '--readnever' option when invoking GDB.
814
815 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
816
817         * MAINTAINERS: Update my email address.
818
819 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
820
821         * build-id.c (build_id_to_debug_bfd_1): New function.
822         (build_id_to_debug_bfd): Look for separate debug file in
823         sysroot.
824
825 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
826
827         * gdbarch.sh: Update the copyright year range that is placed into
828         generated files.
829
830 2019-02-22  Keith Seitz  <keiths@redhat.com>
831
832         PR symtab/23853
833         * linespec.c (create_sals_line_offset): Search for the default
834         symtab's filename instead of its fullname.
835
836 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
837
838         * NEWS: Update style defaults.
839
840 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
841
842         * main.c (captured_main_1): Disable styling in batch mode.
843
844 2019-02-20  Tom Tromey  <tom@tromey.com>
845
846         * symtab.c (symtab_symbol_info): Fix typos.
847
848 2019-02-20  Tom Tromey  <tromey@adacore.com>
849
850         * findcmd.c (_initialize_mem_search): Use upper case for
851         metasyntactic variables.
852
853 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
854
855         * aarch64-tdep.c (aarch64_add_reggroups): New function.
856         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
857
858 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
859
860         * top.h (source_file_name): Change to std::string.
861         * top.c (source_file_name): Likewise.
862         (command_line_input): Adjust.
863         * cli/cli-script.c (script_from_file): Adjust.
864
865 2019-02-19  Tom Tromey  <tromey@adacore.com>
866
867         * ravenscar-thread.c
868         (ravenscar_thread_target::update_thread_list): Don't call
869         ada_build_task_list.
870         * ada-lang.h (ada_build_task_list): Don't declare.
871         * ada-tasks.c (struct ada_tasks_inferior_data)
872         <task_list_valid_p>: Now bool.
873         (read_known_tasks, ada_task_list_changed)
874         (ada_tasks_invalidate_inferior_data): Update.
875         (read_known_tasks_array): Return bool.
876         (read_known_tasks_list): Likewise.
877         (read_known_tasks): Return void.
878         (ada_build_task_list): Now static.
879
880 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
881
882         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
883         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
884
885 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
886
887         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
888         variant for ada_tasks_pspace_data_handle and
889         ada_tasks_inferior_data_handle.
890         (ada_tasks_pspace_data_cleanup): New function.
891         (ada_tasks_inferior_data_cleanup): New function.
892
893 2019-02-17  Tom Tromey  <tom@tromey.com>
894
895         * macrotab.h (macro_source_fullname): Return a std::string.
896         * macrotab.c (macro_include, check_for_redefinition)
897         (macro_undef, macro_lookup_definition, foreach_macro)
898         (foreach_macro_in_scope): Update.
899         (macro_source_fullname): Return a std::string.
900         * macrocmd.c (show_pp_source_pos): Update.
901
902 2019-02-17  Tom Tromey  <tom@tromey.com>
903
904         * macrocmd.c (show_pp_source_pos): Style the file names.
905
906 2019-02-17  Tom Tromey  <tom@tromey.com>
907
908         PR tui/24197:
909         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
910
911 2019-02-17  Tom Tromey  <tom@tromey.com>
912
913         * ada-lang.c (user_select_syms): Use filtered printing.
914         * utils.c (wrap_style): New global.
915         (desired_style): Remove.
916         (emit_style_escape): Add stream parameter.
917         (set_output_style, reset_terminal_style, prompt_for_continue):
918         Update.
919         (flush_wrap_buffer): Only flush gdb_stdout.
920         (wrap_here): Set wrap_style.
921         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
922         treat escape sequences as a character.  Change when wrap buffer is
923         flushed.
924         (fputs_styled): Do not set the output style when the default is
925         requested.
926         * ui-style.h (struct ui_file_style) <is_default>: New method.
927         * source.c (print_source_lines_base): Emit escape sequences in one
928         piece.
929
930 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
931
932         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
933         integers and enumeration types.
934
935 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
936
937         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
938         instead of lookup_symbol_in_language
939         (do_exact_match): New function.
940         (ada_get_symbol_name_matcher): Return do_exact_match when
941         doing a verbatim match.
942
943 2019-02-15  Tom Tromey  <tromey@adacore.com>
944
945         * ravenscar-thread.c (ravenscar_thread_target::resume)
946         (ravenscar_thread_target::wait): Special case wildcard requests.
947
948 2019-02-15  Tom Tromey  <tromey@adacore.com>
949
950         * ravenscar-thread.c (base_ptid): Remove.
951         (struct ravenscar_thread_target) <close>: New method.
952         <m_base_ptid>: New member.
953         <update_inferior_ptid, active_task, task_is_currently_active,
954         runtime_initialized>: Declare methods.
955         <ravenscar_thread_target>: Add constructor.
956         (ravenscar_thread_target::task_is_currently_active)
957         (ravenscar_thread_target::update_inferior_ptid)
958         (ravenscar_runtime_initialized): Rename.  Now methods.
959         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
960         (ravenscar_thread_target::update_thread_list): Update.
961         (ravenscar_thread_target::active_task): Now method.
962         (ravenscar_thread_target::store_registers)
963         (ravenscar_thread_target::prepare_to_store)
964         (ravenscar_thread_target::prepare_to_store)
965         (ravenscar_thread_target::mourn_inferior): Update.
966         (ravenscar_inferior_created): Use "new" to create target.
967         (ravenscar_thread_target::get_ada_task_ptid): Update.
968         (_initialize_ravenscar): Don't initialize base_ptid.
969         (ravenscar_ops): Remove global.
970
971 2019-02-15  Tom Tromey  <tromey@adacore.com>
972
973         * target.h (push_target): Declare new overload.
974         * target.c (push_target): New overload, taking an rvalue reference.
975         * remote.c (remote_target::open_1): Use push_target overload.
976         * corelow.c (core_target_open): Use push_target overload.
977
978 2019-02-15  Tom Tromey  <tromey@adacore.com>
979
980         * ravenscar-thread.c (is_ravenscar_task)
981         (ravenscar_task_is_currently_active): Return bool.
982         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
983         (_initialize_ravenscar): Remove "(void)".
984         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
985         Return bool.
986
987 2019-02-15  Tom Tromey  <tromey@adacore.com>
988
989         * ravenscar-thread.c (ravenscar_runtime_initializer)
990         (has_ravenscar_runtime, get_running_thread_id)
991         (ravenscar_thread_target::resume): Fix indentation.
992
993 2019-02-15  Tom Tromey  <tromey@adacore.com>
994
995         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
996         from ravenscar_arch_ops.
997         (sparc_ravenscar_ops::fetch_registers)
998         (sparc_ravenscar_ops::store_registers): Now methods.
999         (sparc_ravenscar_prepare_to_store): Remove.
1000         (sparc_ravenscar_ops): Redefine.
1001         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1002         methods and destructor.  Remove members.
1003         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1004         (ravenscar_thread_target::store_registers)
1005         (ravenscar_thread_target::prepare_to_store): Update.
1006         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1007         Remove.
1008         (struct ppc_ravenscar_powerpc_ops): Derive from
1009         ravenscar_arch_ops.
1010         (ppc_ravenscar_powerpc_ops::fetch_registers)
1011         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1012         (ppc_ravenscar_powerpc_ops): Redefine.
1013         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1014         (ppc_ravenscar_e500_ops::fetch_registers)
1015         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1016         (ppc_ravenscar_e500_ops): Redefine.
1017         * aarch64-ravenscar-thread.c
1018         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1019         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1020         (aarch64_ravenscar_fetch_registers)
1021         (aarch64_ravenscar_store_registers): Now methods.
1022         (aarch64_ravenscar_ops): Redefine.
1023
1024 2019-02-15  Tom Tromey  <tromey@adacore.com>
1025
1026         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1027         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1028         (ravenscar_thread_target::stopped_by_watchpoint)
1029         (ravenscar_thread_target::stopped_data_address)
1030         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1031
1032 2019-02-15  Tom Tromey  <tromey@adacore.com>
1033
1034         * ravenscar-thread.c: Fix some typos.
1035
1036 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1037             Tom Tromey  <tromey@adacore.com>
1038
1039         * ada-lang.c (ada_exception_sal): Change addr_string to a
1040         std::string.
1041         (create_ada_exception_catchpoint): Update.
1042
1043 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1044             Tom Tromey  <tromey@adacore.com>
1045
1046         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1047         (bp_location_ops): Remove.
1048         (base_breakpoint_allocate_location): Update.
1049         (free_bp_location): Update.
1050         * ada-lang.c (class ada_catchpoint_location)
1051         <ada_catchpoint_location>: Remove ops parameter.
1052         (ada_catchpoint_location_dtor): Remove.
1053         (ada_catchpoint_location_ops): Remove.
1054         (allocate_location_exception): Update.
1055         * breakpoint.h (struct bp_location_ops): Remove.
1056         (class bp_location) <bp_location>: Remove bp_location_ops
1057         parameter.
1058         <~bp_location>: Add destructor.
1059         <ops>: Remove.
1060
1061 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1062             Pedro Alves  <palves@redhat.com>
1063
1064         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1065         'PATH_MAX'.
1066
1067 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1068             Samuel Thibault  <samuel.thibault@gnu.org>
1069             Thomas Schwinge  <thomas@codesourcery.com>
1070
1071         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1072         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1073
1074 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1075
1076         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1077         (check_empty): Use "const char *".
1078
1079         * gnu-nat.c (gnu_nat_target::detach): Instead of
1080         'detach_inferior (pid)' call
1081         'detach_inferior (find_inferior_pid (pid))'.
1082
1083         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1084         'nat/fork-inferior.o'.
1085         * gnu-nat.c: #include "nat/fork-inferior.h".
1086
1087         * gnu-nat.c (gnu_nat_target::detach): Instead of
1088         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1089         * gnu-nat.h: #include "inf-child.h".
1090         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1091         'i386_gnu_nat_target::fetch_registers'.
1092         (gnu_store_registers): Rename/move to
1093         'i386_gnu_nat_target::store_registers'.
1094
1095         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1096         * gnu-nat.h (mach_thread_info): New function.
1097         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1098
1099         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1100
1101 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1102
1103         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1104
1105 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1106
1107         * windows-nat.c (windows_add_thread): Add new parameter
1108         "main_thread_p" with default value set to false.  Update
1109         function documentation as well as all callers.
1110         (windows_delete_thread): Likewise.
1111         (fake_create_process): Update call to windows_add_thread.
1112         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1113         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1114         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1115         call to windows_delete_thread.
1116
1117 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1118
1119         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1120
1121 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1122
1123         * symfile.c (find_separate_debug_file): Use canonical path of
1124         sysroot with child_path instead of gdb_sysroot if it is valid.
1125
1126 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1127
1128         * symfile.c (find_separate_debug_file): Use child_path to
1129         determine if an object file is under a sysroot.
1130
1131 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1132
1133         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1134         unittests/child-path-selftests.c.
1135         * common/pathstuff.c (child_path): New function.
1136         * common/pathstuff.h (child_path): New prototype.
1137         * unittests/child-path-selftests.c: New file.
1138
1139 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1140
1141         * symfile.c (find_separate_debug_file): Look for separate debug
1142         files in debug directories under the sysroot.
1143
1144 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1145
1146         * symtab.h (struct minimal_symbol data_p): New const method.
1147         (struct minimal_symbol text_p): Likewise.
1148         * symtab.c (output_source_filename): Use file name style
1149         to print file name.
1150         (print_symbol_info): Likewise.
1151         (print_msymbol_info): Use address style to print addresses.
1152         Use function name style to print executable text symbols.
1153         (expand_symtab_containing_pc): Use data_p.
1154         (find_pc_sect_compunit_symtab): Likewise.
1155
1156 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1157
1158         * breakpoint.c (describe_other_breakpoints): Use address style
1159         to print addresses.
1160         (say_where): Likewise.
1161
1162 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1163
1164         * ada-typeprint.c (print_func_type): Print function name
1165         style to print function name.
1166         * c-typeprint.c (c_print_type_1): Likewise.
1167
1168 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1169
1170         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1171         for execve.
1172
1173 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1174
1175         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1176         type_stack.
1177
1178 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1179
1180         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1181         TYPE_CODE_REF types.
1182
1183 2019-02-08  Jim Wilson  <jimw@sifive.com>
1184
1185         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1186         (riscv_linux_fregset): New.
1187         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1188
1189 2019-02-07  Tom Tromey  <tom@tromey.com>
1190
1191         * thread.c (thread_cancel_execution_command): Update.
1192         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1193         methods.
1194         (struct thread_fsm_ops): Remove.
1195         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1196         (thread_fsm_should_stop, thread_fsm_return_value)
1197         (thread_fsm_set_finished, thread_fsm_finished_p)
1198         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1199         Don't declare.
1200         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1201         * infrun.c (clear_proceed_status_thread)
1202         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1203         (print_stop_event): Update.
1204         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1205         Add constructor.
1206         (step_command_fsm_ops): Remove.
1207         (new_step_command_fsm): Remove.
1208         (step_1): Update.
1209         (step_command_fsm::should_stop): Rename from
1210         step_command_fsm_should_stop.
1211         (step_command_fsm::clean_up): Rename from
1212         step_command_fsm_clean_up.
1213         (step_command_fsm::do_async_reply_reason): Rename from
1214         step_command_fsm_async_reply_reason.
1215         (struct until_next_fsm): Inherit from thread_fsm.  Add
1216         constructor.
1217         (until_next_fsm_ops): Remove.
1218         (new_until_next_fsm): Remove.
1219         (until_next_fsm::should_stop): Rename from
1220         until_next_fsm_should_stop.
1221         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1222         (until_next_fsm::do_async_reply_reason): Rename from
1223         until_next_fsm_async_reply_reason.
1224         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1225         constructor.  Change type of breakpoint.
1226         (finish_command_fsm_ops): Remove.
1227         (new_finish_command_fsm): Remove.
1228         (finish_command_fsm::should_stop): Rename from
1229         finish_command_fsm_should_stop.
1230         (finish_command_fsm::clean_up): Rename from
1231         finish_command_fsm_clean_up.
1232         (finish_command_fsm::return_value): Rename from
1233         finish_command_fsm_return_value.
1234         (finish_command_fsm::do_async_reply_reason): Rename from
1235         finish_command_fsm_async_reply_reason.
1236         (finish_command): Update.
1237         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1238         Add constructor.
1239         (call_thread_fsm_ops): Remove.
1240         (call_thread_fsm::call_thread_fsm): Rename from
1241         new_call_thread_fsm.
1242         (call_thread_fsm::should_stop): Rename from
1243         call_thread_fsm_should_stop.
1244         (call_thread_fsm::should_notify_stop): Rename from
1245         call_thread_fsm_should_notify_stop.
1246         (run_inferior_call, call_function_by_hand_dummy): Update.
1247         * cli/cli-interp.c (should_print_stop_to_console): Update.
1248         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1249         Add constructor.  Change type of location_breakpoint,
1250         caller_breakpoint.
1251         (until_break_fsm_ops): Remove.
1252         (new_until_break_fsm): Remove.
1253         (until_break_fsm::should_stop): Rename from
1254         until_break_fsm_should_stop.
1255         (until_break_fsm::clean_up): Rename from
1256         until_break_fsm_clean_up.
1257         (until_break_fsm::do_async_reply_reason): Rename from
1258         until_break_fsm_async_reply_reason.
1259         (until_break_command): Update.
1260         * thread-fsm.c: Remove.
1261         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1262
1263 2019-02-07  Tom Tromey  <tom@tromey.com>
1264
1265         * yy-remap.h: Add include guard.
1266         * xtensa-tdep.h: Add include guard.
1267         * xcoffread.h: Rename include guard.
1268         * varobj-iter.h: Add include guard.
1269         * tui/tui.h: Rename include guard.
1270         * tui/tui-winsource.h: Rename include guard.
1271         * tui/tui-wingeneral.h: Rename include guard.
1272         * tui/tui-windata.h: Rename include guard.
1273         * tui/tui-win.h: Rename include guard.
1274         * tui/tui-stack.h: Rename include guard.
1275         * tui/tui-source.h: Rename include guard.
1276         * tui/tui-regs.h: Rename include guard.
1277         * tui/tui-out.h: Rename include guard.
1278         * tui/tui-layout.h: Rename include guard.
1279         * tui/tui-io.h: Rename include guard.
1280         * tui/tui-hooks.h: Rename include guard.
1281         * tui/tui-file.h: Rename include guard.
1282         * tui/tui-disasm.h: Rename include guard.
1283         * tui/tui-data.h: Rename include guard.
1284         * tui/tui-command.h: Rename include guard.
1285         * tic6x-tdep.h: Add include guard.
1286         * target/waitstatus.h: Rename include guard.
1287         * target/wait.h: Rename include guard.
1288         * target/target.h: Rename include guard.
1289         * target/resume.h: Rename include guard.
1290         * target-float.h: Rename include guard.
1291         * stabsread.h: Add include guard.
1292         * rs6000-tdep.h: Add include guard.
1293         * riscv-fbsd-tdep.h: Add include guard.
1294         * regformats/regdef.h: Rename include guard.
1295         * record.h: Rename include guard.
1296         * python/python.h: Rename include guard.
1297         * python/python-internal.h: Rename include guard.
1298         * python/py-stopevent.h: Rename include guard.
1299         * python/py-ref.h: Rename include guard.
1300         * python/py-record.h: Rename include guard.
1301         * python/py-record-full.h: Rename include guard.
1302         * python/py-record-btrace.h: Rename include guard.
1303         * python/py-instruction.h: Rename include guard.
1304         * python/py-events.h: Rename include guard.
1305         * python/py-event.h: Rename include guard.
1306         * procfs.h: Add include guard.
1307         * proc-utils.h: Add include guard.
1308         * p-lang.h: Add include guard.
1309         * or1k-tdep.h: Rename include guard.
1310         * observable.h: Rename include guard.
1311         * nto-tdep.h: Rename include guard.
1312         * nat/x86-linux.h: Rename include guard.
1313         * nat/x86-linux-dregs.h: Rename include guard.
1314         * nat/x86-gcc-cpuid.h: Add include guard.
1315         * nat/x86-dregs.h: Rename include guard.
1316         * nat/x86-cpuid.h: Rename include guard.
1317         * nat/ppc-linux.h: Rename include guard.
1318         * nat/mips-linux-watch.h: Rename include guard.
1319         * nat/linux-waitpid.h: Rename include guard.
1320         * nat/linux-ptrace.h: Rename include guard.
1321         * nat/linux-procfs.h: Rename include guard.
1322         * nat/linux-osdata.h: Rename include guard.
1323         * nat/linux-nat.h: Rename include guard.
1324         * nat/linux-namespaces.h: Rename include guard.
1325         * nat/linux-btrace.h: Rename include guard.
1326         * nat/glibc_thread_db.h: Rename include guard.
1327         * nat/gdb_thread_db.h: Rename include guard.
1328         * nat/gdb_ptrace.h: Rename include guard.
1329         * nat/fork-inferior.h: Rename include guard.
1330         * nat/amd64-linux-siginfo.h: Rename include guard.
1331         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1332         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1333         * nat/aarch64-linux.h: Rename include guard.
1334         * nat/aarch64-linux-hw-point.h: Rename include guard.
1335         * mn10300-tdep.h: Add include guard.
1336         * mips-linux-tdep.h: Add include guard.
1337         * mi/mi-parse.h: Rename include guard.
1338         * mi/mi-out.h: Rename include guard.
1339         * mi/mi-main.h: Rename include guard.
1340         * mi/mi-interp.h: Rename include guard.
1341         * mi/mi-getopt.h: Rename include guard.
1342         * mi/mi-console.h: Rename include guard.
1343         * mi/mi-common.h: Rename include guard.
1344         * mi/mi-cmds.h: Rename include guard.
1345         * mi/mi-cmd-break.h: Rename include guard.
1346         * m2-lang.h: Add include guard.
1347         * location.h: Rename include guard.
1348         * linux-record.h: Rename include guard.
1349         * linux-nat.h: Add include guard.
1350         * linux-fork.h: Add include guard.
1351         * i386-darwin-tdep.h: Rename include guard.
1352         * hppa-linux-offsets.h: Add include guard.
1353         * guile/guile.h: Rename include guard.
1354         * guile/guile-internal.h: Rename include guard.
1355         * gnu-nat.h: Rename include guard.
1356         * gdb-stabs.h: Rename include guard.
1357         * frv-tdep.h: Add include guard.
1358         * f-lang.h: Add include guard.
1359         * event-loop.h: Add include guard.
1360         * darwin-nat.h: Rename include guard.
1361         * cp-abi.h: Rename include guard.
1362         * config/sparc/nm-sol2.h: Rename include guard.
1363         * config/nm-nto.h: Rename include guard.
1364         * config/nm-linux.h: Add include guard.
1365         * config/i386/nm-i386gnu.h: Rename include guard.
1366         * config/djgpp/nl_types.h: Rename include guard.
1367         * config/djgpp/langinfo.h: Rename include guard.
1368         * compile/gcc-cp-plugin.h: Add include guard.
1369         * compile/gcc-c-plugin.h: Add include guard.
1370         * compile/compile.h: Rename include guard.
1371         * compile/compile-object-run.h: Rename include guard.
1372         * compile/compile-object-load.h: Rename include guard.
1373         * compile/compile-internal.h: Rename include guard.
1374         * compile/compile-cplus.h: Rename include guard.
1375         * compile/compile-c.h: Rename include guard.
1376         * common/xml-utils.h: Rename include guard.
1377         * common/x86-xstate.h: Rename include guard.
1378         * common/version.h: Rename include guard.
1379         * common/vec.h: Rename include guard.
1380         * common/tdesc.h: Rename include guard.
1381         * common/selftest.h: Rename include guard.
1382         * common/scoped_restore.h: Rename include guard.
1383         * common/scoped_mmap.h: Rename include guard.
1384         * common/scoped_fd.h: Rename include guard.
1385         * common/safe-iterator.h: Rename include guard.
1386         * common/run-time-clock.h: Rename include guard.
1387         * common/refcounted-object.h: Rename include guard.
1388         * common/queue.h: Rename include guard.
1389         * common/ptid.h: Rename include guard.
1390         * common/print-utils.h: Rename include guard.
1391         * common/preprocessor.h: Rename include guard.
1392         * common/pathstuff.h: Rename include guard.
1393         * common/observable.h: Rename include guard.
1394         * common/netstuff.h: Rename include guard.
1395         * common/job-control.h: Rename include guard.
1396         * common/host-defs.h: Rename include guard.
1397         * common/gdb_wait.h: Rename include guard.
1398         * common/gdb_vecs.h: Rename include guard.
1399         * common/gdb_unlinker.h: Rename include guard.
1400         * common/gdb_unique_ptr.h: Rename include guard.
1401         * common/gdb_tilde_expand.h: Rename include guard.
1402         * common/gdb_sys_time.h: Rename include guard.
1403         * common/gdb_string_view.h: Rename include guard.
1404         * common/gdb_splay_tree.h: Rename include guard.
1405         * common/gdb_setjmp.h: Rename include guard.
1406         * common/gdb_ref_ptr.h: Rename include guard.
1407         * common/gdb_optional.h: Rename include guard.
1408         * common/gdb_locale.h: Rename include guard.
1409         * common/gdb_assert.h: Rename include guard.
1410         * common/filtered-iterator.h: Rename include guard.
1411         * common/filestuff.h: Rename include guard.
1412         * common/fileio.h: Rename include guard.
1413         * common/environ.h: Rename include guard.
1414         * common/common-utils.h: Rename include guard.
1415         * common/common-types.h: Rename include guard.
1416         * common/common-regcache.h: Rename include guard.
1417         * common/common-inferior.h: Rename include guard.
1418         * common/common-gdbthread.h: Rename include guard.
1419         * common/common-exceptions.h: Rename include guard.
1420         * common/common-defs.h: Rename include guard.
1421         * common/common-debug.h: Rename include guard.
1422         * common/cleanups.h: Rename include guard.
1423         * common/buffer.h: Rename include guard.
1424         * common/btrace-common.h: Rename include guard.
1425         * common/break-common.h: Rename include guard.
1426         * cli/cli-utils.h: Rename include guard.
1427         * cli/cli-style.h: Rename include guard.
1428         * cli/cli-setshow.h: Rename include guard.
1429         * cli/cli-script.h: Rename include guard.
1430         * cli/cli-interp.h: Rename include guard.
1431         * cli/cli-decode.h: Rename include guard.
1432         * cli/cli-cmds.h: Rename include guard.
1433         * charset-list.h: Add include guard.
1434         * buildsym-legacy.h: Rename include guard.
1435         * bfin-tdep.h: Add include guard.
1436         * ax.h: Rename include guard.
1437         * arm-linux-tdep.h: Add include guard.
1438         * arm-fbsd-tdep.h: Add include guard.
1439         * arch/xtensa.h: Rename include guard.
1440         * arch/tic6x.h: Add include guard.
1441         * arch/i386.h: Add include guard.
1442         * arch/arm.h: Rename include guard.
1443         * arch/arm-linux.h: Rename include guard.
1444         * arch/arm-get-next-pcs.h: Rename include guard.
1445         * arch/amd64.h: Add include guard.
1446         * arch/aarch64-insn.h: Rename include guard.
1447         * arch-utils.h: Rename include guard.
1448         * annotate.h: Add include guard.
1449         * amd64-darwin-tdep.h: Rename include guard.
1450         * aarch64-linux-tdep.h: Add include guard.
1451         * aarch64-fbsd-tdep.h: Add include guard.
1452         * aarch32-linux-nat.h: Add include guard.
1453
1454 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1455
1456         * macrotab.c (macro_define_internal): New function that
1457         factorizes macro_define_object_internal and macro_define_function
1458         code.
1459         (macro_define_object_internal): Use macro_define_internal.
1460         (macro_define_function): Likewise.
1461
1462 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1463
1464         * macrocmd.c (extract_identifier): Return
1465         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1466         callers.
1467
1468 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1469
1470         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1471
1472 2019-02-05  Tom Tromey  <tom@tromey.com>
1473
1474         * target.c (target_stack::unpush): Move assertion earlier.
1475
1476 2019-01-30  Tom Tromey  <tom@tromey.com>
1477
1478         PR python/23615:
1479         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1480         (gdbpy_parse_and_eval): Likewise.
1481         * python/python-internal.h (gdbpy_allow_threads): New class.
1482
1483 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1484
1485         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1486         (aarch64_fbsd_fpregmap): Move earlier.
1487         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1488         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1489         instead of individual calls to trad_frame_set_reg_addr.
1490         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1491         earlier.
1492         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1493         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1494         instead of individual calls to trad_frame_set_reg_addr.
1495
1496 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1497
1498         * CONTRIBUTE: Replace contribution list with wiki link.
1499
1500 2019-01-25  Tom Tromey  <tom@tromey.com>
1501
1502         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1503
1504 2019-01-25  Tom Tromey  <tom@tromey.com>
1505
1506         * xtensa-linux-nat.c: Fix common/ includes.
1507         * xml-support.h: Fix common/ includes.
1508         * xml-support.c: Fix common/ includes.
1509         * x86-linux-nat.c: Fix common/ includes.
1510         * windows-nat.c: Fix common/ includes.
1511         * varobj.h: Fix common/ includes.
1512         * varobj.c: Fix common/ includes.
1513         * value.c: Fix common/ includes.
1514         * valops.c: Fix common/ includes.
1515         * utils.c: Fix common/ includes.
1516         * unittests/xml-utils-selftests.c: Fix common/ includes.
1517         * unittests/utils-selftests.c: Fix common/ includes.
1518         * unittests/unpack-selftests.c: Fix common/ includes.
1519         * unittests/tracepoint-selftests.c: Fix common/ includes.
1520         * unittests/style-selftests.c: Fix common/ includes.
1521         * unittests/string_view-selftests.c: Fix common/ includes.
1522         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1523         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1524         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1525         * unittests/rsp-low-selftests.c: Fix common/ includes.
1526         * unittests/parse-connection-spec-selftests.c: Fix common/
1527         includes.
1528         * unittests/optional-selftests.c: Fix common/ includes.
1529         * unittests/offset-type-selftests.c: Fix common/ includes.
1530         * unittests/observable-selftests.c: Fix common/ includes.
1531         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1532         * unittests/memrange-selftests.c: Fix common/ includes.
1533         * unittests/memory-map-selftests.c: Fix common/ includes.
1534         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1535         * unittests/function-view-selftests.c: Fix common/ includes.
1536         * unittests/environ-selftests.c: Fix common/ includes.
1537         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1538         * unittests/common-utils-selftests.c: Fix common/ includes.
1539         * unittests/cli-utils-selftests.c: Fix common/ includes.
1540         * unittests/array-view-selftests.c: Fix common/ includes.
1541         * ui-file.c: Fix common/ includes.
1542         * tui/tui-io.c: Fix common/ includes.
1543         * tracepoint.h: Fix common/ includes.
1544         * tracepoint.c: Fix common/ includes.
1545         * tracefile-tfile.c: Fix common/ includes.
1546         * top.h: Fix common/ includes.
1547         * top.c: Fix common/ includes.
1548         * thread.c: Fix common/ includes.
1549         * target/waitstatus.h: Fix common/ includes.
1550         * target/waitstatus.c: Fix common/ includes.
1551         * target.h: Fix common/ includes.
1552         * target.c: Fix common/ includes.
1553         * target-memory.c: Fix common/ includes.
1554         * target-descriptions.c: Fix common/ includes.
1555         * symtab.h: Fix common/ includes.
1556         * symfile.c: Fix common/ includes.
1557         * stap-probe.c: Fix common/ includes.
1558         * spu-linux-nat.c: Fix common/ includes.
1559         * sparc-nat.c: Fix common/ includes.
1560         * source.c: Fix common/ includes.
1561         * solib.c: Fix common/ includes.
1562         * solib-target.c: Fix common/ includes.
1563         * ser-unix.c: Fix common/ includes.
1564         * ser-tcp.c: Fix common/ includes.
1565         * ser-pipe.c: Fix common/ includes.
1566         * ser-base.c: Fix common/ includes.
1567         * selftest-arch.c: Fix common/ includes.
1568         * s12z-tdep.c: Fix common/ includes.
1569         * rust-exp.y: Fix common/ includes.
1570         * rs6000-aix-tdep.c: Fix common/ includes.
1571         * riscv-tdep.c: Fix common/ includes.
1572         * remote.c: Fix common/ includes.
1573         * remote-notif.h: Fix common/ includes.
1574         * remote-fileio.h: Fix common/ includes.
1575         * remote-fileio.c: Fix common/ includes.
1576         * regcache.h: Fix common/ includes.
1577         * regcache.c: Fix common/ includes.
1578         * record-btrace.c: Fix common/ includes.
1579         * python/python.c: Fix common/ includes.
1580         * python/py-type.c: Fix common/ includes.
1581         * python/py-inferior.c: Fix common/ includes.
1582         * progspace.h: Fix common/ includes.
1583         * producer.c: Fix common/ includes.
1584         * procfs.c: Fix common/ includes.
1585         * proc-api.c: Fix common/ includes.
1586         * printcmd.c: Fix common/ includes.
1587         * ppc-linux-nat.c: Fix common/ includes.
1588         * parser-defs.h: Fix common/ includes.
1589         * osdata.c: Fix common/ includes.
1590         * obsd-nat.c: Fix common/ includes.
1591         * nat/x86-linux.c: Fix common/ includes.
1592         * nat/x86-linux-dregs.c: Fix common/ includes.
1593         * nat/x86-dregs.h: Fix common/ includes.
1594         * nat/x86-dregs.c: Fix common/ includes.
1595         * nat/ppc-linux.c: Fix common/ includes.
1596         * nat/mips-linux-watch.h: Fix common/ includes.
1597         * nat/mips-linux-watch.c: Fix common/ includes.
1598         * nat/linux-waitpid.c: Fix common/ includes.
1599         * nat/linux-ptrace.h: Fix common/ includes.
1600         * nat/linux-ptrace.c: Fix common/ includes.
1601         * nat/linux-procfs.c: Fix common/ includes.
1602         * nat/linux-personality.c: Fix common/ includes.
1603         * nat/linux-osdata.c: Fix common/ includes.
1604         * nat/linux-namespaces.c: Fix common/ includes.
1605         * nat/linux-btrace.h: Fix common/ includes.
1606         * nat/linux-btrace.c: Fix common/ includes.
1607         * nat/fork-inferior.c: Fix common/ includes.
1608         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1609         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1610         * nat/aarch64-linux.c: Fix common/ includes.
1611         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1612         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1613         * namespace.h: Fix common/ includes.
1614         * mips-linux-tdep.c: Fix common/ includes.
1615         * minsyms.c: Fix common/ includes.
1616         * mi/mi-parse.h: Fix common/ includes.
1617         * mi/mi-main.c: Fix common/ includes.
1618         * mi/mi-cmd-env.c: Fix common/ includes.
1619         * memrange.h: Fix common/ includes.
1620         * memattr.c: Fix common/ includes.
1621         * maint.h: Fix common/ includes.
1622         * maint.c: Fix common/ includes.
1623         * main.c: Fix common/ includes.
1624         * machoread.c: Fix common/ includes.
1625         * location.c: Fix common/ includes.
1626         * linux-thread-db.c: Fix common/ includes.
1627         * linux-nat.c: Fix common/ includes.
1628         * linux-fork.c: Fix common/ includes.
1629         * inline-frame.c: Fix common/ includes.
1630         * infrun.c: Fix common/ includes.
1631         * inflow.c: Fix common/ includes.
1632         * inferior.h: Fix common/ includes.
1633         * inferior.c: Fix common/ includes.
1634         * infcmd.c: Fix common/ includes.
1635         * inf-ptrace.c: Fix common/ includes.
1636         * inf-child.c: Fix common/ includes.
1637         * ia64-linux-nat.c: Fix common/ includes.
1638         * i387-tdep.c: Fix common/ includes.
1639         * i386-tdep.c: Fix common/ includes.
1640         * i386-linux-tdep.c: Fix common/ includes.
1641         * i386-linux-nat.c: Fix common/ includes.
1642         * i386-go32-tdep.c: Fix common/ includes.
1643         * i386-fbsd-tdep.c: Fix common/ includes.
1644         * i386-fbsd-nat.c: Fix common/ includes.
1645         * guile/scm-type.c: Fix common/ includes.
1646         * guile/guile.c: Fix common/ includes.
1647         * go32-nat.c: Fix common/ includes.
1648         * gnu-nat.c: Fix common/ includes.
1649         * gdbthread.h: Fix common/ includes.
1650         * gdbarch-selftests.c: Fix common/ includes.
1651         * gdb_usleep.c: Fix common/ includes.
1652         * gdb_select.h: Fix common/ includes.
1653         * gdb_bfd.c: Fix common/ includes.
1654         * gcore.c: Fix common/ includes.
1655         * fork-child.c: Fix common/ includes.
1656         * findvar.c: Fix common/ includes.
1657         * fbsd-nat.c: Fix common/ includes.
1658         * event-top.c: Fix common/ includes.
1659         * event-loop.c: Fix common/ includes.
1660         * dwarf2read.c: Fix common/ includes.
1661         * dwarf2loc.c: Fix common/ includes.
1662         * dwarf2-frame.c: Fix common/ includes.
1663         * dwarf-index-cache.c: Fix common/ includes.
1664         * dtrace-probe.c: Fix common/ includes.
1665         * disasm-selftests.c: Fix common/ includes.
1666         * defs.h: Fix common/ includes.
1667         * csky-tdep.c: Fix common/ includes.
1668         * cp-valprint.c: Fix common/ includes.
1669         * cp-support.h: Fix common/ includes.
1670         * cp-support.c: Fix common/ includes.
1671         * corelow.c: Fix common/ includes.
1672         * completer.h: Fix common/ includes.
1673         * completer.c: Fix common/ includes.
1674         * compile/compile.c: Fix common/ includes.
1675         * compile/compile-loc2c.c: Fix common/ includes.
1676         * compile/compile-cplus-types.c: Fix common/ includes.
1677         * compile/compile-cplus-symbols.c: Fix common/ includes.
1678         * command.h: Fix common/ includes.
1679         * cli/cli-dump.c: Fix common/ includes.
1680         * cli/cli-cmds.c: Fix common/ includes.
1681         * charset.c: Fix common/ includes.
1682         * build-id.c: Fix common/ includes.
1683         * btrace.h: Fix common/ includes.
1684         * btrace.c: Fix common/ includes.
1685         * breakpoint.h: Fix common/ includes.
1686         * breakpoint.c: Fix common/ includes.
1687         * ax.h: 
1688         (enum agent_op): Fix common/ includes.
1689         * ax-general.c (struct aop_map): Fix common/ includes.
1690         * ax-gdb.c: Fix common/ includes.
1691         * auxv.c: Fix common/ includes.
1692         * auto-load.c: Fix common/ includes.
1693         * arm-tdep.c: Fix common/ includes.
1694         * arch/riscv.c: Fix common/ includes.
1695         * arch/ppc-linux-common.c: Fix common/ includes.
1696         * arch/i386.c: Fix common/ includes.
1697         * arch/arm.c: Fix common/ includes.
1698         * arch/arm-linux.c: Fix common/ includes.
1699         * arch/arm-get-next-pcs.c: Fix common/ includes.
1700         * arch/amd64.c: Fix common/ includes.
1701         * arch/aarch64.c: Fix common/ includes.
1702         * arch/aarch64-insn.c: Fix common/ includes.
1703         * arch-utils.c: Fix common/ includes.
1704         * amd64-windows-tdep.c: Fix common/ includes.
1705         * amd64-tdep.c: Fix common/ includes.
1706         * amd64-sol2-tdep.c: Fix common/ includes.
1707         * amd64-obsd-tdep.c: Fix common/ includes.
1708         * amd64-nbsd-tdep.c: Fix common/ includes.
1709         * amd64-linux-tdep.c: Fix common/ includes.
1710         * amd64-linux-nat.c: Fix common/ includes.
1711         * amd64-fbsd-tdep.c: Fix common/ includes.
1712         * amd64-fbsd-nat.c: Fix common/ includes.
1713         * amd64-dicos-tdep.c: Fix common/ includes.
1714         * amd64-darwin-tdep.c: Fix common/ includes.
1715         * agent.c: Fix common/ includes.
1716         * ada-lang.h: Fix common/ includes.
1717         * ada-lang.c: Fix common/ includes.
1718         * aarch64-tdep.c: Fix common/ includes.
1719
1720 2019-01-25  Tom Tromey  <tom@tromey.com>
1721
1722         * common/create-version.sh: Use common/version.h.
1723
1724 2019-01-24  Pedro Alves  <palves@redhat.com>
1725
1726         * infrun.c (signal_stop, signal_print, signal_program)
1727         (signal_catch, signal_pass): Now arrays instead of pointers.
1728         (update_signals_program_target, do_target_resume)
1729         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1730         * linux-nat.c (linux_nat_target::pass_signals)
1731         (linux_nat_target::create_inferior, linux_nat_target::attach):
1732         Adjust.
1733         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1734         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1735         * procfs.c (procfs_target::pass_signals): Adjust.
1736         * record-full.c (record_full_target::resume): Adjust.
1737         * remote.c (remote_target::pass_signals)
1738         (remote_target::program_signals): Adjust.
1739         * target-debug.h (target_debug_print_signals): Now takes a
1740         gdb::array_view as parameter.  Adjust.
1741         * target.h (target_ops) <pass_signals, program_signals>: Replace
1742         pointer and length parameters with gdb::array_view.
1743         (target_pass_signals, target_program_signals): Likewise.
1744         * target-delegates.c: Regenerate.
1745
1746 2019-01-24  Pedro Alves  <palves@redhat.com>
1747
1748         * common/forward-scope-exit.h
1749         (forward_scope_exit::forward_scope_exit): Pass arguments to
1750         m_bind_function directly, instead of creating a std::bind and
1751         copying that.
1752
1753 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1754
1755         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1756         for static members.
1757         (pass_in_v_vfp_candidate): Likewise.
1758
1759 2019-01-23  Tom Tromey  <tom@tromey.com>
1760             Pedro Alves  <palves@redhat.com>
1761
1762         * regcache.c (class regcache_invalidator): Remove.
1763         (regcache::raw_write): Use make_scope_exit.
1764
1765 2019-01-23  Tom Tromey  <tom@tromey.com>
1766
1767         * ui-out.h (class ui_out_emit_type): Update comment.
1768
1769 2019-01-23  Tom Tromey  <tom@tromey.com>
1770
1771         * infrun.c (fetch_inferior_event): Update comment.
1772
1773 2019-01-23  Tom Tromey  <tom@tromey.com>
1774             Pedro Alves  <palves@redhat.com>
1775
1776         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1777         parameter.
1778         (fetch_inferior_event): Use SCOPE_EXIT.
1779
1780
1781 2019-01-23  Tom Tromey  <tom@tromey.com>
1782             Pedro Alves  <palves@redhat.com>
1783
1784         * infrun.c (disable_thread_events): Delete.
1785         (stop_all_threads): Use SCOPE_EXIT.
1786
1787 2019-01-23  Tom Tromey  <tom@tromey.com>
1788             Pedro Alves  <palves@redhat.com>
1789
1790         * symfile.c: Include forward-scope-exit.h.
1791         (clear_symtab_users_cleanup): Replace forward declaration with
1792         a FORWARD_SCOPE_EXIT.
1793         (syms_from_objfile_1): Use the forward_scope_exit and
1794         gdb::optional instead of cleanup_function.
1795         (reread_symbols): Use the forward_scope_exit instead of
1796         cleanup_function.
1797         (clear_symtab_users_cleanup): Remove function.
1798
1799 2019-01-23  Tom Tromey  <tom@tromey.com>
1800             Pedro Alves  <palves@redhat.com>
1801
1802         * linux-nat.c: Include scope-exit.h.
1803         (cleanup_target_stop): Remove.
1804         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1805         SCOPE_EXIT.
1806
1807 2019-01-23  Tom Tromey  <tom@tromey.com>
1808             Pedro Alves  <palves@redhat.com>
1809
1810         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1811         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1812
1813 2019-01-23  Tom Tromey  <tom@tromey.com>
1814             Andrew Burgess  <andrew.burgess@embecosm.com>
1815             Pedro Alves  <palves@redhat.com>
1816
1817         * infrun.c (fetch_inferior_event): Use scope_exit.
1818         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1819         * top.c (execute_command): Use scope_exit.
1820         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1821         * utils.c (do_bpstat_clear_actions_cleanup)
1822         (make_bpstat_clear_actions_cleanup): Remove.
1823
1824 2019-01-23  Tom Tromey  <tom@tromey.com>
1825             Pedro Alves  <palves@redhat.com>
1826
1827         * infrun.c: Include "common/scope-exit.h"
1828         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1829         (wait_for_inferior): Use SCOPE_EXIT.
1830         (fetch_inferior_event): Use scope_exit.
1831
1832 2019-01-23  Tom Tromey  <tom@tromey.com>
1833             Pedro Alves  <palves@redhat.com>
1834
1835         * breakpoint.c (create_breakpoint): Remove cleanup.
1836
1837 2019-01-23  Tom Tromey  <tom@tromey.com>
1838             Andrew Burgess  <andrew.burgess@embecosm.com>
1839             Pedro Alves  <palves@redhat.com>
1840
1841 2019-01-23  Pedro Alves  <palves@redhat.com>
1842
1843         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1844
1845 2019-01-23  Pedro Alves  <palves@redhat.com>
1846             Andrew Burgess  <andrew.burgess@embecosm.com>
1847
1848         * gdbthread.h: Include "common/forward-scope-exit.h".
1849         (scoped_finish_thread_state): Redefine custom class in terms of
1850         forward_scope_exit.
1851
1852 2019-01-23  Pedro Alves  <palves@redhat.com>
1853             Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * common/forward-scope-exit.h: New file.
1856
1857 2019-01-23  Pedro Alves  <palves@redhat.com>
1858             Andrew Burgess  <andrew.burgess@embecosm.com>
1859             Tom Tromey  <tom@tromey.com>
1860
1861         * common/scope-exit.h: New file.
1862
1863 2019-01-23  Pedro Alves  <palves@redhat.com>
1864
1865         * common/preprocessor.h (ESC): Rename to ...
1866         (ESC_PARENS): ... this.
1867         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1868         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1869
1870 2019-01-23  Tom Tromey  <tom@tromey.com>
1871
1872         * language.h (class scoped_switch_to_sym_language_if_auto):
1873         Initialize m_lang in both cases.
1874
1875 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1876
1877         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1878         with XCNEW.
1879
1880 2019-01-22  Tom Tromey  <tom@tromey.com>
1881
1882         * corelow.c: Do not include sys/file.h.
1883
1884 2019-01-22  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-wingeneral.h: Include gdb_curses.h.
1887
1888 2019-01-22  Tom Tromey  <tom@tromey.com>
1889
1890         * source-cache.h (class source_cache) <get_source_lines,
1891         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1892
1893 2019-01-22  Tom Tromey  <tom@tromey.com>
1894
1895         * remote-fileio.h (struct remote_target): Declare.
1896
1897 2019-01-22  Tom Tromey  <tom@tromey.com>
1898
1899         * python/py-arch.c: Do not include py-ref.h.
1900         * python/py-bpevent.c: Do not include py-ref.h.
1901         * python/py-cmd.c: Do not include py-ref.h.
1902         * python/py-continueevent.c: Do not include py-ref.h.
1903         * python/py-event.h: Do not include py-ref.h.
1904         * python/py-evtregistry.c: Do not include py-ref.h.
1905         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1906         * python/py-frame.c: Do not include py-ref.h.
1907         * python/py-framefilter.c: Do not include py-ref.h.
1908         * python/py-function.c: Do not include py-ref.h.
1909         * python/py-infevents.c: Do not include py-ref.h.
1910         * python/py-linetable.c: Do not include py-ref.h.
1911         * python/py-objfile.c: Do not include py-ref.h.
1912         * python/py-param.c: Do not include py-ref.h.
1913         * python/py-prettyprint.c: Do not include py-ref.h.
1914         * python/py-progspace.c: Do not include py-ref.h.
1915         * python/py-symbol.c: Do not include py-ref.h.
1916         * python/py-symtab.c: Do not include py-ref.h.
1917         * python/py-type.c: Do not include py-ref.h.
1918         * python/py-unwind.c: Do not include py-ref.h.
1919         * python/py-utils.c: Do not include py-ref.h.
1920         * python/py-value.c: Do not include py-ref.h.
1921         * python/py-varobj.c: Do not include py-ref.h.
1922         * python/py-xmethods.c: Do not include py-ref.h.
1923         * python/python.c: Do not include py-ref.h.
1924         * varobj.c: Do not include py-ref.h.
1925
1926 2019-01-22  Tom Tromey  <tom@tromey.com>
1927
1928         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1929         keyword for bcache.
1930
1931 2019-01-22  Tom Tromey  <tom@tromey.com>
1932
1933         * compile/compile-cplus-types.c: Remove a comment by #include.
1934
1935 2019-01-22  Tom Tromey  <tom@tromey.com>
1936
1937         * compile/gcc-c-plugin.h: Include compile-internal.h.
1938
1939 2019-01-22  Tom Tromey  <tom@tromey.com>
1940
1941         * stabsread.c (EXTERN): Do not define.
1942         (symnum, next_symbol_text_func, processing_gcc_compilation)
1943         (within_function, global_sym_chain, global_stabs)
1944         (previous_stab_code, this_object_header_files)
1945         (n_this_object_header_files)
1946         (n_allocated_this_object_header_files): Define.
1947         * stabsread.h (EXTERN): Never define.  Use "extern".
1948
1949 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1950
1951         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1952         history_value.
1953
1954 2019-01-21  Tom Tromey  <tom@tromey.com>
1955
1956         * ui-out.c: Fix includes.
1957         * tui/tui-source.c: Fix includes.
1958         * target.c: Fix includes.
1959         * remote.c: Fix includes.
1960         * regcache.c: Fix includes.
1961         * python/py-block.c: Fix includes.
1962         * printcmd.c: Fix includes.
1963         * or1k-tdep.c: Fix includes.
1964         * mi/mi-main.c: Fix includes.
1965         * m32r-tdep.c: Fix includes.
1966         * csky-tdep.c: Fix includes.
1967         * compile/compile-cplus-types.c: Fix includes.
1968         * cli/cli-interp.c: Fix includes.
1969
1970 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1971
1972         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1973         for padding.
1974
1975 2019-01-16  Tom Tromey  <tom@tromey.com>
1976
1977         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1978         earlier.
1979         (struct objfile) <msymbols_range>: Move from top level.
1980         <msymbols>: New method.
1981         (class objfile_msymbols): Remove.
1982         * symtab.c (default_collect_symbol_completion_matches_break_on):
1983         Update.
1984         * symmisc.c (dump_msymbols): Update.
1985         * stabsread.c (scan_file_globals): Update.
1986         * objc-lang.c (info_selectors_command, info_classes_command)
1987         (find_methods): Update.
1988         * minsyms.c (find_solib_trampoline_target): Update.
1989         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1990         * coffread.c (coff_symfile_read): Update.
1991         * ada-lang.c (ada_lookup_simple_minsym)
1992         (ada_collect_symbol_completion_matches): Update.
1993
1994 2019-01-16  Tom Tromey  <tom@tromey.com>
1995
1996         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1997         type.  Remove no-argument constructor.
1998         <iterator::operator++>: Simplify.
1999         <begin>: Update.
2000         <end>: Use minimal_symbol_count.
2001
2002 2019-01-16  Tom Tromey  <tom@tromey.com>
2003
2004         * objfiles.h (struct objfile) <psymtabs>: New method.
2005         (class objfile_psymtabs): Remove.
2006         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2007         typedef.
2008         <range>: New method.
2009         (require_partial_symbols): Change return type.
2010         * psymtab.c (require_partial_symbols)
2011         (psym_expand_symtabs_matching): Update.
2012         * mdebugread.c (parse_partial_symbols): Update.
2013         * dbxread.c (dbx_end_psymtab): Update.
2014
2015 2019-01-15  Tom Tromey  <tom@tromey.com>
2016
2017         * symtab.c (lookup_objfile_from_block)
2018         (lookup_symbol_in_objfile_symtabs)
2019         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2020         (find_line_symtab, info_sources_command)
2021         (default_collect_symbol_completion_matches_break_on)
2022         (make_source_files_completion_list): Update.
2023         * symmisc.c (print_objfile_statistics, dump_objfile)
2024         (maintenance_print_symbols, maintenance_info_symtabs)
2025         (maintenance_check_symtabs, maintenance_info_line_tables):
2026         Update.
2027         * source.c (select_source_symtab)
2028         (forget_cached_source_info_for_objfile): Update.
2029         * objfiles.h (class objfile_compunits): Remove.
2030         (struct objfile) <compunits_range>: New typedef.
2031         (compunits): New method.
2032         * objfiles.c (objfile_relocate1): Update.
2033         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2034         * maint.c (count_symtabs_and_blocks): Update.
2035         * linespec.c (iterate_over_all_matching_symtabs): Update.
2036         * cp-support.c (add_symbol_overload_list_qualified): Update.
2037         * coffread.c (coff_symtab_read): Update.
2038         * ada-lang.c (add_nonlocal_symbols)
2039         (ada_collect_symbol_completion_matches)
2040         (ada_add_global_exceptions): Update.
2041
2042 2019-01-15  Tom Tromey  <tom@tromey.com>
2043
2044         * progspace.h (program_space) <objfiles_safe_range>: New
2045         typedef.
2046         <objfiles_safe>: New method.
2047         * objfiles.h (class all_objfiles_safe): Remove.
2048         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2049         * jit.c (jit_inferior_exit_hook): Update.
2050
2051 2019-01-17  Tom Tromey  <tom@tromey.com>
2052
2053         * progspace.h (program_space) <objfiles_range>: New typedef.
2054         <objfiles>: New method.
2055         <objfiles_head>: Rename from objfiles.
2056         (object_files): Update.
2057         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2058         * guile/scm-pretty-print.c
2059         (ppscm_find_pretty_printer_from_objfiles): Update.
2060         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2061         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2062         Update.
2063         * python/py-progspace.c (pspy_get_objfiles): Update.
2064         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2065         Update.
2066         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2067         (objfpy_lookup_objfile_by_build_id): Update.
2068         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2069         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2070         Update.
2071         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2072         (expand_symtab_containing_pc, lookup_objfile_from_block)
2073         (lookup_static_symbol, basic_lookup_transparent_type)
2074         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2075         (find_line_symtab, info_sources_command)
2076         (default_collect_symbol_completion_matches_break_on)
2077         (make_source_files_completion_list, find_main_name): Update.
2078         * symmisc.c (print_symbol_bcache_statistics)
2079         (print_objfile_statistics, maintenance_print_symbols)
2080         (maintenance_print_msymbols, maintenance_print_objfiles)
2081         (maintenance_info_symtabs, maintenance_check_symtabs)
2082         (maintenance_expand_symtabs, maintenance_info_line_tables):
2083         Update.
2084         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2085         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2086         (map_overlay_command, unmap_overlay_command)
2087         (simple_overlay_update, expand_symtabs_matching)
2088         (map_symbol_filenames): Update.
2089         * symfile-debug.c (set_debug_symfile): Update.
2090         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2091         Update.
2092         * source.c (select_source_symtab, forget_cached_source_info):
2093         Update.
2094         * solib.c (solib_read_symbols): Update.
2095         * solib-spu.c (append_ocl_sos): Update.
2096         * psymtab.c (maintenance_print_psymbols)
2097         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2098         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2099         * printcmd.c (info_symbol_command): Update.
2100         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2101         Update.
2102         * objfiles.h (class all_objfiles): Remove.
2103         * objfiles.c (have_partial_symbols, have_full_symbols)
2104         (have_minimal_symbols, qsort_cmp, update_section_map)
2105         (shared_objfile_contains_address_p)
2106         (default_iterate_over_objfiles_in_search_order): Update.
2107         * objc-lang.c (info_selectors_command, info_classes_command)
2108         (find_methods): Update.
2109         * minsyms.c (find_solib_trampoline_target): Update.
2110         * maint.c (maintenance_info_sections)
2111         (maintenance_translate_address, count_symtabs_and_blocks):
2112         Update.
2113         * main.c (captured_main_1): Update.
2114         * linux-thread-db.c (try_thread_db_load_from_pdir)
2115         (has_libpthread): Update.
2116         * linespec.c (iterate_over_all_matching_symtabs)
2117         (search_minsyms_for_name): Update.
2118         * jit.c (jit_find_objf_with_entry_addr): Update.
2119         * hppa-tdep.c (find_unwind_entry)
2120         (hppa_lookup_stub_minimal_symbol): Update.
2121         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2122         Update.
2123         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2124         (elf_gnu_ifunc_resolve_by_got): Update.
2125         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2126         * dwarf-index-write.c (save_gdb_index_command): Update.
2127         * cp-support.c (add_symbol_overload_list_qualified): Update.
2128         * breakpoint.c (create_overlay_event_breakpoint)
2129         (create_longjmp_master_breakpoint)
2130         (create_std_terminate_master_breakpoint)
2131         (create_exception_master_breakpoint): Update.
2132         * blockframe.c (find_pc_partial_function): Update.
2133         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2134         (ada_collect_symbol_completion_matches)
2135         (ada_add_global_exceptions): Update.
2136
2137 2019-01-17  Tom Tromey  <tom@tromey.com>
2138
2139         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2140         declare VEC.
2141         (solib_target_parse_libraries): Change return type.
2142         (library_list_start_segment, library_list_start_section)
2143         (library_list_end_library, library_list_start_library); Update.
2144         (solib_target_free_library_list): Remove.
2145         (solib_target_parse_libraries): Remove cleanup.  Change return
2146         type.
2147         (solib_target_current_sos): Update.
2148
2149 2019-01-17  Tom Tromey  <tromey@bapiya>
2150
2151         * valprint.c: Replace "the the" with "the".
2152         * symtab.c: Replace "the the" with "the".
2153         * solib.c: Replace "the the" with "the".
2154         * solib-dsbt.c: Replace "the the" with "the".
2155         * linespec.c: Replace "the the" with "the".
2156         * dwarf2loc.h: Replace "the the" with "the".
2157         * amd64-windows-tdep.c: Replace "the the" with "the".
2158         * aarch64-tdep.c: Replace "the the" with "the".
2159
2160 2019-01-16  Keith Seitz  <keiths@redhat.com>
2161
2162         PR gdb/23773
2163         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2164         <builder>: Rename to ..
2165         <m_builder>: ... this and make private.
2166         (dwarf2_cu::get_builder): New method.  Change all users of
2167         `builder' to use this method.
2168         (dwarf2_start_symtab): Move to ...
2169         (dwarf2_cu::start_symtab): ... here.  Update all callers
2170         (setup_type_unit_groups): Move to ...
2171         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2172         callers.
2173         (dwarf2_cu::reset_builder): New method.
2174         (process_full_compunit, process_full_type_unit): Use
2175         dwarf2_cu::reset_builder.
2176         (follow_die_offset): Record the ancestor CU if it is different
2177         from the followed DIE's CU.
2178         (follow_die_sig_1): Likewise.
2179
2180 2019-01-15  Tom Tromey  <tom@tromey.com>
2181
2182         * remote.c (class remote_state) <buf>: Now a char_vector.
2183         <buf_size>: Remove.
2184         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2185         parameter.
2186         (remote_target::getpkt_or_notif_sane_1)
2187         (remote_target::getpkt_sane)
2188         (remote_target::getpkt_or_notif_sane): Likewise.
2189         (class remote_target) <putpkt>: New overload.
2190         (remote_target::read_frame): Change type of "buf_p".  Remove
2191         sizeof_p parameter.
2192         (packet_ok): New overload.
2193         (packet_check_result): New overload.
2194         Update all uses.
2195
2196 2019-01-14  Tom Tromey  <tom@tromey.com>
2197
2198         * remote-notif.c (handle_notification, remote_notif_ack)
2199         (remote_notif_parse): Make "buf" const.
2200         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2201         const.
2202         (remote_notif_parse, remote_notif_ack, handle_notification):
2203         Likewise.
2204         * remote.c (remote_notif_stop_parse): Make "buf" const.
2205         (remote_target::remote_parse_stop_reply): Make "buf" const.
2206         (remote_notif_stop_ack): Make "buf" const.
2207
2208 2019-01-14  Tom Tromey  <tom@tromey.com>
2209
2210         * remote.c (remote_console_output): Make parameter const.
2211
2212 2019-01-14  Tom Tromey  <tom@tromey.com>
2213
2214         * target-debug.h (target_debug_print_signals): Constify.
2215         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2216         * procfs.c (procfs_target::pass_signals): Update.
2217         * linux-nat.c (linux_nat_target::pass_signals): Update.
2218         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2219         * target-delegates.c: Rebuild.
2220         * remote.c (remote_target::program_signals): Update.
2221         (remote_target::pass_signals): Update.
2222         * target.c (target_pass_signals): Constify argument.
2223         (target_program_signals): Likewise.
2224         * target.h (struct target_ops) <pass_signals, program_signals>:
2225         Constify argument.
2226         (target_pass_signals, target_program_signals): Constify argument.
2227
2228 2019-01-14  Tom Tromey  <tom@tromey.com>
2229
2230         PR tui/28819:
2231         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2232
2233 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2234
2235         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2236         field.
2237         * rs6000-tdep.c: Include reggroups.h.
2238         (IS_V_ALIAS_PSEUDOREG): Define.
2239         (rs6000_register_name): Return names for the "vX" aliases.
2240         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2241         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2242         aliases.  Call default_register_reggroup_p for all other
2243         pseudo-registers.
2244         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2245         New functions.
2246         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2247         Handle "vX" aliases.
2248         (v_alias_pseudo_register_collect): New function.
2249         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2250         (rs6000_gdbarch_init): Initialize "vX" aliases as
2251         pseudo-registers.  Restore registration of
2252         rs6000_pseudo_register_reggroup_p with
2253         set_tdesc_pseudo_register_reggroup_p.
2254
2255 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2256
2257         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2258         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2259         set_gdbarch_num_pseudo_regs.
2260
2261 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2262
2263         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2264         Remove arg prefixname, add do_set and do_show.
2265         Add member functions set_list and show_list.
2266         * cli/cli-style.c (class cli_style_option): Update accordingly.
2267         (style_set_list): Move to file scope.
2268         (style_show_list): Likewise.
2269         (set_style): Call help_list.
2270         (show_style): Call cmd_show_list.
2271         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2272         Update to use the new macro.
2273
2274 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2275
2276         * ada-lang.c (_initialize_ada_language): Expand the help text
2277         for the "catch exception" command.
2278
2279 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2280
2281         * symtab.c (matching_obj_sections): Initialize obj,
2282         declare it closer to its usage.
2283
2284 2019-01-10  Tom Tromey  <tom@tromey.com>
2285
2286         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2287         (basic_inf_threads_range): Remove.
2288         (inf_threads_range, inf_non_exited_threads_range)
2289         (safe_inf_threads_range): Use next_adapter.
2290
2291 2019-01-10  Keith Seitz  <keiths@redhat.com>
2292
2293         PR gdb/23712
2294         PR symtab/23010
2295         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2296         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2297
2298 2019-01-10  Keith Seitz  <keiths@redhat.com>
2299
2300         PR gdb/23712
2301         PR symtab/23010
2302         * dictionary.c (pending_to_vector): Remove.
2303         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2304         Remove _1 suffix, replacing functions of the same name.  Update
2305         all callers.
2306         (dict_create_hashed, dict_create_hashed_expandable)
2307         (dict_create_linear, dict_create_linear_expandable, dict_free)
2308         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2309         Make functions static.
2310
2311 2019-01-10  Keith Seitz  <keiths@redhat.com>
2312
2313         PR gdb/23712
2314         PR symtab/23010
2315         * dictionary.h (struct dictionary): Replace declaration with
2316         multidictionary.
2317         (dict_create_hashed, dict_create_hashed_expandable)
2318         (dict_create_linear, dict_create_linear_expandable)
2319         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2320         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2321         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2322         taking multidictionary argument.
2323         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2324         * block.h (struct block) <dict>: Change to multidictionary
2325         and rename `multidict'.
2326         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2327         symmisc.c: Update all dictionary references to multidictionary.
2328
2329 2019-01-10  Keith Seitz  <keiths@redhat.com>
2330
2331         PR gdb/23712
2332         PR symtab/23010
2333         * dictionary.c: Include unordered_map.
2334         (pending_to_vector): New function.
2335         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2336         Rewrite the non-"_1" functions to take vector instead
2337         of linked list.
2338         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2339         "new" _1 versions of the same name.
2340         (multidictionary): Define.
2341         (std::hash<enum language): New definition.
2342         (collate_pending_symbols_by_language, mdict_create_hashed)
2343         (mdict_create_hashed_expandable, mdict_create_linear)
2344         (mdict_create_linear_expandable, mdict_free)
2345         (find_language_dictionary, create_new_language_dictionary)
2346         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2347         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2348         (mdict_size, mdict_empty): New functions.
2349         * dictionary.h (mdict_iterator): Define.
2350
2351 2019-01-10  Pedro Alves  <palves@redhat.com>
2352
2353         * breakpoint.c (read_uploaded_action)
2354         (create_tracepoint_from_upload): Adjust to use
2355         gdb::unique_xmalloc_ptr.
2356         * ctf.c (ctf_write_uploaded_tp):
2357         (SET_ARRAY_FIELD): Use emplace_back.
2358         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2359         * tracefile-tfile.c (tfile_write_uploaded_tp):
2360         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2361         gdb::unique_xmalloc_ptr.
2362         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2363         at_string, cond_string, cmd_strings>: Replace char pointers
2364         with gdb::unique_xmalloc_ptr.
2365
2366 2019-01-10  Pedro Alves  <palves@redhat.com>
2367
2368         * solib-target.c (library_list_start_library): Don't xstrdup name.
2369
2370 2019-01-10  Pedro Alves  <palves@redhat.com>
2371
2372         * mdebugread.c (parse_partial_symbols): Use
2373         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2374
2375 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2376
2377         * linux-fork.c (scoped_switch_fork_info)
2378         <~scoped_switch_fork_info>: Fix incorrect variable name.
2379
2380 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2381
2382         * linux-fork.c (scoped_switch_fork_info)
2383         <scoped_switch_fork_info>: Make explicit.
2384         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2385
2386 2019-01-10  Tom Tromey  <tom@tromey.com>
2387
2388         * objfiles.h (objfile::reset_psymtabs): Update.
2389         * objfiles.c (objfile::objfile): Update.
2390         * psymtab.h (psymtab_storage::obstack): Update.
2391         (psymtab_storage::m_obstack): Use gdb::optional.
2392         (class psymtab_storage): Update comment.  Remove objfile
2393         parameter.
2394         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2395
2396 2019-01-10  Tom Tromey  <tom@tromey.com>
2397
2398         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2399         <free_psymtabs>: Now private.
2400         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2401         (allocate_psymtab): Use new method.
2402
2403 2019-01-10  Tom Tromey  <tom@tromey.com>
2404
2405         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2406         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2407         * mdebugread.c (parse_partial_symbols): Use
2408         allocate_dependencies.
2409         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2410         allocate_dependencies.
2411         (process_psymtab_comp_unit_reader)
2412         (build_type_psymtab_dependencies): Likewise.
2413         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2414
2415 2019-01-10  Tom Tromey  <tom@tromey.com>
2416
2417         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2418         PSYMBOL_SET_LANGUAGE.
2419         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2420
2421 2019-01-10  Tom Tromey  <tom@tromey.com>
2422
2423         * psymtab.h (psymtab_storage::obstack): New method.
2424         <m_obstack>: Rename from obstack; now private.
2425         * psymtab.c (psymtab_storage): Update.
2426         * dwarf2read.c (create_addrmap_from_index)
2427         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2428         Update.
2429
2430 2019-01-10  Tom Tromey  <tom@tromey.com>
2431
2432         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2433         * objfiles.h (objfile::reset_psymtabs): New method.
2434
2435 2019-01-10  Tom Tromey  <tom@tromey.com>
2436
2437         * symmisc.c (print_symbol_bcache_statistics): Update.
2438         (print_objfile_statistics): Update.
2439         * symfile.c (reread_symbols): Update.
2440         * psymtab.h (class psymtab_storage): New.
2441         * psymtab.c (psymtab_storage): New constructor.
2442         (~psymtab_storage): New destructor.
2443         (require_partial_symbols): Update.
2444         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2445         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2446         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2447         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2448         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2449         (start_psymtab_common, end_psymtab_common)
2450         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2451         (allocate_psymtab): Update.
2452         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2453         Update.
2454         (dump_psymtab_addrmap, maintenance_print_psymbols)
2455         (maintenance_check_psymtabs): Update.
2456         (class objfile_psymtabs): Move to objfiles.h.
2457         * psympriv.h (discard_psymtab): Now inline.
2458         (psymtab_discarder::psymtab_discarder): Update.
2459         (psymtab_discarder::~psymtab_discarder): Update.
2460         (ALL_OBJFILE_PSYMTABS): Rewrite.
2461         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2462         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2463         Remove fields.
2464         <partial_symtabs>: New field.
2465         (class objfile_psymtabs): Move from psymtab.h.  Update.
2466         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2467         psymbol_cache.
2468         (objfile::~objfile): Don't destroy psymbol_cache.
2469         * mdebugread.c (parse_partial_symbols): Update.
2470         * dwarf2read.c (create_addrmap_from_index)
2471         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2472         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2473         (add_partial_subprogram, dwarf2_ranges_read): Update.
2474         * dwarf-index-write.c (write_address_map)
2475         (write_one_signatured_type, recursively_write_psymbols)
2476         (class debug_names, class debug_names, write_psymtabs_to_index):
2477         Update.
2478
2479 2019-01-10  Tom Tromey  <tom@tromey.com>
2480
2481         * symtab.h (SYMBOL_SET_NAMES): Update.
2482         (symbol_set_names): Update.
2483         (MSYMBOL_SET_NAMES): Update.
2484         * symtab.c (symbol_set_names): Change argument to be an
2485         objfile_per_bfd_storage.
2486         * psymtab.c (add_psymbol_to_bcache): Update.
2487         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2488
2489 2019-01-10  Tom Tromey  <tom@tromey.com>
2490
2491         * symtab.c (create_demangled_names_hash): Change argument to be an
2492         objfile_per_bfd_storage.
2493         (symbol_set_names): Update.
2494
2495 2019-01-10  Tom Tromey  <tom@tromey.com>
2496
2497         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2498         init_psymbol_list.
2499         * psymtab.c (init_psymbol_list): Do nothing if already called.
2500         * psympriv.h (init_psymbol_list): Add comment.
2501         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2502         init_psymbol_list.
2503         * dbxread.c (dbx_symfile_read): Unconditionally call
2504         init_psymbol_list.
2505
2506 2019-01-10  Tom Tromey  <tom@tromey.com>
2507
2508         * xcoffread.c (scan_xcoff_symtab): Update.
2509         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2510         "where".
2511         * mdebugread.c (parse_partial_symbols)
2512         (handle_psymbol_enumerators): Update.
2513         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2514         * dbxread.c (read_dbx_symtab): Update.
2515         * psympriv.h (psymbol_placement): New enum.
2516         (add_psymbol_to_list): Update.
2517
2518 2019-01-10  Tom Tromey  <tom@tromey.com>
2519
2520         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2521         static_psymbols parameters.
2522         (scan_xcoff_symtab): Update.
2523         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2524         static_psymbols parameters.
2525         * psympriv.h (start_psymtab_common): Update.
2526         * mdebugread.c (parse_partial_symbols): Update.
2527         * dwarf2read.c (create_partial_symtab): Update.
2528         * dbxread.c (read_dbx_symtab): Update.
2529         (start_psymtab): Remove global_psymbols and static_psymbols
2530         parameters.
2531
2532 2019-01-10  Tom Tromey  <tom@tromey.com>
2533
2534         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2535         * psymtab.c (allocate_psymtab): Add comment.
2536         * psympriv.h (allocate_psymtab): Add comment.
2537         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2538         initializations.
2539         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2540
2541 2019-01-10  Tom Tromey  <tom@tromey.com>
2542
2543         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2544         Don't declare.
2545         * mipsread.c: Include mdebugread.h.
2546         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2547         Declare.
2548         * elfread.c: Include mdebugread.h.
2549
2550 2019-01-09  Tom Tromey  <tom@tromey.com>
2551
2552         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2553         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2554         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2555         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2556         (psym_lookup_symbol, psym_find_last_source_symtab)
2557         (psym_forget_cached_source_info, psym_print_stats)
2558         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2559         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2560         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2561         (psym_find_compunit_symtab_by_address)
2562         (maintenance_print_psymbols, maintenance_info_psymtabs)
2563         (maintenance_check_psymtabs): Use ranged for.
2564         * psymtab.h (class objfile_psymtabs): New.
2565         (require_partial_symbols): Return objfile_psymtabs.
2566         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2567
2568 2019-01-09  Tom Tromey  <tom@tromey.com>
2569
2570         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2571         (find_pc_mapped_section, list_overlays_command)
2572         (map_overlay_command, unmap_overlay_command)
2573         (simple_overlay_update): Use all_objfiles.
2574         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2575         * printcmd.c (info_symbol_command): Use all_objfiles.
2576         * objfiles.h (ALL_OBJSECTIONS): Remove.
2577         * maint.c (maintenance_translate_address): Use all_objfiles.
2578         * gcore.c (gcore_create_callback): Use all_objfiles.
2579         (objfile_find_memory_regions): Likewise.
2580
2581 2019-01-09  Tom Tromey  <tom@tromey.com>
2582
2583         * symtab.c (find_line_symtab, info_sources_command)
2584         (make_source_files_completion_list): Use objfile_compunits.
2585         * source.c (select_source_symtab): Use objfile_compunits.
2586         * objfiles.h (struct objfile): Update comment.
2587         (ALL_OBJFILES): Remove.
2588         (ALL_FILETABS): Remove.
2589         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2590         objfile_compunits.
2591
2592 2019-01-09  Tom Tromey  <tom@tromey.com>
2593
2594         * symmisc.c (print_objfile_statistics, dump_objfile)
2595         (maintenance_print_symbols): Use compunit_filetabs.
2596         * source.c (forget_cached_source_info_for_objfile): Use
2597         compunit_filetabs.
2598         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2599         (ALL_FILETABS): Use compunit_filetabs.
2600         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2601         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2602
2603 2019-01-09  Tom Tromey  <tom@tromey.com>
2604
2605         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2606         (compunit_filetabs): New.
2607         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2608         compunit_filetabs.
2609         (info_sources_command, make_source_files_completion_list): Remove
2610         declaration.
2611         * symmisc.c (print_objfile_statistics, dump_objfile)
2612         (maintenance_print_symbols): Remove declaration.
2613         (maintenance_info_symtabs): Use compunit_filetabs.
2614         (maintenance_info_line_tables): Likewise.
2615         * source.c (select_source_symtab): Change local variable name.
2616         (forget_cached_source_info_for_objfile): Remove declaration.
2617         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2618         * objfiles.c (objfile_relocate1): Remove declaration.
2619         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2620         declaration.
2621         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2622         * coffread.c (coff_symtab_read): Remove declaration.
2623         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2624         compunit_filetabs.
2625
2626 2019-01-09  Tom Tromey  <tom@tromey.com>
2627
2628         * symtab.c (lookup_objfile_from_block)
2629         (find_pc_sect_compunit_symtab, search_symbols)
2630         (default_collect_symbol_completion_matches_break_on): Use
2631         objfile_compunits.
2632         * objfiles.h (ALL_COMPUNITS): Remove.
2633         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2634         * cp-support.c (add_symbol_overload_list_qualified): Use
2635         objfile_compunits.
2636         * ada-lang.c (ada_collect_symbol_completion_matches)
2637         (ada_add_global_exceptions): Use objfile_compunits.
2638
2639 2019-01-09  Tom Tromey  <tom@tromey.com>
2640
2641         * source.c (select_source_symtab)
2642         (forget_cached_source_info_for_objfile): Remove declaration.
2643         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2644         declaration.
2645         * maint.c (count_symtabs_and_blocks): Remove declaration.
2646         * cp-support.c (add_symbol_overload_list_qualified): Remove
2647         declaration.
2648         * coffread.c (coff_symtab_read): Remove declaration.
2649         * symtab.c (lookup_symbol_in_objfile_symtabs)
2650         (basic_lookup_transparent_type_1): Use objfile_compunits.
2651         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2652         (info_sources_command, search_symbols)
2653         (default_collect_symbol_completion_matches_break_on)
2654         (make_source_files_completion_list): Remove declaration.
2655         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2656         (ada_collect_symbol_completion_matches)
2657         (ada_add_global_exceptions): Remove declaration.
2658         * linespec.c (iterate_over_all_matching_symtabs): Use
2659         objfile_compunits.
2660         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2661         (class objfile_compunits): New.
2662         (ALL_COMPUNITS): Use objfile_compunits.
2663         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2664         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2665         objfile_compunits.
2666         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2667
2668 2019-01-09  Tom Tromey  <tom@tromey.com>
2669
2670         * symtab.c (search_symbols)
2671         (default_collect_symbol_completion_matches_break_on): Use
2672         objfile_msymbols.
2673         * ada-lang.c (ada_lookup_simple_minsym)
2674         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2675         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2676         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2677         objfile_msymbols.
2678         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2679         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2680         * objc-lang.c (find_methods): Use objfile_msymbols.
2681         (info_selectors_command, info_classes_command): Likewise.
2682         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2683         * objfiles.h (class objfile_msymbols): New.
2684         (ALL_OBJFILE_MSYMBOLS): Remove.
2685         (ALL_MSYMBOLS): Remove.
2686
2687 2019-01-09  Tom Tromey  <tom@tromey.com>
2688
2689         * common/next-iterator.h (next_adapter): Add Iterator template
2690         parameter.
2691         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2692         (class all_objfiles_safe): New.
2693         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2694         * objfiles.c (put_objfile_before): Update comment.
2695         (add_separate_debug_objfile): Likewise.
2696         (free_all_objfiles): Use all_objfiles_safe.
2697         (objfile_purge_solibs): Likewise.
2698
2699 2019-01-09  Tom Tromey  <tom@tromey.com>
2700
2701         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2702         (expand_symtab_containing_pc, lookup_static_symbol)
2703         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2704         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2705         all_objfiles.
2706         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2707         * breakpoint.c (create_overlay_event_breakpoint)
2708         (create_longjmp_master_breakpoint)
2709         (create_std_terminate_master_breakpoint)
2710         (create_exception_master_breakpoint): Use all_objfiles.
2711         * linux-thread-db.c (try_thread_db_load_from_pdir)
2712         (has_libpthread): Use all_objfiles.
2713         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2714         * linespec.c (iterate_over_all_matching_symtabs)
2715         (search_minsyms_for_name): Use all_objfiles.
2716         * maint.c (maintenance_info_sections): Use all_objfiles.
2717         * main.c (captured_main_1): Use all_objfiles.
2718         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2719         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2720         * guile/scm-pretty-print.c
2721         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2722         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2723         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2724         (maintenance_print_msymbols): Use all_objfiles.
2725         * source.c (select_source_symtab): Use all_objfiles.
2726         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2727         * symfile.c (remove_symbol_file_command)
2728         (expand_symtabs_matching, map_symbol_filenames): Use
2729         all_objfiles.
2730         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2731         all_objfiles.
2732         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2733         * objc-lang.c (find_methods): Use all_objfiles.
2734         * objfiles.c (have_partial_symbols, have_full_symbols)
2735         (have_minimal_symbols, qsort_cmp)
2736         (default_iterate_over_objfiles_in_search_order): Use
2737         all_objfiles.
2738         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2739         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2740         (maintenance_check_psymtabs): Use all_objfiles.
2741         (ALL_PSYMTABS): Remove.
2742         * compile/compile-object-run.c (do_module_cleanup): Use
2743         all_objfiles.
2744         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2745         * cp-support.c (add_symbol_overload_list_qualified): Use
2746         all_objfiles.
2747         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2748         Use all_objfiles.
2749         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2750         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2751         all_objfiles.
2752         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2753         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2754         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2755         Uses all_objfiles.
2756         * solib.c (solib_read_symbols): Use all_objfiles
2757
2758 2019-01-09  Tom Tromey  <tom@tromey.com>
2759
2760         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2761         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2762         all_objfiles.
2763         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2764         * symmisc.c (print_symbol_bcache_statistics)
2765         (print_objfile_statistics, maintenance_print_objfiles)
2766         (maintenance_info_symtabs, maintenance_check_symtabs)
2767         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2768         all_objfiles.
2769         * source.c (forget_cached_source_info): Use all_objfiles.
2770         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2771         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2772         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2773         * objfiles.c (update_section_map): Use all_objfiles.
2774         (shared_objfile_contains_address_p): Likewise.
2775         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2776         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2777
2778 2019-01-09  Tom Tromey  <tom@tromey.com>
2779
2780         * common/next-iterator.h: New file.
2781         * objfiles.h (class all_objfiles): New.
2782         (struct objfile_iterator): New.
2783
2784 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2785
2786         * NEWS: Move the description of the changed "frame", "select-frame",
2787          and "info frame" commands to the Changed commands section.
2788
2789 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2790
2791         * gdbtypes.c (check_stub_method_group): Remove handling of old
2792         mangling schemes.
2793         * linespec.c (find_methods): Likewise.
2794         * stabsread.c (read_member_functions): Likewise.
2795         * valops.c (search_struct_method): Likewise.
2796         (value_struct_elt_for_reference): Likewise.
2797         * NEWS: Mention this change.
2798
2799 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2800
2801         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2802         print_source_lines.
2803         * source.c (print_source_lines_base): Update line number check.
2804         (print_source_lines): New function.
2805         (source_lines_range::source_lines_range): New function.
2806         * source.h (class source_lines_range): New class.
2807         (print_source_lines): New declaration.
2808
2809 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2810
2811         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2812
2813 2019-01-08  Tom Tromey  <tom@tromey.com>
2814             Simon Marchi  <simon.marchi@ericsson.com>
2815
2816         PR gdb/24060
2817         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2818         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2819         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2820         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2821         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2822         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2823
2824 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2825
2826         * source.c (select_source_symtab): Move header comment to
2827         declaration in source.h.
2828         (forget_cached_source_info_for_objfile): Likewise.
2829         (forget_cached_source_info): Likewise.
2830         (identify_source_line): Likewise.
2831         * source.h (identify_source_line): Move declaration from symtab.h
2832         and add comment from source.c
2833         (print_source_lines): Likewise.
2834         (forget_cached_source_info_for_objfile): Likewise.
2835         (forget_cached_source_info): Likewise.
2836         (select_source_symtab): Likewise.
2837         (enum print_source_lines_flag): Move definition from symtab.h.
2838         * symtab.h (identify_source_line): Move declaration to source.h.
2839         (print_source_lines): Likewise.
2840         (forget_cached_source_info_for_objfile): Likewise.
2841         (forget_cached_source_info): Likewise.
2842         (select_source_symtab): Likewise.
2843         (enum print_source_lines_flag): Move definition to source.h.
2844         * tui/tui-hooks.c: Add 'source.h' include.
2845
2846 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2847
2848         * source.c (print_source_lines_base): Handle requests to print
2849         reverse line number sequences, and guard against empty lines
2850         string.
2851
2852 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2853
2854         * source.c (print_source_lines_base): Fix skip of '\r' if next
2855         character is '\n'.
2856
2857 2019-01-06  Tom Tromey  <tom@tromey.com>
2858
2859         * c-exp.y (struct c_parse_state) <macro_original_text,
2860         expansion_obstack>: New member.
2861         (macro_original_text, expansion_obstack): Remove globals.
2862         (scan_macro_expansion, scanning_macro_expansion)
2863         (finished_macro_expansion): Update.
2864         (scan_macro_cleanup): Remove.
2865         (yylex, c_parse): Update.
2866
2867 2019-01-06  Tom Tromey  <tom@tromey.com>
2868
2869         * c-exp.y (struct c_parse_state) <strings>: New member.
2870         (operator_stoken): Update.
2871
2872 2019-01-06  Tom Tromey  <tom@tromey.com>
2873
2874         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2875         (union type_stack_elt) <typelist_val>: Now a pointer to
2876         std::vector.
2877         (type_stack_cleanup): Don't declare.
2878         (push_typelist): Update.
2879         * parse.c (pop_typelist): Return a std::vector.
2880         (push_typelist): Take a std::vector.
2881         (follow_types): Update.  Do not free args.
2882         (type_stack_cleanup): Remove.
2883         * c-exp.y (struct c_parse_state): New.
2884         (cpstate): New global.
2885         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2886         (nonempty_typelist): Update.
2887         (func_mod): Create a new vector.
2888         (c_parse): Create a c_parse_state.
2889         (check_parameter_typelist): Do not delete params.
2890         (function_method): Update.  Do not delete type_list.
2891
2892 2019-01-06  Tom Tromey  <tom@tromey.com>
2893
2894         PR gdb/28155:
2895         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2896         check_typedef.
2897         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2898         (print_return_value): Likewise.
2899
2900 2019-01-05  Tom Tromey  <tom@tromey.com>
2901
2902         * contrib/cleanup_check.py: Remove.
2903         * contrib/gcc-with-excheck: Remove.
2904         * contrib/exsummary.py: Remove.
2905         * contrib/excheck.py: Remove.
2906
2907 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2908
2909         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2910         NULL. Initialize tpprev to NULL instead of assigning it
2911         to NULL on the next statement.
2912         * windows-nat.c (windows_delete_thread): Remove check for
2913         main_thread_id before printing thread exit notifications.
2914         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2915         Remove thread ID check against main_thread_id.
2916         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2917         windows_delete_thread.
2918         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2919
2920 2019-01-04  Tom Tromey  <tom@tromey.com>
2921
2922         * compile/compile.c (_initialize_compile): Use upper case for
2923         metasyntactic variables.
2924         * symmisc.c (_initialize_symmisc): Use upper case for
2925         metasyntactic variables.
2926         * psymtab.c (_initialize_psymtab): Use upper case for
2927         metasyntactic variables.
2928         * demangle.c (demangle_command): Use upper case for metasyntactic
2929         variables.
2930         (_initialize_demangler): Likewise.
2931         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2932         variables.
2933
2934 2019-01-03  Tom Tromey  <tom@tromey.com>
2935
2936         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2937
2938 2019-01-03  Tom Tromey  <tom@tromey.com>
2939
2940         * python/py-symtab.c (salpy_str): Update.
2941         (struct salpy_sal_object) <symtab>: Now a PyObject.
2942         (salpy_dealloc): Update.
2943         (del_objfile_sal): Use gdbpy_ref.
2944
2945 2019-01-03  Tom Tromey  <tom@tromey.com>
2946
2947         * python/py-type.c (convert_field): Use new_reference.  Return
2948         gdbpy_ref.
2949         (make_fielditem): Return gdbpy_ref.
2950         (typy_fields): Update.
2951         (typy_getitem): Update.
2952         (field_name): Return gdbpy_ref.  Use new_reference.
2953         (typy_iterator_iternext): Update.
2954
2955 2019-01-03  Tom Tromey  <tom@tromey.com>
2956
2957         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2958
2959 2019-01-03  Tom Tromey  <tom@tromey.com>
2960
2961         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2962         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2963         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2964         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2965         (pspy_set_type_printers): Likewise.
2966         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2967         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2968         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2969         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2970         (objfpy_set_type_printers): Likewise.
2971
2972 2019-01-03  Tom Tromey  <tom@tromey.com>
2973
2974         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2975         (gdbpy_print_stack): Use gdbpy_err_fetch.
2976         * python/python-internal.h (class gdbpy_err_fetch): New class.
2977         (class gdbpy_enter) <m_error_type, m_error_value,
2978         m_error_traceback>: Remove.
2979         <m_error>: New member.
2980         (gdbpy_exception_to_string): Don't declare.
2981         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2982         * python/py-value.c (convert_value_from_python): Use
2983         gdbpy_err_fetch.
2984         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2985         gdbpy_exception_to_string.
2986         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2987         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2988         gdbpy_err_fetch.
2989
2990 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * linux-nat.c (delete_lwp_cleanup): Delete.
2993         (struct lwp_deleter): New struct.
2994         (lwp_info_up): New typedef.
2995         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2996         lwp_info_up.
2997
2998 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2999
3000         * linux-fork.c (class scoped_switch_fork_info): New class.
3001         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3002
3003 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * valops.c (find_overload_match): Remove use of null_cleanup, and
3006         calls to do_cleanups.
3007
3008 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * compile/compile-cplus-types.c
3011         (compile_cplus_instance::decl_name): Handle changes to
3012         cp_func_name.
3013         * cp-support.c (cp_func_name): Update header comment, update
3014         return type.
3015         * cp-support.h (cp_func_name): Update return type in declaration.
3016         * valops.c (find_overload_match): Move temp_func local to top
3017         level of function and change its type.  Use temp_func to hold and
3018         delete temporary string obtained from cp_func_name.
3019
3020 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3021
3022         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3023         gdb::char_vector, remove cleanup, and update uses of `msg`.
3024
3025 2019-01-03  Jim Wilson  <jimw@sifive.com>
3026
3027         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3028
3029 2019-01-02  Tom Tromey  <tom@tromey.com>
3030
3031         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3032         (tdesc_parse_xml): Remove cleanups.
3033         * target-descriptions.h (make_cleanup_free_target_description):
3034         Don't declare.
3035         (target_desc_deleter): New struct.
3036         (target_desc_up): New typedef.
3037         * target-descriptions.c (target_desc_deleter::operator()): Rename
3038         from free_target_description.
3039         (make_cleanup_free_target_description): Remove.
3040
3041 2019-01-02  Tom Tromey  <tom@tromey.com>
3042
3043         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3044         constructor, destructor.
3045         (linespec_parser): Remove typedef.
3046         (~linespec_parser): Rename from linespec_parser_delete.
3047         (linespec_lex_to_end, linespec_complete_label)
3048         (linespec_complete): Update.
3049         (decode_line_full): Remove cleanups.
3050         (decode_line_1): Update.
3051
3052 2019-01-02  Tom Tromey  <tom@tromey.com>
3053
3054         * python/python-internal.h (inferior_to_inferior_object): Change
3055         return type.
3056         * python/py-exitedevent.c (create_exited_event_object): Update.
3057         * python/py-inferior.c (inferior_to_inferior_object): Return
3058         gdbpy_ref.
3059         (python_new_inferior, python_inferior_deleted)
3060         (thread_to_thread_object, delete_thread_object)
3061         (build_inferior_list, gdbpy_selected_inferior): Update.
3062         * python/py-infthread.c (create_thread_object): Update.  Also fail
3063         if inferior_to_inferior_object fails.
3064
3065 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3066
3067         * inferior.h (class inferior) <displaced_step_state>: New field.
3068         * infrun.h (struct displaced_step_state): Move here from
3069         infrun.c.  Initialize fields, add constructor.
3070         <inf>: Remove field.
3071         <reset>: New method.
3072         * infrun.c (struct displaced_step_inferior_state): Move to
3073         infrun.h.
3074         (displaced_step_inferior_states): Remove.
3075         (get_displaced_stepping_state): Adust.
3076         (displaced_step_in_progress_any_inferior): Adjust.
3077         (displaced_step_in_progress_thread): Adjust.
3078         (displaced_step_in_progress): Adjust.
3079         (add_displaced_stepping_state): Remove.
3080         (get_displaced_step_closure_by_addr): Adjust.
3081         (remove_displaced_stepping_state): Remove.
3082         (infrun_inferior_exit): Call displaced_step_state.reset.
3083         (use_displaced_stepping): Don't check for NULL.
3084         (displaced_step_prepare_throw): Call
3085         get_displaced_stepping_state.
3086         (displaced_step_fixup): Don't check for NULL.
3087         (prepare_for_detach): Don't check for NULL.
3088
3089 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3090
3091         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3092          in case of call that did not complete.
3093
3094 2019-01-02  Andrey Utkin  <autkin@undo.io>
3095
3096         * symfile.c (find_separate_debug_file): Fix search of debug files for
3097         remote debuggee.
3098
3099 2019-01-02  Tom Tromey  <tom@tromey.com>
3100
3101         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3102         indentation.
3103         * python/py-frame.c (frapy_older): Remove cast.
3104         (frapy_newer): Likewise.
3105         * python/py-breakpoint.c (local_setattro): Remove cast.
3106         * python/py-arch.c (archpy_name): Remove local variable.
3107         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3108
3109 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3110
3111         * unittests/basic_string_view/element_access/char/empty.cc:
3112         Fix year range in copyright header.
3113
3114 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3115
3116         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3117         Delete.
3118         <operator==>: Update with for removed field.
3119         <hash>: Likewise.
3120         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3121         <isa_features>: ...this.
3122         <abi_features>: New field.
3123         (riscv_isa_flen): Update comment.
3124         (riscv_abi_xlen): New declaration.
3125         (riscv_abi_flen): New declaration.
3126         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3127         isa_features.
3128         (riscv_abi_xlen): New function.
3129         (riscv_isa_flen): Update to get answer from isa_features.
3130         (riscv_abi_flen): New function.
3131         (riscv_has_fp_abi): Update to get answer from abi_features.
3132         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3133         xlen and flen.
3134         (riscv_call_info) <xlen, flen>: Update comment.
3135         (riscv_call_arg_struct): Remove invalid assertions
3136         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3137         is removed.
3138         (riscv_gdbarch_init): Gather isa features and abi features
3139         separately, ensure both match on the gdbarch when reusing an old
3140         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3141         a target with 64-bit float hardware.
3142
3143 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3144
3145         * source.c (search_command_helper): Stop reverse search
3146         when line 1 has been searched.
3147
3148 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3149
3150         * record-full.c (record_full_base_target::close): Rewrite
3151         record_full_core_buf_list free logic.
3152
3153 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3154
3155         * break-catch-syscall.c (print_one_catch_syscall): xfree
3156         the last text.
3157
3158 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3159
3160         * top.c (print_gdb_version): Update Copyright year in version
3161         message.
3162
3163 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3164
3165         Update copyright year range in all GDB files.
3166
3167 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3168
3169         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3170
3171 For older changes see ChangeLog-2018.
3172 \f
3173 Local Variables:
3174 mode: change-log
3175 left-margin: 8
3176 fill-column: 74
3177 version-control: never
3178 coding: utf-8
3179 End:
3180