gdb/ChangeLog

   1 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
   2
   3         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
   4         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
   5         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
   6         'body' is NULL to the outter 'if', protecting the '!is_define'
   7         situation as well.
   8
   9 2019-05-29  Tom Tromey  <tromey@adacore.com>
  10
  11         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
  12         (dwarf_unknown): New function.
  13         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
  14         (dwarf_type_encoding_name): Use dwarf_unknown.
  15
  16 2019-05-29  Tom Tromey  <tromey@adacore.com>
  17
  18         PR c++/20020:
  19         * cp-valprint.c (cp_print_value_fields): Call
  20         cp_print_static_field inside "try".
  21
  22 2019-05-29  Tom Tromey  <tromey@adacore.com>
  23
  24         * inflow.c (struct terminal_info): Add default operator=.
  25         * configure: Rebuild.
  26         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
  27         -Wdeprecated-copy-dtor, -Wredundant-move.
  28
  29 2019-05-29  Tom Tromey  <tromey@adacore.com>
  30
  31         * NEWS: Add entry.
  32         * infcmd.c (print_return_value_1): Handle finish_print
  33         option.
  34         (show_print_finish): New function.
  35         (_initialize_infcmd): Add "set/show print finish" commands.
  36         * valprint.c (user_print_options): Initialize new member.
  37         * valprint.h (struct value_print_options) <finish_print>: New
  38         member.
  39
  40 2019-05-28  Tom Tromey  <tromey@adacore.com>
  41
  42         * ada-lang.c (ada_remove_Xbn_suffix)
  43         (find_old_style_renaming_symbol)
  44         (parse_old_style_renaming): Remove.
  45         (ada_find_renaming_symbol): Don't call
  46         find_old_style_renaming_symbol.
  47         (ada_is_renaming_symbol): Rename from
  48         ada_find_renaming_symbol.  Remove "block" parameter.  Return
  49         bool.  Now static.
  50         (ada_read_var_value): Update and simplify.
  51         * ada-exp.y (write_var_or_type): Remove old code.
  52
  53 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
  54
  55         * event-top.c: Remove include comment.
  56         * inflow.c (class scoped_ignore_sigttou): Move from here...
  57         * inflow.h (class scoped_ignore_sigttou): ...to here.
  58         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
  59         * top.c:  Remove include comment.
  60
  61 2019-05-27  Tom Tromey  <tom@tromey.com>
  62
  63         * NEWS: Fix typo.
  64
  65 2019-05-22  Tom Tromey  <tromey@adacore.com>
  66
  67         * target.c (target_follow_exec): Constify parameter.
  68         * target-delegates.c: Rebuild.
  69         * remote.c (remote_target::follow_exec): Constify parameter.
  70         * infrun.c (follow_exec): Constify parameter.
  71         * target.h (struct target_ops) <follow_exec>: Constify parameter.
  72         (target_follow_exec): Likewise.
  73
  74 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  75
  76         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
  77         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
  78
  79 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
  80
  81         * NEWS: Add debugredirect and testsuite sections.
  82
  83 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
  84
  85         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
  86         target descriptions using exclusively floating point register name
  87         aliases.
  88
  89 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  90
  91         PR gdb/18644:
  92         * f-lang.c (build_fortran_types): Handle the case where
  93         gdbarch_floatformat_for_type returns a nullptr.
  94
  95 2019-05-21  Tom de Vries  <tdevries@suse.de>
  96
  97         PR cli/24587
  98         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
  99
 100 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 101
 102         PR gdb/18644:
 103         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 104         16-byte floats.
 105         * i386-tdep.c (i386_floatformat_for_type): Use
 106         floatformats_ia64_quad for the 16-byte floating point component
 107         within a fortran 32-byte complex number.
 108
 109 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 110
 111         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 112         delete default constructor.
 113         (find_partial_die): Update to return const struct.
 114         (partial_die_parent_scope): Move variable declaration into scope
 115         of its use and change its type to auto.
 116         (guess_partial_die_structure_name): Likewise.
 117         (partial_die_info::fixup): Likewise.
 118
 119 2019-05-17  Tom Tromey  <tromey@adacore.com>
 120
 121         * source.c (find_and_open_source): Remove cast.
 122
 123 2019-05-17  Tom Tromey  <tromey@adacore.com>
 124
 125         * annotate.c (annotate_source): Make "filename" const.
 126         * annotate.h (annotate_source): Use const.
 127
 128 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 129
 130         * disasm.c (set_disassembler_options): Send errors to stderr.
 131
 132 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 133
 134         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 135         (cli_interp_base::set_logging): Check debug_redirect.
 136         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 137         * cli/cli-logging.c (debug_redirect): Add static variable.
 138         (pop_output_files): Add default param.
 139         (handle_redirections): Print debug setting.
 140         (show_logging_command): Likewise.
 141         (_initialize_cli_logging): Add debugredirect command.
 142         * interps.c (current_interp_set_logging): Add debug_redirect
 143         parameter.
 144         * interps.h (set_logging): Add debug_redirect parameter.
 145         (current_interp_set_logging): Likewise.
 146         * mi/mi-common.h: Likewise.
 147         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 148
 149 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 150             Tom Tromey  <tromey@adacore.com>
 151
 152         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 153         directly.
 154         * cli/cli-interp.h (make_logging_output): Remove declaration.
 155         * cli/cli-logging.c (make_logging_output): Remove function.
 156         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 157         directly.
 158         * ui-file.c (tee_file::tee_file): Remove bools.
 159         (tee_file::~tee_file): Remove deletes.
 160         * ui-file.h (tee_file): Remove bools.
 161
 162 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 163
 164         * mi/mi-cmds.h (mi_cmd_complete): New function.
 165         * mi/mi-main.c (mi_cmd_complete): Likewise.
 166         * mi/mi-cmds.c: Define new MI command -complete.
 167         * NEWS: Mention new -complete command.
 168
 169 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 170
 171         * completer.h (complete): New function.
 172         * completer.c (complete): Likewise.
 173         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 174         function defined in completer.h.
 175
 176 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 177
 178        * MAINTAINERS (Write After Approval): Add myself.
 179
 180 2019-05-17  Tom de Vries  <tdevries@suse.de>
 181
 182         PR gdb/24094
 183         * dwarf2read.c (struct cu_partial_die_info): New struct.
 184         (find_partial_die): Return cu_partial_die_info.
 185         (partial_die_parent_scope, guess_partial_die_structure_name)
 186         (partial_die_info::fixup): Handle new return type of find_partial_die.
 187
 188 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 189
 190         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 191         "std::string", simplifying the algorithm.
 192
 193 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 194
 195         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 196         (stap_static_probe_ops::get_probes): Likewise.
 197
 198 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 199
 200         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 201         '-')" and "else if".
 202         (stap_parse_single_operand): Join checks for
 203         "gdbarch_stap_parse_special_token_p" and
 204         "gdbarch_stap_parse_special_token" in the same "if" statement.
 205         Invert check when verifying for operation on register
 206         displacement.
 207
 208 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 209
 210         * stap-probe.c (stap_get_opcode): Update comment.
 211         (stap_get_expected_argument_type): Likewise.
 212         (handle_stap_probe): Likewise.
 213
 214 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 215
 216         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 217         return type to 'bool'.  Adjust comment.  Use 'bool' when
 218         appropriate.
 219         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 220         * stap-probe.c (stap_parse_argument_1): Likewise.
 221         (stap_is_operator): Likewise.
 222         (stap_is_generic_prefix): Likewise.
 223         (stap_is_register_prefix): Likewise.
 224         (stap_is_register_indirection_prefix): Likewise.
 225         (stap_is_integer_prefix): Likewise.
 226         (stap_generic_check_suffix): Likewise.
 227         (stap_check_integer_suffix): Likewise.
 228         (stap_check_register_suffix): Likewise.
 229         (stap_check_register_indirection_suffix): Likewise.
 230         (stap_parse_register_operand): Likewise.
 231         (stap_parse_single_operand): Likewise.
 232         (stap_parse_argument_1): Likewise.
 233         (stap_probe::get_argument_count): Likewise.
 234         (stap_is_operator): Likewise.
 235
 236 2019-05-16  Tom Tromey  <tromey@adacore.com>
 237
 238         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 239         keyword to foreach.
 240
 241 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 242
 243         * linux-thread-db.c (try_thread_db_load_1): Change return type
 244         to bool.
 245         (try_thread_db_load): Likewise.
 246         (try_thread_db_load_from_pdir_1): Likewise.
 247         (try_thread_db_load_from_pdir): Likewise.
 248         (try_thread_db_load_from_sdir): Likewise.
 249         (try_thread_db_load_from_dir): Likewise.
 250         (thread_db_load_search): Likewise.
 251         (has_libpthread): Likewise.
 252         (thread_db_load): Likewise.
 253
 254 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 255
 256         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 257         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 258         NULL, and complain/return if that's the case.
 259
 260 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 261
 262         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 263         (advance, posn, abstract_read_memory): New functions.
 264         [struct mem_read_abstraction]: New struct.
 265         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 266
 267 2019-05-14  Tom Tromey  <tromey@adacore.com>
 268
 269         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 270         value is not lval_memory.
 271
 272 2019-05-14  Tom Tromey  <tromey@adacore.com>
 273
 274         * solib.c (info_sharedlibrary_command): Style the file name.
 275
 276 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 277
 278         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 279         (aarch64_vnv_type): Likewise.
 280         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 281         * common/tdesc.c: Likewise.
 282         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 283         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 284         * features/aarch64-fpu.xml: Add ieee half view.
 285         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 286         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 287         * gdbtypes.h (struct builtin_type): Likewise.
 288         (struct objfile_type): Likewise.
 289
 290 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 291
 292         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 293         typo.
 294         * location.h (string_to_event_location): Likewise.
 295
 296 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 297
 298         GDB 8.3 released.
 299
 300 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 301
 302         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 303         New variable declaration.
 304         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 305         New variable.
 306         (print_one_breakpoint): Use ui_out::test_flags and new global
 307         variable to compute use_fixed_output.
 308         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 309         Remove.
 310         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 311         (mi_multi_location_breakpoint_output_fixed): Remove.
 312         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 313         new variable.
 314         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 315         fix_multi_location_breakpoint_output flag if version >= 3.
 316         * ui-out.h (enum ui_out_flag)
 317         <fix_multi_location_breakpoint_output>: New enumerator.
 318
 319 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 320
 321         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 322
 323 2019-05-10  Tom Tromey  <tromey@adacore.com>
 324
 325         * ada-lang.c (catch_ada_completer): New function.
 326         (_initialize_ada_language): Use it.
 327
 328 2019-05-10  Tom Tromey  <tromey@adacore.com>
 329
 330         * thread.c (print_thread_info): Make "requested_threads" const.
 331         * gdbthread.h (print_thread_info): Make "requested_threads"
 332         const.
 333         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 334         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 335
 336 2019-05-08  Tom Tromey  <tom@tromey.com>
 337
 338         * gdbtypes.c (objfile_type_data): Change type.
 339         (objfile_type, _initialize_gdbtypes): Update.
 340
 341 2019-05-08  Tom Tromey  <tom@tromey.com>
 342
 343         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 344         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 345         (_initialize_dwarf2_frame): Update.
 346
 347 2019-05-08  Tom Tromey  <tom@tromey.com>
 348
 349         * objc-lang.c (objc_objfile_data): Change type.
 350         (find_methods): Update.
 351         (_initialize_objc_lang): Remove.
 352
 353 2019-05-08  Tom Tromey  <tom@tromey.com>
 354
 355         * stabsread.c (rs6000_builtin_type_data): Change type.
 356         (rs6000_builtin_type, _initialize_stabsread): Update.
 357
 358 2019-05-08  Tom Tromey  <tom@tromey.com>
 359
 360         * mips-tdep.c (mips_pdr_data): Remove.
 361         (_initialize_mips_tdep): Update.
 362
 363 2019-05-08  Tom Tromey  <tom@tromey.com>
 364
 365         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 366         (hppa_init_objfile_priv_data, read_unwind_info)
 367         (find_unwind_entry, _initialize_hppa_tdep): Update.
 368
 369 2019-05-08  Tom Tromey  <tom@tromey.com>
 370
 371         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 372         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 373         on obstack.
 374         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 375
 376 2019-05-08  Tom Tromey  <tom@tromey.com>
 377
 378         * mdebugread.c (basic_type_data): Change type.
 379         (basic_type, _initialize_mdebugread): Update.
 380
 381 2019-05-08  Tom Tromey  <tom@tromey.com>
 382
 383         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 384
 385 2019-05-08  Tom Tromey  <tom@tromey.com>
 386
 387         * nto-tdep.c (nto_inferior_data_reg): Change type.
 388         (nto_inferior_data): Update.
 389         (nto_inferior_data_cleanup, nto_new_inferior_data)
 390         (_initialize_nto_tdep): Remove.
 391         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 392
 393 2019-05-08  Tom Tromey  <tom@tromey.com>
 394
 395         * ada-lang.c (struct ada_inferior_data): Add initializers.
 396         (ada_inferior_data): Change type.
 397         (ada_inferior_data_cleanup): Remove.
 398         (get_ada_inferior_data, ada_inferior_exit)
 399         (struct ada_pspace_data): Add initializers, destructor.
 400         (ada_pspace_data_handle): Change type.
 401         (get_ada_pspace_data): Update.
 402         (ada_pspace_data_cleanup): Remove.
 403
 404 2019-05-08  Tom Tromey  <tom@tromey.com>
 405
 406         * coffread.c (struct coff_symfile_info): Add initializers.
 407         (coff_objfile_data_key): Move lower.  Change type.
 408         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 409         Update.
 410         (coff_free_info): Remove.
 411
 412 2019-05-08  Tom Tromey  <tom@tromey.com>
 413
 414         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 415         (fbsd_pspace_data_handle): Move lower.  Change type.
 416         (get_fbsd_pspace_data): Update.
 417         (fbsd_pspace_data_cleanup): Remove.
 418         (_initialize_fbsd_tdep): Update.
 419
 420 2019-05-08  Tom Tromey  <tom@tromey.com>
 421
 422         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 423         (get_ada_tasks_pspace_data): Update.
 424         (ada_tasks_pspace_data_cleanup): Remove.
 425         (_initialize_tasks): Update.
 426         (ada_tasks_inferior_data_handle): Change type.
 427         (get_ada_tasks_inferior_data): Update.
 428         (ada_tasks_inferior_data_cleanup): Remove.
 429         (struct ada_tasks_pspace_data): Add initializers.
 430
 431 2019-05-08  Tom Tromey  <tom@tromey.com>
 432
 433         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 434         * symfile-debug.c (debug_sym_get_probes): Change type.
 435         * stap-probe.c (handle_stap_probe):
 436         (stap_static_probe_ops::get_probes): Change type.
 437         * probe.h (class static_probe_ops) <get_probes>: Change type.
 438         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 439         (parse_probes_in_pspace): Update.
 440         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 441         Update.
 442         (any_static_probe_ops::get_probes): Change type.
 443         * elfread.c (elfread_data): New typedef.
 444         (probe_key): Change type.
 445         (elf_get_probes): Likewise.  Update.
 446         (probe_key_free): Remove.
 447         (_initialize_elfread): Update.
 448         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 449         Change type.
 450         (dtrace_process_dof_probe, dtrace_process_dof)
 451         (dtrace_static_probe_ops::get_probe): Change type.
 452
 453 2019-05-08  Tom Tromey  <tom@tromey.com>
 454
 455         * xcoffread.c (struct xcoff_symfile_info): Rename from
 456         coff_symfile_info.  Add initializers.
 457         (xcoff_objfile_data_key): Move lower.  Change type.
 458         (XCOFF_DATA): Rewrite.
 459         (xcoff_free_info): Remove.
 460         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 461         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 462         (xcoff_initial_scan): Update.
 463
 464 2019-05-08  Tom Tromey  <tom@tromey.com>
 465
 466         * solib-svr4.c (struct svr4_info): Add initializers and
 467         destructor.
 468         <probes_table>: Now an htab_up.
 469         (solib_svr4_pspace_data): Change type.
 470         (free_probes_table): Simplify.
 471         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 472         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 473         (probes_table_remove_objfile_probes, register_solib_event_probe)
 474         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 475         (_initialize_svr4_solib): Update.
 476
 477 2019-05-08  Tom Tromey  <tom@tromey.com>
 478
 479         * remote.c (remote_pspace_data): Change type.
 480         (remote_pspace_data_cleanup): Remove.
 481         (get_remote_exec_file, set_pspace_remote_exec_file)
 482         (_initialize_remote): Update.
 483
 484 2019-05-08  Tom Tromey  <tom@tromey.com>
 485
 486         * breakpoint.c (breakpoint_objfile_key): Change type.
 487         (get_breakpoint_objfile_data): Update.
 488         (free_breakpoint_objfile_data): Remove.
 489         (_initialize_breakpoint): Update.
 490
 491 2019-05-08  Tom Tromey  <tom@tromey.com>
 492
 493         * linux-tdep.c (struct linux_info): Add initializers.
 494         (linux_inferior_data): Move.  Change type.
 495         (invalidate_linux_cache_inf): Update.
 496         (linux_inferior_data_cleanup): Remove.
 497         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 498
 499 2019-05-08  Tom Tromey  <tom@tromey.com>
 500
 501         * auxv.c (auxv_inferior_data): Move.  Change type.
 502         (auxv_inferior_data_cleanup): Remove.
 503         (invalidate_auxv_cache_inf): Rewrite.
 504         (get_auxv_inferior_data, _initialize_auxv): Update.
 505
 506 2019-05-08  Tom Tromey  <tom@tromey.com>
 507
 508         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 509         (symfile_debug_objfile_data_key): Change type.
 510         (symfile_debug_installed, debug_qf_has_symbols)
 511         (debug_qf_find_last_source_symtab)
 512         (debug_qf_forget_cached_source_info)
 513         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 514         (debug_qf_print_stats, debug_qf_dump)
 515         (debug_qf_expand_symtabs_for_function)
 516         (debug_qf_expand_all_symtabs)
 517         (debug_qf_expand_symtabs_with_fullname)
 518         (debug_qf_map_matching_symbols)
 519         (debug_qf_expand_symtabs_matching)
 520         (debug_qf_find_pc_sect_compunit_symtab)
 521         (debug_qf_map_symbol_filenames)
 522         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 523         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 524         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 525         (debug_sym_read_linetable, debug_sym_relocate): Update.
 526         (symfile_debug_free_objfile): Remove.
 527         (install_symfile_debug_logging, _initialize_symfile_debug):
 528         Update.
 529
 530 2019-05-08  Tom Tromey  <tom@tromey.com>
 531
 532         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 533         allocate_on_obstack.
 534         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 535         (get_dwarf2_per_objfile): Update.
 536         (set_dwarf2_per_objfile): Remove.
 537         (dwarf2_has_info, dwarf2_get_section_info): Update.
 538         (dwarf2_free_objfile): Remove.
 539         (_initialize_dwarf2_read): Update.
 540
 541 2019-05-08  Tom Tromey  <tom@tromey.com>
 542
 543         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 544         initializers.
 545         <unsupported_script_warning_printed,
 546         script_not_found_warning_printed>: Now bool.
 547         (auto_load_pspace_data): Change type.
 548         (~auto_load_pspace_info): Rename from
 549         auto_load_pspace_data_cleanup.
 550         (get_auto_load_pspace_data, init_loaded_scripts_info)
 551         (clear_section_scripts, maybe_print_unsupported_script_warning)
 552         (maybe_print_script_not_found_warning, _initialize_auto_load):
 553         Update.
 554
 555 2019-05-08  Tom Tromey  <tom@tromey.com>
 556
 557         * objfiles.c (objfile_pspace_info): Add destructor and
 558         initializers.
 559         (objfiles_pspace_data): Change type.
 560         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 561         (get_objfile_pspace_data): Update.
 562         (objfiles_bfd_data): Change type.
 563         (get_objfile_bfd_data): Update.
 564         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 565
 566 2019-05-08  Tom Tromey  <tom@tromey.com>
 567
 568         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 569         Change type.
 570         (get_catch_syscall_inferior_data): Update.
 571         (catch_syscall_inferior_data_cleanup): Remove.
 572         (_initialize_break_catch_syscall): Update.
 573
 574 2019-05-08  Tom Tromey  <tom@tromey.com>
 575
 576         * inflow.c (struct terminal_info): Add destructor and
 577         initializers.
 578         (inflow_inferior_data): Change type.
 579         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 580         (get_inflow_inferior_data, inflow_inferior_exit)
 581         (swap_terminal_info, _initialize_inflow): Update.
 582
 583 2019-05-08  Tom Tromey  <tom@tromey.com>
 584
 585         * target-dcache.c (target_dcache_cleanup): Remove.
 586         (target_dcache_aspace_key): Change type.
 587         (target_dcache_init_p, target_dcache_invalidate)
 588         (target_dcache_get, target_dcache_get_or_init)
 589         (_initialize_target_dcache): Update.
 590         * dcache.h (struct dcache_deleter): New.
 591
 592 2019-05-08  Tom Tromey  <tom@tromey.com>
 593
 594         * symtab.c (struct symbol_cache): Add destructor and
 595         initializers.
 596         (symbol_cache_key): Move.  Change type.
 597         (make_symbol_cache, free_symbol_cache): Remove.
 598         (get_symbol_cache): Update.
 599         (symbol_cache_cleanup): Remove.
 600         (ALL_PSPACES, symbol_cache_flush)
 601         (maintenance_print_symbol_cache)
 602         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 603         Update.
 604
 605 2019-05-08  Tom Tromey  <tom@tromey.com>
 606
 607         * symtab.c (struct main_info): Add destructor and initializers.
 608         (main_progspace_key): Move.  Change type.
 609         (get_main_info): Update.
 610         (main_info_cleanup): Remove.
 611         (_initialize_symtab): Update.
 612
 613 2019-05-08  Tom Tromey  <tom@tromey.com>
 614
 615         * registry.h (DECLARE_REGISTRY): Define the _key class.
 616
 617 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 618
 619         * NEWS: Merge two 'New commands' sections.
 620
 621 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 622
 623         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 624         parameter and use Ada language definition instead.
 625         (ada_val_print_ptr): Remove unused language parameter.
 626         (ada_val_print_num): Remove language parameter and use Ada language
 627         definition instead.
 628         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 629         parameter.
 630         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 631         parameter and use Ada language definition instead.
 632         (ada_val_print_1): Update all ada_val_print_xxx calls.
 633         Remove language parameter.
 634         (ada_val_print): Update ada_val_print_1 call.
 635
 636 2019-05-08  Tom Tromey  <tromey@adacore.com>
 637
 638         * remote.c (remote_hw_watchpoint_limit)
 639         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 640         Now static.
 641
 642 2019-05-08  Tom Tromey  <tromey@adacore.com>
 643
 644         * maint.c (_initialize_maint_cmds): Move initialization code to
 645         remote.c.
 646         (watchdog, show_watchdog): Move to remote.c.
 647         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 648         "watchdog" static.
 649         (_initialize_remote): Move initialization code from maint.c.
 650         * defs.h (watchdog): Don't declare.
 651
 652 2019-05-08  Tom Tromey  <tromey@adacore.com>
 653
 654         * tui/tui-interp.c: Include main.h.
 655         * interps.c: Include main.h.
 656         * main.h (interpreter_p): Declare.
 657         * defs.h (interpreter_p): Don't declare.
 658
 659 2019-05-08  Tom Tromey  <tromey@adacore.com>
 660
 661         * dwarf2loc.c: Include dwarf2read.h.
 662         * defs.h (read_unsigned_leb128): Don't declare.
 663         * dwarf2read.h (read_unsigned_leb128): Declare.
 664
 665 2019-05-08  Tom Tromey  <tromey@adacore.com>
 666
 667         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 668         method.
 669
 670 2019-05-08  Tom Tromey  <tromey@adacore.com>
 671
 672         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 673         when no wrap column is set.
 674
 675 2019-05-08  Tom Tromey  <tromey@adacore.com>
 676
 677         * c-lang.c (c_get_string): Handle non-C-style arrays.
 678
 679 2019-05-08  Tom Tromey  <tromey@adacore.com>
 680
 681         * typeprint.c (print_offset_data::update): Print the bit offset,
 682         not the number of bits remaining.
 683
 684 2019-05-08  Tom Tromey  <tromey@adacore.com>
 685
 686         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 687         padding at end of comment.
 688
 689 2019-05-08  Tom Tromey  <tromey@adacore.com>
 690
 691         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 692         Compare main types.
 693
 694 2019-05-06  Tom Tromey  <tom@tromey.com>
 695
 696         * common/scoped_mmap.c: Include common-defs.h.
 697         * common/scoped_mmap.h: Don't include config.h.
 698
 699 2019-05-04  Tom Tromey  <tom@tromey.com>
 700
 701         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 702         (struct aarch64_call_info): Add initializers.
 703         <si>: Now a std::vector.
 704         (pass_on_stack, aarch64_push_dummy_call): Update.
 705
 706 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 707             Tom Tromey  <tom@tromey.com>
 708
 709         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 710         (ppc_threads): Now a std::vector.  Now static.
 711         (hwdebug_find_thread_points_by_tid)
 712         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 713         Update.
 714
 715 2019-05-04  Tom Tromey  <tom@tromey.com>
 716
 717         * arc-tdep.c (arc_tdesc_init): Return bool.
 718
 719 2019-05-04  Tom Tromey  <tom@tromey.com>
 720
 721         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 722         Use gdb_assert_not_reached.
 723
 724 2019-05-04  Tom Tromey  <tom@tromey.com>
 725
 726         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 727         "false".
 728
 729 2019-05-04  Tom Tromey  <tom@tromey.com>
 730
 731         * arc-tdep.c (arc_tdesc_init): Use bool.
 732
 733 2019-05-04  Tom Tromey  <tom@tromey.com>
 734
 735         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 736
 737 2019-05-04  Tom Tromey  <tom@tromey.com>
 738
 739         * cli/cli-cmds.c (valid_command_p): Return bool.
 740
 741 2019-05-04  Tom Tromey  <tom@tromey.com>
 742
 743         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 744         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 745
 746 2019-05-04  Raul Tambre  <raul@tambre.ee>
 747
 748         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 749         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 750         operator for comparison.
 751
 752 2019-05-04  Tom Tromey  <tom@tromey.com>
 753
 754         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 755         (lookup_partial_symbol, print_partial_symbols)
 756         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 757         (psymbol_compare): Update.
 758         (add_psymbol_to_bcache): Clear the entire psymbol.
 759         (maintenance_check_psymtabs): Update.
 760         * psympriv.h (struct partial_symbol): Don't derive from
 761         general_symbol_info.
 762         <obj_section, unrelocated_address, address,
 763         set_unrelocated_address>: Update.
 764         <ginfo>: New member.
 765         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 766         (debug_names::write_psymbols): Update.
 767
 768 2019-05-04  Tom de Vries  <tdevries@suse.de>
 769
 770         * contrib/cc-with-tweaks.sh: Support -n arg.
 771
 772 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 773
 774         * corelow.c (core_target::detach): Ensure frame cache and
 775         register caches are cleared.
 776         inferior.c (exit_inferior_1): Likewise.
 777
 778 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 779             Tom Tromey  <tom@tromey.com>
 780
 781         * dictionary.c (collate_pending_symbols_by_language): Remove
 782         "struct" from foreach.
 783         * symtab.c (lookup_global_symbol_from_objfile)
 784         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 785         foreach.
 786         * ser-tcp.c (net_open): Remove "struct" from foreach.
 787         * objfiles.c (objfile_relocate, objfile_rebase)
 788         (objfile_has_symbols): Remove "struct" from foreach.
 789         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 790         from foreach.
 791         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 792         foreach.
 793         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 794         "struct" from foreach.
 795         * ada-lang.c (create_excep_cond_exprs)
 796         (ada_exception_catchpoint_cond_string): Remove "struct" from
 797         foreach.
 798
 799 2019-05-03  Tom Tromey  <tromey@adacore.com>
 800
 801         * ada-exp.y (convert_char_literal): Check suffix of each
 802         enumerator.
 803
 804 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 805
 806         PR ada/21406:
 807         * ada-exp.y (yywrap): Don't define.
 808         * ada-lex.l (%option): Add noyywrap
 809         (yywrap): Remove.
 810
 811 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 812
 813         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 814         _WIN32_WINNT to the XP level, unless already defined to a higher
 815         level.
 816
 817         * unittests/parse-connection-spec-selftests.c:
 818         * ser-tcp.c:
 819         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 820         override.
 821
 822         * symfile.c (find_separate_debug_file): Remove colon from the
 823         drive spec of DOS/Windows file names of the target, so that the
 824         file name produced from DEBUGDIR and the target's directory will
 825         be valid on DOS/Windows systems.
 826
 827 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * rust-lang.c (val_print_struct): Handle printing structures
 830         containing strings.
 831
 832 2019-05-02  Tom Tromey  <tromey@adacore.com>
 833
 834         * valarith.c (_initialize_valarith): Remove.
 835
 836 2019-05-01  Tom Tromey  <tromey@adacore.com>
 837
 838         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 839         bitfields.
 840
 841 2019-05-01  Tom Tromey  <tromey@adacore.com>
 842
 843         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 844         for big-endian copies.
 845
 846 2019-04-30  Ali Tamur  <tamur@google.com>
 847         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 848         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 849         (read_3_bytes): New function.
 850
 851 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 852
 853         * windows-nat.c (main_thread_id): Delete.
 854         (handle_output_debug_string): Replace main_thread_id by
 855         current_event.dwThreadId.
 856         (fake_create_process): Likewise.
 857         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 858         Do not set main_thread_id.
 859         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 860         current_event.dwThreadId.
 861         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 862
 863 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 864
 865         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 866         Use current_event.dwThreadId instead of main_thread_id.
 867
 868 2019-04-30  Tom Tromey  <tromey@adacore.com>
 869
 870         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 871         (create_excep_cond_exprs): Iterate over program spaces.
 872         (ada_exception_catchpoint_cond_string): Examine all minimal
 873         symbols for exception types.
 874
 875 2019-04-30  Tom Tromey  <tromey@adacore.com>
 876
 877         PR c++/24470:
 878         * dwarf2read.c (process_structure_scope): Handle case where type
 879         has template parameters but no symbol was created.
 880
 881 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 882             Chris January  <chris.january@arm.com>
 883
 884         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 885         qualifier.
 886         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 887
 888 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 889
 890         * f-typeprint.c (f_print_type): Update rules for printing
 891         whitespace.
 892         (f_type_print_varspec_suffix): Likewise.
 893
 894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 895             Chris January  <chris.january@arm.com>
 896
 897         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 898         function arguments.
 899
 900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * f-lang.c (build_fortran_types): Change name of void type to
 903         lower case.
 904         * f-typeprint.c (f_type_print_base): Print the name of the void
 905         type, rather than a fixed string.
 906         * f-valprint.c (f_decorations): Use lower case void string.
 907
 908 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 909             Chris January  <chris.january@arm.com>
 910
 911         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 912         types for Fortran.
 913
 914 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 915             Chris January  <chris.january@arm.com>
 916             David Lecomber  <david.lecomber@arm.com>
 917
 918         * f-exp.y (BINOP_INTRINSIC): New token.
 919         (exp): New parser rule handling BINOP_INTRINSIC.
 920         (f77_keywords): Add new builtin procedures.
 921         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 922         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 923         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 924         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 925         (print_unop_subexp_f): New function.
 926         (print_binop_subexp_f): New function.
 927         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 928         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 929         (dump_subexp_body_f): Likewise.
 930         (operator_check_f): Likewise.
 931         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 932         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 933
 934 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 937         UNOP_KIND.
 938         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 939         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 940         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 941         (operator_length_f): New fuction.
 942         (print_subexp_f): New function.
 943         (op_name_f): New function.
 944         (dump_subexp_body_f): New function.
 945         (operator_check_f): New function.
 946         (exp_descriptor_f): Replace standard expression handling functions
 947         with new functions.
 948         * gdb/fortran-operator.def: New file.
 949         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 950         * gdb/std-operator.def: Remove UNOP_KIND.
 951
 952 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 953
 954         * std-operator.def: Remove unbalanced, stray double quote
 955         character.
 956
 957 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 958             Chris January  <chris.january@arm.com>
 959             Daniel Everett  <daniel.everett@arm.com>
 960             Nick Forrington  <nick.forrington@arm.com>
 961             Richard Bunt  <richard.bunt@arm.com>
 962
 963         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 964         of depth when printing anonymous structs or unions.
 965         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 966         Don't print either the top-level value, or the children if the
 967         max-depth is exceeded.
 968         (ppscm_print_children): When printing the key of a map, allow one
 969         extra level of depth.
 970         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 971         print either the top-level value, or the children if the max-depth
 972         is exceeded.
 973         (print_children): When printing the key of a map, allow one extra
 974         level of depth.
 975         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 976         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 977         (user_print_options): Initialise max_depth field.
 978         (val_print_scalar_or_string_type_p): New function.
 979         (val_print): Check to see if the max depth has been reached.
 980         (val_print_check_max_depth): Define new function.
 981         (show_print_max_depth): New function.
 982         (_initialize_valprint): Add 'print max-depth' option.
 983         * valprint.h (struct value_print_options) <max_depth>: New field.
 984         (val_print_check_max_depth): Declare new function.
 985         * NEWS: Document new feature.
 986
 987 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 988
 989         * ada-lang.c (ada_language_defn): Initialise new field.
 990         * c-lang.c (c_is_string_type_p): New function.
 991         (c_language_defn): Initialise new field.
 992         (cplus_language_defn): Initialise new field.
 993         (asm_language_defn): Initialise new field.
 994         (minimal_language_defn): Initialise new field.
 995         * c-lang.h (c_is_string_type_p): Declare new function.
 996         * d-lang.c (d_language_defn): Initialise new field.
 997         * f-lang.c (f_is_string_type_p): New function.
 998         (f_language_defn): Initialise new field.
 999         * go-lang.c (go_is_string_type_p): New function.
1000         (go_language_defn): Initialise new field.
1001         * language.c (default_is_string_type_p): New function.
1002         (unknown_language_defn): Initialise new field.
1003         (auto_language_defn): Initialise new field.
1004         * language.h (struct language_defn) <la_is_string_type_p>: New
1005         member variable.
1006         (default_is_string_type_p): Declare new function.
1007         * m2-lang.c (m2_language_defn): Initialise new field.
1008         * objc-lang.c (objc_language_defn): Initialise new field.
1009         * opencl-lang.c (opencl_language_defn): Initialise new field.
1010         * p-lang.c (pascal_is_string_type_p): New function.
1011         (pascal_language_defn): Initialise new field.
1012         * rust-lang.c (rust_is_string_type_p): New function.
1013         (rust_language_defn): Initialise new field.
1014
1015 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1016
1017         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1018         New field.
1019         * ada-lang.c (ada_language_defn): Initialise new field.
1020         * c-lang.c (c_language_defn): Likewise.
1021         (cplus_language_defn): Likewise.
1022         (asm_language_defn): Likewise.
1023         (minimal_language_defn): Likewise.
1024         * d-lang.c (d_language_defn): Likewise.
1025         * f-lang.c (f_language_defn): Likewise.
1026         * go-lang.c (go_language_defn): Likewise.
1027         * language.c (unknown_language_defn): Likewise.
1028         (auto_language_defn): Likewise.
1029         * m2-lang.c (m2_language_defn): Likewise.
1030         * objc-lang.c (objc_language_defn): Likewise.
1031         * opencl-lang.c (opencl_language_defn): Likewise.
1032         * p-lang.c (pascal_language_defn): Likewise.
1033         * rust-lang.c (rust_language_defn): Likewise.
1034
1035 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1036
1037         * ada-lang.c (ada_is_character_type): Change return type to bool.
1038         (ada_is_string_type): Likewise.
1039         * ada-lang.h (ada_is_character_type): Update declaration
1040         (ada_is_string_type): Likewise.
1041
1042 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1043
1044         Support style in 'frame|thread apply'
1045
1046         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1047         * record.c (record_start, record_stop): Update callers of
1048         execute_command_to_string with false.
1049         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1050         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1051         methods.
1052         (class string_file): New constructor with term_out parameter.
1053         Override methods term_out and can_emit_style_escape.  New member
1054         term_out.
1055         (class stdio_file): Override can_emit_style_escape.
1056         (class tee_file): Override term_out and can_emit_style_escape.
1057         * utils.h (can_emit_style_escape): Remove.
1058         * utils.c (can_emit_style_escape): Likewise.
1059         Update all callers of can_emit_style_escape (SOMESTREAM) to
1060         SOMESTREAM->can_emit_style_escape.
1061         * source-cache.c (source_cache::get_source_lines): Likewise.
1062         * stack.c (frame_apply_command_count): Call execute_command_to_string
1063         passing the term_out characteristic of the current gdb_stdout.
1064         * thread.c (thr_try_catch_cmd): Likewise.
1065         * top.c (execute_command_to_string): pass term_out parameter
1066         to construct the string_file for the command output.
1067         * ui-file.c (term_cli_styling): New function (most code moved
1068         from utils.c can_emit_style_escape).
1069         (string_file::string_file, string_file::can_emit_style_escape,
1070         stdio_file::can_emit_style_escape, tee_file::term_out,
1071         tee_file::can_emit_style_escape): New functions.
1072
1073 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1074
1075         * NEWS: Mention the new set|show may-call-functions.
1076         * infcall.c (may_call_functions_p): New variable.
1077         (show_may_call_functions_p): New function.
1078         (call_function_by_hand_dummy): Throws an error if not
1079         may-call-functions.
1080         (_initialize_infcall): Call add_setshow_boolean_cmd for
1081         may-call-functions.
1082
1083 2019-04-25  Keith Seitz  <keiths@redhat.com>
1084
1085         PR c++/24367
1086         * cp-support.c (inspect_type): Don't attempt substitutions
1087         of symbol with the same name.
1088
1089 2019-04-25  Tom Tromey  <tromey@adacore.com>
1090
1091         PR gdb/24475:
1092         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1093         static.
1094
1095 2019-04-25  Tom Tromey  <tromey@adacore.com>
1096
1097         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1098         rvalue reference.
1099         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1100         (gdb_xml_parser::parse): Use std::move.
1101         * python/python-internal.h (gdbpy_convert_exception): Take a const
1102         reference.
1103         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1104         std::move.
1105         * python/py-utils.c (gdbpy_convert_exception): Take a const
1106         reference.
1107         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1108         Use std::move.
1109         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1110         Use std::move.
1111         * mi/mi-main.c (mi_print_exception): Take a const reference.
1112         * main.c (handle_command_errors): Take a const reference.
1113         * linespec.c (parse_linespec): Use std::move.
1114         * infcall.c (run_inferior_call): Use std::move.
1115         (call_function_by_hand_dummy): Use std::move.
1116         * exec.c (try_open_exec_file): Use std::move.
1117         * exceptions.h (exception_print, exception_fprintf)
1118         (exception_print_same): Update.
1119         * exceptions.c (print_exception, exception_print)
1120         (exception_fprintf, exception_print_same): Change parameters to
1121         const reference.
1122         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1123         * common/new-op.c: Use std::move.
1124         * common/common-exceptions.h (struct gdb_exception): Add move
1125         constructor.
1126         (struct gdb_exception_error, struct gdb_exception_quit, struct
1127         gdb_quit_bad_alloc): Change constructor to move constructor.
1128         (throw_exception): Change parameter to rvalue reference.
1129         * common/common-exceptions.c (throw_exception): Take rvalue
1130         reference.
1131         * cli/cli-interp.c (safe_execute_command): Use std::move.
1132         * breakpoint.c (insert_bp_location, location_to_sals): Use
1133         std::move.
1134
1135 2019-04-25  Tom Tromey  <tromey@adacore.com>
1136
1137         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1138         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1139         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1140         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1141         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1142         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1143         guile/scm-value.c: Use unpack.
1144         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1145         gdbscm_gdb_exception.
1146         (gdbscm_throw_gdb_exception): Likewise.
1147         (struct gdbscm_gdb_exception): New.
1148         (unpack): New function.
1149         (gdbscm_wrap): Use unpack.
1150
1151 2019-04-25  Tom Tromey  <tromey@adacore.com>
1152
1153         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1154         (gdb_rl_callback_handler): Use std::move.
1155         * common/common-exceptions.h (struct gdb_exception): Add move
1156         assignment operator.
1157         (throw_exception_sjlj): Change "exception" to const reference.
1158         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1159         (throw_exception_sjlj): Change "exception" to const reference.
1160
1161 2019-04-25  Tom Tromey  <tromey@adacore.com>
1162
1163         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1164         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1165         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1166         Update.
1167         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1168         Update.
1169         * mi/mi-interp.c (mi_interp::exec): Update.
1170         * linespec.c (parse_linespec): Update.
1171         * infcall.c (run_inferior_call): Update.
1172         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1173         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1174         (gdbscm_lookup_global_symbol): Update.
1175         * guile/scm-param.c (gdbscm_parameter_value): Update.
1176         * guile/scm-frame.c (gdbscm_frame_read_register)
1177         (gdbscm_frame_read_var): Update.
1178         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1179         * exec.c (try_open_exec_file): Update.
1180         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1181         (gdb_rl_callback_handler): Update.
1182         * common/common-exceptions.h (exception_none): Don't declare.
1183         * common/common-exceptions.c (exception_none): Don't define.
1184         (struct catcher) <exception>: Update.
1185         * cli/cli-interp.c (safe_execute_command): Update.
1186         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1187
1188 2019-04-25  Ali Tamur  <tamur@google.com>
1189
1190         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1191         (read_attribute_value): Likewise.
1192         (dwarf2_read_addr_index): Update comment.
1193         (read_str_index): Add DW_FORM_strx.
1194         (dwarf2_string_attr): Likewise.
1195         (dwarf2_const_value_attr): Likewise.
1196         (dump_die_shallow): Likewise.
1197         (dwarf2_fetch_constant_bytes): Likewise.
1198         (skip_form_bytes): Likewise.
1199         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1200
1201 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1202
1203         PR corefiles/11608
1204         PR corefiles/18187
1205         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1206         OFFSET.  Verify if current mapping contains an ELF header.
1207         (linux_find_memory_regions_full): Adjust call to
1208         dump_mapping_p.
1209
1210 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1211             Kang Li <kanglictf@gmail.com>
1212
1213         PR gdb/21600
1214
1215         * dwarf2-frame.c (read_initial_length): Be consistent about using
1216         unsigned representation of length.
1217         (decode_frame_entry_1): Likewise.  Check for wraparound of
1218         end pointer as well as buffer overflow.
1219
1220 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1221
1222         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1223         "vq".
1224
1225 2019-04-24  Tom Tromey  <tromey@adacore.com>
1226
1227         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1228
1229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1230
1231         * s12z-tdep.c (s12z_unwind_pc): Delete.
1232         (s12z_unwind_sp): Delete.
1233         (s12z_gdbarch_init): Don't register deleted functions with
1234         gdbarch.
1235
1236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1237
1238         * rl78-tdep.c (rl78_unwind_sp): Delete.
1239         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1240
1241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1244         (xstormy16_unwind_pc): Delete.
1245         (xstormy16_dummy_id): Delete.
1246         (xstormy16_gdbarch_init): Don't register deleted functions with
1247         gdbarch.
1248
1249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1250
1251         * vax-tdep.c (vax_unwind_pc): Delete.
1252         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1253
1254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1255
1256         * v850-tdep.c (v850_unwind_sp): Delete.
1257         (v850_unwind_pc): Delete.
1258         (v850_dummy_id): Delete.
1259         (v850_gdbarch_init): Don't register deleted functions with
1260         gdbarch.
1261
1262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1265         (tilegx_unwind_pc): Delete.
1266         (tilegx_unwind_dummy_id): Delete.
1267         (tilegx_gdbarch_init): Don't register deleted functions with
1268         gdbarch.
1269
1270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1271
1272         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1273         (tic6x_dummy_id): Delete.
1274         (tic6x_gdbarch_init): Don't register deleted functions with
1275         gdbarch.
1276
1277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * sparc-tdep.c (sparc_unwind_pc): Delete.
1280         (sparc32_gdbarch_init): Don't register deleted function with
1281         gdbarch.
1282
1283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * sh-tdep.c (sh_unwind_sp): Delete.
1286         (sh_unwind_pc): Delete.
1287         (sh_dummy_id): Delete.
1288         (sh_gdbarch_init): Don't register deleted functions with
1289         gdbarch.
1290
1291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * score-tdep.c (score_unwind_sp): Delete.
1294         (score_unwind_pc): Delete.
1295         (score_dummy_id): Delete.
1296         (score_gdbarch_init): Don't register deleted functions with
1297         gdbarch.
1298
1299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * rx-tdep.c (rx_unwind_pc): Delete.
1302         (rx_unwind_sp): Delete.
1303         (rx_dummy_id): Delete.
1304         (rx_gdbarch_init): Don't register deleted functions with
1305         gdbarch.  Update comment.
1306
1307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1310         (rs6000_dummy_id): Delete.
1311         (rs6000_gdbarch_init): Don't register deleted functions with
1312         gdbarch.
1313
1314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1315
1316         * or1k-tdep.c (or1k_dummy_id): Delete.
1317         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1318
1319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * nios2-tdep.c (nios2_dummy_id): Delete.
1322         (nios2_unwind_sp): Delete.
1323         (nios2_gdbarch_init): Don't register deleted functions with
1324         gdbarch.
1325
1326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1327
1328         * nds32-tdep.c (nds32_dummy_id): Delete.
1329         (nds32_unwind_pc): Delete.
1330         (nds32_unwind_sp): Delete.
1331         (nds32_gdbarch_init): Don't register deleted functions with
1332         gdbarch.
1333
1334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1335
1336         * msp430-tdep.c (msp430_unwind_pc): Delete.
1337         (msp430_unwind_sp): Delete.
1338         (msp430_dummy_id): Delete.
1339         (msp430_gdbarch_init): Don't register deleted functions with
1340         gdbarch.
1341
1342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1343
1344         * moxie-tdep.c (moxie_unwind_sp): Delete.
1345         (moxie_unwind_pc): Delete.
1346         (moxie_dummy_id): Delete.
1347         (moxie_gdbarch_init): Don't register deleted functions with
1348         gdbarch.
1349
1350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1353         (mn10300_unwind_pc): Delete.
1354         (mn10300_unwind_sp): Delete.
1355         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1356         mn10300_unwind_sp.
1357         (mn10300_frame_unwind_init): Don't register deleted functions with
1358         gdbarch.
1359
1360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * mep-tdep.c (mep_unwind_pc): Delete.
1363         (mep_unwind_sp): Delete.
1364         (mep_dummy_id): Delete.
1365         (mep_gdbarch_init): Don't register deleted functions with
1366         gdbarch.
1367
1368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1369
1370         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1371         (m68hc11_unwind_sp): Delete.
1372         (m68hc11_gdbarch_init): Don't register deleted functions with
1373         gdbarch.
1374
1375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1376
1377         * m32r-tdep.c (m32r_unwind_sp): Delete.
1378         (m32r_unwind_pc): Delete.
1379         (m32r_dummy_id): Delete.
1380         (m32r_gdbarch_init): Don't register deleted functions with
1381         gdbarch.
1382
1383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         * m32c-tdep.c (m32c_unwind_pc): Delete.
1386         (m32c_unwind_sp): Delete.
1387         (m32c_dummy_id): Delete.
1388         (m32c_gdbarch_init): Don't register deleted functions with
1389         gdbarch.
1390
1391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1394         (lm32_unwind_pc): Delete.
1395         (lm32_dummy_id): Delete.
1396         (lm32_gdbarch_init): Don't register deleted functions with
1397         gdbarch.
1398
1399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1402         (iq2000_unwind_pc): Delete.
1403         (iq2000_dummy_id): Delete.
1404         (iq2000_gdbarch_init): Don't register deleted functions with
1405         gdbarch.
1406
1407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1408
1409         * nds32-tdep.c (nds32_type_align): Delete.
1410         (nds32_push_dummy_call): Use type_align instead.
1411
1412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * arm-tdep.c (arm_type_align): Only handle vector override case.
1415         (arm_push_dummy_call): Use type_align.
1416         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1417
1418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1419
1420         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1421         case.
1422         (pass_on_stack): Use type_align.
1423         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1424         function.
1425
1426 2019-04-23  Tom Tromey  <tromey@adacore.com>
1427
1428         * dwarf2read.c (line_header::file_name_at): Remove unused
1429         overload.
1430
1431 2019-04-23  Tom de Vries  <tdevries@suse.de>
1432
1433         PR gdb/24438
1434         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1435         invocation.
1436
1437
1438 2019-03-27  Ali Tamur  <tamur@google.com>
1439
1440         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1441         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1442         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1443         (dwarf_expr_context::get_addr_index): Likewise
1444         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1445         (symbol_needs_eval_context::get_addr_index): Likewise
1446         (disassemble_dwarf_expression): Add DW_OP_addrx
1447         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1448         (read_cutu_die_from_dwo): Update comment
1449         (skip_one_die): Add DW_FORM_addrx
1450         (read_attribute_value): Likewise
1451         (var_decode_location): Add DW_OP_addrx
1452         (dwarf2_const_value_attr): Add DW_FORM_addrx
1453         (dump_die_shallow): Likewise
1454         (dwarf2_fetch_constant_bytes): Likewise
1455         (decode_locdesc): Add DW_OP_addrx
1456         (skip_form_bytes): Add DW_FORM_addrx
1457
1458 2019-04-22  Ali Tamur  <tamur@google.com>
1459
1460         * MAINTAINERS (Write After Approval): Add self.
1461
1462 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1463
1464         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1465         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1466         (open_symbol_file_object): Likewise.
1467         (svr4_default_sos): Add info parameter.
1468         (svr4_read_so_list): Likewise.
1469         (svr4_current_sos_direct): Adjust functions calls to pass down
1470         info.
1471         (svr4_current_sos_1): Add info parameter.
1472         (svr4_current_sos): Call get_svr4_info, pass info down to
1473         svr4_current_sos_1.
1474         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1475         get_svr4_info.
1476         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1477         get_svr4_info.
1478         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1479         to get_svr4_info.
1480         (probes_table_remove_objfile_probes): Likewise.
1481         (register_solib_event_probe): Add info parameter.
1482         (solist_update_incremental): Pass info parameter down to
1483         svr4_read_so_list.
1484         (disable_probes_interface): Add info parameter.
1485         (svr4_handle_solib_event): Pass current_program_space to
1486         get_svr4_info.  Adjust disable_probes_interface cleanup.
1487         (svr4_create_probe_breakpoints): Add info parameter, pass it
1488         down to register_solib_event_probe.
1489         (svr4_create_solib_event_breakpoints): Add info parameter,
1490         pass it down to svr4_create_probe_breakpoints.
1491         (enable_break): Pass info down to
1492         svr4_create_solib_event_breakpoints.
1493         (svr4_solib_create_inferior_hook): Pass current_program_space to
1494         get_svr4_info.
1495         (svr4_clear_solib): Likewise.
1496
1497 2019-04-22  Pedro Alves  <palves@redhat.com>
1498
1499         * solib-svr4.c (svr4_free_objfile_observer): New.
1500         (probe_and_action::objfile): New field.
1501         (probes_table_htab_remove_objfile_probes)
1502         (probes_table_remove_objfile_probes): New functions.
1503         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1504         in the new probe_and_action.  Don't store the probe in 'lookup'.
1505         (svr4_create_probe_breakpoints): Pass objfile to
1506         register_solib_event_probe.
1507         (_initialize_svr4_solib): Register a free_objfile observer.
1508
1509 2019-04-19  Tom Tromey  <tom@tromey.com>
1510
1511         * common/queue.h: Remove.
1512
1513 2019-04-19  Tom Tromey  <tom@tromey.com>
1514
1515         * event-loop.c: Don't include "common/queue.h".
1516
1517 2019-04-19  Tom Tromey  <tom@tromey.com>
1518
1519         * remote.c (remote_target): Use delete.
1520         * remote-notif.h: Include <list>, not "common/queue.h".
1521         (notif_client_p): Remove typedef.
1522         (remote_notif_state): Add constructor, destructor, initializer.
1523         <notif_queue>: Now a std::list.
1524         (remote_notif_state_xfree): Don't declare.
1525         * remote-notif.c (remote_notif_process, handle_notification)
1526         (remote_notif_state_allocate): Update.
1527         (~remote_notif_state): Rename from remote_notif_state_xfree.
1528
1529 2019-04-19  Tom Tromey  <tom@tromey.com>
1530
1531         * symfile.c (reread_symbols): Update.
1532         * objfiles.c (objfile_register_static_link)
1533         (objfile_lookup_static_link): Update
1534         (~objfile) Don't delete static_links.
1535         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1536
1537 2019-04-19  Tom Tromey  <tom@tromey.com>
1538
1539         * type-stack.h (struct type_stack) <insert>: Constify string.
1540         * type-stack.c (type_stack::insert): Constify string.
1541         * gdbtypes.h (lookup_template_type): Update.
1542         (address_space_name_to_int): Update.
1543         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1544         const.
1545         (lookup_template_type): Make name const.
1546         * c-exp.y: Update rules.
1547         (lex_one_token, classify_name, classify_inner_name)
1548         (c_print_token): Update.
1549         * p-exp.y: Update rules.
1550         (yylex): Update.
1551         * f-exp.y: Update rules.
1552         (yylex): Update.
1553         * d-exp.y: Update rules.
1554         (lex_one_token, classify_name, classify_inner_name): Update.
1555         * parse.c (write_dollar_variable, copy_name): Return std::string.
1556         * parser-defs.h (copy_name): Change return type.
1557         * m2-exp.y: Update rules.
1558         (yylex): Update.
1559         * go-exp.y (lex_one_token): Update.
1560         Update rules.
1561         (classify_unsafe_function, classify_packaged_name)
1562         (classify_name, yylex): Update.
1563
1564 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1565
1566         * configure.ac: add --enable-source-highlight switch.
1567         * configure: Regenerate.
1568         * top.c (print_gdb_version): plumb --enable-source-highlight
1569         status to "show configuration".
1570
1571 2019-04-19  Tom Tromey  <tromey@adacore.com>
1572
1573         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1574         Check ADA_TYPE_P.
1575         (empty_record, ada_template_to_fixed_record_type_1)
1576         (template_to_static_fixed_type)
1577         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1578         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1579         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1580         macros.
1581
1582 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1583
1584         PR symtab/24423:
1585         * source.c (print_source_lines_base): Advance "iter" when a
1586         control character is seen.
1587
1588 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1589
1590         * inferior.h (struct infcall_suspend_state_deleter):
1591         Catch exception in destructor to avoid crash.
1592
1593 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1594
1595         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1596         close to the add_com "shell".
1597
1598 2019-04-18  Tom Tromey  <tromey@adacore.com>
1599
1600         * process-stratum-target.h (class process_stratum_target)
1601         <stratum>: Add "final".
1602
1603 2019-04-17  Tom Tromey  <tromey@adacore.com>
1604
1605         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1606         against nullptr before use.
1607
1608 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1609
1610         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1611
1612 2019-04-17  Jim Wilson  <jimw@sifive.com>
1613             Andrew Burgess  <andrew.burgess@embecosm.com>
1614
1615         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1616         code read might fail, assume 4-byte breakpoint in that case.
1617
1618 2019-04-15  Leszek Swirski  <leszeks@google.com>
1619
1620         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1621         rather than a hand-rolled POD check when checking for forced MEMORY
1622         classification.
1623
1624 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1625
1626         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1627         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1628         function.
1629         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1630         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1631         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1632         declaration.
1633
1634 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1635
1636         * aarch64-linux-nat.c
1637         (aarch64_linux_nat_target::thread_architecture): Add override.
1638         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1639         each VQ.
1640
1641 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1642
1643         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1644
1645 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1646
1647         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1648         target types of size 96-bits, add some additional comments, and
1649         check that the builtin type we found was the correct size.
1650
1651 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1652
1653         * utils.c (prompt_for_continue): Don't restore the styling at the
1654         end, as applied_style has the wrong value.  This fixes styling in
1655         long lists of file names that are interrupted by the "Continue?"
1656         prompt.
1657
1658 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1659
1660         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1661         * c-lang.c (c_language_defn): Likewise.
1662         (cplus_language_defn): Likewise.
1663         (asm_language_defn): Likewise.
1664         (minimal_language_defn): Likewise.
1665         * d-lang.c (d_language_defn): Likewise.
1666         * f-lang.c (f_language_defn): Likewise.
1667         * go-lang.c (go_language_defn): Likewise.
1668         * language.c (unknown_language_defn): Likewise.
1669         (auto_language_defn): Likewise.
1670         * language.h (struct language_defn): Remove la_magic field.
1671         (LANG_MAGIC): Delete.
1672         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1673         * objc-lang.c (objc_language_defn): Likewise.
1674         * opencl-lang.c (opencl_language_defn): Likewise.
1675         * p-lang.c (pascal_language_defn): Likewise.
1676         * rust-lang.c (rust_language_defn): Likewise.
1677
1678 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * riscv-tdep.c (riscv_type_align): New function.
1681         (riscv_type_alignment): Delete.
1682         (riscv_arg_location): Use 'type_align'.
1683         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1684
1685 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1686
1687         * gdbtypes.c (type_align): A struct with no non-static fields also
1688         has alignment of 1.
1689
1690 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1691
1692         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1693         component to 0.
1694         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1695         member.
1696         (riscv_struct_info::analyse): New implementation using new
1697         analyse_inner member function.
1698         (riscv_struct_info::field_offset): New member function.
1699         (riscv_struct_info::m_offsets): New member variable.
1700         (riscv_struct_info::analyse_inner): New private member function,
1701         takes the old implementation of riscv_struct_info::analyse but
1702         extended to track field offsets.
1703         (riscv_call_arg_struct): Update the struct folding special cases
1704         to handle cases where empty C++ structs, which are non-zero
1705         length, are found.
1706         (riscv_arg_location): Initialise the length of each location, a
1707         non-zero length now indicates the location is in use.
1708         (riscv_push_dummy_call): Allow for the first location having a
1709         non-zero offset when setting up arguments.
1710         (riscv_return_value): Likewise, but for return values.
1711
1712 2019-04-11  Tom Tromey  <tromey@adacore.com>
1713
1714         * utils.c (internal_vproblem): Make "msg" const.
1715
1716 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1717
1718         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1719         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1720         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1721         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1722
1723 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1724
1725         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1726         function.
1727         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1728         of amd64_collect_native_gregset.
1729         (amd64_linux_nat_target::store_registers): Likewise.
1730
1731 2019-04-10  Tom Tromey  <tom@tromey.com>
1732
1733         * symtab.c (lookup_global_symbol_from_objfile)
1734         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1735         * objfiles.h (class separate_debug_iterator): New.
1736         (class separate_debug_range): New.
1737         (struct objfile) <separate_debug_objfiles>: New method.
1738         (objfile_separate_debug_iterate): Don't declare.
1739         * objfiles.c (separate_debug_iterator::operator++): Rename from
1740         objfile_separate_debug_iterate.
1741         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1742         iterator.
1743         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1744         iterator.
1745
1746 2019-04-10  Tom Tromey  <tom@tromey.com>
1747
1748         * symfile.c (reread_symbols): Remove old comment.
1749         * objfiles.c (free_all_objfiles): Fix a typo.
1750
1751 2019-04-10  Tom Tromey  <tom@tromey.com>
1752
1753         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1754         * minsyms.c (lookup_minimal_symbol): Use foreach.
1755         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1756         (lookup_minimal_symbol_solib_trampoline): Likewise.
1757         * symfile.c (reread_symbols): Use foreach.
1758
1759 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1760             Tom Tromey  <tromey@adacore.com>
1761
1762         PR rust/24414:
1763         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1764         (rust_lex_int_test): Change "value" to be LONGEST.
1765         (rust_lex_tests): Add test for long integer literal.
1766
1767 2019-04-09  Tom Tromey  <tromey@adacore.com>
1768
1769         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1770         to bool.
1771         (extended_remote_target::attach): Update.
1772         (remote_target::remote_notice_new_inferior): Update.
1773         (remote_target::add_current_inferior_and_thread): Update.
1774         * inferior.c (exit_inferior_1): Use "false".
1775         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1776
1777 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1778
1779         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1780         the "start" command.
1781
1782 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1783
1784         * python/py-inferior.c (infpy_thread_from_thread_handle):
1785         Adjust comments to reflect renaming of thread_from_thread_handle
1786         to thread_from_handle.  Adjust keywords.  Fix type error message.
1787         (inferior_object_methods): Add thread_from_handle.  Retain
1788         thread_from_thread_handle, but mark it as deprecated.
1789
1790 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1791
1792         * gdbthread.h (find_thread_by_handle): Revise declaration.
1793         * thread.c (find_thread_by_handle): Likewise.  Adjust
1794         implementation too.
1795         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1796         support for buffer objects as handles.
1797
1798 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1799
1800         * python/py-infthread.c (thpy_thread_handle): New function.
1801         (thread_object_methods): Register thpy_thread_handle.
1802
1803 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1804
1805         * gdbthread.h (thread_to_thread_handle): Declare.
1806         * thread.c (gdbtypes.h): Include.
1807         (thread_to_thread_handle): New function.
1808
1809         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1810         (target_thread_info_to_thread_handle): Declare.
1811         * target.c (target_thread_info_to_thread_handle): New function.
1812         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1813         * target-delegates.c: Regenerate.
1814
1815         * linux-thread-db.c (class thread_db_target): Add method
1816         thread_info_to_thread_handle.
1817         (thread_db_target::thread_info_to_thread_handle): Define.
1818         * remote.c (class remote_target): Add new method
1819         thread_info_to_thread_handle.
1820         (remote_target::thread_info_to_thread_handle): Define.
1821
1822 2019-04-08  Pedro Alves  <palves@redhat.com>
1823
1824         * common/common-exceptions.c (throw_exception): Don't create
1825         named object to throw; throw directly.
1826         (throw_it): Likewise.  Don't initialize gdb_exception::message
1827         here, with new; pass FMT and AP to the ctor instead.
1828         * common/common-exceptions.h: Include <string>.
1829         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1830         const char *, va_list)): New ctor.  Use std::make_shared.
1831         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1832         errors)): Delete.
1833         (gdb_exception_error::gdb_exception_error(enum errors, const char
1834         *, va_list)): New.
1835         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1836         Add assertion.
1837         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1838         errors)): Delete.
1839         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1840         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1841         Add assertion.
1842
1843 2019-04-08  Tom Tromey  <tom@tromey.com>
1844
1845         * valops.c (value_rtti_indirect_type): Replace throw_exception
1846         with throw.
1847         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1848         with throw.
1849         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1850         throw.
1851         * target.c (target_translate_tls_address): Replace throw_exception
1852         with throw.
1853         * stack.c (frame_apply_command_count): Replace throw_exception
1854         with throw.
1855         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1856         throw.
1857         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1858         with throw.
1859         * rs6000-tdep.c (rs6000_frame_cache)
1860         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1861         * remote.c: Replace throw_exception with throw.
1862         * record-full.c (record_full_message, record_full_wait_1)
1863         (record_full_restore): Replace throw_exception with throw.
1864         * record-btrace.c:
1865         (get_thread_current_frame_id, record_btrace_start_replaying)
1866         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1867         (cmd_record_btrace_start): Replace throw_exception with throw.
1868         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1869         throw.
1870         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1871         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1872         * linespec.c:
1873         (find_linespec_symbols): Replace throw_exception with throw.
1874         * infrun.c (displaced_step_prepare, resume): Replace
1875         throw_exception with throw.
1876         * infcmd.c (post_create_inferior): Replace throw_exception with
1877         throw.
1878         * inf-loop.c (inferior_event_handler): Replace throw_exception
1879         with throw.
1880         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1881         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1882         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1883         (get_prev_frame_always, get_frame_pc_if_available)
1884         (get_frame_address_in_block_if_available, get_frame_language):
1885         Replace throw_exception with throw.
1886         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1887         throw_exception with throw.
1888         * eval.c (fetch_subexp_value, evaluate_var_value)
1889         (evaluate_funcall, evaluate_subexp_standard): Replace
1890         throw_exception with throw.
1891         * dwarf2loc.c (call_site_find_chain)
1892         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1893         Replace throw_exception with throw.
1894         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1895         with throw.
1896         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1897         throw.
1898         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1899         * completer.c (complete_line_internal): Replace throw_exception
1900         with throw.
1901         * compile/compile-object-run.c (compile_object_run): Replace
1902         throw_exception with throw.
1903         * cli/cli-script.c (process_next_line): Replace throw_exception
1904         with throw.
1905         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1906         (btrace_enable, btrace_maint_update_pt_packets): Replace
1907         throw_exception with throw.
1908         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1909         throw_exception with throw.
1910         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1911         throw_exception with throw.
1912         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1913         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1914         * aarch64-tdep.c (aarch64_make_prologue_cache)
1915         (aarch64_make_stub_cache): Replace throw_exception with throw.
1916
1917 2019-04-08  Tom Tromey  <tom@tromey.com>
1918
1919         * common/common-exceptions.c (throw_exception): Rename from
1920         throw_exception_cxx.  Remove old copy.  Make argument const.
1921         (throw_it): Create and throw exception objects directly.
1922         * common/common-exceptions.h (throw_exception): Make argument
1923         const.
1924         (struct gdb_exception_error): Add constructor.
1925         (struct gdb_exception_quit): Add constructor.
1926
1927 2019-04-08  Tom Tromey  <tom@tromey.com>
1928
1929         * common/common-exceptions.h (exception_rethrow): Don't declare.
1930         (TRY_SJLJ): Update comment.
1931         (TRY, CATCH, END_CATCH): Remove.
1932         * common/common-exceptions.c (exception_rethrow): Remove.
1933
1934 2019-04-08  Tom Tromey  <tom@tromey.com>
1935
1936         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1937         Remove.
1938         (gdb_exception_error): Rename from
1939         gdb_exception_RETURN_MASK_ERROR.
1940         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1941         (gdb_quit_bad_alloc): Update.
1942         * aarch64-tdep.c: Update.
1943         * ada-lang.c: Update.
1944         * ada-typeprint.c: Update.
1945         * ada-valprint.c: Update.
1946         * amd64-tdep.c: Update.
1947         * arch-utils.c: Update.
1948         * break-catch-throw.c: Update.
1949         * breakpoint.c: Update.
1950         * btrace.c: Update.
1951         * c-varobj.c: Update.
1952         * cli/cli-cmds.c: Update.
1953         * cli/cli-interp.c: Update.
1954         * cli/cli-script.c: Update.
1955         * common/common-exceptions.c: Update.
1956         * common/new-op.c: Update.
1957         * common/selftest.c: Update.
1958         * compile/compile-c-symbols.c: Update.
1959         * compile/compile-cplus-symbols.c: Update.
1960         * compile/compile-object-load.c: Update.
1961         * compile/compile-object-run.c: Update.
1962         * completer.c: Update.
1963         * corelow.c: Update.
1964         * cp-abi.c: Update.
1965         * cp-support.c: Update.
1966         * cp-valprint.c: Update.
1967         * darwin-nat.c: Update.
1968         * disasm-selftests.c: Update.
1969         * dtrace-probe.c: Update.
1970         * dwarf-index-cache.c: Update.
1971         * dwarf-index-write.c: Update.
1972         * dwarf2-frame-tailcall.c: Update.
1973         * dwarf2-frame.c: Update.
1974         * dwarf2loc.c: Update.
1975         * dwarf2read.c: Update.
1976         * eval.c: Update.
1977         * event-loop.c: Update.
1978         * event-top.c: Update.
1979         * exec.c: Update.
1980         * f-valprint.c: Update.
1981         * fbsd-tdep.c: Update.
1982         * frame-unwind.c: Update.
1983         * frame.c: Update.
1984         * gdbtypes.c: Update.
1985         * gnu-v3-abi.c: Update.
1986         * guile/guile-internal.h: Update.
1987         * guile/scm-block.c: Update.
1988         * guile/scm-breakpoint.c: Update.
1989         * guile/scm-cmd.c: Update.
1990         * guile/scm-disasm.c: Update.
1991         * guile/scm-frame.c: Update.
1992         * guile/scm-lazy-string.c: Update.
1993         * guile/scm-math.c: Update.
1994         * guile/scm-param.c: Update.
1995         * guile/scm-ports.c: Update.
1996         * guile/scm-pretty-print.c: Update.
1997         * guile/scm-symbol.c: Update.
1998         * guile/scm-symtab.c: Update.
1999         * guile/scm-type.c: Update.
2000         * guile/scm-value.c: Update.
2001         * i386-linux-tdep.c: Update.
2002         * i386-tdep.c: Update.
2003         * inf-loop.c: Update.
2004         * infcall.c: Update.
2005         * infcmd.c: Update.
2006         * infrun.c: Update.
2007         * jit.c: Update.
2008         * language.c: Update.
2009         * linespec.c: Update.
2010         * linux-fork.c: Update.
2011         * linux-nat.c: Update.
2012         * linux-tdep.c: Update.
2013         * linux-thread-db.c: Update.
2014         * main.c: Update.
2015         * mi/mi-cmd-break.c: Update.
2016         * mi/mi-cmd-stack.c: Update.
2017         * mi/mi-interp.c: Update.
2018         * mi/mi-main.c: Update.
2019         * objc-lang.c: Update.
2020         * p-valprint.c: Update.
2021         * parse.c: Update.
2022         * ppc-linux-tdep.c: Update.
2023         * printcmd.c: Update.
2024         * python/py-arch.c: Update.
2025         * python/py-breakpoint.c: Update.
2026         * python/py-cmd.c: Update.
2027         * python/py-finishbreakpoint.c: Update.
2028         * python/py-frame.c: Update.
2029         * python/py-framefilter.c: Update.
2030         * python/py-gdb-readline.c: Update.
2031         * python/py-inferior.c: Update.
2032         * python/py-infthread.c: Update.
2033         * python/py-lazy-string.c: Update.
2034         * python/py-linetable.c: Update.
2035         * python/py-objfile.c: Update.
2036         * python/py-param.c: Update.
2037         * python/py-prettyprint.c: Update.
2038         * python/py-progspace.c: Update.
2039         * python/py-record-btrace.c: Update.
2040         * python/py-record.c: Update.
2041         * python/py-symbol.c: Update.
2042         * python/py-type.c: Update.
2043         * python/py-unwind.c: Update.
2044         * python/py-utils.c: Update.
2045         * python/py-value.c: Update.
2046         * python/python.c: Update.
2047         * record-btrace.c: Update.
2048         * record-full.c: Update.
2049         * remote-fileio.c: Update.
2050         * remote.c: Update.
2051         * riscv-tdep.c: Update.
2052         * rs6000-aix-tdep.c: Update.
2053         * rs6000-tdep.c: Update.
2054         * rust-exp.y: Update.
2055         * rust-lang.c: Update.
2056         * s390-tdep.c: Update.
2057         * selftest-arch.c: Update.
2058         * solib-dsbt.c: Update.
2059         * solib-frv.c: Update.
2060         * solib-spu.c: Update.
2061         * solib-svr4.c: Update.
2062         * solib.c: Update.
2063         * sparc64-linux-tdep.c: Update.
2064         * stack.c: Update.
2065         * symfile-mem.c: Update.
2066         * symmisc.c: Update.
2067         * target.c: Update.
2068         * thread.c: Update.
2069         * top.c: Update.
2070         * tracefile-tfile.c: Update.
2071         * tui/tui.c: Update.
2072         * typeprint.c: Update.
2073         * unittests/cli-utils-selftests.c: Update.
2074         * unittests/parse-connection-spec-selftests.c: Update.
2075         * valops.c: Update.
2076         * valprint.c: Update.
2077         * value.c: Update.
2078         * varobj.c: Update.
2079         * windows-nat.c: Update.
2080         * x86-linux-nat.c: Update.
2081         * xml-support.c: Update.
2082
2083 2019-04-08  Tom Tromey  <tom@tromey.com>
2084
2085         * xml-support.c: Use C++ exception handling.
2086         * x86-linux-nat.c: Use C++ exception handling.
2087         * windows-nat.c: Use C++ exception handling.
2088         * varobj.c: Use C++ exception handling.
2089         * value.c: Use C++ exception handling.
2090         * valprint.c: Use C++ exception handling.
2091         * valops.c: Use C++ exception handling.
2092         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2093         handling.
2094         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2095         * typeprint.c: Use C++ exception handling.
2096         * tui/tui.c: Use C++ exception handling.
2097         * tracefile-tfile.c: Use C++ exception handling.
2098         * top.c: Use C++ exception handling.
2099         * thread.c: Use C++ exception handling.
2100         * target.c: Use C++ exception handling.
2101         * symmisc.c: Use C++ exception handling.
2102         * symfile-mem.c: Use C++ exception handling.
2103         * stack.c: Use C++ exception handling.
2104         * sparc64-linux-tdep.c: Use C++ exception handling.
2105         * solib.c: Use C++ exception handling.
2106         * solib-svr4.c: Use C++ exception handling.
2107         * solib-spu.c: Use C++ exception handling.
2108         * solib-frv.c: Use C++ exception handling.
2109         * solib-dsbt.c: Use C++ exception handling.
2110         * selftest-arch.c: Use C++ exception handling.
2111         * s390-tdep.c: Use C++ exception handling.
2112         * rust-lang.c: Use C++ exception handling.
2113         * rust-exp.y: Use C++ exception handling.
2114         * rs6000-tdep.c: Use C++ exception handling.
2115         * rs6000-aix-tdep.c: Use C++ exception handling.
2116         * riscv-tdep.c: Use C++ exception handling.
2117         * remote.c: Use C++ exception handling.
2118         * remote-fileio.c: Use C++ exception handling.
2119         * record-full.c: Use C++ exception handling.
2120         * record-btrace.c: Use C++ exception handling.
2121         * python/python.c: Use C++ exception handling.
2122         * python/py-value.c: Use C++ exception handling.
2123         * python/py-utils.c: Use C++ exception handling.
2124         * python/py-unwind.c: Use C++ exception handling.
2125         * python/py-type.c: Use C++ exception handling.
2126         * python/py-symbol.c: Use C++ exception handling.
2127         * python/py-record.c: Use C++ exception handling.
2128         * python/py-record-btrace.c: Use C++ exception handling.
2129         * python/py-progspace.c: Use C++ exception handling.
2130         * python/py-prettyprint.c: Use C++ exception handling.
2131         * python/py-param.c: Use C++ exception handling.
2132         * python/py-objfile.c: Use C++ exception handling.
2133         * python/py-linetable.c: Use C++ exception handling.
2134         * python/py-lazy-string.c: Use C++ exception handling.
2135         * python/py-infthread.c: Use C++ exception handling.
2136         * python/py-inferior.c: Use C++ exception handling.
2137         * python/py-gdb-readline.c: Use C++ exception handling.
2138         * python/py-framefilter.c: Use C++ exception handling.
2139         * python/py-frame.c: Use C++ exception handling.
2140         * python/py-finishbreakpoint.c: Use C++ exception handling.
2141         * python/py-cmd.c: Use C++ exception handling.
2142         * python/py-breakpoint.c: Use C++ exception handling.
2143         * python/py-arch.c: Use C++ exception handling.
2144         * printcmd.c: Use C++ exception handling.
2145         * ppc-linux-tdep.c: Use C++ exception handling.
2146         * parse.c: Use C++ exception handling.
2147         * p-valprint.c: Use C++ exception handling.
2148         * objc-lang.c: Use C++ exception handling.
2149         * mi/mi-main.c: Use C++ exception handling.
2150         * mi/mi-interp.c: Use C++ exception handling.
2151         * mi/mi-cmd-stack.c: Use C++ exception handling.
2152         * mi/mi-cmd-break.c: Use C++ exception handling.
2153         * main.c: Use C++ exception handling.
2154         * linux-thread-db.c: Use C++ exception handling.
2155         * linux-tdep.c: Use C++ exception handling.
2156         * linux-nat.c: Use C++ exception handling.
2157         * linux-fork.c: Use C++ exception handling.
2158         * linespec.c: Use C++ exception handling.
2159         * language.c: Use C++ exception handling.
2160         * jit.c: Use C++ exception handling.
2161         * infrun.c: Use C++ exception handling.
2162         * infcmd.c: Use C++ exception handling.
2163         * infcall.c: Use C++ exception handling.
2164         * inf-loop.c: Use C++ exception handling.
2165         * i386-tdep.c: Use C++ exception handling.
2166         * i386-linux-tdep.c: Use C++ exception handling.
2167         * guile/scm-value.c: Use C++ exception handling.
2168         * guile/scm-type.c: Use C++ exception handling.
2169         * guile/scm-symtab.c: Use C++ exception handling.
2170         * guile/scm-symbol.c: Use C++ exception handling.
2171         * guile/scm-pretty-print.c: Use C++ exception handling.
2172         * guile/scm-ports.c: Use C++ exception handling.
2173         * guile/scm-param.c: Use C++ exception handling.
2174         * guile/scm-math.c: Use C++ exception handling.
2175         * guile/scm-lazy-string.c: Use C++ exception handling.
2176         * guile/scm-frame.c: Use C++ exception handling.
2177         * guile/scm-disasm.c: Use C++ exception handling.
2178         * guile/scm-cmd.c: Use C++ exception handling.
2179         * guile/scm-breakpoint.c: Use C++ exception handling.
2180         * guile/scm-block.c: Use C++ exception handling.
2181         * guile/guile-internal.h: Use C++ exception handling.
2182         * gnu-v3-abi.c: Use C++ exception handling.
2183         * gdbtypes.c: Use C++ exception handling.
2184         * frame.c: Use C++ exception handling.
2185         * frame-unwind.c: Use C++ exception handling.
2186         * fbsd-tdep.c: Use C++ exception handling.
2187         * f-valprint.c: Use C++ exception handling.
2188         * exec.c: Use C++ exception handling.
2189         * event-top.c: Use C++ exception handling.
2190         * event-loop.c: Use C++ exception handling.
2191         * eval.c: Use C++ exception handling.
2192         * dwarf2read.c: Use C++ exception handling.
2193         * dwarf2loc.c: Use C++ exception handling.
2194         * dwarf2-frame.c: Use C++ exception handling.
2195         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2196         * dwarf-index-write.c: Use C++ exception handling.
2197         * dwarf-index-cache.c: Use C++ exception handling.
2198         * dtrace-probe.c: Use C++ exception handling.
2199         * disasm-selftests.c: Use C++ exception handling.
2200         * darwin-nat.c: Use C++ exception handling.
2201         * cp-valprint.c: Use C++ exception handling.
2202         * cp-support.c: Use C++ exception handling.
2203         * cp-abi.c: Use C++ exception handling.
2204         * corelow.c: Use C++ exception handling.
2205         * completer.c: Use C++ exception handling.
2206         * compile/compile-object-run.c: Use C++ exception handling.
2207         * compile/compile-object-load.c: Use C++ exception handling.
2208         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2209         * compile/compile-c-symbols.c: Use C++ exception handling.
2210         * common/selftest.c: Use C++ exception handling.
2211         * common/new-op.c: Use C++ exception handling.
2212         * cli/cli-script.c: Use C++ exception handling.
2213         * cli/cli-interp.c: Use C++ exception handling.
2214         * cli/cli-cmds.c: Use C++ exception handling.
2215         * c-varobj.c: Use C++ exception handling.
2216         * btrace.c: Use C++ exception handling.
2217         * breakpoint.c: Use C++ exception handling.
2218         * break-catch-throw.c: Use C++ exception handling.
2219         * arch-utils.c: Use C++ exception handling.
2220         * amd64-tdep.c: Use C++ exception handling.
2221         * ada-valprint.c: Use C++ exception handling.
2222         * ada-typeprint.c: Use C++ exception handling.
2223         * ada-lang.c: Use C++ exception handling.
2224         * aarch64-tdep.c: Use C++ exception handling.
2225
2226 2019-04-08  Tom Tromey  <tom@tromey.com>
2227
2228         * xml-support.c (gdb_xml_parser::parse): Update.
2229         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2230         * value.c (show_convenience): Update.
2231         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2232         (test_parse_flags_qcs): Update.
2233         * thread.c (thr_try_catch_cmd): Update.
2234         * target.c (target_translate_tls_address): Update.
2235         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2236         (info_frame_command_core, frame_apply_command_count): Update.
2237         * rust-exp.y (rust_lex_exception_test): Update.
2238         * riscv-tdep.c (riscv_print_one_register_info): Update.
2239         * remote.c (remote_target::enable_btrace): Update.
2240         * record-btrace.c (record_btrace_enable_warn): Update.
2241         * python/py-utils.c (gdbpy_convert_exception): Update.
2242         * printcmd.c (do_one_display, print_variable_and_value): Update.
2243         * mi/mi-main.c (mi_print_exception): Update.
2244         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2245         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2246         * linux-nat.c (linux_nat_target::attach): Update.
2247         * linux-fork.c (class scoped_switch_fork_info): Update.
2248         * infrun.c (displaced_step_prepare): Update.
2249         * infcall.c (call_function_by_hand_dummy): Update.
2250         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2251         * gnu-v3-abi.c (print_one_vtable): Update.
2252         * frame.c (get_prev_frame_always): Update.
2253         * f-valprint.c (info_common_command_for_block): Update.
2254         * exec.c (try_open_exec_file): Update.
2255         * exceptions.c (print_exception, exception_print)
2256         (exception_fprintf, exception_print_same): Update.
2257         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2258         * dwarf-index-cache.c (index_cache::store)
2259         (index_cache::lookup_gdb_index): Update.
2260         * darwin-nat.c (maybe_cache_shell): Update.
2261         * cp-valprint.c (cp_print_value_fields): Update.
2262         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2263         (gcc_cplus_symbol_address): Update.
2264         * compile/compile-c-symbols.c (gcc_convert_symbol)
2265         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2266         * common/selftest.c: Update.
2267         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2268         a std::string.
2269         (exception_try_scope_entry, exception_try_scope_exit): Don't
2270         declare.
2271         (struct exception_try_scope): Remove.
2272         (TRY): Don't use exception_try_scope.
2273         (struct gdb_exception): Add constructor, operator=.
2274         <what>: New method.
2275         (struct gdb_exception_RETURN_MASK_ALL)
2276         (struct gdb_exception_RETURN_MASK_ERROR)
2277         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2278         (struct gdb_quit_bad_alloc): Update.
2279         * common/common-exceptions.c (exception_none): Change
2280         initializer.
2281         (struct catcher) <state, exception>: Initialize inline.
2282         <prev>: Remove member.
2283         (current_catcher): Remove.
2284         (catchers): New global.
2285         (exceptions_state_mc_init): Simplify.
2286         (catcher_pop): Remove.
2287         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2288         (try_scope_depth, exception_try_scope_entry)
2289         (exception_try_scope_exit): Remove.
2290         (throw_exception_sjlj): Update.
2291         (exception_messages, exception_messages_size): Remove.
2292         (throw_it): Simplify.
2293         (gdb_exception_sliced_copy): Remove.
2294         (throw_exception_cxx): Update.
2295         * cli/cli-script.c (script_from_file): Update.
2296         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2297         Update.
2298         * ada-valprint.c (ada_val_print): Update.
2299         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2300         (create_excep_cond_exprs): Update.
2301
2302 2019-04-08  Tom Tromey  <tom@tromey.com>
2303
2304         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2305         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2306         (TRY, CATCH, END_CATCH): Remove some definitions.
2307         * common/common-exceptions.c: Don't use GDB_XCPT.
2308         (catcher_list_size): Remove.
2309         (throw_exception, throw_it): Simplify.
2310
2311 2019-04-05  Tom Tromey  <tom@tromey.com>
2312
2313         Revert the header-sorting patch.
2314         * ft32-tdep.c: Revert.
2315         * frv-tdep.c: Revert.
2316         * frv-linux-tdep.c: Revert.
2317         * frame.c: Revert.
2318         * frame-unwind.c: Revert.
2319         * frame-base.c: Revert.
2320         * fork-child.c: Revert.
2321         * findvar.c: Revert.
2322         * findcmd.c: Revert.
2323         * filesystem.c: Revert.
2324         * filename-seen-cache.h: Revert.
2325         * filename-seen-cache.c: Revert.
2326         * fbsd-tdep.c: Revert.
2327         * fbsd-nat.h: Revert.
2328         * fbsd-nat.c: Revert.
2329         * f-valprint.c: Revert.
2330         * f-typeprint.c: Revert.
2331         * f-lang.c: Revert.
2332         * extension.h: Revert.
2333         * extension.c: Revert.
2334         * extension-priv.h: Revert.
2335         * expprint.c: Revert.
2336         * exec.h: Revert.
2337         * exec.c: Revert.
2338         * exceptions.c: Revert.
2339         * event-top.c: Revert.
2340         * event-loop.c: Revert.
2341         * eval.c: Revert.
2342         * elfread.c: Revert.
2343         * dwarf2read.h: Revert.
2344         * dwarf2read.c: Revert.
2345         * dwarf2loc.c: Revert.
2346         * dwarf2expr.h: Revert.
2347         * dwarf2expr.c: Revert.
2348         * dwarf2-frame.c: Revert.
2349         * dwarf2-frame-tailcall.c: Revert.
2350         * dwarf-index-write.h: Revert.
2351         * dwarf-index-write.c: Revert.
2352         * dwarf-index-common.c: Revert.
2353         * dwarf-index-cache.h: Revert.
2354         * dwarf-index-cache.c: Revert.
2355         * dummy-frame.c: Revert.
2356         * dtrace-probe.c: Revert.
2357         * disasm.h: Revert.
2358         * disasm.c: Revert.
2359         * disasm-selftests.c: Revert.
2360         * dictionary.c: Revert.
2361         * dicos-tdep.c: Revert.
2362         * demangle.c: Revert.
2363         * dcache.h: Revert.
2364         * dcache.c: Revert.
2365         * darwin-nat.h: Revert.
2366         * darwin-nat.c: Revert.
2367         * darwin-nat-info.c: Revert.
2368         * d-valprint.c: Revert.
2369         * d-namespace.c: Revert.
2370         * d-lang.c: Revert.
2371         * ctf.c: Revert.
2372         * csky-tdep.c: Revert.
2373         * csky-linux-tdep.c: Revert.
2374         * cris-tdep.c: Revert.
2375         * cris-linux-tdep.c: Revert.
2376         * cp-valprint.c: Revert.
2377         * cp-support.c: Revert.
2378         * cp-namespace.c: Revert.
2379         * cp-abi.c: Revert.
2380         * corelow.c: Revert.
2381         * corefile.c: Revert.
2382         * continuations.c: Revert.
2383         * completer.h: Revert.
2384         * completer.c: Revert.
2385         * complaints.c: Revert.
2386         * coffread.c: Revert.
2387         * coff-pe-read.c: Revert.
2388         * cli-out.h: Revert.
2389         * cli-out.c: Revert.
2390         * charset.c: Revert.
2391         * c-varobj.c: Revert.
2392         * c-valprint.c: Revert.
2393         * c-typeprint.c: Revert.
2394         * c-lang.c: Revert.
2395         * buildsym.c: Revert.
2396         * buildsym-legacy.c: Revert.
2397         * build-id.h: Revert.
2398         * build-id.c: Revert.
2399         * btrace.c: Revert.
2400         * bsd-uthread.c: Revert.
2401         * breakpoint.h: Revert.
2402         * breakpoint.c: Revert.
2403         * break-catch-throw.c: Revert.
2404         * break-catch-syscall.c: Revert.
2405         * break-catch-sig.c: Revert.
2406         * blockframe.c: Revert.
2407         * block.c: Revert.
2408         * bfin-tdep.c: Revert.
2409         * bfin-linux-tdep.c: Revert.
2410         * bfd-target.c: Revert.
2411         * bcache.c: Revert.
2412         * ax-general.c: Revert.
2413         * ax-gdb.h: Revert.
2414         * ax-gdb.c: Revert.
2415         * avr-tdep.c: Revert.
2416         * auxv.c: Revert.
2417         * auto-load.c: Revert.
2418         * arm-wince-tdep.c: Revert.
2419         * arm-tdep.c: Revert.
2420         * arm-symbian-tdep.c: Revert.
2421         * arm-pikeos-tdep.c: Revert.
2422         * arm-obsd-tdep.c: Revert.
2423         * arm-nbsd-tdep.c: Revert.
2424         * arm-nbsd-nat.c: Revert.
2425         * arm-linux-tdep.c: Revert.
2426         * arm-linux-nat.c: Revert.
2427         * arm-fbsd-tdep.c: Revert.
2428         * arm-fbsd-nat.c: Revert.
2429         * arm-bsd-tdep.c: Revert.
2430         * arch-utils.c: Revert.
2431         * arc-tdep.c: Revert.
2432         * arc-newlib-tdep.c: Revert.
2433         * annotate.h: Revert.
2434         * annotate.c: Revert.
2435         * amd64-windows-tdep.c: Revert.
2436         * amd64-windows-nat.c: Revert.
2437         * amd64-tdep.c: Revert.
2438         * amd64-sol2-tdep.c: Revert.
2439         * amd64-obsd-tdep.c: Revert.
2440         * amd64-obsd-nat.c: Revert.
2441         * amd64-nbsd-tdep.c: Revert.
2442         * amd64-nbsd-nat.c: Revert.
2443         * amd64-nat.c: Revert.
2444         * amd64-linux-tdep.c: Revert.
2445         * amd64-linux-nat.c: Revert.
2446         * amd64-fbsd-tdep.c: Revert.
2447         * amd64-fbsd-nat.c: Revert.
2448         * amd64-dicos-tdep.c: Revert.
2449         * amd64-darwin-tdep.c: Revert.
2450         * amd64-bsd-nat.c: Revert.
2451         * alpha-tdep.c: Revert.
2452         * alpha-obsd-tdep.c: Revert.
2453         * alpha-nbsd-tdep.c: Revert.
2454         * alpha-mdebug-tdep.c: Revert.
2455         * alpha-linux-tdep.c: Revert.
2456         * alpha-linux-nat.c: Revert.
2457         * alpha-bsd-tdep.c: Revert.
2458         * alpha-bsd-nat.c: Revert.
2459         * aix-thread.c: Revert.
2460         * agent.c: Revert.
2461         * addrmap.c: Revert.
2462         * ada-varobj.c: Revert.
2463         * ada-valprint.c: Revert.
2464         * ada-typeprint.c: Revert.
2465         * ada-tasks.c: Revert.
2466         * ada-lang.c: Revert.
2467         * aarch64-tdep.c: Revert.
2468         * aarch64-ravenscar-thread.c: Revert.
2469         * aarch64-newlib-tdep.c: Revert.
2470         * aarch64-linux-tdep.c: Revert.
2471         * aarch64-linux-nat.c: Revert.
2472         * aarch64-fbsd-tdep.c: Revert.
2473         * aarch64-fbsd-nat.c: Revert.
2474         * aarch32-linux-nat.c: Revert.
2475
2476 2019-04-05  Tom Tromey  <tom@tromey.com>
2477
2478         * ft32-tdep.c: Sort headers.
2479         * frv-tdep.c: Sort headers.
2480         * frv-linux-tdep.c: Sort headers.
2481         * frame.c: Sort headers.
2482         * frame-unwind.c: Sort headers.
2483         * frame-base.c: Sort headers.
2484         * fork-child.c: Sort headers.
2485         * findvar.c: Sort headers.
2486         * findcmd.c: Sort headers.
2487         * filesystem.c: Sort headers.
2488         * filename-seen-cache.h: Sort headers.
2489         * filename-seen-cache.c: Sort headers.
2490         * fbsd-tdep.c: Sort headers.
2491         * fbsd-nat.h: Sort headers.
2492         * fbsd-nat.c: Sort headers.
2493         * f-valprint.c: Sort headers.
2494         * f-typeprint.c: Sort headers.
2495         * f-lang.c: Sort headers.
2496         * extension.h: Sort headers.
2497         * extension.c: Sort headers.
2498         * extension-priv.h: Sort headers.
2499         * expprint.c: Sort headers.
2500         * exec.h: Sort headers.
2501         * exec.c: Sort headers.
2502         * exceptions.c: Sort headers.
2503         * event-top.c: Sort headers.
2504         * event-loop.c: Sort headers.
2505         * eval.c: Sort headers.
2506         * elfread.c: Sort headers.
2507         * dwarf2read.h: Sort headers.
2508         * dwarf2read.c: Sort headers.
2509         * dwarf2loc.c: Sort headers.
2510         * dwarf2expr.h: Sort headers.
2511         * dwarf2expr.c: Sort headers.
2512         * dwarf2-frame.c: Sort headers.
2513         * dwarf2-frame-tailcall.c: Sort headers.
2514         * dwarf-index-write.h: Sort headers.
2515         * dwarf-index-write.c: Sort headers.
2516         * dwarf-index-common.c: Sort headers.
2517         * dwarf-index-cache.h: Sort headers.
2518         * dwarf-index-cache.c: Sort headers.
2519         * dummy-frame.c: Sort headers.
2520         * dtrace-probe.c: Sort headers.
2521         * disasm.h: Sort headers.
2522         * disasm.c: Sort headers.
2523         * disasm-selftests.c: Sort headers.
2524         * dictionary.c: Sort headers.
2525         * dicos-tdep.c: Sort headers.
2526         * demangle.c: Sort headers.
2527         * dcache.h: Sort headers.
2528         * dcache.c: Sort headers.
2529         * darwin-nat.h: Sort headers.
2530         * darwin-nat.c: Sort headers.
2531         * darwin-nat-info.c: Sort headers.
2532         * d-valprint.c: Sort headers.
2533         * d-namespace.c: Sort headers.
2534         * d-lang.c: Sort headers.
2535         * ctf.c: Sort headers.
2536         * csky-tdep.c: Sort headers.
2537         * csky-linux-tdep.c: Sort headers.
2538         * cris-tdep.c: Sort headers.
2539         * cris-linux-tdep.c: Sort headers.
2540         * cp-valprint.c: Sort headers.
2541         * cp-support.c: Sort headers.
2542         * cp-namespace.c: Sort headers.
2543         * cp-abi.c: Sort headers.
2544         * corelow.c: Sort headers.
2545         * corefile.c: Sort headers.
2546         * continuations.c: Sort headers.
2547         * completer.h: Sort headers.
2548         * completer.c: Sort headers.
2549         * complaints.c: Sort headers.
2550         * coffread.c: Sort headers.
2551         * coff-pe-read.c: Sort headers.
2552         * cli-out.h: Sort headers.
2553         * cli-out.c: Sort headers.
2554         * charset.c: Sort headers.
2555         * c-varobj.c: Sort headers.
2556         * c-valprint.c: Sort headers.
2557         * c-typeprint.c: Sort headers.
2558         * c-lang.c: Sort headers.
2559         * buildsym.c: Sort headers.
2560         * buildsym-legacy.c: Sort headers.
2561         * build-id.h: Sort headers.
2562         * build-id.c: Sort headers.
2563         * btrace.c: Sort headers.
2564         * bsd-uthread.c: Sort headers.
2565         * breakpoint.h: Sort headers.
2566         * breakpoint.c: Sort headers.
2567         * break-catch-throw.c: Sort headers.
2568         * break-catch-syscall.c: Sort headers.
2569         * break-catch-sig.c: Sort headers.
2570         * blockframe.c: Sort headers.
2571         * block.c: Sort headers.
2572         * bfin-tdep.c: Sort headers.
2573         * bfin-linux-tdep.c: Sort headers.
2574         * bfd-target.c: Sort headers.
2575         * bcache.c: Sort headers.
2576         * ax-general.c: Sort headers.
2577         * ax-gdb.h: Sort headers.
2578         * ax-gdb.c: Sort headers.
2579         * avr-tdep.c: Sort headers.
2580         * auxv.c: Sort headers.
2581         * auto-load.c: Sort headers.
2582         * arm-wince-tdep.c: Sort headers.
2583         * arm-tdep.c: Sort headers.
2584         * arm-symbian-tdep.c: Sort headers.
2585         * arm-pikeos-tdep.c: Sort headers.
2586         * arm-obsd-tdep.c: Sort headers.
2587         * arm-nbsd-tdep.c: Sort headers.
2588         * arm-nbsd-nat.c: Sort headers.
2589         * arm-linux-tdep.c: Sort headers.
2590         * arm-linux-nat.c: Sort headers.
2591         * arm-fbsd-tdep.c: Sort headers.
2592         * arm-fbsd-nat.c: Sort headers.
2593         * arm-bsd-tdep.c: Sort headers.
2594         * arch-utils.c: Sort headers.
2595         * arc-tdep.c: Sort headers.
2596         * arc-newlib-tdep.c: Sort headers.
2597         * annotate.h: Sort headers.
2598         * annotate.c: Sort headers.
2599         * amd64-windows-tdep.c: Sort headers.
2600         * amd64-windows-nat.c: Sort headers.
2601         * amd64-tdep.c: Sort headers.
2602         * amd64-sol2-tdep.c: Sort headers.
2603         * amd64-obsd-tdep.c: Sort headers.
2604         * amd64-obsd-nat.c: Sort headers.
2605         * amd64-nbsd-tdep.c: Sort headers.
2606         * amd64-nbsd-nat.c: Sort headers.
2607         * amd64-nat.c: Sort headers.
2608         * amd64-linux-tdep.c: Sort headers.
2609         * amd64-linux-nat.c: Sort headers.
2610         * amd64-fbsd-tdep.c: Sort headers.
2611         * amd64-fbsd-nat.c: Sort headers.
2612         * amd64-dicos-tdep.c: Sort headers.
2613         * amd64-darwin-tdep.c: Sort headers.
2614         * amd64-bsd-nat.c: Sort headers.
2615         * alpha-tdep.c: Sort headers.
2616         * alpha-obsd-tdep.c: Sort headers.
2617         * alpha-nbsd-tdep.c: Sort headers.
2618         * alpha-mdebug-tdep.c: Sort headers.
2619         * alpha-linux-tdep.c: Sort headers.
2620         * alpha-linux-nat.c: Sort headers.
2621         * alpha-bsd-tdep.c: Sort headers.
2622         * alpha-bsd-nat.c: Sort headers.
2623         * aix-thread.c: Sort headers.
2624         * agent.c: Sort headers.
2625         * addrmap.c: Sort headers.
2626         * ada-varobj.c: Sort headers.
2627         * ada-valprint.c: Sort headers.
2628         * ada-typeprint.c: Sort headers.
2629         * ada-tasks.c: Sort headers.
2630         * ada-lang.c: Sort headers.
2631         * aarch64-tdep.c: Sort headers.
2632         * aarch64-ravenscar-thread.c: Sort headers.
2633         * aarch64-newlib-tdep.c: Sort headers.
2634         * aarch64-linux-tdep.c: Sort headers.
2635         * aarch64-linux-nat.c: Sort headers.
2636         * aarch64-fbsd-tdep.c: Sort headers.
2637         * aarch64-fbsd-nat.c: Sort headers.
2638         * aarch32-linux-nat.c: Sort headers.
2639
2640 2019-04-04  Tom Tromey  <tom@tromey.com>
2641
2642         * varobj.c (varobj_create): Update.
2643         * rust-exp.y (struct rust_parser) <update_innermost_block,
2644         lookup_symbol>: New methods.
2645         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2646         Rename.
2647         (rust_parser::rust_lookup_type)
2648         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2649         * printcmd.c (display_command, do_one_display): Update.
2650         * parser-defs.h (struct parser_state) <parser_state>: Add
2651         "tracker" parameter.
2652         (block_tracker): New member.
2653         (class innermost_block_tracker) <innermost_block_tracker>: Add
2654         "types" parameter.
2655         <reset>: Remove method.
2656         (innermost_block): Don't declare.
2657         (null_post_parser): Update.
2658         * parse.c (innermost_block): Remove global.
2659         (write_dollar_variable): Update.
2660         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2661         Remove "tracker_types" parameter.
2662         (parse_expression): Add "tracker" parameter.
2663         (parse_expression_for_completion): Update.
2664         (null_post_parser): Add "tracker" parameter.
2665         * p-exp.y: Update rules.
2666         * m2-exp.y: Update rules.
2667         * language.h (struct language_defn) <la_post_parser>: Add
2668         "tracker" parameter.
2669         * go-exp.y: Update rules.
2670         * f-exp.y: Update rules.
2671         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2672         parameter.
2673         * d-exp.y: Update rules.
2674         * c-exp.y: Update rules.
2675         * breakpoint.c (set_breakpoint_condition): Create an
2676         innermost_block_tracker.
2677         (watch_command_1): Likewise.
2678         * ada-lang.c (resolve): Add "tracker" parameter.
2679         (resolve_subexp): Likewise.
2680         * ada-exp.y (write_var_from_sym): Update.
2681
2682 2019-04-04  Tom Tromey  <tom@tromey.com>
2683
2684         * type-stack.h: New file.
2685         * type-stack.c: New file.
2686         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2687         type-stack.h.
2688         (insert_into_type_stack, insert_type, push_type, push_type_int)
2689         (insert_type_address_space, pop_type, pop_type_int)
2690         (pop_typelist, pop_type_stack, append_type_stack)
2691         (push_type_stack, get_type_stack, push_typelist)
2692         (follow_type_instance_flags, follow_types): Don't declare.
2693         * parse.c (type_stack): Remove global.
2694         (parse_exp_in_context): Update.
2695         (insert_into_type_stack, insert_type, push_type, push_type_int)
2696         (insert_type_address_space, pop_type, pop_type_int)
2697         (pop_typelist, pop_type_stack, append_type_stack)
2698         (push_type_stack, get_type_stack, push_typelist)
2699         (follow_type_instance_flags, follow_types): Remove (moved to
2700         type-stack.c).
2701         * f-exp.y (type_stack): New global.
2702         Update rules.
2703         (push_kind_type, f_parse): Update.
2704         * d-exp.y (type_stack): New global.
2705         Update rules.
2706         (d_parse): Update.
2707         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2708         Update rules.
2709         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2710         (HFILES_NO_SRCDIR): Add type-stack.h.
2711
2712 2019-04-04  Tom Tromey  <tom@tromey.com>
2713
2714         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2715         (rust_parser::convert_ast_to_expression, rust_parse)
2716         (rust_lex_test_completion, rust_lex_tests): Update.
2717         * parser-defs.h (struct expr_completion_state): New.
2718         (struct parser_state) <parser_state>: Add completion parameter.
2719         <mark_struct_expression, mark_completion_tag>: New methods.
2720         <parse_completion, m_completion_state>: New members.
2721         (prefixify_expression, null_post_parser): Update.
2722         (mark_struct_expression, mark_completion_tag): Don't declare.
2723         * parse.c (parse_completion, expout_last_struct)
2724         (expout_tag_completion_type, expout_completion_name): Remove
2725         globals.
2726         (parser_state::mark_struct_expression)
2727         (parser_state::mark_completion_tag): Now methods.
2728         (prefixify_expression): Add last_struct parameter.
2729         (prefixify_subexp): Likewise.
2730         (parse_exp_1): Update.
2731         (parse_exp_in_context): Add cstate parameter.  Update.
2732         (parse_expression_for_completion): Create an
2733         expr_completion_state.
2734         (null_post_parser): Add "completion" parameter.
2735         * p-exp.y: Update rules.
2736         (yylex): Update.
2737         * language.h (struct language_defn) <la_post_parser>: Add
2738         "completing" parameter.
2739         * go-exp.y: Update rules.
2740         (lex_one_token): Update.
2741         * expression.h (parse_completion): Don't declare.
2742         * d-exp.y: Update rules.
2743         (lex_one_token): Update rules.
2744         * c-exp.y: Update rules.
2745         (lex_one_token): Update.
2746         * ada-lang.c (resolve): Add "parse_completion" parameter.
2747         (resolve_subexp): Likewise.
2748         (ada_resolve_function): Likewise.
2749
2750 2019-04-04  Tom Tromey  <tom@tromey.com>
2751
2752         * parser-defs.h (struct parser_state) <start_arglist,
2753         end_arglist>: New methods.
2754         <arglist_len, m_funcall_chain>: New members.
2755         (arglist_len, start_arglist, end_arglist): Don't declare.
2756         * parse.c (arglist_len, funcall_chain): Remove global.
2757         (start_arglist, end_arglist): Remove functions.
2758         (parse_exp_in_context): Update.
2759         * p-exp.y: Update rules.
2760         * m2-exp.y: Update rules.
2761         * go-exp.y: Update rules.
2762         * f-exp.y: Update rules.
2763         * d-exp.y: Update rules.
2764         * c-exp.y: Update rules.
2765
2766 2019-04-04  Tom Tromey  <tom@tromey.com>
2767
2768         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2769         lex_operator, push_back>: New methods.
2770         Update all rules.
2771         (rust_parser::lex_hex, lex_escape): Rename and update.
2772         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2773         (rust_parser::lex_operator): Rename and update.
2774         (rust_parser::lex_number, rustyylex, rustyyerror)
2775         (rust_lex_test_init, rust_lex_test_sequence)
2776         (rust_lex_test_push_back, rust_lex_tests): Update.
2777         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2778         parameter.
2779         <lexptr, prev_lexptr>: New members.
2780         (lexptr, prev_lexptr): Don't declare.
2781         * parse.c (lexptr, prev_lexptr): Remove globals.
2782         (parse_exp_in_context): Update.
2783         * p-exp.y (yylex, yyerror): Update.
2784         * m2-exp.y (parse_number, yylex, yyerror): Update.
2785         * go-exp.y (lex_one_token, yyerror): Update.
2786         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2787         * d-exp.y (lex_one_token, yyerror): Update.
2788         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2789         (lex_one_token, yyerror): Update.
2790         * ada-lex.l (YY_INPUT): Update.
2791         (rewind_to_char): Update.
2792         * ada-exp.y (yyerror): Update.
2793
2794 2019-04-04  Tom Tromey  <tom@tromey.com>
2795
2796         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2797         * parser-defs.h (struct parser_state) <parser_state>: Add new
2798         parameter.
2799         <comma_terminates>: New member.
2800         (comma_terminates): Don't declare global.
2801         * parse.c (comma_terminates): Remove global.
2802         (parse_exp_in_context): Update.
2803         * p-exp.y (yylex): Update.
2804         * m2-exp.y (yylex): Update.
2805         * go-exp.y (lex_one_token): Update.
2806         * f-exp.y (yylex): Update.
2807         * d-exp.y (lex_one_token): Update.
2808         * c-exp.y (lex_one_token): Update.
2809         * ada-lex.l: Update.
2810
2811 2019-04-04  Tom Tromey  <tom@tromey.com>
2812
2813         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2814         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2815         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2816         * parser-defs.h (paren_depth): Don't declare.
2817         * parse.c (paren_depth): Remove global.
2818         (parse_exp_in_context): Update.
2819         * p-exp.y (paren_depth): New global.
2820         (pascal_parse): Initialize it.
2821         * m2-exp.y (paren_depth): New global.
2822         (m2_parse): Initialize it.
2823         * go-exp.y (paren_depth): New global.
2824         (go_parse): Initialize it.
2825         * f-exp.y (paren_depth): New global.
2826         (f_parse): Initialize it.
2827         * d-exp.y (paren_depth): New global.
2828         (d_parse): Initialize it.
2829         * c-exp.y (paren_depth): New global.
2830         (c_parse): Initialize it.
2831         * ada-lex.l (paren_depth): New global.
2832         (lexer_init): Initialize it.
2833
2834 2019-04-04  Tom Tromey  <tom@tromey.com>
2835
2836         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2837         (rust_parser::convert_ast_to_type)
2838         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2839         * parser-defs.h (struct parser_state) <parser_state>: Add
2840         parameters.  Initialize new members.
2841         <expression_context_block, expression_context_pc>: New members.
2842         * parse.c (expression_context_block, expression_context_pc):
2843         Remove globals.
2844         (parse_exp_in_context): Update.
2845         * p-exp.y: Update all rules.
2846         (yylex): Update.
2847         * m2-exp.y: Update all rules.
2848         (yylex): Update.
2849         * go-exp.y (yylex): Update.
2850         * f-exp.y (yylex): Update.
2851         * d-exp.y: Update all rules.
2852         (yylex): Update.
2853         * c-exp.y: Update all rules.
2854         (lex_one_token, classify_name, yylex, c_parse): Update.
2855         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2856
2857 2019-04-04  Tom Tromey  <tom@tromey.com>
2858
2859         * gdbarch.h, gdbarch.c: Rebuild.
2860         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2861         * stap-probe.h:
2862         (struct stap_parse_info): Replace "parser_state" with
2863         "expr_builder".
2864         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2865         (parser_state): New class.
2866         * parse.c (expr_builder): Rename.
2867         (expr_builder::release): Rename.
2868         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2869         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2870         (write_exp_elt_longcst, write_exp_elt_floatcst)
2871         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2872         (write_exp_string_vector, write_exp_bitstring)
2873         (write_exp_msymbol, mark_struct_expression)
2874         (write_dollar_variable)
2875         (insert_type_address_space, increase_expout_size): Replace
2876         "parser_state" with "expr_builder".
2877         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2878         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2879         "parser_state" with "expr_builder".
2880
2881 2019-04-04  Tom Tromey  <tom@tromey.com>
2882
2883         * rust-exp.y: Replace "parse_language" with method call.
2884         * p-exp.y:
2885         (yylex): Replace "parse_language" with method call.
2886         * m2-exp.y:
2887         (yylex): Replace "parse_language" with method call.
2888         * go-exp.y (classify_name): Replace "parse_language" with method
2889         call.
2890         * f-exp.y (yylex): Replace "parse_language" with method call.
2891         * d-exp.y (lex_one_token): Replace "parse_language" with method
2892         call.
2893         * c-exp.y:
2894         (lex_one_token, classify_name, yylex): Replace "parse_language"
2895         with method call.
2896         * ada-exp.y (find_primitive_type, type_char)
2897         (type_system_address): Replace "parse_language" with method call.
2898
2899 2019-04-04  Tom Tromey  <tom@tromey.com>
2900
2901         * rust-exp.y: Replace "parse_gdbarch" with method call.
2902         * parse.c (write_dollar_variable, insert_type_address_space):
2903         Replace "parse_gdbarch" with method call.
2904         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2905         call.
2906         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2907         call.
2908         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2909         "parse_gdbarch" with method call.
2910         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2911         with method call.
2912         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2913         "parse_gdbarch" with method call.
2914         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2915         "parse_gdbarch" with method call.
2916         * c-exp.y (parse_type, parse_number, classify_name): Replace
2917         "parse_gdbarch" with method call.
2918         * ada-lex.l: Replace "parse_gdbarch" with method call.
2919         * ada-exp.y (parse_type, find_primitive_type, type_char)
2920         (type_system_address): Replace "parse_gdbarch" with method call.
2921
2922 2019-04-04  Tom Tromey  <tom@tromey.com>
2923
2924         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2925         * stap-probe.c (stap_parse_argument): Update.
2926         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2927         initial_size parameter.
2928         * rust-exp.y (rust_lex_tests): Update.
2929         * parse.c (parser_state): Update.
2930         (parse_exp_in_context): Update.
2931         * parser-defs.h (struct parser_state) <parser_state>: Remove
2932         "initial_size" parameter.
2933
2934 2019-04-04  Tom Tromey  <tom@tromey.com>
2935
2936         * parser-defs.h (increase_expout_size): Don't declare.
2937         * parse.c (increase_expout_size): Now static.
2938
2939 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2940
2941         * gnu-nat.c (gnu_nat_target::wait): Fix
2942         target_waitstatus_to_string call.
2943
2944 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2945
2946         * eval.c (evaluate_subexp_standard): Handle internal functions
2947         during Fortran function call handling.
2948
2949 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * NEWS: Mention new internal functions.
2952         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2953         (read_base_type): Use dwarf2_init_complex_target_type.
2954         * value.c (creal_internal_fn): New function.
2955         (cimag_internal_fn): New function.
2956         (_initialize_values): Register new internal functions.
2957
2958 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2959
2960         * infrun.c (stop_all_threads): If debug_infrun, always
2961         trace the wait status after wait_one, using
2962         target_waitstatus_to_string and target_pid_to_str.
2963         (handle_inferior_event): Replace various trace of
2964         wait status kind by a single trace.
2965         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2966         wait status kind image by target_waitstatus_to_string.
2967         * target/waitstatus.c (target_waitstatus_to_string): Fix
2968         obsolete comment.
2969
2970 2019-04-01  Tom Tromey  <tromey@adacore.com>
2971
2972         PR symtab/23331:
2973         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2974
2975 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2976             Pedro Alves  <palves@redhat.com>
2977
2978         * top.c (quit_force): Call 'finalize_values'.
2979         * value.c (finalize_values): New function.
2980         * value.h (finalize_values): Declare.
2981
2982 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2983
2984         * NEWS: Announce $_gdb_major and $_gdb_minor.
2985
2986         * top.c (init_gdb_version_vars): New function.
2987         (gdb_init): Call init_gdb_version_vars.
2988
2989 2019-03-29  Tom Tromey  <tromey@adacore.com>
2990
2991         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2992         help text.  Remove dead code.
2993
2994 2019-03-29  Keith Seitz  <keiths@redhat.com>
2995
2996         From Siddhesh Poyarekar:
2997         * f-lang.h (f77_get_upperbound): Return LONGEST.
2998         (f77_get_lowerbound): Likewise.
2999         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3000         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3001         print them.
3002         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3003         plongest to format print it.
3004         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3005         (f77_get_upperbound): Likewise.
3006         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3007         LOWER_BOUND to LONGEST.
3008         (f77_create_arrayprint_offset_tbl): Likewise.
3009
3010 2019-03-29  Keith Seitz  <keiths@redhat.com>
3011
3012         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3013         %s/pulongest for TYPE_LENGTH instead of %d in format
3014         strings.
3015         * ada-typerint.c (ada_print_type): Likewise.
3016         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3017         * compile/compile-c-support.c (generate_register_struct): Likewise.
3018         * gdbtypes.c (recursive_dump_type): Likewise.
3019         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3020         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3021         instead of %d in format strings.
3022         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3023         to std::min to ULONGEST.
3024         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3025         instead of %d in format strings.
3026         * tracepoint.c (info_scope_command): Likewise.
3027         * typeprint.c (print_offset_data::update)
3028         (print_offset_data::finish): Likewise.
3029         * xtensa-tdep.c (xtensa_store_return_value)
3030         (xtensa_push_dummy_call): Likewise.
3031
3032 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3033
3034         * windows-nat.c (display_selector): Fixed format specifications
3035         for 64-bit Cygwin.
3036
3037 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3038
3039         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3040
3041 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3042
3043         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3044         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3045         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3046         (nios2_linux_init_abi): Install it.
3047
3048 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3049
3050         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3051
3052 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3053
3054         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3055
3056 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3057             Tom Tromey  <tromey@adacore.com>
3058
3059         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3060
3061 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3062
3063         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3064         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3065         method to compute the bounds of range types. Also print "[evaluated]"
3066         if the bounds' values come from a dynamic evaluation.
3067
3068 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3071         whitespace when pretty printing is on.
3072
3073 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3074
3075         * ppc-linux-nat.c: Add include.
3076
3077 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3078
3079         * NEWS: Mention AArch64 Pointer Authentication.
3080
3081 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3082
3083         * arm-linux-nat.c: Add include.
3084
3085 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3086
3087         * source-cache.c (source_cache::get_source_lines): Re-read
3088         fullname after calling open_source_file.
3089
3090 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3091
3092         * NEWS: Mention TLS support for FreeBSD.
3093
3094 2019-03-25  Tom Tromey  <tromey@adacore.com>
3095
3096         * minsyms.c (BUNCH_SIZE): Update comment.
3097         (~minimal_symbol_reader): Remove old comment.
3098         (compact_minimal_symbols): Update comment.
3099         (minimal_symbol_reader::install): Remove old comment.  Update
3100         other comments.
3101
3102 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3103
3104         * s390-linux-nat.c: Add include.
3105
3106 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3107
3108         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3109         Call linux_get_hwcap.
3110         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3111         Likewise.
3112         (aarch64_linux_get_hwcap): Remove function.
3113         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3114         declaration.
3115         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3116         linux_get_hwcap.
3117         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3118         * linux-tdep.c (linux_get_hwcap): Add function.
3119         (linux_get_hwcap2): Likewise.
3120         * linux-tdep.h (linux_get_hwcap): Add declaration.
3121         (linux_get_hwcap2): Likewise.
3122         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3123         (ppc_linux_get_hwcap2): Likewise.
3124         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3125         linux_get_hwcap.
3126         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3127         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3128         (ppc_linux_nat_target::read_description): Likewise.
3129         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3130         * s390-linux-nat.c: Likewise.
3131         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3132
3133 2019-03-24  Tom Tromey  <tom@tromey.com>
3134
3135         * ada-lang.c (standard_lookup): Simplify initialization.
3136         (ada_lookup_symbol_nonlocal): Simplify return.
3137         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3138         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3139         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3140         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3141         initialization.
3142         * solib.c (solib_global_lookup): Simplify.
3143         * symtab.c (null_block_symbol): Remove.
3144         (symbol_cache_lookup): Simplify returns.
3145         (lookup_language_this): Simplify returns.
3146         (lookup_symbol_aux): Simplify return.
3147         (lookup_local_symbol): Simplify returns.
3148         (lookup_global_symbol_from_objfile): Simplify return.
3149         (lookup_symbol_in_objfile_symtabs)
3150         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3151         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3152         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3153         * cp-namespace.c (cp_lookup_bare_symbol)
3154         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3155         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3156         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3157         (cp_lookup_symbol_via_imports): Simplify initialization.
3158         (find_symbol_in_baseclass): Likewise.
3159         * symtab.h (null_block_symbol): Remove.
3160         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3161         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3162         (d_lookup_symbol_module): Likewise.
3163         (find_symbol_in_baseclass): Simplify initialization.
3164
3165 2019-03-24  Tom Tromey  <tom@tromey.com>
3166
3167         * expression.h: Don't include symtab.h.
3168         (struct block): Forward declare.
3169
3170 2019-03-24  Tom Tromey  <tom@tromey.com>
3171
3172         * c-exp.y (typebase): Remove casts.
3173         * gdbtypes.c (lookup_unsigned_typename, )
3174         (lookup_signed_typename): Remove cast.
3175         * eval.c (parse_to_comma_and_eval): Remove cast.
3176         * parse.c (write_dollar_variable): Remove cast.
3177         * block.h (struct block) <superblock>: Now const.
3178         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3179         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3180         (map_block): Make "block" const.
3181         * symfile.h (struct quick_symbol_functions)
3182         <map_matching_symbols>: Constify block argument to "callback".
3183         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3184         const.
3185         (find_pc_sect_compunit_symtab): Make "b" const.
3186         (find_symbol_at_address): Likewise.
3187         (search_symbols): Likewise.
3188         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3189         (dw2_debug_names_lookup_symbol): Likewise.
3190         (dw2_map_matching_symbols): Update.
3191         * p-valprint.c (pascal_val_print): Remove "block".
3192         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3193         (aux_add_nonlocal_symbols): Make "block" const.
3194         (resolve_subexp): Remove cast.
3195         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3196         const.
3197         (iterate_over_file_blocks): Likewise.
3198         * f-exp.y (%union) <bval>: Remove.
3199         * coffread.c (patch_opaque_types): Make "b" const.
3200         * spu-tdep.c (spu_catch_start): Make "block" const.
3201         * c-valprint.c (print_unpacked_pointer): Remove "block".
3202         * symmisc.c (dump_symtab_1): Make "b" const.
3203         (block_depth): Make "block" const.
3204         * d-exp.y (%union) <bval>: Remove.
3205         * cp-support.h (cp_lookup_rtti_type): Update.
3206         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3207         * psymtab.c (psym_lookup_symbol): Make "block" const.
3208         (maintenance_check_psymtabs): Make "b" const.
3209         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3210         (enumerate_locals, enumerate_args): Update.
3211         * python/py-symtab.c (stpy_global_block): Make "block" const.
3212         (stpy_static_block): Likewise.
3213         * inline-frame.c (block_starting_point_at): Make "new_block"
3214         const.
3215         * block.c (find_block_in_blockvector): Make return type const.
3216         (blockvector_for_pc_sect): Make "b" const.
3217         (find_block_in_blockvector): Make "b" const.
3218
3219 2019-03-23  Tom Tromey  <tom@tromey.com>
3220
3221         * varobj.c (varobj_create): Update.
3222         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3223         * printcmd.c (display_command, do_one_display): Don't reset
3224         innermost_block.
3225         * parser-defs.h (enum innermost_block_tracker_type): Move to
3226         expression.h.
3227         (innermost_block): Update comment.
3228         * parse.c (parse_exp_1): Add tracker_types parameter.
3229         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3230         tracker_types parameter.  Reset innermost_block.
3231         (parse_exp_in_context): Remove.
3232         (parse_expression_for_completion): Update.
3233         * objfiles.c (~objfile): Don't reset expression_context_block or
3234         innermost_block.
3235         * expression.h (enum innermost_block_tracker_type): Move from
3236         parser-defs.h.
3237         (parse_exp_1): Add tracker_types parameter.
3238         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3239         reset innermost_block.
3240
3241 2019-03-23  Tom Tromey  <tom@tromey.com>
3242
3243         * objfiles.h: Include bcache.h.
3244
3245 2019-03-23  Tom Tromey  <tom@tromey.com>
3246
3247         * linespec.c (get_current_search_block): Use
3248         scoped_restore_current_language.
3249         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3250
3251 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3252             Jiong Wang  <jiong.wang@arm.com>
3253
3254         * aarch64-linux-tdep.c
3255         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3256         section.
3257         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3258
3259 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3260             Jiong Wang  <jiong.wang@arm.com>
3261
3262         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3263         instructions.
3264         (aarch64_analyze_prologue_test): Add PACIASP test.
3265         (aarch64_prologue_prev_register): Unmask PC value.
3266
3267 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3268             Jiong Wang  <jiong.wang@arm.com>
3269
3270         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3271         (aarch64_dwarf2_prev_register): Unmask PC value.
3272         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3273         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3274         DW_CFA_AARCH64_negate_ra_state.
3275         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3276
3277 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3278             Jiong Wang  <jiong.wang@arm.com>
3279
3280         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3281         registers.
3282         (aarch64_pseudo_register_name): Likewise.
3283         (aarch64_pseudo_register_type): Likewise.
3284         (aarch64_pseudo_register_reggroup_p): Likewise.
3285         (aarch64_gdbarch_init): Add pauth registers.
3286         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3287         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3288         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3289         (struct gdbarch_tdep): Add regnum for ra_state.
3290
3291 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3292             Jiong Wang  <jiong.wang@arm.com>
3293
3294         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3295
3296 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3297             Jiong Wang  <jiong.wang@arm.com>
3298
3299         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3300         function.
3301         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3302         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3303         (aarch64_gdbarch_init): Add puth registers.
3304         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3305         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3306         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3307
3308 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3309             Jiong Wang  <jiong.wang@arm.com>
3310
3311         * aarch64-linux-nat.c
3312         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3313         * aarch64-linux-tdep.c
3314         (aarch64_linux_core_read_description): Likewise.
3315         (aarch64_linux_get_hwcap): New function.
3316         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3317         (aarch64_linux_get_hwcap): New declaration.
3318
3319 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3320             Jiong Wang  <jiong.wang@arm.com>
3321
3322         * aarch64-linux-nat.c
3323         (aarch64_linux_nat_target::read_description): Add pauth param.
3324         * aarch64-linux-tdep.c
3325         (aarch64_linux_core_read_description): Likewise.
3326         * aarch64-tdep.c (struct target_desc): Add in pauth.
3327         (aarch64_read_description): Add pauth param.
3328         (aarch64_gdbarch_init): Likewise.
3329         * aarch64-tdep.h (aarch64_read_description): Likewise.
3330         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3331         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3332         * features/Makefile: Add new files.
3333         * features/aarch64-pauth.c: New file.
3334         * features/aarch64-pauth.xml: New file.
3335
3336 2019-03-20  Tom Tromey  <tromey@adacore.com>
3337
3338         * infrun.c (handle_inferior_event): Rename from
3339         handle_inferior_event_1.  Create a scoped_value_mark.
3340         (handle_inferior_event): Remove.
3341
3342 2019-03-19  Tom Tromey  <tromey@adacore.com>
3343
3344         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3345         * infrun.h (print_stop_event): Add "displays" parameter.
3346         * infrun.c (print_stop_event): Add "displays" parameter.
3347
3348 2019-03-19  Pedro Alves  <palves@redhat.com>
3349
3350         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3351         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3352         to -1.  Fix TABs vs spaces.
3353         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3354         * tui/tui-out.h (tui_ui_out) Add intro comments.
3355         <m_line, m_start_of_line>: In-class initialize, and add describing
3356         comment.
3357
3358 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3359
3360         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3361         variable names.
3362         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3363
3364 2019-03-18  Pedro Alves  <palves@redhat.com>
3365             Eli Zaretskii <eliz@gnu.org>
3366
3367         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3368         m_line and m_start_of_line.
3369
3370 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3371
3372         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3373         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3374         it returns a newline.  This fixes a regression in TU mode, whereby
3375         the next line is output on the same screen line as the user input.
3376
3377 2019-03-18  Tom Tromey  <tromey@adacore.com>
3378
3379         * minsyms.c (minimal_symbol_reader::install): Remove call to
3380         obstack_blank.
3381
3382 2019-03-18  Pedro Alves  <palves@redhat.com>
3383
3384         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3385         New globals.
3386         (apply_style): New, factored out from ...
3387         (apply_ansi_escape): ... this.  Handle reverse video mode.
3388         (tui_set_reverse_mode): New function.
3389         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3390         * tui/tui-winsource.c (tui_show_source_line): Use
3391         tui_set_reverse_mode instead of setting A_STANDOUT.
3392         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3393         New setter methods.
3394
3395 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3396
3397         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3398         Handle tabs.
3399
3400 2019-03-18  Tom Tromey  <tromey@adacore.com>
3401
3402         * ada-lang.c (empty_array): Add "high" parameter.
3403         (ada_evaluate_subexp): Update.
3404
3405 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3406
3407         * unittests/string_view-selftests.c: Define
3408         _initialize_string_view_selftests unconditionally.
3409
3410 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3411
3412         PR gdb/24350
3413         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3414
3415 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3416
3417         PR gdb/24351
3418         * windows-nat.c (display_selector): Fix format specifiers.
3419
3420 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3421
3422         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3423         tui_refill_source_window instead of tui_refresh_win, to update the
3424         current execution line.  This fixes redisplay of the current line
3425         when stepping through the code with "next" or "step".
3426
3427 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3428
3429         * source-cache.c (source_cache::get_source_lines): Call
3430         find_source_lines to initialize s->nlines.  This fixes vertical
3431         scrolling of TUI source window when the DOWN arrow is pressed.
3432
3433 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3434
3435         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3436         linux-thread-db.c (_initialize_thread_db): Likewise.
3437
3438 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3439
3440         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3441         wclrtoeol in tui_show_source_line".  This reverts changes made in
3442         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3443
3444 2019-03-15  Tom Tromey  <tom@tromey.com>
3445
3446         * symtab.h (struct minimal_symbol): Derive from
3447         general_symbol_info.
3448         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3449         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3450         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3451         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3452         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3453         (MSYMBOL_SEARCH_NAME): Update.
3454         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3455         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3456         * minsyms.c (minimal_symbol_reader::record_full): Update.
3457
3458 2019-03-15  Tom Tromey  <tom@tromey.com>
3459
3460         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3461
3462 2019-03-15  Tom Tromey  <tom@tromey.com>
3463
3464         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3465         unique_xmalloc_ptr.
3466         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3467         Update.
3468         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3469         (build_minimal_symbol_hash_tables)
3470         (minimal_symbol_reader::install): Update.
3471
3472 2019-03-15  Tom Tromey  <tom@tromey.com>
3473
3474         * symtab.c (create_demangled_names_hash): Update.
3475         (symbol_set_names): Update.
3476         * objfiles.h (struct objfile_per_bfd_storage)
3477         <demangled_names_hash>: Now an htab_up.
3478         * objfiles.c (objfile_per_bfd_storage): Simplify.
3479
3480 2019-03-15  Tom Tromey  <tom@tromey.com>
3481
3482         * objfiles.h (struct objfile_per_bfd_storage): Declare
3483         destructor.
3484         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3485         New.
3486         (get_objfile_bfd_data): Use new.  Don't initialize
3487         language_of_main.
3488         (free_objfile_per_bfd_storage): Remove.
3489         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3490
3491 2019-03-15  Tom Tromey  <tom@tromey.com>
3492
3493         * symfile.c (reread_symbols): Update.
3494         * objfiles.c (objfile::objfile): Update.
3495         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3496         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3497         comment.
3498         (minimal_symbol_reader::install): Update.
3499         (terminate_minimal_symbol_table): Remove.
3500         * jit.c (jit_object_close_impl): Update.
3501
3502 2019-03-15  Tom Tromey  <tom@tromey.com>
3503
3504         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3505         initializations.
3506
3507 2019-03-15  Tom Tromey  <tom@tromey.com>
3508
3509         * objfiles.h (struct objfile_per_bfd_storage)
3510         <demangled_hash_languages>: Now a bitset.
3511         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3512         (lookup_minimal_symbol): Update.
3513
3514 2019-03-15  Tom Tromey  <tom@tromey.com>
3515
3516         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3517         Don't return the symbol.
3518         * coffread.c (record_minimal_symbol): Use record_full.
3519
3520 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3521
3522         The MS-Windows port of ncurses fails to switch to a color pair if
3523         one or both of the colors are the implicit default colors.  This
3524         change records the default colors when TUI is initialized, and
3525         then specifies them explicitly when a color pair uses the default
3526         colors.  This allows color styling in TUI mode on MS-Windows.
3527
3528         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3529         ncurses_norm_attr.
3530         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3531         colors in ncurses_norm_attr.
3532         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3533         "none", replace it with the default color recorded in
3534         ncurses_norm_attr.
3535
3536 2019-03-14  Tom Tromey  <tromey@adacore.com>
3537
3538         * source-cache.h (class source_cache) <get_source_lines>: Return
3539         std::string.
3540         * source-cache.c (source_cache::extract_lines): Handle case where
3541         first_pos==npos.  Return std::string.
3542         (source_cache::get_source_lines): Update.
3543
3544 2019-03-14  Tom Tromey  <tromey@adacore.com>
3545
3546         * NEWS: Add item for "style sources" commands.
3547         * source-cache.c (source_cache::get_source_lines): Check
3548         source_styling.
3549         * cli/cli-style.c (source_styling): New global.
3550         (_initialize_cli_style): Add "style sources" commands.
3551         (show_style_sources): New function.
3552         * cli/cli-style.h (source_styling): Declare.
3553
3554 2019-03-14  Pedro Alves  <palves@redhat.com>
3555             Tom Tromey  <tromey@adacore.com>
3556
3557         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3558         * tui/tui-winsource.c (tui_refill_source_window): New function,
3559         from...
3560         (tui_horizontal_source_scroll): ... here.  Move some logic.
3561         * cli/cli-style.c (set_style_enabled): Notify new observable.
3562         * tui/tui-hooks.c (tui_redisplay_source): New function.
3563         (tui_attach_detach_observers): Attach or detach
3564         tui_redisplay_source.
3565         * observable.h (source_styling_changed): New observable.
3566         * observable.c: Define source_styling_changed observable.
3567
3568 2019-03-13  Tom Tromey  <tromey@adacore.com>
3569
3570         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3571         (i386_gnu_nat_target::store_registers): Update.
3572         * target-debug.h (target_debug_print_std_string): New macro.
3573         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3574         * windows-tdep.c (display_one_tib): Update.
3575         * tui/tui-stack.c (tui_make_status_line): Update.
3576         * top.c (print_inferior_quit_action): Update.
3577         * thread.c (thr_try_catch_cmd): Update.
3578         (add_thread_with_info): Update.
3579         (thread_target_id_str): Update.
3580         (thr_try_catch_cmd): Update.
3581         (thread_command): Update.
3582         (thread_find_command): Update.
3583         * record-btrace.c (record_btrace_target::info_record)
3584         (record_btrace_resume_thread, record_btrace_target::resume)
3585         (record_btrace_cancel_resume, record_btrace_step_thread)
3586         (record_btrace_target::wait, record_btrace_target::wait)
3587         (record_btrace_target::wait, record_btrace_target::stop): Update.
3588         * progspace.c (print_program_space): Update.
3589         * process-stratum-target.c
3590         (process_stratum_target::thread_address_space): Update.
3591         * linux-fork.c (linux_fork_mourn_inferior)
3592         (detach_checkpoint_command, info_checkpoints_command)
3593         (linux_fork_context): Update.
3594         (linux_fork_detach): Update.
3595         (class scoped_switch_fork_info): Update.
3596         (delete_checkpoint_command): Update.
3597         * infrun.c (follow_fork_inferior): Update.
3598         (follow_fork_inferior): Update.
3599         (proceed_after_vfork_done): Update.
3600         (handle_vfork_child_exec_or_exit): Update.
3601         (follow_exec): Update.
3602         (displaced_step_prepare_throw): Update.
3603         (displaced_step_restore): Update.
3604         (start_step_over): Update.
3605         (resume_1): Update.
3606         (clear_proceed_status_thread): Update.
3607         (proceed): Update.
3608         (print_target_wait_results): Update.
3609         (do_target_wait): Update.
3610         (context_switch): Update.
3611         (stop_all_threads): Update.
3612         (restart_threads): Update.
3613         (finish_step_over): Update.
3614         (handle_signal_stop): Update.
3615         (switch_back_to_stepped_thread): Update.
3616         (keep_going_pass_signal): Update.
3617         (print_exited_reason): Update.
3618         (normal_stop): Update.
3619         * inferior.c (inferior_pid_to_str): Change return type.
3620         (print_selected_inferior): Update.
3621         (add_inferior): Update.
3622         (detach_inferior): Update.
3623         * dummy-frame.c (fprint_dummy_frames): Update.
3624         * dcache.c (dcache_info_1): Update.
3625         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3626         (btrace_fetch, btrace_clear): Update.
3627         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3628         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3629         type.
3630         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3631         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3632         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3633         * gdbarch.c, gdbarch.h: Rebuild.
3634         * gdbarch.sh (core_pid_to_str): Change return type.
3635         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3636         return type.
3637         (windows_nat_target::pid_to_str): Change return type.
3638         (windows_delete_thread): Update.
3639         (windows_nat_target::attach): Update.
3640         (windows_nat_target::files_info): Update.
3641         * target-delegates.c: Rebuild.
3642         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3643         return type.
3644         (sol_thread_target::pid_to_str): Change return type.
3645         * remote.c (class remote_target) <pid_to_str>: Change return
3646         type.
3647         (remote_target::pid_to_str): Change return type.
3648         (extended_remote_target::attach, remote_target::remote_stop_ns)
3649         (remote_target::remote_notif_remove_queued_reply)
3650         (remote_target::push_stop_reply, remote_target::disable_btrace):
3651         Update.
3652         (extended_remote_target::attach): Update.
3653         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3654         type.
3655         (gdbsim_target::pid_to_str): Change return type.
3656         * ravenscar-thread.c (struct ravenscar_thread_target)
3657         <pid_to_str>: Change return type.
3658         (ravenscar_thread_target::pid_to_str): Change return type.
3659         * procfs.c (class procfs_target) <pid_to_str>: Change return
3660         type.
3661         (procfs_target::pid_to_str): Change return type.
3662         (procfs_target::attach): Update.
3663         (procfs_target::detach): Update.
3664         (procfs_target::fetch_registers): Update.
3665         (procfs_target::store_registers): Update.
3666         (procfs_target::wait): Update.
3667         (procfs_target::files_info): Update.
3668         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3669         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3670         return type.
3671         (nto_procfs_target::pid_to_str): Change return type.
3672         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3673         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3674         return type.
3675         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3676         (exit_lwp): Update.
3677         (attach_proc_task_lwp_callback, get_detach_signal)
3678         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3679         (linux_nat_target::resume, wait_lwp, stop_callback)
3680         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3681         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3682         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3683         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3684         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3685         type.
3686         (inf_ptrace_target::attach): Update.
3687         (inf_ptrace_target::files_info): Update.
3688         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3689         type.
3690         (go32_nat_target::pid_to_str): Change return type.
3691         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3692         (gnu_nat_target::wait): Update.
3693         (gnu_nat_target::wait): Update.
3694         (gnu_nat_target::resume): Update.
3695         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3696         (fbsd_nat_target::wait): Update.
3697         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3698         type.
3699         (darwin_nat_target::attach): Update.
3700         * corelow.c (class core_target) <pid_to_str>: Change return type.
3701         (core_target::pid_to_str): Change return type.
3702         * target.c (normal_pid_to_str): Change return type.
3703         (default_pid_to_str): Likewise.
3704         (target_pid_to_str): Change return type.
3705         (target_translate_tls_address): Update.
3706         (target_announce_detach): Update.
3707         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3708         return type.
3709         (bsd_uthread_target::pid_to_str): Change return type.
3710         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3711         type.
3712         (bsd_kvm_target::pid_to_str): Change return type.
3713         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3714         return type.
3715         (aix_thread_target::pid_to_str): Change return type.
3716         * target.h (struct target_ops) <pid_to_str>: Change return type.
3717         (target_pid_to_str, normal_pid_to_str): Likewise.
3718         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3719         type.
3720         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3721         type.
3722         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3723         return type.
3724         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3725         type.
3726         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3727         type.
3728         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3729         return type.
3730
3731 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3732
3733         * NEWS: Mention that the new default MI version is 3.  Mention
3734         changes to the output of commands and events that deal with
3735         multi-location breakpoints.
3736         * breakpoint.c: Include "mi/mi-out.h".
3737         (print_one_breakpoint): Change output syntax if using MI version
3738         >= 3.
3739         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3740         New.
3741         (mi_multi_location_breakpoint_output_fixed): New.
3742         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3743         (mi_cmd_fix_multi_location_breakpoint_output): New.
3744         (mi_multi_location_breakpoint_output_fixed): New.
3745         * mi/mi-cmds.c (mi_cmds): Register command
3746         -fix-multi-location-breakpoint-output.
3747         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3748         interpreter "mi".
3749
3750 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3751
3752         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3753         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3754         instantiate mi_ui_out based on interpreter name.
3755         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3756         * mi/mi-main.c (mi_load_progress): Likewise.
3757
3758 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3759
3760         * NEWS: Combine separate "New targets" sections for 8.3.
3761
3762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3763
3764         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3765         (ppcfbsd_init_abi): Install gdbarch
3766         "fetch_tls_load_module_address" and "get_thread_local_address"
3767         methods.
3768
3769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3770
3771         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3772         (riscv_fbsd_init_abi): Install gdbarch
3773         "fetch_tls_load_module_address" and "get_thread_local_address"
3774         methods.
3775
3776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3777
3778         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3779         (i386fbsd_init_abi): Install gdbarch
3780         "fetch_tls_load_module_address" and "get_thread_local_address"
3781         methods.
3782
3783 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3784
3785         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3786         (amd64fbsd_init_abi): Install gdbarch
3787         "fetch_tls_load_module_address" and "get_thread_local_address"
3788         methods.
3789
3790 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3791
3792         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3793         (struct fbsd_pspace_data): New type.
3794         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3795         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3796         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3797         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3798         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3799
3800 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3801
3802         * gdbtypes.c (lookup_struct_elt): New function.
3803         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3804         * gdbtypes.h (struct struct_elt): New type.
3805         (lookup_struct_elt): New prototype.
3806
3807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3808
3809         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3810         remove disabled code block.
3811
3812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3813
3814         * gdbarch.sh (get_thread_local_address): New method.
3815         * gdbarch.h, gdbarch.c: Regenerate.
3816         * target.c (target_translate_tls_address): Use
3817         gdbarch_get_thread_local_address if present instead of
3818         target::get_thread_local_address.
3819
3820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3821
3822         * target.h (target::get_thread_local_address): Update comment.
3823
3824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3825
3826         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3827         objfile->separate_debug_objfile_backlink if not NULL.
3828
3829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3830
3831         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3832         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3833         (amd64bsd_store_inferior_registers): Likewise.
3834         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3835         Enable segment base registers.
3836         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3837         PT_GETFSBASE and PT_GETGSBASE.
3838         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3839         PT_SETGSBASE.
3840         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3841         segment base registers.
3842         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3843
3844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3845
3846         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3847         Update calls to i386_target_description to add 'segments'
3848         parameter.
3849         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3850         add segment base registers.
3851         * arch/i386.c (i386_create_target_description): Add 'segments'
3852         parameter to enable segment base registers.
3853         * arch/i386.h (i386_create_target_description): Likewise.
3854         * features/i386/32bit-segments.xml: New file.
3855         * features/i386/32bit-segments.c: Generate.
3856         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3857         call to i386_target_description to add 'segments' parameter.
3858         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3859         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3860         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3861         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3862         if feature is present.
3863         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3864         Add 'segments' parameter to call to i386_target_description.
3865         (i386_target_description): Add 'segments' parameter to enable
3866         segment base registers.
3867         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3868         to call to i386_target_description.
3869         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3870         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3871         Define I386_NUM_REGS.
3872         (i386_target_description): Add 'segments' parameter to enable
3873         segment base registers.
3874
3875 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3876
3877         PR/24325
3878         * source-cache.c: #undef open and close, to avoid unresolved
3879         externals during linking.
3880
3881 2019-03-12  Tom Tromey  <tromey@adacore.com>
3882
3883         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3884         const.  Add initializers.
3885         (_initialize_remote): Don't initialize ptid globals.
3886
3887 2019-03-12  Pedro Alves  <palves@redhat.com>
3888
3889         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3890
3891 2019-03-12  Pedro Alves  <palves@redhat.com>
3892
3893         * cp-name-parser.y (main): Remove unused 'len' variable.
3894
3895 2019-03-12  Tom Tromey  <tromey@adacore.com>
3896
3897         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3898         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3899
3900 2019-03-12  Tom Tromey  <tromey@adacore.com>
3901
3902         * linux-nat.c (iterate_over_lwps): Update.
3903         (stop_callback): Remove parameter.
3904         (stop_wait_callback, detach_callback, resume_set_callback)
3905         (select_singlestep_lwp_callback, set_ignore_sigint)
3906         (status_callback, resumed_callback, resume_clear_callback)
3907         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3908         data parameter.
3909         (linux_nat_target::detach, linux_nat_target::resume)
3910         (linux_stop_and_wait_all_lwps, select_event_lwp)
3911         (linux_nat_filter_event, linux_nat_wait_1)
3912         (linux_nat_target::kill, linux_nat_target::stop)
3913         (linux_nat_target::stop): Update.
3914         (linux_nat_resume_callback): Change type.
3915         (resume_stopped_resumed_lwps, count_events_callback)
3916         (select_event_lwp_callback): Likewise.
3917         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3918         * arm-linux-nat.c (struct update_registers_data): Remove.
3919         (update_registers_callback): Change type.
3920         (arm_linux_insert_hw_breakpoint1): Update.
3921         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3922         parameter.
3923         (x86_linux_dr_set_addr): Update.
3924         (x86_linux_dr_set_control): Update.
3925         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3926         (iterate_over_lwps): Use gdb::function_view.
3927         * nat/aarch64-linux-hw-point.c (struct
3928         aarch64_dr_update_callback_param): Remove.
3929         (debug_reg_change_callback): Change type.
3930         (aarch64_notify_debug_reg_change): Update.
3931         * s390-linux-nat.c (s390_refresh_per_info): Update.
3932
3933 2019-03-11  Tom Tromey  <tromey@adacore.com>
3934
3935         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3936         redundant assignment to "this_cu".
3937
3938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3939
3940         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3941
3942 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3943
3944         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3945         from...
3946         (rank_one_type): ... this.
3947
3948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3949
3950         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3951         from...
3952         (rank_one_type): ... this.
3953
3954 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3955
3956         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3957         from...
3958         (rank_one_type): ... this.
3959
3960 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3961
3962         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3963         from...
3964         (rank_one_type): ... this.
3965
3966 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3967
3968         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3969         from...
3970         (rank_one_type): ... this.
3971
3972 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3973
3974         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3975         from...
3976         (rank_one_type): ... this.
3977
3978 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3979
3980         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3981         from...
3982         (rank_one_type): ... this.
3983
3984 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3985
3986         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3987         from...
3988         (rank_one_type): ... this.
3989
3990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3991
3992         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3993         from...
3994         (rank_one_type): ... this.
3995
3996 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3997
3998         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3999         from...
4000         (rank_one_type): ... this.
4001
4002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4003
4004         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4005         from...
4006         (rank_one_type): ... this.
4007
4008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4009
4010         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4011         from...
4012         (rank_one_type): ... this.
4013
4014 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4015
4016         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4017         inferior-events' shows the example events.
4018
4019 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4020
4021         Support styling on native MS-Windows console
4022
4023         PR/24315
4024         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4025         on MS-Windows if $TERM is not defined.
4026
4027         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4028
4029         * posix-hdep.c (gdb_console_fputs):
4030         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4031         functions.
4032         * ui-file.h (gdb_console_fputs): Add prototype.
4033
4034         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4035         back to fputs only if the former returns zero.
4036
4037 2019-03-07  Tom Tromey  <tom@tromey.com>
4038
4039         * symmisc.c (print_symbol_bcache_statistics): Update.
4040         (print_objfile_statistics): Update.
4041         * symfile.c (allocate_symtab): Update.
4042         * stabsread.c: Don't include bcache.h.
4043         * psymtab.h (struct psymbol_bcache): Don't declare.
4044         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4045         (psymbol_bcache_init, psymbol_bcache_free)
4046         (psymbol_bcache_get_bcache): Don't declare.
4047         * psymtab.c (struct psymbol_bcache): Remove.
4048         (psymtab_storage::psymtab_storage): Update.
4049         (psymtab_storage::~psymtab_storage): Update.
4050         (psymbol_bcache_init, psymbol_bcache_free)
4051         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4052         (add_psymbol_to_bcache): Update.
4053         (allocate_psymtab): Update.
4054         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4055         macro_cache>: No longer pointers.
4056         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4057         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4058         * macrotab.c (macro_bcache): Update.
4059         * macroexp.c: Don't include bcache.h.
4060         * gdbtypes.c (check_types_worklist): Update.
4061         (types_deeply_equal): Remove TRY/CATCH.  Update.
4062         * elfread.c (elf_symtab_read): Update.
4063         * dwarf2read.c: Don't include bcache.h.
4064         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4065         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4066         (print_bcache_statistics, bcache_memory_used): Don't declare.
4067         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4068         methods.  Rename all data members.
4069         * bcache.c (struct bcache): Move to bcache.h.
4070         (bcache::expand_hash_table): Rename from expand_hash_table.
4071         (bcache): Remove.
4072         (bcache::insert): Rename from bcache_full.
4073         (bcache::compare): Rename from bcache_compare.
4074         (bcache_xmalloc): Remove.
4075         (bcache::~bcache): Rename from bcache_xfree.
4076         (bcache::print_statistics): Rename from print_bcache_statistics.
4077         (bcache::memory_used): Rename from bcache_memory_used.
4078
4079 2019-03-07  Pedro Alves  <palves@redhat.com>
4080
4081         * infrun.c (normal_stop): Also check for
4082         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4083
4084 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         * f-lang.c (value_from_host_double): Moved to...
4087         * value.c (value_from_host_double): ...here.
4088         * value.h (value_from_host_double): Declare.
4089         * guile/scm-math.c (vlscm_convert_typed_number): Use
4090         value_from_host_double.
4091         (vlscm_convert_number): Likewise.
4092         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4093         * python/py-value.c (convert_value_from_python): Likewise.
4094
4095 2019-03-06  Tom Tromey  <tom@tromey.com>
4096
4097         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4098
4099 2019-03-06  Tom Tromey  <tom@tromey.com>
4100
4101         * utils.h (free_current_contents): Don't declare.
4102         * utils.c (free_current_contents): Remove.
4103
4104 2019-03-06  Tom Tromey  <tom@tromey.com>
4105
4106         * top.c (quit_force): Update.
4107         * main.c (captured_command_loop): Update.
4108         * common/new-op.c (operator new): Update.
4109         * common/common-exceptions.c (struct catcher)
4110         <save_cleanup_chain>: Remove member.
4111         (exceptions_state_mc_init): Update.
4112         (exception_try_scope_entry): Return nullptr.
4113         (exception_try_scope_exit, exception_rethrow)
4114         (throw_exception_sjlj, throw_exception_cxx): Update.
4115         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4116         (all_cleanups, do_cleanups, discard_cleanups)
4117         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4118         (restore_cleanups, restore_final_cleanups): Don't declare.
4119         (do_final_cleanups): Remove parameter.
4120         * common/cleanups.c (cleanup_chain, make_cleanup)
4121         (make_cleanup_dtor, all_cleanups, do_cleanups)
4122         (discard_my_cleanups, discard_cleanups)
4123         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4124         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4125         (null_cleanup): Remove.
4126         (do_final_cleanups): Remove parameter.
4127
4128 2019-03-06  Tom Tromey  <tom@tromey.com>
4129
4130         * remote.c (remote_target::remote_parse_stop_reply): Use
4131         unique_xmalloc_ptr.
4132
4133 2019-03-06  Tom Tromey  <tom@tromey.com>
4134
4135         * stabsread.c (struct stabs_field_info): Rename from field_info.
4136         <list, fnlist>: Add initializers.
4137         <obstack>: New member.
4138         (read_member_functions, read_struct_fields, read_baseclasses):
4139         Allocate on obstack.  Don't use cleanups.
4140         (read_one_struct_field, read_member_functions, read_struct_fields)
4141         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4142         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4143         (read_struct_type): Update.
4144
4145 2019-03-06  Tom Tromey  <tom@tromey.com>
4146
4147         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4148         * common/filestuff.h (make_cleanup_close): Don't declare.
4149         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4150         Remove.
4151
4152 2019-03-06  Tom Tromey  <tom@tromey.com>
4153
4154         * solib-aix.c: Use make_scope_exit.
4155
4156 2019-03-06  Tom Tromey  <tom@tromey.com>
4157
4158         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4159         Use make_scope_exit.
4160
4161 2019-03-06  Tom Tromey  <tom@tromey.com>
4162
4163         * solib-svr4.c (disable_probes_interface): Remove parameter.
4164         (svr4_handle_solib_event): Use make_scope_exit.
4165
4166 2019-03-06  Tom Tromey  <tom@tromey.com>
4167
4168         * remote.c (struct stop_reply_deleter): Remove.
4169         (stop_reply_up): Update.
4170         (struct stop_reply): Derive from notif_event.  Don't typedef.
4171         <regcache>: Now a std::vector.
4172         (stop_reply_xfree): Remove.
4173         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4174         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4175         (remote_target::discard_pending_stop_replies): Use delete.
4176         (remote_target::remote_parse_stop_reply): Update.
4177         (remote_target::process_stop_reply): Update.
4178         * remote-notif.h (struct notif_event): Add virtual destructor.
4179         Remove "dtr" member.
4180         (struct notif_client) <alloc_event>: Return a unique_ptr.
4181         (notif_event_xfree): Don't declare.
4182         (notif_event_up): New typedef.
4183         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4184         (notif_event_xfree, do_notif_event_xfree): Remove.
4185         (remote_notif_state_xfree): Update.
4186
4187 2019-03-06  Tom Tromey  <tom@tromey.com>
4188
4189         * infrun.c (displaced_step_clear_cleanup): Now a
4190         forward_scope_exit type.
4191         (displaced_step_prepare_throw): Update.
4192         (displaced_step_fixup): Update.
4193
4194 2019-03-06  Tom Tromey  <tom@tromey.com>
4195
4196         * inferior.h (class inferior): Update comment.
4197         * gdbthread.h (class thread_info): Update comment.
4198
4199 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4200             Tom Tromey  <tom@tromey.com>
4201
4202         * stabsread.h (struct stab_section_list): Remove.
4203         (coffstab_build_psymtabs): Update.
4204         * dbxread.c (symbuf_sections): Now a std::vector.
4205         (sect_idx): New global.
4206         (fill_symbuf): Update.
4207         (coffstab_build_psymtabs): Change type of stabsects parameter.
4208         Update.
4209         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4210         std::vector.
4211         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4212         (coff_locate_sections): Update.
4213         (coff_symfile_read): Remove cleanups.  Update.
4214         (init_stringtab): Add storage parameter.
4215         (free_stringtab, free_stringtab_cleanup): Remove.
4216         (init_lineno): Add storage parameter.
4217         (free_linetab, free_linetab_cleanup): Remove.
4218
4219 2019-03-06  Pedro Alves  <palves@redhat.com>
4220
4221         * linux-fork.c (fork_info::clobber_regs): Delete.
4222         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4223         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4224         comment.  Adjust.
4225         (scoped_switch_fork_info::scoped_switch_fork_info)
4226         (checkpoint_command, linux_fork_context): Adjust
4227         fork_save_infrun_state calls.
4228
4229 2019-03-06  Pedro Alves  <palves@redhat.com>
4230
4231         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4232         (inf_has_multiple_threads): Return 'bool' and rewrite using
4233         inferior_info::threads().
4234
4235 2019-03-06  Pedro Alves  <palves@redhat.com>
4236
4237         * linux-fork.c: Include <list>.
4238         (fork_list): Now a std::list instance.
4239         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4240         (forks_exist_p, find_last_fork): Adjust.
4241         (new_fork): Delete.
4242         (one_fork_p): New.
4243         (add_fork): Adjust.
4244         (free_fork): Delete, folded into fork_info::~fork_info().
4245         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4246         Adjust.
4247         (init_fork_list): Delete.
4248         (linux_fork_killall, linux_fork_mourn_inferior)
4249         (linux_fork_detach, info_checkpoints_command): Adjust.
4250         (_initialize_linux_fork): No longer call init_fork_list.
4251
4252 2019-03-06  Pedro Alves  <palves@redhat.com>
4253
4254         * linux-fork.c (new_fork): New, split out of ...
4255         (add_fork): ... this.  Return void.  Move "first fork" special
4256         case from here, to ...
4257         (checkpoint_command): ... here.
4258         * linux-linux.h (add_fork): Return void.
4259
4260 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4261
4262         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4263
4264 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4265             Chris January  <chris.january@arm.com>
4266             David Lecomber  <david.lecomber@arm.com>
4267
4268         * f-exp.y: New token, UNOP_INTRINSIC.
4269         (exp): New pattern using UNOP_INTRINSIC token.
4270         (f77_keywords): Add 'abs' keyword.
4271         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4272         (value_from_host_double): New function.
4273         (evaluate_subexp_f): Support UNOP_ABS.
4274
4275 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4278         types.
4279
4280 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4281
4282         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4283         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4284         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4285
4286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4287
4288         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4289
4290 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4291             Chris January  <chris.january@arm.com>
4292
4293         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4294         * f-exp.y: Define 'KIND' token.
4295         (exp): New pattern for KIND expressions.
4296         (ptype): Handle types with a kind extension.
4297         (direct_abs_decl): Extend to spot kind extensions.
4298         (f77_keywords): Add 'kind' to the list.
4299         (push_kind_type): New function.
4300         (convert_to_kind_type): New function.
4301         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4302         * parse.c (operator_length_standard): Likewise.
4303         * parser-defs.h (enum type_pieces): Add tp_kind.
4304         * std-operator.def: Add UNOP_KIND.
4305
4306 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * f-exp.y (f_parse): Set yydebug.
4309
4310 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4311
4312         * f-lang.c (evaluate_subexp_f): New function.
4313         (exp_descriptor_f): New global.
4314         (f_language_defn): Use exp_descriptor_f instead of
4315         exp_descriptor_standard.
4316
4317 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4318
4319         * f-exp.y (struct token): Add comments.
4320         (dot_ops): Remove uppercase versions and the end marker.
4321         (f77_keywords): Likewise.
4322         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4323         entries in the dot_ops array are case insensitive, and use
4324         strncasecmp to compare strings.  Also some whitespace cleanup in
4325         this area.  Similar for the f77_keywords array, except entries in
4326         this list might be case sensitive.
4327
4328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4329
4330         * f-exp.y (struct f77_boolean_val): Add comments.
4331         (boolean_values): Remove uppercase versions, and end marker.
4332         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4333         and use strncasecmp to achieve case insensitivity.  Additionally,
4334         perform whitespace cleanup around this code.
4335
4336 2019-03-06  Tom Tromey  <tromey@adacore.com>
4337
4338         * remote-sim.c (gdbsim_target_open): Use result of
4339         gdb_argv::release.
4340
4341 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4342         Dirk Schubert  <dirk.schubert@arm.com>
4343         Chris January  <chris.january@arm.com>
4344
4345         * eval.c (evaluate_subexp_standard): Call Fortran argument
4346         wrapping logic.
4347         * f-lang.c (struct value): A value which can be passed into a
4348         Fortran function call.
4349         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4350         where appropriate.
4351         (struct type): Value ready for a Fortran function call.
4352         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4353         is needed.
4354         * f-lang.h (fortran_argument_convert): Declaration.
4355         (fortran_preserve_arg_pointer): Declaration.
4356         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4357
4358 2019-03-05  Tom Tromey  <tromey@adacore.com>
4359
4360         * python/py-prettyprint.c (print_string_repr): Remove #if.
4361         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4362
4363 2019-03-05  Tom Tromey  <tromey@adacore.com>
4364
4365         * target.c (the_dummy_target): Move later.  Change type to
4366         "dummy_target".
4367         (initialize_targets): Don't initialize the_dummy_target.
4368
4369 2019-03-05  Tom Tromey  <tromey@adacore.com>
4370
4371         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4372         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4373
4374 2019-03-05  Tom Tromey  <tromey@adacore.com>
4375
4376         * windows-nat.c (windows_nat_target::attach)
4377         (windows_nat_target::detach): Don't call gdb_flush.
4378         * valprint.c (generic_val_print, val_print, val_print_string):
4379         Don't call gdb_flush.
4380         * utils.c (defaulted_query): Don't call gdb_flush.
4381         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4382         * target.c (target_announce_detach): Don't call gdb_flush.
4383         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4384         * remote.c (extended_remote_target::attach): Don't call
4385         gdb_flush.
4386         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4387         * printcmd.c (do_examine): Don't call gdb_flush.
4388         (info_display_command): Don't call gdb_flush.
4389         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4390         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4391         * memattr.c (info_mem_command): Don't call gdb_flush.
4392         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4393         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4394         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4395         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4396         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4397         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4398         (gnu_nat_target::detach): Don't call gdb_flush.
4399         * f-valprint.c (f_val_print): Don't call gdb_flush.
4400         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4401         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4402         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4403         gdb_flush.
4404         * c-valprint.c (c_val_print): Don't call gdb_flush.
4405         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4406
4407 2019-03-05  Tom Tromey  <tromey@adacore.com>
4408
4409         * varobj.c (update_dynamic_varobj_children): Update.
4410         (install_default_visualizer): Use reset, not release.
4411         * value.c (set_internalvar): Update.
4412         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4413         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4414         ATTRIBUTE_UNUSED_RESULT.
4415
4416 2019-03-05  Tom Tromey  <tromey@adacore.com>
4417
4418         * remote.c (class scoped_remote_fd) <release>: Add
4419         ATTRIBUTE_UNUSED_RESULT.
4420
4421 2019-03-05  Tom Tromey  <tromey@adacore.com>
4422
4423         * macroexp.c (struct macro_buffer) <release>: Add
4424         ATTRIBUTE_UNUSED_RESULT.
4425
4426 2019-03-05  Tom Tromey  <tromey@adacore.com>
4427
4428         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4429         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4430         ATTRIBUTE_UNUSED_RESULT.
4431
4432 2019-03-05  Tom Tromey  <tromey@adacore.com>
4433
4434         * common/scoped_fd.h (class scoped_fd) <release>: Add
4435         ATTRIBUTE_UNUSED_RESULT.
4436
4437 2019-03-05  Tom Tromey  <tromey@adacore.com>
4438
4439         * parser-defs.h (struct parser_state) <release>: Add
4440         ATTRIBUTE_UNUSED_RESULT.
4441
4442 2019-03-05  Tom Tromey  <tromey@adacore.com>
4443
4444         * utils.h (class gdb_argv) <release>: Add
4445         ATTRIBUTE_UNUSED_RESULT.
4446         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4447
4448 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4449
4450         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4451         for-loop range, to avoid compiler warnings.
4452
4453         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4454         avoid compiler warnings about unused variables.
4455
4456         * NEWS: Mention end of support for native debugging on MS-Windows
4457         before XP.
4458
4459         PR gdb/24292
4460         * common/netstuff.c:
4461         * gdbserver/gdbreplay.c
4462         * gdbserver/remote-utils.c:
4463         * ser-tcp.c:
4464         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4465         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4466         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4467         'getaddrinfo' and 'freeaddrinfo' were not available before
4468         Windows XP, and mingw.org's MinGW headers by default define
4469         _WIN32_WINNT to 0x500.
4470
4471 2019-03-01  Gary Benson <gbenson@redhat.com>
4472
4473         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4474
4475 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4476             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4477
4478         PR gdb/8527
4479         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4480         set_sigint_trap, clear_sigint_trap.
4481
4482 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4483
4484         * target.c (target_detach): Clear the regcache and the
4485         frame cache.
4486
4487 2019-02-27  Pedro Alves  <palves@redhat.com>
4488
4489         * utils.c (set_screen_size): When we cap the height/width sizes,
4490         tweak the corresponding command variable to show "unlimited":
4491
4492 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4493             Pedro Alves  <palves@redhat.com>
4494
4495         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4496         before calling rl_set_screen_size.
4497
4498 2019-02-27  Tom Tromey  <tromey@adacore.com>
4499
4500         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4501         define.
4502         * python/py-value.c: Remove Python 2.4 workaround.
4503         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4504         workaround.
4505         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4506         Python 2.4 workaround.
4507         * python/python-internal.h: Remove Python 2.4 comment.
4508         (Py_ssize_t): Don't define.
4509         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4510         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4511         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4512         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4513         * python/python.c (do_start_initialization): Remove Python 2.4
4514         workaround.
4515         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4516         (print_children): Remove Python 2.4 workaround.
4517         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4518         workaround.
4519         (CHARBUFFERPROC_NAME): Remove.
4520         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4521         Python 2.4 workaround.
4522
4523 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4524
4525         * NEWS: Note minimum Python version.
4526
4527 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4528
4529         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4530         code from these functions.  Remove corresponding ifdefs.  Use
4531         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4532         Remove gotos and target of gotos.
4533         (infpy_search_memory): Likewise.
4534
4535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4538         (hppa_gdbarch_init): Don't register deleted functions with
4539         gdbarch.
4540
4541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4542
4543         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4544         (h8300_unwind_sp): Delete.
4545         (h8300_dummy_id): Delete.
4546         (h8300_gdbarch_init): Don't register deleted functions with
4547         gdbarch.
4548
4549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4550
4551         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4552         (ft32_unwind_pc): Delete.
4553         (ft32_unwind_sp): Delete.
4554         (ft32_gdbarch_init): Don't register deleted functions with
4555         gdbarch.
4556
4557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4558
4559         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4560         (frv_unwind_pc): Delete.
4561         (frv_unwind_sp): Delete.
4562         (frv_gdbarch_init): Don't register deleted functions with
4563         gdbarch.
4564
4565 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4566
4567         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4568         (riscv_unwind_pc): Delete.
4569         (riscv_unwind_sp): Delete.
4570         (riscv_gdbarch_init): Don't register deleted functions with
4571         gdbarch.
4572
4573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4574
4575         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4576         (csky_unwind_pc): Delete.
4577         (csky_unwind_sp): Delete.
4578         (csky_gdbarch_init): Don't register deleted functions with
4579         gdbarch.
4580
4581 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4584         (cris_unwind_pc): Delete.
4585         (cris_unwind_sp): Delete.
4586         (cris_gdbarch_init): Don't register deleted functions with
4587         gdbarch.
4588
4589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4590
4591         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4592         (bfin_unwind_pc): Delete.
4593         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4594
4595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4596
4597         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4598         (arm_unwind_pc): Delete.
4599         (arm_unwind_sp): Delete.
4600         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4601
4602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4603
4604         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4605         (arc_unwind_pc): Delete.
4606         (arc_unwind_sp): Delete.
4607         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4608
4609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4610
4611         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4612         (alpha_unwind_pc): Delete.
4613         (alpha_gdbarch_init): Don't register deleted functions with
4614         gdbarch.
4615
4616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4617
4618         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4619         (aarch64_unwind_pc): Delete.
4620         (aarch64_unwind_sp): Delete.
4621         (aarch64_gdbarch_init): Don't register deleted functions with
4622         gdbarch.
4623
4624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4625
4626         * gdbtypes.c (type_align): Don't consider static members when
4627         computing structure alignment.
4628
4629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4630
4631         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4632         return 0 for other types.
4633         * arch-utils.c (default_type_align): Always return 0.
4634         * gdbarch.h: Regenerate.
4635         * gdbarch.sh (type_align): Extend comment.
4636         * gdbtypes.c (type_align): Add additional comments, always call
4637         gdbarch_type_align before applying the default rules.
4638         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4639         generic code will then apply a suitable default.
4640         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4641         types, return 0 for other types.
4642
4643 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4644
4645         * NEWS: Create a new section for the next release branch.
4646         Rename the section of the current branch, now that it has
4647         been cut.
4648
4649 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4650
4651         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4652         * version.in: Bump version to 8.3.50.DATE-git.
4653
4654 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4655
4656         * aix-thread.c (ptid_cmp): Remove unused variable.
4657         (get_signaled_thread): Likewise.
4658         (store_regs_user_thread): Likewise.
4659         (store_regs_kernel_thread): Likewise.
4660         (fetch_regs_kernel_thread): Remove shadowed variable.
4661
4662 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4663
4664         * features/riscv/32bit-cpu.xml: Add register numbers.
4665         * features/riscv/32bit-fpu.c: Regenerate.
4666         * features/riscv/32bit-fpu.xml: Add register numbers.
4667         * features/riscv/64bit-cpu.xml: Add register numbers.
4668         * features/riscv/64bit-fpu.c: Regenerate.
4669         * features/riscv/64bit-fpu.xml: Add register numbers.
4670
4671 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4672
4673         * NEWS: Mention two argument form of gdb.Value constructor.
4674         * python/py-value.c (convert_buffer_and_type_to_value): New
4675         function.
4676         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4677         Add support for handling an optional second argument.  Call
4678         convert_buffer_and_type_to_value as appropriate.
4679         * python/python-internal.h (Py_buffer_deleter): New struct.
4680         (Py_buffer_up): New typedef.
4681
4682 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4683
4684         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4685         instead of releasing ownership.
4686
4687 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4688
4689         * dwarf2read.c (open_and_init_dwp_file): Call
4690         elf_numsections instead of bfd_count_sections to initialize
4691         dwp_file->num_sections.
4692
4693 2019-02-25  Tom Tromey  <tromey@adacore.com>
4694
4695         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4696
4697 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4698
4699         * gcore.in: Add '--readnever' option when invoking GDB.
4700
4701 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4702
4703         * MAINTAINERS: Update my email address.
4704
4705 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4706
4707         * build-id.c (build_id_to_debug_bfd_1): New function.
4708         (build_id_to_debug_bfd): Look for separate debug file in
4709         sysroot.
4710
4711 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4712
4713         * gdbarch.sh: Update the copyright year range that is placed into
4714         generated files.
4715
4716 2019-02-22  Keith Seitz  <keiths@redhat.com>
4717
4718         PR symtab/23853
4719         * linespec.c (create_sals_line_offset): Search for the default
4720         symtab's filename instead of its fullname.
4721
4722 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4723
4724         * NEWS: Update style defaults.
4725
4726 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4727
4728         * main.c (captured_main_1): Disable styling in batch mode.
4729
4730 2019-02-20  Tom Tromey  <tom@tromey.com>
4731
4732         * symtab.c (symtab_symbol_info): Fix typos.
4733
4734 2019-02-20  Tom Tromey  <tromey@adacore.com>
4735
4736         * findcmd.c (_initialize_mem_search): Use upper case for
4737         metasyntactic variables.
4738
4739 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4740
4741         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4742         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4743
4744 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4745
4746         * top.h (source_file_name): Change to std::string.
4747         * top.c (source_file_name): Likewise.
4748         (command_line_input): Adjust.
4749         * cli/cli-script.c (script_from_file): Adjust.
4750
4751 2019-02-19  Tom Tromey  <tromey@adacore.com>
4752
4753         * ravenscar-thread.c
4754         (ravenscar_thread_target::update_thread_list): Don't call
4755         ada_build_task_list.
4756         * ada-lang.h (ada_build_task_list): Don't declare.
4757         * ada-tasks.c (struct ada_tasks_inferior_data)
4758         <task_list_valid_p>: Now bool.
4759         (read_known_tasks, ada_task_list_changed)
4760         (ada_tasks_invalidate_inferior_data): Update.
4761         (read_known_tasks_array): Return bool.
4762         (read_known_tasks_list): Likewise.
4763         (read_known_tasks): Return void.
4764         (ada_build_task_list): Now static.
4765
4766 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4767
4768         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4769         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4770
4771 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4772
4773         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4774         variant for ada_tasks_pspace_data_handle and
4775         ada_tasks_inferior_data_handle.
4776         (ada_tasks_pspace_data_cleanup): New function.
4777         (ada_tasks_inferior_data_cleanup): New function.
4778
4779 2019-02-17  Tom Tromey  <tom@tromey.com>
4780
4781         * macrotab.h (macro_source_fullname): Return a std::string.
4782         * macrotab.c (macro_include, check_for_redefinition)
4783         (macro_undef, macro_lookup_definition, foreach_macro)
4784         (foreach_macro_in_scope): Update.
4785         (macro_source_fullname): Return a std::string.
4786         * macrocmd.c (show_pp_source_pos): Update.
4787
4788 2019-02-17  Tom Tromey  <tom@tromey.com>
4789
4790         * macrocmd.c (show_pp_source_pos): Style the file names.
4791
4792 2019-02-17  Tom Tromey  <tom@tromey.com>
4793
4794         PR tui/24197:
4795         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4796
4797 2019-02-17  Tom Tromey  <tom@tromey.com>
4798
4799         * ada-lang.c (user_select_syms): Use filtered printing.
4800         * utils.c (wrap_style): New global.
4801         (desired_style): Remove.
4802         (emit_style_escape): Add stream parameter.
4803         (set_output_style, reset_terminal_style, prompt_for_continue):
4804         Update.
4805         (flush_wrap_buffer): Only flush gdb_stdout.
4806         (wrap_here): Set wrap_style.
4807         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4808         treat escape sequences as a character.  Change when wrap buffer is
4809         flushed.
4810         (fputs_styled): Do not set the output style when the default is
4811         requested.
4812         * ui-style.h (struct ui_file_style) <is_default>: New method.
4813         * source.c (print_source_lines_base): Emit escape sequences in one
4814         piece.
4815
4816 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4817
4818         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4819         integers and enumeration types.
4820
4821 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4822
4823         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4824         instead of lookup_symbol_in_language
4825         (do_exact_match): New function.
4826         (ada_get_symbol_name_matcher): Return do_exact_match when
4827         doing a verbatim match.
4828
4829 2019-02-15  Tom Tromey  <tromey@adacore.com>
4830
4831         * ravenscar-thread.c (ravenscar_thread_target::resume)
4832         (ravenscar_thread_target::wait): Special case wildcard requests.
4833
4834 2019-02-15  Tom Tromey  <tromey@adacore.com>
4835
4836         * ravenscar-thread.c (base_ptid): Remove.
4837         (struct ravenscar_thread_target) <close>: New method.
4838         <m_base_ptid>: New member.
4839         <update_inferior_ptid, active_task, task_is_currently_active,
4840         runtime_initialized>: Declare methods.
4841         <ravenscar_thread_target>: Add constructor.
4842         (ravenscar_thread_target::task_is_currently_active)
4843         (ravenscar_thread_target::update_inferior_ptid)
4844         (ravenscar_runtime_initialized): Rename.  Now methods.
4845         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4846         (ravenscar_thread_target::update_thread_list): Update.
4847         (ravenscar_thread_target::active_task): Now method.
4848         (ravenscar_thread_target::store_registers)
4849         (ravenscar_thread_target::prepare_to_store)
4850         (ravenscar_thread_target::prepare_to_store)
4851         (ravenscar_thread_target::mourn_inferior): Update.
4852         (ravenscar_inferior_created): Use "new" to create target.
4853         (ravenscar_thread_target::get_ada_task_ptid): Update.
4854         (_initialize_ravenscar): Don't initialize base_ptid.
4855         (ravenscar_ops): Remove global.
4856
4857 2019-02-15  Tom Tromey  <tromey@adacore.com>
4858
4859         * target.h (push_target): Declare new overload.
4860         * target.c (push_target): New overload, taking an rvalue reference.
4861         * remote.c (remote_target::open_1): Use push_target overload.
4862         * corelow.c (core_target_open): Use push_target overload.
4863
4864 2019-02-15  Tom Tromey  <tromey@adacore.com>
4865
4866         * ravenscar-thread.c (is_ravenscar_task)
4867         (ravenscar_task_is_currently_active): Return bool.
4868         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4869         (_initialize_ravenscar): Remove "(void)".
4870         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4871         Return bool.
4872
4873 2019-02-15  Tom Tromey  <tromey@adacore.com>
4874
4875         * ravenscar-thread.c (ravenscar_runtime_initializer)
4876         (has_ravenscar_runtime, get_running_thread_id)
4877         (ravenscar_thread_target::resume): Fix indentation.
4878
4879 2019-02-15  Tom Tromey  <tromey@adacore.com>
4880
4881         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4882         from ravenscar_arch_ops.
4883         (sparc_ravenscar_ops::fetch_registers)
4884         (sparc_ravenscar_ops::store_registers): Now methods.
4885         (sparc_ravenscar_prepare_to_store): Remove.
4886         (sparc_ravenscar_ops): Redefine.
4887         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4888         methods and destructor.  Remove members.
4889         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4890         (ravenscar_thread_target::store_registers)
4891         (ravenscar_thread_target::prepare_to_store): Update.
4892         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4893         Remove.
4894         (struct ppc_ravenscar_powerpc_ops): Derive from
4895         ravenscar_arch_ops.
4896         (ppc_ravenscar_powerpc_ops::fetch_registers)
4897         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4898         (ppc_ravenscar_powerpc_ops): Redefine.
4899         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4900         (ppc_ravenscar_e500_ops::fetch_registers)
4901         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4902         (ppc_ravenscar_e500_ops): Redefine.
4903         * aarch64-ravenscar-thread.c
4904         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4905         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4906         (aarch64_ravenscar_fetch_registers)
4907         (aarch64_ravenscar_store_registers): Now methods.
4908         (aarch64_ravenscar_ops): Redefine.
4909
4910 2019-02-15  Tom Tromey  <tromey@adacore.com>
4911
4912         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4913         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4914         (ravenscar_thread_target::stopped_by_watchpoint)
4915         (ravenscar_thread_target::stopped_data_address)
4916         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4917
4918 2019-02-15  Tom Tromey  <tromey@adacore.com>
4919
4920         * ravenscar-thread.c: Fix some typos.
4921
4922 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4923             Tom Tromey  <tromey@adacore.com>
4924
4925         * ada-lang.c (ada_exception_sal): Change addr_string to a
4926         std::string.
4927         (create_ada_exception_catchpoint): Update.
4928
4929 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4930             Tom Tromey  <tromey@adacore.com>
4931
4932         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4933         (bp_location_ops): Remove.
4934         (base_breakpoint_allocate_location): Update.
4935         (free_bp_location): Update.
4936         * ada-lang.c (class ada_catchpoint_location)
4937         <ada_catchpoint_location>: Remove ops parameter.
4938         (ada_catchpoint_location_dtor): Remove.
4939         (ada_catchpoint_location_ops): Remove.
4940         (allocate_location_exception): Update.
4941         * breakpoint.h (struct bp_location_ops): Remove.
4942         (class bp_location) <bp_location>: Remove bp_location_ops
4943         parameter.
4944         <~bp_location>: Add destructor.
4945         <ops>: Remove.
4946
4947 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4948             Pedro Alves  <palves@redhat.com>
4949
4950         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4951         'PATH_MAX'.
4952
4953 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4954             Samuel Thibault  <samuel.thibault@gnu.org>
4955             Thomas Schwinge  <thomas@codesourcery.com>
4956
4957         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4958         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4959
4960 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4961
4962         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4963         (check_empty): Use "const char *".
4964
4965         * gnu-nat.c (gnu_nat_target::detach): Instead of
4966         'detach_inferior (pid)' call
4967         'detach_inferior (find_inferior_pid (pid))'.
4968
4969         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4970         'nat/fork-inferior.o'.
4971         * gnu-nat.c: #include "nat/fork-inferior.h".
4972
4973         * gnu-nat.c (gnu_nat_target::detach): Instead of
4974         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4975         * gnu-nat.h: #include "inf-child.h".
4976         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4977         'i386_gnu_nat_target::fetch_registers'.
4978         (gnu_store_registers): Rename/move to
4979         'i386_gnu_nat_target::store_registers'.
4980
4981         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4982         * gnu-nat.h (mach_thread_info): New function.
4983         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4984
4985         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4986
4987 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4988
4989         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4990
4991 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4992
4993         * windows-nat.c (windows_add_thread): Add new parameter
4994         "main_thread_p" with default value set to false.  Update
4995         function documentation as well as all callers.
4996         (windows_delete_thread): Likewise.
4997         (fake_create_process): Update call to windows_add_thread.
4998         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4999         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5000         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5001         call to windows_delete_thread.
5002
5003 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5004
5005         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5006
5007 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5008
5009         * symfile.c (find_separate_debug_file): Use canonical path of
5010         sysroot with child_path instead of gdb_sysroot if it is valid.
5011
5012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5013
5014         * symfile.c (find_separate_debug_file): Use child_path to
5015         determine if an object file is under a sysroot.
5016
5017 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5018
5019         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5020         unittests/child-path-selftests.c.
5021         * common/pathstuff.c (child_path): New function.
5022         * common/pathstuff.h (child_path): New prototype.
5023         * unittests/child-path-selftests.c: New file.
5024
5025 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5026
5027         * symfile.c (find_separate_debug_file): Look for separate debug
5028         files in debug directories under the sysroot.
5029
5030 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5031
5032         * symtab.h (struct minimal_symbol data_p): New const method.
5033         (struct minimal_symbol text_p): Likewise.
5034         * symtab.c (output_source_filename): Use file name style
5035         to print file name.
5036         (print_symbol_info): Likewise.
5037         (print_msymbol_info): Use address style to print addresses.
5038         Use function name style to print executable text symbols.
5039         (expand_symtab_containing_pc): Use data_p.
5040         (find_pc_sect_compunit_symtab): Likewise.
5041
5042 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5043
5044         * breakpoint.c (describe_other_breakpoints): Use address style
5045         to print addresses.
5046         (say_where): Likewise.
5047
5048 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5049
5050         * ada-typeprint.c (print_func_type): Print function name
5051         style to print function name.
5052         * c-typeprint.c (c_print_type_1): Likewise.
5053
5054 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5055
5056         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5057         for execve.
5058
5059 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5060
5061         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5062         type_stack.
5063
5064 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5065
5066         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5067         TYPE_CODE_REF types.
5068
5069 2019-02-08  Jim Wilson  <jimw@sifive.com>
5070
5071         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5072         (riscv_linux_fregset): New.
5073         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5074
5075 2019-02-07  Tom Tromey  <tom@tromey.com>
5076
5077         * thread.c (thread_cancel_execution_command): Update.
5078         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5079         methods.
5080         (struct thread_fsm_ops): Remove.
5081         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5082         (thread_fsm_should_stop, thread_fsm_return_value)
5083         (thread_fsm_set_finished, thread_fsm_finished_p)
5084         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5085         Don't declare.
5086         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5087         * infrun.c (clear_proceed_status_thread)
5088         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5089         (print_stop_event): Update.
5090         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5091         Add constructor.
5092         (step_command_fsm_ops): Remove.
5093         (new_step_command_fsm): Remove.
5094         (step_1): Update.
5095         (step_command_fsm::should_stop): Rename from
5096         step_command_fsm_should_stop.
5097         (step_command_fsm::clean_up): Rename from
5098         step_command_fsm_clean_up.
5099         (step_command_fsm::do_async_reply_reason): Rename from
5100         step_command_fsm_async_reply_reason.
5101         (struct until_next_fsm): Inherit from thread_fsm.  Add
5102         constructor.
5103         (until_next_fsm_ops): Remove.
5104         (new_until_next_fsm): Remove.
5105         (until_next_fsm::should_stop): Rename from
5106         until_next_fsm_should_stop.
5107         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5108         (until_next_fsm::do_async_reply_reason): Rename from
5109         until_next_fsm_async_reply_reason.
5110         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5111         constructor.  Change type of breakpoint.
5112         (finish_command_fsm_ops): Remove.
5113         (new_finish_command_fsm): Remove.
5114         (finish_command_fsm::should_stop): Rename from
5115         finish_command_fsm_should_stop.
5116         (finish_command_fsm::clean_up): Rename from
5117         finish_command_fsm_clean_up.
5118         (finish_command_fsm::return_value): Rename from
5119         finish_command_fsm_return_value.
5120         (finish_command_fsm::do_async_reply_reason): Rename from
5121         finish_command_fsm_async_reply_reason.
5122         (finish_command): Update.
5123         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5124         Add constructor.
5125         (call_thread_fsm_ops): Remove.
5126         (call_thread_fsm::call_thread_fsm): Rename from
5127         new_call_thread_fsm.
5128         (call_thread_fsm::should_stop): Rename from
5129         call_thread_fsm_should_stop.
5130         (call_thread_fsm::should_notify_stop): Rename from
5131         call_thread_fsm_should_notify_stop.
5132         (run_inferior_call, call_function_by_hand_dummy): Update.
5133         * cli/cli-interp.c (should_print_stop_to_console): Update.
5134         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5135         Add constructor.  Change type of location_breakpoint,
5136         caller_breakpoint.
5137         (until_break_fsm_ops): Remove.
5138         (new_until_break_fsm): Remove.
5139         (until_break_fsm::should_stop): Rename from
5140         until_break_fsm_should_stop.
5141         (until_break_fsm::clean_up): Rename from
5142         until_break_fsm_clean_up.
5143         (until_break_fsm::do_async_reply_reason): Rename from
5144         until_break_fsm_async_reply_reason.
5145         (until_break_command): Update.
5146         * thread-fsm.c: Remove.
5147         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5148
5149 2019-02-07  Tom Tromey  <tom@tromey.com>
5150
5151         * yy-remap.h: Add include guard.
5152         * xtensa-tdep.h: Add include guard.
5153         * xcoffread.h: Rename include guard.
5154         * varobj-iter.h: Add include guard.
5155         * tui/tui.h: Rename include guard.
5156         * tui/tui-winsource.h: Rename include guard.
5157         * tui/tui-wingeneral.h: Rename include guard.
5158         * tui/tui-windata.h: Rename include guard.
5159         * tui/tui-win.h: Rename include guard.
5160         * tui/tui-stack.h: Rename include guard.
5161         * tui/tui-source.h: Rename include guard.
5162         * tui/tui-regs.h: Rename include guard.
5163         * tui/tui-out.h: Rename include guard.
5164         * tui/tui-layout.h: Rename include guard.
5165         * tui/tui-io.h: Rename include guard.
5166         * tui/tui-hooks.h: Rename include guard.
5167         * tui/tui-file.h: Rename include guard.
5168         * tui/tui-disasm.h: Rename include guard.
5169         * tui/tui-data.h: Rename include guard.
5170         * tui/tui-command.h: Rename include guard.
5171         * tic6x-tdep.h: Add include guard.
5172         * target/waitstatus.h: Rename include guard.
5173         * target/wait.h: Rename include guard.
5174         * target/target.h: Rename include guard.
5175         * target/resume.h: Rename include guard.
5176         * target-float.h: Rename include guard.
5177         * stabsread.h: Add include guard.
5178         * rs6000-tdep.h: Add include guard.
5179         * riscv-fbsd-tdep.h: Add include guard.
5180         * regformats/regdef.h: Rename include guard.
5181         * record.h: Rename include guard.
5182         * python/python.h: Rename include guard.
5183         * python/python-internal.h: Rename include guard.
5184         * python/py-stopevent.h: Rename include guard.
5185         * python/py-ref.h: Rename include guard.
5186         * python/py-record.h: Rename include guard.
5187         * python/py-record-full.h: Rename include guard.
5188         * python/py-record-btrace.h: Rename include guard.
5189         * python/py-instruction.h: Rename include guard.
5190         * python/py-events.h: Rename include guard.
5191         * python/py-event.h: Rename include guard.
5192         * procfs.h: Add include guard.
5193         * proc-utils.h: Add include guard.
5194         * p-lang.h: Add include guard.
5195         * or1k-tdep.h: Rename include guard.
5196         * observable.h: Rename include guard.
5197         * nto-tdep.h: Rename include guard.
5198         * nat/x86-linux.h: Rename include guard.
5199         * nat/x86-linux-dregs.h: Rename include guard.
5200         * nat/x86-gcc-cpuid.h: Add include guard.
5201         * nat/x86-dregs.h: Rename include guard.
5202         * nat/x86-cpuid.h: Rename include guard.
5203         * nat/ppc-linux.h: Rename include guard.
5204         * nat/mips-linux-watch.h: Rename include guard.
5205         * nat/linux-waitpid.h: Rename include guard.
5206         * nat/linux-ptrace.h: Rename include guard.
5207         * nat/linux-procfs.h: Rename include guard.
5208         * nat/linux-osdata.h: Rename include guard.
5209         * nat/linux-nat.h: Rename include guard.
5210         * nat/linux-namespaces.h: Rename include guard.
5211         * nat/linux-btrace.h: Rename include guard.
5212         * nat/glibc_thread_db.h: Rename include guard.
5213         * nat/gdb_thread_db.h: Rename include guard.
5214         * nat/gdb_ptrace.h: Rename include guard.
5215         * nat/fork-inferior.h: Rename include guard.
5216         * nat/amd64-linux-siginfo.h: Rename include guard.
5217         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5218         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5219         * nat/aarch64-linux.h: Rename include guard.
5220         * nat/aarch64-linux-hw-point.h: Rename include guard.
5221         * mn10300-tdep.h: Add include guard.
5222         * mips-linux-tdep.h: Add include guard.
5223         * mi/mi-parse.h: Rename include guard.
5224         * mi/mi-out.h: Rename include guard.
5225         * mi/mi-main.h: Rename include guard.
5226         * mi/mi-interp.h: Rename include guard.
5227         * mi/mi-getopt.h: Rename include guard.
5228         * mi/mi-console.h: Rename include guard.
5229         * mi/mi-common.h: Rename include guard.
5230         * mi/mi-cmds.h: Rename include guard.
5231         * mi/mi-cmd-break.h: Rename include guard.
5232         * m2-lang.h: Add include guard.
5233         * location.h: Rename include guard.
5234         * linux-record.h: Rename include guard.
5235         * linux-nat.h: Add include guard.
5236         * linux-fork.h: Add include guard.
5237         * i386-darwin-tdep.h: Rename include guard.
5238         * hppa-linux-offsets.h: Add include guard.
5239         * guile/guile.h: Rename include guard.
5240         * guile/guile-internal.h: Rename include guard.
5241         * gnu-nat.h: Rename include guard.
5242         * gdb-stabs.h: Rename include guard.
5243         * frv-tdep.h: Add include guard.
5244         * f-lang.h: Add include guard.
5245         * event-loop.h: Add include guard.
5246         * darwin-nat.h: Rename include guard.
5247         * cp-abi.h: Rename include guard.
5248         * config/sparc/nm-sol2.h: Rename include guard.
5249         * config/nm-nto.h: Rename include guard.
5250         * config/nm-linux.h: Add include guard.
5251         * config/i386/nm-i386gnu.h: Rename include guard.
5252         * config/djgpp/nl_types.h: Rename include guard.
5253         * config/djgpp/langinfo.h: Rename include guard.
5254         * compile/gcc-cp-plugin.h: Add include guard.
5255         * compile/gcc-c-plugin.h: Add include guard.
5256         * compile/compile.h: Rename include guard.
5257         * compile/compile-object-run.h: Rename include guard.
5258         * compile/compile-object-load.h: Rename include guard.
5259         * compile/compile-internal.h: Rename include guard.
5260         * compile/compile-cplus.h: Rename include guard.
5261         * compile/compile-c.h: Rename include guard.
5262         * common/xml-utils.h: Rename include guard.
5263         * common/x86-xstate.h: Rename include guard.
5264         * common/version.h: Rename include guard.
5265         * common/vec.h: Rename include guard.
5266         * common/tdesc.h: Rename include guard.
5267         * common/selftest.h: Rename include guard.
5268         * common/scoped_restore.h: Rename include guard.
5269         * common/scoped_mmap.h: Rename include guard.
5270         * common/scoped_fd.h: Rename include guard.
5271         * common/safe-iterator.h: Rename include guard.
5272         * common/run-time-clock.h: Rename include guard.
5273         * common/refcounted-object.h: Rename include guard.
5274         * common/queue.h: Rename include guard.
5275         * common/ptid.h: Rename include guard.
5276         * common/print-utils.h: Rename include guard.
5277         * common/preprocessor.h: Rename include guard.
5278         * common/pathstuff.h: Rename include guard.
5279         * common/observable.h: Rename include guard.
5280         * common/netstuff.h: Rename include guard.
5281         * common/job-control.h: Rename include guard.
5282         * common/host-defs.h: Rename include guard.
5283         * common/gdb_wait.h: Rename include guard.
5284         * common/gdb_vecs.h: Rename include guard.
5285         * common/gdb_unlinker.h: Rename include guard.
5286         * common/gdb_unique_ptr.h: Rename include guard.
5287         * common/gdb_tilde_expand.h: Rename include guard.
5288         * common/gdb_sys_time.h: Rename include guard.
5289         * common/gdb_string_view.h: Rename include guard.
5290         * common/gdb_splay_tree.h: Rename include guard.
5291         * common/gdb_setjmp.h: Rename include guard.
5292         * common/gdb_ref_ptr.h: Rename include guard.
5293         * common/gdb_optional.h: Rename include guard.
5294         * common/gdb_locale.h: Rename include guard.
5295         * common/gdb_assert.h: Rename include guard.
5296         * common/filtered-iterator.h: Rename include guard.
5297         * common/filestuff.h: Rename include guard.
5298         * common/fileio.h: Rename include guard.
5299         * common/environ.h: Rename include guard.
5300         * common/common-utils.h: Rename include guard.
5301         * common/common-types.h: Rename include guard.
5302         * common/common-regcache.h: Rename include guard.
5303         * common/common-inferior.h: Rename include guard.
5304         * common/common-gdbthread.h: Rename include guard.
5305         * common/common-exceptions.h: Rename include guard.
5306         * common/common-defs.h: Rename include guard.
5307         * common/common-debug.h: Rename include guard.
5308         * common/cleanups.h: Rename include guard.
5309         * common/buffer.h: Rename include guard.
5310         * common/btrace-common.h: Rename include guard.
5311         * common/break-common.h: Rename include guard.
5312         * cli/cli-utils.h: Rename include guard.
5313         * cli/cli-style.h: Rename include guard.
5314         * cli/cli-setshow.h: Rename include guard.
5315         * cli/cli-script.h: Rename include guard.
5316         * cli/cli-interp.h: Rename include guard.
5317         * cli/cli-decode.h: Rename include guard.
5318         * cli/cli-cmds.h: Rename include guard.
5319         * charset-list.h: Add include guard.
5320         * buildsym-legacy.h: Rename include guard.
5321         * bfin-tdep.h: Add include guard.
5322         * ax.h: Rename include guard.
5323         * arm-linux-tdep.h: Add include guard.
5324         * arm-fbsd-tdep.h: Add include guard.
5325         * arch/xtensa.h: Rename include guard.
5326         * arch/tic6x.h: Add include guard.
5327         * arch/i386.h: Add include guard.
5328         * arch/arm.h: Rename include guard.
5329         * arch/arm-linux.h: Rename include guard.
5330         * arch/arm-get-next-pcs.h: Rename include guard.
5331         * arch/amd64.h: Add include guard.
5332         * arch/aarch64-insn.h: Rename include guard.
5333         * arch-utils.h: Rename include guard.
5334         * annotate.h: Add include guard.
5335         * amd64-darwin-tdep.h: Rename include guard.
5336         * aarch64-linux-tdep.h: Add include guard.
5337         * aarch64-fbsd-tdep.h: Add include guard.
5338         * aarch32-linux-nat.h: Add include guard.
5339
5340 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5341
5342         * macrotab.c (macro_define_internal): New function that
5343         factorizes macro_define_object_internal and macro_define_function
5344         code.
5345         (macro_define_object_internal): Use macro_define_internal.
5346         (macro_define_function): Likewise.
5347
5348 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5349
5350         * macrocmd.c (extract_identifier): Return
5351         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5352         callers.
5353
5354 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5355
5356         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5357
5358 2019-02-05  Tom Tromey  <tom@tromey.com>
5359
5360         * target.c (target_stack::unpush): Move assertion earlier.
5361
5362 2019-01-30  Tom Tromey  <tom@tromey.com>
5363
5364         PR python/23615:
5365         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5366         (gdbpy_parse_and_eval): Likewise.
5367         * python/python-internal.h (gdbpy_allow_threads): New class.
5368
5369 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5370
5371         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5372         (aarch64_fbsd_fpregmap): Move earlier.
5373         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5374         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5375         instead of individual calls to trad_frame_set_reg_addr.
5376         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5377         earlier.
5378         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5379         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5380         instead of individual calls to trad_frame_set_reg_addr.
5381
5382 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5383
5384         * CONTRIBUTE: Replace contribution list with wiki link.
5385
5386 2019-01-25  Tom Tromey  <tom@tromey.com>
5387
5388         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5389
5390 2019-01-25  Tom Tromey  <tom@tromey.com>
5391
5392         * xtensa-linux-nat.c: Fix common/ includes.
5393         * xml-support.h: Fix common/ includes.
5394         * xml-support.c: Fix common/ includes.
5395         * x86-linux-nat.c: Fix common/ includes.
5396         * windows-nat.c: Fix common/ includes.
5397         * varobj.h: Fix common/ includes.
5398         * varobj.c: Fix common/ includes.
5399         * value.c: Fix common/ includes.
5400         * valops.c: Fix common/ includes.
5401         * utils.c: Fix common/ includes.
5402         * unittests/xml-utils-selftests.c: Fix common/ includes.
5403         * unittests/utils-selftests.c: Fix common/ includes.
5404         * unittests/unpack-selftests.c: Fix common/ includes.
5405         * unittests/tracepoint-selftests.c: Fix common/ includes.
5406         * unittests/style-selftests.c: Fix common/ includes.
5407         * unittests/string_view-selftests.c: Fix common/ includes.
5408         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5409         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5410         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5411         * unittests/rsp-low-selftests.c: Fix common/ includes.
5412         * unittests/parse-connection-spec-selftests.c: Fix common/
5413         includes.
5414         * unittests/optional-selftests.c: Fix common/ includes.
5415         * unittests/offset-type-selftests.c: Fix common/ includes.
5416         * unittests/observable-selftests.c: Fix common/ includes.
5417         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5418         * unittests/memrange-selftests.c: Fix common/ includes.
5419         * unittests/memory-map-selftests.c: Fix common/ includes.
5420         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5421         * unittests/function-view-selftests.c: Fix common/ includes.
5422         * unittests/environ-selftests.c: Fix common/ includes.
5423         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5424         * unittests/common-utils-selftests.c: Fix common/ includes.
5425         * unittests/cli-utils-selftests.c: Fix common/ includes.
5426         * unittests/array-view-selftests.c: Fix common/ includes.
5427         * ui-file.c: Fix common/ includes.
5428         * tui/tui-io.c: Fix common/ includes.
5429         * tracepoint.h: Fix common/ includes.
5430         * tracepoint.c: Fix common/ includes.
5431         * tracefile-tfile.c: Fix common/ includes.
5432         * top.h: Fix common/ includes.
5433         * top.c: Fix common/ includes.
5434         * thread.c: Fix common/ includes.
5435         * target/waitstatus.h: Fix common/ includes.
5436         * target/waitstatus.c: Fix common/ includes.
5437         * target.h: Fix common/ includes.
5438         * target.c: Fix common/ includes.
5439         * target-memory.c: Fix common/ includes.
5440         * target-descriptions.c: Fix common/ includes.
5441         * symtab.h: Fix common/ includes.
5442         * symfile.c: Fix common/ includes.
5443         * stap-probe.c: Fix common/ includes.
5444         * spu-linux-nat.c: Fix common/ includes.
5445         * sparc-nat.c: Fix common/ includes.
5446         * source.c: Fix common/ includes.
5447         * solib.c: Fix common/ includes.
5448         * solib-target.c: Fix common/ includes.
5449         * ser-unix.c: Fix common/ includes.
5450         * ser-tcp.c: Fix common/ includes.
5451         * ser-pipe.c: Fix common/ includes.
5452         * ser-base.c: Fix common/ includes.
5453         * selftest-arch.c: Fix common/ includes.
5454         * s12z-tdep.c: Fix common/ includes.
5455         * rust-exp.y: Fix common/ includes.
5456         * rs6000-aix-tdep.c: Fix common/ includes.
5457         * riscv-tdep.c: Fix common/ includes.
5458         * remote.c: Fix common/ includes.
5459         * remote-notif.h: Fix common/ includes.
5460         * remote-fileio.h: Fix common/ includes.
5461         * remote-fileio.c: Fix common/ includes.
5462         * regcache.h: Fix common/ includes.
5463         * regcache.c: Fix common/ includes.
5464         * record-btrace.c: Fix common/ includes.
5465         * python/python.c: Fix common/ includes.
5466         * python/py-type.c: Fix common/ includes.
5467         * python/py-inferior.c: Fix common/ includes.
5468         * progspace.h: Fix common/ includes.
5469         * producer.c: Fix common/ includes.
5470         * procfs.c: Fix common/ includes.
5471         * proc-api.c: Fix common/ includes.
5472         * printcmd.c: Fix common/ includes.
5473         * ppc-linux-nat.c: Fix common/ includes.
5474         * parser-defs.h: Fix common/ includes.
5475         * osdata.c: Fix common/ includes.
5476         * obsd-nat.c: Fix common/ includes.
5477         * nat/x86-linux.c: Fix common/ includes.
5478         * nat/x86-linux-dregs.c: Fix common/ includes.
5479         * nat/x86-dregs.h: Fix common/ includes.
5480         * nat/x86-dregs.c: Fix common/ includes.
5481         * nat/ppc-linux.c: Fix common/ includes.
5482         * nat/mips-linux-watch.h: Fix common/ includes.
5483         * nat/mips-linux-watch.c: Fix common/ includes.
5484         * nat/linux-waitpid.c: Fix common/ includes.
5485         * nat/linux-ptrace.h: Fix common/ includes.
5486         * nat/linux-ptrace.c: Fix common/ includes.
5487         * nat/linux-procfs.c: Fix common/ includes.
5488         * nat/linux-personality.c: Fix common/ includes.
5489         * nat/linux-osdata.c: Fix common/ includes.
5490         * nat/linux-namespaces.c: Fix common/ includes.
5491         * nat/linux-btrace.h: Fix common/ includes.
5492         * nat/linux-btrace.c: Fix common/ includes.
5493         * nat/fork-inferior.c: Fix common/ includes.
5494         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5495         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5496         * nat/aarch64-linux.c: Fix common/ includes.
5497         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5498         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5499         * namespace.h: Fix common/ includes.
5500         * mips-linux-tdep.c: Fix common/ includes.
5501         * minsyms.c: Fix common/ includes.
5502         * mi/mi-parse.h: Fix common/ includes.
5503         * mi/mi-main.c: Fix common/ includes.
5504         * mi/mi-cmd-env.c: Fix common/ includes.
5505         * memrange.h: Fix common/ includes.
5506         * memattr.c: Fix common/ includes.
5507         * maint.h: Fix common/ includes.
5508         * maint.c: Fix common/ includes.
5509         * main.c: Fix common/ includes.
5510         * machoread.c: Fix common/ includes.
5511         * location.c: Fix common/ includes.
5512         * linux-thread-db.c: Fix common/ includes.
5513         * linux-nat.c: Fix common/ includes.
5514         * linux-fork.c: Fix common/ includes.
5515         * inline-frame.c: Fix common/ includes.
5516         * infrun.c: Fix common/ includes.
5517         * inflow.c: Fix common/ includes.
5518         * inferior.h: Fix common/ includes.
5519         * inferior.c: Fix common/ includes.
5520         * infcmd.c: Fix common/ includes.
5521         * inf-ptrace.c: Fix common/ includes.
5522         * inf-child.c: Fix common/ includes.
5523         * ia64-linux-nat.c: Fix common/ includes.
5524         * i387-tdep.c: Fix common/ includes.
5525         * i386-tdep.c: Fix common/ includes.
5526         * i386-linux-tdep.c: Fix common/ includes.
5527         * i386-linux-nat.c: Fix common/ includes.
5528         * i386-go32-tdep.c: Fix common/ includes.
5529         * i386-fbsd-tdep.c: Fix common/ includes.
5530         * i386-fbsd-nat.c: Fix common/ includes.
5531         * guile/scm-type.c: Fix common/ includes.
5532         * guile/guile.c: Fix common/ includes.
5533         * go32-nat.c: Fix common/ includes.
5534         * gnu-nat.c: Fix common/ includes.
5535         * gdbthread.h: Fix common/ includes.
5536         * gdbarch-selftests.c: Fix common/ includes.
5537         * gdb_usleep.c: Fix common/ includes.
5538         * gdb_select.h: Fix common/ includes.
5539         * gdb_bfd.c: Fix common/ includes.
5540         * gcore.c: Fix common/ includes.
5541         * fork-child.c: Fix common/ includes.
5542         * findvar.c: Fix common/ includes.
5543         * fbsd-nat.c: Fix common/ includes.
5544         * event-top.c: Fix common/ includes.
5545         * event-loop.c: Fix common/ includes.
5546         * dwarf2read.c: Fix common/ includes.
5547         * dwarf2loc.c: Fix common/ includes.
5548         * dwarf2-frame.c: Fix common/ includes.
5549         * dwarf-index-cache.c: Fix common/ includes.
5550         * dtrace-probe.c: Fix common/ includes.
5551         * disasm-selftests.c: Fix common/ includes.
5552         * defs.h: Fix common/ includes.
5553         * csky-tdep.c: Fix common/ includes.
5554         * cp-valprint.c: Fix common/ includes.
5555         * cp-support.h: Fix common/ includes.
5556         * cp-support.c: Fix common/ includes.
5557         * corelow.c: Fix common/ includes.
5558         * completer.h: Fix common/ includes.
5559         * completer.c: Fix common/ includes.
5560         * compile/compile.c: Fix common/ includes.
5561         * compile/compile-loc2c.c: Fix common/ includes.
5562         * compile/compile-cplus-types.c: Fix common/ includes.
5563         * compile/compile-cplus-symbols.c: Fix common/ includes.
5564         * command.h: Fix common/ includes.
5565         * cli/cli-dump.c: Fix common/ includes.
5566         * cli/cli-cmds.c: Fix common/ includes.
5567         * charset.c: Fix common/ includes.
5568         * build-id.c: Fix common/ includes.
5569         * btrace.h: Fix common/ includes.
5570         * btrace.c: Fix common/ includes.
5571         * breakpoint.h: Fix common/ includes.
5572         * breakpoint.c: Fix common/ includes.
5573         * ax.h:
5574         (enum agent_op): Fix common/ includes.
5575         * ax-general.c (struct aop_map): Fix common/ includes.
5576         * ax-gdb.c: Fix common/ includes.
5577         * auxv.c: Fix common/ includes.
5578         * auto-load.c: Fix common/ includes.
5579         * arm-tdep.c: Fix common/ includes.
5580         * arch/riscv.c: Fix common/ includes.
5581         * arch/ppc-linux-common.c: Fix common/ includes.
5582         * arch/i386.c: Fix common/ includes.
5583         * arch/arm.c: Fix common/ includes.
5584         * arch/arm-linux.c: Fix common/ includes.
5585         * arch/arm-get-next-pcs.c: Fix common/ includes.
5586         * arch/amd64.c: Fix common/ includes.
5587         * arch/aarch64.c: Fix common/ includes.
5588         * arch/aarch64-insn.c: Fix common/ includes.
5589         * arch-utils.c: Fix common/ includes.
5590         * amd64-windows-tdep.c: Fix common/ includes.
5591         * amd64-tdep.c: Fix common/ includes.
5592         * amd64-sol2-tdep.c: Fix common/ includes.
5593         * amd64-obsd-tdep.c: Fix common/ includes.
5594         * amd64-nbsd-tdep.c: Fix common/ includes.
5595         * amd64-linux-tdep.c: Fix common/ includes.
5596         * amd64-linux-nat.c: Fix common/ includes.
5597         * amd64-fbsd-tdep.c: Fix common/ includes.
5598         * amd64-fbsd-nat.c: Fix common/ includes.
5599         * amd64-dicos-tdep.c: Fix common/ includes.
5600         * amd64-darwin-tdep.c: Fix common/ includes.
5601         * agent.c: Fix common/ includes.
5602         * ada-lang.h: Fix common/ includes.
5603         * ada-lang.c: Fix common/ includes.
5604         * aarch64-tdep.c: Fix common/ includes.
5605
5606 2019-01-25  Tom Tromey  <tom@tromey.com>
5607
5608         * common/create-version.sh: Use common/version.h.
5609
5610 2019-01-24  Pedro Alves  <palves@redhat.com>
5611
5612         * infrun.c (signal_stop, signal_print, signal_program)
5613         (signal_catch, signal_pass): Now arrays instead of pointers.
5614         (update_signals_program_target, do_target_resume)
5615         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5616         * linux-nat.c (linux_nat_target::pass_signals)
5617         (linux_nat_target::create_inferior, linux_nat_target::attach):
5618         Adjust.
5619         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5620         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5621         * procfs.c (procfs_target::pass_signals): Adjust.
5622         * record-full.c (record_full_target::resume): Adjust.
5623         * remote.c (remote_target::pass_signals)
5624         (remote_target::program_signals): Adjust.
5625         * target-debug.h (target_debug_print_signals): Now takes a
5626         gdb::array_view as parameter.  Adjust.
5627         * target.h (target_ops) <pass_signals, program_signals>: Replace
5628         pointer and length parameters with gdb::array_view.
5629         (target_pass_signals, target_program_signals): Likewise.
5630         * target-delegates.c: Regenerate.
5631
5632 2019-01-24  Pedro Alves  <palves@redhat.com>
5633
5634         * common/forward-scope-exit.h
5635         (forward_scope_exit::forward_scope_exit): Pass arguments to
5636         m_bind_function directly, instead of creating a std::bind and
5637         copying that.
5638
5639 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5640
5641         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5642         for static members.
5643         (pass_in_v_vfp_candidate): Likewise.
5644
5645 2019-01-23  Tom Tromey  <tom@tromey.com>
5646             Pedro Alves  <palves@redhat.com>
5647
5648         * regcache.c (class regcache_invalidator): Remove.
5649         (regcache::raw_write): Use make_scope_exit.
5650
5651 2019-01-23  Tom Tromey  <tom@tromey.com>
5652
5653         * ui-out.h (class ui_out_emit_type): Update comment.
5654
5655 2019-01-23  Tom Tromey  <tom@tromey.com>
5656
5657         * infrun.c (fetch_inferior_event): Update comment.
5658
5659 2019-01-23  Tom Tromey  <tom@tromey.com>
5660             Pedro Alves  <palves@redhat.com>
5661
5662         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5663         parameter.
5664         (fetch_inferior_event): Use SCOPE_EXIT.
5665
5666
5667 2019-01-23  Tom Tromey  <tom@tromey.com>
5668             Pedro Alves  <palves@redhat.com>
5669
5670         * infrun.c (disable_thread_events): Delete.
5671         (stop_all_threads): Use SCOPE_EXIT.
5672
5673 2019-01-23  Tom Tromey  <tom@tromey.com>
5674             Pedro Alves  <palves@redhat.com>
5675
5676         * symfile.c: Include forward-scope-exit.h.
5677         (clear_symtab_users_cleanup): Replace forward declaration with
5678         a FORWARD_SCOPE_EXIT.
5679         (syms_from_objfile_1): Use the forward_scope_exit and
5680         gdb::optional instead of cleanup_function.
5681         (reread_symbols): Use the forward_scope_exit instead of
5682         cleanup_function.
5683         (clear_symtab_users_cleanup): Remove function.
5684
5685 2019-01-23  Tom Tromey  <tom@tromey.com>
5686             Pedro Alves  <palves@redhat.com>
5687
5688         * linux-nat.c: Include scope-exit.h.
5689         (cleanup_target_stop): Remove.
5690         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5691         SCOPE_EXIT.
5692
5693 2019-01-23  Tom Tromey  <tom@tromey.com>
5694             Pedro Alves  <palves@redhat.com>
5695
5696         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5697         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5698
5699 2019-01-23  Tom Tromey  <tom@tromey.com>
5700             Andrew Burgess  <andrew.burgess@embecosm.com>
5701             Pedro Alves  <palves@redhat.com>
5702
5703         * infrun.c (fetch_inferior_event): Use scope_exit.
5704         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5705         * top.c (execute_command): Use scope_exit.
5706         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5707         * utils.c (do_bpstat_clear_actions_cleanup)
5708         (make_bpstat_clear_actions_cleanup): Remove.
5709
5710 2019-01-23  Tom Tromey  <tom@tromey.com>
5711             Pedro Alves  <palves@redhat.com>
5712
5713         * infrun.c: Include "common/scope-exit.h"
5714         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5715         (wait_for_inferior): Use SCOPE_EXIT.
5716         (fetch_inferior_event): Use scope_exit.
5717
5718 2019-01-23  Tom Tromey  <tom@tromey.com>
5719             Pedro Alves  <palves@redhat.com>
5720
5721         * breakpoint.c (create_breakpoint): Remove cleanup.
5722
5723 2019-01-23  Tom Tromey  <tom@tromey.com>
5724             Andrew Burgess  <andrew.burgess@embecosm.com>
5725             Pedro Alves  <palves@redhat.com>
5726
5727 2019-01-23  Pedro Alves  <palves@redhat.com>
5728
5729         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5730
5731 2019-01-23  Pedro Alves  <palves@redhat.com>
5732             Andrew Burgess  <andrew.burgess@embecosm.com>
5733
5734         * gdbthread.h: Include "common/forward-scope-exit.h".
5735         (scoped_finish_thread_state): Redefine custom class in terms of
5736         forward_scope_exit.
5737
5738 2019-01-23  Pedro Alves  <palves@redhat.com>
5739             Andrew Burgess  <andrew.burgess@embecosm.com>
5740
5741         * common/forward-scope-exit.h: New file.
5742
5743 2019-01-23  Pedro Alves  <palves@redhat.com>
5744             Andrew Burgess  <andrew.burgess@embecosm.com>
5745             Tom Tromey  <tom@tromey.com>
5746
5747         * common/scope-exit.h: New file.
5748
5749 2019-01-23  Pedro Alves  <palves@redhat.com>
5750
5751         * common/preprocessor.h (ESC): Rename to ...
5752         (ESC_PARENS): ... this.
5753         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5754         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5755
5756 2019-01-23  Tom Tromey  <tom@tromey.com>
5757
5758         * language.h (class scoped_switch_to_sym_language_if_auto):
5759         Initialize m_lang in both cases.
5760
5761 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5762
5763         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5764         with XCNEW.
5765
5766 2019-01-22  Tom Tromey  <tom@tromey.com>
5767
5768         * corelow.c: Do not include sys/file.h.
5769
5770 2019-01-22  Tom Tromey  <tom@tromey.com>
5771
5772         * tui/tui-wingeneral.h: Include gdb_curses.h.
5773
5774 2019-01-22  Tom Tromey  <tom@tromey.com>
5775
5776         * source-cache.h (class source_cache) <get_source_lines,
5777         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5778
5779 2019-01-22  Tom Tromey  <tom@tromey.com>
5780
5781         * remote-fileio.h (struct remote_target): Declare.
5782
5783 2019-01-22  Tom Tromey  <tom@tromey.com>
5784
5785         * python/py-arch.c: Do not include py-ref.h.
5786         * python/py-bpevent.c: Do not include py-ref.h.
5787         * python/py-cmd.c: Do not include py-ref.h.
5788         * python/py-continueevent.c: Do not include py-ref.h.
5789         * python/py-event.h: Do not include py-ref.h.
5790         * python/py-evtregistry.c: Do not include py-ref.h.
5791         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5792         * python/py-frame.c: Do not include py-ref.h.
5793         * python/py-framefilter.c: Do not include py-ref.h.
5794         * python/py-function.c: Do not include py-ref.h.
5795         * python/py-infevents.c: Do not include py-ref.h.
5796         * python/py-linetable.c: Do not include py-ref.h.
5797         * python/py-objfile.c: Do not include py-ref.h.
5798         * python/py-param.c: Do not include py-ref.h.
5799         * python/py-prettyprint.c: Do not include py-ref.h.
5800         * python/py-progspace.c: Do not include py-ref.h.
5801         * python/py-symbol.c: Do not include py-ref.h.
5802         * python/py-symtab.c: Do not include py-ref.h.
5803         * python/py-type.c: Do not include py-ref.h.
5804         * python/py-unwind.c: Do not include py-ref.h.
5805         * python/py-utils.c: Do not include py-ref.h.
5806         * python/py-value.c: Do not include py-ref.h.
5807         * python/py-varobj.c: Do not include py-ref.h.
5808         * python/py-xmethods.c: Do not include py-ref.h.
5809         * python/python.c: Do not include py-ref.h.
5810         * varobj.c: Do not include py-ref.h.
5811
5812 2019-01-22  Tom Tromey  <tom@tromey.com>
5813
5814         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5815         keyword for bcache.
5816
5817 2019-01-22  Tom Tromey  <tom@tromey.com>
5818
5819         * compile/compile-cplus-types.c: Remove a comment by #include.
5820
5821 2019-01-22  Tom Tromey  <tom@tromey.com>
5822
5823         * compile/gcc-c-plugin.h: Include compile-internal.h.
5824
5825 2019-01-22  Tom Tromey  <tom@tromey.com>
5826
5827         * stabsread.c (EXTERN): Do not define.
5828         (symnum, next_symbol_text_func, processing_gcc_compilation)
5829         (within_function, global_sym_chain, global_stabs)
5830         (previous_stab_code, this_object_header_files)
5831         (n_this_object_header_files)
5832         (n_allocated_this_object_header_files): Define.
5833         * stabsread.h (EXTERN): Never define.  Use "extern".
5834
5835 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5836
5837         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5838         history_value.
5839
5840 2019-01-21  Tom Tromey  <tom@tromey.com>
5841
5842         * ui-out.c: Fix includes.
5843         * tui/tui-source.c: Fix includes.
5844         * target.c: Fix includes.
5845         * remote.c: Fix includes.
5846         * regcache.c: Fix includes.
5847         * python/py-block.c: Fix includes.
5848         * printcmd.c: Fix includes.
5849         * or1k-tdep.c: Fix includes.
5850         * mi/mi-main.c: Fix includes.
5851         * m32r-tdep.c: Fix includes.
5852         * csky-tdep.c: Fix includes.
5853         * compile/compile-cplus-types.c: Fix includes.
5854         * cli/cli-interp.c: Fix includes.
5855
5856 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5857
5858         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5859         for padding.
5860
5861 2019-01-16  Tom Tromey  <tom@tromey.com>
5862
5863         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5864         earlier.
5865         (struct objfile) <msymbols_range>: Move from top level.
5866         <msymbols>: New method.
5867         (class objfile_msymbols): Remove.
5868         * symtab.c (default_collect_symbol_completion_matches_break_on):
5869         Update.
5870         * symmisc.c (dump_msymbols): Update.
5871         * stabsread.c (scan_file_globals): Update.
5872         * objc-lang.c (info_selectors_command, info_classes_command)
5873         (find_methods): Update.
5874         * minsyms.c (find_solib_trampoline_target): Update.
5875         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5876         * coffread.c (coff_symfile_read): Update.
5877         * ada-lang.c (ada_lookup_simple_minsym)
5878         (ada_collect_symbol_completion_matches): Update.
5879
5880 2019-01-16  Tom Tromey  <tom@tromey.com>
5881
5882         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5883         type.  Remove no-argument constructor.
5884         <iterator::operator++>: Simplify.
5885         <begin>: Update.
5886         <end>: Use minimal_symbol_count.
5887
5888 2019-01-16  Tom Tromey  <tom@tromey.com>
5889
5890         * objfiles.h (struct objfile) <psymtabs>: New method.
5891         (class objfile_psymtabs): Remove.
5892         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5893         typedef.
5894         <range>: New method.
5895         (require_partial_symbols): Change return type.
5896         * psymtab.c (require_partial_symbols)
5897         (psym_expand_symtabs_matching): Update.
5898         * mdebugread.c (parse_partial_symbols): Update.
5899         * dbxread.c (dbx_end_psymtab): Update.
5900
5901 2019-01-15  Tom Tromey  <tom@tromey.com>
5902
5903         * symtab.c (lookup_objfile_from_block)
5904         (lookup_symbol_in_objfile_symtabs)
5905         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5906         (find_line_symtab, info_sources_command)
5907         (default_collect_symbol_completion_matches_break_on)
5908         (make_source_files_completion_list): Update.
5909         * symmisc.c (print_objfile_statistics, dump_objfile)
5910         (maintenance_print_symbols, maintenance_info_symtabs)
5911         (maintenance_check_symtabs, maintenance_info_line_tables):
5912         Update.
5913         * source.c (select_source_symtab)
5914         (forget_cached_source_info_for_objfile): Update.
5915         * objfiles.h (class objfile_compunits): Remove.
5916         (struct objfile) <compunits_range>: New typedef.
5917         (compunits): New method.
5918         * objfiles.c (objfile_relocate1): Update.
5919         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5920         * maint.c (count_symtabs_and_blocks): Update.
5921         * linespec.c (iterate_over_all_matching_symtabs): Update.
5922         * cp-support.c (add_symbol_overload_list_qualified): Update.
5923         * coffread.c (coff_symtab_read): Update.
5924         * ada-lang.c (add_nonlocal_symbols)
5925         (ada_collect_symbol_completion_matches)
5926         (ada_add_global_exceptions): Update.
5927
5928 2019-01-15  Tom Tromey  <tom@tromey.com>
5929
5930         * progspace.h (program_space) <objfiles_safe_range>: New
5931         typedef.
5932         <objfiles_safe>: New method.
5933         * objfiles.h (class all_objfiles_safe): Remove.
5934         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5935         * jit.c (jit_inferior_exit_hook): Update.
5936
5937 2019-01-17  Tom Tromey  <tom@tromey.com>
5938
5939         * progspace.h (program_space) <objfiles_range>: New typedef.
5940         <objfiles>: New method.
5941         <objfiles_head>: Rename from objfiles.
5942         (object_files): Update.
5943         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5944         * guile/scm-pretty-print.c
5945         (ppscm_find_pretty_printer_from_objfiles): Update.
5946         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5947         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5948         Update.
5949         * python/py-progspace.c (pspy_get_objfiles): Update.
5950         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5951         Update.
5952         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5953         (objfpy_lookup_objfile_by_build_id): Update.
5954         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5955         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5956         Update.
5957         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5958         (expand_symtab_containing_pc, lookup_objfile_from_block)
5959         (lookup_static_symbol, basic_lookup_transparent_type)
5960         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5961         (find_line_symtab, info_sources_command)
5962         (default_collect_symbol_completion_matches_break_on)
5963         (make_source_files_completion_list, find_main_name): Update.
5964         * symmisc.c (print_symbol_bcache_statistics)
5965         (print_objfile_statistics, maintenance_print_symbols)
5966         (maintenance_print_msymbols, maintenance_print_objfiles)
5967         (maintenance_info_symtabs, maintenance_check_symtabs)
5968         (maintenance_expand_symtabs, maintenance_info_line_tables):
5969         Update.
5970         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5971         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5972         (map_overlay_command, unmap_overlay_command)
5973         (simple_overlay_update, expand_symtabs_matching)
5974         (map_symbol_filenames): Update.
5975         * symfile-debug.c (set_debug_symfile): Update.
5976         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5977         Update.
5978         * source.c (select_source_symtab, forget_cached_source_info):
5979         Update.
5980         * solib.c (solib_read_symbols): Update.
5981         * solib-spu.c (append_ocl_sos): Update.
5982         * psymtab.c (maintenance_print_psymbols)
5983         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5984         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5985         * printcmd.c (info_symbol_command): Update.
5986         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5987         Update.
5988         * objfiles.h (class all_objfiles): Remove.
5989         * objfiles.c (have_partial_symbols, have_full_symbols)
5990         (have_minimal_symbols, qsort_cmp, update_section_map)
5991         (shared_objfile_contains_address_p)
5992         (default_iterate_over_objfiles_in_search_order): Update.
5993         * objc-lang.c (info_selectors_command, info_classes_command)
5994         (find_methods): Update.
5995         * minsyms.c (find_solib_trampoline_target): Update.
5996         * maint.c (maintenance_info_sections)
5997         (maintenance_translate_address, count_symtabs_and_blocks):
5998         Update.
5999         * main.c (captured_main_1): Update.
6000         * linux-thread-db.c (try_thread_db_load_from_pdir)
6001         (has_libpthread): Update.
6002         * linespec.c (iterate_over_all_matching_symtabs)
6003         (search_minsyms_for_name): Update.
6004         * jit.c (jit_find_objf_with_entry_addr): Update.
6005         * hppa-tdep.c (find_unwind_entry)
6006         (hppa_lookup_stub_minimal_symbol): Update.
6007         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6008         Update.
6009         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6010         (elf_gnu_ifunc_resolve_by_got): Update.
6011         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6012         * dwarf-index-write.c (save_gdb_index_command): Update.
6013         * cp-support.c (add_symbol_overload_list_qualified): Update.
6014         * breakpoint.c (create_overlay_event_breakpoint)
6015         (create_longjmp_master_breakpoint)
6016         (create_std_terminate_master_breakpoint)
6017         (create_exception_master_breakpoint): Update.
6018         * blockframe.c (find_pc_partial_function): Update.
6019         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6020         (ada_collect_symbol_completion_matches)
6021         (ada_add_global_exceptions): Update.
6022
6023 2019-01-17  Tom Tromey  <tom@tromey.com>
6024
6025         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6026         declare VEC.
6027         (solib_target_parse_libraries): Change return type.
6028         (library_list_start_segment, library_list_start_section)
6029         (library_list_end_library, library_list_start_library); Update.
6030         (solib_target_free_library_list): Remove.
6031         (solib_target_parse_libraries): Remove cleanup.  Change return
6032         type.
6033         (solib_target_current_sos): Update.
6034
6035 2019-01-17  Tom Tromey  <tromey@bapiya>
6036
6037         * valprint.c: Replace "the the" with "the".
6038         * symtab.c: Replace "the the" with "the".
6039         * solib.c: Replace "the the" with "the".
6040         * solib-dsbt.c: Replace "the the" with "the".
6041         * linespec.c: Replace "the the" with "the".
6042         * dwarf2loc.h: Replace "the the" with "the".
6043         * amd64-windows-tdep.c: Replace "the the" with "the".
6044         * aarch64-tdep.c: Replace "the the" with "the".
6045
6046 2019-01-16  Keith Seitz  <keiths@redhat.com>
6047
6048         PR gdb/23773
6049         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6050         <builder>: Rename to ..
6051         <m_builder>: ... this and make private.
6052         (dwarf2_cu::get_builder): New method.  Change all users of
6053         `builder' to use this method.
6054         (dwarf2_start_symtab): Move to ...
6055         (dwarf2_cu::start_symtab): ... here.  Update all callers
6056         (setup_type_unit_groups): Move to ...
6057         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6058         callers.
6059         (dwarf2_cu::reset_builder): New method.
6060         (process_full_compunit, process_full_type_unit): Use
6061         dwarf2_cu::reset_builder.
6062         (follow_die_offset): Record the ancestor CU if it is different
6063         from the followed DIE's CU.
6064         (follow_die_sig_1): Likewise.
6065
6066 2019-01-15  Tom Tromey  <tom@tromey.com>
6067
6068         * remote.c (class remote_state) <buf>: Now a char_vector.
6069         <buf_size>: Remove.
6070         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6071         parameter.
6072         (remote_target::getpkt_or_notif_sane_1)
6073         (remote_target::getpkt_sane)
6074         (remote_target::getpkt_or_notif_sane): Likewise.
6075         (class remote_target) <putpkt>: New overload.
6076         (remote_target::read_frame): Change type of "buf_p".  Remove
6077         sizeof_p parameter.
6078         (packet_ok): New overload.
6079         (packet_check_result): New overload.
6080         Update all uses.
6081
6082 2019-01-14  Tom Tromey  <tom@tromey.com>
6083
6084         * remote-notif.c (handle_notification, remote_notif_ack)
6085         (remote_notif_parse): Make "buf" const.
6086         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6087         const.
6088         (remote_notif_parse, remote_notif_ack, handle_notification):
6089         Likewise.
6090         * remote.c (remote_notif_stop_parse): Make "buf" const.
6091         (remote_target::remote_parse_stop_reply): Make "buf" const.
6092         (remote_notif_stop_ack): Make "buf" const.
6093
6094 2019-01-14  Tom Tromey  <tom@tromey.com>
6095
6096         * remote.c (remote_console_output): Make parameter const.
6097
6098 2019-01-14  Tom Tromey  <tom@tromey.com>
6099
6100         * target-debug.h (target_debug_print_signals): Constify.
6101         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6102         * procfs.c (procfs_target::pass_signals): Update.
6103         * linux-nat.c (linux_nat_target::pass_signals): Update.
6104         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6105         * target-delegates.c: Rebuild.
6106         * remote.c (remote_target::program_signals): Update.
6107         (remote_target::pass_signals): Update.
6108         * target.c (target_pass_signals): Constify argument.
6109         (target_program_signals): Likewise.
6110         * target.h (struct target_ops) <pass_signals, program_signals>:
6111         Constify argument.
6112         (target_pass_signals, target_program_signals): Constify argument.
6113
6114 2019-01-14  Tom Tromey  <tom@tromey.com>
6115
6116         PR tui/28819:
6117         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6118
6119 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6120
6121         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6122         field.
6123         * rs6000-tdep.c: Include reggroups.h.
6124         (IS_V_ALIAS_PSEUDOREG): Define.
6125         (rs6000_register_name): Return names for the "vX" aliases.
6126         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6127         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6128         aliases.  Call default_register_reggroup_p for all other
6129         pseudo-registers.
6130         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6131         New functions.
6132         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6133         Handle "vX" aliases.
6134         (v_alias_pseudo_register_collect): New function.
6135         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6136         (rs6000_gdbarch_init): Initialize "vX" aliases as
6137         pseudo-registers.  Restore registration of
6138         rs6000_pseudo_register_reggroup_p with
6139         set_tdesc_pseudo_register_reggroup_p.
6140
6141 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6142
6143         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6144         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6145         set_gdbarch_num_pseudo_regs.
6146
6147 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6148
6149         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6150         Remove arg prefixname, add do_set and do_show.
6151         Add member functions set_list and show_list.
6152         * cli/cli-style.c (class cli_style_option): Update accordingly.
6153         (style_set_list): Move to file scope.
6154         (style_show_list): Likewise.
6155         (set_style): Call help_list.
6156         (show_style): Call cmd_show_list.
6157         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6158         Update to use the new macro.
6159
6160 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6161
6162         * ada-lang.c (_initialize_ada_language): Expand the help text
6163         for the "catch exception" command.
6164
6165 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6166
6167         * symtab.c (matching_obj_sections): Initialize obj,
6168         declare it closer to its usage.
6169
6170 2019-01-10  Tom Tromey  <tom@tromey.com>
6171
6172         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6173         (basic_inf_threads_range): Remove.
6174         (inf_threads_range, inf_non_exited_threads_range)
6175         (safe_inf_threads_range): Use next_adapter.
6176
6177 2019-01-10  Keith Seitz  <keiths@redhat.com>
6178
6179         PR gdb/23712
6180         PR symtab/23010
6181         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6182         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6183
6184 2019-01-10  Keith Seitz  <keiths@redhat.com>
6185
6186         PR gdb/23712
6187         PR symtab/23010
6188         * dictionary.c (pending_to_vector): Remove.
6189         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6190         Remove _1 suffix, replacing functions of the same name.  Update
6191         all callers.
6192         (dict_create_hashed, dict_create_hashed_expandable)
6193         (dict_create_linear, dict_create_linear_expandable, dict_free)
6194         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6195         Make functions static.
6196
6197 2019-01-10  Keith Seitz  <keiths@redhat.com>
6198
6199         PR gdb/23712
6200         PR symtab/23010
6201         * dictionary.h (struct dictionary): Replace declaration with
6202         multidictionary.
6203         (dict_create_hashed, dict_create_hashed_expandable)
6204         (dict_create_linear, dict_create_linear_expandable)
6205         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6206         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6207         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6208         taking multidictionary argument.
6209         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6210         * block.h (struct block) <dict>: Change to multidictionary
6211         and rename `multidict'.
6212         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6213         symmisc.c: Update all dictionary references to multidictionary.
6214
6215 2019-01-10  Keith Seitz  <keiths@redhat.com>
6216
6217         PR gdb/23712
6218         PR symtab/23010
6219         * dictionary.c: Include unordered_map.
6220         (pending_to_vector): New function.
6221         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6222         Rewrite the non-"_1" functions to take vector instead
6223         of linked list.
6224         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6225         "new" _1 versions of the same name.
6226         (multidictionary): Define.
6227         (std::hash<enum language): New definition.
6228         (collate_pending_symbols_by_language, mdict_create_hashed)
6229         (mdict_create_hashed_expandable, mdict_create_linear)
6230         (mdict_create_linear_expandable, mdict_free)
6231         (find_language_dictionary, create_new_language_dictionary)
6232         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6233         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6234         (mdict_size, mdict_empty): New functions.
6235         * dictionary.h (mdict_iterator): Define.
6236
6237 2019-01-10  Pedro Alves  <palves@redhat.com>
6238
6239         * breakpoint.c (read_uploaded_action)
6240         (create_tracepoint_from_upload): Adjust to use
6241         gdb::unique_xmalloc_ptr.
6242         * ctf.c (ctf_write_uploaded_tp):
6243         (SET_ARRAY_FIELD): Use emplace_back.
6244         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6245         * tracefile-tfile.c (tfile_write_uploaded_tp):
6246         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6247         gdb::unique_xmalloc_ptr.
6248         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6249         at_string, cond_string, cmd_strings>: Replace char pointers
6250         with gdb::unique_xmalloc_ptr.
6251
6252 2019-01-10  Pedro Alves  <palves@redhat.com>
6253
6254         * solib-target.c (library_list_start_library): Don't xstrdup name.
6255
6256 2019-01-10  Pedro Alves  <palves@redhat.com>
6257
6258         * mdebugread.c (parse_partial_symbols): Use
6259         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6260
6261 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6262
6263         * linux-fork.c (scoped_switch_fork_info)
6264         <~scoped_switch_fork_info>: Fix incorrect variable name.
6265
6266 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6267
6268         * linux-fork.c (scoped_switch_fork_info)
6269         <scoped_switch_fork_info>: Make explicit.
6270         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6271
6272 2019-01-10  Tom Tromey  <tom@tromey.com>
6273
6274         * objfiles.h (objfile::reset_psymtabs): Update.
6275         * objfiles.c (objfile::objfile): Update.
6276         * psymtab.h (psymtab_storage::obstack): Update.
6277         (psymtab_storage::m_obstack): Use gdb::optional.
6278         (class psymtab_storage): Update comment.  Remove objfile
6279         parameter.
6280         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6281
6282 2019-01-10  Tom Tromey  <tom@tromey.com>
6283
6284         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6285         <free_psymtabs>: Now private.
6286         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6287         (allocate_psymtab): Use new method.
6288
6289 2019-01-10  Tom Tromey  <tom@tromey.com>
6290
6291         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6292         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6293         * mdebugread.c (parse_partial_symbols): Use
6294         allocate_dependencies.
6295         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6296         allocate_dependencies.
6297         (process_psymtab_comp_unit_reader)
6298         (build_type_psymtab_dependencies): Likewise.
6299         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6300
6301 2019-01-10  Tom Tromey  <tom@tromey.com>
6302
6303         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6304         PSYMBOL_SET_LANGUAGE.
6305         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6306
6307 2019-01-10  Tom Tromey  <tom@tromey.com>
6308
6309         * psymtab.h (psymtab_storage::obstack): New method.
6310         <m_obstack>: Rename from obstack; now private.
6311         * psymtab.c (psymtab_storage): Update.
6312         * dwarf2read.c (create_addrmap_from_index)
6313         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6314         Update.
6315
6316 2019-01-10  Tom Tromey  <tom@tromey.com>
6317
6318         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6319         * objfiles.h (objfile::reset_psymtabs): New method.
6320
6321 2019-01-10  Tom Tromey  <tom@tromey.com>
6322
6323         * symmisc.c (print_symbol_bcache_statistics): Update.
6324         (print_objfile_statistics): Update.
6325         * symfile.c (reread_symbols): Update.
6326         * psymtab.h (class psymtab_storage): New.
6327         * psymtab.c (psymtab_storage): New constructor.
6328         (~psymtab_storage): New destructor.
6329         (require_partial_symbols): Update.
6330         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6331         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6332         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6333         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6334         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6335         (start_psymtab_common, end_psymtab_common)
6336         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6337         (allocate_psymtab): Update.
6338         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6339         Update.
6340         (dump_psymtab_addrmap, maintenance_print_psymbols)
6341         (maintenance_check_psymtabs): Update.
6342         (class objfile_psymtabs): Move to objfiles.h.
6343         * psympriv.h (discard_psymtab): Now inline.
6344         (psymtab_discarder::psymtab_discarder): Update.
6345         (psymtab_discarder::~psymtab_discarder): Update.
6346         (ALL_OBJFILE_PSYMTABS): Rewrite.
6347         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6348         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6349         Remove fields.
6350         <partial_symtabs>: New field.
6351         (class objfile_psymtabs): Move from psymtab.h.  Update.
6352         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6353         psymbol_cache.
6354         (objfile::~objfile): Don't destroy psymbol_cache.
6355         * mdebugread.c (parse_partial_symbols): Update.
6356         * dwarf2read.c (create_addrmap_from_index)
6357         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6358         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6359         (add_partial_subprogram, dwarf2_ranges_read): Update.
6360         * dwarf-index-write.c (write_address_map)
6361         (write_one_signatured_type, recursively_write_psymbols)
6362         (class debug_names, class debug_names, write_psymtabs_to_index):
6363         Update.
6364
6365 2019-01-10  Tom Tromey  <tom@tromey.com>
6366
6367         * symtab.h (SYMBOL_SET_NAMES): Update.
6368         (symbol_set_names): Update.
6369         (MSYMBOL_SET_NAMES): Update.
6370         * symtab.c (symbol_set_names): Change argument to be an
6371         objfile_per_bfd_storage.
6372         * psymtab.c (add_psymbol_to_bcache): Update.
6373         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6374
6375 2019-01-10  Tom Tromey  <tom@tromey.com>
6376
6377         * symtab.c (create_demangled_names_hash): Change argument to be an
6378         objfile_per_bfd_storage.
6379         (symbol_set_names): Update.
6380
6381 2019-01-10  Tom Tromey  <tom@tromey.com>
6382
6383         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6384         init_psymbol_list.
6385         * psymtab.c (init_psymbol_list): Do nothing if already called.
6386         * psympriv.h (init_psymbol_list): Add comment.
6387         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6388         init_psymbol_list.
6389         * dbxread.c (dbx_symfile_read): Unconditionally call
6390         init_psymbol_list.
6391
6392 2019-01-10  Tom Tromey  <tom@tromey.com>
6393
6394         * xcoffread.c (scan_xcoff_symtab): Update.
6395         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6396         "where".
6397         * mdebugread.c (parse_partial_symbols)
6398         (handle_psymbol_enumerators): Update.
6399         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6400         * dbxread.c (read_dbx_symtab): Update.
6401         * psympriv.h (psymbol_placement): New enum.
6402         (add_psymbol_to_list): Update.
6403
6404 2019-01-10  Tom Tromey  <tom@tromey.com>
6405
6406         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6407         static_psymbols parameters.
6408         (scan_xcoff_symtab): Update.
6409         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6410         static_psymbols parameters.
6411         * psympriv.h (start_psymtab_common): Update.
6412         * mdebugread.c (parse_partial_symbols): Update.
6413         * dwarf2read.c (create_partial_symtab): Update.
6414         * dbxread.c (read_dbx_symtab): Update.
6415         (start_psymtab): Remove global_psymbols and static_psymbols
6416         parameters.
6417
6418 2019-01-10  Tom Tromey  <tom@tromey.com>
6419
6420         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6421         * psymtab.c (allocate_psymtab): Add comment.
6422         * psympriv.h (allocate_psymtab): Add comment.
6423         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6424         initializations.
6425         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6426
6427 2019-01-10  Tom Tromey  <tom@tromey.com>
6428
6429         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6430         Don't declare.
6431         * mipsread.c: Include mdebugread.h.
6432         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6433         Declare.
6434         * elfread.c: Include mdebugread.h.
6435
6436 2019-01-09  Tom Tromey  <tom@tromey.com>
6437
6438         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6439         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6440         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6441         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6442         (psym_lookup_symbol, psym_find_last_source_symtab)
6443         (psym_forget_cached_source_info, psym_print_stats)
6444         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6445         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6446         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6447         (psym_find_compunit_symtab_by_address)
6448         (maintenance_print_psymbols, maintenance_info_psymtabs)
6449         (maintenance_check_psymtabs): Use ranged for.
6450         * psymtab.h (class objfile_psymtabs): New.
6451         (require_partial_symbols): Return objfile_psymtabs.
6452         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6453
6454 2019-01-09  Tom Tromey  <tom@tromey.com>
6455
6456         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6457         (find_pc_mapped_section, list_overlays_command)
6458         (map_overlay_command, unmap_overlay_command)
6459         (simple_overlay_update): Use all_objfiles.
6460         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6461         * printcmd.c (info_symbol_command): Use all_objfiles.
6462         * objfiles.h (ALL_OBJSECTIONS): Remove.
6463         * maint.c (maintenance_translate_address): Use all_objfiles.
6464         * gcore.c (gcore_create_callback): Use all_objfiles.
6465         (objfile_find_memory_regions): Likewise.
6466
6467 2019-01-09  Tom Tromey  <tom@tromey.com>
6468
6469         * symtab.c (find_line_symtab, info_sources_command)
6470         (make_source_files_completion_list): Use objfile_compunits.
6471         * source.c (select_source_symtab): Use objfile_compunits.
6472         * objfiles.h (struct objfile): Update comment.
6473         (ALL_OBJFILES): Remove.
6474         (ALL_FILETABS): Remove.
6475         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6476         objfile_compunits.
6477
6478 2019-01-09  Tom Tromey  <tom@tromey.com>
6479
6480         * symmisc.c (print_objfile_statistics, dump_objfile)
6481         (maintenance_print_symbols): Use compunit_filetabs.
6482         * source.c (forget_cached_source_info_for_objfile): Use
6483         compunit_filetabs.
6484         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6485         (ALL_FILETABS): Use compunit_filetabs.
6486         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6487         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6488
6489 2019-01-09  Tom Tromey  <tom@tromey.com>
6490
6491         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6492         (compunit_filetabs): New.
6493         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6494         compunit_filetabs.
6495         (info_sources_command, make_source_files_completion_list): Remove
6496         declaration.
6497         * symmisc.c (print_objfile_statistics, dump_objfile)
6498         (maintenance_print_symbols): Remove declaration.
6499         (maintenance_info_symtabs): Use compunit_filetabs.
6500         (maintenance_info_line_tables): Likewise.
6501         * source.c (select_source_symtab): Change local variable name.
6502         (forget_cached_source_info_for_objfile): Remove declaration.
6503         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6504         * objfiles.c (objfile_relocate1): Remove declaration.
6505         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6506         declaration.
6507         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6508         * coffread.c (coff_symtab_read): Remove declaration.
6509         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6510         compunit_filetabs.
6511
6512 2019-01-09  Tom Tromey  <tom@tromey.com>
6513
6514         * symtab.c (lookup_objfile_from_block)
6515         (find_pc_sect_compunit_symtab, search_symbols)
6516         (default_collect_symbol_completion_matches_break_on): Use
6517         objfile_compunits.
6518         * objfiles.h (ALL_COMPUNITS): Remove.
6519         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6520         * cp-support.c (add_symbol_overload_list_qualified): Use
6521         objfile_compunits.
6522         * ada-lang.c (ada_collect_symbol_completion_matches)
6523         (ada_add_global_exceptions): Use objfile_compunits.
6524
6525 2019-01-09  Tom Tromey  <tom@tromey.com>
6526
6527         * source.c (select_source_symtab)
6528         (forget_cached_source_info_for_objfile): Remove declaration.
6529         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6530         declaration.
6531         * maint.c (count_symtabs_and_blocks): Remove declaration.
6532         * cp-support.c (add_symbol_overload_list_qualified): Remove
6533         declaration.
6534         * coffread.c (coff_symtab_read): Remove declaration.
6535         * symtab.c (lookup_symbol_in_objfile_symtabs)
6536         (basic_lookup_transparent_type_1): Use objfile_compunits.
6537         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6538         (info_sources_command, search_symbols)
6539         (default_collect_symbol_completion_matches_break_on)
6540         (make_source_files_completion_list): Remove declaration.
6541         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6542         (ada_collect_symbol_completion_matches)
6543         (ada_add_global_exceptions): Remove declaration.
6544         * linespec.c (iterate_over_all_matching_symtabs): Use
6545         objfile_compunits.
6546         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6547         (class objfile_compunits): New.
6548         (ALL_COMPUNITS): Use objfile_compunits.
6549         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6550         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6551         objfile_compunits.
6552         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6553
6554 2019-01-09  Tom Tromey  <tom@tromey.com>
6555
6556         * symtab.c (search_symbols)
6557         (default_collect_symbol_completion_matches_break_on): Use
6558         objfile_msymbols.
6559         * ada-lang.c (ada_lookup_simple_minsym)
6560         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6561         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6562         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6563         objfile_msymbols.
6564         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6565         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6566         * objc-lang.c (find_methods): Use objfile_msymbols.
6567         (info_selectors_command, info_classes_command): Likewise.
6568         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6569         * objfiles.h (class objfile_msymbols): New.
6570         (ALL_OBJFILE_MSYMBOLS): Remove.
6571         (ALL_MSYMBOLS): Remove.
6572
6573 2019-01-09  Tom Tromey  <tom@tromey.com>
6574
6575         * common/next-iterator.h (next_adapter): Add Iterator template
6576         parameter.
6577         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6578         (class all_objfiles_safe): New.
6579         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6580         * objfiles.c (put_objfile_before): Update comment.
6581         (add_separate_debug_objfile): Likewise.
6582         (free_all_objfiles): Use all_objfiles_safe.
6583         (objfile_purge_solibs): Likewise.
6584
6585 2019-01-09  Tom Tromey  <tom@tromey.com>
6586
6587         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6588         (expand_symtab_containing_pc, lookup_static_symbol)
6589         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6590         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6591         all_objfiles.
6592         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6593         * breakpoint.c (create_overlay_event_breakpoint)
6594         (create_longjmp_master_breakpoint)
6595         (create_std_terminate_master_breakpoint)
6596         (create_exception_master_breakpoint): Use all_objfiles.
6597         * linux-thread-db.c (try_thread_db_load_from_pdir)
6598         (has_libpthread): Use all_objfiles.
6599         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6600         * linespec.c (iterate_over_all_matching_symtabs)
6601         (search_minsyms_for_name): Use all_objfiles.
6602         * maint.c (maintenance_info_sections): Use all_objfiles.
6603         * main.c (captured_main_1): Use all_objfiles.
6604         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6605         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6606         * guile/scm-pretty-print.c
6607         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6608         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6609         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6610         (maintenance_print_msymbols): Use all_objfiles.
6611         * source.c (select_source_symtab): Use all_objfiles.
6612         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6613         * symfile.c (remove_symbol_file_command)
6614         (expand_symtabs_matching, map_symbol_filenames): Use
6615         all_objfiles.
6616         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6617         all_objfiles.
6618         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6619         * objc-lang.c (find_methods): Use all_objfiles.
6620         * objfiles.c (have_partial_symbols, have_full_symbols)
6621         (have_minimal_symbols, qsort_cmp)
6622         (default_iterate_over_objfiles_in_search_order): Use
6623         all_objfiles.
6624         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6625         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6626         (maintenance_check_psymtabs): Use all_objfiles.
6627         (ALL_PSYMTABS): Remove.
6628         * compile/compile-object-run.c (do_module_cleanup): Use
6629         all_objfiles.
6630         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6631         * cp-support.c (add_symbol_overload_list_qualified): Use
6632         all_objfiles.
6633         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6634         Use all_objfiles.
6635         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6636         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6637         all_objfiles.
6638         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6639         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6640         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6641         Uses all_objfiles.
6642         * solib.c (solib_read_symbols): Use all_objfiles
6643
6644 2019-01-09  Tom Tromey  <tom@tromey.com>
6645
6646         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6647         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6648         all_objfiles.
6649         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6650         * symmisc.c (print_symbol_bcache_statistics)
6651         (print_objfile_statistics, maintenance_print_objfiles)
6652         (maintenance_info_symtabs, maintenance_check_symtabs)
6653         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6654         all_objfiles.
6655         * source.c (forget_cached_source_info): Use all_objfiles.
6656         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6657         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6658         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6659         * objfiles.c (update_section_map): Use all_objfiles.
6660         (shared_objfile_contains_address_p): Likewise.
6661         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6662         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6663
6664 2019-01-09  Tom Tromey  <tom@tromey.com>
6665
6666         * common/next-iterator.h: New file.
6667         * objfiles.h (class all_objfiles): New.
6668         (struct objfile_iterator): New.
6669
6670 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6671
6672         * NEWS: Move the description of the changed "frame", "select-frame",
6673          and "info frame" commands to the Changed commands section.
6674
6675 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6676
6677         * gdbtypes.c (check_stub_method_group): Remove handling of old
6678         mangling schemes.
6679         * linespec.c (find_methods): Likewise.
6680         * stabsread.c (read_member_functions): Likewise.
6681         * valops.c (search_struct_method): Likewise.
6682         (value_struct_elt_for_reference): Likewise.
6683         * NEWS: Mention this change.
6684
6685 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6686
6687         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6688         print_source_lines.
6689         * source.c (print_source_lines_base): Update line number check.
6690         (print_source_lines): New function.
6691         (source_lines_range::source_lines_range): New function.
6692         * source.h (class source_lines_range): New class.
6693         (print_source_lines): New declaration.
6694
6695 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6696
6697         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6698
6699 2019-01-08  Tom Tromey  <tom@tromey.com>
6700             Simon Marchi  <simon.marchi@ericsson.com>
6701
6702         PR gdb/24060
6703         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6704         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6705         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6706         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6707         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6708         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6709
6710 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6711
6712         * source.c (select_source_symtab): Move header comment to
6713         declaration in source.h.
6714         (forget_cached_source_info_for_objfile): Likewise.
6715         (forget_cached_source_info): Likewise.
6716         (identify_source_line): Likewise.
6717         * source.h (identify_source_line): Move declaration from symtab.h
6718         and add comment from source.c
6719         (print_source_lines): Likewise.
6720         (forget_cached_source_info_for_objfile): Likewise.
6721         (forget_cached_source_info): Likewise.
6722         (select_source_symtab): Likewise.
6723         (enum print_source_lines_flag): Move definition from symtab.h.
6724         * symtab.h (identify_source_line): Move declaration to source.h.
6725         (print_source_lines): Likewise.
6726         (forget_cached_source_info_for_objfile): Likewise.
6727         (forget_cached_source_info): Likewise.
6728         (select_source_symtab): Likewise.
6729         (enum print_source_lines_flag): Move definition to source.h.
6730         * tui/tui-hooks.c: Add 'source.h' include.
6731
6732 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6733
6734         * source.c (print_source_lines_base): Handle requests to print
6735         reverse line number sequences, and guard against empty lines
6736         string.
6737
6738 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * source.c (print_source_lines_base): Fix skip of '\r' if next
6741         character is '\n'.
6742
6743 2019-01-06  Tom Tromey  <tom@tromey.com>
6744
6745         * c-exp.y (struct c_parse_state) <macro_original_text,
6746         expansion_obstack>: New member.
6747         (macro_original_text, expansion_obstack): Remove globals.
6748         (scan_macro_expansion, scanning_macro_expansion)
6749         (finished_macro_expansion): Update.
6750         (scan_macro_cleanup): Remove.
6751         (yylex, c_parse): Update.
6752
6753 2019-01-06  Tom Tromey  <tom@tromey.com>
6754
6755         * c-exp.y (struct c_parse_state) <strings>: New member.
6756         (operator_stoken): Update.
6757
6758 2019-01-06  Tom Tromey  <tom@tromey.com>
6759
6760         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6761         (union type_stack_elt) <typelist_val>: Now a pointer to
6762         std::vector.
6763         (type_stack_cleanup): Don't declare.
6764         (push_typelist): Update.
6765         * parse.c (pop_typelist): Return a std::vector.
6766         (push_typelist): Take a std::vector.
6767         (follow_types): Update.  Do not free args.
6768         (type_stack_cleanup): Remove.
6769         * c-exp.y (struct c_parse_state): New.
6770         (cpstate): New global.
6771         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6772         (nonempty_typelist): Update.
6773         (func_mod): Create a new vector.
6774         (c_parse): Create a c_parse_state.
6775         (check_parameter_typelist): Do not delete params.
6776         (function_method): Update.  Do not delete type_list.
6777
6778 2019-01-06  Tom Tromey  <tom@tromey.com>
6779
6780         PR gdb/28155:
6781         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6782         check_typedef.
6783         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6784         (print_return_value): Likewise.
6785
6786 2019-01-05  Tom Tromey  <tom@tromey.com>
6787
6788         * contrib/cleanup_check.py: Remove.
6789         * contrib/gcc-with-excheck: Remove.
6790         * contrib/exsummary.py: Remove.
6791         * contrib/excheck.py: Remove.
6792
6793 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6794
6795         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6796         NULL. Initialize tpprev to NULL instead of assigning it
6797         to NULL on the next statement.
6798         * windows-nat.c (windows_delete_thread): Remove check for
6799         main_thread_id before printing thread exit notifications.
6800         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6801         Remove thread ID check against main_thread_id.
6802         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6803         windows_delete_thread.
6804         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6805
6806 2019-01-04  Tom Tromey  <tom@tromey.com>
6807
6808         * compile/compile.c (_initialize_compile): Use upper case for
6809         metasyntactic variables.
6810         * symmisc.c (_initialize_symmisc): Use upper case for
6811         metasyntactic variables.
6812         * psymtab.c (_initialize_psymtab): Use upper case for
6813         metasyntactic variables.
6814         * demangle.c (demangle_command): Use upper case for metasyntactic
6815         variables.
6816         (_initialize_demangler): Likewise.
6817         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6818         variables.
6819
6820 2019-01-03  Tom Tromey  <tom@tromey.com>
6821
6822         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6823
6824 2019-01-03  Tom Tromey  <tom@tromey.com>
6825
6826         * python/py-symtab.c (salpy_str): Update.
6827         (struct salpy_sal_object) <symtab>: Now a PyObject.
6828         (salpy_dealloc): Update.
6829         (del_objfile_sal): Use gdbpy_ref.
6830
6831 2019-01-03  Tom Tromey  <tom@tromey.com>
6832
6833         * python/py-type.c (convert_field): Use new_reference.  Return
6834         gdbpy_ref.
6835         (make_fielditem): Return gdbpy_ref.
6836         (typy_fields): Update.
6837         (typy_getitem): Update.
6838         (field_name): Return gdbpy_ref.  Use new_reference.
6839         (typy_iterator_iternext): Update.
6840
6841 2019-01-03  Tom Tromey  <tom@tromey.com>
6842
6843         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6844
6845 2019-01-03  Tom Tromey  <tom@tromey.com>
6846
6847         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6848         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6849         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6850         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6851         (pspy_set_type_printers): Likewise.
6852         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6853         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6854         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6855         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6856         (objfpy_set_type_printers): Likewise.
6857
6858 2019-01-03  Tom Tromey  <tom@tromey.com>
6859
6860         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6861         (gdbpy_print_stack): Use gdbpy_err_fetch.
6862         * python/python-internal.h (class gdbpy_err_fetch): New class.
6863         (class gdbpy_enter) <m_error_type, m_error_value,
6864         m_error_traceback>: Remove.
6865         <m_error>: New member.
6866         (gdbpy_exception_to_string): Don't declare.
6867         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6868         * python/py-value.c (convert_value_from_python): Use
6869         gdbpy_err_fetch.
6870         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6871         gdbpy_exception_to_string.
6872         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6873         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6874         gdbpy_err_fetch.
6875
6876 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6877
6878         * linux-nat.c (delete_lwp_cleanup): Delete.
6879         (struct lwp_deleter): New struct.
6880         (lwp_info_up): New typedef.
6881         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6882         lwp_info_up.
6883
6884 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6885
6886         * linux-fork.c (class scoped_switch_fork_info): New class.
6887         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6888
6889 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6890
6891         * valops.c (find_overload_match): Remove use of null_cleanup, and
6892         calls to do_cleanups.
6893
6894 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * compile/compile-cplus-types.c
6897         (compile_cplus_instance::decl_name): Handle changes to
6898         cp_func_name.
6899         * cp-support.c (cp_func_name): Update header comment, update
6900         return type.
6901         * cp-support.h (cp_func_name): Update return type in declaration.
6902         * valops.c (find_overload_match): Move temp_func local to top
6903         level of function and change its type.  Use temp_func to hold and
6904         delete temporary string obtained from cp_func_name.
6905
6906 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6907
6908         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6909         gdb::char_vector, remove cleanup, and update uses of `msg`.
6910
6911 2019-01-03  Jim Wilson  <jimw@sifive.com>
6912
6913         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6914
6915 2019-01-02  Tom Tromey  <tom@tromey.com>
6916
6917         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6918         (tdesc_parse_xml): Remove cleanups.
6919         * target-descriptions.h (make_cleanup_free_target_description):
6920         Don't declare.
6921         (target_desc_deleter): New struct.
6922         (target_desc_up): New typedef.
6923         * target-descriptions.c (target_desc_deleter::operator()): Rename
6924         from free_target_description.
6925         (make_cleanup_free_target_description): Remove.
6926
6927 2019-01-02  Tom Tromey  <tom@tromey.com>
6928
6929         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6930         constructor, destructor.
6931         (linespec_parser): Remove typedef.
6932         (~linespec_parser): Rename from linespec_parser_delete.
6933         (linespec_lex_to_end, linespec_complete_label)
6934         (linespec_complete): Update.
6935         (decode_line_full): Remove cleanups.
6936         (decode_line_1): Update.
6937
6938 2019-01-02  Tom Tromey  <tom@tromey.com>
6939
6940         * python/python-internal.h (inferior_to_inferior_object): Change
6941         return type.
6942         * python/py-exitedevent.c (create_exited_event_object): Update.
6943         * python/py-inferior.c (inferior_to_inferior_object): Return
6944         gdbpy_ref.
6945         (python_new_inferior, python_inferior_deleted)
6946         (thread_to_thread_object, delete_thread_object)
6947         (build_inferior_list, gdbpy_selected_inferior): Update.
6948         * python/py-infthread.c (create_thread_object): Update.  Also fail
6949         if inferior_to_inferior_object fails.
6950
6951 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6952
6953         * inferior.h (class inferior) <displaced_step_state>: New field.
6954         * infrun.h (struct displaced_step_state): Move here from
6955         infrun.c.  Initialize fields, add constructor.
6956         <inf>: Remove field.
6957         <reset>: New method.
6958         * infrun.c (struct displaced_step_inferior_state): Move to
6959         infrun.h.
6960         (displaced_step_inferior_states): Remove.
6961         (get_displaced_stepping_state): Adust.
6962         (displaced_step_in_progress_any_inferior): Adjust.
6963         (displaced_step_in_progress_thread): Adjust.
6964         (displaced_step_in_progress): Adjust.
6965         (add_displaced_stepping_state): Remove.
6966         (get_displaced_step_closure_by_addr): Adjust.
6967         (remove_displaced_stepping_state): Remove.
6968         (infrun_inferior_exit): Call displaced_step_state.reset.
6969         (use_displaced_stepping): Don't check for NULL.
6970         (displaced_step_prepare_throw): Call
6971         get_displaced_stepping_state.
6972         (displaced_step_fixup): Don't check for NULL.
6973         (prepare_for_detach): Don't check for NULL.
6974
6975 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6976
6977         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6978          in case of call that did not complete.
6979
6980 2019-01-02  Andrey Utkin  <autkin@undo.io>
6981
6982         * symfile.c (find_separate_debug_file): Fix search of debug files for
6983         remote debuggee.
6984
6985 2019-01-02  Tom Tromey  <tom@tromey.com>
6986
6987         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6988         indentation.
6989         * python/py-frame.c (frapy_older): Remove cast.
6990         (frapy_newer): Likewise.
6991         * python/py-breakpoint.c (local_setattro): Remove cast.
6992         * python/py-arch.c (archpy_name): Remove local variable.
6993         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6994
6995 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6996
6997         * unittests/basic_string_view/element_access/char/empty.cc:
6998         Fix year range in copyright header.
6999
7000 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7001
7002         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7003         Delete.
7004         <operator==>: Update with for removed field.
7005         <hash>: Likewise.
7006         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7007         <isa_features>: ...this.
7008         <abi_features>: New field.
7009         (riscv_isa_flen): Update comment.
7010         (riscv_abi_xlen): New declaration.
7011         (riscv_abi_flen): New declaration.
7012         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7013         isa_features.
7014         (riscv_abi_xlen): New function.
7015         (riscv_isa_flen): Update to get answer from isa_features.
7016         (riscv_abi_flen): New function.
7017         (riscv_has_fp_abi): Update to get answer from abi_features.
7018         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7019         xlen and flen.
7020         (riscv_call_info) <xlen, flen>: Update comment.
7021         (riscv_call_arg_struct): Remove invalid assertions
7022         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7023         is removed.
7024         (riscv_gdbarch_init): Gather isa features and abi features
7025         separately, ensure both match on the gdbarch when reusing an old
7026         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7027         a target with 64-bit float hardware.
7028
7029 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7030
7031         * source.c (search_command_helper): Stop reverse search
7032         when line 1 has been searched.
7033
7034 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7035
7036         * record-full.c (record_full_base_target::close): Rewrite
7037         record_full_core_buf_list free logic.
7038
7039 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7040
7041         * break-catch-syscall.c (print_one_catch_syscall): xfree
7042         the last text.
7043
7044 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7045
7046         * top.c (print_gdb_version): Update Copyright year in version
7047         message.
7048
7049 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7050
7051         Update copyright year range in all GDB files.
7052
7053 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7054
7055         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7056
7057 For older changes see ChangeLog-2018.
7058 \f
7059 Local Variables:
7060 mode: change-log
7061 left-margin: 8
7062 fill-column: 74
7063 version-control: never
7064 coding: utf-8
7065 End:
7066