gdb/ChangeLog

   1 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
   4         (arm_mapping_symbol_s): Remove.
   5         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
   6         (arm_mapping_symbol_vec): New typedef.
   7         (struct arm_per_objfile): Add constructor.
   8         <section_maps>: Change type to
   9         std::unique_ptr<arm_mapping_symbol_vec[]>.
  10         (arm_compare_mapping_symbols): Remove.
  11         (arm_find_mapping_symbol): Adjust to section_maps type change.
  12         (arm_objfile_data_free): Call delete on arm_per_objfile.
  13         (arm_record_special_symbol): Adjust to section_maps type change.
  14         Allocate arm_per_objfile with new.
  15
  16 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  17
  18         * cli/cli-cmds.c (alias_command): Compare the alias prefix
  19         with the command prefix.
  20
  21 2019-06-25  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
  24         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
  25
  26 2019-06-25  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
  29         type.
  30         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
  31         protected.
  32
  33 2019-06-25  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-winsource.c
  36         (tui_source_window_base::set_is_exec_point_at): Add check against
  37         LOA_ADDRESS.
  38
  39 2019-06-25  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-source.c (tui_set_source_content): Don't check before
  42         xfree.
  43         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  44
  45 2019-06-25  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-winsource.h (tui_update_source_window_as_is)
  48         (tui_alloc_source_buffer, tui_line_is_displayed)
  49         (tui_addr_is_displayed): Change type of win_info.
  50         * tui/tui-winsource.c (tui_update_source_window_as_is)
  51         (tui_clear_source_content, tui_show_source_line)
  52         (tui_show_source_content, tui_source_window_base::refill)
  53         (tui_source_window_base::set_is_exec_point_at)
  54         (tui_source_window_base::set_is_exec_point_at)
  55         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  56         (tui_alloc_source_buffer, tui_line_is_displayed)
  57         (tui_addr_is_displayed): Change type of win_info.  Update.
  58         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  59         (tui_source_window_base::do_make_visible_with_new_height):
  60         Update.
  61         * tui/tui-source.c (tui_set_source_content)
  62         (tui_set_source_content_nil)
  63         (tui_source_window::do_scroll_vertical): Update.
  64         * tui/tui-layout.c (show_layout): Update.
  65         * tui/tui-disasm.c (tui_set_disassem_content)
  66         (tui_disasm_window::do_scroll_vertical): Update.
  67         * tui/tui-data.h (tui_win_content): Remove.
  68         (struct tui_gen_win_info) <content, content_size>: Remove.
  69         (struct tui_source_element): Add initializers and destructor.
  70         (union tui_which_element, struct tui_win_element): Remove.
  71         (struct tui_source_window_base) <content>: New field.
  72         (struct tui_data_window): Remove destructor.
  73         (tui_alloc_content, tui_free_win_content)
  74         (tui_free_all_source_wins_content): Don't declare.
  75         * tui/tui-data.c (tui_initialize_static_data): Update.
  76         (init_content_element, tui_alloc_content): Remove.
  77         (~tui_gen_win_info): Update.
  78         (~tui_data_window, tui_free_all_source_wins_content)
  79         (tui_free_win_content, free_content, free_content_elements):
  80         Remove.
  81
  82 2019-06-25  Tom Tromey  <tom@tromey.com>
  83
  84         * tui/tui-winsource.h (tui_clear_source_content)
  85         (tui_erase_source_content, tui_show_source_content): Change type
  86         of win_info.
  87         * tui/tui-winsource.c (tui_clear_source_content)
  88         (tui_erase_source_content, tui_show_source_content): Change type
  89         of win_info.
  90         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  91         * tui/tui-source.h (tui_set_source_content_nil): Change type of
  92         win_info.
  93         * tui/tui-source.c (tui_set_source_content_nil): Change type of
  94         win_info.
  95         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
  96
  97 2019-06-25  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-winsource.c (tui_clear_source_content)
 100         (tui_source_window_base::set_is_exec_point_at): Update.
 101         * tui/tui-source.c (tui_set_source_content_nil): Update.
 102         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 103         a bool.
 104         * tui/tui-data.c (init_content_element): Update.
 105
 106 2019-06-25  Tom Tromey  <tom@tromey.com>
 107
 108         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 109         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 110         * tui/tui-layout.c (init_and_make_win): Update.
 111         * tui/tui.h (enum tui_win_type): Update.
 112         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 113         tui_win_is_auxillary.
 114         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 115         tui_win_is_auxillary.
 116
 117 2019-06-25  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 120         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 121         (tui_delete_data_content_windows, tui_display_all_data)
 122         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 123         Update.
 124         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 125         * tui/tui-regs.c (tui_last_regs_line_no)
 126         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 127         (tui_show_registers): Update.
 128         (tui_show_register_group): Return void.  Update.
 129         (tui_display_registers_from, tui_display_reg_element_at_line)
 130         (tui_display_registers_from_line, tui_check_register_values):
 131         Update.
 132         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 133         member.
 134         (struct tui_data_window) <regs_content>: Now a std::vector.
 135         <regs_content_count>: Remove.
 136         (tui_add_content_elements, tui_free_data_content): Don't declare.
 137         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 138         (init_content_element): Remove DATA_WIN case.  Add assert.
 139         (tui_add_content_elements): Remove.
 140         (tui_data_window): Update.
 141         (tui_free_data_content): Remove.
 142         (free_content_elements): Remove DATA_WIN case.
 143
 144 2019-06-25  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-data.c (tui_data_item_window): Update.
 147         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 148         * tui/tui-windata.c (tui_display_all_data)
 149         (tui_display_data_from_line): Update.
 150         (tui_check_data_values): Remove.
 151         * tui/tui-regs.c (tui_show_register_group)
 152         (tui_display_reg_element_at_line): Update.
 153         * tui/tui-hooks.c (tui_register_changed)
 154         (tui_refresh_frame_and_register_information): Call
 155         tui_check_register_values.
 156         * tui/tui-data.h (struct tui_data_window) <data_content,
 157         data_content_count, data_type>: Remove.
 158         (enum tui_data_type): Remove.
 159
 160         * tui/tui-data.c (tui_data_window::clear_detail)
 161         (~tui_data_window): Update.
 162
 163 2019-06-25  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 166         declare.
 167         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 168         Rename from tui_first_data_item_displayed.  Update.
 169         (tui_data_window::refresh_all)
 170         (tui_data_window::do_scroll_vertical): Update.
 171         * tui/tui-data.h (struct tui_data_window)
 172         <first_data_item_displayed>: Declare new method.
 173
 174 2019-06-25  Tom Tromey  <tom@tromey.com>
 175
 176         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 177         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 178         contents...
 179         (tui_initialize_static_data): ...here.
 180
 181 2019-06-25  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 184         (tui_display_registers_from, tui_check_register_values): Update.
 185         (tui_display_register): Remove win_info parameter; update.
 186         (tui_get_register): Change type of parameters.
 187         * tui/tui-data.h (struct tui_data_element): Remove.
 188         (union tui_which_element) <data>: Remove.
 189         <data_window>: Change type.
 190         (struct tui_data_item_window): New.
 191         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 192         case.  Add assert.
 193         (~tui_data_item_window): New destructor.
 194         (free_content_elements): Remove DATA_ITEM_WIN case.
 195
 196 2019-06-25  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 199         Remove.
 200
 201 2019-06-25  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-data.h (struct tui_command_element): Remove.
 204         (union tui_which_element) <command>: Remove.
 205         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 206         assert.
 207         (free_content_elements): Remove CMD_WIN case.
 208
 209 2019-06-25  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-layout.c (tui_set_layout): Update.
 212         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 213         * tui/tui-data.c (layout_def): Update.
 214
 215 2019-06-25  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 218         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 219         (tui_source_window_base::set_new_height): Update.
 220         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 221         Update.
 222         (tui_set_locator_fullname, tui_set_locator_info)
 223         (tui_show_frame_info): Update.
 224         * tui/tui-source.c (tui_set_source_content)
 225         (tui_source_is_displayed): Update.
 226         * tui/tui-layout.c (show_source_disasm_command, show_data)
 227         (show_source_or_disasm_and_command): Update.
 228         * tui/tui-disasm.c (tui_set_disassem_content)
 229         (tui_get_begin_asm_address): Update.
 230         * tui/tui-data.h (struct tui_locator_element): Remove.
 231         (union tui_which_element) <locator>: Remove.
 232         (struct tui_locator_window): New.
 233         (tui_locator_win_info_ptr): Change return type.
 234         * tui/tui-data.c (_locator): Change type.
 235         (tui_locator_win_info_ptr): Change return type.
 236         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 237         (tui_alloc_content): Add assert.
 238
 239 2019-06-25  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-winsource.c
 242         (tui_exec_info_window::maybe_allocate_content): New method.
 243         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 244         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 245         (make_source_or_disasm_window): Add cast.
 246         * tui/tui-data.h (union tui_which_element) <simple_string>:
 247         Remove.
 248         (struct tui_source_info): New.
 249         (struct tui_source_window_base) <execution_info>: Change type.
 250         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 251         case, and add assert.
 252         (tui_alloc_content): Add assert.
 253
 254 2019-06-25  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 257         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 258         * tui/tui-data.c (tui_alloc_win_info): Remove.
 259
 260 2019-06-25  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 263         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 264         can_highlight.
 265
 266 2019-06-25  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 269         make_visible_with_new_height method.
 270         (tui_win_info::make_visible_with_new_height): New method.
 271         (tui_source_window_base::do_make_visible_with_new_height)
 272         (tui_data_window::do_make_visible_with_new_height)
 273         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 274         (make_visible_with_new_height): Remove.
 275         (tui_resize_all, tui_adjust_win_heights): Use
 276         make_visible_with_new_height method.
 277         * tui/tui-data.h (struct tui_win_info)
 278         <do_make_visible_with_new_height, make_visible_with_new_height>:
 279         New methods.
 280         (struct tui_source_window_base, struct tui_data_window)
 281         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 282         methods.
 283
 284 2019-06-25  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 287         method.
 288         (update_tab_width): Call update_tab_width method.
 289         * tui/tui-data.h (struct tui_win_info)
 290         (struct tui_source_window_base) <update_tab_width>: New methods.
 291
 292 2019-06-25  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 295         parameter.
 296         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 297         parameter.
 298         (tui_gen_win_info::make_visible): Update.
 299         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 300         parameter.
 301         * tui/tui-data.h (enum tui_box): New enum.
 302         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 303
 304 2019-06-25  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 307         init_and_make_win for EXEC_INFO_WIN.
 308         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 309         longer inline.
 310         (struct tui_win_info) <~tui_win_info>: Inline.
 311         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 312         Don't declare.
 313         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 314         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 315         Remove.
 316         (tui_initialize_static_data): Update.
 317         (~tui_gen_win_info): Handle more cleanup here.
 318         (~tui_source_window_base): Delete "execution_info".
 319         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 320
 321 2019-06-25  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-layout.c (make_command_window): Don't set
 324         can_highlight.
 325         (show_source_disasm_command): Call the reset method.
 326         (show_data): Don't set can_highlight.  Call the reset method.
 327         (tui_gen_win_info::reset): Rename from init_gen_win_info
 328         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 329         (show_source_or_disasm_and_command): Call the reset method.
 330         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 331         (struct tui_cmd_window): Set can_highlight.
 332
 333 2019-06-25  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 336         from make_visible.
 337         (tui_make_visible, tui_make_invisible): Rewrite.
 338         (tui_win_info::make_visible): Remove.
 339         (tui_source_window_base::make_visible): Update.
 340         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 341         method.  Moved from...
 342         (struct tui_win_info) <make_visible>: ...here.
 343
 344 2019-06-25  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-winsource.c
 347         (tui_source_window_base::do_scroll_horizontal): Remove direction
 348         parameter.
 349         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 350         direction parameter.
 351         * tui/tui-win.c (tui_win_info::forward_scroll)
 352         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 353         (tui_win_info::right_scroll): Update.
 354         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 355         direction parameter.
 356         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 357         direction parameter.
 358         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 359         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 360         Remove direction parameter.
 361         (struct tui_source_window_base, struct tui_source_window)
 362         (struct tui_disasm_window, struct tui_data_window)
 363         (struct tui_cmd_window): Update.
 364
 365 2019-06-25  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-winsource.h (tui_set_exec_info_content)
 368         (tui_show_exec_info_content, tui_erase_exec_info_content)
 369         (tui_clear_exec_info_content, tui_update_exec_info): Change
 370         argument to tui_source_window_base.
 371         * tui/tui-winsource.c (tui_set_exec_info_content)
 372         (tui_show_exec_info_content, tui_erase_exec_info_content)
 373         (tui_clear_exec_info_content, tui_update_exec_info): Change
 374         argument to tui_source_window_base.
 375
 376 2019-06-25  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 379         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 380
 381 2019-06-25  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 384         check.
 385
 386 2019-06-25  Tom Tromey  <tom@tromey.com>
 387
 388         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 389         type to void.
 390         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 391         type to void.
 392         * tui/tui-source.c (tui_set_source_content): Update.
 393         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 394
 395 2019-06-25  Tom Tromey  <tom@tromey.com>
 396
 397         * tui/tui-win.c (window_name_completer, tui_set_focus)
 398         (tui_all_windows_info): Use name method.
 399         * tui/tui-data.h (struct tui_gen_win_info)
 400         (struct tui_source_window, struct tui_disasm_window)
 401         (struct tui_data_window, struct tui_cmd_window) <name>: New
 402         method.
 403         (tui_win_name): Don't declare.
 404         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 405         (tui_win_name): Remove.
 406
 407 2019-06-25  Tom Tromey  <tom@tromey.com>
 408
 409         * tui/tui-winsource.h (tui_update_source_window)
 410         (tui_update_source_window_as_is): Change parameter type.
 411         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 412         to be a tui_source_window_base.
 413         (tui_update_source_window_as_is): Likewise.
 414         * tui/tui-win.c (make_visible_with_new_height): Update.
 415
 416 2019-06-25  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-winsource.c (tui_erase_source_content)
 419         (tui_show_source_content, tui_show_exec_info_content)
 420         (tui_erase_exec_info_content): Use refresh_window method.
 421         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 422         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 423         from tui_refresh_win.
 424         (tui_data_window::refresh_window): New method.
 425         (tui_win_info::refresh, tui_source_window_base::refresh)
 426         (tui_refresh_all): Use refresh_window method.
 427         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 428         method.
 429         * tui/tui-regs.c (tui_display_register): Call refresh_window
 430         method.
 431         * tui/tui-layout.c (show_source_disasm_command)
 432         (show_source_or_disasm_and_command): Call refresh_window method.
 433         * tui/tui-data.h (struct tui_gen_win_info)
 434         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 435         New method.
 436
 437 2019-06-25  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui.c (tui_rl_other_window, tui_enable)
 440         (tui_is_window_visible, tui_get_command_dimension): Update.
 441         * tui/tui-winsource.c (tui_update_source_window_as_is)
 442         (tui_clear_source_content, tui_erase_source_content)
 443         (tui_show_source_line, tui_source_window_base::refill)
 444         (tui_source_window_base::do_scroll_horizontal)
 445         (tui_source_window_base::set_is_exec_point_at)
 446         (tui_update_breakpoint_info, tui_set_exec_info_content)
 447         (tui_alloc_source_buffer, tui_line_is_displayed)
 448         (tui_addr_is_displayed): Update.
 449         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 450         (tui_check_and_display_highlight_if_needed)
 451         (tui_win_info::make_visible, tui_win_info::refresh)
 452         (tui_refresh_all): Update.
 453         * tui/tui-windata.c (tui_first_data_item_displayed)
 454         (tui_delete_data_content_windows, tui_erase_data_content)
 455         (tui_display_all_data, tui_data_window::refresh_all)
 456         (tui_check_data_values): Update.
 457         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 458         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 459         (tui_win_info::backward_scroll, tui_refresh_all_win)
 460         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 461         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 462         (tui_source_window_base::set_new_height)
 463         (tui_data_window::set_new_height)
 464         (make_invisible_and_set_new_height)
 465         (make_visible_with_new_height, new_height_ok)
 466         (parse_scrolling_args): Update.
 467         * tui/tui-stack.c (tui_show_frame_info): Update.
 468         * tui/tui-source.c (tui_set_source_content)
 469         (tui_set_source_content_nil, tui_source_is_displayed)
 470         (tui_source_window::do_scroll_vertical): Update.
 471         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 472         (tui_display_registers_from, tui_display_reg_element_at_line)
 473         (tui_check_register_values, tui_reg_command): Update.
 474         * tui/tui-layout.c (tui_default_win_height)
 475         (show_source_disasm_command, show_data, init_and_make_win)
 476         (show_source_or_disasm_and_command): Update.
 477         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 478         (tui_redisplay_readline, tui_mld_flush)
 479         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 480         (tui_getc): Update.
 481         * tui/tui-disasm.c (tui_set_disassem_content)
 482         (tui_disasm_window::do_scroll_vertical): Update.
 483         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 484         Now virtual.
 485         (struct tui_win_info): Derive from tui_gen_win_info.
 486         <~tui_win_info>: Mark as override.
 487         <generic>: Remove member.
 488         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 489         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 490         (~tui_data_window, ~tui_win_info)
 491         (tui_free_all_source_wins_content): Update.
 492         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 493
 494 2019-06-25  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-layout.c (init_and_make_win): Use new.
 497         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 498         destructor, initializers.
 499         (tui_alloc_generic_win_info): Don't declare.
 500         * tui/tui-data.c (_locator): Add argument to constructor.
 501         (source_win, disasm_win): New globals.
 502         (exec_info): Remove.
 503         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 504         Update.
 505         (tui_alloc_generic_win_info): Remove.
 506         (init_content_element): Use new.
 507         (tui_win_info::tui_win_info): Update.
 508         (free_content_elements) <case DATA_WIN>: Use delete.
 509
 510 2019-06-25  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 513         * tui/tui-windata.c (tui_first_data_item_displayed)
 514         (tui_delete_data_content_windows): Update.
 515         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 516         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 517         (tui_display_registers_from, tui_check_register_values): Update.
 518         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 519         pointer.
 520         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 521         window.
 522         (tui_free_data_content): Update.
 523         (free_content_elements) <case DATA_WIN>: Free the window.
 524
 525 2019-06-25  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 528         Update.
 529         * tui/tui-layout.c (make_command_window)
 530         (show_source_disasm_command, show_data, init_and_make_win)
 531         (show_source_or_disasm_and_command): Update.
 532         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 533         method.
 534         <can_highight, is_highlighted>: Now bool.
 535         (tui_set_win_highlight): Don't declare.
 536         * tui/tui-data.c (tui_set_win_highlight): Remove.
 537
 538 2019-06-25  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-wingeneral.c (make_visible): Remove check of window
 541         type.
 542
 543 2019-06-25  Tom Tromey  <tom@tromey.com>
 544
 545         * tui/tui-win.c (tui_win_info::max_height)
 546         (tui_cmd_window::max_height): New methods.
 547         (new_height_ok): Call max_height.
 548         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 549         <max_height>: New method.
 550
 551 2019-06-25  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-win.c (tui_source_window_base::set_new_height)
 554         (tui_data_window::set_new_height): New methods.
 555         (make_invisible_and_set_new_height): Call set_new_height method.
 556         * tui/tui-data.h (struct tui_win_info)
 557         (struct tui_source_window_base, struct tui_data_window)
 558         <set_new_height>: New method.
 559
 560 2019-06-25  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 563         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 564         tui_refresh_data_win.
 565         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 566         method.
 567         (tui_refresh_all_win): Call the refresh_all method.
 568         (tui_set_focus): Likewise.
 569         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 570         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 571         Likewise.
 572
 573 2019-06-25  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.h (tui_refill_source_window)
 576         (tui_set_is_exec_point_at): Don't declare.
 577         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 578         (tui_source_window_base::refill): Rename from
 579         tui_refill_source_window.
 580         (tui_source_window_base::do_scroll_horizontal): Update.
 581         (tui_source_window_base::set_is_exec_point_at): Rename from
 582         tui_set_is_exec_point_at.
 583         (tui_update_all_breakpoint_info): Update.
 584         * tui/tui-stack.c (tui_show_frame_info): Update.
 585         * tui/tui-layout.c (show_data): Add cast.
 586         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 587         * tui/tui-data.h (struct tui_source_window_base) <refill,
 588         set_is_exec_point_at>: New methods.
 589         (tui_source_windows, tui_add_to_source_windows): Update types.
 590         (tui_add_to_source_windows): Remove redundant declaration.
 591         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 592         (tui_source_windows): Change return type.
 593         (tui_clear_source_windows_detail): Update.
 594         (tui_add_to_source_windows): Change type of parameter.
 595         (tui_free_all_source_wins_content): Update.
 596
 597 2019-06-25  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-wingeneral.c (tui_win_info::refresh)
 600         (tui_source_window_base::refresh): New methods.
 601         (tui_refresh_all): Call the refresh method.
 602         * tui/tui-data.h (struct tui_win_info)
 603         (struct tui_source_window_base) <refresh>: New method.
 604
 605 2019-06-25  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui.h (tui_is_window_visible): Return bool.
 608         * tui/tui.c (tui_is_window_visible): Return bool.
 609         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 610         (tui_make_visible, tui_make_invisible)
 611         (tui_win_info::make_visible)
 612         (tui_source_window_base::make_visible, make_all_visible)
 613         (tui_make_all_visible, tui_make_all_invisible): Update.
 614         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 615         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 616         bool.
 617         (struct tui_win_info, struct tui_source_window_base)
 618         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 619         * tui/tui-data.c (tui_init_generic_part): Update.
 620
 621 2019-06-25  Tom Tromey  <tom@tromey.com>
 622
 623         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 624         (tui_source_window_base::make_visible): New methods.
 625         (make_all_visible): Make method call.
 626         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 627         (struct tui_source_window_base, struct tui_cmd_window): Override
 628         make_visible.
 629         (tui_win_is_source_type): Don't declare.
 630         * tui/tui-data.c (tui_win_is_source_type): Remove.
 631
 632 2019-06-25  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 635         NULL check.
 636
 637 2019-06-25  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 640         Inline constructor.  Add initializers for members.
 641         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 642         constructors; now inline in class.
 643
 644 2019-06-25  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-regs.c (tui_show_registers): Update.
 647         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 648         bool.
 649         * tui/tui-data.c (tui_data_window::clear_detail)
 650         (tui_data_window): Update.
 651
 652 2019-06-25  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-windata.c (tui_display_all_data)
 655         (tui_display_data_from_line, tui_display_data_from)
 656         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 657         Update.
 658         * tui/tui-regs.c (tui_last_regs_line_no)
 659         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 660         (tui_show_registers, tui_show_register_group)
 661         (tui_display_registers_from, tui_display_reg_element_at_line)
 662         (tui_display_registers_from_line, tui_check_register_values)
 663         (tui_reg_next, tui_reg_prev): Update.
 664         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 665         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 666         tui_data_window.
 667         (struct tui_win_info) <detail>: Remove.  Add new fields from
 668         tui_data_info.
 669         (TUI_DATA_WIN): Add cast.
 670         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 671         (~tui_data_window): Simplify.
 672
 673 2019-06-25  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-layout.c (show_source_disasm_command)
 676         (show_source_or_disasm_and_command): Update.
 677         * tui/tui-io.c (update_cmdwin_start_line)
 678         (tui_redisplay_readline): Update.
 679         * tui/tui-data.h (struct tui_command_info): Remove.
 680         (struct tui_win_info) <detail>: Remove command_info member.
 681         (struct tui_data_window) <start_line>: New member, from
 682         tui_command_info.
 683         (TUI_CMD_WIN): Add casts.
 684
 685 2019-06-25  Tom Tromey  <tom@tromey.com>
 686
 687         * tui/tui-winsource.c (tui_update_source_window)
 688         (tui_refill_source_window)
 689         (tui_source_window_base::do_scroll_horizontal)
 690         (tui_update_breakpoint_info, tui_set_exec_info_content)
 691         (tui_show_exec_info_content, tui_erase_exec_info_content)
 692         (tui_clear_exec_info_content): Update.
 693         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 694         Update.
 695         * tui/tui-win.c (make_invisible_and_set_new_height)
 696         (make_visible_with_new_height): Update.
 697         * tui/tui-source.c (tui_set_source_content)
 698         (tui_show_symtab_source): Update.
 699         * tui/tui-layout.c (extract_display_start_addr)
 700         (show_source_disasm_command, show_data)
 701         (make_source_or_disasm_window)
 702         (show_source_or_disasm_and_command): Update.
 703         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 704         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 705         "gdbarch".
 706         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 707         to tui_source_window_base.
 708         (struct tui_win_info) <detail>: Remove source_info member.
 709         (struct tui_source_window_base) <has_locator>: Inline.
 710         Move contents from tui_source_info; rename has_locator member to
 711         m_has_locator.
 712         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 713         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 714         header file.
 715         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 716         Simplify.
 717         (tui_free_all_source_wins_content): Cast to
 718         tui_source_window_base.
 719
 720 2019-06-25  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-win.c (make_invisible_and_set_new_height)
 723         (make_visible_with_new_height): Call has_locator method.
 724         * tui/tui-layout.c (show_source_disasm_command, show_data)
 725         (show_source_or_disasm_and_command): Update for bool change.
 726         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 727         (tui_win_info) <has_locator>: New method.
 728         (struct tui_source_window_base) <has_locator>: New method.
 729         (tui_win_has_locator): Don't declare.
 730         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 731         from tui_win_has_locator.
 732         (tui_source_window_base): Use false, not FALSE.
 733
 734 2019-06-25  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 737         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 738         clear_detail method directly.
 739         (tui_clear_win_detail): Remove.
 740
 741 2019-06-25  Tom Tromey  <tom@tromey.com>
 742
 743         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 744         "this", not TUI_DISASM_WIN.
 745
 746 2019-06-25  Tom Tromey  <tom@tromey.com>
 747
 748         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 749         declare.
 750         * tui/tui-winsource.c
 751         (tui_source_window_base::do_scroll_horizontal): Rename from
 752         tui_horizontal_source_scroll.
 753         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 754         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 755         from tui_vertical_data_scroll.
 756         * tui/tui-win.h (tui_scroll): Don't declare.
 757         * tui/tui-win.c (tui_win_info::forward_scroll)
 758         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 759         (tui_win_info::right_scroll): Rename and update.
 760         (tui_scroll_forward_command, tui_scroll_backward_command)
 761         (tui_scroll_left_command, tui_scroll_right_command): Update.
 762         (tui_scroll): Remove.
 763         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 764         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 765         from tui_vertical_source_scroll.
 766         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 767         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 768         from tui_vertical_disassem_scroll.
 769         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 770         do_scroll_horizontal>: New methods.
 771         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 772         Likewise.
 773         (struct tui_source_window_base): Add do_scroll_horizontal.
 774         (struct tui_source_window, struct tui_disasm_window): Add
 775         do_scroll_vertical.
 776         (struct tui_data_window, struct tui_cmd_window): Add
 777         do_scroll_horizontal and do_scroll_vertical.
 778         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 779
 780 2019-06-25  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-data.h (struct tui_source_window_base): New struct.
 783         (struct tui_source_window): Derive from tui_source_window_base.
 784         (struct tui_disasm_window): New struct.
 785         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 786         from tui_source_window::clear_detail.
 787         (tui_source_window_base): Rename from tui_source_window.
 788         (~tui_source_window_base): Rename from ~tui_source_window.
 789         (tui_alloc_win_info): Create a tui_disasm_window.
 790
 791 2019-06-25  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-data.h (struct tui_source_window)
 794         (struct tui_data_window): Declare destructors.
 795         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 796         destructors.
 797         (tui_win_info): Simplify.
 798
 799 2019-06-25  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-winsource.c (tui_display_main)
 802         (tui_update_source_windows_with_addr)
 803         (tui_update_all_breakpoint_info): Update.
 804         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 805         (new_height_ok, parse_scrolling_args): Update.
 806         * tui/tui-stack.c (tui_show_frame_info): Update.
 807         * tui/tui-data.h (struct tui_list): Remove.
 808         (tui_source_windows): Return a reference to a std::vector.
 809         * tui/tui-data.c (source_windows): Now a std::vector.
 810         (tui_source_windows): Change return type.
 811         (tui_clear_source_windows): Rewrite.
 812         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 813         (tui_free_all_source_wins_content): Rewrite.
 814
 815 2019-06-25  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 818         (struct tui_data_window, struct tui_cmd_window): Declare
 819         clear_detail method.
 820         * tui/tui-data.c (tui_source_window::clear_detail)
 821         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 822         methods.
 823         (tui_clear_win_detail): Simplify.
 824
 825 2019-06-25  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-layout.c (make_source_window, make_disasm_window)
 828         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 829         Return the new window.
 830         (show_source_disasm_command, show_data)
 831         (show_source_or_disasm_and_command): Update.
 832
 833 2019-06-25  Tom Tromey  <tom@tromey.com>
 834
 835         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 836         parameter.  Return the new window.
 837         (show_source_disasm_command): Update and remove NULL check.
 838         (show_source_or_disasm_and_command): Update.
 839
 840 2019-06-25  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 843
 844 2019-06-25  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-data.h (struct tui_win_info): Make constructor
 847         protected.  Make destructor virtual.  Add initializers.
 848         (tui_source_window, tui_data_window, tui_cmd_window): New
 849         classes.
 850         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 851         constructor.  Add "type" parameter.
 852         (tui_source_window, tui_data_window, tui_cmd_window): New
 853         constructors.
 854         (tui_alloc_win_info): Instantiate the appropriate subclass.
 855
 856 2019-06-25  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-win.c (tui_resize_all): Use delete.
 859         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 860         destructor.
 861         (tui_free_window): Don't declare.
 862         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 863         Update.
 864
 865 2019-06-25  Tom Tromey  <tom@tromey.com>
 866
 867         * tui/tui-data.h (struct tui_win_info): Add constructor.
 868         * tui/tui-data.c (tui_alloc_win_info): Use new.
 869         (tui_free_window): Use delete.
 870
 871 2019-06-22  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 874         declare.
 875         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 876
 877 2019-06-22  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 880         declare.
 881         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 882
 883 2019-06-22  Tom de Vries  <tdevries@suse.de>
 884
 885         * dwarf2read.c (create_addrmap_from_aranges)
 886         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 887         instead of '%zu'.
 888
 889 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 890
 891         * dwarf2read.h (dwarf2_section_info_def): Remove.
 892         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 893         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 894         std::vector<dwarf2_section_info>.
 895         (struct dwo_file) <~dwo_file>: Remove.
 896         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 897         types field.
 898         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 899         (dwarf2_read_debug_names): Likewise.
 900         (create_debug_types_hash_table): Change parameter type to
 901         array_view, adjust code accordingly.
 902         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 903         (partial_die_info::fixup): Likewise.
 904         (determine_prefix): Likewise.
 905         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 906
 907 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 908
 909         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 910         gdb_bfd_ref_ptr.
 911         <~dwo_file>: Remove call to gdb_bfd_unref.
 912         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 913         gdb_bfd_ref_ptr::get.
 914
 915 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 916
 917         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 918         type to htab_up.
 919         * dwarf2read.c (struct dwo_file): Initialize fields.
 920         <~dwo_file>: New.
 921         (free_dwo_file): Remove, move content to ~dwo_file.
 922         (struct dwo_file_deleter): Remove.
 923         (dwo_file_up>: Remove custom deleter.
 924         (free_dwo_files): Remove.
 925         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 926         dwo_files.
 927         (process_skeletonless_type_units): Call unique_ptr::get.
 928         (allocate_dwo_file_hash_table): Add deleter to created hash
 929         table.  Change return type to htab_up.
 930         (lookup_dwo_file_slot): Don't memset dwo_file, call
 931         unique_ptr::get.
 932         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 933         (create_dwo_unit_in_dwp_v2): Likewise.
 934         (open_and_init_dwo_file): Likewise.
 935         (free_dwo_file_from_slot): Remove.
 936
 937 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 938
 939         * dwarf2read.h (struct dwarf2_section_info) <readin,
 940         is_virtual>: Change type to bool.
 941         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 942         true instead of 1.
 943
 944 2019-06-19  Tom Tromey  <tom@tromey.com>
 945
 946         * tui/tui-data.h (tui_init_content_element): Don't declare.
 947
 948 2019-06-19  Tom Tromey  <tom@tromey.com>
 949
 950         * tui/tui-data.h (tui_init_win_info): Don't declare.
 951
 952 2019-06-19  Tom de Vries  <tdevries@suse.de>
 953
 954         * dwarf2read.h (abstract_to_concrete): Change type to
 955         std::unordered_map<sect_offset, std::vector<sect_offset>,
 956         gdb::hash_enum<sect_offset>>.
 957
 958 2019-06-19  Tom Tromey  <tromey@adacore.com>
 959
 960         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 961         EVAL_AVOID_SIDE_EFFECTS specially.
 962
 963 2019-06-19  Tom Tromey  <tromey@adacore.com>
 964
 965         * source-cache.c (highlighter): New global.
 966         (source_cache::get_source_lines): Create a highlighter on demand.
 967
 968 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 969
 970         * defs.h (deprecated_interactive_hook): Delete declaration.
 971         * interps.c (clear_interpreter_hooks): Remove use of
 972         deprecated_interactive_hook.
 973         * top.c (deprecated_interactive_hook): Delete definition.
 974         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 975
 976 2019-06-18  Tom de Vries  <tdevries@suse.de>
 977
 978         PR gdb/24515
 979         * dwarf2read.h (abstract_to_concrete): Change type from
 980         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 981         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 982         * dwarf2read.c (read_variable): Update.
 983         (dwarf2_fetch_die_loc_sect_off): Update.
 984
 985 2019-06-17  Tom de Vries  <tdevries@suse.de>
 986
 987         PR gdb/24617
 988         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 989         accessing parent[parent_len - 1].
 990
 991 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 992
 993         PR gdb/24364
 994         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 995         call dtrace_process_dof with NULL dof.
 996
 997 2019-06-16  Tom de Vries  <tdevries@suse.de>
 998
 999         PR gdb/24445
1000         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1001
1002 2019-06-16  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1005         (make_all_visible): Use address of member.
1006
1007 2019-06-16  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1010         (tui_free_window, free_content, free_content_elements): Remove
1011         unnecessary cast.
1012         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1013         cast.
1014         * tui/tui-regs.c (tui_show_register_group)
1015         (tui_display_registers_from, tui_display_reg_element_at_line):
1016         Remove unnecessary cast.
1017
1018 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * linux-nat.c (normal_mask): Delete.
1021         (_initialize_linux_nat): Don't initialise normal_mask.
1022
1023 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1024
1025         PR gdb/24445
1026         * dwarf-index-write.h (write_psymtabs_to_index): Add
1027         dwz_basename parameter.
1028         * dwarf-index-write.c (write_gdbindex): Move file writing to
1029         write_gdbindex_1.  Change return type void.
1030         (assert_file_size): Move up, remove filename parameter.
1031         (write_gdbindex_1): New function.
1032         (write_debug_names): Change return type to void, call
1033         assert_file_size.
1034         (struct index_wip_file): New struct.
1035         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1036         file logic to index_wip_file.  Write index for dwz file if
1037         needed.
1038         (save_gdb_index_command): Pass basename of dwz file, if present.
1039         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1040         build-id of dwz file, if present.
1041         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1042         (dwarf2_get_dwz_file): Likewise.
1043         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1044         (dwarf2_get_dwz_file): Likewise.
1045
1046 2019-06-16  Tom Tromey  <tom@tromey.com>
1047
1048         * coffread.c (process_coff_symbol): Use xstrdup.
1049         * value.c (create_internalvar): Use xstrdup.
1050
1051 2019-06-16  Tom Tromey  <tom@tromey.com>
1052
1053         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1054         * breakpoint.c (stopin_command, stopat_command)
1055         (until_break_command, decode_location_default): Remove unnecessary
1056         cast.
1057         * utils.c (subset_compare): Remove unnecessary cast.
1058         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1059         cast.
1060         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1061         cast.
1062         * infcmd.c (path_command): Remove unnecessary cast.
1063         * coffread.c (decode_type): Remove unnecessary cast.
1064         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1065         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1066         * tui/tui-stack.c (tui_show_locator_content)
1067         (tui_show_frame_info): Remove unnecessary cast.
1068         * tui/tui-win.c (tui_scroll_forward_command)
1069         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1070         (parse_scrolling_args): Remove unnecessary cast.
1071         * tui/tui-data.c (init_win_info, tui_del_window)
1072         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1073         (free_content_elements): Remove unnecessary cast.
1074         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1075         unnecessary cast.
1076         * tui/tui-source.c (tui_set_source_content)
1077         (tui_vertical_source_scroll): Remove unnecessary cast.
1078         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1079         cast.
1080         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1081         * tui/tui-regs.c (tui_display_registers_from)
1082         (tui_display_register): Remove unnecessary cast.
1083         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1084         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1085         (make_visible): Remove unnecessary cast.
1086         * tui/tui-winsource.c (tui_erase_source_content)
1087         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1088         unnecessary cast.
1089         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1090         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1091         * stabsread.c (read_type, read_array_type, read_range_type):
1092         Remove unnecessary cast.
1093         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1094         (parse_symbol, parse_type, upgrade_type, parse_external)
1095         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1096         unnecessary cast.
1097         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1098
1099 2019-06-16  Tom Tromey  <tom@tromey.com>
1100
1101         * tui/tui-data.c (tui_alloc_generic_win_info)
1102         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1103         checks.
1104
1105 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1106             Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         * f-typeprint.c (f_print_type): Don't return early for not
1109         associated or not allocated types.
1110         (f_type_print_varspec_suffix): Add print_rank parameter and print
1111         ranks of array types in case they dangling.
1112         (f_type_print_base): Add print_rank parameter.
1113
1114 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1115
1116         * NEWS: Mention new MI commands.
1117         * break-catch-throw.c (enum exception_event_kind): Move to
1118         breakpoint.h.
1119         (print_mention_exception_catchpoint): Output text as a single
1120         message.
1121         (catch_exception_command_1): Rename to...
1122         (catch_exception_event): ...this, make non-static, update header
1123         command, and change some parameter types.
1124         (catch_catch_command): Update for changes to
1125         catch_exception_command_1.
1126         (catch_throw_command): Likewise.
1127         (catch_rethrow_command): Likewise.
1128         * breakpoint.c (enum exception_event_kind): Delete.
1129         * breakpoint.h (enum exception_event_kind): Moved here from
1130         break-catch-throw.c.
1131         (catch_exception_event): Declare.
1132         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1133         (mi_cmd_catch_throw): New function.
1134         (mi_cmd_catch_rethrow): New function.
1135         (mi_cmd_catch_catch): New function.
1136         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1137         'catch-catch' entries.
1138         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1139         (mi_cmd_catch_rethrow): Declare.
1140         (mi_cmd_catch_catch): Declare.
1141
1142 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1143
1144         * annotate.c (annotate_source_line): Change return type to void,
1145         update implementation to match.
1146         * annotate.h (annotate_source_line): Change return type to void,
1147         update header comment.
1148         * stack.c (print_frame_info): Don't change what frame information
1149         is printed based on whether annotations are on or not.
1150
1151 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1154         (annotate_source): Make static.
1155         (annotate_source_line): Moved from source.c and renamed from
1156         identify_source_line.  Update the return type.
1157         * annotate.h (annotate_source): Delete declaration.
1158         (annotate_source_line): Declaration moved from source.h, and
1159         renamed from identify_source_line.  Return type updated.
1160         * source.c (identify_source_line): Moved to annotate.c and renamed
1161         to annotate_source_line.
1162         (info_line_command): Remove check of annotation_level.
1163         * source.h (identify_source_line): Move declaration to annotate.h
1164         and rename to annotate_source_line.
1165         * stack.c: Add 'annotate.h' include.
1166         (print_frame_info): Remove check of annotation_level before
1167         calling annotate_source_line.
1168
1169 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * source-cache.c (source_cache::get_plain_source_lines): Use
1172         open_source_file_with_line_charpos instead of just
1173         open_source_file, remove call to find_source_lines.
1174         (source_cache::get_source_lines): Likewise.
1175         * source.c (find_source_lines): Make static.
1176         (get_filename_and_charpos): Renamed into...
1177         (open_source_file_with_line_charpos): ..this along with changes to
1178         return a scoped_fd, and some other minor clean ups.
1179         (identify_source_line): Use open_source_file_with_line_charpos.
1180         (search_command_helper): Use open_source_file_with_line_charpos
1181         instead of just open_source_file, remove call to
1182         find_source_lines.
1183         * source.h (open_source_file_with_line_charpos): Declare new
1184         function.
1185         (find_source_lines): Delete declaration.
1186
1187 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1188
1189         * source.c (get_filename_and_charpos): Remove fullname
1190         parameter.
1191         (identify_source_line): Update call to get_filename_and_charpos.
1192
1193 2019-06-14  Tom Tromey  <tromey@adacore.com>
1194
1195         PR gdb/24502:
1196         * ui-style.h (skip_ansi_escape): Update comment.
1197         * ui-file.h (class no_terminal_escape_file): New class.
1198         * ui-file.c (no_terminal_escape_file::write)
1199         (no_terminal_escape_file::puts): New methods.
1200         * cli/cli-logging.c (handle_redirections): Use
1201         no_terminal_escape_file.
1202
1203 2019-06-14  Tom Tromey  <tromey@adacore.com>
1204
1205         * NEWS: Move convenience variable news above Python news.
1206
1207 2019-06-14  Tom Tromey  <tom@tromey.com>
1208
1209         * gnulib: Move directory to top-level.
1210         * configure.ac: Don't configure gnulib.
1211         * configure: Rebuild.
1212         * common/common-defs.h: Use new path to gnulib.
1213         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1214         (GNULIB_H): Remove.
1215         (INCGNU): Look in new gnulib location.
1216         (HFILES_NO_SRCDIR): Remove gnulib files.
1217         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1218         (generated_files): Remove GNULIB_H.
1219         ($(LIBGNU), all-lib): Remove targets.
1220         (distclean): Don't mention GNULIB_BUILDDIR.
1221         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1222
1223 2019-06-14  Tom Tromey  <tromey@adacore.com>
1224
1225         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1226         Warn if symbol file does not provide any symbols.
1227
1228 2019-06-14  Tom Tromey  <tromey@adacore.com>
1229
1230         * source.c (find_and_open_source): Respect basenames_may_differ.
1231
1232 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * annotate.c (annotate_breakpoints_invalid): Make use of
1235         scoped_restore_terminal_state.
1236         (annotate_frames_invalid): Likewise.
1237
1238 2019-06-14  Tom Tromey  <tromey@adacore.com>
1239
1240         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1241         allow assignment to an internalvar.
1242
1243 2019-06-14  Tom Tromey  <tromey@adacore.com>
1244
1245         * ada-lex.l: Allow "_" in attribute names.
1246
1247 2019-06-14  Tom Tromey  <tromey@adacore.com>
1248
1249         PR gdb/24653:
1250         * regcache.c (registers_changed): Don't call alloca.
1251         * top.c (execute_command): Don't call alloca.
1252
1253 2019-06-13  Pedro Alves  <palves@redhat.com>
1254
1255         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1256         'expression'.  When parsing an expression, error out if there's
1257         junk after "unlimited".
1258         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1259         (do_set_command): Adjust calls to is_unlimited_literal.
1260
1261 2019-06-13  Pedro Alves  <palves@redhat.com>
1262
1263         * compile/compile.c (make_compile_options_def_group): Add braces
1264         around array_view initializer.
1265         * thread.c (make_thread_apply_all_options_def_group)
1266         (make_thread_apply_all_options_def_group): Likewise.
1267
1268 2019-06-13  Pedro Alves  <palves@redhat.com>
1269
1270         * NEWS (New commands): Mention "maint test-options
1271         require-delimiter", "maint test-options unknown-is-error", "maint
1272         test-options unknown-is-operand" and "maint show
1273         test-options-completion-result".
1274         (New command options, command completion): New section.
1275         (Completion improvements): New section.
1276         Mention that you can abbreviate "unlimited".
1277
1278 2019-06-13  Pedro Alves  <palves@redhat.com>
1279
1280         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1281         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1282         * unittests/cli-utils-selftests.c (test_parse_flags)
1283         (test_parse_flags_qcs): Delete.
1284         (test_cli_utils): Don't call deleted functions.
1285
1286 2019-06-13  Pedro Alves  <palves@redhat.com>
1287
1288         * thread.c: Include "cli/cli-option.h".
1289         (tp_array_compar_ascending): Global.
1290         (tp_array_compar): Delete function.
1291         (tp_array_compar_ascending, tp_array_compar_descending): New
1292         functions.
1293         (ascending_option_def, qcs_flag_option_def)
1294         (thr_qcs_flags_option_defs)
1295         (make_thread_apply_all_options_def_group)
1296         (make_thread_apply_options_def_group): New.
1297         (thread_apply_all_command): Use gdb::option::process_options.
1298         (thread_apply_command_completer)
1299         (thread_apply_all_command_completer): New.
1300         (thread_apply_command): Use gdb::option::process_options.
1301         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1302         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1303         to generate help text of "thread apply".  Adjust "taas"'s help.
1304         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1305         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1306
1307 2019-06-13  Pedro Alves  <palves@redhat.com>
1308
1309         * thread.c (thread_apply_command): Check for invalid TID with
1310         isdigit instead of !isalpha.
1311
1312 2019-06-13  Pedro Alves  <palves@redhat.com>
1313
1314         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1315         (validate_flags_qcs): New.
1316         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1317         (validate_flags_qcs): Declare.
1318         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1319         (make_frame_apply_options_def_group): New.
1320         (frame_apply_command_count): Process options with
1321         gdb::option::process_options.
1322         (frame_apply_completer): New.
1323         (frame_apply_level_completer, frame_apply_all_completer)
1324         (frame_apply_completer): New.
1325         (_initialize_stack): Update help of "frame apply", "frame apply
1326         level", "frame apply all" and "faas" to mention supported options
1327         and install command completers.
1328         * stack.h (frame_apply_all_completer): Declare.
1329         * thread.c: Include "stack.h".
1330         (tfaas_command): Add "--".
1331         (_initialize_thread): Update help "tfaas" to mention supported
1332         options and install command completer.
1333
1334 2019-06-13  Pedro Alves  <palves@redhat.com>
1335
1336         * completer.c (complete_nested_command_line): New.
1337         (gdb_completion_word_break_characters_throw): Add assertion.
1338         * completer.h (complete_nested_command_line): Declare.
1339
1340 2019-06-13  Pedro Alves  <palves@redhat.com>
1341
1342         * stack.c (parse_backtrace_qualifiers): New.
1343         (backtrace_command): Use it.
1344         (backtrace_command_completer): Complete on qualifiers.
1345
1346 2019-06-13  Pedro Alves  <palves@redhat.com>
1347
1348         * frame.c: Include "cli/cli-option.h.
1349         (user_set_backtrace_options): New.
1350         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1351         Delete.
1352         (get_prev_frame): Adjust.
1353         (boolean_option_def, uinteger_option_def)
1354         (set_backtrace_option_defs): New.
1355         (_initialize_frame): Adjust and use
1356         gdb::option::add_setshow_cmds_for_options to install "set
1357         backtrace past-main" and "set backtrace past-entry".
1358         * frame.h: Include "cli/cli-option.h".
1359         (struct frame_print_options): Forward declare.
1360         (print_frame_arguments_all, print_frame_arguments_scalars)
1361         (print_frame_arguments_none): Declare.
1362         (print_entry_values): Delete declaration.
1363         (struct frame_print_options, user_frame_print_options): New.
1364         (struct set_backtrace_options): New.
1365         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1366         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1367         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1368         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1369         (list_args_or_locals): Add frame_print_options parameter.
1370         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1371         * python/py-framefilter.c (enumerate_args): Pass down
1372         USER_FRAME_PRINT_OPTIONS.
1373         * stack.c: Include "cli/cli-option.h".
1374         (print_frame_arguments_all, print_frame_arguments_scalars)
1375         (print_frame_arguments_none): Declare.
1376         (print_raw_frame_arguments, print_entry_values): Delete.
1377         (user_frame_print_options): New.
1378         (boolean_option_def, enum_option_def, frame_print_option_defs):
1379         New.
1380         (struct backtrace_cmd_options): New.
1381         (bt_flag_option_def): New.
1382         (backtrace_command_option_defs): New.
1383         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1384         (print_frame_arg, read_frame_arg, print_frame_args)
1385         (print_frame_info, print_frame): Add frame_print_options parameter
1386         and use it.
1387         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1388         (backtrace_command_1): Add frame_print_options and
1389         backtrace_cmd_options parameters and use them.
1390         (make_backtrace_options_def_group): New.
1391         (backtrace_command): Process command options with
1392         gdb::option::process_options.
1393         (backtrace_command_completer): New.
1394         (_initialize_stack): Extend "backtrace"'s help to mention
1395         supported options.  Install completer for "backtrace".
1396         Install some settings commands with add_setshow_cmds_for_options.
1397
1398 2019-06-13  Pedro Alves  <palves@redhat.com>
1399
1400         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1401         and that "set/show print raw frame-arguments" are now deprecated.
1402
1403         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1404         command.
1405         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1406         * stack.c (_initialize_stack): Install "set/show print
1407         raw-frame-arguments", and deprecate "set/show print raw
1408         frame-arguments".
1409         * valprint.c (_initialize_valprint): Deprecate "set/show print
1410         raw".
1411
1412 2019-06-13  Pedro Alves  <palves@redhat.com>
1413
1414         * compile/compile.c (struct compile_options): New.
1415         (compile_flag_option_def, compile_command_option_defs)
1416         (make_compile_options_def_group): New.
1417         (compile_file_command): Handle options with
1418         gdb::option::process_options.
1419         (compile_file_command_completer): New function.
1420         (compile_code_command): Handle options with
1421         gdb::option::process_options.
1422         (compile_code_command_completer): New function.
1423         (_initialize_compiler): Install completers for "compile code" and
1424         "compile file".  Mention available options in "compile code" and
1425         "compile code"'s help.
1426         * completer.c (advance_to_completion_word): New, factored out from
1427         ...
1428         (advance_to_expression_complete_word_point): ... this.
1429         (advance_to_filename_complete_word_point): New.
1430         * completer.h (advance_to_filename_complete_word_point): New
1431         declaration.
1432
1433 2019-06-13  Pedro Alves  <palves@redhat.com>
1434
1435         * compile/compile.c: Include "cli/cli-option.h".
1436         (compile_print_value): Scope data pointer is now a
1437         value_print_options pointer; adjust.
1438         (compile_print_command): Process options.  Scope data pointer is
1439         now a value_print_options pointer; adjust.
1440         (_initialize_compile): Update "compile print"'s help to include
1441         supported options.  Install a completer for "compile print".
1442         * cp-valprint.c (show_vtblprint, show_objectprint)
1443         (show_static_field_print): Delete.
1444         (_initialize_cp_valprint): Don't install "set print
1445         static-members", "set print vtbl", "set print object" here.
1446         * printcmd.c: Include "cli/cli-option.h" and
1447         "common/gdb_optional.h".
1448         (print_command_parse_format): Rework to fill in a
1449         value_print_options instead of a format_data.
1450         (print_value): Change parameter type from format_data pointer to
1451         value_print_options reference.  Adjust.
1452         (print_command_1): Process options.  Adjust to pass down a
1453         value_print_options.
1454         (print_command_completer): New.
1455         (_initialize_printcmd): Install print_command_completer as
1456         handle_brkchars completer for the "print" command.  Update
1457         "print"'s help to include supported options.
1458         * valprint.c: Include "cli/cli-option.h".
1459         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1460         here from cp-valprint.c.
1461         (boolean_option_def, uinteger_option_def)
1462         (value_print_option_defs, make_value_print_options_def_group):
1463         New.  Use gdb::option::add_setshow_cmds_for_options to install
1464         "set print elements", "set print null-stop", "set print repeats",
1465         "set print pretty", "set print union", "set print array", "set
1466         print address", "set print symbol", "set print array-indexes".
1467         * valprint.h: Include <string> and "cli/cli-option.h".
1468         (make_value_print_options_def_group): Declare.
1469         (print_value): Change parameter type from format_data pointer to
1470         value_print_options reference.
1471         (print_command_completer): Declare.
1472
1473 2019-06-13  Pedro Alves  <palves@redhat.com>
1474
1475         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1476         (COMMON_SFILES): Add maint-test-settings.c.
1477         * cli/cli-decode.c (boolean_enums): New global, factored out from
1478         ...
1479         (add_setshow_boolean_cmd): ... here.
1480         * cli/cli-decode.h (boolean_enums): Declare.
1481         * cli/cli-option.c: New file.
1482         * cli/cli-option.h: New file.
1483         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1484         factored out from ...
1485         (parse_cli_boolean_value(const char *)): ... this.
1486         (is_unlimited_literal): Change parameter type to pointer to
1487         pointer.  Adjust and advance ARG pointer.
1488         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1489         (parse_cli_var_enum): New, factored out from ...
1490         (do_set_command): ... this.  Adjust.
1491         * cli/cli-setshow.h (parse_cli_boolean_value)
1492         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1493         (parse_cli_var_enum): Declare.
1494         * cli/cli-utils.c: Include "cli/cli-option.h".
1495         (get_ulongest): New.
1496         * cli/cli-utils.h (get_ulongest): Declare.
1497         (check_for_argument): New overloads.
1498         * maint-test-options.c: New file.
1499
1500 2019-06-13  Pedro Alves  <palves@redhat.com>
1501
1502         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1503         parse a range if "-" is at the end of the string.
1504
1505 2019-06-13  Pedro Alves  <palves@redhat.com>
1506
1507         * cli/cli-setshow.c (parse_auto_binary_operation)
1508         (parse_cli_boolean_value): Don't allow "o".
1509
1510 2019-06-13  Pedro Alves  <palves@redhat.com>
1511
1512         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1513         * NEWS: Mention maint test-settings KIND.
1514         * maint-test-settings.c: New file.
1515
1516 2019-06-13  Pedro Alves  <palves@redhat.com>
1517
1518         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1519         completer.
1520         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1521         "set" completers.
1522
1523 2019-06-13  Pedro Alves  <palves@redhat.com>
1524
1525         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1526         after item.
1527
1528 2019-06-13  Pedro Alves  <palves@redhat.com>
1529
1530         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1531
1532 2019-06-13  Pedro Alves <palves@redhat.com>
1533
1534         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1535         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1536         call.
1537         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1538         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1539         calls.
1540         (check_for_argument): Skip spaces after argument.
1541
1542 2019-06-13  Pedro Alves  <palves@redhat.com>
1543
1544         * thread.c (thread_apply_command): Adjust TID parsing.
1545         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1546         detected before end of string.
1547         (tid_is_in_list): Error out if LIST is invalid.
1548
1549 2019-06-13  Pedro Alves  <palves@redhat.com>
1550
1551         * completer.c (complete_line_internal_1): Rewind completion word
1552         point.
1553         (completion_tracker::advance_custom_word_point_by): Change
1554         parameter type to int.
1555         * completer.h (completion_tracker::advance_custom_word_point_by):
1556         Likewise.
1557
1558 2019-06-13  Pedro Alves  <palves@redhat.com>
1559
1560         * completer.c (advance_to_completion_word): Handle delimiters.
1561
1562 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1563
1564         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1565
1566 2019-06-11  Tom Tromey  <tom@tromey.com>
1567
1568         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1569         (xmalloc_failed): Move to alloc.c.
1570         * alloc.c: New file.
1571         * Makefile.in (COMMON_SFILES): Add alloc.c.
1572
1573 2019-06-11  Tom Tromey  <tom@tromey.com>
1574
1575         * nat/linux-waitpid.c: Don't include server.h.
1576         (linux_debug): Remove.
1577         (my_waitpid): Update.
1578
1579 2019-06-11  Tom Tromey  <tromey@adacore.com>
1580
1581         * infcall.c (_initialize_infcall): Remove trailing newline from
1582         help.
1583         * user-regs.c (_initialize_user_regs): Remove trailing newline
1584         from help.
1585         * typeprint.c (_initialize_typeprint): Remove trailing newline
1586         from help.
1587         * reverse.c (_initialize_reverse): Remove trailing newlines from
1588         help.
1589         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1590         from help.
1591         * language.c (add_set_language_command): Remove trailing newline
1592         from help.
1593         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1594         help.
1595         * disasm.c (_initialize_disasm): Remove trailing newline from
1596         help.
1597         * top.c (init_main): Remove trailing newline from help.
1598         * interps.c (_initialize_interpreter): Remove trailing newline
1599         from help.
1600         * btrace.c (_initialize_btrace): Remove trailing newlines from
1601         help.
1602         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1603         from help.
1604         * python/python.c (_initialize_python): Remove trailing newline
1605         from help.
1606         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1607         help.
1608         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1609         from help.  Reformat some text.
1610         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1611         from help.
1612         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1613         newline from help.
1614
1615 2019-06-11  Tom Tromey  <tromey@adacore.com>
1616
1617         * darwin-nat.c (darwin_decode_exception_message)
1618         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1619
1620 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1621
1622         * valops.c (value_slice): Check for not allocated or not
1623         associated values.
1624
1625 2019-06-10  Tom de Vries  <tdevries@suse.de>
1626
1627         PR gdb/24618
1628         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1629         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1630         invalid.
1631
1632 2019-06-10  Tom de Vries  <tdevries@suse.de>
1633
1634         PR gdb/24611
1635         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1636         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1637
1638 2019-06-10  Tom de Vries  <tdevries@suse.de>
1639
1640         PR symtab/24545
1641         * symtab.c (struct demangled_name_entry): Add language field.
1642         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1643         static minimal symbol".  Set and use language field.
1644
1645 2019-06-10  Tom Tromey  <tromey@adacore.com>
1646
1647         * ada-lang.c (_initialize_ada_language): Update help text.
1648
1649 2019-06-10  Tom Tromey  <tromey@adacore.com>
1650
1651         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1652         with a newline.
1653         * guile/guile.c (handle_boot_error): Don't end warning with a
1654         newline.
1655         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1656         warning with a newline.
1657         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1658         newline.
1659         (s12z_frame_cache): Likewise.
1660         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1661         a newline.
1662         * solib-svr4.c (disable_probes_interface): Don't end warning with
1663         a newline.
1664         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1665         newline.
1666         * python/python.c (do_finish_initialization): Don't end warning
1667         with a newline.
1668
1669 2019-06-10  Tom Tromey  <tom@tromey.com>
1670
1671         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1672         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1673         gdbpy_enter.
1674
1675 2019-06-10  Tom Tromey  <tromey@adacore.com>
1676
1677         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1678         data.
1679         (elf_new_init): Don't call stabsread_new_init.
1680         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1681         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1682         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1683
1684 2019-06-10  Tom de Vries  <tdevries@suse.de>
1685
1686         PR symtab/16264
1687         PR symtab/24517
1688         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1689
1690 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1691
1692         * source.c (find_and_open_source): Also rewrite relative file
1693         names.
1694
1695 2019-04-26  Amos Bird  <amosbird@gmail.com>
1696
1697         * annotate.c (annotate_thread_exited): Add "thread-exited"
1698         annotation.
1699
1700 2019-06-06  Tom Tromey  <tromey@adacore.com>
1701
1702         * maint.h (class scoped_command_stats): Use
1703         DISABLE_COPY_AND_ASSIGN.
1704         <print_time>: New method.
1705         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1706         print_time.
1707         (scoped_command_stats::print_time): New method.
1708
1709 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1710
1711         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1712         instructions of lengths 6 or 8 bytes.
1713
1714 2019-06-04  Pedro Alves  <palves@redhat.com>
1715
1716         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1717
1718         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1719         * breakpoint.c (condition_completer): Likewise.
1720         * cli/cli-dump.c (scan_expression): Likewise.
1721         * common/filestuff.c (mkdir_recursive): Likewise.
1722         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1723         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1724         (gdb_abspath): Likewise.
1725         * compile/compile-cplus-types.c
1726         (compile_cplus_instance::decl_name): Likewise.
1727         * completer.c (complete_explicit_location):
1728         (signal_completer, reg_or_group_completer_1): Likewise.
1729         * cp-support.c (cp_remove_params_if_any): Likewise.
1730         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1731         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1732         * infcmd.c (strip_bg_char): Likewise.
1733         * linespec.c (copy_token_string): Likewise.
1734         * mi/mi-main.c (output_cores): Likewise.
1735         * psymtab.c (psymtab_search_name):
1736         * symfile.c (test_set_ext_lang_command): Likewise.
1737         * target.c (target_fileio_read_stralloc): Likewise.
1738         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1739         * value.c (complete_internalvar): Likewise.
1740
1741 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1742
1743         Add objfile property to gdb.Type.
1744         * NEWS: Mention Python API addition.
1745         * python/py-type.c (typy_get_objfile): New method.
1746
1747 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1748
1749         * NEWS: Mention the new set|show style [title|highlight].
1750         Mention changes to "show style", "help" and "apropos".
1751
1752 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1753
1754         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1755         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1756         instead of print_help_for_command.
1757         (print_doc_of_command): New function.
1758         (help_list): Add 'apropos -v word' suggestion.
1759         (print_help_for_command): Style the command name using title style.
1760         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1761         (_initialize_cli_cmds): Describe -v in apropos_command help.
1762
1763 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1764
1765         * cli/cli-style.h (cli_style_option): Add name in constructor,
1766         add m_name class member, add constructor with intensity,
1767         add name class function.
1768         (cli_style_option::add_setshow_commands): Remove name argument.
1769         (highlight_style, title_style): New styles.
1770         * cli/cli-style.c (do_show): New function that shows a style
1771         characteristic styling the style name with itself.
1772         (set_style_name): New function.
1773         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1774         Update all callers according to the changes in cli/cli-style.h.
1775         * utils.h (fputs_highlighted): New function.
1776         * utils.c (fputs_highlighted): Likewise.
1777
1778 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1779
1780         * NEWS: Mention new pipe command and new convenience variables.
1781
1782 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1783
1784         * cli/cli-cmds.c (pipe_command): New function.
1785         (_initialize_cli_cmds): Call add_com for pipe_command.
1786         Define | as an alias for pipe.
1787         (exit_status_set_internal_vars): New function.
1788         (shell_escape): Call exit_status_set_internal_vars.
1789         cli/cli-decode.c (find_command_name_length): Recognize | as
1790         a single character command.
1791
1792 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1793
1794         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1795         top.c (execute_command_to_ui_file): New function, mostly a copy
1796         of execute_command_to_string.
1797         (execute_command_to_string): Implement by calling
1798         execute_command_to_ui_file.
1799
1800 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1801
1802         * top.h (saved_command_line): Remove declaration.
1803         * top.c (previous_saved_command_line, previous_repeat_arguments):
1804         New variables.
1805         (saved_command_line): Make static, define together with other
1806         'repeat variables'.
1807         (dont_repeat): Clear repeat_arguments.
1808         (repeat_previous, get_saved_command_line, save_command_line):
1809         New functions.
1810         (gdb_init): Initialize saved_command_line
1811         and previous_saved_command_line.
1812         * main.c (captured_main_1): Remove saved_command_line initialization.
1813         * event-top.c (handle_line_of_input): Update to use
1814         the new 'repeat' related functions instead of direct access to
1815         saved_command_line.
1816         * command.h (repeat_previous, get_saved_command_line,
1817         save_command_line): New declarations.
1818         (dont_repeat): Add comment.
1819
1820 2019-05-30  Tom Tromey  <tromey@adacore.com>
1821
1822         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1823         Fix comment.
1824         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1825
1826 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1827
1828         PR cli/24587
1829         * completer.c (complete): Initialize variable word.
1830
1831 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1832
1833         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1834         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1835         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1836         'body' is NULL to the outter 'if', protecting the '!is_define'
1837         situation as well.
1838
1839 2019-05-29  Tom Tromey  <tromey@adacore.com>
1840
1841         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1842         (dwarf_unknown): New function.
1843         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1844         (dwarf_type_encoding_name): Use dwarf_unknown.
1845
1846 2019-05-29  Tom Tromey  <tromey@adacore.com>
1847
1848         PR c++/20020:
1849         * cp-valprint.c (cp_print_value_fields): Call
1850         cp_print_static_field inside "try".
1851
1852 2019-05-29  Tom Tromey  <tromey@adacore.com>
1853
1854         * inflow.c (struct terminal_info): Add default operator=.
1855         * configure: Rebuild.
1856         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1857         -Wdeprecated-copy-dtor, -Wredundant-move.
1858
1859 2019-05-29  Tom Tromey  <tromey@adacore.com>
1860
1861         * NEWS: Add entry.
1862         * infcmd.c (print_return_value_1): Handle finish_print
1863         option.
1864         (show_print_finish): New function.
1865         (_initialize_infcmd): Add "set/show print finish" commands.
1866         * valprint.c (user_print_options): Initialize new member.
1867         * valprint.h (struct value_print_options) <finish_print>: New
1868         member.
1869
1870 2019-05-28  Tom Tromey  <tromey@adacore.com>
1871
1872         * ada-lang.c (ada_remove_Xbn_suffix)
1873         (find_old_style_renaming_symbol)
1874         (parse_old_style_renaming): Remove.
1875         (ada_find_renaming_symbol): Don't call
1876         find_old_style_renaming_symbol.
1877         (ada_is_renaming_symbol): Rename from
1878         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1879         bool.  Now static.
1880         (ada_read_var_value): Update and simplify.
1881         * ada-exp.y (write_var_or_type): Remove old code.
1882
1883 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1884
1885         * event-top.c: Remove include comment.
1886         * inflow.c (class scoped_ignore_sigttou): Move from here...
1887         * inflow.h (class scoped_ignore_sigttou): ...to here.
1888         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1889         * top.c:  Remove include comment.
1890
1891 2019-05-27  Tom Tromey  <tom@tromey.com>
1892
1893         * NEWS: Fix typo.
1894
1895 2019-05-22  Tom Tromey  <tromey@adacore.com>
1896
1897         * target.c (target_follow_exec): Constify parameter.
1898         * target-delegates.c: Rebuild.
1899         * remote.c (remote_target::follow_exec): Constify parameter.
1900         * infrun.c (follow_exec): Constify parameter.
1901         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1902         (target_follow_exec): Likewise.
1903
1904 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1905
1906         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1907         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1908
1909 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1910
1911         * NEWS: Add debugredirect and testsuite sections.
1912
1913 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1914
1915         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1916         target descriptions using exclusively floating point register name
1917         aliases.
1918
1919 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1920
1921         PR gdb/18644:
1922         * f-lang.c (build_fortran_types): Handle the case where
1923         gdbarch_floatformat_for_type returns a nullptr.
1924
1925 2019-05-21  Tom de Vries  <tdevries@suse.de>
1926
1927         PR cli/24587
1928         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1929
1930 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1931
1932         PR gdb/18644:
1933         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1934         16-byte floats.
1935         * i386-tdep.c (i386_floatformat_for_type): Use
1936         floatformats_ia64_quad for the 16-byte floating point component
1937         within a fortran 32-byte complex number.
1938
1939 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1942         delete default constructor.
1943         (find_partial_die): Update to return const struct.
1944         (partial_die_parent_scope): Move variable declaration into scope
1945         of its use and change its type to auto.
1946         (guess_partial_die_structure_name): Likewise.
1947         (partial_die_info::fixup): Likewise.
1948
1949 2019-05-17  Tom Tromey  <tromey@adacore.com>
1950
1951         * source.c (find_and_open_source): Remove cast.
1952
1953 2019-05-17  Tom Tromey  <tromey@adacore.com>
1954
1955         * annotate.c (annotate_source): Make "filename" const.
1956         * annotate.h (annotate_source): Use const.
1957
1958 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1959
1960         * disasm.c (set_disassembler_options): Send errors to stderr.
1961
1962 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1963
1964         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1965         (cli_interp_base::set_logging): Check debug_redirect.
1966         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1967         * cli/cli-logging.c (debug_redirect): Add static variable.
1968         (pop_output_files): Add default param.
1969         (handle_redirections): Print debug setting.
1970         (show_logging_command): Likewise.
1971         (_initialize_cli_logging): Add debugredirect command.
1972         * interps.c (current_interp_set_logging): Add debug_redirect
1973         parameter.
1974         * interps.h (set_logging): Add debug_redirect parameter.
1975         (current_interp_set_logging): Likewise.
1976         * mi/mi-common.h: Likewise.
1977         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1978
1979 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1980             Tom Tromey  <tromey@adacore.com>
1981
1982         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1983         directly.
1984         * cli/cli-interp.h (make_logging_output): Remove declaration.
1985         * cli/cli-logging.c (make_logging_output): Remove function.
1986         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1987         directly.
1988         * ui-file.c (tee_file::tee_file): Remove bools.
1989         (tee_file::~tee_file): Remove deletes.
1990         * ui-file.h (tee_file): Remove bools.
1991
1992 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1993
1994         * mi/mi-cmds.h (mi_cmd_complete): New function.
1995         * mi/mi-main.c (mi_cmd_complete): Likewise.
1996         * mi/mi-cmds.c: Define new MI command -complete.
1997         * NEWS: Mention new -complete command.
1998
1999 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2000
2001         * completer.h (complete): New function.
2002         * completer.c (complete): Likewise.
2003         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2004         function defined in completer.h.
2005
2006 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2007
2008         * MAINTAINERS (Write After Approval): Add myself.
2009
2010 2019-05-17  Tom de Vries  <tdevries@suse.de>
2011
2012         PR gdb/24094
2013         * dwarf2read.c (struct cu_partial_die_info): New struct.
2014         (find_partial_die): Return cu_partial_die_info.
2015         (partial_die_parent_scope, guess_partial_die_structure_name)
2016         (partial_die_info::fixup): Handle new return type of find_partial_die.
2017
2018 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2019
2020         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2021         "std::string", simplifying the algorithm.
2022
2023 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2024
2025         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2026         (stap_static_probe_ops::get_probes): Likewise.
2027
2028 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2029
2030         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2031         '-')" and "else if".
2032         (stap_parse_single_operand): Join checks for
2033         "gdbarch_stap_parse_special_token_p" and
2034         "gdbarch_stap_parse_special_token" in the same "if" statement.
2035         Invert check when verifying for operation on register
2036         displacement.
2037
2038 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2039
2040         * stap-probe.c (stap_get_opcode): Update comment.
2041         (stap_get_expected_argument_type): Likewise.
2042         (handle_stap_probe): Likewise.
2043
2044 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2045
2046         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2047         return type to 'bool'.  Adjust comment.  Use 'bool' when
2048         appropriate.
2049         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2050         * stap-probe.c (stap_parse_argument_1): Likewise.
2051         (stap_is_operator): Likewise.
2052         (stap_is_generic_prefix): Likewise.
2053         (stap_is_register_prefix): Likewise.
2054         (stap_is_register_indirection_prefix): Likewise.
2055         (stap_is_integer_prefix): Likewise.
2056         (stap_generic_check_suffix): Likewise.
2057         (stap_check_integer_suffix): Likewise.
2058         (stap_check_register_suffix): Likewise.
2059         (stap_check_register_indirection_suffix): Likewise.
2060         (stap_parse_register_operand): Likewise.
2061         (stap_parse_single_operand): Likewise.
2062         (stap_parse_argument_1): Likewise.
2063         (stap_probe::get_argument_count): Likewise.
2064         (stap_is_operator): Likewise.
2065
2066 2019-05-16  Tom Tromey  <tromey@adacore.com>
2067
2068         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2069         keyword to foreach.
2070
2071 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2072
2073         * linux-thread-db.c (try_thread_db_load_1): Change return type
2074         to bool.
2075         (try_thread_db_load): Likewise.
2076         (try_thread_db_load_from_pdir_1): Likewise.
2077         (try_thread_db_load_from_pdir): Likewise.
2078         (try_thread_db_load_from_sdir): Likewise.
2079         (try_thread_db_load_from_dir): Likewise.
2080         (thread_db_load_search): Likewise.
2081         (has_libpthread): Likewise.
2082         (thread_db_load): Likewise.
2083
2084 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2085
2086         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2087         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2088         NULL, and complain/return if that's the case.
2089
2090 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2091
2092         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2093         (advance, posn, abstract_read_memory): New functions.
2094         [struct mem_read_abstraction]: New struct.
2095         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2096
2097 2019-05-14  Tom Tromey  <tromey@adacore.com>
2098
2099         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2100         value is not lval_memory.
2101
2102 2019-05-14  Tom Tromey  <tromey@adacore.com>
2103
2104         * solib.c (info_sharedlibrary_command): Style the file name.
2105
2106 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2107
2108         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2109         (aarch64_vnv_type): Likewise.
2110         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2111         * common/tdesc.c: Likewise.
2112         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2113         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2114         * features/aarch64-fpu.xml: Add ieee half view.
2115         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2116         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2117         * gdbtypes.h (struct builtin_type): Likewise.
2118         (struct objfile_type): Likewise.
2119
2120 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2121
2122         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2123         typo.
2124         * location.h (string_to_event_location): Likewise.
2125
2126 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2127
2128         GDB 8.3 released.
2129
2130 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2131
2132         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2133         New variable declaration.
2134         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2135         New variable.
2136         (print_one_breakpoint): Use ui_out::test_flags and new global
2137         variable to compute use_fixed_output.
2138         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2139         Remove.
2140         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2141         (mi_multi_location_breakpoint_output_fixed): Remove.
2142         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2143         new variable.
2144         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2145         fix_multi_location_breakpoint_output flag if version >= 3.
2146         * ui-out.h (enum ui_out_flag)
2147         <fix_multi_location_breakpoint_output>: New enumerator.
2148
2149 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2150
2151         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2152
2153 2019-05-10  Tom Tromey  <tromey@adacore.com>
2154
2155         * ada-lang.c (catch_ada_completer): New function.
2156         (_initialize_ada_language): Use it.
2157
2158 2019-05-10  Tom Tromey  <tromey@adacore.com>
2159
2160         * thread.c (print_thread_info): Make "requested_threads" const.
2161         * gdbthread.h (print_thread_info): Make "requested_threads"
2162         const.
2163         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2164         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2165
2166 2019-05-08  Tom Tromey  <tom@tromey.com>
2167
2168         * gdbtypes.c (objfile_type_data): Change type.
2169         (objfile_type, _initialize_gdbtypes): Update.
2170
2171 2019-05-08  Tom Tromey  <tom@tromey.com>
2172
2173         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2174         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2175         (_initialize_dwarf2_frame): Update.
2176
2177 2019-05-08  Tom Tromey  <tom@tromey.com>
2178
2179         * objc-lang.c (objc_objfile_data): Change type.
2180         (find_methods): Update.
2181         (_initialize_objc_lang): Remove.
2182
2183 2019-05-08  Tom Tromey  <tom@tromey.com>
2184
2185         * stabsread.c (rs6000_builtin_type_data): Change type.
2186         (rs6000_builtin_type, _initialize_stabsread): Update.
2187
2188 2019-05-08  Tom Tromey  <tom@tromey.com>
2189
2190         * mips-tdep.c (mips_pdr_data): Remove.
2191         (_initialize_mips_tdep): Update.
2192
2193 2019-05-08  Tom Tromey  <tom@tromey.com>
2194
2195         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2196         (hppa_init_objfile_priv_data, read_unwind_info)
2197         (find_unwind_entry, _initialize_hppa_tdep): Update.
2198
2199 2019-05-08  Tom Tromey  <tom@tromey.com>
2200
2201         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2202         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2203         on obstack.
2204         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2205
2206 2019-05-08  Tom Tromey  <tom@tromey.com>
2207
2208         * mdebugread.c (basic_type_data): Change type.
2209         (basic_type, _initialize_mdebugread): Update.
2210
2211 2019-05-08  Tom Tromey  <tom@tromey.com>
2212
2213         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2214
2215 2019-05-08  Tom Tromey  <tom@tromey.com>
2216
2217         * nto-tdep.c (nto_inferior_data_reg): Change type.
2218         (nto_inferior_data): Update.
2219         (nto_inferior_data_cleanup, nto_new_inferior_data)
2220         (_initialize_nto_tdep): Remove.
2221         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2222
2223 2019-05-08  Tom Tromey  <tom@tromey.com>
2224
2225         * ada-lang.c (struct ada_inferior_data): Add initializers.
2226         (ada_inferior_data): Change type.
2227         (ada_inferior_data_cleanup): Remove.
2228         (get_ada_inferior_data, ada_inferior_exit)
2229         (struct ada_pspace_data): Add initializers, destructor.
2230         (ada_pspace_data_handle): Change type.
2231         (get_ada_pspace_data): Update.
2232         (ada_pspace_data_cleanup): Remove.
2233
2234 2019-05-08  Tom Tromey  <tom@tromey.com>
2235
2236         * coffread.c (struct coff_symfile_info): Add initializers.
2237         (coff_objfile_data_key): Move lower.  Change type.
2238         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2239         Update.
2240         (coff_free_info): Remove.
2241
2242 2019-05-08  Tom Tromey  <tom@tromey.com>
2243
2244         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2245         (fbsd_pspace_data_handle): Move lower.  Change type.
2246         (get_fbsd_pspace_data): Update.
2247         (fbsd_pspace_data_cleanup): Remove.
2248         (_initialize_fbsd_tdep): Update.
2249
2250 2019-05-08  Tom Tromey  <tom@tromey.com>
2251
2252         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2253         (get_ada_tasks_pspace_data): Update.
2254         (ada_tasks_pspace_data_cleanup): Remove.
2255         (_initialize_tasks): Update.
2256         (ada_tasks_inferior_data_handle): Change type.
2257         (get_ada_tasks_inferior_data): Update.
2258         (ada_tasks_inferior_data_cleanup): Remove.
2259         (struct ada_tasks_pspace_data): Add initializers.
2260
2261 2019-05-08  Tom Tromey  <tom@tromey.com>
2262
2263         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2264         * symfile-debug.c (debug_sym_get_probes): Change type.
2265         * stap-probe.c (handle_stap_probe):
2266         (stap_static_probe_ops::get_probes): Change type.
2267         * probe.h (class static_probe_ops) <get_probes>: Change type.
2268         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2269         (parse_probes_in_pspace): Update.
2270         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2271         Update.
2272         (any_static_probe_ops::get_probes): Change type.
2273         * elfread.c (elfread_data): New typedef.
2274         (probe_key): Change type.
2275         (elf_get_probes): Likewise.  Update.
2276         (probe_key_free): Remove.
2277         (_initialize_elfread): Update.
2278         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2279         Change type.
2280         (dtrace_process_dof_probe, dtrace_process_dof)
2281         (dtrace_static_probe_ops::get_probe): Change type.
2282
2283 2019-05-08  Tom Tromey  <tom@tromey.com>
2284
2285         * xcoffread.c (struct xcoff_symfile_info): Rename from
2286         coff_symfile_info.  Add initializers.
2287         (xcoff_objfile_data_key): Move lower.  Change type.
2288         (XCOFF_DATA): Rewrite.
2289         (xcoff_free_info): Remove.
2290         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2291         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2292         (xcoff_initial_scan): Update.
2293
2294 2019-05-08  Tom Tromey  <tom@tromey.com>
2295
2296         * solib-svr4.c (struct svr4_info): Add initializers and
2297         destructor.
2298         <probes_table>: Now an htab_up.
2299         (solib_svr4_pspace_data): Change type.
2300         (free_probes_table): Simplify.
2301         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2302         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2303         (probes_table_remove_objfile_probes, register_solib_event_probe)
2304         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2305         (_initialize_svr4_solib): Update.
2306
2307 2019-05-08  Tom Tromey  <tom@tromey.com>
2308
2309         * remote.c (remote_pspace_data): Change type.
2310         (remote_pspace_data_cleanup): Remove.
2311         (get_remote_exec_file, set_pspace_remote_exec_file)
2312         (_initialize_remote): Update.
2313
2314 2019-05-08  Tom Tromey  <tom@tromey.com>
2315
2316         * breakpoint.c (breakpoint_objfile_key): Change type.
2317         (get_breakpoint_objfile_data): Update.
2318         (free_breakpoint_objfile_data): Remove.
2319         (_initialize_breakpoint): Update.
2320
2321 2019-05-08  Tom Tromey  <tom@tromey.com>
2322
2323         * linux-tdep.c (struct linux_info): Add initializers.
2324         (linux_inferior_data): Move.  Change type.
2325         (invalidate_linux_cache_inf): Update.
2326         (linux_inferior_data_cleanup): Remove.
2327         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2328
2329 2019-05-08  Tom Tromey  <tom@tromey.com>
2330
2331         * auxv.c (auxv_inferior_data): Move.  Change type.
2332         (auxv_inferior_data_cleanup): Remove.
2333         (invalidate_auxv_cache_inf): Rewrite.
2334         (get_auxv_inferior_data, _initialize_auxv): Update.
2335
2336 2019-05-08  Tom Tromey  <tom@tromey.com>
2337
2338         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2339         (symfile_debug_objfile_data_key): Change type.
2340         (symfile_debug_installed, debug_qf_has_symbols)
2341         (debug_qf_find_last_source_symtab)
2342         (debug_qf_forget_cached_source_info)
2343         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2344         (debug_qf_print_stats, debug_qf_dump)
2345         (debug_qf_expand_symtabs_for_function)
2346         (debug_qf_expand_all_symtabs)
2347         (debug_qf_expand_symtabs_with_fullname)
2348         (debug_qf_map_matching_symbols)
2349         (debug_qf_expand_symtabs_matching)
2350         (debug_qf_find_pc_sect_compunit_symtab)
2351         (debug_qf_map_symbol_filenames)
2352         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2353         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2354         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2355         (debug_sym_read_linetable, debug_sym_relocate): Update.
2356         (symfile_debug_free_objfile): Remove.
2357         (install_symfile_debug_logging, _initialize_symfile_debug):
2358         Update.
2359
2360 2019-05-08  Tom Tromey  <tom@tromey.com>
2361
2362         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2363         allocate_on_obstack.
2364         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2365         (get_dwarf2_per_objfile): Update.
2366         (set_dwarf2_per_objfile): Remove.
2367         (dwarf2_has_info, dwarf2_get_section_info): Update.
2368         (dwarf2_free_objfile): Remove.
2369         (_initialize_dwarf2_read): Update.
2370
2371 2019-05-08  Tom Tromey  <tom@tromey.com>
2372
2373         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2374         initializers.
2375         <unsupported_script_warning_printed,
2376         script_not_found_warning_printed>: Now bool.
2377         (auto_load_pspace_data): Change type.
2378         (~auto_load_pspace_info): Rename from
2379         auto_load_pspace_data_cleanup.
2380         (get_auto_load_pspace_data, init_loaded_scripts_info)
2381         (clear_section_scripts, maybe_print_unsupported_script_warning)
2382         (maybe_print_script_not_found_warning, _initialize_auto_load):
2383         Update.
2384
2385 2019-05-08  Tom Tromey  <tom@tromey.com>
2386
2387         * objfiles.c (objfile_pspace_info): Add destructor and
2388         initializers.
2389         (objfiles_pspace_data): Change type.
2390         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2391         (get_objfile_pspace_data): Update.
2392         (objfiles_bfd_data): Change type.
2393         (get_objfile_bfd_data): Update.
2394         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2395
2396 2019-05-08  Tom Tromey  <tom@tromey.com>
2397
2398         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2399         Change type.
2400         (get_catch_syscall_inferior_data): Update.
2401         (catch_syscall_inferior_data_cleanup): Remove.
2402         (_initialize_break_catch_syscall): Update.
2403
2404 2019-05-08  Tom Tromey  <tom@tromey.com>
2405
2406         * inflow.c (struct terminal_info): Add destructor and
2407         initializers.
2408         (inflow_inferior_data): Change type.
2409         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2410         (get_inflow_inferior_data, inflow_inferior_exit)
2411         (swap_terminal_info, _initialize_inflow): Update.
2412
2413 2019-05-08  Tom Tromey  <tom@tromey.com>
2414
2415         * target-dcache.c (target_dcache_cleanup): Remove.
2416         (target_dcache_aspace_key): Change type.
2417         (target_dcache_init_p, target_dcache_invalidate)
2418         (target_dcache_get, target_dcache_get_or_init)
2419         (_initialize_target_dcache): Update.
2420         * dcache.h (struct dcache_deleter): New.
2421
2422 2019-05-08  Tom Tromey  <tom@tromey.com>
2423
2424         * symtab.c (struct symbol_cache): Add destructor and
2425         initializers.
2426         (symbol_cache_key): Move.  Change type.
2427         (make_symbol_cache, free_symbol_cache): Remove.
2428         (get_symbol_cache): Update.
2429         (symbol_cache_cleanup): Remove.
2430         (ALL_PSPACES, symbol_cache_flush)
2431         (maintenance_print_symbol_cache)
2432         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2433         Update.
2434
2435 2019-05-08  Tom Tromey  <tom@tromey.com>
2436
2437         * symtab.c (struct main_info): Add destructor and initializers.
2438         (main_progspace_key): Move.  Change type.
2439         (get_main_info): Update.
2440         (main_info_cleanup): Remove.
2441         (_initialize_symtab): Update.
2442
2443 2019-05-08  Tom Tromey  <tom@tromey.com>
2444
2445         * registry.h (DECLARE_REGISTRY): Define the _key class.
2446
2447 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2448
2449         * NEWS: Merge two 'New commands' sections.
2450
2451 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2452
2453         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2454         parameter and use Ada language definition instead.
2455         (ada_val_print_ptr): Remove unused language parameter.
2456         (ada_val_print_num): Remove language parameter and use Ada language
2457         definition instead.
2458         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2459         parameter.
2460         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2461         parameter and use Ada language definition instead.
2462         (ada_val_print_1): Update all ada_val_print_xxx calls.
2463         Remove language parameter.
2464         (ada_val_print): Update ada_val_print_1 call.
2465
2466 2019-05-08  Tom Tromey  <tromey@adacore.com>
2467
2468         * remote.c (remote_hw_watchpoint_limit)
2469         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2470         Now static.
2471
2472 2019-05-08  Tom Tromey  <tromey@adacore.com>
2473
2474         * maint.c (_initialize_maint_cmds): Move initialization code to
2475         remote.c.
2476         (watchdog, show_watchdog): Move to remote.c.
2477         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2478         "watchdog" static.
2479         (_initialize_remote): Move initialization code from maint.c.
2480         * defs.h (watchdog): Don't declare.
2481
2482 2019-05-08  Tom Tromey  <tromey@adacore.com>
2483
2484         * tui/tui-interp.c: Include main.h.
2485         * interps.c: Include main.h.
2486         * main.h (interpreter_p): Declare.
2487         * defs.h (interpreter_p): Don't declare.
2488
2489 2019-05-08  Tom Tromey  <tromey@adacore.com>
2490
2491         * dwarf2loc.c: Include dwarf2read.h.
2492         * defs.h (read_unsigned_leb128): Don't declare.
2493         * dwarf2read.h (read_unsigned_leb128): Declare.
2494
2495 2019-05-08  Tom Tromey  <tromey@adacore.com>
2496
2497         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2498         method.
2499
2500 2019-05-08  Tom Tromey  <tromey@adacore.com>
2501
2502         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2503         when no wrap column is set.
2504
2505 2019-05-08  Tom Tromey  <tromey@adacore.com>
2506
2507         * c-lang.c (c_get_string): Handle non-C-style arrays.
2508
2509 2019-05-08  Tom Tromey  <tromey@adacore.com>
2510
2511         * typeprint.c (print_offset_data::update): Print the bit offset,
2512         not the number of bits remaining.
2513
2514 2019-05-08  Tom Tromey  <tromey@adacore.com>
2515
2516         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2517         padding at end of comment.
2518
2519 2019-05-08  Tom Tromey  <tromey@adacore.com>
2520
2521         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2522         Compare main types.
2523
2524 2019-05-06  Tom Tromey  <tom@tromey.com>
2525
2526         * common/scoped_mmap.c: Include common-defs.h.
2527         * common/scoped_mmap.h: Don't include config.h.
2528
2529 2019-05-04  Tom Tromey  <tom@tromey.com>
2530
2531         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2532         (struct aarch64_call_info): Add initializers.
2533         <si>: Now a std::vector.
2534         (pass_on_stack, aarch64_push_dummy_call): Update.
2535
2536 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2537             Tom Tromey  <tom@tromey.com>
2538
2539         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2540         (ppc_threads): Now a std::vector.  Now static.
2541         (hwdebug_find_thread_points_by_tid)
2542         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2543         Update.
2544
2545 2019-05-04  Tom Tromey  <tom@tromey.com>
2546
2547         * arc-tdep.c (arc_tdesc_init): Return bool.
2548
2549 2019-05-04  Tom Tromey  <tom@tromey.com>
2550
2551         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2552         Use gdb_assert_not_reached.
2553
2554 2019-05-04  Tom Tromey  <tom@tromey.com>
2555
2556         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2557         "false".
2558
2559 2019-05-04  Tom Tromey  <tom@tromey.com>
2560
2561         * arc-tdep.c (arc_tdesc_init): Use bool.
2562
2563 2019-05-04  Tom Tromey  <tom@tromey.com>
2564
2565         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2566
2567 2019-05-04  Tom Tromey  <tom@tromey.com>
2568
2569         * cli/cli-cmds.c (valid_command_p): Return bool.
2570
2571 2019-05-04  Tom Tromey  <tom@tromey.com>
2572
2573         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2574         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2575
2576 2019-05-04  Raul Tambre  <raul@tambre.ee>
2577
2578         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2579         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2580         operator for comparison.
2581
2582 2019-05-04  Tom Tromey  <tom@tromey.com>
2583
2584         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2585         (lookup_partial_symbol, print_partial_symbols)
2586         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2587         (psymbol_compare): Update.
2588         (add_psymbol_to_bcache): Clear the entire psymbol.
2589         (maintenance_check_psymtabs): Update.
2590         * psympriv.h (struct partial_symbol): Don't derive from
2591         general_symbol_info.
2592         <obj_section, unrelocated_address, address,
2593         set_unrelocated_address>: Update.
2594         <ginfo>: New member.
2595         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2596         (debug_names::write_psymbols): Update.
2597
2598 2019-05-04  Tom de Vries  <tdevries@suse.de>
2599
2600         * contrib/cc-with-tweaks.sh: Support -n arg.
2601
2602 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2603
2604         * corelow.c (core_target::detach): Ensure frame cache and
2605         register caches are cleared.
2606         inferior.c (exit_inferior_1): Likewise.
2607
2608 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2609             Tom Tromey  <tom@tromey.com>
2610
2611         * dictionary.c (collate_pending_symbols_by_language): Remove
2612         "struct" from foreach.
2613         * symtab.c (lookup_global_symbol_from_objfile)
2614         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2615         foreach.
2616         * ser-tcp.c (net_open): Remove "struct" from foreach.
2617         * objfiles.c (objfile_relocate, objfile_rebase)
2618         (objfile_has_symbols): Remove "struct" from foreach.
2619         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2620         from foreach.
2621         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2622         foreach.
2623         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2624         "struct" from foreach.
2625         * ada-lang.c (create_excep_cond_exprs)
2626         (ada_exception_catchpoint_cond_string): Remove "struct" from
2627         foreach.
2628
2629 2019-05-03  Tom Tromey  <tromey@adacore.com>
2630
2631         * ada-exp.y (convert_char_literal): Check suffix of each
2632         enumerator.
2633
2634 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2635
2636         PR ada/21406:
2637         * ada-exp.y (yywrap): Don't define.
2638         * ada-lex.l (%option): Add noyywrap
2639         (yywrap): Remove.
2640
2641 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2642
2643         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2644         _WIN32_WINNT to the XP level, unless already defined to a higher
2645         level.
2646
2647         * unittests/parse-connection-spec-selftests.c:
2648         * ser-tcp.c:
2649         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2650         override.
2651
2652         * symfile.c (find_separate_debug_file): Remove colon from the
2653         drive spec of DOS/Windows file names of the target, so that the
2654         file name produced from DEBUGDIR and the target's directory will
2655         be valid on DOS/Windows systems.
2656
2657 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2658
2659         * rust-lang.c (val_print_struct): Handle printing structures
2660         containing strings.
2661
2662 2019-05-02  Tom Tromey  <tromey@adacore.com>
2663
2664         * valarith.c (_initialize_valarith): Remove.
2665
2666 2019-05-01  Tom Tromey  <tromey@adacore.com>
2667
2668         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2669         bitfields.
2670
2671 2019-05-01  Tom Tromey  <tromey@adacore.com>
2672
2673         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2674         for big-endian copies.
2675
2676 2019-04-30  Ali Tamur  <tamur@google.com>
2677         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2678         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2679         (read_3_bytes): New function.
2680
2681 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2682
2683         * windows-nat.c (main_thread_id): Delete.
2684         (handle_output_debug_string): Replace main_thread_id by
2685         current_event.dwThreadId.
2686         (fake_create_process): Likewise.
2687         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2688         Do not set main_thread_id.
2689         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2690         current_event.dwThreadId.
2691         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2692
2693 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2694
2695         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2696         Use current_event.dwThreadId instead of main_thread_id.
2697
2698 2019-04-30  Tom Tromey  <tromey@adacore.com>
2699
2700         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2701         (create_excep_cond_exprs): Iterate over program spaces.
2702         (ada_exception_catchpoint_cond_string): Examine all minimal
2703         symbols for exception types.
2704
2705 2019-04-30  Tom Tromey  <tromey@adacore.com>
2706
2707         PR c++/24470:
2708         * dwarf2read.c (process_structure_scope): Handle case where type
2709         has template parameters but no symbol was created.
2710
2711 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2712             Chris January  <chris.january@arm.com>
2713
2714         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2715         qualifier.
2716         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2717
2718 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2719
2720         * f-typeprint.c (f_print_type): Update rules for printing
2721         whitespace.
2722         (f_type_print_varspec_suffix): Likewise.
2723
2724 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2725             Chris January  <chris.january@arm.com>
2726
2727         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2728         function arguments.
2729
2730 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2731
2732         * f-lang.c (build_fortran_types): Change name of void type to
2733         lower case.
2734         * f-typeprint.c (f_type_print_base): Print the name of the void
2735         type, rather than a fixed string.
2736         * f-valprint.c (f_decorations): Use lower case void string.
2737
2738 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2739             Chris January  <chris.january@arm.com>
2740
2741         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2742         types for Fortran.
2743
2744 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2745             Chris January  <chris.january@arm.com>
2746             David Lecomber  <david.lecomber@arm.com>
2747
2748         * f-exp.y (BINOP_INTRINSIC): New token.
2749         (exp): New parser rule handling BINOP_INTRINSIC.
2750         (f77_keywords): Add new builtin procedures.
2751         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2752         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2753         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2754         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2755         (print_unop_subexp_f): New function.
2756         (print_binop_subexp_f): New function.
2757         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2758         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2759         (dump_subexp_body_f): Likewise.
2760         (operator_check_f): Likewise.
2761         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2762         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2763
2764 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2765
2766         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2767         UNOP_KIND.
2768         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2769         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2770         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2771         (operator_length_f): New fuction.
2772         (print_subexp_f): New function.
2773         (op_name_f): New function.
2774         (dump_subexp_body_f): New function.
2775         (operator_check_f): New function.
2776         (exp_descriptor_f): Replace standard expression handling functions
2777         with new functions.
2778         * gdb/fortran-operator.def: New file.
2779         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2780         * gdb/std-operator.def: Remove UNOP_KIND.
2781
2782 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2783
2784         * std-operator.def: Remove unbalanced, stray double quote
2785         character.
2786
2787 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2788             Chris January  <chris.january@arm.com>
2789             Daniel Everett  <daniel.everett@arm.com>
2790             Nick Forrington  <nick.forrington@arm.com>
2791             Richard Bunt  <richard.bunt@arm.com>
2792
2793         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2794         of depth when printing anonymous structs or unions.
2795         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2796         Don't print either the top-level value, or the children if the
2797         max-depth is exceeded.
2798         (ppscm_print_children): When printing the key of a map, allow one
2799         extra level of depth.
2800         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2801         print either the top-level value, or the children if the max-depth
2802         is exceeded.
2803         (print_children): When printing the key of a map, allow one extra
2804         level of depth.
2805         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2806         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2807         (user_print_options): Initialise max_depth field.
2808         (val_print_scalar_or_string_type_p): New function.
2809         (val_print): Check to see if the max depth has been reached.
2810         (val_print_check_max_depth): Define new function.
2811         (show_print_max_depth): New function.
2812         (_initialize_valprint): Add 'print max-depth' option.
2813         * valprint.h (struct value_print_options) <max_depth>: New field.
2814         (val_print_check_max_depth): Declare new function.
2815         * NEWS: Document new feature.
2816
2817 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2818
2819         * ada-lang.c (ada_language_defn): Initialise new field.
2820         * c-lang.c (c_is_string_type_p): New function.
2821         (c_language_defn): Initialise new field.
2822         (cplus_language_defn): Initialise new field.
2823         (asm_language_defn): Initialise new field.
2824         (minimal_language_defn): Initialise new field.
2825         * c-lang.h (c_is_string_type_p): Declare new function.
2826         * d-lang.c (d_language_defn): Initialise new field.
2827         * f-lang.c (f_is_string_type_p): New function.
2828         (f_language_defn): Initialise new field.
2829         * go-lang.c (go_is_string_type_p): New function.
2830         (go_language_defn): Initialise new field.
2831         * language.c (default_is_string_type_p): New function.
2832         (unknown_language_defn): Initialise new field.
2833         (auto_language_defn): Initialise new field.
2834         * language.h (struct language_defn) <la_is_string_type_p>: New
2835         member variable.
2836         (default_is_string_type_p): Declare new function.
2837         * m2-lang.c (m2_language_defn): Initialise new field.
2838         * objc-lang.c (objc_language_defn): Initialise new field.
2839         * opencl-lang.c (opencl_language_defn): Initialise new field.
2840         * p-lang.c (pascal_is_string_type_p): New function.
2841         (pascal_language_defn): Initialise new field.
2842         * rust-lang.c (rust_is_string_type_p): New function.
2843         (rust_language_defn): Initialise new field.
2844
2845 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2846
2847         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2848         New field.
2849         * ada-lang.c (ada_language_defn): Initialise new field.
2850         * c-lang.c (c_language_defn): Likewise.
2851         (cplus_language_defn): Likewise.
2852         (asm_language_defn): Likewise.
2853         (minimal_language_defn): Likewise.
2854         * d-lang.c (d_language_defn): Likewise.
2855         * f-lang.c (f_language_defn): Likewise.
2856         * go-lang.c (go_language_defn): Likewise.
2857         * language.c (unknown_language_defn): Likewise.
2858         (auto_language_defn): Likewise.
2859         * m2-lang.c (m2_language_defn): Likewise.
2860         * objc-lang.c (objc_language_defn): Likewise.
2861         * opencl-lang.c (opencl_language_defn): Likewise.
2862         * p-lang.c (pascal_language_defn): Likewise.
2863         * rust-lang.c (rust_language_defn): Likewise.
2864
2865 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * ada-lang.c (ada_is_character_type): Change return type to bool.
2868         (ada_is_string_type): Likewise.
2869         * ada-lang.h (ada_is_character_type): Update declaration
2870         (ada_is_string_type): Likewise.
2871
2872 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2873
2874         Support style in 'frame|thread apply'
2875
2876         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2877         * record.c (record_start, record_stop): Update callers of
2878         execute_command_to_string with false.
2879         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2880         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2881         methods.
2882         (class string_file): New constructor with term_out parameter.
2883         Override methods term_out and can_emit_style_escape.  New member
2884         term_out.
2885         (class stdio_file): Override can_emit_style_escape.
2886         (class tee_file): Override term_out and can_emit_style_escape.
2887         * utils.h (can_emit_style_escape): Remove.
2888         * utils.c (can_emit_style_escape): Likewise.
2889         Update all callers of can_emit_style_escape (SOMESTREAM) to
2890         SOMESTREAM->can_emit_style_escape.
2891         * source-cache.c (source_cache::get_source_lines): Likewise.
2892         * stack.c (frame_apply_command_count): Call execute_command_to_string
2893         passing the term_out characteristic of the current gdb_stdout.
2894         * thread.c (thr_try_catch_cmd): Likewise.
2895         * top.c (execute_command_to_string): pass term_out parameter
2896         to construct the string_file for the command output.
2897         * ui-file.c (term_cli_styling): New function (most code moved
2898         from utils.c can_emit_style_escape).
2899         (string_file::string_file, string_file::can_emit_style_escape,
2900         stdio_file::can_emit_style_escape, tee_file::term_out,
2901         tee_file::can_emit_style_escape): New functions.
2902
2903 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2904
2905         * NEWS: Mention the new set|show may-call-functions.
2906         * infcall.c (may_call_functions_p): New variable.
2907         (show_may_call_functions_p): New function.
2908         (call_function_by_hand_dummy): Throws an error if not
2909         may-call-functions.
2910         (_initialize_infcall): Call add_setshow_boolean_cmd for
2911         may-call-functions.
2912
2913 2019-04-25  Keith Seitz  <keiths@redhat.com>
2914
2915         PR c++/24367
2916         * cp-support.c (inspect_type): Don't attempt substitutions
2917         of symbol with the same name.
2918
2919 2019-04-25  Tom Tromey  <tromey@adacore.com>
2920
2921         PR gdb/24475:
2922         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2923         static.
2924
2925 2019-04-25  Tom Tromey  <tromey@adacore.com>
2926
2927         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2928         rvalue reference.
2929         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2930         (gdb_xml_parser::parse): Use std::move.
2931         * python/python-internal.h (gdbpy_convert_exception): Take a const
2932         reference.
2933         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2934         std::move.
2935         * python/py-utils.c (gdbpy_convert_exception): Take a const
2936         reference.
2937         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2938         Use std::move.
2939         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2940         Use std::move.
2941         * mi/mi-main.c (mi_print_exception): Take a const reference.
2942         * main.c (handle_command_errors): Take a const reference.
2943         * linespec.c (parse_linespec): Use std::move.
2944         * infcall.c (run_inferior_call): Use std::move.
2945         (call_function_by_hand_dummy): Use std::move.
2946         * exec.c (try_open_exec_file): Use std::move.
2947         * exceptions.h (exception_print, exception_fprintf)
2948         (exception_print_same): Update.
2949         * exceptions.c (print_exception, exception_print)
2950         (exception_fprintf, exception_print_same): Change parameters to
2951         const reference.
2952         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2953         * common/new-op.c: Use std::move.
2954         * common/common-exceptions.h (struct gdb_exception): Add move
2955         constructor.
2956         (struct gdb_exception_error, struct gdb_exception_quit, struct
2957         gdb_quit_bad_alloc): Change constructor to move constructor.
2958         (throw_exception): Change parameter to rvalue reference.
2959         * common/common-exceptions.c (throw_exception): Take rvalue
2960         reference.
2961         * cli/cli-interp.c (safe_execute_command): Use std::move.
2962         * breakpoint.c (insert_bp_location, location_to_sals): Use
2963         std::move.
2964
2965 2019-04-25  Tom Tromey  <tromey@adacore.com>
2966
2967         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2968         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2969         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2970         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2971         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2972         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2973         guile/scm-value.c: Use unpack.
2974         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2975         gdbscm_gdb_exception.
2976         (gdbscm_throw_gdb_exception): Likewise.
2977         (struct gdbscm_gdb_exception): New.
2978         (unpack): New function.
2979         (gdbscm_wrap): Use unpack.
2980
2981 2019-04-25  Tom Tromey  <tromey@adacore.com>
2982
2983         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2984         (gdb_rl_callback_handler): Use std::move.
2985         * common/common-exceptions.h (struct gdb_exception): Add move
2986         assignment operator.
2987         (throw_exception_sjlj): Change "exception" to const reference.
2988         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2989         (throw_exception_sjlj): Change "exception" to const reference.
2990
2991 2019-04-25  Tom Tromey  <tromey@adacore.com>
2992
2993         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2994         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2995         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2996         Update.
2997         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2998         Update.
2999         * mi/mi-interp.c (mi_interp::exec): Update.
3000         * linespec.c (parse_linespec): Update.
3001         * infcall.c (run_inferior_call): Update.
3002         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3003         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3004         (gdbscm_lookup_global_symbol): Update.
3005         * guile/scm-param.c (gdbscm_parameter_value): Update.
3006         * guile/scm-frame.c (gdbscm_frame_read_register)
3007         (gdbscm_frame_read_var): Update.
3008         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3009         * exec.c (try_open_exec_file): Update.
3010         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3011         (gdb_rl_callback_handler): Update.
3012         * common/common-exceptions.h (exception_none): Don't declare.
3013         * common/common-exceptions.c (exception_none): Don't define.
3014         (struct catcher) <exception>: Update.
3015         * cli/cli-interp.c (safe_execute_command): Update.
3016         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3017
3018 2019-04-25  Ali Tamur  <tamur@google.com>
3019
3020         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3021         (read_attribute_value): Likewise.
3022         (dwarf2_read_addr_index): Update comment.
3023         (read_str_index): Add DW_FORM_strx.
3024         (dwarf2_string_attr): Likewise.
3025         (dwarf2_const_value_attr): Likewise.
3026         (dump_die_shallow): Likewise.
3027         (dwarf2_fetch_constant_bytes): Likewise.
3028         (skip_form_bytes): Likewise.
3029         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3030
3031 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3032
3033         PR corefiles/11608
3034         PR corefiles/18187
3035         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3036         OFFSET.  Verify if current mapping contains an ELF header.
3037         (linux_find_memory_regions_full): Adjust call to
3038         dump_mapping_p.
3039
3040 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3041             Kang Li <kanglictf@gmail.com>
3042
3043         PR gdb/21600
3044
3045         * dwarf2-frame.c (read_initial_length): Be consistent about using
3046         unsigned representation of length.
3047         (decode_frame_entry_1): Likewise.  Check for wraparound of
3048         end pointer as well as buffer overflow.
3049
3050 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3051
3052         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3053         "vq".
3054
3055 2019-04-24  Tom Tromey  <tromey@adacore.com>
3056
3057         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3058
3059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3060
3061         * s12z-tdep.c (s12z_unwind_pc): Delete.
3062         (s12z_unwind_sp): Delete.
3063         (s12z_gdbarch_init): Don't register deleted functions with
3064         gdbarch.
3065
3066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3067
3068         * rl78-tdep.c (rl78_unwind_sp): Delete.
3069         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3070
3071 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3072
3073         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3074         (xstormy16_unwind_pc): Delete.
3075         (xstormy16_dummy_id): Delete.
3076         (xstormy16_gdbarch_init): Don't register deleted functions with
3077         gdbarch.
3078
3079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3080
3081         * vax-tdep.c (vax_unwind_pc): Delete.
3082         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3083
3084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3085
3086         * v850-tdep.c (v850_unwind_sp): Delete.
3087         (v850_unwind_pc): Delete.
3088         (v850_dummy_id): Delete.
3089         (v850_gdbarch_init): Don't register deleted functions with
3090         gdbarch.
3091
3092 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3093
3094         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3095         (tilegx_unwind_pc): Delete.
3096         (tilegx_unwind_dummy_id): Delete.
3097         (tilegx_gdbarch_init): Don't register deleted functions with
3098         gdbarch.
3099
3100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3103         (tic6x_dummy_id): Delete.
3104         (tic6x_gdbarch_init): Don't register deleted functions with
3105         gdbarch.
3106
3107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3108
3109         * sparc-tdep.c (sparc_unwind_pc): Delete.
3110         (sparc32_gdbarch_init): Don't register deleted function with
3111         gdbarch.
3112
3113 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3114
3115         * sh-tdep.c (sh_unwind_sp): Delete.
3116         (sh_unwind_pc): Delete.
3117         (sh_dummy_id): Delete.
3118         (sh_gdbarch_init): Don't register deleted functions with
3119         gdbarch.
3120
3121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3122
3123         * score-tdep.c (score_unwind_sp): Delete.
3124         (score_unwind_pc): Delete.
3125         (score_dummy_id): Delete.
3126         (score_gdbarch_init): Don't register deleted functions with
3127         gdbarch.
3128
3129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3130
3131         * rx-tdep.c (rx_unwind_pc): Delete.
3132         (rx_unwind_sp): Delete.
3133         (rx_dummy_id): Delete.
3134         (rx_gdbarch_init): Don't register deleted functions with
3135         gdbarch.  Update comment.
3136
3137 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3138
3139         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3140         (rs6000_dummy_id): Delete.
3141         (rs6000_gdbarch_init): Don't register deleted functions with
3142         gdbarch.
3143
3144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3145
3146         * or1k-tdep.c (or1k_dummy_id): Delete.
3147         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3148
3149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3150
3151         * nios2-tdep.c (nios2_dummy_id): Delete.
3152         (nios2_unwind_sp): Delete.
3153         (nios2_gdbarch_init): Don't register deleted functions with
3154         gdbarch.
3155
3156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3157
3158         * nds32-tdep.c (nds32_dummy_id): Delete.
3159         (nds32_unwind_pc): Delete.
3160         (nds32_unwind_sp): Delete.
3161         (nds32_gdbarch_init): Don't register deleted functions with
3162         gdbarch.
3163
3164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3165
3166         * msp430-tdep.c (msp430_unwind_pc): Delete.
3167         (msp430_unwind_sp): Delete.
3168         (msp430_dummy_id): Delete.
3169         (msp430_gdbarch_init): Don't register deleted functions with
3170         gdbarch.
3171
3172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3173
3174         * moxie-tdep.c (moxie_unwind_sp): Delete.
3175         (moxie_unwind_pc): Delete.
3176         (moxie_dummy_id): Delete.
3177         (moxie_gdbarch_init): Don't register deleted functions with
3178         gdbarch.
3179
3180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3181
3182         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3183         (mn10300_unwind_pc): Delete.
3184         (mn10300_unwind_sp): Delete.
3185         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3186         mn10300_unwind_sp.
3187         (mn10300_frame_unwind_init): Don't register deleted functions with
3188         gdbarch.
3189
3190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3191
3192         * mep-tdep.c (mep_unwind_pc): Delete.
3193         (mep_unwind_sp): Delete.
3194         (mep_dummy_id): Delete.
3195         (mep_gdbarch_init): Don't register deleted functions with
3196         gdbarch.
3197
3198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3201         (m68hc11_unwind_sp): Delete.
3202         (m68hc11_gdbarch_init): Don't register deleted functions with
3203         gdbarch.
3204
3205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * m32r-tdep.c (m32r_unwind_sp): Delete.
3208         (m32r_unwind_pc): Delete.
3209         (m32r_dummy_id): Delete.
3210         (m32r_gdbarch_init): Don't register deleted functions with
3211         gdbarch.
3212
3213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3214
3215         * m32c-tdep.c (m32c_unwind_pc): Delete.
3216         (m32c_unwind_sp): Delete.
3217         (m32c_dummy_id): Delete.
3218         (m32c_gdbarch_init): Don't register deleted functions with
3219         gdbarch.
3220
3221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3222
3223         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3224         (lm32_unwind_pc): Delete.
3225         (lm32_dummy_id): Delete.
3226         (lm32_gdbarch_init): Don't register deleted functions with
3227         gdbarch.
3228
3229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3230
3231         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3232         (iq2000_unwind_pc): Delete.
3233         (iq2000_dummy_id): Delete.
3234         (iq2000_gdbarch_init): Don't register deleted functions with
3235         gdbarch.
3236
3237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3238
3239         * nds32-tdep.c (nds32_type_align): Delete.
3240         (nds32_push_dummy_call): Use type_align instead.
3241
3242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3243
3244         * arm-tdep.c (arm_type_align): Only handle vector override case.
3245         (arm_push_dummy_call): Use type_align.
3246         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3247
3248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3249
3250         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3251         case.
3252         (pass_on_stack): Use type_align.
3253         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3254         function.
3255
3256 2019-04-23  Tom Tromey  <tromey@adacore.com>
3257
3258         * dwarf2read.c (line_header::file_name_at): Remove unused
3259         overload.
3260
3261 2019-04-23  Tom de Vries  <tdevries@suse.de>
3262
3263         PR gdb/24438
3264         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3265         invocation.
3266
3267
3268 2019-03-27  Ali Tamur  <tamur@google.com>
3269
3270         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3271         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3272         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3273         (dwarf_expr_context::get_addr_index): Likewise
3274         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3275         (symbol_needs_eval_context::get_addr_index): Likewise
3276         (disassemble_dwarf_expression): Add DW_OP_addrx
3277         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3278         (read_cutu_die_from_dwo): Update comment
3279         (skip_one_die): Add DW_FORM_addrx
3280         (read_attribute_value): Likewise
3281         (var_decode_location): Add DW_OP_addrx
3282         (dwarf2_const_value_attr): Add DW_FORM_addrx
3283         (dump_die_shallow): Likewise
3284         (dwarf2_fetch_constant_bytes): Likewise
3285         (decode_locdesc): Add DW_OP_addrx
3286         (skip_form_bytes): Add DW_FORM_addrx
3287
3288 2019-04-22  Ali Tamur  <tamur@google.com>
3289
3290         * MAINTAINERS (Write After Approval): Add self.
3291
3292 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3293
3294         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3295         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3296         (open_symbol_file_object): Likewise.
3297         (svr4_default_sos): Add info parameter.
3298         (svr4_read_so_list): Likewise.
3299         (svr4_current_sos_direct): Adjust functions calls to pass down
3300         info.
3301         (svr4_current_sos_1): Add info parameter.
3302         (svr4_current_sos): Call get_svr4_info, pass info down to
3303         svr4_current_sos_1.
3304         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3305         get_svr4_info.
3306         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3307         get_svr4_info.
3308         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3309         to get_svr4_info.
3310         (probes_table_remove_objfile_probes): Likewise.
3311         (register_solib_event_probe): Add info parameter.
3312         (solist_update_incremental): Pass info parameter down to
3313         svr4_read_so_list.
3314         (disable_probes_interface): Add info parameter.
3315         (svr4_handle_solib_event): Pass current_program_space to
3316         get_svr4_info.  Adjust disable_probes_interface cleanup.
3317         (svr4_create_probe_breakpoints): Add info parameter, pass it
3318         down to register_solib_event_probe.
3319         (svr4_create_solib_event_breakpoints): Add info parameter,
3320         pass it down to svr4_create_probe_breakpoints.
3321         (enable_break): Pass info down to
3322         svr4_create_solib_event_breakpoints.
3323         (svr4_solib_create_inferior_hook): Pass current_program_space to
3324         get_svr4_info.
3325         (svr4_clear_solib): Likewise.
3326
3327 2019-04-22  Pedro Alves  <palves@redhat.com>
3328
3329         * solib-svr4.c (svr4_free_objfile_observer): New.
3330         (probe_and_action::objfile): New field.
3331         (probes_table_htab_remove_objfile_probes)
3332         (probes_table_remove_objfile_probes): New functions.
3333         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3334         in the new probe_and_action.  Don't store the probe in 'lookup'.
3335         (svr4_create_probe_breakpoints): Pass objfile to
3336         register_solib_event_probe.
3337         (_initialize_svr4_solib): Register a free_objfile observer.
3338
3339 2019-04-19  Tom Tromey  <tom@tromey.com>
3340
3341         * common/queue.h: Remove.
3342
3343 2019-04-19  Tom Tromey  <tom@tromey.com>
3344
3345         * event-loop.c: Don't include "common/queue.h".
3346
3347 2019-04-19  Tom Tromey  <tom@tromey.com>
3348
3349         * remote.c (remote_target): Use delete.
3350         * remote-notif.h: Include <list>, not "common/queue.h".
3351         (notif_client_p): Remove typedef.
3352         (remote_notif_state): Add constructor, destructor, initializer.
3353         <notif_queue>: Now a std::list.
3354         (remote_notif_state_xfree): Don't declare.
3355         * remote-notif.c (remote_notif_process, handle_notification)
3356         (remote_notif_state_allocate): Update.
3357         (~remote_notif_state): Rename from remote_notif_state_xfree.
3358
3359 2019-04-19  Tom Tromey  <tom@tromey.com>
3360
3361         * symfile.c (reread_symbols): Update.
3362         * objfiles.c (objfile_register_static_link)
3363         (objfile_lookup_static_link): Update
3364         (~objfile) Don't delete static_links.
3365         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3366
3367 2019-04-19  Tom Tromey  <tom@tromey.com>
3368
3369         * type-stack.h (struct type_stack) <insert>: Constify string.
3370         * type-stack.c (type_stack::insert): Constify string.
3371         * gdbtypes.h (lookup_template_type): Update.
3372         (address_space_name_to_int): Update.
3373         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3374         const.
3375         (lookup_template_type): Make name const.
3376         * c-exp.y: Update rules.
3377         (lex_one_token, classify_name, classify_inner_name)
3378         (c_print_token): Update.
3379         * p-exp.y: Update rules.
3380         (yylex): Update.
3381         * f-exp.y: Update rules.
3382         (yylex): Update.
3383         * d-exp.y: Update rules.
3384         (lex_one_token, classify_name, classify_inner_name): Update.
3385         * parse.c (write_dollar_variable, copy_name): Return std::string.
3386         * parser-defs.h (copy_name): Change return type.
3387         * m2-exp.y: Update rules.
3388         (yylex): Update.
3389         * go-exp.y (lex_one_token): Update.
3390         Update rules.
3391         (classify_unsafe_function, classify_packaged_name)
3392         (classify_name, yylex): Update.
3393
3394 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3395
3396         * configure.ac: add --enable-source-highlight switch.
3397         * configure: Regenerate.
3398         * top.c (print_gdb_version): plumb --enable-source-highlight
3399         status to "show configuration".
3400
3401 2019-04-19  Tom Tromey  <tromey@adacore.com>
3402
3403         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3404         Check ADA_TYPE_P.
3405         (empty_record, ada_template_to_fixed_record_type_1)
3406         (template_to_static_fixed_type)
3407         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3408         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3409         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3410         macros.
3411
3412 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3413
3414         PR symtab/24423:
3415         * source.c (print_source_lines_base): Advance "iter" when a
3416         control character is seen.
3417
3418 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3419
3420         * inferior.h (struct infcall_suspend_state_deleter):
3421         Catch exception in destructor to avoid crash.
3422
3423 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3424
3425         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3426         close to the add_com "shell".
3427
3428 2019-04-18  Tom Tromey  <tromey@adacore.com>
3429
3430         * process-stratum-target.h (class process_stratum_target)
3431         <stratum>: Add "final".
3432
3433 2019-04-17  Tom Tromey  <tromey@adacore.com>
3434
3435         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3436         against nullptr before use.
3437
3438 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3439
3440         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3441
3442 2019-04-17  Jim Wilson  <jimw@sifive.com>
3443             Andrew Burgess  <andrew.burgess@embecosm.com>
3444
3445         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3446         code read might fail, assume 4-byte breakpoint in that case.
3447
3448 2019-04-15  Leszek Swirski  <leszeks@google.com>
3449
3450         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3451         rather than a hand-rolled POD check when checking for forced MEMORY
3452         classification.
3453
3454 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3455
3456         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3457         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3458         function.
3459         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3460         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3461         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3462         declaration.
3463
3464 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3465
3466         * aarch64-linux-nat.c
3467         (aarch64_linux_nat_target::thread_architecture): Add override.
3468         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3469         each VQ.
3470
3471 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3472
3473         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3474
3475 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3476
3477         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3478         target types of size 96-bits, add some additional comments, and
3479         check that the builtin type we found was the correct size.
3480
3481 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3482
3483         * utils.c (prompt_for_continue): Don't restore the styling at the
3484         end, as applied_style has the wrong value.  This fixes styling in
3485         long lists of file names that are interrupted by the "Continue?"
3486         prompt.
3487
3488 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3491         * c-lang.c (c_language_defn): Likewise.
3492         (cplus_language_defn): Likewise.
3493         (asm_language_defn): Likewise.
3494         (minimal_language_defn): Likewise.
3495         * d-lang.c (d_language_defn): Likewise.
3496         * f-lang.c (f_language_defn): Likewise.
3497         * go-lang.c (go_language_defn): Likewise.
3498         * language.c (unknown_language_defn): Likewise.
3499         (auto_language_defn): Likewise.
3500         * language.h (struct language_defn): Remove la_magic field.
3501         (LANG_MAGIC): Delete.
3502         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3503         * objc-lang.c (objc_language_defn): Likewise.
3504         * opencl-lang.c (opencl_language_defn): Likewise.
3505         * p-lang.c (pascal_language_defn): Likewise.
3506         * rust-lang.c (rust_language_defn): Likewise.
3507
3508 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3509
3510         * riscv-tdep.c (riscv_type_align): New function.
3511         (riscv_type_alignment): Delete.
3512         (riscv_arg_location): Use 'type_align'.
3513         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3514
3515 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3516
3517         * gdbtypes.c (type_align): A struct with no non-static fields also
3518         has alignment of 1.
3519
3520 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3521
3522         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3523         component to 0.
3524         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3525         member.
3526         (riscv_struct_info::analyse): New implementation using new
3527         analyse_inner member function.
3528         (riscv_struct_info::field_offset): New member function.
3529         (riscv_struct_info::m_offsets): New member variable.
3530         (riscv_struct_info::analyse_inner): New private member function,
3531         takes the old implementation of riscv_struct_info::analyse but
3532         extended to track field offsets.
3533         (riscv_call_arg_struct): Update the struct folding special cases
3534         to handle cases where empty C++ structs, which are non-zero
3535         length, are found.
3536         (riscv_arg_location): Initialise the length of each location, a
3537         non-zero length now indicates the location is in use.
3538         (riscv_push_dummy_call): Allow for the first location having a
3539         non-zero offset when setting up arguments.
3540         (riscv_return_value): Likewise, but for return values.
3541
3542 2019-04-11  Tom Tromey  <tromey@adacore.com>
3543
3544         * utils.c (internal_vproblem): Make "msg" const.
3545
3546 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3547
3548         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3549         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3550         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3551         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3552
3553 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3554
3555         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3556         function.
3557         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3558         of amd64_collect_native_gregset.
3559         (amd64_linux_nat_target::store_registers): Likewise.
3560
3561 2019-04-10  Tom Tromey  <tom@tromey.com>
3562
3563         * symtab.c (lookup_global_symbol_from_objfile)
3564         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3565         * objfiles.h (class separate_debug_iterator): New.
3566         (class separate_debug_range): New.
3567         (struct objfile) <separate_debug_objfiles>: New method.
3568         (objfile_separate_debug_iterate): Don't declare.
3569         * objfiles.c (separate_debug_iterator::operator++): Rename from
3570         objfile_separate_debug_iterate.
3571         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3572         iterator.
3573         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3574         iterator.
3575
3576 2019-04-10  Tom Tromey  <tom@tromey.com>
3577
3578         * symfile.c (reread_symbols): Remove old comment.
3579         * objfiles.c (free_all_objfiles): Fix a typo.
3580
3581 2019-04-10  Tom Tromey  <tom@tromey.com>
3582
3583         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3584         * minsyms.c (lookup_minimal_symbol): Use foreach.
3585         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3586         (lookup_minimal_symbol_solib_trampoline): Likewise.
3587         * symfile.c (reread_symbols): Use foreach.
3588
3589 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3590             Tom Tromey  <tromey@adacore.com>
3591
3592         PR rust/24414:
3593         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3594         (rust_lex_int_test): Change "value" to be LONGEST.
3595         (rust_lex_tests): Add test for long integer literal.
3596
3597 2019-04-09  Tom Tromey  <tromey@adacore.com>
3598
3599         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3600         to bool.
3601         (extended_remote_target::attach): Update.
3602         (remote_target::remote_notice_new_inferior): Update.
3603         (remote_target::add_current_inferior_and_thread): Update.
3604         * inferior.c (exit_inferior_1): Use "false".
3605         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3606
3607 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3608
3609         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3610         the "start" command.
3611
3612 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3613
3614         * python/py-inferior.c (infpy_thread_from_thread_handle):
3615         Adjust comments to reflect renaming of thread_from_thread_handle
3616         to thread_from_handle.  Adjust keywords.  Fix type error message.
3617         (inferior_object_methods): Add thread_from_handle.  Retain
3618         thread_from_thread_handle, but mark it as deprecated.
3619
3620 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3621
3622         * gdbthread.h (find_thread_by_handle): Revise declaration.
3623         * thread.c (find_thread_by_handle): Likewise.  Adjust
3624         implementation too.
3625         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3626         support for buffer objects as handles.
3627
3628 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3629
3630         * python/py-infthread.c (thpy_thread_handle): New function.
3631         (thread_object_methods): Register thpy_thread_handle.
3632
3633 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3634
3635         * gdbthread.h (thread_to_thread_handle): Declare.
3636         * thread.c (gdbtypes.h): Include.
3637         (thread_to_thread_handle): New function.
3638
3639         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3640         (target_thread_info_to_thread_handle): Declare.
3641         * target.c (target_thread_info_to_thread_handle): New function.
3642         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3643         * target-delegates.c: Regenerate.
3644
3645         * linux-thread-db.c (class thread_db_target): Add method
3646         thread_info_to_thread_handle.
3647         (thread_db_target::thread_info_to_thread_handle): Define.
3648         * remote.c (class remote_target): Add new method
3649         thread_info_to_thread_handle.
3650         (remote_target::thread_info_to_thread_handle): Define.
3651
3652 2019-04-08  Pedro Alves  <palves@redhat.com>
3653
3654         * common/common-exceptions.c (throw_exception): Don't create
3655         named object to throw; throw directly.
3656         (throw_it): Likewise.  Don't initialize gdb_exception::message
3657         here, with new; pass FMT and AP to the ctor instead.
3658         * common/common-exceptions.h: Include <string>.
3659         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3660         const char *, va_list)): New ctor.  Use std::make_shared.
3661         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3662         errors)): Delete.
3663         (gdb_exception_error::gdb_exception_error(enum errors, const char
3664         *, va_list)): New.
3665         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3666         Add assertion.
3667         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3668         errors)): Delete.
3669         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3670         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3671         Add assertion.
3672
3673 2019-04-08  Tom Tromey  <tom@tromey.com>
3674
3675         * valops.c (value_rtti_indirect_type): Replace throw_exception
3676         with throw.
3677         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3678         with throw.
3679         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3680         throw.
3681         * target.c (target_translate_tls_address): Replace throw_exception
3682         with throw.
3683         * stack.c (frame_apply_command_count): Replace throw_exception
3684         with throw.
3685         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3686         throw.
3687         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3688         with throw.
3689         * rs6000-tdep.c (rs6000_frame_cache)
3690         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3691         * remote.c: Replace throw_exception with throw.
3692         * record-full.c (record_full_message, record_full_wait_1)
3693         (record_full_restore): Replace throw_exception with throw.
3694         * record-btrace.c:
3695         (get_thread_current_frame_id, record_btrace_start_replaying)
3696         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3697         (cmd_record_btrace_start): Replace throw_exception with throw.
3698         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3699         throw.
3700         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3701         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3702         * linespec.c:
3703         (find_linespec_symbols): Replace throw_exception with throw.
3704         * infrun.c (displaced_step_prepare, resume): Replace
3705         throw_exception with throw.
3706         * infcmd.c (post_create_inferior): Replace throw_exception with
3707         throw.
3708         * inf-loop.c (inferior_event_handler): Replace throw_exception
3709         with throw.
3710         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3711         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3712         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3713         (get_prev_frame_always, get_frame_pc_if_available)
3714         (get_frame_address_in_block_if_available, get_frame_language):
3715         Replace throw_exception with throw.
3716         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3717         throw_exception with throw.
3718         * eval.c (fetch_subexp_value, evaluate_var_value)
3719         (evaluate_funcall, evaluate_subexp_standard): Replace
3720         throw_exception with throw.
3721         * dwarf2loc.c (call_site_find_chain)
3722         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3723         Replace throw_exception with throw.
3724         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3725         with throw.
3726         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3727         throw.
3728         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3729         * completer.c (complete_line_internal): Replace throw_exception
3730         with throw.
3731         * compile/compile-object-run.c (compile_object_run): Replace
3732         throw_exception with throw.
3733         * cli/cli-script.c (process_next_line): Replace throw_exception
3734         with throw.
3735         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3736         (btrace_enable, btrace_maint_update_pt_packets): Replace
3737         throw_exception with throw.
3738         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3739         throw_exception with throw.
3740         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3741         throw_exception with throw.
3742         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3743         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3744         * aarch64-tdep.c (aarch64_make_prologue_cache)
3745         (aarch64_make_stub_cache): Replace throw_exception with throw.
3746
3747 2019-04-08  Tom Tromey  <tom@tromey.com>
3748
3749         * common/common-exceptions.c (throw_exception): Rename from
3750         throw_exception_cxx.  Remove old copy.  Make argument const.
3751         (throw_it): Create and throw exception objects directly.
3752         * common/common-exceptions.h (throw_exception): Make argument
3753         const.
3754         (struct gdb_exception_error): Add constructor.
3755         (struct gdb_exception_quit): Add constructor.
3756
3757 2019-04-08  Tom Tromey  <tom@tromey.com>
3758
3759         * common/common-exceptions.h (exception_rethrow): Don't declare.
3760         (TRY_SJLJ): Update comment.
3761         (TRY, CATCH, END_CATCH): Remove.
3762         * common/common-exceptions.c (exception_rethrow): Remove.
3763
3764 2019-04-08  Tom Tromey  <tom@tromey.com>
3765
3766         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3767         Remove.
3768         (gdb_exception_error): Rename from
3769         gdb_exception_RETURN_MASK_ERROR.
3770         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3771         (gdb_quit_bad_alloc): Update.
3772         * aarch64-tdep.c: Update.
3773         * ada-lang.c: Update.
3774         * ada-typeprint.c: Update.
3775         * ada-valprint.c: Update.
3776         * amd64-tdep.c: Update.
3777         * arch-utils.c: Update.
3778         * break-catch-throw.c: Update.
3779         * breakpoint.c: Update.
3780         * btrace.c: Update.
3781         * c-varobj.c: Update.
3782         * cli/cli-cmds.c: Update.
3783         * cli/cli-interp.c: Update.
3784         * cli/cli-script.c: Update.
3785         * common/common-exceptions.c: Update.
3786         * common/new-op.c: Update.
3787         * common/selftest.c: Update.
3788         * compile/compile-c-symbols.c: Update.
3789         * compile/compile-cplus-symbols.c: Update.
3790         * compile/compile-object-load.c: Update.
3791         * compile/compile-object-run.c: Update.
3792         * completer.c: Update.
3793         * corelow.c: Update.
3794         * cp-abi.c: Update.
3795         * cp-support.c: Update.
3796         * cp-valprint.c: Update.
3797         * darwin-nat.c: Update.
3798         * disasm-selftests.c: Update.
3799         * dtrace-probe.c: Update.
3800         * dwarf-index-cache.c: Update.
3801         * dwarf-index-write.c: Update.
3802         * dwarf2-frame-tailcall.c: Update.
3803         * dwarf2-frame.c: Update.
3804         * dwarf2loc.c: Update.
3805         * dwarf2read.c: Update.
3806         * eval.c: Update.
3807         * event-loop.c: Update.
3808         * event-top.c: Update.
3809         * exec.c: Update.
3810         * f-valprint.c: Update.
3811         * fbsd-tdep.c: Update.
3812         * frame-unwind.c: Update.
3813         * frame.c: Update.
3814         * gdbtypes.c: Update.
3815         * gnu-v3-abi.c: Update.
3816         * guile/guile-internal.h: Update.
3817         * guile/scm-block.c: Update.
3818         * guile/scm-breakpoint.c: Update.
3819         * guile/scm-cmd.c: Update.
3820         * guile/scm-disasm.c: Update.
3821         * guile/scm-frame.c: Update.
3822         * guile/scm-lazy-string.c: Update.
3823         * guile/scm-math.c: Update.
3824         * guile/scm-param.c: Update.
3825         * guile/scm-ports.c: Update.
3826         * guile/scm-pretty-print.c: Update.
3827         * guile/scm-symbol.c: Update.
3828         * guile/scm-symtab.c: Update.
3829         * guile/scm-type.c: Update.
3830         * guile/scm-value.c: Update.
3831         * i386-linux-tdep.c: Update.
3832         * i386-tdep.c: Update.
3833         * inf-loop.c: Update.
3834         * infcall.c: Update.
3835         * infcmd.c: Update.
3836         * infrun.c: Update.
3837         * jit.c: Update.
3838         * language.c: Update.
3839         * linespec.c: Update.
3840         * linux-fork.c: Update.
3841         * linux-nat.c: Update.
3842         * linux-tdep.c: Update.
3843         * linux-thread-db.c: Update.
3844         * main.c: Update.
3845         * mi/mi-cmd-break.c: Update.
3846         * mi/mi-cmd-stack.c: Update.
3847         * mi/mi-interp.c: Update.
3848         * mi/mi-main.c: Update.
3849         * objc-lang.c: Update.
3850         * p-valprint.c: Update.
3851         * parse.c: Update.
3852         * ppc-linux-tdep.c: Update.
3853         * printcmd.c: Update.
3854         * python/py-arch.c: Update.
3855         * python/py-breakpoint.c: Update.
3856         * python/py-cmd.c: Update.
3857         * python/py-finishbreakpoint.c: Update.
3858         * python/py-frame.c: Update.
3859         * python/py-framefilter.c: Update.
3860         * python/py-gdb-readline.c: Update.
3861         * python/py-inferior.c: Update.
3862         * python/py-infthread.c: Update.
3863         * python/py-lazy-string.c: Update.
3864         * python/py-linetable.c: Update.
3865         * python/py-objfile.c: Update.
3866         * python/py-param.c: Update.
3867         * python/py-prettyprint.c: Update.
3868         * python/py-progspace.c: Update.
3869         * python/py-record-btrace.c: Update.
3870         * python/py-record.c: Update.
3871         * python/py-symbol.c: Update.
3872         * python/py-type.c: Update.
3873         * python/py-unwind.c: Update.
3874         * python/py-utils.c: Update.
3875         * python/py-value.c: Update.
3876         * python/python.c: Update.
3877         * record-btrace.c: Update.
3878         * record-full.c: Update.
3879         * remote-fileio.c: Update.
3880         * remote.c: Update.
3881         * riscv-tdep.c: Update.
3882         * rs6000-aix-tdep.c: Update.
3883         * rs6000-tdep.c: Update.
3884         * rust-exp.y: Update.
3885         * rust-lang.c: Update.
3886         * s390-tdep.c: Update.
3887         * selftest-arch.c: Update.
3888         * solib-dsbt.c: Update.
3889         * solib-frv.c: Update.
3890         * solib-spu.c: Update.
3891         * solib-svr4.c: Update.
3892         * solib.c: Update.
3893         * sparc64-linux-tdep.c: Update.
3894         * stack.c: Update.
3895         * symfile-mem.c: Update.
3896         * symmisc.c: Update.
3897         * target.c: Update.
3898         * thread.c: Update.
3899         * top.c: Update.
3900         * tracefile-tfile.c: Update.
3901         * tui/tui.c: Update.
3902         * typeprint.c: Update.
3903         * unittests/cli-utils-selftests.c: Update.
3904         * unittests/parse-connection-spec-selftests.c: Update.
3905         * valops.c: Update.
3906         * valprint.c: Update.
3907         * value.c: Update.
3908         * varobj.c: Update.
3909         * windows-nat.c: Update.
3910         * x86-linux-nat.c: Update.
3911         * xml-support.c: Update.
3912
3913 2019-04-08  Tom Tromey  <tom@tromey.com>
3914
3915         * xml-support.c: Use C++ exception handling.
3916         * x86-linux-nat.c: Use C++ exception handling.
3917         * windows-nat.c: Use C++ exception handling.
3918         * varobj.c: Use C++ exception handling.
3919         * value.c: Use C++ exception handling.
3920         * valprint.c: Use C++ exception handling.
3921         * valops.c: Use C++ exception handling.
3922         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3923         handling.
3924         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3925         * typeprint.c: Use C++ exception handling.
3926         * tui/tui.c: Use C++ exception handling.
3927         * tracefile-tfile.c: Use C++ exception handling.
3928         * top.c: Use C++ exception handling.
3929         * thread.c: Use C++ exception handling.
3930         * target.c: Use C++ exception handling.
3931         * symmisc.c: Use C++ exception handling.
3932         * symfile-mem.c: Use C++ exception handling.
3933         * stack.c: Use C++ exception handling.
3934         * sparc64-linux-tdep.c: Use C++ exception handling.
3935         * solib.c: Use C++ exception handling.
3936         * solib-svr4.c: Use C++ exception handling.
3937         * solib-spu.c: Use C++ exception handling.
3938         * solib-frv.c: Use C++ exception handling.
3939         * solib-dsbt.c: Use C++ exception handling.
3940         * selftest-arch.c: Use C++ exception handling.
3941         * s390-tdep.c: Use C++ exception handling.
3942         * rust-lang.c: Use C++ exception handling.
3943         * rust-exp.y: Use C++ exception handling.
3944         * rs6000-tdep.c: Use C++ exception handling.
3945         * rs6000-aix-tdep.c: Use C++ exception handling.
3946         * riscv-tdep.c: Use C++ exception handling.
3947         * remote.c: Use C++ exception handling.
3948         * remote-fileio.c: Use C++ exception handling.
3949         * record-full.c: Use C++ exception handling.
3950         * record-btrace.c: Use C++ exception handling.
3951         * python/python.c: Use C++ exception handling.
3952         * python/py-value.c: Use C++ exception handling.
3953         * python/py-utils.c: Use C++ exception handling.
3954         * python/py-unwind.c: Use C++ exception handling.
3955         * python/py-type.c: Use C++ exception handling.
3956         * python/py-symbol.c: Use C++ exception handling.
3957         * python/py-record.c: Use C++ exception handling.
3958         * python/py-record-btrace.c: Use C++ exception handling.
3959         * python/py-progspace.c: Use C++ exception handling.
3960         * python/py-prettyprint.c: Use C++ exception handling.
3961         * python/py-param.c: Use C++ exception handling.
3962         * python/py-objfile.c: Use C++ exception handling.
3963         * python/py-linetable.c: Use C++ exception handling.
3964         * python/py-lazy-string.c: Use C++ exception handling.
3965         * python/py-infthread.c: Use C++ exception handling.
3966         * python/py-inferior.c: Use C++ exception handling.
3967         * python/py-gdb-readline.c: Use C++ exception handling.
3968         * python/py-framefilter.c: Use C++ exception handling.
3969         * python/py-frame.c: Use C++ exception handling.
3970         * python/py-finishbreakpoint.c: Use C++ exception handling.
3971         * python/py-cmd.c: Use C++ exception handling.
3972         * python/py-breakpoint.c: Use C++ exception handling.
3973         * python/py-arch.c: Use C++ exception handling.
3974         * printcmd.c: Use C++ exception handling.
3975         * ppc-linux-tdep.c: Use C++ exception handling.
3976         * parse.c: Use C++ exception handling.
3977         * p-valprint.c: Use C++ exception handling.
3978         * objc-lang.c: Use C++ exception handling.
3979         * mi/mi-main.c: Use C++ exception handling.
3980         * mi/mi-interp.c: Use C++ exception handling.
3981         * mi/mi-cmd-stack.c: Use C++ exception handling.
3982         * mi/mi-cmd-break.c: Use C++ exception handling.
3983         * main.c: Use C++ exception handling.
3984         * linux-thread-db.c: Use C++ exception handling.
3985         * linux-tdep.c: Use C++ exception handling.
3986         * linux-nat.c: Use C++ exception handling.
3987         * linux-fork.c: Use C++ exception handling.
3988         * linespec.c: Use C++ exception handling.
3989         * language.c: Use C++ exception handling.
3990         * jit.c: Use C++ exception handling.
3991         * infrun.c: Use C++ exception handling.
3992         * infcmd.c: Use C++ exception handling.
3993         * infcall.c: Use C++ exception handling.
3994         * inf-loop.c: Use C++ exception handling.
3995         * i386-tdep.c: Use C++ exception handling.
3996         * i386-linux-tdep.c: Use C++ exception handling.
3997         * guile/scm-value.c: Use C++ exception handling.
3998         * guile/scm-type.c: Use C++ exception handling.
3999         * guile/scm-symtab.c: Use C++ exception handling.
4000         * guile/scm-symbol.c: Use C++ exception handling.
4001         * guile/scm-pretty-print.c: Use C++ exception handling.
4002         * guile/scm-ports.c: Use C++ exception handling.
4003         * guile/scm-param.c: Use C++ exception handling.
4004         * guile/scm-math.c: Use C++ exception handling.
4005         * guile/scm-lazy-string.c: Use C++ exception handling.
4006         * guile/scm-frame.c: Use C++ exception handling.
4007         * guile/scm-disasm.c: Use C++ exception handling.
4008         * guile/scm-cmd.c: Use C++ exception handling.
4009         * guile/scm-breakpoint.c: Use C++ exception handling.
4010         * guile/scm-block.c: Use C++ exception handling.
4011         * guile/guile-internal.h: Use C++ exception handling.
4012         * gnu-v3-abi.c: Use C++ exception handling.
4013         * gdbtypes.c: Use C++ exception handling.
4014         * frame.c: Use C++ exception handling.
4015         * frame-unwind.c: Use C++ exception handling.
4016         * fbsd-tdep.c: Use C++ exception handling.
4017         * f-valprint.c: Use C++ exception handling.
4018         * exec.c: Use C++ exception handling.
4019         * event-top.c: Use C++ exception handling.
4020         * event-loop.c: Use C++ exception handling.
4021         * eval.c: Use C++ exception handling.
4022         * dwarf2read.c: Use C++ exception handling.
4023         * dwarf2loc.c: Use C++ exception handling.
4024         * dwarf2-frame.c: Use C++ exception handling.
4025         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4026         * dwarf-index-write.c: Use C++ exception handling.
4027         * dwarf-index-cache.c: Use C++ exception handling.
4028         * dtrace-probe.c: Use C++ exception handling.
4029         * disasm-selftests.c: Use C++ exception handling.
4030         * darwin-nat.c: Use C++ exception handling.
4031         * cp-valprint.c: Use C++ exception handling.
4032         * cp-support.c: Use C++ exception handling.
4033         * cp-abi.c: Use C++ exception handling.
4034         * corelow.c: Use C++ exception handling.
4035         * completer.c: Use C++ exception handling.
4036         * compile/compile-object-run.c: Use C++ exception handling.
4037         * compile/compile-object-load.c: Use C++ exception handling.
4038         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4039         * compile/compile-c-symbols.c: Use C++ exception handling.
4040         * common/selftest.c: Use C++ exception handling.
4041         * common/new-op.c: Use C++ exception handling.
4042         * cli/cli-script.c: Use C++ exception handling.
4043         * cli/cli-interp.c: Use C++ exception handling.
4044         * cli/cli-cmds.c: Use C++ exception handling.
4045         * c-varobj.c: Use C++ exception handling.
4046         * btrace.c: Use C++ exception handling.
4047         * breakpoint.c: Use C++ exception handling.
4048         * break-catch-throw.c: Use C++ exception handling.
4049         * arch-utils.c: Use C++ exception handling.
4050         * amd64-tdep.c: Use C++ exception handling.
4051         * ada-valprint.c: Use C++ exception handling.
4052         * ada-typeprint.c: Use C++ exception handling.
4053         * ada-lang.c: Use C++ exception handling.
4054         * aarch64-tdep.c: Use C++ exception handling.
4055
4056 2019-04-08  Tom Tromey  <tom@tromey.com>
4057
4058         * xml-support.c (gdb_xml_parser::parse): Update.
4059         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4060         * value.c (show_convenience): Update.
4061         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4062         (test_parse_flags_qcs): Update.
4063         * thread.c (thr_try_catch_cmd): Update.
4064         * target.c (target_translate_tls_address): Update.
4065         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4066         (info_frame_command_core, frame_apply_command_count): Update.
4067         * rust-exp.y (rust_lex_exception_test): Update.
4068         * riscv-tdep.c (riscv_print_one_register_info): Update.
4069         * remote.c (remote_target::enable_btrace): Update.
4070         * record-btrace.c (record_btrace_enable_warn): Update.
4071         * python/py-utils.c (gdbpy_convert_exception): Update.
4072         * printcmd.c (do_one_display, print_variable_and_value): Update.
4073         * mi/mi-main.c (mi_print_exception): Update.
4074         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4075         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4076         * linux-nat.c (linux_nat_target::attach): Update.
4077         * linux-fork.c (class scoped_switch_fork_info): Update.
4078         * infrun.c (displaced_step_prepare): Update.
4079         * infcall.c (call_function_by_hand_dummy): Update.
4080         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4081         * gnu-v3-abi.c (print_one_vtable): Update.
4082         * frame.c (get_prev_frame_always): Update.
4083         * f-valprint.c (info_common_command_for_block): Update.
4084         * exec.c (try_open_exec_file): Update.
4085         * exceptions.c (print_exception, exception_print)
4086         (exception_fprintf, exception_print_same): Update.
4087         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4088         * dwarf-index-cache.c (index_cache::store)
4089         (index_cache::lookup_gdb_index): Update.
4090         * darwin-nat.c (maybe_cache_shell): Update.
4091         * cp-valprint.c (cp_print_value_fields): Update.
4092         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4093         (gcc_cplus_symbol_address): Update.
4094         * compile/compile-c-symbols.c (gcc_convert_symbol)
4095         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4096         * common/selftest.c: Update.
4097         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4098         a std::string.
4099         (exception_try_scope_entry, exception_try_scope_exit): Don't
4100         declare.
4101         (struct exception_try_scope): Remove.
4102         (TRY): Don't use exception_try_scope.
4103         (struct gdb_exception): Add constructor, operator=.
4104         <what>: New method.
4105         (struct gdb_exception_RETURN_MASK_ALL)
4106         (struct gdb_exception_RETURN_MASK_ERROR)
4107         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4108         (struct gdb_quit_bad_alloc): Update.
4109         * common/common-exceptions.c (exception_none): Change
4110         initializer.
4111         (struct catcher) <state, exception>: Initialize inline.
4112         <prev>: Remove member.
4113         (current_catcher): Remove.
4114         (catchers): New global.
4115         (exceptions_state_mc_init): Simplify.
4116         (catcher_pop): Remove.
4117         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4118         (try_scope_depth, exception_try_scope_entry)
4119         (exception_try_scope_exit): Remove.
4120         (throw_exception_sjlj): Update.
4121         (exception_messages, exception_messages_size): Remove.
4122         (throw_it): Simplify.
4123         (gdb_exception_sliced_copy): Remove.
4124         (throw_exception_cxx): Update.
4125         * cli/cli-script.c (script_from_file): Update.
4126         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4127         Update.
4128         * ada-valprint.c (ada_val_print): Update.
4129         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4130         (create_excep_cond_exprs): Update.
4131
4132 2019-04-08  Tom Tromey  <tom@tromey.com>
4133
4134         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4135         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4136         (TRY, CATCH, END_CATCH): Remove some definitions.
4137         * common/common-exceptions.c: Don't use GDB_XCPT.
4138         (catcher_list_size): Remove.
4139         (throw_exception, throw_it): Simplify.
4140
4141 2019-04-05  Tom Tromey  <tom@tromey.com>
4142
4143         Revert the header-sorting patch.
4144         * ft32-tdep.c: Revert.
4145         * frv-tdep.c: Revert.
4146         * frv-linux-tdep.c: Revert.
4147         * frame.c: Revert.
4148         * frame-unwind.c: Revert.
4149         * frame-base.c: Revert.
4150         * fork-child.c: Revert.
4151         * findvar.c: Revert.
4152         * findcmd.c: Revert.
4153         * filesystem.c: Revert.
4154         * filename-seen-cache.h: Revert.
4155         * filename-seen-cache.c: Revert.
4156         * fbsd-tdep.c: Revert.
4157         * fbsd-nat.h: Revert.
4158         * fbsd-nat.c: Revert.
4159         * f-valprint.c: Revert.
4160         * f-typeprint.c: Revert.
4161         * f-lang.c: Revert.
4162         * extension.h: Revert.
4163         * extension.c: Revert.
4164         * extension-priv.h: Revert.
4165         * expprint.c: Revert.
4166         * exec.h: Revert.
4167         * exec.c: Revert.
4168         * exceptions.c: Revert.
4169         * event-top.c: Revert.
4170         * event-loop.c: Revert.
4171         * eval.c: Revert.
4172         * elfread.c: Revert.
4173         * dwarf2read.h: Revert.
4174         * dwarf2read.c: Revert.
4175         * dwarf2loc.c: Revert.
4176         * dwarf2expr.h: Revert.
4177         * dwarf2expr.c: Revert.
4178         * dwarf2-frame.c: Revert.
4179         * dwarf2-frame-tailcall.c: Revert.
4180         * dwarf-index-write.h: Revert.
4181         * dwarf-index-write.c: Revert.
4182         * dwarf-index-common.c: Revert.
4183         * dwarf-index-cache.h: Revert.
4184         * dwarf-index-cache.c: Revert.
4185         * dummy-frame.c: Revert.
4186         * dtrace-probe.c: Revert.
4187         * disasm.h: Revert.
4188         * disasm.c: Revert.
4189         * disasm-selftests.c: Revert.
4190         * dictionary.c: Revert.
4191         * dicos-tdep.c: Revert.
4192         * demangle.c: Revert.
4193         * dcache.h: Revert.
4194         * dcache.c: Revert.
4195         * darwin-nat.h: Revert.
4196         * darwin-nat.c: Revert.
4197         * darwin-nat-info.c: Revert.
4198         * d-valprint.c: Revert.
4199         * d-namespace.c: Revert.
4200         * d-lang.c: Revert.
4201         * ctf.c: Revert.
4202         * csky-tdep.c: Revert.
4203         * csky-linux-tdep.c: Revert.
4204         * cris-tdep.c: Revert.
4205         * cris-linux-tdep.c: Revert.
4206         * cp-valprint.c: Revert.
4207         * cp-support.c: Revert.
4208         * cp-namespace.c: Revert.
4209         * cp-abi.c: Revert.
4210         * corelow.c: Revert.
4211         * corefile.c: Revert.
4212         * continuations.c: Revert.
4213         * completer.h: Revert.
4214         * completer.c: Revert.
4215         * complaints.c: Revert.
4216         * coffread.c: Revert.
4217         * coff-pe-read.c: Revert.
4218         * cli-out.h: Revert.
4219         * cli-out.c: Revert.
4220         * charset.c: Revert.
4221         * c-varobj.c: Revert.
4222         * c-valprint.c: Revert.
4223         * c-typeprint.c: Revert.
4224         * c-lang.c: Revert.
4225         * buildsym.c: Revert.
4226         * buildsym-legacy.c: Revert.
4227         * build-id.h: Revert.
4228         * build-id.c: Revert.
4229         * btrace.c: Revert.
4230         * bsd-uthread.c: Revert.
4231         * breakpoint.h: Revert.
4232         * breakpoint.c: Revert.
4233         * break-catch-throw.c: Revert.
4234         * break-catch-syscall.c: Revert.
4235         * break-catch-sig.c: Revert.
4236         * blockframe.c: Revert.
4237         * block.c: Revert.
4238         * bfin-tdep.c: Revert.
4239         * bfin-linux-tdep.c: Revert.
4240         * bfd-target.c: Revert.
4241         * bcache.c: Revert.
4242         * ax-general.c: Revert.
4243         * ax-gdb.h: Revert.
4244         * ax-gdb.c: Revert.
4245         * avr-tdep.c: Revert.
4246         * auxv.c: Revert.
4247         * auto-load.c: Revert.
4248         * arm-wince-tdep.c: Revert.
4249         * arm-tdep.c: Revert.
4250         * arm-symbian-tdep.c: Revert.
4251         * arm-pikeos-tdep.c: Revert.
4252         * arm-obsd-tdep.c: Revert.
4253         * arm-nbsd-tdep.c: Revert.
4254         * arm-nbsd-nat.c: Revert.
4255         * arm-linux-tdep.c: Revert.
4256         * arm-linux-nat.c: Revert.
4257         * arm-fbsd-tdep.c: Revert.
4258         * arm-fbsd-nat.c: Revert.
4259         * arm-bsd-tdep.c: Revert.
4260         * arch-utils.c: Revert.
4261         * arc-tdep.c: Revert.
4262         * arc-newlib-tdep.c: Revert.
4263         * annotate.h: Revert.
4264         * annotate.c: Revert.
4265         * amd64-windows-tdep.c: Revert.
4266         * amd64-windows-nat.c: Revert.
4267         * amd64-tdep.c: Revert.
4268         * amd64-sol2-tdep.c: Revert.
4269         * amd64-obsd-tdep.c: Revert.
4270         * amd64-obsd-nat.c: Revert.
4271         * amd64-nbsd-tdep.c: Revert.
4272         * amd64-nbsd-nat.c: Revert.
4273         * amd64-nat.c: Revert.
4274         * amd64-linux-tdep.c: Revert.
4275         * amd64-linux-nat.c: Revert.
4276         * amd64-fbsd-tdep.c: Revert.
4277         * amd64-fbsd-nat.c: Revert.
4278         * amd64-dicos-tdep.c: Revert.
4279         * amd64-darwin-tdep.c: Revert.
4280         * amd64-bsd-nat.c: Revert.
4281         * alpha-tdep.c: Revert.
4282         * alpha-obsd-tdep.c: Revert.
4283         * alpha-nbsd-tdep.c: Revert.
4284         * alpha-mdebug-tdep.c: Revert.
4285         * alpha-linux-tdep.c: Revert.
4286         * alpha-linux-nat.c: Revert.
4287         * alpha-bsd-tdep.c: Revert.
4288         * alpha-bsd-nat.c: Revert.
4289         * aix-thread.c: Revert.
4290         * agent.c: Revert.
4291         * addrmap.c: Revert.
4292         * ada-varobj.c: Revert.
4293         * ada-valprint.c: Revert.
4294         * ada-typeprint.c: Revert.
4295         * ada-tasks.c: Revert.
4296         * ada-lang.c: Revert.
4297         * aarch64-tdep.c: Revert.
4298         * aarch64-ravenscar-thread.c: Revert.
4299         * aarch64-newlib-tdep.c: Revert.
4300         * aarch64-linux-tdep.c: Revert.
4301         * aarch64-linux-nat.c: Revert.
4302         * aarch64-fbsd-tdep.c: Revert.
4303         * aarch64-fbsd-nat.c: Revert.
4304         * aarch32-linux-nat.c: Revert.
4305
4306 2019-04-05  Tom Tromey  <tom@tromey.com>
4307
4308         * ft32-tdep.c: Sort headers.
4309         * frv-tdep.c: Sort headers.
4310         * frv-linux-tdep.c: Sort headers.
4311         * frame.c: Sort headers.
4312         * frame-unwind.c: Sort headers.
4313         * frame-base.c: Sort headers.
4314         * fork-child.c: Sort headers.
4315         * findvar.c: Sort headers.
4316         * findcmd.c: Sort headers.
4317         * filesystem.c: Sort headers.
4318         * filename-seen-cache.h: Sort headers.
4319         * filename-seen-cache.c: Sort headers.
4320         * fbsd-tdep.c: Sort headers.
4321         * fbsd-nat.h: Sort headers.
4322         * fbsd-nat.c: Sort headers.
4323         * f-valprint.c: Sort headers.
4324         * f-typeprint.c: Sort headers.
4325         * f-lang.c: Sort headers.
4326         * extension.h: Sort headers.
4327         * extension.c: Sort headers.
4328         * extension-priv.h: Sort headers.
4329         * expprint.c: Sort headers.
4330         * exec.h: Sort headers.
4331         * exec.c: Sort headers.
4332         * exceptions.c: Sort headers.
4333         * event-top.c: Sort headers.
4334         * event-loop.c: Sort headers.
4335         * eval.c: Sort headers.
4336         * elfread.c: Sort headers.
4337         * dwarf2read.h: Sort headers.
4338         * dwarf2read.c: Sort headers.
4339         * dwarf2loc.c: Sort headers.
4340         * dwarf2expr.h: Sort headers.
4341         * dwarf2expr.c: Sort headers.
4342         * dwarf2-frame.c: Sort headers.
4343         * dwarf2-frame-tailcall.c: Sort headers.
4344         * dwarf-index-write.h: Sort headers.
4345         * dwarf-index-write.c: Sort headers.
4346         * dwarf-index-common.c: Sort headers.
4347         * dwarf-index-cache.h: Sort headers.
4348         * dwarf-index-cache.c: Sort headers.
4349         * dummy-frame.c: Sort headers.
4350         * dtrace-probe.c: Sort headers.
4351         * disasm.h: Sort headers.
4352         * disasm.c: Sort headers.
4353         * disasm-selftests.c: Sort headers.
4354         * dictionary.c: Sort headers.
4355         * dicos-tdep.c: Sort headers.
4356         * demangle.c: Sort headers.
4357         * dcache.h: Sort headers.
4358         * dcache.c: Sort headers.
4359         * darwin-nat.h: Sort headers.
4360         * darwin-nat.c: Sort headers.
4361         * darwin-nat-info.c: Sort headers.
4362         * d-valprint.c: Sort headers.
4363         * d-namespace.c: Sort headers.
4364         * d-lang.c: Sort headers.
4365         * ctf.c: Sort headers.
4366         * csky-tdep.c: Sort headers.
4367         * csky-linux-tdep.c: Sort headers.
4368         * cris-tdep.c: Sort headers.
4369         * cris-linux-tdep.c: Sort headers.
4370         * cp-valprint.c: Sort headers.
4371         * cp-support.c: Sort headers.
4372         * cp-namespace.c: Sort headers.
4373         * cp-abi.c: Sort headers.
4374         * corelow.c: Sort headers.
4375         * corefile.c: Sort headers.
4376         * continuations.c: Sort headers.
4377         * completer.h: Sort headers.
4378         * completer.c: Sort headers.
4379         * complaints.c: Sort headers.
4380         * coffread.c: Sort headers.
4381         * coff-pe-read.c: Sort headers.
4382         * cli-out.h: Sort headers.
4383         * cli-out.c: Sort headers.
4384         * charset.c: Sort headers.
4385         * c-varobj.c: Sort headers.
4386         * c-valprint.c: Sort headers.
4387         * c-typeprint.c: Sort headers.
4388         * c-lang.c: Sort headers.
4389         * buildsym.c: Sort headers.
4390         * buildsym-legacy.c: Sort headers.
4391         * build-id.h: Sort headers.
4392         * build-id.c: Sort headers.
4393         * btrace.c: Sort headers.
4394         * bsd-uthread.c: Sort headers.
4395         * breakpoint.h: Sort headers.
4396         * breakpoint.c: Sort headers.
4397         * break-catch-throw.c: Sort headers.
4398         * break-catch-syscall.c: Sort headers.
4399         * break-catch-sig.c: Sort headers.
4400         * blockframe.c: Sort headers.
4401         * block.c: Sort headers.
4402         * bfin-tdep.c: Sort headers.
4403         * bfin-linux-tdep.c: Sort headers.
4404         * bfd-target.c: Sort headers.
4405         * bcache.c: Sort headers.
4406         * ax-general.c: Sort headers.
4407         * ax-gdb.h: Sort headers.
4408         * ax-gdb.c: Sort headers.
4409         * avr-tdep.c: Sort headers.
4410         * auxv.c: Sort headers.
4411         * auto-load.c: Sort headers.
4412         * arm-wince-tdep.c: Sort headers.
4413         * arm-tdep.c: Sort headers.
4414         * arm-symbian-tdep.c: Sort headers.
4415         * arm-pikeos-tdep.c: Sort headers.
4416         * arm-obsd-tdep.c: Sort headers.
4417         * arm-nbsd-tdep.c: Sort headers.
4418         * arm-nbsd-nat.c: Sort headers.
4419         * arm-linux-tdep.c: Sort headers.
4420         * arm-linux-nat.c: Sort headers.
4421         * arm-fbsd-tdep.c: Sort headers.
4422         * arm-fbsd-nat.c: Sort headers.
4423         * arm-bsd-tdep.c: Sort headers.
4424         * arch-utils.c: Sort headers.
4425         * arc-tdep.c: Sort headers.
4426         * arc-newlib-tdep.c: Sort headers.
4427         * annotate.h: Sort headers.
4428         * annotate.c: Sort headers.
4429         * amd64-windows-tdep.c: Sort headers.
4430         * amd64-windows-nat.c: Sort headers.
4431         * amd64-tdep.c: Sort headers.
4432         * amd64-sol2-tdep.c: Sort headers.
4433         * amd64-obsd-tdep.c: Sort headers.
4434         * amd64-obsd-nat.c: Sort headers.
4435         * amd64-nbsd-tdep.c: Sort headers.
4436         * amd64-nbsd-nat.c: Sort headers.
4437         * amd64-nat.c: Sort headers.
4438         * amd64-linux-tdep.c: Sort headers.
4439         * amd64-linux-nat.c: Sort headers.
4440         * amd64-fbsd-tdep.c: Sort headers.
4441         * amd64-fbsd-nat.c: Sort headers.
4442         * amd64-dicos-tdep.c: Sort headers.
4443         * amd64-darwin-tdep.c: Sort headers.
4444         * amd64-bsd-nat.c: Sort headers.
4445         * alpha-tdep.c: Sort headers.
4446         * alpha-obsd-tdep.c: Sort headers.
4447         * alpha-nbsd-tdep.c: Sort headers.
4448         * alpha-mdebug-tdep.c: Sort headers.
4449         * alpha-linux-tdep.c: Sort headers.
4450         * alpha-linux-nat.c: Sort headers.
4451         * alpha-bsd-tdep.c: Sort headers.
4452         * alpha-bsd-nat.c: Sort headers.
4453         * aix-thread.c: Sort headers.
4454         * agent.c: Sort headers.
4455         * addrmap.c: Sort headers.
4456         * ada-varobj.c: Sort headers.
4457         * ada-valprint.c: Sort headers.
4458         * ada-typeprint.c: Sort headers.
4459         * ada-tasks.c: Sort headers.
4460         * ada-lang.c: Sort headers.
4461         * aarch64-tdep.c: Sort headers.
4462         * aarch64-ravenscar-thread.c: Sort headers.
4463         * aarch64-newlib-tdep.c: Sort headers.
4464         * aarch64-linux-tdep.c: Sort headers.
4465         * aarch64-linux-nat.c: Sort headers.
4466         * aarch64-fbsd-tdep.c: Sort headers.
4467         * aarch64-fbsd-nat.c: Sort headers.
4468         * aarch32-linux-nat.c: Sort headers.
4469
4470 2019-04-04  Tom Tromey  <tom@tromey.com>
4471
4472         * varobj.c (varobj_create): Update.
4473         * rust-exp.y (struct rust_parser) <update_innermost_block,
4474         lookup_symbol>: New methods.
4475         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4476         Rename.
4477         (rust_parser::rust_lookup_type)
4478         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4479         * printcmd.c (display_command, do_one_display): Update.
4480         * parser-defs.h (struct parser_state) <parser_state>: Add
4481         "tracker" parameter.
4482         (block_tracker): New member.
4483         (class innermost_block_tracker) <innermost_block_tracker>: Add
4484         "types" parameter.
4485         <reset>: Remove method.
4486         (innermost_block): Don't declare.
4487         (null_post_parser): Update.
4488         * parse.c (innermost_block): Remove global.
4489         (write_dollar_variable): Update.
4490         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4491         Remove "tracker_types" parameter.
4492         (parse_expression): Add "tracker" parameter.
4493         (parse_expression_for_completion): Update.
4494         (null_post_parser): Add "tracker" parameter.
4495         * p-exp.y: Update rules.
4496         * m2-exp.y: Update rules.
4497         * language.h (struct language_defn) <la_post_parser>: Add
4498         "tracker" parameter.
4499         * go-exp.y: Update rules.
4500         * f-exp.y: Update rules.
4501         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4502         parameter.
4503         * d-exp.y: Update rules.
4504         * c-exp.y: Update rules.
4505         * breakpoint.c (set_breakpoint_condition): Create an
4506         innermost_block_tracker.
4507         (watch_command_1): Likewise.
4508         * ada-lang.c (resolve): Add "tracker" parameter.
4509         (resolve_subexp): Likewise.
4510         * ada-exp.y (write_var_from_sym): Update.
4511
4512 2019-04-04  Tom Tromey  <tom@tromey.com>
4513
4514         * type-stack.h: New file.
4515         * type-stack.c: New file.
4516         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4517         type-stack.h.
4518         (insert_into_type_stack, insert_type, push_type, push_type_int)
4519         (insert_type_address_space, pop_type, pop_type_int)
4520         (pop_typelist, pop_type_stack, append_type_stack)
4521         (push_type_stack, get_type_stack, push_typelist)
4522         (follow_type_instance_flags, follow_types): Don't declare.
4523         * parse.c (type_stack): Remove global.
4524         (parse_exp_in_context): Update.
4525         (insert_into_type_stack, insert_type, push_type, push_type_int)
4526         (insert_type_address_space, pop_type, pop_type_int)
4527         (pop_typelist, pop_type_stack, append_type_stack)
4528         (push_type_stack, get_type_stack, push_typelist)
4529         (follow_type_instance_flags, follow_types): Remove (moved to
4530         type-stack.c).
4531         * f-exp.y (type_stack): New global.
4532         Update rules.
4533         (push_kind_type, f_parse): Update.
4534         * d-exp.y (type_stack): New global.
4535         Update rules.
4536         (d_parse): Update.
4537         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4538         Update rules.
4539         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4540         (HFILES_NO_SRCDIR): Add type-stack.h.
4541
4542 2019-04-04  Tom Tromey  <tom@tromey.com>
4543
4544         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4545         (rust_parser::convert_ast_to_expression, rust_parse)
4546         (rust_lex_test_completion, rust_lex_tests): Update.
4547         * parser-defs.h (struct expr_completion_state): New.
4548         (struct parser_state) <parser_state>: Add completion parameter.
4549         <mark_struct_expression, mark_completion_tag>: New methods.
4550         <parse_completion, m_completion_state>: New members.
4551         (prefixify_expression, null_post_parser): Update.
4552         (mark_struct_expression, mark_completion_tag): Don't declare.
4553         * parse.c (parse_completion, expout_last_struct)
4554         (expout_tag_completion_type, expout_completion_name): Remove
4555         globals.
4556         (parser_state::mark_struct_expression)
4557         (parser_state::mark_completion_tag): Now methods.
4558         (prefixify_expression): Add last_struct parameter.
4559         (prefixify_subexp): Likewise.
4560         (parse_exp_1): Update.
4561         (parse_exp_in_context): Add cstate parameter.  Update.
4562         (parse_expression_for_completion): Create an
4563         expr_completion_state.
4564         (null_post_parser): Add "completion" parameter.
4565         * p-exp.y: Update rules.
4566         (yylex): Update.
4567         * language.h (struct language_defn) <la_post_parser>: Add
4568         "completing" parameter.
4569         * go-exp.y: Update rules.
4570         (lex_one_token): Update.
4571         * expression.h (parse_completion): Don't declare.
4572         * d-exp.y: Update rules.
4573         (lex_one_token): Update rules.
4574         * c-exp.y: Update rules.
4575         (lex_one_token): Update.
4576         * ada-lang.c (resolve): Add "parse_completion" parameter.
4577         (resolve_subexp): Likewise.
4578         (ada_resolve_function): Likewise.
4579
4580 2019-04-04  Tom Tromey  <tom@tromey.com>
4581
4582         * parser-defs.h (struct parser_state) <start_arglist,
4583         end_arglist>: New methods.
4584         <arglist_len, m_funcall_chain>: New members.
4585         (arglist_len, start_arglist, end_arglist): Don't declare.
4586         * parse.c (arglist_len, funcall_chain): Remove global.
4587         (start_arglist, end_arglist): Remove functions.
4588         (parse_exp_in_context): Update.
4589         * p-exp.y: Update rules.
4590         * m2-exp.y: Update rules.
4591         * go-exp.y: Update rules.
4592         * f-exp.y: Update rules.
4593         * d-exp.y: Update rules.
4594         * c-exp.y: Update rules.
4595
4596 2019-04-04  Tom Tromey  <tom@tromey.com>
4597
4598         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4599         lex_operator, push_back>: New methods.
4600         Update all rules.
4601         (rust_parser::lex_hex, lex_escape): Rename and update.
4602         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4603         (rust_parser::lex_operator): Rename and update.
4604         (rust_parser::lex_number, rustyylex, rustyyerror)
4605         (rust_lex_test_init, rust_lex_test_sequence)
4606         (rust_lex_test_push_back, rust_lex_tests): Update.
4607         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4608         parameter.
4609         <lexptr, prev_lexptr>: New members.
4610         (lexptr, prev_lexptr): Don't declare.
4611         * parse.c (lexptr, prev_lexptr): Remove globals.
4612         (parse_exp_in_context): Update.
4613         * p-exp.y (yylex, yyerror): Update.
4614         * m2-exp.y (parse_number, yylex, yyerror): Update.
4615         * go-exp.y (lex_one_token, yyerror): Update.
4616         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4617         * d-exp.y (lex_one_token, yyerror): Update.
4618         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4619         (lex_one_token, yyerror): Update.
4620         * ada-lex.l (YY_INPUT): Update.
4621         (rewind_to_char): Update.
4622         * ada-exp.y (yyerror): Update.
4623
4624 2019-04-04  Tom Tromey  <tom@tromey.com>
4625
4626         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4627         * parser-defs.h (struct parser_state) <parser_state>: Add new
4628         parameter.
4629         <comma_terminates>: New member.
4630         (comma_terminates): Don't declare global.
4631         * parse.c (comma_terminates): Remove global.
4632         (parse_exp_in_context): Update.
4633         * p-exp.y (yylex): Update.
4634         * m2-exp.y (yylex): Update.
4635         * go-exp.y (lex_one_token): Update.
4636         * f-exp.y (yylex): Update.
4637         * d-exp.y (lex_one_token): Update.
4638         * c-exp.y (lex_one_token): Update.
4639         * ada-lex.l: Update.
4640
4641 2019-04-04  Tom Tromey  <tom@tromey.com>
4642
4643         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4644         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4645         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4646         * parser-defs.h (paren_depth): Don't declare.
4647         * parse.c (paren_depth): Remove global.
4648         (parse_exp_in_context): Update.
4649         * p-exp.y (paren_depth): New global.
4650         (pascal_parse): Initialize it.
4651         * m2-exp.y (paren_depth): New global.
4652         (m2_parse): Initialize it.
4653         * go-exp.y (paren_depth): New global.
4654         (go_parse): Initialize it.
4655         * f-exp.y (paren_depth): New global.
4656         (f_parse): Initialize it.
4657         * d-exp.y (paren_depth): New global.
4658         (d_parse): Initialize it.
4659         * c-exp.y (paren_depth): New global.
4660         (c_parse): Initialize it.
4661         * ada-lex.l (paren_depth): New global.
4662         (lexer_init): Initialize it.
4663
4664 2019-04-04  Tom Tromey  <tom@tromey.com>
4665
4666         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4667         (rust_parser::convert_ast_to_type)
4668         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4669         * parser-defs.h (struct parser_state) <parser_state>: Add
4670         parameters.  Initialize new members.
4671         <expression_context_block, expression_context_pc>: New members.
4672         * parse.c (expression_context_block, expression_context_pc):
4673         Remove globals.
4674         (parse_exp_in_context): Update.
4675         * p-exp.y: Update all rules.
4676         (yylex): Update.
4677         * m2-exp.y: Update all rules.
4678         (yylex): Update.
4679         * go-exp.y (yylex): Update.
4680         * f-exp.y (yylex): Update.
4681         * d-exp.y: Update all rules.
4682         (yylex): Update.
4683         * c-exp.y: Update all rules.
4684         (lex_one_token, classify_name, yylex, c_parse): Update.
4685         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4686
4687 2019-04-04  Tom Tromey  <tom@tromey.com>
4688
4689         * gdbarch.h, gdbarch.c: Rebuild.
4690         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4691         * stap-probe.h:
4692         (struct stap_parse_info): Replace "parser_state" with
4693         "expr_builder".
4694         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4695         (parser_state): New class.
4696         * parse.c (expr_builder): Rename.
4697         (expr_builder::release): Rename.
4698         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4699         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4700         (write_exp_elt_longcst, write_exp_elt_floatcst)
4701         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4702         (write_exp_string_vector, write_exp_bitstring)
4703         (write_exp_msymbol, mark_struct_expression)
4704         (write_dollar_variable)
4705         (insert_type_address_space, increase_expout_size): Replace
4706         "parser_state" with "expr_builder".
4707         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4708         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4709         "parser_state" with "expr_builder".
4710
4711 2019-04-04  Tom Tromey  <tom@tromey.com>
4712
4713         * rust-exp.y: Replace "parse_language" with method call.
4714         * p-exp.y:
4715         (yylex): Replace "parse_language" with method call.
4716         * m2-exp.y:
4717         (yylex): Replace "parse_language" with method call.
4718         * go-exp.y (classify_name): Replace "parse_language" with method
4719         call.
4720         * f-exp.y (yylex): Replace "parse_language" with method call.
4721         * d-exp.y (lex_one_token): Replace "parse_language" with method
4722         call.
4723         * c-exp.y:
4724         (lex_one_token, classify_name, yylex): Replace "parse_language"
4725         with method call.
4726         * ada-exp.y (find_primitive_type, type_char)
4727         (type_system_address): Replace "parse_language" with method call.
4728
4729 2019-04-04  Tom Tromey  <tom@tromey.com>
4730
4731         * rust-exp.y: Replace "parse_gdbarch" with method call.
4732         * parse.c (write_dollar_variable, insert_type_address_space):
4733         Replace "parse_gdbarch" with method call.
4734         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4735         call.
4736         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4737         call.
4738         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4739         "parse_gdbarch" with method call.
4740         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4741         with method call.
4742         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4743         "parse_gdbarch" with method call.
4744         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4745         "parse_gdbarch" with method call.
4746         * c-exp.y (parse_type, parse_number, classify_name): Replace
4747         "parse_gdbarch" with method call.
4748         * ada-lex.l: Replace "parse_gdbarch" with method call.
4749         * ada-exp.y (parse_type, find_primitive_type, type_char)
4750         (type_system_address): Replace "parse_gdbarch" with method call.
4751
4752 2019-04-04  Tom Tromey  <tom@tromey.com>
4753
4754         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4755         * stap-probe.c (stap_parse_argument): Update.
4756         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4757         initial_size parameter.
4758         * rust-exp.y (rust_lex_tests): Update.
4759         * parse.c (parser_state): Update.
4760         (parse_exp_in_context): Update.
4761         * parser-defs.h (struct parser_state) <parser_state>: Remove
4762         "initial_size" parameter.
4763
4764 2019-04-04  Tom Tromey  <tom@tromey.com>
4765
4766         * parser-defs.h (increase_expout_size): Don't declare.
4767         * parse.c (increase_expout_size): Now static.
4768
4769 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4770
4771         * gnu-nat.c (gnu_nat_target::wait): Fix
4772         target_waitstatus_to_string call.
4773
4774 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4775
4776         * eval.c (evaluate_subexp_standard): Handle internal functions
4777         during Fortran function call handling.
4778
4779 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4780
4781         * NEWS: Mention new internal functions.
4782         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4783         (read_base_type): Use dwarf2_init_complex_target_type.
4784         * value.c (creal_internal_fn): New function.
4785         (cimag_internal_fn): New function.
4786         (_initialize_values): Register new internal functions.
4787
4788 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4789
4790         * infrun.c (stop_all_threads): If debug_infrun, always
4791         trace the wait status after wait_one, using
4792         target_waitstatus_to_string and target_pid_to_str.
4793         (handle_inferior_event): Replace various trace of
4794         wait status kind by a single trace.
4795         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4796         wait status kind image by target_waitstatus_to_string.
4797         * target/waitstatus.c (target_waitstatus_to_string): Fix
4798         obsolete comment.
4799
4800 2019-04-01  Tom Tromey  <tromey@adacore.com>
4801
4802         PR symtab/23331:
4803         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4804
4805 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4806             Pedro Alves  <palves@redhat.com>
4807
4808         * top.c (quit_force): Call 'finalize_values'.
4809         * value.c (finalize_values): New function.
4810         * value.h (finalize_values): Declare.
4811
4812 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4813
4814         * NEWS: Announce $_gdb_major and $_gdb_minor.
4815
4816         * top.c (init_gdb_version_vars): New function.
4817         (gdb_init): Call init_gdb_version_vars.
4818
4819 2019-03-29  Tom Tromey  <tromey@adacore.com>
4820
4821         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4822         help text.  Remove dead code.
4823
4824 2019-03-29  Keith Seitz  <keiths@redhat.com>
4825
4826         From Siddhesh Poyarekar:
4827         * f-lang.h (f77_get_upperbound): Return LONGEST.
4828         (f77_get_lowerbound): Likewise.
4829         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4830         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4831         print them.
4832         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4833         plongest to format print it.
4834         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4835         (f77_get_upperbound): Likewise.
4836         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4837         LOWER_BOUND to LONGEST.
4838         (f77_create_arrayprint_offset_tbl): Likewise.
4839
4840 2019-03-29  Keith Seitz  <keiths@redhat.com>
4841
4842         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4843         %s/pulongest for TYPE_LENGTH instead of %d in format
4844         strings.
4845         * ada-typerint.c (ada_print_type): Likewise.
4846         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4847         * compile/compile-c-support.c (generate_register_struct): Likewise.
4848         * gdbtypes.c (recursive_dump_type): Likewise.
4849         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4850         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4851         instead of %d in format strings.
4852         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4853         to std::min to ULONGEST.
4854         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4855         instead of %d in format strings.
4856         * tracepoint.c (info_scope_command): Likewise.
4857         * typeprint.c (print_offset_data::update)
4858         (print_offset_data::finish): Likewise.
4859         * xtensa-tdep.c (xtensa_store_return_value)
4860         (xtensa_push_dummy_call): Likewise.
4861
4862 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4863
4864         * windows-nat.c (display_selector): Fixed format specifications
4865         for 64-bit Cygwin.
4866
4867 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4868
4869         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4870
4871 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4872
4873         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4874         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4875         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4876         (nios2_linux_init_abi): Install it.
4877
4878 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4879
4880         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4881
4882 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4883
4884         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4885
4886 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4887             Tom Tromey  <tromey@adacore.com>
4888
4889         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4890
4891 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4892
4893         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4894         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4895         method to compute the bounds of range types. Also print "[evaluated]"
4896         if the bounds' values come from a dynamic evaluation.
4897
4898 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4901         whitespace when pretty printing is on.
4902
4903 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4904
4905         * ppc-linux-nat.c: Add include.
4906
4907 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4908
4909         * NEWS: Mention AArch64 Pointer Authentication.
4910
4911 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4912
4913         * arm-linux-nat.c: Add include.
4914
4915 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4916
4917         * source-cache.c (source_cache::get_source_lines): Re-read
4918         fullname after calling open_source_file.
4919
4920 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4921
4922         * NEWS: Mention TLS support for FreeBSD.
4923
4924 2019-03-25  Tom Tromey  <tromey@adacore.com>
4925
4926         * minsyms.c (BUNCH_SIZE): Update comment.
4927         (~minimal_symbol_reader): Remove old comment.
4928         (compact_minimal_symbols): Update comment.
4929         (minimal_symbol_reader::install): Remove old comment.  Update
4930         other comments.
4931
4932 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4933
4934         * s390-linux-nat.c: Add include.
4935
4936 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4937
4938         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4939         Call linux_get_hwcap.
4940         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4941         Likewise.
4942         (aarch64_linux_get_hwcap): Remove function.
4943         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4944         declaration.
4945         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4946         linux_get_hwcap.
4947         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4948         * linux-tdep.c (linux_get_hwcap): Add function.
4949         (linux_get_hwcap2): Likewise.
4950         * linux-tdep.h (linux_get_hwcap): Add declaration.
4951         (linux_get_hwcap2): Likewise.
4952         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4953         (ppc_linux_get_hwcap2): Likewise.
4954         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4955         linux_get_hwcap.
4956         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4957         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4958         (ppc_linux_nat_target::read_description): Likewise.
4959         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4960         * s390-linux-nat.c: Likewise.
4961         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4962
4963 2019-03-24  Tom Tromey  <tom@tromey.com>
4964
4965         * ada-lang.c (standard_lookup): Simplify initialization.
4966         (ada_lookup_symbol_nonlocal): Simplify return.
4967         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4968         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4969         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4970         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4971         initialization.
4972         * solib.c (solib_global_lookup): Simplify.
4973         * symtab.c (null_block_symbol): Remove.
4974         (symbol_cache_lookup): Simplify returns.
4975         (lookup_language_this): Simplify returns.
4976         (lookup_symbol_aux): Simplify return.
4977         (lookup_local_symbol): Simplify returns.
4978         (lookup_global_symbol_from_objfile): Simplify return.
4979         (lookup_symbol_in_objfile_symtabs)
4980         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4981         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4982         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4983         * cp-namespace.c (cp_lookup_bare_symbol)
4984         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4985         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4986         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4987         (cp_lookup_symbol_via_imports): Simplify initialization.
4988         (find_symbol_in_baseclass): Likewise.
4989         * symtab.h (null_block_symbol): Remove.
4990         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4991         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4992         (d_lookup_symbol_module): Likewise.
4993         (find_symbol_in_baseclass): Simplify initialization.
4994
4995 2019-03-24  Tom Tromey  <tom@tromey.com>
4996
4997         * expression.h: Don't include symtab.h.
4998         (struct block): Forward declare.
4999
5000 2019-03-24  Tom Tromey  <tom@tromey.com>
5001
5002         * c-exp.y (typebase): Remove casts.
5003         * gdbtypes.c (lookup_unsigned_typename, )
5004         (lookup_signed_typename): Remove cast.
5005         * eval.c (parse_to_comma_and_eval): Remove cast.
5006         * parse.c (write_dollar_variable): Remove cast.
5007         * block.h (struct block) <superblock>: Now const.
5008         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5009         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5010         (map_block): Make "block" const.
5011         * symfile.h (struct quick_symbol_functions)
5012         <map_matching_symbols>: Constify block argument to "callback".
5013         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5014         const.
5015         (find_pc_sect_compunit_symtab): Make "b" const.
5016         (find_symbol_at_address): Likewise.
5017         (search_symbols): Likewise.
5018         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5019         (dw2_debug_names_lookup_symbol): Likewise.
5020         (dw2_map_matching_symbols): Update.
5021         * p-valprint.c (pascal_val_print): Remove "block".
5022         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5023         (aux_add_nonlocal_symbols): Make "block" const.
5024         (resolve_subexp): Remove cast.
5025         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5026         const.
5027         (iterate_over_file_blocks): Likewise.
5028         * f-exp.y (%union) <bval>: Remove.
5029         * coffread.c (patch_opaque_types): Make "b" const.
5030         * spu-tdep.c (spu_catch_start): Make "block" const.
5031         * c-valprint.c (print_unpacked_pointer): Remove "block".
5032         * symmisc.c (dump_symtab_1): Make "b" const.
5033         (block_depth): Make "block" const.
5034         * d-exp.y (%union) <bval>: Remove.
5035         * cp-support.h (cp_lookup_rtti_type): Update.
5036         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5037         * psymtab.c (psym_lookup_symbol): Make "block" const.
5038         (maintenance_check_psymtabs): Make "b" const.
5039         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5040         (enumerate_locals, enumerate_args): Update.
5041         * python/py-symtab.c (stpy_global_block): Make "block" const.
5042         (stpy_static_block): Likewise.
5043         * inline-frame.c (block_starting_point_at): Make "new_block"
5044         const.
5045         * block.c (find_block_in_blockvector): Make return type const.
5046         (blockvector_for_pc_sect): Make "b" const.
5047         (find_block_in_blockvector): Make "b" const.
5048
5049 2019-03-23  Tom Tromey  <tom@tromey.com>
5050
5051         * varobj.c (varobj_create): Update.
5052         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5053         * printcmd.c (display_command, do_one_display): Don't reset
5054         innermost_block.
5055         * parser-defs.h (enum innermost_block_tracker_type): Move to
5056         expression.h.
5057         (innermost_block): Update comment.
5058         * parse.c (parse_exp_1): Add tracker_types parameter.
5059         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5060         tracker_types parameter.  Reset innermost_block.
5061         (parse_exp_in_context): Remove.
5062         (parse_expression_for_completion): Update.
5063         * objfiles.c (~objfile): Don't reset expression_context_block or
5064         innermost_block.
5065         * expression.h (enum innermost_block_tracker_type): Move from
5066         parser-defs.h.
5067         (parse_exp_1): Add tracker_types parameter.
5068         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5069         reset innermost_block.
5070
5071 2019-03-23  Tom Tromey  <tom@tromey.com>
5072
5073         * objfiles.h: Include bcache.h.
5074
5075 2019-03-23  Tom Tromey  <tom@tromey.com>
5076
5077         * linespec.c (get_current_search_block): Use
5078         scoped_restore_current_language.
5079         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5080
5081 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5082             Jiong Wang  <jiong.wang@arm.com>
5083
5084         * aarch64-linux-tdep.c
5085         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5086         section.
5087         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5088
5089 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5090             Jiong Wang  <jiong.wang@arm.com>
5091
5092         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5093         instructions.
5094         (aarch64_analyze_prologue_test): Add PACIASP test.
5095         (aarch64_prologue_prev_register): Unmask PC value.
5096
5097 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5098             Jiong Wang  <jiong.wang@arm.com>
5099
5100         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5101         (aarch64_dwarf2_prev_register): Unmask PC value.
5102         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5103         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5104         DW_CFA_AARCH64_negate_ra_state.
5105         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5106
5107 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5108             Jiong Wang  <jiong.wang@arm.com>
5109
5110         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5111         registers.
5112         (aarch64_pseudo_register_name): Likewise.
5113         (aarch64_pseudo_register_type): Likewise.
5114         (aarch64_pseudo_register_reggroup_p): Likewise.
5115         (aarch64_gdbarch_init): Add pauth registers.
5116         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5117         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5118         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5119         (struct gdbarch_tdep): Add regnum for ra_state.
5120
5121 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5122             Jiong Wang  <jiong.wang@arm.com>
5123
5124         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5125
5126 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5127             Jiong Wang  <jiong.wang@arm.com>
5128
5129         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5130         function.
5131         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5132         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5133         (aarch64_gdbarch_init): Add puth registers.
5134         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5135         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5136         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5137
5138 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5139             Jiong Wang  <jiong.wang@arm.com>
5140
5141         * aarch64-linux-nat.c
5142         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5143         * aarch64-linux-tdep.c
5144         (aarch64_linux_core_read_description): Likewise.
5145         (aarch64_linux_get_hwcap): New function.
5146         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5147         (aarch64_linux_get_hwcap): New declaration.
5148
5149 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5150             Jiong Wang  <jiong.wang@arm.com>
5151
5152         * aarch64-linux-nat.c
5153         (aarch64_linux_nat_target::read_description): Add pauth param.
5154         * aarch64-linux-tdep.c
5155         (aarch64_linux_core_read_description): Likewise.
5156         * aarch64-tdep.c (struct target_desc): Add in pauth.
5157         (aarch64_read_description): Add pauth param.
5158         (aarch64_gdbarch_init): Likewise.
5159         * aarch64-tdep.h (aarch64_read_description): Likewise.
5160         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5161         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5162         * features/Makefile: Add new files.
5163         * features/aarch64-pauth.c: New file.
5164         * features/aarch64-pauth.xml: New file.
5165
5166 2019-03-20  Tom Tromey  <tromey@adacore.com>
5167
5168         * infrun.c (handle_inferior_event): Rename from
5169         handle_inferior_event_1.  Create a scoped_value_mark.
5170         (handle_inferior_event): Remove.
5171
5172 2019-03-19  Tom Tromey  <tromey@adacore.com>
5173
5174         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5175         * infrun.h (print_stop_event): Add "displays" parameter.
5176         * infrun.c (print_stop_event): Add "displays" parameter.
5177
5178 2019-03-19  Pedro Alves  <palves@redhat.com>
5179
5180         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5181         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5182         to -1.  Fix TABs vs spaces.
5183         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5184         * tui/tui-out.h (tui_ui_out) Add intro comments.
5185         <m_line, m_start_of_line>: In-class initialize, and add describing
5186         comment.
5187
5188 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5189
5190         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5191         variable names.
5192         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5193
5194 2019-03-18  Pedro Alves  <palves@redhat.com>
5195             Eli Zaretskii <eliz@gnu.org>
5196
5197         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5198         m_line and m_start_of_line.
5199
5200 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5201
5202         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5203         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5204         it returns a newline.  This fixes a regression in TU mode, whereby
5205         the next line is output on the same screen line as the user input.
5206
5207 2019-03-18  Tom Tromey  <tromey@adacore.com>
5208
5209         * minsyms.c (minimal_symbol_reader::install): Remove call to
5210         obstack_blank.
5211
5212 2019-03-18  Pedro Alves  <palves@redhat.com>
5213
5214         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5215         New globals.
5216         (apply_style): New, factored out from ...
5217         (apply_ansi_escape): ... this.  Handle reverse video mode.
5218         (tui_set_reverse_mode): New function.
5219         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5220         * tui/tui-winsource.c (tui_show_source_line): Use
5221         tui_set_reverse_mode instead of setting A_STANDOUT.
5222         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5223         New setter methods.
5224
5225 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5226
5227         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5228         Handle tabs.
5229
5230 2019-03-18  Tom Tromey  <tromey@adacore.com>
5231
5232         * ada-lang.c (empty_array): Add "high" parameter.
5233         (ada_evaluate_subexp): Update.
5234
5235 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5236
5237         * unittests/string_view-selftests.c: Define
5238         _initialize_string_view_selftests unconditionally.
5239
5240 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5241
5242         PR gdb/24350
5243         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5244
5245 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5246
5247         PR gdb/24351
5248         * windows-nat.c (display_selector): Fix format specifiers.
5249
5250 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5251
5252         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5253         tui_refill_source_window instead of tui_refresh_win, to update the
5254         current execution line.  This fixes redisplay of the current line
5255         when stepping through the code with "next" or "step".
5256
5257 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5258
5259         * source-cache.c (source_cache::get_source_lines): Call
5260         find_source_lines to initialize s->nlines.  This fixes vertical
5261         scrolling of TUI source window when the DOWN arrow is pressed.
5262
5263 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5264
5265         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5266         linux-thread-db.c (_initialize_thread_db): Likewise.
5267
5268 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5269
5270         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5271         wclrtoeol in tui_show_source_line".  This reverts changes made in
5272         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5273
5274 2019-03-15  Tom Tromey  <tom@tromey.com>
5275
5276         * symtab.h (struct minimal_symbol): Derive from
5277         general_symbol_info.
5278         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5279         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5280         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5281         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5282         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5283         (MSYMBOL_SEARCH_NAME): Update.
5284         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5285         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5286         * minsyms.c (minimal_symbol_reader::record_full): Update.
5287
5288 2019-03-15  Tom Tromey  <tom@tromey.com>
5289
5290         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5291
5292 2019-03-15  Tom Tromey  <tom@tromey.com>
5293
5294         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5295         unique_xmalloc_ptr.
5296         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5297         Update.
5298         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5299         (build_minimal_symbol_hash_tables)
5300         (minimal_symbol_reader::install): Update.
5301
5302 2019-03-15  Tom Tromey  <tom@tromey.com>
5303
5304         * symtab.c (create_demangled_names_hash): Update.
5305         (symbol_set_names): Update.
5306         * objfiles.h (struct objfile_per_bfd_storage)
5307         <demangled_names_hash>: Now an htab_up.
5308         * objfiles.c (objfile_per_bfd_storage): Simplify.
5309
5310 2019-03-15  Tom Tromey  <tom@tromey.com>
5311
5312         * objfiles.h (struct objfile_per_bfd_storage): Declare
5313         destructor.
5314         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5315         New.
5316         (get_objfile_bfd_data): Use new.  Don't initialize
5317         language_of_main.
5318         (free_objfile_per_bfd_storage): Remove.
5319         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5320
5321 2019-03-15  Tom Tromey  <tom@tromey.com>
5322
5323         * symfile.c (reread_symbols): Update.
5324         * objfiles.c (objfile::objfile): Update.
5325         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5326         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5327         comment.
5328         (minimal_symbol_reader::install): Update.
5329         (terminate_minimal_symbol_table): Remove.
5330         * jit.c (jit_object_close_impl): Update.
5331
5332 2019-03-15  Tom Tromey  <tom@tromey.com>
5333
5334         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5335         initializations.
5336
5337 2019-03-15  Tom Tromey  <tom@tromey.com>
5338
5339         * objfiles.h (struct objfile_per_bfd_storage)
5340         <demangled_hash_languages>: Now a bitset.
5341         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5342         (lookup_minimal_symbol): Update.
5343
5344 2019-03-15  Tom Tromey  <tom@tromey.com>
5345
5346         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5347         Don't return the symbol.
5348         * coffread.c (record_minimal_symbol): Use record_full.
5349
5350 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5351
5352         The MS-Windows port of ncurses fails to switch to a color pair if
5353         one or both of the colors are the implicit default colors.  This
5354         change records the default colors when TUI is initialized, and
5355         then specifies them explicitly when a color pair uses the default
5356         colors.  This allows color styling in TUI mode on MS-Windows.
5357
5358         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5359         ncurses_norm_attr.
5360         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5361         colors in ncurses_norm_attr.
5362         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5363         "none", replace it with the default color recorded in
5364         ncurses_norm_attr.
5365
5366 2019-03-14  Tom Tromey  <tromey@adacore.com>
5367
5368         * source-cache.h (class source_cache) <get_source_lines>: Return
5369         std::string.
5370         * source-cache.c (source_cache::extract_lines): Handle case where
5371         first_pos==npos.  Return std::string.
5372         (source_cache::get_source_lines): Update.
5373
5374 2019-03-14  Tom Tromey  <tromey@adacore.com>
5375
5376         * NEWS: Add item for "style sources" commands.
5377         * source-cache.c (source_cache::get_source_lines): Check
5378         source_styling.
5379         * cli/cli-style.c (source_styling): New global.
5380         (_initialize_cli_style): Add "style sources" commands.
5381         (show_style_sources): New function.
5382         * cli/cli-style.h (source_styling): Declare.
5383
5384 2019-03-14  Pedro Alves  <palves@redhat.com>
5385             Tom Tromey  <tromey@adacore.com>
5386
5387         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5388         * tui/tui-winsource.c (tui_refill_source_window): New function,
5389         from...
5390         (tui_horizontal_source_scroll): ... here.  Move some logic.
5391         * cli/cli-style.c (set_style_enabled): Notify new observable.
5392         * tui/tui-hooks.c (tui_redisplay_source): New function.
5393         (tui_attach_detach_observers): Attach or detach
5394         tui_redisplay_source.
5395         * observable.h (source_styling_changed): New observable.
5396         * observable.c: Define source_styling_changed observable.
5397
5398 2019-03-13  Tom Tromey  <tromey@adacore.com>
5399
5400         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5401         (i386_gnu_nat_target::store_registers): Update.
5402         * target-debug.h (target_debug_print_std_string): New macro.
5403         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5404         * windows-tdep.c (display_one_tib): Update.
5405         * tui/tui-stack.c (tui_make_status_line): Update.
5406         * top.c (print_inferior_quit_action): Update.
5407         * thread.c (thr_try_catch_cmd): Update.
5408         (add_thread_with_info): Update.
5409         (thread_target_id_str): Update.
5410         (thr_try_catch_cmd): Update.
5411         (thread_command): Update.
5412         (thread_find_command): Update.
5413         * record-btrace.c (record_btrace_target::info_record)
5414         (record_btrace_resume_thread, record_btrace_target::resume)
5415         (record_btrace_cancel_resume, record_btrace_step_thread)
5416         (record_btrace_target::wait, record_btrace_target::wait)
5417         (record_btrace_target::wait, record_btrace_target::stop): Update.
5418         * progspace.c (print_program_space): Update.
5419         * process-stratum-target.c
5420         (process_stratum_target::thread_address_space): Update.
5421         * linux-fork.c (linux_fork_mourn_inferior)
5422         (detach_checkpoint_command, info_checkpoints_command)
5423         (linux_fork_context): Update.
5424         (linux_fork_detach): Update.
5425         (class scoped_switch_fork_info): Update.
5426         (delete_checkpoint_command): Update.
5427         * infrun.c (follow_fork_inferior): Update.
5428         (follow_fork_inferior): Update.
5429         (proceed_after_vfork_done): Update.
5430         (handle_vfork_child_exec_or_exit): Update.
5431         (follow_exec): Update.
5432         (displaced_step_prepare_throw): Update.
5433         (displaced_step_restore): Update.
5434         (start_step_over): Update.
5435         (resume_1): Update.
5436         (clear_proceed_status_thread): Update.
5437         (proceed): Update.
5438         (print_target_wait_results): Update.
5439         (do_target_wait): Update.
5440         (context_switch): Update.
5441         (stop_all_threads): Update.
5442         (restart_threads): Update.
5443         (finish_step_over): Update.
5444         (handle_signal_stop): Update.
5445         (switch_back_to_stepped_thread): Update.
5446         (keep_going_pass_signal): Update.
5447         (print_exited_reason): Update.
5448         (normal_stop): Update.
5449         * inferior.c (inferior_pid_to_str): Change return type.
5450         (print_selected_inferior): Update.
5451         (add_inferior): Update.
5452         (detach_inferior): Update.
5453         * dummy-frame.c (fprint_dummy_frames): Update.
5454         * dcache.c (dcache_info_1): Update.
5455         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5456         (btrace_fetch, btrace_clear): Update.
5457         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5458         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5459         type.
5460         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5461         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5462         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5463         * gdbarch.c, gdbarch.h: Rebuild.
5464         * gdbarch.sh (core_pid_to_str): Change return type.
5465         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5466         return type.
5467         (windows_nat_target::pid_to_str): Change return type.
5468         (windows_delete_thread): Update.
5469         (windows_nat_target::attach): Update.
5470         (windows_nat_target::files_info): Update.
5471         * target-delegates.c: Rebuild.
5472         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5473         return type.
5474         (sol_thread_target::pid_to_str): Change return type.
5475         * remote.c (class remote_target) <pid_to_str>: Change return
5476         type.
5477         (remote_target::pid_to_str): Change return type.
5478         (extended_remote_target::attach, remote_target::remote_stop_ns)
5479         (remote_target::remote_notif_remove_queued_reply)
5480         (remote_target::push_stop_reply, remote_target::disable_btrace):
5481         Update.
5482         (extended_remote_target::attach): Update.
5483         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5484         type.
5485         (gdbsim_target::pid_to_str): Change return type.
5486         * ravenscar-thread.c (struct ravenscar_thread_target)
5487         <pid_to_str>: Change return type.
5488         (ravenscar_thread_target::pid_to_str): Change return type.
5489         * procfs.c (class procfs_target) <pid_to_str>: Change return
5490         type.
5491         (procfs_target::pid_to_str): Change return type.
5492         (procfs_target::attach): Update.
5493         (procfs_target::detach): Update.
5494         (procfs_target::fetch_registers): Update.
5495         (procfs_target::store_registers): Update.
5496         (procfs_target::wait): Update.
5497         (procfs_target::files_info): Update.
5498         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5499         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5500         return type.
5501         (nto_procfs_target::pid_to_str): Change return type.
5502         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5503         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5504         return type.
5505         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5506         (exit_lwp): Update.
5507         (attach_proc_task_lwp_callback, get_detach_signal)
5508         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5509         (linux_nat_target::resume, wait_lwp, stop_callback)
5510         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5511         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5512         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5513         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5514         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5515         type.
5516         (inf_ptrace_target::attach): Update.
5517         (inf_ptrace_target::files_info): Update.
5518         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5519         type.
5520         (go32_nat_target::pid_to_str): Change return type.
5521         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5522         (gnu_nat_target::wait): Update.
5523         (gnu_nat_target::wait): Update.
5524         (gnu_nat_target::resume): Update.
5525         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5526         (fbsd_nat_target::wait): Update.
5527         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5528         type.
5529         (darwin_nat_target::attach): Update.
5530         * corelow.c (class core_target) <pid_to_str>: Change return type.
5531         (core_target::pid_to_str): Change return type.
5532         * target.c (normal_pid_to_str): Change return type.
5533         (default_pid_to_str): Likewise.
5534         (target_pid_to_str): Change return type.
5535         (target_translate_tls_address): Update.
5536         (target_announce_detach): Update.
5537         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5538         return type.
5539         (bsd_uthread_target::pid_to_str): Change return type.
5540         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5541         type.
5542         (bsd_kvm_target::pid_to_str): Change return type.
5543         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5544         return type.
5545         (aix_thread_target::pid_to_str): Change return type.
5546         * target.h (struct target_ops) <pid_to_str>: Change return type.
5547         (target_pid_to_str, normal_pid_to_str): Likewise.
5548         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5549         type.
5550         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5551         type.
5552         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5553         return type.
5554         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5555         type.
5556         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5557         type.
5558         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5559         return type.
5560
5561 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5562
5563         * NEWS: Mention that the new default MI version is 3.  Mention
5564         changes to the output of commands and events that deal with
5565         multi-location breakpoints.
5566         * breakpoint.c: Include "mi/mi-out.h".
5567         (print_one_breakpoint): Change output syntax if using MI version
5568         >= 3.
5569         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5570         New.
5571         (mi_multi_location_breakpoint_output_fixed): New.
5572         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5573         (mi_cmd_fix_multi_location_breakpoint_output): New.
5574         (mi_multi_location_breakpoint_output_fixed): New.
5575         * mi/mi-cmds.c (mi_cmds): Register command
5576         -fix-multi-location-breakpoint-output.
5577         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5578         interpreter "mi".
5579
5580 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5581
5582         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5583         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5584         instantiate mi_ui_out based on interpreter name.
5585         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5586         * mi/mi-main.c (mi_load_progress): Likewise.
5587
5588 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5589
5590         * NEWS: Combine separate "New targets" sections for 8.3.
5591
5592 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5593
5594         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5595         (ppcfbsd_init_abi): Install gdbarch
5596         "fetch_tls_load_module_address" and "get_thread_local_address"
5597         methods.
5598
5599 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5600
5601         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5602         (riscv_fbsd_init_abi): Install gdbarch
5603         "fetch_tls_load_module_address" and "get_thread_local_address"
5604         methods.
5605
5606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5607
5608         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5609         (i386fbsd_init_abi): Install gdbarch
5610         "fetch_tls_load_module_address" and "get_thread_local_address"
5611         methods.
5612
5613 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5614
5615         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5616         (amd64fbsd_init_abi): Install gdbarch
5617         "fetch_tls_load_module_address" and "get_thread_local_address"
5618         methods.
5619
5620 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5621
5622         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5623         (struct fbsd_pspace_data): New type.
5624         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5625         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5626         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5627         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5628         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5629
5630 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5631
5632         * gdbtypes.c (lookup_struct_elt): New function.
5633         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5634         * gdbtypes.h (struct struct_elt): New type.
5635         (lookup_struct_elt): New prototype.
5636
5637 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5638
5639         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5640         remove disabled code block.
5641
5642 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5643
5644         * gdbarch.sh (get_thread_local_address): New method.
5645         * gdbarch.h, gdbarch.c: Regenerate.
5646         * target.c (target_translate_tls_address): Use
5647         gdbarch_get_thread_local_address if present instead of
5648         target::get_thread_local_address.
5649
5650 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5651
5652         * target.h (target::get_thread_local_address): Update comment.
5653
5654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5655
5656         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5657         objfile->separate_debug_objfile_backlink if not NULL.
5658
5659 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5660
5661         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5662         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5663         (amd64bsd_store_inferior_registers): Likewise.
5664         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5665         Enable segment base registers.
5666         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5667         PT_GETFSBASE and PT_GETGSBASE.
5668         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5669         PT_SETGSBASE.
5670         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5671         segment base registers.
5672         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5673
5674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5675
5676         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5677         Update calls to i386_target_description to add 'segments'
5678         parameter.
5679         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5680         add segment base registers.
5681         * arch/i386.c (i386_create_target_description): Add 'segments'
5682         parameter to enable segment base registers.
5683         * arch/i386.h (i386_create_target_description): Likewise.
5684         * features/i386/32bit-segments.xml: New file.
5685         * features/i386/32bit-segments.c: Generate.
5686         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5687         call to i386_target_description to add 'segments' parameter.
5688         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5689         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5690         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5691         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5692         if feature is present.
5693         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5694         Add 'segments' parameter to call to i386_target_description.
5695         (i386_target_description): Add 'segments' parameter to enable
5696         segment base registers.
5697         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5698         to call to i386_target_description.
5699         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5700         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5701         Define I386_NUM_REGS.
5702         (i386_target_description): Add 'segments' parameter to enable
5703         segment base registers.
5704
5705 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5706
5707         PR/24325
5708         * source-cache.c: #undef open and close, to avoid unresolved
5709         externals during linking.
5710
5711 2019-03-12  Tom Tromey  <tromey@adacore.com>
5712
5713         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5714         const.  Add initializers.
5715         (_initialize_remote): Don't initialize ptid globals.
5716
5717 2019-03-12  Pedro Alves  <palves@redhat.com>
5718
5719         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5720
5721 2019-03-12  Pedro Alves  <palves@redhat.com>
5722
5723         * cp-name-parser.y (main): Remove unused 'len' variable.
5724
5725 2019-03-12  Tom Tromey  <tromey@adacore.com>
5726
5727         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5728         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5729
5730 2019-03-12  Tom Tromey  <tromey@adacore.com>
5731
5732         * linux-nat.c (iterate_over_lwps): Update.
5733         (stop_callback): Remove parameter.
5734         (stop_wait_callback, detach_callback, resume_set_callback)
5735         (select_singlestep_lwp_callback, set_ignore_sigint)
5736         (status_callback, resumed_callback, resume_clear_callback)
5737         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5738         data parameter.
5739         (linux_nat_target::detach, linux_nat_target::resume)
5740         (linux_stop_and_wait_all_lwps, select_event_lwp)
5741         (linux_nat_filter_event, linux_nat_wait_1)
5742         (linux_nat_target::kill, linux_nat_target::stop)
5743         (linux_nat_target::stop): Update.
5744         (linux_nat_resume_callback): Change type.
5745         (resume_stopped_resumed_lwps, count_events_callback)
5746         (select_event_lwp_callback): Likewise.
5747         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5748         * arm-linux-nat.c (struct update_registers_data): Remove.
5749         (update_registers_callback): Change type.
5750         (arm_linux_insert_hw_breakpoint1): Update.
5751         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5752         parameter.
5753         (x86_linux_dr_set_addr): Update.
5754         (x86_linux_dr_set_control): Update.
5755         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5756         (iterate_over_lwps): Use gdb::function_view.
5757         * nat/aarch64-linux-hw-point.c (struct
5758         aarch64_dr_update_callback_param): Remove.
5759         (debug_reg_change_callback): Change type.
5760         (aarch64_notify_debug_reg_change): Update.
5761         * s390-linux-nat.c (s390_refresh_per_info): Update.
5762
5763 2019-03-11  Tom Tromey  <tromey@adacore.com>
5764
5765         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5766         redundant assignment to "this_cu".
5767
5768 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5769
5770         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5771
5772 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5773
5774         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5775         from...
5776         (rank_one_type): ... this.
5777
5778 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5779
5780         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5781         from...
5782         (rank_one_type): ... this.
5783
5784 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5785
5786         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5787         from...
5788         (rank_one_type): ... this.
5789
5790 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5791
5792         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5793         from...
5794         (rank_one_type): ... this.
5795
5796 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5797
5798         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5799         from...
5800         (rank_one_type): ... this.
5801
5802 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5803
5804         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5805         from...
5806         (rank_one_type): ... this.
5807
5808 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5809
5810         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5811         from...
5812         (rank_one_type): ... this.
5813
5814 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5815
5816         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5817         from...
5818         (rank_one_type): ... this.
5819
5820 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5821
5822         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5823         from...
5824         (rank_one_type): ... this.
5825
5826 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5827
5828         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5829         from...
5830         (rank_one_type): ... this.
5831
5832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5833
5834         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5835         from...
5836         (rank_one_type): ... this.
5837
5838 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5839
5840         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5841         from...
5842         (rank_one_type): ... this.
5843
5844 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5845
5846         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5847         inferior-events' shows the example events.
5848
5849 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5850
5851         Support styling on native MS-Windows console
5852
5853         PR/24315
5854         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5855         on MS-Windows if $TERM is not defined.
5856
5857         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5858
5859         * posix-hdep.c (gdb_console_fputs):
5860         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5861         functions.
5862         * ui-file.h (gdb_console_fputs): Add prototype.
5863
5864         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5865         back to fputs only if the former returns zero.
5866
5867 2019-03-07  Tom Tromey  <tom@tromey.com>
5868
5869         * symmisc.c (print_symbol_bcache_statistics): Update.
5870         (print_objfile_statistics): Update.
5871         * symfile.c (allocate_symtab): Update.
5872         * stabsread.c: Don't include bcache.h.
5873         * psymtab.h (struct psymbol_bcache): Don't declare.
5874         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5875         (psymbol_bcache_init, psymbol_bcache_free)
5876         (psymbol_bcache_get_bcache): Don't declare.
5877         * psymtab.c (struct psymbol_bcache): Remove.
5878         (psymtab_storage::psymtab_storage): Update.
5879         (psymtab_storage::~psymtab_storage): Update.
5880         (psymbol_bcache_init, psymbol_bcache_free)
5881         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5882         (add_psymbol_to_bcache): Update.
5883         (allocate_psymtab): Update.
5884         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5885         macro_cache>: No longer pointers.
5886         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5887         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5888         * macrotab.c (macro_bcache): Update.
5889         * macroexp.c: Don't include bcache.h.
5890         * gdbtypes.c (check_types_worklist): Update.
5891         (types_deeply_equal): Remove TRY/CATCH.  Update.
5892         * elfread.c (elf_symtab_read): Update.
5893         * dwarf2read.c: Don't include bcache.h.
5894         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5895         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5896         (print_bcache_statistics, bcache_memory_used): Don't declare.
5897         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5898         methods.  Rename all data members.
5899         * bcache.c (struct bcache): Move to bcache.h.
5900         (bcache::expand_hash_table): Rename from expand_hash_table.
5901         (bcache): Remove.
5902         (bcache::insert): Rename from bcache_full.
5903         (bcache::compare): Rename from bcache_compare.
5904         (bcache_xmalloc): Remove.
5905         (bcache::~bcache): Rename from bcache_xfree.
5906         (bcache::print_statistics): Rename from print_bcache_statistics.
5907         (bcache::memory_used): Rename from bcache_memory_used.
5908
5909 2019-03-07  Pedro Alves  <palves@redhat.com>
5910
5911         * infrun.c (normal_stop): Also check for
5912         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5913
5914 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5915
5916         * f-lang.c (value_from_host_double): Moved to...
5917         * value.c (value_from_host_double): ...here.
5918         * value.h (value_from_host_double): Declare.
5919         * guile/scm-math.c (vlscm_convert_typed_number): Use
5920         value_from_host_double.
5921         (vlscm_convert_number): Likewise.
5922         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5923         * python/py-value.c (convert_value_from_python): Likewise.
5924
5925 2019-03-06  Tom Tromey  <tom@tromey.com>
5926
5927         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5928
5929 2019-03-06  Tom Tromey  <tom@tromey.com>
5930
5931         * utils.h (free_current_contents): Don't declare.
5932         * utils.c (free_current_contents): Remove.
5933
5934 2019-03-06  Tom Tromey  <tom@tromey.com>
5935
5936         * top.c (quit_force): Update.
5937         * main.c (captured_command_loop): Update.
5938         * common/new-op.c (operator new): Update.
5939         * common/common-exceptions.c (struct catcher)
5940         <save_cleanup_chain>: Remove member.
5941         (exceptions_state_mc_init): Update.
5942         (exception_try_scope_entry): Return nullptr.
5943         (exception_try_scope_exit, exception_rethrow)
5944         (throw_exception_sjlj, throw_exception_cxx): Update.
5945         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5946         (all_cleanups, do_cleanups, discard_cleanups)
5947         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5948         (restore_cleanups, restore_final_cleanups): Don't declare.
5949         (do_final_cleanups): Remove parameter.
5950         * common/cleanups.c (cleanup_chain, make_cleanup)
5951         (make_cleanup_dtor, all_cleanups, do_cleanups)
5952         (discard_my_cleanups, discard_cleanups)
5953         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5954         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5955         (null_cleanup): Remove.
5956         (do_final_cleanups): Remove parameter.
5957
5958 2019-03-06  Tom Tromey  <tom@tromey.com>
5959
5960         * remote.c (remote_target::remote_parse_stop_reply): Use
5961         unique_xmalloc_ptr.
5962
5963 2019-03-06  Tom Tromey  <tom@tromey.com>
5964
5965         * stabsread.c (struct stabs_field_info): Rename from field_info.
5966         <list, fnlist>: Add initializers.
5967         <obstack>: New member.
5968         (read_member_functions, read_struct_fields, read_baseclasses):
5969         Allocate on obstack.  Don't use cleanups.
5970         (read_one_struct_field, read_member_functions, read_struct_fields)
5971         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5972         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5973         (read_struct_type): Update.
5974
5975 2019-03-06  Tom Tromey  <tom@tromey.com>
5976
5977         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5978         * common/filestuff.h (make_cleanup_close): Don't declare.
5979         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5980         Remove.
5981
5982 2019-03-06  Tom Tromey  <tom@tromey.com>
5983
5984         * solib-aix.c: Use make_scope_exit.
5985
5986 2019-03-06  Tom Tromey  <tom@tromey.com>
5987
5988         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5989         Use make_scope_exit.
5990
5991 2019-03-06  Tom Tromey  <tom@tromey.com>
5992
5993         * solib-svr4.c (disable_probes_interface): Remove parameter.
5994         (svr4_handle_solib_event): Use make_scope_exit.
5995
5996 2019-03-06  Tom Tromey  <tom@tromey.com>
5997
5998         * remote.c (struct stop_reply_deleter): Remove.
5999         (stop_reply_up): Update.
6000         (struct stop_reply): Derive from notif_event.  Don't typedef.
6001         <regcache>: Now a std::vector.
6002         (stop_reply_xfree): Remove.
6003         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6004         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6005         (remote_target::discard_pending_stop_replies): Use delete.
6006         (remote_target::remote_parse_stop_reply): Update.
6007         (remote_target::process_stop_reply): Update.
6008         * remote-notif.h (struct notif_event): Add virtual destructor.
6009         Remove "dtr" member.
6010         (struct notif_client) <alloc_event>: Return a unique_ptr.
6011         (notif_event_xfree): Don't declare.
6012         (notif_event_up): New typedef.
6013         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6014         (notif_event_xfree, do_notif_event_xfree): Remove.
6015         (remote_notif_state_xfree): Update.
6016
6017 2019-03-06  Tom Tromey  <tom@tromey.com>
6018
6019         * infrun.c (displaced_step_clear_cleanup): Now a
6020         forward_scope_exit type.
6021         (displaced_step_prepare_throw): Update.
6022         (displaced_step_fixup): Update.
6023
6024 2019-03-06  Tom Tromey  <tom@tromey.com>
6025
6026         * inferior.h (class inferior): Update comment.
6027         * gdbthread.h (class thread_info): Update comment.
6028
6029 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6030             Tom Tromey  <tom@tromey.com>
6031
6032         * stabsread.h (struct stab_section_list): Remove.
6033         (coffstab_build_psymtabs): Update.
6034         * dbxread.c (symbuf_sections): Now a std::vector.
6035         (sect_idx): New global.
6036         (fill_symbuf): Update.
6037         (coffstab_build_psymtabs): Change type of stabsects parameter.
6038         Update.
6039         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6040         std::vector.
6041         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6042         (coff_locate_sections): Update.
6043         (coff_symfile_read): Remove cleanups.  Update.
6044         (init_stringtab): Add storage parameter.
6045         (free_stringtab, free_stringtab_cleanup): Remove.
6046         (init_lineno): Add storage parameter.
6047         (free_linetab, free_linetab_cleanup): Remove.
6048
6049 2019-03-06  Pedro Alves  <palves@redhat.com>
6050
6051         * linux-fork.c (fork_info::clobber_regs): Delete.
6052         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6053         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6054         comment.  Adjust.
6055         (scoped_switch_fork_info::scoped_switch_fork_info)
6056         (checkpoint_command, linux_fork_context): Adjust
6057         fork_save_infrun_state calls.
6058
6059 2019-03-06  Pedro Alves  <palves@redhat.com>
6060
6061         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6062         (inf_has_multiple_threads): Return 'bool' and rewrite using
6063         inferior_info::threads().
6064
6065 2019-03-06  Pedro Alves  <palves@redhat.com>
6066
6067         * linux-fork.c: Include <list>.
6068         (fork_list): Now a std::list instance.
6069         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6070         (forks_exist_p, find_last_fork): Adjust.
6071         (new_fork): Delete.
6072         (one_fork_p): New.
6073         (add_fork): Adjust.
6074         (free_fork): Delete, folded into fork_info::~fork_info().
6075         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6076         Adjust.
6077         (init_fork_list): Delete.
6078         (linux_fork_killall, linux_fork_mourn_inferior)
6079         (linux_fork_detach, info_checkpoints_command): Adjust.
6080         (_initialize_linux_fork): No longer call init_fork_list.
6081
6082 2019-03-06  Pedro Alves  <palves@redhat.com>
6083
6084         * linux-fork.c (new_fork): New, split out of ...
6085         (add_fork): ... this.  Return void.  Move "first fork" special
6086         case from here, to ...
6087         (checkpoint_command): ... here.
6088         * linux-linux.h (add_fork): Return void.
6089
6090 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6093
6094 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6095             Chris January  <chris.january@arm.com>
6096             David Lecomber  <david.lecomber@arm.com>
6097
6098         * f-exp.y: New token, UNOP_INTRINSIC.
6099         (exp): New pattern using UNOP_INTRINSIC token.
6100         (f77_keywords): Add 'abs' keyword.
6101         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6102         (value_from_host_double): New function.
6103         (evaluate_subexp_f): Support UNOP_ABS.
6104
6105 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6106
6107         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6108         types.
6109
6110 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6111
6112         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6113         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6114         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6115
6116 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6117
6118         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6119
6120 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6121             Chris January  <chris.january@arm.com>
6122
6123         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6124         * f-exp.y: Define 'KIND' token.
6125         (exp): New pattern for KIND expressions.
6126         (ptype): Handle types with a kind extension.
6127         (direct_abs_decl): Extend to spot kind extensions.
6128         (f77_keywords): Add 'kind' to the list.
6129         (push_kind_type): New function.
6130         (convert_to_kind_type): New function.
6131         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6132         * parse.c (operator_length_standard): Likewise.
6133         * parser-defs.h (enum type_pieces): Add tp_kind.
6134         * std-operator.def: Add UNOP_KIND.
6135
6136 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6137
6138         * f-exp.y (f_parse): Set yydebug.
6139
6140 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6141
6142         * f-lang.c (evaluate_subexp_f): New function.
6143         (exp_descriptor_f): New global.
6144         (f_language_defn): Use exp_descriptor_f instead of
6145         exp_descriptor_standard.
6146
6147 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6148
6149         * f-exp.y (struct token): Add comments.
6150         (dot_ops): Remove uppercase versions and the end marker.
6151         (f77_keywords): Likewise.
6152         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6153         entries in the dot_ops array are case insensitive, and use
6154         strncasecmp to compare strings.  Also some whitespace cleanup in
6155         this area.  Similar for the f77_keywords array, except entries in
6156         this list might be case sensitive.
6157
6158 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6159
6160         * f-exp.y (struct f77_boolean_val): Add comments.
6161         (boolean_values): Remove uppercase versions, and end marker.
6162         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6163         and use strncasecmp to achieve case insensitivity.  Additionally,
6164         perform whitespace cleanup around this code.
6165
6166 2019-03-06  Tom Tromey  <tromey@adacore.com>
6167
6168         * remote-sim.c (gdbsim_target_open): Use result of
6169         gdb_argv::release.
6170
6171 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6172         Dirk Schubert  <dirk.schubert@arm.com>
6173         Chris January  <chris.january@arm.com>
6174
6175         * eval.c (evaluate_subexp_standard): Call Fortran argument
6176         wrapping logic.
6177         * f-lang.c (struct value): A value which can be passed into a
6178         Fortran function call.
6179         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6180         where appropriate.
6181         (struct type): Value ready for a Fortran function call.
6182         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6183         is needed.
6184         * f-lang.h (fortran_argument_convert): Declaration.
6185         (fortran_preserve_arg_pointer): Declaration.
6186         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6187
6188 2019-03-05  Tom Tromey  <tromey@adacore.com>
6189
6190         * python/py-prettyprint.c (print_string_repr): Remove #if.
6191         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6192
6193 2019-03-05  Tom Tromey  <tromey@adacore.com>
6194
6195         * target.c (the_dummy_target): Move later.  Change type to
6196         "dummy_target".
6197         (initialize_targets): Don't initialize the_dummy_target.
6198
6199 2019-03-05  Tom Tromey  <tromey@adacore.com>
6200
6201         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6202         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6203
6204 2019-03-05  Tom Tromey  <tromey@adacore.com>
6205
6206         * windows-nat.c (windows_nat_target::attach)
6207         (windows_nat_target::detach): Don't call gdb_flush.
6208         * valprint.c (generic_val_print, val_print, val_print_string):
6209         Don't call gdb_flush.
6210         * utils.c (defaulted_query): Don't call gdb_flush.
6211         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6212         * target.c (target_announce_detach): Don't call gdb_flush.
6213         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6214         * remote.c (extended_remote_target::attach): Don't call
6215         gdb_flush.
6216         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6217         * printcmd.c (do_examine): Don't call gdb_flush.
6218         (info_display_command): Don't call gdb_flush.
6219         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6220         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6221         * memattr.c (info_mem_command): Don't call gdb_flush.
6222         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6223         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6224         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6225         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6226         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6227         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6228         (gnu_nat_target::detach): Don't call gdb_flush.
6229         * f-valprint.c (f_val_print): Don't call gdb_flush.
6230         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6231         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6232         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6233         gdb_flush.
6234         * c-valprint.c (c_val_print): Don't call gdb_flush.
6235         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6236
6237 2019-03-05  Tom Tromey  <tromey@adacore.com>
6238
6239         * varobj.c (update_dynamic_varobj_children): Update.
6240         (install_default_visualizer): Use reset, not release.
6241         * value.c (set_internalvar): Update.
6242         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6243         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6244         ATTRIBUTE_UNUSED_RESULT.
6245
6246 2019-03-05  Tom Tromey  <tromey@adacore.com>
6247
6248         * remote.c (class scoped_remote_fd) <release>: Add
6249         ATTRIBUTE_UNUSED_RESULT.
6250
6251 2019-03-05  Tom Tromey  <tromey@adacore.com>
6252
6253         * macroexp.c (struct macro_buffer) <release>: Add
6254         ATTRIBUTE_UNUSED_RESULT.
6255
6256 2019-03-05  Tom Tromey  <tromey@adacore.com>
6257
6258         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6259         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6260         ATTRIBUTE_UNUSED_RESULT.
6261
6262 2019-03-05  Tom Tromey  <tromey@adacore.com>
6263
6264         * common/scoped_fd.h (class scoped_fd) <release>: Add
6265         ATTRIBUTE_UNUSED_RESULT.
6266
6267 2019-03-05  Tom Tromey  <tromey@adacore.com>
6268
6269         * parser-defs.h (struct parser_state) <release>: Add
6270         ATTRIBUTE_UNUSED_RESULT.
6271
6272 2019-03-05  Tom Tromey  <tromey@adacore.com>
6273
6274         * utils.h (class gdb_argv) <release>: Add
6275         ATTRIBUTE_UNUSED_RESULT.
6276         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6277
6278 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6279
6280         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6281         for-loop range, to avoid compiler warnings.
6282
6283         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6284         avoid compiler warnings about unused variables.
6285
6286         * NEWS: Mention end of support for native debugging on MS-Windows
6287         before XP.
6288
6289         PR gdb/24292
6290         * common/netstuff.c:
6291         * gdbserver/gdbreplay.c
6292         * gdbserver/remote-utils.c:
6293         * ser-tcp.c:
6294         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6295         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6296         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6297         'getaddrinfo' and 'freeaddrinfo' were not available before
6298         Windows XP, and mingw.org's MinGW headers by default define
6299         _WIN32_WINNT to 0x500.
6300
6301 2019-03-01  Gary Benson <gbenson@redhat.com>
6302
6303         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6304
6305 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6306             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6307
6308         PR gdb/8527
6309         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6310         set_sigint_trap, clear_sigint_trap.
6311
6312 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6313
6314         * target.c (target_detach): Clear the regcache and the
6315         frame cache.
6316
6317 2019-02-27  Pedro Alves  <palves@redhat.com>
6318
6319         * utils.c (set_screen_size): When we cap the height/width sizes,
6320         tweak the corresponding command variable to show "unlimited":
6321
6322 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6323             Pedro Alves  <palves@redhat.com>
6324
6325         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6326         before calling rl_set_screen_size.
6327
6328 2019-02-27  Tom Tromey  <tromey@adacore.com>
6329
6330         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6331         define.
6332         * python/py-value.c: Remove Python 2.4 workaround.
6333         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6334         workaround.
6335         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6336         Python 2.4 workaround.
6337         * python/python-internal.h: Remove Python 2.4 comment.
6338         (Py_ssize_t): Don't define.
6339         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6340         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6341         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6342         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6343         * python/python.c (do_start_initialization): Remove Python 2.4
6344         workaround.
6345         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6346         (print_children): Remove Python 2.4 workaround.
6347         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6348         workaround.
6349         (CHARBUFFERPROC_NAME): Remove.
6350         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6351         Python 2.4 workaround.
6352
6353 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6354
6355         * NEWS: Note minimum Python version.
6356
6357 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6358
6359         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6360         code from these functions.  Remove corresponding ifdefs.  Use
6361         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6362         Remove gotos and target of gotos.
6363         (infpy_search_memory): Likewise.
6364
6365 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6366
6367         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6368         (hppa_gdbarch_init): Don't register deleted functions with
6369         gdbarch.
6370
6371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6372
6373         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6374         (h8300_unwind_sp): Delete.
6375         (h8300_dummy_id): Delete.
6376         (h8300_gdbarch_init): Don't register deleted functions with
6377         gdbarch.
6378
6379 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6380
6381         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6382         (ft32_unwind_pc): Delete.
6383         (ft32_unwind_sp): Delete.
6384         (ft32_gdbarch_init): Don't register deleted functions with
6385         gdbarch.
6386
6387 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6388
6389         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6390         (frv_unwind_pc): Delete.
6391         (frv_unwind_sp): Delete.
6392         (frv_gdbarch_init): Don't register deleted functions with
6393         gdbarch.
6394
6395 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6396
6397         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6398         (riscv_unwind_pc): Delete.
6399         (riscv_unwind_sp): Delete.
6400         (riscv_gdbarch_init): Don't register deleted functions with
6401         gdbarch.
6402
6403 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6404
6405         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6406         (csky_unwind_pc): Delete.
6407         (csky_unwind_sp): Delete.
6408         (csky_gdbarch_init): Don't register deleted functions with
6409         gdbarch.
6410
6411 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6412
6413         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6414         (cris_unwind_pc): Delete.
6415         (cris_unwind_sp): Delete.
6416         (cris_gdbarch_init): Don't register deleted functions with
6417         gdbarch.
6418
6419 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6420
6421         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6422         (bfin_unwind_pc): Delete.
6423         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6424
6425 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6426
6427         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6428         (arm_unwind_pc): Delete.
6429         (arm_unwind_sp): Delete.
6430         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6431
6432 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6433
6434         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6435         (arc_unwind_pc): Delete.
6436         (arc_unwind_sp): Delete.
6437         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6438
6439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6440
6441         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6442         (alpha_unwind_pc): Delete.
6443         (alpha_gdbarch_init): Don't register deleted functions with
6444         gdbarch.
6445
6446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6447
6448         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6449         (aarch64_unwind_pc): Delete.
6450         (aarch64_unwind_sp): Delete.
6451         (aarch64_gdbarch_init): Don't register deleted functions with
6452         gdbarch.
6453
6454 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         * gdbtypes.c (type_align): Don't consider static members when
6457         computing structure alignment.
6458
6459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6460
6461         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6462         return 0 for other types.
6463         * arch-utils.c (default_type_align): Always return 0.
6464         * gdbarch.h: Regenerate.
6465         * gdbarch.sh (type_align): Extend comment.
6466         * gdbtypes.c (type_align): Add additional comments, always call
6467         gdbarch_type_align before applying the default rules.
6468         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6469         generic code will then apply a suitable default.
6470         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6471         types, return 0 for other types.
6472
6473 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6474
6475         * NEWS: Create a new section for the next release branch.
6476         Rename the section of the current branch, now that it has
6477         been cut.
6478
6479 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6480
6481         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6482         * version.in: Bump version to 8.3.50.DATE-git.
6483
6484 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6485
6486         * aix-thread.c (ptid_cmp): Remove unused variable.
6487         (get_signaled_thread): Likewise.
6488         (store_regs_user_thread): Likewise.
6489         (store_regs_kernel_thread): Likewise.
6490         (fetch_regs_kernel_thread): Remove shadowed variable.
6491
6492 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6493
6494         * features/riscv/32bit-cpu.xml: Add register numbers.
6495         * features/riscv/32bit-fpu.c: Regenerate.
6496         * features/riscv/32bit-fpu.xml: Add register numbers.
6497         * features/riscv/64bit-cpu.xml: Add register numbers.
6498         * features/riscv/64bit-fpu.c: Regenerate.
6499         * features/riscv/64bit-fpu.xml: Add register numbers.
6500
6501 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6502
6503         * NEWS: Mention two argument form of gdb.Value constructor.
6504         * python/py-value.c (convert_buffer_and_type_to_value): New
6505         function.
6506         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6507         Add support for handling an optional second argument.  Call
6508         convert_buffer_and_type_to_value as appropriate.
6509         * python/python-internal.h (Py_buffer_deleter): New struct.
6510         (Py_buffer_up): New typedef.
6511
6512 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6513
6514         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6515         instead of releasing ownership.
6516
6517 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6518
6519         * dwarf2read.c (open_and_init_dwp_file): Call
6520         elf_numsections instead of bfd_count_sections to initialize
6521         dwp_file->num_sections.
6522
6523 2019-02-25  Tom Tromey  <tromey@adacore.com>
6524
6525         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6526
6527 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6528
6529         * gcore.in: Add '--readnever' option when invoking GDB.
6530
6531 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6532
6533         * MAINTAINERS: Update my email address.
6534
6535 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6536
6537         * build-id.c (build_id_to_debug_bfd_1): New function.
6538         (build_id_to_debug_bfd): Look for separate debug file in
6539         sysroot.
6540
6541 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6542
6543         * gdbarch.sh: Update the copyright year range that is placed into
6544         generated files.
6545
6546 2019-02-22  Keith Seitz  <keiths@redhat.com>
6547
6548         PR symtab/23853
6549         * linespec.c (create_sals_line_offset): Search for the default
6550         symtab's filename instead of its fullname.
6551
6552 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6553
6554         * NEWS: Update style defaults.
6555
6556 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6557
6558         * main.c (captured_main_1): Disable styling in batch mode.
6559
6560 2019-02-20  Tom Tromey  <tom@tromey.com>
6561
6562         * symtab.c (symtab_symbol_info): Fix typos.
6563
6564 2019-02-20  Tom Tromey  <tromey@adacore.com>
6565
6566         * findcmd.c (_initialize_mem_search): Use upper case for
6567         metasyntactic variables.
6568
6569 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6570
6571         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6572         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6573
6574 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6575
6576         * top.h (source_file_name): Change to std::string.
6577         * top.c (source_file_name): Likewise.
6578         (command_line_input): Adjust.
6579         * cli/cli-script.c (script_from_file): Adjust.
6580
6581 2019-02-19  Tom Tromey  <tromey@adacore.com>
6582
6583         * ravenscar-thread.c
6584         (ravenscar_thread_target::update_thread_list): Don't call
6585         ada_build_task_list.
6586         * ada-lang.h (ada_build_task_list): Don't declare.
6587         * ada-tasks.c (struct ada_tasks_inferior_data)
6588         <task_list_valid_p>: Now bool.
6589         (read_known_tasks, ada_task_list_changed)
6590         (ada_tasks_invalidate_inferior_data): Update.
6591         (read_known_tasks_array): Return bool.
6592         (read_known_tasks_list): Likewise.
6593         (read_known_tasks): Return void.
6594         (ada_build_task_list): Now static.
6595
6596 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6597
6598         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6599         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6600
6601 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6602
6603         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6604         variant for ada_tasks_pspace_data_handle and
6605         ada_tasks_inferior_data_handle.
6606         (ada_tasks_pspace_data_cleanup): New function.
6607         (ada_tasks_inferior_data_cleanup): New function.
6608
6609 2019-02-17  Tom Tromey  <tom@tromey.com>
6610
6611         * macrotab.h (macro_source_fullname): Return a std::string.
6612         * macrotab.c (macro_include, check_for_redefinition)
6613         (macro_undef, macro_lookup_definition, foreach_macro)
6614         (foreach_macro_in_scope): Update.
6615         (macro_source_fullname): Return a std::string.
6616         * macrocmd.c (show_pp_source_pos): Update.
6617
6618 2019-02-17  Tom Tromey  <tom@tromey.com>
6619
6620         * macrocmd.c (show_pp_source_pos): Style the file names.
6621
6622 2019-02-17  Tom Tromey  <tom@tromey.com>
6623
6624         PR tui/24197:
6625         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6626
6627 2019-02-17  Tom Tromey  <tom@tromey.com>
6628
6629         * ada-lang.c (user_select_syms): Use filtered printing.
6630         * utils.c (wrap_style): New global.
6631         (desired_style): Remove.
6632         (emit_style_escape): Add stream parameter.
6633         (set_output_style, reset_terminal_style, prompt_for_continue):
6634         Update.
6635         (flush_wrap_buffer): Only flush gdb_stdout.
6636         (wrap_here): Set wrap_style.
6637         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6638         treat escape sequences as a character.  Change when wrap buffer is
6639         flushed.
6640         (fputs_styled): Do not set the output style when the default is
6641         requested.
6642         * ui-style.h (struct ui_file_style) <is_default>: New method.
6643         * source.c (print_source_lines_base): Emit escape sequences in one
6644         piece.
6645
6646 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6647
6648         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6649         integers and enumeration types.
6650
6651 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6652
6653         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6654         instead of lookup_symbol_in_language
6655         (do_exact_match): New function.
6656         (ada_get_symbol_name_matcher): Return do_exact_match when
6657         doing a verbatim match.
6658
6659 2019-02-15  Tom Tromey  <tromey@adacore.com>
6660
6661         * ravenscar-thread.c (ravenscar_thread_target::resume)
6662         (ravenscar_thread_target::wait): Special case wildcard requests.
6663
6664 2019-02-15  Tom Tromey  <tromey@adacore.com>
6665
6666         * ravenscar-thread.c (base_ptid): Remove.
6667         (struct ravenscar_thread_target) <close>: New method.
6668         <m_base_ptid>: New member.
6669         <update_inferior_ptid, active_task, task_is_currently_active,
6670         runtime_initialized>: Declare methods.
6671         <ravenscar_thread_target>: Add constructor.
6672         (ravenscar_thread_target::task_is_currently_active)
6673         (ravenscar_thread_target::update_inferior_ptid)
6674         (ravenscar_runtime_initialized): Rename.  Now methods.
6675         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6676         (ravenscar_thread_target::update_thread_list): Update.
6677         (ravenscar_thread_target::active_task): Now method.
6678         (ravenscar_thread_target::store_registers)
6679         (ravenscar_thread_target::prepare_to_store)
6680         (ravenscar_thread_target::prepare_to_store)
6681         (ravenscar_thread_target::mourn_inferior): Update.
6682         (ravenscar_inferior_created): Use "new" to create target.
6683         (ravenscar_thread_target::get_ada_task_ptid): Update.
6684         (_initialize_ravenscar): Don't initialize base_ptid.
6685         (ravenscar_ops): Remove global.
6686
6687 2019-02-15  Tom Tromey  <tromey@adacore.com>
6688
6689         * target.h (push_target): Declare new overload.
6690         * target.c (push_target): New overload, taking an rvalue reference.
6691         * remote.c (remote_target::open_1): Use push_target overload.
6692         * corelow.c (core_target_open): Use push_target overload.
6693
6694 2019-02-15  Tom Tromey  <tromey@adacore.com>
6695
6696         * ravenscar-thread.c (is_ravenscar_task)
6697         (ravenscar_task_is_currently_active): Return bool.
6698         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6699         (_initialize_ravenscar): Remove "(void)".
6700         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6701         Return bool.
6702
6703 2019-02-15  Tom Tromey  <tromey@adacore.com>
6704
6705         * ravenscar-thread.c (ravenscar_runtime_initializer)
6706         (has_ravenscar_runtime, get_running_thread_id)
6707         (ravenscar_thread_target::resume): Fix indentation.
6708
6709 2019-02-15  Tom Tromey  <tromey@adacore.com>
6710
6711         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6712         from ravenscar_arch_ops.
6713         (sparc_ravenscar_ops::fetch_registers)
6714         (sparc_ravenscar_ops::store_registers): Now methods.
6715         (sparc_ravenscar_prepare_to_store): Remove.
6716         (sparc_ravenscar_ops): Redefine.
6717         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6718         methods and destructor.  Remove members.
6719         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6720         (ravenscar_thread_target::store_registers)
6721         (ravenscar_thread_target::prepare_to_store): Update.
6722         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6723         Remove.
6724         (struct ppc_ravenscar_powerpc_ops): Derive from
6725         ravenscar_arch_ops.
6726         (ppc_ravenscar_powerpc_ops::fetch_registers)
6727         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6728         (ppc_ravenscar_powerpc_ops): Redefine.
6729         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6730         (ppc_ravenscar_e500_ops::fetch_registers)
6731         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6732         (ppc_ravenscar_e500_ops): Redefine.
6733         * aarch64-ravenscar-thread.c
6734         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6735         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6736         (aarch64_ravenscar_fetch_registers)
6737         (aarch64_ravenscar_store_registers): Now methods.
6738         (aarch64_ravenscar_ops): Redefine.
6739
6740 2019-02-15  Tom Tromey  <tromey@adacore.com>
6741
6742         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6743         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6744         (ravenscar_thread_target::stopped_by_watchpoint)
6745         (ravenscar_thread_target::stopped_data_address)
6746         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6747
6748 2019-02-15  Tom Tromey  <tromey@adacore.com>
6749
6750         * ravenscar-thread.c: Fix some typos.
6751
6752 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6753             Tom Tromey  <tromey@adacore.com>
6754
6755         * ada-lang.c (ada_exception_sal): Change addr_string to a
6756         std::string.
6757         (create_ada_exception_catchpoint): Update.
6758
6759 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6760             Tom Tromey  <tromey@adacore.com>
6761
6762         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6763         (bp_location_ops): Remove.
6764         (base_breakpoint_allocate_location): Update.
6765         (free_bp_location): Update.
6766         * ada-lang.c (class ada_catchpoint_location)
6767         <ada_catchpoint_location>: Remove ops parameter.
6768         (ada_catchpoint_location_dtor): Remove.
6769         (ada_catchpoint_location_ops): Remove.
6770         (allocate_location_exception): Update.
6771         * breakpoint.h (struct bp_location_ops): Remove.
6772         (class bp_location) <bp_location>: Remove bp_location_ops
6773         parameter.
6774         <~bp_location>: Add destructor.
6775         <ops>: Remove.
6776
6777 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6778             Pedro Alves  <palves@redhat.com>
6779
6780         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6781         'PATH_MAX'.
6782
6783 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6784             Samuel Thibault  <samuel.thibault@gnu.org>
6785             Thomas Schwinge  <thomas@codesourcery.com>
6786
6787         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6788         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6789
6790 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6791
6792         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6793         (check_empty): Use "const char *".
6794
6795         * gnu-nat.c (gnu_nat_target::detach): Instead of
6796         'detach_inferior (pid)' call
6797         'detach_inferior (find_inferior_pid (pid))'.
6798
6799         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6800         'nat/fork-inferior.o'.
6801         * gnu-nat.c: #include "nat/fork-inferior.h".
6802
6803         * gnu-nat.c (gnu_nat_target::detach): Instead of
6804         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6805         * gnu-nat.h: #include "inf-child.h".
6806         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6807         'i386_gnu_nat_target::fetch_registers'.
6808         (gnu_store_registers): Rename/move to
6809         'i386_gnu_nat_target::store_registers'.
6810
6811         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6812         * gnu-nat.h (mach_thread_info): New function.
6813         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6814
6815         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6816
6817 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6818
6819         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6820
6821 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6822
6823         * windows-nat.c (windows_add_thread): Add new parameter
6824         "main_thread_p" with default value set to false.  Update
6825         function documentation as well as all callers.
6826         (windows_delete_thread): Likewise.
6827         (fake_create_process): Update call to windows_add_thread.
6828         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6829         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6830         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6831         call to windows_delete_thread.
6832
6833 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6834
6835         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6836
6837 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6838
6839         * symfile.c (find_separate_debug_file): Use canonical path of
6840         sysroot with child_path instead of gdb_sysroot if it is valid.
6841
6842 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6843
6844         * symfile.c (find_separate_debug_file): Use child_path to
6845         determine if an object file is under a sysroot.
6846
6847 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6848
6849         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6850         unittests/child-path-selftests.c.
6851         * common/pathstuff.c (child_path): New function.
6852         * common/pathstuff.h (child_path): New prototype.
6853         * unittests/child-path-selftests.c: New file.
6854
6855 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6856
6857         * symfile.c (find_separate_debug_file): Look for separate debug
6858         files in debug directories under the sysroot.
6859
6860 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6861
6862         * symtab.h (struct minimal_symbol data_p): New const method.
6863         (struct minimal_symbol text_p): Likewise.
6864         * symtab.c (output_source_filename): Use file name style
6865         to print file name.
6866         (print_symbol_info): Likewise.
6867         (print_msymbol_info): Use address style to print addresses.
6868         Use function name style to print executable text symbols.
6869         (expand_symtab_containing_pc): Use data_p.
6870         (find_pc_sect_compunit_symtab): Likewise.
6871
6872 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6873
6874         * breakpoint.c (describe_other_breakpoints): Use address style
6875         to print addresses.
6876         (say_where): Likewise.
6877
6878 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6879
6880         * ada-typeprint.c (print_func_type): Print function name
6881         style to print function name.
6882         * c-typeprint.c (c_print_type_1): Likewise.
6883
6884 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6885
6886         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6887         for execve.
6888
6889 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6890
6891         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6892         type_stack.
6893
6894 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6895
6896         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6897         TYPE_CODE_REF types.
6898
6899 2019-02-08  Jim Wilson  <jimw@sifive.com>
6900
6901         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6902         (riscv_linux_fregset): New.
6903         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6904
6905 2019-02-07  Tom Tromey  <tom@tromey.com>
6906
6907         * thread.c (thread_cancel_execution_command): Update.
6908         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6909         methods.
6910         (struct thread_fsm_ops): Remove.
6911         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6912         (thread_fsm_should_stop, thread_fsm_return_value)
6913         (thread_fsm_set_finished, thread_fsm_finished_p)
6914         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6915         Don't declare.
6916         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6917         * infrun.c (clear_proceed_status_thread)
6918         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6919         (print_stop_event): Update.
6920         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6921         Add constructor.
6922         (step_command_fsm_ops): Remove.
6923         (new_step_command_fsm): Remove.
6924         (step_1): Update.
6925         (step_command_fsm::should_stop): Rename from
6926         step_command_fsm_should_stop.
6927         (step_command_fsm::clean_up): Rename from
6928         step_command_fsm_clean_up.
6929         (step_command_fsm::do_async_reply_reason): Rename from
6930         step_command_fsm_async_reply_reason.
6931         (struct until_next_fsm): Inherit from thread_fsm.  Add
6932         constructor.
6933         (until_next_fsm_ops): Remove.
6934         (new_until_next_fsm): Remove.
6935         (until_next_fsm::should_stop): Rename from
6936         until_next_fsm_should_stop.
6937         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6938         (until_next_fsm::do_async_reply_reason): Rename from
6939         until_next_fsm_async_reply_reason.
6940         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6941         constructor.  Change type of breakpoint.
6942         (finish_command_fsm_ops): Remove.
6943         (new_finish_command_fsm): Remove.
6944         (finish_command_fsm::should_stop): Rename from
6945         finish_command_fsm_should_stop.
6946         (finish_command_fsm::clean_up): Rename from
6947         finish_command_fsm_clean_up.
6948         (finish_command_fsm::return_value): Rename from
6949         finish_command_fsm_return_value.
6950         (finish_command_fsm::do_async_reply_reason): Rename from
6951         finish_command_fsm_async_reply_reason.
6952         (finish_command): Update.
6953         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6954         Add constructor.
6955         (call_thread_fsm_ops): Remove.
6956         (call_thread_fsm::call_thread_fsm): Rename from
6957         new_call_thread_fsm.
6958         (call_thread_fsm::should_stop): Rename from
6959         call_thread_fsm_should_stop.
6960         (call_thread_fsm::should_notify_stop): Rename from
6961         call_thread_fsm_should_notify_stop.
6962         (run_inferior_call, call_function_by_hand_dummy): Update.
6963         * cli/cli-interp.c (should_print_stop_to_console): Update.
6964         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6965         Add constructor.  Change type of location_breakpoint,
6966         caller_breakpoint.
6967         (until_break_fsm_ops): Remove.
6968         (new_until_break_fsm): Remove.
6969         (until_break_fsm::should_stop): Rename from
6970         until_break_fsm_should_stop.
6971         (until_break_fsm::clean_up): Rename from
6972         until_break_fsm_clean_up.
6973         (until_break_fsm::do_async_reply_reason): Rename from
6974         until_break_fsm_async_reply_reason.
6975         (until_break_command): Update.
6976         * thread-fsm.c: Remove.
6977         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6978
6979 2019-02-07  Tom Tromey  <tom@tromey.com>
6980
6981         * yy-remap.h: Add include guard.
6982         * xtensa-tdep.h: Add include guard.
6983         * xcoffread.h: Rename include guard.
6984         * varobj-iter.h: Add include guard.
6985         * tui/tui.h: Rename include guard.
6986         * tui/tui-winsource.h: Rename include guard.
6987         * tui/tui-wingeneral.h: Rename include guard.
6988         * tui/tui-windata.h: Rename include guard.
6989         * tui/tui-win.h: Rename include guard.
6990         * tui/tui-stack.h: Rename include guard.
6991         * tui/tui-source.h: Rename include guard.
6992         * tui/tui-regs.h: Rename include guard.
6993         * tui/tui-out.h: Rename include guard.
6994         * tui/tui-layout.h: Rename include guard.
6995         * tui/tui-io.h: Rename include guard.
6996         * tui/tui-hooks.h: Rename include guard.
6997         * tui/tui-file.h: Rename include guard.
6998         * tui/tui-disasm.h: Rename include guard.
6999         * tui/tui-data.h: Rename include guard.
7000         * tui/tui-command.h: Rename include guard.
7001         * tic6x-tdep.h: Add include guard.
7002         * target/waitstatus.h: Rename include guard.
7003         * target/wait.h: Rename include guard.
7004         * target/target.h: Rename include guard.
7005         * target/resume.h: Rename include guard.
7006         * target-float.h: Rename include guard.
7007         * stabsread.h: Add include guard.
7008         * rs6000-tdep.h: Add include guard.
7009         * riscv-fbsd-tdep.h: Add include guard.
7010         * regformats/regdef.h: Rename include guard.
7011         * record.h: Rename include guard.
7012         * python/python.h: Rename include guard.
7013         * python/python-internal.h: Rename include guard.
7014         * python/py-stopevent.h: Rename include guard.
7015         * python/py-ref.h: Rename include guard.
7016         * python/py-record.h: Rename include guard.
7017         * python/py-record-full.h: Rename include guard.
7018         * python/py-record-btrace.h: Rename include guard.
7019         * python/py-instruction.h: Rename include guard.
7020         * python/py-events.h: Rename include guard.
7021         * python/py-event.h: Rename include guard.
7022         * procfs.h: Add include guard.
7023         * proc-utils.h: Add include guard.
7024         * p-lang.h: Add include guard.
7025         * or1k-tdep.h: Rename include guard.
7026         * observable.h: Rename include guard.
7027         * nto-tdep.h: Rename include guard.
7028         * nat/x86-linux.h: Rename include guard.
7029         * nat/x86-linux-dregs.h: Rename include guard.
7030         * nat/x86-gcc-cpuid.h: Add include guard.
7031         * nat/x86-dregs.h: Rename include guard.
7032         * nat/x86-cpuid.h: Rename include guard.
7033         * nat/ppc-linux.h: Rename include guard.
7034         * nat/mips-linux-watch.h: Rename include guard.
7035         * nat/linux-waitpid.h: Rename include guard.
7036         * nat/linux-ptrace.h: Rename include guard.
7037         * nat/linux-procfs.h: Rename include guard.
7038         * nat/linux-osdata.h: Rename include guard.
7039         * nat/linux-nat.h: Rename include guard.
7040         * nat/linux-namespaces.h: Rename include guard.
7041         * nat/linux-btrace.h: Rename include guard.
7042         * nat/glibc_thread_db.h: Rename include guard.
7043         * nat/gdb_thread_db.h: Rename include guard.
7044         * nat/gdb_ptrace.h: Rename include guard.
7045         * nat/fork-inferior.h: Rename include guard.
7046         * nat/amd64-linux-siginfo.h: Rename include guard.
7047         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7048         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7049         * nat/aarch64-linux.h: Rename include guard.
7050         * nat/aarch64-linux-hw-point.h: Rename include guard.
7051         * mn10300-tdep.h: Add include guard.
7052         * mips-linux-tdep.h: Add include guard.
7053         * mi/mi-parse.h: Rename include guard.
7054         * mi/mi-out.h: Rename include guard.
7055         * mi/mi-main.h: Rename include guard.
7056         * mi/mi-interp.h: Rename include guard.
7057         * mi/mi-getopt.h: Rename include guard.
7058         * mi/mi-console.h: Rename include guard.
7059         * mi/mi-common.h: Rename include guard.
7060         * mi/mi-cmds.h: Rename include guard.
7061         * mi/mi-cmd-break.h: Rename include guard.
7062         * m2-lang.h: Add include guard.
7063         * location.h: Rename include guard.
7064         * linux-record.h: Rename include guard.
7065         * linux-nat.h: Add include guard.
7066         * linux-fork.h: Add include guard.
7067         * i386-darwin-tdep.h: Rename include guard.
7068         * hppa-linux-offsets.h: Add include guard.
7069         * guile/guile.h: Rename include guard.
7070         * guile/guile-internal.h: Rename include guard.
7071         * gnu-nat.h: Rename include guard.
7072         * gdb-stabs.h: Rename include guard.
7073         * frv-tdep.h: Add include guard.
7074         * f-lang.h: Add include guard.
7075         * event-loop.h: Add include guard.
7076         * darwin-nat.h: Rename include guard.
7077         * cp-abi.h: Rename include guard.
7078         * config/sparc/nm-sol2.h: Rename include guard.
7079         * config/nm-nto.h: Rename include guard.
7080         * config/nm-linux.h: Add include guard.
7081         * config/i386/nm-i386gnu.h: Rename include guard.
7082         * config/djgpp/nl_types.h: Rename include guard.
7083         * config/djgpp/langinfo.h: Rename include guard.
7084         * compile/gcc-cp-plugin.h: Add include guard.
7085         * compile/gcc-c-plugin.h: Add include guard.
7086         * compile/compile.h: Rename include guard.
7087         * compile/compile-object-run.h: Rename include guard.
7088         * compile/compile-object-load.h: Rename include guard.
7089         * compile/compile-internal.h: Rename include guard.
7090         * compile/compile-cplus.h: Rename include guard.
7091         * compile/compile-c.h: Rename include guard.
7092         * common/xml-utils.h: Rename include guard.
7093         * common/x86-xstate.h: Rename include guard.
7094         * common/version.h: Rename include guard.
7095         * common/vec.h: Rename include guard.
7096         * common/tdesc.h: Rename include guard.
7097         * common/selftest.h: Rename include guard.
7098         * common/scoped_restore.h: Rename include guard.
7099         * common/scoped_mmap.h: Rename include guard.
7100         * common/scoped_fd.h: Rename include guard.
7101         * common/safe-iterator.h: Rename include guard.
7102         * common/run-time-clock.h: Rename include guard.
7103         * common/refcounted-object.h: Rename include guard.
7104         * common/queue.h: Rename include guard.
7105         * common/ptid.h: Rename include guard.
7106         * common/print-utils.h: Rename include guard.
7107         * common/preprocessor.h: Rename include guard.
7108         * common/pathstuff.h: Rename include guard.
7109         * common/observable.h: Rename include guard.
7110         * common/netstuff.h: Rename include guard.
7111         * common/job-control.h: Rename include guard.
7112         * common/host-defs.h: Rename include guard.
7113         * common/gdb_wait.h: Rename include guard.
7114         * common/gdb_vecs.h: Rename include guard.
7115         * common/gdb_unlinker.h: Rename include guard.
7116         * common/gdb_unique_ptr.h: Rename include guard.
7117         * common/gdb_tilde_expand.h: Rename include guard.
7118         * common/gdb_sys_time.h: Rename include guard.
7119         * common/gdb_string_view.h: Rename include guard.
7120         * common/gdb_splay_tree.h: Rename include guard.
7121         * common/gdb_setjmp.h: Rename include guard.
7122         * common/gdb_ref_ptr.h: Rename include guard.
7123         * common/gdb_optional.h: Rename include guard.
7124         * common/gdb_locale.h: Rename include guard.
7125         * common/gdb_assert.h: Rename include guard.
7126         * common/filtered-iterator.h: Rename include guard.
7127         * common/filestuff.h: Rename include guard.
7128         * common/fileio.h: Rename include guard.
7129         * common/environ.h: Rename include guard.
7130         * common/common-utils.h: Rename include guard.
7131         * common/common-types.h: Rename include guard.
7132         * common/common-regcache.h: Rename include guard.
7133         * common/common-inferior.h: Rename include guard.
7134         * common/common-gdbthread.h: Rename include guard.
7135         * common/common-exceptions.h: Rename include guard.
7136         * common/common-defs.h: Rename include guard.
7137         * common/common-debug.h: Rename include guard.
7138         * common/cleanups.h: Rename include guard.
7139         * common/buffer.h: Rename include guard.
7140         * common/btrace-common.h: Rename include guard.
7141         * common/break-common.h: Rename include guard.
7142         * cli/cli-utils.h: Rename include guard.
7143         * cli/cli-style.h: Rename include guard.
7144         * cli/cli-setshow.h: Rename include guard.
7145         * cli/cli-script.h: Rename include guard.
7146         * cli/cli-interp.h: Rename include guard.
7147         * cli/cli-decode.h: Rename include guard.
7148         * cli/cli-cmds.h: Rename include guard.
7149         * charset-list.h: Add include guard.
7150         * buildsym-legacy.h: Rename include guard.
7151         * bfin-tdep.h: Add include guard.
7152         * ax.h: Rename include guard.
7153         * arm-linux-tdep.h: Add include guard.
7154         * arm-fbsd-tdep.h: Add include guard.
7155         * arch/xtensa.h: Rename include guard.
7156         * arch/tic6x.h: Add include guard.
7157         * arch/i386.h: Add include guard.
7158         * arch/arm.h: Rename include guard.
7159         * arch/arm-linux.h: Rename include guard.
7160         * arch/arm-get-next-pcs.h: Rename include guard.
7161         * arch/amd64.h: Add include guard.
7162         * arch/aarch64-insn.h: Rename include guard.
7163         * arch-utils.h: Rename include guard.
7164         * annotate.h: Add include guard.
7165         * amd64-darwin-tdep.h: Rename include guard.
7166         * aarch64-linux-tdep.h: Add include guard.
7167         * aarch64-fbsd-tdep.h: Add include guard.
7168         * aarch32-linux-nat.h: Add include guard.
7169
7170 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7171
7172         * macrotab.c (macro_define_internal): New function that
7173         factorizes macro_define_object_internal and macro_define_function
7174         code.
7175         (macro_define_object_internal): Use macro_define_internal.
7176         (macro_define_function): Likewise.
7177
7178 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7179
7180         * macrocmd.c (extract_identifier): Return
7181         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7182         callers.
7183
7184 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7185
7186         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7187
7188 2019-02-05  Tom Tromey  <tom@tromey.com>
7189
7190         * target.c (target_stack::unpush): Move assertion earlier.
7191
7192 2019-01-30  Tom Tromey  <tom@tromey.com>
7193
7194         PR python/23615:
7195         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7196         (gdbpy_parse_and_eval): Likewise.
7197         * python/python-internal.h (gdbpy_allow_threads): New class.
7198
7199 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7200
7201         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7202         (aarch64_fbsd_fpregmap): Move earlier.
7203         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7204         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7205         instead of individual calls to trad_frame_set_reg_addr.
7206         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7207         earlier.
7208         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7209         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7210         instead of individual calls to trad_frame_set_reg_addr.
7211
7212 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7213
7214         * CONTRIBUTE: Replace contribution list with wiki link.
7215
7216 2019-01-25  Tom Tromey  <tom@tromey.com>
7217
7218         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7219
7220 2019-01-25  Tom Tromey  <tom@tromey.com>
7221
7222         * xtensa-linux-nat.c: Fix common/ includes.
7223         * xml-support.h: Fix common/ includes.
7224         * xml-support.c: Fix common/ includes.
7225         * x86-linux-nat.c: Fix common/ includes.
7226         * windows-nat.c: Fix common/ includes.
7227         * varobj.h: Fix common/ includes.
7228         * varobj.c: Fix common/ includes.
7229         * value.c: Fix common/ includes.
7230         * valops.c: Fix common/ includes.
7231         * utils.c: Fix common/ includes.
7232         * unittests/xml-utils-selftests.c: Fix common/ includes.
7233         * unittests/utils-selftests.c: Fix common/ includes.
7234         * unittests/unpack-selftests.c: Fix common/ includes.
7235         * unittests/tracepoint-selftests.c: Fix common/ includes.
7236         * unittests/style-selftests.c: Fix common/ includes.
7237         * unittests/string_view-selftests.c: Fix common/ includes.
7238         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7239         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7240         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7241         * unittests/rsp-low-selftests.c: Fix common/ includes.
7242         * unittests/parse-connection-spec-selftests.c: Fix common/
7243         includes.
7244         * unittests/optional-selftests.c: Fix common/ includes.
7245         * unittests/offset-type-selftests.c: Fix common/ includes.
7246         * unittests/observable-selftests.c: Fix common/ includes.
7247         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7248         * unittests/memrange-selftests.c: Fix common/ includes.
7249         * unittests/memory-map-selftests.c: Fix common/ includes.
7250         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7251         * unittests/function-view-selftests.c: Fix common/ includes.
7252         * unittests/environ-selftests.c: Fix common/ includes.
7253         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7254         * unittests/common-utils-selftests.c: Fix common/ includes.
7255         * unittests/cli-utils-selftests.c: Fix common/ includes.
7256         * unittests/array-view-selftests.c: Fix common/ includes.
7257         * ui-file.c: Fix common/ includes.
7258         * tui/tui-io.c: Fix common/ includes.
7259         * tracepoint.h: Fix common/ includes.
7260         * tracepoint.c: Fix common/ includes.
7261         * tracefile-tfile.c: Fix common/ includes.
7262         * top.h: Fix common/ includes.
7263         * top.c: Fix common/ includes.
7264         * thread.c: Fix common/ includes.
7265         * target/waitstatus.h: Fix common/ includes.
7266         * target/waitstatus.c: Fix common/ includes.
7267         * target.h: Fix common/ includes.
7268         * target.c: Fix common/ includes.
7269         * target-memory.c: Fix common/ includes.
7270         * target-descriptions.c: Fix common/ includes.
7271         * symtab.h: Fix common/ includes.
7272         * symfile.c: Fix common/ includes.
7273         * stap-probe.c: Fix common/ includes.
7274         * spu-linux-nat.c: Fix common/ includes.
7275         * sparc-nat.c: Fix common/ includes.
7276         * source.c: Fix common/ includes.
7277         * solib.c: Fix common/ includes.
7278         * solib-target.c: Fix common/ includes.
7279         * ser-unix.c: Fix common/ includes.
7280         * ser-tcp.c: Fix common/ includes.
7281         * ser-pipe.c: Fix common/ includes.
7282         * ser-base.c: Fix common/ includes.
7283         * selftest-arch.c: Fix common/ includes.
7284         * s12z-tdep.c: Fix common/ includes.
7285         * rust-exp.y: Fix common/ includes.
7286         * rs6000-aix-tdep.c: Fix common/ includes.
7287         * riscv-tdep.c: Fix common/ includes.
7288         * remote.c: Fix common/ includes.
7289         * remote-notif.h: Fix common/ includes.
7290         * remote-fileio.h: Fix common/ includes.
7291         * remote-fileio.c: Fix common/ includes.
7292         * regcache.h: Fix common/ includes.
7293         * regcache.c: Fix common/ includes.
7294         * record-btrace.c: Fix common/ includes.
7295         * python/python.c: Fix common/ includes.
7296         * python/py-type.c: Fix common/ includes.
7297         * python/py-inferior.c: Fix common/ includes.
7298         * progspace.h: Fix common/ includes.
7299         * producer.c: Fix common/ includes.
7300         * procfs.c: Fix common/ includes.
7301         * proc-api.c: Fix common/ includes.
7302         * printcmd.c: Fix common/ includes.
7303         * ppc-linux-nat.c: Fix common/ includes.
7304         * parser-defs.h: Fix common/ includes.
7305         * osdata.c: Fix common/ includes.
7306         * obsd-nat.c: Fix common/ includes.
7307         * nat/x86-linux.c: Fix common/ includes.
7308         * nat/x86-linux-dregs.c: Fix common/ includes.
7309         * nat/x86-dregs.h: Fix common/ includes.
7310         * nat/x86-dregs.c: Fix common/ includes.
7311         * nat/ppc-linux.c: Fix common/ includes.
7312         * nat/mips-linux-watch.h: Fix common/ includes.
7313         * nat/mips-linux-watch.c: Fix common/ includes.
7314         * nat/linux-waitpid.c: Fix common/ includes.
7315         * nat/linux-ptrace.h: Fix common/ includes.
7316         * nat/linux-ptrace.c: Fix common/ includes.
7317         * nat/linux-procfs.c: Fix common/ includes.
7318         * nat/linux-personality.c: Fix common/ includes.
7319         * nat/linux-osdata.c: Fix common/ includes.
7320         * nat/linux-namespaces.c: Fix common/ includes.
7321         * nat/linux-btrace.h: Fix common/ includes.
7322         * nat/linux-btrace.c: Fix common/ includes.
7323         * nat/fork-inferior.c: Fix common/ includes.
7324         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7325         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7326         * nat/aarch64-linux.c: Fix common/ includes.
7327         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7328         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7329         * namespace.h: Fix common/ includes.
7330         * mips-linux-tdep.c: Fix common/ includes.
7331         * minsyms.c: Fix common/ includes.
7332         * mi/mi-parse.h: Fix common/ includes.
7333         * mi/mi-main.c: Fix common/ includes.
7334         * mi/mi-cmd-env.c: Fix common/ includes.
7335         * memrange.h: Fix common/ includes.
7336         * memattr.c: Fix common/ includes.
7337         * maint.h: Fix common/ includes.
7338         * maint.c: Fix common/ includes.
7339         * main.c: Fix common/ includes.
7340         * machoread.c: Fix common/ includes.
7341         * location.c: Fix common/ includes.
7342         * linux-thread-db.c: Fix common/ includes.
7343         * linux-nat.c: Fix common/ includes.
7344         * linux-fork.c: Fix common/ includes.
7345         * inline-frame.c: Fix common/ includes.
7346         * infrun.c: Fix common/ includes.
7347         * inflow.c: Fix common/ includes.
7348         * inferior.h: Fix common/ includes.
7349         * inferior.c: Fix common/ includes.
7350         * infcmd.c: Fix common/ includes.
7351         * inf-ptrace.c: Fix common/ includes.
7352         * inf-child.c: Fix common/ includes.
7353         * ia64-linux-nat.c: Fix common/ includes.
7354         * i387-tdep.c: Fix common/ includes.
7355         * i386-tdep.c: Fix common/ includes.
7356         * i386-linux-tdep.c: Fix common/ includes.
7357         * i386-linux-nat.c: Fix common/ includes.
7358         * i386-go32-tdep.c: Fix common/ includes.
7359         * i386-fbsd-tdep.c: Fix common/ includes.
7360         * i386-fbsd-nat.c: Fix common/ includes.
7361         * guile/scm-type.c: Fix common/ includes.
7362         * guile/guile.c: Fix common/ includes.
7363         * go32-nat.c: Fix common/ includes.
7364         * gnu-nat.c: Fix common/ includes.
7365         * gdbthread.h: Fix common/ includes.
7366         * gdbarch-selftests.c: Fix common/ includes.
7367         * gdb_usleep.c: Fix common/ includes.
7368         * gdb_select.h: Fix common/ includes.
7369         * gdb_bfd.c: Fix common/ includes.
7370         * gcore.c: Fix common/ includes.
7371         * fork-child.c: Fix common/ includes.
7372         * findvar.c: Fix common/ includes.
7373         * fbsd-nat.c: Fix common/ includes.
7374         * event-top.c: Fix common/ includes.
7375         * event-loop.c: Fix common/ includes.
7376         * dwarf2read.c: Fix common/ includes.
7377         * dwarf2loc.c: Fix common/ includes.
7378         * dwarf2-frame.c: Fix common/ includes.
7379         * dwarf-index-cache.c: Fix common/ includes.
7380         * dtrace-probe.c: Fix common/ includes.
7381         * disasm-selftests.c: Fix common/ includes.
7382         * defs.h: Fix common/ includes.
7383         * csky-tdep.c: Fix common/ includes.
7384         * cp-valprint.c: Fix common/ includes.
7385         * cp-support.h: Fix common/ includes.
7386         * cp-support.c: Fix common/ includes.
7387         * corelow.c: Fix common/ includes.
7388         * completer.h: Fix common/ includes.
7389         * completer.c: Fix common/ includes.
7390         * compile/compile.c: Fix common/ includes.
7391         * compile/compile-loc2c.c: Fix common/ includes.
7392         * compile/compile-cplus-types.c: Fix common/ includes.
7393         * compile/compile-cplus-symbols.c: Fix common/ includes.
7394         * command.h: Fix common/ includes.
7395         * cli/cli-dump.c: Fix common/ includes.
7396         * cli/cli-cmds.c: Fix common/ includes.
7397         * charset.c: Fix common/ includes.
7398         * build-id.c: Fix common/ includes.
7399         * btrace.h: Fix common/ includes.
7400         * btrace.c: Fix common/ includes.
7401         * breakpoint.h: Fix common/ includes.
7402         * breakpoint.c: Fix common/ includes.
7403         * ax.h:
7404         (enum agent_op): Fix common/ includes.
7405         * ax-general.c (struct aop_map): Fix common/ includes.
7406         * ax-gdb.c: Fix common/ includes.
7407         * auxv.c: Fix common/ includes.
7408         * auto-load.c: Fix common/ includes.
7409         * arm-tdep.c: Fix common/ includes.
7410         * arch/riscv.c: Fix common/ includes.
7411         * arch/ppc-linux-common.c: Fix common/ includes.
7412         * arch/i386.c: Fix common/ includes.
7413         * arch/arm.c: Fix common/ includes.
7414         * arch/arm-linux.c: Fix common/ includes.
7415         * arch/arm-get-next-pcs.c: Fix common/ includes.
7416         * arch/amd64.c: Fix common/ includes.
7417         * arch/aarch64.c: Fix common/ includes.
7418         * arch/aarch64-insn.c: Fix common/ includes.
7419         * arch-utils.c: Fix common/ includes.
7420         * amd64-windows-tdep.c: Fix common/ includes.
7421         * amd64-tdep.c: Fix common/ includes.
7422         * amd64-sol2-tdep.c: Fix common/ includes.
7423         * amd64-obsd-tdep.c: Fix common/ includes.
7424         * amd64-nbsd-tdep.c: Fix common/ includes.
7425         * amd64-linux-tdep.c: Fix common/ includes.
7426         * amd64-linux-nat.c: Fix common/ includes.
7427         * amd64-fbsd-tdep.c: Fix common/ includes.
7428         * amd64-fbsd-nat.c: Fix common/ includes.
7429         * amd64-dicos-tdep.c: Fix common/ includes.
7430         * amd64-darwin-tdep.c: Fix common/ includes.
7431         * agent.c: Fix common/ includes.
7432         * ada-lang.h: Fix common/ includes.
7433         * ada-lang.c: Fix common/ includes.
7434         * aarch64-tdep.c: Fix common/ includes.
7435
7436 2019-01-25  Tom Tromey  <tom@tromey.com>
7437
7438         * common/create-version.sh: Use common/version.h.
7439
7440 2019-01-24  Pedro Alves  <palves@redhat.com>
7441
7442         * infrun.c (signal_stop, signal_print, signal_program)
7443         (signal_catch, signal_pass): Now arrays instead of pointers.
7444         (update_signals_program_target, do_target_resume)
7445         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7446         * linux-nat.c (linux_nat_target::pass_signals)
7447         (linux_nat_target::create_inferior, linux_nat_target::attach):
7448         Adjust.
7449         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7450         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7451         * procfs.c (procfs_target::pass_signals): Adjust.
7452         * record-full.c (record_full_target::resume): Adjust.
7453         * remote.c (remote_target::pass_signals)
7454         (remote_target::program_signals): Adjust.
7455         * target-debug.h (target_debug_print_signals): Now takes a
7456         gdb::array_view as parameter.  Adjust.
7457         * target.h (target_ops) <pass_signals, program_signals>: Replace
7458         pointer and length parameters with gdb::array_view.
7459         (target_pass_signals, target_program_signals): Likewise.
7460         * target-delegates.c: Regenerate.
7461
7462 2019-01-24  Pedro Alves  <palves@redhat.com>
7463
7464         * common/forward-scope-exit.h
7465         (forward_scope_exit::forward_scope_exit): Pass arguments to
7466         m_bind_function directly, instead of creating a std::bind and
7467         copying that.
7468
7469 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7470
7471         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7472         for static members.
7473         (pass_in_v_vfp_candidate): Likewise.
7474
7475 2019-01-23  Tom Tromey  <tom@tromey.com>
7476             Pedro Alves  <palves@redhat.com>
7477
7478         * regcache.c (class regcache_invalidator): Remove.
7479         (regcache::raw_write): Use make_scope_exit.
7480
7481 2019-01-23  Tom Tromey  <tom@tromey.com>
7482
7483         * ui-out.h (class ui_out_emit_type): Update comment.
7484
7485 2019-01-23  Tom Tromey  <tom@tromey.com>
7486
7487         * infrun.c (fetch_inferior_event): Update comment.
7488
7489 2019-01-23  Tom Tromey  <tom@tromey.com>
7490             Pedro Alves  <palves@redhat.com>
7491
7492         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7493         parameter.
7494         (fetch_inferior_event): Use SCOPE_EXIT.
7495
7496
7497 2019-01-23  Tom Tromey  <tom@tromey.com>
7498             Pedro Alves  <palves@redhat.com>
7499
7500         * infrun.c (disable_thread_events): Delete.
7501         (stop_all_threads): Use SCOPE_EXIT.
7502
7503 2019-01-23  Tom Tromey  <tom@tromey.com>
7504             Pedro Alves  <palves@redhat.com>
7505
7506         * symfile.c: Include forward-scope-exit.h.
7507         (clear_symtab_users_cleanup): Replace forward declaration with
7508         a FORWARD_SCOPE_EXIT.
7509         (syms_from_objfile_1): Use the forward_scope_exit and
7510         gdb::optional instead of cleanup_function.
7511         (reread_symbols): Use the forward_scope_exit instead of
7512         cleanup_function.
7513         (clear_symtab_users_cleanup): Remove function.
7514
7515 2019-01-23  Tom Tromey  <tom@tromey.com>
7516             Pedro Alves  <palves@redhat.com>
7517
7518         * linux-nat.c: Include scope-exit.h.
7519         (cleanup_target_stop): Remove.
7520         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7521         SCOPE_EXIT.
7522
7523 2019-01-23  Tom Tromey  <tom@tromey.com>
7524             Pedro Alves  <palves@redhat.com>
7525
7526         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7527         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7528
7529 2019-01-23  Tom Tromey  <tom@tromey.com>
7530             Andrew Burgess  <andrew.burgess@embecosm.com>
7531             Pedro Alves  <palves@redhat.com>
7532
7533         * infrun.c (fetch_inferior_event): Use scope_exit.
7534         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7535         * top.c (execute_command): Use scope_exit.
7536         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7537         * utils.c (do_bpstat_clear_actions_cleanup)
7538         (make_bpstat_clear_actions_cleanup): Remove.
7539
7540 2019-01-23  Tom Tromey  <tom@tromey.com>
7541             Pedro Alves  <palves@redhat.com>
7542
7543         * infrun.c: Include "common/scope-exit.h"
7544         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7545         (wait_for_inferior): Use SCOPE_EXIT.
7546         (fetch_inferior_event): Use scope_exit.
7547
7548 2019-01-23  Tom Tromey  <tom@tromey.com>
7549             Pedro Alves  <palves@redhat.com>
7550
7551         * breakpoint.c (create_breakpoint): Remove cleanup.
7552
7553 2019-01-23  Tom Tromey  <tom@tromey.com>
7554             Andrew Burgess  <andrew.burgess@embecosm.com>
7555             Pedro Alves  <palves@redhat.com>
7556
7557 2019-01-23  Pedro Alves  <palves@redhat.com>
7558
7559         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7560
7561 2019-01-23  Pedro Alves  <palves@redhat.com>
7562             Andrew Burgess  <andrew.burgess@embecosm.com>
7563
7564         * gdbthread.h: Include "common/forward-scope-exit.h".
7565         (scoped_finish_thread_state): Redefine custom class in terms of
7566         forward_scope_exit.
7567
7568 2019-01-23  Pedro Alves  <palves@redhat.com>
7569             Andrew Burgess  <andrew.burgess@embecosm.com>
7570
7571         * common/forward-scope-exit.h: New file.
7572
7573 2019-01-23  Pedro Alves  <palves@redhat.com>
7574             Andrew Burgess  <andrew.burgess@embecosm.com>
7575             Tom Tromey  <tom@tromey.com>
7576
7577         * common/scope-exit.h: New file.
7578
7579 2019-01-23  Pedro Alves  <palves@redhat.com>
7580
7581         * common/preprocessor.h (ESC): Rename to ...
7582         (ESC_PARENS): ... this.
7583         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7584         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7585
7586 2019-01-23  Tom Tromey  <tom@tromey.com>
7587
7588         * language.h (class scoped_switch_to_sym_language_if_auto):
7589         Initialize m_lang in both cases.
7590
7591 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7592
7593         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7594         with XCNEW.
7595
7596 2019-01-22  Tom Tromey  <tom@tromey.com>
7597
7598         * corelow.c: Do not include sys/file.h.
7599
7600 2019-01-22  Tom Tromey  <tom@tromey.com>
7601
7602         * tui/tui-wingeneral.h: Include gdb_curses.h.
7603
7604 2019-01-22  Tom Tromey  <tom@tromey.com>
7605
7606         * source-cache.h (class source_cache) <get_source_lines,
7607         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7608
7609 2019-01-22  Tom Tromey  <tom@tromey.com>
7610
7611         * remote-fileio.h (struct remote_target): Declare.
7612
7613 2019-01-22  Tom Tromey  <tom@tromey.com>
7614
7615         * python/py-arch.c: Do not include py-ref.h.
7616         * python/py-bpevent.c: Do not include py-ref.h.
7617         * python/py-cmd.c: Do not include py-ref.h.
7618         * python/py-continueevent.c: Do not include py-ref.h.
7619         * python/py-event.h: Do not include py-ref.h.
7620         * python/py-evtregistry.c: Do not include py-ref.h.
7621         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7622         * python/py-frame.c: Do not include py-ref.h.
7623         * python/py-framefilter.c: Do not include py-ref.h.
7624         * python/py-function.c: Do not include py-ref.h.
7625         * python/py-infevents.c: Do not include py-ref.h.
7626         * python/py-linetable.c: Do not include py-ref.h.
7627         * python/py-objfile.c: Do not include py-ref.h.
7628         * python/py-param.c: Do not include py-ref.h.
7629         * python/py-prettyprint.c: Do not include py-ref.h.
7630         * python/py-progspace.c: Do not include py-ref.h.
7631         * python/py-symbol.c: Do not include py-ref.h.
7632         * python/py-symtab.c: Do not include py-ref.h.
7633         * python/py-type.c: Do not include py-ref.h.
7634         * python/py-unwind.c: Do not include py-ref.h.
7635         * python/py-utils.c: Do not include py-ref.h.
7636         * python/py-value.c: Do not include py-ref.h.
7637         * python/py-varobj.c: Do not include py-ref.h.
7638         * python/py-xmethods.c: Do not include py-ref.h.
7639         * python/python.c: Do not include py-ref.h.
7640         * varobj.c: Do not include py-ref.h.
7641
7642 2019-01-22  Tom Tromey  <tom@tromey.com>
7643
7644         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7645         keyword for bcache.
7646
7647 2019-01-22  Tom Tromey  <tom@tromey.com>
7648
7649         * compile/compile-cplus-types.c: Remove a comment by #include.
7650
7651 2019-01-22  Tom Tromey  <tom@tromey.com>
7652
7653         * compile/gcc-c-plugin.h: Include compile-internal.h.
7654
7655 2019-01-22  Tom Tromey  <tom@tromey.com>
7656
7657         * stabsread.c (EXTERN): Do not define.
7658         (symnum, next_symbol_text_func, processing_gcc_compilation)
7659         (within_function, global_sym_chain, global_stabs)
7660         (previous_stab_code, this_object_header_files)
7661         (n_this_object_header_files)
7662         (n_allocated_this_object_header_files): Define.
7663         * stabsread.h (EXTERN): Never define.  Use "extern".
7664
7665 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7666
7667         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7668         history_value.
7669
7670 2019-01-21  Tom Tromey  <tom@tromey.com>
7671
7672         * ui-out.c: Fix includes.
7673         * tui/tui-source.c: Fix includes.
7674         * target.c: Fix includes.
7675         * remote.c: Fix includes.
7676         * regcache.c: Fix includes.
7677         * python/py-block.c: Fix includes.
7678         * printcmd.c: Fix includes.
7679         * or1k-tdep.c: Fix includes.
7680         * mi/mi-main.c: Fix includes.
7681         * m32r-tdep.c: Fix includes.
7682         * csky-tdep.c: Fix includes.
7683         * compile/compile-cplus-types.c: Fix includes.
7684         * cli/cli-interp.c: Fix includes.
7685
7686 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7687
7688         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7689         for padding.
7690
7691 2019-01-16  Tom Tromey  <tom@tromey.com>
7692
7693         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7694         earlier.
7695         (struct objfile) <msymbols_range>: Move from top level.
7696         <msymbols>: New method.
7697         (class objfile_msymbols): Remove.
7698         * symtab.c (default_collect_symbol_completion_matches_break_on):
7699         Update.
7700         * symmisc.c (dump_msymbols): Update.
7701         * stabsread.c (scan_file_globals): Update.
7702         * objc-lang.c (info_selectors_command, info_classes_command)
7703         (find_methods): Update.
7704         * minsyms.c (find_solib_trampoline_target): Update.
7705         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7706         * coffread.c (coff_symfile_read): Update.
7707         * ada-lang.c (ada_lookup_simple_minsym)
7708         (ada_collect_symbol_completion_matches): Update.
7709
7710 2019-01-16  Tom Tromey  <tom@tromey.com>
7711
7712         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7713         type.  Remove no-argument constructor.
7714         <iterator::operator++>: Simplify.
7715         <begin>: Update.
7716         <end>: Use minimal_symbol_count.
7717
7718 2019-01-16  Tom Tromey  <tom@tromey.com>
7719
7720         * objfiles.h (struct objfile) <psymtabs>: New method.
7721         (class objfile_psymtabs): Remove.
7722         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7723         typedef.
7724         <range>: New method.
7725         (require_partial_symbols): Change return type.
7726         * psymtab.c (require_partial_symbols)
7727         (psym_expand_symtabs_matching): Update.
7728         * mdebugread.c (parse_partial_symbols): Update.
7729         * dbxread.c (dbx_end_psymtab): Update.
7730
7731 2019-01-15  Tom Tromey  <tom@tromey.com>
7732
7733         * symtab.c (lookup_objfile_from_block)
7734         (lookup_symbol_in_objfile_symtabs)
7735         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7736         (find_line_symtab, info_sources_command)
7737         (default_collect_symbol_completion_matches_break_on)
7738         (make_source_files_completion_list): Update.
7739         * symmisc.c (print_objfile_statistics, dump_objfile)
7740         (maintenance_print_symbols, maintenance_info_symtabs)
7741         (maintenance_check_symtabs, maintenance_info_line_tables):
7742         Update.
7743         * source.c (select_source_symtab)
7744         (forget_cached_source_info_for_objfile): Update.
7745         * objfiles.h (class objfile_compunits): Remove.
7746         (struct objfile) <compunits_range>: New typedef.
7747         (compunits): New method.
7748         * objfiles.c (objfile_relocate1): Update.
7749         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7750         * maint.c (count_symtabs_and_blocks): Update.
7751         * linespec.c (iterate_over_all_matching_symtabs): Update.
7752         * cp-support.c (add_symbol_overload_list_qualified): Update.
7753         * coffread.c (coff_symtab_read): Update.
7754         * ada-lang.c (add_nonlocal_symbols)
7755         (ada_collect_symbol_completion_matches)
7756         (ada_add_global_exceptions): Update.
7757
7758 2019-01-15  Tom Tromey  <tom@tromey.com>
7759
7760         * progspace.h (program_space) <objfiles_safe_range>: New
7761         typedef.
7762         <objfiles_safe>: New method.
7763         * objfiles.h (class all_objfiles_safe): Remove.
7764         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7765         * jit.c (jit_inferior_exit_hook): Update.
7766
7767 2019-01-17  Tom Tromey  <tom@tromey.com>
7768
7769         * progspace.h (program_space) <objfiles_range>: New typedef.
7770         <objfiles>: New method.
7771         <objfiles_head>: Rename from objfiles.
7772         (object_files): Update.
7773         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7774         * guile/scm-pretty-print.c
7775         (ppscm_find_pretty_printer_from_objfiles): Update.
7776         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7777         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7778         Update.
7779         * python/py-progspace.c (pspy_get_objfiles): Update.
7780         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7781         Update.
7782         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7783         (objfpy_lookup_objfile_by_build_id): Update.
7784         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7785         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7786         Update.
7787         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7788         (expand_symtab_containing_pc, lookup_objfile_from_block)
7789         (lookup_static_symbol, basic_lookup_transparent_type)
7790         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7791         (find_line_symtab, info_sources_command)
7792         (default_collect_symbol_completion_matches_break_on)
7793         (make_source_files_completion_list, find_main_name): Update.
7794         * symmisc.c (print_symbol_bcache_statistics)
7795         (print_objfile_statistics, maintenance_print_symbols)
7796         (maintenance_print_msymbols, maintenance_print_objfiles)
7797         (maintenance_info_symtabs, maintenance_check_symtabs)
7798         (maintenance_expand_symtabs, maintenance_info_line_tables):
7799         Update.
7800         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7801         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7802         (map_overlay_command, unmap_overlay_command)
7803         (simple_overlay_update, expand_symtabs_matching)
7804         (map_symbol_filenames): Update.
7805         * symfile-debug.c (set_debug_symfile): Update.
7806         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7807         Update.
7808         * source.c (select_source_symtab, forget_cached_source_info):
7809         Update.
7810         * solib.c (solib_read_symbols): Update.
7811         * solib-spu.c (append_ocl_sos): Update.
7812         * psymtab.c (maintenance_print_psymbols)
7813         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7814         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7815         * printcmd.c (info_symbol_command): Update.
7816         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7817         Update.
7818         * objfiles.h (class all_objfiles): Remove.
7819         * objfiles.c (have_partial_symbols, have_full_symbols)
7820         (have_minimal_symbols, qsort_cmp, update_section_map)
7821         (shared_objfile_contains_address_p)
7822         (default_iterate_over_objfiles_in_search_order): Update.
7823         * objc-lang.c (info_selectors_command, info_classes_command)
7824         (find_methods): Update.
7825         * minsyms.c (find_solib_trampoline_target): Update.
7826         * maint.c (maintenance_info_sections)
7827         (maintenance_translate_address, count_symtabs_and_blocks):
7828         Update.
7829         * main.c (captured_main_1): Update.
7830         * linux-thread-db.c (try_thread_db_load_from_pdir)
7831         (has_libpthread): Update.
7832         * linespec.c (iterate_over_all_matching_symtabs)
7833         (search_minsyms_for_name): Update.
7834         * jit.c (jit_find_objf_with_entry_addr): Update.
7835         * hppa-tdep.c (find_unwind_entry)
7836         (hppa_lookup_stub_minimal_symbol): Update.
7837         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7838         Update.
7839         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7840         (elf_gnu_ifunc_resolve_by_got): Update.
7841         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7842         * dwarf-index-write.c (save_gdb_index_command): Update.
7843         * cp-support.c (add_symbol_overload_list_qualified): Update.
7844         * breakpoint.c (create_overlay_event_breakpoint)
7845         (create_longjmp_master_breakpoint)
7846         (create_std_terminate_master_breakpoint)
7847         (create_exception_master_breakpoint): Update.
7848         * blockframe.c (find_pc_partial_function): Update.
7849         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7850         (ada_collect_symbol_completion_matches)
7851         (ada_add_global_exceptions): Update.
7852
7853 2019-01-17  Tom Tromey  <tom@tromey.com>
7854
7855         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7856         declare VEC.
7857         (solib_target_parse_libraries): Change return type.
7858         (library_list_start_segment, library_list_start_section)
7859         (library_list_end_library, library_list_start_library); Update.
7860         (solib_target_free_library_list): Remove.
7861         (solib_target_parse_libraries): Remove cleanup.  Change return
7862         type.
7863         (solib_target_current_sos): Update.
7864
7865 2019-01-17  Tom Tromey  <tromey@bapiya>
7866
7867         * valprint.c: Replace "the the" with "the".
7868         * symtab.c: Replace "the the" with "the".
7869         * solib.c: Replace "the the" with "the".
7870         * solib-dsbt.c: Replace "the the" with "the".
7871         * linespec.c: Replace "the the" with "the".
7872         * dwarf2loc.h: Replace "the the" with "the".
7873         * amd64-windows-tdep.c: Replace "the the" with "the".
7874         * aarch64-tdep.c: Replace "the the" with "the".
7875
7876 2019-01-16  Keith Seitz  <keiths@redhat.com>
7877
7878         PR gdb/23773
7879         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7880         <builder>: Rename to ..
7881         <m_builder>: ... this and make private.
7882         (dwarf2_cu::get_builder): New method.  Change all users of
7883         `builder' to use this method.
7884         (dwarf2_start_symtab): Move to ...
7885         (dwarf2_cu::start_symtab): ... here.  Update all callers
7886         (setup_type_unit_groups): Move to ...
7887         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7888         callers.
7889         (dwarf2_cu::reset_builder): New method.
7890         (process_full_compunit, process_full_type_unit): Use
7891         dwarf2_cu::reset_builder.
7892         (follow_die_offset): Record the ancestor CU if it is different
7893         from the followed DIE's CU.
7894         (follow_die_sig_1): Likewise.
7895
7896 2019-01-15  Tom Tromey  <tom@tromey.com>
7897
7898         * remote.c (class remote_state) <buf>: Now a char_vector.
7899         <buf_size>: Remove.
7900         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7901         parameter.
7902         (remote_target::getpkt_or_notif_sane_1)
7903         (remote_target::getpkt_sane)
7904         (remote_target::getpkt_or_notif_sane): Likewise.
7905         (class remote_target) <putpkt>: New overload.
7906         (remote_target::read_frame): Change type of "buf_p".  Remove
7907         sizeof_p parameter.
7908         (packet_ok): New overload.
7909         (packet_check_result): New overload.
7910         Update all uses.
7911
7912 2019-01-14  Tom Tromey  <tom@tromey.com>
7913
7914         * remote-notif.c (handle_notification, remote_notif_ack)
7915         (remote_notif_parse): Make "buf" const.
7916         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7917         const.
7918         (remote_notif_parse, remote_notif_ack, handle_notification):
7919         Likewise.
7920         * remote.c (remote_notif_stop_parse): Make "buf" const.
7921         (remote_target::remote_parse_stop_reply): Make "buf" const.
7922         (remote_notif_stop_ack): Make "buf" const.
7923
7924 2019-01-14  Tom Tromey  <tom@tromey.com>
7925
7926         * remote.c (remote_console_output): Make parameter const.
7927
7928 2019-01-14  Tom Tromey  <tom@tromey.com>
7929
7930         * target-debug.h (target_debug_print_signals): Constify.
7931         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7932         * procfs.c (procfs_target::pass_signals): Update.
7933         * linux-nat.c (linux_nat_target::pass_signals): Update.
7934         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7935         * target-delegates.c: Rebuild.
7936         * remote.c (remote_target::program_signals): Update.
7937         (remote_target::pass_signals): Update.
7938         * target.c (target_pass_signals): Constify argument.
7939         (target_program_signals): Likewise.
7940         * target.h (struct target_ops) <pass_signals, program_signals>:
7941         Constify argument.
7942         (target_pass_signals, target_program_signals): Constify argument.
7943
7944 2019-01-14  Tom Tromey  <tom@tromey.com>
7945
7946         PR tui/28819:
7947         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7948
7949 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7950
7951         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7952         field.
7953         * rs6000-tdep.c: Include reggroups.h.
7954         (IS_V_ALIAS_PSEUDOREG): Define.
7955         (rs6000_register_name): Return names for the "vX" aliases.
7956         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7957         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7958         aliases.  Call default_register_reggroup_p for all other
7959         pseudo-registers.
7960         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7961         New functions.
7962         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7963         Handle "vX" aliases.
7964         (v_alias_pseudo_register_collect): New function.
7965         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7966         (rs6000_gdbarch_init): Initialize "vX" aliases as
7967         pseudo-registers.  Restore registration of
7968         rs6000_pseudo_register_reggroup_p with
7969         set_tdesc_pseudo_register_reggroup_p.
7970
7971 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7972
7973         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7974         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7975         set_gdbarch_num_pseudo_regs.
7976
7977 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7978
7979         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7980         Remove arg prefixname, add do_set and do_show.
7981         Add member functions set_list and show_list.
7982         * cli/cli-style.c (class cli_style_option): Update accordingly.
7983         (style_set_list): Move to file scope.
7984         (style_show_list): Likewise.
7985         (set_style): Call help_list.
7986         (show_style): Call cmd_show_list.
7987         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7988         Update to use the new macro.
7989
7990 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7991
7992         * ada-lang.c (_initialize_ada_language): Expand the help text
7993         for the "catch exception" command.
7994
7995 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7996
7997         * symtab.c (matching_obj_sections): Initialize obj,
7998         declare it closer to its usage.
7999
8000 2019-01-10  Tom Tromey  <tom@tromey.com>
8001
8002         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8003         (basic_inf_threads_range): Remove.
8004         (inf_threads_range, inf_non_exited_threads_range)
8005         (safe_inf_threads_range): Use next_adapter.
8006
8007 2019-01-10  Keith Seitz  <keiths@redhat.com>
8008
8009         PR gdb/23712
8010         PR symtab/23010
8011         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8012         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8013
8014 2019-01-10  Keith Seitz  <keiths@redhat.com>
8015
8016         PR gdb/23712
8017         PR symtab/23010
8018         * dictionary.c (pending_to_vector): Remove.
8019         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8020         Remove _1 suffix, replacing functions of the same name.  Update
8021         all callers.
8022         (dict_create_hashed, dict_create_hashed_expandable)
8023         (dict_create_linear, dict_create_linear_expandable, dict_free)
8024         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8025         Make functions static.
8026
8027 2019-01-10  Keith Seitz  <keiths@redhat.com>
8028
8029         PR gdb/23712
8030         PR symtab/23010
8031         * dictionary.h (struct dictionary): Replace declaration with
8032         multidictionary.
8033         (dict_create_hashed, dict_create_hashed_expandable)
8034         (dict_create_linear, dict_create_linear_expandable)
8035         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8036         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8037         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8038         taking multidictionary argument.
8039         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8040         * block.h (struct block) <dict>: Change to multidictionary
8041         and rename `multidict'.
8042         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8043         symmisc.c: Update all dictionary references to multidictionary.
8044
8045 2019-01-10  Keith Seitz  <keiths@redhat.com>
8046
8047         PR gdb/23712
8048         PR symtab/23010
8049         * dictionary.c: Include unordered_map.
8050         (pending_to_vector): New function.
8051         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8052         Rewrite the non-"_1" functions to take vector instead
8053         of linked list.
8054         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8055         "new" _1 versions of the same name.
8056         (multidictionary): Define.
8057         (std::hash<enum language): New definition.
8058         (collate_pending_symbols_by_language, mdict_create_hashed)
8059         (mdict_create_hashed_expandable, mdict_create_linear)
8060         (mdict_create_linear_expandable, mdict_free)
8061         (find_language_dictionary, create_new_language_dictionary)
8062         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8063         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8064         (mdict_size, mdict_empty): New functions.
8065         * dictionary.h (mdict_iterator): Define.
8066
8067 2019-01-10  Pedro Alves  <palves@redhat.com>
8068
8069         * breakpoint.c (read_uploaded_action)
8070         (create_tracepoint_from_upload): Adjust to use
8071         gdb::unique_xmalloc_ptr.
8072         * ctf.c (ctf_write_uploaded_tp):
8073         (SET_ARRAY_FIELD): Use emplace_back.
8074         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8075         * tracefile-tfile.c (tfile_write_uploaded_tp):
8076         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8077         gdb::unique_xmalloc_ptr.
8078         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8079         at_string, cond_string, cmd_strings>: Replace char pointers
8080         with gdb::unique_xmalloc_ptr.
8081
8082 2019-01-10  Pedro Alves  <palves@redhat.com>
8083
8084         * solib-target.c (library_list_start_library): Don't xstrdup name.
8085
8086 2019-01-10  Pedro Alves  <palves@redhat.com>
8087
8088         * mdebugread.c (parse_partial_symbols): Use
8089         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8090
8091 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8092
8093         * linux-fork.c (scoped_switch_fork_info)
8094         <~scoped_switch_fork_info>: Fix incorrect variable name.
8095
8096 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8097
8098         * linux-fork.c (scoped_switch_fork_info)
8099         <scoped_switch_fork_info>: Make explicit.
8100         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8101
8102 2019-01-10  Tom Tromey  <tom@tromey.com>
8103
8104         * objfiles.h (objfile::reset_psymtabs): Update.
8105         * objfiles.c (objfile::objfile): Update.
8106         * psymtab.h (psymtab_storage::obstack): Update.
8107         (psymtab_storage::m_obstack): Use gdb::optional.
8108         (class psymtab_storage): Update comment.  Remove objfile
8109         parameter.
8110         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8111
8112 2019-01-10  Tom Tromey  <tom@tromey.com>
8113
8114         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8115         <free_psymtabs>: Now private.
8116         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8117         (allocate_psymtab): Use new method.
8118
8119 2019-01-10  Tom Tromey  <tom@tromey.com>
8120
8121         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8122         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8123         * mdebugread.c (parse_partial_symbols): Use
8124         allocate_dependencies.
8125         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8126         allocate_dependencies.
8127         (process_psymtab_comp_unit_reader)
8128         (build_type_psymtab_dependencies): Likewise.
8129         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8130
8131 2019-01-10  Tom Tromey  <tom@tromey.com>
8132
8133         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8134         PSYMBOL_SET_LANGUAGE.
8135         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8136
8137 2019-01-10  Tom Tromey  <tom@tromey.com>
8138
8139         * psymtab.h (psymtab_storage::obstack): New method.
8140         <m_obstack>: Rename from obstack; now private.
8141         * psymtab.c (psymtab_storage): Update.
8142         * dwarf2read.c (create_addrmap_from_index)
8143         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8144         Update.
8145
8146 2019-01-10  Tom Tromey  <tom@tromey.com>
8147
8148         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8149         * objfiles.h (objfile::reset_psymtabs): New method.
8150
8151 2019-01-10  Tom Tromey  <tom@tromey.com>
8152
8153         * symmisc.c (print_symbol_bcache_statistics): Update.
8154         (print_objfile_statistics): Update.
8155         * symfile.c (reread_symbols): Update.
8156         * psymtab.h (class psymtab_storage): New.
8157         * psymtab.c (psymtab_storage): New constructor.
8158         (~psymtab_storage): New destructor.
8159         (require_partial_symbols): Update.
8160         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8161         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8162         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8163         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8164         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8165         (start_psymtab_common, end_psymtab_common)
8166         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8167         (allocate_psymtab): Update.
8168         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8169         Update.
8170         (dump_psymtab_addrmap, maintenance_print_psymbols)
8171         (maintenance_check_psymtabs): Update.
8172         (class objfile_psymtabs): Move to objfiles.h.
8173         * psympriv.h (discard_psymtab): Now inline.
8174         (psymtab_discarder::psymtab_discarder): Update.
8175         (psymtab_discarder::~psymtab_discarder): Update.
8176         (ALL_OBJFILE_PSYMTABS): Rewrite.
8177         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8178         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8179         Remove fields.
8180         <partial_symtabs>: New field.
8181         (class objfile_psymtabs): Move from psymtab.h.  Update.
8182         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8183         psymbol_cache.
8184         (objfile::~objfile): Don't destroy psymbol_cache.
8185         * mdebugread.c (parse_partial_symbols): Update.
8186         * dwarf2read.c (create_addrmap_from_index)
8187         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8188         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8189         (add_partial_subprogram, dwarf2_ranges_read): Update.
8190         * dwarf-index-write.c (write_address_map)
8191         (write_one_signatured_type, recursively_write_psymbols)
8192         (class debug_names, class debug_names, write_psymtabs_to_index):
8193         Update.
8194
8195 2019-01-10  Tom Tromey  <tom@tromey.com>
8196
8197         * symtab.h (SYMBOL_SET_NAMES): Update.
8198         (symbol_set_names): Update.
8199         (MSYMBOL_SET_NAMES): Update.
8200         * symtab.c (symbol_set_names): Change argument to be an
8201         objfile_per_bfd_storage.
8202         * psymtab.c (add_psymbol_to_bcache): Update.
8203         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8204
8205 2019-01-10  Tom Tromey  <tom@tromey.com>
8206
8207         * symtab.c (create_demangled_names_hash): Change argument to be an
8208         objfile_per_bfd_storage.
8209         (symbol_set_names): Update.
8210
8211 2019-01-10  Tom Tromey  <tom@tromey.com>
8212
8213         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8214         init_psymbol_list.
8215         * psymtab.c (init_psymbol_list): Do nothing if already called.
8216         * psympriv.h (init_psymbol_list): Add comment.
8217         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8218         init_psymbol_list.
8219         * dbxread.c (dbx_symfile_read): Unconditionally call
8220         init_psymbol_list.
8221
8222 2019-01-10  Tom Tromey  <tom@tromey.com>
8223
8224         * xcoffread.c (scan_xcoff_symtab): Update.
8225         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8226         "where".
8227         * mdebugread.c (parse_partial_symbols)
8228         (handle_psymbol_enumerators): Update.
8229         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8230         * dbxread.c (read_dbx_symtab): Update.
8231         * psympriv.h (psymbol_placement): New enum.
8232         (add_psymbol_to_list): Update.
8233
8234 2019-01-10  Tom Tromey  <tom@tromey.com>
8235
8236         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8237         static_psymbols parameters.
8238         (scan_xcoff_symtab): Update.
8239         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8240         static_psymbols parameters.
8241         * psympriv.h (start_psymtab_common): Update.
8242         * mdebugread.c (parse_partial_symbols): Update.
8243         * dwarf2read.c (create_partial_symtab): Update.
8244         * dbxread.c (read_dbx_symtab): Update.
8245         (start_psymtab): Remove global_psymbols and static_psymbols
8246         parameters.
8247
8248 2019-01-10  Tom Tromey  <tom@tromey.com>
8249
8250         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8251         * psymtab.c (allocate_psymtab): Add comment.
8252         * psympriv.h (allocate_psymtab): Add comment.
8253         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8254         initializations.
8255         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8256
8257 2019-01-10  Tom Tromey  <tom@tromey.com>
8258
8259         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8260         Don't declare.
8261         * mipsread.c: Include mdebugread.h.
8262         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8263         Declare.
8264         * elfread.c: Include mdebugread.h.
8265
8266 2019-01-09  Tom Tromey  <tom@tromey.com>
8267
8268         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8269         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8270         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8271         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8272         (psym_lookup_symbol, psym_find_last_source_symtab)
8273         (psym_forget_cached_source_info, psym_print_stats)
8274         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8275         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8276         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8277         (psym_find_compunit_symtab_by_address)
8278         (maintenance_print_psymbols, maintenance_info_psymtabs)
8279         (maintenance_check_psymtabs): Use ranged for.
8280         * psymtab.h (class objfile_psymtabs): New.
8281         (require_partial_symbols): Return objfile_psymtabs.
8282         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8283
8284 2019-01-09  Tom Tromey  <tom@tromey.com>
8285
8286         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8287         (find_pc_mapped_section, list_overlays_command)
8288         (map_overlay_command, unmap_overlay_command)
8289         (simple_overlay_update): Use all_objfiles.
8290         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8291         * printcmd.c (info_symbol_command): Use all_objfiles.
8292         * objfiles.h (ALL_OBJSECTIONS): Remove.
8293         * maint.c (maintenance_translate_address): Use all_objfiles.
8294         * gcore.c (gcore_create_callback): Use all_objfiles.
8295         (objfile_find_memory_regions): Likewise.
8296
8297 2019-01-09  Tom Tromey  <tom@tromey.com>
8298
8299         * symtab.c (find_line_symtab, info_sources_command)
8300         (make_source_files_completion_list): Use objfile_compunits.
8301         * source.c (select_source_symtab): Use objfile_compunits.
8302         * objfiles.h (struct objfile): Update comment.
8303         (ALL_OBJFILES): Remove.
8304         (ALL_FILETABS): Remove.
8305         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8306         objfile_compunits.
8307
8308 2019-01-09  Tom Tromey  <tom@tromey.com>
8309
8310         * symmisc.c (print_objfile_statistics, dump_objfile)
8311         (maintenance_print_symbols): Use compunit_filetabs.
8312         * source.c (forget_cached_source_info_for_objfile): Use
8313         compunit_filetabs.
8314         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8315         (ALL_FILETABS): Use compunit_filetabs.
8316         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8317         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8318
8319 2019-01-09  Tom Tromey  <tom@tromey.com>
8320
8321         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8322         (compunit_filetabs): New.
8323         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8324         compunit_filetabs.
8325         (info_sources_command, make_source_files_completion_list): Remove
8326         declaration.
8327         * symmisc.c (print_objfile_statistics, dump_objfile)
8328         (maintenance_print_symbols): Remove declaration.
8329         (maintenance_info_symtabs): Use compunit_filetabs.
8330         (maintenance_info_line_tables): Likewise.
8331         * source.c (select_source_symtab): Change local variable name.
8332         (forget_cached_source_info_for_objfile): Remove declaration.
8333         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8334         * objfiles.c (objfile_relocate1): Remove declaration.
8335         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8336         declaration.
8337         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8338         * coffread.c (coff_symtab_read): Remove declaration.
8339         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8340         compunit_filetabs.
8341
8342 2019-01-09  Tom Tromey  <tom@tromey.com>
8343
8344         * symtab.c (lookup_objfile_from_block)
8345         (find_pc_sect_compunit_symtab, search_symbols)
8346         (default_collect_symbol_completion_matches_break_on): Use
8347         objfile_compunits.
8348         * objfiles.h (ALL_COMPUNITS): Remove.
8349         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8350         * cp-support.c (add_symbol_overload_list_qualified): Use
8351         objfile_compunits.
8352         * ada-lang.c (ada_collect_symbol_completion_matches)
8353         (ada_add_global_exceptions): Use objfile_compunits.
8354
8355 2019-01-09  Tom Tromey  <tom@tromey.com>
8356
8357         * source.c (select_source_symtab)
8358         (forget_cached_source_info_for_objfile): Remove declaration.
8359         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8360         declaration.
8361         * maint.c (count_symtabs_and_blocks): Remove declaration.
8362         * cp-support.c (add_symbol_overload_list_qualified): Remove
8363         declaration.
8364         * coffread.c (coff_symtab_read): Remove declaration.
8365         * symtab.c (lookup_symbol_in_objfile_symtabs)
8366         (basic_lookup_transparent_type_1): Use objfile_compunits.
8367         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8368         (info_sources_command, search_symbols)
8369         (default_collect_symbol_completion_matches_break_on)
8370         (make_source_files_completion_list): Remove declaration.
8371         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8372         (ada_collect_symbol_completion_matches)
8373         (ada_add_global_exceptions): Remove declaration.
8374         * linespec.c (iterate_over_all_matching_symtabs): Use
8375         objfile_compunits.
8376         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8377         (class objfile_compunits): New.
8378         (ALL_COMPUNITS): Use objfile_compunits.
8379         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8380         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8381         objfile_compunits.
8382         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8383
8384 2019-01-09  Tom Tromey  <tom@tromey.com>
8385
8386         * symtab.c (search_symbols)
8387         (default_collect_symbol_completion_matches_break_on): Use
8388         objfile_msymbols.
8389         * ada-lang.c (ada_lookup_simple_minsym)
8390         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8391         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8392         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8393         objfile_msymbols.
8394         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8395         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8396         * objc-lang.c (find_methods): Use objfile_msymbols.
8397         (info_selectors_command, info_classes_command): Likewise.
8398         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8399         * objfiles.h (class objfile_msymbols): New.
8400         (ALL_OBJFILE_MSYMBOLS): Remove.
8401         (ALL_MSYMBOLS): Remove.
8402
8403 2019-01-09  Tom Tromey  <tom@tromey.com>
8404
8405         * common/next-iterator.h (next_adapter): Add Iterator template
8406         parameter.
8407         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8408         (class all_objfiles_safe): New.
8409         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8410         * objfiles.c (put_objfile_before): Update comment.
8411         (add_separate_debug_objfile): Likewise.
8412         (free_all_objfiles): Use all_objfiles_safe.
8413         (objfile_purge_solibs): Likewise.
8414
8415 2019-01-09  Tom Tromey  <tom@tromey.com>
8416
8417         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8418         (expand_symtab_containing_pc, lookup_static_symbol)
8419         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8420         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8421         all_objfiles.
8422         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8423         * breakpoint.c (create_overlay_event_breakpoint)
8424         (create_longjmp_master_breakpoint)
8425         (create_std_terminate_master_breakpoint)
8426         (create_exception_master_breakpoint): Use all_objfiles.
8427         * linux-thread-db.c (try_thread_db_load_from_pdir)
8428         (has_libpthread): Use all_objfiles.
8429         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8430         * linespec.c (iterate_over_all_matching_symtabs)
8431         (search_minsyms_for_name): Use all_objfiles.
8432         * maint.c (maintenance_info_sections): Use all_objfiles.
8433         * main.c (captured_main_1): Use all_objfiles.
8434         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8435         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8436         * guile/scm-pretty-print.c
8437         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8438         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8439         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8440         (maintenance_print_msymbols): Use all_objfiles.
8441         * source.c (select_source_symtab): Use all_objfiles.
8442         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8443         * symfile.c (remove_symbol_file_command)
8444         (expand_symtabs_matching, map_symbol_filenames): Use
8445         all_objfiles.
8446         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8447         all_objfiles.
8448         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8449         * objc-lang.c (find_methods): Use all_objfiles.
8450         * objfiles.c (have_partial_symbols, have_full_symbols)
8451         (have_minimal_symbols, qsort_cmp)
8452         (default_iterate_over_objfiles_in_search_order): Use
8453         all_objfiles.
8454         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8455         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8456         (maintenance_check_psymtabs): Use all_objfiles.
8457         (ALL_PSYMTABS): Remove.
8458         * compile/compile-object-run.c (do_module_cleanup): Use
8459         all_objfiles.
8460         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8461         * cp-support.c (add_symbol_overload_list_qualified): Use
8462         all_objfiles.
8463         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8464         Use all_objfiles.
8465         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8466         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8467         all_objfiles.
8468         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8469         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8470         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8471         Uses all_objfiles.
8472         * solib.c (solib_read_symbols): Use all_objfiles
8473
8474 2019-01-09  Tom Tromey  <tom@tromey.com>
8475
8476         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8477         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8478         all_objfiles.
8479         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8480         * symmisc.c (print_symbol_bcache_statistics)
8481         (print_objfile_statistics, maintenance_print_objfiles)
8482         (maintenance_info_symtabs, maintenance_check_symtabs)
8483         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8484         all_objfiles.
8485         * source.c (forget_cached_source_info): Use all_objfiles.
8486         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8487         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8488         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8489         * objfiles.c (update_section_map): Use all_objfiles.
8490         (shared_objfile_contains_address_p): Likewise.
8491         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8492         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8493
8494 2019-01-09  Tom Tromey  <tom@tromey.com>
8495
8496         * common/next-iterator.h: New file.
8497         * objfiles.h (class all_objfiles): New.
8498         (struct objfile_iterator): New.
8499
8500 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8501
8502         * NEWS: Move the description of the changed "frame", "select-frame",
8503          and "info frame" commands to the Changed commands section.
8504
8505 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8506
8507         * gdbtypes.c (check_stub_method_group): Remove handling of old
8508         mangling schemes.
8509         * linespec.c (find_methods): Likewise.
8510         * stabsread.c (read_member_functions): Likewise.
8511         * valops.c (search_struct_method): Likewise.
8512         (value_struct_elt_for_reference): Likewise.
8513         * NEWS: Mention this change.
8514
8515 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8516
8517         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8518         print_source_lines.
8519         * source.c (print_source_lines_base): Update line number check.
8520         (print_source_lines): New function.
8521         (source_lines_range::source_lines_range): New function.
8522         * source.h (class source_lines_range): New class.
8523         (print_source_lines): New declaration.
8524
8525 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8526
8527         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8528
8529 2019-01-08  Tom Tromey  <tom@tromey.com>
8530             Simon Marchi  <simon.marchi@ericsson.com>
8531
8532         PR gdb/24060
8533         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8534         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8535         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8536         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8537         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8538         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8539
8540 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8541
8542         * source.c (select_source_symtab): Move header comment to
8543         declaration in source.h.
8544         (forget_cached_source_info_for_objfile): Likewise.
8545         (forget_cached_source_info): Likewise.
8546         (identify_source_line): Likewise.
8547         * source.h (identify_source_line): Move declaration from symtab.h
8548         and add comment from source.c
8549         (print_source_lines): Likewise.
8550         (forget_cached_source_info_for_objfile): Likewise.
8551         (forget_cached_source_info): Likewise.
8552         (select_source_symtab): Likewise.
8553         (enum print_source_lines_flag): Move definition from symtab.h.
8554         * symtab.h (identify_source_line): Move declaration to source.h.
8555         (print_source_lines): Likewise.
8556         (forget_cached_source_info_for_objfile): Likewise.
8557         (forget_cached_source_info): Likewise.
8558         (select_source_symtab): Likewise.
8559         (enum print_source_lines_flag): Move definition to source.h.
8560         * tui/tui-hooks.c: Add 'source.h' include.
8561
8562 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8563
8564         * source.c (print_source_lines_base): Handle requests to print
8565         reverse line number sequences, and guard against empty lines
8566         string.
8567
8568 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8569
8570         * source.c (print_source_lines_base): Fix skip of '\r' if next
8571         character is '\n'.
8572
8573 2019-01-06  Tom Tromey  <tom@tromey.com>
8574
8575         * c-exp.y (struct c_parse_state) <macro_original_text,
8576         expansion_obstack>: New member.
8577         (macro_original_text, expansion_obstack): Remove globals.
8578         (scan_macro_expansion, scanning_macro_expansion)
8579         (finished_macro_expansion): Update.
8580         (scan_macro_cleanup): Remove.
8581         (yylex, c_parse): Update.
8582
8583 2019-01-06  Tom Tromey  <tom@tromey.com>
8584
8585         * c-exp.y (struct c_parse_state) <strings>: New member.
8586         (operator_stoken): Update.
8587
8588 2019-01-06  Tom Tromey  <tom@tromey.com>
8589
8590         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8591         (union type_stack_elt) <typelist_val>: Now a pointer to
8592         std::vector.
8593         (type_stack_cleanup): Don't declare.
8594         (push_typelist): Update.
8595         * parse.c (pop_typelist): Return a std::vector.
8596         (push_typelist): Take a std::vector.
8597         (follow_types): Update.  Do not free args.
8598         (type_stack_cleanup): Remove.
8599         * c-exp.y (struct c_parse_state): New.
8600         (cpstate): New global.
8601         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8602         (nonempty_typelist): Update.
8603         (func_mod): Create a new vector.
8604         (c_parse): Create a c_parse_state.
8605         (check_parameter_typelist): Do not delete params.
8606         (function_method): Update.  Do not delete type_list.
8607
8608 2019-01-06  Tom Tromey  <tom@tromey.com>
8609
8610         PR gdb/28155:
8611         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8612         check_typedef.
8613         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8614         (print_return_value): Likewise.
8615
8616 2019-01-05  Tom Tromey  <tom@tromey.com>
8617
8618         * contrib/cleanup_check.py: Remove.
8619         * contrib/gcc-with-excheck: Remove.
8620         * contrib/exsummary.py: Remove.
8621         * contrib/excheck.py: Remove.
8622
8623 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8624
8625         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8626         NULL. Initialize tpprev to NULL instead of assigning it
8627         to NULL on the next statement.
8628         * windows-nat.c (windows_delete_thread): Remove check for
8629         main_thread_id before printing thread exit notifications.
8630         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8631         Remove thread ID check against main_thread_id.
8632         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8633         windows_delete_thread.
8634         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8635
8636 2019-01-04  Tom Tromey  <tom@tromey.com>
8637
8638         * compile/compile.c (_initialize_compile): Use upper case for
8639         metasyntactic variables.
8640         * symmisc.c (_initialize_symmisc): Use upper case for
8641         metasyntactic variables.
8642         * psymtab.c (_initialize_psymtab): Use upper case for
8643         metasyntactic variables.
8644         * demangle.c (demangle_command): Use upper case for metasyntactic
8645         variables.
8646         (_initialize_demangler): Likewise.
8647         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8648         variables.
8649
8650 2019-01-03  Tom Tromey  <tom@tromey.com>
8651
8652         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8653
8654 2019-01-03  Tom Tromey  <tom@tromey.com>
8655
8656         * python/py-symtab.c (salpy_str): Update.
8657         (struct salpy_sal_object) <symtab>: Now a PyObject.
8658         (salpy_dealloc): Update.
8659         (del_objfile_sal): Use gdbpy_ref.
8660
8661 2019-01-03  Tom Tromey  <tom@tromey.com>
8662
8663         * python/py-type.c (convert_field): Use new_reference.  Return
8664         gdbpy_ref.
8665         (make_fielditem): Return gdbpy_ref.
8666         (typy_fields): Update.
8667         (typy_getitem): Update.
8668         (field_name): Return gdbpy_ref.  Use new_reference.
8669         (typy_iterator_iternext): Update.
8670
8671 2019-01-03  Tom Tromey  <tom@tromey.com>
8672
8673         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8674
8675 2019-01-03  Tom Tromey  <tom@tromey.com>
8676
8677         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8678         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8679         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8680         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8681         (pspy_set_type_printers): Likewise.
8682         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8683         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8684         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8685         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8686         (objfpy_set_type_printers): Likewise.
8687
8688 2019-01-03  Tom Tromey  <tom@tromey.com>
8689
8690         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8691         (gdbpy_print_stack): Use gdbpy_err_fetch.
8692         * python/python-internal.h (class gdbpy_err_fetch): New class.
8693         (class gdbpy_enter) <m_error_type, m_error_value,
8694         m_error_traceback>: Remove.
8695         <m_error>: New member.
8696         (gdbpy_exception_to_string): Don't declare.
8697         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8698         * python/py-value.c (convert_value_from_python): Use
8699         gdbpy_err_fetch.
8700         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8701         gdbpy_exception_to_string.
8702         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8703         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8704         gdbpy_err_fetch.
8705
8706 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8707
8708         * linux-nat.c (delete_lwp_cleanup): Delete.
8709         (struct lwp_deleter): New struct.
8710         (lwp_info_up): New typedef.
8711         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8712         lwp_info_up.
8713
8714 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8715
8716         * linux-fork.c (class scoped_switch_fork_info): New class.
8717         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8718
8719 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8720
8721         * valops.c (find_overload_match): Remove use of null_cleanup, and
8722         calls to do_cleanups.
8723
8724 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8725
8726         * compile/compile-cplus-types.c
8727         (compile_cplus_instance::decl_name): Handle changes to
8728         cp_func_name.
8729         * cp-support.c (cp_func_name): Update header comment, update
8730         return type.
8731         * cp-support.h (cp_func_name): Update return type in declaration.
8732         * valops.c (find_overload_match): Move temp_func local to top
8733         level of function and change its type.  Use temp_func to hold and
8734         delete temporary string obtained from cp_func_name.
8735
8736 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8737
8738         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8739         gdb::char_vector, remove cleanup, and update uses of `msg`.
8740
8741 2019-01-03  Jim Wilson  <jimw@sifive.com>
8742
8743         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8744
8745 2019-01-02  Tom Tromey  <tom@tromey.com>
8746
8747         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8748         (tdesc_parse_xml): Remove cleanups.
8749         * target-descriptions.h (make_cleanup_free_target_description):
8750         Don't declare.
8751         (target_desc_deleter): New struct.
8752         (target_desc_up): New typedef.
8753         * target-descriptions.c (target_desc_deleter::operator()): Rename
8754         from free_target_description.
8755         (make_cleanup_free_target_description): Remove.
8756
8757 2019-01-02  Tom Tromey  <tom@tromey.com>
8758
8759         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8760         constructor, destructor.
8761         (linespec_parser): Remove typedef.
8762         (~linespec_parser): Rename from linespec_parser_delete.
8763         (linespec_lex_to_end, linespec_complete_label)
8764         (linespec_complete): Update.
8765         (decode_line_full): Remove cleanups.
8766         (decode_line_1): Update.
8767
8768 2019-01-02  Tom Tromey  <tom@tromey.com>
8769
8770         * python/python-internal.h (inferior_to_inferior_object): Change
8771         return type.
8772         * python/py-exitedevent.c (create_exited_event_object): Update.
8773         * python/py-inferior.c (inferior_to_inferior_object): Return
8774         gdbpy_ref.
8775         (python_new_inferior, python_inferior_deleted)
8776         (thread_to_thread_object, delete_thread_object)
8777         (build_inferior_list, gdbpy_selected_inferior): Update.
8778         * python/py-infthread.c (create_thread_object): Update.  Also fail
8779         if inferior_to_inferior_object fails.
8780
8781 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8782
8783         * inferior.h (class inferior) <displaced_step_state>: New field.
8784         * infrun.h (struct displaced_step_state): Move here from
8785         infrun.c.  Initialize fields, add constructor.
8786         <inf>: Remove field.
8787         <reset>: New method.
8788         * infrun.c (struct displaced_step_inferior_state): Move to
8789         infrun.h.
8790         (displaced_step_inferior_states): Remove.
8791         (get_displaced_stepping_state): Adust.
8792         (displaced_step_in_progress_any_inferior): Adjust.
8793         (displaced_step_in_progress_thread): Adjust.
8794         (displaced_step_in_progress): Adjust.
8795         (add_displaced_stepping_state): Remove.
8796         (get_displaced_step_closure_by_addr): Adjust.
8797         (remove_displaced_stepping_state): Remove.
8798         (infrun_inferior_exit): Call displaced_step_state.reset.
8799         (use_displaced_stepping): Don't check for NULL.
8800         (displaced_step_prepare_throw): Call
8801         get_displaced_stepping_state.
8802         (displaced_step_fixup): Don't check for NULL.
8803         (prepare_for_detach): Don't check for NULL.
8804
8805 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8806
8807         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8808          in case of call that did not complete.
8809
8810 2019-01-02  Andrey Utkin  <autkin@undo.io>
8811
8812         * symfile.c (find_separate_debug_file): Fix search of debug files for
8813         remote debuggee.
8814
8815 2019-01-02  Tom Tromey  <tom@tromey.com>
8816
8817         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8818         indentation.
8819         * python/py-frame.c (frapy_older): Remove cast.
8820         (frapy_newer): Likewise.
8821         * python/py-breakpoint.c (local_setattro): Remove cast.
8822         * python/py-arch.c (archpy_name): Remove local variable.
8823         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8824
8825 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8826
8827         * unittests/basic_string_view/element_access/char/empty.cc:
8828         Fix year range in copyright header.
8829
8830 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8833         Delete.
8834         <operator==>: Update with for removed field.
8835         <hash>: Likewise.
8836         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8837         <isa_features>: ...this.
8838         <abi_features>: New field.
8839         (riscv_isa_flen): Update comment.
8840         (riscv_abi_xlen): New declaration.
8841         (riscv_abi_flen): New declaration.
8842         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8843         isa_features.
8844         (riscv_abi_xlen): New function.
8845         (riscv_isa_flen): Update to get answer from isa_features.
8846         (riscv_abi_flen): New function.
8847         (riscv_has_fp_abi): Update to get answer from abi_features.
8848         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8849         xlen and flen.
8850         (riscv_call_info) <xlen, flen>: Update comment.
8851         (riscv_call_arg_struct): Remove invalid assertions
8852         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8853         is removed.
8854         (riscv_gdbarch_init): Gather isa features and abi features
8855         separately, ensure both match on the gdbarch when reusing an old
8856         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8857         a target with 64-bit float hardware.
8858
8859 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8860
8861         * source.c (search_command_helper): Stop reverse search
8862         when line 1 has been searched.
8863
8864 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8865
8866         * record-full.c (record_full_base_target::close): Rewrite
8867         record_full_core_buf_list free logic.
8868
8869 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8870
8871         * break-catch-syscall.c (print_one_catch_syscall): xfree
8872         the last text.
8873
8874 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8875
8876         * top.c (print_gdb_version): Update Copyright year in version
8877         message.
8878
8879 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8880
8881         Update copyright year range in all GDB files.
8882
8883 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8884
8885         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8886
8887 For older changes see ChangeLog-2018.
8888 \f
8889 Local Variables:
8890 mode: change-log
8891 left-margin: 8
8892 fill-column: 74
8893 version-control: never
8894 coding: utf-8
8895 End:
8896