gdb/ChangeLog

   1 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * features/riscv/32bit-cpu.xml: Add register numbers.
   4         * features/riscv/32bit-fpu.c: Regenerate.
   5         * features/riscv/32bit-fpu.xml: Add register numbers.
   6         * features/riscv/64bit-cpu.xml: Add register numbers.
   7         * features/riscv/64bit-fpu.c: Regenerate.
   8         * features/riscv/64bit-fpu.xml: Add register numbers.
   9
  10 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  11
  12         * NEWS: Mention two argument form of gdb.Value constructor.
  13         * python/py-value.c (convert_buffer_and_type_to_value): New
  14         function.
  15         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  16         Add support for handling an optional second argument.  Call
  17         convert_buffer_and_type_to_value as appropriate.
  18         * python/python-internal.h (Py_buffer_deleter): New struct.
  19         (Py_buffer_up): New typedef.
  20
  21 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  22
  23         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  24         instead of releasing ownership.
  25
  26 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  27
  28         * dwarf2read.c (open_and_init_dwp_file): Call
  29         elf_numsections instead of bfd_count_sections to initialize
  30         dwp_file->num_sections.
  31
  32 2019-02-25  Tom Tromey  <tromey@adacore.com>
  33
  34         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  35
  36 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  37
  38         * gcore.in: Add '--readnever' option when invoking GDB.
  39
  40 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  41
  42         * MAINTAINERS: Update my email address.
  43
  44 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  45
  46         * build-id.c (build_id_to_debug_bfd_1): New function.
  47         (build_id_to_debug_bfd): Look for separate debug file in
  48         sysroot.
  49
  50 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * gdbarch.sh: Update the copyright year range that is placed into
  53         generated files.
  54
  55 2019-02-22  Keith Seitz  <keiths@redhat.com>
  56
  57         PR symtab/23853
  58         * linespec.c (create_sals_line_offset): Search for the default
  59         symtab's filename instead of its fullname.
  60
  61 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  62
  63         * NEWS: Update style defaults.
  64
  65 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  66
  67         * main.c (captured_main_1): Disable styling in batch mode.
  68
  69 2019-02-20  Tom Tromey  <tom@tromey.com>
  70
  71         * symtab.c (symtab_symbol_info): Fix typos.
  72
  73 2019-02-20  Tom Tromey  <tromey@adacore.com>
  74
  75         * findcmd.c (_initialize_mem_search): Use upper case for
  76         metasyntactic variables.
  77
  78 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  79
  80         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  81         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  82
  83 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  84
  85         * top.h (source_file_name): Change to std::string.
  86         * top.c (source_file_name): Likewise.
  87         (command_line_input): Adjust.
  88         * cli/cli-script.c (script_from_file): Adjust.
  89
  90 2019-02-19  Tom Tromey  <tromey@adacore.com>
  91
  92         * ravenscar-thread.c
  93         (ravenscar_thread_target::update_thread_list): Don't call
  94         ada_build_task_list.
  95         * ada-lang.h (ada_build_task_list): Don't declare.
  96         * ada-tasks.c (struct ada_tasks_inferior_data)
  97         <task_list_valid_p>: Now bool.
  98         (read_known_tasks, ada_task_list_changed)
  99         (ada_tasks_invalidate_inferior_data): Update.
 100         (read_known_tasks_array): Return bool.
 101         (read_known_tasks_list): Likewise.
 102         (read_known_tasks): Return void.
 103         (ada_build_task_list): Now static.
 104
 105 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 106
 107         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 108         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 109
 110 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 111
 112         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 113         variant for ada_tasks_pspace_data_handle and
 114         ada_tasks_inferior_data_handle.
 115         (ada_tasks_pspace_data_cleanup): New function.
 116         (ada_tasks_inferior_data_cleanup): New function.
 117
 118 2019-02-17  Tom Tromey  <tom@tromey.com>
 119
 120         * macrotab.h (macro_source_fullname): Return a std::string.
 121         * macrotab.c (macro_include, check_for_redefinition)
 122         (macro_undef, macro_lookup_definition, foreach_macro)
 123         (foreach_macro_in_scope): Update.
 124         (macro_source_fullname): Return a std::string.
 125         * macrocmd.c (show_pp_source_pos): Update.
 126
 127 2019-02-17  Tom Tromey  <tom@tromey.com>
 128
 129         * macrocmd.c (show_pp_source_pos): Style the file names.
 130
 131 2019-02-17  Tom Tromey  <tom@tromey.com>
 132
 133         PR tui/24197:
 134         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 135
 136 2019-02-17  Tom Tromey  <tom@tromey.com>
 137
 138         * ada-lang.c (user_select_syms): Use filtered printing.
 139         * utils.c (wrap_style): New global.
 140         (desired_style): Remove.
 141         (emit_style_escape): Add stream parameter.
 142         (set_output_style, reset_terminal_style, prompt_for_continue):
 143         Update.
 144         (flush_wrap_buffer): Only flush gdb_stdout.
 145         (wrap_here): Set wrap_style.
 146         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 147         treat escape sequences as a character.  Change when wrap buffer is
 148         flushed.
 149         (fputs_styled): Do not set the output style when the default is
 150         requested.
 151         * ui-style.h (struct ui_file_style) <is_default>: New method.
 152         * source.c (print_source_lines_base): Emit escape sequences in one
 153         piece.
 154
 155 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 156
 157         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 158         integers and enumeration types.
 159
 160 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 161
 162         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 163         instead of lookup_symbol_in_language
 164         (do_exact_match): New function.
 165         (ada_get_symbol_name_matcher): Return do_exact_match when
 166         doing a verbatim match.
 167
 168 2019-02-15  Tom Tromey  <tromey@adacore.com>
 169
 170         * ravenscar-thread.c (ravenscar_thread_target::resume)
 171         (ravenscar_thread_target::wait): Special case wildcard requests.
 172
 173 2019-02-15  Tom Tromey  <tromey@adacore.com>
 174
 175         * ravenscar-thread.c (base_ptid): Remove.
 176         (struct ravenscar_thread_target) <close>: New method.
 177         <m_base_ptid>: New member.
 178         <update_inferior_ptid, active_task, task_is_currently_active,
 179         runtime_initialized>: Declare methods.
 180         <ravenscar_thread_target>: Add constructor.
 181         (ravenscar_thread_target::task_is_currently_active)
 182         (ravenscar_thread_target::update_inferior_ptid)
 183         (ravenscar_runtime_initialized): Rename.  Now methods.
 184         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 185         (ravenscar_thread_target::update_thread_list): Update.
 186         (ravenscar_thread_target::active_task): Now method.
 187         (ravenscar_thread_target::store_registers)
 188         (ravenscar_thread_target::prepare_to_store)
 189         (ravenscar_thread_target::prepare_to_store)
 190         (ravenscar_thread_target::mourn_inferior): Update.
 191         (ravenscar_inferior_created): Use "new" to create target.
 192         (ravenscar_thread_target::get_ada_task_ptid): Update.
 193         (_initialize_ravenscar): Don't initialize base_ptid.
 194         (ravenscar_ops): Remove global.
 195
 196 2019-02-15  Tom Tromey  <tromey@adacore.com>
 197
 198         * target.h (push_target): Declare new overload.
 199         * target.c (push_target): New overload, taking an rvalue reference.
 200         * remote.c (remote_target::open_1): Use push_target overload.
 201         * corelow.c (core_target_open): Use push_target overload.
 202
 203 2019-02-15  Tom Tromey  <tromey@adacore.com>
 204
 205         * ravenscar-thread.c (is_ravenscar_task)
 206         (ravenscar_task_is_currently_active): Return bool.
 207         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 208         (_initialize_ravenscar): Remove "(void)".
 209         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 210         Return bool.
 211
 212 2019-02-15  Tom Tromey  <tromey@adacore.com>
 213
 214         * ravenscar-thread.c (ravenscar_runtime_initializer)
 215         (has_ravenscar_runtime, get_running_thread_id)
 216         (ravenscar_thread_target::resume): Fix indentation.
 217
 218 2019-02-15  Tom Tromey  <tromey@adacore.com>
 219
 220         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 221         from ravenscar_arch_ops.
 222         (sparc_ravenscar_ops::fetch_registers)
 223         (sparc_ravenscar_ops::store_registers): Now methods.
 224         (sparc_ravenscar_prepare_to_store): Remove.
 225         (sparc_ravenscar_ops): Redefine.
 226         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 227         methods and destructor.  Remove members.
 228         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 229         (ravenscar_thread_target::store_registers)
 230         (ravenscar_thread_target::prepare_to_store): Update.
 231         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 232         Remove.
 233         (struct ppc_ravenscar_powerpc_ops): Derive from
 234         ravenscar_arch_ops.
 235         (ppc_ravenscar_powerpc_ops::fetch_registers)
 236         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 237         (ppc_ravenscar_powerpc_ops): Redefine.
 238         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 239         (ppc_ravenscar_e500_ops::fetch_registers)
 240         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 241         (ppc_ravenscar_e500_ops): Redefine.
 242         * aarch64-ravenscar-thread.c
 243         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 244         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 245         (aarch64_ravenscar_fetch_registers)
 246         (aarch64_ravenscar_store_registers): Now methods.
 247         (aarch64_ravenscar_ops): Redefine.
 248
 249 2019-02-15  Tom Tromey  <tromey@adacore.com>
 250
 251         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 252         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 253         (ravenscar_thread_target::stopped_by_watchpoint)
 254         (ravenscar_thread_target::stopped_data_address)
 255         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 256
 257 2019-02-15  Tom Tromey  <tromey@adacore.com>
 258
 259         * ravenscar-thread.c: Fix some typos.
 260
 261 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 262             Tom Tromey  <tromey@adacore.com>
 263
 264         * ada-lang.c (ada_exception_sal): Change addr_string to a
 265         std::string.
 266         (create_ada_exception_catchpoint): Update.
 267
 268 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 269             Tom Tromey  <tromey@adacore.com>
 270
 271         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 272         (bp_location_ops): Remove.
 273         (base_breakpoint_allocate_location): Update.
 274         (free_bp_location): Update.
 275         * ada-lang.c (class ada_catchpoint_location)
 276         <ada_catchpoint_location>: Remove ops parameter.
 277         (ada_catchpoint_location_dtor): Remove.
 278         (ada_catchpoint_location_ops): Remove.
 279         (allocate_location_exception): Update.
 280         * breakpoint.h (struct bp_location_ops): Remove.
 281         (class bp_location) <bp_location>: Remove bp_location_ops
 282         parameter.
 283         <~bp_location>: Add destructor.
 284         <ops>: Remove.
 285
 286 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 287             Pedro Alves  <palves@redhat.com>
 288
 289         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 290         'PATH_MAX'.
 291
 292 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 293             Samuel Thibault  <samuel.thibault@gnu.org>
 294             Thomas Schwinge  <thomas@codesourcery.com>
 295
 296         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 297         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 298
 299 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 300
 301         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 302         (check_empty): Use "const char *".
 303
 304         * gnu-nat.c (gnu_nat_target::detach): Instead of
 305         'detach_inferior (pid)' call
 306         'detach_inferior (find_inferior_pid (pid))'.
 307
 308         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 309         'nat/fork-inferior.o'.
 310         * gnu-nat.c: #include "nat/fork-inferior.h".
 311
 312         * gnu-nat.c (gnu_nat_target::detach): Instead of
 313         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 314         * gnu-nat.h: #include "inf-child.h".
 315         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 316         'i386_gnu_nat_target::fetch_registers'.
 317         (gnu_store_registers): Rename/move to
 318         'i386_gnu_nat_target::store_registers'.
 319
 320         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 321         * gnu-nat.h (mach_thread_info): New function.
 322         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 323
 324         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 325
 326 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 327
 328         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 329
 330 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 331
 332         * windows-nat.c (windows_add_thread): Add new parameter
 333         "main_thread_p" with default value set to false.  Update
 334         function documentation as well as all callers.
 335         (windows_delete_thread): Likewise.
 336         (fake_create_process): Update call to windows_add_thread.
 337         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 338         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 339         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 340         call to windows_delete_thread.
 341
 342 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 343
 344         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 345
 346 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 347
 348         * symfile.c (find_separate_debug_file): Use canonical path of
 349         sysroot with child_path instead of gdb_sysroot if it is valid.
 350
 351 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 352
 353         * symfile.c (find_separate_debug_file): Use child_path to
 354         determine if an object file is under a sysroot.
 355
 356 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 357
 358         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 359         unittests/child-path-selftests.c.
 360         * common/pathstuff.c (child_path): New function.
 361         * common/pathstuff.h (child_path): New prototype.
 362         * unittests/child-path-selftests.c: New file.
 363
 364 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 365
 366         * symfile.c (find_separate_debug_file): Look for separate debug
 367         files in debug directories under the sysroot.
 368
 369 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 370
 371         * symtab.h (struct minimal_symbol data_p): New const method.
 372         (struct minimal_symbol text_p): Likewise.
 373         * symtab.c (output_source_filename): Use file name style
 374         to print file name.
 375         (print_symbol_info): Likewise.
 376         (print_msymbol_info): Use address style to print addresses.
 377         Use function name style to print executable text symbols.
 378         (expand_symtab_containing_pc): Use data_p.
 379         (find_pc_sect_compunit_symtab): Likewise.
 380
 381 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 382
 383         * breakpoint.c (describe_other_breakpoints): Use address style
 384         to print addresses.
 385         (say_where): Likewise.
 386
 387 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 388
 389         * ada-typeprint.c (print_func_type): Print function name
 390         style to print function name.
 391         * c-typeprint.c (c_print_type_1): Likewise.
 392
 393 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 394
 395         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 396         for execve.
 397
 398 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 399
 400         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 401         type_stack.
 402
 403 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 404
 405         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 406         TYPE_CODE_REF types.
 407
 408 2019-02-08  Jim Wilson  <jimw@sifive.com>
 409
 410         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 411         (riscv_linux_fregset): New.
 412         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 413
 414 2019-02-07  Tom Tromey  <tom@tromey.com>
 415
 416         * thread.c (thread_cancel_execution_command): Update.
 417         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 418         methods.
 419         (struct thread_fsm_ops): Remove.
 420         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 421         (thread_fsm_should_stop, thread_fsm_return_value)
 422         (thread_fsm_set_finished, thread_fsm_finished_p)
 423         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 424         Don't declare.
 425         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 426         * infrun.c (clear_proceed_status_thread)
 427         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 428         (print_stop_event): Update.
 429         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 430         Add constructor.
 431         (step_command_fsm_ops): Remove.
 432         (new_step_command_fsm): Remove.
 433         (step_1): Update.
 434         (step_command_fsm::should_stop): Rename from
 435         step_command_fsm_should_stop.
 436         (step_command_fsm::clean_up): Rename from
 437         step_command_fsm_clean_up.
 438         (step_command_fsm::do_async_reply_reason): Rename from
 439         step_command_fsm_async_reply_reason.
 440         (struct until_next_fsm): Inherit from thread_fsm.  Add
 441         constructor.
 442         (until_next_fsm_ops): Remove.
 443         (new_until_next_fsm): Remove.
 444         (until_next_fsm::should_stop): Rename from
 445         until_next_fsm_should_stop.
 446         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 447         (until_next_fsm::do_async_reply_reason): Rename from
 448         until_next_fsm_async_reply_reason.
 449         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 450         constructor.  Change type of breakpoint.
 451         (finish_command_fsm_ops): Remove.
 452         (new_finish_command_fsm): Remove.
 453         (finish_command_fsm::should_stop): Rename from
 454         finish_command_fsm_should_stop.
 455         (finish_command_fsm::clean_up): Rename from
 456         finish_command_fsm_clean_up.
 457         (finish_command_fsm::return_value): Rename from
 458         finish_command_fsm_return_value.
 459         (finish_command_fsm::do_async_reply_reason): Rename from
 460         finish_command_fsm_async_reply_reason.
 461         (finish_command): Update.
 462         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 463         Add constructor.
 464         (call_thread_fsm_ops): Remove.
 465         (call_thread_fsm::call_thread_fsm): Rename from
 466         new_call_thread_fsm.
 467         (call_thread_fsm::should_stop): Rename from
 468         call_thread_fsm_should_stop.
 469         (call_thread_fsm::should_notify_stop): Rename from
 470         call_thread_fsm_should_notify_stop.
 471         (run_inferior_call, call_function_by_hand_dummy): Update.
 472         * cli/cli-interp.c (should_print_stop_to_console): Update.
 473         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 474         Add constructor.  Change type of location_breakpoint,
 475         caller_breakpoint.
 476         (until_break_fsm_ops): Remove.
 477         (new_until_break_fsm): Remove.
 478         (until_break_fsm::should_stop): Rename from
 479         until_break_fsm_should_stop.
 480         (until_break_fsm::clean_up): Rename from
 481         until_break_fsm_clean_up.
 482         (until_break_fsm::do_async_reply_reason): Rename from
 483         until_break_fsm_async_reply_reason.
 484         (until_break_command): Update.
 485         * thread-fsm.c: Remove.
 486         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 487
 488 2019-02-07  Tom Tromey  <tom@tromey.com>
 489
 490         * yy-remap.h: Add include guard.
 491         * xtensa-tdep.h: Add include guard.
 492         * xcoffread.h: Rename include guard.
 493         * varobj-iter.h: Add include guard.
 494         * tui/tui.h: Rename include guard.
 495         * tui/tui-winsource.h: Rename include guard.
 496         * tui/tui-wingeneral.h: Rename include guard.
 497         * tui/tui-windata.h: Rename include guard.
 498         * tui/tui-win.h: Rename include guard.
 499         * tui/tui-stack.h: Rename include guard.
 500         * tui/tui-source.h: Rename include guard.
 501         * tui/tui-regs.h: Rename include guard.
 502         * tui/tui-out.h: Rename include guard.
 503         * tui/tui-layout.h: Rename include guard.
 504         * tui/tui-io.h: Rename include guard.
 505         * tui/tui-hooks.h: Rename include guard.
 506         * tui/tui-file.h: Rename include guard.
 507         * tui/tui-disasm.h: Rename include guard.
 508         * tui/tui-data.h: Rename include guard.
 509         * tui/tui-command.h: Rename include guard.
 510         * tic6x-tdep.h: Add include guard.
 511         * target/waitstatus.h: Rename include guard.
 512         * target/wait.h: Rename include guard.
 513         * target/target.h: Rename include guard.
 514         * target/resume.h: Rename include guard.
 515         * target-float.h: Rename include guard.
 516         * stabsread.h: Add include guard.
 517         * rs6000-tdep.h: Add include guard.
 518         * riscv-fbsd-tdep.h: Add include guard.
 519         * regformats/regdef.h: Rename include guard.
 520         * record.h: Rename include guard.
 521         * python/python.h: Rename include guard.
 522         * python/python-internal.h: Rename include guard.
 523         * python/py-stopevent.h: Rename include guard.
 524         * python/py-ref.h: Rename include guard.
 525         * python/py-record.h: Rename include guard.
 526         * python/py-record-full.h: Rename include guard.
 527         * python/py-record-btrace.h: Rename include guard.
 528         * python/py-instruction.h: Rename include guard.
 529         * python/py-events.h: Rename include guard.
 530         * python/py-event.h: Rename include guard.
 531         * procfs.h: Add include guard.
 532         * proc-utils.h: Add include guard.
 533         * p-lang.h: Add include guard.
 534         * or1k-tdep.h: Rename include guard.
 535         * observable.h: Rename include guard.
 536         * nto-tdep.h: Rename include guard.
 537         * nat/x86-linux.h: Rename include guard.
 538         * nat/x86-linux-dregs.h: Rename include guard.
 539         * nat/x86-gcc-cpuid.h: Add include guard.
 540         * nat/x86-dregs.h: Rename include guard.
 541         * nat/x86-cpuid.h: Rename include guard.
 542         * nat/ppc-linux.h: Rename include guard.
 543         * nat/mips-linux-watch.h: Rename include guard.
 544         * nat/linux-waitpid.h: Rename include guard.
 545         * nat/linux-ptrace.h: Rename include guard.
 546         * nat/linux-procfs.h: Rename include guard.
 547         * nat/linux-osdata.h: Rename include guard.
 548         * nat/linux-nat.h: Rename include guard.
 549         * nat/linux-namespaces.h: Rename include guard.
 550         * nat/linux-btrace.h: Rename include guard.
 551         * nat/glibc_thread_db.h: Rename include guard.
 552         * nat/gdb_thread_db.h: Rename include guard.
 553         * nat/gdb_ptrace.h: Rename include guard.
 554         * nat/fork-inferior.h: Rename include guard.
 555         * nat/amd64-linux-siginfo.h: Rename include guard.
 556         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 557         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 558         * nat/aarch64-linux.h: Rename include guard.
 559         * nat/aarch64-linux-hw-point.h: Rename include guard.
 560         * mn10300-tdep.h: Add include guard.
 561         * mips-linux-tdep.h: Add include guard.
 562         * mi/mi-parse.h: Rename include guard.
 563         * mi/mi-out.h: Rename include guard.
 564         * mi/mi-main.h: Rename include guard.
 565         * mi/mi-interp.h: Rename include guard.
 566         * mi/mi-getopt.h: Rename include guard.
 567         * mi/mi-console.h: Rename include guard.
 568         * mi/mi-common.h: Rename include guard.
 569         * mi/mi-cmds.h: Rename include guard.
 570         * mi/mi-cmd-break.h: Rename include guard.
 571         * m2-lang.h: Add include guard.
 572         * location.h: Rename include guard.
 573         * linux-record.h: Rename include guard.
 574         * linux-nat.h: Add include guard.
 575         * linux-fork.h: Add include guard.
 576         * i386-darwin-tdep.h: Rename include guard.
 577         * hppa-linux-offsets.h: Add include guard.
 578         * guile/guile.h: Rename include guard.
 579         * guile/guile-internal.h: Rename include guard.
 580         * gnu-nat.h: Rename include guard.
 581         * gdb-stabs.h: Rename include guard.
 582         * frv-tdep.h: Add include guard.
 583         * f-lang.h: Add include guard.
 584         * event-loop.h: Add include guard.
 585         * darwin-nat.h: Rename include guard.
 586         * cp-abi.h: Rename include guard.
 587         * config/sparc/nm-sol2.h: Rename include guard.
 588         * config/nm-nto.h: Rename include guard.
 589         * config/nm-linux.h: Add include guard.
 590         * config/i386/nm-i386gnu.h: Rename include guard.
 591         * config/djgpp/nl_types.h: Rename include guard.
 592         * config/djgpp/langinfo.h: Rename include guard.
 593         * compile/gcc-cp-plugin.h: Add include guard.
 594         * compile/gcc-c-plugin.h: Add include guard.
 595         * compile/compile.h: Rename include guard.
 596         * compile/compile-object-run.h: Rename include guard.
 597         * compile/compile-object-load.h: Rename include guard.
 598         * compile/compile-internal.h: Rename include guard.
 599         * compile/compile-cplus.h: Rename include guard.
 600         * compile/compile-c.h: Rename include guard.
 601         * common/xml-utils.h: Rename include guard.
 602         * common/x86-xstate.h: Rename include guard.
 603         * common/version.h: Rename include guard.
 604         * common/vec.h: Rename include guard.
 605         * common/tdesc.h: Rename include guard.
 606         * common/selftest.h: Rename include guard.
 607         * common/scoped_restore.h: Rename include guard.
 608         * common/scoped_mmap.h: Rename include guard.
 609         * common/scoped_fd.h: Rename include guard.
 610         * common/safe-iterator.h: Rename include guard.
 611         * common/run-time-clock.h: Rename include guard.
 612         * common/refcounted-object.h: Rename include guard.
 613         * common/queue.h: Rename include guard.
 614         * common/ptid.h: Rename include guard.
 615         * common/print-utils.h: Rename include guard.
 616         * common/preprocessor.h: Rename include guard.
 617         * common/pathstuff.h: Rename include guard.
 618         * common/observable.h: Rename include guard.
 619         * common/netstuff.h: Rename include guard.
 620         * common/job-control.h: Rename include guard.
 621         * common/host-defs.h: Rename include guard.
 622         * common/gdb_wait.h: Rename include guard.
 623         * common/gdb_vecs.h: Rename include guard.
 624         * common/gdb_unlinker.h: Rename include guard.
 625         * common/gdb_unique_ptr.h: Rename include guard.
 626         * common/gdb_tilde_expand.h: Rename include guard.
 627         * common/gdb_sys_time.h: Rename include guard.
 628         * common/gdb_string_view.h: Rename include guard.
 629         * common/gdb_splay_tree.h: Rename include guard.
 630         * common/gdb_setjmp.h: Rename include guard.
 631         * common/gdb_ref_ptr.h: Rename include guard.
 632         * common/gdb_optional.h: Rename include guard.
 633         * common/gdb_locale.h: Rename include guard.
 634         * common/gdb_assert.h: Rename include guard.
 635         * common/filtered-iterator.h: Rename include guard.
 636         * common/filestuff.h: Rename include guard.
 637         * common/fileio.h: Rename include guard.
 638         * common/environ.h: Rename include guard.
 639         * common/common-utils.h: Rename include guard.
 640         * common/common-types.h: Rename include guard.
 641         * common/common-regcache.h: Rename include guard.
 642         * common/common-inferior.h: Rename include guard.
 643         * common/common-gdbthread.h: Rename include guard.
 644         * common/common-exceptions.h: Rename include guard.
 645         * common/common-defs.h: Rename include guard.
 646         * common/common-debug.h: Rename include guard.
 647         * common/cleanups.h: Rename include guard.
 648         * common/buffer.h: Rename include guard.
 649         * common/btrace-common.h: Rename include guard.
 650         * common/break-common.h: Rename include guard.
 651         * cli/cli-utils.h: Rename include guard.
 652         * cli/cli-style.h: Rename include guard.
 653         * cli/cli-setshow.h: Rename include guard.
 654         * cli/cli-script.h: Rename include guard.
 655         * cli/cli-interp.h: Rename include guard.
 656         * cli/cli-decode.h: Rename include guard.
 657         * cli/cli-cmds.h: Rename include guard.
 658         * charset-list.h: Add include guard.
 659         * buildsym-legacy.h: Rename include guard.
 660         * bfin-tdep.h: Add include guard.
 661         * ax.h: Rename include guard.
 662         * arm-linux-tdep.h: Add include guard.
 663         * arm-fbsd-tdep.h: Add include guard.
 664         * arch/xtensa.h: Rename include guard.
 665         * arch/tic6x.h: Add include guard.
 666         * arch/i386.h: Add include guard.
 667         * arch/arm.h: Rename include guard.
 668         * arch/arm-linux.h: Rename include guard.
 669         * arch/arm-get-next-pcs.h: Rename include guard.
 670         * arch/amd64.h: Add include guard.
 671         * arch/aarch64-insn.h: Rename include guard.
 672         * arch-utils.h: Rename include guard.
 673         * annotate.h: Add include guard.
 674         * amd64-darwin-tdep.h: Rename include guard.
 675         * aarch64-linux-tdep.h: Add include guard.
 676         * aarch64-fbsd-tdep.h: Add include guard.
 677         * aarch32-linux-nat.h: Add include guard.
 678
 679 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 680
 681         * macrotab.c (macro_define_internal): New function that
 682         factorizes macro_define_object_internal and macro_define_function
 683         code.
 684         (macro_define_object_internal): Use macro_define_internal.
 685         (macro_define_function): Likewise.
 686
 687 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 688
 689         * macrocmd.c (extract_identifier): Return
 690         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 691         callers.
 692
 693 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 694
 695         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 696
 697 2019-02-05  Tom Tromey  <tom@tromey.com>
 698
 699         * target.c (target_stack::unpush): Move assertion earlier.
 700
 701 2019-01-30  Tom Tromey  <tom@tromey.com>
 702
 703         PR python/23615:
 704         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 705         (gdbpy_parse_and_eval): Likewise.
 706         * python/python-internal.h (gdbpy_allow_threads): New class.
 707
 708 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 709
 710         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 711         (aarch64_fbsd_fpregmap): Move earlier.
 712         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 713         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 714         instead of individual calls to trad_frame_set_reg_addr.
 715         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 716         earlier.
 717         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 718         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 719         instead of individual calls to trad_frame_set_reg_addr.
 720
 721 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 722
 723         * CONTRIBUTE: Replace contribution list with wiki link.
 724
 725 2019-01-25  Tom Tromey  <tom@tromey.com>
 726
 727         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 728
 729 2019-01-25  Tom Tromey  <tom@tromey.com>
 730
 731         * xtensa-linux-nat.c: Fix common/ includes.
 732         * xml-support.h: Fix common/ includes.
 733         * xml-support.c: Fix common/ includes.
 734         * x86-linux-nat.c: Fix common/ includes.
 735         * windows-nat.c: Fix common/ includes.
 736         * varobj.h: Fix common/ includes.
 737         * varobj.c: Fix common/ includes.
 738         * value.c: Fix common/ includes.
 739         * valops.c: Fix common/ includes.
 740         * utils.c: Fix common/ includes.
 741         * unittests/xml-utils-selftests.c: Fix common/ includes.
 742         * unittests/utils-selftests.c: Fix common/ includes.
 743         * unittests/unpack-selftests.c: Fix common/ includes.
 744         * unittests/tracepoint-selftests.c: Fix common/ includes.
 745         * unittests/style-selftests.c: Fix common/ includes.
 746         * unittests/string_view-selftests.c: Fix common/ includes.
 747         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 748         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 749         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 750         * unittests/rsp-low-selftests.c: Fix common/ includes.
 751         * unittests/parse-connection-spec-selftests.c: Fix common/
 752         includes.
 753         * unittests/optional-selftests.c: Fix common/ includes.
 754         * unittests/offset-type-selftests.c: Fix common/ includes.
 755         * unittests/observable-selftests.c: Fix common/ includes.
 756         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 757         * unittests/memrange-selftests.c: Fix common/ includes.
 758         * unittests/memory-map-selftests.c: Fix common/ includes.
 759         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 760         * unittests/function-view-selftests.c: Fix common/ includes.
 761         * unittests/environ-selftests.c: Fix common/ includes.
 762         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 763         * unittests/common-utils-selftests.c: Fix common/ includes.
 764         * unittests/cli-utils-selftests.c: Fix common/ includes.
 765         * unittests/array-view-selftests.c: Fix common/ includes.
 766         * ui-file.c: Fix common/ includes.
 767         * tui/tui-io.c: Fix common/ includes.
 768         * tracepoint.h: Fix common/ includes.
 769         * tracepoint.c: Fix common/ includes.
 770         * tracefile-tfile.c: Fix common/ includes.
 771         * top.h: Fix common/ includes.
 772         * top.c: Fix common/ includes.
 773         * thread.c: Fix common/ includes.
 774         * target/waitstatus.h: Fix common/ includes.
 775         * target/waitstatus.c: Fix common/ includes.
 776         * target.h: Fix common/ includes.
 777         * target.c: Fix common/ includes.
 778         * target-memory.c: Fix common/ includes.
 779         * target-descriptions.c: Fix common/ includes.
 780         * symtab.h: Fix common/ includes.
 781         * symfile.c: Fix common/ includes.
 782         * stap-probe.c: Fix common/ includes.
 783         * spu-linux-nat.c: Fix common/ includes.
 784         * sparc-nat.c: Fix common/ includes.
 785         * source.c: Fix common/ includes.
 786         * solib.c: Fix common/ includes.
 787         * solib-target.c: Fix common/ includes.
 788         * ser-unix.c: Fix common/ includes.
 789         * ser-tcp.c: Fix common/ includes.
 790         * ser-pipe.c: Fix common/ includes.
 791         * ser-base.c: Fix common/ includes.
 792         * selftest-arch.c: Fix common/ includes.
 793         * s12z-tdep.c: Fix common/ includes.
 794         * rust-exp.y: Fix common/ includes.
 795         * rs6000-aix-tdep.c: Fix common/ includes.
 796         * riscv-tdep.c: Fix common/ includes.
 797         * remote.c: Fix common/ includes.
 798         * remote-notif.h: Fix common/ includes.
 799         * remote-fileio.h: Fix common/ includes.
 800         * remote-fileio.c: Fix common/ includes.
 801         * regcache.h: Fix common/ includes.
 802         * regcache.c: Fix common/ includes.
 803         * record-btrace.c: Fix common/ includes.
 804         * python/python.c: Fix common/ includes.
 805         * python/py-type.c: Fix common/ includes.
 806         * python/py-inferior.c: Fix common/ includes.
 807         * progspace.h: Fix common/ includes.
 808         * producer.c: Fix common/ includes.
 809         * procfs.c: Fix common/ includes.
 810         * proc-api.c: Fix common/ includes.
 811         * printcmd.c: Fix common/ includes.
 812         * ppc-linux-nat.c: Fix common/ includes.
 813         * parser-defs.h: Fix common/ includes.
 814         * osdata.c: Fix common/ includes.
 815         * obsd-nat.c: Fix common/ includes.
 816         * nat/x86-linux.c: Fix common/ includes.
 817         * nat/x86-linux-dregs.c: Fix common/ includes.
 818         * nat/x86-dregs.h: Fix common/ includes.
 819         * nat/x86-dregs.c: Fix common/ includes.
 820         * nat/ppc-linux.c: Fix common/ includes.
 821         * nat/mips-linux-watch.h: Fix common/ includes.
 822         * nat/mips-linux-watch.c: Fix common/ includes.
 823         * nat/linux-waitpid.c: Fix common/ includes.
 824         * nat/linux-ptrace.h: Fix common/ includes.
 825         * nat/linux-ptrace.c: Fix common/ includes.
 826         * nat/linux-procfs.c: Fix common/ includes.
 827         * nat/linux-personality.c: Fix common/ includes.
 828         * nat/linux-osdata.c: Fix common/ includes.
 829         * nat/linux-namespaces.c: Fix common/ includes.
 830         * nat/linux-btrace.h: Fix common/ includes.
 831         * nat/linux-btrace.c: Fix common/ includes.
 832         * nat/fork-inferior.c: Fix common/ includes.
 833         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 834         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 835         * nat/aarch64-linux.c: Fix common/ includes.
 836         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 837         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 838         * namespace.h: Fix common/ includes.
 839         * mips-linux-tdep.c: Fix common/ includes.
 840         * minsyms.c: Fix common/ includes.
 841         * mi/mi-parse.h: Fix common/ includes.
 842         * mi/mi-main.c: Fix common/ includes.
 843         * mi/mi-cmd-env.c: Fix common/ includes.
 844         * memrange.h: Fix common/ includes.
 845         * memattr.c: Fix common/ includes.
 846         * maint.h: Fix common/ includes.
 847         * maint.c: Fix common/ includes.
 848         * main.c: Fix common/ includes.
 849         * machoread.c: Fix common/ includes.
 850         * location.c: Fix common/ includes.
 851         * linux-thread-db.c: Fix common/ includes.
 852         * linux-nat.c: Fix common/ includes.
 853         * linux-fork.c: Fix common/ includes.
 854         * inline-frame.c: Fix common/ includes.
 855         * infrun.c: Fix common/ includes.
 856         * inflow.c: Fix common/ includes.
 857         * inferior.h: Fix common/ includes.
 858         * inferior.c: Fix common/ includes.
 859         * infcmd.c: Fix common/ includes.
 860         * inf-ptrace.c: Fix common/ includes.
 861         * inf-child.c: Fix common/ includes.
 862         * ia64-linux-nat.c: Fix common/ includes.
 863         * i387-tdep.c: Fix common/ includes.
 864         * i386-tdep.c: Fix common/ includes.
 865         * i386-linux-tdep.c: Fix common/ includes.
 866         * i386-linux-nat.c: Fix common/ includes.
 867         * i386-go32-tdep.c: Fix common/ includes.
 868         * i386-fbsd-tdep.c: Fix common/ includes.
 869         * i386-fbsd-nat.c: Fix common/ includes.
 870         * guile/scm-type.c: Fix common/ includes.
 871         * guile/guile.c: Fix common/ includes.
 872         * go32-nat.c: Fix common/ includes.
 873         * gnu-nat.c: Fix common/ includes.
 874         * gdbthread.h: Fix common/ includes.
 875         * gdbarch-selftests.c: Fix common/ includes.
 876         * gdb_usleep.c: Fix common/ includes.
 877         * gdb_select.h: Fix common/ includes.
 878         * gdb_bfd.c: Fix common/ includes.
 879         * gcore.c: Fix common/ includes.
 880         * fork-child.c: Fix common/ includes.
 881         * findvar.c: Fix common/ includes.
 882         * fbsd-nat.c: Fix common/ includes.
 883         * event-top.c: Fix common/ includes.
 884         * event-loop.c: Fix common/ includes.
 885         * dwarf2read.c: Fix common/ includes.
 886         * dwarf2loc.c: Fix common/ includes.
 887         * dwarf2-frame.c: Fix common/ includes.
 888         * dwarf-index-cache.c: Fix common/ includes.
 889         * dtrace-probe.c: Fix common/ includes.
 890         * disasm-selftests.c: Fix common/ includes.
 891         * defs.h: Fix common/ includes.
 892         * csky-tdep.c: Fix common/ includes.
 893         * cp-valprint.c: Fix common/ includes.
 894         * cp-support.h: Fix common/ includes.
 895         * cp-support.c: Fix common/ includes.
 896         * corelow.c: Fix common/ includes.
 897         * completer.h: Fix common/ includes.
 898         * completer.c: Fix common/ includes.
 899         * compile/compile.c: Fix common/ includes.
 900         * compile/compile-loc2c.c: Fix common/ includes.
 901         * compile/compile-cplus-types.c: Fix common/ includes.
 902         * compile/compile-cplus-symbols.c: Fix common/ includes.
 903         * command.h: Fix common/ includes.
 904         * cli/cli-dump.c: Fix common/ includes.
 905         * cli/cli-cmds.c: Fix common/ includes.
 906         * charset.c: Fix common/ includes.
 907         * build-id.c: Fix common/ includes.
 908         * btrace.h: Fix common/ includes.
 909         * btrace.c: Fix common/ includes.
 910         * breakpoint.h: Fix common/ includes.
 911         * breakpoint.c: Fix common/ includes.
 912         * ax.h:
 913         (enum agent_op): Fix common/ includes.
 914         * ax-general.c (struct aop_map): Fix common/ includes.
 915         * ax-gdb.c: Fix common/ includes.
 916         * auxv.c: Fix common/ includes.
 917         * auto-load.c: Fix common/ includes.
 918         * arm-tdep.c: Fix common/ includes.
 919         * arch/riscv.c: Fix common/ includes.
 920         * arch/ppc-linux-common.c: Fix common/ includes.
 921         * arch/i386.c: Fix common/ includes.
 922         * arch/arm.c: Fix common/ includes.
 923         * arch/arm-linux.c: Fix common/ includes.
 924         * arch/arm-get-next-pcs.c: Fix common/ includes.
 925         * arch/amd64.c: Fix common/ includes.
 926         * arch/aarch64.c: Fix common/ includes.
 927         * arch/aarch64-insn.c: Fix common/ includes.
 928         * arch-utils.c: Fix common/ includes.
 929         * amd64-windows-tdep.c: Fix common/ includes.
 930         * amd64-tdep.c: Fix common/ includes.
 931         * amd64-sol2-tdep.c: Fix common/ includes.
 932         * amd64-obsd-tdep.c: Fix common/ includes.
 933         * amd64-nbsd-tdep.c: Fix common/ includes.
 934         * amd64-linux-tdep.c: Fix common/ includes.
 935         * amd64-linux-nat.c: Fix common/ includes.
 936         * amd64-fbsd-tdep.c: Fix common/ includes.
 937         * amd64-fbsd-nat.c: Fix common/ includes.
 938         * amd64-dicos-tdep.c: Fix common/ includes.
 939         * amd64-darwin-tdep.c: Fix common/ includes.
 940         * agent.c: Fix common/ includes.
 941         * ada-lang.h: Fix common/ includes.
 942         * ada-lang.c: Fix common/ includes.
 943         * aarch64-tdep.c: Fix common/ includes.
 944
 945 2019-01-25  Tom Tromey  <tom@tromey.com>
 946
 947         * common/create-version.sh: Use common/version.h.
 948
 949 2019-01-24  Pedro Alves  <palves@redhat.com>
 950
 951         * infrun.c (signal_stop, signal_print, signal_program)
 952         (signal_catch, signal_pass): Now arrays instead of pointers.
 953         (update_signals_program_target, do_target_resume)
 954         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 955         * linux-nat.c (linux_nat_target::pass_signals)
 956         (linux_nat_target::create_inferior, linux_nat_target::attach):
 957         Adjust.
 958         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 959         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 960         * procfs.c (procfs_target::pass_signals): Adjust.
 961         * record-full.c (record_full_target::resume): Adjust.
 962         * remote.c (remote_target::pass_signals)
 963         (remote_target::program_signals): Adjust.
 964         * target-debug.h (target_debug_print_signals): Now takes a
 965         gdb::array_view as parameter.  Adjust.
 966         * target.h (target_ops) <pass_signals, program_signals>: Replace
 967         pointer and length parameters with gdb::array_view.
 968         (target_pass_signals, target_program_signals): Likewise.
 969         * target-delegates.c: Regenerate.
 970
 971 2019-01-24  Pedro Alves  <palves@redhat.com>
 972
 973         * common/forward-scope-exit.h
 974         (forward_scope_exit::forward_scope_exit): Pass arguments to
 975         m_bind_function directly, instead of creating a std::bind and
 976         copying that.
 977
 978 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 979
 980         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 981         for static members.
 982         (pass_in_v_vfp_candidate): Likewise.
 983
 984 2019-01-23  Tom Tromey  <tom@tromey.com>
 985             Pedro Alves  <palves@redhat.com>
 986
 987         * regcache.c (class regcache_invalidator): Remove.
 988         (regcache::raw_write): Use make_scope_exit.
 989
 990 2019-01-23  Tom Tromey  <tom@tromey.com>
 991
 992         * ui-out.h (class ui_out_emit_type): Update comment.
 993
 994 2019-01-23  Tom Tromey  <tom@tromey.com>
 995
 996         * infrun.c (fetch_inferior_event): Update comment.
 997
 998 2019-01-23  Tom Tromey  <tom@tromey.com>
 999             Pedro Alves  <palves@redhat.com>
1000
1001         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1002         parameter.
1003         (fetch_inferior_event): Use SCOPE_EXIT.
1004
1005
1006 2019-01-23  Tom Tromey  <tom@tromey.com>
1007             Pedro Alves  <palves@redhat.com>
1008
1009         * infrun.c (disable_thread_events): Delete.
1010         (stop_all_threads): Use SCOPE_EXIT.
1011
1012 2019-01-23  Tom Tromey  <tom@tromey.com>
1013             Pedro Alves  <palves@redhat.com>
1014
1015         * symfile.c: Include forward-scope-exit.h.
1016         (clear_symtab_users_cleanup): Replace forward declaration with
1017         a FORWARD_SCOPE_EXIT.
1018         (syms_from_objfile_1): Use the forward_scope_exit and
1019         gdb::optional instead of cleanup_function.
1020         (reread_symbols): Use the forward_scope_exit instead of
1021         cleanup_function.
1022         (clear_symtab_users_cleanup): Remove function.
1023
1024 2019-01-23  Tom Tromey  <tom@tromey.com>
1025             Pedro Alves  <palves@redhat.com>
1026
1027         * linux-nat.c: Include scope-exit.h.
1028         (cleanup_target_stop): Remove.
1029         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1030         SCOPE_EXIT.
1031
1032 2019-01-23  Tom Tromey  <tom@tromey.com>
1033             Pedro Alves  <palves@redhat.com>
1034
1035         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1036         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1037
1038 2019-01-23  Tom Tromey  <tom@tromey.com>
1039             Andrew Burgess  <andrew.burgess@embecosm.com>
1040             Pedro Alves  <palves@redhat.com>
1041
1042         * infrun.c (fetch_inferior_event): Use scope_exit.
1043         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1044         * top.c (execute_command): Use scope_exit.
1045         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1046         * utils.c (do_bpstat_clear_actions_cleanup)
1047         (make_bpstat_clear_actions_cleanup): Remove.
1048
1049 2019-01-23  Tom Tromey  <tom@tromey.com>
1050             Pedro Alves  <palves@redhat.com>
1051
1052         * infrun.c: Include "common/scope-exit.h"
1053         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1054         (wait_for_inferior): Use SCOPE_EXIT.
1055         (fetch_inferior_event): Use scope_exit.
1056
1057 2019-01-23  Tom Tromey  <tom@tromey.com>
1058             Pedro Alves  <palves@redhat.com>
1059
1060         * breakpoint.c (create_breakpoint): Remove cleanup.
1061
1062 2019-01-23  Tom Tromey  <tom@tromey.com>
1063             Andrew Burgess  <andrew.burgess@embecosm.com>
1064             Pedro Alves  <palves@redhat.com>
1065
1066 2019-01-23  Pedro Alves  <palves@redhat.com>
1067
1068         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1069
1070 2019-01-23  Pedro Alves  <palves@redhat.com>
1071             Andrew Burgess  <andrew.burgess@embecosm.com>
1072
1073         * gdbthread.h: Include "common/forward-scope-exit.h".
1074         (scoped_finish_thread_state): Redefine custom class in terms of
1075         forward_scope_exit.
1076
1077 2019-01-23  Pedro Alves  <palves@redhat.com>
1078             Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * common/forward-scope-exit.h: New file.
1081
1082 2019-01-23  Pedro Alves  <palves@redhat.com>
1083             Andrew Burgess  <andrew.burgess@embecosm.com>
1084             Tom Tromey  <tom@tromey.com>
1085
1086         * common/scope-exit.h: New file.
1087
1088 2019-01-23  Pedro Alves  <palves@redhat.com>
1089
1090         * common/preprocessor.h (ESC): Rename to ...
1091         (ESC_PARENS): ... this.
1092         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1093         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1094
1095 2019-01-23  Tom Tromey  <tom@tromey.com>
1096
1097         * language.h (class scoped_switch_to_sym_language_if_auto):
1098         Initialize m_lang in both cases.
1099
1100 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1101
1102         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1103         with XCNEW.
1104
1105 2019-01-22  Tom Tromey  <tom@tromey.com>
1106
1107         * corelow.c: Do not include sys/file.h.
1108
1109 2019-01-22  Tom Tromey  <tom@tromey.com>
1110
1111         * tui/tui-wingeneral.h: Include gdb_curses.h.
1112
1113 2019-01-22  Tom Tromey  <tom@tromey.com>
1114
1115         * source-cache.h (class source_cache) <get_source_lines,
1116         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1117
1118 2019-01-22  Tom Tromey  <tom@tromey.com>
1119
1120         * remote-fileio.h (struct remote_target): Declare.
1121
1122 2019-01-22  Tom Tromey  <tom@tromey.com>
1123
1124         * python/py-arch.c: Do not include py-ref.h.
1125         * python/py-bpevent.c: Do not include py-ref.h.
1126         * python/py-cmd.c: Do not include py-ref.h.
1127         * python/py-continueevent.c: Do not include py-ref.h.
1128         * python/py-event.h: Do not include py-ref.h.
1129         * python/py-evtregistry.c: Do not include py-ref.h.
1130         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1131         * python/py-frame.c: Do not include py-ref.h.
1132         * python/py-framefilter.c: Do not include py-ref.h.
1133         * python/py-function.c: Do not include py-ref.h.
1134         * python/py-infevents.c: Do not include py-ref.h.
1135         * python/py-linetable.c: Do not include py-ref.h.
1136         * python/py-objfile.c: Do not include py-ref.h.
1137         * python/py-param.c: Do not include py-ref.h.
1138         * python/py-prettyprint.c: Do not include py-ref.h.
1139         * python/py-progspace.c: Do not include py-ref.h.
1140         * python/py-symbol.c: Do not include py-ref.h.
1141         * python/py-symtab.c: Do not include py-ref.h.
1142         * python/py-type.c: Do not include py-ref.h.
1143         * python/py-unwind.c: Do not include py-ref.h.
1144         * python/py-utils.c: Do not include py-ref.h.
1145         * python/py-value.c: Do not include py-ref.h.
1146         * python/py-varobj.c: Do not include py-ref.h.
1147         * python/py-xmethods.c: Do not include py-ref.h.
1148         * python/python.c: Do not include py-ref.h.
1149         * varobj.c: Do not include py-ref.h.
1150
1151 2019-01-22  Tom Tromey  <tom@tromey.com>
1152
1153         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1154         keyword for bcache.
1155
1156 2019-01-22  Tom Tromey  <tom@tromey.com>
1157
1158         * compile/compile-cplus-types.c: Remove a comment by #include.
1159
1160 2019-01-22  Tom Tromey  <tom@tromey.com>
1161
1162         * compile/gcc-c-plugin.h: Include compile-internal.h.
1163
1164 2019-01-22  Tom Tromey  <tom@tromey.com>
1165
1166         * stabsread.c (EXTERN): Do not define.
1167         (symnum, next_symbol_text_func, processing_gcc_compilation)
1168         (within_function, global_sym_chain, global_stabs)
1169         (previous_stab_code, this_object_header_files)
1170         (n_this_object_header_files)
1171         (n_allocated_this_object_header_files): Define.
1172         * stabsread.h (EXTERN): Never define.  Use "extern".
1173
1174 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1175
1176         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1177         history_value.
1178
1179 2019-01-21  Tom Tromey  <tom@tromey.com>
1180
1181         * ui-out.c: Fix includes.
1182         * tui/tui-source.c: Fix includes.
1183         * target.c: Fix includes.
1184         * remote.c: Fix includes.
1185         * regcache.c: Fix includes.
1186         * python/py-block.c: Fix includes.
1187         * printcmd.c: Fix includes.
1188         * or1k-tdep.c: Fix includes.
1189         * mi/mi-main.c: Fix includes.
1190         * m32r-tdep.c: Fix includes.
1191         * csky-tdep.c: Fix includes.
1192         * compile/compile-cplus-types.c: Fix includes.
1193         * cli/cli-interp.c: Fix includes.
1194
1195 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1196
1197         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1198         for padding.
1199
1200 2019-01-16  Tom Tromey  <tom@tromey.com>
1201
1202         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1203         earlier.
1204         (struct objfile) <msymbols_range>: Move from top level.
1205         <msymbols>: New method.
1206         (class objfile_msymbols): Remove.
1207         * symtab.c (default_collect_symbol_completion_matches_break_on):
1208         Update.
1209         * symmisc.c (dump_msymbols): Update.
1210         * stabsread.c (scan_file_globals): Update.
1211         * objc-lang.c (info_selectors_command, info_classes_command)
1212         (find_methods): Update.
1213         * minsyms.c (find_solib_trampoline_target): Update.
1214         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1215         * coffread.c (coff_symfile_read): Update.
1216         * ada-lang.c (ada_lookup_simple_minsym)
1217         (ada_collect_symbol_completion_matches): Update.
1218
1219 2019-01-16  Tom Tromey  <tom@tromey.com>
1220
1221         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1222         type.  Remove no-argument constructor.
1223         <iterator::operator++>: Simplify.
1224         <begin>: Update.
1225         <end>: Use minimal_symbol_count.
1226
1227 2019-01-16  Tom Tromey  <tom@tromey.com>
1228
1229         * objfiles.h (struct objfile) <psymtabs>: New method.
1230         (class objfile_psymtabs): Remove.
1231         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1232         typedef.
1233         <range>: New method.
1234         (require_partial_symbols): Change return type.
1235         * psymtab.c (require_partial_symbols)
1236         (psym_expand_symtabs_matching): Update.
1237         * mdebugread.c (parse_partial_symbols): Update.
1238         * dbxread.c (dbx_end_psymtab): Update.
1239
1240 2019-01-15  Tom Tromey  <tom@tromey.com>
1241
1242         * symtab.c (lookup_objfile_from_block)
1243         (lookup_symbol_in_objfile_symtabs)
1244         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1245         (find_line_symtab, info_sources_command)
1246         (default_collect_symbol_completion_matches_break_on)
1247         (make_source_files_completion_list): Update.
1248         * symmisc.c (print_objfile_statistics, dump_objfile)
1249         (maintenance_print_symbols, maintenance_info_symtabs)
1250         (maintenance_check_symtabs, maintenance_info_line_tables):
1251         Update.
1252         * source.c (select_source_symtab)
1253         (forget_cached_source_info_for_objfile): Update.
1254         * objfiles.h (class objfile_compunits): Remove.
1255         (struct objfile) <compunits_range>: New typedef.
1256         (compunits): New method.
1257         * objfiles.c (objfile_relocate1): Update.
1258         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1259         * maint.c (count_symtabs_and_blocks): Update.
1260         * linespec.c (iterate_over_all_matching_symtabs): Update.
1261         * cp-support.c (add_symbol_overload_list_qualified): Update.
1262         * coffread.c (coff_symtab_read): Update.
1263         * ada-lang.c (add_nonlocal_symbols)
1264         (ada_collect_symbol_completion_matches)
1265         (ada_add_global_exceptions): Update.
1266
1267 2019-01-15  Tom Tromey  <tom@tromey.com>
1268
1269         * progspace.h (program_space) <objfiles_safe_range>: New
1270         typedef.
1271         <objfiles_safe>: New method.
1272         * objfiles.h (class all_objfiles_safe): Remove.
1273         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1274         * jit.c (jit_inferior_exit_hook): Update.
1275
1276 2019-01-17  Tom Tromey  <tom@tromey.com>
1277
1278         * progspace.h (program_space) <objfiles_range>: New typedef.
1279         <objfiles>: New method.
1280         <objfiles_head>: Rename from objfiles.
1281         (object_files): Update.
1282         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1283         * guile/scm-pretty-print.c
1284         (ppscm_find_pretty_printer_from_objfiles): Update.
1285         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1286         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1287         Update.
1288         * python/py-progspace.c (pspy_get_objfiles): Update.
1289         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1290         Update.
1291         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1292         (objfpy_lookup_objfile_by_build_id): Update.
1293         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1294         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1295         Update.
1296         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1297         (expand_symtab_containing_pc, lookup_objfile_from_block)
1298         (lookup_static_symbol, basic_lookup_transparent_type)
1299         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1300         (find_line_symtab, info_sources_command)
1301         (default_collect_symbol_completion_matches_break_on)
1302         (make_source_files_completion_list, find_main_name): Update.
1303         * symmisc.c (print_symbol_bcache_statistics)
1304         (print_objfile_statistics, maintenance_print_symbols)
1305         (maintenance_print_msymbols, maintenance_print_objfiles)
1306         (maintenance_info_symtabs, maintenance_check_symtabs)
1307         (maintenance_expand_symtabs, maintenance_info_line_tables):
1308         Update.
1309         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1310         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1311         (map_overlay_command, unmap_overlay_command)
1312         (simple_overlay_update, expand_symtabs_matching)
1313         (map_symbol_filenames): Update.
1314         * symfile-debug.c (set_debug_symfile): Update.
1315         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1316         Update.
1317         * source.c (select_source_symtab, forget_cached_source_info):
1318         Update.
1319         * solib.c (solib_read_symbols): Update.
1320         * solib-spu.c (append_ocl_sos): Update.
1321         * psymtab.c (maintenance_print_psymbols)
1322         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1323         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1324         * printcmd.c (info_symbol_command): Update.
1325         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1326         Update.
1327         * objfiles.h (class all_objfiles): Remove.
1328         * objfiles.c (have_partial_symbols, have_full_symbols)
1329         (have_minimal_symbols, qsort_cmp, update_section_map)
1330         (shared_objfile_contains_address_p)
1331         (default_iterate_over_objfiles_in_search_order): Update.
1332         * objc-lang.c (info_selectors_command, info_classes_command)
1333         (find_methods): Update.
1334         * minsyms.c (find_solib_trampoline_target): Update.
1335         * maint.c (maintenance_info_sections)
1336         (maintenance_translate_address, count_symtabs_and_blocks):
1337         Update.
1338         * main.c (captured_main_1): Update.
1339         * linux-thread-db.c (try_thread_db_load_from_pdir)
1340         (has_libpthread): Update.
1341         * linespec.c (iterate_over_all_matching_symtabs)
1342         (search_minsyms_for_name): Update.
1343         * jit.c (jit_find_objf_with_entry_addr): Update.
1344         * hppa-tdep.c (find_unwind_entry)
1345         (hppa_lookup_stub_minimal_symbol): Update.
1346         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1347         Update.
1348         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1349         (elf_gnu_ifunc_resolve_by_got): Update.
1350         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1351         * dwarf-index-write.c (save_gdb_index_command): Update.
1352         * cp-support.c (add_symbol_overload_list_qualified): Update.
1353         * breakpoint.c (create_overlay_event_breakpoint)
1354         (create_longjmp_master_breakpoint)
1355         (create_std_terminate_master_breakpoint)
1356         (create_exception_master_breakpoint): Update.
1357         * blockframe.c (find_pc_partial_function): Update.
1358         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1359         (ada_collect_symbol_completion_matches)
1360         (ada_add_global_exceptions): Update.
1361
1362 2019-01-17  Tom Tromey  <tom@tromey.com>
1363
1364         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1365         declare VEC.
1366         (solib_target_parse_libraries): Change return type.
1367         (library_list_start_segment, library_list_start_section)
1368         (library_list_end_library, library_list_start_library); Update.
1369         (solib_target_free_library_list): Remove.
1370         (solib_target_parse_libraries): Remove cleanup.  Change return
1371         type.
1372         (solib_target_current_sos): Update.
1373
1374 2019-01-17  Tom Tromey  <tromey@bapiya>
1375
1376         * valprint.c: Replace "the the" with "the".
1377         * symtab.c: Replace "the the" with "the".
1378         * solib.c: Replace "the the" with "the".
1379         * solib-dsbt.c: Replace "the the" with "the".
1380         * linespec.c: Replace "the the" with "the".
1381         * dwarf2loc.h: Replace "the the" with "the".
1382         * amd64-windows-tdep.c: Replace "the the" with "the".
1383         * aarch64-tdep.c: Replace "the the" with "the".
1384
1385 2019-01-16  Keith Seitz  <keiths@redhat.com>
1386
1387         PR gdb/23773
1388         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1389         <builder>: Rename to ..
1390         <m_builder>: ... this and make private.
1391         (dwarf2_cu::get_builder): New method.  Change all users of
1392         `builder' to use this method.
1393         (dwarf2_start_symtab): Move to ...
1394         (dwarf2_cu::start_symtab): ... here.  Update all callers
1395         (setup_type_unit_groups): Move to ...
1396         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1397         callers.
1398         (dwarf2_cu::reset_builder): New method.
1399         (process_full_compunit, process_full_type_unit): Use
1400         dwarf2_cu::reset_builder.
1401         (follow_die_offset): Record the ancestor CU if it is different
1402         from the followed DIE's CU.
1403         (follow_die_sig_1): Likewise.
1404
1405 2019-01-15  Tom Tromey  <tom@tromey.com>
1406
1407         * remote.c (class remote_state) <buf>: Now a char_vector.
1408         <buf_size>: Remove.
1409         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1410         parameter.
1411         (remote_target::getpkt_or_notif_sane_1)
1412         (remote_target::getpkt_sane)
1413         (remote_target::getpkt_or_notif_sane): Likewise.
1414         (class remote_target) <putpkt>: New overload.
1415         (remote_target::read_frame): Change type of "buf_p".  Remove
1416         sizeof_p parameter.
1417         (packet_ok): New overload.
1418         (packet_check_result): New overload.
1419         Update all uses.
1420
1421 2019-01-14  Tom Tromey  <tom@tromey.com>
1422
1423         * remote-notif.c (handle_notification, remote_notif_ack)
1424         (remote_notif_parse): Make "buf" const.
1425         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1426         const.
1427         (remote_notif_parse, remote_notif_ack, handle_notification):
1428         Likewise.
1429         * remote.c (remote_notif_stop_parse): Make "buf" const.
1430         (remote_target::remote_parse_stop_reply): Make "buf" const.
1431         (remote_notif_stop_ack): Make "buf" const.
1432
1433 2019-01-14  Tom Tromey  <tom@tromey.com>
1434
1435         * remote.c (remote_console_output): Make parameter const.
1436
1437 2019-01-14  Tom Tromey  <tom@tromey.com>
1438
1439         * target-debug.h (target_debug_print_signals): Constify.
1440         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1441         * procfs.c (procfs_target::pass_signals): Update.
1442         * linux-nat.c (linux_nat_target::pass_signals): Update.
1443         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1444         * target-delegates.c: Rebuild.
1445         * remote.c (remote_target::program_signals): Update.
1446         (remote_target::pass_signals): Update.
1447         * target.c (target_pass_signals): Constify argument.
1448         (target_program_signals): Likewise.
1449         * target.h (struct target_ops) <pass_signals, program_signals>:
1450         Constify argument.
1451         (target_pass_signals, target_program_signals): Constify argument.
1452
1453 2019-01-14  Tom Tromey  <tom@tromey.com>
1454
1455         PR tui/28819:
1456         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1457
1458 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1459
1460         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1461         field.
1462         * rs6000-tdep.c: Include reggroups.h.
1463         (IS_V_ALIAS_PSEUDOREG): Define.
1464         (rs6000_register_name): Return names for the "vX" aliases.
1465         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1466         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1467         aliases.  Call default_register_reggroup_p for all other
1468         pseudo-registers.
1469         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1470         New functions.
1471         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1472         Handle "vX" aliases.
1473         (v_alias_pseudo_register_collect): New function.
1474         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1475         (rs6000_gdbarch_init): Initialize "vX" aliases as
1476         pseudo-registers.  Restore registration of
1477         rs6000_pseudo_register_reggroup_p with
1478         set_tdesc_pseudo_register_reggroup_p.
1479
1480 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1481
1482         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1483         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1484         set_gdbarch_num_pseudo_regs.
1485
1486 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1487
1488         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1489         Remove arg prefixname, add do_set and do_show.
1490         Add member functions set_list and show_list.
1491         * cli/cli-style.c (class cli_style_option): Update accordingly.
1492         (style_set_list): Move to file scope.
1493         (style_show_list): Likewise.
1494         (set_style): Call help_list.
1495         (show_style): Call cmd_show_list.
1496         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1497         Update to use the new macro.
1498
1499 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1500
1501         * ada-lang.c (_initialize_ada_language): Expand the help text
1502         for the "catch exception" command.
1503
1504 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1505
1506         * symtab.c (matching_obj_sections): Initialize obj,
1507         declare it closer to its usage.
1508
1509 2019-01-10  Tom Tromey  <tom@tromey.com>
1510
1511         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1512         (basic_inf_threads_range): Remove.
1513         (inf_threads_range, inf_non_exited_threads_range)
1514         (safe_inf_threads_range): Use next_adapter.
1515
1516 2019-01-10  Keith Seitz  <keiths@redhat.com>
1517
1518         PR gdb/23712
1519         PR symtab/23010
1520         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1521         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1522
1523 2019-01-10  Keith Seitz  <keiths@redhat.com>
1524
1525         PR gdb/23712
1526         PR symtab/23010
1527         * dictionary.c (pending_to_vector): Remove.
1528         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1529         Remove _1 suffix, replacing functions of the same name.  Update
1530         all callers.
1531         (dict_create_hashed, dict_create_hashed_expandable)
1532         (dict_create_linear, dict_create_linear_expandable, dict_free)
1533         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1534         Make functions static.
1535
1536 2019-01-10  Keith Seitz  <keiths@redhat.com>
1537
1538         PR gdb/23712
1539         PR symtab/23010
1540         * dictionary.h (struct dictionary): Replace declaration with
1541         multidictionary.
1542         (dict_create_hashed, dict_create_hashed_expandable)
1543         (dict_create_linear, dict_create_linear_expandable)
1544         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1545         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1546         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1547         taking multidictionary argument.
1548         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1549         * block.h (struct block) <dict>: Change to multidictionary
1550         and rename `multidict'.
1551         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1552         symmisc.c: Update all dictionary references to multidictionary.
1553
1554 2019-01-10  Keith Seitz  <keiths@redhat.com>
1555
1556         PR gdb/23712
1557         PR symtab/23010
1558         * dictionary.c: Include unordered_map.
1559         (pending_to_vector): New function.
1560         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1561         Rewrite the non-"_1" functions to take vector instead
1562         of linked list.
1563         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1564         "new" _1 versions of the same name.
1565         (multidictionary): Define.
1566         (std::hash<enum language): New definition.
1567         (collate_pending_symbols_by_language, mdict_create_hashed)
1568         (mdict_create_hashed_expandable, mdict_create_linear)
1569         (mdict_create_linear_expandable, mdict_free)
1570         (find_language_dictionary, create_new_language_dictionary)
1571         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1572         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1573         (mdict_size, mdict_empty): New functions.
1574         * dictionary.h (mdict_iterator): Define.
1575
1576 2019-01-10  Pedro Alves  <palves@redhat.com>
1577
1578         * breakpoint.c (read_uploaded_action)
1579         (create_tracepoint_from_upload): Adjust to use
1580         gdb::unique_xmalloc_ptr.
1581         * ctf.c (ctf_write_uploaded_tp):
1582         (SET_ARRAY_FIELD): Use emplace_back.
1583         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1584         * tracefile-tfile.c (tfile_write_uploaded_tp):
1585         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1586         gdb::unique_xmalloc_ptr.
1587         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1588         at_string, cond_string, cmd_strings>: Replace char pointers
1589         with gdb::unique_xmalloc_ptr.
1590
1591 2019-01-10  Pedro Alves  <palves@redhat.com>
1592
1593         * solib-target.c (library_list_start_library): Don't xstrdup name.
1594
1595 2019-01-10  Pedro Alves  <palves@redhat.com>
1596
1597         * mdebugread.c (parse_partial_symbols): Use
1598         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1599
1600 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1601
1602         * linux-fork.c (scoped_switch_fork_info)
1603         <~scoped_switch_fork_info>: Fix incorrect variable name.
1604
1605 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1606
1607         * linux-fork.c (scoped_switch_fork_info)
1608         <scoped_switch_fork_info>: Make explicit.
1609         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1610
1611 2019-01-10  Tom Tromey  <tom@tromey.com>
1612
1613         * objfiles.h (objfile::reset_psymtabs): Update.
1614         * objfiles.c (objfile::objfile): Update.
1615         * psymtab.h (psymtab_storage::obstack): Update.
1616         (psymtab_storage::m_obstack): Use gdb::optional.
1617         (class psymtab_storage): Update comment.  Remove objfile
1618         parameter.
1619         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1620
1621 2019-01-10  Tom Tromey  <tom@tromey.com>
1622
1623         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1624         <free_psymtabs>: Now private.
1625         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1626         (allocate_psymtab): Use new method.
1627
1628 2019-01-10  Tom Tromey  <tom@tromey.com>
1629
1630         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1631         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1632         * mdebugread.c (parse_partial_symbols): Use
1633         allocate_dependencies.
1634         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1635         allocate_dependencies.
1636         (process_psymtab_comp_unit_reader)
1637         (build_type_psymtab_dependencies): Likewise.
1638         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1639
1640 2019-01-10  Tom Tromey  <tom@tromey.com>
1641
1642         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1643         PSYMBOL_SET_LANGUAGE.
1644         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1645
1646 2019-01-10  Tom Tromey  <tom@tromey.com>
1647
1648         * psymtab.h (psymtab_storage::obstack): New method.
1649         <m_obstack>: Rename from obstack; now private.
1650         * psymtab.c (psymtab_storage): Update.
1651         * dwarf2read.c (create_addrmap_from_index)
1652         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1653         Update.
1654
1655 2019-01-10  Tom Tromey  <tom@tromey.com>
1656
1657         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1658         * objfiles.h (objfile::reset_psymtabs): New method.
1659
1660 2019-01-10  Tom Tromey  <tom@tromey.com>
1661
1662         * symmisc.c (print_symbol_bcache_statistics): Update.
1663         (print_objfile_statistics): Update.
1664         * symfile.c (reread_symbols): Update.
1665         * psymtab.h (class psymtab_storage): New.
1666         * psymtab.c (psymtab_storage): New constructor.
1667         (~psymtab_storage): New destructor.
1668         (require_partial_symbols): Update.
1669         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1670         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1671         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1672         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1673         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1674         (start_psymtab_common, end_psymtab_common)
1675         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1676         (allocate_psymtab): Update.
1677         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1678         Update.
1679         (dump_psymtab_addrmap, maintenance_print_psymbols)
1680         (maintenance_check_psymtabs): Update.
1681         (class objfile_psymtabs): Move to objfiles.h.
1682         * psympriv.h (discard_psymtab): Now inline.
1683         (psymtab_discarder::psymtab_discarder): Update.
1684         (psymtab_discarder::~psymtab_discarder): Update.
1685         (ALL_OBJFILE_PSYMTABS): Rewrite.
1686         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1687         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1688         Remove fields.
1689         <partial_symtabs>: New field.
1690         (class objfile_psymtabs): Move from psymtab.h.  Update.
1691         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1692         psymbol_cache.
1693         (objfile::~objfile): Don't destroy psymbol_cache.
1694         * mdebugread.c (parse_partial_symbols): Update.
1695         * dwarf2read.c (create_addrmap_from_index)
1696         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1697         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1698         (add_partial_subprogram, dwarf2_ranges_read): Update.
1699         * dwarf-index-write.c (write_address_map)
1700         (write_one_signatured_type, recursively_write_psymbols)
1701         (class debug_names, class debug_names, write_psymtabs_to_index):
1702         Update.
1703
1704 2019-01-10  Tom Tromey  <tom@tromey.com>
1705
1706         * symtab.h (SYMBOL_SET_NAMES): Update.
1707         (symbol_set_names): Update.
1708         (MSYMBOL_SET_NAMES): Update.
1709         * symtab.c (symbol_set_names): Change argument to be an
1710         objfile_per_bfd_storage.
1711         * psymtab.c (add_psymbol_to_bcache): Update.
1712         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1713
1714 2019-01-10  Tom Tromey  <tom@tromey.com>
1715
1716         * symtab.c (create_demangled_names_hash): Change argument to be an
1717         objfile_per_bfd_storage.
1718         (symbol_set_names): Update.
1719
1720 2019-01-10  Tom Tromey  <tom@tromey.com>
1721
1722         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1723         init_psymbol_list.
1724         * psymtab.c (init_psymbol_list): Do nothing if already called.
1725         * psympriv.h (init_psymbol_list): Add comment.
1726         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1727         init_psymbol_list.
1728         * dbxread.c (dbx_symfile_read): Unconditionally call
1729         init_psymbol_list.
1730
1731 2019-01-10  Tom Tromey  <tom@tromey.com>
1732
1733         * xcoffread.c (scan_xcoff_symtab): Update.
1734         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1735         "where".
1736         * mdebugread.c (parse_partial_symbols)
1737         (handle_psymbol_enumerators): Update.
1738         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1739         * dbxread.c (read_dbx_symtab): Update.
1740         * psympriv.h (psymbol_placement): New enum.
1741         (add_psymbol_to_list): Update.
1742
1743 2019-01-10  Tom Tromey  <tom@tromey.com>
1744
1745         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1746         static_psymbols parameters.
1747         (scan_xcoff_symtab): Update.
1748         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1749         static_psymbols parameters.
1750         * psympriv.h (start_psymtab_common): Update.
1751         * mdebugread.c (parse_partial_symbols): Update.
1752         * dwarf2read.c (create_partial_symtab): Update.
1753         * dbxread.c (read_dbx_symtab): Update.
1754         (start_psymtab): Remove global_psymbols and static_psymbols
1755         parameters.
1756
1757 2019-01-10  Tom Tromey  <tom@tromey.com>
1758
1759         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1760         * psymtab.c (allocate_psymtab): Add comment.
1761         * psympriv.h (allocate_psymtab): Add comment.
1762         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1763         initializations.
1764         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1765
1766 2019-01-10  Tom Tromey  <tom@tromey.com>
1767
1768         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1769         Don't declare.
1770         * mipsread.c: Include mdebugread.h.
1771         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1772         Declare.
1773         * elfread.c: Include mdebugread.h.
1774
1775 2019-01-09  Tom Tromey  <tom@tromey.com>
1776
1777         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1778         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1779         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1780         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1781         (psym_lookup_symbol, psym_find_last_source_symtab)
1782         (psym_forget_cached_source_info, psym_print_stats)
1783         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1784         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1785         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1786         (psym_find_compunit_symtab_by_address)
1787         (maintenance_print_psymbols, maintenance_info_psymtabs)
1788         (maintenance_check_psymtabs): Use ranged for.
1789         * psymtab.h (class objfile_psymtabs): New.
1790         (require_partial_symbols): Return objfile_psymtabs.
1791         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1792
1793 2019-01-09  Tom Tromey  <tom@tromey.com>
1794
1795         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1796         (find_pc_mapped_section, list_overlays_command)
1797         (map_overlay_command, unmap_overlay_command)
1798         (simple_overlay_update): Use all_objfiles.
1799         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1800         * printcmd.c (info_symbol_command): Use all_objfiles.
1801         * objfiles.h (ALL_OBJSECTIONS): Remove.
1802         * maint.c (maintenance_translate_address): Use all_objfiles.
1803         * gcore.c (gcore_create_callback): Use all_objfiles.
1804         (objfile_find_memory_regions): Likewise.
1805
1806 2019-01-09  Tom Tromey  <tom@tromey.com>
1807
1808         * symtab.c (find_line_symtab, info_sources_command)
1809         (make_source_files_completion_list): Use objfile_compunits.
1810         * source.c (select_source_symtab): Use objfile_compunits.
1811         * objfiles.h (struct objfile): Update comment.
1812         (ALL_OBJFILES): Remove.
1813         (ALL_FILETABS): Remove.
1814         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1815         objfile_compunits.
1816
1817 2019-01-09  Tom Tromey  <tom@tromey.com>
1818
1819         * symmisc.c (print_objfile_statistics, dump_objfile)
1820         (maintenance_print_symbols): Use compunit_filetabs.
1821         * source.c (forget_cached_source_info_for_objfile): Use
1822         compunit_filetabs.
1823         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1824         (ALL_FILETABS): Use compunit_filetabs.
1825         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1826         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1827
1828 2019-01-09  Tom Tromey  <tom@tromey.com>
1829
1830         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1831         (compunit_filetabs): New.
1832         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1833         compunit_filetabs.
1834         (info_sources_command, make_source_files_completion_list): Remove
1835         declaration.
1836         * symmisc.c (print_objfile_statistics, dump_objfile)
1837         (maintenance_print_symbols): Remove declaration.
1838         (maintenance_info_symtabs): Use compunit_filetabs.
1839         (maintenance_info_line_tables): Likewise.
1840         * source.c (select_source_symtab): Change local variable name.
1841         (forget_cached_source_info_for_objfile): Remove declaration.
1842         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1843         * objfiles.c (objfile_relocate1): Remove declaration.
1844         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1845         declaration.
1846         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1847         * coffread.c (coff_symtab_read): Remove declaration.
1848         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1849         compunit_filetabs.
1850
1851 2019-01-09  Tom Tromey  <tom@tromey.com>
1852
1853         * symtab.c (lookup_objfile_from_block)
1854         (find_pc_sect_compunit_symtab, search_symbols)
1855         (default_collect_symbol_completion_matches_break_on): Use
1856         objfile_compunits.
1857         * objfiles.h (ALL_COMPUNITS): Remove.
1858         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1859         * cp-support.c (add_symbol_overload_list_qualified): Use
1860         objfile_compunits.
1861         * ada-lang.c (ada_collect_symbol_completion_matches)
1862         (ada_add_global_exceptions): Use objfile_compunits.
1863
1864 2019-01-09  Tom Tromey  <tom@tromey.com>
1865
1866         * source.c (select_source_symtab)
1867         (forget_cached_source_info_for_objfile): Remove declaration.
1868         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1869         declaration.
1870         * maint.c (count_symtabs_and_blocks): Remove declaration.
1871         * cp-support.c (add_symbol_overload_list_qualified): Remove
1872         declaration.
1873         * coffread.c (coff_symtab_read): Remove declaration.
1874         * symtab.c (lookup_symbol_in_objfile_symtabs)
1875         (basic_lookup_transparent_type_1): Use objfile_compunits.
1876         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1877         (info_sources_command, search_symbols)
1878         (default_collect_symbol_completion_matches_break_on)
1879         (make_source_files_completion_list): Remove declaration.
1880         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1881         (ada_collect_symbol_completion_matches)
1882         (ada_add_global_exceptions): Remove declaration.
1883         * linespec.c (iterate_over_all_matching_symtabs): Use
1884         objfile_compunits.
1885         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1886         (class objfile_compunits): New.
1887         (ALL_COMPUNITS): Use objfile_compunits.
1888         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1889         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1890         objfile_compunits.
1891         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1892
1893 2019-01-09  Tom Tromey  <tom@tromey.com>
1894
1895         * symtab.c (search_symbols)
1896         (default_collect_symbol_completion_matches_break_on): Use
1897         objfile_msymbols.
1898         * ada-lang.c (ada_lookup_simple_minsym)
1899         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1900         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1901         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1902         objfile_msymbols.
1903         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1904         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1905         * objc-lang.c (find_methods): Use objfile_msymbols.
1906         (info_selectors_command, info_classes_command): Likewise.
1907         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1908         * objfiles.h (class objfile_msymbols): New.
1909         (ALL_OBJFILE_MSYMBOLS): Remove.
1910         (ALL_MSYMBOLS): Remove.
1911
1912 2019-01-09  Tom Tromey  <tom@tromey.com>
1913
1914         * common/next-iterator.h (next_adapter): Add Iterator template
1915         parameter.
1916         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1917         (class all_objfiles_safe): New.
1918         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1919         * objfiles.c (put_objfile_before): Update comment.
1920         (add_separate_debug_objfile): Likewise.
1921         (free_all_objfiles): Use all_objfiles_safe.
1922         (objfile_purge_solibs): Likewise.
1923
1924 2019-01-09  Tom Tromey  <tom@tromey.com>
1925
1926         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1927         (expand_symtab_containing_pc, lookup_static_symbol)
1928         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1929         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1930         all_objfiles.
1931         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1932         * breakpoint.c (create_overlay_event_breakpoint)
1933         (create_longjmp_master_breakpoint)
1934         (create_std_terminate_master_breakpoint)
1935         (create_exception_master_breakpoint): Use all_objfiles.
1936         * linux-thread-db.c (try_thread_db_load_from_pdir)
1937         (has_libpthread): Use all_objfiles.
1938         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1939         * linespec.c (iterate_over_all_matching_symtabs)
1940         (search_minsyms_for_name): Use all_objfiles.
1941         * maint.c (maintenance_info_sections): Use all_objfiles.
1942         * main.c (captured_main_1): Use all_objfiles.
1943         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1944         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1945         * guile/scm-pretty-print.c
1946         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1947         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1948         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1949         (maintenance_print_msymbols): Use all_objfiles.
1950         * source.c (select_source_symtab): Use all_objfiles.
1951         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1952         * symfile.c (remove_symbol_file_command)
1953         (expand_symtabs_matching, map_symbol_filenames): Use
1954         all_objfiles.
1955         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1956         all_objfiles.
1957         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1958         * objc-lang.c (find_methods): Use all_objfiles.
1959         * objfiles.c (have_partial_symbols, have_full_symbols)
1960         (have_minimal_symbols, qsort_cmp)
1961         (default_iterate_over_objfiles_in_search_order): Use
1962         all_objfiles.
1963         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1964         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1965         (maintenance_check_psymtabs): Use all_objfiles.
1966         (ALL_PSYMTABS): Remove.
1967         * compile/compile-object-run.c (do_module_cleanup): Use
1968         all_objfiles.
1969         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1970         * cp-support.c (add_symbol_overload_list_qualified): Use
1971         all_objfiles.
1972         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1973         Use all_objfiles.
1974         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1975         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1976         all_objfiles.
1977         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1978         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1979         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1980         Uses all_objfiles.
1981         * solib.c (solib_read_symbols): Use all_objfiles
1982
1983 2019-01-09  Tom Tromey  <tom@tromey.com>
1984
1985         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1986         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1987         all_objfiles.
1988         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1989         * symmisc.c (print_symbol_bcache_statistics)
1990         (print_objfile_statistics, maintenance_print_objfiles)
1991         (maintenance_info_symtabs, maintenance_check_symtabs)
1992         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1993         all_objfiles.
1994         * source.c (forget_cached_source_info): Use all_objfiles.
1995         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1996         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1997         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1998         * objfiles.c (update_section_map): Use all_objfiles.
1999         (shared_objfile_contains_address_p): Likewise.
2000         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2001         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2002
2003 2019-01-09  Tom Tromey  <tom@tromey.com>
2004
2005         * common/next-iterator.h: New file.
2006         * objfiles.h (class all_objfiles): New.
2007         (struct objfile_iterator): New.
2008
2009 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2010
2011         * NEWS: Move the description of the changed "frame", "select-frame",
2012          and "info frame" commands to the Changed commands section.
2013
2014 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2015
2016         * gdbtypes.c (check_stub_method_group): Remove handling of old
2017         mangling schemes.
2018         * linespec.c (find_methods): Likewise.
2019         * stabsread.c (read_member_functions): Likewise.
2020         * valops.c (search_struct_method): Likewise.
2021         (value_struct_elt_for_reference): Likewise.
2022         * NEWS: Mention this change.
2023
2024 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2025
2026         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2027         print_source_lines.
2028         * source.c (print_source_lines_base): Update line number check.
2029         (print_source_lines): New function.
2030         (source_lines_range::source_lines_range): New function.
2031         * source.h (class source_lines_range): New class.
2032         (print_source_lines): New declaration.
2033
2034 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2035
2036         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2037
2038 2019-01-08  Tom Tromey  <tom@tromey.com>
2039             Simon Marchi  <simon.marchi@ericsson.com>
2040
2041         PR gdb/24060
2042         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2043         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2044         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2045         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2046         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2047         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2048
2049 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2050
2051         * source.c (select_source_symtab): Move header comment to
2052         declaration in source.h.
2053         (forget_cached_source_info_for_objfile): Likewise.
2054         (forget_cached_source_info): Likewise.
2055         (identify_source_line): Likewise.
2056         * source.h (identify_source_line): Move declaration from symtab.h
2057         and add comment from source.c
2058         (print_source_lines): Likewise.
2059         (forget_cached_source_info_for_objfile): Likewise.
2060         (forget_cached_source_info): Likewise.
2061         (select_source_symtab): Likewise.
2062         (enum print_source_lines_flag): Move definition from symtab.h.
2063         * symtab.h (identify_source_line): Move declaration to source.h.
2064         (print_source_lines): Likewise.
2065         (forget_cached_source_info_for_objfile): Likewise.
2066         (forget_cached_source_info): Likewise.
2067         (select_source_symtab): Likewise.
2068         (enum print_source_lines_flag): Move definition to source.h.
2069         * tui/tui-hooks.c: Add 'source.h' include.
2070
2071 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2072
2073         * source.c (print_source_lines_base): Handle requests to print
2074         reverse line number sequences, and guard against empty lines
2075         string.
2076
2077 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2078
2079         * source.c (print_source_lines_base): Fix skip of '\r' if next
2080         character is '\n'.
2081
2082 2019-01-06  Tom Tromey  <tom@tromey.com>
2083
2084         * c-exp.y (struct c_parse_state) <macro_original_text,
2085         expansion_obstack>: New member.
2086         (macro_original_text, expansion_obstack): Remove globals.
2087         (scan_macro_expansion, scanning_macro_expansion)
2088         (finished_macro_expansion): Update.
2089         (scan_macro_cleanup): Remove.
2090         (yylex, c_parse): Update.
2091
2092 2019-01-06  Tom Tromey  <tom@tromey.com>
2093
2094         * c-exp.y (struct c_parse_state) <strings>: New member.
2095         (operator_stoken): Update.
2096
2097 2019-01-06  Tom Tromey  <tom@tromey.com>
2098
2099         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2100         (union type_stack_elt) <typelist_val>: Now a pointer to
2101         std::vector.
2102         (type_stack_cleanup): Don't declare.
2103         (push_typelist): Update.
2104         * parse.c (pop_typelist): Return a std::vector.
2105         (push_typelist): Take a std::vector.
2106         (follow_types): Update.  Do not free args.
2107         (type_stack_cleanup): Remove.
2108         * c-exp.y (struct c_parse_state): New.
2109         (cpstate): New global.
2110         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2111         (nonempty_typelist): Update.
2112         (func_mod): Create a new vector.
2113         (c_parse): Create a c_parse_state.
2114         (check_parameter_typelist): Do not delete params.
2115         (function_method): Update.  Do not delete type_list.
2116
2117 2019-01-06  Tom Tromey  <tom@tromey.com>
2118
2119         PR gdb/28155:
2120         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2121         check_typedef.
2122         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2123         (print_return_value): Likewise.
2124
2125 2019-01-05  Tom Tromey  <tom@tromey.com>
2126
2127         * contrib/cleanup_check.py: Remove.
2128         * contrib/gcc-with-excheck: Remove.
2129         * contrib/exsummary.py: Remove.
2130         * contrib/excheck.py: Remove.
2131
2132 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2133
2134         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2135         NULL. Initialize tpprev to NULL instead of assigning it
2136         to NULL on the next statement.
2137         * windows-nat.c (windows_delete_thread): Remove check for
2138         main_thread_id before printing thread exit notifications.
2139         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2140         Remove thread ID check against main_thread_id.
2141         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2142         windows_delete_thread.
2143         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2144
2145 2019-01-04  Tom Tromey  <tom@tromey.com>
2146
2147         * compile/compile.c (_initialize_compile): Use upper case for
2148         metasyntactic variables.
2149         * symmisc.c (_initialize_symmisc): Use upper case for
2150         metasyntactic variables.
2151         * psymtab.c (_initialize_psymtab): Use upper case for
2152         metasyntactic variables.
2153         * demangle.c (demangle_command): Use upper case for metasyntactic
2154         variables.
2155         (_initialize_demangler): Likewise.
2156         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2157         variables.
2158
2159 2019-01-03  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2162
2163 2019-01-03  Tom Tromey  <tom@tromey.com>
2164
2165         * python/py-symtab.c (salpy_str): Update.
2166         (struct salpy_sal_object) <symtab>: Now a PyObject.
2167         (salpy_dealloc): Update.
2168         (del_objfile_sal): Use gdbpy_ref.
2169
2170 2019-01-03  Tom Tromey  <tom@tromey.com>
2171
2172         * python/py-type.c (convert_field): Use new_reference.  Return
2173         gdbpy_ref.
2174         (make_fielditem): Return gdbpy_ref.
2175         (typy_fields): Update.
2176         (typy_getitem): Update.
2177         (field_name): Return gdbpy_ref.  Use new_reference.
2178         (typy_iterator_iternext): Update.
2179
2180 2019-01-03  Tom Tromey  <tom@tromey.com>
2181
2182         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2183
2184 2019-01-03  Tom Tromey  <tom@tromey.com>
2185
2186         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2187         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2188         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2189         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2190         (pspy_set_type_printers): Likewise.
2191         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2192         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2193         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2194         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2195         (objfpy_set_type_printers): Likewise.
2196
2197 2019-01-03  Tom Tromey  <tom@tromey.com>
2198
2199         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2200         (gdbpy_print_stack): Use gdbpy_err_fetch.
2201         * python/python-internal.h (class gdbpy_err_fetch): New class.
2202         (class gdbpy_enter) <m_error_type, m_error_value,
2203         m_error_traceback>: Remove.
2204         <m_error>: New member.
2205         (gdbpy_exception_to_string): Don't declare.
2206         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2207         * python/py-value.c (convert_value_from_python): Use
2208         gdbpy_err_fetch.
2209         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2210         gdbpy_exception_to_string.
2211         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2212         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2213         gdbpy_err_fetch.
2214
2215 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * linux-nat.c (delete_lwp_cleanup): Delete.
2218         (struct lwp_deleter): New struct.
2219         (lwp_info_up): New typedef.
2220         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2221         lwp_info_up.
2222
2223 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * linux-fork.c (class scoped_switch_fork_info): New class.
2226         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2227
2228 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         * valops.c (find_overload_match): Remove use of null_cleanup, and
2231         calls to do_cleanups.
2232
2233 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2234
2235         * compile/compile-cplus-types.c
2236         (compile_cplus_instance::decl_name): Handle changes to
2237         cp_func_name.
2238         * cp-support.c (cp_func_name): Update header comment, update
2239         return type.
2240         * cp-support.h (cp_func_name): Update return type in declaration.
2241         * valops.c (find_overload_match): Move temp_func local to top
2242         level of function and change its type.  Use temp_func to hold and
2243         delete temporary string obtained from cp_func_name.
2244
2245 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2246
2247         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2248         gdb::char_vector, remove cleanup, and update uses of `msg`.
2249
2250 2019-01-03  Jim Wilson  <jimw@sifive.com>
2251
2252         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2253
2254 2019-01-02  Tom Tromey  <tom@tromey.com>
2255
2256         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2257         (tdesc_parse_xml): Remove cleanups.
2258         * target-descriptions.h (make_cleanup_free_target_description):
2259         Don't declare.
2260         (target_desc_deleter): New struct.
2261         (target_desc_up): New typedef.
2262         * target-descriptions.c (target_desc_deleter::operator()): Rename
2263         from free_target_description.
2264         (make_cleanup_free_target_description): Remove.
2265
2266 2019-01-02  Tom Tromey  <tom@tromey.com>
2267
2268         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2269         constructor, destructor.
2270         (linespec_parser): Remove typedef.
2271         (~linespec_parser): Rename from linespec_parser_delete.
2272         (linespec_lex_to_end, linespec_complete_label)
2273         (linespec_complete): Update.
2274         (decode_line_full): Remove cleanups.
2275         (decode_line_1): Update.
2276
2277 2019-01-02  Tom Tromey  <tom@tromey.com>
2278
2279         * python/python-internal.h (inferior_to_inferior_object): Change
2280         return type.
2281         * python/py-exitedevent.c (create_exited_event_object): Update.
2282         * python/py-inferior.c (inferior_to_inferior_object): Return
2283         gdbpy_ref.
2284         (python_new_inferior, python_inferior_deleted)
2285         (thread_to_thread_object, delete_thread_object)
2286         (build_inferior_list, gdbpy_selected_inferior): Update.
2287         * python/py-infthread.c (create_thread_object): Update.  Also fail
2288         if inferior_to_inferior_object fails.
2289
2290 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2291
2292         * inferior.h (class inferior) <displaced_step_state>: New field.
2293         * infrun.h (struct displaced_step_state): Move here from
2294         infrun.c.  Initialize fields, add constructor.
2295         <inf>: Remove field.
2296         <reset>: New method.
2297         * infrun.c (struct displaced_step_inferior_state): Move to
2298         infrun.h.
2299         (displaced_step_inferior_states): Remove.
2300         (get_displaced_stepping_state): Adust.
2301         (displaced_step_in_progress_any_inferior): Adjust.
2302         (displaced_step_in_progress_thread): Adjust.
2303         (displaced_step_in_progress): Adjust.
2304         (add_displaced_stepping_state): Remove.
2305         (get_displaced_step_closure_by_addr): Adjust.
2306         (remove_displaced_stepping_state): Remove.
2307         (infrun_inferior_exit): Call displaced_step_state.reset.
2308         (use_displaced_stepping): Don't check for NULL.
2309         (displaced_step_prepare_throw): Call
2310         get_displaced_stepping_state.
2311         (displaced_step_fixup): Don't check for NULL.
2312         (prepare_for_detach): Don't check for NULL.
2313
2314 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2315
2316         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2317          in case of call that did not complete.
2318
2319 2019-01-02  Andrey Utkin  <autkin@undo.io>
2320
2321         * symfile.c (find_separate_debug_file): Fix search of debug files for
2322         remote debuggee.
2323
2324 2019-01-02  Tom Tromey  <tom@tromey.com>
2325
2326         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2327         indentation.
2328         * python/py-frame.c (frapy_older): Remove cast.
2329         (frapy_newer): Likewise.
2330         * python/py-breakpoint.c (local_setattro): Remove cast.
2331         * python/py-arch.c (archpy_name): Remove local variable.
2332         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2333
2334 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2335
2336         * unittests/basic_string_view/element_access/char/empty.cc:
2337         Fix year range in copyright header.
2338
2339 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2340
2341         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2342         Delete.
2343         <operator==>: Update with for removed field.
2344         <hash>: Likewise.
2345         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2346         <isa_features>: ...this.
2347         <abi_features>: New field.
2348         (riscv_isa_flen): Update comment.
2349         (riscv_abi_xlen): New declaration.
2350         (riscv_abi_flen): New declaration.
2351         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2352         isa_features.
2353         (riscv_abi_xlen): New function.
2354         (riscv_isa_flen): Update to get answer from isa_features.
2355         (riscv_abi_flen): New function.
2356         (riscv_has_fp_abi): Update to get answer from abi_features.
2357         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2358         xlen and flen.
2359         (riscv_call_info) <xlen, flen>: Update comment.
2360         (riscv_call_arg_struct): Remove invalid assertions
2361         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2362         is removed.
2363         (riscv_gdbarch_init): Gather isa features and abi features
2364         separately, ensure both match on the gdbarch when reusing an old
2365         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2366         a target with 64-bit float hardware.
2367
2368 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2369
2370         * source.c (search_command_helper): Stop reverse search
2371         when line 1 has been searched.
2372
2373 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2374
2375         * record-full.c (record_full_base_target::close): Rewrite
2376         record_full_core_buf_list free logic.
2377
2378 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2379
2380         * break-catch-syscall.c (print_one_catch_syscall): xfree
2381         the last text.
2382
2383 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2384
2385         * top.c (print_gdb_version): Update Copyright year in version
2386         message.
2387
2388 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2389
2390         Update copyright year range in all GDB files.
2391
2392 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2393
2394         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2395
2396 For older changes see ChangeLog-2018.
2397 \f
2398 Local Variables:
2399 mode: change-log
2400 left-margin: 8
2401 fill-column: 74
2402 version-control: never
2403 coding: utf-8
2404 End:
2405