gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * solib-dsbt.c (struct dsbt_info): Add initializers.
   4         (solib_dsbt_pspace_data): Change type.
   5         (dsbt_pspace_data_cleanup): Remove.
   6         (get_dsbt_info, _initialize_dsbt_solib): Update.
   7
   8 2019-07-10  Tom Tromey  <tromey@adacore.com>
   9
  10         * spu-tdep.c (spu_overlay_data): Change type.
  11         (spu_get_overlay_table, spu_overlay_new_objfile)
  12         (_initialize_spu_tdep): Update.
  13
  14 2019-07-10  Tom Tromey  <tromey@adacore.com>
  15
  16         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
  17         destructor.
  18         (dbx_objfile_data_key): Change type and declare later.
  19         (DBX_SYMFILE_INFO): Rewrite.
  20         * dbxread.c (dbx_objfile_data_key): Change type.
  21         (dbx_symfile_init): Update.
  22         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
  23         (coffstab_build_psymtabs, elfstab_build_psymtabs)
  24         (stabsect_build_psymtabs, _initialize_dbxread): Update.
  25
  26 2019-07-10  Tom Tromey  <tromey@adacore.com>
  27
  28         * jit.c (jit_program_space_key): Change type.  Move lower.
  29         (get_jit_program_space_data): Update.
  30         (jit_program_space_data_cleanup): Remove.
  31         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
  32         Update.
  33         (struct jit_program_space_data): Add initializers.
  34
  35 2019-07-10  Tom Tromey  <tromey@adacore.com>
  36
  37         * solib-darwin.c (struct darwin_info): Add initializers.
  38         (solib_darwin_pspace_data): Change type.
  39         (darwin_pspace_data_cleanup): Remove.
  40         (get_darwin_info, _initialize_darwin_solib): Update.
  41
  42 2019-07-10  Tom Tromey  <tromey@adacore.com>
  43
  44         * remote-sim.c (struct sim_inferior_data): Add initializers,
  45         constructor, and destructor.
  46         (sim_inferior_data_key): Change type.  Move lower.
  47         (check_for_duplicate_sim_descriptor): Update.
  48         (get_sim_inferior_data): Use new.  Update.
  49         (~sim_inferior_data_cleanup): Rename from
  50         sim_inferior_data_cleanup.  Simplify.
  51         (gdbsim_close_inferior, simulator_command)
  52         (sim_command_completer, _initialize_remote_sim): Update.
  53         (next_pid, INITIAL_PID): Move earlier.
  54
  55 2019-07-10  Tom Tromey  <tromey@adacore.com>
  56
  57         * python/python-internal.h (create_thread_object): Return
  58         gdbpy_ref.
  59         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
  60         * python/py-inferior.c (struct threadlist_entry): Add
  61         constructor.
  62         <thread_obj>: Now a gdbpy_ref.
  63         (thread_to_thread_object): Update.
  64         (add_thread_object): Use new.
  65         (delete_thread_object): Use delete.
  66         (infpy_threads): Update.
  67         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
  68         GIL.
  69
  70 2019-07-10  Tom Tromey  <tromey@adacore.com>
  71
  72         * valops.c (value_cast): Specialize error message for Ada.
  73
  74 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  75
  76         * breakpoint.c (breakpoint_1): Update doc and parameter names.
  77
  78 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  79
  80         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
  81         bpstat_should_step): Return bool, adjust comments.
  82         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  83         bpstat_should_step): Likewise.
  84
  85 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  86
  87         * features/Makefile: Use feature target descriptions for Arm.
  88         * features/arm/arm-core.c: Generate new file.
  89         * features/arm/arm-fpa.c: Likewise.
  90         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  91         * features/arm/arm-m-profile.c: Likewise.
  92         * features/arm/arm-vfpv2.c: Likewise.
  93         * features/arm/arm-vfpv3.c: Likewise.
  94         * features/arm/xscale-iwmmxt.c: Likewise.
  95         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  96
  97 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  98
  99         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 100         ptrace earlier.
 101
 102 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 103
 104         * features/aarch64-pauth.c: Regenerate.
 105
 106 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 107
 108         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 109         bool.
 110         (bpstat_what): Use false instead of 0.
 111
 112 2019-07-09  Pedro Alves  <palves@redhat.com>
 113
 114         * break-catch-throw.c (is_exception_catchpoint): New.
 115         * breakpoint.c (print_one_breakpoint_location): New parameter
 116         'raw_loc'.  Handle it.  Use
 117         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 118         looking at the breakpoint's type.
 119         (print_one_breakpoint): If handling "maint info breakpoints", also
 120         print locations of exception catchpoints.
 121         * breakpoint.h (is_exception_catchpoint): Declare.
 122
 123 2019-07-09  Pedro Alves  <palves@redhat.com>
 124
 125         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 126         "addr" field.
 127         (allocate_location_exception_catchpoint): New.
 128         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 129         (initialize_throw_catchpoint_ops): Install
 130         allocate_location_exception_catchpoint as allocate_location
 131         method.
 132         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 133         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 134         bp_loc_other.
 135         (breakpoint_address_is_meaningful): Delete.
 136         (bl_address_is_meaningful): New.
 137         (breakpoint_locations_match): Adjust comment.
 138         (bp_location_from_bp_type): New, factored out of...
 139         (bp_location::bp_location(breakpoint *)): ... this.
 140         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 141         factored out of...
 142         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 143         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 144         breakpoint_address_is_meaningful.
 145         (bp_locations_compare): Adjust comment.
 146         (update_global_location_list): Use bl_address_is_meaningful
 147         instead of breakpoint_address_is_meaningful.
 148         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 149         explicit.
 150         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 151         * python/py-breakpoint.c (bppy_get_location): No longer check
 152         whether location is null.
 153
 154 2019-07-09  Pedro Alves  <palves@redhat.com>
 155
 156         PR c++/15468
 157         * breakpoint.c (print_one_breakpoint_location): Remove
 158         single-location assert.
 159
 160 2019-07-09  Tom Tromey  <tom@tromey.com>
 161
 162         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 163         * configure: Rebuild.
 164         * configure.ac: Change common to gdbsupport.
 165         * gdbsupport: Rename from common.
 166         * acinclude.m4: Change common to gdbsupport.
 167         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 168         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 169         gdbsupport.
 170         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 171         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 172         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 173         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 174         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 175         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 176         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 177         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 178         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 179         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 180         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 181         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 182         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 183         coff-pe-read.c, command.h, compile/compile-c-support.c,
 184         compile/compile-c.h, compile/compile-cplus-symbols.c,
 185         compile/compile-cplus-types.c, compile/compile-cplus.h,
 186         compile/compile-loc2c.c, compile/compile.c, completer.c,
 187         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 188         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 189         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 190         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 191         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 192         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 193         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 194         features/aarch64-core.c, features/aarch64-fpu.c,
 195         features/aarch64-pauth.c, features/aarch64-sve.c,
 196         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 197         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 198         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 199         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 200         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 201         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 202         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 203         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 204         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 205         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 206         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 207         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 208         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 209         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 210         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 211         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 212         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 213         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 214         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 215         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 216         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 217         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 218         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 219         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 220         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 221         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 222         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 223         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 224         minsyms.c, mips-linux-tdep.c, namespace.h,
 225         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 226         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 227         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 228         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 229         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 230         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 231         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 232         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 233         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 234         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 235         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 236         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 237         procfs.c, producer.c, progspace.h, psymtab.h,
 238         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 239         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 240         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 241         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 242         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 243         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 244         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 245         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 246         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 247         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 248         target-memory.c, target.c, target.h, target/waitstatus.c,
 249         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 250         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 251         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 252         unittests/array-view-selftests.c,
 253         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 254         unittests/common-utils-selftests.c,
 255         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 256         unittests/format_pieces-selftests.c,
 257         unittests/function-view-selftests.c,
 258         unittests/lookup_name_info-selftests.c,
 259         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 260         unittests/mkdir-recursive-selftests.c,
 261         unittests/observable-selftests.c,
 262         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 263         unittests/parse-connection-spec-selftests.c,
 264         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 265         unittests/scoped_fd-selftests.c,
 266         unittests/scoped_mmap-selftests.c,
 267         unittests/scoped_restore-selftests.c,
 268         unittests/string_view-selftests.c, unittests/style-selftests.c,
 269         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 270         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 271         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 272         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 273         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 274         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 275
 276 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 277
 278         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 279         bool value.
 280         (decode_digits_ordinary): Set explicit_line field in sal.
 281         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 282         symtab_and_line that was set on an explicit line number in
 283         assembler code.  Do always update the recorded symtab and line if
 284         we do skip the prologue.
 285
 286 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 287
 288         * breakpoint.c (set_breakpoint_location_function): Remove
 289         explicit_loc parameter.
 290         (momentary_breakpoint_from_master): Update call to
 291         set_breakpoint_location_function.
 292         (add_location_to_breakpoint): Likewise.
 293
 294 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 295
 296         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 297         required features based on default bfd type when no specific bfd
 298         is present.
 299
 300 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 301
 302         * NEWS: Mention that GDB printf and eval commands can now print
 303         C-style and Ada-style convenience var strings without
 304         calling the inferior.
 305         * printcmd.c (printf_c_string): Locally print GDB internal var
 306         instead of transiting via the inferior.
 307         (printf_wide_c_string): Likewise.
 308
 309 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 310
 311         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 312
 313 2019-07-04  Tom Tromey  <tom@tromey.com>
 314
 315         PR tui/24724:
 316         * tui/tui-winsource.c (tui_clear_source_content): Update.
 317         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 318         (tui_update_breakpoint_info): Update.
 319         (tui_set_exec_info_content): Update.
 320         * tui/tui-source.c (tui_set_source_content_nil): Update.
 321         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 322         has_break.
 323         * tui/tui-data.h (enum tui_bp_flag): New.
 324         (tui_bp_flags): New enum flags type.
 325         (struct tui_source_element) <break_mode>: Change type.  Rename
 326         from has_break.
 327         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 328         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 329         constants.
 330         * tui/tui-winsource.h: Fix comment.
 331
 332 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 333
 334         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 335         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 336         (store_fpregs_to_thread)
 337         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 338         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 339         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 340         (IWMMXT_REGS_SIZE): Add define.
 341         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 342         (fetch_vfp_regs, store_vfp_regs)
 343         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 344         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 345
 346 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 347
 348         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 349         defines.
 350         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 351         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 352         (ARM_INT_REGISTER_SIZE): ...to this.
 353         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 354         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 355         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 356         (arm_linux_collect_gregset, supply_nwfpe_register)
 357         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 358         defines.
 359         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 360         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 361         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 362         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 363         (arm_return_in_memory, arm_store_return_value)
 364         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 365         (arm_record_ld_st_multiple): Likewise.
 366         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 367         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 368
 369 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 370
 371         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 372         AARCH64_DISPLACED_MODIFIED_INSNS.
 373         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 374         (aarch64_displaced_step_copy_insn): Likewise.
 375         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 376         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 377         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 378         ARM_DISPLACED_MODIFIED_INSNS.
 379         * arm-tdep.c (arm_gdbarch_init): Likewise.
 380         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 381         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 382         (struct arm_displaced_step_closure): Use
 383         ARM_DISPLACED_MODIFIED_INSNS.
 384
 385 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 386
 387         * features/Makefile: Remove unused xml files.
 388         * features/aarch64.xml: Remove.
 389         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 390         * features/i386/amd64-avx-avx512.xml: Remove.
 391         * features/i386/amd64-avx-linux.xml: Remove.
 392         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 393         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 394         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 395         * features/i386/amd64-avx-mpx.xml: Remove.
 396         * features/i386/amd64-avx.xml: Remove.
 397         * features/i386/amd64-linux.xml: Remove.
 398         * features/i386/amd64-mpx-linux.xml: Remove.
 399         * features/i386/amd64-mpx.xml: Remove.
 400         * features/i386/amd64.xml: Remove.
 401         * features/i386/i386-avx-avx512-linux.xml: Remove.
 402         * features/i386/i386-avx-avx512.xml: Remove.
 403         * features/i386/i386-avx-linux.xml: Remove.
 404         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 405         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 406         * features/i386/i386-avx-mpx-linux.xml: Remove.
 407         * features/i386/i386-avx-mpx.xml: Remove.
 408         * features/i386/i386-avx.xml: Remove.
 409         * features/i386/i386-linux.xml: Remove.
 410         * features/i386/i386-mmx-linux.xml: Remove.
 411         * features/i386/i386-mmx.xml: Remove.
 412         * features/i386/i386-mpx-linux.xml: Remove.
 413         * features/i386/i386-mpx.xml: Remove.
 414         * features/i386/i386.xml: Remove.
 415         * features/i386/x32-avx-avx512-linux.xml: Remove.
 416         * features/i386/x32-avx-linux.xml: Remove.
 417         * features/i386/x32-linux.xml: Remove.
 418
 419 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 420
 421         * regformats/aarch64.dat: Remove.
 422         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 423         * regformats/i386/amd64-avx-linux.dat: Remove.
 424         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 425         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 426         * regformats/i386/amd64-linux.dat: Remove.
 427         * regformats/i386/amd64-mpx-linux.dat: Remove.
 428         * regformats/i386/amd64.dat: Remove.
 429         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 430         * regformats/i386/i386-avx-linux.dat: Remove.
 431         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 432         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 433         * regformats/i386/i386-linux.dat: Remove.
 434         * regformats/i386/i386-mmx-linux.dat: Remove.
 435         * regformats/i386/i386-mpx-linux.dat: Remove.
 436         * regformats/i386/i386.dat: Remove.
 437         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 438         * regformats/i386/x32-avx-linux.dat: Remove.
 439         * regformats/i386/x32-linux.dat: Remove.
 440
 441 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 442
 443         * aarch64-tdep.c: Remove xml self tests.
 444         * amd64-linux-tdep.c: Likewise.
 445         * amd64-tdep.c: Likewise.
 446         * i386-linux-tdep.c: Likewise.
 447         * i386-tdep.c: Likewise.
 448
 449 2019-07-03  Pedro Alves  <palves@redhat.com>
 450
 451         PR cli/24732
 452         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 453         (pipe_cmd_option_defs): New.
 454         (make_pipe_cmd_options_def_group): New.
 455         (pipe_command): Use gdb::option::process_options.
 456         (pipe_command_completer): New function.
 457         (_initialize_cli_cmds): Install completer for "pipe" command.
 458
 459 2019-07-03  Pedro Alves  <palves@redhat.com>
 460
 461         * cli/cli-option.c (union option_value) <string>: New field.
 462         (struct option_def_and_value): Add ctor, move ctor, dtor and
 463         use DISABLE_COPY_AND_ASSIGN.
 464         (option_def_and_value::clear_value): New.
 465         (parse_option, save_option_value_in_ctx, get_val_type_str)
 466         (add_setshow_cmds_for_options): Handle var_string.
 467         * cli-option.h (union option_def::var_address) <string>: New
 468         field.
 469         (struct string_option_def): New.
 470         * maint-test-options.c (struct test_options_opts): Add default
 471         ctor and use DISABLE_COPY_AND_ASSIGN.
 472         <string_opt>: New field.
 473         (test_options_opts::~test_options_opts): New.
 474         (test_options_opts::dump): Also dump "-string".
 475         (test_options_option_defs): Install "string.
 476
 477 2019-07-03  Pedro Alves  <palves@redhat.com>
 478
 479         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 480         option_value with a null enumeration.
 481         (complete_options): Save the option values in the context.
 482         (save_option_value_in_ctx): New, factored out from ...
 483         (process_options): ... here.
 484         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 485         of the function.
 486         * maint-test-options.c (test_options_opts::dump): New, factored
 487         out from ...
 488         (maintenance_test_options_command_mode): ... here.
 489         (maintenance_test_options_command_completion_result): Delete.
 490         (maintenance_test_options_command_completion_text): Update
 491         comment.
 492         (maintenance_show_test_options_completion_result): Change
 493         prototype.  Just print
 494         maintenance_test_options_command_completion_text.
 495         (save_completion_result): New.
 496         (maintenance_test_options_completer_mode): Pass options context to
 497         complete_options, and then save a dump.
 498         (_initialize_maint_test_options): Use add_cmd to install "maint
 499         show test-options-completion-result".
 500
 501 2019-07-03  Pedro Alves  <palves@redhat.com>
 502
 503         * NEWS (New commands): Mention "with" and "maint with".
 504         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 505         (with_command, with_command_completer): New.
 506         (pipe_command): Adjust to new repeat_previous
 507         interface.
 508         (_initialize_cli_cmds): Install the "with" command and its "w"
 509         alias.
 510         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 511         declarations.
 512         * cli/cli-setshow.c (parse_cli_var_uinteger)
 513         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 514         argument strings for all var_types.
 515         (get_setshow_command_value_string): New, factored out from ...
 516         (do_show_command): ... this.
 517         * cli/cli-setshow.h: Include <string>.
 518         (get_setshow_command_value_string): Declare.
 519         * command.h (repeat_previous): Now returns const char *.  Adjust
 520         comment.
 521         * maint.c: Include "cli/cli-cmds.h".
 522         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 523         (_initialize_maint_cmds): Register the "maintenance with" command.
 524         * top.c (repeat_previous): Move bits from pipe_command here:
 525         Return the saved command line, if any; error out if there's no
 526         command to relaunch.
 527
 528 2019-07-03  Pedro Alves  <palves@redhat.com>
 529
 530         * NEWS (New commands): Mention "maint set/show test-settings"
 531         instead of "maint test-settings".
 532         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 533         (maintenance_test_settings_set_list): Rename to ...
 534         (maintenance_set_test_settings_list): ... this.
 535         (maintenance_test_settings_show_list): Rename to  ...
 536         (maintenance_show_test_settings_list): ... this.
 537         (maintenance_test_settings_cmd): Delete.
 538         (maintenance_test_settings_set_cmd): ...
 539         (maintenance_set_test_settings_cmd): ... this.
 540         (maintenance_test_settings_show_cmd): ...
 541         (maintenance_show_test_settings_cmd): ... this.
 542         (maintenance_test_settings_show_value_cmd):
 543         (maintenance_show_test_settings_value_cmd): ... this.
 544         (_initialize_maint_test_settings): No longer install the "maint
 545         test-settings" prefix command.  Rename "maint test-settings set"
 546         to "maint set test-settings", and "maint test-settings show" to
 547         "maint show test-settings".  Adjust all subcommands.
 548
 549 2019-07-03  Pedro Alves  <palves@redhat.com>
 550
 551         * maint-test-settings.c: Fix file's intro comment.  Replace all
 552         references to "test-options" with references to "test-settings",
 553         in comments.
 554
 555 2019-07-03  Pedro Alves  <palves@redhat.com>
 556
 557         * maint-test-settings.c (maintenance_test_settings_xxx)
 558         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 559         New.
 560         (maintenance_test_settings_enums): Use them.
 561         (maintenance_test_settings_enum): Default to
 562         maintenance_test_settings_xxx.
 563         (_initialize_maint_test_settings): Initialize
 564         MAINTENANCE_TEST_SETTINGS_FILENAME.
 565
 566 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 567
 568         * breakpoint.h (remove_breakpoints_inf): Change return type to
 569         void, move function documentation here.
 570         * breakpoint.c (remove_breakpoints_inf): Change return type to
 571         void, move function documentation to header.
 572
 573 2019-07-02  Pedro Alves  <palves@redhat.com>
 574
 575         * NEWS (Completion improvements): Mention "info threads".
 576         * thread.c (struct info_threads_opts, info_threads_option_defs)
 577         (make_info_threads_options_def_group): New.
 578         (info_threads_command): Use gdb::option::process_options.
 579         (info_threads_command_completer): New.
 580         (_initialize_thread): Use gdb::option::build_help to build the
 581         help text for "info threads".
 582
 583 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 584
 585         * defs.h (generic_load): Move from here...
 586         * symfile.h (generic_load): ... to here.  Rename name parameter
 587         to args.
 588         * symfile.c (generic_load): Add comment.
 589
 590 2019-07-01  Tom Tromey  <tromey@adacore.com>
 591
 592         * dwarf2read.c
 593         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 594         declaration of without_params.  Fix formatting.
 595
 596 2019-07-01  Tom Tromey  <tromey@adacore.com>
 597
 598         * ada-exp.y (find_primitive_type): Update.
 599         * ada-lang.h (ada_lookup_symbol): Update.
 600         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 601         parameter.
 602         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 603
 604 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 605
 606         PR breakpoints/24541
 607         * gdbarch.c: Regenerate.
 608         * gdbarch.h: Regenerate.
 609         * gdbarch.sh: Add 'stap_adjust_register'.
 610         * i386-tdep.c: Include '<unordered_set>'.
 611         (i386_stap_adjust_register): New function.
 612         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 613         * stap-probe.c (stap_parse_register_operand): Call
 614         'gdbarch_stap_adjust_register'.
 615
 616 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 617
 618         PR python/24742
 619         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 620         * python/python.c (do_start_initialization): Use 'xmalloc'
 621         instead of 'PyMem_Malloc'.
 622
 623 2019-06-28  Tom Tromey  <tromey@adacore.com>
 624
 625         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 626         for Ada.
 627
 628 2019-06-27  Tom Tromey  <tromey@adacore.com>
 629
 630         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 631         objfile_key.
 632         (arm_find_mapping_symbol, arm_record_special_symbol)
 633         (_initialize_arm_tdep): Update.
 634         (arm_objfile_data_free): Remove.
 635
 636 2019-06-27  Tom Tromey  <tromey@adacore.com>
 637
 638         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 639         to cp_print_static_field.
 640
 641 2019-06-26  Tom Tromey  <tromey@adacore.com>
 642
 643         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 644         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 645         declare.
 646
 647 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 648
 649         * features/aarch64-core.c (create_feature_aarch64_core):
 650         Regenerate.
 651         * features/aarch64-core.xml: Add cpsr flags.
 652
 653 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 654
 655         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 656         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 657
 658 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 659
 660         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 661         field.
 662         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 663         use.
 664         (arm_record_special_symbol): Don't insert new symbol in sorted
 665         position, push it at the end.
 666
 667 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 668
 669         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 670         (arm_mapping_symbol_s): Remove.
 671         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 672         (arm_mapping_symbol_vec): New typedef.
 673         (struct arm_per_objfile): Add constructor.
 674         <section_maps>: Change type to
 675         std::unique_ptr<arm_mapping_symbol_vec[]>.
 676         (arm_compare_mapping_symbols): Remove.
 677         (arm_find_mapping_symbol): Adjust to section_maps type change.
 678         (arm_objfile_data_free): Call delete on arm_per_objfile.
 679         (arm_record_special_symbol): Adjust to section_maps type change.
 680         Allocate arm_per_objfile with new.
 681
 682 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 683
 684         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 685         with the command prefix.
 686
 687 2019-06-25  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 690         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 691
 692 2019-06-25  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 695         type.
 696         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 697         protected.
 698
 699 2019-06-25  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-winsource.c
 702         (tui_source_window_base::set_is_exec_point_at): Add check against
 703         LOA_ADDRESS.
 704
 705 2019-06-25  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-source.c (tui_set_source_content): Don't check before
 708         xfree.
 709         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 710
 711 2019-06-25  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-winsource.h (tui_update_source_window_as_is)
 714         (tui_alloc_source_buffer, tui_line_is_displayed)
 715         (tui_addr_is_displayed): Change type of win_info.
 716         * tui/tui-winsource.c (tui_update_source_window_as_is)
 717         (tui_clear_source_content, tui_show_source_line)
 718         (tui_show_source_content, tui_source_window_base::refill)
 719         (tui_source_window_base::set_is_exec_point_at)
 720         (tui_source_window_base::set_is_exec_point_at)
 721         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 722         (tui_alloc_source_buffer, tui_line_is_displayed)
 723         (tui_addr_is_displayed): Change type of win_info.  Update.
 724         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 725         (tui_source_window_base::do_make_visible_with_new_height):
 726         Update.
 727         * tui/tui-source.c (tui_set_source_content)
 728         (tui_set_source_content_nil)
 729         (tui_source_window::do_scroll_vertical): Update.
 730         * tui/tui-layout.c (show_layout): Update.
 731         * tui/tui-disasm.c (tui_set_disassem_content)
 732         (tui_disasm_window::do_scroll_vertical): Update.
 733         * tui/tui-data.h (tui_win_content): Remove.
 734         (struct tui_gen_win_info) <content, content_size>: Remove.
 735         (struct tui_source_element): Add initializers and destructor.
 736         (union tui_which_element, struct tui_win_element): Remove.
 737         (struct tui_source_window_base) <content>: New field.
 738         (struct tui_data_window): Remove destructor.
 739         (tui_alloc_content, tui_free_win_content)
 740         (tui_free_all_source_wins_content): Don't declare.
 741         * tui/tui-data.c (tui_initialize_static_data): Update.
 742         (init_content_element, tui_alloc_content): Remove.
 743         (~tui_gen_win_info): Update.
 744         (~tui_data_window, tui_free_all_source_wins_content)
 745         (tui_free_win_content, free_content, free_content_elements):
 746         Remove.
 747
 748 2019-06-25  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-winsource.h (tui_clear_source_content)
 751         (tui_erase_source_content, tui_show_source_content): Change type
 752         of win_info.
 753         * tui/tui-winsource.c (tui_clear_source_content)
 754         (tui_erase_source_content, tui_show_source_content): Change type
 755         of win_info.
 756         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 757         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 758         win_info.
 759         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 760         win_info.
 761         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 762
 763 2019-06-25  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-winsource.c (tui_clear_source_content)
 766         (tui_source_window_base::set_is_exec_point_at): Update.
 767         * tui/tui-source.c (tui_set_source_content_nil): Update.
 768         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 769         a bool.
 770         * tui/tui-data.c (init_content_element): Update.
 771
 772 2019-06-25  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 775         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 776         * tui/tui-layout.c (init_and_make_win): Update.
 777         * tui/tui.h (enum tui_win_type): Update.
 778         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 779         tui_win_is_auxillary.
 780         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 781         tui_win_is_auxillary.
 782
 783 2019-06-25  Tom Tromey  <tom@tromey.com>
 784
 785         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 786         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 787         (tui_delete_data_content_windows, tui_display_all_data)
 788         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 789         Update.
 790         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 791         * tui/tui-regs.c (tui_last_regs_line_no)
 792         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 793         (tui_show_registers): Update.
 794         (tui_show_register_group): Return void.  Update.
 795         (tui_display_registers_from, tui_display_reg_element_at_line)
 796         (tui_display_registers_from_line, tui_check_register_values):
 797         Update.
 798         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 799         member.
 800         (struct tui_data_window) <regs_content>: Now a std::vector.
 801         <regs_content_count>: Remove.
 802         (tui_add_content_elements, tui_free_data_content): Don't declare.
 803         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 804         (init_content_element): Remove DATA_WIN case.  Add assert.
 805         (tui_add_content_elements): Remove.
 806         (tui_data_window): Update.
 807         (tui_free_data_content): Remove.
 808         (free_content_elements): Remove DATA_WIN case.
 809
 810 2019-06-25  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-data.c (tui_data_item_window): Update.
 813         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 814         * tui/tui-windata.c (tui_display_all_data)
 815         (tui_display_data_from_line): Update.
 816         (tui_check_data_values): Remove.
 817         * tui/tui-regs.c (tui_show_register_group)
 818         (tui_display_reg_element_at_line): Update.
 819         * tui/tui-hooks.c (tui_register_changed)
 820         (tui_refresh_frame_and_register_information): Call
 821         tui_check_register_values.
 822         * tui/tui-data.h (struct tui_data_window) <data_content,
 823         data_content_count, data_type>: Remove.
 824         (enum tui_data_type): Remove.
 825
 826         * tui/tui-data.c (tui_data_window::clear_detail)
 827         (~tui_data_window): Update.
 828
 829 2019-06-25  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 832         declare.
 833         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 834         Rename from tui_first_data_item_displayed.  Update.
 835         (tui_data_window::refresh_all)
 836         (tui_data_window::do_scroll_vertical): Update.
 837         * tui/tui-data.h (struct tui_data_window)
 838         <first_data_item_displayed>: Declare new method.
 839
 840 2019-06-25  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 843         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 844         contents...
 845         (tui_initialize_static_data): ...here.
 846
 847 2019-06-25  Tom Tromey  <tom@tromey.com>
 848
 849         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 850         (tui_display_registers_from, tui_check_register_values): Update.
 851         (tui_display_register): Remove win_info parameter; update.
 852         (tui_get_register): Change type of parameters.
 853         * tui/tui-data.h (struct tui_data_element): Remove.
 854         (union tui_which_element) <data>: Remove.
 855         <data_window>: Change type.
 856         (struct tui_data_item_window): New.
 857         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 858         case.  Add assert.
 859         (~tui_data_item_window): New destructor.
 860         (free_content_elements): Remove DATA_ITEM_WIN case.
 861
 862 2019-06-25  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 865         Remove.
 866
 867 2019-06-25  Tom Tromey  <tom@tromey.com>
 868
 869         * tui/tui-data.h (struct tui_command_element): Remove.
 870         (union tui_which_element) <command>: Remove.
 871         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 872         assert.
 873         (free_content_elements): Remove CMD_WIN case.
 874
 875 2019-06-25  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-layout.c (tui_set_layout): Update.
 878         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 879         * tui/tui-data.c (layout_def): Update.
 880
 881 2019-06-25  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 884         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 885         (tui_source_window_base::set_new_height): Update.
 886         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 887         Update.
 888         (tui_set_locator_fullname, tui_set_locator_info)
 889         (tui_show_frame_info): Update.
 890         * tui/tui-source.c (tui_set_source_content)
 891         (tui_source_is_displayed): Update.
 892         * tui/tui-layout.c (show_source_disasm_command, show_data)
 893         (show_source_or_disasm_and_command): Update.
 894         * tui/tui-disasm.c (tui_set_disassem_content)
 895         (tui_get_begin_asm_address): Update.
 896         * tui/tui-data.h (struct tui_locator_element): Remove.
 897         (union tui_which_element) <locator>: Remove.
 898         (struct tui_locator_window): New.
 899         (tui_locator_win_info_ptr): Change return type.
 900         * tui/tui-data.c (_locator): Change type.
 901         (tui_locator_win_info_ptr): Change return type.
 902         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 903         (tui_alloc_content): Add assert.
 904
 905 2019-06-25  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui-winsource.c
 908         (tui_exec_info_window::maybe_allocate_content): New method.
 909         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 910         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 911         (make_source_or_disasm_window): Add cast.
 912         * tui/tui-data.h (union tui_which_element) <simple_string>:
 913         Remove.
 914         (struct tui_source_info): New.
 915         (struct tui_source_window_base) <execution_info>: Change type.
 916         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 917         case, and add assert.
 918         (tui_alloc_content): Add assert.
 919
 920 2019-06-25  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 923         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 924         * tui/tui-data.c (tui_alloc_win_info): Remove.
 925
 926 2019-06-25  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 929         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 930         can_highlight.
 931
 932 2019-06-25  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 935         make_visible_with_new_height method.
 936         (tui_win_info::make_visible_with_new_height): New method.
 937         (tui_source_window_base::do_make_visible_with_new_height)
 938         (tui_data_window::do_make_visible_with_new_height)
 939         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 940         (make_visible_with_new_height): Remove.
 941         (tui_resize_all, tui_adjust_win_heights): Use
 942         make_visible_with_new_height method.
 943         * tui/tui-data.h (struct tui_win_info)
 944         <do_make_visible_with_new_height, make_visible_with_new_height>:
 945         New methods.
 946         (struct tui_source_window_base, struct tui_data_window)
 947         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 948         methods.
 949
 950 2019-06-25  Tom Tromey  <tom@tromey.com>
 951
 952         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 953         method.
 954         (update_tab_width): Call update_tab_width method.
 955         * tui/tui-data.h (struct tui_win_info)
 956         (struct tui_source_window_base) <update_tab_width>: New methods.
 957
 958 2019-06-25  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 961         parameter.
 962         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 963         parameter.
 964         (tui_gen_win_info::make_visible): Update.
 965         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 966         parameter.
 967         * tui/tui-data.h (enum tui_box): New enum.
 968         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 969
 970 2019-06-25  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 973         init_and_make_win for EXEC_INFO_WIN.
 974         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 975         longer inline.
 976         (struct tui_win_info) <~tui_win_info>: Inline.
 977         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 978         Don't declare.
 979         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 980         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 981         Remove.
 982         (tui_initialize_static_data): Update.
 983         (~tui_gen_win_info): Handle more cleanup here.
 984         (~tui_source_window_base): Delete "execution_info".
 985         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 986
 987 2019-06-25  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-layout.c (make_command_window): Don't set
 990         can_highlight.
 991         (show_source_disasm_command): Call the reset method.
 992         (show_data): Don't set can_highlight.  Call the reset method.
 993         (tui_gen_win_info::reset): Rename from init_gen_win_info
 994         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 995         (show_source_or_disasm_and_command): Call the reset method.
 996         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 997         (struct tui_cmd_window): Set can_highlight.
 998
 999 2019-06-25  Tom Tromey  <tom@tromey.com>
1000
1001         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1002         from make_visible.
1003         (tui_make_visible, tui_make_invisible): Rewrite.
1004         (tui_win_info::make_visible): Remove.
1005         (tui_source_window_base::make_visible): Update.
1006         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1007         method.  Moved from...
1008         (struct tui_win_info) <make_visible>: ...here.
1009
1010 2019-06-25  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-winsource.c
1013         (tui_source_window_base::do_scroll_horizontal): Remove direction
1014         parameter.
1015         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1016         direction parameter.
1017         * tui/tui-win.c (tui_win_info::forward_scroll)
1018         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1019         (tui_win_info::right_scroll): Update.
1020         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1021         direction parameter.
1022         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1023         direction parameter.
1024         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1025         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1026         Remove direction parameter.
1027         (struct tui_source_window_base, struct tui_source_window)
1028         (struct tui_disasm_window, struct tui_data_window)
1029         (struct tui_cmd_window): Update.
1030
1031 2019-06-25  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-winsource.h (tui_set_exec_info_content)
1034         (tui_show_exec_info_content, tui_erase_exec_info_content)
1035         (tui_clear_exec_info_content, tui_update_exec_info): Change
1036         argument to tui_source_window_base.
1037         * tui/tui-winsource.c (tui_set_exec_info_content)
1038         (tui_show_exec_info_content, tui_erase_exec_info_content)
1039         (tui_clear_exec_info_content, tui_update_exec_info): Change
1040         argument to tui_source_window_base.
1041
1042 2019-06-25  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1045         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1046
1047 2019-06-25  Tom Tromey  <tom@tromey.com>
1048
1049         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1050         check.
1051
1052 2019-06-25  Tom Tromey  <tom@tromey.com>
1053
1054         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1055         type to void.
1056         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1057         type to void.
1058         * tui/tui-source.c (tui_set_source_content): Update.
1059         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1060
1061 2019-06-25  Tom Tromey  <tom@tromey.com>
1062
1063         * tui/tui-win.c (window_name_completer, tui_set_focus)
1064         (tui_all_windows_info): Use name method.
1065         * tui/tui-data.h (struct tui_gen_win_info)
1066         (struct tui_source_window, struct tui_disasm_window)
1067         (struct tui_data_window, struct tui_cmd_window) <name>: New
1068         method.
1069         (tui_win_name): Don't declare.
1070         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1071         (tui_win_name): Remove.
1072
1073 2019-06-25  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-winsource.h (tui_update_source_window)
1076         (tui_update_source_window_as_is): Change parameter type.
1077         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1078         to be a tui_source_window_base.
1079         (tui_update_source_window_as_is): Likewise.
1080         * tui/tui-win.c (make_visible_with_new_height): Update.
1081
1082 2019-06-25  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-winsource.c (tui_erase_source_content)
1085         (tui_show_source_content, tui_show_exec_info_content)
1086         (tui_erase_exec_info_content): Use refresh_window method.
1087         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1088         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1089         from tui_refresh_win.
1090         (tui_data_window::refresh_window): New method.
1091         (tui_win_info::refresh, tui_source_window_base::refresh)
1092         (tui_refresh_all): Use refresh_window method.
1093         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1094         method.
1095         * tui/tui-regs.c (tui_display_register): Call refresh_window
1096         method.
1097         * tui/tui-layout.c (show_source_disasm_command)
1098         (show_source_or_disasm_and_command): Call refresh_window method.
1099         * tui/tui-data.h (struct tui_gen_win_info)
1100         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1101         New method.
1102
1103 2019-06-25  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui.c (tui_rl_other_window, tui_enable)
1106         (tui_is_window_visible, tui_get_command_dimension): Update.
1107         * tui/tui-winsource.c (tui_update_source_window_as_is)
1108         (tui_clear_source_content, tui_erase_source_content)
1109         (tui_show_source_line, tui_source_window_base::refill)
1110         (tui_source_window_base::do_scroll_horizontal)
1111         (tui_source_window_base::set_is_exec_point_at)
1112         (tui_update_breakpoint_info, tui_set_exec_info_content)
1113         (tui_alloc_source_buffer, tui_line_is_displayed)
1114         (tui_addr_is_displayed): Update.
1115         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1116         (tui_check_and_display_highlight_if_needed)
1117         (tui_win_info::make_visible, tui_win_info::refresh)
1118         (tui_refresh_all): Update.
1119         * tui/tui-windata.c (tui_first_data_item_displayed)
1120         (tui_delete_data_content_windows, tui_erase_data_content)
1121         (tui_display_all_data, tui_data_window::refresh_all)
1122         (tui_check_data_values): Update.
1123         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1124         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1125         (tui_win_info::backward_scroll, tui_refresh_all_win)
1126         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1127         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1128         (tui_source_window_base::set_new_height)
1129         (tui_data_window::set_new_height)
1130         (make_invisible_and_set_new_height)
1131         (make_visible_with_new_height, new_height_ok)
1132         (parse_scrolling_args): Update.
1133         * tui/tui-stack.c (tui_show_frame_info): Update.
1134         * tui/tui-source.c (tui_set_source_content)
1135         (tui_set_source_content_nil, tui_source_is_displayed)
1136         (tui_source_window::do_scroll_vertical): Update.
1137         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1138         (tui_display_registers_from, tui_display_reg_element_at_line)
1139         (tui_check_register_values, tui_reg_command): Update.
1140         * tui/tui-layout.c (tui_default_win_height)
1141         (show_source_disasm_command, show_data, init_and_make_win)
1142         (show_source_or_disasm_and_command): Update.
1143         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1144         (tui_redisplay_readline, tui_mld_flush)
1145         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1146         (tui_getc): Update.
1147         * tui/tui-disasm.c (tui_set_disassem_content)
1148         (tui_disasm_window::do_scroll_vertical): Update.
1149         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1150         Now virtual.
1151         (struct tui_win_info): Derive from tui_gen_win_info.
1152         <~tui_win_info>: Mark as override.
1153         <generic>: Remove member.
1154         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1155         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1156         (~tui_data_window, ~tui_win_info)
1157         (tui_free_all_source_wins_content): Update.
1158         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1159
1160 2019-06-25  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-layout.c (init_and_make_win): Use new.
1163         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1164         destructor, initializers.
1165         (tui_alloc_generic_win_info): Don't declare.
1166         * tui/tui-data.c (_locator): Add argument to constructor.
1167         (source_win, disasm_win): New globals.
1168         (exec_info): Remove.
1169         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1170         Update.
1171         (tui_alloc_generic_win_info): Remove.
1172         (init_content_element): Use new.
1173         (tui_win_info::tui_win_info): Update.
1174         (free_content_elements) <case DATA_WIN>: Use delete.
1175
1176 2019-06-25  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1179         * tui/tui-windata.c (tui_first_data_item_displayed)
1180         (tui_delete_data_content_windows): Update.
1181         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1182         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1183         (tui_display_registers_from, tui_check_register_values): Update.
1184         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1185         pointer.
1186         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1187         window.
1188         (tui_free_data_content): Update.
1189         (free_content_elements) <case DATA_WIN>: Free the window.
1190
1191 2019-06-25  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1194         Update.
1195         * tui/tui-layout.c (make_command_window)
1196         (show_source_disasm_command, show_data, init_and_make_win)
1197         (show_source_or_disasm_and_command): Update.
1198         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1199         method.
1200         <can_highight, is_highlighted>: Now bool.
1201         (tui_set_win_highlight): Don't declare.
1202         * tui/tui-data.c (tui_set_win_highlight): Remove.
1203
1204 2019-06-25  Tom Tromey  <tom@tromey.com>
1205
1206         * tui/tui-wingeneral.c (make_visible): Remove check of window
1207         type.
1208
1209 2019-06-25  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-win.c (tui_win_info::max_height)
1212         (tui_cmd_window::max_height): New methods.
1213         (new_height_ok): Call max_height.
1214         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1215         <max_height>: New method.
1216
1217 2019-06-25  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-win.c (tui_source_window_base::set_new_height)
1220         (tui_data_window::set_new_height): New methods.
1221         (make_invisible_and_set_new_height): Call set_new_height method.
1222         * tui/tui-data.h (struct tui_win_info)
1223         (struct tui_source_window_base, struct tui_data_window)
1224         <set_new_height>: New method.
1225
1226 2019-06-25  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1229         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1230         tui_refresh_data_win.
1231         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1232         method.
1233         (tui_refresh_all_win): Call the refresh_all method.
1234         (tui_set_focus): Likewise.
1235         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1236         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1237         Likewise.
1238
1239 2019-06-25  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-winsource.h (tui_refill_source_window)
1242         (tui_set_is_exec_point_at): Don't declare.
1243         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1244         (tui_source_window_base::refill): Rename from
1245         tui_refill_source_window.
1246         (tui_source_window_base::do_scroll_horizontal): Update.
1247         (tui_source_window_base::set_is_exec_point_at): Rename from
1248         tui_set_is_exec_point_at.
1249         (tui_update_all_breakpoint_info): Update.
1250         * tui/tui-stack.c (tui_show_frame_info): Update.
1251         * tui/tui-layout.c (show_data): Add cast.
1252         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1253         * tui/tui-data.h (struct tui_source_window_base) <refill,
1254         set_is_exec_point_at>: New methods.
1255         (tui_source_windows, tui_add_to_source_windows): Update types.
1256         (tui_add_to_source_windows): Remove redundant declaration.
1257         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1258         (tui_source_windows): Change return type.
1259         (tui_clear_source_windows_detail): Update.
1260         (tui_add_to_source_windows): Change type of parameter.
1261         (tui_free_all_source_wins_content): Update.
1262
1263 2019-06-25  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-wingeneral.c (tui_win_info::refresh)
1266         (tui_source_window_base::refresh): New methods.
1267         (tui_refresh_all): Call the refresh method.
1268         * tui/tui-data.h (struct tui_win_info)
1269         (struct tui_source_window_base) <refresh>: New method.
1270
1271 2019-06-25  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui.h (tui_is_window_visible): Return bool.
1274         * tui/tui.c (tui_is_window_visible): Return bool.
1275         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1276         (tui_make_visible, tui_make_invisible)
1277         (tui_win_info::make_visible)
1278         (tui_source_window_base::make_visible, make_all_visible)
1279         (tui_make_all_visible, tui_make_all_invisible): Update.
1280         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1281         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1282         bool.
1283         (struct tui_win_info, struct tui_source_window_base)
1284         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1285         * tui/tui-data.c (tui_init_generic_part): Update.
1286
1287 2019-06-25  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1290         (tui_source_window_base::make_visible): New methods.
1291         (make_all_visible): Make method call.
1292         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1293         (struct tui_source_window_base, struct tui_cmd_window): Override
1294         make_visible.
1295         (tui_win_is_source_type): Don't declare.
1296         * tui/tui-data.c (tui_win_is_source_type): Remove.
1297
1298 2019-06-25  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1301         NULL check.
1302
1303 2019-06-25  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1306         Inline constructor.  Add initializers for members.
1307         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1308         constructors; now inline in class.
1309
1310 2019-06-25  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-regs.c (tui_show_registers): Update.
1313         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1314         bool.
1315         * tui/tui-data.c (tui_data_window::clear_detail)
1316         (tui_data_window): Update.
1317
1318 2019-06-25  Tom Tromey  <tom@tromey.com>
1319
1320         * tui/tui-windata.c (tui_display_all_data)
1321         (tui_display_data_from_line, tui_display_data_from)
1322         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1323         Update.
1324         * tui/tui-regs.c (tui_last_regs_line_no)
1325         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1326         (tui_show_registers, tui_show_register_group)
1327         (tui_display_registers_from, tui_display_reg_element_at_line)
1328         (tui_display_registers_from_line, tui_check_register_values)
1329         (tui_reg_next, tui_reg_prev): Update.
1330         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1331         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1332         tui_data_window.
1333         (struct tui_win_info) <detail>: Remove.  Add new fields from
1334         tui_data_info.
1335         (TUI_DATA_WIN): Add cast.
1336         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1337         (~tui_data_window): Simplify.
1338
1339 2019-06-25  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-layout.c (show_source_disasm_command)
1342         (show_source_or_disasm_and_command): Update.
1343         * tui/tui-io.c (update_cmdwin_start_line)
1344         (tui_redisplay_readline): Update.
1345         * tui/tui-data.h (struct tui_command_info): Remove.
1346         (struct tui_win_info) <detail>: Remove command_info member.
1347         (struct tui_data_window) <start_line>: New member, from
1348         tui_command_info.
1349         (TUI_CMD_WIN): Add casts.
1350
1351 2019-06-25  Tom Tromey  <tom@tromey.com>
1352
1353         * tui/tui-winsource.c (tui_update_source_window)
1354         (tui_refill_source_window)
1355         (tui_source_window_base::do_scroll_horizontal)
1356         (tui_update_breakpoint_info, tui_set_exec_info_content)
1357         (tui_show_exec_info_content, tui_erase_exec_info_content)
1358         (tui_clear_exec_info_content): Update.
1359         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1360         Update.
1361         * tui/tui-win.c (make_invisible_and_set_new_height)
1362         (make_visible_with_new_height): Update.
1363         * tui/tui-source.c (tui_set_source_content)
1364         (tui_show_symtab_source): Update.
1365         * tui/tui-layout.c (extract_display_start_addr)
1366         (show_source_disasm_command, show_data)
1367         (make_source_or_disasm_window)
1368         (show_source_or_disasm_and_command): Update.
1369         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1370         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1371         "gdbarch".
1372         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1373         to tui_source_window_base.
1374         (struct tui_win_info) <detail>: Remove source_info member.
1375         (struct tui_source_window_base) <has_locator>: Inline.
1376         Move contents from tui_source_info; rename has_locator member to
1377         m_has_locator.
1378         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1379         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1380         header file.
1381         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1382         Simplify.
1383         (tui_free_all_source_wins_content): Cast to
1384         tui_source_window_base.
1385
1386 2019-06-25  Tom Tromey  <tom@tromey.com>
1387
1388         * tui/tui-win.c (make_invisible_and_set_new_height)
1389         (make_visible_with_new_height): Call has_locator method.
1390         * tui/tui-layout.c (show_source_disasm_command, show_data)
1391         (show_source_or_disasm_and_command): Update for bool change.
1392         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1393         (tui_win_info) <has_locator>: New method.
1394         (struct tui_source_window_base) <has_locator>: New method.
1395         (tui_win_has_locator): Don't declare.
1396         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1397         from tui_win_has_locator.
1398         (tui_source_window_base): Use false, not FALSE.
1399
1400 2019-06-25  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1403         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1404         clear_detail method directly.
1405         (tui_clear_win_detail): Remove.
1406
1407 2019-06-25  Tom Tromey  <tom@tromey.com>
1408
1409         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1410         "this", not TUI_DISASM_WIN.
1411
1412 2019-06-25  Tom Tromey  <tom@tromey.com>
1413
1414         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1415         declare.
1416         * tui/tui-winsource.c
1417         (tui_source_window_base::do_scroll_horizontal): Rename from
1418         tui_horizontal_source_scroll.
1419         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1420         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1421         from tui_vertical_data_scroll.
1422         * tui/tui-win.h (tui_scroll): Don't declare.
1423         * tui/tui-win.c (tui_win_info::forward_scroll)
1424         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1425         (tui_win_info::right_scroll): Rename and update.
1426         (tui_scroll_forward_command, tui_scroll_backward_command)
1427         (tui_scroll_left_command, tui_scroll_right_command): Update.
1428         (tui_scroll): Remove.
1429         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1430         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1431         from tui_vertical_source_scroll.
1432         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1433         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1434         from tui_vertical_disassem_scroll.
1435         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1436         do_scroll_horizontal>: New methods.
1437         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1438         Likewise.
1439         (struct tui_source_window_base): Add do_scroll_horizontal.
1440         (struct tui_source_window, struct tui_disasm_window): Add
1441         do_scroll_vertical.
1442         (struct tui_data_window, struct tui_cmd_window): Add
1443         do_scroll_horizontal and do_scroll_vertical.
1444         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1445
1446 2019-06-25  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-data.h (struct tui_source_window_base): New struct.
1449         (struct tui_source_window): Derive from tui_source_window_base.
1450         (struct tui_disasm_window): New struct.
1451         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1452         from tui_source_window::clear_detail.
1453         (tui_source_window_base): Rename from tui_source_window.
1454         (~tui_source_window_base): Rename from ~tui_source_window.
1455         (tui_alloc_win_info): Create a tui_disasm_window.
1456
1457 2019-06-25  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-data.h (struct tui_source_window)
1460         (struct tui_data_window): Declare destructors.
1461         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1462         destructors.
1463         (tui_win_info): Simplify.
1464
1465 2019-06-25  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-winsource.c (tui_display_main)
1468         (tui_update_source_windows_with_addr)
1469         (tui_update_all_breakpoint_info): Update.
1470         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1471         (new_height_ok, parse_scrolling_args): Update.
1472         * tui/tui-stack.c (tui_show_frame_info): Update.
1473         * tui/tui-data.h (struct tui_list): Remove.
1474         (tui_source_windows): Return a reference to a std::vector.
1475         * tui/tui-data.c (source_windows): Now a std::vector.
1476         (tui_source_windows): Change return type.
1477         (tui_clear_source_windows): Rewrite.
1478         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1479         (tui_free_all_source_wins_content): Rewrite.
1480
1481 2019-06-25  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1484         (struct tui_data_window, struct tui_cmd_window): Declare
1485         clear_detail method.
1486         * tui/tui-data.c (tui_source_window::clear_detail)
1487         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1488         methods.
1489         (tui_clear_win_detail): Simplify.
1490
1491 2019-06-25  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-layout.c (make_source_window, make_disasm_window)
1494         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1495         Return the new window.
1496         (show_source_disasm_command, show_data)
1497         (show_source_or_disasm_and_command): Update.
1498
1499 2019-06-25  Tom Tromey  <tom@tromey.com>
1500
1501         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1502         parameter.  Return the new window.
1503         (show_source_disasm_command): Update and remove NULL check.
1504         (show_source_or_disasm_and_command): Update.
1505
1506 2019-06-25  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1509
1510 2019-06-25  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui-data.h (struct tui_win_info): Make constructor
1513         protected.  Make destructor virtual.  Add initializers.
1514         (tui_source_window, tui_data_window, tui_cmd_window): New
1515         classes.
1516         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1517         constructor.  Add "type" parameter.
1518         (tui_source_window, tui_data_window, tui_cmd_window): New
1519         constructors.
1520         (tui_alloc_win_info): Instantiate the appropriate subclass.
1521
1522 2019-06-25  Tom Tromey  <tom@tromey.com>
1523
1524         * tui/tui-win.c (tui_resize_all): Use delete.
1525         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1526         destructor.
1527         (tui_free_window): Don't declare.
1528         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1529         Update.
1530
1531 2019-06-25  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-data.h (struct tui_win_info): Add constructor.
1534         * tui/tui-data.c (tui_alloc_win_info): Use new.
1535         (tui_free_window): Use delete.
1536
1537 2019-06-22  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1540         declare.
1541         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1542
1543 2019-06-22  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1546         declare.
1547         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1548
1549 2019-06-22  Tom de Vries  <tdevries@suse.de>
1550
1551         * dwarf2read.c (create_addrmap_from_aranges)
1552         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1553         instead of '%zu'.
1554
1555 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1556
1557         * dwarf2read.h (dwarf2_section_info_def): Remove.
1558         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1559         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1560         std::vector<dwarf2_section_info>.
1561         (struct dwo_file) <~dwo_file>: Remove.
1562         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1563         types field.
1564         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1565         (dwarf2_read_debug_names): Likewise.
1566         (create_debug_types_hash_table): Change parameter type to
1567         array_view, adjust code accordingly.
1568         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1569         (partial_die_info::fixup): Likewise.
1570         (determine_prefix): Likewise.
1571         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1572
1573 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1574
1575         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1576         gdb_bfd_ref_ptr.
1577         <~dwo_file>: Remove call to gdb_bfd_unref.
1578         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1579         gdb_bfd_ref_ptr::get.
1580
1581 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1582
1583         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1584         type to htab_up.
1585         * dwarf2read.c (struct dwo_file): Initialize fields.
1586         <~dwo_file>: New.
1587         (free_dwo_file): Remove, move content to ~dwo_file.
1588         (struct dwo_file_deleter): Remove.
1589         (dwo_file_up>: Remove custom deleter.
1590         (free_dwo_files): Remove.
1591         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1592         dwo_files.
1593         (process_skeletonless_type_units): Call unique_ptr::get.
1594         (allocate_dwo_file_hash_table): Add deleter to created hash
1595         table.  Change return type to htab_up.
1596         (lookup_dwo_file_slot): Don't memset dwo_file, call
1597         unique_ptr::get.
1598         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1599         (create_dwo_unit_in_dwp_v2): Likewise.
1600         (open_and_init_dwo_file): Likewise.
1601         (free_dwo_file_from_slot): Remove.
1602
1603 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1604
1605         * dwarf2read.h (struct dwarf2_section_info) <readin,
1606         is_virtual>: Change type to bool.
1607         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1608         true instead of 1.
1609
1610 2019-06-19  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-data.h (tui_init_content_element): Don't declare.
1613
1614 2019-06-19  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-data.h (tui_init_win_info): Don't declare.
1617
1618 2019-06-19  Tom de Vries  <tdevries@suse.de>
1619
1620         * dwarf2read.h (abstract_to_concrete): Change type to
1621         std::unordered_map<sect_offset, std::vector<sect_offset>,
1622         gdb::hash_enum<sect_offset>>.
1623
1624 2019-06-19  Tom Tromey  <tromey@adacore.com>
1625
1626         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1627         EVAL_AVOID_SIDE_EFFECTS specially.
1628
1629 2019-06-19  Tom Tromey  <tromey@adacore.com>
1630
1631         * source-cache.c (highlighter): New global.
1632         (source_cache::get_source_lines): Create a highlighter on demand.
1633
1634 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1635
1636         * defs.h (deprecated_interactive_hook): Delete declaration.
1637         * interps.c (clear_interpreter_hooks): Remove use of
1638         deprecated_interactive_hook.
1639         * top.c (deprecated_interactive_hook): Delete definition.
1640         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1641
1642 2019-06-18  Tom de Vries  <tdevries@suse.de>
1643
1644         PR gdb/24515
1645         * dwarf2read.h (abstract_to_concrete): Change type from
1646         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1647         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1648         * dwarf2read.c (read_variable): Update.
1649         (dwarf2_fetch_die_loc_sect_off): Update.
1650
1651 2019-06-17  Tom de Vries  <tdevries@suse.de>
1652
1653         PR gdb/24617
1654         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1655         accessing parent[parent_len - 1].
1656
1657 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1658
1659         PR gdb/24364
1660         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1661         call dtrace_process_dof with NULL dof.
1662
1663 2019-06-16  Tom de Vries  <tdevries@suse.de>
1664
1665         PR gdb/24445
1666         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1667
1668 2019-06-16  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1671         (make_all_visible): Use address of member.
1672
1673 2019-06-16  Tom Tromey  <tom@tromey.com>
1674
1675         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1676         (tui_free_window, free_content, free_content_elements): Remove
1677         unnecessary cast.
1678         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1679         cast.
1680         * tui/tui-regs.c (tui_show_register_group)
1681         (tui_display_registers_from, tui_display_reg_element_at_line):
1682         Remove unnecessary cast.
1683
1684 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1685
1686         * linux-nat.c (normal_mask): Delete.
1687         (_initialize_linux_nat): Don't initialise normal_mask.
1688
1689 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1690
1691         PR gdb/24445
1692         * dwarf-index-write.h (write_psymtabs_to_index): Add
1693         dwz_basename parameter.
1694         * dwarf-index-write.c (write_gdbindex): Move file writing to
1695         write_gdbindex_1.  Change return type void.
1696         (assert_file_size): Move up, remove filename parameter.
1697         (write_gdbindex_1): New function.
1698         (write_debug_names): Change return type to void, call
1699         assert_file_size.
1700         (struct index_wip_file): New struct.
1701         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1702         file logic to index_wip_file.  Write index for dwz file if
1703         needed.
1704         (save_gdb_index_command): Pass basename of dwz file, if present.
1705         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1706         build-id of dwz file, if present.
1707         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1708         (dwarf2_get_dwz_file): Likewise.
1709         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1710         (dwarf2_get_dwz_file): Likewise.
1711
1712 2019-06-16  Tom Tromey  <tom@tromey.com>
1713
1714         * coffread.c (process_coff_symbol): Use xstrdup.
1715         * value.c (create_internalvar): Use xstrdup.
1716
1717 2019-06-16  Tom Tromey  <tom@tromey.com>
1718
1719         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1720         * breakpoint.c (stopin_command, stopat_command)
1721         (until_break_command, decode_location_default): Remove unnecessary
1722         cast.
1723         * utils.c (subset_compare): Remove unnecessary cast.
1724         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1725         cast.
1726         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1727         cast.
1728         * infcmd.c (path_command): Remove unnecessary cast.
1729         * coffread.c (decode_type): Remove unnecessary cast.
1730         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1731         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1732         * tui/tui-stack.c (tui_show_locator_content)
1733         (tui_show_frame_info): Remove unnecessary cast.
1734         * tui/tui-win.c (tui_scroll_forward_command)
1735         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1736         (parse_scrolling_args): Remove unnecessary cast.
1737         * tui/tui-data.c (init_win_info, tui_del_window)
1738         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1739         (free_content_elements): Remove unnecessary cast.
1740         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1741         unnecessary cast.
1742         * tui/tui-source.c (tui_set_source_content)
1743         (tui_vertical_source_scroll): Remove unnecessary cast.
1744         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1745         cast.
1746         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1747         * tui/tui-regs.c (tui_display_registers_from)
1748         (tui_display_register): Remove unnecessary cast.
1749         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1750         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1751         (make_visible): Remove unnecessary cast.
1752         * tui/tui-winsource.c (tui_erase_source_content)
1753         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1754         unnecessary cast.
1755         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1756         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1757         * stabsread.c (read_type, read_array_type, read_range_type):
1758         Remove unnecessary cast.
1759         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1760         (parse_symbol, parse_type, upgrade_type, parse_external)
1761         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1762         unnecessary cast.
1763         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1764
1765 2019-06-16  Tom Tromey  <tom@tromey.com>
1766
1767         * tui/tui-data.c (tui_alloc_generic_win_info)
1768         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1769         checks.
1770
1771 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1772             Andrew Burgess  <andrew.burgess@embecosm.com>
1773
1774         * f-typeprint.c (f_print_type): Don't return early for not
1775         associated or not allocated types.
1776         (f_type_print_varspec_suffix): Add print_rank parameter and print
1777         ranks of array types in case they dangling.
1778         (f_type_print_base): Add print_rank parameter.
1779
1780 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1781
1782         * NEWS: Mention new MI commands.
1783         * break-catch-throw.c (enum exception_event_kind): Move to
1784         breakpoint.h.
1785         (print_mention_exception_catchpoint): Output text as a single
1786         message.
1787         (catch_exception_command_1): Rename to...
1788         (catch_exception_event): ...this, make non-static, update header
1789         command, and change some parameter types.
1790         (catch_catch_command): Update for changes to
1791         catch_exception_command_1.
1792         (catch_throw_command): Likewise.
1793         (catch_rethrow_command): Likewise.
1794         * breakpoint.c (enum exception_event_kind): Delete.
1795         * breakpoint.h (enum exception_event_kind): Moved here from
1796         break-catch-throw.c.
1797         (catch_exception_event): Declare.
1798         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1799         (mi_cmd_catch_throw): New function.
1800         (mi_cmd_catch_rethrow): New function.
1801         (mi_cmd_catch_catch): New function.
1802         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1803         'catch-catch' entries.
1804         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1805         (mi_cmd_catch_rethrow): Declare.
1806         (mi_cmd_catch_catch): Declare.
1807
1808 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1809
1810         * annotate.c (annotate_source_line): Change return type to void,
1811         update implementation to match.
1812         * annotate.h (annotate_source_line): Change return type to void,
1813         update header comment.
1814         * stack.c (print_frame_info): Don't change what frame information
1815         is printed based on whether annotations are on or not.
1816
1817 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1820         (annotate_source): Make static.
1821         (annotate_source_line): Moved from source.c and renamed from
1822         identify_source_line.  Update the return type.
1823         * annotate.h (annotate_source): Delete declaration.
1824         (annotate_source_line): Declaration moved from source.h, and
1825         renamed from identify_source_line.  Return type updated.
1826         * source.c (identify_source_line): Moved to annotate.c and renamed
1827         to annotate_source_line.
1828         (info_line_command): Remove check of annotation_level.
1829         * source.h (identify_source_line): Move declaration to annotate.h
1830         and rename to annotate_source_line.
1831         * stack.c: Add 'annotate.h' include.
1832         (print_frame_info): Remove check of annotation_level before
1833         calling annotate_source_line.
1834
1835 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1836
1837         * source-cache.c (source_cache::get_plain_source_lines): Use
1838         open_source_file_with_line_charpos instead of just
1839         open_source_file, remove call to find_source_lines.
1840         (source_cache::get_source_lines): Likewise.
1841         * source.c (find_source_lines): Make static.
1842         (get_filename_and_charpos): Renamed into...
1843         (open_source_file_with_line_charpos): ..this along with changes to
1844         return a scoped_fd, and some other minor clean ups.
1845         (identify_source_line): Use open_source_file_with_line_charpos.
1846         (search_command_helper): Use open_source_file_with_line_charpos
1847         instead of just open_source_file, remove call to
1848         find_source_lines.
1849         * source.h (open_source_file_with_line_charpos): Declare new
1850         function.
1851         (find_source_lines): Delete declaration.
1852
1853 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * source.c (get_filename_and_charpos): Remove fullname
1856         parameter.
1857         (identify_source_line): Update call to get_filename_and_charpos.
1858
1859 2019-06-14  Tom Tromey  <tromey@adacore.com>
1860
1861         PR gdb/24502:
1862         * ui-style.h (skip_ansi_escape): Update comment.
1863         * ui-file.h (class no_terminal_escape_file): New class.
1864         * ui-file.c (no_terminal_escape_file::write)
1865         (no_terminal_escape_file::puts): New methods.
1866         * cli/cli-logging.c (handle_redirections): Use
1867         no_terminal_escape_file.
1868
1869 2019-06-14  Tom Tromey  <tromey@adacore.com>
1870
1871         * NEWS: Move convenience variable news above Python news.
1872
1873 2019-06-14  Tom Tromey  <tom@tromey.com>
1874
1875         * gnulib: Move directory to top-level.
1876         * configure.ac: Don't configure gnulib.
1877         * configure: Rebuild.
1878         * common/common-defs.h: Use new path to gnulib.
1879         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1880         (GNULIB_H): Remove.
1881         (INCGNU): Look in new gnulib location.
1882         (HFILES_NO_SRCDIR): Remove gnulib files.
1883         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1884         (generated_files): Remove GNULIB_H.
1885         ($(LIBGNU), all-lib): Remove targets.
1886         (distclean): Don't mention GNULIB_BUILDDIR.
1887         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1888
1889 2019-06-14  Tom Tromey  <tromey@adacore.com>
1890
1891         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1892         Warn if symbol file does not provide any symbols.
1893
1894 2019-06-14  Tom Tromey  <tromey@adacore.com>
1895
1896         * source.c (find_and_open_source): Respect basenames_may_differ.
1897
1898 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * annotate.c (annotate_breakpoints_invalid): Make use of
1901         scoped_restore_terminal_state.
1902         (annotate_frames_invalid): Likewise.
1903
1904 2019-06-14  Tom Tromey  <tromey@adacore.com>
1905
1906         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1907         allow assignment to an internalvar.
1908
1909 2019-06-14  Tom Tromey  <tromey@adacore.com>
1910
1911         * ada-lex.l: Allow "_" in attribute names.
1912
1913 2019-06-14  Tom Tromey  <tromey@adacore.com>
1914
1915         PR gdb/24653:
1916         * regcache.c (registers_changed): Don't call alloca.
1917         * top.c (execute_command): Don't call alloca.
1918
1919 2019-06-13  Pedro Alves  <palves@redhat.com>
1920
1921         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1922         'expression'.  When parsing an expression, error out if there's
1923         junk after "unlimited".
1924         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1925         (do_set_command): Adjust calls to is_unlimited_literal.
1926
1927 2019-06-13  Pedro Alves  <palves@redhat.com>
1928
1929         * compile/compile.c (make_compile_options_def_group): Add braces
1930         around array_view initializer.
1931         * thread.c (make_thread_apply_all_options_def_group)
1932         (make_thread_apply_all_options_def_group): Likewise.
1933
1934 2019-06-13  Pedro Alves  <palves@redhat.com>
1935
1936         * NEWS (New commands): Mention "maint test-options
1937         require-delimiter", "maint test-options unknown-is-error", "maint
1938         test-options unknown-is-operand" and "maint show
1939         test-options-completion-result".
1940         (New command options, command completion): New section.
1941         (Completion improvements): New section.
1942         Mention that you can abbreviate "unlimited".
1943
1944 2019-06-13  Pedro Alves  <palves@redhat.com>
1945
1946         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1947         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1948         * unittests/cli-utils-selftests.c (test_parse_flags)
1949         (test_parse_flags_qcs): Delete.
1950         (test_cli_utils): Don't call deleted functions.
1951
1952 2019-06-13  Pedro Alves  <palves@redhat.com>
1953
1954         * thread.c: Include "cli/cli-option.h".
1955         (tp_array_compar_ascending): Global.
1956         (tp_array_compar): Delete function.
1957         (tp_array_compar_ascending, tp_array_compar_descending): New
1958         functions.
1959         (ascending_option_def, qcs_flag_option_def)
1960         (thr_qcs_flags_option_defs)
1961         (make_thread_apply_all_options_def_group)
1962         (make_thread_apply_options_def_group): New.
1963         (thread_apply_all_command): Use gdb::option::process_options.
1964         (thread_apply_command_completer)
1965         (thread_apply_all_command_completer): New.
1966         (thread_apply_command): Use gdb::option::process_options.
1967         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1968         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1969         to generate help text of "thread apply".  Adjust "taas"'s help.
1970         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1971         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1972
1973 2019-06-13  Pedro Alves  <palves@redhat.com>
1974
1975         * thread.c (thread_apply_command): Check for invalid TID with
1976         isdigit instead of !isalpha.
1977
1978 2019-06-13  Pedro Alves  <palves@redhat.com>
1979
1980         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1981         (validate_flags_qcs): New.
1982         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1983         (validate_flags_qcs): Declare.
1984         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1985         (make_frame_apply_options_def_group): New.
1986         (frame_apply_command_count): Process options with
1987         gdb::option::process_options.
1988         (frame_apply_completer): New.
1989         (frame_apply_level_completer, frame_apply_all_completer)
1990         (frame_apply_completer): New.
1991         (_initialize_stack): Update help of "frame apply", "frame apply
1992         level", "frame apply all" and "faas" to mention supported options
1993         and install command completers.
1994         * stack.h (frame_apply_all_completer): Declare.
1995         * thread.c: Include "stack.h".
1996         (tfaas_command): Add "--".
1997         (_initialize_thread): Update help "tfaas" to mention supported
1998         options and install command completer.
1999
2000 2019-06-13  Pedro Alves  <palves@redhat.com>
2001
2002         * completer.c (complete_nested_command_line): New.
2003         (gdb_completion_word_break_characters_throw): Add assertion.
2004         * completer.h (complete_nested_command_line): Declare.
2005
2006 2019-06-13  Pedro Alves  <palves@redhat.com>
2007
2008         * stack.c (parse_backtrace_qualifiers): New.
2009         (backtrace_command): Use it.
2010         (backtrace_command_completer): Complete on qualifiers.
2011
2012 2019-06-13  Pedro Alves  <palves@redhat.com>
2013
2014         * frame.c: Include "cli/cli-option.h.
2015         (user_set_backtrace_options): New.
2016         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2017         Delete.
2018         (get_prev_frame): Adjust.
2019         (boolean_option_def, uinteger_option_def)
2020         (set_backtrace_option_defs): New.
2021         (_initialize_frame): Adjust and use
2022         gdb::option::add_setshow_cmds_for_options to install "set
2023         backtrace past-main" and "set backtrace past-entry".
2024         * frame.h: Include "cli/cli-option.h".
2025         (struct frame_print_options): Forward declare.
2026         (print_frame_arguments_all, print_frame_arguments_scalars)
2027         (print_frame_arguments_none): Declare.
2028         (print_entry_values): Delete declaration.
2029         (struct frame_print_options, user_frame_print_options): New.
2030         (struct set_backtrace_options): New.
2031         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2032         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2033         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2034         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2035         (list_args_or_locals): Add frame_print_options parameter.
2036         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2037         * python/py-framefilter.c (enumerate_args): Pass down
2038         USER_FRAME_PRINT_OPTIONS.
2039         * stack.c: Include "cli/cli-option.h".
2040         (print_frame_arguments_all, print_frame_arguments_scalars)
2041         (print_frame_arguments_none): Declare.
2042         (print_raw_frame_arguments, print_entry_values): Delete.
2043         (user_frame_print_options): New.
2044         (boolean_option_def, enum_option_def, frame_print_option_defs):
2045         New.
2046         (struct backtrace_cmd_options): New.
2047         (bt_flag_option_def): New.
2048         (backtrace_command_option_defs): New.
2049         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2050         (print_frame_arg, read_frame_arg, print_frame_args)
2051         (print_frame_info, print_frame): Add frame_print_options parameter
2052         and use it.
2053         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2054         (backtrace_command_1): Add frame_print_options and
2055         backtrace_cmd_options parameters and use them.
2056         (make_backtrace_options_def_group): New.
2057         (backtrace_command): Process command options with
2058         gdb::option::process_options.
2059         (backtrace_command_completer): New.
2060         (_initialize_stack): Extend "backtrace"'s help to mention
2061         supported options.  Install completer for "backtrace".
2062         Install some settings commands with add_setshow_cmds_for_options.
2063
2064 2019-06-13  Pedro Alves  <palves@redhat.com>
2065
2066         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2067         and that "set/show print raw frame-arguments" are now deprecated.
2068
2069         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2070         command.
2071         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2072         * stack.c (_initialize_stack): Install "set/show print
2073         raw-frame-arguments", and deprecate "set/show print raw
2074         frame-arguments".
2075         * valprint.c (_initialize_valprint): Deprecate "set/show print
2076         raw".
2077
2078 2019-06-13  Pedro Alves  <palves@redhat.com>
2079
2080         * compile/compile.c (struct compile_options): New.
2081         (compile_flag_option_def, compile_command_option_defs)
2082         (make_compile_options_def_group): New.
2083         (compile_file_command): Handle options with
2084         gdb::option::process_options.
2085         (compile_file_command_completer): New function.
2086         (compile_code_command): Handle options with
2087         gdb::option::process_options.
2088         (compile_code_command_completer): New function.
2089         (_initialize_compiler): Install completers for "compile code" and
2090         "compile file".  Mention available options in "compile code" and
2091         "compile code"'s help.
2092         * completer.c (advance_to_completion_word): New, factored out from
2093         ...
2094         (advance_to_expression_complete_word_point): ... this.
2095         (advance_to_filename_complete_word_point): New.
2096         * completer.h (advance_to_filename_complete_word_point): New
2097         declaration.
2098
2099 2019-06-13  Pedro Alves  <palves@redhat.com>
2100
2101         * compile/compile.c: Include "cli/cli-option.h".
2102         (compile_print_value): Scope data pointer is now a
2103         value_print_options pointer; adjust.
2104         (compile_print_command): Process options.  Scope data pointer is
2105         now a value_print_options pointer; adjust.
2106         (_initialize_compile): Update "compile print"'s help to include
2107         supported options.  Install a completer for "compile print".
2108         * cp-valprint.c (show_vtblprint, show_objectprint)
2109         (show_static_field_print): Delete.
2110         (_initialize_cp_valprint): Don't install "set print
2111         static-members", "set print vtbl", "set print object" here.
2112         * printcmd.c: Include "cli/cli-option.h" and
2113         "common/gdb_optional.h".
2114         (print_command_parse_format): Rework to fill in a
2115         value_print_options instead of a format_data.
2116         (print_value): Change parameter type from format_data pointer to
2117         value_print_options reference.  Adjust.
2118         (print_command_1): Process options.  Adjust to pass down a
2119         value_print_options.
2120         (print_command_completer): New.
2121         (_initialize_printcmd): Install print_command_completer as
2122         handle_brkchars completer for the "print" command.  Update
2123         "print"'s help to include supported options.
2124         * valprint.c: Include "cli/cli-option.h".
2125         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2126         here from cp-valprint.c.
2127         (boolean_option_def, uinteger_option_def)
2128         (value_print_option_defs, make_value_print_options_def_group):
2129         New.  Use gdb::option::add_setshow_cmds_for_options to install
2130         "set print elements", "set print null-stop", "set print repeats",
2131         "set print pretty", "set print union", "set print array", "set
2132         print address", "set print symbol", "set print array-indexes".
2133         * valprint.h: Include <string> and "cli/cli-option.h".
2134         (make_value_print_options_def_group): Declare.
2135         (print_value): Change parameter type from format_data pointer to
2136         value_print_options reference.
2137         (print_command_completer): Declare.
2138
2139 2019-06-13  Pedro Alves  <palves@redhat.com>
2140
2141         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2142         (COMMON_SFILES): Add maint-test-settings.c.
2143         * cli/cli-decode.c (boolean_enums): New global, factored out from
2144         ...
2145         (add_setshow_boolean_cmd): ... here.
2146         * cli/cli-decode.h (boolean_enums): Declare.
2147         * cli/cli-option.c: New file.
2148         * cli/cli-option.h: New file.
2149         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2150         factored out from ...
2151         (parse_cli_boolean_value(const char *)): ... this.
2152         (is_unlimited_literal): Change parameter type to pointer to
2153         pointer.  Adjust and advance ARG pointer.
2154         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2155         (parse_cli_var_enum): New, factored out from ...
2156         (do_set_command): ... this.  Adjust.
2157         * cli/cli-setshow.h (parse_cli_boolean_value)
2158         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2159         (parse_cli_var_enum): Declare.
2160         * cli/cli-utils.c: Include "cli/cli-option.h".
2161         (get_ulongest): New.
2162         * cli/cli-utils.h (get_ulongest): Declare.
2163         (check_for_argument): New overloads.
2164         * maint-test-options.c: New file.
2165
2166 2019-06-13  Pedro Alves  <palves@redhat.com>
2167
2168         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2169         parse a range if "-" is at the end of the string.
2170
2171 2019-06-13  Pedro Alves  <palves@redhat.com>
2172
2173         * cli/cli-setshow.c (parse_auto_binary_operation)
2174         (parse_cli_boolean_value): Don't allow "o".
2175
2176 2019-06-13  Pedro Alves  <palves@redhat.com>
2177
2178         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2179         * NEWS: Mention maint test-settings KIND.
2180         * maint-test-settings.c: New file.
2181
2182 2019-06-13  Pedro Alves  <palves@redhat.com>
2183
2184         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2185         completer.
2186         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2187         "set" completers.
2188
2189 2019-06-13  Pedro Alves  <palves@redhat.com>
2190
2191         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2192         after item.
2193
2194 2019-06-13  Pedro Alves  <palves@redhat.com>
2195
2196         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2197
2198 2019-06-13  Pedro Alves <palves@redhat.com>
2199
2200         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2201         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2202         call.
2203         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2204         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2205         calls.
2206         (check_for_argument): Skip spaces after argument.
2207
2208 2019-06-13  Pedro Alves  <palves@redhat.com>
2209
2210         * thread.c (thread_apply_command): Adjust TID parsing.
2211         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2212         detected before end of string.
2213         (tid_is_in_list): Error out if LIST is invalid.
2214
2215 2019-06-13  Pedro Alves  <palves@redhat.com>
2216
2217         * completer.c (complete_line_internal_1): Rewind completion word
2218         point.
2219         (completion_tracker::advance_custom_word_point_by): Change
2220         parameter type to int.
2221         * completer.h (completion_tracker::advance_custom_word_point_by):
2222         Likewise.
2223
2224 2019-06-13  Pedro Alves  <palves@redhat.com>
2225
2226         * completer.c (advance_to_completion_word): Handle delimiters.
2227
2228 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2229
2230         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2231
2232 2019-06-11  Tom Tromey  <tom@tromey.com>
2233
2234         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2235         (xmalloc_failed): Move to alloc.c.
2236         * alloc.c: New file.
2237         * Makefile.in (COMMON_SFILES): Add alloc.c.
2238
2239 2019-06-11  Tom Tromey  <tom@tromey.com>
2240
2241         * nat/linux-waitpid.c: Don't include server.h.
2242         (linux_debug): Remove.
2243         (my_waitpid): Update.
2244
2245 2019-06-11  Tom Tromey  <tromey@adacore.com>
2246
2247         * infcall.c (_initialize_infcall): Remove trailing newline from
2248         help.
2249         * user-regs.c (_initialize_user_regs): Remove trailing newline
2250         from help.
2251         * typeprint.c (_initialize_typeprint): Remove trailing newline
2252         from help.
2253         * reverse.c (_initialize_reverse): Remove trailing newlines from
2254         help.
2255         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2256         from help.
2257         * language.c (add_set_language_command): Remove trailing newline
2258         from help.
2259         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2260         help.
2261         * disasm.c (_initialize_disasm): Remove trailing newline from
2262         help.
2263         * top.c (init_main): Remove trailing newline from help.
2264         * interps.c (_initialize_interpreter): Remove trailing newline
2265         from help.
2266         * btrace.c (_initialize_btrace): Remove trailing newlines from
2267         help.
2268         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2269         from help.
2270         * python/python.c (_initialize_python): Remove trailing newline
2271         from help.
2272         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2273         help.
2274         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2275         from help.  Reformat some text.
2276         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2277         from help.
2278         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2279         newline from help.
2280
2281 2019-06-11  Tom Tromey  <tromey@adacore.com>
2282
2283         * darwin-nat.c (darwin_decode_exception_message)
2284         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2285
2286 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * valops.c (value_slice): Check for not allocated or not
2289         associated values.
2290
2291 2019-06-10  Tom de Vries  <tdevries@suse.de>
2292
2293         PR gdb/24618
2294         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2295         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2296         invalid.
2297
2298 2019-06-10  Tom de Vries  <tdevries@suse.de>
2299
2300         PR gdb/24611
2301         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2302         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2303
2304 2019-06-10  Tom de Vries  <tdevries@suse.de>
2305
2306         PR symtab/24545
2307         * symtab.c (struct demangled_name_entry): Add language field.
2308         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2309         static minimal symbol".  Set and use language field.
2310
2311 2019-06-10  Tom Tromey  <tromey@adacore.com>
2312
2313         * ada-lang.c (_initialize_ada_language): Update help text.
2314
2315 2019-06-10  Tom Tromey  <tromey@adacore.com>
2316
2317         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2318         with a newline.
2319         * guile/guile.c (handle_boot_error): Don't end warning with a
2320         newline.
2321         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2322         warning with a newline.
2323         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2324         newline.
2325         (s12z_frame_cache): Likewise.
2326         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2327         a newline.
2328         * solib-svr4.c (disable_probes_interface): Don't end warning with
2329         a newline.
2330         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2331         newline.
2332         * python/python.c (do_finish_initialization): Don't end warning
2333         with a newline.
2334
2335 2019-06-10  Tom Tromey  <tom@tromey.com>
2336
2337         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2338         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2339         gdbpy_enter.
2340
2341 2019-06-10  Tom Tromey  <tromey@adacore.com>
2342
2343         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2344         data.
2345         (elf_new_init): Don't call stabsread_new_init.
2346         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2347         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2348         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2349
2350 2019-06-10  Tom de Vries  <tdevries@suse.de>
2351
2352         PR symtab/16264
2353         PR symtab/24517
2354         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2355
2356 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2357
2358         * source.c (find_and_open_source): Also rewrite relative file
2359         names.
2360
2361 2019-04-26  Amos Bird  <amosbird@gmail.com>
2362
2363         * annotate.c (annotate_thread_exited): Add "thread-exited"
2364         annotation.
2365
2366 2019-06-06  Tom Tromey  <tromey@adacore.com>
2367
2368         * maint.h (class scoped_command_stats): Use
2369         DISABLE_COPY_AND_ASSIGN.
2370         <print_time>: New method.
2371         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2372         print_time.
2373         (scoped_command_stats::print_time): New method.
2374
2375 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2376
2377         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2378         instructions of lengths 6 or 8 bytes.
2379
2380 2019-06-04  Pedro Alves  <palves@redhat.com>
2381
2382         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2383
2384         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2385         * breakpoint.c (condition_completer): Likewise.
2386         * cli/cli-dump.c (scan_expression): Likewise.
2387         * common/filestuff.c (mkdir_recursive): Likewise.
2388         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2389         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2390         (gdb_abspath): Likewise.
2391         * compile/compile-cplus-types.c
2392         (compile_cplus_instance::decl_name): Likewise.
2393         * completer.c (complete_explicit_location):
2394         (signal_completer, reg_or_group_completer_1): Likewise.
2395         * cp-support.c (cp_remove_params_if_any): Likewise.
2396         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2397         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2398         * infcmd.c (strip_bg_char): Likewise.
2399         * linespec.c (copy_token_string): Likewise.
2400         * mi/mi-main.c (output_cores): Likewise.
2401         * psymtab.c (psymtab_search_name):
2402         * symfile.c (test_set_ext_lang_command): Likewise.
2403         * target.c (target_fileio_read_stralloc): Likewise.
2404         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2405         * value.c (complete_internalvar): Likewise.
2406
2407 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2408
2409         Add objfile property to gdb.Type.
2410         * NEWS: Mention Python API addition.
2411         * python/py-type.c (typy_get_objfile): New method.
2412
2413 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2414
2415         * NEWS: Mention the new set|show style [title|highlight].
2416         Mention changes to "show style", "help" and "apropos".
2417
2418 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2419
2420         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2421         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2422         instead of print_help_for_command.
2423         (print_doc_of_command): New function.
2424         (help_list): Add 'apropos -v word' suggestion.
2425         (print_help_for_command): Style the command name using title style.
2426         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2427         (_initialize_cli_cmds): Describe -v in apropos_command help.
2428
2429 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2430
2431         * cli/cli-style.h (cli_style_option): Add name in constructor,
2432         add m_name class member, add constructor with intensity,
2433         add name class function.
2434         (cli_style_option::add_setshow_commands): Remove name argument.
2435         (highlight_style, title_style): New styles.
2436         * cli/cli-style.c (do_show): New function that shows a style
2437         characteristic styling the style name with itself.
2438         (set_style_name): New function.
2439         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2440         Update all callers according to the changes in cli/cli-style.h.
2441         * utils.h (fputs_highlighted): New function.
2442         * utils.c (fputs_highlighted): Likewise.
2443
2444 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2445
2446         * NEWS: Mention new pipe command and new convenience variables.
2447
2448 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2449
2450         * cli/cli-cmds.c (pipe_command): New function.
2451         (_initialize_cli_cmds): Call add_com for pipe_command.
2452         Define | as an alias for pipe.
2453         (exit_status_set_internal_vars): New function.
2454         (shell_escape): Call exit_status_set_internal_vars.
2455         cli/cli-decode.c (find_command_name_length): Recognize | as
2456         a single character command.
2457
2458 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2459
2460         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2461         top.c (execute_command_to_ui_file): New function, mostly a copy
2462         of execute_command_to_string.
2463         (execute_command_to_string): Implement by calling
2464         execute_command_to_ui_file.
2465
2466 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2467
2468         * top.h (saved_command_line): Remove declaration.
2469         * top.c (previous_saved_command_line, previous_repeat_arguments):
2470         New variables.
2471         (saved_command_line): Make static, define together with other
2472         'repeat variables'.
2473         (dont_repeat): Clear repeat_arguments.
2474         (repeat_previous, get_saved_command_line, save_command_line):
2475         New functions.
2476         (gdb_init): Initialize saved_command_line
2477         and previous_saved_command_line.
2478         * main.c (captured_main_1): Remove saved_command_line initialization.
2479         * event-top.c (handle_line_of_input): Update to use
2480         the new 'repeat' related functions instead of direct access to
2481         saved_command_line.
2482         * command.h (repeat_previous, get_saved_command_line,
2483         save_command_line): New declarations.
2484         (dont_repeat): Add comment.
2485
2486 2019-05-30  Tom Tromey  <tromey@adacore.com>
2487
2488         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2489         Fix comment.
2490         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2491
2492 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2493
2494         PR cli/24587
2495         * completer.c (complete): Initialize variable word.
2496
2497 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2498
2499         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2500         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2501         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2502         'body' is NULL to the outter 'if', protecting the '!is_define'
2503         situation as well.
2504
2505 2019-05-29  Tom Tromey  <tromey@adacore.com>
2506
2507         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2508         (dwarf_unknown): New function.
2509         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2510         (dwarf_type_encoding_name): Use dwarf_unknown.
2511
2512 2019-05-29  Tom Tromey  <tromey@adacore.com>
2513
2514         PR c++/20020:
2515         * cp-valprint.c (cp_print_value_fields): Call
2516         cp_print_static_field inside "try".
2517
2518 2019-05-29  Tom Tromey  <tromey@adacore.com>
2519
2520         * inflow.c (struct terminal_info): Add default operator=.
2521         * configure: Rebuild.
2522         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2523         -Wdeprecated-copy-dtor, -Wredundant-move.
2524
2525 2019-05-29  Tom Tromey  <tromey@adacore.com>
2526
2527         * NEWS: Add entry.
2528         * infcmd.c (print_return_value_1): Handle finish_print
2529         option.
2530         (show_print_finish): New function.
2531         (_initialize_infcmd): Add "set/show print finish" commands.
2532         * valprint.c (user_print_options): Initialize new member.
2533         * valprint.h (struct value_print_options) <finish_print>: New
2534         member.
2535
2536 2019-05-28  Tom Tromey  <tromey@adacore.com>
2537
2538         * ada-lang.c (ada_remove_Xbn_suffix)
2539         (find_old_style_renaming_symbol)
2540         (parse_old_style_renaming): Remove.
2541         (ada_find_renaming_symbol): Don't call
2542         find_old_style_renaming_symbol.
2543         (ada_is_renaming_symbol): Rename from
2544         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2545         bool.  Now static.
2546         (ada_read_var_value): Update and simplify.
2547         * ada-exp.y (write_var_or_type): Remove old code.
2548
2549 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2550
2551         * event-top.c: Remove include comment.
2552         * inflow.c (class scoped_ignore_sigttou): Move from here...
2553         * inflow.h (class scoped_ignore_sigttou): ...to here.
2554         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2555         * top.c:  Remove include comment.
2556
2557 2019-05-27  Tom Tromey  <tom@tromey.com>
2558
2559         * NEWS: Fix typo.
2560
2561 2019-05-22  Tom Tromey  <tromey@adacore.com>
2562
2563         * target.c (target_follow_exec): Constify parameter.
2564         * target-delegates.c: Rebuild.
2565         * remote.c (remote_target::follow_exec): Constify parameter.
2566         * infrun.c (follow_exec): Constify parameter.
2567         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2568         (target_follow_exec): Likewise.
2569
2570 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2571
2572         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2573         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2574
2575 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2576
2577         * NEWS: Add debugredirect and testsuite sections.
2578
2579 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2580
2581         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2582         target descriptions using exclusively floating point register name
2583         aliases.
2584
2585 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2586
2587         PR gdb/18644:
2588         * f-lang.c (build_fortran_types): Handle the case where
2589         gdbarch_floatformat_for_type returns a nullptr.
2590
2591 2019-05-21  Tom de Vries  <tdevries@suse.de>
2592
2593         PR cli/24587
2594         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2595
2596 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2597
2598         PR gdb/18644:
2599         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2600         16-byte floats.
2601         * i386-tdep.c (i386_floatformat_for_type): Use
2602         floatformats_ia64_quad for the 16-byte floating point component
2603         within a fortran 32-byte complex number.
2604
2605 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2608         delete default constructor.
2609         (find_partial_die): Update to return const struct.
2610         (partial_die_parent_scope): Move variable declaration into scope
2611         of its use and change its type to auto.
2612         (guess_partial_die_structure_name): Likewise.
2613         (partial_die_info::fixup): Likewise.
2614
2615 2019-05-17  Tom Tromey  <tromey@adacore.com>
2616
2617         * source.c (find_and_open_source): Remove cast.
2618
2619 2019-05-17  Tom Tromey  <tromey@adacore.com>
2620
2621         * annotate.c (annotate_source): Make "filename" const.
2622         * annotate.h (annotate_source): Use const.
2623
2624 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2625
2626         * disasm.c (set_disassembler_options): Send errors to stderr.
2627
2628 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2629
2630         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2631         (cli_interp_base::set_logging): Check debug_redirect.
2632         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2633         * cli/cli-logging.c (debug_redirect): Add static variable.
2634         (pop_output_files): Add default param.
2635         (handle_redirections): Print debug setting.
2636         (show_logging_command): Likewise.
2637         (_initialize_cli_logging): Add debugredirect command.
2638         * interps.c (current_interp_set_logging): Add debug_redirect
2639         parameter.
2640         * interps.h (set_logging): Add debug_redirect parameter.
2641         (current_interp_set_logging): Likewise.
2642         * mi/mi-common.h: Likewise.
2643         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2644
2645 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2646             Tom Tromey  <tromey@adacore.com>
2647
2648         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2649         directly.
2650         * cli/cli-interp.h (make_logging_output): Remove declaration.
2651         * cli/cli-logging.c (make_logging_output): Remove function.
2652         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2653         directly.
2654         * ui-file.c (tee_file::tee_file): Remove bools.
2655         (tee_file::~tee_file): Remove deletes.
2656         * ui-file.h (tee_file): Remove bools.
2657
2658 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2659
2660         * mi/mi-cmds.h (mi_cmd_complete): New function.
2661         * mi/mi-main.c (mi_cmd_complete): Likewise.
2662         * mi/mi-cmds.c: Define new MI command -complete.
2663         * NEWS: Mention new -complete command.
2664
2665 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2666
2667         * completer.h (complete): New function.
2668         * completer.c (complete): Likewise.
2669         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2670         function defined in completer.h.
2671
2672 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2673
2674         * MAINTAINERS (Write After Approval): Add myself.
2675
2676 2019-05-17  Tom de Vries  <tdevries@suse.de>
2677
2678         PR gdb/24094
2679         * dwarf2read.c (struct cu_partial_die_info): New struct.
2680         (find_partial_die): Return cu_partial_die_info.
2681         (partial_die_parent_scope, guess_partial_die_structure_name)
2682         (partial_die_info::fixup): Handle new return type of find_partial_die.
2683
2684 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2685
2686         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2687         "std::string", simplifying the algorithm.
2688
2689 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2690
2691         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2692         (stap_static_probe_ops::get_probes): Likewise.
2693
2694 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2695
2696         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2697         '-')" and "else if".
2698         (stap_parse_single_operand): Join checks for
2699         "gdbarch_stap_parse_special_token_p" and
2700         "gdbarch_stap_parse_special_token" in the same "if" statement.
2701         Invert check when verifying for operation on register
2702         displacement.
2703
2704 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2705
2706         * stap-probe.c (stap_get_opcode): Update comment.
2707         (stap_get_expected_argument_type): Likewise.
2708         (handle_stap_probe): Likewise.
2709
2710 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2711
2712         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2713         return type to 'bool'.  Adjust comment.  Use 'bool' when
2714         appropriate.
2715         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2716         * stap-probe.c (stap_parse_argument_1): Likewise.
2717         (stap_is_operator): Likewise.
2718         (stap_is_generic_prefix): Likewise.
2719         (stap_is_register_prefix): Likewise.
2720         (stap_is_register_indirection_prefix): Likewise.
2721         (stap_is_integer_prefix): Likewise.
2722         (stap_generic_check_suffix): Likewise.
2723         (stap_check_integer_suffix): Likewise.
2724         (stap_check_register_suffix): Likewise.
2725         (stap_check_register_indirection_suffix): Likewise.
2726         (stap_parse_register_operand): Likewise.
2727         (stap_parse_single_operand): Likewise.
2728         (stap_parse_argument_1): Likewise.
2729         (stap_probe::get_argument_count): Likewise.
2730         (stap_is_operator): Likewise.
2731
2732 2019-05-16  Tom Tromey  <tromey@adacore.com>
2733
2734         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2735         keyword to foreach.
2736
2737 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2738
2739         * linux-thread-db.c (try_thread_db_load_1): Change return type
2740         to bool.
2741         (try_thread_db_load): Likewise.
2742         (try_thread_db_load_from_pdir_1): Likewise.
2743         (try_thread_db_load_from_pdir): Likewise.
2744         (try_thread_db_load_from_sdir): Likewise.
2745         (try_thread_db_load_from_dir): Likewise.
2746         (thread_db_load_search): Likewise.
2747         (has_libpthread): Likewise.
2748         (thread_db_load): Likewise.
2749
2750 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2751
2752         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2753         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2754         NULL, and complain/return if that's the case.
2755
2756 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2757
2758         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2759         (advance, posn, abstract_read_memory): New functions.
2760         [struct mem_read_abstraction]: New struct.
2761         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2762
2763 2019-05-14  Tom Tromey  <tromey@adacore.com>
2764
2765         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2766         value is not lval_memory.
2767
2768 2019-05-14  Tom Tromey  <tromey@adacore.com>
2769
2770         * solib.c (info_sharedlibrary_command): Style the file name.
2771
2772 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2773
2774         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2775         (aarch64_vnv_type): Likewise.
2776         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2777         * common/tdesc.c: Likewise.
2778         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2779         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2780         * features/aarch64-fpu.xml: Add ieee half view.
2781         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2782         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2783         * gdbtypes.h (struct builtin_type): Likewise.
2784         (struct objfile_type): Likewise.
2785
2786 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2787
2788         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2789         typo.
2790         * location.h (string_to_event_location): Likewise.
2791
2792 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2793
2794         GDB 8.3 released.
2795
2796 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2797
2798         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2799         New variable declaration.
2800         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2801         New variable.
2802         (print_one_breakpoint): Use ui_out::test_flags and new global
2803         variable to compute use_fixed_output.
2804         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2805         Remove.
2806         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2807         (mi_multi_location_breakpoint_output_fixed): Remove.
2808         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2809         new variable.
2810         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2811         fix_multi_location_breakpoint_output flag if version >= 3.
2812         * ui-out.h (enum ui_out_flag)
2813         <fix_multi_location_breakpoint_output>: New enumerator.
2814
2815 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2816
2817         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2818
2819 2019-05-10  Tom Tromey  <tromey@adacore.com>
2820
2821         * ada-lang.c (catch_ada_completer): New function.
2822         (_initialize_ada_language): Use it.
2823
2824 2019-05-10  Tom Tromey  <tromey@adacore.com>
2825
2826         * thread.c (print_thread_info): Make "requested_threads" const.
2827         * gdbthread.h (print_thread_info): Make "requested_threads"
2828         const.
2829         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2830         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2831
2832 2019-05-08  Tom Tromey  <tom@tromey.com>
2833
2834         * gdbtypes.c (objfile_type_data): Change type.
2835         (objfile_type, _initialize_gdbtypes): Update.
2836
2837 2019-05-08  Tom Tromey  <tom@tromey.com>
2838
2839         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2840         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2841         (_initialize_dwarf2_frame): Update.
2842
2843 2019-05-08  Tom Tromey  <tom@tromey.com>
2844
2845         * objc-lang.c (objc_objfile_data): Change type.
2846         (find_methods): Update.
2847         (_initialize_objc_lang): Remove.
2848
2849 2019-05-08  Tom Tromey  <tom@tromey.com>
2850
2851         * stabsread.c (rs6000_builtin_type_data): Change type.
2852         (rs6000_builtin_type, _initialize_stabsread): Update.
2853
2854 2019-05-08  Tom Tromey  <tom@tromey.com>
2855
2856         * mips-tdep.c (mips_pdr_data): Remove.
2857         (_initialize_mips_tdep): Update.
2858
2859 2019-05-08  Tom Tromey  <tom@tromey.com>
2860
2861         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2862         (hppa_init_objfile_priv_data, read_unwind_info)
2863         (find_unwind_entry, _initialize_hppa_tdep): Update.
2864
2865 2019-05-08  Tom Tromey  <tom@tromey.com>
2866
2867         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2868         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2869         on obstack.
2870         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2871
2872 2019-05-08  Tom Tromey  <tom@tromey.com>
2873
2874         * mdebugread.c (basic_type_data): Change type.
2875         (basic_type, _initialize_mdebugread): Update.
2876
2877 2019-05-08  Tom Tromey  <tom@tromey.com>
2878
2879         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2880
2881 2019-05-08  Tom Tromey  <tom@tromey.com>
2882
2883         * nto-tdep.c (nto_inferior_data_reg): Change type.
2884         (nto_inferior_data): Update.
2885         (nto_inferior_data_cleanup, nto_new_inferior_data)
2886         (_initialize_nto_tdep): Remove.
2887         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2888
2889 2019-05-08  Tom Tromey  <tom@tromey.com>
2890
2891         * ada-lang.c (struct ada_inferior_data): Add initializers.
2892         (ada_inferior_data): Change type.
2893         (ada_inferior_data_cleanup): Remove.
2894         (get_ada_inferior_data, ada_inferior_exit)
2895         (struct ada_pspace_data): Add initializers, destructor.
2896         (ada_pspace_data_handle): Change type.
2897         (get_ada_pspace_data): Update.
2898         (ada_pspace_data_cleanup): Remove.
2899
2900 2019-05-08  Tom Tromey  <tom@tromey.com>
2901
2902         * coffread.c (struct coff_symfile_info): Add initializers.
2903         (coff_objfile_data_key): Move lower.  Change type.
2904         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2905         Update.
2906         (coff_free_info): Remove.
2907
2908 2019-05-08  Tom Tromey  <tom@tromey.com>
2909
2910         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2911         (fbsd_pspace_data_handle): Move lower.  Change type.
2912         (get_fbsd_pspace_data): Update.
2913         (fbsd_pspace_data_cleanup): Remove.
2914         (_initialize_fbsd_tdep): Update.
2915
2916 2019-05-08  Tom Tromey  <tom@tromey.com>
2917
2918         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2919         (get_ada_tasks_pspace_data): Update.
2920         (ada_tasks_pspace_data_cleanup): Remove.
2921         (_initialize_tasks): Update.
2922         (ada_tasks_inferior_data_handle): Change type.
2923         (get_ada_tasks_inferior_data): Update.
2924         (ada_tasks_inferior_data_cleanup): Remove.
2925         (struct ada_tasks_pspace_data): Add initializers.
2926
2927 2019-05-08  Tom Tromey  <tom@tromey.com>
2928
2929         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2930         * symfile-debug.c (debug_sym_get_probes): Change type.
2931         * stap-probe.c (handle_stap_probe):
2932         (stap_static_probe_ops::get_probes): Change type.
2933         * probe.h (class static_probe_ops) <get_probes>: Change type.
2934         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2935         (parse_probes_in_pspace): Update.
2936         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2937         Update.
2938         (any_static_probe_ops::get_probes): Change type.
2939         * elfread.c (elfread_data): New typedef.
2940         (probe_key): Change type.
2941         (elf_get_probes): Likewise.  Update.
2942         (probe_key_free): Remove.
2943         (_initialize_elfread): Update.
2944         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2945         Change type.
2946         (dtrace_process_dof_probe, dtrace_process_dof)
2947         (dtrace_static_probe_ops::get_probe): Change type.
2948
2949 2019-05-08  Tom Tromey  <tom@tromey.com>
2950
2951         * xcoffread.c (struct xcoff_symfile_info): Rename from
2952         coff_symfile_info.  Add initializers.
2953         (xcoff_objfile_data_key): Move lower.  Change type.
2954         (XCOFF_DATA): Rewrite.
2955         (xcoff_free_info): Remove.
2956         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2957         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2958         (xcoff_initial_scan): Update.
2959
2960 2019-05-08  Tom Tromey  <tom@tromey.com>
2961
2962         * solib-svr4.c (struct svr4_info): Add initializers and
2963         destructor.
2964         <probes_table>: Now an htab_up.
2965         (solib_svr4_pspace_data): Change type.
2966         (free_probes_table): Simplify.
2967         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2968         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2969         (probes_table_remove_objfile_probes, register_solib_event_probe)
2970         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2971         (_initialize_svr4_solib): Update.
2972
2973 2019-05-08  Tom Tromey  <tom@tromey.com>
2974
2975         * remote.c (remote_pspace_data): Change type.
2976         (remote_pspace_data_cleanup): Remove.
2977         (get_remote_exec_file, set_pspace_remote_exec_file)
2978         (_initialize_remote): Update.
2979
2980 2019-05-08  Tom Tromey  <tom@tromey.com>
2981
2982         * breakpoint.c (breakpoint_objfile_key): Change type.
2983         (get_breakpoint_objfile_data): Update.
2984         (free_breakpoint_objfile_data): Remove.
2985         (_initialize_breakpoint): Update.
2986
2987 2019-05-08  Tom Tromey  <tom@tromey.com>
2988
2989         * linux-tdep.c (struct linux_info): Add initializers.
2990         (linux_inferior_data): Move.  Change type.
2991         (invalidate_linux_cache_inf): Update.
2992         (linux_inferior_data_cleanup): Remove.
2993         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2994
2995 2019-05-08  Tom Tromey  <tom@tromey.com>
2996
2997         * auxv.c (auxv_inferior_data): Move.  Change type.
2998         (auxv_inferior_data_cleanup): Remove.
2999         (invalidate_auxv_cache_inf): Rewrite.
3000         (get_auxv_inferior_data, _initialize_auxv): Update.
3001
3002 2019-05-08  Tom Tromey  <tom@tromey.com>
3003
3004         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3005         (symfile_debug_objfile_data_key): Change type.
3006         (symfile_debug_installed, debug_qf_has_symbols)
3007         (debug_qf_find_last_source_symtab)
3008         (debug_qf_forget_cached_source_info)
3009         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3010         (debug_qf_print_stats, debug_qf_dump)
3011         (debug_qf_expand_symtabs_for_function)
3012         (debug_qf_expand_all_symtabs)
3013         (debug_qf_expand_symtabs_with_fullname)
3014         (debug_qf_map_matching_symbols)
3015         (debug_qf_expand_symtabs_matching)
3016         (debug_qf_find_pc_sect_compunit_symtab)
3017         (debug_qf_map_symbol_filenames)
3018         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3019         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3020         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3021         (debug_sym_read_linetable, debug_sym_relocate): Update.
3022         (symfile_debug_free_objfile): Remove.
3023         (install_symfile_debug_logging, _initialize_symfile_debug):
3024         Update.
3025
3026 2019-05-08  Tom Tromey  <tom@tromey.com>
3027
3028         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3029         allocate_on_obstack.
3030         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3031         (get_dwarf2_per_objfile): Update.
3032         (set_dwarf2_per_objfile): Remove.
3033         (dwarf2_has_info, dwarf2_get_section_info): Update.
3034         (dwarf2_free_objfile): Remove.
3035         (_initialize_dwarf2_read): Update.
3036
3037 2019-05-08  Tom Tromey  <tom@tromey.com>
3038
3039         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3040         initializers.
3041         <unsupported_script_warning_printed,
3042         script_not_found_warning_printed>: Now bool.
3043         (auto_load_pspace_data): Change type.
3044         (~auto_load_pspace_info): Rename from
3045         auto_load_pspace_data_cleanup.
3046         (get_auto_load_pspace_data, init_loaded_scripts_info)
3047         (clear_section_scripts, maybe_print_unsupported_script_warning)
3048         (maybe_print_script_not_found_warning, _initialize_auto_load):
3049         Update.
3050
3051 2019-05-08  Tom Tromey  <tom@tromey.com>
3052
3053         * objfiles.c (objfile_pspace_info): Add destructor and
3054         initializers.
3055         (objfiles_pspace_data): Change type.
3056         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3057         (get_objfile_pspace_data): Update.
3058         (objfiles_bfd_data): Change type.
3059         (get_objfile_bfd_data): Update.
3060         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3061
3062 2019-05-08  Tom Tromey  <tom@tromey.com>
3063
3064         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3065         Change type.
3066         (get_catch_syscall_inferior_data): Update.
3067         (catch_syscall_inferior_data_cleanup): Remove.
3068         (_initialize_break_catch_syscall): Update.
3069
3070 2019-05-08  Tom Tromey  <tom@tromey.com>
3071
3072         * inflow.c (struct terminal_info): Add destructor and
3073         initializers.
3074         (inflow_inferior_data): Change type.
3075         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3076         (get_inflow_inferior_data, inflow_inferior_exit)
3077         (swap_terminal_info, _initialize_inflow): Update.
3078
3079 2019-05-08  Tom Tromey  <tom@tromey.com>
3080
3081         * target-dcache.c (target_dcache_cleanup): Remove.
3082         (target_dcache_aspace_key): Change type.
3083         (target_dcache_init_p, target_dcache_invalidate)
3084         (target_dcache_get, target_dcache_get_or_init)
3085         (_initialize_target_dcache): Update.
3086         * dcache.h (struct dcache_deleter): New.
3087
3088 2019-05-08  Tom Tromey  <tom@tromey.com>
3089
3090         * symtab.c (struct symbol_cache): Add destructor and
3091         initializers.
3092         (symbol_cache_key): Move.  Change type.
3093         (make_symbol_cache, free_symbol_cache): Remove.
3094         (get_symbol_cache): Update.
3095         (symbol_cache_cleanup): Remove.
3096         (ALL_PSPACES, symbol_cache_flush)
3097         (maintenance_print_symbol_cache)
3098         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3099         Update.
3100
3101 2019-05-08  Tom Tromey  <tom@tromey.com>
3102
3103         * symtab.c (struct main_info): Add destructor and initializers.
3104         (main_progspace_key): Move.  Change type.
3105         (get_main_info): Update.
3106         (main_info_cleanup): Remove.
3107         (_initialize_symtab): Update.
3108
3109 2019-05-08  Tom Tromey  <tom@tromey.com>
3110
3111         * registry.h (DECLARE_REGISTRY): Define the _key class.
3112
3113 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3114
3115         * NEWS: Merge two 'New commands' sections.
3116
3117 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3118
3119         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3120         parameter and use Ada language definition instead.
3121         (ada_val_print_ptr): Remove unused language parameter.
3122         (ada_val_print_num): Remove language parameter and use Ada language
3123         definition instead.
3124         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3125         parameter.
3126         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3127         parameter and use Ada language definition instead.
3128         (ada_val_print_1): Update all ada_val_print_xxx calls.
3129         Remove language parameter.
3130         (ada_val_print): Update ada_val_print_1 call.
3131
3132 2019-05-08  Tom Tromey  <tromey@adacore.com>
3133
3134         * remote.c (remote_hw_watchpoint_limit)
3135         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3136         Now static.
3137
3138 2019-05-08  Tom Tromey  <tromey@adacore.com>
3139
3140         * maint.c (_initialize_maint_cmds): Move initialization code to
3141         remote.c.
3142         (watchdog, show_watchdog): Move to remote.c.
3143         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3144         "watchdog" static.
3145         (_initialize_remote): Move initialization code from maint.c.
3146         * defs.h (watchdog): Don't declare.
3147
3148 2019-05-08  Tom Tromey  <tromey@adacore.com>
3149
3150         * tui/tui-interp.c: Include main.h.
3151         * interps.c: Include main.h.
3152         * main.h (interpreter_p): Declare.
3153         * defs.h (interpreter_p): Don't declare.
3154
3155 2019-05-08  Tom Tromey  <tromey@adacore.com>
3156
3157         * dwarf2loc.c: Include dwarf2read.h.
3158         * defs.h (read_unsigned_leb128): Don't declare.
3159         * dwarf2read.h (read_unsigned_leb128): Declare.
3160
3161 2019-05-08  Tom Tromey  <tromey@adacore.com>
3162
3163         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3164         method.
3165
3166 2019-05-08  Tom Tromey  <tromey@adacore.com>
3167
3168         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3169         when no wrap column is set.
3170
3171 2019-05-08  Tom Tromey  <tromey@adacore.com>
3172
3173         * c-lang.c (c_get_string): Handle non-C-style arrays.
3174
3175 2019-05-08  Tom Tromey  <tromey@adacore.com>
3176
3177         * typeprint.c (print_offset_data::update): Print the bit offset,
3178         not the number of bits remaining.
3179
3180 2019-05-08  Tom Tromey  <tromey@adacore.com>
3181
3182         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3183         padding at end of comment.
3184
3185 2019-05-08  Tom Tromey  <tromey@adacore.com>
3186
3187         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3188         Compare main types.
3189
3190 2019-05-06  Tom Tromey  <tom@tromey.com>
3191
3192         * common/scoped_mmap.c: Include common-defs.h.
3193         * common/scoped_mmap.h: Don't include config.h.
3194
3195 2019-05-04  Tom Tromey  <tom@tromey.com>
3196
3197         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3198         (struct aarch64_call_info): Add initializers.
3199         <si>: Now a std::vector.
3200         (pass_on_stack, aarch64_push_dummy_call): Update.
3201
3202 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3203             Tom Tromey  <tom@tromey.com>
3204
3205         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3206         (ppc_threads): Now a std::vector.  Now static.
3207         (hwdebug_find_thread_points_by_tid)
3208         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3209         Update.
3210
3211 2019-05-04  Tom Tromey  <tom@tromey.com>
3212
3213         * arc-tdep.c (arc_tdesc_init): Return bool.
3214
3215 2019-05-04  Tom Tromey  <tom@tromey.com>
3216
3217         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3218         Use gdb_assert_not_reached.
3219
3220 2019-05-04  Tom Tromey  <tom@tromey.com>
3221
3222         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3223         "false".
3224
3225 2019-05-04  Tom Tromey  <tom@tromey.com>
3226
3227         * arc-tdep.c (arc_tdesc_init): Use bool.
3228
3229 2019-05-04  Tom Tromey  <tom@tromey.com>
3230
3231         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3232
3233 2019-05-04  Tom Tromey  <tom@tromey.com>
3234
3235         * cli/cli-cmds.c (valid_command_p): Return bool.
3236
3237 2019-05-04  Tom Tromey  <tom@tromey.com>
3238
3239         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3240         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3241
3242 2019-05-04  Raul Tambre  <raul@tambre.ee>
3243
3244         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3245         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3246         operator for comparison.
3247
3248 2019-05-04  Tom Tromey  <tom@tromey.com>
3249
3250         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3251         (lookup_partial_symbol, print_partial_symbols)
3252         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3253         (psymbol_compare): Update.
3254         (add_psymbol_to_bcache): Clear the entire psymbol.
3255         (maintenance_check_psymtabs): Update.
3256         * psympriv.h (struct partial_symbol): Don't derive from
3257         general_symbol_info.
3258         <obj_section, unrelocated_address, address,
3259         set_unrelocated_address>: Update.
3260         <ginfo>: New member.
3261         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3262         (debug_names::write_psymbols): Update.
3263
3264 2019-05-04  Tom de Vries  <tdevries@suse.de>
3265
3266         * contrib/cc-with-tweaks.sh: Support -n arg.
3267
3268 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3269
3270         * corelow.c (core_target::detach): Ensure frame cache and
3271         register caches are cleared.
3272         inferior.c (exit_inferior_1): Likewise.
3273
3274 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3275             Tom Tromey  <tom@tromey.com>
3276
3277         * dictionary.c (collate_pending_symbols_by_language): Remove
3278         "struct" from foreach.
3279         * symtab.c (lookup_global_symbol_from_objfile)
3280         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3281         foreach.
3282         * ser-tcp.c (net_open): Remove "struct" from foreach.
3283         * objfiles.c (objfile_relocate, objfile_rebase)
3284         (objfile_has_symbols): Remove "struct" from foreach.
3285         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3286         from foreach.
3287         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3288         foreach.
3289         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3290         "struct" from foreach.
3291         * ada-lang.c (create_excep_cond_exprs)
3292         (ada_exception_catchpoint_cond_string): Remove "struct" from
3293         foreach.
3294
3295 2019-05-03  Tom Tromey  <tromey@adacore.com>
3296
3297         * ada-exp.y (convert_char_literal): Check suffix of each
3298         enumerator.
3299
3300 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3301
3302         PR ada/21406:
3303         * ada-exp.y (yywrap): Don't define.
3304         * ada-lex.l (%option): Add noyywrap
3305         (yywrap): Remove.
3306
3307 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3308
3309         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3310         _WIN32_WINNT to the XP level, unless already defined to a higher
3311         level.
3312
3313         * unittests/parse-connection-spec-selftests.c:
3314         * ser-tcp.c:
3315         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3316         override.
3317
3318         * symfile.c (find_separate_debug_file): Remove colon from the
3319         drive spec of DOS/Windows file names of the target, so that the
3320         file name produced from DEBUGDIR and the target's directory will
3321         be valid on DOS/Windows systems.
3322
3323 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * rust-lang.c (val_print_struct): Handle printing structures
3326         containing strings.
3327
3328 2019-05-02  Tom Tromey  <tromey@adacore.com>
3329
3330         * valarith.c (_initialize_valarith): Remove.
3331
3332 2019-05-01  Tom Tromey  <tromey@adacore.com>
3333
3334         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3335         bitfields.
3336
3337 2019-05-01  Tom Tromey  <tromey@adacore.com>
3338
3339         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3340         for big-endian copies.
3341
3342 2019-04-30  Ali Tamur  <tamur@google.com>
3343         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3344         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3345         (read_3_bytes): New function.
3346
3347 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3348
3349         * windows-nat.c (main_thread_id): Delete.
3350         (handle_output_debug_string): Replace main_thread_id by
3351         current_event.dwThreadId.
3352         (fake_create_process): Likewise.
3353         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3354         Do not set main_thread_id.
3355         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3356         current_event.dwThreadId.
3357         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3358
3359 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3360
3361         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3362         Use current_event.dwThreadId instead of main_thread_id.
3363
3364 2019-04-30  Tom Tromey  <tromey@adacore.com>
3365
3366         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3367         (create_excep_cond_exprs): Iterate over program spaces.
3368         (ada_exception_catchpoint_cond_string): Examine all minimal
3369         symbols for exception types.
3370
3371 2019-04-30  Tom Tromey  <tromey@adacore.com>
3372
3373         PR c++/24470:
3374         * dwarf2read.c (process_structure_scope): Handle case where type
3375         has template parameters but no symbol was created.
3376
3377 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3378             Chris January  <chris.january@arm.com>
3379
3380         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3381         qualifier.
3382         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3383
3384 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3385
3386         * f-typeprint.c (f_print_type): Update rules for printing
3387         whitespace.
3388         (f_type_print_varspec_suffix): Likewise.
3389
3390 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3391             Chris January  <chris.january@arm.com>
3392
3393         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3394         function arguments.
3395
3396 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3397
3398         * f-lang.c (build_fortran_types): Change name of void type to
3399         lower case.
3400         * f-typeprint.c (f_type_print_base): Print the name of the void
3401         type, rather than a fixed string.
3402         * f-valprint.c (f_decorations): Use lower case void string.
3403
3404 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3405             Chris January  <chris.january@arm.com>
3406
3407         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3408         types for Fortran.
3409
3410 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3411             Chris January  <chris.january@arm.com>
3412             David Lecomber  <david.lecomber@arm.com>
3413
3414         * f-exp.y (BINOP_INTRINSIC): New token.
3415         (exp): New parser rule handling BINOP_INTRINSIC.
3416         (f77_keywords): Add new builtin procedures.
3417         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3418         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3419         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3420         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3421         (print_unop_subexp_f): New function.
3422         (print_binop_subexp_f): New function.
3423         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3424         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3425         (dump_subexp_body_f): Likewise.
3426         (operator_check_f): Likewise.
3427         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3428         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3429
3430 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3433         UNOP_KIND.
3434         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3435         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3436         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3437         (operator_length_f): New fuction.
3438         (print_subexp_f): New function.
3439         (op_name_f): New function.
3440         (dump_subexp_body_f): New function.
3441         (operator_check_f): New function.
3442         (exp_descriptor_f): Replace standard expression handling functions
3443         with new functions.
3444         * gdb/fortran-operator.def: New file.
3445         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3446         * gdb/std-operator.def: Remove UNOP_KIND.
3447
3448 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3449
3450         * std-operator.def: Remove unbalanced, stray double quote
3451         character.
3452
3453 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3454             Chris January  <chris.january@arm.com>
3455             Daniel Everett  <daniel.everett@arm.com>
3456             Nick Forrington  <nick.forrington@arm.com>
3457             Richard Bunt  <richard.bunt@arm.com>
3458
3459         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3460         of depth when printing anonymous structs or unions.
3461         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3462         Don't print either the top-level value, or the children if the
3463         max-depth is exceeded.
3464         (ppscm_print_children): When printing the key of a map, allow one
3465         extra level of depth.
3466         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3467         print either the top-level value, or the children if the max-depth
3468         is exceeded.
3469         (print_children): When printing the key of a map, allow one extra
3470         level of depth.
3471         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3472         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3473         (user_print_options): Initialise max_depth field.
3474         (val_print_scalar_or_string_type_p): New function.
3475         (val_print): Check to see if the max depth has been reached.
3476         (val_print_check_max_depth): Define new function.
3477         (show_print_max_depth): New function.
3478         (_initialize_valprint): Add 'print max-depth' option.
3479         * valprint.h (struct value_print_options) <max_depth>: New field.
3480         (val_print_check_max_depth): Declare new function.
3481         * NEWS: Document new feature.
3482
3483 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3484
3485         * ada-lang.c (ada_language_defn): Initialise new field.
3486         * c-lang.c (c_is_string_type_p): New function.
3487         (c_language_defn): Initialise new field.
3488         (cplus_language_defn): Initialise new field.
3489         (asm_language_defn): Initialise new field.
3490         (minimal_language_defn): Initialise new field.
3491         * c-lang.h (c_is_string_type_p): Declare new function.
3492         * d-lang.c (d_language_defn): Initialise new field.
3493         * f-lang.c (f_is_string_type_p): New function.
3494         (f_language_defn): Initialise new field.
3495         * go-lang.c (go_is_string_type_p): New function.
3496         (go_language_defn): Initialise new field.
3497         * language.c (default_is_string_type_p): New function.
3498         (unknown_language_defn): Initialise new field.
3499         (auto_language_defn): Initialise new field.
3500         * language.h (struct language_defn) <la_is_string_type_p>: New
3501         member variable.
3502         (default_is_string_type_p): Declare new function.
3503         * m2-lang.c (m2_language_defn): Initialise new field.
3504         * objc-lang.c (objc_language_defn): Initialise new field.
3505         * opencl-lang.c (opencl_language_defn): Initialise new field.
3506         * p-lang.c (pascal_is_string_type_p): New function.
3507         (pascal_language_defn): Initialise new field.
3508         * rust-lang.c (rust_is_string_type_p): New function.
3509         (rust_language_defn): Initialise new field.
3510
3511 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3514         New field.
3515         * ada-lang.c (ada_language_defn): Initialise new field.
3516         * c-lang.c (c_language_defn): Likewise.
3517         (cplus_language_defn): Likewise.
3518         (asm_language_defn): Likewise.
3519         (minimal_language_defn): Likewise.
3520         * d-lang.c (d_language_defn): Likewise.
3521         * f-lang.c (f_language_defn): Likewise.
3522         * go-lang.c (go_language_defn): Likewise.
3523         * language.c (unknown_language_defn): Likewise.
3524         (auto_language_defn): Likewise.
3525         * m2-lang.c (m2_language_defn): Likewise.
3526         * objc-lang.c (objc_language_defn): Likewise.
3527         * opencl-lang.c (opencl_language_defn): Likewise.
3528         * p-lang.c (pascal_language_defn): Likewise.
3529         * rust-lang.c (rust_language_defn): Likewise.
3530
3531 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3532
3533         * ada-lang.c (ada_is_character_type): Change return type to bool.
3534         (ada_is_string_type): Likewise.
3535         * ada-lang.h (ada_is_character_type): Update declaration
3536         (ada_is_string_type): Likewise.
3537
3538 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3539
3540         Support style in 'frame|thread apply'
3541
3542         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3543         * record.c (record_start, record_stop): Update callers of
3544         execute_command_to_string with false.
3545         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3546         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3547         methods.
3548         (class string_file): New constructor with term_out parameter.
3549         Override methods term_out and can_emit_style_escape.  New member
3550         term_out.
3551         (class stdio_file): Override can_emit_style_escape.
3552         (class tee_file): Override term_out and can_emit_style_escape.
3553         * utils.h (can_emit_style_escape): Remove.
3554         * utils.c (can_emit_style_escape): Likewise.
3555         Update all callers of can_emit_style_escape (SOMESTREAM) to
3556         SOMESTREAM->can_emit_style_escape.
3557         * source-cache.c (source_cache::get_source_lines): Likewise.
3558         * stack.c (frame_apply_command_count): Call execute_command_to_string
3559         passing the term_out characteristic of the current gdb_stdout.
3560         * thread.c (thr_try_catch_cmd): Likewise.
3561         * top.c (execute_command_to_string): pass term_out parameter
3562         to construct the string_file for the command output.
3563         * ui-file.c (term_cli_styling): New function (most code moved
3564         from utils.c can_emit_style_escape).
3565         (string_file::string_file, string_file::can_emit_style_escape,
3566         stdio_file::can_emit_style_escape, tee_file::term_out,
3567         tee_file::can_emit_style_escape): New functions.
3568
3569 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3570
3571         * NEWS: Mention the new set|show may-call-functions.
3572         * infcall.c (may_call_functions_p): New variable.
3573         (show_may_call_functions_p): New function.
3574         (call_function_by_hand_dummy): Throws an error if not
3575         may-call-functions.
3576         (_initialize_infcall): Call add_setshow_boolean_cmd for
3577         may-call-functions.
3578
3579 2019-04-25  Keith Seitz  <keiths@redhat.com>
3580
3581         PR c++/24367
3582         * cp-support.c (inspect_type): Don't attempt substitutions
3583         of symbol with the same name.
3584
3585 2019-04-25  Tom Tromey  <tromey@adacore.com>
3586
3587         PR gdb/24475:
3588         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3589         static.
3590
3591 2019-04-25  Tom Tromey  <tromey@adacore.com>
3592
3593         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3594         rvalue reference.
3595         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3596         (gdb_xml_parser::parse): Use std::move.
3597         * python/python-internal.h (gdbpy_convert_exception): Take a const
3598         reference.
3599         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3600         std::move.
3601         * python/py-utils.c (gdbpy_convert_exception): Take a const
3602         reference.
3603         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3604         Use std::move.
3605         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3606         Use std::move.
3607         * mi/mi-main.c (mi_print_exception): Take a const reference.
3608         * main.c (handle_command_errors): Take a const reference.
3609         * linespec.c (parse_linespec): Use std::move.
3610         * infcall.c (run_inferior_call): Use std::move.
3611         (call_function_by_hand_dummy): Use std::move.
3612         * exec.c (try_open_exec_file): Use std::move.
3613         * exceptions.h (exception_print, exception_fprintf)
3614         (exception_print_same): Update.
3615         * exceptions.c (print_exception, exception_print)
3616         (exception_fprintf, exception_print_same): Change parameters to
3617         const reference.
3618         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3619         * common/new-op.c: Use std::move.
3620         * common/common-exceptions.h (struct gdb_exception): Add move
3621         constructor.
3622         (struct gdb_exception_error, struct gdb_exception_quit, struct
3623         gdb_quit_bad_alloc): Change constructor to move constructor.
3624         (throw_exception): Change parameter to rvalue reference.
3625         * common/common-exceptions.c (throw_exception): Take rvalue
3626         reference.
3627         * cli/cli-interp.c (safe_execute_command): Use std::move.
3628         * breakpoint.c (insert_bp_location, location_to_sals): Use
3629         std::move.
3630
3631 2019-04-25  Tom Tromey  <tromey@adacore.com>
3632
3633         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3634         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3635         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3636         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3637         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3638         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3639         guile/scm-value.c: Use unpack.
3640         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3641         gdbscm_gdb_exception.
3642         (gdbscm_throw_gdb_exception): Likewise.
3643         (struct gdbscm_gdb_exception): New.
3644         (unpack): New function.
3645         (gdbscm_wrap): Use unpack.
3646
3647 2019-04-25  Tom Tromey  <tromey@adacore.com>
3648
3649         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3650         (gdb_rl_callback_handler): Use std::move.
3651         * common/common-exceptions.h (struct gdb_exception): Add move
3652         assignment operator.
3653         (throw_exception_sjlj): Change "exception" to const reference.
3654         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3655         (throw_exception_sjlj): Change "exception" to const reference.
3656
3657 2019-04-25  Tom Tromey  <tromey@adacore.com>
3658
3659         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3660         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3661         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3662         Update.
3663         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3664         Update.
3665         * mi/mi-interp.c (mi_interp::exec): Update.
3666         * linespec.c (parse_linespec): Update.
3667         * infcall.c (run_inferior_call): Update.
3668         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3669         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3670         (gdbscm_lookup_global_symbol): Update.
3671         * guile/scm-param.c (gdbscm_parameter_value): Update.
3672         * guile/scm-frame.c (gdbscm_frame_read_register)
3673         (gdbscm_frame_read_var): Update.
3674         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3675         * exec.c (try_open_exec_file): Update.
3676         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3677         (gdb_rl_callback_handler): Update.
3678         * common/common-exceptions.h (exception_none): Don't declare.
3679         * common/common-exceptions.c (exception_none): Don't define.
3680         (struct catcher) <exception>: Update.
3681         * cli/cli-interp.c (safe_execute_command): Update.
3682         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3683
3684 2019-04-25  Ali Tamur  <tamur@google.com>
3685
3686         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3687         (read_attribute_value): Likewise.
3688         (dwarf2_read_addr_index): Update comment.
3689         (read_str_index): Add DW_FORM_strx.
3690         (dwarf2_string_attr): Likewise.
3691         (dwarf2_const_value_attr): Likewise.
3692         (dump_die_shallow): Likewise.
3693         (dwarf2_fetch_constant_bytes): Likewise.
3694         (skip_form_bytes): Likewise.
3695         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3696
3697 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3698
3699         PR corefiles/11608
3700         PR corefiles/18187
3701         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3702         OFFSET.  Verify if current mapping contains an ELF header.
3703         (linux_find_memory_regions_full): Adjust call to
3704         dump_mapping_p.
3705
3706 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3707             Kang Li <kanglictf@gmail.com>
3708
3709         PR gdb/21600
3710
3711         * dwarf2-frame.c (read_initial_length): Be consistent about using
3712         unsigned representation of length.
3713         (decode_frame_entry_1): Likewise.  Check for wraparound of
3714         end pointer as well as buffer overflow.
3715
3716 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3717
3718         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3719         "vq".
3720
3721 2019-04-24  Tom Tromey  <tromey@adacore.com>
3722
3723         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3724
3725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * s12z-tdep.c (s12z_unwind_pc): Delete.
3728         (s12z_unwind_sp): Delete.
3729         (s12z_gdbarch_init): Don't register deleted functions with
3730         gdbarch.
3731
3732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3733
3734         * rl78-tdep.c (rl78_unwind_sp): Delete.
3735         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3736
3737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3738
3739         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3740         (xstormy16_unwind_pc): Delete.
3741         (xstormy16_dummy_id): Delete.
3742         (xstormy16_gdbarch_init): Don't register deleted functions with
3743         gdbarch.
3744
3745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * vax-tdep.c (vax_unwind_pc): Delete.
3748         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3749
3750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3751
3752         * v850-tdep.c (v850_unwind_sp): Delete.
3753         (v850_unwind_pc): Delete.
3754         (v850_dummy_id): Delete.
3755         (v850_gdbarch_init): Don't register deleted functions with
3756         gdbarch.
3757
3758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3759
3760         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3761         (tilegx_unwind_pc): Delete.
3762         (tilegx_unwind_dummy_id): Delete.
3763         (tilegx_gdbarch_init): Don't register deleted functions with
3764         gdbarch.
3765
3766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3767
3768         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3769         (tic6x_dummy_id): Delete.
3770         (tic6x_gdbarch_init): Don't register deleted functions with
3771         gdbarch.
3772
3773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3774
3775         * sparc-tdep.c (sparc_unwind_pc): Delete.
3776         (sparc32_gdbarch_init): Don't register deleted function with
3777         gdbarch.
3778
3779 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * sh-tdep.c (sh_unwind_sp): Delete.
3782         (sh_unwind_pc): Delete.
3783         (sh_dummy_id): Delete.
3784         (sh_gdbarch_init): Don't register deleted functions with
3785         gdbarch.
3786
3787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * score-tdep.c (score_unwind_sp): Delete.
3790         (score_unwind_pc): Delete.
3791         (score_dummy_id): Delete.
3792         (score_gdbarch_init): Don't register deleted functions with
3793         gdbarch.
3794
3795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3796
3797         * rx-tdep.c (rx_unwind_pc): Delete.
3798         (rx_unwind_sp): Delete.
3799         (rx_dummy_id): Delete.
3800         (rx_gdbarch_init): Don't register deleted functions with
3801         gdbarch.  Update comment.
3802
3803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3804
3805         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3806         (rs6000_dummy_id): Delete.
3807         (rs6000_gdbarch_init): Don't register deleted functions with
3808         gdbarch.
3809
3810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3811
3812         * or1k-tdep.c (or1k_dummy_id): Delete.
3813         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3814
3815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3816
3817         * nios2-tdep.c (nios2_dummy_id): Delete.
3818         (nios2_unwind_sp): Delete.
3819         (nios2_gdbarch_init): Don't register deleted functions with
3820         gdbarch.
3821
3822 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * nds32-tdep.c (nds32_dummy_id): Delete.
3825         (nds32_unwind_pc): Delete.
3826         (nds32_unwind_sp): Delete.
3827         (nds32_gdbarch_init): Don't register deleted functions with
3828         gdbarch.
3829
3830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * msp430-tdep.c (msp430_unwind_pc): Delete.
3833         (msp430_unwind_sp): Delete.
3834         (msp430_dummy_id): Delete.
3835         (msp430_gdbarch_init): Don't register deleted functions with
3836         gdbarch.
3837
3838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * moxie-tdep.c (moxie_unwind_sp): Delete.
3841         (moxie_unwind_pc): Delete.
3842         (moxie_dummy_id): Delete.
3843         (moxie_gdbarch_init): Don't register deleted functions with
3844         gdbarch.
3845
3846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3847
3848         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3849         (mn10300_unwind_pc): Delete.
3850         (mn10300_unwind_sp): Delete.
3851         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3852         mn10300_unwind_sp.
3853         (mn10300_frame_unwind_init): Don't register deleted functions with
3854         gdbarch.
3855
3856 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3857
3858         * mep-tdep.c (mep_unwind_pc): Delete.
3859         (mep_unwind_sp): Delete.
3860         (mep_dummy_id): Delete.
3861         (mep_gdbarch_init): Don't register deleted functions with
3862         gdbarch.
3863
3864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3867         (m68hc11_unwind_sp): Delete.
3868         (m68hc11_gdbarch_init): Don't register deleted functions with
3869         gdbarch.
3870
3871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         * m32r-tdep.c (m32r_unwind_sp): Delete.
3874         (m32r_unwind_pc): Delete.
3875         (m32r_dummy_id): Delete.
3876         (m32r_gdbarch_init): Don't register deleted functions with
3877         gdbarch.
3878
3879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3880
3881         * m32c-tdep.c (m32c_unwind_pc): Delete.
3882         (m32c_unwind_sp): Delete.
3883         (m32c_dummy_id): Delete.
3884         (m32c_gdbarch_init): Don't register deleted functions with
3885         gdbarch.
3886
3887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3888
3889         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3890         (lm32_unwind_pc): Delete.
3891         (lm32_dummy_id): Delete.
3892         (lm32_gdbarch_init): Don't register deleted functions with
3893         gdbarch.
3894
3895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3898         (iq2000_unwind_pc): Delete.
3899         (iq2000_dummy_id): Delete.
3900         (iq2000_gdbarch_init): Don't register deleted functions with
3901         gdbarch.
3902
3903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * nds32-tdep.c (nds32_type_align): Delete.
3906         (nds32_push_dummy_call): Use type_align instead.
3907
3908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3909
3910         * arm-tdep.c (arm_type_align): Only handle vector override case.
3911         (arm_push_dummy_call): Use type_align.
3912         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3913
3914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3915
3916         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3917         case.
3918         (pass_on_stack): Use type_align.
3919         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3920         function.
3921
3922 2019-04-23  Tom Tromey  <tromey@adacore.com>
3923
3924         * dwarf2read.c (line_header::file_name_at): Remove unused
3925         overload.
3926
3927 2019-04-23  Tom de Vries  <tdevries@suse.de>
3928
3929         PR gdb/24438
3930         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3931         invocation.
3932
3933
3934 2019-03-27  Ali Tamur  <tamur@google.com>
3935
3936         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3937         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3938         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3939         (dwarf_expr_context::get_addr_index): Likewise
3940         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3941         (symbol_needs_eval_context::get_addr_index): Likewise
3942         (disassemble_dwarf_expression): Add DW_OP_addrx
3943         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3944         (read_cutu_die_from_dwo): Update comment
3945         (skip_one_die): Add DW_FORM_addrx
3946         (read_attribute_value): Likewise
3947         (var_decode_location): Add DW_OP_addrx
3948         (dwarf2_const_value_attr): Add DW_FORM_addrx
3949         (dump_die_shallow): Likewise
3950         (dwarf2_fetch_constant_bytes): Likewise
3951         (decode_locdesc): Add DW_OP_addrx
3952         (skip_form_bytes): Add DW_FORM_addrx
3953
3954 2019-04-22  Ali Tamur  <tamur@google.com>
3955
3956         * MAINTAINERS (Write After Approval): Add self.
3957
3958 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3959
3960         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3961         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3962         (open_symbol_file_object): Likewise.
3963         (svr4_default_sos): Add info parameter.
3964         (svr4_read_so_list): Likewise.
3965         (svr4_current_sos_direct): Adjust functions calls to pass down
3966         info.
3967         (svr4_current_sos_1): Add info parameter.
3968         (svr4_current_sos): Call get_svr4_info, pass info down to
3969         svr4_current_sos_1.
3970         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3971         get_svr4_info.
3972         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3973         get_svr4_info.
3974         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3975         to get_svr4_info.
3976         (probes_table_remove_objfile_probes): Likewise.
3977         (register_solib_event_probe): Add info parameter.
3978         (solist_update_incremental): Pass info parameter down to
3979         svr4_read_so_list.
3980         (disable_probes_interface): Add info parameter.
3981         (svr4_handle_solib_event): Pass current_program_space to
3982         get_svr4_info.  Adjust disable_probes_interface cleanup.
3983         (svr4_create_probe_breakpoints): Add info parameter, pass it
3984         down to register_solib_event_probe.
3985         (svr4_create_solib_event_breakpoints): Add info parameter,
3986         pass it down to svr4_create_probe_breakpoints.
3987         (enable_break): Pass info down to
3988         svr4_create_solib_event_breakpoints.
3989         (svr4_solib_create_inferior_hook): Pass current_program_space to
3990         get_svr4_info.
3991         (svr4_clear_solib): Likewise.
3992
3993 2019-04-22  Pedro Alves  <palves@redhat.com>
3994
3995         * solib-svr4.c (svr4_free_objfile_observer): New.
3996         (probe_and_action::objfile): New field.
3997         (probes_table_htab_remove_objfile_probes)
3998         (probes_table_remove_objfile_probes): New functions.
3999         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4000         in the new probe_and_action.  Don't store the probe in 'lookup'.
4001         (svr4_create_probe_breakpoints): Pass objfile to
4002         register_solib_event_probe.
4003         (_initialize_svr4_solib): Register a free_objfile observer.
4004
4005 2019-04-19  Tom Tromey  <tom@tromey.com>
4006
4007         * common/queue.h: Remove.
4008
4009 2019-04-19  Tom Tromey  <tom@tromey.com>
4010
4011         * event-loop.c: Don't include "common/queue.h".
4012
4013 2019-04-19  Tom Tromey  <tom@tromey.com>
4014
4015         * remote.c (remote_target): Use delete.
4016         * remote-notif.h: Include <list>, not "common/queue.h".
4017         (notif_client_p): Remove typedef.
4018         (remote_notif_state): Add constructor, destructor, initializer.
4019         <notif_queue>: Now a std::list.
4020         (remote_notif_state_xfree): Don't declare.
4021         * remote-notif.c (remote_notif_process, handle_notification)
4022         (remote_notif_state_allocate): Update.
4023         (~remote_notif_state): Rename from remote_notif_state_xfree.
4024
4025 2019-04-19  Tom Tromey  <tom@tromey.com>
4026
4027         * symfile.c (reread_symbols): Update.
4028         * objfiles.c (objfile_register_static_link)
4029         (objfile_lookup_static_link): Update
4030         (~objfile) Don't delete static_links.
4031         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4032
4033 2019-04-19  Tom Tromey  <tom@tromey.com>
4034
4035         * type-stack.h (struct type_stack) <insert>: Constify string.
4036         * type-stack.c (type_stack::insert): Constify string.
4037         * gdbtypes.h (lookup_template_type): Update.
4038         (address_space_name_to_int): Update.
4039         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4040         const.
4041         (lookup_template_type): Make name const.
4042         * c-exp.y: Update rules.
4043         (lex_one_token, classify_name, classify_inner_name)
4044         (c_print_token): Update.
4045         * p-exp.y: Update rules.
4046         (yylex): Update.
4047         * f-exp.y: Update rules.
4048         (yylex): Update.
4049         * d-exp.y: Update rules.
4050         (lex_one_token, classify_name, classify_inner_name): Update.
4051         * parse.c (write_dollar_variable, copy_name): Return std::string.
4052         * parser-defs.h (copy_name): Change return type.
4053         * m2-exp.y: Update rules.
4054         (yylex): Update.
4055         * go-exp.y (lex_one_token): Update.
4056         Update rules.
4057         (classify_unsafe_function, classify_packaged_name)
4058         (classify_name, yylex): Update.
4059
4060 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4061
4062         * configure.ac: add --enable-source-highlight switch.
4063         * configure: Regenerate.
4064         * top.c (print_gdb_version): plumb --enable-source-highlight
4065         status to "show configuration".
4066
4067 2019-04-19  Tom Tromey  <tromey@adacore.com>
4068
4069         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4070         Check ADA_TYPE_P.
4071         (empty_record, ada_template_to_fixed_record_type_1)
4072         (template_to_static_fixed_type)
4073         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4074         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4075         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4076         macros.
4077
4078 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4079
4080         PR symtab/24423:
4081         * source.c (print_source_lines_base): Advance "iter" when a
4082         control character is seen.
4083
4084 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4085
4086         * inferior.h (struct infcall_suspend_state_deleter):
4087         Catch exception in destructor to avoid crash.
4088
4089 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4090
4091         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4092         close to the add_com "shell".
4093
4094 2019-04-18  Tom Tromey  <tromey@adacore.com>
4095
4096         * process-stratum-target.h (class process_stratum_target)
4097         <stratum>: Add "final".
4098
4099 2019-04-17  Tom Tromey  <tromey@adacore.com>
4100
4101         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4102         against nullptr before use.
4103
4104 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4105
4106         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4107
4108 2019-04-17  Jim Wilson  <jimw@sifive.com>
4109             Andrew Burgess  <andrew.burgess@embecosm.com>
4110
4111         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4112         code read might fail, assume 4-byte breakpoint in that case.
4113
4114 2019-04-15  Leszek Swirski  <leszeks@google.com>
4115
4116         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4117         rather than a hand-rolled POD check when checking for forced MEMORY
4118         classification.
4119
4120 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4121
4122         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4123         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4124         function.
4125         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4126         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4127         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4128         declaration.
4129
4130 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4131
4132         * aarch64-linux-nat.c
4133         (aarch64_linux_nat_target::thread_architecture): Add override.
4134         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4135         each VQ.
4136
4137 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4138
4139         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4140
4141 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4144         target types of size 96-bits, add some additional comments, and
4145         check that the builtin type we found was the correct size.
4146
4147 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4148
4149         * utils.c (prompt_for_continue): Don't restore the styling at the
4150         end, as applied_style has the wrong value.  This fixes styling in
4151         long lists of file names that are interrupted by the "Continue?"
4152         prompt.
4153
4154 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4155
4156         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4157         * c-lang.c (c_language_defn): Likewise.
4158         (cplus_language_defn): Likewise.
4159         (asm_language_defn): Likewise.
4160         (minimal_language_defn): Likewise.
4161         * d-lang.c (d_language_defn): Likewise.
4162         * f-lang.c (f_language_defn): Likewise.
4163         * go-lang.c (go_language_defn): Likewise.
4164         * language.c (unknown_language_defn): Likewise.
4165         (auto_language_defn): Likewise.
4166         * language.h (struct language_defn): Remove la_magic field.
4167         (LANG_MAGIC): Delete.
4168         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4169         * objc-lang.c (objc_language_defn): Likewise.
4170         * opencl-lang.c (opencl_language_defn): Likewise.
4171         * p-lang.c (pascal_language_defn): Likewise.
4172         * rust-lang.c (rust_language_defn): Likewise.
4173
4174 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4175
4176         * riscv-tdep.c (riscv_type_align): New function.
4177         (riscv_type_alignment): Delete.
4178         (riscv_arg_location): Use 'type_align'.
4179         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4180
4181 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * gdbtypes.c (type_align): A struct with no non-static fields also
4184         has alignment of 1.
4185
4186 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4187
4188         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4189         component to 0.
4190         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4191         member.
4192         (riscv_struct_info::analyse): New implementation using new
4193         analyse_inner member function.
4194         (riscv_struct_info::field_offset): New member function.
4195         (riscv_struct_info::m_offsets): New member variable.
4196         (riscv_struct_info::analyse_inner): New private member function,
4197         takes the old implementation of riscv_struct_info::analyse but
4198         extended to track field offsets.
4199         (riscv_call_arg_struct): Update the struct folding special cases
4200         to handle cases where empty C++ structs, which are non-zero
4201         length, are found.
4202         (riscv_arg_location): Initialise the length of each location, a
4203         non-zero length now indicates the location is in use.
4204         (riscv_push_dummy_call): Allow for the first location having a
4205         non-zero offset when setting up arguments.
4206         (riscv_return_value): Likewise, but for return values.
4207
4208 2019-04-11  Tom Tromey  <tromey@adacore.com>
4209
4210         * utils.c (internal_vproblem): Make "msg" const.
4211
4212 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4213
4214         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4215         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4216         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4217         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4218
4219 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4220
4221         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4222         function.
4223         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4224         of amd64_collect_native_gregset.
4225         (amd64_linux_nat_target::store_registers): Likewise.
4226
4227 2019-04-10  Tom Tromey  <tom@tromey.com>
4228
4229         * symtab.c (lookup_global_symbol_from_objfile)
4230         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4231         * objfiles.h (class separate_debug_iterator): New.
4232         (class separate_debug_range): New.
4233         (struct objfile) <separate_debug_objfiles>: New method.
4234         (objfile_separate_debug_iterate): Don't declare.
4235         * objfiles.c (separate_debug_iterator::operator++): Rename from
4236         objfile_separate_debug_iterate.
4237         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4238         iterator.
4239         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4240         iterator.
4241
4242 2019-04-10  Tom Tromey  <tom@tromey.com>
4243
4244         * symfile.c (reread_symbols): Remove old comment.
4245         * objfiles.c (free_all_objfiles): Fix a typo.
4246
4247 2019-04-10  Tom Tromey  <tom@tromey.com>
4248
4249         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4250         * minsyms.c (lookup_minimal_symbol): Use foreach.
4251         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4252         (lookup_minimal_symbol_solib_trampoline): Likewise.
4253         * symfile.c (reread_symbols): Use foreach.
4254
4255 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4256             Tom Tromey  <tromey@adacore.com>
4257
4258         PR rust/24414:
4259         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4260         (rust_lex_int_test): Change "value" to be LONGEST.
4261         (rust_lex_tests): Add test for long integer literal.
4262
4263 2019-04-09  Tom Tromey  <tromey@adacore.com>
4264
4265         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4266         to bool.
4267         (extended_remote_target::attach): Update.
4268         (remote_target::remote_notice_new_inferior): Update.
4269         (remote_target::add_current_inferior_and_thread): Update.
4270         * inferior.c (exit_inferior_1): Use "false".
4271         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4272
4273 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4274
4275         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4276         the "start" command.
4277
4278 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4279
4280         * python/py-inferior.c (infpy_thread_from_thread_handle):
4281         Adjust comments to reflect renaming of thread_from_thread_handle
4282         to thread_from_handle.  Adjust keywords.  Fix type error message.
4283         (inferior_object_methods): Add thread_from_handle.  Retain
4284         thread_from_thread_handle, but mark it as deprecated.
4285
4286 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4287
4288         * gdbthread.h (find_thread_by_handle): Revise declaration.
4289         * thread.c (find_thread_by_handle): Likewise.  Adjust
4290         implementation too.
4291         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4292         support for buffer objects as handles.
4293
4294 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4295
4296         * python/py-infthread.c (thpy_thread_handle): New function.
4297         (thread_object_methods): Register thpy_thread_handle.
4298
4299 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4300
4301         * gdbthread.h (thread_to_thread_handle): Declare.
4302         * thread.c (gdbtypes.h): Include.
4303         (thread_to_thread_handle): New function.
4304
4305         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4306         (target_thread_info_to_thread_handle): Declare.
4307         * target.c (target_thread_info_to_thread_handle): New function.
4308         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4309         * target-delegates.c: Regenerate.
4310
4311         * linux-thread-db.c (class thread_db_target): Add method
4312         thread_info_to_thread_handle.
4313         (thread_db_target::thread_info_to_thread_handle): Define.
4314         * remote.c (class remote_target): Add new method
4315         thread_info_to_thread_handle.
4316         (remote_target::thread_info_to_thread_handle): Define.
4317
4318 2019-04-08  Pedro Alves  <palves@redhat.com>
4319
4320         * common/common-exceptions.c (throw_exception): Don't create
4321         named object to throw; throw directly.
4322         (throw_it): Likewise.  Don't initialize gdb_exception::message
4323         here, with new; pass FMT and AP to the ctor instead.
4324         * common/common-exceptions.h: Include <string>.
4325         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4326         const char *, va_list)): New ctor.  Use std::make_shared.
4327         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4328         errors)): Delete.
4329         (gdb_exception_error::gdb_exception_error(enum errors, const char
4330         *, va_list)): New.
4331         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4332         Add assertion.
4333         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4334         errors)): Delete.
4335         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4336         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4337         Add assertion.
4338
4339 2019-04-08  Tom Tromey  <tom@tromey.com>
4340
4341         * valops.c (value_rtti_indirect_type): Replace throw_exception
4342         with throw.
4343         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4344         with throw.
4345         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4346         throw.
4347         * target.c (target_translate_tls_address): Replace throw_exception
4348         with throw.
4349         * stack.c (frame_apply_command_count): Replace throw_exception
4350         with throw.
4351         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4352         throw.
4353         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4354         with throw.
4355         * rs6000-tdep.c (rs6000_frame_cache)
4356         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4357         * remote.c: Replace throw_exception with throw.
4358         * record-full.c (record_full_message, record_full_wait_1)
4359         (record_full_restore): Replace throw_exception with throw.
4360         * record-btrace.c:
4361         (get_thread_current_frame_id, record_btrace_start_replaying)
4362         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4363         (cmd_record_btrace_start): Replace throw_exception with throw.
4364         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4365         throw.
4366         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4367         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4368         * linespec.c:
4369         (find_linespec_symbols): Replace throw_exception with throw.
4370         * infrun.c (displaced_step_prepare, resume): Replace
4371         throw_exception with throw.
4372         * infcmd.c (post_create_inferior): Replace throw_exception with
4373         throw.
4374         * inf-loop.c (inferior_event_handler): Replace throw_exception
4375         with throw.
4376         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4377         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4378         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4379         (get_prev_frame_always, get_frame_pc_if_available)
4380         (get_frame_address_in_block_if_available, get_frame_language):
4381         Replace throw_exception with throw.
4382         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4383         throw_exception with throw.
4384         * eval.c (fetch_subexp_value, evaluate_var_value)
4385         (evaluate_funcall, evaluate_subexp_standard): Replace
4386         throw_exception with throw.
4387         * dwarf2loc.c (call_site_find_chain)
4388         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4389         Replace throw_exception with throw.
4390         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4391         with throw.
4392         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4393         throw.
4394         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4395         * completer.c (complete_line_internal): Replace throw_exception
4396         with throw.
4397         * compile/compile-object-run.c (compile_object_run): Replace
4398         throw_exception with throw.
4399         * cli/cli-script.c (process_next_line): Replace throw_exception
4400         with throw.
4401         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4402         (btrace_enable, btrace_maint_update_pt_packets): Replace
4403         throw_exception with throw.
4404         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4405         throw_exception with throw.
4406         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4407         throw_exception with throw.
4408         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4409         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4410         * aarch64-tdep.c (aarch64_make_prologue_cache)
4411         (aarch64_make_stub_cache): Replace throw_exception with throw.
4412
4413 2019-04-08  Tom Tromey  <tom@tromey.com>
4414
4415         * common/common-exceptions.c (throw_exception): Rename from
4416         throw_exception_cxx.  Remove old copy.  Make argument const.
4417         (throw_it): Create and throw exception objects directly.
4418         * common/common-exceptions.h (throw_exception): Make argument
4419         const.
4420         (struct gdb_exception_error): Add constructor.
4421         (struct gdb_exception_quit): Add constructor.
4422
4423 2019-04-08  Tom Tromey  <tom@tromey.com>
4424
4425         * common/common-exceptions.h (exception_rethrow): Don't declare.
4426         (TRY_SJLJ): Update comment.
4427         (TRY, CATCH, END_CATCH): Remove.
4428         * common/common-exceptions.c (exception_rethrow): Remove.
4429
4430 2019-04-08  Tom Tromey  <tom@tromey.com>
4431
4432         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4433         Remove.
4434         (gdb_exception_error): Rename from
4435         gdb_exception_RETURN_MASK_ERROR.
4436         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4437         (gdb_quit_bad_alloc): Update.
4438         * aarch64-tdep.c: Update.
4439         * ada-lang.c: Update.
4440         * ada-typeprint.c: Update.
4441         * ada-valprint.c: Update.
4442         * amd64-tdep.c: Update.
4443         * arch-utils.c: Update.
4444         * break-catch-throw.c: Update.
4445         * breakpoint.c: Update.
4446         * btrace.c: Update.
4447         * c-varobj.c: Update.
4448         * cli/cli-cmds.c: Update.
4449         * cli/cli-interp.c: Update.
4450         * cli/cli-script.c: Update.
4451         * common/common-exceptions.c: Update.
4452         * common/new-op.c: Update.
4453         * common/selftest.c: Update.
4454         * compile/compile-c-symbols.c: Update.
4455         * compile/compile-cplus-symbols.c: Update.
4456         * compile/compile-object-load.c: Update.
4457         * compile/compile-object-run.c: Update.
4458         * completer.c: Update.
4459         * corelow.c: Update.
4460         * cp-abi.c: Update.
4461         * cp-support.c: Update.
4462         * cp-valprint.c: Update.
4463         * darwin-nat.c: Update.
4464         * disasm-selftests.c: Update.
4465         * dtrace-probe.c: Update.
4466         * dwarf-index-cache.c: Update.
4467         * dwarf-index-write.c: Update.
4468         * dwarf2-frame-tailcall.c: Update.
4469         * dwarf2-frame.c: Update.
4470         * dwarf2loc.c: Update.
4471         * dwarf2read.c: Update.
4472         * eval.c: Update.
4473         * event-loop.c: Update.
4474         * event-top.c: Update.
4475         * exec.c: Update.
4476         * f-valprint.c: Update.
4477         * fbsd-tdep.c: Update.
4478         * frame-unwind.c: Update.
4479         * frame.c: Update.
4480         * gdbtypes.c: Update.
4481         * gnu-v3-abi.c: Update.
4482         * guile/guile-internal.h: Update.
4483         * guile/scm-block.c: Update.
4484         * guile/scm-breakpoint.c: Update.
4485         * guile/scm-cmd.c: Update.
4486         * guile/scm-disasm.c: Update.
4487         * guile/scm-frame.c: Update.
4488         * guile/scm-lazy-string.c: Update.
4489         * guile/scm-math.c: Update.
4490         * guile/scm-param.c: Update.
4491         * guile/scm-ports.c: Update.
4492         * guile/scm-pretty-print.c: Update.
4493         * guile/scm-symbol.c: Update.
4494         * guile/scm-symtab.c: Update.
4495         * guile/scm-type.c: Update.
4496         * guile/scm-value.c: Update.
4497         * i386-linux-tdep.c: Update.
4498         * i386-tdep.c: Update.
4499         * inf-loop.c: Update.
4500         * infcall.c: Update.
4501         * infcmd.c: Update.
4502         * infrun.c: Update.
4503         * jit.c: Update.
4504         * language.c: Update.
4505         * linespec.c: Update.
4506         * linux-fork.c: Update.
4507         * linux-nat.c: Update.
4508         * linux-tdep.c: Update.
4509         * linux-thread-db.c: Update.
4510         * main.c: Update.
4511         * mi/mi-cmd-break.c: Update.
4512         * mi/mi-cmd-stack.c: Update.
4513         * mi/mi-interp.c: Update.
4514         * mi/mi-main.c: Update.
4515         * objc-lang.c: Update.
4516         * p-valprint.c: Update.
4517         * parse.c: Update.
4518         * ppc-linux-tdep.c: Update.
4519         * printcmd.c: Update.
4520         * python/py-arch.c: Update.
4521         * python/py-breakpoint.c: Update.
4522         * python/py-cmd.c: Update.
4523         * python/py-finishbreakpoint.c: Update.
4524         * python/py-frame.c: Update.
4525         * python/py-framefilter.c: Update.
4526         * python/py-gdb-readline.c: Update.
4527         * python/py-inferior.c: Update.
4528         * python/py-infthread.c: Update.
4529         * python/py-lazy-string.c: Update.
4530         * python/py-linetable.c: Update.
4531         * python/py-objfile.c: Update.
4532         * python/py-param.c: Update.
4533         * python/py-prettyprint.c: Update.
4534         * python/py-progspace.c: Update.
4535         * python/py-record-btrace.c: Update.
4536         * python/py-record.c: Update.
4537         * python/py-symbol.c: Update.
4538         * python/py-type.c: Update.
4539         * python/py-unwind.c: Update.
4540         * python/py-utils.c: Update.
4541         * python/py-value.c: Update.
4542         * python/python.c: Update.
4543         * record-btrace.c: Update.
4544         * record-full.c: Update.
4545         * remote-fileio.c: Update.
4546         * remote.c: Update.
4547         * riscv-tdep.c: Update.
4548         * rs6000-aix-tdep.c: Update.
4549         * rs6000-tdep.c: Update.
4550         * rust-exp.y: Update.
4551         * rust-lang.c: Update.
4552         * s390-tdep.c: Update.
4553         * selftest-arch.c: Update.
4554         * solib-dsbt.c: Update.
4555         * solib-frv.c: Update.
4556         * solib-spu.c: Update.
4557         * solib-svr4.c: Update.
4558         * solib.c: Update.
4559         * sparc64-linux-tdep.c: Update.
4560         * stack.c: Update.
4561         * symfile-mem.c: Update.
4562         * symmisc.c: Update.
4563         * target.c: Update.
4564         * thread.c: Update.
4565         * top.c: Update.
4566         * tracefile-tfile.c: Update.
4567         * tui/tui.c: Update.
4568         * typeprint.c: Update.
4569         * unittests/cli-utils-selftests.c: Update.
4570         * unittests/parse-connection-spec-selftests.c: Update.
4571         * valops.c: Update.
4572         * valprint.c: Update.
4573         * value.c: Update.
4574         * varobj.c: Update.
4575         * windows-nat.c: Update.
4576         * x86-linux-nat.c: Update.
4577         * xml-support.c: Update.
4578
4579 2019-04-08  Tom Tromey  <tom@tromey.com>
4580
4581         * xml-support.c: Use C++ exception handling.
4582         * x86-linux-nat.c: Use C++ exception handling.
4583         * windows-nat.c: Use C++ exception handling.
4584         * varobj.c: Use C++ exception handling.
4585         * value.c: Use C++ exception handling.
4586         * valprint.c: Use C++ exception handling.
4587         * valops.c: Use C++ exception handling.
4588         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4589         handling.
4590         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4591         * typeprint.c: Use C++ exception handling.
4592         * tui/tui.c: Use C++ exception handling.
4593         * tracefile-tfile.c: Use C++ exception handling.
4594         * top.c: Use C++ exception handling.
4595         * thread.c: Use C++ exception handling.
4596         * target.c: Use C++ exception handling.
4597         * symmisc.c: Use C++ exception handling.
4598         * symfile-mem.c: Use C++ exception handling.
4599         * stack.c: Use C++ exception handling.
4600         * sparc64-linux-tdep.c: Use C++ exception handling.
4601         * solib.c: Use C++ exception handling.
4602         * solib-svr4.c: Use C++ exception handling.
4603         * solib-spu.c: Use C++ exception handling.
4604         * solib-frv.c: Use C++ exception handling.
4605         * solib-dsbt.c: Use C++ exception handling.
4606         * selftest-arch.c: Use C++ exception handling.
4607         * s390-tdep.c: Use C++ exception handling.
4608         * rust-lang.c: Use C++ exception handling.
4609         * rust-exp.y: Use C++ exception handling.
4610         * rs6000-tdep.c: Use C++ exception handling.
4611         * rs6000-aix-tdep.c: Use C++ exception handling.
4612         * riscv-tdep.c: Use C++ exception handling.
4613         * remote.c: Use C++ exception handling.
4614         * remote-fileio.c: Use C++ exception handling.
4615         * record-full.c: Use C++ exception handling.
4616         * record-btrace.c: Use C++ exception handling.
4617         * python/python.c: Use C++ exception handling.
4618         * python/py-value.c: Use C++ exception handling.
4619         * python/py-utils.c: Use C++ exception handling.
4620         * python/py-unwind.c: Use C++ exception handling.
4621         * python/py-type.c: Use C++ exception handling.
4622         * python/py-symbol.c: Use C++ exception handling.
4623         * python/py-record.c: Use C++ exception handling.
4624         * python/py-record-btrace.c: Use C++ exception handling.
4625         * python/py-progspace.c: Use C++ exception handling.
4626         * python/py-prettyprint.c: Use C++ exception handling.
4627         * python/py-param.c: Use C++ exception handling.
4628         * python/py-objfile.c: Use C++ exception handling.
4629         * python/py-linetable.c: Use C++ exception handling.
4630         * python/py-lazy-string.c: Use C++ exception handling.
4631         * python/py-infthread.c: Use C++ exception handling.
4632         * python/py-inferior.c: Use C++ exception handling.
4633         * python/py-gdb-readline.c: Use C++ exception handling.
4634         * python/py-framefilter.c: Use C++ exception handling.
4635         * python/py-frame.c: Use C++ exception handling.
4636         * python/py-finishbreakpoint.c: Use C++ exception handling.
4637         * python/py-cmd.c: Use C++ exception handling.
4638         * python/py-breakpoint.c: Use C++ exception handling.
4639         * python/py-arch.c: Use C++ exception handling.
4640         * printcmd.c: Use C++ exception handling.
4641         * ppc-linux-tdep.c: Use C++ exception handling.
4642         * parse.c: Use C++ exception handling.
4643         * p-valprint.c: Use C++ exception handling.
4644         * objc-lang.c: Use C++ exception handling.
4645         * mi/mi-main.c: Use C++ exception handling.
4646         * mi/mi-interp.c: Use C++ exception handling.
4647         * mi/mi-cmd-stack.c: Use C++ exception handling.
4648         * mi/mi-cmd-break.c: Use C++ exception handling.
4649         * main.c: Use C++ exception handling.
4650         * linux-thread-db.c: Use C++ exception handling.
4651         * linux-tdep.c: Use C++ exception handling.
4652         * linux-nat.c: Use C++ exception handling.
4653         * linux-fork.c: Use C++ exception handling.
4654         * linespec.c: Use C++ exception handling.
4655         * language.c: Use C++ exception handling.
4656         * jit.c: Use C++ exception handling.
4657         * infrun.c: Use C++ exception handling.
4658         * infcmd.c: Use C++ exception handling.
4659         * infcall.c: Use C++ exception handling.
4660         * inf-loop.c: Use C++ exception handling.
4661         * i386-tdep.c: Use C++ exception handling.
4662         * i386-linux-tdep.c: Use C++ exception handling.
4663         * guile/scm-value.c: Use C++ exception handling.
4664         * guile/scm-type.c: Use C++ exception handling.
4665         * guile/scm-symtab.c: Use C++ exception handling.
4666         * guile/scm-symbol.c: Use C++ exception handling.
4667         * guile/scm-pretty-print.c: Use C++ exception handling.
4668         * guile/scm-ports.c: Use C++ exception handling.
4669         * guile/scm-param.c: Use C++ exception handling.
4670         * guile/scm-math.c: Use C++ exception handling.
4671         * guile/scm-lazy-string.c: Use C++ exception handling.
4672         * guile/scm-frame.c: Use C++ exception handling.
4673         * guile/scm-disasm.c: Use C++ exception handling.
4674         * guile/scm-cmd.c: Use C++ exception handling.
4675         * guile/scm-breakpoint.c: Use C++ exception handling.
4676         * guile/scm-block.c: Use C++ exception handling.
4677         * guile/guile-internal.h: Use C++ exception handling.
4678         * gnu-v3-abi.c: Use C++ exception handling.
4679         * gdbtypes.c: Use C++ exception handling.
4680         * frame.c: Use C++ exception handling.
4681         * frame-unwind.c: Use C++ exception handling.
4682         * fbsd-tdep.c: Use C++ exception handling.
4683         * f-valprint.c: Use C++ exception handling.
4684         * exec.c: Use C++ exception handling.
4685         * event-top.c: Use C++ exception handling.
4686         * event-loop.c: Use C++ exception handling.
4687         * eval.c: Use C++ exception handling.
4688         * dwarf2read.c: Use C++ exception handling.
4689         * dwarf2loc.c: Use C++ exception handling.
4690         * dwarf2-frame.c: Use C++ exception handling.
4691         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4692         * dwarf-index-write.c: Use C++ exception handling.
4693         * dwarf-index-cache.c: Use C++ exception handling.
4694         * dtrace-probe.c: Use C++ exception handling.
4695         * disasm-selftests.c: Use C++ exception handling.
4696         * darwin-nat.c: Use C++ exception handling.
4697         * cp-valprint.c: Use C++ exception handling.
4698         * cp-support.c: Use C++ exception handling.
4699         * cp-abi.c: Use C++ exception handling.
4700         * corelow.c: Use C++ exception handling.
4701         * completer.c: Use C++ exception handling.
4702         * compile/compile-object-run.c: Use C++ exception handling.
4703         * compile/compile-object-load.c: Use C++ exception handling.
4704         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4705         * compile/compile-c-symbols.c: Use C++ exception handling.
4706         * common/selftest.c: Use C++ exception handling.
4707         * common/new-op.c: Use C++ exception handling.
4708         * cli/cli-script.c: Use C++ exception handling.
4709         * cli/cli-interp.c: Use C++ exception handling.
4710         * cli/cli-cmds.c: Use C++ exception handling.
4711         * c-varobj.c: Use C++ exception handling.
4712         * btrace.c: Use C++ exception handling.
4713         * breakpoint.c: Use C++ exception handling.
4714         * break-catch-throw.c: Use C++ exception handling.
4715         * arch-utils.c: Use C++ exception handling.
4716         * amd64-tdep.c: Use C++ exception handling.
4717         * ada-valprint.c: Use C++ exception handling.
4718         * ada-typeprint.c: Use C++ exception handling.
4719         * ada-lang.c: Use C++ exception handling.
4720         * aarch64-tdep.c: Use C++ exception handling.
4721
4722 2019-04-08  Tom Tromey  <tom@tromey.com>
4723
4724         * xml-support.c (gdb_xml_parser::parse): Update.
4725         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4726         * value.c (show_convenience): Update.
4727         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4728         (test_parse_flags_qcs): Update.
4729         * thread.c (thr_try_catch_cmd): Update.
4730         * target.c (target_translate_tls_address): Update.
4731         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4732         (info_frame_command_core, frame_apply_command_count): Update.
4733         * rust-exp.y (rust_lex_exception_test): Update.
4734         * riscv-tdep.c (riscv_print_one_register_info): Update.
4735         * remote.c (remote_target::enable_btrace): Update.
4736         * record-btrace.c (record_btrace_enable_warn): Update.
4737         * python/py-utils.c (gdbpy_convert_exception): Update.
4738         * printcmd.c (do_one_display, print_variable_and_value): Update.
4739         * mi/mi-main.c (mi_print_exception): Update.
4740         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4741         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4742         * linux-nat.c (linux_nat_target::attach): Update.
4743         * linux-fork.c (class scoped_switch_fork_info): Update.
4744         * infrun.c (displaced_step_prepare): Update.
4745         * infcall.c (call_function_by_hand_dummy): Update.
4746         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4747         * gnu-v3-abi.c (print_one_vtable): Update.
4748         * frame.c (get_prev_frame_always): Update.
4749         * f-valprint.c (info_common_command_for_block): Update.
4750         * exec.c (try_open_exec_file): Update.
4751         * exceptions.c (print_exception, exception_print)
4752         (exception_fprintf, exception_print_same): Update.
4753         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4754         * dwarf-index-cache.c (index_cache::store)
4755         (index_cache::lookup_gdb_index): Update.
4756         * darwin-nat.c (maybe_cache_shell): Update.
4757         * cp-valprint.c (cp_print_value_fields): Update.
4758         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4759         (gcc_cplus_symbol_address): Update.
4760         * compile/compile-c-symbols.c (gcc_convert_symbol)
4761         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4762         * common/selftest.c: Update.
4763         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4764         a std::string.
4765         (exception_try_scope_entry, exception_try_scope_exit): Don't
4766         declare.
4767         (struct exception_try_scope): Remove.
4768         (TRY): Don't use exception_try_scope.
4769         (struct gdb_exception): Add constructor, operator=.
4770         <what>: New method.
4771         (struct gdb_exception_RETURN_MASK_ALL)
4772         (struct gdb_exception_RETURN_MASK_ERROR)
4773         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4774         (struct gdb_quit_bad_alloc): Update.
4775         * common/common-exceptions.c (exception_none): Change
4776         initializer.
4777         (struct catcher) <state, exception>: Initialize inline.
4778         <prev>: Remove member.
4779         (current_catcher): Remove.
4780         (catchers): New global.
4781         (exceptions_state_mc_init): Simplify.
4782         (catcher_pop): Remove.
4783         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4784         (try_scope_depth, exception_try_scope_entry)
4785         (exception_try_scope_exit): Remove.
4786         (throw_exception_sjlj): Update.
4787         (exception_messages, exception_messages_size): Remove.
4788         (throw_it): Simplify.
4789         (gdb_exception_sliced_copy): Remove.
4790         (throw_exception_cxx): Update.
4791         * cli/cli-script.c (script_from_file): Update.
4792         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4793         Update.
4794         * ada-valprint.c (ada_val_print): Update.
4795         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4796         (create_excep_cond_exprs): Update.
4797
4798 2019-04-08  Tom Tromey  <tom@tromey.com>
4799
4800         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4801         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4802         (TRY, CATCH, END_CATCH): Remove some definitions.
4803         * common/common-exceptions.c: Don't use GDB_XCPT.
4804         (catcher_list_size): Remove.
4805         (throw_exception, throw_it): Simplify.
4806
4807 2019-04-05  Tom Tromey  <tom@tromey.com>
4808
4809         Revert the header-sorting patch.
4810         * ft32-tdep.c: Revert.
4811         * frv-tdep.c: Revert.
4812         * frv-linux-tdep.c: Revert.
4813         * frame.c: Revert.
4814         * frame-unwind.c: Revert.
4815         * frame-base.c: Revert.
4816         * fork-child.c: Revert.
4817         * findvar.c: Revert.
4818         * findcmd.c: Revert.
4819         * filesystem.c: Revert.
4820         * filename-seen-cache.h: Revert.
4821         * filename-seen-cache.c: Revert.
4822         * fbsd-tdep.c: Revert.
4823         * fbsd-nat.h: Revert.
4824         * fbsd-nat.c: Revert.
4825         * f-valprint.c: Revert.
4826         * f-typeprint.c: Revert.
4827         * f-lang.c: Revert.
4828         * extension.h: Revert.
4829         * extension.c: Revert.
4830         * extension-priv.h: Revert.
4831         * expprint.c: Revert.
4832         * exec.h: Revert.
4833         * exec.c: Revert.
4834         * exceptions.c: Revert.
4835         * event-top.c: Revert.
4836         * event-loop.c: Revert.
4837         * eval.c: Revert.
4838         * elfread.c: Revert.
4839         * dwarf2read.h: Revert.
4840         * dwarf2read.c: Revert.
4841         * dwarf2loc.c: Revert.
4842         * dwarf2expr.h: Revert.
4843         * dwarf2expr.c: Revert.
4844         * dwarf2-frame.c: Revert.
4845         * dwarf2-frame-tailcall.c: Revert.
4846         * dwarf-index-write.h: Revert.
4847         * dwarf-index-write.c: Revert.
4848         * dwarf-index-common.c: Revert.
4849         * dwarf-index-cache.h: Revert.
4850         * dwarf-index-cache.c: Revert.
4851         * dummy-frame.c: Revert.
4852         * dtrace-probe.c: Revert.
4853         * disasm.h: Revert.
4854         * disasm.c: Revert.
4855         * disasm-selftests.c: Revert.
4856         * dictionary.c: Revert.
4857         * dicos-tdep.c: Revert.
4858         * demangle.c: Revert.
4859         * dcache.h: Revert.
4860         * dcache.c: Revert.
4861         * darwin-nat.h: Revert.
4862         * darwin-nat.c: Revert.
4863         * darwin-nat-info.c: Revert.
4864         * d-valprint.c: Revert.
4865         * d-namespace.c: Revert.
4866         * d-lang.c: Revert.
4867         * ctf.c: Revert.
4868         * csky-tdep.c: Revert.
4869         * csky-linux-tdep.c: Revert.
4870         * cris-tdep.c: Revert.
4871         * cris-linux-tdep.c: Revert.
4872         * cp-valprint.c: Revert.
4873         * cp-support.c: Revert.
4874         * cp-namespace.c: Revert.
4875         * cp-abi.c: Revert.
4876         * corelow.c: Revert.
4877         * corefile.c: Revert.
4878         * continuations.c: Revert.
4879         * completer.h: Revert.
4880         * completer.c: Revert.
4881         * complaints.c: Revert.
4882         * coffread.c: Revert.
4883         * coff-pe-read.c: Revert.
4884         * cli-out.h: Revert.
4885         * cli-out.c: Revert.
4886         * charset.c: Revert.
4887         * c-varobj.c: Revert.
4888         * c-valprint.c: Revert.
4889         * c-typeprint.c: Revert.
4890         * c-lang.c: Revert.
4891         * buildsym.c: Revert.
4892         * buildsym-legacy.c: Revert.
4893         * build-id.h: Revert.
4894         * build-id.c: Revert.
4895         * btrace.c: Revert.
4896         * bsd-uthread.c: Revert.
4897         * breakpoint.h: Revert.
4898         * breakpoint.c: Revert.
4899         * break-catch-throw.c: Revert.
4900         * break-catch-syscall.c: Revert.
4901         * break-catch-sig.c: Revert.
4902         * blockframe.c: Revert.
4903         * block.c: Revert.
4904         * bfin-tdep.c: Revert.
4905         * bfin-linux-tdep.c: Revert.
4906         * bfd-target.c: Revert.
4907         * bcache.c: Revert.
4908         * ax-general.c: Revert.
4909         * ax-gdb.h: Revert.
4910         * ax-gdb.c: Revert.
4911         * avr-tdep.c: Revert.
4912         * auxv.c: Revert.
4913         * auto-load.c: Revert.
4914         * arm-wince-tdep.c: Revert.
4915         * arm-tdep.c: Revert.
4916         * arm-symbian-tdep.c: Revert.
4917         * arm-pikeos-tdep.c: Revert.
4918         * arm-obsd-tdep.c: Revert.
4919         * arm-nbsd-tdep.c: Revert.
4920         * arm-nbsd-nat.c: Revert.
4921         * arm-linux-tdep.c: Revert.
4922         * arm-linux-nat.c: Revert.
4923         * arm-fbsd-tdep.c: Revert.
4924         * arm-fbsd-nat.c: Revert.
4925         * arm-bsd-tdep.c: Revert.
4926         * arch-utils.c: Revert.
4927         * arc-tdep.c: Revert.
4928         * arc-newlib-tdep.c: Revert.
4929         * annotate.h: Revert.
4930         * annotate.c: Revert.
4931         * amd64-windows-tdep.c: Revert.
4932         * amd64-windows-nat.c: Revert.
4933         * amd64-tdep.c: Revert.
4934         * amd64-sol2-tdep.c: Revert.
4935         * amd64-obsd-tdep.c: Revert.
4936         * amd64-obsd-nat.c: Revert.
4937         * amd64-nbsd-tdep.c: Revert.
4938         * amd64-nbsd-nat.c: Revert.
4939         * amd64-nat.c: Revert.
4940         * amd64-linux-tdep.c: Revert.
4941         * amd64-linux-nat.c: Revert.
4942         * amd64-fbsd-tdep.c: Revert.
4943         * amd64-fbsd-nat.c: Revert.
4944         * amd64-dicos-tdep.c: Revert.
4945         * amd64-darwin-tdep.c: Revert.
4946         * amd64-bsd-nat.c: Revert.
4947         * alpha-tdep.c: Revert.
4948         * alpha-obsd-tdep.c: Revert.
4949         * alpha-nbsd-tdep.c: Revert.
4950         * alpha-mdebug-tdep.c: Revert.
4951         * alpha-linux-tdep.c: Revert.
4952         * alpha-linux-nat.c: Revert.
4953         * alpha-bsd-tdep.c: Revert.
4954         * alpha-bsd-nat.c: Revert.
4955         * aix-thread.c: Revert.
4956         * agent.c: Revert.
4957         * addrmap.c: Revert.
4958         * ada-varobj.c: Revert.
4959         * ada-valprint.c: Revert.
4960         * ada-typeprint.c: Revert.
4961         * ada-tasks.c: Revert.
4962         * ada-lang.c: Revert.
4963         * aarch64-tdep.c: Revert.
4964         * aarch64-ravenscar-thread.c: Revert.
4965         * aarch64-newlib-tdep.c: Revert.
4966         * aarch64-linux-tdep.c: Revert.
4967         * aarch64-linux-nat.c: Revert.
4968         * aarch64-fbsd-tdep.c: Revert.
4969         * aarch64-fbsd-nat.c: Revert.
4970         * aarch32-linux-nat.c: Revert.
4971
4972 2019-04-05  Tom Tromey  <tom@tromey.com>
4973
4974         * ft32-tdep.c: Sort headers.
4975         * frv-tdep.c: Sort headers.
4976         * frv-linux-tdep.c: Sort headers.
4977         * frame.c: Sort headers.
4978         * frame-unwind.c: Sort headers.
4979         * frame-base.c: Sort headers.
4980         * fork-child.c: Sort headers.
4981         * findvar.c: Sort headers.
4982         * findcmd.c: Sort headers.
4983         * filesystem.c: Sort headers.
4984         * filename-seen-cache.h: Sort headers.
4985         * filename-seen-cache.c: Sort headers.
4986         * fbsd-tdep.c: Sort headers.
4987         * fbsd-nat.h: Sort headers.
4988         * fbsd-nat.c: Sort headers.
4989         * f-valprint.c: Sort headers.
4990         * f-typeprint.c: Sort headers.
4991         * f-lang.c: Sort headers.
4992         * extension.h: Sort headers.
4993         * extension.c: Sort headers.
4994         * extension-priv.h: Sort headers.
4995         * expprint.c: Sort headers.
4996         * exec.h: Sort headers.
4997         * exec.c: Sort headers.
4998         * exceptions.c: Sort headers.
4999         * event-top.c: Sort headers.
5000         * event-loop.c: Sort headers.
5001         * eval.c: Sort headers.
5002         * elfread.c: Sort headers.
5003         * dwarf2read.h: Sort headers.
5004         * dwarf2read.c: Sort headers.
5005         * dwarf2loc.c: Sort headers.
5006         * dwarf2expr.h: Sort headers.
5007         * dwarf2expr.c: Sort headers.
5008         * dwarf2-frame.c: Sort headers.
5009         * dwarf2-frame-tailcall.c: Sort headers.
5010         * dwarf-index-write.h: Sort headers.
5011         * dwarf-index-write.c: Sort headers.
5012         * dwarf-index-common.c: Sort headers.
5013         * dwarf-index-cache.h: Sort headers.
5014         * dwarf-index-cache.c: Sort headers.
5015         * dummy-frame.c: Sort headers.
5016         * dtrace-probe.c: Sort headers.
5017         * disasm.h: Sort headers.
5018         * disasm.c: Sort headers.
5019         * disasm-selftests.c: Sort headers.
5020         * dictionary.c: Sort headers.
5021         * dicos-tdep.c: Sort headers.
5022         * demangle.c: Sort headers.
5023         * dcache.h: Sort headers.
5024         * dcache.c: Sort headers.
5025         * darwin-nat.h: Sort headers.
5026         * darwin-nat.c: Sort headers.
5027         * darwin-nat-info.c: Sort headers.
5028         * d-valprint.c: Sort headers.
5029         * d-namespace.c: Sort headers.
5030         * d-lang.c: Sort headers.
5031         * ctf.c: Sort headers.
5032         * csky-tdep.c: Sort headers.
5033         * csky-linux-tdep.c: Sort headers.
5034         * cris-tdep.c: Sort headers.
5035         * cris-linux-tdep.c: Sort headers.
5036         * cp-valprint.c: Sort headers.
5037         * cp-support.c: Sort headers.
5038         * cp-namespace.c: Sort headers.
5039         * cp-abi.c: Sort headers.
5040         * corelow.c: Sort headers.
5041         * corefile.c: Sort headers.
5042         * continuations.c: Sort headers.
5043         * completer.h: Sort headers.
5044         * completer.c: Sort headers.
5045         * complaints.c: Sort headers.
5046         * coffread.c: Sort headers.
5047         * coff-pe-read.c: Sort headers.
5048         * cli-out.h: Sort headers.
5049         * cli-out.c: Sort headers.
5050         * charset.c: Sort headers.
5051         * c-varobj.c: Sort headers.
5052         * c-valprint.c: Sort headers.
5053         * c-typeprint.c: Sort headers.
5054         * c-lang.c: Sort headers.
5055         * buildsym.c: Sort headers.
5056         * buildsym-legacy.c: Sort headers.
5057         * build-id.h: Sort headers.
5058         * build-id.c: Sort headers.
5059         * btrace.c: Sort headers.
5060         * bsd-uthread.c: Sort headers.
5061         * breakpoint.h: Sort headers.
5062         * breakpoint.c: Sort headers.
5063         * break-catch-throw.c: Sort headers.
5064         * break-catch-syscall.c: Sort headers.
5065         * break-catch-sig.c: Sort headers.
5066         * blockframe.c: Sort headers.
5067         * block.c: Sort headers.
5068         * bfin-tdep.c: Sort headers.
5069         * bfin-linux-tdep.c: Sort headers.
5070         * bfd-target.c: Sort headers.
5071         * bcache.c: Sort headers.
5072         * ax-general.c: Sort headers.
5073         * ax-gdb.h: Sort headers.
5074         * ax-gdb.c: Sort headers.
5075         * avr-tdep.c: Sort headers.
5076         * auxv.c: Sort headers.
5077         * auto-load.c: Sort headers.
5078         * arm-wince-tdep.c: Sort headers.
5079         * arm-tdep.c: Sort headers.
5080         * arm-symbian-tdep.c: Sort headers.
5081         * arm-pikeos-tdep.c: Sort headers.
5082         * arm-obsd-tdep.c: Sort headers.
5083         * arm-nbsd-tdep.c: Sort headers.
5084         * arm-nbsd-nat.c: Sort headers.
5085         * arm-linux-tdep.c: Sort headers.
5086         * arm-linux-nat.c: Sort headers.
5087         * arm-fbsd-tdep.c: Sort headers.
5088         * arm-fbsd-nat.c: Sort headers.
5089         * arm-bsd-tdep.c: Sort headers.
5090         * arch-utils.c: Sort headers.
5091         * arc-tdep.c: Sort headers.
5092         * arc-newlib-tdep.c: Sort headers.
5093         * annotate.h: Sort headers.
5094         * annotate.c: Sort headers.
5095         * amd64-windows-tdep.c: Sort headers.
5096         * amd64-windows-nat.c: Sort headers.
5097         * amd64-tdep.c: Sort headers.
5098         * amd64-sol2-tdep.c: Sort headers.
5099         * amd64-obsd-tdep.c: Sort headers.
5100         * amd64-obsd-nat.c: Sort headers.
5101         * amd64-nbsd-tdep.c: Sort headers.
5102         * amd64-nbsd-nat.c: Sort headers.
5103         * amd64-nat.c: Sort headers.
5104         * amd64-linux-tdep.c: Sort headers.
5105         * amd64-linux-nat.c: Sort headers.
5106         * amd64-fbsd-tdep.c: Sort headers.
5107         * amd64-fbsd-nat.c: Sort headers.
5108         * amd64-dicos-tdep.c: Sort headers.
5109         * amd64-darwin-tdep.c: Sort headers.
5110         * amd64-bsd-nat.c: Sort headers.
5111         * alpha-tdep.c: Sort headers.
5112         * alpha-obsd-tdep.c: Sort headers.
5113         * alpha-nbsd-tdep.c: Sort headers.
5114         * alpha-mdebug-tdep.c: Sort headers.
5115         * alpha-linux-tdep.c: Sort headers.
5116         * alpha-linux-nat.c: Sort headers.
5117         * alpha-bsd-tdep.c: Sort headers.
5118         * alpha-bsd-nat.c: Sort headers.
5119         * aix-thread.c: Sort headers.
5120         * agent.c: Sort headers.
5121         * addrmap.c: Sort headers.
5122         * ada-varobj.c: Sort headers.
5123         * ada-valprint.c: Sort headers.
5124         * ada-typeprint.c: Sort headers.
5125         * ada-tasks.c: Sort headers.
5126         * ada-lang.c: Sort headers.
5127         * aarch64-tdep.c: Sort headers.
5128         * aarch64-ravenscar-thread.c: Sort headers.
5129         * aarch64-newlib-tdep.c: Sort headers.
5130         * aarch64-linux-tdep.c: Sort headers.
5131         * aarch64-linux-nat.c: Sort headers.
5132         * aarch64-fbsd-tdep.c: Sort headers.
5133         * aarch64-fbsd-nat.c: Sort headers.
5134         * aarch32-linux-nat.c: Sort headers.
5135
5136 2019-04-04  Tom Tromey  <tom@tromey.com>
5137
5138         * varobj.c (varobj_create): Update.
5139         * rust-exp.y (struct rust_parser) <update_innermost_block,
5140         lookup_symbol>: New methods.
5141         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5142         Rename.
5143         (rust_parser::rust_lookup_type)
5144         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5145         * printcmd.c (display_command, do_one_display): Update.
5146         * parser-defs.h (struct parser_state) <parser_state>: Add
5147         "tracker" parameter.
5148         (block_tracker): New member.
5149         (class innermost_block_tracker) <innermost_block_tracker>: Add
5150         "types" parameter.
5151         <reset>: Remove method.
5152         (innermost_block): Don't declare.
5153         (null_post_parser): Update.
5154         * parse.c (innermost_block): Remove global.
5155         (write_dollar_variable): Update.
5156         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5157         Remove "tracker_types" parameter.
5158         (parse_expression): Add "tracker" parameter.
5159         (parse_expression_for_completion): Update.
5160         (null_post_parser): Add "tracker" parameter.
5161         * p-exp.y: Update rules.
5162         * m2-exp.y: Update rules.
5163         * language.h (struct language_defn) <la_post_parser>: Add
5164         "tracker" parameter.
5165         * go-exp.y: Update rules.
5166         * f-exp.y: Update rules.
5167         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5168         parameter.
5169         * d-exp.y: Update rules.
5170         * c-exp.y: Update rules.
5171         * breakpoint.c (set_breakpoint_condition): Create an
5172         innermost_block_tracker.
5173         (watch_command_1): Likewise.
5174         * ada-lang.c (resolve): Add "tracker" parameter.
5175         (resolve_subexp): Likewise.
5176         * ada-exp.y (write_var_from_sym): Update.
5177
5178 2019-04-04  Tom Tromey  <tom@tromey.com>
5179
5180         * type-stack.h: New file.
5181         * type-stack.c: New file.
5182         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5183         type-stack.h.
5184         (insert_into_type_stack, insert_type, push_type, push_type_int)
5185         (insert_type_address_space, pop_type, pop_type_int)
5186         (pop_typelist, pop_type_stack, append_type_stack)
5187         (push_type_stack, get_type_stack, push_typelist)
5188         (follow_type_instance_flags, follow_types): Don't declare.
5189         * parse.c (type_stack): Remove global.
5190         (parse_exp_in_context): Update.
5191         (insert_into_type_stack, insert_type, push_type, push_type_int)
5192         (insert_type_address_space, pop_type, pop_type_int)
5193         (pop_typelist, pop_type_stack, append_type_stack)
5194         (push_type_stack, get_type_stack, push_typelist)
5195         (follow_type_instance_flags, follow_types): Remove (moved to
5196         type-stack.c).
5197         * f-exp.y (type_stack): New global.
5198         Update rules.
5199         (push_kind_type, f_parse): Update.
5200         * d-exp.y (type_stack): New global.
5201         Update rules.
5202         (d_parse): Update.
5203         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5204         Update rules.
5205         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5206         (HFILES_NO_SRCDIR): Add type-stack.h.
5207
5208 2019-04-04  Tom Tromey  <tom@tromey.com>
5209
5210         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5211         (rust_parser::convert_ast_to_expression, rust_parse)
5212         (rust_lex_test_completion, rust_lex_tests): Update.
5213         * parser-defs.h (struct expr_completion_state): New.
5214         (struct parser_state) <parser_state>: Add completion parameter.
5215         <mark_struct_expression, mark_completion_tag>: New methods.
5216         <parse_completion, m_completion_state>: New members.
5217         (prefixify_expression, null_post_parser): Update.
5218         (mark_struct_expression, mark_completion_tag): Don't declare.
5219         * parse.c (parse_completion, expout_last_struct)
5220         (expout_tag_completion_type, expout_completion_name): Remove
5221         globals.
5222         (parser_state::mark_struct_expression)
5223         (parser_state::mark_completion_tag): Now methods.
5224         (prefixify_expression): Add last_struct parameter.
5225         (prefixify_subexp): Likewise.
5226         (parse_exp_1): Update.
5227         (parse_exp_in_context): Add cstate parameter.  Update.
5228         (parse_expression_for_completion): Create an
5229         expr_completion_state.
5230         (null_post_parser): Add "completion" parameter.
5231         * p-exp.y: Update rules.
5232         (yylex): Update.
5233         * language.h (struct language_defn) <la_post_parser>: Add
5234         "completing" parameter.
5235         * go-exp.y: Update rules.
5236         (lex_one_token): Update.
5237         * expression.h (parse_completion): Don't declare.
5238         * d-exp.y: Update rules.
5239         (lex_one_token): Update rules.
5240         * c-exp.y: Update rules.
5241         (lex_one_token): Update.
5242         * ada-lang.c (resolve): Add "parse_completion" parameter.
5243         (resolve_subexp): Likewise.
5244         (ada_resolve_function): Likewise.
5245
5246 2019-04-04  Tom Tromey  <tom@tromey.com>
5247
5248         * parser-defs.h (struct parser_state) <start_arglist,
5249         end_arglist>: New methods.
5250         <arglist_len, m_funcall_chain>: New members.
5251         (arglist_len, start_arglist, end_arglist): Don't declare.
5252         * parse.c (arglist_len, funcall_chain): Remove global.
5253         (start_arglist, end_arglist): Remove functions.
5254         (parse_exp_in_context): Update.
5255         * p-exp.y: Update rules.
5256         * m2-exp.y: Update rules.
5257         * go-exp.y: Update rules.
5258         * f-exp.y: Update rules.
5259         * d-exp.y: Update rules.
5260         * c-exp.y: Update rules.
5261
5262 2019-04-04  Tom Tromey  <tom@tromey.com>
5263
5264         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5265         lex_operator, push_back>: New methods.
5266         Update all rules.
5267         (rust_parser::lex_hex, lex_escape): Rename and update.
5268         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5269         (rust_parser::lex_operator): Rename and update.
5270         (rust_parser::lex_number, rustyylex, rustyyerror)
5271         (rust_lex_test_init, rust_lex_test_sequence)
5272         (rust_lex_test_push_back, rust_lex_tests): Update.
5273         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5274         parameter.
5275         <lexptr, prev_lexptr>: New members.
5276         (lexptr, prev_lexptr): Don't declare.
5277         * parse.c (lexptr, prev_lexptr): Remove globals.
5278         (parse_exp_in_context): Update.
5279         * p-exp.y (yylex, yyerror): Update.
5280         * m2-exp.y (parse_number, yylex, yyerror): Update.
5281         * go-exp.y (lex_one_token, yyerror): Update.
5282         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5283         * d-exp.y (lex_one_token, yyerror): Update.
5284         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5285         (lex_one_token, yyerror): Update.
5286         * ada-lex.l (YY_INPUT): Update.
5287         (rewind_to_char): Update.
5288         * ada-exp.y (yyerror): Update.
5289
5290 2019-04-04  Tom Tromey  <tom@tromey.com>
5291
5292         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5293         * parser-defs.h (struct parser_state) <parser_state>: Add new
5294         parameter.
5295         <comma_terminates>: New member.
5296         (comma_terminates): Don't declare global.
5297         * parse.c (comma_terminates): Remove global.
5298         (parse_exp_in_context): Update.
5299         * p-exp.y (yylex): Update.
5300         * m2-exp.y (yylex): Update.
5301         * go-exp.y (lex_one_token): Update.
5302         * f-exp.y (yylex): Update.
5303         * d-exp.y (lex_one_token): Update.
5304         * c-exp.y (lex_one_token): Update.
5305         * ada-lex.l: Update.
5306
5307 2019-04-04  Tom Tromey  <tom@tromey.com>
5308
5309         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5310         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5311         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5312         * parser-defs.h (paren_depth): Don't declare.
5313         * parse.c (paren_depth): Remove global.
5314         (parse_exp_in_context): Update.
5315         * p-exp.y (paren_depth): New global.
5316         (pascal_parse): Initialize it.
5317         * m2-exp.y (paren_depth): New global.
5318         (m2_parse): Initialize it.
5319         * go-exp.y (paren_depth): New global.
5320         (go_parse): Initialize it.
5321         * f-exp.y (paren_depth): New global.
5322         (f_parse): Initialize it.
5323         * d-exp.y (paren_depth): New global.
5324         (d_parse): Initialize it.
5325         * c-exp.y (paren_depth): New global.
5326         (c_parse): Initialize it.
5327         * ada-lex.l (paren_depth): New global.
5328         (lexer_init): Initialize it.
5329
5330 2019-04-04  Tom Tromey  <tom@tromey.com>
5331
5332         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5333         (rust_parser::convert_ast_to_type)
5334         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5335         * parser-defs.h (struct parser_state) <parser_state>: Add
5336         parameters.  Initialize new members.
5337         <expression_context_block, expression_context_pc>: New members.
5338         * parse.c (expression_context_block, expression_context_pc):
5339         Remove globals.
5340         (parse_exp_in_context): Update.
5341         * p-exp.y: Update all rules.
5342         (yylex): Update.
5343         * m2-exp.y: Update all rules.
5344         (yylex): Update.
5345         * go-exp.y (yylex): Update.
5346         * f-exp.y (yylex): Update.
5347         * d-exp.y: Update all rules.
5348         (yylex): Update.
5349         * c-exp.y: Update all rules.
5350         (lex_one_token, classify_name, yylex, c_parse): Update.
5351         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5352
5353 2019-04-04  Tom Tromey  <tom@tromey.com>
5354
5355         * gdbarch.h, gdbarch.c: Rebuild.
5356         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5357         * stap-probe.h:
5358         (struct stap_parse_info): Replace "parser_state" with
5359         "expr_builder".
5360         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5361         (parser_state): New class.
5362         * parse.c (expr_builder): Rename.
5363         (expr_builder::release): Rename.
5364         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5365         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5366         (write_exp_elt_longcst, write_exp_elt_floatcst)
5367         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5368         (write_exp_string_vector, write_exp_bitstring)
5369         (write_exp_msymbol, mark_struct_expression)
5370         (write_dollar_variable)
5371         (insert_type_address_space, increase_expout_size): Replace
5372         "parser_state" with "expr_builder".
5373         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5374         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5375         "parser_state" with "expr_builder".
5376
5377 2019-04-04  Tom Tromey  <tom@tromey.com>
5378
5379         * rust-exp.y: Replace "parse_language" with method call.
5380         * p-exp.y:
5381         (yylex): Replace "parse_language" with method call.
5382         * m2-exp.y:
5383         (yylex): Replace "parse_language" with method call.
5384         * go-exp.y (classify_name): Replace "parse_language" with method
5385         call.
5386         * f-exp.y (yylex): Replace "parse_language" with method call.
5387         * d-exp.y (lex_one_token): Replace "parse_language" with method
5388         call.
5389         * c-exp.y:
5390         (lex_one_token, classify_name, yylex): Replace "parse_language"
5391         with method call.
5392         * ada-exp.y (find_primitive_type, type_char)
5393         (type_system_address): Replace "parse_language" with method call.
5394
5395 2019-04-04  Tom Tromey  <tom@tromey.com>
5396
5397         * rust-exp.y: Replace "parse_gdbarch" with method call.
5398         * parse.c (write_dollar_variable, insert_type_address_space):
5399         Replace "parse_gdbarch" with method call.
5400         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5401         call.
5402         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5403         call.
5404         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5405         "parse_gdbarch" with method call.
5406         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5407         with method call.
5408         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5409         "parse_gdbarch" with method call.
5410         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5411         "parse_gdbarch" with method call.
5412         * c-exp.y (parse_type, parse_number, classify_name): Replace
5413         "parse_gdbarch" with method call.
5414         * ada-lex.l: Replace "parse_gdbarch" with method call.
5415         * ada-exp.y (parse_type, find_primitive_type, type_char)
5416         (type_system_address): Replace "parse_gdbarch" with method call.
5417
5418 2019-04-04  Tom Tromey  <tom@tromey.com>
5419
5420         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5421         * stap-probe.c (stap_parse_argument): Update.
5422         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5423         initial_size parameter.
5424         * rust-exp.y (rust_lex_tests): Update.
5425         * parse.c (parser_state): Update.
5426         (parse_exp_in_context): Update.
5427         * parser-defs.h (struct parser_state) <parser_state>: Remove
5428         "initial_size" parameter.
5429
5430 2019-04-04  Tom Tromey  <tom@tromey.com>
5431
5432         * parser-defs.h (increase_expout_size): Don't declare.
5433         * parse.c (increase_expout_size): Now static.
5434
5435 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5436
5437         * gnu-nat.c (gnu_nat_target::wait): Fix
5438         target_waitstatus_to_string call.
5439
5440 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5441
5442         * eval.c (evaluate_subexp_standard): Handle internal functions
5443         during Fortran function call handling.
5444
5445 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5446
5447         * NEWS: Mention new internal functions.
5448         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5449         (read_base_type): Use dwarf2_init_complex_target_type.
5450         * value.c (creal_internal_fn): New function.
5451         (cimag_internal_fn): New function.
5452         (_initialize_values): Register new internal functions.
5453
5454 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5455
5456         * infrun.c (stop_all_threads): If debug_infrun, always
5457         trace the wait status after wait_one, using
5458         target_waitstatus_to_string and target_pid_to_str.
5459         (handle_inferior_event): Replace various trace of
5460         wait status kind by a single trace.
5461         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5462         wait status kind image by target_waitstatus_to_string.
5463         * target/waitstatus.c (target_waitstatus_to_string): Fix
5464         obsolete comment.
5465
5466 2019-04-01  Tom Tromey  <tromey@adacore.com>
5467
5468         PR symtab/23331:
5469         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5470
5471 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5472             Pedro Alves  <palves@redhat.com>
5473
5474         * top.c (quit_force): Call 'finalize_values'.
5475         * value.c (finalize_values): New function.
5476         * value.h (finalize_values): Declare.
5477
5478 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5479
5480         * NEWS: Announce $_gdb_major and $_gdb_minor.
5481
5482         * top.c (init_gdb_version_vars): New function.
5483         (gdb_init): Call init_gdb_version_vars.
5484
5485 2019-03-29  Tom Tromey  <tromey@adacore.com>
5486
5487         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5488         help text.  Remove dead code.
5489
5490 2019-03-29  Keith Seitz  <keiths@redhat.com>
5491
5492         From Siddhesh Poyarekar:
5493         * f-lang.h (f77_get_upperbound): Return LONGEST.
5494         (f77_get_lowerbound): Likewise.
5495         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5496         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5497         print them.
5498         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5499         plongest to format print it.
5500         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5501         (f77_get_upperbound): Likewise.
5502         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5503         LOWER_BOUND to LONGEST.
5504         (f77_create_arrayprint_offset_tbl): Likewise.
5505
5506 2019-03-29  Keith Seitz  <keiths@redhat.com>
5507
5508         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5509         %s/pulongest for TYPE_LENGTH instead of %d in format
5510         strings.
5511         * ada-typerint.c (ada_print_type): Likewise.
5512         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5513         * compile/compile-c-support.c (generate_register_struct): Likewise.
5514         * gdbtypes.c (recursive_dump_type): Likewise.
5515         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5516         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5517         instead of %d in format strings.
5518         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5519         to std::min to ULONGEST.
5520         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5521         instead of %d in format strings.
5522         * tracepoint.c (info_scope_command): Likewise.
5523         * typeprint.c (print_offset_data::update)
5524         (print_offset_data::finish): Likewise.
5525         * xtensa-tdep.c (xtensa_store_return_value)
5526         (xtensa_push_dummy_call): Likewise.
5527
5528 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5529
5530         * windows-nat.c (display_selector): Fixed format specifications
5531         for 64-bit Cygwin.
5532
5533 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5534
5535         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5536
5537 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5538
5539         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5540         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5541         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5542         (nios2_linux_init_abi): Install it.
5543
5544 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5545
5546         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5547
5548 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5549
5550         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5551
5552 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5553             Tom Tromey  <tromey@adacore.com>
5554
5555         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5556
5557 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5558
5559         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5560         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5561         method to compute the bounds of range types. Also print "[evaluated]"
5562         if the bounds' values come from a dynamic evaluation.
5563
5564 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5565
5566         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5567         whitespace when pretty printing is on.
5568
5569 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5570
5571         * ppc-linux-nat.c: Add include.
5572
5573 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5574
5575         * NEWS: Mention AArch64 Pointer Authentication.
5576
5577 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5578
5579         * arm-linux-nat.c: Add include.
5580
5581 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5582
5583         * source-cache.c (source_cache::get_source_lines): Re-read
5584         fullname after calling open_source_file.
5585
5586 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5587
5588         * NEWS: Mention TLS support for FreeBSD.
5589
5590 2019-03-25  Tom Tromey  <tromey@adacore.com>
5591
5592         * minsyms.c (BUNCH_SIZE): Update comment.
5593         (~minimal_symbol_reader): Remove old comment.
5594         (compact_minimal_symbols): Update comment.
5595         (minimal_symbol_reader::install): Remove old comment.  Update
5596         other comments.
5597
5598 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5599
5600         * s390-linux-nat.c: Add include.
5601
5602 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5603
5604         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5605         Call linux_get_hwcap.
5606         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5607         Likewise.
5608         (aarch64_linux_get_hwcap): Remove function.
5609         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5610         declaration.
5611         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5612         linux_get_hwcap.
5613         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5614         * linux-tdep.c (linux_get_hwcap): Add function.
5615         (linux_get_hwcap2): Likewise.
5616         * linux-tdep.h (linux_get_hwcap): Add declaration.
5617         (linux_get_hwcap2): Likewise.
5618         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5619         (ppc_linux_get_hwcap2): Likewise.
5620         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5621         linux_get_hwcap.
5622         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5623         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5624         (ppc_linux_nat_target::read_description): Likewise.
5625         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5626         * s390-linux-nat.c: Likewise.
5627         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5628
5629 2019-03-24  Tom Tromey  <tom@tromey.com>
5630
5631         * ada-lang.c (standard_lookup): Simplify initialization.
5632         (ada_lookup_symbol_nonlocal): Simplify return.
5633         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5634         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5635         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5636         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5637         initialization.
5638         * solib.c (solib_global_lookup): Simplify.
5639         * symtab.c (null_block_symbol): Remove.
5640         (symbol_cache_lookup): Simplify returns.
5641         (lookup_language_this): Simplify returns.
5642         (lookup_symbol_aux): Simplify return.
5643         (lookup_local_symbol): Simplify returns.
5644         (lookup_global_symbol_from_objfile): Simplify return.
5645         (lookup_symbol_in_objfile_symtabs)
5646         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5647         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5648         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5649         * cp-namespace.c (cp_lookup_bare_symbol)
5650         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5651         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5652         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5653         (cp_lookup_symbol_via_imports): Simplify initialization.
5654         (find_symbol_in_baseclass): Likewise.
5655         * symtab.h (null_block_symbol): Remove.
5656         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5657         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5658         (d_lookup_symbol_module): Likewise.
5659         (find_symbol_in_baseclass): Simplify initialization.
5660
5661 2019-03-24  Tom Tromey  <tom@tromey.com>
5662
5663         * expression.h: Don't include symtab.h.
5664         (struct block): Forward declare.
5665
5666 2019-03-24  Tom Tromey  <tom@tromey.com>
5667
5668         * c-exp.y (typebase): Remove casts.
5669         * gdbtypes.c (lookup_unsigned_typename, )
5670         (lookup_signed_typename): Remove cast.
5671         * eval.c (parse_to_comma_and_eval): Remove cast.
5672         * parse.c (write_dollar_variable): Remove cast.
5673         * block.h (struct block) <superblock>: Now const.
5674         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5675         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5676         (map_block): Make "block" const.
5677         * symfile.h (struct quick_symbol_functions)
5678         <map_matching_symbols>: Constify block argument to "callback".
5679         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5680         const.
5681         (find_pc_sect_compunit_symtab): Make "b" const.
5682         (find_symbol_at_address): Likewise.
5683         (search_symbols): Likewise.
5684         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5685         (dw2_debug_names_lookup_symbol): Likewise.
5686         (dw2_map_matching_symbols): Update.
5687         * p-valprint.c (pascal_val_print): Remove "block".
5688         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5689         (aux_add_nonlocal_symbols): Make "block" const.
5690         (resolve_subexp): Remove cast.
5691         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5692         const.
5693         (iterate_over_file_blocks): Likewise.
5694         * f-exp.y (%union) <bval>: Remove.
5695         * coffread.c (patch_opaque_types): Make "b" const.
5696         * spu-tdep.c (spu_catch_start): Make "block" const.
5697         * c-valprint.c (print_unpacked_pointer): Remove "block".
5698         * symmisc.c (dump_symtab_1): Make "b" const.
5699         (block_depth): Make "block" const.
5700         * d-exp.y (%union) <bval>: Remove.
5701         * cp-support.h (cp_lookup_rtti_type): Update.
5702         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5703         * psymtab.c (psym_lookup_symbol): Make "block" const.
5704         (maintenance_check_psymtabs): Make "b" const.
5705         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5706         (enumerate_locals, enumerate_args): Update.
5707         * python/py-symtab.c (stpy_global_block): Make "block" const.
5708         (stpy_static_block): Likewise.
5709         * inline-frame.c (block_starting_point_at): Make "new_block"
5710         const.
5711         * block.c (find_block_in_blockvector): Make return type const.
5712         (blockvector_for_pc_sect): Make "b" const.
5713         (find_block_in_blockvector): Make "b" const.
5714
5715 2019-03-23  Tom Tromey  <tom@tromey.com>
5716
5717         * varobj.c (varobj_create): Update.
5718         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5719         * printcmd.c (display_command, do_one_display): Don't reset
5720         innermost_block.
5721         * parser-defs.h (enum innermost_block_tracker_type): Move to
5722         expression.h.
5723         (innermost_block): Update comment.
5724         * parse.c (parse_exp_1): Add tracker_types parameter.
5725         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5726         tracker_types parameter.  Reset innermost_block.
5727         (parse_exp_in_context): Remove.
5728         (parse_expression_for_completion): Update.
5729         * objfiles.c (~objfile): Don't reset expression_context_block or
5730         innermost_block.
5731         * expression.h (enum innermost_block_tracker_type): Move from
5732         parser-defs.h.
5733         (parse_exp_1): Add tracker_types parameter.
5734         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5735         reset innermost_block.
5736
5737 2019-03-23  Tom Tromey  <tom@tromey.com>
5738
5739         * objfiles.h: Include bcache.h.
5740
5741 2019-03-23  Tom Tromey  <tom@tromey.com>
5742
5743         * linespec.c (get_current_search_block): Use
5744         scoped_restore_current_language.
5745         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5746
5747 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5748             Jiong Wang  <jiong.wang@arm.com>
5749
5750         * aarch64-linux-tdep.c
5751         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5752         section.
5753         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5754
5755 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5756             Jiong Wang  <jiong.wang@arm.com>
5757
5758         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5759         instructions.
5760         (aarch64_analyze_prologue_test): Add PACIASP test.
5761         (aarch64_prologue_prev_register): Unmask PC value.
5762
5763 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5764             Jiong Wang  <jiong.wang@arm.com>
5765
5766         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5767         (aarch64_dwarf2_prev_register): Unmask PC value.
5768         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5769         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5770         DW_CFA_AARCH64_negate_ra_state.
5771         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5772
5773 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5774             Jiong Wang  <jiong.wang@arm.com>
5775
5776         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5777         registers.
5778         (aarch64_pseudo_register_name): Likewise.
5779         (aarch64_pseudo_register_type): Likewise.
5780         (aarch64_pseudo_register_reggroup_p): Likewise.
5781         (aarch64_gdbarch_init): Add pauth registers.
5782         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5783         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5784         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5785         (struct gdbarch_tdep): Add regnum for ra_state.
5786
5787 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5788             Jiong Wang  <jiong.wang@arm.com>
5789
5790         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5791
5792 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5793             Jiong Wang  <jiong.wang@arm.com>
5794
5795         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5796         function.
5797         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5798         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5799         (aarch64_gdbarch_init): Add puth registers.
5800         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5801         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5802         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5803
5804 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5805             Jiong Wang  <jiong.wang@arm.com>
5806
5807         * aarch64-linux-nat.c
5808         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5809         * aarch64-linux-tdep.c
5810         (aarch64_linux_core_read_description): Likewise.
5811         (aarch64_linux_get_hwcap): New function.
5812         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5813         (aarch64_linux_get_hwcap): New declaration.
5814
5815 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5816             Jiong Wang  <jiong.wang@arm.com>
5817
5818         * aarch64-linux-nat.c
5819         (aarch64_linux_nat_target::read_description): Add pauth param.
5820         * aarch64-linux-tdep.c
5821         (aarch64_linux_core_read_description): Likewise.
5822         * aarch64-tdep.c (struct target_desc): Add in pauth.
5823         (aarch64_read_description): Add pauth param.
5824         (aarch64_gdbarch_init): Likewise.
5825         * aarch64-tdep.h (aarch64_read_description): Likewise.
5826         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5827         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5828         * features/Makefile: Add new files.
5829         * features/aarch64-pauth.c: New file.
5830         * features/aarch64-pauth.xml: New file.
5831
5832 2019-03-20  Tom Tromey  <tromey@adacore.com>
5833
5834         * infrun.c (handle_inferior_event): Rename from
5835         handle_inferior_event_1.  Create a scoped_value_mark.
5836         (handle_inferior_event): Remove.
5837
5838 2019-03-19  Tom Tromey  <tromey@adacore.com>
5839
5840         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5841         * infrun.h (print_stop_event): Add "displays" parameter.
5842         * infrun.c (print_stop_event): Add "displays" parameter.
5843
5844 2019-03-19  Pedro Alves  <palves@redhat.com>
5845
5846         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5847         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5848         to -1.  Fix TABs vs spaces.
5849         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5850         * tui/tui-out.h (tui_ui_out) Add intro comments.
5851         <m_line, m_start_of_line>: In-class initialize, and add describing
5852         comment.
5853
5854 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5855
5856         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5857         variable names.
5858         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5859
5860 2019-03-18  Pedro Alves  <palves@redhat.com>
5861             Eli Zaretskii <eliz@gnu.org>
5862
5863         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5864         m_line and m_start_of_line.
5865
5866 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5867
5868         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5869         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5870         it returns a newline.  This fixes a regression in TU mode, whereby
5871         the next line is output on the same screen line as the user input.
5872
5873 2019-03-18  Tom Tromey  <tromey@adacore.com>
5874
5875         * minsyms.c (minimal_symbol_reader::install): Remove call to
5876         obstack_blank.
5877
5878 2019-03-18  Pedro Alves  <palves@redhat.com>
5879
5880         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5881         New globals.
5882         (apply_style): New, factored out from ...
5883         (apply_ansi_escape): ... this.  Handle reverse video mode.
5884         (tui_set_reverse_mode): New function.
5885         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5886         * tui/tui-winsource.c (tui_show_source_line): Use
5887         tui_set_reverse_mode instead of setting A_STANDOUT.
5888         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5889         New setter methods.
5890
5891 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5892
5893         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5894         Handle tabs.
5895
5896 2019-03-18  Tom Tromey  <tromey@adacore.com>
5897
5898         * ada-lang.c (empty_array): Add "high" parameter.
5899         (ada_evaluate_subexp): Update.
5900
5901 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5902
5903         * unittests/string_view-selftests.c: Define
5904         _initialize_string_view_selftests unconditionally.
5905
5906 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5907
5908         PR gdb/24350
5909         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5910
5911 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5912
5913         PR gdb/24351
5914         * windows-nat.c (display_selector): Fix format specifiers.
5915
5916 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5917
5918         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5919         tui_refill_source_window instead of tui_refresh_win, to update the
5920         current execution line.  This fixes redisplay of the current line
5921         when stepping through the code with "next" or "step".
5922
5923 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5924
5925         * source-cache.c (source_cache::get_source_lines): Call
5926         find_source_lines to initialize s->nlines.  This fixes vertical
5927         scrolling of TUI source window when the DOWN arrow is pressed.
5928
5929 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5930
5931         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5932         linux-thread-db.c (_initialize_thread_db): Likewise.
5933
5934 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5935
5936         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5937         wclrtoeol in tui_show_source_line".  This reverts changes made in
5938         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5939
5940 2019-03-15  Tom Tromey  <tom@tromey.com>
5941
5942         * symtab.h (struct minimal_symbol): Derive from
5943         general_symbol_info.
5944         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5945         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5946         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5947         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5948         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5949         (MSYMBOL_SEARCH_NAME): Update.
5950         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5951         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5952         * minsyms.c (minimal_symbol_reader::record_full): Update.
5953
5954 2019-03-15  Tom Tromey  <tom@tromey.com>
5955
5956         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5957
5958 2019-03-15  Tom Tromey  <tom@tromey.com>
5959
5960         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5961         unique_xmalloc_ptr.
5962         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5963         Update.
5964         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5965         (build_minimal_symbol_hash_tables)
5966         (minimal_symbol_reader::install): Update.
5967
5968 2019-03-15  Tom Tromey  <tom@tromey.com>
5969
5970         * symtab.c (create_demangled_names_hash): Update.
5971         (symbol_set_names): Update.
5972         * objfiles.h (struct objfile_per_bfd_storage)
5973         <demangled_names_hash>: Now an htab_up.
5974         * objfiles.c (objfile_per_bfd_storage): Simplify.
5975
5976 2019-03-15  Tom Tromey  <tom@tromey.com>
5977
5978         * objfiles.h (struct objfile_per_bfd_storage): Declare
5979         destructor.
5980         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5981         New.
5982         (get_objfile_bfd_data): Use new.  Don't initialize
5983         language_of_main.
5984         (free_objfile_per_bfd_storage): Remove.
5985         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5986
5987 2019-03-15  Tom Tromey  <tom@tromey.com>
5988
5989         * symfile.c (reread_symbols): Update.
5990         * objfiles.c (objfile::objfile): Update.
5991         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5992         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5993         comment.
5994         (minimal_symbol_reader::install): Update.
5995         (terminate_minimal_symbol_table): Remove.
5996         * jit.c (jit_object_close_impl): Update.
5997
5998 2019-03-15  Tom Tromey  <tom@tromey.com>
5999
6000         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6001         initializations.
6002
6003 2019-03-15  Tom Tromey  <tom@tromey.com>
6004
6005         * objfiles.h (struct objfile_per_bfd_storage)
6006         <demangled_hash_languages>: Now a bitset.
6007         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6008         (lookup_minimal_symbol): Update.
6009
6010 2019-03-15  Tom Tromey  <tom@tromey.com>
6011
6012         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6013         Don't return the symbol.
6014         * coffread.c (record_minimal_symbol): Use record_full.
6015
6016 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6017
6018         The MS-Windows port of ncurses fails to switch to a color pair if
6019         one or both of the colors are the implicit default colors.  This
6020         change records the default colors when TUI is initialized, and
6021         then specifies them explicitly when a color pair uses the default
6022         colors.  This allows color styling in TUI mode on MS-Windows.
6023
6024         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6025         ncurses_norm_attr.
6026         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6027         colors in ncurses_norm_attr.
6028         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6029         "none", replace it with the default color recorded in
6030         ncurses_norm_attr.
6031
6032 2019-03-14  Tom Tromey  <tromey@adacore.com>
6033
6034         * source-cache.h (class source_cache) <get_source_lines>: Return
6035         std::string.
6036         * source-cache.c (source_cache::extract_lines): Handle case where
6037         first_pos==npos.  Return std::string.
6038         (source_cache::get_source_lines): Update.
6039
6040 2019-03-14  Tom Tromey  <tromey@adacore.com>
6041
6042         * NEWS: Add item for "style sources" commands.
6043         * source-cache.c (source_cache::get_source_lines): Check
6044         source_styling.
6045         * cli/cli-style.c (source_styling): New global.
6046         (_initialize_cli_style): Add "style sources" commands.
6047         (show_style_sources): New function.
6048         * cli/cli-style.h (source_styling): Declare.
6049
6050 2019-03-14  Pedro Alves  <palves@redhat.com>
6051             Tom Tromey  <tromey@adacore.com>
6052
6053         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6054         * tui/tui-winsource.c (tui_refill_source_window): New function,
6055         from...
6056         (tui_horizontal_source_scroll): ... here.  Move some logic.
6057         * cli/cli-style.c (set_style_enabled): Notify new observable.
6058         * tui/tui-hooks.c (tui_redisplay_source): New function.
6059         (tui_attach_detach_observers): Attach or detach
6060         tui_redisplay_source.
6061         * observable.h (source_styling_changed): New observable.
6062         * observable.c: Define source_styling_changed observable.
6063
6064 2019-03-13  Tom Tromey  <tromey@adacore.com>
6065
6066         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6067         (i386_gnu_nat_target::store_registers): Update.
6068         * target-debug.h (target_debug_print_std_string): New macro.
6069         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6070         * windows-tdep.c (display_one_tib): Update.
6071         * tui/tui-stack.c (tui_make_status_line): Update.
6072         * top.c (print_inferior_quit_action): Update.
6073         * thread.c (thr_try_catch_cmd): Update.
6074         (add_thread_with_info): Update.
6075         (thread_target_id_str): Update.
6076         (thr_try_catch_cmd): Update.
6077         (thread_command): Update.
6078         (thread_find_command): Update.
6079         * record-btrace.c (record_btrace_target::info_record)
6080         (record_btrace_resume_thread, record_btrace_target::resume)
6081         (record_btrace_cancel_resume, record_btrace_step_thread)
6082         (record_btrace_target::wait, record_btrace_target::wait)
6083         (record_btrace_target::wait, record_btrace_target::stop): Update.
6084         * progspace.c (print_program_space): Update.
6085         * process-stratum-target.c
6086         (process_stratum_target::thread_address_space): Update.
6087         * linux-fork.c (linux_fork_mourn_inferior)
6088         (detach_checkpoint_command, info_checkpoints_command)
6089         (linux_fork_context): Update.
6090         (linux_fork_detach): Update.
6091         (class scoped_switch_fork_info): Update.
6092         (delete_checkpoint_command): Update.
6093         * infrun.c (follow_fork_inferior): Update.
6094         (follow_fork_inferior): Update.
6095         (proceed_after_vfork_done): Update.
6096         (handle_vfork_child_exec_or_exit): Update.
6097         (follow_exec): Update.
6098         (displaced_step_prepare_throw): Update.
6099         (displaced_step_restore): Update.
6100         (start_step_over): Update.
6101         (resume_1): Update.
6102         (clear_proceed_status_thread): Update.
6103         (proceed): Update.
6104         (print_target_wait_results): Update.
6105         (do_target_wait): Update.
6106         (context_switch): Update.
6107         (stop_all_threads): Update.
6108         (restart_threads): Update.
6109         (finish_step_over): Update.
6110         (handle_signal_stop): Update.
6111         (switch_back_to_stepped_thread): Update.
6112         (keep_going_pass_signal): Update.
6113         (print_exited_reason): Update.
6114         (normal_stop): Update.
6115         * inferior.c (inferior_pid_to_str): Change return type.
6116         (print_selected_inferior): Update.
6117         (add_inferior): Update.
6118         (detach_inferior): Update.
6119         * dummy-frame.c (fprint_dummy_frames): Update.
6120         * dcache.c (dcache_info_1): Update.
6121         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6122         (btrace_fetch, btrace_clear): Update.
6123         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6124         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6125         type.
6126         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6127         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6128         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6129         * gdbarch.c, gdbarch.h: Rebuild.
6130         * gdbarch.sh (core_pid_to_str): Change return type.
6131         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6132         return type.
6133         (windows_nat_target::pid_to_str): Change return type.
6134         (windows_delete_thread): Update.
6135         (windows_nat_target::attach): Update.
6136         (windows_nat_target::files_info): Update.
6137         * target-delegates.c: Rebuild.
6138         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6139         return type.
6140         (sol_thread_target::pid_to_str): Change return type.
6141         * remote.c (class remote_target) <pid_to_str>: Change return
6142         type.
6143         (remote_target::pid_to_str): Change return type.
6144         (extended_remote_target::attach, remote_target::remote_stop_ns)
6145         (remote_target::remote_notif_remove_queued_reply)
6146         (remote_target::push_stop_reply, remote_target::disable_btrace):
6147         Update.
6148         (extended_remote_target::attach): Update.
6149         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6150         type.
6151         (gdbsim_target::pid_to_str): Change return type.
6152         * ravenscar-thread.c (struct ravenscar_thread_target)
6153         <pid_to_str>: Change return type.
6154         (ravenscar_thread_target::pid_to_str): Change return type.
6155         * procfs.c (class procfs_target) <pid_to_str>: Change return
6156         type.
6157         (procfs_target::pid_to_str): Change return type.
6158         (procfs_target::attach): Update.
6159         (procfs_target::detach): Update.
6160         (procfs_target::fetch_registers): Update.
6161         (procfs_target::store_registers): Update.
6162         (procfs_target::wait): Update.
6163         (procfs_target::files_info): Update.
6164         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6165         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6166         return type.
6167         (nto_procfs_target::pid_to_str): Change return type.
6168         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6169         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6170         return type.
6171         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6172         (exit_lwp): Update.
6173         (attach_proc_task_lwp_callback, get_detach_signal)
6174         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6175         (linux_nat_target::resume, wait_lwp, stop_callback)
6176         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6177         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6178         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6179         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6180         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6181         type.
6182         (inf_ptrace_target::attach): Update.
6183         (inf_ptrace_target::files_info): Update.
6184         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6185         type.
6186         (go32_nat_target::pid_to_str): Change return type.
6187         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6188         (gnu_nat_target::wait): Update.
6189         (gnu_nat_target::wait): Update.
6190         (gnu_nat_target::resume): Update.
6191         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6192         (fbsd_nat_target::wait): Update.
6193         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6194         type.
6195         (darwin_nat_target::attach): Update.
6196         * corelow.c (class core_target) <pid_to_str>: Change return type.
6197         (core_target::pid_to_str): Change return type.
6198         * target.c (normal_pid_to_str): Change return type.
6199         (default_pid_to_str): Likewise.
6200         (target_pid_to_str): Change return type.
6201         (target_translate_tls_address): Update.
6202         (target_announce_detach): Update.
6203         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6204         return type.
6205         (bsd_uthread_target::pid_to_str): Change return type.
6206         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6207         type.
6208         (bsd_kvm_target::pid_to_str): Change return type.
6209         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6210         return type.
6211         (aix_thread_target::pid_to_str): Change return type.
6212         * target.h (struct target_ops) <pid_to_str>: Change return type.
6213         (target_pid_to_str, normal_pid_to_str): Likewise.
6214         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6215         type.
6216         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6217         type.
6218         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6219         return type.
6220         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6221         type.
6222         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6223         type.
6224         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6225         return type.
6226
6227 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6228
6229         * NEWS: Mention that the new default MI version is 3.  Mention
6230         changes to the output of commands and events that deal with
6231         multi-location breakpoints.
6232         * breakpoint.c: Include "mi/mi-out.h".
6233         (print_one_breakpoint): Change output syntax if using MI version
6234         >= 3.
6235         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6236         New.
6237         (mi_multi_location_breakpoint_output_fixed): New.
6238         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6239         (mi_cmd_fix_multi_location_breakpoint_output): New.
6240         (mi_multi_location_breakpoint_output_fixed): New.
6241         * mi/mi-cmds.c (mi_cmds): Register command
6242         -fix-multi-location-breakpoint-output.
6243         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6244         interpreter "mi".
6245
6246 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6247
6248         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6249         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6250         instantiate mi_ui_out based on interpreter name.
6251         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6252         * mi/mi-main.c (mi_load_progress): Likewise.
6253
6254 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6255
6256         * NEWS: Combine separate "New targets" sections for 8.3.
6257
6258 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6259
6260         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6261         (ppcfbsd_init_abi): Install gdbarch
6262         "fetch_tls_load_module_address" and "get_thread_local_address"
6263         methods.
6264
6265 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6266
6267         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6268         (riscv_fbsd_init_abi): Install gdbarch
6269         "fetch_tls_load_module_address" and "get_thread_local_address"
6270         methods.
6271
6272 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6273
6274         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6275         (i386fbsd_init_abi): Install gdbarch
6276         "fetch_tls_load_module_address" and "get_thread_local_address"
6277         methods.
6278
6279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6280
6281         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6282         (amd64fbsd_init_abi): Install gdbarch
6283         "fetch_tls_load_module_address" and "get_thread_local_address"
6284         methods.
6285
6286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6287
6288         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6289         (struct fbsd_pspace_data): New type.
6290         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6291         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6292         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6293         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6294         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6295
6296 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6297
6298         * gdbtypes.c (lookup_struct_elt): New function.
6299         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6300         * gdbtypes.h (struct struct_elt): New type.
6301         (lookup_struct_elt): New prototype.
6302
6303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6304
6305         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6306         remove disabled code block.
6307
6308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6309
6310         * gdbarch.sh (get_thread_local_address): New method.
6311         * gdbarch.h, gdbarch.c: Regenerate.
6312         * target.c (target_translate_tls_address): Use
6313         gdbarch_get_thread_local_address if present instead of
6314         target::get_thread_local_address.
6315
6316 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6317
6318         * target.h (target::get_thread_local_address): Update comment.
6319
6320 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6321
6322         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6323         objfile->separate_debug_objfile_backlink if not NULL.
6324
6325 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6326
6327         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6328         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6329         (amd64bsd_store_inferior_registers): Likewise.
6330         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6331         Enable segment base registers.
6332         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6333         PT_GETFSBASE and PT_GETGSBASE.
6334         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6335         PT_SETGSBASE.
6336         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6337         segment base registers.
6338         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6339
6340 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6341
6342         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6343         Update calls to i386_target_description to add 'segments'
6344         parameter.
6345         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6346         add segment base registers.
6347         * arch/i386.c (i386_create_target_description): Add 'segments'
6348         parameter to enable segment base registers.
6349         * arch/i386.h (i386_create_target_description): Likewise.
6350         * features/i386/32bit-segments.xml: New file.
6351         * features/i386/32bit-segments.c: Generate.
6352         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6353         call to i386_target_description to add 'segments' parameter.
6354         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6355         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6356         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6357         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6358         if feature is present.
6359         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6360         Add 'segments' parameter to call to i386_target_description.
6361         (i386_target_description): Add 'segments' parameter to enable
6362         segment base registers.
6363         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6364         to call to i386_target_description.
6365         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6366         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6367         Define I386_NUM_REGS.
6368         (i386_target_description): Add 'segments' parameter to enable
6369         segment base registers.
6370
6371 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6372
6373         PR/24325
6374         * source-cache.c: #undef open and close, to avoid unresolved
6375         externals during linking.
6376
6377 2019-03-12  Tom Tromey  <tromey@adacore.com>
6378
6379         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6380         const.  Add initializers.
6381         (_initialize_remote): Don't initialize ptid globals.
6382
6383 2019-03-12  Pedro Alves  <palves@redhat.com>
6384
6385         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6386
6387 2019-03-12  Pedro Alves  <palves@redhat.com>
6388
6389         * cp-name-parser.y (main): Remove unused 'len' variable.
6390
6391 2019-03-12  Tom Tromey  <tromey@adacore.com>
6392
6393         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6394         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6395
6396 2019-03-12  Tom Tromey  <tromey@adacore.com>
6397
6398         * linux-nat.c (iterate_over_lwps): Update.
6399         (stop_callback): Remove parameter.
6400         (stop_wait_callback, detach_callback, resume_set_callback)
6401         (select_singlestep_lwp_callback, set_ignore_sigint)
6402         (status_callback, resumed_callback, resume_clear_callback)
6403         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6404         data parameter.
6405         (linux_nat_target::detach, linux_nat_target::resume)
6406         (linux_stop_and_wait_all_lwps, select_event_lwp)
6407         (linux_nat_filter_event, linux_nat_wait_1)
6408         (linux_nat_target::kill, linux_nat_target::stop)
6409         (linux_nat_target::stop): Update.
6410         (linux_nat_resume_callback): Change type.
6411         (resume_stopped_resumed_lwps, count_events_callback)
6412         (select_event_lwp_callback): Likewise.
6413         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6414         * arm-linux-nat.c (struct update_registers_data): Remove.
6415         (update_registers_callback): Change type.
6416         (arm_linux_insert_hw_breakpoint1): Update.
6417         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6418         parameter.
6419         (x86_linux_dr_set_addr): Update.
6420         (x86_linux_dr_set_control): Update.
6421         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6422         (iterate_over_lwps): Use gdb::function_view.
6423         * nat/aarch64-linux-hw-point.c (struct
6424         aarch64_dr_update_callback_param): Remove.
6425         (debug_reg_change_callback): Change type.
6426         (aarch64_notify_debug_reg_change): Update.
6427         * s390-linux-nat.c (s390_refresh_per_info): Update.
6428
6429 2019-03-11  Tom Tromey  <tromey@adacore.com>
6430
6431         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6432         redundant assignment to "this_cu".
6433
6434 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6435
6436         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6437
6438 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6439
6440         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6441         from...
6442         (rank_one_type): ... this.
6443
6444 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6445
6446         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6447         from...
6448         (rank_one_type): ... this.
6449
6450 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6451
6452         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6453         from...
6454         (rank_one_type): ... this.
6455
6456 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6457
6458         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6459         from...
6460         (rank_one_type): ... this.
6461
6462 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6463
6464         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6465         from...
6466         (rank_one_type): ... this.
6467
6468 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6469
6470         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6471         from...
6472         (rank_one_type): ... this.
6473
6474 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6475
6476         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6477         from...
6478         (rank_one_type): ... this.
6479
6480 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6481
6482         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6483         from...
6484         (rank_one_type): ... this.
6485
6486 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6487
6488         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6489         from...
6490         (rank_one_type): ... this.
6491
6492 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6493
6494         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6495         from...
6496         (rank_one_type): ... this.
6497
6498 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6499
6500         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6501         from...
6502         (rank_one_type): ... this.
6503
6504 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6505
6506         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6507         from...
6508         (rank_one_type): ... this.
6509
6510 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6511
6512         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6513         inferior-events' shows the example events.
6514
6515 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6516
6517         Support styling on native MS-Windows console
6518
6519         PR/24315
6520         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6521         on MS-Windows if $TERM is not defined.
6522
6523         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6524
6525         * posix-hdep.c (gdb_console_fputs):
6526         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6527         functions.
6528         * ui-file.h (gdb_console_fputs): Add prototype.
6529
6530         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6531         back to fputs only if the former returns zero.
6532
6533 2019-03-07  Tom Tromey  <tom@tromey.com>
6534
6535         * symmisc.c (print_symbol_bcache_statistics): Update.
6536         (print_objfile_statistics): Update.
6537         * symfile.c (allocate_symtab): Update.
6538         * stabsread.c: Don't include bcache.h.
6539         * psymtab.h (struct psymbol_bcache): Don't declare.
6540         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6541         (psymbol_bcache_init, psymbol_bcache_free)
6542         (psymbol_bcache_get_bcache): Don't declare.
6543         * psymtab.c (struct psymbol_bcache): Remove.
6544         (psymtab_storage::psymtab_storage): Update.
6545         (psymtab_storage::~psymtab_storage): Update.
6546         (psymbol_bcache_init, psymbol_bcache_free)
6547         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6548         (add_psymbol_to_bcache): Update.
6549         (allocate_psymtab): Update.
6550         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6551         macro_cache>: No longer pointers.
6552         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6553         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6554         * macrotab.c (macro_bcache): Update.
6555         * macroexp.c: Don't include bcache.h.
6556         * gdbtypes.c (check_types_worklist): Update.
6557         (types_deeply_equal): Remove TRY/CATCH.  Update.
6558         * elfread.c (elf_symtab_read): Update.
6559         * dwarf2read.c: Don't include bcache.h.
6560         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6561         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6562         (print_bcache_statistics, bcache_memory_used): Don't declare.
6563         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6564         methods.  Rename all data members.
6565         * bcache.c (struct bcache): Move to bcache.h.
6566         (bcache::expand_hash_table): Rename from expand_hash_table.
6567         (bcache): Remove.
6568         (bcache::insert): Rename from bcache_full.
6569         (bcache::compare): Rename from bcache_compare.
6570         (bcache_xmalloc): Remove.
6571         (bcache::~bcache): Rename from bcache_xfree.
6572         (bcache::print_statistics): Rename from print_bcache_statistics.
6573         (bcache::memory_used): Rename from bcache_memory_used.
6574
6575 2019-03-07  Pedro Alves  <palves@redhat.com>
6576
6577         * infrun.c (normal_stop): Also check for
6578         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6579
6580 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6581
6582         * f-lang.c (value_from_host_double): Moved to...
6583         * value.c (value_from_host_double): ...here.
6584         * value.h (value_from_host_double): Declare.
6585         * guile/scm-math.c (vlscm_convert_typed_number): Use
6586         value_from_host_double.
6587         (vlscm_convert_number): Likewise.
6588         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6589         * python/py-value.c (convert_value_from_python): Likewise.
6590
6591 2019-03-06  Tom Tromey  <tom@tromey.com>
6592
6593         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6594
6595 2019-03-06  Tom Tromey  <tom@tromey.com>
6596
6597         * utils.h (free_current_contents): Don't declare.
6598         * utils.c (free_current_contents): Remove.
6599
6600 2019-03-06  Tom Tromey  <tom@tromey.com>
6601
6602         * top.c (quit_force): Update.
6603         * main.c (captured_command_loop): Update.
6604         * common/new-op.c (operator new): Update.
6605         * common/common-exceptions.c (struct catcher)
6606         <save_cleanup_chain>: Remove member.
6607         (exceptions_state_mc_init): Update.
6608         (exception_try_scope_entry): Return nullptr.
6609         (exception_try_scope_exit, exception_rethrow)
6610         (throw_exception_sjlj, throw_exception_cxx): Update.
6611         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6612         (all_cleanups, do_cleanups, discard_cleanups)
6613         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6614         (restore_cleanups, restore_final_cleanups): Don't declare.
6615         (do_final_cleanups): Remove parameter.
6616         * common/cleanups.c (cleanup_chain, make_cleanup)
6617         (make_cleanup_dtor, all_cleanups, do_cleanups)
6618         (discard_my_cleanups, discard_cleanups)
6619         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6620         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6621         (null_cleanup): Remove.
6622         (do_final_cleanups): Remove parameter.
6623
6624 2019-03-06  Tom Tromey  <tom@tromey.com>
6625
6626         * remote.c (remote_target::remote_parse_stop_reply): Use
6627         unique_xmalloc_ptr.
6628
6629 2019-03-06  Tom Tromey  <tom@tromey.com>
6630
6631         * stabsread.c (struct stabs_field_info): Rename from field_info.
6632         <list, fnlist>: Add initializers.
6633         <obstack>: New member.
6634         (read_member_functions, read_struct_fields, read_baseclasses):
6635         Allocate on obstack.  Don't use cleanups.
6636         (read_one_struct_field, read_member_functions, read_struct_fields)
6637         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6638         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6639         (read_struct_type): Update.
6640
6641 2019-03-06  Tom Tromey  <tom@tromey.com>
6642
6643         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6644         * common/filestuff.h (make_cleanup_close): Don't declare.
6645         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6646         Remove.
6647
6648 2019-03-06  Tom Tromey  <tom@tromey.com>
6649
6650         * solib-aix.c: Use make_scope_exit.
6651
6652 2019-03-06  Tom Tromey  <tom@tromey.com>
6653
6654         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6655         Use make_scope_exit.
6656
6657 2019-03-06  Tom Tromey  <tom@tromey.com>
6658
6659         * solib-svr4.c (disable_probes_interface): Remove parameter.
6660         (svr4_handle_solib_event): Use make_scope_exit.
6661
6662 2019-03-06  Tom Tromey  <tom@tromey.com>
6663
6664         * remote.c (struct stop_reply_deleter): Remove.
6665         (stop_reply_up): Update.
6666         (struct stop_reply): Derive from notif_event.  Don't typedef.
6667         <regcache>: Now a std::vector.
6668         (stop_reply_xfree): Remove.
6669         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6670         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6671         (remote_target::discard_pending_stop_replies): Use delete.
6672         (remote_target::remote_parse_stop_reply): Update.
6673         (remote_target::process_stop_reply): Update.
6674         * remote-notif.h (struct notif_event): Add virtual destructor.
6675         Remove "dtr" member.
6676         (struct notif_client) <alloc_event>: Return a unique_ptr.
6677         (notif_event_xfree): Don't declare.
6678         (notif_event_up): New typedef.
6679         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6680         (notif_event_xfree, do_notif_event_xfree): Remove.
6681         (remote_notif_state_xfree): Update.
6682
6683 2019-03-06  Tom Tromey  <tom@tromey.com>
6684
6685         * infrun.c (displaced_step_clear_cleanup): Now a
6686         forward_scope_exit type.
6687         (displaced_step_prepare_throw): Update.
6688         (displaced_step_fixup): Update.
6689
6690 2019-03-06  Tom Tromey  <tom@tromey.com>
6691
6692         * inferior.h (class inferior): Update comment.
6693         * gdbthread.h (class thread_info): Update comment.
6694
6695 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6696             Tom Tromey  <tom@tromey.com>
6697
6698         * stabsread.h (struct stab_section_list): Remove.
6699         (coffstab_build_psymtabs): Update.
6700         * dbxread.c (symbuf_sections): Now a std::vector.
6701         (sect_idx): New global.
6702         (fill_symbuf): Update.
6703         (coffstab_build_psymtabs): Change type of stabsects parameter.
6704         Update.
6705         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6706         std::vector.
6707         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6708         (coff_locate_sections): Update.
6709         (coff_symfile_read): Remove cleanups.  Update.
6710         (init_stringtab): Add storage parameter.
6711         (free_stringtab, free_stringtab_cleanup): Remove.
6712         (init_lineno): Add storage parameter.
6713         (free_linetab, free_linetab_cleanup): Remove.
6714
6715 2019-03-06  Pedro Alves  <palves@redhat.com>
6716
6717         * linux-fork.c (fork_info::clobber_regs): Delete.
6718         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6719         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6720         comment.  Adjust.
6721         (scoped_switch_fork_info::scoped_switch_fork_info)
6722         (checkpoint_command, linux_fork_context): Adjust
6723         fork_save_infrun_state calls.
6724
6725 2019-03-06  Pedro Alves  <palves@redhat.com>
6726
6727         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6728         (inf_has_multiple_threads): Return 'bool' and rewrite using
6729         inferior_info::threads().
6730
6731 2019-03-06  Pedro Alves  <palves@redhat.com>
6732
6733         * linux-fork.c: Include <list>.
6734         (fork_list): Now a std::list instance.
6735         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6736         (forks_exist_p, find_last_fork): Adjust.
6737         (new_fork): Delete.
6738         (one_fork_p): New.
6739         (add_fork): Adjust.
6740         (free_fork): Delete, folded into fork_info::~fork_info().
6741         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6742         Adjust.
6743         (init_fork_list): Delete.
6744         (linux_fork_killall, linux_fork_mourn_inferior)
6745         (linux_fork_detach, info_checkpoints_command): Adjust.
6746         (_initialize_linux_fork): No longer call init_fork_list.
6747
6748 2019-03-06  Pedro Alves  <palves@redhat.com>
6749
6750         * linux-fork.c (new_fork): New, split out of ...
6751         (add_fork): ... this.  Return void.  Move "first fork" special
6752         case from here, to ...
6753         (checkpoint_command): ... here.
6754         * linux-linux.h (add_fork): Return void.
6755
6756 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6757
6758         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6759
6760 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6761             Chris January  <chris.january@arm.com>
6762             David Lecomber  <david.lecomber@arm.com>
6763
6764         * f-exp.y: New token, UNOP_INTRINSIC.
6765         (exp): New pattern using UNOP_INTRINSIC token.
6766         (f77_keywords): Add 'abs' keyword.
6767         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6768         (value_from_host_double): New function.
6769         (evaluate_subexp_f): Support UNOP_ABS.
6770
6771 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6772
6773         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6774         types.
6775
6776 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6777
6778         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6779         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6780         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6781
6782 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6783
6784         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6785
6786 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6787             Chris January  <chris.january@arm.com>
6788
6789         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6790         * f-exp.y: Define 'KIND' token.
6791         (exp): New pattern for KIND expressions.
6792         (ptype): Handle types with a kind extension.
6793         (direct_abs_decl): Extend to spot kind extensions.
6794         (f77_keywords): Add 'kind' to the list.
6795         (push_kind_type): New function.
6796         (convert_to_kind_type): New function.
6797         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6798         * parse.c (operator_length_standard): Likewise.
6799         * parser-defs.h (enum type_pieces): Add tp_kind.
6800         * std-operator.def: Add UNOP_KIND.
6801
6802 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6803
6804         * f-exp.y (f_parse): Set yydebug.
6805
6806 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6807
6808         * f-lang.c (evaluate_subexp_f): New function.
6809         (exp_descriptor_f): New global.
6810         (f_language_defn): Use exp_descriptor_f instead of
6811         exp_descriptor_standard.
6812
6813 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6814
6815         * f-exp.y (struct token): Add comments.
6816         (dot_ops): Remove uppercase versions and the end marker.
6817         (f77_keywords): Likewise.
6818         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6819         entries in the dot_ops array are case insensitive, and use
6820         strncasecmp to compare strings.  Also some whitespace cleanup in
6821         this area.  Similar for the f77_keywords array, except entries in
6822         this list might be case sensitive.
6823
6824 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6825
6826         * f-exp.y (struct f77_boolean_val): Add comments.
6827         (boolean_values): Remove uppercase versions, and end marker.
6828         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6829         and use strncasecmp to achieve case insensitivity.  Additionally,
6830         perform whitespace cleanup around this code.
6831
6832 2019-03-06  Tom Tromey  <tromey@adacore.com>
6833
6834         * remote-sim.c (gdbsim_target_open): Use result of
6835         gdb_argv::release.
6836
6837 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6838         Dirk Schubert  <dirk.schubert@arm.com>
6839         Chris January  <chris.january@arm.com>
6840
6841         * eval.c (evaluate_subexp_standard): Call Fortran argument
6842         wrapping logic.
6843         * f-lang.c (struct value): A value which can be passed into a
6844         Fortran function call.
6845         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6846         where appropriate.
6847         (struct type): Value ready for a Fortran function call.
6848         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6849         is needed.
6850         * f-lang.h (fortran_argument_convert): Declaration.
6851         (fortran_preserve_arg_pointer): Declaration.
6852         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6853
6854 2019-03-05  Tom Tromey  <tromey@adacore.com>
6855
6856         * python/py-prettyprint.c (print_string_repr): Remove #if.
6857         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6858
6859 2019-03-05  Tom Tromey  <tromey@adacore.com>
6860
6861         * target.c (the_dummy_target): Move later.  Change type to
6862         "dummy_target".
6863         (initialize_targets): Don't initialize the_dummy_target.
6864
6865 2019-03-05  Tom Tromey  <tromey@adacore.com>
6866
6867         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6868         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6869
6870 2019-03-05  Tom Tromey  <tromey@adacore.com>
6871
6872         * windows-nat.c (windows_nat_target::attach)
6873         (windows_nat_target::detach): Don't call gdb_flush.
6874         * valprint.c (generic_val_print, val_print, val_print_string):
6875         Don't call gdb_flush.
6876         * utils.c (defaulted_query): Don't call gdb_flush.
6877         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6878         * target.c (target_announce_detach): Don't call gdb_flush.
6879         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6880         * remote.c (extended_remote_target::attach): Don't call
6881         gdb_flush.
6882         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6883         * printcmd.c (do_examine): Don't call gdb_flush.
6884         (info_display_command): Don't call gdb_flush.
6885         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6886         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6887         * memattr.c (info_mem_command): Don't call gdb_flush.
6888         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6889         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6890         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6891         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6892         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6893         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6894         (gnu_nat_target::detach): Don't call gdb_flush.
6895         * f-valprint.c (f_val_print): Don't call gdb_flush.
6896         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6897         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6898         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6899         gdb_flush.
6900         * c-valprint.c (c_val_print): Don't call gdb_flush.
6901         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6902
6903 2019-03-05  Tom Tromey  <tromey@adacore.com>
6904
6905         * varobj.c (update_dynamic_varobj_children): Update.
6906         (install_default_visualizer): Use reset, not release.
6907         * value.c (set_internalvar): Update.
6908         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6909         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6910         ATTRIBUTE_UNUSED_RESULT.
6911
6912 2019-03-05  Tom Tromey  <tromey@adacore.com>
6913
6914         * remote.c (class scoped_remote_fd) <release>: Add
6915         ATTRIBUTE_UNUSED_RESULT.
6916
6917 2019-03-05  Tom Tromey  <tromey@adacore.com>
6918
6919         * macroexp.c (struct macro_buffer) <release>: Add
6920         ATTRIBUTE_UNUSED_RESULT.
6921
6922 2019-03-05  Tom Tromey  <tromey@adacore.com>
6923
6924         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6925         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6926         ATTRIBUTE_UNUSED_RESULT.
6927
6928 2019-03-05  Tom Tromey  <tromey@adacore.com>
6929
6930         * common/scoped_fd.h (class scoped_fd) <release>: Add
6931         ATTRIBUTE_UNUSED_RESULT.
6932
6933 2019-03-05  Tom Tromey  <tromey@adacore.com>
6934
6935         * parser-defs.h (struct parser_state) <release>: Add
6936         ATTRIBUTE_UNUSED_RESULT.
6937
6938 2019-03-05  Tom Tromey  <tromey@adacore.com>
6939
6940         * utils.h (class gdb_argv) <release>: Add
6941         ATTRIBUTE_UNUSED_RESULT.
6942         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6943
6944 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6945
6946         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6947         for-loop range, to avoid compiler warnings.
6948
6949         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6950         avoid compiler warnings about unused variables.
6951
6952         * NEWS: Mention end of support for native debugging on MS-Windows
6953         before XP.
6954
6955         PR gdb/24292
6956         * common/netstuff.c:
6957         * gdbserver/gdbreplay.c
6958         * gdbserver/remote-utils.c:
6959         * ser-tcp.c:
6960         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6961         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6962         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6963         'getaddrinfo' and 'freeaddrinfo' were not available before
6964         Windows XP, and mingw.org's MinGW headers by default define
6965         _WIN32_WINNT to 0x500.
6966
6967 2019-03-01  Gary Benson <gbenson@redhat.com>
6968
6969         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6970
6971 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6972             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6973
6974         PR gdb/8527
6975         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6976         set_sigint_trap, clear_sigint_trap.
6977
6978 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6979
6980         * target.c (target_detach): Clear the regcache and the
6981         frame cache.
6982
6983 2019-02-27  Pedro Alves  <palves@redhat.com>
6984
6985         * utils.c (set_screen_size): When we cap the height/width sizes,
6986         tweak the corresponding command variable to show "unlimited":
6987
6988 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6989             Pedro Alves  <palves@redhat.com>
6990
6991         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6992         before calling rl_set_screen_size.
6993
6994 2019-02-27  Tom Tromey  <tromey@adacore.com>
6995
6996         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6997         define.
6998         * python/py-value.c: Remove Python 2.4 workaround.
6999         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7000         workaround.
7001         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7002         Python 2.4 workaround.
7003         * python/python-internal.h: Remove Python 2.4 comment.
7004         (Py_ssize_t): Don't define.
7005         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7006         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7007         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7008         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7009         * python/python.c (do_start_initialization): Remove Python 2.4
7010         workaround.
7011         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7012         (print_children): Remove Python 2.4 workaround.
7013         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7014         workaround.
7015         (CHARBUFFERPROC_NAME): Remove.
7016         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7017         Python 2.4 workaround.
7018
7019 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7020
7021         * NEWS: Note minimum Python version.
7022
7023 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7024
7025         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7026         code from these functions.  Remove corresponding ifdefs.  Use
7027         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7028         Remove gotos and target of gotos.
7029         (infpy_search_memory): Likewise.
7030
7031 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7032
7033         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7034         (hppa_gdbarch_init): Don't register deleted functions with
7035         gdbarch.
7036
7037 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7038
7039         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7040         (h8300_unwind_sp): Delete.
7041         (h8300_dummy_id): Delete.
7042         (h8300_gdbarch_init): Don't register deleted functions with
7043         gdbarch.
7044
7045 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7046
7047         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7048         (ft32_unwind_pc): Delete.
7049         (ft32_unwind_sp): Delete.
7050         (ft32_gdbarch_init): Don't register deleted functions with
7051         gdbarch.
7052
7053 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7054
7055         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7056         (frv_unwind_pc): Delete.
7057         (frv_unwind_sp): Delete.
7058         (frv_gdbarch_init): Don't register deleted functions with
7059         gdbarch.
7060
7061 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7062
7063         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7064         (riscv_unwind_pc): Delete.
7065         (riscv_unwind_sp): Delete.
7066         (riscv_gdbarch_init): Don't register deleted functions with
7067         gdbarch.
7068
7069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7070
7071         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7072         (csky_unwind_pc): Delete.
7073         (csky_unwind_sp): Delete.
7074         (csky_gdbarch_init): Don't register deleted functions with
7075         gdbarch.
7076
7077 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7078
7079         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7080         (cris_unwind_pc): Delete.
7081         (cris_unwind_sp): Delete.
7082         (cris_gdbarch_init): Don't register deleted functions with
7083         gdbarch.
7084
7085 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7088         (bfin_unwind_pc): Delete.
7089         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7090
7091 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7092
7093         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7094         (arm_unwind_pc): Delete.
7095         (arm_unwind_sp): Delete.
7096         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7097
7098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7099
7100         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7101         (arc_unwind_pc): Delete.
7102         (arc_unwind_sp): Delete.
7103         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7104
7105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7106
7107         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7108         (alpha_unwind_pc): Delete.
7109         (alpha_gdbarch_init): Don't register deleted functions with
7110         gdbarch.
7111
7112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7115         (aarch64_unwind_pc): Delete.
7116         (aarch64_unwind_sp): Delete.
7117         (aarch64_gdbarch_init): Don't register deleted functions with
7118         gdbarch.
7119
7120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7121
7122         * gdbtypes.c (type_align): Don't consider static members when
7123         computing structure alignment.
7124
7125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7126
7127         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7128         return 0 for other types.
7129         * arch-utils.c (default_type_align): Always return 0.
7130         * gdbarch.h: Regenerate.
7131         * gdbarch.sh (type_align): Extend comment.
7132         * gdbtypes.c (type_align): Add additional comments, always call
7133         gdbarch_type_align before applying the default rules.
7134         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7135         generic code will then apply a suitable default.
7136         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7137         types, return 0 for other types.
7138
7139 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7140
7141         * NEWS: Create a new section for the next release branch.
7142         Rename the section of the current branch, now that it has
7143         been cut.
7144
7145 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7146
7147         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7148         * version.in: Bump version to 8.3.50.DATE-git.
7149
7150 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7151
7152         * aix-thread.c (ptid_cmp): Remove unused variable.
7153         (get_signaled_thread): Likewise.
7154         (store_regs_user_thread): Likewise.
7155         (store_regs_kernel_thread): Likewise.
7156         (fetch_regs_kernel_thread): Remove shadowed variable.
7157
7158 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7159
7160         * features/riscv/32bit-cpu.xml: Add register numbers.
7161         * features/riscv/32bit-fpu.c: Regenerate.
7162         * features/riscv/32bit-fpu.xml: Add register numbers.
7163         * features/riscv/64bit-cpu.xml: Add register numbers.
7164         * features/riscv/64bit-fpu.c: Regenerate.
7165         * features/riscv/64bit-fpu.xml: Add register numbers.
7166
7167 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7168
7169         * NEWS: Mention two argument form of gdb.Value constructor.
7170         * python/py-value.c (convert_buffer_and_type_to_value): New
7171         function.
7172         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7173         Add support for handling an optional second argument.  Call
7174         convert_buffer_and_type_to_value as appropriate.
7175         * python/python-internal.h (Py_buffer_deleter): New struct.
7176         (Py_buffer_up): New typedef.
7177
7178 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7179
7180         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7181         instead of releasing ownership.
7182
7183 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7184
7185         * dwarf2read.c (open_and_init_dwp_file): Call
7186         elf_numsections instead of bfd_count_sections to initialize
7187         dwp_file->num_sections.
7188
7189 2019-02-25  Tom Tromey  <tromey@adacore.com>
7190
7191         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7192
7193 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7194
7195         * gcore.in: Add '--readnever' option when invoking GDB.
7196
7197 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7198
7199         * MAINTAINERS: Update my email address.
7200
7201 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7202
7203         * build-id.c (build_id_to_debug_bfd_1): New function.
7204         (build_id_to_debug_bfd): Look for separate debug file in
7205         sysroot.
7206
7207 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7208
7209         * gdbarch.sh: Update the copyright year range that is placed into
7210         generated files.
7211
7212 2019-02-22  Keith Seitz  <keiths@redhat.com>
7213
7214         PR symtab/23853
7215         * linespec.c (create_sals_line_offset): Search for the default
7216         symtab's filename instead of its fullname.
7217
7218 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7219
7220         * NEWS: Update style defaults.
7221
7222 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7223
7224         * main.c (captured_main_1): Disable styling in batch mode.
7225
7226 2019-02-20  Tom Tromey  <tom@tromey.com>
7227
7228         * symtab.c (symtab_symbol_info): Fix typos.
7229
7230 2019-02-20  Tom Tromey  <tromey@adacore.com>
7231
7232         * findcmd.c (_initialize_mem_search): Use upper case for
7233         metasyntactic variables.
7234
7235 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7236
7237         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7238         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7239
7240 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7241
7242         * top.h (source_file_name): Change to std::string.
7243         * top.c (source_file_name): Likewise.
7244         (command_line_input): Adjust.
7245         * cli/cli-script.c (script_from_file): Adjust.
7246
7247 2019-02-19  Tom Tromey  <tromey@adacore.com>
7248
7249         * ravenscar-thread.c
7250         (ravenscar_thread_target::update_thread_list): Don't call
7251         ada_build_task_list.
7252         * ada-lang.h (ada_build_task_list): Don't declare.
7253         * ada-tasks.c (struct ada_tasks_inferior_data)
7254         <task_list_valid_p>: Now bool.
7255         (read_known_tasks, ada_task_list_changed)
7256         (ada_tasks_invalidate_inferior_data): Update.
7257         (read_known_tasks_array): Return bool.
7258         (read_known_tasks_list): Likewise.
7259         (read_known_tasks): Return void.
7260         (ada_build_task_list): Now static.
7261
7262 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7263
7264         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7265         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7266
7267 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7268
7269         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7270         variant for ada_tasks_pspace_data_handle and
7271         ada_tasks_inferior_data_handle.
7272         (ada_tasks_pspace_data_cleanup): New function.
7273         (ada_tasks_inferior_data_cleanup): New function.
7274
7275 2019-02-17  Tom Tromey  <tom@tromey.com>
7276
7277         * macrotab.h (macro_source_fullname): Return a std::string.
7278         * macrotab.c (macro_include, check_for_redefinition)
7279         (macro_undef, macro_lookup_definition, foreach_macro)
7280         (foreach_macro_in_scope): Update.
7281         (macro_source_fullname): Return a std::string.
7282         * macrocmd.c (show_pp_source_pos): Update.
7283
7284 2019-02-17  Tom Tromey  <tom@tromey.com>
7285
7286         * macrocmd.c (show_pp_source_pos): Style the file names.
7287
7288 2019-02-17  Tom Tromey  <tom@tromey.com>
7289
7290         PR tui/24197:
7291         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7292
7293 2019-02-17  Tom Tromey  <tom@tromey.com>
7294
7295         * ada-lang.c (user_select_syms): Use filtered printing.
7296         * utils.c (wrap_style): New global.
7297         (desired_style): Remove.
7298         (emit_style_escape): Add stream parameter.
7299         (set_output_style, reset_terminal_style, prompt_for_continue):
7300         Update.
7301         (flush_wrap_buffer): Only flush gdb_stdout.
7302         (wrap_here): Set wrap_style.
7303         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7304         treat escape sequences as a character.  Change when wrap buffer is
7305         flushed.
7306         (fputs_styled): Do not set the output style when the default is
7307         requested.
7308         * ui-style.h (struct ui_file_style) <is_default>: New method.
7309         * source.c (print_source_lines_base): Emit escape sequences in one
7310         piece.
7311
7312 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7313
7314         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7315         integers and enumeration types.
7316
7317 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7318
7319         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7320         instead of lookup_symbol_in_language
7321         (do_exact_match): New function.
7322         (ada_get_symbol_name_matcher): Return do_exact_match when
7323         doing a verbatim match.
7324
7325 2019-02-15  Tom Tromey  <tromey@adacore.com>
7326
7327         * ravenscar-thread.c (ravenscar_thread_target::resume)
7328         (ravenscar_thread_target::wait): Special case wildcard requests.
7329
7330 2019-02-15  Tom Tromey  <tromey@adacore.com>
7331
7332         * ravenscar-thread.c (base_ptid): Remove.
7333         (struct ravenscar_thread_target) <close>: New method.
7334         <m_base_ptid>: New member.
7335         <update_inferior_ptid, active_task, task_is_currently_active,
7336         runtime_initialized>: Declare methods.
7337         <ravenscar_thread_target>: Add constructor.
7338         (ravenscar_thread_target::task_is_currently_active)
7339         (ravenscar_thread_target::update_inferior_ptid)
7340         (ravenscar_runtime_initialized): Rename.  Now methods.
7341         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7342         (ravenscar_thread_target::update_thread_list): Update.
7343         (ravenscar_thread_target::active_task): Now method.
7344         (ravenscar_thread_target::store_registers)
7345         (ravenscar_thread_target::prepare_to_store)
7346         (ravenscar_thread_target::prepare_to_store)
7347         (ravenscar_thread_target::mourn_inferior): Update.
7348         (ravenscar_inferior_created): Use "new" to create target.
7349         (ravenscar_thread_target::get_ada_task_ptid): Update.
7350         (_initialize_ravenscar): Don't initialize base_ptid.
7351         (ravenscar_ops): Remove global.
7352
7353 2019-02-15  Tom Tromey  <tromey@adacore.com>
7354
7355         * target.h (push_target): Declare new overload.
7356         * target.c (push_target): New overload, taking an rvalue reference.
7357         * remote.c (remote_target::open_1): Use push_target overload.
7358         * corelow.c (core_target_open): Use push_target overload.
7359
7360 2019-02-15  Tom Tromey  <tromey@adacore.com>
7361
7362         * ravenscar-thread.c (is_ravenscar_task)
7363         (ravenscar_task_is_currently_active): Return bool.
7364         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7365         (_initialize_ravenscar): Remove "(void)".
7366         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7367         Return bool.
7368
7369 2019-02-15  Tom Tromey  <tromey@adacore.com>
7370
7371         * ravenscar-thread.c (ravenscar_runtime_initializer)
7372         (has_ravenscar_runtime, get_running_thread_id)
7373         (ravenscar_thread_target::resume): Fix indentation.
7374
7375 2019-02-15  Tom Tromey  <tromey@adacore.com>
7376
7377         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7378         from ravenscar_arch_ops.
7379         (sparc_ravenscar_ops::fetch_registers)
7380         (sparc_ravenscar_ops::store_registers): Now methods.
7381         (sparc_ravenscar_prepare_to_store): Remove.
7382         (sparc_ravenscar_ops): Redefine.
7383         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7384         methods and destructor.  Remove members.
7385         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7386         (ravenscar_thread_target::store_registers)
7387         (ravenscar_thread_target::prepare_to_store): Update.
7388         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7389         Remove.
7390         (struct ppc_ravenscar_powerpc_ops): Derive from
7391         ravenscar_arch_ops.
7392         (ppc_ravenscar_powerpc_ops::fetch_registers)
7393         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7394         (ppc_ravenscar_powerpc_ops): Redefine.
7395         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7396         (ppc_ravenscar_e500_ops::fetch_registers)
7397         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7398         (ppc_ravenscar_e500_ops): Redefine.
7399         * aarch64-ravenscar-thread.c
7400         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7401         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7402         (aarch64_ravenscar_fetch_registers)
7403         (aarch64_ravenscar_store_registers): Now methods.
7404         (aarch64_ravenscar_ops): Redefine.
7405
7406 2019-02-15  Tom Tromey  <tromey@adacore.com>
7407
7408         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7409         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7410         (ravenscar_thread_target::stopped_by_watchpoint)
7411         (ravenscar_thread_target::stopped_data_address)
7412         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7413
7414 2019-02-15  Tom Tromey  <tromey@adacore.com>
7415
7416         * ravenscar-thread.c: Fix some typos.
7417
7418 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7419             Tom Tromey  <tromey@adacore.com>
7420
7421         * ada-lang.c (ada_exception_sal): Change addr_string to a
7422         std::string.
7423         (create_ada_exception_catchpoint): Update.
7424
7425 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7426             Tom Tromey  <tromey@adacore.com>
7427
7428         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7429         (bp_location_ops): Remove.
7430         (base_breakpoint_allocate_location): Update.
7431         (free_bp_location): Update.
7432         * ada-lang.c (class ada_catchpoint_location)
7433         <ada_catchpoint_location>: Remove ops parameter.
7434         (ada_catchpoint_location_dtor): Remove.
7435         (ada_catchpoint_location_ops): Remove.
7436         (allocate_location_exception): Update.
7437         * breakpoint.h (struct bp_location_ops): Remove.
7438         (class bp_location) <bp_location>: Remove bp_location_ops
7439         parameter.
7440         <~bp_location>: Add destructor.
7441         <ops>: Remove.
7442
7443 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7444             Pedro Alves  <palves@redhat.com>
7445
7446         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7447         'PATH_MAX'.
7448
7449 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7450             Samuel Thibault  <samuel.thibault@gnu.org>
7451             Thomas Schwinge  <thomas@codesourcery.com>
7452
7453         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7454         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7455
7456 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7457
7458         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7459         (check_empty): Use "const char *".
7460
7461         * gnu-nat.c (gnu_nat_target::detach): Instead of
7462         'detach_inferior (pid)' call
7463         'detach_inferior (find_inferior_pid (pid))'.
7464
7465         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7466         'nat/fork-inferior.o'.
7467         * gnu-nat.c: #include "nat/fork-inferior.h".
7468
7469         * gnu-nat.c (gnu_nat_target::detach): Instead of
7470         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7471         * gnu-nat.h: #include "inf-child.h".
7472         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7473         'i386_gnu_nat_target::fetch_registers'.
7474         (gnu_store_registers): Rename/move to
7475         'i386_gnu_nat_target::store_registers'.
7476
7477         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7478         * gnu-nat.h (mach_thread_info): New function.
7479         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7480
7481         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7482
7483 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7484
7485         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7486
7487 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7488
7489         * windows-nat.c (windows_add_thread): Add new parameter
7490         "main_thread_p" with default value set to false.  Update
7491         function documentation as well as all callers.
7492         (windows_delete_thread): Likewise.
7493         (fake_create_process): Update call to windows_add_thread.
7494         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7495         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7496         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7497         call to windows_delete_thread.
7498
7499 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7500
7501         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7502
7503 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7504
7505         * symfile.c (find_separate_debug_file): Use canonical path of
7506         sysroot with child_path instead of gdb_sysroot if it is valid.
7507
7508 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7509
7510         * symfile.c (find_separate_debug_file): Use child_path to
7511         determine if an object file is under a sysroot.
7512
7513 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7514
7515         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7516         unittests/child-path-selftests.c.
7517         * common/pathstuff.c (child_path): New function.
7518         * common/pathstuff.h (child_path): New prototype.
7519         * unittests/child-path-selftests.c: New file.
7520
7521 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7522
7523         * symfile.c (find_separate_debug_file): Look for separate debug
7524         files in debug directories under the sysroot.
7525
7526 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7527
7528         * symtab.h (struct minimal_symbol data_p): New const method.
7529         (struct minimal_symbol text_p): Likewise.
7530         * symtab.c (output_source_filename): Use file name style
7531         to print file name.
7532         (print_symbol_info): Likewise.
7533         (print_msymbol_info): Use address style to print addresses.
7534         Use function name style to print executable text symbols.
7535         (expand_symtab_containing_pc): Use data_p.
7536         (find_pc_sect_compunit_symtab): Likewise.
7537
7538 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7539
7540         * breakpoint.c (describe_other_breakpoints): Use address style
7541         to print addresses.
7542         (say_where): Likewise.
7543
7544 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7545
7546         * ada-typeprint.c (print_func_type): Print function name
7547         style to print function name.
7548         * c-typeprint.c (c_print_type_1): Likewise.
7549
7550 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7551
7552         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7553         for execve.
7554
7555 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7556
7557         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7558         type_stack.
7559
7560 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7561
7562         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7563         TYPE_CODE_REF types.
7564
7565 2019-02-08  Jim Wilson  <jimw@sifive.com>
7566
7567         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7568         (riscv_linux_fregset): New.
7569         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7570
7571 2019-02-07  Tom Tromey  <tom@tromey.com>
7572
7573         * thread.c (thread_cancel_execution_command): Update.
7574         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7575         methods.
7576         (struct thread_fsm_ops): Remove.
7577         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7578         (thread_fsm_should_stop, thread_fsm_return_value)
7579         (thread_fsm_set_finished, thread_fsm_finished_p)
7580         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7581         Don't declare.
7582         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7583         * infrun.c (clear_proceed_status_thread)
7584         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7585         (print_stop_event): Update.
7586         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7587         Add constructor.
7588         (step_command_fsm_ops): Remove.
7589         (new_step_command_fsm): Remove.
7590         (step_1): Update.
7591         (step_command_fsm::should_stop): Rename from
7592         step_command_fsm_should_stop.
7593         (step_command_fsm::clean_up): Rename from
7594         step_command_fsm_clean_up.
7595         (step_command_fsm::do_async_reply_reason): Rename from
7596         step_command_fsm_async_reply_reason.
7597         (struct until_next_fsm): Inherit from thread_fsm.  Add
7598         constructor.
7599         (until_next_fsm_ops): Remove.
7600         (new_until_next_fsm): Remove.
7601         (until_next_fsm::should_stop): Rename from
7602         until_next_fsm_should_stop.
7603         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7604         (until_next_fsm::do_async_reply_reason): Rename from
7605         until_next_fsm_async_reply_reason.
7606         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7607         constructor.  Change type of breakpoint.
7608         (finish_command_fsm_ops): Remove.
7609         (new_finish_command_fsm): Remove.
7610         (finish_command_fsm::should_stop): Rename from
7611         finish_command_fsm_should_stop.
7612         (finish_command_fsm::clean_up): Rename from
7613         finish_command_fsm_clean_up.
7614         (finish_command_fsm::return_value): Rename from
7615         finish_command_fsm_return_value.
7616         (finish_command_fsm::do_async_reply_reason): Rename from
7617         finish_command_fsm_async_reply_reason.
7618         (finish_command): Update.
7619         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7620         Add constructor.
7621         (call_thread_fsm_ops): Remove.
7622         (call_thread_fsm::call_thread_fsm): Rename from
7623         new_call_thread_fsm.
7624         (call_thread_fsm::should_stop): Rename from
7625         call_thread_fsm_should_stop.
7626         (call_thread_fsm::should_notify_stop): Rename from
7627         call_thread_fsm_should_notify_stop.
7628         (run_inferior_call, call_function_by_hand_dummy): Update.
7629         * cli/cli-interp.c (should_print_stop_to_console): Update.
7630         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7631         Add constructor.  Change type of location_breakpoint,
7632         caller_breakpoint.
7633         (until_break_fsm_ops): Remove.
7634         (new_until_break_fsm): Remove.
7635         (until_break_fsm::should_stop): Rename from
7636         until_break_fsm_should_stop.
7637         (until_break_fsm::clean_up): Rename from
7638         until_break_fsm_clean_up.
7639         (until_break_fsm::do_async_reply_reason): Rename from
7640         until_break_fsm_async_reply_reason.
7641         (until_break_command): Update.
7642         * thread-fsm.c: Remove.
7643         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7644
7645 2019-02-07  Tom Tromey  <tom@tromey.com>
7646
7647         * yy-remap.h: Add include guard.
7648         * xtensa-tdep.h: Add include guard.
7649         * xcoffread.h: Rename include guard.
7650         * varobj-iter.h: Add include guard.
7651         * tui/tui.h: Rename include guard.
7652         * tui/tui-winsource.h: Rename include guard.
7653         * tui/tui-wingeneral.h: Rename include guard.
7654         * tui/tui-windata.h: Rename include guard.
7655         * tui/tui-win.h: Rename include guard.
7656         * tui/tui-stack.h: Rename include guard.
7657         * tui/tui-source.h: Rename include guard.
7658         * tui/tui-regs.h: Rename include guard.
7659         * tui/tui-out.h: Rename include guard.
7660         * tui/tui-layout.h: Rename include guard.
7661         * tui/tui-io.h: Rename include guard.
7662         * tui/tui-hooks.h: Rename include guard.
7663         * tui/tui-file.h: Rename include guard.
7664         * tui/tui-disasm.h: Rename include guard.
7665         * tui/tui-data.h: Rename include guard.
7666         * tui/tui-command.h: Rename include guard.
7667         * tic6x-tdep.h: Add include guard.
7668         * target/waitstatus.h: Rename include guard.
7669         * target/wait.h: Rename include guard.
7670         * target/target.h: Rename include guard.
7671         * target/resume.h: Rename include guard.
7672         * target-float.h: Rename include guard.
7673         * stabsread.h: Add include guard.
7674         * rs6000-tdep.h: Add include guard.
7675         * riscv-fbsd-tdep.h: Add include guard.
7676         * regformats/regdef.h: Rename include guard.
7677         * record.h: Rename include guard.
7678         * python/python.h: Rename include guard.
7679         * python/python-internal.h: Rename include guard.
7680         * python/py-stopevent.h: Rename include guard.
7681         * python/py-ref.h: Rename include guard.
7682         * python/py-record.h: Rename include guard.
7683         * python/py-record-full.h: Rename include guard.
7684         * python/py-record-btrace.h: Rename include guard.
7685         * python/py-instruction.h: Rename include guard.
7686         * python/py-events.h: Rename include guard.
7687         * python/py-event.h: Rename include guard.
7688         * procfs.h: Add include guard.
7689         * proc-utils.h: Add include guard.
7690         * p-lang.h: Add include guard.
7691         * or1k-tdep.h: Rename include guard.
7692         * observable.h: Rename include guard.
7693         * nto-tdep.h: Rename include guard.
7694         * nat/x86-linux.h: Rename include guard.
7695         * nat/x86-linux-dregs.h: Rename include guard.
7696         * nat/x86-gcc-cpuid.h: Add include guard.
7697         * nat/x86-dregs.h: Rename include guard.
7698         * nat/x86-cpuid.h: Rename include guard.
7699         * nat/ppc-linux.h: Rename include guard.
7700         * nat/mips-linux-watch.h: Rename include guard.
7701         * nat/linux-waitpid.h: Rename include guard.
7702         * nat/linux-ptrace.h: Rename include guard.
7703         * nat/linux-procfs.h: Rename include guard.
7704         * nat/linux-osdata.h: Rename include guard.
7705         * nat/linux-nat.h: Rename include guard.
7706         * nat/linux-namespaces.h: Rename include guard.
7707         * nat/linux-btrace.h: Rename include guard.
7708         * nat/glibc_thread_db.h: Rename include guard.
7709         * nat/gdb_thread_db.h: Rename include guard.
7710         * nat/gdb_ptrace.h: Rename include guard.
7711         * nat/fork-inferior.h: Rename include guard.
7712         * nat/amd64-linux-siginfo.h: Rename include guard.
7713         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7714         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7715         * nat/aarch64-linux.h: Rename include guard.
7716         * nat/aarch64-linux-hw-point.h: Rename include guard.
7717         * mn10300-tdep.h: Add include guard.
7718         * mips-linux-tdep.h: Add include guard.
7719         * mi/mi-parse.h: Rename include guard.
7720         * mi/mi-out.h: Rename include guard.
7721         * mi/mi-main.h: Rename include guard.
7722         * mi/mi-interp.h: Rename include guard.
7723         * mi/mi-getopt.h: Rename include guard.
7724         * mi/mi-console.h: Rename include guard.
7725         * mi/mi-common.h: Rename include guard.
7726         * mi/mi-cmds.h: Rename include guard.
7727         * mi/mi-cmd-break.h: Rename include guard.
7728         * m2-lang.h: Add include guard.
7729         * location.h: Rename include guard.
7730         * linux-record.h: Rename include guard.
7731         * linux-nat.h: Add include guard.
7732         * linux-fork.h: Add include guard.
7733         * i386-darwin-tdep.h: Rename include guard.
7734         * hppa-linux-offsets.h: Add include guard.
7735         * guile/guile.h: Rename include guard.
7736         * guile/guile-internal.h: Rename include guard.
7737         * gnu-nat.h: Rename include guard.
7738         * gdb-stabs.h: Rename include guard.
7739         * frv-tdep.h: Add include guard.
7740         * f-lang.h: Add include guard.
7741         * event-loop.h: Add include guard.
7742         * darwin-nat.h: Rename include guard.
7743         * cp-abi.h: Rename include guard.
7744         * config/sparc/nm-sol2.h: Rename include guard.
7745         * config/nm-nto.h: Rename include guard.
7746         * config/nm-linux.h: Add include guard.
7747         * config/i386/nm-i386gnu.h: Rename include guard.
7748         * config/djgpp/nl_types.h: Rename include guard.
7749         * config/djgpp/langinfo.h: Rename include guard.
7750         * compile/gcc-cp-plugin.h: Add include guard.
7751         * compile/gcc-c-plugin.h: Add include guard.
7752         * compile/compile.h: Rename include guard.
7753         * compile/compile-object-run.h: Rename include guard.
7754         * compile/compile-object-load.h: Rename include guard.
7755         * compile/compile-internal.h: Rename include guard.
7756         * compile/compile-cplus.h: Rename include guard.
7757         * compile/compile-c.h: Rename include guard.
7758         * common/xml-utils.h: Rename include guard.
7759         * common/x86-xstate.h: Rename include guard.
7760         * common/version.h: Rename include guard.
7761         * common/vec.h: Rename include guard.
7762         * common/tdesc.h: Rename include guard.
7763         * common/selftest.h: Rename include guard.
7764         * common/scoped_restore.h: Rename include guard.
7765         * common/scoped_mmap.h: Rename include guard.
7766         * common/scoped_fd.h: Rename include guard.
7767         * common/safe-iterator.h: Rename include guard.
7768         * common/run-time-clock.h: Rename include guard.
7769         * common/refcounted-object.h: Rename include guard.
7770         * common/queue.h: Rename include guard.
7771         * common/ptid.h: Rename include guard.
7772         * common/print-utils.h: Rename include guard.
7773         * common/preprocessor.h: Rename include guard.
7774         * common/pathstuff.h: Rename include guard.
7775         * common/observable.h: Rename include guard.
7776         * common/netstuff.h: Rename include guard.
7777         * common/job-control.h: Rename include guard.
7778         * common/host-defs.h: Rename include guard.
7779         * common/gdb_wait.h: Rename include guard.
7780         * common/gdb_vecs.h: Rename include guard.
7781         * common/gdb_unlinker.h: Rename include guard.
7782         * common/gdb_unique_ptr.h: Rename include guard.
7783         * common/gdb_tilde_expand.h: Rename include guard.
7784         * common/gdb_sys_time.h: Rename include guard.
7785         * common/gdb_string_view.h: Rename include guard.
7786         * common/gdb_splay_tree.h: Rename include guard.
7787         * common/gdb_setjmp.h: Rename include guard.
7788         * common/gdb_ref_ptr.h: Rename include guard.
7789         * common/gdb_optional.h: Rename include guard.
7790         * common/gdb_locale.h: Rename include guard.
7791         * common/gdb_assert.h: Rename include guard.
7792         * common/filtered-iterator.h: Rename include guard.
7793         * common/filestuff.h: Rename include guard.
7794         * common/fileio.h: Rename include guard.
7795         * common/environ.h: Rename include guard.
7796         * common/common-utils.h: Rename include guard.
7797         * common/common-types.h: Rename include guard.
7798         * common/common-regcache.h: Rename include guard.
7799         * common/common-inferior.h: Rename include guard.
7800         * common/common-gdbthread.h: Rename include guard.
7801         * common/common-exceptions.h: Rename include guard.
7802         * common/common-defs.h: Rename include guard.
7803         * common/common-debug.h: Rename include guard.
7804         * common/cleanups.h: Rename include guard.
7805         * common/buffer.h: Rename include guard.
7806         * common/btrace-common.h: Rename include guard.
7807         * common/break-common.h: Rename include guard.
7808         * cli/cli-utils.h: Rename include guard.
7809         * cli/cli-style.h: Rename include guard.
7810         * cli/cli-setshow.h: Rename include guard.
7811         * cli/cli-script.h: Rename include guard.
7812         * cli/cli-interp.h: Rename include guard.
7813         * cli/cli-decode.h: Rename include guard.
7814         * cli/cli-cmds.h: Rename include guard.
7815         * charset-list.h: Add include guard.
7816         * buildsym-legacy.h: Rename include guard.
7817         * bfin-tdep.h: Add include guard.
7818         * ax.h: Rename include guard.
7819         * arm-linux-tdep.h: Add include guard.
7820         * arm-fbsd-tdep.h: Add include guard.
7821         * arch/xtensa.h: Rename include guard.
7822         * arch/tic6x.h: Add include guard.
7823         * arch/i386.h: Add include guard.
7824         * arch/arm.h: Rename include guard.
7825         * arch/arm-linux.h: Rename include guard.
7826         * arch/arm-get-next-pcs.h: Rename include guard.
7827         * arch/amd64.h: Add include guard.
7828         * arch/aarch64-insn.h: Rename include guard.
7829         * arch-utils.h: Rename include guard.
7830         * annotate.h: Add include guard.
7831         * amd64-darwin-tdep.h: Rename include guard.
7832         * aarch64-linux-tdep.h: Add include guard.
7833         * aarch64-fbsd-tdep.h: Add include guard.
7834         * aarch32-linux-nat.h: Add include guard.
7835
7836 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7837
7838         * macrotab.c (macro_define_internal): New function that
7839         factorizes macro_define_object_internal and macro_define_function
7840         code.
7841         (macro_define_object_internal): Use macro_define_internal.
7842         (macro_define_function): Likewise.
7843
7844 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7845
7846         * macrocmd.c (extract_identifier): Return
7847         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7848         callers.
7849
7850 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7851
7852         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7853
7854 2019-02-05  Tom Tromey  <tom@tromey.com>
7855
7856         * target.c (target_stack::unpush): Move assertion earlier.
7857
7858 2019-01-30  Tom Tromey  <tom@tromey.com>
7859
7860         PR python/23615:
7861         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7862         (gdbpy_parse_and_eval): Likewise.
7863         * python/python-internal.h (gdbpy_allow_threads): New class.
7864
7865 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7866
7867         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7868         (aarch64_fbsd_fpregmap): Move earlier.
7869         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7870         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7871         instead of individual calls to trad_frame_set_reg_addr.
7872         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7873         earlier.
7874         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7875         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7876         instead of individual calls to trad_frame_set_reg_addr.
7877
7878 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7879
7880         * CONTRIBUTE: Replace contribution list with wiki link.
7881
7882 2019-01-25  Tom Tromey  <tom@tromey.com>
7883
7884         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7885
7886 2019-01-25  Tom Tromey  <tom@tromey.com>
7887
7888         * xtensa-linux-nat.c: Fix common/ includes.
7889         * xml-support.h: Fix common/ includes.
7890         * xml-support.c: Fix common/ includes.
7891         * x86-linux-nat.c: Fix common/ includes.
7892         * windows-nat.c: Fix common/ includes.
7893         * varobj.h: Fix common/ includes.
7894         * varobj.c: Fix common/ includes.
7895         * value.c: Fix common/ includes.
7896         * valops.c: Fix common/ includes.
7897         * utils.c: Fix common/ includes.
7898         * unittests/xml-utils-selftests.c: Fix common/ includes.
7899         * unittests/utils-selftests.c: Fix common/ includes.
7900         * unittests/unpack-selftests.c: Fix common/ includes.
7901         * unittests/tracepoint-selftests.c: Fix common/ includes.
7902         * unittests/style-selftests.c: Fix common/ includes.
7903         * unittests/string_view-selftests.c: Fix common/ includes.
7904         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7905         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7906         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7907         * unittests/rsp-low-selftests.c: Fix common/ includes.
7908         * unittests/parse-connection-spec-selftests.c: Fix common/
7909         includes.
7910         * unittests/optional-selftests.c: Fix common/ includes.
7911         * unittests/offset-type-selftests.c: Fix common/ includes.
7912         * unittests/observable-selftests.c: Fix common/ includes.
7913         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7914         * unittests/memrange-selftests.c: Fix common/ includes.
7915         * unittests/memory-map-selftests.c: Fix common/ includes.
7916         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7917         * unittests/function-view-selftests.c: Fix common/ includes.
7918         * unittests/environ-selftests.c: Fix common/ includes.
7919         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7920         * unittests/common-utils-selftests.c: Fix common/ includes.
7921         * unittests/cli-utils-selftests.c: Fix common/ includes.
7922         * unittests/array-view-selftests.c: Fix common/ includes.
7923         * ui-file.c: Fix common/ includes.
7924         * tui/tui-io.c: Fix common/ includes.
7925         * tracepoint.h: Fix common/ includes.
7926         * tracepoint.c: Fix common/ includes.
7927         * tracefile-tfile.c: Fix common/ includes.
7928         * top.h: Fix common/ includes.
7929         * top.c: Fix common/ includes.
7930         * thread.c: Fix common/ includes.
7931         * target/waitstatus.h: Fix common/ includes.
7932         * target/waitstatus.c: Fix common/ includes.
7933         * target.h: Fix common/ includes.
7934         * target.c: Fix common/ includes.
7935         * target-memory.c: Fix common/ includes.
7936         * target-descriptions.c: Fix common/ includes.
7937         * symtab.h: Fix common/ includes.
7938         * symfile.c: Fix common/ includes.
7939         * stap-probe.c: Fix common/ includes.
7940         * spu-linux-nat.c: Fix common/ includes.
7941         * sparc-nat.c: Fix common/ includes.
7942         * source.c: Fix common/ includes.
7943         * solib.c: Fix common/ includes.
7944         * solib-target.c: Fix common/ includes.
7945         * ser-unix.c: Fix common/ includes.
7946         * ser-tcp.c: Fix common/ includes.
7947         * ser-pipe.c: Fix common/ includes.
7948         * ser-base.c: Fix common/ includes.
7949         * selftest-arch.c: Fix common/ includes.
7950         * s12z-tdep.c: Fix common/ includes.
7951         * rust-exp.y: Fix common/ includes.
7952         * rs6000-aix-tdep.c: Fix common/ includes.
7953         * riscv-tdep.c: Fix common/ includes.
7954         * remote.c: Fix common/ includes.
7955         * remote-notif.h: Fix common/ includes.
7956         * remote-fileio.h: Fix common/ includes.
7957         * remote-fileio.c: Fix common/ includes.
7958         * regcache.h: Fix common/ includes.
7959         * regcache.c: Fix common/ includes.
7960         * record-btrace.c: Fix common/ includes.
7961         * python/python.c: Fix common/ includes.
7962         * python/py-type.c: Fix common/ includes.
7963         * python/py-inferior.c: Fix common/ includes.
7964         * progspace.h: Fix common/ includes.
7965         * producer.c: Fix common/ includes.
7966         * procfs.c: Fix common/ includes.
7967         * proc-api.c: Fix common/ includes.
7968         * printcmd.c: Fix common/ includes.
7969         * ppc-linux-nat.c: Fix common/ includes.
7970         * parser-defs.h: Fix common/ includes.
7971         * osdata.c: Fix common/ includes.
7972         * obsd-nat.c: Fix common/ includes.
7973         * nat/x86-linux.c: Fix common/ includes.
7974         * nat/x86-linux-dregs.c: Fix common/ includes.
7975         * nat/x86-dregs.h: Fix common/ includes.
7976         * nat/x86-dregs.c: Fix common/ includes.
7977         * nat/ppc-linux.c: Fix common/ includes.
7978         * nat/mips-linux-watch.h: Fix common/ includes.
7979         * nat/mips-linux-watch.c: Fix common/ includes.
7980         * nat/linux-waitpid.c: Fix common/ includes.
7981         * nat/linux-ptrace.h: Fix common/ includes.
7982         * nat/linux-ptrace.c: Fix common/ includes.
7983         * nat/linux-procfs.c: Fix common/ includes.
7984         * nat/linux-personality.c: Fix common/ includes.
7985         * nat/linux-osdata.c: Fix common/ includes.
7986         * nat/linux-namespaces.c: Fix common/ includes.
7987         * nat/linux-btrace.h: Fix common/ includes.
7988         * nat/linux-btrace.c: Fix common/ includes.
7989         * nat/fork-inferior.c: Fix common/ includes.
7990         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7991         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7992         * nat/aarch64-linux.c: Fix common/ includes.
7993         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7994         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7995         * namespace.h: Fix common/ includes.
7996         * mips-linux-tdep.c: Fix common/ includes.
7997         * minsyms.c: Fix common/ includes.
7998         * mi/mi-parse.h: Fix common/ includes.
7999         * mi/mi-main.c: Fix common/ includes.
8000         * mi/mi-cmd-env.c: Fix common/ includes.
8001         * memrange.h: Fix common/ includes.
8002         * memattr.c: Fix common/ includes.
8003         * maint.h: Fix common/ includes.
8004         * maint.c: Fix common/ includes.
8005         * main.c: Fix common/ includes.
8006         * machoread.c: Fix common/ includes.
8007         * location.c: Fix common/ includes.
8008         * linux-thread-db.c: Fix common/ includes.
8009         * linux-nat.c: Fix common/ includes.
8010         * linux-fork.c: Fix common/ includes.
8011         * inline-frame.c: Fix common/ includes.
8012         * infrun.c: Fix common/ includes.
8013         * inflow.c: Fix common/ includes.
8014         * inferior.h: Fix common/ includes.
8015         * inferior.c: Fix common/ includes.
8016         * infcmd.c: Fix common/ includes.
8017         * inf-ptrace.c: Fix common/ includes.
8018         * inf-child.c: Fix common/ includes.
8019         * ia64-linux-nat.c: Fix common/ includes.
8020         * i387-tdep.c: Fix common/ includes.
8021         * i386-tdep.c: Fix common/ includes.
8022         * i386-linux-tdep.c: Fix common/ includes.
8023         * i386-linux-nat.c: Fix common/ includes.
8024         * i386-go32-tdep.c: Fix common/ includes.
8025         * i386-fbsd-tdep.c: Fix common/ includes.
8026         * i386-fbsd-nat.c: Fix common/ includes.
8027         * guile/scm-type.c: Fix common/ includes.
8028         * guile/guile.c: Fix common/ includes.
8029         * go32-nat.c: Fix common/ includes.
8030         * gnu-nat.c: Fix common/ includes.
8031         * gdbthread.h: Fix common/ includes.
8032         * gdbarch-selftests.c: Fix common/ includes.
8033         * gdb_usleep.c: Fix common/ includes.
8034         * gdb_select.h: Fix common/ includes.
8035         * gdb_bfd.c: Fix common/ includes.
8036         * gcore.c: Fix common/ includes.
8037         * fork-child.c: Fix common/ includes.
8038         * findvar.c: Fix common/ includes.
8039         * fbsd-nat.c: Fix common/ includes.
8040         * event-top.c: Fix common/ includes.
8041         * event-loop.c: Fix common/ includes.
8042         * dwarf2read.c: Fix common/ includes.
8043         * dwarf2loc.c: Fix common/ includes.
8044         * dwarf2-frame.c: Fix common/ includes.
8045         * dwarf-index-cache.c: Fix common/ includes.
8046         * dtrace-probe.c: Fix common/ includes.
8047         * disasm-selftests.c: Fix common/ includes.
8048         * defs.h: Fix common/ includes.
8049         * csky-tdep.c: Fix common/ includes.
8050         * cp-valprint.c: Fix common/ includes.
8051         * cp-support.h: Fix common/ includes.
8052         * cp-support.c: Fix common/ includes.
8053         * corelow.c: Fix common/ includes.
8054         * completer.h: Fix common/ includes.
8055         * completer.c: Fix common/ includes.
8056         * compile/compile.c: Fix common/ includes.
8057         * compile/compile-loc2c.c: Fix common/ includes.
8058         * compile/compile-cplus-types.c: Fix common/ includes.
8059         * compile/compile-cplus-symbols.c: Fix common/ includes.
8060         * command.h: Fix common/ includes.
8061         * cli/cli-dump.c: Fix common/ includes.
8062         * cli/cli-cmds.c: Fix common/ includes.
8063         * charset.c: Fix common/ includes.
8064         * build-id.c: Fix common/ includes.
8065         * btrace.h: Fix common/ includes.
8066         * btrace.c: Fix common/ includes.
8067         * breakpoint.h: Fix common/ includes.
8068         * breakpoint.c: Fix common/ includes.
8069         * ax.h:
8070         (enum agent_op): Fix common/ includes.
8071         * ax-general.c (struct aop_map): Fix common/ includes.
8072         * ax-gdb.c: Fix common/ includes.
8073         * auxv.c: Fix common/ includes.
8074         * auto-load.c: Fix common/ includes.
8075         * arm-tdep.c: Fix common/ includes.
8076         * arch/riscv.c: Fix common/ includes.
8077         * arch/ppc-linux-common.c: Fix common/ includes.
8078         * arch/i386.c: Fix common/ includes.
8079         * arch/arm.c: Fix common/ includes.
8080         * arch/arm-linux.c: Fix common/ includes.
8081         * arch/arm-get-next-pcs.c: Fix common/ includes.
8082         * arch/amd64.c: Fix common/ includes.
8083         * arch/aarch64.c: Fix common/ includes.
8084         * arch/aarch64-insn.c: Fix common/ includes.
8085         * arch-utils.c: Fix common/ includes.
8086         * amd64-windows-tdep.c: Fix common/ includes.
8087         * amd64-tdep.c: Fix common/ includes.
8088         * amd64-sol2-tdep.c: Fix common/ includes.
8089         * amd64-obsd-tdep.c: Fix common/ includes.
8090         * amd64-nbsd-tdep.c: Fix common/ includes.
8091         * amd64-linux-tdep.c: Fix common/ includes.
8092         * amd64-linux-nat.c: Fix common/ includes.
8093         * amd64-fbsd-tdep.c: Fix common/ includes.
8094         * amd64-fbsd-nat.c: Fix common/ includes.
8095         * amd64-dicos-tdep.c: Fix common/ includes.
8096         * amd64-darwin-tdep.c: Fix common/ includes.
8097         * agent.c: Fix common/ includes.
8098         * ada-lang.h: Fix common/ includes.
8099         * ada-lang.c: Fix common/ includes.
8100         * aarch64-tdep.c: Fix common/ includes.
8101
8102 2019-01-25  Tom Tromey  <tom@tromey.com>
8103
8104         * common/create-version.sh: Use common/version.h.
8105
8106 2019-01-24  Pedro Alves  <palves@redhat.com>
8107
8108         * infrun.c (signal_stop, signal_print, signal_program)
8109         (signal_catch, signal_pass): Now arrays instead of pointers.
8110         (update_signals_program_target, do_target_resume)
8111         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8112         * linux-nat.c (linux_nat_target::pass_signals)
8113         (linux_nat_target::create_inferior, linux_nat_target::attach):
8114         Adjust.
8115         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8116         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8117         * procfs.c (procfs_target::pass_signals): Adjust.
8118         * record-full.c (record_full_target::resume): Adjust.
8119         * remote.c (remote_target::pass_signals)
8120         (remote_target::program_signals): Adjust.
8121         * target-debug.h (target_debug_print_signals): Now takes a
8122         gdb::array_view as parameter.  Adjust.
8123         * target.h (target_ops) <pass_signals, program_signals>: Replace
8124         pointer and length parameters with gdb::array_view.
8125         (target_pass_signals, target_program_signals): Likewise.
8126         * target-delegates.c: Regenerate.
8127
8128 2019-01-24  Pedro Alves  <palves@redhat.com>
8129
8130         * common/forward-scope-exit.h
8131         (forward_scope_exit::forward_scope_exit): Pass arguments to
8132         m_bind_function directly, instead of creating a std::bind and
8133         copying that.
8134
8135 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8136
8137         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8138         for static members.
8139         (pass_in_v_vfp_candidate): Likewise.
8140
8141 2019-01-23  Tom Tromey  <tom@tromey.com>
8142             Pedro Alves  <palves@redhat.com>
8143
8144         * regcache.c (class regcache_invalidator): Remove.
8145         (regcache::raw_write): Use make_scope_exit.
8146
8147 2019-01-23  Tom Tromey  <tom@tromey.com>
8148
8149         * ui-out.h (class ui_out_emit_type): Update comment.
8150
8151 2019-01-23  Tom Tromey  <tom@tromey.com>
8152
8153         * infrun.c (fetch_inferior_event): Update comment.
8154
8155 2019-01-23  Tom Tromey  <tom@tromey.com>
8156             Pedro Alves  <palves@redhat.com>
8157
8158         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8159         parameter.
8160         (fetch_inferior_event): Use SCOPE_EXIT.
8161
8162
8163 2019-01-23  Tom Tromey  <tom@tromey.com>
8164             Pedro Alves  <palves@redhat.com>
8165
8166         * infrun.c (disable_thread_events): Delete.
8167         (stop_all_threads): Use SCOPE_EXIT.
8168
8169 2019-01-23  Tom Tromey  <tom@tromey.com>
8170             Pedro Alves  <palves@redhat.com>
8171
8172         * symfile.c: Include forward-scope-exit.h.
8173         (clear_symtab_users_cleanup): Replace forward declaration with
8174         a FORWARD_SCOPE_EXIT.
8175         (syms_from_objfile_1): Use the forward_scope_exit and
8176         gdb::optional instead of cleanup_function.
8177         (reread_symbols): Use the forward_scope_exit instead of
8178         cleanup_function.
8179         (clear_symtab_users_cleanup): Remove function.
8180
8181 2019-01-23  Tom Tromey  <tom@tromey.com>
8182             Pedro Alves  <palves@redhat.com>
8183
8184         * linux-nat.c: Include scope-exit.h.
8185         (cleanup_target_stop): Remove.
8186         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8187         SCOPE_EXIT.
8188
8189 2019-01-23  Tom Tromey  <tom@tromey.com>
8190             Pedro Alves  <palves@redhat.com>
8191
8192         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8193         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8194
8195 2019-01-23  Tom Tromey  <tom@tromey.com>
8196             Andrew Burgess  <andrew.burgess@embecosm.com>
8197             Pedro Alves  <palves@redhat.com>
8198
8199         * infrun.c (fetch_inferior_event): Use scope_exit.
8200         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8201         * top.c (execute_command): Use scope_exit.
8202         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8203         * utils.c (do_bpstat_clear_actions_cleanup)
8204         (make_bpstat_clear_actions_cleanup): Remove.
8205
8206 2019-01-23  Tom Tromey  <tom@tromey.com>
8207             Pedro Alves  <palves@redhat.com>
8208
8209         * infrun.c: Include "common/scope-exit.h"
8210         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8211         (wait_for_inferior): Use SCOPE_EXIT.
8212         (fetch_inferior_event): Use scope_exit.
8213
8214 2019-01-23  Tom Tromey  <tom@tromey.com>
8215             Pedro Alves  <palves@redhat.com>
8216
8217         * breakpoint.c (create_breakpoint): Remove cleanup.
8218
8219 2019-01-23  Tom Tromey  <tom@tromey.com>
8220             Andrew Burgess  <andrew.burgess@embecosm.com>
8221             Pedro Alves  <palves@redhat.com>
8222
8223 2019-01-23  Pedro Alves  <palves@redhat.com>
8224
8225         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8226
8227 2019-01-23  Pedro Alves  <palves@redhat.com>
8228             Andrew Burgess  <andrew.burgess@embecosm.com>
8229
8230         * gdbthread.h: Include "common/forward-scope-exit.h".
8231         (scoped_finish_thread_state): Redefine custom class in terms of
8232         forward_scope_exit.
8233
8234 2019-01-23  Pedro Alves  <palves@redhat.com>
8235             Andrew Burgess  <andrew.burgess@embecosm.com>
8236
8237         * common/forward-scope-exit.h: New file.
8238
8239 2019-01-23  Pedro Alves  <palves@redhat.com>
8240             Andrew Burgess  <andrew.burgess@embecosm.com>
8241             Tom Tromey  <tom@tromey.com>
8242
8243         * common/scope-exit.h: New file.
8244
8245 2019-01-23  Pedro Alves  <palves@redhat.com>
8246
8247         * common/preprocessor.h (ESC): Rename to ...
8248         (ESC_PARENS): ... this.
8249         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8250         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8251
8252 2019-01-23  Tom Tromey  <tom@tromey.com>
8253
8254         * language.h (class scoped_switch_to_sym_language_if_auto):
8255         Initialize m_lang in both cases.
8256
8257 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8258
8259         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8260         with XCNEW.
8261
8262 2019-01-22  Tom Tromey  <tom@tromey.com>
8263
8264         * corelow.c: Do not include sys/file.h.
8265
8266 2019-01-22  Tom Tromey  <tom@tromey.com>
8267
8268         * tui/tui-wingeneral.h: Include gdb_curses.h.
8269
8270 2019-01-22  Tom Tromey  <tom@tromey.com>
8271
8272         * source-cache.h (class source_cache) <get_source_lines,
8273         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8274
8275 2019-01-22  Tom Tromey  <tom@tromey.com>
8276
8277         * remote-fileio.h (struct remote_target): Declare.
8278
8279 2019-01-22  Tom Tromey  <tom@tromey.com>
8280
8281         * python/py-arch.c: Do not include py-ref.h.
8282         * python/py-bpevent.c: Do not include py-ref.h.
8283         * python/py-cmd.c: Do not include py-ref.h.
8284         * python/py-continueevent.c: Do not include py-ref.h.
8285         * python/py-event.h: Do not include py-ref.h.
8286         * python/py-evtregistry.c: Do not include py-ref.h.
8287         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8288         * python/py-frame.c: Do not include py-ref.h.
8289         * python/py-framefilter.c: Do not include py-ref.h.
8290         * python/py-function.c: Do not include py-ref.h.
8291         * python/py-infevents.c: Do not include py-ref.h.
8292         * python/py-linetable.c: Do not include py-ref.h.
8293         * python/py-objfile.c: Do not include py-ref.h.
8294         * python/py-param.c: Do not include py-ref.h.
8295         * python/py-prettyprint.c: Do not include py-ref.h.
8296         * python/py-progspace.c: Do not include py-ref.h.
8297         * python/py-symbol.c: Do not include py-ref.h.
8298         * python/py-symtab.c: Do not include py-ref.h.
8299         * python/py-type.c: Do not include py-ref.h.
8300         * python/py-unwind.c: Do not include py-ref.h.
8301         * python/py-utils.c: Do not include py-ref.h.
8302         * python/py-value.c: Do not include py-ref.h.
8303         * python/py-varobj.c: Do not include py-ref.h.
8304         * python/py-xmethods.c: Do not include py-ref.h.
8305         * python/python.c: Do not include py-ref.h.
8306         * varobj.c: Do not include py-ref.h.
8307
8308 2019-01-22  Tom Tromey  <tom@tromey.com>
8309
8310         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8311         keyword for bcache.
8312
8313 2019-01-22  Tom Tromey  <tom@tromey.com>
8314
8315         * compile/compile-cplus-types.c: Remove a comment by #include.
8316
8317 2019-01-22  Tom Tromey  <tom@tromey.com>
8318
8319         * compile/gcc-c-plugin.h: Include compile-internal.h.
8320
8321 2019-01-22  Tom Tromey  <tom@tromey.com>
8322
8323         * stabsread.c (EXTERN): Do not define.
8324         (symnum, next_symbol_text_func, processing_gcc_compilation)
8325         (within_function, global_sym_chain, global_stabs)
8326         (previous_stab_code, this_object_header_files)
8327         (n_this_object_header_files)
8328         (n_allocated_this_object_header_files): Define.
8329         * stabsread.h (EXTERN): Never define.  Use "extern".
8330
8331 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8332
8333         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8334         history_value.
8335
8336 2019-01-21  Tom Tromey  <tom@tromey.com>
8337
8338         * ui-out.c: Fix includes.
8339         * tui/tui-source.c: Fix includes.
8340         * target.c: Fix includes.
8341         * remote.c: Fix includes.
8342         * regcache.c: Fix includes.
8343         * python/py-block.c: Fix includes.
8344         * printcmd.c: Fix includes.
8345         * or1k-tdep.c: Fix includes.
8346         * mi/mi-main.c: Fix includes.
8347         * m32r-tdep.c: Fix includes.
8348         * csky-tdep.c: Fix includes.
8349         * compile/compile-cplus-types.c: Fix includes.
8350         * cli/cli-interp.c: Fix includes.
8351
8352 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8353
8354         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8355         for padding.
8356
8357 2019-01-16  Tom Tromey  <tom@tromey.com>
8358
8359         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8360         earlier.
8361         (struct objfile) <msymbols_range>: Move from top level.
8362         <msymbols>: New method.
8363         (class objfile_msymbols): Remove.
8364         * symtab.c (default_collect_symbol_completion_matches_break_on):
8365         Update.
8366         * symmisc.c (dump_msymbols): Update.
8367         * stabsread.c (scan_file_globals): Update.
8368         * objc-lang.c (info_selectors_command, info_classes_command)
8369         (find_methods): Update.
8370         * minsyms.c (find_solib_trampoline_target): Update.
8371         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8372         * coffread.c (coff_symfile_read): Update.
8373         * ada-lang.c (ada_lookup_simple_minsym)
8374         (ada_collect_symbol_completion_matches): Update.
8375
8376 2019-01-16  Tom Tromey  <tom@tromey.com>
8377
8378         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8379         type.  Remove no-argument constructor.
8380         <iterator::operator++>: Simplify.
8381         <begin>: Update.
8382         <end>: Use minimal_symbol_count.
8383
8384 2019-01-16  Tom Tromey  <tom@tromey.com>
8385
8386         * objfiles.h (struct objfile) <psymtabs>: New method.
8387         (class objfile_psymtabs): Remove.
8388         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8389         typedef.
8390         <range>: New method.
8391         (require_partial_symbols): Change return type.
8392         * psymtab.c (require_partial_symbols)
8393         (psym_expand_symtabs_matching): Update.
8394         * mdebugread.c (parse_partial_symbols): Update.
8395         * dbxread.c (dbx_end_psymtab): Update.
8396
8397 2019-01-15  Tom Tromey  <tom@tromey.com>
8398
8399         * symtab.c (lookup_objfile_from_block)
8400         (lookup_symbol_in_objfile_symtabs)
8401         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8402         (find_line_symtab, info_sources_command)
8403         (default_collect_symbol_completion_matches_break_on)
8404         (make_source_files_completion_list): Update.
8405         * symmisc.c (print_objfile_statistics, dump_objfile)
8406         (maintenance_print_symbols, maintenance_info_symtabs)
8407         (maintenance_check_symtabs, maintenance_info_line_tables):
8408         Update.
8409         * source.c (select_source_symtab)
8410         (forget_cached_source_info_for_objfile): Update.
8411         * objfiles.h (class objfile_compunits): Remove.
8412         (struct objfile) <compunits_range>: New typedef.
8413         (compunits): New method.
8414         * objfiles.c (objfile_relocate1): Update.
8415         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8416         * maint.c (count_symtabs_and_blocks): Update.
8417         * linespec.c (iterate_over_all_matching_symtabs): Update.
8418         * cp-support.c (add_symbol_overload_list_qualified): Update.
8419         * coffread.c (coff_symtab_read): Update.
8420         * ada-lang.c (add_nonlocal_symbols)
8421         (ada_collect_symbol_completion_matches)
8422         (ada_add_global_exceptions): Update.
8423
8424 2019-01-15  Tom Tromey  <tom@tromey.com>
8425
8426         * progspace.h (program_space) <objfiles_safe_range>: New
8427         typedef.
8428         <objfiles_safe>: New method.
8429         * objfiles.h (class all_objfiles_safe): Remove.
8430         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8431         * jit.c (jit_inferior_exit_hook): Update.
8432
8433 2019-01-17  Tom Tromey  <tom@tromey.com>
8434
8435         * progspace.h (program_space) <objfiles_range>: New typedef.
8436         <objfiles>: New method.
8437         <objfiles_head>: Rename from objfiles.
8438         (object_files): Update.
8439         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8440         * guile/scm-pretty-print.c
8441         (ppscm_find_pretty_printer_from_objfiles): Update.
8442         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8443         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8444         Update.
8445         * python/py-progspace.c (pspy_get_objfiles): Update.
8446         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8447         Update.
8448         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8449         (objfpy_lookup_objfile_by_build_id): Update.
8450         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8451         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8452         Update.
8453         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8454         (expand_symtab_containing_pc, lookup_objfile_from_block)
8455         (lookup_static_symbol, basic_lookup_transparent_type)
8456         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8457         (find_line_symtab, info_sources_command)
8458         (default_collect_symbol_completion_matches_break_on)
8459         (make_source_files_completion_list, find_main_name): Update.
8460         * symmisc.c (print_symbol_bcache_statistics)
8461         (print_objfile_statistics, maintenance_print_symbols)
8462         (maintenance_print_msymbols, maintenance_print_objfiles)
8463         (maintenance_info_symtabs, maintenance_check_symtabs)
8464         (maintenance_expand_symtabs, maintenance_info_line_tables):
8465         Update.
8466         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8467         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8468         (map_overlay_command, unmap_overlay_command)
8469         (simple_overlay_update, expand_symtabs_matching)
8470         (map_symbol_filenames): Update.
8471         * symfile-debug.c (set_debug_symfile): Update.
8472         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8473         Update.
8474         * source.c (select_source_symtab, forget_cached_source_info):
8475         Update.
8476         * solib.c (solib_read_symbols): Update.
8477         * solib-spu.c (append_ocl_sos): Update.
8478         * psymtab.c (maintenance_print_psymbols)
8479         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8480         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8481         * printcmd.c (info_symbol_command): Update.
8482         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8483         Update.
8484         * objfiles.h (class all_objfiles): Remove.
8485         * objfiles.c (have_partial_symbols, have_full_symbols)
8486         (have_minimal_symbols, qsort_cmp, update_section_map)
8487         (shared_objfile_contains_address_p)
8488         (default_iterate_over_objfiles_in_search_order): Update.
8489         * objc-lang.c (info_selectors_command, info_classes_command)
8490         (find_methods): Update.
8491         * minsyms.c (find_solib_trampoline_target): Update.
8492         * maint.c (maintenance_info_sections)
8493         (maintenance_translate_address, count_symtabs_and_blocks):
8494         Update.
8495         * main.c (captured_main_1): Update.
8496         * linux-thread-db.c (try_thread_db_load_from_pdir)
8497         (has_libpthread): Update.
8498         * linespec.c (iterate_over_all_matching_symtabs)
8499         (search_minsyms_for_name): Update.
8500         * jit.c (jit_find_objf_with_entry_addr): Update.
8501         * hppa-tdep.c (find_unwind_entry)
8502         (hppa_lookup_stub_minimal_symbol): Update.
8503         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8504         Update.
8505         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8506         (elf_gnu_ifunc_resolve_by_got): Update.
8507         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8508         * dwarf-index-write.c (save_gdb_index_command): Update.
8509         * cp-support.c (add_symbol_overload_list_qualified): Update.
8510         * breakpoint.c (create_overlay_event_breakpoint)
8511         (create_longjmp_master_breakpoint)
8512         (create_std_terminate_master_breakpoint)
8513         (create_exception_master_breakpoint): Update.
8514         * blockframe.c (find_pc_partial_function): Update.
8515         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8516         (ada_collect_symbol_completion_matches)
8517         (ada_add_global_exceptions): Update.
8518
8519 2019-01-17  Tom Tromey  <tom@tromey.com>
8520
8521         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8522         declare VEC.
8523         (solib_target_parse_libraries): Change return type.
8524         (library_list_start_segment, library_list_start_section)
8525         (library_list_end_library, library_list_start_library); Update.
8526         (solib_target_free_library_list): Remove.
8527         (solib_target_parse_libraries): Remove cleanup.  Change return
8528         type.
8529         (solib_target_current_sos): Update.
8530
8531 2019-01-17  Tom Tromey  <tromey@bapiya>
8532
8533         * valprint.c: Replace "the the" with "the".
8534         * symtab.c: Replace "the the" with "the".
8535         * solib.c: Replace "the the" with "the".
8536         * solib-dsbt.c: Replace "the the" with "the".
8537         * linespec.c: Replace "the the" with "the".
8538         * dwarf2loc.h: Replace "the the" with "the".
8539         * amd64-windows-tdep.c: Replace "the the" with "the".
8540         * aarch64-tdep.c: Replace "the the" with "the".
8541
8542 2019-01-16  Keith Seitz  <keiths@redhat.com>
8543
8544         PR gdb/23773
8545         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8546         <builder>: Rename to ..
8547         <m_builder>: ... this and make private.
8548         (dwarf2_cu::get_builder): New method.  Change all users of
8549         `builder' to use this method.
8550         (dwarf2_start_symtab): Move to ...
8551         (dwarf2_cu::start_symtab): ... here.  Update all callers
8552         (setup_type_unit_groups): Move to ...
8553         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8554         callers.
8555         (dwarf2_cu::reset_builder): New method.
8556         (process_full_compunit, process_full_type_unit): Use
8557         dwarf2_cu::reset_builder.
8558         (follow_die_offset): Record the ancestor CU if it is different
8559         from the followed DIE's CU.
8560         (follow_die_sig_1): Likewise.
8561
8562 2019-01-15  Tom Tromey  <tom@tromey.com>
8563
8564         * remote.c (class remote_state) <buf>: Now a char_vector.
8565         <buf_size>: Remove.
8566         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8567         parameter.
8568         (remote_target::getpkt_or_notif_sane_1)
8569         (remote_target::getpkt_sane)
8570         (remote_target::getpkt_or_notif_sane): Likewise.
8571         (class remote_target) <putpkt>: New overload.
8572         (remote_target::read_frame): Change type of "buf_p".  Remove
8573         sizeof_p parameter.
8574         (packet_ok): New overload.
8575         (packet_check_result): New overload.
8576         Update all uses.
8577
8578 2019-01-14  Tom Tromey  <tom@tromey.com>
8579
8580         * remote-notif.c (handle_notification, remote_notif_ack)
8581         (remote_notif_parse): Make "buf" const.
8582         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8583         const.
8584         (remote_notif_parse, remote_notif_ack, handle_notification):
8585         Likewise.
8586         * remote.c (remote_notif_stop_parse): Make "buf" const.
8587         (remote_target::remote_parse_stop_reply): Make "buf" const.
8588         (remote_notif_stop_ack): Make "buf" const.
8589
8590 2019-01-14  Tom Tromey  <tom@tromey.com>
8591
8592         * remote.c (remote_console_output): Make parameter const.
8593
8594 2019-01-14  Tom Tromey  <tom@tromey.com>
8595
8596         * target-debug.h (target_debug_print_signals): Constify.
8597         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8598         * procfs.c (procfs_target::pass_signals): Update.
8599         * linux-nat.c (linux_nat_target::pass_signals): Update.
8600         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8601         * target-delegates.c: Rebuild.
8602         * remote.c (remote_target::program_signals): Update.
8603         (remote_target::pass_signals): Update.
8604         * target.c (target_pass_signals): Constify argument.
8605         (target_program_signals): Likewise.
8606         * target.h (struct target_ops) <pass_signals, program_signals>:
8607         Constify argument.
8608         (target_pass_signals, target_program_signals): Constify argument.
8609
8610 2019-01-14  Tom Tromey  <tom@tromey.com>
8611
8612         PR tui/28819:
8613         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8614
8615 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8616
8617         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8618         field.
8619         * rs6000-tdep.c: Include reggroups.h.
8620         (IS_V_ALIAS_PSEUDOREG): Define.
8621         (rs6000_register_name): Return names for the "vX" aliases.
8622         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8623         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8624         aliases.  Call default_register_reggroup_p for all other
8625         pseudo-registers.
8626         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8627         New functions.
8628         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8629         Handle "vX" aliases.
8630         (v_alias_pseudo_register_collect): New function.
8631         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8632         (rs6000_gdbarch_init): Initialize "vX" aliases as
8633         pseudo-registers.  Restore registration of
8634         rs6000_pseudo_register_reggroup_p with
8635         set_tdesc_pseudo_register_reggroup_p.
8636
8637 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8638
8639         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8640         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8641         set_gdbarch_num_pseudo_regs.
8642
8643 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8644
8645         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8646         Remove arg prefixname, add do_set and do_show.
8647         Add member functions set_list and show_list.
8648         * cli/cli-style.c (class cli_style_option): Update accordingly.
8649         (style_set_list): Move to file scope.
8650         (style_show_list): Likewise.
8651         (set_style): Call help_list.
8652         (show_style): Call cmd_show_list.
8653         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8654         Update to use the new macro.
8655
8656 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8657
8658         * ada-lang.c (_initialize_ada_language): Expand the help text
8659         for the "catch exception" command.
8660
8661 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8662
8663         * symtab.c (matching_obj_sections): Initialize obj,
8664         declare it closer to its usage.
8665
8666 2019-01-10  Tom Tromey  <tom@tromey.com>
8667
8668         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8669         (basic_inf_threads_range): Remove.
8670         (inf_threads_range, inf_non_exited_threads_range)
8671         (safe_inf_threads_range): Use next_adapter.
8672
8673 2019-01-10  Keith Seitz  <keiths@redhat.com>
8674
8675         PR gdb/23712
8676         PR symtab/23010
8677         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8678         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8679
8680 2019-01-10  Keith Seitz  <keiths@redhat.com>
8681
8682         PR gdb/23712
8683         PR symtab/23010
8684         * dictionary.c (pending_to_vector): Remove.
8685         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8686         Remove _1 suffix, replacing functions of the same name.  Update
8687         all callers.
8688         (dict_create_hashed, dict_create_hashed_expandable)
8689         (dict_create_linear, dict_create_linear_expandable, dict_free)
8690         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8691         Make functions static.
8692
8693 2019-01-10  Keith Seitz  <keiths@redhat.com>
8694
8695         PR gdb/23712
8696         PR symtab/23010
8697         * dictionary.h (struct dictionary): Replace declaration with
8698         multidictionary.
8699         (dict_create_hashed, dict_create_hashed_expandable)
8700         (dict_create_linear, dict_create_linear_expandable)
8701         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8702         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8703         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8704         taking multidictionary argument.
8705         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8706         * block.h (struct block) <dict>: Change to multidictionary
8707         and rename `multidict'.
8708         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8709         symmisc.c: Update all dictionary references to multidictionary.
8710
8711 2019-01-10  Keith Seitz  <keiths@redhat.com>
8712
8713         PR gdb/23712
8714         PR symtab/23010
8715         * dictionary.c: Include unordered_map.
8716         (pending_to_vector): New function.
8717         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8718         Rewrite the non-"_1" functions to take vector instead
8719         of linked list.
8720         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8721         "new" _1 versions of the same name.
8722         (multidictionary): Define.
8723         (std::hash<enum language): New definition.
8724         (collate_pending_symbols_by_language, mdict_create_hashed)
8725         (mdict_create_hashed_expandable, mdict_create_linear)
8726         (mdict_create_linear_expandable, mdict_free)
8727         (find_language_dictionary, create_new_language_dictionary)
8728         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8729         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8730         (mdict_size, mdict_empty): New functions.
8731         * dictionary.h (mdict_iterator): Define.
8732
8733 2019-01-10  Pedro Alves  <palves@redhat.com>
8734
8735         * breakpoint.c (read_uploaded_action)
8736         (create_tracepoint_from_upload): Adjust to use
8737         gdb::unique_xmalloc_ptr.
8738         * ctf.c (ctf_write_uploaded_tp):
8739         (SET_ARRAY_FIELD): Use emplace_back.
8740         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8741         * tracefile-tfile.c (tfile_write_uploaded_tp):
8742         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8743         gdb::unique_xmalloc_ptr.
8744         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8745         at_string, cond_string, cmd_strings>: Replace char pointers
8746         with gdb::unique_xmalloc_ptr.
8747
8748 2019-01-10  Pedro Alves  <palves@redhat.com>
8749
8750         * solib-target.c (library_list_start_library): Don't xstrdup name.
8751
8752 2019-01-10  Pedro Alves  <palves@redhat.com>
8753
8754         * mdebugread.c (parse_partial_symbols): Use
8755         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8756
8757 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8758
8759         * linux-fork.c (scoped_switch_fork_info)
8760         <~scoped_switch_fork_info>: Fix incorrect variable name.
8761
8762 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8763
8764         * linux-fork.c (scoped_switch_fork_info)
8765         <scoped_switch_fork_info>: Make explicit.
8766         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8767
8768 2019-01-10  Tom Tromey  <tom@tromey.com>
8769
8770         * objfiles.h (objfile::reset_psymtabs): Update.
8771         * objfiles.c (objfile::objfile): Update.
8772         * psymtab.h (psymtab_storage::obstack): Update.
8773         (psymtab_storage::m_obstack): Use gdb::optional.
8774         (class psymtab_storage): Update comment.  Remove objfile
8775         parameter.
8776         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8777
8778 2019-01-10  Tom Tromey  <tom@tromey.com>
8779
8780         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8781         <free_psymtabs>: Now private.
8782         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8783         (allocate_psymtab): Use new method.
8784
8785 2019-01-10  Tom Tromey  <tom@tromey.com>
8786
8787         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8788         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8789         * mdebugread.c (parse_partial_symbols): Use
8790         allocate_dependencies.
8791         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8792         allocate_dependencies.
8793         (process_psymtab_comp_unit_reader)
8794         (build_type_psymtab_dependencies): Likewise.
8795         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8796
8797 2019-01-10  Tom Tromey  <tom@tromey.com>
8798
8799         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8800         PSYMBOL_SET_LANGUAGE.
8801         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8802
8803 2019-01-10  Tom Tromey  <tom@tromey.com>
8804
8805         * psymtab.h (psymtab_storage::obstack): New method.
8806         <m_obstack>: Rename from obstack; now private.
8807         * psymtab.c (psymtab_storage): Update.
8808         * dwarf2read.c (create_addrmap_from_index)
8809         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8810         Update.
8811
8812 2019-01-10  Tom Tromey  <tom@tromey.com>
8813
8814         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8815         * objfiles.h (objfile::reset_psymtabs): New method.
8816
8817 2019-01-10  Tom Tromey  <tom@tromey.com>
8818
8819         * symmisc.c (print_symbol_bcache_statistics): Update.
8820         (print_objfile_statistics): Update.
8821         * symfile.c (reread_symbols): Update.
8822         * psymtab.h (class psymtab_storage): New.
8823         * psymtab.c (psymtab_storage): New constructor.
8824         (~psymtab_storage): New destructor.
8825         (require_partial_symbols): Update.
8826         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8827         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8828         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8829         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8830         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8831         (start_psymtab_common, end_psymtab_common)
8832         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8833         (allocate_psymtab): Update.
8834         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8835         Update.
8836         (dump_psymtab_addrmap, maintenance_print_psymbols)
8837         (maintenance_check_psymtabs): Update.
8838         (class objfile_psymtabs): Move to objfiles.h.
8839         * psympriv.h (discard_psymtab): Now inline.
8840         (psymtab_discarder::psymtab_discarder): Update.
8841         (psymtab_discarder::~psymtab_discarder): Update.
8842         (ALL_OBJFILE_PSYMTABS): Rewrite.
8843         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8844         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8845         Remove fields.
8846         <partial_symtabs>: New field.
8847         (class objfile_psymtabs): Move from psymtab.h.  Update.
8848         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8849         psymbol_cache.
8850         (objfile::~objfile): Don't destroy psymbol_cache.
8851         * mdebugread.c (parse_partial_symbols): Update.
8852         * dwarf2read.c (create_addrmap_from_index)
8853         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8854         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8855         (add_partial_subprogram, dwarf2_ranges_read): Update.
8856         * dwarf-index-write.c (write_address_map)
8857         (write_one_signatured_type, recursively_write_psymbols)
8858         (class debug_names, class debug_names, write_psymtabs_to_index):
8859         Update.
8860
8861 2019-01-10  Tom Tromey  <tom@tromey.com>
8862
8863         * symtab.h (SYMBOL_SET_NAMES): Update.
8864         (symbol_set_names): Update.
8865         (MSYMBOL_SET_NAMES): Update.
8866         * symtab.c (symbol_set_names): Change argument to be an
8867         objfile_per_bfd_storage.
8868         * psymtab.c (add_psymbol_to_bcache): Update.
8869         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8870
8871 2019-01-10  Tom Tromey  <tom@tromey.com>
8872
8873         * symtab.c (create_demangled_names_hash): Change argument to be an
8874         objfile_per_bfd_storage.
8875         (symbol_set_names): Update.
8876
8877 2019-01-10  Tom Tromey  <tom@tromey.com>
8878
8879         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8880         init_psymbol_list.
8881         * psymtab.c (init_psymbol_list): Do nothing if already called.
8882         * psympriv.h (init_psymbol_list): Add comment.
8883         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8884         init_psymbol_list.
8885         * dbxread.c (dbx_symfile_read): Unconditionally call
8886         init_psymbol_list.
8887
8888 2019-01-10  Tom Tromey  <tom@tromey.com>
8889
8890         * xcoffread.c (scan_xcoff_symtab): Update.
8891         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8892         "where".
8893         * mdebugread.c (parse_partial_symbols)
8894         (handle_psymbol_enumerators): Update.
8895         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8896         * dbxread.c (read_dbx_symtab): Update.
8897         * psympriv.h (psymbol_placement): New enum.
8898         (add_psymbol_to_list): Update.
8899
8900 2019-01-10  Tom Tromey  <tom@tromey.com>
8901
8902         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8903         static_psymbols parameters.
8904         (scan_xcoff_symtab): Update.
8905         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8906         static_psymbols parameters.
8907         * psympriv.h (start_psymtab_common): Update.
8908         * mdebugread.c (parse_partial_symbols): Update.
8909         * dwarf2read.c (create_partial_symtab): Update.
8910         * dbxread.c (read_dbx_symtab): Update.
8911         (start_psymtab): Remove global_psymbols and static_psymbols
8912         parameters.
8913
8914 2019-01-10  Tom Tromey  <tom@tromey.com>
8915
8916         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8917         * psymtab.c (allocate_psymtab): Add comment.
8918         * psympriv.h (allocate_psymtab): Add comment.
8919         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8920         initializations.
8921         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8922
8923 2019-01-10  Tom Tromey  <tom@tromey.com>
8924
8925         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8926         Don't declare.
8927         * mipsread.c: Include mdebugread.h.
8928         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8929         Declare.
8930         * elfread.c: Include mdebugread.h.
8931
8932 2019-01-09  Tom Tromey  <tom@tromey.com>
8933
8934         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8935         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8936         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8937         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8938         (psym_lookup_symbol, psym_find_last_source_symtab)
8939         (psym_forget_cached_source_info, psym_print_stats)
8940         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8941         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8942         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8943         (psym_find_compunit_symtab_by_address)
8944         (maintenance_print_psymbols, maintenance_info_psymtabs)
8945         (maintenance_check_psymtabs): Use ranged for.
8946         * psymtab.h (class objfile_psymtabs): New.
8947         (require_partial_symbols): Return objfile_psymtabs.
8948         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8949
8950 2019-01-09  Tom Tromey  <tom@tromey.com>
8951
8952         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8953         (find_pc_mapped_section, list_overlays_command)
8954         (map_overlay_command, unmap_overlay_command)
8955         (simple_overlay_update): Use all_objfiles.
8956         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8957         * printcmd.c (info_symbol_command): Use all_objfiles.
8958         * objfiles.h (ALL_OBJSECTIONS): Remove.
8959         * maint.c (maintenance_translate_address): Use all_objfiles.
8960         * gcore.c (gcore_create_callback): Use all_objfiles.
8961         (objfile_find_memory_regions): Likewise.
8962
8963 2019-01-09  Tom Tromey  <tom@tromey.com>
8964
8965         * symtab.c (find_line_symtab, info_sources_command)
8966         (make_source_files_completion_list): Use objfile_compunits.
8967         * source.c (select_source_symtab): Use objfile_compunits.
8968         * objfiles.h (struct objfile): Update comment.
8969         (ALL_OBJFILES): Remove.
8970         (ALL_FILETABS): Remove.
8971         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8972         objfile_compunits.
8973
8974 2019-01-09  Tom Tromey  <tom@tromey.com>
8975
8976         * symmisc.c (print_objfile_statistics, dump_objfile)
8977         (maintenance_print_symbols): Use compunit_filetabs.
8978         * source.c (forget_cached_source_info_for_objfile): Use
8979         compunit_filetabs.
8980         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8981         (ALL_FILETABS): Use compunit_filetabs.
8982         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8983         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8984
8985 2019-01-09  Tom Tromey  <tom@tromey.com>
8986
8987         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8988         (compunit_filetabs): New.
8989         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8990         compunit_filetabs.
8991         (info_sources_command, make_source_files_completion_list): Remove
8992         declaration.
8993         * symmisc.c (print_objfile_statistics, dump_objfile)
8994         (maintenance_print_symbols): Remove declaration.
8995         (maintenance_info_symtabs): Use compunit_filetabs.
8996         (maintenance_info_line_tables): Likewise.
8997         * source.c (select_source_symtab): Change local variable name.
8998         (forget_cached_source_info_for_objfile): Remove declaration.
8999         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9000         * objfiles.c (objfile_relocate1): Remove declaration.
9001         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9002         declaration.
9003         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9004         * coffread.c (coff_symtab_read): Remove declaration.
9005         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9006         compunit_filetabs.
9007
9008 2019-01-09  Tom Tromey  <tom@tromey.com>
9009
9010         * symtab.c (lookup_objfile_from_block)
9011         (find_pc_sect_compunit_symtab, search_symbols)
9012         (default_collect_symbol_completion_matches_break_on): Use
9013         objfile_compunits.
9014         * objfiles.h (ALL_COMPUNITS): Remove.
9015         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9016         * cp-support.c (add_symbol_overload_list_qualified): Use
9017         objfile_compunits.
9018         * ada-lang.c (ada_collect_symbol_completion_matches)
9019         (ada_add_global_exceptions): Use objfile_compunits.
9020
9021 2019-01-09  Tom Tromey  <tom@tromey.com>
9022
9023         * source.c (select_source_symtab)
9024         (forget_cached_source_info_for_objfile): Remove declaration.
9025         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9026         declaration.
9027         * maint.c (count_symtabs_and_blocks): Remove declaration.
9028         * cp-support.c (add_symbol_overload_list_qualified): Remove
9029         declaration.
9030         * coffread.c (coff_symtab_read): Remove declaration.
9031         * symtab.c (lookup_symbol_in_objfile_symtabs)
9032         (basic_lookup_transparent_type_1): Use objfile_compunits.
9033         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9034         (info_sources_command, search_symbols)
9035         (default_collect_symbol_completion_matches_break_on)
9036         (make_source_files_completion_list): Remove declaration.
9037         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9038         (ada_collect_symbol_completion_matches)
9039         (ada_add_global_exceptions): Remove declaration.
9040         * linespec.c (iterate_over_all_matching_symtabs): Use
9041         objfile_compunits.
9042         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9043         (class objfile_compunits): New.
9044         (ALL_COMPUNITS): Use objfile_compunits.
9045         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9046         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9047         objfile_compunits.
9048         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9049
9050 2019-01-09  Tom Tromey  <tom@tromey.com>
9051
9052         * symtab.c (search_symbols)
9053         (default_collect_symbol_completion_matches_break_on): Use
9054         objfile_msymbols.
9055         * ada-lang.c (ada_lookup_simple_minsym)
9056         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9057         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9058         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9059         objfile_msymbols.
9060         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9061         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9062         * objc-lang.c (find_methods): Use objfile_msymbols.
9063         (info_selectors_command, info_classes_command): Likewise.
9064         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9065         * objfiles.h (class objfile_msymbols): New.
9066         (ALL_OBJFILE_MSYMBOLS): Remove.
9067         (ALL_MSYMBOLS): Remove.
9068
9069 2019-01-09  Tom Tromey  <tom@tromey.com>
9070
9071         * common/next-iterator.h (next_adapter): Add Iterator template
9072         parameter.
9073         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9074         (class all_objfiles_safe): New.
9075         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9076         * objfiles.c (put_objfile_before): Update comment.
9077         (add_separate_debug_objfile): Likewise.
9078         (free_all_objfiles): Use all_objfiles_safe.
9079         (objfile_purge_solibs): Likewise.
9080
9081 2019-01-09  Tom Tromey  <tom@tromey.com>
9082
9083         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9084         (expand_symtab_containing_pc, lookup_static_symbol)
9085         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9086         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9087         all_objfiles.
9088         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9089         * breakpoint.c (create_overlay_event_breakpoint)
9090         (create_longjmp_master_breakpoint)
9091         (create_std_terminate_master_breakpoint)
9092         (create_exception_master_breakpoint): Use all_objfiles.
9093         * linux-thread-db.c (try_thread_db_load_from_pdir)
9094         (has_libpthread): Use all_objfiles.
9095         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9096         * linespec.c (iterate_over_all_matching_symtabs)
9097         (search_minsyms_for_name): Use all_objfiles.
9098         * maint.c (maintenance_info_sections): Use all_objfiles.
9099         * main.c (captured_main_1): Use all_objfiles.
9100         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9101         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9102         * guile/scm-pretty-print.c
9103         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9104         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9105         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9106         (maintenance_print_msymbols): Use all_objfiles.
9107         * source.c (select_source_symtab): Use all_objfiles.
9108         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9109         * symfile.c (remove_symbol_file_command)
9110         (expand_symtabs_matching, map_symbol_filenames): Use
9111         all_objfiles.
9112         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9113         all_objfiles.
9114         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9115         * objc-lang.c (find_methods): Use all_objfiles.
9116         * objfiles.c (have_partial_symbols, have_full_symbols)
9117         (have_minimal_symbols, qsort_cmp)
9118         (default_iterate_over_objfiles_in_search_order): Use
9119         all_objfiles.
9120         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9121         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9122         (maintenance_check_psymtabs): Use all_objfiles.
9123         (ALL_PSYMTABS): Remove.
9124         * compile/compile-object-run.c (do_module_cleanup): Use
9125         all_objfiles.
9126         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9127         * cp-support.c (add_symbol_overload_list_qualified): Use
9128         all_objfiles.
9129         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9130         Use all_objfiles.
9131         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9132         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9133         all_objfiles.
9134         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9135         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9136         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9137         Uses all_objfiles.
9138         * solib.c (solib_read_symbols): Use all_objfiles
9139
9140 2019-01-09  Tom Tromey  <tom@tromey.com>
9141
9142         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9143         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9144         all_objfiles.
9145         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9146         * symmisc.c (print_symbol_bcache_statistics)
9147         (print_objfile_statistics, maintenance_print_objfiles)
9148         (maintenance_info_symtabs, maintenance_check_symtabs)
9149         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9150         all_objfiles.
9151         * source.c (forget_cached_source_info): Use all_objfiles.
9152         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9153         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9154         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9155         * objfiles.c (update_section_map): Use all_objfiles.
9156         (shared_objfile_contains_address_p): Likewise.
9157         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9158         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9159
9160 2019-01-09  Tom Tromey  <tom@tromey.com>
9161
9162         * common/next-iterator.h: New file.
9163         * objfiles.h (class all_objfiles): New.
9164         (struct objfile_iterator): New.
9165
9166 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9167
9168         * NEWS: Move the description of the changed "frame", "select-frame",
9169          and "info frame" commands to the Changed commands section.
9170
9171 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9172
9173         * gdbtypes.c (check_stub_method_group): Remove handling of old
9174         mangling schemes.
9175         * linespec.c (find_methods): Likewise.
9176         * stabsread.c (read_member_functions): Likewise.
9177         * valops.c (search_struct_method): Likewise.
9178         (value_struct_elt_for_reference): Likewise.
9179         * NEWS: Mention this change.
9180
9181 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9182
9183         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9184         print_source_lines.
9185         * source.c (print_source_lines_base): Update line number check.
9186         (print_source_lines): New function.
9187         (source_lines_range::source_lines_range): New function.
9188         * source.h (class source_lines_range): New class.
9189         (print_source_lines): New declaration.
9190
9191 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9192
9193         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9194
9195 2019-01-08  Tom Tromey  <tom@tromey.com>
9196             Simon Marchi  <simon.marchi@ericsson.com>
9197
9198         PR gdb/24060
9199         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9200         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9201         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9202         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9203         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9204         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9205
9206 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9207
9208         * source.c (select_source_symtab): Move header comment to
9209         declaration in source.h.
9210         (forget_cached_source_info_for_objfile): Likewise.
9211         (forget_cached_source_info): Likewise.
9212         (identify_source_line): Likewise.
9213         * source.h (identify_source_line): Move declaration from symtab.h
9214         and add comment from source.c
9215         (print_source_lines): Likewise.
9216         (forget_cached_source_info_for_objfile): Likewise.
9217         (forget_cached_source_info): Likewise.
9218         (select_source_symtab): Likewise.
9219         (enum print_source_lines_flag): Move definition from symtab.h.
9220         * symtab.h (identify_source_line): Move declaration to source.h.
9221         (print_source_lines): Likewise.
9222         (forget_cached_source_info_for_objfile): Likewise.
9223         (forget_cached_source_info): Likewise.
9224         (select_source_symtab): Likewise.
9225         (enum print_source_lines_flag): Move definition to source.h.
9226         * tui/tui-hooks.c: Add 'source.h' include.
9227
9228 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * source.c (print_source_lines_base): Handle requests to print
9231         reverse line number sequences, and guard against empty lines
9232         string.
9233
9234 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9235
9236         * source.c (print_source_lines_base): Fix skip of '\r' if next
9237         character is '\n'.
9238
9239 2019-01-06  Tom Tromey  <tom@tromey.com>
9240
9241         * c-exp.y (struct c_parse_state) <macro_original_text,
9242         expansion_obstack>: New member.
9243         (macro_original_text, expansion_obstack): Remove globals.
9244         (scan_macro_expansion, scanning_macro_expansion)
9245         (finished_macro_expansion): Update.
9246         (scan_macro_cleanup): Remove.
9247         (yylex, c_parse): Update.
9248
9249 2019-01-06  Tom Tromey  <tom@tromey.com>
9250
9251         * c-exp.y (struct c_parse_state) <strings>: New member.
9252         (operator_stoken): Update.
9253
9254 2019-01-06  Tom Tromey  <tom@tromey.com>
9255
9256         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9257         (union type_stack_elt) <typelist_val>: Now a pointer to
9258         std::vector.
9259         (type_stack_cleanup): Don't declare.
9260         (push_typelist): Update.
9261         * parse.c (pop_typelist): Return a std::vector.
9262         (push_typelist): Take a std::vector.
9263         (follow_types): Update.  Do not free args.
9264         (type_stack_cleanup): Remove.
9265         * c-exp.y (struct c_parse_state): New.
9266         (cpstate): New global.
9267         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9268         (nonempty_typelist): Update.
9269         (func_mod): Create a new vector.
9270         (c_parse): Create a c_parse_state.
9271         (check_parameter_typelist): Do not delete params.
9272         (function_method): Update.  Do not delete type_list.
9273
9274 2019-01-06  Tom Tromey  <tom@tromey.com>
9275
9276         PR gdb/28155:
9277         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9278         check_typedef.
9279         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9280         (print_return_value): Likewise.
9281
9282 2019-01-05  Tom Tromey  <tom@tromey.com>
9283
9284         * contrib/cleanup_check.py: Remove.
9285         * contrib/gcc-with-excheck: Remove.
9286         * contrib/exsummary.py: Remove.
9287         * contrib/excheck.py: Remove.
9288
9289 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9290
9291         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9292         NULL. Initialize tpprev to NULL instead of assigning it
9293         to NULL on the next statement.
9294         * windows-nat.c (windows_delete_thread): Remove check for
9295         main_thread_id before printing thread exit notifications.
9296         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9297         Remove thread ID check against main_thread_id.
9298         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9299         windows_delete_thread.
9300         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9301
9302 2019-01-04  Tom Tromey  <tom@tromey.com>
9303
9304         * compile/compile.c (_initialize_compile): Use upper case for
9305         metasyntactic variables.
9306         * symmisc.c (_initialize_symmisc): Use upper case for
9307         metasyntactic variables.
9308         * psymtab.c (_initialize_psymtab): Use upper case for
9309         metasyntactic variables.
9310         * demangle.c (demangle_command): Use upper case for metasyntactic
9311         variables.
9312         (_initialize_demangler): Likewise.
9313         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9314         variables.
9315
9316 2019-01-03  Tom Tromey  <tom@tromey.com>
9317
9318         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9319
9320 2019-01-03  Tom Tromey  <tom@tromey.com>
9321
9322         * python/py-symtab.c (salpy_str): Update.
9323         (struct salpy_sal_object) <symtab>: Now a PyObject.
9324         (salpy_dealloc): Update.
9325         (del_objfile_sal): Use gdbpy_ref.
9326
9327 2019-01-03  Tom Tromey  <tom@tromey.com>
9328
9329         * python/py-type.c (convert_field): Use new_reference.  Return
9330         gdbpy_ref.
9331         (make_fielditem): Return gdbpy_ref.
9332         (typy_fields): Update.
9333         (typy_getitem): Update.
9334         (field_name): Return gdbpy_ref.  Use new_reference.
9335         (typy_iterator_iternext): Update.
9336
9337 2019-01-03  Tom Tromey  <tom@tromey.com>
9338
9339         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9340
9341 2019-01-03  Tom Tromey  <tom@tromey.com>
9342
9343         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9344         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9345         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9346         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9347         (pspy_set_type_printers): Likewise.
9348         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9349         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9350         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9351         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9352         (objfpy_set_type_printers): Likewise.
9353
9354 2019-01-03  Tom Tromey  <tom@tromey.com>
9355
9356         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9357         (gdbpy_print_stack): Use gdbpy_err_fetch.
9358         * python/python-internal.h (class gdbpy_err_fetch): New class.
9359         (class gdbpy_enter) <m_error_type, m_error_value,
9360         m_error_traceback>: Remove.
9361         <m_error>: New member.
9362         (gdbpy_exception_to_string): Don't declare.
9363         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9364         * python/py-value.c (convert_value_from_python): Use
9365         gdbpy_err_fetch.
9366         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9367         gdbpy_exception_to_string.
9368         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9369         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9370         gdbpy_err_fetch.
9371
9372 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * linux-nat.c (delete_lwp_cleanup): Delete.
9375         (struct lwp_deleter): New struct.
9376         (lwp_info_up): New typedef.
9377         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9378         lwp_info_up.
9379
9380 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9381
9382         * linux-fork.c (class scoped_switch_fork_info): New class.
9383         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9384
9385 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9386
9387         * valops.c (find_overload_match): Remove use of null_cleanup, and
9388         calls to do_cleanups.
9389
9390 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9391
9392         * compile/compile-cplus-types.c
9393         (compile_cplus_instance::decl_name): Handle changes to
9394         cp_func_name.
9395         * cp-support.c (cp_func_name): Update header comment, update
9396         return type.
9397         * cp-support.h (cp_func_name): Update return type in declaration.
9398         * valops.c (find_overload_match): Move temp_func local to top
9399         level of function and change its type.  Use temp_func to hold and
9400         delete temporary string obtained from cp_func_name.
9401
9402 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9403
9404         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9405         gdb::char_vector, remove cleanup, and update uses of `msg`.
9406
9407 2019-01-03  Jim Wilson  <jimw@sifive.com>
9408
9409         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9410
9411 2019-01-02  Tom Tromey  <tom@tromey.com>
9412
9413         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9414         (tdesc_parse_xml): Remove cleanups.
9415         * target-descriptions.h (make_cleanup_free_target_description):
9416         Don't declare.
9417         (target_desc_deleter): New struct.
9418         (target_desc_up): New typedef.
9419         * target-descriptions.c (target_desc_deleter::operator()): Rename
9420         from free_target_description.
9421         (make_cleanup_free_target_description): Remove.
9422
9423 2019-01-02  Tom Tromey  <tom@tromey.com>
9424
9425         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9426         constructor, destructor.
9427         (linespec_parser): Remove typedef.
9428         (~linespec_parser): Rename from linespec_parser_delete.
9429         (linespec_lex_to_end, linespec_complete_label)
9430         (linespec_complete): Update.
9431         (decode_line_full): Remove cleanups.
9432         (decode_line_1): Update.
9433
9434 2019-01-02  Tom Tromey  <tom@tromey.com>
9435
9436         * python/python-internal.h (inferior_to_inferior_object): Change
9437         return type.
9438         * python/py-exitedevent.c (create_exited_event_object): Update.
9439         * python/py-inferior.c (inferior_to_inferior_object): Return
9440         gdbpy_ref.
9441         (python_new_inferior, python_inferior_deleted)
9442         (thread_to_thread_object, delete_thread_object)
9443         (build_inferior_list, gdbpy_selected_inferior): Update.
9444         * python/py-infthread.c (create_thread_object): Update.  Also fail
9445         if inferior_to_inferior_object fails.
9446
9447 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9448
9449         * inferior.h (class inferior) <displaced_step_state>: New field.
9450         * infrun.h (struct displaced_step_state): Move here from
9451         infrun.c.  Initialize fields, add constructor.
9452         <inf>: Remove field.
9453         <reset>: New method.
9454         * infrun.c (struct displaced_step_inferior_state): Move to
9455         infrun.h.
9456         (displaced_step_inferior_states): Remove.
9457         (get_displaced_stepping_state): Adust.
9458         (displaced_step_in_progress_any_inferior): Adjust.
9459         (displaced_step_in_progress_thread): Adjust.
9460         (displaced_step_in_progress): Adjust.
9461         (add_displaced_stepping_state): Remove.
9462         (get_displaced_step_closure_by_addr): Adjust.
9463         (remove_displaced_stepping_state): Remove.
9464         (infrun_inferior_exit): Call displaced_step_state.reset.
9465         (use_displaced_stepping): Don't check for NULL.
9466         (displaced_step_prepare_throw): Call
9467         get_displaced_stepping_state.
9468         (displaced_step_fixup): Don't check for NULL.
9469         (prepare_for_detach): Don't check for NULL.
9470
9471 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9472
9473         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9474          in case of call that did not complete.
9475
9476 2019-01-02  Andrey Utkin  <autkin@undo.io>
9477
9478         * symfile.c (find_separate_debug_file): Fix search of debug files for
9479         remote debuggee.
9480
9481 2019-01-02  Tom Tromey  <tom@tromey.com>
9482
9483         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9484         indentation.
9485         * python/py-frame.c (frapy_older): Remove cast.
9486         (frapy_newer): Likewise.
9487         * python/py-breakpoint.c (local_setattro): Remove cast.
9488         * python/py-arch.c (archpy_name): Remove local variable.
9489         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9490
9491 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9492
9493         * unittests/basic_string_view/element_access/char/empty.cc:
9494         Fix year range in copyright header.
9495
9496 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9497
9498         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9499         Delete.
9500         <operator==>: Update with for removed field.
9501         <hash>: Likewise.
9502         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9503         <isa_features>: ...this.
9504         <abi_features>: New field.
9505         (riscv_isa_flen): Update comment.
9506         (riscv_abi_xlen): New declaration.
9507         (riscv_abi_flen): New declaration.
9508         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9509         isa_features.
9510         (riscv_abi_xlen): New function.
9511         (riscv_isa_flen): Update to get answer from isa_features.
9512         (riscv_abi_flen): New function.
9513         (riscv_has_fp_abi): Update to get answer from abi_features.
9514         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9515         xlen and flen.
9516         (riscv_call_info) <xlen, flen>: Update comment.
9517         (riscv_call_arg_struct): Remove invalid assertions
9518         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9519         is removed.
9520         (riscv_gdbarch_init): Gather isa features and abi features
9521         separately, ensure both match on the gdbarch when reusing an old
9522         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9523         a target with 64-bit float hardware.
9524
9525 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9526
9527         * source.c (search_command_helper): Stop reverse search
9528         when line 1 has been searched.
9529
9530 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9531
9532         * record-full.c (record_full_base_target::close): Rewrite
9533         record_full_core_buf_list free logic.
9534
9535 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9536
9537         * break-catch-syscall.c (print_one_catch_syscall): xfree
9538         the last text.
9539
9540 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9541
9542         * top.c (print_gdb_version): Update Copyright year in version
9543         message.
9544
9545 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9546
9547         Update copyright year range in all GDB files.
9548
9549 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9550
9551         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9552
9553 For older changes see ChangeLog-2018.
9554 \f
9555 Local Variables:
9556 mode: change-log
9557 left-margin: 8
9558 fill-column: 74
9559 version-control: never
9560 coding: utf-8
9561 End:
9562