gdb/ChangeLog

   1 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
   2             Jiong Wang  <jiong.wang@arm.com>
   3
   4         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
   5         (aarch64_dwarf2_prev_register): Unmask PC value.
   6         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
   7         (aarch64_execute_dwarf_cfa_vendor_op): Check for
   8         DW_CFA_AARCH64_negate_ra_state.
   9         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
  10
  11 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  12             Jiong Wang  <jiong.wang@arm.com>
  13
  14         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
  15         registers.
  16         (aarch64_pseudo_register_name): Likewise.
  17         (aarch64_pseudo_register_type): Likewise.
  18         (aarch64_pseudo_register_reggroup_p): Likewise.
  19         (aarch64_gdbarch_init): Add pauth registers.
  20         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
  21         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
  22         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
  23         (struct gdbarch_tdep): Add regnum for ra_state.
  24
  25 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  26             Jiong Wang  <jiong.wang@arm.com>
  27
  28         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
  29
  30 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  31             Jiong Wang  <jiong.wang@arm.com>
  32
  33         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
  34         function.
  35         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
  36         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
  37         (aarch64_gdbarch_init): Add puth registers.
  38         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
  39         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
  40         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
  41
  42 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  43             Jiong Wang  <jiong.wang@arm.com>
  44
  45         * aarch64-linux-nat.c
  46         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
  47         * aarch64-linux-tdep.c
  48         (aarch64_linux_core_read_description): Likewise.
  49         (aarch64_linux_get_hwcap): New function.
  50         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
  51         (aarch64_linux_get_hwcap): New declaration.
  52
  53 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  54             Jiong Wang  <jiong.wang@arm.com>
  55
  56         * aarch64-linux-nat.c
  57         (aarch64_linux_nat_target::read_description): Add pauth param.
  58         * aarch64-linux-tdep.c
  59         (aarch64_linux_core_read_description): Likewise.
  60         * aarch64-tdep.c (struct target_desc): Add in pauth.
  61         (aarch64_read_description): Add pauth param.
  62         (aarch64_gdbarch_init): Likewise.
  63         * aarch64-tdep.h (aarch64_read_description): Likewise.
  64         * arch/aarch64.c (aarch64_create_target_description): Likewise.
  65         * arch/aarch64.h (aarch64_create_target_description): Likewise.
  66         * features/Makefile: Add new files.
  67         * features/aarch64-pauth.c: New file.
  68         * features/aarch64-pauth.xml: New file.
  69
  70 2019-03-20  Tom Tromey  <tromey@adacore.com>
  71
  72         * infrun.c (handle_inferior_event): Rename from
  73         handle_inferior_event_1.  Create a scoped_value_mark.
  74         (handle_inferior_event): Remove.
  75
  76 2019-03-19  Tom Tromey  <tromey@adacore.com>
  77
  78         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
  79         * infrun.h (print_stop_event): Add "displays" parameter.
  80         * infrun.c (print_stop_event): Add "displays" parameter.
  81
  82 2019-03-19  Pedro Alves  <palves@redhat.com>
  83
  84         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
  85         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
  86         to -1.  Fix TABs vs spaces.
  87         (tui_ui_out::tui_ui_out): Don't initialize fields here.
  88         * tui/tui-out.h (tui_ui_out) Add intro comments.
  89         <m_line, m_start_of_line>: In-class initialize, and add describing
  90         comment.
  91
  92 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
  93
  94         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
  95         variable names.
  96         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
  97
  98 2019-03-18  Pedro Alves  <palves@redhat.com>
  99             Eli Zaretskii <eliz@gnu.org>
 100
 101         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 102         m_line and m_start_of_line.
 103
 104 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 105
 106         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 107         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 108         it returns a newline.  This fixes a regression in TU mode, whereby
 109         the next line is output on the same screen line as the user input.
 110
 111 2019-03-18  Tom Tromey  <tromey@adacore.com>
 112
 113         * minsyms.c (minimal_symbol_reader::install): Remove call to
 114         obstack_blank.
 115
 116 2019-03-18  Pedro Alves  <palves@redhat.com>
 117
 118         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 119         New globals.
 120         (apply_style): New, factored out from ...
 121         (apply_ansi_escape): ... this.  Handle reverse video mode.
 122         (tui_set_reverse_mode): New function.
 123         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 124         * tui/tui-winsource.c (tui_show_source_line): Use
 125         tui_set_reverse_mode instead of setting A_STANDOUT.
 126         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 127         New setter methods.
 128
 129 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 130
 131         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 132         Handle tabs.
 133
 134 2019-03-18  Tom Tromey  <tromey@adacore.com>
 135
 136         * ada-lang.c (empty_array): Add "high" parameter.
 137         (ada_evaluate_subexp): Update.
 138
 139 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 140
 141         * unittests/string_view-selftests.c: Define
 142         _initialize_string_view_selftests unconditionally.
 143
 144 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 145
 146         PR gdb/24350
 147         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 148
 149 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 150
 151         PR gdb/24351
 152         * windows-nat.c (display_selector): Fix format specifiers.
 153
 154 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 155
 156         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 157         tui_refill_source_window instead of tui_refresh_win, to update the
 158         current execution line.  This fixes redisplay of the current line
 159         when stepping through the code with "next" or "step".
 160
 161 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 162
 163         * source-cache.c (source_cache::get_source_lines): Call
 164         find_source_lines to initialize s->nlines.  This fixes vertical
 165         scrolling of TUI source window when the DOWN arrow is pressed.
 166
 167 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 168
 169         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 170         linux-thread-db.c (_initialize_thread_db): Likewise.
 171
 172 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 173
 174         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 175         wclrtoeol in tui_show_source_line".  This reverts changes made in
 176         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 177
 178 2019-03-15  Tom Tromey  <tom@tromey.com>
 179
 180         * symtab.h (struct minimal_symbol): Derive from
 181         general_symbol_info.
 182         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 183         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 184         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 185         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 186         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 187         (MSYMBOL_SEARCH_NAME): Update.
 188         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 189         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 190         * minsyms.c (minimal_symbol_reader::record_full): Update.
 191
 192 2019-03-15  Tom Tromey  <tom@tromey.com>
 193
 194         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 195
 196 2019-03-15  Tom Tromey  <tom@tromey.com>
 197
 198         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 199         unique_xmalloc_ptr.
 200         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 201         Update.
 202         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 203         (build_minimal_symbol_hash_tables)
 204         (minimal_symbol_reader::install): Update.
 205
 206 2019-03-15  Tom Tromey  <tom@tromey.com>
 207
 208         * symtab.c (create_demangled_names_hash): Update.
 209         (symbol_set_names): Update.
 210         * objfiles.h (struct objfile_per_bfd_storage)
 211         <demangled_names_hash>: Now an htab_up.
 212         * objfiles.c (objfile_per_bfd_storage): Simplify.
 213
 214 2019-03-15  Tom Tromey  <tom@tromey.com>
 215
 216         * objfiles.h (struct objfile_per_bfd_storage): Declare
 217         destructor.
 218         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 219         New.
 220         (get_objfile_bfd_data): Use new.  Don't initialize
 221         language_of_main.
 222         (free_objfile_per_bfd_storage): Remove.
 223         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 224
 225 2019-03-15  Tom Tromey  <tom@tromey.com>
 226
 227         * symfile.c (reread_symbols): Update.
 228         * objfiles.c (objfile::objfile): Update.
 229         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 230         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 231         comment.
 232         (minimal_symbol_reader::install): Update.
 233         (terminate_minimal_symbol_table): Remove.
 234         * jit.c (jit_object_close_impl): Update.
 235
 236 2019-03-15  Tom Tromey  <tom@tromey.com>
 237
 238         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 239         initializations.
 240
 241 2019-03-15  Tom Tromey  <tom@tromey.com>
 242
 243         * objfiles.h (struct objfile_per_bfd_storage)
 244         <demangled_hash_languages>: Now a bitset.
 245         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 246         (lookup_minimal_symbol): Update.
 247
 248 2019-03-15  Tom Tromey  <tom@tromey.com>
 249
 250         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 251         Don't return the symbol.
 252         * coffread.c (record_minimal_symbol): Use record_full.
 253
 254 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 255
 256         The MS-Windows port of ncurses fails to switch to a color pair if
 257         one or both of the colors are the implicit default colors.  This
 258         change records the default colors when TUI is initialized, and
 259         then specifies them explicitly when a color pair uses the default
 260         colors.  This allows color styling in TUI mode on MS-Windows.
 261
 262         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 263         ncurses_norm_attr.
 264         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 265         colors in ncurses_norm_attr.
 266         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 267         "none", replace it with the default color recorded in
 268         ncurses_norm_attr.
 269
 270 2019-03-14  Tom Tromey  <tromey@adacore.com>
 271
 272         * source-cache.h (class source_cache) <get_source_lines>: Return
 273         std::string.
 274         * source-cache.c (source_cache::extract_lines): Handle case where
 275         first_pos==npos.  Return std::string.
 276         (source_cache::get_source_lines): Update.
 277
 278 2019-03-14  Tom Tromey  <tromey@adacore.com>
 279
 280         * NEWS: Add item for "style sources" commands.
 281         * source-cache.c (source_cache::get_source_lines): Check
 282         source_styling.
 283         * cli/cli-style.c (source_styling): New global.
 284         (_initialize_cli_style): Add "style sources" commands.
 285         (show_style_sources): New function.
 286         * cli/cli-style.h (source_styling): Declare.
 287
 288 2019-03-14  Pedro Alves  <palves@redhat.com>
 289             Tom Tromey  <tromey@adacore.com>
 290
 291         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 292         * tui/tui-winsource.c (tui_refill_source_window): New function,
 293         from...
 294         (tui_horizontal_source_scroll): ... here.  Move some logic.
 295         * cli/cli-style.c (set_style_enabled): Notify new observable.
 296         * tui/tui-hooks.c (tui_redisplay_source): New function.
 297         (tui_attach_detach_observers): Attach or detach
 298         tui_redisplay_source.
 299         * observable.h (source_styling_changed): New observable.
 300         * observable.c: Define source_styling_changed observable.
 301
 302 2019-03-13  Tom Tromey  <tromey@adacore.com>
 303
 304         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 305         (i386_gnu_nat_target::store_registers): Update.
 306         * target-debug.h (target_debug_print_std_string): New macro.
 307         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 308         * windows-tdep.c (display_one_tib): Update.
 309         * tui/tui-stack.c (tui_make_status_line): Update.
 310         * top.c (print_inferior_quit_action): Update.
 311         * thread.c (thr_try_catch_cmd): Update.
 312         (add_thread_with_info): Update.
 313         (thread_target_id_str): Update.
 314         (thr_try_catch_cmd): Update.
 315         (thread_command): Update.
 316         (thread_find_command): Update.
 317         * record-btrace.c (record_btrace_target::info_record)
 318         (record_btrace_resume_thread, record_btrace_target::resume)
 319         (record_btrace_cancel_resume, record_btrace_step_thread)
 320         (record_btrace_target::wait, record_btrace_target::wait)
 321         (record_btrace_target::wait, record_btrace_target::stop): Update.
 322         * progspace.c (print_program_space): Update.
 323         * process-stratum-target.c
 324         (process_stratum_target::thread_address_space): Update.
 325         * linux-fork.c (linux_fork_mourn_inferior)
 326         (detach_checkpoint_command, info_checkpoints_command)
 327         (linux_fork_context): Update.
 328         (linux_fork_detach): Update.
 329         (class scoped_switch_fork_info): Update.
 330         (delete_checkpoint_command): Update.
 331         * infrun.c (follow_fork_inferior): Update.
 332         (follow_fork_inferior): Update.
 333         (proceed_after_vfork_done): Update.
 334         (handle_vfork_child_exec_or_exit): Update.
 335         (follow_exec): Update.
 336         (displaced_step_prepare_throw): Update.
 337         (displaced_step_restore): Update.
 338         (start_step_over): Update.
 339         (resume_1): Update.
 340         (clear_proceed_status_thread): Update.
 341         (proceed): Update.
 342         (print_target_wait_results): Update.
 343         (do_target_wait): Update.
 344         (context_switch): Update.
 345         (stop_all_threads): Update.
 346         (restart_threads): Update.
 347         (finish_step_over): Update.
 348         (handle_signal_stop): Update.
 349         (switch_back_to_stepped_thread): Update.
 350         (keep_going_pass_signal): Update.
 351         (print_exited_reason): Update.
 352         (normal_stop): Update.
 353         * inferior.c (inferior_pid_to_str): Change return type.
 354         (print_selected_inferior): Update.
 355         (add_inferior): Update.
 356         (detach_inferior): Update.
 357         * dummy-frame.c (fprint_dummy_frames): Update.
 358         * dcache.c (dcache_info_1): Update.
 359         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 360         (btrace_fetch, btrace_clear): Update.
 361         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 362         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 363         type.
 364         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 365         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 366         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 367         * gdbarch.c, gdbarch.h: Rebuild.
 368         * gdbarch.sh (core_pid_to_str): Change return type.
 369         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 370         return type.
 371         (windows_nat_target::pid_to_str): Change return type.
 372         (windows_delete_thread): Update.
 373         (windows_nat_target::attach): Update.
 374         (windows_nat_target::files_info): Update.
 375         * target-delegates.c: Rebuild.
 376         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 377         return type.
 378         (sol_thread_target::pid_to_str): Change return type.
 379         * remote.c (class remote_target) <pid_to_str>: Change return
 380         type.
 381         (remote_target::pid_to_str): Change return type.
 382         (extended_remote_target::attach, remote_target::remote_stop_ns)
 383         (remote_target::remote_notif_remove_queued_reply)
 384         (remote_target::push_stop_reply, remote_target::disable_btrace):
 385         Update.
 386         (extended_remote_target::attach): Update.
 387         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 388         type.
 389         (gdbsim_target::pid_to_str): Change return type.
 390         * ravenscar-thread.c (struct ravenscar_thread_target)
 391         <pid_to_str>: Change return type.
 392         (ravenscar_thread_target::pid_to_str): Change return type.
 393         * procfs.c (class procfs_target) <pid_to_str>: Change return
 394         type.
 395         (procfs_target::pid_to_str): Change return type.
 396         (procfs_target::attach): Update.
 397         (procfs_target::detach): Update.
 398         (procfs_target::fetch_registers): Update.
 399         (procfs_target::store_registers): Update.
 400         (procfs_target::wait): Update.
 401         (procfs_target::files_info): Update.
 402         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 403         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 404         return type.
 405         (nto_procfs_target::pid_to_str): Change return type.
 406         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 407         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 408         return type.
 409         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 410         (exit_lwp): Update.
 411         (attach_proc_task_lwp_callback, get_detach_signal)
 412         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 413         (linux_nat_target::resume, wait_lwp, stop_callback)
 414         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 415         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 416         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 417         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 418         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 419         type.
 420         (inf_ptrace_target::attach): Update.
 421         (inf_ptrace_target::files_info): Update.
 422         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 423         type.
 424         (go32_nat_target::pid_to_str): Change return type.
 425         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 426         (gnu_nat_target::wait): Update.
 427         (gnu_nat_target::wait): Update.
 428         (gnu_nat_target::resume): Update.
 429         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 430         (fbsd_nat_target::wait): Update.
 431         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 432         type.
 433         (darwin_nat_target::attach): Update.
 434         * corelow.c (class core_target) <pid_to_str>: Change return type.
 435         (core_target::pid_to_str): Change return type.
 436         * target.c (normal_pid_to_str): Change return type.
 437         (default_pid_to_str): Likewise.
 438         (target_pid_to_str): Change return type.
 439         (target_translate_tls_address): Update.
 440         (target_announce_detach): Update.
 441         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 442         return type.
 443         (bsd_uthread_target::pid_to_str): Change return type.
 444         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 445         type.
 446         (bsd_kvm_target::pid_to_str): Change return type.
 447         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 448         return type.
 449         (aix_thread_target::pid_to_str): Change return type.
 450         * target.h (struct target_ops) <pid_to_str>: Change return type.
 451         (target_pid_to_str, normal_pid_to_str): Likewise.
 452         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 453         type.
 454         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 455         type.
 456         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 457         return type.
 458         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 459         type.
 460         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 461         type.
 462         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 463         return type.
 464
 465 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 466
 467         * NEWS: Mention that the new default MI version is 3.  Mention
 468         changes to the output of commands and events that deal with
 469         multi-location breakpoints.
 470         * breakpoint.c: Include "mi/mi-out.h".
 471         (print_one_breakpoint): Change output syntax if using MI version
 472         >= 3.
 473         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 474         New.
 475         (mi_multi_location_breakpoint_output_fixed): New.
 476         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 477         (mi_cmd_fix_multi_location_breakpoint_output): New.
 478         (mi_multi_location_breakpoint_output_fixed): New.
 479         * mi/mi-cmds.c (mi_cmds): Register command
 480         -fix-multi-location-breakpoint-output.
 481         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 482         interpreter "mi".
 483
 484 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 485
 486         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 487         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 488         instantiate mi_ui_out based on interpreter name.
 489         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 490         * mi/mi-main.c (mi_load_progress): Likewise.
 491
 492 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 493
 494         * NEWS: Combine separate "New targets" sections for 8.3.
 495
 496 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 497
 498         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 499         (ppcfbsd_init_abi): Install gdbarch
 500         "fetch_tls_load_module_address" and "get_thread_local_address"
 501         methods.
 502
 503 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 504
 505         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 506         (riscv_fbsd_init_abi): Install gdbarch
 507         "fetch_tls_load_module_address" and "get_thread_local_address"
 508         methods.
 509
 510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 511
 512         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 513         (i386fbsd_init_abi): Install gdbarch
 514         "fetch_tls_load_module_address" and "get_thread_local_address"
 515         methods.
 516
 517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 518
 519         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 520         (amd64fbsd_init_abi): Install gdbarch
 521         "fetch_tls_load_module_address" and "get_thread_local_address"
 522         methods.
 523
 524 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 525
 526         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 527         (struct fbsd_pspace_data): New type.
 528         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 529         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 530         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 531         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 532         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 533
 534 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 535
 536         * gdbtypes.c (lookup_struct_elt): New function.
 537         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 538         * gdbtypes.h (struct struct_elt): New type.
 539         (lookup_struct_elt): New prototype.
 540
 541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 542
 543         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 544         remove disabled code block.
 545
 546 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 547
 548         * gdbarch.sh (get_thread_local_address): New method.
 549         * gdbarch.h, gdbarch.c: Regenerate.
 550         * target.c (target_translate_tls_address): Use
 551         gdbarch_get_thread_local_address if present instead of
 552         target::get_thread_local_address.
 553
 554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 555
 556         * target.h (target::get_thread_local_address): Update comment.
 557
 558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 559
 560         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 561         objfile->separate_debug_objfile_backlink if not NULL.
 562
 563 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 564
 565         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 566         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 567         (amd64bsd_store_inferior_registers): Likewise.
 568         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 569         Enable segment base registers.
 570         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 571         PT_GETFSBASE and PT_GETGSBASE.
 572         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 573         PT_SETGSBASE.
 574         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 575         segment base registers.
 576         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 577
 578 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 579
 580         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 581         Update calls to i386_target_description to add 'segments'
 582         parameter.
 583         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 584         add segment base registers.
 585         * arch/i386.c (i386_create_target_description): Add 'segments'
 586         parameter to enable segment base registers.
 587         * arch/i386.h (i386_create_target_description): Likewise.
 588         * features/i386/32bit-segments.xml: New file.
 589         * features/i386/32bit-segments.c: Generate.
 590         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 591         call to i386_target_description to add 'segments' parameter.
 592         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 593         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 594         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 595         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 596         if feature is present.
 597         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 598         Add 'segments' parameter to call to i386_target_description.
 599         (i386_target_description): Add 'segments' parameter to enable
 600         segment base registers.
 601         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 602         to call to i386_target_description.
 603         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 604         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 605         Define I386_NUM_REGS.
 606         (i386_target_description): Add 'segments' parameter to enable
 607         segment base registers.
 608
 609 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 610
 611         PR/24325
 612         * source-cache.c: #undef open and close, to avoid unresolved
 613         externals during linking.
 614
 615 2019-03-12  Tom Tromey  <tromey@adacore.com>
 616
 617         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 618         const.  Add initializers.
 619         (_initialize_remote): Don't initialize ptid globals.
 620
 621 2019-03-12  Pedro Alves  <palves@redhat.com>
 622
 623         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 624
 625 2019-03-12  Pedro Alves  <palves@redhat.com>
 626
 627         * cp-name-parser.y (main): Remove unused 'len' variable.
 628
 629 2019-03-12  Tom Tromey  <tromey@adacore.com>
 630
 631         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 632         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 633
 634 2019-03-12  Tom Tromey  <tromey@adacore.com>
 635
 636         * linux-nat.c (iterate_over_lwps): Update.
 637         (stop_callback): Remove parameter.
 638         (stop_wait_callback, detach_callback, resume_set_callback)
 639         (select_singlestep_lwp_callback, set_ignore_sigint)
 640         (status_callback, resumed_callback, resume_clear_callback)
 641         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 642         data parameter.
 643         (linux_nat_target::detach, linux_nat_target::resume)
 644         (linux_stop_and_wait_all_lwps, select_event_lwp)
 645         (linux_nat_filter_event, linux_nat_wait_1)
 646         (linux_nat_target::kill, linux_nat_target::stop)
 647         (linux_nat_target::stop): Update.
 648         (linux_nat_resume_callback): Change type.
 649         (resume_stopped_resumed_lwps, count_events_callback)
 650         (select_event_lwp_callback): Likewise.
 651         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 652         * arm-linux-nat.c (struct update_registers_data): Remove.
 653         (update_registers_callback): Change type.
 654         (arm_linux_insert_hw_breakpoint1): Update.
 655         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 656         parameter.
 657         (x86_linux_dr_set_addr): Update.
 658         (x86_linux_dr_set_control): Update.
 659         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 660         (iterate_over_lwps): Use gdb::function_view.
 661         * nat/aarch64-linux-hw-point.c (struct
 662         aarch64_dr_update_callback_param): Remove.
 663         (debug_reg_change_callback): Change type.
 664         (aarch64_notify_debug_reg_change): Update.
 665         * s390-linux-nat.c (s390_refresh_per_info): Update.
 666
 667 2019-03-11  Tom Tromey  <tromey@adacore.com>
 668
 669         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 670         redundant assignment to "this_cu".
 671
 672 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 673
 674         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 675
 676 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 677
 678         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 679         from...
 680         (rank_one_type): ... this.
 681
 682 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 683
 684         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 685         from...
 686         (rank_one_type): ... this.
 687
 688 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 689
 690         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 691         from...
 692         (rank_one_type): ... this.
 693
 694 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 695
 696         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 697         from...
 698         (rank_one_type): ... this.
 699
 700 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 701
 702         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 703         from...
 704         (rank_one_type): ... this.
 705
 706 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 707
 708         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 709         from...
 710         (rank_one_type): ... this.
 711
 712 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 713
 714         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 715         from...
 716         (rank_one_type): ... this.
 717
 718 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 719
 720         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 721         from...
 722         (rank_one_type): ... this.
 723
 724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 725
 726         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 727         from...
 728         (rank_one_type): ... this.
 729
 730 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 731
 732         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 733         from...
 734         (rank_one_type): ... this.
 735
 736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 737
 738         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 739         from...
 740         (rank_one_type): ... this.
 741
 742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 743
 744         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 745         from...
 746         (rank_one_type): ... this.
 747
 748 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 749
 750         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 751         inferior-events' shows the example events.
 752
 753 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 754
 755         Support styling on native MS-Windows console
 756
 757         PR/24315
 758         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 759         on MS-Windows if $TERM is not defined.
 760
 761         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 762
 763         * posix-hdep.c (gdb_console_fputs):
 764         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 765         functions.
 766         * ui-file.h (gdb_console_fputs): Add prototype.
 767
 768         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 769         back to fputs only if the former returns zero.
 770
 771 2019-03-07  Tom Tromey  <tom@tromey.com>
 772
 773         * symmisc.c (print_symbol_bcache_statistics): Update.
 774         (print_objfile_statistics): Update.
 775         * symfile.c (allocate_symtab): Update.
 776         * stabsread.c: Don't include bcache.h.
 777         * psymtab.h (struct psymbol_bcache): Don't declare.
 778         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 779         (psymbol_bcache_init, psymbol_bcache_free)
 780         (psymbol_bcache_get_bcache): Don't declare.
 781         * psymtab.c (struct psymbol_bcache): Remove.
 782         (psymtab_storage::psymtab_storage): Update.
 783         (psymtab_storage::~psymtab_storage): Update.
 784         (psymbol_bcache_init, psymbol_bcache_free)
 785         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 786         (add_psymbol_to_bcache): Update.
 787         (allocate_psymtab): Update.
 788         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 789         macro_cache>: No longer pointers.
 790         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 791         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 792         * macrotab.c (macro_bcache): Update.
 793         * macroexp.c: Don't include bcache.h.
 794         * gdbtypes.c (check_types_worklist): Update.
 795         (types_deeply_equal): Remove TRY/CATCH.  Update.
 796         * elfread.c (elf_symtab_read): Update.
 797         * dwarf2read.c: Don't include bcache.h.
 798         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 799         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 800         (print_bcache_statistics, bcache_memory_used): Don't declare.
 801         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 802         methods.  Rename all data members.
 803         * bcache.c (struct bcache): Move to bcache.h.
 804         (bcache::expand_hash_table): Rename from expand_hash_table.
 805         (bcache): Remove.
 806         (bcache::insert): Rename from bcache_full.
 807         (bcache::compare): Rename from bcache_compare.
 808         (bcache_xmalloc): Remove.
 809         (bcache::~bcache): Rename from bcache_xfree.
 810         (bcache::print_statistics): Rename from print_bcache_statistics.
 811         (bcache::memory_used): Rename from bcache_memory_used.
 812
 813 2019-03-07  Pedro Alves  <palves@redhat.com>
 814
 815         * infrun.c (normal_stop): Also check for
 816         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 817
 818 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * f-lang.c (value_from_host_double): Moved to...
 821         * value.c (value_from_host_double): ...here.
 822         * value.h (value_from_host_double): Declare.
 823         * guile/scm-math.c (vlscm_convert_typed_number): Use
 824         value_from_host_double.
 825         (vlscm_convert_number): Likewise.
 826         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 827         * python/py-value.c (convert_value_from_python): Likewise.
 828
 829 2019-03-06  Tom Tromey  <tom@tromey.com>
 830
 831         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 832
 833 2019-03-06  Tom Tromey  <tom@tromey.com>
 834
 835         * utils.h (free_current_contents): Don't declare.
 836         * utils.c (free_current_contents): Remove.
 837
 838 2019-03-06  Tom Tromey  <tom@tromey.com>
 839
 840         * top.c (quit_force): Update.
 841         * main.c (captured_command_loop): Update.
 842         * common/new-op.c (operator new): Update.
 843         * common/common-exceptions.c (struct catcher)
 844         <save_cleanup_chain>: Remove member.
 845         (exceptions_state_mc_init): Update.
 846         (exception_try_scope_entry): Return nullptr.
 847         (exception_try_scope_exit, exception_rethrow)
 848         (throw_exception_sjlj, throw_exception_cxx): Update.
 849         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 850         (all_cleanups, do_cleanups, discard_cleanups)
 851         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 852         (restore_cleanups, restore_final_cleanups): Don't declare.
 853         (do_final_cleanups): Remove parameter.
 854         * common/cleanups.c (cleanup_chain, make_cleanup)
 855         (make_cleanup_dtor, all_cleanups, do_cleanups)
 856         (discard_my_cleanups, discard_cleanups)
 857         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 858         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 859         (null_cleanup): Remove.
 860         (do_final_cleanups): Remove parameter.
 861
 862 2019-03-06  Tom Tromey  <tom@tromey.com>
 863
 864         * remote.c (remote_target::remote_parse_stop_reply): Use
 865         unique_xmalloc_ptr.
 866
 867 2019-03-06  Tom Tromey  <tom@tromey.com>
 868
 869         * stabsread.c (struct stabs_field_info): Rename from field_info.
 870         <list, fnlist>: Add initializers.
 871         <obstack>: New member.
 872         (read_member_functions, read_struct_fields, read_baseclasses):
 873         Allocate on obstack.  Don't use cleanups.
 874         (read_one_struct_field, read_member_functions, read_struct_fields)
 875         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 876         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 877         (read_struct_type): Update.
 878
 879 2019-03-06  Tom Tromey  <tom@tromey.com>
 880
 881         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 882         * common/filestuff.h (make_cleanup_close): Don't declare.
 883         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 884         Remove.
 885
 886 2019-03-06  Tom Tromey  <tom@tromey.com>
 887
 888         * solib-aix.c: Use make_scope_exit.
 889
 890 2019-03-06  Tom Tromey  <tom@tromey.com>
 891
 892         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 893         Use make_scope_exit.
 894
 895 2019-03-06  Tom Tromey  <tom@tromey.com>
 896
 897         * solib-svr4.c (disable_probes_interface): Remove parameter.
 898         (svr4_handle_solib_event): Use make_scope_exit.
 899
 900 2019-03-06  Tom Tromey  <tom@tromey.com>
 901
 902         * remote.c (struct stop_reply_deleter): Remove.
 903         (stop_reply_up): Update.
 904         (struct stop_reply): Derive from notif_event.  Don't typedef.
 905         <regcache>: Now a std::vector.
 906         (stop_reply_xfree): Remove.
 907         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 908         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 909         (remote_target::discard_pending_stop_replies): Use delete.
 910         (remote_target::remote_parse_stop_reply): Update.
 911         (remote_target::process_stop_reply): Update.
 912         * remote-notif.h (struct notif_event): Add virtual destructor.
 913         Remove "dtr" member.
 914         (struct notif_client) <alloc_event>: Return a unique_ptr.
 915         (notif_event_xfree): Don't declare.
 916         (notif_event_up): New typedef.
 917         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 918         (notif_event_xfree, do_notif_event_xfree): Remove.
 919         (remote_notif_state_xfree): Update.
 920
 921 2019-03-06  Tom Tromey  <tom@tromey.com>
 922
 923         * infrun.c (displaced_step_clear_cleanup): Now a
 924         forward_scope_exit type.
 925         (displaced_step_prepare_throw): Update.
 926         (displaced_step_fixup): Update.
 927
 928 2019-03-06  Tom Tromey  <tom@tromey.com>
 929
 930         * inferior.h (class inferior): Update comment.
 931         * gdbthread.h (class thread_info): Update comment.
 932
 933 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 934             Tom Tromey  <tom@tromey.com>
 935
 936         * stabsread.h (struct stab_section_list): Remove.
 937         (coffstab_build_psymtabs): Update.
 938         * dbxread.c (symbuf_sections): Now a std::vector.
 939         (sect_idx): New global.
 940         (fill_symbuf): Update.
 941         (coffstab_build_psymtabs): Change type of stabsects parameter.
 942         Update.
 943         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 944         std::vector.
 945         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 946         (coff_locate_sections): Update.
 947         (coff_symfile_read): Remove cleanups.  Update.
 948         (init_stringtab): Add storage parameter.
 949         (free_stringtab, free_stringtab_cleanup): Remove.
 950         (init_lineno): Add storage parameter.
 951         (free_linetab, free_linetab_cleanup): Remove.
 952
 953 2019-03-06  Pedro Alves  <palves@redhat.com>
 954
 955         * linux-fork.c (fork_info::clobber_regs): Delete.
 956         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 957         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 958         comment.  Adjust.
 959         (scoped_switch_fork_info::scoped_switch_fork_info)
 960         (checkpoint_command, linux_fork_context): Adjust
 961         fork_save_infrun_state calls.
 962
 963 2019-03-06  Pedro Alves  <palves@redhat.com>
 964
 965         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 966         (inf_has_multiple_threads): Return 'bool' and rewrite using
 967         inferior_info::threads().
 968
 969 2019-03-06  Pedro Alves  <palves@redhat.com>
 970
 971         * linux-fork.c: Include <list>.
 972         (fork_list): Now a std::list instance.
 973         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 974         (forks_exist_p, find_last_fork): Adjust.
 975         (new_fork): Delete.
 976         (one_fork_p): New.
 977         (add_fork): Adjust.
 978         (free_fork): Delete, folded into fork_info::~fork_info().
 979         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 980         Adjust.
 981         (init_fork_list): Delete.
 982         (linux_fork_killall, linux_fork_mourn_inferior)
 983         (linux_fork_detach, info_checkpoints_command): Adjust.
 984         (_initialize_linux_fork): No longer call init_fork_list.
 985
 986 2019-03-06  Pedro Alves  <palves@redhat.com>
 987
 988         * linux-fork.c (new_fork): New, split out of ...
 989         (add_fork): ... this.  Return void.  Move "first fork" special
 990         case from here, to ...
 991         (checkpoint_command): ... here.
 992         * linux-linux.h (add_fork): Return void.
 993
 994 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 995
 996         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 997
 998 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 999             Chris January  <chris.january@arm.com>
1000             David Lecomber  <david.lecomber@arm.com>
1001
1002         * f-exp.y: New token, UNOP_INTRINSIC.
1003         (exp): New pattern using UNOP_INTRINSIC token.
1004         (f77_keywords): Add 'abs' keyword.
1005         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1006         (value_from_host_double): New function.
1007         (evaluate_subexp_f): Support UNOP_ABS.
1008
1009 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1010
1011         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1012         types.
1013
1014 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1017         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1018         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1019
1020 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1023
1024 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1025             Chris January  <chris.january@arm.com>
1026
1027         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1028         * f-exp.y: Define 'KIND' token.
1029         (exp): New pattern for KIND expressions.
1030         (ptype): Handle types with a kind extension.
1031         (direct_abs_decl): Extend to spot kind extensions.
1032         (f77_keywords): Add 'kind' to the list.
1033         (push_kind_type): New function.
1034         (convert_to_kind_type): New function.
1035         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1036         * parse.c (operator_length_standard): Likewise.
1037         * parser-defs.h (enum type_pieces): Add tp_kind.
1038         * std-operator.def: Add UNOP_KIND.
1039
1040 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * f-exp.y (f_parse): Set yydebug.
1043
1044 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * f-lang.c (evaluate_subexp_f): New function.
1047         (exp_descriptor_f): New global.
1048         (f_language_defn): Use exp_descriptor_f instead of
1049         exp_descriptor_standard.
1050
1051 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * f-exp.y (struct token): Add comments.
1054         (dot_ops): Remove uppercase versions and the end marker.
1055         (f77_keywords): Likewise.
1056         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1057         entries in the dot_ops array are case insensitive, and use
1058         strncasecmp to compare strings.  Also some whitespace cleanup in
1059         this area.  Similar for the f77_keywords array, except entries in
1060         this list might be case sensitive.
1061
1062 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * f-exp.y (struct f77_boolean_val): Add comments.
1065         (boolean_values): Remove uppercase versions, and end marker.
1066         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1067         and use strncasecmp to achieve case insensitivity.  Additionally,
1068         perform whitespace cleanup around this code.
1069
1070 2019-03-06  Tom Tromey  <tromey@adacore.com>
1071
1072         * remote-sim.c (gdbsim_target_open): Use result of
1073         gdb_argv::release.
1074
1075 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1076         Dirk Schubert  <dirk.schubert@arm.com>
1077         Chris January  <chris.january@arm.com>
1078
1079         * eval.c (evaluate_subexp_standard): Call Fortran argument
1080         wrapping logic.
1081         * f-lang.c (struct value): A value which can be passed into a
1082         Fortran function call.
1083         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1084         where appropriate.
1085         (struct type): Value ready for a Fortran function call.
1086         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1087         is needed.
1088         * f-lang.h (fortran_argument_convert): Declaration.
1089         (fortran_preserve_arg_pointer): Declaration.
1090         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1091
1092 2019-03-05  Tom Tromey  <tromey@adacore.com>
1093
1094         * python/py-prettyprint.c (print_string_repr): Remove #if.
1095         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1096
1097 2019-03-05  Tom Tromey  <tromey@adacore.com>
1098
1099         * target.c (the_dummy_target): Move later.  Change type to
1100         "dummy_target".
1101         (initialize_targets): Don't initialize the_dummy_target.
1102
1103 2019-03-05  Tom Tromey  <tromey@adacore.com>
1104
1105         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1106         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1107
1108 2019-03-05  Tom Tromey  <tromey@adacore.com>
1109
1110         * windows-nat.c (windows_nat_target::attach)
1111         (windows_nat_target::detach): Don't call gdb_flush.
1112         * valprint.c (generic_val_print, val_print, val_print_string):
1113         Don't call gdb_flush.
1114         * utils.c (defaulted_query): Don't call gdb_flush.
1115         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1116         * target.c (target_announce_detach): Don't call gdb_flush.
1117         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1118         * remote.c (extended_remote_target::attach): Don't call
1119         gdb_flush.
1120         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1121         * printcmd.c (do_examine): Don't call gdb_flush.
1122         (info_display_command): Don't call gdb_flush.
1123         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1124         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1125         * memattr.c (info_mem_command): Don't call gdb_flush.
1126         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1127         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1128         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1129         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1130         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1131         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1132         (gnu_nat_target::detach): Don't call gdb_flush.
1133         * f-valprint.c (f_val_print): Don't call gdb_flush.
1134         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1135         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1136         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1137         gdb_flush.
1138         * c-valprint.c (c_val_print): Don't call gdb_flush.
1139         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1140
1141 2019-03-05  Tom Tromey  <tromey@adacore.com>
1142
1143         * varobj.c (update_dynamic_varobj_children): Update.
1144         (install_default_visualizer): Use reset, not release.
1145         * value.c (set_internalvar): Update.
1146         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1147         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1148         ATTRIBUTE_UNUSED_RESULT.
1149
1150 2019-03-05  Tom Tromey  <tromey@adacore.com>
1151
1152         * remote.c (class scoped_remote_fd) <release>: Add
1153         ATTRIBUTE_UNUSED_RESULT.
1154
1155 2019-03-05  Tom Tromey  <tromey@adacore.com>
1156
1157         * macroexp.c (struct macro_buffer) <release>: Add
1158         ATTRIBUTE_UNUSED_RESULT.
1159
1160 2019-03-05  Tom Tromey  <tromey@adacore.com>
1161
1162         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1163         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1164         ATTRIBUTE_UNUSED_RESULT.
1165
1166 2019-03-05  Tom Tromey  <tromey@adacore.com>
1167
1168         * common/scoped_fd.h (class scoped_fd) <release>: Add
1169         ATTRIBUTE_UNUSED_RESULT.
1170
1171 2019-03-05  Tom Tromey  <tromey@adacore.com>
1172
1173         * parser-defs.h (struct parser_state) <release>: Add
1174         ATTRIBUTE_UNUSED_RESULT.
1175
1176 2019-03-05  Tom Tromey  <tromey@adacore.com>
1177
1178         * utils.h (class gdb_argv) <release>: Add
1179         ATTRIBUTE_UNUSED_RESULT.
1180         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1181
1182 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1183
1184         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1185         for-loop range, to avoid compiler warnings.
1186
1187         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1188         avoid compiler warnings about unused variables.
1189
1190         * NEWS: Mention end of support for native debugging on MS-Windows
1191         before XP.
1192
1193         PR gdb/24292
1194         * common/netstuff.c:
1195         * gdbserver/gdbreplay.c
1196         * gdbserver/remote-utils.c:
1197         * ser-tcp.c:
1198         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1199         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1200         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1201         'getaddrinfo' and 'freeaddrinfo' were not available before
1202         Windows XP, and mingw.org's MinGW headers by default define
1203         _WIN32_WINNT to 0x500.
1204
1205 2019-03-01  Gary Benson <gbenson@redhat.com>
1206
1207         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1208
1209 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1210             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1211
1212         PR gdb/8527
1213         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1214         set_sigint_trap, clear_sigint_trap.
1215
1216 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1217
1218         * target.c (target_detach): Clear the regcache and the
1219         frame cache.
1220
1221 2019-02-27  Pedro Alves  <palves@redhat.com>
1222
1223         * utils.c (set_screen_size): When we cap the height/width sizes,
1224         tweak the corresponding command variable to show "unlimited":
1225
1226 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1227             Pedro Alves  <palves@redhat.com>
1228
1229         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1230         before calling rl_set_screen_size.
1231
1232 2019-02-27  Tom Tromey  <tromey@adacore.com>
1233
1234         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1235         define.
1236         * python/py-value.c: Remove Python 2.4 workaround.
1237         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1238         workaround.
1239         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1240         Python 2.4 workaround.
1241         * python/python-internal.h: Remove Python 2.4 comment.
1242         (Py_ssize_t): Don't define.
1243         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1244         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1245         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1246         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1247         * python/python.c (do_start_initialization): Remove Python 2.4
1248         workaround.
1249         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1250         (print_children): Remove Python 2.4 workaround.
1251         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1252         workaround.
1253         (CHARBUFFERPROC_NAME): Remove.
1254         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1255         Python 2.4 workaround.
1256
1257 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1258
1259         * NEWS: Note minimum Python version.
1260
1261 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1262
1263         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1264         code from these functions.  Remove corresponding ifdefs.  Use
1265         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1266         Remove gotos and target of gotos.
1267         (infpy_search_memory): Likewise.
1268
1269 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1270
1271         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1272         (hppa_gdbarch_init): Don't register deleted functions with
1273         gdbarch.
1274
1275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1278         (h8300_unwind_sp): Delete.
1279         (h8300_dummy_id): Delete.
1280         (h8300_gdbarch_init): Don't register deleted functions with
1281         gdbarch.
1282
1283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1286         (ft32_unwind_pc): Delete.
1287         (ft32_unwind_sp): Delete.
1288         (ft32_gdbarch_init): Don't register deleted functions with
1289         gdbarch.
1290
1291 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1294         (frv_unwind_pc): Delete.
1295         (frv_unwind_sp): Delete.
1296         (frv_gdbarch_init): Don't register deleted functions with
1297         gdbarch.
1298
1299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1302         (riscv_unwind_pc): Delete.
1303         (riscv_unwind_sp): Delete.
1304         (riscv_gdbarch_init): Don't register deleted functions with
1305         gdbarch.
1306
1307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1310         (csky_unwind_pc): Delete.
1311         (csky_unwind_sp): Delete.
1312         (csky_gdbarch_init): Don't register deleted functions with
1313         gdbarch.
1314
1315 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1318         (cris_unwind_pc): Delete.
1319         (cris_unwind_sp): Delete.
1320         (cris_gdbarch_init): Don't register deleted functions with
1321         gdbarch.
1322
1323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1326         (bfin_unwind_pc): Delete.
1327         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1328
1329 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1332         (arm_unwind_pc): Delete.
1333         (arm_unwind_sp): Delete.
1334         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1335
1336 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1337
1338         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1339         (arc_unwind_pc): Delete.
1340         (arc_unwind_sp): Delete.
1341         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1342
1343 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1344
1345         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1346         (alpha_unwind_pc): Delete.
1347         (alpha_gdbarch_init): Don't register deleted functions with
1348         gdbarch.
1349
1350 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1353         (aarch64_unwind_pc): Delete.
1354         (aarch64_unwind_sp): Delete.
1355         (aarch64_gdbarch_init): Don't register deleted functions with
1356         gdbarch.
1357
1358 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1359
1360         * gdbtypes.c (type_align): Don't consider static members when
1361         computing structure alignment.
1362
1363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1366         return 0 for other types.
1367         * arch-utils.c (default_type_align): Always return 0.
1368         * gdbarch.h: Regenerate.
1369         * gdbarch.sh (type_align): Extend comment.
1370         * gdbtypes.c (type_align): Add additional comments, always call
1371         gdbarch_type_align before applying the default rules.
1372         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1373         generic code will then apply a suitable default.
1374         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1375         types, return 0 for other types.
1376
1377 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1378
1379         * NEWS: Create a new section for the next release branch.
1380         Rename the section of the current branch, now that it has
1381         been cut.
1382
1383 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1384
1385         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1386         * version.in: Bump version to 8.3.50.DATE-git.
1387
1388 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1389
1390         * aix-thread.c (ptid_cmp): Remove unused variable.
1391         (get_signaled_thread): Likewise.
1392         (store_regs_user_thread): Likewise.
1393         (store_regs_kernel_thread): Likewise.
1394         (fetch_regs_kernel_thread): Remove shadowed variable.
1395
1396 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1397
1398         * features/riscv/32bit-cpu.xml: Add register numbers.
1399         * features/riscv/32bit-fpu.c: Regenerate.
1400         * features/riscv/32bit-fpu.xml: Add register numbers.
1401         * features/riscv/64bit-cpu.xml: Add register numbers.
1402         * features/riscv/64bit-fpu.c: Regenerate.
1403         * features/riscv/64bit-fpu.xml: Add register numbers.
1404
1405 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1406
1407         * NEWS: Mention two argument form of gdb.Value constructor.
1408         * python/py-value.c (convert_buffer_and_type_to_value): New
1409         function.
1410         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1411         Add support for handling an optional second argument.  Call
1412         convert_buffer_and_type_to_value as appropriate.
1413         * python/python-internal.h (Py_buffer_deleter): New struct.
1414         (Py_buffer_up): New typedef.
1415
1416 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1417
1418         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1419         instead of releasing ownership.
1420
1421 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1422
1423         * dwarf2read.c (open_and_init_dwp_file): Call
1424         elf_numsections instead of bfd_count_sections to initialize
1425         dwp_file->num_sections.
1426
1427 2019-02-25  Tom Tromey  <tromey@adacore.com>
1428
1429         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1430
1431 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1432
1433         * gcore.in: Add '--readnever' option when invoking GDB.
1434
1435 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1436
1437         * MAINTAINERS: Update my email address.
1438
1439 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1440
1441         * build-id.c (build_id_to_debug_bfd_1): New function.
1442         (build_id_to_debug_bfd): Look for separate debug file in
1443         sysroot.
1444
1445 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1446
1447         * gdbarch.sh: Update the copyright year range that is placed into
1448         generated files.
1449
1450 2019-02-22  Keith Seitz  <keiths@redhat.com>
1451
1452         PR symtab/23853
1453         * linespec.c (create_sals_line_offset): Search for the default
1454         symtab's filename instead of its fullname.
1455
1456 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1457
1458         * NEWS: Update style defaults.
1459
1460 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1461
1462         * main.c (captured_main_1): Disable styling in batch mode.
1463
1464 2019-02-20  Tom Tromey  <tom@tromey.com>
1465
1466         * symtab.c (symtab_symbol_info): Fix typos.
1467
1468 2019-02-20  Tom Tromey  <tromey@adacore.com>
1469
1470         * findcmd.c (_initialize_mem_search): Use upper case for
1471         metasyntactic variables.
1472
1473 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1474
1475         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1476         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1477
1478 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1479
1480         * top.h (source_file_name): Change to std::string.
1481         * top.c (source_file_name): Likewise.
1482         (command_line_input): Adjust.
1483         * cli/cli-script.c (script_from_file): Adjust.
1484
1485 2019-02-19  Tom Tromey  <tromey@adacore.com>
1486
1487         * ravenscar-thread.c
1488         (ravenscar_thread_target::update_thread_list): Don't call
1489         ada_build_task_list.
1490         * ada-lang.h (ada_build_task_list): Don't declare.
1491         * ada-tasks.c (struct ada_tasks_inferior_data)
1492         <task_list_valid_p>: Now bool.
1493         (read_known_tasks, ada_task_list_changed)
1494         (ada_tasks_invalidate_inferior_data): Update.
1495         (read_known_tasks_array): Return bool.
1496         (read_known_tasks_list): Likewise.
1497         (read_known_tasks): Return void.
1498         (ada_build_task_list): Now static.
1499
1500 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1501
1502         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1503         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1504
1505 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1506
1507         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1508         variant for ada_tasks_pspace_data_handle and
1509         ada_tasks_inferior_data_handle.
1510         (ada_tasks_pspace_data_cleanup): New function.
1511         (ada_tasks_inferior_data_cleanup): New function.
1512
1513 2019-02-17  Tom Tromey  <tom@tromey.com>
1514
1515         * macrotab.h (macro_source_fullname): Return a std::string.
1516         * macrotab.c (macro_include, check_for_redefinition)
1517         (macro_undef, macro_lookup_definition, foreach_macro)
1518         (foreach_macro_in_scope): Update.
1519         (macro_source_fullname): Return a std::string.
1520         * macrocmd.c (show_pp_source_pos): Update.
1521
1522 2019-02-17  Tom Tromey  <tom@tromey.com>
1523
1524         * macrocmd.c (show_pp_source_pos): Style the file names.
1525
1526 2019-02-17  Tom Tromey  <tom@tromey.com>
1527
1528         PR tui/24197:
1529         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1530
1531 2019-02-17  Tom Tromey  <tom@tromey.com>
1532
1533         * ada-lang.c (user_select_syms): Use filtered printing.
1534         * utils.c (wrap_style): New global.
1535         (desired_style): Remove.
1536         (emit_style_escape): Add stream parameter.
1537         (set_output_style, reset_terminal_style, prompt_for_continue):
1538         Update.
1539         (flush_wrap_buffer): Only flush gdb_stdout.
1540         (wrap_here): Set wrap_style.
1541         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1542         treat escape sequences as a character.  Change when wrap buffer is
1543         flushed.
1544         (fputs_styled): Do not set the output style when the default is
1545         requested.
1546         * ui-style.h (struct ui_file_style) <is_default>: New method.
1547         * source.c (print_source_lines_base): Emit escape sequences in one
1548         piece.
1549
1550 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1551
1552         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1553         integers and enumeration types.
1554
1555 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1556
1557         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1558         instead of lookup_symbol_in_language
1559         (do_exact_match): New function.
1560         (ada_get_symbol_name_matcher): Return do_exact_match when
1561         doing a verbatim match.
1562
1563 2019-02-15  Tom Tromey  <tromey@adacore.com>
1564
1565         * ravenscar-thread.c (ravenscar_thread_target::resume)
1566         (ravenscar_thread_target::wait): Special case wildcard requests.
1567
1568 2019-02-15  Tom Tromey  <tromey@adacore.com>
1569
1570         * ravenscar-thread.c (base_ptid): Remove.
1571         (struct ravenscar_thread_target) <close>: New method.
1572         <m_base_ptid>: New member.
1573         <update_inferior_ptid, active_task, task_is_currently_active,
1574         runtime_initialized>: Declare methods.
1575         <ravenscar_thread_target>: Add constructor.
1576         (ravenscar_thread_target::task_is_currently_active)
1577         (ravenscar_thread_target::update_inferior_ptid)
1578         (ravenscar_runtime_initialized): Rename.  Now methods.
1579         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1580         (ravenscar_thread_target::update_thread_list): Update.
1581         (ravenscar_thread_target::active_task): Now method.
1582         (ravenscar_thread_target::store_registers)
1583         (ravenscar_thread_target::prepare_to_store)
1584         (ravenscar_thread_target::prepare_to_store)
1585         (ravenscar_thread_target::mourn_inferior): Update.
1586         (ravenscar_inferior_created): Use "new" to create target.
1587         (ravenscar_thread_target::get_ada_task_ptid): Update.
1588         (_initialize_ravenscar): Don't initialize base_ptid.
1589         (ravenscar_ops): Remove global.
1590
1591 2019-02-15  Tom Tromey  <tromey@adacore.com>
1592
1593         * target.h (push_target): Declare new overload.
1594         * target.c (push_target): New overload, taking an rvalue reference.
1595         * remote.c (remote_target::open_1): Use push_target overload.
1596         * corelow.c (core_target_open): Use push_target overload.
1597
1598 2019-02-15  Tom Tromey  <tromey@adacore.com>
1599
1600         * ravenscar-thread.c (is_ravenscar_task)
1601         (ravenscar_task_is_currently_active): Return bool.
1602         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1603         (_initialize_ravenscar): Remove "(void)".
1604         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1605         Return bool.
1606
1607 2019-02-15  Tom Tromey  <tromey@adacore.com>
1608
1609         * ravenscar-thread.c (ravenscar_runtime_initializer)
1610         (has_ravenscar_runtime, get_running_thread_id)
1611         (ravenscar_thread_target::resume): Fix indentation.
1612
1613 2019-02-15  Tom Tromey  <tromey@adacore.com>
1614
1615         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1616         from ravenscar_arch_ops.
1617         (sparc_ravenscar_ops::fetch_registers)
1618         (sparc_ravenscar_ops::store_registers): Now methods.
1619         (sparc_ravenscar_prepare_to_store): Remove.
1620         (sparc_ravenscar_ops): Redefine.
1621         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1622         methods and destructor.  Remove members.
1623         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1624         (ravenscar_thread_target::store_registers)
1625         (ravenscar_thread_target::prepare_to_store): Update.
1626         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1627         Remove.
1628         (struct ppc_ravenscar_powerpc_ops): Derive from
1629         ravenscar_arch_ops.
1630         (ppc_ravenscar_powerpc_ops::fetch_registers)
1631         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1632         (ppc_ravenscar_powerpc_ops): Redefine.
1633         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1634         (ppc_ravenscar_e500_ops::fetch_registers)
1635         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1636         (ppc_ravenscar_e500_ops): Redefine.
1637         * aarch64-ravenscar-thread.c
1638         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1639         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1640         (aarch64_ravenscar_fetch_registers)
1641         (aarch64_ravenscar_store_registers): Now methods.
1642         (aarch64_ravenscar_ops): Redefine.
1643
1644 2019-02-15  Tom Tromey  <tromey@adacore.com>
1645
1646         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1647         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1648         (ravenscar_thread_target::stopped_by_watchpoint)
1649         (ravenscar_thread_target::stopped_data_address)
1650         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1651
1652 2019-02-15  Tom Tromey  <tromey@adacore.com>
1653
1654         * ravenscar-thread.c: Fix some typos.
1655
1656 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1657             Tom Tromey  <tromey@adacore.com>
1658
1659         * ada-lang.c (ada_exception_sal): Change addr_string to a
1660         std::string.
1661         (create_ada_exception_catchpoint): Update.
1662
1663 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1664             Tom Tromey  <tromey@adacore.com>
1665
1666         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1667         (bp_location_ops): Remove.
1668         (base_breakpoint_allocate_location): Update.
1669         (free_bp_location): Update.
1670         * ada-lang.c (class ada_catchpoint_location)
1671         <ada_catchpoint_location>: Remove ops parameter.
1672         (ada_catchpoint_location_dtor): Remove.
1673         (ada_catchpoint_location_ops): Remove.
1674         (allocate_location_exception): Update.
1675         * breakpoint.h (struct bp_location_ops): Remove.
1676         (class bp_location) <bp_location>: Remove bp_location_ops
1677         parameter.
1678         <~bp_location>: Add destructor.
1679         <ops>: Remove.
1680
1681 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1682             Pedro Alves  <palves@redhat.com>
1683
1684         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1685         'PATH_MAX'.
1686
1687 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1688             Samuel Thibault  <samuel.thibault@gnu.org>
1689             Thomas Schwinge  <thomas@codesourcery.com>
1690
1691         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1692         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1693
1694 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1695
1696         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1697         (check_empty): Use "const char *".
1698
1699         * gnu-nat.c (gnu_nat_target::detach): Instead of
1700         'detach_inferior (pid)' call
1701         'detach_inferior (find_inferior_pid (pid))'.
1702
1703         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1704         'nat/fork-inferior.o'.
1705         * gnu-nat.c: #include "nat/fork-inferior.h".
1706
1707         * gnu-nat.c (gnu_nat_target::detach): Instead of
1708         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1709         * gnu-nat.h: #include "inf-child.h".
1710         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1711         'i386_gnu_nat_target::fetch_registers'.
1712         (gnu_store_registers): Rename/move to
1713         'i386_gnu_nat_target::store_registers'.
1714
1715         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1716         * gnu-nat.h (mach_thread_info): New function.
1717         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1718
1719         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1720
1721 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1722
1723         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1724
1725 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1726
1727         * windows-nat.c (windows_add_thread): Add new parameter
1728         "main_thread_p" with default value set to false.  Update
1729         function documentation as well as all callers.
1730         (windows_delete_thread): Likewise.
1731         (fake_create_process): Update call to windows_add_thread.
1732         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1733         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1734         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1735         call to windows_delete_thread.
1736
1737 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1738
1739         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1740
1741 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1742
1743         * symfile.c (find_separate_debug_file): Use canonical path of
1744         sysroot with child_path instead of gdb_sysroot if it is valid.
1745
1746 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1747
1748         * symfile.c (find_separate_debug_file): Use child_path to
1749         determine if an object file is under a sysroot.
1750
1751 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1752
1753         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1754         unittests/child-path-selftests.c.
1755         * common/pathstuff.c (child_path): New function.
1756         * common/pathstuff.h (child_path): New prototype.
1757         * unittests/child-path-selftests.c: New file.
1758
1759 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1760
1761         * symfile.c (find_separate_debug_file): Look for separate debug
1762         files in debug directories under the sysroot.
1763
1764 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1765
1766         * symtab.h (struct minimal_symbol data_p): New const method.
1767         (struct minimal_symbol text_p): Likewise.
1768         * symtab.c (output_source_filename): Use file name style
1769         to print file name.
1770         (print_symbol_info): Likewise.
1771         (print_msymbol_info): Use address style to print addresses.
1772         Use function name style to print executable text symbols.
1773         (expand_symtab_containing_pc): Use data_p.
1774         (find_pc_sect_compunit_symtab): Likewise.
1775
1776 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1777
1778         * breakpoint.c (describe_other_breakpoints): Use address style
1779         to print addresses.
1780         (say_where): Likewise.
1781
1782 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1783
1784         * ada-typeprint.c (print_func_type): Print function name
1785         style to print function name.
1786         * c-typeprint.c (c_print_type_1): Likewise.
1787
1788 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1789
1790         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1791         for execve.
1792
1793 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1794
1795         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1796         type_stack.
1797
1798 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1799
1800         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1801         TYPE_CODE_REF types.
1802
1803 2019-02-08  Jim Wilson  <jimw@sifive.com>
1804
1805         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1806         (riscv_linux_fregset): New.
1807         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1808
1809 2019-02-07  Tom Tromey  <tom@tromey.com>
1810
1811         * thread.c (thread_cancel_execution_command): Update.
1812         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1813         methods.
1814         (struct thread_fsm_ops): Remove.
1815         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1816         (thread_fsm_should_stop, thread_fsm_return_value)
1817         (thread_fsm_set_finished, thread_fsm_finished_p)
1818         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1819         Don't declare.
1820         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1821         * infrun.c (clear_proceed_status_thread)
1822         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1823         (print_stop_event): Update.
1824         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1825         Add constructor.
1826         (step_command_fsm_ops): Remove.
1827         (new_step_command_fsm): Remove.
1828         (step_1): Update.
1829         (step_command_fsm::should_stop): Rename from
1830         step_command_fsm_should_stop.
1831         (step_command_fsm::clean_up): Rename from
1832         step_command_fsm_clean_up.
1833         (step_command_fsm::do_async_reply_reason): Rename from
1834         step_command_fsm_async_reply_reason.
1835         (struct until_next_fsm): Inherit from thread_fsm.  Add
1836         constructor.
1837         (until_next_fsm_ops): Remove.
1838         (new_until_next_fsm): Remove.
1839         (until_next_fsm::should_stop): Rename from
1840         until_next_fsm_should_stop.
1841         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1842         (until_next_fsm::do_async_reply_reason): Rename from
1843         until_next_fsm_async_reply_reason.
1844         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1845         constructor.  Change type of breakpoint.
1846         (finish_command_fsm_ops): Remove.
1847         (new_finish_command_fsm): Remove.
1848         (finish_command_fsm::should_stop): Rename from
1849         finish_command_fsm_should_stop.
1850         (finish_command_fsm::clean_up): Rename from
1851         finish_command_fsm_clean_up.
1852         (finish_command_fsm::return_value): Rename from
1853         finish_command_fsm_return_value.
1854         (finish_command_fsm::do_async_reply_reason): Rename from
1855         finish_command_fsm_async_reply_reason.
1856         (finish_command): Update.
1857         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1858         Add constructor.
1859         (call_thread_fsm_ops): Remove.
1860         (call_thread_fsm::call_thread_fsm): Rename from
1861         new_call_thread_fsm.
1862         (call_thread_fsm::should_stop): Rename from
1863         call_thread_fsm_should_stop.
1864         (call_thread_fsm::should_notify_stop): Rename from
1865         call_thread_fsm_should_notify_stop.
1866         (run_inferior_call, call_function_by_hand_dummy): Update.
1867         * cli/cli-interp.c (should_print_stop_to_console): Update.
1868         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1869         Add constructor.  Change type of location_breakpoint,
1870         caller_breakpoint.
1871         (until_break_fsm_ops): Remove.
1872         (new_until_break_fsm): Remove.
1873         (until_break_fsm::should_stop): Rename from
1874         until_break_fsm_should_stop.
1875         (until_break_fsm::clean_up): Rename from
1876         until_break_fsm_clean_up.
1877         (until_break_fsm::do_async_reply_reason): Rename from
1878         until_break_fsm_async_reply_reason.
1879         (until_break_command): Update.
1880         * thread-fsm.c: Remove.
1881         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1882
1883 2019-02-07  Tom Tromey  <tom@tromey.com>
1884
1885         * yy-remap.h: Add include guard.
1886         * xtensa-tdep.h: Add include guard.
1887         * xcoffread.h: Rename include guard.
1888         * varobj-iter.h: Add include guard.
1889         * tui/tui.h: Rename include guard.
1890         * tui/tui-winsource.h: Rename include guard.
1891         * tui/tui-wingeneral.h: Rename include guard.
1892         * tui/tui-windata.h: Rename include guard.
1893         * tui/tui-win.h: Rename include guard.
1894         * tui/tui-stack.h: Rename include guard.
1895         * tui/tui-source.h: Rename include guard.
1896         * tui/tui-regs.h: Rename include guard.
1897         * tui/tui-out.h: Rename include guard.
1898         * tui/tui-layout.h: Rename include guard.
1899         * tui/tui-io.h: Rename include guard.
1900         * tui/tui-hooks.h: Rename include guard.
1901         * tui/tui-file.h: Rename include guard.
1902         * tui/tui-disasm.h: Rename include guard.
1903         * tui/tui-data.h: Rename include guard.
1904         * tui/tui-command.h: Rename include guard.
1905         * tic6x-tdep.h: Add include guard.
1906         * target/waitstatus.h: Rename include guard.
1907         * target/wait.h: Rename include guard.
1908         * target/target.h: Rename include guard.
1909         * target/resume.h: Rename include guard.
1910         * target-float.h: Rename include guard.
1911         * stabsread.h: Add include guard.
1912         * rs6000-tdep.h: Add include guard.
1913         * riscv-fbsd-tdep.h: Add include guard.
1914         * regformats/regdef.h: Rename include guard.
1915         * record.h: Rename include guard.
1916         * python/python.h: Rename include guard.
1917         * python/python-internal.h: Rename include guard.
1918         * python/py-stopevent.h: Rename include guard.
1919         * python/py-ref.h: Rename include guard.
1920         * python/py-record.h: Rename include guard.
1921         * python/py-record-full.h: Rename include guard.
1922         * python/py-record-btrace.h: Rename include guard.
1923         * python/py-instruction.h: Rename include guard.
1924         * python/py-events.h: Rename include guard.
1925         * python/py-event.h: Rename include guard.
1926         * procfs.h: Add include guard.
1927         * proc-utils.h: Add include guard.
1928         * p-lang.h: Add include guard.
1929         * or1k-tdep.h: Rename include guard.
1930         * observable.h: Rename include guard.
1931         * nto-tdep.h: Rename include guard.
1932         * nat/x86-linux.h: Rename include guard.
1933         * nat/x86-linux-dregs.h: Rename include guard.
1934         * nat/x86-gcc-cpuid.h: Add include guard.
1935         * nat/x86-dregs.h: Rename include guard.
1936         * nat/x86-cpuid.h: Rename include guard.
1937         * nat/ppc-linux.h: Rename include guard.
1938         * nat/mips-linux-watch.h: Rename include guard.
1939         * nat/linux-waitpid.h: Rename include guard.
1940         * nat/linux-ptrace.h: Rename include guard.
1941         * nat/linux-procfs.h: Rename include guard.
1942         * nat/linux-osdata.h: Rename include guard.
1943         * nat/linux-nat.h: Rename include guard.
1944         * nat/linux-namespaces.h: Rename include guard.
1945         * nat/linux-btrace.h: Rename include guard.
1946         * nat/glibc_thread_db.h: Rename include guard.
1947         * nat/gdb_thread_db.h: Rename include guard.
1948         * nat/gdb_ptrace.h: Rename include guard.
1949         * nat/fork-inferior.h: Rename include guard.
1950         * nat/amd64-linux-siginfo.h: Rename include guard.
1951         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1952         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1953         * nat/aarch64-linux.h: Rename include guard.
1954         * nat/aarch64-linux-hw-point.h: Rename include guard.
1955         * mn10300-tdep.h: Add include guard.
1956         * mips-linux-tdep.h: Add include guard.
1957         * mi/mi-parse.h: Rename include guard.
1958         * mi/mi-out.h: Rename include guard.
1959         * mi/mi-main.h: Rename include guard.
1960         * mi/mi-interp.h: Rename include guard.
1961         * mi/mi-getopt.h: Rename include guard.
1962         * mi/mi-console.h: Rename include guard.
1963         * mi/mi-common.h: Rename include guard.
1964         * mi/mi-cmds.h: Rename include guard.
1965         * mi/mi-cmd-break.h: Rename include guard.
1966         * m2-lang.h: Add include guard.
1967         * location.h: Rename include guard.
1968         * linux-record.h: Rename include guard.
1969         * linux-nat.h: Add include guard.
1970         * linux-fork.h: Add include guard.
1971         * i386-darwin-tdep.h: Rename include guard.
1972         * hppa-linux-offsets.h: Add include guard.
1973         * guile/guile.h: Rename include guard.
1974         * guile/guile-internal.h: Rename include guard.
1975         * gnu-nat.h: Rename include guard.
1976         * gdb-stabs.h: Rename include guard.
1977         * frv-tdep.h: Add include guard.
1978         * f-lang.h: Add include guard.
1979         * event-loop.h: Add include guard.
1980         * darwin-nat.h: Rename include guard.
1981         * cp-abi.h: Rename include guard.
1982         * config/sparc/nm-sol2.h: Rename include guard.
1983         * config/nm-nto.h: Rename include guard.
1984         * config/nm-linux.h: Add include guard.
1985         * config/i386/nm-i386gnu.h: Rename include guard.
1986         * config/djgpp/nl_types.h: Rename include guard.
1987         * config/djgpp/langinfo.h: Rename include guard.
1988         * compile/gcc-cp-plugin.h: Add include guard.
1989         * compile/gcc-c-plugin.h: Add include guard.
1990         * compile/compile.h: Rename include guard.
1991         * compile/compile-object-run.h: Rename include guard.
1992         * compile/compile-object-load.h: Rename include guard.
1993         * compile/compile-internal.h: Rename include guard.
1994         * compile/compile-cplus.h: Rename include guard.
1995         * compile/compile-c.h: Rename include guard.
1996         * common/xml-utils.h: Rename include guard.
1997         * common/x86-xstate.h: Rename include guard.
1998         * common/version.h: Rename include guard.
1999         * common/vec.h: Rename include guard.
2000         * common/tdesc.h: Rename include guard.
2001         * common/selftest.h: Rename include guard.
2002         * common/scoped_restore.h: Rename include guard.
2003         * common/scoped_mmap.h: Rename include guard.
2004         * common/scoped_fd.h: Rename include guard.
2005         * common/safe-iterator.h: Rename include guard.
2006         * common/run-time-clock.h: Rename include guard.
2007         * common/refcounted-object.h: Rename include guard.
2008         * common/queue.h: Rename include guard.
2009         * common/ptid.h: Rename include guard.
2010         * common/print-utils.h: Rename include guard.
2011         * common/preprocessor.h: Rename include guard.
2012         * common/pathstuff.h: Rename include guard.
2013         * common/observable.h: Rename include guard.
2014         * common/netstuff.h: Rename include guard.
2015         * common/job-control.h: Rename include guard.
2016         * common/host-defs.h: Rename include guard.
2017         * common/gdb_wait.h: Rename include guard.
2018         * common/gdb_vecs.h: Rename include guard.
2019         * common/gdb_unlinker.h: Rename include guard.
2020         * common/gdb_unique_ptr.h: Rename include guard.
2021         * common/gdb_tilde_expand.h: Rename include guard.
2022         * common/gdb_sys_time.h: Rename include guard.
2023         * common/gdb_string_view.h: Rename include guard.
2024         * common/gdb_splay_tree.h: Rename include guard.
2025         * common/gdb_setjmp.h: Rename include guard.
2026         * common/gdb_ref_ptr.h: Rename include guard.
2027         * common/gdb_optional.h: Rename include guard.
2028         * common/gdb_locale.h: Rename include guard.
2029         * common/gdb_assert.h: Rename include guard.
2030         * common/filtered-iterator.h: Rename include guard.
2031         * common/filestuff.h: Rename include guard.
2032         * common/fileio.h: Rename include guard.
2033         * common/environ.h: Rename include guard.
2034         * common/common-utils.h: Rename include guard.
2035         * common/common-types.h: Rename include guard.
2036         * common/common-regcache.h: Rename include guard.
2037         * common/common-inferior.h: Rename include guard.
2038         * common/common-gdbthread.h: Rename include guard.
2039         * common/common-exceptions.h: Rename include guard.
2040         * common/common-defs.h: Rename include guard.
2041         * common/common-debug.h: Rename include guard.
2042         * common/cleanups.h: Rename include guard.
2043         * common/buffer.h: Rename include guard.
2044         * common/btrace-common.h: Rename include guard.
2045         * common/break-common.h: Rename include guard.
2046         * cli/cli-utils.h: Rename include guard.
2047         * cli/cli-style.h: Rename include guard.
2048         * cli/cli-setshow.h: Rename include guard.
2049         * cli/cli-script.h: Rename include guard.
2050         * cli/cli-interp.h: Rename include guard.
2051         * cli/cli-decode.h: Rename include guard.
2052         * cli/cli-cmds.h: Rename include guard.
2053         * charset-list.h: Add include guard.
2054         * buildsym-legacy.h: Rename include guard.
2055         * bfin-tdep.h: Add include guard.
2056         * ax.h: Rename include guard.
2057         * arm-linux-tdep.h: Add include guard.
2058         * arm-fbsd-tdep.h: Add include guard.
2059         * arch/xtensa.h: Rename include guard.
2060         * arch/tic6x.h: Add include guard.
2061         * arch/i386.h: Add include guard.
2062         * arch/arm.h: Rename include guard.
2063         * arch/arm-linux.h: Rename include guard.
2064         * arch/arm-get-next-pcs.h: Rename include guard.
2065         * arch/amd64.h: Add include guard.
2066         * arch/aarch64-insn.h: Rename include guard.
2067         * arch-utils.h: Rename include guard.
2068         * annotate.h: Add include guard.
2069         * amd64-darwin-tdep.h: Rename include guard.
2070         * aarch64-linux-tdep.h: Add include guard.
2071         * aarch64-fbsd-tdep.h: Add include guard.
2072         * aarch32-linux-nat.h: Add include guard.
2073
2074 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2075
2076         * macrotab.c (macro_define_internal): New function that
2077         factorizes macro_define_object_internal and macro_define_function
2078         code.
2079         (macro_define_object_internal): Use macro_define_internal.
2080         (macro_define_function): Likewise.
2081
2082 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2083
2084         * macrocmd.c (extract_identifier): Return
2085         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2086         callers.
2087
2088 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2089
2090         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2091
2092 2019-02-05  Tom Tromey  <tom@tromey.com>
2093
2094         * target.c (target_stack::unpush): Move assertion earlier.
2095
2096 2019-01-30  Tom Tromey  <tom@tromey.com>
2097
2098         PR python/23615:
2099         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2100         (gdbpy_parse_and_eval): Likewise.
2101         * python/python-internal.h (gdbpy_allow_threads): New class.
2102
2103 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2104
2105         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2106         (aarch64_fbsd_fpregmap): Move earlier.
2107         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2108         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2109         instead of individual calls to trad_frame_set_reg_addr.
2110         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2111         earlier.
2112         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2113         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2114         instead of individual calls to trad_frame_set_reg_addr.
2115
2116 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2117
2118         * CONTRIBUTE: Replace contribution list with wiki link.
2119
2120 2019-01-25  Tom Tromey  <tom@tromey.com>
2121
2122         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2123
2124 2019-01-25  Tom Tromey  <tom@tromey.com>
2125
2126         * xtensa-linux-nat.c: Fix common/ includes.
2127         * xml-support.h: Fix common/ includes.
2128         * xml-support.c: Fix common/ includes.
2129         * x86-linux-nat.c: Fix common/ includes.
2130         * windows-nat.c: Fix common/ includes.
2131         * varobj.h: Fix common/ includes.
2132         * varobj.c: Fix common/ includes.
2133         * value.c: Fix common/ includes.
2134         * valops.c: Fix common/ includes.
2135         * utils.c: Fix common/ includes.
2136         * unittests/xml-utils-selftests.c: Fix common/ includes.
2137         * unittests/utils-selftests.c: Fix common/ includes.
2138         * unittests/unpack-selftests.c: Fix common/ includes.
2139         * unittests/tracepoint-selftests.c: Fix common/ includes.
2140         * unittests/style-selftests.c: Fix common/ includes.
2141         * unittests/string_view-selftests.c: Fix common/ includes.
2142         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2143         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2144         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2145         * unittests/rsp-low-selftests.c: Fix common/ includes.
2146         * unittests/parse-connection-spec-selftests.c: Fix common/
2147         includes.
2148         * unittests/optional-selftests.c: Fix common/ includes.
2149         * unittests/offset-type-selftests.c: Fix common/ includes.
2150         * unittests/observable-selftests.c: Fix common/ includes.
2151         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2152         * unittests/memrange-selftests.c: Fix common/ includes.
2153         * unittests/memory-map-selftests.c: Fix common/ includes.
2154         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2155         * unittests/function-view-selftests.c: Fix common/ includes.
2156         * unittests/environ-selftests.c: Fix common/ includes.
2157         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2158         * unittests/common-utils-selftests.c: Fix common/ includes.
2159         * unittests/cli-utils-selftests.c: Fix common/ includes.
2160         * unittests/array-view-selftests.c: Fix common/ includes.
2161         * ui-file.c: Fix common/ includes.
2162         * tui/tui-io.c: Fix common/ includes.
2163         * tracepoint.h: Fix common/ includes.
2164         * tracepoint.c: Fix common/ includes.
2165         * tracefile-tfile.c: Fix common/ includes.
2166         * top.h: Fix common/ includes.
2167         * top.c: Fix common/ includes.
2168         * thread.c: Fix common/ includes.
2169         * target/waitstatus.h: Fix common/ includes.
2170         * target/waitstatus.c: Fix common/ includes.
2171         * target.h: Fix common/ includes.
2172         * target.c: Fix common/ includes.
2173         * target-memory.c: Fix common/ includes.
2174         * target-descriptions.c: Fix common/ includes.
2175         * symtab.h: Fix common/ includes.
2176         * symfile.c: Fix common/ includes.
2177         * stap-probe.c: Fix common/ includes.
2178         * spu-linux-nat.c: Fix common/ includes.
2179         * sparc-nat.c: Fix common/ includes.
2180         * source.c: Fix common/ includes.
2181         * solib.c: Fix common/ includes.
2182         * solib-target.c: Fix common/ includes.
2183         * ser-unix.c: Fix common/ includes.
2184         * ser-tcp.c: Fix common/ includes.
2185         * ser-pipe.c: Fix common/ includes.
2186         * ser-base.c: Fix common/ includes.
2187         * selftest-arch.c: Fix common/ includes.
2188         * s12z-tdep.c: Fix common/ includes.
2189         * rust-exp.y: Fix common/ includes.
2190         * rs6000-aix-tdep.c: Fix common/ includes.
2191         * riscv-tdep.c: Fix common/ includes.
2192         * remote.c: Fix common/ includes.
2193         * remote-notif.h: Fix common/ includes.
2194         * remote-fileio.h: Fix common/ includes.
2195         * remote-fileio.c: Fix common/ includes.
2196         * regcache.h: Fix common/ includes.
2197         * regcache.c: Fix common/ includes.
2198         * record-btrace.c: Fix common/ includes.
2199         * python/python.c: Fix common/ includes.
2200         * python/py-type.c: Fix common/ includes.
2201         * python/py-inferior.c: Fix common/ includes.
2202         * progspace.h: Fix common/ includes.
2203         * producer.c: Fix common/ includes.
2204         * procfs.c: Fix common/ includes.
2205         * proc-api.c: Fix common/ includes.
2206         * printcmd.c: Fix common/ includes.
2207         * ppc-linux-nat.c: Fix common/ includes.
2208         * parser-defs.h: Fix common/ includes.
2209         * osdata.c: Fix common/ includes.
2210         * obsd-nat.c: Fix common/ includes.
2211         * nat/x86-linux.c: Fix common/ includes.
2212         * nat/x86-linux-dregs.c: Fix common/ includes.
2213         * nat/x86-dregs.h: Fix common/ includes.
2214         * nat/x86-dregs.c: Fix common/ includes.
2215         * nat/ppc-linux.c: Fix common/ includes.
2216         * nat/mips-linux-watch.h: Fix common/ includes.
2217         * nat/mips-linux-watch.c: Fix common/ includes.
2218         * nat/linux-waitpid.c: Fix common/ includes.
2219         * nat/linux-ptrace.h: Fix common/ includes.
2220         * nat/linux-ptrace.c: Fix common/ includes.
2221         * nat/linux-procfs.c: Fix common/ includes.
2222         * nat/linux-personality.c: Fix common/ includes.
2223         * nat/linux-osdata.c: Fix common/ includes.
2224         * nat/linux-namespaces.c: Fix common/ includes.
2225         * nat/linux-btrace.h: Fix common/ includes.
2226         * nat/linux-btrace.c: Fix common/ includes.
2227         * nat/fork-inferior.c: Fix common/ includes.
2228         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2229         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2230         * nat/aarch64-linux.c: Fix common/ includes.
2231         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2232         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2233         * namespace.h: Fix common/ includes.
2234         * mips-linux-tdep.c: Fix common/ includes.
2235         * minsyms.c: Fix common/ includes.
2236         * mi/mi-parse.h: Fix common/ includes.
2237         * mi/mi-main.c: Fix common/ includes.
2238         * mi/mi-cmd-env.c: Fix common/ includes.
2239         * memrange.h: Fix common/ includes.
2240         * memattr.c: Fix common/ includes.
2241         * maint.h: Fix common/ includes.
2242         * maint.c: Fix common/ includes.
2243         * main.c: Fix common/ includes.
2244         * machoread.c: Fix common/ includes.
2245         * location.c: Fix common/ includes.
2246         * linux-thread-db.c: Fix common/ includes.
2247         * linux-nat.c: Fix common/ includes.
2248         * linux-fork.c: Fix common/ includes.
2249         * inline-frame.c: Fix common/ includes.
2250         * infrun.c: Fix common/ includes.
2251         * inflow.c: Fix common/ includes.
2252         * inferior.h: Fix common/ includes.
2253         * inferior.c: Fix common/ includes.
2254         * infcmd.c: Fix common/ includes.
2255         * inf-ptrace.c: Fix common/ includes.
2256         * inf-child.c: Fix common/ includes.
2257         * ia64-linux-nat.c: Fix common/ includes.
2258         * i387-tdep.c: Fix common/ includes.
2259         * i386-tdep.c: Fix common/ includes.
2260         * i386-linux-tdep.c: Fix common/ includes.
2261         * i386-linux-nat.c: Fix common/ includes.
2262         * i386-go32-tdep.c: Fix common/ includes.
2263         * i386-fbsd-tdep.c: Fix common/ includes.
2264         * i386-fbsd-nat.c: Fix common/ includes.
2265         * guile/scm-type.c: Fix common/ includes.
2266         * guile/guile.c: Fix common/ includes.
2267         * go32-nat.c: Fix common/ includes.
2268         * gnu-nat.c: Fix common/ includes.
2269         * gdbthread.h: Fix common/ includes.
2270         * gdbarch-selftests.c: Fix common/ includes.
2271         * gdb_usleep.c: Fix common/ includes.
2272         * gdb_select.h: Fix common/ includes.
2273         * gdb_bfd.c: Fix common/ includes.
2274         * gcore.c: Fix common/ includes.
2275         * fork-child.c: Fix common/ includes.
2276         * findvar.c: Fix common/ includes.
2277         * fbsd-nat.c: Fix common/ includes.
2278         * event-top.c: Fix common/ includes.
2279         * event-loop.c: Fix common/ includes.
2280         * dwarf2read.c: Fix common/ includes.
2281         * dwarf2loc.c: Fix common/ includes.
2282         * dwarf2-frame.c: Fix common/ includes.
2283         * dwarf-index-cache.c: Fix common/ includes.
2284         * dtrace-probe.c: Fix common/ includes.
2285         * disasm-selftests.c: Fix common/ includes.
2286         * defs.h: Fix common/ includes.
2287         * csky-tdep.c: Fix common/ includes.
2288         * cp-valprint.c: Fix common/ includes.
2289         * cp-support.h: Fix common/ includes.
2290         * cp-support.c: Fix common/ includes.
2291         * corelow.c: Fix common/ includes.
2292         * completer.h: Fix common/ includes.
2293         * completer.c: Fix common/ includes.
2294         * compile/compile.c: Fix common/ includes.
2295         * compile/compile-loc2c.c: Fix common/ includes.
2296         * compile/compile-cplus-types.c: Fix common/ includes.
2297         * compile/compile-cplus-symbols.c: Fix common/ includes.
2298         * command.h: Fix common/ includes.
2299         * cli/cli-dump.c: Fix common/ includes.
2300         * cli/cli-cmds.c: Fix common/ includes.
2301         * charset.c: Fix common/ includes.
2302         * build-id.c: Fix common/ includes.
2303         * btrace.h: Fix common/ includes.
2304         * btrace.c: Fix common/ includes.
2305         * breakpoint.h: Fix common/ includes.
2306         * breakpoint.c: Fix common/ includes.
2307         * ax.h:
2308         (enum agent_op): Fix common/ includes.
2309         * ax-general.c (struct aop_map): Fix common/ includes.
2310         * ax-gdb.c: Fix common/ includes.
2311         * auxv.c: Fix common/ includes.
2312         * auto-load.c: Fix common/ includes.
2313         * arm-tdep.c: Fix common/ includes.
2314         * arch/riscv.c: Fix common/ includes.
2315         * arch/ppc-linux-common.c: Fix common/ includes.
2316         * arch/i386.c: Fix common/ includes.
2317         * arch/arm.c: Fix common/ includes.
2318         * arch/arm-linux.c: Fix common/ includes.
2319         * arch/arm-get-next-pcs.c: Fix common/ includes.
2320         * arch/amd64.c: Fix common/ includes.
2321         * arch/aarch64.c: Fix common/ includes.
2322         * arch/aarch64-insn.c: Fix common/ includes.
2323         * arch-utils.c: Fix common/ includes.
2324         * amd64-windows-tdep.c: Fix common/ includes.
2325         * amd64-tdep.c: Fix common/ includes.
2326         * amd64-sol2-tdep.c: Fix common/ includes.
2327         * amd64-obsd-tdep.c: Fix common/ includes.
2328         * amd64-nbsd-tdep.c: Fix common/ includes.
2329         * amd64-linux-tdep.c: Fix common/ includes.
2330         * amd64-linux-nat.c: Fix common/ includes.
2331         * amd64-fbsd-tdep.c: Fix common/ includes.
2332         * amd64-fbsd-nat.c: Fix common/ includes.
2333         * amd64-dicos-tdep.c: Fix common/ includes.
2334         * amd64-darwin-tdep.c: Fix common/ includes.
2335         * agent.c: Fix common/ includes.
2336         * ada-lang.h: Fix common/ includes.
2337         * ada-lang.c: Fix common/ includes.
2338         * aarch64-tdep.c: Fix common/ includes.
2339
2340 2019-01-25  Tom Tromey  <tom@tromey.com>
2341
2342         * common/create-version.sh: Use common/version.h.
2343
2344 2019-01-24  Pedro Alves  <palves@redhat.com>
2345
2346         * infrun.c (signal_stop, signal_print, signal_program)
2347         (signal_catch, signal_pass): Now arrays instead of pointers.
2348         (update_signals_program_target, do_target_resume)
2349         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2350         * linux-nat.c (linux_nat_target::pass_signals)
2351         (linux_nat_target::create_inferior, linux_nat_target::attach):
2352         Adjust.
2353         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2354         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2355         * procfs.c (procfs_target::pass_signals): Adjust.
2356         * record-full.c (record_full_target::resume): Adjust.
2357         * remote.c (remote_target::pass_signals)
2358         (remote_target::program_signals): Adjust.
2359         * target-debug.h (target_debug_print_signals): Now takes a
2360         gdb::array_view as parameter.  Adjust.
2361         * target.h (target_ops) <pass_signals, program_signals>: Replace
2362         pointer and length parameters with gdb::array_view.
2363         (target_pass_signals, target_program_signals): Likewise.
2364         * target-delegates.c: Regenerate.
2365
2366 2019-01-24  Pedro Alves  <palves@redhat.com>
2367
2368         * common/forward-scope-exit.h
2369         (forward_scope_exit::forward_scope_exit): Pass arguments to
2370         m_bind_function directly, instead of creating a std::bind and
2371         copying that.
2372
2373 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2374
2375         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2376         for static members.
2377         (pass_in_v_vfp_candidate): Likewise.
2378
2379 2019-01-23  Tom Tromey  <tom@tromey.com>
2380             Pedro Alves  <palves@redhat.com>
2381
2382         * regcache.c (class regcache_invalidator): Remove.
2383         (regcache::raw_write): Use make_scope_exit.
2384
2385 2019-01-23  Tom Tromey  <tom@tromey.com>
2386
2387         * ui-out.h (class ui_out_emit_type): Update comment.
2388
2389 2019-01-23  Tom Tromey  <tom@tromey.com>
2390
2391         * infrun.c (fetch_inferior_event): Update comment.
2392
2393 2019-01-23  Tom Tromey  <tom@tromey.com>
2394             Pedro Alves  <palves@redhat.com>
2395
2396         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2397         parameter.
2398         (fetch_inferior_event): Use SCOPE_EXIT.
2399
2400
2401 2019-01-23  Tom Tromey  <tom@tromey.com>
2402             Pedro Alves  <palves@redhat.com>
2403
2404         * infrun.c (disable_thread_events): Delete.
2405         (stop_all_threads): Use SCOPE_EXIT.
2406
2407 2019-01-23  Tom Tromey  <tom@tromey.com>
2408             Pedro Alves  <palves@redhat.com>
2409
2410         * symfile.c: Include forward-scope-exit.h.
2411         (clear_symtab_users_cleanup): Replace forward declaration with
2412         a FORWARD_SCOPE_EXIT.
2413         (syms_from_objfile_1): Use the forward_scope_exit and
2414         gdb::optional instead of cleanup_function.
2415         (reread_symbols): Use the forward_scope_exit instead of
2416         cleanup_function.
2417         (clear_symtab_users_cleanup): Remove function.
2418
2419 2019-01-23  Tom Tromey  <tom@tromey.com>
2420             Pedro Alves  <palves@redhat.com>
2421
2422         * linux-nat.c: Include scope-exit.h.
2423         (cleanup_target_stop): Remove.
2424         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2425         SCOPE_EXIT.
2426
2427 2019-01-23  Tom Tromey  <tom@tromey.com>
2428             Pedro Alves  <palves@redhat.com>
2429
2430         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2431         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2432
2433 2019-01-23  Tom Tromey  <tom@tromey.com>
2434             Andrew Burgess  <andrew.burgess@embecosm.com>
2435             Pedro Alves  <palves@redhat.com>
2436
2437         * infrun.c (fetch_inferior_event): Use scope_exit.
2438         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2439         * top.c (execute_command): Use scope_exit.
2440         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2441         * utils.c (do_bpstat_clear_actions_cleanup)
2442         (make_bpstat_clear_actions_cleanup): Remove.
2443
2444 2019-01-23  Tom Tromey  <tom@tromey.com>
2445             Pedro Alves  <palves@redhat.com>
2446
2447         * infrun.c: Include "common/scope-exit.h"
2448         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2449         (wait_for_inferior): Use SCOPE_EXIT.
2450         (fetch_inferior_event): Use scope_exit.
2451
2452 2019-01-23  Tom Tromey  <tom@tromey.com>
2453             Pedro Alves  <palves@redhat.com>
2454
2455         * breakpoint.c (create_breakpoint): Remove cleanup.
2456
2457 2019-01-23  Tom Tromey  <tom@tromey.com>
2458             Andrew Burgess  <andrew.burgess@embecosm.com>
2459             Pedro Alves  <palves@redhat.com>
2460
2461 2019-01-23  Pedro Alves  <palves@redhat.com>
2462
2463         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2464
2465 2019-01-23  Pedro Alves  <palves@redhat.com>
2466             Andrew Burgess  <andrew.burgess@embecosm.com>
2467
2468         * gdbthread.h: Include "common/forward-scope-exit.h".
2469         (scoped_finish_thread_state): Redefine custom class in terms of
2470         forward_scope_exit.
2471
2472 2019-01-23  Pedro Alves  <palves@redhat.com>
2473             Andrew Burgess  <andrew.burgess@embecosm.com>
2474
2475         * common/forward-scope-exit.h: New file.
2476
2477 2019-01-23  Pedro Alves  <palves@redhat.com>
2478             Andrew Burgess  <andrew.burgess@embecosm.com>
2479             Tom Tromey  <tom@tromey.com>
2480
2481         * common/scope-exit.h: New file.
2482
2483 2019-01-23  Pedro Alves  <palves@redhat.com>
2484
2485         * common/preprocessor.h (ESC): Rename to ...
2486         (ESC_PARENS): ... this.
2487         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2488         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2489
2490 2019-01-23  Tom Tromey  <tom@tromey.com>
2491
2492         * language.h (class scoped_switch_to_sym_language_if_auto):
2493         Initialize m_lang in both cases.
2494
2495 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2496
2497         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2498         with XCNEW.
2499
2500 2019-01-22  Tom Tromey  <tom@tromey.com>
2501
2502         * corelow.c: Do not include sys/file.h.
2503
2504 2019-01-22  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui-wingeneral.h: Include gdb_curses.h.
2507
2508 2019-01-22  Tom Tromey  <tom@tromey.com>
2509
2510         * source-cache.h (class source_cache) <get_source_lines,
2511         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2512
2513 2019-01-22  Tom Tromey  <tom@tromey.com>
2514
2515         * remote-fileio.h (struct remote_target): Declare.
2516
2517 2019-01-22  Tom Tromey  <tom@tromey.com>
2518
2519         * python/py-arch.c: Do not include py-ref.h.
2520         * python/py-bpevent.c: Do not include py-ref.h.
2521         * python/py-cmd.c: Do not include py-ref.h.
2522         * python/py-continueevent.c: Do not include py-ref.h.
2523         * python/py-event.h: Do not include py-ref.h.
2524         * python/py-evtregistry.c: Do not include py-ref.h.
2525         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2526         * python/py-frame.c: Do not include py-ref.h.
2527         * python/py-framefilter.c: Do not include py-ref.h.
2528         * python/py-function.c: Do not include py-ref.h.
2529         * python/py-infevents.c: Do not include py-ref.h.
2530         * python/py-linetable.c: Do not include py-ref.h.
2531         * python/py-objfile.c: Do not include py-ref.h.
2532         * python/py-param.c: Do not include py-ref.h.
2533         * python/py-prettyprint.c: Do not include py-ref.h.
2534         * python/py-progspace.c: Do not include py-ref.h.
2535         * python/py-symbol.c: Do not include py-ref.h.
2536         * python/py-symtab.c: Do not include py-ref.h.
2537         * python/py-type.c: Do not include py-ref.h.
2538         * python/py-unwind.c: Do not include py-ref.h.
2539         * python/py-utils.c: Do not include py-ref.h.
2540         * python/py-value.c: Do not include py-ref.h.
2541         * python/py-varobj.c: Do not include py-ref.h.
2542         * python/py-xmethods.c: Do not include py-ref.h.
2543         * python/python.c: Do not include py-ref.h.
2544         * varobj.c: Do not include py-ref.h.
2545
2546 2019-01-22  Tom Tromey  <tom@tromey.com>
2547
2548         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2549         keyword for bcache.
2550
2551 2019-01-22  Tom Tromey  <tom@tromey.com>
2552
2553         * compile/compile-cplus-types.c: Remove a comment by #include.
2554
2555 2019-01-22  Tom Tromey  <tom@tromey.com>
2556
2557         * compile/gcc-c-plugin.h: Include compile-internal.h.
2558
2559 2019-01-22  Tom Tromey  <tom@tromey.com>
2560
2561         * stabsread.c (EXTERN): Do not define.
2562         (symnum, next_symbol_text_func, processing_gcc_compilation)
2563         (within_function, global_sym_chain, global_stabs)
2564         (previous_stab_code, this_object_header_files)
2565         (n_this_object_header_files)
2566         (n_allocated_this_object_header_files): Define.
2567         * stabsread.h (EXTERN): Never define.  Use "extern".
2568
2569 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2570
2571         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2572         history_value.
2573
2574 2019-01-21  Tom Tromey  <tom@tromey.com>
2575
2576         * ui-out.c: Fix includes.
2577         * tui/tui-source.c: Fix includes.
2578         * target.c: Fix includes.
2579         * remote.c: Fix includes.
2580         * regcache.c: Fix includes.
2581         * python/py-block.c: Fix includes.
2582         * printcmd.c: Fix includes.
2583         * or1k-tdep.c: Fix includes.
2584         * mi/mi-main.c: Fix includes.
2585         * m32r-tdep.c: Fix includes.
2586         * csky-tdep.c: Fix includes.
2587         * compile/compile-cplus-types.c: Fix includes.
2588         * cli/cli-interp.c: Fix includes.
2589
2590 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2591
2592         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2593         for padding.
2594
2595 2019-01-16  Tom Tromey  <tom@tromey.com>
2596
2597         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2598         earlier.
2599         (struct objfile) <msymbols_range>: Move from top level.
2600         <msymbols>: New method.
2601         (class objfile_msymbols): Remove.
2602         * symtab.c (default_collect_symbol_completion_matches_break_on):
2603         Update.
2604         * symmisc.c (dump_msymbols): Update.
2605         * stabsread.c (scan_file_globals): Update.
2606         * objc-lang.c (info_selectors_command, info_classes_command)
2607         (find_methods): Update.
2608         * minsyms.c (find_solib_trampoline_target): Update.
2609         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2610         * coffread.c (coff_symfile_read): Update.
2611         * ada-lang.c (ada_lookup_simple_minsym)
2612         (ada_collect_symbol_completion_matches): Update.
2613
2614 2019-01-16  Tom Tromey  <tom@tromey.com>
2615
2616         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2617         type.  Remove no-argument constructor.
2618         <iterator::operator++>: Simplify.
2619         <begin>: Update.
2620         <end>: Use minimal_symbol_count.
2621
2622 2019-01-16  Tom Tromey  <tom@tromey.com>
2623
2624         * objfiles.h (struct objfile) <psymtabs>: New method.
2625         (class objfile_psymtabs): Remove.
2626         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2627         typedef.
2628         <range>: New method.
2629         (require_partial_symbols): Change return type.
2630         * psymtab.c (require_partial_symbols)
2631         (psym_expand_symtabs_matching): Update.
2632         * mdebugread.c (parse_partial_symbols): Update.
2633         * dbxread.c (dbx_end_psymtab): Update.
2634
2635 2019-01-15  Tom Tromey  <tom@tromey.com>
2636
2637         * symtab.c (lookup_objfile_from_block)
2638         (lookup_symbol_in_objfile_symtabs)
2639         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2640         (find_line_symtab, info_sources_command)
2641         (default_collect_symbol_completion_matches_break_on)
2642         (make_source_files_completion_list): Update.
2643         * symmisc.c (print_objfile_statistics, dump_objfile)
2644         (maintenance_print_symbols, maintenance_info_symtabs)
2645         (maintenance_check_symtabs, maintenance_info_line_tables):
2646         Update.
2647         * source.c (select_source_symtab)
2648         (forget_cached_source_info_for_objfile): Update.
2649         * objfiles.h (class objfile_compunits): Remove.
2650         (struct objfile) <compunits_range>: New typedef.
2651         (compunits): New method.
2652         * objfiles.c (objfile_relocate1): Update.
2653         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2654         * maint.c (count_symtabs_and_blocks): Update.
2655         * linespec.c (iterate_over_all_matching_symtabs): Update.
2656         * cp-support.c (add_symbol_overload_list_qualified): Update.
2657         * coffread.c (coff_symtab_read): Update.
2658         * ada-lang.c (add_nonlocal_symbols)
2659         (ada_collect_symbol_completion_matches)
2660         (ada_add_global_exceptions): Update.
2661
2662 2019-01-15  Tom Tromey  <tom@tromey.com>
2663
2664         * progspace.h (program_space) <objfiles_safe_range>: New
2665         typedef.
2666         <objfiles_safe>: New method.
2667         * objfiles.h (class all_objfiles_safe): Remove.
2668         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2669         * jit.c (jit_inferior_exit_hook): Update.
2670
2671 2019-01-17  Tom Tromey  <tom@tromey.com>
2672
2673         * progspace.h (program_space) <objfiles_range>: New typedef.
2674         <objfiles>: New method.
2675         <objfiles_head>: Rename from objfiles.
2676         (object_files): Update.
2677         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2678         * guile/scm-pretty-print.c
2679         (ppscm_find_pretty_printer_from_objfiles): Update.
2680         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2681         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2682         Update.
2683         * python/py-progspace.c (pspy_get_objfiles): Update.
2684         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2685         Update.
2686         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2687         (objfpy_lookup_objfile_by_build_id): Update.
2688         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2689         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2690         Update.
2691         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2692         (expand_symtab_containing_pc, lookup_objfile_from_block)
2693         (lookup_static_symbol, basic_lookup_transparent_type)
2694         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2695         (find_line_symtab, info_sources_command)
2696         (default_collect_symbol_completion_matches_break_on)
2697         (make_source_files_completion_list, find_main_name): Update.
2698         * symmisc.c (print_symbol_bcache_statistics)
2699         (print_objfile_statistics, maintenance_print_symbols)
2700         (maintenance_print_msymbols, maintenance_print_objfiles)
2701         (maintenance_info_symtabs, maintenance_check_symtabs)
2702         (maintenance_expand_symtabs, maintenance_info_line_tables):
2703         Update.
2704         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2705         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2706         (map_overlay_command, unmap_overlay_command)
2707         (simple_overlay_update, expand_symtabs_matching)
2708         (map_symbol_filenames): Update.
2709         * symfile-debug.c (set_debug_symfile): Update.
2710         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2711         Update.
2712         * source.c (select_source_symtab, forget_cached_source_info):
2713         Update.
2714         * solib.c (solib_read_symbols): Update.
2715         * solib-spu.c (append_ocl_sos): Update.
2716         * psymtab.c (maintenance_print_psymbols)
2717         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2718         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2719         * printcmd.c (info_symbol_command): Update.
2720         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2721         Update.
2722         * objfiles.h (class all_objfiles): Remove.
2723         * objfiles.c (have_partial_symbols, have_full_symbols)
2724         (have_minimal_symbols, qsort_cmp, update_section_map)
2725         (shared_objfile_contains_address_p)
2726         (default_iterate_over_objfiles_in_search_order): Update.
2727         * objc-lang.c (info_selectors_command, info_classes_command)
2728         (find_methods): Update.
2729         * minsyms.c (find_solib_trampoline_target): Update.
2730         * maint.c (maintenance_info_sections)
2731         (maintenance_translate_address, count_symtabs_and_blocks):
2732         Update.
2733         * main.c (captured_main_1): Update.
2734         * linux-thread-db.c (try_thread_db_load_from_pdir)
2735         (has_libpthread): Update.
2736         * linespec.c (iterate_over_all_matching_symtabs)
2737         (search_minsyms_for_name): Update.
2738         * jit.c (jit_find_objf_with_entry_addr): Update.
2739         * hppa-tdep.c (find_unwind_entry)
2740         (hppa_lookup_stub_minimal_symbol): Update.
2741         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2742         Update.
2743         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2744         (elf_gnu_ifunc_resolve_by_got): Update.
2745         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2746         * dwarf-index-write.c (save_gdb_index_command): Update.
2747         * cp-support.c (add_symbol_overload_list_qualified): Update.
2748         * breakpoint.c (create_overlay_event_breakpoint)
2749         (create_longjmp_master_breakpoint)
2750         (create_std_terminate_master_breakpoint)
2751         (create_exception_master_breakpoint): Update.
2752         * blockframe.c (find_pc_partial_function): Update.
2753         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2754         (ada_collect_symbol_completion_matches)
2755         (ada_add_global_exceptions): Update.
2756
2757 2019-01-17  Tom Tromey  <tom@tromey.com>
2758
2759         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2760         declare VEC.
2761         (solib_target_parse_libraries): Change return type.
2762         (library_list_start_segment, library_list_start_section)
2763         (library_list_end_library, library_list_start_library); Update.
2764         (solib_target_free_library_list): Remove.
2765         (solib_target_parse_libraries): Remove cleanup.  Change return
2766         type.
2767         (solib_target_current_sos): Update.
2768
2769 2019-01-17  Tom Tromey  <tromey@bapiya>
2770
2771         * valprint.c: Replace "the the" with "the".
2772         * symtab.c: Replace "the the" with "the".
2773         * solib.c: Replace "the the" with "the".
2774         * solib-dsbt.c: Replace "the the" with "the".
2775         * linespec.c: Replace "the the" with "the".
2776         * dwarf2loc.h: Replace "the the" with "the".
2777         * amd64-windows-tdep.c: Replace "the the" with "the".
2778         * aarch64-tdep.c: Replace "the the" with "the".
2779
2780 2019-01-16  Keith Seitz  <keiths@redhat.com>
2781
2782         PR gdb/23773
2783         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2784         <builder>: Rename to ..
2785         <m_builder>: ... this and make private.
2786         (dwarf2_cu::get_builder): New method.  Change all users of
2787         `builder' to use this method.
2788         (dwarf2_start_symtab): Move to ...
2789         (dwarf2_cu::start_symtab): ... here.  Update all callers
2790         (setup_type_unit_groups): Move to ...
2791         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2792         callers.
2793         (dwarf2_cu::reset_builder): New method.
2794         (process_full_compunit, process_full_type_unit): Use
2795         dwarf2_cu::reset_builder.
2796         (follow_die_offset): Record the ancestor CU if it is different
2797         from the followed DIE's CU.
2798         (follow_die_sig_1): Likewise.
2799
2800 2019-01-15  Tom Tromey  <tom@tromey.com>
2801
2802         * remote.c (class remote_state) <buf>: Now a char_vector.
2803         <buf_size>: Remove.
2804         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2805         parameter.
2806         (remote_target::getpkt_or_notif_sane_1)
2807         (remote_target::getpkt_sane)
2808         (remote_target::getpkt_or_notif_sane): Likewise.
2809         (class remote_target) <putpkt>: New overload.
2810         (remote_target::read_frame): Change type of "buf_p".  Remove
2811         sizeof_p parameter.
2812         (packet_ok): New overload.
2813         (packet_check_result): New overload.
2814         Update all uses.
2815
2816 2019-01-14  Tom Tromey  <tom@tromey.com>
2817
2818         * remote-notif.c (handle_notification, remote_notif_ack)
2819         (remote_notif_parse): Make "buf" const.
2820         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2821         const.
2822         (remote_notif_parse, remote_notif_ack, handle_notification):
2823         Likewise.
2824         * remote.c (remote_notif_stop_parse): Make "buf" const.
2825         (remote_target::remote_parse_stop_reply): Make "buf" const.
2826         (remote_notif_stop_ack): Make "buf" const.
2827
2828 2019-01-14  Tom Tromey  <tom@tromey.com>
2829
2830         * remote.c (remote_console_output): Make parameter const.
2831
2832 2019-01-14  Tom Tromey  <tom@tromey.com>
2833
2834         * target-debug.h (target_debug_print_signals): Constify.
2835         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2836         * procfs.c (procfs_target::pass_signals): Update.
2837         * linux-nat.c (linux_nat_target::pass_signals): Update.
2838         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2839         * target-delegates.c: Rebuild.
2840         * remote.c (remote_target::program_signals): Update.
2841         (remote_target::pass_signals): Update.
2842         * target.c (target_pass_signals): Constify argument.
2843         (target_program_signals): Likewise.
2844         * target.h (struct target_ops) <pass_signals, program_signals>:
2845         Constify argument.
2846         (target_pass_signals, target_program_signals): Constify argument.
2847
2848 2019-01-14  Tom Tromey  <tom@tromey.com>
2849
2850         PR tui/28819:
2851         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2852
2853 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2854
2855         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2856         field.
2857         * rs6000-tdep.c: Include reggroups.h.
2858         (IS_V_ALIAS_PSEUDOREG): Define.
2859         (rs6000_register_name): Return names for the "vX" aliases.
2860         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2861         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2862         aliases.  Call default_register_reggroup_p for all other
2863         pseudo-registers.
2864         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2865         New functions.
2866         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2867         Handle "vX" aliases.
2868         (v_alias_pseudo_register_collect): New function.
2869         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2870         (rs6000_gdbarch_init): Initialize "vX" aliases as
2871         pseudo-registers.  Restore registration of
2872         rs6000_pseudo_register_reggroup_p with
2873         set_tdesc_pseudo_register_reggroup_p.
2874
2875 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2876
2877         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2878         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2879         set_gdbarch_num_pseudo_regs.
2880
2881 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2882
2883         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2884         Remove arg prefixname, add do_set and do_show.
2885         Add member functions set_list and show_list.
2886         * cli/cli-style.c (class cli_style_option): Update accordingly.
2887         (style_set_list): Move to file scope.
2888         (style_show_list): Likewise.
2889         (set_style): Call help_list.
2890         (show_style): Call cmd_show_list.
2891         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2892         Update to use the new macro.
2893
2894 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2895
2896         * ada-lang.c (_initialize_ada_language): Expand the help text
2897         for the "catch exception" command.
2898
2899 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2900
2901         * symtab.c (matching_obj_sections): Initialize obj,
2902         declare it closer to its usage.
2903
2904 2019-01-10  Tom Tromey  <tom@tromey.com>
2905
2906         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2907         (basic_inf_threads_range): Remove.
2908         (inf_threads_range, inf_non_exited_threads_range)
2909         (safe_inf_threads_range): Use next_adapter.
2910
2911 2019-01-10  Keith Seitz  <keiths@redhat.com>
2912
2913         PR gdb/23712
2914         PR symtab/23010
2915         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2916         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2917
2918 2019-01-10  Keith Seitz  <keiths@redhat.com>
2919
2920         PR gdb/23712
2921         PR symtab/23010
2922         * dictionary.c (pending_to_vector): Remove.
2923         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2924         Remove _1 suffix, replacing functions of the same name.  Update
2925         all callers.
2926         (dict_create_hashed, dict_create_hashed_expandable)
2927         (dict_create_linear, dict_create_linear_expandable, dict_free)
2928         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2929         Make functions static.
2930
2931 2019-01-10  Keith Seitz  <keiths@redhat.com>
2932
2933         PR gdb/23712
2934         PR symtab/23010
2935         * dictionary.h (struct dictionary): Replace declaration with
2936         multidictionary.
2937         (dict_create_hashed, dict_create_hashed_expandable)
2938         (dict_create_linear, dict_create_linear_expandable)
2939         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2940         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2941         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2942         taking multidictionary argument.
2943         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2944         * block.h (struct block) <dict>: Change to multidictionary
2945         and rename `multidict'.
2946         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2947         symmisc.c: Update all dictionary references to multidictionary.
2948
2949 2019-01-10  Keith Seitz  <keiths@redhat.com>
2950
2951         PR gdb/23712
2952         PR symtab/23010
2953         * dictionary.c: Include unordered_map.
2954         (pending_to_vector): New function.
2955         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2956         Rewrite the non-"_1" functions to take vector instead
2957         of linked list.
2958         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2959         "new" _1 versions of the same name.
2960         (multidictionary): Define.
2961         (std::hash<enum language): New definition.
2962         (collate_pending_symbols_by_language, mdict_create_hashed)
2963         (mdict_create_hashed_expandable, mdict_create_linear)
2964         (mdict_create_linear_expandable, mdict_free)
2965         (find_language_dictionary, create_new_language_dictionary)
2966         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2967         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2968         (mdict_size, mdict_empty): New functions.
2969         * dictionary.h (mdict_iterator): Define.
2970
2971 2019-01-10  Pedro Alves  <palves@redhat.com>
2972
2973         * breakpoint.c (read_uploaded_action)
2974         (create_tracepoint_from_upload): Adjust to use
2975         gdb::unique_xmalloc_ptr.
2976         * ctf.c (ctf_write_uploaded_tp):
2977         (SET_ARRAY_FIELD): Use emplace_back.
2978         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2979         * tracefile-tfile.c (tfile_write_uploaded_tp):
2980         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2981         gdb::unique_xmalloc_ptr.
2982         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2983         at_string, cond_string, cmd_strings>: Replace char pointers
2984         with gdb::unique_xmalloc_ptr.
2985
2986 2019-01-10  Pedro Alves  <palves@redhat.com>
2987
2988         * solib-target.c (library_list_start_library): Don't xstrdup name.
2989
2990 2019-01-10  Pedro Alves  <palves@redhat.com>
2991
2992         * mdebugread.c (parse_partial_symbols): Use
2993         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2994
2995 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * linux-fork.c (scoped_switch_fork_info)
2998         <~scoped_switch_fork_info>: Fix incorrect variable name.
2999
3000 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * linux-fork.c (scoped_switch_fork_info)
3003         <scoped_switch_fork_info>: Make explicit.
3004         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3005
3006 2019-01-10  Tom Tromey  <tom@tromey.com>
3007
3008         * objfiles.h (objfile::reset_psymtabs): Update.
3009         * objfiles.c (objfile::objfile): Update.
3010         * psymtab.h (psymtab_storage::obstack): Update.
3011         (psymtab_storage::m_obstack): Use gdb::optional.
3012         (class psymtab_storage): Update comment.  Remove objfile
3013         parameter.
3014         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3015
3016 2019-01-10  Tom Tromey  <tom@tromey.com>
3017
3018         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3019         <free_psymtabs>: Now private.
3020         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3021         (allocate_psymtab): Use new method.
3022
3023 2019-01-10  Tom Tromey  <tom@tromey.com>
3024
3025         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3026         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3027         * mdebugread.c (parse_partial_symbols): Use
3028         allocate_dependencies.
3029         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3030         allocate_dependencies.
3031         (process_psymtab_comp_unit_reader)
3032         (build_type_psymtab_dependencies): Likewise.
3033         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3034
3035 2019-01-10  Tom Tromey  <tom@tromey.com>
3036
3037         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3038         PSYMBOL_SET_LANGUAGE.
3039         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3040
3041 2019-01-10  Tom Tromey  <tom@tromey.com>
3042
3043         * psymtab.h (psymtab_storage::obstack): New method.
3044         <m_obstack>: Rename from obstack; now private.
3045         * psymtab.c (psymtab_storage): Update.
3046         * dwarf2read.c (create_addrmap_from_index)
3047         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3048         Update.
3049
3050 2019-01-10  Tom Tromey  <tom@tromey.com>
3051
3052         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3053         * objfiles.h (objfile::reset_psymtabs): New method.
3054
3055 2019-01-10  Tom Tromey  <tom@tromey.com>
3056
3057         * symmisc.c (print_symbol_bcache_statistics): Update.
3058         (print_objfile_statistics): Update.
3059         * symfile.c (reread_symbols): Update.
3060         * psymtab.h (class psymtab_storage): New.
3061         * psymtab.c (psymtab_storage): New constructor.
3062         (~psymtab_storage): New destructor.
3063         (require_partial_symbols): Update.
3064         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3065         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3066         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3067         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3068         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3069         (start_psymtab_common, end_psymtab_common)
3070         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3071         (allocate_psymtab): Update.
3072         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3073         Update.
3074         (dump_psymtab_addrmap, maintenance_print_psymbols)
3075         (maintenance_check_psymtabs): Update.
3076         (class objfile_psymtabs): Move to objfiles.h.
3077         * psympriv.h (discard_psymtab): Now inline.
3078         (psymtab_discarder::psymtab_discarder): Update.
3079         (psymtab_discarder::~psymtab_discarder): Update.
3080         (ALL_OBJFILE_PSYMTABS): Rewrite.
3081         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3082         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3083         Remove fields.
3084         <partial_symtabs>: New field.
3085         (class objfile_psymtabs): Move from psymtab.h.  Update.
3086         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3087         psymbol_cache.
3088         (objfile::~objfile): Don't destroy psymbol_cache.
3089         * mdebugread.c (parse_partial_symbols): Update.
3090         * dwarf2read.c (create_addrmap_from_index)
3091         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3092         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3093         (add_partial_subprogram, dwarf2_ranges_read): Update.
3094         * dwarf-index-write.c (write_address_map)
3095         (write_one_signatured_type, recursively_write_psymbols)
3096         (class debug_names, class debug_names, write_psymtabs_to_index):
3097         Update.
3098
3099 2019-01-10  Tom Tromey  <tom@tromey.com>
3100
3101         * symtab.h (SYMBOL_SET_NAMES): Update.
3102         (symbol_set_names): Update.
3103         (MSYMBOL_SET_NAMES): Update.
3104         * symtab.c (symbol_set_names): Change argument to be an
3105         objfile_per_bfd_storage.
3106         * psymtab.c (add_psymbol_to_bcache): Update.
3107         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3108
3109 2019-01-10  Tom Tromey  <tom@tromey.com>
3110
3111         * symtab.c (create_demangled_names_hash): Change argument to be an
3112         objfile_per_bfd_storage.
3113         (symbol_set_names): Update.
3114
3115 2019-01-10  Tom Tromey  <tom@tromey.com>
3116
3117         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3118         init_psymbol_list.
3119         * psymtab.c (init_psymbol_list): Do nothing if already called.
3120         * psympriv.h (init_psymbol_list): Add comment.
3121         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3122         init_psymbol_list.
3123         * dbxread.c (dbx_symfile_read): Unconditionally call
3124         init_psymbol_list.
3125
3126 2019-01-10  Tom Tromey  <tom@tromey.com>
3127
3128         * xcoffread.c (scan_xcoff_symtab): Update.
3129         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3130         "where".
3131         * mdebugread.c (parse_partial_symbols)
3132         (handle_psymbol_enumerators): Update.
3133         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3134         * dbxread.c (read_dbx_symtab): Update.
3135         * psympriv.h (psymbol_placement): New enum.
3136         (add_psymbol_to_list): Update.
3137
3138 2019-01-10  Tom Tromey  <tom@tromey.com>
3139
3140         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3141         static_psymbols parameters.
3142         (scan_xcoff_symtab): Update.
3143         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3144         static_psymbols parameters.
3145         * psympriv.h (start_psymtab_common): Update.
3146         * mdebugread.c (parse_partial_symbols): Update.
3147         * dwarf2read.c (create_partial_symtab): Update.
3148         * dbxread.c (read_dbx_symtab): Update.
3149         (start_psymtab): Remove global_psymbols and static_psymbols
3150         parameters.
3151
3152 2019-01-10  Tom Tromey  <tom@tromey.com>
3153
3154         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3155         * psymtab.c (allocate_psymtab): Add comment.
3156         * psympriv.h (allocate_psymtab): Add comment.
3157         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3158         initializations.
3159         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3160
3161 2019-01-10  Tom Tromey  <tom@tromey.com>
3162
3163         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3164         Don't declare.
3165         * mipsread.c: Include mdebugread.h.
3166         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3167         Declare.
3168         * elfread.c: Include mdebugread.h.
3169
3170 2019-01-09  Tom Tromey  <tom@tromey.com>
3171
3172         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3173         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3174         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3175         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3176         (psym_lookup_symbol, psym_find_last_source_symtab)
3177         (psym_forget_cached_source_info, psym_print_stats)
3178         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3179         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3180         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3181         (psym_find_compunit_symtab_by_address)
3182         (maintenance_print_psymbols, maintenance_info_psymtabs)
3183         (maintenance_check_psymtabs): Use ranged for.
3184         * psymtab.h (class objfile_psymtabs): New.
3185         (require_partial_symbols): Return objfile_psymtabs.
3186         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3187
3188 2019-01-09  Tom Tromey  <tom@tromey.com>
3189
3190         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3191         (find_pc_mapped_section, list_overlays_command)
3192         (map_overlay_command, unmap_overlay_command)
3193         (simple_overlay_update): Use all_objfiles.
3194         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3195         * printcmd.c (info_symbol_command): Use all_objfiles.
3196         * objfiles.h (ALL_OBJSECTIONS): Remove.
3197         * maint.c (maintenance_translate_address): Use all_objfiles.
3198         * gcore.c (gcore_create_callback): Use all_objfiles.
3199         (objfile_find_memory_regions): Likewise.
3200
3201 2019-01-09  Tom Tromey  <tom@tromey.com>
3202
3203         * symtab.c (find_line_symtab, info_sources_command)
3204         (make_source_files_completion_list): Use objfile_compunits.
3205         * source.c (select_source_symtab): Use objfile_compunits.
3206         * objfiles.h (struct objfile): Update comment.
3207         (ALL_OBJFILES): Remove.
3208         (ALL_FILETABS): Remove.
3209         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3210         objfile_compunits.
3211
3212 2019-01-09  Tom Tromey  <tom@tromey.com>
3213
3214         * symmisc.c (print_objfile_statistics, dump_objfile)
3215         (maintenance_print_symbols): Use compunit_filetabs.
3216         * source.c (forget_cached_source_info_for_objfile): Use
3217         compunit_filetabs.
3218         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3219         (ALL_FILETABS): Use compunit_filetabs.
3220         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3221         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3222
3223 2019-01-09  Tom Tromey  <tom@tromey.com>
3224
3225         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3226         (compunit_filetabs): New.
3227         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3228         compunit_filetabs.
3229         (info_sources_command, make_source_files_completion_list): Remove
3230         declaration.
3231         * symmisc.c (print_objfile_statistics, dump_objfile)
3232         (maintenance_print_symbols): Remove declaration.
3233         (maintenance_info_symtabs): Use compunit_filetabs.
3234         (maintenance_info_line_tables): Likewise.
3235         * source.c (select_source_symtab): Change local variable name.
3236         (forget_cached_source_info_for_objfile): Remove declaration.
3237         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3238         * objfiles.c (objfile_relocate1): Remove declaration.
3239         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3240         declaration.
3241         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3242         * coffread.c (coff_symtab_read): Remove declaration.
3243         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3244         compunit_filetabs.
3245
3246 2019-01-09  Tom Tromey  <tom@tromey.com>
3247
3248         * symtab.c (lookup_objfile_from_block)
3249         (find_pc_sect_compunit_symtab, search_symbols)
3250         (default_collect_symbol_completion_matches_break_on): Use
3251         objfile_compunits.
3252         * objfiles.h (ALL_COMPUNITS): Remove.
3253         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3254         * cp-support.c (add_symbol_overload_list_qualified): Use
3255         objfile_compunits.
3256         * ada-lang.c (ada_collect_symbol_completion_matches)
3257         (ada_add_global_exceptions): Use objfile_compunits.
3258
3259 2019-01-09  Tom Tromey  <tom@tromey.com>
3260
3261         * source.c (select_source_symtab)
3262         (forget_cached_source_info_for_objfile): Remove declaration.
3263         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3264         declaration.
3265         * maint.c (count_symtabs_and_blocks): Remove declaration.
3266         * cp-support.c (add_symbol_overload_list_qualified): Remove
3267         declaration.
3268         * coffread.c (coff_symtab_read): Remove declaration.
3269         * symtab.c (lookup_symbol_in_objfile_symtabs)
3270         (basic_lookup_transparent_type_1): Use objfile_compunits.
3271         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3272         (info_sources_command, search_symbols)
3273         (default_collect_symbol_completion_matches_break_on)
3274         (make_source_files_completion_list): Remove declaration.
3275         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3276         (ada_collect_symbol_completion_matches)
3277         (ada_add_global_exceptions): Remove declaration.
3278         * linespec.c (iterate_over_all_matching_symtabs): Use
3279         objfile_compunits.
3280         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3281         (class objfile_compunits): New.
3282         (ALL_COMPUNITS): Use objfile_compunits.
3283         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3284         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3285         objfile_compunits.
3286         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3287
3288 2019-01-09  Tom Tromey  <tom@tromey.com>
3289
3290         * symtab.c (search_symbols)
3291         (default_collect_symbol_completion_matches_break_on): Use
3292         objfile_msymbols.
3293         * ada-lang.c (ada_lookup_simple_minsym)
3294         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3295         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3296         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3297         objfile_msymbols.
3298         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3299         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3300         * objc-lang.c (find_methods): Use objfile_msymbols.
3301         (info_selectors_command, info_classes_command): Likewise.
3302         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3303         * objfiles.h (class objfile_msymbols): New.
3304         (ALL_OBJFILE_MSYMBOLS): Remove.
3305         (ALL_MSYMBOLS): Remove.
3306
3307 2019-01-09  Tom Tromey  <tom@tromey.com>
3308
3309         * common/next-iterator.h (next_adapter): Add Iterator template
3310         parameter.
3311         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3312         (class all_objfiles_safe): New.
3313         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3314         * objfiles.c (put_objfile_before): Update comment.
3315         (add_separate_debug_objfile): Likewise.
3316         (free_all_objfiles): Use all_objfiles_safe.
3317         (objfile_purge_solibs): Likewise.
3318
3319 2019-01-09  Tom Tromey  <tom@tromey.com>
3320
3321         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3322         (expand_symtab_containing_pc, lookup_static_symbol)
3323         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3324         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3325         all_objfiles.
3326         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3327         * breakpoint.c (create_overlay_event_breakpoint)
3328         (create_longjmp_master_breakpoint)
3329         (create_std_terminate_master_breakpoint)
3330         (create_exception_master_breakpoint): Use all_objfiles.
3331         * linux-thread-db.c (try_thread_db_load_from_pdir)
3332         (has_libpthread): Use all_objfiles.
3333         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3334         * linespec.c (iterate_over_all_matching_symtabs)
3335         (search_minsyms_for_name): Use all_objfiles.
3336         * maint.c (maintenance_info_sections): Use all_objfiles.
3337         * main.c (captured_main_1): Use all_objfiles.
3338         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3339         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3340         * guile/scm-pretty-print.c
3341         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3342         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3343         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3344         (maintenance_print_msymbols): Use all_objfiles.
3345         * source.c (select_source_symtab): Use all_objfiles.
3346         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3347         * symfile.c (remove_symbol_file_command)
3348         (expand_symtabs_matching, map_symbol_filenames): Use
3349         all_objfiles.
3350         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3351         all_objfiles.
3352         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3353         * objc-lang.c (find_methods): Use all_objfiles.
3354         * objfiles.c (have_partial_symbols, have_full_symbols)
3355         (have_minimal_symbols, qsort_cmp)
3356         (default_iterate_over_objfiles_in_search_order): Use
3357         all_objfiles.
3358         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3359         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3360         (maintenance_check_psymtabs): Use all_objfiles.
3361         (ALL_PSYMTABS): Remove.
3362         * compile/compile-object-run.c (do_module_cleanup): Use
3363         all_objfiles.
3364         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3365         * cp-support.c (add_symbol_overload_list_qualified): Use
3366         all_objfiles.
3367         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3368         Use all_objfiles.
3369         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3370         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3371         all_objfiles.
3372         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3373         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3374         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3375         Uses all_objfiles.
3376         * solib.c (solib_read_symbols): Use all_objfiles
3377
3378 2019-01-09  Tom Tromey  <tom@tromey.com>
3379
3380         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3381         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3382         all_objfiles.
3383         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3384         * symmisc.c (print_symbol_bcache_statistics)
3385         (print_objfile_statistics, maintenance_print_objfiles)
3386         (maintenance_info_symtabs, maintenance_check_symtabs)
3387         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3388         all_objfiles.
3389         * source.c (forget_cached_source_info): Use all_objfiles.
3390         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3391         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3392         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3393         * objfiles.c (update_section_map): Use all_objfiles.
3394         (shared_objfile_contains_address_p): Likewise.
3395         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3396         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3397
3398 2019-01-09  Tom Tromey  <tom@tromey.com>
3399
3400         * common/next-iterator.h: New file.
3401         * objfiles.h (class all_objfiles): New.
3402         (struct objfile_iterator): New.
3403
3404 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3405
3406         * NEWS: Move the description of the changed "frame", "select-frame",
3407          and "info frame" commands to the Changed commands section.
3408
3409 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3410
3411         * gdbtypes.c (check_stub_method_group): Remove handling of old
3412         mangling schemes.
3413         * linespec.c (find_methods): Likewise.
3414         * stabsread.c (read_member_functions): Likewise.
3415         * valops.c (search_struct_method): Likewise.
3416         (value_struct_elt_for_reference): Likewise.
3417         * NEWS: Mention this change.
3418
3419 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3420
3421         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3422         print_source_lines.
3423         * source.c (print_source_lines_base): Update line number check.
3424         (print_source_lines): New function.
3425         (source_lines_range::source_lines_range): New function.
3426         * source.h (class source_lines_range): New class.
3427         (print_source_lines): New declaration.
3428
3429 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3430
3431         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3432
3433 2019-01-08  Tom Tromey  <tom@tromey.com>
3434             Simon Marchi  <simon.marchi@ericsson.com>
3435
3436         PR gdb/24060
3437         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3438         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3439         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3440         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3441         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3442         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3443
3444 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         * source.c (select_source_symtab): Move header comment to
3447         declaration in source.h.
3448         (forget_cached_source_info_for_objfile): Likewise.
3449         (forget_cached_source_info): Likewise.
3450         (identify_source_line): Likewise.
3451         * source.h (identify_source_line): Move declaration from symtab.h
3452         and add comment from source.c
3453         (print_source_lines): Likewise.
3454         (forget_cached_source_info_for_objfile): Likewise.
3455         (forget_cached_source_info): Likewise.
3456         (select_source_symtab): Likewise.
3457         (enum print_source_lines_flag): Move definition from symtab.h.
3458         * symtab.h (identify_source_line): Move declaration to source.h.
3459         (print_source_lines): Likewise.
3460         (forget_cached_source_info_for_objfile): Likewise.
3461         (forget_cached_source_info): Likewise.
3462         (select_source_symtab): Likewise.
3463         (enum print_source_lines_flag): Move definition to source.h.
3464         * tui/tui-hooks.c: Add 'source.h' include.
3465
3466 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3467
3468         * source.c (print_source_lines_base): Handle requests to print
3469         reverse line number sequences, and guard against empty lines
3470         string.
3471
3472 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * source.c (print_source_lines_base): Fix skip of '\r' if next
3475         character is '\n'.
3476
3477 2019-01-06  Tom Tromey  <tom@tromey.com>
3478
3479         * c-exp.y (struct c_parse_state) <macro_original_text,
3480         expansion_obstack>: New member.
3481         (macro_original_text, expansion_obstack): Remove globals.
3482         (scan_macro_expansion, scanning_macro_expansion)
3483         (finished_macro_expansion): Update.
3484         (scan_macro_cleanup): Remove.
3485         (yylex, c_parse): Update.
3486
3487 2019-01-06  Tom Tromey  <tom@tromey.com>
3488
3489         * c-exp.y (struct c_parse_state) <strings>: New member.
3490         (operator_stoken): Update.
3491
3492 2019-01-06  Tom Tromey  <tom@tromey.com>
3493
3494         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3495         (union type_stack_elt) <typelist_val>: Now a pointer to
3496         std::vector.
3497         (type_stack_cleanup): Don't declare.
3498         (push_typelist): Update.
3499         * parse.c (pop_typelist): Return a std::vector.
3500         (push_typelist): Take a std::vector.
3501         (follow_types): Update.  Do not free args.
3502         (type_stack_cleanup): Remove.
3503         * c-exp.y (struct c_parse_state): New.
3504         (cpstate): New global.
3505         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3506         (nonempty_typelist): Update.
3507         (func_mod): Create a new vector.
3508         (c_parse): Create a c_parse_state.
3509         (check_parameter_typelist): Do not delete params.
3510         (function_method): Update.  Do not delete type_list.
3511
3512 2019-01-06  Tom Tromey  <tom@tromey.com>
3513
3514         PR gdb/28155:
3515         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3516         check_typedef.
3517         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3518         (print_return_value): Likewise.
3519
3520 2019-01-05  Tom Tromey  <tom@tromey.com>
3521
3522         * contrib/cleanup_check.py: Remove.
3523         * contrib/gcc-with-excheck: Remove.
3524         * contrib/exsummary.py: Remove.
3525         * contrib/excheck.py: Remove.
3526
3527 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3528
3529         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3530         NULL. Initialize tpprev to NULL instead of assigning it
3531         to NULL on the next statement.
3532         * windows-nat.c (windows_delete_thread): Remove check for
3533         main_thread_id before printing thread exit notifications.
3534         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3535         Remove thread ID check against main_thread_id.
3536         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3537         windows_delete_thread.
3538         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3539
3540 2019-01-04  Tom Tromey  <tom@tromey.com>
3541
3542         * compile/compile.c (_initialize_compile): Use upper case for
3543         metasyntactic variables.
3544         * symmisc.c (_initialize_symmisc): Use upper case for
3545         metasyntactic variables.
3546         * psymtab.c (_initialize_psymtab): Use upper case for
3547         metasyntactic variables.
3548         * demangle.c (demangle_command): Use upper case for metasyntactic
3549         variables.
3550         (_initialize_demangler): Likewise.
3551         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3552         variables.
3553
3554 2019-01-03  Tom Tromey  <tom@tromey.com>
3555
3556         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3557
3558 2019-01-03  Tom Tromey  <tom@tromey.com>
3559
3560         * python/py-symtab.c (salpy_str): Update.
3561         (struct salpy_sal_object) <symtab>: Now a PyObject.
3562         (salpy_dealloc): Update.
3563         (del_objfile_sal): Use gdbpy_ref.
3564
3565 2019-01-03  Tom Tromey  <tom@tromey.com>
3566
3567         * python/py-type.c (convert_field): Use new_reference.  Return
3568         gdbpy_ref.
3569         (make_fielditem): Return gdbpy_ref.
3570         (typy_fields): Update.
3571         (typy_getitem): Update.
3572         (field_name): Return gdbpy_ref.  Use new_reference.
3573         (typy_iterator_iternext): Update.
3574
3575 2019-01-03  Tom Tromey  <tom@tromey.com>
3576
3577         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3578
3579 2019-01-03  Tom Tromey  <tom@tromey.com>
3580
3581         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3582         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3583         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3584         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3585         (pspy_set_type_printers): Likewise.
3586         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3587         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3588         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3589         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3590         (objfpy_set_type_printers): Likewise.
3591
3592 2019-01-03  Tom Tromey  <tom@tromey.com>
3593
3594         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3595         (gdbpy_print_stack): Use gdbpy_err_fetch.
3596         * python/python-internal.h (class gdbpy_err_fetch): New class.
3597         (class gdbpy_enter) <m_error_type, m_error_value,
3598         m_error_traceback>: Remove.
3599         <m_error>: New member.
3600         (gdbpy_exception_to_string): Don't declare.
3601         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3602         * python/py-value.c (convert_value_from_python): Use
3603         gdbpy_err_fetch.
3604         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3605         gdbpy_exception_to_string.
3606         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3607         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3608         gdbpy_err_fetch.
3609
3610 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3611
3612         * linux-nat.c (delete_lwp_cleanup): Delete.
3613         (struct lwp_deleter): New struct.
3614         (lwp_info_up): New typedef.
3615         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3616         lwp_info_up.
3617
3618 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3619
3620         * linux-fork.c (class scoped_switch_fork_info): New class.
3621         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3622
3623 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3624
3625         * valops.c (find_overload_match): Remove use of null_cleanup, and
3626         calls to do_cleanups.
3627
3628 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3629
3630         * compile/compile-cplus-types.c
3631         (compile_cplus_instance::decl_name): Handle changes to
3632         cp_func_name.
3633         * cp-support.c (cp_func_name): Update header comment, update
3634         return type.
3635         * cp-support.h (cp_func_name): Update return type in declaration.
3636         * valops.c (find_overload_match): Move temp_func local to top
3637         level of function and change its type.  Use temp_func to hold and
3638         delete temporary string obtained from cp_func_name.
3639
3640 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3641
3642         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3643         gdb::char_vector, remove cleanup, and update uses of `msg`.
3644
3645 2019-01-03  Jim Wilson  <jimw@sifive.com>
3646
3647         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3648
3649 2019-01-02  Tom Tromey  <tom@tromey.com>
3650
3651         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3652         (tdesc_parse_xml): Remove cleanups.
3653         * target-descriptions.h (make_cleanup_free_target_description):
3654         Don't declare.
3655         (target_desc_deleter): New struct.
3656         (target_desc_up): New typedef.
3657         * target-descriptions.c (target_desc_deleter::operator()): Rename
3658         from free_target_description.
3659         (make_cleanup_free_target_description): Remove.
3660
3661 2019-01-02  Tom Tromey  <tom@tromey.com>
3662
3663         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3664         constructor, destructor.
3665         (linespec_parser): Remove typedef.
3666         (~linespec_parser): Rename from linespec_parser_delete.
3667         (linespec_lex_to_end, linespec_complete_label)
3668         (linespec_complete): Update.
3669         (decode_line_full): Remove cleanups.
3670         (decode_line_1): Update.
3671
3672 2019-01-02  Tom Tromey  <tom@tromey.com>
3673
3674         * python/python-internal.h (inferior_to_inferior_object): Change
3675         return type.
3676         * python/py-exitedevent.c (create_exited_event_object): Update.
3677         * python/py-inferior.c (inferior_to_inferior_object): Return
3678         gdbpy_ref.
3679         (python_new_inferior, python_inferior_deleted)
3680         (thread_to_thread_object, delete_thread_object)
3681         (build_inferior_list, gdbpy_selected_inferior): Update.
3682         * python/py-infthread.c (create_thread_object): Update.  Also fail
3683         if inferior_to_inferior_object fails.
3684
3685 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3686
3687         * inferior.h (class inferior) <displaced_step_state>: New field.
3688         * infrun.h (struct displaced_step_state): Move here from
3689         infrun.c.  Initialize fields, add constructor.
3690         <inf>: Remove field.
3691         <reset>: New method.
3692         * infrun.c (struct displaced_step_inferior_state): Move to
3693         infrun.h.
3694         (displaced_step_inferior_states): Remove.
3695         (get_displaced_stepping_state): Adust.
3696         (displaced_step_in_progress_any_inferior): Adjust.
3697         (displaced_step_in_progress_thread): Adjust.
3698         (displaced_step_in_progress): Adjust.
3699         (add_displaced_stepping_state): Remove.
3700         (get_displaced_step_closure_by_addr): Adjust.
3701         (remove_displaced_stepping_state): Remove.
3702         (infrun_inferior_exit): Call displaced_step_state.reset.
3703         (use_displaced_stepping): Don't check for NULL.
3704         (displaced_step_prepare_throw): Call
3705         get_displaced_stepping_state.
3706         (displaced_step_fixup): Don't check for NULL.
3707         (prepare_for_detach): Don't check for NULL.
3708
3709 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3710
3711         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3712          in case of call that did not complete.
3713
3714 2019-01-02  Andrey Utkin  <autkin@undo.io>
3715
3716         * symfile.c (find_separate_debug_file): Fix search of debug files for
3717         remote debuggee.
3718
3719 2019-01-02  Tom Tromey  <tom@tromey.com>
3720
3721         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3722         indentation.
3723         * python/py-frame.c (frapy_older): Remove cast.
3724         (frapy_newer): Likewise.
3725         * python/py-breakpoint.c (local_setattro): Remove cast.
3726         * python/py-arch.c (archpy_name): Remove local variable.
3727         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3728
3729 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3730
3731         * unittests/basic_string_view/element_access/char/empty.cc:
3732         Fix year range in copyright header.
3733
3734 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3735
3736         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3737         Delete.
3738         <operator==>: Update with for removed field.
3739         <hash>: Likewise.
3740         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3741         <isa_features>: ...this.
3742         <abi_features>: New field.
3743         (riscv_isa_flen): Update comment.
3744         (riscv_abi_xlen): New declaration.
3745         (riscv_abi_flen): New declaration.
3746         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3747         isa_features.
3748         (riscv_abi_xlen): New function.
3749         (riscv_isa_flen): Update to get answer from isa_features.
3750         (riscv_abi_flen): New function.
3751         (riscv_has_fp_abi): Update to get answer from abi_features.
3752         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3753         xlen and flen.
3754         (riscv_call_info) <xlen, flen>: Update comment.
3755         (riscv_call_arg_struct): Remove invalid assertions
3756         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3757         is removed.
3758         (riscv_gdbarch_init): Gather isa features and abi features
3759         separately, ensure both match on the gdbarch when reusing an old
3760         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3761         a target with 64-bit float hardware.
3762
3763 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3764
3765         * source.c (search_command_helper): Stop reverse search
3766         when line 1 has been searched.
3767
3768 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3769
3770         * record-full.c (record_full_base_target::close): Rewrite
3771         record_full_core_buf_list free logic.
3772
3773 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3774
3775         * break-catch-syscall.c (print_one_catch_syscall): xfree
3776         the last text.
3777
3778 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3779
3780         * top.c (print_gdb_version): Update Copyright year in version
3781         message.
3782
3783 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3784
3785         Update copyright year range in all GDB files.
3786
3787 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3788
3789         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3790
3791 For older changes see ChangeLog-2018.
3792 \f
3793 Local Variables:
3794 mode: change-log
3795 left-margin: 8
3796 fill-column: 74
3797 version-control: never
3798 coding: utf-8
3799 End:
3800