gdb/ChangeLog

   1 2019-08-15  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c: Include tui-stack.h.
   4         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
   5         (struct tui_locator_window): Move from tui-data.h.
   6         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
   7         (tui_initialize_static_data): Move from tui-data.c.
   8         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
   9         (struct tui_locator_window): Move to tui-stack.c.
  10         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
  11         (tui_initialize_static_data): Move to tui-stack.c.
  12
  13 2019-08-15  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-layout.c (show_source_disasm_command)
  16         (show_source_or_disasm_and_command): Use make_visible method, not
  17         tui_make_window.
  18         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
  19         Remove.
  20
  21 2019-08-15  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-wingeneral.h (tui_make_window): Update.
  24         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
  25         parameter.
  26         (tui_gen_win_info::make_visible): Update.
  27         * tui/tui-regs.c (tui_data_window::display_registers_from):
  28         Update.
  29         * tui/tui-layout.c (show_source_disasm_command)
  30         (show_source_or_disasm_and_command): Update.
  31         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
  32         (enum tui_box): Remove.
  33         (struct tui_win_info) <can_box>: New method.
  34         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
  35         method.
  36
  37 2019-08-15  Tom de Vries  <tdevries@suse.de>
  38
  39         * linux-nat-trad.c: Include gdbarch.h.
  40
  41 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
  42
  43         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
  44         register sizes.
  45
  46 2019-08-14  Tom Tromey  <tromey@adacore.com>
  47
  48         * darwin-nat.c: Include gdbarch.h.
  49         * darwin-nat-info.c: Include gdbarch.h.
  50
  51 2019-08-13  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
  54         Remove.
  55         * tui/tui-data.c (tui_initialize_static_data): Update.
  56
  57 2019-08-13  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-winsource.h (struct tui_exec_info_window)
  60         <~tui_exec_info_window, maybe_allocate_content, get_content,
  61         m_content>: Remove.
  62         (struct tui_source_window_base) <set_exec_info_content,
  63         show_exec_info_content>: Don't declare.
  64         * tui/tui-winsource.c
  65         (tui_exec_info_window::maybe_allocate_content): Remove.
  66         (tui_source_window_base::update_exec_info): Rename from
  67         set_exec_info_content.
  68         (tui_source_window_base::show_exec_info_content)
  69         (tui_source_window_base::update_exec_info): Remove.
  70
  71 2019-08-13  Tom Tromey  <tom@tromey.com>
  72
  73         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
  74         declare.
  75         * tui/tui-winsource.c (tui_update_source_window_as_is)
  76         (tui_update_source_windows_with_addr, tui_erase_source_content):
  77         Update.
  78         (tui_clear_exec_info_content): Remove.
  79
  80 2019-08-13  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
  83         declare.
  84         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
  85         call tui_erase_exec_info_content.
  86         (tui_clear_exec_info_content): Rename from
  87         tui_erase_exec_info_content.
  88         (tui_clear_exec_info_content): Delete.
  89
  90 2019-08-13  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-winsource.h (struct tui_source_window_base)
  93         <show_exec_info_content>: Declare.
  94         (tui_show_exec_info_content): Don't declare.
  95         * tui/tui-winsource.c
  96         (tui_source_window_base::show_exec_info_content): Rename from
  97         tui_show_exec_info_content.
  98         (tui_source_window_base::update_exec_info): Update.
  99
 100 2019-08-13  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 103         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 104         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 105         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 106         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 107         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 108         ... here.
 109
 110 2019-08-13  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-winsource.h (struct tui_source_window_base)
 113         <update_exec_info>: Declare.
 114         (tui_update_exec_info): Don't declare.
 115         * tui/tui-winsource.c (tui_update_source_window_as_is)
 116         (tui_source_window_base::refresh_all)
 117         (tui_update_all_breakpoint_info): Update.
 118         (tui_source_window_base::update_exec_info): Rename from
 119         tui_update_exec_info.
 120         * tui/tui-stack.c (tui_show_frame_info): Update.
 121
 122 2019-08-13  Tom Tromey  <tom@tromey.com>
 123
 124         * tui/tui-winsource.h (struct tui_source_window_base)
 125         <set_exec_info_content>: Declare.
 126         (tui_set_exec_info_content): Don't declare.
 127         * tui/tui-winsource.c
 128         (tui_source_window_base::set_exec_info_content): Rename from
 129         tui_set_exec_info_content.
 130         (tui_update_exec_info): Update.
 131
 132 2019-08-13  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-winsource.h (struct tui_source_window_base)
 135         <show_source_content>: Declare.
 136         (tui_show_source_content): Don't declare.
 137         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 138         (tui_source_window_base::show_source_content): Rename from
 139         tui_show_source_content.
 140         (tui_source_window_base::refresh_all): Update.
 141         * tui/tui-layout.c (show_source_disasm_command)
 142         (show_source_or_disasm_and_command): Update.
 143
 144 2019-08-13  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-winsource.c (tui_erase_source_content)
 147         (tui_show_source_content, tui_source_window_base::refresh_all):
 148         Update.
 149         * tui/tui-wingeneral.h
 150         (tui_check_and_display_highlight_if_needed): Don't declare.
 151         * tui/tui-wingeneral.c
 152         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 153         check_and_display_highlight_if_needed.
 154         * tui/tui-win.c (tui_rehighlight_all)
 155         (tui_win_info::make_visible_with_new_height): Update.
 156         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 157         (tui_data_window::erase_data_content)
 158         (tui_data_window::display_all_data): Update.
 159         * tui/tui-data.h (struct tui_win_info)
 160         <check_and_display_highlight_if_needed>: Declare.
 161
 162 2019-08-13  Tom Tromey  <tom@tromey.com>
 163
 164         * tui/tui-win.c (tui_resize_all): Call
 165         tui_delete_invisible_windows.
 166         * tui/tui-layout.c (show_layout): Call
 167         tui_delete_invisible_windows.
 168         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 169         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 170
 171 2019-08-13  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 174         tui_add_win_to_layout.
 175
 176 2019-08-13  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 179         * tui/tui-layout.c (tui_default_win_height): Now static.
 180
 181 2019-08-13  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 184         single switch.
 185         (show_source_disasm_command, show_source_or_disasm_and_command):
 186         Don't check current layout.
 187
 188 2019-08-13  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-wingeneral.c (make_all_visible): Remove.
 191         (tui_make_all_invisible): Simplify.
 192         * tui/tui-layout.c (tui_make_all_invisible): Move from
 193         tui-wingeneral.c; simplify.
 194         (show_layout): Hoist call to tui_make_all_invisible.
 195         (show_data): Don't call tui_make_all_invisible.
 196
 197 2019-08-13  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 200         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 201
 202 2019-08-13  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 205         tui-data.c.
 206         (show_source_disasm_command, show_data)
 207         (show_source_or_disasm_and_command): Don't use
 208         tui_set_current_layout_to.
 209         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 210         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 211         tui-layout.c.
 212         (tui_set_current_layout_to): Remove.
 213
 214 2019-08-13  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-layout.c (tui_set_layout): Update.
 217         * tui/tui-data.h (struct tui_layout_def): Remove.
 218         (tui_layout_def): Don't declare.
 219         * tui/tui-data.c (layout_def): Remove.
 220         (tui_layout_def): Remove.
 221
 222 2019-08-13  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-winsource.h (struct tui_source_window_base)
 225         <clear_detail>: No longer "override".
 226         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 227         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 228         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 229         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 230         Remove.
 231         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 232
 233 2019-08-13  Tom Tromey  <tromey@adacore.com>
 234
 235         * tracepoint.c: Don't include readline.h or history.h.
 236
 237 2019-08-12  Tom Tromey  <tom@tromey.com>
 238
 239         * configure: Rebuild.
 240         * configure.ac: Check for readline 7.
 241         * NEWS: Mention readline 7 requirement.
 242         * README: Update.
 243
 244 2019-08-12  Tom Tromey  <tom@tromey.com>
 245
 246         * mingw-hdep.c (gdb_select): Remove readline hack.
 247
 248 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 249
 250         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 251         when the function fails.
 252
 253 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 254
 255         * s390-tdep.c (s390_type_align): New function.
 256         (s390_gdbarch_init): Set it as type_align gdbarch method.
 257
 258 2019-08-09  Tom de Vries  <tdevries@suse.de>
 259
 260         PR gdb/24591
 261         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 262         pc_low with relocation offset.
 263
 264 2019-08-07  Tom Tromey  <tromey@adacore.com>
 265
 266         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 267         (print_frame_args): Update.
 268         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 269         Update.
 270         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 271         * frame.h (struct frame_arg): Add initializers.
 272         <error>: Now a unique_xmalloc_ptr.
 273
 274 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 275
 276         * NEWS: Expand the Pointer Authentication entry.
 277         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 278         (aarch64_frame_unmask_lr): ... to this.
 279         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 280         Call aarch64_frame_unmask_lr.
 281         * frame.c (struct frame_info): Add "masked" variable.
 282         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 283         (fprint_frame): Check for masked pc.
 284         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 285         declarations.
 286         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 287         * stack.c (print_frame): Check for masked pc.
 288
 289 2019-08-06  Tom Tromey  <tom@tromey.com>
 290
 291         * stabsread.c (patch_block_stabs, read_one_struct_field)
 292         (read_enum_type): Use obstack_strndup.
 293         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 294         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 295         * dwarf2read.c (guess_full_die_structure_name)
 296         (anonymous_struct_prefix): Use obstack_strndup.
 297         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 298         * c-exp.y (yylex): Use obstack_strndup.
 299         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 300         (write_var_or_type): Use obstack_strndup.
 301
 302 2019-08-06  Tom Tromey  <tom@tromey.com>
 303
 304         * symfile.c (reread_symbols): Use obstack_strdup.
 305         * stabsread.c (read_type): Use obstack_strdup.
 306         * gdb_obstack.h (obstack_strdup): New overload.
 307         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 308         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 309         (dwarf2_canonicalize_name): Use obstack_strdup.
 310         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 311         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 312         Use obstack_strdup.
 313
 314 2019-08-06  Tom Tromey  <tom@tromey.com>
 315
 316         * gdb_obstack.h (obstack_strdup): Define.
 317         * gdb_obstack.c (obstack_strdup): Don't define.
 318
 319 2019-08-06  Tom Tromey  <tom@tromey.com>
 320
 321         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 322         obstack_strdup.
 323         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 324         obstack_strdup.
 325         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 326         * stabsread.c (common_block_start): Use obstack_strdup.
 327         * objfiles.c (set_objfile_main_name, objfile): Use
 328         obstack_strdup.
 329         * namespace.c (add_using_directive): Use obstack_strdup.
 330         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 331         * jit.c (finalize_symtab): Use obstack_strdup.
 332         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 333         (guess_partial_die_structure_name, partial_die_info::fixup)
 334         (dwarf2_name): Use obstack_strdup.
 335         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 336         obstack_strdup.
 337         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 338         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 339         obstack_strdup.
 340         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 341
 342 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 343
 344         * unittests/help-doc-selftests.c: New file.
 345         * Makefile.in: Add the new file.
 346
 347 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 348
 349         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 350         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 351         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 352         the trailing '.' is not output, and the first character is uppercased.
 353         (print_help_for_command): Update call to print_doc_line.
 354         (print_doc_of_command): Likewise.
 355         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 356         * cli/cli-option.c (append_indented_doc): Do not append newline.
 357         (build_help_option): Append newline after first appended_indented_doc
 358         only if a second call is done.
 359         (build_help): Append 2 new lines before each option, except the first
 360         one.
 361         * compile/compile.c (_initialize_compile): Add new lines after
 362         %OPTIONS%, when not at the end of the help.
 363         Change help doc or code
 364         producing the help doc to respect the invariants.
 365         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 366         Also removed the new line after 'Options:', as all other commands
 367         do not put an empty line between 'Options:' and the first option.
 368         * printcmd.c (_initialize_printcmd): Likewise.
 369         * stack.c (_initialize_stack): Likewise.
 370         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 371         incorrectly telling COMMAND is optional.
 372         * ada-lang.c (_initialize_ada_language): Change help doc or code
 373         producing the help doc to respect the invariants.
 374         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 375         * breakpoint.c (_initialize_breakpoint): Likewise.
 376         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 377         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 378         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 379         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 380         _initialize_cli_style): Likewise.
 381         * corelow.c (core_target_info): Likewise.
 382         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 383         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 384         * filesystem.c (_initialize_filesystem): Likewise.
 385         * frame.c (_initialize_frame): Likewise.
 386         * gnu-nat.c (add_task_commands): Likewise.
 387         * infcall.c (_initialize_infcall): Likewise.
 388         * infcmd.c (_initialize_infcmd): Likewise.
 389         * interps.c (_initialize_interpreter): Likewise.
 390         * language.c (_initialize_language): Likewise.
 391         * linux-fork.c (_initialize_linux_fork): Likewise.
 392         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 393         * maint.c (_initialize_maint_cmds): Likewise.
 394         * memattr.c (_initialize_mem): Likewise.
 395         * printcmd.c (_initialize_printcmd): Likewise.
 396         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 397         _RegEx): Likewise.
 398         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 399         * record-btrace.c (_initialize_record_btrace): Likewise.
 400         * record-full.c (_initialize_record_full): Likewise.
 401         * record.c (_initialize_record): Likewise.
 402         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 403         * regcache.c (_initialize_regcache): Likewise.
 404         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 405         _initialize_remote): Likewise.
 406         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 407         * serial.c (_initialize_serial): Likewise.
 408         * skip.c (_initialize_step_skip): Likewise.
 409         * source.c (_initialize_source): Likewise.
 410         * stack.c (_initialize_stack): Likewise.
 411         * symfile.c (_initialize_symfile): Likewise.
 412         * symtab.c (_initialize_symtab): Likewise.
 413         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 414         * top.c (init_main): Likewise.
 415         * tracefile-tfile.c (tfile_target_info): Likewise.
 416         * tracepoint.c (_initialize_tracepoint): Likewise.
 417         * tui/tui-win.c (_initialize_tui_win): Likewise.
 418         * utils.c (add_internal_problem_command): Likewise.
 419         * valprint.c (value_print_option_defs): Likewise.
 420
 421 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 422
 423         PR build/24886
 424         * configure.ac: Drop enable-libmcheck support.
 425         * configure, config.in: Rebuild.
 426         * libmcheck.m4: Remove.
 427         * acinclude.m4: Don't include it.
 428         * Makefile.in: Don't distribute it.
 429         * top.c (print_gdb_configuration): Don't mention it.
 430
 431 2019-08-06  Tom Tromey  <tom@tromey.com>
 432
 433         * utils.c (set_output_style): Sometimes pass stream to
 434         emit_style_escape.
 435         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 436         * record-btrace.c (btrace_insn_history): Update.
 437         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 438         method.
 439         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 440         Update initializers.
 441         <m_uiout>: New field.
 442         <m_di>: Move lower.
 443         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 444         Remove "uiout" parameter.
 445         (dump_insns): Update.
 446         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 447         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 448
 449 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 450
 451         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 452         (error_in_psymtab_expansion): Likewise.
 453         (lookup_symbol_via_quick_fns): Likewise.
 454         (basic_lookup_transparent_type_quick): Likewise.
 455         (basic_lookup_transparent_type_1): Likewise.
 456
 457 2019-08-06  Tom Tromey  <tromey@adacore.com>
 458
 459         * source.c (last_source_error): Now bool.
 460         (print_source_lines_base): Make "noprint" bool.  Only open
 461         source file when last_source_visited changes.
 462
 463 2019-08-06  Tom Tromey  <tromey@adacore.com>
 464
 465         * annotate.c (annotate_source_line): Use g_source_cache.
 466         * source-cache.c (source_cache::get_plain_source_lines): Change
 467         parameters.  Populate m_offset_cache.
 468         (source_cache::ensure): New method.
 469         (source_cache::get_line_charpos): New method.
 470         (extract_lines): Move lower.  Change parameters.
 471         (source_cache::get_source_lines): Move lower.
 472         * source-cache.h (class source_cache): Update comment.
 473         <get_line_charpos>: New method.
 474         <get_source_lines>: Update comment.
 475         <clear>: Clear m_offset_cache.
 476         <get_plain_source_lines>: Change parameters.
 477         <ensure>: New method
 478         <m_offset_cache>: New member.
 479         * source.c (forget_cached_source_info_for_objfile): Update.
 480         (info_source_command): Use g_source_cache.
 481         (find_source_lines, open_source_file_with_line_charpos): Remove.
 482         (print_source_lines_base, search_command_helper): Use g_source_cache.
 483         * source.h (open_source_file_with_line_charpos): Don't declare.
 484         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 485         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 486         Use g_source_cache.
 487
 488 2019-08-06  Tom Tromey  <tromey@adacore.com>
 489
 490         * source-cache.c (source_cache::get_plain_source_lines):
 491         Remove "first_line" and "last_line" parameters.
 492         (source_cache::get_source_lines): Cache plain text.
 493         * source-cache.h (class source_cache)
 494         <get_plain_source_lines>: Update.
 495
 496 2019-08-06  Tom Tromey  <tromey@adacore.com>
 497
 498         * source-cache.c (extract_lines): No longer a method.
 499         Changed type of parameter.  Include final newline.
 500         (selftests::extract_lines_test): New function.
 501         (_initialize_source_cache): Likewise.
 502         * source-cache.h (class source_cache)
 503         <extract_lines>: Don't declare.
 504
 505 2019-08-06  Tom Tromey  <tromey@adacore.com>
 506
 507         * breakpoint.c (init_breakpoint_sal): Update.
 508         (breakpoint): Update.
 509         * breakpoint.h (struct breakpoint) <filter>: Now a
 510         unique_xmalloc_ptr.
 511
 512 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 513
 514         * NEWS: Mention dictionary access on blocks.
 515         * python/py-block.c (blpy_getitem): New function.
 516         (block_object_as_mapping): New struct.
 517         (block_object_type): Use new struct for tp_as_mapping field.
 518
 519 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 520
 521         * objfiles.h (objfile): Add a comment describing partial symbols.
 522
 523 2019-08-05  Tom Tromey  <tromey@adacore.com>
 524
 525         * compile/compile.c (_initialize_compile): Use _(), not N_().
 526         * thread.c (_initialize_thread): Use _(), not N_().
 527         * stack.c (_initialize_stack): Use _(), not N_().
 528         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 529
 530 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 531
 532         * dwarf2read.c (struct dw2_symtab_iterator):
 533         <want_specific_block>: Remove.
 534         <block_index>: Change type to gdb::optional.
 535         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 536         change type of BLOCK_INDEX parameter to gdb::optional.
 537         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 538         (dw2_lookup_symbol): Don't pass argument for
 539         WANT_SPECIFIC_BLOCK.
 540         (dw2_expand_symtabs_for_function): Don't pass argument for
 541         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 542         (class dw2_debug_names_iterator)
 543         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 544         parameter, change BLOCK_INDEX type to gdb::optional.
 545         <m_want_specific_block>: Remove.
 546         <m_block_index>: Change type to gdb::optional.
 547         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 548         gdb::optional.  Re-write in function of gdb::optional.
 549         (dw2_debug_names_lookup_symbol): Don't pass argument for
 550         WANT_SPECIFIC_BLOCK.
 551         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 552         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 553         BLOCK_INDEX.
 554
 555 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 556
 557         * NEWS: Mention changes to "info sources" command.
 558
 559 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 560
 561         * symtab.c (filename_partial_match_opts): New struct type.
 562         (struct output_source_filename_data): New members
 563         regexp, c_regexp, partial_match.
 564         (output_source_filename): Use new members to decide to print file.
 565         (info_sources_option_defs): New variable.
 566         (make_info_sources_options_def_group, print_info_sources_header,
 567         info_sources_command_completer):
 568         New functions.
 569         (info_sources_command): Read new optional arguments.
 570         (_initialize_symtab): Update info sources help.
 571
 572 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 573
 574         * ada-lang.c (exception_support_info_v0): Renamed from...
 575         (default_exception_support_info): ... this.  Create new
 576         definition for v1.
 577         (ada_has_this_exception_support): Look up catch_handlers_sym.
 578         (ada_exception_support_info_sniffer): Try v0 after default.
 579
 580 2019-08-01  Tom Tromey  <tromey@adacore.com>
 581
 582         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 583         gdbarch.h.
 584
 585 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 586
 587         * s12z-tdep.c: Fix include path for s12z-opc.h.
 588
 589 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 590
 591         * NEWS: Require GNU make 3.82.
 592
 593 2019-07-16  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 596         declare.
 597
 598 2019-07-30  Tom Tromey  <tromey@adacore.com>
 599
 600         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 601
 602 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 603
 604         * printcmd.c (print_address_symbolic): Print negative offsets.
 605         (build_address_symbolic): Force signed arithmetic when computing
 606         offset.
 607
 608 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 609
 610         PR/24474: Add a function to lookup static variables.
 611         * NEWS: Mention this new function.
 612         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 613         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 614         * python/python.c (python_GdbMethods): Add new function.
 615
 616 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 617
 618         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 619         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 620         (objfpy_lookup_static_symbol): New function.
 621         (objfile_object_methods): Add new functions.
 622
 623 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 624
 625         * NEWS: Mention 'set|show print frame-info'.  Mention new
 626         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 627         backtrace argument.  Mention that python frame filtering code
 628         is now consistent with what 'backtrace' command prints.
 629
 630 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 631
 632         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 633         comments.
 634         (print_frame_info_auto, print_frame_info_source_line,
 635         print_frame_info_location, print_frame_info_source_and_location,
 636         print_frame_info_location_and_address, print_frame_info_short_location):
 637         New declarations.
 638         (struct frame_print_options): New member print_frame_info.
 639         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 640         * stack.h (get_user_print_what_frame_info): New declaration.
 641         (frame_show_address): New declaration.
 642         * stack.c (print_frame_arguments_choices): New value 'presence'.
 643         (print_frame_info_auto, print_frame_info_source_line,
 644         print_frame_info_location, print_frame_info_source_and_location,
 645         print_frame_info_location_and_address, print_frame_info_short_location,
 646         print_frame_info_choices, print_frame_info_print_what): New definitions.
 647         (print_frame_args): Only print dots for args if print frame-arguments
 648         is 'presence'.
 649         (frame_print_option_defs): New element for "frame-info".
 650         (get_user_print_what_frame_info): New function.
 651         (frame_show_address): Make non static.  Move comment to stack.h.
 652         (print_frame_info_to_print_what): New function.
 653         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 654         to decide what to print.
 655         (backtrace_command_1): Handle the new print_frame_arguments_presence
 656         value.
 657         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 658         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 659         (py_print_frame): In non-mi mode, use LOCATION as default for
 660         print_what, similarly to frame information printed directly by
 661         backtrace command. Handle frame-info user option in non MI mode.
 662
 663 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 664
 665         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 666         Add case for debugging 32-bit target on 64-bit host.  Revise
 667         comment.
 668
 669 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 670
 671         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 672         instead of find_function_entry_range_from_pc.
 673
 674 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 675
 676         * stack.c (find_frame_funname): Remove code which preferred
 677         minsym over symtab sym in "certain pathological cases".
 678
 679         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 680         parameter.  Change type of "do_demangle" to bool.
 681         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 682         Pass suitable "prefer_sym_over_minsym" flag to
 683         build_address_symbolic().  Don't output "+" for negative offsets.
 684         * printcmd.c (print_address_symbolic): Update invocation of
 685         build_address_symbolic to include a "prefer_sym_over_minsym"
 686         flag.
 687         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 688         Restrict cases in which use of minimal symbol is preferred to that
 689         of a found symbol.  Update comments.
 690
 691         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 692         for entry pc when entry pc is out of range for that FDE.
 693
 694 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 695
 696         PR gdb/24839:
 697         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 698         type.
 699
 700 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 701
 702         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 703         this function's Python signature.
 704
 705
 706 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 707
 708         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 709         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 710         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 711         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 712         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 713
 714
 715 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 716
 717         * h8300-tdep.c (h8300_register_name_common): New.
 718         h8300_register_name): Use h8300_register_name_common.
 719         (h8300s_register_name): Likewise.
 720         (h8300sx_register_name): Likewise.
 721         (h8300h_register_nam): New.
 722         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 723
 724
 725 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 726
 727         * arm-tdep.c (arm_skip_cmse_entry): New function.
 728         (arm_is_sgstubs_section): New function.
 729         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 730
 731 2019-07-22  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 734         Don't self-assign.
 735
 736 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 737
 738         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 739         type_print.
 740
 741 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 742
 743         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 744         so that GDB doesn't match any msymbols when searching in the
 745         TYPES_DOMAIN.
 746         (print_symbol_info): Print using typedef_print or type_print based
 747         on the type of the symbol.  Add updated FIXME comment moved from...
 748         (_initialize_symtab): ... move and update FIXME comment to above.
 749
 750 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 751
 752         * NEWS: Mention adding -q option to "info types".
 753         * symtab.c (struct info_types_options): New struct.
 754         (info_types_options_defs): New variable.
 755         (make_info_types_options_def_group): New function.
 756         (info_types_command): Use gdb::option framework to parse options.
 757         (info_types_command_completer): New function.
 758         (_initialize_symtab): Extend the help text on "info types" and
 759         register command completer.
 760
 761 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 762
 763         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 764         (lookup_symbol_in_objfile): Change int to block_enum and add a
 765         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 766
 767 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 768
 769         * MAINTAINERS (Write After Approval): Add self.
 770
 771 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 774         instruction to the dummy code region.
 775
 776 2019-07-19  Tom Tromey  <tromey@adacore.com>
 777
 778         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 779         (ARGSUSED, PARAMS, __func__): Remove rules.
 780
 781 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 782
 783         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 784         * features/arm/arm-with-iwmmxt.c: Remove.
 785         * features/arm/arm-with-iwmmxt.xml: Remove.
 786         * features/arm/arm-with-m-fpa-layout.c: Remove.
 787         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 788         * features/arm/arm-with-m-vfp-d16.c: Remove.
 789         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 790         * features/arm/arm-with-m.c: Remove.
 791         * features/arm/arm-with-m.xml: Remove.
 792         * features/arm/arm-with-neon.c: Remove.
 793         * features/arm/arm-with-neon.xml: Remove.
 794         * features/arm/arm-with-vfpv2.c: Remove.
 795         * features/arm/arm-with-vfpv2.xml: Remove.
 796         * features/arm/arm-with-vfpv3.c: Remove.
 797         * features/arm/arm-with-vfpv3.xml: Remove.
 798
 799 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 800
 801         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 802
 803 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 804
 805         * arch/aarch32.c (aarch32_create_target_description): Create
 806         target descriptions using features.
 807         * arch/arm.c (arm_create_target_description)
 808         (arm_create_mprofile_target_description): Likewise.
 809         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 810
 811 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 812
 813         * Makefile.in: Add new files.
 814         * aarch32-tdep.c: New file.
 815         * aarch32-tdep.h: New file.
 816         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 817         Call aarch32_read_description.
 818         * arch/aarch32.c: New file.
 819         * arch/aarch32.h: New file.
 820         * arch/arm.c (arm_create_target_description)
 821         (arm_create_mprofile_target_description): New function.
 822         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 823         (arm_create_target_description)
 824         (arm_create_mprofile_target_description): New declaration.
 825         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 826         read_description functions.
 827         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 828         Likewise.
 829         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 830         * arm-tdep.c (tdesc_arm_list): New variable.
 831         (arm_register_g_packet_guesses): Call create description functions.
 832         (arm_read_description) (arm_read_mprofile_description): New
 833         function.
 834         * arm-tdep.h (arm_read_description)
 835         (arm_read_mprofile_description): Add declaration.
 836         * configure.tgt: Add new files.
 837
 838 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 839
 840         * top.c (new_ui_command): Open specified terminal just once.
 841
 842 2019-07-18  Tom Tromey  <tromey@adacore.com>
 843
 844         * symtab.c (main_name): Constify return type.
 845         * symfile.c (set_initial_language): Update.
 846         * symtab.h (main_name): Constify return type.
 847
 848 2019-07-17  Tom Tromey  <tom@tromey.com>
 849
 850         * tui/tui-winsource.c (tui_update_source_window)
 851         (tui_update_source_window_as_is)
 852         (tui_update_source_windows_with_line): Remove return.
 853         * tui/tui-disasm.c (tui_show_disassem)
 854         (tui_show_disassem_and_update_source): Remove return.
 855         * tui/tui.c (tui_reset): Remove return.
 856         * tui/tui-wingeneral.c
 857         (tui_check_and_display_highlight_if_needed): Remove return.
 858
 859 2019-07-17  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 862
 863 2019-07-17  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-winsource.h (struct tui_exec_info_window)
 866         (struct tui_source_window_base): Move from tui-data.h.
 867         * tui/tui-winsource.c: Move many method definitions from
 868         elsewhere.  Remove "structuring" comments.
 869         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 870         (tui_source_window_base::refresh_window): Move to
 871         tui-winsource.c.
 872         * tui/tui-win.c (tui_source_window_base::refresh_all)
 873         (tui_source_window_base::update_tab_width)
 874         (tui_source_window_base::set_new_height)
 875         (tui_source_window_base::do_make_visible_with_new_height): Move to
 876         tui-winsource.c.
 877         * tui/tui-source.h: Update.
 878         * tui/tui-source.c (tui_source_window_base::reset): Move to
 879         tui-winsource.c.
 880         * tui/tui-disasm.h: Update.
 881         * tui/tui-data.h (struct tui_exec_info_window): Move to
 882         tui-winsource.h.
 883         (struct tui_source_window_base): Likewise.
 884         * tui/tui-data.c (tui_source_window_base::clear_detail)
 885         (tui_source_window_base, ~tui_source_window_base): Move to
 886         tui-winsource.c.
 887
 888 2019-07-17  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-win.c (tui_resize_all)
 891         (tui_source_window_base::update_tab_width)
 892         (tui_adjust_win_heights): Update.
 893         (tui_win_info::make_invisible_and_set_new_height): Rename from
 894         make_invisible_and_set_new_height.
 895         * tui/tui-data.h (struct tui_win_info)
 896         <make_invisible_and_set_new_height>: New method.
 897
 898 2019-07-17  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui.c: Update.
 901         * tui/tui-source.h (struct tui_source_window): Move from
 902         tui-data.h.
 903         * tui/tui-layout.c: Update.
 904         * tui/tui-disasm.c: Update.
 905         * tui/tui-data.h (struct tui_source_window): Move to
 906         tui-source.h.
 907
 908 2019-07-17  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 911         tui-data.h.
 912         * tui/tui-data.h (struct tui_disasm_window): Move to
 913         tui-disasm.h.
 914
 915 2019-07-17  Tom Tromey  <tom@tromey.com>
 916
 917         * tui/tui-regs.h (struct tui_data_item_window): Move from
 918         tui-data.h.
 919         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 920         * tui/tui-data.h (struct tui_data_item_window): Move to
 921         tui-regs.h.
 922         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 923
 924 2019-07-17  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui.c: Update.
 927         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 928         (tui_cmd_window::max_height): Move to tui-command.c.
 929         * tui/tui-layout.c: Update.
 930         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 931         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 932         tui-command.c.
 933         * tui/tui-command.h (struct tui_cmd_window): Move from
 934         tui-data.h.
 935         * tui/tui-command.c: Remove "structuring" comments.
 936         (tui_cmd_window::clear_detail)
 937         (tui_cmd_window::do_make_visible_with_new_height)
 938         (tui_cmd_window::max_height): Move from elsewhere.
 939
 940 2019-07-17  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 943         Now static.
 944         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 945         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 946
 947 2019-07-17  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui.c: Update.
 950         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 951         tui-regs.c.
 952         * tui/tui-windata.h: Remove file.
 953         * tui/tui-windata.c: Remove file.
 954         * tui/tui-win.c (tui_data_window::set_new_height)
 955         (tui_data_window::do_make_visible_with_new_height): Move to
 956         tui-regs.c.
 957         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 958         * tui/tui-regs.c: Remove "structuring" comments.
 959         (tui_data_window::first_data_item_displayed)
 960         (tui_data_window::delete_data_content_windows)
 961         (tui_data_window::erase_data_content)
 962         (tui_data_window::display_all_data)
 963         (tui_data_window::refresh_all)
 964         (tui_data_window::do_scroll_vertical)
 965         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 966         (tui_data_window::do_make_visible_with_new_height)
 967         (tui_data_window::refresh_window): Move from elsewhere.
 968         (_initialize_tui_regs): Move to end of file.
 969         * tui/tui-layout.c: Update.
 970         * tui/tui-hooks.c: Update.
 971         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 972         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 973         tui-regs.c.
 974         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 975
 976 2019-07-17  Tom Tromey  <tom@tromey.com>
 977
 978         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 979         seen.
 980
 981 2019-07-17  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-win.c (tui_source_window_base::set_new_height)
 984         (tui_source_window_base::do_make_visible_with_new_height): Use
 985         m_has_locator field directly.
 986         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 987         method.
 988         (struct tui_source_window_base) <has_locator>: Likewise.
 989
 990 2019-07-17  Tom Tromey  <tom@tromey.com>
 991
 992         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 993         Don't declare.
 994         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 995         Remove.
 996         * tui/tui-win.c (tui_source_window_base::set_new_height)
 997         (tui_source_window_base::set_new_height)
 998         (make_invisible_and_set_new_height)
 999         (tui_source_window_base::do_make_visible_with_new_height)
1000         (tui_source_window_base::do_make_visible_with_new_height):
1001         Update.
1002         * tui/tui-layout.c (show_source_disasm_command, show_data)
1003         (show_source_or_disasm_and_command): Update.
1004         * tui/tui-layout.c (show_layout): Update.
1005
1006 2019-07-17  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-layout.c (make_data_window): Remove.
1009         (show_data): Unify creation and re-initialization cases.
1010
1011 2019-07-17  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-layout.c (make_source_window, make_disasm_window):
1014         Remove.
1015         (show_data): Unify creation and re-initialization cases.
1016
1017 2019-07-17  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-layout.c (make_command_window): Remove.
1020         (show_source_disasm_command, show_source_or_disasm_and_command):
1021         Unify creation and re-initialization cases.
1022
1023 2019-07-17  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1026         creation and re-initialization cases.
1027
1028 2019-07-17  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-regs.c (tui_get_register): Return void.
1031
1032 2019-07-17  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1035         Simplify.
1036
1037 2019-07-17  Tom Tromey  <tom@tromey.com>
1038
1039         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1040         resetting.
1041
1042 2019-07-17  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1045         * tui/tui-regs.c (tui_reg_layout): New function.
1046         (tui_show_registers, tui_reg_command): Use it.
1047         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1048         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1049         parameters.
1050         (tui_layout_command): Remove.
1051
1052 2019-07-17  Tom Tromey  <tom@tromey.com>
1053
1054         * tui/tui-layout.h (tui/tui-layout): Return void.
1055         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1056
1057 2019-07-17  Tom Tromey  <tom@tromey.com>
1058
1059         * tui/tui-layout.c (show_source_disasm_command, show_data):
1060         Update.
1061         (reset_locator): Remove.
1062         (show_source_or_disasm_and_command): Update.
1063
1064 2019-07-17  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-source.c (tui_source_window_base::reset): Remove
1067         win_type parameter.
1068         * tui/tui-layout.c (make_command_window, make_source_window)
1069         (make_disasm_window, make_data_window)
1070         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1071         (reset_locator, show_source_or_disasm_and_command): Update.
1072         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1073         win_type parameter.
1074         (struct tui_source_window_base) <reset>: Likewise.
1075
1076 2019-07-17  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-layout.c (show_source_disasm_command): Use
1079         reset_locator.
1080         (reset_locator): New function.
1081         (init_and_make_win): Remove.
1082         (show_source_or_disasm_and_command): Use reset_locator.
1083
1084 2019-07-17  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1087         condition.
1088         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1089         Remove condition.
1090         * tui/tui-source.c (tui_source_window_base::reset): New method.
1091         * tui/tui-layout.c (make_command_window): Don't call
1092         init_and_make_win.
1093         (make_source_window, make_disasm_window): Don't call
1094         make_source_or_disasm_window.
1095         (make_data_window): Don't call init_and_make_win.  Change calling
1096         convention.
1097         (show_source_disasm_command, show_data): Simplify.
1098         (make_source_or_disasm_window): Remove.
1099         (show_source_or_disasm_and_command): Simplify.
1100         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1101         (struct tui_source_window_base) <reset>: Likewise.
1102         <execution_info>: Remove initializer.
1103         * tui/tui-data.c (tui_source_window_base): Initialize
1104         execution_info.
1105
1106 2019-07-17  Tom Tromey  <tom@tromey.com>
1107
1108         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1109         variable.
1110
1111 2019-07-17  Tom Tromey  <tom@tromey.com>
1112
1113         * tui/tui.c (tui_rl_other_window): Update.
1114         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1115         superclass method first.  Always iterate over regs_content.
1116         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1117         method.
1118         * tui/tui-win.c (tui_set_focus_command): Update.
1119
1120 2019-07-17  Tom Tromey  <tom@tromey.com>
1121
1122         * tui/tui-win.c (tui_set_focus_command): Rename from
1123         tui_set_focus.  Call tui_enable.
1124         (tui_set_focus_command): Remove.
1125
1126 2019-07-17  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1129         refresh_window.
1130         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1131         touchwin.
1132         (tui_data_window::refresh_window): Call refresh_window on data
1133         items.  Always call superclass refresh_window.
1134         (tui_win_info::refresh): Remove.
1135         (tui_source_window_base::refresh_window): Update.
1136         (tui_refresh_all): Update.
1137         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1138         refresh_window.
1139         (show_source_or_disasm_and_command): Likewise.
1140         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1141         (struct tui_source_window_base) <refresh>: Likewise.
1142
1143 2019-07-17  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-winsource.c (tui_clear_source_content)
1146         (tui_show_source_content): Update.
1147         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1148         whether content is empty.
1149         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1150         Remove.
1151
1152 2019-07-17  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1155         window's contents.
1156         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1157         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1158
1159 2019-07-17  Tom Tromey  <tom@tromey.com>
1160
1161         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1162         (struct tui_data_item_window): Update.
1163
1164 2019-07-17  Tom Tromey  <tom@tromey.com>
1165
1166         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1167         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1168         defines.
1169
1170 2019-07-17  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-winsource.h (tui_erase_source_content)
1173         (tui_clear_source_content): Remove "display_prompt" parameter.
1174         * tui/tui-winsource.c (tui_update_source_window_as_is)
1175         (tui_update_source_windows_with_addr): Update.
1176         (tui_clear_source_content): Remove "display_prompt" parameter.
1177         (tui_erase_source_content): Likewise.  Simplify.
1178         (tui_show_source_content): Update.
1179         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1180         * tui/tui-stack.c (tui_show_frame_info): Update.
1181         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1182         Remove defines.
1183
1184 2019-07-17  Tom Tromey  <tom@tromey.com>
1185
1186         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1187         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1188         parameter.
1189         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1190         parameter.
1191
1192 2019-07-17  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-winsource.c (tui_clear_source_content)
1195         (tui_show_source_content, tui_show_exec_info_content)
1196         (tui_clear_exec_info_content): Update.
1197         * tui/tui-stack.c (tui_show_locator_content): Update.
1198         (tui_show_frame_info): Update.
1199         * tui/tui-source.h (tui_source_window): Don't declare.
1200         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1201         from tui_source_is_displayed.
1202         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1203         Remove field.
1204         (struct tui_source_window_base) <content_in_use>: New field.  Now
1205         bool.
1206         (struct tui_source_window) <showing_source_p>: New method.
1207         (TUI_SRC_WIN): Change cast.
1208         * tui/tui-data.c (tui_initialize_static_data): Update.
1209
1210 2019-07-17  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1213         location_matches_p.
1214         * tui/tui-source.c (tui_source_window::location_matches_p): New
1215         method.
1216         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1217         method.
1218         * tui/tui-data.h (struct tui_source_window_base)
1219         <location_matches_p>: New method.
1220         (struct tui_source_window, struct tui_disasm_window)
1221         <location_matches_p>: Likewise.
1222
1223 2019-07-17  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-win.c (tui_set_win_height_command): Rename from
1226         tui_set_win_height.
1227         (tui_set_win_height_command): Remove.
1228
1229 2019-07-17  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-source.c (tui_source_window): New constructor.  Add
1232         observer.
1233         (~tui_source_window): New destructor.
1234         (tui_source_window::style_changed): New method.
1235         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1236         (tui_attach_detach_observers): Update.
1237         * tui/tui-data.h (struct tui_source_window): Make constructor not
1238         inline.  Add destructor.
1239         (struct tui_source_window) <style_changed>: New method.
1240         <m_observable>: New member.
1241
1242 2019-07-17  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1245         * tui/tui-win.c (tui_resize_all): Fix typo.
1246
1247 2019-07-17  Tom Tromey  <tom@tromey.com>
1248
1249         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1250         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1251         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1252         * tui/tui-win.c (window_name_completer): Use foreach.
1253         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1254         (update_tab_width): Likewise.
1255         * tui/tui-layout.c (show_layout): Update.
1256         * tui/tui-data.h (class tui_window_iterator): New.
1257         (struct all_tui_windows): New.
1258         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1259
1260 2019-07-17  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1263         parameter.  Don't reference globals.
1264         (tui_reg_command): Update.
1265
1266 2019-07-17  Tom Tromey  <tom@tromey.com>
1267
1268         * tui/tui-regs.c (tui_show_registers): Simplify.
1269
1270 2019-07-17  Tom Tromey  <tom@tromey.com>
1271
1272         * tui/tui-regs.c (tui_show_registers): Update.
1273         (tui_show_register_group): Add win_info parameter.
1274
1275 2019-07-17  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1278         Rename from tui_display_reg_element_at_line.
1279         (tui_data_window::display_registers_from_line): Update.
1280         * tui/tui-data.h (struct tui_data_window)
1281         <display_reg_element_at_line>: New method.
1282
1283 2019-07-17  Tom Tromey  <tom@tromey.com>
1284
1285         * tui/tui-regs.h (tui_display_registers_from)
1286         (tui_display_registers_from_line): Don't declare.
1287         * tui/tui-windata.c (tui_data_window::display_all_data)
1288         (tui_data_window::refresh_all)
1289         (tui_data_window::do_scroll_vertical): Update.
1290         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1291         from tui_display_registers_from.
1292         (tui_display_reg_element_at_line): Update.
1293         (tui_data_window::display_registers_from_line): Rename from
1294         tui_display_registers_from_line.
1295         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1296         display_registers_from_line>: New methods.
1297
1298 2019-07-17  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1301         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1302         from tui_erase_data_content.
1303         (tui_data_window::display_all_data)
1304         (tui_data_window::refresh_all)
1305         (tui_data_window::do_scroll_vertical): Update.
1306         * tui/tui-regs.c (tui_show_registers): Update.
1307         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1308         New method.
1309
1310 2019-07-17  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1313         declare.
1314         * tui/tui-windata.c
1315         (tui_data_window::delete_data_content_windows): Rename from
1316         tui_delete_data_content_windows.
1317         (tui_data_window::display_all_data)
1318         (tui_data_window::do_scroll_vertical): Update.
1319         * tui/tui-data.h (struct tui_data_window)
1320         <delete_data_content_windows>: New method.
1321
1322 2019-07-17  Tom Tromey  <tom@tromey.com>
1323
1324         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1325         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1326
1327 2019-07-17  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1330         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1331         from tui_display_all_data.
1332         * tui/tui-win.c
1333         (tui_data_window::do_make_visible_with_new_height): Update.
1334         * tui/tui-regs.c (tui_show_registers): Update.
1335         * tui/tui-layout.c (tui_set_layout): Update.
1336         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1337         method.
1338
1339 2019-07-17  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1342         * tui/tui-windata.c (tui_display_data_from): Remove.
1343         (tui_data_window::refresh_all): Update.
1344
1345 2019-07-17  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1348         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1349         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1350         tui_display_registers_from_line.
1351         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1352         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1353         "force_display" parameter.
1354
1355 2019-07-17  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1358         declare.
1359         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1360         Rename from tui_first_reg_element_no_inline.
1361         (tui_display_reg_element_at_line)
1362         (tui_display_registers_from_line): Update.
1363         * tui/tui-data.h (struct tui_data_window)
1364         <first_reg_element_no_inline>: New method.
1365
1366 2019-07-17  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-windata.c (tui_display_data_from)
1369         (tui_data_window::do_scroll_vertical): Update.
1370         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1371         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1372         Rename from tui_line_from_reg_element_no.
1373         (tui_display_registers_from_line): Update.
1374         * tui/tui-data.h (struct tui_data_window)
1375         <line_from_reg_element_no>: New method.
1376
1377 2019-07-17  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1380         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1381         tui_last_regs_line_no.
1382         (tui_display_reg_element_at_line)
1383         (tui_display_registers_from_line): Update.
1384         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1385         method.
1386
1387 2019-07-17  Tom Tromey  <tom@tromey.com>
1388
1389         PR tui/24722:
1390         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1391         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1392         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1393         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1394         (tui_update_breakpoint_info): Likewise.
1395         * tui/tui-hooks.c (tui_event_create_breakpoint)
1396         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1397         Update.
1398
1399 2019-07-17  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1402
1403 2019-07-17  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-winsource.c (tui_update_source_window_as_is)
1406         (tui_update_source_windows_with_addr): Update.
1407         * tui/tui-source.h (tui_set_source_content)
1408         (tui_show_symtab_source): Add "win_info" parameter.
1409         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1410         parameter.
1411         (tui_show_symtab_source): Likewise.
1412
1413 2019-07-17  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-wingeneral.c
1416         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1417
1418 2019-07-17  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1421         (struct tui_cmd_window) <can_scroll>: New method.
1422         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1423         method.
1424
1425 2019-07-17  Tom Tromey  <tromey@adacore.com>
1426
1427         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1428         do_field_signed>: Rename.  Change type of "value".
1429         * ui-out.c (ui_out::field_signed): Rename from field_int.
1430         Change type of "value".
1431         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1432         type of "value".
1433         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1434         do_field_int.  Change type of "value".
1435         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1436         do_field_int.  Change type of "value".
1437         * tracepoint.c (trace_status_mi, tfind_1)
1438         (print_one_static_tracepoint_marker): Update.
1439         * thread.c (print_thread_info_1, print_selected_thread_frame):
1440         Update.
1441         * stack.c (print_frame, print_frame_info): Update.
1442         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1443         Update.
1444         * source.c (print_source_lines_base): Update.
1445         * skip.c (info_skip_command): Update.
1446         * record-btrace.c (btrace_ui_out_decode_error)
1447         (btrace_call_history_src_line): Update.
1448         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1449         Update.
1450         * progspace.c (print_program_space): Update.
1451         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1452         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1453         do_field_int.  Change type of "value".
1454         * mi/mi-out.c (mi_ui_out::do_table_begin)
1455         (mi_ui_out::do_table_header): Update.
1456         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1457         type of "value".
1458         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1459         (mi_cmd_data_list_changed_registers, output_register)
1460         (mi_cmd_data_read_memory, mi_load_progress)
1461         (mi_cmd_trace_frame_collected): Update.
1462         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1463         Update.
1464         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1465         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1466         (mi_cmd_var_list_children, varobj_update_one): Update.
1467         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1468         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1469         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1470         * inferior.c (print_inferior): Update.
1471         * gdb_bfd.c (print_one_bfd): Update.
1472         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1473         Update.
1474         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1475         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1476         do_field_int.  Change type of "value".
1477         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1478         do_field_int.  Change type of "value".
1479         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1480         (print_one_breakpoint_location, print_it_catch_fork)
1481         (print_one_catch_fork, print_it_catch_vfork)
1482         (print_one_catch_vfork, print_it_catch_solib)
1483         (print_it_catch_exec, print_it_ranged_breakpoint)
1484         (print_mention_watchpoint, print_mention_masked_watchpoint)
1485         (bkpt_print_it, update_static_tracepoint): Update.
1486         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1487         * break-catch-syscall.c (print_it_catch_syscall): Update.
1488         * ada-tasks.c (print_ada_task_info): Update.
1489         * ada-lang.c (print_it_exception, print_mention_exception):
1490         Update.
1491
1492 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1493
1494         PR breakpoints/24541
1495         * gdbarch.c: Regenerate.
1496         * gdbarch.h: Regenerate.
1497         * gdbarch.sh: Adjust return type and parameter types for
1498         'stap_adjust_register'.
1499         (i386_stap_adjust_register): Adjust signature and return new
1500         register name.
1501         * stap-probe.c (stap_parse_register_operand): Adjust use of
1502         'gdbarch_stap_adjust_register'.
1503
1504 2019-07-17  Tom Tromey  <tromey@adacore.com>
1505
1506         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1507         declare VEC.
1508         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1509         std::vector.
1510         (struct s390_process_info): Add initializers.
1511         (s390_add_process): Use new.
1512         (s390_linux_nat_target::low_forget_process): Use delete.
1513         (s390_linux_nat_target::low_new_fork)
1514         (s390_linux_nat_target::stopped_by_watchpoint)
1515         (s390_linux_nat_target::low_prepare_to_resume)
1516         (s390_linux_nat_target::insert_watchpoint)
1517         (s390_linux_nat_target::insert_hw_breakpoint)
1518         (s390_linux_nat_target::remove_watchpoint)
1519         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1520
1521 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1522
1523         * aarch64-fbsd-nat.c: Include regcache.h.
1524         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1525         argument.
1526         (aarch64_fbsd_nat_target::fetch_registers)
1527         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1528         variable.
1529         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1530
1531 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1532
1533         * fbsd-nat.c: Include gdbarch.h.
1534
1535 2019-07-15  Tom Tromey  <tromey@adacore.com>
1536
1537         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1538
1539 2019-07-15  Tom Tromey  <tromey@adacore.com>
1540
1541         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1542         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1543         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1544         * cli-out.c (cli_ui_out::do_field_int): New method.
1545         * ui-out.c (ui_out::field_unsigned): New method.
1546         * symfile.c (generic_load): Use field_unsigned.
1547         (print_transfer_performance): Likewise.
1548         * record-btrace.c (ui_out_field_uint): Remove.
1549         (btrace_call_history_insn_range, btrace_call_history): Use
1550         field_unsigned.
1551         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1552         field_unsigned.
1553         * ui-out.h (class ui_out) <field_unsigned>: New method.
1554         <do_field_unsigned>: Likewise.
1555
1556 2019-07-15  Tom Tromey  <tromey@adacore.com>
1557
1558         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1559         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1560         * target.c (flash_erase_command): Use field_string.
1561         * infrun.c (print_signal_received_reason): Use field_string.
1562         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1563         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1564         field_string.
1565         * ada-tasks.c (print_ada_task_info): Use field_string.
1566
1567 2019-07-15  Tom Tromey  <tromey@adacore.com>
1568
1569         * target.c (flash_erase_command): Use field_core_addr.
1570         * symfile.c (generic_load): Use field_core_addr.
1571         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1572         Use field_core_addr.
1573         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1574         field_core_addr.
1575
1576 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1579         value if its desired type is smaller than a CORE_ADDR and signed.
1580
1581 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1582
1583         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1584         of changes to field names, and use new is_reference field to
1585         decide if a property is a reference or not.
1586         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1587         field.
1588         (struct dwarf2_property_baton): Update header comment, rename
1589         'referenced_type' to 'property_type' and update comments.
1590         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1591         default property type, store in property baton, update to take
1592         accound of renamed field.
1593         (read_func_scope): Update call to attr_to_dynamic_prop.
1594         (read_array_type): Likewise.
1595         (dwarf2_per_cu_addr_sized_int_type): New function.
1596         (read_subrange_index_type): Move type finding code to
1597         dwarf2_per_cu_addr_sized_int_type.
1598         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1599         (dwarf2_per_cu_addr_type): New function.
1600         (set_die_type): Update calls to attr_to_dynamic_prop.
1601
1602 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1603
1604         * dwarf2read.c (read_subrange_index_type): New function.
1605         (read_subrange_type): Move code into new function and call it.
1606         * gdbtypes.c (create_range_type): Add some asserts.
1607
1608 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1609
1610         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1611         update return statements.
1612         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1613         declaration, and update comment to match.
1614         * gdbtypes.c (resolve_dynamic_array): Update call to
1615         dwarf2_evaluate_property to match new return type.
1616
1617 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1618
1619         * valarith.c (value_subscripted_rvalue): Change lowerbound
1620         parameter type from int to LONGEST.
1621         * value.h (value_subscripted_rvalue): Likewise in declaration.
1622
1623 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1624
1625         * cli/cli-utils.c (info_print_command_completer): New function.
1626         * cli/cli-utils.h: Add 'completer.h' include, and forward
1627         declaration for 'struct cmd_list_element'.
1628         (info_print_command_completer): Declare.
1629         * stack.c (_initialize_stack): Add completer for 'info locals' and
1630         'info args'.
1631         * symtab.c (_initialize_symtab): Add completer for 'info
1632         variables' and 'info functions'.
1633         * NEWS: Mention completion for additional info commands.
1634
1635 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * cli/cli-utils.c (extract_info_print_args): Delete.
1638         (extract_arg_maybe_quoted): Delete.
1639         (info_print_options_defs): New variable.
1640         (make_info_print_options_def_group): New function.
1641         (extract_info_print_options): Define new function.
1642         * cli/cli-utils.h (extract_info_print_args): Delete.
1643         (struct info_print_options): New structure.
1644         (extract_info_print_options): Declare new function.
1645         * stack.c (info_locals_command): Update to use new
1646         extract_info_print_options, also add a header comment.
1647         (info_args_command): Likewise.
1648         * symtab.c (info_variables_command): Likewise.
1649         (info_functions_command): Likewise.
1650
1651 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1652
1653         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1654         to extract string arguments.
1655         * common/common-utils.c (extract_string_maybe_quoted): New function.
1656         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1657
1658 2019-07-11  Tom Tromey  <tromey@adacore.com>
1659
1660         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1661         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1662         * top.h (gdbinit): Don't declare.
1663         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1664         into...
1665         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1666         * top.c (gdb_init): Don't call init_cli_cmds.
1667         (gdbinit): Remove.
1668         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1669
1670 2019-07-11  Tom Tromey  <tromey@adacore.com>
1671
1672         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1673         after it has been moved.
1674
1675 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1676
1677         * valops.c (value_must_coerce_to_target): Change return type to
1678         bool.
1679         * value.h (value_must_coerce_to_target): Likewise.
1680
1681 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1682
1683         * breakpoint.c (is_hardware_watchpoint): Remove
1684         forward-declaration.
1685         (is_masked_watchpoint): Change return type to bool.
1686         (is_tracepoint): Likewise.
1687         (is_breakpoint): Likewise.
1688         (is_hardware_watchpoint): Likewise.
1689         (is_watchpoint): Likewise.
1690         (is_no_memory_software_watchpoint): Likewise.
1691         (is_catchpoint): Likewise.
1692         (breakpoint_1): Make FILTER parameter's return type bool.
1693         is_masked_watchpoint): Change return type to bool.
1694         (save_breakpoints): Make FILTER parameter's return type bool.
1695         * breakpoint.h (is_breakpoint): Change return type to bool.
1696         (is_watchpoint): Likewise.
1697         (is_catchpoint): Likewise.
1698         (is_tracepoint): Likewise.
1699
1700 2019-07-10  Tom Tromey  <tom@tromey.com>
1701
1702         * defs.h: Don't include gdbarch.h.
1703         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1704         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1705         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1706         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1707         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1708         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1709         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1710         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1711         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1712         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1713         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1714         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1715         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1716         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1717         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1718         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1719         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1720         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1721         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1722         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1723         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1724         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1725         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1726         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1727         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1728         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1729         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1730
1731 2019-07-10  Tom Tromey  <tromey@adacore.com>
1732
1733         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1734         * breakpoint.c (init_ada_exception_breakpoint): Register as
1735         bp_catchpoint.
1736         (print_one_breakpoint_location, print_one_breakpoint): Use
1737         is_ada_exception_catchpoint.
1738         * ada-lang.c (class ada_catchpoint_location): Pass
1739         bp_loc_software_breakpoint to bp_location constructor.
1740         (is_ada_exception_catchpoint): New function.
1741
1742 2019-07-10  Tom Tromey  <tromey@adacore.com>
1743
1744         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1745         VEC.
1746         (struct arm_exidx_entry): New method operator<.
1747         (struct arm_exidx_data) <section_maps>: Change type.
1748         (arm_exidx_data_free): Remove.
1749         (arm_exidx_data_key): Change type.  Move lower.
1750         (arm_exidx_new_objfile): Update.
1751         (arm_compare_exidx_entries): Remove.
1752         (arm_find_exidx_entry, _initialize_arm_tdep)
1753
1754 2019-07-10  Tom Tromey  <tromey@adacore.com>
1755
1756         * solib-spu.c (ocl_program_data_key): Change type.
1757         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1758         Update.
1759
1760 2019-07-10  Tom Tromey  <tromey@adacore.com>
1761
1762         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1763         (struct solib_aix_inferior_data) <library_list>: Change type.
1764         (solib_aix_inferior_data_handle): Change type.
1765         (get_solib_aix_inferior_data): Update.
1766         (solib_aix_free_library_list): Remove.
1767         (library_list_start_library): Update.
1768         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1769         return type.
1770         (solib_aix_get_library_list)
1771         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1772         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1773
1774 2019-07-10  Tom Tromey  <tromey@adacore.com>
1775
1776         * solib-dsbt.c (struct dsbt_info): Add initializers.
1777         (solib_dsbt_pspace_data): Change type.
1778         (dsbt_pspace_data_cleanup): Remove.
1779         (get_dsbt_info, _initialize_dsbt_solib): Update.
1780
1781 2019-07-10  Tom Tromey  <tromey@adacore.com>
1782
1783         * spu-tdep.c (spu_overlay_data): Change type.
1784         (spu_get_overlay_table, spu_overlay_new_objfile)
1785         (_initialize_spu_tdep): Update.
1786
1787 2019-07-10  Tom Tromey  <tromey@adacore.com>
1788
1789         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1790         destructor.
1791         (dbx_objfile_data_key): Change type and declare later.
1792         (DBX_SYMFILE_INFO): Rewrite.
1793         * dbxread.c (dbx_objfile_data_key): Change type.
1794         (dbx_symfile_init): Update.
1795         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1796         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1797         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1798
1799 2019-07-10  Tom Tromey  <tromey@adacore.com>
1800
1801         * jit.c (jit_program_space_key): Change type.  Move lower.
1802         (get_jit_program_space_data): Update.
1803         (jit_program_space_data_cleanup): Remove.
1804         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1805         Update.
1806         (struct jit_program_space_data): Add initializers.
1807
1808 2019-07-10  Tom Tromey  <tromey@adacore.com>
1809
1810         * solib-darwin.c (struct darwin_info): Add initializers.
1811         (solib_darwin_pspace_data): Change type.
1812         (darwin_pspace_data_cleanup): Remove.
1813         (get_darwin_info, _initialize_darwin_solib): Update.
1814
1815 2019-07-10  Tom Tromey  <tromey@adacore.com>
1816
1817         * remote-sim.c (struct sim_inferior_data): Add initializers,
1818         constructor, and destructor.
1819         (sim_inferior_data_key): Change type.  Move lower.
1820         (check_for_duplicate_sim_descriptor): Update.
1821         (get_sim_inferior_data): Use new.  Update.
1822         (~sim_inferior_data_cleanup): Rename from
1823         sim_inferior_data_cleanup.  Simplify.
1824         (gdbsim_close_inferior, simulator_command)
1825         (sim_command_completer, _initialize_remote_sim): Update.
1826         (next_pid, INITIAL_PID): Move earlier.
1827
1828 2019-07-10  Tom Tromey  <tromey@adacore.com>
1829
1830         * python/python-internal.h (create_thread_object): Return
1831         gdbpy_ref.
1832         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1833         * python/py-inferior.c (struct threadlist_entry): Add
1834         constructor.
1835         <thread_obj>: Now a gdbpy_ref.
1836         (thread_to_thread_object): Update.
1837         (add_thread_object): Use new.
1838         (delete_thread_object): Use delete.
1839         (infpy_threads): Update.
1840         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1841         GIL.
1842
1843 2019-07-10  Tom Tromey  <tromey@adacore.com>
1844
1845         * valops.c (value_cast): Specialize error message for Ada.
1846
1847 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1848
1849         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1850
1851 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1852
1853         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1854         bpstat_should_step): Return bool, adjust comments.
1855         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1856         bpstat_should_step): Likewise.
1857
1858 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1859
1860         * features/Makefile: Use feature target descriptions for Arm.
1861         * features/arm/arm-core.c: Generate new file.
1862         * features/arm/arm-fpa.c: Likewise.
1863         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1864         * features/arm/arm-m-profile.c: Likewise.
1865         * features/arm/arm-vfpv2.c: Likewise.
1866         * features/arm/arm-vfpv3.c: Likewise.
1867         * features/arm/xscale-iwmmxt.c: Likewise.
1868         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1869
1870 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1871
1872         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1873         ptrace earlier.
1874
1875 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1876
1877         * features/aarch64-pauth.c: Regenerate.
1878
1879 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1880
1881         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1882         bool.
1883         (bpstat_what): Use false instead of 0.
1884
1885 2019-07-09  Pedro Alves  <palves@redhat.com>
1886
1887         * break-catch-throw.c (is_exception_catchpoint): New.
1888         * breakpoint.c (print_one_breakpoint_location): New parameter
1889         'raw_loc'.  Handle it.  Use
1890         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1891         looking at the breakpoint's type.
1892         (print_one_breakpoint): If handling "maint info breakpoints", also
1893         print locations of exception catchpoints.
1894         * breakpoint.h (is_exception_catchpoint): Declare.
1895
1896 2019-07-09  Pedro Alves  <palves@redhat.com>
1897
1898         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1899         "addr" field.
1900         (allocate_location_exception_catchpoint): New.
1901         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1902         (initialize_throw_catchpoint_ops): Install
1903         allocate_location_exception_catchpoint as allocate_location
1904         method.
1905         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1906         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1907         bp_loc_other.
1908         (breakpoint_address_is_meaningful): Delete.
1909         (bl_address_is_meaningful): New.
1910         (breakpoint_locations_match): Adjust comment.
1911         (bp_location_from_bp_type): New, factored out of...
1912         (bp_location::bp_location(breakpoint *)): ... this.
1913         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1914         factored out of...
1915         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1916         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1917         breakpoint_address_is_meaningful.
1918         (bp_locations_compare): Adjust comment.
1919         (update_global_location_list): Use bl_address_is_meaningful
1920         instead of breakpoint_address_is_meaningful.
1921         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1922         explicit.
1923         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1924         * python/py-breakpoint.c (bppy_get_location): No longer check
1925         whether location is null.
1926
1927 2019-07-09  Pedro Alves  <palves@redhat.com>
1928
1929         PR c++/15468
1930         * breakpoint.c (print_one_breakpoint_location): Remove
1931         single-location assert.
1932
1933 2019-07-09  Tom Tromey  <tom@tromey.com>
1934
1935         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1936         * configure: Rebuild.
1937         * configure.ac: Change common to gdbsupport.
1938         * gdbsupport: Rename from common.
1939         * acinclude.m4: Change common to gdbsupport.
1940         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1941         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1942         gdbsupport.
1943         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1944         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1945         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1946         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1947         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1948         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1949         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1950         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1951         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1952         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1953         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1954         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1955         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1956         coff-pe-read.c, command.h, compile/compile-c-support.c,
1957         compile/compile-c.h, compile/compile-cplus-symbols.c,
1958         compile/compile-cplus-types.c, compile/compile-cplus.h,
1959         compile/compile-loc2c.c, compile/compile.c, completer.c,
1960         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1961         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1962         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1963         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1964         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1965         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1966         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1967         features/aarch64-core.c, features/aarch64-fpu.c,
1968         features/aarch64-pauth.c, features/aarch64-sve.c,
1969         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1970         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1971         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1972         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1973         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1974         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1975         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1976         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1977         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1978         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1979         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1980         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1981         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1982         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1983         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1984         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1985         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1986         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1987         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1988         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1989         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1990         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1991         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1992         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1993         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1994         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1995         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1996         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1997         minsyms.c, mips-linux-tdep.c, namespace.h,
1998         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1999         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2000         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2001         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2002         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2003         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2004         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2005         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2006         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2007         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2008         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2009         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2010         procfs.c, producer.c, progspace.h, psymtab.h,
2011         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2012         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2013         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2014         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2015         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2016         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2017         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2018         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2019         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2020         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2021         target-memory.c, target.c, target.h, target/waitstatus.c,
2022         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2023         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2024         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2025         unittests/array-view-selftests.c,
2026         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2027         unittests/common-utils-selftests.c,
2028         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2029         unittests/format_pieces-selftests.c,
2030         unittests/function-view-selftests.c,
2031         unittests/lookup_name_info-selftests.c,
2032         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2033         unittests/mkdir-recursive-selftests.c,
2034         unittests/observable-selftests.c,
2035         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2036         unittests/parse-connection-spec-selftests.c,
2037         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2038         unittests/scoped_fd-selftests.c,
2039         unittests/scoped_mmap-selftests.c,
2040         unittests/scoped_restore-selftests.c,
2041         unittests/string_view-selftests.c, unittests/style-selftests.c,
2042         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2043         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2044         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2045         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2046         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2047         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2048
2049 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2050
2051         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2052         bool value.
2053         (decode_digits_ordinary): Set explicit_line field in sal.
2054         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2055         symtab_and_line that was set on an explicit line number in
2056         assembler code.  Do always update the recorded symtab and line if
2057         we do skip the prologue.
2058
2059 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2060
2061         * breakpoint.c (set_breakpoint_location_function): Remove
2062         explicit_loc parameter.
2063         (momentary_breakpoint_from_master): Update call to
2064         set_breakpoint_location_function.
2065         (add_location_to_breakpoint): Likewise.
2066
2067 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2068
2069         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2070         required features based on default bfd type when no specific bfd
2071         is present.
2072
2073 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2074
2075         * NEWS: Mention that GDB printf and eval commands can now print
2076         C-style and Ada-style convenience var strings without
2077         calling the inferior.
2078         * printcmd.c (printf_c_string): Locally print GDB internal var
2079         instead of transiting via the inferior.
2080         (printf_wide_c_string): Likewise.
2081
2082 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2083
2084         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2085
2086 2019-07-04  Tom Tromey  <tom@tromey.com>
2087
2088         PR tui/24724:
2089         * tui/tui-winsource.c (tui_clear_source_content): Update.
2090         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2091         (tui_update_breakpoint_info): Update.
2092         (tui_set_exec_info_content): Update.
2093         * tui/tui-source.c (tui_set_source_content_nil): Update.
2094         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2095         has_break.
2096         * tui/tui-data.h (enum tui_bp_flag): New.
2097         (tui_bp_flags): New enum flags type.
2098         (struct tui_source_element) <break_mode>: Change type.  Rename
2099         from has_break.
2100         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2101         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2102         constants.
2103         * tui/tui-winsource.h: Fix comment.
2104
2105 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2106
2107         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2108         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2109         (store_fpregs_to_thread)
2110         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2111         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2112         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2113         (IWMMXT_REGS_SIZE): Add define.
2114         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2115         (fetch_vfp_regs, store_vfp_regs)
2116         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2117         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2118
2119 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2120
2121         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2122         defines.
2123         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2124         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2125         (ARM_INT_REGISTER_SIZE): ...to this.
2126         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2127         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2128         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2129         (arm_linux_collect_gregset, supply_nwfpe_register)
2130         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2131         defines.
2132         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2133         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2134         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2135         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2136         (arm_return_in_memory, arm_store_return_value)
2137         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2138         (arm_record_ld_st_multiple): Likewise.
2139         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2140         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2141
2142 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2143
2144         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2145         AARCH64_DISPLACED_MODIFIED_INSNS.
2146         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2147         (aarch64_displaced_step_copy_insn): Likewise.
2148         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2149         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2150         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2151         ARM_DISPLACED_MODIFIED_INSNS.
2152         * arm-tdep.c (arm_gdbarch_init): Likewise.
2153         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2154         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2155         (struct arm_displaced_step_closure): Use
2156         ARM_DISPLACED_MODIFIED_INSNS.
2157
2158 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2159
2160         * features/Makefile: Remove unused xml files.
2161         * features/aarch64.xml: Remove.
2162         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2163         * features/i386/amd64-avx-avx512.xml: Remove.
2164         * features/i386/amd64-avx-linux.xml: Remove.
2165         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2166         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2167         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2168         * features/i386/amd64-avx-mpx.xml: Remove.
2169         * features/i386/amd64-avx.xml: Remove.
2170         * features/i386/amd64-linux.xml: Remove.
2171         * features/i386/amd64-mpx-linux.xml: Remove.
2172         * features/i386/amd64-mpx.xml: Remove.
2173         * features/i386/amd64.xml: Remove.
2174         * features/i386/i386-avx-avx512-linux.xml: Remove.
2175         * features/i386/i386-avx-avx512.xml: Remove.
2176         * features/i386/i386-avx-linux.xml: Remove.
2177         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2178         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2179         * features/i386/i386-avx-mpx-linux.xml: Remove.
2180         * features/i386/i386-avx-mpx.xml: Remove.
2181         * features/i386/i386-avx.xml: Remove.
2182         * features/i386/i386-linux.xml: Remove.
2183         * features/i386/i386-mmx-linux.xml: Remove.
2184         * features/i386/i386-mmx.xml: Remove.
2185         * features/i386/i386-mpx-linux.xml: Remove.
2186         * features/i386/i386-mpx.xml: Remove.
2187         * features/i386/i386.xml: Remove.
2188         * features/i386/x32-avx-avx512-linux.xml: Remove.
2189         * features/i386/x32-avx-linux.xml: Remove.
2190         * features/i386/x32-linux.xml: Remove.
2191
2192 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2193
2194         * regformats/aarch64.dat: Remove.
2195         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2196         * regformats/i386/amd64-avx-linux.dat: Remove.
2197         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2198         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2199         * regformats/i386/amd64-linux.dat: Remove.
2200         * regformats/i386/amd64-mpx-linux.dat: Remove.
2201         * regformats/i386/amd64.dat: Remove.
2202         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2203         * regformats/i386/i386-avx-linux.dat: Remove.
2204         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2205         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2206         * regformats/i386/i386-linux.dat: Remove.
2207         * regformats/i386/i386-mmx-linux.dat: Remove.
2208         * regformats/i386/i386-mpx-linux.dat: Remove.
2209         * regformats/i386/i386.dat: Remove.
2210         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2211         * regformats/i386/x32-avx-linux.dat: Remove.
2212         * regformats/i386/x32-linux.dat: Remove.
2213
2214 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2215
2216         * aarch64-tdep.c: Remove xml self tests.
2217         * amd64-linux-tdep.c: Likewise.
2218         * amd64-tdep.c: Likewise.
2219         * i386-linux-tdep.c: Likewise.
2220         * i386-tdep.c: Likewise.
2221
2222 2019-07-03  Pedro Alves  <palves@redhat.com>
2223
2224         PR cli/24732
2225         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2226         (pipe_cmd_option_defs): New.
2227         (make_pipe_cmd_options_def_group): New.
2228         (pipe_command): Use gdb::option::process_options.
2229         (pipe_command_completer): New function.
2230         (_initialize_cli_cmds): Install completer for "pipe" command.
2231
2232 2019-07-03  Pedro Alves  <palves@redhat.com>
2233
2234         * cli/cli-option.c (union option_value) <string>: New field.
2235         (struct option_def_and_value): Add ctor, move ctor, dtor and
2236         use DISABLE_COPY_AND_ASSIGN.
2237         (option_def_and_value::clear_value): New.
2238         (parse_option, save_option_value_in_ctx, get_val_type_str)
2239         (add_setshow_cmds_for_options): Handle var_string.
2240         * cli-option.h (union option_def::var_address) <string>: New
2241         field.
2242         (struct string_option_def): New.
2243         * maint-test-options.c (struct test_options_opts): Add default
2244         ctor and use DISABLE_COPY_AND_ASSIGN.
2245         <string_opt>: New field.
2246         (test_options_opts::~test_options_opts): New.
2247         (test_options_opts::dump): Also dump "-string".
2248         (test_options_option_defs): Install "string.
2249
2250 2019-07-03  Pedro Alves  <palves@redhat.com>
2251
2252         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2253         option_value with a null enumeration.
2254         (complete_options): Save the option values in the context.
2255         (save_option_value_in_ctx): New, factored out from ...
2256         (process_options): ... here.
2257         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2258         of the function.
2259         * maint-test-options.c (test_options_opts::dump): New, factored
2260         out from ...
2261         (maintenance_test_options_command_mode): ... here.
2262         (maintenance_test_options_command_completion_result): Delete.
2263         (maintenance_test_options_command_completion_text): Update
2264         comment.
2265         (maintenance_show_test_options_completion_result): Change
2266         prototype.  Just print
2267         maintenance_test_options_command_completion_text.
2268         (save_completion_result): New.
2269         (maintenance_test_options_completer_mode): Pass options context to
2270         complete_options, and then save a dump.
2271         (_initialize_maint_test_options): Use add_cmd to install "maint
2272         show test-options-completion-result".
2273
2274 2019-07-03  Pedro Alves  <palves@redhat.com>
2275
2276         * NEWS (New commands): Mention "with" and "maint with".
2277         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2278         (with_command, with_command_completer): New.
2279         (pipe_command): Adjust to new repeat_previous
2280         interface.
2281         (_initialize_cli_cmds): Install the "with" command and its "w"
2282         alias.
2283         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2284         declarations.
2285         * cli/cli-setshow.c (parse_cli_var_uinteger)
2286         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2287         argument strings for all var_types.
2288         (get_setshow_command_value_string): New, factored out from ...
2289         (do_show_command): ... this.
2290         * cli/cli-setshow.h: Include <string>.
2291         (get_setshow_command_value_string): Declare.
2292         * command.h (repeat_previous): Now returns const char *.  Adjust
2293         comment.
2294         * maint.c: Include "cli/cli-cmds.h".
2295         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2296         (_initialize_maint_cmds): Register the "maintenance with" command.
2297         * top.c (repeat_previous): Move bits from pipe_command here:
2298         Return the saved command line, if any; error out if there's no
2299         command to relaunch.
2300
2301 2019-07-03  Pedro Alves  <palves@redhat.com>
2302
2303         * NEWS (New commands): Mention "maint set/show test-settings"
2304         instead of "maint test-settings".
2305         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2306         (maintenance_test_settings_set_list): Rename to ...
2307         (maintenance_set_test_settings_list): ... this.
2308         (maintenance_test_settings_show_list): Rename to  ...
2309         (maintenance_show_test_settings_list): ... this.
2310         (maintenance_test_settings_cmd): Delete.
2311         (maintenance_test_settings_set_cmd): ...
2312         (maintenance_set_test_settings_cmd): ... this.
2313         (maintenance_test_settings_show_cmd): ...
2314         (maintenance_show_test_settings_cmd): ... this.
2315         (maintenance_test_settings_show_value_cmd):
2316         (maintenance_show_test_settings_value_cmd): ... this.
2317         (_initialize_maint_test_settings): No longer install the "maint
2318         test-settings" prefix command.  Rename "maint test-settings set"
2319         to "maint set test-settings", and "maint test-settings show" to
2320         "maint show test-settings".  Adjust all subcommands.
2321
2322 2019-07-03  Pedro Alves  <palves@redhat.com>
2323
2324         * maint-test-settings.c: Fix file's intro comment.  Replace all
2325         references to "test-options" with references to "test-settings",
2326         in comments.
2327
2328 2019-07-03  Pedro Alves  <palves@redhat.com>
2329
2330         * maint-test-settings.c (maintenance_test_settings_xxx)
2331         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2332         New.
2333         (maintenance_test_settings_enums): Use them.
2334         (maintenance_test_settings_enum): Default to
2335         maintenance_test_settings_xxx.
2336         (_initialize_maint_test_settings): Initialize
2337         MAINTENANCE_TEST_SETTINGS_FILENAME.
2338
2339 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2340
2341         * breakpoint.h (remove_breakpoints_inf): Change return type to
2342         void, move function documentation here.
2343         * breakpoint.c (remove_breakpoints_inf): Change return type to
2344         void, move function documentation to header.
2345
2346 2019-07-02  Pedro Alves  <palves@redhat.com>
2347
2348         * NEWS (Completion improvements): Mention "info threads".
2349         * thread.c (struct info_threads_opts, info_threads_option_defs)
2350         (make_info_threads_options_def_group): New.
2351         (info_threads_command): Use gdb::option::process_options.
2352         (info_threads_command_completer): New.
2353         (_initialize_thread): Use gdb::option::build_help to build the
2354         help text for "info threads".
2355
2356 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2357
2358         * defs.h (generic_load): Move from here...
2359         * symfile.h (generic_load): ... to here.  Rename name parameter
2360         to args.
2361         * symfile.c (generic_load): Add comment.
2362
2363 2019-07-01  Tom Tromey  <tromey@adacore.com>
2364
2365         * dwarf2read.c
2366         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2367         declaration of without_params.  Fix formatting.
2368
2369 2019-07-01  Tom Tromey  <tromey@adacore.com>
2370
2371         * ada-exp.y (find_primitive_type): Update.
2372         * ada-lang.h (ada_lookup_symbol): Update.
2373         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2374         parameter.
2375         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2376
2377 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2378
2379         PR breakpoints/24541
2380         * gdbarch.c: Regenerate.
2381         * gdbarch.h: Regenerate.
2382         * gdbarch.sh: Add 'stap_adjust_register'.
2383         * i386-tdep.c: Include '<unordered_set>'.
2384         (i386_stap_adjust_register): New function.
2385         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2386         * stap-probe.c (stap_parse_register_operand): Call
2387         'gdbarch_stap_adjust_register'.
2388
2389 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2390
2391         PR python/24742
2392         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2393         * python/python.c (do_start_initialization): Use 'xmalloc'
2394         instead of 'PyMem_Malloc'.
2395
2396 2019-06-28  Tom Tromey  <tromey@adacore.com>
2397
2398         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2399         for Ada.
2400
2401 2019-06-27  Tom Tromey  <tromey@adacore.com>
2402
2403         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2404         objfile_key.
2405         (arm_find_mapping_symbol, arm_record_special_symbol)
2406         (_initialize_arm_tdep): Update.
2407         (arm_objfile_data_free): Remove.
2408
2409 2019-06-27  Tom Tromey  <tromey@adacore.com>
2410
2411         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2412         to cp_print_static_field.
2413
2414 2019-06-26  Tom Tromey  <tromey@adacore.com>
2415
2416         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2417         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2418         declare.
2419
2420 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2421
2422         * features/aarch64-core.c (create_feature_aarch64_core):
2423         Regenerate.
2424         * features/aarch64-core.xml: Add cpsr flags.
2425
2426 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2427
2428         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2429         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2430
2431 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2432
2433         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2434         field.
2435         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2436         use.
2437         (arm_record_special_symbol): Don't insert new symbol in sorted
2438         position, push it at the end.
2439
2440 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2441
2442         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2443         (arm_mapping_symbol_s): Remove.
2444         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2445         (arm_mapping_symbol_vec): New typedef.
2446         (struct arm_per_objfile): Add constructor.
2447         <section_maps>: Change type to
2448         std::unique_ptr<arm_mapping_symbol_vec[]>.
2449         (arm_compare_mapping_symbols): Remove.
2450         (arm_find_mapping_symbol): Adjust to section_maps type change.
2451         (arm_objfile_data_free): Call delete on arm_per_objfile.
2452         (arm_record_special_symbol): Adjust to section_maps type change.
2453         Allocate arm_per_objfile with new.
2454
2455 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2456
2457         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2458         with the command prefix.
2459
2460 2019-06-25  Tom Tromey  <tom@tromey.com>
2461
2462         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2463         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2464
2465 2019-06-25  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2468         type.
2469         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2470         protected.
2471
2472 2019-06-25  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-winsource.c
2475         (tui_source_window_base::set_is_exec_point_at): Add check against
2476         LOA_ADDRESS.
2477
2478 2019-06-25  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-source.c (tui_set_source_content): Don't check before
2481         xfree.
2482         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2483
2484 2019-06-25  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-winsource.h (tui_update_source_window_as_is)
2487         (tui_alloc_source_buffer, tui_line_is_displayed)
2488         (tui_addr_is_displayed): Change type of win_info.
2489         * tui/tui-winsource.c (tui_update_source_window_as_is)
2490         (tui_clear_source_content, tui_show_source_line)
2491         (tui_show_source_content, tui_source_window_base::refill)
2492         (tui_source_window_base::set_is_exec_point_at)
2493         (tui_source_window_base::set_is_exec_point_at)
2494         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2495         (tui_alloc_source_buffer, tui_line_is_displayed)
2496         (tui_addr_is_displayed): Change type of win_info.  Update.
2497         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2498         (tui_source_window_base::do_make_visible_with_new_height):
2499         Update.
2500         * tui/tui-source.c (tui_set_source_content)
2501         (tui_set_source_content_nil)
2502         (tui_source_window::do_scroll_vertical): Update.
2503         * tui/tui-layout.c (show_layout): Update.
2504         * tui/tui-disasm.c (tui_set_disassem_content)
2505         (tui_disasm_window::do_scroll_vertical): Update.
2506         * tui/tui-data.h (tui_win_content): Remove.
2507         (struct tui_gen_win_info) <content, content_size>: Remove.
2508         (struct tui_source_element): Add initializers and destructor.
2509         (union tui_which_element, struct tui_win_element): Remove.
2510         (struct tui_source_window_base) <content>: New field.
2511         (struct tui_data_window): Remove destructor.
2512         (tui_alloc_content, tui_free_win_content)
2513         (tui_free_all_source_wins_content): Don't declare.
2514         * tui/tui-data.c (tui_initialize_static_data): Update.
2515         (init_content_element, tui_alloc_content): Remove.
2516         (~tui_gen_win_info): Update.
2517         (~tui_data_window, tui_free_all_source_wins_content)
2518         (tui_free_win_content, free_content, free_content_elements):
2519         Remove.
2520
2521 2019-06-25  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-winsource.h (tui_clear_source_content)
2524         (tui_erase_source_content, tui_show_source_content): Change type
2525         of win_info.
2526         * tui/tui-winsource.c (tui_clear_source_content)
2527         (tui_erase_source_content, tui_show_source_content): Change type
2528         of win_info.
2529         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2530         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2531         win_info.
2532         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2533         win_info.
2534         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2535
2536 2019-06-25  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-winsource.c (tui_clear_source_content)
2539         (tui_source_window_base::set_is_exec_point_at): Update.
2540         * tui/tui-source.c (tui_set_source_content_nil): Update.
2541         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2542         a bool.
2543         * tui/tui-data.c (init_content_element): Update.
2544
2545 2019-06-25  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2548         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2549         * tui/tui-layout.c (init_and_make_win): Update.
2550         * tui/tui.h (enum tui_win_type): Update.
2551         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2552         tui_win_is_auxillary.
2553         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2554         tui_win_is_auxillary.
2555
2556 2019-06-25  Tom Tromey  <tom@tromey.com>
2557
2558         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2559         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2560         (tui_delete_data_content_windows, tui_display_all_data)
2561         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2562         Update.
2563         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2564         * tui/tui-regs.c (tui_last_regs_line_no)
2565         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2566         (tui_show_registers): Update.
2567         (tui_show_register_group): Return void.  Update.
2568         (tui_display_registers_from, tui_display_reg_element_at_line)
2569         (tui_display_registers_from_line, tui_check_register_values):
2570         Update.
2571         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2572         member.
2573         (struct tui_data_window) <regs_content>: Now a std::vector.
2574         <regs_content_count>: Remove.
2575         (tui_add_content_elements, tui_free_data_content): Don't declare.
2576         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2577         (init_content_element): Remove DATA_WIN case.  Add assert.
2578         (tui_add_content_elements): Remove.
2579         (tui_data_window): Update.
2580         (tui_free_data_content): Remove.
2581         (free_content_elements): Remove DATA_WIN case.
2582
2583 2019-06-25  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-data.c (tui_data_item_window): Update.
2586         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2587         * tui/tui-windata.c (tui_display_all_data)
2588         (tui_display_data_from_line): Update.
2589         (tui_check_data_values): Remove.
2590         * tui/tui-regs.c (tui_show_register_group)
2591         (tui_display_reg_element_at_line): Update.
2592         * tui/tui-hooks.c (tui_register_changed)
2593         (tui_refresh_frame_and_register_information): Call
2594         tui_check_register_values.
2595         * tui/tui-data.h (struct tui_data_window) <data_content,
2596         data_content_count, data_type>: Remove.
2597         (enum tui_data_type): Remove.
2598
2599         * tui/tui-data.c (tui_data_window::clear_detail)
2600         (~tui_data_window): Update.
2601
2602 2019-06-25  Tom Tromey  <tom@tromey.com>
2603
2604         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2605         declare.
2606         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2607         Rename from tui_first_data_item_displayed.  Update.
2608         (tui_data_window::refresh_all)
2609         (tui_data_window::do_scroll_vertical): Update.
2610         * tui/tui-data.h (struct tui_data_window)
2611         <first_data_item_displayed>: Declare new method.
2612
2613 2019-06-25  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2616         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2617         contents...
2618         (tui_initialize_static_data): ...here.
2619
2620 2019-06-25  Tom Tromey  <tom@tromey.com>
2621
2622         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2623         (tui_display_registers_from, tui_check_register_values): Update.
2624         (tui_display_register): Remove win_info parameter; update.
2625         (tui_get_register): Change type of parameters.
2626         * tui/tui-data.h (struct tui_data_element): Remove.
2627         (union tui_which_element) <data>: Remove.
2628         <data_window>: Change type.
2629         (struct tui_data_item_window): New.
2630         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2631         case.  Add assert.
2632         (~tui_data_item_window): New destructor.
2633         (free_content_elements): Remove DATA_ITEM_WIN case.
2634
2635 2019-06-25  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2638         Remove.
2639
2640 2019-06-25  Tom Tromey  <tom@tromey.com>
2641
2642         * tui/tui-data.h (struct tui_command_element): Remove.
2643         (union tui_which_element) <command>: Remove.
2644         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2645         assert.
2646         (free_content_elements): Remove CMD_WIN case.
2647
2648 2019-06-25  Tom Tromey  <tom@tromey.com>
2649
2650         * tui/tui-layout.c (tui_set_layout): Update.
2651         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2652         * tui/tui-data.c (layout_def): Update.
2653
2654 2019-06-25  Tom Tromey  <tom@tromey.com>
2655
2656         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2657         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2658         (tui_source_window_base::set_new_height): Update.
2659         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2660         Update.
2661         (tui_set_locator_fullname, tui_set_locator_info)
2662         (tui_show_frame_info): Update.
2663         * tui/tui-source.c (tui_set_source_content)
2664         (tui_source_is_displayed): Update.
2665         * tui/tui-layout.c (show_source_disasm_command, show_data)
2666         (show_source_or_disasm_and_command): Update.
2667         * tui/tui-disasm.c (tui_set_disassem_content)
2668         (tui_get_begin_asm_address): Update.
2669         * tui/tui-data.h (struct tui_locator_element): Remove.
2670         (union tui_which_element) <locator>: Remove.
2671         (struct tui_locator_window): New.
2672         (tui_locator_win_info_ptr): Change return type.
2673         * tui/tui-data.c (_locator): Change type.
2674         (tui_locator_win_info_ptr): Change return type.
2675         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2676         (tui_alloc_content): Add assert.
2677
2678 2019-06-25  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui-winsource.c
2681         (tui_exec_info_window::maybe_allocate_content): New method.
2682         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2683         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2684         (make_source_or_disasm_window): Add cast.
2685         * tui/tui-data.h (union tui_which_element) <simple_string>:
2686         Remove.
2687         (struct tui_source_info): New.
2688         (struct tui_source_window_base) <execution_info>: Change type.
2689         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2690         case, and add assert.
2691         (tui_alloc_content): Add assert.
2692
2693 2019-06-25  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2696         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2697         * tui/tui-data.c (tui_alloc_win_info): Remove.
2698
2699 2019-06-25  Tom Tromey  <tom@tromey.com>
2700
2701         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2702         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2703         can_highlight.
2704
2705 2019-06-25  Tom Tromey  <tom@tromey.com>
2706
2707         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2708         make_visible_with_new_height method.
2709         (tui_win_info::make_visible_with_new_height): New method.
2710         (tui_source_window_base::do_make_visible_with_new_height)
2711         (tui_data_window::do_make_visible_with_new_height)
2712         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2713         (make_visible_with_new_height): Remove.
2714         (tui_resize_all, tui_adjust_win_heights): Use
2715         make_visible_with_new_height method.
2716         * tui/tui-data.h (struct tui_win_info)
2717         <do_make_visible_with_new_height, make_visible_with_new_height>:
2718         New methods.
2719         (struct tui_source_window_base, struct tui_data_window)
2720         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2721         methods.
2722
2723 2019-06-25  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2726         method.
2727         (update_tab_width): Call update_tab_width method.
2728         * tui/tui-data.h (struct tui_win_info)
2729         (struct tui_source_window_base) <update_tab_width>: New methods.
2730
2731 2019-06-25  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2734         parameter.
2735         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2736         parameter.
2737         (tui_gen_win_info::make_visible): Update.
2738         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2739         parameter.
2740         * tui/tui-data.h (enum tui_box): New enum.
2741         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2742
2743 2019-06-25  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2746         init_and_make_win for EXEC_INFO_WIN.
2747         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2748         longer inline.
2749         (struct tui_win_info) <~tui_win_info>: Inline.
2750         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2751         Don't declare.
2752         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2753         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2754         Remove.
2755         (tui_initialize_static_data): Update.
2756         (~tui_gen_win_info): Handle more cleanup here.
2757         (~tui_source_window_base): Delete "execution_info".
2758         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2759
2760 2019-06-25  Tom Tromey  <tom@tromey.com>
2761
2762         * tui/tui-layout.c (make_command_window): Don't set
2763         can_highlight.
2764         (show_source_disasm_command): Call the reset method.
2765         (show_data): Don't set can_highlight.  Call the reset method.
2766         (tui_gen_win_info::reset): Rename from init_gen_win_info
2767         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2768         (show_source_or_disasm_and_command): Call the reset method.
2769         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2770         (struct tui_cmd_window): Set can_highlight.
2771
2772 2019-06-25  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2775         from make_visible.
2776         (tui_make_visible, tui_make_invisible): Rewrite.
2777         (tui_win_info::make_visible): Remove.
2778         (tui_source_window_base::make_visible): Update.
2779         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2780         method.  Moved from...
2781         (struct tui_win_info) <make_visible>: ...here.
2782
2783 2019-06-25  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-winsource.c
2786         (tui_source_window_base::do_scroll_horizontal): Remove direction
2787         parameter.
2788         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2789         direction parameter.
2790         * tui/tui-win.c (tui_win_info::forward_scroll)
2791         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2792         (tui_win_info::right_scroll): Update.
2793         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2794         direction parameter.
2795         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2796         direction parameter.
2797         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2798         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2799         Remove direction parameter.
2800         (struct tui_source_window_base, struct tui_source_window)
2801         (struct tui_disasm_window, struct tui_data_window)
2802         (struct tui_cmd_window): Update.
2803
2804 2019-06-25  Tom Tromey  <tom@tromey.com>
2805
2806         * tui/tui-winsource.h (tui_set_exec_info_content)
2807         (tui_show_exec_info_content, tui_erase_exec_info_content)
2808         (tui_clear_exec_info_content, tui_update_exec_info): Change
2809         argument to tui_source_window_base.
2810         * tui/tui-winsource.c (tui_set_exec_info_content)
2811         (tui_show_exec_info_content, tui_erase_exec_info_content)
2812         (tui_clear_exec_info_content, tui_update_exec_info): Change
2813         argument to tui_source_window_base.
2814
2815 2019-06-25  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2818         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2819
2820 2019-06-25  Tom Tromey  <tom@tromey.com>
2821
2822         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2823         check.
2824
2825 2019-06-25  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2828         type to void.
2829         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2830         type to void.
2831         * tui/tui-source.c (tui_set_source_content): Update.
2832         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2833
2834 2019-06-25  Tom Tromey  <tom@tromey.com>
2835
2836         * tui/tui-win.c (window_name_completer, tui_set_focus)
2837         (tui_all_windows_info): Use name method.
2838         * tui/tui-data.h (struct tui_gen_win_info)
2839         (struct tui_source_window, struct tui_disasm_window)
2840         (struct tui_data_window, struct tui_cmd_window) <name>: New
2841         method.
2842         (tui_win_name): Don't declare.
2843         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2844         (tui_win_name): Remove.
2845
2846 2019-06-25  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-winsource.h (tui_update_source_window)
2849         (tui_update_source_window_as_is): Change parameter type.
2850         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2851         to be a tui_source_window_base.
2852         (tui_update_source_window_as_is): Likewise.
2853         * tui/tui-win.c (make_visible_with_new_height): Update.
2854
2855 2019-06-25  Tom Tromey  <tom@tromey.com>
2856
2857         * tui/tui-winsource.c (tui_erase_source_content)
2858         (tui_show_source_content, tui_show_exec_info_content)
2859         (tui_erase_exec_info_content): Use refresh_window method.
2860         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2861         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2862         from tui_refresh_win.
2863         (tui_data_window::refresh_window): New method.
2864         (tui_win_info::refresh, tui_source_window_base::refresh)
2865         (tui_refresh_all): Use refresh_window method.
2866         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2867         method.
2868         * tui/tui-regs.c (tui_display_register): Call refresh_window
2869         method.
2870         * tui/tui-layout.c (show_source_disasm_command)
2871         (show_source_or_disasm_and_command): Call refresh_window method.
2872         * tui/tui-data.h (struct tui_gen_win_info)
2873         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2874         New method.
2875
2876 2019-06-25  Tom Tromey  <tom@tromey.com>
2877
2878         * tui/tui.c (tui_rl_other_window, tui_enable)
2879         (tui_is_window_visible, tui_get_command_dimension): Update.
2880         * tui/tui-winsource.c (tui_update_source_window_as_is)
2881         (tui_clear_source_content, tui_erase_source_content)
2882         (tui_show_source_line, tui_source_window_base::refill)
2883         (tui_source_window_base::do_scroll_horizontal)
2884         (tui_source_window_base::set_is_exec_point_at)
2885         (tui_update_breakpoint_info, tui_set_exec_info_content)
2886         (tui_alloc_source_buffer, tui_line_is_displayed)
2887         (tui_addr_is_displayed): Update.
2888         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2889         (tui_check_and_display_highlight_if_needed)
2890         (tui_win_info::make_visible, tui_win_info::refresh)
2891         (tui_refresh_all): Update.
2892         * tui/tui-windata.c (tui_first_data_item_displayed)
2893         (tui_delete_data_content_windows, tui_erase_data_content)
2894         (tui_display_all_data, tui_data_window::refresh_all)
2895         (tui_check_data_values): Update.
2896         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2897         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2898         (tui_win_info::backward_scroll, tui_refresh_all_win)
2899         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2900         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2901         (tui_source_window_base::set_new_height)
2902         (tui_data_window::set_new_height)
2903         (make_invisible_and_set_new_height)
2904         (make_visible_with_new_height, new_height_ok)
2905         (parse_scrolling_args): Update.
2906         * tui/tui-stack.c (tui_show_frame_info): Update.
2907         * tui/tui-source.c (tui_set_source_content)
2908         (tui_set_source_content_nil, tui_source_is_displayed)
2909         (tui_source_window::do_scroll_vertical): Update.
2910         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2911         (tui_display_registers_from, tui_display_reg_element_at_line)
2912         (tui_check_register_values, tui_reg_command): Update.
2913         * tui/tui-layout.c (tui_default_win_height)
2914         (show_source_disasm_command, show_data, init_and_make_win)
2915         (show_source_or_disasm_and_command): Update.
2916         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2917         (tui_redisplay_readline, tui_mld_flush)
2918         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2919         (tui_getc): Update.
2920         * tui/tui-disasm.c (tui_set_disassem_content)
2921         (tui_disasm_window::do_scroll_vertical): Update.
2922         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2923         Now virtual.
2924         (struct tui_win_info): Derive from tui_gen_win_info.
2925         <~tui_win_info>: Mark as override.
2926         <generic>: Remove member.
2927         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2928         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2929         (~tui_data_window, ~tui_win_info)
2930         (tui_free_all_source_wins_content): Update.
2931         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2932
2933 2019-06-25  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-layout.c (init_and_make_win): Use new.
2936         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2937         destructor, initializers.
2938         (tui_alloc_generic_win_info): Don't declare.
2939         * tui/tui-data.c (_locator): Add argument to constructor.
2940         (source_win, disasm_win): New globals.
2941         (exec_info): Remove.
2942         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2943         Update.
2944         (tui_alloc_generic_win_info): Remove.
2945         (init_content_element): Use new.
2946         (tui_win_info::tui_win_info): Update.
2947         (free_content_elements) <case DATA_WIN>: Use delete.
2948
2949 2019-06-25  Tom Tromey  <tom@tromey.com>
2950
2951         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2952         * tui/tui-windata.c (tui_first_data_item_displayed)
2953         (tui_delete_data_content_windows): Update.
2954         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2955         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2956         (tui_display_registers_from, tui_check_register_values): Update.
2957         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2958         pointer.
2959         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2960         window.
2961         (tui_free_data_content): Update.
2962         (free_content_elements) <case DATA_WIN>: Free the window.
2963
2964 2019-06-25  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2967         Update.
2968         * tui/tui-layout.c (make_command_window)
2969         (show_source_disasm_command, show_data, init_and_make_win)
2970         (show_source_or_disasm_and_command): Update.
2971         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2972         method.
2973         <can_highight, is_highlighted>: Now bool.
2974         (tui_set_win_highlight): Don't declare.
2975         * tui/tui-data.c (tui_set_win_highlight): Remove.
2976
2977 2019-06-25  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-wingeneral.c (make_visible): Remove check of window
2980         type.
2981
2982 2019-06-25  Tom Tromey  <tom@tromey.com>
2983
2984         * tui/tui-win.c (tui_win_info::max_height)
2985         (tui_cmd_window::max_height): New methods.
2986         (new_height_ok): Call max_height.
2987         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2988         <max_height>: New method.
2989
2990 2019-06-25  Tom Tromey  <tom@tromey.com>
2991
2992         * tui/tui-win.c (tui_source_window_base::set_new_height)
2993         (tui_data_window::set_new_height): New methods.
2994         (make_invisible_and_set_new_height): Call set_new_height method.
2995         * tui/tui-data.h (struct tui_win_info)
2996         (struct tui_source_window_base, struct tui_data_window)
2997         <set_new_height>: New method.
2998
2999 2019-06-25  Tom Tromey  <tom@tromey.com>
3000
3001         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3002         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3003         tui_refresh_data_win.
3004         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3005         method.
3006         (tui_refresh_all_win): Call the refresh_all method.
3007         (tui_set_focus): Likewise.
3008         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3009         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3010         Likewise.
3011
3012 2019-06-25  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-winsource.h (tui_refill_source_window)
3015         (tui_set_is_exec_point_at): Don't declare.
3016         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3017         (tui_source_window_base::refill): Rename from
3018         tui_refill_source_window.
3019         (tui_source_window_base::do_scroll_horizontal): Update.
3020         (tui_source_window_base::set_is_exec_point_at): Rename from
3021         tui_set_is_exec_point_at.
3022         (tui_update_all_breakpoint_info): Update.
3023         * tui/tui-stack.c (tui_show_frame_info): Update.
3024         * tui/tui-layout.c (show_data): Add cast.
3025         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3026         * tui/tui-data.h (struct tui_source_window_base) <refill,
3027         set_is_exec_point_at>: New methods.
3028         (tui_source_windows, tui_add_to_source_windows): Update types.
3029         (tui_add_to_source_windows): Remove redundant declaration.
3030         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3031         (tui_source_windows): Change return type.
3032         (tui_clear_source_windows_detail): Update.
3033         (tui_add_to_source_windows): Change type of parameter.
3034         (tui_free_all_source_wins_content): Update.
3035
3036 2019-06-25  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-wingeneral.c (tui_win_info::refresh)
3039         (tui_source_window_base::refresh): New methods.
3040         (tui_refresh_all): Call the refresh method.
3041         * tui/tui-data.h (struct tui_win_info)
3042         (struct tui_source_window_base) <refresh>: New method.
3043
3044 2019-06-25  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui.h (tui_is_window_visible): Return bool.
3047         * tui/tui.c (tui_is_window_visible): Return bool.
3048         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3049         (tui_make_visible, tui_make_invisible)
3050         (tui_win_info::make_visible)
3051         (tui_source_window_base::make_visible, make_all_visible)
3052         (tui_make_all_visible, tui_make_all_invisible): Update.
3053         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3054         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3055         bool.
3056         (struct tui_win_info, struct tui_source_window_base)
3057         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3058         * tui/tui-data.c (tui_init_generic_part): Update.
3059
3060 2019-06-25  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3063         (tui_source_window_base::make_visible): New methods.
3064         (make_all_visible): Make method call.
3065         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3066         (struct tui_source_window_base, struct tui_cmd_window): Override
3067         make_visible.
3068         (tui_win_is_source_type): Don't declare.
3069         * tui/tui-data.c (tui_win_is_source_type): Remove.
3070
3071 2019-06-25  Tom Tromey  <tom@tromey.com>
3072
3073         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3074         NULL check.
3075
3076 2019-06-25  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3079         Inline constructor.  Add initializers for members.
3080         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3081         constructors; now inline in class.
3082
3083 2019-06-25  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-regs.c (tui_show_registers): Update.
3086         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3087         bool.
3088         * tui/tui-data.c (tui_data_window::clear_detail)
3089         (tui_data_window): Update.
3090
3091 2019-06-25  Tom Tromey  <tom@tromey.com>
3092
3093         * tui/tui-windata.c (tui_display_all_data)
3094         (tui_display_data_from_line, tui_display_data_from)
3095         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3096         Update.
3097         * tui/tui-regs.c (tui_last_regs_line_no)
3098         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3099         (tui_show_registers, tui_show_register_group)
3100         (tui_display_registers_from, tui_display_reg_element_at_line)
3101         (tui_display_registers_from_line, tui_check_register_values)
3102         (tui_reg_next, tui_reg_prev): Update.
3103         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3104         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3105         tui_data_window.
3106         (struct tui_win_info) <detail>: Remove.  Add new fields from
3107         tui_data_info.
3108         (TUI_DATA_WIN): Add cast.
3109         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3110         (~tui_data_window): Simplify.
3111
3112 2019-06-25  Tom Tromey  <tom@tromey.com>
3113
3114         * tui/tui-layout.c (show_source_disasm_command)
3115         (show_source_or_disasm_and_command): Update.
3116         * tui/tui-io.c (update_cmdwin_start_line)
3117         (tui_redisplay_readline): Update.
3118         * tui/tui-data.h (struct tui_command_info): Remove.
3119         (struct tui_win_info) <detail>: Remove command_info member.
3120         (struct tui_data_window) <start_line>: New member, from
3121         tui_command_info.
3122         (TUI_CMD_WIN): Add casts.
3123
3124 2019-06-25  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-winsource.c (tui_update_source_window)
3127         (tui_refill_source_window)
3128         (tui_source_window_base::do_scroll_horizontal)
3129         (tui_update_breakpoint_info, tui_set_exec_info_content)
3130         (tui_show_exec_info_content, tui_erase_exec_info_content)
3131         (tui_clear_exec_info_content): Update.
3132         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3133         Update.
3134         * tui/tui-win.c (make_invisible_and_set_new_height)
3135         (make_visible_with_new_height): Update.
3136         * tui/tui-source.c (tui_set_source_content)
3137         (tui_show_symtab_source): Update.
3138         * tui/tui-layout.c (extract_display_start_addr)
3139         (show_source_disasm_command, show_data)
3140         (make_source_or_disasm_window)
3141         (show_source_or_disasm_and_command): Update.
3142         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3143         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3144         "gdbarch".
3145         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3146         to tui_source_window_base.
3147         (struct tui_win_info) <detail>: Remove source_info member.
3148         (struct tui_source_window_base) <has_locator>: Inline.
3149         Move contents from tui_source_info; rename has_locator member to
3150         m_has_locator.
3151         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3152         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3153         header file.
3154         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3155         Simplify.
3156         (tui_free_all_source_wins_content): Cast to
3157         tui_source_window_base.
3158
3159 2019-06-25  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui-win.c (make_invisible_and_set_new_height)
3162         (make_visible_with_new_height): Call has_locator method.
3163         * tui/tui-layout.c (show_source_disasm_command, show_data)
3164         (show_source_or_disasm_and_command): Update for bool change.
3165         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3166         (tui_win_info) <has_locator>: New method.
3167         (struct tui_source_window_base) <has_locator>: New method.
3168         (tui_win_has_locator): Don't declare.
3169         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3170         from tui_win_has_locator.
3171         (tui_source_window_base): Use false, not FALSE.
3172
3173 2019-06-25  Tom Tromey  <tom@tromey.com>
3174
3175         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3176         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3177         clear_detail method directly.
3178         (tui_clear_win_detail): Remove.
3179
3180 2019-06-25  Tom Tromey  <tom@tromey.com>
3181
3182         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3183         "this", not TUI_DISASM_WIN.
3184
3185 2019-06-25  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3188         declare.
3189         * tui/tui-winsource.c
3190         (tui_source_window_base::do_scroll_horizontal): Rename from
3191         tui_horizontal_source_scroll.
3192         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3193         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3194         from tui_vertical_data_scroll.
3195         * tui/tui-win.h (tui_scroll): Don't declare.
3196         * tui/tui-win.c (tui_win_info::forward_scroll)
3197         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3198         (tui_win_info::right_scroll): Rename and update.
3199         (tui_scroll_forward_command, tui_scroll_backward_command)
3200         (tui_scroll_left_command, tui_scroll_right_command): Update.
3201         (tui_scroll): Remove.
3202         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3203         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3204         from tui_vertical_source_scroll.
3205         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3206         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3207         from tui_vertical_disassem_scroll.
3208         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3209         do_scroll_horizontal>: New methods.
3210         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3211         Likewise.
3212         (struct tui_source_window_base): Add do_scroll_horizontal.
3213         (struct tui_source_window, struct tui_disasm_window): Add
3214         do_scroll_vertical.
3215         (struct tui_data_window, struct tui_cmd_window): Add
3216         do_scroll_horizontal and do_scroll_vertical.
3217         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3218
3219 2019-06-25  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-data.h (struct tui_source_window_base): New struct.
3222         (struct tui_source_window): Derive from tui_source_window_base.
3223         (struct tui_disasm_window): New struct.
3224         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3225         from tui_source_window::clear_detail.
3226         (tui_source_window_base): Rename from tui_source_window.
3227         (~tui_source_window_base): Rename from ~tui_source_window.
3228         (tui_alloc_win_info): Create a tui_disasm_window.
3229
3230 2019-06-25  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-data.h (struct tui_source_window)
3233         (struct tui_data_window): Declare destructors.
3234         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3235         destructors.
3236         (tui_win_info): Simplify.
3237
3238 2019-06-25  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-winsource.c (tui_display_main)
3241         (tui_update_source_windows_with_addr)
3242         (tui_update_all_breakpoint_info): Update.
3243         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3244         (new_height_ok, parse_scrolling_args): Update.
3245         * tui/tui-stack.c (tui_show_frame_info): Update.
3246         * tui/tui-data.h (struct tui_list): Remove.
3247         (tui_source_windows): Return a reference to a std::vector.
3248         * tui/tui-data.c (source_windows): Now a std::vector.
3249         (tui_source_windows): Change return type.
3250         (tui_clear_source_windows): Rewrite.
3251         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3252         (tui_free_all_source_wins_content): Rewrite.
3253
3254 2019-06-25  Tom Tromey  <tom@tromey.com>
3255
3256         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3257         (struct tui_data_window, struct tui_cmd_window): Declare
3258         clear_detail method.
3259         * tui/tui-data.c (tui_source_window::clear_detail)
3260         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3261         methods.
3262         (tui_clear_win_detail): Simplify.
3263
3264 2019-06-25  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-layout.c (make_source_window, make_disasm_window)
3267         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3268         Return the new window.
3269         (show_source_disasm_command, show_data)
3270         (show_source_or_disasm_and_command): Update.
3271
3272 2019-06-25  Tom Tromey  <tom@tromey.com>
3273
3274         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3275         parameter.  Return the new window.
3276         (show_source_disasm_command): Update and remove NULL check.
3277         (show_source_or_disasm_and_command): Update.
3278
3279 2019-06-25  Tom Tromey  <tom@tromey.com>
3280
3281         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3282
3283 2019-06-25  Tom Tromey  <tom@tromey.com>
3284
3285         * tui/tui-data.h (struct tui_win_info): Make constructor
3286         protected.  Make destructor virtual.  Add initializers.
3287         (tui_source_window, tui_data_window, tui_cmd_window): New
3288         classes.
3289         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3290         constructor.  Add "type" parameter.
3291         (tui_source_window, tui_data_window, tui_cmd_window): New
3292         constructors.
3293         (tui_alloc_win_info): Instantiate the appropriate subclass.
3294
3295 2019-06-25  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-win.c (tui_resize_all): Use delete.
3298         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3299         destructor.
3300         (tui_free_window): Don't declare.
3301         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3302         Update.
3303
3304 2019-06-25  Tom Tromey  <tom@tromey.com>
3305
3306         * tui/tui-data.h (struct tui_win_info): Add constructor.
3307         * tui/tui-data.c (tui_alloc_win_info): Use new.
3308         (tui_free_window): Use delete.
3309
3310 2019-06-22  Tom Tromey  <tom@tromey.com>
3311
3312         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3313         declare.
3314         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3315
3316 2019-06-22  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3319         declare.
3320         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3321
3322 2019-06-22  Tom de Vries  <tdevries@suse.de>
3323
3324         * dwarf2read.c (create_addrmap_from_aranges)
3325         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3326         instead of '%zu'.
3327
3328 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3329
3330         * dwarf2read.h (dwarf2_section_info_def): Remove.
3331         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3332         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3333         std::vector<dwarf2_section_info>.
3334         (struct dwo_file) <~dwo_file>: Remove.
3335         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3336         types field.
3337         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3338         (dwarf2_read_debug_names): Likewise.
3339         (create_debug_types_hash_table): Change parameter type to
3340         array_view, adjust code accordingly.
3341         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3342         (partial_die_info::fixup): Likewise.
3343         (determine_prefix): Likewise.
3344         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3345
3346 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3347
3348         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3349         gdb_bfd_ref_ptr.
3350         <~dwo_file>: Remove call to gdb_bfd_unref.
3351         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3352         gdb_bfd_ref_ptr::get.
3353
3354 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3355
3356         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3357         type to htab_up.
3358         * dwarf2read.c (struct dwo_file): Initialize fields.
3359         <~dwo_file>: New.
3360         (free_dwo_file): Remove, move content to ~dwo_file.
3361         (struct dwo_file_deleter): Remove.
3362         (dwo_file_up>: Remove custom deleter.
3363         (free_dwo_files): Remove.
3364         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3365         dwo_files.
3366         (process_skeletonless_type_units): Call unique_ptr::get.
3367         (allocate_dwo_file_hash_table): Add deleter to created hash
3368         table.  Change return type to htab_up.
3369         (lookup_dwo_file_slot): Don't memset dwo_file, call
3370         unique_ptr::get.
3371         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3372         (create_dwo_unit_in_dwp_v2): Likewise.
3373         (open_and_init_dwo_file): Likewise.
3374         (free_dwo_file_from_slot): Remove.
3375
3376 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3377
3378         * dwarf2read.h (struct dwarf2_section_info) <readin,
3379         is_virtual>: Change type to bool.
3380         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3381         true instead of 1.
3382
3383 2019-06-19  Tom Tromey  <tom@tromey.com>
3384
3385         * tui/tui-data.h (tui_init_content_element): Don't declare.
3386
3387 2019-06-19  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-data.h (tui_init_win_info): Don't declare.
3390
3391 2019-06-19  Tom de Vries  <tdevries@suse.de>
3392
3393         * dwarf2read.h (abstract_to_concrete): Change type to
3394         std::unordered_map<sect_offset, std::vector<sect_offset>,
3395         gdb::hash_enum<sect_offset>>.
3396
3397 2019-06-19  Tom Tromey  <tromey@adacore.com>
3398
3399         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3400         EVAL_AVOID_SIDE_EFFECTS specially.
3401
3402 2019-06-19  Tom Tromey  <tromey@adacore.com>
3403
3404         * source-cache.c (highlighter): New global.
3405         (source_cache::get_source_lines): Create a highlighter on demand.
3406
3407 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3408
3409         * defs.h (deprecated_interactive_hook): Delete declaration.
3410         * interps.c (clear_interpreter_hooks): Remove use of
3411         deprecated_interactive_hook.
3412         * top.c (deprecated_interactive_hook): Delete definition.
3413         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3414
3415 2019-06-18  Tom de Vries  <tdevries@suse.de>
3416
3417         PR gdb/24515
3418         * dwarf2read.h (abstract_to_concrete): Change type from
3419         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3420         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3421         * dwarf2read.c (read_variable): Update.
3422         (dwarf2_fetch_die_loc_sect_off): Update.
3423
3424 2019-06-17  Tom de Vries  <tdevries@suse.de>
3425
3426         PR gdb/24617
3427         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3428         accessing parent[parent_len - 1].
3429
3430 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3431
3432         PR gdb/24364
3433         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3434         call dtrace_process_dof with NULL dof.
3435
3436 2019-06-16  Tom de Vries  <tdevries@suse.de>
3437
3438         PR gdb/24445
3439         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3440
3441 2019-06-16  Tom Tromey  <tom@tromey.com>
3442
3443         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3444         (make_all_visible): Use address of member.
3445
3446 2019-06-16  Tom Tromey  <tom@tromey.com>
3447
3448         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3449         (tui_free_window, free_content, free_content_elements): Remove
3450         unnecessary cast.
3451         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3452         cast.
3453         * tui/tui-regs.c (tui_show_register_group)
3454         (tui_display_registers_from, tui_display_reg_element_at_line):
3455         Remove unnecessary cast.
3456
3457 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * linux-nat.c (normal_mask): Delete.
3460         (_initialize_linux_nat): Don't initialise normal_mask.
3461
3462 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3463
3464         PR gdb/24445
3465         * dwarf-index-write.h (write_psymtabs_to_index): Add
3466         dwz_basename parameter.
3467         * dwarf-index-write.c (write_gdbindex): Move file writing to
3468         write_gdbindex_1.  Change return type void.
3469         (assert_file_size): Move up, remove filename parameter.
3470         (write_gdbindex_1): New function.
3471         (write_debug_names): Change return type to void, call
3472         assert_file_size.
3473         (struct index_wip_file): New struct.
3474         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3475         file logic to index_wip_file.  Write index for dwz file if
3476         needed.
3477         (save_gdb_index_command): Pass basename of dwz file, if present.
3478         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3479         build-id of dwz file, if present.
3480         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3481         (dwarf2_get_dwz_file): Likewise.
3482         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3483         (dwarf2_get_dwz_file): Likewise.
3484
3485 2019-06-16  Tom Tromey  <tom@tromey.com>
3486
3487         * coffread.c (process_coff_symbol): Use xstrdup.
3488         * value.c (create_internalvar): Use xstrdup.
3489
3490 2019-06-16  Tom Tromey  <tom@tromey.com>
3491
3492         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3493         * breakpoint.c (stopin_command, stopat_command)
3494         (until_break_command, decode_location_default): Remove unnecessary
3495         cast.
3496         * utils.c (subset_compare): Remove unnecessary cast.
3497         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3498         cast.
3499         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3500         cast.
3501         * infcmd.c (path_command): Remove unnecessary cast.
3502         * coffread.c (decode_type): Remove unnecessary cast.
3503         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3504         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3505         * tui/tui-stack.c (tui_show_locator_content)
3506         (tui_show_frame_info): Remove unnecessary cast.
3507         * tui/tui-win.c (tui_scroll_forward_command)
3508         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3509         (parse_scrolling_args): Remove unnecessary cast.
3510         * tui/tui-data.c (init_win_info, tui_del_window)
3511         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3512         (free_content_elements): Remove unnecessary cast.
3513         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3514         unnecessary cast.
3515         * tui/tui-source.c (tui_set_source_content)
3516         (tui_vertical_source_scroll): Remove unnecessary cast.
3517         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3518         cast.
3519         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3520         * tui/tui-regs.c (tui_display_registers_from)
3521         (tui_display_register): Remove unnecessary cast.
3522         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3523         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3524         (make_visible): Remove unnecessary cast.
3525         * tui/tui-winsource.c (tui_erase_source_content)
3526         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3527         unnecessary cast.
3528         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3529         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3530         * stabsread.c (read_type, read_array_type, read_range_type):
3531         Remove unnecessary cast.
3532         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3533         (parse_symbol, parse_type, upgrade_type, parse_external)
3534         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3535         unnecessary cast.
3536         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3537
3538 2019-06-16  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-data.c (tui_alloc_generic_win_info)
3541         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3542         checks.
3543
3544 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3545             Andrew Burgess  <andrew.burgess@embecosm.com>
3546
3547         * f-typeprint.c (f_print_type): Don't return early for not
3548         associated or not allocated types.
3549         (f_type_print_varspec_suffix): Add print_rank parameter and print
3550         ranks of array types in case they dangling.
3551         (f_type_print_base): Add print_rank parameter.
3552
3553 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3554
3555         * NEWS: Mention new MI commands.
3556         * break-catch-throw.c (enum exception_event_kind): Move to
3557         breakpoint.h.
3558         (print_mention_exception_catchpoint): Output text as a single
3559         message.
3560         (catch_exception_command_1): Rename to...
3561         (catch_exception_event): ...this, make non-static, update header
3562         command, and change some parameter types.
3563         (catch_catch_command): Update for changes to
3564         catch_exception_command_1.
3565         (catch_throw_command): Likewise.
3566         (catch_rethrow_command): Likewise.
3567         * breakpoint.c (enum exception_event_kind): Delete.
3568         * breakpoint.h (enum exception_event_kind): Moved here from
3569         break-catch-throw.c.
3570         (catch_exception_event): Declare.
3571         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3572         (mi_cmd_catch_throw): New function.
3573         (mi_cmd_catch_rethrow): New function.
3574         (mi_cmd_catch_catch): New function.
3575         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3576         'catch-catch' entries.
3577         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3578         (mi_cmd_catch_rethrow): Declare.
3579         (mi_cmd_catch_catch): Declare.
3580
3581 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3582
3583         * annotate.c (annotate_source_line): Change return type to void,
3584         update implementation to match.
3585         * annotate.h (annotate_source_line): Change return type to void,
3586         update header comment.
3587         * stack.c (print_frame_info): Don't change what frame information
3588         is printed based on whether annotations are on or not.
3589
3590 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3591
3592         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3593         (annotate_source): Make static.
3594         (annotate_source_line): Moved from source.c and renamed from
3595         identify_source_line.  Update the return type.
3596         * annotate.h (annotate_source): Delete declaration.
3597         (annotate_source_line): Declaration moved from source.h, and
3598         renamed from identify_source_line.  Return type updated.
3599         * source.c (identify_source_line): Moved to annotate.c and renamed
3600         to annotate_source_line.
3601         (info_line_command): Remove check of annotation_level.
3602         * source.h (identify_source_line): Move declaration to annotate.h
3603         and rename to annotate_source_line.
3604         * stack.c: Add 'annotate.h' include.
3605         (print_frame_info): Remove check of annotation_level before
3606         calling annotate_source_line.
3607
3608 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3609
3610         * source-cache.c (source_cache::get_plain_source_lines): Use
3611         open_source_file_with_line_charpos instead of just
3612         open_source_file, remove call to find_source_lines.
3613         (source_cache::get_source_lines): Likewise.
3614         * source.c (find_source_lines): Make static.
3615         (get_filename_and_charpos): Renamed into...
3616         (open_source_file_with_line_charpos): ..this along with changes to
3617         return a scoped_fd, and some other minor clean ups.
3618         (identify_source_line): Use open_source_file_with_line_charpos.
3619         (search_command_helper): Use open_source_file_with_line_charpos
3620         instead of just open_source_file, remove call to
3621         find_source_lines.
3622         * source.h (open_source_file_with_line_charpos): Declare new
3623         function.
3624         (find_source_lines): Delete declaration.
3625
3626 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3627
3628         * source.c (get_filename_and_charpos): Remove fullname
3629         parameter.
3630         (identify_source_line): Update call to get_filename_and_charpos.
3631
3632 2019-06-14  Tom Tromey  <tromey@adacore.com>
3633
3634         PR gdb/24502:
3635         * ui-style.h (skip_ansi_escape): Update comment.
3636         * ui-file.h (class no_terminal_escape_file): New class.
3637         * ui-file.c (no_terminal_escape_file::write)
3638         (no_terminal_escape_file::puts): New methods.
3639         * cli/cli-logging.c (handle_redirections): Use
3640         no_terminal_escape_file.
3641
3642 2019-06-14  Tom Tromey  <tromey@adacore.com>
3643
3644         * NEWS: Move convenience variable news above Python news.
3645
3646 2019-06-14  Tom Tromey  <tom@tromey.com>
3647
3648         * gnulib: Move directory to top-level.
3649         * configure.ac: Don't configure gnulib.
3650         * configure: Rebuild.
3651         * common/common-defs.h: Use new path to gnulib.
3652         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3653         (GNULIB_H): Remove.
3654         (INCGNU): Look in new gnulib location.
3655         (HFILES_NO_SRCDIR): Remove gnulib files.
3656         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3657         (generated_files): Remove GNULIB_H.
3658         ($(LIBGNU), all-lib): Remove targets.
3659         (distclean): Don't mention GNULIB_BUILDDIR.
3660         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3661
3662 2019-06-14  Tom Tromey  <tromey@adacore.com>
3663
3664         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3665         Warn if symbol file does not provide any symbols.
3666
3667 2019-06-14  Tom Tromey  <tromey@adacore.com>
3668
3669         * source.c (find_and_open_source): Respect basenames_may_differ.
3670
3671 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3672
3673         * annotate.c (annotate_breakpoints_invalid): Make use of
3674         scoped_restore_terminal_state.
3675         (annotate_frames_invalid): Likewise.
3676
3677 2019-06-14  Tom Tromey  <tromey@adacore.com>
3678
3679         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3680         allow assignment to an internalvar.
3681
3682 2019-06-14  Tom Tromey  <tromey@adacore.com>
3683
3684         * ada-lex.l: Allow "_" in attribute names.
3685
3686 2019-06-14  Tom Tromey  <tromey@adacore.com>
3687
3688         PR gdb/24653:
3689         * regcache.c (registers_changed): Don't call alloca.
3690         * top.c (execute_command): Don't call alloca.
3691
3692 2019-06-13  Pedro Alves  <palves@redhat.com>
3693
3694         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3695         'expression'.  When parsing an expression, error out if there's
3696         junk after "unlimited".
3697         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3698         (do_set_command): Adjust calls to is_unlimited_literal.
3699
3700 2019-06-13  Pedro Alves  <palves@redhat.com>
3701
3702         * compile/compile.c (make_compile_options_def_group): Add braces
3703         around array_view initializer.
3704         * thread.c (make_thread_apply_all_options_def_group)
3705         (make_thread_apply_all_options_def_group): Likewise.
3706
3707 2019-06-13  Pedro Alves  <palves@redhat.com>
3708
3709         * NEWS (New commands): Mention "maint test-options
3710         require-delimiter", "maint test-options unknown-is-error", "maint
3711         test-options unknown-is-operand" and "maint show
3712         test-options-completion-result".
3713         (New command options, command completion): New section.
3714         (Completion improvements): New section.
3715         Mention that you can abbreviate "unlimited".
3716
3717 2019-06-13  Pedro Alves  <palves@redhat.com>
3718
3719         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3720         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3721         * unittests/cli-utils-selftests.c (test_parse_flags)
3722         (test_parse_flags_qcs): Delete.
3723         (test_cli_utils): Don't call deleted functions.
3724
3725 2019-06-13  Pedro Alves  <palves@redhat.com>
3726
3727         * thread.c: Include "cli/cli-option.h".
3728         (tp_array_compar_ascending): Global.
3729         (tp_array_compar): Delete function.
3730         (tp_array_compar_ascending, tp_array_compar_descending): New
3731         functions.
3732         (ascending_option_def, qcs_flag_option_def)
3733         (thr_qcs_flags_option_defs)
3734         (make_thread_apply_all_options_def_group)
3735         (make_thread_apply_options_def_group): New.
3736         (thread_apply_all_command): Use gdb::option::process_options.
3737         (thread_apply_command_completer)
3738         (thread_apply_all_command_completer): New.
3739         (thread_apply_command): Use gdb::option::process_options.
3740         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3741         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3742         to generate help text of "thread apply".  Adjust "taas"'s help.
3743         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3744         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3745
3746 2019-06-13  Pedro Alves  <palves@redhat.com>
3747
3748         * thread.c (thread_apply_command): Check for invalid TID with
3749         isdigit instead of !isalpha.
3750
3751 2019-06-13  Pedro Alves  <palves@redhat.com>
3752
3753         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3754         (validate_flags_qcs): New.
3755         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3756         (validate_flags_qcs): Declare.
3757         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3758         (make_frame_apply_options_def_group): New.
3759         (frame_apply_command_count): Process options with
3760         gdb::option::process_options.
3761         (frame_apply_completer): New.
3762         (frame_apply_level_completer, frame_apply_all_completer)
3763         (frame_apply_completer): New.
3764         (_initialize_stack): Update help of "frame apply", "frame apply
3765         level", "frame apply all" and "faas" to mention supported options
3766         and install command completers.
3767         * stack.h (frame_apply_all_completer): Declare.
3768         * thread.c: Include "stack.h".
3769         (tfaas_command): Add "--".
3770         (_initialize_thread): Update help "tfaas" to mention supported
3771         options and install command completer.
3772
3773 2019-06-13  Pedro Alves  <palves@redhat.com>
3774
3775         * completer.c (complete_nested_command_line): New.
3776         (gdb_completion_word_break_characters_throw): Add assertion.
3777         * completer.h (complete_nested_command_line): Declare.
3778
3779 2019-06-13  Pedro Alves  <palves@redhat.com>
3780
3781         * stack.c (parse_backtrace_qualifiers): New.
3782         (backtrace_command): Use it.
3783         (backtrace_command_completer): Complete on qualifiers.
3784
3785 2019-06-13  Pedro Alves  <palves@redhat.com>
3786
3787         * frame.c: Include "cli/cli-option.h.
3788         (user_set_backtrace_options): New.
3789         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3790         Delete.
3791         (get_prev_frame): Adjust.
3792         (boolean_option_def, uinteger_option_def)
3793         (set_backtrace_option_defs): New.
3794         (_initialize_frame): Adjust and use
3795         gdb::option::add_setshow_cmds_for_options to install "set
3796         backtrace past-main" and "set backtrace past-entry".
3797         * frame.h: Include "cli/cli-option.h".
3798         (struct frame_print_options): Forward declare.
3799         (print_frame_arguments_all, print_frame_arguments_scalars)
3800         (print_frame_arguments_none): Declare.
3801         (print_entry_values): Delete declaration.
3802         (struct frame_print_options, user_frame_print_options): New.
3803         (struct set_backtrace_options): New.
3804         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3805         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3806         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3807         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3808         (list_args_or_locals): Add frame_print_options parameter.
3809         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3810         * python/py-framefilter.c (enumerate_args): Pass down
3811         USER_FRAME_PRINT_OPTIONS.
3812         * stack.c: Include "cli/cli-option.h".
3813         (print_frame_arguments_all, print_frame_arguments_scalars)
3814         (print_frame_arguments_none): Declare.
3815         (print_raw_frame_arguments, print_entry_values): Delete.
3816         (user_frame_print_options): New.
3817         (boolean_option_def, enum_option_def, frame_print_option_defs):
3818         New.
3819         (struct backtrace_cmd_options): New.
3820         (bt_flag_option_def): New.
3821         (backtrace_command_option_defs): New.
3822         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3823         (print_frame_arg, read_frame_arg, print_frame_args)
3824         (print_frame_info, print_frame): Add frame_print_options parameter
3825         and use it.
3826         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3827         (backtrace_command_1): Add frame_print_options and
3828         backtrace_cmd_options parameters and use them.
3829         (make_backtrace_options_def_group): New.
3830         (backtrace_command): Process command options with
3831         gdb::option::process_options.
3832         (backtrace_command_completer): New.
3833         (_initialize_stack): Extend "backtrace"'s help to mention
3834         supported options.  Install completer for "backtrace".
3835         Install some settings commands with add_setshow_cmds_for_options.
3836
3837 2019-06-13  Pedro Alves  <palves@redhat.com>
3838
3839         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3840         and that "set/show print raw frame-arguments" are now deprecated.
3841
3842         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3843         command.
3844         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3845         * stack.c (_initialize_stack): Install "set/show print
3846         raw-frame-arguments", and deprecate "set/show print raw
3847         frame-arguments".
3848         * valprint.c (_initialize_valprint): Deprecate "set/show print
3849         raw".
3850
3851 2019-06-13  Pedro Alves  <palves@redhat.com>
3852
3853         * compile/compile.c (struct compile_options): New.
3854         (compile_flag_option_def, compile_command_option_defs)
3855         (make_compile_options_def_group): New.
3856         (compile_file_command): Handle options with
3857         gdb::option::process_options.
3858         (compile_file_command_completer): New function.
3859         (compile_code_command): Handle options with
3860         gdb::option::process_options.
3861         (compile_code_command_completer): New function.
3862         (_initialize_compiler): Install completers for "compile code" and
3863         "compile file".  Mention available options in "compile code" and
3864         "compile code"'s help.
3865         * completer.c (advance_to_completion_word): New, factored out from
3866         ...
3867         (advance_to_expression_complete_word_point): ... this.
3868         (advance_to_filename_complete_word_point): New.
3869         * completer.h (advance_to_filename_complete_word_point): New
3870         declaration.
3871
3872 2019-06-13  Pedro Alves  <palves@redhat.com>
3873
3874         * compile/compile.c: Include "cli/cli-option.h".
3875         (compile_print_value): Scope data pointer is now a
3876         value_print_options pointer; adjust.
3877         (compile_print_command): Process options.  Scope data pointer is
3878         now a value_print_options pointer; adjust.
3879         (_initialize_compile): Update "compile print"'s help to include
3880         supported options.  Install a completer for "compile print".
3881         * cp-valprint.c (show_vtblprint, show_objectprint)
3882         (show_static_field_print): Delete.
3883         (_initialize_cp_valprint): Don't install "set print
3884         static-members", "set print vtbl", "set print object" here.
3885         * printcmd.c: Include "cli/cli-option.h" and
3886         "common/gdb_optional.h".
3887         (print_command_parse_format): Rework to fill in a
3888         value_print_options instead of a format_data.
3889         (print_value): Change parameter type from format_data pointer to
3890         value_print_options reference.  Adjust.
3891         (print_command_1): Process options.  Adjust to pass down a
3892         value_print_options.
3893         (print_command_completer): New.
3894         (_initialize_printcmd): Install print_command_completer as
3895         handle_brkchars completer for the "print" command.  Update
3896         "print"'s help to include supported options.
3897         * valprint.c: Include "cli/cli-option.h".
3898         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3899         here from cp-valprint.c.
3900         (boolean_option_def, uinteger_option_def)
3901         (value_print_option_defs, make_value_print_options_def_group):
3902         New.  Use gdb::option::add_setshow_cmds_for_options to install
3903         "set print elements", "set print null-stop", "set print repeats",
3904         "set print pretty", "set print union", "set print array", "set
3905         print address", "set print symbol", "set print array-indexes".
3906         * valprint.h: Include <string> and "cli/cli-option.h".
3907         (make_value_print_options_def_group): Declare.
3908         (print_value): Change parameter type from format_data pointer to
3909         value_print_options reference.
3910         (print_command_completer): Declare.
3911
3912 2019-06-13  Pedro Alves  <palves@redhat.com>
3913
3914         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3915         (COMMON_SFILES): Add maint-test-settings.c.
3916         * cli/cli-decode.c (boolean_enums): New global, factored out from
3917         ...
3918         (add_setshow_boolean_cmd): ... here.
3919         * cli/cli-decode.h (boolean_enums): Declare.
3920         * cli/cli-option.c: New file.
3921         * cli/cli-option.h: New file.
3922         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3923         factored out from ...
3924         (parse_cli_boolean_value(const char *)): ... this.
3925         (is_unlimited_literal): Change parameter type to pointer to
3926         pointer.  Adjust and advance ARG pointer.
3927         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3928         (parse_cli_var_enum): New, factored out from ...
3929         (do_set_command): ... this.  Adjust.
3930         * cli/cli-setshow.h (parse_cli_boolean_value)
3931         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3932         (parse_cli_var_enum): Declare.
3933         * cli/cli-utils.c: Include "cli/cli-option.h".
3934         (get_ulongest): New.
3935         * cli/cli-utils.h (get_ulongest): Declare.
3936         (check_for_argument): New overloads.
3937         * maint-test-options.c: New file.
3938
3939 2019-06-13  Pedro Alves  <palves@redhat.com>
3940
3941         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3942         parse a range if "-" is at the end of the string.
3943
3944 2019-06-13  Pedro Alves  <palves@redhat.com>
3945
3946         * cli/cli-setshow.c (parse_auto_binary_operation)
3947         (parse_cli_boolean_value): Don't allow "o".
3948
3949 2019-06-13  Pedro Alves  <palves@redhat.com>
3950
3951         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3952         * NEWS: Mention maint test-settings KIND.
3953         * maint-test-settings.c: New file.
3954
3955 2019-06-13  Pedro Alves  <palves@redhat.com>
3956
3957         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3958         completer.
3959         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3960         "set" completers.
3961
3962 2019-06-13  Pedro Alves  <palves@redhat.com>
3963
3964         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3965         after item.
3966
3967 2019-06-13  Pedro Alves  <palves@redhat.com>
3968
3969         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3970
3971 2019-06-13  Pedro Alves <palves@redhat.com>
3972
3973         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3974         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3975         call.
3976         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3977         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3978         calls.
3979         (check_for_argument): Skip spaces after argument.
3980
3981 2019-06-13  Pedro Alves  <palves@redhat.com>
3982
3983         * thread.c (thread_apply_command): Adjust TID parsing.
3984         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3985         detected before end of string.
3986         (tid_is_in_list): Error out if LIST is invalid.
3987
3988 2019-06-13  Pedro Alves  <palves@redhat.com>
3989
3990         * completer.c (complete_line_internal_1): Rewind completion word
3991         point.
3992         (completion_tracker::advance_custom_word_point_by): Change
3993         parameter type to int.
3994         * completer.h (completion_tracker::advance_custom_word_point_by):
3995         Likewise.
3996
3997 2019-06-13  Pedro Alves  <palves@redhat.com>
3998
3999         * completer.c (advance_to_completion_word): Handle delimiters.
4000
4001 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4002
4003         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4004
4005 2019-06-11  Tom Tromey  <tom@tromey.com>
4006
4007         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4008         (xmalloc_failed): Move to alloc.c.
4009         * alloc.c: New file.
4010         * Makefile.in (COMMON_SFILES): Add alloc.c.
4011
4012 2019-06-11  Tom Tromey  <tom@tromey.com>
4013
4014         * nat/linux-waitpid.c: Don't include server.h.
4015         (linux_debug): Remove.
4016         (my_waitpid): Update.
4017
4018 2019-06-11  Tom Tromey  <tromey@adacore.com>
4019
4020         * infcall.c (_initialize_infcall): Remove trailing newline from
4021         help.
4022         * user-regs.c (_initialize_user_regs): Remove trailing newline
4023         from help.
4024         * typeprint.c (_initialize_typeprint): Remove trailing newline
4025         from help.
4026         * reverse.c (_initialize_reverse): Remove trailing newlines from
4027         help.
4028         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4029         from help.
4030         * language.c (add_set_language_command): Remove trailing newline
4031         from help.
4032         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4033         help.
4034         * disasm.c (_initialize_disasm): Remove trailing newline from
4035         help.
4036         * top.c (init_main): Remove trailing newline from help.
4037         * interps.c (_initialize_interpreter): Remove trailing newline
4038         from help.
4039         * btrace.c (_initialize_btrace): Remove trailing newlines from
4040         help.
4041         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4042         from help.
4043         * python/python.c (_initialize_python): Remove trailing newline
4044         from help.
4045         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4046         help.
4047         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4048         from help.  Reformat some text.
4049         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4050         from help.
4051         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4052         newline from help.
4053
4054 2019-06-11  Tom Tromey  <tromey@adacore.com>
4055
4056         * darwin-nat.c (darwin_decode_exception_message)
4057         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4058
4059 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4060
4061         * valops.c (value_slice): Check for not allocated or not
4062         associated values.
4063
4064 2019-06-10  Tom de Vries  <tdevries@suse.de>
4065
4066         PR gdb/24618
4067         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4068         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4069         invalid.
4070
4071 2019-06-10  Tom de Vries  <tdevries@suse.de>
4072
4073         PR gdb/24611
4074         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4075         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4076
4077 2019-06-10  Tom de Vries  <tdevries@suse.de>
4078
4079         PR symtab/24545
4080         * symtab.c (struct demangled_name_entry): Add language field.
4081         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4082         static minimal symbol".  Set and use language field.
4083
4084 2019-06-10  Tom Tromey  <tromey@adacore.com>
4085
4086         * ada-lang.c (_initialize_ada_language): Update help text.
4087
4088 2019-06-10  Tom Tromey  <tromey@adacore.com>
4089
4090         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4091         with a newline.
4092         * guile/guile.c (handle_boot_error): Don't end warning with a
4093         newline.
4094         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4095         warning with a newline.
4096         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4097         newline.
4098         (s12z_frame_cache): Likewise.
4099         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4100         a newline.
4101         * solib-svr4.c (disable_probes_interface): Don't end warning with
4102         a newline.
4103         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4104         newline.
4105         * python/python.c (do_finish_initialization): Don't end warning
4106         with a newline.
4107
4108 2019-06-10  Tom Tromey  <tom@tromey.com>
4109
4110         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4111         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4112         gdbpy_enter.
4113
4114 2019-06-10  Tom Tromey  <tromey@adacore.com>
4115
4116         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4117         data.
4118         (elf_new_init): Don't call stabsread_new_init.
4119         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4120         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4121         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4122
4123 2019-06-10  Tom de Vries  <tdevries@suse.de>
4124
4125         PR symtab/16264
4126         PR symtab/24517
4127         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4128
4129 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4130
4131         * source.c (find_and_open_source): Also rewrite relative file
4132         names.
4133
4134 2019-04-26  Amos Bird  <amosbird@gmail.com>
4135
4136         * annotate.c (annotate_thread_exited): Add "thread-exited"
4137         annotation.
4138
4139 2019-06-06  Tom Tromey  <tromey@adacore.com>
4140
4141         * maint.h (class scoped_command_stats): Use
4142         DISABLE_COPY_AND_ASSIGN.
4143         <print_time>: New method.
4144         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4145         print_time.
4146         (scoped_command_stats::print_time): New method.
4147
4148 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4149
4150         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4151         instructions of lengths 6 or 8 bytes.
4152
4153 2019-06-04  Pedro Alves  <palves@redhat.com>
4154
4155         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4156
4157         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4158         * breakpoint.c (condition_completer): Likewise.
4159         * cli/cli-dump.c (scan_expression): Likewise.
4160         * common/filestuff.c (mkdir_recursive): Likewise.
4161         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4162         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4163         (gdb_abspath): Likewise.
4164         * compile/compile-cplus-types.c
4165         (compile_cplus_instance::decl_name): Likewise.
4166         * completer.c (complete_explicit_location):
4167         (signal_completer, reg_or_group_completer_1): Likewise.
4168         * cp-support.c (cp_remove_params_if_any): Likewise.
4169         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4170         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4171         * infcmd.c (strip_bg_char): Likewise.
4172         * linespec.c (copy_token_string): Likewise.
4173         * mi/mi-main.c (output_cores): Likewise.
4174         * psymtab.c (psymtab_search_name):
4175         * symfile.c (test_set_ext_lang_command): Likewise.
4176         * target.c (target_fileio_read_stralloc): Likewise.
4177         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4178         * value.c (complete_internalvar): Likewise.
4179
4180 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4181
4182         Add objfile property to gdb.Type.
4183         * NEWS: Mention Python API addition.
4184         * python/py-type.c (typy_get_objfile): New method.
4185
4186 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4187
4188         * NEWS: Mention the new set|show style [title|highlight].
4189         Mention changes to "show style", "help" and "apropos".
4190
4191 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4192
4193         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4194         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4195         instead of print_help_for_command.
4196         (print_doc_of_command): New function.
4197         (help_list): Add 'apropos -v word' suggestion.
4198         (print_help_for_command): Style the command name using title style.
4199         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4200         (_initialize_cli_cmds): Describe -v in apropos_command help.
4201
4202 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4203
4204         * cli/cli-style.h (cli_style_option): Add name in constructor,
4205         add m_name class member, add constructor with intensity,
4206         add name class function.
4207         (cli_style_option::add_setshow_commands): Remove name argument.
4208         (highlight_style, title_style): New styles.
4209         * cli/cli-style.c (do_show): New function that shows a style
4210         characteristic styling the style name with itself.
4211         (set_style_name): New function.
4212         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4213         Update all callers according to the changes in cli/cli-style.h.
4214         * utils.h (fputs_highlighted): New function.
4215         * utils.c (fputs_highlighted): Likewise.
4216
4217 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4218
4219         * NEWS: Mention new pipe command and new convenience variables.
4220
4221 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4222
4223         * cli/cli-cmds.c (pipe_command): New function.
4224         (_initialize_cli_cmds): Call add_com for pipe_command.
4225         Define | as an alias for pipe.
4226         (exit_status_set_internal_vars): New function.
4227         (shell_escape): Call exit_status_set_internal_vars.
4228         cli/cli-decode.c (find_command_name_length): Recognize | as
4229         a single character command.
4230
4231 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4232
4233         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4234         top.c (execute_command_to_ui_file): New function, mostly a copy
4235         of execute_command_to_string.
4236         (execute_command_to_string): Implement by calling
4237         execute_command_to_ui_file.
4238
4239 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4240
4241         * top.h (saved_command_line): Remove declaration.
4242         * top.c (previous_saved_command_line, previous_repeat_arguments):
4243         New variables.
4244         (saved_command_line): Make static, define together with other
4245         'repeat variables'.
4246         (dont_repeat): Clear repeat_arguments.
4247         (repeat_previous, get_saved_command_line, save_command_line):
4248         New functions.
4249         (gdb_init): Initialize saved_command_line
4250         and previous_saved_command_line.
4251         * main.c (captured_main_1): Remove saved_command_line initialization.
4252         * event-top.c (handle_line_of_input): Update to use
4253         the new 'repeat' related functions instead of direct access to
4254         saved_command_line.
4255         * command.h (repeat_previous, get_saved_command_line,
4256         save_command_line): New declarations.
4257         (dont_repeat): Add comment.
4258
4259 2019-05-30  Tom Tromey  <tromey@adacore.com>
4260
4261         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4262         Fix comment.
4263         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4264
4265 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4266
4267         PR cli/24587
4268         * completer.c (complete): Initialize variable word.
4269
4270 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4271
4272         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4273         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4274         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4275         'body' is NULL to the outter 'if', protecting the '!is_define'
4276         situation as well.
4277
4278 2019-05-29  Tom Tromey  <tromey@adacore.com>
4279
4280         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4281         (dwarf_unknown): New function.
4282         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4283         (dwarf_type_encoding_name): Use dwarf_unknown.
4284
4285 2019-05-29  Tom Tromey  <tromey@adacore.com>
4286
4287         PR c++/20020:
4288         * cp-valprint.c (cp_print_value_fields): Call
4289         cp_print_static_field inside "try".
4290
4291 2019-05-29  Tom Tromey  <tromey@adacore.com>
4292
4293         * inflow.c (struct terminal_info): Add default operator=.
4294         * configure: Rebuild.
4295         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4296         -Wdeprecated-copy-dtor, -Wredundant-move.
4297
4298 2019-05-29  Tom Tromey  <tromey@adacore.com>
4299
4300         * NEWS: Add entry.
4301         * infcmd.c (print_return_value_1): Handle finish_print
4302         option.
4303         (show_print_finish): New function.
4304         (_initialize_infcmd): Add "set/show print finish" commands.
4305         * valprint.c (user_print_options): Initialize new member.
4306         * valprint.h (struct value_print_options) <finish_print>: New
4307         member.
4308
4309 2019-05-28  Tom Tromey  <tromey@adacore.com>
4310
4311         * ada-lang.c (ada_remove_Xbn_suffix)
4312         (find_old_style_renaming_symbol)
4313         (parse_old_style_renaming): Remove.
4314         (ada_find_renaming_symbol): Don't call
4315         find_old_style_renaming_symbol.
4316         (ada_is_renaming_symbol): Rename from
4317         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4318         bool.  Now static.
4319         (ada_read_var_value): Update and simplify.
4320         * ada-exp.y (write_var_or_type): Remove old code.
4321
4322 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4323
4324         * event-top.c: Remove include comment.
4325         * inflow.c (class scoped_ignore_sigttou): Move from here...
4326         * inflow.h (class scoped_ignore_sigttou): ...to here.
4327         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4328         * top.c:  Remove include comment.
4329
4330 2019-05-27  Tom Tromey  <tom@tromey.com>
4331
4332         * NEWS: Fix typo.
4333
4334 2019-05-22  Tom Tromey  <tromey@adacore.com>
4335
4336         * target.c (target_follow_exec): Constify parameter.
4337         * target-delegates.c: Rebuild.
4338         * remote.c (remote_target::follow_exec): Constify parameter.
4339         * infrun.c (follow_exec): Constify parameter.
4340         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4341         (target_follow_exec): Likewise.
4342
4343 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4344
4345         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4346         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4347
4348 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4349
4350         * NEWS: Add debugredirect and testsuite sections.
4351
4352 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4353
4354         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4355         target descriptions using exclusively floating point register name
4356         aliases.
4357
4358 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4359
4360         PR gdb/18644:
4361         * f-lang.c (build_fortran_types): Handle the case where
4362         gdbarch_floatformat_for_type returns a nullptr.
4363
4364 2019-05-21  Tom de Vries  <tdevries@suse.de>
4365
4366         PR cli/24587
4367         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4368
4369 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4370
4371         PR gdb/18644:
4372         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4373         16-byte floats.
4374         * i386-tdep.c (i386_floatformat_for_type): Use
4375         floatformats_ia64_quad for the 16-byte floating point component
4376         within a fortran 32-byte complex number.
4377
4378 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4379
4380         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4381         delete default constructor.
4382         (find_partial_die): Update to return const struct.
4383         (partial_die_parent_scope): Move variable declaration into scope
4384         of its use and change its type to auto.
4385         (guess_partial_die_structure_name): Likewise.
4386         (partial_die_info::fixup): Likewise.
4387
4388 2019-05-17  Tom Tromey  <tromey@adacore.com>
4389
4390         * source.c (find_and_open_source): Remove cast.
4391
4392 2019-05-17  Tom Tromey  <tromey@adacore.com>
4393
4394         * annotate.c (annotate_source): Make "filename" const.
4395         * annotate.h (annotate_source): Use const.
4396
4397 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4398
4399         * disasm.c (set_disassembler_options): Send errors to stderr.
4400
4401 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4402
4403         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4404         (cli_interp_base::set_logging): Check debug_redirect.
4405         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4406         * cli/cli-logging.c (debug_redirect): Add static variable.
4407         (pop_output_files): Add default param.
4408         (handle_redirections): Print debug setting.
4409         (show_logging_command): Likewise.
4410         (_initialize_cli_logging): Add debugredirect command.
4411         * interps.c (current_interp_set_logging): Add debug_redirect
4412         parameter.
4413         * interps.h (set_logging): Add debug_redirect parameter.
4414         (current_interp_set_logging): Likewise.
4415         * mi/mi-common.h: Likewise.
4416         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4417
4418 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4419             Tom Tromey  <tromey@adacore.com>
4420
4421         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4422         directly.
4423         * cli/cli-interp.h (make_logging_output): Remove declaration.
4424         * cli/cli-logging.c (make_logging_output): Remove function.
4425         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4426         directly.
4427         * ui-file.c (tee_file::tee_file): Remove bools.
4428         (tee_file::~tee_file): Remove deletes.
4429         * ui-file.h (tee_file): Remove bools.
4430
4431 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4432
4433         * mi/mi-cmds.h (mi_cmd_complete): New function.
4434         * mi/mi-main.c (mi_cmd_complete): Likewise.
4435         * mi/mi-cmds.c: Define new MI command -complete.
4436         * NEWS: Mention new -complete command.
4437
4438 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4439
4440         * completer.h (complete): New function.
4441         * completer.c (complete): Likewise.
4442         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4443         function defined in completer.h.
4444
4445 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4446
4447         * MAINTAINERS (Write After Approval): Add myself.
4448
4449 2019-05-17  Tom de Vries  <tdevries@suse.de>
4450
4451         PR gdb/24094
4452         * dwarf2read.c (struct cu_partial_die_info): New struct.
4453         (find_partial_die): Return cu_partial_die_info.
4454         (partial_die_parent_scope, guess_partial_die_structure_name)
4455         (partial_die_info::fixup): Handle new return type of find_partial_die.
4456
4457 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4458
4459         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4460         "std::string", simplifying the algorithm.
4461
4462 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4463
4464         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4465         (stap_static_probe_ops::get_probes): Likewise.
4466
4467 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4468
4469         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4470         '-')" and "else if".
4471         (stap_parse_single_operand): Join checks for
4472         "gdbarch_stap_parse_special_token_p" and
4473         "gdbarch_stap_parse_special_token" in the same "if" statement.
4474         Invert check when verifying for operation on register
4475         displacement.
4476
4477 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4478
4479         * stap-probe.c (stap_get_opcode): Update comment.
4480         (stap_get_expected_argument_type): Likewise.
4481         (handle_stap_probe): Likewise.
4482
4483 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4484
4485         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4486         return type to 'bool'.  Adjust comment.  Use 'bool' when
4487         appropriate.
4488         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4489         * stap-probe.c (stap_parse_argument_1): Likewise.
4490         (stap_is_operator): Likewise.
4491         (stap_is_generic_prefix): Likewise.
4492         (stap_is_register_prefix): Likewise.
4493         (stap_is_register_indirection_prefix): Likewise.
4494         (stap_is_integer_prefix): Likewise.
4495         (stap_generic_check_suffix): Likewise.
4496         (stap_check_integer_suffix): Likewise.
4497         (stap_check_register_suffix): Likewise.
4498         (stap_check_register_indirection_suffix): Likewise.
4499         (stap_parse_register_operand): Likewise.
4500         (stap_parse_single_operand): Likewise.
4501         (stap_parse_argument_1): Likewise.
4502         (stap_probe::get_argument_count): Likewise.
4503         (stap_is_operator): Likewise.
4504
4505 2019-05-16  Tom Tromey  <tromey@adacore.com>
4506
4507         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4508         keyword to foreach.
4509
4510 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4511
4512         * linux-thread-db.c (try_thread_db_load_1): Change return type
4513         to bool.
4514         (try_thread_db_load): Likewise.
4515         (try_thread_db_load_from_pdir_1): Likewise.
4516         (try_thread_db_load_from_pdir): Likewise.
4517         (try_thread_db_load_from_sdir): Likewise.
4518         (try_thread_db_load_from_dir): Likewise.
4519         (thread_db_load_search): Likewise.
4520         (has_libpthread): Likewise.
4521         (thread_db_load): Likewise.
4522
4523 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4524
4525         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4526         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4527         NULL, and complain/return if that's the case.
4528
4529 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4530
4531         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4532         (advance, posn, abstract_read_memory): New functions.
4533         [struct mem_read_abstraction]: New struct.
4534         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4535
4536 2019-05-14  Tom Tromey  <tromey@adacore.com>
4537
4538         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4539         value is not lval_memory.
4540
4541 2019-05-14  Tom Tromey  <tromey@adacore.com>
4542
4543         * solib.c (info_sharedlibrary_command): Style the file name.
4544
4545 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4546
4547         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4548         (aarch64_vnv_type): Likewise.
4549         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4550         * common/tdesc.c: Likewise.
4551         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4552         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4553         * features/aarch64-fpu.xml: Add ieee half view.
4554         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4555         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4556         * gdbtypes.h (struct builtin_type): Likewise.
4557         (struct objfile_type): Likewise.
4558
4559 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4560
4561         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4562         typo.
4563         * location.h (string_to_event_location): Likewise.
4564
4565 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4566
4567         GDB 8.3 released.
4568
4569 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4570
4571         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4572         New variable declaration.
4573         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4574         New variable.
4575         (print_one_breakpoint): Use ui_out::test_flags and new global
4576         variable to compute use_fixed_output.
4577         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4578         Remove.
4579         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4580         (mi_multi_location_breakpoint_output_fixed): Remove.
4581         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4582         new variable.
4583         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4584         fix_multi_location_breakpoint_output flag if version >= 3.
4585         * ui-out.h (enum ui_out_flag)
4586         <fix_multi_location_breakpoint_output>: New enumerator.
4587
4588 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4589
4590         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4591
4592 2019-05-10  Tom Tromey  <tromey@adacore.com>
4593
4594         * ada-lang.c (catch_ada_completer): New function.
4595         (_initialize_ada_language): Use it.
4596
4597 2019-05-10  Tom Tromey  <tromey@adacore.com>
4598
4599         * thread.c (print_thread_info): Make "requested_threads" const.
4600         * gdbthread.h (print_thread_info): Make "requested_threads"
4601         const.
4602         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4603         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4604
4605 2019-05-08  Tom Tromey  <tom@tromey.com>
4606
4607         * gdbtypes.c (objfile_type_data): Change type.
4608         (objfile_type, _initialize_gdbtypes): Update.
4609
4610 2019-05-08  Tom Tromey  <tom@tromey.com>
4611
4612         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4613         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4614         (_initialize_dwarf2_frame): Update.
4615
4616 2019-05-08  Tom Tromey  <tom@tromey.com>
4617
4618         * objc-lang.c (objc_objfile_data): Change type.
4619         (find_methods): Update.
4620         (_initialize_objc_lang): Remove.
4621
4622 2019-05-08  Tom Tromey  <tom@tromey.com>
4623
4624         * stabsread.c (rs6000_builtin_type_data): Change type.
4625         (rs6000_builtin_type, _initialize_stabsread): Update.
4626
4627 2019-05-08  Tom Tromey  <tom@tromey.com>
4628
4629         * mips-tdep.c (mips_pdr_data): Remove.
4630         (_initialize_mips_tdep): Update.
4631
4632 2019-05-08  Tom Tromey  <tom@tromey.com>
4633
4634         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4635         (hppa_init_objfile_priv_data, read_unwind_info)
4636         (find_unwind_entry, _initialize_hppa_tdep): Update.
4637
4638 2019-05-08  Tom Tromey  <tom@tromey.com>
4639
4640         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4641         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4642         on obstack.
4643         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4644
4645 2019-05-08  Tom Tromey  <tom@tromey.com>
4646
4647         * mdebugread.c (basic_type_data): Change type.
4648         (basic_type, _initialize_mdebugread): Update.
4649
4650 2019-05-08  Tom Tromey  <tom@tromey.com>
4651
4652         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4653
4654 2019-05-08  Tom Tromey  <tom@tromey.com>
4655
4656         * nto-tdep.c (nto_inferior_data_reg): Change type.
4657         (nto_inferior_data): Update.
4658         (nto_inferior_data_cleanup, nto_new_inferior_data)
4659         (_initialize_nto_tdep): Remove.
4660         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4661
4662 2019-05-08  Tom Tromey  <tom@tromey.com>
4663
4664         * ada-lang.c (struct ada_inferior_data): Add initializers.
4665         (ada_inferior_data): Change type.
4666         (ada_inferior_data_cleanup): Remove.
4667         (get_ada_inferior_data, ada_inferior_exit)
4668         (struct ada_pspace_data): Add initializers, destructor.
4669         (ada_pspace_data_handle): Change type.
4670         (get_ada_pspace_data): Update.
4671         (ada_pspace_data_cleanup): Remove.
4672
4673 2019-05-08  Tom Tromey  <tom@tromey.com>
4674
4675         * coffread.c (struct coff_symfile_info): Add initializers.
4676         (coff_objfile_data_key): Move lower.  Change type.
4677         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4678         Update.
4679         (coff_free_info): Remove.
4680
4681 2019-05-08  Tom Tromey  <tom@tromey.com>
4682
4683         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4684         (fbsd_pspace_data_handle): Move lower.  Change type.
4685         (get_fbsd_pspace_data): Update.
4686         (fbsd_pspace_data_cleanup): Remove.
4687         (_initialize_fbsd_tdep): Update.
4688
4689 2019-05-08  Tom Tromey  <tom@tromey.com>
4690
4691         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4692         (get_ada_tasks_pspace_data): Update.
4693         (ada_tasks_pspace_data_cleanup): Remove.
4694         (_initialize_tasks): Update.
4695         (ada_tasks_inferior_data_handle): Change type.
4696         (get_ada_tasks_inferior_data): Update.
4697         (ada_tasks_inferior_data_cleanup): Remove.
4698         (struct ada_tasks_pspace_data): Add initializers.
4699
4700 2019-05-08  Tom Tromey  <tom@tromey.com>
4701
4702         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4703         * symfile-debug.c (debug_sym_get_probes): Change type.
4704         * stap-probe.c (handle_stap_probe):
4705         (stap_static_probe_ops::get_probes): Change type.
4706         * probe.h (class static_probe_ops) <get_probes>: Change type.
4707         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4708         (parse_probes_in_pspace): Update.
4709         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4710         Update.
4711         (any_static_probe_ops::get_probes): Change type.
4712         * elfread.c (elfread_data): New typedef.
4713         (probe_key): Change type.
4714         (elf_get_probes): Likewise.  Update.
4715         (probe_key_free): Remove.
4716         (_initialize_elfread): Update.
4717         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4718         Change type.
4719         (dtrace_process_dof_probe, dtrace_process_dof)
4720         (dtrace_static_probe_ops::get_probe): Change type.
4721
4722 2019-05-08  Tom Tromey  <tom@tromey.com>
4723
4724         * xcoffread.c (struct xcoff_symfile_info): Rename from
4725         coff_symfile_info.  Add initializers.
4726         (xcoff_objfile_data_key): Move lower.  Change type.
4727         (XCOFF_DATA): Rewrite.
4728         (xcoff_free_info): Remove.
4729         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4730         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4731         (xcoff_initial_scan): Update.
4732
4733 2019-05-08  Tom Tromey  <tom@tromey.com>
4734
4735         * solib-svr4.c (struct svr4_info): Add initializers and
4736         destructor.
4737         <probes_table>: Now an htab_up.
4738         (solib_svr4_pspace_data): Change type.
4739         (free_probes_table): Simplify.
4740         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4741         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4742         (probes_table_remove_objfile_probes, register_solib_event_probe)
4743         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4744         (_initialize_svr4_solib): Update.
4745
4746 2019-05-08  Tom Tromey  <tom@tromey.com>
4747
4748         * remote.c (remote_pspace_data): Change type.
4749         (remote_pspace_data_cleanup): Remove.
4750         (get_remote_exec_file, set_pspace_remote_exec_file)
4751         (_initialize_remote): Update.
4752
4753 2019-05-08  Tom Tromey  <tom@tromey.com>
4754
4755         * breakpoint.c (breakpoint_objfile_key): Change type.
4756         (get_breakpoint_objfile_data): Update.
4757         (free_breakpoint_objfile_data): Remove.
4758         (_initialize_breakpoint): Update.
4759
4760 2019-05-08  Tom Tromey  <tom@tromey.com>
4761
4762         * linux-tdep.c (struct linux_info): Add initializers.
4763         (linux_inferior_data): Move.  Change type.
4764         (invalidate_linux_cache_inf): Update.
4765         (linux_inferior_data_cleanup): Remove.
4766         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4767
4768 2019-05-08  Tom Tromey  <tom@tromey.com>
4769
4770         * auxv.c (auxv_inferior_data): Move.  Change type.
4771         (auxv_inferior_data_cleanup): Remove.
4772         (invalidate_auxv_cache_inf): Rewrite.
4773         (get_auxv_inferior_data, _initialize_auxv): Update.
4774
4775 2019-05-08  Tom Tromey  <tom@tromey.com>
4776
4777         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4778         (symfile_debug_objfile_data_key): Change type.
4779         (symfile_debug_installed, debug_qf_has_symbols)
4780         (debug_qf_find_last_source_symtab)
4781         (debug_qf_forget_cached_source_info)
4782         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4783         (debug_qf_print_stats, debug_qf_dump)
4784         (debug_qf_expand_symtabs_for_function)
4785         (debug_qf_expand_all_symtabs)
4786         (debug_qf_expand_symtabs_with_fullname)
4787         (debug_qf_map_matching_symbols)
4788         (debug_qf_expand_symtabs_matching)
4789         (debug_qf_find_pc_sect_compunit_symtab)
4790         (debug_qf_map_symbol_filenames)
4791         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4792         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4793         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4794         (debug_sym_read_linetable, debug_sym_relocate): Update.
4795         (symfile_debug_free_objfile): Remove.
4796         (install_symfile_debug_logging, _initialize_symfile_debug):
4797         Update.
4798
4799 2019-05-08  Tom Tromey  <tom@tromey.com>
4800
4801         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4802         allocate_on_obstack.
4803         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4804         (get_dwarf2_per_objfile): Update.
4805         (set_dwarf2_per_objfile): Remove.
4806         (dwarf2_has_info, dwarf2_get_section_info): Update.
4807         (dwarf2_free_objfile): Remove.
4808         (_initialize_dwarf2_read): Update.
4809
4810 2019-05-08  Tom Tromey  <tom@tromey.com>
4811
4812         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4813         initializers.
4814         <unsupported_script_warning_printed,
4815         script_not_found_warning_printed>: Now bool.
4816         (auto_load_pspace_data): Change type.
4817         (~auto_load_pspace_info): Rename from
4818         auto_load_pspace_data_cleanup.
4819         (get_auto_load_pspace_data, init_loaded_scripts_info)
4820         (clear_section_scripts, maybe_print_unsupported_script_warning)
4821         (maybe_print_script_not_found_warning, _initialize_auto_load):
4822         Update.
4823
4824 2019-05-08  Tom Tromey  <tom@tromey.com>
4825
4826         * objfiles.c (objfile_pspace_info): Add destructor and
4827         initializers.
4828         (objfiles_pspace_data): Change type.
4829         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4830         (get_objfile_pspace_data): Update.
4831         (objfiles_bfd_data): Change type.
4832         (get_objfile_bfd_data): Update.
4833         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4834
4835 2019-05-08  Tom Tromey  <tom@tromey.com>
4836
4837         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4838         Change type.
4839         (get_catch_syscall_inferior_data): Update.
4840         (catch_syscall_inferior_data_cleanup): Remove.
4841         (_initialize_break_catch_syscall): Update.
4842
4843 2019-05-08  Tom Tromey  <tom@tromey.com>
4844
4845         * inflow.c (struct terminal_info): Add destructor and
4846         initializers.
4847         (inflow_inferior_data): Change type.
4848         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4849         (get_inflow_inferior_data, inflow_inferior_exit)
4850         (swap_terminal_info, _initialize_inflow): Update.
4851
4852 2019-05-08  Tom Tromey  <tom@tromey.com>
4853
4854         * target-dcache.c (target_dcache_cleanup): Remove.
4855         (target_dcache_aspace_key): Change type.
4856         (target_dcache_init_p, target_dcache_invalidate)
4857         (target_dcache_get, target_dcache_get_or_init)
4858         (_initialize_target_dcache): Update.
4859         * dcache.h (struct dcache_deleter): New.
4860
4861 2019-05-08  Tom Tromey  <tom@tromey.com>
4862
4863         * symtab.c (struct symbol_cache): Add destructor and
4864         initializers.
4865         (symbol_cache_key): Move.  Change type.
4866         (make_symbol_cache, free_symbol_cache): Remove.
4867         (get_symbol_cache): Update.
4868         (symbol_cache_cleanup): Remove.
4869         (ALL_PSPACES, symbol_cache_flush)
4870         (maintenance_print_symbol_cache)
4871         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4872         Update.
4873
4874 2019-05-08  Tom Tromey  <tom@tromey.com>
4875
4876         * symtab.c (struct main_info): Add destructor and initializers.
4877         (main_progspace_key): Move.  Change type.
4878         (get_main_info): Update.
4879         (main_info_cleanup): Remove.
4880         (_initialize_symtab): Update.
4881
4882 2019-05-08  Tom Tromey  <tom@tromey.com>
4883
4884         * registry.h (DECLARE_REGISTRY): Define the _key class.
4885
4886 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4887
4888         * NEWS: Merge two 'New commands' sections.
4889
4890 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4891
4892         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4893         parameter and use Ada language definition instead.
4894         (ada_val_print_ptr): Remove unused language parameter.
4895         (ada_val_print_num): Remove language parameter and use Ada language
4896         definition instead.
4897         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4898         parameter.
4899         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4900         parameter and use Ada language definition instead.
4901         (ada_val_print_1): Update all ada_val_print_xxx calls.
4902         Remove language parameter.
4903         (ada_val_print): Update ada_val_print_1 call.
4904
4905 2019-05-08  Tom Tromey  <tromey@adacore.com>
4906
4907         * remote.c (remote_hw_watchpoint_limit)
4908         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4909         Now static.
4910
4911 2019-05-08  Tom Tromey  <tromey@adacore.com>
4912
4913         * maint.c (_initialize_maint_cmds): Move initialization code to
4914         remote.c.
4915         (watchdog, show_watchdog): Move to remote.c.
4916         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4917         "watchdog" static.
4918         (_initialize_remote): Move initialization code from maint.c.
4919         * defs.h (watchdog): Don't declare.
4920
4921 2019-05-08  Tom Tromey  <tromey@adacore.com>
4922
4923         * tui/tui-interp.c: Include main.h.
4924         * interps.c: Include main.h.
4925         * main.h (interpreter_p): Declare.
4926         * defs.h (interpreter_p): Don't declare.
4927
4928 2019-05-08  Tom Tromey  <tromey@adacore.com>
4929
4930         * dwarf2loc.c: Include dwarf2read.h.
4931         * defs.h (read_unsigned_leb128): Don't declare.
4932         * dwarf2read.h (read_unsigned_leb128): Declare.
4933
4934 2019-05-08  Tom Tromey  <tromey@adacore.com>
4935
4936         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4937         method.
4938
4939 2019-05-08  Tom Tromey  <tromey@adacore.com>
4940
4941         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4942         when no wrap column is set.
4943
4944 2019-05-08  Tom Tromey  <tromey@adacore.com>
4945
4946         * c-lang.c (c_get_string): Handle non-C-style arrays.
4947
4948 2019-05-08  Tom Tromey  <tromey@adacore.com>
4949
4950         * typeprint.c (print_offset_data::update): Print the bit offset,
4951         not the number of bits remaining.
4952
4953 2019-05-08  Tom Tromey  <tromey@adacore.com>
4954
4955         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4956         padding at end of comment.
4957
4958 2019-05-08  Tom Tromey  <tromey@adacore.com>
4959
4960         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4961         Compare main types.
4962
4963 2019-05-06  Tom Tromey  <tom@tromey.com>
4964
4965         * common/scoped_mmap.c: Include common-defs.h.
4966         * common/scoped_mmap.h: Don't include config.h.
4967
4968 2019-05-04  Tom Tromey  <tom@tromey.com>
4969
4970         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4971         (struct aarch64_call_info): Add initializers.
4972         <si>: Now a std::vector.
4973         (pass_on_stack, aarch64_push_dummy_call): Update.
4974
4975 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4976             Tom Tromey  <tom@tromey.com>
4977
4978         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4979         (ppc_threads): Now a std::vector.  Now static.
4980         (hwdebug_find_thread_points_by_tid)
4981         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4982         Update.
4983
4984 2019-05-04  Tom Tromey  <tom@tromey.com>
4985
4986         * arc-tdep.c (arc_tdesc_init): Return bool.
4987
4988 2019-05-04  Tom Tromey  <tom@tromey.com>
4989
4990         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4991         Use gdb_assert_not_reached.
4992
4993 2019-05-04  Tom Tromey  <tom@tromey.com>
4994
4995         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4996         "false".
4997
4998 2019-05-04  Tom Tromey  <tom@tromey.com>
4999
5000         * arc-tdep.c (arc_tdesc_init): Use bool.
5001
5002 2019-05-04  Tom Tromey  <tom@tromey.com>
5003
5004         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5005
5006 2019-05-04  Tom Tromey  <tom@tromey.com>
5007
5008         * cli/cli-cmds.c (valid_command_p): Return bool.
5009
5010 2019-05-04  Tom Tromey  <tom@tromey.com>
5011
5012         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5013         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5014
5015 2019-05-04  Raul Tambre  <raul@tambre.ee>
5016
5017         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5018         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5019         operator for comparison.
5020
5021 2019-05-04  Tom Tromey  <tom@tromey.com>
5022
5023         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5024         (lookup_partial_symbol, print_partial_symbols)
5025         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5026         (psymbol_compare): Update.
5027         (add_psymbol_to_bcache): Clear the entire psymbol.
5028         (maintenance_check_psymtabs): Update.
5029         * psympriv.h (struct partial_symbol): Don't derive from
5030         general_symbol_info.
5031         <obj_section, unrelocated_address, address,
5032         set_unrelocated_address>: Update.
5033         <ginfo>: New member.
5034         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5035         (debug_names::write_psymbols): Update.
5036
5037 2019-05-04  Tom de Vries  <tdevries@suse.de>
5038
5039         * contrib/cc-with-tweaks.sh: Support -n arg.
5040
5041 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5042
5043         * corelow.c (core_target::detach): Ensure frame cache and
5044         register caches are cleared.
5045         inferior.c (exit_inferior_1): Likewise.
5046
5047 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5048             Tom Tromey  <tom@tromey.com>
5049
5050         * dictionary.c (collate_pending_symbols_by_language): Remove
5051         "struct" from foreach.
5052         * symtab.c (lookup_global_symbol_from_objfile)
5053         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5054         foreach.
5055         * ser-tcp.c (net_open): Remove "struct" from foreach.
5056         * objfiles.c (objfile_relocate, objfile_rebase)
5057         (objfile_has_symbols): Remove "struct" from foreach.
5058         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5059         from foreach.
5060         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5061         foreach.
5062         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5063         "struct" from foreach.
5064         * ada-lang.c (create_excep_cond_exprs)
5065         (ada_exception_catchpoint_cond_string): Remove "struct" from
5066         foreach.
5067
5068 2019-05-03  Tom Tromey  <tromey@adacore.com>
5069
5070         * ada-exp.y (convert_char_literal): Check suffix of each
5071         enumerator.
5072
5073 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5074
5075         PR ada/21406:
5076         * ada-exp.y (yywrap): Don't define.
5077         * ada-lex.l (%option): Add noyywrap
5078         (yywrap): Remove.
5079
5080 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5081
5082         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5083         _WIN32_WINNT to the XP level, unless already defined to a higher
5084         level.
5085
5086         * unittests/parse-connection-spec-selftests.c:
5087         * ser-tcp.c:
5088         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5089         override.
5090
5091         * symfile.c (find_separate_debug_file): Remove colon from the
5092         drive spec of DOS/Windows file names of the target, so that the
5093         file name produced from DEBUGDIR and the target's directory will
5094         be valid on DOS/Windows systems.
5095
5096 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5097
5098         * rust-lang.c (val_print_struct): Handle printing structures
5099         containing strings.
5100
5101 2019-05-02  Tom Tromey  <tromey@adacore.com>
5102
5103         * valarith.c (_initialize_valarith): Remove.
5104
5105 2019-05-01  Tom Tromey  <tromey@adacore.com>
5106
5107         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5108         bitfields.
5109
5110 2019-05-01  Tom Tromey  <tromey@adacore.com>
5111
5112         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5113         for big-endian copies.
5114
5115 2019-04-30  Ali Tamur  <tamur@google.com>
5116         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5117         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5118         (read_3_bytes): New function.
5119
5120 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5121
5122         * windows-nat.c (main_thread_id): Delete.
5123         (handle_output_debug_string): Replace main_thread_id by
5124         current_event.dwThreadId.
5125         (fake_create_process): Likewise.
5126         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5127         Do not set main_thread_id.
5128         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5129         current_event.dwThreadId.
5130         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5131
5132 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5133
5134         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5135         Use current_event.dwThreadId instead of main_thread_id.
5136
5137 2019-04-30  Tom Tromey  <tromey@adacore.com>
5138
5139         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5140         (create_excep_cond_exprs): Iterate over program spaces.
5141         (ada_exception_catchpoint_cond_string): Examine all minimal
5142         symbols for exception types.
5143
5144 2019-04-30  Tom Tromey  <tromey@adacore.com>
5145
5146         PR c++/24470:
5147         * dwarf2read.c (process_structure_scope): Handle case where type
5148         has template parameters but no symbol was created.
5149
5150 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5151             Chris January  <chris.january@arm.com>
5152
5153         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5154         qualifier.
5155         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5156
5157 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * f-typeprint.c (f_print_type): Update rules for printing
5160         whitespace.
5161         (f_type_print_varspec_suffix): Likewise.
5162
5163 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5164             Chris January  <chris.january@arm.com>
5165
5166         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5167         function arguments.
5168
5169 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * f-lang.c (build_fortran_types): Change name of void type to
5172         lower case.
5173         * f-typeprint.c (f_type_print_base): Print the name of the void
5174         type, rather than a fixed string.
5175         * f-valprint.c (f_decorations): Use lower case void string.
5176
5177 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5178             Chris January  <chris.january@arm.com>
5179
5180         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5181         types for Fortran.
5182
5183 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5184             Chris January  <chris.january@arm.com>
5185             David Lecomber  <david.lecomber@arm.com>
5186
5187         * f-exp.y (BINOP_INTRINSIC): New token.
5188         (exp): New parser rule handling BINOP_INTRINSIC.
5189         (f77_keywords): Add new builtin procedures.
5190         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5191         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5192         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5193         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5194         (print_unop_subexp_f): New function.
5195         (print_binop_subexp_f): New function.
5196         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5197         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5198         (dump_subexp_body_f): Likewise.
5199         (operator_check_f): Likewise.
5200         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5201         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5202
5203 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5204
5205         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5206         UNOP_KIND.
5207         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5208         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5209         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5210         (operator_length_f): New fuction.
5211         (print_subexp_f): New function.
5212         (op_name_f): New function.
5213         (dump_subexp_body_f): New function.
5214         (operator_check_f): New function.
5215         (exp_descriptor_f): Replace standard expression handling functions
5216         with new functions.
5217         * gdb/fortran-operator.def: New file.
5218         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5219         * gdb/std-operator.def: Remove UNOP_KIND.
5220
5221 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5222
5223         * std-operator.def: Remove unbalanced, stray double quote
5224         character.
5225
5226 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5227             Chris January  <chris.january@arm.com>
5228             Daniel Everett  <daniel.everett@arm.com>
5229             Nick Forrington  <nick.forrington@arm.com>
5230             Richard Bunt  <richard.bunt@arm.com>
5231
5232         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5233         of depth when printing anonymous structs or unions.
5234         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5235         Don't print either the top-level value, or the children if the
5236         max-depth is exceeded.
5237         (ppscm_print_children): When printing the key of a map, allow one
5238         extra level of depth.
5239         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5240         print either the top-level value, or the children if the max-depth
5241         is exceeded.
5242         (print_children): When printing the key of a map, allow one extra
5243         level of depth.
5244         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5245         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5246         (user_print_options): Initialise max_depth field.
5247         (val_print_scalar_or_string_type_p): New function.
5248         (val_print): Check to see if the max depth has been reached.
5249         (val_print_check_max_depth): Define new function.
5250         (show_print_max_depth): New function.
5251         (_initialize_valprint): Add 'print max-depth' option.
5252         * valprint.h (struct value_print_options) <max_depth>: New field.
5253         (val_print_check_max_depth): Declare new function.
5254         * NEWS: Document new feature.
5255
5256 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5257
5258         * ada-lang.c (ada_language_defn): Initialise new field.
5259         * c-lang.c (c_is_string_type_p): New function.
5260         (c_language_defn): Initialise new field.
5261         (cplus_language_defn): Initialise new field.
5262         (asm_language_defn): Initialise new field.
5263         (minimal_language_defn): Initialise new field.
5264         * c-lang.h (c_is_string_type_p): Declare new function.
5265         * d-lang.c (d_language_defn): Initialise new field.
5266         * f-lang.c (f_is_string_type_p): New function.
5267         (f_language_defn): Initialise new field.
5268         * go-lang.c (go_is_string_type_p): New function.
5269         (go_language_defn): Initialise new field.
5270         * language.c (default_is_string_type_p): New function.
5271         (unknown_language_defn): Initialise new field.
5272         (auto_language_defn): Initialise new field.
5273         * language.h (struct language_defn) <la_is_string_type_p>: New
5274         member variable.
5275         (default_is_string_type_p): Declare new function.
5276         * m2-lang.c (m2_language_defn): Initialise new field.
5277         * objc-lang.c (objc_language_defn): Initialise new field.
5278         * opencl-lang.c (opencl_language_defn): Initialise new field.
5279         * p-lang.c (pascal_is_string_type_p): New function.
5280         (pascal_language_defn): Initialise new field.
5281         * rust-lang.c (rust_is_string_type_p): New function.
5282         (rust_language_defn): Initialise new field.
5283
5284 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5285
5286         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5287         New field.
5288         * ada-lang.c (ada_language_defn): Initialise new field.
5289         * c-lang.c (c_language_defn): Likewise.
5290         (cplus_language_defn): Likewise.
5291         (asm_language_defn): Likewise.
5292         (minimal_language_defn): Likewise.
5293         * d-lang.c (d_language_defn): Likewise.
5294         * f-lang.c (f_language_defn): Likewise.
5295         * go-lang.c (go_language_defn): Likewise.
5296         * language.c (unknown_language_defn): Likewise.
5297         (auto_language_defn): Likewise.
5298         * m2-lang.c (m2_language_defn): Likewise.
5299         * objc-lang.c (objc_language_defn): Likewise.
5300         * opencl-lang.c (opencl_language_defn): Likewise.
5301         * p-lang.c (pascal_language_defn): Likewise.
5302         * rust-lang.c (rust_language_defn): Likewise.
5303
5304 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5305
5306         * ada-lang.c (ada_is_character_type): Change return type to bool.
5307         (ada_is_string_type): Likewise.
5308         * ada-lang.h (ada_is_character_type): Update declaration
5309         (ada_is_string_type): Likewise.
5310
5311 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5312
5313         Support style in 'frame|thread apply'
5314
5315         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5316         * record.c (record_start, record_stop): Update callers of
5317         execute_command_to_string with false.
5318         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5319         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5320         methods.
5321         (class string_file): New constructor with term_out parameter.
5322         Override methods term_out and can_emit_style_escape.  New member
5323         term_out.
5324         (class stdio_file): Override can_emit_style_escape.
5325         (class tee_file): Override term_out and can_emit_style_escape.
5326         * utils.h (can_emit_style_escape): Remove.
5327         * utils.c (can_emit_style_escape): Likewise.
5328         Update all callers of can_emit_style_escape (SOMESTREAM) to
5329         SOMESTREAM->can_emit_style_escape.
5330         * source-cache.c (source_cache::get_source_lines): Likewise.
5331         * stack.c (frame_apply_command_count): Call execute_command_to_string
5332         passing the term_out characteristic of the current gdb_stdout.
5333         * thread.c (thr_try_catch_cmd): Likewise.
5334         * top.c (execute_command_to_string): pass term_out parameter
5335         to construct the string_file for the command output.
5336         * ui-file.c (term_cli_styling): New function (most code moved
5337         from utils.c can_emit_style_escape).
5338         (string_file::string_file, string_file::can_emit_style_escape,
5339         stdio_file::can_emit_style_escape, tee_file::term_out,
5340         tee_file::can_emit_style_escape): New functions.
5341
5342 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5343
5344         * NEWS: Mention the new set|show may-call-functions.
5345         * infcall.c (may_call_functions_p): New variable.
5346         (show_may_call_functions_p): New function.
5347         (call_function_by_hand_dummy): Throws an error if not
5348         may-call-functions.
5349         (_initialize_infcall): Call add_setshow_boolean_cmd for
5350         may-call-functions.
5351
5352 2019-04-25  Keith Seitz  <keiths@redhat.com>
5353
5354         PR c++/24367
5355         * cp-support.c (inspect_type): Don't attempt substitutions
5356         of symbol with the same name.
5357
5358 2019-04-25  Tom Tromey  <tromey@adacore.com>
5359
5360         PR gdb/24475:
5361         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5362         static.
5363
5364 2019-04-25  Tom Tromey  <tromey@adacore.com>
5365
5366         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5367         rvalue reference.
5368         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5369         (gdb_xml_parser::parse): Use std::move.
5370         * python/python-internal.h (gdbpy_convert_exception): Take a const
5371         reference.
5372         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5373         std::move.
5374         * python/py-utils.c (gdbpy_convert_exception): Take a const
5375         reference.
5376         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5377         Use std::move.
5378         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5379         Use std::move.
5380         * mi/mi-main.c (mi_print_exception): Take a const reference.
5381         * main.c (handle_command_errors): Take a const reference.
5382         * linespec.c (parse_linespec): Use std::move.
5383         * infcall.c (run_inferior_call): Use std::move.
5384         (call_function_by_hand_dummy): Use std::move.
5385         * exec.c (try_open_exec_file): Use std::move.
5386         * exceptions.h (exception_print, exception_fprintf)
5387         (exception_print_same): Update.
5388         * exceptions.c (print_exception, exception_print)
5389         (exception_fprintf, exception_print_same): Change parameters to
5390         const reference.
5391         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5392         * common/new-op.c: Use std::move.
5393         * common/common-exceptions.h (struct gdb_exception): Add move
5394         constructor.
5395         (struct gdb_exception_error, struct gdb_exception_quit, struct
5396         gdb_quit_bad_alloc): Change constructor to move constructor.
5397         (throw_exception): Change parameter to rvalue reference.
5398         * common/common-exceptions.c (throw_exception): Take rvalue
5399         reference.
5400         * cli/cli-interp.c (safe_execute_command): Use std::move.
5401         * breakpoint.c (insert_bp_location, location_to_sals): Use
5402         std::move.
5403
5404 2019-04-25  Tom Tromey  <tromey@adacore.com>
5405
5406         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5407         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5408         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5409         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5410         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5411         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5412         guile/scm-value.c: Use unpack.
5413         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5414         gdbscm_gdb_exception.
5415         (gdbscm_throw_gdb_exception): Likewise.
5416         (struct gdbscm_gdb_exception): New.
5417         (unpack): New function.
5418         (gdbscm_wrap): Use unpack.
5419
5420 2019-04-25  Tom Tromey  <tromey@adacore.com>
5421
5422         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5423         (gdb_rl_callback_handler): Use std::move.
5424         * common/common-exceptions.h (struct gdb_exception): Add move
5425         assignment operator.
5426         (throw_exception_sjlj): Change "exception" to const reference.
5427         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5428         (throw_exception_sjlj): Change "exception" to const reference.
5429
5430 2019-04-25  Tom Tromey  <tromey@adacore.com>
5431
5432         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5433         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5434         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5435         Update.
5436         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5437         Update.
5438         * mi/mi-interp.c (mi_interp::exec): Update.
5439         * linespec.c (parse_linespec): Update.
5440         * infcall.c (run_inferior_call): Update.
5441         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5442         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5443         (gdbscm_lookup_global_symbol): Update.
5444         * guile/scm-param.c (gdbscm_parameter_value): Update.
5445         * guile/scm-frame.c (gdbscm_frame_read_register)
5446         (gdbscm_frame_read_var): Update.
5447         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5448         * exec.c (try_open_exec_file): Update.
5449         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5450         (gdb_rl_callback_handler): Update.
5451         * common/common-exceptions.h (exception_none): Don't declare.
5452         * common/common-exceptions.c (exception_none): Don't define.
5453         (struct catcher) <exception>: Update.
5454         * cli/cli-interp.c (safe_execute_command): Update.
5455         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5456
5457 2019-04-25  Ali Tamur  <tamur@google.com>
5458
5459         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5460         (read_attribute_value): Likewise.
5461         (dwarf2_read_addr_index): Update comment.
5462         (read_str_index): Add DW_FORM_strx.
5463         (dwarf2_string_attr): Likewise.
5464         (dwarf2_const_value_attr): Likewise.
5465         (dump_die_shallow): Likewise.
5466         (dwarf2_fetch_constant_bytes): Likewise.
5467         (skip_form_bytes): Likewise.
5468         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5469
5470 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5471
5472         PR corefiles/11608
5473         PR corefiles/18187
5474         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5475         OFFSET.  Verify if current mapping contains an ELF header.
5476         (linux_find_memory_regions_full): Adjust call to
5477         dump_mapping_p.
5478
5479 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5480             Kang Li <kanglictf@gmail.com>
5481
5482         PR gdb/21600
5483
5484         * dwarf2-frame.c (read_initial_length): Be consistent about using
5485         unsigned representation of length.
5486         (decode_frame_entry_1): Likewise.  Check for wraparound of
5487         end pointer as well as buffer overflow.
5488
5489 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5490
5491         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5492         "vq".
5493
5494 2019-04-24  Tom Tromey  <tromey@adacore.com>
5495
5496         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5497
5498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5499
5500         * s12z-tdep.c (s12z_unwind_pc): Delete.
5501         (s12z_unwind_sp): Delete.
5502         (s12z_gdbarch_init): Don't register deleted functions with
5503         gdbarch.
5504
5505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5506
5507         * rl78-tdep.c (rl78_unwind_sp): Delete.
5508         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5509
5510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5511
5512         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5513         (xstormy16_unwind_pc): Delete.
5514         (xstormy16_dummy_id): Delete.
5515         (xstormy16_gdbarch_init): Don't register deleted functions with
5516         gdbarch.
5517
5518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5519
5520         * vax-tdep.c (vax_unwind_pc): Delete.
5521         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5522
5523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5524
5525         * v850-tdep.c (v850_unwind_sp): Delete.
5526         (v850_unwind_pc): Delete.
5527         (v850_dummy_id): Delete.
5528         (v850_gdbarch_init): Don't register deleted functions with
5529         gdbarch.
5530
5531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5532
5533         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5534         (tilegx_unwind_pc): Delete.
5535         (tilegx_unwind_dummy_id): Delete.
5536         (tilegx_gdbarch_init): Don't register deleted functions with
5537         gdbarch.
5538
5539 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5540
5541         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5542         (tic6x_dummy_id): Delete.
5543         (tic6x_gdbarch_init): Don't register deleted functions with
5544         gdbarch.
5545
5546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5547
5548         * sparc-tdep.c (sparc_unwind_pc): Delete.
5549         (sparc32_gdbarch_init): Don't register deleted function with
5550         gdbarch.
5551
5552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5553
5554         * sh-tdep.c (sh_unwind_sp): Delete.
5555         (sh_unwind_pc): Delete.
5556         (sh_dummy_id): Delete.
5557         (sh_gdbarch_init): Don't register deleted functions with
5558         gdbarch.
5559
5560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5561
5562         * score-tdep.c (score_unwind_sp): Delete.
5563         (score_unwind_pc): Delete.
5564         (score_dummy_id): Delete.
5565         (score_gdbarch_init): Don't register deleted functions with
5566         gdbarch.
5567
5568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * rx-tdep.c (rx_unwind_pc): Delete.
5571         (rx_unwind_sp): Delete.
5572         (rx_dummy_id): Delete.
5573         (rx_gdbarch_init): Don't register deleted functions with
5574         gdbarch.  Update comment.
5575
5576 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5577
5578         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5579         (rs6000_dummy_id): Delete.
5580         (rs6000_gdbarch_init): Don't register deleted functions with
5581         gdbarch.
5582
5583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * or1k-tdep.c (or1k_dummy_id): Delete.
5586         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5587
5588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5589
5590         * nios2-tdep.c (nios2_dummy_id): Delete.
5591         (nios2_unwind_sp): Delete.
5592         (nios2_gdbarch_init): Don't register deleted functions with
5593         gdbarch.
5594
5595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5596
5597         * nds32-tdep.c (nds32_dummy_id): Delete.
5598         (nds32_unwind_pc): Delete.
5599         (nds32_unwind_sp): Delete.
5600         (nds32_gdbarch_init): Don't register deleted functions with
5601         gdbarch.
5602
5603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5604
5605         * msp430-tdep.c (msp430_unwind_pc): Delete.
5606         (msp430_unwind_sp): Delete.
5607         (msp430_dummy_id): Delete.
5608         (msp430_gdbarch_init): Don't register deleted functions with
5609         gdbarch.
5610
5611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5612
5613         * moxie-tdep.c (moxie_unwind_sp): Delete.
5614         (moxie_unwind_pc): Delete.
5615         (moxie_dummy_id): Delete.
5616         (moxie_gdbarch_init): Don't register deleted functions with
5617         gdbarch.
5618
5619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5620
5621         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5622         (mn10300_unwind_pc): Delete.
5623         (mn10300_unwind_sp): Delete.
5624         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5625         mn10300_unwind_sp.
5626         (mn10300_frame_unwind_init): Don't register deleted functions with
5627         gdbarch.
5628
5629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5630
5631         * mep-tdep.c (mep_unwind_pc): Delete.
5632         (mep_unwind_sp): Delete.
5633         (mep_dummy_id): Delete.
5634         (mep_gdbarch_init): Don't register deleted functions with
5635         gdbarch.
5636
5637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5638
5639         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5640         (m68hc11_unwind_sp): Delete.
5641         (m68hc11_gdbarch_init): Don't register deleted functions with
5642         gdbarch.
5643
5644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5645
5646         * m32r-tdep.c (m32r_unwind_sp): Delete.
5647         (m32r_unwind_pc): Delete.
5648         (m32r_dummy_id): Delete.
5649         (m32r_gdbarch_init): Don't register deleted functions with
5650         gdbarch.
5651
5652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5653
5654         * m32c-tdep.c (m32c_unwind_pc): Delete.
5655         (m32c_unwind_sp): Delete.
5656         (m32c_dummy_id): Delete.
5657         (m32c_gdbarch_init): Don't register deleted functions with
5658         gdbarch.
5659
5660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5661
5662         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5663         (lm32_unwind_pc): Delete.
5664         (lm32_dummy_id): Delete.
5665         (lm32_gdbarch_init): Don't register deleted functions with
5666         gdbarch.
5667
5668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5671         (iq2000_unwind_pc): Delete.
5672         (iq2000_dummy_id): Delete.
5673         (iq2000_gdbarch_init): Don't register deleted functions with
5674         gdbarch.
5675
5676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5677
5678         * nds32-tdep.c (nds32_type_align): Delete.
5679         (nds32_push_dummy_call): Use type_align instead.
5680
5681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5682
5683         * arm-tdep.c (arm_type_align): Only handle vector override case.
5684         (arm_push_dummy_call): Use type_align.
5685         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5686
5687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5688
5689         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5690         case.
5691         (pass_on_stack): Use type_align.
5692         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5693         function.
5694
5695 2019-04-23  Tom Tromey  <tromey@adacore.com>
5696
5697         * dwarf2read.c (line_header::file_name_at): Remove unused
5698         overload.
5699
5700 2019-04-23  Tom de Vries  <tdevries@suse.de>
5701
5702         PR gdb/24438
5703         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5704         invocation.
5705
5706
5707 2019-03-27  Ali Tamur  <tamur@google.com>
5708
5709         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5710         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5711         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5712         (dwarf_expr_context::get_addr_index): Likewise
5713         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5714         (symbol_needs_eval_context::get_addr_index): Likewise
5715         (disassemble_dwarf_expression): Add DW_OP_addrx
5716         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5717         (read_cutu_die_from_dwo): Update comment
5718         (skip_one_die): Add DW_FORM_addrx
5719         (read_attribute_value): Likewise
5720         (var_decode_location): Add DW_OP_addrx
5721         (dwarf2_const_value_attr): Add DW_FORM_addrx
5722         (dump_die_shallow): Likewise
5723         (dwarf2_fetch_constant_bytes): Likewise
5724         (decode_locdesc): Add DW_OP_addrx
5725         (skip_form_bytes): Add DW_FORM_addrx
5726
5727 2019-04-22  Ali Tamur  <tamur@google.com>
5728
5729         * MAINTAINERS (Write After Approval): Add self.
5730
5731 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5732
5733         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5734         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5735         (open_symbol_file_object): Likewise.
5736         (svr4_default_sos): Add info parameter.
5737         (svr4_read_so_list): Likewise.
5738         (svr4_current_sos_direct): Adjust functions calls to pass down
5739         info.
5740         (svr4_current_sos_1): Add info parameter.
5741         (svr4_current_sos): Call get_svr4_info, pass info down to
5742         svr4_current_sos_1.
5743         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5744         get_svr4_info.
5745         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5746         get_svr4_info.
5747         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5748         to get_svr4_info.
5749         (probes_table_remove_objfile_probes): Likewise.
5750         (register_solib_event_probe): Add info parameter.
5751         (solist_update_incremental): Pass info parameter down to
5752         svr4_read_so_list.
5753         (disable_probes_interface): Add info parameter.
5754         (svr4_handle_solib_event): Pass current_program_space to
5755         get_svr4_info.  Adjust disable_probes_interface cleanup.
5756         (svr4_create_probe_breakpoints): Add info parameter, pass it
5757         down to register_solib_event_probe.
5758         (svr4_create_solib_event_breakpoints): Add info parameter,
5759         pass it down to svr4_create_probe_breakpoints.
5760         (enable_break): Pass info down to
5761         svr4_create_solib_event_breakpoints.
5762         (svr4_solib_create_inferior_hook): Pass current_program_space to
5763         get_svr4_info.
5764         (svr4_clear_solib): Likewise.
5765
5766 2019-04-22  Pedro Alves  <palves@redhat.com>
5767
5768         * solib-svr4.c (svr4_free_objfile_observer): New.
5769         (probe_and_action::objfile): New field.
5770         (probes_table_htab_remove_objfile_probes)
5771         (probes_table_remove_objfile_probes): New functions.
5772         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5773         in the new probe_and_action.  Don't store the probe in 'lookup'.
5774         (svr4_create_probe_breakpoints): Pass objfile to
5775         register_solib_event_probe.
5776         (_initialize_svr4_solib): Register a free_objfile observer.
5777
5778 2019-04-19  Tom Tromey  <tom@tromey.com>
5779
5780         * common/queue.h: Remove.
5781
5782 2019-04-19  Tom Tromey  <tom@tromey.com>
5783
5784         * event-loop.c: Don't include "common/queue.h".
5785
5786 2019-04-19  Tom Tromey  <tom@tromey.com>
5787
5788         * remote.c (remote_target): Use delete.
5789         * remote-notif.h: Include <list>, not "common/queue.h".
5790         (notif_client_p): Remove typedef.
5791         (remote_notif_state): Add constructor, destructor, initializer.
5792         <notif_queue>: Now a std::list.
5793         (remote_notif_state_xfree): Don't declare.
5794         * remote-notif.c (remote_notif_process, handle_notification)
5795         (remote_notif_state_allocate): Update.
5796         (~remote_notif_state): Rename from remote_notif_state_xfree.
5797
5798 2019-04-19  Tom Tromey  <tom@tromey.com>
5799
5800         * symfile.c (reread_symbols): Update.
5801         * objfiles.c (objfile_register_static_link)
5802         (objfile_lookup_static_link): Update
5803         (~objfile) Don't delete static_links.
5804         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5805
5806 2019-04-19  Tom Tromey  <tom@tromey.com>
5807
5808         * type-stack.h (struct type_stack) <insert>: Constify string.
5809         * type-stack.c (type_stack::insert): Constify string.
5810         * gdbtypes.h (lookup_template_type): Update.
5811         (address_space_name_to_int): Update.
5812         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5813         const.
5814         (lookup_template_type): Make name const.
5815         * c-exp.y: Update rules.
5816         (lex_one_token, classify_name, classify_inner_name)
5817         (c_print_token): Update.
5818         * p-exp.y: Update rules.
5819         (yylex): Update.
5820         * f-exp.y: Update rules.
5821         (yylex): Update.
5822         * d-exp.y: Update rules.
5823         (lex_one_token, classify_name, classify_inner_name): Update.
5824         * parse.c (write_dollar_variable, copy_name): Return std::string.
5825         * parser-defs.h (copy_name): Change return type.
5826         * m2-exp.y: Update rules.
5827         (yylex): Update.
5828         * go-exp.y (lex_one_token): Update.
5829         Update rules.
5830         (classify_unsafe_function, classify_packaged_name)
5831         (classify_name, yylex): Update.
5832
5833 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5834
5835         * configure.ac: add --enable-source-highlight switch.
5836         * configure: Regenerate.
5837         * top.c (print_gdb_version): plumb --enable-source-highlight
5838         status to "show configuration".
5839
5840 2019-04-19  Tom Tromey  <tromey@adacore.com>
5841
5842         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5843         Check ADA_TYPE_P.
5844         (empty_record, ada_template_to_fixed_record_type_1)
5845         (template_to_static_fixed_type)
5846         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5847         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5848         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5849         macros.
5850
5851 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5852
5853         PR symtab/24423:
5854         * source.c (print_source_lines_base): Advance "iter" when a
5855         control character is seen.
5856
5857 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5858
5859         * inferior.h (struct infcall_suspend_state_deleter):
5860         Catch exception in destructor to avoid crash.
5861
5862 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5863
5864         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5865         close to the add_com "shell".
5866
5867 2019-04-18  Tom Tromey  <tromey@adacore.com>
5868
5869         * process-stratum-target.h (class process_stratum_target)
5870         <stratum>: Add "final".
5871
5872 2019-04-17  Tom Tromey  <tromey@adacore.com>
5873
5874         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5875         against nullptr before use.
5876
5877 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5878
5879         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5880
5881 2019-04-17  Jim Wilson  <jimw@sifive.com>
5882             Andrew Burgess  <andrew.burgess@embecosm.com>
5883
5884         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5885         code read might fail, assume 4-byte breakpoint in that case.
5886
5887 2019-04-15  Leszek Swirski  <leszeks@google.com>
5888
5889         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5890         rather than a hand-rolled POD check when checking for forced MEMORY
5891         classification.
5892
5893 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5894
5895         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5896         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5897         function.
5898         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5899         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5900         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5901         declaration.
5902
5903 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5904
5905         * aarch64-linux-nat.c
5906         (aarch64_linux_nat_target::thread_architecture): Add override.
5907         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5908         each VQ.
5909
5910 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5911
5912         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5913
5914 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5915
5916         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5917         target types of size 96-bits, add some additional comments, and
5918         check that the builtin type we found was the correct size.
5919
5920 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5921
5922         * utils.c (prompt_for_continue): Don't restore the styling at the
5923         end, as applied_style has the wrong value.  This fixes styling in
5924         long lists of file names that are interrupted by the "Continue?"
5925         prompt.
5926
5927 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5928
5929         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5930         * c-lang.c (c_language_defn): Likewise.
5931         (cplus_language_defn): Likewise.
5932         (asm_language_defn): Likewise.
5933         (minimal_language_defn): Likewise.
5934         * d-lang.c (d_language_defn): Likewise.
5935         * f-lang.c (f_language_defn): Likewise.
5936         * go-lang.c (go_language_defn): Likewise.
5937         * language.c (unknown_language_defn): Likewise.
5938         (auto_language_defn): Likewise.
5939         * language.h (struct language_defn): Remove la_magic field.
5940         (LANG_MAGIC): Delete.
5941         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5942         * objc-lang.c (objc_language_defn): Likewise.
5943         * opencl-lang.c (opencl_language_defn): Likewise.
5944         * p-lang.c (pascal_language_defn): Likewise.
5945         * rust-lang.c (rust_language_defn): Likewise.
5946
5947 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5948
5949         * riscv-tdep.c (riscv_type_align): New function.
5950         (riscv_type_alignment): Delete.
5951         (riscv_arg_location): Use 'type_align'.
5952         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5953
5954 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5955
5956         * gdbtypes.c (type_align): A struct with no non-static fields also
5957         has alignment of 1.
5958
5959 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5960
5961         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5962         component to 0.
5963         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5964         member.
5965         (riscv_struct_info::analyse): New implementation using new
5966         analyse_inner member function.
5967         (riscv_struct_info::field_offset): New member function.
5968         (riscv_struct_info::m_offsets): New member variable.
5969         (riscv_struct_info::analyse_inner): New private member function,
5970         takes the old implementation of riscv_struct_info::analyse but
5971         extended to track field offsets.
5972         (riscv_call_arg_struct): Update the struct folding special cases
5973         to handle cases where empty C++ structs, which are non-zero
5974         length, are found.
5975         (riscv_arg_location): Initialise the length of each location, a
5976         non-zero length now indicates the location is in use.
5977         (riscv_push_dummy_call): Allow for the first location having a
5978         non-zero offset when setting up arguments.
5979         (riscv_return_value): Likewise, but for return values.
5980
5981 2019-04-11  Tom Tromey  <tromey@adacore.com>
5982
5983         * utils.c (internal_vproblem): Make "msg" const.
5984
5985 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5986
5987         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5988         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5989         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5990         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5991
5992 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5993
5994         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5995         function.
5996         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5997         of amd64_collect_native_gregset.
5998         (amd64_linux_nat_target::store_registers): Likewise.
5999
6000 2019-04-10  Tom Tromey  <tom@tromey.com>
6001
6002         * symtab.c (lookup_global_symbol_from_objfile)
6003         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6004         * objfiles.h (class separate_debug_iterator): New.
6005         (class separate_debug_range): New.
6006         (struct objfile) <separate_debug_objfiles>: New method.
6007         (objfile_separate_debug_iterate): Don't declare.
6008         * objfiles.c (separate_debug_iterator::operator++): Rename from
6009         objfile_separate_debug_iterate.
6010         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6011         iterator.
6012         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6013         iterator.
6014
6015 2019-04-10  Tom Tromey  <tom@tromey.com>
6016
6017         * symfile.c (reread_symbols): Remove old comment.
6018         * objfiles.c (free_all_objfiles): Fix a typo.
6019
6020 2019-04-10  Tom Tromey  <tom@tromey.com>
6021
6022         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6023         * minsyms.c (lookup_minimal_symbol): Use foreach.
6024         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6025         (lookup_minimal_symbol_solib_trampoline): Likewise.
6026         * symfile.c (reread_symbols): Use foreach.
6027
6028 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6029             Tom Tromey  <tromey@adacore.com>
6030
6031         PR rust/24414:
6032         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6033         (rust_lex_int_test): Change "value" to be LONGEST.
6034         (rust_lex_tests): Add test for long integer literal.
6035
6036 2019-04-09  Tom Tromey  <tromey@adacore.com>
6037
6038         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6039         to bool.
6040         (extended_remote_target::attach): Update.
6041         (remote_target::remote_notice_new_inferior): Update.
6042         (remote_target::add_current_inferior_and_thread): Update.
6043         * inferior.c (exit_inferior_1): Use "false".
6044         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6045
6046 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6047
6048         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6049         the "start" command.
6050
6051 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6052
6053         * python/py-inferior.c (infpy_thread_from_thread_handle):
6054         Adjust comments to reflect renaming of thread_from_thread_handle
6055         to thread_from_handle.  Adjust keywords.  Fix type error message.
6056         (inferior_object_methods): Add thread_from_handle.  Retain
6057         thread_from_thread_handle, but mark it as deprecated.
6058
6059 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6060
6061         * gdbthread.h (find_thread_by_handle): Revise declaration.
6062         * thread.c (find_thread_by_handle): Likewise.  Adjust
6063         implementation too.
6064         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6065         support for buffer objects as handles.
6066
6067 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6068
6069         * python/py-infthread.c (thpy_thread_handle): New function.
6070         (thread_object_methods): Register thpy_thread_handle.
6071
6072 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6073
6074         * gdbthread.h (thread_to_thread_handle): Declare.
6075         * thread.c (gdbtypes.h): Include.
6076         (thread_to_thread_handle): New function.
6077
6078         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6079         (target_thread_info_to_thread_handle): Declare.
6080         * target.c (target_thread_info_to_thread_handle): New function.
6081         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6082         * target-delegates.c: Regenerate.
6083
6084         * linux-thread-db.c (class thread_db_target): Add method
6085         thread_info_to_thread_handle.
6086         (thread_db_target::thread_info_to_thread_handle): Define.
6087         * remote.c (class remote_target): Add new method
6088         thread_info_to_thread_handle.
6089         (remote_target::thread_info_to_thread_handle): Define.
6090
6091 2019-04-08  Pedro Alves  <palves@redhat.com>
6092
6093         * common/common-exceptions.c (throw_exception): Don't create
6094         named object to throw; throw directly.
6095         (throw_it): Likewise.  Don't initialize gdb_exception::message
6096         here, with new; pass FMT and AP to the ctor instead.
6097         * common/common-exceptions.h: Include <string>.
6098         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6099         const char *, va_list)): New ctor.  Use std::make_shared.
6100         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6101         errors)): Delete.
6102         (gdb_exception_error::gdb_exception_error(enum errors, const char
6103         *, va_list)): New.
6104         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6105         Add assertion.
6106         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6107         errors)): Delete.
6108         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6109         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6110         Add assertion.
6111
6112 2019-04-08  Tom Tromey  <tom@tromey.com>
6113
6114         * valops.c (value_rtti_indirect_type): Replace throw_exception
6115         with throw.
6116         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6117         with throw.
6118         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6119         throw.
6120         * target.c (target_translate_tls_address): Replace throw_exception
6121         with throw.
6122         * stack.c (frame_apply_command_count): Replace throw_exception
6123         with throw.
6124         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6125         throw.
6126         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6127         with throw.
6128         * rs6000-tdep.c (rs6000_frame_cache)
6129         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6130         * remote.c: Replace throw_exception with throw.
6131         * record-full.c (record_full_message, record_full_wait_1)
6132         (record_full_restore): Replace throw_exception with throw.
6133         * record-btrace.c:
6134         (get_thread_current_frame_id, record_btrace_start_replaying)
6135         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6136         (cmd_record_btrace_start): Replace throw_exception with throw.
6137         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6138         throw.
6139         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6140         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6141         * linespec.c:
6142         (find_linespec_symbols): Replace throw_exception with throw.
6143         * infrun.c (displaced_step_prepare, resume): Replace
6144         throw_exception with throw.
6145         * infcmd.c (post_create_inferior): Replace throw_exception with
6146         throw.
6147         * inf-loop.c (inferior_event_handler): Replace throw_exception
6148         with throw.
6149         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6150         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6151         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6152         (get_prev_frame_always, get_frame_pc_if_available)
6153         (get_frame_address_in_block_if_available, get_frame_language):
6154         Replace throw_exception with throw.
6155         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6156         throw_exception with throw.
6157         * eval.c (fetch_subexp_value, evaluate_var_value)
6158         (evaluate_funcall, evaluate_subexp_standard): Replace
6159         throw_exception with throw.
6160         * dwarf2loc.c (call_site_find_chain)
6161         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6162         Replace throw_exception with throw.
6163         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6164         with throw.
6165         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6166         throw.
6167         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6168         * completer.c (complete_line_internal): Replace throw_exception
6169         with throw.
6170         * compile/compile-object-run.c (compile_object_run): Replace
6171         throw_exception with throw.
6172         * cli/cli-script.c (process_next_line): Replace throw_exception
6173         with throw.
6174         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6175         (btrace_enable, btrace_maint_update_pt_packets): Replace
6176         throw_exception with throw.
6177         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6178         throw_exception with throw.
6179         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6180         throw_exception with throw.
6181         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6182         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6183         * aarch64-tdep.c (aarch64_make_prologue_cache)
6184         (aarch64_make_stub_cache): Replace throw_exception with throw.
6185
6186 2019-04-08  Tom Tromey  <tom@tromey.com>
6187
6188         * common/common-exceptions.c (throw_exception): Rename from
6189         throw_exception_cxx.  Remove old copy.  Make argument const.
6190         (throw_it): Create and throw exception objects directly.
6191         * common/common-exceptions.h (throw_exception): Make argument
6192         const.
6193         (struct gdb_exception_error): Add constructor.
6194         (struct gdb_exception_quit): Add constructor.
6195
6196 2019-04-08  Tom Tromey  <tom@tromey.com>
6197
6198         * common/common-exceptions.h (exception_rethrow): Don't declare.
6199         (TRY_SJLJ): Update comment.
6200         (TRY, CATCH, END_CATCH): Remove.
6201         * common/common-exceptions.c (exception_rethrow): Remove.
6202
6203 2019-04-08  Tom Tromey  <tom@tromey.com>
6204
6205         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6206         Remove.
6207         (gdb_exception_error): Rename from
6208         gdb_exception_RETURN_MASK_ERROR.
6209         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6210         (gdb_quit_bad_alloc): Update.
6211         * aarch64-tdep.c: Update.
6212         * ada-lang.c: Update.
6213         * ada-typeprint.c: Update.
6214         * ada-valprint.c: Update.
6215         * amd64-tdep.c: Update.
6216         * arch-utils.c: Update.
6217         * break-catch-throw.c: Update.
6218         * breakpoint.c: Update.
6219         * btrace.c: Update.
6220         * c-varobj.c: Update.
6221         * cli/cli-cmds.c: Update.
6222         * cli/cli-interp.c: Update.
6223         * cli/cli-script.c: Update.
6224         * common/common-exceptions.c: Update.
6225         * common/new-op.c: Update.
6226         * common/selftest.c: Update.
6227         * compile/compile-c-symbols.c: Update.
6228         * compile/compile-cplus-symbols.c: Update.
6229         * compile/compile-object-load.c: Update.
6230         * compile/compile-object-run.c: Update.
6231         * completer.c: Update.
6232         * corelow.c: Update.
6233         * cp-abi.c: Update.
6234         * cp-support.c: Update.
6235         * cp-valprint.c: Update.
6236         * darwin-nat.c: Update.
6237         * disasm-selftests.c: Update.
6238         * dtrace-probe.c: Update.
6239         * dwarf-index-cache.c: Update.
6240         * dwarf-index-write.c: Update.
6241         * dwarf2-frame-tailcall.c: Update.
6242         * dwarf2-frame.c: Update.
6243         * dwarf2loc.c: Update.
6244         * dwarf2read.c: Update.
6245         * eval.c: Update.
6246         * event-loop.c: Update.
6247         * event-top.c: Update.
6248         * exec.c: Update.
6249         * f-valprint.c: Update.
6250         * fbsd-tdep.c: Update.
6251         * frame-unwind.c: Update.
6252         * frame.c: Update.
6253         * gdbtypes.c: Update.
6254         * gnu-v3-abi.c: Update.
6255         * guile/guile-internal.h: Update.
6256         * guile/scm-block.c: Update.
6257         * guile/scm-breakpoint.c: Update.
6258         * guile/scm-cmd.c: Update.
6259         * guile/scm-disasm.c: Update.
6260         * guile/scm-frame.c: Update.
6261         * guile/scm-lazy-string.c: Update.
6262         * guile/scm-math.c: Update.
6263         * guile/scm-param.c: Update.
6264         * guile/scm-ports.c: Update.
6265         * guile/scm-pretty-print.c: Update.
6266         * guile/scm-symbol.c: Update.
6267         * guile/scm-symtab.c: Update.
6268         * guile/scm-type.c: Update.
6269         * guile/scm-value.c: Update.
6270         * i386-linux-tdep.c: Update.
6271         * i386-tdep.c: Update.
6272         * inf-loop.c: Update.
6273         * infcall.c: Update.
6274         * infcmd.c: Update.
6275         * infrun.c: Update.
6276         * jit.c: Update.
6277         * language.c: Update.
6278         * linespec.c: Update.
6279         * linux-fork.c: Update.
6280         * linux-nat.c: Update.
6281         * linux-tdep.c: Update.
6282         * linux-thread-db.c: Update.
6283         * main.c: Update.
6284         * mi/mi-cmd-break.c: Update.
6285         * mi/mi-cmd-stack.c: Update.
6286         * mi/mi-interp.c: Update.
6287         * mi/mi-main.c: Update.
6288         * objc-lang.c: Update.
6289         * p-valprint.c: Update.
6290         * parse.c: Update.
6291         * ppc-linux-tdep.c: Update.
6292         * printcmd.c: Update.
6293         * python/py-arch.c: Update.
6294         * python/py-breakpoint.c: Update.
6295         * python/py-cmd.c: Update.
6296         * python/py-finishbreakpoint.c: Update.
6297         * python/py-frame.c: Update.
6298         * python/py-framefilter.c: Update.
6299         * python/py-gdb-readline.c: Update.
6300         * python/py-inferior.c: Update.
6301         * python/py-infthread.c: Update.
6302         * python/py-lazy-string.c: Update.
6303         * python/py-linetable.c: Update.
6304         * python/py-objfile.c: Update.
6305         * python/py-param.c: Update.
6306         * python/py-prettyprint.c: Update.
6307         * python/py-progspace.c: Update.
6308         * python/py-record-btrace.c: Update.
6309         * python/py-record.c: Update.
6310         * python/py-symbol.c: Update.
6311         * python/py-type.c: Update.
6312         * python/py-unwind.c: Update.
6313         * python/py-utils.c: Update.
6314         * python/py-value.c: Update.
6315         * python/python.c: Update.
6316         * record-btrace.c: Update.
6317         * record-full.c: Update.
6318         * remote-fileio.c: Update.
6319         * remote.c: Update.
6320         * riscv-tdep.c: Update.
6321         * rs6000-aix-tdep.c: Update.
6322         * rs6000-tdep.c: Update.
6323         * rust-exp.y: Update.
6324         * rust-lang.c: Update.
6325         * s390-tdep.c: Update.
6326         * selftest-arch.c: Update.
6327         * solib-dsbt.c: Update.
6328         * solib-frv.c: Update.
6329         * solib-spu.c: Update.
6330         * solib-svr4.c: Update.
6331         * solib.c: Update.
6332         * sparc64-linux-tdep.c: Update.
6333         * stack.c: Update.
6334         * symfile-mem.c: Update.
6335         * symmisc.c: Update.
6336         * target.c: Update.
6337         * thread.c: Update.
6338         * top.c: Update.
6339         * tracefile-tfile.c: Update.
6340         * tui/tui.c: Update.
6341         * typeprint.c: Update.
6342         * unittests/cli-utils-selftests.c: Update.
6343         * unittests/parse-connection-spec-selftests.c: Update.
6344         * valops.c: Update.
6345         * valprint.c: Update.
6346         * value.c: Update.
6347         * varobj.c: Update.
6348         * windows-nat.c: Update.
6349         * x86-linux-nat.c: Update.
6350         * xml-support.c: Update.
6351
6352 2019-04-08  Tom Tromey  <tom@tromey.com>
6353
6354         * xml-support.c: Use C++ exception handling.
6355         * x86-linux-nat.c: Use C++ exception handling.
6356         * windows-nat.c: Use C++ exception handling.
6357         * varobj.c: Use C++ exception handling.
6358         * value.c: Use C++ exception handling.
6359         * valprint.c: Use C++ exception handling.
6360         * valops.c: Use C++ exception handling.
6361         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6362         handling.
6363         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6364         * typeprint.c: Use C++ exception handling.
6365         * tui/tui.c: Use C++ exception handling.
6366         * tracefile-tfile.c: Use C++ exception handling.
6367         * top.c: Use C++ exception handling.
6368         * thread.c: Use C++ exception handling.
6369         * target.c: Use C++ exception handling.
6370         * symmisc.c: Use C++ exception handling.
6371         * symfile-mem.c: Use C++ exception handling.
6372         * stack.c: Use C++ exception handling.
6373         * sparc64-linux-tdep.c: Use C++ exception handling.
6374         * solib.c: Use C++ exception handling.
6375         * solib-svr4.c: Use C++ exception handling.
6376         * solib-spu.c: Use C++ exception handling.
6377         * solib-frv.c: Use C++ exception handling.
6378         * solib-dsbt.c: Use C++ exception handling.
6379         * selftest-arch.c: Use C++ exception handling.
6380         * s390-tdep.c: Use C++ exception handling.
6381         * rust-lang.c: Use C++ exception handling.
6382         * rust-exp.y: Use C++ exception handling.
6383         * rs6000-tdep.c: Use C++ exception handling.
6384         * rs6000-aix-tdep.c: Use C++ exception handling.
6385         * riscv-tdep.c: Use C++ exception handling.
6386         * remote.c: Use C++ exception handling.
6387         * remote-fileio.c: Use C++ exception handling.
6388         * record-full.c: Use C++ exception handling.
6389         * record-btrace.c: Use C++ exception handling.
6390         * python/python.c: Use C++ exception handling.
6391         * python/py-value.c: Use C++ exception handling.
6392         * python/py-utils.c: Use C++ exception handling.
6393         * python/py-unwind.c: Use C++ exception handling.
6394         * python/py-type.c: Use C++ exception handling.
6395         * python/py-symbol.c: Use C++ exception handling.
6396         * python/py-record.c: Use C++ exception handling.
6397         * python/py-record-btrace.c: Use C++ exception handling.
6398         * python/py-progspace.c: Use C++ exception handling.
6399         * python/py-prettyprint.c: Use C++ exception handling.
6400         * python/py-param.c: Use C++ exception handling.
6401         * python/py-objfile.c: Use C++ exception handling.
6402         * python/py-linetable.c: Use C++ exception handling.
6403         * python/py-lazy-string.c: Use C++ exception handling.
6404         * python/py-infthread.c: Use C++ exception handling.
6405         * python/py-inferior.c: Use C++ exception handling.
6406         * python/py-gdb-readline.c: Use C++ exception handling.
6407         * python/py-framefilter.c: Use C++ exception handling.
6408         * python/py-frame.c: Use C++ exception handling.
6409         * python/py-finishbreakpoint.c: Use C++ exception handling.
6410         * python/py-cmd.c: Use C++ exception handling.
6411         * python/py-breakpoint.c: Use C++ exception handling.
6412         * python/py-arch.c: Use C++ exception handling.
6413         * printcmd.c: Use C++ exception handling.
6414         * ppc-linux-tdep.c: Use C++ exception handling.
6415         * parse.c: Use C++ exception handling.
6416         * p-valprint.c: Use C++ exception handling.
6417         * objc-lang.c: Use C++ exception handling.
6418         * mi/mi-main.c: Use C++ exception handling.
6419         * mi/mi-interp.c: Use C++ exception handling.
6420         * mi/mi-cmd-stack.c: Use C++ exception handling.
6421         * mi/mi-cmd-break.c: Use C++ exception handling.
6422         * main.c: Use C++ exception handling.
6423         * linux-thread-db.c: Use C++ exception handling.
6424         * linux-tdep.c: Use C++ exception handling.
6425         * linux-nat.c: Use C++ exception handling.
6426         * linux-fork.c: Use C++ exception handling.
6427         * linespec.c: Use C++ exception handling.
6428         * language.c: Use C++ exception handling.
6429         * jit.c: Use C++ exception handling.
6430         * infrun.c: Use C++ exception handling.
6431         * infcmd.c: Use C++ exception handling.
6432         * infcall.c: Use C++ exception handling.
6433         * inf-loop.c: Use C++ exception handling.
6434         * i386-tdep.c: Use C++ exception handling.
6435         * i386-linux-tdep.c: Use C++ exception handling.
6436         * guile/scm-value.c: Use C++ exception handling.
6437         * guile/scm-type.c: Use C++ exception handling.
6438         * guile/scm-symtab.c: Use C++ exception handling.
6439         * guile/scm-symbol.c: Use C++ exception handling.
6440         * guile/scm-pretty-print.c: Use C++ exception handling.
6441         * guile/scm-ports.c: Use C++ exception handling.
6442         * guile/scm-param.c: Use C++ exception handling.
6443         * guile/scm-math.c: Use C++ exception handling.
6444         * guile/scm-lazy-string.c: Use C++ exception handling.
6445         * guile/scm-frame.c: Use C++ exception handling.
6446         * guile/scm-disasm.c: Use C++ exception handling.
6447         * guile/scm-cmd.c: Use C++ exception handling.
6448         * guile/scm-breakpoint.c: Use C++ exception handling.
6449         * guile/scm-block.c: Use C++ exception handling.
6450         * guile/guile-internal.h: Use C++ exception handling.
6451         * gnu-v3-abi.c: Use C++ exception handling.
6452         * gdbtypes.c: Use C++ exception handling.
6453         * frame.c: Use C++ exception handling.
6454         * frame-unwind.c: Use C++ exception handling.
6455         * fbsd-tdep.c: Use C++ exception handling.
6456         * f-valprint.c: Use C++ exception handling.
6457         * exec.c: Use C++ exception handling.
6458         * event-top.c: Use C++ exception handling.
6459         * event-loop.c: Use C++ exception handling.
6460         * eval.c: Use C++ exception handling.
6461         * dwarf2read.c: Use C++ exception handling.
6462         * dwarf2loc.c: Use C++ exception handling.
6463         * dwarf2-frame.c: Use C++ exception handling.
6464         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6465         * dwarf-index-write.c: Use C++ exception handling.
6466         * dwarf-index-cache.c: Use C++ exception handling.
6467         * dtrace-probe.c: Use C++ exception handling.
6468         * disasm-selftests.c: Use C++ exception handling.
6469         * darwin-nat.c: Use C++ exception handling.
6470         * cp-valprint.c: Use C++ exception handling.
6471         * cp-support.c: Use C++ exception handling.
6472         * cp-abi.c: Use C++ exception handling.
6473         * corelow.c: Use C++ exception handling.
6474         * completer.c: Use C++ exception handling.
6475         * compile/compile-object-run.c: Use C++ exception handling.
6476         * compile/compile-object-load.c: Use C++ exception handling.
6477         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6478         * compile/compile-c-symbols.c: Use C++ exception handling.
6479         * common/selftest.c: Use C++ exception handling.
6480         * common/new-op.c: Use C++ exception handling.
6481         * cli/cli-script.c: Use C++ exception handling.
6482         * cli/cli-interp.c: Use C++ exception handling.
6483         * cli/cli-cmds.c: Use C++ exception handling.
6484         * c-varobj.c: Use C++ exception handling.
6485         * btrace.c: Use C++ exception handling.
6486         * breakpoint.c: Use C++ exception handling.
6487         * break-catch-throw.c: Use C++ exception handling.
6488         * arch-utils.c: Use C++ exception handling.
6489         * amd64-tdep.c: Use C++ exception handling.
6490         * ada-valprint.c: Use C++ exception handling.
6491         * ada-typeprint.c: Use C++ exception handling.
6492         * ada-lang.c: Use C++ exception handling.
6493         * aarch64-tdep.c: Use C++ exception handling.
6494
6495 2019-04-08  Tom Tromey  <tom@tromey.com>
6496
6497         * xml-support.c (gdb_xml_parser::parse): Update.
6498         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6499         * value.c (show_convenience): Update.
6500         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6501         (test_parse_flags_qcs): Update.
6502         * thread.c (thr_try_catch_cmd): Update.
6503         * target.c (target_translate_tls_address): Update.
6504         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6505         (info_frame_command_core, frame_apply_command_count): Update.
6506         * rust-exp.y (rust_lex_exception_test): Update.
6507         * riscv-tdep.c (riscv_print_one_register_info): Update.
6508         * remote.c (remote_target::enable_btrace): Update.
6509         * record-btrace.c (record_btrace_enable_warn): Update.
6510         * python/py-utils.c (gdbpy_convert_exception): Update.
6511         * printcmd.c (do_one_display, print_variable_and_value): Update.
6512         * mi/mi-main.c (mi_print_exception): Update.
6513         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6514         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6515         * linux-nat.c (linux_nat_target::attach): Update.
6516         * linux-fork.c (class scoped_switch_fork_info): Update.
6517         * infrun.c (displaced_step_prepare): Update.
6518         * infcall.c (call_function_by_hand_dummy): Update.
6519         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6520         * gnu-v3-abi.c (print_one_vtable): Update.
6521         * frame.c (get_prev_frame_always): Update.
6522         * f-valprint.c (info_common_command_for_block): Update.
6523         * exec.c (try_open_exec_file): Update.
6524         * exceptions.c (print_exception, exception_print)
6525         (exception_fprintf, exception_print_same): Update.
6526         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6527         * dwarf-index-cache.c (index_cache::store)
6528         (index_cache::lookup_gdb_index): Update.
6529         * darwin-nat.c (maybe_cache_shell): Update.
6530         * cp-valprint.c (cp_print_value_fields): Update.
6531         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6532         (gcc_cplus_symbol_address): Update.
6533         * compile/compile-c-symbols.c (gcc_convert_symbol)
6534         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6535         * common/selftest.c: Update.
6536         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6537         a std::string.
6538         (exception_try_scope_entry, exception_try_scope_exit): Don't
6539         declare.
6540         (struct exception_try_scope): Remove.
6541         (TRY): Don't use exception_try_scope.
6542         (struct gdb_exception): Add constructor, operator=.
6543         <what>: New method.
6544         (struct gdb_exception_RETURN_MASK_ALL)
6545         (struct gdb_exception_RETURN_MASK_ERROR)
6546         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6547         (struct gdb_quit_bad_alloc): Update.
6548         * common/common-exceptions.c (exception_none): Change
6549         initializer.
6550         (struct catcher) <state, exception>: Initialize inline.
6551         <prev>: Remove member.
6552         (current_catcher): Remove.
6553         (catchers): New global.
6554         (exceptions_state_mc_init): Simplify.
6555         (catcher_pop): Remove.
6556         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6557         (try_scope_depth, exception_try_scope_entry)
6558         (exception_try_scope_exit): Remove.
6559         (throw_exception_sjlj): Update.
6560         (exception_messages, exception_messages_size): Remove.
6561         (throw_it): Simplify.
6562         (gdb_exception_sliced_copy): Remove.
6563         (throw_exception_cxx): Update.
6564         * cli/cli-script.c (script_from_file): Update.
6565         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6566         Update.
6567         * ada-valprint.c (ada_val_print): Update.
6568         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6569         (create_excep_cond_exprs): Update.
6570
6571 2019-04-08  Tom Tromey  <tom@tromey.com>
6572
6573         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6574         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6575         (TRY, CATCH, END_CATCH): Remove some definitions.
6576         * common/common-exceptions.c: Don't use GDB_XCPT.
6577         (catcher_list_size): Remove.
6578         (throw_exception, throw_it): Simplify.
6579
6580 2019-04-05  Tom Tromey  <tom@tromey.com>
6581
6582         Revert the header-sorting patch.
6583         * ft32-tdep.c: Revert.
6584         * frv-tdep.c: Revert.
6585         * frv-linux-tdep.c: Revert.
6586         * frame.c: Revert.
6587         * frame-unwind.c: Revert.
6588         * frame-base.c: Revert.
6589         * fork-child.c: Revert.
6590         * findvar.c: Revert.
6591         * findcmd.c: Revert.
6592         * filesystem.c: Revert.
6593         * filename-seen-cache.h: Revert.
6594         * filename-seen-cache.c: Revert.
6595         * fbsd-tdep.c: Revert.
6596         * fbsd-nat.h: Revert.
6597         * fbsd-nat.c: Revert.
6598         * f-valprint.c: Revert.
6599         * f-typeprint.c: Revert.
6600         * f-lang.c: Revert.
6601         * extension.h: Revert.
6602         * extension.c: Revert.
6603         * extension-priv.h: Revert.
6604         * expprint.c: Revert.
6605         * exec.h: Revert.
6606         * exec.c: Revert.
6607         * exceptions.c: Revert.
6608         * event-top.c: Revert.
6609         * event-loop.c: Revert.
6610         * eval.c: Revert.
6611         * elfread.c: Revert.
6612         * dwarf2read.h: Revert.
6613         * dwarf2read.c: Revert.
6614         * dwarf2loc.c: Revert.
6615         * dwarf2expr.h: Revert.
6616         * dwarf2expr.c: Revert.
6617         * dwarf2-frame.c: Revert.
6618         * dwarf2-frame-tailcall.c: Revert.
6619         * dwarf-index-write.h: Revert.
6620         * dwarf-index-write.c: Revert.
6621         * dwarf-index-common.c: Revert.
6622         * dwarf-index-cache.h: Revert.
6623         * dwarf-index-cache.c: Revert.
6624         * dummy-frame.c: Revert.
6625         * dtrace-probe.c: Revert.
6626         * disasm.h: Revert.
6627         * disasm.c: Revert.
6628         * disasm-selftests.c: Revert.
6629         * dictionary.c: Revert.
6630         * dicos-tdep.c: Revert.
6631         * demangle.c: Revert.
6632         * dcache.h: Revert.
6633         * dcache.c: Revert.
6634         * darwin-nat.h: Revert.
6635         * darwin-nat.c: Revert.
6636         * darwin-nat-info.c: Revert.
6637         * d-valprint.c: Revert.
6638         * d-namespace.c: Revert.
6639         * d-lang.c: Revert.
6640         * ctf.c: Revert.
6641         * csky-tdep.c: Revert.
6642         * csky-linux-tdep.c: Revert.
6643         * cris-tdep.c: Revert.
6644         * cris-linux-tdep.c: Revert.
6645         * cp-valprint.c: Revert.
6646         * cp-support.c: Revert.
6647         * cp-namespace.c: Revert.
6648         * cp-abi.c: Revert.
6649         * corelow.c: Revert.
6650         * corefile.c: Revert.
6651         * continuations.c: Revert.
6652         * completer.h: Revert.
6653         * completer.c: Revert.
6654         * complaints.c: Revert.
6655         * coffread.c: Revert.
6656         * coff-pe-read.c: Revert.
6657         * cli-out.h: Revert.
6658         * cli-out.c: Revert.
6659         * charset.c: Revert.
6660         * c-varobj.c: Revert.
6661         * c-valprint.c: Revert.
6662         * c-typeprint.c: Revert.
6663         * c-lang.c: Revert.
6664         * buildsym.c: Revert.
6665         * buildsym-legacy.c: Revert.
6666         * build-id.h: Revert.
6667         * build-id.c: Revert.
6668         * btrace.c: Revert.
6669         * bsd-uthread.c: Revert.
6670         * breakpoint.h: Revert.
6671         * breakpoint.c: Revert.
6672         * break-catch-throw.c: Revert.
6673         * break-catch-syscall.c: Revert.
6674         * break-catch-sig.c: Revert.
6675         * blockframe.c: Revert.
6676         * block.c: Revert.
6677         * bfin-tdep.c: Revert.
6678         * bfin-linux-tdep.c: Revert.
6679         * bfd-target.c: Revert.
6680         * bcache.c: Revert.
6681         * ax-general.c: Revert.
6682         * ax-gdb.h: Revert.
6683         * ax-gdb.c: Revert.
6684         * avr-tdep.c: Revert.
6685         * auxv.c: Revert.
6686         * auto-load.c: Revert.
6687         * arm-wince-tdep.c: Revert.
6688         * arm-tdep.c: Revert.
6689         * arm-symbian-tdep.c: Revert.
6690         * arm-pikeos-tdep.c: Revert.
6691         * arm-obsd-tdep.c: Revert.
6692         * arm-nbsd-tdep.c: Revert.
6693         * arm-nbsd-nat.c: Revert.
6694         * arm-linux-tdep.c: Revert.
6695         * arm-linux-nat.c: Revert.
6696         * arm-fbsd-tdep.c: Revert.
6697         * arm-fbsd-nat.c: Revert.
6698         * arm-bsd-tdep.c: Revert.
6699         * arch-utils.c: Revert.
6700         * arc-tdep.c: Revert.
6701         * arc-newlib-tdep.c: Revert.
6702         * annotate.h: Revert.
6703         * annotate.c: Revert.
6704         * amd64-windows-tdep.c: Revert.
6705         * amd64-windows-nat.c: Revert.
6706         * amd64-tdep.c: Revert.
6707         * amd64-sol2-tdep.c: Revert.
6708         * amd64-obsd-tdep.c: Revert.
6709         * amd64-obsd-nat.c: Revert.
6710         * amd64-nbsd-tdep.c: Revert.
6711         * amd64-nbsd-nat.c: Revert.
6712         * amd64-nat.c: Revert.
6713         * amd64-linux-tdep.c: Revert.
6714         * amd64-linux-nat.c: Revert.
6715         * amd64-fbsd-tdep.c: Revert.
6716         * amd64-fbsd-nat.c: Revert.
6717         * amd64-dicos-tdep.c: Revert.
6718         * amd64-darwin-tdep.c: Revert.
6719         * amd64-bsd-nat.c: Revert.
6720         * alpha-tdep.c: Revert.
6721         * alpha-obsd-tdep.c: Revert.
6722         * alpha-nbsd-tdep.c: Revert.
6723         * alpha-mdebug-tdep.c: Revert.
6724         * alpha-linux-tdep.c: Revert.
6725         * alpha-linux-nat.c: Revert.
6726         * alpha-bsd-tdep.c: Revert.
6727         * alpha-bsd-nat.c: Revert.
6728         * aix-thread.c: Revert.
6729         * agent.c: Revert.
6730         * addrmap.c: Revert.
6731         * ada-varobj.c: Revert.
6732         * ada-valprint.c: Revert.
6733         * ada-typeprint.c: Revert.
6734         * ada-tasks.c: Revert.
6735         * ada-lang.c: Revert.
6736         * aarch64-tdep.c: Revert.
6737         * aarch64-ravenscar-thread.c: Revert.
6738         * aarch64-newlib-tdep.c: Revert.
6739         * aarch64-linux-tdep.c: Revert.
6740         * aarch64-linux-nat.c: Revert.
6741         * aarch64-fbsd-tdep.c: Revert.
6742         * aarch64-fbsd-nat.c: Revert.
6743         * aarch32-linux-nat.c: Revert.
6744
6745 2019-04-05  Tom Tromey  <tom@tromey.com>
6746
6747         * ft32-tdep.c: Sort headers.
6748         * frv-tdep.c: Sort headers.
6749         * frv-linux-tdep.c: Sort headers.
6750         * frame.c: Sort headers.
6751         * frame-unwind.c: Sort headers.
6752         * frame-base.c: Sort headers.
6753         * fork-child.c: Sort headers.
6754         * findvar.c: Sort headers.
6755         * findcmd.c: Sort headers.
6756         * filesystem.c: Sort headers.
6757         * filename-seen-cache.h: Sort headers.
6758         * filename-seen-cache.c: Sort headers.
6759         * fbsd-tdep.c: Sort headers.
6760         * fbsd-nat.h: Sort headers.
6761         * fbsd-nat.c: Sort headers.
6762         * f-valprint.c: Sort headers.
6763         * f-typeprint.c: Sort headers.
6764         * f-lang.c: Sort headers.
6765         * extension.h: Sort headers.
6766         * extension.c: Sort headers.
6767         * extension-priv.h: Sort headers.
6768         * expprint.c: Sort headers.
6769         * exec.h: Sort headers.
6770         * exec.c: Sort headers.
6771         * exceptions.c: Sort headers.
6772         * event-top.c: Sort headers.
6773         * event-loop.c: Sort headers.
6774         * eval.c: Sort headers.
6775         * elfread.c: Sort headers.
6776         * dwarf2read.h: Sort headers.
6777         * dwarf2read.c: Sort headers.
6778         * dwarf2loc.c: Sort headers.
6779         * dwarf2expr.h: Sort headers.
6780         * dwarf2expr.c: Sort headers.
6781         * dwarf2-frame.c: Sort headers.
6782         * dwarf2-frame-tailcall.c: Sort headers.
6783         * dwarf-index-write.h: Sort headers.
6784         * dwarf-index-write.c: Sort headers.
6785         * dwarf-index-common.c: Sort headers.
6786         * dwarf-index-cache.h: Sort headers.
6787         * dwarf-index-cache.c: Sort headers.
6788         * dummy-frame.c: Sort headers.
6789         * dtrace-probe.c: Sort headers.
6790         * disasm.h: Sort headers.
6791         * disasm.c: Sort headers.
6792         * disasm-selftests.c: Sort headers.
6793         * dictionary.c: Sort headers.
6794         * dicos-tdep.c: Sort headers.
6795         * demangle.c: Sort headers.
6796         * dcache.h: Sort headers.
6797         * dcache.c: Sort headers.
6798         * darwin-nat.h: Sort headers.
6799         * darwin-nat.c: Sort headers.
6800         * darwin-nat-info.c: Sort headers.
6801         * d-valprint.c: Sort headers.
6802         * d-namespace.c: Sort headers.
6803         * d-lang.c: Sort headers.
6804         * ctf.c: Sort headers.
6805         * csky-tdep.c: Sort headers.
6806         * csky-linux-tdep.c: Sort headers.
6807         * cris-tdep.c: Sort headers.
6808         * cris-linux-tdep.c: Sort headers.
6809         * cp-valprint.c: Sort headers.
6810         * cp-support.c: Sort headers.
6811         * cp-namespace.c: Sort headers.
6812         * cp-abi.c: Sort headers.
6813         * corelow.c: Sort headers.
6814         * corefile.c: Sort headers.
6815         * continuations.c: Sort headers.
6816         * completer.h: Sort headers.
6817         * completer.c: Sort headers.
6818         * complaints.c: Sort headers.
6819         * coffread.c: Sort headers.
6820         * coff-pe-read.c: Sort headers.
6821         * cli-out.h: Sort headers.
6822         * cli-out.c: Sort headers.
6823         * charset.c: Sort headers.
6824         * c-varobj.c: Sort headers.
6825         * c-valprint.c: Sort headers.
6826         * c-typeprint.c: Sort headers.
6827         * c-lang.c: Sort headers.
6828         * buildsym.c: Sort headers.
6829         * buildsym-legacy.c: Sort headers.
6830         * build-id.h: Sort headers.
6831         * build-id.c: Sort headers.
6832         * btrace.c: Sort headers.
6833         * bsd-uthread.c: Sort headers.
6834         * breakpoint.h: Sort headers.
6835         * breakpoint.c: Sort headers.
6836         * break-catch-throw.c: Sort headers.
6837         * break-catch-syscall.c: Sort headers.
6838         * break-catch-sig.c: Sort headers.
6839         * blockframe.c: Sort headers.
6840         * block.c: Sort headers.
6841         * bfin-tdep.c: Sort headers.
6842         * bfin-linux-tdep.c: Sort headers.
6843         * bfd-target.c: Sort headers.
6844         * bcache.c: Sort headers.
6845         * ax-general.c: Sort headers.
6846         * ax-gdb.h: Sort headers.
6847         * ax-gdb.c: Sort headers.
6848         * avr-tdep.c: Sort headers.
6849         * auxv.c: Sort headers.
6850         * auto-load.c: Sort headers.
6851         * arm-wince-tdep.c: Sort headers.
6852         * arm-tdep.c: Sort headers.
6853         * arm-symbian-tdep.c: Sort headers.
6854         * arm-pikeos-tdep.c: Sort headers.
6855         * arm-obsd-tdep.c: Sort headers.
6856         * arm-nbsd-tdep.c: Sort headers.
6857         * arm-nbsd-nat.c: Sort headers.
6858         * arm-linux-tdep.c: Sort headers.
6859         * arm-linux-nat.c: Sort headers.
6860         * arm-fbsd-tdep.c: Sort headers.
6861         * arm-fbsd-nat.c: Sort headers.
6862         * arm-bsd-tdep.c: Sort headers.
6863         * arch-utils.c: Sort headers.
6864         * arc-tdep.c: Sort headers.
6865         * arc-newlib-tdep.c: Sort headers.
6866         * annotate.h: Sort headers.
6867         * annotate.c: Sort headers.
6868         * amd64-windows-tdep.c: Sort headers.
6869         * amd64-windows-nat.c: Sort headers.
6870         * amd64-tdep.c: Sort headers.
6871         * amd64-sol2-tdep.c: Sort headers.
6872         * amd64-obsd-tdep.c: Sort headers.
6873         * amd64-obsd-nat.c: Sort headers.
6874         * amd64-nbsd-tdep.c: Sort headers.
6875         * amd64-nbsd-nat.c: Sort headers.
6876         * amd64-nat.c: Sort headers.
6877         * amd64-linux-tdep.c: Sort headers.
6878         * amd64-linux-nat.c: Sort headers.
6879         * amd64-fbsd-tdep.c: Sort headers.
6880         * amd64-fbsd-nat.c: Sort headers.
6881         * amd64-dicos-tdep.c: Sort headers.
6882         * amd64-darwin-tdep.c: Sort headers.
6883         * amd64-bsd-nat.c: Sort headers.
6884         * alpha-tdep.c: Sort headers.
6885         * alpha-obsd-tdep.c: Sort headers.
6886         * alpha-nbsd-tdep.c: Sort headers.
6887         * alpha-mdebug-tdep.c: Sort headers.
6888         * alpha-linux-tdep.c: Sort headers.
6889         * alpha-linux-nat.c: Sort headers.
6890         * alpha-bsd-tdep.c: Sort headers.
6891         * alpha-bsd-nat.c: Sort headers.
6892         * aix-thread.c: Sort headers.
6893         * agent.c: Sort headers.
6894         * addrmap.c: Sort headers.
6895         * ada-varobj.c: Sort headers.
6896         * ada-valprint.c: Sort headers.
6897         * ada-typeprint.c: Sort headers.
6898         * ada-tasks.c: Sort headers.
6899         * ada-lang.c: Sort headers.
6900         * aarch64-tdep.c: Sort headers.
6901         * aarch64-ravenscar-thread.c: Sort headers.
6902         * aarch64-newlib-tdep.c: Sort headers.
6903         * aarch64-linux-tdep.c: Sort headers.
6904         * aarch64-linux-nat.c: Sort headers.
6905         * aarch64-fbsd-tdep.c: Sort headers.
6906         * aarch64-fbsd-nat.c: Sort headers.
6907         * aarch32-linux-nat.c: Sort headers.
6908
6909 2019-04-04  Tom Tromey  <tom@tromey.com>
6910
6911         * varobj.c (varobj_create): Update.
6912         * rust-exp.y (struct rust_parser) <update_innermost_block,
6913         lookup_symbol>: New methods.
6914         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6915         Rename.
6916         (rust_parser::rust_lookup_type)
6917         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6918         * printcmd.c (display_command, do_one_display): Update.
6919         * parser-defs.h (struct parser_state) <parser_state>: Add
6920         "tracker" parameter.
6921         (block_tracker): New member.
6922         (class innermost_block_tracker) <innermost_block_tracker>: Add
6923         "types" parameter.
6924         <reset>: Remove method.
6925         (innermost_block): Don't declare.
6926         (null_post_parser): Update.
6927         * parse.c (innermost_block): Remove global.
6928         (write_dollar_variable): Update.
6929         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6930         Remove "tracker_types" parameter.
6931         (parse_expression): Add "tracker" parameter.
6932         (parse_expression_for_completion): Update.
6933         (null_post_parser): Add "tracker" parameter.
6934         * p-exp.y: Update rules.
6935         * m2-exp.y: Update rules.
6936         * language.h (struct language_defn) <la_post_parser>: Add
6937         "tracker" parameter.
6938         * go-exp.y: Update rules.
6939         * f-exp.y: Update rules.
6940         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6941         parameter.
6942         * d-exp.y: Update rules.
6943         * c-exp.y: Update rules.
6944         * breakpoint.c (set_breakpoint_condition): Create an
6945         innermost_block_tracker.
6946         (watch_command_1): Likewise.
6947         * ada-lang.c (resolve): Add "tracker" parameter.
6948         (resolve_subexp): Likewise.
6949         * ada-exp.y (write_var_from_sym): Update.
6950
6951 2019-04-04  Tom Tromey  <tom@tromey.com>
6952
6953         * type-stack.h: New file.
6954         * type-stack.c: New file.
6955         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6956         type-stack.h.
6957         (insert_into_type_stack, insert_type, push_type, push_type_int)
6958         (insert_type_address_space, pop_type, pop_type_int)
6959         (pop_typelist, pop_type_stack, append_type_stack)
6960         (push_type_stack, get_type_stack, push_typelist)
6961         (follow_type_instance_flags, follow_types): Don't declare.
6962         * parse.c (type_stack): Remove global.
6963         (parse_exp_in_context): Update.
6964         (insert_into_type_stack, insert_type, push_type, push_type_int)
6965         (insert_type_address_space, pop_type, pop_type_int)
6966         (pop_typelist, pop_type_stack, append_type_stack)
6967         (push_type_stack, get_type_stack, push_typelist)
6968         (follow_type_instance_flags, follow_types): Remove (moved to
6969         type-stack.c).
6970         * f-exp.y (type_stack): New global.
6971         Update rules.
6972         (push_kind_type, f_parse): Update.
6973         * d-exp.y (type_stack): New global.
6974         Update rules.
6975         (d_parse): Update.
6976         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6977         Update rules.
6978         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6979         (HFILES_NO_SRCDIR): Add type-stack.h.
6980
6981 2019-04-04  Tom Tromey  <tom@tromey.com>
6982
6983         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6984         (rust_parser::convert_ast_to_expression, rust_parse)
6985         (rust_lex_test_completion, rust_lex_tests): Update.
6986         * parser-defs.h (struct expr_completion_state): New.
6987         (struct parser_state) <parser_state>: Add completion parameter.
6988         <mark_struct_expression, mark_completion_tag>: New methods.
6989         <parse_completion, m_completion_state>: New members.
6990         (prefixify_expression, null_post_parser): Update.
6991         (mark_struct_expression, mark_completion_tag): Don't declare.
6992         * parse.c (parse_completion, expout_last_struct)
6993         (expout_tag_completion_type, expout_completion_name): Remove
6994         globals.
6995         (parser_state::mark_struct_expression)
6996         (parser_state::mark_completion_tag): Now methods.
6997         (prefixify_expression): Add last_struct parameter.
6998         (prefixify_subexp): Likewise.
6999         (parse_exp_1): Update.
7000         (parse_exp_in_context): Add cstate parameter.  Update.
7001         (parse_expression_for_completion): Create an
7002         expr_completion_state.
7003         (null_post_parser): Add "completion" parameter.
7004         * p-exp.y: Update rules.
7005         (yylex): Update.
7006         * language.h (struct language_defn) <la_post_parser>: Add
7007         "completing" parameter.
7008         * go-exp.y: Update rules.
7009         (lex_one_token): Update.
7010         * expression.h (parse_completion): Don't declare.
7011         * d-exp.y: Update rules.
7012         (lex_one_token): Update rules.
7013         * c-exp.y: Update rules.
7014         (lex_one_token): Update.
7015         * ada-lang.c (resolve): Add "parse_completion" parameter.
7016         (resolve_subexp): Likewise.
7017         (ada_resolve_function): Likewise.
7018
7019 2019-04-04  Tom Tromey  <tom@tromey.com>
7020
7021         * parser-defs.h (struct parser_state) <start_arglist,
7022         end_arglist>: New methods.
7023         <arglist_len, m_funcall_chain>: New members.
7024         (arglist_len, start_arglist, end_arglist): Don't declare.
7025         * parse.c (arglist_len, funcall_chain): Remove global.
7026         (start_arglist, end_arglist): Remove functions.
7027         (parse_exp_in_context): Update.
7028         * p-exp.y: Update rules.
7029         * m2-exp.y: Update rules.
7030         * go-exp.y: Update rules.
7031         * f-exp.y: Update rules.
7032         * d-exp.y: Update rules.
7033         * c-exp.y: Update rules.
7034
7035 2019-04-04  Tom Tromey  <tom@tromey.com>
7036
7037         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7038         lex_operator, push_back>: New methods.
7039         Update all rules.
7040         (rust_parser::lex_hex, lex_escape): Rename and update.
7041         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7042         (rust_parser::lex_operator): Rename and update.
7043         (rust_parser::lex_number, rustyylex, rustyyerror)
7044         (rust_lex_test_init, rust_lex_test_sequence)
7045         (rust_lex_test_push_back, rust_lex_tests): Update.
7046         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7047         parameter.
7048         <lexptr, prev_lexptr>: New members.
7049         (lexptr, prev_lexptr): Don't declare.
7050         * parse.c (lexptr, prev_lexptr): Remove globals.
7051         (parse_exp_in_context): Update.
7052         * p-exp.y (yylex, yyerror): Update.
7053         * m2-exp.y (parse_number, yylex, yyerror): Update.
7054         * go-exp.y (lex_one_token, yyerror): Update.
7055         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7056         * d-exp.y (lex_one_token, yyerror): Update.
7057         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7058         (lex_one_token, yyerror): Update.
7059         * ada-lex.l (YY_INPUT): Update.
7060         (rewind_to_char): Update.
7061         * ada-exp.y (yyerror): Update.
7062
7063 2019-04-04  Tom Tromey  <tom@tromey.com>
7064
7065         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7066         * parser-defs.h (struct parser_state) <parser_state>: Add new
7067         parameter.
7068         <comma_terminates>: New member.
7069         (comma_terminates): Don't declare global.
7070         * parse.c (comma_terminates): Remove global.
7071         (parse_exp_in_context): Update.
7072         * p-exp.y (yylex): Update.
7073         * m2-exp.y (yylex): Update.
7074         * go-exp.y (lex_one_token): Update.
7075         * f-exp.y (yylex): Update.
7076         * d-exp.y (lex_one_token): Update.
7077         * c-exp.y (lex_one_token): Update.
7078         * ada-lex.l: Update.
7079
7080 2019-04-04  Tom Tromey  <tom@tromey.com>
7081
7082         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7083         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7084         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7085         * parser-defs.h (paren_depth): Don't declare.
7086         * parse.c (paren_depth): Remove global.
7087         (parse_exp_in_context): Update.
7088         * p-exp.y (paren_depth): New global.
7089         (pascal_parse): Initialize it.
7090         * m2-exp.y (paren_depth): New global.
7091         (m2_parse): Initialize it.
7092         * go-exp.y (paren_depth): New global.
7093         (go_parse): Initialize it.
7094         * f-exp.y (paren_depth): New global.
7095         (f_parse): Initialize it.
7096         * d-exp.y (paren_depth): New global.
7097         (d_parse): Initialize it.
7098         * c-exp.y (paren_depth): New global.
7099         (c_parse): Initialize it.
7100         * ada-lex.l (paren_depth): New global.
7101         (lexer_init): Initialize it.
7102
7103 2019-04-04  Tom Tromey  <tom@tromey.com>
7104
7105         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7106         (rust_parser::convert_ast_to_type)
7107         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7108         * parser-defs.h (struct parser_state) <parser_state>: Add
7109         parameters.  Initialize new members.
7110         <expression_context_block, expression_context_pc>: New members.
7111         * parse.c (expression_context_block, expression_context_pc):
7112         Remove globals.
7113         (parse_exp_in_context): Update.
7114         * p-exp.y: Update all rules.
7115         (yylex): Update.
7116         * m2-exp.y: Update all rules.
7117         (yylex): Update.
7118         * go-exp.y (yylex): Update.
7119         * f-exp.y (yylex): Update.
7120         * d-exp.y: Update all rules.
7121         (yylex): Update.
7122         * c-exp.y: Update all rules.
7123         (lex_one_token, classify_name, yylex, c_parse): Update.
7124         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7125
7126 2019-04-04  Tom Tromey  <tom@tromey.com>
7127
7128         * gdbarch.h, gdbarch.c: Rebuild.
7129         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7130         * stap-probe.h:
7131         (struct stap_parse_info): Replace "parser_state" with
7132         "expr_builder".
7133         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7134         (parser_state): New class.
7135         * parse.c (expr_builder): Rename.
7136         (expr_builder::release): Rename.
7137         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7138         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7139         (write_exp_elt_longcst, write_exp_elt_floatcst)
7140         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7141         (write_exp_string_vector, write_exp_bitstring)
7142         (write_exp_msymbol, mark_struct_expression)
7143         (write_dollar_variable)
7144         (insert_type_address_space, increase_expout_size): Replace
7145         "parser_state" with "expr_builder".
7146         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7147         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7148         "parser_state" with "expr_builder".
7149
7150 2019-04-04  Tom Tromey  <tom@tromey.com>
7151
7152         * rust-exp.y: Replace "parse_language" with method call.
7153         * p-exp.y:
7154         (yylex): Replace "parse_language" with method call.
7155         * m2-exp.y:
7156         (yylex): Replace "parse_language" with method call.
7157         * go-exp.y (classify_name): Replace "parse_language" with method
7158         call.
7159         * f-exp.y (yylex): Replace "parse_language" with method call.
7160         * d-exp.y (lex_one_token): Replace "parse_language" with method
7161         call.
7162         * c-exp.y:
7163         (lex_one_token, classify_name, yylex): Replace "parse_language"
7164         with method call.
7165         * ada-exp.y (find_primitive_type, type_char)
7166         (type_system_address): Replace "parse_language" with method call.
7167
7168 2019-04-04  Tom Tromey  <tom@tromey.com>
7169
7170         * rust-exp.y: Replace "parse_gdbarch" with method call.
7171         * parse.c (write_dollar_variable, insert_type_address_space):
7172         Replace "parse_gdbarch" with method call.
7173         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7174         call.
7175         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7176         call.
7177         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7178         "parse_gdbarch" with method call.
7179         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7180         with method call.
7181         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7182         "parse_gdbarch" with method call.
7183         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7184         "parse_gdbarch" with method call.
7185         * c-exp.y (parse_type, parse_number, classify_name): Replace
7186         "parse_gdbarch" with method call.
7187         * ada-lex.l: Replace "parse_gdbarch" with method call.
7188         * ada-exp.y (parse_type, find_primitive_type, type_char)
7189         (type_system_address): Replace "parse_gdbarch" with method call.
7190
7191 2019-04-04  Tom Tromey  <tom@tromey.com>
7192
7193         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7194         * stap-probe.c (stap_parse_argument): Update.
7195         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7196         initial_size parameter.
7197         * rust-exp.y (rust_lex_tests): Update.
7198         * parse.c (parser_state): Update.
7199         (parse_exp_in_context): Update.
7200         * parser-defs.h (struct parser_state) <parser_state>: Remove
7201         "initial_size" parameter.
7202
7203 2019-04-04  Tom Tromey  <tom@tromey.com>
7204
7205         * parser-defs.h (increase_expout_size): Don't declare.
7206         * parse.c (increase_expout_size): Now static.
7207
7208 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7209
7210         * gnu-nat.c (gnu_nat_target::wait): Fix
7211         target_waitstatus_to_string call.
7212
7213 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7214
7215         * eval.c (evaluate_subexp_standard): Handle internal functions
7216         during Fortran function call handling.
7217
7218 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7219
7220         * NEWS: Mention new internal functions.
7221         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7222         (read_base_type): Use dwarf2_init_complex_target_type.
7223         * value.c (creal_internal_fn): New function.
7224         (cimag_internal_fn): New function.
7225         (_initialize_values): Register new internal functions.
7226
7227 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7228
7229         * infrun.c (stop_all_threads): If debug_infrun, always
7230         trace the wait status after wait_one, using
7231         target_waitstatus_to_string and target_pid_to_str.
7232         (handle_inferior_event): Replace various trace of
7233         wait status kind by a single trace.
7234         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7235         wait status kind image by target_waitstatus_to_string.
7236         * target/waitstatus.c (target_waitstatus_to_string): Fix
7237         obsolete comment.
7238
7239 2019-04-01  Tom Tromey  <tromey@adacore.com>
7240
7241         PR symtab/23331:
7242         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7243
7244 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7245             Pedro Alves  <palves@redhat.com>
7246
7247         * top.c (quit_force): Call 'finalize_values'.
7248         * value.c (finalize_values): New function.
7249         * value.h (finalize_values): Declare.
7250
7251 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7252
7253         * NEWS: Announce $_gdb_major and $_gdb_minor.
7254
7255         * top.c (init_gdb_version_vars): New function.
7256         (gdb_init): Call init_gdb_version_vars.
7257
7258 2019-03-29  Tom Tromey  <tromey@adacore.com>
7259
7260         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7261         help text.  Remove dead code.
7262
7263 2019-03-29  Keith Seitz  <keiths@redhat.com>
7264
7265         From Siddhesh Poyarekar:
7266         * f-lang.h (f77_get_upperbound): Return LONGEST.
7267         (f77_get_lowerbound): Likewise.
7268         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7269         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7270         print them.
7271         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7272         plongest to format print it.
7273         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7274         (f77_get_upperbound): Likewise.
7275         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7276         LOWER_BOUND to LONGEST.
7277         (f77_create_arrayprint_offset_tbl): Likewise.
7278
7279 2019-03-29  Keith Seitz  <keiths@redhat.com>
7280
7281         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7282         %s/pulongest for TYPE_LENGTH instead of %d in format
7283         strings.
7284         * ada-typerint.c (ada_print_type): Likewise.
7285         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7286         * compile/compile-c-support.c (generate_register_struct): Likewise.
7287         * gdbtypes.c (recursive_dump_type): Likewise.
7288         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7289         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7290         instead of %d in format strings.
7291         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7292         to std::min to ULONGEST.
7293         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7294         instead of %d in format strings.
7295         * tracepoint.c (info_scope_command): Likewise.
7296         * typeprint.c (print_offset_data::update)
7297         (print_offset_data::finish): Likewise.
7298         * xtensa-tdep.c (xtensa_store_return_value)
7299         (xtensa_push_dummy_call): Likewise.
7300
7301 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7302
7303         * windows-nat.c (display_selector): Fixed format specifications
7304         for 64-bit Cygwin.
7305
7306 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7307
7308         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7309
7310 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7311
7312         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7313         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7314         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7315         (nios2_linux_init_abi): Install it.
7316
7317 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7318
7319         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7320
7321 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7322
7323         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7324
7325 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7326             Tom Tromey  <tromey@adacore.com>
7327
7328         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7329
7330 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7331
7332         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7333         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7334         method to compute the bounds of range types. Also print "[evaluated]"
7335         if the bounds' values come from a dynamic evaluation.
7336
7337 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7338
7339         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7340         whitespace when pretty printing is on.
7341
7342 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7343
7344         * ppc-linux-nat.c: Add include.
7345
7346 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7347
7348         * NEWS: Mention AArch64 Pointer Authentication.
7349
7350 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7351
7352         * arm-linux-nat.c: Add include.
7353
7354 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7355
7356         * source-cache.c (source_cache::get_source_lines): Re-read
7357         fullname after calling open_source_file.
7358
7359 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7360
7361         * NEWS: Mention TLS support for FreeBSD.
7362
7363 2019-03-25  Tom Tromey  <tromey@adacore.com>
7364
7365         * minsyms.c (BUNCH_SIZE): Update comment.
7366         (~minimal_symbol_reader): Remove old comment.
7367         (compact_minimal_symbols): Update comment.
7368         (minimal_symbol_reader::install): Remove old comment.  Update
7369         other comments.
7370
7371 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7372
7373         * s390-linux-nat.c: Add include.
7374
7375 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7376
7377         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7378         Call linux_get_hwcap.
7379         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7380         Likewise.
7381         (aarch64_linux_get_hwcap): Remove function.
7382         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7383         declaration.
7384         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7385         linux_get_hwcap.
7386         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7387         * linux-tdep.c (linux_get_hwcap): Add function.
7388         (linux_get_hwcap2): Likewise.
7389         * linux-tdep.h (linux_get_hwcap): Add declaration.
7390         (linux_get_hwcap2): Likewise.
7391         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7392         (ppc_linux_get_hwcap2): Likewise.
7393         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7394         linux_get_hwcap.
7395         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7396         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7397         (ppc_linux_nat_target::read_description): Likewise.
7398         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7399         * s390-linux-nat.c: Likewise.
7400         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7401
7402 2019-03-24  Tom Tromey  <tom@tromey.com>
7403
7404         * ada-lang.c (standard_lookup): Simplify initialization.
7405         (ada_lookup_symbol_nonlocal): Simplify return.
7406         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7407         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7408         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7409         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7410         initialization.
7411         * solib.c (solib_global_lookup): Simplify.
7412         * symtab.c (null_block_symbol): Remove.
7413         (symbol_cache_lookup): Simplify returns.
7414         (lookup_language_this): Simplify returns.
7415         (lookup_symbol_aux): Simplify return.
7416         (lookup_local_symbol): Simplify returns.
7417         (lookup_global_symbol_from_objfile): Simplify return.
7418         (lookup_symbol_in_objfile_symtabs)
7419         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7420         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7421         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7422         * cp-namespace.c (cp_lookup_bare_symbol)
7423         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7424         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7425         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7426         (cp_lookup_symbol_via_imports): Simplify initialization.
7427         (find_symbol_in_baseclass): Likewise.
7428         * symtab.h (null_block_symbol): Remove.
7429         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7430         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7431         (d_lookup_symbol_module): Likewise.
7432         (find_symbol_in_baseclass): Simplify initialization.
7433
7434 2019-03-24  Tom Tromey  <tom@tromey.com>
7435
7436         * expression.h: Don't include symtab.h.
7437         (struct block): Forward declare.
7438
7439 2019-03-24  Tom Tromey  <tom@tromey.com>
7440
7441         * c-exp.y (typebase): Remove casts.
7442         * gdbtypes.c (lookup_unsigned_typename, )
7443         (lookup_signed_typename): Remove cast.
7444         * eval.c (parse_to_comma_and_eval): Remove cast.
7445         * parse.c (write_dollar_variable): Remove cast.
7446         * block.h (struct block) <superblock>: Now const.
7447         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7448         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7449         (map_block): Make "block" const.
7450         * symfile.h (struct quick_symbol_functions)
7451         <map_matching_symbols>: Constify block argument to "callback".
7452         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7453         const.
7454         (find_pc_sect_compunit_symtab): Make "b" const.
7455         (find_symbol_at_address): Likewise.
7456         (search_symbols): Likewise.
7457         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7458         (dw2_debug_names_lookup_symbol): Likewise.
7459         (dw2_map_matching_symbols): Update.
7460         * p-valprint.c (pascal_val_print): Remove "block".
7461         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7462         (aux_add_nonlocal_symbols): Make "block" const.
7463         (resolve_subexp): Remove cast.
7464         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7465         const.
7466         (iterate_over_file_blocks): Likewise.
7467         * f-exp.y (%union) <bval>: Remove.
7468         * coffread.c (patch_opaque_types): Make "b" const.
7469         * spu-tdep.c (spu_catch_start): Make "block" const.
7470         * c-valprint.c (print_unpacked_pointer): Remove "block".
7471         * symmisc.c (dump_symtab_1): Make "b" const.
7472         (block_depth): Make "block" const.
7473         * d-exp.y (%union) <bval>: Remove.
7474         * cp-support.h (cp_lookup_rtti_type): Update.
7475         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7476         * psymtab.c (psym_lookup_symbol): Make "block" const.
7477         (maintenance_check_psymtabs): Make "b" const.
7478         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7479         (enumerate_locals, enumerate_args): Update.
7480         * python/py-symtab.c (stpy_global_block): Make "block" const.
7481         (stpy_static_block): Likewise.
7482         * inline-frame.c (block_starting_point_at): Make "new_block"
7483         const.
7484         * block.c (find_block_in_blockvector): Make return type const.
7485         (blockvector_for_pc_sect): Make "b" const.
7486         (find_block_in_blockvector): Make "b" const.
7487
7488 2019-03-23  Tom Tromey  <tom@tromey.com>
7489
7490         * varobj.c (varobj_create): Update.
7491         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7492         * printcmd.c (display_command, do_one_display): Don't reset
7493         innermost_block.
7494         * parser-defs.h (enum innermost_block_tracker_type): Move to
7495         expression.h.
7496         (innermost_block): Update comment.
7497         * parse.c (parse_exp_1): Add tracker_types parameter.
7498         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7499         tracker_types parameter.  Reset innermost_block.
7500         (parse_exp_in_context): Remove.
7501         (parse_expression_for_completion): Update.
7502         * objfiles.c (~objfile): Don't reset expression_context_block or
7503         innermost_block.
7504         * expression.h (enum innermost_block_tracker_type): Move from
7505         parser-defs.h.
7506         (parse_exp_1): Add tracker_types parameter.
7507         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7508         reset innermost_block.
7509
7510 2019-03-23  Tom Tromey  <tom@tromey.com>
7511
7512         * objfiles.h: Include bcache.h.
7513
7514 2019-03-23  Tom Tromey  <tom@tromey.com>
7515
7516         * linespec.c (get_current_search_block): Use
7517         scoped_restore_current_language.
7518         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7519
7520 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7521             Jiong Wang  <jiong.wang@arm.com>
7522
7523         * aarch64-linux-tdep.c
7524         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7525         section.
7526         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7527
7528 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7529             Jiong Wang  <jiong.wang@arm.com>
7530
7531         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7532         instructions.
7533         (aarch64_analyze_prologue_test): Add PACIASP test.
7534         (aarch64_prologue_prev_register): Unmask PC value.
7535
7536 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7537             Jiong Wang  <jiong.wang@arm.com>
7538
7539         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7540         (aarch64_dwarf2_prev_register): Unmask PC value.
7541         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7542         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7543         DW_CFA_AARCH64_negate_ra_state.
7544         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7545
7546 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7547             Jiong Wang  <jiong.wang@arm.com>
7548
7549         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7550         registers.
7551         (aarch64_pseudo_register_name): Likewise.
7552         (aarch64_pseudo_register_type): Likewise.
7553         (aarch64_pseudo_register_reggroup_p): Likewise.
7554         (aarch64_gdbarch_init): Add pauth registers.
7555         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7556         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7557         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7558         (struct gdbarch_tdep): Add regnum for ra_state.
7559
7560 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7561             Jiong Wang  <jiong.wang@arm.com>
7562
7563         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7564
7565 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7566             Jiong Wang  <jiong.wang@arm.com>
7567
7568         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7569         function.
7570         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7571         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7572         (aarch64_gdbarch_init): Add puth registers.
7573         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7574         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7575         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7576
7577 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7578             Jiong Wang  <jiong.wang@arm.com>
7579
7580         * aarch64-linux-nat.c
7581         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7582         * aarch64-linux-tdep.c
7583         (aarch64_linux_core_read_description): Likewise.
7584         (aarch64_linux_get_hwcap): New function.
7585         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7586         (aarch64_linux_get_hwcap): New declaration.
7587
7588 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7589             Jiong Wang  <jiong.wang@arm.com>
7590
7591         * aarch64-linux-nat.c
7592         (aarch64_linux_nat_target::read_description): Add pauth param.
7593         * aarch64-linux-tdep.c
7594         (aarch64_linux_core_read_description): Likewise.
7595         * aarch64-tdep.c (struct target_desc): Add in pauth.
7596         (aarch64_read_description): Add pauth param.
7597         (aarch64_gdbarch_init): Likewise.
7598         * aarch64-tdep.h (aarch64_read_description): Likewise.
7599         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7600         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7601         * features/Makefile: Add new files.
7602         * features/aarch64-pauth.c: New file.
7603         * features/aarch64-pauth.xml: New file.
7604
7605 2019-03-20  Tom Tromey  <tromey@adacore.com>
7606
7607         * infrun.c (handle_inferior_event): Rename from
7608         handle_inferior_event_1.  Create a scoped_value_mark.
7609         (handle_inferior_event): Remove.
7610
7611 2019-03-19  Tom Tromey  <tromey@adacore.com>
7612
7613         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7614         * infrun.h (print_stop_event): Add "displays" parameter.
7615         * infrun.c (print_stop_event): Add "displays" parameter.
7616
7617 2019-03-19  Pedro Alves  <palves@redhat.com>
7618
7619         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7620         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7621         to -1.  Fix TABs vs spaces.
7622         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7623         * tui/tui-out.h (tui_ui_out) Add intro comments.
7624         <m_line, m_start_of_line>: In-class initialize, and add describing
7625         comment.
7626
7627 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7628
7629         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7630         variable names.
7631         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7632
7633 2019-03-18  Pedro Alves  <palves@redhat.com>
7634             Eli Zaretskii <eliz@gnu.org>
7635
7636         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7637         m_line and m_start_of_line.
7638
7639 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7640
7641         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7642         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7643         it returns a newline.  This fixes a regression in TU mode, whereby
7644         the next line is output on the same screen line as the user input.
7645
7646 2019-03-18  Tom Tromey  <tromey@adacore.com>
7647
7648         * minsyms.c (minimal_symbol_reader::install): Remove call to
7649         obstack_blank.
7650
7651 2019-03-18  Pedro Alves  <palves@redhat.com>
7652
7653         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7654         New globals.
7655         (apply_style): New, factored out from ...
7656         (apply_ansi_escape): ... this.  Handle reverse video mode.
7657         (tui_set_reverse_mode): New function.
7658         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7659         * tui/tui-winsource.c (tui_show_source_line): Use
7660         tui_set_reverse_mode instead of setting A_STANDOUT.
7661         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7662         New setter methods.
7663
7664 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7665
7666         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7667         Handle tabs.
7668
7669 2019-03-18  Tom Tromey  <tromey@adacore.com>
7670
7671         * ada-lang.c (empty_array): Add "high" parameter.
7672         (ada_evaluate_subexp): Update.
7673
7674 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7675
7676         * unittests/string_view-selftests.c: Define
7677         _initialize_string_view_selftests unconditionally.
7678
7679 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7680
7681         PR gdb/24350
7682         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7683
7684 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7685
7686         PR gdb/24351
7687         * windows-nat.c (display_selector): Fix format specifiers.
7688
7689 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7690
7691         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7692         tui_refill_source_window instead of tui_refresh_win, to update the
7693         current execution line.  This fixes redisplay of the current line
7694         when stepping through the code with "next" or "step".
7695
7696 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7697
7698         * source-cache.c (source_cache::get_source_lines): Call
7699         find_source_lines to initialize s->nlines.  This fixes vertical
7700         scrolling of TUI source window when the DOWN arrow is pressed.
7701
7702 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7703
7704         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7705         linux-thread-db.c (_initialize_thread_db): Likewise.
7706
7707 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7708
7709         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7710         wclrtoeol in tui_show_source_line".  This reverts changes made in
7711         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7712
7713 2019-03-15  Tom Tromey  <tom@tromey.com>
7714
7715         * symtab.h (struct minimal_symbol): Derive from
7716         general_symbol_info.
7717         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7718         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7719         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7720         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7721         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7722         (MSYMBOL_SEARCH_NAME): Update.
7723         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7724         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7725         * minsyms.c (minimal_symbol_reader::record_full): Update.
7726
7727 2019-03-15  Tom Tromey  <tom@tromey.com>
7728
7729         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7730
7731 2019-03-15  Tom Tromey  <tom@tromey.com>
7732
7733         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7734         unique_xmalloc_ptr.
7735         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7736         Update.
7737         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7738         (build_minimal_symbol_hash_tables)
7739         (minimal_symbol_reader::install): Update.
7740
7741 2019-03-15  Tom Tromey  <tom@tromey.com>
7742
7743         * symtab.c (create_demangled_names_hash): Update.
7744         (symbol_set_names): Update.
7745         * objfiles.h (struct objfile_per_bfd_storage)
7746         <demangled_names_hash>: Now an htab_up.
7747         * objfiles.c (objfile_per_bfd_storage): Simplify.
7748
7749 2019-03-15  Tom Tromey  <tom@tromey.com>
7750
7751         * objfiles.h (struct objfile_per_bfd_storage): Declare
7752         destructor.
7753         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7754         New.
7755         (get_objfile_bfd_data): Use new.  Don't initialize
7756         language_of_main.
7757         (free_objfile_per_bfd_storage): Remove.
7758         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7759
7760 2019-03-15  Tom Tromey  <tom@tromey.com>
7761
7762         * symfile.c (reread_symbols): Update.
7763         * objfiles.c (objfile::objfile): Update.
7764         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7765         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7766         comment.
7767         (minimal_symbol_reader::install): Update.
7768         (terminate_minimal_symbol_table): Remove.
7769         * jit.c (jit_object_close_impl): Update.
7770
7771 2019-03-15  Tom Tromey  <tom@tromey.com>
7772
7773         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7774         initializations.
7775
7776 2019-03-15  Tom Tromey  <tom@tromey.com>
7777
7778         * objfiles.h (struct objfile_per_bfd_storage)
7779         <demangled_hash_languages>: Now a bitset.
7780         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7781         (lookup_minimal_symbol): Update.
7782
7783 2019-03-15  Tom Tromey  <tom@tromey.com>
7784
7785         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7786         Don't return the symbol.
7787         * coffread.c (record_minimal_symbol): Use record_full.
7788
7789 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7790
7791         The MS-Windows port of ncurses fails to switch to a color pair if
7792         one or both of the colors are the implicit default colors.  This
7793         change records the default colors when TUI is initialized, and
7794         then specifies them explicitly when a color pair uses the default
7795         colors.  This allows color styling in TUI mode on MS-Windows.
7796
7797         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7798         ncurses_norm_attr.
7799         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7800         colors in ncurses_norm_attr.
7801         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7802         "none", replace it with the default color recorded in
7803         ncurses_norm_attr.
7804
7805 2019-03-14  Tom Tromey  <tromey@adacore.com>
7806
7807         * source-cache.h (class source_cache) <get_source_lines>: Return
7808         std::string.
7809         * source-cache.c (source_cache::extract_lines): Handle case where
7810         first_pos==npos.  Return std::string.
7811         (source_cache::get_source_lines): Update.
7812
7813 2019-03-14  Tom Tromey  <tromey@adacore.com>
7814
7815         * NEWS: Add item for "style sources" commands.
7816         * source-cache.c (source_cache::get_source_lines): Check
7817         source_styling.
7818         * cli/cli-style.c (source_styling): New global.
7819         (_initialize_cli_style): Add "style sources" commands.
7820         (show_style_sources): New function.
7821         * cli/cli-style.h (source_styling): Declare.
7822
7823 2019-03-14  Pedro Alves  <palves@redhat.com>
7824             Tom Tromey  <tromey@adacore.com>
7825
7826         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7827         * tui/tui-winsource.c (tui_refill_source_window): New function,
7828         from...
7829         (tui_horizontal_source_scroll): ... here.  Move some logic.
7830         * cli/cli-style.c (set_style_enabled): Notify new observable.
7831         * tui/tui-hooks.c (tui_redisplay_source): New function.
7832         (tui_attach_detach_observers): Attach or detach
7833         tui_redisplay_source.
7834         * observable.h (source_styling_changed): New observable.
7835         * observable.c: Define source_styling_changed observable.
7836
7837 2019-03-13  Tom Tromey  <tromey@adacore.com>
7838
7839         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7840         (i386_gnu_nat_target::store_registers): Update.
7841         * target-debug.h (target_debug_print_std_string): New macro.
7842         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7843         * windows-tdep.c (display_one_tib): Update.
7844         * tui/tui-stack.c (tui_make_status_line): Update.
7845         * top.c (print_inferior_quit_action): Update.
7846         * thread.c (thr_try_catch_cmd): Update.
7847         (add_thread_with_info): Update.
7848         (thread_target_id_str): Update.
7849         (thr_try_catch_cmd): Update.
7850         (thread_command): Update.
7851         (thread_find_command): Update.
7852         * record-btrace.c (record_btrace_target::info_record)
7853         (record_btrace_resume_thread, record_btrace_target::resume)
7854         (record_btrace_cancel_resume, record_btrace_step_thread)
7855         (record_btrace_target::wait, record_btrace_target::wait)
7856         (record_btrace_target::wait, record_btrace_target::stop): Update.
7857         * progspace.c (print_program_space): Update.
7858         * process-stratum-target.c
7859         (process_stratum_target::thread_address_space): Update.
7860         * linux-fork.c (linux_fork_mourn_inferior)
7861         (detach_checkpoint_command, info_checkpoints_command)
7862         (linux_fork_context): Update.
7863         (linux_fork_detach): Update.
7864         (class scoped_switch_fork_info): Update.
7865         (delete_checkpoint_command): Update.
7866         * infrun.c (follow_fork_inferior): Update.
7867         (follow_fork_inferior): Update.
7868         (proceed_after_vfork_done): Update.
7869         (handle_vfork_child_exec_or_exit): Update.
7870         (follow_exec): Update.
7871         (displaced_step_prepare_throw): Update.
7872         (displaced_step_restore): Update.
7873         (start_step_over): Update.
7874         (resume_1): Update.
7875         (clear_proceed_status_thread): Update.
7876         (proceed): Update.
7877         (print_target_wait_results): Update.
7878         (do_target_wait): Update.
7879         (context_switch): Update.
7880         (stop_all_threads): Update.
7881         (restart_threads): Update.
7882         (finish_step_over): Update.
7883         (handle_signal_stop): Update.
7884         (switch_back_to_stepped_thread): Update.
7885         (keep_going_pass_signal): Update.
7886         (print_exited_reason): Update.
7887         (normal_stop): Update.
7888         * inferior.c (inferior_pid_to_str): Change return type.
7889         (print_selected_inferior): Update.
7890         (add_inferior): Update.
7891         (detach_inferior): Update.
7892         * dummy-frame.c (fprint_dummy_frames): Update.
7893         * dcache.c (dcache_info_1): Update.
7894         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7895         (btrace_fetch, btrace_clear): Update.
7896         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7897         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7898         type.
7899         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7900         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7901         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7902         * gdbarch.c, gdbarch.h: Rebuild.
7903         * gdbarch.sh (core_pid_to_str): Change return type.
7904         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7905         return type.
7906         (windows_nat_target::pid_to_str): Change return type.
7907         (windows_delete_thread): Update.
7908         (windows_nat_target::attach): Update.
7909         (windows_nat_target::files_info): Update.
7910         * target-delegates.c: Rebuild.
7911         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7912         return type.
7913         (sol_thread_target::pid_to_str): Change return type.
7914         * remote.c (class remote_target) <pid_to_str>: Change return
7915         type.
7916         (remote_target::pid_to_str): Change return type.
7917         (extended_remote_target::attach, remote_target::remote_stop_ns)
7918         (remote_target::remote_notif_remove_queued_reply)
7919         (remote_target::push_stop_reply, remote_target::disable_btrace):
7920         Update.
7921         (extended_remote_target::attach): Update.
7922         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7923         type.
7924         (gdbsim_target::pid_to_str): Change return type.
7925         * ravenscar-thread.c (struct ravenscar_thread_target)
7926         <pid_to_str>: Change return type.
7927         (ravenscar_thread_target::pid_to_str): Change return type.
7928         * procfs.c (class procfs_target) <pid_to_str>: Change return
7929         type.
7930         (procfs_target::pid_to_str): Change return type.
7931         (procfs_target::attach): Update.
7932         (procfs_target::detach): Update.
7933         (procfs_target::fetch_registers): Update.
7934         (procfs_target::store_registers): Update.
7935         (procfs_target::wait): Update.
7936         (procfs_target::files_info): Update.
7937         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7938         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7939         return type.
7940         (nto_procfs_target::pid_to_str): Change return type.
7941         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7942         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7943         return type.
7944         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7945         (exit_lwp): Update.
7946         (attach_proc_task_lwp_callback, get_detach_signal)
7947         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7948         (linux_nat_target::resume, wait_lwp, stop_callback)
7949         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7950         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7951         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7952         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7953         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7954         type.
7955         (inf_ptrace_target::attach): Update.
7956         (inf_ptrace_target::files_info): Update.
7957         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7958         type.
7959         (go32_nat_target::pid_to_str): Change return type.
7960         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7961         (gnu_nat_target::wait): Update.
7962         (gnu_nat_target::wait): Update.
7963         (gnu_nat_target::resume): Update.
7964         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7965         (fbsd_nat_target::wait): Update.
7966         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7967         type.
7968         (darwin_nat_target::attach): Update.
7969         * corelow.c (class core_target) <pid_to_str>: Change return type.
7970         (core_target::pid_to_str): Change return type.
7971         * target.c (normal_pid_to_str): Change return type.
7972         (default_pid_to_str): Likewise.
7973         (target_pid_to_str): Change return type.
7974         (target_translate_tls_address): Update.
7975         (target_announce_detach): Update.
7976         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7977         return type.
7978         (bsd_uthread_target::pid_to_str): Change return type.
7979         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7980         type.
7981         (bsd_kvm_target::pid_to_str): Change return type.
7982         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7983         return type.
7984         (aix_thread_target::pid_to_str): Change return type.
7985         * target.h (struct target_ops) <pid_to_str>: Change return type.
7986         (target_pid_to_str, normal_pid_to_str): Likewise.
7987         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7988         type.
7989         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7990         type.
7991         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7992         return type.
7993         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7994         type.
7995         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7996         type.
7997         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7998         return type.
7999
8000 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8001
8002         * NEWS: Mention that the new default MI version is 3.  Mention
8003         changes to the output of commands and events that deal with
8004         multi-location breakpoints.
8005         * breakpoint.c: Include "mi/mi-out.h".
8006         (print_one_breakpoint): Change output syntax if using MI version
8007         >= 3.
8008         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8009         New.
8010         (mi_multi_location_breakpoint_output_fixed): New.
8011         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8012         (mi_cmd_fix_multi_location_breakpoint_output): New.
8013         (mi_multi_location_breakpoint_output_fixed): New.
8014         * mi/mi-cmds.c (mi_cmds): Register command
8015         -fix-multi-location-breakpoint-output.
8016         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8017         interpreter "mi".
8018
8019 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8020
8021         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8022         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8023         instantiate mi_ui_out based on interpreter name.
8024         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8025         * mi/mi-main.c (mi_load_progress): Likewise.
8026
8027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8028
8029         * NEWS: Combine separate "New targets" sections for 8.3.
8030
8031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8032
8033         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8034         (ppcfbsd_init_abi): Install gdbarch
8035         "fetch_tls_load_module_address" and "get_thread_local_address"
8036         methods.
8037
8038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8039
8040         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8041         (riscv_fbsd_init_abi): Install gdbarch
8042         "fetch_tls_load_module_address" and "get_thread_local_address"
8043         methods.
8044
8045 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8046
8047         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8048         (i386fbsd_init_abi): Install gdbarch
8049         "fetch_tls_load_module_address" and "get_thread_local_address"
8050         methods.
8051
8052 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8053
8054         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8055         (amd64fbsd_init_abi): Install gdbarch
8056         "fetch_tls_load_module_address" and "get_thread_local_address"
8057         methods.
8058
8059 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8060
8061         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8062         (struct fbsd_pspace_data): New type.
8063         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8064         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8065         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8066         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8067         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8068
8069 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8070
8071         * gdbtypes.c (lookup_struct_elt): New function.
8072         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8073         * gdbtypes.h (struct struct_elt): New type.
8074         (lookup_struct_elt): New prototype.
8075
8076 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8077
8078         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8079         remove disabled code block.
8080
8081 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8082
8083         * gdbarch.sh (get_thread_local_address): New method.
8084         * gdbarch.h, gdbarch.c: Regenerate.
8085         * target.c (target_translate_tls_address): Use
8086         gdbarch_get_thread_local_address if present instead of
8087         target::get_thread_local_address.
8088
8089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8090
8091         * target.h (target::get_thread_local_address): Update comment.
8092
8093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8094
8095         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8096         objfile->separate_debug_objfile_backlink if not NULL.
8097
8098 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8099
8100         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8101         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8102         (amd64bsd_store_inferior_registers): Likewise.
8103         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8104         Enable segment base registers.
8105         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8106         PT_GETFSBASE and PT_GETGSBASE.
8107         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8108         PT_SETGSBASE.
8109         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8110         segment base registers.
8111         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8112
8113 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8114
8115         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8116         Update calls to i386_target_description to add 'segments'
8117         parameter.
8118         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8119         add segment base registers.
8120         * arch/i386.c (i386_create_target_description): Add 'segments'
8121         parameter to enable segment base registers.
8122         * arch/i386.h (i386_create_target_description): Likewise.
8123         * features/i386/32bit-segments.xml: New file.
8124         * features/i386/32bit-segments.c: Generate.
8125         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8126         call to i386_target_description to add 'segments' parameter.
8127         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8128         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8129         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8130         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8131         if feature is present.
8132         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8133         Add 'segments' parameter to call to i386_target_description.
8134         (i386_target_description): Add 'segments' parameter to enable
8135         segment base registers.
8136         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8137         to call to i386_target_description.
8138         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8139         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8140         Define I386_NUM_REGS.
8141         (i386_target_description): Add 'segments' parameter to enable
8142         segment base registers.
8143
8144 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8145
8146         PR/24325
8147         * source-cache.c: #undef open and close, to avoid unresolved
8148         externals during linking.
8149
8150 2019-03-12  Tom Tromey  <tromey@adacore.com>
8151
8152         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8153         const.  Add initializers.
8154         (_initialize_remote): Don't initialize ptid globals.
8155
8156 2019-03-12  Pedro Alves  <palves@redhat.com>
8157
8158         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8159
8160 2019-03-12  Pedro Alves  <palves@redhat.com>
8161
8162         * cp-name-parser.y (main): Remove unused 'len' variable.
8163
8164 2019-03-12  Tom Tromey  <tromey@adacore.com>
8165
8166         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8167         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8168
8169 2019-03-12  Tom Tromey  <tromey@adacore.com>
8170
8171         * linux-nat.c (iterate_over_lwps): Update.
8172         (stop_callback): Remove parameter.
8173         (stop_wait_callback, detach_callback, resume_set_callback)
8174         (select_singlestep_lwp_callback, set_ignore_sigint)
8175         (status_callback, resumed_callback, resume_clear_callback)
8176         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8177         data parameter.
8178         (linux_nat_target::detach, linux_nat_target::resume)
8179         (linux_stop_and_wait_all_lwps, select_event_lwp)
8180         (linux_nat_filter_event, linux_nat_wait_1)
8181         (linux_nat_target::kill, linux_nat_target::stop)
8182         (linux_nat_target::stop): Update.
8183         (linux_nat_resume_callback): Change type.
8184         (resume_stopped_resumed_lwps, count_events_callback)
8185         (select_event_lwp_callback): Likewise.
8186         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8187         * arm-linux-nat.c (struct update_registers_data): Remove.
8188         (update_registers_callback): Change type.
8189         (arm_linux_insert_hw_breakpoint1): Update.
8190         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8191         parameter.
8192         (x86_linux_dr_set_addr): Update.
8193         (x86_linux_dr_set_control): Update.
8194         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8195         (iterate_over_lwps): Use gdb::function_view.
8196         * nat/aarch64-linux-hw-point.c (struct
8197         aarch64_dr_update_callback_param): Remove.
8198         (debug_reg_change_callback): Change type.
8199         (aarch64_notify_debug_reg_change): Update.
8200         * s390-linux-nat.c (s390_refresh_per_info): Update.
8201
8202 2019-03-11  Tom Tromey  <tromey@adacore.com>
8203
8204         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8205         redundant assignment to "this_cu".
8206
8207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8208
8209         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8210
8211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8212
8213         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8214         from...
8215         (rank_one_type): ... this.
8216
8217 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8218
8219         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8220         from...
8221         (rank_one_type): ... this.
8222
8223 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8224
8225         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8226         from...
8227         (rank_one_type): ... this.
8228
8229 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8230
8231         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8232         from...
8233         (rank_one_type): ... this.
8234
8235 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8236
8237         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8238         from...
8239         (rank_one_type): ... this.
8240
8241 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8242
8243         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8244         from...
8245         (rank_one_type): ... this.
8246
8247 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8248
8249         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8250         from...
8251         (rank_one_type): ... this.
8252
8253 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8254
8255         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8256         from...
8257         (rank_one_type): ... this.
8258
8259 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8260
8261         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8262         from...
8263         (rank_one_type): ... this.
8264
8265 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8266
8267         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8268         from...
8269         (rank_one_type): ... this.
8270
8271 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8272
8273         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8274         from...
8275         (rank_one_type): ... this.
8276
8277 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8278
8279         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8280         from...
8281         (rank_one_type): ... this.
8282
8283 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8284
8285         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8286         inferior-events' shows the example events.
8287
8288 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8289
8290         Support styling on native MS-Windows console
8291
8292         PR/24315
8293         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8294         on MS-Windows if $TERM is not defined.
8295
8296         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8297
8298         * posix-hdep.c (gdb_console_fputs):
8299         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8300         functions.
8301         * ui-file.h (gdb_console_fputs): Add prototype.
8302
8303         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8304         back to fputs only if the former returns zero.
8305
8306 2019-03-07  Tom Tromey  <tom@tromey.com>
8307
8308         * symmisc.c (print_symbol_bcache_statistics): Update.
8309         (print_objfile_statistics): Update.
8310         * symfile.c (allocate_symtab): Update.
8311         * stabsread.c: Don't include bcache.h.
8312         * psymtab.h (struct psymbol_bcache): Don't declare.
8313         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8314         (psymbol_bcache_init, psymbol_bcache_free)
8315         (psymbol_bcache_get_bcache): Don't declare.
8316         * psymtab.c (struct psymbol_bcache): Remove.
8317         (psymtab_storage::psymtab_storage): Update.
8318         (psymtab_storage::~psymtab_storage): Update.
8319         (psymbol_bcache_init, psymbol_bcache_free)
8320         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8321         (add_psymbol_to_bcache): Update.
8322         (allocate_psymtab): Update.
8323         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8324         macro_cache>: No longer pointers.
8325         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8326         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8327         * macrotab.c (macro_bcache): Update.
8328         * macroexp.c: Don't include bcache.h.
8329         * gdbtypes.c (check_types_worklist): Update.
8330         (types_deeply_equal): Remove TRY/CATCH.  Update.
8331         * elfread.c (elf_symtab_read): Update.
8332         * dwarf2read.c: Don't include bcache.h.
8333         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8334         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8335         (print_bcache_statistics, bcache_memory_used): Don't declare.
8336         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8337         methods.  Rename all data members.
8338         * bcache.c (struct bcache): Move to bcache.h.
8339         (bcache::expand_hash_table): Rename from expand_hash_table.
8340         (bcache): Remove.
8341         (bcache::insert): Rename from bcache_full.
8342         (bcache::compare): Rename from bcache_compare.
8343         (bcache_xmalloc): Remove.
8344         (bcache::~bcache): Rename from bcache_xfree.
8345         (bcache::print_statistics): Rename from print_bcache_statistics.
8346         (bcache::memory_used): Rename from bcache_memory_used.
8347
8348 2019-03-07  Pedro Alves  <palves@redhat.com>
8349
8350         * infrun.c (normal_stop): Also check for
8351         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8352
8353 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8354
8355         * f-lang.c (value_from_host_double): Moved to...
8356         * value.c (value_from_host_double): ...here.
8357         * value.h (value_from_host_double): Declare.
8358         * guile/scm-math.c (vlscm_convert_typed_number): Use
8359         value_from_host_double.
8360         (vlscm_convert_number): Likewise.
8361         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8362         * python/py-value.c (convert_value_from_python): Likewise.
8363
8364 2019-03-06  Tom Tromey  <tom@tromey.com>
8365
8366         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8367
8368 2019-03-06  Tom Tromey  <tom@tromey.com>
8369
8370         * utils.h (free_current_contents): Don't declare.
8371         * utils.c (free_current_contents): Remove.
8372
8373 2019-03-06  Tom Tromey  <tom@tromey.com>
8374
8375         * top.c (quit_force): Update.
8376         * main.c (captured_command_loop): Update.
8377         * common/new-op.c (operator new): Update.
8378         * common/common-exceptions.c (struct catcher)
8379         <save_cleanup_chain>: Remove member.
8380         (exceptions_state_mc_init): Update.
8381         (exception_try_scope_entry): Return nullptr.
8382         (exception_try_scope_exit, exception_rethrow)
8383         (throw_exception_sjlj, throw_exception_cxx): Update.
8384         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8385         (all_cleanups, do_cleanups, discard_cleanups)
8386         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8387         (restore_cleanups, restore_final_cleanups): Don't declare.
8388         (do_final_cleanups): Remove parameter.
8389         * common/cleanups.c (cleanup_chain, make_cleanup)
8390         (make_cleanup_dtor, all_cleanups, do_cleanups)
8391         (discard_my_cleanups, discard_cleanups)
8392         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8393         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8394         (null_cleanup): Remove.
8395         (do_final_cleanups): Remove parameter.
8396
8397 2019-03-06  Tom Tromey  <tom@tromey.com>
8398
8399         * remote.c (remote_target::remote_parse_stop_reply): Use
8400         unique_xmalloc_ptr.
8401
8402 2019-03-06  Tom Tromey  <tom@tromey.com>
8403
8404         * stabsread.c (struct stabs_field_info): Rename from field_info.
8405         <list, fnlist>: Add initializers.
8406         <obstack>: New member.
8407         (read_member_functions, read_struct_fields, read_baseclasses):
8408         Allocate on obstack.  Don't use cleanups.
8409         (read_one_struct_field, read_member_functions, read_struct_fields)
8410         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8411         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8412         (read_struct_type): Update.
8413
8414 2019-03-06  Tom Tromey  <tom@tromey.com>
8415
8416         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8417         * common/filestuff.h (make_cleanup_close): Don't declare.
8418         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8419         Remove.
8420
8421 2019-03-06  Tom Tromey  <tom@tromey.com>
8422
8423         * solib-aix.c: Use make_scope_exit.
8424
8425 2019-03-06  Tom Tromey  <tom@tromey.com>
8426
8427         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8428         Use make_scope_exit.
8429
8430 2019-03-06  Tom Tromey  <tom@tromey.com>
8431
8432         * solib-svr4.c (disable_probes_interface): Remove parameter.
8433         (svr4_handle_solib_event): Use make_scope_exit.
8434
8435 2019-03-06  Tom Tromey  <tom@tromey.com>
8436
8437         * remote.c (struct stop_reply_deleter): Remove.
8438         (stop_reply_up): Update.
8439         (struct stop_reply): Derive from notif_event.  Don't typedef.
8440         <regcache>: Now a std::vector.
8441         (stop_reply_xfree): Remove.
8442         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8443         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8444         (remote_target::discard_pending_stop_replies): Use delete.
8445         (remote_target::remote_parse_stop_reply): Update.
8446         (remote_target::process_stop_reply): Update.
8447         * remote-notif.h (struct notif_event): Add virtual destructor.
8448         Remove "dtr" member.
8449         (struct notif_client) <alloc_event>: Return a unique_ptr.
8450         (notif_event_xfree): Don't declare.
8451         (notif_event_up): New typedef.
8452         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8453         (notif_event_xfree, do_notif_event_xfree): Remove.
8454         (remote_notif_state_xfree): Update.
8455
8456 2019-03-06  Tom Tromey  <tom@tromey.com>
8457
8458         * infrun.c (displaced_step_clear_cleanup): Now a
8459         forward_scope_exit type.
8460         (displaced_step_prepare_throw): Update.
8461         (displaced_step_fixup): Update.
8462
8463 2019-03-06  Tom Tromey  <tom@tromey.com>
8464
8465         * inferior.h (class inferior): Update comment.
8466         * gdbthread.h (class thread_info): Update comment.
8467
8468 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8469             Tom Tromey  <tom@tromey.com>
8470
8471         * stabsread.h (struct stab_section_list): Remove.
8472         (coffstab_build_psymtabs): Update.
8473         * dbxread.c (symbuf_sections): Now a std::vector.
8474         (sect_idx): New global.
8475         (fill_symbuf): Update.
8476         (coffstab_build_psymtabs): Change type of stabsects parameter.
8477         Update.
8478         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8479         std::vector.
8480         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8481         (coff_locate_sections): Update.
8482         (coff_symfile_read): Remove cleanups.  Update.
8483         (init_stringtab): Add storage parameter.
8484         (free_stringtab, free_stringtab_cleanup): Remove.
8485         (init_lineno): Add storage parameter.
8486         (free_linetab, free_linetab_cleanup): Remove.
8487
8488 2019-03-06  Pedro Alves  <palves@redhat.com>
8489
8490         * linux-fork.c (fork_info::clobber_regs): Delete.
8491         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8492         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8493         comment.  Adjust.
8494         (scoped_switch_fork_info::scoped_switch_fork_info)
8495         (checkpoint_command, linux_fork_context): Adjust
8496         fork_save_infrun_state calls.
8497
8498 2019-03-06  Pedro Alves  <palves@redhat.com>
8499
8500         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8501         (inf_has_multiple_threads): Return 'bool' and rewrite using
8502         inferior_info::threads().
8503
8504 2019-03-06  Pedro Alves  <palves@redhat.com>
8505
8506         * linux-fork.c: Include <list>.
8507         (fork_list): Now a std::list instance.
8508         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8509         (forks_exist_p, find_last_fork): Adjust.
8510         (new_fork): Delete.
8511         (one_fork_p): New.
8512         (add_fork): Adjust.
8513         (free_fork): Delete, folded into fork_info::~fork_info().
8514         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8515         Adjust.
8516         (init_fork_list): Delete.
8517         (linux_fork_killall, linux_fork_mourn_inferior)
8518         (linux_fork_detach, info_checkpoints_command): Adjust.
8519         (_initialize_linux_fork): No longer call init_fork_list.
8520
8521 2019-03-06  Pedro Alves  <palves@redhat.com>
8522
8523         * linux-fork.c (new_fork): New, split out of ...
8524         (add_fork): ... this.  Return void.  Move "first fork" special
8525         case from here, to ...
8526         (checkpoint_command): ... here.
8527         * linux-linux.h (add_fork): Return void.
8528
8529 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8530
8531         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8532
8533 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8534             Chris January  <chris.january@arm.com>
8535             David Lecomber  <david.lecomber@arm.com>
8536
8537         * f-exp.y: New token, UNOP_INTRINSIC.
8538         (exp): New pattern using UNOP_INTRINSIC token.
8539         (f77_keywords): Add 'abs' keyword.
8540         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8541         (value_from_host_double): New function.
8542         (evaluate_subexp_f): Support UNOP_ABS.
8543
8544 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8545
8546         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8547         types.
8548
8549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8550
8551         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8552         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8553         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8554
8555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8556
8557         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8558
8559 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8560             Chris January  <chris.january@arm.com>
8561
8562         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8563         * f-exp.y: Define 'KIND' token.
8564         (exp): New pattern for KIND expressions.
8565         (ptype): Handle types with a kind extension.
8566         (direct_abs_decl): Extend to spot kind extensions.
8567         (f77_keywords): Add 'kind' to the list.
8568         (push_kind_type): New function.
8569         (convert_to_kind_type): New function.
8570         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8571         * parse.c (operator_length_standard): Likewise.
8572         * parser-defs.h (enum type_pieces): Add tp_kind.
8573         * std-operator.def: Add UNOP_KIND.
8574
8575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8576
8577         * f-exp.y (f_parse): Set yydebug.
8578
8579 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8580
8581         * f-lang.c (evaluate_subexp_f): New function.
8582         (exp_descriptor_f): New global.
8583         (f_language_defn): Use exp_descriptor_f instead of
8584         exp_descriptor_standard.
8585
8586 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8587
8588         * f-exp.y (struct token): Add comments.
8589         (dot_ops): Remove uppercase versions and the end marker.
8590         (f77_keywords): Likewise.
8591         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8592         entries in the dot_ops array are case insensitive, and use
8593         strncasecmp to compare strings.  Also some whitespace cleanup in
8594         this area.  Similar for the f77_keywords array, except entries in
8595         this list might be case sensitive.
8596
8597 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8598
8599         * f-exp.y (struct f77_boolean_val): Add comments.
8600         (boolean_values): Remove uppercase versions, and end marker.
8601         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8602         and use strncasecmp to achieve case insensitivity.  Additionally,
8603         perform whitespace cleanup around this code.
8604
8605 2019-03-06  Tom Tromey  <tromey@adacore.com>
8606
8607         * remote-sim.c (gdbsim_target_open): Use result of
8608         gdb_argv::release.
8609
8610 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8611         Dirk Schubert  <dirk.schubert@arm.com>
8612         Chris January  <chris.january@arm.com>
8613
8614         * eval.c (evaluate_subexp_standard): Call Fortran argument
8615         wrapping logic.
8616         * f-lang.c (struct value): A value which can be passed into a
8617         Fortran function call.
8618         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8619         where appropriate.
8620         (struct type): Value ready for a Fortran function call.
8621         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8622         is needed.
8623         * f-lang.h (fortran_argument_convert): Declaration.
8624         (fortran_preserve_arg_pointer): Declaration.
8625         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8626
8627 2019-03-05  Tom Tromey  <tromey@adacore.com>
8628
8629         * python/py-prettyprint.c (print_string_repr): Remove #if.
8630         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8631
8632 2019-03-05  Tom Tromey  <tromey@adacore.com>
8633
8634         * target.c (the_dummy_target): Move later.  Change type to
8635         "dummy_target".
8636         (initialize_targets): Don't initialize the_dummy_target.
8637
8638 2019-03-05  Tom Tromey  <tromey@adacore.com>
8639
8640         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8641         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8642
8643 2019-03-05  Tom Tromey  <tromey@adacore.com>
8644
8645         * windows-nat.c (windows_nat_target::attach)
8646         (windows_nat_target::detach): Don't call gdb_flush.
8647         * valprint.c (generic_val_print, val_print, val_print_string):
8648         Don't call gdb_flush.
8649         * utils.c (defaulted_query): Don't call gdb_flush.
8650         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8651         * target.c (target_announce_detach): Don't call gdb_flush.
8652         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8653         * remote.c (extended_remote_target::attach): Don't call
8654         gdb_flush.
8655         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8656         * printcmd.c (do_examine): Don't call gdb_flush.
8657         (info_display_command): Don't call gdb_flush.
8658         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8659         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8660         * memattr.c (info_mem_command): Don't call gdb_flush.
8661         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8662         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8663         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8664         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8665         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8666         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8667         (gnu_nat_target::detach): Don't call gdb_flush.
8668         * f-valprint.c (f_val_print): Don't call gdb_flush.
8669         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8670         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8671         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8672         gdb_flush.
8673         * c-valprint.c (c_val_print): Don't call gdb_flush.
8674         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8675
8676 2019-03-05  Tom Tromey  <tromey@adacore.com>
8677
8678         * varobj.c (update_dynamic_varobj_children): Update.
8679         (install_default_visualizer): Use reset, not release.
8680         * value.c (set_internalvar): Update.
8681         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8682         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8683         ATTRIBUTE_UNUSED_RESULT.
8684
8685 2019-03-05  Tom Tromey  <tromey@adacore.com>
8686
8687         * remote.c (class scoped_remote_fd) <release>: Add
8688         ATTRIBUTE_UNUSED_RESULT.
8689
8690 2019-03-05  Tom Tromey  <tromey@adacore.com>
8691
8692         * macroexp.c (struct macro_buffer) <release>: Add
8693         ATTRIBUTE_UNUSED_RESULT.
8694
8695 2019-03-05  Tom Tromey  <tromey@adacore.com>
8696
8697         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8698         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8699         ATTRIBUTE_UNUSED_RESULT.
8700
8701 2019-03-05  Tom Tromey  <tromey@adacore.com>
8702
8703         * common/scoped_fd.h (class scoped_fd) <release>: Add
8704         ATTRIBUTE_UNUSED_RESULT.
8705
8706 2019-03-05  Tom Tromey  <tromey@adacore.com>
8707
8708         * parser-defs.h (struct parser_state) <release>: Add
8709         ATTRIBUTE_UNUSED_RESULT.
8710
8711 2019-03-05  Tom Tromey  <tromey@adacore.com>
8712
8713         * utils.h (class gdb_argv) <release>: Add
8714         ATTRIBUTE_UNUSED_RESULT.
8715         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8716
8717 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8718
8719         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8720         for-loop range, to avoid compiler warnings.
8721
8722         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8723         avoid compiler warnings about unused variables.
8724
8725         * NEWS: Mention end of support for native debugging on MS-Windows
8726         before XP.
8727
8728         PR gdb/24292
8729         * common/netstuff.c:
8730         * gdbserver/gdbreplay.c
8731         * gdbserver/remote-utils.c:
8732         * ser-tcp.c:
8733         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8734         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8735         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8736         'getaddrinfo' and 'freeaddrinfo' were not available before
8737         Windows XP, and mingw.org's MinGW headers by default define
8738         _WIN32_WINNT to 0x500.
8739
8740 2019-03-01  Gary Benson <gbenson@redhat.com>
8741
8742         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8743
8744 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8745             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8746
8747         PR gdb/8527
8748         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8749         set_sigint_trap, clear_sigint_trap.
8750
8751 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8752
8753         * target.c (target_detach): Clear the regcache and the
8754         frame cache.
8755
8756 2019-02-27  Pedro Alves  <palves@redhat.com>
8757
8758         * utils.c (set_screen_size): When we cap the height/width sizes,
8759         tweak the corresponding command variable to show "unlimited":
8760
8761 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8762             Pedro Alves  <palves@redhat.com>
8763
8764         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8765         before calling rl_set_screen_size.
8766
8767 2019-02-27  Tom Tromey  <tromey@adacore.com>
8768
8769         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8770         define.
8771         * python/py-value.c: Remove Python 2.4 workaround.
8772         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8773         workaround.
8774         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8775         Python 2.4 workaround.
8776         * python/python-internal.h: Remove Python 2.4 comment.
8777         (Py_ssize_t): Don't define.
8778         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8779         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8780         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8781         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8782         * python/python.c (do_start_initialization): Remove Python 2.4
8783         workaround.
8784         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8785         (print_children): Remove Python 2.4 workaround.
8786         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8787         workaround.
8788         (CHARBUFFERPROC_NAME): Remove.
8789         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8790         Python 2.4 workaround.
8791
8792 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8793
8794         * NEWS: Note minimum Python version.
8795
8796 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8797
8798         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8799         code from these functions.  Remove corresponding ifdefs.  Use
8800         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8801         Remove gotos and target of gotos.
8802         (infpy_search_memory): Likewise.
8803
8804 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8805
8806         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8807         (hppa_gdbarch_init): Don't register deleted functions with
8808         gdbarch.
8809
8810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8811
8812         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8813         (h8300_unwind_sp): Delete.
8814         (h8300_dummy_id): Delete.
8815         (h8300_gdbarch_init): Don't register deleted functions with
8816         gdbarch.
8817
8818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8819
8820         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8821         (ft32_unwind_pc): Delete.
8822         (ft32_unwind_sp): Delete.
8823         (ft32_gdbarch_init): Don't register deleted functions with
8824         gdbarch.
8825
8826 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8827
8828         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8829         (frv_unwind_pc): Delete.
8830         (frv_unwind_sp): Delete.
8831         (frv_gdbarch_init): Don't register deleted functions with
8832         gdbarch.
8833
8834 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8835
8836         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8837         (riscv_unwind_pc): Delete.
8838         (riscv_unwind_sp): Delete.
8839         (riscv_gdbarch_init): Don't register deleted functions with
8840         gdbarch.
8841
8842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8843
8844         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8845         (csky_unwind_pc): Delete.
8846         (csky_unwind_sp): Delete.
8847         (csky_gdbarch_init): Don't register deleted functions with
8848         gdbarch.
8849
8850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8851
8852         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8853         (cris_unwind_pc): Delete.
8854         (cris_unwind_sp): Delete.
8855         (cris_gdbarch_init): Don't register deleted functions with
8856         gdbarch.
8857
8858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8859
8860         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8861         (bfin_unwind_pc): Delete.
8862         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8863
8864 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8865
8866         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8867         (arm_unwind_pc): Delete.
8868         (arm_unwind_sp): Delete.
8869         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8870
8871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8872
8873         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8874         (arc_unwind_pc): Delete.
8875         (arc_unwind_sp): Delete.
8876         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8877
8878 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8879
8880         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8881         (alpha_unwind_pc): Delete.
8882         (alpha_gdbarch_init): Don't register deleted functions with
8883         gdbarch.
8884
8885 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8886
8887         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8888         (aarch64_unwind_pc): Delete.
8889         (aarch64_unwind_sp): Delete.
8890         (aarch64_gdbarch_init): Don't register deleted functions with
8891         gdbarch.
8892
8893 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8894
8895         * gdbtypes.c (type_align): Don't consider static members when
8896         computing structure alignment.
8897
8898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8899
8900         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8901         return 0 for other types.
8902         * arch-utils.c (default_type_align): Always return 0.
8903         * gdbarch.h: Regenerate.
8904         * gdbarch.sh (type_align): Extend comment.
8905         * gdbtypes.c (type_align): Add additional comments, always call
8906         gdbarch_type_align before applying the default rules.
8907         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8908         generic code will then apply a suitable default.
8909         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8910         types, return 0 for other types.
8911
8912 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8913
8914         * NEWS: Create a new section for the next release branch.
8915         Rename the section of the current branch, now that it has
8916         been cut.
8917
8918 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8919
8920         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8921         * version.in: Bump version to 8.3.50.DATE-git.
8922
8923 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8924
8925         * aix-thread.c (ptid_cmp): Remove unused variable.
8926         (get_signaled_thread): Likewise.
8927         (store_regs_user_thread): Likewise.
8928         (store_regs_kernel_thread): Likewise.
8929         (fetch_regs_kernel_thread): Remove shadowed variable.
8930
8931 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8932
8933         * features/riscv/32bit-cpu.xml: Add register numbers.
8934         * features/riscv/32bit-fpu.c: Regenerate.
8935         * features/riscv/32bit-fpu.xml: Add register numbers.
8936         * features/riscv/64bit-cpu.xml: Add register numbers.
8937         * features/riscv/64bit-fpu.c: Regenerate.
8938         * features/riscv/64bit-fpu.xml: Add register numbers.
8939
8940 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8941
8942         * NEWS: Mention two argument form of gdb.Value constructor.
8943         * python/py-value.c (convert_buffer_and_type_to_value): New
8944         function.
8945         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8946         Add support for handling an optional second argument.  Call
8947         convert_buffer_and_type_to_value as appropriate.
8948         * python/python-internal.h (Py_buffer_deleter): New struct.
8949         (Py_buffer_up): New typedef.
8950
8951 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8952
8953         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8954         instead of releasing ownership.
8955
8956 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8957
8958         * dwarf2read.c (open_and_init_dwp_file): Call
8959         elf_numsections instead of bfd_count_sections to initialize
8960         dwp_file->num_sections.
8961
8962 2019-02-25  Tom Tromey  <tromey@adacore.com>
8963
8964         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8965
8966 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8967
8968         * gcore.in: Add '--readnever' option when invoking GDB.
8969
8970 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8971
8972         * MAINTAINERS: Update my email address.
8973
8974 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8975
8976         * build-id.c (build_id_to_debug_bfd_1): New function.
8977         (build_id_to_debug_bfd): Look for separate debug file in
8978         sysroot.
8979
8980 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8981
8982         * gdbarch.sh: Update the copyright year range that is placed into
8983         generated files.
8984
8985 2019-02-22  Keith Seitz  <keiths@redhat.com>
8986
8987         PR symtab/23853
8988         * linespec.c (create_sals_line_offset): Search for the default
8989         symtab's filename instead of its fullname.
8990
8991 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8992
8993         * NEWS: Update style defaults.
8994
8995 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8996
8997         * main.c (captured_main_1): Disable styling in batch mode.
8998
8999 2019-02-20  Tom Tromey  <tom@tromey.com>
9000
9001         * symtab.c (symtab_symbol_info): Fix typos.
9002
9003 2019-02-20  Tom Tromey  <tromey@adacore.com>
9004
9005         * findcmd.c (_initialize_mem_search): Use upper case for
9006         metasyntactic variables.
9007
9008 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9009
9010         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9011         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9012
9013 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9014
9015         * top.h (source_file_name): Change to std::string.
9016         * top.c (source_file_name): Likewise.
9017         (command_line_input): Adjust.
9018         * cli/cli-script.c (script_from_file): Adjust.
9019
9020 2019-02-19  Tom Tromey  <tromey@adacore.com>
9021
9022         * ravenscar-thread.c
9023         (ravenscar_thread_target::update_thread_list): Don't call
9024         ada_build_task_list.
9025         * ada-lang.h (ada_build_task_list): Don't declare.
9026         * ada-tasks.c (struct ada_tasks_inferior_data)
9027         <task_list_valid_p>: Now bool.
9028         (read_known_tasks, ada_task_list_changed)
9029         (ada_tasks_invalidate_inferior_data): Update.
9030         (read_known_tasks_array): Return bool.
9031         (read_known_tasks_list): Likewise.
9032         (read_known_tasks): Return void.
9033         (ada_build_task_list): Now static.
9034
9035 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9036
9037         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9038         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9039
9040 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9041
9042         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9043         variant for ada_tasks_pspace_data_handle and
9044         ada_tasks_inferior_data_handle.
9045         (ada_tasks_pspace_data_cleanup): New function.
9046         (ada_tasks_inferior_data_cleanup): New function.
9047
9048 2019-02-17  Tom Tromey  <tom@tromey.com>
9049
9050         * macrotab.h (macro_source_fullname): Return a std::string.
9051         * macrotab.c (macro_include, check_for_redefinition)
9052         (macro_undef, macro_lookup_definition, foreach_macro)
9053         (foreach_macro_in_scope): Update.
9054         (macro_source_fullname): Return a std::string.
9055         * macrocmd.c (show_pp_source_pos): Update.
9056
9057 2019-02-17  Tom Tromey  <tom@tromey.com>
9058
9059         * macrocmd.c (show_pp_source_pos): Style the file names.
9060
9061 2019-02-17  Tom Tromey  <tom@tromey.com>
9062
9063         PR tui/24197:
9064         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9065
9066 2019-02-17  Tom Tromey  <tom@tromey.com>
9067
9068         * ada-lang.c (user_select_syms): Use filtered printing.
9069         * utils.c (wrap_style): New global.
9070         (desired_style): Remove.
9071         (emit_style_escape): Add stream parameter.
9072         (set_output_style, reset_terminal_style, prompt_for_continue):
9073         Update.
9074         (flush_wrap_buffer): Only flush gdb_stdout.
9075         (wrap_here): Set wrap_style.
9076         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9077         treat escape sequences as a character.  Change when wrap buffer is
9078         flushed.
9079         (fputs_styled): Do not set the output style when the default is
9080         requested.
9081         * ui-style.h (struct ui_file_style) <is_default>: New method.
9082         * source.c (print_source_lines_base): Emit escape sequences in one
9083         piece.
9084
9085 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9086
9087         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9088         integers and enumeration types.
9089
9090 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9091
9092         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9093         instead of lookup_symbol_in_language
9094         (do_exact_match): New function.
9095         (ada_get_symbol_name_matcher): Return do_exact_match when
9096         doing a verbatim match.
9097
9098 2019-02-15  Tom Tromey  <tromey@adacore.com>
9099
9100         * ravenscar-thread.c (ravenscar_thread_target::resume)
9101         (ravenscar_thread_target::wait): Special case wildcard requests.
9102
9103 2019-02-15  Tom Tromey  <tromey@adacore.com>
9104
9105         * ravenscar-thread.c (base_ptid): Remove.
9106         (struct ravenscar_thread_target) <close>: New method.
9107         <m_base_ptid>: New member.
9108         <update_inferior_ptid, active_task, task_is_currently_active,
9109         runtime_initialized>: Declare methods.
9110         <ravenscar_thread_target>: Add constructor.
9111         (ravenscar_thread_target::task_is_currently_active)
9112         (ravenscar_thread_target::update_inferior_ptid)
9113         (ravenscar_runtime_initialized): Rename.  Now methods.
9114         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9115         (ravenscar_thread_target::update_thread_list): Update.
9116         (ravenscar_thread_target::active_task): Now method.
9117         (ravenscar_thread_target::store_registers)
9118         (ravenscar_thread_target::prepare_to_store)
9119         (ravenscar_thread_target::prepare_to_store)
9120         (ravenscar_thread_target::mourn_inferior): Update.
9121         (ravenscar_inferior_created): Use "new" to create target.
9122         (ravenscar_thread_target::get_ada_task_ptid): Update.
9123         (_initialize_ravenscar): Don't initialize base_ptid.
9124         (ravenscar_ops): Remove global.
9125
9126 2019-02-15  Tom Tromey  <tromey@adacore.com>
9127
9128         * target.h (push_target): Declare new overload.
9129         * target.c (push_target): New overload, taking an rvalue reference.
9130         * remote.c (remote_target::open_1): Use push_target overload.
9131         * corelow.c (core_target_open): Use push_target overload.
9132
9133 2019-02-15  Tom Tromey  <tromey@adacore.com>
9134
9135         * ravenscar-thread.c (is_ravenscar_task)
9136         (ravenscar_task_is_currently_active): Return bool.
9137         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9138         (_initialize_ravenscar): Remove "(void)".
9139         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9140         Return bool.
9141
9142 2019-02-15  Tom Tromey  <tromey@adacore.com>
9143
9144         * ravenscar-thread.c (ravenscar_runtime_initializer)
9145         (has_ravenscar_runtime, get_running_thread_id)
9146         (ravenscar_thread_target::resume): Fix indentation.
9147
9148 2019-02-15  Tom Tromey  <tromey@adacore.com>
9149
9150         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9151         from ravenscar_arch_ops.
9152         (sparc_ravenscar_ops::fetch_registers)
9153         (sparc_ravenscar_ops::store_registers): Now methods.
9154         (sparc_ravenscar_prepare_to_store): Remove.
9155         (sparc_ravenscar_ops): Redefine.
9156         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9157         methods and destructor.  Remove members.
9158         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9159         (ravenscar_thread_target::store_registers)
9160         (ravenscar_thread_target::prepare_to_store): Update.
9161         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9162         Remove.
9163         (struct ppc_ravenscar_powerpc_ops): Derive from
9164         ravenscar_arch_ops.
9165         (ppc_ravenscar_powerpc_ops::fetch_registers)
9166         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9167         (ppc_ravenscar_powerpc_ops): Redefine.
9168         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9169         (ppc_ravenscar_e500_ops::fetch_registers)
9170         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9171         (ppc_ravenscar_e500_ops): Redefine.
9172         * aarch64-ravenscar-thread.c
9173         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9174         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9175         (aarch64_ravenscar_fetch_registers)
9176         (aarch64_ravenscar_store_registers): Now methods.
9177         (aarch64_ravenscar_ops): Redefine.
9178
9179 2019-02-15  Tom Tromey  <tromey@adacore.com>
9180
9181         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9182         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9183         (ravenscar_thread_target::stopped_by_watchpoint)
9184         (ravenscar_thread_target::stopped_data_address)
9185         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9186
9187 2019-02-15  Tom Tromey  <tromey@adacore.com>
9188
9189         * ravenscar-thread.c: Fix some typos.
9190
9191 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9192             Tom Tromey  <tromey@adacore.com>
9193
9194         * ada-lang.c (ada_exception_sal): Change addr_string to a
9195         std::string.
9196         (create_ada_exception_catchpoint): Update.
9197
9198 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9199             Tom Tromey  <tromey@adacore.com>
9200
9201         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9202         (bp_location_ops): Remove.
9203         (base_breakpoint_allocate_location): Update.
9204         (free_bp_location): Update.
9205         * ada-lang.c (class ada_catchpoint_location)
9206         <ada_catchpoint_location>: Remove ops parameter.
9207         (ada_catchpoint_location_dtor): Remove.
9208         (ada_catchpoint_location_ops): Remove.
9209         (allocate_location_exception): Update.
9210         * breakpoint.h (struct bp_location_ops): Remove.
9211         (class bp_location) <bp_location>: Remove bp_location_ops
9212         parameter.
9213         <~bp_location>: Add destructor.
9214         <ops>: Remove.
9215
9216 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9217             Pedro Alves  <palves@redhat.com>
9218
9219         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9220         'PATH_MAX'.
9221
9222 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9223             Samuel Thibault  <samuel.thibault@gnu.org>
9224             Thomas Schwinge  <thomas@codesourcery.com>
9225
9226         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9227         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9228
9229 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9230
9231         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9232         (check_empty): Use "const char *".
9233
9234         * gnu-nat.c (gnu_nat_target::detach): Instead of
9235         'detach_inferior (pid)' call
9236         'detach_inferior (find_inferior_pid (pid))'.
9237
9238         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9239         'nat/fork-inferior.o'.
9240         * gnu-nat.c: #include "nat/fork-inferior.h".
9241
9242         * gnu-nat.c (gnu_nat_target::detach): Instead of
9243         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9244         * gnu-nat.h: #include "inf-child.h".
9245         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9246         'i386_gnu_nat_target::fetch_registers'.
9247         (gnu_store_registers): Rename/move to
9248         'i386_gnu_nat_target::store_registers'.
9249
9250         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9251         * gnu-nat.h (mach_thread_info): New function.
9252         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9253
9254         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9255
9256 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9257
9258         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9259
9260 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9261
9262         * windows-nat.c (windows_add_thread): Add new parameter
9263         "main_thread_p" with default value set to false.  Update
9264         function documentation as well as all callers.
9265         (windows_delete_thread): Likewise.
9266         (fake_create_process): Update call to windows_add_thread.
9267         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9268         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9269         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9270         call to windows_delete_thread.
9271
9272 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9273
9274         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9275
9276 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9277
9278         * symfile.c (find_separate_debug_file): Use canonical path of
9279         sysroot with child_path instead of gdb_sysroot if it is valid.
9280
9281 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9282
9283         * symfile.c (find_separate_debug_file): Use child_path to
9284         determine if an object file is under a sysroot.
9285
9286 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9287
9288         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9289         unittests/child-path-selftests.c.
9290         * common/pathstuff.c (child_path): New function.
9291         * common/pathstuff.h (child_path): New prototype.
9292         * unittests/child-path-selftests.c: New file.
9293
9294 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9295
9296         * symfile.c (find_separate_debug_file): Look for separate debug
9297         files in debug directories under the sysroot.
9298
9299 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9300
9301         * symtab.h (struct minimal_symbol data_p): New const method.
9302         (struct minimal_symbol text_p): Likewise.
9303         * symtab.c (output_source_filename): Use file name style
9304         to print file name.
9305         (print_symbol_info): Likewise.
9306         (print_msymbol_info): Use address style to print addresses.
9307         Use function name style to print executable text symbols.
9308         (expand_symtab_containing_pc): Use data_p.
9309         (find_pc_sect_compunit_symtab): Likewise.
9310
9311 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9312
9313         * breakpoint.c (describe_other_breakpoints): Use address style
9314         to print addresses.
9315         (say_where): Likewise.
9316
9317 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9318
9319         * ada-typeprint.c (print_func_type): Print function name
9320         style to print function name.
9321         * c-typeprint.c (c_print_type_1): Likewise.
9322
9323 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9324
9325         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9326         for execve.
9327
9328 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9329
9330         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9331         type_stack.
9332
9333 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9334
9335         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9336         TYPE_CODE_REF types.
9337
9338 2019-02-08  Jim Wilson  <jimw@sifive.com>
9339
9340         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9341         (riscv_linux_fregset): New.
9342         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9343
9344 2019-02-07  Tom Tromey  <tom@tromey.com>
9345
9346         * thread.c (thread_cancel_execution_command): Update.
9347         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9348         methods.
9349         (struct thread_fsm_ops): Remove.
9350         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9351         (thread_fsm_should_stop, thread_fsm_return_value)
9352         (thread_fsm_set_finished, thread_fsm_finished_p)
9353         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9354         Don't declare.
9355         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9356         * infrun.c (clear_proceed_status_thread)
9357         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9358         (print_stop_event): Update.
9359         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9360         Add constructor.
9361         (step_command_fsm_ops): Remove.
9362         (new_step_command_fsm): Remove.
9363         (step_1): Update.
9364         (step_command_fsm::should_stop): Rename from
9365         step_command_fsm_should_stop.
9366         (step_command_fsm::clean_up): Rename from
9367         step_command_fsm_clean_up.
9368         (step_command_fsm::do_async_reply_reason): Rename from
9369         step_command_fsm_async_reply_reason.
9370         (struct until_next_fsm): Inherit from thread_fsm.  Add
9371         constructor.
9372         (until_next_fsm_ops): Remove.
9373         (new_until_next_fsm): Remove.
9374         (until_next_fsm::should_stop): Rename from
9375         until_next_fsm_should_stop.
9376         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9377         (until_next_fsm::do_async_reply_reason): Rename from
9378         until_next_fsm_async_reply_reason.
9379         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9380         constructor.  Change type of breakpoint.
9381         (finish_command_fsm_ops): Remove.
9382         (new_finish_command_fsm): Remove.
9383         (finish_command_fsm::should_stop): Rename from
9384         finish_command_fsm_should_stop.
9385         (finish_command_fsm::clean_up): Rename from
9386         finish_command_fsm_clean_up.
9387         (finish_command_fsm::return_value): Rename from
9388         finish_command_fsm_return_value.
9389         (finish_command_fsm::do_async_reply_reason): Rename from
9390         finish_command_fsm_async_reply_reason.
9391         (finish_command): Update.
9392         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9393         Add constructor.
9394         (call_thread_fsm_ops): Remove.
9395         (call_thread_fsm::call_thread_fsm): Rename from
9396         new_call_thread_fsm.
9397         (call_thread_fsm::should_stop): Rename from
9398         call_thread_fsm_should_stop.
9399         (call_thread_fsm::should_notify_stop): Rename from
9400         call_thread_fsm_should_notify_stop.
9401         (run_inferior_call, call_function_by_hand_dummy): Update.
9402         * cli/cli-interp.c (should_print_stop_to_console): Update.
9403         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9404         Add constructor.  Change type of location_breakpoint,
9405         caller_breakpoint.
9406         (until_break_fsm_ops): Remove.
9407         (new_until_break_fsm): Remove.
9408         (until_break_fsm::should_stop): Rename from
9409         until_break_fsm_should_stop.
9410         (until_break_fsm::clean_up): Rename from
9411         until_break_fsm_clean_up.
9412         (until_break_fsm::do_async_reply_reason): Rename from
9413         until_break_fsm_async_reply_reason.
9414         (until_break_command): Update.
9415         * thread-fsm.c: Remove.
9416         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9417
9418 2019-02-07  Tom Tromey  <tom@tromey.com>
9419
9420         * yy-remap.h: Add include guard.
9421         * xtensa-tdep.h: Add include guard.
9422         * xcoffread.h: Rename include guard.
9423         * varobj-iter.h: Add include guard.
9424         * tui/tui.h: Rename include guard.
9425         * tui/tui-winsource.h: Rename include guard.
9426         * tui/tui-wingeneral.h: Rename include guard.
9427         * tui/tui-windata.h: Rename include guard.
9428         * tui/tui-win.h: Rename include guard.
9429         * tui/tui-stack.h: Rename include guard.
9430         * tui/tui-source.h: Rename include guard.
9431         * tui/tui-regs.h: Rename include guard.
9432         * tui/tui-out.h: Rename include guard.
9433         * tui/tui-layout.h: Rename include guard.
9434         * tui/tui-io.h: Rename include guard.
9435         * tui/tui-hooks.h: Rename include guard.
9436         * tui/tui-file.h: Rename include guard.
9437         * tui/tui-disasm.h: Rename include guard.
9438         * tui/tui-data.h: Rename include guard.
9439         * tui/tui-command.h: Rename include guard.
9440         * tic6x-tdep.h: Add include guard.
9441         * target/waitstatus.h: Rename include guard.
9442         * target/wait.h: Rename include guard.
9443         * target/target.h: Rename include guard.
9444         * target/resume.h: Rename include guard.
9445         * target-float.h: Rename include guard.
9446         * stabsread.h: Add include guard.
9447         * rs6000-tdep.h: Add include guard.
9448         * riscv-fbsd-tdep.h: Add include guard.
9449         * regformats/regdef.h: Rename include guard.
9450         * record.h: Rename include guard.
9451         * python/python.h: Rename include guard.
9452         * python/python-internal.h: Rename include guard.
9453         * python/py-stopevent.h: Rename include guard.
9454         * python/py-ref.h: Rename include guard.
9455         * python/py-record.h: Rename include guard.
9456         * python/py-record-full.h: Rename include guard.
9457         * python/py-record-btrace.h: Rename include guard.
9458         * python/py-instruction.h: Rename include guard.
9459         * python/py-events.h: Rename include guard.
9460         * python/py-event.h: Rename include guard.
9461         * procfs.h: Add include guard.
9462         * proc-utils.h: Add include guard.
9463         * p-lang.h: Add include guard.
9464         * or1k-tdep.h: Rename include guard.
9465         * observable.h: Rename include guard.
9466         * nto-tdep.h: Rename include guard.
9467         * nat/x86-linux.h: Rename include guard.
9468         * nat/x86-linux-dregs.h: Rename include guard.
9469         * nat/x86-gcc-cpuid.h: Add include guard.
9470         * nat/x86-dregs.h: Rename include guard.
9471         * nat/x86-cpuid.h: Rename include guard.
9472         * nat/ppc-linux.h: Rename include guard.
9473         * nat/mips-linux-watch.h: Rename include guard.
9474         * nat/linux-waitpid.h: Rename include guard.
9475         * nat/linux-ptrace.h: Rename include guard.
9476         * nat/linux-procfs.h: Rename include guard.
9477         * nat/linux-osdata.h: Rename include guard.
9478         * nat/linux-nat.h: Rename include guard.
9479         * nat/linux-namespaces.h: Rename include guard.
9480         * nat/linux-btrace.h: Rename include guard.
9481         * nat/glibc_thread_db.h: Rename include guard.
9482         * nat/gdb_thread_db.h: Rename include guard.
9483         * nat/gdb_ptrace.h: Rename include guard.
9484         * nat/fork-inferior.h: Rename include guard.
9485         * nat/amd64-linux-siginfo.h: Rename include guard.
9486         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9487         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9488         * nat/aarch64-linux.h: Rename include guard.
9489         * nat/aarch64-linux-hw-point.h: Rename include guard.
9490         * mn10300-tdep.h: Add include guard.
9491         * mips-linux-tdep.h: Add include guard.
9492         * mi/mi-parse.h: Rename include guard.
9493         * mi/mi-out.h: Rename include guard.
9494         * mi/mi-main.h: Rename include guard.
9495         * mi/mi-interp.h: Rename include guard.
9496         * mi/mi-getopt.h: Rename include guard.
9497         * mi/mi-console.h: Rename include guard.
9498         * mi/mi-common.h: Rename include guard.
9499         * mi/mi-cmds.h: Rename include guard.
9500         * mi/mi-cmd-break.h: Rename include guard.
9501         * m2-lang.h: Add include guard.
9502         * location.h: Rename include guard.
9503         * linux-record.h: Rename include guard.
9504         * linux-nat.h: Add include guard.
9505         * linux-fork.h: Add include guard.
9506         * i386-darwin-tdep.h: Rename include guard.
9507         * hppa-linux-offsets.h: Add include guard.
9508         * guile/guile.h: Rename include guard.
9509         * guile/guile-internal.h: Rename include guard.
9510         * gnu-nat.h: Rename include guard.
9511         * gdb-stabs.h: Rename include guard.
9512         * frv-tdep.h: Add include guard.
9513         * f-lang.h: Add include guard.
9514         * event-loop.h: Add include guard.
9515         * darwin-nat.h: Rename include guard.
9516         * cp-abi.h: Rename include guard.
9517         * config/sparc/nm-sol2.h: Rename include guard.
9518         * config/nm-nto.h: Rename include guard.
9519         * config/nm-linux.h: Add include guard.
9520         * config/i386/nm-i386gnu.h: Rename include guard.
9521         * config/djgpp/nl_types.h: Rename include guard.
9522         * config/djgpp/langinfo.h: Rename include guard.
9523         * compile/gcc-cp-plugin.h: Add include guard.
9524         * compile/gcc-c-plugin.h: Add include guard.
9525         * compile/compile.h: Rename include guard.
9526         * compile/compile-object-run.h: Rename include guard.
9527         * compile/compile-object-load.h: Rename include guard.
9528         * compile/compile-internal.h: Rename include guard.
9529         * compile/compile-cplus.h: Rename include guard.
9530         * compile/compile-c.h: Rename include guard.
9531         * common/xml-utils.h: Rename include guard.
9532         * common/x86-xstate.h: Rename include guard.
9533         * common/version.h: Rename include guard.
9534         * common/vec.h: Rename include guard.
9535         * common/tdesc.h: Rename include guard.
9536         * common/selftest.h: Rename include guard.
9537         * common/scoped_restore.h: Rename include guard.
9538         * common/scoped_mmap.h: Rename include guard.
9539         * common/scoped_fd.h: Rename include guard.
9540         * common/safe-iterator.h: Rename include guard.
9541         * common/run-time-clock.h: Rename include guard.
9542         * common/refcounted-object.h: Rename include guard.
9543         * common/queue.h: Rename include guard.
9544         * common/ptid.h: Rename include guard.
9545         * common/print-utils.h: Rename include guard.
9546         * common/preprocessor.h: Rename include guard.
9547         * common/pathstuff.h: Rename include guard.
9548         * common/observable.h: Rename include guard.
9549         * common/netstuff.h: Rename include guard.
9550         * common/job-control.h: Rename include guard.
9551         * common/host-defs.h: Rename include guard.
9552         * common/gdb_wait.h: Rename include guard.
9553         * common/gdb_vecs.h: Rename include guard.
9554         * common/gdb_unlinker.h: Rename include guard.
9555         * common/gdb_unique_ptr.h: Rename include guard.
9556         * common/gdb_tilde_expand.h: Rename include guard.
9557         * common/gdb_sys_time.h: Rename include guard.
9558         * common/gdb_string_view.h: Rename include guard.
9559         * common/gdb_splay_tree.h: Rename include guard.
9560         * common/gdb_setjmp.h: Rename include guard.
9561         * common/gdb_ref_ptr.h: Rename include guard.
9562         * common/gdb_optional.h: Rename include guard.
9563         * common/gdb_locale.h: Rename include guard.
9564         * common/gdb_assert.h: Rename include guard.
9565         * common/filtered-iterator.h: Rename include guard.
9566         * common/filestuff.h: Rename include guard.
9567         * common/fileio.h: Rename include guard.
9568         * common/environ.h: Rename include guard.
9569         * common/common-utils.h: Rename include guard.
9570         * common/common-types.h: Rename include guard.
9571         * common/common-regcache.h: Rename include guard.
9572         * common/common-inferior.h: Rename include guard.
9573         * common/common-gdbthread.h: Rename include guard.
9574         * common/common-exceptions.h: Rename include guard.
9575         * common/common-defs.h: Rename include guard.
9576         * common/common-debug.h: Rename include guard.
9577         * common/cleanups.h: Rename include guard.
9578         * common/buffer.h: Rename include guard.
9579         * common/btrace-common.h: Rename include guard.
9580         * common/break-common.h: Rename include guard.
9581         * cli/cli-utils.h: Rename include guard.
9582         * cli/cli-style.h: Rename include guard.
9583         * cli/cli-setshow.h: Rename include guard.
9584         * cli/cli-script.h: Rename include guard.
9585         * cli/cli-interp.h: Rename include guard.
9586         * cli/cli-decode.h: Rename include guard.
9587         * cli/cli-cmds.h: Rename include guard.
9588         * charset-list.h: Add include guard.
9589         * buildsym-legacy.h: Rename include guard.
9590         * bfin-tdep.h: Add include guard.
9591         * ax.h: Rename include guard.
9592         * arm-linux-tdep.h: Add include guard.
9593         * arm-fbsd-tdep.h: Add include guard.
9594         * arch/xtensa.h: Rename include guard.
9595         * arch/tic6x.h: Add include guard.
9596         * arch/i386.h: Add include guard.
9597         * arch/arm.h: Rename include guard.
9598         * arch/arm-linux.h: Rename include guard.
9599         * arch/arm-get-next-pcs.h: Rename include guard.
9600         * arch/amd64.h: Add include guard.
9601         * arch/aarch64-insn.h: Rename include guard.
9602         * arch-utils.h: Rename include guard.
9603         * annotate.h: Add include guard.
9604         * amd64-darwin-tdep.h: Rename include guard.
9605         * aarch64-linux-tdep.h: Add include guard.
9606         * aarch64-fbsd-tdep.h: Add include guard.
9607         * aarch32-linux-nat.h: Add include guard.
9608
9609 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9610
9611         * macrotab.c (macro_define_internal): New function that
9612         factorizes macro_define_object_internal and macro_define_function
9613         code.
9614         (macro_define_object_internal): Use macro_define_internal.
9615         (macro_define_function): Likewise.
9616
9617 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9618
9619         * macrocmd.c (extract_identifier): Return
9620         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9621         callers.
9622
9623 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9624
9625         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9626
9627 2019-02-05  Tom Tromey  <tom@tromey.com>
9628
9629         * target.c (target_stack::unpush): Move assertion earlier.
9630
9631 2019-01-30  Tom Tromey  <tom@tromey.com>
9632
9633         PR python/23615:
9634         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9635         (gdbpy_parse_and_eval): Likewise.
9636         * python/python-internal.h (gdbpy_allow_threads): New class.
9637
9638 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9639
9640         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9641         (aarch64_fbsd_fpregmap): Move earlier.
9642         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9643         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9644         instead of individual calls to trad_frame_set_reg_addr.
9645         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9646         earlier.
9647         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9648         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9649         instead of individual calls to trad_frame_set_reg_addr.
9650
9651 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9652
9653         * CONTRIBUTE: Replace contribution list with wiki link.
9654
9655 2019-01-25  Tom Tromey  <tom@tromey.com>
9656
9657         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9658
9659 2019-01-25  Tom Tromey  <tom@tromey.com>
9660
9661         * xtensa-linux-nat.c: Fix common/ includes.
9662         * xml-support.h: Fix common/ includes.
9663         * xml-support.c: Fix common/ includes.
9664         * x86-linux-nat.c: Fix common/ includes.
9665         * windows-nat.c: Fix common/ includes.
9666         * varobj.h: Fix common/ includes.
9667         * varobj.c: Fix common/ includes.
9668         * value.c: Fix common/ includes.
9669         * valops.c: Fix common/ includes.
9670         * utils.c: Fix common/ includes.
9671         * unittests/xml-utils-selftests.c: Fix common/ includes.
9672         * unittests/utils-selftests.c: Fix common/ includes.
9673         * unittests/unpack-selftests.c: Fix common/ includes.
9674         * unittests/tracepoint-selftests.c: Fix common/ includes.
9675         * unittests/style-selftests.c: Fix common/ includes.
9676         * unittests/string_view-selftests.c: Fix common/ includes.
9677         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9678         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9679         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9680         * unittests/rsp-low-selftests.c: Fix common/ includes.
9681         * unittests/parse-connection-spec-selftests.c: Fix common/
9682         includes.
9683         * unittests/optional-selftests.c: Fix common/ includes.
9684         * unittests/offset-type-selftests.c: Fix common/ includes.
9685         * unittests/observable-selftests.c: Fix common/ includes.
9686         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9687         * unittests/memrange-selftests.c: Fix common/ includes.
9688         * unittests/memory-map-selftests.c: Fix common/ includes.
9689         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9690         * unittests/function-view-selftests.c: Fix common/ includes.
9691         * unittests/environ-selftests.c: Fix common/ includes.
9692         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9693         * unittests/common-utils-selftests.c: Fix common/ includes.
9694         * unittests/cli-utils-selftests.c: Fix common/ includes.
9695         * unittests/array-view-selftests.c: Fix common/ includes.
9696         * ui-file.c: Fix common/ includes.
9697         * tui/tui-io.c: Fix common/ includes.
9698         * tracepoint.h: Fix common/ includes.
9699         * tracepoint.c: Fix common/ includes.
9700         * tracefile-tfile.c: Fix common/ includes.
9701         * top.h: Fix common/ includes.
9702         * top.c: Fix common/ includes.
9703         * thread.c: Fix common/ includes.
9704         * target/waitstatus.h: Fix common/ includes.
9705         * target/waitstatus.c: Fix common/ includes.
9706         * target.h: Fix common/ includes.
9707         * target.c: Fix common/ includes.
9708         * target-memory.c: Fix common/ includes.
9709         * target-descriptions.c: Fix common/ includes.
9710         * symtab.h: Fix common/ includes.
9711         * symfile.c: Fix common/ includes.
9712         * stap-probe.c: Fix common/ includes.
9713         * spu-linux-nat.c: Fix common/ includes.
9714         * sparc-nat.c: Fix common/ includes.
9715         * source.c: Fix common/ includes.
9716         * solib.c: Fix common/ includes.
9717         * solib-target.c: Fix common/ includes.
9718         * ser-unix.c: Fix common/ includes.
9719         * ser-tcp.c: Fix common/ includes.
9720         * ser-pipe.c: Fix common/ includes.
9721         * ser-base.c: Fix common/ includes.
9722         * selftest-arch.c: Fix common/ includes.
9723         * s12z-tdep.c: Fix common/ includes.
9724         * rust-exp.y: Fix common/ includes.
9725         * rs6000-aix-tdep.c: Fix common/ includes.
9726         * riscv-tdep.c: Fix common/ includes.
9727         * remote.c: Fix common/ includes.
9728         * remote-notif.h: Fix common/ includes.
9729         * remote-fileio.h: Fix common/ includes.
9730         * remote-fileio.c: Fix common/ includes.
9731         * regcache.h: Fix common/ includes.
9732         * regcache.c: Fix common/ includes.
9733         * record-btrace.c: Fix common/ includes.
9734         * python/python.c: Fix common/ includes.
9735         * python/py-type.c: Fix common/ includes.
9736         * python/py-inferior.c: Fix common/ includes.
9737         * progspace.h: Fix common/ includes.
9738         * producer.c: Fix common/ includes.
9739         * procfs.c: Fix common/ includes.
9740         * proc-api.c: Fix common/ includes.
9741         * printcmd.c: Fix common/ includes.
9742         * ppc-linux-nat.c: Fix common/ includes.
9743         * parser-defs.h: Fix common/ includes.
9744         * osdata.c: Fix common/ includes.
9745         * obsd-nat.c: Fix common/ includes.
9746         * nat/x86-linux.c: Fix common/ includes.
9747         * nat/x86-linux-dregs.c: Fix common/ includes.
9748         * nat/x86-dregs.h: Fix common/ includes.
9749         * nat/x86-dregs.c: Fix common/ includes.
9750         * nat/ppc-linux.c: Fix common/ includes.
9751         * nat/mips-linux-watch.h: Fix common/ includes.
9752         * nat/mips-linux-watch.c: Fix common/ includes.
9753         * nat/linux-waitpid.c: Fix common/ includes.
9754         * nat/linux-ptrace.h: Fix common/ includes.
9755         * nat/linux-ptrace.c: Fix common/ includes.
9756         * nat/linux-procfs.c: Fix common/ includes.
9757         * nat/linux-personality.c: Fix common/ includes.
9758         * nat/linux-osdata.c: Fix common/ includes.
9759         * nat/linux-namespaces.c: Fix common/ includes.
9760         * nat/linux-btrace.h: Fix common/ includes.
9761         * nat/linux-btrace.c: Fix common/ includes.
9762         * nat/fork-inferior.c: Fix common/ includes.
9763         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9764         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9765         * nat/aarch64-linux.c: Fix common/ includes.
9766         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9767         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9768         * namespace.h: Fix common/ includes.
9769         * mips-linux-tdep.c: Fix common/ includes.
9770         * minsyms.c: Fix common/ includes.
9771         * mi/mi-parse.h: Fix common/ includes.
9772         * mi/mi-main.c: Fix common/ includes.
9773         * mi/mi-cmd-env.c: Fix common/ includes.
9774         * memrange.h: Fix common/ includes.
9775         * memattr.c: Fix common/ includes.
9776         * maint.h: Fix common/ includes.
9777         * maint.c: Fix common/ includes.
9778         * main.c: Fix common/ includes.
9779         * machoread.c: Fix common/ includes.
9780         * location.c: Fix common/ includes.
9781         * linux-thread-db.c: Fix common/ includes.
9782         * linux-nat.c: Fix common/ includes.
9783         * linux-fork.c: Fix common/ includes.
9784         * inline-frame.c: Fix common/ includes.
9785         * infrun.c: Fix common/ includes.
9786         * inflow.c: Fix common/ includes.
9787         * inferior.h: Fix common/ includes.
9788         * inferior.c: Fix common/ includes.
9789         * infcmd.c: Fix common/ includes.
9790         * inf-ptrace.c: Fix common/ includes.
9791         * inf-child.c: Fix common/ includes.
9792         * ia64-linux-nat.c: Fix common/ includes.
9793         * i387-tdep.c: Fix common/ includes.
9794         * i386-tdep.c: Fix common/ includes.
9795         * i386-linux-tdep.c: Fix common/ includes.
9796         * i386-linux-nat.c: Fix common/ includes.
9797         * i386-go32-tdep.c: Fix common/ includes.
9798         * i386-fbsd-tdep.c: Fix common/ includes.
9799         * i386-fbsd-nat.c: Fix common/ includes.
9800         * guile/scm-type.c: Fix common/ includes.
9801         * guile/guile.c: Fix common/ includes.
9802         * go32-nat.c: Fix common/ includes.
9803         * gnu-nat.c: Fix common/ includes.
9804         * gdbthread.h: Fix common/ includes.
9805         * gdbarch-selftests.c: Fix common/ includes.
9806         * gdb_usleep.c: Fix common/ includes.
9807         * gdb_select.h: Fix common/ includes.
9808         * gdb_bfd.c: Fix common/ includes.
9809         * gcore.c: Fix common/ includes.
9810         * fork-child.c: Fix common/ includes.
9811         * findvar.c: Fix common/ includes.
9812         * fbsd-nat.c: Fix common/ includes.
9813         * event-top.c: Fix common/ includes.
9814         * event-loop.c: Fix common/ includes.
9815         * dwarf2read.c: Fix common/ includes.
9816         * dwarf2loc.c: Fix common/ includes.
9817         * dwarf2-frame.c: Fix common/ includes.
9818         * dwarf-index-cache.c: Fix common/ includes.
9819         * dtrace-probe.c: Fix common/ includes.
9820         * disasm-selftests.c: Fix common/ includes.
9821         * defs.h: Fix common/ includes.
9822         * csky-tdep.c: Fix common/ includes.
9823         * cp-valprint.c: Fix common/ includes.
9824         * cp-support.h: Fix common/ includes.
9825         * cp-support.c: Fix common/ includes.
9826         * corelow.c: Fix common/ includes.
9827         * completer.h: Fix common/ includes.
9828         * completer.c: Fix common/ includes.
9829         * compile/compile.c: Fix common/ includes.
9830         * compile/compile-loc2c.c: Fix common/ includes.
9831         * compile/compile-cplus-types.c: Fix common/ includes.
9832         * compile/compile-cplus-symbols.c: Fix common/ includes.
9833         * command.h: Fix common/ includes.
9834         * cli/cli-dump.c: Fix common/ includes.
9835         * cli/cli-cmds.c: Fix common/ includes.
9836         * charset.c: Fix common/ includes.
9837         * build-id.c: Fix common/ includes.
9838         * btrace.h: Fix common/ includes.
9839         * btrace.c: Fix common/ includes.
9840         * breakpoint.h: Fix common/ includes.
9841         * breakpoint.c: Fix common/ includes.
9842         * ax.h:
9843         (enum agent_op): Fix common/ includes.
9844         * ax-general.c (struct aop_map): Fix common/ includes.
9845         * ax-gdb.c: Fix common/ includes.
9846         * auxv.c: Fix common/ includes.
9847         * auto-load.c: Fix common/ includes.
9848         * arm-tdep.c: Fix common/ includes.
9849         * arch/riscv.c: Fix common/ includes.
9850         * arch/ppc-linux-common.c: Fix common/ includes.
9851         * arch/i386.c: Fix common/ includes.
9852         * arch/arm.c: Fix common/ includes.
9853         * arch/arm-linux.c: Fix common/ includes.
9854         * arch/arm-get-next-pcs.c: Fix common/ includes.
9855         * arch/amd64.c: Fix common/ includes.
9856         * arch/aarch64.c: Fix common/ includes.
9857         * arch/aarch64-insn.c: Fix common/ includes.
9858         * arch-utils.c: Fix common/ includes.
9859         * amd64-windows-tdep.c: Fix common/ includes.
9860         * amd64-tdep.c: Fix common/ includes.
9861         * amd64-sol2-tdep.c: Fix common/ includes.
9862         * amd64-obsd-tdep.c: Fix common/ includes.
9863         * amd64-nbsd-tdep.c: Fix common/ includes.
9864         * amd64-linux-tdep.c: Fix common/ includes.
9865         * amd64-linux-nat.c: Fix common/ includes.
9866         * amd64-fbsd-tdep.c: Fix common/ includes.
9867         * amd64-fbsd-nat.c: Fix common/ includes.
9868         * amd64-dicos-tdep.c: Fix common/ includes.
9869         * amd64-darwin-tdep.c: Fix common/ includes.
9870         * agent.c: Fix common/ includes.
9871         * ada-lang.h: Fix common/ includes.
9872         * ada-lang.c: Fix common/ includes.
9873         * aarch64-tdep.c: Fix common/ includes.
9874
9875 2019-01-25  Tom Tromey  <tom@tromey.com>
9876
9877         * common/create-version.sh: Use common/version.h.
9878
9879 2019-01-24  Pedro Alves  <palves@redhat.com>
9880
9881         * infrun.c (signal_stop, signal_print, signal_program)
9882         (signal_catch, signal_pass): Now arrays instead of pointers.
9883         (update_signals_program_target, do_target_resume)
9884         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9885         * linux-nat.c (linux_nat_target::pass_signals)
9886         (linux_nat_target::create_inferior, linux_nat_target::attach):
9887         Adjust.
9888         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9889         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9890         * procfs.c (procfs_target::pass_signals): Adjust.
9891         * record-full.c (record_full_target::resume): Adjust.
9892         * remote.c (remote_target::pass_signals)
9893         (remote_target::program_signals): Adjust.
9894         * target-debug.h (target_debug_print_signals): Now takes a
9895         gdb::array_view as parameter.  Adjust.
9896         * target.h (target_ops) <pass_signals, program_signals>: Replace
9897         pointer and length parameters with gdb::array_view.
9898         (target_pass_signals, target_program_signals): Likewise.
9899         * target-delegates.c: Regenerate.
9900
9901 2019-01-24  Pedro Alves  <palves@redhat.com>
9902
9903         * common/forward-scope-exit.h
9904         (forward_scope_exit::forward_scope_exit): Pass arguments to
9905         m_bind_function directly, instead of creating a std::bind and
9906         copying that.
9907
9908 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9909
9910         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9911         for static members.
9912         (pass_in_v_vfp_candidate): Likewise.
9913
9914 2019-01-23  Tom Tromey  <tom@tromey.com>
9915             Pedro Alves  <palves@redhat.com>
9916
9917         * regcache.c (class regcache_invalidator): Remove.
9918         (regcache::raw_write): Use make_scope_exit.
9919
9920 2019-01-23  Tom Tromey  <tom@tromey.com>
9921
9922         * ui-out.h (class ui_out_emit_type): Update comment.
9923
9924 2019-01-23  Tom Tromey  <tom@tromey.com>
9925
9926         * infrun.c (fetch_inferior_event): Update comment.
9927
9928 2019-01-23  Tom Tromey  <tom@tromey.com>
9929             Pedro Alves  <palves@redhat.com>
9930
9931         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9932         parameter.
9933         (fetch_inferior_event): Use SCOPE_EXIT.
9934
9935
9936 2019-01-23  Tom Tromey  <tom@tromey.com>
9937             Pedro Alves  <palves@redhat.com>
9938
9939         * infrun.c (disable_thread_events): Delete.
9940         (stop_all_threads): Use SCOPE_EXIT.
9941
9942 2019-01-23  Tom Tromey  <tom@tromey.com>
9943             Pedro Alves  <palves@redhat.com>
9944
9945         * symfile.c: Include forward-scope-exit.h.
9946         (clear_symtab_users_cleanup): Replace forward declaration with
9947         a FORWARD_SCOPE_EXIT.
9948         (syms_from_objfile_1): Use the forward_scope_exit and
9949         gdb::optional instead of cleanup_function.
9950         (reread_symbols): Use the forward_scope_exit instead of
9951         cleanup_function.
9952         (clear_symtab_users_cleanup): Remove function.
9953
9954 2019-01-23  Tom Tromey  <tom@tromey.com>
9955             Pedro Alves  <palves@redhat.com>
9956
9957         * linux-nat.c: Include scope-exit.h.
9958         (cleanup_target_stop): Remove.
9959         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9960         SCOPE_EXIT.
9961
9962 2019-01-23  Tom Tromey  <tom@tromey.com>
9963             Pedro Alves  <palves@redhat.com>
9964
9965         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9966         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9967
9968 2019-01-23  Tom Tromey  <tom@tromey.com>
9969             Andrew Burgess  <andrew.burgess@embecosm.com>
9970             Pedro Alves  <palves@redhat.com>
9971
9972         * infrun.c (fetch_inferior_event): Use scope_exit.
9973         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9974         * top.c (execute_command): Use scope_exit.
9975         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9976         * utils.c (do_bpstat_clear_actions_cleanup)
9977         (make_bpstat_clear_actions_cleanup): Remove.
9978
9979 2019-01-23  Tom Tromey  <tom@tromey.com>
9980             Pedro Alves  <palves@redhat.com>
9981
9982         * infrun.c: Include "common/scope-exit.h"
9983         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9984         (wait_for_inferior): Use SCOPE_EXIT.
9985         (fetch_inferior_event): Use scope_exit.
9986
9987 2019-01-23  Tom Tromey  <tom@tromey.com>
9988             Pedro Alves  <palves@redhat.com>
9989
9990         * breakpoint.c (create_breakpoint): Remove cleanup.
9991
9992 2019-01-23  Tom Tromey  <tom@tromey.com>
9993             Andrew Burgess  <andrew.burgess@embecosm.com>
9994             Pedro Alves  <palves@redhat.com>
9995
9996 2019-01-23  Pedro Alves  <palves@redhat.com>
9997
9998         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9999
10000 2019-01-23  Pedro Alves  <palves@redhat.com>
10001             Andrew Burgess  <andrew.burgess@embecosm.com>
10002
10003         * gdbthread.h: Include "common/forward-scope-exit.h".
10004         (scoped_finish_thread_state): Redefine custom class in terms of
10005         forward_scope_exit.
10006
10007 2019-01-23  Pedro Alves  <palves@redhat.com>
10008             Andrew Burgess  <andrew.burgess@embecosm.com>
10009
10010         * common/forward-scope-exit.h: New file.
10011
10012 2019-01-23  Pedro Alves  <palves@redhat.com>
10013             Andrew Burgess  <andrew.burgess@embecosm.com>
10014             Tom Tromey  <tom@tromey.com>
10015
10016         * common/scope-exit.h: New file.
10017
10018 2019-01-23  Pedro Alves  <palves@redhat.com>
10019
10020         * common/preprocessor.h (ESC): Rename to ...
10021         (ESC_PARENS): ... this.
10022         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10023         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10024
10025 2019-01-23  Tom Tromey  <tom@tromey.com>
10026
10027         * language.h (class scoped_switch_to_sym_language_if_auto):
10028         Initialize m_lang in both cases.
10029
10030 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10031
10032         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10033         with XCNEW.
10034
10035 2019-01-22  Tom Tromey  <tom@tromey.com>
10036
10037         * corelow.c: Do not include sys/file.h.
10038
10039 2019-01-22  Tom Tromey  <tom@tromey.com>
10040
10041         * tui/tui-wingeneral.h: Include gdb_curses.h.
10042
10043 2019-01-22  Tom Tromey  <tom@tromey.com>
10044
10045         * source-cache.h (class source_cache) <get_source_lines,
10046         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10047
10048 2019-01-22  Tom Tromey  <tom@tromey.com>
10049
10050         * remote-fileio.h (struct remote_target): Declare.
10051
10052 2019-01-22  Tom Tromey  <tom@tromey.com>
10053
10054         * python/py-arch.c: Do not include py-ref.h.
10055         * python/py-bpevent.c: Do not include py-ref.h.
10056         * python/py-cmd.c: Do not include py-ref.h.
10057         * python/py-continueevent.c: Do not include py-ref.h.
10058         * python/py-event.h: Do not include py-ref.h.
10059         * python/py-evtregistry.c: Do not include py-ref.h.
10060         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10061         * python/py-frame.c: Do not include py-ref.h.
10062         * python/py-framefilter.c: Do not include py-ref.h.
10063         * python/py-function.c: Do not include py-ref.h.
10064         * python/py-infevents.c: Do not include py-ref.h.
10065         * python/py-linetable.c: Do not include py-ref.h.
10066         * python/py-objfile.c: Do not include py-ref.h.
10067         * python/py-param.c: Do not include py-ref.h.
10068         * python/py-prettyprint.c: Do not include py-ref.h.
10069         * python/py-progspace.c: Do not include py-ref.h.
10070         * python/py-symbol.c: Do not include py-ref.h.
10071         * python/py-symtab.c: Do not include py-ref.h.
10072         * python/py-type.c: Do not include py-ref.h.
10073         * python/py-unwind.c: Do not include py-ref.h.
10074         * python/py-utils.c: Do not include py-ref.h.
10075         * python/py-value.c: Do not include py-ref.h.
10076         * python/py-varobj.c: Do not include py-ref.h.
10077         * python/py-xmethods.c: Do not include py-ref.h.
10078         * python/python.c: Do not include py-ref.h.
10079         * varobj.c: Do not include py-ref.h.
10080
10081 2019-01-22  Tom Tromey  <tom@tromey.com>
10082
10083         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10084         keyword for bcache.
10085
10086 2019-01-22  Tom Tromey  <tom@tromey.com>
10087
10088         * compile/compile-cplus-types.c: Remove a comment by #include.
10089
10090 2019-01-22  Tom Tromey  <tom@tromey.com>
10091
10092         * compile/gcc-c-plugin.h: Include compile-internal.h.
10093
10094 2019-01-22  Tom Tromey  <tom@tromey.com>
10095
10096         * stabsread.c (EXTERN): Do not define.
10097         (symnum, next_symbol_text_func, processing_gcc_compilation)
10098         (within_function, global_sym_chain, global_stabs)
10099         (previous_stab_code, this_object_header_files)
10100         (n_this_object_header_files)
10101         (n_allocated_this_object_header_files): Define.
10102         * stabsread.h (EXTERN): Never define.  Use "extern".
10103
10104 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10105
10106         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10107         history_value.
10108
10109 2019-01-21  Tom Tromey  <tom@tromey.com>
10110
10111         * ui-out.c: Fix includes.
10112         * tui/tui-source.c: Fix includes.
10113         * target.c: Fix includes.
10114         * remote.c: Fix includes.
10115         * regcache.c: Fix includes.
10116         * python/py-block.c: Fix includes.
10117         * printcmd.c: Fix includes.
10118         * or1k-tdep.c: Fix includes.
10119         * mi/mi-main.c: Fix includes.
10120         * m32r-tdep.c: Fix includes.
10121         * csky-tdep.c: Fix includes.
10122         * compile/compile-cplus-types.c: Fix includes.
10123         * cli/cli-interp.c: Fix includes.
10124
10125 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10126
10127         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10128         for padding.
10129
10130 2019-01-16  Tom Tromey  <tom@tromey.com>
10131
10132         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10133         earlier.
10134         (struct objfile) <msymbols_range>: Move from top level.
10135         <msymbols>: New method.
10136         (class objfile_msymbols): Remove.
10137         * symtab.c (default_collect_symbol_completion_matches_break_on):
10138         Update.
10139         * symmisc.c (dump_msymbols): Update.
10140         * stabsread.c (scan_file_globals): Update.
10141         * objc-lang.c (info_selectors_command, info_classes_command)
10142         (find_methods): Update.
10143         * minsyms.c (find_solib_trampoline_target): Update.
10144         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10145         * coffread.c (coff_symfile_read): Update.
10146         * ada-lang.c (ada_lookup_simple_minsym)
10147         (ada_collect_symbol_completion_matches): Update.
10148
10149 2019-01-16  Tom Tromey  <tom@tromey.com>
10150
10151         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10152         type.  Remove no-argument constructor.
10153         <iterator::operator++>: Simplify.
10154         <begin>: Update.
10155         <end>: Use minimal_symbol_count.
10156
10157 2019-01-16  Tom Tromey  <tom@tromey.com>
10158
10159         * objfiles.h (struct objfile) <psymtabs>: New method.
10160         (class objfile_psymtabs): Remove.
10161         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10162         typedef.
10163         <range>: New method.
10164         (require_partial_symbols): Change return type.
10165         * psymtab.c (require_partial_symbols)
10166         (psym_expand_symtabs_matching): Update.
10167         * mdebugread.c (parse_partial_symbols): Update.
10168         * dbxread.c (dbx_end_psymtab): Update.
10169
10170 2019-01-15  Tom Tromey  <tom@tromey.com>
10171
10172         * symtab.c (lookup_objfile_from_block)
10173         (lookup_symbol_in_objfile_symtabs)
10174         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10175         (find_line_symtab, info_sources_command)
10176         (default_collect_symbol_completion_matches_break_on)
10177         (make_source_files_completion_list): Update.
10178         * symmisc.c (print_objfile_statistics, dump_objfile)
10179         (maintenance_print_symbols, maintenance_info_symtabs)
10180         (maintenance_check_symtabs, maintenance_info_line_tables):
10181         Update.
10182         * source.c (select_source_symtab)
10183         (forget_cached_source_info_for_objfile): Update.
10184         * objfiles.h (class objfile_compunits): Remove.
10185         (struct objfile) <compunits_range>: New typedef.
10186         (compunits): New method.
10187         * objfiles.c (objfile_relocate1): Update.
10188         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10189         * maint.c (count_symtabs_and_blocks): Update.
10190         * linespec.c (iterate_over_all_matching_symtabs): Update.
10191         * cp-support.c (add_symbol_overload_list_qualified): Update.
10192         * coffread.c (coff_symtab_read): Update.
10193         * ada-lang.c (add_nonlocal_symbols)
10194         (ada_collect_symbol_completion_matches)
10195         (ada_add_global_exceptions): Update.
10196
10197 2019-01-15  Tom Tromey  <tom@tromey.com>
10198
10199         * progspace.h (program_space) <objfiles_safe_range>: New
10200         typedef.
10201         <objfiles_safe>: New method.
10202         * objfiles.h (class all_objfiles_safe): Remove.
10203         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10204         * jit.c (jit_inferior_exit_hook): Update.
10205
10206 2019-01-17  Tom Tromey  <tom@tromey.com>
10207
10208         * progspace.h (program_space) <objfiles_range>: New typedef.
10209         <objfiles>: New method.
10210         <objfiles_head>: Rename from objfiles.
10211         (object_files): Update.
10212         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10213         * guile/scm-pretty-print.c
10214         (ppscm_find_pretty_printer_from_objfiles): Update.
10215         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10216         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10217         Update.
10218         * python/py-progspace.c (pspy_get_objfiles): Update.
10219         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10220         Update.
10221         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10222         (objfpy_lookup_objfile_by_build_id): Update.
10223         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10224         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10225         Update.
10226         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10227         (expand_symtab_containing_pc, lookup_objfile_from_block)
10228         (lookup_static_symbol, basic_lookup_transparent_type)
10229         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10230         (find_line_symtab, info_sources_command)
10231         (default_collect_symbol_completion_matches_break_on)
10232         (make_source_files_completion_list, find_main_name): Update.
10233         * symmisc.c (print_symbol_bcache_statistics)
10234         (print_objfile_statistics, maintenance_print_symbols)
10235         (maintenance_print_msymbols, maintenance_print_objfiles)
10236         (maintenance_info_symtabs, maintenance_check_symtabs)
10237         (maintenance_expand_symtabs, maintenance_info_line_tables):
10238         Update.
10239         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10240         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10241         (map_overlay_command, unmap_overlay_command)
10242         (simple_overlay_update, expand_symtabs_matching)
10243         (map_symbol_filenames): Update.
10244         * symfile-debug.c (set_debug_symfile): Update.
10245         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10246         Update.
10247         * source.c (select_source_symtab, forget_cached_source_info):
10248         Update.
10249         * solib.c (solib_read_symbols): Update.
10250         * solib-spu.c (append_ocl_sos): Update.
10251         * psymtab.c (maintenance_print_psymbols)
10252         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10253         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10254         * printcmd.c (info_symbol_command): Update.
10255         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10256         Update.
10257         * objfiles.h (class all_objfiles): Remove.
10258         * objfiles.c (have_partial_symbols, have_full_symbols)
10259         (have_minimal_symbols, qsort_cmp, update_section_map)
10260         (shared_objfile_contains_address_p)
10261         (default_iterate_over_objfiles_in_search_order): Update.
10262         * objc-lang.c (info_selectors_command, info_classes_command)
10263         (find_methods): Update.
10264         * minsyms.c (find_solib_trampoline_target): Update.
10265         * maint.c (maintenance_info_sections)
10266         (maintenance_translate_address, count_symtabs_and_blocks):
10267         Update.
10268         * main.c (captured_main_1): Update.
10269         * linux-thread-db.c (try_thread_db_load_from_pdir)
10270         (has_libpthread): Update.
10271         * linespec.c (iterate_over_all_matching_symtabs)
10272         (search_minsyms_for_name): Update.
10273         * jit.c (jit_find_objf_with_entry_addr): Update.
10274         * hppa-tdep.c (find_unwind_entry)
10275         (hppa_lookup_stub_minimal_symbol): Update.
10276         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10277         Update.
10278         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10279         (elf_gnu_ifunc_resolve_by_got): Update.
10280         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10281         * dwarf-index-write.c (save_gdb_index_command): Update.
10282         * cp-support.c (add_symbol_overload_list_qualified): Update.
10283         * breakpoint.c (create_overlay_event_breakpoint)
10284         (create_longjmp_master_breakpoint)
10285         (create_std_terminate_master_breakpoint)
10286         (create_exception_master_breakpoint): Update.
10287         * blockframe.c (find_pc_partial_function): Update.
10288         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10289         (ada_collect_symbol_completion_matches)
10290         (ada_add_global_exceptions): Update.
10291
10292 2019-01-17  Tom Tromey  <tom@tromey.com>
10293
10294         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10295         declare VEC.
10296         (solib_target_parse_libraries): Change return type.
10297         (library_list_start_segment, library_list_start_section)
10298         (library_list_end_library, library_list_start_library); Update.
10299         (solib_target_free_library_list): Remove.
10300         (solib_target_parse_libraries): Remove cleanup.  Change return
10301         type.
10302         (solib_target_current_sos): Update.
10303
10304 2019-01-17  Tom Tromey  <tromey@bapiya>
10305
10306         * valprint.c: Replace "the the" with "the".
10307         * symtab.c: Replace "the the" with "the".
10308         * solib.c: Replace "the the" with "the".
10309         * solib-dsbt.c: Replace "the the" with "the".
10310         * linespec.c: Replace "the the" with "the".
10311         * dwarf2loc.h: Replace "the the" with "the".
10312         * amd64-windows-tdep.c: Replace "the the" with "the".
10313         * aarch64-tdep.c: Replace "the the" with "the".
10314
10315 2019-01-16  Keith Seitz  <keiths@redhat.com>
10316
10317         PR gdb/23773
10318         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10319         <builder>: Rename to ..
10320         <m_builder>: ... this and make private.
10321         (dwarf2_cu::get_builder): New method.  Change all users of
10322         `builder' to use this method.
10323         (dwarf2_start_symtab): Move to ...
10324         (dwarf2_cu::start_symtab): ... here.  Update all callers
10325         (setup_type_unit_groups): Move to ...
10326         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10327         callers.
10328         (dwarf2_cu::reset_builder): New method.
10329         (process_full_compunit, process_full_type_unit): Use
10330         dwarf2_cu::reset_builder.
10331         (follow_die_offset): Record the ancestor CU if it is different
10332         from the followed DIE's CU.
10333         (follow_die_sig_1): Likewise.
10334
10335 2019-01-15  Tom Tromey  <tom@tromey.com>
10336
10337         * remote.c (class remote_state) <buf>: Now a char_vector.
10338         <buf_size>: Remove.
10339         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10340         parameter.
10341         (remote_target::getpkt_or_notif_sane_1)
10342         (remote_target::getpkt_sane)
10343         (remote_target::getpkt_or_notif_sane): Likewise.
10344         (class remote_target) <putpkt>: New overload.
10345         (remote_target::read_frame): Change type of "buf_p".  Remove
10346         sizeof_p parameter.
10347         (packet_ok): New overload.
10348         (packet_check_result): New overload.
10349         Update all uses.
10350
10351 2019-01-14  Tom Tromey  <tom@tromey.com>
10352
10353         * remote-notif.c (handle_notification, remote_notif_ack)
10354         (remote_notif_parse): Make "buf" const.
10355         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10356         const.
10357         (remote_notif_parse, remote_notif_ack, handle_notification):
10358         Likewise.
10359         * remote.c (remote_notif_stop_parse): Make "buf" const.
10360         (remote_target::remote_parse_stop_reply): Make "buf" const.
10361         (remote_notif_stop_ack): Make "buf" const.
10362
10363 2019-01-14  Tom Tromey  <tom@tromey.com>
10364
10365         * remote.c (remote_console_output): Make parameter const.
10366
10367 2019-01-14  Tom Tromey  <tom@tromey.com>
10368
10369         * target-debug.h (target_debug_print_signals): Constify.
10370         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10371         * procfs.c (procfs_target::pass_signals): Update.
10372         * linux-nat.c (linux_nat_target::pass_signals): Update.
10373         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10374         * target-delegates.c: Rebuild.
10375         * remote.c (remote_target::program_signals): Update.
10376         (remote_target::pass_signals): Update.
10377         * target.c (target_pass_signals): Constify argument.
10378         (target_program_signals): Likewise.
10379         * target.h (struct target_ops) <pass_signals, program_signals>:
10380         Constify argument.
10381         (target_pass_signals, target_program_signals): Constify argument.
10382
10383 2019-01-14  Tom Tromey  <tom@tromey.com>
10384
10385         PR tui/28819:
10386         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10387
10388 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10389
10390         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10391         field.
10392         * rs6000-tdep.c: Include reggroups.h.
10393         (IS_V_ALIAS_PSEUDOREG): Define.
10394         (rs6000_register_name): Return names for the "vX" aliases.
10395         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10396         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10397         aliases.  Call default_register_reggroup_p for all other
10398         pseudo-registers.
10399         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10400         New functions.
10401         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10402         Handle "vX" aliases.
10403         (v_alias_pseudo_register_collect): New function.
10404         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10405         (rs6000_gdbarch_init): Initialize "vX" aliases as
10406         pseudo-registers.  Restore registration of
10407         rs6000_pseudo_register_reggroup_p with
10408         set_tdesc_pseudo_register_reggroup_p.
10409
10410 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10411
10412         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10413         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10414         set_gdbarch_num_pseudo_regs.
10415
10416 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10417
10418         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10419         Remove arg prefixname, add do_set and do_show.
10420         Add member functions set_list and show_list.
10421         * cli/cli-style.c (class cli_style_option): Update accordingly.
10422         (style_set_list): Move to file scope.
10423         (style_show_list): Likewise.
10424         (set_style): Call help_list.
10425         (show_style): Call cmd_show_list.
10426         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10427         Update to use the new macro.
10428
10429 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10430
10431         * ada-lang.c (_initialize_ada_language): Expand the help text
10432         for the "catch exception" command.
10433
10434 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10435
10436         * symtab.c (matching_obj_sections): Initialize obj,
10437         declare it closer to its usage.
10438
10439 2019-01-10  Tom Tromey  <tom@tromey.com>
10440
10441         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10442         (basic_inf_threads_range): Remove.
10443         (inf_threads_range, inf_non_exited_threads_range)
10444         (safe_inf_threads_range): Use next_adapter.
10445
10446 2019-01-10  Keith Seitz  <keiths@redhat.com>
10447
10448         PR gdb/23712
10449         PR symtab/23010
10450         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10451         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10452
10453 2019-01-10  Keith Seitz  <keiths@redhat.com>
10454
10455         PR gdb/23712
10456         PR symtab/23010
10457         * dictionary.c (pending_to_vector): Remove.
10458         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10459         Remove _1 suffix, replacing functions of the same name.  Update
10460         all callers.
10461         (dict_create_hashed, dict_create_hashed_expandable)
10462         (dict_create_linear, dict_create_linear_expandable, dict_free)
10463         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10464         Make functions static.
10465
10466 2019-01-10  Keith Seitz  <keiths@redhat.com>
10467
10468         PR gdb/23712
10469         PR symtab/23010
10470         * dictionary.h (struct dictionary): Replace declaration with
10471         multidictionary.
10472         (dict_create_hashed, dict_create_hashed_expandable)
10473         (dict_create_linear, dict_create_linear_expandable)
10474         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10475         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10476         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10477         taking multidictionary argument.
10478         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10479         * block.h (struct block) <dict>: Change to multidictionary
10480         and rename `multidict'.
10481         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10482         symmisc.c: Update all dictionary references to multidictionary.
10483
10484 2019-01-10  Keith Seitz  <keiths@redhat.com>
10485
10486         PR gdb/23712
10487         PR symtab/23010
10488         * dictionary.c: Include unordered_map.
10489         (pending_to_vector): New function.
10490         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10491         Rewrite the non-"_1" functions to take vector instead
10492         of linked list.
10493         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10494         "new" _1 versions of the same name.
10495         (multidictionary): Define.
10496         (std::hash<enum language): New definition.
10497         (collate_pending_symbols_by_language, mdict_create_hashed)
10498         (mdict_create_hashed_expandable, mdict_create_linear)
10499         (mdict_create_linear_expandable, mdict_free)
10500         (find_language_dictionary, create_new_language_dictionary)
10501         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10502         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10503         (mdict_size, mdict_empty): New functions.
10504         * dictionary.h (mdict_iterator): Define.
10505
10506 2019-01-10  Pedro Alves  <palves@redhat.com>
10507
10508         * breakpoint.c (read_uploaded_action)
10509         (create_tracepoint_from_upload): Adjust to use
10510         gdb::unique_xmalloc_ptr.
10511         * ctf.c (ctf_write_uploaded_tp):
10512         (SET_ARRAY_FIELD): Use emplace_back.
10513         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10514         * tracefile-tfile.c (tfile_write_uploaded_tp):
10515         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10516         gdb::unique_xmalloc_ptr.
10517         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10518         at_string, cond_string, cmd_strings>: Replace char pointers
10519         with gdb::unique_xmalloc_ptr.
10520
10521 2019-01-10  Pedro Alves  <palves@redhat.com>
10522
10523         * solib-target.c (library_list_start_library): Don't xstrdup name.
10524
10525 2019-01-10  Pedro Alves  <palves@redhat.com>
10526
10527         * mdebugread.c (parse_partial_symbols): Use
10528         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10529
10530 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10531
10532         * linux-fork.c (scoped_switch_fork_info)
10533         <~scoped_switch_fork_info>: Fix incorrect variable name.
10534
10535 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10536
10537         * linux-fork.c (scoped_switch_fork_info)
10538         <scoped_switch_fork_info>: Make explicit.
10539         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10540
10541 2019-01-10  Tom Tromey  <tom@tromey.com>
10542
10543         * objfiles.h (objfile::reset_psymtabs): Update.
10544         * objfiles.c (objfile::objfile): Update.
10545         * psymtab.h (psymtab_storage::obstack): Update.
10546         (psymtab_storage::m_obstack): Use gdb::optional.
10547         (class psymtab_storage): Update comment.  Remove objfile
10548         parameter.
10549         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10550
10551 2019-01-10  Tom Tromey  <tom@tromey.com>
10552
10553         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10554         <free_psymtabs>: Now private.
10555         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10556         (allocate_psymtab): Use new method.
10557
10558 2019-01-10  Tom Tromey  <tom@tromey.com>
10559
10560         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10561         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10562         * mdebugread.c (parse_partial_symbols): Use
10563         allocate_dependencies.
10564         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10565         allocate_dependencies.
10566         (process_psymtab_comp_unit_reader)
10567         (build_type_psymtab_dependencies): Likewise.
10568         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10569
10570 2019-01-10  Tom Tromey  <tom@tromey.com>
10571
10572         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10573         PSYMBOL_SET_LANGUAGE.
10574         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10575
10576 2019-01-10  Tom Tromey  <tom@tromey.com>
10577
10578         * psymtab.h (psymtab_storage::obstack): New method.
10579         <m_obstack>: Rename from obstack; now private.
10580         * psymtab.c (psymtab_storage): Update.
10581         * dwarf2read.c (create_addrmap_from_index)
10582         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10583         Update.
10584
10585 2019-01-10  Tom Tromey  <tom@tromey.com>
10586
10587         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10588         * objfiles.h (objfile::reset_psymtabs): New method.
10589
10590 2019-01-10  Tom Tromey  <tom@tromey.com>
10591
10592         * symmisc.c (print_symbol_bcache_statistics): Update.
10593         (print_objfile_statistics): Update.
10594         * symfile.c (reread_symbols): Update.
10595         * psymtab.h (class psymtab_storage): New.
10596         * psymtab.c (psymtab_storage): New constructor.
10597         (~psymtab_storage): New destructor.
10598         (require_partial_symbols): Update.
10599         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10600         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10601         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10602         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10603         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10604         (start_psymtab_common, end_psymtab_common)
10605         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10606         (allocate_psymtab): Update.
10607         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10608         Update.
10609         (dump_psymtab_addrmap, maintenance_print_psymbols)
10610         (maintenance_check_psymtabs): Update.
10611         (class objfile_psymtabs): Move to objfiles.h.
10612         * psympriv.h (discard_psymtab): Now inline.
10613         (psymtab_discarder::psymtab_discarder): Update.
10614         (psymtab_discarder::~psymtab_discarder): Update.
10615         (ALL_OBJFILE_PSYMTABS): Rewrite.
10616         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10617         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10618         Remove fields.
10619         <partial_symtabs>: New field.
10620         (class objfile_psymtabs): Move from psymtab.h.  Update.
10621         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10622         psymbol_cache.
10623         (objfile::~objfile): Don't destroy psymbol_cache.
10624         * mdebugread.c (parse_partial_symbols): Update.
10625         * dwarf2read.c (create_addrmap_from_index)
10626         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10627         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10628         (add_partial_subprogram, dwarf2_ranges_read): Update.
10629         * dwarf-index-write.c (write_address_map)
10630         (write_one_signatured_type, recursively_write_psymbols)
10631         (class debug_names, class debug_names, write_psymtabs_to_index):
10632         Update.
10633
10634 2019-01-10  Tom Tromey  <tom@tromey.com>
10635
10636         * symtab.h (SYMBOL_SET_NAMES): Update.
10637         (symbol_set_names): Update.
10638         (MSYMBOL_SET_NAMES): Update.
10639         * symtab.c (symbol_set_names): Change argument to be an
10640         objfile_per_bfd_storage.
10641         * psymtab.c (add_psymbol_to_bcache): Update.
10642         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10643
10644 2019-01-10  Tom Tromey  <tom@tromey.com>
10645
10646         * symtab.c (create_demangled_names_hash): Change argument to be an
10647         objfile_per_bfd_storage.
10648         (symbol_set_names): Update.
10649
10650 2019-01-10  Tom Tromey  <tom@tromey.com>
10651
10652         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10653         init_psymbol_list.
10654         * psymtab.c (init_psymbol_list): Do nothing if already called.
10655         * psympriv.h (init_psymbol_list): Add comment.
10656         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10657         init_psymbol_list.
10658         * dbxread.c (dbx_symfile_read): Unconditionally call
10659         init_psymbol_list.
10660
10661 2019-01-10  Tom Tromey  <tom@tromey.com>
10662
10663         * xcoffread.c (scan_xcoff_symtab): Update.
10664         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10665         "where".
10666         * mdebugread.c (parse_partial_symbols)
10667         (handle_psymbol_enumerators): Update.
10668         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10669         * dbxread.c (read_dbx_symtab): Update.
10670         * psympriv.h (psymbol_placement): New enum.
10671         (add_psymbol_to_list): Update.
10672
10673 2019-01-10  Tom Tromey  <tom@tromey.com>
10674
10675         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10676         static_psymbols parameters.
10677         (scan_xcoff_symtab): Update.
10678         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10679         static_psymbols parameters.
10680         * psympriv.h (start_psymtab_common): Update.
10681         * mdebugread.c (parse_partial_symbols): Update.
10682         * dwarf2read.c (create_partial_symtab): Update.
10683         * dbxread.c (read_dbx_symtab): Update.
10684         (start_psymtab): Remove global_psymbols and static_psymbols
10685         parameters.
10686
10687 2019-01-10  Tom Tromey  <tom@tromey.com>
10688
10689         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10690         * psymtab.c (allocate_psymtab): Add comment.
10691         * psympriv.h (allocate_psymtab): Add comment.
10692         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10693         initializations.
10694         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10695
10696 2019-01-10  Tom Tromey  <tom@tromey.com>
10697
10698         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10699         Don't declare.
10700         * mipsread.c: Include mdebugread.h.
10701         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10702         Declare.
10703         * elfread.c: Include mdebugread.h.
10704
10705 2019-01-09  Tom Tromey  <tom@tromey.com>
10706
10707         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10708         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10709         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10710         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10711         (psym_lookup_symbol, psym_find_last_source_symtab)
10712         (psym_forget_cached_source_info, psym_print_stats)
10713         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10714         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10715         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10716         (psym_find_compunit_symtab_by_address)
10717         (maintenance_print_psymbols, maintenance_info_psymtabs)
10718         (maintenance_check_psymtabs): Use ranged for.
10719         * psymtab.h (class objfile_psymtabs): New.
10720         (require_partial_symbols): Return objfile_psymtabs.
10721         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10722
10723 2019-01-09  Tom Tromey  <tom@tromey.com>
10724
10725         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10726         (find_pc_mapped_section, list_overlays_command)
10727         (map_overlay_command, unmap_overlay_command)
10728         (simple_overlay_update): Use all_objfiles.
10729         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10730         * printcmd.c (info_symbol_command): Use all_objfiles.
10731         * objfiles.h (ALL_OBJSECTIONS): Remove.
10732         * maint.c (maintenance_translate_address): Use all_objfiles.
10733         * gcore.c (gcore_create_callback): Use all_objfiles.
10734         (objfile_find_memory_regions): Likewise.
10735
10736 2019-01-09  Tom Tromey  <tom@tromey.com>
10737
10738         * symtab.c (find_line_symtab, info_sources_command)
10739         (make_source_files_completion_list): Use objfile_compunits.
10740         * source.c (select_source_symtab): Use objfile_compunits.
10741         * objfiles.h (struct objfile): Update comment.
10742         (ALL_OBJFILES): Remove.
10743         (ALL_FILETABS): Remove.
10744         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10745         objfile_compunits.
10746
10747 2019-01-09  Tom Tromey  <tom@tromey.com>
10748
10749         * symmisc.c (print_objfile_statistics, dump_objfile)
10750         (maintenance_print_symbols): Use compunit_filetabs.
10751         * source.c (forget_cached_source_info_for_objfile): Use
10752         compunit_filetabs.
10753         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10754         (ALL_FILETABS): Use compunit_filetabs.
10755         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10756         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10757
10758 2019-01-09  Tom Tromey  <tom@tromey.com>
10759
10760         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10761         (compunit_filetabs): New.
10762         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10763         compunit_filetabs.
10764         (info_sources_command, make_source_files_completion_list): Remove
10765         declaration.
10766         * symmisc.c (print_objfile_statistics, dump_objfile)
10767         (maintenance_print_symbols): Remove declaration.
10768         (maintenance_info_symtabs): Use compunit_filetabs.
10769         (maintenance_info_line_tables): Likewise.
10770         * source.c (select_source_symtab): Change local variable name.
10771         (forget_cached_source_info_for_objfile): Remove declaration.
10772         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10773         * objfiles.c (objfile_relocate1): Remove declaration.
10774         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10775         declaration.
10776         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10777         * coffread.c (coff_symtab_read): Remove declaration.
10778         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10779         compunit_filetabs.
10780
10781 2019-01-09  Tom Tromey  <tom@tromey.com>
10782
10783         * symtab.c (lookup_objfile_from_block)
10784         (find_pc_sect_compunit_symtab, search_symbols)
10785         (default_collect_symbol_completion_matches_break_on): Use
10786         objfile_compunits.
10787         * objfiles.h (ALL_COMPUNITS): Remove.
10788         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10789         * cp-support.c (add_symbol_overload_list_qualified): Use
10790         objfile_compunits.
10791         * ada-lang.c (ada_collect_symbol_completion_matches)
10792         (ada_add_global_exceptions): Use objfile_compunits.
10793
10794 2019-01-09  Tom Tromey  <tom@tromey.com>
10795
10796         * source.c (select_source_symtab)
10797         (forget_cached_source_info_for_objfile): Remove declaration.
10798         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10799         declaration.
10800         * maint.c (count_symtabs_and_blocks): Remove declaration.
10801         * cp-support.c (add_symbol_overload_list_qualified): Remove
10802         declaration.
10803         * coffread.c (coff_symtab_read): Remove declaration.
10804         * symtab.c (lookup_symbol_in_objfile_symtabs)
10805         (basic_lookup_transparent_type_1): Use objfile_compunits.
10806         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10807         (info_sources_command, search_symbols)
10808         (default_collect_symbol_completion_matches_break_on)
10809         (make_source_files_completion_list): Remove declaration.
10810         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10811         (ada_collect_symbol_completion_matches)
10812         (ada_add_global_exceptions): Remove declaration.
10813         * linespec.c (iterate_over_all_matching_symtabs): Use
10814         objfile_compunits.
10815         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10816         (class objfile_compunits): New.
10817         (ALL_COMPUNITS): Use objfile_compunits.
10818         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10819         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10820         objfile_compunits.
10821         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10822
10823 2019-01-09  Tom Tromey  <tom@tromey.com>
10824
10825         * symtab.c (search_symbols)
10826         (default_collect_symbol_completion_matches_break_on): Use
10827         objfile_msymbols.
10828         * ada-lang.c (ada_lookup_simple_minsym)
10829         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10830         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10831         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10832         objfile_msymbols.
10833         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10834         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10835         * objc-lang.c (find_methods): Use objfile_msymbols.
10836         (info_selectors_command, info_classes_command): Likewise.
10837         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10838         * objfiles.h (class objfile_msymbols): New.
10839         (ALL_OBJFILE_MSYMBOLS): Remove.
10840         (ALL_MSYMBOLS): Remove.
10841
10842 2019-01-09  Tom Tromey  <tom@tromey.com>
10843
10844         * common/next-iterator.h (next_adapter): Add Iterator template
10845         parameter.
10846         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10847         (class all_objfiles_safe): New.
10848         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10849         * objfiles.c (put_objfile_before): Update comment.
10850         (add_separate_debug_objfile): Likewise.
10851         (free_all_objfiles): Use all_objfiles_safe.
10852         (objfile_purge_solibs): Likewise.
10853
10854 2019-01-09  Tom Tromey  <tom@tromey.com>
10855
10856         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10857         (expand_symtab_containing_pc, lookup_static_symbol)
10858         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10859         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10860         all_objfiles.
10861         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10862         * breakpoint.c (create_overlay_event_breakpoint)
10863         (create_longjmp_master_breakpoint)
10864         (create_std_terminate_master_breakpoint)
10865         (create_exception_master_breakpoint): Use all_objfiles.
10866         * linux-thread-db.c (try_thread_db_load_from_pdir)
10867         (has_libpthread): Use all_objfiles.
10868         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10869         * linespec.c (iterate_over_all_matching_symtabs)
10870         (search_minsyms_for_name): Use all_objfiles.
10871         * maint.c (maintenance_info_sections): Use all_objfiles.
10872         * main.c (captured_main_1): Use all_objfiles.
10873         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10874         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10875         * guile/scm-pretty-print.c
10876         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10877         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10878         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10879         (maintenance_print_msymbols): Use all_objfiles.
10880         * source.c (select_source_symtab): Use all_objfiles.
10881         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10882         * symfile.c (remove_symbol_file_command)
10883         (expand_symtabs_matching, map_symbol_filenames): Use
10884         all_objfiles.
10885         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10886         all_objfiles.
10887         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10888         * objc-lang.c (find_methods): Use all_objfiles.
10889         * objfiles.c (have_partial_symbols, have_full_symbols)
10890         (have_minimal_symbols, qsort_cmp)
10891         (default_iterate_over_objfiles_in_search_order): Use
10892         all_objfiles.
10893         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10894         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10895         (maintenance_check_psymtabs): Use all_objfiles.
10896         (ALL_PSYMTABS): Remove.
10897         * compile/compile-object-run.c (do_module_cleanup): Use
10898         all_objfiles.
10899         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10900         * cp-support.c (add_symbol_overload_list_qualified): Use
10901         all_objfiles.
10902         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10903         Use all_objfiles.
10904         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10905         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10906         all_objfiles.
10907         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10908         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10909         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10910         Uses all_objfiles.
10911         * solib.c (solib_read_symbols): Use all_objfiles
10912
10913 2019-01-09  Tom Tromey  <tom@tromey.com>
10914
10915         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10916         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10917         all_objfiles.
10918         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10919         * symmisc.c (print_symbol_bcache_statistics)
10920         (print_objfile_statistics, maintenance_print_objfiles)
10921         (maintenance_info_symtabs, maintenance_check_symtabs)
10922         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10923         all_objfiles.
10924         * source.c (forget_cached_source_info): Use all_objfiles.
10925         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10926         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10927         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10928         * objfiles.c (update_section_map): Use all_objfiles.
10929         (shared_objfile_contains_address_p): Likewise.
10930         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10931         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10932
10933 2019-01-09  Tom Tromey  <tom@tromey.com>
10934
10935         * common/next-iterator.h: New file.
10936         * objfiles.h (class all_objfiles): New.
10937         (struct objfile_iterator): New.
10938
10939 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10940
10941         * NEWS: Move the description of the changed "frame", "select-frame",
10942          and "info frame" commands to the Changed commands section.
10943
10944 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10945
10946         * gdbtypes.c (check_stub_method_group): Remove handling of old
10947         mangling schemes.
10948         * linespec.c (find_methods): Likewise.
10949         * stabsread.c (read_member_functions): Likewise.
10950         * valops.c (search_struct_method): Likewise.
10951         (value_struct_elt_for_reference): Likewise.
10952         * NEWS: Mention this change.
10953
10954 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10955
10956         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10957         print_source_lines.
10958         * source.c (print_source_lines_base): Update line number check.
10959         (print_source_lines): New function.
10960         (source_lines_range::source_lines_range): New function.
10961         * source.h (class source_lines_range): New class.
10962         (print_source_lines): New declaration.
10963
10964 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10965
10966         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10967
10968 2019-01-08  Tom Tromey  <tom@tromey.com>
10969             Simon Marchi  <simon.marchi@ericsson.com>
10970
10971         PR gdb/24060
10972         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10973         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10974         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10975         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10976         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10977         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10978
10979 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10980
10981         * source.c (select_source_symtab): Move header comment to
10982         declaration in source.h.
10983         (forget_cached_source_info_for_objfile): Likewise.
10984         (forget_cached_source_info): Likewise.
10985         (identify_source_line): Likewise.
10986         * source.h (identify_source_line): Move declaration from symtab.h
10987         and add comment from source.c
10988         (print_source_lines): Likewise.
10989         (forget_cached_source_info_for_objfile): Likewise.
10990         (forget_cached_source_info): Likewise.
10991         (select_source_symtab): Likewise.
10992         (enum print_source_lines_flag): Move definition from symtab.h.
10993         * symtab.h (identify_source_line): Move declaration to source.h.
10994         (print_source_lines): Likewise.
10995         (forget_cached_source_info_for_objfile): Likewise.
10996         (forget_cached_source_info): Likewise.
10997         (select_source_symtab): Likewise.
10998         (enum print_source_lines_flag): Move definition to source.h.
10999         * tui/tui-hooks.c: Add 'source.h' include.
11000
11001 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11002
11003         * source.c (print_source_lines_base): Handle requests to print
11004         reverse line number sequences, and guard against empty lines
11005         string.
11006
11007 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11008
11009         * source.c (print_source_lines_base): Fix skip of '\r' if next
11010         character is '\n'.
11011
11012 2019-01-06  Tom Tromey  <tom@tromey.com>
11013
11014         * c-exp.y (struct c_parse_state) <macro_original_text,
11015         expansion_obstack>: New member.
11016         (macro_original_text, expansion_obstack): Remove globals.
11017         (scan_macro_expansion, scanning_macro_expansion)
11018         (finished_macro_expansion): Update.
11019         (scan_macro_cleanup): Remove.
11020         (yylex, c_parse): Update.
11021
11022 2019-01-06  Tom Tromey  <tom@tromey.com>
11023
11024         * c-exp.y (struct c_parse_state) <strings>: New member.
11025         (operator_stoken): Update.
11026
11027 2019-01-06  Tom Tromey  <tom@tromey.com>
11028
11029         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11030         (union type_stack_elt) <typelist_val>: Now a pointer to
11031         std::vector.
11032         (type_stack_cleanup): Don't declare.
11033         (push_typelist): Update.
11034         * parse.c (pop_typelist): Return a std::vector.
11035         (push_typelist): Take a std::vector.
11036         (follow_types): Update.  Do not free args.
11037         (type_stack_cleanup): Remove.
11038         * c-exp.y (struct c_parse_state): New.
11039         (cpstate): New global.
11040         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11041         (nonempty_typelist): Update.
11042         (func_mod): Create a new vector.
11043         (c_parse): Create a c_parse_state.
11044         (check_parameter_typelist): Do not delete params.
11045         (function_method): Update.  Do not delete type_list.
11046
11047 2019-01-06  Tom Tromey  <tom@tromey.com>
11048
11049         PR gdb/28155:
11050         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11051         check_typedef.
11052         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11053         (print_return_value): Likewise.
11054
11055 2019-01-05  Tom Tromey  <tom@tromey.com>
11056
11057         * contrib/cleanup_check.py: Remove.
11058         * contrib/gcc-with-excheck: Remove.
11059         * contrib/exsummary.py: Remove.
11060         * contrib/excheck.py: Remove.
11061
11062 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11063
11064         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11065         NULL. Initialize tpprev to NULL instead of assigning it
11066         to NULL on the next statement.
11067         * windows-nat.c (windows_delete_thread): Remove check for
11068         main_thread_id before printing thread exit notifications.
11069         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11070         Remove thread ID check against main_thread_id.
11071         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11072         windows_delete_thread.
11073         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11074
11075 2019-01-04  Tom Tromey  <tom@tromey.com>
11076
11077         * compile/compile.c (_initialize_compile): Use upper case for
11078         metasyntactic variables.
11079         * symmisc.c (_initialize_symmisc): Use upper case for
11080         metasyntactic variables.
11081         * psymtab.c (_initialize_psymtab): Use upper case for
11082         metasyntactic variables.
11083         * demangle.c (demangle_command): Use upper case for metasyntactic
11084         variables.
11085         (_initialize_demangler): Likewise.
11086         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11087         variables.
11088
11089 2019-01-03  Tom Tromey  <tom@tromey.com>
11090
11091         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11092
11093 2019-01-03  Tom Tromey  <tom@tromey.com>
11094
11095         * python/py-symtab.c (salpy_str): Update.
11096         (struct salpy_sal_object) <symtab>: Now a PyObject.
11097         (salpy_dealloc): Update.
11098         (del_objfile_sal): Use gdbpy_ref.
11099
11100 2019-01-03  Tom Tromey  <tom@tromey.com>
11101
11102         * python/py-type.c (convert_field): Use new_reference.  Return
11103         gdbpy_ref.
11104         (make_fielditem): Return gdbpy_ref.
11105         (typy_fields): Update.
11106         (typy_getitem): Update.
11107         (field_name): Return gdbpy_ref.  Use new_reference.
11108         (typy_iterator_iternext): Update.
11109
11110 2019-01-03  Tom Tromey  <tom@tromey.com>
11111
11112         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11113
11114 2019-01-03  Tom Tromey  <tom@tromey.com>
11115
11116         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11117         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11118         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11119         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11120         (pspy_set_type_printers): Likewise.
11121         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11122         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11123         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11124         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11125         (objfpy_set_type_printers): Likewise.
11126
11127 2019-01-03  Tom Tromey  <tom@tromey.com>
11128
11129         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11130         (gdbpy_print_stack): Use gdbpy_err_fetch.
11131         * python/python-internal.h (class gdbpy_err_fetch): New class.
11132         (class gdbpy_enter) <m_error_type, m_error_value,
11133         m_error_traceback>: Remove.
11134         <m_error>: New member.
11135         (gdbpy_exception_to_string): Don't declare.
11136         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11137         * python/py-value.c (convert_value_from_python): Use
11138         gdbpy_err_fetch.
11139         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11140         gdbpy_exception_to_string.
11141         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11142         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11143         gdbpy_err_fetch.
11144
11145 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11146
11147         * linux-nat.c (delete_lwp_cleanup): Delete.
11148         (struct lwp_deleter): New struct.
11149         (lwp_info_up): New typedef.
11150         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11151         lwp_info_up.
11152
11153 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11154
11155         * linux-fork.c (class scoped_switch_fork_info): New class.
11156         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11157
11158 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11159
11160         * valops.c (find_overload_match): Remove use of null_cleanup, and
11161         calls to do_cleanups.
11162
11163 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11164
11165         * compile/compile-cplus-types.c
11166         (compile_cplus_instance::decl_name): Handle changes to
11167         cp_func_name.
11168         * cp-support.c (cp_func_name): Update header comment, update
11169         return type.
11170         * cp-support.h (cp_func_name): Update return type in declaration.
11171         * valops.c (find_overload_match): Move temp_func local to top
11172         level of function and change its type.  Use temp_func to hold and
11173         delete temporary string obtained from cp_func_name.
11174
11175 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11176
11177         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11178         gdb::char_vector, remove cleanup, and update uses of `msg`.
11179
11180 2019-01-03  Jim Wilson  <jimw@sifive.com>
11181
11182         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11183
11184 2019-01-02  Tom Tromey  <tom@tromey.com>
11185
11186         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11187         (tdesc_parse_xml): Remove cleanups.
11188         * target-descriptions.h (make_cleanup_free_target_description):
11189         Don't declare.
11190         (target_desc_deleter): New struct.
11191         (target_desc_up): New typedef.
11192         * target-descriptions.c (target_desc_deleter::operator()): Rename
11193         from free_target_description.
11194         (make_cleanup_free_target_description): Remove.
11195
11196 2019-01-02  Tom Tromey  <tom@tromey.com>
11197
11198         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11199         constructor, destructor.
11200         (linespec_parser): Remove typedef.
11201         (~linespec_parser): Rename from linespec_parser_delete.
11202         (linespec_lex_to_end, linespec_complete_label)
11203         (linespec_complete): Update.
11204         (decode_line_full): Remove cleanups.
11205         (decode_line_1): Update.
11206
11207 2019-01-02  Tom Tromey  <tom@tromey.com>
11208
11209         * python/python-internal.h (inferior_to_inferior_object): Change
11210         return type.
11211         * python/py-exitedevent.c (create_exited_event_object): Update.
11212         * python/py-inferior.c (inferior_to_inferior_object): Return
11213         gdbpy_ref.
11214         (python_new_inferior, python_inferior_deleted)
11215         (thread_to_thread_object, delete_thread_object)
11216         (build_inferior_list, gdbpy_selected_inferior): Update.
11217         * python/py-infthread.c (create_thread_object): Update.  Also fail
11218         if inferior_to_inferior_object fails.
11219
11220 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11221
11222         * inferior.h (class inferior) <displaced_step_state>: New field.
11223         * infrun.h (struct displaced_step_state): Move here from
11224         infrun.c.  Initialize fields, add constructor.
11225         <inf>: Remove field.
11226         <reset>: New method.
11227         * infrun.c (struct displaced_step_inferior_state): Move to
11228         infrun.h.
11229         (displaced_step_inferior_states): Remove.
11230         (get_displaced_stepping_state): Adust.
11231         (displaced_step_in_progress_any_inferior): Adjust.
11232         (displaced_step_in_progress_thread): Adjust.
11233         (displaced_step_in_progress): Adjust.
11234         (add_displaced_stepping_state): Remove.
11235         (get_displaced_step_closure_by_addr): Adjust.
11236         (remove_displaced_stepping_state): Remove.
11237         (infrun_inferior_exit): Call displaced_step_state.reset.
11238         (use_displaced_stepping): Don't check for NULL.
11239         (displaced_step_prepare_throw): Call
11240         get_displaced_stepping_state.
11241         (displaced_step_fixup): Don't check for NULL.
11242         (prepare_for_detach): Don't check for NULL.
11243
11244 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11245
11246         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11247          in case of call that did not complete.
11248
11249 2019-01-02  Andrey Utkin  <autkin@undo.io>
11250
11251         * symfile.c (find_separate_debug_file): Fix search of debug files for
11252         remote debuggee.
11253
11254 2019-01-02  Tom Tromey  <tom@tromey.com>
11255
11256         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11257         indentation.
11258         * python/py-frame.c (frapy_older): Remove cast.
11259         (frapy_newer): Likewise.
11260         * python/py-breakpoint.c (local_setattro): Remove cast.
11261         * python/py-arch.c (archpy_name): Remove local variable.
11262         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11263
11264 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11265
11266         * unittests/basic_string_view/element_access/char/empty.cc:
11267         Fix year range in copyright header.
11268
11269 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11270
11271         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11272         Delete.
11273         <operator==>: Update with for removed field.
11274         <hash>: Likewise.
11275         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11276         <isa_features>: ...this.
11277         <abi_features>: New field.
11278         (riscv_isa_flen): Update comment.
11279         (riscv_abi_xlen): New declaration.
11280         (riscv_abi_flen): New declaration.
11281         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11282         isa_features.
11283         (riscv_abi_xlen): New function.
11284         (riscv_isa_flen): Update to get answer from isa_features.
11285         (riscv_abi_flen): New function.
11286         (riscv_has_fp_abi): Update to get answer from abi_features.
11287         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11288         xlen and flen.
11289         (riscv_call_info) <xlen, flen>: Update comment.
11290         (riscv_call_arg_struct): Remove invalid assertions
11291         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11292         is removed.
11293         (riscv_gdbarch_init): Gather isa features and abi features
11294         separately, ensure both match on the gdbarch when reusing an old
11295         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11296         a target with 64-bit float hardware.
11297
11298 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11299
11300         * source.c (search_command_helper): Stop reverse search
11301         when line 1 has been searched.
11302
11303 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11304
11305         * record-full.c (record_full_base_target::close): Rewrite
11306         record_full_core_buf_list free logic.
11307
11308 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11309
11310         * break-catch-syscall.c (print_one_catch_syscall): xfree
11311         the last text.
11312
11313 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11314
11315         * top.c (print_gdb_version): Update Copyright year in version
11316         message.
11317
11318 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11319
11320         Update copyright year range in all GDB files.
11321
11322 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11323
11324         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11325
11326 For older changes see ChangeLog-2018.
11327 \f
11328 Local Variables:
11329 mode: change-log
11330 left-margin: 8
11331 fill-column: 74
11332 version-control: never
11333 coding: utf-8
11334 End:
11335