Remove free_current_contents
[external/binutils.git] / gdb / ChangeLog
1 2019-03-06  Tom Tromey  <tom@tromey.com>
2
3         * utils.h (free_current_contents): Don't declare.
4         * utils.c (free_current_contents): Remove.
5
6 2019-03-06  Tom Tromey  <tom@tromey.com>
7
8         * top.c (quit_force): Update.
9         * main.c (captured_command_loop): Update.
10         * common/new-op.c (operator new): Update.
11         * common/common-exceptions.c (struct catcher)
12         <save_cleanup_chain>: Remove member.
13         (exceptions_state_mc_init): Update.
14         (exception_try_scope_entry): Return nullptr.
15         (exception_try_scope_exit, exception_rethrow)
16         (throw_exception_sjlj, throw_exception_cxx): Update.
17         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
18         (all_cleanups, do_cleanups, discard_cleanups)
19         (discard_final_cleanups, save_cleanups, save_final_cleanups)
20         (restore_cleanups, restore_final_cleanups): Don't declare.
21         (do_final_cleanups): Remove parameter.
22         * common/cleanups.c (cleanup_chain, make_cleanup)
23         (make_cleanup_dtor, all_cleanups, do_cleanups)
24         (discard_my_cleanups, discard_cleanups)
25         (discard_final_cleanups, save_my_cleanups, save_cleanups)
26         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
27         (null_cleanup): Remove.
28         (do_final_cleanups): Remove parameter.
29
30 2019-03-06  Tom Tromey  <tom@tromey.com>
31
32         * remote.c (remote_target::remote_parse_stop_reply): Use
33         unique_xmalloc_ptr.
34
35 2019-03-06  Tom Tromey  <tom@tromey.com>
36
37         * stabsread.c (struct stabs_field_info): Rename from field_info.
38         <list, fnlist>: Add initializers.
39         <obstack>: New member.
40         (read_member_functions, read_struct_fields, read_baseclasses):
41         Allocate on obstack.  Don't use cleanups.
42         (read_one_struct_field, read_member_functions, read_struct_fields)
43         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
44         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
45         (read_struct_type): Update.
46
47 2019-03-06  Tom Tromey  <tom@tromey.com>
48
49         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
50         * common/filestuff.h (make_cleanup_close): Don't declare.
51         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
52         Remove.
53
54 2019-03-06  Tom Tromey  <tom@tromey.com>
55
56         * solib-aix.c: Use make_scope_exit.
57
58 2019-03-06  Tom Tromey  <tom@tromey.com>
59
60         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
61         Use make_scope_exit.
62
63 2019-03-06  Tom Tromey  <tom@tromey.com>
64
65         * solib-svr4.c (disable_probes_interface): Remove parameter.
66         (svr4_handle_solib_event): Use make_scope_exit.
67
68 2019-03-06  Tom Tromey  <tom@tromey.com>
69
70         * remote.c (struct stop_reply_deleter): Remove.
71         (stop_reply_up): Update.
72         (struct stop_reply): Derive from notif_event.  Don't typedef.
73         <regcache>: Now a std::vector.
74         (stop_reply_xfree): Remove.
75         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
76         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
77         (remote_target::discard_pending_stop_replies): Use delete.
78         (remote_target::remote_parse_stop_reply): Update.
79         (remote_target::process_stop_reply): Update.
80         * remote-notif.h (struct notif_event): Add virtual destructor.
81         Remove "dtr" member.
82         (struct notif_client) <alloc_event>: Return a unique_ptr.
83         (notif_event_xfree): Don't declare.
84         (notif_event_up): New typedef.
85         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
86         (notif_event_xfree, do_notif_event_xfree): Remove.
87         (remote_notif_state_xfree): Update.
88
89 2019-03-06  Tom Tromey  <tom@tromey.com>
90
91         * infrun.c (displaced_step_clear_cleanup): Now a
92         forward_scope_exit type.
93         (displaced_step_prepare_throw): Update.
94         (displaced_step_fixup): Update.
95
96 2019-03-06  Tom Tromey  <tom@tromey.com>
97
98         * inferior.h (class inferior): Update comment.
99         * gdbthread.h (class thread_info): Update comment.
100
101 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
102             Tom Tromey  <tom@tromey.com>
103
104         * stabsread.h (struct stab_section_list): Remove.
105         (coffstab_build_psymtabs): Update.
106         * dbxread.c (symbuf_sections): Now a std::vector.
107         (sect_idx): New global.
108         (fill_symbuf): Update.
109         (coffstab_build_psymtabs): Change type of stabsects parameter.
110         Update.
111         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
112         std::vector.
113         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
114         (coff_locate_sections): Update.
115         (coff_symfile_read): Remove cleanups.  Update.
116         (init_stringtab): Add storage parameter.
117         (free_stringtab, free_stringtab_cleanup): Remove.
118         (init_lineno): Add storage parameter.
119         (free_linetab, free_linetab_cleanup): Remove.
120
121 2019-03-06  Pedro Alves  <palves@redhat.com>
122
123         * linux-fork.c (fork_info::clobber_regs): Delete.
124         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
125         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
126         comment.  Adjust.
127         (scoped_switch_fork_info::scoped_switch_fork_info)
128         (checkpoint_command, linux_fork_context): Adjust
129         fork_save_infrun_state calls.
130
131 2019-03-06  Pedro Alves  <palves@redhat.com>
132
133         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
134         (inf_has_multiple_threads): Return 'bool' and rewrite using
135         inferior_info::threads().
136
137 2019-03-06  Pedro Alves  <palves@redhat.com>
138
139         * linux-fork.c: Include <list>.
140         (fork_list): Now a std::list instance.
141         (fork_info): Add ctor, dtor, and in-class initialize all fields.
142         (forks_exist_p, find_last_fork): Adjust.
143         (new_fork): Delete.
144         (one_fork_p): New.
145         (add_fork): Adjust.
146         (free_fork): Delete, folded into fork_info::~fork_info().
147         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
148         Adjust.
149         (init_fork_list): Delete.
150         (linux_fork_killall, linux_fork_mourn_inferior)
151         (linux_fork_detach, info_checkpoints_command): Adjust.
152         (_initialize_linux_fork): No longer call init_fork_list.
153
154 2019-03-06  Pedro Alves  <palves@redhat.com>
155
156         * linux-fork.c (new_fork): New, split out of ...
157         (add_fork): ... this.  Return void.  Move "first fork" special
158         case from here, to ...
159         (checkpoint_command): ... here.
160         * linux-linux.h (add_fork): Return void.
161
162 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
163
164         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
165
166 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
167             Chris January  <chris.january@arm.com>
168             David Lecomber  <david.lecomber@arm.com>
169
170         * f-exp.y: New token, UNOP_INTRINSIC.
171         (exp): New pattern using UNOP_INTRINSIC token.
172         (f77_keywords): Add 'abs' keyword.
173         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
174         (value_from_host_double): New function.
175         (evaluate_subexp_f): Support UNOP_ABS.
176
177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
178
179         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
180         types.
181
182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
183
184         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
185         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
186         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
187
188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
189
190         * f-exp.y (convert_to_kind_type): Handle more type kinds.
191
192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
193             Chris January  <chris.january@arm.com>
194
195         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
196         * f-exp.y: Define 'KIND' token.
197         (exp): New pattern for KIND expressions.
198         (ptype): Handle types with a kind extension.
199         (direct_abs_decl): Extend to spot kind extensions.
200         (f77_keywords): Add 'kind' to the list.
201         (push_kind_type): New function.
202         (convert_to_kind_type): New function.
203         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
204         * parse.c (operator_length_standard): Likewise.
205         * parser-defs.h (enum type_pieces): Add tp_kind.
206         * std-operator.def: Add UNOP_KIND.
207
208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
209
210         * f-exp.y (f_parse): Set yydebug.
211
212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
213
214         * f-lang.c (evaluate_subexp_f): New function.
215         (exp_descriptor_f): New global.
216         (f_language_defn): Use exp_descriptor_f instead of
217         exp_descriptor_standard.
218
219 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
220
221         * f-exp.y (struct token): Add comments.
222         (dot_ops): Remove uppercase versions and the end marker.
223         (f77_keywords): Likewise.
224         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
225         entries in the dot_ops array are case insensitive, and use
226         strncasecmp to compare strings.  Also some whitespace cleanup in
227         this area.  Similar for the f77_keywords array, except entries in
228         this list might be case sensitive.
229
230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
231
232         * f-exp.y (struct f77_boolean_val): Add comments.
233         (boolean_values): Remove uppercase versions, and end marker.
234         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
235         and use strncasecmp to achieve case insensitivity.  Additionally,
236         perform whitespace cleanup around this code.
237
238 2019-03-06  Tom Tromey  <tromey@adacore.com>
239
240         * remote-sim.c (gdbsim_target_open): Use result of
241         gdb_argv::release.
242
243 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
244         Dirk Schubert  <dirk.schubert@arm.com>
245         Chris January  <chris.january@arm.com>
246
247         * eval.c (evaluate_subexp_standard): Call Fortran argument
248         wrapping logic.
249         * f-lang.c (struct value): A value which can be passed into a
250         Fortran function call.
251         (fortran_argument_convert): Wrap Fortran arguments in a pointer
252         where appropriate.
253         (struct type): Value ready for a Fortran function call.
254         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
255         is needed.
256         * f-lang.h (fortran_argument_convert): Declaration.
257         (fortran_preserve_arg_pointer): Declaration.
258         * infcall.c (value_arg_coerce): Call Fortran argument logic.
259
260 2019-03-05  Tom Tromey  <tromey@adacore.com>
261
262         * python/py-prettyprint.c (print_string_repr): Remove #if.
263         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
264
265 2019-03-05  Tom Tromey  <tromey@adacore.com>
266
267         * target.c (the_dummy_target): Move later.  Change type to
268         "dummy_target".
269         (initialize_targets): Don't initialize the_dummy_target.
270
271 2019-03-05  Tom Tromey  <tromey@adacore.com>
272
273         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
274         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
275
276 2019-03-05  Tom Tromey  <tromey@adacore.com>
277
278         * windows-nat.c (windows_nat_target::attach)
279         (windows_nat_target::detach): Don't call gdb_flush.
280         * valprint.c (generic_val_print, val_print, val_print_string):
281         Don't call gdb_flush.
282         * utils.c (defaulted_query): Don't call gdb_flush.
283         * typeprint.c (print_type_scalar): Don't call gdb_flush.
284         * target.c (target_announce_detach): Don't call gdb_flush.
285         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
286         * remote.c (extended_remote_target::attach): Don't call
287         gdb_flush.
288         * procfs.c (procfs_target::detach): Don't call gdb_flush.
289         * printcmd.c (do_examine): Don't call gdb_flush.
290         (info_display_command): Don't call gdb_flush.
291         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
292         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
293         * memattr.c (info_mem_command): Don't call gdb_flush.
294         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
295         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
296         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
297         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
298         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
299         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
300         (gnu_nat_target::detach): Don't call gdb_flush.
301         * f-valprint.c (f_val_print): Don't call gdb_flush.
302         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
303         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
304         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
305         gdb_flush.
306         * c-valprint.c (c_val_print): Don't call gdb_flush.
307         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
308
309 2019-03-05  Tom Tromey  <tromey@adacore.com>
310
311         * varobj.c (update_dynamic_varobj_children): Update.
312         (install_default_visualizer): Use reset, not release.
313         * value.c (set_internalvar): Update.
314         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
315         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
316         ATTRIBUTE_UNUSED_RESULT.
317
318 2019-03-05  Tom Tromey  <tromey@adacore.com>
319
320         * remote.c (class scoped_remote_fd) <release>: Add
321         ATTRIBUTE_UNUSED_RESULT.
322
323 2019-03-05  Tom Tromey  <tromey@adacore.com>
324
325         * macroexp.c (struct macro_buffer) <release>: Add
326         ATTRIBUTE_UNUSED_RESULT.
327
328 2019-03-05  Tom Tromey  <tromey@adacore.com>
329
330         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
331         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
332         ATTRIBUTE_UNUSED_RESULT.
333
334 2019-03-05  Tom Tromey  <tromey@adacore.com>
335
336         * common/scoped_fd.h (class scoped_fd) <release>: Add
337         ATTRIBUTE_UNUSED_RESULT.
338
339 2019-03-05  Tom Tromey  <tromey@adacore.com>
340
341         * parser-defs.h (struct parser_state) <release>: Add
342         ATTRIBUTE_UNUSED_RESULT.
343
344 2019-03-05  Tom Tromey  <tromey@adacore.com>
345
346         * utils.h (class gdb_argv) <release>: Add
347         ATTRIBUTE_UNUSED_RESULT.
348         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
349
350 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
351
352         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
353         for-loop range, to avoid compiler warnings.
354
355         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
356         avoid compiler warnings about unused variables.
357
358         * NEWS: Mention end of support for native debugging on MS-Windows
359         before XP.
360
361         PR gdb/24292
362         * common/netstuff.c:
363         * gdbserver/gdbreplay.c
364         * gdbserver/remote-utils.c:
365         * ser-tcp.c:
366         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
367         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
368         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
369         'getaddrinfo' and 'freeaddrinfo' were not available before
370         Windows XP, and mingw.org's MinGW headers by default define
371         _WIN32_WINNT to 0x500.
372
373 2019-03-01  Gary Benson <gbenson@redhat.com>
374
375         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
376
377 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
378             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
379
380         PR gdb/8527
381         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
382         set_sigint_trap, clear_sigint_trap.
383
384 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
385
386         * target.c (target_detach): Clear the regcache and the
387         frame cache.
388
389 2019-02-27  Pedro Alves  <palves@redhat.com>
390
391         * utils.c (set_screen_size): When we cap the height/width sizes,
392         tweak the corresponding command variable to show "unlimited":
393
394 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
395             Pedro Alves  <palves@redhat.com>
396
397         * utils.c (set_screen_size): Reduce "infinite" rows and columns
398         before calling rl_set_screen_size.
399
400 2019-02-27  Tom Tromey  <tromey@adacore.com>
401
402         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
403         define.
404         * python/py-value.c: Remove Python 2.4 workaround.
405         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
406         workaround.
407         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
408         Python 2.4 workaround.
409         * python/python-internal.h: Remove Python 2.4 comment.
410         (Py_ssize_t): Don't define.
411         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
412         (gdb_Py_DECREF): Remove Python 2.4 workaround.
413         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
414         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
415         * python/python.c (do_start_initialization): Remove Python 2.4
416         workaround.
417         * python/py-prettyprint.c (class dummy_python_frame): Remove.
418         (print_children): Remove Python 2.4 workaround.
419         * python/py-inferior.c (buffer_procs): Remove Python 2.4
420         workaround.
421         (CHARBUFFERPROC_NAME): Remove.
422         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
423         Python 2.4 workaround.
424
425 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
426
427         * NEWS: Note minimum Python version.
428
429 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
430
431         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
432         code from these functions.  Remove corresponding ifdefs.  Use
433         Py_buffer_up instead of explicit calls to PyBuffer_Release.
434         Remove gotos and target of gotos.
435         (infpy_search_memory): Likewise.
436
437 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
438
439         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
440         (hppa_gdbarch_init): Don't register deleted functions with
441         gdbarch.
442
443 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
444
445         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
446         (h8300_unwind_sp): Delete.
447         (h8300_dummy_id): Delete.
448         (h8300_gdbarch_init): Don't register deleted functions with
449         gdbarch.
450
451 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
452
453         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
454         (ft32_unwind_pc): Delete.
455         (ft32_unwind_sp): Delete.
456         (ft32_gdbarch_init): Don't register deleted functions with
457         gdbarch.
458
459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
460
461         * gdb/frv-tdep.c (frv_dummy_id): Delete.
462         (frv_unwind_pc): Delete.
463         (frv_unwind_sp): Delete.
464         (frv_gdbarch_init): Don't register deleted functions with
465         gdbarch.
466
467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
468
469         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
470         (riscv_unwind_pc): Delete.
471         (riscv_unwind_sp): Delete.
472         (riscv_gdbarch_init): Don't register deleted functions with
473         gdbarch.
474
475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
476
477         * gdb/csky-tdep.c (csky_dummy_id): Delete.
478         (csky_unwind_pc): Delete.
479         (csky_unwind_sp): Delete.
480         (csky_gdbarch_init): Don't register deleted functions with
481         gdbarch.
482
483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
484
485         * gdb/cris-tdep.c (cris_dummy_id): Delete.
486         (cris_unwind_pc): Delete.
487         (cris_unwind_sp): Delete.
488         (cris_gdbarch_init): Don't register deleted functions with
489         gdbarch.
490
491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
492
493         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
494         (bfin_unwind_pc): Delete.
495         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
496
497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
498
499         * gdb/arm-tdep.c (arm_dummy_id): Delete.
500         (arm_unwind_pc): Delete.
501         (arm_unwind_sp): Delete.
502         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
503
504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
505
506         * gdb/arc-tdep.c (arc_dummy_id): Delete.
507         (arc_unwind_pc): Delete.
508         (arc_unwind_sp): Delete.
509         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
510
511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
512
513         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
514         (alpha_unwind_pc): Delete.
515         (alpha_gdbarch_init): Don't register deleted functions with
516         gdbarch.
517
518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
519
520         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
521         (aarch64_unwind_pc): Delete.
522         (aarch64_unwind_sp): Delete.
523         (aarch64_gdbarch_init): Don't register deleted functions with
524         gdbarch.
525
526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
527
528         * gdbtypes.c (type_align): Don't consider static members when
529         computing structure alignment.
530
531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
532
533         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
534         return 0 for other types.
535         * arch-utils.c (default_type_align): Always return 0.
536         * gdbarch.h: Regenerate.
537         * gdbarch.sh (type_align): Extend comment.
538         * gdbtypes.c (type_align): Add additional comments, always call
539         gdbarch_type_align before applying the default rules.
540         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
541         generic code will then apply a suitable default.
542         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
543         types, return 0 for other types.
544
545 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
546
547         * NEWS: Create a new section for the next release branch.
548         Rename the section of the current branch, now that it has
549         been cut.
550
551 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
552
553         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
554         * version.in: Bump version to 8.3.50.DATE-git.
555
556 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
557
558         * aix-thread.c (ptid_cmp): Remove unused variable.
559         (get_signaled_thread): Likewise.
560         (store_regs_user_thread): Likewise.
561         (store_regs_kernel_thread): Likewise.
562         (fetch_regs_kernel_thread): Remove shadowed variable.
563
564 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
565
566         * features/riscv/32bit-cpu.xml: Add register numbers.
567         * features/riscv/32bit-fpu.c: Regenerate.
568         * features/riscv/32bit-fpu.xml: Add register numbers.
569         * features/riscv/64bit-cpu.xml: Add register numbers.
570         * features/riscv/64bit-fpu.c: Regenerate.
571         * features/riscv/64bit-fpu.xml: Add register numbers.
572
573 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
574
575         * NEWS: Mention two argument form of gdb.Value constructor.
576         * python/py-value.c (convert_buffer_and_type_to_value): New
577         function.
578         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
579         Add support for handling an optional second argument.  Call
580         convert_buffer_and_type_to_value as appropriate.
581         * python/python-internal.h (Py_buffer_deleter): New struct.
582         (Py_buffer_up): New typedef.
583
584 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
585
586         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
587         instead of releasing ownership.
588
589 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
590
591         * dwarf2read.c (open_and_init_dwp_file): Call
592         elf_numsections instead of bfd_count_sections to initialize
593         dwp_file->num_sections.
594
595 2019-02-25  Tom Tromey  <tromey@adacore.com>
596
597         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
598
599 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
600
601         * gcore.in: Add '--readnever' option when invoking GDB.
602
603 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
604
605         * MAINTAINERS: Update my email address.
606
607 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
608
609         * build-id.c (build_id_to_debug_bfd_1): New function.
610         (build_id_to_debug_bfd): Look for separate debug file in
611         sysroot.
612
613 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
614
615         * gdbarch.sh: Update the copyright year range that is placed into
616         generated files.
617
618 2019-02-22  Keith Seitz  <keiths@redhat.com>
619
620         PR symtab/23853
621         * linespec.c (create_sals_line_offset): Search for the default
622         symtab's filename instead of its fullname.
623
624 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
625
626         * NEWS: Update style defaults.
627
628 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
629
630         * main.c (captured_main_1): Disable styling in batch mode.
631
632 2019-02-20  Tom Tromey  <tom@tromey.com>
633
634         * symtab.c (symtab_symbol_info): Fix typos.
635
636 2019-02-20  Tom Tromey  <tromey@adacore.com>
637
638         * findcmd.c (_initialize_mem_search): Use upper case for
639         metasyntactic variables.
640
641 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
642
643         * aarch64-tdep.c (aarch64_add_reggroups): New function.
644         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
645
646 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
647
648         * top.h (source_file_name): Change to std::string.
649         * top.c (source_file_name): Likewise.
650         (command_line_input): Adjust.
651         * cli/cli-script.c (script_from_file): Adjust.
652
653 2019-02-19  Tom Tromey  <tromey@adacore.com>
654
655         * ravenscar-thread.c
656         (ravenscar_thread_target::update_thread_list): Don't call
657         ada_build_task_list.
658         * ada-lang.h (ada_build_task_list): Don't declare.
659         * ada-tasks.c (struct ada_tasks_inferior_data)
660         <task_list_valid_p>: Now bool.
661         (read_known_tasks, ada_task_list_changed)
662         (ada_tasks_invalidate_inferior_data): Update.
663         (read_known_tasks_array): Return bool.
664         (read_known_tasks_list): Likewise.
665         (read_known_tasks): Return void.
666         (ada_build_task_list): Now static.
667
668 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
669
670         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
671         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
672
673 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
674
675         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
676         variant for ada_tasks_pspace_data_handle and
677         ada_tasks_inferior_data_handle.
678         (ada_tasks_pspace_data_cleanup): New function.
679         (ada_tasks_inferior_data_cleanup): New function.
680
681 2019-02-17  Tom Tromey  <tom@tromey.com>
682
683         * macrotab.h (macro_source_fullname): Return a std::string.
684         * macrotab.c (macro_include, check_for_redefinition)
685         (macro_undef, macro_lookup_definition, foreach_macro)
686         (foreach_macro_in_scope): Update.
687         (macro_source_fullname): Return a std::string.
688         * macrocmd.c (show_pp_source_pos): Update.
689
690 2019-02-17  Tom Tromey  <tom@tromey.com>
691
692         * macrocmd.c (show_pp_source_pos): Style the file names.
693
694 2019-02-17  Tom Tromey  <tom@tromey.com>
695
696         PR tui/24197:
697         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
698
699 2019-02-17  Tom Tromey  <tom@tromey.com>
700
701         * ada-lang.c (user_select_syms): Use filtered printing.
702         * utils.c (wrap_style): New global.
703         (desired_style): Remove.
704         (emit_style_escape): Add stream parameter.
705         (set_output_style, reset_terminal_style, prompt_for_continue):
706         Update.
707         (flush_wrap_buffer): Only flush gdb_stdout.
708         (wrap_here): Set wrap_style.
709         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
710         treat escape sequences as a character.  Change when wrap buffer is
711         flushed.
712         (fputs_styled): Do not set the output style when the default is
713         requested.
714         * ui-style.h (struct ui_file_style) <is_default>: New method.
715         * source.c (print_source_lines_base): Emit escape sequences in one
716         piece.
717
718 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
719
720         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
721         integers and enumeration types.
722
723 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
724
725         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
726         instead of lookup_symbol_in_language
727         (do_exact_match): New function.
728         (ada_get_symbol_name_matcher): Return do_exact_match when
729         doing a verbatim match.
730
731 2019-02-15  Tom Tromey  <tromey@adacore.com>
732
733         * ravenscar-thread.c (ravenscar_thread_target::resume)
734         (ravenscar_thread_target::wait): Special case wildcard requests.
735
736 2019-02-15  Tom Tromey  <tromey@adacore.com>
737
738         * ravenscar-thread.c (base_ptid): Remove.
739         (struct ravenscar_thread_target) <close>: New method.
740         <m_base_ptid>: New member.
741         <update_inferior_ptid, active_task, task_is_currently_active,
742         runtime_initialized>: Declare methods.
743         <ravenscar_thread_target>: Add constructor.
744         (ravenscar_thread_target::task_is_currently_active)
745         (ravenscar_thread_target::update_inferior_ptid)
746         (ravenscar_runtime_initialized): Rename.  Now methods.
747         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
748         (ravenscar_thread_target::update_thread_list): Update.
749         (ravenscar_thread_target::active_task): Now method.
750         (ravenscar_thread_target::store_registers)
751         (ravenscar_thread_target::prepare_to_store)
752         (ravenscar_thread_target::prepare_to_store)
753         (ravenscar_thread_target::mourn_inferior): Update.
754         (ravenscar_inferior_created): Use "new" to create target.
755         (ravenscar_thread_target::get_ada_task_ptid): Update.
756         (_initialize_ravenscar): Don't initialize base_ptid.
757         (ravenscar_ops): Remove global.
758
759 2019-02-15  Tom Tromey  <tromey@adacore.com>
760
761         * target.h (push_target): Declare new overload.
762         * target.c (push_target): New overload, taking an rvalue reference.
763         * remote.c (remote_target::open_1): Use push_target overload.
764         * corelow.c (core_target_open): Use push_target overload.
765
766 2019-02-15  Tom Tromey  <tromey@adacore.com>
767
768         * ravenscar-thread.c (is_ravenscar_task)
769         (ravenscar_task_is_currently_active): Return bool.
770         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
771         (_initialize_ravenscar): Remove "(void)".
772         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
773         Return bool.
774
775 2019-02-15  Tom Tromey  <tromey@adacore.com>
776
777         * ravenscar-thread.c (ravenscar_runtime_initializer)
778         (has_ravenscar_runtime, get_running_thread_id)
779         (ravenscar_thread_target::resume): Fix indentation.
780
781 2019-02-15  Tom Tromey  <tromey@adacore.com>
782
783         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
784         from ravenscar_arch_ops.
785         (sparc_ravenscar_ops::fetch_registers)
786         (sparc_ravenscar_ops::store_registers): Now methods.
787         (sparc_ravenscar_prepare_to_store): Remove.
788         (sparc_ravenscar_ops): Redefine.
789         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
790         methods and destructor.  Remove members.
791         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
792         (ravenscar_thread_target::store_registers)
793         (ravenscar_thread_target::prepare_to_store): Update.
794         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
795         Remove.
796         (struct ppc_ravenscar_powerpc_ops): Derive from
797         ravenscar_arch_ops.
798         (ppc_ravenscar_powerpc_ops::fetch_registers)
799         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
800         (ppc_ravenscar_powerpc_ops): Redefine.
801         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
802         (ppc_ravenscar_e500_ops::fetch_registers)
803         (ppc_ravenscar_e500_ops::store_registers): Now methods.
804         (ppc_ravenscar_e500_ops): Redefine.
805         * aarch64-ravenscar-thread.c
806         (aarch64_ravenscar_generic_prepare_to_store): Remove.
807         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
808         (aarch64_ravenscar_fetch_registers)
809         (aarch64_ravenscar_store_registers): Now methods.
810         (aarch64_ravenscar_ops): Redefine.
811
812 2019-02-15  Tom Tromey  <tromey@adacore.com>
813
814         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
815         (ravenscar_thread_target::stopped_by_hw_breakpoint)
816         (ravenscar_thread_target::stopped_by_watchpoint)
817         (ravenscar_thread_target::stopped_data_address)
818         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
819
820 2019-02-15  Tom Tromey  <tromey@adacore.com>
821
822         * ravenscar-thread.c: Fix some typos.
823
824 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
825             Tom Tromey  <tromey@adacore.com>
826
827         * ada-lang.c (ada_exception_sal): Change addr_string to a
828         std::string.
829         (create_ada_exception_catchpoint): Update.
830
831 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
832             Tom Tromey  <tromey@adacore.com>
833
834         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
835         (bp_location_ops): Remove.
836         (base_breakpoint_allocate_location): Update.
837         (free_bp_location): Update.
838         * ada-lang.c (class ada_catchpoint_location)
839         <ada_catchpoint_location>: Remove ops parameter.
840         (ada_catchpoint_location_dtor): Remove.
841         (ada_catchpoint_location_ops): Remove.
842         (allocate_location_exception): Update.
843         * breakpoint.h (struct bp_location_ops): Remove.
844         (class bp_location) <bp_location>: Remove bp_location_ops
845         parameter.
846         <~bp_location>: Add destructor.
847         <ops>: Remove.
848
849 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
850             Pedro Alves  <palves@redhat.com>
851
852         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
853         'PATH_MAX'.
854
855 2019-02-14  David Michael  <fedora.dm0@gmail.com>
856             Samuel Thibault  <samuel.thibault@gnu.org>
857             Thomas Schwinge  <thomas@codesourcery.com>
858
859         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
860         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
861
862 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
863
864         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
865         (check_empty): Use "const char *".
866
867         * gnu-nat.c (gnu_nat_target::detach): Instead of
868         'detach_inferior (pid)' call
869         'detach_inferior (find_inferior_pid (pid))'.
870
871         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
872         'nat/fork-inferior.o'.
873         * gnu-nat.c: #include "nat/fork-inferior.h".
874
875         * gnu-nat.c (gnu_nat_target::detach): Instead of
876         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
877         * gnu-nat.h: #include "inf-child.h".
878         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
879         'i386_gnu_nat_target::fetch_registers'.
880         (gnu_store_registers): Rename/move to
881         'i386_gnu_nat_target::store_registers'.
882
883         * config/i386/nm-i386gnu.h: Don't "#include" any files.
884         * gnu-nat.h (mach_thread_info): New function.
885         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
886
887         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
888
889 2019-02-14  Frederic Konrad  <konrad@adacore.com>
890
891         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
892
893 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
894
895         * windows-nat.c (windows_add_thread): Add new parameter
896         "main_thread_p" with default value set to false.  Update
897         function documentation as well as all callers.
898         (windows_delete_thread): Likewise.
899         (fake_create_process): Update call to windows_add_thread.
900         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
901         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
902         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
903         call to windows_delete_thread.
904
905 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
906
907         * MAINTAINERS: Add Andrew Burgess as global maintainer.
908
909 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
910
911         * symfile.c (find_separate_debug_file): Use canonical path of
912         sysroot with child_path instead of gdb_sysroot if it is valid.
913
914 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
915
916         * symfile.c (find_separate_debug_file): Use child_path to
917         determine if an object file is under a sysroot.
918
919 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
920
921         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
922         unittests/child-path-selftests.c.
923         * common/pathstuff.c (child_path): New function.
924         * common/pathstuff.h (child_path): New prototype.
925         * unittests/child-path-selftests.c: New file.
926
927 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
928
929         * symfile.c (find_separate_debug_file): Look for separate debug
930         files in debug directories under the sysroot.
931
932 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
933
934         * symtab.h (struct minimal_symbol data_p): New const method.
935         (struct minimal_symbol text_p): Likewise.
936         * symtab.c (output_source_filename): Use file name style
937         to print file name.
938         (print_symbol_info): Likewise.
939         (print_msymbol_info): Use address style to print addresses.
940         Use function name style to print executable text symbols.
941         (expand_symtab_containing_pc): Use data_p.
942         (find_pc_sect_compunit_symtab): Likewise.
943
944 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
945
946         * breakpoint.c (describe_other_breakpoints): Use address style
947         to print addresses.
948         (say_where): Likewise.
949
950 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
951
952         * ada-typeprint.c (print_func_type): Print function name
953         style to print function name.
954         * c-typeprint.c (c_print_type_1): Likewise.
955
956 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
957
958         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
959         for execve.
960
961 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
962
963         * c-exp.y (direct_abs_decl): Use emplace_back to record the
964         type_stack.
965
966 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
967
968         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
969         TYPE_CODE_REF types.
970
971 2019-02-08  Jim Wilson  <jimw@sifive.com>
972
973         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
974         (riscv_linux_fregset): New.
975         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
976
977 2019-02-07  Tom Tromey  <tom@tromey.com>
978
979         * thread.c (thread_cancel_execution_command): Update.
980         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
981         methods.
982         (struct thread_fsm_ops): Remove.
983         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
984         (thread_fsm_should_stop, thread_fsm_return_value)
985         (thread_fsm_set_finished, thread_fsm_finished_p)
986         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
987         Don't declare.
988         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
989         * infrun.c (clear_proceed_status_thread)
990         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
991         (print_stop_event): Update.
992         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
993         Add constructor.
994         (step_command_fsm_ops): Remove.
995         (new_step_command_fsm): Remove.
996         (step_1): Update.
997         (step_command_fsm::should_stop): Rename from
998         step_command_fsm_should_stop.
999         (step_command_fsm::clean_up): Rename from
1000         step_command_fsm_clean_up.
1001         (step_command_fsm::do_async_reply_reason): Rename from
1002         step_command_fsm_async_reply_reason.
1003         (struct until_next_fsm): Inherit from thread_fsm.  Add
1004         constructor.
1005         (until_next_fsm_ops): Remove.
1006         (new_until_next_fsm): Remove.
1007         (until_next_fsm::should_stop): Rename from
1008         until_next_fsm_should_stop.
1009         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1010         (until_next_fsm::do_async_reply_reason): Rename from
1011         until_next_fsm_async_reply_reason.
1012         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1013         constructor.  Change type of breakpoint.
1014         (finish_command_fsm_ops): Remove.
1015         (new_finish_command_fsm): Remove.
1016         (finish_command_fsm::should_stop): Rename from
1017         finish_command_fsm_should_stop.
1018         (finish_command_fsm::clean_up): Rename from
1019         finish_command_fsm_clean_up.
1020         (finish_command_fsm::return_value): Rename from
1021         finish_command_fsm_return_value.
1022         (finish_command_fsm::do_async_reply_reason): Rename from
1023         finish_command_fsm_async_reply_reason.
1024         (finish_command): Update.
1025         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1026         Add constructor.
1027         (call_thread_fsm_ops): Remove.
1028         (call_thread_fsm::call_thread_fsm): Rename from
1029         new_call_thread_fsm.
1030         (call_thread_fsm::should_stop): Rename from
1031         call_thread_fsm_should_stop.
1032         (call_thread_fsm::should_notify_stop): Rename from
1033         call_thread_fsm_should_notify_stop.
1034         (run_inferior_call, call_function_by_hand_dummy): Update.
1035         * cli/cli-interp.c (should_print_stop_to_console): Update.
1036         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1037         Add constructor.  Change type of location_breakpoint,
1038         caller_breakpoint.
1039         (until_break_fsm_ops): Remove.
1040         (new_until_break_fsm): Remove.
1041         (until_break_fsm::should_stop): Rename from
1042         until_break_fsm_should_stop.
1043         (until_break_fsm::clean_up): Rename from
1044         until_break_fsm_clean_up.
1045         (until_break_fsm::do_async_reply_reason): Rename from
1046         until_break_fsm_async_reply_reason.
1047         (until_break_command): Update.
1048         * thread-fsm.c: Remove.
1049         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1050
1051 2019-02-07  Tom Tromey  <tom@tromey.com>
1052
1053         * yy-remap.h: Add include guard.
1054         * xtensa-tdep.h: Add include guard.
1055         * xcoffread.h: Rename include guard.
1056         * varobj-iter.h: Add include guard.
1057         * tui/tui.h: Rename include guard.
1058         * tui/tui-winsource.h: Rename include guard.
1059         * tui/tui-wingeneral.h: Rename include guard.
1060         * tui/tui-windata.h: Rename include guard.
1061         * tui/tui-win.h: Rename include guard.
1062         * tui/tui-stack.h: Rename include guard.
1063         * tui/tui-source.h: Rename include guard.
1064         * tui/tui-regs.h: Rename include guard.
1065         * tui/tui-out.h: Rename include guard.
1066         * tui/tui-layout.h: Rename include guard.
1067         * tui/tui-io.h: Rename include guard.
1068         * tui/tui-hooks.h: Rename include guard.
1069         * tui/tui-file.h: Rename include guard.
1070         * tui/tui-disasm.h: Rename include guard.
1071         * tui/tui-data.h: Rename include guard.
1072         * tui/tui-command.h: Rename include guard.
1073         * tic6x-tdep.h: Add include guard.
1074         * target/waitstatus.h: Rename include guard.
1075         * target/wait.h: Rename include guard.
1076         * target/target.h: Rename include guard.
1077         * target/resume.h: Rename include guard.
1078         * target-float.h: Rename include guard.
1079         * stabsread.h: Add include guard.
1080         * rs6000-tdep.h: Add include guard.
1081         * riscv-fbsd-tdep.h: Add include guard.
1082         * regformats/regdef.h: Rename include guard.
1083         * record.h: Rename include guard.
1084         * python/python.h: Rename include guard.
1085         * python/python-internal.h: Rename include guard.
1086         * python/py-stopevent.h: Rename include guard.
1087         * python/py-ref.h: Rename include guard.
1088         * python/py-record.h: Rename include guard.
1089         * python/py-record-full.h: Rename include guard.
1090         * python/py-record-btrace.h: Rename include guard.
1091         * python/py-instruction.h: Rename include guard.
1092         * python/py-events.h: Rename include guard.
1093         * python/py-event.h: Rename include guard.
1094         * procfs.h: Add include guard.
1095         * proc-utils.h: Add include guard.
1096         * p-lang.h: Add include guard.
1097         * or1k-tdep.h: Rename include guard.
1098         * observable.h: Rename include guard.
1099         * nto-tdep.h: Rename include guard.
1100         * nat/x86-linux.h: Rename include guard.
1101         * nat/x86-linux-dregs.h: Rename include guard.
1102         * nat/x86-gcc-cpuid.h: Add include guard.
1103         * nat/x86-dregs.h: Rename include guard.
1104         * nat/x86-cpuid.h: Rename include guard.
1105         * nat/ppc-linux.h: Rename include guard.
1106         * nat/mips-linux-watch.h: Rename include guard.
1107         * nat/linux-waitpid.h: Rename include guard.
1108         * nat/linux-ptrace.h: Rename include guard.
1109         * nat/linux-procfs.h: Rename include guard.
1110         * nat/linux-osdata.h: Rename include guard.
1111         * nat/linux-nat.h: Rename include guard.
1112         * nat/linux-namespaces.h: Rename include guard.
1113         * nat/linux-btrace.h: Rename include guard.
1114         * nat/glibc_thread_db.h: Rename include guard.
1115         * nat/gdb_thread_db.h: Rename include guard.
1116         * nat/gdb_ptrace.h: Rename include guard.
1117         * nat/fork-inferior.h: Rename include guard.
1118         * nat/amd64-linux-siginfo.h: Rename include guard.
1119         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1120         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1121         * nat/aarch64-linux.h: Rename include guard.
1122         * nat/aarch64-linux-hw-point.h: Rename include guard.
1123         * mn10300-tdep.h: Add include guard.
1124         * mips-linux-tdep.h: Add include guard.
1125         * mi/mi-parse.h: Rename include guard.
1126         * mi/mi-out.h: Rename include guard.
1127         * mi/mi-main.h: Rename include guard.
1128         * mi/mi-interp.h: Rename include guard.
1129         * mi/mi-getopt.h: Rename include guard.
1130         * mi/mi-console.h: Rename include guard.
1131         * mi/mi-common.h: Rename include guard.
1132         * mi/mi-cmds.h: Rename include guard.
1133         * mi/mi-cmd-break.h: Rename include guard.
1134         * m2-lang.h: Add include guard.
1135         * location.h: Rename include guard.
1136         * linux-record.h: Rename include guard.
1137         * linux-nat.h: Add include guard.
1138         * linux-fork.h: Add include guard.
1139         * i386-darwin-tdep.h: Rename include guard.
1140         * hppa-linux-offsets.h: Add include guard.
1141         * guile/guile.h: Rename include guard.
1142         * guile/guile-internal.h: Rename include guard.
1143         * gnu-nat.h: Rename include guard.
1144         * gdb-stabs.h: Rename include guard.
1145         * frv-tdep.h: Add include guard.
1146         * f-lang.h: Add include guard.
1147         * event-loop.h: Add include guard.
1148         * darwin-nat.h: Rename include guard.
1149         * cp-abi.h: Rename include guard.
1150         * config/sparc/nm-sol2.h: Rename include guard.
1151         * config/nm-nto.h: Rename include guard.
1152         * config/nm-linux.h: Add include guard.
1153         * config/i386/nm-i386gnu.h: Rename include guard.
1154         * config/djgpp/nl_types.h: Rename include guard.
1155         * config/djgpp/langinfo.h: Rename include guard.
1156         * compile/gcc-cp-plugin.h: Add include guard.
1157         * compile/gcc-c-plugin.h: Add include guard.
1158         * compile/compile.h: Rename include guard.
1159         * compile/compile-object-run.h: Rename include guard.
1160         * compile/compile-object-load.h: Rename include guard.
1161         * compile/compile-internal.h: Rename include guard.
1162         * compile/compile-cplus.h: Rename include guard.
1163         * compile/compile-c.h: Rename include guard.
1164         * common/xml-utils.h: Rename include guard.
1165         * common/x86-xstate.h: Rename include guard.
1166         * common/version.h: Rename include guard.
1167         * common/vec.h: Rename include guard.
1168         * common/tdesc.h: Rename include guard.
1169         * common/selftest.h: Rename include guard.
1170         * common/scoped_restore.h: Rename include guard.
1171         * common/scoped_mmap.h: Rename include guard.
1172         * common/scoped_fd.h: Rename include guard.
1173         * common/safe-iterator.h: Rename include guard.
1174         * common/run-time-clock.h: Rename include guard.
1175         * common/refcounted-object.h: Rename include guard.
1176         * common/queue.h: Rename include guard.
1177         * common/ptid.h: Rename include guard.
1178         * common/print-utils.h: Rename include guard.
1179         * common/preprocessor.h: Rename include guard.
1180         * common/pathstuff.h: Rename include guard.
1181         * common/observable.h: Rename include guard.
1182         * common/netstuff.h: Rename include guard.
1183         * common/job-control.h: Rename include guard.
1184         * common/host-defs.h: Rename include guard.
1185         * common/gdb_wait.h: Rename include guard.
1186         * common/gdb_vecs.h: Rename include guard.
1187         * common/gdb_unlinker.h: Rename include guard.
1188         * common/gdb_unique_ptr.h: Rename include guard.
1189         * common/gdb_tilde_expand.h: Rename include guard.
1190         * common/gdb_sys_time.h: Rename include guard.
1191         * common/gdb_string_view.h: Rename include guard.
1192         * common/gdb_splay_tree.h: Rename include guard.
1193         * common/gdb_setjmp.h: Rename include guard.
1194         * common/gdb_ref_ptr.h: Rename include guard.
1195         * common/gdb_optional.h: Rename include guard.
1196         * common/gdb_locale.h: Rename include guard.
1197         * common/gdb_assert.h: Rename include guard.
1198         * common/filtered-iterator.h: Rename include guard.
1199         * common/filestuff.h: Rename include guard.
1200         * common/fileio.h: Rename include guard.
1201         * common/environ.h: Rename include guard.
1202         * common/common-utils.h: Rename include guard.
1203         * common/common-types.h: Rename include guard.
1204         * common/common-regcache.h: Rename include guard.
1205         * common/common-inferior.h: Rename include guard.
1206         * common/common-gdbthread.h: Rename include guard.
1207         * common/common-exceptions.h: Rename include guard.
1208         * common/common-defs.h: Rename include guard.
1209         * common/common-debug.h: Rename include guard.
1210         * common/cleanups.h: Rename include guard.
1211         * common/buffer.h: Rename include guard.
1212         * common/btrace-common.h: Rename include guard.
1213         * common/break-common.h: Rename include guard.
1214         * cli/cli-utils.h: Rename include guard.
1215         * cli/cli-style.h: Rename include guard.
1216         * cli/cli-setshow.h: Rename include guard.
1217         * cli/cli-script.h: Rename include guard.
1218         * cli/cli-interp.h: Rename include guard.
1219         * cli/cli-decode.h: Rename include guard.
1220         * cli/cli-cmds.h: Rename include guard.
1221         * charset-list.h: Add include guard.
1222         * buildsym-legacy.h: Rename include guard.
1223         * bfin-tdep.h: Add include guard.
1224         * ax.h: Rename include guard.
1225         * arm-linux-tdep.h: Add include guard.
1226         * arm-fbsd-tdep.h: Add include guard.
1227         * arch/xtensa.h: Rename include guard.
1228         * arch/tic6x.h: Add include guard.
1229         * arch/i386.h: Add include guard.
1230         * arch/arm.h: Rename include guard.
1231         * arch/arm-linux.h: Rename include guard.
1232         * arch/arm-get-next-pcs.h: Rename include guard.
1233         * arch/amd64.h: Add include guard.
1234         * arch/aarch64-insn.h: Rename include guard.
1235         * arch-utils.h: Rename include guard.
1236         * annotate.h: Add include guard.
1237         * amd64-darwin-tdep.h: Rename include guard.
1238         * aarch64-linux-tdep.h: Add include guard.
1239         * aarch64-fbsd-tdep.h: Add include guard.
1240         * aarch32-linux-nat.h: Add include guard.
1241
1242 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1243
1244         * macrotab.c (macro_define_internal): New function that
1245         factorizes macro_define_object_internal and macro_define_function
1246         code.
1247         (macro_define_object_internal): Use macro_define_internal.
1248         (macro_define_function): Likewise.
1249
1250 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1251
1252         * macrocmd.c (extract_identifier): Return
1253         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1254         callers.
1255
1256 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1257
1258         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1259
1260 2019-02-05  Tom Tromey  <tom@tromey.com>
1261
1262         * target.c (target_stack::unpush): Move assertion earlier.
1263
1264 2019-01-30  Tom Tromey  <tom@tromey.com>
1265
1266         PR python/23615:
1267         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1268         (gdbpy_parse_and_eval): Likewise.
1269         * python/python-internal.h (gdbpy_allow_threads): New class.
1270
1271 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1272
1273         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1274         (aarch64_fbsd_fpregmap): Move earlier.
1275         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1276         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1277         instead of individual calls to trad_frame_set_reg_addr.
1278         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1279         earlier.
1280         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1281         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1282         instead of individual calls to trad_frame_set_reg_addr.
1283
1284 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1285
1286         * CONTRIBUTE: Replace contribution list with wiki link.
1287
1288 2019-01-25  Tom Tromey  <tom@tromey.com>
1289
1290         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1291
1292 2019-01-25  Tom Tromey  <tom@tromey.com>
1293
1294         * xtensa-linux-nat.c: Fix common/ includes.
1295         * xml-support.h: Fix common/ includes.
1296         * xml-support.c: Fix common/ includes.
1297         * x86-linux-nat.c: Fix common/ includes.
1298         * windows-nat.c: Fix common/ includes.
1299         * varobj.h: Fix common/ includes.
1300         * varobj.c: Fix common/ includes.
1301         * value.c: Fix common/ includes.
1302         * valops.c: Fix common/ includes.
1303         * utils.c: Fix common/ includes.
1304         * unittests/xml-utils-selftests.c: Fix common/ includes.
1305         * unittests/utils-selftests.c: Fix common/ includes.
1306         * unittests/unpack-selftests.c: Fix common/ includes.
1307         * unittests/tracepoint-selftests.c: Fix common/ includes.
1308         * unittests/style-selftests.c: Fix common/ includes.
1309         * unittests/string_view-selftests.c: Fix common/ includes.
1310         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1311         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1312         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1313         * unittests/rsp-low-selftests.c: Fix common/ includes.
1314         * unittests/parse-connection-spec-selftests.c: Fix common/
1315         includes.
1316         * unittests/optional-selftests.c: Fix common/ includes.
1317         * unittests/offset-type-selftests.c: Fix common/ includes.
1318         * unittests/observable-selftests.c: Fix common/ includes.
1319         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1320         * unittests/memrange-selftests.c: Fix common/ includes.
1321         * unittests/memory-map-selftests.c: Fix common/ includes.
1322         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1323         * unittests/function-view-selftests.c: Fix common/ includes.
1324         * unittests/environ-selftests.c: Fix common/ includes.
1325         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1326         * unittests/common-utils-selftests.c: Fix common/ includes.
1327         * unittests/cli-utils-selftests.c: Fix common/ includes.
1328         * unittests/array-view-selftests.c: Fix common/ includes.
1329         * ui-file.c: Fix common/ includes.
1330         * tui/tui-io.c: Fix common/ includes.
1331         * tracepoint.h: Fix common/ includes.
1332         * tracepoint.c: Fix common/ includes.
1333         * tracefile-tfile.c: Fix common/ includes.
1334         * top.h: Fix common/ includes.
1335         * top.c: Fix common/ includes.
1336         * thread.c: Fix common/ includes.
1337         * target/waitstatus.h: Fix common/ includes.
1338         * target/waitstatus.c: Fix common/ includes.
1339         * target.h: Fix common/ includes.
1340         * target.c: Fix common/ includes.
1341         * target-memory.c: Fix common/ includes.
1342         * target-descriptions.c: Fix common/ includes.
1343         * symtab.h: Fix common/ includes.
1344         * symfile.c: Fix common/ includes.
1345         * stap-probe.c: Fix common/ includes.
1346         * spu-linux-nat.c: Fix common/ includes.
1347         * sparc-nat.c: Fix common/ includes.
1348         * source.c: Fix common/ includes.
1349         * solib.c: Fix common/ includes.
1350         * solib-target.c: Fix common/ includes.
1351         * ser-unix.c: Fix common/ includes.
1352         * ser-tcp.c: Fix common/ includes.
1353         * ser-pipe.c: Fix common/ includes.
1354         * ser-base.c: Fix common/ includes.
1355         * selftest-arch.c: Fix common/ includes.
1356         * s12z-tdep.c: Fix common/ includes.
1357         * rust-exp.y: Fix common/ includes.
1358         * rs6000-aix-tdep.c: Fix common/ includes.
1359         * riscv-tdep.c: Fix common/ includes.
1360         * remote.c: Fix common/ includes.
1361         * remote-notif.h: Fix common/ includes.
1362         * remote-fileio.h: Fix common/ includes.
1363         * remote-fileio.c: Fix common/ includes.
1364         * regcache.h: Fix common/ includes.
1365         * regcache.c: Fix common/ includes.
1366         * record-btrace.c: Fix common/ includes.
1367         * python/python.c: Fix common/ includes.
1368         * python/py-type.c: Fix common/ includes.
1369         * python/py-inferior.c: Fix common/ includes.
1370         * progspace.h: Fix common/ includes.
1371         * producer.c: Fix common/ includes.
1372         * procfs.c: Fix common/ includes.
1373         * proc-api.c: Fix common/ includes.
1374         * printcmd.c: Fix common/ includes.
1375         * ppc-linux-nat.c: Fix common/ includes.
1376         * parser-defs.h: Fix common/ includes.
1377         * osdata.c: Fix common/ includes.
1378         * obsd-nat.c: Fix common/ includes.
1379         * nat/x86-linux.c: Fix common/ includes.
1380         * nat/x86-linux-dregs.c: Fix common/ includes.
1381         * nat/x86-dregs.h: Fix common/ includes.
1382         * nat/x86-dregs.c: Fix common/ includes.
1383         * nat/ppc-linux.c: Fix common/ includes.
1384         * nat/mips-linux-watch.h: Fix common/ includes.
1385         * nat/mips-linux-watch.c: Fix common/ includes.
1386         * nat/linux-waitpid.c: Fix common/ includes.
1387         * nat/linux-ptrace.h: Fix common/ includes.
1388         * nat/linux-ptrace.c: Fix common/ includes.
1389         * nat/linux-procfs.c: Fix common/ includes.
1390         * nat/linux-personality.c: Fix common/ includes.
1391         * nat/linux-osdata.c: Fix common/ includes.
1392         * nat/linux-namespaces.c: Fix common/ includes.
1393         * nat/linux-btrace.h: Fix common/ includes.
1394         * nat/linux-btrace.c: Fix common/ includes.
1395         * nat/fork-inferior.c: Fix common/ includes.
1396         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1397         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1398         * nat/aarch64-linux.c: Fix common/ includes.
1399         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1400         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1401         * namespace.h: Fix common/ includes.
1402         * mips-linux-tdep.c: Fix common/ includes.
1403         * minsyms.c: Fix common/ includes.
1404         * mi/mi-parse.h: Fix common/ includes.
1405         * mi/mi-main.c: Fix common/ includes.
1406         * mi/mi-cmd-env.c: Fix common/ includes.
1407         * memrange.h: Fix common/ includes.
1408         * memattr.c: Fix common/ includes.
1409         * maint.h: Fix common/ includes.
1410         * maint.c: Fix common/ includes.
1411         * main.c: Fix common/ includes.
1412         * machoread.c: Fix common/ includes.
1413         * location.c: Fix common/ includes.
1414         * linux-thread-db.c: Fix common/ includes.
1415         * linux-nat.c: Fix common/ includes.
1416         * linux-fork.c: Fix common/ includes.
1417         * inline-frame.c: Fix common/ includes.
1418         * infrun.c: Fix common/ includes.
1419         * inflow.c: Fix common/ includes.
1420         * inferior.h: Fix common/ includes.
1421         * inferior.c: Fix common/ includes.
1422         * infcmd.c: Fix common/ includes.
1423         * inf-ptrace.c: Fix common/ includes.
1424         * inf-child.c: Fix common/ includes.
1425         * ia64-linux-nat.c: Fix common/ includes.
1426         * i387-tdep.c: Fix common/ includes.
1427         * i386-tdep.c: Fix common/ includes.
1428         * i386-linux-tdep.c: Fix common/ includes.
1429         * i386-linux-nat.c: Fix common/ includes.
1430         * i386-go32-tdep.c: Fix common/ includes.
1431         * i386-fbsd-tdep.c: Fix common/ includes.
1432         * i386-fbsd-nat.c: Fix common/ includes.
1433         * guile/scm-type.c: Fix common/ includes.
1434         * guile/guile.c: Fix common/ includes.
1435         * go32-nat.c: Fix common/ includes.
1436         * gnu-nat.c: Fix common/ includes.
1437         * gdbthread.h: Fix common/ includes.
1438         * gdbarch-selftests.c: Fix common/ includes.
1439         * gdb_usleep.c: Fix common/ includes.
1440         * gdb_select.h: Fix common/ includes.
1441         * gdb_bfd.c: Fix common/ includes.
1442         * gcore.c: Fix common/ includes.
1443         * fork-child.c: Fix common/ includes.
1444         * findvar.c: Fix common/ includes.
1445         * fbsd-nat.c: Fix common/ includes.
1446         * event-top.c: Fix common/ includes.
1447         * event-loop.c: Fix common/ includes.
1448         * dwarf2read.c: Fix common/ includes.
1449         * dwarf2loc.c: Fix common/ includes.
1450         * dwarf2-frame.c: Fix common/ includes.
1451         * dwarf-index-cache.c: Fix common/ includes.
1452         * dtrace-probe.c: Fix common/ includes.
1453         * disasm-selftests.c: Fix common/ includes.
1454         * defs.h: Fix common/ includes.
1455         * csky-tdep.c: Fix common/ includes.
1456         * cp-valprint.c: Fix common/ includes.
1457         * cp-support.h: Fix common/ includes.
1458         * cp-support.c: Fix common/ includes.
1459         * corelow.c: Fix common/ includes.
1460         * completer.h: Fix common/ includes.
1461         * completer.c: Fix common/ includes.
1462         * compile/compile.c: Fix common/ includes.
1463         * compile/compile-loc2c.c: Fix common/ includes.
1464         * compile/compile-cplus-types.c: Fix common/ includes.
1465         * compile/compile-cplus-symbols.c: Fix common/ includes.
1466         * command.h: Fix common/ includes.
1467         * cli/cli-dump.c: Fix common/ includes.
1468         * cli/cli-cmds.c: Fix common/ includes.
1469         * charset.c: Fix common/ includes.
1470         * build-id.c: Fix common/ includes.
1471         * btrace.h: Fix common/ includes.
1472         * btrace.c: Fix common/ includes.
1473         * breakpoint.h: Fix common/ includes.
1474         * breakpoint.c: Fix common/ includes.
1475         * ax.h: 
1476         (enum agent_op): Fix common/ includes.
1477         * ax-general.c (struct aop_map): Fix common/ includes.
1478         * ax-gdb.c: Fix common/ includes.
1479         * auxv.c: Fix common/ includes.
1480         * auto-load.c: Fix common/ includes.
1481         * arm-tdep.c: Fix common/ includes.
1482         * arch/riscv.c: Fix common/ includes.
1483         * arch/ppc-linux-common.c: Fix common/ includes.
1484         * arch/i386.c: Fix common/ includes.
1485         * arch/arm.c: Fix common/ includes.
1486         * arch/arm-linux.c: Fix common/ includes.
1487         * arch/arm-get-next-pcs.c: Fix common/ includes.
1488         * arch/amd64.c: Fix common/ includes.
1489         * arch/aarch64.c: Fix common/ includes.
1490         * arch/aarch64-insn.c: Fix common/ includes.
1491         * arch-utils.c: Fix common/ includes.
1492         * amd64-windows-tdep.c: Fix common/ includes.
1493         * amd64-tdep.c: Fix common/ includes.
1494         * amd64-sol2-tdep.c: Fix common/ includes.
1495         * amd64-obsd-tdep.c: Fix common/ includes.
1496         * amd64-nbsd-tdep.c: Fix common/ includes.
1497         * amd64-linux-tdep.c: Fix common/ includes.
1498         * amd64-linux-nat.c: Fix common/ includes.
1499         * amd64-fbsd-tdep.c: Fix common/ includes.
1500         * amd64-fbsd-nat.c: Fix common/ includes.
1501         * amd64-dicos-tdep.c: Fix common/ includes.
1502         * amd64-darwin-tdep.c: Fix common/ includes.
1503         * agent.c: Fix common/ includes.
1504         * ada-lang.h: Fix common/ includes.
1505         * ada-lang.c: Fix common/ includes.
1506         * aarch64-tdep.c: Fix common/ includes.
1507
1508 2019-01-25  Tom Tromey  <tom@tromey.com>
1509
1510         * common/create-version.sh: Use common/version.h.
1511
1512 2019-01-24  Pedro Alves  <palves@redhat.com>
1513
1514         * infrun.c (signal_stop, signal_print, signal_program)
1515         (signal_catch, signal_pass): Now arrays instead of pointers.
1516         (update_signals_program_target, do_target_resume)
1517         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1518         * linux-nat.c (linux_nat_target::pass_signals)
1519         (linux_nat_target::create_inferior, linux_nat_target::attach):
1520         Adjust.
1521         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1522         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1523         * procfs.c (procfs_target::pass_signals): Adjust.
1524         * record-full.c (record_full_target::resume): Adjust.
1525         * remote.c (remote_target::pass_signals)
1526         (remote_target::program_signals): Adjust.
1527         * target-debug.h (target_debug_print_signals): Now takes a
1528         gdb::array_view as parameter.  Adjust.
1529         * target.h (target_ops) <pass_signals, program_signals>: Replace
1530         pointer and length parameters with gdb::array_view.
1531         (target_pass_signals, target_program_signals): Likewise.
1532         * target-delegates.c: Regenerate.
1533
1534 2019-01-24  Pedro Alves  <palves@redhat.com>
1535
1536         * common/forward-scope-exit.h
1537         (forward_scope_exit::forward_scope_exit): Pass arguments to
1538         m_bind_function directly, instead of creating a std::bind and
1539         copying that.
1540
1541 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1542
1543         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1544         for static members.
1545         (pass_in_v_vfp_candidate): Likewise.
1546
1547 2019-01-23  Tom Tromey  <tom@tromey.com>
1548             Pedro Alves  <palves@redhat.com>
1549
1550         * regcache.c (class regcache_invalidator): Remove.
1551         (regcache::raw_write): Use make_scope_exit.
1552
1553 2019-01-23  Tom Tromey  <tom@tromey.com>
1554
1555         * ui-out.h (class ui_out_emit_type): Update comment.
1556
1557 2019-01-23  Tom Tromey  <tom@tromey.com>
1558
1559         * infrun.c (fetch_inferior_event): Update comment.
1560
1561 2019-01-23  Tom Tromey  <tom@tromey.com>
1562             Pedro Alves  <palves@redhat.com>
1563
1564         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1565         parameter.
1566         (fetch_inferior_event): Use SCOPE_EXIT.
1567
1568
1569 2019-01-23  Tom Tromey  <tom@tromey.com>
1570             Pedro Alves  <palves@redhat.com>
1571
1572         * infrun.c (disable_thread_events): Delete.
1573         (stop_all_threads): Use SCOPE_EXIT.
1574
1575 2019-01-23  Tom Tromey  <tom@tromey.com>
1576             Pedro Alves  <palves@redhat.com>
1577
1578         * symfile.c: Include forward-scope-exit.h.
1579         (clear_symtab_users_cleanup): Replace forward declaration with
1580         a FORWARD_SCOPE_EXIT.
1581         (syms_from_objfile_1): Use the forward_scope_exit and
1582         gdb::optional instead of cleanup_function.
1583         (reread_symbols): Use the forward_scope_exit instead of
1584         cleanup_function.
1585         (clear_symtab_users_cleanup): Remove function.
1586
1587 2019-01-23  Tom Tromey  <tom@tromey.com>
1588             Pedro Alves  <palves@redhat.com>
1589
1590         * linux-nat.c: Include scope-exit.h.
1591         (cleanup_target_stop): Remove.
1592         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1593         SCOPE_EXIT.
1594
1595 2019-01-23  Tom Tromey  <tom@tromey.com>
1596             Pedro Alves  <palves@redhat.com>
1597
1598         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1599         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1600
1601 2019-01-23  Tom Tromey  <tom@tromey.com>
1602             Andrew Burgess  <andrew.burgess@embecosm.com>
1603             Pedro Alves  <palves@redhat.com>
1604
1605         * infrun.c (fetch_inferior_event): Use scope_exit.
1606         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1607         * top.c (execute_command): Use scope_exit.
1608         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1609         * utils.c (do_bpstat_clear_actions_cleanup)
1610         (make_bpstat_clear_actions_cleanup): Remove.
1611
1612 2019-01-23  Tom Tromey  <tom@tromey.com>
1613             Pedro Alves  <palves@redhat.com>
1614
1615         * infrun.c: Include "common/scope-exit.h"
1616         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1617         (wait_for_inferior): Use SCOPE_EXIT.
1618         (fetch_inferior_event): Use scope_exit.
1619
1620 2019-01-23  Tom Tromey  <tom@tromey.com>
1621             Pedro Alves  <palves@redhat.com>
1622
1623         * breakpoint.c (create_breakpoint): Remove cleanup.
1624
1625 2019-01-23  Tom Tromey  <tom@tromey.com>
1626             Andrew Burgess  <andrew.burgess@embecosm.com>
1627             Pedro Alves  <palves@redhat.com>
1628
1629 2019-01-23  Pedro Alves  <palves@redhat.com>
1630
1631         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1632
1633 2019-01-23  Pedro Alves  <palves@redhat.com>
1634             Andrew Burgess  <andrew.burgess@embecosm.com>
1635
1636         * gdbthread.h: Include "common/forward-scope-exit.h".
1637         (scoped_finish_thread_state): Redefine custom class in terms of
1638         forward_scope_exit.
1639
1640 2019-01-23  Pedro Alves  <palves@redhat.com>
1641             Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * common/forward-scope-exit.h: New file.
1644
1645 2019-01-23  Pedro Alves  <palves@redhat.com>
1646             Andrew Burgess  <andrew.burgess@embecosm.com>
1647             Tom Tromey  <tom@tromey.com>
1648
1649         * common/scope-exit.h: New file.
1650
1651 2019-01-23  Pedro Alves  <palves@redhat.com>
1652
1653         * common/preprocessor.h (ESC): Rename to ...
1654         (ESC_PARENS): ... this.
1655         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1656         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1657
1658 2019-01-23  Tom Tromey  <tom@tromey.com>
1659
1660         * language.h (class scoped_switch_to_sym_language_if_auto):
1661         Initialize m_lang in both cases.
1662
1663 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1664
1665         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1666         with XCNEW.
1667
1668 2019-01-22  Tom Tromey  <tom@tromey.com>
1669
1670         * corelow.c: Do not include sys/file.h.
1671
1672 2019-01-22  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-wingeneral.h: Include gdb_curses.h.
1675
1676 2019-01-22  Tom Tromey  <tom@tromey.com>
1677
1678         * source-cache.h (class source_cache) <get_source_lines,
1679         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1680
1681 2019-01-22  Tom Tromey  <tom@tromey.com>
1682
1683         * remote-fileio.h (struct remote_target): Declare.
1684
1685 2019-01-22  Tom Tromey  <tom@tromey.com>
1686
1687         * python/py-arch.c: Do not include py-ref.h.
1688         * python/py-bpevent.c: Do not include py-ref.h.
1689         * python/py-cmd.c: Do not include py-ref.h.
1690         * python/py-continueevent.c: Do not include py-ref.h.
1691         * python/py-event.h: Do not include py-ref.h.
1692         * python/py-evtregistry.c: Do not include py-ref.h.
1693         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1694         * python/py-frame.c: Do not include py-ref.h.
1695         * python/py-framefilter.c: Do not include py-ref.h.
1696         * python/py-function.c: Do not include py-ref.h.
1697         * python/py-infevents.c: Do not include py-ref.h.
1698         * python/py-linetable.c: Do not include py-ref.h.
1699         * python/py-objfile.c: Do not include py-ref.h.
1700         * python/py-param.c: Do not include py-ref.h.
1701         * python/py-prettyprint.c: Do not include py-ref.h.
1702         * python/py-progspace.c: Do not include py-ref.h.
1703         * python/py-symbol.c: Do not include py-ref.h.
1704         * python/py-symtab.c: Do not include py-ref.h.
1705         * python/py-type.c: Do not include py-ref.h.
1706         * python/py-unwind.c: Do not include py-ref.h.
1707         * python/py-utils.c: Do not include py-ref.h.
1708         * python/py-value.c: Do not include py-ref.h.
1709         * python/py-varobj.c: Do not include py-ref.h.
1710         * python/py-xmethods.c: Do not include py-ref.h.
1711         * python/python.c: Do not include py-ref.h.
1712         * varobj.c: Do not include py-ref.h.
1713
1714 2019-01-22  Tom Tromey  <tom@tromey.com>
1715
1716         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1717         keyword for bcache.
1718
1719 2019-01-22  Tom Tromey  <tom@tromey.com>
1720
1721         * compile/compile-cplus-types.c: Remove a comment by #include.
1722
1723 2019-01-22  Tom Tromey  <tom@tromey.com>
1724
1725         * compile/gcc-c-plugin.h: Include compile-internal.h.
1726
1727 2019-01-22  Tom Tromey  <tom@tromey.com>
1728
1729         * stabsread.c (EXTERN): Do not define.
1730         (symnum, next_symbol_text_func, processing_gcc_compilation)
1731         (within_function, global_sym_chain, global_stabs)
1732         (previous_stab_code, this_object_header_files)
1733         (n_this_object_header_files)
1734         (n_allocated_this_object_header_files): Define.
1735         * stabsread.h (EXTERN): Never define.  Use "extern".
1736
1737 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1738
1739         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1740         history_value.
1741
1742 2019-01-21  Tom Tromey  <tom@tromey.com>
1743
1744         * ui-out.c: Fix includes.
1745         * tui/tui-source.c: Fix includes.
1746         * target.c: Fix includes.
1747         * remote.c: Fix includes.
1748         * regcache.c: Fix includes.
1749         * python/py-block.c: Fix includes.
1750         * printcmd.c: Fix includes.
1751         * or1k-tdep.c: Fix includes.
1752         * mi/mi-main.c: Fix includes.
1753         * m32r-tdep.c: Fix includes.
1754         * csky-tdep.c: Fix includes.
1755         * compile/compile-cplus-types.c: Fix includes.
1756         * cli/cli-interp.c: Fix includes.
1757
1758 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1759
1760         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1761         for padding.
1762
1763 2019-01-16  Tom Tromey  <tom@tromey.com>
1764
1765         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1766         earlier.
1767         (struct objfile) <msymbols_range>: Move from top level.
1768         <msymbols>: New method.
1769         (class objfile_msymbols): Remove.
1770         * symtab.c (default_collect_symbol_completion_matches_break_on):
1771         Update.
1772         * symmisc.c (dump_msymbols): Update.
1773         * stabsread.c (scan_file_globals): Update.
1774         * objc-lang.c (info_selectors_command, info_classes_command)
1775         (find_methods): Update.
1776         * minsyms.c (find_solib_trampoline_target): Update.
1777         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1778         * coffread.c (coff_symfile_read): Update.
1779         * ada-lang.c (ada_lookup_simple_minsym)
1780         (ada_collect_symbol_completion_matches): Update.
1781
1782 2019-01-16  Tom Tromey  <tom@tromey.com>
1783
1784         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1785         type.  Remove no-argument constructor.
1786         <iterator::operator++>: Simplify.
1787         <begin>: Update.
1788         <end>: Use minimal_symbol_count.
1789
1790 2019-01-16  Tom Tromey  <tom@tromey.com>
1791
1792         * objfiles.h (struct objfile) <psymtabs>: New method.
1793         (class objfile_psymtabs): Remove.
1794         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1795         typedef.
1796         <range>: New method.
1797         (require_partial_symbols): Change return type.
1798         * psymtab.c (require_partial_symbols)
1799         (psym_expand_symtabs_matching): Update.
1800         * mdebugread.c (parse_partial_symbols): Update.
1801         * dbxread.c (dbx_end_psymtab): Update.
1802
1803 2019-01-15  Tom Tromey  <tom@tromey.com>
1804
1805         * symtab.c (lookup_objfile_from_block)
1806         (lookup_symbol_in_objfile_symtabs)
1807         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1808         (find_line_symtab, info_sources_command)
1809         (default_collect_symbol_completion_matches_break_on)
1810         (make_source_files_completion_list): Update.
1811         * symmisc.c (print_objfile_statistics, dump_objfile)
1812         (maintenance_print_symbols, maintenance_info_symtabs)
1813         (maintenance_check_symtabs, maintenance_info_line_tables):
1814         Update.
1815         * source.c (select_source_symtab)
1816         (forget_cached_source_info_for_objfile): Update.
1817         * objfiles.h (class objfile_compunits): Remove.
1818         (struct objfile) <compunits_range>: New typedef.
1819         (compunits): New method.
1820         * objfiles.c (objfile_relocate1): Update.
1821         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1822         * maint.c (count_symtabs_and_blocks): Update.
1823         * linespec.c (iterate_over_all_matching_symtabs): Update.
1824         * cp-support.c (add_symbol_overload_list_qualified): Update.
1825         * coffread.c (coff_symtab_read): Update.
1826         * ada-lang.c (add_nonlocal_symbols)
1827         (ada_collect_symbol_completion_matches)
1828         (ada_add_global_exceptions): Update.
1829
1830 2019-01-15  Tom Tromey  <tom@tromey.com>
1831
1832         * progspace.h (program_space) <objfiles_safe_range>: New
1833         typedef.
1834         <objfiles_safe>: New method.
1835         * objfiles.h (class all_objfiles_safe): Remove.
1836         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1837         * jit.c (jit_inferior_exit_hook): Update.
1838
1839 2019-01-17  Tom Tromey  <tom@tromey.com>
1840
1841         * progspace.h (program_space) <objfiles_range>: New typedef.
1842         <objfiles>: New method.
1843         <objfiles_head>: Rename from objfiles.
1844         (object_files): Update.
1845         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1846         * guile/scm-pretty-print.c
1847         (ppscm_find_pretty_printer_from_objfiles): Update.
1848         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1849         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1850         Update.
1851         * python/py-progspace.c (pspy_get_objfiles): Update.
1852         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1853         Update.
1854         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1855         (objfpy_lookup_objfile_by_build_id): Update.
1856         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1857         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1858         Update.
1859         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1860         (expand_symtab_containing_pc, lookup_objfile_from_block)
1861         (lookup_static_symbol, basic_lookup_transparent_type)
1862         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1863         (find_line_symtab, info_sources_command)
1864         (default_collect_symbol_completion_matches_break_on)
1865         (make_source_files_completion_list, find_main_name): Update.
1866         * symmisc.c (print_symbol_bcache_statistics)
1867         (print_objfile_statistics, maintenance_print_symbols)
1868         (maintenance_print_msymbols, maintenance_print_objfiles)
1869         (maintenance_info_symtabs, maintenance_check_symtabs)
1870         (maintenance_expand_symtabs, maintenance_info_line_tables):
1871         Update.
1872         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1873         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1874         (map_overlay_command, unmap_overlay_command)
1875         (simple_overlay_update, expand_symtabs_matching)
1876         (map_symbol_filenames): Update.
1877         * symfile-debug.c (set_debug_symfile): Update.
1878         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1879         Update.
1880         * source.c (select_source_symtab, forget_cached_source_info):
1881         Update.
1882         * solib.c (solib_read_symbols): Update.
1883         * solib-spu.c (append_ocl_sos): Update.
1884         * psymtab.c (maintenance_print_psymbols)
1885         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1886         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1887         * printcmd.c (info_symbol_command): Update.
1888         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1889         Update.
1890         * objfiles.h (class all_objfiles): Remove.
1891         * objfiles.c (have_partial_symbols, have_full_symbols)
1892         (have_minimal_symbols, qsort_cmp, update_section_map)
1893         (shared_objfile_contains_address_p)
1894         (default_iterate_over_objfiles_in_search_order): Update.
1895         * objc-lang.c (info_selectors_command, info_classes_command)
1896         (find_methods): Update.
1897         * minsyms.c (find_solib_trampoline_target): Update.
1898         * maint.c (maintenance_info_sections)
1899         (maintenance_translate_address, count_symtabs_and_blocks):
1900         Update.
1901         * main.c (captured_main_1): Update.
1902         * linux-thread-db.c (try_thread_db_load_from_pdir)
1903         (has_libpthread): Update.
1904         * linespec.c (iterate_over_all_matching_symtabs)
1905         (search_minsyms_for_name): Update.
1906         * jit.c (jit_find_objf_with_entry_addr): Update.
1907         * hppa-tdep.c (find_unwind_entry)
1908         (hppa_lookup_stub_minimal_symbol): Update.
1909         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1910         Update.
1911         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1912         (elf_gnu_ifunc_resolve_by_got): Update.
1913         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1914         * dwarf-index-write.c (save_gdb_index_command): Update.
1915         * cp-support.c (add_symbol_overload_list_qualified): Update.
1916         * breakpoint.c (create_overlay_event_breakpoint)
1917         (create_longjmp_master_breakpoint)
1918         (create_std_terminate_master_breakpoint)
1919         (create_exception_master_breakpoint): Update.
1920         * blockframe.c (find_pc_partial_function): Update.
1921         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1922         (ada_collect_symbol_completion_matches)
1923         (ada_add_global_exceptions): Update.
1924
1925 2019-01-17  Tom Tromey  <tom@tromey.com>
1926
1927         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1928         declare VEC.
1929         (solib_target_parse_libraries): Change return type.
1930         (library_list_start_segment, library_list_start_section)
1931         (library_list_end_library, library_list_start_library); Update.
1932         (solib_target_free_library_list): Remove.
1933         (solib_target_parse_libraries): Remove cleanup.  Change return
1934         type.
1935         (solib_target_current_sos): Update.
1936
1937 2019-01-17  Tom Tromey  <tromey@bapiya>
1938
1939         * valprint.c: Replace "the the" with "the".
1940         * symtab.c: Replace "the the" with "the".
1941         * solib.c: Replace "the the" with "the".
1942         * solib-dsbt.c: Replace "the the" with "the".
1943         * linespec.c: Replace "the the" with "the".
1944         * dwarf2loc.h: Replace "the the" with "the".
1945         * amd64-windows-tdep.c: Replace "the the" with "the".
1946         * aarch64-tdep.c: Replace "the the" with "the".
1947
1948 2019-01-16  Keith Seitz  <keiths@redhat.com>
1949
1950         PR gdb/23773
1951         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1952         <builder>: Rename to ..
1953         <m_builder>: ... this and make private.
1954         (dwarf2_cu::get_builder): New method.  Change all users of
1955         `builder' to use this method.
1956         (dwarf2_start_symtab): Move to ...
1957         (dwarf2_cu::start_symtab): ... here.  Update all callers
1958         (setup_type_unit_groups): Move to ...
1959         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1960         callers.
1961         (dwarf2_cu::reset_builder): New method.
1962         (process_full_compunit, process_full_type_unit): Use
1963         dwarf2_cu::reset_builder.
1964         (follow_die_offset): Record the ancestor CU if it is different
1965         from the followed DIE's CU.
1966         (follow_die_sig_1): Likewise.
1967
1968 2019-01-15  Tom Tromey  <tom@tromey.com>
1969
1970         * remote.c (class remote_state) <buf>: Now a char_vector.
1971         <buf_size>: Remove.
1972         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1973         parameter.
1974         (remote_target::getpkt_or_notif_sane_1)
1975         (remote_target::getpkt_sane)
1976         (remote_target::getpkt_or_notif_sane): Likewise.
1977         (class remote_target) <putpkt>: New overload.
1978         (remote_target::read_frame): Change type of "buf_p".  Remove
1979         sizeof_p parameter.
1980         (packet_ok): New overload.
1981         (packet_check_result): New overload.
1982         Update all uses.
1983
1984 2019-01-14  Tom Tromey  <tom@tromey.com>
1985
1986         * remote-notif.c (handle_notification, remote_notif_ack)
1987         (remote_notif_parse): Make "buf" const.
1988         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1989         const.
1990         (remote_notif_parse, remote_notif_ack, handle_notification):
1991         Likewise.
1992         * remote.c (remote_notif_stop_parse): Make "buf" const.
1993         (remote_target::remote_parse_stop_reply): Make "buf" const.
1994         (remote_notif_stop_ack): Make "buf" const.
1995
1996 2019-01-14  Tom Tromey  <tom@tromey.com>
1997
1998         * remote.c (remote_console_output): Make parameter const.
1999
2000 2019-01-14  Tom Tromey  <tom@tromey.com>
2001
2002         * target-debug.h (target_debug_print_signals): Constify.
2003         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2004         * procfs.c (procfs_target::pass_signals): Update.
2005         * linux-nat.c (linux_nat_target::pass_signals): Update.
2006         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2007         * target-delegates.c: Rebuild.
2008         * remote.c (remote_target::program_signals): Update.
2009         (remote_target::pass_signals): Update.
2010         * target.c (target_pass_signals): Constify argument.
2011         (target_program_signals): Likewise.
2012         * target.h (struct target_ops) <pass_signals, program_signals>:
2013         Constify argument.
2014         (target_pass_signals, target_program_signals): Constify argument.
2015
2016 2019-01-14  Tom Tromey  <tom@tromey.com>
2017
2018         PR tui/28819:
2019         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2020
2021 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2022
2023         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2024         field.
2025         * rs6000-tdep.c: Include reggroups.h.
2026         (IS_V_ALIAS_PSEUDOREG): Define.
2027         (rs6000_register_name): Return names for the "vX" aliases.
2028         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2029         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2030         aliases.  Call default_register_reggroup_p for all other
2031         pseudo-registers.
2032         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2033         New functions.
2034         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2035         Handle "vX" aliases.
2036         (v_alias_pseudo_register_collect): New function.
2037         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2038         (rs6000_gdbarch_init): Initialize "vX" aliases as
2039         pseudo-registers.  Restore registration of
2040         rs6000_pseudo_register_reggroup_p with
2041         set_tdesc_pseudo_register_reggroup_p.
2042
2043 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2044
2045         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2046         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2047         set_gdbarch_num_pseudo_regs.
2048
2049 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2050
2051         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2052         Remove arg prefixname, add do_set and do_show.
2053         Add member functions set_list and show_list.
2054         * cli/cli-style.c (class cli_style_option): Update accordingly.
2055         (style_set_list): Move to file scope.
2056         (style_show_list): Likewise.
2057         (set_style): Call help_list.
2058         (show_style): Call cmd_show_list.
2059         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2060         Update to use the new macro.
2061
2062 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2063
2064         * ada-lang.c (_initialize_ada_language): Expand the help text
2065         for the "catch exception" command.
2066
2067 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2068
2069         * symtab.c (matching_obj_sections): Initialize obj,
2070         declare it closer to its usage.
2071
2072 2019-01-10  Tom Tromey  <tom@tromey.com>
2073
2074         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2075         (basic_inf_threads_range): Remove.
2076         (inf_threads_range, inf_non_exited_threads_range)
2077         (safe_inf_threads_range): Use next_adapter.
2078
2079 2019-01-10  Keith Seitz  <keiths@redhat.com>
2080
2081         PR gdb/23712
2082         PR symtab/23010
2083         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2084         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2085
2086 2019-01-10  Keith Seitz  <keiths@redhat.com>
2087
2088         PR gdb/23712
2089         PR symtab/23010
2090         * dictionary.c (pending_to_vector): Remove.
2091         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2092         Remove _1 suffix, replacing functions of the same name.  Update
2093         all callers.
2094         (dict_create_hashed, dict_create_hashed_expandable)
2095         (dict_create_linear, dict_create_linear_expandable, dict_free)
2096         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2097         Make functions static.
2098
2099 2019-01-10  Keith Seitz  <keiths@redhat.com>
2100
2101         PR gdb/23712
2102         PR symtab/23010
2103         * dictionary.h (struct dictionary): Replace declaration with
2104         multidictionary.
2105         (dict_create_hashed, dict_create_hashed_expandable)
2106         (dict_create_linear, dict_create_linear_expandable)
2107         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2108         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2109         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2110         taking multidictionary argument.
2111         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2112         * block.h (struct block) <dict>: Change to multidictionary
2113         and rename `multidict'.
2114         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2115         symmisc.c: Update all dictionary references to multidictionary.
2116
2117 2019-01-10  Keith Seitz  <keiths@redhat.com>
2118
2119         PR gdb/23712
2120         PR symtab/23010
2121         * dictionary.c: Include unordered_map.
2122         (pending_to_vector): New function.
2123         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2124         Rewrite the non-"_1" functions to take vector instead
2125         of linked list.
2126         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2127         "new" _1 versions of the same name.
2128         (multidictionary): Define.
2129         (std::hash<enum language): New definition.
2130         (collate_pending_symbols_by_language, mdict_create_hashed)
2131         (mdict_create_hashed_expandable, mdict_create_linear)
2132         (mdict_create_linear_expandable, mdict_free)
2133         (find_language_dictionary, create_new_language_dictionary)
2134         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2135         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2136         (mdict_size, mdict_empty): New functions.
2137         * dictionary.h (mdict_iterator): Define.
2138
2139 2019-01-10  Pedro Alves  <palves@redhat.com>
2140
2141         * breakpoint.c (read_uploaded_action)
2142         (create_tracepoint_from_upload): Adjust to use
2143         gdb::unique_xmalloc_ptr.
2144         * ctf.c (ctf_write_uploaded_tp):
2145         (SET_ARRAY_FIELD): Use emplace_back.
2146         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2147         * tracefile-tfile.c (tfile_write_uploaded_tp):
2148         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2149         gdb::unique_xmalloc_ptr.
2150         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2151         at_string, cond_string, cmd_strings>: Replace char pointers
2152         with gdb::unique_xmalloc_ptr.
2153
2154 2019-01-10  Pedro Alves  <palves@redhat.com>
2155
2156         * solib-target.c (library_list_start_library): Don't xstrdup name.
2157
2158 2019-01-10  Pedro Alves  <palves@redhat.com>
2159
2160         * mdebugread.c (parse_partial_symbols): Use
2161         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2162
2163 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2164
2165         * linux-fork.c (scoped_switch_fork_info)
2166         <~scoped_switch_fork_info>: Fix incorrect variable name.
2167
2168 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2169
2170         * linux-fork.c (scoped_switch_fork_info)
2171         <scoped_switch_fork_info>: Make explicit.
2172         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2173
2174 2019-01-10  Tom Tromey  <tom@tromey.com>
2175
2176         * objfiles.h (objfile::reset_psymtabs): Update.
2177         * objfiles.c (objfile::objfile): Update.
2178         * psymtab.h (psymtab_storage::obstack): Update.
2179         (psymtab_storage::m_obstack): Use gdb::optional.
2180         (class psymtab_storage): Update comment.  Remove objfile
2181         parameter.
2182         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2183
2184 2019-01-10  Tom Tromey  <tom@tromey.com>
2185
2186         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2187         <free_psymtabs>: Now private.
2188         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2189         (allocate_psymtab): Use new method.
2190
2191 2019-01-10  Tom Tromey  <tom@tromey.com>
2192
2193         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2194         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2195         * mdebugread.c (parse_partial_symbols): Use
2196         allocate_dependencies.
2197         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2198         allocate_dependencies.
2199         (process_psymtab_comp_unit_reader)
2200         (build_type_psymtab_dependencies): Likewise.
2201         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2202
2203 2019-01-10  Tom Tromey  <tom@tromey.com>
2204
2205         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2206         PSYMBOL_SET_LANGUAGE.
2207         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2208
2209 2019-01-10  Tom Tromey  <tom@tromey.com>
2210
2211         * psymtab.h (psymtab_storage::obstack): New method.
2212         <m_obstack>: Rename from obstack; now private.
2213         * psymtab.c (psymtab_storage): Update.
2214         * dwarf2read.c (create_addrmap_from_index)
2215         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2216         Update.
2217
2218 2019-01-10  Tom Tromey  <tom@tromey.com>
2219
2220         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2221         * objfiles.h (objfile::reset_psymtabs): New method.
2222
2223 2019-01-10  Tom Tromey  <tom@tromey.com>
2224
2225         * symmisc.c (print_symbol_bcache_statistics): Update.
2226         (print_objfile_statistics): Update.
2227         * symfile.c (reread_symbols): Update.
2228         * psymtab.h (class psymtab_storage): New.
2229         * psymtab.c (psymtab_storage): New constructor.
2230         (~psymtab_storage): New destructor.
2231         (require_partial_symbols): Update.
2232         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2233         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2234         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2235         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2236         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2237         (start_psymtab_common, end_psymtab_common)
2238         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2239         (allocate_psymtab): Update.
2240         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2241         Update.
2242         (dump_psymtab_addrmap, maintenance_print_psymbols)
2243         (maintenance_check_psymtabs): Update.
2244         (class objfile_psymtabs): Move to objfiles.h.
2245         * psympriv.h (discard_psymtab): Now inline.
2246         (psymtab_discarder::psymtab_discarder): Update.
2247         (psymtab_discarder::~psymtab_discarder): Update.
2248         (ALL_OBJFILE_PSYMTABS): Rewrite.
2249         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2250         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2251         Remove fields.
2252         <partial_symtabs>: New field.
2253         (class objfile_psymtabs): Move from psymtab.h.  Update.
2254         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2255         psymbol_cache.
2256         (objfile::~objfile): Don't destroy psymbol_cache.
2257         * mdebugread.c (parse_partial_symbols): Update.
2258         * dwarf2read.c (create_addrmap_from_index)
2259         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2260         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2261         (add_partial_subprogram, dwarf2_ranges_read): Update.
2262         * dwarf-index-write.c (write_address_map)
2263         (write_one_signatured_type, recursively_write_psymbols)
2264         (class debug_names, class debug_names, write_psymtabs_to_index):
2265         Update.
2266
2267 2019-01-10  Tom Tromey  <tom@tromey.com>
2268
2269         * symtab.h (SYMBOL_SET_NAMES): Update.
2270         (symbol_set_names): Update.
2271         (MSYMBOL_SET_NAMES): Update.
2272         * symtab.c (symbol_set_names): Change argument to be an
2273         objfile_per_bfd_storage.
2274         * psymtab.c (add_psymbol_to_bcache): Update.
2275         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2276
2277 2019-01-10  Tom Tromey  <tom@tromey.com>
2278
2279         * symtab.c (create_demangled_names_hash): Change argument to be an
2280         objfile_per_bfd_storage.
2281         (symbol_set_names): Update.
2282
2283 2019-01-10  Tom Tromey  <tom@tromey.com>
2284
2285         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2286         init_psymbol_list.
2287         * psymtab.c (init_psymbol_list): Do nothing if already called.
2288         * psympriv.h (init_psymbol_list): Add comment.
2289         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2290         init_psymbol_list.
2291         * dbxread.c (dbx_symfile_read): Unconditionally call
2292         init_psymbol_list.
2293
2294 2019-01-10  Tom Tromey  <tom@tromey.com>
2295
2296         * xcoffread.c (scan_xcoff_symtab): Update.
2297         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2298         "where".
2299         * mdebugread.c (parse_partial_symbols)
2300         (handle_psymbol_enumerators): Update.
2301         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2302         * dbxread.c (read_dbx_symtab): Update.
2303         * psympriv.h (psymbol_placement): New enum.
2304         (add_psymbol_to_list): Update.
2305
2306 2019-01-10  Tom Tromey  <tom@tromey.com>
2307
2308         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2309         static_psymbols parameters.
2310         (scan_xcoff_symtab): Update.
2311         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2312         static_psymbols parameters.
2313         * psympriv.h (start_psymtab_common): Update.
2314         * mdebugread.c (parse_partial_symbols): Update.
2315         * dwarf2read.c (create_partial_symtab): Update.
2316         * dbxread.c (read_dbx_symtab): Update.
2317         (start_psymtab): Remove global_psymbols and static_psymbols
2318         parameters.
2319
2320 2019-01-10  Tom Tromey  <tom@tromey.com>
2321
2322         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2323         * psymtab.c (allocate_psymtab): Add comment.
2324         * psympriv.h (allocate_psymtab): Add comment.
2325         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2326         initializations.
2327         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2328
2329 2019-01-10  Tom Tromey  <tom@tromey.com>
2330
2331         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2332         Don't declare.
2333         * mipsread.c: Include mdebugread.h.
2334         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2335         Declare.
2336         * elfread.c: Include mdebugread.h.
2337
2338 2019-01-09  Tom Tromey  <tom@tromey.com>
2339
2340         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2341         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2342         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2343         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2344         (psym_lookup_symbol, psym_find_last_source_symtab)
2345         (psym_forget_cached_source_info, psym_print_stats)
2346         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2347         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2348         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2349         (psym_find_compunit_symtab_by_address)
2350         (maintenance_print_psymbols, maintenance_info_psymtabs)
2351         (maintenance_check_psymtabs): Use ranged for.
2352         * psymtab.h (class objfile_psymtabs): New.
2353         (require_partial_symbols): Return objfile_psymtabs.
2354         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2355
2356 2019-01-09  Tom Tromey  <tom@tromey.com>
2357
2358         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2359         (find_pc_mapped_section, list_overlays_command)
2360         (map_overlay_command, unmap_overlay_command)
2361         (simple_overlay_update): Use all_objfiles.
2362         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2363         * printcmd.c (info_symbol_command): Use all_objfiles.
2364         * objfiles.h (ALL_OBJSECTIONS): Remove.
2365         * maint.c (maintenance_translate_address): Use all_objfiles.
2366         * gcore.c (gcore_create_callback): Use all_objfiles.
2367         (objfile_find_memory_regions): Likewise.
2368
2369 2019-01-09  Tom Tromey  <tom@tromey.com>
2370
2371         * symtab.c (find_line_symtab, info_sources_command)
2372         (make_source_files_completion_list): Use objfile_compunits.
2373         * source.c (select_source_symtab): Use objfile_compunits.
2374         * objfiles.h (struct objfile): Update comment.
2375         (ALL_OBJFILES): Remove.
2376         (ALL_FILETABS): Remove.
2377         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2378         objfile_compunits.
2379
2380 2019-01-09  Tom Tromey  <tom@tromey.com>
2381
2382         * symmisc.c (print_objfile_statistics, dump_objfile)
2383         (maintenance_print_symbols): Use compunit_filetabs.
2384         * source.c (forget_cached_source_info_for_objfile): Use
2385         compunit_filetabs.
2386         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2387         (ALL_FILETABS): Use compunit_filetabs.
2388         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2389         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2390
2391 2019-01-09  Tom Tromey  <tom@tromey.com>
2392
2393         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2394         (compunit_filetabs): New.
2395         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2396         compunit_filetabs.
2397         (info_sources_command, make_source_files_completion_list): Remove
2398         declaration.
2399         * symmisc.c (print_objfile_statistics, dump_objfile)
2400         (maintenance_print_symbols): Remove declaration.
2401         (maintenance_info_symtabs): Use compunit_filetabs.
2402         (maintenance_info_line_tables): Likewise.
2403         * source.c (select_source_symtab): Change local variable name.
2404         (forget_cached_source_info_for_objfile): Remove declaration.
2405         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2406         * objfiles.c (objfile_relocate1): Remove declaration.
2407         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2408         declaration.
2409         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2410         * coffread.c (coff_symtab_read): Remove declaration.
2411         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2412         compunit_filetabs.
2413
2414 2019-01-09  Tom Tromey  <tom@tromey.com>
2415
2416         * symtab.c (lookup_objfile_from_block)
2417         (find_pc_sect_compunit_symtab, search_symbols)
2418         (default_collect_symbol_completion_matches_break_on): Use
2419         objfile_compunits.
2420         * objfiles.h (ALL_COMPUNITS): Remove.
2421         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2422         * cp-support.c (add_symbol_overload_list_qualified): Use
2423         objfile_compunits.
2424         * ada-lang.c (ada_collect_symbol_completion_matches)
2425         (ada_add_global_exceptions): Use objfile_compunits.
2426
2427 2019-01-09  Tom Tromey  <tom@tromey.com>
2428
2429         * source.c (select_source_symtab)
2430         (forget_cached_source_info_for_objfile): Remove declaration.
2431         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2432         declaration.
2433         * maint.c (count_symtabs_and_blocks): Remove declaration.
2434         * cp-support.c (add_symbol_overload_list_qualified): Remove
2435         declaration.
2436         * coffread.c (coff_symtab_read): Remove declaration.
2437         * symtab.c (lookup_symbol_in_objfile_symtabs)
2438         (basic_lookup_transparent_type_1): Use objfile_compunits.
2439         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2440         (info_sources_command, search_symbols)
2441         (default_collect_symbol_completion_matches_break_on)
2442         (make_source_files_completion_list): Remove declaration.
2443         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2444         (ada_collect_symbol_completion_matches)
2445         (ada_add_global_exceptions): Remove declaration.
2446         * linespec.c (iterate_over_all_matching_symtabs): Use
2447         objfile_compunits.
2448         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2449         (class objfile_compunits): New.
2450         (ALL_COMPUNITS): Use objfile_compunits.
2451         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2452         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2453         objfile_compunits.
2454         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2455
2456 2019-01-09  Tom Tromey  <tom@tromey.com>
2457
2458         * symtab.c (search_symbols)
2459         (default_collect_symbol_completion_matches_break_on): Use
2460         objfile_msymbols.
2461         * ada-lang.c (ada_lookup_simple_minsym)
2462         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2463         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2464         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2465         objfile_msymbols.
2466         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2467         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2468         * objc-lang.c (find_methods): Use objfile_msymbols.
2469         (info_selectors_command, info_classes_command): Likewise.
2470         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2471         * objfiles.h (class objfile_msymbols): New.
2472         (ALL_OBJFILE_MSYMBOLS): Remove.
2473         (ALL_MSYMBOLS): Remove.
2474
2475 2019-01-09  Tom Tromey  <tom@tromey.com>
2476
2477         * common/next-iterator.h (next_adapter): Add Iterator template
2478         parameter.
2479         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2480         (class all_objfiles_safe): New.
2481         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2482         * objfiles.c (put_objfile_before): Update comment.
2483         (add_separate_debug_objfile): Likewise.
2484         (free_all_objfiles): Use all_objfiles_safe.
2485         (objfile_purge_solibs): Likewise.
2486
2487 2019-01-09  Tom Tromey  <tom@tromey.com>
2488
2489         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2490         (expand_symtab_containing_pc, lookup_static_symbol)
2491         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2492         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2493         all_objfiles.
2494         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2495         * breakpoint.c (create_overlay_event_breakpoint)
2496         (create_longjmp_master_breakpoint)
2497         (create_std_terminate_master_breakpoint)
2498         (create_exception_master_breakpoint): Use all_objfiles.
2499         * linux-thread-db.c (try_thread_db_load_from_pdir)
2500         (has_libpthread): Use all_objfiles.
2501         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2502         * linespec.c (iterate_over_all_matching_symtabs)
2503         (search_minsyms_for_name): Use all_objfiles.
2504         * maint.c (maintenance_info_sections): Use all_objfiles.
2505         * main.c (captured_main_1): Use all_objfiles.
2506         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2507         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2508         * guile/scm-pretty-print.c
2509         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2510         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2511         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2512         (maintenance_print_msymbols): Use all_objfiles.
2513         * source.c (select_source_symtab): Use all_objfiles.
2514         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2515         * symfile.c (remove_symbol_file_command)
2516         (expand_symtabs_matching, map_symbol_filenames): Use
2517         all_objfiles.
2518         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2519         all_objfiles.
2520         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2521         * objc-lang.c (find_methods): Use all_objfiles.
2522         * objfiles.c (have_partial_symbols, have_full_symbols)
2523         (have_minimal_symbols, qsort_cmp)
2524         (default_iterate_over_objfiles_in_search_order): Use
2525         all_objfiles.
2526         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2527         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2528         (maintenance_check_psymtabs): Use all_objfiles.
2529         (ALL_PSYMTABS): Remove.
2530         * compile/compile-object-run.c (do_module_cleanup): Use
2531         all_objfiles.
2532         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2533         * cp-support.c (add_symbol_overload_list_qualified): Use
2534         all_objfiles.
2535         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2536         Use all_objfiles.
2537         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2538         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2539         all_objfiles.
2540         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2541         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2542         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2543         Uses all_objfiles.
2544         * solib.c (solib_read_symbols): Use all_objfiles
2545
2546 2019-01-09  Tom Tromey  <tom@tromey.com>
2547
2548         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2549         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2550         all_objfiles.
2551         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2552         * symmisc.c (print_symbol_bcache_statistics)
2553         (print_objfile_statistics, maintenance_print_objfiles)
2554         (maintenance_info_symtabs, maintenance_check_symtabs)
2555         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2556         all_objfiles.
2557         * source.c (forget_cached_source_info): Use all_objfiles.
2558         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2559         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2560         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2561         * objfiles.c (update_section_map): Use all_objfiles.
2562         (shared_objfile_contains_address_p): Likewise.
2563         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2564         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2565
2566 2019-01-09  Tom Tromey  <tom@tromey.com>
2567
2568         * common/next-iterator.h: New file.
2569         * objfiles.h (class all_objfiles): New.
2570         (struct objfile_iterator): New.
2571
2572 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2573
2574         * NEWS: Move the description of the changed "frame", "select-frame",
2575          and "info frame" commands to the Changed commands section.
2576
2577 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2578
2579         * gdbtypes.c (check_stub_method_group): Remove handling of old
2580         mangling schemes.
2581         * linespec.c (find_methods): Likewise.
2582         * stabsread.c (read_member_functions): Likewise.
2583         * valops.c (search_struct_method): Likewise.
2584         (value_struct_elt_for_reference): Likewise.
2585         * NEWS: Mention this change.
2586
2587 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2588
2589         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2590         print_source_lines.
2591         * source.c (print_source_lines_base): Update line number check.
2592         (print_source_lines): New function.
2593         (source_lines_range::source_lines_range): New function.
2594         * source.h (class source_lines_range): New class.
2595         (print_source_lines): New declaration.
2596
2597 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2598
2599         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2600
2601 2019-01-08  Tom Tromey  <tom@tromey.com>
2602             Simon Marchi  <simon.marchi@ericsson.com>
2603
2604         PR gdb/24060
2605         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2606         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2607         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2608         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2609         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2610         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2611
2612 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2613
2614         * source.c (select_source_symtab): Move header comment to
2615         declaration in source.h.
2616         (forget_cached_source_info_for_objfile): Likewise.
2617         (forget_cached_source_info): Likewise.
2618         (identify_source_line): Likewise.
2619         * source.h (identify_source_line): Move declaration from symtab.h
2620         and add comment from source.c
2621         (print_source_lines): Likewise.
2622         (forget_cached_source_info_for_objfile): Likewise.
2623         (forget_cached_source_info): Likewise.
2624         (select_source_symtab): Likewise.
2625         (enum print_source_lines_flag): Move definition from symtab.h.
2626         * symtab.h (identify_source_line): Move declaration to source.h.
2627         (print_source_lines): Likewise.
2628         (forget_cached_source_info_for_objfile): Likewise.
2629         (forget_cached_source_info): Likewise.
2630         (select_source_symtab): Likewise.
2631         (enum print_source_lines_flag): Move definition to source.h.
2632         * tui/tui-hooks.c: Add 'source.h' include.
2633
2634 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2635
2636         * source.c (print_source_lines_base): Handle requests to print
2637         reverse line number sequences, and guard against empty lines
2638         string.
2639
2640 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * source.c (print_source_lines_base): Fix skip of '\r' if next
2643         character is '\n'.
2644
2645 2019-01-06  Tom Tromey  <tom@tromey.com>
2646
2647         * c-exp.y (struct c_parse_state) <macro_original_text,
2648         expansion_obstack>: New member.
2649         (macro_original_text, expansion_obstack): Remove globals.
2650         (scan_macro_expansion, scanning_macro_expansion)
2651         (finished_macro_expansion): Update.
2652         (scan_macro_cleanup): Remove.
2653         (yylex, c_parse): Update.
2654
2655 2019-01-06  Tom Tromey  <tom@tromey.com>
2656
2657         * c-exp.y (struct c_parse_state) <strings>: New member.
2658         (operator_stoken): Update.
2659
2660 2019-01-06  Tom Tromey  <tom@tromey.com>
2661
2662         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2663         (union type_stack_elt) <typelist_val>: Now a pointer to
2664         std::vector.
2665         (type_stack_cleanup): Don't declare.
2666         (push_typelist): Update.
2667         * parse.c (pop_typelist): Return a std::vector.
2668         (push_typelist): Take a std::vector.
2669         (follow_types): Update.  Do not free args.
2670         (type_stack_cleanup): Remove.
2671         * c-exp.y (struct c_parse_state): New.
2672         (cpstate): New global.
2673         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2674         (nonempty_typelist): Update.
2675         (func_mod): Create a new vector.
2676         (c_parse): Create a c_parse_state.
2677         (check_parameter_typelist): Do not delete params.
2678         (function_method): Update.  Do not delete type_list.
2679
2680 2019-01-06  Tom Tromey  <tom@tromey.com>
2681
2682         PR gdb/28155:
2683         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2684         check_typedef.
2685         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2686         (print_return_value): Likewise.
2687
2688 2019-01-05  Tom Tromey  <tom@tromey.com>
2689
2690         * contrib/cleanup_check.py: Remove.
2691         * contrib/gcc-with-excheck: Remove.
2692         * contrib/exsummary.py: Remove.
2693         * contrib/excheck.py: Remove.
2694
2695 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2696
2697         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2698         NULL. Initialize tpprev to NULL instead of assigning it
2699         to NULL on the next statement.
2700         * windows-nat.c (windows_delete_thread): Remove check for
2701         main_thread_id before printing thread exit notifications.
2702         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2703         Remove thread ID check against main_thread_id.
2704         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2705         windows_delete_thread.
2706         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2707
2708 2019-01-04  Tom Tromey  <tom@tromey.com>
2709
2710         * compile/compile.c (_initialize_compile): Use upper case for
2711         metasyntactic variables.
2712         * symmisc.c (_initialize_symmisc): Use upper case for
2713         metasyntactic variables.
2714         * psymtab.c (_initialize_psymtab): Use upper case for
2715         metasyntactic variables.
2716         * demangle.c (demangle_command): Use upper case for metasyntactic
2717         variables.
2718         (_initialize_demangler): Likewise.
2719         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2720         variables.
2721
2722 2019-01-03  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2725
2726 2019-01-03  Tom Tromey  <tom@tromey.com>
2727
2728         * python/py-symtab.c (salpy_str): Update.
2729         (struct salpy_sal_object) <symtab>: Now a PyObject.
2730         (salpy_dealloc): Update.
2731         (del_objfile_sal): Use gdbpy_ref.
2732
2733 2019-01-03  Tom Tromey  <tom@tromey.com>
2734
2735         * python/py-type.c (convert_field): Use new_reference.  Return
2736         gdbpy_ref.
2737         (make_fielditem): Return gdbpy_ref.
2738         (typy_fields): Update.
2739         (typy_getitem): Update.
2740         (field_name): Return gdbpy_ref.  Use new_reference.
2741         (typy_iterator_iternext): Update.
2742
2743 2019-01-03  Tom Tromey  <tom@tromey.com>
2744
2745         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2746
2747 2019-01-03  Tom Tromey  <tom@tromey.com>
2748
2749         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2750         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2751         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2752         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2753         (pspy_set_type_printers): Likewise.
2754         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2755         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2756         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2757         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2758         (objfpy_set_type_printers): Likewise.
2759
2760 2019-01-03  Tom Tromey  <tom@tromey.com>
2761
2762         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2763         (gdbpy_print_stack): Use gdbpy_err_fetch.
2764         * python/python-internal.h (class gdbpy_err_fetch): New class.
2765         (class gdbpy_enter) <m_error_type, m_error_value,
2766         m_error_traceback>: Remove.
2767         <m_error>: New member.
2768         (gdbpy_exception_to_string): Don't declare.
2769         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2770         * python/py-value.c (convert_value_from_python): Use
2771         gdbpy_err_fetch.
2772         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2773         gdbpy_exception_to_string.
2774         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2775         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2776         gdbpy_err_fetch.
2777
2778 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2779
2780         * linux-nat.c (delete_lwp_cleanup): Delete.
2781         (struct lwp_deleter): New struct.
2782         (lwp_info_up): New typedef.
2783         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2784         lwp_info_up.
2785
2786 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2787
2788         * linux-fork.c (class scoped_switch_fork_info): New class.
2789         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2790
2791 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * valops.c (find_overload_match): Remove use of null_cleanup, and
2794         calls to do_cleanups.
2795
2796 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2797
2798         * compile/compile-cplus-types.c
2799         (compile_cplus_instance::decl_name): Handle changes to
2800         cp_func_name.
2801         * cp-support.c (cp_func_name): Update header comment, update
2802         return type.
2803         * cp-support.h (cp_func_name): Update return type in declaration.
2804         * valops.c (find_overload_match): Move temp_func local to top
2805         level of function and change its type.  Use temp_func to hold and
2806         delete temporary string obtained from cp_func_name.
2807
2808 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2809
2810         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2811         gdb::char_vector, remove cleanup, and update uses of `msg`.
2812
2813 2019-01-03  Jim Wilson  <jimw@sifive.com>
2814
2815         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2816
2817 2019-01-02  Tom Tromey  <tom@tromey.com>
2818
2819         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2820         (tdesc_parse_xml): Remove cleanups.
2821         * target-descriptions.h (make_cleanup_free_target_description):
2822         Don't declare.
2823         (target_desc_deleter): New struct.
2824         (target_desc_up): New typedef.
2825         * target-descriptions.c (target_desc_deleter::operator()): Rename
2826         from free_target_description.
2827         (make_cleanup_free_target_description): Remove.
2828
2829 2019-01-02  Tom Tromey  <tom@tromey.com>
2830
2831         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2832         constructor, destructor.
2833         (linespec_parser): Remove typedef.
2834         (~linespec_parser): Rename from linespec_parser_delete.
2835         (linespec_lex_to_end, linespec_complete_label)
2836         (linespec_complete): Update.
2837         (decode_line_full): Remove cleanups.
2838         (decode_line_1): Update.
2839
2840 2019-01-02  Tom Tromey  <tom@tromey.com>
2841
2842         * python/python-internal.h (inferior_to_inferior_object): Change
2843         return type.
2844         * python/py-exitedevent.c (create_exited_event_object): Update.
2845         * python/py-inferior.c (inferior_to_inferior_object): Return
2846         gdbpy_ref.
2847         (python_new_inferior, python_inferior_deleted)
2848         (thread_to_thread_object, delete_thread_object)
2849         (build_inferior_list, gdbpy_selected_inferior): Update.
2850         * python/py-infthread.c (create_thread_object): Update.  Also fail
2851         if inferior_to_inferior_object fails.
2852
2853 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2854
2855         * inferior.h (class inferior) <displaced_step_state>: New field.
2856         * infrun.h (struct displaced_step_state): Move here from
2857         infrun.c.  Initialize fields, add constructor.
2858         <inf>: Remove field.
2859         <reset>: New method.
2860         * infrun.c (struct displaced_step_inferior_state): Move to
2861         infrun.h.
2862         (displaced_step_inferior_states): Remove.
2863         (get_displaced_stepping_state): Adust.
2864         (displaced_step_in_progress_any_inferior): Adjust.
2865         (displaced_step_in_progress_thread): Adjust.
2866         (displaced_step_in_progress): Adjust.
2867         (add_displaced_stepping_state): Remove.
2868         (get_displaced_step_closure_by_addr): Adjust.
2869         (remove_displaced_stepping_state): Remove.
2870         (infrun_inferior_exit): Call displaced_step_state.reset.
2871         (use_displaced_stepping): Don't check for NULL.
2872         (displaced_step_prepare_throw): Call
2873         get_displaced_stepping_state.
2874         (displaced_step_fixup): Don't check for NULL.
2875         (prepare_for_detach): Don't check for NULL.
2876
2877 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2878
2879         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2880          in case of call that did not complete.
2881
2882 2019-01-02  Andrey Utkin  <autkin@undo.io>
2883
2884         * symfile.c (find_separate_debug_file): Fix search of debug files for
2885         remote debuggee.
2886
2887 2019-01-02  Tom Tromey  <tom@tromey.com>
2888
2889         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2890         indentation.
2891         * python/py-frame.c (frapy_older): Remove cast.
2892         (frapy_newer): Likewise.
2893         * python/py-breakpoint.c (local_setattro): Remove cast.
2894         * python/py-arch.c (archpy_name): Remove local variable.
2895         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2896
2897 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2898
2899         * unittests/basic_string_view/element_access/char/empty.cc:
2900         Fix year range in copyright header.
2901
2902 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2903
2904         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2905         Delete.
2906         <operator==>: Update with for removed field.
2907         <hash>: Likewise.
2908         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2909         <isa_features>: ...this.
2910         <abi_features>: New field.
2911         (riscv_isa_flen): Update comment.
2912         (riscv_abi_xlen): New declaration.
2913         (riscv_abi_flen): New declaration.
2914         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2915         isa_features.
2916         (riscv_abi_xlen): New function.
2917         (riscv_isa_flen): Update to get answer from isa_features.
2918         (riscv_abi_flen): New function.
2919         (riscv_has_fp_abi): Update to get answer from abi_features.
2920         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2921         xlen and flen.
2922         (riscv_call_info) <xlen, flen>: Update comment.
2923         (riscv_call_arg_struct): Remove invalid assertions
2924         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2925         is removed.
2926         (riscv_gdbarch_init): Gather isa features and abi features
2927         separately, ensure both match on the gdbarch when reusing an old
2928         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2929         a target with 64-bit float hardware.
2930
2931 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2932
2933         * source.c (search_command_helper): Stop reverse search
2934         when line 1 has been searched.
2935
2936 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2937
2938         * record-full.c (record_full_base_target::close): Rewrite
2939         record_full_core_buf_list free logic.
2940
2941 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2942
2943         * break-catch-syscall.c (print_one_catch_syscall): xfree
2944         the last text.
2945
2946 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2947
2948         * top.c (print_gdb_version): Update Copyright year in version
2949         message.
2950
2951 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2952
2953         Update copyright year range in all GDB files.
2954
2955 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2956
2957         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2958
2959 For older changes see ChangeLog-2018.
2960 \f
2961 Local Variables:
2962 mode: change-log
2963 left-margin: 8
2964 fill-column: 74
2965 version-control: never
2966 coding: utf-8
2967 End:
2968