gdb/ChangeLog

   1 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * cli/cli-cmds.c (pipe_command): New function.
   4         (_initialize_cli_cmds): Call add_com for pipe_command.
   5         Define | as an alias for pipe.
   6         (exit_status_set_internal_vars): New function.
   7         (shell_escape): Call exit_status_set_internal_vars.
   8         cli/cli-decode.c (find_command_name_length): Recognize | as
   9         a single character command.
  10
  11 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  12
  13         * gdbcmd.h (execute_command_to_ui_file): New declaration.
  14         top.c (execute_command_to_ui_file): New function, mostly a copy
  15         of execute_command_to_string.
  16         (execute_command_to_string): Implement by calling
  17         execute_command_to_ui_file.
  18
  19 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  20
  21         * top.h (saved_command_line): Remove declaration.
  22         * top.c (previous_saved_command_line, previous_repeat_arguments):
  23         New variables.
  24         (saved_command_line): Make static, define together with other
  25         'repeat variables'.
  26         (dont_repeat): Clear repeat_arguments.
  27         (repeat_previous, get_saved_command_line, save_command_line):
  28         New functions.
  29         (gdb_init): Initialize saved_command_line
  30         and previous_saved_command_line.
  31         * main.c (captured_main_1): Remove saved_command_line initialization.
  32         * event-top.c (handle_line_of_input): Update to use
  33         the new 'repeat' related functions instead of direct access to
  34         saved_command_line.
  35         * command.h (repeat_previous, get_saved_command_line,
  36         save_command_line): New declarations.
  37         (dont_repeat): Add comment.
  38
  39 2019-05-30  Tom Tromey  <tromey@adacore.com>
  40
  41         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
  42         Fix comment.
  43         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
  44
  45 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
  46
  47         PR cli/24587
  48         * completer.c (complete): Initialize variable word.
  49
  50 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
  51
  52         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
  53         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
  54         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
  55         'body' is NULL to the outter 'if', protecting the '!is_define'
  56         situation as well.
  57
  58 2019-05-29  Tom Tromey  <tromey@adacore.com>
  59
  60         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
  61         (dwarf_unknown): New function.
  62         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
  63         (dwarf_type_encoding_name): Use dwarf_unknown.
  64
  65 2019-05-29  Tom Tromey  <tromey@adacore.com>
  66
  67         PR c++/20020:
  68         * cp-valprint.c (cp_print_value_fields): Call
  69         cp_print_static_field inside "try".
  70
  71 2019-05-29  Tom Tromey  <tromey@adacore.com>
  72
  73         * inflow.c (struct terminal_info): Add default operator=.
  74         * configure: Rebuild.
  75         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
  76         -Wdeprecated-copy-dtor, -Wredundant-move.
  77
  78 2019-05-29  Tom Tromey  <tromey@adacore.com>
  79
  80         * NEWS: Add entry.
  81         * infcmd.c (print_return_value_1): Handle finish_print
  82         option.
  83         (show_print_finish): New function.
  84         (_initialize_infcmd): Add "set/show print finish" commands.
  85         * valprint.c (user_print_options): Initialize new member.
  86         * valprint.h (struct value_print_options) <finish_print>: New
  87         member.
  88
  89 2019-05-28  Tom Tromey  <tromey@adacore.com>
  90
  91         * ada-lang.c (ada_remove_Xbn_suffix)
  92         (find_old_style_renaming_symbol)
  93         (parse_old_style_renaming): Remove.
  94         (ada_find_renaming_symbol): Don't call
  95         find_old_style_renaming_symbol.
  96         (ada_is_renaming_symbol): Rename from
  97         ada_find_renaming_symbol.  Remove "block" parameter.  Return
  98         bool.  Now static.
  99         (ada_read_var_value): Update and simplify.
 100         * ada-exp.y (write_var_or_type): Remove old code.
 101
 102 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 103
 104         * event-top.c: Remove include comment.
 105         * inflow.c (class scoped_ignore_sigttou): Move from here...
 106         * inflow.h (class scoped_ignore_sigttou): ...to here.
 107         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 108         * top.c:  Remove include comment.
 109
 110 2019-05-27  Tom Tromey  <tom@tromey.com>
 111
 112         * NEWS: Fix typo.
 113
 114 2019-05-22  Tom Tromey  <tromey@adacore.com>
 115
 116         * target.c (target_follow_exec): Constify parameter.
 117         * target-delegates.c: Rebuild.
 118         * remote.c (remote_target::follow_exec): Constify parameter.
 119         * infrun.c (follow_exec): Constify parameter.
 120         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 121         (target_follow_exec): Likewise.
 122
 123 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 124
 125         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 126         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 127
 128 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 129
 130         * NEWS: Add debugredirect and testsuite sections.
 131
 132 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 133
 134         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 135         target descriptions using exclusively floating point register name
 136         aliases.
 137
 138 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 139
 140         PR gdb/18644:
 141         * f-lang.c (build_fortran_types): Handle the case where
 142         gdbarch_floatformat_for_type returns a nullptr.
 143
 144 2019-05-21  Tom de Vries  <tdevries@suse.de>
 145
 146         PR cli/24587
 147         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 148
 149 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 150
 151         PR gdb/18644:
 152         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 153         16-byte floats.
 154         * i386-tdep.c (i386_floatformat_for_type): Use
 155         floatformats_ia64_quad for the 16-byte floating point component
 156         within a fortran 32-byte complex number.
 157
 158 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 159
 160         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 161         delete default constructor.
 162         (find_partial_die): Update to return const struct.
 163         (partial_die_parent_scope): Move variable declaration into scope
 164         of its use and change its type to auto.
 165         (guess_partial_die_structure_name): Likewise.
 166         (partial_die_info::fixup): Likewise.
 167
 168 2019-05-17  Tom Tromey  <tromey@adacore.com>
 169
 170         * source.c (find_and_open_source): Remove cast.
 171
 172 2019-05-17  Tom Tromey  <tromey@adacore.com>
 173
 174         * annotate.c (annotate_source): Make "filename" const.
 175         * annotate.h (annotate_source): Use const.
 176
 177 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 178
 179         * disasm.c (set_disassembler_options): Send errors to stderr.
 180
 181 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 182
 183         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 184         (cli_interp_base::set_logging): Check debug_redirect.
 185         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 186         * cli/cli-logging.c (debug_redirect): Add static variable.
 187         (pop_output_files): Add default param.
 188         (handle_redirections): Print debug setting.
 189         (show_logging_command): Likewise.
 190         (_initialize_cli_logging): Add debugredirect command.
 191         * interps.c (current_interp_set_logging): Add debug_redirect
 192         parameter.
 193         * interps.h (set_logging): Add debug_redirect parameter.
 194         (current_interp_set_logging): Likewise.
 195         * mi/mi-common.h: Likewise.
 196         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 197
 198 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 199             Tom Tromey  <tromey@adacore.com>
 200
 201         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 202         directly.
 203         * cli/cli-interp.h (make_logging_output): Remove declaration.
 204         * cli/cli-logging.c (make_logging_output): Remove function.
 205         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 206         directly.
 207         * ui-file.c (tee_file::tee_file): Remove bools.
 208         (tee_file::~tee_file): Remove deletes.
 209         * ui-file.h (tee_file): Remove bools.
 210
 211 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 212
 213         * mi/mi-cmds.h (mi_cmd_complete): New function.
 214         * mi/mi-main.c (mi_cmd_complete): Likewise.
 215         * mi/mi-cmds.c: Define new MI command -complete.
 216         * NEWS: Mention new -complete command.
 217
 218 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 219
 220         * completer.h (complete): New function.
 221         * completer.c (complete): Likewise.
 222         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 223         function defined in completer.h.
 224
 225 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 226
 227        * MAINTAINERS (Write After Approval): Add myself.
 228
 229 2019-05-17  Tom de Vries  <tdevries@suse.de>
 230
 231         PR gdb/24094
 232         * dwarf2read.c (struct cu_partial_die_info): New struct.
 233         (find_partial_die): Return cu_partial_die_info.
 234         (partial_die_parent_scope, guess_partial_die_structure_name)
 235         (partial_die_info::fixup): Handle new return type of find_partial_die.
 236
 237 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 238
 239         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 240         "std::string", simplifying the algorithm.
 241
 242 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 243
 244         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 245         (stap_static_probe_ops::get_probes): Likewise.
 246
 247 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 248
 249         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 250         '-')" and "else if".
 251         (stap_parse_single_operand): Join checks for
 252         "gdbarch_stap_parse_special_token_p" and
 253         "gdbarch_stap_parse_special_token" in the same "if" statement.
 254         Invert check when verifying for operation on register
 255         displacement.
 256
 257 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 258
 259         * stap-probe.c (stap_get_opcode): Update comment.
 260         (stap_get_expected_argument_type): Likewise.
 261         (handle_stap_probe): Likewise.
 262
 263 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 264
 265         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 266         return type to 'bool'.  Adjust comment.  Use 'bool' when
 267         appropriate.
 268         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 269         * stap-probe.c (stap_parse_argument_1): Likewise.
 270         (stap_is_operator): Likewise.
 271         (stap_is_generic_prefix): Likewise.
 272         (stap_is_register_prefix): Likewise.
 273         (stap_is_register_indirection_prefix): Likewise.
 274         (stap_is_integer_prefix): Likewise.
 275         (stap_generic_check_suffix): Likewise.
 276         (stap_check_integer_suffix): Likewise.
 277         (stap_check_register_suffix): Likewise.
 278         (stap_check_register_indirection_suffix): Likewise.
 279         (stap_parse_register_operand): Likewise.
 280         (stap_parse_single_operand): Likewise.
 281         (stap_parse_argument_1): Likewise.
 282         (stap_probe::get_argument_count): Likewise.
 283         (stap_is_operator): Likewise.
 284
 285 2019-05-16  Tom Tromey  <tromey@adacore.com>
 286
 287         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 288         keyword to foreach.
 289
 290 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 291
 292         * linux-thread-db.c (try_thread_db_load_1): Change return type
 293         to bool.
 294         (try_thread_db_load): Likewise.
 295         (try_thread_db_load_from_pdir_1): Likewise.
 296         (try_thread_db_load_from_pdir): Likewise.
 297         (try_thread_db_load_from_sdir): Likewise.
 298         (try_thread_db_load_from_dir): Likewise.
 299         (thread_db_load_search): Likewise.
 300         (has_libpthread): Likewise.
 301         (thread_db_load): Likewise.
 302
 303 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 304
 305         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 306         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 307         NULL, and complain/return if that's the case.
 308
 309 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 310
 311         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 312         (advance, posn, abstract_read_memory): New functions.
 313         [struct mem_read_abstraction]: New struct.
 314         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 315
 316 2019-05-14  Tom Tromey  <tromey@adacore.com>
 317
 318         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 319         value is not lval_memory.
 320
 321 2019-05-14  Tom Tromey  <tromey@adacore.com>
 322
 323         * solib.c (info_sharedlibrary_command): Style the file name.
 324
 325 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 326
 327         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 328         (aarch64_vnv_type): Likewise.
 329         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 330         * common/tdesc.c: Likewise.
 331         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 332         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 333         * features/aarch64-fpu.xml: Add ieee half view.
 334         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 335         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 336         * gdbtypes.h (struct builtin_type): Likewise.
 337         (struct objfile_type): Likewise.
 338
 339 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 340
 341         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 342         typo.
 343         * location.h (string_to_event_location): Likewise.
 344
 345 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 346
 347         GDB 8.3 released.
 348
 349 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 350
 351         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 352         New variable declaration.
 353         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 354         New variable.
 355         (print_one_breakpoint): Use ui_out::test_flags and new global
 356         variable to compute use_fixed_output.
 357         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 358         Remove.
 359         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 360         (mi_multi_location_breakpoint_output_fixed): Remove.
 361         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 362         new variable.
 363         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 364         fix_multi_location_breakpoint_output flag if version >= 3.
 365         * ui-out.h (enum ui_out_flag)
 366         <fix_multi_location_breakpoint_output>: New enumerator.
 367
 368 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 369
 370         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 371
 372 2019-05-10  Tom Tromey  <tromey@adacore.com>
 373
 374         * ada-lang.c (catch_ada_completer): New function.
 375         (_initialize_ada_language): Use it.
 376
 377 2019-05-10  Tom Tromey  <tromey@adacore.com>
 378
 379         * thread.c (print_thread_info): Make "requested_threads" const.
 380         * gdbthread.h (print_thread_info): Make "requested_threads"
 381         const.
 382         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 383         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 384
 385 2019-05-08  Tom Tromey  <tom@tromey.com>
 386
 387         * gdbtypes.c (objfile_type_data): Change type.
 388         (objfile_type, _initialize_gdbtypes): Update.
 389
 390 2019-05-08  Tom Tromey  <tom@tromey.com>
 391
 392         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 393         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 394         (_initialize_dwarf2_frame): Update.
 395
 396 2019-05-08  Tom Tromey  <tom@tromey.com>
 397
 398         * objc-lang.c (objc_objfile_data): Change type.
 399         (find_methods): Update.
 400         (_initialize_objc_lang): Remove.
 401
 402 2019-05-08  Tom Tromey  <tom@tromey.com>
 403
 404         * stabsread.c (rs6000_builtin_type_data): Change type.
 405         (rs6000_builtin_type, _initialize_stabsread): Update.
 406
 407 2019-05-08  Tom Tromey  <tom@tromey.com>
 408
 409         * mips-tdep.c (mips_pdr_data): Remove.
 410         (_initialize_mips_tdep): Update.
 411
 412 2019-05-08  Tom Tromey  <tom@tromey.com>
 413
 414         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 415         (hppa_init_objfile_priv_data, read_unwind_info)
 416         (find_unwind_entry, _initialize_hppa_tdep): Update.
 417
 418 2019-05-08  Tom Tromey  <tom@tromey.com>
 419
 420         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 421         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 422         on obstack.
 423         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 424
 425 2019-05-08  Tom Tromey  <tom@tromey.com>
 426
 427         * mdebugread.c (basic_type_data): Change type.
 428         (basic_type, _initialize_mdebugread): Update.
 429
 430 2019-05-08  Tom Tromey  <tom@tromey.com>
 431
 432         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 433
 434 2019-05-08  Tom Tromey  <tom@tromey.com>
 435
 436         * nto-tdep.c (nto_inferior_data_reg): Change type.
 437         (nto_inferior_data): Update.
 438         (nto_inferior_data_cleanup, nto_new_inferior_data)
 439         (_initialize_nto_tdep): Remove.
 440         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 441
 442 2019-05-08  Tom Tromey  <tom@tromey.com>
 443
 444         * ada-lang.c (struct ada_inferior_data): Add initializers.
 445         (ada_inferior_data): Change type.
 446         (ada_inferior_data_cleanup): Remove.
 447         (get_ada_inferior_data, ada_inferior_exit)
 448         (struct ada_pspace_data): Add initializers, destructor.
 449         (ada_pspace_data_handle): Change type.
 450         (get_ada_pspace_data): Update.
 451         (ada_pspace_data_cleanup): Remove.
 452
 453 2019-05-08  Tom Tromey  <tom@tromey.com>
 454
 455         * coffread.c (struct coff_symfile_info): Add initializers.
 456         (coff_objfile_data_key): Move lower.  Change type.
 457         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 458         Update.
 459         (coff_free_info): Remove.
 460
 461 2019-05-08  Tom Tromey  <tom@tromey.com>
 462
 463         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 464         (fbsd_pspace_data_handle): Move lower.  Change type.
 465         (get_fbsd_pspace_data): Update.
 466         (fbsd_pspace_data_cleanup): Remove.
 467         (_initialize_fbsd_tdep): Update.
 468
 469 2019-05-08  Tom Tromey  <tom@tromey.com>
 470
 471         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 472         (get_ada_tasks_pspace_data): Update.
 473         (ada_tasks_pspace_data_cleanup): Remove.
 474         (_initialize_tasks): Update.
 475         (ada_tasks_inferior_data_handle): Change type.
 476         (get_ada_tasks_inferior_data): Update.
 477         (ada_tasks_inferior_data_cleanup): Remove.
 478         (struct ada_tasks_pspace_data): Add initializers.
 479
 480 2019-05-08  Tom Tromey  <tom@tromey.com>
 481
 482         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 483         * symfile-debug.c (debug_sym_get_probes): Change type.
 484         * stap-probe.c (handle_stap_probe):
 485         (stap_static_probe_ops::get_probes): Change type.
 486         * probe.h (class static_probe_ops) <get_probes>: Change type.
 487         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 488         (parse_probes_in_pspace): Update.
 489         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 490         Update.
 491         (any_static_probe_ops::get_probes): Change type.
 492         * elfread.c (elfread_data): New typedef.
 493         (probe_key): Change type.
 494         (elf_get_probes): Likewise.  Update.
 495         (probe_key_free): Remove.
 496         (_initialize_elfread): Update.
 497         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 498         Change type.
 499         (dtrace_process_dof_probe, dtrace_process_dof)
 500         (dtrace_static_probe_ops::get_probe): Change type.
 501
 502 2019-05-08  Tom Tromey  <tom@tromey.com>
 503
 504         * xcoffread.c (struct xcoff_symfile_info): Rename from
 505         coff_symfile_info.  Add initializers.
 506         (xcoff_objfile_data_key): Move lower.  Change type.
 507         (XCOFF_DATA): Rewrite.
 508         (xcoff_free_info): Remove.
 509         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 510         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 511         (xcoff_initial_scan): Update.
 512
 513 2019-05-08  Tom Tromey  <tom@tromey.com>
 514
 515         * solib-svr4.c (struct svr4_info): Add initializers and
 516         destructor.
 517         <probes_table>: Now an htab_up.
 518         (solib_svr4_pspace_data): Change type.
 519         (free_probes_table): Simplify.
 520         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 521         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 522         (probes_table_remove_objfile_probes, register_solib_event_probe)
 523         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 524         (_initialize_svr4_solib): Update.
 525
 526 2019-05-08  Tom Tromey  <tom@tromey.com>
 527
 528         * remote.c (remote_pspace_data): Change type.
 529         (remote_pspace_data_cleanup): Remove.
 530         (get_remote_exec_file, set_pspace_remote_exec_file)
 531         (_initialize_remote): Update.
 532
 533 2019-05-08  Tom Tromey  <tom@tromey.com>
 534
 535         * breakpoint.c (breakpoint_objfile_key): Change type.
 536         (get_breakpoint_objfile_data): Update.
 537         (free_breakpoint_objfile_data): Remove.
 538         (_initialize_breakpoint): Update.
 539
 540 2019-05-08  Tom Tromey  <tom@tromey.com>
 541
 542         * linux-tdep.c (struct linux_info): Add initializers.
 543         (linux_inferior_data): Move.  Change type.
 544         (invalidate_linux_cache_inf): Update.
 545         (linux_inferior_data_cleanup): Remove.
 546         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 547
 548 2019-05-08  Tom Tromey  <tom@tromey.com>
 549
 550         * auxv.c (auxv_inferior_data): Move.  Change type.
 551         (auxv_inferior_data_cleanup): Remove.
 552         (invalidate_auxv_cache_inf): Rewrite.
 553         (get_auxv_inferior_data, _initialize_auxv): Update.
 554
 555 2019-05-08  Tom Tromey  <tom@tromey.com>
 556
 557         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 558         (symfile_debug_objfile_data_key): Change type.
 559         (symfile_debug_installed, debug_qf_has_symbols)
 560         (debug_qf_find_last_source_symtab)
 561         (debug_qf_forget_cached_source_info)
 562         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 563         (debug_qf_print_stats, debug_qf_dump)
 564         (debug_qf_expand_symtabs_for_function)
 565         (debug_qf_expand_all_symtabs)
 566         (debug_qf_expand_symtabs_with_fullname)
 567         (debug_qf_map_matching_symbols)
 568         (debug_qf_expand_symtabs_matching)
 569         (debug_qf_find_pc_sect_compunit_symtab)
 570         (debug_qf_map_symbol_filenames)
 571         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 572         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 573         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 574         (debug_sym_read_linetable, debug_sym_relocate): Update.
 575         (symfile_debug_free_objfile): Remove.
 576         (install_symfile_debug_logging, _initialize_symfile_debug):
 577         Update.
 578
 579 2019-05-08  Tom Tromey  <tom@tromey.com>
 580
 581         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 582         allocate_on_obstack.
 583         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 584         (get_dwarf2_per_objfile): Update.
 585         (set_dwarf2_per_objfile): Remove.
 586         (dwarf2_has_info, dwarf2_get_section_info): Update.
 587         (dwarf2_free_objfile): Remove.
 588         (_initialize_dwarf2_read): Update.
 589
 590 2019-05-08  Tom Tromey  <tom@tromey.com>
 591
 592         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 593         initializers.
 594         <unsupported_script_warning_printed,
 595         script_not_found_warning_printed>: Now bool.
 596         (auto_load_pspace_data): Change type.
 597         (~auto_load_pspace_info): Rename from
 598         auto_load_pspace_data_cleanup.
 599         (get_auto_load_pspace_data, init_loaded_scripts_info)
 600         (clear_section_scripts, maybe_print_unsupported_script_warning)
 601         (maybe_print_script_not_found_warning, _initialize_auto_load):
 602         Update.
 603
 604 2019-05-08  Tom Tromey  <tom@tromey.com>
 605
 606         * objfiles.c (objfile_pspace_info): Add destructor and
 607         initializers.
 608         (objfiles_pspace_data): Change type.
 609         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 610         (get_objfile_pspace_data): Update.
 611         (objfiles_bfd_data): Change type.
 612         (get_objfile_bfd_data): Update.
 613         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 614
 615 2019-05-08  Tom Tromey  <tom@tromey.com>
 616
 617         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 618         Change type.
 619         (get_catch_syscall_inferior_data): Update.
 620         (catch_syscall_inferior_data_cleanup): Remove.
 621         (_initialize_break_catch_syscall): Update.
 622
 623 2019-05-08  Tom Tromey  <tom@tromey.com>
 624
 625         * inflow.c (struct terminal_info): Add destructor and
 626         initializers.
 627         (inflow_inferior_data): Change type.
 628         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 629         (get_inflow_inferior_data, inflow_inferior_exit)
 630         (swap_terminal_info, _initialize_inflow): Update.
 631
 632 2019-05-08  Tom Tromey  <tom@tromey.com>
 633
 634         * target-dcache.c (target_dcache_cleanup): Remove.
 635         (target_dcache_aspace_key): Change type.
 636         (target_dcache_init_p, target_dcache_invalidate)
 637         (target_dcache_get, target_dcache_get_or_init)
 638         (_initialize_target_dcache): Update.
 639         * dcache.h (struct dcache_deleter): New.
 640
 641 2019-05-08  Tom Tromey  <tom@tromey.com>
 642
 643         * symtab.c (struct symbol_cache): Add destructor and
 644         initializers.
 645         (symbol_cache_key): Move.  Change type.
 646         (make_symbol_cache, free_symbol_cache): Remove.
 647         (get_symbol_cache): Update.
 648         (symbol_cache_cleanup): Remove.
 649         (ALL_PSPACES, symbol_cache_flush)
 650         (maintenance_print_symbol_cache)
 651         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 652         Update.
 653
 654 2019-05-08  Tom Tromey  <tom@tromey.com>
 655
 656         * symtab.c (struct main_info): Add destructor and initializers.
 657         (main_progspace_key): Move.  Change type.
 658         (get_main_info): Update.
 659         (main_info_cleanup): Remove.
 660         (_initialize_symtab): Update.
 661
 662 2019-05-08  Tom Tromey  <tom@tromey.com>
 663
 664         * registry.h (DECLARE_REGISTRY): Define the _key class.
 665
 666 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 667
 668         * NEWS: Merge two 'New commands' sections.
 669
 670 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 671
 672         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 673         parameter and use Ada language definition instead.
 674         (ada_val_print_ptr): Remove unused language parameter.
 675         (ada_val_print_num): Remove language parameter and use Ada language
 676         definition instead.
 677         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 678         parameter.
 679         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 680         parameter and use Ada language definition instead.
 681         (ada_val_print_1): Update all ada_val_print_xxx calls.
 682         Remove language parameter.
 683         (ada_val_print): Update ada_val_print_1 call.
 684
 685 2019-05-08  Tom Tromey  <tromey@adacore.com>
 686
 687         * remote.c (remote_hw_watchpoint_limit)
 688         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 689         Now static.
 690
 691 2019-05-08  Tom Tromey  <tromey@adacore.com>
 692
 693         * maint.c (_initialize_maint_cmds): Move initialization code to
 694         remote.c.
 695         (watchdog, show_watchdog): Move to remote.c.
 696         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 697         "watchdog" static.
 698         (_initialize_remote): Move initialization code from maint.c.
 699         * defs.h (watchdog): Don't declare.
 700
 701 2019-05-08  Tom Tromey  <tromey@adacore.com>
 702
 703         * tui/tui-interp.c: Include main.h.
 704         * interps.c: Include main.h.
 705         * main.h (interpreter_p): Declare.
 706         * defs.h (interpreter_p): Don't declare.
 707
 708 2019-05-08  Tom Tromey  <tromey@adacore.com>
 709
 710         * dwarf2loc.c: Include dwarf2read.h.
 711         * defs.h (read_unsigned_leb128): Don't declare.
 712         * dwarf2read.h (read_unsigned_leb128): Declare.
 713
 714 2019-05-08  Tom Tromey  <tromey@adacore.com>
 715
 716         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 717         method.
 718
 719 2019-05-08  Tom Tromey  <tromey@adacore.com>
 720
 721         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 722         when no wrap column is set.
 723
 724 2019-05-08  Tom Tromey  <tromey@adacore.com>
 725
 726         * c-lang.c (c_get_string): Handle non-C-style arrays.
 727
 728 2019-05-08  Tom Tromey  <tromey@adacore.com>
 729
 730         * typeprint.c (print_offset_data::update): Print the bit offset,
 731         not the number of bits remaining.
 732
 733 2019-05-08  Tom Tromey  <tromey@adacore.com>
 734
 735         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 736         padding at end of comment.
 737
 738 2019-05-08  Tom Tromey  <tromey@adacore.com>
 739
 740         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 741         Compare main types.
 742
 743 2019-05-06  Tom Tromey  <tom@tromey.com>
 744
 745         * common/scoped_mmap.c: Include common-defs.h.
 746         * common/scoped_mmap.h: Don't include config.h.
 747
 748 2019-05-04  Tom Tromey  <tom@tromey.com>
 749
 750         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 751         (struct aarch64_call_info): Add initializers.
 752         <si>: Now a std::vector.
 753         (pass_on_stack, aarch64_push_dummy_call): Update.
 754
 755 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 756             Tom Tromey  <tom@tromey.com>
 757
 758         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 759         (ppc_threads): Now a std::vector.  Now static.
 760         (hwdebug_find_thread_points_by_tid)
 761         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 762         Update.
 763
 764 2019-05-04  Tom Tromey  <tom@tromey.com>
 765
 766         * arc-tdep.c (arc_tdesc_init): Return bool.
 767
 768 2019-05-04  Tom Tromey  <tom@tromey.com>
 769
 770         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 771         Use gdb_assert_not_reached.
 772
 773 2019-05-04  Tom Tromey  <tom@tromey.com>
 774
 775         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 776         "false".
 777
 778 2019-05-04  Tom Tromey  <tom@tromey.com>
 779
 780         * arc-tdep.c (arc_tdesc_init): Use bool.
 781
 782 2019-05-04  Tom Tromey  <tom@tromey.com>
 783
 784         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 785
 786 2019-05-04  Tom Tromey  <tom@tromey.com>
 787
 788         * cli/cli-cmds.c (valid_command_p): Return bool.
 789
 790 2019-05-04  Tom Tromey  <tom@tromey.com>
 791
 792         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 793         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 794
 795 2019-05-04  Raul Tambre  <raul@tambre.ee>
 796
 797         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 798         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 799         operator for comparison.
 800
 801 2019-05-04  Tom Tromey  <tom@tromey.com>
 802
 803         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 804         (lookup_partial_symbol, print_partial_symbols)
 805         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 806         (psymbol_compare): Update.
 807         (add_psymbol_to_bcache): Clear the entire psymbol.
 808         (maintenance_check_psymtabs): Update.
 809         * psympriv.h (struct partial_symbol): Don't derive from
 810         general_symbol_info.
 811         <obj_section, unrelocated_address, address,
 812         set_unrelocated_address>: Update.
 813         <ginfo>: New member.
 814         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 815         (debug_names::write_psymbols): Update.
 816
 817 2019-05-04  Tom de Vries  <tdevries@suse.de>
 818
 819         * contrib/cc-with-tweaks.sh: Support -n arg.
 820
 821 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 822
 823         * corelow.c (core_target::detach): Ensure frame cache and
 824         register caches are cleared.
 825         inferior.c (exit_inferior_1): Likewise.
 826
 827 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 828             Tom Tromey  <tom@tromey.com>
 829
 830         * dictionary.c (collate_pending_symbols_by_language): Remove
 831         "struct" from foreach.
 832         * symtab.c (lookup_global_symbol_from_objfile)
 833         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 834         foreach.
 835         * ser-tcp.c (net_open): Remove "struct" from foreach.
 836         * objfiles.c (objfile_relocate, objfile_rebase)
 837         (objfile_has_symbols): Remove "struct" from foreach.
 838         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 839         from foreach.
 840         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 841         foreach.
 842         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 843         "struct" from foreach.
 844         * ada-lang.c (create_excep_cond_exprs)
 845         (ada_exception_catchpoint_cond_string): Remove "struct" from
 846         foreach.
 847
 848 2019-05-03  Tom Tromey  <tromey@adacore.com>
 849
 850         * ada-exp.y (convert_char_literal): Check suffix of each
 851         enumerator.
 852
 853 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 854
 855         PR ada/21406:
 856         * ada-exp.y (yywrap): Don't define.
 857         * ada-lex.l (%option): Add noyywrap
 858         (yywrap): Remove.
 859
 860 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 861
 862         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 863         _WIN32_WINNT to the XP level, unless already defined to a higher
 864         level.
 865
 866         * unittests/parse-connection-spec-selftests.c:
 867         * ser-tcp.c:
 868         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 869         override.
 870
 871         * symfile.c (find_separate_debug_file): Remove colon from the
 872         drive spec of DOS/Windows file names of the target, so that the
 873         file name produced from DEBUGDIR and the target's directory will
 874         be valid on DOS/Windows systems.
 875
 876 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 877
 878         * rust-lang.c (val_print_struct): Handle printing structures
 879         containing strings.
 880
 881 2019-05-02  Tom Tromey  <tromey@adacore.com>
 882
 883         * valarith.c (_initialize_valarith): Remove.
 884
 885 2019-05-01  Tom Tromey  <tromey@adacore.com>
 886
 887         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 888         bitfields.
 889
 890 2019-05-01  Tom Tromey  <tromey@adacore.com>
 891
 892         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 893         for big-endian copies.
 894
 895 2019-04-30  Ali Tamur  <tamur@google.com>
 896         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 897         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 898         (read_3_bytes): New function.
 899
 900 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 901
 902         * windows-nat.c (main_thread_id): Delete.
 903         (handle_output_debug_string): Replace main_thread_id by
 904         current_event.dwThreadId.
 905         (fake_create_process): Likewise.
 906         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 907         Do not set main_thread_id.
 908         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 909         current_event.dwThreadId.
 910         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 911
 912 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 913
 914         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 915         Use current_event.dwThreadId instead of main_thread_id.
 916
 917 2019-04-30  Tom Tromey  <tromey@adacore.com>
 918
 919         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 920         (create_excep_cond_exprs): Iterate over program spaces.
 921         (ada_exception_catchpoint_cond_string): Examine all minimal
 922         symbols for exception types.
 923
 924 2019-04-30  Tom Tromey  <tromey@adacore.com>
 925
 926         PR c++/24470:
 927         * dwarf2read.c (process_structure_scope): Handle case where type
 928         has template parameters but no symbol was created.
 929
 930 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 931             Chris January  <chris.january@arm.com>
 932
 933         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 934         qualifier.
 935         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 936
 937 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 938
 939         * f-typeprint.c (f_print_type): Update rules for printing
 940         whitespace.
 941         (f_type_print_varspec_suffix): Likewise.
 942
 943 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 944             Chris January  <chris.january@arm.com>
 945
 946         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 947         function arguments.
 948
 949 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 950
 951         * f-lang.c (build_fortran_types): Change name of void type to
 952         lower case.
 953         * f-typeprint.c (f_type_print_base): Print the name of the void
 954         type, rather than a fixed string.
 955         * f-valprint.c (f_decorations): Use lower case void string.
 956
 957 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 958             Chris January  <chris.january@arm.com>
 959
 960         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 961         types for Fortran.
 962
 963 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 964             Chris January  <chris.january@arm.com>
 965             David Lecomber  <david.lecomber@arm.com>
 966
 967         * f-exp.y (BINOP_INTRINSIC): New token.
 968         (exp): New parser rule handling BINOP_INTRINSIC.
 969         (f77_keywords): Add new builtin procedures.
 970         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 971         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 972         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 973         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 974         (print_unop_subexp_f): New function.
 975         (print_binop_subexp_f): New function.
 976         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 977         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 978         (dump_subexp_body_f): Likewise.
 979         (operator_check_f): Likewise.
 980         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 981         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 982
 983 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 984
 985         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 986         UNOP_KIND.
 987         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 988         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 989         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 990         (operator_length_f): New fuction.
 991         (print_subexp_f): New function.
 992         (op_name_f): New function.
 993         (dump_subexp_body_f): New function.
 994         (operator_check_f): New function.
 995         (exp_descriptor_f): Replace standard expression handling functions
 996         with new functions.
 997         * gdb/fortran-operator.def: New file.
 998         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 999         * gdb/std-operator.def: Remove UNOP_KIND.
1000
1001 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1002
1003         * std-operator.def: Remove unbalanced, stray double quote
1004         character.
1005
1006 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1007             Chris January  <chris.january@arm.com>
1008             Daniel Everett  <daniel.everett@arm.com>
1009             Nick Forrington  <nick.forrington@arm.com>
1010             Richard Bunt  <richard.bunt@arm.com>
1011
1012         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1013         of depth when printing anonymous structs or unions.
1014         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1015         Don't print either the top-level value, or the children if the
1016         max-depth is exceeded.
1017         (ppscm_print_children): When printing the key of a map, allow one
1018         extra level of depth.
1019         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1020         print either the top-level value, or the children if the max-depth
1021         is exceeded.
1022         (print_children): When printing the key of a map, allow one extra
1023         level of depth.
1024         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1025         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1026         (user_print_options): Initialise max_depth field.
1027         (val_print_scalar_or_string_type_p): New function.
1028         (val_print): Check to see if the max depth has been reached.
1029         (val_print_check_max_depth): Define new function.
1030         (show_print_max_depth): New function.
1031         (_initialize_valprint): Add 'print max-depth' option.
1032         * valprint.h (struct value_print_options) <max_depth>: New field.
1033         (val_print_check_max_depth): Declare new function.
1034         * NEWS: Document new feature.
1035
1036 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * ada-lang.c (ada_language_defn): Initialise new field.
1039         * c-lang.c (c_is_string_type_p): New function.
1040         (c_language_defn): Initialise new field.
1041         (cplus_language_defn): Initialise new field.
1042         (asm_language_defn): Initialise new field.
1043         (minimal_language_defn): Initialise new field.
1044         * c-lang.h (c_is_string_type_p): Declare new function.
1045         * d-lang.c (d_language_defn): Initialise new field.
1046         * f-lang.c (f_is_string_type_p): New function.
1047         (f_language_defn): Initialise new field.
1048         * go-lang.c (go_is_string_type_p): New function.
1049         (go_language_defn): Initialise new field.
1050         * language.c (default_is_string_type_p): New function.
1051         (unknown_language_defn): Initialise new field.
1052         (auto_language_defn): Initialise new field.
1053         * language.h (struct language_defn) <la_is_string_type_p>: New
1054         member variable.
1055         (default_is_string_type_p): Declare new function.
1056         * m2-lang.c (m2_language_defn): Initialise new field.
1057         * objc-lang.c (objc_language_defn): Initialise new field.
1058         * opencl-lang.c (opencl_language_defn): Initialise new field.
1059         * p-lang.c (pascal_is_string_type_p): New function.
1060         (pascal_language_defn): Initialise new field.
1061         * rust-lang.c (rust_is_string_type_p): New function.
1062         (rust_language_defn): Initialise new field.
1063
1064 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1067         New field.
1068         * ada-lang.c (ada_language_defn): Initialise new field.
1069         * c-lang.c (c_language_defn): Likewise.
1070         (cplus_language_defn): Likewise.
1071         (asm_language_defn): Likewise.
1072         (minimal_language_defn): Likewise.
1073         * d-lang.c (d_language_defn): Likewise.
1074         * f-lang.c (f_language_defn): Likewise.
1075         * go-lang.c (go_language_defn): Likewise.
1076         * language.c (unknown_language_defn): Likewise.
1077         (auto_language_defn): Likewise.
1078         * m2-lang.c (m2_language_defn): Likewise.
1079         * objc-lang.c (objc_language_defn): Likewise.
1080         * opencl-lang.c (opencl_language_defn): Likewise.
1081         * p-lang.c (pascal_language_defn): Likewise.
1082         * rust-lang.c (rust_language_defn): Likewise.
1083
1084 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1085
1086         * ada-lang.c (ada_is_character_type): Change return type to bool.
1087         (ada_is_string_type): Likewise.
1088         * ada-lang.h (ada_is_character_type): Update declaration
1089         (ada_is_string_type): Likewise.
1090
1091 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1092
1093         Support style in 'frame|thread apply'
1094
1095         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1096         * record.c (record_start, record_stop): Update callers of
1097         execute_command_to_string with false.
1098         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1099         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1100         methods.
1101         (class string_file): New constructor with term_out parameter.
1102         Override methods term_out and can_emit_style_escape.  New member
1103         term_out.
1104         (class stdio_file): Override can_emit_style_escape.
1105         (class tee_file): Override term_out and can_emit_style_escape.
1106         * utils.h (can_emit_style_escape): Remove.
1107         * utils.c (can_emit_style_escape): Likewise.
1108         Update all callers of can_emit_style_escape (SOMESTREAM) to
1109         SOMESTREAM->can_emit_style_escape.
1110         * source-cache.c (source_cache::get_source_lines): Likewise.
1111         * stack.c (frame_apply_command_count): Call execute_command_to_string
1112         passing the term_out characteristic of the current gdb_stdout.
1113         * thread.c (thr_try_catch_cmd): Likewise.
1114         * top.c (execute_command_to_string): pass term_out parameter
1115         to construct the string_file for the command output.
1116         * ui-file.c (term_cli_styling): New function (most code moved
1117         from utils.c can_emit_style_escape).
1118         (string_file::string_file, string_file::can_emit_style_escape,
1119         stdio_file::can_emit_style_escape, tee_file::term_out,
1120         tee_file::can_emit_style_escape): New functions.
1121
1122 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1123
1124         * NEWS: Mention the new set|show may-call-functions.
1125         * infcall.c (may_call_functions_p): New variable.
1126         (show_may_call_functions_p): New function.
1127         (call_function_by_hand_dummy): Throws an error if not
1128         may-call-functions.
1129         (_initialize_infcall): Call add_setshow_boolean_cmd for
1130         may-call-functions.
1131
1132 2019-04-25  Keith Seitz  <keiths@redhat.com>
1133
1134         PR c++/24367
1135         * cp-support.c (inspect_type): Don't attempt substitutions
1136         of symbol with the same name.
1137
1138 2019-04-25  Tom Tromey  <tromey@adacore.com>
1139
1140         PR gdb/24475:
1141         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1142         static.
1143
1144 2019-04-25  Tom Tromey  <tromey@adacore.com>
1145
1146         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1147         rvalue reference.
1148         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1149         (gdb_xml_parser::parse): Use std::move.
1150         * python/python-internal.h (gdbpy_convert_exception): Take a const
1151         reference.
1152         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1153         std::move.
1154         * python/py-utils.c (gdbpy_convert_exception): Take a const
1155         reference.
1156         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1157         Use std::move.
1158         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1159         Use std::move.
1160         * mi/mi-main.c (mi_print_exception): Take a const reference.
1161         * main.c (handle_command_errors): Take a const reference.
1162         * linespec.c (parse_linespec): Use std::move.
1163         * infcall.c (run_inferior_call): Use std::move.
1164         (call_function_by_hand_dummy): Use std::move.
1165         * exec.c (try_open_exec_file): Use std::move.
1166         * exceptions.h (exception_print, exception_fprintf)
1167         (exception_print_same): Update.
1168         * exceptions.c (print_exception, exception_print)
1169         (exception_fprintf, exception_print_same): Change parameters to
1170         const reference.
1171         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1172         * common/new-op.c: Use std::move.
1173         * common/common-exceptions.h (struct gdb_exception): Add move
1174         constructor.
1175         (struct gdb_exception_error, struct gdb_exception_quit, struct
1176         gdb_quit_bad_alloc): Change constructor to move constructor.
1177         (throw_exception): Change parameter to rvalue reference.
1178         * common/common-exceptions.c (throw_exception): Take rvalue
1179         reference.
1180         * cli/cli-interp.c (safe_execute_command): Use std::move.
1181         * breakpoint.c (insert_bp_location, location_to_sals): Use
1182         std::move.
1183
1184 2019-04-25  Tom Tromey  <tromey@adacore.com>
1185
1186         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1187         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1188         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1189         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1190         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1191         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1192         guile/scm-value.c: Use unpack.
1193         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1194         gdbscm_gdb_exception.
1195         (gdbscm_throw_gdb_exception): Likewise.
1196         (struct gdbscm_gdb_exception): New.
1197         (unpack): New function.
1198         (gdbscm_wrap): Use unpack.
1199
1200 2019-04-25  Tom Tromey  <tromey@adacore.com>
1201
1202         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1203         (gdb_rl_callback_handler): Use std::move.
1204         * common/common-exceptions.h (struct gdb_exception): Add move
1205         assignment operator.
1206         (throw_exception_sjlj): Change "exception" to const reference.
1207         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1208         (throw_exception_sjlj): Change "exception" to const reference.
1209
1210 2019-04-25  Tom Tromey  <tromey@adacore.com>
1211
1212         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1213         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1214         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1215         Update.
1216         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1217         Update.
1218         * mi/mi-interp.c (mi_interp::exec): Update.
1219         * linespec.c (parse_linespec): Update.
1220         * infcall.c (run_inferior_call): Update.
1221         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1222         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1223         (gdbscm_lookup_global_symbol): Update.
1224         * guile/scm-param.c (gdbscm_parameter_value): Update.
1225         * guile/scm-frame.c (gdbscm_frame_read_register)
1226         (gdbscm_frame_read_var): Update.
1227         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1228         * exec.c (try_open_exec_file): Update.
1229         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1230         (gdb_rl_callback_handler): Update.
1231         * common/common-exceptions.h (exception_none): Don't declare.
1232         * common/common-exceptions.c (exception_none): Don't define.
1233         (struct catcher) <exception>: Update.
1234         * cli/cli-interp.c (safe_execute_command): Update.
1235         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1236
1237 2019-04-25  Ali Tamur  <tamur@google.com>
1238
1239         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1240         (read_attribute_value): Likewise.
1241         (dwarf2_read_addr_index): Update comment.
1242         (read_str_index): Add DW_FORM_strx.
1243         (dwarf2_string_attr): Likewise.
1244         (dwarf2_const_value_attr): Likewise.
1245         (dump_die_shallow): Likewise.
1246         (dwarf2_fetch_constant_bytes): Likewise.
1247         (skip_form_bytes): Likewise.
1248         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1249
1250 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1251
1252         PR corefiles/11608
1253         PR corefiles/18187
1254         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1255         OFFSET.  Verify if current mapping contains an ELF header.
1256         (linux_find_memory_regions_full): Adjust call to
1257         dump_mapping_p.
1258
1259 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1260             Kang Li <kanglictf@gmail.com>
1261
1262         PR gdb/21600
1263
1264         * dwarf2-frame.c (read_initial_length): Be consistent about using
1265         unsigned representation of length.
1266         (decode_frame_entry_1): Likewise.  Check for wraparound of
1267         end pointer as well as buffer overflow.
1268
1269 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1270
1271         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1272         "vq".
1273
1274 2019-04-24  Tom Tromey  <tromey@adacore.com>
1275
1276         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1277
1278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1279
1280         * s12z-tdep.c (s12z_unwind_pc): Delete.
1281         (s12z_unwind_sp): Delete.
1282         (s12z_gdbarch_init): Don't register deleted functions with
1283         gdbarch.
1284
1285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1286
1287         * rl78-tdep.c (rl78_unwind_sp): Delete.
1288         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1289
1290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1291
1292         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1293         (xstormy16_unwind_pc): Delete.
1294         (xstormy16_dummy_id): Delete.
1295         (xstormy16_gdbarch_init): Don't register deleted functions with
1296         gdbarch.
1297
1298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1299
1300         * vax-tdep.c (vax_unwind_pc): Delete.
1301         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1302
1303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * v850-tdep.c (v850_unwind_sp): Delete.
1306         (v850_unwind_pc): Delete.
1307         (v850_dummy_id): Delete.
1308         (v850_gdbarch_init): Don't register deleted functions with
1309         gdbarch.
1310
1311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1312
1313         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1314         (tilegx_unwind_pc): Delete.
1315         (tilegx_unwind_dummy_id): Delete.
1316         (tilegx_gdbarch_init): Don't register deleted functions with
1317         gdbarch.
1318
1319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1320
1321         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1322         (tic6x_dummy_id): Delete.
1323         (tic6x_gdbarch_init): Don't register deleted functions with
1324         gdbarch.
1325
1326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1327
1328         * sparc-tdep.c (sparc_unwind_pc): Delete.
1329         (sparc32_gdbarch_init): Don't register deleted function with
1330         gdbarch.
1331
1332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * sh-tdep.c (sh_unwind_sp): Delete.
1335         (sh_unwind_pc): Delete.
1336         (sh_dummy_id): Delete.
1337         (sh_gdbarch_init): Don't register deleted functions with
1338         gdbarch.
1339
1340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1341
1342         * score-tdep.c (score_unwind_sp): Delete.
1343         (score_unwind_pc): Delete.
1344         (score_dummy_id): Delete.
1345         (score_gdbarch_init): Don't register deleted functions with
1346         gdbarch.
1347
1348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1349
1350         * rx-tdep.c (rx_unwind_pc): Delete.
1351         (rx_unwind_sp): Delete.
1352         (rx_dummy_id): Delete.
1353         (rx_gdbarch_init): Don't register deleted functions with
1354         gdbarch.  Update comment.
1355
1356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1357
1358         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1359         (rs6000_dummy_id): Delete.
1360         (rs6000_gdbarch_init): Don't register deleted functions with
1361         gdbarch.
1362
1363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * or1k-tdep.c (or1k_dummy_id): Delete.
1366         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1367
1368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1369
1370         * nios2-tdep.c (nios2_dummy_id): Delete.
1371         (nios2_unwind_sp): Delete.
1372         (nios2_gdbarch_init): Don't register deleted functions with
1373         gdbarch.
1374
1375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1376
1377         * nds32-tdep.c (nds32_dummy_id): Delete.
1378         (nds32_unwind_pc): Delete.
1379         (nds32_unwind_sp): Delete.
1380         (nds32_gdbarch_init): Don't register deleted functions with
1381         gdbarch.
1382
1383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         * msp430-tdep.c (msp430_unwind_pc): Delete.
1386         (msp430_unwind_sp): Delete.
1387         (msp430_dummy_id): Delete.
1388         (msp430_gdbarch_init): Don't register deleted functions with
1389         gdbarch.
1390
1391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * moxie-tdep.c (moxie_unwind_sp): Delete.
1394         (moxie_unwind_pc): Delete.
1395         (moxie_dummy_id): Delete.
1396         (moxie_gdbarch_init): Don't register deleted functions with
1397         gdbarch.
1398
1399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1402         (mn10300_unwind_pc): Delete.
1403         (mn10300_unwind_sp): Delete.
1404         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1405         mn10300_unwind_sp.
1406         (mn10300_frame_unwind_init): Don't register deleted functions with
1407         gdbarch.
1408
1409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1410
1411         * mep-tdep.c (mep_unwind_pc): Delete.
1412         (mep_unwind_sp): Delete.
1413         (mep_dummy_id): Delete.
1414         (mep_gdbarch_init): Don't register deleted functions with
1415         gdbarch.
1416
1417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1418
1419         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1420         (m68hc11_unwind_sp): Delete.
1421         (m68hc11_gdbarch_init): Don't register deleted functions with
1422         gdbarch.
1423
1424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1425
1426         * m32r-tdep.c (m32r_unwind_sp): Delete.
1427         (m32r_unwind_pc): Delete.
1428         (m32r_dummy_id): Delete.
1429         (m32r_gdbarch_init): Don't register deleted functions with
1430         gdbarch.
1431
1432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1433
1434         * m32c-tdep.c (m32c_unwind_pc): Delete.
1435         (m32c_unwind_sp): Delete.
1436         (m32c_dummy_id): Delete.
1437         (m32c_gdbarch_init): Don't register deleted functions with
1438         gdbarch.
1439
1440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1441
1442         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1443         (lm32_unwind_pc): Delete.
1444         (lm32_dummy_id): Delete.
1445         (lm32_gdbarch_init): Don't register deleted functions with
1446         gdbarch.
1447
1448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1451         (iq2000_unwind_pc): Delete.
1452         (iq2000_dummy_id): Delete.
1453         (iq2000_gdbarch_init): Don't register deleted functions with
1454         gdbarch.
1455
1456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         * nds32-tdep.c (nds32_type_align): Delete.
1459         (nds32_push_dummy_call): Use type_align instead.
1460
1461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1462
1463         * arm-tdep.c (arm_type_align): Only handle vector override case.
1464         (arm_push_dummy_call): Use type_align.
1465         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1466
1467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1468
1469         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1470         case.
1471         (pass_on_stack): Use type_align.
1472         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1473         function.
1474
1475 2019-04-23  Tom Tromey  <tromey@adacore.com>
1476
1477         * dwarf2read.c (line_header::file_name_at): Remove unused
1478         overload.
1479
1480 2019-04-23  Tom de Vries  <tdevries@suse.de>
1481
1482         PR gdb/24438
1483         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1484         invocation.
1485
1486
1487 2019-03-27  Ali Tamur  <tamur@google.com>
1488
1489         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1490         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1491         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1492         (dwarf_expr_context::get_addr_index): Likewise
1493         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1494         (symbol_needs_eval_context::get_addr_index): Likewise
1495         (disassemble_dwarf_expression): Add DW_OP_addrx
1496         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1497         (read_cutu_die_from_dwo): Update comment
1498         (skip_one_die): Add DW_FORM_addrx
1499         (read_attribute_value): Likewise
1500         (var_decode_location): Add DW_OP_addrx
1501         (dwarf2_const_value_attr): Add DW_FORM_addrx
1502         (dump_die_shallow): Likewise
1503         (dwarf2_fetch_constant_bytes): Likewise
1504         (decode_locdesc): Add DW_OP_addrx
1505         (skip_form_bytes): Add DW_FORM_addrx
1506
1507 2019-04-22  Ali Tamur  <tamur@google.com>
1508
1509         * MAINTAINERS (Write After Approval): Add self.
1510
1511 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1512
1513         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1514         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1515         (open_symbol_file_object): Likewise.
1516         (svr4_default_sos): Add info parameter.
1517         (svr4_read_so_list): Likewise.
1518         (svr4_current_sos_direct): Adjust functions calls to pass down
1519         info.
1520         (svr4_current_sos_1): Add info parameter.
1521         (svr4_current_sos): Call get_svr4_info, pass info down to
1522         svr4_current_sos_1.
1523         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1524         get_svr4_info.
1525         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1526         get_svr4_info.
1527         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1528         to get_svr4_info.
1529         (probes_table_remove_objfile_probes): Likewise.
1530         (register_solib_event_probe): Add info parameter.
1531         (solist_update_incremental): Pass info parameter down to
1532         svr4_read_so_list.
1533         (disable_probes_interface): Add info parameter.
1534         (svr4_handle_solib_event): Pass current_program_space to
1535         get_svr4_info.  Adjust disable_probes_interface cleanup.
1536         (svr4_create_probe_breakpoints): Add info parameter, pass it
1537         down to register_solib_event_probe.
1538         (svr4_create_solib_event_breakpoints): Add info parameter,
1539         pass it down to svr4_create_probe_breakpoints.
1540         (enable_break): Pass info down to
1541         svr4_create_solib_event_breakpoints.
1542         (svr4_solib_create_inferior_hook): Pass current_program_space to
1543         get_svr4_info.
1544         (svr4_clear_solib): Likewise.
1545
1546 2019-04-22  Pedro Alves  <palves@redhat.com>
1547
1548         * solib-svr4.c (svr4_free_objfile_observer): New.
1549         (probe_and_action::objfile): New field.
1550         (probes_table_htab_remove_objfile_probes)
1551         (probes_table_remove_objfile_probes): New functions.
1552         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1553         in the new probe_and_action.  Don't store the probe in 'lookup'.
1554         (svr4_create_probe_breakpoints): Pass objfile to
1555         register_solib_event_probe.
1556         (_initialize_svr4_solib): Register a free_objfile observer.
1557
1558 2019-04-19  Tom Tromey  <tom@tromey.com>
1559
1560         * common/queue.h: Remove.
1561
1562 2019-04-19  Tom Tromey  <tom@tromey.com>
1563
1564         * event-loop.c: Don't include "common/queue.h".
1565
1566 2019-04-19  Tom Tromey  <tom@tromey.com>
1567
1568         * remote.c (remote_target): Use delete.
1569         * remote-notif.h: Include <list>, not "common/queue.h".
1570         (notif_client_p): Remove typedef.
1571         (remote_notif_state): Add constructor, destructor, initializer.
1572         <notif_queue>: Now a std::list.
1573         (remote_notif_state_xfree): Don't declare.
1574         * remote-notif.c (remote_notif_process, handle_notification)
1575         (remote_notif_state_allocate): Update.
1576         (~remote_notif_state): Rename from remote_notif_state_xfree.
1577
1578 2019-04-19  Tom Tromey  <tom@tromey.com>
1579
1580         * symfile.c (reread_symbols): Update.
1581         * objfiles.c (objfile_register_static_link)
1582         (objfile_lookup_static_link): Update
1583         (~objfile) Don't delete static_links.
1584         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1585
1586 2019-04-19  Tom Tromey  <tom@tromey.com>
1587
1588         * type-stack.h (struct type_stack) <insert>: Constify string.
1589         * type-stack.c (type_stack::insert): Constify string.
1590         * gdbtypes.h (lookup_template_type): Update.
1591         (address_space_name_to_int): Update.
1592         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1593         const.
1594         (lookup_template_type): Make name const.
1595         * c-exp.y: Update rules.
1596         (lex_one_token, classify_name, classify_inner_name)
1597         (c_print_token): Update.
1598         * p-exp.y: Update rules.
1599         (yylex): Update.
1600         * f-exp.y: Update rules.
1601         (yylex): Update.
1602         * d-exp.y: Update rules.
1603         (lex_one_token, classify_name, classify_inner_name): Update.
1604         * parse.c (write_dollar_variable, copy_name): Return std::string.
1605         * parser-defs.h (copy_name): Change return type.
1606         * m2-exp.y: Update rules.
1607         (yylex): Update.
1608         * go-exp.y (lex_one_token): Update.
1609         Update rules.
1610         (classify_unsafe_function, classify_packaged_name)
1611         (classify_name, yylex): Update.
1612
1613 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1614
1615         * configure.ac: add --enable-source-highlight switch.
1616         * configure: Regenerate.
1617         * top.c (print_gdb_version): plumb --enable-source-highlight
1618         status to "show configuration".
1619
1620 2019-04-19  Tom Tromey  <tromey@adacore.com>
1621
1622         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1623         Check ADA_TYPE_P.
1624         (empty_record, ada_template_to_fixed_record_type_1)
1625         (template_to_static_fixed_type)
1626         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1627         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1628         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1629         macros.
1630
1631 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1632
1633         PR symtab/24423:
1634         * source.c (print_source_lines_base): Advance "iter" when a
1635         control character is seen.
1636
1637 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1638
1639         * inferior.h (struct infcall_suspend_state_deleter):
1640         Catch exception in destructor to avoid crash.
1641
1642 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1643
1644         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1645         close to the add_com "shell".
1646
1647 2019-04-18  Tom Tromey  <tromey@adacore.com>
1648
1649         * process-stratum-target.h (class process_stratum_target)
1650         <stratum>: Add "final".
1651
1652 2019-04-17  Tom Tromey  <tromey@adacore.com>
1653
1654         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1655         against nullptr before use.
1656
1657 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1658
1659         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1660
1661 2019-04-17  Jim Wilson  <jimw@sifive.com>
1662             Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1665         code read might fail, assume 4-byte breakpoint in that case.
1666
1667 2019-04-15  Leszek Swirski  <leszeks@google.com>
1668
1669         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1670         rather than a hand-rolled POD check when checking for forced MEMORY
1671         classification.
1672
1673 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1674
1675         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1676         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1677         function.
1678         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1679         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1680         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1681         declaration.
1682
1683 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1684
1685         * aarch64-linux-nat.c
1686         (aarch64_linux_nat_target::thread_architecture): Add override.
1687         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1688         each VQ.
1689
1690 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1691
1692         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1693
1694 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1695
1696         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1697         target types of size 96-bits, add some additional comments, and
1698         check that the builtin type we found was the correct size.
1699
1700 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1701
1702         * utils.c (prompt_for_continue): Don't restore the styling at the
1703         end, as applied_style has the wrong value.  This fixes styling in
1704         long lists of file names that are interrupted by the "Continue?"
1705         prompt.
1706
1707 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1708
1709         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1710         * c-lang.c (c_language_defn): Likewise.
1711         (cplus_language_defn): Likewise.
1712         (asm_language_defn): Likewise.
1713         (minimal_language_defn): Likewise.
1714         * d-lang.c (d_language_defn): Likewise.
1715         * f-lang.c (f_language_defn): Likewise.
1716         * go-lang.c (go_language_defn): Likewise.
1717         * language.c (unknown_language_defn): Likewise.
1718         (auto_language_defn): Likewise.
1719         * language.h (struct language_defn): Remove la_magic field.
1720         (LANG_MAGIC): Delete.
1721         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1722         * objc-lang.c (objc_language_defn): Likewise.
1723         * opencl-lang.c (opencl_language_defn): Likewise.
1724         * p-lang.c (pascal_language_defn): Likewise.
1725         * rust-lang.c (rust_language_defn): Likewise.
1726
1727 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1728
1729         * riscv-tdep.c (riscv_type_align): New function.
1730         (riscv_type_alignment): Delete.
1731         (riscv_arg_location): Use 'type_align'.
1732         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1733
1734 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1735
1736         * gdbtypes.c (type_align): A struct with no non-static fields also
1737         has alignment of 1.
1738
1739 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1742         component to 0.
1743         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1744         member.
1745         (riscv_struct_info::analyse): New implementation using new
1746         analyse_inner member function.
1747         (riscv_struct_info::field_offset): New member function.
1748         (riscv_struct_info::m_offsets): New member variable.
1749         (riscv_struct_info::analyse_inner): New private member function,
1750         takes the old implementation of riscv_struct_info::analyse but
1751         extended to track field offsets.
1752         (riscv_call_arg_struct): Update the struct folding special cases
1753         to handle cases where empty C++ structs, which are non-zero
1754         length, are found.
1755         (riscv_arg_location): Initialise the length of each location, a
1756         non-zero length now indicates the location is in use.
1757         (riscv_push_dummy_call): Allow for the first location having a
1758         non-zero offset when setting up arguments.
1759         (riscv_return_value): Likewise, but for return values.
1760
1761 2019-04-11  Tom Tromey  <tromey@adacore.com>
1762
1763         * utils.c (internal_vproblem): Make "msg" const.
1764
1765 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1766
1767         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1768         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1769         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1770         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1771
1772 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1773
1774         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1775         function.
1776         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1777         of amd64_collect_native_gregset.
1778         (amd64_linux_nat_target::store_registers): Likewise.
1779
1780 2019-04-10  Tom Tromey  <tom@tromey.com>
1781
1782         * symtab.c (lookup_global_symbol_from_objfile)
1783         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1784         * objfiles.h (class separate_debug_iterator): New.
1785         (class separate_debug_range): New.
1786         (struct objfile) <separate_debug_objfiles>: New method.
1787         (objfile_separate_debug_iterate): Don't declare.
1788         * objfiles.c (separate_debug_iterator::operator++): Rename from
1789         objfile_separate_debug_iterate.
1790         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1791         iterator.
1792         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1793         iterator.
1794
1795 2019-04-10  Tom Tromey  <tom@tromey.com>
1796
1797         * symfile.c (reread_symbols): Remove old comment.
1798         * objfiles.c (free_all_objfiles): Fix a typo.
1799
1800 2019-04-10  Tom Tromey  <tom@tromey.com>
1801
1802         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1803         * minsyms.c (lookup_minimal_symbol): Use foreach.
1804         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1805         (lookup_minimal_symbol_solib_trampoline): Likewise.
1806         * symfile.c (reread_symbols): Use foreach.
1807
1808 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1809             Tom Tromey  <tromey@adacore.com>
1810
1811         PR rust/24414:
1812         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1813         (rust_lex_int_test): Change "value" to be LONGEST.
1814         (rust_lex_tests): Add test for long integer literal.
1815
1816 2019-04-09  Tom Tromey  <tromey@adacore.com>
1817
1818         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1819         to bool.
1820         (extended_remote_target::attach): Update.
1821         (remote_target::remote_notice_new_inferior): Update.
1822         (remote_target::add_current_inferior_and_thread): Update.
1823         * inferior.c (exit_inferior_1): Use "false".
1824         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1825
1826 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1827
1828         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1829         the "start" command.
1830
1831 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1832
1833         * python/py-inferior.c (infpy_thread_from_thread_handle):
1834         Adjust comments to reflect renaming of thread_from_thread_handle
1835         to thread_from_handle.  Adjust keywords.  Fix type error message.
1836         (inferior_object_methods): Add thread_from_handle.  Retain
1837         thread_from_thread_handle, but mark it as deprecated.
1838
1839 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1840
1841         * gdbthread.h (find_thread_by_handle): Revise declaration.
1842         * thread.c (find_thread_by_handle): Likewise.  Adjust
1843         implementation too.
1844         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1845         support for buffer objects as handles.
1846
1847 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1848
1849         * python/py-infthread.c (thpy_thread_handle): New function.
1850         (thread_object_methods): Register thpy_thread_handle.
1851
1852 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1853
1854         * gdbthread.h (thread_to_thread_handle): Declare.
1855         * thread.c (gdbtypes.h): Include.
1856         (thread_to_thread_handle): New function.
1857
1858         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1859         (target_thread_info_to_thread_handle): Declare.
1860         * target.c (target_thread_info_to_thread_handle): New function.
1861         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1862         * target-delegates.c: Regenerate.
1863
1864         * linux-thread-db.c (class thread_db_target): Add method
1865         thread_info_to_thread_handle.
1866         (thread_db_target::thread_info_to_thread_handle): Define.
1867         * remote.c (class remote_target): Add new method
1868         thread_info_to_thread_handle.
1869         (remote_target::thread_info_to_thread_handle): Define.
1870
1871 2019-04-08  Pedro Alves  <palves@redhat.com>
1872
1873         * common/common-exceptions.c (throw_exception): Don't create
1874         named object to throw; throw directly.
1875         (throw_it): Likewise.  Don't initialize gdb_exception::message
1876         here, with new; pass FMT and AP to the ctor instead.
1877         * common/common-exceptions.h: Include <string>.
1878         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1879         const char *, va_list)): New ctor.  Use std::make_shared.
1880         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1881         errors)): Delete.
1882         (gdb_exception_error::gdb_exception_error(enum errors, const char
1883         *, va_list)): New.
1884         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1885         Add assertion.
1886         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1887         errors)): Delete.
1888         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1889         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1890         Add assertion.
1891
1892 2019-04-08  Tom Tromey  <tom@tromey.com>
1893
1894         * valops.c (value_rtti_indirect_type): Replace throw_exception
1895         with throw.
1896         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1897         with throw.
1898         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1899         throw.
1900         * target.c (target_translate_tls_address): Replace throw_exception
1901         with throw.
1902         * stack.c (frame_apply_command_count): Replace throw_exception
1903         with throw.
1904         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1905         throw.
1906         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1907         with throw.
1908         * rs6000-tdep.c (rs6000_frame_cache)
1909         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1910         * remote.c: Replace throw_exception with throw.
1911         * record-full.c (record_full_message, record_full_wait_1)
1912         (record_full_restore): Replace throw_exception with throw.
1913         * record-btrace.c:
1914         (get_thread_current_frame_id, record_btrace_start_replaying)
1915         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1916         (cmd_record_btrace_start): Replace throw_exception with throw.
1917         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1918         throw.
1919         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1920         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1921         * linespec.c:
1922         (find_linespec_symbols): Replace throw_exception with throw.
1923         * infrun.c (displaced_step_prepare, resume): Replace
1924         throw_exception with throw.
1925         * infcmd.c (post_create_inferior): Replace throw_exception with
1926         throw.
1927         * inf-loop.c (inferior_event_handler): Replace throw_exception
1928         with throw.
1929         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1930         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1931         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1932         (get_prev_frame_always, get_frame_pc_if_available)
1933         (get_frame_address_in_block_if_available, get_frame_language):
1934         Replace throw_exception with throw.
1935         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1936         throw_exception with throw.
1937         * eval.c (fetch_subexp_value, evaluate_var_value)
1938         (evaluate_funcall, evaluate_subexp_standard): Replace
1939         throw_exception with throw.
1940         * dwarf2loc.c (call_site_find_chain)
1941         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1942         Replace throw_exception with throw.
1943         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1944         with throw.
1945         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1946         throw.
1947         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1948         * completer.c (complete_line_internal): Replace throw_exception
1949         with throw.
1950         * compile/compile-object-run.c (compile_object_run): Replace
1951         throw_exception with throw.
1952         * cli/cli-script.c (process_next_line): Replace throw_exception
1953         with throw.
1954         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1955         (btrace_enable, btrace_maint_update_pt_packets): Replace
1956         throw_exception with throw.
1957         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1958         throw_exception with throw.
1959         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1960         throw_exception with throw.
1961         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1962         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1963         * aarch64-tdep.c (aarch64_make_prologue_cache)
1964         (aarch64_make_stub_cache): Replace throw_exception with throw.
1965
1966 2019-04-08  Tom Tromey  <tom@tromey.com>
1967
1968         * common/common-exceptions.c (throw_exception): Rename from
1969         throw_exception_cxx.  Remove old copy.  Make argument const.
1970         (throw_it): Create and throw exception objects directly.
1971         * common/common-exceptions.h (throw_exception): Make argument
1972         const.
1973         (struct gdb_exception_error): Add constructor.
1974         (struct gdb_exception_quit): Add constructor.
1975
1976 2019-04-08  Tom Tromey  <tom@tromey.com>
1977
1978         * common/common-exceptions.h (exception_rethrow): Don't declare.
1979         (TRY_SJLJ): Update comment.
1980         (TRY, CATCH, END_CATCH): Remove.
1981         * common/common-exceptions.c (exception_rethrow): Remove.
1982
1983 2019-04-08  Tom Tromey  <tom@tromey.com>
1984
1985         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1986         Remove.
1987         (gdb_exception_error): Rename from
1988         gdb_exception_RETURN_MASK_ERROR.
1989         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1990         (gdb_quit_bad_alloc): Update.
1991         * aarch64-tdep.c: Update.
1992         * ada-lang.c: Update.
1993         * ada-typeprint.c: Update.
1994         * ada-valprint.c: Update.
1995         * amd64-tdep.c: Update.
1996         * arch-utils.c: Update.
1997         * break-catch-throw.c: Update.
1998         * breakpoint.c: Update.
1999         * btrace.c: Update.
2000         * c-varobj.c: Update.
2001         * cli/cli-cmds.c: Update.
2002         * cli/cli-interp.c: Update.
2003         * cli/cli-script.c: Update.
2004         * common/common-exceptions.c: Update.
2005         * common/new-op.c: Update.
2006         * common/selftest.c: Update.
2007         * compile/compile-c-symbols.c: Update.
2008         * compile/compile-cplus-symbols.c: Update.
2009         * compile/compile-object-load.c: Update.
2010         * compile/compile-object-run.c: Update.
2011         * completer.c: Update.
2012         * corelow.c: Update.
2013         * cp-abi.c: Update.
2014         * cp-support.c: Update.
2015         * cp-valprint.c: Update.
2016         * darwin-nat.c: Update.
2017         * disasm-selftests.c: Update.
2018         * dtrace-probe.c: Update.
2019         * dwarf-index-cache.c: Update.
2020         * dwarf-index-write.c: Update.
2021         * dwarf2-frame-tailcall.c: Update.
2022         * dwarf2-frame.c: Update.
2023         * dwarf2loc.c: Update.
2024         * dwarf2read.c: Update.
2025         * eval.c: Update.
2026         * event-loop.c: Update.
2027         * event-top.c: Update.
2028         * exec.c: Update.
2029         * f-valprint.c: Update.
2030         * fbsd-tdep.c: Update.
2031         * frame-unwind.c: Update.
2032         * frame.c: Update.
2033         * gdbtypes.c: Update.
2034         * gnu-v3-abi.c: Update.
2035         * guile/guile-internal.h: Update.
2036         * guile/scm-block.c: Update.
2037         * guile/scm-breakpoint.c: Update.
2038         * guile/scm-cmd.c: Update.
2039         * guile/scm-disasm.c: Update.
2040         * guile/scm-frame.c: Update.
2041         * guile/scm-lazy-string.c: Update.
2042         * guile/scm-math.c: Update.
2043         * guile/scm-param.c: Update.
2044         * guile/scm-ports.c: Update.
2045         * guile/scm-pretty-print.c: Update.
2046         * guile/scm-symbol.c: Update.
2047         * guile/scm-symtab.c: Update.
2048         * guile/scm-type.c: Update.
2049         * guile/scm-value.c: Update.
2050         * i386-linux-tdep.c: Update.
2051         * i386-tdep.c: Update.
2052         * inf-loop.c: Update.
2053         * infcall.c: Update.
2054         * infcmd.c: Update.
2055         * infrun.c: Update.
2056         * jit.c: Update.
2057         * language.c: Update.
2058         * linespec.c: Update.
2059         * linux-fork.c: Update.
2060         * linux-nat.c: Update.
2061         * linux-tdep.c: Update.
2062         * linux-thread-db.c: Update.
2063         * main.c: Update.
2064         * mi/mi-cmd-break.c: Update.
2065         * mi/mi-cmd-stack.c: Update.
2066         * mi/mi-interp.c: Update.
2067         * mi/mi-main.c: Update.
2068         * objc-lang.c: Update.
2069         * p-valprint.c: Update.
2070         * parse.c: Update.
2071         * ppc-linux-tdep.c: Update.
2072         * printcmd.c: Update.
2073         * python/py-arch.c: Update.
2074         * python/py-breakpoint.c: Update.
2075         * python/py-cmd.c: Update.
2076         * python/py-finishbreakpoint.c: Update.
2077         * python/py-frame.c: Update.
2078         * python/py-framefilter.c: Update.
2079         * python/py-gdb-readline.c: Update.
2080         * python/py-inferior.c: Update.
2081         * python/py-infthread.c: Update.
2082         * python/py-lazy-string.c: Update.
2083         * python/py-linetable.c: Update.
2084         * python/py-objfile.c: Update.
2085         * python/py-param.c: Update.
2086         * python/py-prettyprint.c: Update.
2087         * python/py-progspace.c: Update.
2088         * python/py-record-btrace.c: Update.
2089         * python/py-record.c: Update.
2090         * python/py-symbol.c: Update.
2091         * python/py-type.c: Update.
2092         * python/py-unwind.c: Update.
2093         * python/py-utils.c: Update.
2094         * python/py-value.c: Update.
2095         * python/python.c: Update.
2096         * record-btrace.c: Update.
2097         * record-full.c: Update.
2098         * remote-fileio.c: Update.
2099         * remote.c: Update.
2100         * riscv-tdep.c: Update.
2101         * rs6000-aix-tdep.c: Update.
2102         * rs6000-tdep.c: Update.
2103         * rust-exp.y: Update.
2104         * rust-lang.c: Update.
2105         * s390-tdep.c: Update.
2106         * selftest-arch.c: Update.
2107         * solib-dsbt.c: Update.
2108         * solib-frv.c: Update.
2109         * solib-spu.c: Update.
2110         * solib-svr4.c: Update.
2111         * solib.c: Update.
2112         * sparc64-linux-tdep.c: Update.
2113         * stack.c: Update.
2114         * symfile-mem.c: Update.
2115         * symmisc.c: Update.
2116         * target.c: Update.
2117         * thread.c: Update.
2118         * top.c: Update.
2119         * tracefile-tfile.c: Update.
2120         * tui/tui.c: Update.
2121         * typeprint.c: Update.
2122         * unittests/cli-utils-selftests.c: Update.
2123         * unittests/parse-connection-spec-selftests.c: Update.
2124         * valops.c: Update.
2125         * valprint.c: Update.
2126         * value.c: Update.
2127         * varobj.c: Update.
2128         * windows-nat.c: Update.
2129         * x86-linux-nat.c: Update.
2130         * xml-support.c: Update.
2131
2132 2019-04-08  Tom Tromey  <tom@tromey.com>
2133
2134         * xml-support.c: Use C++ exception handling.
2135         * x86-linux-nat.c: Use C++ exception handling.
2136         * windows-nat.c: Use C++ exception handling.
2137         * varobj.c: Use C++ exception handling.
2138         * value.c: Use C++ exception handling.
2139         * valprint.c: Use C++ exception handling.
2140         * valops.c: Use C++ exception handling.
2141         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2142         handling.
2143         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2144         * typeprint.c: Use C++ exception handling.
2145         * tui/tui.c: Use C++ exception handling.
2146         * tracefile-tfile.c: Use C++ exception handling.
2147         * top.c: Use C++ exception handling.
2148         * thread.c: Use C++ exception handling.
2149         * target.c: Use C++ exception handling.
2150         * symmisc.c: Use C++ exception handling.
2151         * symfile-mem.c: Use C++ exception handling.
2152         * stack.c: Use C++ exception handling.
2153         * sparc64-linux-tdep.c: Use C++ exception handling.
2154         * solib.c: Use C++ exception handling.
2155         * solib-svr4.c: Use C++ exception handling.
2156         * solib-spu.c: Use C++ exception handling.
2157         * solib-frv.c: Use C++ exception handling.
2158         * solib-dsbt.c: Use C++ exception handling.
2159         * selftest-arch.c: Use C++ exception handling.
2160         * s390-tdep.c: Use C++ exception handling.
2161         * rust-lang.c: Use C++ exception handling.
2162         * rust-exp.y: Use C++ exception handling.
2163         * rs6000-tdep.c: Use C++ exception handling.
2164         * rs6000-aix-tdep.c: Use C++ exception handling.
2165         * riscv-tdep.c: Use C++ exception handling.
2166         * remote.c: Use C++ exception handling.
2167         * remote-fileio.c: Use C++ exception handling.
2168         * record-full.c: Use C++ exception handling.
2169         * record-btrace.c: Use C++ exception handling.
2170         * python/python.c: Use C++ exception handling.
2171         * python/py-value.c: Use C++ exception handling.
2172         * python/py-utils.c: Use C++ exception handling.
2173         * python/py-unwind.c: Use C++ exception handling.
2174         * python/py-type.c: Use C++ exception handling.
2175         * python/py-symbol.c: Use C++ exception handling.
2176         * python/py-record.c: Use C++ exception handling.
2177         * python/py-record-btrace.c: Use C++ exception handling.
2178         * python/py-progspace.c: Use C++ exception handling.
2179         * python/py-prettyprint.c: Use C++ exception handling.
2180         * python/py-param.c: Use C++ exception handling.
2181         * python/py-objfile.c: Use C++ exception handling.
2182         * python/py-linetable.c: Use C++ exception handling.
2183         * python/py-lazy-string.c: Use C++ exception handling.
2184         * python/py-infthread.c: Use C++ exception handling.
2185         * python/py-inferior.c: Use C++ exception handling.
2186         * python/py-gdb-readline.c: Use C++ exception handling.
2187         * python/py-framefilter.c: Use C++ exception handling.
2188         * python/py-frame.c: Use C++ exception handling.
2189         * python/py-finishbreakpoint.c: Use C++ exception handling.
2190         * python/py-cmd.c: Use C++ exception handling.
2191         * python/py-breakpoint.c: Use C++ exception handling.
2192         * python/py-arch.c: Use C++ exception handling.
2193         * printcmd.c: Use C++ exception handling.
2194         * ppc-linux-tdep.c: Use C++ exception handling.
2195         * parse.c: Use C++ exception handling.
2196         * p-valprint.c: Use C++ exception handling.
2197         * objc-lang.c: Use C++ exception handling.
2198         * mi/mi-main.c: Use C++ exception handling.
2199         * mi/mi-interp.c: Use C++ exception handling.
2200         * mi/mi-cmd-stack.c: Use C++ exception handling.
2201         * mi/mi-cmd-break.c: Use C++ exception handling.
2202         * main.c: Use C++ exception handling.
2203         * linux-thread-db.c: Use C++ exception handling.
2204         * linux-tdep.c: Use C++ exception handling.
2205         * linux-nat.c: Use C++ exception handling.
2206         * linux-fork.c: Use C++ exception handling.
2207         * linespec.c: Use C++ exception handling.
2208         * language.c: Use C++ exception handling.
2209         * jit.c: Use C++ exception handling.
2210         * infrun.c: Use C++ exception handling.
2211         * infcmd.c: Use C++ exception handling.
2212         * infcall.c: Use C++ exception handling.
2213         * inf-loop.c: Use C++ exception handling.
2214         * i386-tdep.c: Use C++ exception handling.
2215         * i386-linux-tdep.c: Use C++ exception handling.
2216         * guile/scm-value.c: Use C++ exception handling.
2217         * guile/scm-type.c: Use C++ exception handling.
2218         * guile/scm-symtab.c: Use C++ exception handling.
2219         * guile/scm-symbol.c: Use C++ exception handling.
2220         * guile/scm-pretty-print.c: Use C++ exception handling.
2221         * guile/scm-ports.c: Use C++ exception handling.
2222         * guile/scm-param.c: Use C++ exception handling.
2223         * guile/scm-math.c: Use C++ exception handling.
2224         * guile/scm-lazy-string.c: Use C++ exception handling.
2225         * guile/scm-frame.c: Use C++ exception handling.
2226         * guile/scm-disasm.c: Use C++ exception handling.
2227         * guile/scm-cmd.c: Use C++ exception handling.
2228         * guile/scm-breakpoint.c: Use C++ exception handling.
2229         * guile/scm-block.c: Use C++ exception handling.
2230         * guile/guile-internal.h: Use C++ exception handling.
2231         * gnu-v3-abi.c: Use C++ exception handling.
2232         * gdbtypes.c: Use C++ exception handling.
2233         * frame.c: Use C++ exception handling.
2234         * frame-unwind.c: Use C++ exception handling.
2235         * fbsd-tdep.c: Use C++ exception handling.
2236         * f-valprint.c: Use C++ exception handling.
2237         * exec.c: Use C++ exception handling.
2238         * event-top.c: Use C++ exception handling.
2239         * event-loop.c: Use C++ exception handling.
2240         * eval.c: Use C++ exception handling.
2241         * dwarf2read.c: Use C++ exception handling.
2242         * dwarf2loc.c: Use C++ exception handling.
2243         * dwarf2-frame.c: Use C++ exception handling.
2244         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2245         * dwarf-index-write.c: Use C++ exception handling.
2246         * dwarf-index-cache.c: Use C++ exception handling.
2247         * dtrace-probe.c: Use C++ exception handling.
2248         * disasm-selftests.c: Use C++ exception handling.
2249         * darwin-nat.c: Use C++ exception handling.
2250         * cp-valprint.c: Use C++ exception handling.
2251         * cp-support.c: Use C++ exception handling.
2252         * cp-abi.c: Use C++ exception handling.
2253         * corelow.c: Use C++ exception handling.
2254         * completer.c: Use C++ exception handling.
2255         * compile/compile-object-run.c: Use C++ exception handling.
2256         * compile/compile-object-load.c: Use C++ exception handling.
2257         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2258         * compile/compile-c-symbols.c: Use C++ exception handling.
2259         * common/selftest.c: Use C++ exception handling.
2260         * common/new-op.c: Use C++ exception handling.
2261         * cli/cli-script.c: Use C++ exception handling.
2262         * cli/cli-interp.c: Use C++ exception handling.
2263         * cli/cli-cmds.c: Use C++ exception handling.
2264         * c-varobj.c: Use C++ exception handling.
2265         * btrace.c: Use C++ exception handling.
2266         * breakpoint.c: Use C++ exception handling.
2267         * break-catch-throw.c: Use C++ exception handling.
2268         * arch-utils.c: Use C++ exception handling.
2269         * amd64-tdep.c: Use C++ exception handling.
2270         * ada-valprint.c: Use C++ exception handling.
2271         * ada-typeprint.c: Use C++ exception handling.
2272         * ada-lang.c: Use C++ exception handling.
2273         * aarch64-tdep.c: Use C++ exception handling.
2274
2275 2019-04-08  Tom Tromey  <tom@tromey.com>
2276
2277         * xml-support.c (gdb_xml_parser::parse): Update.
2278         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2279         * value.c (show_convenience): Update.
2280         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2281         (test_parse_flags_qcs): Update.
2282         * thread.c (thr_try_catch_cmd): Update.
2283         * target.c (target_translate_tls_address): Update.
2284         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2285         (info_frame_command_core, frame_apply_command_count): Update.
2286         * rust-exp.y (rust_lex_exception_test): Update.
2287         * riscv-tdep.c (riscv_print_one_register_info): Update.
2288         * remote.c (remote_target::enable_btrace): Update.
2289         * record-btrace.c (record_btrace_enable_warn): Update.
2290         * python/py-utils.c (gdbpy_convert_exception): Update.
2291         * printcmd.c (do_one_display, print_variable_and_value): Update.
2292         * mi/mi-main.c (mi_print_exception): Update.
2293         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2294         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2295         * linux-nat.c (linux_nat_target::attach): Update.
2296         * linux-fork.c (class scoped_switch_fork_info): Update.
2297         * infrun.c (displaced_step_prepare): Update.
2298         * infcall.c (call_function_by_hand_dummy): Update.
2299         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2300         * gnu-v3-abi.c (print_one_vtable): Update.
2301         * frame.c (get_prev_frame_always): Update.
2302         * f-valprint.c (info_common_command_for_block): Update.
2303         * exec.c (try_open_exec_file): Update.
2304         * exceptions.c (print_exception, exception_print)
2305         (exception_fprintf, exception_print_same): Update.
2306         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2307         * dwarf-index-cache.c (index_cache::store)
2308         (index_cache::lookup_gdb_index): Update.
2309         * darwin-nat.c (maybe_cache_shell): Update.
2310         * cp-valprint.c (cp_print_value_fields): Update.
2311         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2312         (gcc_cplus_symbol_address): Update.
2313         * compile/compile-c-symbols.c (gcc_convert_symbol)
2314         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2315         * common/selftest.c: Update.
2316         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2317         a std::string.
2318         (exception_try_scope_entry, exception_try_scope_exit): Don't
2319         declare.
2320         (struct exception_try_scope): Remove.
2321         (TRY): Don't use exception_try_scope.
2322         (struct gdb_exception): Add constructor, operator=.
2323         <what>: New method.
2324         (struct gdb_exception_RETURN_MASK_ALL)
2325         (struct gdb_exception_RETURN_MASK_ERROR)
2326         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2327         (struct gdb_quit_bad_alloc): Update.
2328         * common/common-exceptions.c (exception_none): Change
2329         initializer.
2330         (struct catcher) <state, exception>: Initialize inline.
2331         <prev>: Remove member.
2332         (current_catcher): Remove.
2333         (catchers): New global.
2334         (exceptions_state_mc_init): Simplify.
2335         (catcher_pop): Remove.
2336         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2337         (try_scope_depth, exception_try_scope_entry)
2338         (exception_try_scope_exit): Remove.
2339         (throw_exception_sjlj): Update.
2340         (exception_messages, exception_messages_size): Remove.
2341         (throw_it): Simplify.
2342         (gdb_exception_sliced_copy): Remove.
2343         (throw_exception_cxx): Update.
2344         * cli/cli-script.c (script_from_file): Update.
2345         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2346         Update.
2347         * ada-valprint.c (ada_val_print): Update.
2348         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2349         (create_excep_cond_exprs): Update.
2350
2351 2019-04-08  Tom Tromey  <tom@tromey.com>
2352
2353         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2354         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2355         (TRY, CATCH, END_CATCH): Remove some definitions.
2356         * common/common-exceptions.c: Don't use GDB_XCPT.
2357         (catcher_list_size): Remove.
2358         (throw_exception, throw_it): Simplify.
2359
2360 2019-04-05  Tom Tromey  <tom@tromey.com>
2361
2362         Revert the header-sorting patch.
2363         * ft32-tdep.c: Revert.
2364         * frv-tdep.c: Revert.
2365         * frv-linux-tdep.c: Revert.
2366         * frame.c: Revert.
2367         * frame-unwind.c: Revert.
2368         * frame-base.c: Revert.
2369         * fork-child.c: Revert.
2370         * findvar.c: Revert.
2371         * findcmd.c: Revert.
2372         * filesystem.c: Revert.
2373         * filename-seen-cache.h: Revert.
2374         * filename-seen-cache.c: Revert.
2375         * fbsd-tdep.c: Revert.
2376         * fbsd-nat.h: Revert.
2377         * fbsd-nat.c: Revert.
2378         * f-valprint.c: Revert.
2379         * f-typeprint.c: Revert.
2380         * f-lang.c: Revert.
2381         * extension.h: Revert.
2382         * extension.c: Revert.
2383         * extension-priv.h: Revert.
2384         * expprint.c: Revert.
2385         * exec.h: Revert.
2386         * exec.c: Revert.
2387         * exceptions.c: Revert.
2388         * event-top.c: Revert.
2389         * event-loop.c: Revert.
2390         * eval.c: Revert.
2391         * elfread.c: Revert.
2392         * dwarf2read.h: Revert.
2393         * dwarf2read.c: Revert.
2394         * dwarf2loc.c: Revert.
2395         * dwarf2expr.h: Revert.
2396         * dwarf2expr.c: Revert.
2397         * dwarf2-frame.c: Revert.
2398         * dwarf2-frame-tailcall.c: Revert.
2399         * dwarf-index-write.h: Revert.
2400         * dwarf-index-write.c: Revert.
2401         * dwarf-index-common.c: Revert.
2402         * dwarf-index-cache.h: Revert.
2403         * dwarf-index-cache.c: Revert.
2404         * dummy-frame.c: Revert.
2405         * dtrace-probe.c: Revert.
2406         * disasm.h: Revert.
2407         * disasm.c: Revert.
2408         * disasm-selftests.c: Revert.
2409         * dictionary.c: Revert.
2410         * dicos-tdep.c: Revert.
2411         * demangle.c: Revert.
2412         * dcache.h: Revert.
2413         * dcache.c: Revert.
2414         * darwin-nat.h: Revert.
2415         * darwin-nat.c: Revert.
2416         * darwin-nat-info.c: Revert.
2417         * d-valprint.c: Revert.
2418         * d-namespace.c: Revert.
2419         * d-lang.c: Revert.
2420         * ctf.c: Revert.
2421         * csky-tdep.c: Revert.
2422         * csky-linux-tdep.c: Revert.
2423         * cris-tdep.c: Revert.
2424         * cris-linux-tdep.c: Revert.
2425         * cp-valprint.c: Revert.
2426         * cp-support.c: Revert.
2427         * cp-namespace.c: Revert.
2428         * cp-abi.c: Revert.
2429         * corelow.c: Revert.
2430         * corefile.c: Revert.
2431         * continuations.c: Revert.
2432         * completer.h: Revert.
2433         * completer.c: Revert.
2434         * complaints.c: Revert.
2435         * coffread.c: Revert.
2436         * coff-pe-read.c: Revert.
2437         * cli-out.h: Revert.
2438         * cli-out.c: Revert.
2439         * charset.c: Revert.
2440         * c-varobj.c: Revert.
2441         * c-valprint.c: Revert.
2442         * c-typeprint.c: Revert.
2443         * c-lang.c: Revert.
2444         * buildsym.c: Revert.
2445         * buildsym-legacy.c: Revert.
2446         * build-id.h: Revert.
2447         * build-id.c: Revert.
2448         * btrace.c: Revert.
2449         * bsd-uthread.c: Revert.
2450         * breakpoint.h: Revert.
2451         * breakpoint.c: Revert.
2452         * break-catch-throw.c: Revert.
2453         * break-catch-syscall.c: Revert.
2454         * break-catch-sig.c: Revert.
2455         * blockframe.c: Revert.
2456         * block.c: Revert.
2457         * bfin-tdep.c: Revert.
2458         * bfin-linux-tdep.c: Revert.
2459         * bfd-target.c: Revert.
2460         * bcache.c: Revert.
2461         * ax-general.c: Revert.
2462         * ax-gdb.h: Revert.
2463         * ax-gdb.c: Revert.
2464         * avr-tdep.c: Revert.
2465         * auxv.c: Revert.
2466         * auto-load.c: Revert.
2467         * arm-wince-tdep.c: Revert.
2468         * arm-tdep.c: Revert.
2469         * arm-symbian-tdep.c: Revert.
2470         * arm-pikeos-tdep.c: Revert.
2471         * arm-obsd-tdep.c: Revert.
2472         * arm-nbsd-tdep.c: Revert.
2473         * arm-nbsd-nat.c: Revert.
2474         * arm-linux-tdep.c: Revert.
2475         * arm-linux-nat.c: Revert.
2476         * arm-fbsd-tdep.c: Revert.
2477         * arm-fbsd-nat.c: Revert.
2478         * arm-bsd-tdep.c: Revert.
2479         * arch-utils.c: Revert.
2480         * arc-tdep.c: Revert.
2481         * arc-newlib-tdep.c: Revert.
2482         * annotate.h: Revert.
2483         * annotate.c: Revert.
2484         * amd64-windows-tdep.c: Revert.
2485         * amd64-windows-nat.c: Revert.
2486         * amd64-tdep.c: Revert.
2487         * amd64-sol2-tdep.c: Revert.
2488         * amd64-obsd-tdep.c: Revert.
2489         * amd64-obsd-nat.c: Revert.
2490         * amd64-nbsd-tdep.c: Revert.
2491         * amd64-nbsd-nat.c: Revert.
2492         * amd64-nat.c: Revert.
2493         * amd64-linux-tdep.c: Revert.
2494         * amd64-linux-nat.c: Revert.
2495         * amd64-fbsd-tdep.c: Revert.
2496         * amd64-fbsd-nat.c: Revert.
2497         * amd64-dicos-tdep.c: Revert.
2498         * amd64-darwin-tdep.c: Revert.
2499         * amd64-bsd-nat.c: Revert.
2500         * alpha-tdep.c: Revert.
2501         * alpha-obsd-tdep.c: Revert.
2502         * alpha-nbsd-tdep.c: Revert.
2503         * alpha-mdebug-tdep.c: Revert.
2504         * alpha-linux-tdep.c: Revert.
2505         * alpha-linux-nat.c: Revert.
2506         * alpha-bsd-tdep.c: Revert.
2507         * alpha-bsd-nat.c: Revert.
2508         * aix-thread.c: Revert.
2509         * agent.c: Revert.
2510         * addrmap.c: Revert.
2511         * ada-varobj.c: Revert.
2512         * ada-valprint.c: Revert.
2513         * ada-typeprint.c: Revert.
2514         * ada-tasks.c: Revert.
2515         * ada-lang.c: Revert.
2516         * aarch64-tdep.c: Revert.
2517         * aarch64-ravenscar-thread.c: Revert.
2518         * aarch64-newlib-tdep.c: Revert.
2519         * aarch64-linux-tdep.c: Revert.
2520         * aarch64-linux-nat.c: Revert.
2521         * aarch64-fbsd-tdep.c: Revert.
2522         * aarch64-fbsd-nat.c: Revert.
2523         * aarch32-linux-nat.c: Revert.
2524
2525 2019-04-05  Tom Tromey  <tom@tromey.com>
2526
2527         * ft32-tdep.c: Sort headers.
2528         * frv-tdep.c: Sort headers.
2529         * frv-linux-tdep.c: Sort headers.
2530         * frame.c: Sort headers.
2531         * frame-unwind.c: Sort headers.
2532         * frame-base.c: Sort headers.
2533         * fork-child.c: Sort headers.
2534         * findvar.c: Sort headers.
2535         * findcmd.c: Sort headers.
2536         * filesystem.c: Sort headers.
2537         * filename-seen-cache.h: Sort headers.
2538         * filename-seen-cache.c: Sort headers.
2539         * fbsd-tdep.c: Sort headers.
2540         * fbsd-nat.h: Sort headers.
2541         * fbsd-nat.c: Sort headers.
2542         * f-valprint.c: Sort headers.
2543         * f-typeprint.c: Sort headers.
2544         * f-lang.c: Sort headers.
2545         * extension.h: Sort headers.
2546         * extension.c: Sort headers.
2547         * extension-priv.h: Sort headers.
2548         * expprint.c: Sort headers.
2549         * exec.h: Sort headers.
2550         * exec.c: Sort headers.
2551         * exceptions.c: Sort headers.
2552         * event-top.c: Sort headers.
2553         * event-loop.c: Sort headers.
2554         * eval.c: Sort headers.
2555         * elfread.c: Sort headers.
2556         * dwarf2read.h: Sort headers.
2557         * dwarf2read.c: Sort headers.
2558         * dwarf2loc.c: Sort headers.
2559         * dwarf2expr.h: Sort headers.
2560         * dwarf2expr.c: Sort headers.
2561         * dwarf2-frame.c: Sort headers.
2562         * dwarf2-frame-tailcall.c: Sort headers.
2563         * dwarf-index-write.h: Sort headers.
2564         * dwarf-index-write.c: Sort headers.
2565         * dwarf-index-common.c: Sort headers.
2566         * dwarf-index-cache.h: Sort headers.
2567         * dwarf-index-cache.c: Sort headers.
2568         * dummy-frame.c: Sort headers.
2569         * dtrace-probe.c: Sort headers.
2570         * disasm.h: Sort headers.
2571         * disasm.c: Sort headers.
2572         * disasm-selftests.c: Sort headers.
2573         * dictionary.c: Sort headers.
2574         * dicos-tdep.c: Sort headers.
2575         * demangle.c: Sort headers.
2576         * dcache.h: Sort headers.
2577         * dcache.c: Sort headers.
2578         * darwin-nat.h: Sort headers.
2579         * darwin-nat.c: Sort headers.
2580         * darwin-nat-info.c: Sort headers.
2581         * d-valprint.c: Sort headers.
2582         * d-namespace.c: Sort headers.
2583         * d-lang.c: Sort headers.
2584         * ctf.c: Sort headers.
2585         * csky-tdep.c: Sort headers.
2586         * csky-linux-tdep.c: Sort headers.
2587         * cris-tdep.c: Sort headers.
2588         * cris-linux-tdep.c: Sort headers.
2589         * cp-valprint.c: Sort headers.
2590         * cp-support.c: Sort headers.
2591         * cp-namespace.c: Sort headers.
2592         * cp-abi.c: Sort headers.
2593         * corelow.c: Sort headers.
2594         * corefile.c: Sort headers.
2595         * continuations.c: Sort headers.
2596         * completer.h: Sort headers.
2597         * completer.c: Sort headers.
2598         * complaints.c: Sort headers.
2599         * coffread.c: Sort headers.
2600         * coff-pe-read.c: Sort headers.
2601         * cli-out.h: Sort headers.
2602         * cli-out.c: Sort headers.
2603         * charset.c: Sort headers.
2604         * c-varobj.c: Sort headers.
2605         * c-valprint.c: Sort headers.
2606         * c-typeprint.c: Sort headers.
2607         * c-lang.c: Sort headers.
2608         * buildsym.c: Sort headers.
2609         * buildsym-legacy.c: Sort headers.
2610         * build-id.h: Sort headers.
2611         * build-id.c: Sort headers.
2612         * btrace.c: Sort headers.
2613         * bsd-uthread.c: Sort headers.
2614         * breakpoint.h: Sort headers.
2615         * breakpoint.c: Sort headers.
2616         * break-catch-throw.c: Sort headers.
2617         * break-catch-syscall.c: Sort headers.
2618         * break-catch-sig.c: Sort headers.
2619         * blockframe.c: Sort headers.
2620         * block.c: Sort headers.
2621         * bfin-tdep.c: Sort headers.
2622         * bfin-linux-tdep.c: Sort headers.
2623         * bfd-target.c: Sort headers.
2624         * bcache.c: Sort headers.
2625         * ax-general.c: Sort headers.
2626         * ax-gdb.h: Sort headers.
2627         * ax-gdb.c: Sort headers.
2628         * avr-tdep.c: Sort headers.
2629         * auxv.c: Sort headers.
2630         * auto-load.c: Sort headers.
2631         * arm-wince-tdep.c: Sort headers.
2632         * arm-tdep.c: Sort headers.
2633         * arm-symbian-tdep.c: Sort headers.
2634         * arm-pikeos-tdep.c: Sort headers.
2635         * arm-obsd-tdep.c: Sort headers.
2636         * arm-nbsd-tdep.c: Sort headers.
2637         * arm-nbsd-nat.c: Sort headers.
2638         * arm-linux-tdep.c: Sort headers.
2639         * arm-linux-nat.c: Sort headers.
2640         * arm-fbsd-tdep.c: Sort headers.
2641         * arm-fbsd-nat.c: Sort headers.
2642         * arm-bsd-tdep.c: Sort headers.
2643         * arch-utils.c: Sort headers.
2644         * arc-tdep.c: Sort headers.
2645         * arc-newlib-tdep.c: Sort headers.
2646         * annotate.h: Sort headers.
2647         * annotate.c: Sort headers.
2648         * amd64-windows-tdep.c: Sort headers.
2649         * amd64-windows-nat.c: Sort headers.
2650         * amd64-tdep.c: Sort headers.
2651         * amd64-sol2-tdep.c: Sort headers.
2652         * amd64-obsd-tdep.c: Sort headers.
2653         * amd64-obsd-nat.c: Sort headers.
2654         * amd64-nbsd-tdep.c: Sort headers.
2655         * amd64-nbsd-nat.c: Sort headers.
2656         * amd64-nat.c: Sort headers.
2657         * amd64-linux-tdep.c: Sort headers.
2658         * amd64-linux-nat.c: Sort headers.
2659         * amd64-fbsd-tdep.c: Sort headers.
2660         * amd64-fbsd-nat.c: Sort headers.
2661         * amd64-dicos-tdep.c: Sort headers.
2662         * amd64-darwin-tdep.c: Sort headers.
2663         * amd64-bsd-nat.c: Sort headers.
2664         * alpha-tdep.c: Sort headers.
2665         * alpha-obsd-tdep.c: Sort headers.
2666         * alpha-nbsd-tdep.c: Sort headers.
2667         * alpha-mdebug-tdep.c: Sort headers.
2668         * alpha-linux-tdep.c: Sort headers.
2669         * alpha-linux-nat.c: Sort headers.
2670         * alpha-bsd-tdep.c: Sort headers.
2671         * alpha-bsd-nat.c: Sort headers.
2672         * aix-thread.c: Sort headers.
2673         * agent.c: Sort headers.
2674         * addrmap.c: Sort headers.
2675         * ada-varobj.c: Sort headers.
2676         * ada-valprint.c: Sort headers.
2677         * ada-typeprint.c: Sort headers.
2678         * ada-tasks.c: Sort headers.
2679         * ada-lang.c: Sort headers.
2680         * aarch64-tdep.c: Sort headers.
2681         * aarch64-ravenscar-thread.c: Sort headers.
2682         * aarch64-newlib-tdep.c: Sort headers.
2683         * aarch64-linux-tdep.c: Sort headers.
2684         * aarch64-linux-nat.c: Sort headers.
2685         * aarch64-fbsd-tdep.c: Sort headers.
2686         * aarch64-fbsd-nat.c: Sort headers.
2687         * aarch32-linux-nat.c: Sort headers.
2688
2689 2019-04-04  Tom Tromey  <tom@tromey.com>
2690
2691         * varobj.c (varobj_create): Update.
2692         * rust-exp.y (struct rust_parser) <update_innermost_block,
2693         lookup_symbol>: New methods.
2694         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2695         Rename.
2696         (rust_parser::rust_lookup_type)
2697         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2698         * printcmd.c (display_command, do_one_display): Update.
2699         * parser-defs.h (struct parser_state) <parser_state>: Add
2700         "tracker" parameter.
2701         (block_tracker): New member.
2702         (class innermost_block_tracker) <innermost_block_tracker>: Add
2703         "types" parameter.
2704         <reset>: Remove method.
2705         (innermost_block): Don't declare.
2706         (null_post_parser): Update.
2707         * parse.c (innermost_block): Remove global.
2708         (write_dollar_variable): Update.
2709         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2710         Remove "tracker_types" parameter.
2711         (parse_expression): Add "tracker" parameter.
2712         (parse_expression_for_completion): Update.
2713         (null_post_parser): Add "tracker" parameter.
2714         * p-exp.y: Update rules.
2715         * m2-exp.y: Update rules.
2716         * language.h (struct language_defn) <la_post_parser>: Add
2717         "tracker" parameter.
2718         * go-exp.y: Update rules.
2719         * f-exp.y: Update rules.
2720         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2721         parameter.
2722         * d-exp.y: Update rules.
2723         * c-exp.y: Update rules.
2724         * breakpoint.c (set_breakpoint_condition): Create an
2725         innermost_block_tracker.
2726         (watch_command_1): Likewise.
2727         * ada-lang.c (resolve): Add "tracker" parameter.
2728         (resolve_subexp): Likewise.
2729         * ada-exp.y (write_var_from_sym): Update.
2730
2731 2019-04-04  Tom Tromey  <tom@tromey.com>
2732
2733         * type-stack.h: New file.
2734         * type-stack.c: New file.
2735         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2736         type-stack.h.
2737         (insert_into_type_stack, insert_type, push_type, push_type_int)
2738         (insert_type_address_space, pop_type, pop_type_int)
2739         (pop_typelist, pop_type_stack, append_type_stack)
2740         (push_type_stack, get_type_stack, push_typelist)
2741         (follow_type_instance_flags, follow_types): Don't declare.
2742         * parse.c (type_stack): Remove global.
2743         (parse_exp_in_context): Update.
2744         (insert_into_type_stack, insert_type, push_type, push_type_int)
2745         (insert_type_address_space, pop_type, pop_type_int)
2746         (pop_typelist, pop_type_stack, append_type_stack)
2747         (push_type_stack, get_type_stack, push_typelist)
2748         (follow_type_instance_flags, follow_types): Remove (moved to
2749         type-stack.c).
2750         * f-exp.y (type_stack): New global.
2751         Update rules.
2752         (push_kind_type, f_parse): Update.
2753         * d-exp.y (type_stack): New global.
2754         Update rules.
2755         (d_parse): Update.
2756         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2757         Update rules.
2758         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2759         (HFILES_NO_SRCDIR): Add type-stack.h.
2760
2761 2019-04-04  Tom Tromey  <tom@tromey.com>
2762
2763         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2764         (rust_parser::convert_ast_to_expression, rust_parse)
2765         (rust_lex_test_completion, rust_lex_tests): Update.
2766         * parser-defs.h (struct expr_completion_state): New.
2767         (struct parser_state) <parser_state>: Add completion parameter.
2768         <mark_struct_expression, mark_completion_tag>: New methods.
2769         <parse_completion, m_completion_state>: New members.
2770         (prefixify_expression, null_post_parser): Update.
2771         (mark_struct_expression, mark_completion_tag): Don't declare.
2772         * parse.c (parse_completion, expout_last_struct)
2773         (expout_tag_completion_type, expout_completion_name): Remove
2774         globals.
2775         (parser_state::mark_struct_expression)
2776         (parser_state::mark_completion_tag): Now methods.
2777         (prefixify_expression): Add last_struct parameter.
2778         (prefixify_subexp): Likewise.
2779         (parse_exp_1): Update.
2780         (parse_exp_in_context): Add cstate parameter.  Update.
2781         (parse_expression_for_completion): Create an
2782         expr_completion_state.
2783         (null_post_parser): Add "completion" parameter.
2784         * p-exp.y: Update rules.
2785         (yylex): Update.
2786         * language.h (struct language_defn) <la_post_parser>: Add
2787         "completing" parameter.
2788         * go-exp.y: Update rules.
2789         (lex_one_token): Update.
2790         * expression.h (parse_completion): Don't declare.
2791         * d-exp.y: Update rules.
2792         (lex_one_token): Update rules.
2793         * c-exp.y: Update rules.
2794         (lex_one_token): Update.
2795         * ada-lang.c (resolve): Add "parse_completion" parameter.
2796         (resolve_subexp): Likewise.
2797         (ada_resolve_function): Likewise.
2798
2799 2019-04-04  Tom Tromey  <tom@tromey.com>
2800
2801         * parser-defs.h (struct parser_state) <start_arglist,
2802         end_arglist>: New methods.
2803         <arglist_len, m_funcall_chain>: New members.
2804         (arglist_len, start_arglist, end_arglist): Don't declare.
2805         * parse.c (arglist_len, funcall_chain): Remove global.
2806         (start_arglist, end_arglist): Remove functions.
2807         (parse_exp_in_context): Update.
2808         * p-exp.y: Update rules.
2809         * m2-exp.y: Update rules.
2810         * go-exp.y: Update rules.
2811         * f-exp.y: Update rules.
2812         * d-exp.y: Update rules.
2813         * c-exp.y: Update rules.
2814
2815 2019-04-04  Tom Tromey  <tom@tromey.com>
2816
2817         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2818         lex_operator, push_back>: New methods.
2819         Update all rules.
2820         (rust_parser::lex_hex, lex_escape): Rename and update.
2821         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2822         (rust_parser::lex_operator): Rename and update.
2823         (rust_parser::lex_number, rustyylex, rustyyerror)
2824         (rust_lex_test_init, rust_lex_test_sequence)
2825         (rust_lex_test_push_back, rust_lex_tests): Update.
2826         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2827         parameter.
2828         <lexptr, prev_lexptr>: New members.
2829         (lexptr, prev_lexptr): Don't declare.
2830         * parse.c (lexptr, prev_lexptr): Remove globals.
2831         (parse_exp_in_context): Update.
2832         * p-exp.y (yylex, yyerror): Update.
2833         * m2-exp.y (parse_number, yylex, yyerror): Update.
2834         * go-exp.y (lex_one_token, yyerror): Update.
2835         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2836         * d-exp.y (lex_one_token, yyerror): Update.
2837         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2838         (lex_one_token, yyerror): Update.
2839         * ada-lex.l (YY_INPUT): Update.
2840         (rewind_to_char): Update.
2841         * ada-exp.y (yyerror): Update.
2842
2843 2019-04-04  Tom Tromey  <tom@tromey.com>
2844
2845         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2846         * parser-defs.h (struct parser_state) <parser_state>: Add new
2847         parameter.
2848         <comma_terminates>: New member.
2849         (comma_terminates): Don't declare global.
2850         * parse.c (comma_terminates): Remove global.
2851         (parse_exp_in_context): Update.
2852         * p-exp.y (yylex): Update.
2853         * m2-exp.y (yylex): Update.
2854         * go-exp.y (lex_one_token): Update.
2855         * f-exp.y (yylex): Update.
2856         * d-exp.y (lex_one_token): Update.
2857         * c-exp.y (lex_one_token): Update.
2858         * ada-lex.l: Update.
2859
2860 2019-04-04  Tom Tromey  <tom@tromey.com>
2861
2862         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2863         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2864         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2865         * parser-defs.h (paren_depth): Don't declare.
2866         * parse.c (paren_depth): Remove global.
2867         (parse_exp_in_context): Update.
2868         * p-exp.y (paren_depth): New global.
2869         (pascal_parse): Initialize it.
2870         * m2-exp.y (paren_depth): New global.
2871         (m2_parse): Initialize it.
2872         * go-exp.y (paren_depth): New global.
2873         (go_parse): Initialize it.
2874         * f-exp.y (paren_depth): New global.
2875         (f_parse): Initialize it.
2876         * d-exp.y (paren_depth): New global.
2877         (d_parse): Initialize it.
2878         * c-exp.y (paren_depth): New global.
2879         (c_parse): Initialize it.
2880         * ada-lex.l (paren_depth): New global.
2881         (lexer_init): Initialize it.
2882
2883 2019-04-04  Tom Tromey  <tom@tromey.com>
2884
2885         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2886         (rust_parser::convert_ast_to_type)
2887         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2888         * parser-defs.h (struct parser_state) <parser_state>: Add
2889         parameters.  Initialize new members.
2890         <expression_context_block, expression_context_pc>: New members.
2891         * parse.c (expression_context_block, expression_context_pc):
2892         Remove globals.
2893         (parse_exp_in_context): Update.
2894         * p-exp.y: Update all rules.
2895         (yylex): Update.
2896         * m2-exp.y: Update all rules.
2897         (yylex): Update.
2898         * go-exp.y (yylex): Update.
2899         * f-exp.y (yylex): Update.
2900         * d-exp.y: Update all rules.
2901         (yylex): Update.
2902         * c-exp.y: Update all rules.
2903         (lex_one_token, classify_name, yylex, c_parse): Update.
2904         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2905
2906 2019-04-04  Tom Tromey  <tom@tromey.com>
2907
2908         * gdbarch.h, gdbarch.c: Rebuild.
2909         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2910         * stap-probe.h:
2911         (struct stap_parse_info): Replace "parser_state" with
2912         "expr_builder".
2913         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2914         (parser_state): New class.
2915         * parse.c (expr_builder): Rename.
2916         (expr_builder::release): Rename.
2917         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2918         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2919         (write_exp_elt_longcst, write_exp_elt_floatcst)
2920         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2921         (write_exp_string_vector, write_exp_bitstring)
2922         (write_exp_msymbol, mark_struct_expression)
2923         (write_dollar_variable)
2924         (insert_type_address_space, increase_expout_size): Replace
2925         "parser_state" with "expr_builder".
2926         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2927         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2928         "parser_state" with "expr_builder".
2929
2930 2019-04-04  Tom Tromey  <tom@tromey.com>
2931
2932         * rust-exp.y: Replace "parse_language" with method call.
2933         * p-exp.y:
2934         (yylex): Replace "parse_language" with method call.
2935         * m2-exp.y:
2936         (yylex): Replace "parse_language" with method call.
2937         * go-exp.y (classify_name): Replace "parse_language" with method
2938         call.
2939         * f-exp.y (yylex): Replace "parse_language" with method call.
2940         * d-exp.y (lex_one_token): Replace "parse_language" with method
2941         call.
2942         * c-exp.y:
2943         (lex_one_token, classify_name, yylex): Replace "parse_language"
2944         with method call.
2945         * ada-exp.y (find_primitive_type, type_char)
2946         (type_system_address): Replace "parse_language" with method call.
2947
2948 2019-04-04  Tom Tromey  <tom@tromey.com>
2949
2950         * rust-exp.y: Replace "parse_gdbarch" with method call.
2951         * parse.c (write_dollar_variable, insert_type_address_space):
2952         Replace "parse_gdbarch" with method call.
2953         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2954         call.
2955         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2956         call.
2957         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2958         "parse_gdbarch" with method call.
2959         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2960         with method call.
2961         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2962         "parse_gdbarch" with method call.
2963         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2964         "parse_gdbarch" with method call.
2965         * c-exp.y (parse_type, parse_number, classify_name): Replace
2966         "parse_gdbarch" with method call.
2967         * ada-lex.l: Replace "parse_gdbarch" with method call.
2968         * ada-exp.y (parse_type, find_primitive_type, type_char)
2969         (type_system_address): Replace "parse_gdbarch" with method call.
2970
2971 2019-04-04  Tom Tromey  <tom@tromey.com>
2972
2973         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2974         * stap-probe.c (stap_parse_argument): Update.
2975         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2976         initial_size parameter.
2977         * rust-exp.y (rust_lex_tests): Update.
2978         * parse.c (parser_state): Update.
2979         (parse_exp_in_context): Update.
2980         * parser-defs.h (struct parser_state) <parser_state>: Remove
2981         "initial_size" parameter.
2982
2983 2019-04-04  Tom Tromey  <tom@tromey.com>
2984
2985         * parser-defs.h (increase_expout_size): Don't declare.
2986         * parse.c (increase_expout_size): Now static.
2987
2988 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2989
2990         * gnu-nat.c (gnu_nat_target::wait): Fix
2991         target_waitstatus_to_string call.
2992
2993 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2994
2995         * eval.c (evaluate_subexp_standard): Handle internal functions
2996         during Fortran function call handling.
2997
2998 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2999
3000         * NEWS: Mention new internal functions.
3001         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3002         (read_base_type): Use dwarf2_init_complex_target_type.
3003         * value.c (creal_internal_fn): New function.
3004         (cimag_internal_fn): New function.
3005         (_initialize_values): Register new internal functions.
3006
3007 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3008
3009         * infrun.c (stop_all_threads): If debug_infrun, always
3010         trace the wait status after wait_one, using
3011         target_waitstatus_to_string and target_pid_to_str.
3012         (handle_inferior_event): Replace various trace of
3013         wait status kind by a single trace.
3014         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3015         wait status kind image by target_waitstatus_to_string.
3016         * target/waitstatus.c (target_waitstatus_to_string): Fix
3017         obsolete comment.
3018
3019 2019-04-01  Tom Tromey  <tromey@adacore.com>
3020
3021         PR symtab/23331:
3022         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3023
3024 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3025             Pedro Alves  <palves@redhat.com>
3026
3027         * top.c (quit_force): Call 'finalize_values'.
3028         * value.c (finalize_values): New function.
3029         * value.h (finalize_values): Declare.
3030
3031 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3032
3033         * NEWS: Announce $_gdb_major and $_gdb_minor.
3034
3035         * top.c (init_gdb_version_vars): New function.
3036         (gdb_init): Call init_gdb_version_vars.
3037
3038 2019-03-29  Tom Tromey  <tromey@adacore.com>
3039
3040         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3041         help text.  Remove dead code.
3042
3043 2019-03-29  Keith Seitz  <keiths@redhat.com>
3044
3045         From Siddhesh Poyarekar:
3046         * f-lang.h (f77_get_upperbound): Return LONGEST.
3047         (f77_get_lowerbound): Likewise.
3048         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3049         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3050         print them.
3051         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3052         plongest to format print it.
3053         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3054         (f77_get_upperbound): Likewise.
3055         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3056         LOWER_BOUND to LONGEST.
3057         (f77_create_arrayprint_offset_tbl): Likewise.
3058
3059 2019-03-29  Keith Seitz  <keiths@redhat.com>
3060
3061         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3062         %s/pulongest for TYPE_LENGTH instead of %d in format
3063         strings.
3064         * ada-typerint.c (ada_print_type): Likewise.
3065         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3066         * compile/compile-c-support.c (generate_register_struct): Likewise.
3067         * gdbtypes.c (recursive_dump_type): Likewise.
3068         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3069         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3070         instead of %d in format strings.
3071         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3072         to std::min to ULONGEST.
3073         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3074         instead of %d in format strings.
3075         * tracepoint.c (info_scope_command): Likewise.
3076         * typeprint.c (print_offset_data::update)
3077         (print_offset_data::finish): Likewise.
3078         * xtensa-tdep.c (xtensa_store_return_value)
3079         (xtensa_push_dummy_call): Likewise.
3080
3081 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3082
3083         * windows-nat.c (display_selector): Fixed format specifications
3084         for 64-bit Cygwin.
3085
3086 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3087
3088         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3089
3090 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3091
3092         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3093         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3094         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3095         (nios2_linux_init_abi): Install it.
3096
3097 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3098
3099         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3100
3101 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3102
3103         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3104
3105 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3106             Tom Tromey  <tromey@adacore.com>
3107
3108         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3109
3110 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3111
3112         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3113         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3114         method to compute the bounds of range types. Also print "[evaluated]"
3115         if the bounds' values come from a dynamic evaluation.
3116
3117 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3118
3119         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3120         whitespace when pretty printing is on.
3121
3122 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3123
3124         * ppc-linux-nat.c: Add include.
3125
3126 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3127
3128         * NEWS: Mention AArch64 Pointer Authentication.
3129
3130 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3131
3132         * arm-linux-nat.c: Add include.
3133
3134 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3135
3136         * source-cache.c (source_cache::get_source_lines): Re-read
3137         fullname after calling open_source_file.
3138
3139 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3140
3141         * NEWS: Mention TLS support for FreeBSD.
3142
3143 2019-03-25  Tom Tromey  <tromey@adacore.com>
3144
3145         * minsyms.c (BUNCH_SIZE): Update comment.
3146         (~minimal_symbol_reader): Remove old comment.
3147         (compact_minimal_symbols): Update comment.
3148         (minimal_symbol_reader::install): Remove old comment.  Update
3149         other comments.
3150
3151 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3152
3153         * s390-linux-nat.c: Add include.
3154
3155 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3156
3157         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3158         Call linux_get_hwcap.
3159         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3160         Likewise.
3161         (aarch64_linux_get_hwcap): Remove function.
3162         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3163         declaration.
3164         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3165         linux_get_hwcap.
3166         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3167         * linux-tdep.c (linux_get_hwcap): Add function.
3168         (linux_get_hwcap2): Likewise.
3169         * linux-tdep.h (linux_get_hwcap): Add declaration.
3170         (linux_get_hwcap2): Likewise.
3171         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3172         (ppc_linux_get_hwcap2): Likewise.
3173         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3174         linux_get_hwcap.
3175         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3176         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3177         (ppc_linux_nat_target::read_description): Likewise.
3178         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3179         * s390-linux-nat.c: Likewise.
3180         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3181
3182 2019-03-24  Tom Tromey  <tom@tromey.com>
3183
3184         * ada-lang.c (standard_lookup): Simplify initialization.
3185         (ada_lookup_symbol_nonlocal): Simplify return.
3186         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3187         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3188         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3189         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3190         initialization.
3191         * solib.c (solib_global_lookup): Simplify.
3192         * symtab.c (null_block_symbol): Remove.
3193         (symbol_cache_lookup): Simplify returns.
3194         (lookup_language_this): Simplify returns.
3195         (lookup_symbol_aux): Simplify return.
3196         (lookup_local_symbol): Simplify returns.
3197         (lookup_global_symbol_from_objfile): Simplify return.
3198         (lookup_symbol_in_objfile_symtabs)
3199         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3200         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3201         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3202         * cp-namespace.c (cp_lookup_bare_symbol)
3203         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3204         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3205         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3206         (cp_lookup_symbol_via_imports): Simplify initialization.
3207         (find_symbol_in_baseclass): Likewise.
3208         * symtab.h (null_block_symbol): Remove.
3209         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3210         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3211         (d_lookup_symbol_module): Likewise.
3212         (find_symbol_in_baseclass): Simplify initialization.
3213
3214 2019-03-24  Tom Tromey  <tom@tromey.com>
3215
3216         * expression.h: Don't include symtab.h.
3217         (struct block): Forward declare.
3218
3219 2019-03-24  Tom Tromey  <tom@tromey.com>
3220
3221         * c-exp.y (typebase): Remove casts.
3222         * gdbtypes.c (lookup_unsigned_typename, )
3223         (lookup_signed_typename): Remove cast.
3224         * eval.c (parse_to_comma_and_eval): Remove cast.
3225         * parse.c (write_dollar_variable): Remove cast.
3226         * block.h (struct block) <superblock>: Now const.
3227         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3228         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3229         (map_block): Make "block" const.
3230         * symfile.h (struct quick_symbol_functions)
3231         <map_matching_symbols>: Constify block argument to "callback".
3232         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3233         const.
3234         (find_pc_sect_compunit_symtab): Make "b" const.
3235         (find_symbol_at_address): Likewise.
3236         (search_symbols): Likewise.
3237         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3238         (dw2_debug_names_lookup_symbol): Likewise.
3239         (dw2_map_matching_symbols): Update.
3240         * p-valprint.c (pascal_val_print): Remove "block".
3241         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3242         (aux_add_nonlocal_symbols): Make "block" const.
3243         (resolve_subexp): Remove cast.
3244         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3245         const.
3246         (iterate_over_file_blocks): Likewise.
3247         * f-exp.y (%union) <bval>: Remove.
3248         * coffread.c (patch_opaque_types): Make "b" const.
3249         * spu-tdep.c (spu_catch_start): Make "block" const.
3250         * c-valprint.c (print_unpacked_pointer): Remove "block".
3251         * symmisc.c (dump_symtab_1): Make "b" const.
3252         (block_depth): Make "block" const.
3253         * d-exp.y (%union) <bval>: Remove.
3254         * cp-support.h (cp_lookup_rtti_type): Update.
3255         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3256         * psymtab.c (psym_lookup_symbol): Make "block" const.
3257         (maintenance_check_psymtabs): Make "b" const.
3258         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3259         (enumerate_locals, enumerate_args): Update.
3260         * python/py-symtab.c (stpy_global_block): Make "block" const.
3261         (stpy_static_block): Likewise.
3262         * inline-frame.c (block_starting_point_at): Make "new_block"
3263         const.
3264         * block.c (find_block_in_blockvector): Make return type const.
3265         (blockvector_for_pc_sect): Make "b" const.
3266         (find_block_in_blockvector): Make "b" const.
3267
3268 2019-03-23  Tom Tromey  <tom@tromey.com>
3269
3270         * varobj.c (varobj_create): Update.
3271         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3272         * printcmd.c (display_command, do_one_display): Don't reset
3273         innermost_block.
3274         * parser-defs.h (enum innermost_block_tracker_type): Move to
3275         expression.h.
3276         (innermost_block): Update comment.
3277         * parse.c (parse_exp_1): Add tracker_types parameter.
3278         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3279         tracker_types parameter.  Reset innermost_block.
3280         (parse_exp_in_context): Remove.
3281         (parse_expression_for_completion): Update.
3282         * objfiles.c (~objfile): Don't reset expression_context_block or
3283         innermost_block.
3284         * expression.h (enum innermost_block_tracker_type): Move from
3285         parser-defs.h.
3286         (parse_exp_1): Add tracker_types parameter.
3287         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3288         reset innermost_block.
3289
3290 2019-03-23  Tom Tromey  <tom@tromey.com>
3291
3292         * objfiles.h: Include bcache.h.
3293
3294 2019-03-23  Tom Tromey  <tom@tromey.com>
3295
3296         * linespec.c (get_current_search_block): Use
3297         scoped_restore_current_language.
3298         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3299
3300 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3301             Jiong Wang  <jiong.wang@arm.com>
3302
3303         * aarch64-linux-tdep.c
3304         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3305         section.
3306         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3307
3308 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3309             Jiong Wang  <jiong.wang@arm.com>
3310
3311         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3312         instructions.
3313         (aarch64_analyze_prologue_test): Add PACIASP test.
3314         (aarch64_prologue_prev_register): Unmask PC value.
3315
3316 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3317             Jiong Wang  <jiong.wang@arm.com>
3318
3319         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3320         (aarch64_dwarf2_prev_register): Unmask PC value.
3321         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3322         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3323         DW_CFA_AARCH64_negate_ra_state.
3324         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3325
3326 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3327             Jiong Wang  <jiong.wang@arm.com>
3328
3329         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3330         registers.
3331         (aarch64_pseudo_register_name): Likewise.
3332         (aarch64_pseudo_register_type): Likewise.
3333         (aarch64_pseudo_register_reggroup_p): Likewise.
3334         (aarch64_gdbarch_init): Add pauth registers.
3335         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3336         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3337         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3338         (struct gdbarch_tdep): Add regnum for ra_state.
3339
3340 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3341             Jiong Wang  <jiong.wang@arm.com>
3342
3343         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3344
3345 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3346             Jiong Wang  <jiong.wang@arm.com>
3347
3348         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3349         function.
3350         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3351         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3352         (aarch64_gdbarch_init): Add puth registers.
3353         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3354         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3355         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3356
3357 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3358             Jiong Wang  <jiong.wang@arm.com>
3359
3360         * aarch64-linux-nat.c
3361         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3362         * aarch64-linux-tdep.c
3363         (aarch64_linux_core_read_description): Likewise.
3364         (aarch64_linux_get_hwcap): New function.
3365         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3366         (aarch64_linux_get_hwcap): New declaration.
3367
3368 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3369             Jiong Wang  <jiong.wang@arm.com>
3370
3371         * aarch64-linux-nat.c
3372         (aarch64_linux_nat_target::read_description): Add pauth param.
3373         * aarch64-linux-tdep.c
3374         (aarch64_linux_core_read_description): Likewise.
3375         * aarch64-tdep.c (struct target_desc): Add in pauth.
3376         (aarch64_read_description): Add pauth param.
3377         (aarch64_gdbarch_init): Likewise.
3378         * aarch64-tdep.h (aarch64_read_description): Likewise.
3379         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3380         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3381         * features/Makefile: Add new files.
3382         * features/aarch64-pauth.c: New file.
3383         * features/aarch64-pauth.xml: New file.
3384
3385 2019-03-20  Tom Tromey  <tromey@adacore.com>
3386
3387         * infrun.c (handle_inferior_event): Rename from
3388         handle_inferior_event_1.  Create a scoped_value_mark.
3389         (handle_inferior_event): Remove.
3390
3391 2019-03-19  Tom Tromey  <tromey@adacore.com>
3392
3393         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3394         * infrun.h (print_stop_event): Add "displays" parameter.
3395         * infrun.c (print_stop_event): Add "displays" parameter.
3396
3397 2019-03-19  Pedro Alves  <palves@redhat.com>
3398
3399         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3400         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3401         to -1.  Fix TABs vs spaces.
3402         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3403         * tui/tui-out.h (tui_ui_out) Add intro comments.
3404         <m_line, m_start_of_line>: In-class initialize, and add describing
3405         comment.
3406
3407 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3408
3409         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3410         variable names.
3411         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3412
3413 2019-03-18  Pedro Alves  <palves@redhat.com>
3414             Eli Zaretskii <eliz@gnu.org>
3415
3416         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3417         m_line and m_start_of_line.
3418
3419 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3420
3421         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3422         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3423         it returns a newline.  This fixes a regression in TU mode, whereby
3424         the next line is output on the same screen line as the user input.
3425
3426 2019-03-18  Tom Tromey  <tromey@adacore.com>
3427
3428         * minsyms.c (minimal_symbol_reader::install): Remove call to
3429         obstack_blank.
3430
3431 2019-03-18  Pedro Alves  <palves@redhat.com>
3432
3433         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3434         New globals.
3435         (apply_style): New, factored out from ...
3436         (apply_ansi_escape): ... this.  Handle reverse video mode.
3437         (tui_set_reverse_mode): New function.
3438         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3439         * tui/tui-winsource.c (tui_show_source_line): Use
3440         tui_set_reverse_mode instead of setting A_STANDOUT.
3441         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3442         New setter methods.
3443
3444 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3445
3446         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3447         Handle tabs.
3448
3449 2019-03-18  Tom Tromey  <tromey@adacore.com>
3450
3451         * ada-lang.c (empty_array): Add "high" parameter.
3452         (ada_evaluate_subexp): Update.
3453
3454 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3455
3456         * unittests/string_view-selftests.c: Define
3457         _initialize_string_view_selftests unconditionally.
3458
3459 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3460
3461         PR gdb/24350
3462         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3463
3464 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3465
3466         PR gdb/24351
3467         * windows-nat.c (display_selector): Fix format specifiers.
3468
3469 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3470
3471         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3472         tui_refill_source_window instead of tui_refresh_win, to update the
3473         current execution line.  This fixes redisplay of the current line
3474         when stepping through the code with "next" or "step".
3475
3476 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3477
3478         * source-cache.c (source_cache::get_source_lines): Call
3479         find_source_lines to initialize s->nlines.  This fixes vertical
3480         scrolling of TUI source window when the DOWN arrow is pressed.
3481
3482 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3483
3484         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3485         linux-thread-db.c (_initialize_thread_db): Likewise.
3486
3487 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3488
3489         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3490         wclrtoeol in tui_show_source_line".  This reverts changes made in
3491         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3492
3493 2019-03-15  Tom Tromey  <tom@tromey.com>
3494
3495         * symtab.h (struct minimal_symbol): Derive from
3496         general_symbol_info.
3497         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3498         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3499         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3500         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3501         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3502         (MSYMBOL_SEARCH_NAME): Update.
3503         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3504         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3505         * minsyms.c (minimal_symbol_reader::record_full): Update.
3506
3507 2019-03-15  Tom Tromey  <tom@tromey.com>
3508
3509         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3510
3511 2019-03-15  Tom Tromey  <tom@tromey.com>
3512
3513         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3514         unique_xmalloc_ptr.
3515         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3516         Update.
3517         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3518         (build_minimal_symbol_hash_tables)
3519         (minimal_symbol_reader::install): Update.
3520
3521 2019-03-15  Tom Tromey  <tom@tromey.com>
3522
3523         * symtab.c (create_demangled_names_hash): Update.
3524         (symbol_set_names): Update.
3525         * objfiles.h (struct objfile_per_bfd_storage)
3526         <demangled_names_hash>: Now an htab_up.
3527         * objfiles.c (objfile_per_bfd_storage): Simplify.
3528
3529 2019-03-15  Tom Tromey  <tom@tromey.com>
3530
3531         * objfiles.h (struct objfile_per_bfd_storage): Declare
3532         destructor.
3533         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3534         New.
3535         (get_objfile_bfd_data): Use new.  Don't initialize
3536         language_of_main.
3537         (free_objfile_per_bfd_storage): Remove.
3538         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3539
3540 2019-03-15  Tom Tromey  <tom@tromey.com>
3541
3542         * symfile.c (reread_symbols): Update.
3543         * objfiles.c (objfile::objfile): Update.
3544         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3545         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3546         comment.
3547         (minimal_symbol_reader::install): Update.
3548         (terminate_minimal_symbol_table): Remove.
3549         * jit.c (jit_object_close_impl): Update.
3550
3551 2019-03-15  Tom Tromey  <tom@tromey.com>
3552
3553         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3554         initializations.
3555
3556 2019-03-15  Tom Tromey  <tom@tromey.com>
3557
3558         * objfiles.h (struct objfile_per_bfd_storage)
3559         <demangled_hash_languages>: Now a bitset.
3560         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3561         (lookup_minimal_symbol): Update.
3562
3563 2019-03-15  Tom Tromey  <tom@tromey.com>
3564
3565         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3566         Don't return the symbol.
3567         * coffread.c (record_minimal_symbol): Use record_full.
3568
3569 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3570
3571         The MS-Windows port of ncurses fails to switch to a color pair if
3572         one or both of the colors are the implicit default colors.  This
3573         change records the default colors when TUI is initialized, and
3574         then specifies them explicitly when a color pair uses the default
3575         colors.  This allows color styling in TUI mode on MS-Windows.
3576
3577         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3578         ncurses_norm_attr.
3579         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3580         colors in ncurses_norm_attr.
3581         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3582         "none", replace it with the default color recorded in
3583         ncurses_norm_attr.
3584
3585 2019-03-14  Tom Tromey  <tromey@adacore.com>
3586
3587         * source-cache.h (class source_cache) <get_source_lines>: Return
3588         std::string.
3589         * source-cache.c (source_cache::extract_lines): Handle case where
3590         first_pos==npos.  Return std::string.
3591         (source_cache::get_source_lines): Update.
3592
3593 2019-03-14  Tom Tromey  <tromey@adacore.com>
3594
3595         * NEWS: Add item for "style sources" commands.
3596         * source-cache.c (source_cache::get_source_lines): Check
3597         source_styling.
3598         * cli/cli-style.c (source_styling): New global.
3599         (_initialize_cli_style): Add "style sources" commands.
3600         (show_style_sources): New function.
3601         * cli/cli-style.h (source_styling): Declare.
3602
3603 2019-03-14  Pedro Alves  <palves@redhat.com>
3604             Tom Tromey  <tromey@adacore.com>
3605
3606         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3607         * tui/tui-winsource.c (tui_refill_source_window): New function,
3608         from...
3609         (tui_horizontal_source_scroll): ... here.  Move some logic.
3610         * cli/cli-style.c (set_style_enabled): Notify new observable.
3611         * tui/tui-hooks.c (tui_redisplay_source): New function.
3612         (tui_attach_detach_observers): Attach or detach
3613         tui_redisplay_source.
3614         * observable.h (source_styling_changed): New observable.
3615         * observable.c: Define source_styling_changed observable.
3616
3617 2019-03-13  Tom Tromey  <tromey@adacore.com>
3618
3619         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3620         (i386_gnu_nat_target::store_registers): Update.
3621         * target-debug.h (target_debug_print_std_string): New macro.
3622         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3623         * windows-tdep.c (display_one_tib): Update.
3624         * tui/tui-stack.c (tui_make_status_line): Update.
3625         * top.c (print_inferior_quit_action): Update.
3626         * thread.c (thr_try_catch_cmd): Update.
3627         (add_thread_with_info): Update.
3628         (thread_target_id_str): Update.
3629         (thr_try_catch_cmd): Update.
3630         (thread_command): Update.
3631         (thread_find_command): Update.
3632         * record-btrace.c (record_btrace_target::info_record)
3633         (record_btrace_resume_thread, record_btrace_target::resume)
3634         (record_btrace_cancel_resume, record_btrace_step_thread)
3635         (record_btrace_target::wait, record_btrace_target::wait)
3636         (record_btrace_target::wait, record_btrace_target::stop): Update.
3637         * progspace.c (print_program_space): Update.
3638         * process-stratum-target.c
3639         (process_stratum_target::thread_address_space): Update.
3640         * linux-fork.c (linux_fork_mourn_inferior)
3641         (detach_checkpoint_command, info_checkpoints_command)
3642         (linux_fork_context): Update.
3643         (linux_fork_detach): Update.
3644         (class scoped_switch_fork_info): Update.
3645         (delete_checkpoint_command): Update.
3646         * infrun.c (follow_fork_inferior): Update.
3647         (follow_fork_inferior): Update.
3648         (proceed_after_vfork_done): Update.
3649         (handle_vfork_child_exec_or_exit): Update.
3650         (follow_exec): Update.
3651         (displaced_step_prepare_throw): Update.
3652         (displaced_step_restore): Update.
3653         (start_step_over): Update.
3654         (resume_1): Update.
3655         (clear_proceed_status_thread): Update.
3656         (proceed): Update.
3657         (print_target_wait_results): Update.
3658         (do_target_wait): Update.
3659         (context_switch): Update.
3660         (stop_all_threads): Update.
3661         (restart_threads): Update.
3662         (finish_step_over): Update.
3663         (handle_signal_stop): Update.
3664         (switch_back_to_stepped_thread): Update.
3665         (keep_going_pass_signal): Update.
3666         (print_exited_reason): Update.
3667         (normal_stop): Update.
3668         * inferior.c (inferior_pid_to_str): Change return type.
3669         (print_selected_inferior): Update.
3670         (add_inferior): Update.
3671         (detach_inferior): Update.
3672         * dummy-frame.c (fprint_dummy_frames): Update.
3673         * dcache.c (dcache_info_1): Update.
3674         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3675         (btrace_fetch, btrace_clear): Update.
3676         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3677         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3678         type.
3679         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3680         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3681         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3682         * gdbarch.c, gdbarch.h: Rebuild.
3683         * gdbarch.sh (core_pid_to_str): Change return type.
3684         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3685         return type.
3686         (windows_nat_target::pid_to_str): Change return type.
3687         (windows_delete_thread): Update.
3688         (windows_nat_target::attach): Update.
3689         (windows_nat_target::files_info): Update.
3690         * target-delegates.c: Rebuild.
3691         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3692         return type.
3693         (sol_thread_target::pid_to_str): Change return type.
3694         * remote.c (class remote_target) <pid_to_str>: Change return
3695         type.
3696         (remote_target::pid_to_str): Change return type.
3697         (extended_remote_target::attach, remote_target::remote_stop_ns)
3698         (remote_target::remote_notif_remove_queued_reply)
3699         (remote_target::push_stop_reply, remote_target::disable_btrace):
3700         Update.
3701         (extended_remote_target::attach): Update.
3702         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3703         type.
3704         (gdbsim_target::pid_to_str): Change return type.
3705         * ravenscar-thread.c (struct ravenscar_thread_target)
3706         <pid_to_str>: Change return type.
3707         (ravenscar_thread_target::pid_to_str): Change return type.
3708         * procfs.c (class procfs_target) <pid_to_str>: Change return
3709         type.
3710         (procfs_target::pid_to_str): Change return type.
3711         (procfs_target::attach): Update.
3712         (procfs_target::detach): Update.
3713         (procfs_target::fetch_registers): Update.
3714         (procfs_target::store_registers): Update.
3715         (procfs_target::wait): Update.
3716         (procfs_target::files_info): Update.
3717         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3718         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3719         return type.
3720         (nto_procfs_target::pid_to_str): Change return type.
3721         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3722         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3723         return type.
3724         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3725         (exit_lwp): Update.
3726         (attach_proc_task_lwp_callback, get_detach_signal)
3727         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3728         (linux_nat_target::resume, wait_lwp, stop_callback)
3729         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3730         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3731         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3732         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3733         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3734         type.
3735         (inf_ptrace_target::attach): Update.
3736         (inf_ptrace_target::files_info): Update.
3737         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3738         type.
3739         (go32_nat_target::pid_to_str): Change return type.
3740         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3741         (gnu_nat_target::wait): Update.
3742         (gnu_nat_target::wait): Update.
3743         (gnu_nat_target::resume): Update.
3744         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3745         (fbsd_nat_target::wait): Update.
3746         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3747         type.
3748         (darwin_nat_target::attach): Update.
3749         * corelow.c (class core_target) <pid_to_str>: Change return type.
3750         (core_target::pid_to_str): Change return type.
3751         * target.c (normal_pid_to_str): Change return type.
3752         (default_pid_to_str): Likewise.
3753         (target_pid_to_str): Change return type.
3754         (target_translate_tls_address): Update.
3755         (target_announce_detach): Update.
3756         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3757         return type.
3758         (bsd_uthread_target::pid_to_str): Change return type.
3759         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3760         type.
3761         (bsd_kvm_target::pid_to_str): Change return type.
3762         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3763         return type.
3764         (aix_thread_target::pid_to_str): Change return type.
3765         * target.h (struct target_ops) <pid_to_str>: Change return type.
3766         (target_pid_to_str, normal_pid_to_str): Likewise.
3767         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3768         type.
3769         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3770         type.
3771         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3772         return type.
3773         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3774         type.
3775         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3776         type.
3777         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3778         return type.
3779
3780 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3781
3782         * NEWS: Mention that the new default MI version is 3.  Mention
3783         changes to the output of commands and events that deal with
3784         multi-location breakpoints.
3785         * breakpoint.c: Include "mi/mi-out.h".
3786         (print_one_breakpoint): Change output syntax if using MI version
3787         >= 3.
3788         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3789         New.
3790         (mi_multi_location_breakpoint_output_fixed): New.
3791         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3792         (mi_cmd_fix_multi_location_breakpoint_output): New.
3793         (mi_multi_location_breakpoint_output_fixed): New.
3794         * mi/mi-cmds.c (mi_cmds): Register command
3795         -fix-multi-location-breakpoint-output.
3796         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3797         interpreter "mi".
3798
3799 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3800
3801         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3802         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3803         instantiate mi_ui_out based on interpreter name.
3804         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3805         * mi/mi-main.c (mi_load_progress): Likewise.
3806
3807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3808
3809         * NEWS: Combine separate "New targets" sections for 8.3.
3810
3811 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3812
3813         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3814         (ppcfbsd_init_abi): Install gdbarch
3815         "fetch_tls_load_module_address" and "get_thread_local_address"
3816         methods.
3817
3818 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3819
3820         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3821         (riscv_fbsd_init_abi): Install gdbarch
3822         "fetch_tls_load_module_address" and "get_thread_local_address"
3823         methods.
3824
3825 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3826
3827         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3828         (i386fbsd_init_abi): Install gdbarch
3829         "fetch_tls_load_module_address" and "get_thread_local_address"
3830         methods.
3831
3832 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3833
3834         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3835         (amd64fbsd_init_abi): Install gdbarch
3836         "fetch_tls_load_module_address" and "get_thread_local_address"
3837         methods.
3838
3839 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3840
3841         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3842         (struct fbsd_pspace_data): New type.
3843         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3844         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3845         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3846         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3847         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3848
3849 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3850
3851         * gdbtypes.c (lookup_struct_elt): New function.
3852         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3853         * gdbtypes.h (struct struct_elt): New type.
3854         (lookup_struct_elt): New prototype.
3855
3856 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3857
3858         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3859         remove disabled code block.
3860
3861 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3862
3863         * gdbarch.sh (get_thread_local_address): New method.
3864         * gdbarch.h, gdbarch.c: Regenerate.
3865         * target.c (target_translate_tls_address): Use
3866         gdbarch_get_thread_local_address if present instead of
3867         target::get_thread_local_address.
3868
3869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3870
3871         * target.h (target::get_thread_local_address): Update comment.
3872
3873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3874
3875         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3876         objfile->separate_debug_objfile_backlink if not NULL.
3877
3878 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3879
3880         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3881         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3882         (amd64bsd_store_inferior_registers): Likewise.
3883         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3884         Enable segment base registers.
3885         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3886         PT_GETFSBASE and PT_GETGSBASE.
3887         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3888         PT_SETGSBASE.
3889         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3890         segment base registers.
3891         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3892
3893 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3894
3895         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3896         Update calls to i386_target_description to add 'segments'
3897         parameter.
3898         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3899         add segment base registers.
3900         * arch/i386.c (i386_create_target_description): Add 'segments'
3901         parameter to enable segment base registers.
3902         * arch/i386.h (i386_create_target_description): Likewise.
3903         * features/i386/32bit-segments.xml: New file.
3904         * features/i386/32bit-segments.c: Generate.
3905         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3906         call to i386_target_description to add 'segments' parameter.
3907         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3908         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3909         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3910         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3911         if feature is present.
3912         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3913         Add 'segments' parameter to call to i386_target_description.
3914         (i386_target_description): Add 'segments' parameter to enable
3915         segment base registers.
3916         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3917         to call to i386_target_description.
3918         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3919         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3920         Define I386_NUM_REGS.
3921         (i386_target_description): Add 'segments' parameter to enable
3922         segment base registers.
3923
3924 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3925
3926         PR/24325
3927         * source-cache.c: #undef open and close, to avoid unresolved
3928         externals during linking.
3929
3930 2019-03-12  Tom Tromey  <tromey@adacore.com>
3931
3932         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3933         const.  Add initializers.
3934         (_initialize_remote): Don't initialize ptid globals.
3935
3936 2019-03-12  Pedro Alves  <palves@redhat.com>
3937
3938         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3939
3940 2019-03-12  Pedro Alves  <palves@redhat.com>
3941
3942         * cp-name-parser.y (main): Remove unused 'len' variable.
3943
3944 2019-03-12  Tom Tromey  <tromey@adacore.com>
3945
3946         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3947         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3948
3949 2019-03-12  Tom Tromey  <tromey@adacore.com>
3950
3951         * linux-nat.c (iterate_over_lwps): Update.
3952         (stop_callback): Remove parameter.
3953         (stop_wait_callback, detach_callback, resume_set_callback)
3954         (select_singlestep_lwp_callback, set_ignore_sigint)
3955         (status_callback, resumed_callback, resume_clear_callback)
3956         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3957         data parameter.
3958         (linux_nat_target::detach, linux_nat_target::resume)
3959         (linux_stop_and_wait_all_lwps, select_event_lwp)
3960         (linux_nat_filter_event, linux_nat_wait_1)
3961         (linux_nat_target::kill, linux_nat_target::stop)
3962         (linux_nat_target::stop): Update.
3963         (linux_nat_resume_callback): Change type.
3964         (resume_stopped_resumed_lwps, count_events_callback)
3965         (select_event_lwp_callback): Likewise.
3966         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3967         * arm-linux-nat.c (struct update_registers_data): Remove.
3968         (update_registers_callback): Change type.
3969         (arm_linux_insert_hw_breakpoint1): Update.
3970         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3971         parameter.
3972         (x86_linux_dr_set_addr): Update.
3973         (x86_linux_dr_set_control): Update.
3974         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3975         (iterate_over_lwps): Use gdb::function_view.
3976         * nat/aarch64-linux-hw-point.c (struct
3977         aarch64_dr_update_callback_param): Remove.
3978         (debug_reg_change_callback): Change type.
3979         (aarch64_notify_debug_reg_change): Update.
3980         * s390-linux-nat.c (s390_refresh_per_info): Update.
3981
3982 2019-03-11  Tom Tromey  <tromey@adacore.com>
3983
3984         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3985         redundant assignment to "this_cu".
3986
3987 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3988
3989         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3990
3991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3992
3993         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3994         from...
3995         (rank_one_type): ... this.
3996
3997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3998
3999         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4000         from...
4001         (rank_one_type): ... this.
4002
4003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4004
4005         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4006         from...
4007         (rank_one_type): ... this.
4008
4009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4010
4011         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4012         from...
4013         (rank_one_type): ... this.
4014
4015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4016
4017         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4018         from...
4019         (rank_one_type): ... this.
4020
4021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4022
4023         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4024         from...
4025         (rank_one_type): ... this.
4026
4027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4028
4029         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4030         from...
4031         (rank_one_type): ... this.
4032
4033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4034
4035         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4036         from...
4037         (rank_one_type): ... this.
4038
4039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4040
4041         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4042         from...
4043         (rank_one_type): ... this.
4044
4045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4046
4047         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4048         from...
4049         (rank_one_type): ... this.
4050
4051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4052
4053         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4054         from...
4055         (rank_one_type): ... this.
4056
4057 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4058
4059         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4060         from...
4061         (rank_one_type): ... this.
4062
4063 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4064
4065         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4066         inferior-events' shows the example events.
4067
4068 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4069
4070         Support styling on native MS-Windows console
4071
4072         PR/24315
4073         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4074         on MS-Windows if $TERM is not defined.
4075
4076         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4077
4078         * posix-hdep.c (gdb_console_fputs):
4079         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4080         functions.
4081         * ui-file.h (gdb_console_fputs): Add prototype.
4082
4083         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4084         back to fputs only if the former returns zero.
4085
4086 2019-03-07  Tom Tromey  <tom@tromey.com>
4087
4088         * symmisc.c (print_symbol_bcache_statistics): Update.
4089         (print_objfile_statistics): Update.
4090         * symfile.c (allocate_symtab): Update.
4091         * stabsread.c: Don't include bcache.h.
4092         * psymtab.h (struct psymbol_bcache): Don't declare.
4093         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4094         (psymbol_bcache_init, psymbol_bcache_free)
4095         (psymbol_bcache_get_bcache): Don't declare.
4096         * psymtab.c (struct psymbol_bcache): Remove.
4097         (psymtab_storage::psymtab_storage): Update.
4098         (psymtab_storage::~psymtab_storage): Update.
4099         (psymbol_bcache_init, psymbol_bcache_free)
4100         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4101         (add_psymbol_to_bcache): Update.
4102         (allocate_psymtab): Update.
4103         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4104         macro_cache>: No longer pointers.
4105         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4106         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4107         * macrotab.c (macro_bcache): Update.
4108         * macroexp.c: Don't include bcache.h.
4109         * gdbtypes.c (check_types_worklist): Update.
4110         (types_deeply_equal): Remove TRY/CATCH.  Update.
4111         * elfread.c (elf_symtab_read): Update.
4112         * dwarf2read.c: Don't include bcache.h.
4113         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4114         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4115         (print_bcache_statistics, bcache_memory_used): Don't declare.
4116         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4117         methods.  Rename all data members.
4118         * bcache.c (struct bcache): Move to bcache.h.
4119         (bcache::expand_hash_table): Rename from expand_hash_table.
4120         (bcache): Remove.
4121         (bcache::insert): Rename from bcache_full.
4122         (bcache::compare): Rename from bcache_compare.
4123         (bcache_xmalloc): Remove.
4124         (bcache::~bcache): Rename from bcache_xfree.
4125         (bcache::print_statistics): Rename from print_bcache_statistics.
4126         (bcache::memory_used): Rename from bcache_memory_used.
4127
4128 2019-03-07  Pedro Alves  <palves@redhat.com>
4129
4130         * infrun.c (normal_stop): Also check for
4131         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4132
4133 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4134
4135         * f-lang.c (value_from_host_double): Moved to...
4136         * value.c (value_from_host_double): ...here.
4137         * value.h (value_from_host_double): Declare.
4138         * guile/scm-math.c (vlscm_convert_typed_number): Use
4139         value_from_host_double.
4140         (vlscm_convert_number): Likewise.
4141         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4142         * python/py-value.c (convert_value_from_python): Likewise.
4143
4144 2019-03-06  Tom Tromey  <tom@tromey.com>
4145
4146         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4147
4148 2019-03-06  Tom Tromey  <tom@tromey.com>
4149
4150         * utils.h (free_current_contents): Don't declare.
4151         * utils.c (free_current_contents): Remove.
4152
4153 2019-03-06  Tom Tromey  <tom@tromey.com>
4154
4155         * top.c (quit_force): Update.
4156         * main.c (captured_command_loop): Update.
4157         * common/new-op.c (operator new): Update.
4158         * common/common-exceptions.c (struct catcher)
4159         <save_cleanup_chain>: Remove member.
4160         (exceptions_state_mc_init): Update.
4161         (exception_try_scope_entry): Return nullptr.
4162         (exception_try_scope_exit, exception_rethrow)
4163         (throw_exception_sjlj, throw_exception_cxx): Update.
4164         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4165         (all_cleanups, do_cleanups, discard_cleanups)
4166         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4167         (restore_cleanups, restore_final_cleanups): Don't declare.
4168         (do_final_cleanups): Remove parameter.
4169         * common/cleanups.c (cleanup_chain, make_cleanup)
4170         (make_cleanup_dtor, all_cleanups, do_cleanups)
4171         (discard_my_cleanups, discard_cleanups)
4172         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4173         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4174         (null_cleanup): Remove.
4175         (do_final_cleanups): Remove parameter.
4176
4177 2019-03-06  Tom Tromey  <tom@tromey.com>
4178
4179         * remote.c (remote_target::remote_parse_stop_reply): Use
4180         unique_xmalloc_ptr.
4181
4182 2019-03-06  Tom Tromey  <tom@tromey.com>
4183
4184         * stabsread.c (struct stabs_field_info): Rename from field_info.
4185         <list, fnlist>: Add initializers.
4186         <obstack>: New member.
4187         (read_member_functions, read_struct_fields, read_baseclasses):
4188         Allocate on obstack.  Don't use cleanups.
4189         (read_one_struct_field, read_member_functions, read_struct_fields)
4190         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4191         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4192         (read_struct_type): Update.
4193
4194 2019-03-06  Tom Tromey  <tom@tromey.com>
4195
4196         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4197         * common/filestuff.h (make_cleanup_close): Don't declare.
4198         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4199         Remove.
4200
4201 2019-03-06  Tom Tromey  <tom@tromey.com>
4202
4203         * solib-aix.c: Use make_scope_exit.
4204
4205 2019-03-06  Tom Tromey  <tom@tromey.com>
4206
4207         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4208         Use make_scope_exit.
4209
4210 2019-03-06  Tom Tromey  <tom@tromey.com>
4211
4212         * solib-svr4.c (disable_probes_interface): Remove parameter.
4213         (svr4_handle_solib_event): Use make_scope_exit.
4214
4215 2019-03-06  Tom Tromey  <tom@tromey.com>
4216
4217         * remote.c (struct stop_reply_deleter): Remove.
4218         (stop_reply_up): Update.
4219         (struct stop_reply): Derive from notif_event.  Don't typedef.
4220         <regcache>: Now a std::vector.
4221         (stop_reply_xfree): Remove.
4222         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4223         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4224         (remote_target::discard_pending_stop_replies): Use delete.
4225         (remote_target::remote_parse_stop_reply): Update.
4226         (remote_target::process_stop_reply): Update.
4227         * remote-notif.h (struct notif_event): Add virtual destructor.
4228         Remove "dtr" member.
4229         (struct notif_client) <alloc_event>: Return a unique_ptr.
4230         (notif_event_xfree): Don't declare.
4231         (notif_event_up): New typedef.
4232         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4233         (notif_event_xfree, do_notif_event_xfree): Remove.
4234         (remote_notif_state_xfree): Update.
4235
4236 2019-03-06  Tom Tromey  <tom@tromey.com>
4237
4238         * infrun.c (displaced_step_clear_cleanup): Now a
4239         forward_scope_exit type.
4240         (displaced_step_prepare_throw): Update.
4241         (displaced_step_fixup): Update.
4242
4243 2019-03-06  Tom Tromey  <tom@tromey.com>
4244
4245         * inferior.h (class inferior): Update comment.
4246         * gdbthread.h (class thread_info): Update comment.
4247
4248 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4249             Tom Tromey  <tom@tromey.com>
4250
4251         * stabsread.h (struct stab_section_list): Remove.
4252         (coffstab_build_psymtabs): Update.
4253         * dbxread.c (symbuf_sections): Now a std::vector.
4254         (sect_idx): New global.
4255         (fill_symbuf): Update.
4256         (coffstab_build_psymtabs): Change type of stabsects parameter.
4257         Update.
4258         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4259         std::vector.
4260         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4261         (coff_locate_sections): Update.
4262         (coff_symfile_read): Remove cleanups.  Update.
4263         (init_stringtab): Add storage parameter.
4264         (free_stringtab, free_stringtab_cleanup): Remove.
4265         (init_lineno): Add storage parameter.
4266         (free_linetab, free_linetab_cleanup): Remove.
4267
4268 2019-03-06  Pedro Alves  <palves@redhat.com>
4269
4270         * linux-fork.c (fork_info::clobber_regs): Delete.
4271         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4272         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4273         comment.  Adjust.
4274         (scoped_switch_fork_info::scoped_switch_fork_info)
4275         (checkpoint_command, linux_fork_context): Adjust
4276         fork_save_infrun_state calls.
4277
4278 2019-03-06  Pedro Alves  <palves@redhat.com>
4279
4280         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4281         (inf_has_multiple_threads): Return 'bool' and rewrite using
4282         inferior_info::threads().
4283
4284 2019-03-06  Pedro Alves  <palves@redhat.com>
4285
4286         * linux-fork.c: Include <list>.
4287         (fork_list): Now a std::list instance.
4288         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4289         (forks_exist_p, find_last_fork): Adjust.
4290         (new_fork): Delete.
4291         (one_fork_p): New.
4292         (add_fork): Adjust.
4293         (free_fork): Delete, folded into fork_info::~fork_info().
4294         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4295         Adjust.
4296         (init_fork_list): Delete.
4297         (linux_fork_killall, linux_fork_mourn_inferior)
4298         (linux_fork_detach, info_checkpoints_command): Adjust.
4299         (_initialize_linux_fork): No longer call init_fork_list.
4300
4301 2019-03-06  Pedro Alves  <palves@redhat.com>
4302
4303         * linux-fork.c (new_fork): New, split out of ...
4304         (add_fork): ... this.  Return void.  Move "first fork" special
4305         case from here, to ...
4306         (checkpoint_command): ... here.
4307         * linux-linux.h (add_fork): Return void.
4308
4309 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4310
4311         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4312
4313 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4314             Chris January  <chris.january@arm.com>
4315             David Lecomber  <david.lecomber@arm.com>
4316
4317         * f-exp.y: New token, UNOP_INTRINSIC.
4318         (exp): New pattern using UNOP_INTRINSIC token.
4319         (f77_keywords): Add 'abs' keyword.
4320         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4321         (value_from_host_double): New function.
4322         (evaluate_subexp_f): Support UNOP_ABS.
4323
4324 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4325
4326         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4327         types.
4328
4329 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4330
4331         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4332         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4333         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4334
4335 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4336
4337         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4338
4339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4340             Chris January  <chris.january@arm.com>
4341
4342         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4343         * f-exp.y: Define 'KIND' token.
4344         (exp): New pattern for KIND expressions.
4345         (ptype): Handle types with a kind extension.
4346         (direct_abs_decl): Extend to spot kind extensions.
4347         (f77_keywords): Add 'kind' to the list.
4348         (push_kind_type): New function.
4349         (convert_to_kind_type): New function.
4350         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4351         * parse.c (operator_length_standard): Likewise.
4352         * parser-defs.h (enum type_pieces): Add tp_kind.
4353         * std-operator.def: Add UNOP_KIND.
4354
4355 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4356
4357         * f-exp.y (f_parse): Set yydebug.
4358
4359 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * f-lang.c (evaluate_subexp_f): New function.
4362         (exp_descriptor_f): New global.
4363         (f_language_defn): Use exp_descriptor_f instead of
4364         exp_descriptor_standard.
4365
4366 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4367
4368         * f-exp.y (struct token): Add comments.
4369         (dot_ops): Remove uppercase versions and the end marker.
4370         (f77_keywords): Likewise.
4371         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4372         entries in the dot_ops array are case insensitive, and use
4373         strncasecmp to compare strings.  Also some whitespace cleanup in
4374         this area.  Similar for the f77_keywords array, except entries in
4375         this list might be case sensitive.
4376
4377 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4378
4379         * f-exp.y (struct f77_boolean_val): Add comments.
4380         (boolean_values): Remove uppercase versions, and end marker.
4381         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4382         and use strncasecmp to achieve case insensitivity.  Additionally,
4383         perform whitespace cleanup around this code.
4384
4385 2019-03-06  Tom Tromey  <tromey@adacore.com>
4386
4387         * remote-sim.c (gdbsim_target_open): Use result of
4388         gdb_argv::release.
4389
4390 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4391         Dirk Schubert  <dirk.schubert@arm.com>
4392         Chris January  <chris.january@arm.com>
4393
4394         * eval.c (evaluate_subexp_standard): Call Fortran argument
4395         wrapping logic.
4396         * f-lang.c (struct value): A value which can be passed into a
4397         Fortran function call.
4398         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4399         where appropriate.
4400         (struct type): Value ready for a Fortran function call.
4401         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4402         is needed.
4403         * f-lang.h (fortran_argument_convert): Declaration.
4404         (fortran_preserve_arg_pointer): Declaration.
4405         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4406
4407 2019-03-05  Tom Tromey  <tromey@adacore.com>
4408
4409         * python/py-prettyprint.c (print_string_repr): Remove #if.
4410         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4411
4412 2019-03-05  Tom Tromey  <tromey@adacore.com>
4413
4414         * target.c (the_dummy_target): Move later.  Change type to
4415         "dummy_target".
4416         (initialize_targets): Don't initialize the_dummy_target.
4417
4418 2019-03-05  Tom Tromey  <tromey@adacore.com>
4419
4420         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4421         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4422
4423 2019-03-05  Tom Tromey  <tromey@adacore.com>
4424
4425         * windows-nat.c (windows_nat_target::attach)
4426         (windows_nat_target::detach): Don't call gdb_flush.
4427         * valprint.c (generic_val_print, val_print, val_print_string):
4428         Don't call gdb_flush.
4429         * utils.c (defaulted_query): Don't call gdb_flush.
4430         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4431         * target.c (target_announce_detach): Don't call gdb_flush.
4432         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4433         * remote.c (extended_remote_target::attach): Don't call
4434         gdb_flush.
4435         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4436         * printcmd.c (do_examine): Don't call gdb_flush.
4437         (info_display_command): Don't call gdb_flush.
4438         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4439         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4440         * memattr.c (info_mem_command): Don't call gdb_flush.
4441         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4442         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4443         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4444         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4445         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4446         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4447         (gnu_nat_target::detach): Don't call gdb_flush.
4448         * f-valprint.c (f_val_print): Don't call gdb_flush.
4449         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4450         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4451         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4452         gdb_flush.
4453         * c-valprint.c (c_val_print): Don't call gdb_flush.
4454         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4455
4456 2019-03-05  Tom Tromey  <tromey@adacore.com>
4457
4458         * varobj.c (update_dynamic_varobj_children): Update.
4459         (install_default_visualizer): Use reset, not release.
4460         * value.c (set_internalvar): Update.
4461         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4462         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4463         ATTRIBUTE_UNUSED_RESULT.
4464
4465 2019-03-05  Tom Tromey  <tromey@adacore.com>
4466
4467         * remote.c (class scoped_remote_fd) <release>: Add
4468         ATTRIBUTE_UNUSED_RESULT.
4469
4470 2019-03-05  Tom Tromey  <tromey@adacore.com>
4471
4472         * macroexp.c (struct macro_buffer) <release>: Add
4473         ATTRIBUTE_UNUSED_RESULT.
4474
4475 2019-03-05  Tom Tromey  <tromey@adacore.com>
4476
4477         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4478         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4479         ATTRIBUTE_UNUSED_RESULT.
4480
4481 2019-03-05  Tom Tromey  <tromey@adacore.com>
4482
4483         * common/scoped_fd.h (class scoped_fd) <release>: Add
4484         ATTRIBUTE_UNUSED_RESULT.
4485
4486 2019-03-05  Tom Tromey  <tromey@adacore.com>
4487
4488         * parser-defs.h (struct parser_state) <release>: Add
4489         ATTRIBUTE_UNUSED_RESULT.
4490
4491 2019-03-05  Tom Tromey  <tromey@adacore.com>
4492
4493         * utils.h (class gdb_argv) <release>: Add
4494         ATTRIBUTE_UNUSED_RESULT.
4495         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4496
4497 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4498
4499         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4500         for-loop range, to avoid compiler warnings.
4501
4502         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4503         avoid compiler warnings about unused variables.
4504
4505         * NEWS: Mention end of support for native debugging on MS-Windows
4506         before XP.
4507
4508         PR gdb/24292
4509         * common/netstuff.c:
4510         * gdbserver/gdbreplay.c
4511         * gdbserver/remote-utils.c:
4512         * ser-tcp.c:
4513         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4514         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4515         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4516         'getaddrinfo' and 'freeaddrinfo' were not available before
4517         Windows XP, and mingw.org's MinGW headers by default define
4518         _WIN32_WINNT to 0x500.
4519
4520 2019-03-01  Gary Benson <gbenson@redhat.com>
4521
4522         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4523
4524 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4525             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4526
4527         PR gdb/8527
4528         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4529         set_sigint_trap, clear_sigint_trap.
4530
4531 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4532
4533         * target.c (target_detach): Clear the regcache and the
4534         frame cache.
4535
4536 2019-02-27  Pedro Alves  <palves@redhat.com>
4537
4538         * utils.c (set_screen_size): When we cap the height/width sizes,
4539         tweak the corresponding command variable to show "unlimited":
4540
4541 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4542             Pedro Alves  <palves@redhat.com>
4543
4544         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4545         before calling rl_set_screen_size.
4546
4547 2019-02-27  Tom Tromey  <tromey@adacore.com>
4548
4549         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4550         define.
4551         * python/py-value.c: Remove Python 2.4 workaround.
4552         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4553         workaround.
4554         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4555         Python 2.4 workaround.
4556         * python/python-internal.h: Remove Python 2.4 comment.
4557         (Py_ssize_t): Don't define.
4558         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4559         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4560         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4561         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4562         * python/python.c (do_start_initialization): Remove Python 2.4
4563         workaround.
4564         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4565         (print_children): Remove Python 2.4 workaround.
4566         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4567         workaround.
4568         (CHARBUFFERPROC_NAME): Remove.
4569         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4570         Python 2.4 workaround.
4571
4572 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4573
4574         * NEWS: Note minimum Python version.
4575
4576 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4577
4578         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4579         code from these functions.  Remove corresponding ifdefs.  Use
4580         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4581         Remove gotos and target of gotos.
4582         (infpy_search_memory): Likewise.
4583
4584 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4585
4586         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4587         (hppa_gdbarch_init): Don't register deleted functions with
4588         gdbarch.
4589
4590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4591
4592         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4593         (h8300_unwind_sp): Delete.
4594         (h8300_dummy_id): Delete.
4595         (h8300_gdbarch_init): Don't register deleted functions with
4596         gdbarch.
4597
4598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4601         (ft32_unwind_pc): Delete.
4602         (ft32_unwind_sp): Delete.
4603         (ft32_gdbarch_init): Don't register deleted functions with
4604         gdbarch.
4605
4606 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4609         (frv_unwind_pc): Delete.
4610         (frv_unwind_sp): Delete.
4611         (frv_gdbarch_init): Don't register deleted functions with
4612         gdbarch.
4613
4614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4615
4616         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4617         (riscv_unwind_pc): Delete.
4618         (riscv_unwind_sp): Delete.
4619         (riscv_gdbarch_init): Don't register deleted functions with
4620         gdbarch.
4621
4622 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4623
4624         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4625         (csky_unwind_pc): Delete.
4626         (csky_unwind_sp): Delete.
4627         (csky_gdbarch_init): Don't register deleted functions with
4628         gdbarch.
4629
4630 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4631
4632         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4633         (cris_unwind_pc): Delete.
4634         (cris_unwind_sp): Delete.
4635         (cris_gdbarch_init): Don't register deleted functions with
4636         gdbarch.
4637
4638 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4639
4640         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4641         (bfin_unwind_pc): Delete.
4642         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4643
4644 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4645
4646         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4647         (arm_unwind_pc): Delete.
4648         (arm_unwind_sp): Delete.
4649         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4650
4651 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4652
4653         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4654         (arc_unwind_pc): Delete.
4655         (arc_unwind_sp): Delete.
4656         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4657
4658 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4659
4660         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4661         (alpha_unwind_pc): Delete.
4662         (alpha_gdbarch_init): Don't register deleted functions with
4663         gdbarch.
4664
4665 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4666
4667         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4668         (aarch64_unwind_pc): Delete.
4669         (aarch64_unwind_sp): Delete.
4670         (aarch64_gdbarch_init): Don't register deleted functions with
4671         gdbarch.
4672
4673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4674
4675         * gdbtypes.c (type_align): Don't consider static members when
4676         computing structure alignment.
4677
4678 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4679
4680         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4681         return 0 for other types.
4682         * arch-utils.c (default_type_align): Always return 0.
4683         * gdbarch.h: Regenerate.
4684         * gdbarch.sh (type_align): Extend comment.
4685         * gdbtypes.c (type_align): Add additional comments, always call
4686         gdbarch_type_align before applying the default rules.
4687         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4688         generic code will then apply a suitable default.
4689         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4690         types, return 0 for other types.
4691
4692 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4693
4694         * NEWS: Create a new section for the next release branch.
4695         Rename the section of the current branch, now that it has
4696         been cut.
4697
4698 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4699
4700         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4701         * version.in: Bump version to 8.3.50.DATE-git.
4702
4703 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4704
4705         * aix-thread.c (ptid_cmp): Remove unused variable.
4706         (get_signaled_thread): Likewise.
4707         (store_regs_user_thread): Likewise.
4708         (store_regs_kernel_thread): Likewise.
4709         (fetch_regs_kernel_thread): Remove shadowed variable.
4710
4711 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4712
4713         * features/riscv/32bit-cpu.xml: Add register numbers.
4714         * features/riscv/32bit-fpu.c: Regenerate.
4715         * features/riscv/32bit-fpu.xml: Add register numbers.
4716         * features/riscv/64bit-cpu.xml: Add register numbers.
4717         * features/riscv/64bit-fpu.c: Regenerate.
4718         * features/riscv/64bit-fpu.xml: Add register numbers.
4719
4720 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4721
4722         * NEWS: Mention two argument form of gdb.Value constructor.
4723         * python/py-value.c (convert_buffer_and_type_to_value): New
4724         function.
4725         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4726         Add support for handling an optional second argument.  Call
4727         convert_buffer_and_type_to_value as appropriate.
4728         * python/python-internal.h (Py_buffer_deleter): New struct.
4729         (Py_buffer_up): New typedef.
4730
4731 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4732
4733         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4734         instead of releasing ownership.
4735
4736 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4737
4738         * dwarf2read.c (open_and_init_dwp_file): Call
4739         elf_numsections instead of bfd_count_sections to initialize
4740         dwp_file->num_sections.
4741
4742 2019-02-25  Tom Tromey  <tromey@adacore.com>
4743
4744         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4745
4746 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4747
4748         * gcore.in: Add '--readnever' option when invoking GDB.
4749
4750 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4751
4752         * MAINTAINERS: Update my email address.
4753
4754 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4755
4756         * build-id.c (build_id_to_debug_bfd_1): New function.
4757         (build_id_to_debug_bfd): Look for separate debug file in
4758         sysroot.
4759
4760 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4761
4762         * gdbarch.sh: Update the copyright year range that is placed into
4763         generated files.
4764
4765 2019-02-22  Keith Seitz  <keiths@redhat.com>
4766
4767         PR symtab/23853
4768         * linespec.c (create_sals_line_offset): Search for the default
4769         symtab's filename instead of its fullname.
4770
4771 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4772
4773         * NEWS: Update style defaults.
4774
4775 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4776
4777         * main.c (captured_main_1): Disable styling in batch mode.
4778
4779 2019-02-20  Tom Tromey  <tom@tromey.com>
4780
4781         * symtab.c (symtab_symbol_info): Fix typos.
4782
4783 2019-02-20  Tom Tromey  <tromey@adacore.com>
4784
4785         * findcmd.c (_initialize_mem_search): Use upper case for
4786         metasyntactic variables.
4787
4788 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4789
4790         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4791         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4792
4793 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4794
4795         * top.h (source_file_name): Change to std::string.
4796         * top.c (source_file_name): Likewise.
4797         (command_line_input): Adjust.
4798         * cli/cli-script.c (script_from_file): Adjust.
4799
4800 2019-02-19  Tom Tromey  <tromey@adacore.com>
4801
4802         * ravenscar-thread.c
4803         (ravenscar_thread_target::update_thread_list): Don't call
4804         ada_build_task_list.
4805         * ada-lang.h (ada_build_task_list): Don't declare.
4806         * ada-tasks.c (struct ada_tasks_inferior_data)
4807         <task_list_valid_p>: Now bool.
4808         (read_known_tasks, ada_task_list_changed)
4809         (ada_tasks_invalidate_inferior_data): Update.
4810         (read_known_tasks_array): Return bool.
4811         (read_known_tasks_list): Likewise.
4812         (read_known_tasks): Return void.
4813         (ada_build_task_list): Now static.
4814
4815 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4816
4817         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4818         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4819
4820 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4821
4822         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4823         variant for ada_tasks_pspace_data_handle and
4824         ada_tasks_inferior_data_handle.
4825         (ada_tasks_pspace_data_cleanup): New function.
4826         (ada_tasks_inferior_data_cleanup): New function.
4827
4828 2019-02-17  Tom Tromey  <tom@tromey.com>
4829
4830         * macrotab.h (macro_source_fullname): Return a std::string.
4831         * macrotab.c (macro_include, check_for_redefinition)
4832         (macro_undef, macro_lookup_definition, foreach_macro)
4833         (foreach_macro_in_scope): Update.
4834         (macro_source_fullname): Return a std::string.
4835         * macrocmd.c (show_pp_source_pos): Update.
4836
4837 2019-02-17  Tom Tromey  <tom@tromey.com>
4838
4839         * macrocmd.c (show_pp_source_pos): Style the file names.
4840
4841 2019-02-17  Tom Tromey  <tom@tromey.com>
4842
4843         PR tui/24197:
4844         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4845
4846 2019-02-17  Tom Tromey  <tom@tromey.com>
4847
4848         * ada-lang.c (user_select_syms): Use filtered printing.
4849         * utils.c (wrap_style): New global.
4850         (desired_style): Remove.
4851         (emit_style_escape): Add stream parameter.
4852         (set_output_style, reset_terminal_style, prompt_for_continue):
4853         Update.
4854         (flush_wrap_buffer): Only flush gdb_stdout.
4855         (wrap_here): Set wrap_style.
4856         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4857         treat escape sequences as a character.  Change when wrap buffer is
4858         flushed.
4859         (fputs_styled): Do not set the output style when the default is
4860         requested.
4861         * ui-style.h (struct ui_file_style) <is_default>: New method.
4862         * source.c (print_source_lines_base): Emit escape sequences in one
4863         piece.
4864
4865 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4866
4867         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4868         integers and enumeration types.
4869
4870 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4871
4872         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4873         instead of lookup_symbol_in_language
4874         (do_exact_match): New function.
4875         (ada_get_symbol_name_matcher): Return do_exact_match when
4876         doing a verbatim match.
4877
4878 2019-02-15  Tom Tromey  <tromey@adacore.com>
4879
4880         * ravenscar-thread.c (ravenscar_thread_target::resume)
4881         (ravenscar_thread_target::wait): Special case wildcard requests.
4882
4883 2019-02-15  Tom Tromey  <tromey@adacore.com>
4884
4885         * ravenscar-thread.c (base_ptid): Remove.
4886         (struct ravenscar_thread_target) <close>: New method.
4887         <m_base_ptid>: New member.
4888         <update_inferior_ptid, active_task, task_is_currently_active,
4889         runtime_initialized>: Declare methods.
4890         <ravenscar_thread_target>: Add constructor.
4891         (ravenscar_thread_target::task_is_currently_active)
4892         (ravenscar_thread_target::update_inferior_ptid)
4893         (ravenscar_runtime_initialized): Rename.  Now methods.
4894         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4895         (ravenscar_thread_target::update_thread_list): Update.
4896         (ravenscar_thread_target::active_task): Now method.
4897         (ravenscar_thread_target::store_registers)
4898         (ravenscar_thread_target::prepare_to_store)
4899         (ravenscar_thread_target::prepare_to_store)
4900         (ravenscar_thread_target::mourn_inferior): Update.
4901         (ravenscar_inferior_created): Use "new" to create target.
4902         (ravenscar_thread_target::get_ada_task_ptid): Update.
4903         (_initialize_ravenscar): Don't initialize base_ptid.
4904         (ravenscar_ops): Remove global.
4905
4906 2019-02-15  Tom Tromey  <tromey@adacore.com>
4907
4908         * target.h (push_target): Declare new overload.
4909         * target.c (push_target): New overload, taking an rvalue reference.
4910         * remote.c (remote_target::open_1): Use push_target overload.
4911         * corelow.c (core_target_open): Use push_target overload.
4912
4913 2019-02-15  Tom Tromey  <tromey@adacore.com>
4914
4915         * ravenscar-thread.c (is_ravenscar_task)
4916         (ravenscar_task_is_currently_active): Return bool.
4917         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4918         (_initialize_ravenscar): Remove "(void)".
4919         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4920         Return bool.
4921
4922 2019-02-15  Tom Tromey  <tromey@adacore.com>
4923
4924         * ravenscar-thread.c (ravenscar_runtime_initializer)
4925         (has_ravenscar_runtime, get_running_thread_id)
4926         (ravenscar_thread_target::resume): Fix indentation.
4927
4928 2019-02-15  Tom Tromey  <tromey@adacore.com>
4929
4930         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4931         from ravenscar_arch_ops.
4932         (sparc_ravenscar_ops::fetch_registers)
4933         (sparc_ravenscar_ops::store_registers): Now methods.
4934         (sparc_ravenscar_prepare_to_store): Remove.
4935         (sparc_ravenscar_ops): Redefine.
4936         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4937         methods and destructor.  Remove members.
4938         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4939         (ravenscar_thread_target::store_registers)
4940         (ravenscar_thread_target::prepare_to_store): Update.
4941         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4942         Remove.
4943         (struct ppc_ravenscar_powerpc_ops): Derive from
4944         ravenscar_arch_ops.
4945         (ppc_ravenscar_powerpc_ops::fetch_registers)
4946         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4947         (ppc_ravenscar_powerpc_ops): Redefine.
4948         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4949         (ppc_ravenscar_e500_ops::fetch_registers)
4950         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4951         (ppc_ravenscar_e500_ops): Redefine.
4952         * aarch64-ravenscar-thread.c
4953         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4954         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4955         (aarch64_ravenscar_fetch_registers)
4956         (aarch64_ravenscar_store_registers): Now methods.
4957         (aarch64_ravenscar_ops): Redefine.
4958
4959 2019-02-15  Tom Tromey  <tromey@adacore.com>
4960
4961         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4962         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4963         (ravenscar_thread_target::stopped_by_watchpoint)
4964         (ravenscar_thread_target::stopped_data_address)
4965         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4966
4967 2019-02-15  Tom Tromey  <tromey@adacore.com>
4968
4969         * ravenscar-thread.c: Fix some typos.
4970
4971 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4972             Tom Tromey  <tromey@adacore.com>
4973
4974         * ada-lang.c (ada_exception_sal): Change addr_string to a
4975         std::string.
4976         (create_ada_exception_catchpoint): Update.
4977
4978 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4979             Tom Tromey  <tromey@adacore.com>
4980
4981         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4982         (bp_location_ops): Remove.
4983         (base_breakpoint_allocate_location): Update.
4984         (free_bp_location): Update.
4985         * ada-lang.c (class ada_catchpoint_location)
4986         <ada_catchpoint_location>: Remove ops parameter.
4987         (ada_catchpoint_location_dtor): Remove.
4988         (ada_catchpoint_location_ops): Remove.
4989         (allocate_location_exception): Update.
4990         * breakpoint.h (struct bp_location_ops): Remove.
4991         (class bp_location) <bp_location>: Remove bp_location_ops
4992         parameter.
4993         <~bp_location>: Add destructor.
4994         <ops>: Remove.
4995
4996 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4997             Pedro Alves  <palves@redhat.com>
4998
4999         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5000         'PATH_MAX'.
5001
5002 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5003             Samuel Thibault  <samuel.thibault@gnu.org>
5004             Thomas Schwinge  <thomas@codesourcery.com>
5005
5006         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5007         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5008
5009 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5010
5011         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5012         (check_empty): Use "const char *".
5013
5014         * gnu-nat.c (gnu_nat_target::detach): Instead of
5015         'detach_inferior (pid)' call
5016         'detach_inferior (find_inferior_pid (pid))'.
5017
5018         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5019         'nat/fork-inferior.o'.
5020         * gnu-nat.c: #include "nat/fork-inferior.h".
5021
5022         * gnu-nat.c (gnu_nat_target::detach): Instead of
5023         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5024         * gnu-nat.h: #include "inf-child.h".
5025         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5026         'i386_gnu_nat_target::fetch_registers'.
5027         (gnu_store_registers): Rename/move to
5028         'i386_gnu_nat_target::store_registers'.
5029
5030         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5031         * gnu-nat.h (mach_thread_info): New function.
5032         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5033
5034         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5035
5036 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5037
5038         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5039
5040 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5041
5042         * windows-nat.c (windows_add_thread): Add new parameter
5043         "main_thread_p" with default value set to false.  Update
5044         function documentation as well as all callers.
5045         (windows_delete_thread): Likewise.
5046         (fake_create_process): Update call to windows_add_thread.
5047         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5048         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5049         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5050         call to windows_delete_thread.
5051
5052 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5053
5054         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5055
5056 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5057
5058         * symfile.c (find_separate_debug_file): Use canonical path of
5059         sysroot with child_path instead of gdb_sysroot if it is valid.
5060
5061 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5062
5063         * symfile.c (find_separate_debug_file): Use child_path to
5064         determine if an object file is under a sysroot.
5065
5066 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5067
5068         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5069         unittests/child-path-selftests.c.
5070         * common/pathstuff.c (child_path): New function.
5071         * common/pathstuff.h (child_path): New prototype.
5072         * unittests/child-path-selftests.c: New file.
5073
5074 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5075
5076         * symfile.c (find_separate_debug_file): Look for separate debug
5077         files in debug directories under the sysroot.
5078
5079 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5080
5081         * symtab.h (struct minimal_symbol data_p): New const method.
5082         (struct minimal_symbol text_p): Likewise.
5083         * symtab.c (output_source_filename): Use file name style
5084         to print file name.
5085         (print_symbol_info): Likewise.
5086         (print_msymbol_info): Use address style to print addresses.
5087         Use function name style to print executable text symbols.
5088         (expand_symtab_containing_pc): Use data_p.
5089         (find_pc_sect_compunit_symtab): Likewise.
5090
5091 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5092
5093         * breakpoint.c (describe_other_breakpoints): Use address style
5094         to print addresses.
5095         (say_where): Likewise.
5096
5097 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5098
5099         * ada-typeprint.c (print_func_type): Print function name
5100         style to print function name.
5101         * c-typeprint.c (c_print_type_1): Likewise.
5102
5103 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5104
5105         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5106         for execve.
5107
5108 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5109
5110         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5111         type_stack.
5112
5113 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5114
5115         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5116         TYPE_CODE_REF types.
5117
5118 2019-02-08  Jim Wilson  <jimw@sifive.com>
5119
5120         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5121         (riscv_linux_fregset): New.
5122         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5123
5124 2019-02-07  Tom Tromey  <tom@tromey.com>
5125
5126         * thread.c (thread_cancel_execution_command): Update.
5127         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5128         methods.
5129         (struct thread_fsm_ops): Remove.
5130         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5131         (thread_fsm_should_stop, thread_fsm_return_value)
5132         (thread_fsm_set_finished, thread_fsm_finished_p)
5133         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5134         Don't declare.
5135         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5136         * infrun.c (clear_proceed_status_thread)
5137         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5138         (print_stop_event): Update.
5139         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5140         Add constructor.
5141         (step_command_fsm_ops): Remove.
5142         (new_step_command_fsm): Remove.
5143         (step_1): Update.
5144         (step_command_fsm::should_stop): Rename from
5145         step_command_fsm_should_stop.
5146         (step_command_fsm::clean_up): Rename from
5147         step_command_fsm_clean_up.
5148         (step_command_fsm::do_async_reply_reason): Rename from
5149         step_command_fsm_async_reply_reason.
5150         (struct until_next_fsm): Inherit from thread_fsm.  Add
5151         constructor.
5152         (until_next_fsm_ops): Remove.
5153         (new_until_next_fsm): Remove.
5154         (until_next_fsm::should_stop): Rename from
5155         until_next_fsm_should_stop.
5156         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5157         (until_next_fsm::do_async_reply_reason): Rename from
5158         until_next_fsm_async_reply_reason.
5159         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5160         constructor.  Change type of breakpoint.
5161         (finish_command_fsm_ops): Remove.
5162         (new_finish_command_fsm): Remove.
5163         (finish_command_fsm::should_stop): Rename from
5164         finish_command_fsm_should_stop.
5165         (finish_command_fsm::clean_up): Rename from
5166         finish_command_fsm_clean_up.
5167         (finish_command_fsm::return_value): Rename from
5168         finish_command_fsm_return_value.
5169         (finish_command_fsm::do_async_reply_reason): Rename from
5170         finish_command_fsm_async_reply_reason.
5171         (finish_command): Update.
5172         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5173         Add constructor.
5174         (call_thread_fsm_ops): Remove.
5175         (call_thread_fsm::call_thread_fsm): Rename from
5176         new_call_thread_fsm.
5177         (call_thread_fsm::should_stop): Rename from
5178         call_thread_fsm_should_stop.
5179         (call_thread_fsm::should_notify_stop): Rename from
5180         call_thread_fsm_should_notify_stop.
5181         (run_inferior_call, call_function_by_hand_dummy): Update.
5182         * cli/cli-interp.c (should_print_stop_to_console): Update.
5183         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5184         Add constructor.  Change type of location_breakpoint,
5185         caller_breakpoint.
5186         (until_break_fsm_ops): Remove.
5187         (new_until_break_fsm): Remove.
5188         (until_break_fsm::should_stop): Rename from
5189         until_break_fsm_should_stop.
5190         (until_break_fsm::clean_up): Rename from
5191         until_break_fsm_clean_up.
5192         (until_break_fsm::do_async_reply_reason): Rename from
5193         until_break_fsm_async_reply_reason.
5194         (until_break_command): Update.
5195         * thread-fsm.c: Remove.
5196         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5197
5198 2019-02-07  Tom Tromey  <tom@tromey.com>
5199
5200         * yy-remap.h: Add include guard.
5201         * xtensa-tdep.h: Add include guard.
5202         * xcoffread.h: Rename include guard.
5203         * varobj-iter.h: Add include guard.
5204         * tui/tui.h: Rename include guard.
5205         * tui/tui-winsource.h: Rename include guard.
5206         * tui/tui-wingeneral.h: Rename include guard.
5207         * tui/tui-windata.h: Rename include guard.
5208         * tui/tui-win.h: Rename include guard.
5209         * tui/tui-stack.h: Rename include guard.
5210         * tui/tui-source.h: Rename include guard.
5211         * tui/tui-regs.h: Rename include guard.
5212         * tui/tui-out.h: Rename include guard.
5213         * tui/tui-layout.h: Rename include guard.
5214         * tui/tui-io.h: Rename include guard.
5215         * tui/tui-hooks.h: Rename include guard.
5216         * tui/tui-file.h: Rename include guard.
5217         * tui/tui-disasm.h: Rename include guard.
5218         * tui/tui-data.h: Rename include guard.
5219         * tui/tui-command.h: Rename include guard.
5220         * tic6x-tdep.h: Add include guard.
5221         * target/waitstatus.h: Rename include guard.
5222         * target/wait.h: Rename include guard.
5223         * target/target.h: Rename include guard.
5224         * target/resume.h: Rename include guard.
5225         * target-float.h: Rename include guard.
5226         * stabsread.h: Add include guard.
5227         * rs6000-tdep.h: Add include guard.
5228         * riscv-fbsd-tdep.h: Add include guard.
5229         * regformats/regdef.h: Rename include guard.
5230         * record.h: Rename include guard.
5231         * python/python.h: Rename include guard.
5232         * python/python-internal.h: Rename include guard.
5233         * python/py-stopevent.h: Rename include guard.
5234         * python/py-ref.h: Rename include guard.
5235         * python/py-record.h: Rename include guard.
5236         * python/py-record-full.h: Rename include guard.
5237         * python/py-record-btrace.h: Rename include guard.
5238         * python/py-instruction.h: Rename include guard.
5239         * python/py-events.h: Rename include guard.
5240         * python/py-event.h: Rename include guard.
5241         * procfs.h: Add include guard.
5242         * proc-utils.h: Add include guard.
5243         * p-lang.h: Add include guard.
5244         * or1k-tdep.h: Rename include guard.
5245         * observable.h: Rename include guard.
5246         * nto-tdep.h: Rename include guard.
5247         * nat/x86-linux.h: Rename include guard.
5248         * nat/x86-linux-dregs.h: Rename include guard.
5249         * nat/x86-gcc-cpuid.h: Add include guard.
5250         * nat/x86-dregs.h: Rename include guard.
5251         * nat/x86-cpuid.h: Rename include guard.
5252         * nat/ppc-linux.h: Rename include guard.
5253         * nat/mips-linux-watch.h: Rename include guard.
5254         * nat/linux-waitpid.h: Rename include guard.
5255         * nat/linux-ptrace.h: Rename include guard.
5256         * nat/linux-procfs.h: Rename include guard.
5257         * nat/linux-osdata.h: Rename include guard.
5258         * nat/linux-nat.h: Rename include guard.
5259         * nat/linux-namespaces.h: Rename include guard.
5260         * nat/linux-btrace.h: Rename include guard.
5261         * nat/glibc_thread_db.h: Rename include guard.
5262         * nat/gdb_thread_db.h: Rename include guard.
5263         * nat/gdb_ptrace.h: Rename include guard.
5264         * nat/fork-inferior.h: Rename include guard.
5265         * nat/amd64-linux-siginfo.h: Rename include guard.
5266         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5267         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5268         * nat/aarch64-linux.h: Rename include guard.
5269         * nat/aarch64-linux-hw-point.h: Rename include guard.
5270         * mn10300-tdep.h: Add include guard.
5271         * mips-linux-tdep.h: Add include guard.
5272         * mi/mi-parse.h: Rename include guard.
5273         * mi/mi-out.h: Rename include guard.
5274         * mi/mi-main.h: Rename include guard.
5275         * mi/mi-interp.h: Rename include guard.
5276         * mi/mi-getopt.h: Rename include guard.
5277         * mi/mi-console.h: Rename include guard.
5278         * mi/mi-common.h: Rename include guard.
5279         * mi/mi-cmds.h: Rename include guard.
5280         * mi/mi-cmd-break.h: Rename include guard.
5281         * m2-lang.h: Add include guard.
5282         * location.h: Rename include guard.
5283         * linux-record.h: Rename include guard.
5284         * linux-nat.h: Add include guard.
5285         * linux-fork.h: Add include guard.
5286         * i386-darwin-tdep.h: Rename include guard.
5287         * hppa-linux-offsets.h: Add include guard.
5288         * guile/guile.h: Rename include guard.
5289         * guile/guile-internal.h: Rename include guard.
5290         * gnu-nat.h: Rename include guard.
5291         * gdb-stabs.h: Rename include guard.
5292         * frv-tdep.h: Add include guard.
5293         * f-lang.h: Add include guard.
5294         * event-loop.h: Add include guard.
5295         * darwin-nat.h: Rename include guard.
5296         * cp-abi.h: Rename include guard.
5297         * config/sparc/nm-sol2.h: Rename include guard.
5298         * config/nm-nto.h: Rename include guard.
5299         * config/nm-linux.h: Add include guard.
5300         * config/i386/nm-i386gnu.h: Rename include guard.
5301         * config/djgpp/nl_types.h: Rename include guard.
5302         * config/djgpp/langinfo.h: Rename include guard.
5303         * compile/gcc-cp-plugin.h: Add include guard.
5304         * compile/gcc-c-plugin.h: Add include guard.
5305         * compile/compile.h: Rename include guard.
5306         * compile/compile-object-run.h: Rename include guard.
5307         * compile/compile-object-load.h: Rename include guard.
5308         * compile/compile-internal.h: Rename include guard.
5309         * compile/compile-cplus.h: Rename include guard.
5310         * compile/compile-c.h: Rename include guard.
5311         * common/xml-utils.h: Rename include guard.
5312         * common/x86-xstate.h: Rename include guard.
5313         * common/version.h: Rename include guard.
5314         * common/vec.h: Rename include guard.
5315         * common/tdesc.h: Rename include guard.
5316         * common/selftest.h: Rename include guard.
5317         * common/scoped_restore.h: Rename include guard.
5318         * common/scoped_mmap.h: Rename include guard.
5319         * common/scoped_fd.h: Rename include guard.
5320         * common/safe-iterator.h: Rename include guard.
5321         * common/run-time-clock.h: Rename include guard.
5322         * common/refcounted-object.h: Rename include guard.
5323         * common/queue.h: Rename include guard.
5324         * common/ptid.h: Rename include guard.
5325         * common/print-utils.h: Rename include guard.
5326         * common/preprocessor.h: Rename include guard.
5327         * common/pathstuff.h: Rename include guard.
5328         * common/observable.h: Rename include guard.
5329         * common/netstuff.h: Rename include guard.
5330         * common/job-control.h: Rename include guard.
5331         * common/host-defs.h: Rename include guard.
5332         * common/gdb_wait.h: Rename include guard.
5333         * common/gdb_vecs.h: Rename include guard.
5334         * common/gdb_unlinker.h: Rename include guard.
5335         * common/gdb_unique_ptr.h: Rename include guard.
5336         * common/gdb_tilde_expand.h: Rename include guard.
5337         * common/gdb_sys_time.h: Rename include guard.
5338         * common/gdb_string_view.h: Rename include guard.
5339         * common/gdb_splay_tree.h: Rename include guard.
5340         * common/gdb_setjmp.h: Rename include guard.
5341         * common/gdb_ref_ptr.h: Rename include guard.
5342         * common/gdb_optional.h: Rename include guard.
5343         * common/gdb_locale.h: Rename include guard.
5344         * common/gdb_assert.h: Rename include guard.
5345         * common/filtered-iterator.h: Rename include guard.
5346         * common/filestuff.h: Rename include guard.
5347         * common/fileio.h: Rename include guard.
5348         * common/environ.h: Rename include guard.
5349         * common/common-utils.h: Rename include guard.
5350         * common/common-types.h: Rename include guard.
5351         * common/common-regcache.h: Rename include guard.
5352         * common/common-inferior.h: Rename include guard.
5353         * common/common-gdbthread.h: Rename include guard.
5354         * common/common-exceptions.h: Rename include guard.
5355         * common/common-defs.h: Rename include guard.
5356         * common/common-debug.h: Rename include guard.
5357         * common/cleanups.h: Rename include guard.
5358         * common/buffer.h: Rename include guard.
5359         * common/btrace-common.h: Rename include guard.
5360         * common/break-common.h: Rename include guard.
5361         * cli/cli-utils.h: Rename include guard.
5362         * cli/cli-style.h: Rename include guard.
5363         * cli/cli-setshow.h: Rename include guard.
5364         * cli/cli-script.h: Rename include guard.
5365         * cli/cli-interp.h: Rename include guard.
5366         * cli/cli-decode.h: Rename include guard.
5367         * cli/cli-cmds.h: Rename include guard.
5368         * charset-list.h: Add include guard.
5369         * buildsym-legacy.h: Rename include guard.
5370         * bfin-tdep.h: Add include guard.
5371         * ax.h: Rename include guard.
5372         * arm-linux-tdep.h: Add include guard.
5373         * arm-fbsd-tdep.h: Add include guard.
5374         * arch/xtensa.h: Rename include guard.
5375         * arch/tic6x.h: Add include guard.
5376         * arch/i386.h: Add include guard.
5377         * arch/arm.h: Rename include guard.
5378         * arch/arm-linux.h: Rename include guard.
5379         * arch/arm-get-next-pcs.h: Rename include guard.
5380         * arch/amd64.h: Add include guard.
5381         * arch/aarch64-insn.h: Rename include guard.
5382         * arch-utils.h: Rename include guard.
5383         * annotate.h: Add include guard.
5384         * amd64-darwin-tdep.h: Rename include guard.
5385         * aarch64-linux-tdep.h: Add include guard.
5386         * aarch64-fbsd-tdep.h: Add include guard.
5387         * aarch32-linux-nat.h: Add include guard.
5388
5389 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5390
5391         * macrotab.c (macro_define_internal): New function that
5392         factorizes macro_define_object_internal and macro_define_function
5393         code.
5394         (macro_define_object_internal): Use macro_define_internal.
5395         (macro_define_function): Likewise.
5396
5397 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5398
5399         * macrocmd.c (extract_identifier): Return
5400         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5401         callers.
5402
5403 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5404
5405         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5406
5407 2019-02-05  Tom Tromey  <tom@tromey.com>
5408
5409         * target.c (target_stack::unpush): Move assertion earlier.
5410
5411 2019-01-30  Tom Tromey  <tom@tromey.com>
5412
5413         PR python/23615:
5414         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5415         (gdbpy_parse_and_eval): Likewise.
5416         * python/python-internal.h (gdbpy_allow_threads): New class.
5417
5418 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5419
5420         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5421         (aarch64_fbsd_fpregmap): Move earlier.
5422         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5423         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5424         instead of individual calls to trad_frame_set_reg_addr.
5425         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5426         earlier.
5427         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5428         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5429         instead of individual calls to trad_frame_set_reg_addr.
5430
5431 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5432
5433         * CONTRIBUTE: Replace contribution list with wiki link.
5434
5435 2019-01-25  Tom Tromey  <tom@tromey.com>
5436
5437         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5438
5439 2019-01-25  Tom Tromey  <tom@tromey.com>
5440
5441         * xtensa-linux-nat.c: Fix common/ includes.
5442         * xml-support.h: Fix common/ includes.
5443         * xml-support.c: Fix common/ includes.
5444         * x86-linux-nat.c: Fix common/ includes.
5445         * windows-nat.c: Fix common/ includes.
5446         * varobj.h: Fix common/ includes.
5447         * varobj.c: Fix common/ includes.
5448         * value.c: Fix common/ includes.
5449         * valops.c: Fix common/ includes.
5450         * utils.c: Fix common/ includes.
5451         * unittests/xml-utils-selftests.c: Fix common/ includes.
5452         * unittests/utils-selftests.c: Fix common/ includes.
5453         * unittests/unpack-selftests.c: Fix common/ includes.
5454         * unittests/tracepoint-selftests.c: Fix common/ includes.
5455         * unittests/style-selftests.c: Fix common/ includes.
5456         * unittests/string_view-selftests.c: Fix common/ includes.
5457         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5458         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5459         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5460         * unittests/rsp-low-selftests.c: Fix common/ includes.
5461         * unittests/parse-connection-spec-selftests.c: Fix common/
5462         includes.
5463         * unittests/optional-selftests.c: Fix common/ includes.
5464         * unittests/offset-type-selftests.c: Fix common/ includes.
5465         * unittests/observable-selftests.c: Fix common/ includes.
5466         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5467         * unittests/memrange-selftests.c: Fix common/ includes.
5468         * unittests/memory-map-selftests.c: Fix common/ includes.
5469         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5470         * unittests/function-view-selftests.c: Fix common/ includes.
5471         * unittests/environ-selftests.c: Fix common/ includes.
5472         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5473         * unittests/common-utils-selftests.c: Fix common/ includes.
5474         * unittests/cli-utils-selftests.c: Fix common/ includes.
5475         * unittests/array-view-selftests.c: Fix common/ includes.
5476         * ui-file.c: Fix common/ includes.
5477         * tui/tui-io.c: Fix common/ includes.
5478         * tracepoint.h: Fix common/ includes.
5479         * tracepoint.c: Fix common/ includes.
5480         * tracefile-tfile.c: Fix common/ includes.
5481         * top.h: Fix common/ includes.
5482         * top.c: Fix common/ includes.
5483         * thread.c: Fix common/ includes.
5484         * target/waitstatus.h: Fix common/ includes.
5485         * target/waitstatus.c: Fix common/ includes.
5486         * target.h: Fix common/ includes.
5487         * target.c: Fix common/ includes.
5488         * target-memory.c: Fix common/ includes.
5489         * target-descriptions.c: Fix common/ includes.
5490         * symtab.h: Fix common/ includes.
5491         * symfile.c: Fix common/ includes.
5492         * stap-probe.c: Fix common/ includes.
5493         * spu-linux-nat.c: Fix common/ includes.
5494         * sparc-nat.c: Fix common/ includes.
5495         * source.c: Fix common/ includes.
5496         * solib.c: Fix common/ includes.
5497         * solib-target.c: Fix common/ includes.
5498         * ser-unix.c: Fix common/ includes.
5499         * ser-tcp.c: Fix common/ includes.
5500         * ser-pipe.c: Fix common/ includes.
5501         * ser-base.c: Fix common/ includes.
5502         * selftest-arch.c: Fix common/ includes.
5503         * s12z-tdep.c: Fix common/ includes.
5504         * rust-exp.y: Fix common/ includes.
5505         * rs6000-aix-tdep.c: Fix common/ includes.
5506         * riscv-tdep.c: Fix common/ includes.
5507         * remote.c: Fix common/ includes.
5508         * remote-notif.h: Fix common/ includes.
5509         * remote-fileio.h: Fix common/ includes.
5510         * remote-fileio.c: Fix common/ includes.
5511         * regcache.h: Fix common/ includes.
5512         * regcache.c: Fix common/ includes.
5513         * record-btrace.c: Fix common/ includes.
5514         * python/python.c: Fix common/ includes.
5515         * python/py-type.c: Fix common/ includes.
5516         * python/py-inferior.c: Fix common/ includes.
5517         * progspace.h: Fix common/ includes.
5518         * producer.c: Fix common/ includes.
5519         * procfs.c: Fix common/ includes.
5520         * proc-api.c: Fix common/ includes.
5521         * printcmd.c: Fix common/ includes.
5522         * ppc-linux-nat.c: Fix common/ includes.
5523         * parser-defs.h: Fix common/ includes.
5524         * osdata.c: Fix common/ includes.
5525         * obsd-nat.c: Fix common/ includes.
5526         * nat/x86-linux.c: Fix common/ includes.
5527         * nat/x86-linux-dregs.c: Fix common/ includes.
5528         * nat/x86-dregs.h: Fix common/ includes.
5529         * nat/x86-dregs.c: Fix common/ includes.
5530         * nat/ppc-linux.c: Fix common/ includes.
5531         * nat/mips-linux-watch.h: Fix common/ includes.
5532         * nat/mips-linux-watch.c: Fix common/ includes.
5533         * nat/linux-waitpid.c: Fix common/ includes.
5534         * nat/linux-ptrace.h: Fix common/ includes.
5535         * nat/linux-ptrace.c: Fix common/ includes.
5536         * nat/linux-procfs.c: Fix common/ includes.
5537         * nat/linux-personality.c: Fix common/ includes.
5538         * nat/linux-osdata.c: Fix common/ includes.
5539         * nat/linux-namespaces.c: Fix common/ includes.
5540         * nat/linux-btrace.h: Fix common/ includes.
5541         * nat/linux-btrace.c: Fix common/ includes.
5542         * nat/fork-inferior.c: Fix common/ includes.
5543         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5544         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5545         * nat/aarch64-linux.c: Fix common/ includes.
5546         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5547         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5548         * namespace.h: Fix common/ includes.
5549         * mips-linux-tdep.c: Fix common/ includes.
5550         * minsyms.c: Fix common/ includes.
5551         * mi/mi-parse.h: Fix common/ includes.
5552         * mi/mi-main.c: Fix common/ includes.
5553         * mi/mi-cmd-env.c: Fix common/ includes.
5554         * memrange.h: Fix common/ includes.
5555         * memattr.c: Fix common/ includes.
5556         * maint.h: Fix common/ includes.
5557         * maint.c: Fix common/ includes.
5558         * main.c: Fix common/ includes.
5559         * machoread.c: Fix common/ includes.
5560         * location.c: Fix common/ includes.
5561         * linux-thread-db.c: Fix common/ includes.
5562         * linux-nat.c: Fix common/ includes.
5563         * linux-fork.c: Fix common/ includes.
5564         * inline-frame.c: Fix common/ includes.
5565         * infrun.c: Fix common/ includes.
5566         * inflow.c: Fix common/ includes.
5567         * inferior.h: Fix common/ includes.
5568         * inferior.c: Fix common/ includes.
5569         * infcmd.c: Fix common/ includes.
5570         * inf-ptrace.c: Fix common/ includes.
5571         * inf-child.c: Fix common/ includes.
5572         * ia64-linux-nat.c: Fix common/ includes.
5573         * i387-tdep.c: Fix common/ includes.
5574         * i386-tdep.c: Fix common/ includes.
5575         * i386-linux-tdep.c: Fix common/ includes.
5576         * i386-linux-nat.c: Fix common/ includes.
5577         * i386-go32-tdep.c: Fix common/ includes.
5578         * i386-fbsd-tdep.c: Fix common/ includes.
5579         * i386-fbsd-nat.c: Fix common/ includes.
5580         * guile/scm-type.c: Fix common/ includes.
5581         * guile/guile.c: Fix common/ includes.
5582         * go32-nat.c: Fix common/ includes.
5583         * gnu-nat.c: Fix common/ includes.
5584         * gdbthread.h: Fix common/ includes.
5585         * gdbarch-selftests.c: Fix common/ includes.
5586         * gdb_usleep.c: Fix common/ includes.
5587         * gdb_select.h: Fix common/ includes.
5588         * gdb_bfd.c: Fix common/ includes.
5589         * gcore.c: Fix common/ includes.
5590         * fork-child.c: Fix common/ includes.
5591         * findvar.c: Fix common/ includes.
5592         * fbsd-nat.c: Fix common/ includes.
5593         * event-top.c: Fix common/ includes.
5594         * event-loop.c: Fix common/ includes.
5595         * dwarf2read.c: Fix common/ includes.
5596         * dwarf2loc.c: Fix common/ includes.
5597         * dwarf2-frame.c: Fix common/ includes.
5598         * dwarf-index-cache.c: Fix common/ includes.
5599         * dtrace-probe.c: Fix common/ includes.
5600         * disasm-selftests.c: Fix common/ includes.
5601         * defs.h: Fix common/ includes.
5602         * csky-tdep.c: Fix common/ includes.
5603         * cp-valprint.c: Fix common/ includes.
5604         * cp-support.h: Fix common/ includes.
5605         * cp-support.c: Fix common/ includes.
5606         * corelow.c: Fix common/ includes.
5607         * completer.h: Fix common/ includes.
5608         * completer.c: Fix common/ includes.
5609         * compile/compile.c: Fix common/ includes.
5610         * compile/compile-loc2c.c: Fix common/ includes.
5611         * compile/compile-cplus-types.c: Fix common/ includes.
5612         * compile/compile-cplus-symbols.c: Fix common/ includes.
5613         * command.h: Fix common/ includes.
5614         * cli/cli-dump.c: Fix common/ includes.
5615         * cli/cli-cmds.c: Fix common/ includes.
5616         * charset.c: Fix common/ includes.
5617         * build-id.c: Fix common/ includes.
5618         * btrace.h: Fix common/ includes.
5619         * btrace.c: Fix common/ includes.
5620         * breakpoint.h: Fix common/ includes.
5621         * breakpoint.c: Fix common/ includes.
5622         * ax.h:
5623         (enum agent_op): Fix common/ includes.
5624         * ax-general.c (struct aop_map): Fix common/ includes.
5625         * ax-gdb.c: Fix common/ includes.
5626         * auxv.c: Fix common/ includes.
5627         * auto-load.c: Fix common/ includes.
5628         * arm-tdep.c: Fix common/ includes.
5629         * arch/riscv.c: Fix common/ includes.
5630         * arch/ppc-linux-common.c: Fix common/ includes.
5631         * arch/i386.c: Fix common/ includes.
5632         * arch/arm.c: Fix common/ includes.
5633         * arch/arm-linux.c: Fix common/ includes.
5634         * arch/arm-get-next-pcs.c: Fix common/ includes.
5635         * arch/amd64.c: Fix common/ includes.
5636         * arch/aarch64.c: Fix common/ includes.
5637         * arch/aarch64-insn.c: Fix common/ includes.
5638         * arch-utils.c: Fix common/ includes.
5639         * amd64-windows-tdep.c: Fix common/ includes.
5640         * amd64-tdep.c: Fix common/ includes.
5641         * amd64-sol2-tdep.c: Fix common/ includes.
5642         * amd64-obsd-tdep.c: Fix common/ includes.
5643         * amd64-nbsd-tdep.c: Fix common/ includes.
5644         * amd64-linux-tdep.c: Fix common/ includes.
5645         * amd64-linux-nat.c: Fix common/ includes.
5646         * amd64-fbsd-tdep.c: Fix common/ includes.
5647         * amd64-fbsd-nat.c: Fix common/ includes.
5648         * amd64-dicos-tdep.c: Fix common/ includes.
5649         * amd64-darwin-tdep.c: Fix common/ includes.
5650         * agent.c: Fix common/ includes.
5651         * ada-lang.h: Fix common/ includes.
5652         * ada-lang.c: Fix common/ includes.
5653         * aarch64-tdep.c: Fix common/ includes.
5654
5655 2019-01-25  Tom Tromey  <tom@tromey.com>
5656
5657         * common/create-version.sh: Use common/version.h.
5658
5659 2019-01-24  Pedro Alves  <palves@redhat.com>
5660
5661         * infrun.c (signal_stop, signal_print, signal_program)
5662         (signal_catch, signal_pass): Now arrays instead of pointers.
5663         (update_signals_program_target, do_target_resume)
5664         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5665         * linux-nat.c (linux_nat_target::pass_signals)
5666         (linux_nat_target::create_inferior, linux_nat_target::attach):
5667         Adjust.
5668         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5669         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5670         * procfs.c (procfs_target::pass_signals): Adjust.
5671         * record-full.c (record_full_target::resume): Adjust.
5672         * remote.c (remote_target::pass_signals)
5673         (remote_target::program_signals): Adjust.
5674         * target-debug.h (target_debug_print_signals): Now takes a
5675         gdb::array_view as parameter.  Adjust.
5676         * target.h (target_ops) <pass_signals, program_signals>: Replace
5677         pointer and length parameters with gdb::array_view.
5678         (target_pass_signals, target_program_signals): Likewise.
5679         * target-delegates.c: Regenerate.
5680
5681 2019-01-24  Pedro Alves  <palves@redhat.com>
5682
5683         * common/forward-scope-exit.h
5684         (forward_scope_exit::forward_scope_exit): Pass arguments to
5685         m_bind_function directly, instead of creating a std::bind and
5686         copying that.
5687
5688 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5689
5690         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5691         for static members.
5692         (pass_in_v_vfp_candidate): Likewise.
5693
5694 2019-01-23  Tom Tromey  <tom@tromey.com>
5695             Pedro Alves  <palves@redhat.com>
5696
5697         * regcache.c (class regcache_invalidator): Remove.
5698         (regcache::raw_write): Use make_scope_exit.
5699
5700 2019-01-23  Tom Tromey  <tom@tromey.com>
5701
5702         * ui-out.h (class ui_out_emit_type): Update comment.
5703
5704 2019-01-23  Tom Tromey  <tom@tromey.com>
5705
5706         * infrun.c (fetch_inferior_event): Update comment.
5707
5708 2019-01-23  Tom Tromey  <tom@tromey.com>
5709             Pedro Alves  <palves@redhat.com>
5710
5711         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5712         parameter.
5713         (fetch_inferior_event): Use SCOPE_EXIT.
5714
5715
5716 2019-01-23  Tom Tromey  <tom@tromey.com>
5717             Pedro Alves  <palves@redhat.com>
5718
5719         * infrun.c (disable_thread_events): Delete.
5720         (stop_all_threads): Use SCOPE_EXIT.
5721
5722 2019-01-23  Tom Tromey  <tom@tromey.com>
5723             Pedro Alves  <palves@redhat.com>
5724
5725         * symfile.c: Include forward-scope-exit.h.
5726         (clear_symtab_users_cleanup): Replace forward declaration with
5727         a FORWARD_SCOPE_EXIT.
5728         (syms_from_objfile_1): Use the forward_scope_exit and
5729         gdb::optional instead of cleanup_function.
5730         (reread_symbols): Use the forward_scope_exit instead of
5731         cleanup_function.
5732         (clear_symtab_users_cleanup): Remove function.
5733
5734 2019-01-23  Tom Tromey  <tom@tromey.com>
5735             Pedro Alves  <palves@redhat.com>
5736
5737         * linux-nat.c: Include scope-exit.h.
5738         (cleanup_target_stop): Remove.
5739         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5740         SCOPE_EXIT.
5741
5742 2019-01-23  Tom Tromey  <tom@tromey.com>
5743             Pedro Alves  <palves@redhat.com>
5744
5745         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5746         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5747
5748 2019-01-23  Tom Tromey  <tom@tromey.com>
5749             Andrew Burgess  <andrew.burgess@embecosm.com>
5750             Pedro Alves  <palves@redhat.com>
5751
5752         * infrun.c (fetch_inferior_event): Use scope_exit.
5753         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5754         * top.c (execute_command): Use scope_exit.
5755         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5756         * utils.c (do_bpstat_clear_actions_cleanup)
5757         (make_bpstat_clear_actions_cleanup): Remove.
5758
5759 2019-01-23  Tom Tromey  <tom@tromey.com>
5760             Pedro Alves  <palves@redhat.com>
5761
5762         * infrun.c: Include "common/scope-exit.h"
5763         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5764         (wait_for_inferior): Use SCOPE_EXIT.
5765         (fetch_inferior_event): Use scope_exit.
5766
5767 2019-01-23  Tom Tromey  <tom@tromey.com>
5768             Pedro Alves  <palves@redhat.com>
5769
5770         * breakpoint.c (create_breakpoint): Remove cleanup.
5771
5772 2019-01-23  Tom Tromey  <tom@tromey.com>
5773             Andrew Burgess  <andrew.burgess@embecosm.com>
5774             Pedro Alves  <palves@redhat.com>
5775
5776 2019-01-23  Pedro Alves  <palves@redhat.com>
5777
5778         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5779
5780 2019-01-23  Pedro Alves  <palves@redhat.com>
5781             Andrew Burgess  <andrew.burgess@embecosm.com>
5782
5783         * gdbthread.h: Include "common/forward-scope-exit.h".
5784         (scoped_finish_thread_state): Redefine custom class in terms of
5785         forward_scope_exit.
5786
5787 2019-01-23  Pedro Alves  <palves@redhat.com>
5788             Andrew Burgess  <andrew.burgess@embecosm.com>
5789
5790         * common/forward-scope-exit.h: New file.
5791
5792 2019-01-23  Pedro Alves  <palves@redhat.com>
5793             Andrew Burgess  <andrew.burgess@embecosm.com>
5794             Tom Tromey  <tom@tromey.com>
5795
5796         * common/scope-exit.h: New file.
5797
5798 2019-01-23  Pedro Alves  <palves@redhat.com>
5799
5800         * common/preprocessor.h (ESC): Rename to ...
5801         (ESC_PARENS): ... this.
5802         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5803         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5804
5805 2019-01-23  Tom Tromey  <tom@tromey.com>
5806
5807         * language.h (class scoped_switch_to_sym_language_if_auto):
5808         Initialize m_lang in both cases.
5809
5810 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5811
5812         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5813         with XCNEW.
5814
5815 2019-01-22  Tom Tromey  <tom@tromey.com>
5816
5817         * corelow.c: Do not include sys/file.h.
5818
5819 2019-01-22  Tom Tromey  <tom@tromey.com>
5820
5821         * tui/tui-wingeneral.h: Include gdb_curses.h.
5822
5823 2019-01-22  Tom Tromey  <tom@tromey.com>
5824
5825         * source-cache.h (class source_cache) <get_source_lines,
5826         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5827
5828 2019-01-22  Tom Tromey  <tom@tromey.com>
5829
5830         * remote-fileio.h (struct remote_target): Declare.
5831
5832 2019-01-22  Tom Tromey  <tom@tromey.com>
5833
5834         * python/py-arch.c: Do not include py-ref.h.
5835         * python/py-bpevent.c: Do not include py-ref.h.
5836         * python/py-cmd.c: Do not include py-ref.h.
5837         * python/py-continueevent.c: Do not include py-ref.h.
5838         * python/py-event.h: Do not include py-ref.h.
5839         * python/py-evtregistry.c: Do not include py-ref.h.
5840         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5841         * python/py-frame.c: Do not include py-ref.h.
5842         * python/py-framefilter.c: Do not include py-ref.h.
5843         * python/py-function.c: Do not include py-ref.h.
5844         * python/py-infevents.c: Do not include py-ref.h.
5845         * python/py-linetable.c: Do not include py-ref.h.
5846         * python/py-objfile.c: Do not include py-ref.h.
5847         * python/py-param.c: Do not include py-ref.h.
5848         * python/py-prettyprint.c: Do not include py-ref.h.
5849         * python/py-progspace.c: Do not include py-ref.h.
5850         * python/py-symbol.c: Do not include py-ref.h.
5851         * python/py-symtab.c: Do not include py-ref.h.
5852         * python/py-type.c: Do not include py-ref.h.
5853         * python/py-unwind.c: Do not include py-ref.h.
5854         * python/py-utils.c: Do not include py-ref.h.
5855         * python/py-value.c: Do not include py-ref.h.
5856         * python/py-varobj.c: Do not include py-ref.h.
5857         * python/py-xmethods.c: Do not include py-ref.h.
5858         * python/python.c: Do not include py-ref.h.
5859         * varobj.c: Do not include py-ref.h.
5860
5861 2019-01-22  Tom Tromey  <tom@tromey.com>
5862
5863         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5864         keyword for bcache.
5865
5866 2019-01-22  Tom Tromey  <tom@tromey.com>
5867
5868         * compile/compile-cplus-types.c: Remove a comment by #include.
5869
5870 2019-01-22  Tom Tromey  <tom@tromey.com>
5871
5872         * compile/gcc-c-plugin.h: Include compile-internal.h.
5873
5874 2019-01-22  Tom Tromey  <tom@tromey.com>
5875
5876         * stabsread.c (EXTERN): Do not define.
5877         (symnum, next_symbol_text_func, processing_gcc_compilation)
5878         (within_function, global_sym_chain, global_stabs)
5879         (previous_stab_code, this_object_header_files)
5880         (n_this_object_header_files)
5881         (n_allocated_this_object_header_files): Define.
5882         * stabsread.h (EXTERN): Never define.  Use "extern".
5883
5884 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5885
5886         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5887         history_value.
5888
5889 2019-01-21  Tom Tromey  <tom@tromey.com>
5890
5891         * ui-out.c: Fix includes.
5892         * tui/tui-source.c: Fix includes.
5893         * target.c: Fix includes.
5894         * remote.c: Fix includes.
5895         * regcache.c: Fix includes.
5896         * python/py-block.c: Fix includes.
5897         * printcmd.c: Fix includes.
5898         * or1k-tdep.c: Fix includes.
5899         * mi/mi-main.c: Fix includes.
5900         * m32r-tdep.c: Fix includes.
5901         * csky-tdep.c: Fix includes.
5902         * compile/compile-cplus-types.c: Fix includes.
5903         * cli/cli-interp.c: Fix includes.
5904
5905 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5906
5907         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5908         for padding.
5909
5910 2019-01-16  Tom Tromey  <tom@tromey.com>
5911
5912         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5913         earlier.
5914         (struct objfile) <msymbols_range>: Move from top level.
5915         <msymbols>: New method.
5916         (class objfile_msymbols): Remove.
5917         * symtab.c (default_collect_symbol_completion_matches_break_on):
5918         Update.
5919         * symmisc.c (dump_msymbols): Update.
5920         * stabsread.c (scan_file_globals): Update.
5921         * objc-lang.c (info_selectors_command, info_classes_command)
5922         (find_methods): Update.
5923         * minsyms.c (find_solib_trampoline_target): Update.
5924         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5925         * coffread.c (coff_symfile_read): Update.
5926         * ada-lang.c (ada_lookup_simple_minsym)
5927         (ada_collect_symbol_completion_matches): Update.
5928
5929 2019-01-16  Tom Tromey  <tom@tromey.com>
5930
5931         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5932         type.  Remove no-argument constructor.
5933         <iterator::operator++>: Simplify.
5934         <begin>: Update.
5935         <end>: Use minimal_symbol_count.
5936
5937 2019-01-16  Tom Tromey  <tom@tromey.com>
5938
5939         * objfiles.h (struct objfile) <psymtabs>: New method.
5940         (class objfile_psymtabs): Remove.
5941         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5942         typedef.
5943         <range>: New method.
5944         (require_partial_symbols): Change return type.
5945         * psymtab.c (require_partial_symbols)
5946         (psym_expand_symtabs_matching): Update.
5947         * mdebugread.c (parse_partial_symbols): Update.
5948         * dbxread.c (dbx_end_psymtab): Update.
5949
5950 2019-01-15  Tom Tromey  <tom@tromey.com>
5951
5952         * symtab.c (lookup_objfile_from_block)
5953         (lookup_symbol_in_objfile_symtabs)
5954         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5955         (find_line_symtab, info_sources_command)
5956         (default_collect_symbol_completion_matches_break_on)
5957         (make_source_files_completion_list): Update.
5958         * symmisc.c (print_objfile_statistics, dump_objfile)
5959         (maintenance_print_symbols, maintenance_info_symtabs)
5960         (maintenance_check_symtabs, maintenance_info_line_tables):
5961         Update.
5962         * source.c (select_source_symtab)
5963         (forget_cached_source_info_for_objfile): Update.
5964         * objfiles.h (class objfile_compunits): Remove.
5965         (struct objfile) <compunits_range>: New typedef.
5966         (compunits): New method.
5967         * objfiles.c (objfile_relocate1): Update.
5968         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5969         * maint.c (count_symtabs_and_blocks): Update.
5970         * linespec.c (iterate_over_all_matching_symtabs): Update.
5971         * cp-support.c (add_symbol_overload_list_qualified): Update.
5972         * coffread.c (coff_symtab_read): Update.
5973         * ada-lang.c (add_nonlocal_symbols)
5974         (ada_collect_symbol_completion_matches)
5975         (ada_add_global_exceptions): Update.
5976
5977 2019-01-15  Tom Tromey  <tom@tromey.com>
5978
5979         * progspace.h (program_space) <objfiles_safe_range>: New
5980         typedef.
5981         <objfiles_safe>: New method.
5982         * objfiles.h (class all_objfiles_safe): Remove.
5983         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5984         * jit.c (jit_inferior_exit_hook): Update.
5985
5986 2019-01-17  Tom Tromey  <tom@tromey.com>
5987
5988         * progspace.h (program_space) <objfiles_range>: New typedef.
5989         <objfiles>: New method.
5990         <objfiles_head>: Rename from objfiles.
5991         (object_files): Update.
5992         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5993         * guile/scm-pretty-print.c
5994         (ppscm_find_pretty_printer_from_objfiles): Update.
5995         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5996         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5997         Update.
5998         * python/py-progspace.c (pspy_get_objfiles): Update.
5999         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6000         Update.
6001         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6002         (objfpy_lookup_objfile_by_build_id): Update.
6003         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6004         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6005         Update.
6006         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6007         (expand_symtab_containing_pc, lookup_objfile_from_block)
6008         (lookup_static_symbol, basic_lookup_transparent_type)
6009         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6010         (find_line_symtab, info_sources_command)
6011         (default_collect_symbol_completion_matches_break_on)
6012         (make_source_files_completion_list, find_main_name): Update.
6013         * symmisc.c (print_symbol_bcache_statistics)
6014         (print_objfile_statistics, maintenance_print_symbols)
6015         (maintenance_print_msymbols, maintenance_print_objfiles)
6016         (maintenance_info_symtabs, maintenance_check_symtabs)
6017         (maintenance_expand_symtabs, maintenance_info_line_tables):
6018         Update.
6019         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6020         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6021         (map_overlay_command, unmap_overlay_command)
6022         (simple_overlay_update, expand_symtabs_matching)
6023         (map_symbol_filenames): Update.
6024         * symfile-debug.c (set_debug_symfile): Update.
6025         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6026         Update.
6027         * source.c (select_source_symtab, forget_cached_source_info):
6028         Update.
6029         * solib.c (solib_read_symbols): Update.
6030         * solib-spu.c (append_ocl_sos): Update.
6031         * psymtab.c (maintenance_print_psymbols)
6032         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6033         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6034         * printcmd.c (info_symbol_command): Update.
6035         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6036         Update.
6037         * objfiles.h (class all_objfiles): Remove.
6038         * objfiles.c (have_partial_symbols, have_full_symbols)
6039         (have_minimal_symbols, qsort_cmp, update_section_map)
6040         (shared_objfile_contains_address_p)
6041         (default_iterate_over_objfiles_in_search_order): Update.
6042         * objc-lang.c (info_selectors_command, info_classes_command)
6043         (find_methods): Update.
6044         * minsyms.c (find_solib_trampoline_target): Update.
6045         * maint.c (maintenance_info_sections)
6046         (maintenance_translate_address, count_symtabs_and_blocks):
6047         Update.
6048         * main.c (captured_main_1): Update.
6049         * linux-thread-db.c (try_thread_db_load_from_pdir)
6050         (has_libpthread): Update.
6051         * linespec.c (iterate_over_all_matching_symtabs)
6052         (search_minsyms_for_name): Update.
6053         * jit.c (jit_find_objf_with_entry_addr): Update.
6054         * hppa-tdep.c (find_unwind_entry)
6055         (hppa_lookup_stub_minimal_symbol): Update.
6056         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6057         Update.
6058         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6059         (elf_gnu_ifunc_resolve_by_got): Update.
6060         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6061         * dwarf-index-write.c (save_gdb_index_command): Update.
6062         * cp-support.c (add_symbol_overload_list_qualified): Update.
6063         * breakpoint.c (create_overlay_event_breakpoint)
6064         (create_longjmp_master_breakpoint)
6065         (create_std_terminate_master_breakpoint)
6066         (create_exception_master_breakpoint): Update.
6067         * blockframe.c (find_pc_partial_function): Update.
6068         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6069         (ada_collect_symbol_completion_matches)
6070         (ada_add_global_exceptions): Update.
6071
6072 2019-01-17  Tom Tromey  <tom@tromey.com>
6073
6074         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6075         declare VEC.
6076         (solib_target_parse_libraries): Change return type.
6077         (library_list_start_segment, library_list_start_section)
6078         (library_list_end_library, library_list_start_library); Update.
6079         (solib_target_free_library_list): Remove.
6080         (solib_target_parse_libraries): Remove cleanup.  Change return
6081         type.
6082         (solib_target_current_sos): Update.
6083
6084 2019-01-17  Tom Tromey  <tromey@bapiya>
6085
6086         * valprint.c: Replace "the the" with "the".
6087         * symtab.c: Replace "the the" with "the".
6088         * solib.c: Replace "the the" with "the".
6089         * solib-dsbt.c: Replace "the the" with "the".
6090         * linespec.c: Replace "the the" with "the".
6091         * dwarf2loc.h: Replace "the the" with "the".
6092         * amd64-windows-tdep.c: Replace "the the" with "the".
6093         * aarch64-tdep.c: Replace "the the" with "the".
6094
6095 2019-01-16  Keith Seitz  <keiths@redhat.com>
6096
6097         PR gdb/23773
6098         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6099         <builder>: Rename to ..
6100         <m_builder>: ... this and make private.
6101         (dwarf2_cu::get_builder): New method.  Change all users of
6102         `builder' to use this method.
6103         (dwarf2_start_symtab): Move to ...
6104         (dwarf2_cu::start_symtab): ... here.  Update all callers
6105         (setup_type_unit_groups): Move to ...
6106         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6107         callers.
6108         (dwarf2_cu::reset_builder): New method.
6109         (process_full_compunit, process_full_type_unit): Use
6110         dwarf2_cu::reset_builder.
6111         (follow_die_offset): Record the ancestor CU if it is different
6112         from the followed DIE's CU.
6113         (follow_die_sig_1): Likewise.
6114
6115 2019-01-15  Tom Tromey  <tom@tromey.com>
6116
6117         * remote.c (class remote_state) <buf>: Now a char_vector.
6118         <buf_size>: Remove.
6119         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6120         parameter.
6121         (remote_target::getpkt_or_notif_sane_1)
6122         (remote_target::getpkt_sane)
6123         (remote_target::getpkt_or_notif_sane): Likewise.
6124         (class remote_target) <putpkt>: New overload.
6125         (remote_target::read_frame): Change type of "buf_p".  Remove
6126         sizeof_p parameter.
6127         (packet_ok): New overload.
6128         (packet_check_result): New overload.
6129         Update all uses.
6130
6131 2019-01-14  Tom Tromey  <tom@tromey.com>
6132
6133         * remote-notif.c (handle_notification, remote_notif_ack)
6134         (remote_notif_parse): Make "buf" const.
6135         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6136         const.
6137         (remote_notif_parse, remote_notif_ack, handle_notification):
6138         Likewise.
6139         * remote.c (remote_notif_stop_parse): Make "buf" const.
6140         (remote_target::remote_parse_stop_reply): Make "buf" const.
6141         (remote_notif_stop_ack): Make "buf" const.
6142
6143 2019-01-14  Tom Tromey  <tom@tromey.com>
6144
6145         * remote.c (remote_console_output): Make parameter const.
6146
6147 2019-01-14  Tom Tromey  <tom@tromey.com>
6148
6149         * target-debug.h (target_debug_print_signals): Constify.
6150         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6151         * procfs.c (procfs_target::pass_signals): Update.
6152         * linux-nat.c (linux_nat_target::pass_signals): Update.
6153         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6154         * target-delegates.c: Rebuild.
6155         * remote.c (remote_target::program_signals): Update.
6156         (remote_target::pass_signals): Update.
6157         * target.c (target_pass_signals): Constify argument.
6158         (target_program_signals): Likewise.
6159         * target.h (struct target_ops) <pass_signals, program_signals>:
6160         Constify argument.
6161         (target_pass_signals, target_program_signals): Constify argument.
6162
6163 2019-01-14  Tom Tromey  <tom@tromey.com>
6164
6165         PR tui/28819:
6166         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6167
6168 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6169
6170         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6171         field.
6172         * rs6000-tdep.c: Include reggroups.h.
6173         (IS_V_ALIAS_PSEUDOREG): Define.
6174         (rs6000_register_name): Return names for the "vX" aliases.
6175         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6176         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6177         aliases.  Call default_register_reggroup_p for all other
6178         pseudo-registers.
6179         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6180         New functions.
6181         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6182         Handle "vX" aliases.
6183         (v_alias_pseudo_register_collect): New function.
6184         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6185         (rs6000_gdbarch_init): Initialize "vX" aliases as
6186         pseudo-registers.  Restore registration of
6187         rs6000_pseudo_register_reggroup_p with
6188         set_tdesc_pseudo_register_reggroup_p.
6189
6190 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6191
6192         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6193         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6194         set_gdbarch_num_pseudo_regs.
6195
6196 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6197
6198         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6199         Remove arg prefixname, add do_set and do_show.
6200         Add member functions set_list and show_list.
6201         * cli/cli-style.c (class cli_style_option): Update accordingly.
6202         (style_set_list): Move to file scope.
6203         (style_show_list): Likewise.
6204         (set_style): Call help_list.
6205         (show_style): Call cmd_show_list.
6206         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6207         Update to use the new macro.
6208
6209 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6210
6211         * ada-lang.c (_initialize_ada_language): Expand the help text
6212         for the "catch exception" command.
6213
6214 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6215
6216         * symtab.c (matching_obj_sections): Initialize obj,
6217         declare it closer to its usage.
6218
6219 2019-01-10  Tom Tromey  <tom@tromey.com>
6220
6221         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6222         (basic_inf_threads_range): Remove.
6223         (inf_threads_range, inf_non_exited_threads_range)
6224         (safe_inf_threads_range): Use next_adapter.
6225
6226 2019-01-10  Keith Seitz  <keiths@redhat.com>
6227
6228         PR gdb/23712
6229         PR symtab/23010
6230         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6231         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6232
6233 2019-01-10  Keith Seitz  <keiths@redhat.com>
6234
6235         PR gdb/23712
6236         PR symtab/23010
6237         * dictionary.c (pending_to_vector): Remove.
6238         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6239         Remove _1 suffix, replacing functions of the same name.  Update
6240         all callers.
6241         (dict_create_hashed, dict_create_hashed_expandable)
6242         (dict_create_linear, dict_create_linear_expandable, dict_free)
6243         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6244         Make functions static.
6245
6246 2019-01-10  Keith Seitz  <keiths@redhat.com>
6247
6248         PR gdb/23712
6249         PR symtab/23010
6250         * dictionary.h (struct dictionary): Replace declaration with
6251         multidictionary.
6252         (dict_create_hashed, dict_create_hashed_expandable)
6253         (dict_create_linear, dict_create_linear_expandable)
6254         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6255         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6256         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6257         taking multidictionary argument.
6258         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6259         * block.h (struct block) <dict>: Change to multidictionary
6260         and rename `multidict'.
6261         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6262         symmisc.c: Update all dictionary references to multidictionary.
6263
6264 2019-01-10  Keith Seitz  <keiths@redhat.com>
6265
6266         PR gdb/23712
6267         PR symtab/23010
6268         * dictionary.c: Include unordered_map.
6269         (pending_to_vector): New function.
6270         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6271         Rewrite the non-"_1" functions to take vector instead
6272         of linked list.
6273         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6274         "new" _1 versions of the same name.
6275         (multidictionary): Define.
6276         (std::hash<enum language): New definition.
6277         (collate_pending_symbols_by_language, mdict_create_hashed)
6278         (mdict_create_hashed_expandable, mdict_create_linear)
6279         (mdict_create_linear_expandable, mdict_free)
6280         (find_language_dictionary, create_new_language_dictionary)
6281         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6282         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6283         (mdict_size, mdict_empty): New functions.
6284         * dictionary.h (mdict_iterator): Define.
6285
6286 2019-01-10  Pedro Alves  <palves@redhat.com>
6287
6288         * breakpoint.c (read_uploaded_action)
6289         (create_tracepoint_from_upload): Adjust to use
6290         gdb::unique_xmalloc_ptr.
6291         * ctf.c (ctf_write_uploaded_tp):
6292         (SET_ARRAY_FIELD): Use emplace_back.
6293         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6294         * tracefile-tfile.c (tfile_write_uploaded_tp):
6295         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6296         gdb::unique_xmalloc_ptr.
6297         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6298         at_string, cond_string, cmd_strings>: Replace char pointers
6299         with gdb::unique_xmalloc_ptr.
6300
6301 2019-01-10  Pedro Alves  <palves@redhat.com>
6302
6303         * solib-target.c (library_list_start_library): Don't xstrdup name.
6304
6305 2019-01-10  Pedro Alves  <palves@redhat.com>
6306
6307         * mdebugread.c (parse_partial_symbols): Use
6308         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6309
6310 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6311
6312         * linux-fork.c (scoped_switch_fork_info)
6313         <~scoped_switch_fork_info>: Fix incorrect variable name.
6314
6315 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6316
6317         * linux-fork.c (scoped_switch_fork_info)
6318         <scoped_switch_fork_info>: Make explicit.
6319         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6320
6321 2019-01-10  Tom Tromey  <tom@tromey.com>
6322
6323         * objfiles.h (objfile::reset_psymtabs): Update.
6324         * objfiles.c (objfile::objfile): Update.
6325         * psymtab.h (psymtab_storage::obstack): Update.
6326         (psymtab_storage::m_obstack): Use gdb::optional.
6327         (class psymtab_storage): Update comment.  Remove objfile
6328         parameter.
6329         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6330
6331 2019-01-10  Tom Tromey  <tom@tromey.com>
6332
6333         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6334         <free_psymtabs>: Now private.
6335         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6336         (allocate_psymtab): Use new method.
6337
6338 2019-01-10  Tom Tromey  <tom@tromey.com>
6339
6340         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6341         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6342         * mdebugread.c (parse_partial_symbols): Use
6343         allocate_dependencies.
6344         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6345         allocate_dependencies.
6346         (process_psymtab_comp_unit_reader)
6347         (build_type_psymtab_dependencies): Likewise.
6348         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6349
6350 2019-01-10  Tom Tromey  <tom@tromey.com>
6351
6352         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6353         PSYMBOL_SET_LANGUAGE.
6354         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6355
6356 2019-01-10  Tom Tromey  <tom@tromey.com>
6357
6358         * psymtab.h (psymtab_storage::obstack): New method.
6359         <m_obstack>: Rename from obstack; now private.
6360         * psymtab.c (psymtab_storage): Update.
6361         * dwarf2read.c (create_addrmap_from_index)
6362         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6363         Update.
6364
6365 2019-01-10  Tom Tromey  <tom@tromey.com>
6366
6367         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6368         * objfiles.h (objfile::reset_psymtabs): New method.
6369
6370 2019-01-10  Tom Tromey  <tom@tromey.com>
6371
6372         * symmisc.c (print_symbol_bcache_statistics): Update.
6373         (print_objfile_statistics): Update.
6374         * symfile.c (reread_symbols): Update.
6375         * psymtab.h (class psymtab_storage): New.
6376         * psymtab.c (psymtab_storage): New constructor.
6377         (~psymtab_storage): New destructor.
6378         (require_partial_symbols): Update.
6379         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6380         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6381         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6382         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6383         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6384         (start_psymtab_common, end_psymtab_common)
6385         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6386         (allocate_psymtab): Update.
6387         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6388         Update.
6389         (dump_psymtab_addrmap, maintenance_print_psymbols)
6390         (maintenance_check_psymtabs): Update.
6391         (class objfile_psymtabs): Move to objfiles.h.
6392         * psympriv.h (discard_psymtab): Now inline.
6393         (psymtab_discarder::psymtab_discarder): Update.
6394         (psymtab_discarder::~psymtab_discarder): Update.
6395         (ALL_OBJFILE_PSYMTABS): Rewrite.
6396         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6397         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6398         Remove fields.
6399         <partial_symtabs>: New field.
6400         (class objfile_psymtabs): Move from psymtab.h.  Update.
6401         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6402         psymbol_cache.
6403         (objfile::~objfile): Don't destroy psymbol_cache.
6404         * mdebugread.c (parse_partial_symbols): Update.
6405         * dwarf2read.c (create_addrmap_from_index)
6406         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6407         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6408         (add_partial_subprogram, dwarf2_ranges_read): Update.
6409         * dwarf-index-write.c (write_address_map)
6410         (write_one_signatured_type, recursively_write_psymbols)
6411         (class debug_names, class debug_names, write_psymtabs_to_index):
6412         Update.
6413
6414 2019-01-10  Tom Tromey  <tom@tromey.com>
6415
6416         * symtab.h (SYMBOL_SET_NAMES): Update.
6417         (symbol_set_names): Update.
6418         (MSYMBOL_SET_NAMES): Update.
6419         * symtab.c (symbol_set_names): Change argument to be an
6420         objfile_per_bfd_storage.
6421         * psymtab.c (add_psymbol_to_bcache): Update.
6422         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6423
6424 2019-01-10  Tom Tromey  <tom@tromey.com>
6425
6426         * symtab.c (create_demangled_names_hash): Change argument to be an
6427         objfile_per_bfd_storage.
6428         (symbol_set_names): Update.
6429
6430 2019-01-10  Tom Tromey  <tom@tromey.com>
6431
6432         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6433         init_psymbol_list.
6434         * psymtab.c (init_psymbol_list): Do nothing if already called.
6435         * psympriv.h (init_psymbol_list): Add comment.
6436         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6437         init_psymbol_list.
6438         * dbxread.c (dbx_symfile_read): Unconditionally call
6439         init_psymbol_list.
6440
6441 2019-01-10  Tom Tromey  <tom@tromey.com>
6442
6443         * xcoffread.c (scan_xcoff_symtab): Update.
6444         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6445         "where".
6446         * mdebugread.c (parse_partial_symbols)
6447         (handle_psymbol_enumerators): Update.
6448         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6449         * dbxread.c (read_dbx_symtab): Update.
6450         * psympriv.h (psymbol_placement): New enum.
6451         (add_psymbol_to_list): Update.
6452
6453 2019-01-10  Tom Tromey  <tom@tromey.com>
6454
6455         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6456         static_psymbols parameters.
6457         (scan_xcoff_symtab): Update.
6458         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6459         static_psymbols parameters.
6460         * psympriv.h (start_psymtab_common): Update.
6461         * mdebugread.c (parse_partial_symbols): Update.
6462         * dwarf2read.c (create_partial_symtab): Update.
6463         * dbxread.c (read_dbx_symtab): Update.
6464         (start_psymtab): Remove global_psymbols and static_psymbols
6465         parameters.
6466
6467 2019-01-10  Tom Tromey  <tom@tromey.com>
6468
6469         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6470         * psymtab.c (allocate_psymtab): Add comment.
6471         * psympriv.h (allocate_psymtab): Add comment.
6472         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6473         initializations.
6474         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6475
6476 2019-01-10  Tom Tromey  <tom@tromey.com>
6477
6478         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6479         Don't declare.
6480         * mipsread.c: Include mdebugread.h.
6481         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6482         Declare.
6483         * elfread.c: Include mdebugread.h.
6484
6485 2019-01-09  Tom Tromey  <tom@tromey.com>
6486
6487         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6488         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6489         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6490         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6491         (psym_lookup_symbol, psym_find_last_source_symtab)
6492         (psym_forget_cached_source_info, psym_print_stats)
6493         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6494         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6495         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6496         (psym_find_compunit_symtab_by_address)
6497         (maintenance_print_psymbols, maintenance_info_psymtabs)
6498         (maintenance_check_psymtabs): Use ranged for.
6499         * psymtab.h (class objfile_psymtabs): New.
6500         (require_partial_symbols): Return objfile_psymtabs.
6501         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6502
6503 2019-01-09  Tom Tromey  <tom@tromey.com>
6504
6505         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6506         (find_pc_mapped_section, list_overlays_command)
6507         (map_overlay_command, unmap_overlay_command)
6508         (simple_overlay_update): Use all_objfiles.
6509         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6510         * printcmd.c (info_symbol_command): Use all_objfiles.
6511         * objfiles.h (ALL_OBJSECTIONS): Remove.
6512         * maint.c (maintenance_translate_address): Use all_objfiles.
6513         * gcore.c (gcore_create_callback): Use all_objfiles.
6514         (objfile_find_memory_regions): Likewise.
6515
6516 2019-01-09  Tom Tromey  <tom@tromey.com>
6517
6518         * symtab.c (find_line_symtab, info_sources_command)
6519         (make_source_files_completion_list): Use objfile_compunits.
6520         * source.c (select_source_symtab): Use objfile_compunits.
6521         * objfiles.h (struct objfile): Update comment.
6522         (ALL_OBJFILES): Remove.
6523         (ALL_FILETABS): Remove.
6524         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6525         objfile_compunits.
6526
6527 2019-01-09  Tom Tromey  <tom@tromey.com>
6528
6529         * symmisc.c (print_objfile_statistics, dump_objfile)
6530         (maintenance_print_symbols): Use compunit_filetabs.
6531         * source.c (forget_cached_source_info_for_objfile): Use
6532         compunit_filetabs.
6533         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6534         (ALL_FILETABS): Use compunit_filetabs.
6535         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6536         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6537
6538 2019-01-09  Tom Tromey  <tom@tromey.com>
6539
6540         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6541         (compunit_filetabs): New.
6542         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6543         compunit_filetabs.
6544         (info_sources_command, make_source_files_completion_list): Remove
6545         declaration.
6546         * symmisc.c (print_objfile_statistics, dump_objfile)
6547         (maintenance_print_symbols): Remove declaration.
6548         (maintenance_info_symtabs): Use compunit_filetabs.
6549         (maintenance_info_line_tables): Likewise.
6550         * source.c (select_source_symtab): Change local variable name.
6551         (forget_cached_source_info_for_objfile): Remove declaration.
6552         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6553         * objfiles.c (objfile_relocate1): Remove declaration.
6554         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6555         declaration.
6556         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6557         * coffread.c (coff_symtab_read): Remove declaration.
6558         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6559         compunit_filetabs.
6560
6561 2019-01-09  Tom Tromey  <tom@tromey.com>
6562
6563         * symtab.c (lookup_objfile_from_block)
6564         (find_pc_sect_compunit_symtab, search_symbols)
6565         (default_collect_symbol_completion_matches_break_on): Use
6566         objfile_compunits.
6567         * objfiles.h (ALL_COMPUNITS): Remove.
6568         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6569         * cp-support.c (add_symbol_overload_list_qualified): Use
6570         objfile_compunits.
6571         * ada-lang.c (ada_collect_symbol_completion_matches)
6572         (ada_add_global_exceptions): Use objfile_compunits.
6573
6574 2019-01-09  Tom Tromey  <tom@tromey.com>
6575
6576         * source.c (select_source_symtab)
6577         (forget_cached_source_info_for_objfile): Remove declaration.
6578         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6579         declaration.
6580         * maint.c (count_symtabs_and_blocks): Remove declaration.
6581         * cp-support.c (add_symbol_overload_list_qualified): Remove
6582         declaration.
6583         * coffread.c (coff_symtab_read): Remove declaration.
6584         * symtab.c (lookup_symbol_in_objfile_symtabs)
6585         (basic_lookup_transparent_type_1): Use objfile_compunits.
6586         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6587         (info_sources_command, search_symbols)
6588         (default_collect_symbol_completion_matches_break_on)
6589         (make_source_files_completion_list): Remove declaration.
6590         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6591         (ada_collect_symbol_completion_matches)
6592         (ada_add_global_exceptions): Remove declaration.
6593         * linespec.c (iterate_over_all_matching_symtabs): Use
6594         objfile_compunits.
6595         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6596         (class objfile_compunits): New.
6597         (ALL_COMPUNITS): Use objfile_compunits.
6598         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6599         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6600         objfile_compunits.
6601         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6602
6603 2019-01-09  Tom Tromey  <tom@tromey.com>
6604
6605         * symtab.c (search_symbols)
6606         (default_collect_symbol_completion_matches_break_on): Use
6607         objfile_msymbols.
6608         * ada-lang.c (ada_lookup_simple_minsym)
6609         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6610         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6611         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6612         objfile_msymbols.
6613         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6614         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6615         * objc-lang.c (find_methods): Use objfile_msymbols.
6616         (info_selectors_command, info_classes_command): Likewise.
6617         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6618         * objfiles.h (class objfile_msymbols): New.
6619         (ALL_OBJFILE_MSYMBOLS): Remove.
6620         (ALL_MSYMBOLS): Remove.
6621
6622 2019-01-09  Tom Tromey  <tom@tromey.com>
6623
6624         * common/next-iterator.h (next_adapter): Add Iterator template
6625         parameter.
6626         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6627         (class all_objfiles_safe): New.
6628         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6629         * objfiles.c (put_objfile_before): Update comment.
6630         (add_separate_debug_objfile): Likewise.
6631         (free_all_objfiles): Use all_objfiles_safe.
6632         (objfile_purge_solibs): Likewise.
6633
6634 2019-01-09  Tom Tromey  <tom@tromey.com>
6635
6636         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6637         (expand_symtab_containing_pc, lookup_static_symbol)
6638         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6639         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6640         all_objfiles.
6641         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6642         * breakpoint.c (create_overlay_event_breakpoint)
6643         (create_longjmp_master_breakpoint)
6644         (create_std_terminate_master_breakpoint)
6645         (create_exception_master_breakpoint): Use all_objfiles.
6646         * linux-thread-db.c (try_thread_db_load_from_pdir)
6647         (has_libpthread): Use all_objfiles.
6648         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6649         * linespec.c (iterate_over_all_matching_symtabs)
6650         (search_minsyms_for_name): Use all_objfiles.
6651         * maint.c (maintenance_info_sections): Use all_objfiles.
6652         * main.c (captured_main_1): Use all_objfiles.
6653         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6654         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6655         * guile/scm-pretty-print.c
6656         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6657         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6658         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6659         (maintenance_print_msymbols): Use all_objfiles.
6660         * source.c (select_source_symtab): Use all_objfiles.
6661         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6662         * symfile.c (remove_symbol_file_command)
6663         (expand_symtabs_matching, map_symbol_filenames): Use
6664         all_objfiles.
6665         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6666         all_objfiles.
6667         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6668         * objc-lang.c (find_methods): Use all_objfiles.
6669         * objfiles.c (have_partial_symbols, have_full_symbols)
6670         (have_minimal_symbols, qsort_cmp)
6671         (default_iterate_over_objfiles_in_search_order): Use
6672         all_objfiles.
6673         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6674         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6675         (maintenance_check_psymtabs): Use all_objfiles.
6676         (ALL_PSYMTABS): Remove.
6677         * compile/compile-object-run.c (do_module_cleanup): Use
6678         all_objfiles.
6679         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6680         * cp-support.c (add_symbol_overload_list_qualified): Use
6681         all_objfiles.
6682         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6683         Use all_objfiles.
6684         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6685         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6686         all_objfiles.
6687         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6688         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6689         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6690         Uses all_objfiles.
6691         * solib.c (solib_read_symbols): Use all_objfiles
6692
6693 2019-01-09  Tom Tromey  <tom@tromey.com>
6694
6695         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6696         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6697         all_objfiles.
6698         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6699         * symmisc.c (print_symbol_bcache_statistics)
6700         (print_objfile_statistics, maintenance_print_objfiles)
6701         (maintenance_info_symtabs, maintenance_check_symtabs)
6702         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6703         all_objfiles.
6704         * source.c (forget_cached_source_info): Use all_objfiles.
6705         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6706         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6707         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6708         * objfiles.c (update_section_map): Use all_objfiles.
6709         (shared_objfile_contains_address_p): Likewise.
6710         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6711         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6712
6713 2019-01-09  Tom Tromey  <tom@tromey.com>
6714
6715         * common/next-iterator.h: New file.
6716         * objfiles.h (class all_objfiles): New.
6717         (struct objfile_iterator): New.
6718
6719 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6720
6721         * NEWS: Move the description of the changed "frame", "select-frame",
6722          and "info frame" commands to the Changed commands section.
6723
6724 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6725
6726         * gdbtypes.c (check_stub_method_group): Remove handling of old
6727         mangling schemes.
6728         * linespec.c (find_methods): Likewise.
6729         * stabsread.c (read_member_functions): Likewise.
6730         * valops.c (search_struct_method): Likewise.
6731         (value_struct_elt_for_reference): Likewise.
6732         * NEWS: Mention this change.
6733
6734 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6735
6736         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6737         print_source_lines.
6738         * source.c (print_source_lines_base): Update line number check.
6739         (print_source_lines): New function.
6740         (source_lines_range::source_lines_range): New function.
6741         * source.h (class source_lines_range): New class.
6742         (print_source_lines): New declaration.
6743
6744 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6745
6746         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6747
6748 2019-01-08  Tom Tromey  <tom@tromey.com>
6749             Simon Marchi  <simon.marchi@ericsson.com>
6750
6751         PR gdb/24060
6752         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6753         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6754         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6755         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6756         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6757         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6758
6759 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6760
6761         * source.c (select_source_symtab): Move header comment to
6762         declaration in source.h.
6763         (forget_cached_source_info_for_objfile): Likewise.
6764         (forget_cached_source_info): Likewise.
6765         (identify_source_line): Likewise.
6766         * source.h (identify_source_line): Move declaration from symtab.h
6767         and add comment from source.c
6768         (print_source_lines): Likewise.
6769         (forget_cached_source_info_for_objfile): Likewise.
6770         (forget_cached_source_info): Likewise.
6771         (select_source_symtab): Likewise.
6772         (enum print_source_lines_flag): Move definition from symtab.h.
6773         * symtab.h (identify_source_line): Move declaration to source.h.
6774         (print_source_lines): Likewise.
6775         (forget_cached_source_info_for_objfile): Likewise.
6776         (forget_cached_source_info): Likewise.
6777         (select_source_symtab): Likewise.
6778         (enum print_source_lines_flag): Move definition to source.h.
6779         * tui/tui-hooks.c: Add 'source.h' include.
6780
6781 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6782
6783         * source.c (print_source_lines_base): Handle requests to print
6784         reverse line number sequences, and guard against empty lines
6785         string.
6786
6787 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6788
6789         * source.c (print_source_lines_base): Fix skip of '\r' if next
6790         character is '\n'.
6791
6792 2019-01-06  Tom Tromey  <tom@tromey.com>
6793
6794         * c-exp.y (struct c_parse_state) <macro_original_text,
6795         expansion_obstack>: New member.
6796         (macro_original_text, expansion_obstack): Remove globals.
6797         (scan_macro_expansion, scanning_macro_expansion)
6798         (finished_macro_expansion): Update.
6799         (scan_macro_cleanup): Remove.
6800         (yylex, c_parse): Update.
6801
6802 2019-01-06  Tom Tromey  <tom@tromey.com>
6803
6804         * c-exp.y (struct c_parse_state) <strings>: New member.
6805         (operator_stoken): Update.
6806
6807 2019-01-06  Tom Tromey  <tom@tromey.com>
6808
6809         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6810         (union type_stack_elt) <typelist_val>: Now a pointer to
6811         std::vector.
6812         (type_stack_cleanup): Don't declare.
6813         (push_typelist): Update.
6814         * parse.c (pop_typelist): Return a std::vector.
6815         (push_typelist): Take a std::vector.
6816         (follow_types): Update.  Do not free args.
6817         (type_stack_cleanup): Remove.
6818         * c-exp.y (struct c_parse_state): New.
6819         (cpstate): New global.
6820         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6821         (nonempty_typelist): Update.
6822         (func_mod): Create a new vector.
6823         (c_parse): Create a c_parse_state.
6824         (check_parameter_typelist): Do not delete params.
6825         (function_method): Update.  Do not delete type_list.
6826
6827 2019-01-06  Tom Tromey  <tom@tromey.com>
6828
6829         PR gdb/28155:
6830         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6831         check_typedef.
6832         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6833         (print_return_value): Likewise.
6834
6835 2019-01-05  Tom Tromey  <tom@tromey.com>
6836
6837         * contrib/cleanup_check.py: Remove.
6838         * contrib/gcc-with-excheck: Remove.
6839         * contrib/exsummary.py: Remove.
6840         * contrib/excheck.py: Remove.
6841
6842 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6843
6844         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6845         NULL. Initialize tpprev to NULL instead of assigning it
6846         to NULL on the next statement.
6847         * windows-nat.c (windows_delete_thread): Remove check for
6848         main_thread_id before printing thread exit notifications.
6849         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6850         Remove thread ID check against main_thread_id.
6851         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6852         windows_delete_thread.
6853         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6854
6855 2019-01-04  Tom Tromey  <tom@tromey.com>
6856
6857         * compile/compile.c (_initialize_compile): Use upper case for
6858         metasyntactic variables.
6859         * symmisc.c (_initialize_symmisc): Use upper case for
6860         metasyntactic variables.
6861         * psymtab.c (_initialize_psymtab): Use upper case for
6862         metasyntactic variables.
6863         * demangle.c (demangle_command): Use upper case for metasyntactic
6864         variables.
6865         (_initialize_demangler): Likewise.
6866         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6867         variables.
6868
6869 2019-01-03  Tom Tromey  <tom@tromey.com>
6870
6871         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6872
6873 2019-01-03  Tom Tromey  <tom@tromey.com>
6874
6875         * python/py-symtab.c (salpy_str): Update.
6876         (struct salpy_sal_object) <symtab>: Now a PyObject.
6877         (salpy_dealloc): Update.
6878         (del_objfile_sal): Use gdbpy_ref.
6879
6880 2019-01-03  Tom Tromey  <tom@tromey.com>
6881
6882         * python/py-type.c (convert_field): Use new_reference.  Return
6883         gdbpy_ref.
6884         (make_fielditem): Return gdbpy_ref.
6885         (typy_fields): Update.
6886         (typy_getitem): Update.
6887         (field_name): Return gdbpy_ref.  Use new_reference.
6888         (typy_iterator_iternext): Update.
6889
6890 2019-01-03  Tom Tromey  <tom@tromey.com>
6891
6892         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6893
6894 2019-01-03  Tom Tromey  <tom@tromey.com>
6895
6896         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6897         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6898         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6899         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6900         (pspy_set_type_printers): Likewise.
6901         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6902         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6903         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6904         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6905         (objfpy_set_type_printers): Likewise.
6906
6907 2019-01-03  Tom Tromey  <tom@tromey.com>
6908
6909         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6910         (gdbpy_print_stack): Use gdbpy_err_fetch.
6911         * python/python-internal.h (class gdbpy_err_fetch): New class.
6912         (class gdbpy_enter) <m_error_type, m_error_value,
6913         m_error_traceback>: Remove.
6914         <m_error>: New member.
6915         (gdbpy_exception_to_string): Don't declare.
6916         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6917         * python/py-value.c (convert_value_from_python): Use
6918         gdbpy_err_fetch.
6919         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6920         gdbpy_exception_to_string.
6921         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6922         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6923         gdbpy_err_fetch.
6924
6925 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6926
6927         * linux-nat.c (delete_lwp_cleanup): Delete.
6928         (struct lwp_deleter): New struct.
6929         (lwp_info_up): New typedef.
6930         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6931         lwp_info_up.
6932
6933 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6934
6935         * linux-fork.c (class scoped_switch_fork_info): New class.
6936         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6937
6938 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6939
6940         * valops.c (find_overload_match): Remove use of null_cleanup, and
6941         calls to do_cleanups.
6942
6943 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6944
6945         * compile/compile-cplus-types.c
6946         (compile_cplus_instance::decl_name): Handle changes to
6947         cp_func_name.
6948         * cp-support.c (cp_func_name): Update header comment, update
6949         return type.
6950         * cp-support.h (cp_func_name): Update return type in declaration.
6951         * valops.c (find_overload_match): Move temp_func local to top
6952         level of function and change its type.  Use temp_func to hold and
6953         delete temporary string obtained from cp_func_name.
6954
6955 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6956
6957         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6958         gdb::char_vector, remove cleanup, and update uses of `msg`.
6959
6960 2019-01-03  Jim Wilson  <jimw@sifive.com>
6961
6962         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6963
6964 2019-01-02  Tom Tromey  <tom@tromey.com>
6965
6966         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6967         (tdesc_parse_xml): Remove cleanups.
6968         * target-descriptions.h (make_cleanup_free_target_description):
6969         Don't declare.
6970         (target_desc_deleter): New struct.
6971         (target_desc_up): New typedef.
6972         * target-descriptions.c (target_desc_deleter::operator()): Rename
6973         from free_target_description.
6974         (make_cleanup_free_target_description): Remove.
6975
6976 2019-01-02  Tom Tromey  <tom@tromey.com>
6977
6978         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6979         constructor, destructor.
6980         (linespec_parser): Remove typedef.
6981         (~linespec_parser): Rename from linespec_parser_delete.
6982         (linespec_lex_to_end, linespec_complete_label)
6983         (linespec_complete): Update.
6984         (decode_line_full): Remove cleanups.
6985         (decode_line_1): Update.
6986
6987 2019-01-02  Tom Tromey  <tom@tromey.com>
6988
6989         * python/python-internal.h (inferior_to_inferior_object): Change
6990         return type.
6991         * python/py-exitedevent.c (create_exited_event_object): Update.
6992         * python/py-inferior.c (inferior_to_inferior_object): Return
6993         gdbpy_ref.
6994         (python_new_inferior, python_inferior_deleted)
6995         (thread_to_thread_object, delete_thread_object)
6996         (build_inferior_list, gdbpy_selected_inferior): Update.
6997         * python/py-infthread.c (create_thread_object): Update.  Also fail
6998         if inferior_to_inferior_object fails.
6999
7000 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7001
7002         * inferior.h (class inferior) <displaced_step_state>: New field.
7003         * infrun.h (struct displaced_step_state): Move here from
7004         infrun.c.  Initialize fields, add constructor.
7005         <inf>: Remove field.
7006         <reset>: New method.
7007         * infrun.c (struct displaced_step_inferior_state): Move to
7008         infrun.h.
7009         (displaced_step_inferior_states): Remove.
7010         (get_displaced_stepping_state): Adust.
7011         (displaced_step_in_progress_any_inferior): Adjust.
7012         (displaced_step_in_progress_thread): Adjust.
7013         (displaced_step_in_progress): Adjust.
7014         (add_displaced_stepping_state): Remove.
7015         (get_displaced_step_closure_by_addr): Adjust.
7016         (remove_displaced_stepping_state): Remove.
7017         (infrun_inferior_exit): Call displaced_step_state.reset.
7018         (use_displaced_stepping): Don't check for NULL.
7019         (displaced_step_prepare_throw): Call
7020         get_displaced_stepping_state.
7021         (displaced_step_fixup): Don't check for NULL.
7022         (prepare_for_detach): Don't check for NULL.
7023
7024 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7025
7026         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7027          in case of call that did not complete.
7028
7029 2019-01-02  Andrey Utkin  <autkin@undo.io>
7030
7031         * symfile.c (find_separate_debug_file): Fix search of debug files for
7032         remote debuggee.
7033
7034 2019-01-02  Tom Tromey  <tom@tromey.com>
7035
7036         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7037         indentation.
7038         * python/py-frame.c (frapy_older): Remove cast.
7039         (frapy_newer): Likewise.
7040         * python/py-breakpoint.c (local_setattro): Remove cast.
7041         * python/py-arch.c (archpy_name): Remove local variable.
7042         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7043
7044 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7045
7046         * unittests/basic_string_view/element_access/char/empty.cc:
7047         Fix year range in copyright header.
7048
7049 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7050
7051         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7052         Delete.
7053         <operator==>: Update with for removed field.
7054         <hash>: Likewise.
7055         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7056         <isa_features>: ...this.
7057         <abi_features>: New field.
7058         (riscv_isa_flen): Update comment.
7059         (riscv_abi_xlen): New declaration.
7060         (riscv_abi_flen): New declaration.
7061         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7062         isa_features.
7063         (riscv_abi_xlen): New function.
7064         (riscv_isa_flen): Update to get answer from isa_features.
7065         (riscv_abi_flen): New function.
7066         (riscv_has_fp_abi): Update to get answer from abi_features.
7067         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7068         xlen and flen.
7069         (riscv_call_info) <xlen, flen>: Update comment.
7070         (riscv_call_arg_struct): Remove invalid assertions
7071         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7072         is removed.
7073         (riscv_gdbarch_init): Gather isa features and abi features
7074         separately, ensure both match on the gdbarch when reusing an old
7075         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7076         a target with 64-bit float hardware.
7077
7078 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7079
7080         * source.c (search_command_helper): Stop reverse search
7081         when line 1 has been searched.
7082
7083 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7084
7085         * record-full.c (record_full_base_target::close): Rewrite
7086         record_full_core_buf_list free logic.
7087
7088 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7089
7090         * break-catch-syscall.c (print_one_catch_syscall): xfree
7091         the last text.
7092
7093 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7094
7095         * top.c (print_gdb_version): Update Copyright year in version
7096         message.
7097
7098 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7099
7100         Update copyright year range in all GDB files.
7101
7102 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7103
7104         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7105
7106 For older changes see ChangeLog-2018.
7107 \f
7108 Local Variables:
7109 mode: change-log
7110 left-margin: 8
7111 fill-column: 74
7112 version-control: never
7113 coding: utf-8
7114 End:
7115