1 // SPDX-License-Identifier: GPL-2.0
3 * Novatek NT39016 TFT LCD panel driver
5 * Copyright (C) 2017, Maarten ter Huurne <maarten@treewalker.org>
6 * Copyright (C) 2019, Paul Cercueil <paul@crapouillou.net>
9 #include <linux/delay.h>
10 #include <linux/device.h>
11 #include <linux/gpio/consumer.h>
12 #include <linux/media-bus-format.h>
13 #include <linux/module.h>
15 #include <linux/regmap.h>
16 #include <linux/regulator/consumer.h>
17 #include <linux/spi/spi.h>
19 #include <drm/drm_modes.h>
20 #include <drm/drm_panel.h>
27 NT39016_REG_SRC_TIMING_DELAY,
28 NT39016_REG_GATE_TIMING_DELAY,
30 NT39016_REG_INITIAL_FUNC,
32 NT39016_REG_BRIGHTNESS,
33 NT39016_REG_HUE_SATURATION,
34 NT39016_REG_RB_SUBCONTRAST,
35 NT39016_REG_R_SUBBRIGHTNESS,
36 NT39016_REG_B_SUBBRIGHTNESS,
42 NT39016_REG_VCOMDC_TRIM = 0x1e,
43 NT39016_REG_DISPLAY_MODE = 0x20,
46 #define NT39016_SYSTEM_RESET_N BIT(0)
47 #define NT39016_SYSTEM_STANDBY BIT(1)
49 struct nt39016_panel_info {
50 const struct drm_display_mode *display_modes;
51 unsigned int num_modes;
52 u16 width_mm, height_mm;
53 u32 bus_format, bus_flags;
57 struct drm_panel drm_panel;
59 struct regulator *supply;
60 const struct nt39016_panel_info *panel_info;
62 struct gpio_desc *reset_gpio;
65 static inline struct nt39016 *to_nt39016(struct drm_panel *panel)
67 return container_of(panel, struct nt39016, drm_panel);
70 #define RV(REG, VAL) { .reg = (REG), .def = (VAL), .delay_us = 2 }
71 static const struct reg_sequence nt39016_panel_regs[] = {
72 RV(NT39016_REG_SYSTEM, 0x00),
73 RV(NT39016_REG_TIMING, 0x00),
74 RV(NT39016_REG_OP, 0x03),
75 RV(NT39016_REG_DATA_IN, 0xCC),
76 RV(NT39016_REG_SRC_TIMING_DELAY, 0x46),
77 RV(NT39016_REG_GATE_TIMING_DELAY, 0x05),
78 RV(NT39016_REG_RESERVED, 0x00),
79 RV(NT39016_REG_INITIAL_FUNC, 0x00),
80 RV(NT39016_REG_CONTRAST, 0x08),
81 RV(NT39016_REG_BRIGHTNESS, 0x40),
82 RV(NT39016_REG_HUE_SATURATION, 0x88),
83 RV(NT39016_REG_RB_SUBCONTRAST, 0x88),
84 RV(NT39016_REG_R_SUBBRIGHTNESS, 0x20),
85 RV(NT39016_REG_B_SUBBRIGHTNESS, 0x20),
86 RV(NT39016_REG_VCOMDC, 0x67),
87 RV(NT39016_REG_VCOMAC, 0xA4),
88 RV(NT39016_REG_VGAM2, 0x04),
89 RV(NT39016_REG_VGAM34, 0x24),
90 RV(NT39016_REG_VGAM56, 0x24),
91 RV(NT39016_REG_DISPLAY_MODE, 0x00),
96 static const struct regmap_range nt39016_regmap_no_ranges[] = {
97 regmap_reg_range(0x13, 0x1D),
98 regmap_reg_range(0x1F, 0x1F),
101 static const struct regmap_access_table nt39016_regmap_access_table = {
102 .no_ranges = nt39016_regmap_no_ranges,
103 .n_no_ranges = ARRAY_SIZE(nt39016_regmap_no_ranges),
106 static const struct regmap_config nt39016_regmap_config = {
111 .max_register = NT39016_REG_DISPLAY_MODE,
112 .wr_table = &nt39016_regmap_access_table,
113 .write_flag_mask = 0x02,
115 .cache_type = REGCACHE_FLAT,
118 static int nt39016_prepare(struct drm_panel *drm_panel)
120 struct nt39016 *panel = to_nt39016(drm_panel);
123 err = regulator_enable(panel->supply);
125 dev_err(drm_panel->dev, "Failed to enable power supply: %d\n", err);
131 * The documentation says the reset pulse should be at least 40 us to
132 * pass the glitch filter, but when testing I see some resets fail and
133 * some succeed when using a 70 us delay, so we use 100 us instead.
135 gpiod_set_value_cansleep(panel->reset_gpio, 1);
136 usleep_range(100, 1000);
137 gpiod_set_value_cansleep(panel->reset_gpio, 0);
140 /* Init all registers. */
141 err = regmap_multi_reg_write(panel->map, nt39016_panel_regs,
142 ARRAY_SIZE(nt39016_panel_regs));
144 dev_err(drm_panel->dev, "Failed to init registers: %d\n", err);
145 goto err_disable_regulator;
150 err_disable_regulator:
151 regulator_disable(panel->supply);
155 static int nt39016_unprepare(struct drm_panel *drm_panel)
157 struct nt39016 *panel = to_nt39016(drm_panel);
159 gpiod_set_value_cansleep(panel->reset_gpio, 1);
161 regulator_disable(panel->supply);
166 static int nt39016_enable(struct drm_panel *drm_panel)
168 struct nt39016 *panel = to_nt39016(drm_panel);
171 ret = regmap_write(panel->map, NT39016_REG_SYSTEM,
172 NT39016_SYSTEM_RESET_N | NT39016_SYSTEM_STANDBY);
174 dev_err(drm_panel->dev, "Unable to enable panel: %d\n", ret);
178 if (drm_panel->backlight) {
179 /* Wait for the picture to be ready before enabling backlight */
186 static int nt39016_disable(struct drm_panel *drm_panel)
188 struct nt39016 *panel = to_nt39016(drm_panel);
191 err = regmap_write(panel->map, NT39016_REG_SYSTEM,
192 NT39016_SYSTEM_RESET_N);
194 dev_err(drm_panel->dev, "Unable to disable panel: %d\n", err);
201 static int nt39016_get_modes(struct drm_panel *drm_panel,
202 struct drm_connector *connector)
204 struct nt39016 *panel = to_nt39016(drm_panel);
205 const struct nt39016_panel_info *panel_info = panel->panel_info;
206 struct drm_display_mode *mode;
209 for (i = 0; i < panel_info->num_modes; i++) {
210 mode = drm_mode_duplicate(connector->dev,
211 &panel_info->display_modes[i]);
215 drm_mode_set_name(mode);
217 mode->type = DRM_MODE_TYPE_DRIVER;
218 if (panel_info->num_modes == 1)
219 mode->type |= DRM_MODE_TYPE_PREFERRED;
221 drm_mode_probed_add(connector, mode);
224 connector->display_info.bpc = 8;
225 connector->display_info.width_mm = panel_info->width_mm;
226 connector->display_info.height_mm = panel_info->height_mm;
228 drm_display_info_set_bus_formats(&connector->display_info,
229 &panel_info->bus_format, 1);
230 connector->display_info.bus_flags = panel_info->bus_flags;
232 return panel_info->num_modes;
235 static const struct drm_panel_funcs nt39016_funcs = {
236 .prepare = nt39016_prepare,
237 .unprepare = nt39016_unprepare,
238 .enable = nt39016_enable,
239 .disable = nt39016_disable,
240 .get_modes = nt39016_get_modes,
243 static int nt39016_probe(struct spi_device *spi)
245 struct device *dev = &spi->dev;
246 struct nt39016 *panel;
249 panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL);
253 spi_set_drvdata(spi, panel);
255 panel->panel_info = of_device_get_match_data(dev);
256 if (!panel->panel_info)
259 panel->supply = devm_regulator_get(dev, "power");
260 if (IS_ERR(panel->supply))
261 return dev_err_probe(dev, PTR_ERR(panel->supply),
262 "Failed to get power supply\n");
264 panel->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
265 if (IS_ERR(panel->reset_gpio))
266 return dev_err_probe(dev, PTR_ERR(panel->reset_gpio), "Failed to get reset GPIO\n");
268 spi->bits_per_word = 8;
269 spi->mode = SPI_MODE_3 | SPI_3WIRE;
270 err = spi_setup(spi);
272 dev_err(dev, "Failed to setup SPI\n");
276 panel->map = devm_regmap_init_spi(spi, &nt39016_regmap_config);
277 if (IS_ERR(panel->map)) {
278 dev_err(dev, "Failed to init regmap\n");
279 return PTR_ERR(panel->map);
282 drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs,
283 DRM_MODE_CONNECTOR_DPI);
285 err = drm_panel_of_backlight(&panel->drm_panel);
287 return dev_err_probe(dev, err, "Failed to get backlight handle\n");
289 drm_panel_add(&panel->drm_panel);
294 static void nt39016_remove(struct spi_device *spi)
296 struct nt39016 *panel = spi_get_drvdata(spi);
298 drm_panel_remove(&panel->drm_panel);
300 nt39016_disable(&panel->drm_panel);
301 nt39016_unprepare(&panel->drm_panel);
304 static const struct drm_display_mode kd035g6_display_modes[] = {
308 .hsync_start = 320 + 10,
309 .hsync_end = 320 + 10 + 50,
310 .htotal = 320 + 10 + 50 + 20,
312 .vsync_start = 240 + 5,
313 .vsync_end = 240 + 5 + 1,
314 .vtotal = 240 + 5 + 1 + 4,
315 .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
320 .hsync_start = 320 + 42,
321 .hsync_end = 320 + 42 + 50,
322 .htotal = 320 + 42 + 50 + 20,
324 .vsync_start = 240 + 5,
325 .vsync_end = 240 + 5 + 1,
326 .vtotal = 240 + 5 + 1 + 4,
327 .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
331 static const struct nt39016_panel_info kd035g6_info = {
332 .display_modes = kd035g6_display_modes,
333 .num_modes = ARRAY_SIZE(kd035g6_display_modes),
336 .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
337 .bus_flags = DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE,
340 static const struct of_device_id nt39016_of_match[] = {
341 { .compatible = "kingdisplay,kd035g6-54nt", .data = &kd035g6_info },
344 MODULE_DEVICE_TABLE(of, nt39016_of_match);
346 static struct spi_driver nt39016_driver = {
349 .of_match_table = nt39016_of_match,
351 .probe = nt39016_probe,
352 .remove = nt39016_remove,
355 module_spi_driver(nt39016_driver);
357 MODULE_AUTHOR("Maarten ter Huurne <maarten@treewalker.org>");
358 MODULE_AUTHOR("Paul Cercueil <paul@crapouillou.net>");
359 MODULE_LICENSE("GPL v2");