1 // SPDX-License-Identifier: GPL-2.0-only
3 * Copyright (c) 2015, The Linux Foundation. All rights reserved.
9 #define DSI_CLOCK_MASTER DSI_0
10 #define DSI_CLOCK_SLAVE DSI_1
12 #define DSI_LEFT DSI_0
13 #define DSI_RIGHT DSI_1
15 /* According to the current drm framework sequence, take the encoder of
16 * DSI_1 as master encoder
18 #define DSI_ENCODER_MASTER DSI_1
19 #define DSI_ENCODER_SLAVE DSI_0
21 struct msm_dsi_manager {
22 struct msm_dsi *dsi[DSI_MAX];
26 int master_dsi_link_id;
29 static struct msm_dsi_manager msm_dsim_glb;
31 #define IS_DUAL_DSI() (msm_dsim_glb.is_dual_dsi)
32 #define IS_SYNC_NEEDED() (msm_dsim_glb.is_sync_needed)
33 #define IS_MASTER_DSI_LINK(id) (msm_dsim_glb.master_dsi_link_id == id)
35 static inline struct msm_dsi *dsi_mgr_get_dsi(int id)
37 return msm_dsim_glb.dsi[id];
40 static inline struct msm_dsi *dsi_mgr_get_other_dsi(int id)
42 return msm_dsim_glb.dsi[(id + 1) % DSI_MAX];
45 static int dsi_mgr_parse_dual_dsi(struct device_node *np, int id)
47 struct msm_dsi_manager *msm_dsim = &msm_dsim_glb;
49 /* We assume 2 dsi nodes have the same information of dual-dsi and
50 * sync-mode, and only one node specifies master in case of dual mode.
52 if (!msm_dsim->is_dual_dsi)
53 msm_dsim->is_dual_dsi = of_property_read_bool(
54 np, "qcom,dual-dsi-mode");
56 if (msm_dsim->is_dual_dsi) {
57 if (of_property_read_bool(np, "qcom,master-dsi"))
58 msm_dsim->master_dsi_link_id = id;
59 if (!msm_dsim->is_sync_needed)
60 msm_dsim->is_sync_needed = of_property_read_bool(
61 np, "qcom,sync-dual-dsi");
67 static int dsi_mgr_setup_components(int id)
69 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
70 struct msm_dsi *other_dsi = dsi_mgr_get_other_dsi(id);
71 struct msm_dsi *clk_master_dsi = dsi_mgr_get_dsi(DSI_CLOCK_MASTER);
72 struct msm_dsi *clk_slave_dsi = dsi_mgr_get_dsi(DSI_CLOCK_SLAVE);
73 struct msm_dsi_pll *src_pll;
77 ret = msm_dsi_host_register(msm_dsi->host, true);
81 msm_dsi_phy_set_usecase(msm_dsi->phy, MSM_DSI_PHY_STANDALONE);
82 src_pll = msm_dsi_phy_get_pll(msm_dsi->phy);
84 return PTR_ERR(src_pll);
85 ret = msm_dsi_host_set_src_pll(msm_dsi->host, src_pll);
86 } else if (!other_dsi) {
89 struct msm_dsi *master_link_dsi = IS_MASTER_DSI_LINK(id) ?
91 struct msm_dsi *slave_link_dsi = IS_MASTER_DSI_LINK(id) ?
93 /* Register slave host first, so that slave DSI device
94 * has a chance to probe, and do not block the master
96 * Also, do not check defer for the slave host,
97 * because only master DSI device adds the panel to global
98 * panel list. The panel's device is the master DSI device.
100 ret = msm_dsi_host_register(slave_link_dsi->host, false);
103 ret = msm_dsi_host_register(master_link_dsi->host, true);
107 /* PLL0 is to drive both 2 DSI link clocks in Dual DSI mode. */
108 msm_dsi_phy_set_usecase(clk_master_dsi->phy,
110 msm_dsi_phy_set_usecase(clk_slave_dsi->phy,
112 src_pll = msm_dsi_phy_get_pll(clk_master_dsi->phy);
114 return PTR_ERR(src_pll);
115 ret = msm_dsi_host_set_src_pll(msm_dsi->host, src_pll);
118 ret = msm_dsi_host_set_src_pll(other_dsi->host, src_pll);
124 static int enable_phy(struct msm_dsi *msm_dsi, int src_pll_id,
125 struct msm_dsi_phy_shared_timings *shared_timings)
127 struct msm_dsi_phy_clk_request clk_req;
129 bool is_dual_dsi = IS_DUAL_DSI();
131 msm_dsi_host_get_phy_clk_req(msm_dsi->host, &clk_req, is_dual_dsi);
133 ret = msm_dsi_phy_enable(msm_dsi->phy, src_pll_id, &clk_req);
134 msm_dsi_phy_get_shared_timings(msm_dsi->phy, shared_timings);
140 dsi_mgr_phy_enable(int id,
141 struct msm_dsi_phy_shared_timings shared_timings[DSI_MAX])
143 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
144 struct msm_dsi *mdsi = dsi_mgr_get_dsi(DSI_CLOCK_MASTER);
145 struct msm_dsi *sdsi = dsi_mgr_get_dsi(DSI_CLOCK_SLAVE);
146 int src_pll_id = IS_DUAL_DSI() ? DSI_CLOCK_MASTER : id;
149 /* In case of dual DSI, some registers in PHY1 have been programmed
150 * during PLL0 clock's set_rate. The PHY1 reset called by host1 here
151 * will silently reset those PHY1 registers. Therefore we need to reset
152 * and enable both PHYs before any PLL clock operation.
154 if (IS_DUAL_DSI() && mdsi && sdsi) {
155 if (!mdsi->phy_enabled && !sdsi->phy_enabled) {
156 msm_dsi_host_reset_phy(mdsi->host);
157 msm_dsi_host_reset_phy(sdsi->host);
159 ret = enable_phy(mdsi, src_pll_id,
160 &shared_timings[DSI_CLOCK_MASTER]);
163 ret = enable_phy(sdsi, src_pll_id,
164 &shared_timings[DSI_CLOCK_SLAVE]);
166 msm_dsi_phy_disable(mdsi->phy);
171 msm_dsi_host_reset_phy(msm_dsi->host);
172 ret = enable_phy(msm_dsi, src_pll_id, &shared_timings[id]);
177 msm_dsi->phy_enabled = true;
182 static void dsi_mgr_phy_disable(int id)
184 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
185 struct msm_dsi *mdsi = dsi_mgr_get_dsi(DSI_CLOCK_MASTER);
186 struct msm_dsi *sdsi = dsi_mgr_get_dsi(DSI_CLOCK_SLAVE);
189 * In dual-dsi configuration, the phy should be disabled for the
190 * first controller only when the second controller is disabled.
192 msm_dsi->phy_enabled = false;
193 if (IS_DUAL_DSI() && mdsi && sdsi) {
194 if (!mdsi->phy_enabled && !sdsi->phy_enabled) {
195 msm_dsi_phy_disable(sdsi->phy);
196 msm_dsi_phy_disable(mdsi->phy);
199 msm_dsi_phy_disable(msm_dsi->phy);
203 struct dsi_connector {
204 struct drm_connector base;
209 struct drm_bridge base;
213 #define to_dsi_connector(x) container_of(x, struct dsi_connector, base)
214 #define to_dsi_bridge(x) container_of(x, struct dsi_bridge, base)
216 static inline int dsi_mgr_connector_get_id(struct drm_connector *connector)
218 struct dsi_connector *dsi_connector = to_dsi_connector(connector);
219 return dsi_connector->id;
222 static int dsi_mgr_bridge_get_id(struct drm_bridge *bridge)
224 struct dsi_bridge *dsi_bridge = to_dsi_bridge(bridge);
225 return dsi_bridge->id;
228 static bool dsi_mgr_is_cmd_mode(struct msm_dsi *msm_dsi)
230 unsigned long host_flags = msm_dsi_host_get_mode_flags(msm_dsi->host);
231 return !(host_flags & MIPI_DSI_MODE_VIDEO);
234 void msm_dsi_manager_setup_encoder(int id)
236 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
237 struct msm_drm_private *priv = msm_dsi->dev->dev_private;
238 struct msm_kms *kms = priv->kms;
239 struct drm_encoder *encoder = msm_dsi_get_encoder(msm_dsi);
241 if (encoder && kms->funcs->set_encoder_mode)
242 kms->funcs->set_encoder_mode(kms, encoder,
243 dsi_mgr_is_cmd_mode(msm_dsi));
246 static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id)
248 struct msm_drm_private *priv = conn->dev->dev_private;
249 struct msm_kms *kms = priv->kms;
250 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
251 struct msm_dsi *other_dsi = dsi_mgr_get_other_dsi(id);
252 struct msm_dsi *master_dsi, *slave_dsi;
253 struct drm_panel *panel;
255 if (IS_DUAL_DSI() && !IS_MASTER_DSI_LINK(id)) {
256 master_dsi = other_dsi;
259 master_dsi = msm_dsi;
260 slave_dsi = other_dsi;
264 * There is only 1 panel in the global panel list for dual DSI mode.
265 * Therefore slave dsi should get the drm_panel instance from master
268 panel = msm_dsi_host_get_panel(master_dsi->host);
270 DRM_ERROR("Could not find panel for %u (%ld)\n", msm_dsi->id,
272 return PTR_ERR(panel);
275 if (!panel || !IS_DUAL_DSI())
278 drm_object_attach_property(&conn->base,
279 conn->dev->mode_config.tile_property, 0);
282 * Set split display info to kms once dual DSI panel is connected to
285 if (other_dsi && other_dsi->panel && kms->funcs->set_split_display) {
286 kms->funcs->set_split_display(kms, master_dsi->encoder,
288 dsi_mgr_is_cmd_mode(msm_dsi));
292 msm_dsi->panel = panel;
296 static enum drm_connector_status dsi_mgr_connector_detect(
297 struct drm_connector *connector, bool force)
299 int id = dsi_mgr_connector_get_id(connector);
300 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
302 return msm_dsi->panel ? connector_status_connected :
303 connector_status_disconnected;
306 static void dsi_mgr_connector_destroy(struct drm_connector *connector)
308 struct dsi_connector *dsi_connector = to_dsi_connector(connector);
312 drm_connector_cleanup(connector);
314 kfree(dsi_connector);
317 static int dsi_mgr_connector_get_modes(struct drm_connector *connector)
319 int id = dsi_mgr_connector_get_id(connector);
320 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
321 struct drm_panel *panel = msm_dsi->panel;
328 * In dual DSI mode, we have one connector that can be
329 * attached to the drm_panel.
331 drm_panel_attach(panel, connector);
332 num = drm_panel_get_modes(panel, connector);
339 static int dsi_mgr_connector_mode_valid(struct drm_connector *connector,
340 struct drm_display_mode *mode)
342 int id = dsi_mgr_connector_get_id(connector);
343 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
344 struct drm_encoder *encoder = msm_dsi_get_encoder(msm_dsi);
345 struct msm_drm_private *priv = connector->dev->dev_private;
346 struct msm_kms *kms = priv->kms;
347 long actual, requested;
350 requested = 1000 * mode->clock;
351 actual = kms->funcs->round_pixclk(kms, requested, encoder);
353 DBG("requested=%ld, actual=%ld", requested, actual);
354 if (actual != requested)
355 return MODE_CLOCK_RANGE;
360 static struct drm_encoder *
361 dsi_mgr_connector_best_encoder(struct drm_connector *connector)
363 int id = dsi_mgr_connector_get_id(connector);
364 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
367 return msm_dsi_get_encoder(msm_dsi);
370 static void dsi_mgr_bridge_pre_enable(struct drm_bridge *bridge)
372 int id = dsi_mgr_bridge_get_id(bridge);
373 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
374 struct msm_dsi *msm_dsi1 = dsi_mgr_get_dsi(DSI_1);
375 struct mipi_dsi_host *host = msm_dsi->host;
376 struct drm_panel *panel = msm_dsi->panel;
377 struct msm_dsi_phy_shared_timings phy_shared_timings[DSI_MAX];
378 bool is_dual_dsi = IS_DUAL_DSI();
382 if (!msm_dsi_device_connected(msm_dsi))
385 ret = dsi_mgr_phy_enable(id, phy_shared_timings);
389 /* Do nothing with the host if it is slave-DSI in case of dual DSI */
390 if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))
393 ret = msm_dsi_host_power_on(host, &phy_shared_timings[id], is_dual_dsi);
395 pr_err("%s: power on host %d failed, %d\n", __func__, id, ret);
399 if (is_dual_dsi && msm_dsi1) {
400 ret = msm_dsi_host_power_on(msm_dsi1->host,
401 &phy_shared_timings[DSI_1], is_dual_dsi);
403 pr_err("%s: power on host1 failed, %d\n",
409 /* Always call panel functions once, because even for dual panels,
410 * there is only one drm_panel instance.
413 ret = drm_panel_prepare(panel);
415 pr_err("%s: prepare panel %d failed, %d\n", __func__,
417 goto panel_prep_fail;
421 ret = msm_dsi_host_enable(host);
423 pr_err("%s: enable host %d failed, %d\n", __func__, id, ret);
427 if (is_dual_dsi && msm_dsi1) {
428 ret = msm_dsi_host_enable(msm_dsi1->host);
430 pr_err("%s: enable host1 failed, %d\n", __func__, ret);
436 ret = drm_panel_enable(panel);
438 pr_err("%s: enable panel %d failed, %d\n", __func__, id,
447 if (is_dual_dsi && msm_dsi1)
448 msm_dsi_host_disable(msm_dsi1->host);
450 msm_dsi_host_disable(host);
453 drm_panel_unprepare(panel);
455 if (is_dual_dsi && msm_dsi1)
456 msm_dsi_host_power_off(msm_dsi1->host);
458 msm_dsi_host_power_off(host);
460 dsi_mgr_phy_disable(id);
465 static void dsi_mgr_bridge_enable(struct drm_bridge *bridge)
470 static void dsi_mgr_bridge_disable(struct drm_bridge *bridge)
475 static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge)
477 int id = dsi_mgr_bridge_get_id(bridge);
478 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
479 struct msm_dsi *msm_dsi1 = dsi_mgr_get_dsi(DSI_1);
480 struct mipi_dsi_host *host = msm_dsi->host;
481 struct drm_panel *panel = msm_dsi->panel;
482 bool is_dual_dsi = IS_DUAL_DSI();
487 if (!msm_dsi_device_connected(msm_dsi))
491 * Do nothing with the host if it is slave-DSI in case of dual DSI.
492 * It is safe to call dsi_mgr_phy_disable() here because a single PHY
493 * won't be diabled until both PHYs request disable.
495 if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))
499 ret = drm_panel_disable(panel);
501 pr_err("%s: Panel %d OFF failed, %d\n", __func__, id,
505 ret = msm_dsi_host_disable(host);
507 pr_err("%s: host %d disable failed, %d\n", __func__, id, ret);
509 if (is_dual_dsi && msm_dsi1) {
510 ret = msm_dsi_host_disable(msm_dsi1->host);
512 pr_err("%s: host1 disable failed, %d\n", __func__, ret);
516 ret = drm_panel_unprepare(panel);
518 pr_err("%s: Panel %d unprepare failed,%d\n", __func__,
522 ret = msm_dsi_host_power_off(host);
524 pr_err("%s: host %d power off failed,%d\n", __func__, id, ret);
526 if (is_dual_dsi && msm_dsi1) {
527 ret = msm_dsi_host_power_off(msm_dsi1->host);
529 pr_err("%s: host1 power off failed, %d\n",
534 dsi_mgr_phy_disable(id);
537 static void dsi_mgr_bridge_mode_set(struct drm_bridge *bridge,
538 const struct drm_display_mode *mode,
539 const struct drm_display_mode *adjusted_mode)
541 int id = dsi_mgr_bridge_get_id(bridge);
542 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
543 struct msm_dsi *other_dsi = dsi_mgr_get_other_dsi(id);
544 struct mipi_dsi_host *host = msm_dsi->host;
545 bool is_dual_dsi = IS_DUAL_DSI();
547 DBG("set mode: " DRM_MODE_FMT, DRM_MODE_ARG(mode));
549 if (is_dual_dsi && !IS_MASTER_DSI_LINK(id))
552 msm_dsi_host_set_display_mode(host, adjusted_mode);
553 if (is_dual_dsi && other_dsi)
554 msm_dsi_host_set_display_mode(other_dsi->host, adjusted_mode);
557 static const struct drm_connector_funcs dsi_mgr_connector_funcs = {
558 .detect = dsi_mgr_connector_detect,
559 .fill_modes = drm_helper_probe_single_connector_modes,
560 .destroy = dsi_mgr_connector_destroy,
561 .reset = drm_atomic_helper_connector_reset,
562 .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
563 .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
566 static const struct drm_connector_helper_funcs dsi_mgr_conn_helper_funcs = {
567 .get_modes = dsi_mgr_connector_get_modes,
568 .mode_valid = dsi_mgr_connector_mode_valid,
569 .best_encoder = dsi_mgr_connector_best_encoder,
572 static const struct drm_bridge_funcs dsi_mgr_bridge_funcs = {
573 .pre_enable = dsi_mgr_bridge_pre_enable,
574 .enable = dsi_mgr_bridge_enable,
575 .disable = dsi_mgr_bridge_disable,
576 .post_disable = dsi_mgr_bridge_post_disable,
577 .mode_set = dsi_mgr_bridge_mode_set,
580 /* initialize connector when we're connected to a drm_panel */
581 struct drm_connector *msm_dsi_manager_connector_init(u8 id)
583 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
584 struct drm_connector *connector = NULL;
585 struct dsi_connector *dsi_connector;
588 dsi_connector = kzalloc(sizeof(*dsi_connector), GFP_KERNEL);
590 return ERR_PTR(-ENOMEM);
592 dsi_connector->id = id;
594 connector = &dsi_connector->base;
596 ret = drm_connector_init(msm_dsi->dev, connector,
597 &dsi_mgr_connector_funcs, DRM_MODE_CONNECTOR_DSI);
601 drm_connector_helper_add(connector, &dsi_mgr_conn_helper_funcs);
603 /* Enable HPD to let hpd event is handled
604 * when panel is attached to the host.
606 connector->polled = DRM_CONNECTOR_POLL_HPD;
608 /* Display driver doesn't support interlace now. */
609 connector->interlace_allowed = 0;
610 connector->doublescan_allowed = 0;
612 drm_connector_attach_encoder(connector, msm_dsi->encoder);
614 ret = msm_dsi_manager_panel_init(connector, id);
616 DRM_DEV_ERROR(msm_dsi->dev->dev, "init panel failed %d\n", ret);
623 connector->funcs->destroy(msm_dsi->connector);
627 bool msm_dsi_manager_validate_current_config(u8 id)
629 bool is_dual_dsi = IS_DUAL_DSI();
632 * For dual DSI, we only have one drm panel. For this
633 * use case, we register only one bridge/connector.
634 * Skip bridge/connector initialisation if it is
635 * slave-DSI for dual DSI configuration.
637 if (is_dual_dsi && !IS_MASTER_DSI_LINK(id)) {
638 DBG("Skip bridge registration for slave DSI->id: %d\n", id);
644 /* initialize bridge */
645 struct drm_bridge *msm_dsi_manager_bridge_init(u8 id)
647 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
648 struct drm_bridge *bridge = NULL;
649 struct dsi_bridge *dsi_bridge;
650 struct drm_encoder *encoder;
653 dsi_bridge = devm_kzalloc(msm_dsi->dev->dev,
654 sizeof(*dsi_bridge), GFP_KERNEL);
662 encoder = msm_dsi->encoder;
664 bridge = &dsi_bridge->base;
665 bridge->funcs = &dsi_mgr_bridge_funcs;
667 ret = drm_bridge_attach(encoder, bridge, NULL);
675 msm_dsi_manager_bridge_destroy(bridge);
680 struct drm_connector *msm_dsi_manager_ext_bridge_init(u8 id)
682 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
683 struct drm_device *dev = msm_dsi->dev;
684 struct drm_encoder *encoder;
685 struct drm_bridge *int_bridge, *ext_bridge;
686 struct drm_connector *connector;
687 struct list_head *connector_list;
689 int_bridge = msm_dsi->bridge;
690 ext_bridge = msm_dsi->external_bridge =
691 msm_dsi_host_get_bridge(msm_dsi->host);
693 encoder = msm_dsi->encoder;
695 /* link the internal dsi bridge to the external bridge */
696 drm_bridge_attach(encoder, ext_bridge, int_bridge);
699 * we need the drm_connector created by the external bridge
700 * driver (or someone else) to feed it to our driver's
701 * priv->connector[] list, mainly for msm_fbdev_init()
703 connector_list = &dev->mode_config.connector_list;
705 list_for_each_entry(connector, connector_list, head) {
706 if (drm_connector_has_possible_encoder(connector, encoder))
710 return ERR_PTR(-ENODEV);
713 void msm_dsi_manager_bridge_destroy(struct drm_bridge *bridge)
717 int msm_dsi_manager_cmd_xfer(int id, const struct mipi_dsi_msg *msg)
719 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
720 struct msm_dsi *msm_dsi0 = dsi_mgr_get_dsi(DSI_0);
721 struct mipi_dsi_host *host = msm_dsi->host;
722 bool is_read = (msg->rx_buf && msg->rx_len);
723 bool need_sync = (IS_SYNC_NEEDED() && !is_read);
726 if (!msg->tx_buf || !msg->tx_len)
729 /* In dual master case, panel requires the same commands sent to
730 * both DSI links. Host issues the command trigger to both links
731 * when DSI_1 calls the cmd transfer function, no matter it happens
732 * before or after DSI_0 cmd transfer.
734 if (need_sync && (id == DSI_0))
735 return is_read ? msg->rx_len : msg->tx_len;
737 if (need_sync && msm_dsi0) {
738 ret = msm_dsi_host_xfer_prepare(msm_dsi0->host, msg);
740 pr_err("%s: failed to prepare non-trigger host, %d\n",
745 ret = msm_dsi_host_xfer_prepare(host, msg);
747 pr_err("%s: failed to prepare host, %d\n", __func__, ret);
751 ret = is_read ? msm_dsi_host_cmd_rx(host, msg) :
752 msm_dsi_host_cmd_tx(host, msg);
754 msm_dsi_host_xfer_restore(host, msg);
757 if (need_sync && msm_dsi0)
758 msm_dsi_host_xfer_restore(msm_dsi0->host, msg);
763 bool msm_dsi_manager_cmd_xfer_trigger(int id, u32 dma_base, u32 len)
765 struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id);
766 struct msm_dsi *msm_dsi0 = dsi_mgr_get_dsi(DSI_0);
767 struct mipi_dsi_host *host = msm_dsi->host;
769 if (IS_SYNC_NEEDED() && (id == DSI_0))
772 if (IS_SYNC_NEEDED() && msm_dsi0)
773 msm_dsi_host_cmd_xfer_commit(msm_dsi0->host, dma_base, len);
775 msm_dsi_host_cmd_xfer_commit(host, dma_base, len);
780 int msm_dsi_manager_register(struct msm_dsi *msm_dsi)
782 struct msm_dsi_manager *msm_dsim = &msm_dsim_glb;
783 int id = msm_dsi->id;
787 pr_err("%s: invalid id %d\n", __func__, id);
791 if (msm_dsim->dsi[id]) {
792 pr_err("%s: dsi%d already registered\n", __func__, id);
796 msm_dsim->dsi[id] = msm_dsi;
798 ret = dsi_mgr_parse_dual_dsi(msm_dsi->pdev->dev.of_node, id);
800 pr_err("%s: failed to parse dual DSI info\n", __func__);
804 ret = dsi_mgr_setup_components(id);
806 pr_err("%s: failed to register mipi dsi host for DSI %d\n",
814 msm_dsim->dsi[id] = NULL;
818 void msm_dsi_manager_unregister(struct msm_dsi *msm_dsi)
820 struct msm_dsi_manager *msm_dsim = &msm_dsim_glb;
823 msm_dsi_host_unregister(msm_dsi->host);
825 if (msm_dsi->id >= 0)
826 msm_dsim->dsi[msm_dsi->id] = NULL;