drivers/gpu/drm/i915/display/icl_dsi.c

   1 /*
   2  * Copyright © 2018 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  21  * DEALINGS IN THE SOFTWARE.
  22  *
  23  * Authors:
  24  *   Madhav Chauhan <madhav.chauhan@intel.com>
  25  *   Jani Nikula <jani.nikula@intel.com>
  26  */
  27
  28 #include <drm/display/drm_dsc_helper.h>
  29 #include <drm/drm_atomic_helper.h>
  30 #include <drm/drm_mipi_dsi.h>
  31
  32 #include "i915_reg.h"
  33 #include "icl_dsi.h"
  34 #include "icl_dsi_regs.h"
  35 #include "intel_atomic.h"
  36 #include "intel_backlight.h"
  37 #include "intel_backlight_regs.h"
  38 #include "intel_combo_phy.h"
  39 #include "intel_combo_phy_regs.h"
  40 #include "intel_connector.h"
  41 #include "intel_crtc.h"
  42 #include "intel_ddi.h"
  43 #include "intel_de.h"
  44 #include "intel_dsi.h"
  45 #include "intel_dsi_vbt.h"
  46 #include "intel_panel.h"
  47 #include "intel_vdsc.h"
  48 #include "intel_vdsc_regs.h"
  49 #include "skl_scaler.h"
  50 #include "skl_universal_plane.h"
  51
  52 static int header_credits_available(struct drm_i915_private *dev_priv,
  53                                     enum transcoder dsi_trans)
  54 {
  55         return (intel_de_read(dev_priv, DSI_CMD_TXCTL(dsi_trans)) & FREE_HEADER_CREDIT_MASK)
  56                 >> FREE_HEADER_CREDIT_SHIFT;
  57 }
  58
  59 static int payload_credits_available(struct drm_i915_private *dev_priv,
  60                                      enum transcoder dsi_trans)
  61 {
  62         return (intel_de_read(dev_priv, DSI_CMD_TXCTL(dsi_trans)) & FREE_PLOAD_CREDIT_MASK)
  63                 >> FREE_PLOAD_CREDIT_SHIFT;
  64 }
  65
  66 static bool wait_for_header_credits(struct drm_i915_private *dev_priv,
  67                                     enum transcoder dsi_trans, int hdr_credit)
  68 {
  69         if (wait_for_us(header_credits_available(dev_priv, dsi_trans) >=
  70                         hdr_credit, 100)) {
  71                 drm_err(&dev_priv->drm, "DSI header credits not released\n");
  72                 return false;
  73         }
  74
  75         return true;
  76 }
  77
  78 static bool wait_for_payload_credits(struct drm_i915_private *dev_priv,
  79                                      enum transcoder dsi_trans, int payld_credit)
  80 {
  81         if (wait_for_us(payload_credits_available(dev_priv, dsi_trans) >=
  82                         payld_credit, 100)) {
  83                 drm_err(&dev_priv->drm, "DSI payload credits not released\n");
  84                 return false;
  85         }
  86
  87         return true;
  88 }
  89
  90 static enum transcoder dsi_port_to_transcoder(enum port port)
  91 {
  92         if (port == PORT_A)
  93                 return TRANSCODER_DSI_0;
  94         else
  95                 return TRANSCODER_DSI_1;
  96 }
  97
  98 static void wait_for_cmds_dispatched_to_panel(struct intel_encoder *encoder)
  99 {
 100         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 101         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 102         struct mipi_dsi_device *dsi;
 103         enum port port;
 104         enum transcoder dsi_trans;
 105         int ret;
 106
 107         /* wait for header/payload credits to be released */
 108         for_each_dsi_port(port, intel_dsi->ports) {
 109                 dsi_trans = dsi_port_to_transcoder(port);
 110                 wait_for_header_credits(dev_priv, dsi_trans, MAX_HEADER_CREDIT);
 111                 wait_for_payload_credits(dev_priv, dsi_trans, MAX_PLOAD_CREDIT);
 112         }
 113
 114         /* send nop DCS command */
 115         for_each_dsi_port(port, intel_dsi->ports) {
 116                 dsi = intel_dsi->dsi_hosts[port]->device;
 117                 dsi->mode_flags |= MIPI_DSI_MODE_LPM;
 118                 dsi->channel = 0;
 119                 ret = mipi_dsi_dcs_nop(dsi);
 120                 if (ret < 0)
 121                         drm_err(&dev_priv->drm,
 122                                 "error sending DCS NOP command\n");
 123         }
 124
 125         /* wait for header credits to be released */
 126         for_each_dsi_port(port, intel_dsi->ports) {
 127                 dsi_trans = dsi_port_to_transcoder(port);
 128                 wait_for_header_credits(dev_priv, dsi_trans, MAX_HEADER_CREDIT);
 129         }
 130
 131         /* wait for LP TX in progress bit to be cleared */
 132         for_each_dsi_port(port, intel_dsi->ports) {
 133                 dsi_trans = dsi_port_to_transcoder(port);
 134                 if (wait_for_us(!(intel_de_read(dev_priv, DSI_LP_MSG(dsi_trans)) &
 135                                   LPTX_IN_PROGRESS), 20))
 136                         drm_err(&dev_priv->drm, "LPTX bit not cleared\n");
 137         }
 138 }
 139
 140 static int dsi_send_pkt_payld(struct intel_dsi_host *host,
 141                               const struct mipi_dsi_packet *packet)
 142 {
 143         struct intel_dsi *intel_dsi = host->intel_dsi;
 144         struct drm_i915_private *i915 = to_i915(intel_dsi->base.base.dev);
 145         enum transcoder dsi_trans = dsi_port_to_transcoder(host->port);
 146         const u8 *data = packet->payload;
 147         u32 len = packet->payload_length;
 148         int i, j;
 149
 150         /* payload queue can accept *256 bytes*, check limit */
 151         if (len > MAX_PLOAD_CREDIT * 4) {
 152                 drm_err(&i915->drm, "payload size exceeds max queue limit\n");
 153                 return -EINVAL;
 154         }
 155
 156         for (i = 0; i < len; i += 4) {
 157                 u32 tmp = 0;
 158
 159                 if (!wait_for_payload_credits(i915, dsi_trans, 1))
 160                         return -EBUSY;
 161
 162                 for (j = 0; j < min_t(u32, len - i, 4); j++)
 163                         tmp |= *data++ << 8 * j;
 164
 165                 intel_de_write(i915, DSI_CMD_TXPYLD(dsi_trans), tmp);
 166         }
 167
 168         return 0;
 169 }
 170
 171 static int dsi_send_pkt_hdr(struct intel_dsi_host *host,
 172                             const struct mipi_dsi_packet *packet,
 173                             bool enable_lpdt)
 174 {
 175         struct intel_dsi *intel_dsi = host->intel_dsi;
 176         struct drm_i915_private *dev_priv = to_i915(intel_dsi->base.base.dev);
 177         enum transcoder dsi_trans = dsi_port_to_transcoder(host->port);
 178         u32 tmp;
 179
 180         if (!wait_for_header_credits(dev_priv, dsi_trans, 1))
 181                 return -EBUSY;
 182
 183         tmp = intel_de_read(dev_priv, DSI_CMD_TXHDR(dsi_trans));
 184
 185         if (packet->payload)
 186                 tmp |= PAYLOAD_PRESENT;
 187         else
 188                 tmp &= ~PAYLOAD_PRESENT;
 189
 190         tmp &= ~VBLANK_FENCE;
 191
 192         if (enable_lpdt)
 193                 tmp |= LP_DATA_TRANSFER;
 194         else
 195                 tmp &= ~LP_DATA_TRANSFER;
 196
 197         tmp &= ~(PARAM_WC_MASK | VC_MASK | DT_MASK);
 198         tmp |= ((packet->header[0] & VC_MASK) << VC_SHIFT);
 199         tmp |= ((packet->header[0] & DT_MASK) << DT_SHIFT);
 200         tmp |= (packet->header[1] << PARAM_WC_LOWER_SHIFT);
 201         tmp |= (packet->header[2] << PARAM_WC_UPPER_SHIFT);
 202         intel_de_write(dev_priv, DSI_CMD_TXHDR(dsi_trans), tmp);
 203
 204         return 0;
 205 }
 206
 207 void icl_dsi_frame_update(struct intel_crtc_state *crtc_state)
 208 {
 209         struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
 210         struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
 211         u32 mode_flags;
 212         enum port port;
 213
 214         mode_flags = crtc_state->mode_flags;
 215
 216         /*
 217          * case 1 also covers dual link
 218          * In case of dual link, frame update should be set on
 219          * DSI_0
 220          */
 221         if (mode_flags & I915_MODE_FLAG_DSI_USE_TE0)
 222                 port = PORT_A;
 223         else if (mode_flags & I915_MODE_FLAG_DSI_USE_TE1)
 224                 port = PORT_B;
 225         else
 226                 return;
 227
 228         intel_de_rmw(dev_priv, DSI_CMD_FRMCTL(port), 0, DSI_FRAME_UPDATE_REQUEST);
 229 }
 230
 231 static void dsi_program_swing_and_deemphasis(struct intel_encoder *encoder)
 232 {
 233         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 234         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 235         enum phy phy;
 236         u32 tmp, mask, val;
 237         int lane;
 238
 239         for_each_dsi_phy(phy, intel_dsi->phys) {
 240                 /*
 241                  * Program voltage swing and pre-emphasis level values as per
 242                  * table in BSPEC under DDI buffer programing
 243                  */
 244                 mask = SCALING_MODE_SEL_MASK | RTERM_SELECT_MASK;
 245                 val = SCALING_MODE_SEL(0x2) | TAP2_DISABLE | TAP3_DISABLE |
 246                       RTERM_SELECT(0x6);
 247                 tmp = intel_de_read(dev_priv, ICL_PORT_TX_DW5_LN(0, phy));
 248                 tmp &= ~mask;
 249                 tmp |= val;
 250                 intel_de_write(dev_priv, ICL_PORT_TX_DW5_GRP(phy), tmp);
 251                 intel_de_rmw(dev_priv, ICL_PORT_TX_DW5_AUX(phy), mask, val);
 252
 253                 mask = SWING_SEL_LOWER_MASK | SWING_SEL_UPPER_MASK |
 254                        RCOMP_SCALAR_MASK;
 255                 val = SWING_SEL_UPPER(0x2) | SWING_SEL_LOWER(0x2) |
 256                       RCOMP_SCALAR(0x98);
 257                 tmp = intel_de_read(dev_priv, ICL_PORT_TX_DW2_LN(0, phy));
 258                 tmp &= ~mask;
 259                 tmp |= val;
 260                 intel_de_write(dev_priv, ICL_PORT_TX_DW2_GRP(phy), tmp);
 261                 intel_de_rmw(dev_priv, ICL_PORT_TX_DW2_AUX(phy), mask, val);
 262
 263                 mask = POST_CURSOR_1_MASK | POST_CURSOR_2_MASK |
 264                        CURSOR_COEFF_MASK;
 265                 val = POST_CURSOR_1(0x0) | POST_CURSOR_2(0x0) |
 266                       CURSOR_COEFF(0x3f);
 267                 intel_de_rmw(dev_priv, ICL_PORT_TX_DW4_AUX(phy), mask, val);
 268
 269                 /* Bspec: must not use GRP register for write */
 270                 for (lane = 0; lane <= 3; lane++)
 271                         intel_de_rmw(dev_priv, ICL_PORT_TX_DW4_LN(lane, phy),
 272                                      mask, val);
 273         }
 274 }
 275
 276 static void configure_dual_link_mode(struct intel_encoder *encoder,
 277                                      const struct intel_crtc_state *pipe_config)
 278 {
 279         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 280         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 281         i915_reg_t dss_ctl1_reg, dss_ctl2_reg;
 282         u32 dss_ctl1;
 283
 284         /* FIXME: Move all DSS handling to intel_vdsc.c */
 285         if (DISPLAY_VER(dev_priv) >= 12) {
 286                 struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
 287
 288                 dss_ctl1_reg = ICL_PIPE_DSS_CTL1(crtc->pipe);
 289                 dss_ctl2_reg = ICL_PIPE_DSS_CTL2(crtc->pipe);
 290         } else {
 291                 dss_ctl1_reg = DSS_CTL1;
 292                 dss_ctl2_reg = DSS_CTL2;
 293         }
 294
 295         dss_ctl1 = intel_de_read(dev_priv, dss_ctl1_reg);
 296         dss_ctl1 |= SPLITTER_ENABLE;
 297         dss_ctl1 &= ~OVERLAP_PIXELS_MASK;
 298         dss_ctl1 |= OVERLAP_PIXELS(intel_dsi->pixel_overlap);
 299
 300         if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK) {
 301                 const struct drm_display_mode *adjusted_mode =
 302                                         &pipe_config->hw.adjusted_mode;
 303                 u16 hactive = adjusted_mode->crtc_hdisplay;
 304                 u16 dl_buffer_depth;
 305
 306                 dss_ctl1 &= ~DUAL_LINK_MODE_INTERLEAVE;
 307                 dl_buffer_depth = hactive / 2 + intel_dsi->pixel_overlap;
 308
 309                 if (dl_buffer_depth > MAX_DL_BUFFER_TARGET_DEPTH)
 310                         drm_err(&dev_priv->drm,
 311                                 "DL buffer depth exceed max value\n");
 312
 313                 dss_ctl1 &= ~LEFT_DL_BUF_TARGET_DEPTH_MASK;
 314                 dss_ctl1 |= LEFT_DL_BUF_TARGET_DEPTH(dl_buffer_depth);
 315                 intel_de_rmw(dev_priv, dss_ctl2_reg, RIGHT_DL_BUF_TARGET_DEPTH_MASK,
 316                              RIGHT_DL_BUF_TARGET_DEPTH(dl_buffer_depth));
 317         } else {
 318                 /* Interleave */
 319                 dss_ctl1 |= DUAL_LINK_MODE_INTERLEAVE;
 320         }
 321
 322         intel_de_write(dev_priv, dss_ctl1_reg, dss_ctl1);
 323 }
 324
 325 /* aka DSI 8X clock */
 326 static int afe_clk(struct intel_encoder *encoder,
 327                    const struct intel_crtc_state *crtc_state)
 328 {
 329         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 330         int bpp;
 331
 332         if (crtc_state->dsc.compression_enable)
 333                 bpp = crtc_state->dsc.compressed_bpp;
 334         else
 335                 bpp = mipi_dsi_pixel_format_to_bpp(intel_dsi->pixel_format);
 336
 337         return DIV_ROUND_CLOSEST(intel_dsi->pclk * bpp, intel_dsi->lane_count);
 338 }
 339
 340 static void gen11_dsi_program_esc_clk_div(struct intel_encoder *encoder,
 341                                           const struct intel_crtc_state *crtc_state)
 342 {
 343         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 344         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 345         enum port port;
 346         int afe_clk_khz;
 347         int theo_word_clk, act_word_clk;
 348         u32 esc_clk_div_m, esc_clk_div_m_phy;
 349
 350         afe_clk_khz = afe_clk(encoder, crtc_state);
 351
 352         if (IS_ALDERLAKE_S(dev_priv) || IS_ALDERLAKE_P(dev_priv)) {
 353                 theo_word_clk = DIV_ROUND_UP(afe_clk_khz, 8 * DSI_MAX_ESC_CLK);
 354                 act_word_clk = max(3, theo_word_clk + (theo_word_clk + 1) % 2);
 355                 esc_clk_div_m = act_word_clk * 8;
 356                 esc_clk_div_m_phy = (act_word_clk - 1) / 2;
 357         } else {
 358                 esc_clk_div_m = DIV_ROUND_UP(afe_clk_khz, DSI_MAX_ESC_CLK);
 359         }
 360
 361         for_each_dsi_port(port, intel_dsi->ports) {
 362                 intel_de_write(dev_priv, ICL_DSI_ESC_CLK_DIV(port),
 363                                esc_clk_div_m & ICL_ESC_CLK_DIV_MASK);
 364                 intel_de_posting_read(dev_priv, ICL_DSI_ESC_CLK_DIV(port));
 365         }
 366
 367         for_each_dsi_port(port, intel_dsi->ports) {
 368                 intel_de_write(dev_priv, ICL_DPHY_ESC_CLK_DIV(port),
 369                                esc_clk_div_m & ICL_ESC_CLK_DIV_MASK);
 370                 intel_de_posting_read(dev_priv, ICL_DPHY_ESC_CLK_DIV(port));
 371         }
 372
 373         if (IS_ALDERLAKE_S(dev_priv) || IS_ALDERLAKE_P(dev_priv)) {
 374                 for_each_dsi_port(port, intel_dsi->ports) {
 375                         intel_de_write(dev_priv, ADL_MIPIO_DW(port, 8),
 376                                        esc_clk_div_m_phy & TX_ESC_CLK_DIV_PHY);
 377                         intel_de_posting_read(dev_priv, ADL_MIPIO_DW(port, 8));
 378                 }
 379         }
 380 }
 381
 382 static void get_dsi_io_power_domains(struct drm_i915_private *dev_priv,
 383                                      struct intel_dsi *intel_dsi)
 384 {
 385         enum port port;
 386
 387         for_each_dsi_port(port, intel_dsi->ports) {
 388                 drm_WARN_ON(&dev_priv->drm, intel_dsi->io_wakeref[port]);
 389                 intel_dsi->io_wakeref[port] =
 390                         intel_display_power_get(dev_priv,
 391                                                 port == PORT_A ?
 392                                                 POWER_DOMAIN_PORT_DDI_IO_A :
 393                                                 POWER_DOMAIN_PORT_DDI_IO_B);
 394         }
 395 }
 396
 397 static void gen11_dsi_enable_io_power(struct intel_encoder *encoder)
 398 {
 399         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 400         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 401         enum port port;
 402
 403         for_each_dsi_port(port, intel_dsi->ports)
 404                 intel_de_rmw(dev_priv, ICL_DSI_IO_MODECTL(port),
 405                              0, COMBO_PHY_MODE_DSI);
 406
 407         get_dsi_io_power_domains(dev_priv, intel_dsi);
 408 }
 409
 410 static void gen11_dsi_power_up_lanes(struct intel_encoder *encoder)
 411 {
 412         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 413         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 414         enum phy phy;
 415
 416         for_each_dsi_phy(phy, intel_dsi->phys)
 417                 intel_combo_phy_power_up_lanes(dev_priv, phy, true,
 418                                                intel_dsi->lane_count, false);
 419 }
 420
 421 static void gen11_dsi_config_phy_lanes_sequence(struct intel_encoder *encoder)
 422 {
 423         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 424         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 425         enum phy phy;
 426         u32 tmp;
 427         int lane;
 428
 429         /* Step 4b(i) set loadgen select for transmit and aux lanes */
 430         for_each_dsi_phy(phy, intel_dsi->phys) {
 431                 intel_de_rmw(dev_priv, ICL_PORT_TX_DW4_AUX(phy), LOADGEN_SELECT, 0);
 432                 for (lane = 0; lane <= 3; lane++)
 433                         intel_de_rmw(dev_priv, ICL_PORT_TX_DW4_LN(lane, phy),
 434                                      LOADGEN_SELECT, lane != 2 ? LOADGEN_SELECT : 0);
 435         }
 436
 437         /* Step 4b(ii) set latency optimization for transmit and aux lanes */
 438         for_each_dsi_phy(phy, intel_dsi->phys) {
 439                 intel_de_rmw(dev_priv, ICL_PORT_TX_DW2_AUX(phy),
 440                              FRC_LATENCY_OPTIM_MASK, FRC_LATENCY_OPTIM_VAL(0x5));
 441                 tmp = intel_de_read(dev_priv, ICL_PORT_TX_DW2_LN(0, phy));
 442                 tmp &= ~FRC_LATENCY_OPTIM_MASK;
 443                 tmp |= FRC_LATENCY_OPTIM_VAL(0x5);
 444                 intel_de_write(dev_priv, ICL_PORT_TX_DW2_GRP(phy), tmp);
 445
 446                 /* For EHL, TGL, set latency optimization for PCS_DW1 lanes */
 447                 if (IS_JSL_EHL(dev_priv) || (DISPLAY_VER(dev_priv) >= 12)) {
 448                         intel_de_rmw(dev_priv, ICL_PORT_PCS_DW1_AUX(phy),
 449                                      LATENCY_OPTIM_MASK, LATENCY_OPTIM_VAL(0));
 450
 451                         tmp = intel_de_read(dev_priv,
 452                                             ICL_PORT_PCS_DW1_LN(0, phy));
 453                         tmp &= ~LATENCY_OPTIM_MASK;
 454                         tmp |= LATENCY_OPTIM_VAL(0x1);
 455                         intel_de_write(dev_priv, ICL_PORT_PCS_DW1_GRP(phy),
 456                                        tmp);
 457                 }
 458         }
 459
 460 }
 461
 462 static void gen11_dsi_voltage_swing_program_seq(struct intel_encoder *encoder)
 463 {
 464         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 465         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 466         u32 tmp;
 467         enum phy phy;
 468
 469         /* clear common keeper enable bit */
 470         for_each_dsi_phy(phy, intel_dsi->phys) {
 471                 tmp = intel_de_read(dev_priv, ICL_PORT_PCS_DW1_LN(0, phy));
 472                 tmp &= ~COMMON_KEEPER_EN;
 473                 intel_de_write(dev_priv, ICL_PORT_PCS_DW1_GRP(phy), tmp);
 474                 intel_de_rmw(dev_priv, ICL_PORT_PCS_DW1_AUX(phy), COMMON_KEEPER_EN, 0);
 475         }
 476
 477         /*
 478          * Set SUS Clock Config bitfield to 11b
 479          * Note: loadgen select program is done
 480          * as part of lane phy sequence configuration
 481          */
 482         for_each_dsi_phy(phy, intel_dsi->phys)
 483                 intel_de_rmw(dev_priv, ICL_PORT_CL_DW5(phy), 0, SUS_CLOCK_CONFIG);
 484
 485         /* Clear training enable to change swing values */
 486         for_each_dsi_phy(phy, intel_dsi->phys) {
 487                 tmp = intel_de_read(dev_priv, ICL_PORT_TX_DW5_LN(0, phy));
 488                 tmp &= ~TX_TRAINING_EN;
 489                 intel_de_write(dev_priv, ICL_PORT_TX_DW5_GRP(phy), tmp);
 490                 intel_de_rmw(dev_priv, ICL_PORT_TX_DW5_AUX(phy), TX_TRAINING_EN, 0);
 491         }
 492
 493         /* Program swing and de-emphasis */
 494         dsi_program_swing_and_deemphasis(encoder);
 495
 496         /* Set training enable to trigger update */
 497         for_each_dsi_phy(phy, intel_dsi->phys) {
 498                 tmp = intel_de_read(dev_priv, ICL_PORT_TX_DW5_LN(0, phy));
 499                 tmp |= TX_TRAINING_EN;
 500                 intel_de_write(dev_priv, ICL_PORT_TX_DW5_GRP(phy), tmp);
 501                 intel_de_rmw(dev_priv, ICL_PORT_TX_DW5_AUX(phy), 0, TX_TRAINING_EN);
 502         }
 503 }
 504
 505 static void gen11_dsi_enable_ddi_buffer(struct intel_encoder *encoder)
 506 {
 507         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 508         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 509         enum port port;
 510
 511         for_each_dsi_port(port, intel_dsi->ports) {
 512                 intel_de_rmw(dev_priv, DDI_BUF_CTL(port), 0, DDI_BUF_CTL_ENABLE);
 513
 514                 if (wait_for_us(!(intel_de_read(dev_priv, DDI_BUF_CTL(port)) &
 515                                   DDI_BUF_IS_IDLE),
 516                                   500))
 517                         drm_err(&dev_priv->drm, "DDI port:%c buffer idle\n",
 518                                 port_name(port));
 519         }
 520 }
 521
 522 static void
 523 gen11_dsi_setup_dphy_timings(struct intel_encoder *encoder,
 524                              const struct intel_crtc_state *crtc_state)
 525 {
 526         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 527         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 528         enum port port;
 529         enum phy phy;
 530
 531         /* Program DPHY clock lanes timings */
 532         for_each_dsi_port(port, intel_dsi->ports)
 533                 intel_de_write(dev_priv, DPHY_CLK_TIMING_PARAM(port),
 534                                intel_dsi->dphy_reg);
 535
 536         /* Program DPHY data lanes timings */
 537         for_each_dsi_port(port, intel_dsi->ports)
 538                 intel_de_write(dev_priv, DPHY_DATA_TIMING_PARAM(port),
 539                                intel_dsi->dphy_data_lane_reg);
 540
 541         /*
 542          * If DSI link operating at or below an 800 MHz,
 543          * TA_SURE should be override and programmed to
 544          * a value '0' inside TA_PARAM_REGISTERS otherwise
 545          * leave all fields at HW default values.
 546          */
 547         if (DISPLAY_VER(dev_priv) == 11) {
 548                 if (afe_clk(encoder, crtc_state) <= 800000) {
 549                         for_each_dsi_port(port, intel_dsi->ports)
 550                                 intel_de_rmw(dev_priv, DPHY_TA_TIMING_PARAM(port),
 551                                              TA_SURE_MASK,
 552                                              TA_SURE_OVERRIDE | TA_SURE(0));
 553                 }
 554         }
 555
 556         if (IS_JSL_EHL(dev_priv)) {
 557                 for_each_dsi_phy(phy, intel_dsi->phys)
 558                         intel_de_rmw(dev_priv, ICL_DPHY_CHKN(phy),
 559                                      0, ICL_DPHY_CHKN_AFE_OVER_PPI_STRAP);
 560         }
 561 }
 562
 563 static void
 564 gen11_dsi_setup_timings(struct intel_encoder *encoder,
 565                         const struct intel_crtc_state *crtc_state)
 566 {
 567         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 568         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 569         enum port port;
 570
 571         /* Program T-INIT master registers */
 572         for_each_dsi_port(port, intel_dsi->ports)
 573                 intel_de_rmw(dev_priv, ICL_DSI_T_INIT_MASTER(port),
 574                              DSI_T_INIT_MASTER_MASK, intel_dsi->init_count);
 575
 576         /* shadow register inside display core */
 577         for_each_dsi_port(port, intel_dsi->ports)
 578                 intel_de_write(dev_priv, DSI_CLK_TIMING_PARAM(port),
 579                                intel_dsi->dphy_reg);
 580
 581         /* shadow register inside display core */
 582         for_each_dsi_port(port, intel_dsi->ports)
 583                 intel_de_write(dev_priv, DSI_DATA_TIMING_PARAM(port),
 584                                intel_dsi->dphy_data_lane_reg);
 585
 586         /* shadow register inside display core */
 587         if (DISPLAY_VER(dev_priv) == 11) {
 588                 if (afe_clk(encoder, crtc_state) <= 800000) {
 589                         for_each_dsi_port(port, intel_dsi->ports) {
 590                                 intel_de_rmw(dev_priv, DSI_TA_TIMING_PARAM(port),
 591                                              TA_SURE_MASK,
 592                                              TA_SURE_OVERRIDE | TA_SURE(0));
 593                         }
 594                 }
 595         }
 596 }
 597
 598 static void gen11_dsi_gate_clocks(struct intel_encoder *encoder)
 599 {
 600         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 601         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 602         u32 tmp;
 603         enum phy phy;
 604
 605         mutex_lock(&dev_priv->display.dpll.lock);
 606         tmp = intel_de_read(dev_priv, ICL_DPCLKA_CFGCR0);
 607         for_each_dsi_phy(phy, intel_dsi->phys)
 608                 tmp |= ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy);
 609
 610         intel_de_write(dev_priv, ICL_DPCLKA_CFGCR0, tmp);
 611         mutex_unlock(&dev_priv->display.dpll.lock);
 612 }
 613
 614 static void gen11_dsi_ungate_clocks(struct intel_encoder *encoder)
 615 {
 616         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 617         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 618         u32 tmp;
 619         enum phy phy;
 620
 621         mutex_lock(&dev_priv->display.dpll.lock);
 622         tmp = intel_de_read(dev_priv, ICL_DPCLKA_CFGCR0);
 623         for_each_dsi_phy(phy, intel_dsi->phys)
 624                 tmp &= ~ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy);
 625
 626         intel_de_write(dev_priv, ICL_DPCLKA_CFGCR0, tmp);
 627         mutex_unlock(&dev_priv->display.dpll.lock);
 628 }
 629
 630 static bool gen11_dsi_is_clock_enabled(struct intel_encoder *encoder)
 631 {
 632         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 633         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 634         bool clock_enabled = false;
 635         enum phy phy;
 636         u32 tmp;
 637
 638         tmp = intel_de_read(dev_priv, ICL_DPCLKA_CFGCR0);
 639
 640         for_each_dsi_phy(phy, intel_dsi->phys) {
 641                 if (!(tmp & ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy)))
 642                         clock_enabled = true;
 643         }
 644
 645         return clock_enabled;
 646 }
 647
 648 static void gen11_dsi_map_pll(struct intel_encoder *encoder,
 649                               const struct intel_crtc_state *crtc_state)
 650 {
 651         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 652         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 653         struct intel_shared_dpll *pll = crtc_state->shared_dpll;
 654         enum phy phy;
 655         u32 val;
 656
 657         mutex_lock(&dev_priv->display.dpll.lock);
 658
 659         val = intel_de_read(dev_priv, ICL_DPCLKA_CFGCR0);
 660         for_each_dsi_phy(phy, intel_dsi->phys) {
 661                 val &= ~ICL_DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(phy);
 662                 val |= ICL_DPCLKA_CFGCR0_DDI_CLK_SEL(pll->info->id, phy);
 663         }
 664         intel_de_write(dev_priv, ICL_DPCLKA_CFGCR0, val);
 665
 666         for_each_dsi_phy(phy, intel_dsi->phys) {
 667                 val &= ~ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy);
 668         }
 669         intel_de_write(dev_priv, ICL_DPCLKA_CFGCR0, val);
 670
 671         intel_de_posting_read(dev_priv, ICL_DPCLKA_CFGCR0);
 672
 673         mutex_unlock(&dev_priv->display.dpll.lock);
 674 }
 675
 676 static void
 677 gen11_dsi_configure_transcoder(struct intel_encoder *encoder,
 678                                const struct intel_crtc_state *pipe_config)
 679 {
 680         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 681         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 682         struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
 683         enum pipe pipe = crtc->pipe;
 684         u32 tmp;
 685         enum port port;
 686         enum transcoder dsi_trans;
 687
 688         for_each_dsi_port(port, intel_dsi->ports) {
 689                 dsi_trans = dsi_port_to_transcoder(port);
 690                 tmp = intel_de_read(dev_priv, DSI_TRANS_FUNC_CONF(dsi_trans));
 691
 692                 if (intel_dsi->eotp_pkt)
 693                         tmp &= ~EOTP_DISABLED;
 694                 else
 695                         tmp |= EOTP_DISABLED;
 696
 697                 /* enable link calibration if freq > 1.5Gbps */
 698                 if (afe_clk(encoder, pipe_config) >= 1500 * 1000) {
 699                         tmp &= ~LINK_CALIBRATION_MASK;
 700                         tmp |= CALIBRATION_ENABLED_INITIAL_ONLY;
 701                 }
 702
 703                 /* configure continuous clock */
 704                 tmp &= ~CONTINUOUS_CLK_MASK;
 705                 if (intel_dsi->clock_stop)
 706                         tmp |= CLK_ENTER_LP_AFTER_DATA;
 707                 else
 708                         tmp |= CLK_HS_CONTINUOUS;
 709
 710                 /* configure buffer threshold limit to minimum */
 711                 tmp &= ~PIX_BUF_THRESHOLD_MASK;
 712                 tmp |= PIX_BUF_THRESHOLD_1_4;
 713
 714                 /* set virtual channel to '0' */
 715                 tmp &= ~PIX_VIRT_CHAN_MASK;
 716                 tmp |= PIX_VIRT_CHAN(0);
 717
 718                 /* program BGR transmission */
 719                 if (intel_dsi->bgr_enabled)
 720                         tmp |= BGR_TRANSMISSION;
 721
 722                 /* select pixel format */
 723                 tmp &= ~PIX_FMT_MASK;
 724                 if (pipe_config->dsc.compression_enable) {
 725                         tmp |= PIX_FMT_COMPRESSED;
 726                 } else {
 727                         switch (intel_dsi->pixel_format) {
 728                         default:
 729                                 MISSING_CASE(intel_dsi->pixel_format);
 730                                 fallthrough;
 731                         case MIPI_DSI_FMT_RGB565:
 732                                 tmp |= PIX_FMT_RGB565;
 733                                 break;
 734                         case MIPI_DSI_FMT_RGB666_PACKED:
 735                                 tmp |= PIX_FMT_RGB666_PACKED;
 736                                 break;
 737                         case MIPI_DSI_FMT_RGB666:
 738                                 tmp |= PIX_FMT_RGB666_LOOSE;
 739                                 break;
 740                         case MIPI_DSI_FMT_RGB888:
 741                                 tmp |= PIX_FMT_RGB888;
 742                                 break;
 743                         }
 744                 }
 745
 746                 if (DISPLAY_VER(dev_priv) >= 12) {
 747                         if (is_vid_mode(intel_dsi))
 748                                 tmp |= BLANKING_PACKET_ENABLE;
 749                 }
 750
 751                 /* program DSI operation mode */
 752                 if (is_vid_mode(intel_dsi)) {
 753                         tmp &= ~OP_MODE_MASK;
 754                         switch (intel_dsi->video_mode) {
 755                         default:
 756                                 MISSING_CASE(intel_dsi->video_mode);
 757                                 fallthrough;
 758                         case NON_BURST_SYNC_EVENTS:
 759                                 tmp |= VIDEO_MODE_SYNC_EVENT;
 760                                 break;
 761                         case NON_BURST_SYNC_PULSE:
 762                                 tmp |= VIDEO_MODE_SYNC_PULSE;
 763                                 break;
 764                         }
 765                 } else {
 766                         /*
 767                          * FIXME: Retrieve this info from VBT.
 768                          * As per the spec when dsi transcoder is operating
 769                          * in TE GATE mode, TE comes from GPIO
 770                          * which is UTIL PIN for DSI 0.
 771                          * Also this GPIO would not be used for other
 772                          * purposes is an assumption.
 773                          */
 774                         tmp &= ~OP_MODE_MASK;
 775                         tmp |= CMD_MODE_TE_GATE;
 776                         tmp |= TE_SOURCE_GPIO;
 777                 }
 778
 779                 intel_de_write(dev_priv, DSI_TRANS_FUNC_CONF(dsi_trans), tmp);
 780         }
 781
 782         /* enable port sync mode if dual link */
 783         if (intel_dsi->dual_link) {
 784                 for_each_dsi_port(port, intel_dsi->ports) {
 785                         dsi_trans = dsi_port_to_transcoder(port);
 786                         intel_de_rmw(dev_priv, TRANS_DDI_FUNC_CTL2(dsi_trans),
 787                                      0, PORT_SYNC_MODE_ENABLE);
 788                 }
 789
 790                 /* configure stream splitting */
 791                 configure_dual_link_mode(encoder, pipe_config);
 792         }
 793
 794         for_each_dsi_port(port, intel_dsi->ports) {
 795                 dsi_trans = dsi_port_to_transcoder(port);
 796
 797                 /* select data lane width */
 798                 tmp = intel_de_read(dev_priv, TRANS_DDI_FUNC_CTL(dsi_trans));
 799                 tmp &= ~DDI_PORT_WIDTH_MASK;
 800                 tmp |= DDI_PORT_WIDTH(intel_dsi->lane_count);
 801
 802                 /* select input pipe */
 803                 tmp &= ~TRANS_DDI_EDP_INPUT_MASK;
 804                 switch (pipe) {
 805                 default:
 806                         MISSING_CASE(pipe);
 807                         fallthrough;
 808                 case PIPE_A:
 809                         tmp |= TRANS_DDI_EDP_INPUT_A_ON;
 810                         break;
 811                 case PIPE_B:
 812                         tmp |= TRANS_DDI_EDP_INPUT_B_ONOFF;
 813                         break;
 814                 case PIPE_C:
 815                         tmp |= TRANS_DDI_EDP_INPUT_C_ONOFF;
 816                         break;
 817                 case PIPE_D:
 818                         tmp |= TRANS_DDI_EDP_INPUT_D_ONOFF;
 819                         break;
 820                 }
 821
 822                 /* enable DDI buffer */
 823                 tmp |= TRANS_DDI_FUNC_ENABLE;
 824                 intel_de_write(dev_priv, TRANS_DDI_FUNC_CTL(dsi_trans), tmp);
 825         }
 826
 827         /* wait for link ready */
 828         for_each_dsi_port(port, intel_dsi->ports) {
 829                 dsi_trans = dsi_port_to_transcoder(port);
 830                 if (wait_for_us((intel_de_read(dev_priv, DSI_TRANS_FUNC_CONF(dsi_trans)) &
 831                                  LINK_READY), 2500))
 832                         drm_err(&dev_priv->drm, "DSI link not ready\n");
 833         }
 834 }
 835
 836 static void
 837 gen11_dsi_set_transcoder_timings(struct intel_encoder *encoder,
 838                                  const struct intel_crtc_state *crtc_state)
 839 {
 840         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
 841         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
 842         const struct drm_display_mode *adjusted_mode =
 843                 &crtc_state->hw.adjusted_mode;
 844         enum port port;
 845         enum transcoder dsi_trans;
 846         /* horizontal timings */
 847         u16 htotal, hactive, hsync_start, hsync_end, hsync_size;
 848         u16 hback_porch;
 849         /* vertical timings */
 850         u16 vtotal, vactive, vsync_start, vsync_end, vsync_shift;
 851         int mul = 1, div = 1;
 852
 853         /*
 854          * Adjust horizontal timings (htotal, hsync_start, hsync_end) to account
 855          * for slower link speed if DSC is enabled.
 856          *
 857          * The compression frequency ratio is the ratio between compressed and
 858          * non-compressed link speeds, and simplifies down to the ratio between
 859          * compressed and non-compressed bpp.
 860          */
 861         if (crtc_state->dsc.compression_enable) {
 862                 mul = crtc_state->dsc.compressed_bpp;
 863                 div = mipi_dsi_pixel_format_to_bpp(intel_dsi->pixel_format);
 864         }
 865
 866         hactive = adjusted_mode->crtc_hdisplay;
 867
 868         if (is_vid_mode(intel_dsi))
 869                 htotal = DIV_ROUND_UP(adjusted_mode->crtc_htotal * mul, div);
 870         else
 871                 htotal = DIV_ROUND_UP((hactive + 160) * mul, div);
 872
 873         hsync_start = DIV_ROUND_UP(adjusted_mode->crtc_hsync_start * mul, div);
 874         hsync_end = DIV_ROUND_UP(adjusted_mode->crtc_hsync_end * mul, div);
 875         hsync_size  = hsync_end - hsync_start;
 876         hback_porch = (adjusted_mode->crtc_htotal -
 877                        adjusted_mode->crtc_hsync_end);
 878         vactive = adjusted_mode->crtc_vdisplay;
 879
 880         if (is_vid_mode(intel_dsi)) {
 881                 vtotal = adjusted_mode->crtc_vtotal;
 882         } else {
 883                 int bpp, line_time_us, byte_clk_period_ns;
 884
 885                 if (crtc_state->dsc.compression_enable)
 886                         bpp = crtc_state->dsc.compressed_bpp;
 887                 else
 888                         bpp = mipi_dsi_pixel_format_to_bpp(intel_dsi->pixel_format);
 889
 890                 byte_clk_period_ns = 1000000 / afe_clk(encoder, crtc_state);
 891                 line_time_us = (htotal * (bpp / 8) * byte_clk_period_ns) / (1000 * intel_dsi->lane_count);
 892                 vtotal = vactive + DIV_ROUND_UP(400, line_time_us);
 893         }
 894         vsync_start = adjusted_mode->crtc_vsync_start;
 895         vsync_end = adjusted_mode->crtc_vsync_end;
 896         vsync_shift = hsync_start - htotal / 2;
 897
 898         if (intel_dsi->dual_link) {
 899                 hactive /= 2;
 900                 if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK)
 901                         hactive += intel_dsi->pixel_overlap;
 902                 htotal /= 2;
 903         }
 904
 905         /* minimum hactive as per bspec: 256 pixels */
 906         if (adjusted_mode->crtc_hdisplay < 256)
 907                 drm_err(&dev_priv->drm, "hactive is less then 256 pixels\n");
 908
 909         /* if RGB666 format, then hactive must be multiple of 4 pixels */
 910         if (intel_dsi->pixel_format == MIPI_DSI_FMT_RGB666 && hactive % 4 != 0)
 911                 drm_err(&dev_priv->drm,
 912                         "hactive pixels are not multiple of 4\n");
 913
 914         /* program TRANS_HTOTAL register */
 915         for_each_dsi_port(port, intel_dsi->ports) {
 916                 dsi_trans = dsi_port_to_transcoder(port);
 917                 intel_de_write(dev_priv, TRANS_HTOTAL(dsi_trans),
 918                                HACTIVE(hactive - 1) | HTOTAL(htotal - 1));
 919         }
 920
 921         /* TRANS_HSYNC register to be programmed only for video mode */
 922         if (is_vid_mode(intel_dsi)) {
 923                 if (intel_dsi->video_mode == NON_BURST_SYNC_PULSE) {
 924                         /* BSPEC: hsync size should be atleast 16 pixels */
 925                         if (hsync_size < 16)
 926                                 drm_err(&dev_priv->drm,
 927                                         "hsync size < 16 pixels\n");
 928                 }
 929
 930                 if (hback_porch < 16)
 931                         drm_err(&dev_priv->drm, "hback porch < 16 pixels\n");
 932
 933                 if (intel_dsi->dual_link) {
 934                         hsync_start /= 2;
 935                         hsync_end /= 2;
 936                 }
 937
 938                 for_each_dsi_port(port, intel_dsi->ports) {
 939                         dsi_trans = dsi_port_to_transcoder(port);
 940                         intel_de_write(dev_priv, TRANS_HSYNC(dsi_trans),
 941                                        HSYNC_START(hsync_start - 1) | HSYNC_END(hsync_end - 1));
 942                 }
 943         }
 944
 945         /* program TRANS_VTOTAL register */
 946         for_each_dsi_port(port, intel_dsi->ports) {
 947                 dsi_trans = dsi_port_to_transcoder(port);
 948                 /*
 949                  * FIXME: Programing this by assuming progressive mode, since
 950                  * non-interlaced info from VBT is not saved inside
 951                  * struct drm_display_mode.
 952                  * For interlace mode: program required pixel minus 2
 953                  */
 954                 intel_de_write(dev_priv, TRANS_VTOTAL(dsi_trans),
 955                                VACTIVE(vactive - 1) | VTOTAL(vtotal - 1));
 956         }
 957
 958         if (vsync_end < vsync_start || vsync_end > vtotal)
 959                 drm_err(&dev_priv->drm, "Invalid vsync_end value\n");
 960
 961         if (vsync_start < vactive)
 962                 drm_err(&dev_priv->drm, "vsync_start less than vactive\n");
 963
 964         /* program TRANS_VSYNC register for video mode only */
 965         if (is_vid_mode(intel_dsi)) {
 966                 for_each_dsi_port(port, intel_dsi->ports) {
 967                         dsi_trans = dsi_port_to_transcoder(port);
 968                         intel_de_write(dev_priv, TRANS_VSYNC(dsi_trans),
 969                                        VSYNC_START(vsync_start - 1) | VSYNC_END(vsync_end - 1));
 970                 }
 971         }
 972
 973         /*
 974          * FIXME: It has to be programmed only for video modes and interlaced
 975          * modes. Put the check condition here once interlaced
 976          * info available as described above.
 977          * program TRANS_VSYNCSHIFT register
 978          */
 979         if (is_vid_mode(intel_dsi)) {
 980                 for_each_dsi_port(port, intel_dsi->ports) {
 981                         dsi_trans = dsi_port_to_transcoder(port);
 982                         intel_de_write(dev_priv, TRANS_VSYNCSHIFT(dsi_trans),
 983                                        vsync_shift);
 984                 }
 985         }
 986
 987         /*
 988          * program TRANS_VBLANK register, should be same as vtotal programmed
 989          *
 990          * FIXME get rid of these local hacks and do it right,
 991          * this will not handle eg. delayed vblank correctly.
 992          */
 993         if (DISPLAY_VER(dev_priv) >= 12) {
 994                 for_each_dsi_port(port, intel_dsi->ports) {
 995                         dsi_trans = dsi_port_to_transcoder(port);
 996                         intel_de_write(dev_priv, TRANS_VBLANK(dsi_trans),
 997                                        VBLANK_START(vactive - 1) | VBLANK_END(vtotal - 1));
 998                 }
 999         }
1000 }
1001
1002 static void gen11_dsi_enable_transcoder(struct intel_encoder *encoder)
1003 {
1004         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1005         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1006         enum port port;
1007         enum transcoder dsi_trans;
1008
1009         for_each_dsi_port(port, intel_dsi->ports) {
1010                 dsi_trans = dsi_port_to_transcoder(port);
1011                 intel_de_rmw(dev_priv, TRANSCONF(dsi_trans), 0, TRANSCONF_ENABLE);
1012
1013                 /* wait for transcoder to be enabled */
1014                 if (intel_de_wait_for_set(dev_priv, TRANSCONF(dsi_trans),
1015                                           TRANSCONF_STATE_ENABLE, 10))
1016                         drm_err(&dev_priv->drm,
1017                                 "DSI transcoder not enabled\n");
1018         }
1019 }
1020
1021 static void gen11_dsi_setup_timeouts(struct intel_encoder *encoder,
1022                                      const struct intel_crtc_state *crtc_state)
1023 {
1024         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1025         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1026         enum port port;
1027         enum transcoder dsi_trans;
1028         u32 hs_tx_timeout, lp_rx_timeout, ta_timeout, divisor, mul;
1029
1030         /*
1031          * escape clock count calculation:
1032          * BYTE_CLK_COUNT = TIME_NS/(8 * UI)
1033          * UI (nsec) = (10^6)/Bitrate
1034          * TIME_NS = (BYTE_CLK_COUNT * 8 * 10^6)/ Bitrate
1035          * ESCAPE_CLK_COUNT  = TIME_NS/ESC_CLK_NS
1036          */
1037         divisor = intel_dsi_tlpx_ns(intel_dsi) * afe_clk(encoder, crtc_state) * 1000;
1038         mul = 8 * 1000000;
1039         hs_tx_timeout = DIV_ROUND_UP(intel_dsi->hs_tx_timeout * mul,
1040                                      divisor);
1041         lp_rx_timeout = DIV_ROUND_UP(intel_dsi->lp_rx_timeout * mul, divisor);
1042         ta_timeout = DIV_ROUND_UP(intel_dsi->turn_arnd_val * mul, divisor);
1043
1044         for_each_dsi_port(port, intel_dsi->ports) {
1045                 dsi_trans = dsi_port_to_transcoder(port);
1046
1047                 /* program hst_tx_timeout */
1048                 intel_de_rmw(dev_priv, DSI_HSTX_TO(dsi_trans),
1049                              HSTX_TIMEOUT_VALUE_MASK,
1050                              HSTX_TIMEOUT_VALUE(hs_tx_timeout));
1051
1052                 /* FIXME: DSI_CALIB_TO */
1053
1054                 /* program lp_rx_host timeout */
1055                 intel_de_rmw(dev_priv, DSI_LPRX_HOST_TO(dsi_trans),
1056                              LPRX_TIMEOUT_VALUE_MASK,
1057                              LPRX_TIMEOUT_VALUE(lp_rx_timeout));
1058
1059                 /* FIXME: DSI_PWAIT_TO */
1060
1061                 /* program turn around timeout */
1062                 intel_de_rmw(dev_priv, DSI_TA_TO(dsi_trans),
1063                              TA_TIMEOUT_VALUE_MASK,
1064                              TA_TIMEOUT_VALUE(ta_timeout));
1065         }
1066 }
1067
1068 static void gen11_dsi_config_util_pin(struct intel_encoder *encoder,
1069                                       bool enable)
1070 {
1071         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1072         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1073         u32 tmp;
1074
1075         /*
1076          * used as TE i/p for DSI0,
1077          * for dual link/DSI1 TE is from slave DSI1
1078          * through GPIO.
1079          */
1080         if (is_vid_mode(intel_dsi) || (intel_dsi->ports & BIT(PORT_B)))
1081                 return;
1082
1083         tmp = intel_de_read(dev_priv, UTIL_PIN_CTL);
1084
1085         if (enable) {
1086                 tmp |= UTIL_PIN_DIRECTION_INPUT;
1087                 tmp |= UTIL_PIN_ENABLE;
1088         } else {
1089                 tmp &= ~UTIL_PIN_ENABLE;
1090         }
1091         intel_de_write(dev_priv, UTIL_PIN_CTL, tmp);
1092 }
1093
1094 static void
1095 gen11_dsi_enable_port_and_phy(struct intel_encoder *encoder,
1096                               const struct intel_crtc_state *crtc_state)
1097 {
1098         /* step 4a: power up all lanes of the DDI used by DSI */
1099         gen11_dsi_power_up_lanes(encoder);
1100
1101         /* step 4b: configure lane sequencing of the Combo-PHY transmitters */
1102         gen11_dsi_config_phy_lanes_sequence(encoder);
1103
1104         /* step 4c: configure voltage swing and skew */
1105         gen11_dsi_voltage_swing_program_seq(encoder);
1106
1107         /* setup D-PHY timings */
1108         gen11_dsi_setup_dphy_timings(encoder, crtc_state);
1109
1110         /* enable DDI buffer */
1111         gen11_dsi_enable_ddi_buffer(encoder);
1112
1113         gen11_dsi_gate_clocks(encoder);
1114
1115         gen11_dsi_setup_timings(encoder, crtc_state);
1116
1117         /* Since transcoder is configured to take events from GPIO */
1118         gen11_dsi_config_util_pin(encoder, true);
1119
1120         /* step 4h: setup DSI protocol timeouts */
1121         gen11_dsi_setup_timeouts(encoder, crtc_state);
1122
1123         /* Step (4h, 4i, 4j, 4k): Configure transcoder */
1124         gen11_dsi_configure_transcoder(encoder, crtc_state);
1125 }
1126
1127 static void gen11_dsi_powerup_panel(struct intel_encoder *encoder)
1128 {
1129         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1130         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1131         struct mipi_dsi_device *dsi;
1132         enum port port;
1133         enum transcoder dsi_trans;
1134         u32 tmp;
1135         int ret;
1136
1137         /* set maximum return packet size */
1138         for_each_dsi_port(port, intel_dsi->ports) {
1139                 dsi_trans = dsi_port_to_transcoder(port);
1140
1141                 /*
1142                  * FIXME: This uses the number of DW's currently in the payload
1143                  * receive queue. This is probably not what we want here.
1144                  */
1145                 tmp = intel_de_read(dev_priv, DSI_CMD_RXCTL(dsi_trans));
1146                 tmp &= NUMBER_RX_PLOAD_DW_MASK;
1147                 /* multiply "Number Rx Payload DW" by 4 to get max value */
1148                 tmp = tmp * 4;
1149                 dsi = intel_dsi->dsi_hosts[port]->device;
1150                 ret = mipi_dsi_set_maximum_return_packet_size(dsi, tmp);
1151                 if (ret < 0)
1152                         drm_err(&dev_priv->drm,
1153                                 "error setting max return pkt size%d\n", tmp);
1154         }
1155
1156         intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_INIT_OTP);
1157
1158         /* ensure all panel commands dispatched before enabling transcoder */
1159         wait_for_cmds_dispatched_to_panel(encoder);
1160 }
1161
1162 static void gen11_dsi_pre_pll_enable(struct intel_atomic_state *state,
1163                                      struct intel_encoder *encoder,
1164                                      const struct intel_crtc_state *crtc_state,
1165                                      const struct drm_connector_state *conn_state)
1166 {
1167         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1168
1169         intel_dsi_wait_panel_power_cycle(intel_dsi);
1170
1171         intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_POWER_ON);
1172         msleep(intel_dsi->panel_on_delay);
1173         intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_DEASSERT_RESET);
1174
1175         /* step2: enable IO power */
1176         gen11_dsi_enable_io_power(encoder);
1177
1178         /* step3: enable DSI PLL */
1179         gen11_dsi_program_esc_clk_div(encoder, crtc_state);
1180 }
1181
1182 static void gen11_dsi_pre_enable(struct intel_atomic_state *state,
1183                                  struct intel_encoder *encoder,
1184                                  const struct intel_crtc_state *pipe_config,
1185                                  const struct drm_connector_state *conn_state)
1186 {
1187         /* step3b */
1188         gen11_dsi_map_pll(encoder, pipe_config);
1189
1190         /* step4: enable DSI port and DPHY */
1191         gen11_dsi_enable_port_and_phy(encoder, pipe_config);
1192
1193         /* step5: program and powerup panel */
1194         gen11_dsi_powerup_panel(encoder);
1195
1196         intel_dsc_dsi_pps_write(encoder, pipe_config);
1197
1198         /* step6c: configure transcoder timings */
1199         gen11_dsi_set_transcoder_timings(encoder, pipe_config);
1200 }
1201
1202 /*
1203  * Wa_1409054076:icl,jsl,ehl
1204  * When pipe A is disabled and MIPI DSI is enabled on pipe B,
1205  * the AMT KVMR feature will incorrectly see pipe A as enabled.
1206  * Set 0x42080 bit 23=1 before enabling DSI on pipe B and leave
1207  * it set while DSI is enabled on pipe B
1208  */
1209 static void icl_apply_kvmr_pipe_a_wa(struct intel_encoder *encoder,
1210                                      enum pipe pipe, bool enable)
1211 {
1212         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1213
1214         if (DISPLAY_VER(dev_priv) == 11 && pipe == PIPE_B)
1215                 intel_de_rmw(dev_priv, CHICKEN_PAR1_1,
1216                              IGNORE_KVMR_PIPE_A,
1217                              enable ? IGNORE_KVMR_PIPE_A : 0);
1218 }
1219
1220 /*
1221  * Wa_16012360555:adl-p
1222  * SW will have to program the "LP to HS Wakeup Guardband"
1223  * to account for the repeaters on the HS Request/Ready
1224  * PPI signaling between the Display engine and the DPHY.
1225  */
1226 static void adlp_set_lp_hs_wakeup_gb(struct intel_encoder *encoder)
1227 {
1228         struct drm_i915_private *i915 = to_i915(encoder->base.dev);
1229         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1230         enum port port;
1231
1232         if (DISPLAY_VER(i915) == 13) {
1233                 for_each_dsi_port(port, intel_dsi->ports)
1234                         intel_de_rmw(i915, TGL_DSI_CHKN_REG(port),
1235                                      TGL_DSI_CHKN_LSHS_GB_MASK,
1236                                      TGL_DSI_CHKN_LSHS_GB(4));
1237         }
1238 }
1239
1240 static void gen11_dsi_enable(struct intel_atomic_state *state,
1241                              struct intel_encoder *encoder,
1242                              const struct intel_crtc_state *crtc_state,
1243                              const struct drm_connector_state *conn_state)
1244 {
1245         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1246         struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
1247
1248         drm_WARN_ON(state->base.dev, crtc_state->has_pch_encoder);
1249
1250         /* Wa_1409054076:icl,jsl,ehl */
1251         icl_apply_kvmr_pipe_a_wa(encoder, crtc->pipe, true);
1252
1253         /* Wa_16012360555:adl-p */
1254         adlp_set_lp_hs_wakeup_gb(encoder);
1255
1256         /* step6d: enable dsi transcoder */
1257         gen11_dsi_enable_transcoder(encoder);
1258
1259         intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_DISPLAY_ON);
1260
1261         /* step7: enable backlight */
1262         intel_backlight_enable(crtc_state, conn_state);
1263         intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_ON);
1264
1265         intel_crtc_vblank_on(crtc_state);
1266 }
1267
1268 static void gen11_dsi_disable_transcoder(struct intel_encoder *encoder)
1269 {
1270         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1271         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1272         enum port port;
1273         enum transcoder dsi_trans;
1274
1275         for_each_dsi_port(port, intel_dsi->ports) {
1276                 dsi_trans = dsi_port_to_transcoder(port);
1277
1278                 /* disable transcoder */
1279                 intel_de_rmw(dev_priv, TRANSCONF(dsi_trans), TRANSCONF_ENABLE, 0);
1280
1281                 /* wait for transcoder to be disabled */
1282                 if (intel_de_wait_for_clear(dev_priv, TRANSCONF(dsi_trans),
1283                                             TRANSCONF_STATE_ENABLE, 50))
1284                         drm_err(&dev_priv->drm,
1285                                 "DSI trancoder not disabled\n");
1286         }
1287 }
1288
1289 static void gen11_dsi_powerdown_panel(struct intel_encoder *encoder)
1290 {
1291         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1292
1293         intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_DISPLAY_OFF);
1294
1295         /* ensure cmds dispatched to panel */
1296         wait_for_cmds_dispatched_to_panel(encoder);
1297 }
1298
1299 static void gen11_dsi_deconfigure_trancoder(struct intel_encoder *encoder)
1300 {
1301         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1302         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1303         enum port port;
1304         enum transcoder dsi_trans;
1305         u32 tmp;
1306
1307         /* disable periodic update mode */
1308         if (is_cmd_mode(intel_dsi)) {
1309                 for_each_dsi_port(port, intel_dsi->ports)
1310                         intel_de_rmw(dev_priv, DSI_CMD_FRMCTL(port),
1311                                      DSI_PERIODIC_FRAME_UPDATE_ENABLE, 0);
1312         }
1313
1314         /* put dsi link in ULPS */
1315         for_each_dsi_port(port, intel_dsi->ports) {
1316                 dsi_trans = dsi_port_to_transcoder(port);
1317                 tmp = intel_de_read(dev_priv, DSI_LP_MSG(dsi_trans));
1318                 tmp |= LINK_ENTER_ULPS;
1319                 tmp &= ~LINK_ULPS_TYPE_LP11;
1320                 intel_de_write(dev_priv, DSI_LP_MSG(dsi_trans), tmp);
1321
1322                 if (wait_for_us((intel_de_read(dev_priv, DSI_LP_MSG(dsi_trans)) &
1323                                  LINK_IN_ULPS),
1324                                 10))
1325                         drm_err(&dev_priv->drm, "DSI link not in ULPS\n");
1326         }
1327
1328         /* disable ddi function */
1329         for_each_dsi_port(port, intel_dsi->ports) {
1330                 dsi_trans = dsi_port_to_transcoder(port);
1331                 intel_de_rmw(dev_priv, TRANS_DDI_FUNC_CTL(dsi_trans),
1332                              TRANS_DDI_FUNC_ENABLE, 0);
1333         }
1334
1335         /* disable port sync mode if dual link */
1336         if (intel_dsi->dual_link) {
1337                 for_each_dsi_port(port, intel_dsi->ports) {
1338                         dsi_trans = dsi_port_to_transcoder(port);
1339                         intel_de_rmw(dev_priv, TRANS_DDI_FUNC_CTL2(dsi_trans),
1340                                      PORT_SYNC_MODE_ENABLE, 0);
1341                 }
1342         }
1343 }
1344
1345 static void gen11_dsi_disable_port(struct intel_encoder *encoder)
1346 {
1347         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1348         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1349         enum port port;
1350
1351         gen11_dsi_ungate_clocks(encoder);
1352         for_each_dsi_port(port, intel_dsi->ports) {
1353                 intel_de_rmw(dev_priv, DDI_BUF_CTL(port), DDI_BUF_CTL_ENABLE, 0);
1354
1355                 if (wait_for_us((intel_de_read(dev_priv, DDI_BUF_CTL(port)) &
1356                                  DDI_BUF_IS_IDLE),
1357                                  8))
1358                         drm_err(&dev_priv->drm,
1359                                 "DDI port:%c buffer not idle\n",
1360                                 port_name(port));
1361         }
1362         gen11_dsi_gate_clocks(encoder);
1363 }
1364
1365 static void gen11_dsi_disable_io_power(struct intel_encoder *encoder)
1366 {
1367         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1368         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1369         enum port port;
1370
1371         for_each_dsi_port(port, intel_dsi->ports) {
1372                 intel_wakeref_t wakeref;
1373
1374                 wakeref = fetch_and_zero(&intel_dsi->io_wakeref[port]);
1375                 intel_display_power_put(dev_priv,
1376                                         port == PORT_A ?
1377                                         POWER_DOMAIN_PORT_DDI_IO_A :
1378                                         POWER_DOMAIN_PORT_DDI_IO_B,
1379                                         wakeref);
1380         }
1381
1382         /* set mode to DDI */
1383         for_each_dsi_port(port, intel_dsi->ports)
1384                 intel_de_rmw(dev_priv, ICL_DSI_IO_MODECTL(port),
1385                              COMBO_PHY_MODE_DSI, 0);
1386 }
1387
1388 static void gen11_dsi_disable(struct intel_atomic_state *state,
1389                               struct intel_encoder *encoder,
1390                               const struct intel_crtc_state *old_crtc_state,
1391                               const struct drm_connector_state *old_conn_state)
1392 {
1393         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1394
1395         /* step1: turn off backlight */
1396         intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_OFF);
1397         intel_backlight_disable(old_conn_state);
1398 }
1399
1400 static void gen11_dsi_post_disable(struct intel_atomic_state *state,
1401                                    struct intel_encoder *encoder,
1402                                    const struct intel_crtc_state *old_crtc_state,
1403                                    const struct drm_connector_state *old_conn_state)
1404 {
1405         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1406         struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
1407
1408         intel_crtc_vblank_off(old_crtc_state);
1409
1410         /* step2d,e: disable transcoder and wait */
1411         gen11_dsi_disable_transcoder(encoder);
1412
1413         /* Wa_1409054076:icl,jsl,ehl */
1414         icl_apply_kvmr_pipe_a_wa(encoder, crtc->pipe, false);
1415
1416         /* step2f,g: powerdown panel */
1417         gen11_dsi_powerdown_panel(encoder);
1418
1419         /* step2h,i,j: deconfig trancoder */
1420         gen11_dsi_deconfigure_trancoder(encoder);
1421
1422         intel_dsc_disable(old_crtc_state);
1423         skl_scaler_disable(old_crtc_state);
1424
1425         /* step3: disable port */
1426         gen11_dsi_disable_port(encoder);
1427
1428         gen11_dsi_config_util_pin(encoder, false);
1429
1430         /* step4: disable IO power */
1431         gen11_dsi_disable_io_power(encoder);
1432
1433         intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_ASSERT_RESET);
1434
1435         msleep(intel_dsi->panel_off_delay);
1436         intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_POWER_OFF);
1437
1438         intel_dsi->panel_power_off_time = ktime_get_boottime();
1439 }
1440
1441 static enum drm_mode_status gen11_dsi_mode_valid(struct drm_connector *connector,
1442                                                  struct drm_display_mode *mode)
1443 {
1444         /* FIXME: DSC? */
1445         return intel_dsi_mode_valid(connector, mode);
1446 }
1447
1448 static void gen11_dsi_get_timings(struct intel_encoder *encoder,
1449                                   struct intel_crtc_state *pipe_config)
1450 {
1451         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1452         struct drm_display_mode *adjusted_mode =
1453                                         &pipe_config->hw.adjusted_mode;
1454
1455         if (pipe_config->dsc.compressed_bpp) {
1456                 int div = pipe_config->dsc.compressed_bpp;
1457                 int mul = mipi_dsi_pixel_format_to_bpp(intel_dsi->pixel_format);
1458
1459                 adjusted_mode->crtc_htotal =
1460                         DIV_ROUND_UP(adjusted_mode->crtc_htotal * mul, div);
1461                 adjusted_mode->crtc_hsync_start =
1462                         DIV_ROUND_UP(adjusted_mode->crtc_hsync_start * mul, div);
1463                 adjusted_mode->crtc_hsync_end =
1464                         DIV_ROUND_UP(adjusted_mode->crtc_hsync_end * mul, div);
1465         }
1466
1467         if (intel_dsi->dual_link) {
1468                 adjusted_mode->crtc_hdisplay *= 2;
1469                 if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK)
1470                         adjusted_mode->crtc_hdisplay -=
1471                                                 intel_dsi->pixel_overlap;
1472                 adjusted_mode->crtc_htotal *= 2;
1473         }
1474         adjusted_mode->crtc_hblank_start = adjusted_mode->crtc_hdisplay;
1475         adjusted_mode->crtc_hblank_end = adjusted_mode->crtc_htotal;
1476
1477         if (intel_dsi->operation_mode == INTEL_DSI_VIDEO_MODE) {
1478                 if (intel_dsi->dual_link) {
1479                         adjusted_mode->crtc_hsync_start *= 2;
1480                         adjusted_mode->crtc_hsync_end *= 2;
1481                 }
1482         }
1483         adjusted_mode->crtc_vblank_start = adjusted_mode->crtc_vdisplay;
1484         adjusted_mode->crtc_vblank_end = adjusted_mode->crtc_vtotal;
1485 }
1486
1487 static bool gen11_dsi_is_periodic_cmd_mode(struct intel_dsi *intel_dsi)
1488 {
1489         struct drm_device *dev = intel_dsi->base.base.dev;
1490         struct drm_i915_private *dev_priv = to_i915(dev);
1491         enum transcoder dsi_trans;
1492         u32 val;
1493
1494         if (intel_dsi->ports == BIT(PORT_B))
1495                 dsi_trans = TRANSCODER_DSI_1;
1496         else
1497                 dsi_trans = TRANSCODER_DSI_0;
1498
1499         val = intel_de_read(dev_priv, DSI_TRANS_FUNC_CONF(dsi_trans));
1500         return (val & DSI_PERIODIC_FRAME_UPDATE_ENABLE);
1501 }
1502
1503 static void gen11_dsi_get_cmd_mode_config(struct intel_dsi *intel_dsi,
1504                                           struct intel_crtc_state *pipe_config)
1505 {
1506         if (intel_dsi->ports == (BIT(PORT_B) | BIT(PORT_A)))
1507                 pipe_config->mode_flags |= I915_MODE_FLAG_DSI_USE_TE1 |
1508                                             I915_MODE_FLAG_DSI_USE_TE0;
1509         else if (intel_dsi->ports == BIT(PORT_B))
1510                 pipe_config->mode_flags |= I915_MODE_FLAG_DSI_USE_TE1;
1511         else
1512                 pipe_config->mode_flags |= I915_MODE_FLAG_DSI_USE_TE0;
1513 }
1514
1515 static void gen11_dsi_get_config(struct intel_encoder *encoder,
1516                                  struct intel_crtc_state *pipe_config)
1517 {
1518         struct intel_crtc *crtc = to_intel_crtc(pipe_config->uapi.crtc);
1519         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1520
1521         intel_ddi_get_clock(encoder, pipe_config, icl_ddi_combo_get_pll(encoder));
1522
1523         pipe_config->hw.adjusted_mode.crtc_clock = intel_dsi->pclk;
1524         if (intel_dsi->dual_link)
1525                 pipe_config->hw.adjusted_mode.crtc_clock *= 2;
1526
1527         gen11_dsi_get_timings(encoder, pipe_config);
1528         pipe_config->output_types |= BIT(INTEL_OUTPUT_DSI);
1529         pipe_config->pipe_bpp = bdw_get_pipe_misc_bpp(crtc);
1530
1531         /* Get the details on which TE should be enabled */
1532         if (is_cmd_mode(intel_dsi))
1533                 gen11_dsi_get_cmd_mode_config(intel_dsi, pipe_config);
1534
1535         if (gen11_dsi_is_periodic_cmd_mode(intel_dsi))
1536                 pipe_config->mode_flags |= I915_MODE_FLAG_DSI_PERIODIC_CMD_MODE;
1537 }
1538
1539 static void gen11_dsi_sync_state(struct intel_encoder *encoder,
1540                                  const struct intel_crtc_state *crtc_state)
1541 {
1542         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1543         struct intel_crtc *intel_crtc;
1544         enum pipe pipe;
1545
1546         if (!crtc_state)
1547                 return;
1548
1549         intel_crtc = to_intel_crtc(crtc_state->uapi.crtc);
1550         pipe = intel_crtc->pipe;
1551
1552         /* wa verify 1409054076:icl,jsl,ehl */
1553         if (DISPLAY_VER(dev_priv) == 11 && pipe == PIPE_B &&
1554             !(intel_de_read(dev_priv, CHICKEN_PAR1_1) & IGNORE_KVMR_PIPE_A))
1555                 drm_dbg_kms(&dev_priv->drm,
1556                             "[ENCODER:%d:%s] BIOS left IGNORE_KVMR_PIPE_A cleared with pipe B enabled\n",
1557                             encoder->base.base.id,
1558                             encoder->base.name);
1559 }
1560
1561 static int gen11_dsi_dsc_compute_config(struct intel_encoder *encoder,
1562                                         struct intel_crtc_state *crtc_state)
1563 {
1564         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1565         struct drm_dsc_config *vdsc_cfg = &crtc_state->dsc.config;
1566         int dsc_max_bpc = DISPLAY_VER(dev_priv) >= 12 ? 12 : 10;
1567         bool use_dsc;
1568         int ret;
1569
1570         use_dsc = intel_bios_get_dsc_params(encoder, crtc_state, dsc_max_bpc);
1571         if (!use_dsc)
1572                 return 0;
1573
1574         if (crtc_state->pipe_bpp < 8 * 3)
1575                 return -EINVAL;
1576
1577         /* FIXME: split only when necessary */
1578         if (crtc_state->dsc.slice_count > 1)
1579                 crtc_state->dsc.dsc_split = true;
1580
1581         /* FIXME: initialize from VBT */
1582         vdsc_cfg->rc_model_size = DSC_RC_MODEL_SIZE_CONST;
1583
1584         vdsc_cfg->pic_height = crtc_state->hw.adjusted_mode.crtc_vdisplay;
1585
1586         ret = intel_dsc_compute_params(crtc_state);
1587         if (ret)
1588                 return ret;
1589
1590         /* DSI specific sanity checks on the common code */
1591         drm_WARN_ON(&dev_priv->drm, vdsc_cfg->vbr_enable);
1592         drm_WARN_ON(&dev_priv->drm, vdsc_cfg->simple_422);
1593         drm_WARN_ON(&dev_priv->drm,
1594                     vdsc_cfg->pic_width % vdsc_cfg->slice_width);
1595         drm_WARN_ON(&dev_priv->drm, vdsc_cfg->slice_height < 8);
1596         drm_WARN_ON(&dev_priv->drm,
1597                     vdsc_cfg->pic_height % vdsc_cfg->slice_height);
1598
1599         ret = drm_dsc_compute_rc_parameters(vdsc_cfg);
1600         if (ret)
1601                 return ret;
1602
1603         crtc_state->dsc.compression_enable = true;
1604
1605         return 0;
1606 }
1607
1608 static int gen11_dsi_compute_config(struct intel_encoder *encoder,
1609                                     struct intel_crtc_state *pipe_config,
1610                                     struct drm_connector_state *conn_state)
1611 {
1612         struct drm_i915_private *i915 = to_i915(encoder->base.dev);
1613         struct intel_dsi *intel_dsi = container_of(encoder, struct intel_dsi,
1614                                                    base);
1615         struct intel_connector *intel_connector = intel_dsi->attached_connector;
1616         struct drm_display_mode *adjusted_mode =
1617                 &pipe_config->hw.adjusted_mode;
1618         int ret;
1619
1620         pipe_config->sink_format = INTEL_OUTPUT_FORMAT_RGB;
1621         pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
1622
1623         ret = intel_panel_compute_config(intel_connector, adjusted_mode);
1624         if (ret)
1625                 return ret;
1626
1627         ret = intel_panel_fitting(pipe_config, conn_state);
1628         if (ret)
1629                 return ret;
1630
1631         adjusted_mode->flags = 0;
1632
1633         /* Dual link goes to trancoder DSI'0' */
1634         if (intel_dsi->ports == BIT(PORT_B))
1635                 pipe_config->cpu_transcoder = TRANSCODER_DSI_1;
1636         else
1637                 pipe_config->cpu_transcoder = TRANSCODER_DSI_0;
1638
1639         if (intel_dsi->pixel_format == MIPI_DSI_FMT_RGB888)
1640                 pipe_config->pipe_bpp = 24;
1641         else
1642                 pipe_config->pipe_bpp = 18;
1643
1644         pipe_config->clock_set = true;
1645
1646         if (gen11_dsi_dsc_compute_config(encoder, pipe_config))
1647                 drm_dbg_kms(&i915->drm, "Attempting to use DSC failed\n");
1648
1649         pipe_config->port_clock = afe_clk(encoder, pipe_config) / 5;
1650
1651         /*
1652          * In case of TE GATE cmd mode, we
1653          * receive TE from the slave if
1654          * dual link is enabled
1655          */
1656         if (is_cmd_mode(intel_dsi))
1657                 gen11_dsi_get_cmd_mode_config(intel_dsi, pipe_config);
1658
1659         return 0;
1660 }
1661
1662 static void gen11_dsi_get_power_domains(struct intel_encoder *encoder,
1663                                         struct intel_crtc_state *crtc_state)
1664 {
1665         struct drm_i915_private *i915 = to_i915(encoder->base.dev);
1666
1667         get_dsi_io_power_domains(i915,
1668                                  enc_to_intel_dsi(encoder));
1669 }
1670
1671 static bool gen11_dsi_get_hw_state(struct intel_encoder *encoder,
1672                                    enum pipe *pipe)
1673 {
1674         struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1675         struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1676         enum transcoder dsi_trans;
1677         intel_wakeref_t wakeref;
1678         enum port port;
1679         bool ret = false;
1680         u32 tmp;
1681
1682         wakeref = intel_display_power_get_if_enabled(dev_priv,
1683                                                      encoder->power_domain);
1684         if (!wakeref)
1685                 return false;
1686
1687         for_each_dsi_port(port, intel_dsi->ports) {
1688                 dsi_trans = dsi_port_to_transcoder(port);
1689                 tmp = intel_de_read(dev_priv, TRANS_DDI_FUNC_CTL(dsi_trans));
1690                 switch (tmp & TRANS_DDI_EDP_INPUT_MASK) {
1691                 case TRANS_DDI_EDP_INPUT_A_ON:
1692                         *pipe = PIPE_A;
1693                         break;
1694                 case TRANS_DDI_EDP_INPUT_B_ONOFF:
1695                         *pipe = PIPE_B;
1696                         break;
1697                 case TRANS_DDI_EDP_INPUT_C_ONOFF:
1698                         *pipe = PIPE_C;
1699                         break;
1700                 case TRANS_DDI_EDP_INPUT_D_ONOFF:
1701                         *pipe = PIPE_D;
1702                         break;
1703                 default:
1704                         drm_err(&dev_priv->drm, "Invalid PIPE input\n");
1705                         goto out;
1706                 }
1707
1708                 tmp = intel_de_read(dev_priv, TRANSCONF(dsi_trans));
1709                 ret = tmp & TRANSCONF_ENABLE;
1710         }
1711 out:
1712         intel_display_power_put(dev_priv, encoder->power_domain, wakeref);
1713         return ret;
1714 }
1715
1716 static bool gen11_dsi_initial_fastset_check(struct intel_encoder *encoder,
1717                                             struct intel_crtc_state *crtc_state)
1718 {
1719         if (crtc_state->dsc.compression_enable) {
1720                 drm_dbg_kms(encoder->base.dev, "Forcing full modeset due to DSC being enabled\n");
1721                 crtc_state->uapi.mode_changed = true;
1722
1723                 return false;
1724         }
1725
1726         return true;
1727 }
1728
1729 static void gen11_dsi_encoder_destroy(struct drm_encoder *encoder)
1730 {
1731         intel_encoder_destroy(encoder);
1732 }
1733
1734 static const struct drm_encoder_funcs gen11_dsi_encoder_funcs = {
1735         .destroy = gen11_dsi_encoder_destroy,
1736 };
1737
1738 static const struct drm_connector_funcs gen11_dsi_connector_funcs = {
1739         .detect = intel_panel_detect,
1740         .late_register = intel_connector_register,
1741         .early_unregister = intel_connector_unregister,
1742         .destroy = intel_connector_destroy,
1743         .fill_modes = drm_helper_probe_single_connector_modes,
1744         .atomic_get_property = intel_digital_connector_atomic_get_property,
1745         .atomic_set_property = intel_digital_connector_atomic_set_property,
1746         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
1747         .atomic_duplicate_state = intel_digital_connector_duplicate_state,
1748 };
1749
1750 static const struct drm_connector_helper_funcs gen11_dsi_connector_helper_funcs = {
1751         .get_modes = intel_dsi_get_modes,
1752         .mode_valid = gen11_dsi_mode_valid,
1753         .atomic_check = intel_digital_connector_atomic_check,
1754 };
1755
1756 static int gen11_dsi_host_attach(struct mipi_dsi_host *host,
1757                                  struct mipi_dsi_device *dsi)
1758 {
1759         return 0;
1760 }
1761
1762 static int gen11_dsi_host_detach(struct mipi_dsi_host *host,
1763                                  struct mipi_dsi_device *dsi)
1764 {
1765         return 0;
1766 }
1767
1768 static ssize_t gen11_dsi_host_transfer(struct mipi_dsi_host *host,
1769                                        const struct mipi_dsi_msg *msg)
1770 {
1771         struct intel_dsi_host *intel_dsi_host = to_intel_dsi_host(host);
1772         struct mipi_dsi_packet dsi_pkt;
1773         ssize_t ret;
1774         bool enable_lpdt = false;
1775
1776         ret = mipi_dsi_create_packet(&dsi_pkt, msg);
1777         if (ret < 0)
1778                 return ret;
1779
1780         if (msg->flags & MIPI_DSI_MSG_USE_LPM)
1781                 enable_lpdt = true;
1782
1783         /* only long packet contains payload */
1784         if (mipi_dsi_packet_format_is_long(msg->type)) {
1785                 ret = dsi_send_pkt_payld(intel_dsi_host, &dsi_pkt);
1786                 if (ret < 0)
1787                         return ret;
1788         }
1789
1790         /* send packet header */
1791         ret  = dsi_send_pkt_hdr(intel_dsi_host, &dsi_pkt, enable_lpdt);
1792         if (ret < 0)
1793                 return ret;
1794
1795         //TODO: add payload receive code if needed
1796
1797         ret = sizeof(dsi_pkt.header) + dsi_pkt.payload_length;
1798
1799         return ret;
1800 }
1801
1802 static const struct mipi_dsi_host_ops gen11_dsi_host_ops = {
1803         .attach = gen11_dsi_host_attach,
1804         .detach = gen11_dsi_host_detach,
1805         .transfer = gen11_dsi_host_transfer,
1806 };
1807
1808 #define ICL_PREPARE_CNT_MAX     0x7
1809 #define ICL_CLK_ZERO_CNT_MAX    0xf
1810 #define ICL_TRAIL_CNT_MAX       0x7
1811 #define ICL_TCLK_PRE_CNT_MAX    0x3
1812 #define ICL_TCLK_POST_CNT_MAX   0x7
1813 #define ICL_HS_ZERO_CNT_MAX     0xf
1814 #define ICL_EXIT_ZERO_CNT_MAX   0x7
1815
1816 static void icl_dphy_param_init(struct intel_dsi *intel_dsi)
1817 {
1818         struct drm_device *dev = intel_dsi->base.base.dev;
1819         struct drm_i915_private *dev_priv = to_i915(dev);
1820         struct intel_connector *connector = intel_dsi->attached_connector;
1821         struct mipi_config *mipi_config = connector->panel.vbt.dsi.config;
1822         u32 tlpx_ns;
1823         u32 prepare_cnt, exit_zero_cnt, clk_zero_cnt, trail_cnt;
1824         u32 ths_prepare_ns, tclk_trail_ns;
1825         u32 hs_zero_cnt;
1826         u32 tclk_pre_cnt, tclk_post_cnt;
1827
1828         tlpx_ns = intel_dsi_tlpx_ns(intel_dsi);
1829
1830         tclk_trail_ns = max(mipi_config->tclk_trail, mipi_config->ths_trail);
1831         ths_prepare_ns = max(mipi_config->ths_prepare,
1832                              mipi_config->tclk_prepare);
1833
1834         /*
1835          * prepare cnt in escape clocks
1836          * this field represents a hexadecimal value with a precision
1837          * of 1.2 – i.e. the most significant bit is the integer
1838          * and the least significant 2 bits are fraction bits.
1839          * so, the field can represent a range of 0.25 to 1.75
1840          */
1841         prepare_cnt = DIV_ROUND_UP(ths_prepare_ns * 4, tlpx_ns);
1842         if (prepare_cnt > ICL_PREPARE_CNT_MAX) {
1843                 drm_dbg_kms(&dev_priv->drm, "prepare_cnt out of range (%d)\n",
1844                             prepare_cnt);
1845                 prepare_cnt = ICL_PREPARE_CNT_MAX;
1846         }
1847
1848         /* clk zero count in escape clocks */
1849         clk_zero_cnt = DIV_ROUND_UP(mipi_config->tclk_prepare_clkzero -
1850                                     ths_prepare_ns, tlpx_ns);
1851         if (clk_zero_cnt > ICL_CLK_ZERO_CNT_MAX) {
1852                 drm_dbg_kms(&dev_priv->drm,
1853                             "clk_zero_cnt out of range (%d)\n", clk_zero_cnt);
1854                 clk_zero_cnt = ICL_CLK_ZERO_CNT_MAX;
1855         }
1856
1857         /* trail cnt in escape clocks*/
1858         trail_cnt = DIV_ROUND_UP(tclk_trail_ns, tlpx_ns);
1859         if (trail_cnt > ICL_TRAIL_CNT_MAX) {
1860                 drm_dbg_kms(&dev_priv->drm, "trail_cnt out of range (%d)\n",
1861                             trail_cnt);
1862                 trail_cnt = ICL_TRAIL_CNT_MAX;
1863         }
1864
1865         /* tclk pre count in escape clocks */
1866         tclk_pre_cnt = DIV_ROUND_UP(mipi_config->tclk_pre, tlpx_ns);
1867         if (tclk_pre_cnt > ICL_TCLK_PRE_CNT_MAX) {
1868                 drm_dbg_kms(&dev_priv->drm,
1869                             "tclk_pre_cnt out of range (%d)\n", tclk_pre_cnt);
1870                 tclk_pre_cnt = ICL_TCLK_PRE_CNT_MAX;
1871         }
1872
1873         /* tclk post count in escape clocks */
1874         tclk_post_cnt = DIV_ROUND_UP(mipi_config->tclk_post, tlpx_ns);
1875         if (tclk_post_cnt > ICL_TCLK_POST_CNT_MAX) {
1876                 drm_dbg_kms(&dev_priv->drm,
1877                             "tclk_post_cnt out of range (%d)\n",
1878                             tclk_post_cnt);
1879                 tclk_post_cnt = ICL_TCLK_POST_CNT_MAX;
1880         }
1881
1882         /* hs zero cnt in escape clocks */
1883         hs_zero_cnt = DIV_ROUND_UP(mipi_config->ths_prepare_hszero -
1884                                    ths_prepare_ns, tlpx_ns);
1885         if (hs_zero_cnt > ICL_HS_ZERO_CNT_MAX) {
1886                 drm_dbg_kms(&dev_priv->drm, "hs_zero_cnt out of range (%d)\n",
1887                             hs_zero_cnt);
1888                 hs_zero_cnt = ICL_HS_ZERO_CNT_MAX;
1889         }
1890
1891         /* hs exit zero cnt in escape clocks */
1892         exit_zero_cnt = DIV_ROUND_UP(mipi_config->ths_exit, tlpx_ns);
1893         if (exit_zero_cnt > ICL_EXIT_ZERO_CNT_MAX) {
1894                 drm_dbg_kms(&dev_priv->drm,
1895                             "exit_zero_cnt out of range (%d)\n",
1896                             exit_zero_cnt);
1897                 exit_zero_cnt = ICL_EXIT_ZERO_CNT_MAX;
1898         }
1899
1900         /* clock lane dphy timings */
1901         intel_dsi->dphy_reg = (CLK_PREPARE_OVERRIDE |
1902                                CLK_PREPARE(prepare_cnt) |
1903                                CLK_ZERO_OVERRIDE |
1904                                CLK_ZERO(clk_zero_cnt) |
1905                                CLK_PRE_OVERRIDE |
1906                                CLK_PRE(tclk_pre_cnt) |
1907                                CLK_POST_OVERRIDE |
1908                                CLK_POST(tclk_post_cnt) |
1909                                CLK_TRAIL_OVERRIDE |
1910                                CLK_TRAIL(trail_cnt));
1911
1912         /* data lanes dphy timings */
1913         intel_dsi->dphy_data_lane_reg = (HS_PREPARE_OVERRIDE |
1914                                          HS_PREPARE(prepare_cnt) |
1915                                          HS_ZERO_OVERRIDE |
1916                                          HS_ZERO(hs_zero_cnt) |
1917                                          HS_TRAIL_OVERRIDE |
1918                                          HS_TRAIL(trail_cnt) |
1919                                          HS_EXIT_OVERRIDE |
1920                                          HS_EXIT(exit_zero_cnt));
1921
1922         intel_dsi_log_params(intel_dsi);
1923 }
1924
1925 static void icl_dsi_add_properties(struct intel_connector *connector)
1926 {
1927         const struct drm_display_mode *fixed_mode =
1928                 intel_panel_preferred_fixed_mode(connector);
1929
1930         intel_attach_scaling_mode_property(&connector->base);
1931
1932         drm_connector_set_panel_orientation_with_quirk(&connector->base,
1933                                                        intel_dsi_get_panel_orientation(connector),
1934                                                        fixed_mode->hdisplay,
1935                                                        fixed_mode->vdisplay);
1936 }
1937
1938 void icl_dsi_init(struct drm_i915_private *dev_priv)
1939 {
1940         struct intel_dsi *intel_dsi;
1941         struct intel_encoder *encoder;
1942         struct intel_connector *intel_connector;
1943         struct drm_connector *connector;
1944         enum port port;
1945
1946         if (!intel_bios_is_dsi_present(dev_priv, &port))
1947                 return;
1948
1949         intel_dsi = kzalloc(sizeof(*intel_dsi), GFP_KERNEL);
1950         if (!intel_dsi)
1951                 return;
1952
1953         intel_connector = intel_connector_alloc();
1954         if (!intel_connector) {
1955                 kfree(intel_dsi);
1956                 return;
1957         }
1958
1959         encoder = &intel_dsi->base;
1960         intel_dsi->attached_connector = intel_connector;
1961         connector = &intel_connector->base;
1962
1963         /* register DSI encoder with DRM subsystem */
1964         drm_encoder_init(&dev_priv->drm, &encoder->base, &gen11_dsi_encoder_funcs,
1965                          DRM_MODE_ENCODER_DSI, "DSI %c", port_name(port));
1966
1967         encoder->pre_pll_enable = gen11_dsi_pre_pll_enable;
1968         encoder->pre_enable = gen11_dsi_pre_enable;
1969         encoder->enable = gen11_dsi_enable;
1970         encoder->disable = gen11_dsi_disable;
1971         encoder->post_disable = gen11_dsi_post_disable;
1972         encoder->port = port;
1973         encoder->get_config = gen11_dsi_get_config;
1974         encoder->sync_state = gen11_dsi_sync_state;
1975         encoder->update_pipe = intel_backlight_update;
1976         encoder->compute_config = gen11_dsi_compute_config;
1977         encoder->get_hw_state = gen11_dsi_get_hw_state;
1978         encoder->initial_fastset_check = gen11_dsi_initial_fastset_check;
1979         encoder->type = INTEL_OUTPUT_DSI;
1980         encoder->cloneable = 0;
1981         encoder->pipe_mask = ~0;
1982         encoder->power_domain = POWER_DOMAIN_PORT_DSI;
1983         encoder->get_power_domains = gen11_dsi_get_power_domains;
1984         encoder->disable_clock = gen11_dsi_gate_clocks;
1985         encoder->is_clock_enabled = gen11_dsi_is_clock_enabled;
1986         encoder->shutdown = intel_dsi_shutdown;
1987
1988         /* register DSI connector with DRM subsystem */
1989         drm_connector_init(&dev_priv->drm, connector, &gen11_dsi_connector_funcs,
1990                            DRM_MODE_CONNECTOR_DSI);
1991         drm_connector_helper_add(connector, &gen11_dsi_connector_helper_funcs);
1992         connector->display_info.subpixel_order = SubPixelHorizontalRGB;
1993         intel_connector->get_hw_state = intel_connector_get_hw_state;
1994
1995         /* attach connector to encoder */
1996         intel_connector_attach_encoder(intel_connector, encoder);
1997
1998         intel_dsi->panel_power_off_time = ktime_get_boottime();
1999
2000         encoder->devdata = intel_bios_encoder_data_lookup(dev_priv, port);
2001         intel_bios_init_panel_late(dev_priv, &intel_connector->panel, encoder->devdata, NULL);
2002
2003         mutex_lock(&dev_priv->drm.mode_config.mutex);
2004         intel_panel_add_vbt_lfp_fixed_mode(intel_connector);
2005         mutex_unlock(&dev_priv->drm.mode_config.mutex);
2006
2007         if (!intel_panel_preferred_fixed_mode(intel_connector)) {
2008                 drm_err(&dev_priv->drm, "DSI fixed mode info missing\n");
2009                 goto err;
2010         }
2011
2012         intel_panel_init(intel_connector, NULL);
2013
2014         intel_backlight_setup(intel_connector, INVALID_PIPE);
2015
2016         if (intel_connector->panel.vbt.dsi.config->dual_link)
2017                 intel_dsi->ports = BIT(PORT_A) | BIT(PORT_B);
2018         else
2019                 intel_dsi->ports = BIT(port);
2020
2021         if (drm_WARN_ON(&dev_priv->drm, intel_connector->panel.vbt.dsi.bl_ports & ~intel_dsi->ports))
2022                 intel_connector->panel.vbt.dsi.bl_ports &= intel_dsi->ports;
2023
2024         if (drm_WARN_ON(&dev_priv->drm, intel_connector->panel.vbt.dsi.cabc_ports & ~intel_dsi->ports))
2025                 intel_connector->panel.vbt.dsi.cabc_ports &= intel_dsi->ports;
2026
2027         for_each_dsi_port(port, intel_dsi->ports) {
2028                 struct intel_dsi_host *host;
2029
2030                 host = intel_dsi_host_init(intel_dsi, &gen11_dsi_host_ops, port);
2031                 if (!host)
2032                         goto err;
2033
2034                 intel_dsi->dsi_hosts[port] = host;
2035         }
2036
2037         if (!intel_dsi_vbt_init(intel_dsi, MIPI_DSI_GENERIC_PANEL_ID)) {
2038                 drm_dbg_kms(&dev_priv->drm, "no device found\n");
2039                 goto err;
2040         }
2041
2042         icl_dphy_param_init(intel_dsi);
2043
2044         icl_dsi_add_properties(intel_connector);
2045         return;
2046
2047 err:
2048         drm_connector_cleanup(connector);
2049         drm_encoder_cleanup(&encoder->base);
2050         kfree(intel_dsi);
2051         kfree(intel_connector);
2052 }