2 * Copyright 2007-8 Advanced Micro Devices, Inc.
3 * Copyright 2008 Red Hat Inc.
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
12 * The above copyright notice and this permission notice shall be included in
13 * all copies or substantial portions of the Software.
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21 * OTHER DEALINGS IN THE SOFTWARE.
23 * Authors: Dave Airlie
27 #include <drm/display/drm_dp_helper.h>
28 #include <drm/drm_edid.h>
29 #include <drm/drm_probe_helper.h>
30 #include <drm/amdgpu_drm.h>
33 #include "atombios_encoders.h"
34 #include "atombios_dp.h"
35 #include "amdgpu_connectors.h"
36 #include "amdgpu_i2c.h"
37 #include "amdgpu_display.h"
39 #include <linux/pm_runtime.h>
41 void amdgpu_connector_hotplug(struct drm_connector *connector)
43 struct drm_device *dev = connector->dev;
44 struct amdgpu_device *adev = drm_to_adev(dev);
45 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
47 /* bail if the connector does not have hpd pin, e.g.,
50 if (amdgpu_connector->hpd.hpd == AMDGPU_HPD_NONE)
53 amdgpu_display_hpd_set_polarity(adev, amdgpu_connector->hpd.hpd);
55 /* if the connector is already off, don't turn it back on */
56 if (connector->dpms != DRM_MODE_DPMS_ON)
59 /* just deal with DP (not eDP) here. */
60 if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) {
61 struct amdgpu_connector_atom_dig *dig_connector =
62 amdgpu_connector->con_priv;
64 /* if existing sink type was not DP no need to retrain */
65 if (dig_connector->dp_sink_type != CONNECTOR_OBJECT_ID_DISPLAYPORT)
68 /* first get sink type as it may be reset after (un)plug */
69 dig_connector->dp_sink_type = amdgpu_atombios_dp_get_sinktype(amdgpu_connector);
70 /* don't do anything if sink is not display port, i.e.,
71 * passive dp->(dvi|hdmi) adaptor
73 if (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT &&
74 amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd) &&
75 amdgpu_atombios_dp_needs_link_train(amdgpu_connector)) {
76 /* Don't start link training before we have the DPCD */
77 if (amdgpu_atombios_dp_get_dpcd(amdgpu_connector))
80 /* Turn the connector off and back on immediately, which
81 * will trigger link training
83 drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
84 drm_helper_connector_dpms(connector, DRM_MODE_DPMS_ON);
89 static void amdgpu_connector_property_change_mode(struct drm_encoder *encoder)
91 struct drm_crtc *crtc = encoder->crtc;
93 if (crtc && crtc->enabled) {
94 drm_crtc_helper_set_mode(crtc, &crtc->mode,
95 crtc->x, crtc->y, crtc->primary->fb);
99 int amdgpu_connector_get_monitor_bpc(struct drm_connector *connector)
101 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
102 struct amdgpu_connector_atom_dig *dig_connector;
104 unsigned mode_clock, max_tmds_clock;
106 switch (connector->connector_type) {
107 case DRM_MODE_CONNECTOR_DVII:
108 case DRM_MODE_CONNECTOR_HDMIB:
109 if (amdgpu_connector->use_digital) {
110 if (connector->display_info.is_hdmi) {
111 if (connector->display_info.bpc)
112 bpc = connector->display_info.bpc;
116 case DRM_MODE_CONNECTOR_DVID:
117 case DRM_MODE_CONNECTOR_HDMIA:
118 if (connector->display_info.is_hdmi) {
119 if (connector->display_info.bpc)
120 bpc = connector->display_info.bpc;
123 case DRM_MODE_CONNECTOR_DisplayPort:
124 dig_connector = amdgpu_connector->con_priv;
125 if ((dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
126 (dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) ||
127 connector->display_info.is_hdmi) {
128 if (connector->display_info.bpc)
129 bpc = connector->display_info.bpc;
132 case DRM_MODE_CONNECTOR_eDP:
133 case DRM_MODE_CONNECTOR_LVDS:
134 if (connector->display_info.bpc)
135 bpc = connector->display_info.bpc;
137 const struct drm_connector_helper_funcs *connector_funcs =
138 connector->helper_private;
139 struct drm_encoder *encoder = connector_funcs->best_encoder(connector);
140 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
141 struct amdgpu_encoder_atom_dig *dig = amdgpu_encoder->enc_priv;
143 if (dig->lcd_misc & ATOM_PANEL_MISC_V13_6BIT_PER_COLOR)
145 else if (dig->lcd_misc & ATOM_PANEL_MISC_V13_8BIT_PER_COLOR)
151 if (connector->display_info.is_hdmi) {
153 * Pre DCE-8 hw can't handle > 12 bpc, and more than 12 bpc doesn't make
154 * much sense without support for > 12 bpc framebuffers. RGB 4:4:4 at
155 * 12 bpc is always supported on hdmi deep color sinks, as this is
156 * required by the HDMI-1.3 spec. Clamp to a safe 12 bpc maximum.
159 DRM_DEBUG("%s: HDMI deep color %d bpc unsupported. Using 12 bpc.\n",
160 connector->name, bpc);
164 /* Any defined maximum tmds clock limit we must not exceed? */
165 if (connector->display_info.max_tmds_clock > 0) {
166 /* mode_clock is clock in kHz for mode to be modeset on this connector */
167 mode_clock = amdgpu_connector->pixelclock_for_modeset;
169 /* Maximum allowable input clock in kHz */
170 max_tmds_clock = connector->display_info.max_tmds_clock;
172 DRM_DEBUG("%s: hdmi mode dotclock %d kHz, max tmds input clock %d kHz.\n",
173 connector->name, mode_clock, max_tmds_clock);
175 /* Check if bpc is within clock limit. Try to degrade gracefully otherwise */
176 if ((bpc == 12) && (mode_clock * 3/2 > max_tmds_clock)) {
177 if ((connector->display_info.edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_30) &&
178 (mode_clock * 5/4 <= max_tmds_clock))
183 DRM_DEBUG("%s: HDMI deep color 12 bpc exceeds max tmds clock. Using %d bpc.\n",
184 connector->name, bpc);
187 if ((bpc == 10) && (mode_clock * 5/4 > max_tmds_clock)) {
189 DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using %d bpc.\n",
190 connector->name, bpc);
192 } else if (bpc > 8) {
193 /* max_tmds_clock missing, but hdmi spec mandates it for deep color. */
194 DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing. Using 8 bpc.\n",
200 if ((amdgpu_deep_color == 0) && (bpc > 8)) {
201 DRM_DEBUG("%s: Deep color disabled. Set amdgpu module param deep_color=1 to enable.\n",
206 DRM_DEBUG("%s: Display bpc=%d, returned bpc=%d\n",
207 connector->name, connector->display_info.bpc, bpc);
213 amdgpu_connector_update_scratch_regs(struct drm_connector *connector,
214 enum drm_connector_status status)
216 struct drm_encoder *best_encoder;
217 struct drm_encoder *encoder;
218 const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
221 best_encoder = connector_funcs->best_encoder(connector);
223 drm_connector_for_each_possible_encoder(connector, encoder) {
224 if ((encoder == best_encoder) && (status == connector_status_connected))
229 amdgpu_atombios_encoder_set_bios_scratch_regs(connector, encoder, connected);
233 static struct drm_encoder *
234 amdgpu_connector_find_encoder(struct drm_connector *connector,
237 struct drm_encoder *encoder;
239 drm_connector_for_each_possible_encoder(connector, encoder) {
240 if (encoder->encoder_type == encoder_type)
247 struct edid *amdgpu_connector_edid(struct drm_connector *connector)
249 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
250 struct drm_property_blob *edid_blob = connector->edid_blob_ptr;
252 if (amdgpu_connector->edid) {
253 return amdgpu_connector->edid;
254 } else if (edid_blob) {
255 struct edid *edid = kmemdup(edid_blob->data, edid_blob->length, GFP_KERNEL);
257 amdgpu_connector->edid = edid;
259 return amdgpu_connector->edid;
263 amdgpu_connector_get_hardcoded_edid(struct amdgpu_device *adev)
267 if (adev->mode_info.bios_hardcoded_edid) {
268 edid = kmalloc(adev->mode_info.bios_hardcoded_edid_size, GFP_KERNEL);
270 memcpy((unsigned char *)edid,
271 (unsigned char *)adev->mode_info.bios_hardcoded_edid,
272 adev->mode_info.bios_hardcoded_edid_size);
279 static void amdgpu_connector_get_edid(struct drm_connector *connector)
281 struct drm_device *dev = connector->dev;
282 struct amdgpu_device *adev = drm_to_adev(dev);
283 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
285 if (amdgpu_connector->edid)
288 /* on hw with routers, select right port */
289 if (amdgpu_connector->router.ddc_valid)
290 amdgpu_i2c_router_select_ddc_port(amdgpu_connector);
292 if ((amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
293 ENCODER_OBJECT_ID_NONE) &&
294 amdgpu_connector->ddc_bus->has_aux) {
295 amdgpu_connector->edid = drm_get_edid(connector,
296 &amdgpu_connector->ddc_bus->aux.ddc);
297 } else if ((connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) ||
298 (connector->connector_type == DRM_MODE_CONNECTOR_eDP)) {
299 struct amdgpu_connector_atom_dig *dig = amdgpu_connector->con_priv;
301 if ((dig->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT ||
302 dig->dp_sink_type == CONNECTOR_OBJECT_ID_eDP) &&
303 amdgpu_connector->ddc_bus->has_aux)
304 amdgpu_connector->edid = drm_get_edid(connector,
305 &amdgpu_connector->ddc_bus->aux.ddc);
306 else if (amdgpu_connector->ddc_bus)
307 amdgpu_connector->edid = drm_get_edid(connector,
308 &amdgpu_connector->ddc_bus->adapter);
309 } else if (amdgpu_connector->ddc_bus) {
310 amdgpu_connector->edid = drm_get_edid(connector,
311 &amdgpu_connector->ddc_bus->adapter);
314 if (!amdgpu_connector->edid) {
315 /* some laptops provide a hardcoded edid in rom for LCDs */
316 if (((connector->connector_type == DRM_MODE_CONNECTOR_LVDS) ||
317 (connector->connector_type == DRM_MODE_CONNECTOR_eDP))) {
318 amdgpu_connector->edid = amdgpu_connector_get_hardcoded_edid(adev);
319 drm_connector_update_edid_property(connector, amdgpu_connector->edid);
324 static void amdgpu_connector_free_edid(struct drm_connector *connector)
326 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
328 kfree(amdgpu_connector->edid);
329 amdgpu_connector->edid = NULL;
332 static int amdgpu_connector_ddc_get_modes(struct drm_connector *connector)
334 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
337 if (amdgpu_connector->edid) {
338 drm_connector_update_edid_property(connector, amdgpu_connector->edid);
339 ret = drm_add_edid_modes(connector, amdgpu_connector->edid);
342 drm_connector_update_edid_property(connector, NULL);
346 static struct drm_encoder *
347 amdgpu_connector_best_single_encoder(struct drm_connector *connector)
349 struct drm_encoder *encoder;
351 /* pick the first one */
352 drm_connector_for_each_possible_encoder(connector, encoder)
358 static void amdgpu_get_native_mode(struct drm_connector *connector)
360 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
361 struct amdgpu_encoder *amdgpu_encoder;
366 amdgpu_encoder = to_amdgpu_encoder(encoder);
368 if (!list_empty(&connector->probed_modes)) {
369 struct drm_display_mode *preferred_mode =
370 list_first_entry(&connector->probed_modes,
371 struct drm_display_mode, head);
373 amdgpu_encoder->native_mode = *preferred_mode;
375 amdgpu_encoder->native_mode.clock = 0;
379 static struct drm_display_mode *
380 amdgpu_connector_lcd_native_mode(struct drm_encoder *encoder)
382 struct drm_device *dev = encoder->dev;
383 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
384 struct drm_display_mode *mode = NULL;
385 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
387 if (native_mode->hdisplay != 0 &&
388 native_mode->vdisplay != 0 &&
389 native_mode->clock != 0) {
390 mode = drm_mode_duplicate(dev, native_mode);
394 mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
395 drm_mode_set_name(mode);
397 DRM_DEBUG_KMS("Adding native panel mode %s\n", mode->name);
398 } else if (native_mode->hdisplay != 0 &&
399 native_mode->vdisplay != 0) {
400 /* mac laptops without an edid */
401 /* Note that this is not necessarily the exact panel mode,
402 * but an approximation based on the cvt formula. For these
403 * systems we should ideally read the mode info out of the
404 * registers or add a mode table, but this works and is much
407 mode = drm_cvt_mode(dev, native_mode->hdisplay, native_mode->vdisplay, 60, true, false, false);
411 mode->type = DRM_MODE_TYPE_PREFERRED | DRM_MODE_TYPE_DRIVER;
412 DRM_DEBUG_KMS("Adding cvt approximation of native panel mode %s\n", mode->name);
417 static void amdgpu_connector_add_common_modes(struct drm_encoder *encoder,
418 struct drm_connector *connector)
420 struct drm_device *dev = encoder->dev;
421 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
422 struct drm_display_mode *mode = NULL;
423 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
425 static const struct mode_size {
428 } common_modes[17] = {
448 for (i = 0; i < 17; i++) {
449 if (amdgpu_encoder->devices & (ATOM_DEVICE_TV_SUPPORT)) {
450 if (common_modes[i].w > 1024 ||
451 common_modes[i].h > 768)
454 if (amdgpu_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
455 if (common_modes[i].w > native_mode->hdisplay ||
456 common_modes[i].h > native_mode->vdisplay ||
457 (common_modes[i].w == native_mode->hdisplay &&
458 common_modes[i].h == native_mode->vdisplay))
461 if (common_modes[i].w < 320 || common_modes[i].h < 200)
464 mode = drm_cvt_mode(dev, common_modes[i].w, common_modes[i].h, 60, false, false, false);
465 drm_mode_probed_add(connector, mode);
469 static int amdgpu_connector_set_property(struct drm_connector *connector,
470 struct drm_property *property,
473 struct drm_device *dev = connector->dev;
474 struct amdgpu_device *adev = drm_to_adev(dev);
475 struct drm_encoder *encoder;
476 struct amdgpu_encoder *amdgpu_encoder;
478 if (property == adev->mode_info.coherent_mode_property) {
479 struct amdgpu_encoder_atom_dig *dig;
480 bool new_coherent_mode;
482 /* need to find digital encoder on connector */
483 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
487 amdgpu_encoder = to_amdgpu_encoder(encoder);
489 if (!amdgpu_encoder->enc_priv)
492 dig = amdgpu_encoder->enc_priv;
493 new_coherent_mode = val ? true : false;
494 if (dig->coherent_mode != new_coherent_mode) {
495 dig->coherent_mode = new_coherent_mode;
496 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
500 if (property == adev->mode_info.audio_property) {
501 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
502 /* need to find digital encoder on connector */
503 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
507 amdgpu_encoder = to_amdgpu_encoder(encoder);
509 if (amdgpu_connector->audio != val) {
510 amdgpu_connector->audio = val;
511 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
515 if (property == adev->mode_info.dither_property) {
516 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
517 /* need to find digital encoder on connector */
518 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
522 amdgpu_encoder = to_amdgpu_encoder(encoder);
524 if (amdgpu_connector->dither != val) {
525 amdgpu_connector->dither = val;
526 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
530 if (property == adev->mode_info.underscan_property) {
531 /* need to find digital encoder on connector */
532 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
536 amdgpu_encoder = to_amdgpu_encoder(encoder);
538 if (amdgpu_encoder->underscan_type != val) {
539 amdgpu_encoder->underscan_type = val;
540 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
544 if (property == adev->mode_info.underscan_hborder_property) {
545 /* need to find digital encoder on connector */
546 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
550 amdgpu_encoder = to_amdgpu_encoder(encoder);
552 if (amdgpu_encoder->underscan_hborder != val) {
553 amdgpu_encoder->underscan_hborder = val;
554 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
558 if (property == adev->mode_info.underscan_vborder_property) {
559 /* need to find digital encoder on connector */
560 encoder = amdgpu_connector_find_encoder(connector, DRM_MODE_ENCODER_TMDS);
564 amdgpu_encoder = to_amdgpu_encoder(encoder);
566 if (amdgpu_encoder->underscan_vborder != val) {
567 amdgpu_encoder->underscan_vborder = val;
568 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
572 if (property == adev->mode_info.load_detect_property) {
573 struct amdgpu_connector *amdgpu_connector =
574 to_amdgpu_connector(connector);
577 amdgpu_connector->dac_load_detect = false;
579 amdgpu_connector->dac_load_detect = true;
582 if (property == dev->mode_config.scaling_mode_property) {
583 enum amdgpu_rmx_type rmx_type;
585 if (connector->encoder) {
586 amdgpu_encoder = to_amdgpu_encoder(connector->encoder);
588 const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
589 amdgpu_encoder = to_amdgpu_encoder(connector_funcs->best_encoder(connector));
594 case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
595 case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
596 case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
597 case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
599 if (amdgpu_encoder->rmx_type == rmx_type)
602 if ((rmx_type != DRM_MODE_SCALE_NONE) &&
603 (amdgpu_encoder->native_mode.clock == 0))
606 amdgpu_encoder->rmx_type = rmx_type;
608 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
615 amdgpu_connector_fixup_lcd_native_mode(struct drm_encoder *encoder,
616 struct drm_connector *connector)
618 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
619 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
620 struct drm_display_mode *t, *mode;
622 /* If the EDID preferred mode doesn't match the native mode, use it */
623 list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
624 if (mode->type & DRM_MODE_TYPE_PREFERRED) {
625 if (mode->hdisplay != native_mode->hdisplay ||
626 mode->vdisplay != native_mode->vdisplay)
627 drm_mode_copy(native_mode, mode);
631 /* Try to get native mode details from EDID if necessary */
632 if (!native_mode->clock) {
633 list_for_each_entry_safe(mode, t, &connector->probed_modes, head) {
634 if (mode->hdisplay == native_mode->hdisplay &&
635 mode->vdisplay == native_mode->vdisplay) {
636 drm_mode_copy(native_mode, mode);
637 drm_mode_set_crtcinfo(native_mode, CRTC_INTERLACE_HALVE_V);
638 DRM_DEBUG_KMS("Determined LVDS native mode details from EDID\n");
644 if (!native_mode->clock) {
645 DRM_DEBUG_KMS("No LVDS native mode details, disabling RMX\n");
646 amdgpu_encoder->rmx_type = RMX_OFF;
650 static int amdgpu_connector_lvds_get_modes(struct drm_connector *connector)
652 struct drm_encoder *encoder;
654 struct drm_display_mode *mode;
656 amdgpu_connector_get_edid(connector);
657 ret = amdgpu_connector_ddc_get_modes(connector);
659 encoder = amdgpu_connector_best_single_encoder(connector);
661 amdgpu_connector_fixup_lcd_native_mode(encoder, connector);
662 /* add scaled modes */
663 amdgpu_connector_add_common_modes(encoder, connector);
668 encoder = amdgpu_connector_best_single_encoder(connector);
672 /* we have no EDID modes */
673 mode = amdgpu_connector_lcd_native_mode(encoder);
676 drm_mode_probed_add(connector, mode);
677 /* add the width/height from vbios tables if available */
678 connector->display_info.width_mm = mode->width_mm;
679 connector->display_info.height_mm = mode->height_mm;
680 /* add scaled modes */
681 amdgpu_connector_add_common_modes(encoder, connector);
687 static enum drm_mode_status amdgpu_connector_lvds_mode_valid(struct drm_connector *connector,
688 struct drm_display_mode *mode)
690 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
692 if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
696 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
697 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
699 /* AVIVO hardware supports downscaling modes larger than the panel
700 * to the panel size, but I'm not sure this is desirable.
702 if ((mode->hdisplay > native_mode->hdisplay) ||
703 (mode->vdisplay > native_mode->vdisplay))
706 /* if scaling is disabled, block non-native modes */
707 if (amdgpu_encoder->rmx_type == RMX_OFF) {
708 if ((mode->hdisplay != native_mode->hdisplay) ||
709 (mode->vdisplay != native_mode->vdisplay))
717 static enum drm_connector_status
718 amdgpu_connector_lvds_detect(struct drm_connector *connector, bool force)
720 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
721 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
722 enum drm_connector_status ret = connector_status_disconnected;
725 if (!drm_kms_helper_is_poll_worker()) {
726 r = pm_runtime_get_sync(connector->dev->dev);
728 pm_runtime_put_autosuspend(connector->dev->dev);
729 return connector_status_disconnected;
734 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
735 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
737 /* check if panel is valid */
738 if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
739 ret = connector_status_connected;
743 /* check for edid as well */
744 amdgpu_connector_get_edid(connector);
745 if (amdgpu_connector->edid)
746 ret = connector_status_connected;
747 /* check acpi lid status ??? */
749 amdgpu_connector_update_scratch_regs(connector, ret);
751 if (!drm_kms_helper_is_poll_worker()) {
752 pm_runtime_mark_last_busy(connector->dev->dev);
753 pm_runtime_put_autosuspend(connector->dev->dev);
759 static void amdgpu_connector_unregister(struct drm_connector *connector)
761 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
763 if (amdgpu_connector->ddc_bus && amdgpu_connector->ddc_bus->has_aux) {
764 drm_dp_aux_unregister(&amdgpu_connector->ddc_bus->aux);
765 amdgpu_connector->ddc_bus->has_aux = false;
769 static void amdgpu_connector_destroy(struct drm_connector *connector)
771 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
773 amdgpu_connector_free_edid(connector);
774 kfree(amdgpu_connector->con_priv);
775 drm_connector_unregister(connector);
776 drm_connector_cleanup(connector);
780 static int amdgpu_connector_set_lcd_property(struct drm_connector *connector,
781 struct drm_property *property,
784 struct drm_device *dev = connector->dev;
785 struct amdgpu_encoder *amdgpu_encoder;
786 enum amdgpu_rmx_type rmx_type;
789 if (property != dev->mode_config.scaling_mode_property)
792 if (connector->encoder)
793 amdgpu_encoder = to_amdgpu_encoder(connector->encoder);
795 const struct drm_connector_helper_funcs *connector_funcs = connector->helper_private;
796 amdgpu_encoder = to_amdgpu_encoder(connector_funcs->best_encoder(connector));
800 case DRM_MODE_SCALE_NONE: rmx_type = RMX_OFF; break;
801 case DRM_MODE_SCALE_CENTER: rmx_type = RMX_CENTER; break;
802 case DRM_MODE_SCALE_ASPECT: rmx_type = RMX_ASPECT; break;
804 case DRM_MODE_SCALE_FULLSCREEN: rmx_type = RMX_FULL; break;
806 if (amdgpu_encoder->rmx_type == rmx_type)
809 amdgpu_encoder->rmx_type = rmx_type;
811 amdgpu_connector_property_change_mode(&amdgpu_encoder->base);
816 static const struct drm_connector_helper_funcs amdgpu_connector_lvds_helper_funcs = {
817 .get_modes = amdgpu_connector_lvds_get_modes,
818 .mode_valid = amdgpu_connector_lvds_mode_valid,
819 .best_encoder = amdgpu_connector_best_single_encoder,
822 static const struct drm_connector_funcs amdgpu_connector_lvds_funcs = {
823 .dpms = drm_helper_connector_dpms,
824 .detect = amdgpu_connector_lvds_detect,
825 .fill_modes = drm_helper_probe_single_connector_modes,
826 .early_unregister = amdgpu_connector_unregister,
827 .destroy = amdgpu_connector_destroy,
828 .set_property = amdgpu_connector_set_lcd_property,
831 static int amdgpu_connector_vga_get_modes(struct drm_connector *connector)
835 amdgpu_connector_get_edid(connector);
836 ret = amdgpu_connector_ddc_get_modes(connector);
837 amdgpu_get_native_mode(connector);
842 static enum drm_mode_status amdgpu_connector_vga_mode_valid(struct drm_connector *connector,
843 struct drm_display_mode *mode)
845 struct drm_device *dev = connector->dev;
846 struct amdgpu_device *adev = drm_to_adev(dev);
848 /* XXX check mode bandwidth */
850 if ((mode->clock / 10) > adev->clock.max_pixel_clock)
851 return MODE_CLOCK_HIGH;
856 static enum drm_connector_status
857 amdgpu_connector_vga_detect(struct drm_connector *connector, bool force)
859 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
860 struct drm_encoder *encoder;
861 const struct drm_encoder_helper_funcs *encoder_funcs;
863 enum drm_connector_status ret = connector_status_disconnected;
866 if (!drm_kms_helper_is_poll_worker()) {
867 r = pm_runtime_get_sync(connector->dev->dev);
869 pm_runtime_put_autosuspend(connector->dev->dev);
870 return connector_status_disconnected;
874 encoder = amdgpu_connector_best_single_encoder(connector);
876 ret = connector_status_disconnected;
878 if (amdgpu_connector->ddc_bus)
879 dret = amdgpu_display_ddc_probe(amdgpu_connector, false);
881 amdgpu_connector->detected_by_load = false;
882 amdgpu_connector_free_edid(connector);
883 amdgpu_connector_get_edid(connector);
885 if (!amdgpu_connector->edid) {
886 DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
888 ret = connector_status_connected;
890 amdgpu_connector->use_digital =
891 !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
893 /* some oems have boards with separate digital and analog connectors
894 * with a shared ddc line (often vga + hdmi)
896 if (amdgpu_connector->use_digital && amdgpu_connector->shared_ddc) {
897 amdgpu_connector_free_edid(connector);
898 ret = connector_status_disconnected;
900 ret = connector_status_connected;
905 /* if we aren't forcing don't do destructive polling */
907 /* only return the previous status if we last
908 * detected a monitor via load.
910 if (amdgpu_connector->detected_by_load)
911 ret = connector->status;
915 if (amdgpu_connector->dac_load_detect && encoder) {
916 encoder_funcs = encoder->helper_private;
917 ret = encoder_funcs->detect(encoder, connector);
918 if (ret != connector_status_disconnected)
919 amdgpu_connector->detected_by_load = true;
923 amdgpu_connector_update_scratch_regs(connector, ret);
926 if (!drm_kms_helper_is_poll_worker()) {
927 pm_runtime_mark_last_busy(connector->dev->dev);
928 pm_runtime_put_autosuspend(connector->dev->dev);
934 static const struct drm_connector_helper_funcs amdgpu_connector_vga_helper_funcs = {
935 .get_modes = amdgpu_connector_vga_get_modes,
936 .mode_valid = amdgpu_connector_vga_mode_valid,
937 .best_encoder = amdgpu_connector_best_single_encoder,
940 static const struct drm_connector_funcs amdgpu_connector_vga_funcs = {
941 .dpms = drm_helper_connector_dpms,
942 .detect = amdgpu_connector_vga_detect,
943 .fill_modes = drm_helper_probe_single_connector_modes,
944 .early_unregister = amdgpu_connector_unregister,
945 .destroy = amdgpu_connector_destroy,
946 .set_property = amdgpu_connector_set_property,
950 amdgpu_connector_check_hpd_status_unchanged(struct drm_connector *connector)
952 struct drm_device *dev = connector->dev;
953 struct amdgpu_device *adev = drm_to_adev(dev);
954 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
955 enum drm_connector_status status;
957 if (amdgpu_connector->hpd.hpd != AMDGPU_HPD_NONE) {
958 if (amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd))
959 status = connector_status_connected;
961 status = connector_status_disconnected;
962 if (connector->status == status)
971 * Do a DDC probe, if DDC probe passes, get the full EDID so
972 * we can do analog/digital monitor detection at this point.
973 * If the monitor is an analog monitor or we got no DDC,
974 * we need to find the DAC encoder object for this connector.
975 * If we got no DDC, we do load detection on the DAC encoder object.
976 * If we got analog DDC or load detection passes on the DAC encoder
977 * we have to check if this analog encoder is shared with anyone else (TV)
978 * if its shared we have to set the other connector to disconnected.
980 static enum drm_connector_status
981 amdgpu_connector_dvi_detect(struct drm_connector *connector, bool force)
983 struct drm_device *dev = connector->dev;
984 struct amdgpu_device *adev = drm_to_adev(dev);
985 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
986 const struct drm_encoder_helper_funcs *encoder_funcs;
988 enum drm_connector_status ret = connector_status_disconnected;
989 bool dret = false, broken_edid = false;
991 if (!drm_kms_helper_is_poll_worker()) {
992 r = pm_runtime_get_sync(connector->dev->dev);
994 pm_runtime_put_autosuspend(connector->dev->dev);
995 return connector_status_disconnected;
999 if (!force && amdgpu_connector_check_hpd_status_unchanged(connector)) {
1000 ret = connector->status;
1004 if (amdgpu_connector->ddc_bus)
1005 dret = amdgpu_display_ddc_probe(amdgpu_connector, false);
1007 amdgpu_connector->detected_by_load = false;
1008 amdgpu_connector_free_edid(connector);
1009 amdgpu_connector_get_edid(connector);
1011 if (!amdgpu_connector->edid) {
1012 DRM_ERROR("%s: probed a monitor but no|invalid EDID\n",
1014 ret = connector_status_connected;
1015 broken_edid = true; /* defer use_digital to later */
1017 amdgpu_connector->use_digital =
1018 !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
1020 /* some oems have boards with separate digital and analog connectors
1021 * with a shared ddc line (often vga + hdmi)
1023 if ((!amdgpu_connector->use_digital) && amdgpu_connector->shared_ddc) {
1024 amdgpu_connector_free_edid(connector);
1025 ret = connector_status_disconnected;
1027 ret = connector_status_connected;
1030 /* This gets complicated. We have boards with VGA + HDMI with a
1031 * shared DDC line and we have boards with DVI-D + HDMI with a shared
1032 * DDC line. The latter is more complex because with DVI<->HDMI adapters
1033 * you don't really know what's connected to which port as both are digital.
1035 if (amdgpu_connector->shared_ddc && (ret == connector_status_connected)) {
1036 struct drm_connector *list_connector;
1037 struct drm_connector_list_iter iter;
1038 struct amdgpu_connector *list_amdgpu_connector;
1040 drm_connector_list_iter_begin(dev, &iter);
1041 drm_for_each_connector_iter(list_connector,
1043 if (connector == list_connector)
1045 list_amdgpu_connector = to_amdgpu_connector(list_connector);
1046 if (list_amdgpu_connector->shared_ddc &&
1047 (list_amdgpu_connector->ddc_bus->rec.i2c_id ==
1048 amdgpu_connector->ddc_bus->rec.i2c_id)) {
1049 /* cases where both connectors are digital */
1050 if (list_connector->connector_type != DRM_MODE_CONNECTOR_VGA) {
1051 /* hpd is our only option in this case */
1052 if (!amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd)) {
1053 amdgpu_connector_free_edid(connector);
1054 ret = connector_status_disconnected;
1059 drm_connector_list_iter_end(&iter);
1064 if ((ret == connector_status_connected) && (amdgpu_connector->use_digital == true))
1067 /* DVI-D and HDMI-A are digital only */
1068 if ((connector->connector_type == DRM_MODE_CONNECTOR_DVID) ||
1069 (connector->connector_type == DRM_MODE_CONNECTOR_HDMIA))
1072 /* if we aren't forcing don't do destructive polling */
1074 /* only return the previous status if we last
1075 * detected a monitor via load.
1077 if (amdgpu_connector->detected_by_load)
1078 ret = connector->status;
1082 /* find analog encoder */
1083 if (amdgpu_connector->dac_load_detect) {
1084 struct drm_encoder *encoder;
1086 drm_connector_for_each_possible_encoder(connector, encoder) {
1087 if (encoder->encoder_type != DRM_MODE_ENCODER_DAC &&
1088 encoder->encoder_type != DRM_MODE_ENCODER_TVDAC)
1091 encoder_funcs = encoder->helper_private;
1092 if (encoder_funcs->detect) {
1094 if (ret != connector_status_connected) {
1095 /* deal with analog monitors without DDC */
1096 ret = encoder_funcs->detect(encoder, connector);
1097 if (ret == connector_status_connected) {
1098 amdgpu_connector->use_digital = false;
1100 if (ret != connector_status_disconnected)
1101 amdgpu_connector->detected_by_load = true;
1104 enum drm_connector_status lret;
1105 /* assume digital unless load detected otherwise */
1106 amdgpu_connector->use_digital = true;
1107 lret = encoder_funcs->detect(encoder, connector);
1108 DRM_DEBUG_KMS("load_detect %x returned: %x\n",encoder->encoder_type,lret);
1109 if (lret == connector_status_connected)
1110 amdgpu_connector->use_digital = false;
1118 /* updated in get modes as well since we need to know if it's analog or digital */
1119 amdgpu_connector_update_scratch_regs(connector, ret);
1122 if (!drm_kms_helper_is_poll_worker()) {
1123 pm_runtime_mark_last_busy(connector->dev->dev);
1124 pm_runtime_put_autosuspend(connector->dev->dev);
1130 /* okay need to be smart in here about which encoder to pick */
1131 static struct drm_encoder *
1132 amdgpu_connector_dvi_encoder(struct drm_connector *connector)
1134 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1135 struct drm_encoder *encoder;
1137 drm_connector_for_each_possible_encoder(connector, encoder) {
1138 if (amdgpu_connector->use_digital == true) {
1139 if (encoder->encoder_type == DRM_MODE_ENCODER_TMDS)
1142 if (encoder->encoder_type == DRM_MODE_ENCODER_DAC ||
1143 encoder->encoder_type == DRM_MODE_ENCODER_TVDAC)
1148 /* see if we have a default encoder TODO */
1150 /* then check use digitial */
1151 /* pick the first one */
1152 drm_connector_for_each_possible_encoder(connector, encoder)
1158 static void amdgpu_connector_dvi_force(struct drm_connector *connector)
1160 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1161 if (connector->force == DRM_FORCE_ON)
1162 amdgpu_connector->use_digital = false;
1163 if (connector->force == DRM_FORCE_ON_DIGITAL)
1164 amdgpu_connector->use_digital = true;
1167 static enum drm_mode_status amdgpu_connector_dvi_mode_valid(struct drm_connector *connector,
1168 struct drm_display_mode *mode)
1170 struct drm_device *dev = connector->dev;
1171 struct amdgpu_device *adev = drm_to_adev(dev);
1172 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1174 /* XXX check mode bandwidth */
1176 if (amdgpu_connector->use_digital && (mode->clock > 165000)) {
1177 if ((amdgpu_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_I) ||
1178 (amdgpu_connector->connector_object_id == CONNECTOR_OBJECT_ID_DUAL_LINK_DVI_D) ||
1179 (amdgpu_connector->connector_object_id == CONNECTOR_OBJECT_ID_HDMI_TYPE_B)) {
1181 } else if (connector->display_info.is_hdmi) {
1182 /* HDMI 1.3+ supports max clock of 340 Mhz */
1183 if (mode->clock > 340000)
1184 return MODE_CLOCK_HIGH;
1188 return MODE_CLOCK_HIGH;
1192 /* check against the max pixel clock */
1193 if ((mode->clock / 10) > adev->clock.max_pixel_clock)
1194 return MODE_CLOCK_HIGH;
1199 static const struct drm_connector_helper_funcs amdgpu_connector_dvi_helper_funcs = {
1200 .get_modes = amdgpu_connector_vga_get_modes,
1201 .mode_valid = amdgpu_connector_dvi_mode_valid,
1202 .best_encoder = amdgpu_connector_dvi_encoder,
1205 static const struct drm_connector_funcs amdgpu_connector_dvi_funcs = {
1206 .dpms = drm_helper_connector_dpms,
1207 .detect = amdgpu_connector_dvi_detect,
1208 .fill_modes = drm_helper_probe_single_connector_modes,
1209 .set_property = amdgpu_connector_set_property,
1210 .early_unregister = amdgpu_connector_unregister,
1211 .destroy = amdgpu_connector_destroy,
1212 .force = amdgpu_connector_dvi_force,
1215 static int amdgpu_connector_dp_get_modes(struct drm_connector *connector)
1217 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1218 struct amdgpu_connector_atom_dig *amdgpu_dig_connector = amdgpu_connector->con_priv;
1219 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
1222 if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1223 (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1224 struct drm_display_mode *mode;
1226 if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
1227 if (!amdgpu_dig_connector->edp_on)
1228 amdgpu_atombios_encoder_set_edp_panel_power(connector,
1229 ATOM_TRANSMITTER_ACTION_POWER_ON);
1230 amdgpu_connector_get_edid(connector);
1231 ret = amdgpu_connector_ddc_get_modes(connector);
1232 if (!amdgpu_dig_connector->edp_on)
1233 amdgpu_atombios_encoder_set_edp_panel_power(connector,
1234 ATOM_TRANSMITTER_ACTION_POWER_OFF);
1236 /* need to setup ddc on the bridge */
1237 if (amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1238 ENCODER_OBJECT_ID_NONE) {
1240 amdgpu_atombios_encoder_setup_ext_encoder_ddc(encoder);
1242 amdgpu_connector_get_edid(connector);
1243 ret = amdgpu_connector_ddc_get_modes(connector);
1248 amdgpu_connector_fixup_lcd_native_mode(encoder, connector);
1249 /* add scaled modes */
1250 amdgpu_connector_add_common_modes(encoder, connector);
1258 /* we have no EDID modes */
1259 mode = amdgpu_connector_lcd_native_mode(encoder);
1262 drm_mode_probed_add(connector, mode);
1263 /* add the width/height from vbios tables if available */
1264 connector->display_info.width_mm = mode->width_mm;
1265 connector->display_info.height_mm = mode->height_mm;
1266 /* add scaled modes */
1267 amdgpu_connector_add_common_modes(encoder, connector);
1270 /* need to setup ddc on the bridge */
1271 if (amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1272 ENCODER_OBJECT_ID_NONE) {
1274 amdgpu_atombios_encoder_setup_ext_encoder_ddc(encoder);
1276 amdgpu_connector_get_edid(connector);
1277 ret = amdgpu_connector_ddc_get_modes(connector);
1279 amdgpu_get_native_mode(connector);
1285 u16 amdgpu_connector_encoder_get_dp_bridge_encoder_id(struct drm_connector *connector)
1287 struct drm_encoder *encoder;
1288 struct amdgpu_encoder *amdgpu_encoder;
1290 drm_connector_for_each_possible_encoder(connector, encoder) {
1291 amdgpu_encoder = to_amdgpu_encoder(encoder);
1293 switch (amdgpu_encoder->encoder_id) {
1294 case ENCODER_OBJECT_ID_TRAVIS:
1295 case ENCODER_OBJECT_ID_NUTMEG:
1296 return amdgpu_encoder->encoder_id;
1302 return ENCODER_OBJECT_ID_NONE;
1305 static bool amdgpu_connector_encoder_is_hbr2(struct drm_connector *connector)
1307 struct drm_encoder *encoder;
1308 struct amdgpu_encoder *amdgpu_encoder;
1311 drm_connector_for_each_possible_encoder(connector, encoder) {
1312 amdgpu_encoder = to_amdgpu_encoder(encoder);
1313 if (amdgpu_encoder->caps & ATOM_ENCODER_CAP_RECORD_HBR2)
1320 bool amdgpu_connector_is_dp12_capable(struct drm_connector *connector)
1322 struct drm_device *dev = connector->dev;
1323 struct amdgpu_device *adev = drm_to_adev(dev);
1325 if ((adev->clock.default_dispclk >= 53900) &&
1326 amdgpu_connector_encoder_is_hbr2(connector)) {
1333 static enum drm_connector_status
1334 amdgpu_connector_dp_detect(struct drm_connector *connector, bool force)
1336 struct drm_device *dev = connector->dev;
1337 struct amdgpu_device *adev = drm_to_adev(dev);
1338 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1339 enum drm_connector_status ret = connector_status_disconnected;
1340 struct amdgpu_connector_atom_dig *amdgpu_dig_connector = amdgpu_connector->con_priv;
1341 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
1344 if (!drm_kms_helper_is_poll_worker()) {
1345 r = pm_runtime_get_sync(connector->dev->dev);
1347 pm_runtime_put_autosuspend(connector->dev->dev);
1348 return connector_status_disconnected;
1352 if (!force && amdgpu_connector_check_hpd_status_unchanged(connector)) {
1353 ret = connector->status;
1357 amdgpu_connector_free_edid(connector);
1359 if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1360 (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1362 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
1363 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
1365 /* check if panel is valid */
1366 if (native_mode->hdisplay >= 320 && native_mode->vdisplay >= 240)
1367 ret = connector_status_connected;
1369 /* eDP is always DP */
1370 amdgpu_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1371 if (!amdgpu_dig_connector->edp_on)
1372 amdgpu_atombios_encoder_set_edp_panel_power(connector,
1373 ATOM_TRANSMITTER_ACTION_POWER_ON);
1374 if (!amdgpu_atombios_dp_get_dpcd(amdgpu_connector))
1375 ret = connector_status_connected;
1376 if (!amdgpu_dig_connector->edp_on)
1377 amdgpu_atombios_encoder_set_edp_panel_power(connector,
1378 ATOM_TRANSMITTER_ACTION_POWER_OFF);
1379 } else if (amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=
1380 ENCODER_OBJECT_ID_NONE) {
1381 /* DP bridges are always DP */
1382 amdgpu_dig_connector->dp_sink_type = CONNECTOR_OBJECT_ID_DISPLAYPORT;
1383 /* get the DPCD from the bridge */
1384 amdgpu_atombios_dp_get_dpcd(amdgpu_connector);
1387 /* setup ddc on the bridge */
1388 amdgpu_atombios_encoder_setup_ext_encoder_ddc(encoder);
1389 /* bridge chips are always aux */
1391 if (amdgpu_display_ddc_probe(amdgpu_connector, true))
1392 ret = connector_status_connected;
1393 else if (amdgpu_connector->dac_load_detect) { /* try load detection */
1394 const struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;
1395 ret = encoder_funcs->detect(encoder, connector);
1399 amdgpu_dig_connector->dp_sink_type =
1400 amdgpu_atombios_dp_get_sinktype(amdgpu_connector);
1401 if (amdgpu_display_hpd_sense(adev, amdgpu_connector->hpd.hpd)) {
1402 ret = connector_status_connected;
1403 if (amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT)
1404 amdgpu_atombios_dp_get_dpcd(amdgpu_connector);
1406 if (amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) {
1407 if (!amdgpu_atombios_dp_get_dpcd(amdgpu_connector))
1408 ret = connector_status_connected;
1410 /* try non-aux ddc (DP to DVI/HDMI/etc. adapter) */
1411 if (amdgpu_display_ddc_probe(amdgpu_connector,
1413 ret = connector_status_connected;
1418 amdgpu_connector_update_scratch_regs(connector, ret);
1420 if (!drm_kms_helper_is_poll_worker()) {
1421 pm_runtime_mark_last_busy(connector->dev->dev);
1422 pm_runtime_put_autosuspend(connector->dev->dev);
1425 if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
1426 connector->connector_type == DRM_MODE_CONNECTOR_eDP)
1427 drm_dp_set_subconnector_property(&amdgpu_connector->base,
1429 amdgpu_dig_connector->dpcd,
1430 amdgpu_dig_connector->downstream_ports);
1434 static enum drm_mode_status amdgpu_connector_dp_mode_valid(struct drm_connector *connector,
1435 struct drm_display_mode *mode)
1437 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1438 struct amdgpu_connector_atom_dig *amdgpu_dig_connector = amdgpu_connector->con_priv;
1440 /* XXX check mode bandwidth */
1442 if ((connector->connector_type == DRM_MODE_CONNECTOR_eDP) ||
1443 (connector->connector_type == DRM_MODE_CONNECTOR_LVDS)) {
1444 struct drm_encoder *encoder = amdgpu_connector_best_single_encoder(connector);
1446 if ((mode->hdisplay < 320) || (mode->vdisplay < 240))
1450 struct amdgpu_encoder *amdgpu_encoder = to_amdgpu_encoder(encoder);
1451 struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;
1453 /* AVIVO hardware supports downscaling modes larger than the panel
1454 * to the panel size, but I'm not sure this is desirable.
1456 if ((mode->hdisplay > native_mode->hdisplay) ||
1457 (mode->vdisplay > native_mode->vdisplay))
1460 /* if scaling is disabled, block non-native modes */
1461 if (amdgpu_encoder->rmx_type == RMX_OFF) {
1462 if ((mode->hdisplay != native_mode->hdisplay) ||
1463 (mode->vdisplay != native_mode->vdisplay))
1469 if ((amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_DISPLAYPORT) ||
1470 (amdgpu_dig_connector->dp_sink_type == CONNECTOR_OBJECT_ID_eDP)) {
1471 return amdgpu_atombios_dp_mode_valid_helper(connector, mode);
1473 if (connector->display_info.is_hdmi) {
1474 /* HDMI 1.3+ supports max clock of 340 Mhz */
1475 if (mode->clock > 340000)
1476 return MODE_CLOCK_HIGH;
1478 if (mode->clock > 165000)
1479 return MODE_CLOCK_HIGH;
1488 amdgpu_connector_late_register(struct drm_connector *connector)
1490 struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
1493 if (amdgpu_connector->ddc_bus->has_aux) {
1494 amdgpu_connector->ddc_bus->aux.dev = amdgpu_connector->base.kdev;
1495 r = drm_dp_aux_register(&amdgpu_connector->ddc_bus->aux);
1501 static const struct drm_connector_helper_funcs amdgpu_connector_dp_helper_funcs = {
1502 .get_modes = amdgpu_connector_dp_get_modes,
1503 .mode_valid = amdgpu_connector_dp_mode_valid,
1504 .best_encoder = amdgpu_connector_dvi_encoder,
1507 static const struct drm_connector_funcs amdgpu_connector_dp_funcs = {
1508 .dpms = drm_helper_connector_dpms,
1509 .detect = amdgpu_connector_dp_detect,
1510 .fill_modes = drm_helper_probe_single_connector_modes,
1511 .set_property = amdgpu_connector_set_property,
1512 .early_unregister = amdgpu_connector_unregister,
1513 .destroy = amdgpu_connector_destroy,
1514 .force = amdgpu_connector_dvi_force,
1515 .late_register = amdgpu_connector_late_register,
1518 static const struct drm_connector_funcs amdgpu_connector_edp_funcs = {
1519 .dpms = drm_helper_connector_dpms,
1520 .detect = amdgpu_connector_dp_detect,
1521 .fill_modes = drm_helper_probe_single_connector_modes,
1522 .set_property = amdgpu_connector_set_lcd_property,
1523 .early_unregister = amdgpu_connector_unregister,
1524 .destroy = amdgpu_connector_destroy,
1525 .force = amdgpu_connector_dvi_force,
1526 .late_register = amdgpu_connector_late_register,
1530 amdgpu_connector_add(struct amdgpu_device *adev,
1531 uint32_t connector_id,
1532 uint32_t supported_device,
1534 struct amdgpu_i2c_bus_rec *i2c_bus,
1535 uint16_t connector_object_id,
1536 struct amdgpu_hpd *hpd,
1537 struct amdgpu_router *router)
1539 struct drm_device *dev = adev_to_drm(adev);
1540 struct drm_connector *connector;
1541 struct drm_connector_list_iter iter;
1542 struct amdgpu_connector *amdgpu_connector;
1543 struct amdgpu_connector_atom_dig *amdgpu_dig_connector;
1544 struct drm_encoder *encoder;
1545 struct amdgpu_encoder *amdgpu_encoder;
1546 struct i2c_adapter *ddc = NULL;
1547 uint32_t subpixel_order = SubPixelNone;
1548 bool shared_ddc = false;
1549 bool is_dp_bridge = false;
1550 bool has_aux = false;
1552 if (connector_type == DRM_MODE_CONNECTOR_Unknown)
1555 /* see if we already added it */
1556 drm_connector_list_iter_begin(dev, &iter);
1557 drm_for_each_connector_iter(connector, &iter) {
1558 amdgpu_connector = to_amdgpu_connector(connector);
1559 if (amdgpu_connector->connector_id == connector_id) {
1560 amdgpu_connector->devices |= supported_device;
1561 drm_connector_list_iter_end(&iter);
1564 if (amdgpu_connector->ddc_bus && i2c_bus->valid) {
1565 if (amdgpu_connector->ddc_bus->rec.i2c_id == i2c_bus->i2c_id) {
1566 amdgpu_connector->shared_ddc = true;
1569 if (amdgpu_connector->router_bus && router->ddc_valid &&
1570 (amdgpu_connector->router.router_id == router->router_id)) {
1571 amdgpu_connector->shared_ddc = false;
1576 drm_connector_list_iter_end(&iter);
1578 /* check if it's a dp bridge */
1579 list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
1580 amdgpu_encoder = to_amdgpu_encoder(encoder);
1581 if (amdgpu_encoder->devices & supported_device) {
1582 switch (amdgpu_encoder->encoder_id) {
1583 case ENCODER_OBJECT_ID_TRAVIS:
1584 case ENCODER_OBJECT_ID_NUTMEG:
1585 is_dp_bridge = true;
1593 amdgpu_connector = kzalloc(sizeof(struct amdgpu_connector), GFP_KERNEL);
1594 if (!amdgpu_connector)
1597 connector = &amdgpu_connector->base;
1599 amdgpu_connector->connector_id = connector_id;
1600 amdgpu_connector->devices = supported_device;
1601 amdgpu_connector->shared_ddc = shared_ddc;
1602 amdgpu_connector->connector_object_id = connector_object_id;
1603 amdgpu_connector->hpd = *hpd;
1605 amdgpu_connector->router = *router;
1606 if (router->ddc_valid || router->cd_valid) {
1607 amdgpu_connector->router_bus = amdgpu_i2c_lookup(adev, &router->i2c_info);
1608 if (!amdgpu_connector->router_bus)
1609 DRM_ERROR("Failed to assign router i2c bus! Check dmesg for i2c errors.\n");
1613 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1614 if (!amdgpu_dig_connector)
1616 amdgpu_connector->con_priv = amdgpu_dig_connector;
1617 if (i2c_bus->valid) {
1618 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1619 if (amdgpu_connector->ddc_bus) {
1621 ddc = &amdgpu_connector->ddc_bus->adapter;
1623 DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1626 switch (connector_type) {
1627 case DRM_MODE_CONNECTOR_VGA:
1628 case DRM_MODE_CONNECTOR_DVIA:
1630 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1631 &amdgpu_connector_dp_funcs,
1634 drm_connector_helper_add(&amdgpu_connector->base,
1635 &amdgpu_connector_dp_helper_funcs);
1636 connector->interlace_allowed = true;
1637 connector->doublescan_allowed = true;
1638 amdgpu_connector->dac_load_detect = true;
1639 drm_object_attach_property(&amdgpu_connector->base.base,
1640 adev->mode_info.load_detect_property,
1642 drm_object_attach_property(&amdgpu_connector->base.base,
1643 dev->mode_config.scaling_mode_property,
1644 DRM_MODE_SCALE_NONE);
1646 case DRM_MODE_CONNECTOR_DVII:
1647 case DRM_MODE_CONNECTOR_DVID:
1648 case DRM_MODE_CONNECTOR_HDMIA:
1649 case DRM_MODE_CONNECTOR_HDMIB:
1650 case DRM_MODE_CONNECTOR_DisplayPort:
1651 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1652 &amdgpu_connector_dp_funcs,
1655 drm_connector_helper_add(&amdgpu_connector->base,
1656 &amdgpu_connector_dp_helper_funcs);
1657 drm_object_attach_property(&amdgpu_connector->base.base,
1658 adev->mode_info.underscan_property,
1660 drm_object_attach_property(&amdgpu_connector->base.base,
1661 adev->mode_info.underscan_hborder_property,
1663 drm_object_attach_property(&amdgpu_connector->base.base,
1664 adev->mode_info.underscan_vborder_property,
1667 drm_object_attach_property(&amdgpu_connector->base.base,
1668 dev->mode_config.scaling_mode_property,
1669 DRM_MODE_SCALE_NONE);
1671 drm_object_attach_property(&amdgpu_connector->base.base,
1672 adev->mode_info.dither_property,
1673 AMDGPU_FMT_DITHER_DISABLE);
1675 if (amdgpu_audio != 0) {
1676 drm_object_attach_property(&amdgpu_connector->base.base,
1677 adev->mode_info.audio_property,
1679 amdgpu_connector->audio = AMDGPU_AUDIO_AUTO;
1682 subpixel_order = SubPixelHorizontalRGB;
1683 connector->interlace_allowed = true;
1684 if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
1685 connector->doublescan_allowed = true;
1687 connector->doublescan_allowed = false;
1688 if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1689 amdgpu_connector->dac_load_detect = true;
1690 drm_object_attach_property(&amdgpu_connector->base.base,
1691 adev->mode_info.load_detect_property,
1695 case DRM_MODE_CONNECTOR_LVDS:
1696 case DRM_MODE_CONNECTOR_eDP:
1697 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1698 &amdgpu_connector_edp_funcs,
1701 drm_connector_helper_add(&amdgpu_connector->base,
1702 &amdgpu_connector_dp_helper_funcs);
1703 drm_object_attach_property(&amdgpu_connector->base.base,
1704 dev->mode_config.scaling_mode_property,
1705 DRM_MODE_SCALE_FULLSCREEN);
1706 subpixel_order = SubPixelHorizontalRGB;
1707 connector->interlace_allowed = false;
1708 connector->doublescan_allowed = false;
1712 switch (connector_type) {
1713 case DRM_MODE_CONNECTOR_VGA:
1714 if (i2c_bus->valid) {
1715 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1716 if (!amdgpu_connector->ddc_bus)
1717 DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1719 ddc = &amdgpu_connector->ddc_bus->adapter;
1721 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1722 &amdgpu_connector_vga_funcs,
1725 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_vga_helper_funcs);
1726 amdgpu_connector->dac_load_detect = true;
1727 drm_object_attach_property(&amdgpu_connector->base.base,
1728 adev->mode_info.load_detect_property,
1730 drm_object_attach_property(&amdgpu_connector->base.base,
1731 dev->mode_config.scaling_mode_property,
1732 DRM_MODE_SCALE_NONE);
1733 /* no HPD on analog connectors */
1734 amdgpu_connector->hpd.hpd = AMDGPU_HPD_NONE;
1735 connector->interlace_allowed = true;
1736 connector->doublescan_allowed = true;
1738 case DRM_MODE_CONNECTOR_DVIA:
1739 if (i2c_bus->valid) {
1740 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1741 if (!amdgpu_connector->ddc_bus)
1742 DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1744 ddc = &amdgpu_connector->ddc_bus->adapter;
1746 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1747 &amdgpu_connector_vga_funcs,
1750 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_vga_helper_funcs);
1751 amdgpu_connector->dac_load_detect = true;
1752 drm_object_attach_property(&amdgpu_connector->base.base,
1753 adev->mode_info.load_detect_property,
1755 drm_object_attach_property(&amdgpu_connector->base.base,
1756 dev->mode_config.scaling_mode_property,
1757 DRM_MODE_SCALE_NONE);
1758 /* no HPD on analog connectors */
1759 amdgpu_connector->hpd.hpd = AMDGPU_HPD_NONE;
1760 connector->interlace_allowed = true;
1761 connector->doublescan_allowed = true;
1763 case DRM_MODE_CONNECTOR_DVII:
1764 case DRM_MODE_CONNECTOR_DVID:
1765 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1766 if (!amdgpu_dig_connector)
1768 amdgpu_connector->con_priv = amdgpu_dig_connector;
1769 if (i2c_bus->valid) {
1770 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1771 if (!amdgpu_connector->ddc_bus)
1772 DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1774 ddc = &amdgpu_connector->ddc_bus->adapter;
1776 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1777 &amdgpu_connector_dvi_funcs,
1780 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dvi_helper_funcs);
1781 subpixel_order = SubPixelHorizontalRGB;
1782 drm_object_attach_property(&amdgpu_connector->base.base,
1783 adev->mode_info.coherent_mode_property,
1785 drm_object_attach_property(&amdgpu_connector->base.base,
1786 adev->mode_info.underscan_property,
1788 drm_object_attach_property(&amdgpu_connector->base.base,
1789 adev->mode_info.underscan_hborder_property,
1791 drm_object_attach_property(&amdgpu_connector->base.base,
1792 adev->mode_info.underscan_vborder_property,
1794 drm_object_attach_property(&amdgpu_connector->base.base,
1795 dev->mode_config.scaling_mode_property,
1796 DRM_MODE_SCALE_NONE);
1798 if (amdgpu_audio != 0) {
1799 drm_object_attach_property(&amdgpu_connector->base.base,
1800 adev->mode_info.audio_property,
1802 amdgpu_connector->audio = AMDGPU_AUDIO_AUTO;
1804 drm_object_attach_property(&amdgpu_connector->base.base,
1805 adev->mode_info.dither_property,
1806 AMDGPU_FMT_DITHER_DISABLE);
1807 if (connector_type == DRM_MODE_CONNECTOR_DVII) {
1808 amdgpu_connector->dac_load_detect = true;
1809 drm_object_attach_property(&amdgpu_connector->base.base,
1810 adev->mode_info.load_detect_property,
1813 connector->interlace_allowed = true;
1814 if (connector_type == DRM_MODE_CONNECTOR_DVII)
1815 connector->doublescan_allowed = true;
1817 connector->doublescan_allowed = false;
1819 case DRM_MODE_CONNECTOR_HDMIA:
1820 case DRM_MODE_CONNECTOR_HDMIB:
1821 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1822 if (!amdgpu_dig_connector)
1824 amdgpu_connector->con_priv = amdgpu_dig_connector;
1825 if (i2c_bus->valid) {
1826 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1827 if (!amdgpu_connector->ddc_bus)
1828 DRM_ERROR("HDMI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1830 ddc = &amdgpu_connector->ddc_bus->adapter;
1832 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1833 &amdgpu_connector_dvi_funcs,
1836 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dvi_helper_funcs);
1837 drm_object_attach_property(&amdgpu_connector->base.base,
1838 adev->mode_info.coherent_mode_property,
1840 drm_object_attach_property(&amdgpu_connector->base.base,
1841 adev->mode_info.underscan_property,
1843 drm_object_attach_property(&amdgpu_connector->base.base,
1844 adev->mode_info.underscan_hborder_property,
1846 drm_object_attach_property(&amdgpu_connector->base.base,
1847 adev->mode_info.underscan_vborder_property,
1849 drm_object_attach_property(&amdgpu_connector->base.base,
1850 dev->mode_config.scaling_mode_property,
1851 DRM_MODE_SCALE_NONE);
1852 if (amdgpu_audio != 0) {
1853 drm_object_attach_property(&amdgpu_connector->base.base,
1854 adev->mode_info.audio_property,
1856 amdgpu_connector->audio = AMDGPU_AUDIO_AUTO;
1858 drm_object_attach_property(&amdgpu_connector->base.base,
1859 adev->mode_info.dither_property,
1860 AMDGPU_FMT_DITHER_DISABLE);
1861 subpixel_order = SubPixelHorizontalRGB;
1862 connector->interlace_allowed = true;
1863 if (connector_type == DRM_MODE_CONNECTOR_HDMIB)
1864 connector->doublescan_allowed = true;
1866 connector->doublescan_allowed = false;
1868 case DRM_MODE_CONNECTOR_DisplayPort:
1869 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1870 if (!amdgpu_dig_connector)
1872 amdgpu_connector->con_priv = amdgpu_dig_connector;
1873 if (i2c_bus->valid) {
1874 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1875 if (amdgpu_connector->ddc_bus) {
1877 ddc = &amdgpu_connector->ddc_bus->adapter;
1879 DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1882 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1883 &amdgpu_connector_dp_funcs,
1886 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dp_helper_funcs);
1887 subpixel_order = SubPixelHorizontalRGB;
1888 drm_object_attach_property(&amdgpu_connector->base.base,
1889 adev->mode_info.coherent_mode_property,
1891 drm_object_attach_property(&amdgpu_connector->base.base,
1892 adev->mode_info.underscan_property,
1894 drm_object_attach_property(&amdgpu_connector->base.base,
1895 adev->mode_info.underscan_hborder_property,
1897 drm_object_attach_property(&amdgpu_connector->base.base,
1898 adev->mode_info.underscan_vborder_property,
1900 drm_object_attach_property(&amdgpu_connector->base.base,
1901 dev->mode_config.scaling_mode_property,
1902 DRM_MODE_SCALE_NONE);
1903 if (amdgpu_audio != 0) {
1904 drm_object_attach_property(&amdgpu_connector->base.base,
1905 adev->mode_info.audio_property,
1907 amdgpu_connector->audio = AMDGPU_AUDIO_AUTO;
1909 drm_object_attach_property(&amdgpu_connector->base.base,
1910 adev->mode_info.dither_property,
1911 AMDGPU_FMT_DITHER_DISABLE);
1912 connector->interlace_allowed = true;
1913 /* in theory with a DP to VGA converter... */
1914 connector->doublescan_allowed = false;
1916 case DRM_MODE_CONNECTOR_eDP:
1917 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1918 if (!amdgpu_dig_connector)
1920 amdgpu_connector->con_priv = amdgpu_dig_connector;
1921 if (i2c_bus->valid) {
1922 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1923 if (amdgpu_connector->ddc_bus) {
1925 ddc = &amdgpu_connector->ddc_bus->adapter;
1927 DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1930 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1931 &amdgpu_connector_edp_funcs,
1934 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_dp_helper_funcs);
1935 drm_object_attach_property(&amdgpu_connector->base.base,
1936 dev->mode_config.scaling_mode_property,
1937 DRM_MODE_SCALE_FULLSCREEN);
1938 subpixel_order = SubPixelHorizontalRGB;
1939 connector->interlace_allowed = false;
1940 connector->doublescan_allowed = false;
1942 case DRM_MODE_CONNECTOR_LVDS:
1943 amdgpu_dig_connector = kzalloc(sizeof(struct amdgpu_connector_atom_dig), GFP_KERNEL);
1944 if (!amdgpu_dig_connector)
1946 amdgpu_connector->con_priv = amdgpu_dig_connector;
1947 if (i2c_bus->valid) {
1948 amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
1949 if (!amdgpu_connector->ddc_bus)
1950 DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
1952 ddc = &amdgpu_connector->ddc_bus->adapter;
1954 drm_connector_init_with_ddc(dev, &amdgpu_connector->base,
1955 &amdgpu_connector_lvds_funcs,
1958 drm_connector_helper_add(&amdgpu_connector->base, &amdgpu_connector_lvds_helper_funcs);
1959 drm_object_attach_property(&amdgpu_connector->base.base,
1960 dev->mode_config.scaling_mode_property,
1961 DRM_MODE_SCALE_FULLSCREEN);
1962 subpixel_order = SubPixelHorizontalRGB;
1963 connector->interlace_allowed = false;
1964 connector->doublescan_allowed = false;
1969 if (amdgpu_connector->hpd.hpd == AMDGPU_HPD_NONE) {
1970 if (i2c_bus->valid) {
1971 connector->polled = DRM_CONNECTOR_POLL_CONNECT |
1972 DRM_CONNECTOR_POLL_DISCONNECT;
1975 connector->polled = DRM_CONNECTOR_POLL_HPD;
1977 connector->display_info.subpixel_order = subpixel_order;
1980 amdgpu_atombios_dp_aux_init(amdgpu_connector);
1982 if (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
1983 connector_type == DRM_MODE_CONNECTOR_eDP) {
1984 drm_connector_attach_dp_subconnector_property(&amdgpu_connector->base);
1990 drm_connector_cleanup(connector);