1 /* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
2 /* dbus-sysdeps-util-unix.c Would be in dbus-sysdeps-unix.c, but not used in libdbus
4 * Copyright (C) 2002, 2003, 2004, 2005 Red Hat, Inc.
5 * Copyright (C) 2003 CodeFactory AB
7 * Licensed under the Academic Free License version 2.1
9 * This program is free software; you can redistribute it and/or modify
10 * it under the terms of the GNU General Public License as published by
11 * the Free Software Foundation; either version 2 of the License, or
12 * (at your option) any later version.
14 * This program is distributed in the hope that it will be useful,
15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17 * GNU General Public License for more details.
19 * You should have received a copy of the GNU General Public License
20 * along with this program; if not, write to the Free Software
21 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
24 #include "dbus-sysdeps.h"
25 #include "dbus-sysdeps-unix.h"
26 #include "dbus-internals.h"
27 #include "dbus-protocol.h"
28 #include "dbus-string.h"
29 #define DBUS_USERDB_INCLUDES_PRIVATE 1
30 #include "dbus-userdb.h"
31 #include "dbus-test.h"
33 #include <sys/types.h>
43 #include <sys/socket.h>
48 #ifdef HAVE_SYS_SYSLIMITS_H
49 #include <sys/syslimits.h>
57 * @addtogroup DBusInternalsUtils
63 * Does the chdir, fork, setsid, etc. to become a daemon process.
65 * @param pidfile #NULL, or pidfile to create
66 * @param print_pid_pipe pipe to print daemon's pid to, or -1 for none
67 * @param error return location for errors
68 * @param keep_umask #TRUE to keep the original umask
69 * @returns #FALSE on failure
72 _dbus_become_daemon (const DBusString *pidfile,
73 DBusPipe *print_pid_pipe,
75 dbus_bool_t keep_umask)
81 _dbus_verbose ("Becoming a daemon...\n");
83 _dbus_verbose ("chdir to /\n");
86 dbus_set_error (error, DBUS_ERROR_FAILED,
87 "Could not chdir() to root directory");
91 _dbus_verbose ("forking...\n");
92 switch ((child_pid = fork ()))
95 _dbus_verbose ("fork failed\n");
96 dbus_set_error (error, _dbus_error_from_errno (errno),
97 "Failed to fork daemon: %s", _dbus_strerror (errno));
102 _dbus_verbose ("in child, closing std file descriptors\n");
104 /* silently ignore failures here, if someone
105 * doesn't have /dev/null we may as well try
109 dev_null_fd = open ("/dev/null", O_RDWR);
110 if (dev_null_fd >= 0)
112 dup2 (dev_null_fd, 0);
113 dup2 (dev_null_fd, 1);
115 s = _dbus_getenv ("DBUS_DEBUG_OUTPUT");
116 if (s == NULL || *s == '\0')
117 dup2 (dev_null_fd, 2);
119 _dbus_verbose ("keeping stderr open due to DBUS_DEBUG_OUTPUT\n");
124 /* Get a predictable umask */
125 _dbus_verbose ("setting umask\n");
129 _dbus_verbose ("calling setsid()\n");
131 _dbus_assert_not_reached ("setsid() failed");
136 if (!_dbus_write_pid_to_file_and_pipe (pidfile, print_pid_pipe,
139 _dbus_verbose ("pid file or pipe write failed: %s\n",
141 kill (child_pid, SIGTERM);
145 _dbus_verbose ("parent exiting\n");
155 * Creates a file containing the process ID.
157 * @param filename the filename to write to
158 * @param pid our process ID
159 * @param error return location for errors
160 * @returns #FALSE on failure
163 _dbus_write_pid_file (const DBusString *filename,
167 const char *cfilename;
171 cfilename = _dbus_string_get_const_data (filename);
173 fd = open (cfilename, O_WRONLY|O_CREAT|O_EXCL|O_BINARY, 0644);
177 dbus_set_error (error, _dbus_error_from_errno (errno),
178 "Failed to open \"%s\": %s", cfilename,
179 _dbus_strerror (errno));
183 if ((f = fdopen (fd, "w")) == NULL)
185 dbus_set_error (error, _dbus_error_from_errno (errno),
186 "Failed to fdopen fd %d: %s", fd, _dbus_strerror (errno));
187 _dbus_close (fd, NULL);
191 if (fprintf (f, "%lu\n", pid) < 0)
193 dbus_set_error (error, _dbus_error_from_errno (errno),
194 "Failed to write to \"%s\": %s", cfilename,
195 _dbus_strerror (errno));
201 if (fclose (f) == EOF)
203 dbus_set_error (error, _dbus_error_from_errno (errno),
204 "Failed to close \"%s\": %s", cfilename,
205 _dbus_strerror (errno));
213 * Writes the given pid_to_write to a pidfile (if non-NULL) and/or to a
214 * pipe (if non-NULL). Does nothing if pidfile and print_pid_pipe are both
217 * @param pidfile the file to write to or #NULL
218 * @param print_pid_pipe the pipe to write to or #NULL
219 * @param pid_to_write the pid to write out
220 * @param error error on failure
221 * @returns FALSE if error is set
224 _dbus_write_pid_to_file_and_pipe (const DBusString *pidfile,
225 DBusPipe *print_pid_pipe,
226 dbus_pid_t pid_to_write,
231 _dbus_verbose ("writing pid file %s\n", _dbus_string_get_const_data (pidfile));
232 if (!_dbus_write_pid_file (pidfile,
236 _dbus_verbose ("pid file write failed\n");
237 _DBUS_ASSERT_ERROR_IS_SET(error);
243 _dbus_verbose ("No pid file requested\n");
246 if (print_pid_pipe != NULL && _dbus_pipe_is_valid (print_pid_pipe))
251 _dbus_verbose ("writing our pid to pipe %d\n", print_pid_pipe->fd_or_handle);
253 if (!_dbus_string_init (&pid))
255 _DBUS_SET_OOM (error);
259 if (!_dbus_string_append_int (&pid, pid_to_write) ||
260 !_dbus_string_append (&pid, "\n"))
262 _dbus_string_free (&pid);
263 _DBUS_SET_OOM (error);
267 bytes = _dbus_string_get_length (&pid);
268 if (_dbus_pipe_write (print_pid_pipe, &pid, 0, bytes, error) != bytes)
270 /* _dbus_pipe_write sets error only on failure, not short write */
271 if (error != NULL && !dbus_error_is_set(error))
273 dbus_set_error (error, DBUS_ERROR_FAILED,
274 "Printing message bus PID: did not write enough bytes\n");
276 _dbus_string_free (&pid);
280 _dbus_string_free (&pid);
284 _dbus_verbose ("No pid pipe to write to\n");
291 * Verify that after the fork we can successfully change to this user.
293 * @param user the username given in the daemon configuration
294 * @returns #TRUE if username is valid
297 _dbus_verify_daemon_user (const char *user)
301 _dbus_string_init_const (&u, user);
303 return _dbus_get_user_id_and_primary_group (&u, NULL, NULL);
307 /* The HAVE_LIBAUDIT case lives in selinux.c */
308 #ifndef HAVE_LIBAUDIT
310 * Changes the user and group the bus is running as.
312 * @param user the user to become
313 * @param error return location for errors
314 * @returns #FALSE on failure
317 _dbus_change_to_daemon_user (const char *user,
324 _dbus_string_init_const (&u, user);
326 if (!_dbus_get_user_id_and_primary_group (&u, &uid, &gid))
328 dbus_set_error (error, DBUS_ERROR_FAILED,
329 "User '%s' does not appear to exist?",
334 /* setgroups() only works if we are a privileged process,
335 * so we don't return error on failure; the only possible
336 * failure is that we don't have perms to do it.
338 * not sure this is right, maybe if setuid()
339 * is going to work then setgroups() should also work.
341 if (setgroups (0, NULL) < 0)
342 _dbus_warn ("Failed to drop supplementary groups: %s\n",
343 _dbus_strerror (errno));
345 /* Set GID first, or the setuid may remove our permission
348 if (setgid (gid) < 0)
350 dbus_set_error (error, _dbus_error_from_errno (errno),
351 "Failed to set GID to %lu: %s", gid,
352 _dbus_strerror (errno));
356 if (setuid (uid) < 0)
358 dbus_set_error (error, _dbus_error_from_errno (errno),
359 "Failed to set UID to %lu: %s", uid,
360 _dbus_strerror (errno));
366 #endif /* !HAVE_LIBAUDIT */
369 _dbus_init_system_log (void)
371 openlog ("dbus", LOG_PID, LOG_DAEMON);
375 * Log an informative message. Intended for use primarily by
378 * @param msg a printf-style format string
379 * @param args arguments for the format string
382 _dbus_log_info (const char *msg, va_list args)
384 vsyslog (LOG_DAEMON|LOG_NOTICE, msg, args);
388 * Log a security-related message. Intended for use primarily by
391 * @param msg a printf-style format string
392 * @param args arguments for the format string
395 _dbus_log_security (const char *msg, va_list args)
397 vsyslog (LOG_AUTH|LOG_NOTICE, msg, args);
400 /** Installs a UNIX signal handler
402 * @param sig the signal to handle
403 * @param handler the handler
406 _dbus_set_signal_handler (int sig,
407 DBusSignalHandler handler)
409 struct sigaction act;
412 sigemptyset (&empty_mask);
413 act.sa_handler = handler;
414 act.sa_mask = empty_mask;
416 sigaction (sig, &act, NULL);
421 * Removes a directory; Directory must be empty
423 * @param filename directory filename
424 * @param error initialized error object
425 * @returns #TRUE on success
428 _dbus_delete_directory (const DBusString *filename,
431 const char *filename_c;
433 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
435 filename_c = _dbus_string_get_const_data (filename);
437 if (rmdir (filename_c) != 0)
439 dbus_set_error (error, DBUS_ERROR_FAILED,
440 "Failed to remove directory %s: %s\n",
441 filename_c, _dbus_strerror (errno));
448 /** Checks if a file exists
450 * @param file full path to the file
451 * @returns #TRUE if file exists
454 _dbus_file_exists (const char *file)
456 return (access (file, F_OK) == 0);
459 /** Checks if user is at the console
461 * @param username user to check
462 * @param error return location for errors
463 * @returns #TRUE is the user is at the consolei and there are no errors
466 _dbus_user_at_console (const char *username,
474 if (!_dbus_string_init (&f))
476 _DBUS_SET_OOM (error);
480 if (!_dbus_string_append (&f, DBUS_CONSOLE_AUTH_DIR))
482 _DBUS_SET_OOM (error);
487 if (!_dbus_string_append (&f, username))
489 _DBUS_SET_OOM (error);
493 result = _dbus_file_exists (_dbus_string_get_const_data (&f));
496 _dbus_string_free (&f);
503 * Checks whether the filename is an absolute path
505 * @param filename the filename
506 * @returns #TRUE if an absolute path
509 _dbus_path_is_absolute (const DBusString *filename)
511 if (_dbus_string_get_length (filename) > 0)
512 return _dbus_string_get_byte (filename, 0) == '/';
520 * @param filename the filename to stat
521 * @param statbuf the stat info to fill in
522 * @param error return location for error
523 * @returns #FALSE if error was set
526 _dbus_stat (const DBusString *filename,
530 const char *filename_c;
533 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
535 filename_c = _dbus_string_get_const_data (filename);
537 if (stat (filename_c, &sb) < 0)
539 dbus_set_error (error, _dbus_error_from_errno (errno),
540 "%s", _dbus_strerror (errno));
544 statbuf->mode = sb.st_mode;
545 statbuf->nlink = sb.st_nlink;
546 statbuf->uid = sb.st_uid;
547 statbuf->gid = sb.st_gid;
548 statbuf->size = sb.st_size;
549 statbuf->atime = sb.st_atime;
550 statbuf->mtime = sb.st_mtime;
551 statbuf->ctime = sb.st_ctime;
558 * Internals of directory iterator
562 DIR *d; /**< The DIR* from opendir() */
567 * Open a directory to iterate over.
569 * @param filename the directory name
570 * @param error exception return object or #NULL
571 * @returns new iterator, or #NULL on error
574 _dbus_directory_open (const DBusString *filename,
579 const char *filename_c;
581 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
583 filename_c = _dbus_string_get_const_data (filename);
585 d = opendir (filename_c);
588 dbus_set_error (error, _dbus_error_from_errno (errno),
589 "Failed to read directory \"%s\": %s",
591 _dbus_strerror (errno));
594 iter = dbus_new0 (DBusDirIter, 1);
598 dbus_set_error (error, DBUS_ERROR_NO_MEMORY,
599 "Could not allocate memory for directory iterator");
608 /* Calculate the required buffer size (in bytes) for directory
609 * entries read from the given directory handle. Return -1 if this
610 * this cannot be done.
612 * If you use autoconf, include fpathconf and dirfd in your
613 * AC_CHECK_FUNCS list. Otherwise use some other method to detect
614 * and use them where available.
617 dirent_buf_size(DIR * dirp, size_t *size)
620 # if defined(HAVE_FPATHCONF) && defined(_PC_NAME_MAX)
621 # if defined(HAVE_DIRFD)
622 name_max = fpathconf(dirfd(dirp), _PC_NAME_MAX);
623 # elif defined(HAVE_DDFD)
624 name_max = fpathconf(dirp->dd_fd, _PC_NAME_MAX);
626 name_max = fpathconf(dirp->__dd_fd, _PC_NAME_MAX);
627 # endif /* HAVE_DIRFD */
629 # if defined(NAME_MAX)
634 # elif defined(MAXNAMELEN)
635 name_max = MAXNAMELEN;
637 # if defined(NAME_MAX)
640 # error "buffer size for readdir_r cannot be determined"
644 *size = (size_t)offsetof(struct dirent, d_name) + name_max + 1;
652 * Get next file in the directory. Will not return "." or ".." on
653 * UNIX. If an error occurs, the contents of "filename" are
654 * undefined. The error is never set if the function succeeds.
656 * @param iter the iterator
657 * @param filename string to be set to the next file in the dir
658 * @param error return location for error
659 * @returns #TRUE if filename was filled in with a new filename
662 _dbus_directory_get_next_file (DBusDirIter *iter,
663 DBusString *filename,
666 struct dirent *d, *ent;
670 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
672 if (!dirent_buf_size (iter->d, &buf_size))
674 dbus_set_error (error, DBUS_ERROR_FAILED,
675 "Can't calculate buffer size when reading directory");
679 d = (struct dirent *)dbus_malloc (buf_size);
682 dbus_set_error (error, DBUS_ERROR_NO_MEMORY,
683 "No memory to read directory entry");
688 err = readdir_r (iter->d, d, &ent);
692 dbus_set_error (error,
693 _dbus_error_from_errno (err),
694 "%s", _dbus_strerror (err));
699 else if (ent->d_name[0] == '.' &&
700 (ent->d_name[1] == '\0' ||
701 (ent->d_name[1] == '.' && ent->d_name[2] == '\0')))
705 _dbus_string_set_length (filename, 0);
706 if (!_dbus_string_append (filename, ent->d_name))
708 dbus_set_error (error, DBUS_ERROR_NO_MEMORY,
709 "No memory to read directory entry");
722 * Closes a directory iteration.
725 _dbus_directory_close (DBusDirIter *iter)
732 fill_user_info_from_group (struct group *g,
736 _dbus_assert (g->gr_name != NULL);
738 info->gid = g->gr_gid;
739 info->groupname = _dbus_strdup (g->gr_name);
741 /* info->members = dbus_strdupv (g->gr_mem) */
743 if (info->groupname == NULL)
745 dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
753 fill_group_info (DBusGroupInfo *info,
755 const DBusString *groupname,
758 const char *group_c_str;
760 _dbus_assert (groupname != NULL || gid != DBUS_GID_UNSET);
761 _dbus_assert (groupname == NULL || gid == DBUS_GID_UNSET);
764 group_c_str = _dbus_string_get_const_data (groupname);
768 /* For now assuming that the getgrnam() and getgrgid() flavors
769 * always correspond to the pwnam flavors, if not we have
770 * to add more configure checks.
773 #if defined (HAVE_POSIX_GETPWNAM_R) || defined (HAVE_NONPOSIX_GETPWNAM_R)
782 /* retrieve maximum needed size for buf */
783 buflen = sysconf (_SC_GETGR_R_SIZE_MAX);
785 /* sysconf actually returns a long, but everything else expects size_t,
786 * so just recast here.
787 * https://bugs.freedesktop.org/show_bug.cgi?id=17061
789 if ((long) buflen <= 0)
795 buf = dbus_malloc (buflen);
798 dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
803 #ifdef HAVE_POSIX_GETPWNAM_R
805 result = getgrnam_r (group_c_str, &g_str, buf, buflen,
808 result = getgrgid_r (gid, &g_str, buf, buflen,
811 g = getgrnam_r (group_c_str, &g_str, buf, buflen);
813 #endif /* !HAVE_POSIX_GETPWNAM_R */
814 /* Try a bigger buffer if ERANGE was returned:
815 https://bugs.freedesktop.org/show_bug.cgi?id=16727
817 if (result == ERANGE && buflen < 512 * 1024)
828 if (result == 0 && g == &g_str)
830 b = fill_user_info_from_group (g, info, error);
836 dbus_set_error (error, _dbus_error_from_errno (errno),
837 "Group %s unknown or failed to look it up\n",
838 group_c_str ? group_c_str : "???");
843 #else /* ! HAVE_GETPWNAM_R */
845 /* I guess we're screwed on thread safety here */
848 g = getgrnam (group_c_str);
852 return fill_user_info_from_group (g, info, error);
856 dbus_set_error (error, _dbus_error_from_errno (errno),
857 "Group %s unknown or failed to look it up\n",
858 group_c_str ? group_c_str : "???");
862 #endif /* ! HAVE_GETPWNAM_R */
866 * Initializes the given DBusGroupInfo struct
867 * with information about the given group name.
869 * @param info the group info struct
870 * @param groupname name of group
871 * @param error the error return
872 * @returns #FALSE if error is set
875 _dbus_group_info_fill (DBusGroupInfo *info,
876 const DBusString *groupname,
879 return fill_group_info (info, DBUS_GID_UNSET,
885 * Initializes the given DBusGroupInfo struct
886 * with information about the given group ID.
888 * @param info the group info struct
889 * @param gid group ID
890 * @param error the error return
891 * @returns #FALSE if error is set
894 _dbus_group_info_fill_gid (DBusGroupInfo *info,
898 return fill_group_info (info, gid, NULL, error);
902 * Parse a UNIX user from the bus config file. On Windows, this should
903 * simply always fail (just return #FALSE).
905 * @param username the username text
906 * @param uid_p place to return the uid
907 * @returns #TRUE on success
910 _dbus_parse_unix_user_from_config (const DBusString *username,
913 return _dbus_get_user_id (username, uid_p);
918 * Parse a UNIX group from the bus config file. On Windows, this should
919 * simply always fail (just return #FALSE).
921 * @param groupname the groupname text
922 * @param gid_p place to return the gid
923 * @returns #TRUE on success
926 _dbus_parse_unix_group_from_config (const DBusString *groupname,
929 return _dbus_get_group_id (groupname, gid_p);
933 * Gets all groups corresponding to the given UNIX user ID. On UNIX,
934 * just calls _dbus_groups_from_uid(). On Windows, should always
935 * fail since we don't know any UNIX groups.
938 * @param group_ids return location for array of group IDs
939 * @param n_group_ids return location for length of returned array
940 * @returns #TRUE if the UID existed and we got some credentials
943 _dbus_unix_groups_from_uid (dbus_uid_t uid,
944 dbus_gid_t **group_ids,
947 return _dbus_groups_from_uid (uid, group_ids, n_group_ids);
951 * Checks to see if the UNIX user ID is at the console.
952 * Should always fail on Windows (set the error to
953 * #DBUS_ERROR_NOT_SUPPORTED).
955 * @param uid UID of person to check
956 * @param error return location for errors
957 * @returns #TRUE if the UID is the same as the console user and there are no errors
960 _dbus_unix_user_is_at_console (dbus_uid_t uid,
963 return _dbus_is_console_user (uid, error);
968 * Checks to see if the UNIX user ID matches the UID of
969 * the process. Should always return #FALSE on Windows.
971 * @param uid the UNIX user ID
972 * @returns #TRUE if this uid owns the process.
975 _dbus_unix_user_is_process_owner (dbus_uid_t uid)
977 return uid == _dbus_geteuid ();
981 * Checks to see if the Windows user SID matches the owner of
982 * the process. Should always return #FALSE on UNIX.
984 * @param windows_sid the Windows user SID
985 * @returns #TRUE if this user owns the process.
988 _dbus_windows_user_is_process_owner (const char *windows_sid)
993 /** @} */ /* End of DBusInternalsUtils functions */
996 * @addtogroup DBusString
1001 * Get the directory name from a complete filename
1002 * @param filename the filename
1003 * @param dirname string to append directory name to
1004 * @returns #FALSE if no memory
1007 _dbus_string_get_dirname (const DBusString *filename,
1008 DBusString *dirname)
1012 _dbus_assert (filename != dirname);
1013 _dbus_assert (filename != NULL);
1014 _dbus_assert (dirname != NULL);
1016 /* Ignore any separators on the end */
1017 sep = _dbus_string_get_length (filename);
1019 return _dbus_string_append (dirname, "."); /* empty string passed in */
1021 while (sep > 0 && _dbus_string_get_byte (filename, sep - 1) == '/')
1024 _dbus_assert (sep >= 0);
1027 return _dbus_string_append (dirname, "/");
1029 /* Now find the previous separator */
1030 _dbus_string_find_byte_backward (filename, sep, '/', &sep);
1032 return _dbus_string_append (dirname, ".");
1034 /* skip multiple separators */
1035 while (sep > 0 && _dbus_string_get_byte (filename, sep - 1) == '/')
1038 _dbus_assert (sep >= 0);
1041 _dbus_string_get_byte (filename, 0) == '/')
1042 return _dbus_string_append (dirname, "/");
1044 return _dbus_string_copy_len (filename, 0, sep - 0,
1045 dirname, _dbus_string_get_length (dirname));
1047 /** @} */ /* DBusString stuff */
1050 string_squash_nonprintable (DBusString *str)
1055 buf = _dbus_string_get_data (str);
1056 len = _dbus_string_get_length (str);
1058 for (i = 0; i < len; i++)
1060 unsigned char c = (unsigned char) buf[i];
1063 else if (c < 0x20 || c > 127)
1069 * Get a printable string describing the command used to execute
1070 * the process with pid. This string should only be used for
1071 * informative purposes such as logging; it may not be trusted.
1073 * The command is guaranteed to be printable ASCII and no longer
1076 * @param pid Process id
1077 * @param str Append command to this string
1078 * @param max_len Maximum length of returned command
1079 * @param error return location for errors
1080 * @returns #FALSE on error
1083 _dbus_command_for_pid (unsigned long pid,
1088 /* This is all Linux-specific for now */
1093 if (!_dbus_string_init (&path))
1095 _DBUS_SET_OOM (error);
1099 if (!_dbus_string_init (&cmdline))
1101 _DBUS_SET_OOM (error);
1102 _dbus_string_free (&path);
1106 if (!_dbus_string_append_printf (&path, "/proc/%ld/cmdline", pid))
1109 fd = open (_dbus_string_get_const_data (&path), O_RDONLY);
1112 dbus_set_error (error,
1113 _dbus_error_from_errno (errno),
1114 "Failed to open \"%s\": %s",
1115 _dbus_string_get_const_data (&path),
1116 _dbus_strerror (errno));
1120 if (!_dbus_read (fd, &cmdline, max_len))
1122 dbus_set_error (error,
1123 _dbus_error_from_errno (errno),
1124 "Failed to read from \"%s\": %s",
1125 _dbus_string_get_const_data (&path),
1126 _dbus_strerror (errno));
1130 if (!_dbus_close (fd, error))
1133 string_squash_nonprintable (&cmdline);
1135 if (!_dbus_string_copy (&cmdline, 0, str, _dbus_string_get_length (str)))
1138 _dbus_string_free (&cmdline);
1139 _dbus_string_free (&path);
1142 _DBUS_SET_OOM (error);
1144 _dbus_string_free (&cmdline);
1145 _dbus_string_free (&path);