ARM: dts: rmobile: Reserve space in R-Car Gen3 DTs
[platform/kernel/u-boot.git] / cmd / bootefi.c
1 // SPDX-License-Identifier: GPL-2.0+
2 /*
3  *  EFI application loader
4  *
5  *  Copyright (c) 2016 Alexander Graf
6  */
7
8 #include <common.h>
9 #include <charset.h>
10 #include <command.h>
11 #include <dm.h>
12 #include <efi_loader.h>
13 #include <efi_selftest.h>
14 #include <env.h>
15 #include <errno.h>
16 #include <image.h>
17 #include <malloc.h>
18 #include <linux/libfdt.h>
19 #include <linux/libfdt_env.h>
20 #include <mapmem.h>
21 #include <memalign.h>
22 #include <asm-generic/sections.h>
23 #include <linux/linkage.h>
24
25 DECLARE_GLOBAL_DATA_PTR;
26
27 static struct efi_device_path *bootefi_image_path;
28 static struct efi_device_path *bootefi_device_path;
29
30 /**
31  * Set the load options of an image from an environment variable.
32  *
33  * @handle:             the image handle
34  * @env_var:            name of the environment variable
35  * @load_options:       pointer to load options (output)
36  * Return:              status code
37  */
38 static efi_status_t set_load_options(efi_handle_t handle, const char *env_var,
39                                      u16 **load_options)
40 {
41         struct efi_loaded_image *loaded_image_info;
42         size_t size;
43         const char *env = env_get(env_var);
44         u16 *pos;
45         efi_status_t ret;
46
47         *load_options = NULL;
48         ret = EFI_CALL(systab.boottime->open_protocol(
49                                         handle,
50                                         &efi_guid_loaded_image,
51                                         (void **)&loaded_image_info,
52                                         efi_root, NULL,
53                                         EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL));
54         if (ret != EFI_SUCCESS)
55                 return EFI_INVALID_PARAMETER;
56
57         loaded_image_info->load_options = NULL;
58         loaded_image_info->load_options_size = 0;
59         if (!env)
60                 goto out;
61
62         size = utf8_utf16_strlen(env) + 1;
63         loaded_image_info->load_options = calloc(size, sizeof(u16));
64         if (!loaded_image_info->load_options) {
65                 printf("ERROR: Out of memory\n");
66                 EFI_CALL(systab.boottime->close_protocol(handle,
67                                                          &efi_guid_loaded_image,
68                                                          efi_root, NULL));
69                 return EFI_OUT_OF_RESOURCES;
70         }
71         pos = loaded_image_info->load_options;
72         *load_options = pos;
73         utf8_utf16_strcpy(&pos, env);
74         loaded_image_info->load_options_size = size * 2;
75
76 out:
77         return EFI_CALL(systab.boottime->close_protocol(handle,
78                                                         &efi_guid_loaded_image,
79                                                         efi_root, NULL));
80 }
81
82 #if !CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE)
83
84 /**
85  * copy_fdt() - Copy the device tree to a new location available to EFI
86  *
87  * The FDT is copied to a suitable location within the EFI memory map.
88  * Additional 12 KiB are added to the space in case the device tree needs to be
89  * expanded later with fdt_open_into().
90  *
91  * @fdtp:       On entry a pointer to the flattened device tree.
92  *              On exit a pointer to the copy of the flattened device tree.
93  *              FDT start
94  * Return:      status code
95  */
96 static efi_status_t copy_fdt(void **fdtp)
97 {
98         unsigned long fdt_ram_start = -1L, fdt_pages;
99         efi_status_t ret = 0;
100         void *fdt, *new_fdt;
101         u64 new_fdt_addr;
102         uint fdt_size;
103         int i;
104
105         for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
106                 u64 ram_start = gd->bd->bi_dram[i].start;
107                 u64 ram_size = gd->bd->bi_dram[i].size;
108
109                 if (!ram_size)
110                         continue;
111
112                 if (ram_start < fdt_ram_start)
113                         fdt_ram_start = ram_start;
114         }
115
116         /*
117          * Give us at least 12 KiB of breathing room in case the device tree
118          * needs to be expanded later.
119          */
120         fdt = *fdtp;
121         fdt_pages = efi_size_in_pages(fdt_totalsize(fdt) + 0x3000);
122         fdt_size = fdt_pages << EFI_PAGE_SHIFT;
123
124         /*
125          * Safe fdt location is at 127 MiB.
126          * On the sandbox convert from the sandbox address space.
127          */
128         new_fdt_addr = (uintptr_t)map_sysmem(fdt_ram_start + 0x7f00000 +
129                                              fdt_size, 0);
130         ret = efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS,
131                                  EFI_ACPI_RECLAIM_MEMORY, fdt_pages,
132                                  &new_fdt_addr);
133         if (ret != EFI_SUCCESS) {
134                 /* If we can't put it there, put it somewhere */
135                 new_fdt_addr = (ulong)memalign(EFI_PAGE_SIZE, fdt_size);
136                 ret = efi_allocate_pages(EFI_ALLOCATE_MAX_ADDRESS,
137                                          EFI_ACPI_RECLAIM_MEMORY, fdt_pages,
138                                          &new_fdt_addr);
139                 if (ret != EFI_SUCCESS) {
140                         printf("ERROR: Failed to reserve space for FDT\n");
141                         goto done;
142                 }
143         }
144         new_fdt = (void *)(uintptr_t)new_fdt_addr;
145         memcpy(new_fdt, fdt, fdt_totalsize(fdt));
146         fdt_set_totalsize(new_fdt, fdt_size);
147
148         *fdtp = (void *)(uintptr_t)new_fdt_addr;
149 done:
150         return ret;
151 }
152
153 static void efi_reserve_memory(u64 addr, u64 size)
154 {
155         /* Convert from sandbox address space. */
156         addr = (uintptr_t)map_sysmem(addr, 0);
157         if (efi_add_memory_map(addr, size,
158                                EFI_RESERVED_MEMORY_TYPE) != EFI_SUCCESS)
159                 printf("Reserved memory mapping failed addr %llx size %llx\n",
160                        addr, size);
161 }
162
163 /**
164  * efi_carve_out_dt_rsv() - Carve out DT reserved memory ranges
165  *
166  * The mem_rsv entries of the FDT are added to the memory map. Any failures are
167  * ignored because this is not critical and we would rather continue to try to
168  * boot.
169  *
170  * @fdt: Pointer to device tree
171  */
172 static void efi_carve_out_dt_rsv(void *fdt)
173 {
174         int nr_rsv, i;
175         u64 addr, size;
176         int nodeoffset, subnode;
177
178         nr_rsv = fdt_num_mem_rsv(fdt);
179
180         /* Look for an existing entry and add it to the efi mem map. */
181         for (i = 0; i < nr_rsv; i++) {
182                 if (fdt_get_mem_rsv(fdt, i, &addr, &size) != 0)
183                         continue;
184                 efi_reserve_memory(addr, size);
185         }
186
187         /* process reserved-memory */
188         nodeoffset = fdt_subnode_offset(fdt, 0, "reserved-memory");
189         if (nodeoffset >= 0) {
190                 subnode = fdt_first_subnode(fdt, nodeoffset);
191                 while (subnode >= 0) {
192                         /* check if this subnode has a reg property */
193                         addr = fdtdec_get_addr_size(fdt, subnode, "reg",
194                                                     (fdt_size_t *)&size);
195                         /*
196                          * The /reserved-memory node may have children with
197                          * a size instead of a reg property.
198                          */
199                         if (addr != FDT_ADDR_T_NONE &&
200                             fdtdec_get_is_enabled(fdt, subnode))
201                                 efi_reserve_memory(addr, size);
202                         subnode = fdt_next_subnode(fdt, subnode);
203                 }
204         }
205 }
206
207 /**
208  * get_config_table() - get configuration table
209  *
210  * @guid:       GUID of the configuration table
211  * Return:      pointer to configuration table or NULL
212  */
213 static void *get_config_table(const efi_guid_t *guid)
214 {
215         size_t i;
216
217         for (i = 0; i < systab.nr_tables; i++) {
218                 if (!guidcmp(guid, &systab.tables[i].guid))
219                         return systab.tables[i].table;
220         }
221         return NULL;
222 }
223
224 #endif /* !CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE) */
225
226 /**
227  * efi_install_fdt() - install device tree
228  *
229  * If fdt is not EFI_FDT_USE_INTERNAL, the device tree located at that memory
230  * address will will be installed as configuration table, otherwise the device
231  * tree located at the address indicated by environment variable fdt_addr or as
232  * fallback fdtcontroladdr will be used.
233  *
234  * On architectures using ACPI tables device trees shall not be installed as
235  * configuration table.
236  *
237  * @fdt:        address of device tree or EFI_FDT_USE_INTERNAL to use the
238  *              the hardware device tree as indicated by environment variable
239  *              fdt_addr or as fallback the internal device tree as indicated by
240  *              the environment variable fdtcontroladdr
241  * Return:      status code
242  */
243 efi_status_t efi_install_fdt(void *fdt)
244 {
245         /*
246          * The EBBR spec requires that we have either an FDT or an ACPI table
247          * but not both.
248          */
249 #if CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE)
250         if (fdt) {
251                 printf("ERROR: can't have ACPI table and device tree.\n");
252                 return EFI_LOAD_ERROR;
253         }
254 #else
255         bootm_headers_t img = { 0 };
256         efi_status_t ret;
257
258         if (fdt == EFI_FDT_USE_INTERNAL) {
259                 const char *fdt_opt;
260                 uintptr_t fdt_addr;
261
262                 /* Look for device tree that is already installed */
263                 if (get_config_table(&efi_guid_fdt))
264                         return EFI_SUCCESS;
265                 /* Check if there is a hardware device tree */
266                 fdt_opt = env_get("fdt_addr");
267                 /* Use our own device tree as fallback */
268                 if (!fdt_opt) {
269                         fdt_opt = env_get("fdtcontroladdr");
270                         if (!fdt_opt) {
271                                 printf("ERROR: need device tree\n");
272                                 return EFI_NOT_FOUND;
273                         }
274                 }
275                 fdt_addr = simple_strtoul(fdt_opt, NULL, 16);
276                 if (!fdt_addr) {
277                         printf("ERROR: invalid $fdt_addr or $fdtcontroladdr\n");
278                         return EFI_LOAD_ERROR;
279                 }
280                 fdt = map_sysmem(fdt_addr, 0);
281         }
282
283         /* Install device tree */
284         if (fdt_check_header(fdt)) {
285                 printf("ERROR: invalid device tree\n");
286                 return EFI_LOAD_ERROR;
287         }
288
289         /* Prepare device tree for payload */
290         ret = copy_fdt(&fdt);
291         if (ret) {
292                 printf("ERROR: out of memory\n");
293                 return EFI_OUT_OF_RESOURCES;
294         }
295
296         if (image_setup_libfdt(&img, fdt, 0, NULL)) {
297                 printf("ERROR: failed to process device tree\n");
298                 return EFI_LOAD_ERROR;
299         }
300
301         /* Create memory reservations as indicated by the device tree */
302         efi_carve_out_dt_rsv(fdt);
303
304         /* Install device tree as UEFI table */
305         ret = efi_install_configuration_table(&efi_guid_fdt, fdt);
306         if (ret != EFI_SUCCESS) {
307                 printf("ERROR: failed to install device tree\n");
308                 return ret;
309         }
310 #endif /* GENERATE_ACPI_TABLE */
311
312         return EFI_SUCCESS;
313 }
314
315 /**
316  * do_bootefi_exec() - execute EFI binary
317  *
318  * @handle:             handle of loaded image
319  * Return:              status code
320  *
321  * Load the EFI binary into a newly assigned memory unwinding the relocation
322  * information, install the loaded image protocol, and call the binary.
323  */
324 static efi_status_t do_bootefi_exec(efi_handle_t handle)
325 {
326         efi_status_t ret;
327         efi_uintn_t exit_data_size = 0;
328         u16 *exit_data = NULL;
329         u16 *load_options;
330
331         /* Transfer environment variable as load options */
332         ret = set_load_options(handle, "bootargs", &load_options);
333         if (ret != EFI_SUCCESS)
334                 return ret;
335
336         /* Call our payload! */
337         ret = EFI_CALL(efi_start_image(handle, &exit_data_size, &exit_data));
338         printf("## Application terminated, r = %lu\n", ret & ~EFI_ERROR_MASK);
339         if (ret && exit_data) {
340                 printf("## %ls\n", exit_data);
341                 efi_free_pool(exit_data);
342         }
343
344         efi_restore_gd();
345
346         free(load_options);
347
348         return ret;
349 }
350
351 /**
352  * do_efibootmgr() - execute EFI boot manager
353  *
354  * Return:      status code
355  */
356 static int do_efibootmgr(void)
357 {
358         efi_handle_t handle;
359         efi_status_t ret;
360
361         ret = efi_bootmgr_load(&handle);
362         if (ret != EFI_SUCCESS) {
363                 printf("EFI boot manager: Cannot load any image\n");
364                 return CMD_RET_FAILURE;
365         }
366
367         ret = do_bootefi_exec(handle);
368
369         if (ret != EFI_SUCCESS)
370                 return CMD_RET_FAILURE;
371
372         return CMD_RET_SUCCESS;
373 }
374
375 /**
376  * do_bootefi_image() - execute EFI binary
377  *
378  * Set up memory image for the binary to be loaded, prepare device path, and
379  * then call do_bootefi_exec() to execute it.
380  *
381  * @image_opt:  string of image start address
382  * Return:      status code
383  */
384 static int do_bootefi_image(const char *image_opt)
385 {
386         void *image_buf;
387         unsigned long addr, size;
388         const char *size_str;
389         efi_status_t ret;
390
391 #ifdef CONFIG_CMD_BOOTEFI_HELLO
392         if (!strcmp(image_opt, "hello")) {
393                 char *saddr;
394
395                 saddr = env_get("loadaddr");
396                 size = __efi_helloworld_end - __efi_helloworld_begin;
397
398                 if (saddr)
399                         addr = simple_strtoul(saddr, NULL, 16);
400                 else
401                         addr = CONFIG_SYS_LOAD_ADDR;
402
403                 image_buf = map_sysmem(addr, size);
404                 memcpy(image_buf, __efi_helloworld_begin, size);
405
406                 efi_free_pool(bootefi_device_path);
407                 efi_free_pool(bootefi_image_path);
408                 bootefi_device_path = NULL;
409                 bootefi_image_path = NULL;
410         } else
411 #endif
412         {
413                 size_str = env_get("filesize");
414                 if (size_str)
415                         size = simple_strtoul(size_str, NULL, 16);
416                 else
417                         size = 0;
418
419                 addr = simple_strtoul(image_opt, NULL, 16);
420                 /* Check that a numeric value was passed */
421                 if (!addr && *image_opt != '0')
422                         return CMD_RET_USAGE;
423
424                 image_buf = map_sysmem(addr, size);
425         }
426         ret = efi_run_image(image_buf, size);
427
428         if (ret != EFI_SUCCESS)
429                 return CMD_RET_FAILURE;
430
431         return CMD_RET_SUCCESS;
432 }
433
434 /**
435  * efi_run_image() - run loaded UEFI image
436  *
437  * @source_buffer:      memory address of the UEFI image
438  * @source_size:        size of the UEFI image
439  * Return:              status code
440  */
441 efi_status_t efi_run_image(void *source_buffer, efi_uintn_t source_size)
442 {
443         efi_handle_t mem_handle = NULL, handle;
444         struct efi_device_path *file_path = NULL;
445         efi_status_t ret;
446
447         if (!bootefi_device_path || !bootefi_image_path) {
448                 /*
449                  * Special case for efi payload not loaded from disk,
450                  * such as 'bootefi hello' or for example payload
451                  * loaded directly into memory via JTAG, etc:
452                  */
453                 file_path = efi_dp_from_mem(EFI_RESERVED_MEMORY_TYPE,
454                                             (uintptr_t)source_buffer,
455                                             source_size);
456                 /*
457                  * Make sure that device for device_path exist
458                  * in load_image(). Otherwise, shell and grub will fail.
459                  */
460                 ret = efi_create_handle(&mem_handle);
461                 if (ret != EFI_SUCCESS)
462                         goto out;
463
464                 ret = efi_add_protocol(mem_handle, &efi_guid_device_path,
465                                        file_path);
466                 if (ret != EFI_SUCCESS)
467                         goto out;
468         } else {
469                 file_path = efi_dp_append(bootefi_device_path,
470                                           bootefi_image_path);
471         }
472
473         ret = EFI_CALL(efi_load_image(false, efi_root, file_path, source_buffer,
474                                       source_size, &handle));
475         if (ret != EFI_SUCCESS)
476                 goto out;
477
478         ret = do_bootefi_exec(handle);
479
480 out:
481         efi_delete_handle(mem_handle);
482         efi_free_pool(file_path);
483         return ret;
484 }
485
486 #ifdef CONFIG_CMD_BOOTEFI_SELFTEST
487 static efi_status_t bootefi_run_prepare(const char *load_options_path,
488                 struct efi_device_path *device_path,
489                 struct efi_device_path *image_path,
490                 struct efi_loaded_image_obj **image_objp,
491                 struct efi_loaded_image **loaded_image_infop)
492 {
493         efi_status_t ret;
494         u16 *load_options;
495
496         ret = efi_setup_loaded_image(device_path, image_path, image_objp,
497                                      loaded_image_infop);
498         if (ret != EFI_SUCCESS)
499                 return ret;
500
501         /* Transfer environment variable as load options */
502         return set_load_options((efi_handle_t)*image_objp, load_options_path,
503                                 &load_options);
504 }
505
506 /**
507  * bootefi_test_prepare() - prepare to run an EFI test
508  *
509  * Prepare to run a test as if it were provided by a loaded image.
510  *
511  * @image_objp:         pointer to be set to the loaded image handle
512  * @loaded_image_infop: pointer to be set to the loaded image protocol
513  * @path:               dummy file path used to construct the device path
514  *                      set in the loaded image protocol
515  * @load_options_path:  name of a U-Boot environment variable. Its value is
516  *                      set as load options in the loaded image protocol.
517  * Return:              status code
518  */
519 static efi_status_t bootefi_test_prepare
520                 (struct efi_loaded_image_obj **image_objp,
521                  struct efi_loaded_image **loaded_image_infop, const char *path,
522                  const char *load_options_path)
523 {
524         efi_status_t ret;
525
526         /* Construct a dummy device path */
527         bootefi_device_path = efi_dp_from_mem(EFI_RESERVED_MEMORY_TYPE, 0, 0);
528         if (!bootefi_device_path)
529                 return EFI_OUT_OF_RESOURCES;
530
531         bootefi_image_path = efi_dp_from_file(NULL, 0, path);
532         if (!bootefi_image_path) {
533                 ret = EFI_OUT_OF_RESOURCES;
534                 goto failure;
535         }
536
537         ret = bootefi_run_prepare(load_options_path, bootefi_device_path,
538                                   bootefi_image_path, image_objp,
539                                   loaded_image_infop);
540         if (ret == EFI_SUCCESS)
541                 return ret;
542
543         efi_free_pool(bootefi_image_path);
544         bootefi_image_path = NULL;
545 failure:
546         efi_free_pool(bootefi_device_path);
547         bootefi_device_path = NULL;
548         return ret;
549 }
550
551 /**
552  * bootefi_run_finish() - finish up after running an EFI test
553  *
554  * @loaded_image_info: Pointer to a struct which holds the loaded image info
555  * @image_obj: Pointer to a struct which holds the loaded image object
556  */
557 static void bootefi_run_finish(struct efi_loaded_image_obj *image_obj,
558                                struct efi_loaded_image *loaded_image_info)
559 {
560         efi_restore_gd();
561         free(loaded_image_info->load_options);
562         efi_delete_handle(&image_obj->header);
563 }
564
565 /**
566  * do_efi_selftest() - execute EFI selftest
567  *
568  * Return:      status code
569  */
570 static int do_efi_selftest(void)
571 {
572         struct efi_loaded_image_obj *image_obj;
573         struct efi_loaded_image *loaded_image_info;
574         efi_status_t ret;
575
576         ret = bootefi_test_prepare(&image_obj, &loaded_image_info,
577                                    "\\selftest", "efi_selftest");
578         if (ret != EFI_SUCCESS)
579                 return CMD_RET_FAILURE;
580
581         /* Execute the test */
582         ret = EFI_CALL(efi_selftest(&image_obj->header, &systab));
583         bootefi_run_finish(image_obj, loaded_image_info);
584
585         return ret != EFI_SUCCESS;
586 }
587 #endif /* CONFIG_CMD_BOOTEFI_SELFTEST */
588
589 /**
590  * do_bootefi() - execute `bootefi` command
591  *
592  * @cmdtp:      table entry describing command
593  * @flag:       bitmap indicating how the command was invoked
594  * @argc:       number of arguments
595  * @argv:       command line arguments
596  * Return:      status code
597  */
598 static int do_bootefi(struct cmd_tbl *cmdtp, int flag, int argc,
599                       char *const argv[])
600 {
601         efi_status_t ret;
602         void *fdt;
603
604         if (argc < 2)
605                 return CMD_RET_USAGE;
606
607         /* Initialize EFI drivers */
608         ret = efi_init_obj_list();
609         if (ret != EFI_SUCCESS) {
610                 printf("Error: Cannot initialize UEFI sub-system, r = %lu\n",
611                        ret & ~EFI_ERROR_MASK);
612                 return CMD_RET_FAILURE;
613         }
614
615         if (argc > 2) {
616                 uintptr_t fdt_addr;
617
618                 fdt_addr = simple_strtoul(argv[2], NULL, 16);
619                 fdt = map_sysmem(fdt_addr, 0);
620         } else {
621                 fdt = EFI_FDT_USE_INTERNAL;
622         }
623         ret = efi_install_fdt(fdt);
624         if (ret == EFI_INVALID_PARAMETER)
625                 return CMD_RET_USAGE;
626         else if (ret != EFI_SUCCESS)
627                 return CMD_RET_FAILURE;
628
629         if (!strcmp(argv[1], "bootmgr"))
630                 return do_efibootmgr();
631 #ifdef CONFIG_CMD_BOOTEFI_SELFTEST
632         else if (!strcmp(argv[1], "selftest"))
633                 return do_efi_selftest();
634 #endif
635
636         return do_bootefi_image(argv[1]);
637 }
638
639 #ifdef CONFIG_SYS_LONGHELP
640 static char bootefi_help_text[] =
641         "<image address> [fdt address]\n"
642         "  - boot EFI payload stored at address <image address>.\n"
643         "    If specified, the device tree located at <fdt address> gets\n"
644         "    exposed as EFI configuration table.\n"
645 #ifdef CONFIG_CMD_BOOTEFI_HELLO
646         "bootefi hello\n"
647         "  - boot a sample Hello World application stored within U-Boot\n"
648 #endif
649 #ifdef CONFIG_CMD_BOOTEFI_SELFTEST
650         "bootefi selftest [fdt address]\n"
651         "  - boot an EFI selftest application stored within U-Boot\n"
652         "    Use environment variable efi_selftest to select a single test.\n"
653         "    Use 'setenv efi_selftest list' to enumerate all tests.\n"
654 #endif
655         "bootefi bootmgr [fdt address]\n"
656         "  - load and boot EFI payload based on BootOrder/BootXXXX variables.\n"
657         "\n"
658         "    If specified, the device tree located at <fdt address> gets\n"
659         "    exposed as EFI configuration table.\n";
660 #endif
661
662 U_BOOT_CMD(
663         bootefi, 3, 0, do_bootefi,
664         "Boots an EFI payload from memory",
665         bootefi_help_text
666 );
667
668 /**
669  * efi_set_bootdev() - set boot device
670  *
671  * This function is called when a file is loaded, e.g. via the 'load' command.
672  * We use the path to this file to inform the UEFI binary about the boot device.
673  *
674  * @dev:        device, e.g. "MMC"
675  * @devnr:      number of the device, e.g. "1:2"
676  * @path:       path to file loaded
677  */
678 void efi_set_bootdev(const char *dev, const char *devnr, const char *path)
679 {
680         struct efi_device_path *device, *image;
681         efi_status_t ret;
682
683         /* efi_set_bootdev is typically called repeatedly, recover memory */
684         efi_free_pool(bootefi_device_path);
685         efi_free_pool(bootefi_image_path);
686
687         ret = efi_dp_from_name(dev, devnr, path, &device, &image);
688         if (ret == EFI_SUCCESS) {
689                 bootefi_device_path = device;
690                 if (image) {
691                         /* FIXME: image should not contain device */
692                         struct efi_device_path *image_tmp = image;
693
694                         efi_dp_split_file_path(image, &device, &image);
695                         efi_free_pool(image_tmp);
696                 }
697                 bootefi_image_path = image;
698         } else {
699                 bootefi_device_path = NULL;
700                 bootefi_image_path = NULL;
701         }
702 }