1 # Copyright 2012 The Chromium Authors
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
5 """Top-level presubmit script for cc.
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools.
13 PRESUBMIT_VERSION = '2.0.0'
16 CC_SOURCE_FILES=(r'^cc[\\/].*\.(cc|h)$',)
18 def _CheckChangeLintsClean(input_api, output_api):
19 allowlist = CC_SOURCE_FILES
21 source_filter = lambda x: input_api.FilterSourceFile(x, allowlist, denylist)
23 return input_api.canned_checks.CheckChangeLintsClean(
24 input_api, output_api, source_filter, lint_filters=[], verbose_level=1)
26 def _CheckAsserts(input_api, output_api, allowlist=CC_SOURCE_FILES,
28 denylist = tuple(denylist or input_api.DEFAULT_FILES_TO_SKIP)
29 source_file_filter = lambda x: input_api.FilterSourceFile(x, allowlist,
34 for f in input_api.AffectedSourceFiles(source_file_filter):
35 contents = input_api.ReadFile(f, 'rb')
36 # WebKit ASSERT() is not allowed.
37 if re.search(r"\bASSERT\(", contents):
38 assert_files.append(f.LocalPath())
41 return [output_api.PresubmitError(
42 'These files use ASSERT instead of using DCHECK:',
46 def _CheckStdAbs(input_api, output_api,
47 allowlist=CC_SOURCE_FILES, denylist=None):
48 denylist = tuple(denylist or input_api.DEFAULT_FILES_TO_SKIP)
49 source_file_filter = lambda x: input_api.FilterSourceFile(x,
53 using_std_abs_files = []
55 missing_std_prefix_files = []
57 for f in input_api.AffectedSourceFiles(source_file_filter):
58 contents = input_api.ReadFile(f, 'rb')
59 if re.search(r"using std::f?abs;", contents):
60 using_std_abs_files.append(f.LocalPath())
61 if re.search(r"\bfabsf?\(", contents):
62 found_fabs_files.append(f.LocalPath());
64 no_std_prefix = r"(?<!std::)"
65 # Matches occurrences of abs/absf/fabs/fabsf without a "std::" prefix.
66 abs_without_prefix = r"%s(\babsf?\()" % no_std_prefix
67 fabs_without_prefix = r"%s(\bfabsf?\()" % no_std_prefix
68 # Skips matching any lines that have "// NOLINT".
69 no_nolint = r"(?![^\n]*//\s+NOLINT)"
71 expression = re.compile("(%s|%s)%s" %
72 (abs_without_prefix, fabs_without_prefix, no_nolint))
73 if expression.search(contents):
74 missing_std_prefix_files.append(f.LocalPath())
77 if using_std_abs_files:
78 result.append(output_api.PresubmitError(
79 'These files have "using std::abs" which is not permitted.',
80 items=using_std_abs_files))
82 result.append(output_api.PresubmitError(
83 'std::abs() should be used instead of std::fabs() for consistency.',
84 items=found_fabs_files))
85 if missing_std_prefix_files:
86 result.append(output_api.PresubmitError(
87 'These files use abs(), absf(), fabs(), or fabsf() without qualifying '
88 'the std namespace. Please use std::abs() in all places.',
89 items=missing_std_prefix_files))
92 def _CheckPassByValue(input_api,
94 allowlist=CC_SOURCE_FILES,
96 denylist = tuple(denylist or input_api.DEFAULT_FILES_TO_SKIP)
97 source_file_filter = lambda x: input_api.FilterSourceFile(x,
103 # Well-defined simple classes the same size as a primitive type.
104 pass_by_value_types = ['base::Time',
108 for f in input_api.AffectedSourceFiles(source_file_filter):
109 contents = input_api.ReadFile(f, 'rb')
112 r'\bconst +' + '(?P<type>(%s))&' % sep.join(pass_by_value_types),
115 local_errors.append(output_api.PresubmitError(
116 '%s passes %s by const ref instead of by value.' %
117 (f.LocalPath(), match.group('type'))))
120 def _CheckTodos(input_api, output_api):
123 source_file_filter = lambda x: x
124 for f in input_api.AffectedSourceFiles(source_file_filter):
125 contents = input_api.ReadFile(f, 'rb')
126 if ('FIX'+'ME') in contents:
127 errors.append(f.LocalPath())
130 return [output_api.PresubmitError(
131 'All TODO comments should be of the form TODO(name/bug). ' +
132 'Use TODO instead of FIX' + 'ME',
136 def _CheckDoubleAngles(input_api, output_api, allowlist=CC_SOURCE_FILES,
140 source_file_filter = lambda x: input_api.FilterSourceFile(x,
143 for f in input_api.AffectedSourceFiles(source_file_filter):
144 contents = input_api.ReadFile(f, 'rb')
145 if ('> >') in contents:
146 errors.append(f.LocalPath())
149 return [output_api.PresubmitError('Use >> instead of > >:', items=errors)]
152 def _FindUnquotedQuote(contents, pos):
153 match = re.search(r"(?<!\\)(?P<quote>\")", contents[pos:])
154 return -1 if not match else match.start("quote") + pos
156 def _FindUselessIfdefs(input_api, output_api):
158 source_file_filter = lambda x: x
159 for f in input_api.AffectedSourceFiles(source_file_filter):
160 contents = input_api.ReadFile(f, 'rb')
161 if re.search(r'#if\s*0\s', contents):
162 errors.append(f.LocalPath())
164 return [output_api.PresubmitError(
165 'Don\'t use #if '+'0; just delete the code.',
169 def _FindNamespaceInBlock(pos, namespace, contents, allowlist=[]):
176 while pos < len(contents) and brace_count > 0:
177 if open_brace < pos: open_brace = contents.find("{", pos)
178 if close_brace < pos: close_brace = contents.find("}", pos)
179 if quote < pos: quote = _FindUnquotedQuote(contents, pos)
180 if name < pos: name = contents.find(("%s::" % namespace), pos)
183 return False # The namespace is not used at all.
185 open_brace = len(contents)
187 close_brace = len(contents)
189 quote = len(contents)
191 next = min(open_brace, min(close_brace, min(quote, name)))
193 if next == open_brace:
195 elif next == close_brace:
198 quote_count = 0 if quote_count else 1
199 elif next == name and not quote_count:
202 if re.match(w, contents[next:]):
210 # Checks for the use of cc:: within the cc namespace, which is usually
212 def _CheckNamespace(input_api, output_api):
215 source_file_filter = lambda x: x
216 for f in input_api.AffectedSourceFiles(source_file_filter):
217 contents = input_api.ReadFile(f, 'rb')
218 match = re.search(r'namespace\s*cc\s*{', contents)
221 if _FindNamespaceInBlock(match.end(),
224 allowlist=allowlist):
225 errors.append(f.LocalPath())
228 return [output_api.PresubmitError(
229 'Do not use cc:: inside of the cc namespace.',
233 def _CheckForUseOfWrongClock(input_api,
235 allowlist=CC_SOURCE_FILES,
237 """Make sure new lines of code don't use a clock susceptible to skew."""
238 denylist = tuple(denylist or input_api.DEFAULT_FILES_TO_SKIP)
239 source_file_filter = lambda x: input_api.FilterSourceFile(x,
242 # Regular expression that should detect any explicit references to the
243 # base::Time type (or base::Clock/DefaultClock), whether in using decls,
244 # typedefs, or to call static methods.
245 base_time_type_pattern = r'(^|\W)base::(Time|Clock|DefaultClock)(\W|$)'
247 # Regular expression that should detect references to the base::Time class
248 # members, such as a call to base::Time::Now.
249 base_time_member_pattern = r'(^|\W)(Time|Clock|DefaultClock)::'
251 # Regular expression to detect "using base::Time" declarations. We want to
252 # prevent these from triggerring a warning. For example, it's perfectly
253 # reasonable for code to be written like this:
257 # int64 foo_us = foo_s * Time::kMicrosecondsPerSecond;
258 using_base_time_decl_pattern = r'^\s*using\s+(::)?base::Time\s*;'
260 # Regular expression to detect references to the kXXX constants in the
261 # base::Time class. We want to prevent these from triggerring a warning.
262 base_time_konstant_pattern = r'(^|\W)Time::k\w+'
264 problem_re = input_api.re.compile(
265 r'(' + base_time_type_pattern + r')|(' + base_time_member_pattern + r')')
266 exception_re = input_api.re.compile(
267 r'(' + using_base_time_decl_pattern + r')|(' +
268 base_time_konstant_pattern + r')')
270 for f in input_api.AffectedSourceFiles(source_file_filter):
271 for line_number, line in f.ChangedContents():
272 if problem_re.search(line):
273 if not exception_re.search(line):
275 ' %s:%d\n %s' % (f.LocalPath(), line_number, line.strip()))
278 return [output_api.PresubmitPromptOrNotify(
279 'You added one or more references to the base::Time class and/or one\n'
280 'of its member functions (or base::Clock/DefaultClock). In cc code,\n'
281 'it is most certainly incorrect! Instead use base::TimeTicks.\n\n'
282 '\n'.join(problems))]
286 def CheckChangeOnUpload(input_api, output_api):
288 results += _CheckAsserts(input_api, output_api)
289 results += _CheckStdAbs(input_api, output_api)
290 results += _CheckPassByValue(input_api, output_api)
291 results += _CheckChangeLintsClean(input_api, output_api)
292 results += _CheckTodos(input_api, output_api)
293 results += _CheckDoubleAngles(input_api, output_api)
294 results += _CheckNamespace(input_api, output_api)
295 results += _CheckForUseOfWrongClock(input_api, output_api)
296 results += _FindUselessIfdefs(input_api, output_api)