1 # Copyright 2012 The Chromium Authors
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
5 """Top-level presubmit script for cc.
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools.
13 PRESUBMIT_VERSION = '2.0.0'
15 CC_SOURCE_FILES=(r'^cc[\\/].*\.(cc|h)$',)
17 def _CheckChangeLintsClean(input_api, output_api):
18 allowlist = CC_SOURCE_FILES
20 source_filter = lambda x: input_api.FilterSourceFile(x, allowlist, denylist)
22 return input_api.canned_checks.CheckChangeLintsClean(
23 input_api, output_api, source_filter, lint_filters=[], verbose_level=1)
25 def _CheckAsserts(input_api, output_api, allowlist=CC_SOURCE_FILES,
27 denylist = tuple(denylist or input_api.DEFAULT_FILES_TO_SKIP)
28 source_file_filter = lambda x: input_api.FilterSourceFile(x, allowlist,
33 for f in input_api.AffectedSourceFiles(source_file_filter):
34 contents = input_api.ReadFile(f, 'rb')
35 # WebKit ASSERT() is not allowed.
36 if re.search(r"\bASSERT\(", contents):
37 assert_files.append(f.LocalPath())
40 return [output_api.PresubmitError(
41 'These files use ASSERT instead of using DCHECK:',
45 def _CheckStdAbs(input_api, output_api,
46 allowlist=CC_SOURCE_FILES, denylist=None):
47 denylist = tuple(denylist or input_api.DEFAULT_FILES_TO_SKIP)
48 source_file_filter = lambda x: input_api.FilterSourceFile(x,
52 using_std_abs_files = []
54 missing_std_prefix_files = []
56 for f in input_api.AffectedSourceFiles(source_file_filter):
57 contents = input_api.ReadFile(f, 'rb')
58 if re.search(r"using std::f?abs;", contents):
59 using_std_abs_files.append(f.LocalPath())
60 if re.search(r"\bfabsf?\(", contents):
61 found_fabs_files.append(f.LocalPath());
63 no_std_prefix = r"(?<!std::)"
64 # Matches occurrences of abs/absf/fabs/fabsf without a "std::" prefix.
65 abs_without_prefix = r"%s(\babsf?\()" % no_std_prefix
66 fabs_without_prefix = r"%s(\bfabsf?\()" % no_std_prefix
67 # Skips matching any lines that have "// NOLINT".
68 no_nolint = r"(?![^\n]*//\s+NOLINT)"
70 expression = re.compile("(%s|%s)%s" %
71 (abs_without_prefix, fabs_without_prefix, no_nolint))
72 if expression.search(contents):
73 missing_std_prefix_files.append(f.LocalPath())
76 if using_std_abs_files:
77 result.append(output_api.PresubmitError(
78 'These files have "using std::abs" which is not permitted.',
79 items=using_std_abs_files))
81 result.append(output_api.PresubmitError(
82 'std::abs() should be used instead of std::fabs() for consistency.',
83 items=found_fabs_files))
84 if missing_std_prefix_files:
85 result.append(output_api.PresubmitError(
86 'These files use abs(), absf(), fabs(), or fabsf() without qualifying '
87 'the std namespace. Please use std::abs() in all places.',
88 items=missing_std_prefix_files))
91 def _CheckPassByValue(input_api,
93 allowlist=CC_SOURCE_FILES,
95 denylist = tuple(denylist or input_api.DEFAULT_FILES_TO_SKIP)
96 source_file_filter = lambda x: input_api.FilterSourceFile(x,
102 # Well-defined simple classes the same size as a primitive type.
103 pass_by_value_types = ['base::Time',
107 for f in input_api.AffectedSourceFiles(source_file_filter):
108 contents = input_api.ReadFile(f, 'rb')
111 r'\bconst +' + '(?P<type>(%s))&' % sep.join(pass_by_value_types),
114 local_errors.append(output_api.PresubmitError(
115 '%s passes %s by const ref instead of by value.' %
116 (f.LocalPath(), match.group('type'))))
119 def _CheckTodos(input_api, output_api):
122 source_file_filter = lambda x: x
123 for f in input_api.AffectedSourceFiles(source_file_filter):
124 contents = input_api.ReadFile(f, 'rb')
125 if ('FIX'+'ME') in contents:
126 errors.append(f.LocalPath())
129 return [output_api.PresubmitError(
130 'All TODO comments should be of the form TODO(name/bug). ' +
131 'Use TODO instead of FIX' + 'ME',
135 def _CheckDoubleAngles(input_api, output_api, allowlist=CC_SOURCE_FILES,
139 source_file_filter = lambda x: input_api.FilterSourceFile(x,
142 for f in input_api.AffectedSourceFiles(source_file_filter):
143 contents = input_api.ReadFile(f, 'rb')
144 if ('> >') in contents:
145 errors.append(f.LocalPath())
148 return [output_api.PresubmitError('Use >> instead of > >:', items=errors)]
151 def _FindUnquotedQuote(contents, pos):
152 match = re.search(r"(?<!\\)(?P<quote>\")", contents[pos:])
153 return -1 if not match else match.start("quote") + pos
155 def _FindUselessIfdefs(input_api, output_api):
157 source_file_filter = lambda x: x
158 for f in input_api.AffectedSourceFiles(source_file_filter):
159 contents = input_api.ReadFile(f, 'rb')
160 if re.search(r'#if\s*0\s', contents):
161 errors.append(f.LocalPath())
163 return [output_api.PresubmitError(
164 'Don\'t use #if '+'0; just delete the code.',
168 def _FindNamespaceInBlock(pos, namespace, contents, allowlist=[]):
175 while pos < len(contents) and brace_count > 0:
176 if open_brace < pos: open_brace = contents.find("{", pos)
177 if close_brace < pos: close_brace = contents.find("}", pos)
178 if quote < pos: quote = _FindUnquotedQuote(contents, pos)
179 if name < pos: name = contents.find(("%s::" % namespace), pos)
182 return False # The namespace is not used at all.
184 open_brace = len(contents)
186 close_brace = len(contents)
188 quote = len(contents)
190 next = min(open_brace, min(close_brace, min(quote, name)))
192 if next == open_brace:
194 elif next == close_brace:
197 quote_count = 0 if quote_count else 1
198 elif next == name and not quote_count:
201 if re.match(w, contents[next:]):
209 # Checks for the use of cc:: within the cc namespace, which is usually
211 def _CheckNamespace(input_api, output_api):
214 source_file_filter = lambda x: x
215 for f in input_api.AffectedSourceFiles(source_file_filter):
216 contents = input_api.ReadFile(f, 'rb')
217 match = re.search(r'namespace\s*cc\s*{', contents)
220 if _FindNamespaceInBlock(match.end(),
223 allowlist=allowlist):
224 errors.append(f.LocalPath())
227 return [output_api.PresubmitError(
228 'Do not use cc:: inside of the cc namespace.',
232 def _CheckForUseOfWrongClock(input_api,
234 allowlist=CC_SOURCE_FILES,
236 """Make sure new lines of code don't use a clock susceptible to skew."""
237 denylist = tuple(denylist or input_api.DEFAULT_FILES_TO_SKIP)
238 source_file_filter = lambda x: input_api.FilterSourceFile(x,
241 # Regular expression that should detect any explicit references to the
242 # base::Time type (or base::Clock/DefaultClock), whether in using decls,
243 # typedefs, or to call static methods.
244 base_time_type_pattern = r'(^|\W)base::(Time|Clock|DefaultClock)(\W|$)'
246 # Regular expression that should detect references to the base::Time class
247 # members, such as a call to base::Time::Now.
248 base_time_member_pattern = r'(^|\W)(Time|Clock|DefaultClock)::'
250 # Regular expression to detect "using base::Time" declarations. We want to
251 # prevent these from triggerring a warning. For example, it's perfectly
252 # reasonable for code to be written like this:
256 # int64 foo_us = foo_s * Time::kMicrosecondsPerSecond;
257 using_base_time_decl_pattern = r'^\s*using\s+(::)?base::Time\s*;'
259 # Regular expression to detect references to the kXXX constants in the
260 # base::Time class. We want to prevent these from triggerring a warning.
261 base_time_konstant_pattern = r'(^|\W)Time::k\w+'
263 problem_re = input_api.re.compile(
264 r'(' + base_time_type_pattern + r')|(' + base_time_member_pattern + r')')
265 exception_re = input_api.re.compile(
266 r'(' + using_base_time_decl_pattern + r')|(' +
267 base_time_konstant_pattern + r')')
269 for f in input_api.AffectedSourceFiles(source_file_filter):
270 for line_number, line in f.ChangedContents():
271 if problem_re.search(line):
272 if not exception_re.search(line):
274 ' %s:%d\n %s' % (f.LocalPath(), line_number, line.strip()))
277 return [output_api.PresubmitPromptOrNotify(
278 'You added one or more references to the base::Time class and/or one\n'
279 'of its member functions (or base::Clock/DefaultClock). In cc code,\n'
280 'it is most certainly incorrect! Instead use base::TimeTicks.\n\n'
281 '\n'.join(problems))]
285 def CheckChangeOnUpload(input_api, output_api):
287 results += _CheckAsserts(input_api, output_api)
288 results += _CheckStdAbs(input_api, output_api)
289 results += _CheckPassByValue(input_api, output_api)
290 results += _CheckChangeLintsClean(input_api, output_api)
291 results += _CheckTodos(input_api, output_api)
292 results += _CheckDoubleAngles(input_api, output_api)
293 results += _CheckNamespace(input_api, output_api)
294 results += _CheckForUseOfWrongClock(input_api, output_api)
295 results += _FindUselessIfdefs(input_api, output_api)