1 /* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
2 /* config-parser.c XML-library-agnostic configuration file parser
4 * Copyright (C) 2003, 2004 Red Hat, Inc.
6 * Licensed under the Academic Free License version 2.1
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version.
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
25 #include "config-parser-common.h"
26 #include "config-parser.h"
32 #include <dbus/dbus-list.h>
33 #include <dbus/dbus-internals.h>
34 #include <dbus/dbus-misc.h>
35 #include <dbus/dbus-sysdeps.h>
40 /* we ignore policies for unknown groups/users */
55 unsigned int had_content : 1;
61 unsigned int ignore_missing : 1;
62 unsigned int if_selinux_enabled : 1;
63 unsigned int selinux_root_relative : 1;
69 unsigned long gid_uid_or_at_console;
83 * Parser for bus configuration file.
85 struct BusConfigParser
87 int refcount; /**< Reference count */
89 DBusString basedir; /**< Directory we resolve paths relative to */
91 DBusList *stack; /**< stack of Element */
93 char *user; /**< user to run as */
95 char *servicehelper; /**< location of the setuid helper */
97 char *bus_type; /**< Message bus type */
99 DBusList *listen_on; /**< List of addresses to listen to */
101 DBusList *mechanisms; /**< Auth mechanisms */
103 DBusList *service_dirs; /**< BusConfigServiceDirs to look for session services in */
105 DBusList *conf_dirs; /**< Directories to look for policy configuration in */
107 BusPolicy *policy; /**< Security policy */
109 BusLimits limits; /**< Limits */
111 char *pidfile; /**< PID file */
113 DBusList *included_files; /**< Included files stack */
115 DBusHashTable *service_context_table; /**< Map service names to SELinux contexts */
117 unsigned int fork : 1; /**< TRUE to fork into daemon mode */
119 unsigned int syslog : 1; /**< TRUE to enable syslog */
120 unsigned int keep_umask : 1; /**< TRUE to keep original umask when forking */
122 unsigned int is_toplevel : 1; /**< FALSE if we are a sub-config-file inside another one */
124 unsigned int allow_anonymous : 1; /**< TRUE to allow anonymous connections */
128 push_element (BusConfigParser *parser,
133 _dbus_assert (type != ELEMENT_NONE);
135 e = dbus_new0 (Element, 1);
139 if (!_dbus_list_append (&parser->stack, e))
151 element_free (Element *e)
153 if (e->type == ELEMENT_LIMIT)
154 dbus_free (e->d.limit.name);
160 pop_element (BusConfigParser *parser)
164 e = _dbus_list_pop_last (&parser->stack);
170 peek_element (BusConfigParser *parser)
174 e = _dbus_list_get_last (&parser->stack);
180 top_element_type (BusConfigParser *parser)
184 e = _dbus_list_get_last (&parser->stack);
193 merge_service_context_hash (DBusHashTable *dest,
203 _dbus_hash_iter_init (from, &iter);
204 while (_dbus_hash_iter_next (&iter))
206 const char *service = _dbus_hash_iter_get_string_key (&iter);
207 const char *context = _dbus_hash_iter_get_value (&iter);
209 service_copy = _dbus_strdup (service);
210 if (service_copy == NULL)
212 context_copy = _dbus_strdup (context);
213 if (context_copy == NULL)
216 if (!_dbus_hash_table_insert_string (dest, service_copy, context_copy))
227 dbus_free (service_copy);
230 dbus_free (context_copy);
236 * Create a new BusConfigServiceDir. Takes ownership of path if #TRUE is returned.
238 * @returns #FALSE on OOM
240 static BusConfigServiceDir *
241 bus_config_service_dir_new_take (char *path,
242 BusServiceDirFlags flags)
244 BusConfigServiceDir *self = dbus_new0 (BusConfigServiceDir, 1);
249 self->path = path; /* take ownership */
255 bus_config_service_dir_free (BusConfigServiceDir *self)
257 dbus_free (self->path);
261 static BusConfigServiceDir *
262 service_dirs_find_dir (DBusList **service_dirs,
267 _dbus_assert (dir != NULL);
269 for (link = *service_dirs; link; link = _dbus_list_get_next_link(service_dirs, link))
271 BusConfigServiceDir *link_dir = link->data;
273 if (strcmp (dir, link_dir->path) == 0)
281 service_dirs_append_link_unique_or_free (DBusList **service_dirs,
284 BusConfigServiceDir *dir = dir_link->data;
285 BusConfigServiceDir *already = service_dirs_find_dir (service_dirs,
290 _dbus_list_append_link (service_dirs, dir_link);
294 /* BusServiceDirFlags are chosen such that the compatible thing to do
295 * is to "and" the flags. For example, if a directory is explicitly
296 * added as a <servicedir> (which is watched with inotify) and is also
297 * the transient service directory (which should not be watched),
298 * the compatible thing to do is to watch it. */
299 already->flags &= dir->flags;
300 bus_config_service_dir_free (dir_link->data);
301 _dbus_list_free_link (dir_link);
306 * Consume links from dirs (a list of paths), converting them into links in
307 * service_dirs (a list of unique BusServiceDir).
309 * On success, return TRUE. dirs will be empty, and every original entry in
310 * dirs will have a corresponding service_dirs entry.
312 * On OOM, return FALSE. Each original entry of dirs has either been
313 * appended to service_dirs or left in dirs.
316 service_dirs_absorb_string_list (DBusList **service_dirs,
318 BusServiceDirFlags flags)
322 _dbus_assert (service_dirs != NULL);
323 _dbus_assert (dirs != NULL);
325 while ((link = _dbus_list_pop_first_link (dirs)))
327 char *path = link->data;
328 BusConfigServiceDir *dir = bus_config_service_dir_new_take (path, flags);
332 /* OOM - roll back (this does not need to allocate memory) */
333 _dbus_list_prepend_link (service_dirs, link);
337 /* Ownership of path has been taken by dir */
339 service_dirs_append_link_unique_or_free (service_dirs, link);
342 _dbus_assert (*dirs == NULL);
347 merge_included (BusConfigParser *parser,
348 BusConfigParser *included,
353 if (!bus_policy_merge (parser->policy,
360 if (!merge_service_context_hash (parser->service_context_table,
361 included->service_context_table))
367 if (included->user != NULL)
369 dbus_free (parser->user);
370 parser->user = included->user;
371 included->user = NULL;
374 if (included->bus_type != NULL)
376 dbus_free (parser->bus_type);
377 parser->bus_type = included->bus_type;
378 included->bus_type = NULL;
384 if (included->keep_umask)
385 parser->keep_umask = TRUE;
387 if (included->allow_anonymous)
388 parser->allow_anonymous = TRUE;
390 if (included->pidfile != NULL)
392 dbus_free (parser->pidfile);
393 parser->pidfile = included->pidfile;
394 included->pidfile = NULL;
397 if (included->servicehelper != NULL)
399 dbus_free (parser->servicehelper);
400 parser->servicehelper = included->servicehelper;
401 included->servicehelper = NULL;
404 while ((link = _dbus_list_pop_first_link (&included->listen_on)))
405 _dbus_list_append_link (&parser->listen_on, link);
407 while ((link = _dbus_list_pop_first_link (&included->mechanisms)))
408 _dbus_list_append_link (&parser->mechanisms, link);
410 while ((link = _dbus_list_pop_first_link (&included->service_dirs)))
411 service_dirs_append_link_unique_or_free (&parser->service_dirs, link);
413 while ((link = _dbus_list_pop_first_link (&included->conf_dirs)))
414 _dbus_list_append_link (&parser->conf_dirs, link);
420 seen_include (BusConfigParser *parser,
421 const DBusString *file)
425 iter = parser->included_files;
428 if (! strcmp (_dbus_string_get_const_data (file), iter->data))
431 iter = _dbus_list_get_next_link (&parser->included_files, iter);
438 bus_config_parser_new (const DBusString *basedir,
439 dbus_bool_t is_toplevel,
440 const BusConfigParser *parent)
442 BusConfigParser *parser;
444 parser = dbus_new0 (BusConfigParser, 1);
448 parser->is_toplevel = !!is_toplevel;
450 if (!_dbus_string_init (&parser->basedir))
456 if (((parser->policy = bus_policy_new ()) == NULL) ||
457 !_dbus_string_copy (basedir, 0, &parser->basedir, 0) ||
458 ((parser->service_context_table = _dbus_hash_table_new (DBUS_HASH_STRING,
460 dbus_free)) == NULL))
463 bus_policy_unref (parser->policy);
465 _dbus_string_free (&parser->basedir);
473 /* Initialize the parser's limits from the parent. */
474 parser->limits = parent->limits;
476 /* Use the parent's list of included_files to avoid
477 circular inclusions. */
478 parser->included_files = parent->included_files;
483 /* Make up some numbers! woot! */
484 parser->limits.max_incoming_bytes = _DBUS_ONE_MEGABYTE * 127;
485 parser->limits.max_outgoing_bytes = _DBUS_ONE_MEGABYTE * 127;
486 parser->limits.max_message_size = _DBUS_ONE_MEGABYTE * 32;
488 /* We set relatively conservative values here since due to the
489 way SCM_RIGHTS works we need to preallocate an array for the
490 maximum number of file descriptors we can receive. Picking a
491 high value here thus translates directly to more memory
493 parser->limits.max_incoming_unix_fds = DBUS_DEFAULT_MESSAGE_UNIX_FDS*4;
494 parser->limits.max_outgoing_unix_fds = DBUS_DEFAULT_MESSAGE_UNIX_FDS*4;
495 parser->limits.max_message_unix_fds = DBUS_DEFAULT_MESSAGE_UNIX_FDS;
497 /* Making this long means the user has to wait longer for an error
498 * message if something screws up, but making it too short means
499 * they might see a false failure.
501 parser->limits.activation_timeout = 25000; /* 25 seconds */
503 /* Making this long risks making a DOS attack easier, but too short
504 * and legitimate auth will fail. If interactive auth (ask user for
505 * password) is allowed, then potentially it has to be quite long.
507 parser->limits.auth_timeout = 30000; /* 30 seconds */
509 /* Do not allow a fd to stay forever in dbus-daemon
510 * https://bugs.freedesktop.org/show_bug.cgi?id=80559
512 parser->limits.pending_fd_timeout = 150000; /* 2.5 minutes */
514 parser->limits.max_incomplete_connections = 64;
515 parser->limits.max_connections_per_user = 256;
517 /* Note that max_completed_connections / max_connections_per_user
518 * is the number of users that would have to work together to
519 * DOS all the other users.
521 parser->limits.max_completed_connections = 2048;
523 parser->limits.max_pending_activations = 512;
524 parser->limits.max_services_per_connection = 512;
526 /* For this one, keep in mind that it isn't only the memory used
527 * by the match rules, but slowdown from linearly walking a big
528 * list of them. A client adding more than this is almost
529 * certainly a bad idea for that reason, and should change to a
530 * smaller number of wider-net match rules - getting every last
531 * message to the bus is probably better than having a thousand
534 parser->limits.max_match_rules_per_connection = 512;
536 parser->limits.reply_timeout = -1; /* never */
538 /* this is effectively a limit on message queue size for messages
539 * that require a reply
541 parser->limits.max_replies_per_connection = 128;
544 parser->refcount = 1;
550 bus_config_parser_ref (BusConfigParser *parser)
552 _dbus_assert (parser->refcount > 0);
554 parser->refcount += 1;
560 bus_config_parser_unref (BusConfigParser *parser)
562 _dbus_assert (parser->refcount > 0);
564 parser->refcount -= 1;
566 if (parser->refcount == 0)
568 while (parser->stack != NULL)
569 pop_element (parser);
571 dbus_free (parser->user);
572 dbus_free (parser->servicehelper);
573 dbus_free (parser->bus_type);
574 dbus_free (parser->pidfile);
576 _dbus_list_foreach (&parser->listen_on,
577 (DBusForeachFunction) dbus_free,
580 _dbus_list_clear (&parser->listen_on);
582 _dbus_list_foreach (&parser->service_dirs,
583 (DBusForeachFunction) bus_config_service_dir_free,
586 _dbus_list_clear (&parser->service_dirs);
588 _dbus_list_foreach (&parser->conf_dirs,
589 (DBusForeachFunction) dbus_free,
592 _dbus_list_clear (&parser->conf_dirs);
594 _dbus_list_foreach (&parser->mechanisms,
595 (DBusForeachFunction) dbus_free,
598 _dbus_list_clear (&parser->mechanisms);
600 _dbus_string_free (&parser->basedir);
603 bus_policy_unref (parser->policy);
605 if (parser->service_context_table)
606 _dbus_hash_table_unref (parser->service_context_table);
613 bus_config_parser_check_doctype (BusConfigParser *parser,
617 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
619 if (strcmp (doctype, "busconfig") != 0)
621 dbus_set_error (error,
623 "Configuration file has the wrong document type %s",
638 locate_attributes (BusConfigParser *parser,
639 const char *element_name,
640 const char **attribute_names,
641 const char **attribute_values,
643 const char *first_attribute_name,
644 const char **first_attribute_retloc,
652 LocateAttr attrs[MAX_ATTRS];
656 _dbus_assert (first_attribute_name != NULL);
657 _dbus_assert (first_attribute_retloc != NULL);
662 attrs[0].name = first_attribute_name;
663 attrs[0].retloc = first_attribute_retloc;
664 *first_attribute_retloc = NULL;
666 va_start (args, first_attribute_retloc);
668 name = va_arg (args, const char*);
669 retloc = va_arg (args, const char**);
673 _dbus_assert (retloc != NULL);
674 _dbus_assert (n_attrs < MAX_ATTRS);
676 attrs[n_attrs].name = name;
677 attrs[n_attrs].retloc = retloc;
681 name = va_arg (args, const char*);
682 retloc = va_arg (args, const char**);
688 while (attribute_names[i])
697 if (strcmp (attrs[j].name, attribute_names[i]) == 0)
699 retloc = attrs[j].retloc;
703 dbus_set_error (error, DBUS_ERROR_FAILED,
704 "Attribute \"%s\" repeated twice on the same <%s> element",
705 attrs[j].name, element_name);
710 *retloc = attribute_values[i];
719 dbus_set_error (error, DBUS_ERROR_FAILED,
720 "Attribute \"%s\" is invalid on <%s> element in this context",
721 attribute_names[i], element_name);
734 check_no_attributes (BusConfigParser *parser,
735 const char *element_name,
736 const char **attribute_names,
737 const char **attribute_values,
740 if (attribute_names[0] != NULL)
742 dbus_set_error (error, DBUS_ERROR_FAILED,
743 "Attribute \"%s\" is invalid on <%s> element in this context",
744 attribute_names[0], element_name);
752 start_busconfig_child (BusConfigParser *parser,
753 const char *element_name,
754 const char **attribute_names,
755 const char **attribute_values,
758 ElementType element_type;
760 element_type = bus_config_parser_element_name_to_type (element_name);
762 if (element_type == ELEMENT_USER)
764 if (!check_no_attributes (parser, "user", attribute_names, attribute_values, error))
767 if (push_element (parser, ELEMENT_USER) == NULL)
775 else if (element_type == ELEMENT_CONFIGTYPE)
777 if (!check_no_attributes (parser, "type", attribute_names, attribute_values, error))
780 if (push_element (parser, ELEMENT_CONFIGTYPE) == NULL)
788 else if (element_type == ELEMENT_FORK)
790 if (!check_no_attributes (parser, "fork", attribute_names, attribute_values, error))
793 if (push_element (parser, ELEMENT_FORK) == NULL)
803 else if (element_type == ELEMENT_SYSLOG)
805 if (!check_no_attributes (parser, "syslog", attribute_names, attribute_values, error))
808 if (push_element (parser, ELEMENT_SYSLOG) == NULL)
814 parser->syslog = TRUE;
818 else if (element_type == ELEMENT_KEEP_UMASK)
820 if (!check_no_attributes (parser, "keep_umask", attribute_names, attribute_values, error))
823 if (push_element (parser, ELEMENT_KEEP_UMASK) == NULL)
829 parser->keep_umask = TRUE;
833 else if (element_type == ELEMENT_PIDFILE)
835 if (!check_no_attributes (parser, "pidfile", attribute_names, attribute_values, error))
838 if (push_element (parser, ELEMENT_PIDFILE) == NULL)
846 else if (element_type == ELEMENT_LISTEN)
848 if (!check_no_attributes (parser, "listen", attribute_names, attribute_values, error))
851 if (push_element (parser, ELEMENT_LISTEN) == NULL)
859 else if (element_type == ELEMENT_AUTH)
861 if (!check_no_attributes (parser, "auth", attribute_names, attribute_values, error))
864 if (push_element (parser, ELEMENT_AUTH) == NULL)
872 else if (element_type == ELEMENT_SERVICEHELPER)
874 if (!check_no_attributes (parser, "servicehelper", attribute_names, attribute_values, error))
877 if (push_element (parser, ELEMENT_SERVICEHELPER) == NULL)
885 else if (element_type == ELEMENT_INCLUDEDIR)
887 if (!check_no_attributes (parser, "includedir", attribute_names, attribute_values, error))
890 if (push_element (parser, ELEMENT_INCLUDEDIR) == NULL)
898 else if (element_type == ELEMENT_STANDARD_SESSION_SERVICEDIRS)
900 DBusError local_error = DBUS_ERROR_INIT;
901 DBusList *dirs = NULL;
903 if (!check_no_attributes (parser, "standard_session_servicedirs", attribute_names, attribute_values, error))
906 if (push_element (parser, ELEMENT_STANDARD_SESSION_SERVICEDIRS) == NULL)
912 if (_dbus_set_up_transient_session_servicedirs (&dirs, &local_error))
914 if (!service_dirs_absorb_string_list (&parser->service_dirs, &dirs,
915 BUS_SERVICE_DIR_FLAGS_NO_WATCH |
916 BUS_SERVICE_DIR_FLAGS_STRICT_NAMING))
919 _dbus_list_foreach (&dirs, (DBusForeachFunction) dbus_free,
921 _dbus_list_clear (&dirs);
927 /* Failing to set these up isn't fatal */
928 _dbus_warn ("Unable to set up transient service directory: %s",
929 local_error.message);
930 dbus_error_free (&local_error);
933 _dbus_assert (dirs == NULL);
935 if (!_dbus_get_standard_session_servicedirs (&dirs))
941 /* We have traditionally watched the standard session service
942 * directories with inotify, and allowed service files whose names do not
943 * match the bus name */
944 if (!service_dirs_absorb_string_list (&parser->service_dirs, &dirs,
945 BUS_SERVICE_DIR_FLAGS_NONE))
948 _dbus_list_foreach (&dirs, (DBusForeachFunction) dbus_free,
950 _dbus_list_clear (&dirs);
954 _dbus_assert (dirs == NULL);
958 else if (element_type == ELEMENT_STANDARD_SYSTEM_SERVICEDIRS)
963 if (!check_no_attributes (parser, "standard_system_servicedirs", attribute_names, attribute_values, error))
966 if (push_element (parser, ELEMENT_STANDARD_SYSTEM_SERVICEDIRS) == NULL)
972 if (!_dbus_get_standard_system_servicedirs (&dirs))
978 /* We have traditionally watched the standard system service
979 * directories with inotify, and allowed service files whose names do not
980 * match the bus name (the servicehelper won't successfully activate
981 * them, but we do still parse them) */
982 if (!service_dirs_absorb_string_list (&parser->service_dirs, &dirs,
983 BUS_SERVICE_DIR_FLAGS_NONE))
986 _dbus_list_foreach (&dirs, (DBusForeachFunction) dbus_free,
988 _dbus_list_clear (&dirs);
994 else if (element_type == ELEMENT_ALLOW_ANONYMOUS)
996 if (!check_no_attributes (parser, "allow_anonymous", attribute_names, attribute_values, error))
999 if (push_element (parser, ELEMENT_ALLOW_ANONYMOUS) == NULL)
1001 BUS_SET_OOM (error);
1005 parser->allow_anonymous = TRUE;
1008 else if (element_type == ELEMENT_SERVICEDIR)
1010 if (!check_no_attributes (parser, "servicedir", attribute_names, attribute_values, error))
1013 if (push_element (parser, ELEMENT_SERVICEDIR) == NULL)
1015 BUS_SET_OOM (error);
1021 else if (element_type == ELEMENT_INCLUDE)
1024 const char *if_selinux_enabled;
1025 const char *ignore_missing;
1026 const char *selinux_root_relative;
1028 if ((e = push_element (parser, ELEMENT_INCLUDE)) == NULL)
1030 BUS_SET_OOM (error);
1034 e->d.include.ignore_missing = FALSE;
1035 e->d.include.if_selinux_enabled = FALSE;
1036 e->d.include.selinux_root_relative = FALSE;
1038 if (!locate_attributes (parser, "include",
1042 "ignore_missing", &ignore_missing,
1043 "if_selinux_enabled", &if_selinux_enabled,
1044 "selinux_root_relative", &selinux_root_relative,
1048 if (ignore_missing != NULL)
1050 if (strcmp (ignore_missing, "yes") == 0)
1051 e->d.include.ignore_missing = TRUE;
1052 else if (strcmp (ignore_missing, "no") == 0)
1053 e->d.include.ignore_missing = FALSE;
1056 dbus_set_error (error, DBUS_ERROR_FAILED,
1057 "ignore_missing attribute must have value \"yes\" or \"no\"");
1062 if (if_selinux_enabled != NULL)
1064 if (strcmp (if_selinux_enabled, "yes") == 0)
1065 e->d.include.if_selinux_enabled = TRUE;
1066 else if (strcmp (if_selinux_enabled, "no") == 0)
1067 e->d.include.if_selinux_enabled = FALSE;
1070 dbus_set_error (error, DBUS_ERROR_FAILED,
1071 "if_selinux_enabled attribute must have value"
1072 " \"yes\" or \"no\"");
1077 if (selinux_root_relative != NULL)
1079 if (strcmp (selinux_root_relative, "yes") == 0)
1080 e->d.include.selinux_root_relative = TRUE;
1081 else if (strcmp (selinux_root_relative, "no") == 0)
1082 e->d.include.selinux_root_relative = FALSE;
1085 dbus_set_error (error, DBUS_ERROR_FAILED,
1086 "selinux_root_relative attribute must have value"
1087 " \"yes\" or \"no\"");
1094 else if (element_type == ELEMENT_POLICY)
1097 const char *context;
1100 const char *at_console;
1102 if ((e = push_element (parser, ELEMENT_POLICY)) == NULL)
1104 BUS_SET_OOM (error);
1108 e->d.policy.type = POLICY_IGNORED;
1110 if (!locate_attributes (parser, "policy",
1114 "context", &context,
1117 "at_console", &at_console,
1121 if (((context && user) ||
1122 (context && group) ||
1123 (context && at_console)) ||
1125 (user && at_console)) ||
1126 (group && at_console) ||
1127 !(context || user || group || at_console))
1129 dbus_set_error (error, DBUS_ERROR_FAILED,
1130 "<policy> element must have exactly one of (context|user|group|at_console) attributes");
1134 if (context != NULL)
1136 if (strcmp (context, "default") == 0)
1138 e->d.policy.type = POLICY_DEFAULT;
1140 else if (strcmp (context, "mandatory") == 0)
1142 e->d.policy.type = POLICY_MANDATORY;
1146 dbus_set_error (error, DBUS_ERROR_FAILED,
1147 "context attribute on <policy> must have the value \"default\" or \"mandatory\", not \"%s\"",
1152 else if (user != NULL)
1154 DBusString username;
1155 _dbus_string_init_const (&username, user);
1157 if (_dbus_parse_unix_user_from_config (&username,
1158 &e->d.policy.gid_uid_or_at_console))
1159 e->d.policy.type = POLICY_USER;
1161 _dbus_warn ("Unknown username \"%s\" in message bus configuration file",
1164 else if (group != NULL)
1166 DBusString group_name;
1167 _dbus_string_init_const (&group_name, group);
1169 if (_dbus_parse_unix_group_from_config (&group_name,
1170 &e->d.policy.gid_uid_or_at_console))
1171 e->d.policy.type = POLICY_GROUP;
1173 _dbus_warn ("Unknown group \"%s\" in message bus configuration file",
1176 else if (at_console != NULL)
1179 t = (strcmp (at_console, "true") == 0);
1180 if (t || strcmp (at_console, "false") == 0)
1182 e->d.policy.gid_uid_or_at_console = t;
1183 e->d.policy.type = POLICY_CONSOLE;
1187 dbus_set_error (error, DBUS_ERROR_FAILED,
1188 "Unknown value \"%s\" for at_console in message bus configuration file",
1196 _dbus_assert_not_reached ("all <policy> attributes null and we didn't set error");
1201 else if (element_type == ELEMENT_LIMIT)
1206 if ((e = push_element (parser, ELEMENT_LIMIT)) == NULL)
1208 BUS_SET_OOM (error);
1212 if (!locate_attributes (parser, "limit",
1222 dbus_set_error (error, DBUS_ERROR_FAILED,
1223 "<limit> element must have a \"name\" attribute");
1227 e->d.limit.name = _dbus_strdup (name);
1228 if (e->d.limit.name == NULL)
1230 BUS_SET_OOM (error);
1236 else if (element_type == ELEMENT_SELINUX)
1238 if (!check_no_attributes (parser, "selinux", attribute_names, attribute_values, error))
1241 if (push_element (parser, ELEMENT_SELINUX) == NULL)
1243 BUS_SET_OOM (error);
1249 else if (element_type == ELEMENT_APPARMOR)
1254 if ((e = push_element (parser, ELEMENT_APPARMOR)) == NULL)
1256 BUS_SET_OOM (error);
1260 if (!locate_attributes (parser, "apparmor",
1268 return bus_apparmor_set_mode_from_config (mode, error);
1272 dbus_set_error (error, DBUS_ERROR_FAILED,
1273 "Element <%s> not allowed inside <%s> in configuration file",
1274 element_name, "busconfig");
1280 append_rule_from_element (BusConfigParser *parser,
1281 const char *element_name,
1282 const char **attribute_names,
1283 const char **attribute_values,
1288 const char *send_interface;
1289 const char *send_member;
1290 const char *send_error;
1291 const char *send_destination;
1292 const char *send_path;
1293 const char *send_type;
1294 const char *receive_interface;
1295 const char *receive_member;
1296 const char *receive_error;
1297 const char *receive_sender;
1298 const char *receive_path;
1299 const char *receive_type;
1300 const char *eavesdrop;
1301 const char *send_requested_reply;
1302 const char *receive_requested_reply;
1304 const char *own_prefix;
1308 BusPolicyRule *rule;
1310 if (!locate_attributes (parser, element_name,
1314 "send_interface", &send_interface,
1315 "send_member", &send_member,
1316 "send_error", &send_error,
1317 "send_destination", &send_destination,
1318 "send_path", &send_path,
1319 "send_type", &send_type,
1320 "receive_interface", &receive_interface,
1321 "receive_member", &receive_member,
1322 "receive_error", &receive_error,
1323 "receive_sender", &receive_sender,
1324 "receive_path", &receive_path,
1325 "receive_type", &receive_type,
1326 "eavesdrop", &eavesdrop,
1327 "send_requested_reply", &send_requested_reply,
1328 "receive_requested_reply", &receive_requested_reply,
1330 "own_prefix", &own_prefix,
1337 if (!(send_interface || send_member || send_error || send_destination ||
1338 send_type || send_path ||
1339 receive_interface || receive_member || receive_error || receive_sender ||
1340 receive_type || receive_path || eavesdrop ||
1341 send_requested_reply || receive_requested_reply ||
1342 own || own_prefix || user || group))
1344 dbus_set_error (error, DBUS_ERROR_FAILED,
1345 "Element <%s> must have one or more attributes",
1350 if ((send_member && (send_interface == NULL && send_path == NULL)) ||
1351 (receive_member && (receive_interface == NULL && receive_path == NULL)))
1353 dbus_set_error (error, DBUS_ERROR_FAILED,
1354 "On element <%s>, if you specify a member you must specify an interface or a path. Keep in mind that not all messages have an interface field.",
1359 /* Allowed combinations of elements are:
1361 * base, must be all send or all receive:
1364 * interface + member
1367 * base send_ can combine with send_destination, send_path, send_type, send_requested_reply
1368 * base receive_ with receive_sender, receive_path, receive_type, receive_requested_reply, eavesdrop
1370 * user, group, own, own_prefix must occur alone
1372 * Pretty sure the below stuff is broken, FIXME think about it more.
1375 if ((send_interface && (send_error ||
1376 receive_interface ||
1380 receive_requested_reply ||
1381 own || own_prefix ||
1385 (send_member && (send_error ||
1386 receive_interface ||
1390 receive_requested_reply ||
1391 own || own_prefix ||
1395 (send_error && (receive_interface ||
1399 receive_requested_reply ||
1400 own || own_prefix ||
1404 (send_destination && (receive_interface ||
1408 receive_requested_reply ||
1409 own || own_prefix ||
1413 (send_type && (receive_interface ||
1417 receive_requested_reply ||
1418 own || own_prefix ||
1422 (send_path && (receive_interface ||
1426 receive_requested_reply ||
1427 own || own_prefix ||
1431 (send_requested_reply && (receive_interface ||
1435 receive_requested_reply ||
1436 own || own_prefix ||
1440 (receive_interface && (receive_error ||
1441 own || own_prefix ||
1445 (receive_member && (receive_error ||
1446 own || own_prefix ||
1450 (receive_error && (own || own_prefix ||
1454 (eavesdrop && (own || own_prefix ||
1458 (receive_requested_reply && (own || own_prefix ||
1462 (own && (own_prefix || user || group)) ||
1464 (own_prefix && (own || user || group)) ||
1468 dbus_set_error (error, DBUS_ERROR_FAILED,
1469 "Invalid combination of attributes on element <%s>",
1476 /* In BusPolicyRule, NULL represents wildcard.
1477 * In the config file, '*' represents it.
1479 #define IS_WILDCARD(str) ((str) && ((str)[0]) == '*' && ((str)[1]) == '\0')
1481 if (send_interface || send_member || send_error || send_destination ||
1482 send_path || send_type || send_requested_reply)
1486 if (IS_WILDCARD (send_interface))
1487 send_interface = NULL;
1488 if (IS_WILDCARD (send_member))
1490 if (IS_WILDCARD (send_error))
1492 if (IS_WILDCARD (send_destination))
1493 send_destination = NULL;
1494 if (IS_WILDCARD (send_path))
1496 if (IS_WILDCARD (send_type))
1499 message_type = DBUS_MESSAGE_TYPE_INVALID;
1500 if (send_type != NULL)
1502 message_type = dbus_message_type_from_string (send_type);
1503 if (message_type == DBUS_MESSAGE_TYPE_INVALID)
1505 dbus_set_error (error, DBUS_ERROR_FAILED,
1506 "Bad message type \"%s\"",
1513 !(strcmp (eavesdrop, "true") == 0 ||
1514 strcmp (eavesdrop, "false") == 0))
1516 dbus_set_error (error, DBUS_ERROR_FAILED,
1517 "Bad value \"%s\" for %s attribute, must be true or false",
1518 "eavesdrop", eavesdrop);
1522 if (send_requested_reply &&
1523 !(strcmp (send_requested_reply, "true") == 0 ||
1524 strcmp (send_requested_reply, "false") == 0))
1526 dbus_set_error (error, DBUS_ERROR_FAILED,
1527 "Bad value \"%s\" for %s attribute, must be true or false",
1528 "send_requested_reply", send_requested_reply);
1532 rule = bus_policy_rule_new (BUS_POLICY_RULE_SEND, allow);
1537 rule->d.send.eavesdrop = (strcmp (eavesdrop, "true") == 0);
1540 rule->d.send.log = (strcmp (log, "true") == 0);
1542 if (send_requested_reply)
1543 rule->d.send.requested_reply = (strcmp (send_requested_reply, "true") == 0);
1545 rule->d.send.message_type = message_type;
1546 rule->d.send.path = _dbus_strdup (send_path);
1547 rule->d.send.interface = _dbus_strdup (send_interface);
1548 rule->d.send.member = _dbus_strdup (send_member);
1549 rule->d.send.error = _dbus_strdup (send_error);
1550 rule->d.send.destination = _dbus_strdup (send_destination);
1551 if (send_path && rule->d.send.path == NULL)
1553 if (send_interface && rule->d.send.interface == NULL)
1555 if (send_member && rule->d.send.member == NULL)
1557 if (send_error && rule->d.send.error == NULL)
1559 if (send_destination && rule->d.send.destination == NULL)
1562 else if (receive_interface || receive_member || receive_error || receive_sender ||
1563 receive_path || receive_type || eavesdrop || receive_requested_reply)
1567 if (IS_WILDCARD (receive_interface))
1568 receive_interface = NULL;
1569 if (IS_WILDCARD (receive_member))
1570 receive_member = NULL;
1571 if (IS_WILDCARD (receive_error))
1572 receive_error = NULL;
1573 if (IS_WILDCARD (receive_sender))
1574 receive_sender = NULL;
1575 if (IS_WILDCARD (receive_path))
1576 receive_path = NULL;
1577 if (IS_WILDCARD (receive_type))
1578 receive_type = NULL;
1580 message_type = DBUS_MESSAGE_TYPE_INVALID;
1581 if (receive_type != NULL)
1583 message_type = dbus_message_type_from_string (receive_type);
1584 if (message_type == DBUS_MESSAGE_TYPE_INVALID)
1586 dbus_set_error (error, DBUS_ERROR_FAILED,
1587 "Bad message type \"%s\"",
1595 !(strcmp (eavesdrop, "true") == 0 ||
1596 strcmp (eavesdrop, "false") == 0))
1598 dbus_set_error (error, DBUS_ERROR_FAILED,
1599 "Bad value \"%s\" for %s attribute, must be true or false",
1600 "eavesdrop", eavesdrop);
1604 if (receive_requested_reply &&
1605 !(strcmp (receive_requested_reply, "true") == 0 ||
1606 strcmp (receive_requested_reply, "false") == 0))
1608 dbus_set_error (error, DBUS_ERROR_FAILED,
1609 "Bad value \"%s\" for %s attribute, must be true or false",
1610 "receive_requested_reply", receive_requested_reply);
1614 rule = bus_policy_rule_new (BUS_POLICY_RULE_RECEIVE, allow);
1619 rule->d.receive.eavesdrop = (strcmp (eavesdrop, "true") == 0);
1621 if (receive_requested_reply)
1622 rule->d.receive.requested_reply = (strcmp (receive_requested_reply, "true") == 0);
1624 rule->d.receive.message_type = message_type;
1625 rule->d.receive.path = _dbus_strdup (receive_path);
1626 rule->d.receive.interface = _dbus_strdup (receive_interface);
1627 rule->d.receive.member = _dbus_strdup (receive_member);
1628 rule->d.receive.error = _dbus_strdup (receive_error);
1629 rule->d.receive.origin = _dbus_strdup (receive_sender);
1631 if (receive_path && rule->d.receive.path == NULL)
1633 if (receive_interface && rule->d.receive.interface == NULL)
1635 if (receive_member && rule->d.receive.member == NULL)
1637 if (receive_error && rule->d.receive.error == NULL)
1639 if (receive_sender && rule->d.receive.origin == NULL)
1642 else if (own || own_prefix)
1644 rule = bus_policy_rule_new (BUS_POLICY_RULE_OWN, allow);
1650 if (IS_WILDCARD (own))
1653 rule->d.own.prefix = 0;
1654 rule->d.own.service_name = _dbus_strdup (own);
1655 if (own && rule->d.own.service_name == NULL)
1660 rule->d.own.prefix = 1;
1661 rule->d.own.service_name = _dbus_strdup (own_prefix);
1662 if (rule->d.own.service_name == NULL)
1668 if (IS_WILDCARD (user))
1670 rule = bus_policy_rule_new (BUS_POLICY_RULE_USER, allow);
1674 rule->d.user.uid = DBUS_UID_UNSET;
1678 DBusString username;
1681 _dbus_string_init_const (&username, user);
1683 if (_dbus_parse_unix_user_from_config (&username, &uid))
1685 rule = bus_policy_rule_new (BUS_POLICY_RULE_USER, allow);
1689 rule->d.user.uid = uid;
1693 _dbus_warn ("Unknown username \"%s\" on element <%s>",
1694 user, element_name);
1700 if (IS_WILDCARD (group))
1702 rule = bus_policy_rule_new (BUS_POLICY_RULE_GROUP, allow);
1706 rule->d.group.gid = DBUS_GID_UNSET;
1710 DBusString groupname;
1713 _dbus_string_init_const (&groupname, group);
1715 if (_dbus_parse_unix_group_from_config (&groupname, &gid))
1717 rule = bus_policy_rule_new (BUS_POLICY_RULE_GROUP, allow);
1721 rule->d.group.gid = gid;
1725 _dbus_warn ("Unknown group \"%s\" on element <%s>",
1726 group, element_name);
1731 _dbus_assert_not_reached ("Did not handle some combination of attributes on <allow> or <deny>");
1737 pe = peek_element (parser);
1738 _dbus_assert (pe != NULL);
1739 _dbus_assert (pe->type == ELEMENT_POLICY);
1741 switch (pe->d.policy.type)
1743 case POLICY_IGNORED:
1745 /* drop the rule on the floor */
1748 case POLICY_DEFAULT:
1749 if (!bus_policy_append_default_rule (parser->policy, rule))
1752 case POLICY_MANDATORY:
1753 if (!bus_policy_append_mandatory_rule (parser->policy, rule))
1757 if (!BUS_POLICY_RULE_IS_PER_CLIENT (rule))
1759 dbus_set_error (error, DBUS_ERROR_FAILED,
1760 "<%s> rule cannot be per-user because it has bus-global semantics",
1765 if (!bus_policy_append_user_rule (parser->policy, pe->d.policy.gid_uid_or_at_console,
1770 if (!BUS_POLICY_RULE_IS_PER_CLIENT (rule))
1772 dbus_set_error (error, DBUS_ERROR_FAILED,
1773 "<%s> rule cannot be per-group because it has bus-global semantics",
1778 if (!bus_policy_append_group_rule (parser->policy, pe->d.policy.gid_uid_or_at_console,
1784 case POLICY_CONSOLE:
1785 if (!bus_policy_append_console_rule (parser->policy, pe->d.policy.gid_uid_or_at_console,
1791 bus_policy_rule_unref (rule);
1798 BUS_SET_OOM (error);
1801 bus_policy_rule_unref (rule);
1806 start_policy_child (BusConfigParser *parser,
1807 const char *element_name,
1808 const char **attribute_names,
1809 const char **attribute_values,
1812 if (strcmp (element_name, "allow") == 0)
1814 if (!append_rule_from_element (parser, element_name,
1815 attribute_names, attribute_values,
1819 if (push_element (parser, ELEMENT_ALLOW) == NULL)
1821 BUS_SET_OOM (error);
1827 else if (strcmp (element_name, "deny") == 0)
1829 if (!append_rule_from_element (parser, element_name,
1830 attribute_names, attribute_values,
1834 if (push_element (parser, ELEMENT_DENY) == NULL)
1836 BUS_SET_OOM (error);
1844 dbus_set_error (error, DBUS_ERROR_FAILED,
1845 "Element <%s> not allowed inside <%s> in configuration file",
1846 element_name, "policy");
1852 start_selinux_child (BusConfigParser *parser,
1853 const char *element_name,
1854 const char **attribute_names,
1855 const char **attribute_values,
1862 context_copy = NULL;
1864 if (strcmp (element_name, "associate") == 0)
1867 const char *context;
1869 if (!locate_attributes (parser, "associate",
1874 "context", &context,
1878 if (push_element (parser, ELEMENT_ASSOCIATE) == NULL)
1880 BUS_SET_OOM (error);
1884 if (own == NULL || context == NULL)
1886 dbus_set_error (error, DBUS_ERROR_FAILED,
1887 "Element <associate> must have attributes own=\"<servicename>\" and context=\"<selinux context>\"");
1891 own_copy = _dbus_strdup (own);
1892 if (own_copy == NULL)
1894 context_copy = _dbus_strdup (context);
1895 if (context_copy == NULL)
1898 if (!_dbus_hash_table_insert_string (parser->service_context_table,
1899 own_copy, context_copy))
1906 dbus_set_error (error, DBUS_ERROR_FAILED,
1907 "Element <%s> not allowed inside <%s> in configuration file",
1908 element_name, "selinux");
1914 dbus_free (own_copy);
1917 dbus_free (context_copy);
1919 BUS_SET_OOM (error);
1924 bus_config_parser_start_element (BusConfigParser *parser,
1925 const char *element_name,
1926 const char **attribute_names,
1927 const char **attribute_values,
1932 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
1934 /* printf ("START: %s\n", element_name); */
1936 t = top_element_type (parser);
1938 if (t == ELEMENT_NONE)
1940 if (strcmp (element_name, "busconfig") == 0)
1942 if (!check_no_attributes (parser, "busconfig", attribute_names, attribute_values, error))
1945 if (push_element (parser, ELEMENT_BUSCONFIG) == NULL)
1947 BUS_SET_OOM (error);
1955 dbus_set_error (error, DBUS_ERROR_FAILED,
1956 "Unknown element <%s> at root of configuration file",
1961 else if (t == ELEMENT_BUSCONFIG)
1963 return start_busconfig_child (parser, element_name,
1964 attribute_names, attribute_values,
1967 else if (t == ELEMENT_POLICY)
1969 return start_policy_child (parser, element_name,
1970 attribute_names, attribute_values,
1973 else if (t == ELEMENT_SELINUX)
1975 return start_selinux_child (parser, element_name,
1976 attribute_names, attribute_values,
1981 dbus_set_error (error, DBUS_ERROR_FAILED,
1982 "Element <%s> is not allowed in this context",
1989 set_limit (BusConfigParser *parser,
1994 dbus_bool_t must_be_positive;
1995 dbus_bool_t must_be_int;
1997 must_be_int = FALSE;
1998 must_be_positive = FALSE;
2000 if (strcmp (name, "max_incoming_bytes") == 0)
2002 must_be_positive = TRUE;
2003 parser->limits.max_incoming_bytes = value;
2005 else if (strcmp (name, "max_incoming_unix_fds") == 0)
2007 must_be_positive = TRUE;
2008 parser->limits.max_incoming_unix_fds = value;
2010 else if (strcmp (name, "max_outgoing_bytes") == 0)
2012 must_be_positive = TRUE;
2013 parser->limits.max_outgoing_bytes = value;
2015 else if (strcmp (name, "max_outgoing_unix_fds") == 0)
2017 must_be_positive = TRUE;
2018 parser->limits.max_outgoing_unix_fds = value;
2020 else if (strcmp (name, "max_message_size") == 0)
2022 must_be_positive = TRUE;
2023 parser->limits.max_message_size = value;
2025 else if (strcmp (name, "max_message_unix_fds") == 0)
2027 must_be_positive = TRUE;
2028 parser->limits.max_message_unix_fds = value;
2030 else if (strcmp (name, "service_start_timeout") == 0)
2032 must_be_positive = TRUE;
2034 parser->limits.activation_timeout = value;
2036 else if (strcmp (name, "auth_timeout") == 0)
2038 must_be_positive = TRUE;
2040 parser->limits.auth_timeout = value;
2042 else if (strcmp (name, "pending_fd_timeout") == 0)
2044 must_be_positive = TRUE;
2046 parser->limits.pending_fd_timeout = value;
2048 else if (strcmp (name, "reply_timeout") == 0)
2050 must_be_positive = TRUE;
2052 parser->limits.reply_timeout = value;
2054 else if (strcmp (name, "max_completed_connections") == 0)
2056 must_be_positive = TRUE;
2058 parser->limits.max_completed_connections = value;
2060 else if (strcmp (name, "max_incomplete_connections") == 0)
2062 must_be_positive = TRUE;
2064 parser->limits.max_incomplete_connections = value;
2066 else if (strcmp (name, "max_connections_per_user") == 0)
2068 must_be_positive = TRUE;
2070 parser->limits.max_connections_per_user = value;
2072 else if (strcmp (name, "max_pending_service_starts") == 0)
2074 must_be_positive = TRUE;
2076 parser->limits.max_pending_activations = value;
2078 else if (strcmp (name, "max_names_per_connection") == 0)
2080 must_be_positive = TRUE;
2082 parser->limits.max_services_per_connection = value;
2084 else if (strcmp (name, "max_match_rules_per_connection") == 0)
2086 must_be_positive = TRUE;
2088 parser->limits.max_match_rules_per_connection = value;
2090 else if (strcmp (name, "max_replies_per_connection") == 0)
2092 must_be_positive = TRUE;
2094 parser->limits.max_replies_per_connection = value;
2098 dbus_set_error (error, DBUS_ERROR_FAILED,
2099 "There is no limit called \"%s\"\n",
2104 if (must_be_positive && value < 0)
2106 dbus_set_error (error, DBUS_ERROR_FAILED,
2107 "<limit name=\"%s\"> must be a positive number\n",
2113 (value < _DBUS_INT_MIN || value > _DBUS_INT_MAX))
2115 dbus_set_error (error, DBUS_ERROR_FAILED,
2116 "<limit name=\"%s\"> value is too large\n",
2125 bus_config_parser_end_element (BusConfigParser *parser,
2126 const char *element_name,
2133 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2135 /* printf ("END: %s\n", element_name); */
2137 t = top_element_type (parser);
2139 if (t == ELEMENT_NONE)
2141 /* should probably be an assertion failure but
2142 * being paranoid about XML parsers
2144 dbus_set_error (error, DBUS_ERROR_FAILED,
2145 "XML parser ended element with no element on the stack");
2149 n = bus_config_parser_element_type_to_name (t);
2150 _dbus_assert (n != NULL);
2151 if (strcmp (n, element_name) != 0)
2153 /* should probably be an assertion failure but
2154 * being paranoid about XML parsers
2156 dbus_set_error (error, DBUS_ERROR_FAILED,
2157 "XML element <%s> ended but topmost element on the stack was <%s>",
2162 e = peek_element (parser);
2163 _dbus_assert (e != NULL);
2169 _dbus_assert_not_reached ("element in stack has no type");
2172 case ELEMENT_INCLUDE:
2174 case ELEMENT_CONFIGTYPE:
2175 case ELEMENT_LISTEN:
2176 case ELEMENT_PIDFILE:
2178 case ELEMENT_SERVICEDIR:
2179 case ELEMENT_SERVICEHELPER:
2180 case ELEMENT_INCLUDEDIR:
2182 if (!e->had_content)
2184 dbus_set_error (error, DBUS_ERROR_FAILED,
2185 "XML element <%s> was expected to have content inside it",
2186 bus_config_parser_element_type_to_name (e->type));
2190 if (e->type == ELEMENT_LIMIT)
2192 if (!set_limit (parser, e->d.limit.name, e->d.limit.value,
2198 case ELEMENT_BUSCONFIG:
2199 case ELEMENT_POLICY:
2203 case ELEMENT_SYSLOG:
2204 case ELEMENT_KEEP_UMASK:
2205 case ELEMENT_SELINUX:
2206 case ELEMENT_ASSOCIATE:
2207 case ELEMENT_STANDARD_SESSION_SERVICEDIRS:
2208 case ELEMENT_STANDARD_SYSTEM_SERVICEDIRS:
2209 case ELEMENT_ALLOW_ANONYMOUS:
2210 case ELEMENT_APPARMOR:
2214 pop_element (parser);
2220 all_whitespace (const DBusString *str)
2224 _dbus_string_skip_white (str, 0, &i);
2226 return i == _dbus_string_get_length (str);
2230 make_full_path (const DBusString *basedir,
2231 const DBusString *filename,
2232 DBusString *full_path)
2234 if (_dbus_path_is_absolute (filename))
2236 if (!_dbus_string_copy (filename, 0, full_path, 0))
2241 if (!_dbus_string_copy (basedir, 0, full_path, 0))
2244 if (!_dbus_concat_dir_and_file (full_path, filename))
2248 if (!_dbus_replace_install_prefix (full_path))
2255 include_file (BusConfigParser *parser,
2256 const DBusString *filename,
2257 dbus_bool_t ignore_missing,
2260 /* FIXME good test case for this would load each config file in the
2261 * test suite both alone, and as an include, and check
2262 * that the result is the same
2264 BusConfigParser *included;
2265 const char *filename_str;
2266 DBusError tmp_error;
2268 dbus_error_init (&tmp_error);
2270 filename_str = _dbus_string_get_const_data (filename);
2272 /* Check to make sure this file hasn't already been included. */
2273 if (seen_include (parser, filename))
2275 dbus_set_error (error, DBUS_ERROR_FAILED,
2276 "Circular inclusion of file '%s'",
2281 if (! _dbus_list_append (&parser->included_files, (void *) filename_str))
2283 BUS_SET_OOM (error);
2287 /* Since parser is passed in as the parent, included
2288 inherits parser's limits. */
2289 included = bus_config_load (filename, FALSE, parser, &tmp_error);
2291 _dbus_list_pop_last (&parser->included_files);
2293 if (included == NULL)
2295 _DBUS_ASSERT_ERROR_IS_SET (&tmp_error);
2297 if (dbus_error_has_name (&tmp_error, DBUS_ERROR_FILE_NOT_FOUND) &&
2300 dbus_error_free (&tmp_error);
2305 dbus_move_error (&tmp_error, error);
2311 _DBUS_ASSERT_ERROR_IS_CLEAR (&tmp_error);
2313 if (!merge_included (parser, included, error))
2315 bus_config_parser_unref (included);
2319 /* Copy included's limits back to parser. */
2320 parser->limits = included->limits;
2322 bus_config_parser_unref (included);
2328 servicehelper_path (BusConfigParser *parser,
2329 const DBusString *filename,
2332 const char *filename_str;
2333 char *servicehelper;
2335 filename_str = _dbus_string_get_const_data (filename);
2337 /* copy to avoid overwriting with NULL on OOM */
2338 servicehelper = _dbus_strdup (filename_str);
2341 if (servicehelper == NULL)
2343 BUS_SET_OOM (error);
2347 /* save the latest servicehelper only if not OOM */
2348 dbus_free (parser->servicehelper);
2349 parser->servicehelper = servicehelper;
2351 /* We don't check whether the helper exists; instead we
2352 * would just fail to ever activate anything if it doesn't.
2353 * This allows an admin to fix the problem if it doesn't exist.
2354 * It also allows the parser test suite to successfully parse
2355 * test cases without installing the helper. ;-)
2362 include_dir (BusConfigParser *parser,
2363 const DBusString *dirname,
2366 DBusString filename;
2368 DBusError tmp_error;
2372 if (!_dbus_string_init (&filename))
2374 BUS_SET_OOM (error);
2380 dir = _dbus_directory_open (dirname, error);
2384 if (dbus_error_has_name (error, DBUS_ERROR_FILE_NOT_FOUND))
2386 dbus_error_free (error);
2393 dbus_error_init (&tmp_error);
2394 while (_dbus_directory_get_next_file (dir, &filename, &tmp_error))
2396 DBusString full_path;
2398 if (!_dbus_string_init (&full_path))
2400 BUS_SET_OOM (error);
2404 if (!_dbus_string_copy (dirname, 0, &full_path, 0))
2406 BUS_SET_OOM (error);
2407 _dbus_string_free (&full_path);
2411 if (!_dbus_concat_dir_and_file (&full_path, &filename))
2413 BUS_SET_OOM (error);
2414 _dbus_string_free (&full_path);
2418 if (_dbus_string_ends_with_c_str (&full_path, ".conf"))
2420 if (!include_file (parser, &full_path, TRUE, error))
2422 if (dbus_error_is_set (error))
2424 /* We use both syslog and stderr here, because this is
2425 * the configuration parser, so we don't yet know whether
2426 * this bus is going to want to write to syslog! Err on
2427 * the side of making sure the message gets to the sysadmin
2429 _dbus_init_system_log ("dbus-daemon",
2430 DBUS_LOG_FLAGS_STDERR | DBUS_LOG_FLAGS_SYSTEM_LOG);
2431 _dbus_log (DBUS_SYSTEM_LOG_INFO,
2432 "Encountered error '%s' while parsing '%s'",
2434 _dbus_string_get_const_data (&full_path));
2435 dbus_error_free (error);
2440 _dbus_string_free (&full_path);
2443 if (dbus_error_is_set (&tmp_error))
2445 dbus_move_error (&tmp_error, error);
2450 if (!_dbus_string_copy_data (dirname, &s))
2452 BUS_SET_OOM (error);
2456 if (!_dbus_list_append (&parser->conf_dirs, s))
2459 BUS_SET_OOM (error);
2467 _dbus_string_free (&filename);
2470 _dbus_directory_close (dir);
2476 bus_config_parser_content (BusConfigParser *parser,
2477 const DBusString *content,
2482 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2488 _dbus_string_get_const_data (content, &c_str);
2490 printf ("CONTENT %d bytes: %s\n", _dbus_string_get_length (content), c_str);
2494 e = peek_element (parser);
2497 dbus_set_error (error, DBUS_ERROR_FAILED,
2498 "Text content outside of any XML element in configuration file");
2501 else if (e->had_content)
2503 _dbus_assert_not_reached ("Element had multiple content blocks");
2507 switch (top_element_type (parser))
2511 _dbus_assert_not_reached ("element at top of stack has no type");
2514 case ELEMENT_BUSCONFIG:
2515 case ELEMENT_POLICY:
2519 case ELEMENT_SYSLOG:
2520 case ELEMENT_KEEP_UMASK:
2521 case ELEMENT_STANDARD_SESSION_SERVICEDIRS:
2522 case ELEMENT_STANDARD_SYSTEM_SERVICEDIRS:
2523 case ELEMENT_ALLOW_ANONYMOUS:
2524 case ELEMENT_SELINUX:
2525 case ELEMENT_ASSOCIATE:
2526 case ELEMENT_APPARMOR:
2527 if (all_whitespace (content))
2531 dbus_set_error (error, DBUS_ERROR_FAILED,
2532 "No text content expected inside XML element %s in configuration file",
2533 bus_config_parser_element_type_to_name (top_element_type (parser)));
2537 case ELEMENT_PIDFILE:
2541 e->had_content = TRUE;
2543 if (!_dbus_string_copy_data (content, &s))
2546 dbus_free (parser->pidfile);
2547 parser->pidfile = s;
2551 case ELEMENT_INCLUDE:
2553 DBusString full_path, selinux_policy_root;
2555 e->had_content = TRUE;
2557 if (e->d.include.if_selinux_enabled
2558 && !bus_selinux_enabled ())
2561 if (!_dbus_string_init (&full_path))
2564 if (e->d.include.selinux_root_relative)
2566 if (!bus_selinux_get_policy_root ())
2568 dbus_set_error (error, DBUS_ERROR_FAILED,
2569 "Could not determine SELinux policy root for relative inclusion");
2570 _dbus_string_free (&full_path);
2573 _dbus_string_init_const (&selinux_policy_root,
2574 bus_selinux_get_policy_root ());
2575 if (!make_full_path (&selinux_policy_root, content, &full_path))
2577 _dbus_string_free (&full_path);
2581 else if (!make_full_path (&parser->basedir, content, &full_path))
2583 _dbus_string_free (&full_path);
2587 if (!include_file (parser, &full_path,
2588 e->d.include.ignore_missing, error))
2590 _dbus_string_free (&full_path);
2594 _dbus_string_free (&full_path);
2598 case ELEMENT_SERVICEHELPER:
2600 DBusString full_path;
2602 e->had_content = TRUE;
2604 if (!_dbus_string_init (&full_path))
2607 if (!make_full_path (&parser->basedir, content, &full_path))
2609 _dbus_string_free (&full_path);
2613 if (!servicehelper_path (parser, &full_path, error))
2615 _dbus_string_free (&full_path);
2619 _dbus_string_free (&full_path);
2623 case ELEMENT_INCLUDEDIR:
2625 DBusString full_path;
2627 e->had_content = TRUE;
2629 if (!_dbus_string_init (&full_path))
2632 if (!make_full_path (&parser->basedir, content, &full_path))
2634 _dbus_string_free (&full_path);
2638 if (!include_dir (parser, &full_path, error))
2640 _dbus_string_free (&full_path);
2644 _dbus_string_free (&full_path);
2652 e->had_content = TRUE;
2654 if (!_dbus_string_copy_data (content, &s))
2657 dbus_free (parser->user);
2662 case ELEMENT_CONFIGTYPE:
2666 e->had_content = TRUE;
2668 if (!_dbus_string_copy_data (content, &s))
2671 dbus_free (parser->bus_type);
2672 parser->bus_type = s;
2676 case ELEMENT_LISTEN:
2680 e->had_content = TRUE;
2682 if (!_dbus_string_copy_data (content, &s))
2685 if (!_dbus_list_append (&parser->listen_on,
2698 e->had_content = TRUE;
2700 if (!_dbus_string_copy_data (content, &s))
2703 if (!_dbus_list_append (&parser->mechanisms,
2712 case ELEMENT_SERVICEDIR:
2715 BusConfigServiceDir *dir;
2716 DBusString full_path;
2719 e->had_content = TRUE;
2721 if (!_dbus_string_init (&full_path))
2724 if (!make_full_path (&parser->basedir, content, &full_path))
2726 _dbus_string_free (&full_path);
2730 if (!_dbus_string_copy_data (&full_path, &s))
2732 _dbus_string_free (&full_path);
2736 /* <servicedir/> has traditionally implied that we watch the
2737 * directory with inotify, and allow service files whose names do not
2738 * match the bus name */
2739 dir = bus_config_service_dir_new_take (s, BUS_SERVICE_DIR_FLAGS_NONE);
2743 _dbus_string_free (&full_path);
2748 link = _dbus_list_alloc_link (dir);
2752 _dbus_string_free (&full_path);
2753 bus_config_service_dir_free (dir);
2758 service_dirs_append_link_unique_or_free (&parser->service_dirs, link);
2759 _dbus_string_free (&full_path);
2767 e->had_content = TRUE;
2770 if (!_dbus_string_parse_int (content, 0, &val, NULL))
2772 dbus_set_error (error, DBUS_ERROR_FAILED,
2773 "<limit name=\"%s\"> element has invalid value (could not parse as integer)",
2778 e->d.limit.value = val;
2780 _dbus_verbose ("Loaded value %ld for limit %s\n",
2787 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2791 BUS_SET_OOM (error);
2796 bus_config_parser_finished (BusConfigParser *parser,
2799 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2801 if (parser->stack != NULL)
2803 dbus_set_error (error, DBUS_ERROR_FAILED,
2804 "Element <%s> was not closed in configuration file",
2805 bus_config_parser_element_type_to_name (top_element_type (parser)));
2810 if (parser->is_toplevel && parser->listen_on == NULL)
2812 dbus_set_error (error, DBUS_ERROR_FAILED,
2813 "Configuration file needs one or more <listen> elements giving addresses");
2821 bus_config_parser_get_user (BusConfigParser *parser)
2823 return parser->user;
2827 bus_config_parser_get_type (BusConfigParser *parser)
2829 return parser->bus_type;
2833 bus_config_parser_get_addresses (BusConfigParser *parser)
2835 return &parser->listen_on;
2839 bus_config_parser_get_mechanisms (BusConfigParser *parser)
2841 return &parser->mechanisms;
2845 bus_config_parser_get_service_dirs (BusConfigParser *parser)
2847 return &parser->service_dirs;
2851 bus_config_parser_get_conf_dirs (BusConfigParser *parser)
2853 return &parser->conf_dirs;
2857 bus_config_parser_get_fork (BusConfigParser *parser)
2859 return parser->fork;
2863 bus_config_parser_get_syslog (BusConfigParser *parser)
2865 return parser->syslog;
2869 bus_config_parser_get_keep_umask (BusConfigParser *parser)
2871 return parser->keep_umask;
2875 bus_config_parser_get_allow_anonymous (BusConfigParser *parser)
2877 return parser->allow_anonymous;
2881 bus_config_parser_get_pidfile (BusConfigParser *parser)
2883 return parser->pidfile;
2887 bus_config_parser_get_servicehelper (BusConfigParser *parser)
2889 return parser->servicehelper;
2893 bus_config_parser_steal_policy (BusConfigParser *parser)
2897 _dbus_assert (parser->policy != NULL); /* can only steal the policy 1 time */
2899 policy = parser->policy;
2901 parser->policy = NULL;
2906 /* Overwrite any limits that were set in the configuration file */
2908 bus_config_parser_get_limits (BusConfigParser *parser,
2911 *limits = parser->limits;
2915 bus_config_parser_steal_service_context_table (BusConfigParser *parser)
2917 DBusHashTable *table;
2919 _dbus_assert (parser->service_context_table != NULL); /* can only steal once */
2921 table = parser->service_context_table;
2923 parser->service_context_table = NULL;
2929 * Return a list of the directories that should be watched with inotify,
2930 * as strings. The list might be empty and is in arbitrary order.
2932 * The list must be empty on entry. On success, the links are owned by the
2933 * caller and must be freed, but the data in each link remains owned by
2934 * the BusConfigParser and must not be freed: in GObject-Introspection
2935 * notation, it is (transfer container).
2938 bus_config_parser_get_watched_dirs (BusConfigParser *parser,
2939 DBusList **watched_dirs)
2943 _dbus_assert (*watched_dirs == NULL);
2945 for (link = _dbus_list_get_first_link (&parser->conf_dirs);
2947 link = _dbus_list_get_next_link (&parser->conf_dirs, link))
2949 if (!_dbus_list_append (watched_dirs, link->data))
2953 for (link = _dbus_list_get_first_link (&parser->service_dirs);
2955 link = _dbus_list_get_next_link (&parser->service_dirs, link))
2957 BusConfigServiceDir *dir = link->data;
2959 if (dir->flags & BUS_SERVICE_DIR_FLAGS_NO_WATCH)
2962 if (!_dbus_list_append (watched_dirs, dir->path))
2969 _dbus_list_clear (watched_dirs);
2973 #ifdef DBUS_ENABLE_EMBEDDED_TESTS
2984 do_check_own_rules (BusPolicy *policy)
2988 dbus_bool_t allowed;
2990 {"org.freedesktop", FALSE},
2991 {"org.freedesktop.ManySystem", FALSE},
2992 {"org.freedesktop.ManySystems", TRUE},
2993 {"org.freedesktop.ManySystems.foo", TRUE},
2994 {"org.freedesktop.ManySystems.foo.bar", TRUE},
2995 {"org.freedesktop.ManySystems2", FALSE},
2996 {"org.freedesktop.ManySystems2.foo", FALSE},
2997 {"org.freedesktop.ManySystems2.foo.bar", FALSE},
3002 while (checks[i].name)
3004 DBusString service_name;
3007 if (!_dbus_string_init (&service_name))
3008 _dbus_assert_not_reached ("couldn't init string");
3009 if (!_dbus_string_append (&service_name, checks[i].name))
3010 _dbus_assert_not_reached ("couldn't append string");
3012 ret = bus_policy_check_can_own (policy, &service_name);
3013 printf (" Check name %s: %s\n", checks[i].name,
3014 ret ? "allowed" : "not allowed");
3015 if (checks[i].allowed && !ret)
3017 _dbus_warn ("Cannot own %s", checks[i].name);
3020 if (!checks[i].allowed && ret)
3022 _dbus_warn ("Can own %s", checks[i].name);
3025 _dbus_string_free (&service_name);
3034 do_load (const DBusString *full_path,
3036 dbus_bool_t oom_possible,
3037 dbus_bool_t check_own_rules)
3039 BusConfigParser *parser;
3042 dbus_error_init (&error);
3044 parser = bus_config_load (full_path, TRUE, NULL, &error);
3047 _DBUS_ASSERT_ERROR_IS_SET (&error);
3050 dbus_error_has_name (&error, DBUS_ERROR_NO_MEMORY))
3052 _dbus_verbose ("Failed to load valid file due to OOM\n");
3053 dbus_error_free (&error);
3056 else if (validity == VALID)
3058 _dbus_warn ("Failed to load valid file but still had memory: %s",
3061 dbus_error_free (&error);
3066 dbus_error_free (&error);
3072 _DBUS_ASSERT_ERROR_IS_CLEAR (&error);
3074 if (check_own_rules && do_check_own_rules (parser->policy) == FALSE)
3079 bus_config_parser_unref (parser);
3081 if (validity == INVALID)
3083 _dbus_warn ("Accepted invalid file");
3093 const DBusString *full_path;
3095 dbus_bool_t check_own_rules;
3099 check_loader_oom_func (void *data)
3101 LoaderOomData *d = data;
3103 return do_load (d->full_path, d->validity, TRUE, d->check_own_rules);
3107 process_test_valid_subdir (const DBusString *test_base_dir,
3111 DBusString test_directory;
3112 DBusString filename;
3120 if (!_dbus_string_init (&test_directory))
3121 _dbus_assert_not_reached ("didn't allocate test_directory");
3123 _dbus_string_init_const (&filename, subdir);
3125 if (!_dbus_string_copy (test_base_dir, 0,
3126 &test_directory, 0))
3127 _dbus_assert_not_reached ("couldn't copy test_base_dir to test_directory");
3129 if (!_dbus_concat_dir_and_file (&test_directory, &filename))
3130 _dbus_assert_not_reached ("couldn't allocate full path");
3132 _dbus_string_free (&filename);
3133 if (!_dbus_string_init (&filename))
3134 _dbus_assert_not_reached ("didn't allocate filename string");
3136 dbus_error_init (&error);
3137 dir = _dbus_directory_open (&test_directory, &error);
3140 _dbus_warn ("Could not open %s: %s",
3141 _dbus_string_get_const_data (&test_directory),
3143 dbus_error_free (&error);
3147 if (validity == VALID)
3148 printf ("Testing valid files:\n");
3149 else if (validity == INVALID)
3150 printf ("Testing invalid files:\n");
3152 printf ("Testing unknown files:\n");
3155 while (_dbus_directory_get_next_file (dir, &filename, &error))
3157 DBusString full_path;
3160 if (!_dbus_string_init (&full_path))
3161 _dbus_assert_not_reached ("couldn't init string");
3163 if (!_dbus_string_copy (&test_directory, 0, &full_path, 0))
3164 _dbus_assert_not_reached ("couldn't copy dir to full_path");
3166 if (!_dbus_concat_dir_and_file (&full_path, &filename))
3167 _dbus_assert_not_reached ("couldn't concat file to dir");
3169 if (!_dbus_string_ends_with_c_str (&full_path, ".conf"))
3171 _dbus_verbose ("Skipping non-.conf file %s\n",
3172 _dbus_string_get_const_data (&filename));
3173 _dbus_string_free (&full_path);
3177 printf (" %s\n", _dbus_string_get_const_data (&filename));
3179 _dbus_verbose (" expecting %s\n",
3180 validity == VALID ? "valid" :
3181 (validity == INVALID ? "invalid" :
3182 (validity == UNKNOWN ? "unknown" : "???")));
3184 d.full_path = &full_path;
3185 d.validity = validity;
3186 d.check_own_rules = _dbus_string_ends_with_c_str (&full_path,
3187 "check-own-rules.conf");
3189 /* FIXME hackaround for an expat problem, see
3190 * https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=124747
3191 * http://freedesktop.org/pipermail/dbus/2004-May/001153.html
3193 /* if (!_dbus_test_oom_handling ("config-loader", check_loader_oom_func, &d)) */
3194 if (!check_loader_oom_func (&d))
3195 _dbus_assert_not_reached ("test failed");
3197 _dbus_string_free (&full_path);
3200 if (dbus_error_is_set (&error))
3202 _dbus_warn ("Could not get next file in %s: %s",
3203 _dbus_string_get_const_data (&test_directory),
3205 dbus_error_free (&error);
3214 _dbus_directory_close (dir);
3215 _dbus_string_free (&test_directory);
3216 _dbus_string_free (&filename);
3222 bools_equal (dbus_bool_t a,
3229 strings_equal_or_both_null (const char *a,
3232 if (a == NULL || b == NULL)
3235 return !strcmp (a, b);
3239 elements_equal (const Element *a,
3242 if (a->type != b->type)
3245 if (!bools_equal (a->had_content, b->had_content))
3251 case ELEMENT_INCLUDE:
3252 if (!bools_equal (a->d.include.ignore_missing,
3253 b->d.include.ignore_missing))
3257 case ELEMENT_POLICY:
3258 if (a->d.policy.type != b->d.policy.type)
3260 if (a->d.policy.gid_uid_or_at_console != b->d.policy.gid_uid_or_at_console)
3265 if (strcmp (a->d.limit.name, b->d.limit.name))
3267 if (a->d.limit.value != b->d.limit.value)
3272 case ELEMENT_BUSCONFIG:
3274 case ELEMENT_LISTEN:
3279 case ELEMENT_PIDFILE:
3280 case ELEMENT_SERVICEDIR:
3281 case ELEMENT_SERVICEHELPER:
3282 case ELEMENT_INCLUDEDIR:
3283 case ELEMENT_CONFIGTYPE:
3284 case ELEMENT_SELINUX:
3285 case ELEMENT_ASSOCIATE:
3286 case ELEMENT_STANDARD_SESSION_SERVICEDIRS:
3287 case ELEMENT_STANDARD_SYSTEM_SERVICEDIRS:
3288 case ELEMENT_KEEP_UMASK:
3289 case ELEMENT_SYSLOG:
3290 case ELEMENT_ALLOW_ANONYMOUS:
3291 case ELEMENT_APPARMOR:
3293 /* do nothing: nothing in the Element struct for these types */
3302 lists_of_elements_equal (DBusList *a,
3311 while (ia != NULL && ib != NULL)
3313 if (elements_equal (ia->data, ib->data))
3315 ia = _dbus_list_get_next_link (&a, ia);
3316 ib = _dbus_list_get_next_link (&b, ib);
3319 return ia == NULL && ib == NULL;
3323 lists_of_c_strings_equal (DBusList *a,
3332 while (ia != NULL && ib != NULL)
3334 if (strcmp (ia->data, ib->data))
3336 ia = _dbus_list_get_next_link (&a, ia);
3337 ib = _dbus_list_get_next_link (&b, ib);
3340 return ia == NULL && ib == NULL;
3344 lists_of_service_dirs_equal (DBusList *a,
3353 while (ia != NULL && ib != NULL)
3355 BusConfigServiceDir *da = ia->data;
3356 BusConfigServiceDir *db = ib->data;
3358 if (strcmp (da->path, db->path))
3361 if (da->flags != db->flags)
3364 ia = _dbus_list_get_next_link (&a, ia);
3365 ib = _dbus_list_get_next_link (&b, ib);
3368 return ia == NULL && ib == NULL;
3372 limits_equal (const BusLimits *a,
3376 (a->max_incoming_bytes == b->max_incoming_bytes
3377 || a->max_incoming_unix_fds == b->max_incoming_unix_fds
3378 || a->max_outgoing_bytes == b->max_outgoing_bytes
3379 || a->max_outgoing_unix_fds == b->max_outgoing_unix_fds
3380 || a->max_message_size == b->max_message_size
3381 || a->max_message_unix_fds == b->max_message_unix_fds
3382 || a->activation_timeout == b->activation_timeout
3383 || a->auth_timeout == b->auth_timeout
3384 || a->pending_fd_timeout == b->pending_fd_timeout
3385 || a->max_completed_connections == b->max_completed_connections
3386 || a->max_incomplete_connections == b->max_incomplete_connections
3387 || a->max_connections_per_user == b->max_connections_per_user
3388 || a->max_pending_activations == b->max_pending_activations
3389 || a->max_services_per_connection == b->max_services_per_connection
3390 || a->max_match_rules_per_connection == b->max_match_rules_per_connection
3391 || a->max_replies_per_connection == b->max_replies_per_connection
3392 || a->reply_timeout == b->reply_timeout);
3396 config_parsers_equal (const BusConfigParser *a,
3397 const BusConfigParser *b)
3399 if (!_dbus_string_equal (&a->basedir, &b->basedir))
3402 if (!lists_of_elements_equal (a->stack, b->stack))
3405 if (!strings_equal_or_both_null (a->user, b->user))
3408 if (!lists_of_c_strings_equal (a->listen_on, b->listen_on))
3411 if (!lists_of_c_strings_equal (a->mechanisms, b->mechanisms))
3414 if (!lists_of_service_dirs_equal (a->service_dirs, b->service_dirs))
3417 /* FIXME: compare policy */
3419 /* FIXME: compare service selinux ID table */
3421 if (! limits_equal (&a->limits, &b->limits))
3424 if (!strings_equal_or_both_null (a->pidfile, b->pidfile))
3427 if (! bools_equal (a->fork, b->fork))
3430 if (! bools_equal (a->keep_umask, b->keep_umask))
3433 if (! bools_equal (a->is_toplevel, b->is_toplevel))
3440 all_are_equiv (const DBusString *target_directory)
3442 DBusString filename;
3444 BusConfigParser *first_parser;
3445 BusConfigParser *parser;
3451 first_parser = NULL;
3455 if (!_dbus_string_init (&filename))
3456 _dbus_assert_not_reached ("didn't allocate filename string");
3458 dbus_error_init (&error);
3459 dir = _dbus_directory_open (target_directory, &error);
3462 _dbus_warn ("Could not open %s: %s",
3463 _dbus_string_get_const_data (target_directory),
3465 dbus_error_free (&error);
3469 printf ("Comparing equivalent files:\n");
3472 while (_dbus_directory_get_next_file (dir, &filename, &error))
3474 DBusString full_path;
3476 if (!_dbus_string_init (&full_path))
3477 _dbus_assert_not_reached ("couldn't init string");
3479 if (!_dbus_string_copy (target_directory, 0, &full_path, 0))
3480 _dbus_assert_not_reached ("couldn't copy dir to full_path");
3482 if (!_dbus_concat_dir_and_file (&full_path, &filename))
3483 _dbus_assert_not_reached ("couldn't concat file to dir");
3485 if (!_dbus_string_ends_with_c_str (&full_path, ".conf"))
3487 _dbus_verbose ("Skipping non-.conf file %s\n",
3488 _dbus_string_get_const_data (&filename));
3489 _dbus_string_free (&full_path);
3493 printf (" %s\n", _dbus_string_get_const_data (&filename));
3495 parser = bus_config_load (&full_path, TRUE, NULL, &error);
3499 _dbus_warn ("Could not load file %s: %s",
3500 _dbus_string_get_const_data (&full_path),
3502 _dbus_string_free (&full_path);
3503 dbus_error_free (&error);
3506 else if (first_parser == NULL)
3508 _dbus_string_free (&full_path);
3509 first_parser = parser;
3513 _dbus_string_free (&full_path);
3514 equal = config_parsers_equal (first_parser, parser);
3515 bus_config_parser_unref (parser);
3524 _dbus_string_free (&filename);
3526 bus_config_parser_unref (first_parser);
3528 _dbus_directory_close (dir);
3535 process_test_equiv_subdir (const DBusString *test_base_dir,
3538 DBusString test_directory;
3539 DBusString filename;
3548 if (!_dbus_string_init (&test_directory))
3549 _dbus_assert_not_reached ("didn't allocate test_directory");
3551 _dbus_string_init_const (&filename, subdir);
3553 if (!_dbus_string_copy (test_base_dir, 0,
3554 &test_directory, 0))
3555 _dbus_assert_not_reached ("couldn't copy test_base_dir to test_directory");
3557 if (!_dbus_concat_dir_and_file (&test_directory, &filename))
3558 _dbus_assert_not_reached ("couldn't allocate full path");
3560 _dbus_string_free (&filename);
3561 if (!_dbus_string_init (&filename))
3562 _dbus_assert_not_reached ("didn't allocate filename string");
3564 dbus_error_init (&error);
3565 dir = _dbus_directory_open (&test_directory, &error);
3568 _dbus_warn ("Could not open %s: %s",
3569 _dbus_string_get_const_data (&test_directory),
3571 dbus_error_free (&error);
3575 while (_dbus_directory_get_next_file (dir, &filename, &error))
3577 DBusString full_path;
3579 /* Skip CVS's magic directories! */
3580 if (_dbus_string_equal_c_str (&filename, "CVS"))
3583 if (!_dbus_string_init (&full_path))
3584 _dbus_assert_not_reached ("couldn't init string");
3586 if (!_dbus_string_copy (&test_directory, 0, &full_path, 0))
3587 _dbus_assert_not_reached ("couldn't copy dir to full_path");
3589 if (!_dbus_concat_dir_and_file (&full_path, &filename))
3590 _dbus_assert_not_reached ("couldn't concat file to dir");
3592 equal = all_are_equiv (&full_path);
3593 _dbus_string_free (&full_path);
3602 _dbus_string_free (&test_directory);
3603 _dbus_string_free (&filename);
3605 _dbus_directory_close (dir);
3611 static const char *test_session_service_dir_matches[] =
3613 /* will be filled in test_default_session_servicedirs() */
3615 NULL, /* install root-based */
3616 NULL, /* CommonProgramFiles-based */
3618 NULL, /* XDG_RUNTIME_DIR-based */
3619 NULL, /* XDG_DATA_HOME-based */
3620 NULL, /* XDG_DATA_DIRS-based */
3621 NULL, /* XDG_DATA_DIRS-based */
3622 DBUS_DATADIR "/dbus-1/services",
3628 test_default_session_servicedirs (const DBusString *test_base_dir)
3630 BusConfigParser *parser = NULL;
3631 DBusError error = DBUS_ERROR_INIT;
3633 DBusList *watched_dirs = NULL;
3636 DBusString full_path;
3638 DBusString install_root_based;
3639 DBusString runtime_dir_based;
3640 DBusString data_home_based;
3641 DBusString data_dirs_based;
3642 DBusString data_dirs_based2;
3644 dbus_bool_t ret = FALSE;
3646 const char *common_progs;
3648 const char *dbus_test_builddir;
3649 const char *xdg_data_home;
3650 const char *xdg_runtime_dir;
3653 /* On each platform we don't actually use all of these, but it's easier to
3654 * handle the deallocation if we always allocate them, whether needed or
3656 if (!_dbus_string_init (&full_path) ||
3657 !_dbus_string_init (&progs) ||
3658 !_dbus_string_init (&install_root_based) ||
3659 !_dbus_string_init (&runtime_dir_based) ||
3660 !_dbus_string_init (&data_home_based) ||
3661 !_dbus_string_init (&data_dirs_based) ||
3662 !_dbus_string_init (&data_dirs_based2))
3663 _dbus_assert_not_reached ("OOM allocating strings");
3665 if (!_dbus_string_copy (test_base_dir, 0,
3667 _dbus_assert_not_reached ("couldn't copy test_base_dir to full_path");
3669 _dbus_string_init_const (&tmp, "valid-config-files");
3671 if (!_dbus_concat_dir_and_file (&full_path, &tmp))
3672 _dbus_assert_not_reached ("couldn't allocate full path");
3674 _dbus_string_init_const (&tmp, "standard-session-dirs.conf");
3676 if (!_dbus_concat_dir_and_file (&full_path, &tmp))
3677 _dbus_assert_not_reached ("couldn't allocate full path");
3680 if (!_dbus_string_append (&install_root_based, DBUS_DATADIR) ||
3681 !_dbus_string_append (&install_root_based, "/dbus-1/services") ||
3682 !_dbus_replace_install_prefix (&install_root_based))
3685 _dbus_assert (_dbus_path_is_absolute (&install_root_based));
3687 test_session_service_dir_matches[0] = _dbus_string_get_const_data (
3688 &install_root_based);
3690 common_progs = _dbus_getenv ("CommonProgramFiles");
3694 if (!_dbus_string_append (&progs, common_progs))
3697 if (!_dbus_string_append (&progs, "/dbus-1/services"))
3700 test_session_service_dir_matches[1] = _dbus_string_get_const_data(&progs);
3703 dbus_test_builddir = _dbus_getenv ("DBUS_TEST_BUILDDIR");
3704 xdg_data_home = _dbus_getenv ("XDG_DATA_HOME");
3705 xdg_runtime_dir = _dbus_getenv ("XDG_RUNTIME_DIR");
3707 if (dbus_test_builddir == NULL || xdg_data_home == NULL ||
3708 xdg_runtime_dir == NULL)
3710 printf ("Not testing default session service directories because a "
3711 "build-time testing environment variable is not set: "
3712 "see AM_TESTS_ENVIRONMENT in tests/Makefile.am\n");
3717 if (!_dbus_string_append (&data_dirs_based, dbus_test_builddir) ||
3718 !_dbus_string_append (&data_dirs_based, "/XDG_DATA_DIRS/dbus-1/services") ||
3719 !_dbus_string_append (&data_dirs_based2, dbus_test_builddir) ||
3720 !_dbus_string_append (&data_dirs_based2, "/XDG_DATA_DIRS2/dbus-1/services") ||
3721 !_dbus_string_append (&runtime_dir_based, xdg_runtime_dir) ||
3722 !_dbus_string_append (&data_home_based, xdg_data_home) ||
3723 !_dbus_string_append (&data_home_based, "/dbus-1/services"))
3724 _dbus_assert_not_reached ("out of memory");
3726 if (!_dbus_ensure_directory (&runtime_dir_based, NULL))
3727 _dbus_assert_not_reached ("Unable to create fake XDG_RUNTIME_DIR");
3729 if (!_dbus_string_append (&runtime_dir_based, "/dbus-1/services"))
3730 _dbus_assert_not_reached ("out of memory");
3732 /* Sanity check: the Makefile sets this up. We assume that if this is
3733 * right, the XDG_DATA_DIRS will be too. */
3734 if (!_dbus_string_starts_with_c_str (&data_home_based, dbus_test_builddir))
3735 _dbus_assert_not_reached ("$XDG_DATA_HOME should start with $DBUS_TEST_BUILDDIR");
3737 if (!_dbus_string_starts_with_c_str (&runtime_dir_based, dbus_test_builddir))
3738 _dbus_assert_not_reached ("$XDG_RUNTIME_DIR should start with $DBUS_TEST_BUILDDIR");
3740 test_session_service_dir_matches[0] = _dbus_string_get_const_data (
3741 &runtime_dir_based);
3742 test_session_service_dir_matches[1] = _dbus_string_get_const_data (
3744 test_session_service_dir_matches[2] = _dbus_string_get_const_data (
3746 test_session_service_dir_matches[3] = _dbus_string_get_const_data (
3750 parser = bus_config_load (&full_path, TRUE, NULL, &error);
3753 _dbus_assert_not_reached (error.message);
3755 dirs = bus_config_parser_get_service_dirs (parser);
3757 for (link = _dbus_list_get_first_link (dirs), i = 0;
3759 link = _dbus_list_get_next_link (dirs, link), i++)
3761 BusConfigServiceDir *dir = link->data;
3762 BusServiceDirFlags expected = BUS_SERVICE_DIR_FLAGS_NONE;
3764 printf (" test service dir: '%s'\n", dir->path);
3765 printf (" current standard service dir: '%s'\n", test_session_service_dir_matches[i]);
3766 if (test_session_service_dir_matches[i] == NULL)
3768 printf ("more directories parsed than in match set\n");
3772 if (strcmp (test_session_service_dir_matches[i], dir->path) != 0)
3774 printf ("'%s' directory does not match '%s' in the match set\n",
3775 dir->path, test_session_service_dir_matches[i]);
3780 /* On Unix we expect the first directory in the search path to be
3781 * in the XDG_RUNTIME_DIR, and we expect it to have special flags */
3783 expected = (BUS_SERVICE_DIR_FLAGS_NO_WATCH |
3784 BUS_SERVICE_DIR_FLAGS_STRICT_NAMING);
3787 if (dir->flags != expected)
3789 printf ("'%s' directory has flags 0x%x, should be 0x%x\n",
3790 dir->path, dir->flags, expected);
3795 if (test_session_service_dir_matches[i] != NULL)
3797 printf ("extra data %s in the match set was not matched\n",
3798 test_session_service_dir_matches[i]);
3802 if (!bus_config_parser_get_watched_dirs (parser, &watched_dirs))
3803 _dbus_assert_not_reached ("out of memory");
3806 /* We expect all directories to be watched (not that it matters on Windows,
3807 * because we don't know how) */
3810 /* We expect all directories except the first to be watched, because
3811 * the first one is transient */
3815 for (link = _dbus_list_get_first_link (&watched_dirs);
3817 link = _dbus_list_get_next_link (&watched_dirs, link), i++)
3819 printf (" watched service dir: '%s'\n", (const char *) link->data);
3820 printf (" current standard service dir: '%s'\n",
3821 test_session_service_dir_matches[i]);
3823 if (test_session_service_dir_matches[i] == NULL)
3825 printf ("more directories parsed than in match set\n");
3829 if (strcmp (test_session_service_dir_matches[i],
3830 (const char *) link->data) != 0)
3832 printf ("'%s' directory does not match '%s' in the match set\n",
3833 (const char *) link->data,
3834 test_session_service_dir_matches[i]);
3839 if (test_session_service_dir_matches[i] != NULL)
3841 printf ("extra data %s in the match set was not matched\n",
3842 test_session_service_dir_matches[i]);
3850 bus_config_parser_unref (parser);
3852 _dbus_list_clear (&watched_dirs);
3853 _dbus_string_free (&full_path);
3854 _dbus_string_free (&install_root_based);
3855 _dbus_string_free (&progs);
3856 _dbus_string_free (&runtime_dir_based);
3857 _dbus_string_free (&data_home_based);
3858 _dbus_string_free (&data_dirs_based);
3859 _dbus_string_free (&data_dirs_based2);
3864 static const char *test_system_service_dir_matches[] =
3866 "/usr/local/share/dbus-1/system-services",
3867 "/usr/share/dbus-1/system-services",
3868 DBUS_DATADIR"/dbus-1/system-services",
3869 "/lib/dbus-1/system-services",
3874 test_default_system_servicedirs (void)
3882 if (!_dbus_get_standard_system_servicedirs (&dirs))
3883 _dbus_assert_not_reached ("couldn't get stardard dirs");
3885 /* make sure we read and parse the env variable correctly */
3887 while ((link = _dbus_list_pop_first_link (&dirs)))
3889 printf (" test service dir: %s\n", (char *)link->data);
3890 if (test_system_service_dir_matches[i] == NULL)
3892 printf ("more directories parsed than in match set\n");
3893 dbus_free (link->data);
3894 _dbus_list_free_link (link);
3898 if (strcmp (test_system_service_dir_matches[i],
3899 (char *)link->data) != 0)
3901 printf ("%s directory does not match %s in the match set\n",
3903 test_system_service_dir_matches[i]);
3904 dbus_free (link->data);
3905 _dbus_list_free_link (link);
3911 dbus_free (link->data);
3912 _dbus_list_free_link (link);
3915 if (test_system_service_dir_matches[i] != NULL)
3917 printf ("extra data %s in the match set was not matched\n",
3918 test_system_service_dir_matches[i]);
3928 bus_config_parser_test (const DBusString *test_data_dir)
3930 if (test_data_dir == NULL ||
3931 _dbus_string_get_length (test_data_dir) == 0)
3933 printf ("No test data\n");
3937 if (!test_default_session_servicedirs (test_data_dir))
3941 printf("default system service dir skipped\n");
3943 if (!test_default_system_servicedirs())
3947 if (!process_test_valid_subdir (test_data_dir, "valid-config-files", VALID))
3951 if (!process_test_valid_subdir (test_data_dir, "valid-config-files-system", VALID))
3955 if (!process_test_valid_subdir (test_data_dir, "invalid-config-files", INVALID))
3958 if (!process_test_equiv_subdir (test_data_dir, "equiv-config-files"))
3964 #endif /* DBUS_ENABLE_EMBEDDED_TESTS */