1 /* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
2 /* config-parser.c XML-library-agnostic configuration file parser
4 * Copyright (C) 2003, 2004 Red Hat, Inc.
6 * Licensed under the Academic Free License version 2.1
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version.
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
25 #include "config-parser-common.h"
26 #include "config-parser.h"
32 #include <dbus/dbus-list.h>
33 #include <dbus/dbus-internals.h>
34 #include <dbus/dbus-misc.h>
35 #include <dbus/dbus-sysdeps.h>
40 /* we ignore policies for unknown groups/users */
55 unsigned int had_content : 1;
61 unsigned int ignore_missing : 1;
62 unsigned int if_selinux_enabled : 1;
63 unsigned int selinux_root_relative : 1;
69 unsigned long gid_uid_or_at_console;
83 * Parser for bus configuration file.
85 struct BusConfigParser
87 int refcount; /**< Reference count */
89 DBusString basedir; /**< Directory we resolve paths relative to */
91 DBusList *stack; /**< stack of Element */
93 char *user; /**< user to run as */
95 char *servicehelper; /**< location of the setuid helper */
97 char *bus_type; /**< Message bus type */
99 DBusList *listen_on; /**< List of addresses to listen to */
101 DBusList *mechanisms; /**< Auth mechanisms */
103 DBusList *service_dirs; /**< BusConfigServiceDirs to look for session services in */
105 DBusList *conf_dirs; /**< Directories to look for policy configuration in */
107 BusPolicy *policy; /**< Security policy */
109 BusLimits limits; /**< Limits */
111 char *pidfile; /**< PID file */
113 DBusList *included_files; /**< Included files stack */
115 DBusHashTable *service_context_table; /**< Map service names to SELinux contexts */
117 unsigned int fork : 1; /**< TRUE to fork into daemon mode */
119 unsigned int syslog : 1; /**< TRUE to enable syslog */
120 unsigned int keep_umask : 1; /**< TRUE to keep original umask when forking */
122 unsigned int is_toplevel : 1; /**< FALSE if we are a sub-config-file inside another one */
124 unsigned int allow_anonymous : 1; /**< TRUE to allow anonymous connections */
128 push_element (BusConfigParser *parser,
133 _dbus_assert (type != ELEMENT_NONE);
135 e = dbus_new0 (Element, 1);
139 if (!_dbus_list_append (&parser->stack, e))
151 element_free (Element *e)
153 if (e->type == ELEMENT_LIMIT)
154 dbus_free (e->d.limit.name);
160 pop_element (BusConfigParser *parser)
164 e = _dbus_list_pop_last (&parser->stack);
170 peek_element (BusConfigParser *parser)
174 e = _dbus_list_get_last (&parser->stack);
180 top_element_type (BusConfigParser *parser)
184 e = _dbus_list_get_last (&parser->stack);
193 merge_service_context_hash (DBusHashTable *dest,
203 _dbus_hash_iter_init (from, &iter);
204 while (_dbus_hash_iter_next (&iter))
206 const char *service = _dbus_hash_iter_get_string_key (&iter);
207 const char *context = _dbus_hash_iter_get_value (&iter);
209 service_copy = _dbus_strdup (service);
210 if (service_copy == NULL)
212 context_copy = _dbus_strdup (context);
213 if (context_copy == NULL)
216 if (!_dbus_hash_table_insert_string (dest, service_copy, context_copy))
227 dbus_free (service_copy);
230 dbus_free (context_copy);
236 * Create a new BusConfigServiceDir. Takes ownership of path if #TRUE is returned.
238 * @returns #FALSE on OOM
240 static BusConfigServiceDir *
241 bus_config_service_dir_new_take (char *path,
242 BusServiceDirFlags flags)
244 BusConfigServiceDir *self = dbus_new0 (BusConfigServiceDir, 1);
249 self->path = path; /* take ownership */
255 bus_config_service_dir_free (BusConfigServiceDir *self)
257 dbus_free (self->path);
261 static BusConfigServiceDir *
262 service_dirs_find_dir (DBusList **service_dirs,
267 _dbus_assert (dir != NULL);
269 for (link = *service_dirs; link; link = _dbus_list_get_next_link(service_dirs, link))
271 BusConfigServiceDir *link_dir = link->data;
273 if (strcmp (dir, link_dir->path) == 0)
281 service_dirs_append_link_unique_or_free (DBusList **service_dirs,
284 BusConfigServiceDir *dir = dir_link->data;
285 BusConfigServiceDir *already = service_dirs_find_dir (service_dirs,
290 _dbus_list_append_link (service_dirs, dir_link);
294 /* BusServiceDirFlags are chosen such that the compatible thing to do
295 * is to "and" the flags. For example, if a directory is explicitly
296 * added as a <servicedir> (which is watched with inotify) and is also
297 * the transient service directory (which should not be watched),
298 * the compatible thing to do is to watch it. */
299 already->flags &= dir->flags;
300 bus_config_service_dir_free (dir_link->data);
301 _dbus_list_free_link (dir_link);
306 * Consume links from dirs (a list of paths), converting them into links in
307 * service_dirs (a list of unique BusServiceDir).
309 * On success, return TRUE. dirs will be empty, and every original entry in
310 * dirs will have a corresponding service_dirs entry.
312 * On OOM, return FALSE. Each original entry of dirs has either been
313 * appended to service_dirs or left in dirs.
316 service_dirs_absorb_string_list (DBusList **service_dirs,
318 BusServiceDirFlags flags)
322 _dbus_assert (service_dirs != NULL);
323 _dbus_assert (dirs != NULL);
325 while ((link = _dbus_list_pop_first_link (dirs)))
327 char *path = link->data;
328 BusConfigServiceDir *dir = bus_config_service_dir_new_take (path, flags);
332 /* OOM - roll back (this does not need to allocate memory) */
333 _dbus_list_prepend_link (service_dirs, link);
337 /* Ownership of path has been taken by dir */
339 service_dirs_append_link_unique_or_free (service_dirs, link);
342 _dbus_assert (*dirs == NULL);
347 merge_included (BusConfigParser *parser,
348 BusConfigParser *included,
353 if (!bus_policy_merge (parser->policy,
360 if (!merge_service_context_hash (parser->service_context_table,
361 included->service_context_table))
367 if (included->user != NULL)
369 dbus_free (parser->user);
370 parser->user = included->user;
371 included->user = NULL;
374 if (included->bus_type != NULL)
376 dbus_free (parser->bus_type);
377 parser->bus_type = included->bus_type;
378 included->bus_type = NULL;
384 if (included->keep_umask)
385 parser->keep_umask = TRUE;
387 if (included->allow_anonymous)
388 parser->allow_anonymous = TRUE;
390 if (included->pidfile != NULL)
392 dbus_free (parser->pidfile);
393 parser->pidfile = included->pidfile;
394 included->pidfile = NULL;
397 if (included->servicehelper != NULL)
399 dbus_free (parser->servicehelper);
400 parser->servicehelper = included->servicehelper;
401 included->servicehelper = NULL;
404 while ((link = _dbus_list_pop_first_link (&included->listen_on)))
405 _dbus_list_append_link (&parser->listen_on, link);
407 while ((link = _dbus_list_pop_first_link (&included->mechanisms)))
408 _dbus_list_append_link (&parser->mechanisms, link);
410 while ((link = _dbus_list_pop_first_link (&included->service_dirs)))
411 service_dirs_append_link_unique_or_free (&parser->service_dirs, link);
413 while ((link = _dbus_list_pop_first_link (&included->conf_dirs)))
414 _dbus_list_append_link (&parser->conf_dirs, link);
420 seen_include (BusConfigParser *parser,
421 const DBusString *file)
425 iter = parser->included_files;
428 if (! strcmp (_dbus_string_get_const_data (file), iter->data))
431 iter = _dbus_list_get_next_link (&parser->included_files, iter);
438 bus_config_parser_new (const DBusString *basedir,
439 dbus_bool_t is_toplevel,
440 const BusConfigParser *parent)
442 BusConfigParser *parser;
444 parser = dbus_new0 (BusConfigParser, 1);
448 parser->is_toplevel = !!is_toplevel;
450 if (!_dbus_string_init (&parser->basedir))
456 if (((parser->policy = bus_policy_new ()) == NULL) ||
457 !_dbus_string_copy (basedir, 0, &parser->basedir, 0) ||
458 ((parser->service_context_table = _dbus_hash_table_new (DBUS_HASH_STRING,
460 dbus_free)) == NULL))
463 bus_policy_unref (parser->policy);
465 _dbus_string_free (&parser->basedir);
473 /* Initialize the parser's limits from the parent. */
474 parser->limits = parent->limits;
476 /* Use the parent's list of included_files to avoid
477 circular inclusions. */
478 parser->included_files = parent->included_files;
483 /* Make up some numbers! woot! */
484 parser->limits.max_incoming_bytes = _DBUS_ONE_MEGABYTE * 127;
485 parser->limits.max_outgoing_bytes = _DBUS_ONE_MEGABYTE * 127;
486 parser->limits.max_message_size = _DBUS_ONE_MEGABYTE * 32;
488 /* We set relatively conservative values here since due to the
489 way SCM_RIGHTS works we need to preallocate an array for the
490 maximum number of file descriptors we can receive. Picking a
491 high value here thus translates directly to more memory
493 parser->limits.max_incoming_unix_fds = DBUS_DEFAULT_MESSAGE_UNIX_FDS*4;
494 parser->limits.max_outgoing_unix_fds = DBUS_DEFAULT_MESSAGE_UNIX_FDS*4;
495 parser->limits.max_message_unix_fds = DBUS_DEFAULT_MESSAGE_UNIX_FDS;
497 /* Making this long means the user has to wait longer for an error
498 * message if something screws up, but making it too short means
499 * they might see a false failure.
501 parser->limits.activation_timeout = 25000; /* 25 seconds */
503 /* Making this long risks making a DOS attack easier, but too short
504 * and legitimate auth will fail. If interactive auth (ask user for
505 * password) is allowed, then potentially it has to be quite long.
507 parser->limits.auth_timeout = 30000; /* 30 seconds */
509 /* Do not allow a fd to stay forever in dbus-daemon
510 * https://bugs.freedesktop.org/show_bug.cgi?id=80559
512 parser->limits.pending_fd_timeout = 150000; /* 2.5 minutes */
514 parser->limits.max_incomplete_connections = 64;
515 parser->limits.max_connections_per_user = 256;
517 /* Note that max_completed_connections / max_connections_per_user
518 * is the number of users that would have to work together to
519 * DOS all the other users.
521 parser->limits.max_completed_connections = 2048;
523 parser->limits.max_pending_activations = 512;
524 parser->limits.max_services_per_connection = 512;
526 /* For this one, keep in mind that it isn't only the memory used
527 * by the match rules, but slowdown from linearly walking a big
528 * list of them. A client adding more than this is almost
529 * certainly a bad idea for that reason, and should change to a
530 * smaller number of wider-net match rules - getting every last
531 * message to the bus is probably better than having a thousand
534 parser->limits.max_match_rules_per_connection = 512;
536 parser->limits.reply_timeout = -1; /* never */
538 /* this is effectively a limit on message queue size for messages
539 * that require a reply
541 parser->limits.max_replies_per_connection = 128;
544 parser->refcount = 1;
550 bus_config_parser_ref (BusConfigParser *parser)
552 _dbus_assert (parser->refcount > 0);
554 parser->refcount += 1;
560 bus_config_parser_unref (BusConfigParser *parser)
562 _dbus_assert (parser->refcount > 0);
564 parser->refcount -= 1;
566 if (parser->refcount == 0)
568 while (parser->stack != NULL)
569 pop_element (parser);
571 dbus_free (parser->user);
572 dbus_free (parser->servicehelper);
573 dbus_free (parser->bus_type);
574 dbus_free (parser->pidfile);
576 _dbus_list_foreach (&parser->listen_on,
577 (DBusForeachFunction) dbus_free,
580 _dbus_list_clear (&parser->listen_on);
582 _dbus_list_foreach (&parser->service_dirs,
583 (DBusForeachFunction) bus_config_service_dir_free,
586 _dbus_list_clear (&parser->service_dirs);
588 _dbus_list_foreach (&parser->conf_dirs,
589 (DBusForeachFunction) dbus_free,
592 _dbus_list_clear (&parser->conf_dirs);
594 _dbus_list_foreach (&parser->mechanisms,
595 (DBusForeachFunction) dbus_free,
598 _dbus_list_clear (&parser->mechanisms);
600 _dbus_string_free (&parser->basedir);
603 bus_policy_unref (parser->policy);
605 if (parser->service_context_table)
606 _dbus_hash_table_unref (parser->service_context_table);
613 bus_config_parser_check_doctype (BusConfigParser *parser,
617 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
619 if (strcmp (doctype, "busconfig") != 0)
621 dbus_set_error (error,
623 "Configuration file has the wrong document type %s",
638 locate_attributes (BusConfigParser *parser,
639 const char *element_name,
640 const char **attribute_names,
641 const char **attribute_values,
643 const char *first_attribute_name,
644 const char **first_attribute_retloc,
652 LocateAttr attrs[MAX_ATTRS];
656 _dbus_assert (first_attribute_name != NULL);
657 _dbus_assert (first_attribute_retloc != NULL);
662 attrs[0].name = first_attribute_name;
663 attrs[0].retloc = first_attribute_retloc;
664 *first_attribute_retloc = NULL;
666 va_start (args, first_attribute_retloc);
668 name = va_arg (args, const char*);
669 retloc = va_arg (args, const char**);
673 _dbus_assert (retloc != NULL);
674 _dbus_assert (n_attrs < MAX_ATTRS);
676 attrs[n_attrs].name = name;
677 attrs[n_attrs].retloc = retloc;
681 name = va_arg (args, const char*);
682 retloc = va_arg (args, const char**);
688 while (attribute_names[i])
697 if (strcmp (attrs[j].name, attribute_names[i]) == 0)
699 retloc = attrs[j].retloc;
703 dbus_set_error (error, DBUS_ERROR_FAILED,
704 "Attribute \"%s\" repeated twice on the same <%s> element",
705 attrs[j].name, element_name);
710 *retloc = attribute_values[i];
719 dbus_set_error (error, DBUS_ERROR_FAILED,
720 "Attribute \"%s\" is invalid on <%s> element in this context",
721 attribute_names[i], element_name);
734 check_no_attributes (BusConfigParser *parser,
735 const char *element_name,
736 const char **attribute_names,
737 const char **attribute_values,
740 if (attribute_names[0] != NULL)
742 dbus_set_error (error, DBUS_ERROR_FAILED,
743 "Attribute \"%s\" is invalid on <%s> element in this context",
744 attribute_names[0], element_name);
752 start_busconfig_child (BusConfigParser *parser,
753 const char *element_name,
754 const char **attribute_names,
755 const char **attribute_values,
758 ElementType element_type;
760 element_type = bus_config_parser_element_name_to_type (element_name);
762 if (element_type == ELEMENT_USER)
764 if (!check_no_attributes (parser, "user", attribute_names, attribute_values, error))
767 if (push_element (parser, ELEMENT_USER) == NULL)
775 else if (element_type == ELEMENT_CONFIGTYPE)
777 if (!check_no_attributes (parser, "type", attribute_names, attribute_values, error))
780 if (push_element (parser, ELEMENT_CONFIGTYPE) == NULL)
788 else if (element_type == ELEMENT_FORK)
790 if (!check_no_attributes (parser, "fork", attribute_names, attribute_values, error))
793 if (push_element (parser, ELEMENT_FORK) == NULL)
803 else if (element_type == ELEMENT_SYSLOG)
805 if (!check_no_attributes (parser, "syslog", attribute_names, attribute_values, error))
808 if (push_element (parser, ELEMENT_SYSLOG) == NULL)
814 parser->syslog = TRUE;
818 else if (element_type == ELEMENT_KEEP_UMASK)
820 if (!check_no_attributes (parser, "keep_umask", attribute_names, attribute_values, error))
823 if (push_element (parser, ELEMENT_KEEP_UMASK) == NULL)
829 parser->keep_umask = TRUE;
833 else if (element_type == ELEMENT_PIDFILE)
835 if (!check_no_attributes (parser, "pidfile", attribute_names, attribute_values, error))
838 if (push_element (parser, ELEMENT_PIDFILE) == NULL)
846 else if (element_type == ELEMENT_LISTEN)
848 if (!check_no_attributes (parser, "listen", attribute_names, attribute_values, error))
851 if (push_element (parser, ELEMENT_LISTEN) == NULL)
859 else if (element_type == ELEMENT_AUTH)
861 if (!check_no_attributes (parser, "auth", attribute_names, attribute_values, error))
864 if (push_element (parser, ELEMENT_AUTH) == NULL)
872 else if (element_type == ELEMENT_SERVICEHELPER)
874 if (!check_no_attributes (parser, "servicehelper", attribute_names, attribute_values, error))
877 if (push_element (parser, ELEMENT_SERVICEHELPER) == NULL)
885 else if (element_type == ELEMENT_INCLUDEDIR)
887 if (!check_no_attributes (parser, "includedir", attribute_names, attribute_values, error))
890 if (push_element (parser, ELEMENT_INCLUDEDIR) == NULL)
898 else if (element_type == ELEMENT_STANDARD_SESSION_SERVICEDIRS)
900 DBusError local_error = DBUS_ERROR_INIT;
901 DBusList *dirs = NULL;
903 if (!check_no_attributes (parser, "standard_session_servicedirs", attribute_names, attribute_values, error))
906 if (push_element (parser, ELEMENT_STANDARD_SESSION_SERVICEDIRS) == NULL)
912 if (_dbus_set_up_transient_session_servicedirs (&dirs, &local_error))
914 if (!service_dirs_absorb_string_list (&parser->service_dirs, &dirs,
915 BUS_SERVICE_DIR_FLAGS_NO_WATCH |
916 BUS_SERVICE_DIR_FLAGS_STRICT_NAMING))
919 _dbus_list_foreach (&dirs, (DBusForeachFunction) dbus_free,
921 _dbus_list_clear (&dirs);
927 /* Failing to set these up isn't fatal */
928 _dbus_warn ("Unable to set up transient service directory: %s",
929 local_error.message);
930 dbus_error_free (&local_error);
933 _dbus_assert (dirs == NULL);
935 if (!_dbus_get_standard_session_servicedirs (&dirs))
941 /* We have traditionally watched the standard session service
942 * directories with inotify, and allowed service files whose names do not
943 * match the bus name */
944 if (!service_dirs_absorb_string_list (&parser->service_dirs, &dirs,
945 BUS_SERVICE_DIR_FLAGS_NONE))
948 _dbus_list_foreach (&dirs, (DBusForeachFunction) dbus_free,
950 _dbus_list_clear (&dirs);
954 _dbus_assert (dirs == NULL);
958 else if (element_type == ELEMENT_STANDARD_SYSTEM_SERVICEDIRS)
963 if (!check_no_attributes (parser, "standard_system_servicedirs", attribute_names, attribute_values, error))
966 if (push_element (parser, ELEMENT_STANDARD_SYSTEM_SERVICEDIRS) == NULL)
972 if (!_dbus_get_standard_system_servicedirs (&dirs))
978 /* We have traditionally watched the standard system service
979 * directories with inotify, and allowed service files whose names do not
980 * match the bus name (the servicehelper won't successfully activate
981 * them, but we do still parse them) */
982 if (!service_dirs_absorb_string_list (&parser->service_dirs, &dirs,
983 BUS_SERVICE_DIR_FLAGS_NONE))
986 _dbus_list_foreach (&dirs, (DBusForeachFunction) dbus_free,
988 _dbus_list_clear (&dirs);
994 else if (element_type == ELEMENT_ALLOW_ANONYMOUS)
996 if (!check_no_attributes (parser, "allow_anonymous", attribute_names, attribute_values, error))
999 if (push_element (parser, ELEMENT_ALLOW_ANONYMOUS) == NULL)
1001 BUS_SET_OOM (error);
1005 parser->allow_anonymous = TRUE;
1008 else if (element_type == ELEMENT_SERVICEDIR)
1010 if (!check_no_attributes (parser, "servicedir", attribute_names, attribute_values, error))
1013 if (push_element (parser, ELEMENT_SERVICEDIR) == NULL)
1015 BUS_SET_OOM (error);
1021 else if (element_type == ELEMENT_INCLUDE)
1024 const char *if_selinux_enabled;
1025 const char *ignore_missing;
1026 const char *selinux_root_relative;
1028 if ((e = push_element (parser, ELEMENT_INCLUDE)) == NULL)
1030 BUS_SET_OOM (error);
1034 e->d.include.ignore_missing = FALSE;
1035 e->d.include.if_selinux_enabled = FALSE;
1036 e->d.include.selinux_root_relative = FALSE;
1038 if (!locate_attributes (parser, "include",
1042 "ignore_missing", &ignore_missing,
1043 "if_selinux_enabled", &if_selinux_enabled,
1044 "selinux_root_relative", &selinux_root_relative,
1048 if (ignore_missing != NULL)
1050 if (strcmp (ignore_missing, "yes") == 0)
1051 e->d.include.ignore_missing = TRUE;
1052 else if (strcmp (ignore_missing, "no") == 0)
1053 e->d.include.ignore_missing = FALSE;
1056 dbus_set_error (error, DBUS_ERROR_FAILED,
1057 "ignore_missing attribute must have value \"yes\" or \"no\"");
1062 if (if_selinux_enabled != NULL)
1064 if (strcmp (if_selinux_enabled, "yes") == 0)
1065 e->d.include.if_selinux_enabled = TRUE;
1066 else if (strcmp (if_selinux_enabled, "no") == 0)
1067 e->d.include.if_selinux_enabled = FALSE;
1070 dbus_set_error (error, DBUS_ERROR_FAILED,
1071 "if_selinux_enabled attribute must have value"
1072 " \"yes\" or \"no\"");
1077 if (selinux_root_relative != NULL)
1079 if (strcmp (selinux_root_relative, "yes") == 0)
1080 e->d.include.selinux_root_relative = TRUE;
1081 else if (strcmp (selinux_root_relative, "no") == 0)
1082 e->d.include.selinux_root_relative = FALSE;
1085 dbus_set_error (error, DBUS_ERROR_FAILED,
1086 "selinux_root_relative attribute must have value"
1087 " \"yes\" or \"no\"");
1094 else if (element_type == ELEMENT_POLICY)
1097 const char *context;
1100 const char *at_console;
1102 if ((e = push_element (parser, ELEMENT_POLICY)) == NULL)
1104 BUS_SET_OOM (error);
1108 e->d.policy.type = POLICY_IGNORED;
1110 if (!locate_attributes (parser, "policy",
1114 "context", &context,
1117 "at_console", &at_console,
1121 if (((context && user) ||
1122 (context && group) ||
1123 (context && at_console)) ||
1125 (user && at_console)) ||
1126 (group && at_console) ||
1127 !(context || user || group || at_console))
1129 dbus_set_error (error, DBUS_ERROR_FAILED,
1130 "<policy> element must have exactly one of (context|user|group|at_console) attributes");
1134 if (context != NULL)
1136 if (strcmp (context, "default") == 0)
1138 e->d.policy.type = POLICY_DEFAULT;
1140 else if (strcmp (context, "mandatory") == 0)
1142 e->d.policy.type = POLICY_MANDATORY;
1146 dbus_set_error (error, DBUS_ERROR_FAILED,
1147 "context attribute on <policy> must have the value \"default\" or \"mandatory\", not \"%s\"",
1152 else if (user != NULL)
1154 DBusString username;
1155 _dbus_string_init_const (&username, user);
1157 if (_dbus_parse_unix_user_from_config (&username,
1158 &e->d.policy.gid_uid_or_at_console))
1159 e->d.policy.type = POLICY_USER;
1161 _dbus_warn ("Unknown username \"%s\" in message bus configuration file",
1164 else if (group != NULL)
1166 DBusString group_name;
1167 _dbus_string_init_const (&group_name, group);
1169 if (_dbus_parse_unix_group_from_config (&group_name,
1170 &e->d.policy.gid_uid_or_at_console))
1171 e->d.policy.type = POLICY_GROUP;
1173 _dbus_warn ("Unknown group \"%s\" in message bus configuration file",
1176 else if (at_console != NULL)
1179 t = (strcmp (at_console, "true") == 0);
1180 if (t || strcmp (at_console, "false") == 0)
1182 e->d.policy.gid_uid_or_at_console = t;
1183 e->d.policy.type = POLICY_CONSOLE;
1187 dbus_set_error (error, DBUS_ERROR_FAILED,
1188 "Unknown value \"%s\" for at_console in message bus configuration file",
1196 _dbus_assert_not_reached ("all <policy> attributes null and we didn't set error");
1201 else if (element_type == ELEMENT_LIMIT)
1206 if ((e = push_element (parser, ELEMENT_LIMIT)) == NULL)
1208 BUS_SET_OOM (error);
1212 if (!locate_attributes (parser, "limit",
1222 dbus_set_error (error, DBUS_ERROR_FAILED,
1223 "<limit> element must have a \"name\" attribute");
1227 e->d.limit.name = _dbus_strdup (name);
1228 if (e->d.limit.name == NULL)
1230 BUS_SET_OOM (error);
1236 else if (element_type == ELEMENT_SELINUX)
1238 if (!check_no_attributes (parser, "selinux", attribute_names, attribute_values, error))
1241 if (push_element (parser, ELEMENT_SELINUX) == NULL)
1243 BUS_SET_OOM (error);
1249 else if (element_type == ELEMENT_APPARMOR)
1254 if ((e = push_element (parser, ELEMENT_APPARMOR)) == NULL)
1256 BUS_SET_OOM (error);
1260 if (!locate_attributes (parser, "apparmor",
1268 return bus_apparmor_set_mode_from_config (mode, error);
1272 dbus_set_error (error, DBUS_ERROR_FAILED,
1273 "Element <%s> not allowed inside <%s> in configuration file",
1274 element_name, "busconfig");
1280 * Parse an attribute named name, whose content is content, or NULL if
1281 * missing. It is meant to be a (long) integer between min and max inclusive.
1282 * If it is missing, use def as the default value (which does not
1283 * necessarily need to be between min and max).
1286 parse_int_attribute (const char *name,
1287 const char *content,
1294 DBusString parse_string;
1298 if (content == NULL)
1301 _dbus_string_init_const (&parse_string, content);
1303 if (!_dbus_string_parse_int (&parse_string, 0, value, NULL) ||
1304 *value < min || *value > max)
1306 dbus_set_error (error, DBUS_ERROR_FAILED,
1307 "Bad value \"%s\" for %s attribute, must be an "
1308 "integer in range %ld to %ld inclusive",
1309 content, name, min, max);
1317 append_rule_from_element (BusConfigParser *parser,
1318 const char *element_name,
1319 const char **attribute_names,
1320 const char **attribute_values,
1326 /* Group: send_ attributes */
1327 const char *send_interface;
1328 const char *send_member;
1329 const char *send_error;
1330 const char *send_destination;
1331 const char *send_path;
1332 const char *send_type;
1333 const char *send_requested_reply;
1334 const char *send_broadcast;
1335 /* TRUE if any send_ attribute is present */
1336 dbus_bool_t any_send_attribute;
1338 /* Group: receive_ attributes */
1339 const char *receive_interface;
1340 const char *receive_member;
1341 const char *receive_error;
1342 const char *receive_sender;
1343 const char *receive_path;
1344 const char *receive_type;
1345 const char *receive_requested_reply;
1346 /* TRUE if any receive_ attribute is present */
1347 dbus_bool_t any_receive_attribute;
1349 /* Group: message-matching modifiers that can go on send_ or receive_ */
1350 const char *eavesdrop;
1351 const char *max_fds_attr;
1352 long max_fds = DBUS_MAXIMUM_MESSAGE_UNIX_FDS;
1353 const char *min_fds_attr;
1355 /* TRUE if any message-matching modifier is present */
1356 dbus_bool_t any_message_attribute;
1358 /* Non-message-related attributes */
1360 const char *own_prefix;
1364 BusPolicyRule *rule;
1366 if (!locate_attributes (parser, element_name,
1370 "send_interface", &send_interface,
1371 "send_member", &send_member,
1372 "send_error", &send_error,
1373 "send_destination", &send_destination,
1374 "send_path", &send_path,
1375 "send_type", &send_type,
1376 "send_broadcast", &send_broadcast,
1377 "receive_interface", &receive_interface,
1378 "receive_member", &receive_member,
1379 "receive_error", &receive_error,
1380 "receive_sender", &receive_sender,
1381 "receive_path", &receive_path,
1382 "receive_type", &receive_type,
1383 "eavesdrop", &eavesdrop,
1384 "max_fds", &max_fds_attr,
1385 "min_fds", &min_fds_attr,
1386 "send_requested_reply", &send_requested_reply,
1387 "receive_requested_reply", &receive_requested_reply,
1389 "own_prefix", &own_prefix,
1396 any_send_attribute = (send_destination != NULL ||
1397 send_broadcast != NULL ||
1398 send_path != NULL ||
1399 send_type != NULL ||
1400 send_interface != NULL ||
1401 send_member != NULL ||
1402 send_error != NULL ||
1403 send_requested_reply != NULL);
1404 any_receive_attribute = (receive_sender != NULL ||
1405 receive_path != NULL ||
1406 receive_type != NULL ||
1407 receive_interface != NULL ||
1408 receive_member != NULL ||
1409 receive_error != NULL ||
1410 receive_requested_reply != NULL ||
1411 /* <allow eavesdrop="true"/> means the same as
1412 * <allow receive_sender="*" eavesdrop="true"/>,
1413 * but <allow send_anything="anything"/> can also
1414 * take the eavesdrop attribute and still counts
1415 * as a send rule. */
1416 (!any_send_attribute && eavesdrop != NULL));
1417 any_message_attribute = (any_send_attribute ||
1418 any_receive_attribute ||
1419 eavesdrop != NULL ||
1420 max_fds_attr != NULL ||
1421 min_fds_attr != NULL);
1423 if (!(any_send_attribute ||
1424 any_receive_attribute ||
1425 own || own_prefix || user || group))
1427 dbus_set_error (error, DBUS_ERROR_FAILED,
1428 "Element <%s> must have one or more attributes",
1433 if ((send_member && (send_interface == NULL && send_path == NULL)) ||
1434 (receive_member && (receive_interface == NULL && receive_path == NULL)))
1436 dbus_set_error (error, DBUS_ERROR_FAILED,
1437 "On element <%s>, if you specify a member you must specify an interface or a path. Keep in mind that not all messages have an interface field.",
1442 /* Allowed combinations of elements are:
1444 * base, must be all send or all receive:
1447 * interface + member
1450 * base send_ can combine with send_destination, send_path, send_type, send_requested_reply, send_broadcast, eavesdrop
1451 * base receive_ with receive_sender, receive_path, receive_type, receive_requested_reply, eavesdrop
1453 * user, group, own, own_prefix must occur alone
1456 if (any_message_attribute +
1458 (own_prefix != NULL) +
1460 (group != NULL)) > 1)
1462 dbus_set_error (error, DBUS_ERROR_FAILED,
1463 "Invalid combination of attributes on element <%s>: "
1464 "own, own_prefix, user, group and the message-related "
1465 "attributes cannot be combined",
1470 if (any_send_attribute && any_receive_attribute)
1472 dbus_set_error (error, DBUS_ERROR_FAILED,
1473 "Invalid combination of attributes on element <%s>: "
1474 "send and receive attributes cannot be combined",
1479 if ((send_member != NULL || send_interface != NULL) && send_error != NULL)
1481 dbus_set_error (error, DBUS_ERROR_FAILED,
1482 "Invalid combination of attributes on element <%s>: "
1483 "send_error cannot be combined with send_member or "
1489 if ((receive_member != NULL || receive_interface != NULL) &&
1490 receive_error != NULL)
1492 dbus_set_error (error, DBUS_ERROR_FAILED,
1493 "Invalid combination of attributes on element <%s>: "
1494 "receive_error cannot be combined with receive_member "
1495 "or receive_interface",
1502 /* In BusPolicyRule, NULL represents wildcard.
1503 * In the config file, '*' represents it.
1505 #define IS_WILDCARD(str) ((str) && ((str)[0]) == '*' && ((str)[1]) == '\0')
1507 if (any_send_attribute)
1511 if (IS_WILDCARD (send_interface))
1512 send_interface = NULL;
1513 if (IS_WILDCARD (send_member))
1515 if (IS_WILDCARD (send_error))
1517 if (IS_WILDCARD (send_destination))
1518 send_destination = NULL;
1519 if (IS_WILDCARD (send_path))
1521 if (IS_WILDCARD (send_type))
1524 message_type = DBUS_MESSAGE_TYPE_INVALID;
1525 if (send_type != NULL)
1527 message_type = dbus_message_type_from_string (send_type);
1528 if (message_type == DBUS_MESSAGE_TYPE_INVALID)
1530 dbus_set_error (error, DBUS_ERROR_FAILED,
1531 "Bad message type \"%s\"",
1538 !(strcmp (eavesdrop, "true") == 0 ||
1539 strcmp (eavesdrop, "false") == 0))
1541 dbus_set_error (error, DBUS_ERROR_FAILED,
1542 "Bad value \"%s\" for %s attribute, must be true or false",
1543 "eavesdrop", eavesdrop);
1547 if (send_broadcast &&
1548 !(strcmp (send_broadcast, "true") == 0 ||
1549 strcmp (send_broadcast, "false") == 0))
1551 dbus_set_error (error, DBUS_ERROR_FAILED,
1552 "Bad value \"%s\" for %s attribute, must be true or false",
1553 send_broadcast, "send_broadcast");
1557 if (send_requested_reply &&
1558 !(strcmp (send_requested_reply, "true") == 0 ||
1559 strcmp (send_requested_reply, "false") == 0))
1561 dbus_set_error (error, DBUS_ERROR_FAILED,
1562 "Bad value \"%s\" for %s attribute, must be true or false",
1563 "send_requested_reply", send_requested_reply);
1567 /* Matching only messages with DBUS_MAXIMUM_MESSAGE_UNIX_FDS or fewer
1568 * fds is the same as matching all messages, so we always set a maximum,
1569 * but perhaps an unrealistically high one. */
1570 if (!parse_int_attribute ("max_fds", max_fds_attr,
1571 0, DBUS_MAXIMUM_MESSAGE_UNIX_FDS,
1572 DBUS_MAXIMUM_MESSAGE_UNIX_FDS, &max_fds,
1574 !parse_int_attribute ("min_fds", min_fds_attr,
1575 0, DBUS_MAXIMUM_MESSAGE_UNIX_FDS, 0, &min_fds,
1579 rule = bus_policy_rule_new (BUS_POLICY_RULE_SEND, allow);
1584 rule->d.send.eavesdrop = (strcmp (eavesdrop, "true") == 0);
1587 rule->d.send.log = (strcmp (log, "true") == 0);
1589 if (send_requested_reply)
1590 rule->d.send.requested_reply = (strcmp (send_requested_reply, "true") == 0);
1594 if (strcmp (send_broadcast, "true") == 0)
1595 rule->d.send.broadcast = BUS_POLICY_TRISTATE_TRUE;
1597 rule->d.send.broadcast = BUS_POLICY_TRISTATE_FALSE;
1601 rule->d.send.broadcast = BUS_POLICY_TRISTATE_ANY;
1604 rule->d.send.message_type = message_type;
1605 rule->d.send.path = _dbus_strdup (send_path);
1606 rule->d.send.interface = _dbus_strdup (send_interface);
1607 rule->d.send.member = _dbus_strdup (send_member);
1608 rule->d.send.error = _dbus_strdup (send_error);
1609 rule->d.send.destination = _dbus_strdup (send_destination);
1610 rule->d.send.max_fds = max_fds;
1611 rule->d.send.min_fds = min_fds;
1613 if (send_path && rule->d.send.path == NULL)
1615 if (send_interface && rule->d.send.interface == NULL)
1617 if (send_member && rule->d.send.member == NULL)
1619 if (send_error && rule->d.send.error == NULL)
1621 if (send_destination && rule->d.send.destination == NULL)
1624 else if (any_receive_attribute)
1628 if (IS_WILDCARD (receive_interface))
1629 receive_interface = NULL;
1630 if (IS_WILDCARD (receive_member))
1631 receive_member = NULL;
1632 if (IS_WILDCARD (receive_error))
1633 receive_error = NULL;
1634 if (IS_WILDCARD (receive_sender))
1635 receive_sender = NULL;
1636 if (IS_WILDCARD (receive_path))
1637 receive_path = NULL;
1638 if (IS_WILDCARD (receive_type))
1639 receive_type = NULL;
1641 message_type = DBUS_MESSAGE_TYPE_INVALID;
1642 if (receive_type != NULL)
1644 message_type = dbus_message_type_from_string (receive_type);
1645 if (message_type == DBUS_MESSAGE_TYPE_INVALID)
1647 dbus_set_error (error, DBUS_ERROR_FAILED,
1648 "Bad message type \"%s\"",
1656 !(strcmp (eavesdrop, "true") == 0 ||
1657 strcmp (eavesdrop, "false") == 0))
1659 dbus_set_error (error, DBUS_ERROR_FAILED,
1660 "Bad value \"%s\" for %s attribute, must be true or false",
1661 "eavesdrop", eavesdrop);
1665 if (receive_requested_reply &&
1666 !(strcmp (receive_requested_reply, "true") == 0 ||
1667 strcmp (receive_requested_reply, "false") == 0))
1669 dbus_set_error (error, DBUS_ERROR_FAILED,
1670 "Bad value \"%s\" for %s attribute, must be true or false",
1671 "receive_requested_reply", receive_requested_reply);
1675 if (!parse_int_attribute ("max_fds", max_fds_attr,
1676 0, DBUS_MAXIMUM_MESSAGE_UNIX_FDS,
1677 DBUS_MAXIMUM_MESSAGE_UNIX_FDS, &max_fds,
1679 !parse_int_attribute ("min_fds", min_fds_attr,
1680 0, DBUS_MAXIMUM_MESSAGE_UNIX_FDS, 0, &min_fds,
1684 rule = bus_policy_rule_new (BUS_POLICY_RULE_RECEIVE, allow);
1689 rule->d.receive.eavesdrop = (strcmp (eavesdrop, "true") == 0);
1691 if (receive_requested_reply)
1692 rule->d.receive.requested_reply = (strcmp (receive_requested_reply, "true") == 0);
1694 rule->d.receive.message_type = message_type;
1695 rule->d.receive.path = _dbus_strdup (receive_path);
1696 rule->d.receive.interface = _dbus_strdup (receive_interface);
1697 rule->d.receive.member = _dbus_strdup (receive_member);
1698 rule->d.receive.error = _dbus_strdup (receive_error);
1699 rule->d.receive.origin = _dbus_strdup (receive_sender);
1700 rule->d.receive.max_fds = max_fds;
1701 rule->d.receive.min_fds = min_fds;
1703 if (receive_path && rule->d.receive.path == NULL)
1705 if (receive_interface && rule->d.receive.interface == NULL)
1707 if (receive_member && rule->d.receive.member == NULL)
1709 if (receive_error && rule->d.receive.error == NULL)
1711 if (receive_sender && rule->d.receive.origin == NULL)
1714 else if (own || own_prefix)
1716 rule = bus_policy_rule_new (BUS_POLICY_RULE_OWN, allow);
1722 if (IS_WILDCARD (own))
1725 rule->d.own.prefix = 0;
1726 rule->d.own.service_name = _dbus_strdup (own);
1727 if (own && rule->d.own.service_name == NULL)
1732 rule->d.own.prefix = 1;
1733 rule->d.own.service_name = _dbus_strdup (own_prefix);
1734 if (rule->d.own.service_name == NULL)
1740 if (IS_WILDCARD (user))
1742 rule = bus_policy_rule_new (BUS_POLICY_RULE_USER, allow);
1746 rule->d.user.uid = DBUS_UID_UNSET;
1750 DBusString username;
1753 _dbus_string_init_const (&username, user);
1755 if (_dbus_parse_unix_user_from_config (&username, &uid))
1757 rule = bus_policy_rule_new (BUS_POLICY_RULE_USER, allow);
1761 rule->d.user.uid = uid;
1765 _dbus_warn ("Unknown username \"%s\" on element <%s>",
1766 user, element_name);
1772 if (IS_WILDCARD (group))
1774 rule = bus_policy_rule_new (BUS_POLICY_RULE_GROUP, allow);
1778 rule->d.group.gid = DBUS_GID_UNSET;
1782 DBusString groupname;
1785 _dbus_string_init_const (&groupname, group);
1787 if (_dbus_parse_unix_group_from_config (&groupname, &gid))
1789 rule = bus_policy_rule_new (BUS_POLICY_RULE_GROUP, allow);
1793 rule->d.group.gid = gid;
1797 _dbus_warn ("Unknown group \"%s\" on element <%s>",
1798 group, element_name);
1803 _dbus_assert_not_reached ("Did not handle some combination of attributes on <allow> or <deny>");
1809 pe = peek_element (parser);
1810 _dbus_assert (pe != NULL);
1811 _dbus_assert (pe->type == ELEMENT_POLICY);
1813 switch (pe->d.policy.type)
1815 case POLICY_IGNORED:
1817 /* drop the rule on the floor */
1820 case POLICY_DEFAULT:
1821 if (!bus_policy_append_default_rule (parser->policy, rule))
1824 case POLICY_MANDATORY:
1825 if (!bus_policy_append_mandatory_rule (parser->policy, rule))
1829 if (!BUS_POLICY_RULE_IS_PER_CLIENT (rule))
1831 dbus_set_error (error, DBUS_ERROR_FAILED,
1832 "<%s> rule cannot be per-user because it has bus-global semantics",
1837 if (!bus_policy_append_user_rule (parser->policy, pe->d.policy.gid_uid_or_at_console,
1842 if (!BUS_POLICY_RULE_IS_PER_CLIENT (rule))
1844 dbus_set_error (error, DBUS_ERROR_FAILED,
1845 "<%s> rule cannot be per-group because it has bus-global semantics",
1850 if (!bus_policy_append_group_rule (parser->policy, pe->d.policy.gid_uid_or_at_console,
1856 case POLICY_CONSOLE:
1857 if (!bus_policy_append_console_rule (parser->policy, pe->d.policy.gid_uid_or_at_console,
1863 bus_policy_rule_unref (rule);
1870 BUS_SET_OOM (error);
1873 bus_policy_rule_unref (rule);
1878 start_policy_child (BusConfigParser *parser,
1879 const char *element_name,
1880 const char **attribute_names,
1881 const char **attribute_values,
1884 if (strcmp (element_name, "allow") == 0)
1886 if (!append_rule_from_element (parser, element_name,
1887 attribute_names, attribute_values,
1891 if (push_element (parser, ELEMENT_ALLOW) == NULL)
1893 BUS_SET_OOM (error);
1899 else if (strcmp (element_name, "deny") == 0)
1901 if (!append_rule_from_element (parser, element_name,
1902 attribute_names, attribute_values,
1906 if (push_element (parser, ELEMENT_DENY) == NULL)
1908 BUS_SET_OOM (error);
1916 dbus_set_error (error, DBUS_ERROR_FAILED,
1917 "Element <%s> not allowed inside <%s> in configuration file",
1918 element_name, "policy");
1924 start_selinux_child (BusConfigParser *parser,
1925 const char *element_name,
1926 const char **attribute_names,
1927 const char **attribute_values,
1934 context_copy = NULL;
1936 if (strcmp (element_name, "associate") == 0)
1939 const char *context;
1941 if (!locate_attributes (parser, "associate",
1946 "context", &context,
1950 if (push_element (parser, ELEMENT_ASSOCIATE) == NULL)
1952 BUS_SET_OOM (error);
1956 if (own == NULL || context == NULL)
1958 dbus_set_error (error, DBUS_ERROR_FAILED,
1959 "Element <associate> must have attributes own=\"<servicename>\" and context=\"<selinux context>\"");
1963 own_copy = _dbus_strdup (own);
1964 if (own_copy == NULL)
1966 context_copy = _dbus_strdup (context);
1967 if (context_copy == NULL)
1970 if (!_dbus_hash_table_insert_string (parser->service_context_table,
1971 own_copy, context_copy))
1978 dbus_set_error (error, DBUS_ERROR_FAILED,
1979 "Element <%s> not allowed inside <%s> in configuration file",
1980 element_name, "selinux");
1986 dbus_free (own_copy);
1989 dbus_free (context_copy);
1991 BUS_SET_OOM (error);
1996 bus_config_parser_start_element (BusConfigParser *parser,
1997 const char *element_name,
1998 const char **attribute_names,
1999 const char **attribute_values,
2004 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2006 /* printf ("START: %s\n", element_name); */
2008 t = top_element_type (parser);
2010 if (t == ELEMENT_NONE)
2012 if (strcmp (element_name, "busconfig") == 0)
2014 if (!check_no_attributes (parser, "busconfig", attribute_names, attribute_values, error))
2017 if (push_element (parser, ELEMENT_BUSCONFIG) == NULL)
2019 BUS_SET_OOM (error);
2027 dbus_set_error (error, DBUS_ERROR_FAILED,
2028 "Unknown element <%s> at root of configuration file",
2033 else if (t == ELEMENT_BUSCONFIG)
2035 return start_busconfig_child (parser, element_name,
2036 attribute_names, attribute_values,
2039 else if (t == ELEMENT_POLICY)
2041 return start_policy_child (parser, element_name,
2042 attribute_names, attribute_values,
2045 else if (t == ELEMENT_SELINUX)
2047 return start_selinux_child (parser, element_name,
2048 attribute_names, attribute_values,
2053 dbus_set_error (error, DBUS_ERROR_FAILED,
2054 "Element <%s> is not allowed in this context",
2061 set_limit (BusConfigParser *parser,
2066 dbus_bool_t must_be_positive;
2067 dbus_bool_t must_be_int;
2069 must_be_int = FALSE;
2070 must_be_positive = FALSE;
2072 if (strcmp (name, "max_incoming_bytes") == 0)
2074 must_be_positive = TRUE;
2075 parser->limits.max_incoming_bytes = value;
2077 else if (strcmp (name, "max_incoming_unix_fds") == 0)
2079 must_be_positive = TRUE;
2080 parser->limits.max_incoming_unix_fds = value;
2082 else if (strcmp (name, "max_outgoing_bytes") == 0)
2084 must_be_positive = TRUE;
2085 parser->limits.max_outgoing_bytes = value;
2087 else if (strcmp (name, "max_outgoing_unix_fds") == 0)
2089 must_be_positive = TRUE;
2090 parser->limits.max_outgoing_unix_fds = value;
2092 else if (strcmp (name, "max_message_size") == 0)
2094 must_be_positive = TRUE;
2095 parser->limits.max_message_size = value;
2097 else if (strcmp (name, "max_message_unix_fds") == 0)
2099 must_be_positive = TRUE;
2100 parser->limits.max_message_unix_fds = value;
2102 else if (strcmp (name, "service_start_timeout") == 0)
2104 must_be_positive = TRUE;
2106 parser->limits.activation_timeout = value;
2108 else if (strcmp (name, "auth_timeout") == 0)
2110 must_be_positive = TRUE;
2112 parser->limits.auth_timeout = value;
2114 else if (strcmp (name, "pending_fd_timeout") == 0)
2116 must_be_positive = TRUE;
2118 parser->limits.pending_fd_timeout = value;
2120 else if (strcmp (name, "reply_timeout") == 0)
2122 must_be_positive = TRUE;
2124 parser->limits.reply_timeout = value;
2126 else if (strcmp (name, "max_completed_connections") == 0)
2128 must_be_positive = TRUE;
2130 parser->limits.max_completed_connections = value;
2132 else if (strcmp (name, "max_incomplete_connections") == 0)
2134 must_be_positive = TRUE;
2136 parser->limits.max_incomplete_connections = value;
2138 else if (strcmp (name, "max_connections_per_user") == 0)
2140 must_be_positive = TRUE;
2142 parser->limits.max_connections_per_user = value;
2144 else if (strcmp (name, "max_pending_service_starts") == 0)
2146 must_be_positive = TRUE;
2148 parser->limits.max_pending_activations = value;
2150 else if (strcmp (name, "max_names_per_connection") == 0)
2152 must_be_positive = TRUE;
2154 parser->limits.max_services_per_connection = value;
2156 else if (strcmp (name, "max_match_rules_per_connection") == 0)
2158 must_be_positive = TRUE;
2160 parser->limits.max_match_rules_per_connection = value;
2162 else if (strcmp (name, "max_replies_per_connection") == 0)
2164 must_be_positive = TRUE;
2166 parser->limits.max_replies_per_connection = value;
2170 dbus_set_error (error, DBUS_ERROR_FAILED,
2171 "There is no limit called \"%s\"\n",
2176 if (must_be_positive && value < 0)
2178 dbus_set_error (error, DBUS_ERROR_FAILED,
2179 "<limit name=\"%s\"> must be a positive number\n",
2185 (value < _DBUS_INT_MIN || value > _DBUS_INT_MAX))
2187 dbus_set_error (error, DBUS_ERROR_FAILED,
2188 "<limit name=\"%s\"> value is too large\n",
2197 bus_config_parser_end_element (BusConfigParser *parser,
2198 const char *element_name,
2205 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2207 /* printf ("END: %s\n", element_name); */
2209 t = top_element_type (parser);
2211 if (t == ELEMENT_NONE)
2213 /* should probably be an assertion failure but
2214 * being paranoid about XML parsers
2216 dbus_set_error (error, DBUS_ERROR_FAILED,
2217 "XML parser ended element with no element on the stack");
2221 n = bus_config_parser_element_type_to_name (t);
2222 _dbus_assert (n != NULL);
2223 if (strcmp (n, element_name) != 0)
2225 /* should probably be an assertion failure but
2226 * being paranoid about XML parsers
2228 dbus_set_error (error, DBUS_ERROR_FAILED,
2229 "XML element <%s> ended but topmost element on the stack was <%s>",
2234 e = peek_element (parser);
2235 _dbus_assert (e != NULL);
2241 _dbus_assert_not_reached ("element in stack has no type");
2244 case ELEMENT_INCLUDE:
2246 case ELEMENT_CONFIGTYPE:
2247 case ELEMENT_LISTEN:
2248 case ELEMENT_PIDFILE:
2250 case ELEMENT_SERVICEDIR:
2251 case ELEMENT_SERVICEHELPER:
2252 case ELEMENT_INCLUDEDIR:
2254 if (!e->had_content)
2256 dbus_set_error (error, DBUS_ERROR_FAILED,
2257 "XML element <%s> was expected to have content inside it",
2258 bus_config_parser_element_type_to_name (e->type));
2262 if (e->type == ELEMENT_LIMIT)
2264 if (!set_limit (parser, e->d.limit.name, e->d.limit.value,
2270 case ELEMENT_BUSCONFIG:
2271 case ELEMENT_POLICY:
2275 case ELEMENT_SYSLOG:
2276 case ELEMENT_KEEP_UMASK:
2277 case ELEMENT_SELINUX:
2278 case ELEMENT_ASSOCIATE:
2279 case ELEMENT_STANDARD_SESSION_SERVICEDIRS:
2280 case ELEMENT_STANDARD_SYSTEM_SERVICEDIRS:
2281 case ELEMENT_ALLOW_ANONYMOUS:
2282 case ELEMENT_APPARMOR:
2286 pop_element (parser);
2292 all_whitespace (const DBusString *str)
2296 _dbus_string_skip_white (str, 0, &i);
2298 return i == _dbus_string_get_length (str);
2302 make_full_path (const DBusString *basedir,
2303 const DBusString *filename,
2304 DBusString *full_path)
2306 if (_dbus_path_is_absolute (filename))
2308 if (!_dbus_string_copy (filename, 0, full_path, 0))
2313 if (!_dbus_string_copy (basedir, 0, full_path, 0))
2316 if (!_dbus_concat_dir_and_file (full_path, filename))
2320 if (!_dbus_replace_install_prefix (full_path))
2327 include_file (BusConfigParser *parser,
2328 const DBusString *filename,
2329 dbus_bool_t ignore_missing,
2332 /* FIXME good test case for this would load each config file in the
2333 * test suite both alone, and as an include, and check
2334 * that the result is the same
2336 BusConfigParser *included;
2337 const char *filename_str;
2338 DBusError tmp_error;
2340 dbus_error_init (&tmp_error);
2342 filename_str = _dbus_string_get_const_data (filename);
2344 /* Check to make sure this file hasn't already been included. */
2345 if (seen_include (parser, filename))
2347 dbus_set_error (error, DBUS_ERROR_FAILED,
2348 "Circular inclusion of file '%s'",
2353 if (! _dbus_list_append (&parser->included_files, (void *) filename_str))
2355 BUS_SET_OOM (error);
2359 /* Since parser is passed in as the parent, included
2360 inherits parser's limits. */
2361 included = bus_config_load (filename, FALSE, parser, &tmp_error);
2363 _dbus_list_pop_last (&parser->included_files);
2365 if (included == NULL)
2367 _DBUS_ASSERT_ERROR_IS_SET (&tmp_error);
2369 if (dbus_error_has_name (&tmp_error, DBUS_ERROR_FILE_NOT_FOUND) &&
2372 dbus_error_free (&tmp_error);
2377 dbus_move_error (&tmp_error, error);
2383 _DBUS_ASSERT_ERROR_IS_CLEAR (&tmp_error);
2385 if (!merge_included (parser, included, error))
2387 bus_config_parser_unref (included);
2391 /* Copy included's limits back to parser. */
2392 parser->limits = included->limits;
2394 bus_config_parser_unref (included);
2400 servicehelper_path (BusConfigParser *parser,
2401 const DBusString *filename,
2404 const char *filename_str;
2405 char *servicehelper;
2407 filename_str = _dbus_string_get_const_data (filename);
2409 /* copy to avoid overwriting with NULL on OOM */
2410 servicehelper = _dbus_strdup (filename_str);
2413 if (servicehelper == NULL)
2415 BUS_SET_OOM (error);
2419 /* save the latest servicehelper only if not OOM */
2420 dbus_free (parser->servicehelper);
2421 parser->servicehelper = servicehelper;
2423 /* We don't check whether the helper exists; instead we
2424 * would just fail to ever activate anything if it doesn't.
2425 * This allows an admin to fix the problem if it doesn't exist.
2426 * It also allows the parser test suite to successfully parse
2427 * test cases without installing the helper. ;-)
2434 include_dir (BusConfigParser *parser,
2435 const DBusString *dirname,
2438 DBusString filename;
2440 DBusError tmp_error;
2444 if (!_dbus_string_init (&filename))
2446 BUS_SET_OOM (error);
2452 dir = _dbus_directory_open (dirname, error);
2456 if (dbus_error_has_name (error, DBUS_ERROR_FILE_NOT_FOUND))
2458 dbus_error_free (error);
2465 dbus_error_init (&tmp_error);
2466 while (_dbus_directory_get_next_file (dir, &filename, &tmp_error))
2468 DBusString full_path;
2470 if (!_dbus_string_init (&full_path))
2472 BUS_SET_OOM (error);
2476 if (!_dbus_string_copy (dirname, 0, &full_path, 0))
2478 BUS_SET_OOM (error);
2479 _dbus_string_free (&full_path);
2483 if (!_dbus_concat_dir_and_file (&full_path, &filename))
2485 BUS_SET_OOM (error);
2486 _dbus_string_free (&full_path);
2490 if (_dbus_string_ends_with_c_str (&full_path, ".conf"))
2492 if (!include_file (parser, &full_path, TRUE, error))
2494 if (dbus_error_is_set (error))
2496 /* We use both syslog and stderr here, because this is
2497 * the configuration parser, so we don't yet know whether
2498 * this bus is going to want to write to syslog! Err on
2499 * the side of making sure the message gets to the sysadmin
2501 _dbus_init_system_log ("dbus-daemon",
2502 DBUS_LOG_FLAGS_STDERR | DBUS_LOG_FLAGS_SYSTEM_LOG);
2503 _dbus_log (DBUS_SYSTEM_LOG_INFO,
2504 "Encountered error '%s' while parsing '%s'",
2506 _dbus_string_get_const_data (&full_path));
2507 dbus_error_free (error);
2512 _dbus_string_free (&full_path);
2515 if (dbus_error_is_set (&tmp_error))
2517 dbus_move_error (&tmp_error, error);
2522 if (!_dbus_string_copy_data (dirname, &s))
2524 BUS_SET_OOM (error);
2528 if (!_dbus_list_append (&parser->conf_dirs, s))
2531 BUS_SET_OOM (error);
2539 _dbus_string_free (&filename);
2542 _dbus_directory_close (dir);
2548 bus_config_parser_content (BusConfigParser *parser,
2549 const DBusString *content,
2554 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2560 _dbus_string_get_const_data (content, &c_str);
2562 printf ("CONTENT %d bytes: %s\n", _dbus_string_get_length (content), c_str);
2566 e = peek_element (parser);
2569 dbus_set_error (error, DBUS_ERROR_FAILED,
2570 "Text content outside of any XML element in configuration file");
2573 else if (e->had_content)
2575 _dbus_assert_not_reached ("Element had multiple content blocks");
2579 switch (top_element_type (parser))
2583 _dbus_assert_not_reached ("element at top of stack has no type");
2586 case ELEMENT_BUSCONFIG:
2587 case ELEMENT_POLICY:
2591 case ELEMENT_SYSLOG:
2592 case ELEMENT_KEEP_UMASK:
2593 case ELEMENT_STANDARD_SESSION_SERVICEDIRS:
2594 case ELEMENT_STANDARD_SYSTEM_SERVICEDIRS:
2595 case ELEMENT_ALLOW_ANONYMOUS:
2596 case ELEMENT_SELINUX:
2597 case ELEMENT_ASSOCIATE:
2598 case ELEMENT_APPARMOR:
2599 if (all_whitespace (content))
2603 dbus_set_error (error, DBUS_ERROR_FAILED,
2604 "No text content expected inside XML element %s in configuration file",
2605 bus_config_parser_element_type_to_name (top_element_type (parser)));
2609 case ELEMENT_PIDFILE:
2613 e->had_content = TRUE;
2615 if (!_dbus_string_copy_data (content, &s))
2618 dbus_free (parser->pidfile);
2619 parser->pidfile = s;
2623 case ELEMENT_INCLUDE:
2625 DBusString full_path, selinux_policy_root;
2627 e->had_content = TRUE;
2629 if (e->d.include.if_selinux_enabled
2630 && !bus_selinux_enabled ())
2633 if (!_dbus_string_init (&full_path))
2636 if (e->d.include.selinux_root_relative)
2638 if (!bus_selinux_get_policy_root ())
2640 dbus_set_error (error, DBUS_ERROR_FAILED,
2641 "Could not determine SELinux policy root for relative inclusion");
2642 _dbus_string_free (&full_path);
2645 _dbus_string_init_const (&selinux_policy_root,
2646 bus_selinux_get_policy_root ());
2647 if (!make_full_path (&selinux_policy_root, content, &full_path))
2649 _dbus_string_free (&full_path);
2653 else if (!make_full_path (&parser->basedir, content, &full_path))
2655 _dbus_string_free (&full_path);
2659 if (!include_file (parser, &full_path,
2660 e->d.include.ignore_missing, error))
2662 _dbus_string_free (&full_path);
2666 _dbus_string_free (&full_path);
2670 case ELEMENT_SERVICEHELPER:
2672 DBusString full_path;
2674 e->had_content = TRUE;
2676 if (!_dbus_string_init (&full_path))
2679 if (!make_full_path (&parser->basedir, content, &full_path))
2681 _dbus_string_free (&full_path);
2685 if (!servicehelper_path (parser, &full_path, error))
2687 _dbus_string_free (&full_path);
2691 _dbus_string_free (&full_path);
2695 case ELEMENT_INCLUDEDIR:
2697 DBusString full_path;
2699 e->had_content = TRUE;
2701 if (!_dbus_string_init (&full_path))
2704 if (!make_full_path (&parser->basedir, content, &full_path))
2706 _dbus_string_free (&full_path);
2710 if (!include_dir (parser, &full_path, error))
2712 _dbus_string_free (&full_path);
2716 _dbus_string_free (&full_path);
2724 e->had_content = TRUE;
2726 if (!_dbus_string_copy_data (content, &s))
2729 dbus_free (parser->user);
2734 case ELEMENT_CONFIGTYPE:
2738 e->had_content = TRUE;
2740 if (!_dbus_string_copy_data (content, &s))
2743 dbus_free (parser->bus_type);
2744 parser->bus_type = s;
2748 case ELEMENT_LISTEN:
2752 e->had_content = TRUE;
2754 if (!_dbus_string_copy_data (content, &s))
2757 if (!_dbus_list_append (&parser->listen_on,
2770 e->had_content = TRUE;
2772 if (!_dbus_string_copy_data (content, &s))
2775 if (!_dbus_list_append (&parser->mechanisms,
2784 case ELEMENT_SERVICEDIR:
2787 BusConfigServiceDir *dir;
2788 DBusString full_path;
2791 e->had_content = TRUE;
2793 if (!_dbus_string_init (&full_path))
2796 if (!make_full_path (&parser->basedir, content, &full_path))
2798 _dbus_string_free (&full_path);
2802 if (!_dbus_string_copy_data (&full_path, &s))
2804 _dbus_string_free (&full_path);
2808 /* <servicedir/> has traditionally implied that we watch the
2809 * directory with inotify, and allow service files whose names do not
2810 * match the bus name */
2811 dir = bus_config_service_dir_new_take (s, BUS_SERVICE_DIR_FLAGS_NONE);
2815 _dbus_string_free (&full_path);
2820 link = _dbus_list_alloc_link (dir);
2824 _dbus_string_free (&full_path);
2825 bus_config_service_dir_free (dir);
2830 service_dirs_append_link_unique_or_free (&parser->service_dirs, link);
2831 _dbus_string_free (&full_path);
2839 e->had_content = TRUE;
2842 if (!_dbus_string_parse_int (content, 0, &val, NULL))
2844 dbus_set_error (error, DBUS_ERROR_FAILED,
2845 "<limit name=\"%s\"> element has invalid value (could not parse as integer)",
2850 e->d.limit.value = val;
2852 _dbus_verbose ("Loaded value %ld for limit %s\n",
2859 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2863 BUS_SET_OOM (error);
2868 bus_config_parser_finished (BusConfigParser *parser,
2871 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2873 if (parser->stack != NULL)
2875 dbus_set_error (error, DBUS_ERROR_FAILED,
2876 "Element <%s> was not closed in configuration file",
2877 bus_config_parser_element_type_to_name (top_element_type (parser)));
2882 if (parser->is_toplevel && parser->listen_on == NULL)
2884 dbus_set_error (error, DBUS_ERROR_FAILED,
2885 "Configuration file needs one or more <listen> elements giving addresses");
2893 bus_config_parser_get_user (BusConfigParser *parser)
2895 return parser->user;
2899 bus_config_parser_get_type (BusConfigParser *parser)
2901 return parser->bus_type;
2905 bus_config_parser_get_addresses (BusConfigParser *parser)
2907 return &parser->listen_on;
2911 bus_config_parser_get_mechanisms (BusConfigParser *parser)
2913 return &parser->mechanisms;
2917 bus_config_parser_get_service_dirs (BusConfigParser *parser)
2919 return &parser->service_dirs;
2923 bus_config_parser_get_conf_dirs (BusConfigParser *parser)
2925 return &parser->conf_dirs;
2929 bus_config_parser_get_fork (BusConfigParser *parser)
2931 return parser->fork;
2935 bus_config_parser_get_syslog (BusConfigParser *parser)
2937 return parser->syslog;
2941 bus_config_parser_get_keep_umask (BusConfigParser *parser)
2943 return parser->keep_umask;
2947 bus_config_parser_get_allow_anonymous (BusConfigParser *parser)
2949 return parser->allow_anonymous;
2953 bus_config_parser_get_pidfile (BusConfigParser *parser)
2955 return parser->pidfile;
2959 bus_config_parser_get_servicehelper (BusConfigParser *parser)
2961 return parser->servicehelper;
2965 bus_config_parser_steal_policy (BusConfigParser *parser)
2969 _dbus_assert (parser->policy != NULL); /* can only steal the policy 1 time */
2971 policy = parser->policy;
2973 parser->policy = NULL;
2978 /* Overwrite any limits that were set in the configuration file */
2980 bus_config_parser_get_limits (BusConfigParser *parser,
2983 *limits = parser->limits;
2987 bus_config_parser_steal_service_context_table (BusConfigParser *parser)
2989 DBusHashTable *table;
2991 _dbus_assert (parser->service_context_table != NULL); /* can only steal once */
2993 table = parser->service_context_table;
2995 parser->service_context_table = NULL;
3001 * Return a list of the directories that should be watched with inotify,
3002 * as strings. The list might be empty and is in arbitrary order.
3004 * The list must be empty on entry. On success, the links are owned by the
3005 * caller and must be freed, but the data in each link remains owned by
3006 * the BusConfigParser and must not be freed: in GObject-Introspection
3007 * notation, it is (transfer container).
3010 bus_config_parser_get_watched_dirs (BusConfigParser *parser,
3011 DBusList **watched_dirs)
3015 _dbus_assert (*watched_dirs == NULL);
3017 for (link = _dbus_list_get_first_link (&parser->conf_dirs);
3019 link = _dbus_list_get_next_link (&parser->conf_dirs, link))
3021 if (!_dbus_list_append (watched_dirs, link->data))
3025 for (link = _dbus_list_get_first_link (&parser->service_dirs);
3027 link = _dbus_list_get_next_link (&parser->service_dirs, link))
3029 BusConfigServiceDir *dir = link->data;
3031 if (dir->flags & BUS_SERVICE_DIR_FLAGS_NO_WATCH)
3034 if (!_dbus_list_append (watched_dirs, dir->path))
3041 _dbus_list_clear (watched_dirs);
3045 #ifdef DBUS_ENABLE_EMBEDDED_TESTS
3056 do_check_own_rules (BusPolicy *policy)
3060 dbus_bool_t allowed;
3062 {"org.freedesktop", FALSE},
3063 {"org.freedesktop.ManySystem", FALSE},
3064 {"org.freedesktop.ManySystems", TRUE},
3065 {"org.freedesktop.ManySystems.foo", TRUE},
3066 {"org.freedesktop.ManySystems.foo.bar", TRUE},
3067 {"org.freedesktop.ManySystems2", FALSE},
3068 {"org.freedesktop.ManySystems2.foo", FALSE},
3069 {"org.freedesktop.ManySystems2.foo.bar", FALSE},
3074 while (checks[i].name)
3076 DBusString service_name;
3079 if (!_dbus_string_init (&service_name))
3080 _dbus_assert_not_reached ("couldn't init string");
3081 if (!_dbus_string_append (&service_name, checks[i].name))
3082 _dbus_assert_not_reached ("couldn't append string");
3084 ret = bus_policy_check_can_own (policy, &service_name);
3085 printf (" Check name %s: %s\n", checks[i].name,
3086 ret ? "allowed" : "not allowed");
3087 if (checks[i].allowed && !ret)
3089 _dbus_warn ("Cannot own %s", checks[i].name);
3092 if (!checks[i].allowed && ret)
3094 _dbus_warn ("Can own %s", checks[i].name);
3097 _dbus_string_free (&service_name);
3106 do_load (const DBusString *full_path,
3108 dbus_bool_t oom_possible,
3109 dbus_bool_t check_own_rules)
3111 BusConfigParser *parser;
3114 dbus_error_init (&error);
3116 parser = bus_config_load (full_path, TRUE, NULL, &error);
3119 _DBUS_ASSERT_ERROR_IS_SET (&error);
3122 dbus_error_has_name (&error, DBUS_ERROR_NO_MEMORY))
3124 _dbus_verbose ("Failed to load valid file due to OOM\n");
3125 dbus_error_free (&error);
3128 else if (validity == VALID)
3130 _dbus_warn ("Failed to load valid file but still had memory: %s",
3133 dbus_error_free (&error);
3138 dbus_error_free (&error);
3144 _DBUS_ASSERT_ERROR_IS_CLEAR (&error);
3146 if (check_own_rules && do_check_own_rules (parser->policy) == FALSE)
3151 bus_config_parser_unref (parser);
3153 if (validity == INVALID)
3155 _dbus_warn ("Accepted invalid file");
3165 const DBusString *full_path;
3167 dbus_bool_t check_own_rules;
3171 check_loader_oom_func (void *data)
3173 LoaderOomData *d = data;
3175 return do_load (d->full_path, d->validity, TRUE, d->check_own_rules);
3179 process_test_valid_subdir (const DBusString *test_base_dir,
3183 DBusString test_directory;
3184 DBusString filename;
3192 if (!_dbus_string_init (&test_directory))
3193 _dbus_assert_not_reached ("didn't allocate test_directory");
3195 _dbus_string_init_const (&filename, subdir);
3197 if (!_dbus_string_copy (test_base_dir, 0,
3198 &test_directory, 0))
3199 _dbus_assert_not_reached ("couldn't copy test_base_dir to test_directory");
3201 if (!_dbus_concat_dir_and_file (&test_directory, &filename))
3202 _dbus_assert_not_reached ("couldn't allocate full path");
3204 _dbus_string_free (&filename);
3205 if (!_dbus_string_init (&filename))
3206 _dbus_assert_not_reached ("didn't allocate filename string");
3208 dbus_error_init (&error);
3209 dir = _dbus_directory_open (&test_directory, &error);
3212 _dbus_warn ("Could not open %s: %s",
3213 _dbus_string_get_const_data (&test_directory),
3215 dbus_error_free (&error);
3219 if (validity == VALID)
3220 printf ("Testing valid files:\n");
3221 else if (validity == INVALID)
3222 printf ("Testing invalid files:\n");
3224 printf ("Testing unknown files:\n");
3227 while (_dbus_directory_get_next_file (dir, &filename, &error))
3229 DBusString full_path;
3232 if (!_dbus_string_init (&full_path))
3233 _dbus_assert_not_reached ("couldn't init string");
3235 if (!_dbus_string_copy (&test_directory, 0, &full_path, 0))
3236 _dbus_assert_not_reached ("couldn't copy dir to full_path");
3238 if (!_dbus_concat_dir_and_file (&full_path, &filename))
3239 _dbus_assert_not_reached ("couldn't concat file to dir");
3241 if (!_dbus_string_ends_with_c_str (&full_path, ".conf"))
3243 _dbus_verbose ("Skipping non-.conf file %s\n",
3244 _dbus_string_get_const_data (&filename));
3245 _dbus_string_free (&full_path);
3249 printf (" %s\n", _dbus_string_get_const_data (&filename));
3251 _dbus_verbose (" expecting %s\n",
3252 validity == VALID ? "valid" :
3253 (validity == INVALID ? "invalid" :
3254 (validity == UNKNOWN ? "unknown" : "???")));
3256 d.full_path = &full_path;
3257 d.validity = validity;
3258 d.check_own_rules = _dbus_string_ends_with_c_str (&full_path,
3259 "check-own-rules.conf");
3261 /* FIXME hackaround for an expat problem, see
3262 * https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=124747
3263 * http://freedesktop.org/pipermail/dbus/2004-May/001153.html
3265 /* if (!_dbus_test_oom_handling ("config-loader", check_loader_oom_func, &d)) */
3266 if (!check_loader_oom_func (&d))
3267 _dbus_assert_not_reached ("test failed");
3269 _dbus_string_free (&full_path);
3272 if (dbus_error_is_set (&error))
3274 _dbus_warn ("Could not get next file in %s: %s",
3275 _dbus_string_get_const_data (&test_directory),
3277 dbus_error_free (&error);
3286 _dbus_directory_close (dir);
3287 _dbus_string_free (&test_directory);
3288 _dbus_string_free (&filename);
3294 bools_equal (dbus_bool_t a,
3301 strings_equal_or_both_null (const char *a,
3304 if (a == NULL || b == NULL)
3307 return !strcmp (a, b);
3311 elements_equal (const Element *a,
3314 if (a->type != b->type)
3317 if (!bools_equal (a->had_content, b->had_content))
3323 case ELEMENT_INCLUDE:
3324 if (!bools_equal (a->d.include.ignore_missing,
3325 b->d.include.ignore_missing))
3329 case ELEMENT_POLICY:
3330 if (a->d.policy.type != b->d.policy.type)
3332 if (a->d.policy.gid_uid_or_at_console != b->d.policy.gid_uid_or_at_console)
3337 if (strcmp (a->d.limit.name, b->d.limit.name))
3339 if (a->d.limit.value != b->d.limit.value)
3344 case ELEMENT_BUSCONFIG:
3346 case ELEMENT_LISTEN:
3351 case ELEMENT_PIDFILE:
3352 case ELEMENT_SERVICEDIR:
3353 case ELEMENT_SERVICEHELPER:
3354 case ELEMENT_INCLUDEDIR:
3355 case ELEMENT_CONFIGTYPE:
3356 case ELEMENT_SELINUX:
3357 case ELEMENT_ASSOCIATE:
3358 case ELEMENT_STANDARD_SESSION_SERVICEDIRS:
3359 case ELEMENT_STANDARD_SYSTEM_SERVICEDIRS:
3360 case ELEMENT_KEEP_UMASK:
3361 case ELEMENT_SYSLOG:
3362 case ELEMENT_ALLOW_ANONYMOUS:
3363 case ELEMENT_APPARMOR:
3365 /* do nothing: nothing in the Element struct for these types */
3374 lists_of_elements_equal (DBusList *a,
3383 while (ia != NULL && ib != NULL)
3385 if (elements_equal (ia->data, ib->data))
3387 ia = _dbus_list_get_next_link (&a, ia);
3388 ib = _dbus_list_get_next_link (&b, ib);
3391 return ia == NULL && ib == NULL;
3395 lists_of_c_strings_equal (DBusList *a,
3404 while (ia != NULL && ib != NULL)
3406 if (strcmp (ia->data, ib->data))
3408 ia = _dbus_list_get_next_link (&a, ia);
3409 ib = _dbus_list_get_next_link (&b, ib);
3412 return ia == NULL && ib == NULL;
3416 lists_of_service_dirs_equal (DBusList *a,
3425 while (ia != NULL && ib != NULL)
3427 BusConfigServiceDir *da = ia->data;
3428 BusConfigServiceDir *db = ib->data;
3430 if (strcmp (da->path, db->path))
3433 if (da->flags != db->flags)
3436 ia = _dbus_list_get_next_link (&a, ia);
3437 ib = _dbus_list_get_next_link (&b, ib);
3440 return ia == NULL && ib == NULL;
3444 limits_equal (const BusLimits *a,
3448 (a->max_incoming_bytes == b->max_incoming_bytes
3449 || a->max_incoming_unix_fds == b->max_incoming_unix_fds
3450 || a->max_outgoing_bytes == b->max_outgoing_bytes
3451 || a->max_outgoing_unix_fds == b->max_outgoing_unix_fds
3452 || a->max_message_size == b->max_message_size
3453 || a->max_message_unix_fds == b->max_message_unix_fds
3454 || a->activation_timeout == b->activation_timeout
3455 || a->auth_timeout == b->auth_timeout
3456 || a->pending_fd_timeout == b->pending_fd_timeout
3457 || a->max_completed_connections == b->max_completed_connections
3458 || a->max_incomplete_connections == b->max_incomplete_connections
3459 || a->max_connections_per_user == b->max_connections_per_user
3460 || a->max_pending_activations == b->max_pending_activations
3461 || a->max_services_per_connection == b->max_services_per_connection
3462 || a->max_match_rules_per_connection == b->max_match_rules_per_connection
3463 || a->max_replies_per_connection == b->max_replies_per_connection
3464 || a->reply_timeout == b->reply_timeout);
3468 config_parsers_equal (const BusConfigParser *a,
3469 const BusConfigParser *b)
3471 if (!_dbus_string_equal (&a->basedir, &b->basedir))
3474 if (!lists_of_elements_equal (a->stack, b->stack))
3477 if (!strings_equal_or_both_null (a->user, b->user))
3480 if (!lists_of_c_strings_equal (a->listen_on, b->listen_on))
3483 if (!lists_of_c_strings_equal (a->mechanisms, b->mechanisms))
3486 if (!lists_of_service_dirs_equal (a->service_dirs, b->service_dirs))
3489 /* FIXME: compare policy */
3491 /* FIXME: compare service selinux ID table */
3493 if (! limits_equal (&a->limits, &b->limits))
3496 if (!strings_equal_or_both_null (a->pidfile, b->pidfile))
3499 if (! bools_equal (a->fork, b->fork))
3502 if (! bools_equal (a->keep_umask, b->keep_umask))
3505 if (! bools_equal (a->is_toplevel, b->is_toplevel))
3512 all_are_equiv (const DBusString *target_directory)
3514 DBusString filename;
3516 BusConfigParser *first_parser;
3517 BusConfigParser *parser;
3523 first_parser = NULL;
3527 if (!_dbus_string_init (&filename))
3528 _dbus_assert_not_reached ("didn't allocate filename string");
3530 dbus_error_init (&error);
3531 dir = _dbus_directory_open (target_directory, &error);
3534 _dbus_warn ("Could not open %s: %s",
3535 _dbus_string_get_const_data (target_directory),
3537 dbus_error_free (&error);
3541 printf ("Comparing equivalent files:\n");
3544 while (_dbus_directory_get_next_file (dir, &filename, &error))
3546 DBusString full_path;
3548 if (!_dbus_string_init (&full_path))
3549 _dbus_assert_not_reached ("couldn't init string");
3551 if (!_dbus_string_copy (target_directory, 0, &full_path, 0))
3552 _dbus_assert_not_reached ("couldn't copy dir to full_path");
3554 if (!_dbus_concat_dir_and_file (&full_path, &filename))
3555 _dbus_assert_not_reached ("couldn't concat file to dir");
3557 if (!_dbus_string_ends_with_c_str (&full_path, ".conf"))
3559 _dbus_verbose ("Skipping non-.conf file %s\n",
3560 _dbus_string_get_const_data (&filename));
3561 _dbus_string_free (&full_path);
3565 printf (" %s\n", _dbus_string_get_const_data (&filename));
3567 parser = bus_config_load (&full_path, TRUE, NULL, &error);
3571 _dbus_warn ("Could not load file %s: %s",
3572 _dbus_string_get_const_data (&full_path),
3574 _dbus_string_free (&full_path);
3575 dbus_error_free (&error);
3578 else if (first_parser == NULL)
3580 _dbus_string_free (&full_path);
3581 first_parser = parser;
3585 _dbus_string_free (&full_path);
3586 equal = config_parsers_equal (first_parser, parser);
3587 bus_config_parser_unref (parser);
3596 _dbus_string_free (&filename);
3598 bus_config_parser_unref (first_parser);
3600 _dbus_directory_close (dir);
3607 process_test_equiv_subdir (const DBusString *test_base_dir,
3610 DBusString test_directory;
3611 DBusString filename;
3620 if (!_dbus_string_init (&test_directory))
3621 _dbus_assert_not_reached ("didn't allocate test_directory");
3623 _dbus_string_init_const (&filename, subdir);
3625 if (!_dbus_string_copy (test_base_dir, 0,
3626 &test_directory, 0))
3627 _dbus_assert_not_reached ("couldn't copy test_base_dir to test_directory");
3629 if (!_dbus_concat_dir_and_file (&test_directory, &filename))
3630 _dbus_assert_not_reached ("couldn't allocate full path");
3632 _dbus_string_free (&filename);
3633 if (!_dbus_string_init (&filename))
3634 _dbus_assert_not_reached ("didn't allocate filename string");
3636 dbus_error_init (&error);
3637 dir = _dbus_directory_open (&test_directory, &error);
3640 _dbus_warn ("Could not open %s: %s",
3641 _dbus_string_get_const_data (&test_directory),
3643 dbus_error_free (&error);
3647 while (_dbus_directory_get_next_file (dir, &filename, &error))
3649 DBusString full_path;
3651 /* Skip CVS's magic directories! */
3652 if (_dbus_string_equal_c_str (&filename, "CVS"))
3655 if (!_dbus_string_init (&full_path))
3656 _dbus_assert_not_reached ("couldn't init string");
3658 if (!_dbus_string_copy (&test_directory, 0, &full_path, 0))
3659 _dbus_assert_not_reached ("couldn't copy dir to full_path");
3661 if (!_dbus_concat_dir_and_file (&full_path, &filename))
3662 _dbus_assert_not_reached ("couldn't concat file to dir");
3664 equal = all_are_equiv (&full_path);
3665 _dbus_string_free (&full_path);
3674 _dbus_string_free (&test_directory);
3675 _dbus_string_free (&filename);
3677 _dbus_directory_close (dir);
3683 static const char *test_session_service_dir_matches[] =
3685 /* will be filled in test_default_session_servicedirs() */
3687 NULL, /* install root-based */
3688 NULL, /* CommonProgramFiles-based */
3690 NULL, /* XDG_RUNTIME_DIR-based */
3691 NULL, /* XDG_DATA_HOME-based */
3692 NULL, /* XDG_DATA_DIRS-based */
3693 NULL, /* XDG_DATA_DIRS-based */
3694 DBUS_DATADIR "/dbus-1/services",
3700 test_default_session_servicedirs (const DBusString *test_base_dir)
3702 BusConfigParser *parser = NULL;
3703 DBusError error = DBUS_ERROR_INIT;
3705 DBusList *watched_dirs = NULL;
3708 DBusString full_path;
3710 DBusString install_root_based;
3711 DBusString runtime_dir_based;
3712 DBusString data_home_based;
3713 DBusString data_dirs_based;
3714 DBusString data_dirs_based2;
3716 dbus_bool_t ret = FALSE;
3718 const char *common_progs;
3720 const char *dbus_test_builddir;
3721 const char *xdg_data_home;
3722 const char *xdg_runtime_dir;
3725 /* On each platform we don't actually use all of these, but it's easier to
3726 * handle the deallocation if we always allocate them, whether needed or
3728 if (!_dbus_string_init (&full_path) ||
3729 !_dbus_string_init (&progs) ||
3730 !_dbus_string_init (&install_root_based) ||
3731 !_dbus_string_init (&runtime_dir_based) ||
3732 !_dbus_string_init (&data_home_based) ||
3733 !_dbus_string_init (&data_dirs_based) ||
3734 !_dbus_string_init (&data_dirs_based2))
3735 _dbus_assert_not_reached ("OOM allocating strings");
3737 if (!_dbus_string_copy (test_base_dir, 0,
3739 _dbus_assert_not_reached ("couldn't copy test_base_dir to full_path");
3741 _dbus_string_init_const (&tmp, "valid-config-files");
3743 if (!_dbus_concat_dir_and_file (&full_path, &tmp))
3744 _dbus_assert_not_reached ("couldn't allocate full path");
3746 _dbus_string_init_const (&tmp, "standard-session-dirs.conf");
3748 if (!_dbus_concat_dir_and_file (&full_path, &tmp))
3749 _dbus_assert_not_reached ("couldn't allocate full path");
3752 if (!_dbus_string_append (&install_root_based, DBUS_DATADIR) ||
3753 !_dbus_string_append (&install_root_based, "/dbus-1/services") ||
3754 !_dbus_replace_install_prefix (&install_root_based))
3757 _dbus_assert (_dbus_path_is_absolute (&install_root_based));
3759 test_session_service_dir_matches[0] = _dbus_string_get_const_data (
3760 &install_root_based);
3762 common_progs = _dbus_getenv ("CommonProgramFiles");
3766 if (!_dbus_string_append (&progs, common_progs))
3769 if (!_dbus_string_append (&progs, "/dbus-1/services"))
3772 test_session_service_dir_matches[1] = _dbus_string_get_const_data(&progs);
3775 dbus_test_builddir = _dbus_getenv ("DBUS_TEST_BUILDDIR");
3776 xdg_data_home = _dbus_getenv ("XDG_DATA_HOME");
3777 xdg_runtime_dir = _dbus_getenv ("XDG_RUNTIME_DIR");
3779 if (dbus_test_builddir == NULL || xdg_data_home == NULL ||
3780 xdg_runtime_dir == NULL)
3782 printf ("Not testing default session service directories because a "
3783 "build-time testing environment variable is not set: "
3784 "see AM_TESTS_ENVIRONMENT in tests/Makefile.am\n");
3789 if (!_dbus_string_append (&data_dirs_based, dbus_test_builddir) ||
3790 !_dbus_string_append (&data_dirs_based, "/XDG_DATA_DIRS/dbus-1/services") ||
3791 !_dbus_string_append (&data_dirs_based2, dbus_test_builddir) ||
3792 !_dbus_string_append (&data_dirs_based2, "/XDG_DATA_DIRS2/dbus-1/services") ||
3793 !_dbus_string_append (&runtime_dir_based, xdg_runtime_dir) ||
3794 !_dbus_string_append (&data_home_based, xdg_data_home) ||
3795 !_dbus_string_append (&data_home_based, "/dbus-1/services"))
3796 _dbus_assert_not_reached ("out of memory");
3798 if (!_dbus_ensure_directory (&runtime_dir_based, NULL))
3799 _dbus_assert_not_reached ("Unable to create fake XDG_RUNTIME_DIR");
3801 if (!_dbus_string_append (&runtime_dir_based, "/dbus-1/services"))
3802 _dbus_assert_not_reached ("out of memory");
3804 /* Sanity check: the Makefile sets this up. We assume that if this is
3805 * right, the XDG_DATA_DIRS will be too. */
3806 if (!_dbus_string_starts_with_c_str (&data_home_based, dbus_test_builddir))
3807 _dbus_assert_not_reached ("$XDG_DATA_HOME should start with $DBUS_TEST_BUILDDIR");
3809 if (!_dbus_string_starts_with_c_str (&runtime_dir_based, dbus_test_builddir))
3810 _dbus_assert_not_reached ("$XDG_RUNTIME_DIR should start with $DBUS_TEST_BUILDDIR");
3812 test_session_service_dir_matches[0] = _dbus_string_get_const_data (
3813 &runtime_dir_based);
3814 test_session_service_dir_matches[1] = _dbus_string_get_const_data (
3816 test_session_service_dir_matches[2] = _dbus_string_get_const_data (
3818 test_session_service_dir_matches[3] = _dbus_string_get_const_data (
3822 parser = bus_config_load (&full_path, TRUE, NULL, &error);
3825 _dbus_assert_not_reached (error.message);
3827 dirs = bus_config_parser_get_service_dirs (parser);
3829 for (link = _dbus_list_get_first_link (dirs), i = 0;
3831 link = _dbus_list_get_next_link (dirs, link), i++)
3833 BusConfigServiceDir *dir = link->data;
3834 BusServiceDirFlags expected = BUS_SERVICE_DIR_FLAGS_NONE;
3836 printf (" test service dir: '%s'\n", dir->path);
3837 printf (" current standard service dir: '%s'\n", test_session_service_dir_matches[i]);
3838 if (test_session_service_dir_matches[i] == NULL)
3840 printf ("more directories parsed than in match set\n");
3844 if (strcmp (test_session_service_dir_matches[i], dir->path) != 0)
3846 printf ("'%s' directory does not match '%s' in the match set\n",
3847 dir->path, test_session_service_dir_matches[i]);
3852 /* On Unix we expect the first directory in the search path to be
3853 * in the XDG_RUNTIME_DIR, and we expect it to have special flags */
3855 expected = (BUS_SERVICE_DIR_FLAGS_NO_WATCH |
3856 BUS_SERVICE_DIR_FLAGS_STRICT_NAMING);
3859 if (dir->flags != expected)
3861 printf ("'%s' directory has flags 0x%x, should be 0x%x\n",
3862 dir->path, dir->flags, expected);
3867 if (test_session_service_dir_matches[i] != NULL)
3869 printf ("extra data %s in the match set was not matched\n",
3870 test_session_service_dir_matches[i]);
3874 if (!bus_config_parser_get_watched_dirs (parser, &watched_dirs))
3875 _dbus_assert_not_reached ("out of memory");
3878 /* We expect all directories to be watched (not that it matters on Windows,
3879 * because we don't know how) */
3882 /* We expect all directories except the first to be watched, because
3883 * the first one is transient */
3887 for (link = _dbus_list_get_first_link (&watched_dirs);
3889 link = _dbus_list_get_next_link (&watched_dirs, link), i++)
3891 printf (" watched service dir: '%s'\n", (const char *) link->data);
3892 printf (" current standard service dir: '%s'\n",
3893 test_session_service_dir_matches[i]);
3895 if (test_session_service_dir_matches[i] == NULL)
3897 printf ("more directories parsed than in match set\n");
3901 if (strcmp (test_session_service_dir_matches[i],
3902 (const char *) link->data) != 0)
3904 printf ("'%s' directory does not match '%s' in the match set\n",
3905 (const char *) link->data,
3906 test_session_service_dir_matches[i]);
3911 if (test_session_service_dir_matches[i] != NULL)
3913 printf ("extra data %s in the match set was not matched\n",
3914 test_session_service_dir_matches[i]);
3922 bus_config_parser_unref (parser);
3924 _dbus_list_clear (&watched_dirs);
3925 _dbus_string_free (&full_path);
3926 _dbus_string_free (&install_root_based);
3927 _dbus_string_free (&progs);
3928 _dbus_string_free (&runtime_dir_based);
3929 _dbus_string_free (&data_home_based);
3930 _dbus_string_free (&data_dirs_based);
3931 _dbus_string_free (&data_dirs_based2);
3936 static const char *test_system_service_dir_matches[] =
3938 "/usr/local/share/dbus-1/system-services",
3939 "/usr/share/dbus-1/system-services",
3940 DBUS_DATADIR"/dbus-1/system-services",
3941 "/lib/dbus-1/system-services",
3946 test_default_system_servicedirs (void)
3954 if (!_dbus_get_standard_system_servicedirs (&dirs))
3955 _dbus_assert_not_reached ("couldn't get stardard dirs");
3957 /* make sure we read and parse the env variable correctly */
3959 while ((link = _dbus_list_pop_first_link (&dirs)))
3961 printf (" test service dir: %s\n", (char *)link->data);
3962 if (test_system_service_dir_matches[i] == NULL)
3964 printf ("more directories parsed than in match set\n");
3965 dbus_free (link->data);
3966 _dbus_list_free_link (link);
3970 if (strcmp (test_system_service_dir_matches[i],
3971 (char *)link->data) != 0)
3973 printf ("%s directory does not match %s in the match set\n",
3975 test_system_service_dir_matches[i]);
3976 dbus_free (link->data);
3977 _dbus_list_free_link (link);
3983 dbus_free (link->data);
3984 _dbus_list_free_link (link);
3987 if (test_system_service_dir_matches[i] != NULL)
3989 printf ("extra data %s in the match set was not matched\n",
3990 test_system_service_dir_matches[i]);
4000 bus_config_parser_test (const DBusString *test_data_dir)
4002 if (test_data_dir == NULL ||
4003 _dbus_string_get_length (test_data_dir) == 0)
4005 printf ("No test data\n");
4009 if (!test_default_session_servicedirs (test_data_dir))
4013 printf("default system service dir skipped\n");
4015 if (!test_default_system_servicedirs())
4019 if (!process_test_valid_subdir (test_data_dir, "valid-config-files", VALID))
4023 if (!process_test_valid_subdir (test_data_dir, "valid-config-files-system", VALID))
4027 if (!process_test_valid_subdir (test_data_dir, "invalid-config-files", INVALID))
4030 if (!process_test_equiv_subdir (test_data_dir, "equiv-config-files"))
4036 #endif /* DBUS_ENABLE_EMBEDDED_TESTS */