1 /* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
2 /* config-parser.c XML-library-agnostic configuration file parser
4 * Copyright (C) 2003, 2004 Red Hat, Inc.
6 * Licensed under the Academic Free License version 2.1
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version.
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
25 #include "config-parser-common.h"
26 #include "config-parser.h"
32 #include <dbus/dbus-list.h>
33 #include <dbus/dbus-internals.h>
34 #include <dbus/dbus-misc.h>
35 #include <dbus/dbus-sysdeps.h>
40 /* we ignore policies for unknown groups/users */
55 unsigned int had_content : 1;
61 unsigned int ignore_missing : 1;
62 unsigned int if_selinux_enabled : 1;
63 unsigned int selinux_root_relative : 1;
69 unsigned long gid_uid_or_at_console;
83 * Parser for bus configuration file.
85 struct BusConfigParser
87 int refcount; /**< Reference count */
89 DBusString basedir; /**< Directory we resolve paths relative to */
91 DBusList *stack; /**< stack of Element */
93 char *user; /**< user to run as */
95 char *servicehelper; /**< location of the setuid helper */
97 char *bus_type; /**< Message bus type */
99 DBusList *listen_on; /**< List of addresses to listen to */
101 DBusList *mechanisms; /**< Auth mechanisms */
103 DBusList *service_dirs; /**< BusConfigServiceDirs to look for session services in */
105 DBusList *conf_dirs; /**< Directories to look for policy configuration in */
107 BusPolicy *policy; /**< Security policy */
109 BusLimits limits; /**< Limits */
111 char *pidfile; /**< PID file */
113 DBusList *included_files; /**< Included files stack */
115 DBusHashTable *service_context_table; /**< Map service names to SELinux contexts */
117 unsigned int fork : 1; /**< TRUE to fork into daemon mode */
119 unsigned int syslog : 1; /**< TRUE to enable syslog */
120 unsigned int keep_umask : 1; /**< TRUE to keep original umask when forking */
122 unsigned int is_toplevel : 1; /**< FALSE if we are a sub-config-file inside another one */
124 unsigned int allow_anonymous : 1; /**< TRUE to allow anonymous connections */
128 push_element (BusConfigParser *parser,
133 _dbus_assert (type != ELEMENT_NONE);
135 e = dbus_new0 (Element, 1);
139 if (!_dbus_list_append (&parser->stack, e))
151 element_free (Element *e)
153 if (e->type == ELEMENT_LIMIT)
154 dbus_free (e->d.limit.name);
160 pop_element (BusConfigParser *parser)
164 e = _dbus_list_pop_last (&parser->stack);
170 peek_element (BusConfigParser *parser)
174 e = _dbus_list_get_last (&parser->stack);
180 top_element_type (BusConfigParser *parser)
184 e = _dbus_list_get_last (&parser->stack);
193 merge_service_context_hash (DBusHashTable *dest,
203 _dbus_hash_iter_init (from, &iter);
204 while (_dbus_hash_iter_next (&iter))
206 const char *service = _dbus_hash_iter_get_string_key (&iter);
207 const char *context = _dbus_hash_iter_get_value (&iter);
209 service_copy = _dbus_strdup (service);
210 if (service_copy == NULL)
212 context_copy = _dbus_strdup (context);
213 if (context_copy == NULL)
216 if (!_dbus_hash_table_insert_string (dest, service_copy, context_copy))
227 dbus_free (service_copy);
230 dbus_free (context_copy);
236 * Create a new BusConfigServiceDir. Takes ownership of path if #TRUE is returned.
238 * @returns #FALSE on OOM
240 static BusConfigServiceDir *
241 bus_config_service_dir_new_take (char *path,
242 BusServiceDirFlags flags)
244 BusConfigServiceDir *self = dbus_new0 (BusConfigServiceDir, 1);
249 self->path = path; /* take ownership */
255 bus_config_service_dir_free (BusConfigServiceDir *self)
257 dbus_free (self->path);
261 static BusConfigServiceDir *
262 service_dirs_find_dir (DBusList **service_dirs,
267 _dbus_assert (dir != NULL);
269 for (link = *service_dirs; link; link = _dbus_list_get_next_link(service_dirs, link))
271 BusConfigServiceDir *link_dir = link->data;
273 if (strcmp (dir, link_dir->path) == 0)
281 service_dirs_append_link_unique_or_free (DBusList **service_dirs,
284 BusConfigServiceDir *dir = dir_link->data;
285 BusConfigServiceDir *already = service_dirs_find_dir (service_dirs,
290 _dbus_list_append_link (service_dirs, dir_link);
294 /* BusServiceDirFlags are chosen such that the compatible thing to do
295 * is to "and" the flags. For example, if a directory is explicitly
296 * added as a <servicedir> (which is watched with inotify) and is also
297 * the transient service directory (which should not be watched),
298 * the compatible thing to do is to watch it. */
299 already->flags &= dir->flags;
300 bus_config_service_dir_free (dir_link->data);
301 _dbus_list_free_link (dir_link);
306 * Consume links from dirs (a list of paths), converting them into links in
307 * service_dirs (a list of unique BusServiceDir).
309 * On success, return TRUE. dirs will be empty, and every original entry in
310 * dirs will have a corresponding service_dirs entry.
312 * On OOM, return FALSE. Each original entry of dirs has either been
313 * appended to service_dirs or left in dirs.
316 service_dirs_absorb_string_list (DBusList **service_dirs,
318 BusServiceDirFlags flags)
322 _dbus_assert (service_dirs != NULL);
323 _dbus_assert (dirs != NULL);
325 while ((link = _dbus_list_pop_first_link (dirs)))
327 char *path = link->data;
328 BusConfigServiceDir *dir = bus_config_service_dir_new_take (path, flags);
332 /* OOM - roll back (this does not need to allocate memory) */
333 _dbus_list_prepend_link (service_dirs, link);
337 /* Ownership of path has been taken by dir */
339 service_dirs_append_link_unique_or_free (service_dirs, link);
342 _dbus_assert (*dirs == NULL);
347 merge_included (BusConfigParser *parser,
348 BusConfigParser *included,
353 if (!bus_policy_merge (parser->policy,
360 if (!merge_service_context_hash (parser->service_context_table,
361 included->service_context_table))
367 if (included->user != NULL)
369 dbus_free (parser->user);
370 parser->user = included->user;
371 included->user = NULL;
374 if (included->bus_type != NULL)
376 dbus_free (parser->bus_type);
377 parser->bus_type = included->bus_type;
378 included->bus_type = NULL;
384 if (included->keep_umask)
385 parser->keep_umask = TRUE;
387 if (included->allow_anonymous)
388 parser->allow_anonymous = TRUE;
390 if (included->pidfile != NULL)
392 dbus_free (parser->pidfile);
393 parser->pidfile = included->pidfile;
394 included->pidfile = NULL;
397 if (included->servicehelper != NULL)
399 dbus_free (parser->servicehelper);
400 parser->servicehelper = included->servicehelper;
401 included->servicehelper = NULL;
404 while ((link = _dbus_list_pop_first_link (&included->listen_on)))
405 _dbus_list_append_link (&parser->listen_on, link);
407 while ((link = _dbus_list_pop_first_link (&included->mechanisms)))
408 _dbus_list_append_link (&parser->mechanisms, link);
410 while ((link = _dbus_list_pop_first_link (&included->service_dirs)))
411 service_dirs_append_link_unique_or_free (&parser->service_dirs, link);
413 while ((link = _dbus_list_pop_first_link (&included->conf_dirs)))
414 _dbus_list_append_link (&parser->conf_dirs, link);
420 seen_include (BusConfigParser *parser,
421 const DBusString *file)
425 iter = parser->included_files;
428 if (! strcmp (_dbus_string_get_const_data (file), iter->data))
431 iter = _dbus_list_get_next_link (&parser->included_files, iter);
438 bus_config_parser_new (const DBusString *basedir,
439 dbus_bool_t is_toplevel,
440 const BusConfigParser *parent)
442 BusConfigParser *parser;
444 parser = dbus_new0 (BusConfigParser, 1);
448 parser->is_toplevel = !!is_toplevel;
450 if (!_dbus_string_init (&parser->basedir))
456 if (((parser->policy = bus_policy_new ()) == NULL) ||
457 !_dbus_string_copy (basedir, 0, &parser->basedir, 0) ||
458 ((parser->service_context_table = _dbus_hash_table_new (DBUS_HASH_STRING,
460 dbus_free)) == NULL))
463 bus_policy_unref (parser->policy);
465 _dbus_string_free (&parser->basedir);
473 /* Initialize the parser's limits from the parent. */
474 parser->limits = parent->limits;
476 /* Use the parent's list of included_files to avoid
477 circular inclusions. */
478 parser->included_files = parent->included_files;
483 /* Make up some numbers! woot! */
484 parser->limits.max_incoming_bytes = _DBUS_ONE_MEGABYTE * 127;
485 parser->limits.max_outgoing_bytes = _DBUS_ONE_MEGABYTE * 127;
486 parser->limits.max_message_size = _DBUS_ONE_MEGABYTE * 32;
488 /* We set relatively conservative values here since due to the
489 way SCM_RIGHTS works we need to preallocate an array for the
490 maximum number of file descriptors we can receive. Picking a
491 high value here thus translates directly to more memory
493 parser->limits.max_incoming_unix_fds = DBUS_DEFAULT_MESSAGE_UNIX_FDS*4;
494 parser->limits.max_outgoing_unix_fds = DBUS_DEFAULT_MESSAGE_UNIX_FDS*4;
495 parser->limits.max_message_unix_fds = DBUS_DEFAULT_MESSAGE_UNIX_FDS;
497 /* Making this long means the user has to wait longer for an error
498 * message if something screws up, but making it too short means
499 * they might see a false failure.
501 parser->limits.activation_timeout = 25000; /* 25 seconds */
503 /* Making this long risks making a DOS attack easier, but too short
504 * and legitimate auth will fail. If interactive auth (ask user for
505 * password) is allowed, then potentially it has to be quite long.
507 parser->limits.auth_timeout = 30000; /* 30 seconds */
509 /* Do not allow a fd to stay forever in dbus-daemon
510 * https://bugs.freedesktop.org/show_bug.cgi?id=80559
512 parser->limits.pending_fd_timeout = 150000; /* 2.5 minutes */
514 parser->limits.max_incomplete_connections = 64;
515 parser->limits.max_connections_per_user = 256;
517 /* Note that max_completed_connections / max_connections_per_user
518 * is the number of users that would have to work together to
519 * DOS all the other users.
521 parser->limits.max_completed_connections = 2048;
523 parser->limits.max_pending_activations = 512;
524 parser->limits.max_services_per_connection = 512;
526 /* For this one, keep in mind that it isn't only the memory used
527 * by the match rules, but slowdown from linearly walking a big
528 * list of them. A client adding more than this is almost
529 * certainly a bad idea for that reason, and should change to a
530 * smaller number of wider-net match rules - getting every last
531 * message to the bus is probably better than having a thousand
534 parser->limits.max_match_rules_per_connection = 512;
536 parser->limits.reply_timeout = -1; /* never */
538 /* this is effectively a limit on message queue size for messages
539 * that require a reply
541 parser->limits.max_replies_per_connection = 128;
544 parser->refcount = 1;
550 bus_config_parser_ref (BusConfigParser *parser)
552 _dbus_assert (parser->refcount > 0);
554 parser->refcount += 1;
560 bus_config_parser_unref (BusConfigParser *parser)
562 _dbus_assert (parser->refcount > 0);
564 parser->refcount -= 1;
566 if (parser->refcount == 0)
568 while (parser->stack != NULL)
569 pop_element (parser);
571 dbus_free (parser->user);
572 dbus_free (parser->servicehelper);
573 dbus_free (parser->bus_type);
574 dbus_free (parser->pidfile);
576 _dbus_list_foreach (&parser->listen_on,
577 (DBusForeachFunction) dbus_free,
580 _dbus_list_clear (&parser->listen_on);
582 _dbus_list_foreach (&parser->service_dirs,
583 (DBusForeachFunction) bus_config_service_dir_free,
586 _dbus_list_clear (&parser->service_dirs);
588 _dbus_list_foreach (&parser->conf_dirs,
589 (DBusForeachFunction) dbus_free,
592 _dbus_list_clear (&parser->conf_dirs);
594 _dbus_list_foreach (&parser->mechanisms,
595 (DBusForeachFunction) dbus_free,
598 _dbus_list_clear (&parser->mechanisms);
600 _dbus_string_free (&parser->basedir);
603 bus_policy_unref (parser->policy);
605 if (parser->service_context_table)
606 _dbus_hash_table_unref (parser->service_context_table);
613 bus_config_parser_check_doctype (BusConfigParser *parser,
617 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
619 if (strcmp (doctype, "busconfig") != 0)
621 dbus_set_error (error,
623 "Configuration file has the wrong document type %s",
638 locate_attributes (BusConfigParser *parser,
639 const char *element_name,
640 const char **attribute_names,
641 const char **attribute_values,
643 const char *first_attribute_name,
644 const char **first_attribute_retloc,
652 LocateAttr attrs[MAX_ATTRS];
656 _dbus_assert (first_attribute_name != NULL);
657 _dbus_assert (first_attribute_retloc != NULL);
662 attrs[0].name = first_attribute_name;
663 attrs[0].retloc = first_attribute_retloc;
664 *first_attribute_retloc = NULL;
666 va_start (args, first_attribute_retloc);
668 name = va_arg (args, const char*);
669 retloc = va_arg (args, const char**);
673 _dbus_assert (retloc != NULL);
674 _dbus_assert (n_attrs < MAX_ATTRS);
676 attrs[n_attrs].name = name;
677 attrs[n_attrs].retloc = retloc;
681 name = va_arg (args, const char*);
682 retloc = va_arg (args, const char**);
688 while (attribute_names[i])
697 if (strcmp (attrs[j].name, attribute_names[i]) == 0)
699 retloc = attrs[j].retloc;
703 dbus_set_error (error, DBUS_ERROR_FAILED,
704 "Attribute \"%s\" repeated twice on the same <%s> element",
705 attrs[j].name, element_name);
710 *retloc = attribute_values[i];
719 dbus_set_error (error, DBUS_ERROR_FAILED,
720 "Attribute \"%s\" is invalid on <%s> element in this context",
721 attribute_names[i], element_name);
734 check_no_attributes (BusConfigParser *parser,
735 const char *element_name,
736 const char **attribute_names,
737 const char **attribute_values,
740 if (attribute_names[0] != NULL)
742 dbus_set_error (error, DBUS_ERROR_FAILED,
743 "Attribute \"%s\" is invalid on <%s> element in this context",
744 attribute_names[0], element_name);
752 start_busconfig_child (BusConfigParser *parser,
753 const char *element_name,
754 const char **attribute_names,
755 const char **attribute_values,
758 ElementType element_type;
760 element_type = bus_config_parser_element_name_to_type (element_name);
762 if (element_type == ELEMENT_USER)
764 if (!check_no_attributes (parser, "user", attribute_names, attribute_values, error))
767 if (push_element (parser, ELEMENT_USER) == NULL)
775 else if (element_type == ELEMENT_CONFIGTYPE)
777 if (!check_no_attributes (parser, "type", attribute_names, attribute_values, error))
780 if (push_element (parser, ELEMENT_CONFIGTYPE) == NULL)
788 else if (element_type == ELEMENT_FORK)
790 if (!check_no_attributes (parser, "fork", attribute_names, attribute_values, error))
793 if (push_element (parser, ELEMENT_FORK) == NULL)
803 else if (element_type == ELEMENT_SYSLOG)
805 if (!check_no_attributes (parser, "syslog", attribute_names, attribute_values, error))
808 if (push_element (parser, ELEMENT_SYSLOG) == NULL)
814 parser->syslog = TRUE;
818 else if (element_type == ELEMENT_KEEP_UMASK)
820 if (!check_no_attributes (parser, "keep_umask", attribute_names, attribute_values, error))
823 if (push_element (parser, ELEMENT_KEEP_UMASK) == NULL)
829 parser->keep_umask = TRUE;
833 else if (element_type == ELEMENT_PIDFILE)
835 if (!check_no_attributes (parser, "pidfile", attribute_names, attribute_values, error))
838 if (push_element (parser, ELEMENT_PIDFILE) == NULL)
846 else if (element_type == ELEMENT_LISTEN)
848 if (!check_no_attributes (parser, "listen", attribute_names, attribute_values, error))
851 if (push_element (parser, ELEMENT_LISTEN) == NULL)
859 else if (element_type == ELEMENT_AUTH)
861 if (!check_no_attributes (parser, "auth", attribute_names, attribute_values, error))
864 if (push_element (parser, ELEMENT_AUTH) == NULL)
872 else if (element_type == ELEMENT_SERVICEHELPER)
874 if (!check_no_attributes (parser, "servicehelper", attribute_names, attribute_values, error))
877 if (push_element (parser, ELEMENT_SERVICEHELPER) == NULL)
885 else if (element_type == ELEMENT_INCLUDEDIR)
887 if (!check_no_attributes (parser, "includedir", attribute_names, attribute_values, error))
890 if (push_element (parser, ELEMENT_INCLUDEDIR) == NULL)
898 else if (element_type == ELEMENT_STANDARD_SESSION_SERVICEDIRS)
903 if (!check_no_attributes (parser, "standard_session_servicedirs", attribute_names, attribute_values, error))
906 if (push_element (parser, ELEMENT_STANDARD_SESSION_SERVICEDIRS) == NULL)
912 if (!_dbus_get_standard_session_servicedirs (&dirs))
918 /* We have traditionally watched the standard session service
919 * directories with inotify, and allowed service files whose names do not
920 * match the bus name */
921 if (!service_dirs_absorb_string_list (&parser->service_dirs, &dirs,
922 BUS_SERVICE_DIR_FLAGS_NONE))
925 _dbus_list_foreach (&dirs, (DBusForeachFunction) dbus_free,
927 _dbus_list_clear (&dirs);
933 else if (element_type == ELEMENT_STANDARD_SYSTEM_SERVICEDIRS)
938 if (!check_no_attributes (parser, "standard_system_servicedirs", attribute_names, attribute_values, error))
941 if (push_element (parser, ELEMENT_STANDARD_SYSTEM_SERVICEDIRS) == NULL)
947 if (!_dbus_get_standard_system_servicedirs (&dirs))
953 /* We have traditionally watched the standard system service
954 * directories with inotify, and allowed service files whose names do not
955 * match the bus name (the servicehelper won't successfully activate
956 * them, but we do still parse them) */
957 if (!service_dirs_absorb_string_list (&parser->service_dirs, &dirs,
958 BUS_SERVICE_DIR_FLAGS_NONE))
961 _dbus_list_foreach (&dirs, (DBusForeachFunction) dbus_free,
963 _dbus_list_clear (&dirs);
969 else if (element_type == ELEMENT_ALLOW_ANONYMOUS)
971 if (!check_no_attributes (parser, "allow_anonymous", attribute_names, attribute_values, error))
974 if (push_element (parser, ELEMENT_ALLOW_ANONYMOUS) == NULL)
980 parser->allow_anonymous = TRUE;
983 else if (element_type == ELEMENT_SERVICEDIR)
985 if (!check_no_attributes (parser, "servicedir", attribute_names, attribute_values, error))
988 if (push_element (parser, ELEMENT_SERVICEDIR) == NULL)
996 else if (element_type == ELEMENT_INCLUDE)
999 const char *if_selinux_enabled;
1000 const char *ignore_missing;
1001 const char *selinux_root_relative;
1003 if ((e = push_element (parser, ELEMENT_INCLUDE)) == NULL)
1005 BUS_SET_OOM (error);
1009 e->d.include.ignore_missing = FALSE;
1010 e->d.include.if_selinux_enabled = FALSE;
1011 e->d.include.selinux_root_relative = FALSE;
1013 if (!locate_attributes (parser, "include",
1017 "ignore_missing", &ignore_missing,
1018 "if_selinux_enabled", &if_selinux_enabled,
1019 "selinux_root_relative", &selinux_root_relative,
1023 if (ignore_missing != NULL)
1025 if (strcmp (ignore_missing, "yes") == 0)
1026 e->d.include.ignore_missing = TRUE;
1027 else if (strcmp (ignore_missing, "no") == 0)
1028 e->d.include.ignore_missing = FALSE;
1031 dbus_set_error (error, DBUS_ERROR_FAILED,
1032 "ignore_missing attribute must have value \"yes\" or \"no\"");
1037 if (if_selinux_enabled != NULL)
1039 if (strcmp (if_selinux_enabled, "yes") == 0)
1040 e->d.include.if_selinux_enabled = TRUE;
1041 else if (strcmp (if_selinux_enabled, "no") == 0)
1042 e->d.include.if_selinux_enabled = FALSE;
1045 dbus_set_error (error, DBUS_ERROR_FAILED,
1046 "if_selinux_enabled attribute must have value"
1047 " \"yes\" or \"no\"");
1052 if (selinux_root_relative != NULL)
1054 if (strcmp (selinux_root_relative, "yes") == 0)
1055 e->d.include.selinux_root_relative = TRUE;
1056 else if (strcmp (selinux_root_relative, "no") == 0)
1057 e->d.include.selinux_root_relative = FALSE;
1060 dbus_set_error (error, DBUS_ERROR_FAILED,
1061 "selinux_root_relative attribute must have value"
1062 " \"yes\" or \"no\"");
1069 else if (element_type == ELEMENT_POLICY)
1072 const char *context;
1075 const char *at_console;
1077 if ((e = push_element (parser, ELEMENT_POLICY)) == NULL)
1079 BUS_SET_OOM (error);
1083 e->d.policy.type = POLICY_IGNORED;
1085 if (!locate_attributes (parser, "policy",
1089 "context", &context,
1092 "at_console", &at_console,
1096 if (((context && user) ||
1097 (context && group) ||
1098 (context && at_console)) ||
1100 (user && at_console)) ||
1101 (group && at_console) ||
1102 !(context || user || group || at_console))
1104 dbus_set_error (error, DBUS_ERROR_FAILED,
1105 "<policy> element must have exactly one of (context|user|group|at_console) attributes");
1109 if (context != NULL)
1111 if (strcmp (context, "default") == 0)
1113 e->d.policy.type = POLICY_DEFAULT;
1115 else if (strcmp (context, "mandatory") == 0)
1117 e->d.policy.type = POLICY_MANDATORY;
1121 dbus_set_error (error, DBUS_ERROR_FAILED,
1122 "context attribute on <policy> must have the value \"default\" or \"mandatory\", not \"%s\"",
1127 else if (user != NULL)
1129 DBusString username;
1130 _dbus_string_init_const (&username, user);
1132 if (_dbus_parse_unix_user_from_config (&username,
1133 &e->d.policy.gid_uid_or_at_console))
1134 e->d.policy.type = POLICY_USER;
1136 _dbus_warn ("Unknown username \"%s\" in message bus configuration file",
1139 else if (group != NULL)
1141 DBusString group_name;
1142 _dbus_string_init_const (&group_name, group);
1144 if (_dbus_parse_unix_group_from_config (&group_name,
1145 &e->d.policy.gid_uid_or_at_console))
1146 e->d.policy.type = POLICY_GROUP;
1148 _dbus_warn ("Unknown group \"%s\" in message bus configuration file",
1151 else if (at_console != NULL)
1154 t = (strcmp (at_console, "true") == 0);
1155 if (t || strcmp (at_console, "false") == 0)
1157 e->d.policy.gid_uid_or_at_console = t;
1158 e->d.policy.type = POLICY_CONSOLE;
1162 dbus_set_error (error, DBUS_ERROR_FAILED,
1163 "Unknown value \"%s\" for at_console in message bus configuration file",
1171 _dbus_assert_not_reached ("all <policy> attributes null and we didn't set error");
1176 else if (element_type == ELEMENT_LIMIT)
1181 if ((e = push_element (parser, ELEMENT_LIMIT)) == NULL)
1183 BUS_SET_OOM (error);
1187 if (!locate_attributes (parser, "limit",
1197 dbus_set_error (error, DBUS_ERROR_FAILED,
1198 "<limit> element must have a \"name\" attribute");
1202 e->d.limit.name = _dbus_strdup (name);
1203 if (e->d.limit.name == NULL)
1205 BUS_SET_OOM (error);
1211 else if (element_type == ELEMENT_SELINUX)
1213 if (!check_no_attributes (parser, "selinux", attribute_names, attribute_values, error))
1216 if (push_element (parser, ELEMENT_SELINUX) == NULL)
1218 BUS_SET_OOM (error);
1224 else if (element_type == ELEMENT_APPARMOR)
1229 if ((e = push_element (parser, ELEMENT_APPARMOR)) == NULL)
1231 BUS_SET_OOM (error);
1235 if (!locate_attributes (parser, "apparmor",
1243 return bus_apparmor_set_mode_from_config (mode, error);
1247 dbus_set_error (error, DBUS_ERROR_FAILED,
1248 "Element <%s> not allowed inside <%s> in configuration file",
1249 element_name, "busconfig");
1255 append_rule_from_element (BusConfigParser *parser,
1256 const char *element_name,
1257 const char **attribute_names,
1258 const char **attribute_values,
1263 const char *send_interface;
1264 const char *send_member;
1265 const char *send_error;
1266 const char *send_destination;
1267 const char *send_path;
1268 const char *send_type;
1269 const char *receive_interface;
1270 const char *receive_member;
1271 const char *receive_error;
1272 const char *receive_sender;
1273 const char *receive_path;
1274 const char *receive_type;
1275 const char *eavesdrop;
1276 const char *send_requested_reply;
1277 const char *receive_requested_reply;
1279 const char *own_prefix;
1283 BusPolicyRule *rule;
1285 if (!locate_attributes (parser, element_name,
1289 "send_interface", &send_interface,
1290 "send_member", &send_member,
1291 "send_error", &send_error,
1292 "send_destination", &send_destination,
1293 "send_path", &send_path,
1294 "send_type", &send_type,
1295 "receive_interface", &receive_interface,
1296 "receive_member", &receive_member,
1297 "receive_error", &receive_error,
1298 "receive_sender", &receive_sender,
1299 "receive_path", &receive_path,
1300 "receive_type", &receive_type,
1301 "eavesdrop", &eavesdrop,
1302 "send_requested_reply", &send_requested_reply,
1303 "receive_requested_reply", &receive_requested_reply,
1305 "own_prefix", &own_prefix,
1312 if (!(send_interface || send_member || send_error || send_destination ||
1313 send_type || send_path ||
1314 receive_interface || receive_member || receive_error || receive_sender ||
1315 receive_type || receive_path || eavesdrop ||
1316 send_requested_reply || receive_requested_reply ||
1317 own || own_prefix || user || group))
1319 dbus_set_error (error, DBUS_ERROR_FAILED,
1320 "Element <%s> must have one or more attributes",
1325 if ((send_member && (send_interface == NULL && send_path == NULL)) ||
1326 (receive_member && (receive_interface == NULL && receive_path == NULL)))
1328 dbus_set_error (error, DBUS_ERROR_FAILED,
1329 "On element <%s>, if you specify a member you must specify an interface or a path. Keep in mind that not all messages have an interface field.",
1334 /* Allowed combinations of elements are:
1336 * base, must be all send or all receive:
1339 * interface + member
1342 * base send_ can combine with send_destination, send_path, send_type, send_requested_reply
1343 * base receive_ with receive_sender, receive_path, receive_type, receive_requested_reply, eavesdrop
1345 * user, group, own, own_prefix must occur alone
1347 * Pretty sure the below stuff is broken, FIXME think about it more.
1350 if ((send_interface && (send_error ||
1351 receive_interface ||
1355 receive_requested_reply ||
1356 own || own_prefix ||
1360 (send_member && (send_error ||
1361 receive_interface ||
1365 receive_requested_reply ||
1366 own || own_prefix ||
1370 (send_error && (receive_interface ||
1374 receive_requested_reply ||
1375 own || own_prefix ||
1379 (send_destination && (receive_interface ||
1383 receive_requested_reply ||
1384 own || own_prefix ||
1388 (send_type && (receive_interface ||
1392 receive_requested_reply ||
1393 own || own_prefix ||
1397 (send_path && (receive_interface ||
1401 receive_requested_reply ||
1402 own || own_prefix ||
1406 (send_requested_reply && (receive_interface ||
1410 receive_requested_reply ||
1411 own || own_prefix ||
1415 (receive_interface && (receive_error ||
1416 own || own_prefix ||
1420 (receive_member && (receive_error ||
1421 own || own_prefix ||
1425 (receive_error && (own || own_prefix ||
1429 (eavesdrop && (own || own_prefix ||
1433 (receive_requested_reply && (own || own_prefix ||
1437 (own && (own_prefix || user || group)) ||
1439 (own_prefix && (own || user || group)) ||
1443 dbus_set_error (error, DBUS_ERROR_FAILED,
1444 "Invalid combination of attributes on element <%s>",
1451 /* In BusPolicyRule, NULL represents wildcard.
1452 * In the config file, '*' represents it.
1454 #define IS_WILDCARD(str) ((str) && ((str)[0]) == '*' && ((str)[1]) == '\0')
1456 if (send_interface || send_member || send_error || send_destination ||
1457 send_path || send_type || send_requested_reply)
1461 if (IS_WILDCARD (send_interface))
1462 send_interface = NULL;
1463 if (IS_WILDCARD (send_member))
1465 if (IS_WILDCARD (send_error))
1467 if (IS_WILDCARD (send_destination))
1468 send_destination = NULL;
1469 if (IS_WILDCARD (send_path))
1471 if (IS_WILDCARD (send_type))
1474 message_type = DBUS_MESSAGE_TYPE_INVALID;
1475 if (send_type != NULL)
1477 message_type = dbus_message_type_from_string (send_type);
1478 if (message_type == DBUS_MESSAGE_TYPE_INVALID)
1480 dbus_set_error (error, DBUS_ERROR_FAILED,
1481 "Bad message type \"%s\"",
1488 !(strcmp (eavesdrop, "true") == 0 ||
1489 strcmp (eavesdrop, "false") == 0))
1491 dbus_set_error (error, DBUS_ERROR_FAILED,
1492 "Bad value \"%s\" for %s attribute, must be true or false",
1493 "eavesdrop", eavesdrop);
1497 if (send_requested_reply &&
1498 !(strcmp (send_requested_reply, "true") == 0 ||
1499 strcmp (send_requested_reply, "false") == 0))
1501 dbus_set_error (error, DBUS_ERROR_FAILED,
1502 "Bad value \"%s\" for %s attribute, must be true or false",
1503 "send_requested_reply", send_requested_reply);
1507 rule = bus_policy_rule_new (BUS_POLICY_RULE_SEND, allow);
1512 rule->d.send.eavesdrop = (strcmp (eavesdrop, "true") == 0);
1515 rule->d.send.log = (strcmp (log, "true") == 0);
1517 if (send_requested_reply)
1518 rule->d.send.requested_reply = (strcmp (send_requested_reply, "true") == 0);
1520 rule->d.send.message_type = message_type;
1521 rule->d.send.path = _dbus_strdup (send_path);
1522 rule->d.send.interface = _dbus_strdup (send_interface);
1523 rule->d.send.member = _dbus_strdup (send_member);
1524 rule->d.send.error = _dbus_strdup (send_error);
1525 rule->d.send.destination = _dbus_strdup (send_destination);
1526 if (send_path && rule->d.send.path == NULL)
1528 if (send_interface && rule->d.send.interface == NULL)
1530 if (send_member && rule->d.send.member == NULL)
1532 if (send_error && rule->d.send.error == NULL)
1534 if (send_destination && rule->d.send.destination == NULL)
1537 else if (receive_interface || receive_member || receive_error || receive_sender ||
1538 receive_path || receive_type || eavesdrop || receive_requested_reply)
1542 if (IS_WILDCARD (receive_interface))
1543 receive_interface = NULL;
1544 if (IS_WILDCARD (receive_member))
1545 receive_member = NULL;
1546 if (IS_WILDCARD (receive_error))
1547 receive_error = NULL;
1548 if (IS_WILDCARD (receive_sender))
1549 receive_sender = NULL;
1550 if (IS_WILDCARD (receive_path))
1551 receive_path = NULL;
1552 if (IS_WILDCARD (receive_type))
1553 receive_type = NULL;
1555 message_type = DBUS_MESSAGE_TYPE_INVALID;
1556 if (receive_type != NULL)
1558 message_type = dbus_message_type_from_string (receive_type);
1559 if (message_type == DBUS_MESSAGE_TYPE_INVALID)
1561 dbus_set_error (error, DBUS_ERROR_FAILED,
1562 "Bad message type \"%s\"",
1570 !(strcmp (eavesdrop, "true") == 0 ||
1571 strcmp (eavesdrop, "false") == 0))
1573 dbus_set_error (error, DBUS_ERROR_FAILED,
1574 "Bad value \"%s\" for %s attribute, must be true or false",
1575 "eavesdrop", eavesdrop);
1579 if (receive_requested_reply &&
1580 !(strcmp (receive_requested_reply, "true") == 0 ||
1581 strcmp (receive_requested_reply, "false") == 0))
1583 dbus_set_error (error, DBUS_ERROR_FAILED,
1584 "Bad value \"%s\" for %s attribute, must be true or false",
1585 "receive_requested_reply", receive_requested_reply);
1589 rule = bus_policy_rule_new (BUS_POLICY_RULE_RECEIVE, allow);
1594 rule->d.receive.eavesdrop = (strcmp (eavesdrop, "true") == 0);
1596 if (receive_requested_reply)
1597 rule->d.receive.requested_reply = (strcmp (receive_requested_reply, "true") == 0);
1599 rule->d.receive.message_type = message_type;
1600 rule->d.receive.path = _dbus_strdup (receive_path);
1601 rule->d.receive.interface = _dbus_strdup (receive_interface);
1602 rule->d.receive.member = _dbus_strdup (receive_member);
1603 rule->d.receive.error = _dbus_strdup (receive_error);
1604 rule->d.receive.origin = _dbus_strdup (receive_sender);
1606 if (receive_path && rule->d.receive.path == NULL)
1608 if (receive_interface && rule->d.receive.interface == NULL)
1610 if (receive_member && rule->d.receive.member == NULL)
1612 if (receive_error && rule->d.receive.error == NULL)
1614 if (receive_sender && rule->d.receive.origin == NULL)
1617 else if (own || own_prefix)
1619 rule = bus_policy_rule_new (BUS_POLICY_RULE_OWN, allow);
1625 if (IS_WILDCARD (own))
1628 rule->d.own.prefix = 0;
1629 rule->d.own.service_name = _dbus_strdup (own);
1630 if (own && rule->d.own.service_name == NULL)
1635 rule->d.own.prefix = 1;
1636 rule->d.own.service_name = _dbus_strdup (own_prefix);
1637 if (rule->d.own.service_name == NULL)
1643 if (IS_WILDCARD (user))
1645 rule = bus_policy_rule_new (BUS_POLICY_RULE_USER, allow);
1649 rule->d.user.uid = DBUS_UID_UNSET;
1653 DBusString username;
1656 _dbus_string_init_const (&username, user);
1658 if (_dbus_parse_unix_user_from_config (&username, &uid))
1660 rule = bus_policy_rule_new (BUS_POLICY_RULE_USER, allow);
1664 rule->d.user.uid = uid;
1668 _dbus_warn ("Unknown username \"%s\" on element <%s>",
1669 user, element_name);
1675 if (IS_WILDCARD (group))
1677 rule = bus_policy_rule_new (BUS_POLICY_RULE_GROUP, allow);
1681 rule->d.group.gid = DBUS_GID_UNSET;
1685 DBusString groupname;
1688 _dbus_string_init_const (&groupname, group);
1690 if (_dbus_parse_unix_group_from_config (&groupname, &gid))
1692 rule = bus_policy_rule_new (BUS_POLICY_RULE_GROUP, allow);
1696 rule->d.group.gid = gid;
1700 _dbus_warn ("Unknown group \"%s\" on element <%s>",
1701 group, element_name);
1706 _dbus_assert_not_reached ("Did not handle some combination of attributes on <allow> or <deny>");
1712 pe = peek_element (parser);
1713 _dbus_assert (pe != NULL);
1714 _dbus_assert (pe->type == ELEMENT_POLICY);
1716 switch (pe->d.policy.type)
1718 case POLICY_IGNORED:
1719 /* drop the rule on the floor */
1722 case POLICY_DEFAULT:
1723 if (!bus_policy_append_default_rule (parser->policy, rule))
1726 case POLICY_MANDATORY:
1727 if (!bus_policy_append_mandatory_rule (parser->policy, rule))
1731 if (!BUS_POLICY_RULE_IS_PER_CLIENT (rule))
1733 dbus_set_error (error, DBUS_ERROR_FAILED,
1734 "<%s> rule cannot be per-user because it has bus-global semantics",
1739 if (!bus_policy_append_user_rule (parser->policy, pe->d.policy.gid_uid_or_at_console,
1744 if (!BUS_POLICY_RULE_IS_PER_CLIENT (rule))
1746 dbus_set_error (error, DBUS_ERROR_FAILED,
1747 "<%s> rule cannot be per-group because it has bus-global semantics",
1752 if (!bus_policy_append_group_rule (parser->policy, pe->d.policy.gid_uid_or_at_console,
1758 case POLICY_CONSOLE:
1759 if (!bus_policy_append_console_rule (parser->policy, pe->d.policy.gid_uid_or_at_console,
1765 bus_policy_rule_unref (rule);
1772 BUS_SET_OOM (error);
1775 bus_policy_rule_unref (rule);
1780 start_policy_child (BusConfigParser *parser,
1781 const char *element_name,
1782 const char **attribute_names,
1783 const char **attribute_values,
1786 if (strcmp (element_name, "allow") == 0)
1788 if (!append_rule_from_element (parser, element_name,
1789 attribute_names, attribute_values,
1793 if (push_element (parser, ELEMENT_ALLOW) == NULL)
1795 BUS_SET_OOM (error);
1801 else if (strcmp (element_name, "deny") == 0)
1803 if (!append_rule_from_element (parser, element_name,
1804 attribute_names, attribute_values,
1808 if (push_element (parser, ELEMENT_DENY) == NULL)
1810 BUS_SET_OOM (error);
1818 dbus_set_error (error, DBUS_ERROR_FAILED,
1819 "Element <%s> not allowed inside <%s> in configuration file",
1820 element_name, "policy");
1826 start_selinux_child (BusConfigParser *parser,
1827 const char *element_name,
1828 const char **attribute_names,
1829 const char **attribute_values,
1836 context_copy = NULL;
1838 if (strcmp (element_name, "associate") == 0)
1841 const char *context;
1843 if (!locate_attributes (parser, "associate",
1848 "context", &context,
1852 if (push_element (parser, ELEMENT_ASSOCIATE) == NULL)
1854 BUS_SET_OOM (error);
1858 if (own == NULL || context == NULL)
1860 dbus_set_error (error, DBUS_ERROR_FAILED,
1861 "Element <associate> must have attributes own=\"<servicename>\" and context=\"<selinux context>\"");
1865 own_copy = _dbus_strdup (own);
1866 if (own_copy == NULL)
1868 context_copy = _dbus_strdup (context);
1869 if (context_copy == NULL)
1872 if (!_dbus_hash_table_insert_string (parser->service_context_table,
1873 own_copy, context_copy))
1880 dbus_set_error (error, DBUS_ERROR_FAILED,
1881 "Element <%s> not allowed inside <%s> in configuration file",
1882 element_name, "selinux");
1888 dbus_free (own_copy);
1891 dbus_free (context_copy);
1893 BUS_SET_OOM (error);
1898 bus_config_parser_start_element (BusConfigParser *parser,
1899 const char *element_name,
1900 const char **attribute_names,
1901 const char **attribute_values,
1906 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
1908 /* printf ("START: %s\n", element_name); */
1910 t = top_element_type (parser);
1912 if (t == ELEMENT_NONE)
1914 if (strcmp (element_name, "busconfig") == 0)
1916 if (!check_no_attributes (parser, "busconfig", attribute_names, attribute_values, error))
1919 if (push_element (parser, ELEMENT_BUSCONFIG) == NULL)
1921 BUS_SET_OOM (error);
1929 dbus_set_error (error, DBUS_ERROR_FAILED,
1930 "Unknown element <%s> at root of configuration file",
1935 else if (t == ELEMENT_BUSCONFIG)
1937 return start_busconfig_child (parser, element_name,
1938 attribute_names, attribute_values,
1941 else if (t == ELEMENT_POLICY)
1943 return start_policy_child (parser, element_name,
1944 attribute_names, attribute_values,
1947 else if (t == ELEMENT_SELINUX)
1949 return start_selinux_child (parser, element_name,
1950 attribute_names, attribute_values,
1955 dbus_set_error (error, DBUS_ERROR_FAILED,
1956 "Element <%s> is not allowed in this context",
1963 set_limit (BusConfigParser *parser,
1968 dbus_bool_t must_be_positive;
1969 dbus_bool_t must_be_int;
1971 must_be_int = FALSE;
1972 must_be_positive = FALSE;
1974 if (strcmp (name, "max_incoming_bytes") == 0)
1976 must_be_positive = TRUE;
1977 parser->limits.max_incoming_bytes = value;
1979 else if (strcmp (name, "max_incoming_unix_fds") == 0)
1981 must_be_positive = TRUE;
1982 parser->limits.max_incoming_unix_fds = value;
1984 else if (strcmp (name, "max_outgoing_bytes") == 0)
1986 must_be_positive = TRUE;
1987 parser->limits.max_outgoing_bytes = value;
1989 else if (strcmp (name, "max_outgoing_unix_fds") == 0)
1991 must_be_positive = TRUE;
1992 parser->limits.max_outgoing_unix_fds = value;
1994 else if (strcmp (name, "max_message_size") == 0)
1996 must_be_positive = TRUE;
1997 parser->limits.max_message_size = value;
1999 else if (strcmp (name, "max_message_unix_fds") == 0)
2001 must_be_positive = TRUE;
2002 parser->limits.max_message_unix_fds = value;
2004 else if (strcmp (name, "service_start_timeout") == 0)
2006 must_be_positive = TRUE;
2008 parser->limits.activation_timeout = value;
2010 else if (strcmp (name, "auth_timeout") == 0)
2012 must_be_positive = TRUE;
2014 parser->limits.auth_timeout = value;
2016 else if (strcmp (name, "pending_fd_timeout") == 0)
2018 must_be_positive = TRUE;
2020 parser->limits.pending_fd_timeout = value;
2022 else if (strcmp (name, "reply_timeout") == 0)
2024 must_be_positive = TRUE;
2026 parser->limits.reply_timeout = value;
2028 else if (strcmp (name, "max_completed_connections") == 0)
2030 must_be_positive = TRUE;
2032 parser->limits.max_completed_connections = value;
2034 else if (strcmp (name, "max_incomplete_connections") == 0)
2036 must_be_positive = TRUE;
2038 parser->limits.max_incomplete_connections = value;
2040 else if (strcmp (name, "max_connections_per_user") == 0)
2042 must_be_positive = TRUE;
2044 parser->limits.max_connections_per_user = value;
2046 else if (strcmp (name, "max_pending_service_starts") == 0)
2048 must_be_positive = TRUE;
2050 parser->limits.max_pending_activations = value;
2052 else if (strcmp (name, "max_names_per_connection") == 0)
2054 must_be_positive = TRUE;
2056 parser->limits.max_services_per_connection = value;
2058 else if (strcmp (name, "max_match_rules_per_connection") == 0)
2060 must_be_positive = TRUE;
2062 parser->limits.max_match_rules_per_connection = value;
2064 else if (strcmp (name, "max_replies_per_connection") == 0)
2066 must_be_positive = TRUE;
2068 parser->limits.max_replies_per_connection = value;
2072 dbus_set_error (error, DBUS_ERROR_FAILED,
2073 "There is no limit called \"%s\"\n",
2078 if (must_be_positive && value < 0)
2080 dbus_set_error (error, DBUS_ERROR_FAILED,
2081 "<limit name=\"%s\"> must be a positive number\n",
2087 (value < _DBUS_INT_MIN || value > _DBUS_INT_MAX))
2089 dbus_set_error (error, DBUS_ERROR_FAILED,
2090 "<limit name=\"%s\"> value is too large\n",
2099 bus_config_parser_end_element (BusConfigParser *parser,
2100 const char *element_name,
2107 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2109 /* printf ("END: %s\n", element_name); */
2111 t = top_element_type (parser);
2113 if (t == ELEMENT_NONE)
2115 /* should probably be an assertion failure but
2116 * being paranoid about XML parsers
2118 dbus_set_error (error, DBUS_ERROR_FAILED,
2119 "XML parser ended element with no element on the stack");
2123 n = bus_config_parser_element_type_to_name (t);
2124 _dbus_assert (n != NULL);
2125 if (strcmp (n, element_name) != 0)
2127 /* should probably be an assertion failure but
2128 * being paranoid about XML parsers
2130 dbus_set_error (error, DBUS_ERROR_FAILED,
2131 "XML element <%s> ended but topmost element on the stack was <%s>",
2136 e = peek_element (parser);
2137 _dbus_assert (e != NULL);
2142 _dbus_assert_not_reached ("element in stack has no type");
2145 case ELEMENT_INCLUDE:
2147 case ELEMENT_CONFIGTYPE:
2148 case ELEMENT_LISTEN:
2149 case ELEMENT_PIDFILE:
2151 case ELEMENT_SERVICEDIR:
2152 case ELEMENT_SERVICEHELPER:
2153 case ELEMENT_INCLUDEDIR:
2155 if (!e->had_content)
2157 dbus_set_error (error, DBUS_ERROR_FAILED,
2158 "XML element <%s> was expected to have content inside it",
2159 bus_config_parser_element_type_to_name (e->type));
2163 if (e->type == ELEMENT_LIMIT)
2165 if (!set_limit (parser, e->d.limit.name, e->d.limit.value,
2171 case ELEMENT_BUSCONFIG:
2172 case ELEMENT_POLICY:
2176 case ELEMENT_SYSLOG:
2177 case ELEMENT_KEEP_UMASK:
2178 case ELEMENT_SELINUX:
2179 case ELEMENT_ASSOCIATE:
2180 case ELEMENT_STANDARD_SESSION_SERVICEDIRS:
2181 case ELEMENT_STANDARD_SYSTEM_SERVICEDIRS:
2182 case ELEMENT_ALLOW_ANONYMOUS:
2183 case ELEMENT_APPARMOR:
2187 pop_element (parser);
2193 all_whitespace (const DBusString *str)
2197 _dbus_string_skip_white (str, 0, &i);
2199 return i == _dbus_string_get_length (str);
2203 make_full_path (const DBusString *basedir,
2204 const DBusString *filename,
2205 DBusString *full_path)
2207 if (_dbus_path_is_absolute (filename))
2209 if (!_dbus_string_copy (filename, 0, full_path, 0))
2214 if (!_dbus_string_copy (basedir, 0, full_path, 0))
2217 if (!_dbus_concat_dir_and_file (full_path, filename))
2221 if (!_dbus_replace_install_prefix (full_path))
2228 include_file (BusConfigParser *parser,
2229 const DBusString *filename,
2230 dbus_bool_t ignore_missing,
2233 /* FIXME good test case for this would load each config file in the
2234 * test suite both alone, and as an include, and check
2235 * that the result is the same
2237 BusConfigParser *included;
2238 const char *filename_str;
2239 DBusError tmp_error;
2241 dbus_error_init (&tmp_error);
2243 filename_str = _dbus_string_get_const_data (filename);
2245 /* Check to make sure this file hasn't already been included. */
2246 if (seen_include (parser, filename))
2248 dbus_set_error (error, DBUS_ERROR_FAILED,
2249 "Circular inclusion of file '%s'",
2254 if (! _dbus_list_append (&parser->included_files, (void *) filename_str))
2256 BUS_SET_OOM (error);
2260 /* Since parser is passed in as the parent, included
2261 inherits parser's limits. */
2262 included = bus_config_load (filename, FALSE, parser, &tmp_error);
2264 _dbus_list_pop_last (&parser->included_files);
2266 if (included == NULL)
2268 _DBUS_ASSERT_ERROR_IS_SET (&tmp_error);
2270 if (dbus_error_has_name (&tmp_error, DBUS_ERROR_FILE_NOT_FOUND) &&
2273 dbus_error_free (&tmp_error);
2278 dbus_move_error (&tmp_error, error);
2284 _DBUS_ASSERT_ERROR_IS_CLEAR (&tmp_error);
2286 if (!merge_included (parser, included, error))
2288 bus_config_parser_unref (included);
2292 /* Copy included's limits back to parser. */
2293 parser->limits = included->limits;
2295 bus_config_parser_unref (included);
2301 servicehelper_path (BusConfigParser *parser,
2302 const DBusString *filename,
2305 const char *filename_str;
2306 char *servicehelper;
2308 filename_str = _dbus_string_get_const_data (filename);
2310 /* copy to avoid overwriting with NULL on OOM */
2311 servicehelper = _dbus_strdup (filename_str);
2314 if (servicehelper == NULL)
2316 BUS_SET_OOM (error);
2320 /* save the latest servicehelper only if not OOM */
2321 dbus_free (parser->servicehelper);
2322 parser->servicehelper = servicehelper;
2324 /* We don't check whether the helper exists; instead we
2325 * would just fail to ever activate anything if it doesn't.
2326 * This allows an admin to fix the problem if it doesn't exist.
2327 * It also allows the parser test suite to successfully parse
2328 * test cases without installing the helper. ;-)
2335 include_dir (BusConfigParser *parser,
2336 const DBusString *dirname,
2339 DBusString filename;
2341 DBusError tmp_error;
2345 if (!_dbus_string_init (&filename))
2347 BUS_SET_OOM (error);
2353 dir = _dbus_directory_open (dirname, error);
2357 if (dbus_error_has_name (error, DBUS_ERROR_FILE_NOT_FOUND))
2359 dbus_error_free (error);
2366 dbus_error_init (&tmp_error);
2367 while (_dbus_directory_get_next_file (dir, &filename, &tmp_error))
2369 DBusString full_path;
2371 if (!_dbus_string_init (&full_path))
2373 BUS_SET_OOM (error);
2377 if (!_dbus_string_copy (dirname, 0, &full_path, 0))
2379 BUS_SET_OOM (error);
2380 _dbus_string_free (&full_path);
2384 if (!_dbus_concat_dir_and_file (&full_path, &filename))
2386 BUS_SET_OOM (error);
2387 _dbus_string_free (&full_path);
2391 if (_dbus_string_ends_with_c_str (&full_path, ".conf"))
2393 if (!include_file (parser, &full_path, TRUE, error))
2395 if (dbus_error_is_set (error))
2397 /* We use both syslog and stderr here, because this is
2398 * the configuration parser, so we don't yet know whether
2399 * this bus is going to want to write to syslog! Err on
2400 * the side of making sure the message gets to the sysadmin
2402 _dbus_init_system_log ("dbus-daemon",
2403 DBUS_LOG_FLAGS_STDERR | DBUS_LOG_FLAGS_SYSTEM_LOG);
2404 _dbus_log (DBUS_SYSTEM_LOG_INFO,
2405 "Encountered error '%s' while parsing '%s'",
2407 _dbus_string_get_const_data (&full_path));
2408 dbus_error_free (error);
2413 _dbus_string_free (&full_path);
2416 if (dbus_error_is_set (&tmp_error))
2418 dbus_move_error (&tmp_error, error);
2423 if (!_dbus_string_copy_data (dirname, &s))
2425 BUS_SET_OOM (error);
2429 if (!_dbus_list_append (&parser->conf_dirs, s))
2432 BUS_SET_OOM (error);
2440 _dbus_string_free (&filename);
2443 _dbus_directory_close (dir);
2449 bus_config_parser_content (BusConfigParser *parser,
2450 const DBusString *content,
2455 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2461 _dbus_string_get_const_data (content, &c_str);
2463 printf ("CONTENT %d bytes: %s\n", _dbus_string_get_length (content), c_str);
2467 e = peek_element (parser);
2470 dbus_set_error (error, DBUS_ERROR_FAILED,
2471 "Text content outside of any XML element in configuration file");
2474 else if (e->had_content)
2476 _dbus_assert_not_reached ("Element had multiple content blocks");
2480 switch (top_element_type (parser))
2483 _dbus_assert_not_reached ("element at top of stack has no type");
2486 case ELEMENT_BUSCONFIG:
2487 case ELEMENT_POLICY:
2491 case ELEMENT_SYSLOG:
2492 case ELEMENT_KEEP_UMASK:
2493 case ELEMENT_STANDARD_SESSION_SERVICEDIRS:
2494 case ELEMENT_STANDARD_SYSTEM_SERVICEDIRS:
2495 case ELEMENT_ALLOW_ANONYMOUS:
2496 case ELEMENT_SELINUX:
2497 case ELEMENT_ASSOCIATE:
2498 case ELEMENT_APPARMOR:
2499 if (all_whitespace (content))
2503 dbus_set_error (error, DBUS_ERROR_FAILED,
2504 "No text content expected inside XML element %s in configuration file",
2505 bus_config_parser_element_type_to_name (top_element_type (parser)));
2509 case ELEMENT_PIDFILE:
2513 e->had_content = TRUE;
2515 if (!_dbus_string_copy_data (content, &s))
2518 dbus_free (parser->pidfile);
2519 parser->pidfile = s;
2523 case ELEMENT_INCLUDE:
2525 DBusString full_path, selinux_policy_root;
2527 e->had_content = TRUE;
2529 if (e->d.include.if_selinux_enabled
2530 && !bus_selinux_enabled ())
2533 if (!_dbus_string_init (&full_path))
2536 if (e->d.include.selinux_root_relative)
2538 if (!bus_selinux_get_policy_root ())
2540 dbus_set_error (error, DBUS_ERROR_FAILED,
2541 "Could not determine SELinux policy root for relative inclusion");
2542 _dbus_string_free (&full_path);
2545 _dbus_string_init_const (&selinux_policy_root,
2546 bus_selinux_get_policy_root ());
2547 if (!make_full_path (&selinux_policy_root, content, &full_path))
2549 _dbus_string_free (&full_path);
2553 else if (!make_full_path (&parser->basedir, content, &full_path))
2555 _dbus_string_free (&full_path);
2559 if (!include_file (parser, &full_path,
2560 e->d.include.ignore_missing, error))
2562 _dbus_string_free (&full_path);
2566 _dbus_string_free (&full_path);
2570 case ELEMENT_SERVICEHELPER:
2572 DBusString full_path;
2574 e->had_content = TRUE;
2576 if (!_dbus_string_init (&full_path))
2579 if (!make_full_path (&parser->basedir, content, &full_path))
2581 _dbus_string_free (&full_path);
2585 if (!servicehelper_path (parser, &full_path, error))
2587 _dbus_string_free (&full_path);
2591 _dbus_string_free (&full_path);
2595 case ELEMENT_INCLUDEDIR:
2597 DBusString full_path;
2599 e->had_content = TRUE;
2601 if (!_dbus_string_init (&full_path))
2604 if (!make_full_path (&parser->basedir, content, &full_path))
2606 _dbus_string_free (&full_path);
2610 if (!include_dir (parser, &full_path, error))
2612 _dbus_string_free (&full_path);
2616 _dbus_string_free (&full_path);
2624 e->had_content = TRUE;
2626 if (!_dbus_string_copy_data (content, &s))
2629 dbus_free (parser->user);
2634 case ELEMENT_CONFIGTYPE:
2638 e->had_content = TRUE;
2640 if (!_dbus_string_copy_data (content, &s))
2643 dbus_free (parser->bus_type);
2644 parser->bus_type = s;
2648 case ELEMENT_LISTEN:
2652 e->had_content = TRUE;
2654 if (!_dbus_string_copy_data (content, &s))
2657 if (!_dbus_list_append (&parser->listen_on,
2670 e->had_content = TRUE;
2672 if (!_dbus_string_copy_data (content, &s))
2675 if (!_dbus_list_append (&parser->mechanisms,
2684 case ELEMENT_SERVICEDIR:
2687 BusConfigServiceDir *dir;
2688 DBusString full_path;
2691 e->had_content = TRUE;
2693 if (!_dbus_string_init (&full_path))
2696 if (!make_full_path (&parser->basedir, content, &full_path))
2698 _dbus_string_free (&full_path);
2702 if (!_dbus_string_copy_data (&full_path, &s))
2704 _dbus_string_free (&full_path);
2708 /* <servicedir/> has traditionally implied that we watch the
2709 * directory with inotify, and allow service files whose names do not
2710 * match the bus name */
2711 dir = bus_config_service_dir_new_take (s, BUS_SERVICE_DIR_FLAGS_NONE);
2715 _dbus_string_free (&full_path);
2720 link = _dbus_list_alloc_link (dir);
2724 _dbus_string_free (&full_path);
2725 bus_config_service_dir_free (dir);
2730 service_dirs_append_link_unique_or_free (&parser->service_dirs, link);
2731 _dbus_string_free (&full_path);
2739 e->had_content = TRUE;
2742 if (!_dbus_string_parse_int (content, 0, &val, NULL))
2744 dbus_set_error (error, DBUS_ERROR_FAILED,
2745 "<limit name=\"%s\"> element has invalid value (could not parse as integer)",
2750 e->d.limit.value = val;
2752 _dbus_verbose ("Loaded value %ld for limit %s\n",
2759 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2763 BUS_SET_OOM (error);
2768 bus_config_parser_finished (BusConfigParser *parser,
2771 _DBUS_ASSERT_ERROR_IS_CLEAR (error);
2773 if (parser->stack != NULL)
2775 dbus_set_error (error, DBUS_ERROR_FAILED,
2776 "Element <%s> was not closed in configuration file",
2777 bus_config_parser_element_type_to_name (top_element_type (parser)));
2782 if (parser->is_toplevel && parser->listen_on == NULL)
2784 dbus_set_error (error, DBUS_ERROR_FAILED,
2785 "Configuration file needs one or more <listen> elements giving addresses");
2793 bus_config_parser_get_user (BusConfigParser *parser)
2795 return parser->user;
2799 bus_config_parser_get_type (BusConfigParser *parser)
2801 return parser->bus_type;
2805 bus_config_parser_get_addresses (BusConfigParser *parser)
2807 return &parser->listen_on;
2811 bus_config_parser_get_mechanisms (BusConfigParser *parser)
2813 return &parser->mechanisms;
2817 bus_config_parser_get_service_dirs (BusConfigParser *parser)
2819 return &parser->service_dirs;
2823 bus_config_parser_get_conf_dirs (BusConfigParser *parser)
2825 return &parser->conf_dirs;
2829 bus_config_parser_get_fork (BusConfigParser *parser)
2831 return parser->fork;
2835 bus_config_parser_get_syslog (BusConfigParser *parser)
2837 return parser->syslog;
2841 bus_config_parser_get_keep_umask (BusConfigParser *parser)
2843 return parser->keep_umask;
2847 bus_config_parser_get_allow_anonymous (BusConfigParser *parser)
2849 return parser->allow_anonymous;
2853 bus_config_parser_get_pidfile (BusConfigParser *parser)
2855 return parser->pidfile;
2859 bus_config_parser_get_servicehelper (BusConfigParser *parser)
2861 return parser->servicehelper;
2865 bus_config_parser_steal_policy (BusConfigParser *parser)
2869 _dbus_assert (parser->policy != NULL); /* can only steal the policy 1 time */
2871 policy = parser->policy;
2873 parser->policy = NULL;
2878 /* Overwrite any limits that were set in the configuration file */
2880 bus_config_parser_get_limits (BusConfigParser *parser,
2883 *limits = parser->limits;
2887 bus_config_parser_steal_service_context_table (BusConfigParser *parser)
2889 DBusHashTable *table;
2891 _dbus_assert (parser->service_context_table != NULL); /* can only steal once */
2893 table = parser->service_context_table;
2895 parser->service_context_table = NULL;
2901 * Return a list of the directories that should be watched with inotify,
2902 * as strings. The list might be empty and is in arbitrary order.
2904 * The list must be empty on entry. On success, the links are owned by the
2905 * caller and must be freed, but the data in each link remains owned by
2906 * the BusConfigParser and must not be freed: in GObject-Introspection
2907 * notation, it is (transfer container).
2910 bus_config_parser_get_watched_dirs (BusConfigParser *parser,
2911 DBusList **watched_dirs)
2915 _dbus_assert (*watched_dirs == NULL);
2917 for (link = _dbus_list_get_first_link (&parser->conf_dirs);
2919 link = _dbus_list_get_next_link (&parser->conf_dirs, link))
2921 if (!_dbus_list_append (watched_dirs, link->data))
2925 for (link = _dbus_list_get_first_link (&parser->service_dirs);
2927 link = _dbus_list_get_next_link (&parser->service_dirs, link))
2929 BusConfigServiceDir *dir = link->data;
2931 if (dir->flags & BUS_SERVICE_DIR_FLAGS_NO_WATCH)
2934 if (!_dbus_list_append (watched_dirs, dir->path))
2941 _dbus_list_clear (watched_dirs);
2945 #ifdef DBUS_ENABLE_EMBEDDED_TESTS
2956 do_check_own_rules (BusPolicy *policy)
2960 dbus_bool_t allowed;
2962 {"org.freedesktop", FALSE},
2963 {"org.freedesktop.ManySystem", FALSE},
2964 {"org.freedesktop.ManySystems", TRUE},
2965 {"org.freedesktop.ManySystems.foo", TRUE},
2966 {"org.freedesktop.ManySystems.foo.bar", TRUE},
2967 {"org.freedesktop.ManySystems2", FALSE},
2968 {"org.freedesktop.ManySystems2.foo", FALSE},
2969 {"org.freedesktop.ManySystems2.foo.bar", FALSE},
2974 while (checks[i].name)
2976 DBusString service_name;
2979 if (!_dbus_string_init (&service_name))
2980 _dbus_assert_not_reached ("couldn't init string");
2981 if (!_dbus_string_append (&service_name, checks[i].name))
2982 _dbus_assert_not_reached ("couldn't append string");
2984 ret = bus_policy_check_can_own (policy, &service_name);
2985 printf (" Check name %s: %s\n", checks[i].name,
2986 ret ? "allowed" : "not allowed");
2987 if (checks[i].allowed && !ret)
2989 _dbus_warn ("Cannot own %s", checks[i].name);
2992 if (!checks[i].allowed && ret)
2994 _dbus_warn ("Can own %s", checks[i].name);
2997 _dbus_string_free (&service_name);
3006 do_load (const DBusString *full_path,
3008 dbus_bool_t oom_possible,
3009 dbus_bool_t check_own_rules)
3011 BusConfigParser *parser;
3014 dbus_error_init (&error);
3016 parser = bus_config_load (full_path, TRUE, NULL, &error);
3019 _DBUS_ASSERT_ERROR_IS_SET (&error);
3022 dbus_error_has_name (&error, DBUS_ERROR_NO_MEMORY))
3024 _dbus_verbose ("Failed to load valid file due to OOM\n");
3025 dbus_error_free (&error);
3028 else if (validity == VALID)
3030 _dbus_warn ("Failed to load valid file but still had memory: %s",
3033 dbus_error_free (&error);
3038 dbus_error_free (&error);
3044 _DBUS_ASSERT_ERROR_IS_CLEAR (&error);
3046 if (check_own_rules && do_check_own_rules (parser->policy) == FALSE)
3051 bus_config_parser_unref (parser);
3053 if (validity == INVALID)
3055 _dbus_warn ("Accepted invalid file");
3065 const DBusString *full_path;
3067 dbus_bool_t check_own_rules;
3071 check_loader_oom_func (void *data)
3073 LoaderOomData *d = data;
3075 return do_load (d->full_path, d->validity, TRUE, d->check_own_rules);
3079 process_test_valid_subdir (const DBusString *test_base_dir,
3083 DBusString test_directory;
3084 DBusString filename;
3092 if (!_dbus_string_init (&test_directory))
3093 _dbus_assert_not_reached ("didn't allocate test_directory");
3095 _dbus_string_init_const (&filename, subdir);
3097 if (!_dbus_string_copy (test_base_dir, 0,
3098 &test_directory, 0))
3099 _dbus_assert_not_reached ("couldn't copy test_base_dir to test_directory");
3101 if (!_dbus_concat_dir_and_file (&test_directory, &filename))
3102 _dbus_assert_not_reached ("couldn't allocate full path");
3104 _dbus_string_free (&filename);
3105 if (!_dbus_string_init (&filename))
3106 _dbus_assert_not_reached ("didn't allocate filename string");
3108 dbus_error_init (&error);
3109 dir = _dbus_directory_open (&test_directory, &error);
3112 _dbus_warn ("Could not open %s: %s",
3113 _dbus_string_get_const_data (&test_directory),
3115 dbus_error_free (&error);
3119 if (validity == VALID)
3120 printf ("Testing valid files:\n");
3121 else if (validity == INVALID)
3122 printf ("Testing invalid files:\n");
3124 printf ("Testing unknown files:\n");
3127 while (_dbus_directory_get_next_file (dir, &filename, &error))
3129 DBusString full_path;
3132 if (!_dbus_string_init (&full_path))
3133 _dbus_assert_not_reached ("couldn't init string");
3135 if (!_dbus_string_copy (&test_directory, 0, &full_path, 0))
3136 _dbus_assert_not_reached ("couldn't copy dir to full_path");
3138 if (!_dbus_concat_dir_and_file (&full_path, &filename))
3139 _dbus_assert_not_reached ("couldn't concat file to dir");
3141 if (!_dbus_string_ends_with_c_str (&full_path, ".conf"))
3143 _dbus_verbose ("Skipping non-.conf file %s\n",
3144 _dbus_string_get_const_data (&filename));
3145 _dbus_string_free (&full_path);
3149 printf (" %s\n", _dbus_string_get_const_data (&filename));
3151 _dbus_verbose (" expecting %s\n",
3152 validity == VALID ? "valid" :
3153 (validity == INVALID ? "invalid" :
3154 (validity == UNKNOWN ? "unknown" : "???")));
3156 d.full_path = &full_path;
3157 d.validity = validity;
3158 d.check_own_rules = _dbus_string_ends_with_c_str (&full_path,
3159 "check-own-rules.conf");
3161 /* FIXME hackaround for an expat problem, see
3162 * https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=124747
3163 * http://freedesktop.org/pipermail/dbus/2004-May/001153.html
3165 /* if (!_dbus_test_oom_handling ("config-loader", check_loader_oom_func, &d)) */
3166 if (!check_loader_oom_func (&d))
3167 _dbus_assert_not_reached ("test failed");
3169 _dbus_string_free (&full_path);
3172 if (dbus_error_is_set (&error))
3174 _dbus_warn ("Could not get next file in %s: %s",
3175 _dbus_string_get_const_data (&test_directory),
3177 dbus_error_free (&error);
3186 _dbus_directory_close (dir);
3187 _dbus_string_free (&test_directory);
3188 _dbus_string_free (&filename);
3194 bools_equal (dbus_bool_t a,
3201 strings_equal_or_both_null (const char *a,
3204 if (a == NULL || b == NULL)
3207 return !strcmp (a, b);
3211 elements_equal (const Element *a,
3214 if (a->type != b->type)
3217 if (!bools_equal (a->had_content, b->had_content))
3223 case ELEMENT_INCLUDE:
3224 if (!bools_equal (a->d.include.ignore_missing,
3225 b->d.include.ignore_missing))
3229 case ELEMENT_POLICY:
3230 if (a->d.policy.type != b->d.policy.type)
3232 if (a->d.policy.gid_uid_or_at_console != b->d.policy.gid_uid_or_at_console)
3237 if (strcmp (a->d.limit.name, b->d.limit.name))
3239 if (a->d.limit.value != b->d.limit.value)
3253 lists_of_elements_equal (DBusList *a,
3262 while (ia != NULL && ib != NULL)
3264 if (elements_equal (ia->data, ib->data))
3266 ia = _dbus_list_get_next_link (&a, ia);
3267 ib = _dbus_list_get_next_link (&b, ib);
3270 return ia == NULL && ib == NULL;
3274 lists_of_c_strings_equal (DBusList *a,
3283 while (ia != NULL && ib != NULL)
3285 if (strcmp (ia->data, ib->data))
3287 ia = _dbus_list_get_next_link (&a, ia);
3288 ib = _dbus_list_get_next_link (&b, ib);
3291 return ia == NULL && ib == NULL;
3295 lists_of_service_dirs_equal (DBusList *a,
3304 while (ia != NULL && ib != NULL)
3306 BusConfigServiceDir *da = ia->data;
3307 BusConfigServiceDir *db = ib->data;
3309 if (strcmp (da->path, db->path))
3312 if (da->flags != db->flags)
3315 ia = _dbus_list_get_next_link (&a, ia);
3316 ib = _dbus_list_get_next_link (&b, ib);
3319 return ia == NULL && ib == NULL;
3323 limits_equal (const BusLimits *a,
3327 (a->max_incoming_bytes == b->max_incoming_bytes
3328 || a->max_incoming_unix_fds == b->max_incoming_unix_fds
3329 || a->max_outgoing_bytes == b->max_outgoing_bytes
3330 || a->max_outgoing_unix_fds == b->max_outgoing_unix_fds
3331 || a->max_message_size == b->max_message_size
3332 || a->max_message_unix_fds == b->max_message_unix_fds
3333 || a->activation_timeout == b->activation_timeout
3334 || a->auth_timeout == b->auth_timeout
3335 || a->pending_fd_timeout == b->pending_fd_timeout
3336 || a->max_completed_connections == b->max_completed_connections
3337 || a->max_incomplete_connections == b->max_incomplete_connections
3338 || a->max_connections_per_user == b->max_connections_per_user
3339 || a->max_pending_activations == b->max_pending_activations
3340 || a->max_services_per_connection == b->max_services_per_connection
3341 || a->max_match_rules_per_connection == b->max_match_rules_per_connection
3342 || a->max_replies_per_connection == b->max_replies_per_connection
3343 || a->reply_timeout == b->reply_timeout);
3347 config_parsers_equal (const BusConfigParser *a,
3348 const BusConfigParser *b)
3350 if (!_dbus_string_equal (&a->basedir, &b->basedir))
3353 if (!lists_of_elements_equal (a->stack, b->stack))
3356 if (!strings_equal_or_both_null (a->user, b->user))
3359 if (!lists_of_c_strings_equal (a->listen_on, b->listen_on))
3362 if (!lists_of_c_strings_equal (a->mechanisms, b->mechanisms))
3365 if (!lists_of_service_dirs_equal (a->service_dirs, b->service_dirs))
3368 /* FIXME: compare policy */
3370 /* FIXME: compare service selinux ID table */
3372 if (! limits_equal (&a->limits, &b->limits))
3375 if (!strings_equal_or_both_null (a->pidfile, b->pidfile))
3378 if (! bools_equal (a->fork, b->fork))
3381 if (! bools_equal (a->keep_umask, b->keep_umask))
3384 if (! bools_equal (a->is_toplevel, b->is_toplevel))
3391 all_are_equiv (const DBusString *target_directory)
3393 DBusString filename;
3395 BusConfigParser *first_parser;
3396 BusConfigParser *parser;
3402 first_parser = NULL;
3406 if (!_dbus_string_init (&filename))
3407 _dbus_assert_not_reached ("didn't allocate filename string");
3409 dbus_error_init (&error);
3410 dir = _dbus_directory_open (target_directory, &error);
3413 _dbus_warn ("Could not open %s: %s",
3414 _dbus_string_get_const_data (target_directory),
3416 dbus_error_free (&error);
3420 printf ("Comparing equivalent files:\n");
3423 while (_dbus_directory_get_next_file (dir, &filename, &error))
3425 DBusString full_path;
3427 if (!_dbus_string_init (&full_path))
3428 _dbus_assert_not_reached ("couldn't init string");
3430 if (!_dbus_string_copy (target_directory, 0, &full_path, 0))
3431 _dbus_assert_not_reached ("couldn't copy dir to full_path");
3433 if (!_dbus_concat_dir_and_file (&full_path, &filename))
3434 _dbus_assert_not_reached ("couldn't concat file to dir");
3436 if (!_dbus_string_ends_with_c_str (&full_path, ".conf"))
3438 _dbus_verbose ("Skipping non-.conf file %s\n",
3439 _dbus_string_get_const_data (&filename));
3440 _dbus_string_free (&full_path);
3444 printf (" %s\n", _dbus_string_get_const_data (&filename));
3446 parser = bus_config_load (&full_path, TRUE, NULL, &error);
3450 _dbus_warn ("Could not load file %s: %s",
3451 _dbus_string_get_const_data (&full_path),
3453 _dbus_string_free (&full_path);
3454 dbus_error_free (&error);
3457 else if (first_parser == NULL)
3459 _dbus_string_free (&full_path);
3460 first_parser = parser;
3464 _dbus_string_free (&full_path);
3465 equal = config_parsers_equal (first_parser, parser);
3466 bus_config_parser_unref (parser);
3475 _dbus_string_free (&filename);
3477 bus_config_parser_unref (first_parser);
3479 _dbus_directory_close (dir);
3486 process_test_equiv_subdir (const DBusString *test_base_dir,
3489 DBusString test_directory;
3490 DBusString filename;
3499 if (!_dbus_string_init (&test_directory))
3500 _dbus_assert_not_reached ("didn't allocate test_directory");
3502 _dbus_string_init_const (&filename, subdir);
3504 if (!_dbus_string_copy (test_base_dir, 0,
3505 &test_directory, 0))
3506 _dbus_assert_not_reached ("couldn't copy test_base_dir to test_directory");
3508 if (!_dbus_concat_dir_and_file (&test_directory, &filename))
3509 _dbus_assert_not_reached ("couldn't allocate full path");
3511 _dbus_string_free (&filename);
3512 if (!_dbus_string_init (&filename))
3513 _dbus_assert_not_reached ("didn't allocate filename string");
3515 dbus_error_init (&error);
3516 dir = _dbus_directory_open (&test_directory, &error);
3519 _dbus_warn ("Could not open %s: %s",
3520 _dbus_string_get_const_data (&test_directory),
3522 dbus_error_free (&error);
3526 while (_dbus_directory_get_next_file (dir, &filename, &error))
3528 DBusString full_path;
3530 /* Skip CVS's magic directories! */
3531 if (_dbus_string_equal_c_str (&filename, "CVS"))
3534 if (!_dbus_string_init (&full_path))
3535 _dbus_assert_not_reached ("couldn't init string");
3537 if (!_dbus_string_copy (&test_directory, 0, &full_path, 0))
3538 _dbus_assert_not_reached ("couldn't copy dir to full_path");
3540 if (!_dbus_concat_dir_and_file (&full_path, &filename))
3541 _dbus_assert_not_reached ("couldn't concat file to dir");
3543 equal = all_are_equiv (&full_path);
3544 _dbus_string_free (&full_path);
3553 _dbus_string_free (&test_directory);
3554 _dbus_string_free (&filename);
3556 _dbus_directory_close (dir);
3562 static const char *test_session_service_dir_matches[] =
3564 /* will be filled in test_default_session_servicedirs() */
3566 NULL, /* install root-based */
3567 NULL, /* CommonProgramFiles-based */
3569 NULL, /* XDG_DATA_HOME-based */
3570 NULL, /* XDG_DATA_DIRS-based */
3571 NULL, /* XDG_DATA_DIRS-based */
3572 DBUS_DATADIR "/dbus-1/services",
3578 test_default_session_servicedirs (const DBusString *test_base_dir)
3580 BusConfigParser *parser = NULL;
3581 DBusError error = DBUS_ERROR_INIT;
3583 DBusList *watched_dirs = NULL;
3586 DBusString full_path;
3588 DBusString install_root_based;
3589 DBusString data_home_based;
3590 DBusString data_dirs_based;
3591 DBusString data_dirs_based2;
3593 dbus_bool_t ret = FALSE;
3595 const char *common_progs;
3597 const char *dbus_test_builddir;
3598 const char *xdg_data_home;
3601 /* On each platform we don't actually use all of these, but it's easier to
3602 * handle the deallocation if we always allocate them, whether needed or
3604 if (!_dbus_string_init (&full_path) ||
3605 !_dbus_string_init (&progs) ||
3606 !_dbus_string_init (&install_root_based) ||
3607 !_dbus_string_init (&data_home_based) ||
3608 !_dbus_string_init (&data_dirs_based) ||
3609 !_dbus_string_init (&data_dirs_based2))
3610 _dbus_assert_not_reached ("OOM allocating strings");
3612 if (!_dbus_string_copy (test_base_dir, 0,
3614 _dbus_assert_not_reached ("couldn't copy test_base_dir to full_path");
3616 _dbus_string_init_const (&tmp, "valid-config-files");
3618 if (!_dbus_concat_dir_and_file (&full_path, &tmp))
3619 _dbus_assert_not_reached ("couldn't allocate full path");
3621 _dbus_string_init_const (&tmp, "standard-session-dirs.conf");
3623 if (!_dbus_concat_dir_and_file (&full_path, &tmp))
3624 _dbus_assert_not_reached ("couldn't allocate full path");
3627 if (!_dbus_string_append (&install_root_based, DBUS_DATADIR) ||
3628 !_dbus_string_append (&install_root_based, "/dbus-1/services") ||
3629 !_dbus_replace_install_prefix (&install_root_based))
3632 _dbus_assert (_dbus_path_is_absolute (&install_root_based));
3634 test_session_service_dir_matches[0] = _dbus_string_get_const_data (
3635 &install_root_based);
3637 common_progs = _dbus_getenv ("CommonProgramFiles");
3641 if (!_dbus_string_append (&progs, common_progs))
3644 if (!_dbus_string_append (&progs, "/dbus-1/services"))
3647 test_session_service_dir_matches[1] = _dbus_string_get_const_data(&progs);
3650 dbus_test_builddir = _dbus_getenv ("DBUS_TEST_BUILDDIR");
3651 xdg_data_home = _dbus_getenv ("XDG_DATA_HOME");
3653 if (dbus_test_builddir == NULL || xdg_data_home == NULL)
3655 printf ("Not testing default session service directories because a "
3656 "build-time testing environment variable is not set: "
3657 "see AM_TESTS_ENVIRONMENT in tests/Makefile.am\n");
3662 if (!_dbus_string_append (&data_dirs_based, dbus_test_builddir) ||
3663 !_dbus_string_append (&data_dirs_based, "/XDG_DATA_DIRS/dbus-1/services") ||
3664 !_dbus_string_append (&data_dirs_based2, dbus_test_builddir) ||
3665 !_dbus_string_append (&data_dirs_based2, "/XDG_DATA_DIRS2/dbus-1/services") ||
3666 !_dbus_string_append (&data_home_based, xdg_data_home) ||
3667 !_dbus_string_append (&data_home_based, "/dbus-1/services"))
3668 _dbus_assert_not_reached ("out of memory");
3670 /* Sanity check: the Makefile sets this up. We assume that if this is
3671 * right, the XDG_DATA_DIRS will be too. */
3672 if (!_dbus_string_starts_with_c_str (&data_home_based, dbus_test_builddir))
3673 _dbus_assert_not_reached ("$XDG_DATA_HOME should start with $DBUS_TEST_BUILDDIR");
3675 test_session_service_dir_matches[0] = _dbus_string_get_const_data (
3677 test_session_service_dir_matches[1] = _dbus_string_get_const_data (
3679 test_session_service_dir_matches[2] = _dbus_string_get_const_data (
3683 parser = bus_config_load (&full_path, TRUE, NULL, &error);
3686 _dbus_assert_not_reached (error.message);
3688 dirs = bus_config_parser_get_service_dirs (parser);
3690 for (link = _dbus_list_get_first_link (dirs), i = 0;
3692 link = _dbus_list_get_next_link (dirs, link), i++)
3694 BusConfigServiceDir *dir = link->data;
3696 printf (" test service dir: '%s'\n", dir->path);
3697 printf (" current standard service dir: '%s'\n", test_session_service_dir_matches[i]);
3698 if (test_session_service_dir_matches[i] == NULL)
3700 printf ("more directories parsed than in match set\n");
3704 if (strcmp (test_session_service_dir_matches[i], dir->path) != 0)
3706 printf ("'%s' directory does not match '%s' in the match set\n",
3707 dir->path, test_session_service_dir_matches[i]);
3711 if (dir->flags != BUS_SERVICE_DIR_FLAGS_NONE)
3713 printf ("'%s' directory has flags 0x%x, should be 0x%x\n",
3714 dir->path, dir->flags, BUS_SERVICE_DIR_FLAGS_NONE);
3719 if (test_session_service_dir_matches[i] != NULL)
3721 printf ("extra data %s in the match set was not matched\n",
3722 test_session_service_dir_matches[i]);
3726 if (!bus_config_parser_get_watched_dirs (parser, &watched_dirs))
3727 _dbus_assert_not_reached ("out of memory");
3729 for (link = _dbus_list_get_first_link (&watched_dirs), i = 0;
3731 link = _dbus_list_get_next_link (&watched_dirs, link), i++)
3733 printf (" watched service dir: '%s'\n", (const char *) link->data);
3734 printf (" current standard service dir: '%s'\n",
3735 test_session_service_dir_matches[i]);
3737 if (test_session_service_dir_matches[i] == NULL)
3739 printf ("more directories parsed than in match set\n");
3743 if (strcmp (test_session_service_dir_matches[i],
3744 (const char *) link->data) != 0)
3746 printf ("'%s' directory does not match '%s' in the match set\n",
3747 (const char *) link->data,
3748 test_session_service_dir_matches[i]);
3753 if (test_session_service_dir_matches[i] != NULL)
3755 printf ("extra data %s in the match set was not matched\n",
3756 test_session_service_dir_matches[i]);
3764 bus_config_parser_unref (parser);
3766 _dbus_list_clear (&watched_dirs);
3767 _dbus_string_free (&full_path);
3768 _dbus_string_free (&install_root_based);
3769 _dbus_string_free (&progs);
3770 _dbus_string_free (&data_home_based);
3771 _dbus_string_free (&data_dirs_based);
3772 _dbus_string_free (&data_dirs_based2);
3777 static const char *test_system_service_dir_matches[] =
3779 "/usr/local/share/dbus-1/system-services",
3780 "/usr/share/dbus-1/system-services",
3781 DBUS_DATADIR"/dbus-1/system-services",
3782 "/lib/dbus-1/system-services",
3787 test_default_system_servicedirs (void)
3795 if (!_dbus_get_standard_system_servicedirs (&dirs))
3796 _dbus_assert_not_reached ("couldn't get stardard dirs");
3798 /* make sure we read and parse the env variable correctly */
3800 while ((link = _dbus_list_pop_first_link (&dirs)))
3802 printf (" test service dir: %s\n", (char *)link->data);
3803 if (test_system_service_dir_matches[i] == NULL)
3805 printf ("more directories parsed than in match set\n");
3806 dbus_free (link->data);
3807 _dbus_list_free_link (link);
3811 if (strcmp (test_system_service_dir_matches[i],
3812 (char *)link->data) != 0)
3814 printf ("%s directory does not match %s in the match set\n",
3816 test_system_service_dir_matches[i]);
3817 dbus_free (link->data);
3818 _dbus_list_free_link (link);
3824 dbus_free (link->data);
3825 _dbus_list_free_link (link);
3828 if (test_system_service_dir_matches[i] != NULL)
3830 printf ("extra data %s in the match set was not matched\n",
3831 test_system_service_dir_matches[i]);
3841 bus_config_parser_test (const DBusString *test_data_dir)
3843 if (test_data_dir == NULL ||
3844 _dbus_string_get_length (test_data_dir) == 0)
3846 printf ("No test data\n");
3850 if (!test_default_session_servicedirs (test_data_dir))
3854 printf("default system service dir skipped\n");
3856 if (!test_default_system_servicedirs())
3860 if (!process_test_valid_subdir (test_data_dir, "valid-config-files", VALID))
3864 if (!process_test_valid_subdir (test_data_dir, "valid-config-files-system", VALID))
3868 if (!process_test_valid_subdir (test_data_dir, "invalid-config-files", INVALID))
3871 if (!process_test_equiv_subdir (test_data_dir, "equiv-config-files"))
3877 #endif /* DBUS_ENABLE_EMBEDDED_TESTS */