base/values_unittest.cc

   1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
   2 // Use of this source code is governed by a BSD-style license that can be
   3 // found in the LICENSE file.
   4
   5 #include "base/values.h"
   6
   7 #include <stddef.h>
   8
   9 #include <algorithm>
  10 #include <functional>
  11 #include <limits>
  12 #include <memory>
  13 #include <string>
  14 #include <type_traits>
  15 #include <utility>
  16 #include <vector>
  17
  18 #include "base/containers/adapters.h"
  19 #include "base/logging.h"
  20 #include "base/strings/string16.h"
  21 #include "base/strings/string_piece.h"
  22 #include "base/strings/utf_string_conversions.h"
  23 #include "build/build_config.h"
  24 #include "testing/gmock/include/gmock/gmock.h"
  25 #include "testing/gtest/include/gtest/gtest.h"
  26
  27 namespace base {
  28
  29 // Ensure that base::Value is as small as possible, i.e. that there is
  30 // no wasted space after the inner value due to alignment constraints.
  31 // Distinguish between the 'header' that includes |type_| and and the inner
  32 // value that follows it, which can be a bool, int, double, string, blob, list
  33 // or dict.
  34 //
  35 // This test is only enabled when NDEBUG is defined. This way the test will not
  36 // fail in debug builds that sometimes contain larger versions of the standard
  37 // containers used inside base::Value.
  38 #if defined(NDEBUG)
  39
  40 static size_t AlignSizeTo(size_t size, size_t alignment) {
  41   EXPECT_TRUE((alignment & (alignment - 1)) == 0)
  42       << "Alignment " << alignment << " is not a power of 2!";
  43   return (size + (alignment - 1u)) & ~(alignment - 1u);
  44 }
  45
  46 TEST(ValuesTest, SizeOfValue) {
  47 #define INNER_TYPES_LIST(X)              \
  48   X(bool, bool_value_)                   \
  49   X(int, int_value_)                     \
  50   X(Value::DoubleStorage, double_value_) \
  51   X(std::string, string_value_)          \
  52   X(Value::BlobStorage, binary_value_)   \
  53   X(Value::ListStorage, list_)           \
  54   X(Value::DictStorage, dict_)
  55
  56 #define INNER_FIELD_ALIGNMENT(type, value) alignof(type),
  57
  58   // The maximum alignment of each inner struct value field inside base::Value
  59   size_t max_inner_value_alignment =
  60       std::max({INNER_TYPES_LIST(INNER_FIELD_ALIGNMENT)});
  61
  62   // Check that base::Value has the smallest alignment possible. This would
  63   // fail if the header would contain something that has a larger alignment
  64   // than necessary.
  65   EXPECT_EQ(max_inner_value_alignment, alignof(Value));
  66
  67   // Find the offset of each inner value. Which should normally not be
  68   // larger than 4. Note that we use std::max(4, ...) because bool_value_
  69   // could be stored just after the |bool_type_| field, with an offset of
  70   // 1, and that would be ok.
  71 #define INNER_VALUE_START_OFFSET(type, value) offsetof(Value, value),
  72
  73   size_t min_inner_value_offset =
  74       std::min({INNER_TYPES_LIST(INNER_VALUE_START_OFFSET)});
  75
  76   // Inner fields may contain pointers, which have an alignment of 8
  77   // on most 64-bit platforms.
  78   size_t expected_min_offset = alignof(void*);
  79
  80   EXPECT_EQ(expected_min_offset, min_inner_value_offset);
  81
  82   // Ensure that base::Value is not larger than necessary, i.e. that there is
  83   // no un-necessary padding after the structs due to alignment constraints of
  84   // one of the inner fields.
  85 #define INNER_STRUCT_END_OFFSET(type, value) \
  86   offsetof(Value, value) + sizeof(type),
  87
  88   // The maximum size in bytes of each inner struct inside base::Value,
  89   size_t max_inner_struct_end_offset =
  90       std::max({INNER_TYPES_LIST(INNER_STRUCT_END_OFFSET)});
  91
  92   // The expected value size.
  93   size_t expected_value_size =
  94       AlignSizeTo(max_inner_struct_end_offset, alignof(Value));
  95
  96   EXPECT_EQ(expected_value_size, sizeof(Value));
  97   if (min_inner_value_offset != expected_min_offset ||
  98       expected_value_size != sizeof(Value)) {
  99     // The following are useful to understand what's wrong when the EXPECT_EQ()
 100     // above actually fail.
 101 #define PRINT_INNER_FIELD_INFO(x, y)                           \
 102   LOG(INFO) << #y " type=" #x " offset=" << offsetof(Value, y) \
 103             << " size=" << sizeof(x) << " align=" << alignof(x);
 104
 105     LOG(INFO) << "Value size=" << sizeof(Value) << " align=" << alignof(Value);
 106     INNER_TYPES_LIST(PRINT_INNER_FIELD_INFO)
 107     LOG(INFO) << "max_inner_struct_end_offset=" << max_inner_struct_end_offset;
 108   }
 109 }
 110
 111 #endif  // NDEBUG
 112
 113 TEST(ValuesTest, TestNothrow) {
 114   static_assert(std::is_nothrow_move_constructible<Value>::value,
 115                 "IsNothrowMoveConstructible");
 116   static_assert(std::is_nothrow_default_constructible<Value>::value,
 117                 "IsNothrowDefaultConstructible");
 118   static_assert(std::is_nothrow_constructible<Value, std::string&&>::value,
 119                 "IsNothrowMoveConstructibleFromString");
 120   static_assert(
 121       std::is_nothrow_constructible<Value, Value::BlobStorage&&>::value,
 122       "IsNothrowMoveConstructibleFromBlob");
 123   static_assert(
 124       std::is_nothrow_constructible<Value, Value::ListStorage&&>::value,
 125       "IsNothrowMoveConstructibleFromList");
 126   static_assert(std::is_nothrow_move_assignable<Value>::value,
 127                 "IsNothrowMoveAssignable");
 128   static_assert(
 129       std::is_nothrow_constructible<ListValue, Value::ListStorage&&>::value,
 130       "ListIsNothrowMoveConstructibleFromList");
 131 }
 132
 133 // Group of tests for the value constructors.
 134 TEST(ValuesTest, ConstructBool) {
 135   Value true_value(true);
 136   EXPECT_EQ(Value::Type::BOOLEAN, true_value.type());
 137   EXPECT_TRUE(true_value.GetBool());
 138
 139   Value false_value(false);
 140   EXPECT_EQ(Value::Type::BOOLEAN, false_value.type());
 141   EXPECT_FALSE(false_value.GetBool());
 142 }
 143
 144 TEST(ValuesTest, ConstructInt) {
 145   Value value(-37);
 146   EXPECT_EQ(Value::Type::INTEGER, value.type());
 147   EXPECT_EQ(-37, value.GetInt());
 148 }
 149
 150 TEST(ValuesTest, ConstructDouble) {
 151   Value value(-4.655);
 152   EXPECT_EQ(Value::Type::DOUBLE, value.type());
 153   EXPECT_EQ(-4.655, value.GetDouble());
 154 }
 155
 156 TEST(ValuesTest, ConstructStringFromConstCharPtr) {
 157   const char* str = "foobar";
 158   Value value(str);
 159   EXPECT_EQ(Value::Type::STRING, value.type());
 160   EXPECT_EQ("foobar", value.GetString());
 161 }
 162
 163 TEST(ValuesTest, ConstructStringFromStringPiece) {
 164   std::string str = "foobar";
 165   Value value{StringPiece(str)};
 166   EXPECT_EQ(Value::Type::STRING, value.type());
 167   EXPECT_EQ("foobar", value.GetString());
 168 }
 169
 170 TEST(ValuesTest, ConstructStringFromStdStringRRef) {
 171   std::string str = "foobar";
 172   Value value(std::move(str));
 173   EXPECT_EQ(Value::Type::STRING, value.type());
 174   EXPECT_EQ("foobar", value.GetString());
 175 }
 176
 177 TEST(ValuesTest, ConstructStringFromConstChar16Ptr) {
 178   string16 str = ASCIIToUTF16("foobar");
 179   Value value(str.c_str());
 180   EXPECT_EQ(Value::Type::STRING, value.type());
 181   EXPECT_EQ("foobar", value.GetString());
 182 }
 183
 184 TEST(ValuesTest, ConstructStringFromStringPiece16) {
 185   string16 str = ASCIIToUTF16("foobar");
 186   Value value{StringPiece16(str)};
 187   EXPECT_EQ(Value::Type::STRING, value.type());
 188   EXPECT_EQ("foobar", value.GetString());
 189 }
 190
 191 TEST(ValuesTest, ConstructBinary) {
 192   Value value(Value::BlobStorage({0xF, 0x0, 0x0, 0xB, 0xA, 0x2}));
 193   EXPECT_EQ(Value::Type::BINARY, value.type());
 194   EXPECT_EQ(Value::BlobStorage({0xF, 0x0, 0x0, 0xB, 0xA, 0x2}),
 195             value.GetBlob());
 196 }
 197
 198 TEST(ValuesTest, ConstructDict) {
 199   DictionaryValue value;
 200   EXPECT_EQ(Value::Type::DICTIONARY, value.type());
 201 }
 202
 203 TEST(ValuesTest, ConstructDictFromStorage) {
 204   Value::DictStorage storage;
 205   storage.emplace("foo", std::make_unique<Value>("bar"));
 206   {
 207     DictionaryValue value(storage);
 208     EXPECT_EQ(Value::Type::DICTIONARY, value.type());
 209     EXPECT_EQ(Value::Type::STRING, value.FindKey("foo")->type());
 210     EXPECT_EQ("bar", value.FindKey("foo")->GetString());
 211   }
 212
 213   *storage["foo"] = base::Value("baz");
 214   {
 215     DictionaryValue value(std::move(storage));
 216     EXPECT_EQ(Value::Type::DICTIONARY, value.type());
 217     EXPECT_EQ(Value::Type::STRING, value.FindKey("foo")->type());
 218     EXPECT_EQ("baz", value.FindKey("foo")->GetString());
 219   }
 220 }
 221
 222 TEST(ValuesTest, ConstructList) {
 223   ListValue value;
 224   EXPECT_EQ(Value::Type::LIST, value.type());
 225 }
 226
 227 TEST(ValuesTest, ConstructListFromStorage) {
 228   Value::ListStorage storage;
 229   storage.emplace_back("foo");
 230   {
 231     ListValue value(storage);
 232     EXPECT_EQ(Value::Type::LIST, value.type());
 233     EXPECT_EQ(1u, value.GetList().size());
 234     EXPECT_EQ(Value::Type::STRING, value.GetList()[0].type());
 235     EXPECT_EQ("foo", value.GetList()[0].GetString());
 236   }
 237
 238   storage.back() = base::Value("bar");
 239   {
 240     ListValue value(std::move(storage));
 241     EXPECT_EQ(Value::Type::LIST, value.type());
 242     EXPECT_EQ(1u, value.GetList().size());
 243     EXPECT_EQ(Value::Type::STRING, value.GetList()[0].type());
 244     EXPECT_EQ("bar", value.GetList()[0].GetString());
 245   }
 246 }
 247
 248 // Group of tests for the copy constructors and copy-assigmnent. For equality
 249 // checks comparisons of the interesting fields are done instead of relying on
 250 // Equals being correct.
 251 TEST(ValuesTest, CopyBool) {
 252   Value true_value(true);
 253   Value copied_true_value(true_value.Clone());
 254   EXPECT_EQ(true_value.type(), copied_true_value.type());
 255   EXPECT_EQ(true_value.GetBool(), copied_true_value.GetBool());
 256
 257   Value false_value(false);
 258   Value copied_false_value(false_value.Clone());
 259   EXPECT_EQ(false_value.type(), copied_false_value.type());
 260   EXPECT_EQ(false_value.GetBool(), copied_false_value.GetBool());
 261
 262   Value blank;
 263
 264   blank = true_value.Clone();
 265   EXPECT_EQ(true_value.type(), blank.type());
 266   EXPECT_EQ(true_value.GetBool(), blank.GetBool());
 267
 268   blank = false_value.Clone();
 269   EXPECT_EQ(false_value.type(), blank.type());
 270   EXPECT_EQ(false_value.GetBool(), blank.GetBool());
 271 }
 272
 273 TEST(ValuesTest, CopyInt) {
 274   Value value(74);
 275   Value copied_value(value.Clone());
 276   EXPECT_EQ(value.type(), copied_value.type());
 277   EXPECT_EQ(value.GetInt(), copied_value.GetInt());
 278
 279   Value blank;
 280
 281   blank = value.Clone();
 282   EXPECT_EQ(value.type(), blank.type());
 283   EXPECT_EQ(value.GetInt(), blank.GetInt());
 284 }
 285
 286 TEST(ValuesTest, CopyDouble) {
 287   Value value(74.896);
 288   Value copied_value(value.Clone());
 289   EXPECT_EQ(value.type(), copied_value.type());
 290   EXPECT_EQ(value.GetDouble(), copied_value.GetDouble());
 291
 292   Value blank;
 293
 294   blank = value.Clone();
 295   EXPECT_EQ(value.type(), blank.type());
 296   EXPECT_EQ(value.GetDouble(), blank.GetDouble());
 297 }
 298
 299 TEST(ValuesTest, CopyString) {
 300   Value value("foobar");
 301   Value copied_value(value.Clone());
 302   EXPECT_EQ(value.type(), copied_value.type());
 303   EXPECT_EQ(value.GetString(), copied_value.GetString());
 304
 305   Value blank;
 306
 307   blank = value.Clone();
 308   EXPECT_EQ(value.type(), blank.type());
 309   EXPECT_EQ(value.GetString(), blank.GetString());
 310 }
 311
 312 TEST(ValuesTest, CopyBinary) {
 313   Value value(Value::BlobStorage({0xF, 0x0, 0x0, 0xB, 0xA, 0x2}));
 314   Value copied_value(value.Clone());
 315   EXPECT_EQ(value.type(), copied_value.type());
 316   EXPECT_EQ(value.GetBlob(), copied_value.GetBlob());
 317
 318   Value blank;
 319
 320   blank = value.Clone();
 321   EXPECT_EQ(value.type(), blank.type());
 322   EXPECT_EQ(value.GetBlob(), blank.GetBlob());
 323 }
 324
 325 TEST(ValuesTest, CopyDictionary) {
 326   Value::DictStorage storage;
 327   storage.emplace("Int", std::make_unique<Value>(123));
 328   Value value(std::move(storage));
 329
 330   Value copied_value(value.Clone());
 331   EXPECT_EQ(value, copied_value);
 332
 333   Value blank;
 334   blank = value.Clone();
 335   EXPECT_EQ(value, blank);
 336 }
 337
 338 TEST(ValuesTest, CopyList) {
 339   Value::ListStorage storage;
 340   storage.emplace_back(123);
 341   Value value(std::move(storage));
 342
 343   Value copied_value(value.Clone());
 344   EXPECT_EQ(value, copied_value);
 345
 346   Value blank;
 347   blank = value.Clone();
 348   EXPECT_EQ(value, blank);
 349 }
 350
 351 // Group of tests for the move constructors and move-assigmnent.
 352 TEST(ValuesTest, MoveBool) {
 353   Value true_value(true);
 354   Value moved_true_value(std::move(true_value));
 355   EXPECT_EQ(Value::Type::BOOLEAN, moved_true_value.type());
 356   EXPECT_TRUE(moved_true_value.GetBool());
 357
 358   Value false_value(false);
 359   Value moved_false_value(std::move(false_value));
 360   EXPECT_EQ(Value::Type::BOOLEAN, moved_false_value.type());
 361   EXPECT_FALSE(moved_false_value.GetBool());
 362
 363   Value blank;
 364
 365   blank = Value(true);
 366   EXPECT_EQ(Value::Type::BOOLEAN, blank.type());
 367   EXPECT_TRUE(blank.GetBool());
 368
 369   blank = Value(false);
 370   EXPECT_EQ(Value::Type::BOOLEAN, blank.type());
 371   EXPECT_FALSE(blank.GetBool());
 372 }
 373
 374 TEST(ValuesTest, MoveInt) {
 375   Value value(74);
 376   Value moved_value(std::move(value));
 377   EXPECT_EQ(Value::Type::INTEGER, moved_value.type());
 378   EXPECT_EQ(74, moved_value.GetInt());
 379
 380   Value blank;
 381
 382   blank = Value(47);
 383   EXPECT_EQ(Value::Type::INTEGER, blank.type());
 384   EXPECT_EQ(47, blank.GetInt());
 385 }
 386
 387 TEST(ValuesTest, MoveDouble) {
 388   Value value(74.896);
 389   Value moved_value(std::move(value));
 390   EXPECT_EQ(Value::Type::DOUBLE, moved_value.type());
 391   EXPECT_EQ(74.896, moved_value.GetDouble());
 392
 393   Value blank;
 394
 395   blank = Value(654.38);
 396   EXPECT_EQ(Value::Type::DOUBLE, blank.type());
 397   EXPECT_EQ(654.38, blank.GetDouble());
 398 }
 399
 400 TEST(ValuesTest, MoveString) {
 401   Value value("foobar");
 402   Value moved_value(std::move(value));
 403   EXPECT_EQ(Value::Type::STRING, moved_value.type());
 404   EXPECT_EQ("foobar", moved_value.GetString());
 405
 406   Value blank;
 407
 408   blank = Value("foobar");
 409   EXPECT_EQ(Value::Type::STRING, blank.type());
 410   EXPECT_EQ("foobar", blank.GetString());
 411 }
 412
 413 TEST(ValuesTest, MoveBinary) {
 414   const Value::BlobStorage buffer = {0xF, 0x0, 0x0, 0xB, 0xA, 0x2};
 415   Value value(buffer);
 416   Value moved_value(std::move(value));
 417   EXPECT_EQ(Value::Type::BINARY, moved_value.type());
 418   EXPECT_EQ(buffer, moved_value.GetBlob());
 419
 420   Value blank;
 421
 422   blank = Value(buffer);
 423   EXPECT_EQ(Value::Type::BINARY, blank.type());
 424   EXPECT_EQ(buffer, blank.GetBlob());
 425 }
 426
 427 TEST(ValuesTest, MoveConstructDictionary) {
 428   Value::DictStorage storage;
 429   storage.emplace("Int", std::make_unique<Value>(123));
 430
 431   Value value(std::move(storage));
 432   Value moved_value(std::move(value));
 433   EXPECT_EQ(Value::Type::DICTIONARY, moved_value.type());
 434   EXPECT_EQ(123, moved_value.FindKey("Int")->GetInt());
 435 }
 436
 437 TEST(ValuesTest, MoveAssignDictionary) {
 438   Value::DictStorage storage;
 439   storage.emplace("Int", std::make_unique<Value>(123));
 440
 441   Value blank;
 442   blank = Value(std::move(storage));
 443   EXPECT_EQ(Value::Type::DICTIONARY, blank.type());
 444   EXPECT_EQ(123, blank.FindKey("Int")->GetInt());
 445 }
 446
 447 TEST(ValuesTest, MoveList) {
 448   Value::ListStorage storage;
 449   storage.emplace_back(123);
 450   Value value(storage);
 451   Value moved_value(std::move(value));
 452   EXPECT_EQ(Value::Type::LIST, moved_value.type());
 453   EXPECT_EQ(123, moved_value.GetList().back().GetInt());
 454
 455   Value blank;
 456   blank = Value(std::move(storage));
 457   EXPECT_EQ(Value::Type::LIST, blank.type());
 458   EXPECT_EQ(123, blank.GetList().back().GetInt());
 459 }
 460
 461 TEST(ValuesTest, TakeList) {
 462   // Prepare a list with a value of each type.
 463   ListValue value;
 464   value.Append(Value(Value::Type::NONE));
 465   value.Append(Value(Value::Type::BOOLEAN));
 466   value.Append(Value(Value::Type::INTEGER));
 467   value.Append(Value(Value::Type::DOUBLE));
 468   value.Append(Value(Value::Type::STRING));
 469   value.Append(Value(Value::Type::BINARY));
 470   value.Append(Value(Value::Type::LIST));
 471   value.Append(Value(Value::Type::DICTIONARY));
 472
 473   // Take ownership of the list and make sure its contents are what we expect.
 474   auto list = value.TakeList();
 475   EXPECT_EQ(8u, list.size());
 476   EXPECT_TRUE(list[0].is_none());
 477   EXPECT_TRUE(list[1].is_bool());
 478   EXPECT_TRUE(list[2].is_int());
 479   EXPECT_TRUE(list[3].is_double());
 480   EXPECT_TRUE(list[4].is_string());
 481   EXPECT_TRUE(list[5].is_blob());
 482   EXPECT_TRUE(list[6].is_list());
 483   EXPECT_TRUE(list[7].is_dict());
 484
 485   // Validate that |value| no longer contains values.
 486   EXPECT_TRUE(value.GetList().empty());
 487 }
 488
 489 TEST(ValuesTest, Append) {
 490   ListValue value;
 491   value.Append(true);
 492   EXPECT_TRUE(value.GetList().back().is_bool());
 493
 494   value.Append(123);
 495   EXPECT_TRUE(value.GetList().back().is_int());
 496
 497   value.Append(3.14);
 498   EXPECT_TRUE(value.GetList().back().is_double());
 499
 500   std::string str = "foo";
 501   value.Append(str.c_str());
 502   EXPECT_TRUE(value.GetList().back().is_string());
 503
 504   value.Append(StringPiece(str));
 505   EXPECT_TRUE(value.GetList().back().is_string());
 506
 507   value.Append(std::move(str));
 508   EXPECT_TRUE(value.GetList().back().is_string());
 509
 510   string16 str16 = ASCIIToUTF16("bar");
 511   value.Append(str16.c_str());
 512   EXPECT_TRUE(value.GetList().back().is_string());
 513
 514   value.Append(base::StringPiece16(str16));
 515   EXPECT_TRUE(value.GetList().back().is_string());
 516
 517   value.Append(Value());
 518   EXPECT_TRUE(value.GetList().back().is_none());
 519
 520   value.Append(Value(Value::Type::DICTIONARY));
 521   EXPECT_TRUE(value.GetList().back().is_dict());
 522
 523   value.Append(Value(Value::Type::LIST));
 524   EXPECT_TRUE(value.GetList().back().is_list());
 525 }
 526
 527 TEST(ValuesTest, Insert) {
 528   ListValue value;
 529   auto GetList = [&value]() -> decltype(auto) { return value.GetList(); };
 530   auto GetConstList = [&value] { return as_const(value).GetList(); };
 531
 532   auto storage_iter = value.Insert(GetList().end(), Value(true));
 533   EXPECT_TRUE(GetList().begin() == storage_iter);
 534   EXPECT_TRUE(storage_iter->is_bool());
 535
 536   auto span_iter = value.Insert(GetConstList().begin(), Value(123));
 537   EXPECT_TRUE(GetConstList().begin() == span_iter);
 538   EXPECT_TRUE(span_iter->is_int());
 539 }
 540
 541 TEST(ValuesTest, EraseListIter) {
 542   ListValue value;
 543   value.Append(1);
 544   value.Append(2);
 545   value.Append(3);
 546
 547   EXPECT_TRUE(value.EraseListIter(value.GetList().begin() + 1));
 548   EXPECT_EQ(2u, value.GetList().size());
 549   EXPECT_EQ(1, value.GetList()[0].GetInt());
 550   EXPECT_EQ(3, value.GetList()[1].GetInt());
 551
 552   EXPECT_TRUE(value.EraseListIter(value.GetList().begin()));
 553   EXPECT_EQ(1u, value.GetList().size());
 554   EXPECT_EQ(3, value.GetList()[0].GetInt());
 555
 556   EXPECT_TRUE(value.EraseListIter(value.GetList().begin()));
 557   EXPECT_TRUE(value.GetList().empty());
 558
 559   EXPECT_FALSE(value.EraseListIter(value.GetList().begin()));
 560 }
 561
 562 TEST(ValuesTest, EraseListValue) {
 563   ListValue value;
 564   value.Append(1);
 565   value.Append(2);
 566   value.Append(2);
 567   value.Append(3);
 568
 569   EXPECT_EQ(2u, value.EraseListValue(Value(2)));
 570   EXPECT_EQ(2u, value.GetList().size());
 571   EXPECT_EQ(1, value.GetList()[0].GetInt());
 572   EXPECT_EQ(3, value.GetList()[1].GetInt());
 573
 574   EXPECT_EQ(1u, value.EraseListValue(Value(1)));
 575   EXPECT_EQ(1u, value.GetList().size());
 576   EXPECT_EQ(3, value.GetList()[0].GetInt());
 577
 578   EXPECT_EQ(1u, value.EraseListValue(Value(3)));
 579   EXPECT_TRUE(value.GetList().empty());
 580
 581   EXPECT_EQ(0u, value.EraseListValue(Value(3)));
 582 }
 583
 584 TEST(ValuesTest, EraseListValueIf) {
 585   ListValue value;
 586   value.Append(1);
 587   value.Append(2);
 588   value.Append(2);
 589   value.Append(3);
 590
 591   EXPECT_EQ(3u, value.EraseListValueIf(
 592                     [](const auto& val) { return val >= Value(2); }));
 593   EXPECT_EQ(1u, value.GetList().size());
 594   EXPECT_EQ(1, value.GetList()[0].GetInt());
 595
 596   EXPECT_EQ(1u, value.EraseListValueIf([](const auto& val) { return true; }));
 597   EXPECT_TRUE(value.GetList().empty());
 598
 599   EXPECT_EQ(0u, value.EraseListValueIf([](const auto& val) { return true; }));
 600 }
 601
 602 TEST(ValuesTest, ClearList) {
 603   ListValue value;
 604   value.Append(1);
 605   value.Append(2);
 606   value.Append(3);
 607   EXPECT_EQ(3u, value.GetList().size());
 608
 609   value.ClearList();
 610   EXPECT_TRUE(value.GetList().empty());
 611
 612   // ClearList() should be idempotent.
 613   value.ClearList();
 614   EXPECT_TRUE(value.GetList().empty());
 615 }
 616
 617 TEST(ValuesTest, FindKey) {
 618   Value::DictStorage storage;
 619   storage.emplace("foo", std::make_unique<Value>("bar"));
 620   Value dict(std::move(storage));
 621   EXPECT_NE(nullptr, dict.FindKey("foo"));
 622   EXPECT_EQ(nullptr, dict.FindKey("baz"));
 623
 624   // Single not found key.
 625   bool found = dict.FindKey("notfound");
 626   EXPECT_FALSE(found);
 627 }
 628
 629 TEST(ValuesTest, FindKeyChangeValue) {
 630   Value::DictStorage storage;
 631   storage.emplace("foo", std::make_unique<Value>("bar"));
 632   Value dict(std::move(storage));
 633   Value* found = dict.FindKey("foo");
 634   EXPECT_NE(nullptr, found);
 635   EXPECT_EQ("bar", found->GetString());
 636
 637   *found = Value(123);
 638   EXPECT_EQ(123, dict.FindKey("foo")->GetInt());
 639 }
 640
 641 TEST(ValuesTest, FindKeyConst) {
 642   Value::DictStorage storage;
 643   storage.emplace("foo", std::make_unique<Value>("bar"));
 644   const Value dict(std::move(storage));
 645   EXPECT_NE(nullptr, dict.FindKey("foo"));
 646   EXPECT_EQ(nullptr, dict.FindKey("baz"));
 647 }
 648
 649 TEST(ValuesTest, FindKeyOfType) {
 650   Value::DictStorage storage;
 651   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 652   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 653   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 654   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 655   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 656   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 657   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 658   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 659
 660   Value dict(std::move(storage));
 661   EXPECT_NE(nullptr, dict.FindKeyOfType("null", Value::Type::NONE));
 662   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::BOOLEAN));
 663   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::INTEGER));
 664   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::DOUBLE));
 665   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::STRING));
 666   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::BINARY));
 667   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::LIST));
 668   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::DICTIONARY));
 669
 670   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::NONE));
 671   EXPECT_NE(nullptr, dict.FindKeyOfType("bool", Value::Type::BOOLEAN));
 672   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::INTEGER));
 673   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::DOUBLE));
 674   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::STRING));
 675   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::BINARY));
 676   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::LIST));
 677   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::DICTIONARY));
 678
 679   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::NONE));
 680   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::BOOLEAN));
 681   EXPECT_NE(nullptr, dict.FindKeyOfType("int", Value::Type::INTEGER));
 682   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::DOUBLE));
 683   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::STRING));
 684   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::BINARY));
 685   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::LIST));
 686   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::DICTIONARY));
 687
 688   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::NONE));
 689   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::BOOLEAN));
 690   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::INTEGER));
 691   EXPECT_NE(nullptr, dict.FindKeyOfType("double", Value::Type::DOUBLE));
 692   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::STRING));
 693   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::BINARY));
 694   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::LIST));
 695   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::DICTIONARY));
 696
 697   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::NONE));
 698   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::BOOLEAN));
 699   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::INTEGER));
 700   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::DOUBLE));
 701   EXPECT_NE(nullptr, dict.FindKeyOfType("string", Value::Type::STRING));
 702   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::BINARY));
 703   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::LIST));
 704   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::DICTIONARY));
 705
 706   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::NONE));
 707   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::BOOLEAN));
 708   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::INTEGER));
 709   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::DOUBLE));
 710   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::STRING));
 711   EXPECT_NE(nullptr, dict.FindKeyOfType("blob", Value::Type::BINARY));
 712   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::LIST));
 713   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::DICTIONARY));
 714
 715   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::NONE));
 716   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::BOOLEAN));
 717   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::INTEGER));
 718   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::DOUBLE));
 719   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::STRING));
 720   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::BINARY));
 721   EXPECT_NE(nullptr, dict.FindKeyOfType("list", Value::Type::LIST));
 722   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::DICTIONARY));
 723
 724   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::NONE));
 725   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::BOOLEAN));
 726   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::INTEGER));
 727   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::DOUBLE));
 728   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::STRING));
 729   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::BINARY));
 730   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::LIST));
 731   EXPECT_NE(nullptr, dict.FindKeyOfType("dict", Value::Type::DICTIONARY));
 732 }
 733
 734 TEST(ValuesTest, FindKeyOfTypeConst) {
 735   Value::DictStorage storage;
 736   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 737   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 738   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 739   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 740   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 741   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 742   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 743   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 744
 745   const Value dict(std::move(storage));
 746   EXPECT_NE(nullptr, dict.FindKeyOfType("null", Value::Type::NONE));
 747   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::BOOLEAN));
 748   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::INTEGER));
 749   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::DOUBLE));
 750   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::STRING));
 751   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::BINARY));
 752   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::LIST));
 753   EXPECT_EQ(nullptr, dict.FindKeyOfType("null", Value::Type::DICTIONARY));
 754
 755   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::NONE));
 756   EXPECT_NE(nullptr, dict.FindKeyOfType("bool", Value::Type::BOOLEAN));
 757   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::INTEGER));
 758   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::DOUBLE));
 759   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::STRING));
 760   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::BINARY));
 761   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::LIST));
 762   EXPECT_EQ(nullptr, dict.FindKeyOfType("bool", Value::Type::DICTIONARY));
 763
 764   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::NONE));
 765   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::BOOLEAN));
 766   EXPECT_NE(nullptr, dict.FindKeyOfType("int", Value::Type::INTEGER));
 767   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::DOUBLE));
 768   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::STRING));
 769   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::BINARY));
 770   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::LIST));
 771   EXPECT_EQ(nullptr, dict.FindKeyOfType("int", Value::Type::DICTIONARY));
 772
 773   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::NONE));
 774   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::BOOLEAN));
 775   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::INTEGER));
 776   EXPECT_NE(nullptr, dict.FindKeyOfType("double", Value::Type::DOUBLE));
 777   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::STRING));
 778   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::BINARY));
 779   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::LIST));
 780   EXPECT_EQ(nullptr, dict.FindKeyOfType("double", Value::Type::DICTIONARY));
 781
 782   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::NONE));
 783   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::BOOLEAN));
 784   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::INTEGER));
 785   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::DOUBLE));
 786   EXPECT_NE(nullptr, dict.FindKeyOfType("string", Value::Type::STRING));
 787   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::BINARY));
 788   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::LIST));
 789   EXPECT_EQ(nullptr, dict.FindKeyOfType("string", Value::Type::DICTIONARY));
 790
 791   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::NONE));
 792   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::BOOLEAN));
 793   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::INTEGER));
 794   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::DOUBLE));
 795   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::STRING));
 796   EXPECT_NE(nullptr, dict.FindKeyOfType("blob", Value::Type::BINARY));
 797   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::LIST));
 798   EXPECT_EQ(nullptr, dict.FindKeyOfType("blob", Value::Type::DICTIONARY));
 799
 800   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::NONE));
 801   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::BOOLEAN));
 802   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::INTEGER));
 803   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::DOUBLE));
 804   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::STRING));
 805   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::BINARY));
 806   EXPECT_NE(nullptr, dict.FindKeyOfType("list", Value::Type::LIST));
 807   EXPECT_EQ(nullptr, dict.FindKeyOfType("list", Value::Type::DICTIONARY));
 808
 809   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::NONE));
 810   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::BOOLEAN));
 811   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::INTEGER));
 812   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::DOUBLE));
 813   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::STRING));
 814   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::BINARY));
 815   EXPECT_EQ(nullptr, dict.FindKeyOfType("dict", Value::Type::LIST));
 816   EXPECT_NE(nullptr, dict.FindKeyOfType("dict", Value::Type::DICTIONARY));
 817 }
 818
 819 TEST(ValuesTest, FindBoolKey) {
 820   Value::DictStorage storage;
 821   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 822   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 823   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 824   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 825   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 826   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 827   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 828   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 829
 830   const Value dict(std::move(storage));
 831   EXPECT_EQ(base::nullopt, dict.FindBoolKey("null"));
 832   EXPECT_NE(base::nullopt, dict.FindBoolKey("bool"));
 833   EXPECT_EQ(base::nullopt, dict.FindBoolKey("int"));
 834   EXPECT_EQ(base::nullopt, dict.FindBoolKey("double"));
 835   EXPECT_EQ(base::nullopt, dict.FindBoolKey("string"));
 836   EXPECT_EQ(base::nullopt, dict.FindBoolKey("blob"));
 837   EXPECT_EQ(base::nullopt, dict.FindBoolKey("list"));
 838   EXPECT_EQ(base::nullopt, dict.FindBoolKey("dict"));
 839 }
 840
 841 TEST(ValuesTest, FindIntKey) {
 842   Value::DictStorage storage;
 843   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 844   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 845   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 846   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 847   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 848   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 849   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 850   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 851
 852   const Value dict(std::move(storage));
 853   EXPECT_EQ(base::nullopt, dict.FindIntKey("null"));
 854   EXPECT_EQ(base::nullopt, dict.FindIntKey("bool"));
 855   EXPECT_NE(base::nullopt, dict.FindIntKey("int"));
 856   EXPECT_EQ(base::nullopt, dict.FindIntKey("double"));
 857   EXPECT_EQ(base::nullopt, dict.FindIntKey("string"));
 858   EXPECT_EQ(base::nullopt, dict.FindIntKey("blob"));
 859   EXPECT_EQ(base::nullopt, dict.FindIntKey("list"));
 860   EXPECT_EQ(base::nullopt, dict.FindIntKey("dict"));
 861 }
 862
 863 TEST(ValuesTest, FindDoubleKey) {
 864   Value::DictStorage storage;
 865   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 866   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 867   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 868   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 869   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 870   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 871   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 872   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 873
 874   const Value dict(std::move(storage));
 875   EXPECT_EQ(base::nullopt, dict.FindDoubleKey("null"));
 876   EXPECT_EQ(base::nullopt, dict.FindDoubleKey("bool"));
 877   EXPECT_NE(base::nullopt, dict.FindDoubleKey("int"));
 878   EXPECT_NE(base::nullopt, dict.FindDoubleKey("double"));
 879   EXPECT_EQ(base::nullopt, dict.FindDoubleKey("string"));
 880   EXPECT_EQ(base::nullopt, dict.FindDoubleKey("blob"));
 881   EXPECT_EQ(base::nullopt, dict.FindDoubleKey("list"));
 882   EXPECT_EQ(base::nullopt, dict.FindDoubleKey("dict"));
 883 }
 884
 885 TEST(ValuesTest, FindStringKey) {
 886   Value::DictStorage storage;
 887   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 888   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 889   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 890   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 891   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 892   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 893   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 894   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 895
 896   const Value dict(std::move(storage));
 897   EXPECT_EQ(nullptr, dict.FindStringKey("null"));
 898   EXPECT_EQ(nullptr, dict.FindStringKey("bool"));
 899   EXPECT_EQ(nullptr, dict.FindStringKey("int"));
 900   EXPECT_EQ(nullptr, dict.FindStringKey("double"));
 901   EXPECT_NE(nullptr, dict.FindStringKey("string"));
 902   EXPECT_EQ(nullptr, dict.FindStringKey("blob"));
 903   EXPECT_EQ(nullptr, dict.FindStringKey("list"));
 904   EXPECT_EQ(nullptr, dict.FindStringKey("dict"));
 905 }
 906
 907 TEST(ValuesTest, MutableFindStringKey) {
 908   Value::DictStorage storage;
 909   storage.emplace("string", std::make_unique<Value>("foo"));
 910   Value dict(std::move(storage));
 911
 912   *(dict.FindStringKey("string")) = "bar";
 913
 914   Value::DictStorage expected_storage;
 915   expected_storage.emplace("string", std::make_unique<Value>("bar"));
 916   Value expected_dict(std::move(expected_storage));
 917
 918   EXPECT_EQ(expected_dict, dict);
 919 }
 920
 921 TEST(ValuesTest, FindDictKey) {
 922   Value::DictStorage storage;
 923   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 924   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 925   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 926   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 927   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 928   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 929   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 930   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 931
 932   const Value dict(std::move(storage));
 933   EXPECT_EQ(nullptr, dict.FindDictKey("null"));
 934   EXPECT_EQ(nullptr, dict.FindDictKey("bool"));
 935   EXPECT_EQ(nullptr, dict.FindDictKey("int"));
 936   EXPECT_EQ(nullptr, dict.FindDictKey("double"));
 937   EXPECT_EQ(nullptr, dict.FindDictKey("string"));
 938   EXPECT_EQ(nullptr, dict.FindDictKey("blob"));
 939   EXPECT_EQ(nullptr, dict.FindDictKey("list"));
 940   EXPECT_NE(nullptr, dict.FindDictKey("dict"));
 941 }
 942
 943 TEST(ValuesTest, FindListKey) {
 944   Value::DictStorage storage;
 945   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 946   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 947   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 948   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 949   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 950   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 951   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 952   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 953
 954   const Value dict(std::move(storage));
 955   EXPECT_EQ(nullptr, dict.FindListKey("null"));
 956   EXPECT_EQ(nullptr, dict.FindListKey("bool"));
 957   EXPECT_EQ(nullptr, dict.FindListKey("int"));
 958   EXPECT_EQ(nullptr, dict.FindListKey("double"));
 959   EXPECT_EQ(nullptr, dict.FindListKey("string"));
 960   EXPECT_EQ(nullptr, dict.FindListKey("blob"));
 961   EXPECT_NE(nullptr, dict.FindListKey("list"));
 962   EXPECT_EQ(nullptr, dict.FindListKey("dict"));
 963 }
 964
 965 TEST(ValuesTest, FindBlobKey) {
 966   Value::DictStorage storage;
 967   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 968   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 969   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 970   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 971   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 972   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 973   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 974   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 975
 976   const Value dict(std::move(storage));
 977   EXPECT_EQ(nullptr, dict.FindBlobKey("null"));
 978   EXPECT_EQ(nullptr, dict.FindBlobKey("bool"));
 979   EXPECT_EQ(nullptr, dict.FindBlobKey("int"));
 980   EXPECT_EQ(nullptr, dict.FindBlobKey("double"));
 981   EXPECT_EQ(nullptr, dict.FindBlobKey("string"));
 982   EXPECT_NE(nullptr, dict.FindBlobKey("blob"));
 983   EXPECT_EQ(nullptr, dict.FindBlobKey("list"));
 984   EXPECT_EQ(nullptr, dict.FindBlobKey("dict"));
 985 }
 986
 987 TEST(ValuesTest, SetKey) {
 988   Value::DictStorage storage;
 989   storage.emplace("null", std::make_unique<Value>(Value::Type::NONE));
 990   storage.emplace("bool", std::make_unique<Value>(Value::Type::BOOLEAN));
 991   storage.emplace("int", std::make_unique<Value>(Value::Type::INTEGER));
 992   storage.emplace("double", std::make_unique<Value>(Value::Type::DOUBLE));
 993   storage.emplace("string", std::make_unique<Value>(Value::Type::STRING));
 994   storage.emplace("blob", std::make_unique<Value>(Value::Type::BINARY));
 995   storage.emplace("list", std::make_unique<Value>(Value::Type::LIST));
 996   storage.emplace("dict", std::make_unique<Value>(Value::Type::DICTIONARY));
 997
 998   Value dict(Value::Type::DICTIONARY);
 999   dict.SetKey(StringPiece("null"), Value(Value::Type::NONE));
1000   dict.SetKey(StringPiece("bool"), Value(Value::Type::BOOLEAN));
1001   dict.SetKey(std::string("int"), Value(Value::Type::INTEGER));
1002   dict.SetKey(std::string("double"), Value(Value::Type::DOUBLE));
1003   dict.SetKey(std::string("string"), Value(Value::Type::STRING));
1004   dict.SetKey("blob", Value(Value::Type::BINARY));
1005   dict.SetKey("list", Value(Value::Type::LIST));
1006   dict.SetKey("dict", Value(Value::Type::DICTIONARY));
1007
1008   EXPECT_EQ(Value(std::move(storage)), dict);
1009 }
1010
1011 TEST(ValuesTest, SetBoolKey) {
1012   base::Optional<bool> value;
1013
1014   DictionaryValue dict;
1015   dict.SetBoolKey("true_key", true);
1016   dict.SetBoolKey("false_key", false);
1017
1018   value = dict.FindBoolKey("true_key");
1019   ASSERT_TRUE(value);
1020   ASSERT_TRUE(*value);
1021
1022   value = dict.FindBoolKey("false_key");
1023   ASSERT_TRUE(value);
1024   ASSERT_FALSE(*value);
1025
1026   value = dict.FindBoolKey("missing_key");
1027   ASSERT_FALSE(value);
1028 }
1029
1030 TEST(ValuesTest, SetIntKey) {
1031   base::Optional<int> value;
1032
1033   DictionaryValue dict;
1034   dict.SetIntKey("one_key", 1);
1035   dict.SetIntKey("minus_one_key", -1);
1036
1037   value = dict.FindIntKey("one_key");
1038   ASSERT_TRUE(value);
1039   ASSERT_EQ(1, *value);
1040
1041   value = dict.FindIntKey("minus_one_key");
1042   ASSERT_TRUE(value);
1043   ASSERT_EQ(-1, *value);
1044
1045   value = dict.FindIntKey("missing_key");
1046   ASSERT_FALSE(value);
1047 }
1048
1049 TEST(ValuesTest, SetDoubleKey) {
1050   DictionaryValue dict;
1051   dict.SetDoubleKey("one_key", 1.0);
1052   dict.SetDoubleKey("minus_one_key", -1.0);
1053   dict.SetDoubleKey("pi_key", 3.1415);
1054
1055   // NOTE: Use FindKey() instead of FindDoubleKey() because the latter will
1056   // auto-convert integers to doubles as well.
1057   const Value* value;
1058
1059   value = dict.FindKey("one_key");
1060   ASSERT_TRUE(value);
1061   EXPECT_TRUE(value->is_double());
1062   EXPECT_EQ(1.0, value->GetDouble());
1063
1064   value = dict.FindKey("minus_one_key");
1065   ASSERT_TRUE(value);
1066   EXPECT_TRUE(value->is_double());
1067   EXPECT_EQ(-1.0, value->GetDouble());
1068
1069   value = dict.FindKey("pi_key");
1070   ASSERT_TRUE(value);
1071   EXPECT_TRUE(value->is_double());
1072   EXPECT_EQ(3.1415, value->GetDouble());
1073 }
1074
1075 TEST(ValuesTest, SetStringKey) {
1076   DictionaryValue dict;
1077   dict.SetStringKey("one_key", "one");
1078   dict.SetStringKey("hello_key", "hello world");
1079
1080   std::string movable_value("movable_value");
1081   dict.SetStringKey("movable_key", std::move(movable_value));
1082   ASSERT_TRUE(movable_value.empty());
1083
1084   const std::string* value;
1085
1086   value = dict.FindStringKey("one_key");
1087   ASSERT_TRUE(value);
1088   ASSERT_EQ("one", *value);
1089
1090   value = dict.FindStringKey("hello_key");
1091   ASSERT_TRUE(value);
1092   ASSERT_EQ("hello world", *value);
1093
1094   value = dict.FindStringKey("movable_key");
1095   ASSERT_TRUE(value);
1096   ASSERT_EQ("movable_value", *value);
1097
1098   value = dict.FindStringKey("missing_key");
1099   ASSERT_FALSE(value);
1100 }
1101
1102 TEST(ValuesTest, FindPath) {
1103   // Construct a dictionary path {root}.foo.bar = 123
1104   Value foo(Value::Type::DICTIONARY);
1105   foo.SetKey("bar", Value(123));
1106
1107   Value root(Value::Type::DICTIONARY);
1108   root.SetKey("foo", std::move(foo));
1109
1110   // No key (stupid but well-defined and takes work to prevent).
1111   Value* found = root.FindPath("");
1112   EXPECT_EQ(&root, found);
1113
1114   // Double key, second not found.
1115   found = root.FindPath("foo.notfound");
1116   EXPECT_FALSE(found);
1117
1118   // Double key, found.
1119   found = root.FindPath("foo.bar");
1120   EXPECT_TRUE(found);
1121   EXPECT_TRUE(found->is_int());
1122   EXPECT_EQ(123, found->GetInt());
1123 }
1124
1125 TEST(ValuesTest, SetPath) {
1126   Value root(Value::Type::DICTIONARY);
1127
1128   Value* inserted = root.SetPath("one.two", Value(123));
1129   Value* found = root.FindPathOfType("one.two", Value::Type::INTEGER);
1130   ASSERT_TRUE(found);
1131   EXPECT_EQ(inserted, found);
1132   EXPECT_EQ(123, found->GetInt());
1133
1134   inserted = root.SetPath("foo.bar", Value(123));
1135   found = root.FindPathOfType("foo.bar", Value::Type::INTEGER);
1136   ASSERT_TRUE(found);
1137   EXPECT_EQ(inserted, found);
1138   EXPECT_EQ(123, found->GetInt());
1139
1140   // Overwrite with a different value.
1141   root.SetPath("foo.bar", Value("hello"));
1142   found = root.FindPathOfType("foo.bar", Value::Type::STRING);
1143   ASSERT_TRUE(found);
1144   EXPECT_EQ("hello", found->GetString());
1145
1146   // Can't change existing non-dictionary keys to dictionaries.
1147   found = root.SetPath("foo.bar.baz", Value(123));
1148   EXPECT_FALSE(found);
1149 }
1150
1151 TEST(ValuesTest, SetBoolPath) {
1152   DictionaryValue root;
1153   Value* inserted = root.SetBoolPath("foo.bar", true);
1154   Value* found = root.FindPath("foo.bar");
1155   ASSERT_TRUE(found);
1156   EXPECT_EQ(inserted, found);
1157   ASSERT_TRUE(found->is_bool());
1158   EXPECT_TRUE(found->GetBool());
1159
1160   // Overwrite with a different value.
1161   root.SetBoolPath("foo.bar", false);
1162   found = root.FindPath("foo.bar");
1163   ASSERT_TRUE(found);
1164   ASSERT_TRUE(found->is_bool());
1165   EXPECT_FALSE(found->GetBool());
1166
1167   // Can't change existing non-dictionary keys.
1168   ASSERT_FALSE(root.SetBoolPath("foo.bar.zoo", true));
1169 }
1170
1171 TEST(ValuesTest, SetIntPath) {
1172   DictionaryValue root;
1173   Value* inserted = root.SetIntPath("foo.bar", 123);
1174   Value* found = root.FindPath("foo.bar");
1175   ASSERT_TRUE(found);
1176   EXPECT_EQ(inserted, found);
1177   ASSERT_TRUE(found->is_int());
1178   EXPECT_EQ(123, found->GetInt());
1179
1180   // Overwrite with a different value.
1181   root.SetIntPath("foo.bar", 234);
1182   found = root.FindPath("foo.bar");
1183   ASSERT_TRUE(found);
1184   ASSERT_TRUE(found->is_int());
1185   EXPECT_EQ(234, found->GetInt());
1186
1187   // Can't change existing non-dictionary keys.
1188   ASSERT_FALSE(root.SetIntPath("foo.bar.zoo", 567));
1189 }
1190
1191 TEST(ValuesTest, SetDoublePath) {
1192   DictionaryValue root;
1193   Value* inserted = root.SetDoublePath("foo.bar", 1.23);
1194   Value* found = root.FindPath("foo.bar");
1195   ASSERT_TRUE(found);
1196   EXPECT_EQ(inserted, found);
1197   ASSERT_TRUE(found->is_double());
1198   EXPECT_EQ(1.23, found->GetDouble());
1199
1200   // Overwrite with a different value.
1201   root.SetDoublePath("foo.bar", 2.34);
1202   found = root.FindPath("foo.bar");
1203   ASSERT_TRUE(found);
1204   ASSERT_TRUE(found->is_double());
1205   EXPECT_EQ(2.34, found->GetDouble());
1206
1207   // Can't change existing non-dictionary keys.
1208   ASSERT_FALSE(root.SetDoublePath("foo.bar.zoo", 5.67));
1209 }
1210
1211 TEST(ValuesTest, SetStringPath) {
1212   DictionaryValue root;
1213   Value* inserted = root.SetStringPath("foo.bar", "hello world");
1214   Value* found = root.FindPath("foo.bar");
1215   ASSERT_TRUE(found);
1216   EXPECT_EQ(inserted, found);
1217   ASSERT_TRUE(found->is_string());
1218   EXPECT_EQ("hello world", found->GetString());
1219
1220   // Overwrite with a different value.
1221   root.SetStringPath("foo.bar", "bonjour monde");
1222   found = root.FindPath("foo.bar");
1223   ASSERT_TRUE(found);
1224   ASSERT_TRUE(found->is_string());
1225   EXPECT_EQ("bonjour monde", found->GetString());
1226
1227   ASSERT_TRUE(root.SetStringPath("foo.bar", StringPiece("rah rah")));
1228   ASSERT_TRUE(root.SetStringPath("foo.bar", std::string("temp string")));
1229   ASSERT_TRUE(root.SetStringPath("foo.bar", UTF8ToUTF16("temp string")));
1230
1231   // Can't change existing non-dictionary keys.
1232   ASSERT_FALSE(root.SetStringPath("foo.bar.zoo", "ola mundo"));
1233 }
1234
1235 TEST(ValuesTest, RemoveKey) {
1236   Value root(Value::Type::DICTIONARY);
1237   root.SetKey("one", Value(123));
1238
1239   // Removal of missing key should fail.
1240   EXPECT_FALSE(root.RemoveKey("two"));
1241
1242   // Removal of existing key should succeed.
1243   EXPECT_TRUE(root.RemoveKey("one"));
1244
1245   // Second removal of previously existing key should fail.
1246   EXPECT_FALSE(root.RemoveKey("one"));
1247 }
1248
1249 TEST(ValuesTest, ExtractKey) {
1250   Value root(Value::Type::DICTIONARY);
1251   root.SetKey("one", Value(123));
1252
1253   // Extraction of missing key should fail.
1254   EXPECT_EQ(nullopt, root.ExtractKey("two"));
1255
1256   // Extraction of existing key should succeed.
1257   EXPECT_EQ(Value(123), root.ExtractKey("one"));
1258
1259   // Second extraction of previously existing key should fail.
1260   EXPECT_EQ(nullopt, root.ExtractKey("one"));
1261 }
1262
1263 TEST(ValuesTest, RemovePath) {
1264   Value root(Value::Type::DICTIONARY);
1265   root.SetPath("one.two.three", Value(123));
1266
1267   // Removal of missing key should fail.
1268   EXPECT_FALSE(root.RemovePath("one.two.four"));
1269
1270   // Removal of existing key should succeed.
1271   EXPECT_TRUE(root.RemovePath("one.two.three"));
1272
1273   // Second removal of previously existing key should fail.
1274   EXPECT_FALSE(root.RemovePath("one.two.three"));
1275
1276   // Intermediate empty dictionaries should be cleared.
1277   EXPECT_EQ(nullptr, root.FindKey("one"));
1278
1279   root.SetPath("one.two.three", Value(123));
1280   root.SetPath("one.two.four", Value(124));
1281
1282   EXPECT_TRUE(root.RemovePath("one.two.three"));
1283   // Intermediate non-empty dictionaries should be kept.
1284   EXPECT_NE(nullptr, root.FindKey("one"));
1285   EXPECT_NE(nullptr, root.FindPath("one.two"));
1286   EXPECT_NE(nullptr, root.FindPath("one.two.four"));
1287 }
1288
1289 TEST(ValuesTest, ExtractPath) {
1290   Value root(Value::Type::DICTIONARY);
1291   root.SetPath("one.two.three", Value(123));
1292
1293   // Extraction of missing key should fail.
1294   EXPECT_EQ(nullopt, root.ExtractPath("one.two.four"));
1295
1296   // Extraction of existing key should succeed.
1297   EXPECT_EQ(Value(123), root.ExtractPath("one.two.three"));
1298
1299   // Second extraction of previously existing key should fail.
1300   EXPECT_EQ(nullopt, root.ExtractPath("one.two.three"));
1301
1302   // Intermediate empty dictionaries should be cleared.
1303   EXPECT_EQ(nullptr, root.FindKey("one"));
1304
1305   root.SetPath("one.two.three", Value(123));
1306   root.SetPath("one.two.four", Value(124));
1307
1308   EXPECT_EQ(Value(123), root.ExtractPath("one.two.three"));
1309   // Intermediate non-empty dictionaries should be kept.
1310   EXPECT_NE(nullptr, root.FindKey("one"));
1311   EXPECT_NE(nullptr, root.FindPath("one.two"));
1312   EXPECT_NE(nullptr, root.FindPath("one.two.four"));
1313 }
1314
1315 TEST(ValuesTest, Basic) {
1316   // Test basic dictionary getting/setting
1317   DictionaryValue settings;
1318   ASSERT_FALSE(settings.FindPath("global.homepage"));
1319
1320   ASSERT_FALSE(settings.FindKey("global"));
1321   settings.SetKey("global", Value(true));
1322   ASSERT_TRUE(settings.FindKey("global"));
1323   settings.RemoveKey("global");
1324   settings.SetPath("global.homepage", Value("http://scurvy.com"));
1325   ASSERT_TRUE(settings.FindKey("global"));
1326   const std::string* homepage = settings.FindStringPath("global.homepage");
1327   ASSERT_TRUE(homepage);
1328   ASSERT_EQ(std::string("http://scurvy.com"), *homepage);
1329
1330   // Test storing a dictionary in a list.
1331   ASSERT_FALSE(settings.FindPath("global.toolbar.bookmarks"));
1332
1333   ListValue new_toolbar_bookmarks;
1334   settings.SetPath("global.toolbar.bookmarks",
1335                    std::move(new_toolbar_bookmarks));
1336   Value* toolbar_bookmarks = settings.FindListPath("global.toolbar.bookmarks");
1337   ASSERT_TRUE(toolbar_bookmarks);
1338
1339   DictionaryValue new_bookmark;
1340   new_bookmark.SetKey("name", Value("Froogle"));
1341   new_bookmark.SetKey("url", Value("http://froogle.com"));
1342   toolbar_bookmarks->Append(std::move(new_bookmark));
1343
1344   Value* bookmark_list = settings.FindPath("global.toolbar.bookmarks");
1345   ASSERT_TRUE(bookmark_list);
1346   ASSERT_EQ(1U, bookmark_list->GetList().size());
1347   Value* bookmark = &bookmark_list->GetList()[0];
1348   ASSERT_TRUE(bookmark);
1349   ASSERT_TRUE(bookmark->is_dict());
1350   const std::string* bookmark_name = bookmark->FindStringKey("name");
1351   ASSERT_TRUE(bookmark_name);
1352   ASSERT_EQ(std::string("Froogle"), *bookmark_name);
1353   const std::string* bookmark_url = bookmark->FindStringKey("url");
1354   ASSERT_TRUE(bookmark_url);
1355   ASSERT_EQ(std::string("http://froogle.com"), *bookmark_url);
1356 }
1357
1358 TEST(ValuesTest, List) {
1359   std::unique_ptr<ListValue> mixed_list(new ListValue());
1360   mixed_list->Set(0, std::make_unique<Value>(true));
1361   mixed_list->Set(1, std::make_unique<Value>(42));
1362   mixed_list->Set(2, std::make_unique<Value>(88.8));
1363   mixed_list->Set(3, std::make_unique<Value>("foo"));
1364   ASSERT_EQ(4u, mixed_list->GetSize());
1365
1366   Value* value = nullptr;
1367   bool bool_value = false;
1368   int int_value = 0;
1369   double double_value = 0.0;
1370   std::string string_value;
1371
1372   ASSERT_FALSE(mixed_list->Get(4, &value));
1373
1374   ASSERT_FALSE(mixed_list->GetInteger(0, &int_value));
1375   ASSERT_EQ(0, int_value);
1376   ASSERT_FALSE(mixed_list->GetBoolean(1, &bool_value));
1377   ASSERT_FALSE(bool_value);
1378   ASSERT_FALSE(mixed_list->GetString(2, &string_value));
1379   ASSERT_EQ("", string_value);
1380   ASSERT_FALSE(mixed_list->GetInteger(2, &int_value));
1381   ASSERT_EQ(0, int_value);
1382   ASSERT_FALSE(mixed_list->GetBoolean(3, &bool_value));
1383   ASSERT_FALSE(bool_value);
1384
1385   ASSERT_TRUE(mixed_list->GetBoolean(0, &bool_value));
1386   ASSERT_TRUE(bool_value);
1387   ASSERT_TRUE(mixed_list->GetInteger(1, &int_value));
1388   ASSERT_EQ(42, int_value);
1389   // implicit conversion from Integer to Double should be possible.
1390   ASSERT_TRUE(mixed_list->GetDouble(1, &double_value));
1391   ASSERT_EQ(42, double_value);
1392   ASSERT_TRUE(mixed_list->GetDouble(2, &double_value));
1393   ASSERT_EQ(88.8, double_value);
1394   ASSERT_TRUE(mixed_list->GetString(3, &string_value));
1395   ASSERT_EQ("foo", string_value);
1396
1397   // Try searching in the mixed list.
1398   base::Value sought_value(42);
1399   base::Value not_found_value(false);
1400
1401   ASSERT_NE(mixed_list->end(), mixed_list->Find(sought_value));
1402   ASSERT_TRUE((*mixed_list->Find(sought_value)).GetAsInteger(&int_value));
1403   ASSERT_EQ(42, int_value);
1404   ASSERT_EQ(mixed_list->end(), mixed_list->Find(not_found_value));
1405 }
1406
1407 TEST(ValuesTest, BinaryValue) {
1408   // Default constructor creates a BinaryValue with a buffer of size 0.
1409   auto binary = std::make_unique<Value>(Value::Type::BINARY);
1410   ASSERT_TRUE(binary.get());
1411   ASSERT_TRUE(binary->GetBlob().empty());
1412
1413   // Test the common case of a non-empty buffer
1414   Value::BlobStorage buffer(15);
1415   uint8_t* original_buffer = buffer.data();
1416   binary.reset(new Value(std::move(buffer)));
1417   ASSERT_TRUE(binary.get());
1418   ASSERT_TRUE(binary->GetBlob().data());
1419   ASSERT_EQ(original_buffer, binary->GetBlob().data());
1420   ASSERT_EQ(15U, binary->GetBlob().size());
1421
1422   char stack_buffer[42];
1423   memset(stack_buffer, '!', 42);
1424   binary = Value::CreateWithCopiedBuffer(stack_buffer, 42);
1425   ASSERT_TRUE(binary.get());
1426   ASSERT_TRUE(binary->GetBlob().data());
1427   ASSERT_NE(stack_buffer,
1428             reinterpret_cast<const char*>(binary->GetBlob().data()));
1429   ASSERT_EQ(42U, binary->GetBlob().size());
1430   ASSERT_EQ(0, memcmp(stack_buffer, binary->GetBlob().data(),
1431                       binary->GetBlob().size()));
1432 }
1433
1434 TEST(ValuesTest, StringValue) {
1435   // Test overloaded StringValue constructor.
1436   std::unique_ptr<Value> narrow_value(new Value("narrow"));
1437   ASSERT_TRUE(narrow_value.get());
1438   ASSERT_TRUE(narrow_value->is_string());
1439   std::unique_ptr<Value> utf16_value(new Value(ASCIIToUTF16("utf16")));
1440   ASSERT_TRUE(utf16_value.get());
1441   ASSERT_TRUE(utf16_value->is_string());
1442
1443   // Test overloaded GetAsString.
1444   std::string narrow = "http://google.com";
1445   string16 utf16 = ASCIIToUTF16("http://google.com");
1446   const Value* string_value = nullptr;
1447   ASSERT_TRUE(narrow_value->GetAsString(&narrow));
1448   ASSERT_TRUE(narrow_value->GetAsString(&utf16));
1449   ASSERT_TRUE(narrow_value->GetAsString(&string_value));
1450   ASSERT_EQ(std::string("narrow"), narrow);
1451   ASSERT_EQ(ASCIIToUTF16("narrow"), utf16);
1452   ASSERT_EQ(string_value->GetString(), narrow);
1453
1454   ASSERT_TRUE(utf16_value->GetAsString(&narrow));
1455   ASSERT_TRUE(utf16_value->GetAsString(&utf16));
1456   ASSERT_TRUE(utf16_value->GetAsString(&string_value));
1457   ASSERT_EQ(std::string("utf16"), narrow);
1458   ASSERT_EQ(ASCIIToUTF16("utf16"), utf16);
1459   ASSERT_EQ(string_value->GetString(), narrow);
1460
1461   // Don't choke on NULL values.
1462   ASSERT_TRUE(narrow_value->GetAsString(static_cast<string16*>(nullptr)));
1463   ASSERT_TRUE(narrow_value->GetAsString(static_cast<std::string*>(nullptr)));
1464   ASSERT_TRUE(narrow_value->GetAsString(static_cast<const Value**>(nullptr)));
1465 }
1466
1467 TEST(ValuesTest, ListDeletion) {
1468   ListValue list;
1469   list.Append(std::make_unique<Value>());
1470   EXPECT_FALSE(list.empty());
1471   list.Clear();
1472   EXPECT_TRUE(list.empty());
1473 }
1474
1475 TEST(ValuesTest, ListRemoval) {
1476   std::unique_ptr<Value> removed_item;
1477
1478   {
1479     ListValue list;
1480     list.Append(std::make_unique<Value>());
1481     EXPECT_EQ(1U, list.GetSize());
1482     EXPECT_FALSE(list.Remove(std::numeric_limits<size_t>::max(),
1483                              &removed_item));
1484     EXPECT_FALSE(list.Remove(1, &removed_item));
1485     EXPECT_TRUE(list.Remove(0, &removed_item));
1486     ASSERT_TRUE(removed_item);
1487     EXPECT_EQ(0U, list.GetSize());
1488   }
1489   removed_item.reset();
1490
1491   {
1492     ListValue list;
1493     list.Append(std::make_unique<Value>());
1494     EXPECT_TRUE(list.Remove(0, nullptr));
1495     EXPECT_EQ(0U, list.GetSize());
1496   }
1497
1498   {
1499     ListValue list;
1500     auto value = std::make_unique<Value>();
1501     Value original_value = value->Clone();
1502     list.Append(std::move(value));
1503     size_t index = 0;
1504     list.Remove(original_value, &index);
1505     EXPECT_EQ(0U, index);
1506     EXPECT_EQ(0U, list.GetSize());
1507   }
1508 }
1509
1510 TEST(ValuesTest, DictionaryDeletion) {
1511   std::string key = "test";
1512   DictionaryValue dict;
1513   dict.Set(key, std::make_unique<Value>());
1514   EXPECT_FALSE(dict.empty());
1515   EXPECT_FALSE(dict.DictEmpty());
1516   EXPECT_EQ(1U, dict.DictSize());
1517   dict.Clear();
1518   EXPECT_TRUE(dict.empty());
1519   EXPECT_TRUE(dict.DictEmpty());
1520   EXPECT_EQ(0U, dict.DictSize());
1521 }
1522
1523 TEST(ValuesTest, DictionarySetReturnsPointer) {
1524   {
1525     DictionaryValue dict;
1526     Value* blank_ptr = dict.Set("foo.bar", std::make_unique<base::Value>());
1527     EXPECT_EQ(Value::Type::NONE, blank_ptr->type());
1528   }
1529
1530   {
1531     DictionaryValue dict;
1532     Value* blank_ptr = dict.SetWithoutPathExpansion(
1533         "foo.bar", std::make_unique<base::Value>());
1534     EXPECT_EQ(Value::Type::NONE, blank_ptr->type());
1535   }
1536
1537   {
1538     DictionaryValue dict;
1539     Value* int_ptr = dict.SetInteger("foo.bar", 42);
1540     EXPECT_EQ(Value::Type::INTEGER, int_ptr->type());
1541     EXPECT_EQ(42, int_ptr->GetInt());
1542   }
1543
1544   {
1545     DictionaryValue dict;
1546     Value* double_ptr = dict.SetDouble("foo.bar", 3.142);
1547     EXPECT_EQ(Value::Type::DOUBLE, double_ptr->type());
1548     EXPECT_EQ(3.142, double_ptr->GetDouble());
1549   }
1550
1551   {
1552     DictionaryValue dict;
1553     Value* string_ptr = dict.SetString("foo.bar", "foo");
1554     EXPECT_EQ(Value::Type::STRING, string_ptr->type());
1555     EXPECT_EQ("foo", string_ptr->GetString());
1556   }
1557
1558   {
1559     DictionaryValue dict;
1560     Value* string16_ptr = dict.SetString("foo.bar", ASCIIToUTF16("baz"));
1561     EXPECT_EQ(Value::Type::STRING, string16_ptr->type());
1562     EXPECT_EQ("baz", string16_ptr->GetString());
1563   }
1564
1565   {
1566     DictionaryValue dict;
1567     DictionaryValue* dict_ptr = dict.SetDictionary(
1568         "foo.bar", std::make_unique<base::DictionaryValue>());
1569     EXPECT_EQ(Value::Type::DICTIONARY, dict_ptr->type());
1570   }
1571
1572   {
1573     DictionaryValue dict;
1574     ListValue* list_ptr =
1575         dict.SetList("foo.bar", std::make_unique<base::ListValue>());
1576     EXPECT_EQ(Value::Type::LIST, list_ptr->type());
1577   }
1578 }
1579
1580 TEST(ValuesTest, DictionaryRemoval) {
1581   std::string key = "test";
1582   std::unique_ptr<Value> removed_item;
1583
1584   {
1585     DictionaryValue dict;
1586     EXPECT_EQ(0U, dict.DictSize());
1587     EXPECT_TRUE(dict.DictEmpty());
1588     dict.Set(key, std::make_unique<Value>());
1589     EXPECT_TRUE(dict.HasKey(key));
1590     EXPECT_FALSE(dict.Remove("absent key", &removed_item));
1591     EXPECT_EQ(1U, dict.DictSize());
1592     EXPECT_FALSE(dict.DictEmpty());
1593
1594     EXPECT_TRUE(dict.Remove(key, &removed_item));
1595     EXPECT_FALSE(dict.HasKey(key));
1596     ASSERT_TRUE(removed_item);
1597     EXPECT_EQ(0U, dict.DictSize());
1598     EXPECT_TRUE(dict.DictEmpty());
1599   }
1600
1601   {
1602     DictionaryValue dict;
1603     dict.Set(key, std::make_unique<Value>());
1604     EXPECT_TRUE(dict.HasKey(key));
1605     EXPECT_TRUE(dict.Remove(key, nullptr));
1606     EXPECT_FALSE(dict.HasKey(key));
1607   }
1608 }
1609
1610 TEST(ValuesTest, DictionaryWithoutPathExpansion) {
1611   DictionaryValue dict;
1612   dict.Set("this.is.expanded", std::make_unique<Value>());
1613   dict.SetWithoutPathExpansion("this.isnt.expanded", std::make_unique<Value>());
1614
1615   EXPECT_FALSE(dict.HasKey("this.is.expanded"));
1616   EXPECT_TRUE(dict.HasKey("this"));
1617   Value* value1;
1618   EXPECT_TRUE(dict.Get("this", &value1));
1619   DictionaryValue* value2;
1620   ASSERT_TRUE(dict.GetDictionaryWithoutPathExpansion("this", &value2));
1621   EXPECT_EQ(value1, value2);
1622   EXPECT_EQ(1U, value2->size());
1623
1624   EXPECT_TRUE(dict.HasKey("this.isnt.expanded"));
1625   Value* value3;
1626   EXPECT_FALSE(dict.Get("this.isnt.expanded", &value3));
1627   Value* value4;
1628   ASSERT_TRUE(dict.GetWithoutPathExpansion("this.isnt.expanded", &value4));
1629   EXPECT_EQ(Value::Type::NONE, value4->type());
1630 }
1631
1632 // Tests the deprecated version of SetWithoutPathExpansion.
1633 // TODO(estade): remove.
1634 TEST(ValuesTest, DictionaryWithoutPathExpansionDeprecated) {
1635   DictionaryValue dict;
1636   dict.Set("this.is.expanded", std::make_unique<Value>());
1637   dict.SetWithoutPathExpansion("this.isnt.expanded", std::make_unique<Value>());
1638
1639   EXPECT_FALSE(dict.HasKey("this.is.expanded"));
1640   EXPECT_TRUE(dict.HasKey("this"));
1641   Value* value1;
1642   EXPECT_TRUE(dict.Get("this", &value1));
1643   DictionaryValue* value2;
1644   ASSERT_TRUE(dict.GetDictionaryWithoutPathExpansion("this", &value2));
1645   EXPECT_EQ(value1, value2);
1646   EXPECT_EQ(1U, value2->size());
1647
1648   EXPECT_TRUE(dict.HasKey("this.isnt.expanded"));
1649   Value* value3;
1650   EXPECT_FALSE(dict.Get("this.isnt.expanded", &value3));
1651   Value* value4;
1652   ASSERT_TRUE(dict.GetWithoutPathExpansion("this.isnt.expanded", &value4));
1653   EXPECT_EQ(Value::Type::NONE, value4->type());
1654 }
1655
1656 TEST(ValuesTest, DictionaryRemovePath) {
1657   DictionaryValue dict;
1658   dict.SetInteger("a.long.way.down", 1);
1659   dict.SetBoolean("a.long.key.path", true);
1660
1661   std::unique_ptr<Value> removed_item;
1662   EXPECT_TRUE(dict.RemovePath("a.long.way.down", &removed_item));
1663   ASSERT_TRUE(removed_item);
1664   EXPECT_TRUE(removed_item->is_int());
1665   EXPECT_FALSE(dict.HasKey("a.long.way.down"));
1666   EXPECT_FALSE(dict.HasKey("a.long.way"));
1667   EXPECT_TRUE(dict.Get("a.long.key.path", nullptr));
1668
1669   removed_item.reset();
1670   EXPECT_FALSE(dict.RemovePath("a.long.way.down", &removed_item));
1671   EXPECT_FALSE(removed_item);
1672   EXPECT_TRUE(dict.Get("a.long.key.path", nullptr));
1673
1674   removed_item.reset();
1675   EXPECT_TRUE(dict.RemovePath("a.long.key.path", &removed_item));
1676   ASSERT_TRUE(removed_item);
1677   EXPECT_TRUE(removed_item->is_bool());
1678   EXPECT_TRUE(dict.empty());
1679 }
1680
1681 TEST(ValuesTest, DeepCopy) {
1682   DictionaryValue original_dict;
1683   Value* null_weak = original_dict.Set("null", std::make_unique<Value>());
1684   Value* bool_weak = original_dict.Set("bool", std::make_unique<Value>(true));
1685   Value* int_weak = original_dict.Set("int", std::make_unique<Value>(42));
1686   Value* double_weak =
1687       original_dict.Set("double", std::make_unique<Value>(3.14));
1688   Value* string_weak =
1689       original_dict.Set("string", std::make_unique<Value>("hello"));
1690   Value* string16_weak = original_dict.Set(
1691       "string16", std::make_unique<Value>(ASCIIToUTF16("hello16")));
1692
1693   Value* binary_weak = original_dict.Set(
1694       "binary", std::make_unique<Value>(Value::BlobStorage(42, '!')));
1695
1696   Value::ListStorage storage;
1697   storage.emplace_back(0);
1698   storage.emplace_back(1);
1699   Value* list_weak =
1700       original_dict.Set("list", std::make_unique<Value>(std::move(storage)));
1701   Value* list_element_0_weak = &list_weak->GetList()[0];
1702   Value* list_element_1_weak = &list_weak->GetList()[1];
1703
1704   DictionaryValue* dict_weak = original_dict.SetDictionary(
1705       "dictionary", std::make_unique<DictionaryValue>());
1706   dict_weak->SetStringKey("key", "value");
1707
1708   auto copy_dict = original_dict.CreateDeepCopy();
1709   ASSERT_TRUE(copy_dict.get());
1710   ASSERT_NE(copy_dict.get(), &original_dict);
1711
1712   Value* copy_null = nullptr;
1713   ASSERT_TRUE(copy_dict->Get("null", &copy_null));
1714   ASSERT_TRUE(copy_null);
1715   ASSERT_NE(copy_null, null_weak);
1716   ASSERT_TRUE(copy_null->is_none());
1717
1718   Value* copy_bool = nullptr;
1719   ASSERT_TRUE(copy_dict->Get("bool", &copy_bool));
1720   ASSERT_TRUE(copy_bool);
1721   ASSERT_NE(copy_bool, bool_weak);
1722   ASSERT_TRUE(copy_bool->is_bool());
1723   bool copy_bool_value = false;
1724   ASSERT_TRUE(copy_bool->GetAsBoolean(&copy_bool_value));
1725   ASSERT_TRUE(copy_bool_value);
1726
1727   Value* copy_int = nullptr;
1728   ASSERT_TRUE(copy_dict->Get("int", &copy_int));
1729   ASSERT_TRUE(copy_int);
1730   ASSERT_NE(copy_int, int_weak);
1731   ASSERT_TRUE(copy_int->is_int());
1732   int copy_int_value = 0;
1733   ASSERT_TRUE(copy_int->GetAsInteger(&copy_int_value));
1734   ASSERT_EQ(42, copy_int_value);
1735
1736   Value* copy_double = nullptr;
1737   ASSERT_TRUE(copy_dict->Get("double", &copy_double));
1738   ASSERT_TRUE(copy_double);
1739   ASSERT_NE(copy_double, double_weak);
1740   ASSERT_TRUE(copy_double->is_double());
1741   double copy_double_value = 0;
1742   ASSERT_TRUE(copy_double->GetAsDouble(&copy_double_value));
1743   ASSERT_EQ(3.14, copy_double_value);
1744
1745   Value* copy_string = nullptr;
1746   ASSERT_TRUE(copy_dict->Get("string", &copy_string));
1747   ASSERT_TRUE(copy_string);
1748   ASSERT_NE(copy_string, string_weak);
1749   ASSERT_TRUE(copy_string->is_string());
1750   std::string copy_string_value;
1751   string16 copy_string16_value;
1752   ASSERT_TRUE(copy_string->GetAsString(&copy_string_value));
1753   ASSERT_TRUE(copy_string->GetAsString(&copy_string16_value));
1754   ASSERT_EQ(std::string("hello"), copy_string_value);
1755   ASSERT_EQ(ASCIIToUTF16("hello"), copy_string16_value);
1756
1757   Value* copy_string16 = nullptr;
1758   ASSERT_TRUE(copy_dict->Get("string16", &copy_string16));
1759   ASSERT_TRUE(copy_string16);
1760   ASSERT_NE(copy_string16, string16_weak);
1761   ASSERT_TRUE(copy_string16->is_string());
1762   ASSERT_TRUE(copy_string16->GetAsString(&copy_string_value));
1763   ASSERT_TRUE(copy_string16->GetAsString(&copy_string16_value));
1764   ASSERT_EQ(std::string("hello16"), copy_string_value);
1765   ASSERT_EQ(ASCIIToUTF16("hello16"), copy_string16_value);
1766
1767   Value* copy_binary = nullptr;
1768   ASSERT_TRUE(copy_dict->Get("binary", &copy_binary));
1769   ASSERT_TRUE(copy_binary);
1770   ASSERT_NE(copy_binary, binary_weak);
1771   ASSERT_TRUE(copy_binary->is_blob());
1772   ASSERT_NE(binary_weak->GetBlob().data(), copy_binary->GetBlob().data());
1773   ASSERT_EQ(binary_weak->GetBlob(), copy_binary->GetBlob());
1774
1775   Value* copy_value = nullptr;
1776   ASSERT_TRUE(copy_dict->Get("list", &copy_value));
1777   ASSERT_TRUE(copy_value);
1778   ASSERT_NE(copy_value, list_weak);
1779   ASSERT_TRUE(copy_value->is_list());
1780   ListValue* copy_list = nullptr;
1781   ASSERT_TRUE(copy_value->GetAsList(&copy_list));
1782   ASSERT_TRUE(copy_list);
1783   ASSERT_EQ(2U, copy_list->GetSize());
1784
1785   Value* copy_list_element_0;
1786   ASSERT_TRUE(copy_list->Get(0, &copy_list_element_0));
1787   ASSERT_TRUE(copy_list_element_0);
1788   ASSERT_NE(copy_list_element_0, list_element_0_weak);
1789   int copy_list_element_0_value;
1790   ASSERT_TRUE(copy_list_element_0->GetAsInteger(&copy_list_element_0_value));
1791   ASSERT_EQ(0, copy_list_element_0_value);
1792
1793   Value* copy_list_element_1;
1794   ASSERT_TRUE(copy_list->Get(1, &copy_list_element_1));
1795   ASSERT_TRUE(copy_list_element_1);
1796   ASSERT_NE(copy_list_element_1, list_element_1_weak);
1797   int copy_list_element_1_value;
1798   ASSERT_TRUE(copy_list_element_1->GetAsInteger(&copy_list_element_1_value));
1799   ASSERT_EQ(1, copy_list_element_1_value);
1800
1801   copy_value = nullptr;
1802   ASSERT_TRUE(copy_dict->Get("dictionary", &copy_value));
1803   ASSERT_TRUE(copy_value);
1804   ASSERT_NE(copy_value, dict_weak);
1805   ASSERT_TRUE(copy_value->is_dict());
1806   DictionaryValue* copy_nested_dictionary = nullptr;
1807   ASSERT_TRUE(copy_value->GetAsDictionary(&copy_nested_dictionary));
1808   ASSERT_TRUE(copy_nested_dictionary);
1809   EXPECT_TRUE(copy_nested_dictionary->HasKey("key"));
1810 }
1811
1812 TEST(ValuesTest, Equals) {
1813   auto null1 = std::make_unique<Value>();
1814   auto null2 = std::make_unique<Value>();
1815   EXPECT_NE(null1.get(), null2.get());
1816   EXPECT_EQ(*null1, *null2);
1817
1818   Value boolean(false);
1819   EXPECT_NE(*null1, boolean);
1820
1821   DictionaryValue dv;
1822   dv.SetBoolKey("a", false);
1823   dv.SetIntKey("b", 2);
1824   dv.SetDoubleKey("c", 2.5);
1825   dv.SetStringKey("d1", "string");
1826   dv.SetStringKey("d2", ASCIIToUTF16("http://google.com"));
1827   dv.Set("e", std::make_unique<Value>());
1828
1829   auto copy = dv.CreateDeepCopy();
1830   EXPECT_EQ(dv, *copy);
1831
1832   std::unique_ptr<ListValue> list(new ListValue);
1833   list->Append(std::make_unique<Value>());
1834   list->Append(std::make_unique<DictionaryValue>());
1835   auto list_copy = std::make_unique<Value>(list->Clone());
1836
1837   ListValue* list_weak = dv.SetList("f", std::move(list));
1838   EXPECT_NE(dv, *copy);
1839   copy->Set("f", std::move(list_copy));
1840   EXPECT_EQ(dv, *copy);
1841
1842   list_weak->Append(std::make_unique<Value>(true));
1843   EXPECT_NE(dv, *copy);
1844
1845   // Check if Equals detects differences in only the keys.
1846   copy = dv.CreateDeepCopy();
1847   EXPECT_EQ(dv, *copy);
1848   copy->Remove("a", nullptr);
1849   copy->SetBoolKey("aa", false);
1850   EXPECT_NE(dv, *copy);
1851 }
1852
1853 TEST(ValuesTest, Comparisons) {
1854   // Test None Values.
1855   Value null1;
1856   Value null2;
1857   EXPECT_EQ(null1, null2);
1858   EXPECT_FALSE(null1 != null2);
1859   EXPECT_FALSE(null1 < null2);
1860   EXPECT_FALSE(null1 > null2);
1861   EXPECT_LE(null1, null2);
1862   EXPECT_GE(null1, null2);
1863
1864   // Test Bool Values.
1865   Value bool1(false);
1866   Value bool2(true);
1867   EXPECT_FALSE(bool1 == bool2);
1868   EXPECT_NE(bool1, bool2);
1869   EXPECT_LT(bool1, bool2);
1870   EXPECT_FALSE(bool1 > bool2);
1871   EXPECT_LE(bool1, bool2);
1872   EXPECT_FALSE(bool1 >= bool2);
1873
1874   // Test Int Values.
1875   Value int1(1);
1876   Value int2(2);
1877   EXPECT_FALSE(int1 == int2);
1878   EXPECT_NE(int1, int2);
1879   EXPECT_LT(int1, int2);
1880   EXPECT_FALSE(int1 > int2);
1881   EXPECT_LE(int1, int2);
1882   EXPECT_FALSE(int1 >= int2);
1883
1884   // Test Double Values.
1885   Value double1(1.0);
1886   Value double2(2.0);
1887   EXPECT_FALSE(double1 == double2);
1888   EXPECT_NE(double1, double2);
1889   EXPECT_LT(double1, double2);
1890   EXPECT_FALSE(double1 > double2);
1891   EXPECT_LE(double1, double2);
1892   EXPECT_FALSE(double1 >= double2);
1893
1894   // Test String Values.
1895   Value string1("1");
1896   Value string2("2");
1897   EXPECT_FALSE(string1 == string2);
1898   EXPECT_NE(string1, string2);
1899   EXPECT_LT(string1, string2);
1900   EXPECT_FALSE(string1 > string2);
1901   EXPECT_LE(string1, string2);
1902   EXPECT_FALSE(string1 >= string2);
1903
1904   // Test Binary Values.
1905   Value binary1(Value::BlobStorage{0x01});
1906   Value binary2(Value::BlobStorage{0x02});
1907   EXPECT_FALSE(binary1 == binary2);
1908   EXPECT_NE(binary1, binary2);
1909   EXPECT_LT(binary1, binary2);
1910   EXPECT_FALSE(binary1 > binary2);
1911   EXPECT_LE(binary1, binary2);
1912   EXPECT_FALSE(binary1 >= binary2);
1913
1914   // Test Empty List Values.
1915   ListValue null_list1;
1916   ListValue null_list2;
1917   EXPECT_EQ(null_list1, null_list2);
1918   EXPECT_FALSE(null_list1 != null_list2);
1919   EXPECT_FALSE(null_list1 < null_list2);
1920   EXPECT_FALSE(null_list1 > null_list2);
1921   EXPECT_LE(null_list1, null_list2);
1922   EXPECT_GE(null_list1, null_list2);
1923
1924   // Test Non Empty List Values.
1925   ListValue int_list1;
1926   ListValue int_list2;
1927   int_list1.AppendInteger(1);
1928   int_list2.AppendInteger(2);
1929   EXPECT_FALSE(int_list1 == int_list2);
1930   EXPECT_NE(int_list1, int_list2);
1931   EXPECT_LT(int_list1, int_list2);
1932   EXPECT_FALSE(int_list1 > int_list2);
1933   EXPECT_LE(int_list1, int_list2);
1934   EXPECT_FALSE(int_list1 >= int_list2);
1935
1936   // Test Empty Dict Values.
1937   DictionaryValue null_dict1;
1938   DictionaryValue null_dict2;
1939   EXPECT_EQ(null_dict1, null_dict2);
1940   EXPECT_FALSE(null_dict1 != null_dict2);
1941   EXPECT_FALSE(null_dict1 < null_dict2);
1942   EXPECT_FALSE(null_dict1 > null_dict2);
1943   EXPECT_LE(null_dict1, null_dict2);
1944   EXPECT_GE(null_dict1, null_dict2);
1945
1946   // Test Non Empty Dict Values.
1947   DictionaryValue int_dict1;
1948   DictionaryValue int_dict2;
1949   int_dict1.SetIntKey("key", 1);
1950   int_dict2.SetIntKey("key", 2);
1951   EXPECT_FALSE(int_dict1 == int_dict2);
1952   EXPECT_NE(int_dict1, int_dict2);
1953   EXPECT_LT(int_dict1, int_dict2);
1954   EXPECT_FALSE(int_dict1 > int_dict2);
1955   EXPECT_LE(int_dict1, int_dict2);
1956   EXPECT_FALSE(int_dict1 >= int_dict2);
1957
1958   // Test Values of different types.
1959   std::vector<Value> values;
1960   values.emplace_back(std::move(null1));
1961   values.emplace_back(std::move(bool1));
1962   values.emplace_back(std::move(int1));
1963   values.emplace_back(std::move(double1));
1964   values.emplace_back(std::move(string1));
1965   values.emplace_back(std::move(binary1));
1966   values.emplace_back(std::move(int_dict1));
1967   values.emplace_back(std::move(int_list1));
1968   for (size_t i = 0; i < values.size(); ++i) {
1969     for (size_t j = i + 1; j < values.size(); ++j) {
1970       EXPECT_FALSE(values[i] == values[j]);
1971       EXPECT_NE(values[i], values[j]);
1972       EXPECT_LT(values[i], values[j]);
1973       EXPECT_FALSE(values[i] > values[j]);
1974       EXPECT_LE(values[i], values[j]);
1975       EXPECT_FALSE(values[i] >= values[j]);
1976     }
1977   }
1978 }
1979
1980 TEST(ValuesTest, DeepCopyCovariantReturnTypes) {
1981   DictionaryValue original_dict;
1982   Value* null_weak = original_dict.SetKey("null", Value());
1983   Value* bool_weak = original_dict.SetKey("bool", Value(true));
1984   Value* int_weak = original_dict.SetKey("int", Value(42));
1985   Value* double_weak = original_dict.SetKey("double", Value(3.14));
1986   Value* string_weak = original_dict.SetKey("string", Value("hello"));
1987   Value* string16_weak =
1988       original_dict.SetKey("string16", Value(ASCIIToUTF16("hello16")));
1989   Value* binary_weak =
1990       original_dict.SetKey("binary", Value(Value::BlobStorage(42, '!')));
1991
1992   Value::ListStorage storage;
1993   storage.emplace_back(0);
1994   storage.emplace_back(1);
1995   Value* list_weak = original_dict.SetKey("list", Value(std::move(storage)));
1996
1997   auto copy_dict = std::make_unique<Value>(original_dict.Clone());
1998   auto copy_null = std::make_unique<Value>(null_weak->Clone());
1999   auto copy_bool = std::make_unique<Value>(bool_weak->Clone());
2000   auto copy_int = std::make_unique<Value>(int_weak->Clone());
2001   auto copy_double = std::make_unique<Value>(double_weak->Clone());
2002   auto copy_string = std::make_unique<Value>(string_weak->Clone());
2003   auto copy_string16 = std::make_unique<Value>(string16_weak->Clone());
2004   auto copy_binary = std::make_unique<Value>(binary_weak->Clone());
2005   auto copy_list = std::make_unique<Value>(list_weak->Clone());
2006
2007   EXPECT_EQ(original_dict, *copy_dict);
2008   EXPECT_EQ(*null_weak, *copy_null);
2009   EXPECT_EQ(*bool_weak, *copy_bool);
2010   EXPECT_EQ(*int_weak, *copy_int);
2011   EXPECT_EQ(*double_weak, *copy_double);
2012   EXPECT_EQ(*string_weak, *copy_string);
2013   EXPECT_EQ(*string16_weak, *copy_string16);
2014   EXPECT_EQ(*binary_weak, *copy_binary);
2015   EXPECT_EQ(*list_weak, *copy_list);
2016 }
2017
2018 TEST(ValuesTest, RemoveEmptyChildren) {
2019   auto root = std::make_unique<DictionaryValue>();
2020   // Remove empty lists and dictionaries.
2021   root->Set("empty_dict", std::make_unique<DictionaryValue>());
2022   root->Set("empty_list", std::make_unique<ListValue>());
2023   root->SetWithoutPathExpansion("a.b.c.d.e",
2024                                 std::make_unique<DictionaryValue>());
2025   root = root->DeepCopyWithoutEmptyChildren();
2026   EXPECT_TRUE(root->empty());
2027
2028   // Make sure we don't prune too much.
2029   root->SetBoolKey("bool", true);
2030   root->Set("empty_dict", std::make_unique<DictionaryValue>());
2031   root->SetStringKey("empty_string", std::string());
2032   root = root->DeepCopyWithoutEmptyChildren();
2033   EXPECT_EQ(2U, root->size());
2034
2035   // Should do nothing.
2036   root = root->DeepCopyWithoutEmptyChildren();
2037   EXPECT_EQ(2U, root->size());
2038
2039   // Nested test cases.  These should all reduce back to the bool and string
2040   // set above.
2041   {
2042     root->Set("a.b.c.d.e", std::make_unique<DictionaryValue>());
2043     root = root->DeepCopyWithoutEmptyChildren();
2044     EXPECT_EQ(2U, root->size());
2045   }
2046   {
2047     auto inner = std::make_unique<DictionaryValue>();
2048     inner->Set("empty_dict", std::make_unique<DictionaryValue>());
2049     inner->Set("empty_list", std::make_unique<ListValue>());
2050     root->Set("dict_with_empty_children", std::move(inner));
2051     root = root->DeepCopyWithoutEmptyChildren();
2052     EXPECT_EQ(2U, root->size());
2053   }
2054   {
2055     auto inner = std::make_unique<ListValue>();
2056     inner->Append(std::make_unique<DictionaryValue>());
2057     inner->Append(std::make_unique<ListValue>());
2058     root->Set("list_with_empty_children", std::move(inner));
2059     root = root->DeepCopyWithoutEmptyChildren();
2060     EXPECT_EQ(2U, root->size());
2061   }
2062
2063   // Nested with siblings.
2064   {
2065     auto inner = std::make_unique<ListValue>();
2066     inner->Append(std::make_unique<DictionaryValue>());
2067     inner->Append(std::make_unique<ListValue>());
2068     root->Set("list_with_empty_children", std::move(inner));
2069     auto inner2 = std::make_unique<DictionaryValue>();
2070     inner2->Set("empty_dict", std::make_unique<DictionaryValue>());
2071     inner2->Set("empty_list", std::make_unique<ListValue>());
2072     root->Set("dict_with_empty_children", std::move(inner2));
2073     root = root->DeepCopyWithoutEmptyChildren();
2074     EXPECT_EQ(2U, root->size());
2075   }
2076
2077   // Make sure nested values don't get pruned.
2078   {
2079     auto inner = std::make_unique<ListValue>();
2080     auto inner2 = std::make_unique<ListValue>();
2081     inner2->Append(std::make_unique<Value>("hello"));
2082     inner->Append(std::make_unique<DictionaryValue>());
2083     inner->Append(std::move(inner2));
2084     root->Set("list_with_empty_children", std::move(inner));
2085     root = root->DeepCopyWithoutEmptyChildren();
2086     EXPECT_EQ(3U, root->size());
2087
2088     ListValue* inner_value, *inner_value2;
2089     EXPECT_TRUE(root->GetList("list_with_empty_children", &inner_value));
2090     EXPECT_EQ(1U, inner_value->GetSize());  // Dictionary was pruned.
2091     EXPECT_TRUE(inner_value->GetList(0, &inner_value2));
2092     EXPECT_EQ(1U, inner_value2->GetSize());
2093   }
2094 }
2095
2096 TEST(ValuesTest, MergeDictionary) {
2097   std::unique_ptr<DictionaryValue> base(new DictionaryValue);
2098   base->SetStringKey("base_key", "base_key_value_base");
2099   base->SetStringKey("collide_key", "collide_key_value_base");
2100   std::unique_ptr<DictionaryValue> base_sub_dict(new DictionaryValue);
2101   base_sub_dict->SetStringKey("sub_base_key", "sub_base_key_value_base");
2102   base_sub_dict->SetStringKey("sub_collide_key", "sub_collide_key_value_base");
2103   base->Set("sub_dict_key", std::move(base_sub_dict));
2104
2105   std::unique_ptr<DictionaryValue> merge(new DictionaryValue);
2106   merge->SetStringKey("merge_key", "merge_key_value_merge");
2107   merge->SetStringKey("collide_key", "collide_key_value_merge");
2108   std::unique_ptr<DictionaryValue> merge_sub_dict(new DictionaryValue);
2109   merge_sub_dict->SetStringKey("sub_merge_key", "sub_merge_key_value_merge");
2110   merge_sub_dict->SetStringKey("sub_collide_key",
2111                                "sub_collide_key_value_merge");
2112   merge->Set("sub_dict_key", std::move(merge_sub_dict));
2113
2114   base->MergeDictionary(merge.get());
2115
2116   EXPECT_EQ(4U, base->size());
2117   std::string base_key_value;
2118   EXPECT_TRUE(base->GetString("base_key", &base_key_value));
2119   EXPECT_EQ("base_key_value_base", base_key_value); // Base value preserved.
2120   std::string collide_key_value;
2121   EXPECT_TRUE(base->GetString("collide_key", &collide_key_value));
2122   EXPECT_EQ("collide_key_value_merge", collide_key_value); // Replaced.
2123   std::string merge_key_value;
2124   EXPECT_TRUE(base->GetString("merge_key", &merge_key_value));
2125   EXPECT_EQ("merge_key_value_merge", merge_key_value); // Merged in.
2126
2127   DictionaryValue* res_sub_dict;
2128   EXPECT_TRUE(base->GetDictionary("sub_dict_key", &res_sub_dict));
2129   EXPECT_EQ(3U, res_sub_dict->size());
2130   std::string sub_base_key_value;
2131   EXPECT_TRUE(res_sub_dict->GetString("sub_base_key", &sub_base_key_value));
2132   EXPECT_EQ("sub_base_key_value_base", sub_base_key_value); // Preserved.
2133   std::string sub_collide_key_value;
2134   EXPECT_TRUE(res_sub_dict->GetString("sub_collide_key",
2135                                       &sub_collide_key_value));
2136   EXPECT_EQ("sub_collide_key_value_merge", sub_collide_key_value); // Replaced.
2137   std::string sub_merge_key_value;
2138   EXPECT_TRUE(res_sub_dict->GetString("sub_merge_key", &sub_merge_key_value));
2139   EXPECT_EQ("sub_merge_key_value_merge", sub_merge_key_value); // Merged in.
2140 }
2141
2142 TEST(ValuesTest, MergeDictionaryDeepCopy) {
2143   std::unique_ptr<DictionaryValue> child(new DictionaryValue);
2144   DictionaryValue* original_child = child.get();
2145   child->SetStringKey("test", "value");
2146   EXPECT_EQ(1U, child->size());
2147
2148   std::string value;
2149   EXPECT_TRUE(child->GetString("test", &value));
2150   EXPECT_EQ("value", value);
2151
2152   std::unique_ptr<DictionaryValue> base(new DictionaryValue);
2153   base->Set("dict", std::move(child));
2154   EXPECT_EQ(1U, base->size());
2155
2156   DictionaryValue* ptr;
2157   EXPECT_TRUE(base->GetDictionary("dict", &ptr));
2158   EXPECT_EQ(original_child, ptr);
2159
2160   std::unique_ptr<DictionaryValue> merged(new DictionaryValue);
2161   merged->MergeDictionary(base.get());
2162   EXPECT_EQ(1U, merged->size());
2163   EXPECT_TRUE(merged->GetDictionary("dict", &ptr));
2164   EXPECT_NE(original_child, ptr);
2165   EXPECT_TRUE(ptr->GetString("test", &value));
2166   EXPECT_EQ("value", value);
2167
2168   original_child->SetStringKey("test", "overwrite");
2169   base.reset();
2170   EXPECT_TRUE(ptr->GetString("test", &value));
2171   EXPECT_EQ("value", value);
2172 }
2173
2174 TEST(ValuesTest, DictionaryIterator) {
2175   DictionaryValue dict;
2176   for (DictionaryValue::Iterator it(dict); !it.IsAtEnd(); it.Advance()) {
2177     ADD_FAILURE();
2178   }
2179
2180   Value value1("value1");
2181   dict.SetKey("key1", value1.Clone());
2182   bool seen1 = false;
2183   for (DictionaryValue::Iterator it(dict); !it.IsAtEnd(); it.Advance()) {
2184     EXPECT_FALSE(seen1);
2185     EXPECT_EQ("key1", it.key());
2186     EXPECT_EQ(value1, it.value());
2187     seen1 = true;
2188   }
2189   EXPECT_TRUE(seen1);
2190
2191   Value value2("value2");
2192   dict.SetKey("key2", value2.Clone());
2193   bool seen2 = seen1 = false;
2194   for (DictionaryValue::Iterator it(dict); !it.IsAtEnd(); it.Advance()) {
2195     if (it.key() == "key1") {
2196       EXPECT_FALSE(seen1);
2197       EXPECT_EQ(value1, it.value());
2198       seen1 = true;
2199     } else if (it.key() == "key2") {
2200       EXPECT_FALSE(seen2);
2201       EXPECT_EQ(value2, it.value());
2202       seen2 = true;
2203     } else {
2204       ADD_FAILURE();
2205     }
2206   }
2207   EXPECT_TRUE(seen1);
2208   EXPECT_TRUE(seen2);
2209 }
2210
2211 TEST(ValuesTest, MutatingCopiedPairsInDictItemsMutatesUnderlyingValues) {
2212   Value dict(Value::Type::DICTIONARY);
2213   dict.SetKey("key", Value("initial value"));
2214
2215   // Because the non-const DictItems() iterates over
2216   // <const std::string&, Value&> pairs, it's possible
2217   // to alter iterated-over values in place even when
2218   // "copying" the key-value pair:
2219   for (auto kv : dict.DictItems())
2220     kv.second.GetString() = "replacement";
2221
2222   std::string* found = dict.FindStringKey("key");
2223   ASSERT_TRUE(found);
2224   EXPECT_EQ(*found, "replacement");
2225 }
2226
2227 TEST(ValuesTest, StdDictionaryIterator) {
2228   DictionaryValue dict;
2229   for (auto it = dict.begin(); it != dict.end(); ++it) {
2230     ADD_FAILURE();
2231   }
2232
2233   Value value1("value1");
2234   dict.SetKey("key1", value1.Clone());
2235   bool seen1 = false;
2236   for (const auto& it : dict) {
2237     EXPECT_FALSE(seen1);
2238     EXPECT_EQ("key1", it.first);
2239     EXPECT_EQ(value1, *it.second);
2240     seen1 = true;
2241   }
2242   EXPECT_TRUE(seen1);
2243
2244   Value value2("value2");
2245   dict.SetKey("key2", value2.Clone());
2246   bool seen2 = seen1 = false;
2247   for (const auto& it : dict) {
2248     if (it.first == "key1") {
2249       EXPECT_FALSE(seen1);
2250       EXPECT_EQ(value1, *it.second);
2251       seen1 = true;
2252     } else if (it.first == "key2") {
2253       EXPECT_FALSE(seen2);
2254       EXPECT_EQ(value2, *it.second);
2255       seen2 = true;
2256     } else {
2257       ADD_FAILURE();
2258     }
2259   }
2260   EXPECT_TRUE(seen1);
2261   EXPECT_TRUE(seen2);
2262 }
2263
2264 // DictionaryValue/ListValue's Get*() methods should accept NULL as an out-value
2265 // and still return true/false based on success.
2266 TEST(ValuesTest, GetWithNullOutValue) {
2267   DictionaryValue main_dict;
2268   ListValue main_list;
2269
2270   Value bool_value(false);
2271   Value int_value(1234);
2272   Value double_value(12.34567);
2273   Value string_value("foo");
2274   Value binary_value(Value::Type::BINARY);
2275   DictionaryValue dict_value;
2276   ListValue list_value;
2277
2278   main_dict.SetKey("bool", bool_value.Clone());
2279   main_dict.SetKey("int", int_value.Clone());
2280   main_dict.SetKey("double", double_value.Clone());
2281   main_dict.SetKey("string", string_value.Clone());
2282   main_dict.SetKey("binary", binary_value.Clone());
2283   main_dict.SetKey("dict", dict_value.Clone());
2284   main_dict.SetKey("list", list_value.Clone());
2285
2286   main_list.Append(std::make_unique<Value>(bool_value.Clone()));
2287   main_list.Append(std::make_unique<Value>(int_value.Clone()));
2288   main_list.Append(std::make_unique<Value>(double_value.Clone()));
2289   main_list.Append(std::make_unique<Value>(string_value.Clone()));
2290   main_list.Append(std::make_unique<Value>(binary_value.Clone()));
2291   main_list.Append(std::make_unique<Value>(dict_value.Clone()));
2292   main_list.Append(std::make_unique<Value>(list_value.Clone()));
2293
2294   EXPECT_TRUE(main_dict.Get("bool", nullptr));
2295   EXPECT_TRUE(main_dict.Get("int", nullptr));
2296   EXPECT_TRUE(main_dict.Get("double", nullptr));
2297   EXPECT_TRUE(main_dict.Get("string", nullptr));
2298   EXPECT_TRUE(main_dict.Get("binary", nullptr));
2299   EXPECT_TRUE(main_dict.Get("dict", nullptr));
2300   EXPECT_TRUE(main_dict.Get("list", nullptr));
2301   EXPECT_FALSE(main_dict.Get("DNE", nullptr));
2302
2303   EXPECT_TRUE(main_dict.GetBoolean("bool", nullptr));
2304   EXPECT_FALSE(main_dict.GetBoolean("int", nullptr));
2305   EXPECT_FALSE(main_dict.GetBoolean("double", nullptr));
2306   EXPECT_FALSE(main_dict.GetBoolean("string", nullptr));
2307   EXPECT_FALSE(main_dict.GetBoolean("binary", nullptr));
2308   EXPECT_FALSE(main_dict.GetBoolean("dict", nullptr));
2309   EXPECT_FALSE(main_dict.GetBoolean("list", nullptr));
2310   EXPECT_FALSE(main_dict.GetBoolean("DNE", nullptr));
2311
2312   EXPECT_FALSE(main_dict.GetInteger("bool", nullptr));
2313   EXPECT_TRUE(main_dict.GetInteger("int", nullptr));
2314   EXPECT_FALSE(main_dict.GetInteger("double", nullptr));
2315   EXPECT_FALSE(main_dict.GetInteger("string", nullptr));
2316   EXPECT_FALSE(main_dict.GetInteger("binary", nullptr));
2317   EXPECT_FALSE(main_dict.GetInteger("dict", nullptr));
2318   EXPECT_FALSE(main_dict.GetInteger("list", nullptr));
2319   EXPECT_FALSE(main_dict.GetInteger("DNE", nullptr));
2320
2321   // Both int and double values can be obtained from GetDouble.
2322   EXPECT_FALSE(main_dict.GetDouble("bool", nullptr));
2323   EXPECT_TRUE(main_dict.GetDouble("int", nullptr));
2324   EXPECT_TRUE(main_dict.GetDouble("double", nullptr));
2325   EXPECT_FALSE(main_dict.GetDouble("string", nullptr));
2326   EXPECT_FALSE(main_dict.GetDouble("binary", nullptr));
2327   EXPECT_FALSE(main_dict.GetDouble("dict", nullptr));
2328   EXPECT_FALSE(main_dict.GetDouble("list", nullptr));
2329   EXPECT_FALSE(main_dict.GetDouble("DNE", nullptr));
2330
2331   EXPECT_FALSE(main_dict.GetString("bool", static_cast<std::string*>(nullptr)));
2332   EXPECT_FALSE(main_dict.GetString("int", static_cast<std::string*>(nullptr)));
2333   EXPECT_FALSE(
2334       main_dict.GetString("double", static_cast<std::string*>(nullptr)));
2335   EXPECT_TRUE(
2336       main_dict.GetString("string", static_cast<std::string*>(nullptr)));
2337   EXPECT_FALSE(
2338       main_dict.GetString("binary", static_cast<std::string*>(nullptr)));
2339   EXPECT_FALSE(main_dict.GetString("dict", static_cast<std::string*>(nullptr)));
2340   EXPECT_FALSE(main_dict.GetString("list", static_cast<std::string*>(nullptr)));
2341   EXPECT_FALSE(main_dict.GetString("DNE", static_cast<std::string*>(nullptr)));
2342
2343   EXPECT_FALSE(main_dict.GetString("bool", static_cast<string16*>(nullptr)));
2344   EXPECT_FALSE(main_dict.GetString("int", static_cast<string16*>(nullptr)));
2345   EXPECT_FALSE(main_dict.GetString("double", static_cast<string16*>(nullptr)));
2346   EXPECT_TRUE(main_dict.GetString("string", static_cast<string16*>(nullptr)));
2347   EXPECT_FALSE(main_dict.GetString("binary", static_cast<string16*>(nullptr)));
2348   EXPECT_FALSE(main_dict.GetString("dict", static_cast<string16*>(nullptr)));
2349   EXPECT_FALSE(main_dict.GetString("list", static_cast<string16*>(nullptr)));
2350   EXPECT_FALSE(main_dict.GetString("DNE", static_cast<string16*>(nullptr)));
2351
2352   EXPECT_FALSE(main_dict.GetBinary("bool", nullptr));
2353   EXPECT_FALSE(main_dict.GetBinary("int", nullptr));
2354   EXPECT_FALSE(main_dict.GetBinary("double", nullptr));
2355   EXPECT_FALSE(main_dict.GetBinary("string", nullptr));
2356   EXPECT_TRUE(main_dict.GetBinary("binary", nullptr));
2357   EXPECT_FALSE(main_dict.GetBinary("dict", nullptr));
2358   EXPECT_FALSE(main_dict.GetBinary("list", nullptr));
2359   EXPECT_FALSE(main_dict.GetBinary("DNE", nullptr));
2360
2361   EXPECT_FALSE(main_dict.GetDictionary("bool", nullptr));
2362   EXPECT_FALSE(main_dict.GetDictionary("int", nullptr));
2363   EXPECT_FALSE(main_dict.GetDictionary("double", nullptr));
2364   EXPECT_FALSE(main_dict.GetDictionary("string", nullptr));
2365   EXPECT_FALSE(main_dict.GetDictionary("binary", nullptr));
2366   EXPECT_TRUE(main_dict.GetDictionary("dict", nullptr));
2367   EXPECT_FALSE(main_dict.GetDictionary("list", nullptr));
2368   EXPECT_FALSE(main_dict.GetDictionary("DNE", nullptr));
2369
2370   EXPECT_FALSE(main_dict.GetList("bool", nullptr));
2371   EXPECT_FALSE(main_dict.GetList("int", nullptr));
2372   EXPECT_FALSE(main_dict.GetList("double", nullptr));
2373   EXPECT_FALSE(main_dict.GetList("string", nullptr));
2374   EXPECT_FALSE(main_dict.GetList("binary", nullptr));
2375   EXPECT_FALSE(main_dict.GetList("dict", nullptr));
2376   EXPECT_TRUE(main_dict.GetList("list", nullptr));
2377   EXPECT_FALSE(main_dict.GetList("DNE", nullptr));
2378
2379   EXPECT_TRUE(main_dict.GetWithoutPathExpansion("bool", nullptr));
2380   EXPECT_TRUE(main_dict.GetWithoutPathExpansion("int", nullptr));
2381   EXPECT_TRUE(main_dict.GetWithoutPathExpansion("double", nullptr));
2382   EXPECT_TRUE(main_dict.GetWithoutPathExpansion("string", nullptr));
2383   EXPECT_TRUE(main_dict.GetWithoutPathExpansion("binary", nullptr));
2384   EXPECT_TRUE(main_dict.GetWithoutPathExpansion("dict", nullptr));
2385   EXPECT_TRUE(main_dict.GetWithoutPathExpansion("list", nullptr));
2386   EXPECT_FALSE(main_dict.GetWithoutPathExpansion("DNE", nullptr));
2387
2388   EXPECT_TRUE(main_dict.GetBooleanWithoutPathExpansion("bool", nullptr));
2389   EXPECT_FALSE(main_dict.GetBooleanWithoutPathExpansion("int", nullptr));
2390   EXPECT_FALSE(main_dict.GetBooleanWithoutPathExpansion("double", nullptr));
2391   EXPECT_FALSE(main_dict.GetBooleanWithoutPathExpansion("string", nullptr));
2392   EXPECT_FALSE(main_dict.GetBooleanWithoutPathExpansion("binary", nullptr));
2393   EXPECT_FALSE(main_dict.GetBooleanWithoutPathExpansion("dict", nullptr));
2394   EXPECT_FALSE(main_dict.GetBooleanWithoutPathExpansion("list", nullptr));
2395   EXPECT_FALSE(main_dict.GetBooleanWithoutPathExpansion("DNE", nullptr));
2396
2397   EXPECT_FALSE(main_dict.GetIntegerWithoutPathExpansion("bool", nullptr));
2398   EXPECT_TRUE(main_dict.GetIntegerWithoutPathExpansion("int", nullptr));
2399   EXPECT_FALSE(main_dict.GetIntegerWithoutPathExpansion("double", nullptr));
2400   EXPECT_FALSE(main_dict.GetIntegerWithoutPathExpansion("string", nullptr));
2401   EXPECT_FALSE(main_dict.GetIntegerWithoutPathExpansion("binary", nullptr));
2402   EXPECT_FALSE(main_dict.GetIntegerWithoutPathExpansion("dict", nullptr));
2403   EXPECT_FALSE(main_dict.GetIntegerWithoutPathExpansion("list", nullptr));
2404   EXPECT_FALSE(main_dict.GetIntegerWithoutPathExpansion("DNE", nullptr));
2405
2406   EXPECT_FALSE(main_dict.GetDoubleWithoutPathExpansion("bool", nullptr));
2407   EXPECT_TRUE(main_dict.GetDoubleWithoutPathExpansion("int", nullptr));
2408   EXPECT_TRUE(main_dict.GetDoubleWithoutPathExpansion("double", nullptr));
2409   EXPECT_FALSE(main_dict.GetDoubleWithoutPathExpansion("string", nullptr));
2410   EXPECT_FALSE(main_dict.GetDoubleWithoutPathExpansion("binary", nullptr));
2411   EXPECT_FALSE(main_dict.GetDoubleWithoutPathExpansion("dict", nullptr));
2412   EXPECT_FALSE(main_dict.GetDoubleWithoutPathExpansion("list", nullptr));
2413   EXPECT_FALSE(main_dict.GetDoubleWithoutPathExpansion("DNE", nullptr));
2414
2415   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2416       "bool", static_cast<std::string*>(nullptr)));
2417   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2418       "int", static_cast<std::string*>(nullptr)));
2419   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2420       "double", static_cast<std::string*>(nullptr)));
2421   EXPECT_TRUE(main_dict.GetStringWithoutPathExpansion(
2422       "string", static_cast<std::string*>(nullptr)));
2423   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2424       "binary", static_cast<std::string*>(nullptr)));
2425   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2426       "dict", static_cast<std::string*>(nullptr)));
2427   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2428       "list", static_cast<std::string*>(nullptr)));
2429   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2430       "DNE", static_cast<std::string*>(nullptr)));
2431
2432   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2433       "bool", static_cast<string16*>(nullptr)));
2434   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2435       "int", static_cast<string16*>(nullptr)));
2436   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2437       "double", static_cast<string16*>(nullptr)));
2438   EXPECT_TRUE(main_dict.GetStringWithoutPathExpansion(
2439       "string", static_cast<string16*>(nullptr)));
2440   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2441       "binary", static_cast<string16*>(nullptr)));
2442   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2443       "dict", static_cast<string16*>(nullptr)));
2444   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2445       "list", static_cast<string16*>(nullptr)));
2446   EXPECT_FALSE(main_dict.GetStringWithoutPathExpansion(
2447       "DNE", static_cast<string16*>(nullptr)));
2448
2449   // There is no GetBinaryWithoutPathExpansion for some reason, but if there
2450   // were it should be tested here...
2451
2452   EXPECT_FALSE(main_dict.GetDictionaryWithoutPathExpansion("bool", nullptr));
2453   EXPECT_FALSE(main_dict.GetDictionaryWithoutPathExpansion("int", nullptr));
2454   EXPECT_FALSE(main_dict.GetDictionaryWithoutPathExpansion("double", nullptr));
2455   EXPECT_FALSE(main_dict.GetDictionaryWithoutPathExpansion("string", nullptr));
2456   EXPECT_FALSE(main_dict.GetDictionaryWithoutPathExpansion("binary", nullptr));
2457   EXPECT_TRUE(main_dict.GetDictionaryWithoutPathExpansion("dict", nullptr));
2458   EXPECT_FALSE(main_dict.GetDictionaryWithoutPathExpansion("list", nullptr));
2459   EXPECT_FALSE(main_dict.GetDictionaryWithoutPathExpansion("DNE", nullptr));
2460
2461   EXPECT_FALSE(main_dict.GetListWithoutPathExpansion("bool", nullptr));
2462   EXPECT_FALSE(main_dict.GetListWithoutPathExpansion("int", nullptr));
2463   EXPECT_FALSE(main_dict.GetListWithoutPathExpansion("double", nullptr));
2464   EXPECT_FALSE(main_dict.GetListWithoutPathExpansion("string", nullptr));
2465   EXPECT_FALSE(main_dict.GetListWithoutPathExpansion("binary", nullptr));
2466   EXPECT_FALSE(main_dict.GetListWithoutPathExpansion("dict", nullptr));
2467   EXPECT_TRUE(main_dict.GetListWithoutPathExpansion("list", nullptr));
2468   EXPECT_FALSE(main_dict.GetListWithoutPathExpansion("DNE", nullptr));
2469
2470   EXPECT_TRUE(main_list.Get(0, nullptr));
2471   EXPECT_TRUE(main_list.Get(1, nullptr));
2472   EXPECT_TRUE(main_list.Get(2, nullptr));
2473   EXPECT_TRUE(main_list.Get(3, nullptr));
2474   EXPECT_TRUE(main_list.Get(4, nullptr));
2475   EXPECT_TRUE(main_list.Get(5, nullptr));
2476   EXPECT_TRUE(main_list.Get(6, nullptr));
2477   EXPECT_FALSE(main_list.Get(7, nullptr));
2478
2479   EXPECT_TRUE(main_list.GetBoolean(0, nullptr));
2480   EXPECT_FALSE(main_list.GetBoolean(1, nullptr));
2481   EXPECT_FALSE(main_list.GetBoolean(2, nullptr));
2482   EXPECT_FALSE(main_list.GetBoolean(3, nullptr));
2483   EXPECT_FALSE(main_list.GetBoolean(4, nullptr));
2484   EXPECT_FALSE(main_list.GetBoolean(5, nullptr));
2485   EXPECT_FALSE(main_list.GetBoolean(6, nullptr));
2486   EXPECT_FALSE(main_list.GetBoolean(7, nullptr));
2487
2488   EXPECT_FALSE(main_list.GetInteger(0, nullptr));
2489   EXPECT_TRUE(main_list.GetInteger(1, nullptr));
2490   EXPECT_FALSE(main_list.GetInteger(2, nullptr));
2491   EXPECT_FALSE(main_list.GetInteger(3, nullptr));
2492   EXPECT_FALSE(main_list.GetInteger(4, nullptr));
2493   EXPECT_FALSE(main_list.GetInteger(5, nullptr));
2494   EXPECT_FALSE(main_list.GetInteger(6, nullptr));
2495   EXPECT_FALSE(main_list.GetInteger(7, nullptr));
2496
2497   EXPECT_FALSE(main_list.GetDouble(0, nullptr));
2498   EXPECT_TRUE(main_list.GetDouble(1, nullptr));
2499   EXPECT_TRUE(main_list.GetDouble(2, nullptr));
2500   EXPECT_FALSE(main_list.GetDouble(3, nullptr));
2501   EXPECT_FALSE(main_list.GetDouble(4, nullptr));
2502   EXPECT_FALSE(main_list.GetDouble(5, nullptr));
2503   EXPECT_FALSE(main_list.GetDouble(6, nullptr));
2504   EXPECT_FALSE(main_list.GetDouble(7, nullptr));
2505
2506   EXPECT_FALSE(main_list.GetString(0, static_cast<std::string*>(nullptr)));
2507   EXPECT_FALSE(main_list.GetString(1, static_cast<std::string*>(nullptr)));
2508   EXPECT_FALSE(main_list.GetString(2, static_cast<std::string*>(nullptr)));
2509   EXPECT_TRUE(main_list.GetString(3, static_cast<std::string*>(nullptr)));
2510   EXPECT_FALSE(main_list.GetString(4, static_cast<std::string*>(nullptr)));
2511   EXPECT_FALSE(main_list.GetString(5, static_cast<std::string*>(nullptr)));
2512   EXPECT_FALSE(main_list.GetString(6, static_cast<std::string*>(nullptr)));
2513   EXPECT_FALSE(main_list.GetString(7, static_cast<std::string*>(nullptr)));
2514
2515   EXPECT_FALSE(main_list.GetString(0, static_cast<string16*>(nullptr)));
2516   EXPECT_FALSE(main_list.GetString(1, static_cast<string16*>(nullptr)));
2517   EXPECT_FALSE(main_list.GetString(2, static_cast<string16*>(nullptr)));
2518   EXPECT_TRUE(main_list.GetString(3, static_cast<string16*>(nullptr)));
2519   EXPECT_FALSE(main_list.GetString(4, static_cast<string16*>(nullptr)));
2520   EXPECT_FALSE(main_list.GetString(5, static_cast<string16*>(nullptr)));
2521   EXPECT_FALSE(main_list.GetString(6, static_cast<string16*>(nullptr)));
2522   EXPECT_FALSE(main_list.GetString(7, static_cast<string16*>(nullptr)));
2523
2524   EXPECT_FALSE(main_list.GetDictionary(0, nullptr));
2525   EXPECT_FALSE(main_list.GetDictionary(1, nullptr));
2526   EXPECT_FALSE(main_list.GetDictionary(2, nullptr));
2527   EXPECT_FALSE(main_list.GetDictionary(3, nullptr));
2528   EXPECT_FALSE(main_list.GetDictionary(4, nullptr));
2529   EXPECT_TRUE(main_list.GetDictionary(5, nullptr));
2530   EXPECT_FALSE(main_list.GetDictionary(6, nullptr));
2531   EXPECT_FALSE(main_list.GetDictionary(7, nullptr));
2532
2533   EXPECT_FALSE(main_list.GetList(0, nullptr));
2534   EXPECT_FALSE(main_list.GetList(1, nullptr));
2535   EXPECT_FALSE(main_list.GetList(2, nullptr));
2536   EXPECT_FALSE(main_list.GetList(3, nullptr));
2537   EXPECT_FALSE(main_list.GetList(4, nullptr));
2538   EXPECT_FALSE(main_list.GetList(5, nullptr));
2539   EXPECT_TRUE(main_list.GetList(6, nullptr));
2540   EXPECT_FALSE(main_list.GetList(7, nullptr));
2541 }
2542
2543 TEST(ValuesTest, SelfSwap) {
2544   base::Value test(1);
2545   std::swap(test, test);
2546   EXPECT_EQ(1, test.GetInt());
2547 }
2548
2549 TEST(ValuesTest, FromToUniquePtrValue) {
2550   std::unique_ptr<DictionaryValue> dict = std::make_unique<DictionaryValue>();
2551   dict->SetStringKey("name", "Froogle");
2552   dict->SetStringKey("url", "http://froogle.com");
2553   Value dict_copy = dict->Clone();
2554
2555   Value dict_converted = Value::FromUniquePtrValue(std::move(dict));
2556   EXPECT_EQ(dict_copy, dict_converted);
2557
2558   std::unique_ptr<Value> val =
2559       Value::ToUniquePtrValue(std::move(dict_converted));
2560   EXPECT_EQ(dict_copy, *val);
2561 }
2562
2563 TEST(ValuesTest, MutableFindStringPath) {
2564   Value dict(Value::Type::DICTIONARY);
2565   dict.SetStringPath("foo.bar", "value");
2566
2567   *(dict.FindStringPath("foo.bar")) = "new_value";
2568
2569   Value expected_dict(Value::Type::DICTIONARY);
2570   expected_dict.SetStringPath("foo.bar", "new_value");
2571
2572   EXPECT_EQ(expected_dict, dict);
2573 }
2574
2575 TEST(ValuesTest, MutableGetString) {
2576   Value value("value");
2577   value.GetString() = "new_value";
2578   EXPECT_EQ("new_value", value.GetString());
2579 }
2580
2581 }  // namespace base