Initialize Tizen 2.3
[framework/web/webkit-efl.git] / Tools / ChangeLog-2012-10-02
1 2012-10-02  Daniel Bates  <dbates@webkit.org>
2
3         Define watch list "webkitperl", "SVNScripts", and "XSS" to watch for changes
4         to Tools/Scripts/{VCSUtils.pm, webkitdirs.pm, webkitperl}, Tools/Scripts/svn-*
5         scripts, and files whose name contains the word "XSS", respectively. Subscribe
6         myself to these lists.
7
8         * Scripts/webkitpy/common/config/watchlist:
9
10 2012-10-02  Roger Fong  <roger_fong@apple.com>
11
12         executive_unittest.py fails on Apple Windows bots but not when run locally.
13         https://bugs.webkit.org/show_bug.cgi?id=98196
14
15         Reviewed by Eric Seidel.
16
17         Making the test more flexible to check for cygwin and allow different outputs from process.wait().
18
19         * Scripts/webkitpy/common/system/executive_unittest.py:
20         (ExecutiveTest.serial_test_kill_process):
21
22 2012-10-02  Roger Fong  <roger_fong@apple.com>
23
24         Ignore failing line of SpacebarScrolling API test on Windows.
25         https://bugs.webkit.org/show_bug.cgi?id=84961
26
27         Reviewed by Anders Carlsson.
28
29         Test is failing because of https://bugs.webkit.org/show_bug.cgi?id=97946.
30         Ignoring the line that fails on Windows for now until the larger problem at hand is fixed.
31
32         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
33         (TestWebKitAPI::TEST):
34
35 2012-10-02  Tony Chang  <tony@chromium.org>
36
37         check-webkit-style can't handle qt-arm, qt-win, qt-mac, qt-5.0, qt-5.0-wk1 and qt-5.0-wk2 TestExpecatations
38         https://bugs.webkit.org/show_bug.cgi?id=98140
39
40         Reviewed by Eric Seidel.
41
42         Fix a bug where we were always using the host OS rather than using what was passed in as part of the
43         port name on Qt.
44
45         There's also a bug with being able to test for qt-5.0 expectations files when on a system with
46         Qt 4.8 installed. I'm not sure how to solve that, so for now, stop emitting a style warning about
47         not checking a file.
48
49         * Scripts/webkitpy/layout_tests/port/qt.py:
50         (QtPort._search_paths): Use passed in OS.
51         * Scripts/webkitpy/style/checkers/test_expectations.py:
52         (TestExpectationsChecker.check): Don't warn if we don't know about the TestExpectations file.
53         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
54         (TestExpectationsTestCase.test_determine_port_from_expectations_path): Added a test case for the OS fix.
55         Add a commented out test for the version case.
56
57 2012-10-02  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
58
59         Remove the last bits of MSYS support from webkitperl.
60         https://bugs.webkit.org/show_bug.cgi?id=98195
61
62         Reviewed by Eric Seidel.
63
64         No ports currently need MinGW/MSYS support, so remove the last
65         hackish bits related to it from our Perl code.
66
67         * Scripts/commit-log-editor:
68         (createCommitMessage):
69         * Scripts/old-run-webkit-tests:
70         * Scripts/webkitdirs.pm:
71         (isAnyWindows):
72         (isWindows):
73
74 2012-10-02  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
75
76         Remove MSYS-related changes to the http testing infrastructure.
77         https://bugs.webkit.org/show_bug.cgi?id=98183
78
79         Reviewed by Eric Seidel.
80
81         In the process of removing the cruft that has accumulated in our
82         Apache configuration code, we can basically revert r77161 which
83         added some MSYS (mingw)-specific code to old-run-webkit-tests,
84         since it is not being used by any port anymore.
85
86         * Scripts/run-webkit-httpd: Remove isMsys()-dependent hacks.
87         * Scripts/webkitperl/httpd.pm:
88         (getHTTPDPath): Remove isMsys() code path.
89         (getDefaultConfigForTestDirectory): Revert isMsys() hacks.
90         (getHTTPDConfigPathForTestDirectory): Do not point to the noew
91         removed apache2-msys-httpd.conf.
92         (convertMsysPath): Removed.
93
94 2012-10-02  Sadrul Habib Chowdhury  <sadrul@chromium.org>
95
96         [chromium] Make sure the touch-points in the touch-events have the correct state.
97         https://bugs.webkit.org/show_bug.cgi?id=98110
98
99         Reviewed by Adam Barth.
100
101         TestWebPlugin can now be configured to print out some details about
102         events. For now, details for only touch events are printed. This is
103         used to verify that touch-points in the touch-events are properly
104         set.
105
106         * DumpRenderTree/chromium/TestWebPlugin.cpp:
107         (pointState):
108         (printTouchList):
109         (printEventDetails):
110         (TestWebPlugin::TestWebPlugin):
111         (TestWebPlugin::handleInputEvent):
112         * DumpRenderTree/chromium/TestWebPlugin.h:
113         (TestWebPlugin):
114
115 2012-10-02  Zan Dobersek  <zandobersek@gmail.com>
116
117         [XvfbDriver] First tests in each worker occasionally crash
118         https://bugs.webkit.org/show_bug.cgi?id=96203
119
120         Reviewed by Dirk Pranke.
121
122         Often in debug builds, the first tests in each worker crash because they
123         can't yet open the Xvfb display assigned to them. This indicates Xvfb hasn't
124         yet been set up.
125
126         To avoid this, the execution should halt for a small amount of time before tests
127         are run so the Xvfb process has enough time to get ready. At the moment this is
128         done right after the Xvfb process is spawned and the execution halts for one
129         second. That value is overriden to zero when testing to not prolong the testing time.
130
131         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
132         (XvfbDriver.__init__):
133         (XvfbDriver._start):
134         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
135         (XvfbDriverTest.make_driver):
136
137 2012-10-02  Christophe Dumez  <christophe.dumez@intel.com>
138
139         [EFL] Use XvfbDriver for layout tests
140         https://bugs.webkit.org/show_bug.cgi?id=98162
141
142         Reviewed by Kenneth Rohde Christiansen.
143
144         Use XvfbDriver for layout tests on EFL port.
145
146         * Scripts/webkitpy/layout_tests/port/efl.py:
147         (EflPort._driver_class):
148         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
149         (XvfbDriver._start): Set DUMPRENDERTREE_TEMP and LOCAL_RESOURCE_ROOT
150         environment variables in XvfbDriver as those are needed for
151         TestRunner::pathToLocalResource().
152
153 2012-10-02  Zan Dobersek  <zandobersek@gmail.com>
154
155         [Gtk] Several tests launch g_object_ref/unref assertion messages
156         https://bugs.webkit.org/show_bug.cgi?id=95062
157
158         Reviewed by Martin Robinson.
159
160         Only increase and decrease reference count of the accessibility
161         UI element if it actually exists.
162
163         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
164         (AccessibilityUIElement::AccessibilityUIElement):
165         (AccessibilityUIElement::~AccessibilityUIElement):
166
167 2012-10-02  Douglas Stockwell  <dstockwell@chromium.org>
168
169         [chromium] running layout tests on mountainlion should use chromium TestExpectations
170         https://bugs.webkit.org/show_bug.cgi?id=98119
171
172         Reviewed by Adam Barth.
173
174         Some basic support for mountainlion has already been committed but it failed to refer
175         to the chromium TestExpectations.
176
177         * Scripts/webkitpy/layout_tests/port/chromium.py:
178         (ChromiumPort):
179         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
180         (ChromiumPortTestCase.test_all_test_configurations):
181
182 2012-10-02  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
183
184         webkitpy: Stop listening on port 8081 when using Apache.
185         https://bugs.webkit.org/show_bug.cgi?id=98155
186
187         Reviewed by Eric Seidel.
188
189         No test currently uses this port, and the lighttpd configuration
190         does not open it.
191
192         This helps the efforts of bringing some consistency to the Apache
193         configuration at the moment by opening the same ports in the
194         webkitpy side and in the httpd.conf side (the idea is to remove
195         the httpd.conf side later), and also makes the behavior consistent
196         across the two servers we currently support.
197
198         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
199         (LayoutTestApacheHttpd.__init__):
200
201 2012-10-02  Csaba Osztrogonác  <ossy@webkit.org>
202
203         [WK2] REGRESSION(r128623): It made layout tests extremely slow
204         https://bugs.webkit.org/show_bug.cgi?id=96862
205
206         Reviewed by Simon Hausmann.
207
208         Disable calling the extremely slow WKBundleSetDatabaseQuota() between tests until proper fix.
209
210         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
211         (WTR::InjectedBundle::beginTesting):
212
213 2012-10-02  Philip Rogers  <pdr@google.com>
214
215         Fix PerfTest standard deviation calculation.
216         https://bugs.webkit.org/show_bug.cgi?id=98115
217
218         Reviewed by Ryosuke Niwa.
219
220         Previously our standard deviation calculation was incorrect. This patch
221         updates perftest.py's algorithm to calculate the sample standard deviation
222         (with Bessel's correction) using Knuth's online algorithm:
223         http://en.wikipedia.org/wiki/Algorithms_for_calculating_variance#Online_algorithm
224         An existing test has been modified to prove our new results.
225
226         This patch also updates runner.js to use Bessel's correction in
227         its sample standard deviation calculation, which is more accurate
228         for small sample sizes.
229
230         Additionally, runner.js has been modified to not calculate
231         the 'sum' statistic, which was not very useful.
232
233         * Scripts/webkitpy/performance_tests/perftest.py:
234
235             The unused variable valueSum has also been removed.
236
237         (PageLoadingPerfTest.run):
238         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
239
240             This test calculates the stdev of {2000, 3000, ..., 20000} which
241             was hand-calculated using a spreadsheet.
242
243         (TestPageLoadingPerfTest.test_run):
244
245 2012-10-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
246
247         webkitpy should accept a different httpd.conf specified by the user
248         https://bugs.webkit.org/show_bug.cgi?id=98071
249
250         Reviewed by Dirk Pranke.
251
252         The existing httpd.conf variants (or lighttpd.conf, for that
253         matter) we have do not always suit the user's system. This is
254         particularly true on Linux/Unix, where Apache can be installed in
255         a plethora of ways and the LoadModule calls can fail to specify
256         the proper module paths.
257
258         For now, we start accepting the WEBKIT_HTTP_SERVER_CONF_PATH
259         environment variable, which allows the user to specify the
260         absolute path to another http server configuration file that might
261         work on the user's system.
262
263         In the long term, we should try to generate our configuration file
264         and stop requiring all the different httpd.conf files we have as
265         well as this hack.
266
267         * Scripts/webkitpy/layout_tests/port/base.py:
268         (Port._path_to_apache_config_file):
269         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
270         (test_path_to_apache_config_file):
271
272 2012-10-01  Emil A Eklund  <eae@chromium.org>
273
274         Unreviewed, upgrade eae to reviewer. 
275         http://lists.webkit.org/mailman/private/webkit-committers/2012-October/000191.html
276
277         * Scripts/webkitpy/common/config/committers.py:
278
279 2012-10-01  Ming Xie  <mxie@rim.com>
280
281         [BlackBerry] Add a early return in buildCMakeProjectOrExit()
282         https://bugs.webkit.org/show_bug.cgi?id=98052
283
284         Reviewed by Rob Buis.
285
286         This option allows our build to only run the CMake build configuration
287         step when environment variable GENERATE_CMAKE_PROJECT_ONLY is specified.
288
289         * Scripts/webkitdirs.pm:
290         (buildCMakeProjectOrExit):
291
292 2012-10-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
293
294         [webkitpy] Detect the multiple names of the wdiff binary in the Port class.
295         https://bugs.webkit.org/show_bug.cgi?id=98039
296
297         Reviewed by Dirk Pranke.
298
299         Unify the duplicate checks for the wdiff binary present in
300         different ports into the base Port class.
301
302         * Scripts/webkitpy/layout_tests/port/base.py:
303         (Port):
304         (Port._path_to_wdiff):
305         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
306         (ChromiumLinuxPort._path_to_wdiff): Removed.
307         * Scripts/webkitpy/layout_tests/port/gtk.py:
308         (GtkPort._path_to_wdiff): Removed.
309
310 2012-10-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
311
312         [chromium] Remove custom implementation of _path_to_apache_config_file in chromium_linux.
313         https://bugs.webkit.org/show_bug.cgi?id=98042
314
315         Reviewed by Dirk Pranke.
316
317         The Chromium-based ports inherit from Port these days, so get rid
318         of the custom implementation of _path_to_apache_config_file() in
319         favor of the more portable one in the Port class.
320
321         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
322         (ChromiumLinuxPort._path_to_apache_config_file):
323
324 2012-10-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
325
326         [chromium] Remove duplicated _is_redhat_based() implementation from chromium_linux.py.
327         https://bugs.webkit.org/show_bug.cgi?id=98035
328
329         Reviewed by Dirk Pranke.
330
331         Since the Chromium port classes inherit from Port these days, it
332         can rely on the same implementation of _is_redhat_based() present
333         there instead of duplicating it.
334
335         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
336         (ChromiumLinuxPort._is_redhat_based): Removed.
337
338 2012-10-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
339
340         [GTK] Rely on the general implementation for detecting the Apache server path.
341         https://bugs.webkit.org/show_bug.cgi?id=98033
342
343         Reviewed by Martin Robinson.
344
345         The implemenentation of _path_to_apache() in base.py already
346         checks for the same paths gtk.py tries; the only difference is
347         that all of the are tried regardless of the current distro.
348
349         Doing so is more portable, and lets us remove some distro-checking
350         from the code.
351
352         * Scripts/webkitpy/layout_tests/port/gtk.py:
353         (GtkPort._path_to_apache): Remove.
354
355 2012-10-01  Csaba Osztrogonác  <ossy@webkit.org>
356
357         Unreviewed, update the URL of the Szeged SVN mirror.
358
359         * BuildSlaveSupport/build.webkit.org-config/config.json:
360
361 2012-10-01  Yuta Kitamura  <yutak@chromium.org>
362
363         Unreviewed. Create WebSocket watch list, and add myself to that list.
364
365         * Scripts/webkitpy/common/config/watchlist:
366
367 2012-09-30  Taiju Tsuiki  <tzik@chromium.org>
368
369         Unreviewed. Adding myself as a committer.
370
371         * Scripts/webkitpy/common/config/committers.py:
372
373 2012-09-30  Sadrul Habib Chowdhury  <sadrul@chromium.org>
374
375         [chromium] Add a test to verify that a plugin does not receive touch-events unless it explicitly requests for them
376         https://bugs.webkit.org/show_bug.cgi?id=97975
377
378         Reviewed by Adam Barth.
379
380         TestWebPlugin can now be configured to accept touch events or not. Use this
381         configurability to verify that a plugin does not receive touch events unless
382         it explicitly requests for them.
383
384         * DumpRenderTree/chromium/TestWebPlugin.cpp:
385         (TestWebPlugin::TestWebPlugin):
386         (TestWebPlugin::initialize):
387         (TestWebPlugin::parseBoolean):
388         * DumpRenderTree/chromium/TestWebPlugin.h:
389         (TestWebPlugin):
390
391 2012-09-28  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
392
393         [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port
394         https://bugs.webkit.org/show_bug.cgi?id=91844
395
396         Reviewed by Simon Hausmann.
397
398         Turn on Netscape Plugin API option by default.
399
400         * Scripts/webkitperl/FeatureList.pm:
401
402 2012-09-28  Dirk Pranke  <dpranke@chromium.org>
403
404         webkit-patch rebaseline-expectations is broken
405         https://bugs.webkit.org/show_bug.cgi?id=97619
406
407         Reviewed by Ojan Vafai.
408
409         The new expectations format is causing two problems for
410         webkit-patch rebaseline expectations
411
412         1) the transformation into and out of the old syntax (which is
413         still used internally) is somewhat lossy, e.g., we're not
414         preserving the case of Bug(x) identifiers. Also, we can't
415         tell if the input was [ WontFix ] or [ Skip WontFix Pass ]
416         2) the new syntax is more lenient, allowing for multiple ways to
417         specify the same result, e.g., "[ Skip ]" may or may not be
418         missing.
419
420         As a result, we end up rewriting a whole bunch of lines for
421         purely syntactic differences.
422
423         Both of these things are bugs that need to be fixed, but
424         we should also not just rewrite lines that shouldn't be
425         modified.
426
427         This patch fixes the last issue (no rewriting).
428
429         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
430         (TestExpectationLine._format_line):
431         (TestExpectations.remove_rebaselined_tests):
432         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
433         (RebaseliningTest.test_remove):
434
435 2012-09-28  Dirk Pranke  <dpranke@chromium.org>
436
437         virtual directories should just rename the beginning of the test path
438         https://bugs.webkit.org/show_bug.cgi?id=97925
439
440         Reviewed by Ojan Vafai.
441
442         We were replacing all occurrences of the base prefix of a
443         virtual test suite with the virtual name, instead of just the
444         first. So, where we had softwarecompositing running the
445         compositing tests, any compositing test that actually had
446         "compositing" in the test base name would get that expanded
447         incorrectly.
448
449         * Scripts/webkitpy/layout_tests/port/base.py:
450         (Port.populated_virtual_test_suites):
451         (Port.lookup_virtual_test_base):
452         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
453         (PortTest.test_tests):
454         * Scripts/webkitpy/layout_tests/port/test.py:
455
456 2012-09-28  Ojan Vafai  <ojan@chromium.org>
457
458         Garden-o-matic sometimes things buildbot warnings are failures
459         https://bugs.webkit.org/show_bug.cgi?id=97926
460
461         Reviewed by Tony Chang.
462
463         It turns out the JSON clearly tells us if it's a failure.
464         We want to skip all warnings even if they don't have "warning" in the text.
465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
467
468 2012-09-28  Harald Tveit Alvestrand  <harald@alvestrand.no>
469
470         Implement the GetStats interface on PeerConnection
471         https://bugs.webkit.org/show_bug.cgi?id=95193
472
473         Reviewed by Adam Barth.
474
475         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
476         (RTCStatsRequestSucceededTask):
477         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
478         (MockWebRTCPeerConnectionHandler::getStats):
479         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
480         (MockWebRTCPeerConnectionHandler):
481
482 2012-09-28  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
483
484         [NRWT] XvfbDriver should choose the next free display
485         https://bugs.webkit.org/show_bug.cgi?id=88414
486
487         Reviewed by Dirk Pranke.
488
489         This change how the XvfbDriver choose the next display. Before
490         this the choosing are based on the worker number but it caused
491         errors when several nrwt run on the same time. This add process
492         based free diplay search.
493
494         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
495         (XvfbDriver.__init__):
496         (XvfbDriver._next_free_display):
497         (XvfbDriver._start):
498         (XvfbDriver.stop):
499         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
500         (XvfbDriverTest.make_driver):
501         (XvfbDriverTest.test_start_no_pixel_tests):
502         (XvfbDriverTest.test_start_pixel_tests):
503         (XvfbDriverTest.test_start_arbitrary_worker_number):
504         (XvfbDriverTest.test_next_free_display):
505         (XvfbDriverTest):
506         (XvfbDriverTest.test_start_next_worker):
507
508 2012-09-28  Huang Dongsung  <luxtella@company100.net>
509
510         [GTK] Enable CSS Shaders layout LayoutTests on GTK+
511         https://bugs.webkit.org/show_bug.cgi?id=97821
512
513         Reviewed by Martin Robinson.
514
515         This feature is disabled via Settings by default, but for testing,
516         we enable it using layoutTestController.overridePreferences. Add the
517         necessary plumbing for DRT.
518
519         WTR already works because support was added for Apple Mac earlier.
520
521         * DumpRenderTree/gtk/DumpRenderTree.cpp:
522         (resetDefaultsToConsistentValues): Feature is off by default.
523         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
524         (TestRunner::overridePreference): Add handling of WebKitCSSCustomFilterEnabled.
525
526 2012-09-28  Csaba Osztrogonác  <ossy@webkit.org>
527
528         [Qt] Make NRWT use wk2/TestExpectations file
529         https://bugs.webkit.org/show_bug.cgi?id=97894
530
531         Reviewed by Simon Hausmann.
532
533         * Scripts/webkitpy/layout_tests/port/qt.py: Remove unnecessary _skipped_file_search_paths function.
534         (QtPort.expectations_files): Add wk2 if --webkit-test-runner option added.
535         * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Remove unnecessary test__skipped_file_search_paths function.
536         (QtPortTest._assert_search_path): Removed.
537         (QtPortTest.test_expectations_files): Add wk2 if --webkit-test-runner option added, and code cleanup.
538
539 2012-09-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
540
541         [EFL][DRT] EFL's layoutTestController.keepWebHistory should enable visited links tracking
542         https://bugs.webkit.org/show_bug.cgi?id=97901
543
544         Reviewed by Kenneth Rohde Christiansen.
545
546         EFL's DRT testRunner.keepWebHistory should enable visited links tracking in order
547         to be consistent with WTR implementation and also several tests rely on that (fast/history).
548
549         * DumpRenderTree/efl/TestRunnerEfl.cpp:
550         (TestRunner::keepWebHistory):
551
552 2012-09-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
553
554         [EFL][DRT] EFL DRT should disable visited links tracking by default
555         https://bugs.webkit.org/show_bug.cgi?id=97881
556
557         Reviewed by Kenneth Rohde Christiansen.
558
559         Visited links tracking is disabled by default for each test.
560
561         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
562         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
563
564 2012-09-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
565
566         Unreviewed, rolling out r129863.
567         http://trac.webkit.org/changeset/129863
568         https://bugs.webkit.org/show_bug.cgi?id=97173
569
570         Broken debug WK2 layout test
571
572         * MiniBrowser/efl/main.c:
573         (quit):
574         (main):
575         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
576         (WTR::initEcoreEvas):
577         (WTR::PlatformWebView::~PlatformWebView):
578         * WebKitTestRunner/efl/main.cpp:
579         (main):
580
581 2012-09-28  Kai Koehne  <kai.koehne@digia.com>
582
583         [Qt] Use qInstallMessageHandler()
584         https://bugs.webkit.org/show_bug.cgi?id=96648
585
586         Reviewed by Jocelyn Turcotte.
587
588         qInstallMsgHandler() got deprecated in Qt 5.
589
590         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
591         (messageHandler):
592         (main):
593         * WebKitTestRunner/qt/main.cpp:
594         (messageHandler):
595         (main):
596
597 2012-09-28  Eunmi Lee  <eunmi15.lee@samsung.com>
598
599         [EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries.
600         https://bugs.webkit.org/show_bug.cgi?id=97173
601
602         Reviewed by Gyuyoung Kim.
603
604         The initialization and shutdown are done inside the webkit, so we don't
605         have to call them out of the webkit.
606
607         * MiniBrowser/efl/main.c:
608         (quit):
609         (main):
610         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
611         (WTR::initEcoreEvas):
612         (WTR::PlatformWebView::~PlatformWebView):
613         * WebKitTestRunner/efl/main.cpp:
614         (main):
615
616 2012-09-27  Alexandre Elias  <aelias@chromium.org>
617
618         [chromium] DumpRenderTree support for software compositing
619         https://bugs.webkit.org/show_bug.cgi?id=96853
620
621         Reviewed by James Robinson.
622
623         This adds software compositor support to DumpRenderTree.  The only
624         thing needed is a minimal OutputSurfaceSoftware that holds a
625         viewport-sized bitmap. Then, I added virtual test suite
626         platform/chromium/virtual/softwarecompositing -- a mirror of the
627         compositing/ directory with --enable-software-compositing, and
628         expectations for not yet supported tests.
629
630         * DumpRenderTree/DumpRenderTree.gypi:
631         * DumpRenderTree/chromium/DumpRenderTree.cpp:
632         (main):
633         * DumpRenderTree/chromium/TestShell.cpp:
634         (TestShell::TestShell):
635         * DumpRenderTree/chromium/TestShell.h:
636         (TestShell::softwareCompositingEnabled):
637         (TestShell::setSoftwareCompositingEnabled):
638         (TestShell):
639         * DumpRenderTree/chromium/WebViewHost.cpp:
640         (WebViewHost::createOutputSurface):
641         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp:
642         (WebKit::WebViewHostOutputSurface::create3d):
643         (WebKit):
644         (WebKit::WebViewHostOutputSurface::createSoftware):
645         (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
646         (WebKit::WebViewHostOutputSurface::bindToClient):
647         (WebKit::WebViewHostOutputSurface::surfaceSoftware):
648         * DumpRenderTree/chromium/WebViewHostOutputSurface.h:
649         (WebKit):
650         (WebViewHostOutputSurface):
651         * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.
652         (WebKit):
653         (WebKit::WebViewHostSoftwareOutputDevice::lockForWrite):
654         (WebKit::WebViewHostSoftwareOutputDevice::unlockForWrite):
655         (WebKit::WebViewHostSoftwareOutputDevice::lockForRead):
656         (WebKit::WebViewHostSoftwareOutputDevice::unlockForRead):
657         (WebKit::WebViewHostSoftwareOutputDevice::viewportChanged):
658         * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Copied from Tools/DumpRenderTree/chromium/WebViewHostOutputSurface.cpp.
659         (WebKit):
660         (WebViewHostSoftwareOutputDevice):
661         * Scripts/webkitpy/layout_tests/port/chromium.py:
662         (ChromiumPort.virtual_test_suites):
663
664 2012-09-27  Nasko Oskov  <nasko@chromium.org>
665
666         Move DumpRenderTree to use newer version of the name method of
667         WebFrame and the willCheckAndDispatchMessageEvent method of WebFrameClient
668         https://bugs.webkit.org/show_bug.cgi?id=95254
669
670         Reviewed by Adam Barth.
671
672         The WebFrame name() method is removed and replaced by better named
673         uniqueName() method, so DRT needs to be updated to use this new version.
674         Also the willCheckAndDispatchMessageEvent in WebFrameClient gained
675         one more parameter, which had to be added in DRT.
676
677         * DumpRenderTree/chromium/TestShell.cpp:
678         (dumpFramesAsText):
679         (dumpFramesAsPrintedText):
680         (dumpFrameScrollPosition):
681         * DumpRenderTree/chromium/WebViewHost.cpp:
682         (WebViewHost::unableToImplementPolicyWithError):
683         (WebViewHost::willCheckAndDispatchMessageEvent):
684         (WebViewHost::printFrameDescription):
685         * DumpRenderTree/chromium/WebViewHost.h:
686         (WebViewHost):
687
688 2012-09-27  Julie Parent  <jparent@chromium.org>
689
690         Add webkit_unit_tests to the flakiness dashboard
691         https://bugs.webkit.org/show_bug.cgi?id=97814
692
693         Reviewed by Dirk Pranke.
694
695         webkit_unit_tests run on the same bots as test_shell_tests.
696
697         * TestResultServer/static-dashboards/builders.js:
698         (loadBuildersList):
699         * TestResultServer/static-dashboards/dashboard_base.js:
700         (currentBuilderGroupCategory):
701
702 2012-09-27  Florin Malita  <fmalita@chromium.org>
703
704         [Perftest] PerfTestRunner exception when using nested git checkouts
705         https://bugs.webkit.org/show_bug.cgi?id=97796
706
707         Reviewed by Ryosuke Niwa.
708
709         In order to support separate Chromium vs. WebKit git trees, PerfTestsRunner needs to
710         instantiate per-repository SCM objects when collecting revision information.
711
712         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
713         (PerfTestsRunner._generate_results_dict):
714
715 2012-09-27  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
716
717         [Mac][DRT] Add support to allow non-array modifier arguments in keyDown()
718         https://bugs.webkit.org/show_bug.cgi?id=97805
719
720         Reviewed by Alexey Proskuryakov.
721
722         Add support for handling a string as modifier argument to keyDown().
723         This support has already been added to other ports, so implementing
724         this on Mac too, to be consistent with the other ports.
725
726         * DumpRenderTree/mac/EventSendingController.mm:
727         (modifierFlags):
728         (buildModifierFlags):
729
730 2012-09-27  Dirk Pranke  <dpranke@chromium.org>
731
732         efl wk2 bots weren't looking at platform/wk2/TestExpectations
733         https://bugs.webkit.org/show_bug.cgi?id=97815
734
735         Unreviewed, build fix.
736
737         Should clean up this logic later so that we're just using the
738         implementation in base ...
739
740         * Scripts/webkitpy/layout_tests/port/efl.py:
741         (EflPort._search_paths):
742         (EflPort.expectations_files):
743
744 2012-09-27  Dirk Pranke  <dpranke@chromium.org>
745
746         webkitpy: make warning about missing BUG identifiers per-port configurable
747         https://bugs.webkit.org/show_bug.cgi?id=97751
748
749         Reviewed by Ojan Vafai.
750
751         Prior to this change linting TestExpectations files (checking their style)
752         would raise warnings if lines were missing a BUG modifier, even
753         though such a modifier is actually optional in the syntax. As we
754         migrate the entries over from the Skipped files, these warnings
755         will generate a lot of noise, and it's not yet clear that we
756         actually want to require the modifiers on all ports.
757
758         So, this change makes this per-port configurable so that they
759         will generate warnings in the Chromium TestExpectations and not
760         anywhere else.
761
762         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
763         (TestExpectationParser._parse_modifiers):
764         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
765         (MiscTests.test_parse_warning):
766         (SemanticTests.test_missing_bugid):
767         * Scripts/webkitpy/layout_tests/port/base.py:
768         (Port.warn_if_bug_missing_in_test_expectations):
769         * Scripts/webkitpy/layout_tests/port/chromium.py:
770         (ChromiumPort.warn_if_bug_missing_in_test_expectations):
771
772 2012-09-27  Xianzhu Wang  <wangxianzhu@chromium.org>
773
774         [Chromium-Android] Push more fonts for layout tests to match chromium-linux
775         https://bugs.webkit.org/show_bug.cgi?id=97746
776
777         Reviewed by Dirk Pranke.
778
779         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added the new fonts into fallback list. Removed the Android system fallback font DroidSansFallback.ttf.
780         * Scripts/webkitpy/layout_tests/port/builders.py: Add chromium-android to pass style check.
781         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
782         (ChromiumAndroidPort.check_build): Added check for md5sum and forwarder utilities to give better error message when they are missing.
783         (ChromiumAndroidPort.check_sys_deps): Allow host font files to come from one of multiple directories.
784         (ChromiumAndroidPort._path_to_md5sum):
785         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
786         (ChromiumAndroidDriver._push_fonts):
787         (ChromiumAndroidDriver._push_test_resources):
788
789 2012-09-27  Tommy Widenflycht  <tommyw@google.com>
790
791         MediaStream API: Enhance MediaConstraints to make it easier to get the constraint data
792         https://bugs.webkit.org/show_bug.cgi?id=97559
793
794         Reviewed by Adam Barth.
795
796         Refactoring for the new WebMediaConstraints api.
797
798         * DumpRenderTree/chromium/MockConstraints.cpp:
799         (MockConstraints::verify):
800
801 2012-09-27  Tommy Widenflycht  <tommyw@google.com>
802
803         MediaStream API: Rename MockConstraints::verify to verifyConstraints
804         https://bugs.webkit.org/show_bug.cgi?id=97779
805
806         Reviewed by Csaba Osztrogonác.
807
808         The Mac OS X sdk has a macro called verify :/
809
810         * DumpRenderTree/chromium/MockConstraints.cpp:
811         (MockConstraints::verifyConstraints):
812         * DumpRenderTree/chromium/MockConstraints.h:
813         (MockConstraints):
814         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
815         (MockWebRTCPeerConnectionHandler::initialize):
816         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
817         (WebUserMediaClientMock::requestUserMedia):
818
819 2012-09-27  Tommy Widenflycht  <tommyw@google.com>
820
821         MediaStream API: Update getUserMedia to match the latest specification
822         https://bugs.webkit.org/show_bug.cgi?id=97540
823
824         Reviewed by Adam Barth.
825
826         http://dev.w3.org/2011/webrtc/editor/getusermedia.html#navigatorusermedia
827         Navigator.getUserMedia is changed so that the audio and video members can either
828         be a bool or a constraints object.
829
830         * public/WebUserMediaRequest.h:
831         (WebKit):
832         (WebUserMediaRequest):
833         * src/WebUserMediaRequest.cpp:
834         (WebKit::WebUserMediaRequest::audioConstraints):
835         (WebKit):
836         (WebKit::WebUserMediaRequest::videoConstraints):
837
838 2012-09-26  Laszlo Gombos  <l.gombos@samsung.com>
839
840         Unreviewed. Update my e-mail address.
841
842         * Scripts/webkitpy/common/config/committers.py:
843
844 2012-09-26  Dirk Pranke  <dpranke@chromium.org>
845
846         modify old-run-webkit-tests to support TestExpectations files a little
847         https://bugs.webkit.org/show_bug.cgi?id=97276
848
849         Reviewed by Daniel Bates.
850
851         This patch adds minimal support to old-run-webkit-tests so that
852         it can read a TestExpectations file and skip the tests listed
853         there. It will skip *all* tests, regardless of the expectation
854         (even if the test is listed as [ Pass ]), and it will only look
855         at the TestExpectations file if there isn't a Skipped file next
856         to it.
857         
858         This will allow us to switch to using just using
859         TestExpectations files without making old-run-webkit-tests
860         totally useless.
861
862         * Scripts/old-run-webkit-tests:
863         (readSkippedFiles):
864         (processSkippedFileEntry): Added.
865         (startsWith): Added.
866
867 2012-09-26  Dirk Pranke  <dpranke@chromium.org>
868
869         The style bot spams about skia_test_expectations.txt
870         https://bugs.webkit.org/show_bug.cgi?id=97699
871
872         Reviewed by Adam Barth.
873
874         Remove the warning about a missing skia_test_expectations.txt
875         file for now. There are some situations where it would be
876         helpful to get this warning as it might indicate that the user
877         is going to get results different than what they're expecting,
878         but at the moment it looks difficult if not impossible to get
879         those warnings and not also get warnings that we don't care
880         about, so the noise is outweighing the value of the signal.
881
882         This at least will stop the false negatives we're getting on the
883         style bots. If it turns out people do need the warning we can
884         add it back in in some other more conditional way.
885
886         * Scripts/webkitpy/layout_tests/port/chromium.py:
887         (ChromiumPort.expectations_files):
888         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
889         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
890         (test_rebaseline_updates_expectations_file):
891         (test_rebaseline_does_not_include_overrides):
892         (test_rebaseline_expectations):
893         (_assert_command):
894
895 2012-09-26  David Michael Barr  <davidbarr@chromium.org>
896
897         Unreviewed. Upgrade myself from contributor to committer.
898
899         * Scripts/webkitpy/common/config/committers.py:
900
901 2012-09-26  Ryosuke Niwa  <rniwa@webkit.org>
902
903         Remove deprecated code from perftestrunner.py
904         https://bugs.webkit.org/show_bug.cgi?id=97724
905
906         Reviewed by Adam Barth.
907
908         Remove the code deprecated in r129580 now that we have landed r129597,
909         which updated master.cfg to use new options, and restarted the buildbot master.
910
911         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
912         (PerfTestsRunner._parse_args):
913         (PerfTestsRunner._generate_and_show_results):
914         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
915         (test_run_with_slave_config_json):
916         (test_parse_args):
917
918 2012-09-26  Beth Dakin  <bdakin@apple.com>
919
920         https://bugs.webkit.org/show_bug.cgi?id=97629
921         http/tests/security/cross-frame-access-put.html failing on Mac WK2 bots after 
922         being unskipped
923
924         Reviewed by Tim Horton.
925
926         The test was failing because we were failing to use the fake window origin. We 
927         should really always use the fake origin. This patch eliminates 
928         _shouldUseFakeOrigin in favor of always using it.
929         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
930         (-[WebKitTestRunnerWindow setFrameOrigin:]):
931         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
932         (-[WebKitTestRunnerWindow setFrame:display:]):
933         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
934
935 2012-09-26  Tony Chang  <tony@chromium.org>
936
937         C++ style checker should warn when the indentation is wrong
938         https://bugs.webkit.org/show_bug.cgi?id=97602
939
940         Reviewed by Ojan Vafai.
941
942         Rewrite the indentation checker to ensure that indentation is always a factor of 4
943         and that we only indent 4 spaces from the previous line.
944
945         I deleted some of the old indentation checking code since it was filtered out
946         and didn't match the webkit style.
947
948         * Scripts/webkitpy/style/checker.py:
949         * Scripts/webkitpy/style/checkers/cpp.py:
950         (check_indentation_amount): New function that checks indentation. Intentionally runs after
951         other indentation checks.
952         (check_style): Delete the old indentation code since we were already filtering out the whitespace/labels warnings.
953         (CppChecker): Remove the whitespace/labels filter.
954         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
955         (CppStyleTest.test_multi_line_comments): Force 4 space indent.
956         (CppStyleTest.test_explicit_single_argument_constructors):
957         (CppStyleTest.test_explicit_single_argument_constructors.Foo):
958         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier):
959         (CppStyleTest.test_slash_star_comment_on_single_line):
960         (CppStyleTest.test_braces):
961         (CppStyleTest.test_spacing_before_last_semicolon):
962         (CppStyleTest.test_static_or_global_stlstrings):
963         (CppStyleTest.test_indent): Added macro test case.
964         (CppStyleTest.test_build_class):
965         (NoNonVirtualDestructorsTest.test_no_error):
966         (NoNonVirtualDestructorsTest.test_no_error.Foo):
967         (NoNonVirtualDestructorsTest.test_no_error.Qualified):
968         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed):
969         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo):
970         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed):
971         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo):
972         (NoNonVirtualDestructorsTest.test_no_warn_when_derived):
973         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo):
974         (NoNonVirtualDestructorsTest.test_internal_braces):
975         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
976         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor):
977         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo):
978         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo):
979         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor):
980         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo):
981         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo):
982         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor):
983         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified):
984         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error):
985         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo):
986         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
987         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo):
988         (WebKitStyleTest.test_indentation):
989         (WebKitStyleTest.test_braces): Add test for call params spanning lines.
990
991 2012-09-26  Adam Barth  <abarth@webkit.org>
992
993         Rollout messages should be clickable in bugzilla
994         https://bugs.webkit.org/show_bug.cgi?id=97711
995
996         Reviewed by Simon Fraser.
997
998         If we say Bug NNNN instead of just NNNN, bugzilla will autolink to the
999         actual bug.
1000
1001         * Scripts/webkitpy/tool/commands/download_unittest.py:
1002         * Scripts/webkitpy/tool/steps/createbug.py:
1003         (CreateBug.run):
1004
1005 2012-09-26  Marcelo Lira  <marcelo.lira@openbossa.org>
1006
1007         run-perf-tests must expand environment variables in user provided paths
1008         https://bugs.webkit.org/show_bug.cgi?id=97686
1009
1010         Reviewed by Ryosuke Niwa.
1011
1012         The run-perf-tests command line options that receive paths from the
1013         user now expand any possible environment variables, because Python's
1014         file handling methods do not handle those.
1015
1016         Examples:
1017         run-perf-tests --platform=qt --release --output-json-path=~/perf-results
1018         run-perf-tests --platform=qt --release --output-json-path=$HOME/perf-results
1019
1020         Also removed unused imports.
1021
1022         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1023         (PerfTestsRunner._parse_args._expand_path): expand environment variables in a path passed via command line
1024         (PerfTestsRunner._parse_args):
1025
1026 2012-09-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1027
1028         Unreviewed, rolling out r129654.
1029         http://trac.webkit.org/changeset/129654
1030         https://bugs.webkit.org/show_bug.cgi?id=97702
1031
1032         breaks chromium windows build (Requested by schenney on
1033         #webkit).
1034
1035         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1036         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1037         (MockWebRTCPeerConnectionHandler):
1038
1039 2012-09-26  Michael Saboff  <msaboff@apple.com>
1040
1041         Unreviewed build change.
1042
1043         Reverting inadvertent change to project file.
1044
1045         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1046
1047 2012-09-26  Harald Tveit Alvestrand  <harald@alvestrand.no>
1048
1049         Implement the GetStats interface on PeerConnection
1050         https://bugs.webkit.org/show_bug.cgi?id=95193
1051
1052         Reviewed by Adam Barth.
1053
1054         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1055         (RTCStatsRequestSucceededTask):
1056         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
1057         (MockWebRTCPeerConnectionHandler::getStats):
1058         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1059         (MockWebRTCPeerConnectionHandler):
1060
1061 2012-09-26  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1062
1063         [WK2][WTR] Policy client: dumping from decidePolicyForResponse callback
1064         https://bugs.webkit.org/show_bug.cgi?id=97034
1065
1066         Reviewed by Kenneth Rohde Christiansen.
1067
1068         Provided dumping from WTR Policy client 'decidePolicyForResponse' callback.
1069
1070         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1071         (WTR::InjectedBundlePage::decidePolicyForResponse):
1072
1073 2012-09-26  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1074
1075         [Qt][WTR] Build fix for MSVC. 
1076         https://bugs.webkit.org/show_bug.cgi?id=97667
1077
1078         Reviewed by Csaba Osztrogonác.
1079
1080         WTR misses InjectedBundle headers. Adding $$PWD to Target.pri is required for MSVC. Clean build is necessary on Windows.
1081
1082         * WebKitTestRunner/InjectedBundle/Target.pri:
1083
1084 2012-09-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1085
1086         [BlackBerry] [DRT] eventSender.keyDown() doesn't support Ctrl key modifier
1087         https://bugs.webkit.org/show_bug.cgi?id=97665
1088
1089         Reviewed by Rob Buis.
1090
1091         This patch fixes test fast/forms/input-text-option-delete.html.
1092
1093         * DumpRenderTree/blackberry/EventSender.cpp:
1094         (keyDownCallback):
1095
1096 2012-09-26  Dinu Jacob  <dinu.s.jacob@intel.com>
1097
1098         Unreviewed. Adding myself as a committer.
1099
1100         * Scripts/webkitpy/common/config/committers.py:
1101
1102 2012-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1103
1104         [GTK] Remove color codes characters from run-gtk-tests output when not writing to a TTY
1105         https://bugs.webkit.org/show_bug.cgi?id=97660
1106
1107         Reviewed by Philippe Normand.
1108
1109         Remove also the '\r' characters returned by TTY output to try to fix
1110         the double line endings of the script output in the bots.
1111
1112         * Scripts/run-gtk-tests:
1113         (TestRunner.__init__): Compile a regexp for color codes if stdout
1114         it not a TTY.
1115         (TestRunner._run_test_command.parse_line): Remove color codes and
1116         '\r' characters from the line returned by the pseudo-terminal if
1117         stdout is not a TTY.
1118         * gtk/common.py:
1119         (parse_output_lines): Fix the last chunk check to make sure we
1120         always send entire lines to the callback, otherwise color codes
1121         regexp might fail if the line is not complete.
1122
1123 2012-09-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1124
1125         [DRT][WTR] Support overriding the 'WebKitDisplayImagesKey' preference
1126         https://bugs.webkit.org/show_bug.cgi?id=96883
1127
1128         Reviewed by Kenneth Rohde Christiansen.
1129
1130         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1131         (TestRunner::overridePreference): Support the
1132         'WebKitDisplayImagesKey' preference.
1133
1134 2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
1135
1136         [GTK] Enable some of the unstable CSS features
1137         https://bugs.webkit.org/show_bug.cgi?id=97572
1138
1139         Reviewed by Martin Robinson.
1140
1141         Enable the <style scoped> support via DumpRenderTreeSupportGtk method
1142         whenever resetting defualts to consistent values.
1143
1144         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1145         (resetDefaultsToConsistentValues):
1146
1147 2012-09-26  Zan Dobersek  <zandobersek@gmail.com>
1148
1149         REGRESSION (r126189): No more mismatch-did-not-occur failures in reftests
1150         https://bugs.webkit.org/show_bug.cgi?id=97112
1151
1152         Reviewed by Dirk Pranke.
1153
1154         Don't use the reftest's image hash when gathering output of its reference.
1155         This indirectly forces the driver to return the reference's image output
1156         as well. This specifically solves the problem when the reftest and its
1157         mismatch reference are equal but the unexpected match failure is not
1158         reported due to missing image output of the reference file.
1159
1160         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1161         (SingleTestRunner._run_reftest):
1162         * Scripts/webkitpy/layout_tests/port/test.py:
1163         (TestPort.diff_image):
1164         (TestDriver.run_test):
1165
1166 2012-09-25  Ryosuke Niwa  <rniwa@webkit.org>
1167
1168         Update master.cfg to invoke run-perf-tests with --no-show-results and --reset-results
1169         https://bugs.webkit.org/show_bug.cgi?id=97613
1170
1171         Reviewed by Dirk Pranke.
1172
1173         Use options added in r129580.
1174
1175         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1176         (RunAndUploadPerfTests):
1177
1178 2012-09-25  Peter Rybin  <peter.rybin@gmail.com>
1179
1180         Web Inspector: Fix logging in pure protocol test harness
1181         https://bugs.webkit.org/show_bug.cgi?id=97579
1182
1183         Reviewed by Yury Semikhatsky.
1184
1185         JavaScript alert implementation in DumpRenderTree gets immediate flush to make sure that
1186         the message survives crash or kill by timeout.
1187
1188         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1189         (BlackBerry::WebKit::DumpRenderTree::runJavaScriptAlert):
1190         * DumpRenderTree/chromium/WebViewHost.cpp:
1191         (WebViewHost::runModalAlertDialog):
1192         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1193         (onJavaScriptAlert):
1194         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1195         (webViewScriptAlert):
1196         * DumpRenderTree/mac/UIDelegate.mm:
1197         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1198         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1199         (WebCore::WebPage::javaScriptAlert):
1200         * DumpRenderTree/win/UIDelegate.cpp:
1201         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1202
1203 2012-09-25  Dan Bernstein  <mitz@apple.com>
1204
1205         Tools part of <rdar://problem/11455228> [mac] Stop using screen fonts
1206         https://bugs.webkit.org/show_bug.cgi?id=97620
1207
1208         Reviewed by John Sullivan.
1209
1210         * DumpRenderTree/mac/DumpRenderTree.mm:
1211         (resetDefaultsToConsistentValues): Enable screen font substitution when
1212         running the tests.
1213         * WebKitTestRunner/TestController.cpp:
1214         (WTR::TestController::resetStateToConsistentValues): Ditto.
1215
1216 2012-09-25  Ryosuke Niwa  <rniwa@webkit.org>
1217
1218         Build fix. "values" doesn't necessarily contain multiple values but it needs to be always parsed as an array.
1219
1220         * Scripts/webkitpy/performance_tests/perftest.py:
1221         (PerfTest.parse_output):
1222
1223 2012-09-25  Ryosuke Niwa  <rniwa@webkit.org>
1224
1225         run-perf-tests: cleanup options and results generation code
1226         https://bugs.webkit.org/show_bug.cgi?id=97611
1227
1228         Reviewed by Dirk Pranke.
1229
1230         Previously, --test-results-server triggered old JSOn format where the outermost structure was a dictionary
1231         instead of an array, and also implicitly triggered --no-show-results, caused the old outputs not to merge,
1232         and prevented the generation of results page. Also, it was not obvious that --source-json-path is an option
1233         used only on buildbot slaves.
1234
1235         This patch will:
1236         - Remove the old format since perf-o-matic supports new format now.
1237         - Add --reset-results option so that we can explicitly clear existing outputs.
1238         - Add --slave-config-json-path option to replace --source-json-path option.
1239
1240         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1241         (PerfTestsRunner._parse_args): Added --reset-results and --slave-config-json-path options.
1242         (PerfTestsRunner._generate_and_show_results): Refactored. Also removed the code to strip "values" from
1243         results since perf-o-matic can parse and store these values now.
1244         (PerfTestsRunner._merge_outputs_if_needed): Renamed from _merge_outputs_if_needed.
1245         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1246         (test_run_with_json_output): Test a harmless behavioral change to generate resuls page even when
1247         --test-results-server is present.
1248         (test_run_with_description):
1249         (test_run_generates_json_by_default):
1250         (test_run_merges_output_by_default): Added.
1251         (test_run_respects_reset_results): Added.
1252         (test_run_with_slave_config_json):
1253         (test_run_with_bad_slave_config_json): Use --slave-config-json-path instead of --source-json-path to make
1254         sure this optioon works as well.
1255         (test_run_with_multiple_repositories):
1256         (test_run_with_upload_json):
1257
1258 2012-09-25  Simon Fraser  <simon.fraser@apple.com>
1259
1260         Fix SnowLeopard build by adding #ifdefs.
1261         
1262         Fix crashes on some tests where the CFURLRef appears to be null.
1263
1264         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1265         (WTR::testPathFromURL):
1266         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1267
1268 2012-09-25  Simon Fraser  <simon.fraser@apple.com>
1269
1270         Speculative build fix for Production builds.
1271
1272         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1273         * WebKitTestRunner/Configurations/Base.xcconfig:
1274
1275 2012-09-25  Simon Fraser  <simon.fraser@apple.com>
1276
1277         Fix the build after r129566.
1278
1279         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1280
1281 2012-09-25  Dominic Mazzoni  <dmazzoni@google.com>
1282
1283         AX: AccessibilityUIElementChromium.cpp won't build on Windows without wtf/StringExtras.h
1284         https://bugs.webkit.org/show_bug.cgi?id=97614
1285
1286         Unreviewed, fixing windows breakage.
1287
1288         Added wtf/StringExtras.h to the includes to fix the Chromium/Windows build.
1289
1290         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1291
1292 2012-09-24  Simon Fraser  <simon.fraser@apple.com>
1293
1294         <rdar://problem/12351906> Have DumpRenderTree and WebKitTestRunner crash logs show which test crashed
1295
1296         Reviewed by Mark Rowe.
1297
1298         Use a new WebKitSytemInterface function to add data to crash logs about which 
1299         test was running when the crash happened.
1300
1301         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Make sure WEBKIT_SYSTEM_INTERFACE_LIBRARY is defined.
1302         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: link with the WebKitSystemInterface library.
1303         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1304         (testPathFromURL): Given a (probably) file URL, return the part after "/LayoutTests/"
1305         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Tell Crash Reporter which test was running,
1306         if we're the main frame and the test is active.
1307         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Make sure WEBKIT_SYSTEM_INTERFACE_LIBRARY is defined.
1308         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: link the injected bundle with the WebKitSystemInterface library.
1309         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1310         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Call platformDidStartProvisionalLoadForFrame().
1311         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Stub for non-Mac platforms.
1312         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1313         Add a platformDidStartProvisionalLoadForFrame() for platform-specific work.
1314         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm: Added.
1315         (WTR::testPathFromURL): Given a (probably) file URL, return the part after "/LayoutTests/"
1316         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Tell Crash Reporter which test was running,
1317         if we're the main frame.
1318         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add InjectedBundlePageMac.mm.
1319
1320 2012-09-25  Julie Parent  <jparent@chromium.org>
1321
1322         Make test_shell_tests show up in flakiness dashboard.
1323         https://bugs.webkit.org/show_bug.cgi?id=97585
1324
1325         Reviewed by Dirk Pranke.
1326
1327         test_shell_tests run only on chromium.org, and on the same bots as
1328         the layout tests, so do not use the generic fallbacks.
1329
1330         * TestResultServer/static-dashboards/builders.js:
1331         (loadBuildersList):
1332         * TestResultServer/static-dashboards/dashboard_base.js:
1333         (currentBuilderGroupCategory):
1334
1335 2012-09-25  Lucas Forschler  <lforschler@apple.com>
1336
1337         Python tests fail on Windows bots when running with more than one child process.  Temporarily use only one child process until the problem can be fixed.
1338         https://bugs.webkit.org/show_bug.cgi?id=97465
1339         
1340         Reviewed by Tim Horton.
1341
1342         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1343         (RunPythonTests.start):
1344
1345 2012-09-25  Mike West  <mkwst@chromium.org>
1346
1347         Unreviewed. Adding myself as a committer.
1348
1349         Yay. :)
1350
1351         * Scripts/webkitpy/common/config/committers.py:
1352
1353 2012-09-25  Beth Dakin  <bdakin@apple.com>
1354
1355         https://bugs.webkit.org/show_bug.cgi?id=95397
1356         Need to merge didFirstVisuallyNonEmptyLayout and 
1357         didNewFirstVisuallyNonEmptyLayout
1358         -and corresponding-
1359         <rdar://problem/10791680>
1360
1361         Reviewed by Sam Weinig.
1362
1363         Account for the new member of the PageLoadClient.
1364         * MiniBrowser/mac/BrowserWindowController.m:
1365         (-[BrowserWindowController awakeFromNib]):
1366         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1367         (WTR::InjectedBundlePage::InjectedBundlePage):
1368         * WebKitTestRunner/TestController.cpp:
1369         (WTR::TestController::initialize):
1370
1371         The NewFirstVisuallyNonEmptyLayoutForImages has existed for a while, 
1372         but it did not have the right target membership.
1373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1374
1375         Use new didLayout API instead of old 
1376         didNewFirstVisuallyNonEmptyLayout API.
1377         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1378         (TestWebKitAPI):
1379         (TestWebKitAPI::didLayout):
1380         (TestWebKitAPI::setPageLoaderClient):
1381         (TestWebKitAPI::TEST):
1382         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1383         (TestWebKitAPI):
1384         (TestWebKitAPI::didLayout):
1385         (TestWebKitAPI::setPageLoaderClient):
1386         (TestWebKitAPI::TEST):
1387         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1388         (TestWebKitAPI):
1389         (TestWebKitAPI::didLayout):
1390         (TestWebKitAPI::setPageLoaderClient):
1391         (TestWebKitAPI::TEST):
1392         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1393         (TestWebKitAPI):
1394         (TestWebKitAPI::didLayout):
1395         (TestWebKitAPI::setPageLoaderClient):
1396         (TestWebKitAPI::TEST):
1397
1398 2012-09-25  Benjamin Poulain  <bpoulain@apple.com>
1399
1400         Add missing support for Geolocation tests on WebKit2
1401         https://bugs.webkit.org/show_bug.cgi?id=97518
1402
1403         Reviewed by Sam Weinig.
1404
1405         There are two main features added to the tooling to make the test run:
1406         -Add support for error reporting for position errors through setMockGeolocationPositionUnavailableError.
1407         -Support the 3 states permission: undefined-allowed-denied.
1408
1409         * WebKitTestRunner/GeolocationProviderMock.cpp:
1410         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1411         (WTR::GeolocationProviderMock::setPosition):
1412         (WTR::GeolocationProviderMock::setPositionUnavailableError):
1413         (WTR::GeolocationProviderMock::startUpdating):
1414         (WTR::GeolocationProviderMock::sendPositionIfNeeded):
1415         (WTR::GeolocationProviderMock::sendErrorIfNeeded):
1416         * WebKitTestRunner/GeolocationProviderMock.h:
1417         (GeolocationProviderMock):
1418         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1419         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1420         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1421         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1422         (InjectedBundle):
1423         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1424         (WTR::TestRunner::setMockGeolocationPositionUnavailableError):
1425         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1426         (TestRunner):
1427         * WebKitTestRunner/TestController.cpp:
1428         (WTR::TestController::TestController):
1429         (WTR::decidePolicyForGeolocationPermissionRequest):
1430         (WTR::TestController::resetStateToConsistentValues):
1431         (WTR::TestController::setGeolocationPermission):
1432         (WTR::TestController::setMockGeolocationPosition):
1433         (WTR::TestController::setMockGeolocationPositionUnavailableError):
1434         (WTR::TestController::handleGeolocationPermissionRequest):
1435         (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
1436         * WebKitTestRunner/TestController.h:
1437         (TestController):
1438         * WebKitTestRunner/TestInvocation.cpp:
1439         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1440
1441 2012-09-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1442
1443         Unreviewed, rolling out r129517.
1444         http://trac.webkit.org/changeset/129517
1445         https://bugs.webkit.org/show_bug.cgi?id=97582
1446
1447         Link errors in chromium (Requested by alecf on #webkit).
1448
1449         * DumpRenderTree/DumpRenderTree.gypi:
1450         * DumpRenderTree/chromium/MockConstraints.cpp: Removed.
1451         * DumpRenderTree/chromium/MockConstraints.h: Removed.
1452         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1453         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1454         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
1455         (RTCVoidRequestTask::RTCVoidRequestTask):
1456         (isSupportedConstraint):
1457         (isValidConstraint):
1458         (MockWebRTCPeerConnectionHandler::initialize):
1459         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
1460         (WebKit::WebUserMediaClientMock::requestUserMedia):
1461         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
1462         (WebKit):
1463         (WebUserMediaClientMock):
1464         * DumpRenderTree/chromium/WebViewHost.h:
1465         (WebKit):
1466         (WebViewHost):
1467
1468 2012-09-25  Dominic Mazzoni  <dmazzoni@google.com>
1469
1470         AX: Chromium doesn't pass accessibility text range and line number tests
1471         https://bugs.webkit.org/show_bug.cgi?id=97246
1472
1473         Reviewed by Chris Fleizach.
1474
1475         Provide a chromium implementation of some AccessibilityUIElement
1476         methods needed by accessibility tests.
1477
1478         Enables four existing tests to pass on Chromium:
1479         Tests: accessibility/textarea-insertion-point-line-number.html
1480                accessibility/textarea-line-for-index.html
1481                accessibility/textarea-selected-text-range.html
1482                accessibility/textbox-role-reports-selection.html
1483
1484         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1485         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
1486         (AccessibilityUIElement::selectedTextRangeGetterCallback):
1487         (AccessibilityUIElement::lineForIndexCallback):
1488         (AccessibilityUIElement::setSelectedTextRangeCallback):
1489
1490 2012-09-25  Peter Beverloo  <peter@chromium.org>
1491
1492         [Chromium] Android's build archives have grown from 38M to 102M in 11 days
1493         https://bugs.webkit.org/show_bug.cgi?id=97336
1494
1495         Reviewed by Adam Barth.
1496
1497         Each WebKit target results in four APKs in the out/{Debug,Release}/ directory,
1498         while we really only need one. Ignoring the unsigned APKs removes six from
1499         the archive will make sure that we only archive a single APK per target,
1500         bringing its size back to rougly 40 megabytes.
1501
1502         * BuildSlaveSupport/built-product-archive:
1503         (archiveBuiltProduct):
1504
1505 2012-09-25  Tommy Widenflycht  <tommyw@google.com>
1506
1507         MediaStream API: Update getUserMedia to match the latest specification
1508         https://bugs.webkit.org/show_bug.cgi?id=97540
1509
1510         Reviewed by Adam Barth.
1511
1512         Adding mock support for the enhanced getUserMedia call.
1513
1514         * DumpRenderTree/DumpRenderTree.gypi:
1515         * DumpRenderTree/chromium/MockConstraints.cpp: Copied from Source/WebCore/platform/chromium/support/WebMediaConstraints.cpp.
1516         (MockConstraints):
1517         (MockConstraints::isSupported):
1518         (MockConstraints::isValid):
1519         (MockConstraints::verify):
1520         * DumpRenderTree/chromium/MockConstraints.h: Copied from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.
1521         (WebKit):
1522         (MockConstraints):
1523         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1524         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
1525         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
1526         (RTCVoidRequestTask::RTCVoidRequestTask):
1527         (MockWebRTCPeerConnectionHandler::initialize):
1528         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
1529         (UserMediaRequestTask):
1530         (UserMediaRequestTask::UserMediaRequestTask):
1531         (WebUserMediaClientMock::requestUserMedia):
1532         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
1533         (WebUserMediaClientMock):
1534         (WebUserMediaClientMock::taskList):
1535         * DumpRenderTree/chromium/WebViewHost.h:
1536         (WebKit):
1537         (WebViewHost):
1538
1539 2012-09-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1540
1541         [EFL] Do not dump inspector output in DRT
1542         https://bugs.webkit.org/show_bug.cgi?id=97018
1543
1544         Reviewed by Kenneth Rohde Christiansen.
1545
1546         Some inspector-related layout tests expect console output from the
1547         inspector view to be suppressed. Do that by setting a property in
1548         the inspector view that makes the onConsoleMessage callback return
1549         early and not output anything.
1550
1551         Using evas_object_data_{get,set} is not very beautiful, but it is
1552         still better than properly subclassing Ewk_View and having to
1553         implement something similar to drt_view_console_message_enable_set().
1554
1555         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1556         (DumpRenderTreeChrome::createWebInspectorView):
1557         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1558         (onConsoleMessage):
1559
1560 2012-09-25  Christophe Dumez  <christophe.dumez@intel.com>
1561
1562         [WK2][WKTR] TestRunner needs support for setWillSendRequestReturnsNullOnRedirect
1563         https://bugs.webkit.org/show_bug.cgi?id=97542
1564
1565         Reviewed by Kenneth Rohde Christiansen.
1566
1567         Implement support for setWillSendRequestReturnsNullOnRedirect
1568         in WebKitTestRunner.
1569
1570         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1571         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1572         (WTR::InjectedBundlePage::willSendRequestForFrame):
1573         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1574         (WTR::TestRunner::TestRunner):
1575         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1576         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1577         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1578         (TestRunner):
1579
1580 2012-09-25  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1581
1582         [BlackBerry] [DRT] fast/forms/textarea-live-pseudo-selectors.html failed
1583         https://bugs.webkit.org/show_bug.cgi?id=97189
1584
1585         Reviewed by Rob Buis.
1586
1587         Translate ASCII key code to BlackBerry key code for BACKSPACE and DELETE key.
1588
1589         * DumpRenderTree/blackberry/EventSender.cpp:
1590         (keyDownCallback):
1591
1592 2012-09-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1593
1594         [WK2][WTR] WTR bundle client loads binary data as text
1595         https://bugs.webkit.org/show_bug.cgi?id=97532
1596
1597         Reviewed by Kenneth Rohde Christiansen.
1598
1599         WTR::InjectedBundlePage::decidePolicyForResponse now checks response MIME type
1600         and returns WKBundlePagePolicyActionPassThrough if it cannot be shown.
1601
1602         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1603         (WTR::InjectedBundlePage::decidePolicyForResponse):
1604
1605 2012-09-25  Zan Dobersek  <zandobersek@gmail.com>
1606
1607         Unreviewed, another test case adjustment after r129459. Python 2.7 doesn't
1608         seem to be a requirement yet so the assertDictEqual method is not yet available
1609         on all builders. Assert that the empty dictionary length equals 0 instead.
1610
1611         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1612         (ResultSummaryTest.test_interpret_test_failures):
1613
1614 2012-09-24  Simon Hausmann  <simon.hausmann@digia.com>
1615
1616         [Qt] Fix build with latest Qt 5
1617         https://bugs.webkit.org/show_bug.cgi?id=97479
1618
1619         Reviewed by Tor Arne Vestbø.
1620
1621         The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
1622         remove them from default_pre.prf once we're past Qt 5 beta2.
1623
1624         * qmake/mkspecs/features/default_pre.prf:
1625
1626 2012-09-25  Zan Dobersek  <zandobersek@gmail.com>
1627
1628         Unreviewed, adjusting the test cases after r129459. The JSON data
1629         for reftests now contains the 'reftest_type' key and no more 'is_reftest'
1630         or 'is_mismatch_reftest' keys.
1631
1632         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1633         (EndToEndTest.test_reftest_with_two_notrefs):
1634
1635 2012-09-24  Zan Dobersek  <zandobersek@gmail.com>
1636
1637         Unexpected reftest passes are only reported when pixel testing is enabled in results.html as well
1638         https://bugs.webkit.org/show_bug.cgi?id=97426
1639
1640         Reviewed by Ojan Vafai.
1641
1642         The 'is_reftest' member of the TestResult class has been replaced by the reftest_type
1643         member which is a set containing either '!=', '==', both or none if the test represented
1644         by the object is not a reftest.
1645
1646         When summarizing results, the test dictionary is updated to contain the 'reftest_type' key
1647         if the test is a reftest. The value of this key is a list of all the reftest types of this test.
1648
1649         The test failure interpretation method has been refactored, it now reports only
1650         missing results of various formats and image diff percent in case of image or
1651         reftest mismatch.
1652
1653         Unit tests have been modified accordingly.
1654
1655         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1656         (LayoutTestRunner._update_summary_with_result):
1657         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1658         (LayoutTestRunnerTests.test_update_summary_with_result):
1659         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1660         (interpret_test_failures):
1661         (summarize_results):
1662         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1663         (ResultSummaryTest.test_interpret_test_failures):
1664         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1665         (SingleTestRunner.run):
1666         (SingleTestRunner._run_reftest):
1667         * Scripts/webkitpy/layout_tests/models/test_results.py:
1668         (TestResult.__init__):
1669         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1670         (EndToEndTest.test_reftest_with_two_notrefs):
1671
1672 2012-09-24  Sam Weinig  <sam@webkit.org>
1673
1674         Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
1675         https://bugs.webkit.org/show_bug.cgi?id=97514
1676
1677         Reviewed by Anders Carlsson.
1678
1679         * Scripts/webkitdirs.pm:
1680         (argumentsForRunAndDebugMacWebKitApp):
1681         Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
1682         is provided to set the user default. Move adding of @ARGV to after custom additions as calling
1683         shouldUseXPCServiceForWebProcess() can change @ARGV.
1684
1685         (runMacWebKitApp):
1686         (execMacWebKitAppForDebugging):
1687         Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.
1688
1689 2012-09-24  Laszlo Gombos  <l.gombos@samsung.com>
1690
1691         [GTK][EFL] Make sure cairo is built with fontconfig support
1692         https://bugs.webkit.org/show_bug.cgi?id=97513
1693
1694         Reviewed by Martin Robinson.
1695
1696         The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support. 
1697
1698         * efl/jhbuild.modules:
1699         * gtk/jhbuild.modules:
1700
1701 2012-09-24  Benjamin Poulain  <bpoulain@apple.com>
1702
1703         Fix Geolocation error reporting in the test support
1704         https://bugs.webkit.org/show_bug.cgi?id=97386
1705
1706         Reviewed by Sam Weinig.
1707         The TestRunner was exposing internal implementation details of
1708         the Geolocation object through setMockGeolocationError().
1709
1710         In practice, only the error code PositionUnavailable is supported
1711         or even implemented.
1712
1713         Exposing setMockGeolocationError() does not make sense for WebKit2 as
1714         passing generic errors from the UIProcess is a bad idea. This is the
1715         opportunity to clean TestRunner and prepare and interface suitable for WebKit2.
1716
1717         * DumpRenderTree/TestRunner.cpp:
1718         (setMockGeolocationPositionUnavailableErrorCallback):
1719         (TestRunner::staticFunctions):
1720         * DumpRenderTree/TestRunner.h:
1721         (TestRunner):
1722         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1723         (TestRunner::setMockGeolocationPositionUnavailableError):
1724         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1725         (DRTTestRunner::DRTTestRunner):
1726         (DRTTestRunner::setMockGeolocationPositionUnavailableError):
1727         * DumpRenderTree/chromium/DRTTestRunner.h:
1728         (DRTTestRunner):
1729         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1730         (TestRunner::setMockGeolocationPositionUnavailableError):
1731         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1732         (TestRunner::setMockGeolocationPositionUnavailableError):
1733         * DumpRenderTree/mac/MockGeolocationProvider.h:
1734         * DumpRenderTree/mac/MockGeolocationProvider.mm:
1735         (-[MockGeolocationProvider dealloc]):
1736         (-[MockGeolocationProvider resetError]):
1737         (-[MockGeolocationProvider setPosition:]):
1738         (-[MockGeolocationProvider setPositionUnavailableErrorWithMessage:]):
1739         (-[MockGeolocationProvider lastPosition]):
1740         (-[MockGeolocationProvider timerFired]):
1741         * DumpRenderTree/mac/TestRunnerMac.mm:
1742         (TestRunner::setMockGeolocationPositionUnavailableError):
1743         * DumpRenderTree/qt/TestRunnerQt.cpp:
1744         (TestRunner::setMockGeolocationPositionUnavailableError):
1745         * DumpRenderTree/qt/TestRunnerQt.h:
1746         (TestRunner):
1747         * DumpRenderTree/win/TestRunnerWin.cpp:
1748         (TestRunner::setMockGeolocationPositionUnavailableError):
1749         * DumpRenderTree/wx/TestRunnerWx.cpp:
1750         (TestRunner::setMockGeolocationPositionUnavailableError):
1751
1752 2012-09-24  Nikhil Bansal  <n.bansal@samsung.com>
1753
1754         [EFL][WK2] TestRunner needs touch events support.
1755         https://bugs.webkit.org/show_bug.cgi?id=96465
1756
1757         Reviewed by Kenneth Rohde Christiansen.
1758
1759         Simulate touch events in WebkitTestRunner for touch related
1760         layout tests. This patch uses ewk_view_feed_touch_event() to
1761         generate touch events.
1762
1763         * WebKitTestRunner/EventSenderProxy.h:
1764         (EventSenderProxy):
1765         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1766         (WTR):
1767         (WTR::setEvasModifiers):
1768         (WTR::EventSenderProxy::EventSenderProxy):
1769         (WTR::EventSenderProxy::~EventSenderProxy):
1770         (WTR::EventSenderProxy::sendTouchEvent):
1771         (WTR::EventSenderProxy::addTouchPoint):
1772         (WTR::EventSenderProxy::updateTouchPoint):
1773         (WTR::EventSenderProxy::setTouchModifier):
1774         (WTR::EventSenderProxy::touchStart):
1775         (WTR::EventSenderProxy::touchMove):
1776         (WTR::EventSenderProxy::touchEnd):
1777         (WTR::EventSenderProxy::touchCancel):
1778         (WTR::EventSenderProxy::clearTouchPoints):
1779         (WTR::EventSenderProxy::releaseTouchPoint):
1780         (WTR::EventSenderProxy::cancelTouchPoint):
1781
1782 2012-09-24  Christophe Dumez  <christophe.dumez@intel.com>
1783
1784         [WK2] TestRunner does not support overridePreference with value "0"
1785         https://bugs.webkit.org/show_bug.cgi?id=97457
1786
1787         Reviewed by Alexey Proskuryakov.
1788
1789         testRunner.overridePreference() was marked as taking a boolean
1790         in argument in testRunner.idl even though the test cases are
1791         passing strings to it. The current code works if the test
1792         case wants to enable a setting and therefore passes "1" string.
1793         However, if the test wants to disable a setting and passes "0"
1794         string, the current code also evaluates this to true causing
1795         certain test cases to fail.
1796
1797         The argument to testRunner.overridePreference() is now of string
1798         type and a function has been added to convert the string passed
1799         by the test to a boolean value.
1800
1801         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1803         (WTR::toBool):
1804         (WTR):
1805         (WTR::TestRunner::overridePreference):
1806         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1807         (TestRunner):
1808
1809 2012-09-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1810
1811         Unreviewed, rolling out r129343.
1812         http://trac.webkit.org/changeset/129343
1813         https://bugs.webkit.org/show_bug.cgi?id=97479
1814
1815         It broke the build (Requested by Ossy_NIGHT on #webkit).
1816
1817         * qmake/mkspecs/features/default_pre.prf:
1818
1819 2012-09-24  Zan Dobersek  <zandobersek@gmail.com>
1820
1821         [Gtk] Unskip the Shadow DOM layout tests
1822         https://bugs.webkit.org/show_bug.cgi?id=90776
1823
1824         Reviewed by Ryosuke Niwa.
1825
1826         Enable Shadow DOM through DumpRenderTreeSupport when resetting defaults in between tests.
1827
1828         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1829         (resetDefaultsToConsistentValues):
1830
1831 2012-09-24  Zan Dobersek  <zandobersek@gmail.com>
1832
1833         REGRESSION (r129211-r129218): http/tests/loading/redirect-with-no-location-crash.html failing on GTK Linux 64-bit Release WK2 (Tests)
1834         https://bugs.webkit.org/show_bug.cgi?id=97404
1835
1836         Reviewed by Philippe Normand.
1837
1838         Print out the 'didReceiveTitle' information when dumping frame load callbacks.
1839
1840         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1841         (webViewTitleChanged):
1842
1843 2012-09-24  Simon Hausmann  <simon.hausmann@digia.com>
1844
1845         [Qt] Fix build with latest Qt 5
1846
1847         Reviewed by Tor Arne Vestbø.
1848
1849         The variables for syncqt handling are now set in api.pri, but let's add a comment here that we can
1850         remove them from default_pre.prf once we're past Qt 5 beta2.
1851
1852         * qmake/mkspecs/features/default_pre.prf:
1853
1854 2012-09-22  Dominic Mazzoni  <dmazzoni@google.com>
1855
1856         AX: Layout tests would be easier to write if AccessibilityController could find an element by id
1857         https://bugs.webkit.org/show_bug.cgi?id=97301
1858
1859         Reviewed by Chris Fleizach.
1860
1861         Adds a new accessibleElementById method to AccessibilityController, to make it
1862         easier to write cross-platform layout tests.
1863
1864         Implemented for Chromium and for Mac (DRT and WKTR).
1865
1866         * DumpRenderTree/AccessibilityController.cpp:
1867         (getAccessibleElementByIdCallback):
1868         (AccessibilityController::getJSClass):
1869         * DumpRenderTree/AccessibilityController.h:
1870         (AccessibilityController):
1871         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1872         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
1873         (AccessibilityController::AccessibilityController):
1874         (AccessibilityController::findAccessibleElementByIdRecursive):
1875         (AccessibilityController::getAccessibleElementById):
1876         (AccessibilityController::accessibleElementByIdGetterCallback):
1877         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h:
1878         (AccessibilityController):
1879         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1880         (AccessibilityController::accessibleElementById):
1881         * DumpRenderTree/mac/AccessibilityCommonMac.h: added
1882         * DumpRenderTree/mac/AccessibilityCommonMac.mm: added
1883         (+[NSString stringWithJSStringRef:]):
1884         (-[NSString createJSStringRef]):
1885         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1886         (findAccessibleObjectById):
1887         (AccessibilityController::accessibleElementById):
1888         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1889         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1890         (AccessibilityController::accessibleElementById):
1891         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1892         (WTR::AccessibilityController::accessibleElementById):
1893         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1894         (AccessibilityController):
1895         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1896         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h: added
1897         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm: added
1898         (+[NSString stringWithJSStringRef:]):
1899         (-[NSString createJSStringRef]):
1900         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1901         (WTR::findAccessibleObjectById):
1902         (WTR):
1903         (WTR::AccessibilityController::accessibleElementById):
1904         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1905         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1906
1907 2012-09-22  Zan Dobersek  <zandobersek@gmail.com>
1908
1909         Unexpected reftest passes are only reported when pixel testing is enabled
1910         https://bugs.webkit.org/show_bug.cgi?id=97242
1911
1912         Reviewed by Dirk Pranke.
1913
1914         LayoutTestRunner should know whether the finished test it's handling is
1915         a reftest. This is necessary when updating result summary for reftests
1916         when pixel testing is not enabled - in these circumstances an unexpectedly
1917         passing reftest was not reported as such due to pixel testing then being
1918         determined by searching for reftest failures in failures list, which were
1919         not found in an empty failure list of a passing test. Now the TestResult
1920         objects have a member variable indicating the test is a reftest whenever
1921         that's the case.
1922
1923         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1924         (LayoutTestRunner._update_summary_with_result):
1925         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1926         (LayoutTestRunnerTests.test_update_summary_with_result):
1927         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1928         (SingleTestRunner.run):
1929         (SingleTestRunner._run_reftest):
1930         * Scripts/webkitpy/layout_tests/models/test_results.py:
1931         (TestResult.__init__):
1932
1933 2012-09-21  Sam Weinig  <sam@webkit.org>
1934
1935         WebProcess XPC services need have their environment set without disrupting all other XPC services
1936         https://bugs.webkit.org/show_bug.cgi?id=95161
1937
1938         Reviewed by Anders Carlsson.
1939
1940         Remove setting the __XPC_* environment variables.
1941
1942         * Scripts/webkitdirs.pm:
1943         (setUpGuardMallocIfNeeded):
1944         (runMacWebKitApp):
1945         (execMacWebKitAppForDebugging):
1946
1947 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
1948
1949         Fix typo in additional-platform-directory patch just landed
1950         https://bugs.webkit.org/show_bug.cgi?id=97380
1951         
1952         Unreviewed, build fix.
1953
1954         * Scripts/webkitpy/layout_tests/port/base.py:
1955         (Port.relative_test_filename):
1956         (Port.relative_perf_test_filename):
1957
1958 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
1959
1960         nrwt: don't require additional-platform-directory to be an abspath or live under LayoutTests
1961         https://bugs.webkit.org/show_bug.cgi?id=97380
1962
1963         Reviewed by Ojan Vafai.
1964
1965         There doesn't seem to be a good reason for this restriction and
1966         it's useful to be able to point to directories outside the
1967         checkout for results (e.g., for local failures due to a 10.7.4
1968         install ;).
1969
1970         * Scripts/webkitpy/layout_tests/port/base.py:
1971         (Port.relative_test_filename):
1972         (Port.relative_perf_test_filename):
1973         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1974         (ChromiumAndroidDriver._command_from_driver_input):
1975         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1976         (_set_up_derived_options):
1977         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1978         (MainTest.test_additional_platform_directory):
1979
1980 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
1981
1982         webkitpy: drop support for old TestExpectations syntax
1983         https://bugs.webkit.org/show_bug.cgi?id=97364
1984
1985         Reviewed by Ryosuke Niwa.
1986
1987         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1988         (TestExpectationParser._collect_matching_tests):
1989         (TestExpectationParser):
1990         (TestExpectationParser._tokenize_line):
1991         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1992         (SkippedTests.test_skipped_entry_dont_exist):
1993         (ExpectationSyntaxTests.assert_tokenize_exp):
1994         (ExpectationSyntaxTests.test_bare_name):
1995         (ExpectationSyntaxTests.test_bare_name_and_bugs):
1996         (ExpectationSyntaxTests.test_comments):
1997         (ExpectationSyntaxTests.test_config_modifiers):
1998         (ExpectationSyntaxTests.test_unknown_config):
1999         (ExpectationSyntaxTests.test_unknown_expectation):
2000         (ExpectationSyntaxTests.test_skip):
2001         (ExpectationSyntaxTests.test_slow):
2002         (ExpectationSyntaxTests.test_wontfix):
2003         (ExpectationSyntaxTests.test_blank_line):
2004         (ExpectationSyntaxTests.test_warnings):
2005         (RebaseliningTest.test_no_get_rebaselining_failures):
2006
2007 2012-09-21  Simon Fraser  <simon.fraser@apple.com>
2008
2009         Improve WTR unresponsiveness output a little
2010         https://bugs.webkit.org/show_bug.cgi?id=97370
2011
2012         Reviewed by Timothy Horton.
2013
2014         Distinguish between conditions that already set the errorMessage,
2015         and unresponsiveness due to slow about:blank loads when WTR
2016         reports unresponsiveness.
2017
2018         * WebKitTestRunner/TestInvocation.cpp:
2019         (WTR::TestInvocation::invoke):
2020
2021 2012-09-21  Chris Rogers  <crogers@google.com>
2022
2023         Add Web Audio support for deprecated/legacy APIs
2024         https://bugs.webkit.org/show_bug.cgi?id=97050
2025
2026         Reviewed by Eric Carlson.
2027
2028         * Scripts/webkitperl/FeatureList.pm:
2029
2030 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
2031
2032         webkitpy: update remaining tests to use the new expectation syntax
2033         https://bugs.webkit.org/show_bug.cgi?id=97362
2034
2035         Reviewed by Ojan Vafai.
2036
2037         This patch updates all the unit tests that were still using the
2038         old TestExpectations syntax to use the new syntax *except* for
2039         the tests that were specifically testing that we parsed the old
2040         syntax correctly.
2041
2042         Also, a block of tests for the new syntax were duplicated, so
2043         I've deleted the duplicate.
2044
2045         Note that the old syntax is still supported so this change should
2046         produce no visible changes.
2047
2048         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2049         (MiscTests.test_multiple_results):
2050         (MiscTests.test_category_expectations):
2051         (MiscTests.test_error_on_different_platform):
2052         (MiscTests.test_error_on_different_build_type):
2053         (MiscTests.test_overrides):
2054         (MiscTests.test_overrides__directory):
2055         (MiscTests.test_overrides__duplicate):
2056         (MiscTests.test_more_specific_override_resets_skip):
2057         (SkippedTests.check):
2058         (SkippedTests.test_duplicate_skipped_test_fails_lint):
2059         (SkippedTests.test_skipped_file_overrides_expectations):
2060         (SkippedTests.test_skipped_dir_overrides_expectations):
2061         (SkippedTests.test_skipped_file_overrides_overrides):
2062         (SkippedTests.test_skipped_dir_overrides_overrides):
2063         (ExpectationSyntaxTests.disabled_test_missing_expectation):
2064         (ExpectationSyntaxTests.disabled_test_missing_colon):
2065         (ExpectationSyntaxTests.disabled_test_too_many_colons):
2066         (ExpectationSyntaxTests.disabled_test_too_many_equals_signs):
2067         (ExpectationSyntaxTests):
2068         (ExpectationSyntaxTests.test_unrecognized_expectation):
2069         (ExpectationSyntaxTests.test_macro):
2070         (SemanticTests.test_bug_format):
2071         (SemanticTests.test_bad_bugid):
2072         (SemanticTests.test_missing_bugid):
2073         (SemanticTests.test_slow_and_timeout):
2074         (SemanticTests.test_rebaseline):
2075         (test_missing_file):
2076         (test_ambiguous):
2077         (test_more_modifiers):
2078         (test_order_in_file):
2079         (test_macro_overrides):
2080         (OldExpectationParserTests):
2081         (OldExpectationParserTests._tokenize):
2082         (OldExpectationParserTests.test_tokenize_extra_colon):
2083         (OldExpectationParserTests.test_tokenize_missing_equal):
2084         (OldExpectationParserTests.test_tokenize_extra_equal):
2085         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2086         (MainTest.test_skip_failing_tests):
2087         (MainTest.test_additional_expectations):
2088         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2089         (TestExpectationsTestCase.test_valid_expectations):
2090         (TestExpectationsTestCase.test_invalid_expectations):
2091         (TestExpectationsTestCase.test_tab):
2092
2093 2012-09-21  Benjamin Poulain  <bpoulain@apple.com>
2094
2095         [WK2] Add basic testing support for Geolocation
2096         https://bugs.webkit.org/show_bug.cgi?id=97278
2097
2098         Reviewed by Kenneth Rohde Christiansen.
2099
2100         Update the Geolocation testing to use the proper API in the UIProcess.
2101
2102         * WebKitTestRunner/CMakeLists.txt:
2103         * WebKitTestRunner/GNUmakefile.am:
2104
2105         * WebKitTestRunner/GeolocationProviderMock.cpp: Added.
2106         (WTR::startUpdatingCallback):
2107         (WTR::stopUpdatingCallback):
2108         (WTR::GeolocationProviderMock::GeolocationProvierMock):
2109         (WTR::GeolocationProviderMock::setMockGeolocationPosition):
2110         (WTR::GeolocationProviderMock::startUpdating):
2111         (WTR::GeolocationProviderMock::stopUpdating):
2112         (GeolocationProviderMock):
2113         The GeolocationProvider store the location update and deliver them as needed.
2114
2115         WebCore GeolocationController do not support asynchronous update on start/stop. This is not
2116         a problem in this case because all the messages between the WebProcess and the UIProcess are
2117         asynchronous. Because of this, unlike GeolocationClientMock, we do not use a timer for event
2118         delivery.
2119
2120         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2121         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2122         (WTR::InjectedBundle::setGeolocationPermission):
2123         (WTR::InjectedBundle::setMockGeolocationPosition):
2124         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2125         (InjectedBundle):
2126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2127         (WTR::TestRunner::setGeolocationPermission):
2128         (WTR::TestRunner::setMockGeolocationPosition):
2129         From the InjectedBundle, we now pass the information to the UIProcess so that
2130         GeolocationProvider and the TestController can respond appropriately.
2131
2132         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2133         (TestRunner):
2134         * WebKitTestRunner/Target.pri:
2135         * WebKitTestRunner/TestController.cpp:
2136         (WTR::TestController::TestController):
2137         (WTR::decidePolicyForGeolocationPermissionRequest):
2138         (WTR::TestController::createOtherPage):
2139         (WTR::TestController::initialize):
2140         (WTR::TestController::setMockGeolocationPosition):
2141         * WebKitTestRunner/TestController.h:
2142         (TestController):
2143         (WTR::TestController::setGeolocationPermission):
2144         (WTR::TestController::isGeolocationPermissionAllowed):
2145         * WebKitTestRunner/TestInvocation.cpp:
2146         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2147         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2148         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2149
2150 2012-09-21  Joanmarie Diggs  <jdiggs@igalia.com>
2151
2152         REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
2153         https://bugs.webkit.org/show_bug.cgi?id=96196
2154
2155         Reviewed by Martin Robinson.
2156
2157         The "regression" is that a new test was added but the support was missing
2158         in the Gtk port for spin buttons.
2159
2160         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2161         (AccessibilityUIElement::valueDescription): Updated the FIXME comment to
2162         indicate that this cannot be implemented until it is implemented in ATK.
2163         URL of the newly-filed ATK bug included for reference.
2164
2165 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
2166
2167         Fix test_skip_and_wontfix failure
2168         https://bugs.webkit.org/show_bug.cgi?id=97225
2169
2170         Unreviewed, build fix.
2171
2172         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2173         (SemanticTests.test_skip_and_wontfix):
2174
2175 2012-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2176
2177         [GTK] Implement ViewState methods in PageClientImpl in WebKit2
2178         https://bugs.webkit.org/show_bug.cgi?id=97202
2179
2180         Reviewed by Martin Robinson.
2181
2182         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2183         (WTR::PlatformWebView::focus): Focus the view.
2184
2185 2012-09-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2186
2187         [WTR] Memory leaks in InjectedBundleController::initialize()
2188         https://bugs.webkit.org/show_bug.cgi?id=97329
2189
2190         Reviewed by Alexey Proskuryakov.
2191
2192         Fix leaks in InjectedBundleController::initialize() by adopting
2193         strings created with WKStringCreateWithUTF8CString().
2194
2195         * TestWebKitAPI/InjectedBundleController.cpp:
2196         (TestWebKitAPI::InjectedBundleController::initialize):
2197
2198 2012-09-21  Marcelo Lira  <marcelo.lira@openbossa.org>
2199
2200         [Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
2201         https://bugs.webkit.org/show_bug.cgi?id=97235
2202
2203         Reviewed by Luiz Agostini.
2204
2205         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2206         (WTR::EventSenderProxy::keyDown):
2207
2208 2012-09-21  Gergely Kis  <gergely@homejinni.com>
2209
2210         Add MIPS build slave to build.webkit.org
2211         https://bugs.webkit.org/show_bug.cgi?id=96713
2212
2213         Reviewed by Csaba Osztrogonác.
2214
2215         Added a build slave for MIPS, and enabled a builder for 
2216         Qt Linux MIPS32R2 little-endian release build.
2217
2218         * BuildSlaveSupport/build.webkit.org-config/config.json:
2219
2220 2012-09-21  Peter Beverloo  <peter@chromium.org>
2221
2222         [Chromium] Switch back to a fixed fifo path for Android
2223         https://bugs.webkit.org/show_bug.cgi?id=97230
2224
2225         Reviewed by Tony Chang.
2226
2227         Because not all external storage cards will be formated using a file
2228         system that supports named pipes, Chromium has been changed to creating
2229         the pipes in a temporary folder on the internal storage. Adapt this in
2230         WebKit so we can continue to run layout tests.
2231
2232         This also includes an *unreviewed* fix for a breakage in the webkitpy
2233         tests I made in r129221. Two lines and related to this code, so I decided
2234         to include it in this change.
2235
2236         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2237         (ChromiumAndroidDriver.__init__):
2238         (ChromiumAndroidDriver._setup_test):
2239         (ChromiumAndroidDriver._update_version):
2240
2241 2012-09-20  Peter Beverloo  <peter@chromium.org>
2242
2243         Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
2244         https://bugs.webkit.org/show_bug.cgi?id=97227
2245
2246         Reviewed by Tony Chang.
2247
2248         We switched Chromium to using FIFOs in order to achieve better consistency,
2249         which was done by Marcus in r157541. Remove all custom WebKit code in
2250         favor of Chromium's implementation.
2251
2252         Remove more FIFO code in the test runner itself, including the code in
2253         DumpRenderTree that invoked it. We can now switch to Chromium's brand
2254         new FIFO-creating code, which is being set-up for all test targets build
2255         for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.
2256
2257         This also changes the ChromiumAndroidDriver._remove_all_pipes method to
2258         delete the files individually. "rm" would fail if one of the earlier files
2259         does not exist, and the "-f" argument doesn't seem to be reliable.
2260
2261         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2262         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2263         (platformInit):
2264         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2265         (ChromiumAndroidDriver.__init__):
2266         (ChromiumAndroidDriver._setup_test):
2267         (ChromiumAndroidDriver._get_external_storage):
2268         (ChromiumAndroidDriver._drt_cmd_line):
2269         (ChromiumAndroidDriver._remove_all_pipes):
2270         (ChromiumAndroidDriver.stop):
2271         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2272
2273 2012-09-21  Christophe Dumez  <christophe.dumez@intel.com>
2274
2275         [WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
2276         https://bugs.webkit.org/show_bug.cgi?id=97326
2277
2278         Reviewed by Kenneth Rohde Christiansen.
2279
2280         Implement scheduleAsynchronousClick() in WebKitTestRunner's
2281         EventSender by sending a "MouseDown" and a "MouseUp" message
2282         asynchronously to the WebProcess.
2283
2284         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2285         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2286         (WTR::createMouseMessageBody):
2287         (WTR):
2288         (WTR::EventSendingController::mouseDown):
2289         (WTR::EventSendingController::mouseUp):
2290         (WTR::EventSendingController::scheduleAsynchronousClick):
2291         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2292         (EventSendingController):
2293         * WebKitTestRunner/TestController.cpp:
2294         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2295
2296 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
2297
2298         [Qt] Error out early if we don't have ICU available
2299
2300         Reviewed by Tor Arne Vestbø.
2301
2302         * qmake/mkspecs/features/configure.prf:
2303
2304 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
2305
2306         [Qt] Bail out when trying to build WebKit with Qt != 5
2307
2308         Reviewed by Tor Arne Vestbø.
2309
2310         Moved check for Qt version out of default_pre into top-level WebKit.pro,
2311         because we never reach default_pre.prf due to the lack of .qmake.conf support
2312         in older versions of Qt/QMake.
2313
2314         * qmake/mkspecs/features/default_pre.prf:
2315
2316 2012-09-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2317
2318         WebKitTestRunner needs to print frame load delegate information
2319         https://bugs.webkit.org/show_bug.cgi?id=42705
2320
2321         Reviewed by Kenneth Rohde Christiansen.
2322
2323         Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.
2324
2325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2326         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2327
2328 2012-09-21  Christophe Dumez  <christophe.dumez@intel.com>
2329
2330         [EFL] EventSender should mimic CTRL+o emacs shortcut
2331         https://bugs.webkit.org/show_bug.cgi?id=97224
2332
2333         Reviewed by Kenneth Rohde Christiansen.
2334
2335         Add support for mimicking CTRL+o emacs shortcut in EFL's
2336         EventSender in DumpRenderTree and WebKitTestRunner.
2337
2338         * DumpRenderTree/efl/EventSender.cpp:
2339         (sendKeyDown):
2340         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2341         (WTR::EventSenderProxy::keyDown):
2342
2343 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
2344
2345         [Qt] Re-fix clean builds
2346
2347         Reviewed by Tor Arne Vestbø.
2348
2349         Re-introduce the sanitization for LIBS when creating a module to use
2350         LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
2351         continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
2352         throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
2353         causes build issues when depending system libraries end up in LIBS before
2354         LIBS_PRIVATE.
2355
2356         * qmake/mkspecs/features/default_post.prf:
2357         * qmake/mkspecs/features/functions.prf:
2358
2359 2012-09-20  Simon Fraser  <simon.fraser@apple.com>
2360
2361         Comment out a failing webkitpy unit test until Dirk can fix it.
2362
2363         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2364         (SemanticTests.test_skip_and_wontfix):
2365
2366 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
2367
2368         make Skip, WontFix be the only expectations on a line
2369         https://bugs.webkit.org/show_bug.cgi?id=97225
2370
2371         Reviewed by Ojan Vafai.
2372
2373         It is now incorrect in the new syntax to have a line like:
2374
2375             foo.html [ WontFix Crash ]
2376
2377         This will generate a lint warning and be treated as an invalid
2378         line. Fixing this caused a whole bunch of unit tests to need updating
2379         to no longer be marked as WontFix :). Also, this patch adjusts
2380         the warnings so that missing Bug() identifiers will cause lint
2381         warnings but will *not* cause the line to be treated as invalid.
2382         Fixing these issues also revealed that test_hung_thread was no
2383         longer testing the right logic, so I adjusted the timeouts in
2384         test.py to make that test work again.
2385
2386         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2387         (Worker._run_test_in_another_thread):
2388         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2389         (ResultSummaryTest.test_summarized_results_wontfix):
2390         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2391         (TestExpectationParser._parse_modifiers):
2392         (TestExpectationParser._tokenize_line_using_new_format):
2393         (TestExpectationLine.is_invalid):
2394         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2395         (BasicTests.test_basic):
2396         (test_get_test_set):
2397         (test_parse_warning):
2398         (test_pixel_tests_flag):
2399         (SemanticTests.test_missing_bugid):
2400         (SemanticTests):
2401         (SemanticTests.test_skip_and_wontfix):
2402         * Scripts/webkitpy/layout_tests/port/test.py:
2403         (TestDriver.run_test):
2404         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2405         (MainTest.test_hung_thread):
2406         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2407         (PrintExpectationsTest.test_basic):
2408         (PrintExpectationsTest.test_multiple):
2409         (PrintExpectationsTest.test_full):
2410         (PrintExpectationsTest.test_exclude):
2411         (PrintExpectationsTest.test_csv):
2412
2413 2012-09-20  Lucas Forschler  <lforschler@apple.com>
2414
2415         Unreviewed.  Start running tests on the mac-ews.
2416         
2417         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2418         (MacEWS):
2419
2420 2012-09-20  Tony Chang  <tony@chromium.org>
2421
2422         [chromium] Enable more clang warnings
2423         https://bugs.webkit.org/show_bug.cgi?id=97257
2424
2425         Reviewed by James Robinson.
2426
2427         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
2428         there are lots of violations in these files.
2429
2430 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2431
2432         run-perf-tests should record individual value instead of statistics
2433         https://bugs.webkit.org/show_bug.cgi?id=97155
2434
2435         Reviewed by Hajime Morita.
2436
2437         Parse the list of individual value reported by tests and include them as "values".
2438         We strip "values" from the output JSON when uploading it to the perf-o-matic
2439         since it doesn't know how to parse "values" or ignore it.
2440
2441         * Scripts/webkitpy/performance_tests/perftest.py:
2442         (PerfTest):
2443         (PerfTest.parse_output): Parse and report "values".
2444         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
2445         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2446         (MainTest.test_parse_output):
2447         (MainTest.test_parse_output_with_failing_line):
2448         (TestPageLoadingPerfTest.test_run):
2449         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2450         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
2451         until we update perf-o-matic.
2452         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2453         (test_run_memory_test):
2454         (test_run_with_json_output):
2455         (test_run_with_description):
2456         (test_run_with_slave_config_json):
2457         (test_run_with_multiple_repositories):
2458
2459 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
2460
2461         [Qt] Fix production builds
2462
2463         Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
2464
2465         Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
2466
2467         * qmake/mkspecs/features/functions.prf:
2468
2469 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
2470
2471         REGRESSION: layout test results doesn't show diffs
2472         https://bugs.webkit.org/show_bug.cgi?id=97182
2473
2474         Reviewed by Ojan Vafai.
2475
2476         Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
2477         so that results.html (and hopefully garden-o-matic) can
2478         determine which things actually failed. However, we keep mapping
2479         these results to Failure so that we still only have a single
2480         expectation type for them.
2481
2482         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2483         (JSONLayoutResultsGenerator):
2484         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2485         (TestExpectationParser):
2486         (TestExpectations):
2487         (TestExpectations.result_was_expected):
2488         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2489         (determine_result_type):
2490         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2491         (MainTest.test_missing_and_unexpected_results):
2492         (MainTest.test_retrying_and_flaky_tests):
2493
2494 2012-09-20  Tommy Widenflycht  <tommyw@google.com>
2495
2496         MediaStream API: Extend UserMediaRequest with a ownerDocument method
2497         https://bugs.webkit.org/show_bug.cgi?id=97095
2498
2499         Reviewed by Adam Barth.
2500
2501         Extending WebUserMediaClientMock to check that the owning document is valid,
2502         and that the document has a frame.
2503
2504         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
2505         (WebKit::WebUserMediaClientMock::requestUserMedia):
2506
2507 2012-09-20  Stephen Chenney  <schenney@chromium.org>
2508
2509         [Chromium] DRT does not support --dump-all-pixels flag
2510         https://bugs.webkit.org/show_bug.cgi?id=95098
2511
2512         Reviewed by Dirk Pranke.
2513
2514         Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
2515         of this flag causes pixel results to be created for all tests, regardless of
2516         individual test options. If an individual test provides a pixel hash it will be used,
2517         otherwise the hash will be empty. This replaces a previously defined but unused option
2518         --dump-all-pixels, and is useful primarily when debugging DRT instances.
2519
2520         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2521         (runTest): Add a parameter and code to force pixel results for the test.
2522         (main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
2523
2524 2012-09-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2525
2526         [GTK] run-api-tests should not buffer test stdout
2527         https://bugs.webkit.org/show_bug.cgi?id=88474
2528
2529         Reviewed by Philippe Normand.
2530
2531         * Scripts/run-gtk-tests:
2532         (TestRunner._run_test_command): Use os.forkpty() instead of
2533         subprocess.Popen() so that gtest sends the output with colors to
2534         stdout. Use common.parse_output_lines() to parse the output and
2535         write it to stdout while it's read.
2536         (TestRunner._run_test_command.parse_line): Parse the line to get
2537         the test pid and write the line to stdout.
2538         (TestRunner._run_test_command.waitpid): Helper function to call
2539         waitpid handling EINTR.
2540         (TestRunner._run_test_command.return_code_from_exit_status):
2541         Helper function to convert exit status of test commands to a
2542         return code.
2543         * gtk/common.py:
2544         (parse_output_lines): Helper function that uses select to read
2545         the given file descriptor and call the given callback for every
2546         line read.
2547
2548 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
2549
2550         [Qt] Fix initial build
2551
2552         Reviewed by Tor Arne Vestbø.
2553
2554         When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
2555         $$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
2556         causing incorrect linking for Makefile.api, etc.
2557
2558         Fix the determination by simply checking if MODULE is set, which only happens in api.pri.
2559
2560         * qmake/mkspecs/features/webkit_modules.prf:
2561
2562 2012-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2563
2564         Unreviewed, rolling out r129091.
2565         http://trac.webkit.org/changeset/129091
2566         https://bugs.webkit.org/show_bug.cgi?id=97205
2567
2568         It broke perf tests everywhere (Requested by Ossy on #webkit).
2569
2570         * Scripts/webkitpy/performance_tests/perftest.py:
2571         (PerfTest):
2572         (PerfTest.parse_output):
2573         (PageLoadingPerfTest.run):
2574         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2575         (MainTest.test_parse_output):
2576         (MainTest.test_parse_output_with_failing_line):
2577         (TestPageLoadingPerfTest.test_run):
2578         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2579         (PerfTestsRunner._generate_and_show_results):
2580         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2581         (test_run_memory_test):
2582         (test_run_with_json_output):
2583         (test_run_with_description):
2584         (test_run_with_slave_config_json):
2585         (test_run_with_multiple_repositories):
2586
2587 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
2588
2589         [Qt] QtWebKit module header includes private dependencies
2590
2591         Reviewed by Tor Arne Vestbø.
2592
2593         * qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
2594         that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
2595         sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
2596         we can't do it in default_pre.
2597         * qmake/mkspecs/features/webkit_modules.prf:
2598
2599 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
2600
2601         [Qt] Fix build with MingW
2602
2603         Reviewed by Tor Arne Vestbø.
2604
2605         Don't try to compile WebCore, etc. with debug symbols for production
2606         builds, it's just too big.
2607
2608         * qmake/mkspecs/features/production_build.prf:
2609
2610 2012-09-20  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2611
2612         [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
2613         https://bugs.webkit.org/show_bug.cgi?id=97087
2614
2615         Reviewed by Gyuyoung Kim.
2616
2617         Add focusing a main frame on settings reset.
2618         After editing/undo/undo-iframe-location-change was executed a frame
2619         was left in unfocused state. This caused flakiness in two tests results.
2620
2621         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2622         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2623
2624 2012-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2625
2626         [Qt] Add eventSender.gestureTap
2627         https://bugs.webkit.org/show_bug.cgi?id=66173
2628
2629         Reviewed by Kenneth Rohde Christiansen.
2630
2631         Implement support for sending raw QGesture events.
2632
2633         * DumpRenderTree/qt/EventSenderQt.cpp:
2634         (EventSender::EventSender):
2635         (EventSender::gestureTap):
2636         * DumpRenderTree/qt/EventSenderQt.h:
2637         (EventSender):
2638
2639 2012-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2640
2641         Unreviewed, rolling out r129007.
2642         http://trac.webkit.org/changeset/129007
2643         https://bugs.webkit.org/show_bug.cgi?id=97172
2644
2645         It broke the build on the Qt bots (Requested by Ossy on
2646         #webkit).
2647
2648         * qmake/config.tests/gccdepends/empty.cpp:
2649         * qmake/config.tests/gccdepends/gccdepends.pro:
2650         * qmake/mkspecs/features/default_pre.prf:
2651
2652 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2653
2654         run-perf-tests should record indivisual value instead of statistics
2655         https://bugs.webkit.org/show_bug.cgi?id=97155
2656
2657         Reviewed by Hajime Morita.
2658
2659         Parse the list of indivisual value reported by tests and include them as "values".
2660         We strip "values" from the output JSON when uploading it to the perf-o-matic
2661         since it doesn't know how to parse "values" or ignore it.
2662
2663         * Scripts/webkitpy/performance_tests/perftest.py:
2664         (PerfTest):
2665         (PerfTest.parse_output): Parse and report "values".
2666         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
2667         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2668         (MainTest.test_parse_output):
2669         (MainTest.test_parse_output_with_failing_line):
2670         (TestPageLoadingPerfTest.test_run):
2671         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2672         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
2673         until we update perf-o-matic.
2674         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2675         (test_run_memory_test):
2676         (test_run_with_json_output):
2677         (test_run_with_description):
2678         (test_run_with_slave_config_json):
2679         (test_run_with_multiple_repositories):
2680
2681 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2682
2683         Fix regex groups for bug matching in flakiness dashboard.
2684         https://bugs.webkit.org/show_bug.cgi?id=97152
2685
2686         Unreviewed, build fix.
2687
2688         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2689         (htmlForBugs):
2690
2691 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2692
2693         nrwt: print unexpected results using new TestExpectations syntax
2694         https://bugs.webkit.org/show_bug.cgi?id=97159
2695
2696         Unreviewed, build fix.
2697
2698         Change new-run-webkit-tests to print out failures using the new
2699         syntax when there are unexpected results, e.g.:
2700
2701         52 tests ran as expected, 19 didn't:
2702
2703
2704         Regressions: Unexpected failures : (2)
2705           failures/flaky/text.html [ Failure ]
2706           failures/unexpected/text-image-checksum.html [ Failure ]
2707
2708         and so forth
2709
2710         * Scripts/webkitpy/layout_tests/views/printing.py:
2711         (Printer._print_unexpected_results):
2712
2713 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2714
2715         update flakiness dashboard after cutover to new test expectations syntax
2716         https://bugs.webkit.org/show_bug.cgi?id=97152
2717
2718         Unreviewed, build fix.
2719
2720         Handle (??) the new Bug notations as well. Hopefully we don't
2721         still need the old ones.
2722
2723         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2724         (filterBugs):
2725         (htmlForBugs):
2726         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2727
2728 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2729
2730         update flakiness dashboard after cutover to new test expectations syntax
2731         https://bugs.webkit.org/show_bug.cgi?id=97152
2732
2733         Reviewed by Ryosuke Niwa.
2734
2735         This change clones the TestExpectation parsing state machine
2736         from python into javascript.
2737
2738         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2739         (parsedExpectations.lines.forEach):
2740         (parsedExpectations):
2741         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2742
2743 2012-09-19  Dana Jansens  <danakj@chromium.org>
2744
2745         Add backer@chromium.org as contributor
2746         https://bugs.webkit.org/show_bug.cgi?id=97150
2747
2748         * Scripts/webkitpy/common/config/committers.py:
2749
2750 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2751
2752         fix MISSING after TestExpectations conversion
2753         https://bugs.webkit.org/show_bug.cgi?id=97148
2754
2755         Unreviewed, expectations change / build fix.
2756
2757         * Scripts/convert-test-expectations:
2758         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2759         (TestExpectationParser):
2760
2761 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2762
2763         nrwt: convert chromium TestExpectations to the new syntax
2764         https://bugs.webkit.org/show_bug.cgi?id=97139
2765
2766         Reviewed by Ryosuke Niwa.
2767     
2768         Add in a file temporarily that does the conversion of
2769         test expectations formats
2770
2771         * Tools/Scripts/convert-test-expectations: Added.
2772
2773 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2774
2775         REGRESSION: run-perf-tests no longer reports the total test time
2776         https://bugs.webkit.org/show_bug.cgi?id=97138
2777
2778         Reviewed by Tony Chang.
2779
2780         Report the finished time as a info-level log as opposed to a debug level log.
2781
2782         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2783         (PerfTestsRunner._run_single_test):
2784         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2785         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
2786         (test_run_test_pause_before_testing):
2787         (test_run_test_set_for_parser_tests):
2788         (test_run_memory_test):
2789         (_test_run_with_json_output):
2790
2791 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2792
2793         Support new TestExpectations format alongside old one
2794         https://bugs.webkit.org/show_bug.cgi?id=96588
2795
2796         Reviewed by Ojan Vafai.
2797
2798         This patch adds support for actually reading in lines formatted
2799         in the new style, and when we re-serialize/write out the file,
2800         all lines will be written in the new style. Note that reading in
2801         the old style is still supported, and no updates are being made
2802         to the actual TestExpectations files as part of this change.
2803
2804         This change updates most but not all of the unit tests to use
2805         the new syntax. I will update the rest when (or before where
2806         possible) I drop support for the old format.
2807
2808         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2809         (TestExpectationParser):
2810         (TestExpectationParser._tokenize_line):
2811         (TestExpectationParser._tokenize_line_using_new_format):
2812         (TestExpectationLine.to_string):
2813         (TestExpectationLine._format_line):
2814         (TestExpectations):
2815         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2816         (test_parse_warning):
2817         (SkippedTests.test_skipped_entry_dont_exist):
2818         (NewExpectationSyntaxTests.test_warnings):
2819         (RemoveConfigurationsTest.test_remove):
2820         (test_remove_line):
2821         (RebaseliningTest.test_remove):
2822         (RebaseliningTest.test_no_get_rebaselining_failures):
2823         (TestExpectationParserTests.test_tokenize_blank):
2824         (TestExpectationParserTests.test_tokenize_extra_colon):
2825         (TestExpectationParserTests.test_tokenize_missing_equal):
2826         (TestExpectationParserTests.test_tokenize_extra_equal):
2827         (TestExpectationSerializationTests.test_unparsed_to_string):
2828         (TestExpectationSerializationTests.test_unparsed_list_to_string):
2829         (TestExpectationSerializationTests.test_parsed_to_string):
2830         (TestExpectationSerializationTests.test_format_line):
2831         (TestExpectationSerializationTests.test_string_roundtrip):
2832         (TestExpectationSerializationTests.test_list_roundtrip):
2833         (TestExpectationSerializationTests.test_reconstitute_only_these):
2834         (TestExpectationSerializationTests.test_string_whitespace_stripping):
2835         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2836         (LintTest.test_lint_test_files__errors):
2837         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2838         (PrintExpectationsTest.test_basic):
2839         (PrintExpectationsTest.test_multiple):
2840         (PrintExpectationsTest.test_full):
2841         (PrintExpectationsTest.test_exclude):
2842         * Scripts/webkitpy/tool/commands/rebaseline.py:
2843         (RebaselineExpectations.execute):
2844         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2845         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2846         (test_rebaseline_updates_expectations_file):
2847         (test_rebaseline_does_not_include_overrides):
2848         (test_rebaseline_expectations_noop):
2849         (test_overrides_are_included_correctly):
2850
2851 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2852
2853         implement first part of support for the new TestExpectations syntax
2854         https://bugs.webkit.org/show_bug.cgi?id=96569
2855
2856         Reviewed by Ryosuke Niwa.
2857
2858         This patch implements support for parsing a line of the new
2859         format for the TestExpectations file and converting it back into
2860         the old format for compatibility. This routine is not yet used
2861         by anything.
2862
2863         The new format is documented at:
2864           http://trac.webkit.org/wiki/TestExpectations
2865
2866         but, in short:
2867
2868           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
2869
2870         - Comments are indicated with "#" instead of "//"
2871         - If no expectations are specified we default to Skip for
2872           compatibility with the Skipped files (these two changes make
2873           Skipped files a subset of TestExpectations files)
2874
2875         - All of the tokens are now CamelCase instead of ALLCAPS.
2876         - FAIL -> Failure
2877         - IMAGE -> ImageOnlyFailure
2878         - WONTFIX -> WontFix
2879         - modifiers refer to just the platforms and configurations
2880           (release/debug) that the line applies to.
2881         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
2882           expectations
2883         - expectations will typically be written out in lexicographic order
2884         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
2885           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
2886
2887         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2888         (TestExpectationParser):
2889         (TestExpectationParser._tokenize_line_using_new_format):
2890         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2891         (NewExpectationSyntaxTests):
2892         (NewExpectationSyntaxTests.assert_exp):
2893         (NewExpectationSyntaxTests.test_bare_name):
2894         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
2895         (NewExpectationSyntaxTests.test_comments):
2896         (NewExpectationSyntaxTests.test_config_modifiers):
2897         (NewExpectationSyntaxTests.test_unknown_config):
2898         (NewExpectationSyntaxTests.test_unknown_expectation):
2899         (NewExpectationSyntaxTests.test_skip):
2900         (NewExpectationSyntaxTests.test_slow):
2901         (NewExpectationSyntaxTests.test_wontfix):
2902         (NewExpectationSyntaxTests.test_blank_line):
2903         (NewExpectationSyntaxTests.test_warnings):
2904
2905 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2906
2907         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
2908         https://bugs.webkit.org/show_bug.cgi?id=96845
2909
2910         Reviewed by Ojan Vafai.
2911
2912         In preparation for the new TestExpectations syntax, we replace
2913         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
2914         make switching to the new syntax lossless (i.e., we lose
2915         information now, not then).
2916
2917         Note that we can still parse in results.json files that have the
2918         old data for backwards compatibility.
2919         
2920
2921         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2922         (JSONTestResult._failure_types_from_actual_result):
2923         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2924         (ResultsJSONParserTest):
2925         (test_basic):
2926         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2927         (ResultSummaryTest.test_summarized_results_wontfix):
2928         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2929         (JSONLayoutResultsGenerator):
2930         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2931         (TestExpectations):
2932         (TestExpectations.remove_pixel_failures):
2933         (TestExpectations.has_pixel_failures):
2934         (TestExpectations.suffixes_for_expectations):
2935         (TestExpectations.get_rebaselining_failures):
2936         (TestExpectations.remove_configuration_from_test):
2937         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2938         (assert_bad_expectations):
2939         (BasicTests):
2940         (BasicTests.test_basic):
2941         (MiscTests):
2942         (MiscTests.test_multiple_results):
2943         (MiscTests.test_result_was_expected):
2944         (MiscTests.test_remove_pixel_failures):
2945         (MiscTests.test_suffixes_for_expectations):
2946         (test_get_expectations_string):
2947         (test_parse_warning):
2948         (test_error_on_different_platform):
2949         (test_error_on_different_build_type):
2950         (test_overrides):
2951         (test_overrides__directory):
2952         (test_overrides__duplicate):
2953         (test_pixel_tests_flag):
2954         (test_more_specific_override_resets_skip):
2955         (SkippedTests.test_skipped_file_overrides_expectations):
2956         (SkippedTests.test_skipped_dir_overrides_expectations):
2957         (SkippedTests.test_skipped_file_overrides_overrides):
2958         (SkippedTests.test_skipped_dir_overrides_overrides):
2959         (ExpectationSyntaxTests.test_missing_colon):
2960         (ExpectationSyntaxTests.test_too_many_equals_signs):
2961         (SemanticTests.test_bug_format):
2962         (SemanticTests.test_bad_bugid):
2963         (SemanticTests.test_missing_bugid):
2964         (SemanticTests.test_rebaseline):
2965         (test_missing_file):
2966         (test_more_modifiers):
2967         (test_order_in_file):
2968         (test_macro_overrides):
2969         (RemoveConfigurationsTest.test_remove):
2970         (test_remove_line):
2971         (RebaseliningTest.test_remove):
2972         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
2973         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2974         (determine_result_type):
2975         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2976         (test_test_expectations):
2977         * Scripts/webkitpy/layout_tests/port/test.py:
2978         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2979         (MainTest.test_missing_and_unexpected_results):
2980         (MainTest.test_retrying_and_flaky_tests):
2981         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2982         (TestExpectationsTestCase.test_valid_expectations):
2983         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2984         (PrintExpectationsTest.test_basic):
2985         (PrintExpectationsTest.test_multiple):
2986         (PrintExpectationsTest.test_full):
2987         (PrintExpectationsTest.test_exclude):
2988         (PrintExpectationsTest.test_csv):
2989         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2990         (test_rebaseline_does_not_include_overrides):
2991         (test_overrides_are_included_correctly):
2992
2993 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
2994
2995         AX: A few control types are returning the wrong answer for isReadOnly
2996         https://bugs.webkit.org/show_bug.cgi?id=96735
2997
2998         Reviewed by Chris Fleizach.
2999
3000         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
3001
3002         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3003         (AccessibilityUIElement::AccessibilityUIElement):
3004         (AccessibilityUIElement::isReadOnlyGetterCallback):
3005         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
3006         (AccessibilityUIElement):
3007
3008 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3009
3010         [WTR] Memory leaks in TestRunner::deliverWebIntent()
3011         https://bugs.webkit.org/show_bug.cgi?id=97111
3012
3013         Reviewed by Kenneth Rohde Christiansen.
3014
3015         Fix memory leaks in deliverWebIntent() by adopting strings
3016         created with WKStringCreateWithUTF8CString().
3017
3018         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3019         (WTR::TestRunner::deliverWebIntent):
3020
3021 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
3022
3023         [Qt] Fix incremental builds with all-in-one-files and gccdepends
3024
3025         Reviewed by Tor Arne Vestbø.
3026
3027         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
3028         are not only created for header files but also for .cpp files. AllInOne.cpp files
3029         include other .cpp files, and when those are removed we need those dummy rules to
3030         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
3031
3032         * qmake/config.tests/gccdepends/empty.cpp:
3033         (main):
3034         * qmake/config.tests/gccdepends/gccdepends.pro:
3035         * qmake/mkspecs/features/default_pre.prf:
3036
3037 2012-09-19  Rick Byers  <rbyers@chromium.org>
3038
3039         Do touch adjustment on GestureTapDown
3040         https://bugs.webkit.org/show_bug.cgi?id=96677
3041
3042         Reviewed by Antonio Gomes.
3043
3044         Allow radius to be set for GestureTapDown events.
3045         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3046         (EventSender::gestureEvent):
3047
3048 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
3049
3050         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
3051         https://bugs.webkit.org/show_bug.cgi?id=97100
3052
3053         Reviewed by Gyuyoung Kim.
3054
3055         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
3056         preference, in order to match WebKitTestRunner functionality.
3057
3058         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3059         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3060         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3061         (TestRunner::overridePreference):
3062
3063 2012-09-18  Kangil Han  <kangil.han@samsung.com>
3064
3065         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
3066         https://bugs.webkit.org/show_bug.cgi?id=96181
3067
3068         Reviewed by Daniel Bates.
3069
3070         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
3071
3072         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3073         (new):
3074         (_parseLicenseBlock):
3075         (_parseLicenseBlockFromFile):
3076         (_defaultLicenseBlock):
3077         (_licenseBlock):
3078         (_generateHeaderFile):
3079         (_generateImplementationFile):
3080
3081 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
3082
3083         Title string should be changed when document.title is set to ''.
3084         https://bugs.webkit.org/show_bug.cgi?id=96793
3085
3086         Reviewed by Kenneth Rohde Christiansen.
3087
3088         Change dump format of dumpTitleChanges more understandable.
3089         Uses single quotation marks for the title string.
3090
3091         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3092         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
3093         * DumpRenderTree/chromium/WebViewHost.cpp:
3094         (WebViewHost::didReceiveTitle):
3095         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3096         (DumpRenderTreeChrome::onFrameTitleChanged):
3097         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3098         (webViewTitleChanged):
3099         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3100         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3101         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3102         (WebCore::DumpRenderTree::titleChanged):
3103         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3104         (FrameLoadDelegate::didReceiveTitle):
3105         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3106         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
3107         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3108         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3109
3110 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
3111
3112         EWS shouldn't sleep if there are new patches in its queue
3113         https://bugs.webkit.org/show_bug.cgi?id=83038
3114
3115         Reviewed by Eric Seidel.
3116
3117         EWS tries to process a security patch. Of course it can't, because the EWS isn't
3118         the member of the security group. But the problem is that after it can't process
3119         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
3120         and push the security patch to the end of the queue.
3121         Now it stays in the loop until it finds a patch or the queue gets empty.
3122
3123         * Scripts/webkitpy/tool/commands/queues.py:
3124         (AbstractPatchQueue._next_patch):
3125         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3126         (AbstractPatchQueueTest.test_next_patch):
3127
3128 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3129
3130         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
3131         https://bugs.webkit.org/show_bug.cgi?id=97014
3132
3133         Reviewed by Kenneth Rohde Christiansen.
3134
3135         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
3136         be used for literals rather than WTF::StringBuilder::append().
3137
3138         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3139         (WTR::InjectedBundle::booleanForKey):
3140
3141 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
3142
3143         Update my e-mail address.
3144
3145         * Scripts/webkitpy/common/config/committers.py:
3146
3147 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
3148
3149         Update my e-mail address.
3150
3151         Unreviewed.
3152
3153         * Scripts/webkitpy/common/config/committers.py:
3154
3155 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
3156
3157         [Qt] qt_webkit.pri should not be listed in Tools.pro
3158
3159         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
3160
3161         Since r128751 the module pri file is auto-generated
3162         but it was still listed in OTHER_FILES.
3163
3164         * Tools.pro: Remove unneeded line.
3165
3166 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
3167
3168         [Qt] Fix build with some versions of the gold linker
3169
3170         Reviewed by Tor Arne Vestbø.
3171
3172         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
3173         Instead run a compile/link test first to see if it works.
3174
3175         * qmake/config.tests/gnuld/gnuld.pro: Added.
3176         * qmake/config.tests/gnuld/main.cpp: Added.
3177         (main):
3178         * qmake/mkspecs/features/unix/default_post.prf:
3179
3180 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
3181
3182         [Qt] Remove forced use of gold.
3183
3184         Reviewed by Tor Arne Vestbø.
3185
3186         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
3187         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
3188         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
3189
3190         * qmake/mkspecs/features/unix/default_post.prf:
3191
3192 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
3193
3194         [Qt] Prospective Qt/Windows cross-compiling fix
3195
3196         Reviewed by Tor Arne Vestbø.
3197
3198         The win32 scope is not set when cross-compiling from Linux to Windows.
3199
3200         * qmake/mkspecs/features/functions.prf:
3201
3202 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
3203
3204         [EFL] Remove background view on EWebLauncher and MiniBrowser
3205         https://bugs.webkit.org/show_bug.cgi?id=96905
3206
3207         Reviewed by Gyuyoung Kim.
3208
3209         The size of webview was changed after adding url bar.
3210         And the background view is not necessary anymore, since it was used for debugging back in the day.
3211
3212         * EWebLauncher/main.c:
3213         (_ELauncher):
3214         (on_ecore_evas_resize):
3215         (browserCreate):
3216         * MiniBrowser/efl/main.c:
3217         (_MiniBrowser):
3218         (on_ecore_evas_resize):
3219         (browserCreate):
3220
3221 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
3222
3223         [GTK] run-webkit-tests unable to find TestExpectations for WK2
3224         https://bugs.webkit.org/show_bug.cgi?id=96998
3225
3226         Reviewed by Philippe Normand.
3227
3228         We should look for TestExpectations files in all the locations where
3229         we currently look for Skipped files. This will allow
3230         run-webkit-tests to look for TestExpectations files in
3231         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
3232
3233         * Scripts/webkitpy/layout_tests/port/gtk.py:
3234         (GtkPort.expectations_files):
3235
3236 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3237
3238         [Qt] Fix build without the QtQuick module
3239
3240         Reviewed by Simon Hausmann.
3241
3242         * qmake/mkspecs/features/features.prf:
3243
3244 2012-09-18  Stephanie Lewis  <slewis@apple.com>
3245
3246         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
3247
3248         Unreviewed.
3249
3250         * DumpRenderTree/mac/DumpRenderTree.mm:
3251         (poseAsClass):
3252
3253 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3254
3255         Unreviewed update of email addresses for Berlin QtWebKit office.
3256
3257         * Scripts/webkitpy/common/config/committers.py:
3258
3259 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
3260
3261         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
3262         https://bugs.webkit.org/show_bug.cgi?id=96899
3263
3264         Reviewed by Martin Robinson.
3265
3266         When overriding the 'WebKitDisplayImageKey' preference, use the
3267         'auto-load-images' property of WebKitWebSettings as the property which
3268         should be updated with the corresponding preference value.
3269
3270         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3271         (resetDefaultsToConsistentValues):
3272         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3273         (TestRunner::overridePreference):
3274
3275 2012-09-17  Pratik Solanki  <psolanki@apple.com>
3276
3277         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
3278         https://bugs.webkit.org/show_bug.cgi?id=96973
3279
3280         Reviewed by Dan Bernstein.
3281
3282         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3283         * WebKitTestRunner/Configurations/Base.xcconfig:
3284         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
3285
3286 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
3287
3288         nrwt: remove "unexpected EOF" warnings
3289         https://bugs.webkit.org/show_bug.cgi?id=96970
3290
3291         Reviewed by Ojan Vafai.
3292
3293         After debugging this a bit, it looks like there aren't any cases
3294         that I can reproduce where a read() of zero indicates something
3295         actually wrong; either it is a prelude to a crash, or a false
3296         negative. So, I'm removing these warnings and adding a comment.
3297
3298         * Scripts/webkitpy/layout_tests/port/server_process.py:
3299         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3300
3301 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
3302
3303         [chromium] ASAN bot is crashing at the end of the run
3304         https://bugs.webkit.org/show_bug.cgi?id=96967
3305
3306         Reviewed by Abhishek Arya.
3307
3308         The ASAN bot is crashing attempting to decode some output into
3309         UTF-8; there's no reason to do this, so let's not do this and
3310         see if something else is going on as well.
3311
3312         * Scripts/webkitpy/layout_tests/port/chromium.py:
3313         (ChromiumPort._get_crash_log):
3314
3315 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
3316
3317         nrwt: --results-directory isn't getting printed properly
3318         https://bugs.webkit.org/show_bug.cgi?id=96965
3319
3320         Reviewed by Ojan Vafai.
3321
3322         options.results_directory isn't actually initialized with the
3323         default values until after we call print_config(), so this
3324         changes things to print the value directly.
3325
3326         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3327         (run):
3328         * Scripts/webkitpy/layout_tests/views/printing.py:
3329         (Printer.print_config):
3330         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3331         (Testprinter.test_print_config):
3332
3333 2012-09-17  Rob Buis  <rbuis@rim.com>
3334
3335         [BlackBerry] Enable VIDEO_TRACK
3336         https://bugs.webkit.org/show_bug.cgi?id=96949
3337
3338         Reviewed by Antonio Gomes.
3339
3340         * Scripts/webkitperl/FeatureList.pm:
3341
3342 2012-09-17  Rick Byers  <rbyers@chromium.org>
3343
3344         Add handling of new GestureTapCancel in DRT
3345
3346         https://bugs.webkit.org/show_bug.cgi?id=96183
3347
3348         Reviewed by Antonio Gomes.
3349
3350         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3351         (TestWebPlugin::handleInputEvent):
3352         * DumpRenderTree/chromium/EventSender.cpp:
3353         (EventSender::gestureTapCancel):
3354
3355 2012-09-17  Philip Rogers  <pdr@google.com>
3356
3357         Teach style checker about preprocessor directive indentation rules
3358         https://bugs.webkit.org/show_bug.cgi?id=96874
3359
3360         Reviewed by Adam Barth.
3361
3362         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
3363         This is not explicit in our style guide but is generally followed in our code.
3364         Searching for violations in our codebase shows these are rarely indented:
3365             #include - indented in 6 files
3366             #ifdef - indented in 0 files
3367             #ifndef - indented in 1 file
3368             #define - indented in 11 files
3369             #if - indented in 7 files
3370
3371         * Scripts/webkitpy/style/checkers/cpp.py:
3372         (check_directive_indentation):
3373
3374             This is the simple test where we look for spaces followed by a #.
3375
3376         (check_style):
3377         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3378
3379             A few tests needed to be modified because they had unintentionally indented
3380             preprocessor directives.
3381
3382         (CppStyleTest.test_build_class.Foo):
3383         (CppStyleTest.test_build_class):
3384         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
3385         (WebKitStyleTest.test_line_breaking):
3386         (WebKitStyleTest.test_directive_indentation):
3387
3388 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3389
3390         [Qt] Auto-generate the module pri file for QtWebKit
3391
3392         Reviewed by Simon Hausmann.
3393
3394         * qmake/qt_webkit.pri: Removed.
3395
3396 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
3397
3398         nrwt: --additional-platform-dir is broken on chromium ports
3399         https://bugs.webkit.org/show_bug.cgi?id=96840
3400
3401         Reviewed by Ojan Vafai.
3402
3403         Looks like I broke this when cleaning things up as part of
3404         adding ML support. Fixing and adding a test.
3405
3406         * Scripts/webkitpy/layout_tests/port/chromium.py:
3407         (ChromiumPort.default_baseline_search_path):
3408         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3409         (ChromiumAndroidPort.default_baseline_search_path):
3410         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3411         (ChromiumLinuxPort.default_baseline_search_path):
3412         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3413         (ChromiumMacPort.__init__):
3414         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3415         (ChromiumWinPort.setup_environ_for_server):
3416         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3417         (test_check_build):
3418         (test_additional_platform_directory):
3419
3420 2012-09-13  Stephanie Lewis  <slewis@apple.com>
3421
3422         mac-future ignores previous platform TestExpectations.
3423         https://bugs.webkit.org/show_bug.cgi?id=96718.
3424
3425         Reviewed by Dirk Pranke.
3426
3427         TestExpectations match an expectation's configuraton against a list of configurations that are 
3428         valid for that port.  That list does not contain mac-future so none of the expectations can be
3429         applied.
3430
3431         * Scripts/webkitpy/layout_tests/port/apple.py:
3432         (ApplePort._generate_all_test_configurations):
3433
3434 2012-09-14  Adam Barth  <abarth@webkit.org>
3435
3436         Remove webkitPostMessage
3437         https://bugs.webkit.org/show_bug.cgi?id=96577
3438
3439         Reviewed by Ojan Vafai.
3440
3441         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
3442
3443         * Scripts/webkitperl/FeatureList.pm:
3444         * qmake/mkspecs/features/features.pri:
3445
3446 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
3447
3448         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
3449         https://bugs.webkit.org/show_bug.cgi?id=96817
3450
3451         Reviewed by Kenneth Rohde Christiansen.
3452
3453         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3454         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
3455         got overlooked when adding logging elsewhere.
3456
3457 2012-09-14  Peter Beverloo  <peter@chromium.org>
3458
3459         [Chromium] Build fix for DumpRenderTree following r128628
3460         https://bugs.webkit.org/show_bug.cgi?id=96808
3461
3462         Reviewed by Tony Chang.
3463
3464         When building DumpRenderTree from the Chromium project, a compile error
3465         shows up because including the header ForwardIOStreamsAndroid.h cannot
3466         be located. TestWebKitAPI does this correctly.
3467
3468         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3469
3470 2012-09-14  Dana Jansens  <danakj@chromium.org>
3471
3472         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
3473         https://bugs.webkit.org/show_bug.cgi?id=96805
3474
3475         Reviewed by Dirk Pranke.
3476
3477         * Scripts/webkitpy/common/config/committers.py:
3478         * Scripts/webkitpy/common/config/watchlist:
3479
3480 2012-09-14  Peter Beverloo  <peter@chromium.org>
3481
3482         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
3483         https://bugs.webkit.org/show_bug.cgi?id=96687
3484
3485         Reviewed by Tony Chang.
3486
3487         Android's DumpRenderTree currently supports these arguments, implemented
3488         as part of TestShellAndroid:
3489         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
3490
3491         They're used by the layout test runner to get the STDOUT and STDERR while
3492         a layout test run is in process, which is a safer alternative to parsing
3493         all the logcat output manually. The implementation can be seen here:
3494         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
3495
3496         This patch generalizes parsing of and applying the effects of these arguments
3497         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
3498         After this patch, this will make it possible to pull out the output-reading
3499         code from Android's layout test port and generalize it so it can be re-used
3500         in the new test-runner for the other two test suites.
3501
3502         This has no effect when compiling and running these tests as part of Chromium
3503         code, which has a much more advanced test-runner that does parse complete log
3504         output, but also directly depends on code licensed under Apache 2.
3505
3506         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3507         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3508         (platformInit):
3509         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3510
3511 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
3512
3513         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
3514         https://bugs.webkit.org/show_bug.cgi?id=96656
3515
3516         Reviewed by Adam Barth.
3517
3518         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
3519         macros in 1 line.
3520
3521         * Scripts/webkitpy/style/checkers/cpp.py:
3522         (check_style.definitions):
3523         (check_style): Add rule.
3524         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3525         (WebKitStyleTest.test_line_breaking): Add unittest.
3526
3527 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
3528
3529         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
3530         https://bugs.webkit.org/show_bug.cgi?id=57570
3531
3532         Reviewed by Kenneth Rohde Christiansen.
3533
3534         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
3535         and dump the information expected by the test cases.
3536
3537         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3538         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3539         (WTR::InjectedBundle::beginTesting): Explicitly set the default
3540         database quota.
3541         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3542         (WTR::securityOriginToStr): New convenience function to convert
3543         a security origin to the string expected in test results.
3544         (WTR):
3545         (WTR::InjectedBundlePage::InjectedBundlePage):
3546         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
3547         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
3548         refactoring to share code with didExceedDatabaseQuota.
3549         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3550         (InjectedBundlePage):
3551         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3552         (WTR::TestRunner::TestRunner):
3553         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3554         (WTR::TestRunner::dumpDatabaseCallbacks):
3555         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
3556         (TestRunner):
3557
3558 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3559
3560         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
3561
3562         Rubber-stamped by Simon Hausmann.
3563
3564         * qmake/mkspecs/features/default_post.prf:
3565
3566 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3567
3568         [Qt] Remove old cruft from the qmake build system
3569
3570         Rubber-stamped by Simon Hausmann.
3571
3572         * DumpRenderTree/qt/DumpRenderTree.pro:
3573         * qmake/mkspecs/features/default_post.prf:
3574
3575 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3576
3577         [Qt] Enable force_static_libs_as_shared for development
3578
3579         Not enabled for buildbots or production-builds (part of Qt5)
3580
3581         Reviewed by Simon Hausmann.
3582
3583         * qmake/mkspecs/features/default_post.prf:
3584
3585 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3586
3587         [Qt] Make force_static_libs_as_shared work on Mac OS
3588
3589         We had to move a few LIBS += around that were in the wrong place,
3590         and not caught when everything was just linked into the final
3591         QtWebKit library.
3592
3593         Reviewed by Simon Hausmann.
3594
3595         * qmake/mkspecs/features/default_post.prf:
3596         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
3597
3598 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
3599
3600         [Qt] Fix build of WTR on Windows
3601
3602         Reviewed by Tor Arne Vestbø.
3603
3604         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
3605         With qmake's unix makefile generator as well as with the MingW generator,
3606         the directory where the pro file lives (WTR/) is automatically added to
3607         the include search path, but not so with MSVC. Instead of relying on qmake's
3608         implicit feature here, add WTR/ explicitly to the include search path.
3609
3610         * WebKitTestRunner/Target.pri:
3611
3612 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
3613
3614         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
3615         https://bugs.webkit.org/show_bug.cgi?id=42691
3616
3617         Reviewed by Kenneth Rohde Christiansen.
3618
3619         Add implementation for testrunner.setStopProvisionalFrameLoads()
3620         in WebKitTestRunner.
3621
3622         Original patch by Alexey Proskuryakov.
3623
3624         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3625         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3626         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3627         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3628         (WTR::TestRunner::TestRunner):
3629         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3630         (TestRunner):
3631         (WTR::TestRunner::setStopProvisionalFrameLoads):
3632         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
3633
3634 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3635
3636         [Qt] Fix handling of debug/release/debug_and_release/build_all
3637
3638         We now pick up the defaults from Qt, in default_pre (CONFIG already
3639         contains the appropriate values for debug and release). We then let
3640         the command line arguments to qmake, or the project files themselves,
3641         override the configuration, and finally we sanitize the configuration
3642         in default_post.
3643
3644         Reviewed by Simon Hausmann.
3645
3646         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3647         * Scripts/webkitdirs.pm:
3648         (buildQMakeProjects):
3649         * qmake/mkspecs/features/default_post.prf:
3650         * qmake/mkspecs/features/default_pre.prf:
3651         * qmake/mkspecs/features/mac/default_pre.prf:
3652
3653 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3654
3655         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
3656         https://bugs.webkit.org/show_bug.cgi?id=42687
3657
3658         Reviewed by Kenneth Rohde Christiansen.
3659
3660         Implement testRunner.setTabKeyCyclesThroughElements for
3661         WebKitTestRunner.
3662
3663         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3664         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3665         (WTR::InjectedBundle::beginTesting):
3666         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3667         (WTR::TestRunner::setTabKeyCyclesThroughElements):
3668         (WTR):
3669         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3670         (TestRunner):
3671
3672 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3673
3674         EventSendingController::keyDown does not support non-array modifier arguments
3675         https://bugs.webkit.org/show_bug.cgi?id=96727
3676
3677         Reviewed by Kenneth Rohde Christiansen.
3678
3679         Add support for handling a string as modifier argument to
3680         EventSendingController::keyDown.
3681
3682         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3683         (WTR::parseModifierArray):
3684
3685 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3686
3687         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
3688         https://bugs.webkit.org/show_bug.cgi?id=42546
3689
3690         Reviewed by Kenneth Rohde Christiansen.
3691
3692         Exported TestRunner::setCustomPolicyDelegate() method.
3693         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
3694
3695         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3696         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3697         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3698
3699 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
3700
3701         [GTK] Clear application cache between tests in DumpRenderTree
3702         https://bugs.webkit.org/show_bug.cgi?id=96543
3703
3704         Reviewed by Philippe Normand.
3705
3706         Call the new DumpRenderTreeSupportGtk method to clear application cache
3707         after each test in DumpRenderTree.
3708
3709         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
3710         as well. It's now being set in XvfbDriver._start so that each driver is assigned
3711         a cache directory that's constructed out of the driver's name and its worker
3712         number. These directories are located in the layout tests results directory.
3713         At least on the builders this ensures a driver-specific empty cache directory
3714         with each test run.
3715
3716         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3717         (runTest):
3718         * Scripts/webkitpy/layout_tests/port/gtk.py:
3719         (GtkPort.setup_environ_for_server):
3720         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3721         (XvfbDriver._start):
3722
3723 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
3724
3725         [Qt] Fix linking on Windows
3726
3727         Reviewed by Tor Arne Vestbø.
3728
3729         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
3730         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
3731         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
3732         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
3733
3734         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
3735         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
3736         after the module. Therefore QT did never contain webkit anymore and we always passed
3737         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
3738
3739         This patch introduces a creating_module configuration that is used to
3740         scope the qt/pkgconfig sanitization.
3741
3742         * qmake/mkspecs/features/default_post.prf:
3743
3744 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
3745
3746         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
3747         https://bugs.webkit.org/show_bug.cgi?id=96740
3748
3749         Reviewed by Kenneth Rohde Christiansen.
3750
3751         Dump information expected by the test cases about the following
3752         frame load callbacks:
3753         "didDisplayInsecureContentForFrame"
3754         "didRunInsecureContentForFrame"
3755         "didDetectXSSForFrame"
3756
3757         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3758         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
3759         as expected by test results by calling pathSuitableForTestResult() instead
3760         of printing raw URL.
3761         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
3762         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
3763         (WTR::InjectedBundlePage::didDetectXSSForFrame):
3764
3765 2012-09-14  Peter Beverloo  <peter@chromium.org>
3766
3767         The runtime/unsigned category should be valid in the cpp style-checker.
3768         https://bugs.webkit.org/show_bug.cgi?id=96748
3769
3770         Reviewed by Csaba Osztrogonác.
3771
3772         This is causing the webkitpy tests to fail because it's not listed in the
3773         category array. Furthermore, change an "int" to "long" because it's
3774         throwing a double error in one of the earlier asserts.
3775
3776         * Scripts/webkitpy/style/checkers/cpp.py:
3777         (CppChecker):
3778         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3779         (WebKitStyleTest.test_names):
3780
3781 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3782
3783         Evas_Object* is a ref'ed structure, so tread it as such
3784         https://bugs.webkit.org/show_bug.cgi?id=96659
3785
3786         Reviewed by Adam Barth.
3787
3788         Replace OwnPtr<Evas_Object> with RefPtr.
3789
3790         * DumpRenderTree/efl/ImageDiff.cpp:
3791         (calculateDifference):
3792         (printImageDifferences):
3793         (readImageFromStdin):
3794         (main):
3795
3796 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3797
3798         Unreviewed, rolling out r128507.
3799         http://trac.webkit.org/changeset/128507
3800         https://bugs.webkit.org/show_bug.cgi?id=96659
3801
3802         Revert. r128507 makes too many crashes in EFL layout test bots.
3803
3804         * DumpRenderTree/efl/ImageDiff.cpp:
3805         (calculateDifference):
3806         (printImageDifferences):
3807         (readImageFromStdin):
3808         (main):
3809
3810 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
3811
3812         Make compile with both OS(WINCE) and PLATFORM(QT) support
3813         https://bugs.webkit.org/show_bug.cgi?id=95536
3814
3815         Reviewed by Simon Hausmann.
3816
3817         Fix wince support in qmake files
3818
3819         * Tools.pro:
3820         * qmake/mkspecs/features/configure.prf:
3821         * qmake/mkspecs/features/default_post.prf:
3822         * qmake/mkspecs/features/features.prf:
3823         * qmake/mkspecs/features/functions.prf:
3824
3825 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
3826
3827         [WK2] Add color picker API support for WebKit2
3828         https://bugs.webkit.org/show_bug.cgi?id=95058
3829
3830         Reviewed by Gyuyoung Kim.
3831
3832         Initialization code for color picker callbacks in UI client.
3833
3834         * MiniBrowser/mac/BrowserWindowController.m:
3835         (-[BrowserWindowController awakeFromNib]):
3836         * MiniBrowser/win/BrowserView.cpp:
3837         (BrowserView::create):
3838         * WebKitTestRunner/TestController.cpp:
3839         (WTR::TestController::createOtherPage):
3840         (WTR::TestController::initialize):
3841
3842 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
3843
3844         Upgrade yutak to reviewer
3845         https://bugs.webkit.org/show_bug.cgi?id=96721
3846
3847         Reviewed by Kent Tamura.
3848
3849         * Scripts/webkitpy/common/config/committers.py:
3850
3851 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3852
3853         Make the style checker report usage of "unsigned int"
3854         https://bugs.webkit.org/show_bug.cgi?id=96693
3855
3856         Reviewed by Dirk Pranke.
3857
3858         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
3859
3860         * Scripts/webkitpy/style/checkers/cpp.py:
3861         (check_language):
3862
3863 2012-09-13  Philip Rogers  <pdr@google.com>
3864
3865         Add gender-neutral form of webkit-patch land-cowboy
3866         https://bugs.webkit.org/show_bug.cgi?id=96709
3867
3868         Reviewed by Adam Barth.
3869
3870         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
3871
3872         * Scripts/webkitpy/tool/commands/download.py:
3873         (LandCowhand):
3874
3875 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
3876
3877         [EFL] Remove some parameters in browserCreate()
3878         https://bugs.webkit.org/show_bug.cgi?id=96499
3879
3880         Reviewed by Kenneth Rohde Christiansen.
3881
3882         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
3883         And I have moved some parameters into User_Arguments.
3884
3885         * EWebLauncher/main.c:
3886         (_User_Arguments):
3887         (_ELauncher):
3888         (on_key_down):
3889         (browserCreate):
3890         (findThemePath):
3891         (parseUserArguments):
3892         (main):
3893
3894 2012-09-13  Mark Lam  <mark.lam@apple.com>
3895
3896         Unreviewed. Adding myself to the committers list.
3897
3898         * Scripts/webkitpy/common/config/committers.py:
3899
3900 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3901
3902         run-perf-tests output cryptic error when the config file is missing.
3903         https://bugs.webkit.org/show_bug.cgi?id=96453
3904
3905         Reviewed by Tony Chang.
3906
3907         Add a special error message when a configuration file is missing.
3908
3909         Also update the help message of --source-json-path to signify the fact it specifies
3910         the configuration file on performance tests bots.
3911
3912         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3913         (PerfTestsRunner._parse_args):
3914         (PerfTestsRunner._generate_and_show_results):
3915         (PerfTestsRunner._merge_slave_config_json):
3916         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3917         (_test_run_with_json_output): Make upload to fail by default and assert the result
3918         in the function so that we can return logs instead.
3919         (_test_run_with_json_output.mock_upload_json):
3920         (test_run_with_json_output):
3921         (test_run_with_description):
3922         (test_run_respects_no_results):
3923         (test_run_with_slave_config_json):
3924         (test_run_with_bad_slave_config_json):
3925         (test_run_with_multiple_repositories):
3926
3927 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3928
3929         Evas_Object* is a ref'ed structure, so tread it as such
3930         https://bugs.webkit.org/show_bug.cgi?id=96659
3931
3932         Reviewed by Adam Barth.
3933
3934         Replace OwnPtr<Evas_Object> with RefPtr.
3935
3936         * DumpRenderTree/efl/ImageDiff.cpp:
3937         (calculateDifference):
3938         (printImageDifferences):
3939         (readImageFromStdin):
3940         (main):
3941
3942 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
3943
3944         One more unreviewed trivial fix after r128399.
3945
3946         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
3947
3948 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
3949
3950         Unreviewed trivial fix after r128399.
3951
3952         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
3953         (getLatestSVNRevision):
3954         (waitForSVNRevision):
3955
3956 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3957
3958         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
3959         https://bugs.webkit.org/show_bug.cgi?id=96366
3960
3961         Reviewed by Anders Carlsson.
3962
3963         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
3964         by calling shouldClose() on the FrameLoader.
3965
3966         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3967         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3968         (WTR::TestRunner::callShouldCloseOnWebView):
3969         (WTR):
3970         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3971         (TestRunner):
3972
3973 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3974
3975         Unreviewed, rolling out r128453.
3976         http://trac.webkit.org/changeset/128453
3977         https://bugs.webkit.org/show_bug.cgi?id=96681
3978
3979         Having tests use the same appcache directory leads to timeouts
3980         (Requested by zdobersek on #webkit).
3981
3982         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3983         (runTest):
3984         * Scripts/webkitpy/layout_tests/port/gtk.py:
3985         (GtkPort.setup_environ_for_server):
3986
3987 2012-09-13  James Robinson  <jamesr@chromium.org>
3988
3989         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
3990         https://bugs.webkit.org/show_bug.cgi?id=96678
3991
3992         Reviewed by Dirk Pranke.
3993
3994         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3995         (.):
3996
3997 2012-09-13  Rob Buis  <rbuis@rim.com>
3998
3999         Unreviewed changes to watchlist.
4000
4001         - Add myself to BlackBerry bugs
4002
4003         * Scripts/webkitpy/common/config/watchlist:
4004
4005 2012-09-13  Stephen Chenney  <schenney@chromium.org>
4006
4007         Add an SVG entry to the watchlist
4008
4009         Unreviewed config change.
4010
4011         * Scripts/webkitpy/common/config/watchlist:
4012         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
4013         - Added myself and pdr as watchers
4014
4015 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
4016
4017         [Qt] Make WebKit2 work on Windows with Qt 5
4018         https://bugs.webkit.org/show_bug.cgi?id=76776
4019
4020         Reviewed by Tor Arne Vestbø.
4021
4022         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
4023         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
4024         that for the GL TextureMapper (it's only built when that feature is set).
4025
4026         * qmake/mkspecs/features/configure.prf:
4027
4028 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4029
4030         [Qt] Ensure that QT is finalized before loading qt_module.prf
4031
4032         As qt_module.prf does dependency tracking based on the content of the
4033         QT variable. The intermediate WebKit modules modify the variable in
4034         their .pri files, so we have to ensure we've loaded all the modules
4035         before loading qt_module.
4036
4037         Reviewed by Tor Arne Vestbø.
4038         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
4039
4040         * qmake/mkspecs/features/default_post.prf:
4041         * qmake/mkspecs/features/webkit_modules.prf: Added.
4042
4043 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
4044
4045         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
4046         https://bugs.webkit.org/show_bug.cgi?id=96633
4047
4048         Reviewed by Csaba Osztrogonác.
4049
4050         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
4051         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
4052         It's the usual problem and the usual solution is to rename one of the conflicting files.
4053         This patch chooses to rename DRT instead of WTR and MBR.
4054
4055         Fixed include order at the same time to match style guide.
4056
4057         * DumpRenderTree/qt/DumpRenderTree.pro:
4058         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
4059         (messageHandler):
4060         (isOption):
4061         (takeOptionValue):
4062         (printUsage):
4063         (main):
4064
4065 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4066
4067         The Script run-launcher should support -2 in combination with --efl
4068         https://bugs.webkit.org/show_bug.cgi?id=96639
4069
4070         Reviewed by Simon Hausmann.
4071
4072         Support running the MiniBrowser then supplied -2 as argument.
4073
4074         * Scripts/run-launcher:
4075
4076 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
4077
4078         Unreviewed, add my Intel email address to the list.
4079
4080         * Scripts/webkitpy/common/config/committers.py:
4081
4082 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4083
4084         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
4085
4086         Reviewed by Ossy.
4087
4088         * qmake/mkspecs/features/default_post.prf:
4089
4090 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4091
4092         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
4093         https://bugs.webkit.org/show_bug.cgi?id=82294
4094
4095         Reviewed by Gyuyoung Kim.
4096
4097         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
4098
4099         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4100         (TestRunner::layerTreeAsText):
4101
4102 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
4103
4104         [GTK] Clear application cache between tests in DumpRenderTree
4105         https://bugs.webkit.org/show_bug.cgi?id=96543
4106
4107         Reviewed by Philippe Normand.
4108
4109         Call the new DumpRenderTreeSupportGtk method to clear application cache
4110         after each test.
4111
4112         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
4113         as well. Currently it points to a subdirectory in the layout tests results
4114         directory. At least on the builders this ensures an empty cache directory
4115         with each test run.
4116
4117         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4118         (runTest):
4119         * Scripts/webkitpy/layout_tests/port/gtk.py:
4120         (GtkPort.setup_environ_for_server):
4121
4122 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4123
4124         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
4125
4126         Unless it's actually a dependency of the public QtWebKit API.
4127
4128         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
4129         files with their _PRIVATE equivivalent, but that's likely to break when
4130         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
4131         clean up the variables in default_post.
4132
4133         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
4134         longer needed, as it was a workaround for the intermediate libraries ending
4135         up in the prl file. And, since CONFIG -= staticlib was there to support
4136         the explicitlib option, we can remove that too (as well as the exception
4137         for gprof, since it would be empty). If gprof needs tweaks to always link
4138         statically they should go in gprof.prf.
4139
4140         Reviewed by Simon Hausmann.
4141
4142         * qmake/mkspecs/features/default_post.prf:
4143         * qmake/mkspecs/features/functions.prf:
4144
4145 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
4146
4147         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
4148         https://bugs.webkit.org/show_bug.cgi?id=96632
4149
4150         Reviewed by Carlos Garcia Campos.
4151
4152         Fix this by using atk_object_get_n_accessible_children instead of
4153         calling getChildren() from childCount.
4154
4155         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
4156         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
4157         loop by using atk_object_get_n_accessible_children().
4158
4159 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
4160
4161         [Qt][Win] Enable USE(3D_GRAPHICS)
4162         https://bugs.webkit.org/show_bug.cgi?id=90879
4163
4164         Reviewed by Kenneth Rohde Christiansen.
4165
4166         Enable it on Windows as well as on QNX (bug fixed).
4167
4168         * qmake/mkspecs/features/features.prf:
4169
4170 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
4171
4172         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
4173         https://bugs.webkit.org/show_bug.cgi?id=96359
4174
4175         Reviewed by Tor Arne Vestbø.
4176
4177         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
4178         lexer. The only viable alternative I could find on Windows that provides
4179         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
4180         so let's use that one instead.
4181
4182         * Scripts/webkitdirs.pm:
4183         (checkRequiredSystemConfig):
4184         * qmake/mkspecs/features/default_pre.prf:
4185
4186 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
4187
4188         [Qt] Add configuration for production builds
4189         https://bugs.webkit.org/show_bug.cgi?id=96607
4190
4191         Reviewed by Kenneth Rohde Christiansen.
4192
4193         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
4194         and enable all-in-one-files optimizations.
4195
4196         * qmake/mkspecs/features/production_build.prf: Added.
4197
4198 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
4199
4200         [Qt] GStreamer detection does not work when cross-compiling
4201         https://bugs.webkit.org/show_bug.cgi?id=96608
4202
4203         Reviewed by Kenneth Rohde Christiansen.
4204
4205         When cross-compiling it is not safe to just use system(pkg-config),
4206         because there is a high probability that it will find packages in the
4207         host system instead of in the target one. Instead use qmake's new
4208         packagesExist() function that takes care of this delicate aspect of
4209         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
4210         PKG_CONFIG_LIBDIR accordingly.
4211
4212         * qmake/mkspecs/features/features.prf:
4213
4214 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
4215
4216         [WK2][WTR] More efficient string handling in InjectedBundlePage
4217         https://bugs.webkit.org/show_bug.cgi?id=96609
4218
4219         Reviewed by Kenneth Rohde Christiansen.
4220
4221         Update StringBuilder usage in InjectedBundlePage to follow
4222         the latest recommandations for efficient string handling:
4223         http://trac.webkit.org/wiki/EfficientStrings
4224
4225         This involves using appendLiteral() or appendNumber()
4226         instead of append() whenever possible.
4227
4228         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4229         (WTR::dumpPath):
4230         (WTR::rangeToStr):
4231         (WTR::styleDecToStr):
4232         (WTR::frameToStr):
4233         (WTR::dumpResourceURL):
4234         (WTR):
4235         (WTR::dumpFrameDescriptionSuitableForTestResult):
4236         (WTR::dumpRequestDescriptionSuitableForTestResult):
4237         (WTR::dumpResponseDescriptionSuitableForTestResult):
4238         (WTR::dumpErrorDescriptionSuitableForTestResult):
4239         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
4240         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
4241         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
4242         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
4243         (WTR::InjectedBundlePage::didCommitLoadForFrame):
4244         (WTR::InjectedBundlePage::didFinishProgress):
4245         (WTR::dumpFrameScrollPosition):
4246         (WTR::dumpFrameText):
4247         (WTR::dumpDescendantFramesText):
4248         (WTR::InjectedBundlePage::didFinishLoadForFrame):
4249         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
4250         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
4251         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
4252         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
4253         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
4254         (WTR::InjectedBundlePage::willSendRequestForFrame):
4255         (WTR::InjectedBundlePage::didReceiveResponseForResource):
4256         (WTR::InjectedBundlePage::didFinishLoadForResource):
4257         (WTR::InjectedBundlePage::didFailLoadForResource):
4258         (WTR::InjectedBundlePage::shouldCacheResponse):
4259         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
4260         (WTR::InjectedBundlePage::willAddMessageToConsole):
4261         (WTR::InjectedBundlePage::willSetStatusbarText):
4262         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
4263         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
4264         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
4265         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
4266         (WTR::InjectedBundlePage::shouldBeginEditing):
4267         (WTR::InjectedBundlePage::shouldEndEditing):
4268         (WTR::InjectedBundlePage::shouldInsertNode):
4269         (WTR::InjectedBundlePage::shouldInsertText):
4270         (WTR::InjectedBundlePage::shouldDeleteRange):
4271         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
4272         (WTR::InjectedBundlePage::shouldApplyStyle):
4273         (WTR::InjectedBundlePage::didBeginEditing):
4274         (WTR::InjectedBundlePage::didEndEditing):
4275         (WTR::InjectedBundlePage::didChange):
4276         (WTR::InjectedBundlePage::didChangeSelection):
4277         (WTR::InjectedBundlePage::supportsFullScreen):
4278         (WTR::InjectedBundlePage::enterFullScreenForElement):
4279         (WTR::InjectedBundlePage::exitFullScreenForElement):
4280         (WTR::InjectedBundlePage::beganEnterFullScreen):
4281         (WTR::InjectedBundlePage::beganExitFullScreen):
4282         (WTR::InjectedBundlePage::closeFullScreen):
4283         (WTR::dumpBackForwardListItem):
4284         (WTR::InjectedBundlePage::dumpBackForwardList):
4285
4286 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4287
4288         [Qt][WK2] Memory leaks in Qt's TestRunner
4289         https://bugs.webkit.org/show_bug.cgi?id=96603
4290
4291         Reviewed by Csaba Osztrogonác.
4292
4293         Fix memory leaks in Qt's TestRunner code by adopting WKString
4294         created with WKStringCreateWithUTF8CString().
4295
4296         * WebKitTestRunner/qt/TestControllerQt.cpp:
4297         (WTR::TestController::initializeInjectedBundlePath):
4298         (WTR::TestController::initializeTestPluginDirectory):
4299
4300 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
4301
4302         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
4303         https://bugs.webkit.org/show_bug.cgi?id=96506
4304
4305         Reviewed by Dirk Pranke.
4306
4307         Lower the timeout value to 6 seconds for release configuration and 12 seconds
4308         for debug configuration. These are the same values the Chromium port uses.
4309
4310         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
4311         the layout tests under WebKit2 generally) requires more attention and gardening
4312         than what the current effort produces.
4313
4314         The unit test is updated as well to test these changes.
4315
4316         * Scripts/webkitpy/layout_tests/port/gtk.py:
4317         (GtkPort.default_timeout_ms):
4318         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
4319         (GtkPortTest.test_default_timeout_ms):
4320         (GtkPortTest.assertLinesEqual):
4321
4322 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
4323
4324         Add SVN mirror handling feature to build.webkit.org
4325         https://bugs.webkit.org/show_bug.cgi?id=85887
4326
4327         Reviewed by Dirk Pranke.
4328
4329         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
4330         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4331         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
4332         (ConfigureBuild.start):
4333         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
4334         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
4335         (Factory.__init__):
4336         (BuildFactory.__init__):
4337         (TestFactory.__init__):
4338         (BuildAndTestFactory.__init__):
4339         (BuildAndPerfTestFactory.__init__):
4340         (BuildAndPerfTestWebKit2Factory.__init__):
4341         (DownloadAndPerfTestFactory.__init__):
4342         (DownloadAndPerfTestWebKit2Factory.__init__):
4343         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
4344         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4345         (SVNMirrorTest):
4346         (SVNMirrorTest.setUp): Load config.json once at startup.
4347         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
4348         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
4349         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
4350         (getLatestSVNRevision): Get the latest SVN revison from the given server.
4351         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
4352                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
4353
4354 2012-09-12  Kangil Han  <kangil.han@samsung.com>
4355
4356         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
4357         https://bugs.webkit.org/show_bug.cgi?id=81606
4358
4359         Reviewed by Tim Horton.
4360
4361         6 seconds is harsh for some jquery test cases.
4362         Therefore, adjust the value to match DumpRenderTree.
4363
4364         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4365         (WTR):
4366
4367 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
4368
4369         [EFL] Support download attribute feature
4370         https://bugs.webkit.org/show_bug.cgi?id=96462
4371
4372         Reviewed by Gyuyoung Kim.
4373
4374         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
4375         and add "download,request" callback to the DumpRenderTree for EFL.
4376
4377         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4378         (DumpRenderTreeChrome::createView):
4379         (DumpRenderTreeChrome::onDownloadRequest):
4380         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
4381         (DumpRenderTreeChrome):
4382         * Scripts/webkitperl/FeatureList.pm:
4383
4384 2012-09-12  Stephanie Lewis  <slewis@apple.com>
4385
4386         Reduce parallism on the wk2 testers.
4387         https://bugs.webkit.org/show_bug.cgi?id=95906
4388
4389         Reviewed by Dirk Pranke.
4390
4391         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
4392         resource contention.  Reducing the number of processes alleviates the issue.  
4393
4394         Starting by reducing 25%.
4395
4396         * Scripts/webkitpy/layout_tests/port/mac.py:
4397         (MacPort.default_child_processes):
4398
4399 2012-09-12  Brady Eidson  <beidson@apple.com>
4400
4401         Assert in NetscapePlugin::destroy() with async plugin init
4402         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
4403
4404         Reviewed by Anders Carlsson.
4405
4406         Expose NPN_Invoke to plug-in tests:
4407         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4408         (PluginTest::NPN_Invoke):
4409         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4410         (PluginTest):
4411
4412         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
4413         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
4414         (InvokeDestroysPluginWithinNPP_New):
4415         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
4416         (InvokeDestroysPluginWithinNPP_New::NPP_New):
4417         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4418
4419 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
4420
4421         refactor TestExpectations tokenization slightly in preparation for the new syntax
4422         https://bugs.webkit.org/show_bug.cgi?id=96564
4423
4424         Reviewed by Ojan Vafai.
4425
4426         This change changes how we will tokenize/lex the
4427         TestExpectations files, in preparation for supporting both the
4428         old syntax and the new one. This change by itself should be a
4429         no-op.
4430
4431         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4432         (TestExpectationParser._tokenize_line):
4433         (TestExpectationParser):
4434         (TestExpectationParser._tokenize_line_using_old_format):
4435         (TestExpectationParser._tokenize_line_using_new_format):
4436
4437 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
4438
4439         remove unused testexpectations editing code from webkitpy, garden-o-matic
4440         https://bugs.webkit.org/show_bug.cgi?id=96562
4441
4442         Reviewed by Adam Barth.
4443
4444         This code was prototyped but never fully realized. Removing
4445         until it reanimates :).
4446
4447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
4448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
4449         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
4450         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
4451         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4452         (BuildCoverageExtrapolator.extrapolate_test_configurations):
4453         (GardeningHTTPRequestHandler._run_webkit_patch):
4454         (GardeningHTTPRequestHandler.ping):
4455         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4456         (BuildCoverageExtrapolatorTest.test_extrapolate):
4457         (GardeningServerTest.test_rebaseline_new_port):
4458
4459 2012-09-12  Lucas Forschler  <lforschler@apple.com>
4460
4461         Remove unused bot, apple-xserve-1.
4462         https://bugs.webkit.org/show_bug.cgi?id=96570
4463         
4464         Reviewed by Stephanie Lewis.
4465
4466         * BuildSlaveSupport/build.webkit.org-config/config.json:
4467
4468 2012-09-12  Xan Lopez  <xlopez@igalia.com>
4469
4470         [GTK] We attempt to rebase documentation even if it's not present
4471         https://bugs.webkit.org/show_bug.cgi?id=96553
4472
4473         Reviewed by Martin Robinson.
4474
4475         Do not make the documentation rebase step fatal. This allows make
4476         install to succeed when there's no documentation generated.
4477
4478         * gtk/generate-gtkdoc:
4479
4480 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4481
4482         Respect WEBKITOUTPUTDIR when running EFL tests
4483         https://bugs.webkit.org/show_bug.cgi?id=96528
4484
4485         Reviewed by Dirk Pranke.
4486
4487         Expose user set WEBKITOUTPUTDIR to the web process.
4488
4489         * Scripts/webkitpy/layout_tests/port/driver.py:
4490         (Driver._start): Add WEBKITOUTPUTDIR to the environment
4491         of the web process and its potential jhbuild wrapper.
4492
4493 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
4494
4495         webkitdirs: fix uname version handling for cygwin
4496         https://bugs.webkit.org/show_bug.cgi?id=96436
4497
4498         Reviewed by Jon Honeycutt.
4499
4500         Newer versions of cygwin embed an additional version string
4501         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
4502         Update the code to handle that.
4503
4504         * Scripts/webkitdirs.pm:
4505         (setupAppleWinEnv):
4506
4507 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
4508
4509         Regression(r128338): Broke Windows build
4510         https://bugs.webkit.org/show_bug.cgi?id=96537
4511
4512         Unreviewed build fix.
4513
4514         Fix Apple-Win build by allocating array dynamically
4515         since its size is not constant.
4516
4517         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4518         (WTR::stringArrayToJS):
4519
4520 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
4521
4522         [chromium] Add a virtual test suite for fast/hidpi
4523         https://bugs.webkit.org/show_bug.cgi?id=90192
4524
4525         Reviewed by Dirk Pranke.
4526
4527         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
4528         on the hardware accelerated path as the software path.
4529
4530         * DumpRenderTree/chromium/WebPreferences.cpp:
4531         (WebPreferences::applyTo):
4532         * Scripts/webkitpy/layout_tests/port/chromium.py:
4533         (ChromiumPort.virtual_test_suites):
4534
4535 2012-09-12  Adam Klein  <adamk@chromium.org>
4536
4537         [chromium] Add content_browsertests to the flakiness dashboard
4538         https://bugs.webkit.org/show_bug.cgi?id=96535
4539
4540         Reviewed by Ojan Vafai.
4541
4542         * TestResultServer/static-dashboards/dashboard_base.js:
4543
4544 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
4545
4546         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
4547         https://bugs.webkit.org/show_bug.cgi?id=96496
4548
4549         Reviewed by Kenneth Rohde Christiansen.
4550
4551         Add implementation for originsWithApplicationCache to
4552         WebKitTestRunner.
4553
4554         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4555         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4556         (WTR::stringArrayToJS):
4557         (WTR):
4558         (WTR::TestRunner::originsWithApplicationCache):
4559         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4560         (TestRunner):
4561
4562 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
4563
4564         Fix Qt/Windows build with Python3
4565         https://bugs.webkit.org/show_bug.cgi?id=96473
4566
4567         Reviewed by Csaba Osztrogonác.
4568
4569         In Python 3 print is a real function, so we must use parentheses around
4570         the function parameters. This is backwards compatible with Python 2.
4571
4572         * Scripts/generate-win32-export-forwards:
4573
4574 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
4575
4576         Unreviewed trivial build fix for Qt/Windows after bug #96358.
4577
4578         As pointed out by Kevin, we should inject the "set PATH=..." statement
4579         to add the GnuWin32 directory only if that directory actually exists.
4580
4581         * qmake/mkspecs/features/default_post.prf:
4582
4583 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4584
4585         [EFL] [WK2] Memory leaks in TestControllerEfl
4586         https://bugs.webkit.org/show_bug.cgi?id=96525
4587
4588         Reviewed by Kenneth Rohde Christiansen.
4589
4590         Fix memory leaks in EFL's TestRunner code by adopting an allocation
4591         of WKString created with WKStringCreateWithUTF8CString().
4592
4593         * WebKitTestRunner/efl/TestControllerEfl.cpp:
4594         (WTR::TestController::initializeInjectedBundlePath):
4595         (WTR::TestController::initializeTestPluginDirectory):
4596
4597 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
4598
4599         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
4600         https://bugs.webkit.org/show_bug.cgi?id=96374
4601
4602         Reviewed by Kenneth Rohde Christiansen.
4603
4604         Implement support for dumpApplicationCacheDelegateCallbacks
4605         and disallowIncreaseForApplicationCacheQuota in
4606         WebKitTestRunner and properly dump the information
4607         expected by the tests.
4608
4609         If the application cache quota is reached for a given
4610         security origin, WebKitTestRunner will reset the quota
4611         to its default value, unless intructed not to via
4612         disallowIncreaseForApplicationCacheQuota().
4613
4614         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4615         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4616         (WTR::InjectedBundlePage::InjectedBundlePage):
4617         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
4618         (WTR):
4619         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4620         (InjectedBundlePage):
4621         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4622         (WTR::TestRunner::TestRunner):
4623         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
4624         (WTR):
4625         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4626         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
4627         (TestRunner):
4628         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
4629         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
4630
4631 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
4632
4633         [chromium] remove deprecated and unused sets import from chromium_android driver
4634         https://bugs.webkit.org/show_bug.cgi?id=96485
4635
4636         Reviewed by Dirk Pranke.
4637
4638         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4639
4640 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
4641
4642         Flakiness dashboard doesn't recognize new Chromium Android test builder
4643         https://bugs.webkit.org/show_bug.cgi?id=96523
4644
4645         Reviewed by Ojan Vafai.
4646
4647         Properly return 'ANDROID' as the Chromium platform for Android builders.
4648
4649         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4650         (chromiumPlatform):
4651         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4652         (test):
4653
4654 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
4655
4656         [Qt] Build on Windows requires bison/flex in PATH
4657         https://bugs.webkit.org/show_bug.cgi?id=96358
4658
4659         Reviewed by Tor Arne Vestbø.
4660
4661         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
4662         and Linux that is rarely a problem given how easily available the tools are. On Windows however
4663         a separate installation of various GNU tools is required as the operating system doesn't come with
4664         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
4665         the gnuwin32 directory of the qt5.git top-level repository.
4666
4667         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
4668
4669         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
4670         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
4671         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
4672         updated with the new tool.
4673
4674         * Scripts/webkitdirs.pm:
4675         (checkRequiredSystemConfig):
4676         * qmake/mkspecs/features/default_post.prf:
4677
4678 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4679
4680         [Qt] Update build-jsc after r128174
4681
4682         Reviewed by Ossy.
4683
4684         * Scripts/build-jsc:
4685
4686 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4687
4688         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
4689
4690         By hard-coding the names of the targets we defined we ended up just
4691         redefining the previous target when using addStrictSubdirOrderBetween
4692         more than once in a single project file.
4693
4694         We now embed the two base targets into the target names.
4695
4696         Reviewed by Simon Hausmann.
4697
4698         * qmake/mkspecs/features/functions.prf:
4699
4700 2012-09-12  Philippe Liard  <pliard@google.com>
4701
4702         Depend on {base,net} GYP targets rather than {base,net}_java.
4703         https://bugs.webkit.org/show_bug.cgi?id=95690
4704
4705         Reviewed by Adam Barth.
4706
4707         {base,net}_java became 'private' targets on the Chromium side that
4708         clients should not depend on (see
4709         https://chromiumcodereview.appspot.com/10913083/).
4710         This removes a bunch of trailing white spaces additionally in
4711         TestWebkitAPI.gyp (which includes non-trailing white space changes).
4712
4713         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4714         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4715
4716 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
4717
4718         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
4719         https://bugs.webkit.org/show_bug.cgi?id=96494
4720
4721         Reviewed by Tor Arne Vestbø.
4722
4723         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
4724         plugin process feature if we don't have NPAPI.
4725
4726         * qmake/mkspecs/features/features.prf:
4727
4728 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
4729
4730         Unreviewed, rolling out r128280.
4731         http://trac.webkit.org/changeset/128280
4732         https://bugs.webkit.org/show_bug.cgi?id=96498
4733
4734         it broke compilation on windows debug bot (Requested by loislo
4735         on #webkit).
4736
4737         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4738         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4739         (WTR::InjectedBundlePage::InjectedBundlePage):
4740         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4741         (InjectedBundlePage):
4742         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4743         (WTR::TestRunner::TestRunner):
4744         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4745         (TestRunner):
4746
4747 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
4748
4749         [Qt] Make it possible to build with "make release" and "make debug" on Windows
4750         https://bugs.webkit.org/show_bug.cgi?id=96488
4751
4752         Reviewed by Tor Arne Vestbø.
4753
4754         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
4755         because there are no such targets. We want the generated sources to be independent from release
4756         or debug build configurations, so it is sufficient to provide fake debug and release targets that
4757         redirect to the same general-purpose target (first) of creating the derived sources.
4758
4759         * qmake/mkspecs/features/default_post.prf:
4760
4761 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4762
4763         [EFL] Make DumpRenderTree smarter at finding the fonts
4764         http://webkit.org/b/96281
4765
4766         Reviewed by Gyuyoung Kim.
4767
4768         Respect WEBKITOUTPUTDIR and expand the font dir from it.
4769         Use CString consistently.
4770
4771         * DumpRenderTree/efl/FontManagement.cpp:
4772         (buildPath):
4773         (getCoreFontFiles):
4774         (addFontDirectory):
4775         (addFontFiles):
4776         (getCustomBuildDir):
4777         (getPlatformFontsPath):
4778         (addFontsToEnvironment):
4779
4780 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
4781
4782         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
4783         https://bugs.webkit.org/show_bug.cgi?id=96374
4784
4785         Reviewed by Kenneth Rohde Christiansen.
4786
4787         Implement support for dumpApplicationCacheDelegateCallbacks
4788         and disallowIncreaseForApplicationCacheQuota in
4789         WebKitTestRunner and properly dump the information
4790         expected by the tests.
4791
4792         If the application cache quota is reached for a given
4793         security origin, WebKitTestRunner will reset the quota
4794         to its default value, unless intructed not to via
4795         disallowIncreaseForApplicationCacheQuota().
4796
4797         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4798         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4799         (WTR::InjectedBundlePage::InjectedBundlePage):
4800         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
4801         (WTR):
4802         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4803         (InjectedBundlePage):
4804         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4805         (WTR::TestRunner::TestRunner):
4806         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
4807         (WTR):
4808         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4809         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
4810         (TestRunner):
4811         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
4812         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
4813
4814 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4815
4816         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
4817         https://bugs.webkit.org/show_bug.cgi?id=96388
4818
4819         Reviewed by Kenneth Rohde Christiansen.
4820
4821         Exported TestRunner.workerThreadCount as readonly attribute.
4822
4823         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4824         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
4825         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
4826         (WTR):
4827         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
4828         (TestRunner):
4829
4830 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
4831
4832         [chromium] Consume a user gesture when creating a new view.
4833         https://bugs.webkit.org/show_bug.cgi?id=96373
4834
4835         Reviewed by Adam Barth.
4836
4837         * DumpRenderTree/chromium/WebViewHost.cpp:
4838         (WebViewHost::createView):
4839
4840 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4841
4842         [WK2][WTR] Some of TestRunner special options are not reset before testing
4843         https://bugs.webkit.org/show_bug.cgi?id=96384
4844
4845         Reviewed by Kenneth Rohde Christiansen.
4846
4847         Now values of the following special options are reset:
4848         void setAcceptsEditing(in boolean value);
4849         void setCloseRemainingWindowsWhenComplete(in boolean value);
4850         void setXSSAuditorEnabled(in boolean value);
4851         void setAllowFileAccessFromFileURLs(in boolean value);
4852         void setPluginsEnabled(in boolean value);
4853         void setPopupBlockingEnabled(in boolean value);
4854
4855         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4856         (WTR::InjectedBundle::beginTesting):
4857
4858 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
4859
4860         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
4861         https://bugs.webkit.org/show_bug.cgi?id=96273
4862
4863         Reviewed by Gyuyoung Kim.
4864
4865         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
4866         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
4867
4868         * WebKitTestRunner/CMakeLists.txt:
4869
4870 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
4871
4872         [chromium] rename webkit_resources
4873         https://bugs.webkit.org/show_bug.cgi?id=95874
4874
4875         Reviewed by James Robinson.
4876
4877         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4878
4879 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
4880
4881         [chromium] don't include content shell builders in the garden-o-matic view
4882         https://bugs.webkit.org/show_bug.cgi?id=96418
4883
4884         Reviewed by James Robinson.
4885
4886         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4887
4888 2012-09-11  Adam Klein  <adamk@chromium.org>
4889
4890         Garden-o-matic should ignore a wider variety of warnings in buildbot json
4891         https://bugs.webkit.org/show_bug.cgi?id=96411
4892
4893         Reviewed by Adam Barth.
4894
4895         Previously only the exact string "warning" was treated as a warning
4896         result. This patch treats any string with "warning" as a substring
4897         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
4898
4899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
4900         (.):
4901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
4902
4903 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
4904
4905         Restore original value of mock scrollbars enabled in InternalSettings
4906         https://bugs.webkit.org/show_bug.cgi?id=87680
4907
4908         Reviewed by Adam Barth.
4909
4910         Added backup support for mock scrollbars state in
4911         InternalSettings::Backup, and removed support for these
4912         from Qt's DumpRenderTree.
4913
4914         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4915         (WebCore::WebPage::resetSettings):
4916         * DumpRenderTree/qt/TestRunnerQt.cpp:
4917         (TestRunner::setFrameFlatteningEnabled):
4918         * DumpRenderTree/qt/TestRunnerQt.h:
4919         (TestRunner):
4920
4921 2012-09-11  Dan Bernstein  <mitz@apple.com>
4922
4923         Fixed a bug where kill-old-processes failed to kill clang++.
4924
4925         Rubber-stamped by Alexey Proskuryakov.
4926
4927         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
4928         where it is passed as a regular expression to killall.
4929
4930 2012-09-11  Philippe Liard  <pliard@google.com>
4931
4932         Make sure that md5sum is not setup on non-Chromium Android platforms.
4933         https://bugs.webkit.org/show_bug.cgi?id=96393
4934
4935         Reviewed by Adam Barth.
4936
4937         Previously md5sum was setup in ChromiumAndroidDriver's constructor
4938         which is also invoked on non-Chromium Android platforms. The following patch
4939         moves this logic to _startup_test() which is guaranteed to be invoked
4940         only on Android.
4941
4942         This also updates the prompt unit test in chromium_android_unittest.py.
4943
4944         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4945         (ChromiumAndroidDriver.__init__):
4946         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
4947         (ChromiumAndroidDriver._setup_test):
4948
4949 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
4950
4951         [EFL] Rewrite the EFL-related Find modules
4952         https://bugs.webkit.org/show_bug.cgi?id=95237
4953
4954         Reviewed by Kenneth Rohde Christiansen.
4955
4956         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
4957         property and include all the Enlightenment Foundation Libraries
4958         required by the target.
4959         * EWebLauncher/CMakeLists.txt: Ditto.
4960         * MiniBrowser/efl/CMakeLists.txt: Ditto.
4961         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
4962         now that they are not added implicitly.
4963         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
4964         property.
4965         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
4966         property and include all the Enlightenment Foundation Libraries
4967         required by the target.
4968
4969 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
4970
4971         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
4972         https://bugs.webkit.org/show_bug.cgi?id=96379
4973
4974         Reviewed by Kenneth Rohde Christiansen.
4975
4976         Add implementation for setApplicationCacheOriginQuota
4977         to WebKitTestRunner.
4978
4979         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4980         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4981         (WTR::TestRunner::setApplicationCacheOriginQuota):
4982         (WTR):
4983         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4984         (TestRunner):
4985
4986 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
4987
4988         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
4989         https://bugs.webkit.org/show_bug.cgi?id=91988
4990
4991         Reviewed by Kenneth Rohde Christiansen.
4992
4993         Regular key events generated by Qt for the tab key fill both
4994         keyCode and keyText, so we should do the same for our fake events.
4995
4996         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
4997         (WTR::EventSenderProxy::keyDown):
4998
4999 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
5000
5001         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
5002         https://bugs.webkit.org/show_bug.cgi?id=96269
5003
5004         Reviewed by Kenneth Rohde Christiansen.
5005
5006         Exported missing testRunner.setSpatialNavigationEnabled() method.
5007
5008         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
5009         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
5010         (WTR::InjectedBundle::beginTesting):
5011         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5012         (WTR::TestRunner::setSpatialNavigationEnabled):
5013         (WTR):
5014         * WebKitTestRunner/InjectedBundle/TestRunner.h:
5015         (TestRunner):
5016
5017 2012-09-11  Philippe Liard  <pliard@chromium.org>
5018
5019         Support LayoutTests on non-rooted devices for Chromium Android.
5020         https://bugs.webkit.org/show_bug.cgi?id=95346
5021
5022         Reviewed by Dirk Pranke.
5023
5024         We were requiring root permissions to sync resource files with the
5025         device by comparing host and device files' timestamp after we
5026         synchronized the device and host clocks.
5027         We now rely on md5sum provided by Chromium to handle data files
5028         synchronization.
5029
5030         * Scripts/webkitpy/layout_tests/port/chromium.py:
5031         (ChromiumPort._check_driver_build_up_to_date):
5032         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
5033         (ChromiumAndroidDriver.__init__):
5034         (ChromiumAndroidDriver._setup_test):
5035         (ChromiumAndroidDriver._push_executable):
5036         (ChromiumAndroidDriver._push_test_resources):
5037         (ChromiumAndroidDriver._read_prompt):
5038
5039 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
5040
5041         [Qt] Fix output paths on Windows
5042
5043         Reviewed by Tor Arne Vestbø.
5044
5045         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
5046         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
5047         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
5048         incorrect here and instead for the calculation we should use forward slashes.
5049
5050         * qmake/mkspecs/features/default_pre.prf:
5051
5052 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5053
5054         [Qt] Fix passing of defines from the build system
5055
5056         We explicitly have to pass -DENABLE_FOO=0 for every single feature
5057         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
5058         will add it's own defaults if the features are not defined.
5059
5060         At some point we might want to run a configure-test to inspect what
5061         Platform.h will do, so we can sync up the build system's view of
5062         the feature-defines with the compile-time situation.
5063
5064         Reviewed by Simon Hausmann.
5065
5066         * qmake/mkspecs/features/functions.prf:
5067
5068 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5069
5070         [Qt] Fix --qt option to build-webkit
5071
5072         Reviewed by Ossy.
5073
5074         * Scripts/webkitdirs.pm:
5075         (buildQMakeProjects):
5076
5077 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5078
5079         [Qt] Add a configure step to the Qt build system
5080
5081         This allows building the Qt port using just 'qmake WebKit.pro'. Using
5082         the build-webkit script is still supported, and will add slightly more
5083         logic to the build, such as detecting the need for clean or incremental
5084         builds.
5085
5086         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
5087         all things related to configuring the build, such as use/have/enable flags,
5088         and these are translated to defines in default_post. Project files should
5089         no longer check contains(DEFINES,...) to detect features, but use the new
5090         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
5091         options have been translated into WEBKIT_CONFIG options as well, and can
5092         be checked using build?().
5093
5094         Reviewed by Simon Hausmann.
5095
5096         * DumpRenderTree/qt/DumpRenderTree.pro:
5097         * MiniBrowser/qt/MiniBrowser.pro:
5098         * QtTestBrowser/QtTestBrowser.pro:
5099         * Scripts/build-webkit:
5100         * Scripts/webkitdirs.pm:
5101         (qtFeatureDefaults):
5102         (buildQMakeProjects):
5103         * Tools.pro:
5104         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
5105         * WebKitTestRunner/InjectedBundle/Target.pri:
5106         * WebKitTestRunner/Target.pri:
5107         * qmake/.qmake.cache: Added.
5108         * qmake/configure.pri: Removed.
5109         * qmake/configure.pro: Removed.
5110         * qmake/dump-features: Added.
5111         * qmake/mkspecs/features/configure.prf: Added.
5112         * qmake/mkspecs/features/default_post.prf:
5113         * qmake/mkspecs/features/default_pre.prf:
5114         * qmake/mkspecs/features/features.prf:
5115         * qmake/mkspecs/features/features.pri:
5116         * qmake/mkspecs/features/functions.prf:
5117         * qmake/mkspecs/features/gprof.prf:
5118         * qmake/mkspecs/features/mac/default_pre.prf:
5119         * qmake/mkspecs/features/win32/default_pre.prf:
5120
5121 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
5122
5123         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
5124         https://bugs.webkit.org/show_bug.cgi?id=96372
5125
5126         Reviewed by Kenneth Rohde Christiansen.
5127
5128         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
5129
5130         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
5131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5132         (WTR::TestRunner::clearApplicationCacheForOrigin):
5133         (WTR):
5134         * WebKitTestRunner/InjectedBundle/TestRunner.h:
5135         (TestRunner):
5136
5137 2012-09-11  Peter Beverloo  <peter@chromium.org>
5138
5139         Don't ignore .pak files when making an archive for Android
5140         https://bugs.webkit.org/show_bug.cgi?id=96375
5141
5142         Reviewed by Jochen Eisinger.
5143
5144         The .pak files do need to be pushed to the device, which is currently
5145         preventing the layout test runner from correctly pushing all files.
5146
5147         * BuildSlaveSupport/built-product-archive:
5148         (archiveBuiltProduct):
5149
5150 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
5151
5152         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
5153         https://bugs.webkit.org/show_bug.cgi?id=96256
5154
5155         Reviewed by Kenneth Rohde Christiansen.
5156
5157         Exported TestRunner::setMinimumTimerInterval() method.
5158
5159         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
5160         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
5161         (WTR::InjectedBundle::beginTesting):
5162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5163         (WTR::TestRunner::setMinimumTimerInterval):
5164         (WTR):
5165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
5166         (TestRunner):
5167
5168 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
5169
5170         MediaStream API: add RTCPeerConnection::onnegotiationneeded
5171         https://bugs.webkit.org/show_bug.cgi?id=96097
5172
5173         Reviewed by Adam Barth.
5174
5175         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
5176         (MockWebRTCPeerConnectionHandler::addStream):
5177         (MockWebRTCPeerConnectionHandler::removeStream):
5178
5179 2012-09-11  Peter Beverloo  <peter@chromium.org>
5180
5181         Recognize the "--chromium-android" argument in run-webkit-tests
5182         https://bugs.webkit.org/show_bug.cgi?id=96369
5183
5184         Reviewed by Jochen Eisinger.
5185
5186         Chromium for the Android platform cannot determine the platform based on
5187         the host itself, so we'll use the --chromium-android argument as the build
5188         master passes to run-webkit-tests. Make sure the layout test runner
5189         can pick the right port when doing so.
5190
5191         * Scripts/run-webkit-tests:
5192         * Scripts/webkitpy/layout_tests/port/factory.py:
5193         (port_options):
5194
5195 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
5196
5197         [QT] Fix build with newer qmake from Qt 5
5198
5199         Rubber-stamped by Tor Arne Vestbø.
5200
5201         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
5202         it with the use of QT_HOST_DATA/mkspecs.
5203         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
5204
5205         * Scripts/webkitdirs.pm:
5206         (builtDylibPathForName):
5207         (qtMakeCommand):
5208
5209 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5210
5211         [Qt] Remove Qt 4 syncqt, no longer needed
5212
5213         Reviewed by Simon Hausmann.
5214
5215         * qmake/syncqt-4.8: Removed.
5216
5217 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
5218
5219         [Qt][WK2] Fix the build with recent Qt5
5220         https://bugs.webkit.org/show_bug.cgi?id=96283
5221
5222         Reviewed by Simon Hausmann.
5223
5224         We should not use deprecated Qt API because doing that results
5225         in build failure since all the deprecated API was disabled
5226         in qtbase (https://codereview.qt-project.org/#change,24890).
5227
5228         * DumpRenderTree/qt/main.cpp:
5229         (main):
5230         * MiniBrowser/qt/MiniBrowserApplication.cpp:
5231         (MiniBrowserApplication::notify):
5232         * MiniBrowser/qt/raw/View.cpp:
5233         (View::exposeEvent):
5234         (main):
5235
5236 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
5237
5238         WTR needs an implementation of applicationCacheDiskUsageForOrigin
5239         https://bugs.webkit.org/show_bug.cgi?id=87188
5240
5241         Reviewed by Kenneth Rohde Christiansen.
5242
5243         Add implementation for applicationCacheDiskUsageForOrigin()
5244         in WebKitTestRunner.
5245
5246         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
5247         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5248         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
5249         (WTR):
5250         * WebKitTestRunner/InjectedBundle/TestRunner.h:
5251         (TestRunner):
5252
5253 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
5254
5255         Properly expose <legend> elements to ATs
5256         https://bugs.webkit.org/show_bug.cgi?id=84137
5257
5258         Reviewed by Chris Fleizach.
5259
5260         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
5261         the expected platform role, ATK_ROLE_LABEL. Also established the needed
5262         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
5263
5264         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
5265         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
5266
5267 2012-09-10  Jer Noble  <jer.noble@apple.com>
5268
5269         Unreviewed; rolling out r128081.
5270         http://trac.webkit.org/changeset/128081
5271         https://bugs.webkit.org/show_bug.cgi?id=96134
5272
5273         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
5274
5275         * DumpRenderTree/TestRunner.cpp:
5276         (TestRunner::TestRunner):
5277         (TestRunner::staticFunctions):
5278         * DumpRenderTree/TestRunner.h:
5279         (TestRunner):
5280         * DumpRenderTree/mac/FrameLoadDelegate.mm:
5281         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
5282         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
5283         (WTR::InjectedBundlePage::InjectedBundlePage):
5284         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
5285         (InjectedBundlePage):
5286         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5287         (WTR::TestRunner::TestRunner):
5288         * WebKitTestRunner/InjectedBundle/TestRunner.h:
5289         (TestRunner):
5290
5291 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
5292
5293         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
5294         https://bugs.webkit.org/show_bug.cgi?id=96205
5295
5296         Reviewed by Tony Chang.
5297
5298         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
5299         internally, which means that it would support only 1 TestExpectations file per port. This
5300         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
5301         and efl-wk1 -> efl).
5302
5303         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
5304         instead so that all the ports TestExpectations are recognized. The ports are also
5305         constructed twice, with "webkit_test_runner" option set to True and False so that we
5306         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
5307
5308         * Scripts/webkitpy/style/checkers/test_expectations.py:
5309         (TestExpectationsChecker._determine_port_from_expectations_path):
5310         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
5311         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
5312
5313 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
5314
5315         [WTR] Generated source files should include config.h
5316         https://bugs.webkit.org/show_bug.cgi?id=96254
5317
5318         Reviewed by Benjamin Poulain.
5319
5320         Current coding style has encouraged to include config.h at the first position,
5321         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
5322         this rule.
5323         Therefore, this patch added it.
5324
5325         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
5326         (_generateImplementationFile):
5327
5328 2012-09-10  Rick Byers  <rbyers@chromium.org>
5329
5330         Add handling of new GestureTapCancel in DRT
5331         
5332         https://bugs.webkit.org/show_bug.cgi?id=96183
5333
5334         Reviewed by Adam Barth.
5335
5336         * DumpRenderTree/chromium/TestWebPlugin.cpp:
5337         (TestWebPlugin::handleInputEvent):
5338
5339 2012-09-10  Brady Eidson  <beidson@apple.com>
5340
5341         Javascript in foreground tabs should not wait synchronously for plug-ins to load
5342         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
5343
5344         Reviewed by Geoff Garen.
5345
5346         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
5347
5348         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
5349         (PluginObject):
5350         (SlowNPPNew::PluginObject::PluginObject):
5351         (SlowNPPNew::PluginObject::~PluginObject):
5352         (SlowNPPNew::PluginObject::hasProperty):
5353         (SlowNPPNew::PluginObject::getProperty):
5354         (SlowNPPNew::NPP_GetValue):
5355         (SlowNPPNew):
5356
5357 2012-09-10  Tim Horton  <timothy_horton@apple.com>
5358
5359         WKTR often reports an unresponsive WebProcess on Mac bots
5360         https://bugs.webkit.org/show_bug.cgi?id=95906
5361
5362         Reviewed by Dan Bernstein.
5363
5364         Attempt to work around resource contention issues by increasing the NRWT
5365         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
5366
5367         * Scripts/webkitpy/layout_tests/port/base.py:
5368         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
5369         * WebKitTestRunner/TestController.cpp:
5370         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
5371
5372 2012-09-07  Jer Noble  <jer.noble@apple.com>
5373
5374         <audio> and <video> should send Do Not Track when appropriate
5375         https://bugs.webkit.org/show_bug.cgi?id=96134
5376
5377         Reviewed by Eric Carlson.
5378
5379         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
5380         WTR. Add FrameLoaderClient client methods for retrieving that value.
5381
5382         * DumpRenderTree/TestRunner.cpp:
5383         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
5384         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
5385         * DumpRenderTree/TestRunner.h:
5386         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
5387         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
5388         * DumpRenderTree/mac/FrameLoadDelegate.mm:
5389         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
5390             Pass the question on to the TestRunner.
5391         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
5392         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
5393         (WTR::InjectedBundlePage::InjectedBundlePage):
5394             Add the setShouldSendDoNotTrackHTTPHeader client function.
5395         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
5396             Pass the question on to the TestRunner.
5397         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
5398         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
5399         * WebKitTestRunner/InjectedBundle/TestRunner.h:
5400         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
5401         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
5402
5403 2012-09-10  Ojan Vafai  <ojan@chromium.org>
5404
5405         Make EFL bots work on the flakiness dashboard
5406         https://bugs.webkit.org/show_bug.cgi?id=96164
5407
5408         Reviewed by Tony Chang.
5409
5410         Also, update outdated unittests that had started failing.
5411
5412         * TestResultServer/static-dashboards/builders.js:
5413         (isWebkitTestRunner):
5414         * TestResultServer/static-dashboards/flakiness_dashboard.js:
5415         (nonChromiumPlatform):
5416         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
5417         (test):
5418
5419 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
5420
5421         [chromium] MediaStream API: Remove the Descriptor postfix
5422         https://bugs.webkit.org/show_bug.cgi?id=96268
5423
5424         Reviewed by Adam Barth.
5425
5426         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
5427         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
5428
5429         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
5430         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
5431         (MockWebRTCPeerConnectionHandler::createOffer):
5432         (MockWebRTCPeerConnectionHandler::createAnswer):
5433         (MockWebRTCPeerConnectionHandler::setLocalDescription):
5434         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
5435         (MockWebRTCPeerConnectionHandler::localDescription):
5436         (MockWebRTCPeerConnectionHandler::remoteDescription):
5437         (MockWebRTCPeerConnectionHandler::addICECandidate):
5438         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
5439         (MockWebRTCPeerConnectionHandler):
5440
5441 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
5442
5443         [Gtk] failure to build jhbuild dependencies with cups 1.6
5444         https://bugs.webkit.org/show_bug.cgi?id=95991
5445
5446         Reviewed by Gustavo Noronha Silva.
5447
5448         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
5449         building with cups >= 1.6 [GNOME #670373].
5450
5451         * gtk/jhbuild.modules:
5452
5453 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
5454
5455         [EFL][DRT] Encoding issue in printed console messages
5456         https://bugs.webkit.org/show_bug.cgi?id=96263
5457
5458         Reviewed by Kenneth Rohde Christiansen.
5459
5460         Correctly handle CONSOLE messages that contain non-ascii
5461         characters in EFL's DRT. We need to use String::fromUTF8()
5462         to construct a WTF::String from a raw string.
5463
5464         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
5465         (onConsoleMessage):
5466
5467 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
5468
5469         [WK2][WTR] User style sheet location should be reset before each test
5470         https://bugs.webkit.org/show_bug.cgi?id=96262
5471
5472         Reviewed by Kenneth Rohde Christiansen.
5473
5474         User style sheet location is reset before each test now.
5475
5476         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
5477         (WTR::InjectedBundle::beginTesting):
5478
5479 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
5480
5481         Fix build of WTR with Qt on Windows
5482         https://bugs.webkit.org/show_bug.cgi?id=96249
5483
5484         Reviewed by Kenneth Rohde Christiansen.
5485
5486         Windows loves to define min and max as macros, which beautifully
5487         clashes in many places where min and max are used as variable or method
5488         names. It can be convinced not to do this when min and max are already
5489         define as macros (expanding to themselves). We have this kind of
5490         workaround in config.h files all over WebKit and as it turns out when
5491         building WTR with Qt on Windows we do end up with such a clash. Therefore
5492         we need the same workaround.
5493
5494         * WebKitTestRunner/config.h:
5495
5496 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
5497
5498         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
5499         https://bugs.webkit.org/show_bug.cgi?id=95936
5500
5501         Reviewed by Kenneth Rohde Christiansen.
5502
5503         Enable interactive form validation setting in WebKitTestRunner as
5504         we are currently doing in DumpRenderTree. This is needed for some
5505         tests to pass.
5506
5507         * WebKitTestRunner/TestController.cpp:
5508         (WTR::TestController::resetStateToConsistentValues):
5509
5510 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
5511
5512         Clean up the code in XvfbDriver
5513         https://bugs.webkit.org/show_bug.cgi?id=96202
5514
5515         Reviewed by Philippe Normand.
5516
5517         Changes:
5518         - Remove unneeded imports,
5519         - assign the _lock_file member variable when the display number is determined,
5520         - no need for parentheses around a single string format argument,
5521         - use FileSystem.exists method when checking if lock file is present as it
5522         makes the intention much more clearer.
5523
5524         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
5525         (XvfbDriver._start):
5526         (XvfbDriver.stop):
5527
5528 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
5529
5530         Make the String initialization on the function side of String::number()
5531         https://bugs.webkit.org/show_bug.cgi?id=95940
5532
5533         Reviewed by Benjamin Poulain.
5534
5535         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
5536         (testBoundaries):
5537         (testNumbers):
5538
5539 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
5540
5541         [WK2] expose element rect for color input type
5542         https://bugs.webkit.org/show_bug.cgi?id=91664
5543
5544         Reviewed by Simon Hausmann.
5545
5546         Update the QML logic in MiniBrowser to take advantage of this.
5547         The picker size is now hardcoded and we try to place it below the
5548         input element if possible.
5549
5550         * MiniBrowser/qt/qml/ColorChooser.qml:
5551
5552 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
5553
5554         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
5555         https://bugs.webkit.org/show_bug.cgi?id=95329
5556
5557         Reviewed by Kenneth Rohde Christiansen.
5558
5559         Explicitely disable TabToLinks setting in WebKitTestRunner.
5560         Tests override the "WebKitTabToLinksPreferenceKey" preference
5561         to enable it.
5562
5563         * WebKitTestRunner/TestController.cpp:
5564         (WTR::TestController::resetStateToConsistentValues):
5565
5566 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
5567
5568         webkit.py gdb pretty printer can't print CString
5569         https://bugs.webkit.org/show_bug.cgi?id=96068
5570
5571         Reviewed by Tony Chang.
5572
5573         Update WTFCStringPrinter to follow r126191.
5574
5575         * gdb/webkit.py:
5576         (WTFCStringPrinter.to_string):
5577
5578 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
5579
5580         Rename the ustring() accessor to string()
5581         https://bugs.webkit.org/show_bug.cgi?id=95919
5582
5583         Reviewed by Geoffrey Garen.
5584
5585         Update EFL's DRT.
5586
5587         Fix some string conversion that have been made useless
5588         with recent changes.
5589
5590         * DumpRenderTree/efl/EventSender.cpp:
5591         (keyPadNameFromJSValue):
5592         (keyNameFromJSValue):
5593         * DumpRenderTree/efl/TestRunnerEfl.cpp:
5594         (TestRunner::queueLoad):
5595         (TestRunner::addOriginAccessWhitelistEntry):
5596         (TestRunner::removeOriginAccessWhitelistEntry):
5597         (TestRunner::setUserStyleSheetLocation):
5598         (TestRunner::setValueForUser):
5599         (TestRunner::elementDoesAutoCompleteForElementWithId):
5600         (TestRunner::execCommand):
5601         (TestRunner::findString):
5602         (TestRunner::isCommandEnabled):
5603         (TestRunner::clearApplicationCacheForOrigin):
5604         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
5605         (TestRunner::pauseAnimationAtTimeOnElementWithId):
5606         (TestRunner::pauseTransitionAtTimeOnElementWithId):
5607         (toInt):
5608         (TestRunner::overridePreference):
5609         (TestRunner::addUserScript):
5610         (TestRunner::addUserStyleSheet):
5611         (TestRunner::evaluateInWebInspector):
5612         (TestRunner::evaluateScriptInIsolatedWorld):
5613         (TestRunner::setTextDirection):
5614         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
5615         (LoadItem::invoke):
5616         (LoadHTMLStringItem::invoke):
5617         (ScriptItem::invoke):
5618
5619 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
5620
5621         Extend third-party storage blocking API to optionally allow blocking all storage
5622         https://bugs.webkit.org/show_bug.cgi?id=95915
5623
5624         Reviewed by Brady Eidson.
5625
5626         Modified API test to use new revised API.
5627
5628         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
5629         (TestWebKitAPI::TEST):
5630
5631 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
5632
5633         AX: WebCore accessibility roles should be cross-platform
5634         https://bugs.webkit.org/show_bug.cgi?id=94870
5635
5636         Reviewed by Chris Fleizach.
5637
5638         Add debug strings to Chromium for new accessibility roles.
5639
5640         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
5641         (roleToString):
5642
5643 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
5644
5645         AX: Chromium needs access to canvasHasFallbackContent
5646         https://bugs.webkit.org/show_bug.cgi?id=96124
5647
5648         Reviewed by Chris Fleizach.
5649
5650         Distinguish between canvas roles with and without fallback
5651         content on Chromium.
5652
5653         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
5654         (getRole):
5655
5656 2012-09-07  Ojan Vafai  <ojan@chromium.org>
5657
5658         Handle non-existant TestExpectations files gracefully
5659         https://bugs.webkit.org/show_bug.cgi?id=96149
5660
5661         Reviewed by Eric Seidel.
5662
5663         Even when we get rid of Skipped files, we shouldn't have each port
5664         require a TestExpectations file for each platform if it doesn't
5665         need one.
5666
5667         * Scripts/webkitpy/layout_tests/port/base.py:
5668         (Port.expectations_dict):
5669         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
5670         (PortTest.test_nonexistant_expectations):
5671
5672 2012-09-07  Tony Chang  <tony@chromium.org>
5673
5674         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
5675         https://bugs.webkit.org/show_bug.cgi?id=96136
5676
5677         Reviewed by Ojan Vafai.
5678
5679         When we renamed the file to TestExpectations, it was no longer considered a text file so
5680         it was no longer being checked. Since then, test_expectations_overrides() has been removed
5681         from the port object, so I've removed that from the check. I'm not sure what it was
5682         supposed to do.
5683
5684         * Scripts/webkitpy/style/checker.py:
5685         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
5686         * Scripts/webkitpy/style/checkers/test_expectations.py:
5687         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
5688         (TestExpectationsChecker.check): Remove overrides param.
5689         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
5690         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
5691
5692 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
5693
5694         [EFL] Use same default minimum logical font size in DRT and WTR
5695         https://bugs.webkit.org/show_bug.cgi?id=96116
5696
5697         Reviewed by Martin Robinson.
5698
5699         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
5700         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
5701         logical font size to 9 to match the value used in WTR.
5702         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
5703         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
5704         logical font size to 9 (default value in WK2)
5705
5706 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
5707
5708         MediaStream API: add RTCPeerConnection::createAnswer
5709         https://bugs.webkit.org/show_bug.cgi?id=96092
5710
5711         Reviewed by Adam Barth.
5712
5713         Expanding and enhancing MockWebRTCPeerConnectionHandler.
5714
5715         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
5716         (MockWebRTCPeerConnectionHandler::createOffer):
5717         (MockWebRTCPeerConnectionHandler::createAnswer):
5718         (MockWebRTCPeerConnectionHandler::setLocalDescription):
5719         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
5720         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
5721         (MockWebRTCPeerConnectionHandler):
5722
5723 2012-09-07  Dean Jackson  <dino@apple.com>
5724
5725         Unreviewed changes to watchlist.
5726
5727         - Add new WebGL and Filters definitions
5728         - Add myself to OpenGL bugs
5729
5730         * Scripts/webkitpy/common/config/watchlist:
5731
5732 2012-09-07  Peter Beverloo  <peter@chromium.org>
5733
5734         Actually trigger the Android Tester
5735         https://bugs.webkit.org/show_bug.cgi?id=96118
5736
5737         Reviewed by Adam Barth.
5738
5739         * BuildSlaveSupport/build.webkit.org-config/config.json:
5740
5741 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
5742
5743         New time input needs accessibility
5744         https://bugs.webkit.org/show_bug.cgi?id=96032
5745
5746         Reviewed by Chris Fleizach.
5747
5748         Add support for valueDescription for testing.
5749
5750         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
5751         (getValueDescription):
5752         (AccessibilityUIElement::AccessibilityUIElement):
5753         (AccessibilityUIElement::valueDescriptionGetterCallback):
5754         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
5755         (AccessibilityUIElement):
5756
5757 2012-09-07  Peter Beverloo  <peter@chromium.org>
5758
5759         Add the google-android-tests build slave to the master's config
5760         https://bugs.webkit.org/show_bug.cgi?id=96113
5761
5762         Reviewed by Csaba Osztrogonác.
5763
5764         * BuildSlaveSupport/build.webkit.org-config/config.json:
5765
5766 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
5767
5768         [WK2] [EFL] Set theme for WebKit2 API test runner
5769         https://bugs.webkit.org/show_bug.cgi?id=96100
5770
5771         Reviewed by Kenneth Rohde Christiansen.
5772
5773         Set the theme generated by the build for the WebKit2 API test runner.
5774
5775         * TestWebKitAPI/PlatformEfl.cmake:
5776         * TestWebKitAPI/efl/PlatformWebView.cpp:
5777         (TestWebKitAPI::PlatformWebView::PlatformWebView):
5778
5779 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
5780
5781         Unreviewed. Add Gábor Ballabás as contributor.
5782
5783         * Scripts/webkitpy/common/config/committers.py:
5784
5785 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
5786
5787         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
5788         https://bugs.webkit.org/show_bug.cgi?id=96078
5789
5790         Reviewed by Tor Arne Vestbø.
5791
5792         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
5793
5794         * qmake/mkspecs/features/default_pre.prf:
5795
5796 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
5797
5798         [EFL] Add TestExpectations file for efl-wk1
5799         https://bugs.webkit.org/show_bug.cgi?id=96019
5800
5801         Reviewed by Gyuyoung Kim.
5802
5803         Update TestExpectations cascading for EFL port
5804         so that we use efl-wk1 -> efl search paths
5805         for WebKit1 EFL.
5806
5807         * Scripts/webkitpy/layout_tests/port/efl.py:
5808         (EflPort._search_paths):
5809
5810 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
5811
5812         [NRWT] XvfbDriver should stop the Xvfb more aggressively
5813         https://bugs.webkit.org/show_bug.cgi?id=95097
5814
5815         Reviewed by Dirk Pranke.
5816
5817         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
5818         terminating the process does not always work as expected, leading to timeouts
5819         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
5820         as it's not removed by the killed Xvfb process.
5821
5822         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
5823         is tested in different circumstances - whether pixel tests are enabled or not,
5824         with an arbitrary worker number or with an Xorg process already running on the system.
5825         The stopping of the driver is tested by checking that the Xvfb process is truly killed
5826         and then set to None.
5827
5828         * BuildSlaveSupport/kill-old-processes:
5829         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
5830         is left running, potentially clogging up a display at a certain position.
5831         * Scripts/webkitpy/common/system/executive_mock.py:
5832         (MockExecutive.__init__):
5833         The _running_pids is now a dictionary with process names as keys and pids
5834         as values.
5835         (MockExecutive.check_running_pid):
5836         Check whether the passed-in pid is in the _running_pids dictionary's values.
5837         (MockExecutive):
5838         (MockExecutive.running_pids):
5839         This method returns the list of all the process pids of which the name passes
5840         through the process_name_filter.
5841         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
5842         Use the Executive object of the port's host to check for running pids and open
5843         new subprocesses or kill them throughout the class.
5844         (XvfbDriver._start):
5845         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
5846         start the server process after it's created.
5847         (XvfbDriver.stop):
5848         Now kills the Xvfb process instead of terminating it and waiting for it to close.
5849         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
5850         (XvfbDriverTest):
5851         (XvfbDriverTest.make_driver):
5852         (XvfbDriverTest.assertDriverStartSuccessful):
5853         (XvfbDriverTest.test_start_no_pixel_tests):
5854         (XvfbDriverTest.test_start_pixel_tests):
5855         (XvfbDriverTest.test_start_arbitrary_worker_number):
5856         (XvfbDriverTest.test_start_existing_xorg_process):
5857         (XvfbDriverTest.test_stop):
5858         (XvfbDriverTest.test_stop.FakeXvfbProcess):
5859
5860 2012-09-06  Peter Beverloo  <peter@chromium.org>
5861
5862         Introduce the Chromium Android Release (Tests) bot
5863         https://bugs.webkit.org/show_bug.cgi?id=95980
5864
5865         Reviewed by Adam Barth.
5866
5867         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
5868         which will be running layout tests on actual Android devices. Right now,
5869         four Galaxy Nexus phones are attached.
5870
5871         * BuildSlaveSupport/build.webkit.org-config/config.json:
5872
5873 2012-09-06  James Robinson  <jamesr@chromium.org>
5874
5875         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
5876         https://bugs.webkit.org/show_bug.cgi?id=96007
5877
5878         Reviewed by Adrienne Walker.
5879
5880         Fixes initialization / settings code to use WebCompositorSupport.
5881
5882         * DumpRenderTree/chromium/DumpRenderTree.cpp:
5883         (main):
5884         * DumpRenderTree/chromium/TestShell.cpp:
5885         (TestShell::initialize):
5886         (TestShell::setPerTilePaintingEnabled):
5887
5888 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
5889
5890         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
5891         https://bugs.webkit.org/show_bug.cgi?id=95995
5892
5893         Reviewed by Kenneth Rohde Christiansen.
5894
5895         Provide proper implementation for PlatformWebView::windowFrame()
5896         in EFL's WebKitTestRunner.
5897
5898         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
5899         (WTR::PlatformWebView::windowFrame):
5900
5901 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
5902
5903         Fix WTF.Lrint on 32-bit platforms
5904         https://bugs.webkit.org/show_bug.cgi?id=96003
5905
5906         Reviewed by Benjamin Poulain.
5907
5908         Fixed failing WTF.Lrint test on 32-bit platforms.
5909
5910         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
5911         (TestWebKitAPI::TEST):
5912
5913 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
5914
5915         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
5916         https://bugs.webkit.org/show_bug.cgi?id=95839
5917
5918         Reviewed by Adam Barth.
5919
5920         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
5921         up the task definitions a bit. There was no need to have them in the header file.
5922
5923         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
5924         (RTCSessionDescriptionRequestSuccededTask):
5925         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
5926         (RTCSessionDescriptionRequestFailedTask):
5927         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
5928         (RTCVoidRequestTask):
5929         (RTCVoidRequestTask::RTCVoidRequestTask):
5930         (MockWebRTCPeerConnectionHandler::createOffer):
5931         (MockWebRTCPeerConnectionHandler::setLocalDescription):
5932         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
5933         (MockWebRTCPeerConnectionHandler::localDescription):
5934         (MockWebRTCPeerConnectionHandler::remoteDescription):
5935         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
5936         (MockWebRTCPeerConnectionHandler):
5937
5938 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
5939
5940         [Qt] Fix build on Mac OS X 10.6
5941         https://bugs.webkit.org/show_bug.cgi?id=95200
5942
5943         Reviewed by Tor Arne Vestbø.
5944
5945         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
5946         10.7 and newer.
5947
5948         * qmake/mkspecs/features/features.prf:
5949
5950 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
5951
5952         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
5953         https://bugs.webkit.org/show_bug.cgi?id=95973
5954
5955         Reviewed by Kenneth Rohde Christiansen.
5956
5957         Correctly map "addSelectionKey" to "Control" modifier
5958         in WKTR's EventSender on other OSes than Mac OS X,
5959         instead of mapping it to the "Meta" modifier.
5960
5961         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
5962         (WTR::parseModifier):
5963
5964 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
5965
5966         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
5967         https://bugs.webkit.org/show_bug.cgi?id=95710
5968
5969         Reviewed by Dirk Pranke.
5970
5971         The stdout / stderr output can be None so make sure
5972         we won't raise an exception in this case.
5973
5974         * Scripts/webkitpy/layout_tests/port/driver.py:
5975         (Driver.run_test):
5976
5977 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
5978
5979         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
5980         https://bugs.webkit.org/show_bug.cgi?id=95849
5981
5982         Reviewed by Kenneth Rohde Christiansen.
5983
5984         Sanitize URLs passed by the user as program
5985         argument or typed in the URL bar in order to
5986         be more tolerant.
5987
5988         * EWebLauncher/CMakeLists.txt:
5989         * EWebLauncher/main.c:
5990         (main):
5991         * EWebLauncher/url_bar.c:
5992         (_url_bar_url_get_with_protocol):
5993         (on_urlbar_key_down):
5994         * EWebLauncher/url_utils.c: Added.
5995         (has_scheme):
5996         (url_from_user_input): Add utility function to construct a
5997         URL from user input.
5998         * EWebLauncher/url_utils.h: Added.
5999         * MiniBrowser/efl/CMakeLists.txt:
6000         * MiniBrowser/efl/main.c:
6001         (main):
6002
6003 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
6004
6005         [Qt] Various small Windows / MSVC build fixes
6006         https://bugs.webkit.org/show_bug.cgi?id=95934
6007
6008         Reviewed by Kenneth Rohde Christiansen.
6009
6010         setFocus takes a boolean as argument: Don't try to implicitly convert
6011         an enum to a boolean, MSVC doesn't like that. The intent here is to
6012         enable focus, so just pass true.
6013
6014         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
6015         (WTR::PlatformWebView::focus):
6016
6017 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
6018
6019         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
6020         https://bugs.webkit.org/show_bug.cgi?id=95965
6021
6022         Reviewed by Tor Arne Vestbø.
6023
6024         Add ANGLE as a static library module to the Qt WebKit build system.
6025
6026         * qmake/mkspecs/features/default_post.prf:
6027         * qmake/mkspecs/modules/angle.prf: Added.
6028
6029 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
6030
6031         [WK2] Make [Qt]ViewportHandler cross platform
6032         https://bugs.webkit.org/show_bug.cgi?id=91257
6033
6034         Reviewed by Kenneth Rohde Christiansen.
6035
6036         Remove initial scale from viewport info item since it is
6037         set to -1 after applied thus it does not hold any valuable
6038         information.
6039
6040         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
6041
6042 2012-09-05  Tony Chang  <tony@chromium.org>
6043
6044         [chromium] Remove dependency on webkit_user_agent
6045         https://bugs.webkit.org/show_bug.cgi?id=95886
6046
6047         Reviewed by Adam Barth.
6048
6049         The code isn't used by DumpRenderTree.
6050
6051         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
6052
6053 2012-09-05  Rick Byers  <rbyers@chromium.org>
6054
6055         Update chromium DumpRenderTree for new WebGestureEvent fields
6056         https://bugs.webkit.org/show_bug.cgi?id=95573
6057
6058         Reviewed by James Robinson.
6059
6060         Update EventSender to write gesture details into the appropriate
6061         type-specific WebGestureEvent fields.
6062         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
6063         (EventSender::gestureEvent):
6064         (EventSender::gestureFlingStart):
6065
6066 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
6067
6068         NRWT lies about the number of tests that it's skipping when used with --repeat-each
6069         https://bugs.webkit.org/show_bug.cgi?id=95789
6070
6071         Reviewed by Ojan Vafai.
6072
6073         Fix miscalculation in log message.
6074
6075         * Scripts/webkitpy/layout_tests/views/printing.py:
6076         (Printer.print_found):
6077
6078 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
6079
6080         Unreviewed, rolling out r127612, r127660, and r127664.
6081         http://trac.webkit.org/changeset/127612
6082         http://trac.webkit.org/changeset/127660
6083         http://trac.webkit.org/changeset/127664
6084         https://bugs.webkit.org/show_bug.cgi?id=95920
6085
6086         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
6087         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
6088         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
6089         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
6090         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
6091         (MockWebRTCPeerConnectionHandler::createOffer):
6092         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
6093         (MockWebRTCPeerConnectionHandler):
6094         (SuccessCallbackTask):
6095         (FailureCallbackTask):
6096
6097 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
6098
6099         Ignore-metrics includes scroll offsets.
6100         https://bugs.webkit.org/show_bug.cgi?id=95845
6101
6102         Reviewed by Dirk Pranke.
6103
6104         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
6105
6106         * Scripts/old-run-webkit-tests:
6107         (stripMetrics):
6108         * Scripts/webkitpy/layout_tests/port/driver.py:
6109         (DriverOutput):
6110
6111 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
6112
6113         Unreviewed test fix.
6114
6115         Including a plugin source file into the build that was added in r127595.
6116
6117         * GNUmakefile.am:
6118
6119 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
6120
6121         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
6122         https://bugs.webkit.org/show_bug.cgi?id=95839
6123
6124         Reviewed by Adam Barth.
6125
6126         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
6127         up the task definitions a bit. There was no need to have them in the header file.
6128
6129         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
6130         (RTCSessionDescriptionRequestSuccededTask):
6131         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
6132         (RTCSessionDescriptionRequestFailedTask):
6133         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
6134         (RTCVoidRequestTask):
6135         (RTCVoidRequestTask::RTCVoidRequestTask):
6136         (MockWebRTCPeerConnectionHandler::createOffer):
6137         (MockWebRTCPeerConnectionHandler::setLocalDescription):
6138         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
6139         (MockWebRTCPeerConnectionHandler::localDescription):
6140         (MockWebRTCPeerConnectionHandler::remoteDescription):
6141         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
6142         (MockWebRTCPeerConnectionHandler):
6143
6144 2012-09-05  Kangil Han  <kangil.han@samsung.com>
6145
6146         [EFL] Remove '+=' usage in String
6147         https://bugs.webkit.org/show_bug.cgi?id=95808
6148
6149         Reviewed by Benjamin Poulain.
6150
6151         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
6152
6153         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
6154         (descriptionSuitableForTestResult):
6155
6156 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
6157
6158         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
6159         https://bugs.webkit.org/show_bug.cgi?id=95842
6160
6161         Reviewed by Kenneth Rohde Christiansen.
6162
6163         Provide proper implementation for TestRunner::pathToLocalResource()
6164         in EFL WKTR, identical to the one for DumpRenderTree.
6165
6166         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
6167         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
6168         are found my WebKitTestRunner.
6169
6170         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
6171         (WTR::TestRunner::pathToLocalResource):
6172
6173 2012-09-05  Brady Eidson  <beidson@apple.com>
6174
6175         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
6176         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
6177
6178         Reviewed by Andy Estes.
6179
6180         Add a plug-in that always fails to initialize:
6181         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
6182         (NPPNewFails):
6183         (NPPNewFails::NPPNewFails):
6184         (NPPNewFails::NPP_New):
6185
6186         Add it to all the project files:
6187         * DumpRenderTree/DumpRenderTree.gypi:
6188         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
6189         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
6190         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
6191         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
6192
6193 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
6194
6195         [Qt] Fix makefile race condition between derived sources and target
6196
6197         r121966 removed too much of the old qmake logic, including the rule
6198         that ensured that qmake_all would not trigger dual runs of qmake --
6199         one of the derived sources -qmake-all rule, and one for making the
6200         derived sources.
6201
6202         We now follow a similar pattern as before, by introducing a custom
6203         target that explicitly depends on the derived sources' qmake-all before
6204         doing a manual run of make. That ensures a single qmake run for the derived
6205         sources.
6206
6207         https://bugs.webkit.org/show_bug.cgi?id=93847
6208
6209         Reviewed by Csaba Osztrogonác.
6210
6211         * qmake/mkspecs/features/functions.prf:
6212
6213 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
6214
6215         WKTR doesn't implement dumpWillCacheResponse()
6216         https://bugs.webkit.org/show_bug.cgi?id=94607
6217
6218         Reviewed by Kenneth Rohde Christiansen.
6219
6220         Define shouldCacheResponse() callback in resource
6221         load client and provide implementation for
6222         dumpWillCacheResponse() in WebKitTestRunner.
6223
6224         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
6225         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
6226         (WTR::InjectedBundlePage::InjectedBundlePage):
6227         (WTR::InjectedBundlePage::shouldCacheResponse):
6228         (WTR):
6229         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
6230         (InjectedBundlePage):
6231         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
6232         (WTR::TestRunner::TestRunner):
6233         * WebKitTestRunner/InjectedBundle/TestRunner.h:
6234         (WTR::TestRunner::dumpWillCacheResponse):
6235         (WTR::TestRunner::shouldDumpWillCacheResponse):
6236         (TestRunner):
6237
6238 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
6239
6240         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
6241         https://bugs.webkit.org/show_bug.cgi?id=92735
6242
6243         Reviewed by Hajime Morita.
6244
6245         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
6246
6247         * DumpRenderTree/TestRunner.cpp:
6248         (TestRunner::staticFunctions):
6249         * DumpRenderTree/TestRunner.h:
6250         (TestRunner):
6251         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
6252         (TestRunner::addUserStyleSheet):
6253         * DumpRenderTree/chromium/DRTTestRunner.cpp:
6254         (DRTTestRunner::DRTTestRunner):
6255         (DRTTestRunner::hasCustomPageSizeStyle):
6256         * DumpRenderTree/chromium/DRTTestRunner.h:
6257         (DRTTestRunner):
6258         * DumpRenderTree/efl/TestRunnerEfl.cpp:
6259         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
6260         * DumpRenderTree/mac/TestRunnerMac.mm:
6261         * DumpRenderTree/qt/TestRunnerQt.cpp:
6262         (TestRunner::evaluateScriptInIsolatedWorld):
6263         * DumpRenderTree/qt/TestRunnerQt.h:
6264         (TestRunner):
6265         * DumpRenderTree/win/TestRunnerWin.cpp:
6266         * DumpRenderTree/wx/TestRunnerWx.cpp:
6267         (TestRunner::abortModal):
6268         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
6269         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
6270         (WTR):
6271         * WebKitTestRunner/InjectedBundle/TestRunner.h:
6272         (TestRunner):
6273
6274 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
6275
6276         [Qt] Automate the use of AllInOne files in the Qt build
6277         https://bugs.webkit.org/show_bug.cgi?id=95837
6278
6279         Reviewed by Tor Arne Vestbø.
6280
6281         New feature file that implements the all-in-one file automation by
6282         adding the requested all-in-one files to SOURCES and removing the files
6283         it includes from SOURCES.
6284
6285         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
6286
6287 2012-09-04  Tim Horton  <timothy_horton@apple.com>
6288
6289         Have NRWT log more output when crash logs are missing
6290         https://bugs.webkit.org/show_bug.cgi?id=95814
6291
6292         Reviewed by Dan Bernstein.
6293
6294         Log the stderr and stdout of the test, in order to provide slightly more
6295         context when the WebProcess times out while running tests.
6296
6297         * Scripts/webkitpy/layout_tests/port/driver.py:
6298         (Driver.run_test):
6299
6300 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
6301
6302         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
6303         https://bugs.webkit.org/show_bug.cgi?id=95770
6304
6305         Reviewed by Adam Barth.
6306
6307         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
6308         (ChromiumAndroidDriver.__init__):
6309         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
6310         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
6311         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
6312         (ChromiumAndroidDriver._push_executable):
6313         (ChromiumAndroidDriver._push_fonts):
6314         (ChromiumAndroidDriver._push_test_resources):
6315         (ChromiumAndroidDriver._run_adb_command):
6316         (ChromiumAndroidDriver._get_last_stacktrace):
6317         (ChromiumAndroidDriver._get_crash_log):
6318         (ChromiumAndroidDriver._start):
6319         (ChromiumAndroidDriver._start_once):
6320         (ChromiumAndroidDriver._start_once.deadlock_detector):
6321         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
6322         (ChromiumAndroidDriverTest.test_get_crash_log):
6323
6324 2012-09-04  Satish Sampath  <satish@chromium.org>
6325
6326         Run git commands within the checkout directory
6327         https://bugs.webkit.org/show_bug.cgi?id=95742
6328
6329         Reviewed by Eric Seidel.
6330
6331         git commands run from scm/git.py are sometimes run with cwd set to the
6332         checkout_root and other times with whatever directory was the default cwd.
6333         Instead all these should run with the checkout root set as the cwd
6334         (except where we explicitly need a different path)
6335
6336         * Scripts/webkitpy/common/checkout/scm/git.py:
6337         (Git._run_git):
6338         (Git.find_checkout_root):
6339         (Git.discard_local_commits):
6340         (Git.local_commits):
6341         (Git.working_directory_is_clean):
6342         (Git.clean_working_directory):
6343         (Git.add_list):
6344         (Git.delete_list):
6345         (Git.exists):
6346         (Git._current_branch):
6347         (Git._changes_files_for_commit):
6348         (Git.revisions_changing_file):
6349         (Git.svn_revision):
6350         (Git._run_git_svn_find_rev):
6351         (Git.contents_at_revision):
6352         (Git.diff_for_file):
6353         (Git.show_head):
6354         (Git.committer_email_for_revision):
6355         (Git.apply_reverse_diff):
6356         (Git.revert_files):
6357         (Git.commit_with_message):
6358         (Git._commit_on_branch):
6359         (Git.svn_commit_log):
6360         (Git.last_svn_commit_log):
6361         (Git.svn_blame):
6362         (Git._branch_ref_exists):
6363         (Git.delete_branch):
6364         (Git.remote_merge_base):
6365         (Git.commit_locally_with_message):
6366         (Git.push_local_commits_to_server):
6367         (Git.commit_ids_from_commitish_arguments):
6368         (Git.commit_message_for_local_commit):
6369         (Git.files_changed_summary_for_commit):
6370
6371 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
6372
6373         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
6374         https://bugs.webkit.org/show_bug.cgi?id=95734
6375
6376         Reviewed by Adam Barth.
6377
6378         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
6379         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
6380         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
6381         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
6382         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
6383         (MockWebRTCPeerConnectionHandler::createOffer):
6384         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
6385         (MockWebRTCPeerConnectionHandler):
6386         (MockWebRTCPeerConnectionHandler::taskList):
6387         (SuccessCallbackTask):
6388         (FailureCallbackTask):
6389
6390 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
6391
6392         [Chromium-Android] Output time and thread info in crash log
6393         https://bugs.webkit.org/show_bug.cgi?id=95768
6394
6395         Reviewed by Adam Barth.
6396
6397         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
6398         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
6399
6400 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
6401
6402         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
6403         https://bugs.webkit.org/show_bug.cgi?id=95721
6404
6405         Reviewed by Adam Barth.
6406
6407         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
6408         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
6409         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
6410         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
6411         (MockWebMediaStreamCenter):
6412
6413 2012-09-04  Tony Chang  <tony@chromium.org>
6414
6415         Elide test names when running new-run-webkit-tests
6416         https://bugs.webkit.org/show_bug.cgi?id=95626
6417
6418         Reviewed by Dirk Pranke.
6419
6420         When the test name exceeds the number of terminal columns, it leaves
6421         text on the screen. Avoid this by eliding the test name when running
6422         tests. This is similar to what ninja does when compiling.
6423
6424         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
6425         (MeteredStream):
6426         (MeteredStream.number_of_columns): Helper method to get number of
6427         terminal columns. Won't work on Win32 python, but meh.
6428         * Scripts/webkitpy/layout_tests/views/printing.py:
6429         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
6430         because stderr appears to be ascii only.
6431         (Printer.print_started_test): Route through _test_status_line.
6432         (Printer.print_finished_test): Route through _test_status_line.
6433         (Printer._print_test_trace): Route through _test_status_line.
6434         (Printer._print_baseline): Route through _test_status_line.
6435         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
6436         (test_test_status_line): Test for _test_status_line.
6437
6438 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
6439
6440         [GTK] Print API missing documentation when generating gtkdoc
6441         https://bugs.webkit.org/show_bug.cgi?id=95703
6442
6443         Reviewed by Carlos Garcia Campos.
6444
6445         Print out API missing documentation when generating gtkdoc. This makes it
6446         easier to fix documentation errors.
6447
6448         * gtk/generate-gtkdoc:
6449         (print_missing_api): Added.
6450         (generate_doc): Inline the rebase step, since it now reports an error
6451         when you try to rebase without generating documentation first.
6452         * gtk/gtkdoc.py:
6453         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
6454         generating documentation first to enable a small cleanup at the caller.
6455         (GTKDoc.api_missing_documentation): Added.
6456
6457 2012-09-04  Vincent Scheib  <scheib@chromium.org>
6458
6459         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
6460         https://bugs.webkit.org/show_bug.cgi?id=95628
6461
6462         Reviewed by James Robinson.
6463
6464         Future tests need the ability to respond asynchronously that
6465         pointer lock requests have been accepted or rejected. This patch
6466         adds the following:
6467             testRunner.setPointerLockWillRespondAsynchronously();
6468             testRunner.didAcquirePointerLock();
6469             testRunner.didNotAcquirePointerLock();
6470
6471         Tested in existing test:
6472             pointerlockchange-pointerlockerror-events.html
6473
6474         * DumpRenderTree/chromium/DRTTestRunner.cpp:
6475         (DRTTestRunner::DRTTestRunner):
6476         (DRTTestRunner::didAcquirePointerLock):
6477         (DRTTestRunner::didNotAcquirePointerLock):
6478         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
6479         * DumpRenderTree/chromium/DRTTestRunner.h:
6480         (DRTTestRunner):
6481         * DumpRenderTree/chromium/WebViewHost.cpp:
6482         (WebViewHost::requestPointerLock):
6483         (WebViewHost::didAcquirePointerLock):
6484         (WebViewHost::didNotAcquirePointerLock):
6485         * DumpRenderTree/chromium/WebViewHost.h:
6486         (WebViewHost):
6487         (WebViewHost::setPointerLockWillRespondAsynchronously):
6488
6489 2012-09-04  Ojan Vafai  <ojan@chromium.org>
6490
6491         Move content shell bots to their own builder group
6492         https://bugs.webkit.org/show_bug.cgi?id=95765
6493
6494         Reviewed by Adam Barth.
6495
6496         In their current state of instability, they add too much noise. Once they get more stable,
6497         we can add them back to the regular group or just have them replace the other bots.
6498
6499         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
6500
6501         * TestResultServer/static-dashboards/builders.js:
6502         (isWebkitTestRunner):
6503         (isChromiumContentShellTestRunner):
6504         (isChromiumWebkitTipOfTreeTestRunner):
6505         (loadBuildersList):
6506
6507 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
6508
6509         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
6510         https://bugs.webkit.org/show_bug.cgi?id=95689
6511
6512         Reviewed by Kenneth Rohde Christiansen.
6513
6514         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
6515         So, there are bugs that key events are always generated in url bar although
6516         the user clicked the web view.
6517
6518         This patch recovers the focus of the web view when left button is pressed and
6519         adds for MiniBrowser to toggle the focus when middle button is pressed
6520         like EWebLauncher already did.
6521
6522         * EWebLauncher/main.c:
6523         (on_mouse_down):
6524         * MiniBrowser/efl/main.c:
6525         (on_mouse_down):
6526         (browserCreate):
6527
6528 2012-09-03  Tao Bai  <michaelbai@chromium.org>
6529
6530         Added ANDROID_GDBSERVER definition for Ant
6531         https://bugs.webkit.org/show_bug.cgi?id=95265
6532
6533         Reviewed by Adam Barth.
6534
6535         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
6536         is only used for finding the gdbserver.
6537
6538         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
6539         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
6540
6541 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
6542
6543         MediaStream API: Add Ice-related functionality to RTCPeerConnection
6544         https://bugs.webkit.org/show_bug.cgi?id=95565
6545
6546         Reviewed by Adam Barth.
6547
6548         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
6549         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
6550         (MockWebRTCPeerConnectionHandler::updateICE):
6551         (MockWebRTCPeerConnectionHandler::addICECandidate):
6552         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
6553         (MockWebRTCPeerConnectionHandler):
6554
6555 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
6556
6557         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
6558         https://bugs.webkit.org/show_bug.cgi?id=95670
6559
6560         Reviewed by Kenneth Rohde Christiansen.
6561
6562         Fix layout issues related to the URL bar in Minibrowser
6563         and EWebLauncher when the window is resized.
6564
6565         The URL bar was not resized accordingly and the Web
6566         page was moved behing the URL bar, hiding part of it.
6567
6568         * EWebLauncher/main.c:
6569         (on_ecore_evas_resize):
6570         (closeWindow):
6571         * EWebLauncher/url_bar.c:
6572         (url_bar_width_set):
6573         (url_bar_add):
6574         * EWebLauncher/url_bar.h:
6575         * MiniBrowser/efl/main.c:
6576         (on_ecore_evas_resize):
6577         (main):
6578
6579 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
6580
6581         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
6582         https://bugs.webkit.org/show_bug.cgi?id=95605
6583
6584         Reviewed by Dirk Pranke.
6585
6586         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
6587
6588         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
6589         (ChromiumAndroidPort.check_sys_deps):
6590         (ChromiumAndroidPort.expectations_files):
6591         (ChromiumAndroidPort.clean_up_test_run):
6592
6593 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
6594
6595         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
6596         https://bugs.webkit.org/show_bug.cgi?id=95180
6597
6598         Reviewed by Chris Fleizach.
6599
6600         The bug that was fixed stood in the way of fully implementing stringValue().
6601         Testing that the bug is fixed requires stringValue() to be fully implemented
6602         and object replacement characters to be printable.
6603
6604         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
6605         (replaceCharactersForResults): New method which turns object replacement
6606         characters into "<obj>" so that the characters can be properly shown in
6607         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
6608         accessible text of a single object in the accessible tree doesn't mess up
6609         the readibility of the results.
6610         (AccessibilityUIElement::stringValue): Remove the code that immediately
6611         returned upon encountering an object of ATK_ROLE_PANEL and call the new
6612         replaceCharactersForResults() prior to returning the accessible string
6613         value.
6614
6615 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
6616
6617         MediaStream API: Add MediaStream management to RTCPeerConnection
6618         https://bugs.webkit.org/show_bug.cgi?id=95543
6619
6620         Reviewed by Adam Barth.
6621
6622         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
6623
6624         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
6625         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
6626         (MockWebRTCPeerConnectionHandler::addStream):
6627         (MockWebRTCPeerConnectionHandler::removeStream):
6628         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
6629         (MockWebRTCPeerConnectionHandler):
6630
6631 2012-08-31  Tony Chang  <tony@chromium.org>
6632
6633         Remove ENABLE_CSS3_FLEXBOX compile time flag
6634         https://bugs.webkit.org/show_bug.cgi?id=95382
6635
6636         Reviewed by Ojan Vafai.
6637
6638         Everyone is already enabling this by default and the spec has stablized.
6639
6640         * Scripts/webkitperl/FeatureList.pm:
6641         * qmake/mkspecs/features/features.pri:
6642
6643 2012-08-31  Pratik Solanki  <psolanki@apple.com>
6644
6645         objc_msgSend and IMP should be cast appropriately before using
6646         https://bugs.webkit.org/show_bug.cgi?id=95242
6647
6648         Reviewed by Benjamin Poulain.
6649
6650         Fix for older compilers. Pass id as the return type to the template
6651         instead of relying on default type.
6652
6653         * DumpRenderTree/mac/DumpRenderTree.mm:
6654         (drt_NSFontManager_availableFontFamilies):
6655         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
6656         (WTR::wtr_NSFontManager_availableFontFamilies):
6657
6658 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
6659
6660         nrwt: use scm instead of calling svn directly to get the revision in json results generator
6661         https://bugs.webkit.org/show_bug.cgi?id=89616
6662
6663         Reviewed by Eric Seidel.
6664
6665         Add the new 'executive' optional function argument to the SCM.in_working_directory
6666         class method. This way we get to reuse an Executive instance which is necessary in testing
6667         when we're operating with a mock version of the object.
6668
6669         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
6670         the SCMDetector with the generator's FileSystem and Executive instances.
6671
6672         * Scripts/webkitpy/common/checkout/scm/detection.py:
6673         (SCMDetector.detect_scm_system):
6674         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
6675         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
6676         Executive output and test it against expected output.
6677         * Scripts/webkitpy/common/checkout/scm/git.py:
6678         (Git.in_working_directory):
6679         * Scripts/webkitpy/common/checkout/scm/scm.py:
6680         (SCM.in_working_directory):
6681         * Scripts/webkitpy/common/checkout/scm/svn.py:
6682         (SVN.in_working_directory):
6683         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
6684         (JSONResultsGeneratorBase.__init__):
6685         (JSONResultsGeneratorBase._get_svn_revision):
6686
6687 2012-08-31  Jon Lee  <jonlee@apple.com>
6688
6689         [Tests] Add basic tests to http/tests/notifications
6690         https://bugs.webkit.org/show_bug.cgi?id=95493
6691         <rdar://problem/12209303>
6692
6693         Reviewed by Alexey Proskuryakov.
6694
6695         Add permission request support for WTR.
6696
6697         * WebKitTestRunner/TestController.cpp:
6698         (WTR::TestController::initialize):
6699         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
6700         * WebKitTestRunner/TestController.h:
6701         (TestController):
6702
6703 2012-08-31  Jon Lee  <jonlee@apple.com>
6704
6705         [DRT] Make simulating a web click on a notification a queued task
6706         https://bugs.webkit.org/show_bug.cgi?id=95546
6707         <rdar://problem/12214170>
6708
6709         Reviewed by Alexey Proskuryakov.
6710
6711         Making the web click happen asynchronously better mimics user interaction with the platform.
6712
6713         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
6714         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
6715         not set.
6716         * DumpRenderTree/mac/DumpRenderTree.mm:
6717         (dump): Assert that the flag is not set.
6718         * DumpRenderTree/mac/TestRunnerMac.mm:
6719         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
6720         notification. In the case where the block gets executed after the flag has been unset, we avoid
6721         performing the click.
6722
6723 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
6724
6725         [Qt] ImageDiff output is not in the expected form if image dimensions differ
6726         https://bugs.webkit.org/show_bug.cgi?id=95575
6727
6728         Reviewed by Csaba Osztrogonác.
6729
6730         Output 100% difference in the case of differing image dimensions so
6731         the test harness knows that we won't produce any output further.
6732         This matches the behavior of other ports.
6733
6734         * DumpRenderTree/qt/ImageDiff.cpp:
6735         (main):
6736
6737 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
6738
6739         Unreviewed, rolling out r127261.
6740         http://trac.webkit.org/changeset/127261
6741         https://bugs.webkit.org/show_bug.cgi?id=95572
6742
6743         This patch depends on other build fixes (see blockers of bug
6744         95466) which should land first (Requested by milian on
6745         #webkit).
6746
6747         * qmake/mkspecs/features/features.prf:
6748
6749 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
6750
6751         [Qt] Support WebKit2/QML on QNX
6752         https://bugs.webkit.org/show_bug.cgi?id=95466
6753
6754         Reviewed by Noam Rosenthal.
6755
6756         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
6757         this should finally work now.
6758
6759         * qmake/mkspecs/features/features.prf:
6760
6761 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
6762
6763         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
6764         https://bugs.webkit.org/show_bug.cgi?id=95400
6765
6766         Reviewed by Dirk Pranke.
6767
6768         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
6769
6770         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
6771         (ChromiumAndroidPort.skipped_layout_tests):
6772
6773 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
6774
6775         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
6776         https://bugs.webkit.org/show_bug.cgi?id=95499
6777
6778         Unreviewed. One more fix to avoid trying to run the empty string.
6779
6780         * Scripts/webkitdirs.pm:
6781         (buildAutotoolsProject):
6782
6783 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
6784
6785         Unreviewed, rolling out r127171.
6786         http://trac.webkit.org/changeset/127171
6787         https://bugs.webkit.org/show_bug.cgi?id=95505
6788
6789         testRunner does not need dumpWebNotificationCallbacks().
6790         (Requested by jonlee on #webkit).
6791
6792         * DumpRenderTree/TestRunner.cpp:
6793         (TestRunner::TestRunner):
6794         (TestRunner::staticFunctions):
6795         * DumpRenderTree/TestRunner.h:
6796         (TestRunner):
6797         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
6798         (-[MockWebNotificationProvider webView:didShowNotification:]):
6799         (-[MockWebNotificationProvider webView:didClickNotification:]):
6800         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
6801         * DumpRenderTree/mac/UIDelegate.mm:
6802         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
6803
6804 2012-08-30  Pratik Solanki  <psolanki@apple.com>
6805
6806         objc_msgSend and IMP should be cast appropriately before using
6807         https://bugs.webkit.org/show_bug.cgi?id=95242
6808
6809         Reviewed by Benjamin Poulain.
6810
6811         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
6812         to a function pointer with right types when calling objc_msgSend and an
6813         IMP method directly.
6814
6815         * DumpRenderTree/mac/DumpRenderTree.mm:
6816         (drt_NSFontManager_availableFontFamilies):
6817         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
6818         (WTR::wtr_NSFontManager_availableFontFamilies):
6819
6820 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
6821
6822         Replace JSC::UString by WTF::String
6823         https://bugs.webkit.org/show_bug.cgi?id=95271
6824
6825         Reviewed by Geoffrey Garen.
6826
6827         Get rid of UString.
6828
6829         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
6830         * gdb/webkit.py:
6831         (WTFStringPrinter.to_string):
6832         (JSCIdentifierPrinter.to_string):
6833         (JSCJSStringPrinter.to_string):
6834         (add_pretty_printers):
6835
6836 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
6837
6838         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
6839         https://bugs.webkit.org/show_bug.cgi?id=95495
6840
6841         Reviewed by Ojan Vafai.
6842
6843         This is a follow-on to bug 95370 that adds in support for
6844         platform/wk2/TestExpectations and
6845         platform/{mac,win}-$version/TestExpectations.
6846
6847         * Scripts/webkitpy/layout_tests/port/apple.py:
6848         (ApplePort.expectations_files):
6849         * Scripts/webkitpy/layout_tests/port/base.py:
6850         (Port._skipped_file_search_paths):
6851         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
6852         (MacTest.test_expectations_files):
6853         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
6854         (MockDRTPortTest.make_port):
6855         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
6856         (WinPortTest.test_expectations_files):
6857
6858 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
6859
6860         executive.run_in_parallel() hangs if given nothing to do
6861         https://bugs.webkit.org/show_bug.cgi?id=95387
6862
6863         Reviewed by Ojan Vafai.
6864
6865         Check to make sure that Executive.run_in_parallel() requires
6866         a non-empty list of commands to execute; passing an empty list
6867         seems surely like a programming error.
6868
6869         * Scripts/webkitpy/common/system/executive.py:
6870         (Executive.run_in_parallel):
6871         * Scripts/webkitpy/common/system/executive_unittest.py:
6872         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
6873
6874 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
6875
6876         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
6877         https://bugs.webkit.org/show_bug.cgi?id=94746
6878
6879         Reviewed by Ojan Vafai.
6880
6881         Add an assertion to diff_image() to check that we are passing
6882         tolerance=0 explicitly when diffing ref test results.
6883
6884         * Scripts/webkitpy/layout_tests/port/test.py:
6885         (TestPort.diff_image):
6886
6887 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
6888
6889         NRWT should look in mac-wk2 for a TestExpecations file
6890         https://bugs.webkit.org/show_bug.cgi?id=95370
6891
6892         Reviewed by Ojan Vafai.
6893
6894         Adds support for mac-wk2 and win-wk2 to expectations_files()
6895         for the apple mac and apple win ports.
6896         
6897         * Scripts/webkitpy/layout_tests/port/apple.py:
6898         (ApplePort.expectations_files):
6899         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
6900         (MacTest.test_expectations_files):
6901         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
6902         (WinTest.test_expectations_files):
6903         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
6904         (PortTestCase.test_expectations_files):
6905
6906 2012-08-30  Jon Lee  <jonlee@apple.com>
6907
6908         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
6909         https://bugs.webkit.org/show_bug.cgi?id=95232
6910         <rdar://problem/12190776>
6911
6912         Reviewed by Alexey Proskuryakov.
6913
6914         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
6915
6916         * DumpRenderTree/TestRunner.cpp:
6917         (TestRunner::TestRunner):
6918         (dumpWebNotificationCallbacksCallback):
6919         (TestRunner::staticFunctions):
6920         * DumpRenderTree/TestRunner.h:
6921         (TestRunner):
6922         (TestRunner::dumpWebNotificationCallbacks):
6923         (TestRunner::setDumpWebNotificationCallbacks):
6924         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
6925         (-[WebNotification _drt_descriptionSuitableForTestResult]):
6926         (-[MockWebNotificationProvider webView:didShowNotification:]):
6927         (-[MockWebNotificationProvider webView:didClickNotification:]):
6928         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
6929         * DumpRenderTree/mac/UIDelegate.mm:
6930         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
6931
6932 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
6933
6934         MediaStream API: Introduce MediaConstraints
6935         https://bugs.webkit.org/show_bug.cgi?id=95198
6936
6937         Reviewed by Adam Barth.
6938
6939         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
6940
6941         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
6942         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
6943         (isSupportedConstraint):
6944         (isValidConstraint):
6945         (MockWebRTCPeerConnectionHandler::initialize):
6946         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
6947         (MockWebRTCPeerConnectionHandler):
6948
6949 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
6950
6951         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
6952         https://bugs.webkit.org/show_bug.cgi?id=95454
6953
6954         Reviewed by Kenneth Rohde Christiansen.
6955
6956         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
6957
6958         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
6959         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
6960
6961 2012-08-30  Leo Yang  <leoyang@rim.com>
6962
6963         Update my email address.
6964
6965         Not reviewed.
6966
6967         * Scripts/webkitpy/common/config/committers.py:
6968
6969 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
6970
6971         [NRWT] Add support for recognizing arbitrary process names in crash lines
6972         https://bugs.webkit.org/show_bug.cgi?id=95435
6973
6974         Reviewed by Adam Barth.
6975
6976         When running layout tests in the chromium port using the content shell,
6977         we want to be able to report sub-process crashes as well.
6978
6979         * Scripts/webkitpy/layout_tests/port/driver.py:
6980         (Driver._check_for_driver_crash):
6981         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
6982         (DriverTest.test_check_for_driver_crash):
6983
6984 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
6985
6986         Random test-webkitpy failures on the buildbot
6987         https://bugs.webkit.org/show_bug.cgi?id=95096
6988
6989         Reviewed by Dirk Pranke.
6990
6991         Suppress occasional errors when running test-webkitpy on GTK builders
6992         by running these tests serially. The 64-bit Release builder is especially
6993         prone to these as it can run up to 24 tests in parallel.
6994
6995         Despite the tests not being run in parallel, the testing only lasts a handful
6996         of seconds more, so this is a worthy trade-off to avoid unnecessary
6997         false-alarm redness on the GTK builders.
6998
6999         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
7000         (RunPythonTests.start):
7001
7002 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
7003
7004         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
7005         https://bugs.webkit.org/show_bug.cgi?id=95380
7006
7007         Reviewed by Michael Saboff.
7008
7009         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
7010         Add very basic tests for String::ascii(). This covers the case of null strings that caused
7011         the crash.
7012
7013 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
7014
7015         AX: Canvas should have a distinct role
7016         https://bugs.webkit.org/show_bug.cgi?id=95248
7017
7018         Reviewed by Chris Fleizach.
7019
7020         Add support for canvas accessibility role.
7021
7022         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
7023         (roleToString):
7024
7025 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
7026
7027         [Gtk] Process Gtk 3.4 smooth scroll events properly
7028         https://bugs.webkit.org/show_bug.cgi?id=88070
7029
7030         Added continousMouseScrollBy support in WebKitTestRunner, and added
7031         implementation for gtk, and stub for Qt, mac and EFL.
7032
7033         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
7034         scroll for emulating multi-tick mouseScrollBy events.
7035
7036         Reviewed by Martin Robinson.
7037
7038         * DumpRenderTree/gtk/EventSender.cpp:
7039         (mouseScrollByCallback):
7040         (continuousMouseScrollByCallback):
7041         * WebKitTestRunner/EventSenderProxy.h:
7042         (EventSenderProxy):
7043         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
7044         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
7045         (WTR::EventSendingController::mouseScrollBy):
7046         (WTR):
7047         (WTR::EventSendingController::continuousMouseScrollBy):
7048         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
7049         (EventSendingController):
7050         * WebKitTestRunner/TestController.cpp:
7051         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
7052         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
7053         (WTR):
7054         (WTR::EventSenderProxy::mouseScrollBy):
7055         (WTR::EventSenderProxy::continuousMouseScrollBy):
7056         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
7057         (WTR):
7058         (WTR::EventSenderProxy::continuousMouseScrollBy):
7059         * WebKitTestRunner/mac/EventSenderProxy.mm:
7060         (WTR::EventSenderProxy::continuousScrollBy):
7061         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
7062         (WTR::EventSenderProxy::continuousMouseScrollBy):
7063         (WTR):
7064
7065 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
7066
7067         [chromium] Support high DIP pixel tests with DumpRenderTree
7068         https://bugs.webkit.org/show_bug.cgi?id=94935
7069
7070         Reviewed by James Robinson.
7071
7072         Adding device scale factor into the drt image dumping code
7073
7074         * DumpRenderTree/chromium/DRTTestRunner.cpp:
7075         (DRTTestRunner::reset):
7076         (DRTTestRunner::setBackingScaleFactor):
7077         * DumpRenderTree/chromium/WebViewHost.cpp:
7078         (WebViewHost::setDeviceScaleFactor):
7079         (WebViewHost::paintInvalidatedRegion):
7080         (WebViewHost::canvas):
7081         * DumpRenderTree/chromium/WebViewHost.h:
7082         (WebViewHost):
7083
7084 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
7085
7086         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
7087         https://bugs.webkit.org/show_bug.cgi?id=95177
7088
7089         Reviewed by Dirk Pranke.
7090
7091         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
7092
7093         * Scripts/webkitpy/common/checkout/scm/git.py:
7094
7095 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
7096
7097         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
7098         https://bugs.webkit.org/show_bug.cgi?id=95222
7099
7100         Reviewed by Adam Barth.
7101
7102         The code we had to remove REBASELINE lines from the
7103         TestExpectations files did not handle multiple files (in a
7104         cascade) correctly; we weren't limiting lines to a particular
7105         file correctly in without_rebaseline_modifier(). This patch
7106         fixes that and corrects the tests (which weren't correct and
7107         didn't cover things very well).
7108
7109         Note also that the webkit-patch rebaseline-commands are still
7110         using the include_overrides=False option in a couple places;
7111         this is never correct or needed at this point. This patch fixes
7112         the usage for webkit-patch rebaseline-expectations, but I still
7113         need to fix rebaseline-test-internal, which I will do in a
7114         separate patch (see bug 95268).
7115
7116         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
7117         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
7118         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
7119         (RebaseliningTest.assertRemove):
7120         (RebaseliningTest.test_remove):
7121         * Scripts/webkitpy/tool/commands/rebaseline.py:
7122         (RebaselineExpectations._update_expectations_files):
7123
7124 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
7125
7126         webkit-patch rebaseline-expectations hangs
7127         https://bugs.webkit.org/show_bug.cgi?id=95243
7128
7129         Reviewed by Tony Chang.
7130
7131         Don't try to run no commands in parallel; report an error
7132         instead that we didn't find any tests to rebaseline.
7133
7134         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
7135
7136         * Scripts/webkitpy/tool/commands/rebaseline.py:
7137         (RebaselineExpectations.execute):
7138         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
7139         (_assert_command):
7140         (test_rebaseline_expectations_noop):
7141
7142 2012-08-29  Brady Eidson  <beidson@apple.com>
7143
7144         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
7145         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
7146
7147         Reviewed by Sam Weinig.
7148
7149         Add a test plug-in that calls back into the page with info on the NPWindow passed
7150         in to NPP_SetWindow.
7151
7152         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
7153         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
7154         (LogNPPSetWindow):
7155         (LogNPPSetWindow::LogNPPSetWindow):
7156         (LogNPPSetWindow::NPP_SetWindow):
7157
7158 2012-08-29  Jon Lee  <jonlee@apple.com>
7159
7160         [Mac] Basic DRT support for web notifications
7161         https://bugs.webkit.org/show_bug.cgi?id=79492
7162         <rdar://problem/10357639>
7163
7164         Reviewed by Alexey Proskuryakov.
7165
7166         This patch implements the stubs for web notification support on DRT. Assume that when
7167         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
7168         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
7169
7170         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
7171         * DumpRenderTree/mac/DumpRenderTree.mm:
7172         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
7173         web view.
7174         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
7175
7176         * DumpRenderTree/mac/TestRunnerMac.mm:
7177         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
7178         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
7179         (TestRunner::removeAllWebNotificationPermissions):
7180         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
7181         simulate the click. This is similar to how WTR performs the click.
7182         * DumpRenderTree/mac/UIDelegate.mm:
7183         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
7184         user allows web notifications.
7185
7186         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
7187         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
7188         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
7189         (+[MockWebNotificationProvider shared]): The provider is a singleton.
7190         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
7191         (-[MockWebNotificationProvider registerWebView:]):
7192         (-[MockWebNotificationProvider unregisterWebView:]):
7193         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
7194         notification did show.
7195         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
7196         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
7197         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
7198         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
7199         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
7200         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
7201         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
7202         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
7203         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
7204         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
7205         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
7206
7207 2012-08-29  Rob Buis  <rbuis@rim.com>
7208
7209         [BlackBerry] Adjust wtf include header style
7210         https://bugs.webkit.org/show_bug.cgi?id=95368
7211
7212         Reviewed by Yong Li.
7213
7214         Switch to #include <wtf/...> like the other ports.
7215
7216         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
7217         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
7218         * DumpRenderTree/blackberry/PNGImageEncoder.h:
7219         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
7220         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
7221         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
7222
7223 2012-08-29  Roger Fong  <roger_fong@apple.com>
7224
7225         Update cygwin-downloader.zip to match modified downloader script.
7226         https://bugs.webkit.org/show_bug.cgi?id=76936
7227
7228         Rubber Stamped by Jon Honeycutt.
7229
7230         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
7231         Updating zip to reflect changes.
7232
7233         * CygwinDownloader/cygwin-downloader.zip:
7234
7235 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
7236
7237         Stylechecker warns about comparison to zero when comparing to 0.5
7238         https://bugs.webkit.org/show_bug.cgi?id=94913
7239
7240         Reviewed by Dirk Pranke.
7241
7242         According to the python documentation, \W is the character group with all
7243         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
7244         to [^\w]. We need to exclude the dot "." as well, so that floating point
7245         values do not trigger this warning. Adding a unit test that shows the problem.
7246
7247         * Scripts/webkitpy/style/checkers/cpp.py:
7248         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
7249         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
7250         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
7251
7252 2012-08-29  Jon Lee  <jonlee@apple.com>
7253
7254         WTR build fixes.
7255
7256         * WebKitTestRunner/CMakeLists.txt:
7257         * WebKitTestRunner/GNUmakefile.am:
7258         * WebKitTestRunner/Target.pri:
7259         * WebKitTestRunner/WebNotificationProvider.cpp:
7260         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
7261         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
7262
7263 2012-08-29  Jon Lee  <jonlee@apple.com>
7264
7265         [WK2] Basic WTR support for web notifications
7266         https://bugs.webkit.org/show_bug.cgi?id=95154
7267         <rdar://problem/12184492>
7268
7269         Reviewed by Alexey Proskuryakov.
7270
7271         Implement WTR support, without platform event output (bug 95233).
7272
7273         Legacy APIs will not be supported, since many of the tests are skipped
7274         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
7275         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
7276         the tests to http/tests/notifications.
7277
7278         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
7279         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
7280         be invoked from the UIProcess.
7281
7282         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
7283         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
7284         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
7285         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
7286         notification's internal ID.
7287         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
7288         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
7289         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
7290         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
7291         (WTR::TestRunner::removeAllWebNotificationPermissions):
7292         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
7293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
7294
7295         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
7296         class.
7297         * WebKitTestRunner/TestInvocation.cpp:
7298         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
7299         TestInvocation forwards that request to the TestController.
7300         * WebKitTestRunner/TestController.cpp:
7301         (WTR::TestController::initialize): Set the provider.
7302         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
7303         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
7304         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
7305
7306         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
7307         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
7308         * WebKitTestRunner/WebNotificationProvider.h: Added.
7309         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
7310         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
7311         the notification got shown.
7312         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
7313         got closed.
7314         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
7315         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
7316         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
7317         permissions. For testing purposes, we always want this set to be empty.
7318         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
7319         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
7320
7321         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
7322
7323 2012-08-29  Kamil Blank  <k.blank@samsung.com>
7324
7325         [EFL] Add setting API for allow universal/file access from file URLs.
7326         https://bugs.webkit.org/show_bug.cgi?id=83121
7327
7328         Reviewed by Eric Seidel.
7329
7330         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
7331
7332         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
7333         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
7334         * DumpRenderTree/efl/TestRunnerEfl.cpp:
7335         (TestRunner::setAllowUniversalAccessFromFileURLs):
7336         (TestRunner::setAllowFileAccessFromFileURLs):
7337
7338 2012-08-29  Jon Lee  <jonlee@apple.com>
7339
7340         Update TestRunner API for web notifications
7341         https://bugs.webkit.org/show_bug.cgi?id=95093
7342         <rdar://problem/12179649>
7343
7344         Reviewed by Alexey Proskuryakov.
7345
7346         As it turns out the patch for this accidentally got squashed into the commit for
7347         bug 95099 (r126909). This amendment patch adds some comments about the renaming
7348         of the older TestRunner API for web notifications.
7349
7350         * DumpRenderTree/TestRunner.h:
7351         (TestRunner):
7352
7353 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
7354
7355         Unreviewed, rolling out r126972.
7356         http://trac.webkit.org/changeset/126972
7357         https://bugs.webkit.org/show_bug.cgi?id=95349
7358
7359         accessibility/canvas-description-and-role.html has been
7360         failing consistently on several bots and Dominic needs some
7361         time to investigate why (Requested by jchaffraix on #webkit).
7362
7363         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
7364         (roleToString):
7365
7366 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
7367
7368         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
7369         https://bugs.webkit.org/show_bug.cgi?id=84707
7370
7371         Reviewed by Gustavo Noronha Silva.
7372
7373         Most of the warnings have been fixed now that FindCairo.cmake and
7374         FindGLIB.cmake have been rewritten. The remaining one, related to
7375         FindFontconfig.cmake, shows up when building on a 64-bit
7376         Debian-based systems.
7377
7378         jhbuild installs libraries into lib64/ by default on 64-bit Linux
7379         installations, while CMake does not look for libraries in lib64/
7380         when /etc/debian_version exists on the system. The FIND_LIBRARY()
7381         would then sometimes end up using the system installation instead of
7382         the jhbuild one, causing mismatches and, when pkg-config is not used
7383         at all, failing to find libraries altogether.
7384
7385         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
7386         when use_lib64 is set to force CMake to look into lib64/ regardless
7387         of the presence of /etc/debian_version.
7388
7389 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
7390
7391         The 2d.imageData.object.round canvas test is failing
7392         https://bugs.webkit.org/show_bug.cgi?id=40272
7393
7394         Reviewed by Benjamin Poulain.
7395
7396         Updating patch to address Benjamin's review comments.
7397         Adding a WTF test to test lrint implementation.
7398
7399         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
7400         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
7401         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
7402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
7403         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
7404         (TestWebKitAPI):
7405         (TestWebKitAPI::TEST):
7406         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
7407
7408 2012-08-29  Florin Malita  <fmalita@chromium.org>
7409
7410         Unreviewed, updating Kelly Norton's email address at his request.
7411
7412         * Scripts/webkitpy/common/config/committers.py:
7413
7414 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
7415
7416         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
7417         https://bugs.webkit.org/show_bug.cgi?id=93723
7418
7419         Reviewed by Dirk Pranke.
7420
7421         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
7422         (TestExpectationParser.expectation_for_skipped_test):
7423         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
7424         (SkippedTests.test_skipped_entry_dont_exist):
7425
7426 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
7427
7428         Unreviewed, rolling out r120113.
7429         http://trac.webkit.org/changeset/120113
7430         https://bugs.webkit.org/show_bug.cgi?id=95320
7431
7432         Wrong fix for the problem, experimentally rolling it out for
7433         bug 95237. (Requested by rakuco on #webkit).
7434
7435         * efl/jhbuildrc:
7436
7437 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
7438
7439         AX: Canvas should have a distinct role
7440         https://bugs.webkit.org/show_bug.cgi?id=95248
7441
7442         Reviewed by Chris Fleizach.
7443
7444         Add support for canvas accessibility role.
7445
7446         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
7447         (roleToString):
7448
7449 2012-08-28  Eric Seidel  <eric@webkit.org>
7450
7451         cr-ews bot doesn't set CWD correctly when zipping layout test results
7452         https://bugs.webkit.org/show_bug.cgi?id=91265
7453
7454         Reviewed by Kenneth Russell.
7455
7456         This should make the zips slightly less cumbersome to deal with.
7457
7458         * Scripts/webkitpy/common/system/workspace.py:
7459         (Workspace.create_zip):
7460         * Scripts/webkitpy/common/system/workspace_unittest.py:
7461         (WorkspaceTest.test_create_zip):
7462         (WorkspaceTest.test_create_zip_exception):
7463
7464 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
7465
7466         Fix the Commiters script
7467
7468         Unreviewed.
7469
7470         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
7471
7472         * Scripts/webkitpy/common/config/committers.py:
7473
7474 2012-08-28  Roger Fong  <roger_fong@apple.com>
7475
7476         Unreviewed. Adding myself to committers list.
7477
7478         * Scripts/webkitpy/common/config/committers.py:
7479
7480 2012-08-28  Roger Fong  <roger_fong@apple.com>
7481
7482         Add minires to list of required cygwin install packages.
7483         https://bugs.webkit.org/show_bug.cgi?id=76936
7484
7485         Reviewed by Tim Horton.
7486
7487         * CygwinDownloader/cygwin-downloader.py:
7488
7489 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
7490
7491         [Chromium-Android] Upstream layout test expectations (Part 2)
7492         https://bugs.webkit.org/show_bug.cgi?id=95212
7493
7494         Reviewed by Adam Barth.
7495
7496         - Now run both gpu path and non-gpu path of 2d canvas layout tests
7497         because both are used in chromium-android.
7498
7499         - Exclude all webgl tests because webgl is not enabled yet.
7500
7501         - Removed 'win' from the baseline fallback list. This was a mistake.
7502
7503         - Moved some small directories to TestExpectations from skipped_layout_tests().
7504
7505         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
7506         (ChromiumAndroidPort):
7507         (ChromiumAndroidPort.skipped_layout_tests):
7508
7509 2012-08-28  Joanmarie Diggs  <jdiggs@igalia.com>
7510
7511         Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
7512         https://bugs.webkit.org/show_bug.cgi?id=95185
7513
7514         Reviewed by Chris Fleizach.
7515
7516         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
7517         (AccessibilityUIElement::titleUIElement): Implemented
7518         Gets the ATK_RELATION_LABELLED_BY target.
7519         (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
7520         Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
7521         bug 95180 is fixed.
7522
7523 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
7524
7525         AX: Crash due to object getting deleted inside updateBackingStore
7526         https://bugs.webkit.org/show_bug.cgi?id=94619
7527
7528         Reviewed by Chris Fleizach.
7529
7530         Change isValid to !isDetached after deleting isValid from
7531         chromium WebAccessibilityObject as being redundant.
7532
7533         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
7534         (AccessibilityUIElement::isValidGetterCallback):
7535
7536 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
7537
7538         Unreviewed, rolling out r126914.
7539         http://trac.webkit.org/changeset/126914
7540         https://bugs.webkit.org/show_bug.cgi?id=95239
7541
7542         it breaks everything and fixes nothing (Requested by pizlo on
7543         #webkit).
7544
7545         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
7546         (MockWebSpeechInputController::addMockRecognitionResult):
7547         * DumpRenderTree/chromium/NotificationPresenter.cpp:
7548         (NotificationPresenter::simulateClick):
7549         (NotificationPresenter::show):
7550         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
7551         (CppBoundClass::~CppBoundClass):
7552         (CppBoundClass::invoke):
7553         (CppBoundClass::getProperty):
7554         (CppBoundClass::setProperty):
7555         (CppBoundClass::bindCallback):
7556         (CppBoundClass::bindProperty):
7557         * DumpRenderTree/chromium/WebPreferences.cpp:
7558         (applyFontMap):
7559         * DumpRenderTree/chromium/WebViewHost.cpp:
7560         (WebViewHost::printResourceDescription):
7561         * DumpRenderTree/mac/TestRunnerMac.mm:
7562         (worldIDForWorld):
7563         (TestRunner::evaluateScriptInIsolatedWorld):
7564         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
7565         (AccessibilityController::~AccessibilityController):
7566         (AccessibilityController::winNotificationReceived):
7567         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
7568         (ResourceLoadDelegate::descriptionSuitableForTestResult):
7569         * DumpRenderTree/win/TestRunnerWin.cpp:
7570         (worldIDForWorld):
7571         (TestRunner::evaluateScriptInIsolatedWorld):
7572         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
7573         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
7574         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
7575         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
7576         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
7577         (WTR::TestRunner::worldIDForWorld):
7578         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
7579
7580 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
7581
7582         Rename first/second to key/value in HashMap iterators
7583         https://bugs.webkit.org/show_bug.cgi?id=82784
7584
7585         Reviewed by Eric Seidel.
7586
7587         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
7588         (MockWebSpeechInputController::addMockRecognitionResult):
7589         * DumpRenderTree/chromium/NotificationPresenter.cpp:
7590         (NotificationPresenter::simulateClick):
7591         (NotificationPresenter::show):
7592         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
7593         (CppBoundClass::~CppBoundClass):
7594         (CppBoundClass::invoke):
7595         (CppBoundClass::getProperty):
7596         (CppBoundClass::setProperty):
7597         (CppBoundClass::bindCallback):
7598         (CppBoundClass::bindProperty):
7599         * DumpRenderTree/chromium/WebPreferences.cpp:
7600         (applyFontMap):
7601         * DumpRenderTree/chromium/WebViewHost.cpp:
7602         (WebViewHost::printResourceDescription):
7603         * DumpRenderTree/mac/TestRunnerMac.mm:
7604         (worldIDForWorld):
7605         (TestRunner::evaluateScriptInIsolatedWorld):
7606         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
7607         (AccessibilityController::~AccessibilityController):
7608         (AccessibilityController::winNotificationReceived):
7609         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
7610         (ResourceLoadDelegate::descriptionSuitableForTestResult):
7611         * DumpRenderTree/win/TestRunnerWin.cpp:
7612         (worldIDForWorld):
7613         (TestRunner::evaluateScriptInIsolatedWorld):
7614         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
7615         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
7616         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
7617         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
7618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
7619         (WTR::TestRunner::worldIDForWorld):
7620         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
7621
7622 2012-08-27  Jon Lee  <jonlee@apple.com>
7623
7624         Update TestRunner API for web notifications
7625         https://bugs.webkit.org/show_bug.cgi?id=95093
7626         <rdar://problem/12179649>
7627
7628         Reviewed by Jessie Berlin.
7629
7630         This is work toward providing Mac support for web notifications in DRT and WTR (77969).
7631
7632         Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
7633         This first patch renames the TestRunner calls to use the term "web notifications" instead of
7634         "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
7635         additional calls that will be used in the tests that test the standard API.
7636
7637         * DumpRenderTree/TestRunner.h:
7638         (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
7639         and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
7640         * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
7641         (TestRunner::TestRunner):
7642         (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
7643         (simulateLegacyWebNotificationClickCallback): Renamed.
7644         (grantWebNotificationPermissionCallback): Renamed.
7645         (denyWebNotificationPermissionCallback): Added.
7646         (removeAllWebNotificationPermissionsCallback): Added.
7647         (simulateWebNotificationClickCallback): Added.
7648         (TestRunner::staticFunctions):
7649         (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
7650
7651         * DumpRenderTree/chromium/DRTTestRunner.cpp:
7652         (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
7653         (DRTTestRunner::grantWebNotificationPermission):
7654         (DRTTestRunner::denyWebNotificationPermission): Stub.
7655         (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
7656         (DRTTestRunner::simulateWebNotificationClick): Stub.
7657         (DRTTestRunner::simulateLegacyWebNotificationClick):
7658         * DumpRenderTree/chromium/DRTTestRunner.h:
7659         (DRTTestRunner):
7660
7661         Added stubs.
7662         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
7663         * DumpRenderTree/efl/TestRunnerEfl.cpp:
7664         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
7665         * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
7666         * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
7667         * DumpRenderTree/win/TestRunnerWin.cpp:
7668
7669 2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
7670
7671         [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
7672         https://bugs.webkit.org/show_bug.cgi?id=94700
7673
7674         Reviewed by Eric Seidel.
7675
7676         Interrupting download with a timeout would be a possible solution.
7677         I imported the socket module and used the setdefaulttimeout() method.
7678         Fixing it is important, because EWS bots need to be restarted regularly
7679         because of this bug.
7680
7681         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
7682         (Bugzilla._get_browser):
7683         (Bugzilla.setdefaulttimeout):
7684
7685 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
7686
7687         [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
7688         https://bugs.webkit.org/show_bug.cgi?id=95194
7689
7690         Reviewed by Simon Hausmann.
7691
7692         * Scripts/webkitpy/layout_tests/port/qt.py:
7693         (QtPort.setup_environ_for_server):
7694
7695 2012-08-28  Andras Becsi  <andras.becsi@nokia.com>
7696
7697         [watchlist] Unreviewed, subscribe to Qt bugs.
7698
7699         * Scripts/webkitpy/common/config/watchlist:
7700
7701 2012-08-28  Simon Hausmann  <simon.hausmann@nokia.com>
7702
7703         [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
7704         https://bugs.webkit.org/show_bug.cgi?id=95054
7705
7706         Reviewed by Eric Seidel.
7707
7708         Enable CSS_IMAGE_SET for the Qt build.
7709
7710         * qmake/mkspecs/features/features.pri:
7711
7712 2012-08-27  Csaba Osztrogonác  <ossy@webkit.org>
7713
7714         [Qt] Enable CSS sticky position
7715         https://bugs.webkit.org/show_bug.cgi?id=95172
7716
7717         Reviewed by Simon Hausmann.
7718
7719         * qmake/mkspecs/features/features.pri:
7720
7721 2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
7722
7723         [GTK] Memory cache should be cleared in between test runs
7724         https://bugs.webkit.org/show_bug.cgi?id=95105
7725
7726         Reviewed by Martin Robinson.
7727
7728         Call the new DumpRenderTreeSupportGtk helper method after every test
7729         to clear the memory cache.
7730
7731         * DumpRenderTree/gtk/DumpRenderTree.cpp:
7732         (runTest):
7733
7734 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
7735
7736         Unreviewed, rolling out r126836.
7737         http://trac.webkit.org/changeset/126836
7738         https://bugs.webkit.org/show_bug.cgi?id=95163
7739
7740         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
7741         #webkit).
7742
7743         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
7744         (MockWebSpeechInputController::addMockRecognitionResult):
7745         * DumpRenderTree/chromium/NotificationPresenter.cpp:
7746         (NotificationPresenter::simulateClick):
7747         (NotificationPresenter::show):
7748         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
7749         (CppBoundClass::~CppBoundClass):
7750         (CppBoundClass::invoke):
7751         (CppBoundClass::getProperty):
7752         (CppBoundClass::setProperty):
7753         (CppBoundClass::bindCallback):
7754         (CppBoundClass::bindProperty):
7755         * DumpRenderTree/chromium/WebPreferences.cpp:
7756         (applyFontMap):
7757         * DumpRenderTree/chromium/WebViewHost.cpp:
7758         (WebViewHost::printResourceDescription):
7759         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
7760         (AccessibilityController::~AccessibilityController):
7761         (AccessibilityController::winNotificationReceived):
7762         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
7763         (ResourceLoadDelegate::descriptionSuitableForTestResult):
7764         * DumpRenderTree/win/TestRunnerWin.cpp:
7765         (worldIDForWorld):
7766         (TestRunner::evaluateScriptInIsolatedWorld):
7767         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
7768         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
7769         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
7770         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
7771         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
7772         (WTR::TestRunner::worldIDForWorld):
7773         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
7774
7775 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
7776
7777         Rename first/second to key/value in HashMap iterators
7778         https://bugs.webkit.org/show_bug.cgi?id=82784
7779
7780         Reviewed by Eric Seidel.
7781
7782         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
7783         (MockWebSpeechInputController::addMockRecognitionResult):
7784         * DumpRenderTree/chromium/NotificationPresenter.cpp:
7785         (NotificationPresenter::simulateClick):
7786         (NotificationPresenter::show):
7787         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
7788         (CppBoundClass::~CppBoundClass):
7789         (CppBoundClass::invoke):
7790         (CppBoundClass::getProperty):
7791         (CppBoundClass::setProperty):
7792         (CppBoundClass::bindCallback):
7793         (CppBoundClass::bindProperty):
7794         * DumpRenderTree/chromium/WebPreferences.cpp:
7795         (applyFontMap):
7796         * DumpRenderTree/chromium/WebViewHost.cpp:
7797         (WebViewHost::printResourceDescription):
7798         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
7799         (AccessibilityController::~AccessibilityController):
7800         (AccessibilityController::winNotificationReceived):
7801         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
7802         (ResourceLoadDelegate::descriptionSuitableForTestResult):
7803         * DumpRenderTree/win/TestRunnerWin.cpp:
7804         (worldIDForWorld):
7805         (TestRunner::evaluateScriptInIsolatedWorld):
7806         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
7807         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
7808         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
7809         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
7810         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
7811         (WTR::TestRunner::worldIDForWorld):
7812         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
7813
7814 2012-08-24  James Robinson  <jamesr@chromium.org>
7815
7816         WebGL should not flip textures on presentation if contents are unchanged
7817         https://bugs.webkit.org/show_bug.cgi?id=94961
7818
7819         Reviewed by Kenneth Russell.
7820
7821         Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.
7822
7823         * Scripts/webkitpy/layout_tests/port/chromium.py:
7824         (ChromiumPort.virtual_test_suites):
7825
7826 2012-08-27  Gavin Peters  <gavinp@chromium.org>
7827
7828         [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
7829         https://bugs.webkit.org/show_bug.cgi?id=95104
7830
7831         Reviewed by Adam Barth.
7832
7833         Today I found out this command was broken by the new iOS platform showing up on omahaproxy. Now the webkit-patch chrome-channels command gracefully handles new, previously unknown platforms. Also, it prints iOS in the proper mixed case.
7834
7835         * Scripts/webkitpy/common/net/omahaproxy.py:
7836         (OmahaProxy):
7837         (OmahaProxy.get_revisions):
7838         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
7839         (OmahaProxyTest):
7840         (OmahaProxyTest.test_get_revisions):
7841
7842 2012-08-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
7843
7844         [EFL][WK2] Free Url_Bar on program exit
7845         https://bugs.webkit.org/show_bug.cgi?id=95086
7846
7847         Reviewed by Eric Seidel.
7848
7849         Fix a memory leak by freeing the Url_Bar on program exit.
7850
7851         * MiniBrowser/efl/main.c:
7852         (main): Call url_bar_del() to free the Url_Bar.
7853
7854 2012-08-27  James Robinson  <jamesr@chromium.org>
7855
7856         [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
7857         https://bugs.webkit.org/show_bug.cgi?id=95115
7858
7859         Reviewed by Adam Barth.
7860
7861         Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
7862         code if the unit tests crash.
7863
7864         * Scripts/run-chromium-webkit-unit-tests:
7865
7866 2012-08-27  Benjamin Poulain  <benjamin@webkit.org>
7867
7868         Add ECMAScript Number to String conversion to WTF::String
7869         https://bugs.webkit.org/show_bug.cgi?id=95016
7870
7871         Reviewed by Geoffrey Garen.
7872
7873         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
7874         (TestWebKitAPI::testNumberToStringECMAScript):
7875         (TestWebKitAPI): Add tests for String's ECMAString number conversion.
7876
7877 2012-08-27  Philippe Normand  <pnormand@igalia.com>
7878
7879         [GStreamer][Qt] WebAudio support
7880         https://bugs.webkit.org/show_bug.cgi?id=94806
7881
7882         Reviewed by Simon Hausmann.
7883
7884         * MiniBrowser/qt/qml/BrowserWindow.qml: Enable WebAudio support.
7885
7886 2012-08-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
7887
7888         Rename RegisterProtocolHandler API to NavigatorContentUtils
7889         https://bugs.webkit.org/show_bug.cgi?id=94920
7890
7891         Reviewed by Adam Barth.
7892
7893         Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.
7894
7895         * Scripts/webkitperl/FeatureList.pm:
7896         * qmake/mkspecs/features/features.pri:
7897
7898 2012-08-24  Benjamin Poulain  <bpoulain@apple.com>
7899
7900         Unify Number to StringImpl conversion
7901         https://bugs.webkit.org/show_bug.cgi?id=94879
7902
7903         Reviewed by Geoffrey Garen.
7904
7905         Add testing for the new IntegerToStringConversion.
7906
7907         * TestWebKitAPI/CMakeLists.txt:
7908         * TestWebKitAPI/GNUmakefile.am:
7909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7910         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.
7911
7912 2012-08-23  James Robinson  <jamesr@chromium.org>
7913
7914         [chromium] Convert WebLayerTreeView interface into pure virtual
7915         https://bugs.webkit.org/show_bug.cgi?id=94866
7916
7917         Reviewed by Adrienne Walker.
7918
7919         Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
7920         tests.
7921
7922         * DumpRenderTree/DumpRenderTree.gypi:
7923         * DumpRenderTree/chromium/WebViewHost.cpp:
7924         (WebViewHost::createOutputSurface):
7925         * DumpRenderTree/chromium/WebViewHost.h:
7926         (WebViewHost):
7927         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
7928         (WebKit):
7929         (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
7930         (WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
7931         (WebKit::WebViewHostOutputSurface::bindToClient):
7932         (WebKit::WebViewHostOutputSurface::capabilities):
7933         (WebKit::WebViewHostOutputSurface::context3D):
7934         (WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):
7935         * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
7936         (WebKit):
7937         (WebViewHostOutputSurface):
7938
7939 2012-08-24  Xianzhu Wang  <wangxianzhu@chromium.org>
7940
7941         [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
7942         https://bugs.webkit.org/show_bug.cgi?id=94865
7943
7944         Reviewed by Dirk Pranke.
7945
7946         Android detects crash of test by checking if the return value of read() is None.
7947         Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
7948         If set, ServerProcess will set _crashed unconditionaly when there is no data.
7949
7950         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
7951         (ChromiumAndroidPort.__init__):
7952         (ChromiumAndroidPort):
7953         (ChromiumAndroidPort._android_server_process_constructor):
7954         (ChromiumAndroidDriver._start_once):
7955         * Scripts/webkitpy/layout_tests/port/server_process.py:
7956         (ServerProcess.__init__):
7957         (ServerProcess._wait_for_data_and_update_buffers_using_select):
7958
7959 2012-08-24  Arnaud Renevier  <a.renevier@sisa.samsung.com>
7960
7961         build-webkit --gtk fails with Can't exec ""
7962         https://bugs.webkit.org/show_bug.cgi?id=94944
7963
7964         Reviewed by Martin Robinson.
7965
7966         When jhbuild wrapper is not needed, do unshift a blank string to build
7967         arguments.
7968
7969         * Scripts/webkitdirs.pm:
7970         (runAutogenForAutotoolsProjectIfNecessary):
7971
7972 2012-08-24  Tommy Widenflycht  <tommyw@google.com>
7973
7974         MediaStream API: Add readyState functionality to RTCPeerConnection
7975         https://bugs.webkit.org/show_bug.cgi?id=94813
7976
7977         Reviewed by Adam Barth.
7978
7979         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
7980         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
7981         (MockWebRTCPeerConnectionHandler::stop):
7982         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
7983         (MockWebRTCPeerConnectionHandler):
7984
7985 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
7986
7987         Unreviewed. Adding myself to committers list.
7988
7989         Also updated email information.
7990
7991         * Scripts/webkitpy/common/config/committers.py:
7992
7993 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
7994
7995         [Qt][WK2] Make viewport related experimental.test properties encapsulated.
7996         https://bugs.webkit.org/show_bug.cgi?id=88320
7997
7998         Reviewed by Kenneth Rohde Christiansen.
7999
8000         Changed the access to the viewport attributes to use the viewport object that is introduced by this change.
8001
8002         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
8003
8004 2012-08-23  Dirk Pranke  <dpranke@chromium.org>
8005
8006         leak detection broken after r126247 on mac
8007         https://bugs.webkit.org/show_bug.cgi?id=94893
8008
8009         Unreviewed, build fix.
8010
8011         Adds is_snowleopard(), is_lion back() in for the mac port. We'll
8012         probably need an is_mountainlion() or equivalent at some point,
8013         I'm guessing (but I've deleted the leopard code).
8014
8015         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
8016         (LeakDetector._callstacks_to_exclude_from_leaks):
8017         * Scripts/webkitpy/layout_tests/port/mac.py:
8018         (MacPort):
8019         (MacPort.is_snowleopard):
8020         (MacPort.is_lion):
8021
8022 2012-08-23  Julien Chaffraix  <jchaffraix@webkit.org>
8023
8024         [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
8025         https://bugs.webkit.org/show_bug.cgi?id=94871
8026
8027         Reviewed by Benjamin Poulain.
8028
8029         * TestWebKitAPI/TestWebKitAPI.gypi:
8030         Added the missing files to Chromium's build system.
8031
8032 2012-08-23  Raphael Kubo da Costa  <rakuco@webkit.org>
8033
8034         [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
8035
8036         * Scripts/webkitpy/common/config/watchlist:
8037
8038 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
8039
8040         Replay tests take forever to load
8041         https://bugs.webkit.org/show_bug.cgi?id=94764
8042
8043         Reviewed by Adam Barth.
8044
8045         Don't load about:blank at the beginning. This appears to clog the DRT.
8046
8047         * Scripts/webkitpy/performance_tests/perftest.py:
8048         (ReplayPerfTest.run_single):
8049         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
8050         (TestReplayPerfTest.test_run_single):
8051         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
8052
8053 2012-08-23  Kenneth Russell  <kbr@google.com>
8054
8055         Unreviewed, rolling out r126497.
8056         http://trac.webkit.org/changeset/126497
8057         https://bugs.webkit.org/show_bug.cgi?id=94764
8058
8059         Caused webkitpy-test step to start failing.
8060
8061         * Scripts/webkitpy/performance_tests/perftest.py:
8062         (ReplayPerfTest.run_single):
8063
8064 2012-08-23  Emil A Eklund  <eae@chromium.org>
8065
8066         Add saturation arithmetic support to FractionalLayoutUnit
8067         https://bugs.webkit.org/show_bug.cgi?id=94364
8068
8069         Reviewed by Benjamin Poulain.
8070
8071         Add test for new saturatedArithmetic functions.
8072
8073         * TestWebKitAPI/CMakeLists.txt:
8074         * TestWebKitAPI/GNUmakefile.am:
8075         * TestWebKitAPI/TestWebKitAPI.gypi:
8076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8077         * TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.
8078         (TestWebKitAPI):
8079         (TestWebKitAPI::TEST):
8080         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
8081
8082 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
8083
8084         Replay tests take forever to load
8085         https://bugs.webkit.org/show_bug.cgi?id=94764
8086
8087         Reviewed by Adam Barth.
8088
8089         Don't load about:blank at the beginning. This appears to clog the DRT.
8090
8091         * Scripts/webkitpy/performance_tests/perftest.py:
8092         (ReplayPerfTest.run_single):
8093
8094 2012-08-23  Wei Jia  <wjia@chromium.org>
8095
8096         create different WebKit::WebMediaPlayer based on URL
8097         https://bugs.webkit.org/show_bug.cgi?id=91301
8098
8099         Reviewed by Adam Barth.
8100
8101         Pass URL to createMediaPlayer. This corresponds to change in base
8102         class WebKit::WebFrameClient.
8103
8104         * DumpRenderTree/chromium/WebViewHost.cpp:
8105         (WebViewHost::createMediaPlayer): add URL as additional argument.
8106         * DumpRenderTree/chromium/WebViewHost.h:
8107         (WebViewHost):
8108
8109 2012-08-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
8110
8111         Unreviewed, upgrade gyuyoung to reviewer.
8112         http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html
8113
8114         * Scripts/webkitpy/common/config/committers.py:
8115
8116 2012-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
8117
8118         REGRESSION(r126306): it broke the plugin process
8119         https://bugs.webkit.org/show_bug.cgi?id=94797
8120
8121         Reviewed by Xan Lopez.
8122
8123         * GNUmakefile.am:
8124
8125 2012-08-23  Ryuan Choi  <ryuan.choi@samsung.com>
8126
8127         [EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
8128         https://bugs.webkit.org/show_bug.cgi?id=63966
8129
8130         Reviewed by Kenneth Rohde Christiansen.
8131
8132         EWebLauncher and MiniBrowser/Efl did not have functionality that users
8133         navigates the site which they want.
8134         This patch adds the urlbar and functionality to load url which users want.
8135
8136         * CMakeLists.txt:
8137         Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.
8138         * EWebLauncher/CMakeLists.txt:
8139         Added urlbar.c and dependency of urlbar theme.
8140         In addition, changed macro name to THEME_DIR to share the code easily.
8141         * EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
8142         * EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
8143         * EWebLauncher/main.c:
8144         Implemented to use the urlbar.
8145         In addition, remove unnecessary border of webview to control webview and urlbar easily.
8146         (_ELauncher):
8147         (on_url_changed):
8148         (browserCreate):
8149         (closeWindow):
8150         (findThemePath):
8151         * EWebLauncher/url_bar.c: Implemented functionality of the urlbar.
8152         (_url_bar_url_get_with_protocol):
8153         (on_urlbar_key_down):
8154         (on_urlbar_mouse_down):
8155         (on_urlbar_focus_out):
8156         (url_bar_add):
8157         (url_bar_del):
8158         (url_bar_url_set):
8159         * EWebLauncher/url_bar.h: Added.
8160         * MiniBrowser/efl/CMakeLists.txt:
8161         * MiniBrowser/efl/main.c: Implemented to use the urlbar.
8162         (_MiniBrowser):
8163         (on_url_changed):
8164         (browserCreate):
8165
8166 2012-08-23  Balazs Kelemen  <kbalazs@webkit.org>
8167
8168         [nrwt, WTR] Remove workaround for timeout handing from r126062
8169         https://bugs.webkit.org/show_bug.cgi?id=94609
8170
8171         Reviewed by Dirk Pranke.
8172
8173         Don't try to reset state if a timeout occured but inform
8174         the harness that the web process is no longer reliable.
8175
8176         * Scripts/webkitpy/layout_tests/port/driver.py:
8177         (Driver.run_test): Remove the workaround. Furthermore, handle the case when
8178         the pid is unknown.
8179         * WebKitTestRunner/TestController.cpp:
8180         (WTR::TestController::run):
8181         * WebKitTestRunner/TestInvocation.cpp:
8182         (WTR::TestInvocation::invoke):
8183         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
8184         * WebKitTestRunner/TestInvocation.h:
8185         (TestInvocation):
8186
8187 2012-08-23  Ádám Kallai  <kadam@inf.u-szeged.hu>
8188
8189         Unreviewed. Adding myself to committers list.
8190
8191         * Scripts/webkitpy/common/config/committers.py:
8192
8193 2012-08-22  Alexis Menard  <alexis@webkit.org>
8194
8195         Unreviewed update of my email.
8196
8197         * Scripts/webkitpy/common/config/committers.py:
8198         * Scripts/webkitpy/common/config/watchlist:
8199
8200 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
8201
8202         Fix typos in r126374
8203         https://bugs.webkit.org/show_bug.cgi?id=94665
8204         Unreviewed, build fix.
8205
8206         Fix two issues that snuck in, one that caused a crash if there
8207         were no baselines to optimize and one that occurred as a result
8208         of failing to rename a variable when I changed the recursion to
8209         a loop in the previous patch.
8210
8211         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
8212         (BaselineOptimizer._optimize_by_pushing_results_up):
8213
8214 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
8215
8216         Baseline optimizer should try to optimize per-port if global optimization fails
8217         https://bugs.webkit.org/show_bug.cgi?id=94665
8218
8219         Reviewed by Adam Barth.
8220
8221         Add a fallback strategy for optimizing baselines if the default
8222         one fails; this one simply attempts to shift baselines up in the
8223         tree and consolidates them if a parent and child in the fallback
8224         path have the same result. This strategy is somewhat flawed in
8225         that we will always put something in a parent dir even if we
8226         "shouldn't"; for example, if chromium-mac produces a different
8227         result from chromium-win and chromium-linux, then the new
8228         algorithm will move the mac result into platform/chromium,
8229         leaving chromium-mac empty. This result is still correct, but
8230         perhaps confusing.
8231
8232         I haven't done much testing of this algorithm yet, so it's not
8233         clear how many cases where this does a better job than the
8234         default algorithm and how many it'll do a worse job.
8235
8236         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
8237         (BaselineOptimizer._find_optimal_result_placement):
8238         (BaselineOptimizer._optimize_by_most_specific_common_directory):
8239         (BaselineOptimizer):
8240         (BaselineOptimizer._optimize_by_pushing_results_up):
8241         (BaselineOptimizer._find_in_fallbackpath):
8242         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
8243         (BaselineOptimizerTest.test_platform_mac_different):
8244
8245 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
8246
8247         add debug info, another test to webkit-patch optimize-baselines
8248         https://bugs.webkit.org/show_bug.cgi?id=94762
8249
8250         Reviewed by Adam Barth.
8251
8252         This patch adds more debug logging for optimize-baselines so
8253         that you can tell the before and after states and figure out
8254         what the command is actually deciding to do.
8255
8256         Also, this command adds a (disabled) test for the problem in bug
8257         94665. It's disabled because we don't have the fix yet (that
8258         will be posted in a patch to that bug).
8259
8260         There should be no functional changes in this patch apart from
8261         the additional logging.
8262
8263         Note that adding the debug logging exposed a bug in
8264         filesystem_mock.relpath() (that would return None if the path
8265         wasn't a subpath of the start); the real relpath computes a
8266         relpath with parent dirs. Fixing this revealed a bad check in
8267         the style checker's change_directory() call which was checking
8268         for None.
8269
8270         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
8271         (BaselineOptimizer._find_optimal_result_placement):
8272         (BaselineOptimizer):
8273         (BaselineOptimizer._optimize_by_most_specific_common_directory):
8274         (BaselineOptimizer._move_baselines):
8275         (BaselineOptimizer.optimize):
8276         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
8277         (BaselineOptimizerTest.disabled_test_platform_mac_different):
8278         * Scripts/webkitpy/common/system/filesystem.py:
8279         (FileSystem):
8280         * Scripts/webkitpy/common/system/filesystem_mock.py:
8281         (MockFileSystem):
8282         (MockFileSystem.__init__):
8283         (MockFileSystem.relpath):
8284         * Scripts/webkitpy/common/system/filesystem_unittest.py:
8285         (RealFileSystemTest.test_sep):
8286         * Scripts/webkitpy/style/main.py:
8287         (change_directory):
8288
8289 2012-08-22  Alejandro Piñeiro  <apinheiro@igalia.com>
8290
8291         Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
8292         https://bugs.webkit.org/show_bug.cgi?id=73819
8293
8294         Reviewed by Chris Fleizach.
8295
8296         Added a new role, Toggle Button, based on whether aria-pressed is present.
8297         http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
8298
8299         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
8300         (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
8301
8302 2012-08-23  Victor Carbune  <victor@rosedu.org>
8303
8304         Add myself to the committer list
8305         https://bugs.webkit.org/show_bug.cgi?id=94659
8306
8307         Reviewed by James Robinson.
8308
8309         Added my email and IRC handle.
8310
8311         * Scripts/webkitpy/common/config/committers.py:
8312
8313 2012-08-22  Scott Graham  <scottmg@chromium.org>
8314
8315         Don't unconditionally define NOMINMAX on Windows
8316         https://bugs.webkit.org/show_bug.cgi?id=94742
8317
8318         Reviewed by Adrienne Walker.
8319
8320         Avoids a warning when building on Windows when NOMINMAX is defined
8321         elsewhere or on the command line.
8322
8323         * TestWebKitAPI/config.h:
8324
8325 2012-08-22  Zan Dobersek  <zandobersek@gmail.com>
8326
8327         REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
8328         https://bugs.webkit.org/show_bug.cgi?id=94704
8329
8330         Reviewed by Dirk Pranke.
8331
8332         Use tolerance=0 when acquiring diff image of reftest output.
8333
8334         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
8335         (SingleTestRunner._compare_output_with_reference):
8336
8337 2012-08-22  Tommy Widenflycht  <tommyw@google.com>
8338
8339         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
8340         https://bugs.webkit.org/show_bug.cgi?id=93091
8341
8342         Reviewed by Adam Barth.
8343
8344         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
8345         to complete the infrastructure for RTCPeerConnection.
8346
8347         * DumpRenderTree/DumpRenderTree.gypi:
8348         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
8349         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
8350         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
8351         (MockWebKitPlatformSupport):
8352         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
8353         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
8354         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
8355         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
8356         (MockWebRTCPeerConnectionHandler::initialize):
8357         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
8358         (WebKit):
8359         (MockWebRTCPeerConnectionHandler):
8360         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
8361
8362 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
8363
8364         Merge TestExpectationSerializer into TestExpectationLine
8365         https://bugs.webkit.org/show_bug.cgi?id=94638
8366
8367         Reviewed by Dimitri Glazkov.
8368
8369         Moved all methods except, list_to_string which was moved to TestExpectations
8370         from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.
8371
8372         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
8373         (TestExpectationEditorTests.assert_remove_roundtrip):
8374         (TestExpectationEditorTests.assert_update_roundtrip):
8375         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
8376         (ParseError.__repr__):
8377         (TestExpectationLine):
8378         (TestExpectationLine.create_passing_expectation):
8379         (TestExpectationLine.to_string): Moved from TestExpectationSerializer.
8380         (TestExpectationLine.to_csv): Ditto.
8381         (TestExpectationLine._serialize_parsed_expectations): Ditto.
8382         (TestExpectationLine._serialize_parsed_modifiers): Ditto.
8383         (TestExpectationLine._format_line):
8384         (TestExpectations.remove_configuration_from_test):
8385         (TestExpectations.remove_rebaselined_tests):
8386         (TestExpectations.add_skipped_tests):
8387         (TestExpectations):
8388         (TestExpectations.list_to_string): Moved from TestExpectationSerializer.
8389         (TestExpectations.list_to_string.serialize):
8390         (TestExpectations.list_to_string.nones_out):
8391         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
8392         (TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
8393         (TestExpectationSerializationTests.__init__):
8394         (TestExpectationSerializationTests.assert_round_trip):
8395         (TestExpectationSerializationTests.assert_list_round_trip):
8396         (TestExpectationSerializationTests.test_unparsed_to_string):
8397         (TestExpectationSerializationTests.test_unparsed_list_to_string):
8398         (TestExpectationSerializationTests.test_parsed_to_string):
8399         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
8400         (TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
8401         (TestExpectationSerializationTests.test_format_line):
8402         (TestExpectationSerializationTests.test_reconstitute_only_these):
8403         * Scripts/webkitpy/tool/commands/expectations.py:
8404         (OptimizeExpectations.execute):
8405         * Scripts/webkitpy/tool/commands/queries.py:
8406         (PrintExpectations.execute):
8407         (PrintExpectations._format_lines):
8408         * Scripts/webkitpy/tool/servers/gardeningserver.py:
8409         (GardeningExpectationsUpdater.update_expectations):
8410
8411 2012-08-22  Alexandre Elias  <aelias@chromium.org>
8412
8413         Unreviewed, add aelias@chromium.org to committers
8414
8415         I (aelias@chromium.org) have been approved for commit access and Apple
8416         has confirmed receipt of my committer agreement.
8417
8418         * Scripts/webkitpy/common/config/committers.py:
8419
8420 2012-08-22  Alexey Proskuryakov  <ap@apple.com>
8421
8422         [WK2] Support posting injected bundle messages to a page
8423         https://bugs.webkit.org/show_bug.cgi?id=94630
8424
8425         Reviewed by Sam Weinig.
8426
8427         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
8428         * TestWebKitAPI/InjectedBundleController.cpp:
8429         (TestWebKitAPI::InjectedBundleController::initialize):
8430         (TestWebKitAPI::InjectedBundleController::didReceiveMessageToPage):
8431         * TestWebKitAPI/InjectedBundleController.h:
8432         * TestWebKitAPI/InjectedBundleTest.h:
8433         (TestWebKitAPI::InjectedBundleTest::didReceiveMessageToPage):
8434         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
8435         (WTR::InjectedBundle::didReceiveMessage):
8436         (WTR::InjectedBundle::didReceiveMessageToPage):
8437         (WTR::InjectedBundle::initialize):
8438         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
8439         Updated for new client API call.
8440
8441 2012-08-22  Dominic Mazzoni  <dmazzoni@google.com>
8442
8443         REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
8444         https://bugs.webkit.org/show_bug.cgi?id=94200
8445
8446         Reviewed by Chris Fleizach.
8447
8448         Adds reference counting for AtkObjects referenced by
8449         AccessibilityUIElementGtk. This prevents bogus results and
8450         assertion failures on AccessibilityUIElements whose underlying
8451         object has been deleted (as opposed to just made defunct).
8452
8453         This fixes two tests that were previously failing because of this bug.
8454
8455         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
8456         (AccessibilityUIElement::AccessibilityUIElement):
8457         (AccessibilityUIElement::~AccessibilityUIElement):
8458
8459 2012-08-22  Gustavo Noronha Silva  <gns@gnome.org>
8460
8461         [GTK] Split WebCore/platform into a separate library
8462         https://bugs.webkit.org/show_bug.cgi?id=94435
8463
8464         Reviewed by Martin Robinson.
8465
8466         More people have been reporting problems when linking WebCore because
8467         the command line limit is being exceeded. Splitting WebCore a bit more
8468         is in order.
8469
8470         * GNUmakefile.am: link libWebCorePlatform into DRT
8471
8472 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
8473
8474         Unreviewed buildfix for Qt-minimal after r126291
8475
8476         Disable smooth scrolling when request-animation-frame has been disabled either
8477         explicitly or as part of --minimal.
8478
8479         * qmake/mkspecs/features/features.prf:
8480
8481 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
8482
8483         [Qt] Optionally support smooth-scrolling on all platforms
8484         https://bugs.webkit.org/show_bug.cgi?id=74926
8485
8486         Reviewed by Simon Hausmann.
8487
8488         Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
8489         setting in QtTestBrowser so it can be tested.
8490
8491         * QtTestBrowser/launcherwindow.cpp:
8492         (LauncherWindow::createChrome):
8493         (LauncherWindow::toggleScrollAnimator):
8494         * QtTestBrowser/launcherwindow.h:
8495         (WindowOptions::WindowOptions):
8496         (WindowOptions):
8497         (LauncherWindow):
8498         * qmake/mkspecs/features/features.pri:
8499
8500 2012-08-22  Dominik Röttsches  <dominik.rottsches@intel.com>
8501
8502         Unreviewed, adding myself to committers.py.
8503
8504         * Scripts/webkitpy/common/config/committers.py:
8505
8506 2012-08-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
8507
8508         [GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
8509         https://bugs.webkit.org/show_bug.cgi?id=94669
8510
8511         Reviewed by Carlos Garcia Campos.
8512
8513         Fix memory leaks in DRT's EventSender code.
8514
8515         * DumpRenderTree/gtk/EventSender.cpp:
8516         (getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
8517         (contextClickCallback): Use GOwnPtr to manage memory of a
8518         newly-allocated list automatically.
8519
8520 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
8521
8522         Add mountain lion to perf-tests, layout tests
8523         https://bugs.webkit.org/show_bug.cgi?id=94553
8524
8525         Reviewed by Adam Barth.
8526
8527         This patch adds support for the 'mac-mountainlion' platform and
8528         stamps out the last references to 'mac-leopard' as a supported
8529         name.
8530         
8531         This patch does a small amount of refactoring to try and make
8532         things a little clearer how we treat the "most recent version"
8533         specially for baselines and skipped files, and so you only
8534         should have to touch the VERSION_FALLBACK_ORDER constants on the
8535         ports, but unfortunately changing this list changes a bunch of
8536         the unit tests which are doing exact matches for correctness, so
8537         you have to touch more than a couple files :(. There's probably
8538         still more refactoring that can be done so that we don't have to
8539         do all of this functional testing to feel completely correct.
8540
8541         * Scripts/webkitpy/common/system/platforminfo.py:
8542         (PlatformInfo._determine_mac_version):
8543         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
8544         (TestPlatformInfo.test_os_version):
8545         * Scripts/webkitpy/layout_tests/port/apple.py:
8546         (ApplePort.__init__):
8547         (ApplePort):
8548         (ApplePort._skipped_file_search_paths):
8549         (ApplePort._generate_all_test_configurations):
8550         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
8551         (ChromiumMacPort):
8552         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
8553         (FactoryTest.test_mac):
8554         * Scripts/webkitpy/layout_tests/port/mac.py:
8555         (MacPort):
8556         (MacPort._build_driver_flags):
8557         (MacPort.should_retry_crashes):
8558         (MacPort.default_baseline_search_path):
8559         (MacPort.operating_system):
8560         (MacPort.default_child_processes):
8561         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
8562         (MacTest):
8563         (MacTest.test_skipped_file_search_paths):
8564         (test_versions):
8565         (test_baseline_search_path):
8566         * Scripts/webkitpy/layout_tests/port/win.py:
8567         (WinPort):
8568         (WinPort.default_baseline_search_path):
8569
8570 2012-08-21  Zan Dobersek  <zandobersek@gmail.com>
8571
8572         [GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
8573         https://bugs.webkit.org/show_bug.cgi?id=94617
8574
8575         Reviewed by Martin Robinson.
8576
8577         Set the 'enable-file-access-from-file-uris' setting to true when
8578         resetting default values. The other ports do this as well, giving
8579         documents with local security origin permission to load other
8580         local resources.
8581
8582         * DumpRenderTree/gtk/DumpRenderTree.cpp:
8583         (resetDefaultsToConsistentValues):
8584
8585 2012-08-21  Kent Tamura  <tkent@chromium.org>
8586
8587         [Chromium] DRT produces wrong back-forward list
8588         https://bugs.webkit.org/show_bug.cgi?id=94575
8589
8590         Reviewed by Adam Barth.
8591
8592         DRT clears its history state before running every tests. However
8593         HistoryController in WebCore isn't reset. So, it is possible that
8594         'isNewNavigation' flag is false even though the navigation should be
8595         handled as "new" for DRT.
8596
8597         This change might fix a problem of
8598         fast/forms/select/select-state-restore.html (Bug 90207).
8599
8600         * DumpRenderTree/chromium/WebViewHost.cpp:
8601         (WebViewHost::updateForCommittedLoad):
8602         Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
8603         Without this change, a navigation entry for this loading won't be recorded.
8604
8605 2012-08-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
8606
8607         [EFL] Enable CSS Text Decoration by default
8608         https://bugs.webkit.org/show_bug.cgi?id=94483
8609
8610         Reviewed by Kenneth Rohde Christiansen.
8611
8612         * Scripts/webkitperl/FeatureList.pm:
8613
8614 2012-08-21  Benjamin Poulain  <bpoulain@apple.com>
8615
8616         Store CString data in the CStringBuffer to avoid the double indirection
8617         https://bugs.webkit.org/show_bug.cgi?id=94562
8618
8619         Reviewed by Darin Adler.
8620
8621         Add test coverage for WTF::CString.
8622
8623         * TestWebKitAPI/CMakeLists.txt:
8624         * TestWebKitAPI/GNUmakefile.am:
8625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8626         * TestWebKitAPI/Tests/WTF/CString.cpp:
8627
8628 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
8629
8630         Text Autosizing: ::first-letter pseudo-element is incorrectly sized
8631         https://bugs.webkit.org/show_bug.cgi?id=94540
8632
8633         Reviewed by Ojan Vafai.
8634
8635         Revert the changes in bugs 94517 and 94396 so that we are
8636         actually looking for stderr output from ImageDiff and doing
8637         image compares on ref tests on the wk2 ports again.
8638
8639         Also, do an actual diff_image() call if the hash checks fail on
8640         reftests, and only fail the test if we get real diffs (or don't,
8641         for mismatches).
8642
8643         Lastly, clean up the log messages to be more helpful.
8644
8645         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
8646         (SingleTestRunner._compare_image):
8647         (SingleTestRunner._compare_output_with_reference):
8648         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
8649         (write_test_result):
8650
8651 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
8652
8653         _compare_image() swaps actual and expected images by mistake
8654         https://bugs.webkit.org/show_bug.cgi?id=94567
8655
8656         Reviewed by Ojan Vafai.
8657
8658         Re-work the code so that we consistently pass (expected, actual)
8659         across all of the compare/diff routines.
8660
8661         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
8662         (SingleTestRunner._run_compare_test):
8663         (SingleTestRunner._compare_output):
8664         (SingleTestRunner._compare_text):
8665         (SingleTestRunner._compare_audio):
8666         (SingleTestRunner._compare_image):
8667         (SingleTestRunner._run_reftest):
8668         (SingleTestRunner._compare_output_with_reference):
8669         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
8670         (write_test_result):
8671
8672 2012-08-21  Adam Barth  <abarth@webkit.org>
8673
8674         Unreviewed. Move the commit-queue to building release only. Previously,
8675         we built debug too, but for some reason the debug build doesn't work on
8676         the bots. We can re-enable debug builds once we fix the underlying
8677         problem.
8678
8679         * Scripts/webkitpy/tool/commands/queues.py:
8680         (CommitQueue.build_style):
8681         * Scripts/webkitpy/tool/commands/queues_unittest.py:
8682
8683 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
8684
8685         TestExpectationsParser doesn't warn about test files that don't exist.
8686         https://bugs.webkit.org/show_bug.cgi?id=94632
8687
8688         Reviewed by Dirk Pranke.
8689
8690         Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.
8691
8692         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
8693         (TestExpectationParser._parse_line):
8694         (TestExpectationParser._check_test_exists):
8695         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
8696         (test_parse_warning):
8697
8698 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
8699
8700         Move free functions in test_expectations to TestExpectations class
8701         https://bugs.webkit.org/show_bug.cgi?id=94557
8702
8703         Reviewed by Dirk Pranke.
8704
8705         Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
8706         to allow further refactoring.
8707
8708         * Scripts/webkitpy/common/net/resultsjsonparser.py:
8709         (JSONTestResult.did_run_as_expected):
8710         (JSONTestResult._tokenize):
8711         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
8712         (TestExpectations):
8713         (TestExpectations.result_was_expected):
8714         (TestExpectations.remove_pixel_failures):
8715         (TestExpectations.has_pixel_failures):
8716         (TestExpectations.suffixes_for_expectations):
8717         (TestExpectations.matches_an_expected_result):
8718         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
8719         (MockBugManager.create_bug):
8720         (test_result_was_expected):
8721         (test_remove_pixel_failures):
8722         (test_suffixes_for_expectations):
8723         * Scripts/webkitpy/tool/commands/rebaseline.py:
8724         (RebaselineExpectations._tests_to_rebaseline):
8725
8726 2012-08-21  Simon Hausmann  <simon.hausmann@nokia.com>
8727
8728         Unreviewed build fix for newer Qt 5: The meaning of private_includes changed to be fully
8729         self-contained. The module name is not appended automatically anymore.
8730
8731         * qmake/qt_webkit.pri:
8732
8733 2012-08-20  Xianzhu Wang  <wangxianzhu@chromium.org>
8734
8735         [Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
8736         https://bugs.webkit.org/show_bug.cgi?id=94558
8737
8738         Reviewed by Dirk Pranke.
8739
8740         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
8741         (ChromiumAndroidDriver.run_test):
8742
8743 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
8744
8745         Cleanup TestExpectationParser.parse
8746         https://bugs.webkit.org/show_bug.cgi?id=94545
8747
8748         Reviewed by Dirk Pranke.
8749
8750         Refactor TestExpectations to simplify the code.
8751
8752         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
8753         (TestExpectationParser.parse): Merged _tokenize_list.
8754         (TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
8755         since the check is now done in _parser_modifiers.
8756         (TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
8757         (TestExpectationParser._tokenize_line): Renamed from _tokenize.
8758         (TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
8759         This is done on a local variable in _parse_modifiers, preserving the original case.
8760         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
8761         of 'rebaseline' against parsed modifiers.
8762         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
8763         (TestExpectationParserTests._tokenize):
8764         (TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
8765         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
8766         (TestExpectationSerializerTests._tokenize):
8767         (TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
8768         been merged into parse.
8769         * Scripts/webkitpy/tool/commands/queries_unittest.py:
8770         (PrintExpectationsTest.test_csv): Preserves the case.
8771
8772 2012-08-20  Gustavo Noronha Silva  <gns@gnome.org>
8773
8774         [jhbuild] EFL now runs jhbuild update for every build
8775         https://bugs.webkit.org/show_bug.cgi?id=94267
8776
8777         Reviewed by Martin Robinson.
8778
8779         Try to fix WinCE build by returning the empty string instead of
8780         env when no jhbuild infrastructure is found.
8781
8782         * Scripts/webkitdirs.pm:
8783         (jhbuildWrapperPrefixIfNeeded):
8784
8785 2012-08-20  Benjamin Poulain  <benjamin@webkit.org>
8786
8787         Add a watcher for WTF changes
8788
8789         Unreviewed.
8790
8791         Add myself as a watcher for changes in WTF.
8792
8793         * Scripts/webkitpy/common/config/watchlist:
8794
8795 2012-08-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
8796
8797         [EFL] Move jhbuild dependencies based on SVN to tarballs
8798         https://bugs.webkit.org/show_bug.cgi?id=90374
8799
8800         Reviewed by Kenneth Rohde Christiansen.
8801
8802         Moved all the dependencies based on SVN to tarballs taken from a
8803         equivalent snapshot from the official git mirror. This will make
8804         update-webkitefl not dependent on network connection after the first
8805         run. The bots will not fail if EFL SVN server in unreachable.
8806         The reason why git mirror is not used directly is to minimize the
8807         total size of source code we need to download.
8808
8809         * efl/jhbuild.modules:
8810
8811 2012-08-20  Simon Fraser  <simon.fraser@apple.com>
8812
8813         Lots of "error, test and reference image have different properties" in pixel test output
8814         https://bugs.webkit.org/show_bug.cgi?id=92578
8815
8816         Reviewed by Dirk Pranke.
8817
8818         Improve ImageDiff's error reporting when test result image and expected image
8819         differ in their properties.
8820
8821         * DumpRenderTree/cg/ImageDiffCG.cpp:
8822
8823 2012-08-20  Nate Chapin  <japhet@chromium.org>
8824
8825         Unsafe vsprintf usage in TestNetscapePlugin
8826         https://bugs.webkit.org/show_bug.cgi?id=94522
8827
8828         Reviewed by Adam Barth.
8829
8830         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
8831         (pluginLogWithArguments): Using vsnprintf instead of vsprintf to ensure we don't overflow
8832             the message buffer.
8833         (testDocumentOpen):
8834         (testWindowOpen):
8835
8836 2012-08-20  George Staikos  <staikos@webkit.org>
8837
8838         [BlackBerry] Enable XHR Response BLOB
8839         https://bugs.webkit.org/show_bug.cgi?id=94525
8840
8841         Reviewed by Rob Buis.
8842
8843         Turn on the XHR response blob feature for the BlackBerry port.
8844
8845         * Scripts/webkitperl/FeatureList.pm: Add the feature and enable it.
8846
8847 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
8848
8849         Fix change for timeout detection to not crash if we have no output :)
8850         https://bugs.webkit.org/show_bug.cgi?id=94505
8851
8852         Unreviewed, build fix.
8853
8854         * Scripts/webkitpy/layout_tests/port/driver.py:
8855         (Driver.run_test):
8856
8857 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
8858
8859         temporarily disable ImageDiff on WK2 ports for ref tests
8860         https://bugs.webkit.org/show_bug.cgi?id=94517
8861
8862         Reviewed by Brady Eidson.
8863
8864         ImageDiff appears to be unable to handle the pngs returned from
8865         WebKitTestRunner, so we disable checking images by default
8866         for ref tests on wk2 ports (unless pixel tests is explicitly enabled).
8867
8868         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
8869         (SingleTestRunner._compare_output_with_reference):
8870
8871 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
8872
8873         Add missing FIXME: to previous change.
8874         https://bugs.webkit.org/show_bug.cgi?id=94505
8875
8876         Reviewed by Ojan Vafai.
8877
8878         * Scripts/webkitpy/layout_tests/port/driver.py:
8879         (Driver.run_test):
8880
8881 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
8882
8883         Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
8884         https://bugs.webkit.org/show_bug.cgi?id=94505
8885
8886         Reviewed by Ojan Vafai.
8887
8888         It looks like if the webprocess times out, WTR may tell NRWT
8889         that the test completed, but not properly reset its internal
8890         state, and then return stale output for subsequent tests.
8891
8892         This patch modifies NRWT temporarily to check for
8893         "Timed out waiting for final message from web process" in stdout
8894         and treat that as a timeout (and thus kill WTR); this seems
8895         to solve the cascade of failures, but of course there's probably
8896         still a bug in WTR that needs to be fixed.
8897
8898         * Scripts/webkitpy/layout_tests/port/driver.py:
8899         (Driver.run_test):
8900
8901 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
8902
8903         NRWT reports unexpected EOF
8904         https://bugs.webkit.org/show_bug.cgi?id=94387
8905
8906         Reviewed by Adam Barth.
8907
8908         Stop logging "Unexpected EOF" when we are reading the last few
8909         bytes from stdout/stderr after stopping the subprocess.
8910
8911         * Scripts/webkitpy/layout_tests/port/server_process.py:
8912         (ServerProcess._wait_for_data_and_update_buffers_using_select):
8913         (ServerProcess.stop):
8914
8915 2012-08-20  Brady Eidson  <beidson@apple.com>
8916
8917         Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
8918         https://bugs.webkit.org/show_bug.cgi?id=94506
8919
8920         Reviewed by Dirk Pranke.
8921
8922         When running WK2 tests, don't add the "abort early" command line options.
8923
8924         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
8925         (ConfigureBuild.start):
8926         (RunWebKitTests):
8927         (RunWebKitTests.start):
8928         (RunWebKit2Tests.start):
8929
8930 2012-08-19  Stephanie Lewis  <slewis@apple.com>
8931
8932         Add mountain lion to build config.
8933         https://bugs.webkit.org/show_bug.cgi?id=94441
8934
8935         Reviewed by Adam Barth.
8936
8937         Add Mountain Lion to the build trigger configurations.
8938
8939         * Scripts/webkitpy/common/config/build.py:
8940         (_should_file_trigger_build):
8941         * Scripts/webkitpy/common/config/build_unittest.py:
8942         (ShouldBuildTest):
8943         (ShouldBuildTest.test_should_build):
8944
8945 2012-08-17  Kiran Muppala  <cmuppala@apple.com>
8946
8947         Add self to webkit contributors list
8948         https://bugs.webkit.org/show_bug.cgi?id=94409
8949
8950         Reviewed by Dirk Pranke.
8951
8952         Add name, email and irc handle to webkit contributors list.
8953
8954         * Scripts/webkitpy/common/config/committers.py:
8955
8956 2012-08-17  Ryosuke Niwa  <rniwa@webkit.org>
8957
8958         Perfalizer should differentiate results with and without the patch
8959         https://bugs.webkit.org/show_bug.cgi?id=94399
8960
8961         Reviewed by Dirk Pranke.
8962
8963         Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
8964         the results page are labled accordingly.
8965
8966         Also use _build_without_patch when building without a patch so that we get the right error message.
8967
8968         * Scripts/webkitpy/tool/commands/perfalizer.py:
8969         (PerfalizerTask.run):
8970         (PerfalizerTask._run_perf_test):
8971         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
8972         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
8973
8974 2012-08-17  Dirk Pranke  <dpranke@chromium.org>
8975
8976         nrwt: don't fail tests if ImageDiff fails on the wk2 ports
8977         https://bugs.webkit.org/show_bug.cgi?id=94396
8978
8979         Reviewed by Ryosuke Niwa.
8980
8981         It appears that WTR is generating PNGs that ImageDiff doesn't
8982         like, and so we're getting lots of "can not get ImageDiff"
8983         errors (see bug 81962). The change in r124581 made this a test
8984         failure, and this is causing the WK2 bots to frequently abort
8985         with 500+ failures. 
8986
8987         This change makes ImageDiff errors not be test failures just for
8988         WK2 for now until we can better triage what's going on.
8989
8990         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
8991         (SingleTestRunner._compare_image):
8992
8993 2012-08-17  James Robinson  <jamesr@chromium.org>
8994
8995         [chromium] Add a style check for #include "cc/..." in chromium files
8996         https://bugs.webkit.org/show_bug.cgi?id=94382
8997
8998         Reviewed by Adam Barth.
8999
9000         Adds a style check to make sure new chromium code follows the correct convention for including cc files.
9001
9002         * Scripts/webkitpy/style/checkers/cpp.py:
9003         (check_include_line):
9004         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
9005         (OrderOfIncludesTest.test_check_cc_includes):
9006
9007 2012-08-17  Ojan Vafai  <ojan@chromium.org>
9008
9009         Delete some dead code from the flakiness dashboard
9010         https://bugs.webkit.org/show_bug.cgi?id=94380
9011
9012         Reviewed by Dirk Pranke.
9013
9014         This code became dead in one of the refactors of how we handle BuilderGroups.
9015         There's no bug here, it's just dead code.
9016         * TestResultServer/static-dashboards/builders.js:
9017         (requestBuilderList):
9018         (loadBuildersList):
9019
9020 2012-08-17  Jochen Eisinger  <jochen@chromium.org>
9021
9022         [chromium] Add content shell bots to the flakiness dashboard
9023         https://bugs.webkit.org/show_bug.cgi?id=94369
9024
9025         Reviewed by Ojan Vafai.
9026
9027         The bots are named $OS (Content Shell).
9028
9029         * TestResultServer/static-dashboards/builders.js:
9030         (isChromiumWebkitTipOfTreeTestRunner):
9031         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
9032
9033 2012-08-17  Shadi Khalek  <shadi@chromium.org>
9034
9035         Add AV perf layout tests to webkit flakiness dashboard
9036         https://bugs.webkit.org/show_bug.cgi?id=94255
9037
9038         Reviewed by Ojan Vafai.
9039
9040         Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
9041         The isChromiumDepsAVTestRunner() filter does not work on current builder names. 
9042         It assumes the new names they are getting renamed to (AV Linux, AV Win7).
9043
9044         * TestResultServer/static-dashboards/builders.js:
9045         (isChromiumTipOfTreeAVTestRunner):
9046         (loadBuildersList):
9047
9048 2012-08-17  Milian Wolff  <milian.wolff@kdab.com>
9049
9050         [Qt] QtWebKit fails to build with OpenGL support on QNX
9051         https://bugs.webkit.org/show_bug.cgi?id=93278
9052
9053         Reviewed by Noam Rosenthal.
9054
9055         Change the order in which we define WTF_USE_3D_GRAPHICS and ENABLE_WEBGL.
9056         First, we now defined WTF_USE_3D_GRAPHICS=1, but only if QT_CONFIG
9057         contains opengl. Furthermore, we disable this feature on win32-* as usual,
9058         but now also disable it on QNX.
9059
9060         Then, we set ENABLE_WEBGL=1 but only if we previously set WTF_USE_3D_GRAPHICS=1.
9061
9062         * qmake/mkspecs/features/features.prf:
9063
9064 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
9065
9066         [jhbuild] EFL now runs jhbuild update for every build
9067         https://bugs.webkit.org/show_bug.cgi?id=94267
9068
9069         Reviewed by Dirk Pranke.
9070
9071         This change makes EFL's approach to jhbuild more in line with the one
9072         used by WebKitGTK+. update-webkitefl-libs will only be called by build-
9073         webkit if --update-efl is given explicitly. The EWS bot will do that
9074         from now on.
9075
9076         * Scripts/webkitdirs.pm:
9077         (jhbuildWrapperPrefixIfNeeded): return jhbuild wrapper only if the
9078         Dependencies directory exists also for EFL
9079         (generateBuildSystemFromCMakeProject): no longer run update-webkitefl-libs
9080         (buildCMakeProjectOrExit): build update-webkitefl-libs if --update-efl is
9081         given
9082         * Scripts/webkitpy/common/config/ports.py:
9083         (EflPort.build_webkit_command): make EWS bots pass --update-efl to build-webkit
9084         * Scripts/webkitpy/common/config/ports_unittest.py:
9085         (DeprecatedPortTest.test_efl_port): add unit testing for EFL port
9086
9087 2012-08-16  Kent Tamura  <tkent@chromium.org>
9088
9089         Add forms-bugs@chromium.org as a contributor.
9090
9091         * Scripts/webkitpy/common/config/committers.py:
9092
9093 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
9094
9095         Unreviewed warning fix, sys.argv is a python construct.
9096
9097         * Scripts/update-webkitefl-libs:
9098
9099 2012-08-16  Dirk Pranke  <dpranke@chromium.org>
9100
9101         NRWT cutting off the output from LayoutTest run under Valgrind
9102         https://bugs.webkit.org/show_bug.cgi?id=94011
9103
9104         Reviewed by Ojan Vafai.
9105
9106         Make NRWT work with valgrind again ... I needed to rework the
9107         driver infrastructure so that we could get the stderr written
9108         between a test completing and a process being stopped and
9109         associate it with the DriverOutput for the test; this meant that
9110         run_test() needed to stop the driver at the end of the test
9111         directly if/when appropriate. This also entailed reworking
9112         run_test() so that we would gather stderr and stdout
9113         consistently regardless of whether this was a normal test, or
9114         stop_when_done, or a crash or timeout.
9115
9116         Also, I had to rework the process_stop_time() (and renamed it to
9117         driver_stop_timeout) so that it would be longer if --time-out-ms
9118         was long as well (so that valgrind would get enough time to
9119         run), and I reworked driver.stop(kill_directly=True) to just
9120         driver.stop(timeout=0.0).
9121
9122         Lastly, adding the new stop_when_done parameter entailed
9123         touching a lot of test mock functions :(.
9124
9125         This change appeared to be well-covered by existing tests.
9126
9127         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
9128         (Worker._run_test):
9129         (Worker._run_test_with_timeout):
9130         (Worker._run_test_in_another_thread):
9131         (Worker._run_test_in_another_thread.SingleTestThread.run):
9132         (Worker._run_test_in_this_thread):
9133         (Worker._run_single_test):
9134         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
9135         (run_single_test):
9136         (SingleTestRunner.__init__):
9137         (SingleTestRunner._run_compare_test):
9138         (SingleTestRunner._run_rebaseline):
9139         (SingleTestRunner._run_reftest):
9140         * Scripts/webkitpy/layout_tests/port/base.py:
9141         (Port.driver_stop_timeout):
9142         (Port.variable.default_configuration):
9143         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
9144         (ChromiumAndroidPort.driver_stop_timeout):
9145         (ChromiumAndroidDriver.stop):
9146         * Scripts/webkitpy/layout_tests/port/driver.py:
9147         (Driver.run_test):
9148         (Driver.stop):
9149         (DriverProxy.run_test):
9150         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
9151         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
9152         * Scripts/webkitpy/layout_tests/port/server_process.py:
9153         (ServerProcess.write):
9154         (ServerProcess._wait_for_data_and_update_buffers_using_select):
9155         (ServerProcess.stop):
9156         (ServerProcess.kill):
9157         (ServerProcess):
9158         (ServerProcess._kill):
9159         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
9160         (TrivialMockPort.__init__):
9161         (MockProc.wait):
9162         (TestServerProcess.test_basic):
9163         * Scripts/webkitpy/layout_tests/port/test.py:
9164         (TestDriver.run_test):
9165         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
9166         (get_tests_run.RecordingTestDriver.run_test):
9167         * Scripts/webkitpy/performance_tests/perftest.py:
9168         (PerfTest.run_single):
9169         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
9170         (TestPageLoadingPerfTest.MockDriver.run_test):
9171         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
9172         (TestReplayPerfTest.test_run_single.run_test):
9173         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
9174         (TestReplayPerfTest.test_prepare.run_test):
9175         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
9176         (MainTest.TestDriver.run_test):
9177
9178 2012-08-16  Roger Fong  <roger_fong@apple.com>
9179
9180         Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
9181         https://bugs.webkit.org/show_bug.cgi?id=94228
9182
9183         Reviewed by Tim Horton.
9184
9185         I previously made the change but made a typo that causes the script not ignore mismatch ref tests.
9186
9187         * Scripts/old-run-webkit-tests:
9188         (isUsedInReftest):
9189
9190 2012-08-16  Peter Beverloo  <peter@chromium.org>
9191
9192         [Chromium] Pass the --strip-binary argument to the apk test generator
9193         https://bugs.webkit.org/show_bug.cgi?id=94224
9194
9195         Reviewed by Adam Barth.
9196
9197         The native test generator currently relies on the $STRIP environment
9198         variable to be available, which it shouldn't do. Instead, pass it as an
9199         argument to the script. The $STRIP variable is being deprecated.
9200
9201         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
9202         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
9203
9204 2012-08-16  Xiaobo Wang  <xbwang@torchmobile.com.cn>
9205
9206         [BlackBerry] Update format of JS console message to keep consistent with other ports.
9207         https://bugs.webkit.org/show_bug.cgi?id=94058
9208
9209         Reviewed by Yong Li.
9210         Reviewed internally by George Staikos.
9211
9212         1. Remove line number if it's zero.
9213         2. Print only file name for "file://" URL.
9214
9215         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
9216         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
9217
9218 2012-08-16  Simon Hausmann  <simon.hausmann@nokia.com>
9219
9220         [Qt] Make DRT results more reliable on X11
9221
9222         Reviewed by Jocelyn Turcotte.
9223
9224         Disable desktop setting awareness, to prevent QApplication on X11 from reading palette settings from
9225         the running desktop environment.
9226
9227         * DumpRenderTree/qt/main.cpp:
9228         (main):
9229
9230 2012-08-16  Pierre Rossi  <pierre.rossi@gmail.com>
9231
9232         [Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
9233         https://bugs.webkit.org/show_bug.cgi?id=93960
9234
9235         Reviewed by Simon Hausmann.
9236
9237         Following the removal of Qt 4 support from trunk in r124879.
9238
9239         * qmake/mkspecs/features/features.prf:
9240
9241 2012-08-16  Taiju Tsuiki  <tzik@chromium.org>
9242
9243         Add deleteFileSystem support to DumpRenderTree for chromium
9244         https://bugs.webkit.org/show_bug.cgi?id=94071
9245
9246         Reviewed by Kent Tamura.
9247
9248         * DumpRenderTree/chromium/WebViewHost.cpp:
9249         (WebViewHost::deleteFileSystem): Added
9250         * DumpRenderTree/chromium/WebViewHost.h:
9251         (WebViewHost):
9252
9253 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
9254
9255         Rename LayoutTestController to TestRunner in WebKitTestRunner
9256         https://bugs.webkit.org/show_bug.cgi?id=93942
9257
9258         Reviewed by Simon Fraser.
9259
9260         Renamed the class and relevant files.
9261
9262         * WebKitTestRunner/CMakeLists.txt:
9263         * WebKitTestRunner/DerivedSources.make:
9264         * WebKitTestRunner/GNUmakefile.am:
9265         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
9266         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
9267         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
9268         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
9269         (WTR::InjectedBundle::didReceiveMessage):
9270         (WTR::InjectedBundle::beginTesting):
9271         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
9272         (WTR::InjectedBundle::testRunner):
9273         (InjectedBundle):
9274         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
9275         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
9276         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
9277         * WebKitTestRunner/InjectedBundle/Target.pri:
9278         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
9279         * WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.
9280         (TestRunner):
9281         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
9282         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.
9283         (WTR::waitToDumpWatchdogTimerCallback):
9284         (WTR::TestRunner::platformInitialize):
9285         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
9286         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
9287         (WTR::TestRunner::pathToLocalResource):
9288         (WTR::TestRunner::platformName):
9289         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
9290         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.
9291         (WTR::waitToDumpWatchdogTimerCallback):
9292         (WTR::TestRunner::platformInitialize):
9293         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
9294         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
9295         (WTR::TestRunner::pathToLocalResource):
9296         (WTR::TestRunner::platformName):
9297         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
9298         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.
9299         (WTR::TestRunner::platformInitialize):
9300         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
9301         (WTR::waitUntilDoneWatchdogTimerFired):
9302         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
9303         (WTR::TestRunner::pathToLocalResource):
9304         (WTR::TestRunner::platformName):
9305         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
9306         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.
9307         (WTR::WatchdogTimerHelper::timerFired):
9308         (WTR::TestRunner::platformInitialize):
9309         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
9310         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
9311         (WTR::TestRunner::pathToLocalResource):
9312         (WTR::TestRunner::platformName):
9313         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
9314         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.
9315         (WTR::TestRunner::platformInitialize):
9316         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
9317         (WTR::waitToDumpWatchdogTimerFired):
9318         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
9319         (WTR::TestRunner::pathToLocalResource):
9320         (WTR::TestRunner::platformName):
9321         * WebKitTestRunner/PlatformEfl.cmake:
9322         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
9323         * WebKitTestRunner/win/InjectedBundle.vcproj:
9324
9325 2012-08-15  Xianzhu Wang  <wangxianzhu@chromium.org>
9326
9327         [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
9328         https://bugs.webkit.org/show_bug.cgi?id=94155
9329
9330         Reviewed by Dirk Pranke.
9331
9332         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
9333         (ChromiumAndroidPort.create_driver): Force no_timeout=True
9334
9335 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
9336
9337         Add a hyperlink to perf-o-matic from build.webkit.org/root.html
9338         https://bugs.webkit.org/show_bug.cgi?id=93749
9339
9340         Reviewed by Csaba Osztrogonác.
9341
9342         Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
9343         of performance tests.
9344
9345         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
9346
9347 2012-08-15  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
9348
9349         [css3-text] Add CSS3 Text decoration compile flag
9350         https://bugs.webkit.org/show_bug.cgi?id=93863
9351
9352         Reviewed by Julien Chaffraix.
9353
9354         This patch handles the compile flag implementation, which will come disabled by
9355         default, thus not exposing the CSS3 text decoration features to the web, unless
9356         when explicitly enabling it with "--css3-text-decoration" build parameter.
9357
9358         * Scripts/webkitperl/FeatureList.pm:
9359         * qmake/mkspecs/features/features.pri:
9360
9361 2012-08-15  Beth Dakin  <bdakin@apple.com>
9362
9363         https://bugs.webkit.org/show_bug.cgi?id=93693
9364         [WK2] REGRESSION(125091): pixel results don't sow scrollbars 
9365         anymore
9366
9367         Reviewed by Sam Weinig.
9368
9369         Use new API WKBundlePageCreateSnapshotWithOptions().
9370         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
9371         (WTR::InjectedBundlePage::dump):
9372
9373 2012-08-15  Alexey Proskuryakov  <ap@apple.com>
9374
9375         Add rfong to Bugzilla CC "contributor" list.
9376
9377         * Scripts/webkitpy/common/config/committers.py:
9378
9379 2012-08-15  Scott Graham  <scottmg@chromium.org>
9380
9381         Rename window.internals.fastMallocStatistics to mallocStatistics
9382         https://bugs.webkit.org/show_bug.cgi?id=94033
9383
9384         Reviewed by Adam Barth.
9385
9386         * GNUmakefile.am:
9387         * Scripts/webkitpy/performance_tests/perftest.py:
9388         (PerfTest):
9389         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
9390         (test_run_memory_test):
9391
9392 2012-08-15  Peter Beverloo  <peter@chromium.org>
9393
9394         Fix a warning in TestWebKitAPI's MediaTime test-suite
9395         https://bugs.webkit.org/show_bug.cgi?id=94096
9396
9397         Reviewed by Adam Barth.
9398
9399         This warning is visible when building the file with certain GCC versions,
9400         including the one used by Chromium for Android. The warning is visible in
9401         the cr-android build bot output:
9402
9403         MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90
9404
9405         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
9406         (TestWebKitAPI::TEST):
9407
9408 2012-08-15  Kevin Funk  <kevin.funk@kdab.com>
9409
9410         Fix the 'git log' call in VCSUtils.pm for Windows
9411         https://bugs.webkit.org/show_bug.cgi?id=94113
9412
9413         Reviewed by Kenneth Rohde Christiansen.
9414
9415         Failed because of invalid enquoting characters.
9416
9417         * Scripts/VCSUtils.pm:
9418
9419 2012-08-14  Gustavo Noronha Silva  <gns@gnome.org>
9420
9421         [jhbuild] move md5sum checking to update-webkit-libs-jhbuild
9422         https://bugs.webkit.org/show_bug.cgi?id=93208
9423
9424         Reviewed by Martin Robinson.
9425
9426         This change makes the md5sum check and saving be done by the script
9427         that performs the dependencies update. build-webkit no longer prefixes
9428         calls to commands with jhbuild-wrapper if jhbuild has not been
9429         bootstrapped by the developer and --update-gtk is not given.
9430
9431         * Scripts/update-webkit-libs-jhbuild:
9432         (getMD5HashForFile): moved from webkitdirs.
9433         (jhbuildConfigurationChanged): ditto.
9434         (saveJhbuildMd5): ditto.
9435         (cleanJhbuild): ditto, and changed to run jhbuild clean before removing
9436         jhbuild.
9437         * Scripts/webkitdirs.pm:
9438         (runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
9439         (buildAutotoolsProject): ditto.
9440         (jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
9441         (generateBuildSystemFromCMakeProject): call update-webkitefl-libs
9442         unconditionally for EFL.
9443         * jhbuild/jhbuild-wrapper:
9444         (update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
9445         update script itself
9446         (ensure_jhbuild): remove update call.
9447
9448 2012-08-15  Christophe Dumez  <christophe.dumez@intel.com>
9449
9450         [WK2] Add support for Web Intents MessagePorts
9451         https://bugs.webkit.org/show_bug.cgi?id=89072
9452
9453         Reviewed by Kenneth Rohde Christiansen.
9454
9455         Use WKBundleIntent instead of WebIntentData in
9456         WebKitTestRunner. WTR now prints the number of
9457         MessagePorts in received Web intents as
9458         expected by the following layout tests:
9459         webintents/web-intents-invoke-port.html
9460         webintents/web-intents-obj-constructor.html
9461
9462         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
9463         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
9464         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
9465         (WTR::LayoutTestController::deliverWebIntent):
9466
9467 2012-08-14  Ryosuke Niwa  <rniwa@webkit.org>
9468
9469         Build fix after r125516. Revert the erroneous rename since we need to keep exposing
9470         layoutTestController in Chromium port as explained r124785.
9471
9472         * DumpRenderTree/chromium/TestShell.cpp:
9473         (TestShell::bindJSObjectsToWindow):
9474
9475 2012-08-14  Dan Bernstein  <mitz@apple.com>
9476
9477         fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
9478         https://bugs.webkit.org/show_bug.cgi?id=94045
9479
9480         Reviewed by Geoff Garen.
9481
9482         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
9483         (-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
9484         needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.
9485
9486 2012-08-14  Alexey Proskuryakov  <ap@apple.com>
9487
9488         [WK2] Fix some typos in MiniBrowser
9489         https://bugs.webkit.org/show_bug.cgi?id=94047
9490
9491         Reviewed by Jon Honeycutt.
9492
9493         * MiniBrowser/mac/AppDelegate.m:
9494         (didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):
9495         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
9496         (didReceiveMessage):
9497         (WKBundleInitialize):
9498
9499 2012-08-14  Roger Fong  <roger_fong@apple.com>
9500
9501         old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
9502         https://bugs.webkit.org/show_bug.cgi?id=93904
9503
9504         Reviewed by Tim Horton.
9505
9506         old-run-webkit-tests ref test only skipped .html test.
9507         They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.
9508         
9509         * Scripts/old-run-webkit-tests:
9510         (isUsedInReftest): Skip all extensions for ref tests.
9511
9512 2012-08-14  Lauro Neto  <lauro.neto@openbossa.org>
9513
9514         Convert signals/slots to Q_* macros.
9515
9516         [Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
9517         https://bugs.webkit.org/show_bug.cgi?id=93996
9518
9519         Reviewed by Kenneth Rohde Christiansen.
9520
9521         Change usage of keyword-conflicting 'signals' and 'slots' for
9522         Q_SIGNALS and Q_SLOTS macro.
9523
9524         * DumpRenderTree/qt/DumpRenderTreeQt.h:
9525         (NetworkAccessManager):
9526         (WebPage):
9527         * DumpRenderTree/qt/EventSenderQt.h:
9528         (EventSender):
9529         * DumpRenderTree/qt/GCControllerQt.h:
9530         (GCController):
9531         * DumpRenderTree/qt/TestRunnerQt.h:
9532         (TestRunner):
9533         * DumpRenderTree/qt/TextInputControllerQt.h:
9534         (TextInputController):
9535         * MiniBrowser/qt/BrowserWindow.h:
9536         (BrowserWindow):
9537         * MiniBrowser/qt/MiniBrowserApplication.h:
9538         (WindowOptions):
9539         * MiniBrowser/qt/UrlLoader.h:
9540         (UrlLoader):
9541         * QtTestBrowser/cookiejar.h:
9542         (TestBrowserCookieJar):
9543         * QtTestBrowser/fpstimer.h:
9544         (FpsTimer):
9545         * QtTestBrowser/launcherwindow.h:
9546         (LauncherWindow):
9547         * QtTestBrowser/locationedit.h:
9548         (LocationEdit):
9549         * QtTestBrowser/mainwindow.h:
9550         (MainWindow):
9551         * QtTestBrowser/urlloader.h:
9552         (UrlLoader):
9553         * QtTestBrowser/webinspector.h:
9554         (WebInspector):
9555         * QtTestBrowser/webpage.h:
9556         (WebPage):
9557         * QtTestBrowser/webview.h:
9558         (WebViewGraphicsBased):
9559         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
9560         (WatchdogTimerHelper):
9561         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
9562         (WrapperWindow):
9563         * WebKitTestRunner/qt/main.cpp:
9564         (Launcher):
9565
9566 2012-08-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
9567
9568         WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
9569         https://bugs.webkit.org/show_bug.cgi?id=42332
9570
9571         Reviewed by Kenneth Rohde Christiansen.
9572
9573         Added Resource Callbacks logging. Several aux dumping functions are added.
9574
9575         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
9576         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
9577         (WTR::isFileScheme):
9578         (WTR):
9579         (WTR::pathSuitableForTestResult):
9580         (WTR::urlSuitableForTestResult):
9581         (WTR::InjectedBundlePage::resetAfterTest):
9582         (WTR::dumpRequestDescriptionSuitableForTestResult):
9583         (WTR::dumpResponseDescriptionSuitableForTestResult):
9584         (WTR::dumpErrorDescriptionSuitableForTestResult):
9585         (WTR::InjectedBundlePage::didInitiateLoadForResource):
9586         (WTR::InjectedBundlePage::willSendRequestForFrame):
9587         (WTR::InjectedBundlePage::didReceiveResponseForResource):
9588         (WTR::InjectedBundlePage::didFinishLoadForResource):
9589         (WTR::InjectedBundlePage::didFailLoadForResource):
9590         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
9591         (WTR::LayoutTestController::LayoutTestController):
9592         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
9593         (WTR::LayoutTestController::dumpResourceLoadCallbacks):
9594         (WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
9595         (LayoutTestController):
9596
9597 2012-08-14  Alexis Menard  <alexis.menard@openbossa.org>
9598
9599         Update INdT build bot to Mountain Lion.
9600         https://bugs.webkit.org/show_bug.cgi?id=93963
9601
9602         Reviewed by Csaba Osztrogonác.
9603
9604         We updated the machine as well as the OS as the Qt port is now running
9605         on top of Qt5.
9606
9607         * BuildSlaveSupport/build.webkit.org-config/config.json:
9608
9609 2012-08-14  Peter Beverloo  <peter@chromium.org>
9610
9611         [Chromium] Remove unneeded build logic for Android
9612         https://bugs.webkit.org/show_bug.cgi?id=93962
9613
9614         Reviewed by Dimitri Glazkov.
9615
9616         The Android SDK and NDK have been checked in to the Chromium tree, which
9617         allows WebKit to leverage those as well. They will already be pulled in
9618         through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
9619         environment variable, the envsetup.sh will set the project files up
9620         appropriately for us.
9621
9622         * Scripts/webkitdirs.pm:
9623
9624 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
9625
9626         [WK2] [GTK] Plugin tests failing in WK2 bot
9627         https://bugs.webkit.org/show_bug.cgi?id=93954
9628
9629         Reviewed by Carlos Garcia Campos.
9630
9631         Plugin tests are failing in the WK2 bot because we aren't exporting
9632         the Netscape plugin when creating the product archive.
9633
9634         * BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
9635         to the list of directories to export.
9636         (archiveBuiltProduct):
9637
9638 2012-08-14  Peter Beverloo  <peter@chromium.org>
9639
9640         [Chromium] Fix apk generation for the Android platform
9641         https://bugs.webkit.org/show_bug.cgi?id=93841
9642
9643         Unreviewed build fix.
9644
9645         APK generation was broken as the configuration file assumed compilation
9646         would only occur in the Chromium tree. Pass the path to Chromium's source
9647         base directory as a property to ant.
9648
9649         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
9650         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
9651
9652 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
9653
9654         [GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
9655         https://bugs.webkit.org/show_bug.cgi?id=91083
9656
9657         Reviewed by Carlos Garcia Campos.
9658
9659         Unskipped a couple of API tests that should work fine from now on.
9660
9661         * Scripts/run-gtk-tests:
9662         (TestRunner):
9663
9664 2012-08-14  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
9665
9666         [NRWT] Compare results between different platforms
9667         https://bugs.webkit.org/show_bug.cgi?id=90555
9668
9669         Reviewed by Dirk Pranke.
9670
9671         * Scripts/webkitpy/layout_tests/port/base.py:
9672         (Port.baseline_search_path):
9673         (Port):
9674         (Port.compare_baseline):
9675         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
9676         (parse_args):
9677
9678 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
9679
9680         Rename LayoutTestController to TestRunner in DumpRenderTree
9681         https://bugs.webkit.org/show_bug.cgi?id=93758
9682
9683         Reviewed by Tony Chang.
9684
9685         Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
9686         since it already has TestRunner class shared between DumpRenderTree and content_shell.
9687
9688         * DumpRenderTree/DumpRenderTree.h:
9689         * DumpRenderTree/PixelDumpSupport.cpp:
9690         * DumpRenderTree/StorageTrackerDelegate.h:
9691         * DumpRenderTree/StorageTrackerDelegate.mm:
9692         * DumpRenderTree/TestRunner.cpp:
9693         * DumpRenderTree/TestRunner.h:
9694         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
9695         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
9696         * DumpRenderTree/chromium/DRTTestRunner.cpp:
9697         * DumpRenderTree/chromium/DRTTestRunner.h:
9698         * DumpRenderTree/chromium/DumpRenderTree.cpp:
9699         * DumpRenderTree/chromium/NotificationPresenter.h:
9700         * DumpRenderTree/chromium/TestShell.cpp:
9701         * DumpRenderTree/chromium/TestShell.h:
9702         * DumpRenderTree/chromium/WebPermissions.cpp:
9703         * DumpRenderTree/chromium/WebPermissions.h:
9704         * DumpRenderTree/chromium/WebViewHost.cpp:
9705         * DumpRenderTree/chromium/WebViewHost.h:
9706         * DumpRenderTree/efl/DumpRenderTree.cpp:
9707         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
9708         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
9709         * DumpRenderTree/efl/EditingCallbacks.cpp:
9710         * DumpRenderTree/efl/TestRunnerEfl.cpp:
9711         * DumpRenderTree/gtk/DumpRenderTree.cpp:
9712         * DumpRenderTree/gtk/EditingCallbacks.cpp:
9713         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
9714         * DumpRenderTree/mac/DumpRenderTree.mm:
9715         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
9716         * DumpRenderTree/mac/EditingDelegate.mm:
9717         * DumpRenderTree/mac/FrameLoadDelegate.mm:
9718         * DumpRenderTree/mac/HistoryDelegate.mm:
9719         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
9720         * DumpRenderTree/mac/PolicyDelegate.h:
9721         * DumpRenderTree/mac/PolicyDelegate.mm:
9722         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
9723         * DumpRenderTree/mac/TestRunnerMac.mm:
9724         * DumpRenderTree/mac/UIDelegate.mm:
9725         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
9726         * DumpRenderTree/qt/DumpRenderTreeQt.h:
9727         * DumpRenderTree/qt/TestRunnerQt.cpp:
9728         * DumpRenderTree/qt/TestRunnerQt.h:
9729         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
9730         * DumpRenderTree/win/DumpRenderTree.cpp:
9731         * DumpRenderTree/win/EditingDelegate.cpp:
9732         * DumpRenderTree/win/FrameLoadDelegate.cpp:
9733         * DumpRenderTree/win/HistoryDelegate.cpp:
9734         * DumpRenderTree/win/PolicyDelegate.h:
9735         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
9736         * DumpRenderTree/win/TestRunnerWin.cpp:
9737         * DumpRenderTree/win/UIDelegate.cpp:
9738         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
9739         * DumpRenderTree/wx/TestRunnerWx.cpp:
9740
9741 2012-08-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
9742
9743         [GTK] String returned by g_path_get_dirname() must be freed
9744         https://bugs.webkit.org/show_bug.cgi?id=93885
9745
9746         Reviewed by Philippe Normand.
9747
9748         Fix a memory leak in GTK's DRT code.
9749
9750         * DumpRenderTree/gtk/DumpRenderTree.cpp:
9751         (pathFromSoupURI): Free the string returned by g_path_get_dirname().
9752
9753 2012-08-14  Zan Dobersek  <zandobersek@gmail.com>
9754
9755         Unreviewed GTK build fix after r125508.
9756
9757         Do the renaming in GNUmakefile.am as well, LayoutTestController -> TestRunner.
9758
9759         * GNUmakefile.am:
9760
9761 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
9762
9763         Rename files that declare and define LayoutTestController in DumpRenderTree
9764         https://bugs.webkit.org/show_bug.cgi?id=93899
9765
9766         Reviewed by Tony Chang.
9767
9768         Renamed files and fixed style errors.
9769
9770         * DumpRenderTree/DumpRenderTree.gypi:
9771         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9772         * DumpRenderTree/LayoutTestController.cpp: Removed.
9773         * DumpRenderTree/LayoutTestController.h: Removed.
9774         * DumpRenderTree/PixelDumpSupport.cpp:
9775         * DumpRenderTree/StorageTrackerDelegate.mm:
9776         * DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
9777         * DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.
9778         (LayoutTestController):
9779         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
9780         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
9781         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
9782         * DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
9783         * DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
9784         * DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
9785         * DumpRenderTree/chromium/LayoutTestController.h: Removed.
9786         * DumpRenderTree/chromium/TestShell.cpp:
9787         * DumpRenderTree/chromium/TestShell.h:
9788         * DumpRenderTree/chromium/WebPermissions.cpp:
9789         * DumpRenderTree/chromium/WebViewHost.cpp:
9790         * DumpRenderTree/efl/CMakeLists.txt:
9791         * DumpRenderTree/efl/DumpRenderTree.cpp:
9792         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
9793         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
9794         * DumpRenderTree/efl/EditingCallbacks.cpp:
9795         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
9796         * DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
9797         * DumpRenderTree/gtk/DumpRenderTree.cpp:
9798         * DumpRenderTree/gtk/EditingCallbacks.cpp:
9799         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
9800         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
9801         * DumpRenderTree/mac/DumpRenderTree.mm:
9802         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
9803         * DumpRenderTree/mac/EditingDelegate.mm:
9804         * DumpRenderTree/mac/FrameLoadDelegate.mm:
9805         * DumpRenderTree/mac/HistoryDelegate.mm:
9806         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
9807         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
9808         * DumpRenderTree/mac/PolicyDelegate.mm:
9809         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
9810         * DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
9811         * DumpRenderTree/mac/UIDelegate.mm:
9812         * DumpRenderTree/qt/DumpRenderTree.pro:
9813         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
9814         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
9815         * DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
9816         * DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
9817         * DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.
9818         (WebCore):
9819         (LayoutTestController):
9820         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
9821         (LayoutTestController::dumpSelectionRect):
9822         (LayoutTestController::setCallCloseOnWebViews):
9823         (LayoutTestController::addDisallowedURL):
9824         (LayoutTestController::abortModal):
9825         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
9826         * DumpRenderTree/win/DumpRenderTree.cpp:
9827         * DumpRenderTree/win/DumpRenderTree.vcproj:
9828         * DumpRenderTree/win/EditingDelegate.cpp:
9829         * DumpRenderTree/win/FrameLoadDelegate.cpp:
9830         * DumpRenderTree/win/HistoryDelegate.cpp:
9831         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
9832         * DumpRenderTree/win/PolicyDelegate.cpp:
9833         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
9834         * DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.
9835         (LayoutTestController::setUserStyleSheetEnabled):
9836         (resolveCygwinPath):
9837         * DumpRenderTree/win/UIDelegate.cpp:
9838         * DumpRenderTree/wscript:
9839         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
9840         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
9841         * DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.
9842
9843 2012-08-13  Alex Christensen  <alex.christensen@flexsim.com>
9844
9845         Windows 64 bit compliance
9846         https://bugs.webkit.org/show_bug.cgi?id=93275
9847
9848         Reviewed by Brent Fulgham.
9849
9850         Fixed a few compile and link problems for Win64
9851
9852         * WinLauncher/WinLauncher.cpp:
9853         * win/DLLLauncher/DLLLauncherMain.cpp:
9854
9855 2012-08-13  MORITA Hajime  <morrita@google.com>
9856
9857         Unreviewed update for webcomponents-bugzilla address.
9858
9859         * Scripts/webkitpy/common/config/committers.py:
9860
9861 2012-08-11  Raphael Kubo da Costa  <rakuco@webkit.org>
9862
9863         [CMake] Rewrite FindLibSoup2.cmake.
9864         https://bugs.webkit.org/show_bug.cgi?id=93191
9865
9866         Reviewed by Rob Buis.
9867
9868         * DumpRenderTree/efl/CMakeLists.txt: Use LIBSOUP_FOO instead of
9869         LIBSOUP24_FOO, and do not use LIBSOUP24_LDFLAGS, as it is not
9870         needed anymore.
9871         * EWebLauncher/CMakeLists.txt: Ditto.
9872         * MiniBrowser/efl/CMakeLists.txt: Ditto.
9873         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
9874         * WebKitTestRunner/CMakeLists.txt: Ditto.
9875         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
9876
9877 2012-08-13  Brady Eidson  <beidson@apple.com>
9878
9879         With asynchronous plug-in initialization, WebProcess and PluginProcess can deadlock
9880         <rdar://problem/12062125> and https://bugs.webkit.org/show_bug.cgi?id=93894
9881
9882         Reviewed by Alexey Proskuryakov.
9883
9884         Add a test that calls out to NPP_Evaluate for some JS inside of NPP_New.
9885
9886         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9887         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp: Added.
9888         (EvaluteJSWithinNPP_New):
9889         (EvaluteJSWithinNPP_New::EvaluteJSWithinNPP_New):
9890         (EvaluteJSWithinNPP_New::NPP_New):
9891
9892 2012-08-13  Sheriff Bot  <webkit.review.bot@gmail.com>
9893
9894         Unreviewed, rolling out r125422.
9895         http://trac.webkit.org/changeset/125422
9896         https://bugs.webkit.org/show_bug.cgi?id=93902
9897
9898         Broke the Android canary build (Requested by fmalita on
9899         #webkit).
9900
9901         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
9902         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
9903
9904 2012-08-13  Raphael Kubo da Costa  <rakuco@webkit.org>
9905
9906         [CMake] Remove glib-related Find modules and write single new one instead.
9907         https://bugs.webkit.org/show_bug.cgi?id=93786
9908
9909         Reviewed by Rob Buis.
9910
9911         * DumpRenderTree/efl/CMakeLists.txt: Use GLIB_* instead of Glib_*.
9912         * EWebLauncher/CMakeLists.txt: Ditto.
9913         * MiniBrowser/efl/CMakeLists.txt: Ditto.
9914         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
9915
9916 2012-08-13  Peter Beverloo  <peter@chromium.org>
9917
9918         [Chromium] Fix apk generation for the Android platform
9919         https://bugs.webkit.org/show_bug.cgi?id=93841
9920
9921         Reviewed by Dimitri Glazkov.
9922
9923         APK generation was broken as the configuration file assumed compilation
9924         would only occur in the Chromium tree. Pass the path to Chromium's source
9925         base directory as a property to ant.
9926
9927         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
9928         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
9929
9930 2012-08-13  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
9931
9932         [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
9933         https://bugs.webkit.org/show_bug.cgi?id=93825
9934
9935         Reviewed by Antonio Gomes.
9936
9937         Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke. 
9938
9939         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
9940         (WTR::InjectedBundlePage::didFailLoadForResource):
9941
9942 2012-08-13  Kwang Yul Seo  <skyul@company100.net>
9943
9944         [Qt] Add gprof.prf to build WebKit with gprof enabled
9945         https://bugs.webkit.org/show_bug.cgi?id=90283
9946
9947         Reviewed by Eric Seidel.
9948
9949         * qmake/mkspecs/features/functions.prf:
9950         gprof does not support profiling a shared library.
9951         To profile WebKit, applications must link QtWebKit statically.
9952
9953         * qmake/mkspecs/features/gprof.prf: Added.
9954         Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.
9955
9956 2012-08-13  KwangYong Choi  <ky0.choi@samsung.com>
9957
9958         [TestNetscapePlugin][X11] Additional key up event handler routine is required
9959         https://bugs.webkit.org/show_bug.cgi?id=91357
9960
9961         Reviewed by Eric Seidel.
9962
9963         Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
9964         has-focus.html on X11 architecture. The test can not be done without this patch.
9965         All other ports implemented it already.
9966
9967         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
9968         (handleEventX11): Modified key up event handler for X11
9969
9970 2012-08-13  Christophe Dumez  <christophe.dumez@intel.com>
9971
9972         [EFL][WK2] Replace Skipped list by TestExpectations
9973         https://bugs.webkit.org/show_bug.cgi?id=93796
9974
9975         Reviewed by Kenneth Rohde Christiansen.
9976
9977         Enable cascaded TestExpectations for EFL port so
9978         that we can use TestExpectations in WK2-EFL.
9979
9980         * Scripts/webkitpy/layout_tests/port/efl.py:
9981         (EflPort._search_paths):
9982         (EflPort):
9983         (EflPort.expectations_files):
9984
9985 2012-08-13  Peter Gal  <galpeter@inf.u-szeged.hu>
9986
9987         REGRESSION(r125153): It broke the 'Unexpected no expected results' case
9988         https://bugs.webkit.org/show_bug.cgi?id=93789
9989
9990         Reviewed by Csaba Osztrogonác.
9991
9992         Fix the regex, so the text won't be a capturing group.
9993
9994         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9995         (RunWebKitTests._parseNewRunWebKitTestsOutput):
9996
9997 2012-08-12  MORITA Hajime  <morrita@google.com>
9998
9999         Unreviewed, added a proxy address to contributors_who_are_not_committers.
10000
10001         * Scripts/webkitpy/common/config/committers.py:
10002
10003 2012-08-12  Loïc Yhuel  <loic.yhuel@softathome.com>
10004
10005         [Qt] Make it possible to build without QtTest/QtPrintSupport
10006         https://bugs.webkit.org/show_bug.cgi?id=93492
10007
10008         Reviewed by Tor Arne Vestbø.
10009
10010         * DumpRenderTree/qt/DumpRenderTree.pro: Optional printsupport
10011         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
10012         (WebCore):
10013         (WebCore::DumpRenderTree::dryRunPrint): Does nothing if no printsupport
10014         * QtTestBrowser/QtTestBrowser.pro: Optional printsupport
10015         * QtTestBrowser/launcherwindow.cpp:
10016         (LauncherWindow::createChrome): No print menu if no printsupport
10017         (LauncherWindow::print): Does nothing if no printsupport
10018         * QtTestBrowser/launcherwindow.h:
10019         * Tools.pro: Disable DRT/WTR if QtTest not present
10020         * qmake/mkspecs/features/default_pre.prf: printsupport no more mandatory
10021         * qmake/mkspecs/features/features.prf: Qt module availability tests
10022
10023 2012-08-12  Csaba Osztrogonác  <ossy@webkit.org>
10024
10025         master.cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
10026         https://bugs.webkit.org/show_bug.cgi?id=90161
10027
10028         Reviewed by Eric Seidel.
10029
10030         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
10031
10032 2012-08-12  Simon Hausmann  <simon.hausmann@nokia.com>
10033
10034         [Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindowsysteminterface.h
10035         through the QTestLib headers anymore.
10036
10037         * DumpRenderTree/qt/EventSenderQt.cpp:
10038         * WebKitTestRunner/Target.pri:
10039         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
10040
10041 2012-08-11  Sam Weinig  <sam@webkit.org>
10042
10043         Remove ability to run MiniBrowser in threaded mode, it hasn't worked for a long time
10044         https://bugs.webkit.org/show_bug.cgi?id=93774
10045
10046         Reviewed by Dan Bernstein.
10047
10048         Remove support for opening windows using the shared thread WKContextRef. WKContextGetSharedThreadContext()
10049         is going away, due to not working for a long time, and the first step is removing all the callers.
10050
10051         While here, remove the BrowserStatisticsWindow, which was not providing interesting information.
10052
10053         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
10054         * MiniBrowser/mac/AppDelegate.h:
10055         * MiniBrowser/mac/AppDelegate.m:
10056         (-[BrowserAppDelegate init]):
10057         (-[BrowserAppDelegate newWindow:]):
10058         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
10059         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Removed.
10060         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Removed.
10061         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Removed.
10062         * MiniBrowser/mac/MainMenu.xib:
10063         * MiniBrowser/win/BrowserView.cpp:
10064         (BrowserView::create):
10065
10066 2012-08-11  Sam Weinig  <sam@webkit.org>
10067
10068         Enable XPC Service based WebProcess with runtime flag
10069         https://bugs.webkit.org/show_bug.cgi?id=93773
10070
10071         Reviewed by Dan Bernstein.
10072
10073         Convert --use-web-process-xpc-service passed to run-safari (and similar scripts)
10074         to setting WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS=YES in the environment and setting
10075         up __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_INSERT_LIBRARIES variables. NOTE: using
10076         the XPC service is not the default code path.
10077
10078         * Scripts/webkitdirs.pm:
10079         (shouldUseXPCServiceForWebProcess):
10080         (determineShouldUseXPCServiceForWebProcess):
10081         Add functions to extract --use-web-process-xpc-service from ARGV and set a
10082         global variable.
10083
10084         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
10085         Add help text for --use-web-process-xpc-service.
10086
10087         (runMacWebKitApp):
10088         Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
10089         if --use-web-process-xpc-service was passed on the command line.
10090
10091         (execMacWebKitAppForDebugging):
10092         Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
10093         if --use-web-process-xpc-service was passed on the command line. Also, bail
10094         if both --use-web-process-xpc-service and --target-web-process are passed on
10095         the command line, as we don't currently support using both.
10096
10097 2012-08-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
10098
10099         [EFL] Bump harfbuzz dependency to v0.9.2
10100         https://bugs.webkit.org/show_bug.cgi?id=93762
10101
10102         Reviewed by Eric Seidel.
10103
10104         EFL port has used harfbuzz 0.9.0 ver. However, the 0.9.2 version was released on 10th Aug 2012.
10105         In addition, 0.9.0 ver. was disappeared. So, EFL port needs to use 0.9.2 ver. from now on.
10106
10107         * efl/jhbuild.modules:
10108
10109 2012-08-10  Ryosuke Niwa  <rniwa@webkit.org>
10110
10111         run-perf-tests should upload memory statistics to perf-o-matic
10112         https://bugs.webkit.org/show_bug.cgi?id=93690
10113
10114         Reviewed by Dirk Pranke.
10115
10116         Upload JS Heap and FastMalloc results for a test X/Y as: X/Y:JSHeap and X/Y:FastMalloc.
10117         Note "JS Heap" is converted to the CamelCase JSHeap.
10118
10119         Also did some refactoring in PerfTest.parse_output and PerfTestRunnerTest and updated
10120         some helps in PerfTest.parse_output per arv's comments.
10121
10122         * Scripts/webkitpy/performance_tests/perftest.py:
10123         (PerfTest):
10124         (PerfTest.parse_output): Include JSHeap and FastMalloc statistics in results as well as of Time.
10125         Also refactored it to avoid hard-coding indices in _result_classes and moved complied regular
10126         exressions out of the function to avoid re-compiling them every time the method runs.
10127         (PerfTest.output_statistics): Convert ':' to ': ' as well as '/'.
10128         (ChromiumStylePerfTest.parse_output): Removed an unused variable.
10129         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
10130         (PerfTestsRunner._parse_args): Uploaded some helps per arv's feedback.
10131         (PerfTestsRunner._output_json_path): Extracted from _generate_and_show_results to be used in
10132         PerfTestRunnerTest.create_runner.
10133         (PerfTestsRunner._generate_and_show_results):
10134         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
10135         (create_runner): Extracted runner.load_output_json from various tests.
10136         (test_run_memory_test): Added.
10137         (PerfTestRunner): Extracted _event_target_wrapper_and_inspector_results from various tests.
10138         (test_run_with_json_output):
10139         (test_run_with_description):
10140         (test_run_generates_json_by_default):
10141         (test_run_generates_and_show_results_page):
10142         (test_run_with_json_source):
10143         (test_run_with_multiple_repositories):
10144
10145 2012-08-10  Benjamin Poulain  <bpoulain@apple.com>
10146
10147         Add support for String initialization from literal to WTFString
10148         https://bugs.webkit.org/show_bug.cgi?id=93426
10149
10150         Reviewed by Anders Carlsson.
10151
10152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10153         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
10154         (TestWebKitAPI::TEST):
10155         * TestWebKitAPI/Tests/WTF/WTFString.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp.
10156         (TestWebKitAPI):
10157         (TestWebKitAPI::TEST):
10158
10159 2012-08-10  Xianzhu Wang  <wangxianzhu@chromium.org>
10160
10161         NRWT crashes when DRT with --encode-binary crashes just before it dumps pixels
10162         https://bugs.webkit.org/show_bug.cgi?id=93728
10163
10164         Reviewed by Dirk Pranke.
10165
10166         * Scripts/webkitpy/layout_tests/port/driver.py:
10167         (ContentBlock.decode_content): Check self.content is not None before calling base64.b64decode().
10168
10169 2012-08-10  Xianzhu Wang  <wangxianzhu@chromium.org>
10170
10171         [Chromium-Android][NRWT] Executable might not be pushed correctly when there are multiple builds
10172         https://bugs.webkit.org/show_bug.cgi?id=93688
10173
10174         Reviewed by Dirk Pranke.
10175
10176         There might be other better methods, but this change is the smallest.
10177         I think the chance of equal timestamp can be ignored because we flock
10178         to avoid concurrent linkers.
10179
10180         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
10181         (ChromiumAndroidDriver._push_executable): Changed '<' to '!=' to compare the timestamp.
10182
10183 2012-08-09  Xianzhu Wang  <wangxianzhu@chromium.org>
10184
10185         [Chromium-Android] Skip layout tests directories that are not applicable
10186         https://bugs.webkit.org/show_bug.cgi?id=93670
10187
10188         Reviewed by Dirk Pranke.
10189
10190         Added back ChromiumAndroidPort.skipped_layout_tests to skip some whole directories.
10191         The method is more convenient to skip whole directories than SKIP in TestExpectations
10192         because its higher priority. Will still use TestExpectations to skip individual tests.
10193
10194         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
10195         (ChromiumAndroidPort.skipped_layout_tests):
10196
10197 2012-08-09  Elliott Sprehn  <esprehn@chromium.org>
10198
10199         Add myself to the Contributor list.
10200         https://bugs.webkit.org/show_bug.cgi?id=93653
10201
10202         Reviewed by Dirk Pranke.
10203
10204         Add my email to the contributor list.
10205
10206         * Scripts/webkitpy/common/config/committers.py:
10207
10208 2012-08-09  Dirk Pranke  <dpranke@chromium.org>
10209
10210         nrwt: should log progress like ninja does
10211         https://bugs.webkit.org/show_bug.cgi?id=93563
10212
10213         Reviewed by Ojan Vafai.
10214
10215         This change modifies the output of nrwt in the
10216         non--debug-rwt-logging modes.
10217
10218         In non-verbose mode, the output changes from:
10219           "Testing (50%): 96 ran as expected, 4 didn't, 100 left"
10220         to:
10221           "[100/200] foo.html (+4)"
10222         or:
10223           "[100/200] foo.html failed  unexpectedly (text diff)"
10224
10225         which indicates the earliest test currently running (optionally plus the
10226         count of other currently-executing tests if we're running tests in parallel)
10227         or the result of said test.
10228
10229         If the test produces unexpected results, that line is flushed
10230         rather than erased (so we no longer need the %d didn't running
10231         tally).
10232
10233         In --verbose mode, the output is similar, but every test gets a
10234         line (and tests are logged in order of them being started, not
10235         order of them being completed) (and in --details mode, the
10236         first line of each test matches --verbose but the other lines
10237         are unchanged).
10238         
10239         The overall result should be easier to read and is simpler to
10240         implement as well (apart from managing the number of tests that
10241         have started but not completed, which is slightly annoying).
10242
10243         This also matches the output style for test-webkitpy, more-or-less.
10244
10245         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
10246         (LayoutTestRunner.run_tests):
10247         (LayoutTestRunner._update_summary_with_result):
10248         (LayoutTestRunner._handle_started_test):
10249         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
10250         (FakePrinter):
10251         (FakePrinter.print_started_test):
10252         (FakePrinter.print_finished_test):
10253         * Scripts/webkitpy/layout_tests/views/printing.py:
10254         (Printer.__init__):
10255         (Printer.print_started_test):
10256         (Printer.print_finished_test):
10257         (Printer._print_test_trace):
10258         (Printer._print_progress):
10259         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
10260         (test_details):
10261
10262 2012-08-09  Alexey Proskuryakov  <ap@apple.com>
10263
10264         [WK2] Add a process model constant for multiple processes
10265         https://bugs.webkit.org/show_bug.cgi?id=93642
10266
10267         Reviewed by Anders Carlsson.
10268
10269         * MiniBrowser/mac/AppDelegate.h: Updated process model enum to match WebKit.
10270
10271 2012-08-09  Ryosuke Niwa  <rniwa@webkit.org>
10272
10273         Build fix after r125178.
10274
10275         * Scripts/webkitpy/performance_tests/perftest.py:
10276         (PerfTest.parse_output): Don't include non-time results in the JSON output.
10277         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated the test outputs so to match
10278         actual test outputs.
10279         (MainTest.test_parse_output):
10280         (MainTest.test_parse_output_with_failing_line):
10281         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Ditto.
10282
10283 2012-08-09  Zoltan Horvath  <zoltan@webkit.org>
10284
10285         JSHeap and FastMallocStatistics based memory measurement for performance-tests
10286         https://bugs.webkit.org/show_bug.cgi?id=90858
10287
10288         Reviewed by Ryosuke Niwa.
10289
10290         Measure the memory usage of the performancetests with the help of the windows.memory.usedJSHeapSize
10291         object and the window.internals.fastMallocStatistics() function call.
10292
10293         * Scripts/webkitpy/performance_tests/perftest.py:
10294         (PerfTest):
10295         (PerfTest.parse_output):
10296         (PerfTest.output_statistics):
10297
10298 2012-08-09  Csaba Osztrogonác  <ossy@webkit.org>
10299
10300         [Qt][Win] Build system bug revealed by r124835
10301         https://bugs.webkit.org/show_bug.cgi?id=93339
10302
10303         Reviewed by Tor Arne Vestbø.
10304
10305         Don't add "LC_ALL=c" on Windows in svnRevisionForDirectory() and in pathRelativeToSVNRepositoryRootForPath().
10306
10307         * Scripts/VCSUtils.pm:
10308         (isWindows): Copied from webkitdirs.pm.
10309         (svnRevisionForDirectory):
10310         (pathRelativeToSVNRepositoryRootForPath):
10311
10312 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
10313
10314         update bot parsing of new-run-webkit-tests' output
10315         https://bugs.webkit.org/show_bug.cgi?id=93537
10316
10317         Reviewed by Ryosuke Niwa.
10318
10319         This change updates the way we parse the output from
10320         new-run-webkit-tests on the bots so that we can show a summary
10321         of the results properly after I re-land the changes that were
10322         reverted in r124994 and r124870.
10323
10324         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10325         (RunWebKitTests._parseNewRunWebKitTestsOutput):
10326
10327 2012-08-08  Shane Stephens  <shanestephens@google.com>
10328
10329         Compile flag for CSS Hierarchies
10330         https://bugs.webkit.org/show_bug.cgi?id=92433
10331
10332         Reviewed by Tony Chang.
10333
10334         * Scripts/webkitperl/FeatureList.pm:
10335         * qmake/mkspecs/features/features.pri:
10336
10337 2012-08-08  Benjamin Poulain  <bpoulain@apple.com>
10338
10339         Use char* instead of LChar* for the public interface of String construction from literals
10340         https://bugs.webkit.org/show_bug.cgi?id=93402
10341
10342         Reviewed by Michael Saboff.
10343
10344         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
10345         (TestWebKitAPI::TEST):
10346
10347 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
10348
10349         nrwt: rename finder.py to layout_test_finder.py
10350         https://bugs.webkit.org/show_bug.cgi?id=93557
10351
10352         Reviewed by Ryosuke Niwa.
10353
10354         One last cleanup per old review feedback from rniwa.
10355
10356         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/finder.py.
10357         (LayoutTestFinder):
10358         (LayoutTestFinder.__init__):
10359         (LayoutTestFinder.find_tests):
10360         (LayoutTestFinder._strip_test_dir_prefixes):
10361         (LayoutTestFinder._strip_test_dir_prefix):
10362         (LayoutTestFinder._read_test_names_from_file):
10363         (LayoutTestFinder._strip_comments):
10364         (LayoutTestFinder.skip_tests):
10365         (LayoutTestFinder.split_into_chunks):
10366         * Scripts/webkitpy/layout_tests/controllers/manager.py:
10367
10368 2012-08-08  Ryosuke Niwa  <rniwa@webkit.org>
10369
10370         Add Perf EWS IRC bot
10371         https://bugs.webkit.org/show_bug.cgi?id=92913
10372
10373         Reviewed by Dirk Pranke.
10374
10375         Adds the preliminary implementation of perfalizer, a IRC bot that runs performance tests
10376         based on IRC requests.
10377
10378         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
10379         (MockSCM.head_svn_revision): The actual implementation returns string, so match that.
10380         (MockSCM.svn_revision): Ditto.
10381         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
10382         (Bugzilla.add_attachment_to_bug): Added mimetype.
10383         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
10384         (MockBugzilla.add_attachment_to_bug): Ditto.
10385         * Scripts/webkitpy/common/system/filesystem.py:
10386         (FileSystem.copytree): Added.
10387         * Scripts/webkitpy/common/system/filesystem_mock.py:
10388         (MockFileSystem.copytree): Added.
10389         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Rebaselined tests
10390         that had assumed revision numbers were integers.
10391         (test_run_with_json_output):
10392         (test_run_with_description):
10393         (test_run_generates_json_by_default):
10394         (test_run_generates_and_show_results_page):
10395         (test_run_with_json_source):
10396         (test_run_with_multiple_repositories):
10397         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
10398         * Scripts/webkitpy/tool/commands/__init__.py:
10399         * Scripts/webkitpy/tool/commands/perfalizer.py: Added.
10400         (PerfalizerTask):
10401         (PerfalizerTask.__init__):
10402         (PerfalizerTask._copy_build_product_without_patch):
10403         (PerfalizerTask.run):
10404         (PerfalizerTask.parent_command):
10405         (PerfalizerTask.run_webkit_patch):
10406         (PerfalizerTask._json_path):
10407         (PerfalizerTask._results_page_path):
10408         (PerfalizerTask._run_perf_test):
10409         (PerfalizerTask.run_command):
10410         (PerfalizerTask.command_passed):
10411         (PerfalizerTask.command_failed):
10412         (PerfalizerTask.refetch_patch):
10413         (PerfalizerTask.expected_failures):
10414         (PerfalizerTask.build_style):
10415         (PerfTest): IRC command.
10416         (PerfTest.execute):
10417         (Perfalizer): IRC bot.
10418         (Perfalizer.begin_work_queue):
10419         (Perfalizer.work_item_log_path):
10420         (Perfalizer._is_old_failure):
10421         (Perfalizer.next_work_item):
10422         (Perfalizer.process_work_item):
10423         (Perfalizer.handle_unexpected_error):
10424         (Perfalizer.handle_script_error):
10425         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py: Added.
10426         (PerfalizerTaskTest):
10427         (PerfalizerTaskTest._create_and_run_perfalizer):
10428         (PerfalizerTaskTest._create_and_run_perfalizer.logger):
10429         (PerfalizerTaskTest._create_and_run_perfalizer.run_webkit_patch):
10430         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
10431         (PerfalizerTaskTest.test_run):
10432         (PerfalizerTaskTest.test_run_with_clean_fails):
10433         (PerfalizerTaskTest.test_run_with_update_fails):
10434         (PerfalizerTaskTest.test_run_with_build_fails):
10435         (PerfalizerTaskTest.test_run_with_perf_test_fails):
10436         (PerfalizerTaskTest.test_run_without_results_page):
10437         * Scripts/webkitpy/tool/commands/queues_unittest.py:
10438         (AbstractPatchQueueTest.test_upload_results_archive_for_patch): Rebaselined.
10439         * Scripts/webkitpy/tool/commands/upload_unittest.py:
10440         (test_attach_to_bug): Ditto.
10441         (test_attach_to_bug_no_description_or_comment): Ditto.
10442
10443 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
10444
10445         webkit-patch rebaseline-expectations needs to support multiple expectations files
10446         https://bugs.webkit.org/show_bug.cgi?id=89051
10447
10448         Reviewed by Adam Barth.
10449
10450         fixed the bug described above, added unit test in
10451         test_expectations_unittest, and updated the tool tests
10452         to not contain all of the "missing skia expectations" warnings.
10453
10454         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
10455         (TestExpectations.remove_rebaselined_tests):
10456         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
10457         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
10458         (RebaseliningTest.assertRemove):
10459         (RebaseliningTest.test_remove):
10460         * Scripts/webkitpy/tool/commands/rebaseline.py:
10461         (RebaselineExpectations._update_expectations_files):
10462         (RebaselineExpectations.execute):
10463         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
10464         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
10465         (test_rebaseline_expectations):
10466
10467 2012-08-08  Alexey Proskuryakov  <ap@apple.com>
10468
10469         [WK2] MiniBrowser crashes on quit if any windows were previously closed
10470         https://bugs.webkit.org/show_bug.cgi?id=93529
10471
10472         Reviewed by John Sullivan.
10473
10474         * MiniBrowser/mac/AppDelegate.h:
10475         * MiniBrowser/mac/AppDelegate.m:
10476         (-[BrowserAppDelegate init]):
10477         (-[BrowserAppDelegate newWindow:]):
10478         (-[BrowserAppDelegate browserWindowWillClose:]):
10479         (-[BrowserAppDelegate applicationWillTerminate:]):
10480         (-[BrowserAppDelegate frontmostBrowserWindowController]):
10481         Track browser windows explicitly, not relying on [NSApp windows]. Closed windows
10482         are not automatically removed from the list until deallocated, so a refcounting
10483         error can result in working on a closed window.
10484
10485         * MiniBrowser/mac/BrowserWindowController.m:
10486         (-[BrowserWindowController dealloc]): Moved code from -windowWillClose: here.
10487         Releasing data members is -dealloc's job.
10488         (-[BrowserWindowController windowWillClose:]): Notify BrowserAppDelegate that
10489         the window is no longer open. Autorelease self, making sure that WKView and
10490         then WebPageProxy get released.
10491         (-[BrowserWindowController applicationTerminating]): Don't release _webView.pageRef.
10492         WKView is responsible for its lifetime.
10493         (closePage): Ditto.
10494
10495 2012-08-08  Xianzhu Wang  <wangxianzhu@chromium.org>
10496
10497         [Chromium-Android] Apply all Linux layout test expectations
10498         https://bugs.webkit.org/show_bug.cgi?id=92653
10499
10500         Reviewed by Adam Barth.
10501
10502         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
10503         (ChromiumAndroidPort.skipped_layout_tests): Removed. Skip these tests in TestExpectations instead.
10504
10505 2012-08-08  Josh Hawn  <jhawn@apple.com>
10506
10507         Add MountainLion WebKit Bots.
10508         https://bugs.webkit.org/show_bug.cgi?id=93417
10509
10510         Reviewed by Stephanie Lewis.
10511
10512         Mountain Lion is now available, so we've added the appropriate Apple bots,
10513         mirroring the configuration of the Lion bots.
10514
10515         * BuildSlaveSupport/build.webkit.org-config/config.json:
10516         Added 10 "apple-mini-###" slaves.
10517         Added MountainLion Builders and Schedulers.
10518
10519 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
10520
10521         [WK2] Coding style violation was brought with r125031
10522         https://bugs.webkit.org/show_bug.cgi?id=93503
10523
10524         Reviewed by Alexey Proskuryakov.
10525
10526         WKURLResponseCopyMimeType is corrected to WKURLResponseCopyMIMEType.
10527
10528         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
10529         (WTR::InjectedBundlePage::didReceiveResponseForResource):
10530         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
10531         (WTR::LayoutTestController::dumpProgressFinishedCallback): Removed trailing whitespace that was brought with the same revision.
10532
10533 2012-08-08  Peter Beverloo  <peter@chromium.org>
10534
10535         Buildmaster changes in preparation of a Chromium Android tester
10536         https://bugs.webkit.org/show_bug.cgi?id=92251
10537
10538         Reviewed by Adam Barth.
10539
10540         Slightly update the build master's configuration in preparation of adding
10541         a Chromium Android tester.
10542
10543         The change in built-product-archive is required as the out/ directory
10544         for Android has a number of unstripped .so binaries and unaligned APKs,
10545         causing the default release.zip file to be 2.7 gigabytes. By excluding
10546         these file types, the file is only 59.7 megabytes. We can't disable
10547         them for all of Chromium, as Mac and Linux do use their .so files.
10548
10549         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10550         (ArchiveBuiltProduct): Pass the full platform name instead of just the
10551             generic type, i.e. chromium-android instead of chromium.
10552         (ExtractBuiltProduct): Dito, stay consistent for this script.
10553         (RunUnitTests): Pass --chromium-android as well as --chromium. Since we
10554             now read the full platform name, stay on the safe side with 'win'
10555             even though there (as far as I know) is no win-* platform.
10556         (RunChromiumWebKitUnitTests): Dito. The platform wasn't being passed
10557             at all, but we'll be needing different handling here.
10558         (unitTestsSupported): Next to refactoring work required, as we'll be
10559             running this test on a device, there is no reason to disable this
10560             in the master's configuration.
10561         * BuildSlaveSupport/built-product-archive:
10562         (main): Determine the generic platform.
10563         (archiveBuiltProduct): Use an identical set of ignorePatterns, but
10564             extend the list with .so, .pak and -unaligned.apk for Android.
10565
10566 2012-08-08  Adam Barth  <abarth@webkit.org>
10567
10568         Unreviewed. Stop running tests on the mac-ews while we wait for more
10569         hardware. As requested by lforschler.
10570
10571         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
10572
10573 2012-08-08  Peter Beverloo  <peter@chromium.org>
10574
10575         The cr-android EWS should actually be building Chromium for Android
10576         https://bugs.webkit.org/show_bug.cgi?id=93489
10577
10578         Reviewed by Adam Barth.
10579
10580         The cr-android EWS bots should be building Chromium for Android, which
10581         requires some additional flags to Chromium's default configuration.
10582
10583         * Scripts/webkitdirs.pm:
10584         (buildChromium):
10585         * Scripts/webkitpy/common/config/ports.py:
10586         (DeprecatedPort.port):
10587         (ChromiumAndroidPort):
10588         (ChromiumAndroidPort.update_webkit_command):
10589         (ChromiumAndroidPort.build_webkit_command):
10590         * Scripts/webkitpy/common/config/ports_unittest.py:
10591         (DeprecatedPortTest.test_chromium_android_port):
10592         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
10593         (ChromiumAndroidEWS):
10594         * Scripts/webkitpy/tool/steps/update_unittest.py:
10595         (UpdateTest.test_update_command_non_interactive):
10596         (UpdateTest.test_update_command_interactive):
10597
10598 2012-08-08  Alexey Proskuryakov  <ap@apple.com>
10599
10600         [WK2] MiniBrowser crashes on window.open()
10601         https://bugs.webkit.org/show_bug.cgi?id=93413
10602
10603         Reviewed by Dan Bernstein.
10604
10605         * MiniBrowser/mac/BrowserWindowController.m: (createNewPage): This is a "create"
10606         API, so it needs to return a retained result.
10607
10608         * MiniBrowser/mac/WebBundle/WebBundleMain.m: (didClearWindowObjectForFrame):
10609         When this function is called, URL appears to be poorly defined. Sometimes, it's
10610         the new URL, other times it's the old one. An "old" URL is null in a new page.
10611
10612 2012-08-08  Loïc Yhuel  <loic.yhuel@softathome.com>
10613
10614         [Qt] Compile errors with OpenGLES2
10615         https://bugs.webkit.org/show_bug.cgi?id=93206
10616
10617         Reviewed by Noam Rosenthal.
10618
10619         Fix build with OpenGLES2 on Linux desktop
10620
10621         * qmake/mkspecs/features/features.prf: Don't use GLX with OpenGLES2
10622
10623 2012-08-08  Peter Beverloo  <peter@chromium.org>
10624
10625         Introduce cr-android bots in the EWS system
10626         https://bugs.webkit.org/show_bug.cgi?id=93472
10627
10628         Reviewed by Adam Barth.
10629
10630         This adds the queue to the EWS scripts. Two builders are ready to be
10631         attached to the queue. All webkitpy tests pass with this change applied.
10632
10633         * QueueStatusServer/model/queues.py:
10634         (Queue):
10635         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
10636         (ChromiumAndroidEWS):
10637         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
10638         (EarlyWarningSytemTest.test_builder_ewses):
10639
10640 2012-08-08  Carlos Garcia Campos  <cgarcia@igalia.com>
10641
10642         Unreviewed. Fix GTK+ build with GTK2 after r121475.
10643
10644         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Add missing
10645         include required when building with GTK2.
10646
10647 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
10648
10649         [WK2] [WTR] Provide Resource Response dumping.
10650         https://bugs.webkit.org/show_bug.cgi?id=93454
10651
10652         Reviewed by Kenneth Rohde Christiansen.
10653
10654         Added missing dumpResourceResponseMIMETypes() method to testRunner. Provided resource response dumping.
10655
10656         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
10657         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
10658         (WTR::InjectedBundlePage::didReceiveResponseForResource):
10659         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
10660         (WTR::LayoutTestController::LayoutTestController):
10661         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
10662         (WTR::LayoutTestController::dumpProgressFinishedCallback):
10663         (WTR::LayoutTestController::dumpResourceResponseMIMETypes):
10664         (WTR::LayoutTestController::shouldDumpResourceResponseMIMETypes):
10665         (LayoutTestController):
10666
10667 2012-08-08  Simon Hausmann  <simon.hausmann@nokia.com>
10668
10669         [Qt][Win] Fix compilation of DumpRenderTree
10670         https://bugs.webkit.org/show_bug.cgi?id=93461
10671
10672         Reviewed by Tor Arne Vestbø.
10673
10674         DRT includes stdint.h, for which we have wrappers in Source/JavaScriptCore/os-win32. Use these not only
10675         for libraries but any building template.
10676
10677         * qmake/mkspecs/features/default_post.prf:
10678
10679 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
10680
10681         [WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCallback() should be const
10682         https://bugs.webkit.org/show_bug.cgi?id=93457
10683
10684         Reviewed by Csaba Osztrogonác.
10685
10686         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
10687         (WTR::LayoutTestController::shouldDumpProgressFinishedCallback): Added constness.
10688
10689 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
10690
10691         Unreviewed typo fix after r124988.
10692
10693         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
10694         (TestExpectations):
10695
10696 2012-08-07  YoungTaeck Song  <youngtaeck.song@samsung.com>
10697
10698         [WK2][EFL] Implement accelerated compositing on WK2 Efl port
10699         https://bugs.webkit.org/show_bug.cgi?id=89840
10700
10701         Reviewed by Noam Rosenthal.
10702
10703         Implement accelerated composition with TiledBackingStore on WK2 Efl port.
10704         Add OPENGL_LIBRARIES in CMakeList.txt.
10705
10706         * MiniBrowser/efl/CMakeLists.txt:
10707         * WebKitTestRunner/PlatformEfl.cmake:
10708
10709 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
10710
10711         [NRWT] REGRESSION(r124967): New tests without expected results handled as failures
10712         https://bugs.webkit.org/show_bug.cgi?id=93434
10713
10714         Reviewed by Tony Chang.
10715
10716         Change back "missing results" to "no expected result found", because master.cfg's results parser expects it.
10717
10718         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
10719         (TestExpectations):
10720
10721 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
10722
10723         buildbot: Remove the configuration of hfreyther*
10724         https://bugs.webkit.org/show_bug.cgi?id=91849
10725
10726         Unreviewed typo fix after r123757.
10727
10728         * BuildSlaveSupport/build.webkit.org-config/config.json:
10729
10730 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
10731
10732         REGRESSION: PrettyPatchTest.test_pretty_diff_encodings has been failing on Chromium Windows
10733         https://bugs.webkit.org/show_bug.cgi?id=93192
10734
10735         Unreviewed, build fix.
10736
10737         Disabling the test for now as PrettyPatch is just broken on win32.
10738
10739         * Scripts/webkitpy/common/prettypatch_unittest.py:
10740         (test_pretty_diff_encodings):
10741
10742 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
10743
10744         [NRWT] Would like an output mode similar to ORWT verbose one
10745         https://bugs.webkit.org/show_bug.cgi?id=88702
10746
10747         Reviewed by Ryosuke Niwa.
10748
10749         Change the --verbose logging for new-run-webkit-tests so that
10750         it matches ORWT more; we just print one line per test. Use
10751         --debug-rwt-logging to get the full debug stream (aka old ORWT
10752         --verbose).
10753
10754         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
10755         (TestExpectations):
10756         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10757         (_set_up_derived_options):
10758         (parse_args):
10759         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
10760         (MainTest.test_retrying_and_flaky_tests):
10761         * Scripts/webkitpy/layout_tests/views/printing.py:
10762         (print_options):
10763         (Printer._print_result_summary_entry):
10764         (Printer._print_one_line_summary):
10765         (Printer._print_test_result):
10766         (Printer._print_baseline):
10767         (Printer._print_unexpected_results):
10768
10769 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
10770
10771         nrwt: handle errors from image diff better
10772         https://bugs.webkit.org/show_bug.cgi?id=92934
10773
10774         Reviewed by Ojan Vafai.
10775
10776         Re-land the change in r124801 with a fix ... in the case where
10777         the ImageDiff is passed a tolerance and passes the fuzzy check,
10778         we were returning the wrong value (missing an empty error
10779         string) and crashing; this patch fixes that and adds a test for
10780         that case (TestImageDiffer.test_image_diff_passed).
10781
10782         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
10783         (SingleTestRunner._compare_image):
10784         (SingleTestRunner._compare_output_with_reference):
10785         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
10786         (write_test_result):
10787         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
10788         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
10789         (TestResultWriterTest):
10790         * Scripts/webkitpy/layout_tests/port/base.py:
10791         (Port.diff_image):
10792         * Scripts/webkitpy/layout_tests/port/chromium.py:
10793         (ChromiumPort.diff_image):
10794         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
10795         (ChromiumPortTestCase.test_diff_image_crashed):
10796         * Scripts/webkitpy/layout_tests/port/image_diff.py:
10797         (ImageDiffer.diff_image):
10798         (ImageDiffer._read):
10799         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
10800         (TestImageDiffer.test_diff_image):
10801         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
10802         (MockDRTPortTest.test_diff_image_crashed):
10803         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
10804         (PortTestCase.test_diff_image):
10805         (PortTestCase.test_diff_image_crashed):
10806         (PortTestCase.test_diff_image_crashed.make_proc):
10807         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
10808         (MockServerProcess.__init__):
10809         * Scripts/webkitpy/layout_tests/port/test.py:
10810         (TestPort.diff_image):
10811         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
10812         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
10813
10814 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
10815
10816         nrwt: --no-build isn't working
10817         https://bugs.webkit.org/show_bug.cgi?id=93415
10818
10819         Reviewed by Ryosuke Niwa.
10820
10821         Turns out our optimization to avoid calling
10822         webkit-build-directory N times for each worker broke --no-build.
10823
10824         Fixing, and adding a test.
10825
10826         Also, the gtk port wasn't using the default check_build() logic,
10827         but I don't know why not. Removing their custom hook and will
10828         verify that this is okay in the review ...
10829
10830         * Scripts/webkitpy/layout_tests/port/base.py:
10831         (Port.__init__):
10832         (Port.check_build):
10833         (Port._build_path):
10834         * Scripts/webkitpy/layout_tests/port/gtk.py:
10835         (GtkPort._path_to_image_diff):
10836         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
10837         (MockDRTPortTest.test_check_build):
10838         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
10839         (test_path_to_apache_config_file):
10840         (test_check_build):
10841         (test_check_build.build_driver_called):
10842
10843 2012-08-07  Ryosuke Niwa  <rniwa@webkit.org>
10844
10845         run-perf-tests should support --no-show-results
10846         https://bugs.webkit.org/show_bug.cgi?id=93409
10847
10848         Reviewed by Dirk Pranke.
10849
10850         Add the support for --no-show-results.
10851
10852         Also replace only local paths to jquery and flot instead of embedding them.
10853         The results page is still standalone in that it tries to load scripts
10854         from both webkit.org and local filesystem.
10855
10856         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
10857         (PerfTestsRunner._parse_args):
10858         (PerfTestsRunner.run):
10859         (PerfTestsRunner._generate_and_show_results):
10860         (PerfTestsRunner._generate_output_files):
10861         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
10862         (create_runner_and_setup_results_template):
10863         (test_run_generates_and_show_results_page):
10864         (test_run_respects_no_show_results):
10865
10866 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
10867
10868         test-webkitpy hangs in a new checkout on snow leopard
10869         https://bugs.webkit.org/show_bug.cgi?id=93301
10870
10871         Reviewed by Ryosuke Niwa.
10872
10873         This change works around what appears to be a bug in Python
10874         2.6.1 (the version that ships on Mac Snow Leopard) that causes
10875         the multiprocessing module to hang after we use the
10876         autoinstaller; I'm guessing it's some sort of python sockets
10877         issue. I was unable to reproduce this with 2.6.5 or newer
10878         versions of Python.
10879
10880         * Scripts/webkitpy/common/system/autoinstall.py:
10881         (AutoInstaller.install):
10882         * Scripts/webkitpy/test/main.py:
10883         (Tester._run_tests):
10884         * Scripts/webkitpy/thirdparty/__init__.py:
10885         (AutoinstallImportHook._install_mechanize):
10886         (AutoinstallImportHook._install_pep8):
10887         (AutoinstallImportHook._install_pylint):
10888         (AutoinstallImportHook._install_buildbot):
10889         (AutoinstallImportHook._install_coverage):
10890         (AutoinstallImportHook._install_eliza):
10891         (AutoinstallImportHook._install_irc):
10892         (AutoinstallImportHook._install_webpagereplay):
10893         (AutoinstallImportHook._install):
10894         (autoinstall_everything):
10895
10896 2012-08-07  Xianzhu Wang  <wangxianzhu@chromium.org>
10897
10898         [Chromium-Android][NRWT] Fix 2 FIXMEs in chromium_android.py
10899         https://bugs.webkit.org/show_bug.cgi?id=93381
10900
10901         Reviewed by Adam Barth.
10902
10903         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
10904         (ChromiumAndroidDriver.__init__):
10905         (ChromiumAndroidDriver._push_executable): Remove temporary lines as the chromium change has been landed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150371
10906         (ChromiumAndroidDriver._setup_performance): Update all scaling governor files.
10907         (ChromiumAndroidDriver._teardown_performance): Update all scaling governor files.
10908
10909 2012-08-07  W. James MacLean  <wjmaclean@chromium.org>
10910
10911         [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
10912         https://bugs.webkit.org/show_bug.cgi?id=93286
10913
10914         Reviewed by James Robinson.
10915
10916         Adds support to generate GestureTapDown events from EventSender, to facilitate
10917         link highlighting layout tests.
10918  
10919         Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.
10920
10921         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
10922         (EventSender::EventSender):
10923         (EventSender::gestureTapDown):
10924         (EventSender::gestureEvent):
10925         * DumpRenderTree/chromium/TestRunner/EventSender.h:
10926         (EventSender):
10927
10928 2012-08-07  Marcelo Lira  <marcelo.lira@openbossa.org>
10929
10930         [Qt] Add support for the Gamepad API
10931         https://bugs.webkit.org/show_bug.cgi?id=90637
10932
10933         Reviewed by Alexis Menard.
10934
10935         If the libudev library is present, the GAMEPAD flag is
10936         turned on by default for the Qt port.
10937
10938         * Scripts/webkitperl/FeatureList.pm:
10939         * qmake/mkspecs/features/features.prf:
10940
10941 2012-08-07  Rob Buis  <rbuis@rim.com>
10942
10943         [BlackBerry] Turn on CSS Variables
10944         https://bugs.webkit.org/show_bug.cgi?id=93376
10945
10946         Reviewed by Antonio Gomes.
10947
10948         Turn on CSS Variables for BlackBerry port.
10949
10950         * Scripts/webkitperl/FeatureList.pm:
10951
10952 2012-08-07  No'am Rosenthal  <noam.rosenthal@nokia.com>
10953
10954         [Qt] Make it possible to build without QtQuick
10955
10956         Reviewed by Simon Hausmann.
10957
10958         * Tools.pro:
10959         * qmake/mkspecs/features/features.prf:
10960
10961 2012-08-02  Simon Hausmann  <simon.hausmann@nokia.com>
10962
10963         [Qt] Remove Qt 4 specific code paths
10964         https://bugs.webkit.org/show_bug.cgi?id=88161
10965
10966         Reviewed by Kenneth Rohde Christiansen.
10967
10968         * DumpRenderTree/qt/DumpRenderTree.pro:
10969         * DumpRenderTree/qt/EventSenderQt.cpp:
10970         (EventSender::touchCancel):
10971         (EventSender::sendTouchEvent):
10972         * DumpRenderTree/qt/EventSenderQt.h:
10973         (EventSender):
10974         * DumpRenderTree/qt/ImageDiff.pro:
10975         * DumpRenderTree/qt/main.cpp:
10976         (main):
10977         * QtTestBrowser/QtTestBrowser.pro:
10978         * QtTestBrowser/cookiejar.cpp:
10979         (TestBrowserCookieJar::TestBrowserCookieJar):
10980         * QtTestBrowser/launcherwindow.cpp:
10981         (LauncherWindow::setDiskCache):
10982         * qmake/configure.pri:
10983         * qmake/mkspecs/features/default_post.prf:
10984         * qmake/mkspecs/features/default_pre.prf:
10985         * qmake/mkspecs/features/features.prf:
10986         * qmake/mkspecs/features/functions.prf:
10987         * qmake/mkspecs/features/qtwebkit.prf: Removed.
10988         * qmake/mkspecs/features/unix/default_pre.prf:
10989
10990 2012-08-07  Andras Becsi  <andras.becsi@nokia.com>
10991
10992         [Qt][WK2] MiniBrowser should only synthesize multiple touch points if Ctrl is pressed
10993         https://bugs.webkit.org/show_bug.cgi?id=93277
10994
10995         Reviewed by Jocelyn Turcotte.
10996
10997         MiniBrowser's multi-touch mocking does not check if Ctrl is pressed
10998         when registering multiple touch points based on pressed mouse buttons
10999         and sends inconsistent touch events to the WebView which triggers an
11000         assert in the pinch gesture recognizer.
11001         MiniBrowserApplication::updateTouchPoint should only register multiple
11002         touch points if the Ctrl button is pressed else it should ignore the
11003         update request.
11004
11005         * MiniBrowser/qt/MiniBrowserApplication.cpp:
11006         (MiniBrowserApplication::updateTouchPoint):
11007
11008 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
11009
11010         REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
11011         https://bugs.webkit.org/show_bug.cgi?id=93346
11012
11013         Rubber-stamped by Simon Hausmann.
11014
11015         Change back "unexpected" to "Unexpected", because master.cfg's results parser expects it.
11016
11017         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11018         (MainTest.test_retrying_and_flaky_tests):
11019         * Scripts/webkitpy/layout_tests/views/printing.py:
11020         (Printer._print_unexpected_results):
11021
11022 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
11023
11024         [NRWT] runs platform specific tests that it shouldn't with --force
11025         https://bugs.webkit.org/show_bug.cgi?id=91089
11026
11027         Reviewed by Dirk Pranke.
11028
11029         Ignore other platform's directories from platform/.
11030
11031         * Scripts/webkitpy/layout_tests/port/base.py:
11032         (Port._expanded_paths):
11033         * Scripts/webkitpy/layout_tests/port/test.py:
11034         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11035         (MainTest.test_platform_tests_are_found):
11036         Updated integration test in accordance to the new behavior.
11037
11038 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
11039
11040         [EFL] Enable link prefetch
11041         https://bugs.webkit.org/show_bug.cgi?id=93281
11042
11043         Reviewed by Kentaro Hara.
11044
11045         * Scripts/webkitperl/FeatureList.pm: Enable LINK_PREFETCH feature.
11046
11047 2012-08-06  Sheriff Bot  <webkit.review.bot@gmail.com>
11048
11049         Unreviewed, rolling out r124801.
11050         http://trac.webkit.org/changeset/124801
11051         https://bugs.webkit.org/show_bug.cgi?id=93338
11052
11053         It broke NRWT (Requested by Ossy on #webkit).
11054
11055         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
11056         (SingleTestRunner._compare_image):
11057         (SingleTestRunner._compare_output_with_reference):
11058         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
11059         (write_test_result):
11060         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
11061         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
11062         (TestResultWriterTest):
11063         * Scripts/webkitpy/layout_tests/port/base.py:
11064         (Port.diff_image):
11065         * Scripts/webkitpy/layout_tests/port/chromium.py:
11066         (ChromiumPort.diff_image):
11067         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
11068         (ChromiumPortTestCase.test_diff_image):
11069         * Scripts/webkitpy/layout_tests/port/image_diff.py:
11070         (ImageDiffer.diff_image):
11071         (ImageDiffer._read):
11072         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
11073         (TestImageDiffer.test_diff_image):
11074         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
11075         (MockDRTPortTest.test_diff_image):
11076         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
11077         (PortTestCase.test_diff_image):
11078         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
11079         (MockServerProcess.__init__):
11080         * Scripts/webkitpy/layout_tests/port/test.py:
11081         (TestPort.diff_image):
11082         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11083         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
11084
11085 2012-08-06  Wei James  <james.wei@intel.com>
11086
11087         [Chromium]duplicated command line options in Android LayoutTest
11088         https://bugs.webkit.org/show_bug.cgi?id=93233
11089
11090         Reviewed by Tony Chang.
11091
11092         Duplicated options found in Android layout test command line:
11093         --encode-binary and --enable-hardware-gpu.
11094
11095         If there are multiple ChromiumAndroidPort instances,
11096         these two options will be appended for multiple times.
11097
11098         * Scripts/webkitpy/layout_tests/port/base.py:
11099         (Port.additional_drt_flag):
11100         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
11101         (ChromiumAndroidPort.__init__):
11102         (ChromiumAndroidPort.additional_drt_flag):
11103         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
11104         (ChromiumAndroidTwoPortsTest):
11105         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
11106         * Scripts/webkitpy/layout_tests/port/driver.py:
11107         (Driver.cmd_line):
11108
11109 2012-08-03  Brady Eidson  <beidson@apple.com>
11110
11111         Out-of-process plug-ins should support asynchronous initialization
11112         <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
11113
11114         Reviewed by Anders Carlsson.
11115
11116         Add a plug-in with an NPP_New that takes 550ms (a reasonable trade-off between a solid test and a slow running test)
11117         for testing asynchronous plug-in initialization.
11118
11119         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
11120         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp: Copied from Source/WebKit2/Shared/Plugins/PluginProcessCreationParameters.h.
11121         (SlowNPPNew):
11122         (SlowNPPNew::SlowNPPNew):
11123         (SlowNPPNew::NPP_New):
11124
11125 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
11126
11127         [Chromium-Android] Virtual test suites fail
11128         https://bugs.webkit.org/show_bug.cgi?id=92515
11129
11130         Reviewed by Dirk Pranke.
11131
11132         The failure is because our bypassing of DriverProxy.
11133         Repeat the logic of virtual tests in DriverProxy in ChromiumAndroidDriver
11134         and restart DRT when the command line changes.
11135
11136         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
11137         (ChromiumAndroidDriver.__init__):
11138         (ChromiumAndroidDriver.cmd_line): Added comments about why we override this and have _drt_cmd_line().
11139         (ChromiumAndroidDriver.run_test): Repeat the logic of virtual tests in DriverProxy.
11140         (ChromiumAndroidDriver.start): Restart DRT when the command line changes.
11141         (ChromiumAndroidDriver._start_once):
11142
11143 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
11144
11145         Remove NRWT --shard-ref-tests
11146         https://bugs.webkit.org/show_bug.cgi?id=91539
11147
11148         This is basically a revert of "[Chromium-Android] Run ref tests together to avoid expensive driver restarts"
11149         (https://bugs.webkit.org/show_bug.cgi?id=91533, http://trac.webkit.org/changeset/122914),
11150         with some conflicts resolved (because of refactory of Manager/LayoutTestRunner/Sharder classes).
11151
11152         Reviewed by Dirk Pranke.
11153
11154         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
11155         (LayoutTestRunner.run_tests):
11156         (Sharder.shard_tests):
11157         (Sharder._shard_in_two):
11158         (Sharder._shard_by_directory):
11159         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
11160         (SharderTests):
11161         (SharderTests.get_test_input):
11162         (SharderTests.get_shards):
11163         (SharderTests.test_shard_by_dir):
11164         (SharderTests.test_shard_in_two):
11165         * Scripts/webkitpy/layout_tests/controllers/manager.py:
11166         (Manager._test_input_for_file):
11167         (Manager._test_is_slow):
11168         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
11169         (ChromiumAndroidPort.__init__):
11170         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11171         (parse_args):
11172
11173 2012-08-06  Luciano Wolf  <luciano.wolf@openbossa.org>
11174
11175         [Qt] Default sizes for input-text and text-area are different when running DRT/WTR
11176         https://bugs.webkit.org/show_bug.cgi?id=91990
11177
11178         Reviewed by Kenneth Rohde Christiansen.
11179
11180         Initializing TestFonts information into WTR binary. Doing it 
11181         later leads to wrong font names usage (Dejavu Serif instead
11182         of Liberation Serif).
11183
11184         * WebKitTestRunner/Target.pri:
11185         * WebKitTestRunner/qt/main.cpp:
11186         (main):
11187
11188 2012-08-06  Jeff Timanus  <twiz@chromium.org>
11189
11190         Add twiz@{chromium|google}.org to the set of non-committer contributors.
11191         https://bugs.webkit.org/show_bug.cgi?id=93288
11192
11193         Reviewed by Adam Barth.
11194
11195         * Scripts/webkitpy/common/config/committers.py:
11196
11197 2012-08-06  Adam Barth  <abarth@webkit.org>
11198
11199         REGRESSION(124789): EWS errors out because --print option is missing
11200         https://bugs.webkit.org/show_bug.cgi?id=93299
11201
11202         Unreviewed.
11203
11204         The --print option doesn't exist anymore.  Let's try --quiet instead.
11205
11206         * Scripts/webkitpy/tool/steps/runtests.py:
11207         (RunTests.run):
11208         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
11209
11210 2012-08-06  Ryosuke Niwa  <rniwa@webkit.org>
11211
11212         run-webkit-tests should have ability to add description to its JSON output
11213         https://bugs.webkit.org/show_bug.cgi?id=93296
11214
11215         Reviewed by Dirk Pranke.
11216
11217         Add --description option.
11218
11219         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
11220         (PerfTestsRunner._parse_args):
11221         (PerfTestsRunner._generate_and_show_results):
11222         (PerfTestsRunner._generate_results_dict):
11223         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
11224         (test_run_with_description):
11225
11226 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
11227
11228         nrwt: handle errors from image diff better
11229         https://bugs.webkit.org/show_bug.cgi?id=92934
11230
11231         Reviewed by Ojan Vafai.
11232
11233         Currently if ImageDiff crashes, returns a weird exit code, or
11234         produces any stderr output, it's basically swallowed. This
11235         change ensures that we log errors to stderr, and also appends
11236         the error to the stderr for the test (so it'll show up in
11237         results.html).
11238
11239         Most importantly, it'll cause diff_image() to fail and we'll
11240         report ImageHashMismatch ... this may be kinda untrue, but I
11241         think it's better than ignoring the error.
11242
11243         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
11244         (SingleTestRunner._compare_image):
11245         (SingleTestRunner._compare_output_with_reference):
11246         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
11247         (write_test_result):
11248         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
11249         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
11250         (TestResultWriterTest):
11251         * Scripts/webkitpy/layout_tests/port/base.py:
11252         (Port.diff_image):
11253         * Scripts/webkitpy/layout_tests/port/chromium.py:
11254         (ChromiumPort.diff_image):
11255         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
11256         (ChromiumPortTestCase.test_diff_image_crashed):
11257         * Scripts/webkitpy/layout_tests/port/driver.py:
11258         (Driver.run_test):
11259         * Scripts/webkitpy/layout_tests/port/image_diff.py:
11260         (ImageDiffer.diff_image):
11261         (ImageDiffer._read):
11262         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
11263         (TestImageDiffer.test_diff_image):
11264         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
11265         (MockDRTPortTest.test_diff_image_crashed):
11266         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
11267         (PortTestCase.test_diff_image):
11268         (PortTestCase):
11269         (PortTestCase.test_diff_image_crashed):
11270         (PortTestCase.test_diff_image_crashed.make_proc):
11271         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
11272         (MockServerProcess.__init__):
11273         * Scripts/webkitpy/layout_tests/port/test.py:
11274         (TestPort.diff_image):
11275         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11276         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
11277
11278 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
11279
11280         nrwt: clean up printing.py
11281         https://bugs.webkit.org/show_bug.cgi?id=93026
11282
11283         Reviewed by Dirk Pranke.
11284
11285         This patch cleans up the implementation of printing.py now
11286         that we're not using all the original complexity.
11287
11288         There should be no changes in functionality and everything
11289         should be covered by the existing tests.
11290
11291         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
11292         (LayoutTestRunner.run_tests):
11293         * Scripts/webkitpy/layout_tests/views/printing.py:
11294         (Printer.__init__):
11295         (Printer.__del__):
11296         (Printer.print_config):
11297         (Printer.print_found):
11298         (Printer.print_expected):
11299         (Printer.print_workers_and_shards):
11300         (Printer):
11301         (Printer._print_expected_results_of_type):
11302         (Printer.print_results):
11303         (Printer._print_timing_statistics):
11304         (Printer._print_aggregate_test_statistics):
11305         (Printer._print_individual_test_times):
11306         (Printer._print_test_list_timing):
11307         (Printer._print_directory_timings):
11308         (Printer._print_statistics_for_test_timings):
11309         (Printer._print_result_summary):
11310         (Printer._print_result_summary_entry):
11311         (Printer._print_one_line_summary):
11312         (Printer.print_finished_test):
11313         (Printer._print_test_result):
11314         (Printer._print_test_trace):
11315         (Printer._print_baseline):
11316         (Printer._print_unexpected_test_result):
11317         (Printer._print_progress):
11318         (Printer._print_unexpected_results):
11319         (Printer._print_unexpected_results.add_result):
11320         (Printer._print_quiet):
11321         (Printer._print_default):
11322         (Printer._print_debug):
11323         (Printer._print_for_bot):
11324         (Printer.write_update):
11325         (Printer.writeln):
11326         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
11327         (Testprinter.get_printer):
11328         (Testprinter.test_print_config):
11329         (Testprinter.test_print_one_line_summary):
11330         (Testprinter.test_print_unexpected_results):
11331         (test_details):
11332
11333 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
11334
11335         change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
11336         https://bugs.webkit.org/show_bug.cgi?id=93043
11337
11338         Reviewed by Ryosuke Niwa.
11339
11340         in preparation for the cleanup of the logging flags in new-run-webkit-tests.
11341
11342         * Scripts/run-webkit-tests:
11343
11344 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
11345
11346         nrwt: clean up logging, part 1
11347         https://bugs.webkit.org/show_bug.cgi?id=93018
11348
11349         Reviewed by Ojan Vafai.
11350
11351         remove --print, --help-printing from nrwt, add three new options:
11352         --quiet, which just logs warnings,errors, and unexpected results
11353         --debug-rwt-logging, a new name for --verbose
11354         --details, to get the old --print trace-everything behavior
11355
11356         This patch does not implement the new "one line per test"
11357         --verbose behavior specified in bug 88702, and there's a bunch
11358         of internal cleanup I can do in printing.py that I'll defer to
11359         a later patch to make things easier to review.
11360
11361         This patch deletes a lot of unit tests that are no longer
11362         necessary since there aren't so many logging combinations.
11363
11364         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11365         (run):
11366         (main):
11367         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11368         (parse_args):
11369         (passing_run):
11370         (StreamTestingMixin.assertContains):
11371         (MainTest.test_child_processes_2):
11372         (MainTest.test_child_processes_min):
11373         (MainTest.test_full_results_html):
11374         (MainTest.test_no_tests_found):
11375         (MainTest.test_no_tests_found_2):
11376         (MainTest.test_repeat_each_iterations_num_tests):
11377         (MainTest.test_additional_platform_directory):
11378         (RebaselineTest.assertBaselines):
11379         * Scripts/webkitpy/layout_tests/views/printing.py:
11380         (print_options):
11381         (Printer.__init__):
11382         (Printer.enabled):
11383         (Printer.print_unexpected_results):
11384         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
11385         (TestUtilityFunctions.test_print_options):
11386         (Testprinter.get_result_summary):
11387         (Testprinter.test_configure_and_cleanup):
11388         (Testprinter.test_print_config):
11389         (Testprinter.test_print_one_line_summary):
11390         (Testprinter.test_print_unexpected_results):
11391         (test_details):
11392         (test_default):
11393         (test_quiet):
11394         (test_verbose):
11395
11396 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
11397
11398         [Chromium-Android] Store test executable, data and fonts in /data/local/tmp
11399         https://bugs.webkit.org/show_bug.cgi?id=91910
11400
11401         /data/local/tmp is a directory with permission 0777 by default.
11402         Place DumpRenderTree resources here so that both the native test app and
11403         the NRWT script can access them even if adb shell isn't running as root.
11404
11405         Reviewed by Adam Barth.
11406
11407         * DumpRenderTree/chromium/TestShellAndroid.cpp:
11408         (createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
11409         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
11410         (ChromiumAndroidPort.driver_cmd_line):
11411         (ChromiumAndroidDriver.__init__):
11412         (ChromiumAndroidDriver._setup_test):
11413         (ChromiumAndroidDriver._push_executable):
11414         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
11415         (ChromiumAndroidPortTest.make_port):
11416         (ChromiumAndroidPortTest.test_expectations_files):
11417         (ChromiumAndroidDriverTest.test_drt_cmd_line):
11418
11419 2012-08-06  Abhishek Arya  <inferno@chromium.org>
11420
11421         [Chromium] Re-expose layoutTestController as various fuzzers depend on it
11422         https://bugs.webkit.org/show_bug.cgi?id=93282
11423
11424         Reviewed by Ryosuke Niwa.
11425
11426         Unfortunately, various fuzzers used in the Chromium project still depends on
11427         window.layoutTestController. Re-expose the object while they're making the transition.
11428
11429         * DumpRenderTree/chromium/TestShell.cpp:
11430         (TestShell::bindJSObjectsToWindow):
11431
11432 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
11433
11434         WTR should be able to load external resources
11435         https://bugs.webkit.org/show_bug.cgi?id=89382
11436
11437         Reviewed by Ryosuke Niwa.
11438
11439         Allow to load an external resource as the main frame
11440         and allow all subsequent external loads for such a main
11441         frame. This behavior is necessary for being able to run
11442         performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).
11443
11444         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
11445         (WTR::isLocalHost):
11446         (WTR):
11447         (WTR::isHTTPOrHTTPSScheme):
11448         (WTR::InjectedBundlePage::willSendRequestForFrame):
11449
11450 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
11451
11452         [WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
11453         https://bugs.webkit.org/show_bug.cgi?id=93120
11454
11455         Reviewed by Csaba Osztrogonác.
11456
11457         Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
11458         so it will be able to detect an unresponsive web process.
11459
11460         * Scripts/webkitpy/layout_tests/port/base.py:
11461         (Port.default_timeout_ms):
11462         * WebKitTestRunner/TestController.cpp:
11463         (WTR):
11464
11465 2012-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
11466
11467         Unreviewed. Fix make distcheck.
11468
11469         * GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.
11470
11471 2012-08-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
11472
11473         [EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
11474         https://bugs.webkit.org/show_bug.cgi?id=82724
11475
11476         Reviewed by Csaba Osztrogonác.
11477
11478         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
11479         (LayoutTestController::removeAllVisitedLinks):
11480
11481 2012-08-06  Mario Sanchez Prada  <msanchez@igalia.com>
11482
11483         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
11484         https://bugs.webkit.org/show_bug.cgi?id=90268
11485
11486         Reviewed by Martin Robinson.
11487
11488         Ignore WebKitTextChecker.* private files for gtk-doc.
11489
11490         * gtk/generate-gtkdoc:
11491         (get_webkit2_options):
11492
11493 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
11494
11495         Unreviewed. Roll out r124728 because of build bot test fail.
11496
11497         * Scripts/webkitpy/common/config/watchlist:
11498
11499 2012-08-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
11500
11501         Unreviewed. Change my email address for watch list.
11502
11503         * Scripts/webkitpy/common/config/watchlist:
11504
11505 2012-08-04  Nico Weber  <thakis@chromium.org>
11506
11507         [Chromium Mac] Tests are exiting early due to failures to load missingImage.png
11508         https://bugs.webkit.org/show_bug.cgi?id=93186
11509
11510         Reviewed by Ryosuke Niwa.
11511
11512         Add missingImage.png to DumpRenderTree.app's Resource folder.
11513         Depends on http://crrev.com/150037 rolling into webkit first.
11514
11515         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11516
11517 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
11518
11519         Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
11520         https://bugs.webkit.org/show_bug.cgi?id=93173
11521
11522         Reviewed by Adam Barth.
11523
11524         Don't expose window.layoutTestController since all layout tests use window.testRunner
11525         instead of window.layoutTestController as of r124685.
11526
11527         We can safely rename classes and files to use TestRunner once this patch is landed.
11528
11529         * DumpRenderTree/LayoutTestController.cpp:
11530         (LayoutTestController::makeWindowObject):
11531         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
11532         (notifyTestCompletion):
11533         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
11534         (PluginTest::waitUntilDone):
11535         (PluginTest::notifyDone):
11536         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
11537         (ConvertPoint::NPP_SetWindow):
11538         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
11539         (handleEventCarbon):
11540         (handleEventCocoa):
11541         (handleEventWin):
11542         * DumpRenderTree/chromium/TestShell.cpp:
11543         (TestShell::bindJSObjectsToWindow):
11544         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
11545         (WebCore::DumpRenderTree::initJSObjects):
11546         * Scripts/bencher:
11547         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
11548         (WTR::LayoutTestController::makeWindowObject):
11549
11550 2012-08-04  Ilya Tikhonovsky  <loislo@chromium.org>
11551
11552         Unreviewed: Web Inspector: extend instrumenting methods set in ReportMemoryUsage clang plugin
11553         Three methods addString, addVectorPtr and addInstrumentedVectorPtr were added to the list of instrumentation methods.
11554
11555         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
11556         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
11557
11558 2012-08-03  Yaron Friedman  <yfriedman@chromium.org>
11559
11560         [Chrome-Android] - Prepare apk tests for switch to checked in SDK.
11561         https://bugs.webkit.org/show_bug.cgi?id=92931
11562
11563         Reviewed by Adam Barth.
11564
11565         Pass Android-specific gyp variables to the native test generator,
11566         avoiding any dependencies on environment variables during build time.
11567
11568         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11569         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
11570
11571 2012-08-03  Rick Byers  <rbyers@chromium.org>
11572
11573         Double tap gesture should send dblclick event
11574         https://bugs.webkit.org/show_bug.cgi?id=92412
11575
11576         Reviewed by Adam Barth.
11577
11578         Enable EventSender to set the tap count on tap gesture events.  The
11579         delta X/Y parameters were not actually being used anymore (used to be
11580         used for radius information).
11581
11582         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
11583         (EventSender::gestureEvent):
11584
11585 2012-08-03  Ryosuke Niwa  <rniwa@webkit.org>
11586
11587         run-perf-tests should generate JSON output and results page by default
11588         https://bugs.webkit.org/show_bug.cgi?id=93042
11589
11590         Reviewed by Eric Seidel.
11591
11592         Generate results JSON and page named PerfTestResults.json and PerfTestResults.html by default.
11593
11594         * Scripts/webkitpy/layout_tests/port/base.py:
11595         (Port.perf_results_directory): Added.
11596         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
11597         (PerfTestsRunner): Added _DEFAULT_JSON_FILENAME.
11598         (PerfTestsRunner._parse_args): Added --no-results option in the case a user doens't want to generate
11599         results JSON or results page.
11600         (PerfTestsRunner.run):
11601         (PerfTestsRunner._generate_and_show_results): Extracted from run. Set the default json file path using
11602         port's perf_results_directory and call show_results_html_file at the end if the results page is generated.
11603         (PerfTestsRunner._generate_results_dict): Renamed from _generate_output to disambiguate it from
11604         _generate_and_show_results.
11605         (PerfTestsRunner._generate_output_files): Takes results page's path instead of a boolean indicating
11606         whether results page should be generated or not.
11607         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
11608         (create_runner_and_setup_results_template):
11609         (test_run_respects_results_output): Added.
11610         (test_run_generates_json_by_default): Added.
11611         (test_run_generates_and_show_results_page): Added a check to ensure show_results_html_file is called.
11612
11613 2012-08-03  Sheriff Bot  <webkit.review.bot@gmail.com>
11614
11615         Unreviewed, rolling out r124628.
11616         http://trac.webkit.org/changeset/124628
11617         https://bugs.webkit.org/show_bug.cgi?id=93155
11618
11619         Causes random crashes of DRT on Chromium bots (Requested by
11620         dimich on #webkit).
11621
11622         * DumpRenderTree/DumpRenderTree.gypi:
11623         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
11624         (MockWebKitPlatformSupport::createMediaStreamCenter):
11625         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
11626         (MockWebKitPlatformSupport):
11627         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
11628         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
11629         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Removed.
11630         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Removed.
11631
11632 2012-08-03  Brady Eidson  <beidson@apple.com>
11633
11634         Small part of "Out-of-process plug-ins should support asynchronous initialization."
11635         <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
11636
11637         Reviewed by Anders Carlsson.
11638
11639         * WebKitTestRunner/TestController.cpp:
11640         (WTR::TestController::resetStateToConsistentValues): Reset all preferences related to asynchronous plugin initialization.
11641
11642 2012-08-02  Jeffrey Pfau  <jpfau@apple.com>
11643
11644         Add API for enabling blanket third-party data blocking
11645         https://bugs.webkit.org/show_bug.cgi?id=93022
11646
11647         Reviewed by Anders Carlsson.
11648
11649         Added test for default setting of new third-party storage blocking API.
11650
11651         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
11652         (TestWebKitAPI::TEST):
11653
11654 2012-08-03  Arvid Nilsson  <anilsson@rim.com>
11655
11656         Unreviewed, adding self to committers.py after becoming committer.
11657
11658         * Scripts/webkitpy/common/config/committers.py:
11659
11660 2012-08-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
11661
11662         Limited the number of queried cached build infos in URLs used by Garden-o-matic.
11663         https://bugs.webkit.org/show_bug.cgi?id=92992.
11664
11665         Reviewed by Adam Barth.
11666
11667         I added a limit to the cached builds that are included in the URL to avoid too long URLs in Garden-o-matic.
11668
11669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
11670         (.):
11671         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
11672
11673 2012-08-03  Tommy Widenflycht  <tommyw@google.com>
11674
11675         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
11676         https://bugs.webkit.org/show_bug.cgi?id=93091
11677
11678         Reviewed by Adam Barth.
11679
11680         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
11681         to complete the infrastructure for RTCPeerConnection.
11682
11683         * DumpRenderTree/DumpRenderTree.gypi:
11684         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
11685         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
11686         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
11687         (MockWebKitPlatformSupport):
11688         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
11689         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
11690         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
11691         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
11692         (MockWebRTCPeerConnectionHandler::initialize):
11693         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
11694         (WebKit):
11695         (MockWebRTCPeerConnectionHandler):
11696         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
11697
11698 2012-08-03  Hugo Parente Lima  <hugo.lima@openbossa.org>
11699
11700         [Qt][WK2] There's no way to test the gesture tap on WTR
11701         https://bugs.webkit.org/show_bug.cgi?id=92895
11702
11703         Reviewed by Kenneth Rohde Christiansen.
11704
11705         WTR doesn't create the QQuickItem from C++, not from QML, so a call
11706         to componentComplete() was added to mimic the QML behaviour.
11707
11708         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
11709         (WTR::PlatformWebView::PlatformWebView):
11710
11711 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
11712
11713         Unreviewed, rolling out r124567.
11714         http://trac.webkit.org/changeset/124567
11715         https://bugs.webkit.org/show_bug.cgi?id=89382
11716
11717         Broke some tests with external resources
11718
11719         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
11720         (WTR::InjectedBundlePage::willSendRequestForFrame):
11721
11722 2012-08-03  Philippe Normand  <pnormand@igalia.com>
11723
11724         Unreviewed, rolling out r124614.
11725         http://trac.webkit.org/changeset/124614
11726         https://bugs.webkit.org/show_bug.cgi?id=91727
11727
11728         gstreamer core .po files mess up the build again
11729
11730         * Scripts/webkitdirs.pm:
11731         (buildAutotoolsProject):
11732         * gtk/jhbuild.modules:
11733
11734 2012-08-03  Philippe Normand  <pnormand@igalia.com>
11735
11736         [GTK][jhbuild] Switch to GStreamer 0.11 build
11737         https://bugs.webkit.org/show_bug.cgi?id=91727
11738
11739         Reviewed by Gustavo Noronha Silva.
11740
11741         Switch build-webkit --gtk to GStreamer 0.11 support and build the
11742         necessary GStreamer git modules from JHBuild.
11743
11744         * Scripts/webkitdirs.pm:
11745         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
11746         * gtk/jhbuild.modules: GStreamer build support.
11747
11748 2012-08-03  Nico Weber  <thakis@chromium.org>
11749
11750         [chromium mac] DumpRenderTree compile fails with warning/error in LayoutTestHelper.mm with 10.7sdk
11751         https://bugs.webkit.org/show_bug.cgi?id=92820
11752
11753         Reviewed by Jochen Eisinger.
11754
11755         When building with the 10.7 SDK, use newer functions to switch color
11756         profiles. Note that these newer functions aren't available on 10.6,
11757         but we don't intend to ship DRT to users, and no bots that currently
11758         build with the 10.7 SDK ship their binaries to 10.6 testers.
11759
11760         The new code was copied from Apple's DRT/mac/LayoutTestHelper.m.
11761
11762         * DumpRenderTree/chromium/LayoutTestHelper.mm:
11763         (installLayoutTestColorProfile):
11764         (restoreUserColorProfile):
11765         (saveCurrentColorProfile):
11766
11767 2012-08-03  Benjamin Poulain  <benjamin@webkit.org>
11768
11769         StringImpl created from literal should be BufferInternal
11770         https://bugs.webkit.org/show_bug.cgi?id=92940
11771
11772         Reviewed by Anders Carlsson.
11773
11774         Add tests for the contruction of strings from literal.
11775
11776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11777         * TestWebKitAPI/Tests/WTF/AtomicString.cpp: Added.
11778         (TestWebKitAPI):
11779         (TestWebKitAPI::TEST):
11780         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Added.
11781         (TestWebKitAPI):
11782         (TestWebKitAPI::TEST):
11783
11784 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
11785
11786         [nrwt] fix unit tests after turned pixel testing to be a per test setting
11787         https://bugs.webkit.org/show_bug.cgi?id=93112
11788
11789         Reviewed by Csaba Osztrogonác.
11790
11791         Change unit tests in accordance of per test switching of pixel testing.
11792
11793         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
11794         (ChromiumAndroidDriverTest.test_command_from_driver_input):
11795         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
11796         (DriverTest.test_no_timeout):
11797
11798 2012-08-03  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
11799
11800         [Qt] Populate .qmake.cache from the top-level project file
11801
11802         This makes it possible to build webkit without using the perl build
11803         script. The duplicated logic in build-webkit will be removed when we
11804         remove the Qt4 code paths. The build-webkit script will then simply
11805         call 'qmake WebKit.pro' from WEBKITOUTPUTDIR.
11806
11807         Reviewed by Tor Arne Vestbø.
11808
11809         * qmake/mkspecs/features/win32/default_pre.prf:
11810
11811 2012-08-03  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
11812
11813         [Qt] Move build config default to build-webkit instead of default_pre
11814
11815         Allows the qmake buildsystem have its own default.
11816
11817         Reviewed by Tor Arne Vestbø.
11818
11819         * Scripts/webkitdirs.pm:
11820         (buildQMakeProjects):
11821         * qmake/mkspecs/features/default_pre.prf:
11822
11823 2012-08-03  Mario Sanchez Prada  <msanchez@igalia.com>
11824
11825         Unreviewed build fix for GTK after r124581.
11826
11827         * DumpRenderTree/gtk/DumpRenderTree.cpp:
11828         (runTest): Fix wrong variable name in ASSERT.
11829
11830 2012-08-03  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
11831
11832         [Qt] Always save CONFIG & DEFINES in default_pre
11833
11834         Always doing it is cheaper than checking whether it needs to be done.
11835         apart from that, it would break configuration initiated from another
11836         project.
11837
11838         Reviewed by Tor Arne Vestbø.
11839
11840         * qmake/mkspecs/features/default_pre.prf:
11841
11842 2012-08-03  Joone Hur  <joone.hur@intel.com>
11843
11844         [EFL][DRT] fast/loader/stop-provisional-loads.html fails
11845         https://bugs.webkit.org/show_bug.cgi?id=92219
11846
11847         Reviewed by Kenneth Rohde Christiansen.
11848
11849         This patch adds the ability to tell DRT to call ewk_frame_stop 
11850         inside of a didStartProvisionalLoadForFrame signal handler.
11851         It allows to pass fast/loader/stop-provisional-loads.html.
11852
11853         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
11854         (DumpRenderTreeChrome::onFrameProvisionalLoad):
11855
11856 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
11857
11858         [WTR] process unresponsiveness is reported to the wrong test
11859         https://bugs.webkit.org/show_bug.cgi?id=88404
11860
11861         2nd unreviewed buildfix.
11862
11863         * WebKitTestRunner/TestInvocation.cpp:
11864
11865 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
11866
11867         [WTR] process unresponsiveness is reported to the wrong test
11868         https://bugs.webkit.org/show_bug.cgi?id=88404
11869
11870         Unreviewed buildfix. Also made the change on the array size
11871         suggested on review because I forgot it when landed.
11872
11873         * WebKitTestRunner/TestInvocation.cpp:
11874         (WTR::TestInvocation::invoke):
11875
11876 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
11877
11878         [WTR] process unresponsiveness is reported to the wrong test
11879         https://bugs.webkit.org/show_bug.cgi?id=88404
11880
11881         Reviewed by Zoltan Herczeg.
11882
11883         Do resetting to consistent state after the finished test,
11884         not before the next. This way we can report unresponsiveness
11885         to the test that triggered it, and we do a restart before the
11886         next test so it will start in a functional state.
11887
11888         * Scripts/webkitpy/layout_tests/port/webkit.py:
11889         (WebKitDriver._check_for_driver_crash):
11890         Print the error line for unresponsive web process, otherwise
11891         it's hard to tell what happened.
11892         * WebKitTestRunner/TestController.cpp:
11893         (WTR):
11894         Decreased the default short timeout so we can detect unresponsiveness
11895         before the timer of the test harness times out. It was unnecessarily
11896         high anyway, we should get answer from the web process in those cases
11897         when the short timeout is used in less than a second.
11898         (WTR::TestController::runTest):
11899         (WTR::TestController::run):
11900         * WebKitTestRunner/TestController.h:
11901         (TestController):
11902         * WebKitTestRunner/TestInvocation.cpp:
11903         (WTR::TestInvocation::invoke):
11904         (WTR::TestInvocation::dump):
11905         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
11906         * WebKitTestRunner/TestInvocation.h:
11907         (TestInvocation): Make the dump function static as it doesn't need an object.
11908
11909 2012-08-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
11910
11911         [EFL] (REGRESSION 124581) : EFL 64-bit Debug bot is red and build is exiting early after 20 test crashes
11912         https://bugs.webkit.org/show_bug.cgi?id=93084
11913
11914         Reviewed by Csaba Osztrogonác.
11915
11916         Fix regression introduced in r124581.
11917
11918         * DumpRenderTree/efl/DumpRenderTree.cpp:
11919         (getFinalTestURL): Convert the path into a full file URL.
11920         (runTest):
11921
11922 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
11923
11924         All ports should support per test switching of pixel testing
11925         https://bugs.webkit.org/show_bug.cgi?id=92398
11926
11927         Reviewed by Dirk Pranke.
11928
11929         Teach all test drivers to accept a per test control of whether
11930         to dump pixels. Drivers now accept a -p/--pixel-test argument
11931         on the standart input that means that running the current
11932         test as pixel test is allowed (even if the expected hash is
11933         missing). Removed the --pixel-tests command line option since
11934         there is no need for it anymore.
11935
11936         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11937         * DumpRenderTree/DumpRenderTree.gypi:
11938         * DumpRenderTree/DumpRenderTree.h:
11939         (TestCommand::TestCommand):
11940         (TestCommand):
11941         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
11942         * DumpRenderTree/DumpRenderTreeCommon.cpp: Added.
11943         (CommandTokenizer):
11944         (CommandTokenizer::CommandTokenizer):
11945         (CommandTokenizer::pump):
11946         (CommandTokenizer::next):
11947         (CommandTokenizer::hasNext):
11948         (die):
11949         (parseInputLine):
11950         Common logic to parse the input line from the standard input (or from the command line
11951         in standalone mode). Made it somewhat general so we can easily add more arguments if
11952         there is a need.
11953
11954         * DumpRenderTree/chromium/DumpRenderTree.cpp:
11955         (runTest):
11956         (main):
11957
11958         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp.
11959         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityController.h.
11960         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp.
11961         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h.
11962         Renamed these files with a Chromium suffix because they were clashing with the common ones used by other ports after adding the root
11963         DumpRenderTree directory to the include path.
11964
11965         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
11966         * DumpRenderTree/chromium/TestShell.cpp:
11967         (TestShell::TestShell):
11968         (TestShell::runFileTest):
11969         (TestShell::dump):
11970         * DumpRenderTree/chromium/TestShell.h:
11971         (TestParams::TestParams):
11972         (TestShell):
11973         * DumpRenderTree/efl/CMakeLists.txt:
11974         * DumpRenderTree/efl/DumpRenderTree.cpp:
11975         (parseCommandLineOptions):
11976         (runTest):
11977         (shouldDumpPixelsAndCompareWithExpected):
11978         (main):
11979         * DumpRenderTree/gtk/DumpRenderTree.cpp:
11980         (initializeGlobalsFromCommandLineOptions):
11981         (dump):
11982         (runTest):
11983         (main):
11984         * DumpRenderTree/mac/DumpRenderTree.mm:
11985         (initializeGlobalsFromCommandLineOptions):
11986         (dumpRenderTree):
11987         (dump):
11988         (runTest):
11989         * DumpRenderTree/qt/DumpRenderTree.pro:
11990         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
11991         (WebCore::DumpRenderTree::DumpRenderTree):
11992         (WebCore::DumpRenderTree::open):
11993         (WebCore::DumpRenderTree::processLine):
11994         (WebCore::DumpRenderTree::dump):
11995         * DumpRenderTree/qt/DumpRenderTreeQt.h:
11996         (DumpRenderTree):
11997         * DumpRenderTree/qt/main.cpp:
11998         (isOption):
11999         (printUsage):
12000         (main):
12001         * DumpRenderTree/win/DumpRenderTree.cpp:
12002         (dump):
12003         (runTest):
12004         (dllLauncherEntryPoint):
12005         * DumpRenderTree/win/DumpRenderTree.vcproj:
12006         * DumpRenderTree/wscript:
12007         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
12008         (dump):
12009         (runTest):
12010         (MyApp::OnInit):
12011         * GNUmakefile.am:
12012
12013         * Scripts/old-run-webkit-tests:
12014         * Scripts/old-run-webkit-tests:
12015         Pass --pixel-test before the hash.
12016
12017         * Scripts/webkitpy/layout_tests/port/base.py:
12018         (Port.should_run_as_pixel_test): Removed now that all ports supports it.
12019         * Scripts/webkitpy/layout_tests/port/driver.py:
12020         (Driver.cmd_line): Don't pass --pixel-tests anymore.
12021         (Driver._command_from_driver_input):
12022         * Scripts/webkitpy/layout_tests/port/qt.py:
12023         (QtPort.should_run_as_pixel_test):
12024         * Scripts/webkitpy/layout_tests/port/test.py:
12025         (TestPort.should_run_as_pixel_test):
12026
12027         * WebKitTestRunner/TestController.cpp:
12028         (WTR::TestController::TestController):
12029         (WTR::TestController::initialize):
12030         (WTR::TestCommand::TestCommand):
12031         (TestCommand):
12032         (WTR):
12033         (CommandTokenizer):
12034         (WTR::CommandTokenizer::CommandTokenizer):
12035         (WTR::CommandTokenizer::pump):
12036         (WTR::CommandTokenizer::next):
12037         (WTR::CommandTokenizer::hasNext):
12038         (WTR::die):
12039         (WTR::parseInputLine):
12040         (WTR::TestController::runTest):
12041         * WebKitTestRunner/TestController.h:
12042         (TestController):
12043         Duplicate the logic for parsing the command line because
12044         unfortunately there is no way to share code between
12045         WebKitTestRunner and DumpRenderTree.
12046
12047 2012-08-03  Ilya Tikhonovsky  <loislo@chromium.org>
12048
12049         Web Inspector: clang plugin for checking native memory instrumentation coverage.
12050         https://bugs.webkit.org/show_bug.cgi?id=92650
12051
12052         Reviewed by Yury Semikhatsky.
12053
12054         This is the clang plugin for checking native memory instrumentation coverage.
12055         The idea: InspectorMemoryAgent traverses through instrumented objects and collects pointers and their sizes and types.
12056         It is doing that with help of reportMemoryUsage function that needs to be implemented in each, significant
12057         from native memory footprint point of view, WebCore class.
12058         This plugin checks that the list of class members is matching with the list of members reported in reportMemoryUsage function
12059         and makes a warning for the each member that needs to be reported.
12060
12061         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Added.
12062         * clang/ReportMemoryUsagePlugin/Makefile: Added.
12063         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Added.
12064         (clang):
12065         (AddMemberCallVisitor):
12066         (clang::AddMemberCallVisitor::VisitCallExpr):
12067         (clang::AddMemberCallVisitor::instrumentedMembers):
12068         (ReportMemoryUsageVisitor):
12069         (clang::ReportMemoryUsageVisitor::ReportMemoryUsageVisitor):
12070         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
12071         (clang::ReportMemoryUsageVisitor::emitWarning):
12072         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
12073         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
12074         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
12075         (ReportMemoryUsageConsumer):
12076         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
12077         (clang::ReportMemoryUsageConsumer::HandleTranslationUnit):
12078         (ReportMemoryUsageAction):
12079         (clang::ReportMemoryUsageAction::CreateASTConsumer):
12080         (clang::ReportMemoryUsageAction::ParseArgs):
12081         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Added.
12082         (aNamespace):
12083         (MemoryInstrumentation):
12084         (MemoryClassInfo):
12085         (aNamespace::MemoryClassInfo::MemoryClassInfo):
12086         (aNamespace::MemoryClassInfo::addMember):
12087         (aNamespace::MemoryClassInfo::addInstrumentedMember):
12088         (OwnPtr):
12089         (aNamespace::OwnPtr::OwnPtr):
12090         (RefPtr):
12091         (aNamespace::RefPtr::RefPtr):
12092         (Vector):
12093         (String):
12094         (NotInstrumentedClass):
12095         (InstrumentedClass):
12096         (aNamespace::InstrumentedClass::reportMemoryUsage):
12097         (InstrumentedChildClass):
12098         (aNamespace::InstrumentedChildClass::reportMemoryUsage):
12099         (InstrumentedChildChildClass):
12100         (InstrumentedChildChildClass::reportMemoryUsage):
12101         (main):
12102
12103 2012-08-03  Joone Hur  <joone.hur@intel.com>
12104
12105         [EFL][DRT] WebKitAnimation API compile-time disabled
12106         https://bugs.webkit.org/show_bug.cgi?id=84593
12107
12108         Reviewed by Laszlo Gombos.
12109
12110         Enable ENABLE_ANIMATION_API by default on the Efl port.
12111
12112         * Scripts/webkitperl/FeatureList.pm:
12113
12114 2012-08-03  Balazs Kelemen  <kbalazs@webkit.org>
12115
12116         WTR should be able to load external resources
12117         https://bugs.webkit.org/show_bug.cgi?id=89382
12118
12119         Reviewed by Ryosuke Niwa.
12120
12121         Allow to load an external resource as the main frame
12122         and allow all subsequent external loads for such a main
12123         frame. This behavior is necessary for being able to run
12124         performance tests (wkb.ug/84008).
12125
12126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
12127         (WTR::isLocalHost):
12128         (WTR):
12129         (WTR::isHTTPOrHTTPSScheme):
12130         (WTR::InjectedBundlePage::willSendRequestForFrame):
12131
12132 2012-08-02  Joone Hur  <joone.hur@intel.com>
12133
12134         [GTK] Build break when building DumpRenderTree/gtk/EditingCallbacks.cpp
12135         https://bugs.webkit.org/show_bug.cgi?id=93061
12136
12137         Unreviewed, Fix build break for WebKitGtk+.
12138
12139         Use webkit_dom_element_get_class_name instead of webkit_dom_html_element_get_class_name.
12140
12141         * DumpRenderTree/gtk/EditingCallbacks.cpp:
12142         (shouldShowDeleteInterfaceForElement):
12143
12144 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
12145
12146         test-webkitpy can fail on a clean checkout
12147         https://bugs.webkit.org/show_bug.cgi?id=93039
12148
12149         Reviewed by Adam Barth.
12150
12151         Now that we run tests in parallel that can cause the installer
12152         to try and install packages in parallel (even the same package),
12153         and that probably won't work. We fix this by autoinstalling
12154         everything up front (serially).
12155
12156         * Scripts/webkitpy/test/main.py:
12157         (Tester._run_tests):
12158         * Scripts/webkitpy/thirdparty/__init__.py:
12159         (autoinstall_everything):
12160
12161 2012-06-15  David Barton  <dbarton@mathscribe.com>
12162
12163         MathML: nested square root symbols have varying descenders
12164         https://bugs.webkit.org/show_bug.cgi?id=43819
12165
12166         Reviewed by Eric Seidel.
12167
12168         Allow the STIXGeneral font to be used during layout tests, especially for MathML.
12169
12170         * DumpRenderTree/mac/DumpRenderTree.mm:
12171         (allowedFontFamilySet):
12172         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
12173         (WTR::allowedFontFamilySet):
12174
12175 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
12176
12177         test-webkitpy: some tests need to run by themselves
12178         https://bugs.webkit.org/show_bug.cgi?id=92926
12179
12180         Reviewed by Ojan Vafai.
12181
12182         Due to timing issues some of the executive tests will collide
12183         and fail if they're run concurrently. This patch adds support
12184         for writing tests that will be executed one at a time
12185         (serially); to get them, add "serial_" to the front of the test
12186         method name. 
12187
12188         * Scripts/webkitpy/common/system/executive_unittest.py:
12189         (ExecutiveTest.serial_test_kill_process):
12190         (ExecutiveTest.serial_test_kill_all):
12191         (ExecutiveTest.serial_test_check_running_pid):
12192         (ExecutiveTest.serial_test_running_pids):
12193         (ExecutiveTest.serial_test_run_in_parallel):
12194         * Scripts/webkitpy/test/main.py:
12195         (Tester._run_tests):
12196         (Tester._test_names):
12197
12198 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
12199
12200         test-webkitpy: integrate proper support for integration tests
12201         https://bugs.webkit.org/show_bug.cgi?id=92925
12202
12203         Reviewed by Ojan Vafai.
12204
12205         This patch merges the custom loader I used for integration tests
12206         into the main test-webkitpy code. Integration tests are not run
12207         by default yet, but at least they can be run.
12208
12209         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
12210         (MockTestShellTest.test_test_shell_parse_options):
12211         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
12212         (test_path_to_apache_config_file):
12213         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
12214         (WebsocketserverTest):
12215         * Scripts/webkitpy/test/main.py:
12216         (Tester._parse_args):
12217         (Tester._run_tests):
12218         (Tester._test_names):
12219         (Tester._log_exception):
12220         (_Loader):
12221         (_Loader.getTestCaseNames):
12222         (_Loader.getTestCaseNames.isTestMethod):
12223
12224 2012-08-02  Dirk Pranke  <dpranke@chromium.org>
12225
12226         test-webkitpy: clean up runner in preparation for running tests serially as necessary
12227         https://bugs.webkit.org/show_bug.cgi?id=92922
12228
12229         Reviewed by Ojan Vafai.
12230
12231         In order to run some tests by themselves (serially, rather than
12232         in parallel with other tests), we will need to be able to run
12233         multiple test suites; this causes us to move loading the logic
12234         for finding test method names out of the runner and into main.
12235
12236         I'm taking advantage of this to simplify some other stuff from
12237         the runner as well; it is now very simple and doesn't expose its
12238         dependency on unittest.TestResult at all (nor will the Printer
12239         use TestResult).
12240
12241         Subsequent patches will move the custom loader from
12242         port_testcase so that we can properly choose whether to run
12243         integration tests and/or serial tests, and then update the
12244         appropriate tests to run only serially.
12245
12246         * Scripts/webkitpy/test/main.py:
12247         (Tester._run_tests):
12248         (Tester):
12249         (Tester._check_imports):
12250         (Tester._test_names):
12251         (Tester._all_test_names):
12252         * Scripts/webkitpy/test/printer.py:
12253         (Printer.__init__):
12254         (Printer.write_update):
12255         (Printer):
12256         (Printer.print_finished_test):
12257         (Printer.print_result):
12258         * Scripts/webkitpy/test/runner.py:
12259         (unit_test_name):
12260         (Runner.__init__):
12261         (Runner.run):
12262         (Runner.handle):
12263         (_Worker.handle):
12264         * Scripts/webkitpy/test/runner_unittest.py:
12265         (FakeLoader.loadTestsFromName):
12266         (RunnerTest.test_run):
12267
12268 2012-08-02  Adam Barth  <abarth@webkit.org>
12269
12270         Turn on tests for the mac-ews, for realz this time.
12271
12272         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12273         (MacEWS):
12274
12275 2012-08-02  Xianzhu Wang  <wangxianzhu@chromium.org>
12276
12277         [Chromium-Android] Run layout tests on multiple devices in parallel
12278         https://bugs.webkit.org/show_bug.cgi?id=92877
12279
12280         Reviewed by Dirk Pranke.
12281
12282         Moved methods that run command on a particular device from ChromiumAndroidPort to ChromiumAndroidDriver.
12283         The drivers run adb commands with the '-s serial_number' parameter which specifies the device according to the work_number.
12284
12285         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
12286         (ChromiumAndroidPort.__init__):
12287         (ChromiumAndroidPort.default_child_processes): Default to the number of attached devices.
12288         (ChromiumAndroidPort.test_expectations): Removed because it is unused. 
12289         (ChromiumAndroidPort.setup_test_run): Most contents moved into ChromiumAndroidDriver._setup_test()
12290         (ChromiumAndroidPort.clean_up_test_run): Now the http server is stopped here.
12291         (ChromiumAndroidPort._get_devices):
12292         (ChromiumAndroidPort._get_device_serial):
12293         (ChromiumAndroidDriver):
12294         (ChromiumAndroidDriver.__init__):
12295         (ChromiumAndroidDriver.__del__):
12296         (ChromiumAndroidDriver._setup_test): Original contents of ChromiumAndroidPort.setup_test_run().
12297         (ChromiumAndroidDriver._push_executable): Moved from ChromiumAndroidPort.
12298         (ChromiumAndroidDriver._push_fonts): Moved from ChromiumAndroidPort.
12299         (ChromiumAndroidDriver._push_test_resources): Moved from ChromiumAndroidPort.
12300         (ChromiumAndroidDriver._synchronize_datetime): Moved from ChromiumAndroidPort.
12301         (ChromiumAndroidDriver._run_adb_command): Moved from ChromiumAndroidPort.
12302         (ChromiumAndroidDriver._teardown_performance): Moved from ChromiumAndroidPort.
12303         (ChromiumAndroidDriver._get_crash_log): Moved from ChromiumAndroidPort.
12304         (ChromiumAndroidDriver.cmd_line):
12305         (ChromiumAndroidDriver._file_exists_on_device):
12306         (ChromiumAndroidDriver._remove_all_pipes):
12307         (ChromiumAndroidDriver._start):
12308         (ChromiumAndroidDriver._start_once):
12309         (ChromiumAndroidDriver.stop):
12310         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
12311         (MockRunCommand):
12312         (MockRunCommand.__init__):
12313         (MockRunCommand.mock_run_command_fn):
12314         (MockRunCommand.mock_no_device):
12315         (MockRunCommand.mock_one_device):
12316         (MockRunCommand.mock_two_devices):
12317         (MockRunCommand.mock_no_tombstone_dir):
12318         (MockRunCommand.mock_no_tombstone_file):
12319         (MockRunCommand.mock_ten_tombstones):
12320         (MockRunCommand.mock_logcat):
12321         (ChromiumAndroidPortTest):
12322         (ChromiumAndroidPortTest.make_port):
12323         (ChromiumAndroidPortTest.test_driver_cmd_line):
12324         (ChromiumAndroidPortTest.test_get_devices_no_device):
12325         (ChromiumAndroidPortTest.test_get_devices_one_device):
12326         (ChromiumAndroidPortTest.test_get_devices_two_devices):
12327         (ChromiumAndroidPortTest.test_get_device_serial_no_device):
12328         (ChromiumAndroidPortTest.test_get_device_serial_one_device):
12329         (ChromiumAndroidPortTest.test_get_device_serial_two_devices):
12330         (ChromiumAndroidDriverTest):
12331         (ChromiumAndroidDriverTest.setUp):
12332         (ChromiumAndroidDriverTest.test_get_last_stacktrace):
12333         (ChromiumAndroidDriverTest.test_get_crash_log):
12334         (ChromiumAndroidDriverTest.test_cmd_line):
12335         (ChromiumAndroidDriverTwoDriversTest):
12336         (ChromiumAndroidDriverTwoDriversTest.test_two_drivers):
12337         * Scripts/webkitpy/layout_tests/port/driver.py:
12338         (Driver.run_test):
12339         (Driver._get_crash_log): Added to allow subclasses to override.
12340         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12341         (parse_args): Removed the --adb-args command-line parameter because now we select device automatically. Added --adb-device to specify devices.
12342
12343 2012-08-02  Dinu Jacob  <dinu.jacob@nokia.com>
12344
12345         WebKitTestRunner needs layoutTestController.setUserStyleSheetEnabled
12346         https://bugs.webkit.org/show_bug.cgi?id=42679
12347
12348         Reviewed by Eric Seidel.
12349
12350         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added 
12351         setUserStyleSheetEnabled and setUserStyleSheetLocation.
12352         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
12353         (WTR::LayoutTestController::LayoutTestController): Initialize new members added.
12354         (WTR::LayoutTestController::setUserStyleSheetEnabled): Added.
12355         (WTR::LayoutTestController::setUserStyleSheetLocation): Added.
12356         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added members
12357         userStyleSheetEnabled, and m_userStyleSheetLocation and methods
12358         setUserStyleSheetEnabled, and setUserStyleSheetLocation.
12359
12360 2012-08-02  Hans Wennborg  <hans@chromium.org>
12361
12362         Speech JavaScript API: Fire speech start event at the same time as sound start event
12363         https://bugs.webkit.org/show_bug.cgi?id=92971
12364
12365         Reviewed by Adam Barth.
12366
12367         Update the MockWebSpeechRecognizer to not fire "speech started" events
12368         separately.
12369
12370         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
12371         (MockWebSpeechRecognizer::start):
12372
12373 2012-08-02  Philippe Normand  <pnormand@igalia.com>
12374
12375         [GTK] make sometimes using a single core
12376         https://bugs.webkit.org/show_bug.cgi?id=92998
12377
12378         Reviewed by Martin Robinson.
12379
12380         In the GTK 64-bit Release buildbot some builds use a single core
12381         for the make process. I suspect this is because in those cases
12382         nproc reports a single core available. The proposed solution is to
12383         always rely on all the cores available in the machine.
12384
12385         * Scripts/webkitdirs.pm:
12386         (determineNumberOfCPUs):
12387
12388 2012-08-02  Adam Barth  <abarth@webkit.org>
12389
12390         Re-land http://trac.webkit.org/changeset/94441 now that lforschler is ready.
12391
12392         This patch enables testing on the mac-ews bots.
12393
12394         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12395
12396 2012-08-02  Adam Barth  <abarth@webkit.org>
12397
12398         [Chromium] Merge final nits to DumpRenderTree.gyp for Android
12399         https://bugs.webkit.org/show_bug.cgi?id=90920
12400
12401         Reviewed by Tony Chang.
12402
12403         This patch contains the last few small changes to DumpRenderTree.gyp
12404         from the chromium-android branch. After this change, this file will be
12405         fully merged.
12406
12407         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
12408
12409 2012-08-02  Peter Beverloo  <peter@chromium.org>
12410
12411         [Chromium] Toggle the type of ant compile for webkit_unit_tests and TestWebKitAPI
12412         https://bugs.webkit.org/show_bug.cgi?id=92858
12413
12414         Reviewed by Adam Barth.
12415
12416         Now that the sdk_build variable is available, we can remove these two differences
12417         as well. This goes together with Adam's bug 90920.
12418
12419         After this patch, the whole Tools/ directory will be unforked :-).
12420
12421         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
12422
12423 2012-08-02  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
12424
12425         [Qt] MSVC specific buildfix for DRT.
12426         https://bugs.webkit.org/show_bug.cgi?id=92978
12427
12428         Reviewed by Simon Hausmann.
12429
12430         DumpRenderTree/qt subdirectory is missing from generated makefile under MSVC build, need to be added to the pro file.
12431
12432         * DumpRenderTree/qt/DumpRenderTree.pro:
12433
12434 2012-08-02  Alexander Shalamov  <alexander.shalamov@intel.com>
12435
12436         [EFL][WK2] WTR is failing when X server is not running
12437         https://bugs.webkit.org/show_bug.cgi?id=92719
12438
12439         Reviewed by Hajime Morita.
12440
12441         EFL's WebKitTestRunner doesn't execute tests when X server is not running.
12442         This patch fixes the problem by checking environment variable before ecore x initialization.
12443
12444         * Scripts/webkitpy/layout_tests/port/efl.py:
12445         (EflPort.setup_environ_for_server):
12446         * WebKitTestRunner/efl/main.cpp:
12447         (main):
12448
12449 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
12450
12451         REGRESSION(r123893): Reftest mismatches are run through ImageDiff with 0.1 tolerance
12452         https://bugs.webkit.org/show_bug.cgi?id=92847
12453
12454         Reviewed by Ojan Vafai.
12455
12456         I was failing to distinguish between 'None' and 0 :(. Fixed and added tests.
12457
12458         * Scripts/webkitpy/layout_tests/port/base.py:
12459         (Port.diff_image):
12460         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
12461         (PortTestCase.test_diff_image.make_proc):
12462         (PortTestCase.test_diff_image):
12463
12464 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
12465
12466         test-webkitpy: clean up handling of tests to skip
12467         https://bugs.webkit.org/show_bug.cgi?id=92909
12468
12469         Reviewed by Ryosuke Niwa.
12470
12471         This change moves the handling of tests to skip into main.py
12472         where it is at least slightly more findable and generic.
12473
12474         Also fix a couple of lint nits.
12475
12476         * Scripts/webkitpy/test/finder.py:
12477         (Finder.__init__):
12478         (Finder.skip):
12479         (Finder._default_names):
12480         * Scripts/webkitpy/test/main.py:
12481         (main):
12482         (Tester.skip):
12483         * Scripts/webkitpy/test/main_unittest.py:
12484         (TesterTest.test_no_tests_found):
12485         * Scripts/webkitpy/test/runner_unittest.py:
12486
12487 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
12488
12489         test-webkitpy: remove --skip-integrationtests flag
12490         https://bugs.webkit.org/show_bug.cgi?id=92907
12491
12492         Reviewed by Ryosuke Niwa.
12493
12494         This flag is no longer used since the tests complete quickly.
12495         
12496         Also clean up the unused skip_if_parallel arg in finder, and
12497         make a couple of lint fixes.
12498
12499         * Scripts/webkitpy/test/finder.py:
12500         (Finder.find_names):
12501         (Finder._default_names):
12502         * Scripts/webkitpy/test/finder_unittest.py:
12503         (FinderTest.check_names):
12504         (FinderTest.test_default_names):
12505         * Scripts/webkitpy/test/main.py:
12506         (Tester._parse_args):
12507         (Tester.run):
12508         * Scripts/webkitpy/test/main_unittest.py:
12509         (TesterTest.test_no_tests_found):
12510
12511 2012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
12512
12513         Generalize SheriffIRCBot to prepare for PerfBot
12514         https://bugs.webkit.org/show_bug.cgi?id=92912
12515
12516         Reviewed by Adam Barth.
12517
12518         Renamed SheriffIRCBot to IRCBot and generalized to support non-sheriffbot IRC bot in the future.
12519         This will be useful when I add an experimental perf EWS IRC bot.
12520
12521         * Scripts/webkitpy/tool/bot/irc_command.py:
12522         (Whois.execute):
12523         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
12524         (IRCCommandTest):
12525         * Scripts/webkitpy/tool/bot/ircbot.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py.
12526         (Eliza): Moved from irc_command.
12527         (Eliza.__init__):
12528         (Eliza.execute):
12529         (IRCBot):
12530         (IRCBot.__init__):
12531         (IRCBot.irc_delegate):
12532         (IRCBot._parse_command_and_args):
12533         (IRCBot.process_message):
12534         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Moved from Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py.
12535         (run):
12536         (IRCBotTest):
12537         (IRCBotTest.test_eliza): Moved from IRCCommandTest.
12538         (IRCBotTest.test_parse_command_and_args):
12539         (IRCBotTest.test_exception_during_command):
12540         * Scripts/webkitpy/tool/bot/sheriffircbot.py: Removed.
12541         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Removed.
12542         * Scripts/webkitpy/tool/commands/sheriffbot.py:
12543         (SheriffBot.begin_work_queue):
12544         * Scripts/webkitpy/webkitpy.pyproj:
12545
12546 2012-08-01  Dirk Pranke  <dpranke@chromium.org>
12547
12548         nrwt: reenable the test for --verbose working in child processes
12549         https://bugs.webkit.org/show_bug.cgi?id=92894
12550
12551         Reviewed by Ryosuke Niwa.
12552
12553         This change rewrites the test to not use outputcapture, meaning
12554         that the MockHost can propagate to Worker properly and things
12555         work again :).
12556
12557         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
12558         (MainTest.test_verbose_in_child_processes):
12559
12560 2012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
12561
12562         run-perf-tests --build-directory doesn't work
12563         https://bugs.webkit.org/show_bug.cgi?id=92051
12564
12565         Reviewed by Dirk Pranke.
12566
12567         The bug was caused by not prepending build_directory even when one is defined.
12568         Fixed that.
12569
12570         * Scripts/webkitpy/layout_tests/port/base.py:
12571         (Port._build_path):
12572         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
12573         (PortTest.test_build_path):
12574
12575 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
12576
12577         Unreviewed, rolling out r123865.
12578         http://trac.webkit.org/changeset/123865
12579         https://bugs.webkit.org/show_bug.cgi?id=92891
12580
12581         This patch is causing the style-queue to fall behind
12582         (Requested by abarth on #webkit).
12583
12584         * Scripts/webkitpy/tool/commands/queues.py:
12585         (AbstractReviewQueue.begin_work_queue):
12586         (StyleQueue.__init__):
12587         * Scripts/webkitpy/tool/commands/queues_unittest.py:
12588         (StyleQueueTest.test_style_queue_with_style_exception):
12589         (test_style_queue_with_watch_list_exception):
12590
12591 2012-08-01  Ryosuke Niwa  <rniwa@webkit.org>
12592
12593         run-perf-tests throws an exception when the output json is malformed
12594         https://bugs.webkit.org/show_bug.cgi?id=92887
12595
12596         Reviewed by Dirk Pranke.
12597
12598         Catch exceptions and gracefully fail. Also split _generate_json into smaller methods.
12599
12600         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
12601         (PerfTestsRunner):
12602         (PerfTestsRunner.run):
12603         (PerfTestsRunner._generate_output): Extracted from _generate_json.
12604         (PerfTestsRunner._merge_source_json): Ditto; catch all exceptions since they are too many
12605         exceptions to consder here.
12606         (PerfTestsRunner._merge_outputs): Ditto.
12607         (PerfTestsRunner._generate_output_files): Extracted from _generate_json.
12608         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
12609         (_test_run_with_json_output): Don't assert logs when we except an non-zero exit code.
12610         (create_runner_and_setup_results_template): Extracted from test_run_generates_results_page.
12611         (test_run_generates_results_page):
12612         (test_run_with_bad_output_json): Added.
12613         (test_run_with_bad_json_source): Added.
12614         (test_run_with_upload_json):
12615
12616 2012-08-01  Thiago Marcos P. Santos  <thiago.santos@intel.com>
12617
12618         Regression(r124135): nrwt: --verbose logging does not work right on windows
12619         https://bugs.webkit.org/show_bug.cgi?id=92845
12620
12621         Reviewed by Dirk Pranke.
12622
12623         Disabled the failing test. The Workers spawned by this test are using Host()
12624         instead of MockHost() and trying to access the real filesystem instead of the
12625         MockFilesytem.
12626
12627         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
12628         (MainTest.disabled_test_verbose):
12629
12630 2012-08-01  Arnaud Renevier  <a.renevier@sisa.samsung.com>
12631
12632         keyring.get_password may raise an exception.
12633         https://bugs.webkit.org/show_bug.cgi?id=92876
12634
12635         Reviewed by Dirk Pranke.
12636
12637         keyring.get_password sometimes raises an exception. We wrap this call,
12638         and also set_password to avoid breaking webkit-patch in that case.
12639
12640         * Scripts/webkitpy/common/net/credentials.py:
12641         (Credentials._offer_to_store_credentials_in_keyring):
12642         (Credentials.read_credentials):
12643
12644 2012-08-01  Xianzhu Wang  <wangxianzhu@chromium.org>
12645
12646         Layout Test fast/text/descent-clip-in-scaled-page.html is failing on linux since it was added
12647         https://bugs.webkit.org/show_bug.cgi?id=91386
12648
12649         Reviewed by Tony Chang.
12650
12651         Added font mapping from SubpixelPositioningAhem to Ahem on Linux and Android
12652         (used in layout test fast/text/descent-clip-in-scaled-page.html).
12653         Added font mapping from SubpixelPositioning to Times New Roman on Android to match Linux
12654         (used in platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html)
12655
12656         * DumpRenderTree/chromium/android_main_fonts.xml:
12657         * DumpRenderTree/chromium/fonts.conf:
12658
12659 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
12660
12661         Unreviewed, rolling out r124325.
12662         http://trac.webkit.org/changeset/124325
12663         https://bugs.webkit.org/show_bug.cgi?id=92865
12664
12665         broke android build (Requested by mnaganov on #webkit).
12666
12667         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
12668
12669 2012-08-01  Thiago Marcos P. Santos  <thiago.santos@intel.com>
12670
12671         [EFL] Dump a backtrace in case of a crash on the UIProcess
12672         https://bugs.webkit.org/show_bug.cgi?id=92843
12673
12674         Reviewed by Csaba Osztrogonác.
12675
12676         We are already dumping the backtraces when automated tests are
12677         crashing, but only for the WebProcess. This patch adds the same
12678         hooks for the UIProcess.
12679
12680         * TestWebKitAPI/efl/main.cpp:
12681         (main):
12682         * WebKitTestRunner/efl/main.cpp:
12683         (main):
12684
12685 2012-08-01  Adam Barth  <abarth@webkit.org>
12686
12687         [Chromium] Merge final nits to DumpRenderTree.gyp for Android
12688         https://bugs.webkit.org/show_bug.cgi?id=90920
12689
12690         Reviewed by Tony Chang.
12691
12692         This patch contains the last few small changes to DumpRenderTree.gyp
12693         from the chromium-android branch. After this change, this file will be
12694         fully merged.
12695
12696         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
12697
12698 2012-08-01  Csaba Osztrogonác  <ossy@webkit.org>
12699
12700         [Qt] ImageDiff should use float division instead of integer
12701         https://bugs.webkit.org/show_bug.cgi?id=92859
12702
12703         Reviewed by Zoltan Herczeg.
12704
12705         * DumpRenderTree/qt/ImageDiff.cpp:
12706         (main):
12707
12708 2012-08-01  Sheriff Bot  <webkit.review.bot@gmail.com>
12709
12710         Unreviewed, rolling out r124313.
12711         http://trac.webkit.org/changeset/124313
12712         https://bugs.webkit.org/show_bug.cgi?id=92855
12713
12714         Compilation failed on Chromium ports (Requested by yosin on
12715         #webkit).
12716
12717         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
12718         * DumpRenderTree/DumpRenderTree.gypi:
12719         * DumpRenderTree/DumpRenderTree.h:
12720         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
12721         * DumpRenderTree/DumpRenderTreeCommon.cpp: Removed.
12722         * DumpRenderTree/chromium/DumpRenderTree.cpp:
12723         (runTest):
12724         (main):
12725         * DumpRenderTree/chromium/TestShell.cpp:
12726         (TestShell::TestShell):
12727         (TestShell::runFileTest):
12728         (TestShell::dump):
12729         * DumpRenderTree/chromium/TestShell.h:
12730         (TestParams):
12731         (TestParams::TestParams):
12732         (TestShell):
12733         * DumpRenderTree/efl/CMakeLists.txt:
12734         * DumpRenderTree/efl/DumpRenderTree.cpp:
12735         (parseCommandLineOptions):
12736         (getFinalTestURL):
12737         (getExpectedPixelHash):
12738         (runTest):
12739         (shouldDumpPixelsAndCompareWithExpected):
12740         (main):
12741         * DumpRenderTree/gtk/DumpRenderTree.cpp:
12742         (initializeGlobalsFromCommandLineOptions):
12743         (dump):
12744         (runTest):
12745         (main):
12746         * DumpRenderTree/mac/DumpRenderTree.mm:
12747         (initializeGlobalsFromCommandLineOptions):
12748         (dumpRenderTree):
12749         (dump):
12750         (runTest):
12751         * DumpRenderTree/qt/DumpRenderTree.pro:
12752         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
12753         (WebCore::DumpRenderTree::processLine):
12754         * DumpRenderTree/win/DumpRenderTree.cpp:
12755         (dump):
12756         (runTest):
12757         (dllLauncherEntryPoint):
12758         * DumpRenderTree/win/DumpRenderTree.vcproj:
12759         * DumpRenderTree/wscript:
12760         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
12761         (dump):
12762         (runTest):
12763         (MyApp::OnInit):
12764         * GNUmakefile.am:
12765         * Scripts/old-run-webkit-tests:
12766         * Scripts/webkitpy/layout_tests/port/base.py:
12767         (Port.supports_switching_pixel_tests_per_test):
12768         (Port):
12769         (Port._supports_switching_pixel_tests_per_test):
12770         (Port.should_run_as_pixel_test):
12771         * Scripts/webkitpy/layout_tests/port/driver.py:
12772         (Driver.cmd_line):
12773         (Driver._command_from_driver_input):
12774         * Scripts/webkitpy/layout_tests/port/qt.py:
12775         (QtPort._supports_switching_pixel_tests_per_test):
12776         * Scripts/webkitpy/layout_tests/port/test.py:
12777         (TestPort.supports_switching_pixel_tests_per_test):
12778         * WebKitTestRunner/TestController.cpp:
12779         (WTR::TestController::TestController):
12780         (WTR::TestController::initialize):
12781         (WTR::TestController::runTest):
12782         * WebKitTestRunner/TestController.h:
12783         (TestController):
12784
12785 2012-08-01  Balazs Kelemen  <kbalazs@webkit.org>
12786
12787         All ports should support per test switching of pixel testing
12788         https://bugs.webkit.org/show_bug.cgi?id=92398
12789
12790         Reviewed by Dirk Pranke.
12791
12792         Teach all test drivers to accept a per test control of whether
12793         to dump pixels. Drivers now accept a -p/--pixel-test argument
12794         on the standart input that means that running the current
12795         test as pixel test is allowed (even if the expected hash is
12796         missing). Removed the --pixel-tests command line option since
12797         there is no need for it anymore.
12798
12799         * DumpRenderTree/DumpRenderTree.gypi:
12800         * DumpRenderTree/DumpRenderTree.h:
12801         (TestCommand::TestCommand):
12802         (TestCommand):
12803         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
12804         * DumpRenderTree/DumpRenderTreeCommon.cpp: Added.
12805         (CommandTokenizer):
12806         (CommandTokenizer::CommandTokenizer):
12807         (CommandTokenizer::pump):
12808         (CommandTokenizer::next):
12809         (CommandTokenizer::hasNext):
12810         (die):
12811         (parseInputLine):
12812         Common logic to parse the input line from the standard input (or from the command line
12813         in standalone mode). Made it somewhat general so we can easily add more arguments if
12814         there is a need.
12815         * DumpRenderTree/chromium/DumpRenderTree.cpp:
12816         (runTest):
12817         (main):
12818         * DumpRenderTree/chromium/TestShell.cpp:
12819         (TestShell::TestShell):
12820         (TestShell::runFileTest):
12821         (TestShell::dump):
12822         * DumpRenderTree/chromium/TestShell.h:
12823         (TestParams::TestParams):
12824         (TestShell):
12825         * DumpRenderTree/efl/CMakeLists.txt:
12826         * DumpRenderTree/efl/DumpRenderTree.cpp:
12827         (parseCommandLineOptions):
12828         (runTest):
12829         (shouldDumpPixelsAndCompareWithExpected):
12830         (main):
12831         * DumpRenderTree/gtk/DumpRenderTree.cpp:
12832         (initializeGlobalsFromCommandLineOptions):
12833         (dump):
12834         * DumpRenderTree/mac/DumpRenderTree.mm:
12835         (initializeGlobalsFromCommandLineOptions):
12836         (dumpRenderTree):
12837         * DumpRenderTree/qt/DumpRenderTree.pro:
12838         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
12839         (WebCore::DumpRenderTree::processLine):
12840         * DumpRenderTree/win/DumpRenderTree.cpp:
12841         (dump):
12842         (runTest):
12843         (dllLauncherEntryPoint):
12844         * DumpRenderTree/win/DumpRenderTree.vcproj:
12845         * DumpRenderTree/wscript:
12846         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
12847         (dump):
12848         (runTest):
12849         (MyApp::OnInit):
12850         * Scripts/old-run-webkit-tests: Pass --pixel-test before the hash.
12851         Changed the separator form ' to : because it don't need to be escaped
12852         when passing manually on the comand line.
12853         * Scripts/webkitpy/layout_tests/port/base.py:
12854         (Port.should_run_as_pixel_test): Removed now that all ports supports it.
12855         * Scripts/webkitpy/layout_tests/port/driver.py:
12856         (Driver.cmd_line): Don't pass --pixel-tests anymore.
12857         (Driver._command_from_driver_input):
12858
12859         * WebKitTestRunner/TestController.cpp:
12860         (WTR::TestController::TestController):
12861         (WTR::TestController::initialize):
12862         (WTR::TestCommand::TestCommand):
12863         (TestCommand):
12864         (WTR):
12865         (CommandTokenizer):
12866         (WTR::CommandTokenizer::CommandTokenizer):
12867         (WTR::CommandTokenizer::pump):
12868         (WTR::CommandTokenizer::next):
12869         (WTR::CommandTokenizer::hasNext):
12870         (WTR::die):
12871         (WTR::parseInputLine):
12872         (WTR::TestController::runTest):
12873         * WebKitTestRunner/TestController.h:
12874         (TestController):
12875         Duplicate the logic for parsing the command line because
12876         unfortunately there is no way to share code between
12877         WebKitTestRunner and DumpRenderTree.
12878
12879 2012-08-01  Martin Robinson  <mrobinson@igalia.com>
12880
12881         Add the jhbuild source directory to the __builtin__ object
12882
12883         Reviewed by Philippe Normand.
12884
12885         It seems that the jhbuild script explicitly looks for the SRCDIR __builtin__ when
12886         initializing. This is necessary for loading the jhbuild from the checkout directory.
12887
12888         * jhbuild/jhbuildutils.py:
12889         (enter_jhbuild_environment_if_available): Set SRCDIR to the source directory.
12890
12891 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
12892
12893         nrwt: move actual test-running code into layout_test_runner.py
12894         https://bugs.webkit.org/show_bug.cgi?id=92806
12895
12896         Reviewed by Ryosuke Niwa.
12897
12898         This is the final patch in manager-refactoring series (for now).
12899         This moves all of the logic to actually run the tests into
12900         layout_test_runner (in a new LayoutTestRunner) class. Now
12901         the mechanics of actually executing all of  the tests are
12902         contained in one file (of course the actual work of talking to
12903         DRT/WTR and diff'ing the results is still in single_test_runner).
12904
12905         Now manager is left with setting up and tearing down the test
12906         environment, finding the tests to run, and processing the
12907         results of the tests, which is a pretty managable amount of code
12908         (no pun intended).
12909
12910         The unit tests for manager were split in two and all of the
12911         runner-specific tests moved into layout_test_runner_unittest.
12912         They were significantly cleaned up to be easier to read and
12913         maintain as a part of this.
12914
12915         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
12916         (TestRunInterruptedException):
12917         (TestRunInterruptedException.__init__):
12918         (TestRunInterruptedException.__reduce__):
12919         (LayoutTestRunner):
12920         (LayoutTestRunner.__init__):
12921         (LayoutTestRunner.test_key):
12922         (LayoutTestRunner.run_tests):
12923         (LayoutTestRunner.run_tests.worker_factory):
12924         (LayoutTestRunner.run_tests.instead):
12925         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
12926         (LayoutTestRunner._interrupt_if_at_failure_limits):
12927         (LayoutTestRunner._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
12928         (LayoutTestRunner._update_summary_with_result):
12929         (LayoutTestRunner.start_servers_with_lock):
12930         (LayoutTestRunner.stop_servers_with_lock):
12931         (LayoutTestRunner.handle):
12932         (LayoutTestRunner._handle_started_test):
12933         (LayoutTestRunner._handle_finished_test_list):
12934         (LayoutTestRunner._handle_finished_test_list.find):
12935         (LayoutTestRunner._handle_finished_test):
12936         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
12937         (FakePrinter):
12938         (FakePrinter.print_workers_and_shards):
12939         (FakePrinter.print_finished_test):
12940         (FakePrinter.write):
12941         (FakePrinter.write_update):
12942         (FakePrinter.flush):
12943         (LockCheckingRunner):
12944         (LockCheckingRunner.__init__):
12945         (LockCheckingRunner.handle_finished_list):
12946         (LayoutTestRunnerTests):
12947         (LayoutTestRunnerTests._runner):
12948         (LayoutTestRunnerTests._result_summary):
12949         (LayoutTestRunnerTests._run_tests):
12950         (LayoutTestRunnerTests.test_http_locking):
12951         (LayoutTestRunnerTests.test_perf_locking):
12952         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
12953         (LayoutTestRunnerTests.test_update_summary_with_result):
12954         (LayoutTestRunnerTests.test_servers_started):
12955         (LayoutTestRunnerTests.test_servers_started.start_http_server):
12956         (LayoutTestRunnerTests.test_servers_started.start_websocket_server):
12957         (LayoutTestRunnerTests.test_servers_started.stop_http_server):
12958         (LayoutTestRunnerTests.test_servers_started.stop_websocket_server):
12959         * Scripts/webkitpy/layout_tests/controllers/manager.py:
12960         (summarize_results):
12961         (Manager.__init__):
12962         (Manager._is_http_test):
12963         (Manager):
12964         (Manager._is_websocket_test):
12965         (Manager._websocket_tests):
12966         (Manager._prepare_lists):
12967         (Manager._is_ref_test):
12968         (Manager.run):
12969         (Manager._run_tests):
12970         (Manager._look_for_new_crash_logs):
12971         (Manager._show_results_html_file):
12972         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
12973         (ManagerTest.test_look_for_new_crash_logs):
12974         (ResultSummaryTest.summarized_results):
12975         (ResultSummaryTest.test_summarized_results_wontfix):
12976
12977 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
12978
12979         nrwt: move sharding logic into layout_test_runner.py
12980         https://bugs.webkit.org/show_bug.cgi?id=92805
12981
12982         Reviewed by Ryosuke Niwa.
12983
12984         The sharding logic is specific to how we actually run the tests,
12985         so it belongs in this file instead of manager.py or finder.py.
12986
12987         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
12988         (Worker._run_single_test):
12989         (TestShard):
12990         (TestShard.__init__):
12991         (TestShard.__repr__):
12992         (TestShard.__eq__):
12993         (Sharder):
12994         (Sharder.__init__):
12995         (Sharder.shard_tests):
12996         (Sharder.shard_tests.or):
12997         (Sharder._shard_in_two):
12998         (Sharder._shard_every_file):
12999         (Sharder._shard_by_directory):
13000         (Sharder._resize_shards):
13001         (Sharder._resize_shards.divide_and_round_up):
13002         (Sharder._resize_shards.extract_and_flatten):
13003         (Sharder._resize_shards.split_at):
13004         (Sharder._dir_for_test_input):
13005         (Sharder.test_key):
13006         (Sharder.natural_sort_key):
13007         (Sharder.natural_sort_key.tryint):
13008         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Added.
13009         (SharderTests):
13010         (SharderTests.get_test_input):
13011         (SharderTests.get_shards):
13012         (SharderTests.get_shards.split):
13013         (SharderTests.assert_shards):
13014         (SharderTests.test_shard_by_dir):
13015         (SharderTests.test_shard_by_dir_sharding_ref_tests):
13016         (SharderTests.test_shard_every_file):
13017         (SharderTests.test_shard_in_two):
13018         (SharderTests.test_shard_in_two_sharding_ref_tests):
13019         (SharderTests.test_shard_in_two_has_no_locked_shards):
13020         (SharderTests.test_shard_in_two_has_no_unlocked_shards):
13021         (SharderTests.test_multiple_locked_shards):
13022         (NaturalCompareTest):
13023         (NaturalCompareTest.assert_cmp):
13024         (NaturalCompareTest.test_natural_compare):
13025         (KeyCompareTest):
13026         (KeyCompareTest.setUp):
13027         (KeyCompareTest.setUp.split):
13028         (KeyCompareTest.assert_cmp):
13029         (KeyCompareTest.test_test_key):
13030         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13031         (Manager.__init__):
13032         (Manager._prepare_lists):
13033         (Manager._is_ref_test):
13034         (Manager._run_tests):
13035         (Manager._handle_finished_test):
13036         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
13037         (ManagerTest.get_options):
13038         (ManagerTest.test_interrupt_if_at_failure_limits):
13039         (ManagerTest.test_update_summary_with_result):
13040         (ManagerTest.test_needs_servers.get_manager_with_tests):
13041         (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
13042         (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
13043         (ManagerTest.test_servers_started):
13044         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
13045         (parse_args):
13046
13047 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
13048
13049         nrwt: rename worker.py to layout_test_runner.py
13050         https://bugs.webkit.org/show_bug.cgi?id=92804
13051
13052         Reviewed by Ojan Vafai.
13053
13054         Home stretch of this round of manager refactoring ... I will be
13055         moving all of the actual test-running code (which includes the
13056         code that shards the tests for the workers) into a different
13057         module, and it makes sense for that module to contain the actual
13058         worker code, so I'm renaming worker.py to layout_test_runner.py.
13059
13060         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/worker.py.
13061         (Worker):
13062         (Worker.__init__):
13063         (Worker.__del__):
13064         (Worker.start):
13065         (Worker.handle):
13066         (Worker._update_test_input):
13067         (Worker._run_test):
13068         (Worker.stop):
13069         (Worker._timeout):
13070         (Worker._kill_driver):
13071         (Worker._run_test_with_timeout):
13072         (Worker._clean_up_after_test):
13073         (Worker._run_test_in_another_thread):
13074         (Worker._run_test_in_another_thread.SingleTestThread):
13075         (Worker._run_test_in_another_thread.SingleTestThread.__init__):
13076         (Worker._run_test_in_another_thread.SingleTestThread.run):
13077         (Worker._run_test_in_this_thread):
13078         (Worker._run_single_test):
13079         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13080         (Manager._run_tests.worker_factory):
13081
13082 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
13083
13084         nrwt: clean up names in sharding code
13085         https://bugs.webkit.org/show_bug.cgi?id=92785
13086
13087         Reviewed by Ryosuke Niwa.
13088
13089         More refactoring ... this makes the methods use TestInputs
13090         consistently (and updates the names accordingly) and improves
13091         encapsulation a bit. The sharding code is now pretty
13092         self-contained.
13093
13094         This change adds no new functionality and is covered by the
13095         existing (updated) tests.
13096
13097         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13098         (TestShard.visible.__init__):
13099         (TestShard.visible.__repr__):
13100         (Manager._dir_for_test_input):
13101         (Manager._shard_tests):
13102         (Manager._shard_in_two):
13103         (Manager._shard_every_file):
13104         (Manager._shard_by_directory):
13105         (Manager._run_tests):
13106         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
13107         (ManagerWrapper._test_input_for_file):
13108         (ShardingTests.get_shards):
13109         * Scripts/webkitpy/layout_tests/models/test_input.py:
13110         (TestInput.__init__):
13111         (TestInput.__repr__):
13112
13113 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
13114
13115         nrwt: clean up TestInputs in preparation for cleaning up sharding
13116         https://bugs.webkit.org/show_bug.cgi?id=92784
13117
13118         Reviewed by Ryosuke Niwa.
13119
13120         Currently, in order to shard the tests you need to refer to
13121         state in the manager as well as the state in the TestInputs;
13122         this change embeds the necessary state into the TestInputs so
13123         sharding them can be a standalone operation.
13124
13125         The actual clean up of the sharding will follow in a subsequent patch.
13126
13127         Covered by existing tests; no new functionality. However, I did
13128         rework the sharding tests to be less dependent on the test
13129         scaffolding and easier to follow.
13130
13131         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13132         (Manager._test_input_for_file):
13133         (Manager._shard_in_two):
13134         (Manager._shard_every_file):
13135         (Manager._shard_by_directory):
13136         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
13137         (ManagerWrapper._test_input_for_file):
13138         (ShardingTests.assert_shards):
13139         (ShardingTests.test_shard_by_dir):
13140         (ShardingTests.test_shard_by_dir_sharding_ref_tests):
13141         (ShardingTests.test_shard_every_file):
13142         (ShardingTests.test_shard_in_two):
13143         (ShardingTests.test_shard_in_two_sharding_ref_tests):
13144         (ShardingTests.test_shard_in_two_has_no_unlocked_shards):
13145         (ShardingTests.test_multiple_locked_shards):
13146         * Scripts/webkitpy/layout_tests/models/test_input.py:
13147         (TestInput.__init__):
13148         (TestInput.__repr__):
13149
13150 2012-07-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
13151
13152         [EFL] Dump a backtrace in case of a crash
13153         https://bugs.webkit.org/show_bug.cgi?id=92489
13154
13155         Reviewed by Csaba Osztrogonác.
13156
13157         Dump a stack trace in case of a unexpected signal. This should
13158         provide a better report at the build bots when WTR crashes.
13159
13160         * DumpRenderTree/efl/DumpRenderTree.cpp:
13161         (main):
13162         * TestWebKitAPI/efl/InjectedBundleController.cpp:
13163         (TestWebKitAPI::InjectedBundleController::platformInitialize):
13164         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp:
13165         (WTR::InjectedBundle::platformInitialize):
13166
13167 2012-07-31  Joshua Netterfield  <jnetterfield@rim.com>
13168
13169         [BlackBerry] Enable CSS Filter Effects
13170         https://bugs.webkit.org/show_bug.cgi?id=92685
13171
13172         Reviewed by Rob Buis.
13173
13174         Enable CSS filter effects, with the exception of custom effects (CSS shaders) and reference effects (SVG effects)
13175
13176         Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.
13177
13178         * Scripts/webkitperl/FeatureList.pm: Acknowledge CSS filter effects.
13179
13180 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
13181
13182         nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
13183         https://bugs.webkit.org/show_bug.cgi?id=92781
13184
13185         Reviewed by Ryosuke Niwa.
13186
13187         More refactoring ... rename prepare_lists_and_print_output to
13188         just prepare_lists so that it only has a single purpose, and
13189         clean up the surrounding code a bit as well.
13190
13191         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13192         (Manager._collect_tests):
13193         (Manager._prepare_lists):
13194         (Manager._set_up_run):
13195         (Manager.run):
13196
13197 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
13198
13199         nrwt: clean up self._test_files_list vs. self._test_files, other nits
13200         https://bugs.webkit.org/show_bug.cgi?id=92702
13201
13202         Reviewed by Ojan Vafai.
13203
13204         Get rid of self._test_files, rename self._test_files_list to
13205         self._test_names (removing the confusion between the two fields).
13206
13207         Also inline the one call to _parse_expectations, remove the one
13208         use of more_tests_to_skip, and fix a couple of minor nits.
13209
13210         * Scripts/webkitpy/layout_tests/controllers/finder.py:
13211         (LayoutTestFinder.split_into_chunks):
13212         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13213         (Manager.__init__):
13214         (Manager._collect_tests):
13215         (Manager._http_tests):
13216         (Manager._websocket_tests):
13217         (Manager._is_perf_test):
13218         (Manager.prepare_lists_and_print_output):
13219         (Manager.needs_servers):
13220         (Manager.run):
13221         (Manager._mark_interrupted_tests_as_skipped):
13222         (Manager._update_summary_with_result):
13223         (Manager._upload_json_files):
13224         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
13225         (ManagerTest.test_interrupt_if_at_failure_limits):
13226         (ManagerTest.test_needs_servers.get_manager_with_tests):
13227         (ManagerTest.test_servers_started):
13228
13229 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
13230
13231         nrwt: --verbose logging does not work right on windows
13232         https://bugs.webkit.org/show_bug.cgi?id=92673
13233
13234         Reviewed by Ojan Vafai.
13235
13236         Add a test for r124090.
13237
13238         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
13239         (MainTest.test_verbose):
13240
13241 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
13242
13243         REGRESSION(124116): Number of skipped tests isn't printed anymore
13244         https://bugs.webkit.org/show_bug.cgi?id=92736
13245
13246         Reviewed by Tony Chang.
13247
13248         Add the skipped number back in; it was useful ... also clean up
13249         the formatting a little bit.
13250
13251         * Scripts/webkitpy/layout_tests/views/printing.py:
13252         (Printer.print_found):
13253
13254 2012-07-31  Hans Wennborg  <hans@chromium.org>
13255
13256         Speech JavaScript API: Throw exception for start() when already started
13257         https://bugs.webkit.org/show_bug.cgi?id=92756
13258
13259         Reviewed by Adam Barth.
13260
13261         Fix the task queue in MockWebSpeechRecognizer.
13262         It's important that we remove the task from the queue before we run
13263         it, as running the task could alter the queue's state.
13264
13265         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
13266         (MockWebSpeechRecognizer::abort):
13267         (MockWebSpeechRecognizer::setError):
13268         (MockWebSpeechRecognizer::clearTaskQueue):
13269         (MockWebSpeechRecognizer::StepTask::runIfValid):
13270         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
13271         (MockWebSpeechRecognizer):
13272
13273 2012-07-31  Dirk Pranke  <dpranke@chromium.org>
13274
13275         nrwt: move handling the initial list of tests to skip to finder
13276         https://bugs.webkit.org/show_bug.cgi?id=92701
13277
13278         Reviewed by Ryosuke Niwa.
13279
13280         More refactoring of manager ...
13281
13282         * Scripts/webkitpy/layout_tests/controllers/finder.py:
13283         (LayoutTestFinder.skip_tests):
13284         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13285         (Manager._collect_tests):
13286         (Manager.prepare_lists_and_print_output):
13287
13288 2012-07-31  Alexey Proskuryakov  <ap@apple.com>
13289
13290         [WK2] Kill the concept of secondary shared process
13291         https://bugs.webkit.org/show_bug.cgi?id=92676
13292
13293         Reviewed by Sam Weinig.
13294
13295         * MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Update Windows build fix.
13296         Don't create a new context for every view.
13297
13298 2012-07-31  Peter Beverloo  <peter@chromium.org>
13299
13300         [Chromium] Don't use ninja for building Chromium for Android
13301         https://bugs.webkit.org/show_bug.cgi?id=92764
13302
13303         Reviewed by Adam Barth.
13304
13305         When Ninja projects files are generated (which will be done for Android),
13306         make sure that the Android builder doesn't unintentionally switch to
13307         using Ninja. We should make that switch at a predetermined time.
13308
13309         * Scripts/webkitdirs.pm:
13310         (buildChromium):
13311
13312 2012-07-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
13313
13314         Add a mechanism to dump the stack trace in case of a crash
13315         https://bugs.webkit.org/show_bug.cgi?id=92666
13316
13317         Reviewed by Csaba Osztrogonác.
13318
13319         Move crash signal handlers to WTFInstallReportBacktraceOnCrashHook()
13320         and eliminate some duplicated code.
13321
13322         * DumpRenderTree/qt/main.cpp:
13323         (main):
13324         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
13325         (WTR::InjectedBundle::platformInitialize):
13326
13327 2012-07-31  Jochen Eisinger  <jochen@chromium.org>
13328
13329         [chromium] move EventSender into TestRunner.a
13330         https://bugs.webkit.org/show_bug.cgi?id=92277
13331
13332         Reviewed by Adam Barth.
13333
13334         * DumpRenderTree/DumpRenderTree.gypi:
13335         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
13336         * DumpRenderTree/chromium/TestRunner/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/EventSender.cpp.
13337         * DumpRenderTree/chromium/TestRunner/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/EventSender.h.
13338         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
13339         (TestInterfaces::Internal::eventSender):
13340         (TestInterfaces::Internal):
13341         (TestInterfaces::Internal::Internal):
13342         (TestInterfaces::Internal::~Internal):
13343         (TestInterfaces::Internal::setWebView):
13344         (TestInterfaces::Internal::setDelegate):
13345         (TestInterfaces::Internal::bindTo):
13346         (TestInterfaces::Internal::resetAll):
13347         (TestInterfaces::eventSender):
13348         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
13349         (TestInterfaces):
13350         * DumpRenderTree/chromium/TestShell.cpp:
13351         (TestShell::initialize):
13352         (TestShell::createMainWindow):
13353         (TestShell::~TestShell):
13354         (TestShell::resetTestController):
13355         (TestShell::bindJSObjectsToWindow):
13356         * DumpRenderTree/chromium/TestShell.h:
13357         (TestShell::eventSender):
13358         (TestShell):
13359         * DumpRenderTree/chromium/WebViewHost.cpp:
13360
13361 2012-07-31  Jochen Eisinger  <jochen@chromium.org>
13362
13363         Unreviewed. Update watchlist
13364
13365         * Scripts/webkitpy/common/config/watchlist: Turned out to be less useful than I had hoped
13366
13367 2012-07-31  Kent Tamura  <tkent@chromium.org>
13368
13369         Unreviewed, update watchlist
13370
13371         * Scripts/webkitpy/common/config/watchlist:
13372         - Improve "Forms" filename pattern.
13373         - tkent stops watching Chromium DRT. It was not so helpful.
13374
13375 2012-07-31  Martin Robinson  <mrobinson@igalia.com>
13376
13377         [jhbuild] Also try to load jhbuild Python module from the source checkout
13378
13379         Reviewed by Philippe Normand.
13380
13381         JHBuild also seems to have an installation mode where it prefers to load its
13382         Python modules from the source checkout. This seems to be used particularly
13383         on the GTK+ 64-bit release bot. We should fall back to this mode.
13384
13385         * jhbuild/jhbuildutils.py:
13386         (enter_jhbuild_environment_if_available): Use the source checkout if there
13387         is no installation path.
13388
13389 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
13390
13391         Revert r124153 and land the "right" build fix per ap's comment on the bug 92676.
13392
13393         * MiniBrowser/win/BrowserView.cpp:
13394         (BrowserView::create):
13395
13396 2012-07-30  Sam Weinig  <sam@webkit.org>
13397
13398         Rename WebKit2.h to WebKit2_C.h
13399         https://bugs.webkit.org/show_bug.cgi?id=92704
13400
13401         Reviewed by Dan Bernstein.
13402
13403         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
13404         * MiniBrowser/win/BrowserView.h:
13405         * TestWebKitAPI/config.h:
13406         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
13407         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
13408         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
13409         * WebKitTestRunner/config.h:
13410         Update for changed header file name.
13411
13412 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
13413
13414         chromium win compile broken after removing webkit.py
13415         https://bugs.webkit.org/show_bug.cgi?id=92549
13416
13417         Reviewed by Ryosuke Niwa.
13418
13419         Remove the stub file for webkit.py now that it's no longer
13420         necessary.
13421
13422         * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
13423
13424 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
13425
13426         Windows build fix attempt after r124092.
13427
13428         * MiniBrowser/win/BrowserView.cpp:
13429         (BrowserView::create):
13430
13431 2012-07-30  Ryosuke Niwa  <rniwa@webkit.org>
13432
13433         Remove erroneously committed debugging print call from a test.
13434
13435         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
13436         (test_run_generates_results_page):
13437
13438 2012-07-30  Arnaud Renevier  <a.renevier@sisa.samsung.com>
13439
13440         webkit-patch: system keyring is not used to read my password
13441         https://bugs.webkit.org/show_bug.cgi?id=92532
13442
13443         Reviewed by Dirk Pranke.
13444
13445         In case no username can be fetched from environment, git or keychain,
13446         prompt for username, and try to get password from keyring associated
13447         with that username.
13448
13449         * Scripts/webkitpy/common/net/credentials.py:
13450         (Credentials.read_credentials):
13451         * Scripts/webkitpy/common/net/credentials_unittest.py:
13452         (test_keyring_without_git_repo_nor_keychain):
13453         (test_keyring_without_git_repo_nor_keychain.MockKeyring):
13454         (test_keyring_without_git_repo_nor_keychain.MockKeyring.get_password):
13455         (test_keyring_without_git_repo_nor_keychain.FakeCredentials):
13456         (test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_keychain):
13457         (test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_environment):
13458         (test_keyring_without_git_repo_nor_keychain.FakeUser):
13459         (test_keyring_without_git_repo_nor_keychain.FakeUser.prompt):
13460         (test_keyring_without_git_repo_nor_keychain.FakeUser.prompt_password):
13461
13462 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
13463
13464         nrwt: move the code that identifies the chunk of tests to run into finder
13465         https://bugs.webkit.org/show_bug.cgi?id=92694
13466
13467         Reviewed by Ryosuke Niwa.
13468
13469         Another patch to make manager.py smaller and clearer; this patch moves
13470         the handling of breaking the list of tests into chunks (--run-part,
13471         --run-chunk) from manager.py to finder.py.
13472
13473         There are no functional changes and this is covered by existing tests.
13474
13475         * Scripts/webkitpy/layout_tests/controllers/finder.py:
13476         (Finder.__init__):
13477         (Finder._read_test_files):
13478         (Finder):
13479         (Finder.split_into_chunks_if_necessary):
13480         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13481         (Manager.__init__):
13482         (Manager._collect_tests):
13483         (Manager._parse_expectations):
13484         (Manager.prepare_lists_and_print_output):
13485
13486 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
13487
13488         nrwt: split test-finding code out from manager.py
13489         https://bugs.webkit.org/show_bug.cgi?id=92693
13490
13491         Reviewed by Ryosuke Niwa.
13492
13493         In the interest of making manager.py smaller, this patch moves
13494         the code that actually takes the command line arguments and
13495         --test-file lists of tests to run and expands them into an
13496         actual list of tests out into a separate module.
13497
13498         * Scripts/webkitpy/layout_tests/controllers/finder.py: Added.
13499         (LayoutTestFinder):
13500         (LayoutTestFinder.__init__):
13501         (LayoutTestFinder.find_tests):
13502         (LayoutTestFinder._strip_test_dir_prefixes):
13503         (LayoutTestFinder._strip_test_dir_prefix):
13504         (LayoutTestFinder._read_test_names_from_file):
13505         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13506         (Manager._collect_tests):
13507         (Manager._handle_finished_test):
13508         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
13509         (strip_comments):
13510
13511 2012-07-30  Adam Barth  <abarth@webkit.org>
13512
13513         commit-queue is corrupting ChangeLogs
13514         https://bugs.webkit.org/show_bug.cgi?id=92681
13515
13516         Reviewed by Tony Chang.
13517
13518         Some commits made with the commit-queue are ending up with duplicate
13519         ChangeLog entries. I've hot-patched the servers to not use a special
13520         merge driver for ChangeLogs, which should fix this issue. This patch
13521         removes the merge driver from our cold-boot.sh script so that we won't
13522         use it on new commit-queue instances.
13523
13524         * EWSTools/cold-boot.sh:
13525
13526 2012-07-28  Sam Weinig  <sam@webkit.org>
13527
13528         Add ability to load from a string to the ObjC WK API
13529         https://bugs.webkit.org/show_bug.cgi?id=92590
13530
13531         Reviewed by Dan Bernstein.
13532
13533         Add tests for [WKBrowsingContextController loadHTMLString:baseURL:]. We will be able
13534         to greatly improve these tests (to test more than just not crashing) when methods to
13535         access page content are added (soon!).
13536
13537         Adds:
13538             Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString
13539             Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilBaseURL
13540             Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL
13541
13542         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
13543         Adds tests and refactors delegates to not use global state.
13544
13545 2012-07-30  Thiago Marcos P. Santos  <thiago.santos@intel.com>
13546
13547         [CMake] TestWebKitAPI bundle should link with WTF
13548         https://bugs.webkit.org/show_bug.cgi?id=92616
13549
13550         Reviewed by Antonio Gomes.
13551
13552         Fixes build when shared core is disabled.
13553
13554         * TestWebKitAPI/CMakeLists.txt:
13555
13556 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
13557
13558         nrwt: clean up handling of 'expected' stats
13559         https://bugs.webkit.org/show_bug.cgi?id=92527
13560
13561         Reviewed by Tony Chang.
13562
13563         This patch alters the way we compute and log the "expected"
13564         results and how we treat skipped tests; we will now log the
13565         number of skipped tests separately from the categories, e.g.:
13566
13567         Found 31607 tests; running 24464.
13568         Expect: 23496 passes   (23496 now,    0 wontfix)
13569         Expect:   548 failures (  543 now,    5 wontfix)
13570         Expect:   420 flaky    (  245 now,  175 wontfix)
13571
13572         (so that the "expect" totals add up to the "running" totals);
13573         in addition, the totals in the one-line-progress reflect the
13574         number of tests we will actually run. If --iterations or
13575         --repeat-each are specified, the number of tests we run are
13576         multiplied as appropriate, but the "expect" numbers are
13577         unchanged, since we don't count multiple invocations of the same
13578         test multiple times. In addition, if we are using --run-part or
13579         --run-chunk, the tests we don't run are treated as skipped
13580         for consistency. We will also log the values for --iterations
13581         and --repeat each as part of the found/running line.
13582
13583         Previously the code had parsed and re-parsed the
13584         TestExpectations files several times in an attempt to come up
13585         with some sane statistics, but this was expensive and lead to
13586         confusing layer; treating files as skipped in the way described
13587         above is more consistent and cleaner.
13588
13589         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13590         (Manager._split_into_chunks_if_necessary):
13591         (Manager.prepare_lists_and_print_output):
13592         (Manager.run):
13593         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
13594         (ManagerTest.test_interrupt_if_at_failure_limits):
13595         (ManagerTest.test_update_summary_with_result):
13596         (ManagerTest.test_look_for_new_crash_logs):
13597         (ResultSummaryTest.get_result_summary):
13598         * Scripts/webkitpy/layout_tests/models/result_summary.py:
13599         (ResultSummary.__init__):
13600         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
13601         (TestExpectationParser.expectation_for_skipped_test):
13602         (TestExpectations.__init__):
13603         (TestExpectations.add_skipped_tests):
13604           Here we make add_skipped_tests() public, so that we can update
13605           the expectations for tests that we are skipping due to
13606           --run-part or --run-chunk; we use the wontfix flag so that
13607           the tests that are intentionally skipped aren't considered
13608           "fixable".
13609         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
13610         (SkippedTests.check):
13611         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
13612         (parse_args):
13613         * Scripts/webkitpy/layout_tests/views/printing.py:
13614         (Printer.print_found):
13615         (Printer):
13616         (Printer.print_expected):
13617         (Printer._print_result_summary):
13618         (Printer._print_result_summary_entry):
13619           Here we split out printing the number of tests found and run
13620           from the expected results, to be clearer and so that we don't
13621           have to reparse the expectations to update the stats.
13622         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
13623         (Testprinter.get_result_summary):
13624
13625 2012-07-30  Sadrul Habib Chowdhury  <sadrul@chromium.org>
13626
13627         Propagate gesture events to plugins.
13628         https://bugs.webkit.org/show_bug.cgi?id=92281
13629
13630         Reviewed by Adam Barth.
13631
13632         Update TestWebPlugin to receive events, and output logs for the events.
13633
13634         * DumpRenderTree/chromium/TestWebPlugin.cpp:
13635         (TestWebPlugin::handleInputEvent):
13636         * DumpRenderTree/chromium/TestWebPlugin.h:
13637         (TestWebPlugin::acceptsInputEvents):
13638         (TestWebPlugin):
13639
13640 2012-07-30  Raphael Kubo da Costa  <rakuco@webkit.org>
13641
13642         [jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0
13643         https://bugs.webkit.org/show_bug.cgi?id=90643
13644
13645         Reviewed by Gustavo Noronha Silva.
13646
13647         The 2.x series of gnutls has a version of Gnulib that is
13648         incompatible with glibc 2.16.0, which now does not define gets()
13649         by default.
13650
13651         After talking to kov, mrobinson and philn, it looks like it makes
13652         sense to simply remove gnutls from jhbuild.modules and rely on the
13653         version installed on the system being recent enough.
13654
13655         This means at least version 2.12.8 for PKCS11 support, or at the
13656         very least 2.11.0 (these are the minimum versions enforced by
13657         glib-networking's configure.ac).
13658
13659         * efl/jhbuild.modules: Do not build gnutls anymore, make
13660         glib-networking depend on glib instead, and move the libgcrypt
13661         dependency to eet, which is what currently needs it.
13662         * gtk/jhbuild.modules: Do not build gnutls anymore.
13663
13664 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
13665
13666         nrwt: --verbose logging does not work right on windows
13667         https://bugs.webkit.org/show_bug.cgi?id=92673
13668
13669         Unreviewed, build fix.
13670
13671         The --verbose log level is not being propagated to the worker
13672         processes on windows properly; this has been broken ever since I
13673         refactored logging into the message pool directly :(.
13674
13675         Also, fixing this revealed that outputcapture wasn't saving and
13676         restoring log levels correctly, so I had to fix that as well.
13677
13678         * Scripts/webkitpy/common/message_pool.py:
13679         (_MessagePool._start_workers):
13680         (_MessagePool._worker_log_level):
13681         (_Worker.__init__):
13682         (_Worker._set_up_logging):
13683         (_WorkerLogHandler.__init__):
13684         * Scripts/webkitpy/common/system/outputcapture.py:
13685         (OutputCapture.capture_output):
13686         (OutputCapture.restore_output):
13687
13688 2012-07-30  Dirk Pranke  <dpranke@chromium.org>
13689
13690         After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
13691         https://bugs.webkit.org/show_bug.cgi?id=92664
13692
13693         Reviewed by Michael Saboff.
13694
13695         Updated to handle crash_logs being returned as a tuple of (stderr, crash_log).
13696
13697         * Scripts/webkitpy/layout_tests/port/mac.py:
13698         (MacPort.look_for_new_crash_logs):
13699
13700 2012-07-30  Stephen White  <senorblanco@chromium.org>
13701
13702         Added a SkiaGraphics definition to the watchlist file; cc'ed myself
13703         to that group.  Unreviewed.
13704
13705         * Scripts/webkitpy/common/config/watchlist:
13706
13707 2012-07-30  Sheriff Bot  <webkit.review.bot@gmail.com>
13708
13709         Unreviewed, rolling out r123966 and r123967.
13710         http://trac.webkit.org/changeset/123966
13711         http://trac.webkit.org/changeset/123967
13712         https://bugs.webkit.org/show_bug.cgi?id=92656
13713
13714         This patch is causing assertion failures on the debug bot
13715         (also rolling out a dependent patch) (Requested by mrobinson
13716         on #webkit).
13717
13718         * gtk/generate-gtkdoc:
13719         (get_webkit2_options):
13720
13721 2012-07-30  Martin Robinson  <mrobinson@igalia.com>
13722
13723         [GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
13724         https://bugs.webkit.org/show_bug.cgi?id=92626
13725
13726         Reviewed by Gustavo Noronha Silva.
13727
13728         Instead of always shelling out to enter a jhbuild environment, add a Python
13729         hook for entering a jhbuild environment directly. This avoids requiring a
13730         script to be wrapped in jhbuild.
13731
13732         * GNUmakefile.am: Remove gtk/run-api-tests from the distribution list.
13733         * Scripts/run-gtk-tests: Move most of the logic from run-api-tests here
13734         with additional code for entering a jhbuild environment directly.
13735         * gtk/run-api-tests: Removed.
13736         * jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py.
13737         * jhbuild/jhbuildutils.py: Add some new helper methods here including
13738         a method which can transform the current environment into a jhbuild-ified one.
13739
13740 2012-07-30  Alexander Pavlov  <apavlov@chromium.org>
13741
13742         Unreviewed, upgrade apavlov to reviewer.
13743         http://lists.webkit.org/mailman/private/webkit-committers/2012-July/000184.html
13744
13745         * Scripts/webkitpy/common/config/committers.py:
13746
13747 2012-07-30  Robin Cao  <robin.cao@torchmobile.com.cn>
13748
13749         [BlackBerry] Adapt to changes in the SharedArray platform API
13750         https://bugs.webkit.org/show_bug.cgi?id=92631
13751
13752         Reviewed by Rob Buis.
13753
13754         Adapt to changes in the SharedArray platform API. No behavioural change.
13755
13756         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
13757         (LayoutTestController::webHistoryItemCount):
13758
13759 2012-07-30  Balazs Kelemen  <kbalazs@webkit.org>
13760
13761         [Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
13762         https://bugs.webkit.org/show_bug.cgi?id=92627
13763
13764         Reviewed by Noam Rosenthal.
13765
13766         Remove the default behavior I added in r123729 so that we run all tests as pixel
13767         test with -p. It was intentional but it seems like we don't have consensus on
13768         that we want it.
13769
13770         * Scripts/webkitpy/layout_tests/port/qt.py:
13771         (QtPort._supports_switching_pixel_tests_per_test):
13772
13773 2012-07-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
13774
13775         [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
13776         https://bugs.webkit.org/show_bug.cgi?id=92366
13777
13778         Reviewed by Antonio Gomes.
13779
13780         Add SHIFT modifier for capital letters as VK_
13781         codes do not distinguish between lows and caps and also to be consistent
13782         with other ports which send caps as lowercase letters with the shift key down.
13783
13784         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
13785         (WTR::EventSenderProxy::keyDown):
13786
13787 2012-07-29  Raphael Kubo da Costa  <rakuco@webkit.org>
13788
13789         [EFL][jhbuild] Make run-with-jhbuild become the jhbuild process itself.
13790         https://bugs.webkit.org/show_bug.cgi?id=92592
13791
13792         Reviewed by Eric Seidel.
13793
13794         Adapt to the changes made to GTK+'s run-with-jhbuild in r123979
13795         and make EFL's run-with-jhbuild call os.execve() instead of
13796         launching a subprocess as well.
13797
13798         This should make it possible to interrupt execution of jhbuild
13799         cleanly.
13800
13801         * efl/run-with-jhbuild:
13802
13803 2012-07-28  Ryosuke Niwa  <rniwa@webkit.org>
13804
13805         run-perf-tests should generate a results page
13806         https://bugs.webkit.org/show_bug.cgi?id=92575
13807
13808         Reviewed by Eric Seidel.
13809
13810         Added the ability to generate a results page that summarizes performance test results from
13811         multiple runs of run-perf-tests when --output-json-path is specified and --test-results-server
13812         is not specified. We cannot generate a results page when --test-results-server is specified
13813         because perf-o-matic cannot parse the new JSON format.
13814
13815         The new JSON format is simply an array of the old JSON output. This JSON is then merged into
13816         results-template.html along with jQuery and copied as a HTML file of the same filename as
13817         the output JSON file with a .html extension.
13818
13819         We merge all scripts and the JSON output into the results page as opposed to including them
13820         with the src content attribute to make it standalone so that we may post it on Bugzilla or
13821         e-mail it to someone else without breaking it.
13822
13823         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
13824         (PerfTestsRunner.run):
13825         (PerfTestsRunner._generate_json): Merge "contents" with the existing JSON file when generating
13826         a results page, and generate the results page from results-template.html merged with jQuery and
13827         the generated JSON output.
13828         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
13829         (_test_run_with_json_output): Extracted from test_run_with_upload_json to be shared with
13830         several test cases.
13831         (_test_run_with_json_output.mock_upload_json): Ditto.
13832         (test_run_with_json_output): Refactored to use _test_run_with_json_output.
13833         (test_run_generates_results_page): Added. Tests the new feature.
13834         (test_run_with_json_source): Refactored to use _test_run_with_json_output.
13835         (test_run_with_multiple_repositories): Ditto.
13836         (test_run_with_upload_json): Ditto.
13837
13838 2012-07-29  Rik Cabanier  <cabanier@adobe.com>
13839
13840         Add ENABLE_CSS_COMPOSITING flag
13841         https://bugs.webkit.org/show_bug.cgi?id=92553
13842
13843         Reviewed by Dirk Schulze.
13844
13845         Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
13846
13847         * Scripts/webkitperl/FeatureList.pm:
13848
13849 2012-07-29  Gustavo Noronha Silva  <gns@gnome.org>
13850
13851         Reviewed by Martin Robinson.
13852
13853         Make the jhbuild wrapper scripts become the jhbuild process
13854         instead of starting it as a child. This should make it possible to
13855         interrupt execution of jhbuild cleanly.
13856
13857         * gtk/run-with-jhbuild:
13858         * jhbuild/jhbuild-wrapper:
13859
13860 2012-07-29  Mike West  <mkwst@chromium.org>
13861
13862         Extend `application/x-webkit-test-netscape` plugins to better support multiple frames.
13863         https://bugs.webkit.org/show_bug.cgi?id=92478
13864
13865         Reviewed by Adam Barth.
13866
13867         DumpRenderTree currently understands
13868         `<object src="data:application/x-webkit-test-netscape,alertwhenloaded">`.
13869         It would be useful if it understood `logifloaded`, which could give
13870         more context regarding test expectations, and can be written in such
13871         as way as to support plugins loaded into multiple iframes in a single
13872         test.
13873
13874         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
13875         (NPP_New):
13876             Adding support for `logifloaded`.
13877
13878 2012-07-28  Peter Kasting  <pkasting@google.com>
13879
13880         Fix Chromium/Win compile.
13881         https://bugs.webkit.org/show_bug.cgi?id=88787
13882
13883         Unreviewed, build fix.
13884
13885         Chromium/Win needs _USE_MATH_DEFINES but doesn't define PLATFORM(WIN).
13886         The other files in WebKit that define this macro (both in
13887         WebCore/platform/graphics/cg) do it by unconditionally #defining it to 1
13888         above the #include of "config.h", so copy that pattern here.
13889
13890         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
13891
13892 2012-07-28  Mario Sanchez Prada  <msanchez@igalia.com>
13893
13894         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
13895         https://bugs.webkit.org/show_bug.cgi?id=90268
13896
13897         Reviewed by Martin Robinson.
13898
13899         Ignore WebKitTextChecker.* private files for gtk-doc.
13900
13901         * gtk/generate-gtkdoc:
13902         (get_webkit2_options):
13903
13904 2012-07-28  Philippe Normand  <pnormand@igalia.com>
13905
13906         [GTK] Transparent Media controls timeline and panel
13907         https://bugs.webkit.org/show_bug.cgi?id=85279
13908
13909         Reviewed by Martin Robinson.
13910
13911         * gtk/jhbuild.modules: Provide gnome-themes-standard build
13912         support, this is necessary so the media controls panel colors are
13913         properly initialized from the GTK+ theme.
13914
13915 2012-07-27  Kihong Kwon  <kihong.kwon@samsung.com>
13916
13917         [EFL] Support for HTML media capture
13918         https://bugs.webkit.org/show_bug.cgi?id=91842
13919
13920         Reviewed by Ryosuke Niwa.
13921
13922         Add HTML media capture feature to the feature list.
13923         In addition, enable that on the Efl port.
13924
13925         * Scripts/webkitperl/FeatureList.pm:
13926
13927 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
13928
13929         "webkit-patch rebaseline <test>" fails with exit_code 1
13930         https://bugs.webkit.org/show_bug.cgi?id=91560
13931
13932         Reviewed by Adam Barth.
13933
13934         webkit-patch rebaseline-json crashes in an svn checkout if it
13935         tries to add files and there are no files to add; arguably
13936         svn.add() should be robust against this, but rebaseline-json
13937         shouldn't be calling it, either. This patch fixes the latter and
13938         adds better debugging info to garden-o-matic so we can see what
13939         caused the crash.
13940
13941         * Scripts/webkitpy/tool/commands/rebaseline.py:
13942         (AbstractParallelRebaselineCommand._rebaseline):
13943         * Scripts/webkitpy/tool/servers/gardeningserver.py:
13944         (GardeningHTTPRequestHandler.rebaselineall):
13945         (GardeningHTTPRequestHandler.rebaselineall.error_handler):
13946         (GardeningHTTPRequestHandler):
13947
13948 2012-07-27  Brady Eidson  <beidson@apple.com>
13949
13950         Plugins should not be allowed to override standard properties/attributes in non-standard worlds
13951         <rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519
13952
13953         Reviewed by Anders Carlsson.
13954
13955         Add a test plugin which overrides all properties it is asked about:
13956         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.
13957         (PluginScriptableObjectOverridesAllProperties):
13958         (PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
13959         (PluginObject):
13960         (PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
13961         (PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
13962         (PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
13963         (PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
13964         (PluginScriptableObjectOverridesAllProperties::NPP_GetValue):
13965
13966         Expose NPN_MemAlloc to the test plugin:
13967         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
13968         (PluginTest::NPN_MemAlloc):
13969         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
13970         (PluginTest):
13971
13972         * DumpRenderTree/DumpRenderTree.gypi:
13973         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
13974         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
13975         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
13976
13977 2012-07-27  Rafael Brandao  <rafael.lobo@openbossa.org>
13978
13979         "webkit-patch upload" should strip colors from patch if necessary
13980         https://bugs.webkit.org/show_bug.cgi?id=92306
13981
13982         Reviewed by Adam Barth.
13983
13984         * Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.
13985
13986 2012-07-27  Eric Seidel  <eric@webkit.org>
13987
13988         clean-pending-commit throws exception when encountering Ossy
13989         https://bugs.webkit.org/show_bug.cgi?id=92534
13990
13991         Reviewed by Adam Barth.
13992
13993         Mark a couple strings as unicode so that reviewers with unicode names do not cause
13994         clean-pending-commit to barf.
13995
13996         * Scripts/webkitpy/tool/commands/upload.py:
13997         (CleanPendingCommit._flags_to_clear_on_patch):
13998         (CleanPendingCommit.execute):
13999         (AssignToCommitter._assign_bug_to_last_patch_attacher):
14000
14001 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
14002
14003         chromium win compile broken after removing webkit.py
14004         https://bugs.webkit.org/show_bug.cgi?id=92549
14005
14006         Unreviewed, build fix.
14007
14008         It turns out that this file is listed in the chromium downstream
14009         'browser_tests.isolate' file, and so deleting it broke gyp.
14010         Adding a stub file back in until we can remove the entry from
14011         the file.
14012
14013         * Scripts/webkitpy/layout_tests/port/webkit.py: Added.
14014
14015 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
14016
14017         nrwt: remove 'webkit.py' and the 'WebKitPort'
14018         https://bugs.webkit.org/show_bug.cgi?id=92450
14019
14020         Reviewed by Ryosuke Niwa.
14021
14022         This patch finishes the work of merging WebKitPort into Port.
14023         Now Port is way too big :).
14024
14025         This is all cutting and pasting; no new functionality and
14026         no changes in the tests.
14027
14028         * Scripts/webkitpy/layout_tests/port/apple.py:
14029         (ApplePort):
14030         (ApplePort.__init__):
14031         * Scripts/webkitpy/layout_tests/port/base.py:
14032         (Port.skipped_layout_tests):
14033         (Port):
14034         (Port._port_flag_for_scripts):
14035         (Port._arguments_for_configuration):
14036         (Port._run_script):
14037         (Port._build_driver):
14038         (Port._build_driver_flags):
14039         (Port._tests_for_other_platforms):
14040         (Port._runtime_feature_list):
14041         (Port.nm_command):
14042         (Port._modules_to_search_for_symbols):
14043         (Port._symbols_string):
14044         (Port._missing_feature_to_skipped_tests):
14045         (Port._missing_symbol_to_skipped_tests):
14046         (Port._has_test_in_directories):
14047         (Port._skipped_tests_for_unsupported_features):
14048         (Port._wk2_port_name):
14049         (Port._skipped_file_search_paths):
14050         * Scripts/webkitpy/layout_tests/port/chromium.py:
14051         (ChromiumPort):
14052         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
14053         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
14054         (ChromiumPortTestCase.test_check_build):
14055         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
14056         * Scripts/webkitpy/layout_tests/port/efl.py:
14057         (EflPort):
14058         (EflPort.__init__):
14059         * Scripts/webkitpy/layout_tests/port/gtk.py:
14060         (GtkPort):
14061         (GtkPort.setup_environ_for_server):
14062         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
14063         (TestWebKitPort):
14064         (TestWebKitPort.__init__):
14065         (TestWebKitPort.all_test_configurations):
14066         (TestWebKitPort._symbols_string):
14067         (TestWebKitPort._tests_for_other_platforms):
14068         (TestWebKitPort._tests_for_disabled_features):
14069         (PortTestCase):
14070         (PortTestCase.test_diff_image):
14071         (PortTestCase.test_path_to_test_expectations_file):
14072         (PortTestCase.test_skipped_directories_for_symbols):
14073         (test_skipped_directories_for_features):
14074         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
14075         (test_skipped_tests_for_unsupported_features_empty_test_list):
14076         (test_skipped_layout_tests):
14077         (test_skipped_file_search_paths):
14078         (test_root_option):
14079         (test_test_expectations):
14080         (test_build_driver):
14081         (_assert_config_file_for_platform):
14082         (test_linux_distro_detection):
14083         (test_apache_config_file_name_for_platform):
14084         (test_path_to_apache_config_file):
14085         * Scripts/webkitpy/layout_tests/port/qt.py:
14086         (QtPort):
14087         (QtPort.__init__):
14088         (QtPort.setup_environ_for_server):
14089         * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
14090         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
14091         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
14092         (get_test_baselines.AllPlatformsPort):
14093         (get_test_baselines.AllPlatformsPort.__init__):
14094         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
14095         (get_test_config.TestMacPort):
14096
14097 2012-07-27  Christophe Dumez  <christophe.dumez@intel.com>
14098
14099         [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
14100         https://bugs.webkit.org/show_bug.cgi?id=92228
14101
14102         Reviewed by Anders Carlsson.
14103
14104         Implement LayoutTestController.deliverWebIntent() to
14105         allow test cases to deliver a Web intent and test this
14106         functionality.
14107
14108         This functionality is needed by:
14109         - webintents/web-intents-delivery.html
14110
14111         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
14112         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
14113         (WTR::LayoutTestController::deliverWebIntent):
14114         (WTR):
14115         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
14116         (LayoutTestController):
14117
14118 2012-07-27  Jer Noble  <jer.noble@apple.com>
14119
14120         Unreviewed build fix.
14121
14122         Wrap MSVC-specific fixes is a COMPILER() check, not a PLATFORM() check.
14123
14124         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
14125
14126 2012-07-27  Xianzhu Wang  <wangxianzhu@chromium.org>
14127
14128         [Chromium-Android] NRWT better handling of DRT deadlocks and crashes
14129         https://bugs.webkit.org/show_bug.cgi?id=92299
14130
14131         Reviewed by Dirk Pranke.
14132
14133         1. Changed the deadlock detector thread target from a method of driver to a function to avoid its reference to the
14134            current driver (see the bug for the problem of the reference.
14135         2. Let the deadlock detector thread exit early when the normal_startup_event is set to avoid it from blocking the main thread when the main thread is exiting.
14136         3. Extracted common loop until timeout logic into ChromiumAndroidDriver._loop_with_timeout().
14137         4. Use the "for i in range(n)" style suggested by dpranke in https://bugs.webkit.org/show_bug.cgi?id=89124 in several functions.
14138
14139         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
14140         (ChromiumAndroidPort.__init__):
14141         (ChromiumAndroidPort._run_adb_command): Reduced the verbose output.
14142         (ChromiumAndroidDriver.__init__):
14143         (ChromiumAndroidDriver._loop_with_timeout): Extracted common loop until timeout logic here.
14144         (ChromiumAndroidDriver._all_pipes_created):
14145         (ChromiumAndroidDriver._remove_all_pipes):
14146         (ChromiumAndroidDriver._start): Changed the retry loop style.
14147         (ChromiumAndroidDriver._start_once): Changed the loop style and code related to deadlock detector.
14148         (ChromiumAndroidDriver._start_once.deadlock_detector): Moved the original ChromiumAndroidDriver._deadlock_detector() here.
14149         (ChromiumAndroidDriver.stop): Changed the loop style.
14150
14151 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
14152
14153         nrwt: move collect_tests(), parse_expectations() into manager
14154         https://bugs.webkit.org/show_bug.cgi?id=92423
14155
14156         Reviewed by Ojan Vafai.
14157
14158         This is the first in a series of patches refactoring
14159         run_webkit_tests.py and manager.py to make them more
14160         maintainable; all this patch does is move a couple of functions
14161         into manager.run_tests() so manager's public interface is
14162         simple.
14163
14164         * Scripts/webkitpy/layout_tests/controllers/manager.py:
14165         (Manager._collect_tests):
14166         (Manager._parse_expectations):
14167         (Manager._split_into_chunks_if_necessary):
14168         (Manager.run):
14169         (read_test_files):
14170         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
14171         (ManagerTest.test_http_locking):
14172         (ManagerTest.test_perf_locking):
14173         (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
14174         (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
14175         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14176         (run):
14177
14178 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
14179
14180         nrwt: print filtered stderr after a crash correctly
14181         https://bugs.webkit.org/show_bug.cgi?id=92428
14182
14183         Reviewed by Adam Barth.
14184
14185         Some ports will run the stderr output from DRT/WTR through a
14186         filter after a crash in order to print a more useful stack
14187         trace; while that gets written to the crash log correctly, we
14188         don't log it to the debug output properly. This change fixes
14189         that and makes it clearer that we're logging stderr, not the
14190         crash log.
14191
14192         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
14193         (SingleTestRunner._handle_error):
14194         * Scripts/webkitpy/layout_tests/port/base.py:
14195         (Port._get_crash_log):
14196         * Scripts/webkitpy/layout_tests/port/chromium.py:
14197         (ChromiumPort._get_crash_log):
14198         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
14199         (ChromiumAndroidPortTest.test_get_crash_log):
14200         * Scripts/webkitpy/layout_tests/port/driver.py:
14201         (Driver.run_test):
14202         * Scripts/webkitpy/layout_tests/port/gtk.py:
14203         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
14204         * Scripts/webkitpy/layout_tests/port/mac.py:
14205         (MacPort._get_crash_log):
14206         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
14207         (PortTestCase.test_get_crash_log):
14208
14209 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
14210
14211         nrwt: move image diffing code to a separate module
14212         https://bugs.webkit.org/show_bug.cgi?id=92447
14213
14214         Reviewed by Ryosuke Niwa.
14215
14216         This patch moves the code to talk to ImageDiff into its own
14217         module, and adds more tests for it. In addition, the patch
14218         modifies diff_image() so that we don't automatically stop
14219         ImageDiff after a single invocation, and thus subsequent
14220         diffs may be slightly faster. (Note that the chromium ports
14221         don't use any of this code; that is not changed by this patch).
14222
14223         The main motivation for this change is to move more "generic"
14224         code out of the port/* classes, and in particular to move more
14225         code out of webkit.py so that we can eventually eliminate it by
14226         merging it into base.py.
14227
14228         This patch also splits MockServerProcess out from driver_unittest.py
14229         so that it can be re-used.
14230
14231         * Scripts/webkitpy/layout_tests/port/base.py:
14232         (Port.__init__):
14233         (Port.diff_image):
14234         (Port.clean_up_test_run):
14235         * Scripts/webkitpy/layout_tests/port/driver.py:
14236         (Driver.__init__):
14237         (Driver._start):
14238         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
14239         (DriverTest.test_stop_cleans_up_properly):
14240         (DriverTest.test_two_starts_cleans_up_properly):
14241         (DriverTest.test_start_actually_starts):
14242         * Scripts/webkitpy/layout_tests/port/efl.py:
14243         (EflPort.clean_up_test_run):
14244         * Scripts/webkitpy/layout_tests/port/gtk.py:
14245         (GtkPort.clean_up_test_run):
14246         * Scripts/webkitpy/layout_tests/port/image_diff.py: Added.
14247         (ImageDiffer):
14248         (ImageDiffer.__init__):
14249         (ImageDiffer.diff_image):
14250         (ImageDiffer._start):
14251         (ImageDiffer._read):
14252         (ImageDiffer.stop):
14253         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.
14254         (for):
14255         (FakePort):
14256         (FakePort.__init__):
14257         (FakePort._path_to_image_diff):
14258         (FakePort.setup_environ_for_server):
14259         (TestImageDiffer):
14260         (TestImageDiffer.test_diff_image):
14261         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
14262         (MockDRTPortTest.test_diff_image):
14263         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
14264         (PortTestCase.test_diff_image__missing_both):
14265         (PortTestCase.test_diff_image):
14266         (PortTestCase.test_diff_image.make_proc):
14267         * Scripts/webkitpy/layout_tests/port/server_process.py:
14268         (ServerProcess._start):
14269         * Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.
14270         (MockServerProcess):
14271         (MockServerProcess.__init__):
14272         (MockServerProcess.write):
14273         (MockServerProcess.has_crashed):
14274         (MockServerProcess.read_stdout_line):
14275         (MockServerProcess.read_stdout):
14276         (MockServerProcess.pop_all_buffered_stderr):
14277         (MockServerProcess.read_either_stdout_or_stderr_line):
14278         (MockServerProcess.start):
14279         (MockServerProcess.stop):
14280         (MockServerProcess.kill):
14281         * Scripts/webkitpy/layout_tests/port/webkit.py:
14282         (WebKitPort._build_driver_flags):
14283         (WebKitPort._symbols_string):
14284
14285 2012-07-27  Tom Hudson  <hudson@google.com>
14286
14287         Activate committer bit granted April 6th so I can garden.
14288         https://bugs.webkit.org/show_bug.cgi?id=92500
14289
14290         Reviewed by Jochen Eisinger.
14291
14292         * Scripts/webkitpy/common/config/committers.py:
14293
14294 2012-07-27  Jer Noble  <jer.noble@apple.com>
14295
14296         Support a rational time class for use by media elements.
14297         https://bugs.webkit.org/show_bug.cgi?id=88787
14298
14299         Add unit tests for the WTF::MediaTime class.
14300
14301         Reviewed by Eric Carlson.
14302
14303         * TestWebKitAPI/GNUmakefile.am:
14304         * TestWebKitAPI/TestWebKitAPI.gypi:
14305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
14306         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Added.
14307         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
14308         (WTF::operator<<):
14309         (TestWebKitAPI):
14310         (TestWebKitAPI::TEST):
14311
14312 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
14313
14314         [NRWT] should have a way to restrict pixel tests for individual directories
14315         https://bugs.webkit.org/show_bug.cgi?id=91754
14316
14317         Unreviewed attempt to fix the chaos I introduced.
14318
14319         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
14320         (WebCore::DumpRenderTree::processLine):
14321
14322 2012-07-27  YoungTaeck Song  <youngtaeck.song@samsung.com>
14323
14324         [WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
14325         https://bugs.webkit.org/show_bug.cgi?id=91581
14326
14327         Reviewed by Noam Rosenthal.
14328
14329         Add a MiniBrowser's option for selecting evas engine.
14330
14331         * MiniBrowser/efl/main.c:
14332         (browserCreate):
14333         (main):
14334
14335 2012-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
14336
14337         Unreviewed, rolling out r123869.
14338         http://trac.webkit.org/changeset/123869
14339         https://bugs.webkit.org/show_bug.cgi?id=92501
14340
14341         "it did not fix anything but made things even worst"
14342         (Requested by kbalazs on #webkit).
14343
14344         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
14345         (WebCore::DumpRenderTree::DumpRenderTree):
14346         (WebCore::DumpRenderTree::open):
14347         (WebCore::DumpRenderTree::processLine):
14348         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
14349         (WebCore::DumpRenderTree::dump):
14350         * DumpRenderTree/qt/DumpRenderTreeQt.h:
14351         (DumpRenderTree):
14352         * DumpRenderTree/qt/main.cpp:
14353         (main):
14354         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
14355         (SingleTestRunner._should_fetch_expected_checksum):
14356         (SingleTestRunner._overwrite_baselines):
14357         (SingleTestRunner._compare_output):
14358         * Scripts/webkitpy/layout_tests/controllers/worker.py:
14359         (Worker._update_test_input):
14360         * Scripts/webkitpy/layout_tests/port/base.py:
14361         (Port.supports_switching_pixel_tests_per_test):
14362         (Port):
14363         (Port._supports_switching_pixel_tests_per_test):
14364         (Port.should_run_as_pixel_test):
14365         (Port._should_run_as_pixel_test):
14366         * Scripts/webkitpy/layout_tests/port/driver.py:
14367         (Driver.cmd_line):
14368         (Driver._command_from_driver_input):
14369         * Scripts/webkitpy/layout_tests/port/qt.py:
14370         (QtPort.check_sys_deps):
14371         (QtPort):
14372         (QtPort._supports_switching_pixel_tests_per_test):
14373         (QtPort._should_run_as_pixel_test):
14374         (QtPort._default_pixel_test_directories):
14375         * Scripts/webkitpy/layout_tests/port/test.py:
14376         (TestPort.supports_switching_pixel_tests_per_test):
14377         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14378         (_set_up_derived_options):
14379         (parse_args):
14380         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
14381         (MainTest.test_run_singly_actually_runs_tests):
14382         (MainTest.test_pixel_test_directories):
14383         * WebKitTestRunner/TestController.cpp:
14384         (WTR::TestController::TestController):
14385         (WTR::TestController::initialize):
14386         (WTR::TestController::runTest):
14387         * WebKitTestRunner/TestController.h:
14388         (TestController):
14389
14390 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
14391
14392         [NRWT] should have a way to restrict pixel tests for individual directories
14393         https://bugs.webkit.org/show_bug.cgi?id=91754
14394
14395         Reviewed by Zoltan Herczeg.
14396
14397         Rollout r123729 because it made Qt debug bots crasy.
14398
14399         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
14400         (WebCore::DumpRenderTree::DumpRenderTree):
14401         (WebCore::DumpRenderTree::open):
14402         (WebCore::DumpRenderTree::processLine):
14403         (WebCore::DumpRenderTree::setDumpPixels):
14404         (WebCore::DumpRenderTree::dump):
14405         * DumpRenderTree/qt/DumpRenderTreeQt.h:
14406         (DumpRenderTree):
14407         * DumpRenderTree/qt/main.cpp:
14408         (main):
14409         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
14410         (SingleTestRunner._should_fetch_expected_checksum):
14411         (SingleTestRunner._overwrite_baselines):
14412         (SingleTestRunner._compare_output):
14413         * Scripts/webkitpy/layout_tests/controllers/worker.py:
14414         (Worker._update_test_input):
14415         * Scripts/webkitpy/layout_tests/port/base.py:
14416         (Port.lookup_virtual_test_args):
14417         * Scripts/webkitpy/layout_tests/port/driver.py:
14418         (Driver.cmd_line):
14419         (Driver._command_from_driver_input):
14420         * Scripts/webkitpy/layout_tests/port/qt.py:
14421         (QtPort.check_sys_deps):
14422         * Scripts/webkitpy/layout_tests/port/test.py:
14423         (TestPort.virtual_test_suites):
14424         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14425         (_set_up_derived_options):
14426         (parse_args):
14427         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
14428         (MainTest.test_run_singly_actually_runs_tests):
14429         (MainTest.test_missing_and_unexpected_results):
14430         * WebKitTestRunner/TestController.cpp:
14431         (WTR::TestController::TestController):
14432         (WTR::TestController::initialize):
14433         (WTR::TestController::runTest):
14434         * WebKitTestRunner/TestController.h:
14435         (TestController):
14436
14437 2012-07-27  Adam Barth  <abarth@webkit.org>
14438
14439         webkit.review.bot should run clean-review-queue and clean-pending-commit periodically
14440         https://bugs.webkit.org/show_bug.cgi?id=92472
14441
14442         Reviewed by Eric Seidel.
14443
14444         We need to run these command periodically to keep cruft from
14445         accumulating in bugs.webkit.org. Rather than running them manually, we
14446         should just have a bot run them. This patch has the style-queue run the
14447         commands, which admittedly is a bit odd but it doesn't seem worthwhile
14448         to create another bot specifically for this purposes.
14449
14450         * Scripts/webkitpy/tool/commands/queues.py:
14451         (AbstractReviewQueue):
14452         (StyleQueue.begin_work_queue):
14453         (StyleQueue):
14454         (StyleQueue.clean_bugzilla):
14455         * Scripts/webkitpy/tool/commands/queues_unittest.py:
14456         (StyleQueueTest.test_style_queue_with_style_exception):
14457         (test_style_queue_with_watch_list_exception):
14458
14459 2012-07-27  Dominik Röttsches  <dominik.rottsches@intel.com>
14460
14461         [Cairo] Add complex font drawing using HarfbuzzNG
14462         https://bugs.webkit.org/show_bug.cgi?id=91864
14463
14464         Reviewed by Simon Hausmann and Martin Robinson.
14465
14466         Bringing Harfbuzz support to EFL with this patch, so we need HarfBuzz in the pulled in jhbuild dependencies.
14467
14468         * WebKitTestRunner/CMakeLists.txt: Adding additional header include directories.
14469         * efl/jhbuild.modules: Adding source for HarfBuzz release version 0.9.0.
14470
14471 2012-07-27  KwangYong Choi  <ky0.choi@samsung.com>
14472
14473         [WK2][EFL][WTR] TestNetscapePlugin is required.
14474         https://bugs.webkit.org/show_bug.cgi?id=88756
14475
14476         Reviewed by Simon Hausmann.
14477
14478         libTestNetscapePlugin.so should be required for DRT/WTR/EFL.
14479
14480         * CMakeLists.txt:
14481         * DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
14482
14483 2012-07-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
14484
14485         [EFL] Memory leaks in EFL DRT
14486         https://bugs.webkit.org/show_bug.cgi?id=92347
14487
14488         Reviewed by Simon Hausmann.
14489
14490         Fix a memory leak in EFL's DRT code by adopting an allocation
14491         of JSString created with JSStringCreateWithUTF8CString.
14492
14493         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
14494         (DumpRenderTreeChrome::onWindowObjectCleared):
14495
14496 2012-07-27  Adam Barth  <abarth@webkit.org>
14497
14498         Simplify ExpectedFailures
14499         https://bugs.webkit.org/show_bug.cgi?id=92216
14500
14501         Reviewed by Eric Seidel.
14502
14503         This patch simplifies the ExpectedFailures class we use to remember
14504         which tests are currently failing on the bots. When we wrote this code
14505         originally, we weren't entirely sure how it would work. Now that we
14506         understand it more clearly, we can write the code more clearly.
14507
14508         * Scripts/webkitpy/tool/bot/expectedfailures.py:
14509         (_has_failures):
14510         (_is_trustworthy):
14511         (ExpectedFailures.__init__):
14512         (ExpectedFailures.failures_were_expected):
14513         (ExpectedFailures.unexpected_failures_observed):
14514         (ExpectedFailures.update):
14515         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
14516         (ExpectedFailuresTest._assert_can_trust):
14517         (ExpectedFailuresTest.test_failures_were_expected):
14518         (ExpectedFailuresTest.test_unexpected_failures_observed):
14519         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
14520         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
14521         (PatchAnalysisTask._test):
14522         (PatchAnalysisTask._build_and_test_without_patch):
14523         (PatchAnalysisTask._test_patch):
14524
14525 2012-07-27  Csaba Osztrogonác  <ossy@webkit.org>
14526
14527         [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
14528         https://bugs.webkit.org/show_bug.cgi?id=88064
14529
14530         Reviewed by Zoltan Herczeg.
14531
14532         Use resetInternalsObject() instead of injectInternalsObject().
14533
14534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
14535         (WTR::InjectedBundlePage::resetAfterTest):
14536
14537 2012-07-26  Ryuan Choi  <ryuan.choi@samsung.com>
14538
14539         [EFL] Remove forwarding headers from MiniBrowser/Efl.
14540         https://bugs.webkit.org/show_bug.cgi?id=91627
14541
14542         Reviewed by Kentaro Hara.
14543
14544         * MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.
14545
14546 2012-07-26  Yoshifumi Inoue  <yosin@chromium.org>
14547
14548         [Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
14549         https://bugs.webkit.org/show_bug.cgi?id=92339
14550
14551         Reviewed by Kent Tamura.
14552
14553         This patch enables runtime features for input type datetime, datetime-local,
14554         month, time and week for Chromium DRT.
14555
14556         * DumpRenderTree/chromium/TestShell.cpp:
14557         (TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.
14558
14559 2012-07-26  Jeffrey Pfau  <jpfau@apple.com>
14560
14561         Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
14562         https://bugs.webkit.org/show_bug.cgi?id=84041
14563
14564         Reviewed by Brady Eidson.
14565
14566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
14567         * TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
14568         (-[BackForwardListTest webView:didFinishLoadForFrame:]):
14569         (-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
14570         (TestWebKitAPI):
14571         (TestWebKitAPI::TEST):
14572
14573 2012-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
14574
14575         Unreviewed, rolling out r123799.
14576         http://trac.webkit.org/changeset/123799
14577         https://bugs.webkit.org/show_bug.cgi?id=92431
14578
14579         broke the Apple Mac build (Requested by bweinstein on
14580         #webkit).
14581
14582         * DumpRenderTree/chromium/TestWebPlugin.cpp:
14583         * DumpRenderTree/chromium/TestWebPlugin.h:
14584         (TestWebPlugin::acceptsInputEvents):
14585         (TestWebPlugin::handleInputEvent):
14586
14587 2012-07-26  Dirk Pranke  <dpranke@chromium.org>
14588
14589         nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
14590         https://bugs.webkit.org/show_bug.cgi?id=92172
14591
14592         Reviewed by Tony Chang.
14593
14594         Right now new-run-webkit-tests --verbose prints out too much
14595         information (it's like --verbose + debugging). I plan to fix
14596         this in bug 88702, and also clean up and simplify all of the
14597         --print options, but in preparation for these changes I need to
14598         pass --verbose twice to get the same level of output
14599         temporarily (for compatibility).
14600
14601         * Scripts/run-webkit-tests:
14602
14603 2012-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
14604
14605         Propagate gesture events to plugins.
14606         https://bugs.webkit.org/show_bug.cgi?id=92281
14607
14608         Reviewed by Adam Barth.
14609
14610         Update TestWebPlugin to receive events, and output logs for the events.
14611
14612         * DumpRenderTree/chromium/TestWebPlugin.cpp:
14613         (TestWebPlugin::handleInputEvent):
14614         * DumpRenderTree/chromium/TestWebPlugin.h:
14615         (TestWebPlugin::acceptsInputEvents):
14616         (TestWebPlugin):
14617
14618 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
14619
14620         [nrwt] get rid of --skip-pixel-test-if-no-baseline
14621         https://bugs.webkit.org/show_bug.cgi?id=92377
14622
14623         Reviewed by Adam Barth.
14624
14625         Remove the option and all code paths that handled it.
14626
14627         * Scripts/webkitpy/layout_tests/port/base.py:
14628         (Port.should_run_as_pixel_test):
14629         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14630         (_set_up_derived_options):
14631         (parse_args):
14632         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
14633         (MainTest.test_repeat_each):
14634
14635 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
14636
14637         Add FastMalloc statistics in window.internals
14638         https://bugs.webkit.org/show_bug.cgi?id=91274
14639
14640         Reviewed by Ryosuke Niwa.
14641
14642         * GNUmakefile.am:
14643
14644 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
14645
14646         Add FastMalloc statistics in window.internals
14647         https://bugs.webkit.org/show_bug.cgi?id=91274
14648
14649         Reviewed by Ryosuke Niwa.
14650
14651         * GNUmakefile.am:
14652
14653 2012-07-20  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
14654
14655         buildbot: Remove the configuration of hfreyther*
14656         https://bugs.webkit.org/show_bug.cgi?id=91849
14657
14658         Reviewed by Adam Roben.
14659
14660         The machine running these configs was decommissioned and
14661         there is no replacement at this point. Remove them from the
14662         configuration.
14663
14664         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from
14665         the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
14666         them too.
14667
14668 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
14669
14670         Unreviewed speculative Mac buildfix after r123729 - 2nd attempt.
14671
14672         * WebKitTestRunner/TestController.cpp:
14673         (WTR::TestController::runTest):
14674
14675 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
14676
14677         Unreviewed speculative buildfix after r123729.
14678
14679         * WebKitTestRunner/TestController.cpp:
14680         (WTR::TestController::runTest): Fix sign errors.
14681
14682 2012-07-26  Zoltan Nyul  <zoltan.nyul@intel.com>
14683
14684         [EFL] EFL port should use XDG paths
14685         https://bugs.webkit.org/show_bug.cgi?id=91719
14686
14687         Reviewed by Kenneth Rohde Christiansen.
14688
14689         The appcache/localstorage/webdatabase path should be set in the
14690         ewk_main.cpp instead of the DumpRenderTree, and the XDG_DATA_HOME and
14691         XDG_CACHE_HOME should be set to different directory for each processes
14692         for the layout-tests.
14693
14694         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
14695         (DumpRenderTreeChrome::initialize):
14696         * Scripts/webkitpy/layout_tests/port/efl.py:
14697         (EflPort.setup_environ_for_server):
14698         * efl/jhbuild.modules:
14699
14700 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
14701
14702         [NRWT] should have a way to restrict pixel tests for individual directories
14703         https://bugs.webkit.org/show_bug.cgi?id=91754
14704
14705         Reviewed by Dirk Pranke.
14706
14707         Added --pixel-test-directories option to nrwt. It implies --pixel-tests.
14708         If the platform supports this option only tests from these directories will
14709         be executed as pixel tests. Furthermore, platforms can have a default set of
14710         pixel test directories. To support the feature the test harness have to be
14711         able to inform the driver whether to dump pixels for each tests. For this
14712         purpose I changed WTR and the Qt DRT to handle a --pixel-test argument from
14713         the standard output and made NRWT use this argument with these drivers.
14714
14715         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
14716         (WebCore::DumpRenderTree::DumpRenderTree):
14717         (WebCore::DumpRenderTree::open):
14718         (WebCore::DumpRenderTree::processLine):
14719         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
14720         (WebCore::DumpRenderTree::dump):
14721         * DumpRenderTree/qt/DumpRenderTreeQt.h:
14722         (DumpRenderTree):
14723         * DumpRenderTree/qt/main.cpp:
14724         (main):
14725         Handle the --pixel-test argument.
14726
14727         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
14728         (SingleTestRunner._should_fetch_expected_checksum):
14729         (SingleTestRunner._overwrite_baselines):
14730         (SingleTestRunner._compare_output):
14731         * Scripts/webkitpy/layout_tests/controllers/worker.py:
14732         (Worker._update_test_input):
14733         * Scripts/webkitpy/layout_tests/port/base.py:
14734         (Port.supports_switching_pixel_tests_per_test): Ports can override this to inform
14735         the harness that --pixel-test argument is supported. True for WTR, otherwise calls
14736         private version that can be overridden by the actual platform. Only true with WTR
14737         and Qt DRT currently. This supposed to exist only temporary until there are ports
14738         that doesn't support the feature in their DRT's.
14739         (Port):
14740         (Port._supports_switching_pixel_tests_per_test):
14741         (Port.should_run_as_pixel_test):
14742         (Port._should_run_as_pixel_test): Ports can override this to define their
14743         default set of pixel tests directories.
14744         * Scripts/webkitpy/layout_tests/port/driver.py:
14745         (Driver.cmd_line): Don't pass --pixel-tests if the platform supports per test
14746         --pixel-test.
14747         (Driver._command_from_driver_input): Pass --pixel-test if it is supported and pixel
14748         tests are enabled.
14749         * Scripts/webkitpy/layout_tests/port/qt.py:
14750         (QtPort.check_sys_deps):
14751         (QtPort):
14752         (QtPort._supports_switching_pixel_tests_per_test):
14753         (QtPort._should_run_as_pixel_test):
14754         (QtPort._default_pixel_test_directories): Only compositing will be our default pixel
14755         test directory for the time being.
14756         * Scripts/webkitpy/layout_tests/port/test.py:
14757         (TestPort.supports_switching_pixel_tests_per_test):
14758         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14759         (_set_up_derived_options):
14760         (parse_args):
14761         Handle the --pixel-test-directory option. It expect a directory below LayoutTests
14762         and can be specified multiple times. Added fixme's that we should improve how we
14763         handle these arguments.
14764
14765         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
14766         (MainTest.test_run_singly_actually_runs_tests):
14767         (MainTest.test_pixel_test_directories):
14768         Added an integration test for the feature.
14769
14770         * WebKitTestRunner/TestController.cpp:
14771         (WTR::TestController::TestController):
14772         (WTR::TestController::initialize):
14773         (WTR::TestController::runTest):
14774         * WebKitTestRunner/TestController.h:
14775         (TestController):
14776         Handle the --pixel-test argument.
14777
14778 2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
14779
14780         [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
14781         https://bugs.webkit.org/show_bug.cgi?id=92349
14782
14783         Reviewed by Kentaro Hara.
14784
14785         Fix crash occurring after r123604, which replaced strdup()
14786         usage with eina_stringshare_add(). Unfortunately, the DRT
14787         was not updated accordingly to use eina_stringshare_del()
14788         instead of free() on the values returned by Ewk_Intent
14789         getters and it was causing
14790         webintents/web-intents-obj-constructor.html to crash.
14791
14792         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
14793         (DumpRenderTreeChrome::onFrameIntentNew):
14794
14795 2012-07-26  Adam Barth  <abarth@webkit.org>
14796
14797         Unreviewed attempt to fix the chromium-win build.
14798
14799         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp:
14800
14801 2012-07-26  Kaustubh Atrawalkar  <kaustubh@motorola.com>
14802
14803         [DRT] LTC:: pageNumberForElementById() could be moved to Internals
14804         https://bugs.webkit.org/show_bug.cgi?id=92091
14805
14806         Reviewed by Adam Barth.
14807
14808         Move the pageNumberForElementById from LayoutTestCotroller to Internals and
14809         remove the old platform specific implementations as it exclusively tests WebCore functionality.
14810
14811         * DumpRenderTree/LayoutTestController.cpp:
14812         (LayoutTestController::staticFunctions):
14813         * DumpRenderTree/LayoutTestController.h:
14814         (LayoutTestController):
14815         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
14816         * DumpRenderTree/chromium/LayoutTestController.cpp:
14817         (LayoutTestController::LayoutTestController):
14818         (LayoutTestController::setPrinting):
14819         * DumpRenderTree/chromium/LayoutTestController.h:
14820         (LayoutTestController):
14821         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
14822         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
14823         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
14824         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
14825         * DumpRenderTree/qt/LayoutTestControllerQt.h:
14826         (LayoutTestController):
14827         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
14828         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
14829         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
14830         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
14831         (WTR):
14832         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
14833         (LayoutTestController):
14834
14835 2012-07-25  Adam Barth  <abarth@webkit.org>
14836
14837         TestRunner.a should contain a TestRunner object
14838         https://bugs.webkit.org/show_bug.cgi?id=92313
14839
14840         Reviewed by Kent Tamura.
14841
14842         This patch adds a stub implementation of TestRunner, which is the new
14843         home for our implementation of window.testRunner. A future patch will
14844         migrate functions from LayoutTestController to TestRunner.
14845
14846         * DumpRenderTree/DumpRenderTree.gypi:
14847         * DumpRenderTree/chromium/LayoutTestController.h:
14848         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
14849         * DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.
14850
14851 2012-07-25  Wei James  <james.wei@intel.com>
14852
14853         [Chromium] Fix infinite loop issue for chromium android layout test
14854         https://bugs.webkit.org/show_bug.cgi?id=92197
14855
14856         Reviewed by Adam Barth.
14857
14858         The change brought in by r123530 will cause infinite loop when running
14859         Chromium Android Layout Test.
14860         Revert the change for this line only.
14861
14862         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
14863         (ChromiumAndroidPort._build_path):
14864
14865 2012-07-25  Adam Barth  <abarth@webkit.org>
14866
14867         Jochen is our a newest reviewer!
14868
14869         * Scripts/webkitpy/common/config/committers.py:
14870
14871 2012-07-25  Jochen Eisinger  <jochen@chromium.org>
14872
14873         [chromium] don't use webkit_support methods directly from test runners but through the test delegate
14874         https://bugs.webkit.org/show_bug.cgi?id=92256
14875
14876         Reviewed by Adam Barth.
14877
14878         This will allow for the content_shell to provide its own implementation
14879         for setting the Gamepad data instead.
14880
14881         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp:
14882         (GamepadController::setDelegate):
14883         (GamepadController::reset):
14884         (GamepadController::connect):
14885         (GamepadController::disconnect):
14886         (GamepadController::setId):
14887         (GamepadController::setButtonCount):
14888         (GamepadController::setButtonData):
14889         (GamepadController::setAxisCount):
14890         (GamepadController::setAxisData):
14891         * DumpRenderTree/chromium/TestRunner/GamepadController.h:
14892         (GamepadController):
14893         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
14894         (WebKit):
14895         (TestDelegate):
14896         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
14897         (TestInterfaces::Internal):
14898         (TestInterfaces::Internal::~Internal):
14899         (TestInterfaces::Internal::setDelegate):
14900         (TestInterfaces::setDelegate):
14901         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
14902         (TestInterfaces):
14903         * DumpRenderTree/chromium/TestShell.cpp:
14904         (TestShell::createMainWindow):
14905         (TestShell::~TestShell):
14906         * DumpRenderTree/chromium/WebViewHost.cpp:
14907         (WebViewHost::setGamepadData):
14908         * DumpRenderTree/chromium/WebViewHost.h:
14909         (WebViewHost):
14910
14911 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
14912
14913         [WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented
14914         https://bugs.webkit.org/show_bug.cgi?id=92227
14915
14916         Reviewed by Kenneth Rohde Christiansen.
14917
14918         Implement LayoutTestController.sendWebIntentResponse() so
14919         that a test case can reply to a Web intent request and
14920         test this functionality.
14921
14922         In order to support this functionality, we need to keep
14923         a pointer to the current intent request in
14924         InjectedBundlePage::didReceiveIntentForFrame() so that
14925         we can reuse it later in
14926         LayoutTestController::sendWebIntentResponse().
14927
14928         The following tests need this functionality:
14929         - webintents/web-intents-failure.html
14930         - webintents/web-intents-reply.html
14931
14932         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
14933         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
14934         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
14935         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
14936         (InjectedBundlePage):
14937         (WTR::InjectedBundlePage::currentIntentRequest):
14938         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
14939         (WTR::LayoutTestController::sendWebIntentResponse):
14940         (WTR):
14941         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
14942         (LayoutTestController):
14943
14944 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
14945
14946         [EFL][WK2][WTR] Alt, Shift and Ctrl keys are not handled by EventSenderProxy.
14947         https://bugs.webkit.org/show_bug.cgi?id=92241
14948
14949         Reviewed by Kenneth Rohde Christiansen.
14950
14951         Alt, Shift and Ctrl keys were not handled by EventSenderProxy.
14952         It caused failure of fast/events/keydown-leftright-keys.html test.
14953
14954         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added handling of Alt, Shift and Ctrl keys.
14955         (WTR::keyName):
14956
14957 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
14958
14959         [EFL][WK2] Fix timeout issues when debugging WebProcess.
14960         https://bugs.webkit.org/show_bug.cgi?id=92245
14961
14962         Reviewed by Dirk Pranke.
14963
14964         Fix timeout issues when debugging the WebProcess
14965         under valgrind or gdb.
14966
14967         * Scripts/webkitpy/layout_tests/port/efl.py:
14968         (EflPort.default_timeout_ms):
14969         * WebKitTestRunner/efl/TestControllerEfl.cpp:
14970         (WTR::TestController::platformInitialize):
14971
14972 2012-07-25  Xianzhu Wang  <wangxianzhu@chromium.org>
14973
14974         [Chromium-Android] NRWT driver should not restart between reftests
14975         https://bugs.webkit.org/show_bug.cgi?id=92267
14976
14977         Reviewed by Dirk Pranke.
14978
14979         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
14980         (ChromiumAndroidDriver.start): Resets self._pixel_tests when the pixel_tests parameter changes.
14981
14982 2012-07-25  Tommy Widenflycht  <tommyw@google.com>
14983
14984         MediaStream API: Update MediaStreamTrack to match the specification
14985         https://bugs.webkit.org/show_bug.cgi?id=90180
14986
14987         Reviewed by Adam Barth.
14988
14989         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
14990
14991         * DumpRenderTree/DumpRenderTree.gypi:
14992         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
14993         (MockWebKitPlatformSupport::createMediaStreamCenter):
14994         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
14995         (WebKit):
14996         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
14997         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
14998         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
14999         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
15000         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
15001         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
15002         (WebKit::MockWebMediaStreamCenter::constructSDP):
15003         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
15004         (WebKit):
15005         (MockWebMediaStreamCenter):
15006         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
15007
15008 2012-07-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
15009
15010         [NRWT] Rename baseline_search_path() to default_baseline_search_path()
15011         https://bugs.webkit.org/show_bug.cgi?id=92122
15012
15013         Reviewed by Dirk Pranke.
15014
15015         * Scripts/webkitpy/layout_tests/port/base.py:
15016         (Port.baseline_version_dir):
15017         (Port.baseline_search_path):
15018         (Port):
15019         (Port.default_baseline_search_path):
15020         (Port.expected_baselines):
15021         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
15022         (PortTest.test_additional_platform_directory):
15023         * Scripts/webkitpy/layout_tests/port/mac.py:
15024         (MacPort.default_baseline_search_path):
15025         * Scripts/webkitpy/layout_tests/port/qt.py:
15026         (QtPort.default_baseline_search_path):
15027         * Scripts/webkitpy/layout_tests/port/win.py:
15028         (WinPort.default_baseline_search_path):
15029
15030 2012-07-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
15031
15032         [EFL] Use eina_stringshare_add instead of strdup.
15033         https://bugs.webkit.org/show_bug.cgi?id=92072
15034
15035         Reviewed by Kentaro Hara.
15036
15037         Eina of EFL libraries supports a string functionality that replaces strdup. So, EFL port needs
15038         to replace strdup with eina_stringshare_add function.
15039
15040         DumpRenderTree also needs to be modified according to ewk APIs's parameter change.
15041
15042         * DumpRenderTree/efl/DumpRenderTree.cpp:
15043         (dumpFramesAsText):
15044         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
15045         (DumpRenderTreeChrome::onFrameIntentNew):
15046         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
15047         (onJavaScriptPrompt):
15048
15049 2012-07-25  Alexander Shalamov  <alexander.shalamov@intel.com>
15050
15051         [WTR][EFL] Wheel events are not emitted
15052         https://bugs.webkit.org/show_bug.cgi?id=92094
15053
15054         Reviewed by Csaba Osztrogonác.
15055
15056         Wheel events are not emitted, therefore, layout tests that use mouseScrollBy method are failing.
15057
15058         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
15059         (WTR::dispatchMouseScrollByEvent):
15060         (WTR::EventSenderProxy::mouseScrollBy):
15061         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
15062         (WTR::PlatformWebView::PlatformWebView):
15063         (WTR::PlatformWebView::focus):
15064
15065 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
15066
15067         [EFL][WK2] Add ewk_main.{cpp,h} to EFL WK2
15068         https://bugs.webkit.org/show_bug.cgi?id=92101
15069
15070         Reviewed by Kenneth Rohde Christiansen.
15071
15072         Added a centralized place for general initialization in UI process for EFL WK2.
15073
15074         * MiniBrowser/efl/main.c: Added using of newly added ewk_init() and ewk_shutdown() functions.
15075         (main):
15076         * WebKitTestRunner/efl/main.cpp: Ditto.
15077         (main):
15078
15079 2012-07-24  Benjamin Poulain  <bpoulain@apple.com> && Joseph Pecoraro  <pecoraro@apple.com>
15080
15081         QualifiedName's HashSet should be big enough to hold at least all the static names
15082         https://bugs.webkit.org/show_bug.cgi?id=91891
15083
15084         Reviewed by Darin Adler.
15085
15086         Add a test for WTF::hashTableCapacityForSize.
15087
15088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
15089         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added.
15090         (InitialCapacityTestHashTraits):
15091         (TestWebKitAPI::testInitialCapacity):
15092         (TestWebKitAPI::generateTestCapacityUpToSize):
15093         (TestWebKitAPI::TEST):
15094
15095 2012-07-24  Adam Barth  <abarth@webkit.org>
15096
15097         The EWS bots get flaky when we hit the failure limit
15098         https://bugs.webkit.org/show_bug.cgi?id=92212
15099
15100         Reviewed by Eric Seidel.
15101
15102         Previously we were missing some failure types, which means we didn't
15103         notice that the bots were hitting the failure limit.
15104
15105         * Scripts/webkitpy/common/net/layouttestresults.py:
15106         (LayoutTestResults.failing_test_results):
15107         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
15108         (LayoutTestResultsTest.test_results_from_string):
15109         (LayoutTestResultsTest.test_tests_matching_failure_types):
15110
15111 2012-07-24  Raphael Kubo da Costa  <rakuco@webkit.org>
15112
15113         [EFL] Unreviewed build fix.
15114
15115         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h
15116         for usleep(3).
15117
15118 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
15119
15120         make test-webkitpy at least kinda work in parallel on win32
15121         https://bugs.webkit.org/show_bug.cgi?id=91700
15122
15123         Reviewed by Adam Barth.
15124
15125         This change makes the hoop-jumping we have to do to make running
15126         new-run-webkit-tests in parallel on win32 generic so that we can
15127         re-use it for test-webkitpy as well.
15128
15129         * Scripts/new-run-webkit-tests:
15130         * Scripts/test-webkitpy:
15131         * Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.
15132         (run):
15133         * Scripts/webkitpy/test/main.py:
15134         (main):
15135         (Tester._log_exception):
15136
15137 2012-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
15138
15139         Unreviewed, rolling out r123499.
15140         http://trac.webkit.org/changeset/123499
15141         https://bugs.webkit.org/show_bug.cgi?id=92161
15142
15143         Android fails to compile (Requested by zhenyao on #webkit).
15144
15145         * DumpRenderTree/DumpRenderTree.gypi:
15146         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
15147         (MockWebKitPlatformSupport::createMediaStreamCenter):
15148         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
15149         (MockWebKitPlatformSupport):
15150         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
15151         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.
15152
15153 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
15154
15155         nrwt: never finds binaries in the 'out' dir on chromium win
15156         https://bugs.webkit.org/show_bug.cgi?id=91890
15157
15158         Reviewed by Tony Chang.
15159
15160         Attempt to fix this bug yet again; it turns out that --root and
15161         --build-directory don't have the same meaning (--root should
15162         include the configuration, --build-directory should not).
15163
15164         * Scripts/webkitpy/layout_tests/port/base.py:
15165         (Port._build_path):
15166         * Scripts/webkitpy/layout_tests/port/chromium.py:
15167         (ChromiumPort._static_build_path):
15168         (ChromiumPort.default_results_directory):
15169         (ChromiumPort._build_path):
15170         (ChromiumPort):
15171         (ChromiumPort._build_path_with_configuration):
15172         (ChromiumPort._build_path_with_configuration.does):
15173         (ChromiumPort._path_to_image_diff):
15174         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
15175         (ChromiumAndroidPort._build_path):
15176         (ChromiumAndroidPort):
15177         (ChromiumAndroidPort._build_path_with_configuration):
15178         (ChromiumAndroidPort._path_to_driver):
15179         (ChromiumAndroidPort._path_to_forwarder):
15180         (ChromiumAndroidPort._push_executable):
15181         (ChromiumAndroidPort._push_fonts):
15182         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
15183         (ChromiumLinuxPort._determine_driver_path_statically):
15184         (ChromiumLinuxPort._modules_to_search_for_symbols):
15185         (ChromiumLinuxPort._path_to_driver):
15186         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
15187         (ChromiumLinuxPortTest.test_build_path):
15188         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
15189         (ChromiumMacPort._modules_to_search_for_symbols):
15190         (ChromiumMacPort._path_to_driver):
15191         (ChromiumMacPort._path_to_helper):
15192         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
15193         (ChromiumMacPortTest.test_build_path):
15194         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
15195         (ChromiumWinPort._path_to_driver):
15196         (ChromiumWinPort._path_to_helper):
15197         (ChromiumWinPort._path_to_image_diff):
15198         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
15199         (ChromiumWinTest.test_build_path):
15200         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15201         (parse_args):
15202
15203 2012-07-24  Peter Beverloo  <peter@chromium.org>
15204
15205         Android-chromium layout tests failing with GPU related crash
15206         https://bugs.webkit.org/show_bug.cgi?id=92126
15207
15208         Reviewed by Adam Barth.
15209
15210         Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
15211         as it's not being used by any port anymore, and neither is being passed
15212         on to the test runner. Instead, append the flag directly to DRT for the
15213         Chromium Android port, which does rely on this functionality.
15214
15215         The ChromiumAndroidUnitTest tests didn't catch this as the property was
15216         set to True, but it's unable to detect whether they'll actually be used.
15217         No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
15218         or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
15219
15220         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
15221         (ChromiumAndroidPort.__init__):
15222         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
15223         (ChromiumAndroidPortTest.test_attributes):
15224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15225         (parse_args):
15226
15227 2012-07-24  Alexander Shalamov  <alexander.shalamov@intel.com>
15228
15229         [WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
15230         https://bugs.webkit.org/show_bug.cgi?id=92107
15231
15232         Reviewed by Kenneth Rohde Christiansen.
15233
15234         Fixes mouse click events in EventSenderProxyEfl.
15235
15236         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
15237         (WTR::dispatchMouseDownEvent):
15238         (WTR::EventSenderProxy::dispatchEvent):
15239
15240 2012-07-24  Tommy Widenflycht  <tommyw@google.com>
15241
15242         MediaStream API: Update MediaStreamTrack to match the specification
15243         https://bugs.webkit.org/show_bug.cgi?id=90180
15244
15245         Reviewed by Adam Barth.
15246
15247         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
15248
15249         * DumpRenderTree/DumpRenderTree.gypi:
15250         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
15251         (MockWebKitPlatformSupport::createMediaStreamCenter):
15252         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
15253         (WebKit):
15254         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
15255         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
15256         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
15257         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
15258         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
15259         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
15260         (WebKit::MockWebMediaStreamCenter::constructSDP):
15261         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
15262         (WebKit):
15263         (MockWebMediaStreamCenter):
15264         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
15265
15266 2012-07-23  Ryosuke Niwa  <rniwa@webkit.org>
15267
15268         Fix regressions in replay performance tests
15269         https://bugs.webkit.org/show_bug.cgi?id=92052
15270
15271         Reviewed by Dirk Pranke.
15272
15273         Fix regression that accumulated over time to make replay tests work again.
15274
15275         * DumpRenderTree/chromium/WebViewHost.cpp:
15276         (WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
15277         URL hadn't been updated yet When requesting a new URL on the main frame.
15278         * Scripts/webkitpy/performance_tests/perftest.py:
15279         (ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
15280         (ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
15281         (ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.
15282         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
15283         (TestReplayPerfTest.test_run_single):
15284         (TestReplayPerfTest.test_prepare):
15285         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
15286         (TestReplayPerfTest):
15287
15288 2012-07-24  Simon Hausmann  <simon.hausmann@nokia.com>
15289
15290         [Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
15291         https://bugs.webkit.org/show_bug.cgi?id=91229
15292
15293         Reviewed by Jocelyn Turcotte.
15294
15295         In order to successfully link a DLL on Windows we need to have at least
15296         one object file (or compilation unit). The forward export header files were
15297         supposed to be that, but unfortunately the rule in win32/default_post.prf for
15298         creating the header files had some bugs, among others that it did an exists()
15299         check on the depending static library. At the time qmake is ran those libraries
15300         do not exist yet and therefore the corresponding extra compiler rules were never
15301         created, resulting in empty OBJECTS/SOURCES.
15302
15303         Even without such an exists() check, qmake extra compilers require the files
15304         referred to in the .input variable to exist at qmake time. In this case the input
15305         files were the static libraries, which do not exist yet.
15306
15307         This patch solves this by using a qmake extra target instead of extra
15308         compiler, which does not have this limitation. The target is referenced
15309         through the extension of GENERATED_SOURCES.
15310
15311         The patch also adds a d/_debug suffix for debug builds, do allow for separate
15312         symbol exports if necessary.
15313
15314         * Scripts/generate-win32-export-forwards: Support multiple input files, i.e.
15315         consider the last argument to be the output file and everything else input.
15316         * qmake/mkspecs/features/win32/default_post.prf:
15317
15318 2012-07-24  Balazs Kelemen  <kbalazs@webkit.org>
15319
15320         [Qt] Add quirks for running the web process in a profiler shell, like valgrind
15321         https://bugs.webkit.org/show_bug.cgi?id=87672
15322
15323         Reviewed by Jocelyn Turcotte.
15324
15325         Add --no-timeout-at-all command line switch to not time out no matter how
15326         long the web process does it's job. --no-timeout is not enough for profiling
15327         purposes because it only affects the timeout when we are waiting for the end
15328         of the test. We use another timeout to control how much we wait for the web
15329         process to initialize before and reset after the test and it could also easily
15330         expire when running under valgrind. We should keep the behavior of --no-timeout
15331         to not disable this timout check because --no-timeout is used by performace tests
15332         and those should not wait for the web process to initialize and reset more than
15333         normal tests.
15334
15335         * WebKitTestRunner/TestController.cpp:
15336         (WTR::TestController::TestController):
15337         (WTR::TestController::initialize):
15338         (WTR::TestController::runUntil):
15339         * WebKitTestRunner/TestController.h:
15340
15341 2012-07-24  Peter Beverloo  <peter@chromium.org>
15342
15343         [Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
15344         https://bugs.webkit.org/show_bug.cgi?id=92097
15345
15346         Unreviewed build fix.
15347
15348         WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
15349         but TestDelegate.h forward declares it as a class.
15350
15351         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
15352         (WebKit):
15353
15354 2012-07-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
15355
15356         [Qt] Fix compilation against namespaced Qt
15357
15358         Reviewed by Simon Hausmann.
15359
15360         * QtTestBrowser/launcherwindow.h:
15361         * WebKitTestRunner/PlatformWebView.h:
15362
15363 2012-07-24  Peter Beverloo  <peter@chromium.org>
15364
15365         Update a few Chromium Android contributors in committers.py
15366         https://bugs.webkit.org/show_bug.cgi?id=92090
15367
15368         Reviewed by Kent Tamura.
15369
15370         Add Sami Kyostila, who has been doing significant work on Chromium's
15371         compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
15372         remove John Grabowski who changed projects, and add my webkit.org alias.
15373
15374         * Scripts/webkitpy/common/config/committers.py:
15375
15376 2012-07-24  Pierre Rossi  <pierre.rossi@gmail.com>
15377
15378         [Qt] Enable touch slider when touch events are enabled
15379         https://bugs.webkit.org/show_bug.cgi?id=91013
15380
15381         Reviewed by Kenneth Rohde Christiansen.
15382
15383         TOUCH_SLIDER guards are used in WebCore, so we should really
15384         be setting the corresponding ENABLE define in features.prf.
15385
15386         * qmake/mkspecs/features/features.prf:
15387
15388 2012-07-24  Ryuan Choi  <ryuan.choi@samsung.com>
15389
15390         [EFL] EWebLauncher should not require config.h in the style check
15391         https://bugs.webkit.org/show_bug.cgi?id=92070
15392
15393         Reviewed by Kentaro Hara.
15394
15395         * Scripts/webkitpy/style/checker.py:
15396         Remove the include rules from the style-check for EWebLauncher because
15397         EWebLauncher is simple EFL application.
15398
15399 2012-07-24  Jochen Eisinger  <jochen@chromium.or>
15400
15401         [Chromium] EventSender shouldn't know about TestShell
15402         https://bugs.webkit.org/show_bug.cgi?id=91449
15403
15404         Reviewed by Adam Barth.
15405
15406         Original patch by Adam Barth.
15407
15408         This patch removes the dependency from EventSender to TestShell.  Most
15409         of EventSender works directly with a WebView, but there are a handful
15410         of references to WebViewHost.  We don't want to re-use WebViewHost in
15411         ContentShell because we want to use the multi-process embedding
15412         environment for WebViews.
15413
15414         To avoid the dependency on WebViewHost, this patch introduces
15415         TestDelegate, which is an abstract base class for WebViewHost.  In
15416         ContentShell, we'll need another object to implement these functions.
15417
15418         * DumpRenderTree/chromium/EventSender.cpp:
15419         (EventSender::EventSender):
15420         (EventSender::keyDown):
15421         (makeMenuItemStringsFor):
15422         (EventSender::contextClick):
15423         * DumpRenderTree/chromium/EventSender.h:
15424         (EventSender):
15425         (EventSender::setDelegate):
15426         (EventSender::setWebView):
15427         (EventSender::webview):
15428         * DumpRenderTree/chromium/TestRunner/TestDelegate.h: Added.
15429         (WebKit):
15430         (TestDelegate):
15431         * DumpRenderTree/chromium/TestShell.cpp:
15432         (TestShell::initialize):
15433         (TestShell::createMainWindow):
15434         (TestShell::~TestShell):
15435         * DumpRenderTree/chromium/WebViewHost.cpp:
15436         (WebViewHost::fillSpellingSuggestionList):
15437         * DumpRenderTree/chromium/WebViewHost.h:
15438         (WebViewHost):
15439
15440 2012-07-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
15441
15442         Make WebIntents and WebIntentsTag a build option for the build-webkit script
15443         https://bugs.webkit.org/show_bug.cgi?id=91841
15444
15445         Reviewed by Philippe Normand.
15446
15447         And it will also be disabled when building with --minimal.
15448
15449         * Scripts/webkitperl/FeatureList.pm:
15450
15451 2012-07-23  Dirk Pranke  <dpranke@chromium.org>
15452
15453         Unreviewed, rolling out r123360.
15454         http://trac.webkit.org/changeset/123360
15455         https://bugs.webkit.org/show_bug.cgi?id=91890
15456
15457         broke the chromium bots
15458
15459         * Scripts/webkitpy/layout_tests/port/chromium.py:
15460         (ChromiumPort._static_build_path):
15461         (ChromiumPort.default_results_directory):
15462         (ChromiumPort._build_path):
15463         (ChromiumPort._path_to_image_diff):
15464         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
15465         (ChromiumAndroidPort._build_path):
15466         (ChromiumAndroidPort._path_to_driver):
15467         (ChromiumAndroidPort._path_to_forwarder):
15468         (ChromiumAndroidPort._push_executable):
15469         (ChromiumAndroidPort._push_fonts):
15470         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
15471         (ChromiumLinuxPort._determine_driver_path_statically):
15472         (ChromiumLinuxPort._modules_to_search_for_symbols):
15473         (ChromiumLinuxPort._path_to_driver):
15474         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
15475         (ChromiumLinuxPortTest.test_build_path):
15476         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
15477         (ChromiumMacPort._modules_to_search_for_symbols):
15478         (ChromiumMacPort._path_to_driver):
15479         (ChromiumMacPort._path_to_helper):
15480         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
15481         (ChromiumMacPortTest.test_build_path):
15482         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
15483         (ChromiumWinPort._path_to_driver):
15484         (ChromiumWinPort._path_to_helper):
15485         (ChromiumWinPort._path_to_image_diff):
15486         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
15487         (ChromiumWinTest.test_build_path):
15488
15489 2012-07-23  Adam Barth  <abarth@webkit.org>
15490
15491         [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
15492         https://bugs.webkit.org/show_bug.cgi?id=91459
15493
15494         Reviewed by Ryosuke Niwa.
15495
15496         Rather than having TestShell own and bind each of these JavaScript APIs
15497         individually, TestShell should delegate that work to TestInterfaces.
15498         This patch moves AccessibilityController and TextInputController to be
15499         the responsibility of TestInterfaces.
15500
15501         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
15502         (TestInterfaces::TestInterfaces):
15503         (TestInterfaces::~TestInterfaces):
15504         (TestInterfaces::setWebView):
15505         (TestInterfaces::bindTo):
15506         (TestInterfaces::resetAll):
15507         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
15508         (WebKit):
15509         (TestInterfaces):
15510         (TestInterfaces::accessibilityController):
15511         * DumpRenderTree/chromium/TestShell.cpp:
15512         (TestShell::initialize):
15513         (TestShell::createMainWindow):
15514         (TestShell::~TestShell):
15515         (TestShell::resetTestController):
15516         (TestShell::bindJSObjectsToWindow):
15517         * DumpRenderTree/chromium/TestShell.h:
15518         (TestShell::accessibilityController):
15519         (TestShell):
15520
15521 2012-07-23  Balazs Kelemen  <kbalazs@webkit.org>
15522
15523         nrwt swallows early exceptions
15524         https://bugs.webkit.org/show_bug.cgi?id=91884
15525
15526         Reviewed by Dirk Pranke.
15527
15528         Put everything in a try block so we won't miss any error.
15529
15530         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15531         (run):
15532         (main):
15533
15534 2012-07-23  Christophe Dumez  <christophe.dumez@intel.com>
15535
15536         [WK2] WebKitTestRunner needs to print information about Web intents
15537         https://bugs.webkit.org/show_bug.cgi?id=90873
15538
15539         Reviewed by Anders Carlsson.
15540
15541         Print out information about new intents requests and intent
15542         services registrations in WebKitTestRunner. This is expected
15543         by tests under webintents/*.
15544
15545         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
15546         (WTR::InjectedBundlePage::InjectedBundlePage):
15547         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
15548         (WTR):
15549         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
15550         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
15551         (InjectedBundlePage):
15552
15553 2012-07-23  Dirk Pranke  <dpranke@chromium.org>
15554
15555         nrwt: never finds binaries in the 'out' dir on chromium win
15556         https://bugs.webkit.org/show_bug.cgi?id=91890
15557
15558         Reviewed by Tony Chang.
15559
15560         We were figuring out which directory look in for binaries by
15561         testing for the base directory (the directory above
15562         Debug/Release). In chromium-win's case, we look in src/build,
15563         which always exists because there are checked-in files in it,
15564         which means we'd always pick that directory over src/out. All of
15565         the other ports' build_path() implementation was including
15566         Debug/Release. If we matched that, we wouldn't have a problem,
15567         so this change fixes that and updates all of the callers of the
15568         chromium ports' implementation to not pass configuration as part
15569         of the path to look up; we still need to pass configuration in
15570         some cases (to test if the build is out of date between debug
15571         and release) so the implementation gets slightly more
15572         complicated.
15573
15574         * Scripts/webkitpy/layout_tests/port/chromium.py:
15575         (ChromiumPort._static_build_path):
15576         (ChromiumPort.default_results_directory):
15577         (ChromiumPort._build_path):
15578         (ChromiumPort._path_to_image_diff):
15579         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
15580         (ChromiumAndroidPort._build_path):
15581         (ChromiumAndroidPort._path_to_driver):
15582         (ChromiumAndroidPort._path_to_forwarder):
15583         (ChromiumAndroidPort._push_executable):
15584         (ChromiumAndroidPort._push_fonts):
15585         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
15586         (ChromiumLinuxPort._determine_driver_path_statically):
15587         (ChromiumLinuxPort._modules_to_search_for_symbols):
15588         (ChromiumLinuxPort._path_to_driver):
15589         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
15590         (ChromiumLinuxPortTest.test_build_path):
15591         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
15592         (ChromiumMacPort._modules_to_search_for_symbols):
15593         (ChromiumMacPort._path_to_driver):
15594         (ChromiumMacPort._path_to_helper):
15595         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
15596         (ChromiumMacPortTest.test_build_path):
15597         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
15598         (ChromiumWinPort._path_to_driver):
15599         (ChromiumWinPort._path_to_helper):
15600         (ChromiumWinPort._path_to_image_diff):
15601         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
15602         (ChromiumWinTest.test_build_path):
15603
15604 2012-07-23  Sheriff Bot  <webkit.review.bot@gmail.com>
15605
15606         Unreviewed, rolling out r123339.
15607         http://trac.webkit.org/changeset/123339
15608         https://bugs.webkit.org/show_bug.cgi?id=92006
15609
15610         massive media tests failure (Requested by philn on #webkit).
15611
15612         * Scripts/webkitdirs.pm:
15613         (buildAutotoolsProject):
15614         * gtk/jhbuild.modules:
15615
15616 2012-07-23  Tommy Widenflycht  <tommyw@google.com>
15617
15618         [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
15619         https://bugs.webkit.org/show_bug.cgi?id=91857
15620
15621         Reviewed by Adam Barth.
15622
15623         Made a few changes so that the destructor could be called at shutdown.
15624
15625         * DumpRenderTree/chromium/DumpRenderTree.cpp:
15626         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
15627         (WebKitSupportTestEnvironment):
15628         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
15629         (MockWebKitPlatformSupport::create):
15630         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
15631         (MockWebKitPlatformSupport):
15632         (MockWebKitPlatformSupport::~MockWebKitPlatformSupport):
15633
15634 2012-07-23  Philippe Normand  <pnormand@igalia.com>
15635
15636         [GTK][jhbuild] Switch to GStreamer 0.11 build
15637         https://bugs.webkit.org/show_bug.cgi?id=91727
15638
15639         Reviewed by Gustavo Noronha Silva.
15640
15641         Switch build-webkit --gtk to GStreamer 0.11 support and build the
15642         necessary GStreamer git modules from JHBuild.
15643
15644         * Scripts/webkitdirs.pm:
15645         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
15646         * gtk/jhbuild.modules: GStreamer build support.
15647
15648 2012-07-23  Christophe Dumez  <christophe.dumez@intel.com>
15649
15650         WebKit2 needs layoutTestController.setAlwaysAcceptCookies
15651         https://bugs.webkit.org/show_bug.cgi?id=42778
15652
15653         Reviewed by Kenneth Rohde Christiansen.
15654
15655         Add support for layoutTestController.setAlwaysAcceptCookies()
15656         since it is required by some tests.
15657
15658         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
15659         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
15660         (WTR::LayoutTestController::setAlwaysAcceptCookies):
15661         (WTR):
15662         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
15663         (LayoutTestController):
15664
15665 2012-07-23  Kent Tamura  <tkent@chromium.org>
15666
15667         Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
15668         https://bugs.webkit.org/show_bug.cgi?id=91941
15669
15670         Reviewed by Kentaro Hara.
15671
15672         A flag name for an elmement should be ENABLE_*_ELEMENT.
15673
15674         * Scripts/webkitperl/FeatureList.pm:
15675         * qmake/mkspecs/features/features.pri:
15676
15677 2012-07-22  Kent Tamura  <tkent@chromium.org>
15678
15679         Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
15680         https://bugs.webkit.org/show_bug.cgi?id=91928
15681
15682         Reviewed by Kentaro Hara.
15683
15684         A flag name for an elmement should be ENABLE_*_ELEMENT.
15685
15686         * Scripts/webkitperl/FeatureList.pm:
15687         * qmake/mkspecs/features/features.pri:
15688
15689 2012-07-20  Kent Tamura  <tkent@chromium.org>
15690
15691         Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT
15692         https://bugs.webkit.org/show_bug.cgi?id=91846
15693
15694         Reviewed by Kentaro Hara.
15695
15696         A flag name for an elmement should be ENABLE_*_ELEMENT.
15697
15698         * Scripts/webkitperl/FeatureList.pm:
15699         * qmake/mkspecs/features/features.pri:
15700
15701 2012-07-20  Xianzhu Wang  <wangxianzhu@chromium.org>
15702
15703         [Chromium-Android] Store test pipes in /data/local/tmp
15704         https://bugs.webkit.org/show_bug.cgi?id=91909
15705
15706         In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
15707         However after tests we found some devices don't allow the app to create pipes there.
15708         So /data/local/tmp is a better place for the pipes.
15709
15710         Reviewed by Adam Barth.
15711
15712         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
15713
15714 2012-07-20  Xianzhu Wang  <wangxianzhu@chromium.org>
15715
15716         [Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
15717         https://bugs.webkit.org/show_bug.cgi?id=91873
15718
15719         Reviewed by Adam Barth.
15720
15721         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
15722
15723 2012-07-20  Han Shen  <shenhan@google.com>
15724
15725         [Chromium] Compilation fails under gcc 4.7
15726         https://bugs.webkit.org/show_bug.cgi?id=90227
15727
15728         Reviewed by Tony Chang.
15729
15730         Disable warnings about c++0x compatibility in gcc newer than 4.6.
15731
15732         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
15733
15734 2012-07-20  Dirk Pranke  <dpranke@chromium.org>
15735
15736         REGRESSION: run-perf-tests --pause-before-testing is broken
15737         https://bugs.webkit.org/show_bug.cgi?id=91789
15738
15739         Reviewed by Ryosuke Niwa.
15740
15741         Turns out start() wasn't actually starting things :(. Fixed, and
15742         added tests.
15743
15744         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
15745         (ChromiumAndroidDriverTest.test_read_prompt):
15746         * Scripts/webkitpy/layout_tests/port/driver.py:
15747         (Driver.__init__):
15748         (Driver._start):
15749         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
15750         (DriverTest.test_read_block):
15751         (DriverTest.test_read_binary_block):
15752         (DriverTest.test_read_base64_block):
15753         (DriverTest.test_stop_cleans_up_properly):
15754         (DriverTest.test_two_starts_cleans_up_properly):
15755         (DriverTest.test_start_actually_starts):
15756         (MockServerProcess.__init__):
15757         (MockServerProcess.start):
15758
15759 2012-07-20  Jochen Eisinger  <jochen@chromium.org>
15760
15761         [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
15762         https://bugs.webkit.org/show_bug.cgi?id=91847
15763
15764         Reviewed by Adam Barth.
15765
15766         This allows for including the TestIntefaces.h from content shell
15767         without introducing a dependency to WebCore/wtf
15768
15769         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
15770         (TestInterfaces::Internal):
15771         (TestInterfaces::Internal::Internal):
15772         (TestInterfaces::Internal::~Internal):
15773         (TestInterfaces::Internal::bindTo):
15774         (TestInterfaces::Internal::resetAll):
15775         (TestInterfaces::TestInterfaces):
15776         (TestInterfaces::~TestInterfaces):
15777         (TestInterfaces::bindTo):
15778         (TestInterfaces::resetAll):
15779         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
15780         (TestInterfaces):
15781
15782 2012-07-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
15783
15784         [Qt] Make WTR use the same color palette as DRT
15785         https://bugs.webkit.org/show_bug.cgi?id=91870
15786
15787         Reviewed by Noam Rosenthal.
15788
15789         Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
15790         standard from QWindowsStyle.
15791
15792         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
15793         (WTR::activateFonts): Moved code to platformInitialize since setting style is not
15794         exactly font related.
15795         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
15796         (WTR::InjectedBundle::platformInitialize): Force the usage of the style's
15797         palette.  Because at this point QApplication was already instantiated, the
15798         default palette was already initialized to be the system one, so we need to
15799         explicitly set the palette to be the standard from style. This is not needed in
15800         DRT because there we set the style before instantiating QApplication.
15801
15802 2012-07-20  Tony Chang  <tony@chromium.org>
15803
15804         Baseline align text in the flakiness dashboard toolbar
15805         https://bugs.webkit.org/show_bug.cgi?id=91784
15806
15807         Reviewed by Ojan Vafai.
15808
15809         Baseline align the flex items.
15810
15811         * TestResultServer/static-dashboards/flakiness_dashboard.css:
15812         (.forms): Add box-align: baseline
15813         (.forms > *): Use block display to force flex items rather than box.
15814         (#tests-form): Add box-align: baseline
15815         (#tests-form > *): Use block display to force flex items rather than box.
15816
15817 2012-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
15818
15819         Unreviewed, rolling out r123220.
15820         http://trac.webkit.org/changeset/123220
15821         https://bugs.webkit.org/show_bug.cgi?id=91880
15822
15823         broke Debug build (Requested by philn on #webkit).
15824
15825         * Scripts/webkitdirs.pm:
15826         (buildAutotoolsProject):
15827         * gtk/jhbuild.modules:
15828
15829 2012-07-20  Philippe Normand  <pnormand@igalia.com>
15830
15831         [GTK][jhbuild] Switch to GStreamer 0.11 build
15832         https://bugs.webkit.org/show_bug.cgi?id=91727
15833
15834         Reviewed by Gustavo Noronha Silva.
15835
15836         Switch build-webkit --gtk to GStreamer 0.11 support and build the
15837         necessary GStreamer git modules from JHBuild.
15838
15839         * Scripts/webkitdirs.pm:
15840         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
15841         * gtk/jhbuild.modules: GStreamer build support.
15842
15843 2012-07-20  Christophe Dumez  <christophe.dumez@intel.com>
15844
15845         [EFL] Proxy configuration should honor the no_proxy environment variable
15846         https://bugs.webkit.org/show_bug.cgi?id=91747
15847
15848         Reviewed by Kenneth Rohde Christiansen.
15849
15850         Add ProxyResolverSoup to the list of classes that contain GObjects
15851         in style checker script so that it does not complain about naming
15852         convention issues that are mandated by GObject.
15853
15854         * Scripts/webkitpy/style/checker.py:
15855
15856 2012-07-20  Zeno Albisser  <zeno@webkit.org>
15857
15858         [Qt][WK2] Add configure tests for Xrender and GLX.
15859         https://bugs.webkit.org/show_bug.cgi?id=91845
15860
15861         GraphicsSurface on linux requires Xcomposite, Xrender
15862         and GLX. If any of these requirements is not met,
15863         we should disable GraphicsSurface.
15864
15865         Reviewed by Kenneth Rohde Christiansen.
15866
15867         * qmake/config.tests/glx/glx.cpp: Added.
15868         (main):
15869         * qmake/config.tests/glx/glx.pro: Added.
15870         * qmake/config.tests/libXrender/libXrender.cpp: Added.
15871         (main):
15872         * qmake/config.tests/libXrender/libXrender.pro: Added.
15873         * qmake/configure.pri:
15874         * qmake/mkspecs/features/features.prf:
15875
15876 2012-07-20  Kangil Han  <kangil.han@samsung.com>
15877
15878         [EFL][WK2][WTR] Implement EventSenderProxy
15879         https://bugs.webkit.org/show_bug.cgi?id=91731
15880
15881         Reviewed by Kentaro Hara.
15882
15883         This is an initial EFL port implementation of EventSenderProxy.
15884
15885         * WebKitTestRunner/EventSenderProxy.h:
15886         (WTR):
15887         (EventSenderProxy):
15888         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
15889         * WebKitTestRunner/PlatformEfl.cmake:
15890         * WebKitTestRunner/TestController.cpp:
15891         (WTR::TestController::TestController):
15892         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
15893         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added.
15894         (WTR):
15895         (WTREvent):
15896         (WTR::WTREvent::WTREvent):
15897         (WTR::KeyEventInfo::KeyEventInfo):
15898         (KeyEventInfo):
15899         (WTR::evasMouseButton):
15900         (WTR::setEvasModifiers):
15901         (WTR::dispatchMouseDownEvent):
15902         (WTR::dispatchMouseUpEvent):
15903         (WTR::dispatchMouseMoveEvent):
15904         (WTR::dispatchMouseScrollByEvent):
15905         (WTR::keyPadName):
15906         (WTR::keyName):
15907         (WTR::EventSenderProxy::EventSenderProxy):
15908         (WTR::EventSenderProxy::updateClickCountForButton):
15909         (WTR::EventSenderProxy::dispatchEvent):
15910         (WTR::EventSenderProxy::replaySavedEvents):
15911         (WTR::EventSenderProxy::sendOrQueueEvent):
15912         (WTR::EventSenderProxy::mouseDown):
15913         (WTR::EventSenderProxy::mouseUp):
15914         (WTR::EventSenderProxy::mouseMoveTo):
15915         (WTR::EventSenderProxy::mouseScrollBy):
15916         (WTR::EventSenderProxy::leapForward):
15917         (WTR::EventSenderProxy::keyDown):
15918         (WTR::EventSenderProxy::addTouchPoint):
15919         (WTR::EventSenderProxy::updateTouchPoint):
15920         (WTR::EventSenderProxy::setTouchModifier):
15921         (WTR::EventSenderProxy::touchStart):
15922         (WTR::EventSenderProxy::touchMove):
15923         (WTR::EventSenderProxy::touchEnd):
15924         (WTR::EventSenderProxy::touchCancel):
15925         (WTR::EventSenderProxy::clearTouchPoints):
15926         (WTR::EventSenderProxy::releaseTouchPoint):
15927         (WTR::EventSenderProxy::cancelTouchPoint):
15928         (WTR::EventSenderProxy::setTouchPointRadius):
15929
15930 2012-07-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
15931
15932         Unreviewed, rolling out r123085.
15933         http://trac.webkit.org/changeset/123085
15934         https://bugs.webkit.org/show_bug.cgi?id=91719
15935
15936         r123085 causes crashes on EFL layout test bot.
15937
15938         * WebKitTestRunner/CMakeLists.txt:
15939         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
15940         (WTR::LayoutTestController::platformInitialize):
15941
15942 2012-07-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
15943
15944         [WTR] Add *explicit* keyword to constructor which has a parameter
15945         https://bugs.webkit.org/show_bug.cgi?id=91745
15946
15947         Reviewed by Adam Barth.
15948
15949         Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
15950
15951         * WebKitTestRunner/EventSenderProxy.h:
15952         (EventSenderProxy):
15953         * WebKitTestRunner/TestInvocation.h:
15954         (TestInvocation):
15955
15956 2012-07-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
15957
15958         [EFL] [WK2] Add methods to get/set a custom text encoding
15959         https://bugs.webkit.org/show_bug.cgi?id=90604
15960
15961         Reviewed by Kenneth Rohde Christiansen.
15962
15963         Added support for setting custom character encoding in MiniBrowser.
15964         Use 'F3' to set the custom character encoding.
15965
15966         * MiniBrowser/efl/main.c:
15967         (on_key_down):
15968
15969 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
15970
15971         webkitpy: executive_unittest still failing when run in parallel
15972         https://bugs.webkit.org/show_bug.cgi?id=91795
15973
15974         Reviewed by Adam Barth.
15975
15976         It turns out that test_kill_process and test_kill_all are both
15977         launching the same process, and so if they're run at the same
15978         time, test_kill_all interferes w/ test_kill_process.
15979
15980         Merging the two tests solves the issue :).
15981
15982         * Scripts/webkitpy/common/system/executive_unittest.py:
15983         (ExecutiveTest.test_kill_process):
15984         (ExecutiveTest._assert_windows_image_name):
15985         (ExecutiveTest):
15986         (ExecutiveTest.test_windows_image_name):
15987
15988 2012-07-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
15989
15990         [EFL] [WK2] Add a callback to handle delete request in MiniBrowser
15991         https://bugs.webkit.org/show_bug.cgi?id=91483
15992
15993         Reviewed by Dirk Pranke.
15994
15995         Add a callback to handle delete request and quit the main loop when
15996         window is asked to be deleted so that all the resources allocated
15997         for the window will be freed properly.
15998
15999         * MiniBrowser/efl/main.c:
16000         (closeWindow):
16001         (browserCreate):
16002
16003 2012-07-19  No'am Rosenthal  <noam.rosenthal@nokia.com>
16004
16005         [Qt] Enable CSS shaders in Qt (software mode)
16006         https://bugs.webkit.org/show_bug.cgi?id=85140
16007
16008         Reviewed by Simon Hausmann.
16009
16010         Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
16011
16012         * qmake/mkspecs/features/features.prf:
16013
16014 2012-07-19  No'am Rosenthal  <noam.rosenthal@nokia.com>
16015
16016         [Qt] Enable CSS shaders in Qt (software mode)
16017         https://bugs.webkit.org/show_bug.cgi?id=85140
16018
16019         Reviewed by Simon Hausmann.
16020
16021         Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
16022
16023         * qmake/mkspecs/features/features.prf:
16024
16025 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
16026
16027         test-webkitpy: fix executive_unittest nits, including a missing 'errno' import
16028         https://bugs.webkit.org/show_bug.cgi?id=91770
16029
16030         Reviewed by Adam Barth.
16031
16032         The missing errno import is causing a flaky failure when run in
16033         parallel on the bots.
16034
16035         * Scripts/webkitpy/common/system/executive_unittest.py:
16036         (ExecutiveTest.assert_interpreter_for_content):
16037
16038 2012-07-19  Oliver Hunt  <oliver@apple.com>
16039
16040         Make style bot handle underscores in names more reasonably
16041         https://bugs.webkit.org/show_bug.cgi?id=91777
16042
16043         Reviewed by Gavin Barraclough.
16044
16045         This patch adds a naming/readability/underscores category for style errors.
16046         That allows us to use underscores in those portions of JSC (and potentially
16047         gtk?) without turning off all naming checks for the effected directories.
16048         We also filter out the DFG_OPERATION warning, and a few other minor changes
16049         to make the style bot less noisy when running over JSC at least.
16050
16051         * Scripts/webkitpy/style/checker.py:
16052         * Scripts/webkitpy/style/checkers/cpp.py:
16053         (check_identifier_name_in_declaration):
16054         (CppChecker):
16055         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
16056         (WebKitStyleTest.test_names):
16057
16058 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
16059
16060         config_standalone.py is crashing on apple win's cygwin port
16061         https://bugs.webkit.org/show_bug.cgi?id=91682
16062
16063         Reviewed by Adam Roben.
16064
16065         Work around a weird interaction of ctypes and cygwin that
16066         is causing unit tests to crash for me locally.
16067
16068         * Scripts/webkitpy/common/system/executive.py:
16069         (Executive._win32_check_running_pid):
16070
16071 2012-07-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
16072
16073         [GTK] WebKit test runner ignores all system environment variables
16074         https://bugs.webkit.org/show_bug.cgi?id=90284
16075
16076         Reviewed by Dirk Pranke.
16077
16078         Added support in unit test framework to pass a custom environment
16079         variable to the tests by using the --additional-env-var parameter.
16080
16081         * Scripts/webkitpy/layout_tests/port/base.py:
16082         (Port.to.setup_environ_for_server): Adding environment variables
16083         that come through the additional_env_var option.
16084         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
16085         (PortTest.test_additional_env_var): Added unit test for the
16086         additional_env_var option
16087         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16088         (parse_args): Added the --additional-env-var parameter.
16089
16090 2012-07-19  Joshua Bell  <jsbell@chromium.org>
16091
16092         Roll out r121610 and r122487 which may have been causing flaky crashes
16093         https://bugs.webkit.org/show_bug.cgi?id=91637
16094
16095         Reviewed by Kentaro Hara.
16096
16097         Flaky crashes started in random tests following r121610. It's not clear
16098         that r121610 is to blame, but we'd like to prove or disprove it.
16099         If this doesn't resolve the crashes, this patch should be rolled out.
16100
16101         * DumpRenderTree/DumpRenderTree.gypi:
16102         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
16103         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
16104         (PluginTest):
16105         * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Removed.
16106
16107 2012-07-19  Pierre Rossi  <pierre.rossi@gmail.com>
16108
16109         [Qt][WK2] Map the elementRect exposed in QML to the view for popup menu
16110         https://bugs.webkit.org/show_bug.cgi?id=91645
16111
16112         Reviewed by Simon Hausmann.
16113
16114         Also improved the logic slightly for edge cases.
16115
16116         * MiniBrowser/qt/qml/ItemSelector.qml:
16117
16118 2012-07-19  Christophe Dumez  <christophe.dumez@intel.com>
16119
16120         [EFL] Bump libsoup dependency to v2.39.4.1 to fix cookie issues
16121         https://bugs.webkit.org/show_bug.cgi?id=91741
16122
16123         Reviewed by Kenneth Rohde Christiansen.
16124
16125         Bump libsoup dependency in jhbuild to v2.39.4.1 to fix issues
16126         with cookies in non-suffixed/private domains [GNOME #679230].
16127
16128         * efl/jhbuild.modules:
16129
16130 2012-07-19  Simon Hausmann  <simon.hausmann@nokia.com>
16131
16132         [Qt] Remove support for Qt versions before 4.8.0
16133         https://bugs.webkit.org/show_bug.cgi?id=91730
16134
16135         Reviewed by Kenneth Rohde Christiansen.
16136
16137         Remove Qt version check #ifdefs for Qt versions before 4.8.0.
16138
16139         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
16140         (LayoutTestController::reset):
16141         (LayoutTestController::setAlwaysBlockCookies):
16142         * DumpRenderTree/qt/LayoutTestControllerQt.h:
16143         (LayoutTestController):
16144
16145 2012-07-19  Mario Sanchez Prada  <msanchez@igalia.com>
16146
16147         [GTK] Enable MHTML support by default at build time
16148         https://bugs.webkit.org/show_bug.cgi?id=89987
16149
16150         Reviewed by Carlos Garcia Campos.
16151
16152         Enable MHTML support by default for GTK in build-webkit.
16153
16154         * Scripts/webkitperl/FeatureList.pm:
16155
16156 2012-07-19  Zoltan Nyul  <zoltan.nyul@intel.com>
16157
16158         [EFL][WK2] Using different cache directory for each WTR process
16159         https://bugs.webkit.org/show_bug.cgi?id=91719
16160
16161         Reviewed by Kenneth Rohde Christiansen.
16162
16163         The testrunner script may be running multiple processes in
16164         parallel, and it makes appcache tests fail if they are using the same
16165         directory. I modified the EFL's LayoutTestController to use the
16166         DUMPRENDERTREE_TEMP for application cache directory because it's
16167         different for each process.
16168
16169         * WebKitTestRunner/CMakeLists.txt:
16170         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
16171         (WTR::LayoutTestController::platformInitialize):
16172
16173 2012-07-19  Mario Sanchez Prada  <msanchez@igalia.com>
16174
16175         [WK2][GTK] Complete implementation of AccessibilityController in WKTR for GTK
16176         https://bugs.webkit.org/show_bug.cgi?id=89224
16177
16178         Reviewed by Chris Fleizach.
16179
16180         Implement logAccessibilityEvents() and resetToConsistentState(),
16181         so we can ask WKTR from the layout tests for logging all the
16182         accessibility related events into the result.
16183
16184         * WebKitTestRunner/GNUmakefile.am:
16185         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
16186         (WTR::AccessibilityController::AccessibilityController):
16187         (WTR):
16188         (WTR::AccessibilityController::logAccessibilityEvents):
16189         (WTR::AccessibilityController::resetToConsistentState):
16190         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
16191         (AccessibilityController):
16192         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp: Added.
16193         (WTR):
16194         (WTR::printAccessibilityEvent):
16195         (WTR::axObjectEventListener):
16196         (WTR::AccessibilityController::logAccessibilityEvents):
16197         (WTR::AccessibilityController::resetToConsistentState):
16198
16199         Ensure we reset the accessibility controller to a consistent
16200         whenever a test has finished running.
16201
16202         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
16203         (WTR::InjectedBundle::done):
16204
16205 2012-07-19  Dominik Röttsches  <dominik.rottsches@intel.com>
16206
16207         [EFL][Wk2] Add a bot that runs WTR / WebKit2 tests
16208         https://bugs.webkit.org/show_bug.cgi?id=90788
16209
16210         Reviewed by Kentaro Hara.
16211
16212         Adding EFL 64bit WK2 BuildAndTest bot. At this point, we cannot transfer
16213         the build product from one bot to the other due to link path issues with jhbuild,
16214         so we do a full build and test cycle for WebKit2 on this bot.
16215
16216         * BuildSlaveSupport/build.webkit.org-config/config.json: Adding the new slave.
16217         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Adding a new factory for building and testing WebKit2.
16218         (BuildAndTestWebKit2Factory):
16219
16220 2012-07-18  Mihnea Ovidenie  <mihnea@adobe.com>
16221
16222         Unreviewed. Adding Andrei Bucur, Mihai Balan and Raul Hudea to the contributors list.
16223         They are Adobe contributors working on CSSRegions.
16224
16225         * Scripts/webkitpy/common/config/committers.py:
16226
16227 2012-07-18  Christophe Dumez  <christophe.dumez@intel.com>
16228
16229         [CMake][EFL] Should try to find the same libsoup version pulled by jhbuild
16230         https://bugs.webkit.org/show_bug.cgi?id=91626
16231
16232         Reviewed by Kenneth Rohde Christiansen.
16233
16234         Update jhbuild to pull libsoup 2.39.3 tarball from Gnome FTP instead
16235         of fetching a tag from Gnome GIT. We need to do this to map the version
16236         of libsoup that is required by our CMake config.
16237
16238         * efl/jhbuild.modules:
16239
16240 2012-07-18  MORITA Hajime  <morrita@google.com>
16241
16242         Add window resize benchmark
16243         https://bugs.webkit.org/show_bug.cgi?id=91070
16244
16245         Reviewed by Ryosuke Niwa.
16246
16247         Added some more output filters to take care of html5.html output.
16248
16249         * Scripts/webkitpy/performance_tests/perftest.py:
16250         (PerfTest):
16251
16252 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
16253
16254         nrwt: merge WebKitDriver into Driver
16255         https://bugs.webkit.org/show_bug.cgi?id=91696
16256
16257         Reviewed by Adam Barth.
16258
16259         As part of merging WebKitPort into Port, we also should merge
16260         WebKitDriver into Driver, since all of the non-test Drivers now
16261         inherit from WebKitDriver.
16262
16263         There are no functional changes in this patch, and all the changes should
16264         be covered by the existing tests.
16265
16266         * Scripts/webkitpy/layout_tests/port/base.py:
16267         (Port._driver_class):
16268         * Scripts/webkitpy/layout_tests/port/chromium.py:
16269         (ChromiumPort._check_file_exists):
16270         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
16271         (ChromiumAndroidDriver):
16272         (ChromiumAndroidDriver.__init__):
16273         (ChromiumAndroidDriver._drt_cmd_line):
16274         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
16275         (ChromiumAndroidDriverTest.test_read_prompt):
16276         * Scripts/webkitpy/layout_tests/port/driver.py:
16277         (Driver):
16278         (Driver.__init__):
16279         (Driver.__del__):
16280         (Driver.run_test):
16281         (Driver.has_crashed):
16282         (Driver.start):
16283         (Driver._start):
16284         (Driver.stop):
16285         (Driver.cmd_line):
16286         (Driver._check_for_driver_crash):
16287         (Driver._command_from_driver_input):
16288         (Driver._read_first_block):
16289         (Driver._read_optional_image_block):
16290         (Driver._read_header):
16291         (Driver._process_stdout_line):
16292         (Driver._strip_eof):
16293         (Driver._read_block):
16294         (ContentBlock):
16295         (ContentBlock.__init__):
16296         (ContentBlock.decode_content):
16297         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
16298         (DriverTest.make_port):
16299         (DriverTest._assert_wrapper):
16300         (DriverTest.test_read_block):
16301         (DriverTest):
16302         (DriverTest.test_read_binary_block):
16303         (DriverTest.test_read_base64_block):
16304         (DriverTest.test_no_timeout):
16305         (DriverTest.test_check_for_driver_crash):
16306         (DriverTest.test_check_for_driver_crash.FakeServerProcess):
16307         (DriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
16308         (DriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
16309         (DriverTest.test_check_for_driver_crash.FakeServerProcess.name):
16310         (DriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
16311         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
16312         (DriverTest.test_check_for_driver_crash.assert_crash):
16313         (DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
16314         (DriverTest.test_stop_cleans_up_properly):
16315         (DriverTest.test_two_starts_cleans_up_properly):
16316         (MockServerProcess):
16317         (MockServerProcess.__init__):
16318         (MockServerProcess.has_crashed):
16319         (MockServerProcess.read_stdout_line):
16320         (MockServerProcess.read_stdout):
16321         (MockServerProcess.read_either_stdout_or_stderr_line):
16322         (MockServerProcess.start):
16323         (MockServerProcess.stop):
16324         (MockServerProcess.kill):
16325         * Scripts/webkitpy/layout_tests/port/gtk.py:
16326         * Scripts/webkitpy/layout_tests/port/webkit.py:
16327         (WebKitPort._read_image_diff):
16328         (WebKitPort.skipped_layout_tests):
16329         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
16330         (test_path_to_apache_config_file):
16331         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
16332         (XvfbDriver):
16333         (XvfbDriver.stop):
16334
16335 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
16336
16337         webkitpy.common.system.executive_unittest.ExecutiveTest.test_kill_process is flaky
16338         https://bugs.webkit.org/show_bug.cgi?id=91698
16339
16340         Unreviewed, build fix.
16341
16342         This is a workaround for the test failing (apparently mostly?)
16343         when run in parallel with other tests. The underlying bug still
16344         needs to be diagnosed as we shouldn't be getting ECHILD from
16345         process.wait().
16346
16347         * Scripts/webkitpy/common/system/executive_unittest.py:
16348         (ExecutiveTest.test_kill_process):
16349
16350 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
16351
16352         Disable running python unit tests in parallel on win32 for now.
16353         https://bugs.webkit.org/show_bug.cgi?id=91697
16354
16355         Unreviewed, build fix.
16356
16357         * Scripts/webkitpy/test/main.py:
16358         (Tester._parse_args):
16359
16360 2012-07-18  Dave Tu  <dtu@chromium.org>
16361
16362         [chromium] Add gl_tests to flakiness dashboard.
16363         https://bugs.webkit.org/show_bug.cgi?id=91680
16364
16365         Reviewed by Dirk Pranke.
16366
16367         * TestResultServer/static-dashboards/builders.js:
16368         (loadBuildersList):
16369         * TestResultServer/static-dashboards/dashboard_base.js:
16370         (currentBuilderGroupCategory):
16371
16372 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
16373
16374         fix python unit tests failing under cygwin
16375         https://bugs.webkit.org/show_bug.cgi?id=91678
16376
16377         Reviewed by Adam Barth.
16378
16379         Fix a case where executive.kill_process was failing under cygwin
16380         (apple win port) in an unexpected way.
16381         
16382         * Scripts/webkitpy/common/system/executive.py:
16383         (Executive.kill_process):
16384
16385 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
16386
16387         test-webkitpy: run tests in parallel by default
16388         https://bugs.webkit.org/show_bug.cgi?id=91422
16389
16390         Reviewed by Adam Barth.
16391
16392         We use multiprocessing.cpu_count() for the default number of
16393         jobs to run; memory overhead should be very low, so this should
16394         be fine.
16395
16396         * Scripts/webkitpy/test/main.py:
16397         (Tester._parse_args):
16398
16399 2012-07-18  Ryosuke Niwa  <rniwa@webkit.org>
16400
16401         Add Pravin D to the list of contributors.
16402
16403         * Scripts/webkitpy/common/config/committers.py:
16404
16405 2012-07-18  Balazs Kelemen  <kbalazs@webkit.org>
16406
16407         [Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
16408         https://bugs.webkit.org/show_bug.cgi?id=91514
16409
16410         Reviewed by Dirk Pranke.
16411
16412         Analyzing libQtWebKit.so is not enough in the case of force_static_libs_as_shared.
16413         We need to analyze all the shared library or at least the WebCore one.
16414
16415         * Scripts/webkitdirs.pm:
16416         (builtDylibPathForName):
16417         In orwt it is hard coded to search for symbols in the WebCore library.
16418         While in theory it is possible that symbols for a given feature are not
16419         located in that, it doesn't happen in practice, so returning the path of
16420         the WebCore library for a force_static_libs_as_shared build is enough to
16421         fix the bug and it doesn't require a bigger refactoring. For a default
16422         build we still return the path of the QtWebKit lib.
16423         * Scripts/webkitpy/layout_tests/port/qt.py:
16424         (QtPort._modules_to_search_for_symbols):
16425         Enumerate all dynamic libraries, not just the QtWebKit one.
16426
16427 2012-07-18  Tony Chang  <tony@chromium.org>
16428
16429         [chromium] Unreviewed, more compile fixes on Chromium Win.
16430
16431         * DumpRenderTree/chromium/TestShellWin.cpp:
16432         (TestShell::waitTestFinished):
16433         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
16434
16435 2012-07-18  Christophe Dumez  <christophe.dumez@intel.com>
16436
16437         [EFL] Add central error management to EFL port
16438         https://bugs.webkit.org/show_bug.cgi?id=91598
16439
16440         Reviewed by Kenneth Rohde Christiansen.
16441
16442         Map WebKitNetworkError to NSURLErrorDomain when
16443         printing in DumpRenderTree so that the output
16444         matches the expected one.
16445
16446         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
16447         (descriptionSuitableForTestResult):
16448
16449 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
16450
16451         nrwt: start merging port/webkit.py into port/base.py
16452         https://bugs.webkit.org/show_bug.cgi?id=91559
16453
16454         Reviewed by Ojan Vafai.
16455
16456         Since all the non-test port implementations now derive from
16457         WebKitPort, there's no real point in keeping WebKitPort distinct
16458         from Port. This patch starts merging the two by moving nearly
16459         all of the webkit implementations of routines with no default
16460         behavior into base.py. The few that didn't move rely on
16461         additional infrastructure that should be refactored differently
16462         (like the image diffing, which should probably be its own
16463         class) and deserve their own patches.
16464
16465         This patch should just be moving code around, and require no
16466         additional tests; in fact, we can delete the tests that were
16467         asserting virtual methods in the base class.
16468
16469         * Scripts/webkitpy/layout_tests/port/base.py:
16470         (Port.baseline_search_path):
16471         (Port.check_build):
16472         (Port):
16473         (Port._check_driver):
16474         (Port._check_port_build):
16475         (Port.check_image_diff):
16476         (Port.driver_name):
16477         (Port.default_results_directory):
16478         (Port.to.setup_environ_for_server):
16479         (Port._path_to_apache):
16480         (Port._is_redhat_based):
16481         (Port._is_debian_based):
16482         (Port._apache_config_file_name_for_platform):
16483         (Port._path_to_apache_config_file):
16484         (Port._build_path):
16485         (Port._path_to_driver):
16486         (Port._path_to_webcore_library):
16487         (Port._path_to_helper):
16488         (Port._path_to_image_diff):
16489         (Port._path_to_wdiff):
16490         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
16491         (PortTest.test_httpd_returns_error_code):
16492         * Scripts/webkitpy/layout_tests/port/webkit.py:
16493         (WebKitPort):
16494         (WebKitPort._build_driver_flags):
16495         (WebKitPort._read_image_diff):
16496         (WebKitPort.skipped_layout_tests):
16497
16498 2012-07-18  Tommy Widenflycht  <tommyw@google.com>
16499
16500         [chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
16501         https://bugs.webkit.org/show_bug.cgi?id=86215
16502
16503         Reviewed by Adam Barth.
16504
16505         Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
16506         instead create mock objects. No actual mock objects created yet.
16507
16508         * DumpRenderTree/DumpRenderTree.gypi:
16509         * DumpRenderTree/chromium/DumpRenderTree.cpp:
16510         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
16511         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.
16512         (MockWebKitPlatformSupport::create):
16513         (MockWebKitPlatformSupport::MockWebKitPlatformSupport):
16514         (MockWebKitPlatformSupport::cryptographicallyRandomValues):
16515         (MockWebKitPlatformSupport::createMediaStreamCenter):
16516         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.
16517         (MockWebKitPlatformSupport):
16518         * DumpRenderTree/chromium/config.h:
16519
16520 2012-07-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
16521
16522         [CMake][EFL] Build and run TestWebKitAPI unit tests
16523         https://bugs.webkit.org/show_bug.cgi?id=90671
16524
16525         Reviewed by Daniel Bates.
16526
16527         This patch enables almost for free a significant amount of test for the
16528         WebKit C API, WTF and KURL. It makes easy for CMake based ports to
16529         enable TestWebKitAPI since the missing bits to implement are
16530         relatively simple.
16531
16532         * CMakeLists.txt:
16533         * TestWebKitAPI/CMakeLists.txt: Added.
16534         * TestWebKitAPI/PlatformEfl.cmake: Added.
16535         * TestWebKitAPI/PlatformWebView.h:
16536         * TestWebKitAPI/config.h:
16537         * TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
16538         (TestWebKitAPI):
16539         (TestWebKitAPI::InjectedBundleController::platformInitialize):
16540         * TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
16541         (TestWebKitAPI):
16542         (Util):
16543         (TestWebKitAPI::Util::run):
16544         (TestWebKitAPI::Util::sleep):
16545         (TestWebKitAPI::Util::createURLForResource):
16546         (TestWebKitAPI::Util::createInjectedBundlePath):
16547         (TestWebKitAPI::Util::URLForNonExistentResource):
16548         * TestWebKitAPI/efl/PlatformWebView.cpp: Added.
16549         (TestWebKitAPI):
16550         (TestWebKitAPI::initEcoreEvas):
16551         (TestWebKitAPI::PlatformWebView::PlatformWebView):
16552         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
16553         (TestWebKitAPI::PlatformWebView::page):
16554         * TestWebKitAPI/efl/main.cpp: Added.
16555         (checkForUseX11WindowArgument):
16556         (main):
16557
16558 2012-07-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
16559
16560         [CMake][EFL] Building jsc causes reconfiguration
16561         https://bugs.webkit.org/show_bug.cgi?id=91387
16562
16563         Reviewed by Daniel Bates.
16564
16565         We should remove CMakeCache only when running build-webkit script,
16566         otherwise it will cause a reconfiguration every time someone calls
16567         generateBuildSystemFromCMakeProject(). We were re-building "jsc" and
16568         not running WebKit2 unit tests on the bots because the project was
16569         reconfigured with default values by the scripts that run these tests.
16570
16571         * Scripts/build-webkit:
16572         * Scripts/webkitdirs.pm:
16573         (removeCMakeCache):
16574         (generateBuildSystemFromCMakeProject):
16575
16576 2012-07-18  Seokju Kwon  <seokju.kwon@samsung.com>
16577
16578         [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
16579         https://bugs.webkit.org/show_bug.cgi?id=87935
16580
16581         Reviewed by Andreas Kling.
16582
16583         Web Inspector will be shown when path or url contains "inspector/".
16584         Dumprendertree should wait util web inspector resources are loaded totally
16585         and handle the signals for creating or removing a view of web inspector.
16586         ("inspector,view,create" and "inspector,view,close")
16587
16588         * DumpRenderTree/efl/DumpRenderTree.cpp:
16589         (shouldOpenWebInspector):
16590         (createLayoutTestController):
16591         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
16592         (DumpRenderTreeChrome::createView):
16593         (DumpRenderTreeChrome::createWebInspectorView):
16594         (DumpRenderTreeChrome::removeWebInspectorView):
16595         (DumpRenderTreeChrome::waitInspectorLoadFinished):
16596         (DumpRenderTreeChrome::onInspectorViewCreate):
16597         (DumpRenderTreeChrome::onInspectorViewClose):
16598         (DumpRenderTreeChrome::onInspectorFrameLoadFinished):
16599         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
16600         (DumpRenderTreeChrome):
16601         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
16602         (onConsoleMessage):
16603         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
16604         (LayoutTestController::showWebInspector):
16605         (LayoutTestController::closeWebInspector):
16606         (LayoutTestController::evaluateInWebInspector):
16607
16608 2012-07-18  Simon Hausmann  <simon.hausmann@nokia.com>
16609
16610         [ANGLE] On QT, use Bison and Flex during ANGLE build
16611         https://bugs.webkit.org/show_bug.cgi?id=91108
16612
16613         Reviewed by Kenneth Rohde Christiansen.
16614
16615         * qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow
16616         generating not only for SOURCES but also ANGLE_SOURCES (in this bug)
16617
16618 2012-07-18  Balazs Kelemen  <kbalazs@webkit.org>
16619
16620         [Qt] plugin tests should not be disabled for WebKit1
16621         https://bugs.webkit.org/show_bug.cgi?id=91604
16622
16623         Reviewed by Simon Hausmann.
16624
16625         Instead of not building TestNetscapePlugIn, we could programatically
16626         disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
16627         has been solved, so we can still test plugins on WebKit1.
16628
16629         * Tools.pro:
16630         * WebKitTestRunner/TestController.cpp:
16631         (WTR::TestController::initialize):
16632         * WebKitTestRunner/qt/TestControllerQt.cpp:
16633         (WTR::TestController::initializeTestPluginDirectory):
16634
16635 2012-07-18  Mario Sanchez Prada  <msanchez@igalia.com>
16636
16637         [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
16638         https://bugs.webkit.org/show_bug.cgi?id=89223
16639
16640         Reviewed by Chris Fleizach.
16641
16642         Implemented AccessibilityUIElement in WKTR for GTK, based in the
16643         implementation present in DumpRenderTree.
16644
16645         Added new files in gtk/ and updated the cross-platform ones.
16646
16647         * WebKitTestRunner/GNUmakefile.am:
16648         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
16649         (WTR):
16650         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
16651         (AccessibilityUIElement):
16652         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp: Added.
16653         (WTR):
16654         (WTR::attributeSetToString):
16655         (WTR::checkElementState):
16656         (WTR::indexRangeInTable):
16657         (WTR::alterCurrentValue):
16658         (WTR::AccessibilityUIElement::AccessibilityUIElement):
16659         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
16660         (WTR::AccessibilityUIElement::isEqual):
16661         (WTR::AccessibilityUIElement::getChildren):
16662         (WTR::AccessibilityUIElement::getChildrenWithRange):
16663         (WTR::AccessibilityUIElement::childrenCount):
16664         (WTR::AccessibilityUIElement::elementAtPoint):
16665         (WTR::AccessibilityUIElement::indexOfChild):
16666         (WTR::AccessibilityUIElement::childAtIndex):
16667         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
16668         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
16669         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
16670         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
16671         (WTR::AccessibilityUIElement::rowAtIndex):
16672         (WTR::AccessibilityUIElement::selectedChildAtIndex):
16673         (WTR::AccessibilityUIElement::selectedChildrenCount):
16674         (WTR::AccessibilityUIElement::selectedRowAtIndex):
16675         (WTR::AccessibilityUIElement::titleUIElement):
16676         (WTR::AccessibilityUIElement::parentElement):
16677         (WTR::AccessibilityUIElement::disclosedByRow):
16678         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
16679         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
16680         (WTR::AccessibilityUIElement::attributesOfChildren):
16681         (WTR::AccessibilityUIElement::allAttributes):
16682         (WTR::AccessibilityUIElement::stringAttributeValue):
16683         (WTR::AccessibilityUIElement::numberAttributeValue):
16684         (WTR::AccessibilityUIElement::uiElementAttributeValue):
16685         (WTR::AccessibilityUIElement::boolAttributeValue):
16686         (WTR::AccessibilityUIElement::isAttributeSettable):
16687         (WTR::AccessibilityUIElement::isAttributeSupported):
16688         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
16689         (WTR::AccessibilityUIElement::role):
16690         (WTR::AccessibilityUIElement::subrole):
16691         (WTR::AccessibilityUIElement::roleDescription):
16692         (WTR::AccessibilityUIElement::title):
16693         (WTR::AccessibilityUIElement::description):
16694         (WTR::AccessibilityUIElement::orientation):
16695         (WTR::AccessibilityUIElement::stringValue):
16696         (WTR::AccessibilityUIElement::language):
16697         (WTR::AccessibilityUIElement::helpText):
16698         (WTR::AccessibilityUIElement::x):
16699         (WTR::AccessibilityUIElement::y):
16700         (WTR::AccessibilityUIElement::width):
16701         (WTR::AccessibilityUIElement::height):
16702         (WTR::AccessibilityUIElement::clickPointX):
16703         (WTR::AccessibilityUIElement::clickPointY):
16704         (WTR::AccessibilityUIElement::intValue):
16705         (WTR::AccessibilityUIElement::minValue):
16706         (WTR::AccessibilityUIElement::maxValue):
16707         (WTR::AccessibilityUIElement::valueDescription):
16708         (WTR::AccessibilityUIElement::insertionPointLineNumber):
16709         (WTR::AccessibilityUIElement::isActionSupported):
16710         (WTR::AccessibilityUIElement::isEnabled):
16711         (WTR::AccessibilityUIElement::isRequired):
16712         (WTR::AccessibilityUIElement::isFocused):
16713         (WTR::AccessibilityUIElement::isSelected):
16714         (WTR::AccessibilityUIElement::isExpanded):
16715         (WTR::AccessibilityUIElement::isChecked):
16716         (WTR::AccessibilityUIElement::hierarchicalLevel):
16717         (WTR::AccessibilityUIElement::speak):
16718         (WTR::AccessibilityUIElement::ariaIsGrabbed):
16719         (WTR::AccessibilityUIElement::ariaDropEffects):
16720         (WTR::AccessibilityUIElement::lineForIndex):
16721         (WTR::AccessibilityUIElement::rangeForLine):
16722         (WTR::AccessibilityUIElement::rangeForPosition):
16723         (WTR::AccessibilityUIElement::boundsForRange):
16724         (WTR::AccessibilityUIElement::stringForRange):
16725         (WTR::AccessibilityUIElement::attributedStringForRange):
16726         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
16727         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
16728         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
16729         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
16730         (WTR::AccessibilityUIElement::attributesOfColumns):
16731         (WTR::AccessibilityUIElement::attributesOfRows):
16732         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
16733         (WTR::AccessibilityUIElement::attributesOfHeader):
16734         (WTR::AccessibilityUIElement::rowCount):
16735         (WTR::AccessibilityUIElement::columnCount):
16736         (WTR::AccessibilityUIElement::indexInTable):
16737         (WTR::AccessibilityUIElement::rowIndexRange):
16738         (WTR::AccessibilityUIElement::columnIndexRange):
16739         (WTR::AccessibilityUIElement::cellForColumnAndRow):
16740         (WTR::AccessibilityUIElement::horizontalScrollbar):
16741         (WTR::AccessibilityUIElement::verticalScrollbar):
16742         (WTR::AccessibilityUIElement::selectedTextRange):
16743         (WTR::AccessibilityUIElement::setSelectedTextRange):
16744         (WTR::AccessibilityUIElement::increment):
16745         (WTR::AccessibilityUIElement::decrement):
16746         (WTR::AccessibilityUIElement::showMenu):
16747         (WTR::AccessibilityUIElement::press):
16748         (WTR::AccessibilityUIElement::setSelectedChild):
16749         (WTR::AccessibilityUIElement::accessibilityValue):
16750         (WTR::AccessibilityUIElement::documentEncoding):
16751         (WTR::AccessibilityUIElement::documentURI):
16752         (WTR::AccessibilityUIElement::url):
16753         (WTR::AccessibilityUIElement::addNotificationListener):
16754         (WTR::AccessibilityUIElement::removeNotificationListener):
16755         (WTR::AccessibilityUIElement::isFocusable):
16756         (WTR::AccessibilityUIElement::isSelectable):
16757         (WTR::AccessibilityUIElement::isMultiSelectable):
16758         (WTR::AccessibilityUIElement::isVisible):
16759         (WTR::AccessibilityUIElement::isOffScreen):
16760         (WTR::AccessibilityUIElement::isCollapsed):
16761         (WTR::AccessibilityUIElement::isIgnored):
16762         (WTR::AccessibilityUIElement::hasPopup):
16763         (WTR::AccessibilityUIElement::takeFocus):
16764         (WTR::AccessibilityUIElement::takeSelection):
16765         (WTR::AccessibilityUIElement::addSelection):
16766         (WTR::AccessibilityUIElement::removeSelection):
16767         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
16768         (WTR::AccessibilityUIElement::textMarkerRangeLength):
16769         (WTR::AccessibilityUIElement::previousTextMarker):
16770         (WTR::AccessibilityUIElement::nextTextMarker):
16771         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
16772         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
16773         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
16774         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
16775         (WTR::AccessibilityUIElement::textMarkerForPoint):
16776         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
16777         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
16778         (WTR::AccessibilityUIElement::indexForTextMarker):
16779         (WTR::AccessibilityUIElement::isTextMarkerValid):
16780         (WTR::AccessibilityUIElement::textMarkerForIndex):
16781
16782         Add documentEncoding and documentURI to AccessibilityUIElement.idl.
16783
16784         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
16785
16786 2012-07-18  Alexis Menard  <alexis.menard@openbossa.org>
16787
16788         [EFL] Build fix in WebKitTestRunner.
16789         https://bugs.webkit.org/show_bug.cgi?id=91567
16790
16791         Reviewed by Kentaro Hara.
16792
16793         sleep() is defined in unistd.h, we need to include it.
16794
16795         * WebKitTestRunner/efl/TestControllerEfl.cpp:
16796
16797 2012-07-18  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
16798
16799         [NRWT] Unreviewed gardening after r122913
16800         https://bugs.webkit.org/show_bug.cgi?id=91601
16801
16802         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
16803         (TrivialMockPort.process_kill_time):
16804
16805 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
16806
16807         [Chromium-Android] Run ref tests together to avoid expensive driver restarts
16808         https://bugs.webkit.org/show_bug.cgi?id=91533
16809
16810         Reviewed by Dirk Pranke.
16811
16812         Though DriverProxy maintains two drivers to support pixel tests and non-pixel tests,
16813         chromium-android uses another way because it can't support multiple drivers.
16814         It restarts the driver when pixel-test mode changes (e.g. when running a ref test after
16815         a normal test in --no-pixel-tests mode). However restarting driver is expensive on
16816         Android (several seconds each time). To reduce the cost, a command line option
16817         '--shard-ref-tests' is added to group ref tests in dedicated shards.
16818         The option is by default enabled on Android.
16819
16820         Will remove the option once DRT supports switching pixel test mode during one run.
16821         (https://bugs.webkit.org/show_bug.cgi?id=91538, https://bugs.webkit.org/show_bug.cgi?id=91539)
16822
16823         * Scripts/webkitpy/layout_tests/controllers/manager.py:
16824         (Manager._shard_tests):
16825         (Manager._shard_in_two):
16826         (Manager._shard_by_directory):
16827         (Manager._run_tests):
16828         * Scripts/webkitpy/layout_tests/controllers/worker.py:
16829         (Worker._update_test_input):
16830         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
16831         (ChromiumAndroidPort.__init__):
16832         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16833         (parse_args):
16834
16835 2012-07-17  Don Olmstead  <don.olmstead@am.sony.com>
16836
16837         NRWT The time before server_process kills DRT should be variable
16838         https://bugs.webkit.org/show_bug.cgi?id=91542
16839
16840         Reviewed by Dirk Pranke.
16841
16842         Added the ability to configure the amount of time
16843         server_process waits before killing the DRT process
16844         during the call to stop.
16845
16846         * Scripts/webkitpy/layout_tests/port/base.py:
16847         (Port.variable.process_kill_time):
16848         * Scripts/webkitpy/layout_tests/port/server_process.py:
16849         (ServerProcess.stop):
16850
16851 2012-07-17  Alexis Menard  <alexis.menard@openbossa.org>
16852
16853         webkitdirs.pm should fallback to uname -m if arch is not present.
16854         https://bugs.webkit.org/show_bug.cgi?id=91543
16855
16856         Reviewed by Martin Robinson.
16857
16858         It seems that coreutils is moving away from the 'arch' command. Archlinux
16859         for example doesn't ship it anymore (coreutils 8.17). We can then fallback
16860         to 'uname -m' to find out the architecture.
16861
16862         * Scripts/webkitdirs.pm:
16863         (determineArchitecture):
16864
16865 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
16866
16867         nrwt: rename printer.print_update to printer.write_update to match metered_stream
16868         https://bugs.webkit.org/show_bug.cgi?id=91557
16869
16870         Reviewed by Ojan Vafai.
16871
16872         Now that all of the printing logic is in printer.py, I want the
16873         public interface to printer to follow the meteredstream
16874         interface where possible. renaming write_update() gets us close.
16875
16876         * Scripts/webkitpy/layout_tests/controllers/manager.py:
16877         (Manager._run_tests):
16878         (Manager._set_up_run):
16879         (Manager.start_servers_with_lock):
16880         (Manager.stop_servers_with_lock):
16881         (Manager._clobber_old_results):
16882         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16883         (run):
16884         * Scripts/webkitpy/layout_tests/views/printing.py:
16885         (Printer.write_update):
16886         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
16887         (Testprinter.test_write_update):
16888
16889 2012-07-17  Tony Chang  <tony@chromium.org>
16890
16891         Fix a bug where optimize-baselines would incorrectly fail to optimize
16892         https://bugs.webkit.org/show_bug.cgi?id=91551
16893
16894         Reviewed by Adam Barth.
16895
16896         In some cases, optimize-baseline would correctly optimize the results, but because
16897         we weren't filtering the virtual ports out of _results_by_port_name, we thought
16898         that we had failed to optimize.
16899
16900         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
16901         (BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
16902         (BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
16903         (BaselineOptimizer.optimize): Filter out virtual ports.
16904         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
16905         (TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
16906         (BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
16907         (BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
16908         (BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
16909         (BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.
16910
16911 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
16912
16913         [Chromium] Add --encode-binary command line option for DRT
16914         https://bugs.webkit.org/show_bug.cgi?id=91532
16915
16916         Reviewed by Adam Barth.
16917
16918         When the option presents, DRT will encode binary output data in base64.
16919         ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
16920         binary data output.
16921
16922         This change is a refactoring to replace the original hard-coded code for Android.
16923
16924         * DumpRenderTree/chromium/DumpRenderTree.cpp:
16925         (main):
16926         * DumpRenderTree/chromium/TestEventPrinter.cpp:
16927         (TestEventPrinter::TestEventPrinter):
16928         (TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
16929         (TestEventPrinter::handleImage):
16930         (TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage
16931         * DumpRenderTree/chromium/TestEventPrinter.h:
16932         (TestEventPrinter):
16933         * DumpRenderTree/chromium/TestShell.cpp:
16934         (TestShell::TestShell):
16935         (TestShell::initialize):
16936         (TestShell::dump):
16937         * DumpRenderTree/chromium/TestShell.h:
16938         (TestShell):
16939         (TestShell::setEncodeBinary):
16940         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags
16941         (ChromiumAndroidPort.__init__):
16942
16943 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
16944
16945         nrwt: move per-test result output into printing.py
16946         https://bugs.webkit.org/show_bug.cgi?id=91465
16947
16948         Reviewed by Ojan Vafai.
16949
16950         This moves the last substantive logging/printing code from the
16951         manager into printing.py. Subsequent patches in this thread can
16952         largely focus on cleaning up printing.py and will leave the rest
16953         of the code alone.
16954
16955         This patch also removes manager.update() and
16956         manager.update_summary(), two routines that were no longer being
16957         used or needed (they have been dead for a long time but I didn't
16958         notice them until now).
16959
16960         * Scripts/webkitpy/layout_tests/controllers/manager.py:
16961         (Manager.results_directory):
16962         (Manager._look_for_new_crash_logs):
16963         (Manager._update_summary_with_result):
16964         * Scripts/webkitpy/layout_tests/views/printing.py:
16965         (Printer.print_finished_test):
16966
16967 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
16968
16969         nrwt: move config-specific logging to printing.py
16970         https://bugs.webkit.org/show_bug.cgi?id=91450
16971
16972         Reviewed by Ojan Vafai.
16973
16974         More refactoring ... this moves the 'config' output to
16975         printing.py.
16976
16977         * Scripts/webkitpy/layout_tests/controllers/manager.py:
16978         (Manager._resize_shards):
16979         (Manager._run_tests):
16980         (Manager._upload_json_files):
16981         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
16982         (ManagerTest.get_options):
16983         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16984         (run):
16985         * Scripts/webkitpy/layout_tests/views/printing.py:
16986         (Printer.print_config):
16987         (Printer.print_workers_and_shards):
16988         (Printer._print_config):
16989         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
16990         (Testprinter.test_fallback_path_in_config):
16991         (Testprinter.test_print_config):
16992
16993 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
16994
16995         nrwt: clean up logging when we're only running one chunk of the tests
16996         https://bugs.webkit.org/show_bug.cgi?id=91447
16997
16998         Reviewed by Ojan Vafai.
16999
17000         Apparently we were creating a 'tests_run.txt' in the results
17001         directory if we were only running one chunk of the tests; after
17002         3+ years of hacking on this code, that was news to me, so I'm
17003         guessing no one uses this. I'm removing this, and changing the
17004         _print_expected calls to debug messages to simplify the
17005         layering.
17006
17007         * Scripts/webkitpy/layout_tests/controllers/manager.py:
17008         (Manager._split_into_chunks_if_necessary):
17009
17010 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
17011
17012         Fix regression in style checker introduced in r122868.
17013         https://bugs.webkit.org/show_bug.cgi?id=91470
17014
17015         Unreviewed, build fix.
17016
17017         * Scripts/webkitpy/style/checkers/cpp.py:
17018         (_FileState.__init__):
17019
17020 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
17021
17022         nrwt: move the bulk of the "expected" output to printing.py
17023         https://bugs.webkit.org/show_bug.cgi?id=91442
17024
17025         Reviewed by Ojan Vafai.
17026
17027         More printing-related refactoring. This moves all of the code
17028         that prints the results we expect to get, but doesn't move a few
17029         dangling printfs (those'll get hit in a later patch).
17030         
17031         No functional changes; covered by existing tests.
17032
17033         * Scripts/webkitpy/layout_tests/controllers/manager.py:
17034         (Manager._split_into_chunks_if_necessary):
17035         (Manager.prepare_lists_and_print_output):
17036         (Manager.print_config):
17037         * Scripts/webkitpy/layout_tests/views/printing.py:
17038         (Printer.print_expected):
17039         (Printer):
17040         (Printer._print_expected_results_of_type):
17041         (Printer._num_digits):
17042         (Printer._print_expected):
17043         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
17044         (Testprinter.test_print_expected):
17045
17046 2012-07-17  Christophe Dumez  <christophe.dumez@intel.com>
17047
17048         [EFL] Replace 0 by NULL in public headers documentation
17049         https://bugs.webkit.org/show_bug.cgi?id=91470
17050
17051         Reviewed by Dirk Pranke.
17052
17053         Fix style checking to properly detect C headers as C
17054         files. Without this change, the style script would
17055         complain if we use NULL (instead of 0 / null) in C
17056         headers.
17057
17058         * Scripts/webkitpy/style/checkers/cpp.py:
17059         (_FileState.__init__):
17060         (_FileState.is_c):
17061         (_FileState.is_c_or_objective_c):
17062
17063 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
17064
17065         [chromium] remove --test-shell support from DRT
17066         https://bugs.webkit.org/show_bug.cgi?id=86927
17067
17068         Reviewed by Adam Barth.
17069
17070         Now no one use --test-shell. All of us use the standard DRT mode.
17071
17072         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed support of --test-shell and --pixel-tests=filename options. (--pixel-tests without '=' is kept for DRT mode.)
17073         (runTest):
17074         (main):
17075         * DumpRenderTree/chromium/TestEventPrinter.cpp:
17076         (TestEventPrinter::TestEventPrinter):
17077         (TestEventPrinter::~TestEventPrinter):
17078         (TestEventPrinter::handleTestHeader):
17079         (TestEventPrinter::handleTimedOut):
17080         (TestEventPrinter::handleTextHeader):
17081         (TestEventPrinter::handleTextFooter):
17082         (TestEventPrinter::handleAudioHeader):
17083         (TestEventPrinter::handleAudioFooter):
17084         (TestEventPrinter::handleImage): Removed the unused filename parameter.
17085         (TestEventPrinter::handleTestFooter):
17086         * DumpRenderTree/chromium/TestEventPrinter.h:
17087         (TestEventPrinter): Made it a concrete class because we have only one implementation.
17088         * DumpRenderTree/chromium/TestShell.cpp:
17089         (TestShell::TestShell):
17090         (TestShell::initialize):
17091         (TestShell::dumpImage):
17092         * DumpRenderTree/chromium/TestShell.h:
17093         (TestParams): Removed pixelFileName field.
17094         (TestShell):
17095
17096 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
17097
17098         remove ChromiumDriver from NRWT
17099         https://bugs.webkit.org/show_bug.cgi?id=88478
17100
17101         Now WebKitDriver has replaced ChromiumDriver since test_shell mode is deperecated.
17102
17103         Reviewed by Dirk Pranke.
17104
17105         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed ChromiumDriver code.
17106         (ChromiumPort._driver_class): Removed. WebKitPort._driver_class() will be used.
17107         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
17108
17109 2012-07-17  No'am Rosenthal  <noam.rosenthal@nokia.com>
17110
17111         Unreviewed. Add QtGraphics, TextureMapper and OpenGL to watchlist.
17112
17113         * Scripts/webkitpy/common/config/watchlist:
17114
17115 2012-07-17  Sheriff Bot  <webkit.review.bot@gmail.com>
17116
17117         Unreviewed, rolling out r122828.
17118         http://trac.webkit.org/changeset/122828
17119         https://bugs.webkit.org/show_bug.cgi?id=91516
17120
17121         DumpRenderTree crashes after printing test results. (Requested
17122         by vsevik on #webkit).
17123
17124         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
17125         (TestInterfaces::TestInterfaces):
17126         (TestInterfaces::~TestInterfaces):
17127         (TestInterfaces::bindTo):
17128         (TestInterfaces::resetAll):
17129         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
17130         (TestInterfaces):
17131         * DumpRenderTree/chromium/TestShell.cpp:
17132         (TestShell::initialize):
17133         (TestShell::createMainWindow):
17134         (TestShell::~TestShell):
17135         (TestShell::resetTestController):
17136         (TestShell::bindJSObjectsToWindow):
17137         * DumpRenderTree/chromium/TestShell.h:
17138         (TestShell::accessibilityController):
17139         (TestShell):
17140
17141 2012-07-17  Gabor Ballabas  <gaborb@inf.u-szeged.hu>
17142
17143         [Qt][V8] Remove the V8 related codepaths and configuration
17144         https://bugs.webkit.org/show_bug.cgi?id=90863
17145
17146         Reviewed by Simon Hausmann.
17147
17148         * Scripts/build-webkit: Remove --v8 option.
17149
17150 2012-07-17  Sheriff Bot  <webkit.review.bot@gmail.com>
17151
17152         Unreviewed, rolling out r122834.
17153         http://trac.webkit.org/changeset/122834
17154         https://bugs.webkit.org/show_bug.cgi?id=91492
17155
17156         it broke the chromium (Requested by kkristof on #webkit).
17157
17158         * Scripts/build-webkit:
17159
17160 2012-07-17  Gabor Ballabas  <gaborb@inf.u-szeged.hu>
17161
17162         [Qt][V8] Remove the V8 related codepaths and configuration
17163         https://bugs.webkit.org/show_bug.cgi?id=90863
17164
17165         Reviewed by Simon Hausmann.
17166
17167         * Scripts/build-webkit: Remove --v8 option.
17168
17169 2012-07-17  Balazs Kelemen  <kbalazs@webkit.org>
17170
17171         [Qt] Add --use-test-fonts option to Minibrowser
17172         https://bugs.webkit.org/show_bug.cgi?id=91402
17173
17174         Reviewed by Tor Arne Vestbø.
17175
17176         Same stuff that already exists for QtTestBrowser.
17177
17178         * MiniBrowser/qt/MiniBrowser.pro:
17179         * MiniBrowser/qt/MiniBrowserApplication.cpp:
17180         (MiniBrowserApplication::handleUserOptions):
17181
17182 2012-07-17  Adam Barth  <abarth@webkit.org>
17183
17184         [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
17185         https://bugs.webkit.org/show_bug.cgi?id=91459
17186
17187         Reviewed by Ryosuke Niwa.
17188
17189         Rather than having TestShell own and bind each of these JavaScript APIs
17190         individually, TestShell should delegate that work to TestInterfaces.
17191         This patch moves AccessibilityController and TextInputController to be
17192         the responsibility of TestInterfaces.
17193
17194         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
17195         (TestInterfaces::TestInterfaces):
17196         (TestInterfaces::~TestInterfaces):
17197         (TestInterfaces::setWebView):
17198         (TestInterfaces::bindTo):
17199         (TestInterfaces::resetAll):
17200         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
17201         (WebKit):
17202         (TestInterfaces):
17203         (TestInterfaces::accessibilityController):
17204         * DumpRenderTree/chromium/TestShell.cpp:
17205         (TestShell::initialize):
17206         (TestShell::createMainWindow):
17207         (TestShell::~TestShell):
17208         (TestShell::resetTestController):
17209         (TestShell::bindJSObjectsToWindow):
17210         * DumpRenderTree/chromium/TestShell.h:
17211         (TestShell::accessibilityController):
17212         (TestShell):
17213
17214 2012-07-17  Adam Barth  <abarth@webkit.org>
17215
17216         [Chromium] Move TextInputController into TestRunner.a
17217         https://bugs.webkit.org/show_bug.cgi?id=91457
17218
17219         Reviewed by Ryosuke Niwa.
17220
17221         This patch is purely moving code. TextInputController is one of the
17222         objects exposed to JavaScript and so should be in the TestRunner
17223         library.
17224
17225         * DumpRenderTree/DumpRenderTree.gypi:
17226         * DumpRenderTree/chromium/TestRunner/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TextInputController.cpp.
17227         * DumpRenderTree/chromium/TestRunner/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TextInputController.h.
17228
17229 2012-07-17  Adam Barth  <abarth@webkit.org>
17230
17231         [Chromium] TextInputController shouldn't know about TestShell
17232         https://bugs.webkit.org/show_bug.cgi?id=91455
17233
17234         Reviewed by Kent Tamura.
17235
17236         This patch uses the same pattern we used for the
17237         AccessibilityController to remove the dependency on TestShell.
17238
17239         * DumpRenderTree/chromium/TestShell.cpp:
17240         (TestShell::initialize):
17241         (TestShell::createMainWindow):
17242         (TestShell::~TestShell):
17243         * DumpRenderTree/chromium/TextInputController.cpp:
17244         (TextInputController::TextInputController):
17245         (TextInputController::insertText):
17246         (TextInputController::doCommand):
17247         (TextInputController::setMarkedText):
17248         (TextInputController::unmarkText):
17249         (TextInputController::hasMarkedText):
17250         (TextInputController::markedRange):
17251         (TextInputController::selectedRange):
17252         (TextInputController::firstRectForCharacterRange):
17253         (TextInputController::validAttributesForMarkedText):
17254         (TextInputController::setComposition):
17255         * DumpRenderTree/chromium/TextInputController.h:
17256         (WebKit):
17257         (TextInputController):
17258         (TextInputController::setWebView):
17259
17260 2012-07-17  David Barr  <davidbarr@chromium.org>
17261
17262         Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
17263         https://bugs.webkit.org/show_bug.cgi?id=89055
17264
17265         Reviewed by Kent Tamura.
17266
17267         The css3-images module is at candidate recommendation.
17268         http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
17269
17270         Add a configuration option for CSS image-orientation support, disabling it by default.
17271
17272         * Scripts/webkitperl/FeatureList.pm:
17273         * qmake/mkspecs/features/features.pri:
17274
17275 2012-07-16  Adam Barth  <abarth@webkit.org>
17276
17277         [Chromium] Move Task.(cpp|h) into TestRunner.a
17278         https://bugs.webkit.org/show_bug.cgi?id=91446
17279
17280         Reviewed by Ryosuke Niwa.
17281
17282         Task is a dependency of EventSender, which needs to move into TestRunner.a.
17283
17284         * DumpRenderTree/DumpRenderTree.gypi:
17285         * DumpRenderTree/chromium/TestRunner/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/Task.cpp.
17286         * DumpRenderTree/chromium/TestRunner/Task.h: Renamed from Tools/DumpRenderTree/chromium/Task.h.
17287
17288 2012-07-16  Adam Barth  <abarth@webkit.org>
17289
17290         [Chromium] Move AccessibilityController and AccessibilityUIElement into TestRunner.a
17291         https://bugs.webkit.org/show_bug.cgi?id=91443
17292
17293         Reviewed by Tony Chang.
17294
17295         Purely a file move (and a sorting of #includes).
17296
17297         * DumpRenderTree/DumpRenderTree.gypi:
17298         * DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.cpp.
17299         * DumpRenderTree/chromium/TestRunner/AccessibilityController.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.h.
17300         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.cpp.
17301         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.h.
17302
17303 2012-07-16  Adam Barth  <abarth@webkit.org>
17304
17305         [Chromium] AccessibilityController shouldn't know anything about TestShell
17306         https://bugs.webkit.org/show_bug.cgi?id=91441
17307
17308         Reviewed by Tony Chang.
17309
17310         This patch is a precursor to moving AccessibilityController.cpp into TestRunner.a.
17311
17312         * DumpRenderTree/chromium/AccessibilityController.cpp:
17313         (AccessibilityController::AccessibilityController):
17314         (AccessibilityController::getFocusedElement):
17315         (AccessibilityController::getRootElement):
17316         * DumpRenderTree/chromium/AccessibilityController.h:
17317         (WebKit):
17318         (AccessibilityController):
17319         (AccessibilityController::setWebView):
17320         * DumpRenderTree/chromium/TestShell.cpp:
17321         (TestShell::initialize):
17322         (TestShell::createMainWindow):
17323         (TestShell::~TestShell):
17324
17325 2012-07-16  Adam Barth  <abarth@webkit.org>
17326
17327         [Chromium] Introduce TestInterfaces to hold all the JavaScript interfaces needed for LayoutTests
17328         https://bugs.webkit.org/show_bug.cgi?id=91312
17329
17330         Reviewed by Ryosuke Niwa.
17331
17332         Looking forward to moving more objects into TestRunner.a, we're going
17333         to need an object to own all the interfaces and to put them through
17334         their lifecycle.
17335
17336         * DumpRenderTree/DumpRenderTree.gypi:
17337         * DumpRenderTree/chromium/TestShell.cpp:
17338         (TestShell::initialize):
17339         (TestShell::resetTestController):
17340         (TestShell::bindJSObjectsToWindow):
17341         * DumpRenderTree/chromium/TestShell.h:
17342         (TestShell):
17343         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: Added.
17344         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h: Added.
17345
17346 2012-07-16  Ryuan Choi  <ryuan.choi@samsung.com>
17347
17348         [EFL][WK2] Add APIs to support theme.
17349         https://bugs.webkit.org/show_bug.cgi?id=90107
17350
17351         Reviewed by Hajime Morita.
17352
17353         Override default theme path for MiniBrowser and WebKitTestRunner.
17354
17355         * MiniBrowser/efl/CMakeLists.txt:
17356         * MiniBrowser/efl/main.c:
17357         (browserCreate):
17358         * WebKitTestRunner/PlatformEfl.cmake:
17359         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
17360         (WTR::PlatformWebView::PlatformWebView):
17361
17362 2012-07-16  Ryuan Choi  <ryuan.choi@samsung.com>
17363
17364         [EFL][DRT] Implement dumpFrameScrollPosition
17365         https://bugs.webkit.org/show_bug.cgi?id=87638
17366
17367         Reviewed by Hajime Morita.
17368
17369         * DumpRenderTree/efl/DumpRenderTree.cpp:
17370         (dumpFrameScrollPosition): Implemented.
17371         (shouldDumpFrameScrollPosition): Fixed wrong condition like other ports.
17372
17373 2012-07-16  Don Olmstead  <don.olmstead@am.sony.com>
17374
17375         NRWRT Should provide a VS project to work on
17376         https://bugs.webkit.org/show_bug.cgi?id=91436
17377
17378         Reviewed by Dirk Pranke.
17379
17380         Adding VS2010 project for modifying webkitpy. Uses pytools
17381         <http://pytools.codeplex.com> which integrates python into 
17382         Visual Studio.
17383
17384         * Scripts/webkitpy/webkitpy.pyproj: Added.
17385         * Scripts/webkitpy/webkitpy.sln: Added.
17386
17387 2012-07-16  Adam Barth  <abarth@webkit.org>
17388
17389         [Chromium] Move GamepadController into TestRunner.a
17390         https://bugs.webkit.org/show_bug.cgi?id=91311
17391
17392         Reviewed by Tony Chang.
17393
17394         GamepadController looks like a simple class to move into TestRunner.a
17395         because it has almost zero dependence on TestShell.
17396
17397         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
17398         * DumpRenderTree/DumpRenderTree.gypi:
17399         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.cpp.
17400         * DumpRenderTree/chromium/TestRunner/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.h.
17401         * DumpRenderTree/chromium/TestRunner/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/CppVariant.cpp.
17402         * DumpRenderTree/chromium/TestRunner/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/CppVariant.h.
17403             - GamepadController depends on these bindings helpers.
17404         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/GamepadController.cpp.
17405         * DumpRenderTree/chromium/TestRunner/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/GamepadController.h.
17406             - Just moved these files and removed the unused TestShell
17407               references.
17408         * DumpRenderTree/chromium/TestRunner/Stub.cpp: Removed.
17409             - No longer needed.
17410         * DumpRenderTree/chromium/TestShell.cpp:
17411             - Update call to constructor to avoid passing in this.
17412
17413 2012-07-16  Xianzhu Wang  <wangxianzhu@chromium.org>
17414
17415         [Chromium-android] Don't use test_shell mode of DRT
17416         https://bugs.webkit.org/show_bug.cgi?id=88542
17417
17418         Reviewed by Dirk Pranke.
17419
17420         Test shell mode is about to be removed.
17421         Switch to use DRT mode for chromium-android.
17422
17423         Summary of changes:
17424         1. ChromiumAndroidDriver now inherits from WebKitDriver instead of ChromiumDriver (to be deprecated).
17425         2. Conforms to the DRT mode protocol for input/output of DumpRenderTree.
17426         3. Added support for Android 'adb shell' input/output (base64, newline mode, etc.)
17427
17428         * DumpRenderTree/chromium/TestEventPrinter.cpp:
17429         (DRTPrinter::handleImage): Outputs base64 on Android.
17430         * DumpRenderTree/chromium/TestShellAndroid.cpp:
17431         (platformInit): Changed err_file to err_fifo, required by python ServerProcess.
17432         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
17433         (ChromiumAndroidPort.__init__):
17434         (ChromiumAndroidPort.create_driver): Override to create driver without DriverProxy to ensure 1 Driver per run.
17435         (ChromiumAndroidDriver):
17436         (ChromiumAndroidDriver.__init__):
17437         (ChromiumAndroidDriver.cmd_line):
17438         (ChromiumAndroidDriver._deadlock_detector):
17439         (ChromiumAndroidDriver._drt_cmd_line):
17440         (ChromiumAndroidDriver.start):
17441         (ChromiumAndroidDriver._start):
17442         (ChromiumAndroidDriver._start_once):
17443         (ChromiumAndroidDriver.run_test):
17444         (ChromiumAndroidDriver.stop):
17445         (ChromiumAndroidDriver._command_from_driver_input):
17446         (ChromiumAndroidDriver._read_prompt):
17447         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
17448         (ChromiumAndroidPortTest.test_driver_cmd_line):
17449         (ChromiumAndroidDriverTest.test_cmd_line):
17450         (ChromiumAndroidDriverTest):
17451         (ChromiumAndroidDriverTest.test_drt_cmd_line):
17452         (ChromiumAndroidDriverTest.test_read_prompt):
17453         (ChromiumAndroidDriverTest.test_command_from_driver_input):
17454         (ChromiumAndroidDriverTest.test_write_command_and_read_line):
17455         * Scripts/webkitpy/layout_tests/port/server_process.py:
17456         (ServerProcess.__init__): Added universal_newlines to handle Android 'adb shell' line ends.
17457         (ServerProcess._start):
17458         (ServerProcess._wait_for_data_and_update_buffers_using_select): Handles unexpected EOF which indicates crash on Android.
17459         (ServerProcess.stop): Added kill_directly parameter to kill the process without waiting it (which always timeouts for Android).
17460         (ServerProcess.replace_outputs): Added to combine different input/output pipes into one ServerProcess.
17461         * Scripts/webkitpy/layout_tests/port/webkit.py:
17462         (WebKitDriver._command_from_driver_input):
17463         (WebKitDriver.run_test): Changed timeout origin so that slow start() on Android won't cause timeout of layout test case.
17464         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
17465         (MockServerProcess.read_stdout):
17466         (MockServerProcess.start):
17467         (MockServerProcess):
17468         (MockServerProcess.stop):
17469         (MockServerProcess.kill):
17470         (WebKitDriverTest.test_read_block):
17471         (WebKitDriverTest.test_read_binary_block):
17472         (WebKitDriverTest.test_read_base64_block):
17473
17474 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
17475
17476         nrwt: move a bunch of printing code from manager.py to printing.py
17477         https://bugs.webkit.org/show_bug.cgi?id=91439
17478
17479         Reviewed by Ojan Vafai.
17480
17481         All of the logic that handles what gets logged should eventually
17482         live in printing.py; this patch moves a large chunk of code that
17483         prints all of the stuff after the run completes.
17484
17485         There are no functional changes, this is just moving code
17486         around. Covered by existing tests (updated as necessary).
17487
17488         This code is all pretty messy and most of it should be deleted
17489         (or extracted after the fact from results.json), but I'm saving
17490         that for further patches. My goal is just to manager.py to a
17491         more manageable state.
17492
17493         * Scripts/webkitpy/layout_tests/controllers/manager.py:
17494         (Manager.prepare_lists_and_print_output):
17495         (Manager.run):
17496         (Manager._mark_interrupted_tests_as_skipped):
17497         (Manager._update_summary_with_result):
17498         (Manager._num_digits):
17499         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
17500         (ManagerTest.test_interrupt_if_at_failure_limits):
17501         (ResultSummaryTest.summarized_results):
17502         * Scripts/webkitpy/layout_tests/models/result_summary.py:
17503         (ResultSummary.__init__):
17504         (ResultSummary.add):
17505         Here we had to add a list of the slow tests to the result
17506         summary so that we didn't need to call back into the manager and
17507         the test expectations object to figure out if a test is SLOW.
17508         * Scripts/webkitpy/layout_tests/views/printing.py:
17509         (Printer.print_results):
17510         (Printer):
17511         (Printer._print_timing_statistics):
17512         (Printer._print_aggregate_test_statistics):
17513         (Printer._print_individual_test_times):
17514         (Printer._print_test_list_timing):
17515         (Printer._print_directory_timings):
17516         (Printer._print_statistics_for_test_timings):
17517         (Printer._print_result_summary):
17518         (Printer._print_result_summary_entry):
17519         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
17520         (Testprinter.test_print_unexpected_results.get_unexpected_results):
17521         (Testprinter):
17522
17523 2012-07-16  Adam Barth  <abarth@webkit.org>
17524
17525         [Chromium] Create a stub TestRunner.a target
17526         https://bugs.webkit.org/show_bug.cgi?id=91309
17527
17528         Reviewed by Ryosuke Niwa.
17529
17530         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
17531         * DumpRenderTree/DumpRenderTree.gypi:
17532         * DumpRenderTree/chromium/TestRunner/Stub.cpp: Added.
17533
17534 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
17535
17536         test-webkitpy: clean up logging to make it ninja-esque
17537         https://bugs.webkit.org/show_bug.cgi?id=91297
17538
17539         Reviewed by Adam Barth.
17540
17541         This patch changes the output of test-webkitpy to be closer to
17542         what ninja produces. Namely:
17543
17544         If you are running with stderr writing to a tty (and not -v), we
17545         will no longer print '...' as tests complete. Instead, we use a
17546         metered stream and print entries of the form:
17547            '[X/Y] test_name passed/failed/erred'
17548         where X is the current test # and Y is the total number of tests.
17549
17550         If you are running with stderr piped to a file or other non-tty
17551         object (or with -v), you get the same output, one per line for
17552         every test.
17553
17554         In addition, if tests fail or err out, you get the stack trace
17555         immediately; you don't have to wait until the end of the run.
17556
17557         Lastly, this change cleans up the unit tests for test-webkitpy
17558         itself to not confuse the logger and to work cleanly w/ multiple
17559         processes. It looks like between this and all the clean up in
17560         MessagePool that happened as it landed, we can now run
17561         multiprocessing tests in parallel.
17562
17563         * Scripts/webkitpy/test/finder.py:
17564         (Finder._default_names):
17565         * Scripts/webkitpy/test/finder_unittest.py:
17566         (FinderTest.setUp):
17567         (FinderTest.tearDown):
17568         * Scripts/webkitpy/test/printer.py:
17569         (Printer.__init__):
17570         (Printer.configure):
17571         (Printer.print_started_test):
17572         (Printer.print_finished_test):
17573         (Printer._test_line):
17574         (Printer.print_result):
17575         * Scripts/webkitpy/test/runner.py:
17576         (Runner.run):
17577         * Scripts/webkitpy/test/runner_unittest.py:
17578         (RunnerTest.setUp):
17579         (RunnerTest):
17580         (RunnerTest.tearDown):
17581         (RunnerTest.assert_run):
17582         (RunnerTest.test_regular):
17583         (RunnerTest.test_verbose):
17584         (RunnerTest.test_timing):
17585
17586 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
17587
17588         test-webkitpy: handle failures properly when running in parallel
17589         https://bugs.webkit.org/show_bug.cgi?id=91416
17590
17591         Reviewed by Adam Barth.
17592
17593         It turns out that unittest.TestResults contain a handle to the
17594         test method itself, which isn't picklable; it's sufficient to just
17595         store the test name instead of the actual method. By doing so
17596         we can move the test_name() method from the printer to the
17597         runner where it belongs (so the printer is less dependent on the
17598         unittest framework's data structures).
17599
17600         This change should really have a test but I don't know how to
17601         write one that properly captures the behavior and won't cause
17602         test-webkitpy itself to fail. I've verified the fix by hand, at
17603         least, in the meantime.
17604
17605         * Scripts/webkitpy/test/printer.py:
17606         (Printer.__init__):
17607         (Printer.print_result):
17608         * Scripts/webkitpy/test/runner.py:
17609         (_test_name):
17610         (Runner.all_test_names):
17611         (_Worker.handle):
17612
17613 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
17614
17615         test-webkitpy: handle failures properly when running in parallel
17616         https://bugs.webkit.org/show_bug.cgi?id=91416
17617
17618         Reviewed by Tony Chang.
17619
17620         It turns out that unittest.TestResults contain a handle to the
17621         test method itself, which isn't picklable; it's sufficient to just
17622         store the test name instead of the actual method. By doing so
17623         we can move the test_name() method from the printer to the
17624         runner where it belongs (so the printer is less dependent on the
17625         unittest framework's data structures).
17626
17627         This change should really have a test but I don't know how to
17628         write one that properly captures the behavior and won't cause
17629         test-webkitpy itself to fail. I've verified the fix by hand, at
17630         least, in the meantime.
17631
17632         * Scripts/webkitpy/test/printer.py:
17633         (Printer.__init__):
17634         (Printer.print_result):
17635         * Scripts/webkitpy/test/runner.py:
17636         (_test_name):
17637         (Runner.all_test_names):
17638         (_Worker.handle):
17639
17640 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
17641
17642         test-webkitpy: run tests in parallel
17643         https://bugs.webkit.org/show_bug.cgi?id=91294
17644
17645         Reviewed by Ojan Vafai.
17646
17647         This change adds support for running tests in parallel. This is
17648         not yet on by default, since the logging isn't very pretty w/
17649         parallel tests.
17650
17651         Also, there are some (multiprocessing-related) tests that can't be
17652         run in parallel and so we skip them in that situation; I need to
17653         come up with a mechanism for dealing with this, since you
17654         apparently can't use multiprocessing as both a parent and a
17655         child process.
17656
17657         * Scripts/webkitpy/test/finder.py:
17658         (Finder.find_names):
17659         (Finder._default_names):
17660         * Scripts/webkitpy/test/main.py:
17661         (Tester._parse_args):
17662         (Tester.run):
17663         * Scripts/webkitpy/test/main_unittest.py:
17664         (TesterTest.test_no_tests_found):
17665         * Scripts/webkitpy/test/runner.py:
17666         (Runner.run):
17667         * Scripts/webkitpy/test/runner_unittest.py:
17668         (RunnerTest.test_regular):
17669         (RunnerTest.test_verbose):
17670         (RunnerTest.test_timing):
17671
17672 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
17673
17674         test-webkitpy: use message pools
17675         https://bugs.webkit.org/show_bug.cgi?id=91292
17676
17677         Reviewed by Ojan Vafai.
17678
17679         Restructure the test-running code to be message-driven and
17680         use a MessagePool; note that this does not yet actually run the
17681         tests in parallel.
17682
17683         Also clean up the unit tests so that the fake loader is passed
17684         to the _Worker properly, and reduce a lot of the cut&pasted code
17685         in the tests.
17686
17687         No functional changes; covered by existing tests.
17688
17689         * Scripts/webkitpy/test/printer.py:
17690         (Printer.print_started_test):
17691         (Printer.print_finished_test):
17692         * Scripts/webkitpy/test/runner.py:
17693         (Runner.__init__):
17694         (Runner.run):
17695         (Runner.handle):
17696         (_Worker):
17697         (_Worker.__init__):
17698         (_Worker.handle):
17699         * Scripts/webkitpy/test/runner_unittest.py:
17700         (RunnerTest.assert_run):
17701         (RunnerTest.test_regular):
17702         (RunnerTest.test_verbose):
17703         (RunnerTest.test_timing):
17704
17705 2012-07-16  Simon Hausmann  <simon.hausmann@nokia.com>
17706
17707         [Qt] Fix Qt5 module dependencies
17708         https://bugs.webkit.org/show_bug.cgi?id=91388
17709
17710         Reviewed by Laszlo Gombos.
17711
17712         Removed ancient qtscript and qtxmlpatterns module dependencies.
17713
17714         * qmake/qt_webkit.pri:
17715
17716 2012-07-16  Thiago Marcos P. Santos  <thiago.santos@intel.com>
17717
17718         run-webkit-test returns 254 at exit even when it succeeds
17719         https://bugs.webkit.org/show_bug.cgi?id=91370
17720
17721         Reviewed by Simon Hausmann.
17722
17723         sys.exit() is implemented by raising SystemExit which inherits from
17724         BaseException. Since we are catching BaseException, run_webkit_tests.py
17725         was always returning an error code.
17726
17727         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17728
17729 2012-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
17730
17731         Unreviewed. Fix make distcheck.
17732
17733         * GNUmakefile.am: Add missing file to compilation.
17734
17735 2012-07-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
17736
17737         Unreviewed. Add EFLWebKit2PublicAPI, EFLWebKit2PlatformSpecific to watch list.
17738
17739         * Scripts/webkitpy/common/config/watchlist:
17740
17741 2012-07-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
17742
17743         Unreviewed. Add gyuyoung.kim@samsung.com to watch list.
17744
17745         * Scripts/webkitpy/common/config/watchlist:
17746
17747 2012-07-15  Joseph Pecoraro  <pecoraro@apple.com>
17748
17749         Windowless WebView not firing JavaScript load event if there is a media element
17750         https://bugs.webkit.org/show_bug.cgi?id=91331
17751
17752         Reviewed by Eric Carlson.
17753
17754         Test a windowless WebView loading a page with a media element. The load
17755         event should happen on the next spin of the run loop, but we spin check
17756         the page, with a timeout of 250ms.
17757
17758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17759         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.html: Added.
17760         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm: Added.
17761         (-[WindowlessWebViewWithMediaFrameLoadDelegate webView:didFinishLoadForFrame:]):
17762         (TestWebKitAPI::spinLoop): Spin check with timeout. Runs a block each spin to early bail.
17763         (TestWebKitAPI::TEST):
17764
17765 2012-07-14  Benjamin Poulain  <bpoulain@apple.com>
17766
17767         [Mac] Do not try to update the cache model for every WebPreferences change
17768         https://bugs.webkit.org/show_bug.cgi?id=91302
17769
17770         Reviewed by Joseph Pecoraro.
17771
17772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17773         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
17774         (TestWebKitAPI):
17775         (TestWebKitAPI::TEST):
17776
17777 2012-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
17778
17779         Unreviewed, rolling out r122665.
17780         http://trac.webkit.org/changeset/122665
17781         https://bugs.webkit.org/show_bug.cgi?id=91321
17782
17783         Broke Mac builds (Requested by rniwa on #webkit).
17784
17785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17786         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Removed.
17787
17788 2012-07-13  Benjamin Poulain  <bpoulain@apple.com>
17789
17790         [Mac] Do not try to update the cache model for every WebPreferences change
17791         https://bugs.webkit.org/show_bug.cgi?id=91302
17792
17793         Reviewed by Joseph Pecoraro.
17794
17795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17796         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
17797         (TestWebKitAPI):
17798         (TestWebKitAPI::TEST):
17799
17800 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
17801
17802         run-webkit-test outputs the wrong number of tests executed when some are skipped.
17803         https://bugs.webkit.org/show_bug.cgi?id=89894
17804
17805         Reviewed by Ojan Vafai.
17806
17807         Fix the logging of the actual number of tests run so that tests
17808         that are skipped aren't included.
17809
17810         Also revamp the 'expected' output so we distinguish the number
17811         of tests found from the number of tests run (to account for
17812         --repeat-each and --iterations).
17813
17814         Covered by existing tests.
17815
17816         * Scripts/webkitpy/layout_tests/controllers/manager.py:
17817         (Manager.prepare_lists_and_print_output):
17818         (Manager._log_num_workers):
17819         (Manager.run):
17820         (Manager._print_result_summary):
17821         * Scripts/webkitpy/layout_tests/models/result_summary.py:
17822         (ResultSummary.__init__):
17823         (ResultSummary.add):
17824         * Scripts/webkitpy/layout_tests/views/printing.py:
17825         (Printer.print_one_line_summary):
17826         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
17827         (Testprinter.test_print_one_line_summary):
17828
17829 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
17830
17831         nrwt: actually print the exception name and message for otherwise unhandled exceptions
17832         https://bugs.webkit.org/show_bug.cgi?id=91305
17833
17834         Reviewed by Adam Barth.
17835
17836         Two more places where I was printing the stack trace but not the
17837         exception itself :(. These two spots can't easily be
17838         unit-tested, but I tested them by hand.
17839
17840         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17841         (run):
17842         (main):
17843
17844 2012-07-13  Josh Hawn  <jhawn@apple.com>
17845
17846         Fix for WebContext::getWebCoreStatistics() causes crash if no m_process
17847         https://bugs.webkit.org/show_bug.cgi?id=91116
17848
17849         Reviewed by Simon Fraser.
17850
17851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17852             Added new test file.
17853         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Added.
17854         (TestWebKitAPI::wkContextGetStatisticsCallback):
17855             Tests that callback function receives an error.
17856         (TestWebKitAPI::TEST):
17857             Creates a dummy web context object (no web process).
17858             Calls WKContextGetStatistics with the web context and test callback.
17859             The test callback should get an expected error.
17860
17861 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
17862
17863         test-webkitpy: move printing-related code out of the runner
17864         https://bugs.webkit.org/show_bug.cgi?id=91289
17865
17866         Reviewed by Ryosuke Niwa.
17867
17868         More refactoring ... this moves all printing-related stuff out
17869         of runner.py and into printer.py.
17870
17871         No functional changes; covered by existing tests.
17872
17873         * Scripts/webkitpy/test/main.py:
17874         (Tester._run_tests):
17875         * Scripts/webkitpy/test/printer.py:
17876         (Printer.__init__):
17877         (Printer):
17878         (Printer.test_name):
17879         (Printer.print_started_test):
17880         (Printer.print_finished_test):
17881         (Printer.print_result):
17882         * Scripts/webkitpy/test/runner.py:
17883         (Runner.__init__):
17884         (Runner.all_test_names):
17885         (Runner.run):
17886         * Scripts/webkitpy/test/runner_unittest.py:
17887         (RunnerTest.test_regular):
17888         (RunnerTest.test_verbose):
17889         (RunnerTest.test_timing):
17890
17891 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
17892
17893         webkitpy: split printing/logging code for test-webkitpy out into a new class
17894         https://bugs.webkit.org/show_bug.cgi?id=91282
17895
17896         Reviewed by Ojan Vafai.
17897
17898         This patch is the first step at splitting all of the
17899         printing/logging code out separately from the actual
17900         test-running code.
17901
17902         This is just moving stuff around; no new functionality and no
17903         new tests needed.
17904
17905         * Scripts/webkitpy/test/finder_unittest.py:
17906         (FinderTest.setUp):
17907         * Scripts/webkitpy/test/main.py:
17908         (Tester.__init__):
17909         (Tester._parse_args):
17910         (Tester.run):
17911         (Tester._run_tests):
17912         (Tester._log_exception):
17913         * Scripts/webkitpy/test/main_unittest.py:
17914         (TesterTest.test_no_tests_found):
17915         * Scripts/webkitpy/test/printer.py: Added.
17916         (Printer):
17917         (Printer.__init__):
17918         (Printer.configure):
17919         (Printer.configure.filter):
17920         (_CaptureAndPassThroughStream):
17921         (_CaptureAndPassThroughStream.__init__):
17922         (_CaptureAndPassThroughStream.write):
17923         (_CaptureAndPassThroughStream._message_is_from_pdb):
17924         (_CaptureAndPassThroughStream.flush):
17925         (_CaptureAndPassThroughStream.getvalue):
17926
17927 2012-07-13  James Simonsen  <simonjam@chromium.org>
17928
17929         [Navigation Timing] Imported W3C tests contain duplicates and are DOS formatted
17930         https://bugs.webkit.org/show_bug.cgi?id=91184
17931
17932         Reviewed by Adam Barth.
17933
17934         The upstream 'html5' tests are just duplicates of the 'html' tests.
17935
17936         * Scripts/import-w3c-performance-wg-tests:
17937
17938 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
17939
17940         webkitpy: hide yield_to_caller from callers in MessagePool :)
17941         https://bugs.webkit.org/show_bug.cgi?id=91269
17942
17943         Reviewed by Adam Barth.
17944
17945         yield_to_caller() was an optimization/hack to allow us to run
17946         both manager and worker in a single process/loop without
17947         starving the manager while the worker is running tests. The
17948         worker was required to call yield_to_caller() periodically. It
17949         turns out that I can get equivalent responsiveness by yielding
17950         inside the MessagePool every time the worker posts a message, and this
17951         allows me to no longer need the worker to call the routine. Thus
17952         I rename yield_to_caller() to _yield_to_manager() to be a little
17953         clearer about its purpose.
17954
17955         Tested by existing tests.
17956
17957         * Scripts/webkitpy/common/message_pool.py:
17958         (_Worker.run):
17959         (_Worker.post):
17960         (_Worker._yield_to_manager):
17961         * Scripts/webkitpy/layout_tests/controllers/worker.py:
17962         (Worker.handle):
17963
17964 2012-07-13  Adam Barth  <abarth@webkit.org>
17965
17966         EWSTools should be able to build a commit-queue instance from scratch
17967         https://bugs.webkit.org/show_bug.cgi?id=91264
17968
17969         Reviewed by Eric Seidel.
17970
17971         I've been using this script to build commit-queue instances on Google
17972         Compute Engine and it seems to work.
17973
17974         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Added.
17975
17976 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
17977
17978         webkitpy: make worker.start() and worker.stop() optional in the messagepool
17979         https://bugs.webkit.org/show_bug.cgi?id=91170
17980
17981         Reviewed by Ojan Vafai.
17982
17983         test-webkitpy will use messagepool workers that don't actually
17984         have any per-worker state, so they don't need start() and stop()
17985         methods. Now we will only call the methods if they exist; this
17986         means that workers only need to expose a handle() method.
17987
17988         * Scripts/webkitpy/common/message_pool.py:
17989         (_Worker.terminate):
17990         (_Worker.run):
17991
17992 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
17993
17994         NRWT doesn't print exceptions
17995         https://bugs.webkit.org/show_bug.cgi?id=91129
17996
17997         Reviewed by Ojan Vafai.
17998
17999         Although we printed exceptions in most cases, if an unexpected
18000         exception (like a runtime error) was raised when creating a
18001         port, we wouldn't. This patch fixes that, and also cleans up
18002         how we were logging exceptions from the workers to be less
18003         verbose.
18004
18005         Because of the corner cases where these errors are occurring,
18006         it's difficult to write automated unit tests for them. I've
18007         tested it quite a bit by hand, though.
18008
18009         * Scripts/webkitpy/common/message_pool.py:
18010         (_MessagePool._close):
18011         (_MessagePool._handle_worker_exception):
18012         (_Worker.run):
18013         (_Worker._raise):
18014         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18015         (Manager._run_tests):
18016         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18017         (main):
18018
18019 2012-07-13  Wei James  <james.wei@intel.com>
18020
18021         enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
18022         https://bugs.webkit.org/show_bug.cgi?id=91194
18023
18024         Reviewed by Adam Barth.
18025
18026         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
18027
18028 2012-07-13  Simon Pena  <spena@igalia.com>
18029
18030         [GTK] Gardening: update API tests skipped list
18031         https://bugs.webkit.org/show_bug.cgi?id=91224
18032
18033         Unreviewed gardening.
18034
18035         Skip "next" and "previous" tests of FindController until bug #91083
18036         is fixed.
18037
18038         * gtk/run-api-tests:
18039         (TestRunner):
18040
18041 2012-07-13  Zeno Albisser  <zeno@webkit.org>
18042
18043         [Qt][WK2] Implement GraphicsSurface for Linux/GLX.
18044         https://bugs.webkit.org/show_bug.cgi?id=90881
18045
18046         Enable GraphicsSurface for Linux based platforms
18047         whenever the Xcomposite extension is available.
18048
18049         Reviewed by Noam Rosenthal.
18050
18051         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Added.
18052         (main):
18053         * qmake/config.tests/libXcomposite/libXcomposite.pro: Added.
18054           Add a configure test to detect Xcomposite extension and
18055           activate GraphicsSurface on linux in case the extension is available.
18056         * qmake/configure.pri:
18057         * qmake/mkspecs/features/features.prf:
18058
18059 2012-07-13  David Grogan  <dgrogan@chromium.org>
18060
18061         nrwt: don't choke when printing invalid utf-8 to stderr
18062         https://bugs.webkit.org/show_bug.cgi?id=91181
18063
18064         Reviewed by Dirk Pranke.
18065
18066         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
18067         (TestResultWriter.write_stderr):
18068
18069 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
18070
18071         test-webkitpy: more class renaming cleanup
18072         https://bugs.webkit.org/show_bug.cgi?id=91182
18073
18074         Reviewed by Adam Barth.
18075
18076         More removing of the unnecessary "Test" prefix.
18077
18078         * Scripts/webkitpy/test/finder.py:
18079         (_DirectoryTree):
18080         (Finder.add_tree):
18081         * Scripts/webkitpy/test/main.py:
18082         (Tester._run_tests):
18083         * Scripts/webkitpy/test/runner.py:
18084         (Runner):
18085         * Scripts/webkitpy/test/runner_unittest.py:
18086         (RunnerTest.test_regular):
18087         (RunnerTest.test_verbose):
18088         (RunnerTest.test_timing):
18089
18090 2012-07-12  Christophe Dumez  <christophe.dumez@intel.com>
18091
18092         [WK2][EFL] Facilitate debugging of the Web Process
18093         https://bugs.webkit.org/show_bug.cgi?id=90768
18094
18095         Reviewed by Kenneth Rohde Christiansen.
18096
18097         Add a new --webprocess-cmd-prefix argument to
18098         run-webkit-tests script for EFL port. If provided,
18099         the prefix will be prepended to the command used
18100         to spawn the Web process. This can be used for
18101         debugging purposes with prefixes such as:
18102         "xterm -title renderer -e gdb --args".
18103
18104         * Scripts/webkitpy/layout_tests/port/efl.py:
18105         (EflPort.__init__):
18106         (EflPort.setup_environ_for_server):
18107         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18108         (parse_args):
18109         * WebKitTestRunner/efl/TestControllerEfl.cpp:
18110         (WTR::TestController::platformRunUntil): Implement support for
18111         m_noTimeout timeout value.
18112
18113 2012-07-12  Adam Barth  <abarth@webkit.org>
18114
18115         Fix crash in the commit-queue.  We need to initialize self.port during __init__.
18116
18117         * Scripts/webkitpy/tool/commands/queues.py:
18118         (CommitQueue.__init__):
18119         (CommitQueue.begin_work_queue):
18120
18121 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
18122
18123         test-webkitpy: rename test_finder to finder
18124         https://bugs.webkit.org/show_bug.cgi?id=91175
18125
18126         Reviewed by Adam Barth.
18127
18128         Rename test_finder -> finder, TestFinder -> Finder to remove
18129         some of the stutter in the names.
18130
18131         * Scripts/webkitpy/test/finder.py: Renamed from Tools/Scripts/webkitpy/test/test_finder.py.
18132         * Scripts/webkitpy/test/finder_unittest.py: Renamed from Tools/Scripts/webkitpy/test/test_finder_unittest.py.
18133         * Scripts/webkitpy/test/main.py:
18134         (Tester.__init__):
18135
18136 2012-07-12  Adam Barth  <abarth@webkit.org>
18137
18138         CommitQueue is confused about what port it is using
18139         https://bugs.webkit.org/show_bug.cgi?id=91040
18140
18141         Reviewed by Dirk Pranke.
18142
18143         On EC2, we explicitly pass --port to the commit-queue, but that
18144         requires editing the start-queue.sh script locally on each bot. In
18145         moving to Google Compute Engine, we're try to avoid any local edits to
18146         the EWSTools.
18147
18148         Rather than passing --port to the commit-queue, this patch teaches the
18149         CommitQueue which port its running, which is the approach we use for
18150         the EWS bots.
18151
18152         Mutating tool._deprecated_port is a bit ugly, but it's what we're doing
18153         currently for the EWS bots.
18154
18155         * Scripts/webkitpy/tool/commands/queues.py:
18156         (CommitQueue):
18157         (CommitQueue.begin_work_queue):
18158         (CommitQueue.run_command):
18159         * Scripts/webkitpy/tool/commands/queues_unittest.py:
18160         (CommitQueueTest.test_commit_queue):
18161         (mock_run_webkit_patch):
18162         (test_rollout):
18163         (test_rollout_lands):
18164         (test_manual_reject_during_processing):
18165
18166 2012-07-12  James Simonsen  <simonjam@chromium.org>
18167
18168         [Navigation Timing] Import the W3C Navigation Timing test suite
18169         https://bugs.webkit.org/show_bug.cgi?id=84887
18170
18171         Reviewed by Tony Gentilcore.
18172
18173         * Scripts/import-w3c-performance-wg-tests: Added.
18174
18175 2012-07-12  Adam Barth  <abarth@webkit.org>
18176
18177         Unreviewed.  Nit: git config files use tabs, not spaces.
18178
18179         * EWSTools/cold-boot.sh:
18180
18181 2012-07-12  Kwang Yul Seo  <skyul@company100.net>
18182
18183         Unreviewed. Add Dongsung Huang to the list of contributors. He
18184         has submitted over 30 patches on texture mapper, canvas and image decoders.
18185
18186         * Scripts/webkitpy/common/config/committers.py:
18187
18188 2012-07-12  Kwang Yul Seo  <skyul@company100.net>
18189
18190         Unreviewed. Change my irc nickname to kseo.
18191
18192         * Scripts/webkitpy/common/config/committers.py:
18193
18194 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
18195
18196         webkitpy: clean up logging handlers, lint common.message_pool
18197         https://bugs.webkit.org/show_bug.cgi?id=91152
18198
18199         Reviewed by Ojan Vafai.
18200
18201         The unix implementation of multiprocessing clones any logging
18202         handlers from the parent process into the child; we currently
18203         don't want this behavior in our code, so I was hand-removing the
18204         installed handlers in the child process I knew about. After thinking
18205         about it further, I think it was simpler and safe enough to just
18206         remove all handlers in the child, since the message pool
18207         propagates any message from the child back into the parent.
18208         
18209         We can always change this in the future if it turns out to be an issue.
18210
18211         I'm also fixing a couple of other lint warnings while I'm at it.
18212
18213         * Scripts/webkitpy/common/message_pool.py:
18214         (_MessagePool.__exit__):
18215         (_MessagePool._handle_worker_exception):
18216         (_Worker._set_up_logging):
18217
18218 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
18219
18220         webkitpy: rename manager_worker_broker to message_pool
18221         https://bugs.webkit.org/show_bug.cgi?id=91145
18222
18223         Reviewed by Ojan Vafai.
18224
18225         Since the MessagePool interface is more generic (and simpler)
18226         now and will be reused by test-webkitpy, I'm renaming it and
18227         moving it to webkitpy.common.
18228
18229         * Scripts/webkitpy/common/message_pool.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py.
18230         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18231         (TestRunInterruptedException.__reduce__):
18232         (Manager._run_tests.worker_factory):
18233         (Manager._run_tests):
18234         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
18235
18236 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
18237
18238         nrwt crashes saving the output for a platform-specific expected test reference
18239         https://bugs.webkit.org/show_bug.cgi?id=90872
18240
18241         Reviewed by Ojan Vafai.
18242
18243         The expected output for a test is copied alongside the test
18244         itself in the layout-test-results directory; in other words, for
18245         foo/bar-expected.txt sits alongside foo/bar.html even if we're
18246         actually using platform/mac/foo/bar-expected.txt.
18247
18248         Unless the test is a reftest, in which case we would copy the
18249         output to platform/mac/foo/bar-expected.html and set a
18250         'ref_file' parameter in results.json to indicate the path. This
18251         can be useful in the cases where we have multiple references for
18252         a single test or when multiple tests share the same reference.
18253
18254         We found a bug where we weren't creating platform/mac/foo under
18255         the results directory, and so this wasn't actually working.
18256         However, treating reftests differently seems like a bad thing,
18257         so we should probably be consistent. This change puts the
18258         -expected.html next to the test, and reworks test_result_writer
18259         so that we create directories uniformly and consistently.
18260
18261         Note that we weren't catching this problem in unit tests because
18262         the MockFileSystem creates a directory automatically if it
18263         doesn't exist; this was done intentionally for convenience, but
18264         is really a bug and should be fixed; see https://bugs.webkit.org/show_bug.cgi?id=91028.
18265
18266         I have not added additional tests here since fixing that bug
18267         should be sufficient.
18268
18269         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18270         (interpret_test_failures):
18271         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
18272         (ResultSummaryTest.test_interpret_test_failures):
18273         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
18274         (write_test_result):
18275         (TestResultWriter._write_binary_file):
18276         (TestResultWriter):
18277         (TestResultWriter._write_text_file):
18278         (TestResultWriter.write_output_files):
18279         (TestResultWriter.write_stderr):
18280         (TestResultWriter.write_crash_log):
18281         (TestResultWriter.create_text_diff_and_write_result):
18282         (TestResultWriter.write_image_diff_files):
18283         (write_reftest):
18284         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
18285         (EndToEndTest.test_reftest_with_two_notrefs):
18286
18287 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
18288
18289         nrwt: reimplement manager_worker_broker in a much simpler form
18290         https://bugs.webkit.org/show_bug.cgi?id=90513
18291
18292         Reviewed by Ojan Vafai.
18293
18294         This is a wholesale replacement of the MessagePool() implementation
18295         and the other classes in manager_worker_broker.py. All of the
18296         BrokerConnection*, Broker*, etc. classes are gone, and there are now
18297         just a MessagePool class and a _Worker class. Happiness ensues.
18298  
18299         I'm removing manager_worker_broker_unittest.py as well; we get
18300         nearly complete coverage from the integration tests, and will
18301         get more coverage when test-webkitpy moves to use this as well,
18302         so having unit tests seems like unnecessary overhead. (running
18303         coverage numbers with test-webkitpy shows that pretty much the only
18304         uncovered lines are lines that are only run in the child processes,
18305         which coverage doesn't handle at the moment).
18306  
18307         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
18308         (_MessagePool.__init__):
18309         (_MessagePool.run):
18310         (_MessagePool._start_workers):
18311         (_MessagePool):
18312         (_MessagePool.wait):
18313         (_MessagePool._close):
18314         (_MessagePool._handle_done):
18315         (_MessagePool._can_pickle):
18316         (_MessagePool._loop):
18317         (WorkerException):
18318         (_Message.__init__):
18319         (_Message.__repr__):
18320         (_Worker):
18321         (_Worker.__init__):
18322         (_Worker.terminate):
18323         (_Worker._close):
18324         (_Worker.run):
18325         (_Worker.post):
18326         (_Worker.yield_to_caller):
18327         (_Worker._post):
18328         (_Worker._raise):
18329         (_Worker._set_up_logging):
18330         (_WorkerLogHandler.__init__):
18331         (_WorkerLogHandler.emit):
18332         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Removed.
18333
18334 2012-07-12  Tony Chang  <tony@chromium.org>
18335
18336         [chromium] Remove drag and drop API methods that are no longer used
18337         https://bugs.webkit.org/show_bug.cgi?id=90996
18338
18339         Reviewed by Adam Barth.
18340
18341         Migrate DRT to use the methods that take modifier keys.
18342
18343         * DumpRenderTree/chromium/EventSender.cpp:
18344         (EventSender::doDragDrop):
18345         (EventSender::doMouseUp):
18346         (EventSender::doMouseMove):
18347         (EventSender::beginDragWithFiles):
18348
18349 2012-07-12  Ojan Vafai  <ojan@chromium.org>
18350
18351         Allow putting ranges in user.py list prompts
18352         https://bugs.webkit.org/show_bug.cgi?id=91115
18353
18354         Reviewed by Adam Barth.
18355
18356         Ranges are inclusive and denoted by a dash. This is useful for rebaselining a whole port
18357         since the items are listed with each port's builders being contiguous.
18358
18359         * Scripts/webkitpy/common/system/user.py:
18360         (User._wait_on_list_response):
18361         * Scripts/webkitpy/common/system/user_unittest.py:
18362         (UserTest.test_prompt_with_multiple_lists.run_prompt_test):
18363         (UserTest.test_prompt_with_multiple_lists):
18364
18365 2012-07-12  Arnaud Renevier  <arno@renevier.net>
18366
18367         [GTK] Implement disableImageLoading in DRT
18368         https://bugs.webkit.org/show_bug.cgi?id=87973
18369
18370         Reviewed by Martin Robinson.
18371
18372         * DumpRenderTree/gtk/DumpRenderTree.cpp:
18373         (resetDefaultsToConsistentValues):
18374         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
18375         (LayoutTestController::disableImageLoading):
18376
18377 2012-07-12  Simon Hausmann  <simon.hausmann@nokia.com>
18378
18379         [Qt] Internal symbols are exported on Linux
18380         https://bugs.webkit.org/show_bug.cgi?id=90981
18381
18382         Reviewed by Jocelyn Turcotte.
18383
18384         I should've re-enabled ELF symbol visibility when removing the symbol map in
18385         r106650.
18386
18387         * qmake/mkspecs/features/default_post.prf:
18388
18389 2012-07-11  Mark Rowe  <mrowe@apple.com>
18390
18391         <http://webkit.org/b/91024> Build against the latest SDK when targeting older OS X versions.
18392
18393         Reviewed by Dan Bernstein.
18394
18395         The deployment target is already set to the version that we're targeting, and it's that setting
18396         which determines which functionality from the SDK is available to us.
18397
18398         * DumpRenderTree/mac/Configurations/Base.xcconfig:
18399         * TestWebKitAPI/Configurations/Base.xcconfig:
18400         * WebKitTestRunner/Configurations/Base.xcconfig:
18401
18402 2012-07-11  Mark Rowe  <mrowe@apple.com>
18403
18404         Replace definitions of BUILDING_ON / TARGETING macros with macros that will error when used.
18405
18406         Part of <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros.
18407
18408         Reviewed by Anders Carlsson.
18409
18410         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Remove the macros completely from here since
18411         they're completely unused in TestNetscapePlugIn.
18412         * DumpRenderTree/config.h:
18413
18414 2012-07-11  Mark Rowe  <mrowe@apple.com>
18415
18416         <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros
18417
18418         This removal was handled by a script that translates the relevant macros in to the equivalent checks
18419         using the system availability macros.
18420
18421         Reviewed by Filip Pizlo.
18422
18423         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
18424         * DumpRenderTree/mac/CheckedMalloc.cpp:
18425         * DumpRenderTree/mac/DumpRenderTree.mm:
18426         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
18427         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
18428         * DumpRenderTree/mac/TextInputController.m:
18429         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
18430         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
18431         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
18432
18433 2012-07-11  Robert Kroeger  <rjkroege@chromium.org>
18434
18435         Suppress horizontal conversion of PlatformWheelEvents when hasPreciseScrollingDeltas is true
18436         https://bugs.webkit.org/show_bug.cgi?id=89580
18437
18438         WebKit GTK and Chromium Linux force vertical wheel events to
18439         scroll horizontally when over horizontal scroll bars.  This is
18440         undesirable for touchpad scrolling with
18441         hasPreciseScrollingDeltas() == true. Modified DumpRenderTree to
18442         let a layout test specify this attribute so that the change's impact
18443         on scrolling can be tested in a layout test.
18444
18445         Reviewed by Adam Barth.
18446
18447         * DumpRenderTree/chromium/EventSender.cpp:
18448         (EventSender::handleMouseWheel):
18449
18450 2012-07-11  Simon Fraser  <simon.fraser@apple.com>
18451
18452         Fix the build by declaring -isPaginated before use.
18453
18454         * MiniBrowser/mac/BrowserWindowController.m:
18455
18456 2012-07-11  Sheriff Bot  <webkit.review.bot@gmail.com>
18457
18458         Unreviewed, rolling out r122358.
18459         http://trac.webkit.org/changeset/122358
18460         https://bugs.webkit.org/show_bug.cgi?id=91037
18461
18462         Build break on WebKit Win (Requested by hayato on #webkit).
18463
18464         * DumpRenderTree/chromium/EventSender.cpp:
18465         (EventSender::doDragDrop):
18466         (EventSender::doMouseUp):
18467         (EventSender::doMouseMove):
18468         (EventSender::beginDragWithFiles):
18469
18470 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
18471
18472         nrwt: add a MessagePool abstraction that the manager will call to replace the broker
18473         https://bugs.webkit.org/show_bug.cgi?id=90511
18474
18475         Reviewed by Ojan Vafai.
18476
18477         This change introduces the new MessagePool abstraction that will
18478         replace the classes in manager_worker_broker. It is a minimal
18479         interface that tries to follow the conventions in
18480         multiprocessing.Pool and concurrency.futures ... it provides a
18481         context manager and a run() method that sends N messages to M
18482         workers processes (starting workers as necessary) and waits for
18483         them all to complete, handling cleanup as necessary. The caller
18484         is responsible for providing a handle() method to handle
18485         messages received from the workers.
18486         
18487         This interface basically hides all of the multiprocessing logic from
18488         the manager class.
18489
18490         The initial implementation of MessagePool is a simple shim
18491         around the existing broker classes; a subsequent change will
18492         replace all the other classes with a much simpler
18493         implementation.
18494
18495         No additional tests are provided for now; existing tests should
18496         provide adequate coverage, and I will add new unit tests for the
18497         MessagePool class when I replace the existing implementation.
18498
18499         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18500         (TestRunInterruptedException.__reduce__):
18501         (Manager.__init__):
18502         (Manager._run_tests):
18503         (Manager._run_tests.instead):
18504         (Manager.handle):
18505         (Manager._handle_started_test):
18506         (Manager._handle_finished_test_list):
18507         (Manager._handle_finished_test):
18508         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
18509         (get):
18510         (_MessagePool):
18511         (_MessagePool.__init__):
18512         (_MessagePool.__enter__):
18513         (_MessagePool.__exit__):
18514         (_MessagePool.run):
18515         (_MessagePool.wait):
18516         (_MessagePool.is_done):
18517         (_MessagePool._worker_is_done):
18518         (_MessagePool._close):
18519         (_MessagePool.handle_done):
18520         (_MessagePool.handle_started_test):
18521         (_MessagePool.handle_finished_test):
18522         (_MessagePool.handle_finished_test_list):
18523         (_MessagePool.handle_exception):
18524         (_MessagePool._log_messages):
18525         (_MessagePool._handle_worker_exception):
18526         (_WorkerState):
18527         (_WorkerState.for):
18528         (_WorkerState.__init__):
18529         (_WorkerState.__repr__):
18530         (_get_broker):
18531         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
18532         (make_broker):
18533
18534 2012-07-11  Simon Fraser  <simon.fraser@apple.com>
18535
18536         Add an option to enter paginated mode in MiniBrowser
18537         https://bugs.webkit.org/show_bug.cgi?id=91035
18538
18539         Reviewed by Dan Bernstein.
18540
18541         Add an item to the Debug menu for MiniBrowser that puts
18542         the web view into paginated mode. For now, we only
18543         do left-to-right pagination, with a fixed column width.
18544
18545         * MiniBrowser/mac/BrowserWindowController.h:
18546         * MiniBrowser/mac/BrowserWindowController.m:
18547         (-[BrowserWindowController validateMenuItem:]): Update the checked
18548         state of the menu item.
18549         (-[BrowserWindowController isPaginated]): Return YES if paginated.
18550         (-[BrowserWindowController togglePaginationMode:]): Toggle in
18551         and out of pagination mode.
18552         * MiniBrowser/mac/MainMenu.xib: Add the debug menu item.
18553
18554 2012-07-11  Adam Barth  <abarth@webkit.org>
18555
18556         commit-queue instances on Compute Engine are missing git-svn
18557         https://bugs.webkit.org/show_bug.cgi?id=91034
18558
18559         Reviewed by Eric Seidel.
18560
18561         git-svn is needed to actually commit to SVN from a git working copy.
18562
18563         * EWSTools/cold-boot.sh:
18564
18565 2012-07-11  Dirk Pranke  <dpranke@chromium.org>
18566
18567         webkitpy: lint code in webkitpy.layout_tests.models
18568         https://bugs.webkit.org/show_bug.cgi?id=90416
18569
18570         Reviewed by Ojan Vafai.
18571
18572         Cleaning up errors reported from lint-webkitpy.
18573
18574         Also, suppress the warnings about wildcard imports in pylintrc;
18575         we have nothing particularly against them.
18576
18577         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
18578         (TestConfigurationConverter.combinations):
18579         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
18580         (TestConfigurationTest.test_hash.query_unknown_key):
18581         (TestConfigurationTest.test_eq):
18582         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
18583         (ParseError.__init__):
18584         (TestExpectationLine.__init__):
18585         (TestExpectationsModel.get_expectations_string):
18586         (TestExpectationsModel):
18587         (TestExpectationsModel.expectation_to_string):
18588         (TestExpectationsModel.add_expectation_line):
18589         (TestExpectationsModel._clear_expectations_for_test):
18590         (TestExpectationsModel._remove_from_sets):
18591         (TestExpectations.get_expectations_string):
18592         (TestExpectations.expectation_to_string):
18593         (TestExpectations._report_warnings):
18594         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
18595         (Base.__init__):
18596         (parse_exp):
18597         (SkippedTests.check):
18598         (TestExpectationParserTests.test_parse_empty_string):
18599         * Scripts/webkitpy/layout_tests/models/test_failures.py:
18600         (FailureTimeout.__init__):
18601         (FailureCrash.__init__):
18602         (FailureImageHashMismatch.__init__):
18603         (FailureReftestMismatch.__init__):
18604         (FailureReftestMismatchDidNotOccur.__init__):
18605         (FailureReftestNoImagesGenerated.__init__):
18606         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
18607         (TestFailuresTest.test_unknown_failure_type.UnknownFailure.message):
18608         (TestFailuresTest.test_unknown_failure_type):
18609         (TestFailuresTest):
18610         (TestFailuresTest.test_message_is_virtual):
18611         * Scripts/webkitpy/layout_tests/models/test_results.py:
18612         (TestResult.loads):
18613         (TestResult.has_failure_matching_types):
18614         * Scripts/webkitpy/pylintrc:
18615
18616 2012-07-11  Dirk Pranke  <dpranke@chromium.org>
18617
18618         nrwt: clean up names in worker.py
18619         https://bugs.webkit.org/show_bug.cgi?id=90510
18620
18621         Reviewed by Ojan Vafai.
18622
18623         This is the last patch in the series of refactoring worker.py;
18624         all this does is change some names of methods, instance
18625         variables, and method parameters to be clearer (it also changes
18626         some code in manager.py and manager_worker.py to be consistent).
18627
18628         There are no functional changes in this patch and the existing
18629         tests should cover everything.
18630
18631         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18632         (Manager.__init__):
18633         (Manager.prepare_lists_and_print_output):
18634         (Manager._run_tests.worker_factory):
18635         (Manager._run_tests):
18636         (Manager._show_results_html_file):
18637         (Manager.handle_finished_test_list):
18638         (_WorkerState.__init__):
18639         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
18640         (_Broker.post_message):
18641         (_Broker._dispatch_message):
18642         (AbstractWorker.__init__):
18643         (AbstractWorker.run):
18644         (AbstractWorker.yield_to_caller):
18645         (AbstractWorker.post):
18646         (_WorkerConnection.__init__):
18647         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
18648         (_TestWorker.__init__):
18649         (_TestWorker.start):
18650         (_TestWorker.handle):
18651         (_TestWorker.stop):
18652         (_TestsMixin):
18653         (_TestsMixin.test_name):
18654         * Scripts/webkitpy/layout_tests/controllers/worker.py:
18655         (Worker.__init__):
18656         (Worker.__del__):
18657         (Worker.start):
18658         (Worker.handle):
18659         (Worker._run_test):
18660         (Worker.stop):
18661         (Worker._timeout):
18662         (Worker._kill_driver):
18663         (Worker._run_test_with_timeout):
18664         (Worker._clean_up_after_test):
18665         (Worker._run_test_in_another_thread.SingleTestThread.run):
18666         (Worker._run_test_in_this_thread):
18667         (Worker._run_single_test):
18668
18669 2012-07-11  Adam Barth  <abarth@webkit.org>
18670
18671         The commit-queue needs some extra git config to be able to commit
18672         https://bugs.webkit.org/show_bug.cgi?id=91025
18673
18674         Reviewed by Eric Seidel.
18675
18676         In order for the commit-queue to actually commit, it needs to know the
18677         location of the SVN server.
18678
18679         * EWSTools/cold-boot.sh:
18680
18681 2012-07-11  Adam Barth  <abarth@webkit.org>
18682
18683         Teach EWSTools how to configure SVN auth credentials
18684         https://bugs.webkit.org/show_bug.cgi?id=91021
18685
18686         Reviewed by Eric Seidel.
18687
18688         To move the commit-queue over to Google Compute Engine, we need a way
18689         to configure the commit-queue's credentials during the machine build
18690         process. There doesn't seem to be a nice command line way of
18691         configuring SVN auth credentials. I tried doing a bogus commit and
18692         supplying the credentials that way, but that's super hacky.
18693
18694         The approach in this patch is to write the config file directly. The
18695         format of these configurations files is documented in the SVN book, so
18696         this approach doesn't see too sketchy.
18697
18698         * EWSTools/configure-svn-auth.sh: Added.
18699
18700 2012-07-11  Ojan Vafai  <ojan@chromium.org>
18701
18702         Dedupe suffixes passed to webkit-patch rebaseline
18703         https://bugs.webkit.org/show_bug.cgi?id=91017
18704
18705         Reviewed by Dirk Pranke.
18706
18707         * Scripts/webkitpy/tool/commands/rebaseline.py:
18708         (Rebaseline._suffixes_to_update):
18709         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
18710         (test_rebaseline_multiple_builders_and_tests_command_line):
18711
18712 2012-07-11  Kevin Ollivier  <kevino@theolliviers.com>
18713
18714         [wx] Unreviewed build fix. Add new directories and a new LayoutTestController method.
18715
18716         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
18717         (LayoutTestController::setStorageDatabaseIdleInterval):
18718         * waf/build/settings.py:
18719
18720 2012-07-11  Tony Chang  <tony@chromium.org>
18721
18722         [chromium] Remove drag and drop API methods that are no longer used
18723         https://bugs.webkit.org/show_bug.cgi?id=90996
18724
18725         Reviewed by Adam Barth.
18726
18727         Migrate DRT to use the methods that take modifier keys.
18728
18729         * DumpRenderTree/chromium/EventSender.cpp:
18730         (EventSender::doDragDrop):
18731         (EventSender::doMouseUp):
18732         (EventSender::doMouseMove):
18733         (EventSender::beginDragWithFiles):
18734
18735 2012-07-11  Mark Rowe  <mrowe@apple.com>
18736
18737         Add a Mountain Lion version of libWebKitSystemInterface.a.
18738
18739         Reviewed by John Sullivan.
18740
18741         * Scripts/copy-webkitlibraries-to-product-directory: Include libWebKitSystemInterfaceMountainLion.a in the list of libraries to copy.
18742
18743 2012-07-09  Mark Rowe  <mrowe@apple.com>
18744
18745         <http://webkit.org/b/90835> Teach bisect-builds to work with a Safari.app that has entitlements.
18746
18747         Reviewed by Dan Bernstein.
18748
18749         * Scripts/bisect-builds: Use safariPathFromSafariBundle to determine which binary within the application
18750         should be invoked.
18751
18752 2012-07-11  Zan Dobersek  <zandobersek@gmail.com>
18753
18754         [Gtk] fast/events/keydown-function-keys.html is failing
18755         https://bugs.webkit.org/show_bug.cgi?id=90891
18756
18757         Reviewed by Martin Robinson.
18758
18759         Work around the context menu being shown on F10 key being pressed by
18760         unbiding the key when running tests in DumpRenderTree. The problem
18761         appears when using a recent version of the xkeyboard-config package.
18762
18763         * DumpRenderTree/gtk/DumpRenderTree.cpp:
18764         (setDefaultsToConsistentStateValuesForTesting):
18765
18766 2012-07-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
18767
18768         [Qt] QRawWebView should notify when rendering is done, so that pixel results can be grabbed at the appropriate moment.
18769         https://bugs.webkit.org/show_bug.cgi?id=90641
18770
18771         Reviewed by Jocelyn Turcotte.
18772
18773         * MiniBrowser/qt/raw/View.h: Comment used old class name (WKView).
18774         (View):
18775
18776 2012-07-11  Min Qin  <qinmin@chromium.org>
18777
18778         [Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
18779         https://bugs.webkit.org/show_bug.cgi?id=90831
18780
18781         Reviewed by Adam Barth.
18782
18783         On android, DRT needs to run in a background thread to avoid ANR.
18784         However, the java tests are running on UI thread by default.
18785         We need to send an intent extra to the apk so that it can run on a sub thread.
18786
18787         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
18788         (ChromiumAndroidDriver._start_once):
18789
18790 2012-07-11  Csaba Osztrogonác  <ossy@webkit.org>
18791
18792         [Qt] REGRESSION(r107171): Fix --timeout option of Qt's DRT
18793         https://bugs.webkit.org/show_bug.cgi?id=90966
18794
18795         Reviewed by Ryosuke Niwa.
18796
18797         * DumpRenderTree/qt/main.cpp:
18798         (main): Don't remove the argument, because takeOptionValue() did it before.
18799
18800 2012-07-11  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
18801
18802         First commit; moving myself to commiters.
18803
18804         Unreviewed.
18805
18806         * Scripts/webkitpy/common/config/committers.py:
18807
18808 2012-07-11  Balazs Ankes  <bank@inf.u-szeged.hu>
18809
18810         webkit-patch land should automatically add svn:mime-type for .png files
18811         https://bugs.webkit.org/show_bug.cgi?id=75825
18812
18813         Reviewed by Dirk Pranke.
18814
18815         Refactor the png.py to avoid code duplication.
18816
18817         * Scripts/webkitpy/common/checksvnconfigfile.py: Added.
18818         (check):
18819         (config_file_path):
18820         (errorstr_autoprop):
18821         (errorstr_png):
18822         * Scripts/webkitpy/style/checkers/png.py:
18823         (PNGChecker.check):
18824         * Scripts/webkitpy/tool/commands/download.py:
18825         (Land):
18826         * Scripts/webkitpy/tool/steps/__init__.py:
18827         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
18828         (AddSvnMimetypeForPng):
18829         (AddSvnMimetypeForPng.__init__):
18830         (AddSvnMimetypeForPng.run):
18831         (AddSvnMimetypeForPng._check_pngs):
18832         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
18833         (MockSCMDetector):
18834         (MockSCMDetector.__init__):
18835         (MockSCMDetector.display_name):
18836         (AddSvnMimetypeForPngTest):
18837         (AddSvnMimetypeForPngTest.test_run):
18838
18839 2012-07-11  Hayato Ito  <hayato@chromium.org>
18840
18841         Unreviewed gardening.
18842         One more fix for r122292.
18843
18844         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
18845
18846 2012-07-11  Sheriff Bot  <webkit.review.bot@gmail.com>
18847
18848         Unreviewed, rolling out r122301.
18849         http://trac.webkit.org/changeset/122301
18850         https://bugs.webkit.org/show_bug.cgi?id=90947
18851
18852         Android builder started to fail (Requested by hayato on
18853         #webkit).
18854
18855         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
18856
18857 2012-07-10  Adam Barth  <abarth@webkit.org>
18858
18859         [Chromium] Merge final nits to DumpRenderTree.gyp for Android
18860         https://bugs.webkit.org/show_bug.cgi?id=90920
18861
18862         Reviewed by Tony Chang.
18863
18864         This patch contains the last few small changes to DumpRenderTree.gyp
18865         from the chromium-android branch. After this change, this file will be
18866         fully merged.
18867
18868         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
18869
18870 2012-07-10  Adam Barth  <abarth@webkit.org>
18871
18872         [Chromium-Android] Add apk test targets for webkit_unit_tests and TestWebKitAPI
18873         https://bugs.webkit.org/show_bug.cgi?id=90918
18874
18875         Reviewed by Tony Chang.
18876
18877         The rules are similar to what we have added for DumpRenderTree apk.
18878         All references to gtest_target_type can be removed once we enable APK
18879         tests on the all bots.
18880
18881         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
18882
18883 2012-07-10  Kenneth Russell  <kbr@google.com>
18884
18885         Add --no-build option to perf test runner
18886         https://bugs.webkit.org/show_bug.cgi?id=90916
18887
18888         Reviewed by Ryosuke Niwa.
18889
18890         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
18891         (PerfTestsRunner._parse_args):
18892             Support --no-build option to perf tests, as in layout tests.
18893
18894 2012-07-10  Adam Barth  <abarth@webkit.org>
18895
18896         EWSTools should be able to build a chromium-ews bot from scratch
18897         https://bugs.webkit.org/show_bug.cgi?id=90912
18898
18899         Reviewed by Eric Seidel.
18900
18901         I've been using this script to kick off the build process for the
18902         chromium-ews bots on Google Compute Engine.
18903
18904         * EWSTools/GoogleComputeEngine: Added.
18905         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Added.
18906
18907 2012-07-10  Alec Flett  <alecflett@chromium.org>
18908
18909         Add alecflett to the list of committers
18910         https://bugs.webkit.org/show_bug.cgi?id=90903
18911
18912         Reviewed by Ojan Vafai.
18913
18914         * Scripts/webkitpy/common/config/committers.py:
18915
18916 2012-07-10  Xianzhu Wang  <wangxianzhu@chromium.org>
18917
18918         Unreviewed fix of webkitpy unittest break about chromium_android.py
18919         caused by r122251.
18920
18921         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
18922         (ChromiumAndroidDriverTest.test_cmd_line):
18923
18924 2012-07-10  Ojan Vafai  <ojan@chromium.org>
18925
18926         webkit-patch rebaseline doesn't work for audio/pixel tests
18927         https://bugs.webkit.org/show_bug.cgi?id=90905
18928
18929         Reviewed by Adam Barth.
18930
18931         We just need to pass the correct suffix list to rebaseline-test-internal
18932         and optimize-baselines. By default, pass all suffixes.
18933
18934         * Scripts/webkitpy/tool/commands/rebaseline.py:
18935         (Rebaseline):
18936         (Rebaseline.__init__):
18937         (Rebaseline._suffixes_to_update):
18938         (Rebaseline.execute):
18939         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
18940         (test_rebaseline_multiple_builders_and_tests_command_line):
18941
18942 2012-07-10  Adam Barth  <abarth@webkit.org>
18943
18944         Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
18945         https://bugs.webkit.org/show_bug.cgi?id=90853
18946
18947         Reviewed by Eric Seidel.
18948
18949         WebKit no longer implements the Hixie76 version of the WebSocket
18950         protocol. We don't need to support it in our test framework.
18951
18952         * DumpRenderTree/chromium/LayoutTestController.cpp:
18953         (LayoutTestController::overridePreference):
18954         * DumpRenderTree/chromium/WebPreferences.cpp:
18955         (WebPreferences::reset):
18956         (WebPreferences::applyTo):
18957         * DumpRenderTree/chromium/WebPreferences.h:
18958         (WebPreferences):
18959         * DumpRenderTree/gtk/DumpRenderTree.cpp:
18960         (resetDefaultsToConsistentValues):
18961         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
18962         (LayoutTestController::overridePreference):
18963         * DumpRenderTree/mac/DumpRenderTree.mm:
18964         (resetDefaultsToConsistentValues):
18965         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
18966         (WebCore::WebPage::resetSettings):
18967         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
18968         (LayoutTestController::overridePreference):
18969         * DumpRenderTree/win/DumpRenderTree.cpp:
18970         (resetDefaultsToConsistentValues):
18971
18972 2012-07-10  Xianzhu Wang  <wangxianzhu@chromium.org>
18973
18974         [Chromium-Android] Fix typos in chromium_android.py in r151492
18975         https://bugs.webkit.org/show_bug.cgi?id=90904
18976
18977         Reviewed by Ojan Vafai.
18978
18979         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
18980         (ChromiumAndroidPort.setup_test_run):
18981
18982 2012-07-10  Xianzhu Wang  <wangxianzhu@chromium.org>
18983
18984         [Chromium-Android] Use setup_test_runner() instead of start_helper() to setup test environment
18985         https://bugs.webkit.org/show_bug.cgi?id=90894
18986
18987         Reviewed by Adam Barth.
18988
18989         start_helper() is actually start_pixel_test_helper() since r115601 (bug 81729).
18990         Should use setup_test_runner() to setup test environment for chromium-android.
18991
18992         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
18993         (ChromiumAndroidPort.setup_test_run): Renamed from start_helper(). Added cache cleanup code.
18994         (ChromiumAndroidPort.clean_up_test_run): Renamed from stop_helper().
18995         (ChromiumAndroidPort._path_to_helper): Returns None as we don't have a helper now.
18996         (ChromiumAndroidPort):
18997         (ChromiumAndroidPort._path_to_forwarder): Original _path_to_helper().
18998         (ChromiumAndroidPort._push_executable):
18999         (ChromiumAndroidDriver.__init__):
19000         (ChromiumAndroidDriver.cmd_line):
19001
19002 2012-07-09  Ojan Vafai  <ojan@chromium.org>
19003
19004         Improve webkit-patch rebaseline to work for more cases
19005         https://bugs.webkit.org/show_bug.cgi?id=90504
19006
19007         Reviewed by Adam Barth.
19008
19009         -Makes it work for the build.chromium.org bots.
19010         -Lets you rebaseline all builders instead of just one.
19011         -Lets you pass in the builders or tests to rebaseline.
19012
19013         * Scripts/webkitpy/common/host.py:
19014         (Host.buildbot_for_builder_name):
19015         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
19016         (Builder.__init__):
19017         (Builder.latest_layout_test_results):
19018         Provide a way to get to the LayoutTestResults of the latest build.
19019         Most of the time we only need to get the latest one and the Chromium bots
19020         only expose the full_results.json file for the latest build.
19021
19022         (Builder):
19023         (Builder._fetch_file_from_results):
19024         (Builder.fetch_layout_test_results):
19025         Move these functions into Builder so that Builder and Build can both
19026         fetch layout test results.
19027
19028         (Build.results_zip_url):
19029         (Build.layout_test_results):
19030         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
19031         (BuilderTest.test_latest_layout_test_results):
19032         (BuildTest.test_layout_test_results):
19033         * Scripts/webkitpy/common/system/user.py:
19034         (User.prompt_with_multiple_lists):
19035         Prompt with multiple sublists, but still have a global numbering.
19036         This lets the build.chromium.org bots be clearly separated from the
19037         build.webkit.org bots, which helps understand the builder names.
19038
19039         (User):
19040         (User._wait_on_list_response):
19041         (User.prompt_with_list):
19042         * Scripts/webkitpy/common/system/user_unittest.py:
19043         (UserTest.test_prompt_with_multiple_lists):
19044         (UserTest.test_prompt_with_multiple_lists.run_prompt_test):
19045         (UserTest.test_prompt_with_multiple_lists.run_prompt_test.mock_raw_input):
19046         * Scripts/webkitpy/layout_tests/port/base.py:
19047         (Port.is_chromium):
19048         Provide a way to tell if a port is a Chromium port that doesn't involve string
19049         manipulation on the port name or builder name.
19050
19051         * Scripts/webkitpy/layout_tests/port/builders.py:
19052         (builder_path_from_name):
19053         (all_builder_names):
19054         Memoizing here is incorrect because the test override _exact_matches,
19055         so these can return different values. In either case, I'm pretty sure these
19056         are not remotely hot codepaths. I manually inspected all call sites and they're
19057         all in high-level calls (e.g. execute calls for webkit-patch commands) and not
19058         called in a loop.
19059
19060         * Scripts/webkitpy/layout_tests/port/chromium.py:
19061         (ChromiumPort.is_chromium):
19062         * Scripts/webkitpy/tool/commands/rebaseline.py:
19063         (RebaselineTest._results_url):
19064         (AbstractParallelRebaselineCommand.__init__):
19065         (Rebaseline.__init__):
19066         (Rebaseline):
19067         (Rebaseline._builders_to_pull_from):
19068         (Rebaseline._tests_to_update):
19069         (Rebaseline.execute):
19070         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
19071         (test_rebaseline.mock_builders_to_pull_from):
19072         (test_rebaseline):
19073         (test_rebaseline_command_line_flags):
19074         (test_rebaseline_multiple_builders):
19075         (test_rebaseline_multiple_builders.mock_builders_to_pull_from):
19076         (test_rebaseline_multiple_builders.mock_tests_to_update):
19077         (test_rebaseline_multiple_builders_and_tests_command_line):
19078         * Scripts/webkitpy/tool/mocktool.py:
19079         (MockTool.irc):
19080         (MockTool):
19081         (MockTool.buildbot_for_builder_name):
19082
19083 2012-07-10  Alice Cheng  <alice_cheng@apple.com>
19084
19085         Editing: Reproducible crasher when pasting a 0x0 image into Mail
19086         https://bugs.webkit.org/show_bug.cgi?id=90640
19087         <rdar://problem/11141920>
19088
19089         Reviewed by Brady Eidson.
19090
19091         Test cases for the patch. 0x0 images don't get a resource representation in the WebArchive, so we need a null check.
19092
19093         * TestWebKitAPI/Tests/mac/0.png: Added.
19094         * TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm: Added.
19095         (TestWebKitAPI):
19096         (TestWebKitAPI::TEST):
19097
19098 2012-07-10  Leandro Gracia Gil  <leandrogracia@chromium.org>
19099
19100         WebSurroundingText layout tests should use the same code path as the rest of the feature.
19101         https://bugs.webkit.org/show_bug.cgi?id=90807
19102
19103         Reviewed by Adam Barth.
19104
19105         Make the textSurroundingNode method take a pair of point coordinates
19106         instead of a node offset.
19107
19108         * DumpRenderTree/chromium/LayoutTestController.cpp:
19109         (LayoutTestController::textSurroundingNode):
19110         * DumpRenderTree/chromium/LayoutTestController.h:
19111         (LayoutTestController):
19112
19113 2012-07-10  Csaba Osztrogonác  <ossy@webkit.org>
19114
19115         [Qt] REGRESSION(r122175): It broke the Windows build
19116         https://bugs.webkit.org/show_bug.cgi?id=90850
19117
19118         Reviewed by Noam Rosenthal.
19119
19120         * qmake/mkspecs/features/features.prf: Disable USE(3D_GRAPHICS) on Windows temporarily until proper fix.
19121
19122 2012-07-10  János Badics  <jbadics@inf.u-szeged.hu>
19123
19124         [Qt][NRWT] Enable cascaded TestExpectations
19125         https://bugs.webkit.org/show_bug.cgi?id=89108
19126
19127         Reviewed by Dirk Pranke.
19128
19129         * Scripts/webkitpy/layout_tests/port/qt.py:
19130         (QtPort.expectations_files):
19131         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
19132         (QtPortTest._assert_expectations_files):
19133         (QtPortTest.test_expectations_files):
19134
19135 2012-07-10  Christophe Dumez  <christophe.dumez@intel.com>
19136
19137         [EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::*
19138         https://bugs.webkit.org/show_bug.cgi?id=90868
19139
19140         Unreviewed EFL build fix.
19141
19142         Correct CMake configuration to have EFL's DRT and WebKitTestRunner link
19143         WTF library. This is needed to resolve undefined reference to WTF::MD5::*.
19144
19145         * DumpRenderTree/efl/CMakeLists.txt:
19146         * WebKitTestRunner/PlatformEfl.cmake:
19147
19148 2012-07-10  Adam Barth  <abarth@webkit.org>
19149
19150         LayoutTestController.dumpConfigurationForViewport should move to Internals
19151         https://bugs.webkit.org/show_bug.cgi?id=45652
19152
19153         Reviewed by Eric Seidel.
19154
19155         Remove dumpConfigurationForViewport from LayoutTestController. This API
19156         has been replaced by an API on Internals that does the same thing in a
19157         port-agnostic way.
19158
19159         * DumpRenderTree/LayoutTestController.cpp:
19160         (LayoutTestController::staticFunctions):
19161         * DumpRenderTree/LayoutTestController.h:
19162         (LayoutTestController):
19163         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
19164         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
19165         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
19166         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
19167         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
19168         * DumpRenderTree/qt/LayoutTestControllerQt.h:
19169         (LayoutTestController):
19170         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
19171         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
19172
19173 2012-07-09  Matt Falkenhagen  <falken@chromium.org>
19174
19175         Add ENABLE_DIALOG_ELEMENT and skeleton files
19176         https://bugs.webkit.org/show_bug.cgi?id=90521
19177
19178         Reviewed by Kent Tamura.
19179
19180         * Scripts/webkitperl/FeatureList.pm:
19181
19182 2012-07-09  Kent Tamura  <tkent@chromium.org>
19183
19184         Improve the boilerplate generated by prepare-ChangeLog
19185         https://bugs.webkit.org/show_bug.cgi?id=89560
19186
19187         Reviewed by Ryosuke Niwa.
19188
19189         Produce the following boilerplate:
19190
19191         > 2012-06-20  Kent Tamura  <tkent@chromium.org>
19192         >
19193         >         Need a short description (Oops!).
19194         >         Need the bug URL (Oops!).
19195         >
19196         >         Reviewed by NOBODY (Oops!).
19197         >
19198         >         Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
19199         >
19200         >         No new tests (Oops!).
19201
19202         * Scripts/prepare-ChangeLog:
19203         (generateNewChangeLogs): Generate the updated template.
19204         * Scripts/webkitpy/common/checkout/changelog.py:
19205         (ChangeLog.update_with_unreviewed_message):
19206         Update the pattern for the beginning of the boilerplate.
19207         (ChangeLog.set_short_description_and_bug_url):
19208         - Use self._changelog_indent
19209         - Update the pattern for the description line
19210         - Skip the bug boilerplate.
19211         We substitute the specified bug URL to the description boilerplate
19212         because we need to add it even if the bug URL boilerplate is missing.
19213         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Update the boilerplate data.
19214         (test_set_short_description_and_bug_url):
19215         - Update the description boilerplate.
19216         - Add a test for a case with both of the description boilerplace and the
19217           bug URL boilerplate.
19218         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
19219         (PrepareChangeLogTest.test_ensure_bug_url): Update the expected boilerplate.
19220
19221 2012-07-09  No'am Rosenthal  <noam.rosenthal@nokia.com>
19222
19223         Shared code that is guarded with ENABLE(WEBGL) should be guarded with USE()
19224         https://bugs.webkit.org/show_bug.cgi?id=90506
19225
19226         Reviewed by Martin Robinson.
19227
19228         Always enable the WTF_USE_3D_GRAPHICS flag in features.prf if we're compiling with Qt5
19229         or if the OpenGL module is enabled.
19230
19231         * qmake/mkspecs/features/features.prf:
19232
19233 2012-07-09  Yongjun Zhang  <yongjun_zhang@apple.com>
19234
19235         Consider closing unused localStorage database after a timeout.
19236         https://bugs.webkit.org/show_bug.cgi?id=90713
19237
19238         For a localStorage, if there is no active document referencing to it for certain amount of time (300 seconds),
19239         we can close the underlying sqlite database.
19240
19241         Reviewed by Brady Eidson.
19242
19243         * DumpRenderTree/LayoutTestController.cpp: add a JS method setStorageDatabaseIdleInterval to testRunner
19244             to set a different timeout value for closing localStorage database.
19245         (setStorageDatabaseIdleIntervalCallback):
19246         (LayoutTestController::staticFunctions):
19247         * DumpRenderTree/LayoutTestController.h:
19248         (LayoutTestController):
19249         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
19250         (LayoutTestController::setStorageDatabaseIdleInterval): add empty method.
19251         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
19252         (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
19253         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
19254         (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
19255         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
19256         (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
19257
19258 2012-07-09  Adam Klein  <adamk@chromium.org>
19259
19260         Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver
19261         https://bugs.webkit.org/show_bug.cgi?id=90810
19262
19263         Reviewed by Ojan Vafai.
19264
19265         * DumpRenderTree/gtk/EventSender.cpp:
19266
19267 2012-07-09  Mihai Parparita  <mihaip@chromium.org>
19268
19269         Handle missing results in TestResultsServer better
19270         https://bugs.webkit.org/show_bug.cgi?id=90816
19271
19272         Reviewed by Ojan Vafai.
19273
19274         If we can't load the results JSON, don't try to wrap it with the JSONP
19275         callback invocation.
19276
19277         * TestResultServer/handlers/testfilehandler.py:
19278         (GetFile.get):
19279
19280 2012-07-09  Sheriff Bot  <webkit.review.bot@gmail.com>
19281
19282         Unreviewed, rolling out r122124.
19283         http://trac.webkit.org/changeset/122124
19284         https://bugs.webkit.org/show_bug.cgi?id=90815
19285
19286         It broke NRWT on Qt (Requested by Ossy_HOME on #webkit).
19287
19288         * Scripts/webkitpy/layout_tests/port/qt.py:
19289         (QtPort._skipped_file_search_paths):
19290         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
19291         (QtPortTest._assert_skipped_path):
19292         (QtPortTest.test_skipped_file_search_path):
19293
19294 2012-07-09  Zan Dobersek  <zandobersek@gmail.com>
19295
19296         [Gtk] Implement dumpFrameScrollPosition in DumpRenderTree
19297         https://bugs.webkit.org/show_bug.cgi?id=89356
19298
19299         Reviewed by Martin Robinson.
19300
19301         Implement dumpFrameScrollPosition, acquiring the scroll position
19302         through WebKitDOMDOMWindow of the WebKitDOMDocument loaded in the frame
19303         whose scroll position is being dumped.
19304
19305         * DumpRenderTree/gtk/DumpRenderTree.cpp:
19306         (dumpFrameScrollPosition):
19307
19308 2012-07-09  János Badics  <jbadics@inf.u-szeged.hu>
19309
19310         [Qt][NRWT] Enable cascaded TestExpectations
19311         https://bugs.webkit.org/show_bug.cgi?id=89108
19312
19313         Reviewed by Dirk Pranke.
19314
19315         * Scripts/webkitpy/layout_tests/port/qt.py:
19316         (QtPort.expectations_files):
19317         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
19318         (QtPortTest._assert_expectations_files):
19319         (QtPortTest.test_expectations_files):
19320
19321 2012-07-09  Dan Bernstein  <mitz@apple.com>
19322
19323         Fixed clean builds of the All target in the DumpRenderTree project.
19324
19325         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode know that the
19326         DumpRenderTree Perl Support target depends on the DumpRenderTree target.
19327
19328 2012-07-09  Zan Dobersek  <zandobersek@gmail.com>
19329
19330         [Gtk] Unskip the CSS Regions layout tests
19331         https://bugs.webkit.org/show_bug.cgi?id=90771
19332
19333         Reviewed by Martin Robinson.
19334
19335         Use the DumpRenderTreeSupportGtk method for enabling the CSS Regions,
19336         calling it when resetting the defaults in DumpRenderTree or when the
19337         settings value is overriden through the testRunner.
19338
19339         * DumpRenderTree/gtk/DumpRenderTree.cpp:
19340         (resetDefaultsToConsistentValues):
19341         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
19342         (LayoutTestController::overridePreference):
19343
19344 2012-07-09  Sheriff Bot  <webkit.review.bot@gmail.com>
19345
19346         Unreviewed, rolling out r122107.
19347         http://trac.webkit.org/changeset/122107
19348         https://bugs.webkit.org/show_bug.cgi?id=90794
19349
19350         Build failure on Mac debug bots (Requested by falken_ on
19351         #webkit).
19352
19353         * Scripts/webkitperl/FeatureList.pm:
19354
19355 2012-07-09  Matt Falkenhagen  <falken@chromium.org>
19356
19357         Add ENABLE_DIALOG_ELEMENT and skeleton files
19358         https://bugs.webkit.org/show_bug.cgi?id=90521
19359
19360         Reviewed by Kent Tamura.
19361
19362         * Scripts/webkitperl/FeatureList.pm:
19363
19364 2012-07-08  Kent Tamura  <tkent@chromium.org>
19365
19366         Unreviewed, rolling out r122076.
19367         http://trac.webkit.org/changeset/122076
19368         https://bugs.webkit.org/show_bug.cgi?id=89560
19369
19370         Broke sheriffbot rollout
19371
19372         * Scripts/prepare-ChangeLog:
19373         (generateNewChangeLogs):
19374
19375 2012-07-08  Leandro Gracia Gil  <leandrogracia@chromium.org>
19376
19377         Update the description of LayoutTestController::textSurroundingElement
19378         https://bugs.webkit.org/show_bug.cgi?id=90620
19379
19380         Reviewed by Adam Barth.
19381
19382         Rename and fix the description of the method as its behaviour changed
19383         during the review of https://bugs.webkit.org/show_bug.cgi?id=82461
19384
19385         * DumpRenderTree/chromium/LayoutTestController.cpp:
19386         (LayoutTestController::LayoutTestController):
19387         (LayoutTestController::textSurroundingNode):
19388         * DumpRenderTree/chromium/LayoutTestController.h:
19389         (LayoutTestController):
19390
19391 2012-07-08  Kent Tamura  <tkent@chromium.org>
19392
19393         Improve the template generated by prepare-ChangeLog
19394         https://bugs.webkit.org/show_bug.cgi?id=89560
19395
19396         Reviewed by Ryosuke Niwa.
19397
19398         Produce the following template:
19399
19400         > 2012-06-20  Kent Tamura  <tkent@chromium.org>
19401         >
19402         >         Need a short description (Oops!).
19403         >         Need the bug URL (Oops!).
19404         >
19405         >         Reviewed by Ryosuke Niwa.
19406         >
19407         >         Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
19408         >
19409         >         No new tests (Oops!).
19410
19411         * Scripts/prepare-ChangeLog:
19412         (generateNewChangeLogs):
19413
19414 2012-07-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
19415
19416         [wx] Unreviewed. Fix notificaitons directory path after notifications move.
19417
19418         * waf/build/settings.py:
19419
19420 2012-07-07  Nuno Lopes  <nlopes@apple.com>
19421
19422         Fix build with recent clang.
19423         https://bugs.webkit.org/show_bug.cgi?id=90712
19424
19425         Reviewed by Alexey Proskuryakov.
19426
19427         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
19428         (DOMWindowExtensionBasic):
19429         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
19430         (DOMWindowExtensionNoCache):
19431         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
19432         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
19433
19434 2012-07-06  Zan Dobersek  <zandobersek@gmail.com>
19435
19436         [Gtk] Add a configuration option for disabling unstable features in releases
19437         https://bugs.webkit.org/show_bug.cgi?id=87995
19438
19439         Reviewed by Martin Robinson.
19440
19441         Pass the --enable-unstable-features flag when building the Gtk port through build-webkit.
19442
19443         * Scripts/webkitdirs.pm:
19444         (buildAutotoolsProject):
19445
19446 2012-07-06  Jessie Berlin  <jberlin@apple.com>
19447
19448         WKContext should ask for its initialization data when it needs it so the client doesn't have
19449         to keep it up to date.
19450         https://bugs.webkit.org/show_bug.cgi?id=90627
19451
19452         Reviewed by Anders Carlsson.
19453
19454         Add tests and update other WKContextInjectedBundleClients.
19455
19456         * MiniBrowser/mac/AppDelegate.m:
19457         (-[BrowserAppDelegate init]):
19458         Updated for the change to WKContextInjectedBundleClient.
19459         * WebKitTestRunner/TestController.cpp:
19460         (WTR::TestController::initialize):
19461         Ditto.
19462
19463         * TestWebKitAPI/PlatformUtilities.cpp:
19464         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
19465         Moved the logic to create the initialization dictionary here ...
19466         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
19467         ... from here so that it can be used without automatically using
19468         WKContextSetInitializationUserDataForInjectedBundle.
19469         * TestWebKitAPI/PlatformUtilities.h:
19470
19471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19472         Add the new test files.
19473         * TestWebKitAPI/GNUmakefile.am:
19474         Ditto.
19475
19476         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Added.
19477         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
19478         Check that the message received from the injected bundle matches the user data it was
19479         initialized with.
19480         (TestWebKitAPI::getInjectedBundleInitializationUserData):
19481         Return the user data that the injected bundle should be initialized with.
19482         (TestWebKitAPI::TEST):
19483         Set up WKContextInjectedBundleClient and load a page.
19484         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Added.
19485         (TestWebKitAPI::GetInjectedBundleInitializationUserDataCallbackTest::initialize):
19486         Send the initialization user data back up to the UI Process.
19487
19488         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Added.
19489         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
19490         Check that the message received from the injected bundle matches the user data it was
19491         initialized with in the callback.
19492         (TestWebKitAPI::getInjectedBundleInitializationUserData):
19493         Return the user data that the injected bundle should be initialized with.
19494         (TestWebKitAPI::TEST):
19495         Set up the context and use WKContextSetInitializationUserDataForInjectedBundle to set the
19496         initialization user data (which should be overridden by the user data returned in
19497         getInjectedBundleInitializationUserData).
19498         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Added.
19499         (TestWebKitAPI::InjectedBundleInitializationUserDataCallbackWinsTest::initialize):
19500         Send the initialization user data back up to the UI Process.
19501
19502 2012-07-06  Dongwoo Im  <dw.im@samsung.com>
19503
19504         [EFL][GTK] jhbuild : Disable pixman demos build depending on GTK+
19505         https://bugs.webkit.org/show_bug.cgi?id=90593
19506
19507         Reviewed by Philippe Normand.
19508
19509         * efl/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
19510         * gtk/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
19511
19512 2012-07-06  Luciano Wolf <luciano.wolf@openbossa.org>
19513
19514         [Qt] DumpRenderTree does not use 'monospace' font when directed
19515         https://bugs.webkit.org/show_bug.cgi?id=85203
19516
19517         The test fonts used for Qt tests were moved to the Liberation font family.
19518
19519         Due to this change we are skipping tons of tests. They will be gradually
19520         unskipped in batches, ASAP.
19521
19522         Also, the now unneeded special font configuration for Qt5 WK1 was removed.
19523
19524         Reviewed by Tor Arne Vestbø.
19525
19526         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
19527         (WebKit::initializeTestFonts):
19528
19529 2012-07-06  Csaba Osztrogonác  <ossy@webkit.org>
19530
19531         [Qt] Buildfix for newer Qt5
19532         https://bugs.webkit.org/show_bug.cgi?id=90519
19533
19534         Reviewed by Tor Arne Vestbø.
19535
19536         * MiniBrowser/qt/MiniBrowser.pro: We also need to depend on gui-private in the MiniBrowser to get access to these headers.
19537         * MiniBrowser/qt/MiniBrowserApplication.h: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
19538         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
19539
19540 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
19541
19542         [Qt] Make use of Qt5 qmake's changed makefile recursion behavior
19543
19544         When not using the -r option, qmake now interleaves qmake and make calls,
19545         so we don't need custom logic for this. There's also an option to supress
19546         the effect of the -r option, which we use to make WebKit.pro the only
19547         project file parsed in a recursive qmake-run.
19548
19549         https://bugs.webkit.org/show_bug.cgi?id=90461
19550
19551         Reviewed by Tor Arne Vestbø.
19552
19553         * qmake/mkspecs/features/default_post.prf:
19554         * qmake/mkspecs/features/functions.prf:
19555
19556 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
19557
19558         [Qt] Remove custom qmake logic for module creation
19559
19560         Qmake now has the necessary hooks to cleanly override the build locations.
19561
19562         https://bugs.webkit.org/show_bug.cgi?id=90461
19563
19564         Reviewed by Tor Arne Vestbø.
19565
19566         * qmake/mkspecs/features/default_pre.prf:
19567
19568 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
19569
19570         [Qt] Add top-level .qmake.conf
19571
19572         With Qt5, this makes setting $QMAKEPATH externally unnecessary.
19573
19574         The magic in the perl scripts to set QMAKEPATH is still there, as it doesn't
19575         hurt, and is still required for Qt4.
19576
19577         https://bugs.webkit.org/show_bug.cgi?id=90461
19578
19579         Reviewed by Tor Arne Vestbø.
19580
19581         * qmake/mkspecs/features/default_pre.prf:
19582
19583 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
19584
19585         [Qt] Unify qtFeatureDefaults code paths
19586
19587         There's no reason to run qmake on features.prf directly anymore, as we
19588         can selectivly run configure tests in the project file now.
19589
19590         https://bugs.webkit.org/show_bug.cgi?id=90461
19591
19592         Reviewed by Tor Arne Vestbø.
19593
19594         * Scripts/webkitdirs.pm:
19595         (qtFeatureDefaults):
19596         * qmake/configure.pri:
19597         * qmake/mkspecs/features/features.prf:
19598
19599 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
19600
19601         [Qt] Don't let qt_webkit.pri proclaim its own location
19602
19603         This won't work any more with recent Qt5 versions, as the forwarding
19604         pri is created by qt_module_config, which needs MODULE_PRI to be set
19605         up already.
19606
19607         We also need to load build_config, not qt_module.
19608
19609         https://bugs.webkit.org/show_bug.cgi?id=90461
19610
19611         Reviewed by Tor Arne Vestbø.
19612
19613         * qmake/qt_webkit.pri:
19614
19615 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
19616
19617         [Qt] Remove redundant CONFIG+=module
19618
19619         qt_module_config takes care of that.
19620
19621         In api.pri we are actually testing the flag ourselves, so now we need to
19622         test a related flag qt_module_config sets instead.
19623
19624         Reviewed by Tor Arne Vestbø.
19625
19626         * qmake/mkspecs/features/default_post.prf:
19627
19628 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
19629
19630         [Qt] Switch to new-style Qt 5 configure tests
19631
19632         Use explicit project file action instead of syncqt magic.
19633
19634         https://bugs.webkit.org/show_bug.cgi?id=90461
19635
19636         Reviewed by Tor Arne Vestbø.
19637
19638         * Scripts/webkitdirs.pm:
19639         (buildQMakeProjects):
19640         * qmake/configure.pri: Copied from Tools/qmake/configure.pro.
19641         * qmake/configure.pro:
19642         * qmake/mkspecs/features/default_pre.prf:
19643         * qmake/mkspecs/features/features.prf:
19644         * qmake/sync.profile: Removed.
19645
19646 2012-07-05  Jason Liu  <jason.liu@torchmobile.com.cn>
19647
19648         Add Jason Liu to committers.py.
19649         https://bugs.webkit.org/show_bug.cgi?id=90654
19650
19651         Unreviewed.
19652
19653         * Scripts/webkitpy/common/config/committers.py:
19654
19655 2012-07-05  Benjamin Poulain  <bpoulain@apple.com>
19656
19657         Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
19658         https://bugs.webkit.org/show_bug.cgi?id=90431
19659
19660         Reviewed by Anders Carlsson.
19661
19662         Add a Mac API test.
19663
19664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19665         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html: Added.
19666         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm: Added.
19667         (-[CancelLoadFromResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
19668         (-[CancelLoadFromResourceLoadDelegateFrameLoadDelegate webView:didFinishLoadForFrame:]):
19669         (TestWebKitAPI):
19670         (TestWebKitAPI::TEST):
19671
19672 2012-07-05  Dave Tharp  <dtharp@codeaurora.org>
19673
19674         Adding myself as committer to committers.py
19675
19676         Unreviewed.
19677
19678         * Scripts/webkitpy/common/config/committers.py:
19679
19680 2012-07-05  Alexey Proskuryakov  <ap@apple.com>
19681
19682         [Mac][WK2] Enable HTTPS tests
19683         https://bugs.webkit.org/show_bug.cgi?id=90600
19684
19685         Reviewed by Brady Eidson.
19686
19687         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.
19688         It explained why we were doing this here instead of a frame load delegate, but that's
19689         just history, not an explanation of why we need this code.
19690
19691         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
19692         Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
19693         for tests, it seems appropriate to have platform specific solutions in every WTR,
19694         and not add a WebKit2 API.
19695
19696 2012-07-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
19697
19698         [Qt] Remove rpath-hacks in qt_webkit.pri
19699
19700         Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
19701         even if they were not using QtWebKit.
19702
19703         This is a regression for people who build client apps against a non-installed
19704         QtWebKit, as the client app will be missing a rpath to the standalone WebKit
19705         build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
19706         logic, until the real issue is fixed in Qt.
19707
19708         Reviewed by Csaba Osztrogonác.
19709
19710         * qmake/mkspecs/features/rpath.prf:
19711         * qmake/qt_webkit.pri:
19712
19713 2012-07-05  Dongwoo Im  <dw.im@samsung.com>
19714
19715         [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
19716         https://bugs.webkit.org/show_bug.cgi?id=88608
19717
19718         Reviewed by Hajime Morita.
19719
19720         * Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.
19721
19722 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
19723
19724         [Wk2][EFL] EFL needs a WebKitTestRunner
19725         https://bugs.webkit.org/show_bug.cgi?id=87659
19726
19727         Reviewed by Kenneth Rohde Christiansen.
19728
19729         Add an implementation of WebKitTestRunner for Efl port.
19730
19731         * CMakeLists.txt: Includes WebKitTestRunner build script.
19732         * Scripts/build-webkittestrunner: Added knowledge of WebKitTestRunner/Efl.
19733         * Scripts/webkitpy/layout_tests/port/efl.py: Ditto.
19734         (EflPort.setup_environ_for_server):
19735         * WebKitTestRunner/CMakeLists.txt: Added.
19736         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
19737         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Added.
19738         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
19739         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Added.
19740         * WebKitTestRunner/PlatformEfl.cmake: Added.
19741         * WebKitTestRunner/PlatformWebView.h:
19742         * WebKitTestRunner/TestController.cpp:
19743         * WebKitTestRunner/config.h: Added knowledge of WebKitTestRunner/Efl.
19744         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Added.
19745         * WebKitTestRunner/efl/TestControllerEfl.cpp: Added.
19746         * WebKitTestRunner/efl/main.cpp: Added.
19747         (main):
19748
19749 2012-07-05  Christophe Dumez  <christophe.dumez@intel.com>
19750
19751         [WK2][EFL] Ewk_View needs API to load HTML data
19752         https://bugs.webkit.org/show_bug.cgi?id=90540
19753
19754         Reviewed by Kenneth Rohde Christiansen.
19755
19756         Update EFL MiniBrowser to catch the "load,error" signal
19757         on the view and display an error page.
19758
19759         * MiniBrowser/efl/main.c:
19760         (on_error):
19761         (browserCreate):
19762
19763 2012-07-05  Sergio Villar Senin  <svillar@igalia.com>
19764
19765         Hidden dirs are not copied when creating the built product archive
19766         https://bugs.webkit.org/show_bug.cgi?id=90559
19767
19768         Reviewed by Carlos Garcia Campos.
19769
19770         Hidden dirs are not copied inside the built product archive
19771         because the recursive copy command was ignoring them. We need those
19772         hidden directories for the GTK WebKit2 testing bot to work fine.
19773
19774         * BuildSlaveSupport/built-product-archive:
19775         (archiveBuiltProduct): replaced "*" by "." to include hidden
19776         dirs/files.
19777
19778 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
19779
19780         Unreviewed Chromium gardening, Disable always failed python tests on Windows.
19781         https://bugs.webkit.org/show_bug.cgi?id=90587
19782
19783         PortTest.qt_linux and mac_lion are always failed on Chromium Windows at
19784         creating child process.
19785
19786         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
19787         (PortTest.disabled_test_qt_linux):
19788         (PortTest.disabled_test_mac_lion):
19789
19790 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
19791
19792         [Tools] webkit_unittest.py got assertion
19793         https://bugs.webkit.org/show_bug.cgi?id=90579
19794
19795         Reviewed by Hajime Morita.
19796
19797         This patch updates expectation of assertion in test_skipped_directories_for_symbols().
19798         r121874 added new (exclude) directory (inspector/styles/variables), however it didn't
19799         update one of two assertions.
19800
19801         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
19802
19803 2012-07-04  Balazs Ankes  <bank@inf.u-szeged.hu>
19804
19805         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
19806         https://bugs.webkit.org/show_bug.cgi?id=67935
19807
19808         Reviewed by Ryosuke Niwa.
19809
19810         * Scripts/webkitpy/common/checkout/changelog.py:
19811         (ChangeLog.set_reviewer):
19812         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
19813         (test_set_reviewer):
19814         (test_set_short_description_and_bug_url):
19815
19816 2012-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
19817
19818         Unreviewed, rolling out r121862.
19819         http://trac.webkit.org/changeset/121862
19820         https://bugs.webkit.org/show_bug.cgi?id=90569
19821
19822         It broke built-product-archive for GTK, Qt and EFL (Requested
19823         by svillar on #webkit).
19824
19825         * BuildSlaveSupport/built-product-archive:
19826         (archiveBuiltProduct):
19827
19828 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
19829
19830         Hidden dirs are not copied when creating the built product archive
19831         https://bugs.webkit.org/show_bug.cgi?id=90559
19832
19833         Reviewed by Carlos Garcia Campos.
19834
19835         Hidden dirs are not copied inside the built product archive because
19836         the recursive copy command was ignoring them. We need those hidden
19837         directories for the GTK WebKit2 testing bot to work fine.
19838
19839         * BuildSlaveSupport/built-product-archive:
19840         (archiveBuiltProduct): removed the trailing "*" from the copy
19841         command.
19842
19843 2012-07-04  John Mellor  <johnme@chromium.org>
19844
19845         Text Autosizing: Add compile flag and runtime setting
19846         https://bugs.webkit.org/show_bug.cgi?id=87394
19847
19848         This patch renames Font Boosting to Text Autosizing.
19849
19850         Reviewed by Adam Barth.
19851
19852         * Scripts/webkitperl/FeatureList.pm:
19853         * qmake/mkspecs/features/features.pri:
19854
19855 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
19856
19857         [Qt] Replace deprecated IN_PWD with PWD
19858
19859         Reviewed by Csaba Osztrogonác.
19860
19861         * qmake/mkspecs/features/default_pre.prf:
19862
19863 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
19864
19865         [Qt] Don't try to build WTR twice
19866
19867         Reviewed by Csaba Osztrogonác.
19868
19869         * Tools.pro:
19870
19871 2012-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
19872
19873         Unreviewed, rolling out r121821.
19874         http://trac.webkit.org/changeset/121821
19875         https://bugs.webkit.org/show_bug.cgi?id=90551
19876
19877         This patch did not receive a high-quality review and has a
19878         number of errors (Requested by abarth on #webkit).
19879
19880         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
19881         (Build.results_url):
19882         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
19883         (ChromiumBuilder.accumulated_results_url):
19884         * Scripts/webkitpy/layout_tests/port/builders.py:
19885         * Scripts/webkitpy/tool/commands/rebaseline.py:
19886         (AbstractParallelRebaselineCommand.__init__):
19887         (Rebaseline):
19888         (Rebaseline._builder_to_pull_from):
19889         (Rebaseline._tests_to_update):
19890         (Rebaseline.execute):
19891         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
19892         (test_rebaseline.mock_builder_to_pull_from):
19893         (test_rebaseline):
19894
19895 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
19896
19897         [Qt] Get rid of un-needed QT += declarative for Qt 5
19898
19899         The declarative module has been renamed to quick1 in Qt 5, and the
19900         engine-only module for Qt 5 is named 'qml'. For many of the instances
19901         we could just remove 'declarative', since the project file was only
19902         used for Qt5/WebKit2 builds. In the other cases the module was wrapped
19903         in a haveQt(4) scope.
19904
19905         Reviewed by Csaba Osztrogonác.
19906
19907         * MiniBrowser/qt/MiniBrowser.pro:
19908         * WebKitTestRunner/InjectedBundle/Target.pri:
19909         * WebKitTestRunner/Target.pri:
19910
19911 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
19912
19913         [Qt] Remove a few un-needed load(features) after r121777
19914
19915         The features are computed by configure.pro and cached in .qmake.cache.
19916
19917         Reviewed by Jocelyn Turcotte..
19918
19919         * MiniBrowser/qt/raw/Target.pri:
19920
19921 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
19922
19923         [Qt] Use haveQtModule() in project files instead of manual checks
19924
19925         Reviewed by Jocelyn Turcotte.
19926
19927         * qmake/mkspecs/features/default_pre.prf:
19928         * qmake/mkspecs/features/features.prf:
19929
19930 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
19931
19932         [Qt] Fix haveQtModule() check
19933
19934         Without {} brackets we were pulling out the value of the module.name variable.
19935
19936         Reviewed by Jocelyn Turcotte.
19937
19938         * qmake/mkspecs/features/functions.prf:
19939
19940 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
19941
19942         [WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
19943         https://bugs.webkit.org/show_bug.cgi?id=90541
19944
19945         Reviewed by Carlos Garcia Campos.
19946
19947         We must add the contents of WebKitBuild/*/Libraries/ directory to
19948         the file to be uploaded to b.w.o to successfully run WebKit2 tests
19949         in the WebKit2 testing bot.
19950
19951         * BuildSlaveSupport/built-product-archive:
19952         (archiveBuiltProduct): appended Libraries to the list of
19953         neededDirectories.
19954
19955 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
19956
19957         [GTK] WebKit2 testing bot unable to find the build directory
19958         https://bugs.webkit.org/show_bug.cgi?id=90523
19959
19960         Reviewed by Carlos Garcia Campos.
19961
19962         The presence of GNUmakefile was used to determine whether a given
19963         directory was a valid build directory or not. That's not correct for
19964         testing bots as we export only the minimum required stuff to run the
19965         tests.
19966
19967         * gtk/common.py:
19968         (get_build_path.is_valid_build_directory): added an extra check.:
19969
19970 2012-07-04  Joe Thomas  <joethomas@motorola.com>
19971
19972         Adding myself to committers list.
19973
19974         Unreviewed.
19975
19976         * Scripts/webkitpy/common/config/committers.py:
19977
19978 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
19979
19980         [WK2][EFL] Ewk_View should report the load progress
19981         https://bugs.webkit.org/show_bug.cgi?id=90457
19982
19983         Reviewed by Kenneth Rohde Christiansen.
19984
19985         Update EFL MiniBrowser so that it listens for the
19986         "load,progress" on the Ewk_View and updates its
19987         window title accordingly.
19988
19989         * MiniBrowser/efl/main.c:
19990         (title_set):
19991         (on_title_changed):
19992         (on_progress):
19993         (browserCreate):
19994
19995 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
19996
19997         disable failing mock-chromium-mac python unit tests
19998
19999         Unreviewed, build fix.
20000
20001         Disable these tests until I can figure out why they're failing
20002         on the bots.
20003
20004         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
20005         (PortTest.disabled_test_chromium_mac_lion):
20006         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
20007
20008 2012-07-03  Ian Vollick  <vollick@chromium.org>
20009
20010         Add vollick to the list of committers
20011         https://bugs.webkit.org/show_bug.cgi?id=90512
20012
20013         Reviewed by Adrienne Walker.
20014
20015         * Scripts/webkitpy/common/config/committers.py:
20016
20017 2012-07-03  Ojan Vafai  <ojan@chromium.org>
20018
20019         Improve webkit-patch rebaseline to work for more cases
20020         https://bugs.webkit.org/show_bug.cgi?id=90504
20021
20022         Reviewed by Dirk Pranke.
20023
20024         -Makes it work for the build.chromium.org bots.
20025         -Lets you rebaseline all builders instead of just one.
20026         -Lets you pass in the builder or test to rebaseline.
20027
20028         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
20029         (Build.results_url):
20030         Make this work for build.chromium.org builders as well.
20031
20032         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
20033         (ChromiumBuilder):
20034         (ChromiumBuilder.latest_cached_build):
20035         ChromiumBuilder doesn't support large parts of the Builder interface.
20036         This provides the bare minimum for this patch to work. Eventually,
20037         we should create a single interface that can be supported for both
20038         sets of buildbots.
20039
20040         * Scripts/webkitpy/layout_tests/port/builders.py:
20041         (builder_path_from_name):
20042         (all_builder_names):
20043         memoizing here is incorrect because the test override _exact_matches,
20044         so these can return different values. In either case, I'm pretty sure these
20045         are not remotely hot codepaths.
20046
20047         * Scripts/webkitpy/tool/commands/rebaseline.py:
20048         (AbstractParallelRebaselineCommand.__init__):
20049         (Rebaseline):
20050         (Rebaseline.__init__):
20051         (Rebaseline._builders_to_pull_from):
20052         (Rebaseline._builder_with_name):
20053         (Rebaseline._tests_to_update):
20054         (Rebaseline.execute):
20055         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
20056         (test_rebaseline.mock_builders_to_pull_from):
20057         (test_rebaseline):
20058         (test_rebaseline_command_line_flags):
20059         (test_rebaseline_multiple_builders):
20060         (test_rebaseline_multiple_builders.mock_builders_to_pull_from):
20061         (test_rebaseline_multiple_builders.mock_tests_to_update):
20062
20063 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
20064
20065         [EFL] Enable CSS variables support at compile time
20066         https://bugs.webkit.org/show_bug.cgi?id=90448
20067
20068         Reviewed by Kenneth Rohde Christiansen.
20069
20070         Turn on CSS_VARIABLES flag by default on EFL port.
20071
20072         * Scripts/webkitperl/FeatureList.pm:
20073
20074 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
20075
20076         nrwt: clean up exception handling and make sure we log some more failures
20077         https://bugs.webkit.org/show_bug.cgi?id=90503
20078
20079         Reviewed by Ojan Vafai.
20080
20081         There were several places where exceptions weren't getting
20082         logged, most notably if you passed a bad value to --platform.
20083         This change tests that and cleans things up a bit; more cleanup
20084         will be possible when we rework the manager_worker_broker code.
20085
20086         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
20087         (_BrokerConnection.raise_exception):
20088         (_InlineWorkerConnection.raise_exception):
20089         * Scripts/webkitpy/layout_tests/controllers/worker.py:
20090         (Worker.run):
20091         (Worker.kill_driver):
20092         * Scripts/webkitpy/layout_tests/port/factory.py:
20093         (PortFactory.get):
20094         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
20095         (run):
20096         (main):
20097         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
20098         (MainTest.test_unsupported_platfrom):
20099
20100 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
20101
20102         nrwt: fix mock port
20103         https://bugs.webkit.org/show_bug.cgi?id=90500
20104
20105         Reviewed by Ojan Vafai.
20106
20107         The MockDRT code was never updated when we switched the chromium
20108         ports to using "drt mode" by default. This change updates that
20109         code, fixes a typo in the chromium port that went undetected
20110         (default_test_timeout_ms -> default_timeout_ms), and adds tests
20111         that actually exercise some of the mock ports. These tests are
20112         useful in that they will exercise the port-specific code in an
20113         end-to-end-manner, but they are a bit slow for some reason (>1s
20114         each) that I need to look into.
20115
20116         * Scripts/webkitpy/layout_tests/port/chromium.py:
20117         (ChromiumDriver.stop):
20118         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
20119         (ChromiumAndroidPort.default_timeout_ms):
20120         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
20121         (TestChromiumAndroidPort.test_default_timeout_ms):
20122         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
20123         (main):
20124         (parse_options):
20125         (MockTestShell):
20126         (MockTestShell.output_for_test):
20127         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
20128         (MockDRTTest.assertTest):
20129         (MockTestShellTest):
20130         (MockTestShellTest.make_drt):
20131         (MockTestShellTest.test_test_shell_parse_options):
20132         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
20133         (PortTest):
20134         (PortTest.assert_mock_port_works):
20135         (PortTest.test_chromium_mac_lion):
20136         (PortTest.test_chromium_mac_lion_in_test_shell_mode):
20137         (PortTest.test_qt_linux):
20138         (PortTest.test_mac_lion):
20139
20140 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
20141
20142         nrwt: make the worker class stand alone with a cleaner interface
20143         https://bugs.webkit.org/show_bug.cgi?id=90409
20144
20145         Reviewed by Ojan Vafai.
20146
20147         Currently the Worker class derives from AbstractWorker, which is
20148         kind of crufty and awkward; it would be better if we did not
20149         rely on shared state.
20150
20151         This change changes that so that Worker derives from object, and
20152         exposes the following interface:
20153           __init__() - called in the manager process
20154           safe_init() - called in the worker process to initialize
20155             unpicklable state
20156           handle() - a single routine to handle all messages
20157           cleanup() - called so the worker can clean up
20158
20159         Also, all of the "administrative" messages that are handled by
20160         the worker (notification of start/stop/etc.) move into
20161         manager_worker_broker - this reduces worker.py to just handling
20162         the mechanics of actually running each test.
20163
20164         For the moment, we do this by creating Yet Another wrapper/proxy
20165         class in manager_worker_broker, but this will get simpler
20166         shortly when the rest of m_w_b is cleaned up.
20167
20168         With this change worker is now in its new form but there will be
20169         a follow-on change that cleans up some names and other minor
20170         things.
20171
20172         This change is again mostly just moving things around and should
20173         be covered by the (updated) existing tests.
20174
20175         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
20176         (get):
20177         (AbstractWorker.__init__):
20178         (AbstractWorker.run):
20179         (AbstractWorker):
20180         (AbstractWorker.handle_stop):
20181         (AbstractWorker.handle_test_list):
20182         (AbstractWorker.yield_to_broker):
20183         (AbstractWorker.post_message):
20184         (_WorkerConnection.__init__):
20185         (_Process.run):
20186         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
20187         (_TestWorker):
20188         (_TestWorker.__init__):
20189         (_TestWorker.name):
20190         (_TestWorker.cleanup):
20191         (_TestWorker.handle):
20192         (_TestWorker.safe_init):
20193         (_TestWorker.stop):
20194         (_TestsMixin.handle_finished_test):
20195         (_TestsMixin.setUp):
20196         (_TestsMixin.test_cancel):
20197         (_TestsMixin.test_done):
20198         * Scripts/webkitpy/layout_tests/controllers/worker.py:
20199         (Worker):
20200         (Worker.__init__):
20201         (Worker.safe_init):
20202         (Worker.handle):
20203
20204 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
20205
20206         nrwt: moving child process logging code into manager_worker_broker
20207         https://bugs.webkit.org/show_bug.cgi?id=90408
20208
20209         Reviewed by Ojan Vafai.
20210
20211         Users of manager_worker_broker should not have to be aware of
20212         whether they're in the same process or different processes and
20213         configure logging themselves; mwb should hide this complexity.
20214         We can't quite do this completely/correctly yet, since the
20215         manager expects to get a list of messages to log, but this
20216         change fixes the worker side of it, at least.
20217
20218         This is just moving code around, there is no new functionality
20219         and this should be covered by existing tests.
20220
20221         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
20222         (AbstractWorker.__init__):
20223         (_WorkerConnection.__init__):
20224         (_WorkerConnection.post_message):
20225         (_WorkerConnection):
20226         (_WorkerConnection.set_up_logging):
20227         (_WorkerConnection.clean_up_logging):
20228         (_InlineWorkerConnection.run):
20229         (_MultiProcessWorkerConnection.run):
20230         (_WorkerLogHandler):
20231         (_WorkerLogHandler.__init__):
20232         (_WorkerLogHandler.emit):
20233         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
20234         (_TestWorker.run):
20235         (_TestsMixin.handle_done):
20236         * Scripts/webkitpy/layout_tests/controllers/worker.py:
20237         (Worker.__init__):
20238         (Worker.run):
20239         (Worker._run_test):
20240         (Worker.cleanup):
20241         (Worker.run_single_test):
20242
20243 2012-07-03  Tony Chang  <tony@chromium.org>
20244
20245         [chromium] Don't archive build files generated by VS2010
20246         https://bugs.webkit.org/show_bug.cgi?id=90493
20247
20248         Reviewed by Ojan Vafai.
20249
20250         In particular, the pch (pre compiled header) files are gigantic, making
20251         release.zip almost a 1gb in size.
20252
20253         * BuildSlaveSupport/built-product-archive:
20254         (archiveBuiltProduct):
20255
20256 2012-07-03  Tony Chang  <tony@chromium.org>
20257
20258         [chromium] Unreviewed, update .gitignore to handle VS2010 files.
20259
20260         * .gitignore:
20261         * DumpRenderTree/DumpRenderTree.gyp/.gitignore:
20262         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore:
20263
20264 2012-07-03  Ojan Vafai  <ojan@chromium.org>
20265
20266         Have webkit-patch rebaseline use rebaseline-test-internal
20267         https://bugs.webkit.org/show_bug.cgi?id=90491
20268
20269         Reviewed by Dirk Pranke.
20270
20271         This lets it handle new files, reduces duplicate code and lays the
20272         groundwork for making rebaseline have a richer interface.
20273
20274         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
20275         (MockBuild):
20276         (MockBuild.__init__):
20277         (MockBuilder.build):
20278         * Scripts/webkitpy/tool/commands/rebaseline.py:
20279         (AbstractParallelRebaselineCommand._files_to_add):
20280         (Rebaseline):
20281         (Rebaseline._builder_to_pull_from):
20282         (Rebaseline._tests_to_update):
20283         (Rebaseline.execute):
20284         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
20285         (test_overrides_are_included_correctly):
20286         (test_rebaseline):
20287         (test_rebaseline.mock_builder_to_pull_from):
20288         (test_rebaseline.mock_tests_to_update):
20289
20290 2012-07-03  Ojan Vafai  <ojan@chromium.org>
20291
20292         Rename rebaseline-test to rebaseline-test-internal
20293         https://bugs.webkit.org/show_bug.cgi?id=90485
20294
20295         Reviewed by Adam Barth.
20296
20297         It's now only used by other rebaseline commands. It's still useful to leave it
20298         as it's own command to aid in debugging when something goes wrong. In a followup
20299         patch, I'll make webkit-patch rebaseline cover any use-cases that rebaseline-test
20300         might have covered.
20301
20302         We no longer need the --print-scm-changes option since the only caller always passes
20303         that option in.
20304
20305         Also, make all the arguments command-line flags instead. Simplifies the code
20306         a bit in my opinion.
20307
20308         * Scripts/webkitpy/tool/commands/rebaseline.py:
20309         (RebaselineTest):
20310         (RebaselineTest.__init__):
20311         (RebaselineTest.execute):
20312         (AbstractParallelRebaselineCommand._rebaseline_commands):
20313         (RebaselineExpectations.execute):
20314         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
20315         (test_rebaseline_all):
20316
20317 2012-07-03  Balazs Kelemen  <kbalazs@webkit.org>
20318
20319         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
20320         https://bugs.webkit.org/show_bug.cgi?id=90262
20321
20322         Unreviewed build fix.
20323
20324         Reverting r121550 manually because it caused build
20325         break on ARM and Mac. It turned out that the Qt build
20326         system is too broken for this change now, first we have
20327         to address two issues:
20328             * symbol hiding was forbidden accidentally on x86 Linux
20329             * Qt lacks a separate library for test support
20330
20331         * Tools.pro:
20332         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
20333         (WTR::InjectedBundlePage::resetAfterTest):
20334         (WTR::InjectedBundlePage::didClearWindowForFrame):
20335         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
20336
20337 2012-07-03  Tony Chang  <tony@chromium.org>
20338
20339         [chromium] Handle trailing backslash on %VSINSTALLDIR%
20340         https://bugs.webkit.org/show_bug.cgi?id=90410
20341
20342         Reviewed by Ojan Vafai.
20343
20344         * Scripts/webkitdirs.pm:
20345         (buildChromiumVisualStudioProject): Handle VSINSTALLDIR ending in a backslash, the backslash escapes the closing double quote.
20346
20347 2012-07-02  Ojan Vafai  <ojan@chromium.org>
20348
20349         Make the skia_test_expectations.txt file optional.
20350         https://bugs.webkit.org/show_bug.cgi?id=90400
20351
20352         Reviewed by Dirk Pranke.
20353
20354         It used to be optional. This regressed at some point. It's important that it be
20355         optional so that webkit-patch commands work in a pure-webkit checkout for chromium bots.
20356         Specifically, this was breaking webkit-patch rebaseline-test when it would go to update
20357         TestExpectations.
20358
20359         * Scripts/webkitpy/layout_tests/port/chromium.py:
20360         (ChromiumPort.expectations_files):
20361         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
20362         (ChromiumDriverTest.test_expectations_dict):
20363
20364 2012-07-03  Raphael Kubo da Costa  <rakuco@webkit.org>
20365
20366         [jhbuild][EFL] Bump libffi dependency.
20367         https://bugs.webkit.org/show_bug.cgi?id=85373
20368
20369         Reviewed by Gustavo Noronha Silva.
20370
20371         Update libffi to 3.0.11, which fixes the build on some platforms
20372         where 3.0.10 had problems.
20373
20374         * efl/jhbuild.modules:
20375
20376 2012-07-03  George Staikos  <staikos@webkit.org>
20377
20378         [BlackBerry] Enable microdata support for BlackBerry.
20379         https://bugs.webkit.org/show_bug.cgi?id=90429
20380
20381         Reviewed by Rob Buis.
20382
20383         * Scripts/webkitperl/FeatureList.pm:
20384
20385 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
20386
20387         [Qt] Make use of .qmake.cache for caching features
20388
20389         Instead of loading() features from the files that need them (and re-running
20390         a bunch of checks), we now run feature detection as part of configure.pro,
20391         and have build-webkit write the computed feature-defines and CONFIG to
20392         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
20393         when building WebKit.pro.
20394
20395         At some point we'll be able to selectivly prevent running of config tests
20396         in configure.pro, which means we don't need a separate code-path for
20397         the build-webkit --help case.
20398
20399         We should also move the code in build-webkit that now uses .webkit.config
20400         to detect clean builds, to use .qmake.cache, since we now store the same
20401         thing there.
20402
20403         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
20404
20405         Reviewed by Tor Arne Vestbø.
20406
20407         * DumpRenderTree/qt/DumpRenderTree.pro:
20408         * QtTestBrowser/QtTestBrowser.pro:
20409         * Scripts/webkitdirs.pm:
20410         (qtFeatureDefaults):
20411         (buildQMakeProjects):
20412         * Tools.pro:
20413         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
20414         * WebKitTestRunner/InjectedBundle/Target.pri:
20415         * WebKitTestRunner/Target.pri:
20416         * qmake/.qmake.conf: Added.
20417         * qmake/configure.pro:
20418         * qmake/mkspecs/features/default_post.prf:
20419         * qmake/mkspecs/features/default_pre.prf:
20420         * qmake/mkspecs/features/features.prf:
20421
20422 2012-07-03  Nico Weber  <thakis@chromium.org>
20423
20424         -Wunused-private-field cleanup, linux edition
20425         https://bugs.webkit.org/show_bug.cgi?id=90463
20426
20427         Reviewed by Stephen White.
20428
20429         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
20430         * DumpRenderTree/chromium/GamepadController.h:
20431         (GamepadController):
20432         * DumpRenderTree/chromium/NotificationPresenter.h:
20433         (NotificationPresenter::NotificationPresenter):
20434         (NotificationPresenter):
20435
20436 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
20437
20438         Unreviewed, rolling out r121766.
20439         http://trac.webkit.org/changeset/121766
20440         https://bugs.webkit.org/show_bug.cgi?id=90465
20441
20442         It caused flakey build errors on the bots (Requested by Ossy
20443         on #webkit).
20444
20445         * DumpRenderTree/qt/DumpRenderTree.pro:
20446         * QtTestBrowser/QtTestBrowser.pro:
20447         * Scripts/webkitdirs.pm:
20448         (qtFeatureDefaults):
20449         (buildQMakeProjects):
20450         * Tools.pro:
20451         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
20452         * WebKitTestRunner/InjectedBundle/Target.pri:
20453         * WebKitTestRunner/Target.pri:
20454         * qmake/.qmake.conf: Removed.
20455         * qmake/configure.pro:
20456         * qmake/mkspecs/features/default_post.prf:
20457         * qmake/mkspecs/features/default_pre.prf:
20458         * qmake/mkspecs/features/features.prf:
20459
20460 2012-07-03  George Staikos  <staikos@webkit.org>
20461
20462         [BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
20463         https://bugs.webkit.org/show_bug.cgi?id=90422
20464
20465         Reviewed by Rob Buis.
20466
20467         * Scripts/webkitperl/FeatureList.pm:
20468
20469 2012-07-03  George Staikos  <staikos@webkit.org>
20470
20471         [BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
20472         https://bugs.webkit.org/show_bug.cgi?id=90422
20473
20474         Reviewed by Rob Buis.
20475
20476         * Scripts/webkitperl/FeatureList.pm:
20477
20478 2012-07-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
20479
20480         [EFL] Add run API tests as a step on the build bots
20481         https://bugs.webkit.org/show_bug.cgi?id=87252
20482
20483         Reviewed by Daniel Bates.
20484
20485         Run EFL API test suite on the build bots.
20486
20487         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
20488         (RunEflAPITests):
20489         (TestFactory.__init__):
20490         (BuildAndTestFactory.__init__):
20491         * Scripts/run-efl-tests: Added.
20492
20493 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
20494
20495         [Qt] Make use of .qmake.cache for caching features
20496
20497         Instead of loading() features from the files that need them (and re-running
20498         a bunch of checks), we now run feature detection as part of configure.pro,
20499         and have build-webkit write the computed feature-defines and CONFIG to
20500         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
20501         when building WebKit.pro.
20502
20503         At some point we'll be able to selectivly prevent running of config tests
20504         in configure.pro, which means we don't need a separate code-path for
20505         the build-webkit --help case.
20506
20507         We should also move the code in build-webkit that now uses .webkit.config
20508         to detect clean builds, to use .qmake.cache, since we now store the same
20509         thing there.
20510
20511         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
20512
20513         Reviewed by Tor Arne Vestbø.
20514
20515         * DumpRenderTree/qt/DumpRenderTree.pro:
20516         * QtTestBrowser/QtTestBrowser.pro:
20517         * Scripts/webkitdirs.pm:
20518         (qtFeatureDefaults):
20519         (buildQMakeProjects):
20520         * Tools.pro:
20521         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
20522         * WebKitTestRunner/InjectedBundle/Target.pri:
20523         * WebKitTestRunner/Target.pri:
20524         * qmake/.qmake.conf: Added.
20525         * qmake/configure.pro:
20526         * qmake/mkspecs/features/default_post.prf:
20527         * qmake/mkspecs/features/default_pre.prf:
20528         * qmake/mkspecs/features/features.prf:
20529
20530 2012-07-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>  Joel Dillon <joel.dillon@codethink.co.uk>
20531
20532         [Qt][Win] Fix broken QtWebKit5.lib linking
20533         https://bugs.webkit.org/show_bug.cgi?id=88321
20534
20535         Reviewed by Kenneth Rohde Christiansen.
20536
20537         On windows the import/export definition is part of the symbol's signature.
20538         Define STATICALLY_LINKED_WITH_$$library for each dependend module
20539         that is being linked statically to make sure that they can be linked together
20540         later on.
20541
20542         Also do not compile Assertions.cpp in DumpRenderTree anymore since all the
20543         used symbols are exported and it would cause a duplicate symbols error.
20544
20545         * DumpRenderTree/qt/DumpRenderTree.pro:
20546         * qmake/mkspecs/features/default_post.prf:
20547
20548 2012-07-03  Szilard Ledan  <szledan@inf.u-szeged.hu>
20549
20550         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
20551         https://bugs.webkit.org/show_bug.cgi?id=89001
20552
20553         Reviewed by Csaba Osztrogonác.
20554
20555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
20556         (UploadBuiltProduct.__init__):
20557         (UploadTestResults.__init__):
20558         (ExtractTestResults.__init__):
20559         (Factory.__init__):
20560         (BuildFactory.__init__):
20561         (TestFactory.__init__):
20562         (BuildAndTestFactory.__init__):
20563         (BuildAndPerfTestFactory.__init__):
20564         (BuildAndPerfTestWebKit2Factory.__init__):
20565         (DownloadAndPerfTestFactory.__init__):
20566
20567 2012-07-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
20568
20569         Update unit test after r121724.
20570         https://bugs.webkit.org/show_bug.cgi?id=90444
20571
20572         Reviewed by Csaba Osztrogonác.
20573
20574         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
20575         (GardeningServerTest.test_rebaseline_new_port):
20576
20577 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
20578
20579         Unreviewed, rolling out r121749.
20580         http://trac.webkit.org/changeset/121749
20581         https://bugs.webkit.org/show_bug.cgi?id=90441
20582
20583         Tests crash on the paralel NRWT Qt bot (Requested by Ossy on
20584         #webkit).
20585
20586         * Scripts/webkitpy/layout_tests/port/qt.py:
20587         (QtPort._build_driver):
20588         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
20589         (XvfbDriver._start):
20590         (XvfbDriver._start.x_filter):
20591         (XvfbDriver.stop):
20592
20593 2012-07-03  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
20594
20595         [NRWT] XvfbDriver should choose the next free display
20596         https://bugs.webkit.org/show_bug.cgi?id=88414
20597
20598         Reviewed by Dirk Pranke.
20599
20600         * Scripts/webkitpy/layout_tests/port/qt.py:
20601         (QtPort._driver_class):
20602         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
20603         (XvfbDriver.__init__):
20604         (XvfbDriver._start):
20605         (XvfbDriver._start.next_free_id):
20606         (XvfbDriver.stop):
20607
20608 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
20609
20610         [EFL] Enable MICRODATA support
20611         https://bugs.webkit.org/show_bug.cgi?id=90377
20612
20613         Reviewed by Kenneth Rohde Christiansen.
20614
20615         Turn on MICRODATA flag for EFL port by default.
20616
20617         * Scripts/webkitperl/FeatureList.pm:
20618
20619 2012-07-02  George Staikos  <staikos@webkit.org>
20620
20621         [BlackBerry] Enable scoped style for BlackBerry.
20622         https://bugs.webkit.org/show_bug.cgi?id=90418
20623
20624         Reviewed by Rob Buis.
20625
20626         * Scripts/webkitperl/FeatureList.pm:
20627
20628 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
20629
20630         [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
20631         https://bugs.webkit.org/show_bug.cgi?id=90271
20632
20633         Reviewed by George Staikos.
20634
20635         RIM PR #154707
20636
20637         Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
20638         defined by default.
20639         We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
20640         need to rebuild webkit before running DRT.
20641
20642         * Scripts/webkitdirs.pm:
20643         (blackberryCMakeArguments):
20644
20645 2012-07-02  Ojan Vafai  <ojan@chromium.org>
20646
20647         webkit-patch rebaseline-expectations should share code with rebaseline-all
20648         https://bugs.webkit.org/show_bug.cgi?id=90413
20649
20650         Reviewed by Dirk Pranke.
20651
20652         Make them share code. In addition to reducing code duplication this makes
20653         rebaseline-expectations considerably faster by rebaselining in parallel.
20654
20655         * Scripts/webkitpy/tool/commands/rebaseline.py:
20656         (AbstractParallelRebaselineCommand):
20657         (AbstractParallelRebaselineCommand._run_webkit_patch):
20658         (AbstractParallelRebaselineCommand._rebaseline):
20659         (RebaselineJson):
20660         (RebaselineJson.execute):
20661         (RebaselineExpectations):
20662         (RebaselineExpectations._update_expectations_file):
20663         (RebaselineExpectations._tests_to_rebaseline):
20664         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
20665         (RebaselineExpectations.execute):
20666         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
20667         (test_rebaseline_all):
20668         (test_rebaseline_expectations.run_in_parallel):
20669         (test_rebaseline_expectations):
20670
20671 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
20672
20673         [BlackBerry] Update DumpRenderTree to have it work interactively in parallel
20674         https://bugs.webkit.org/show_bug.cgi?id=88326
20675
20676         Reviewed by Rob Buis.
20677
20678         1. Test name is sent to torch-launcher via PPS message(from host machine).
20679            So we get test list by monitoring and receiving PPS message instead of
20680            reading file index.drt.
20681         2. Torch-launcher create a <test file>.done file when it finished a test.
20682         3. We don't need to search for Ref-tests in DumpRenderTree.cpp any more. NRWT
20683            will get them for us.
20684
20685         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
20686         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
20687         (BlackBerry::WebKit::DumpRenderTree::doneDrt):
20688         (BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
20689         (BlackBerry::WebKit::DumpRenderTree::ensurePPS):
20690         (WebKit):
20691         (BlackBerry::WebKit::DumpRenderTree::handlePPSData):
20692         (BlackBerry::WebKit::DumpRenderTree::waitForTest):
20693         (BlackBerry::WebKit::DumpRenderTree::runTests):
20694         (BlackBerry::WebKit::DumpRenderTree::dump):
20695         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
20696         (DumpRenderTree):
20697
20698 2012-07-02  Adam Barth  <abarth@webkit.org>
20699
20700         Remove flashplugin-installer from the EWS image because it causes some tests to crash
20701         https://bugs.webkit.org/show_bug.cgi?id=90403
20702
20703         Reviewed by Tony Chang.
20704
20705         * EWSTools/cold-boot.sh:
20706
20707 2012-07-02  Leandro Gracia Gil  <leandrogracia@chromium.org>
20708
20709         [Chromium] Implement a Layout Test for editing/SurroundingText
20710         https://bugs.webkit.org/show_bug.cgi?id=82461
20711
20712         Reviewed by Ryosuke Niwa.
20713
20714         Add a new method to the layout test controller in order to retrieve the
20715         text surrounding a provided element.
20716
20717         * DumpRenderTree/chromium/LayoutTestController.cpp:
20718         (LayoutTestController::LayoutTestController):
20719         (LayoutTestController::textSurroundingElement):
20720         * DumpRenderTree/chromium/LayoutTestController.h:
20721         (LayoutTestController):
20722
20723 2012-07-02  Ojan Vafai  <ojan@chromium.org>
20724
20725         Delete unused rebaseline method in gardeningserver.py
20726         https://bugs.webkit.org/show_bug.cgi?id=90396
20727
20728         Reviewed by Eric Seidel.
20729
20730         As best I can tell, the only usage was in this unittest.
20731
20732         * Scripts/webkitpy/tool/servers/gardeningserver.py:
20733         (GardeningHTTPRequestHandler.updateexpectations):
20734         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
20735         (GardeningServerTest.test_rebaseline_new_port):
20736
20737 2012-07-02  Csaba Osztrogonác  <ossy@webkit.org>
20738
20739         REGRESSION(r121497): It switched off and broke many unittests
20740         https://bugs.webkit.org/show_bug.cgi?id=90371
20741
20742         Reviewed by Adam Barth.
20743
20744         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
20745         (ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
20746         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
20747         (ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
20748         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
20749         (PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.
20750
20751 2012-07-02  Ojan Vafai  <ojan@chromium.org>
20752
20753         Move rebaseline-all command from the gardening-server down into webkit-patch
20754         https://bugs.webkit.org/show_bug.cgi?id=90395
20755
20756         Reviewed by Adam Barth.
20757
20758         This is just moving code. It it in preparation for making rebaseline-expectations
20759         use the same code in order to get the parallelism benefits and reduces the amount
20760         of code we have for doing rebaselines.
20761
20762         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
20763         (CheckoutTest.test_apply_patch):
20764         Updated due to the change to executive_mock.
20765         * Scripts/webkitpy/common/system/executive_mock.py:
20766         (MockExecutive.run_command):
20767         Update to print out the input passed to stdin.
20768         * Scripts/webkitpy/tool/commands/download_unittest.py:
20769         Updated due to executive_mock change.
20770         * Scripts/webkitpy/tool/commands/rebaseline.py:
20771         (RebaselineAll):
20772         (RebaselineAll._run_webkit_patch):
20773         (RebaselineAll._builders_to_fetch_from):
20774         (RebaselineAll._rebaseline_commands):
20775         (RebaselineAll._files_to_add):
20776         (RebaselineAll._optimize_baselines):
20777         (RebaselineAll._rebaseline):
20778         (RebaselineAll.execute):
20779         All this code is just copy-pasted except for mechanical changes
20780         (e.g. self.server.tool --> self._tool) and the reading in of the 
20781         JSON from stdin instead of the post body.
20782         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
20783         (test_rebaseline_all):
20784         Copied the test-case out of gardeningserver_unittest.py.
20785         * Scripts/webkitpy/tool/servers/gardeningserver.py:
20786         (GardeningHTTPRequestHandler):
20787         (GardeningHTTPRequestHandler.rebaseline):
20788         (GardeningHTTPRequestHandler.rebaselineall):
20789         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
20790         (GardeningServerTest.test_rebaselineall):
20791         (GardeningServerTest.test_rebaselineall.run_command):
20792
20793 2012-07-02  Ojan Vafai  <ojan@chromium.org>
20794
20795         Remove Leopard support from the flakiness dashboard
20796         https://bugs.webkit.org/show_bug.cgi?id=90390
20797
20798         Reviewed by Adam Barth.
20799
20800         * TestResultServer/static-dashboards/flakiness_dashboard.js:
20801         (nonChromiumPlatform):
20802         (chromiumPlatform):
20803         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
20804         (test):
20805         * TestResultServer/static-dashboards/run-embedded-unittests.html:
20806         * TestResultServer/static-dashboards/run-unittests.html:
20807
20808 2012-07-02  Ojan Vafai  <ojan@chromium.org>
20809
20810         Fix posting from garden-o-matic. This broke in moving away from jquery's ajax method
20811         in http://trac.webkit.org/changeset/121617.
20812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
20813
20814 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
20815
20816         [GTK] Read fonts path when running layout tests from alternative fonts dir when main dir doesn't exist
20817         https://bugs.webkit.org/show_bug.cgi?id=89437
20818
20819         Reviewed by Martin Robinson.
20820
20821         If main fonts directory doesn't exist, try with an alternative
20822         fonts directory at build directory.
20823
20824         * DumpRenderTree/gtk/DumpRenderTree.cpp:
20825         (getOutputDir):
20826         (getFontsPath):
20827         (initializeFonts):
20828         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
20829         (WTR::getOutputDir):
20830         (WTR):
20831         (WTR::getFontsPath):
20832         (WTR::inititializeFontConfigSetting):
20833
20834 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
20835
20836         [GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
20837         https://bugs.webkit.org/show_bug.cgi?id=89435
20838
20839         Reviewed by Martin Robinson.
20840
20841         * Scripts/new-run-webkit-tests: Don't run the tests with the
20842         jhbuild wrapper if there isn't a Dependencies directory inside the
20843         build directory.
20844
20845 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
20846
20847         [Qt] Simplify detection of non-installed module file
20848
20849         Has the additional advantage that we do not rely on additional information.
20850
20851         Reviewed by Tor Arne Vestbø.
20852
20853         * qmake/qt_webkit.pri:
20854
20855 2012-07-01  Christophe Dumez  <christophe.dumez@intel.com>
20856
20857         [EFL] Add Gamepad support
20858         https://bugs.webkit.org/show_bug.cgi?id=90170
20859
20860         Reviewed by Kenneth Rohde Christiansen.
20861
20862         * Scripts/webkitperl/FeatureList.pm: Turn on GAMEPAD flag
20863         by default for EFL port.
20864         * efl/jhbuild.modules: Bump dependency versions of EFL libs
20865         since the latest Eeze is required for gamepad support.
20866
20867 2012-07-01  Adam Barth  <abarth@webkit.org>
20868
20869         Unreviewed.
20870
20871         Using the default start cylinder for fdisk causes a warning about the
20872         partition not starting on physical sector boundary.  The Ubuntu forums
20873         recommend using a number that's divisible by 8, which is what we do in
20874         this patch.
20875
20876         * EWSTools/cold-boot.sh:
20877
20878 2012-07-01  Adam Barth  <abarth@webkit.org>
20879
20880         Unreviewed.
20881
20882         It turns out we need to use Ubuntu 10.04 to get the right image results
20883         for chromium-linux. This patch updates our scripts to be compatible
20884         with Ubuntu 10.04.
20885
20886         * EWSTools/cold-boot.sh:
20887             - fdisk doesn't have p and 1 as default commands in 10.04.
20888         * EWSTools/start-queue.sh:
20889             - git doesn't understanding the -B argument in 10.04. We've been
20890               using this change locally on the EC2 bots for a while.
20891
20892 2012-07-01  Adam Barth  <abarth@webkit.org>
20893
20894         Unreviewed.
20895
20896         * EWSTools/boot.sh:
20897             - We need to start the screen in detached mode so that we can run
20898               it remotely via ssh.
20899
20900 2012-07-01  Adam Barth  <abarth@webkit.org>
20901
20902         Unreviewed.
20903
20904         * EWSTools/cold-boot.sh:
20905             - Turns out we need to sudo this command in order for it to
20906               actually dimiss the EULA screen. :)
20907
20908 2012-06-29  Adam Barth  <abarth@webkit.org>
20909
20910         Turns out we need zip too.
20911
20912         * EWSTools/cold-boot.sh:
20913
20914 2012-06-29  Adam Barth  <abarth@webkit.org>
20915
20916         Add a cold-boot.sh script for the EWS
20917         https://bugs.webkit.org/show_bug.cgi?id=90330
20918
20919         Unreviewed.
20920
20921         * EWSTools/cold-boot.sh: Added.
20922             - This script can take us from a cold GCE instance to a running EWS
20923               bot in one fell swoop.
20924         * EWSTools/start-queue.sh:
20925             - The if-block at the top of this script was causing trouble. I
20926               removed it from the bots a while ago. Now that we're using SVN to
20927               cold-boot the EWS bots, we need to make this change in the repo.
20928
20929 2012-06-29  Luiz Agostini  <luiz.agostini@nokia.com>
20930
20931         [Qt][WK2] Private non-QtQuick API
20932         https://bugs.webkit.org/show_bug.cgi?id=84532
20933
20934         MiniBrowserRaw is an usage example for the QRawWebView API.
20935         It is only an example and is not fully implemented.
20936
20937         Reviewed by Noam Rosenthal.
20938
20939         * MiniBrowser/qt/raw/DerivedSources.pri: Added.
20940         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Added.
20941         * MiniBrowser/qt/raw/Target.pri: Added.
20942         * MiniBrowser/qt/raw/View.cpp: Added.
20943         * MiniBrowser/qt/raw/View.h: Added.
20944         * Scripts/webkitpy/style/checker.py:
20945         * Tools.pro:
20946
20947 2012-06-29  Ojan Vafai  <ojan@chromium.org>
20948
20949         Remove leopard bots from garden-o-matic
20950         https://bugs.webkit.org/show_bug.cgi?id=90328
20951
20952         Reviewed by Adam Barth.
20953
20954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
20955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
20956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
20957
20958 2012-06-29  Ojan Vafai  <ojan@chromium.org>
20959
20960         garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url')
20961         https://bugs.webkit.org/show_bug.cgi?id=90243
20962
20963         Reviewed by Dirk Pranke.
20964
20965         jQuery was trying to be too smart and parsing the jsonp as json because of it's content-type.
20966         Excise jQuery and just use XHR directly since it's easier to maintain something where we control it
20967         all.
20968
20969         Not really sure how to unittest this. I tested it all manually of course.
20970
20971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
20972         Made net.ajax a drop-in replacement for the features of $.ajax that we were using.
20973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
20974         Not related to this patch, but figured I'd update the failing test while I was at it.
20975
20976 2012-06-29  Yaron Friedman  <yfriedman@chromium.org>
20977
20978         Fix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id=88134
20979         https://bugs.webkit.org/show_bug.cgi?id=90309
20980
20981         Reviewed by Adam Barth.
20982
20983         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
20984         (ChromiumAndroidPort.start_http_server):
20985
20986 2012-06-29  James Weatherall  <wez@chromium.org>
20987
20988         NPObjectWrapper may not address all window script object lifetime issues
20989         https://bugs.webkit.org/show_bug.cgi?id=85679
20990
20991         TestNetscapePlugin now has a leak-window-scriptable-object test which takes a reference to the window script object, and a second reference to it via the "self" property, and does not release those references. This is used to simulate a leaky plugin in layout tests of the NPAPI scripting interface glue code.
20992
20993         Reviewed by Nate Chapin.
20994
20995         * DumpRenderTree/DumpRenderTree.gypi:
20996         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
20997         (PluginTest::NPN_GetProperty):
20998         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
20999         (PluginTest):
21000         * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Added.
21001         (LeakWindowScriptableObject):
21002         (LeakWindowScriptableObject::LeakWindowScriptableObject):
21003         (LeakWindowScriptableObject::NPP_New):
21004
21005 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
21006
21007         webkitpy: add comment about how determine_full_port_name() works for apple ports, fix -wk2 bug
21008         https://bugs.webkit.org/show_bug.cgi?id=90314
21009
21010         Reviewed by Ojan Vafai.
21011
21012         Add comments and fix a bug in how we would handle the mac-wk2
21013         and win-wk2 port names after confusion around in bug 90312 :).
21014
21015         * Scripts/webkitpy/layout_tests/port/apple.py:
21016         (ApplePort.determine_full_port_name):
21017
21018 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
21019
21020         webkitpy: remove support for mac leopard from chromium configurations
21021         https://bugs.webkit.org/show_bug.cgi?id=90313
21022
21023         Reviewed by Tony Chang.
21024
21025         Google has shipped the last version of Chrome that will support
21026         Mac OS 10.5 (Leopard), and we no longer have bots that run this
21027         configuration, so we're removing support for it.
21028
21029         A subsequent change will remove the baselines in platform/chromium-mac-leopard.
21030
21031         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
21032         (BaselineOptimizerTest.test_complex_shadowing):
21033         * Scripts/webkitpy/layout_tests/port/builders.py:
21034         * Scripts/webkitpy/layout_tests/port/chromium.py:
21035         (ChromiumPort):
21036         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
21037         (ChromiumMacPort):
21038         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
21039         (ChromiumMacPortTest.test_versions):
21040         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
21041         (FactoryTest.test_mac):
21042         (FactoryTest.test_chromium_mac):
21043         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
21044         (test_rebaseline_and_copy_test_with_lion_result):
21045
21046 2012-06-29  Ojan Vafai  <ojan@chromium.org>
21047
21048         Fix optimize-baselines to not move baselines from win to win-7sp0
21049         https://bugs.webkit.org/show_bug.cgi?id=90312
21050
21051         Reviewed by Dirk Pranke.
21052
21053         It used to consider win-7sp0 as the common directory for all the Apple
21054         windows ports and incorrectly move results out of win.
21055
21056         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
21057         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
21058         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
21059         (BaselineOptimizerTest.test_common_directory_includes_root):
21060
21061 2012-06-28  Ojan Vafai  <ojan@chromium.org>
21062
21063         Fix rebaselining for Qt and Apple ports
21064         https://bugs.webkit.org/show_bug.cgi?id=90204
21065
21066         Reviewed by Dirk Pranke.
21067
21068         -Apporpriately put wk2 results in the -wk2 directories.
21069         -Since Qt and Apple-Win don't have bots that correspond to the
21070         platform/qt and platform/win directories, we need to fudge it
21071         and always put the results in those directories for those ports.
21072
21073         * Scripts/webkitpy/layout_tests/port/builders.py:
21074         (rebaseline_override_dir):
21075         * Scripts/webkitpy/layout_tests/port/factory.py:
21076         (_builder_options):
21077         Identify webkit2 builders by the WK2 in the builder name.
21078         * Scripts/webkitpy/tool/commands/rebaseline.py:
21079         (RebaselineTest._baseline_directory):
21080         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
21081         (TestRebaseline.test_baseline_directory):
21082
21083 2012-06-29  Zoltan Horvath  <zoltan@webkit.org>
21084
21085         Add support for --force parameter to run-performance-tests
21086         https://bugs.webkit.org/show_bug.cgi?id=90279
21087
21088         Reviewed by Dirk Pranke.
21089
21090         It's helpful to be able to run tests from the Skipped list of the performance tests.
21091
21092         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
21093         (PerfTestsRunner._parse_args):
21094         (PerfTestsRunner._collect_tests):
21095         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.
21096         (test_collect_tests_with_skipped_list):
21097
21098 2012-06-29  Tony Chang  <tony@chromium.org>
21099
21100         [GTK] Enable CSS grid layout LayoutTests on GTK+
21101         https://bugs.webkit.org/show_bug.cgi?id=90226
21102
21103         Reviewed by Martin Robinson.
21104
21105         This feature is disabled via Settings by default, but for testing,
21106         we enable it using layoutTestController.overridePreferences. Add the
21107         necessary plumbing for DRT.
21108
21109         WTR already works because support was added for Apple Mac earlier.
21110
21111         * DumpRenderTree/gtk/DumpRenderTree.cpp:
21112         (resetDefaultsToConsistentValues): Feature is off by default.
21113         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
21114         (LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.
21115
21116 2012-06-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
21117
21118         [Qt] Added Qt port for garden-o-matic.
21119         https://bugs.webkit.org/show_bug.cgi?id=82719
21120
21121         Reviewed by Adam Barth.
21122
21123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
21124         (.):
21125
21126 2012-06-29  Balazs Kelemen  <kbalazs@webkit.org>
21127
21128         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
21129         https://bugs.webkit.org/show_bug.cgi?id=90262
21130
21131         Reviewed by Alexey Proskuryakov.
21132
21133         Now that we decided to not support v8 in WebKit2
21134         we can get rid of using DumpRenderTreeSupportQt
21135         in WebKitTestRunner.
21136
21137         * Tools.pro:
21138         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
21139         (WTR::InjectedBundlePage::resetAfterTest):
21140         (WTR::InjectedBundlePage::didClearWindowForFrame):
21141         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
21142
21143 2012-06-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
21144
21145         Revert r121540, it broke most Qt builds
21146
21147         * qmake/mkspecs/features/default_post.prf:
21148         * qmake/mkspecs/features/functions.prf:
21149
21150 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
21151
21152         [Qt] Make build-webkit reject uknown configurations, eg. --profile
21153
21154         The qmake-based buildsystem doesn't support it.
21155
21156         Reviewed by Tor Arne Vestbø.
21157
21158         * Scripts/webkitdirs.pm:
21159         (buildQMakeProjects):
21160
21161 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
21162
21163         [Qt] Don't add Qt module dependencies in features.prf
21164
21165         The required dependencies are already added in WebCore.pri.
21166
21167         Reviewed by Tor Arne Vestbø.
21168
21169         * qmake/mkspecs/features/features.prf:
21170
21171 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
21172
21173         [Qt] Use LIBS_PRIVATE instead of putting dependencies into LIBS
21174
21175         Reviewed by Tor Arne Vestbø..
21176
21177         * qmake/mkspecs/features/default_post.prf:
21178         * qmake/mkspecs/features/functions.prf:
21179
21180 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
21181
21182         DOMHTMLCollection::item may return a wrong element after namedItem is called
21183         https://bugs.webkit.org/show_bug.cgi?id=90240
21184
21185         Reviewed by Antti Koivisto.
21186
21187         Add a WebKit API test since namedItem is not used in the JS/V8 binding code.
21188
21189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21190         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.html: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html.
21191         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm.
21192         (TestWebKitAPI::TEST):
21193
21194 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
21195
21196         nrwt: remove the 'google-chrome' port code
21197         https://bugs.webkit.org/show_bug.cgi?id=88824
21198
21199         Reviewed by Ojan Vafai.
21200
21201         NRWT now supports passing additional baseline directories
21202         and expectations files on the command line, so there's no need
21203         to support the concept of a 'google-chrome' port directly.
21204
21205         * Scripts/webkitpy/layout_tests/port/base.py:
21206         (Port.path_to_test_expectations_file):
21207         * Scripts/webkitpy/layout_tests/port/builders.py:
21208         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
21209         (ChromiumMacPort.__init__):
21210         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
21211         (ChromiumWinPort.__init__):
21212         * Scripts/webkitpy/layout_tests/port/factory.py:
21213         (PortFactory):
21214         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
21215         (FactoryTest.test_win):
21216         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Removed.
21217         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: Removed.
21218
21219 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
21220
21221         nrwt: clean up how arguments are passed to workers
21222         https://bugs.webkit.org/show_bug.cgi?id=90126
21223
21224         Reviewed by Ojan Vafai.
21225
21226         The way arguments are passed to workers has been crufty. It
21227         turns out it can be a lot cleaner via two things:
21228         1) using a factory method instead of instantiating objects
21229         directly in manager_worker_broker removes the need for passing
21230         'worker arguments' to the broker.
21231         2) it turns out that since mock hosts and test ports are purely
21232         in-memory constructions, they can be pickled and passed to child
21233         workers, meaning that the worker no longer needs hacky code to
21234         pass the port in a special case or to guess what to do if we
21235         don't have a host - all of the test-specific logic can move to
21236         the test file, where we can stub out the mock host's
21237         port_factory to return the same already-created port when it
21238         needs to be shared.
21239
21240         This change also moves WorkerException to manager_worker_broker.py
21241         where it belongs, and removes several useless tests that were
21242         just a maintenance burden (and would've needed rewriting when we
21243         change the rest of the broker implementation).
21244
21245         * Scripts/webkitpy/layout_tests/controllers/manager.py:
21246         (Manager._run_tests.worker_factory):
21247         (Manager._run_tests):
21248         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
21249         (get):
21250         (WorkerException):
21251         (AbstractWorker.__init__):
21252         (_ManagerConnection.__init__):
21253         (_ManagerConnection.start_worker):
21254         (_InlineManager.__init__):
21255         (_InlineManager.start_worker):
21256         (_MultiProcessManager._can_pickle_host):
21257         (_MultiProcessManager):
21258         (_MultiProcessManager.start_worker):
21259         (_WorkerConnection.__init__):
21260         (_InlineWorkerConnection.__init__):
21261         (_InlineWorkerConnection.join):
21262         (_InlineWorkerConnection.run):
21263         (_Process.run):
21264         (_MultiProcessWorkerConnection.__init__):
21265         (_MultiProcessWorkerConnection.start):
21266         (_MultiProcessWorkerConnection):
21267         (_MultiProcessWorkerConnection.run):
21268         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
21269         (_TestWorker.__init__):
21270         (_TestWorker.run):
21271         (_TestsMixin.test_name):
21272         (_TestsMixin.test_cancel):
21273         (_TestsMixin.test_done):
21274         (_TestsMixin.test_unknown_message):
21275         (InlineBrokerTests.setUp):
21276         (MultiProcessBrokerTests.setUp):
21277         * Scripts/webkitpy/layout_tests/controllers/worker.py:
21278         (Worker.__init__):
21279         (Worker.run):
21280         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Removed.
21281         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
21282         (passing_run):
21283         (logging_run):
21284         (run_and_capture):
21285         (MainTest.test_child_processes_2):
21286         (MainTest.test_child_processes_min):
21287         (MainTest.test_exception_raised):
21288         (MainTest.test_keyboard_interrupt):
21289         (MainTest.test_retrying_and_flaky_tests):
21290         (MainTest.test_run_order__inline):
21291
21292 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
21293
21294         nrwt: don't try to catch worker exceptions in run_webkit_tests.__main__
21295         https://bugs.webkit.org/show_bug.cgi?id=90125
21296
21297         Reviewed by Ojan Vafai.
21298
21299         It turns out run_webkit_tests.py wasn't really using
21300         WorkerException and the catch we had for it was pointless. I've
21301         removed the symbol import and moved it to the integration tests
21302         where it is needed. Eventually the definition of the exception
21303         moves to the broker module, and so minimizing the number of
21304         users of it is a good thing.
21305
21306         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21307         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
21308         (MainTest.test_exception_raised):
21309
21310 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
21311
21312         nrwt: clean up passing of log messages between processes
21313         https://bugs.webkit.org/show_bug.cgi?id=90123
21314
21315         Reviewed by Ojan Vafai.
21316
21317         It turns out log messages are perfectly picklable by themselves
21318         and contain the process id of the process that generated the
21319         message, so if we just pass the record from the worker to the
21320         manager and call logger.handle() in the manager, everything just
21321         works :).
21322
21323         The change is covered by existing tests.
21324
21325         * Scripts/webkitpy/layout_tests/controllers/manager.py:
21326         (Manager._log_messages):
21327         * Scripts/webkitpy/layout_tests/controllers/worker.py:
21328         (_WorkerLogHandler.emit):
21329         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
21330         (MeteredStream.__init__):
21331         (_LogHandler.emit):
21332
21333 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
21334
21335         add a pylint wrapper for linting python code
21336         https://bugs.webkit.org/show_bug.cgi?id=90232
21337
21338         Reviewed by Adam Barth.
21339
21340         Currently we use 'pep8' to check python code in
21341         check-webkit-style. pep8 is fast but simple; pylint is slower
21342         but has much more robust linting capabilities and will catch
21343         variable typos and all sorts of other things. Eventually we
21344         should switch check-webkit-style to use this, but our code is
21345         far from linting now so it needs to be cleaned up first.
21346
21347         This change adds the infrastructure and a wrapper so we can
21348         start doing that.
21349
21350         * Scripts/lint-webkitpy: Added.
21351         * Scripts/webkitpy/pylintrc: Added.
21352         * Scripts/webkitpy/thirdparty/__init__.py:
21353         (AutoinstallImportHook.find_module):
21354         (AutoinstallImportHook._install_pylint):
21355
21356 2012-06-28  Tony Chang  <tony@chromium.org>
21357
21358         [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
21359         https://bugs.webkit.org/show_bug.cgi?id=90215
21360
21361         Reviewed by Martin Robinson.
21362
21363         * DumpRenderTree/gtk/DumpRenderTree.cpp:
21364         (initializeFonts): Check for WEBKITOUTPUTDIR first.
21365         * Scripts/webkitpy/layout_tests/port/gtk.py:
21366         (GtkPort.setup_environ_for_server): Copy the environment variable to the child process.
21367         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
21368         (WTR::inititializeFontConfigSetting): Check for WEBKITOUTPUTDIR first.
21369
21370 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
21371
21372         derive ChromiumPort from WebKitPort in NRWT in order to support skipping tests if symbols are missing
21373         https://bugs.webkit.org/show_bug.cgi?id=89706
21374
21375         Reviewed by Ojan Vafai.
21376
21377         Try again to land the change first landed in r121363. This patch
21378         adds a bunch more tests and reworks the handling of
21379         port-specific default values for --pixel-tests and --time-out-ms
21380         to be more consistent (adding a default_pixel_tests() method,
21381         pushing the webkit default_timeout_ms() value up into base.py,
21382         and overriding it properly in the chromium and apple mac ports.
21383
21384         Also change the logic in
21385         run_webkit_tests._setup_derived_options() to not second-guess
21386         what the port wants the timeout value to be for debug builds;
21387         computing this in two different places led to several bugs.
21388
21389         This change also changes the Chromium unittest ports to derive
21390         from ChromiumPortTestCase instead of PortTestCase, so that we
21391         ensure that we're running the same tests on all port variants
21392         more easily. There's more cleanup that can be done here, but
21393         this is good enough for now
21394
21395         * Scripts/webkitpy/layout_tests/port/base.py:
21396         (Port.default_pixel_tests):
21397         (Port):
21398         (Port.default_timeout_ms):
21399         * Scripts/webkitpy/layout_tests/port/chromium.py:
21400         (ChromiumPort):
21401         (ChromiumPort.__init__):
21402         (ChromiumPort.default_pixel_tests):
21403         (ChromiumPort.default_timeout_ms):
21404         (ChromiumPort.driver_name):
21405         (ChromiumPort._driver_class):
21406         (ChromiumPort._missing_symbol_to_skipped_tests):
21407         (ChromiumPort.skipped_layout_tests):
21408         (ChromiumPort.setup_test_run):
21409         (ChromiumPort._path_to_image_diff):
21410         (ChromiumPort._convert_path):
21411         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
21412         (ChromiumAndroidPortTest):
21413         (ChromiumAndroidPortTest.test_expectations_files):
21414         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
21415         (ChromiumLinuxPort._modules_to_search_for_symbols):
21416         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
21417         (ChromiumLinuxPortTest):
21418         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
21419         (ChromiumMacPort._modules_to_search_for_symbols):
21420         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
21421         (ChromiumMacPortTest):
21422         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
21423         split off from chromium_unittest.
21424         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
21425         (ChromiumWinPort._modules_to_search_for_symbols):
21426         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
21427         (ChromiumWinTest):
21428         * Scripts/webkitpy/layout_tests/port/mac.py:
21429         (MacPort.default_timeout_ms):
21430         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
21431         (MacTest.test_default_timeout_ms):
21432         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
21433         (MockDRTPort.start_http_server):
21434         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
21435         (PortTestCase.test_default_timeout_ms):
21436         (PortTestCase):
21437         (PortTestCase.test_default_pixel_tests):
21438         * Scripts/webkitpy/layout_tests/port/test.py:
21439         (TestPort.default_pixel_tests):
21440         * Scripts/webkitpy/layout_tests/port/webkit.py:
21441         (WebKitPort._modules_to_search_for_symbols):
21442         (WebKitPort):
21443         (WebKitPort._symbols_string):
21444         (WebKitPort._skipped_tests_for_unsupported_features):
21445         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
21446         (TestWebKitPort._symbols_string):
21447         (TestWebKitPort._tests_for_disabled_features):
21448         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21449         (_set_up_derived_options):
21450
21451 2012-06-28  Joshua Bell  <jsbell@chromium.org>
21452
21453         run-bindings-tests should return non-zero exit code on test failure
21454         https://bugs.webkit.org/show_bug.cgi?id=90205
21455
21456         Reviewed by Adam Barth.
21457
21458         * Scripts/run-bindings-tests:
21459         (main):
21460
21461 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
21462
21463         [chromium] Reset the device scale factor to 1 before each test is run
21464         https://bugs.webkit.org/show_bug.cgi?id=90212
21465
21466         Reviewed by Adam Barth.
21467
21468         Some tests change the device scale factor, so this needs to be reset to
21469         1.0 at the start of each test to avoid test flakiness.
21470
21471         * DumpRenderTree/chromium/LayoutTestController.cpp:
21472         (LayoutTestController::reset):
21473
21474 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
21475
21476         Cleanup HTMLFormCollection
21477         https://bugs.webkit.org/show_bug.cgi?id=90111
21478
21479         Reviewed by Andreas Kling.
21480
21481         Add a WebKit API test using copy-paste design pattern per kling's request.
21482
21483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
21484         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html: Added.
21485         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm: Added.
21486         (-[HTMLFormCollectionNamedItemTest webView:didFinishLoadForFrame:]):
21487         (TestWebKitAPI):
21488         (TestWebKitAPI::TEST):
21489
21490 2012-06-28  Tim Horton  <timothy_horton@apple.com>
21491
21492         [mac] WKTR windows still don't stay off screen sometimes
21493         https://bugs.webkit.org/show_bug.cgi?id=90214
21494         <rdar://problem/11760263>
21495
21496         Reviewed by Simon Fraser.
21497
21498         In some cases, the system itself will consult [WebKitTestRunnerWindow frame], so we should refrain from
21499         overriding it and instead provide a different method to use when we want the web-facing "fake" window origin
21500         (for PlatformWebView::windowFrame()).
21501
21502         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
21503         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
21504         (WTR::PlatformWebView::windowFrame):
21505
21506 2012-06-28  Martin Robinson  <mrobinson@igalia.com>
21507
21508         [GTK] Add unit tests for GtkInputMethodFilter
21509         https://bugs.webkit.org/show_bug.cgi?id=88698
21510
21511         Reviewed by Carlos Garcia Campos.
21512
21513         Add unit tests for GtkInputMethodFilter in the WebCore platform layer.
21514         This change adds the TestGtk test suite which will be used for all non-API
21515         layer GTK unit tests.
21516
21517         * TestWebKitAPI/GNUmakefile.am: Update the build to include the new tests.
21518         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Added.
21519         (TestWebKitAPI::PlatformWebView::PlatformWebView): Remove the call to gtk_init here
21520         as it's now in main.cpp.
21521         * TestWebKitAPI/gtk/main.cpp: Change the g_type_init call to gtk_init, because now
21522         a majority of all unit tests depend on GTK+ being initialized.
21523
21524 2012-06-28  Christophe Dumez  <christophe.dumez@intel.com>
21525
21526         [EFL] Enable support for HTML5 datalist
21527         https://bugs.webkit.org/show_bug.cgi?id=90157
21528
21529         Reviewed by Martin Robinson.
21530
21531         Turn on DATALIST flag by default on EFL port to
21532         support HTML5 datalist tag.
21533
21534         * Scripts/webkitperl/FeatureList.pm:
21535
21536 2012-06-28  Tony Chang  <tony@chromium.org>
21537
21538         Enable CSS grid layout LayoutTests on platform Mac
21539         https://bugs.webkit.org/show_bug.cgi?id=90113
21540
21541         Reviewed by Ojan Vafai.
21542
21543         * DumpRenderTree/mac/DumpRenderTree.mm:
21544         (resetDefaultsToConsistentValues): Reset the value to NO between tests.
21545
21546 2012-06-28  Mike Fenton  <mifenton@rim.com>
21547
21548         [BlackBerry] Add watchlist options for Blackberry and editing.
21549         https://bugs.webkit.org/show_bug.cgi?id=90193
21550
21551         Unreviewed.
21552
21553         Add BlackBerry and Editing watchlist and monitor them.
21554
21555         * Scripts/webkitpy/common/config/watchlist:
21556
21557 2012-06-28  Tim Horton  <timothy_horton@apple.com>
21558
21559         Unreviewed, upgrade myself to a reviewer!
21560
21561         http://www.webkit.org/blog/2082/tim-horton-is-now-a-webkit-reviewer/
21562
21563         * Scripts/webkitpy/common/config/committers.py:
21564
21565 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
21566
21567         [Chromium] Chromium's LayoutTestController is missing setBackingScaleFactor
21568         https://bugs.webkit.org/show_bug.cgi?id=83635
21569
21570         Reviewed by Adam Barth.
21571
21572         Added InvokeCallbackTask, a new derived class of MethodTask. When
21573         setBackingScaleFactor is called, a call to setDeviceScaleFactor in
21574         WebView is made and then postTask is used to invoke the callback
21575         function specified in testRunner.setBackingScaleFactor. 
21576
21577         * DumpRenderTree/chromium/LayoutTestController.cpp:
21578         (LayoutTestController::LayoutTestController):
21579         (InvokeCallbackTask):
21580         (InvokeCallbackTask::InvokeCallbackTask):
21581         (InvokeCallbackTask::runIfValid):
21582         (LayoutTestController::setBackingScaleFactor):
21583         * DumpRenderTree/chromium/LayoutTestController.h:
21584         (LayoutTestController):
21585
21586 2012-06-28  Ojan Vafai  <ojan@chromium.org>
21587
21588         Make rebaseline-test and rebaseline-expectations work for non-Chromium ports
21589         https://bugs.webkit.org/show_bug.cgi?id=90186
21590
21591         Reviewed by Adam Barth.
21592
21593         This makes rebaselining work for all ports that have a TestExpectations file
21594         in the tree. I didn't test other ports.
21595
21596         This doesn't address 100% of the problem. The rebaseline code puts the expectations
21597         in the most specific directory and relies on optimize-baselines to merge baselines
21598         appropriately. This only works if every platform directory has an equivalent bot
21599         that runs the tests, which is not true for most ports.
21600
21601         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
21602         (Builder._revision_and_build_for_filename):
21603         Some bots have filenames that aren't revision/build number pairs
21604         e.g. they are random junk like aQhxvx. Handle this gracefully.
21605         (Builder._fetch_revision_to_build_map):
21606         (Builder._file_info_list_to_revision_to_build_list):
21607         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
21608         (BuilderTest.test_build_and_revision_for_filename):
21609         (BuilderTest.test_file_info_list_to_revision_to_build_list):
21610         * Scripts/webkitpy/layout_tests/port/builders.py:
21611         Update the list of builders. This list needs to be kept up
21612         to date for the rebaseline tool to work.
21613         * Scripts/webkitpy/tool/commands/rebaseline.py:
21614         (RebaselineTest._results_url):
21615         (RebaselineExpectations._run_webkit_patch):
21616         (RebaselineExpectations._rebaseline_port):
21617         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
21618         Qt port uses qmake to determine the right version. Systems without qmake correctly fallback
21619         to a specific version.
21620
21621 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
21622
21623         [Qt][NRWT] Fix baseline and skipped file search path.
21624         https://bugs.webkit.org/show_bug.cgi?id=89882
21625
21626         Unreviewed trivial typo fix after r121430.
21627
21628         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
21629         (QtPortTest._assert_search_path):
21630         (QtPortTest._assert_skipped_path):
21631
21632 2012-06-28  János Badics  <jbadics@inf.u-szeged.hu>
21633
21634         [Qt][NRWT] Fix baseline and skipped file search path.
21635         https://bugs.webkit.org/show_bug.cgi?id=89882
21636
21637         Reviewed by Csaba Osztrogonác.
21638
21639         * Scripts/webkitpy/layout_tests/port/qt.py:
21640         (QtPort._search_paths):
21641         (QtPort):
21642         (QtPort.baseline_search_path):
21643         (QtPort._skipped_file_search_paths):
21644         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
21645         (QtPortTest):
21646         (QtPortTest._assert_skipped_path):
21647         (QtPortTest.test_baseline_search_path):
21648         (QtPortTest.test_skipped_file_search_path):
21649
21650 2012-06-28  Alexander Pavlov  <apavlov@chromium.org>
21651
21652         [Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS)
21653         https://bugs.webkit.org/show_bug.cgi?id=90167
21654
21655         Reviewed by Csaba Osztrogonác.
21656
21657         DRT should remove user stylesheets from the page group when resetting before running another test.
21658
21659         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
21660         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
21661
21662 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
21663
21664         [Qt][DRT] Reset AcceleratedCompositingEnabled between tests
21665         https://bugs.webkit.org/show_bug.cgi?id=90164
21666
21667         Reviewed by Simon Hausmann.
21668
21669         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
21670         (WebCore::WebPage::resetSettings):
21671
21672 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
21673
21674         [Qt] Restore original value of mock scrollbars between tests
21675         https://bugs.webkit.org/show_bug.cgi?id=90155
21676
21677         Reviewed by Simon Hausmann.
21678
21679         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
21680         (WebCore::WebPage::resetSettings):
21681         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
21682         (LayoutTestController::setMockScrollbarsEnabled):
21683         * DumpRenderTree/qt/LayoutTestControllerQt.h:
21684         (LayoutTestController):
21685
21686 2012-06-27  Mark Rowe  <mrowe@apple.com>
21687
21688         <http://webkit.org/b/90096> Building within Xcode sometimes does a full rebuild after building via build-webkit
21689
21690         We need to ensure that build-webkit uses the same setting for SHARED_PRECOMPS_DIR
21691         as what Xcode itself will use when building, otherwise switching between the two
21692         can result in the precompiled headers being rebuilt and thus the entire world
21693         rebuilding.
21694
21695         Reviewed by Dan Bernstein.
21696
21697         * Scripts/webkitdirs.pm:
21698         (determineBaseProductDir):
21699
21700 2012-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
21701
21702         Unreviewed, rolling out r121363, r121367, r121384, and
21703         r121390.
21704         http://trac.webkit.org/changeset/121363
21705         http://trac.webkit.org/changeset/121367
21706         http://trac.webkit.org/changeset/121384
21707         http://trac.webkit.org/changeset/121390
21708         https://bugs.webkit.org/show_bug.cgi?id=90134
21709
21710         It broke debug NRWT on GTK and on Qt (Requested by Ossy_NIGHT
21711         on #webkit).
21712
21713         * Scripts/webkitpy/layout_tests/port/chromium.py:
21714         (ChromiumPort):
21715         (ChromiumPort.__init__):
21716         (ChromiumPort._check_file_exists):
21717         (ChromiumPort.default_results_directory):
21718         (ChromiumPort._driver_class):
21719         (ChromiumPort._build_path):
21720         (ChromiumPort._path_to_image_diff):
21721         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
21722         (ChromiumLinuxPort.baseline_search_path):
21723         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
21724         (ChromiumMacPort.baseline_search_path):
21725         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
21726         (ChromiumPortTest):
21727         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
21728         (ChromiumWinPort.baseline_search_path):
21729         * Scripts/webkitpy/layout_tests/port/webkit.py:
21730         (WebKitPort.__init__):
21731         (WebKitPort._webcore_symbols_string):
21732         (WebKitPort._skipped_tests_for_unsupported_features):
21733         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
21734         (TestWebKitPort._webcore_symbols_string):
21735         (WebKitPortUnitTests.test_default_options):
21736
21737 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
21738
21739         Fix typo in r121384 :(
21740
21741         Unreviewed, build fix.
21742
21743         * Scripts/webkitpy/layout_tests/port/webkit.py:
21744         (WebKitPort.default_test_timeout_ms):
21745
21746 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
21747
21748         nrwt: default timeout for debug bots broke in r121363
21749         https://bugs.webkit.org/show_bug.cgi?id=90112
21750
21751         Unreviewed, build fix.
21752
21753         I forgot to account for release and debug having different
21754         default values :(.
21755
21756         * Scripts/webkitpy/layout_tests/port/chromium.py:
21757         (ChromiumPort.default_test_timeout_ms):
21758         * Scripts/webkitpy/layout_tests/port/webkit.py:
21759         (WebKitPort):
21760         (WebKitPort.default_test_timeout_ms):
21761         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
21762         (WebKitPortUnitTests.test_default_options):
21763
21764 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
21765
21766         webkitpy: fix a couple of issues running under cygwin
21767         https://bugs.webkit.org/show_bug.cgi?id=90035
21768
21769         Reviewed by Eric Seidel.
21770
21771         These were causing unit tests to fail on cygwin (apple win bot).
21772
21773         * Scripts/webkitpy/layout_tests/port/chromium.py:
21774         * Scripts/webkitpy/performance_tests/perftest.py:
21775
21776 2012-06-27  Adam Barth  <abarth@webkit.org>
21777
21778         [Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available
21779         https://bugs.webkit.org/show_bug.cgi?id=89801
21780
21781         Reviewed by Nate Chapin.
21782
21783         Let's call SkUseTestFontConfigFile now that it exists.
21784
21785         * DumpRenderTree/chromium/TestShellAndroid.cpp:
21786         (platformInit):
21787
21788 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
21789
21790         Fix typo introduced in r121363.
21791
21792         Unreviewed, build fix.
21793
21794         * Scripts/webkitpy/layout_tests/port/webkit.py:
21795         (WebKitPort._symbols_string):
21796
21797 2012-06-27  Mark Hahnenberg  <mhahnenberg@apple.com>
21798
21799         Moving from committers to reviewers :-)
21800
21801         Rubber stamped by Filip Pizlo.
21802
21803         * Scripts/webkitpy/common/config/committers.py:
21804
21805 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
21806
21807         Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests
21808         https://bugs.webkit.org/show_bug.cgi?id=89706
21809
21810         Reviewed by Adam Barth.
21811
21812         Based on the original patch by Raymond Toy.
21813
21814         This patch changes ChromiumPort to derive from webkit.WebKitPort
21815         instead of base.Port. This is a long-awaited change and a
21816         precursor to merging base.Port and webkit.WebKitPort, but is
21817         driven by the desire to dynamically detect whether the MP3 and
21818         AAC codecs are compiled into DRT on Chromium, for which we
21819         wanted to re-use the existing logic in WebKit port for determine
21820         what to skip at compile time.
21821
21822         Most of the changes are shuffling things around so that we don't
21823         change any other logic and so we override the necessary methods
21824         in WebKitPort (and try to follow the same method definition
21825         order where possible).
21826
21827         Also, on the Chromium port the mp3 and aac codecs are actually
21828         defined in a separate library, so scanning webcore isn't
21829         sufficient. This patch generalizes the symbol lookup to handle
21830         multiple libraries, and uses different libraries as appropriate
21831         for Chromium.
21832
21833         The only functional/visible changes should be in the value
21834         returned for skipped_layout_tests().
21835
21836         * Scripts/webkitpy/layout_tests/port/chromium.py:
21837         (ChromiumPort):
21838         (ChromiumPort.__init__):
21839         (ChromiumPort.driver_name):
21840         (ChromiumPort._driver_class):
21841         (ChromiumPort._missing_symbol_to_skipped_tests):
21842         (ChromiumPort.skipped_layout_tests):
21843         (ChromiumPort.setup_test_run):
21844         (ChromiumPort._path_to_image_diff):
21845         (ChromiumPort._convert_path):
21846         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
21847         (ChromiumPortTest.test_missing_symbol_to_skipped_tests):
21848         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
21849         (ChromiumLinuxPort._modules_to_search_for_symbols):
21850         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
21851         (ChromiumLinuxPort._modules_to_search_for_symbols):
21852         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
21853         (ChromiumLinuxPort._modules_to_search_for_symbols):
21854         * Scripts/webkitpy/layout_tests/port/webkit.py:
21855         (WebKitPort):
21856         (WebKitPort.__init__):
21857         (WebKitPort._symbols_string):
21858         (WebKitPort._modules_to_search_for_symbols):
21859
21860 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
21861
21862         [Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
21863         https://bugs.webkit.org/show_bug.cgi?id=90081
21864
21865         Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.
21866
21867         Reviewed by Noam Rosenthal.
21868
21869         * qmake/mkspecs/features/features.prf:
21870
21871 2012-06-27  Sergio Villar Senin  <svillar@igalia.com>
21872
21873         [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
21874         https://bugs.webkit.org/show_bug.cgi?id=90061
21875
21876         Reviewed by Gustavo Noronha Silva.
21877
21878         Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
21879         this flag libtool tells the linker to set the rpath for the output
21880         file to the full path of the .libs directory, instead of using a
21881         wrapper script to set up the LD_LIBRARY_PATH. This will allow us
21882         to directly reuse builds in the pure testing bots.
21883
21884         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
21885
21886 2012-06-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
21887
21888         [Qt] No need to save and restore TEMPLATE in a function
21889
21890         This was a leftover from when the logic was not in its own function scope.
21891
21892         QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
21893         will surprisingly affect the global scope as well, so we have to save and restore it.
21894
21895         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
21896
21897         Reviewed by Tor Arne Vestbø.
21898
21899         * qmake/mkspecs/features/functions.prf:
21900
21901 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
21902
21903         [Qt] Fix lookup location for sqlite sources
21904
21905         Don't look in the install dir - we are unlikely to find anything there
21906         unless we are doing a developer build.
21907
21908         Reviewed by Tor Arne Vestbø.
21909
21910         * qmake/mkspecs/features/features.prf:
21911
21912 2012-06-27  Zan Dobersek  <zandobersek@gmail.com>
21913
21914         [Gtk] Add support for the Gamepad API
21915         https://bugs.webkit.org/show_bug.cgi?id=87503
21916
21917         Reviewed by Carlos Garcia Campos.
21918
21919         Enable the gamepad support for the GTK port.
21920
21921         * Scripts/webkitperl/FeatureList.pm:
21922
21923 2012-06-27  Ryosuke Niwa  <rniwa@webkit.org>
21924
21925         Fix gcc build after r121302
21926         https://bugs.webkit.org/show_bug.cgi?id=90055
21927
21928         Reviewed by Mark Rowe.
21929
21930         Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
21931
21932         It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
21933
21934         * TestWebKitAPI/Configurations/Base.xcconfig:
21935         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
21936         (TestWebKitAPI::AcceptsFirstMouse::runTest):
21937
21938 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
21939
21940         Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
21941         https://bugs.webkit.org/show_bug.cgi?id=89564
21942
21943         Reviewed by Tony Chang.
21944
21945         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
21946         (BuildStepsConstructorTest):
21947         (BuildStepsConstructorTest.generateTests):
21948         (BuildStepsConstructorTest.createTest):
21949         (BuildStepsConstructorTest.createTest.doTest):
21950
21951 2012-06-26  Mark Hahnenberg  <mhahnenberg@apple.com>
21952
21953         Add support for preciseTime() to WebKitTestRunner
21954         https://bugs.webkit.org/show_bug.cgi?id=90027
21955
21956         Reviewed by Darin Adler.
21957
21958         It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
21959
21960         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
21961         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 
21962         (WTR::LayoutTestController::preciseTime): 
21963         (WTR):
21964         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
21965         (LayoutTestController):
21966
21967 2012-06-26  Lucas Forschler  <lforschler@apple.com>
21968
21969       Teach the Apple port how to build the test tools in build-webkit
21970       https://bugs.webkit.org/show_bug.cgi?id=89540
21971
21972       Reviewed by Jon Lee & Simon Fraser.
21973
21974       * BuildSlaveSupport/build.webkit.org-config/master.cfg:
21975       (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
21976       (RunUnitTests.start): ditto
21977       * Scripts/build-webkit: add tools to the projects build list
21978
21979 2012-06-26  Ojan Vafai  <ojan@chromium.org>
21980
21981         Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
21982         https://bugs.webkit.org/show_bug.cgi?id=90025
21983
21984         Reviewed by Simon Fraser.
21985
21986         Move the chromium-specific filtering code into config.js and replace it with a method on each platform
21987         config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
21988
21989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
21990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
21991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
21992
21993 2012-06-26  Ojan Vafai  <ojan@chromium.org>
21994
21995         Fix failing garden-o-matic unittests
21996         https://bugs.webkit.org/show_bug.cgi?id=90021
21997
21998         Reviewed by Adam Barth.
21999
22000         These had all just fallen out of date.
22001
22002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
22003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
22004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
22005
22006 2012-06-26  Ojan Vafai  <ojan@chromium.org>
22007
22008         Fix platform picker change handler in garden-o-matic
22009         https://bugs.webkit.org/show_bug.cgi?id=90010
22010
22011         Reviewed by Simon Fraser.
22012
22013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
22014         The old code never worked. This is hard to test because change handlers require
22015         a user-initiated action and the code is changing the window's location, which would
22016         navigate the test page.
22017
22018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
22019         Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
22020         due to the large margin-bottom.
22021
22022 2012-06-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
22023
22024         webkitpy: Make webkit-patch patches-to-review useful
22025         https://bugs.webkit.org/show_bug.cgi?id=89470
22026
22027         Reviewed by Eric Seidel.
22028
22029         webkit-patch patches-to-review will now output the list of
22030         bugs with patches pending for review that has the user on CC,
22031         excluding patches with cq-, sorted by the age of the patch.
22032
22033         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
22034         (BugzillaQueries.fetch_bugs_from_review_queue):
22035         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
22036         (MockBugzillaQueries.fetch_bugs_from_review_queue):
22037         (MockBugzilla.__init__):
22038         (MockBugzilla.authenticate):
22039         * Scripts/webkitpy/tool/commands/queries.py:
22040         (PatchesToReview):
22041         (PatchesToReview.__init__):
22042         (PatchesToReview._print_report):
22043         (PatchesToReview._generate_report):
22044         (PatchesToReview.execute):
22045         * Scripts/webkitpy/tool/commands/queries_unittest.py:
22046         (QueryCommandsTest.test_patches_to_review):
22047
22048 2012-06-26  Dirk Pranke  <dpranke@chromium.org>
22049
22050         nrwt: broken for chromium on vista
22051         https://bugs.webkit.org/show_bug.cgi?id=89988
22052
22053         Reviewed by Tony Chang.
22054
22055         r121194 removed support for 'chromium-win-vista' as a separate
22056         port, but this actually prevented the code from running on vista
22057         at all, which is unduly harsh and broke the websocket tests on
22058         the (non-webkit) chromium bots that are still running on vista.
22059
22060         It's probably good enough to pretend that vista is win7 instead;
22061         some layout tests will still fail but at least things'll run.
22062
22063         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
22064         (ChromiumWinPort.determine_full_port_name):
22065         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
22066         (ChromiumWinTest.test_versions):
22067
22068 2012-06-26  Csaba Osztrogonác  <ossy@webkit.org>
22069
22070         master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
22071         https://bugs.webkit.org/show_bug.cgi?id=89215
22072
22073         We need it because it is deprecated and will be dropped in buildbot 0.8.7
22074
22075         Reviewed by Tony Chang.
22076
22077         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22078         (CheckOutSource.__init__):
22079         (Factory.__init__):
22080
22081 2012-06-26  Simon Hausmann  <simon.hausmann@nokia.com>
22082
22083         [Qt][Win] Symbols are not exported in QtWebKit5.dll
22084         https://bugs.webkit.org/show_bug.cgi?id=88873
22085
22086         Reviewed by Tor Arne Vestbø.
22087
22088         When linking the target dll make sure to re-export the symbols from
22089         the static libraries marked as export, with the help of a little python
22090         script and a qmake extra compiler.
22091
22092         * Scripts/generate-win32-export-forwards: Added.
22093         * qmake/mkspecs/features/win32/default_post.prf:
22094
22095 2012-06-25  Jocelyn Turcotte  <turcotte.j@gmail.com>
22096
22097         Add a note about hostname completion not working well with --cc completion
22098
22099         Reviewed by Simon Hausmann.
22100
22101         Hostname completion tries to resolve anything after an @ sign which is present
22102         in the completed list of contributor emails to CC.
22103
22104         * Scripts/webkit-tools-completion.sh:
22105
22106 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
22107
22108         Unreviewed, rolling out r121244.
22109         http://trac.webkit.org/changeset/121244
22110         https://bugs.webkit.org/show_bug.cgi?id=89966
22111
22112         skip list path is incorrect now. (Requested by Ossy on
22113         #webkit).
22114
22115         * Scripts/webkitpy/layout_tests/port/qt.py:
22116         (QtPort.baseline_search_path):
22117         (QtPort._skipped_file_search_paths):
22118         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
22119         (QtPortTest.test_baseline_search_path):
22120
22121 2012-06-26  János Badics  <jbadics@inf.u-szeged.hu>
22122
22123         [Qt][NRWT] Fix baseline and skipped file search path.
22124         https://bugs.webkit.org/show_bug.cgi?id=89882
22125
22126         Reviewed by Csaba Osztrogonác.
22127
22128         * Scripts/webkitpy/layout_tests/port/qt.py:
22129         (QtPort.baseline_search_path):
22130         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
22131         (QtPortTest.test_baseline_search_path):
22132
22133 2012-06-26  Tony Chang  <tony@chromium.org>
22134
22135         [Qt] Enable grid layout LayoutTests
22136         https://bugs.webkit.org/show_bug.cgi?id=89909
22137
22138         Reviewed by Csaba Osztrogonác.
22139
22140         These tests pass, we just need to hook up the overridePreference.
22141
22142         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
22143         (WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
22144         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
22145         (LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
22146
22147 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
22148
22149         Unreviewed, rolling out r121236.
22150         http://trac.webkit.org/changeset/121236
22151         https://bugs.webkit.org/show_bug.cgi?id=89956
22152
22153         It's broke the nrwt on qt and gtk platform (Requested by
22154         kkristof on #webkit).
22155
22156         * Scripts/webkitpy/layout_tests/port/qt.py:
22157         (QtPort._build_driver):
22158         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
22159         (XvfbDriver._start):
22160         (XvfbDriver._start.x_filter):
22161         (XvfbDriver.stop):
22162
22163 2012-06-26  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
22164
22165         [NRWT] XvfbDriver should choose the next free display
22166         https://bugs.webkit.org/show_bug.cgi?id=88414
22167
22168         Reviewed by Dirk Pranke.
22169
22170         * Scripts/webkitpy/layout_tests/port/qt.py:
22171         (QtPort._driver_class):
22172         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
22173         (XvfbDriver.__init__):
22174         (XvfbDriver._start):
22175         (XvfbDriver._start.next_free_id):
22176         (XvfbDriver.stop):
22177
22178 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
22179
22180         [Qt] Make it possible to build WebKit without QtWidgets
22181         https://bugs.webkit.org/show_bug.cgi?id=78109
22182
22183         Reviewed by Tor Arne Vestbø.
22184
22185         * Tools.pro: Disable various tools that depend on WK1.
22186         * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
22187         * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
22188         * qmake/mkspecs/modules/webkit1.prf: Added.
22189
22190 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
22191
22192         put vista back for chromium (non-webkit) bots ...
22193         https://bugs.webkit.org/show_bug.cgi?id=89929
22194
22195         Unreviewed, build fix.
22196
22197         Turns out we've only gotten rid of vista on the webkit tests so
22198         far. Put vista back for the other chromium bots ...
22199
22200         * TestResultServer/static-dashboards/flakiness_dashboard.js:
22201         (chromiumPlatform):
22202         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
22203         (test):
22204
22205 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
22206
22207         update flakiness dashboard after removing chromium-vista bots
22208         https://bugs.webkit.org/show_bug.cgi?id=89925
22209
22210         Unreviewed, build fix.
22211
22212         More changes missed in r121194 :(.
22213
22214         * TestResultServer/static-dashboards/flakiness_dashboard.js:
22215         (chromiumPlatform):
22216         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
22217         (test):
22218
22219 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
22220
22221         remove support for chromium vista from tools
22222         https://bugs.webkit.org/show_bug.cgi?id=89915
22223
22224         Reviewed by Tony Chang.
22225
22226         This change is all deleting code and updating tests to handle
22227         the configuration being gone. All tests now pass except for a
22228         few unittests for the flakiness dashboard which were failing
22229         before this patch.
22230
22231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
22232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
22233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
22234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
22235         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
22236         (BaselineOptimizerTest.test_complex_shadowing):
22237         * Scripts/webkitpy/layout_tests/port/builders.py:
22238         * Scripts/webkitpy/layout_tests/port/chromium.py:
22239         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
22240         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
22241         (ChromiumWinPort):
22242         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
22243         (ChromiumWinTest.test_versions):
22244         (ChromiumWinTest.test_baseline_path):
22245         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
22246         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
22247         (BuildCoverageExtrapolatorTest.test_extrapolate):
22248
22249 2012-06-25  Scott Graham  <scottmg@chromium.org>
22250
22251         [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
22252         https://bugs.webkit.org/show_bug.cgi?id=89907
22253
22254         Not reviewed. Fix build in Chromium.
22255
22256         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
22257         (WebThemeEngineDRTWin::getSize):
22258         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
22259         (WebThemeEngineDRTWin):
22260
22261 2012-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
22262
22263         [EFL] Implement Network Information API
22264         https://bugs.webkit.org/show_bug.cgi?id=87067
22265
22266         Reviewed by Kenneth Rohde Christiansen.
22267
22268         * efl/jhbuild.modules: Add eeze library dependency.
22269
22270 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
22271
22272         [Qt] Fix Win32 debug build
22273
22274         Reviewed by Tor Arne Vestbø.
22275
22276         Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
22277
22278         * qmake/mkspecs/features/unix/default_pre.prf:
22279         * qmake/mkspecs/features/win32/default_pre.prf: Added.
22280
22281 2012-06-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
22282
22283         [Qt] Enable <input type="color"> support by default
22284         https://bugs.webkit.org/show_bug.cgi?id=89653
22285
22286         Reviewed by Kenneth Rohde Christiansen.
22287
22288         This feature is complete for Qt WebKit2. Enabling by default
22289         will help to mature the implementation.
22290
22291         * Scripts/webkitperl/FeatureList.pm:
22292         * qmake/mkspecs/features/features.pri:
22293
22294 2012-06-24  Dan Bernstein  <mitz@apple.com>
22295
22296         Made debug-{minibrowser,safari,test-runner} work with LLDB.
22297
22298         Reviewed by Sam Weinig.
22299
22300         * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
22301         printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
22302         * Scripts/debug-safari: Ditto.
22303         * Scripts/debug-test-runner: Ditto.
22304         * Scripts/webkitdirs.pm:
22305         (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
22306         (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
22307         and to "gdb" otherwise.
22308         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
22309         --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
22310         (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
22311
22312 2012-06-24  Adam Barth  <abarth@webkit.org>
22313
22314         [Chromium] Release media resources after each LayoutTest on Android
22315         https://bugs.webkit.org/show_bug.cgi?id=89720
22316
22317         Reviewed by Eric Carlson.
22318
22319         The LayoutTests can hang when run on Android because we sometimes run
22320         out of media resources. This patch causes us to release our media
22321         resources after each test in order to avoid running out of this
22322         resource. In production, there are other mechanisms that manage this
22323         resource.
22324
22325         * DumpRenderTree/chromium/TestShell.cpp:
22326         (TestShell::resetTestController):
22327
22328 2012-06-23  Zan Dobersek  <zandobersek@gmail.com>
22329
22330         [Gtk] REGRESSION(r120918): Causes flaky DND tests
22331         https://bugs.webkit.org/show_bug.cgi?id=89770
22332
22333         Reviewed by Martin Robinson.
22334
22335         Connect to the run-file-chooser signal of the WebKitWebView and
22336         return TRUE so no file chooser dialog is run. This prevents certain
22337         test failures.
22338
22339         * DumpRenderTree/gtk/DumpRenderTree.cpp:
22340         (webViewRunFileChooser):
22341         (createWebView):
22342
22343 2012-06-23  Dan Bernstein  <mitz@apple.com>
22344
22345         debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
22346
22347         Reviewed by Sam Weinig.
22348
22349         * Scripts/webkitdirs.pm:
22350         (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
22351
22352 2012-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
22353
22354         Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
22355
22356         It fails always when running it in Xvfb.
22357
22358         * gtk/run-api-tests:
22359         (TestRunner):
22360
22361 2012-06-23  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
22362
22363         [GTK][WK2]Mis-spelt defaultWindowTitle
22364         https://bugs.webkit.org/show_bug.cgi?id=89808
22365
22366         Reviewed by Carlos Garcia Campos.
22367
22368         * MiniBrowser/gtk/BrowserWindow.c:
22369
22370 2012-06-23  Sergio Villar Senin  <svillar@igalia.com>
22371
22372         [GTK] Add a new webkit2 tests slave bot
22373         https://bugs.webkit.org/show_bug.cgi?id=89336
22374
22375         Reviewed by Csaba Osztrogonác.
22376
22377         Slave configuration for a new GTK 64 bit release bot that will run
22378         WebKit2 tests.
22379
22380         Also BuildAndTest now accepts the "triggers" parametter,
22381         this means that apart from building and testing it can trigger
22382         some other build/test sequences in other slaves.
22383
22384         * BuildSlaveSupport/build.webkit.org-config/config.json:
22385         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22386         (BuildAndTestFactory.__init__):
22387
22388 2012-06-23  Kwang Yul Seo  <skyul@company100.net>
22389
22390         Unreviewed. Update my email.
22391
22392         * Scripts/webkitpy/common/config/committers.py:
22393
22394 2012-06-22  Adam Barth  <abarth@webkit.org>
22395
22396         [Chromium] DumpRenderTree on Android needs to configure fonts for testing
22397         https://bugs.webkit.org/show_bug.cgi?id=89721
22398
22399         Reviewed by Nate Chapin.
22400
22401         This patch teaches DumpRenderTree to configure Skia to use the fallback
22402         fonts that the LayoutTests assume. This patch reduces the number result
22403         differences between chromium-android and chromium-linux.
22404
22405         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
22406         * DumpRenderTree/chromium/TestShellAndroid.cpp:
22407         (platformInit):
22408         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
22409         * DumpRenderTree/chromium/android_main_fonts.xml: Added.
22410         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
22411
22412 2012-06-22  Alexandru Chiculita  <achicu@adobe.com>
22413
22414         [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
22415         https://bugs.webkit.org/show_bug.cgi?id=89781
22416
22417         Reviewed by Dean Jackson.
22418
22419         Added CSS Shaders as enabled by default on Safari for Mac.
22420
22421         * Scripts/webkitperl/FeatureList.pm:
22422
22423 2012-06-22  Adam Barth  <abarth@webkit.org>
22424
22425         Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
22426         https://bugs.webkit.org/show_bug.cgi?id=89791
22427
22428         Reviewed by Dirk Pranke.
22429
22430         Downstream, the chromium-android port maintains a test expectations
22431         file to keep track of which tests pass or fail. That causes them to
22432         keep a patch in chromium_android.py in their branch.
22433
22434         This patch teaches chromium_android.py to use test_expectations_android.txt.
22435         We don't intend to use this file upstream, but having this code patch
22436         upstream lets us unfork webkitpy.
22437
22438         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
22439         (ChromiumAndroidPort.expectations_files):
22440
22441 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
22442
22443         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
22444         https://bugs.webkit.org/show_bug.cgi?id=89734
22445
22446         Reviewed by Ryosuke Niwa.
22447
22448         Fix a crash in ServerProcess if you called .pid() after it
22449         crashed during a write(). We had a test for this case but the
22450         test wasn't calling pid(), just has_crashed(). Fixed the problem
22451         and the test.
22452
22453         * Scripts/webkitpy/layout_tests/port/server_process.py:
22454         (ServerProcess.__init__):
22455         (ServerProcess.pid):
22456         (ServerProcess._start):
22457         (ServerProcess.stop):
22458         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
22459         (FakeServerProcess._start):
22460         (TestServerProcess.test_broken_pipe):
22461
22462 2012-06-22  Peter Beverloo  <peter@chromium.org>
22463
22464         [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
22465         https://bugs.webkit.org/show_bug.cgi?id=88853
22466
22467         Reviewed by Steve Block.
22468
22469         The Android exclusions were necessary to fix a gyp generation error, as
22470         the gcc_version variable wasn't being defined for Android. Remove these
22471         exceptions when Chromium is able to define the gcc_version variable.
22472
22473         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
22474
22475 2012-06-22  Mario Sanchez Prada  <msanchez@igalia.com>
22476
22477         Unreviewed gardening. Unskipping test passing after fixing bug 88419.
22478
22479         * gtk/run-api-tests:
22480         (TestRunner): Unskip WTF.HashMap.
22481
22482 2012-06-22  Zoltan Horvath  <zoltan@webkit.org>
22483
22484         [Qt] Allow DumpRenderTree to dump about:blank
22485         https://bugs.webkit.org/show_bug.cgi?id=89685
22486
22487         Reviewed by Ryosuke Niwa.
22488
22489         We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
22490         additionaly this behavior is required for running WTR performance tests.
22491
22492         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
22493         (WebCore::DumpRenderTree::processLine):
22494
22495 2012-06-21  Adam Barth  <abarth@webkit.org>
22496
22497         [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
22498         https://bugs.webkit.org/show_bug.cgi?id=89718
22499
22500         Reviewed by Kent Tamura.
22501
22502         We should reset this WebSetting to its default value so that it behaves
22503         consistently across tests.
22504
22505         * DumpRenderTree/chromium/WebPreferences.cpp:
22506         (WebPreferences::reset):
22507         (WebPreferences::applyTo):
22508         * DumpRenderTree/chromium/WebPreferences.h:
22509         (WebPreferences):
22510
22511 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
22512
22513         DRT/WTR python interface handles about:blank incorrectly
22514         https://bugs.webkit.org/show_bug.cgi?id=89563
22515
22516         Reviewed by Dirk Pranke.
22517
22518         Currently DRT/WTR python interface's _command_from_driver_input function
22519         puts the test directory path before about:blank. Remove this incorrect behavior.
22520
22521         * Scripts/webkitpy/layout_tests/port/webkit.py:
22522         (WebKitDriver._command_from_driver_input):
22523
22524 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
22525
22526         reenable perf tests on win
22527         https://bugs.webkit.org/show_bug.cgi?id=89690
22528
22529         Reviewed by Ryosuke Niwa.
22530
22531         Only the replay tests don't work, and those are disabled by
22532         default. This change also fixes the undefined _log reference
22533         that was causing a crash.
22534
22535         * Scripts/run-perf-tests:
22536
22537 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
22538
22539         Unreviewed, rolling out r120937.
22540         http://trac.webkit.org/changeset/120937
22541         https://bugs.webkit.org/show_bug.cgi?id=89679
22542
22543         This patch brought buildbot master down (Requested by svillar
22544         on #webkit).
22545
22546         * BuildSlaveSupport/build.webkit.org-config/config.json:
22547
22548 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
22549
22550         [GTK] Combine WebKit API tests into fewer binaries
22551         https://bugs.webkit.org/show_bug.cgi?id=88458
22552
22553         Reviewed by Carlos Garcia Campos.
22554
22555         Instead of creating one binary per-test file, create binaries for each
22556         category of tests. Right now this includes WTF and the WebKit2 C API,
22557         but later tests can be added for the GTK+ platform layer and the WebKit1
22558         and WebKit2 API layers.
22559
22560         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
22561           C API and one for WTF. Refresh the source list to ensure that new test are active.
22562         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
22563         concept of skipping a test and skipping a suite (program) of tests. Test cases are
22564         skipped because of legitimate failures, but entire programs are skipped because of
22565         problems in the harness. As of right now a test program is only skipped if the
22566         accessibility bus cannot be started.
22567         (SkippedTest.__init__): Make the test case a required argument and have one skipped
22568         test case per SkippedTest instance.
22569         (SkippedTest.__str__): Ditto.
22570         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
22571         in one directory. Reformat the test list to make it slightly easier to read.
22572         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
22573         test programs that are skipped.
22574         (TestRunner._setup_testing_environment): Use the new member.
22575         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
22576         the first SkippedTest that matches.
22577         (TestRunner._should_run_test_program): Take a look at the new member to make this
22578         decision.
22579         (TestRunner._run_test_command): Use the name test_program instead of test
22580         to disambiguate between test cases and test suites.
22581         (TestRunner._run_test_glib): ditto.
22582         (TestRunner._run_test_google): Ditto.
22583         (TestRunner._run_test): Ditto.
22584         (TestRunner.run_tests): Ditto.
22585
22586 2012-06-21  Yong Li  <yoli@rim.com>
22587
22588         Unreviewed. Moving myself from committer to reviewer.
22589
22590         * Scripts/webkitpy/common/config/committers.py:
22591
22592 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
22593
22594         [GTK] Add a new webkit2 tests slave bot
22595         https://bugs.webkit.org/show_bug.cgi?id=89336
22596
22597         Reviewed by Philippe Normand.
22598
22599         Slave configuration for a new GTK bot that will run WebKit2 tests.
22600
22601         * BuildSlaveSupport/build.webkit.org-config/config.json:
22602
22603 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
22604
22605         [Qt] Add a custom Color Chooser widget to MiniBrowser
22606         https://bugs.webkit.org/show_bug.cgi?id=87988
22607
22608         Reviewed by Alexis Menard.
22609
22610         Added custom color chooser example for the MiniBrowser.
22611
22612         * MiniBrowser/qt/MiniBrowser.qrc:
22613         * MiniBrowser/qt/qml/BrowserWindow.qml:
22614         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
22615
22616 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
22617
22618         Remove the warning "File not found" in MiniBrowser post-build event
22619         https://bugs.webkit.org/show_bug.cgi?id=89601
22620
22621         Reviewed by Adam Roben.
22622
22623         * MiniBrowser/MiniBrowserPostBuild.cmd:
22624
22625 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
22626
22627         [Qt] DRT in standalone mode hangs after the first test
22628         https://bugs.webkit.org/show_bug.cgi?id=89613
22629
22630         Reviewed by Csaba Osztrogonác.
22631
22632         Break an inline signal slot chain that ends up in setting
22633         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
22634         we emit done() which starts the chain that finishes in DumpRenderTree::open().
22635         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
22636         these two lines but it seems to be wrong in general to start the next load
22637         from this call chain. The server mode (when DRT is runned by the test harness)
22638         also uses a queued connection to read the next test from stdin.
22639
22640         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
22641         (WebCore::DumpRenderTree::processArgsLine):
22642
22643 2012-06-20  Hans Wennborg  <hans@chromium.org>
22644
22645         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
22646         https://bugs.webkit.org/show_bug.cgi?id=89217
22647
22648         Reviewed by Adam Barth.
22649
22650         Add a method for checking whether the mock speech
22651         recognition was aborted.
22652
22653         Also redo the way the mock posts tasks. Instead of posting them all at once,
22654         maintain an internal queue of task objects, and call postTask() for them
22655         once at the time. This means that for example when the page is navigated
22656         away and abort() is called, that call doesn't end up after a bunch
22657         of previously posted events on the event loop.
22658
22659         * DumpRenderTree/chromium/LayoutTestController.cpp:
22660         (LayoutTestController::LayoutTestController):
22661         (LayoutTestController::wasMockSpeechRecognitionAborted):
22662         * DumpRenderTree/chromium/LayoutTestController.h:
22663         (LayoutTestController):
22664         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
22665         (WebKit::ClientCallTask::ClientCallTask):
22666         (WebKit::ResultTask::ResultTask):
22667         (WebKit::NoMatchTask::NoMatchTask):
22668         (WebKit::ErrorTask::ErrorTask):
22669         (MockWebSpeechRecognizer::start):
22670         (MockWebSpeechRecognizer::abort):
22671         (MockWebSpeechRecognizer::setError):
22672         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
22673         (MockWebSpeechRecognizer::startTaskQueue):
22674         (MockWebSpeechRecognizer::StepTask::runIfValid):
22675         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
22676         (MockWebSpeechRecognizer::hasBeenAborted):
22677         (MockWebSpeechRecognizer):
22678         (MockWebSpeechRecognizer::taskList):
22679         (Task):
22680         (MockWebSpeechRecognizer::Task::Task):
22681         (MockWebSpeechRecognizer::Task::~Task):
22682         (StepTask):
22683         (MockWebSpeechRecognizer::StepTask::StepTask):
22684
22685 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
22686
22687         [GTK] Add support for window.showModalDialog in WebKit2GTK+
22688         https://bugs.webkit.org/show_bug.cgi?id=79500
22689
22690         Reviewed by Carlos Garcia Campos.
22691
22692         Add support for modal dialogs in GTK's MiniBrowser.
22693
22694         * MiniBrowser/gtk/BrowserWindow.c:
22695         (webViewRunAsModal):
22696         (webViewCreate):
22697         (webViewDecidePolicy):
22698         (browser_window_new):
22699         * MiniBrowser/gtk/BrowserWindow.h:
22700         * MiniBrowser/gtk/main.c:
22701         (createBrowserWindow):
22702
22703 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
22704
22705         [WinCairo] Unreviewed build fix.
22706         The wrapper script that launched new- and old-run-webkit-tests
22707         was discarding the --wincairo argument needed to get the proper
22708         test infrastructure to build under WinCairo.
22709
22710         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
22711         behavior to chain the --wincairo flag through to the new build
22712         and test scripts.
22713
22714 2012-06-20  Mark Rowe  <mrowe@apple.com>
22715
22716         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
22717
22718         Reviewed by Dan Bernstein.
22719
22720         * Scripts/webkitdirs.pm:
22721         (executableHasEntitlements):
22722         (safariPathFromSafariBundle):
22723
22724 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
22725
22726         Unreviewed, rolling out r120821.
22727         http://trac.webkit.org/changeset/120821
22728         https://bugs.webkit.org/show_bug.cgi?id=89605
22729
22730         It made duplicated reviewer entries (Requested by Ossy on
22731         #webkit).
22732
22733         * Scripts/webkitpy/common/checkout/changelog.py:
22734         (ChangeLog.set_reviewer):
22735         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
22736         (test_set_reviewer):
22737         (test_set_short_description_and_bug_url):
22738
22739 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
22740
22741         nrwt outputs empty files for wdiff output if wdiff is not installed
22742         https://bugs.webkit.org/show_bug.cgi?id=88709
22743
22744         Reviewed by Tony Chang.
22745
22746         Reviewed by Tony Chang.
22747
22748         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
22749         aren't available, and clean up the handling for them in the port
22750         code.
22751
22752         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
22753         (MainTest.test_output_diffs):
22754         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
22755         (TestResultWriter.create_text_diff_and_write_result):
22756         * Scripts/webkitpy/layout_tests/port/base.py:
22757         (Port.check_pretty_patch):
22758         (Port.check_wdiff):
22759         (Port._wdiff_missing_message):
22760         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
22761         (ChromiumLinuxPort.check_build):
22762         (ChromiumLinuxPort._wdiff_missing_message):
22763         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
22764         (ChromiumMacPort.check_build):
22765         (ChromiumMacPort):
22766         (ChromiumMacPort._wdiff_missing_message):
22767         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
22768         (ChromiumMacPortTest):
22769
22770 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
22771
22772         nrwt: fix unit tests for ensuring svn revision is correct
22773         https://bugs.webkit.org/show_bug.cgi?id=89498
22774
22775         Reviewed by Eric Seidel.
22776
22777         Reviewed by Eric Seidel.
22778
22779         Fix the unit tests for testing that we are embedding the SVN
22780         revision in the results json for NRWT properly; this was broken
22781         in r120646 but because the MockHost worked differently than the
22782         real one (by always initializing the MockSCM object) we didn't
22783         notice. Unfortunately, just changing the default breaks all
22784         sorts of unit tests ...
22785
22786         * Scripts/webkitpy/common/host_mock.py:
22787         (MockHost.__init__):
22788         (MockHost._initialize_scm):
22789         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
22790         (ResultSummaryTest.test_no_svn_revision):
22791         (ResultSummaryTest.test_svn_revision):
22792
22793 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
22794
22795         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
22796         https://bugs.webkit.org/show_bug.cgi?id=69360
22797
22798         Reviewed by Eric Seidel.
22799
22800         Reviewed by Eric Seidel.
22801
22802         Propagate the 'port_implementation' part of the platform (i.e.,
22803         gtk,qt,chromium) to webkit-build-directory so that we can pick
22804         up the gtk-specific handling of WEBKITOUTPUTDIR ...
22805
22806         I didn't write any additional tests for this; testing it
22807         properly is an integration test between the python code and the
22808         perl code, which I verified by hand.
22809
22810         * Scripts/webkitpy/layout_tests/port/base.py:
22811         (Port.__init__):
22812         * Scripts/webkitpy/layout_tests/port/config.py:
22813         (Config.__init__):
22814         (Config.build_directory):
22815         * Scripts/webkitpy/layout_tests/port/config_mock.py:
22816         (MockConfig.__init__):
22817         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
22818         (ConfigTest.test_build_directory_passes_port_implementation):
22819
22820 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
22821
22822         Fix import sorting missed in r120846
22823
22824         Reviewed by Tony Chang.
22825
22826         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
22827
22828 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
22829
22830         Fix chromium win http servers after breakage introduced in r120846.
22831
22832         Unreviewed, build fix.
22833
22834         * Scripts/webkitpy/layout_tests/port/base.py:
22835         (Port.to.start_http_server):
22836         * Scripts/webkitpy/layout_tests/servers/http_server.py:
22837         (Lighttpd.__init__):
22838
22839 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
22840
22841         tweak output of webkit-patch print-{baselines,expectations}
22842         https://bugs.webkit.org/show_bug.cgi?id=89588
22843
22844         Reviewed by Tony Chang.
22845
22846         Minor tweaks to the output to make it more readable, including
22847         turning off csv by default for print-baselines with multiple ports.
22848
22849         * Scripts/webkitpy/layout_tests/port/test.py:
22850         (TestPort):
22851         * Scripts/webkitpy/tool/commands/queries.py:
22852         (PrintExpectations.execute):
22853         (PrintBaselines.execute):
22854         * Scripts/webkitpy/tool/commands/queries_unittest.py:
22855         (PrintExpectationsTest.run_test):
22856         (PrintExpectationsTest.test_multiple):
22857         (PrintBaselinesTest.setUp):
22858         (PrintBaselinesTest.test_multiple):
22859
22860 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
22861
22862         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
22863         https://bugs.webkit.org/show_bug.cgi?id=88134
22864
22865         Reviewed by Tony Chang.
22866
22867         Change NRWT to spin up 2*min(child_processes, locked_shards)
22868         http servers by default so that we are less likely to get a
22869         bunch of http timeouts at the beginning of a test run.
22870
22871         Note that I had to tweak executive_mock to support mocked stderr
22872         because the apache_http_server code reads stderr when starting a
22873         process to ensure it started okay.
22874
22875         * Scripts/webkitpy/common/system/executive_mock.py:
22876         (MockProcess.__init__):
22877         * Scripts/webkitpy/common/system/outputcapture.py:
22878         * Scripts/webkitpy/layout_tests/controllers/manager.py:
22879         (Manager._run_tests):
22880         (Manager.start_servers_with_lock):
22881         * Scripts/webkitpy/layout_tests/port/base.py:
22882         (Port.to.start_http_server):
22883         * Scripts/webkitpy/layout_tests/port/test.py:
22884         (TestPort.start_http_server):
22885         (TestPort._path_to_apache):
22886         (TestPort):
22887         (TestPort._path_to_apache_config_file):
22888         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
22889         (LayoutTestApacheHttpd.__init__):
22890         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
22891         (LayoutTestApacheHttpd.__init__):
22892         * Scripts/webkitpy/layout_tests/servers/http_server.py:
22893         (Lighttpd.__init__):
22894         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
22895         (HttpServerBase.__init__):
22896
22897 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
22898
22899         Unreviewed: Back out accidentally checked in debug print which broke a test
22900
22901         * Scripts/webkitpy/performance_tests/perftest.py:
22902         (PerfTest.parse_output):
22903
22904 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
22905
22906         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
22907         https://bugs.webkit.org/show_bug.cgi?id=78789
22908
22909         Reviewed by Ryosuke Niwa.
22910
22911         Updated parser to include fps as a valid unit.
22912
22913         * Scripts/webkitpy/performance_tests/perftest.py:
22914         (PerfTest):
22915         (PerfTest.parse_output):
22916
22917 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
22918
22919         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
22920         https://bugs.webkit.org/show_bug.cgi?id=67935
22921
22922         Reviewed by Ryosuke Niwa.
22923
22924         * Scripts/webkitpy/common/checkout/changelog.py:
22925         (ChangeLog.set_reviewer):
22926         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
22927         (test_set_reviewer):
22928         (test_set_short_description_and_bug_url):
22929
22930 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
22931
22932         Unreviewed trivial permissions fix.
22933
22934         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
22935
22936 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
22937
22938         [EFL][Regression] Build break after r120786
22939         https://bugs.webkit.org/show_bug.cgi?id=89549
22940
22941         Unreviewed build fix for Efl port.
22942
22943         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
22944
22945 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
22946
22947         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
22948         https://bugs.webkit.org/show_bug.cgi?id=64489
22949
22950         Reviewed by Tony Chang.
22951
22952         This change changes NRWT so that we don't start the websocket
22953         server if we aren't running websocket tests and don't start the
22954         HTTP server if we aren't running http tests.
22955         
22956         * Scripts/webkitpy/layout_tests/controllers/manager.py:
22957         (Manager._websocket_tests):
22958         (Manager.start_servers_with_lock):
22959         (Manager.stop_servers_with_lock):
22960         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
22961         (ManagerTest.test_servers_started):
22962
22963 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
22964
22965         test-webkitpy: add a -p flag to pass through captured output to enable debugging
22966         https://bugs.webkit.org/show_bug.cgi?id=89158
22967
22968         Reviewed by Eric Seidel.
22969
22970         Normally when outputcapture runs it intercepts stdout/stderr,
22971         which makes running under the debugger difficult and mostly
22972         pointless (since you can't see any output). This change adds a
22973         flag to test-webkitpy (-p) that will cause outputcapture to pass
22974         through the output as well as capture it.
22975
22976         * Scripts/webkitpy/common/system/outputcapture.py:
22977         (OutputCapture.stream_wrapper):
22978         (OutputCapture._capture_output_with_name):
22979         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
22980         (OutputCaptureTest.setUp):
22981         * Scripts/webkitpy/test/main.py:
22982         (Tester._parse_args):
22983         (Tester._run_tests):
22984         (Tester._log_exception):
22985         (_CaptureAndPassThroughStream):
22986         (_CaptureAndPassThroughStream.__init__):
22987         (_CaptureAndPassThroughStream.write):
22988         (_CaptureAndPassThroughStream._message_is_from_pdb):
22989         (_CaptureAndPassThroughStream.flush):
22990         (_CaptureAndPassThroughStream.getvalue):
22991
22992 2012-06-19  Adam Barth  <abarth@webkit.org>
22993
22994         garden-o-matic fails to rebaseline tests with MISSING results
22995         https://bugs.webkit.org/show_bug.cgi?id=89521
22996
22997         Reviewed by Kenneth Russell.
22998
22999         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
23000
23001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
23002
23003 2012-06-19  Adam Barth  <abarth@webkit.org>
23004
23005         svn.delete_list fails to delete empty parent directories
23006         https://bugs.webkit.org/show_bug.cgi?id=89520
23007
23008         Reviewed by Dirk Pranke.
23009
23010         These functions were calling scm.delete and scm.add, which already
23011         delete the parent directory. We'd get an exception when we tried to
23012         delete the parent directory again.
23013
23014         * Scripts/webkitpy/common/checkout/scm/svn.py:
23015         (SVN._add_parent_directories):
23016         (SVN._delete_parent_directories):
23017
23018 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
23019
23020         webkitpy: Simplify fetch_bugs_matching_search()
23021         https://bugs.webkit.org/show_bug.cgi?id=89497
23022
23023         Reviewed by Adam Barth.
23024
23025         Removed parameter with default value. It's not being used
23026         and the handling of the parameter was wrong. Saves a check.
23027
23028         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
23029         (BugzillaQueries.fetch_bugs_matching_search):
23030         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
23031         (MockBugzillaQueries.fetch_bugs_matching_search):
23032
23033 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
23034
23035         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
23036         https://bugs.webkit.org/show_bug.cgi?id=89522
23037
23038         Reviewed by Eric Seidel.
23039
23040         They were no longer being used. No tests necessary.
23041
23042         * Scripts/webkitpy/layout_tests/port/chromium.py:
23043
23044 2012-06-19  Adam Barth  <abarth@webkit.org>
23045
23046         Missing results aren't shown in garden-o-matic
23047
23048         Reviewed by Kenneth Russell.
23049
23050         Previously we didn't know to look for text and image results when the
23051         bot told us that results were missing.
23052
23053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
23054
23055 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
23056
23057         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
23058
23059         Unreviewed, build fix.
23060
23061         It turns out that we store the svn revision two different ways
23062         in the JSON, and I only caught one of them :(. This should fix
23063         the other.
23064
23065         Also, this part of the code is poorly tested. I will investigate
23066         adding at least a basic test for this in a separate fix.
23067
23068         * Scripts/webkitpy/layout_tests/controllers/manager.py:
23069         (summarize_results):
23070
23071 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
23072
23073         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
23074         https://bugs.webkit.org/show_bug.cgi?id=78127
23075
23076         Reviewed by Ryosuke Niwa.
23077
23078         Add the --add-platform-exceptions flag from ORWT, and ensure
23079         that --new-baseline is equivalent to --reset-results
23080         --add-platform-exceptions. Also fix the default logic for where to
23081         put PNGs and render tree dumps if --new-test-results is true:
23082         if --add-platform-exceptions is False, baselines should go in
23083         the least-specific platform directory (e.g., platform/mac)
23084         rather than the most-specific (platform/mac-snowleopard).
23085
23086         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
23087         (SingleTestRunner):
23088         (SingleTestRunner.run):
23089         (SingleTestRunner._run_rebaseline):
23090         (SingleTestRunner._add_missing_baselines):
23091         (SingleTestRunner._location_for_new_baseline):
23092         (SingleTestRunner._overwrite_baselines):
23093         (SingleTestRunner._save_baseline_data):
23094         * Scripts/webkitpy/layout_tests/port/base.py:
23095         (Port.baseline_path):
23096         (Port):
23097         (Port.baseline_platform_dir):
23098         (Port.baseline_version_dir):
23099         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
23100         (_set_up_derived_options):
23101         (parse_args):
23102         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
23103         (RebaselineTest.assertBaselines):
23104         (RebaselineTest.test_reset_results):
23105         (RebaselineTest.test_missing_results):
23106         (RebaselineTest.test_new_baseline):
23107
23108 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
23109
23110         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
23111         https://bugs.webkit.org/show_bug.cgi?id=81379
23112
23113         Reviewed by Eric Seidel.
23114
23115         The 'free memory' calculation we were running on the mac seemed
23116         to underestimate how many children we can run in parallel, and
23117         it was complex. This patch replaces that calculation with a
23118         simpler one that reserves 2GB for overhead and assumes 256MB per
23119         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
23120
23121         Also, there was a bug where we were truncating the memory
23122         installed on the machine to 4GB by casting to an int instead of
23123         a long; this was probably the source of some of the earlier
23124         problems when using total memory.
23125
23126         This patch also removes the no-longer-needed restrictions on the
23127         number of workers on beefy Lion boxes for both Apple Mac and Chromium
23128         Mac; we should now use all of the cores by default.
23129
23130         The memory calculations have only been implemented on the mac;
23131         having the calculation in base.default_child_processes() was IMO
23132         misleading, and so this patch also moves the computation into
23133         the MacPort. I have not heard of the # of workers being an issue
23134         on any other ports, so this should be fine.
23135
23136         * Scripts/webkitpy/common/system/platforminfo.py:
23137         (PlatformInfo.total_bytes_memory):
23138         * Scripts/webkitpy/common/system/platforminfo_mock.py:
23139         (PlatformInfo.total_bytes_memory):
23140         (PlatformInfo.total_bytes_memory):
23141         (PlatformInfo._win_version_tuple_from_cmd):
23142         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
23143         (TestPlatformInfo.test_total_bytes_memory):
23144         * Scripts/webkitpy/layout_tests/port/base.py:
23145         (Port.default_child_processes):
23146         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
23147         (PortTest.test_default_child_processes):
23148         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
23149         (ChromiumMacPort.operating_system):
23150         * Scripts/webkitpy/layout_tests/port/mac.py:
23151         (MacPort.default_child_processes):
23152         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
23153         (TestMacPort.test_default_child_processes):
23154
23155 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
23156
23157         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
23158         https://bugs.webkit.org/show_bug.cgi?id=85446
23159
23160         Reviewed by Simon Fraser.
23161
23162         Embed whether pixel testing was enabled into the results.json.
23163
23164         * Scripts/webkitpy/layout_tests/controllers/manager.py:
23165         (summarize_results):
23166
23167 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
23168
23169         [Qt] Modify HTTPS port to 8443 for performance tests
23170         https://bugs.webkit.org/show_bug.cgi?id=89442
23171
23172         Reviewed by Ryosuke Niwa.
23173
23174         We should be consistent with the default HTTPS port and with the changelog of r119188.
23175
23176         * Scripts/webkitpy/performance_tests/perftest.py:
23177         (ReplayServer.__init__):
23178
23179 2012-06-19  Mike West  <mkwst@chromium.org>
23180
23181         Introduce ENABLE_CSP_NEXT configuration flag.
23182         https://bugs.webkit.org/show_bug.cgi?id=89300
23183
23184         Reviewed by Adam Barth.
23185
23186         The 1.0 draft of the Content Security Policy spec is just about to
23187         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
23188         this ENABLE flag, disabled by default.
23189
23190         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
23191
23192         * Scripts/webkitperl/FeatureList.pm:
23193         * qmake/mkspecs/features/features.pri:
23194
23195 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
23196
23197         [EFL] EFL's LayoutTestController does not support setTextDirection
23198         https://bugs.webkit.org/show_bug.cgi?id=87481
23199
23200         Reviewed by Hajime Morita.
23201
23202         Implement setTextDirection in EFL's LayoutTestController and
23203         properly reset its value between test cases to avoid flakiness.
23204
23205         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
23206         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
23207         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
23208         (LayoutTestController::setTextDirection):
23209
23210 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
23211
23212         [Qt] Temporarily disable xvfb driver in nrwt
23213         https://bugs.webkit.org/show_bug.cgi?id=88414
23214
23215         Reviewed by Csaba Osztrogonác.
23216
23217         * Scripts/webkitpy/layout_tests/port/qt.py:
23218         (QtPort._build_driver):
23219
23220 2012-06-18  Joone Hur  <joone.hur@intel.com>
23221
23222         [EFL] Fontconfig can't be linked properly
23223         https://bugs.webkit.org/show_bug.cgi?id=89418
23224
23225         Unreviewed build fix.
23226
23227         Make Fontconfig be linked correctly.
23228
23229         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
23230
23231 2012-06-18  Joone Hur  <joone.hur@intel.com>
23232
23233         Unreviewed. Updating email for committers.py script.
23234
23235         * Scripts/webkitpy/common/config/committers.py:
23236
23237 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
23238
23239         Fix a typo that caused TestFailures to have a syntax error.
23240         
23241         Sadly TestFailures is broken for another reason now too:
23242         https://bugs.webkit.org/show_bug.cgi?id=89419
23243
23244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
23245         (ViewController.prototype._domForBuildName):
23246
23247 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
23248
23249         Provide bug links for suspicious commits
23250         https://bugs.webkit.org/show_bug.cgi?id=89408
23251         
23252         Reviewed by Adam Barth.
23253
23254         Add links to bugs for the suspicious commits if we have bug data.
23255
23256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
23257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
23258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
23259         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
23260         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
23261
23262 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
23263
23264         [Chromium] DeviceOrientation Cleanup
23265         https://bugs.webkit.org/show_bug.cgi?id=89354
23266
23267         Reviewed by Kent Tamura.
23268
23269         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
23270         (WebViewHost):
23271
23272 2012-06-18  James Robinson  <jamesr@chromium.org>
23273
23274         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
23275         https://bugs.webkit.org/show_bug.cgi?id=89254
23276
23277         Reviewed by Adrienne Walker.
23278
23279         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
23280         upstream.
23281
23282         * DumpRenderTree/chromium/WebViewHost.cpp:
23283         (WebViewHost::createGraphicsContext3D):
23284
23285 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
23286
23287         Minor fix suggested by Adam Barth.
23288
23289         Use $(this._what).empty(); rather than removing children one at a time.
23290         For some reason removeAllChildren() is undefined on this node.
23291         
23292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
23293
23294 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
23295
23296         Show TOT revision in garden-o-matic, and make the revisions into links
23297         https://bugs.webkit.org/show_bug.cgi?id=89396
23298
23299         Reviewed by Adam Barth.
23300
23301         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
23302         where the revisions are links to trac.
23303         
23304         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
23305         the knock-on effect of flipping the target and href attributes for anchors in some test output.
23306
23307         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
23308         (ViewController.prototype._displayTesters.updateList.list):
23309         (ViewController.prototype._displayTesters.updateList):
23310         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
23311         (ViewController.prototype._domForRegressionRange):
23312         (ViewController.prototype._domForAuxiliaryUIElements):
23313         (ViewController.prototype._domForBuildName):
23314         (ViewController.prototype):
23315         (ViewController.prototype.):
23316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
23317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
23318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
23319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
23320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
23321
23322 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
23323
23324         REGRESSION(r100558): NRWT should work without SVN or GIT
23325         https://bugs.webkit.org/show_bug.cgi?id=76630
23326
23327         Reviewed by Dirk Pranke.
23328
23329         NRWT is not supposed to have a requirement that we have an
23330         actual SVN or Git checkout, and we were unnecessarily
23331         initializing the checkout. This patch removes that line :).
23332
23333         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
23334         (main):
23335
23336 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
23337
23338         [garden-o-matic] Add support for the GTK builders
23339         https://bugs.webkit.org/show_bug.cgi?id=89360
23340
23341         Reviewed by Adam Barth.
23342
23343         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
23344         both get their data from build.webkit.org.
23345
23346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
23347         (.):
23348
23349 2012-06-18  Nico Weber  <thakis@chromium.org>
23350
23351         [chromium/mac] Unbreak smooth scrolling.
23352         https://bugs.webkit.org/show_bug.cgi?id=89327
23353
23354         Reviewed by Dimitri Glazkov.
23355
23356         Broken by Sam in r115589 / r115591.
23357
23358         * DumpRenderTree/mac/DumpRenderTree.mm:
23359         (resetDefaultsToConsistentValues):
23360         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
23361         (TestWebKitAPI::InjectedBundleController::platformInitialize):
23362         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
23363         (WTR::InjectedBundle::platformInitialize):
23364
23365 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
23366
23367         Unreviewed, rolling out r120541, r120547, and r120548.
23368         http://trac.webkit.org/changeset/120541
23369         http://trac.webkit.org/changeset/120547
23370         http://trac.webkit.org/changeset/120548
23371         https://bugs.webkit.org/show_bug.cgi?id=89383
23372
23373         This approach doesn't work for WebKit2 (Requested by abarth on
23374         #webkit).
23375
23376         * DumpRenderTree/LayoutTestController.cpp:
23377         (setBackingScaleFactorCallback):
23378         (LayoutTestController::staticFunctions):
23379         * DumpRenderTree/LayoutTestController.h:
23380         (LayoutTestController):
23381         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
23382         (LayoutTestController::setBackingScaleFactor):
23383         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
23384         (LayoutTestController::setBackingScaleFactor):
23385         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
23386         (LayoutTestController::setBackingScaleFactor):
23387         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
23388         (LayoutTestController::setBackingScaleFactor):
23389         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
23390         (LayoutTestController::setBackingScaleFactor):
23391         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
23392         (LayoutTestController::setBackingScaleFactor):
23393         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
23394         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
23395         (WTR::InjectedBundle::didReceiveMessage):
23396         (WTR::InjectedBundle::postSetBackingScaleFactor):
23397         (WTR):
23398         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
23399         (InjectedBundle):
23400         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
23401         (WTR::LayoutTestController::setBackingScaleFactor):
23402         (WTR):
23403         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
23404         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
23405         (LayoutTestController):
23406         * WebKitTestRunner/TestInvocation.cpp:
23407         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
23408
23409 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
23410
23411         REGRESSION(r120546): It made 3 webkitpy tests fail
23412         https://bugs.webkit.org/show_bug.cgi?id=89332
23413
23414         Reviewed by Adam Barth.
23415
23416         Update the BaselineOptimizer unittest after r120546.
23417
23418         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
23419         (BaselineOptimizerTest.test_no_add_mac_future):
23420         (BaselineOptimizerTest.test_mac_future):
23421         (BaselineOptimizerTest.test_complex_shadowing):
23422
23423 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
23424
23425         new-run-webkit-tests output gets confused when logging
23426         https://bugs.webkit.org/show_bug.cgi?id=63793
23427
23428         Reviewed by Adam Barth.
23429
23430         Ship all of the log messages generated in the worker back
23431         to the manager; this allows the messages to be properly
23432         serialized to stderr and for the meter to flush its output correctly.
23433
23434         Note however that this will likely result in messages to be
23435         logged out of order between workers; I'm not sure that there's
23436         an easy way to fix this short of buffering a potentially
23437         unbounded amount of data. It might be better to just log through
23438         stderr unless we're in 'metering' mode, but it's also worth
23439         noting that we already get messages out of order through stderr
23440         on Windows.
23441
23442         * Scripts/webkitpy/layout_tests/controllers/manager.py:
23443         (Manager.handle_done):
23444         (Manager.handle_finished_test):
23445         (Manager._log_messages):
23446         * Scripts/webkitpy/layout_tests/controllers/worker.py:
23447         (Worker.__init__):
23448         (Worker._set_up_logging):
23449         (Worker.run):
23450         (Worker._run_test):
23451         (Worker.cleanup):
23452         (Worker.run_single_test):
23453         (_WorkerLogHandler):
23454         (_WorkerLogHandler.__init__):
23455         (_WorkerLogHandler.emit):
23456         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
23457         (MeteredStream.write):
23458         (MeteredStream.writeln):
23459         * Scripts/webkitpy/layout_tests/views/printing.py:
23460         (Printer.writeln):
23461
23462 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
23463
23464         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
23465         https://bugs.webkit.org/show_bug.cgi?id=89362
23466
23467         Reviewed by Simon Fraser.
23468
23469         Replace white spaces, braces and dots in the builder name with underscores. This
23470         way the JQuery tabs will be properly matched with the according container.
23471
23472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
23473
23474 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
23475
23476         nrwt: metered output doesn't handle ^C cleanly
23477         https://bugs.webkit.org/show_bug.cgi?id=89249
23478
23479         Reviewed by Tony Chang.
23480
23481         If you ctrl-c a running nrwt (w/o --verbose), then all but
23482         two characters of the last update are erased, and then we print
23483         "interrupted, exiting" as an update, which itself then gets
23484         erased. Fix this so that we flush the meter (making the last
23485         update persistent, so that we print the ^C for a visual clue),
23486         print the interrupt message, and move on ...
23487
23488         * Scripts/webkitpy/layout_tests/controllers/manager.py:
23489         (Manager._run_tests):
23490         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
23491         (MeteredStream.flush):
23492         * Scripts/webkitpy/layout_tests/views/printing.py:
23493         (Printer._write):
23494         (Printer):
23495         (Printer.flush):
23496
23497 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
23498
23499         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
23500         https://bugs.webkit.org/show_bug.cgi?id=89228
23501
23502         Reviewed by Tony Chang.
23503
23504         * DumpRenderTree/chromium/LayoutTestController.cpp:
23505         * DumpRenderTree/chromium/TestShellAndroid.cpp:
23506
23507 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
23508
23509         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
23510         https://bugs.webkit.org/show_bug.cgi?id=89226
23511
23512         Reviewed by Martin Robinson.
23513
23514         Implement increment() and decrement() functions in term of the AtkValue interface,
23515         instead of using DumpRenderTreeSupportGtk helper class.
23516
23517         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
23518         (AccessibilityUIElement::intValue):
23519         (AccessibilityUIElement::minValue):
23520         (AccessibilityUIElement::maxValue):
23521         (alterCurrentValue):
23522         (AccessibilityUIElement::increment):
23523         (AccessibilityUIElement::decrement):
23524
23525 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
23526
23527         garden-o-matic 'Results' panel is broken for the Apple platform
23528         https://bugs.webkit.org/show_bug.cgi?id=89310
23529
23530         Reviewed by Adam Barth.
23531         
23532         For platforms that don't use accumulated build directories on the server,
23533         carry along buildLocation data with buildInfo, so that we know where to
23534         look for the test results files for a given test.
23535         
23536         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
23537         it now returns an array of objects with buildNumber, revision and url info.
23538         
23539         Fixed results.fetchResultsURLs() to use this data to find results.
23540         
23541         Fixed the results display to not scroll when you click on a test to see the results.
23542         Made the h3s look less ugly
23543         
23544         Don't try to show the flakiness dashboard for the Apple platform.
23545
23546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
23547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
23548         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
23549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
23550         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
23551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
23552         (.results-view .top-panel):
23553         (.results-view h3):
23554
23555 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
23556
23557         Make garden-o-matic work for the Apple Mac port
23558         https://bugs.webkit.org/show_bug.cgi?id=84642
23559
23560         Reviewed by Adam Barth.
23561         
23562         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
23563         educating the scripts in various ways:
23564         * Wrap up platform-related differences in config.kPlatforms[]
23565         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
23566         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
23567           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
23568           recent build with valid results.
23569         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
23570           try to test a build that has already been deleted). Make walkHistory() more robust here.
23571         * webkit.org uses differently named test result directories, that include the SVN revision as
23572           well as the build number. That forces us to fetch more build info before we can get the
23573           result directory URL.
23574         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
23575           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
23576           dirs.
23577         * Various URLs differ between webkit.org and chromium.org
23578         * Better UI for the failures info, so that some info is visible even when not hovered.
23579
23580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
23581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
23582         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
23583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
23584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
23585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
23586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
23587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
23588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
23589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
23590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
23591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
23592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
23593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
23594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
23595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
23596         (ol.notifications>li table.failures):
23597         (ol.notifications>li:hover table.failures):
23598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
23599         (#onebar #platform-picker):
23600         * Scripts/webkitpy/layout_tests/port/builders.py:
23601
23602 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
23603
23604         Unreviewed, rolling out r120536.
23605         http://trac.webkit.org/changeset/120536
23606         https://bugs.webkit.org/show_bug.cgi?id=89296
23607
23608         Does not compile on chromium-linux (Requested by abarth on
23609         #webkit).
23610
23611         * DumpRenderTree/chromium/LayoutTestController.cpp:
23612         (LayoutTestController::reset):
23613         (LayoutTestController::setTextSubpixelPositioning):
23614         * DumpRenderTree/chromium/TestShellAndroid.cpp:
23615
23616 2012-06-16  Adam Barth  <abarth@webkit.org>
23617
23618         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
23619         https://bugs.webkit.org/show_bug.cgi?id=89274
23620
23621         Reviewed by Levi Weintraub.
23622
23623         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
23624         Note: The WebKit2 API that setBackingScaleFactor exercises is still
23625         tested by API-level tests.
23626
23627         * DumpRenderTree/LayoutTestController.cpp:
23628         (LayoutTestController::staticFunctions):
23629         * DumpRenderTree/LayoutTestController.h:
23630         (LayoutTestController):
23631         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
23632         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
23633         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
23634         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
23635         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
23636         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
23637         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
23638         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
23639         (WTR::InjectedBundle::didReceiveMessage):
23640         (WTR):
23641         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
23642         (InjectedBundle):
23643         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
23644         (WTR):
23645         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
23646         (LayoutTestController):
23647         * WebKitTestRunner/TestInvocation.cpp:
23648         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
23649
23650 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
23651
23652         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
23653         https://bugs.webkit.org/show_bug.cgi?id=89228
23654
23655         Reviewed by Tony Chang.
23656
23657         * DumpRenderTree/chromium/LayoutTestController.cpp:
23658         (LayoutTestController::reset):
23659         (LayoutTestController::setTextSubpixelPositioning):
23660         * DumpRenderTree/chromium/TestShellAndroid.cpp:
23661
23662 2012-06-15  Adam Barth  <abarth@webkit.org>
23663
23664         garden-o-matic's results.js should use RequestTracker
23665         https://bugs.webkit.org/show_bug.cgi?id=89257
23666
23667         Reviewed by Dimitri Glazkov.
23668
23669         We wrote results.js before we recognized the RequestTracker pattern.
23670         This patch replaces the manual implementations of RequestTracker with
23671         the real deal.
23672
23673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
23674
23675 2012-06-15  Darin Adler  <darin@apple.com>
23676
23677         * Scripts/webkitpy/bindings: Added property svn:ignore.
23678
23679 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
23680
23681         Unreviewed, rolling out r120511.
23682         http://trac.webkit.org/changeset/120511
23683         https://bugs.webkit.org/show_bug.cgi?id=89255
23684
23685         Breaks at least Android builder (Requested by wangxianzhu on
23686         #webkit).
23687
23688         * DumpRenderTree/chromium/LayoutTestController.cpp:
23689         (LayoutTestController::reset):
23690         (LayoutTestController::setTextSubpixelPositioning):
23691
23692 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
23693
23694         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
23695         https://bugs.webkit.org/show_bug.cgi?id=89228
23696
23697         Reviewed by Tony Chang.
23698
23699         * DumpRenderTree/chromium/LayoutTestController.cpp:
23700         (LayoutTestController::reset):
23701         (LayoutTestController::setTextSubpixelPositioning):
23702
23703 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
23704
23705         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
23706         https://bugs.webkit.org/show_bug.cgi?id=89135
23707
23708         Re-land change in r120370 with fix in
23709         PortFactory.get_from_builder_name() that changes BuilderOptions
23710         to an actual optparse.Values object.
23711
23712         * Scripts/webkitpy/layout_tests/port/base.py:
23713         (Port.__init__):
23714         (Port.get_option):
23715         (Port.set_option_default):
23716         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
23717         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
23718         * Scripts/webkitpy/layout_tests/port/factory.py:
23719         (_builder_options):
23720         (PortFactory.get_from_builder_name):
23721         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
23722         (FactoryTest.test_get_from_builder_name):
23723         * Scripts/webkitpy/style/checkers/test_expectations.py:
23724         (TestExpectationsChecker._determine_port_from_expectations_path):
23725         * Scripts/webkitpy/tool/mocktool.py:
23726         (MockOptions.ensure_value):
23727
23728 2012-06-15  Bill Budge  <bbudge@chromium.org>
23729
23730         Add bbudge@chromium.org to committers.py
23731
23732         Unreviewed.
23733
23734         * Scripts/webkitpy/common/config/committers.py:
23735
23736 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
23737
23738         Unreviewed style fix after r120351.
23739
23740         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
23741         (body.interface):
23742
23743 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
23744
23745         master.cfg cleanup, remove unnecessary workaround
23746         https://bugs.webkit.org/show_bug.cgi?id=88994
23747
23748         Reviewed by Lucas Forschler.
23749
23750         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
23751         (loadBuilderConfig):
23752
23753 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
23754
23755         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
23756         https://bugs.webkit.org/show_bug.cgi?id=88581
23757
23758         Reviewed by Adam Barth.
23759
23760         Make sure we only optimize the suffixes we rebaselined during
23761         rebaseline-expectations, and not all suffixes for a test.
23762         While optimizing is somewhere between harmless and good, it's also confusing :)
23763
23764         * Scripts/webkitpy/tool/commands/rebaseline.py:
23765         (RebaselineExpectations._rebaseline_port):
23766         (RebaselineExpectations.execute):
23767         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
23768
23769 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
23770
23771         Update builder.html template for newer buildmaster
23772         https://bugs.webkit.org/show_bug.cgi?id=89207
23773
23774         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
23775
23776         Reviewed by Zoltan Herczeg.
23777
23778         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
23779
23780 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
23781
23782         Add ForceScheduler to build.webkit.org
23783         https://bugs.webkit.org/show_bug.cgi?id=88982
23784
23785         Reviewed by Ryosuke Niwa.
23786
23787         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
23788         (loadBuilderConfig):
23789
23790 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
23791
23792         [EFL][WK2] Add title support to Ewk_View
23793         https://bugs.webkit.org/show_bug.cgi?id=89095
23794
23795         Reviewed by Kenneth Rohde Christiansen.
23796
23797         Update the MiniBrowser so it listens for the "title,change"
23798         signal on the view and keeps the browser window title
23799         up-to-date.
23800
23801         * MiniBrowser/efl/main.c:
23802         (on_title_changed):
23803         (browserCreate):
23804
23805 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
23806
23807         [WK2][EFL] Implement navigation back/forward in Ewk_View
23808         https://bugs.webkit.org/show_bug.cgi?id=89173
23809
23810         Reviewed by Kenneth Rohde Christiansen.
23811
23812         Implement navigation back / forward in MiniBrowser. Use
23813         'F1' to navigate back and 'F2' to navigate forward.
23814
23815         * MiniBrowser/efl/main.c:
23816         (on_key_down):
23817
23818 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
23819
23820         [EFL] EFL's LayoutTestController does not support titleTextDirection
23821         https://bugs.webkit.org/show_bug.cgi?id=86475
23822
23823         Reviewed by Hajime Morita.
23824
23825         Add titleTextDirection getter and setter to LayoutTestController and
23826         expose its value to JavaScript.
23827         Update the titleTextDirection value from EFL's "title,changed"
23828         callback in DumpRenderTree.
23829
23830         * DumpRenderTree/LayoutTestController.cpp:
23831         (LayoutTestController::LayoutTestController):
23832         (getTitleTextDirectionCallback):
23833         (LayoutTestController::staticValues):
23834         * DumpRenderTree/LayoutTestController.h:
23835         (LayoutTestController::titleTextDirection):
23836         (LayoutTestController::setTitleTextDirection):
23837         (LayoutTestController):
23838         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
23839         (DumpRenderTreeChrome::onFrameTitleChanged):
23840
23841 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
23842
23843         [EFL][WK2] Implement reload / stop in Ewk_View
23844         https://bugs.webkit.org/show_bug.cgi?id=89168
23845
23846         Reviewed by Kenneth Rohde Christiansen.
23847
23848         Implement view reload / stop loading in MiniBrowser.
23849         Use 'F5' for reload and 'F6' for stopping the load.
23850
23851         * MiniBrowser/efl/main.c:
23852         (on_key_down):
23853         (browserCreate):
23854
23855 2012-06-15  Hironori Bono  <hbono@chromium.org>
23856
23857         Allow platforms to choose whether to remove markers on editing
23858         https://bugs.webkit.org/show_bug.cgi?id=88838
23859
23860         Reviewed by Hajime Morita.
23861
23862         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
23863         run grammar tests.
23864
23865         * DumpRenderTree/chromium/WebViewHost.cpp:
23866         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
23867         * DumpRenderTree/chromium/WebViewHost.h:
23868         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
23869
23870 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
23871
23872         Unreviewed, rolling out r120370.
23873         http://trac.webkit.org/changeset/120370
23874         https://bugs.webkit.org/show_bug.cgi?id=89183
23875
23876         Broke webkit-patch rebaseline (Requested by zdobersek on
23877         #webkit).
23878
23879         * Scripts/webkitpy/layout_tests/port/base.py:
23880         (DummyOptions):
23881         (DummyOptions.__init__):
23882         (DummyOptions.__init__.this):
23883         (Port.__init__):
23884         (Port.get_option):
23885         (Port.set_option_default):
23886         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
23887         (ChromiumWinTest.RegisterCygwinOption):
23888         (ChromiumWinTest.RegisterCygwinOption.__init__):
23889         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
23890         * Scripts/webkitpy/style/checkers/test_expectations.py:
23891         (TestExpectationsChecker._determine_port_from_expectations_path):
23892         * Scripts/webkitpy/tool/mocktool.py:
23893         (MockOptions.update):
23894
23895 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
23896
23897         [Chromium-Android] Initialize font rendering in DumpRenderTree
23898         https://bugs.webkit.org/show_bug.cgi?id=89133
23899
23900         Reviewed by Adam Barth.
23901
23902         * DumpRenderTree/chromium/LayoutTestController.cpp:
23903         (LayoutTestController::reset):
23904         (LayoutTestController::setTextSubpixelPositioning):
23905         * DumpRenderTree/chromium/TestShellAndroid.cpp:
23906         (platformInit):
23907
23908 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
23909
23910         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
23911         https://bugs.webkit.org/show_bug.cgi?id=88622
23912
23913         Reviewed by Philippe Normand.
23914
23915         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
23916         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
23917
23918 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
23919
23920         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
23921         https://bugs.webkit.org/show_bug.cgi?id=89124
23922
23923         Reviewed by Dirk Pranke.
23924
23925         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
23926         (ChromiumAndroidDriver._start):
23927         (ChromiumAndroidDriver):
23928         (ChromiumAndroidDriver._start_once):
23929
23930 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
23931
23932         Update webpagereplay to 1.1.2
23933         https://bugs.webkit.org/show_bug.cgi?id=89118
23934
23935         This includes the following patch which avoids pkg_resources import errors:
23936         http://code.google.com/p/web-page-replay/source/detail?r=476
23937
23938         Reviewed by Dirk Pranke.
23939
23940         * Scripts/webkitpy/thirdparty/__init__.py:
23941         (AutoinstallImportHook._install_webpagereplay):
23942
23943 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
23944
23945         Get rid of FAIL test expectation
23946         https://bugs.webkit.org/show_bug.cgi?id=89137
23947
23948         Reviewed by Dirk Pranke.
23949
23950         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
23951         (ResultSummaryTest.test_summarized_results_wontfix):
23952         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
23953         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
23954         (JSONLayoutResultsGenerator):
23955         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
23956         (result_was_expected):
23957         (suffixes_for_expectations):
23958         (TestExpectationsModel._add_test):
23959         (TestExpectations):
23960         (TestExpectations.get_rebaselining_failures):
23961         (TestExpectations.remove_configuration_from_test):
23962         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
23963         (FunctionsTest.test_result_was_expected):
23964         (FunctionsTest.test_suffixes_for_expectations):
23965         (TestExpectationSerializerTests.test_parsed_expectations_string):
23966         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
23967         (test_test_expectations):
23968         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
23969         (TestExpectationsTestCase.test_valid_expectations):
23970
23971 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
23972
23973         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
23974         https://bugs.webkit.org/show_bug.cgi?id=89135
23975
23976         Reviewed by Ryosuke Niwa.
23977
23978         This patch is just some minor cleanup and simplification. There
23979         should be no functional changes here.
23980
23981         * Scripts/webkitpy/layout_tests/port/base.py:
23982         (Port.__init__):
23983         (Port.get_option):
23984         (Port.set_option_default):
23985         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
23986         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
23987         * Scripts/webkitpy/style/checkers/test_expectations.py:
23988         (TestExpectationsChecker._determine_port_from_expectations_path):
23989         * Scripts/webkitpy/tool/mocktool.py:
23990         (MockOptions.ensure_value):
23991
23992 2012-06-14  Ian Vollick  <vollick@chromium.org>
23993
23994         [chromium] Certain settings in CCSettings could be global
23995         https://bugs.webkit.org/show_bug.cgi?id=88384
23996
23997         Reviewed by James Robinson.
23998
23999         * DumpRenderTree/chromium/TestShell.cpp:
24000         (TestShell::TestShell):
24001         (TestShell::resetWebSettings):
24002         (TestShell::setPerTilePaintingEnabled):
24003         * DumpRenderTree/chromium/TestShell.h:
24004         (TestShell):
24005         * DumpRenderTree/chromium/WebPreferences.cpp:
24006         (WebPreferences::reset):
24007         (WebPreferences::applyTo):
24008         * DumpRenderTree/chromium/WebPreferences.h:
24009         (WebPreferences):
24010
24011 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
24012
24013         Unreviewed, rolling out r120352.
24014         http://trac.webkit.org/changeset/120352
24015         https://bugs.webkit.org/show_bug.cgi?id=89120
24016
24017         It seems something is still wrong with it :/ (Requested by
24018         Ossy on #webkit).
24019
24020         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24021         (Factory.__init__):
24022         (BuildFactory.__init__):
24023         (TestFactory.__init__):
24024         (BuildAndTestFactory.__init__):
24025         (BuildAndPerfTestFactory.__init__):
24026         (BuildAndPerfTestWebKit2Factory.__init__):
24027         (DownloadAndPerfTestFactory.__init__):
24028         (DownloadAndPerfTestWebKit2Factory.__init__):
24029
24030 2012-06-14  Jia Pu  <jpu@apple.com>
24031
24032         Mark text with text alternative with blue underline.
24033         https://bugs.webkit.org/show_bug.cgi?id=83047
24034
24035         Reviewed by NOBODY Enrica Casucci.
24036
24037         * DumpRenderTree/mac/TextInputController.m:
24038         (+[TextInputController isSelectorExcludedFromWebScript:]):
24039         (+[TextInputController webScriptNameForSelector:]):
24040         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
24041
24042 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
24043
24044         Unreviewed, rolling out r120353.
24045         http://trac.webkit.org/changeset/120353
24046         https://bugs.webkit.org/show_bug.cgi?id=89119
24047
24048         It seems we still need this workaround (Requested by Ossy on
24049         #webkit).
24050
24051         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24052         (loadBuilderConfig):
24053
24054 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
24055
24056         master.cfg cleanup, remove unnecessary workaround
24057         https://bugs.webkit.org/show_bug.cgi?id=88994
24058
24059         Reviewed by Lucas Forschler.
24060
24061         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24062         (loadBuilderConfig):
24063
24064 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
24065
24066         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
24067         https://bugs.webkit.org/show_bug.cgi?id=89001
24068
24069         Reviewed by Lucas Forschler.
24070
24071         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24072         (Factory.__init__):
24073         (BuildFactory.__init__):
24074         (TestFactory.__init__):
24075         (BuildAndTestFactory.__init__):
24076         (BuildAndPerfTestFactory.__init__):
24077         (BuildAndPerfTestWebKit2Factory.__init__):
24078         (DownloadAndPerfTestFactory.__init__):
24079         (DownloadAndPerfTestWebKit2Factory.__init__):
24080
24081 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
24082
24083         Unhide login form on the build.webkit.org
24084         https://bugs.webkit.org/show_bug.cgi?id=88981
24085
24086         Reviewed by Lucas Forschler.
24087
24088         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
24089
24090 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
24091
24092         [Gtk] Add support in DumpRenderTree for tracking repaints
24093         https://bugs.webkit.org/show_bug.cgi?id=87658
24094
24095         Reviewed by Martin Robinson.
24096
24097         Reimplement the displayWebView method in DumpRenderTree - force a
24098         repaint before starting tracking repaints and resetting them.
24099
24100         When gathering pixel output from a web view, if tracking repaints,
24101         paint an overlay over the output with the overlay being clear in the
24102         areas where the repaints occurred.
24103
24104         * DumpRenderTree/gtk/DumpRenderTree.cpp:
24105         (displayWebView):
24106         (resetDefaultsToConsistentValues):
24107         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
24108         (paintOverlay):
24109         (fillRepaintOverlayIntoContext):
24110         (createBitmapContextFromWebView):
24111
24112 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
24113
24114         new-run-webkit-tests doesn't find similar platform tests for a keyword
24115         https://bugs.webkit.org/show_bug.cgi?id=37956
24116
24117         Reviewed by Ryosuke Niwa.
24118
24119         This patches adds support for NRWT so that if you type
24120         "new-run-webkit-tests foo" it will run all the tests in foo as
24121         well as platform/foo for all of the platforms that are normally
24122         searched (this only applies to directories, not to individual tests).
24123
24124         * Scripts/webkitpy/layout_tests/controllers/manager.py:
24125         (Manager.collect_tests):
24126         * Scripts/webkitpy/layout_tests/port/base.py:
24127         (Port.tests):
24128         (Port):
24129         (Port._expanded_paths):
24130         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
24131         (MainTest.test_no_http_tests):
24132         (MainTest):
24133         (MainTest.test_platform_tests_are_found):
24134
24135 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
24136
24137         NRWT should honor --skipped=[default|ignore|only], like ORWT does
24138         https://bugs.webkit.org/show_bug.cgi?id=66308
24139
24140         Reviewed by Ryosuke Niwa.
24141
24142         This patch adds support for ORWT's --skipped=(default|ignore|only)
24143         flag and cleans up the interaction between that and --ignore.
24144
24145         Individual tests (but not directories) explicitly listed on the
24146         command line will always be run regardless of what is passed
24147         for --skipped and --ignore.
24148
24149         This patch also changes the "found" and "running" log messages
24150         since it wasn't clear how the skipped tests were included in those numbers.
24151
24152         * Scripts/webkitpy/layout_tests/controllers/manager.py:
24153         (Manager.__init__):
24154         (Manager.collect_tests):
24155         (Manager.prepare_lists_and_print_output):
24156         * Scripts/webkitpy/layout_tests/port/test.py:
24157         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
24158         (_set_up_derived_options):
24159         (parse_args):
24160         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
24161         (MainTest.test_ignore_flag):
24162         (MainTest):
24163         (MainTest.test_skipped_flag):
24164
24165 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
24166
24167         new-run-webkit-websocketserver must handle TLS related arguments
24168         https://bugs.webkit.org/show_bug.cgi?id=89079
24169
24170         Reviewed by Dirk Pranke.
24171
24172         PyWebSocket class must accept private_key, certificate, and
24173         ca_certificate arguments and pass them to launching pywebsocket.
24174         Also add ca_certificate handling to new-run-webkit-websocketserver.
24175
24176         * Scripts/new-run-webkit-websocketserver:
24177         (main):
24178         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
24179         (PyWebSocket.__init__):
24180         (PyWebSocket._prepare_config):
24181
24182 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
24183
24184         Unreviewed. Update my email.
24185
24186         * Scripts/webkitpy/common/config/committers.py:
24187
24188 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
24189
24190         Update pywebsocket to 0.7.6 from 0.7.4
24191         https://bugs.webkit.org/show_bug.cgi?id=88975
24192
24193         Reviewed by Kent Tamura.
24194
24195         This new version of pywebsocket introduce following features.
24196          - Allow handlers to send a close frame with empty body in response of
24197              a client initiated closing handshake
24198          - Implement perframe compression extension
24199          - Support client certificate authentication
24200
24201         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
24202         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
24203         (_create_control_frame):
24204         (Stream._receive_frame):
24205         (Stream.send_message):
24206         (Stream.receive_message):
24207         (Stream._send_closing_handshake):
24208         (Stream.close_connection):
24209         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
24210         (ExtensionParsingException):
24211         (ExtensionParsingException.__init__):
24212         (_parse_extension_param):
24213         (_parse_extension):
24214         (parse_extensions):
24215         (format_extension):
24216         (format_extensions):
24217         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
24218         (_parse_compression_method):
24219         (_create_accepted_method_desc):
24220         (PerFrameCompressionExtensionProcessor):
24221         (PerFrameCompressionExtensionProcessor.__init__):
24222         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
24223         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
24224         (PerFrameCompressionExtensionProcessor.get_extension_response):
24225         (PerFrameCompressionExtensionProcessor.setup_stream_options):
24226         (PerFrameCompressionExtensionProcessor.get_compression_processor):
24227         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
24228         (parse_token_list):
24229         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
24230         (Handshaker._parse_extensions):
24231         (Handshaker._send_handshake):
24232         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
24233         (WebSocketServer._create_sockets):
24234         (_get_logger_from_class):
24235         (_configure_logging):
24236         (_build_option_parser):
24237         (_main.if):
24238         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
24239         (RepeatedXorMasker.mask):
24240
24241 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
24242
24243         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
24244
24245         Reviewed by Noam Rosenthal.
24246
24247         * qmake/mkspecs/features/features.prf:
24248
24249 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
24250
24251         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
24252         https://bugs.webkit.org/show_bug.cgi?id=88399
24253
24254         Reviewed by Kenneth Rohde Christiansen.
24255
24256         Update initialization of WKPageLoaderClient.
24257
24258         * MiniBrowser/mac/BrowserWindowController.m:
24259         (-[BrowserWindowController awakeFromNib]):
24260         * WebKitTestRunner/TestController.cpp:
24261         (WTR::TestController::initialize):
24262
24263 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
24264
24265         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
24266         https://bugs.webkit.org/show_bug.cgi?id=84577
24267
24268         Reviewed by Ryosuke Niwa.
24269
24270         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
24271         LayoutTestController.
24272
24273         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
24274         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
24275
24276 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
24277
24278         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
24279         https://bugs.webkit.org/show_bug.cgi?id=88340
24280
24281         Reviewed by Kenneth Rohde Christiansen.
24282
24283         Update initialization of WKPageLoaderClient.
24284
24285         * MiniBrowser/mac/BrowserWindowController.m:
24286         (-[BrowserWindowController awakeFromNib]):
24287         * WebKitTestRunner/TestController.cpp:
24288         (WTR::TestController::initialize):
24289
24290 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
24291
24292         Unreviewed, rolling out r120268.
24293         http://trac.webkit.org/changeset/120268
24294         https://bugs.webkit.org/show_bug.cgi?id=89060
24295
24296         WebCompositor::setPerTilePaintingEnabled hits an assertion in
24297         DEBUG (Requested by dominicc|work on #webkit).
24298
24299         * DumpRenderTree/chromium/WebPreferences.cpp:
24300         (WebPreferences::applyTo):
24301
24302 2012-06-13  Tim Horton  <timothy_horton@apple.com>
24303
24304         REGRESSION (r120252): run-webkit-tests on Mac fails
24305         https://bugs.webkit.org/show_bug.cgi?id=89057
24306
24307         Reviewed by Dan Bernstein.
24308
24309         get_option will happily return None (the default only kicks in if
24310         the option is actually *not set*). We should instead check get_option's
24311         return value and default to "x86_64" architecture ourselves.
24312
24313         * Scripts/webkitpy/layout_tests/port/mac.py:
24314         (MacPort.__init__):
24315
24316 2012-06-13  Ian Vollick  <vollick@chromium.org>
24317
24318         [chromium] Certain settings in CCSettings could be global
24319         https://bugs.webkit.org/show_bug.cgi?id=88384
24320
24321         Reviewed by James Robinson.
24322
24323         * DumpRenderTree/chromium/WebPreferences.cpp:
24324         (WebPreferences::applyTo):
24325
24326 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
24327
24328         new-run-webkit-tests does not support --32-bit like ORWT did
24329         https://bugs.webkit.org/show_bug.cgi?id=71634
24330
24331         Reviewed by Ojan Vafai.
24332
24333         This patch adds support for 32-bit apple mac builds, adding the
24334         --32-bit flag for compatibility with ORWT and fixing the port
24335         architecture() definition to actually return the correct values.
24336
24337         * Scripts/webkitpy/layout_tests/port/apple.py:
24338         (ApplePort._generate_all_test_configurations):
24339         * Scripts/webkitpy/layout_tests/port/factory.py:
24340         (port_options):
24341         * Scripts/webkitpy/layout_tests/port/mac.py:
24342         (MacPort):
24343         (MacPort.__init__):
24344         (MacPort._build_driver_flags):
24345         (MacPort.setup_environ_for_server):
24346         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
24347         (test_sample_process_throws_exception):
24348         (test_32bit):
24349         (test_32bit.run_script):
24350         (test_64bit):
24351         (test_64bit.run_script):
24352         * Scripts/webkitpy/layout_tests/port/webkit.py:
24353         (WebKitPort._build_driver):
24354         (WebKitPort._build_driver_flags):
24355         * Scripts/webkitpy/layout_tests/port/win.py:
24356         (WinPort):
24357
24358 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
24359
24360         Remove webkitpy code to support legacy test_expectations.txt files
24361         https://bugs.webkit.org/show_bug.cgi?id=89038
24362
24363         Reviewed by Dirk Pranke.
24364
24365         * Scripts/webkitpy/layout_tests/port/base.py:
24366         (Port.path_to_test_expectations_file):
24367         (Port.expectations_dict):
24368         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
24369         (PortTest.test_uses_test_expectations_file):
24370         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
24371         (WebKitPortTest.test_path_to_test_expectations_file):
24372         (test_test_expectations):
24373         * Scripts/webkitpy/style/checker.py:
24374         (CheckerDispatcher.should_skip_without_warning):
24375         (CheckerDispatcher._create_checker):
24376         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
24377         (TestExpectationsTestCase._expect_port_for_expectations_path):
24378         * Scripts/webkitpy/tool/steps/commit.py:
24379         (Commit._check_test_expectations):
24380         * Scripts/webkitpy/tool/steps/commit_unittest.py:
24381         (CommitTest.test_check_test_expectations):
24382
24383 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
24384
24385         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
24386         https://bugs.webkit.org/show_bug.cgi?id=88948
24387
24388         Reviewed by Ojan Vafai.
24389
24390         In the final patch of this run, we remove the
24391         test_expectations() and test_expectation_overrides() methods
24392         from the Port class - callers must now use just
24393         expectations_dict().
24394
24395         Note that support for the cascade in new-run-webkit-tests is
24396         complete but only Chromium uses it; webkit-patch
24397         rebaseline-expectations still does not support updating entries
24398         in any file other than the first expectations file, however.
24399
24400         * Scripts/webkitpy/layout_tests/port/base.py:
24401         (Port.path_to_test_expectations_file):
24402         (Port.uses_test_expectations_file):
24403         (Port.expectations_files):
24404         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
24405         (PortTest.test_additional_expectations):
24406         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
24407         (ChromiumPortTest.test_expectations_files):
24408         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
24409         (TestGoogleChromePort.test_get_google_chrome_port):
24410         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
24411         (test_test_expectations):
24412         (test_legacy_test_expectations):
24413
24414 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
24415
24416         nrwt: implement the actual cascade of TestExpectations
24417         https://bugs.webkit.org/show_bug.cgi?id=88947
24418
24419         Reviewed by Ojan Vafai.
24420
24421         This change implements the actual cascade by removing the
24422         concept of 'overrides' from the TestExpectations object and
24423         parsing each file separately.
24424
24425         There is an actual semantic change in this patch, in that
24426         setting an expectation on a directory in one file will override
24427         the expectations on any individual tests set in prior files. The
24428         test_overrides__directory() unit test verifies this.
24429
24430         Otherwise, this patch mostly consists of deleting code :).
24431
24432         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
24433         (TestExpectationsModel.__init__):
24434         (TestExpectationsModel.add_expectation_line):
24435         (TestExpectationsModel._add_test):
24436         (TestExpectationsModel._already_seen_better_match):
24437         (TestExpectations.__init__):
24438         (TestExpectations._add_expectations):
24439         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
24440         (test_overrides__directory):
24441
24442 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
24443
24444         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
24445         https://bugs.webkit.org/show_bug.cgi?id=88946
24446
24447         Reviewed by Ojan Vafai.
24448
24449         In preparation for fully supporting cascading expectations files
24450         and removing the 'overrides' concept.
24451
24452         There should be no functional changes in this patch.
24453
24454         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
24455         (ManagerTest.test_update_summary_with_result):
24456         (ResultSummaryTest.get_result_summary):
24457         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
24458         (TestExpectations.__init__):
24459         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
24460         (parse_exp):
24461         (SkippedTests.check):
24462         (RemoveConfigurationsTest.test_remove):
24463         (test_remove_line):
24464         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
24465         (LintTest.test_all_configurations.FakePort.__init__):
24466         (LintTest.test_all_configurations.FakePort.expectations_dict):
24467         (LintTest.test_lint_test_files__errors):
24468         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
24469         (test_overrides_are_included_correctly):
24470
24471 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
24472
24473         webkitpy: rework the TestExpectations style checker in preparation for the cascade
24474         https://bugs.webkit.org/show_bug.cgi?id=88945
24475
24476         Reviewed by Ojan Vafai.
24477
24478         This patch changes the style checker to call the
24479         TestExpectations parser directly and be oblivious as to what the
24480         port's actual expectations are.
24481
24482         * Scripts/webkitpy/style/checkers/test_expectations.py:
24483         (TestExpectationsChecker.__init__):
24484         (TestExpectationsChecker.check_test_expectations):
24485
24486 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
24487
24488         nrwt: restructure the port classes to handle multiple expectations files
24489         https://bugs.webkit.org/show_bug.cgi?id=88944
24490
24491         Reviewed by Ojan Vafai.
24492
24493         This patch restructures the Port classes so that each port
24494         returns a list of TestExpectations files to be used (in a new, public,
24495         expectations_files() method), and the base implementation rolls them
24496         up into the ordered expectations_dict(), which becomes a public
24497         method.
24498
24499         port.path_to_test_expectations_file(), port.test_expectations(),
24500         and port.test_expectations_overrides() are then reimplemented as
24501         wrappers around port.expectations_dict().
24502         port.test_expectations() and port.test_expectations_overrides()
24503         will eventually be removed when the cascade is fully completed,
24504         and port.path_to_test_expectations_file() will be removed when
24505         the rebaselining tool supports the cascade
24506         (expectations_files() may also become private at that point).
24507
24508         There should be no functional changes in this patch, but a bunch
24509         of custom logic gets deleted!
24510
24511         * Scripts/webkitpy/layout_tests/port/base.py:
24512         (Port.expectations_dict):
24513         (Port):
24514         (Port.expectations_files):
24515         (Port.test_expectations):
24516         (Port.test_expectations_overrides):
24517         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
24518         (PortTest.test_additional_expectations):
24519         (PortTest.test_uses_test_expectations_file):
24520         * Scripts/webkitpy/layout_tests/port/chromium.py:
24521         (ChromiumPort.all_baseline_variants):
24522         (ChromiumPort.expectations_files):
24523         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
24524         (ChromiumPortTest.test_overrides_and_builder_names):
24525         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
24526         (_expectations_files):
24527         (GoogleChromeLinux32Port.expectations_files):
24528         (GoogleChromeLinux64Port.expectations_files):
24529         (GoogleChromeMacPort.expectations_files):
24530         (GoogleChromeWinPort.expectations_files):
24531         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
24532         (TestGoogleChromePort._verify_expectations_overrides):
24533         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
24534         (PortTestCase.test_expectations_ordering):
24535         * Scripts/webkitpy/layout_tests/port/webkit.py:
24536         (WebKitPort._skipped_file_search_paths):
24537         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
24538         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
24539         (test_rebaseline_updates_expectations_file):
24540         (test_rebaseline_does_not_include_overrides):
24541         (test_rebaseline_expectations):
24542         (test_overrides_are_included_correctly):
24543
24544 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
24545
24546         [WinCairo] Update URL of WinCairoRequirements.zip download.
24547         https://bugs.webkit.org/show_bug.cgi?id=89009
24548
24549         Reviewed by Martin Robinson.
24550
24551         * Tools/Scripts/update-webkit-dependency: Put fallback code
24552         to download a "last update" time from servers that don't properly
24553         report Last-Modified in their HTTP header.
24554         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
24555         for the WinCairo build requirements bundle.
24556
24557 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
24558
24559         nrwt: preliminary cleanup before supporting cascading expectations files
24560         https://bugs.webkit.org/show_bug.cgi?id=88942
24561
24562         Reviewed by Ojan Vafai.
24563
24564         This change just prepares the TestExpectations parser to get filenames
24565         along with the expectations, and improves the warning messages so that
24566         they contain the filenames along with the line numbers.
24567
24568         There should be no functional changes in this patch.
24569
24570         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
24571         (TestExpectationEditorTests.make_parsed_expectation_lines):
24572         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
24573         (TestExpectationParser.parse):
24574         (TestExpectationParser.expectation_for_skipped_test):
24575         (TestExpectationParser._tokenize):
24576         (TestExpectationParser._tokenize_list):
24577         (TestExpectationLine):
24578         (TestExpectationsModel.__init__):
24579         (TestExpectationsModel._already_seen_better_match):
24580         (TestExpectations.__init__):
24581         (TestExpectations._shorten_filename):
24582         (TestExpectations._report_warnings):
24583         (TestExpectations._add_skipped_tests):
24584         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
24585         (TestExpectationParserTests._tokenize):
24586         (TestExpectationParserTests.test_tokenize_blank):
24587         (TestExpectationParserTests.test_tokenize_missing_colon):
24588         (TestExpectationParserTests.test_tokenize_extra_colon):
24589         (TestExpectationParserTests.test_tokenize_empty_comment):
24590         (TestExpectationParserTests.test_tokenize_comment):
24591         (TestExpectationParserTests.test_tokenize_missing_equal):
24592         (TestExpectationParserTests.test_tokenize_extra_equal):
24593         (TestExpectationParserTests.test_tokenize_valid):
24594         (TestExpectationParserTests.test_tokenize_valid_with_comment):
24595         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
24596         (TestExpectationParserTests.test_parse_empty_string):
24597         (TestExpectationSerializerTests._tokenize):
24598         (TestExpectationSerializerTests.assert_round_trip):
24599         (TestExpectationSerializerTests.assert_list_round_trip):
24600         * Scripts/webkitpy/tool/servers/gardeningserver.py:
24601         (GardeningExpectationsUpdater.update_expectations):
24602
24603 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
24604
24605         [Gtk] Enable link prefetch support in the developer builds
24606         https://bugs.webkit.org/show_bug.cgi?id=89011
24607
24608         Reviewed by Martin Robinson.
24609
24610         Enable the link prefetch support for Gtk by default in developer
24611         builds.
24612
24613         * Scripts/webkitperl/FeatureList.pm:
24614
24615 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
24616
24617         Update buildbot master in autoinstaller to match build.webkit.org
24618         https://bugs.webkit.org/show_bug.cgi?id=88992
24619
24620         Reviewed by Adam Barth.
24621
24622         * Scripts/webkitpy/thirdparty/__init__.py:
24623         (AutoinstallImportHook._install_buildbot):
24624
24625 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
24626
24627         Unreviewed, rolling out r120209.
24628         http://trac.webkit.org/changeset/120209
24629         https://bugs.webkit.org/show_bug.cgi?id=89007
24630
24631         Broke the WebKit2 mac build. (Requested by andersca on
24632         #webkit).
24633
24634         * MiniBrowser/mac/BrowserWindowController.m:
24635         (-[BrowserWindowController awakeFromNib]):
24636         * WebKitTestRunner/TestController.cpp:
24637         (WTR::TestController::initialize):
24638
24639 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
24640
24641         check-webkit-style needs to respect Qt API coding style
24642         https://bugs.webkit.org/show_bug.cgi?id=88995
24643
24644         Reviewed by Csaba Osztrogonác.
24645
24646         Add -whitespace/declaration exception to Qt API files.
24647
24648         * Scripts/webkitpy/style/checker.py:
24649
24650 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
24651
24652         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
24653         https://bugs.webkit.org/show_bug.cgi?id=88340
24654
24655         Reviewed by Kenneth Rohde Christiansen.
24656
24657         Update initialization of WKPageLoaderClient.
24658
24659         * MiniBrowser/mac/BrowserWindowController.m:
24660         (-[BrowserWindowController awakeFromNib]):
24661         * WebKitTestRunner/TestController.cpp:
24662         (WTR::TestController::initialize):
24663
24664 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
24665
24666         [Qt] Handle multiple held buttons in touch mocking.
24667         https://bugs.webkit.org/show_bug.cgi?id=88865
24668
24669         Reviewed by Kenneth Rohde Christiansen.
24670
24671         Add handling for multiple held mouse-buttons in the appropiate places.
24672         To do this last-pos and start-pos are now also read from the last recorded
24673         touch-point instead from object-global variables.
24674
24675         * MiniBrowser/qt/MiniBrowserApplication.cpp:
24676         (MiniBrowserApplication::notify):
24677         (MiniBrowserApplication::updateTouchPoint):
24678         * MiniBrowser/qt/MiniBrowserApplication.h:
24679         (MiniBrowserApplication):
24680
24681 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
24682
24683         [Qt] Make it possible to disable -Werror in production builds
24684
24685         Reviewed by Tor Arne Vestbø.
24686
24687         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
24688         something qt5.git's qtwebkit.pri will soon do.
24689
24690         * qmake/mkspecs/features/unix/default_post.prf:
24691
24692 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
24693
24694         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
24695         https://bugs.webkit.org/show_bug.cgi?id=85790
24696
24697         Reviewed by Gustavo Noronha Silva.
24698
24699         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
24700         code in webkitdirs.pm.
24701
24702         * Scripts/webkitdirs.pm:
24703         (jhbuildConfigurationChanged):
24704         (saveJhbuildMd5):
24705         (cleanJhbuild):
24706         (buildAutotoolsProject):
24707         (generateBuildSystemFromCMakeProject):
24708
24709 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
24710
24711         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
24712         https://bugs.webkit.org/show_bug.cgi?id=88763
24713
24714         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
24715         extension.
24716
24717         Reviewed by Simon Hausmann.
24718
24719         * qmake/config.tests/libzlib: Added.
24720         * qmake/config.tests/libzlib/libzlib.cpp: Added.
24721         (main):
24722         * qmake/config.tests/libzlib/libzlib.pro: Added.
24723         * qmake/mkspecs/features/features.prf:
24724         * qmake/sync.profile:
24725
24726 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
24727
24728         [BlackBerry] Enable MEDIA_STREAM by default
24729         https://bugs.webkit.org/show_bug.cgi?id=88849
24730
24731         Reviewed by Antonio Gomes.
24732
24733         * Scripts/webkitperl/FeatureList.pm:
24734
24735 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
24736
24737         Prevent stderr output from messing up detection of build path
24738
24739         https://bugs.webkit.org/show_bug.cgi?id=88075
24740
24741         Warnings such as 'perl: warning: Setting locale failed' will otherwise
24742         end up as the build path when calling out to webkit-build-directory.
24743
24744         Reviewed by Ojan Vafai.
24745
24746         * Scripts/webkitpy/layout_tests/port/config.py:
24747         (Config.build_directory):
24748
24749 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
24750
24751         Update the builder name for Apple Lion builders.
24752
24753         * Scripts/webkitpy/layout_tests/port/builders.py:
24754
24755 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
24756
24757         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
24758         https://bugs.webkit.org/show_bug.cgi?id=88874
24759
24760         Reviewed by Simon Hausmann.
24761
24762         Rename main.cpp in QtTestBrowser because on Windows
24763         it conflicts with main.cpp from DumpRenderTree.
24764
24765         * QtTestBrowser/QtTestBrowser.pro:
24766         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
24767         (launcherMain):
24768         (LauncherApplication):
24769         (LauncherApplication::urls):
24770         (LauncherApplication::isRobotized):
24771         (LauncherApplication::robotTimeout):
24772         (LauncherApplication::robotExtraTime):
24773         (LauncherApplication::applyDefaultSettings):
24774         (LauncherApplication::LauncherApplication):
24775         (requiresGraphicsView):
24776         (LauncherApplication::handleUserOptions):
24777         (main):
24778
24779 2012-06-12  Lucas Forschler  <lforschler@apple.com>
24780
24781         Wrap bot types inside ().
24782         https://bugs.webkit.org/show_bug.cgi?id=88893
24783         
24784         Reviewed by Stephanie Lewis.
24785
24786         * BuildSlaveSupport/build.webkit.org-config/config.json:
24787
24788 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
24789
24790         [soup] Prevent setting or editing httpOnly cookies from JavaScript
24791         https://bugs.webkit.org/show_bug.cgi?id=88760
24792
24793         Reviewed by Gustavo Noronha Silva.
24794
24795         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
24796         to v2.33.2 for both GTK and EFL ports.
24797
24798         * efl/jhbuild.modules:
24799         * gtk/jhbuild.modules:
24800
24801 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
24802
24803         [EFL] Enable SHADOW_DOM flag
24804         https://bugs.webkit.org/show_bug.cgi?id=87732
24805
24806         Reviewed by Kentaro Hara.
24807
24808         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
24809         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
24810         SHADOW_DOM by default in DRT.
24811         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
24812         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
24813         Chromium and Mac ports.
24814         (drtViewAdd):
24815         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
24816         at compile time for EFL port.
24817
24818 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
24819
24820         WinLauncher should show loading errors
24821         https://bugs.webkit.org/show_bug.cgi?id=80760
24822
24823         Reviewed by Brent Fulgham.
24824
24825         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
24826         (WinLauncherWebHost::didFailProvisionalLoadWithError):
24827         * WinLauncher/WinLauncher.h:
24828         (WinLauncherWebHost::didFailProvisionalLoadWithError):
24829         (WinLauncherWebHost):
24830
24831 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
24832
24833         [EFL][WK2] Add MiniBrowserEfl.
24834         https://bugs.webkit.org/show_bug.cgi?id=61850
24835
24836         Reviewed by Chang Shu.
24837
24838         Implement MiniBrowser for EFL.
24839
24840         * CMakeLists.txt:
24841         * MiniBrowser/efl/CMakeLists.txt: Added.
24842         * MiniBrowser/efl/main.c: Added.
24843         (_MiniBrowser):
24844         (main_signal_exit):
24845         (on_ecore_evas_resize):
24846         (browserCreate):
24847         (main):
24848
24849 2012-06-12  Helder Correia  <helder.correia@nokia.com>
24850
24851         Unreviewed. Update my email address in committers.py.
24852
24853         * Scripts/webkitpy/common/config/committers.py:
24854
24855 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
24856
24857         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
24858         https://bugs.webkit.org/show_bug.cgi?id=84707
24859
24860         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
24861         use_lib64 variable is preconfigured to True by jhbuild.
24862
24863         Reviewed by Dirk Pranke.
24864
24865         * efl/jhbuildrc:
24866
24867 2012-06-12  Dana Jansens  <danakj@chromium.org>
24868
24869         Add zlieber@chromium.org to contributors list
24870         https://bugs.webkit.org/show_bug.cgi?id=88904
24871
24872         Unreviewed.
24873
24874         * Scripts/webkitpy/common/config/committers.py:
24875
24876 2012-06-12  Lucas Forschler  <lforschler@apple.com>
24877
24878         Rename Apple bots to a standard convention.
24879         https://bugs.webkit.org/show_bug.cgi?id=88893
24880         
24881         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
24882
24883         Reviewed by Simon Fraser.
24884
24885         * BuildSlaveSupport/build.webkit.org-config/config.json:
24886
24887 2012-06-12  Mike West  <mkwst@chromium.org>
24888
24889         Make document.documentURI readonly from JavaScript
24890         https://bugs.webkit.org/show_bug.cgi?id=65187
24891
24892         Reviewed by Alexey Proskuryakov.
24893
24894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24895         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
24896         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
24897         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
24898         (TestWebKitAPI):
24899         (TestWebKitAPI::TEST):
24900
24901 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
24902
24903         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
24904         https://bugs.webkit.org/show_bug.cgi?id=88715
24905
24906         Reviewed by Noam Rosenthal.
24907
24908         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
24909
24910         * Scripts/webkitperl/FeatureList.pm:
24911
24912 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
24913
24914         [Qt] Fix -Werror for the buildbots
24915         https://bugs.webkit.org/show_bug.cgi?id=88223
24916
24917         Rubber-stamped by Tor Arne Vestbø.
24918
24919         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
24920
24921         * qmake/mkspecs/features/unix/default_post.prf:
24922
24923 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
24924
24925         [REGRESSION][WTR] Build fail with werror after r120054
24926         https://bugs.webkit.org/show_bug.cgi?id=88862
24927
24928         Reviewed by Csaba Osztrogonác.
24929
24930         Some static helpers become unused after counterValueForElementById
24931         has moved to Internals. Let's remove them.
24932
24933         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
24934         (WTR):
24935
24936 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
24937
24938         [Qt] Slave losts cause build break on bots
24939         https://bugs.webkit.org/show_bug.cgi?id=38980
24940
24941         Minor fix after r59261.
24942
24943         Reviewed by Tor Arne Vestbø.
24944
24945         * Scripts/build-webkit:
24946         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
24947
24948 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
24949
24950         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
24951         https://bugs.webkit.org/show_bug.cgi?id=84406
24952
24953         Reviewed by Hajime Morita.
24954
24955         Move the counterValueForElementById from LayoutTestCotroller to Internals and
24956         remove the old platform specific implementations as it exclusively tests WebCore functionality.
24957
24958         * DumpRenderTree/LayoutTestController.cpp:
24959         (LayoutTestController::staticFunctions):
24960         * DumpRenderTree/LayoutTestController.h:
24961         (LayoutTestController):
24962         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
24963         * DumpRenderTree/chromium/LayoutTestController.cpp:
24964         (LayoutTestController::LayoutTestController):
24965         (LayoutTestController::setPOSIXLocale):
24966         * DumpRenderTree/chromium/LayoutTestController.h:
24967         (LayoutTestController):
24968         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
24969         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
24970         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
24971         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
24972         * DumpRenderTree/qt/LayoutTestControllerQt.h:
24973         (LayoutTestController):
24974         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
24975         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
24976         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
24977         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
24978         (WTR):
24979         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
24980         (LayoutTestController):
24981
24982 2012-06-11  Hans Wennborg  <hans@chromium.org>
24983
24984         Speech JavaScript API: Make SpeechRecognitionError an Event
24985         https://bugs.webkit.org/show_bug.cgi?id=88784
24986
24987         Reviewed by Adam Barth.
24988
24989         Make it possible to have MockWebSpeechRecognizer fire error events.
24990
24991         * DumpRenderTree/chromium/LayoutTestController.cpp:
24992         (LayoutTestController::LayoutTestController):
24993         (LayoutTestController::setMockSpeechRecognitionError):
24994         * DumpRenderTree/chromium/LayoutTestController.h:
24995         (LayoutTestController):
24996         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
24997         (WebKit):
24998         (ErrorTask):
24999         (WebKit::ErrorTask::ErrorTask):
25000         (MockWebSpeechRecognizer::addMockResult):
25001         (MockWebSpeechRecognizer::setError):
25002         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
25003         (MockWebSpeechRecognizer):
25004
25005 2012-06-11  Ojan Vafai  <ojan@chromium.org>
25006
25007         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
25008         https://bugs.webkit.org/show_bug.cgi?id=88836
25009
25010         Reviewed by Dirk Pranke.
25011
25012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
25013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
25014
25015 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
25016
25017         [EFL] Remove CMakeCache.txt before building
25018         https://bugs.webkit.org/show_bug.cgi?id=88717
25019
25020         Reviewed by Antonio Gomes.
25021
25022         Remove CMake cache file before every build to avoid using outdated
25023         build flags when new features get enabled. This will avoid unexpected
25024         failures on the bots due to outdated build flags.
25025
25026         * Scripts/webkitdirs.pm:
25027         (generateBuildSystemFromCMakeProject):
25028
25029 2012-06-11  Vincent Scheib  <scheib@chromium.org>
25030
25031         Add new Pointer Lock spec attribute webkitPointerLockElement.
25032         https://bugs.webkit.org/show_bug.cgi?id=88799
25033
25034         Reviewed by Dimitri Glazkov.
25035
25036         Part of a series of refactoring changes to update pointer lock API to
25037         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
25038
25039         New attribute webkitPointerLockElement added. Follow up patches
25040         will remove the previous isLocked attribute. Tests updated to use
25041         the new attribute.
25042
25043         WebViewHost logic required modification to correctly repond to
25044         a lock, unlock, pointerLockElement call series. Specifically,
25045         unlocking must be queued after a lock command is issued always
25046         as the lock state may not be set yet with a lock request in flight.
25047
25048         * DumpRenderTree/chromium/WebViewHost.cpp:
25049         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
25050         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
25051
25052 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
25053
25054         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
25055         https://bugs.webkit.org/show_bug.cgi?id=88804
25056
25057         Reviewed by Tony Chang.
25058
25059         Protect box-decoration-break behind a feature flag enabled by default.
25060
25061         * Scripts/webkitperl/FeatureList.pm:
25062         * qmake/mkspecs/features/features.pri:
25063
25064 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
25065
25066         [CMAKE][EFL] Remove duplicated executable output path
25067         https://bugs.webkit.org/show_bug.cgi?id=88765
25068
25069         Reviewed by Daniel Bates.
25070
25071         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
25072         need to define again because it is already defined in top-level CMake file.
25073
25074         * DumpRenderTree/efl/CMakeLists.txt:
25075         * EWebLauncher/CMakeLists.txt:
25076
25077 2012-06-11  Ojan Vafai  <ojan@chromium.org>
25078
25079         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
25080         https://bugs.webkit.org/show_bug.cgi?id=88816
25081
25082         Reviewed by Dirk Pranke.
25083
25084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
25085         Expose a way to clear AsynchronousCaches.
25086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
25087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
25088         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
25089
25090 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
25091
25092         nrwt exits early too frequently
25093         https://bugs.webkit.org/show_bug.cgi?id=73843
25094
25095         Reviewed by Ryosuke Niwa.
25096
25097         Change the defaults for new-run-webkit-tests for both
25098         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
25099         to zero (i.e., we will never exit early by default).
25100
25101         If people want their buildbots to exit early it is their
25102         responsibility to update their buildbot configs appropriately.
25103
25104         Note that we have tests that ensure that these flags work for
25105         non-zero numbers, but we don't have tests that either test the
25106         default or ensure that zero means "run all of the tests". I
25107         think that's okay but can add tests if others disagree.
25108
25109         Also note that it looks like no changes on the build.webkit.org
25110         master.cfg are necessary; all of the bots seem to be using the
25111         RunWebKitTests wrapper which is already setting the flags. There
25112         is a NewRunWebKitTests wrapper, but that looks to be unused; I
25113         will delete that in a separate patch.
25114
25115         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
25116         (parse_args):
25117
25118 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
25119
25120         [EFL] [DRT] Reset CacheModel before running each test
25121         https://bugs.webkit.org/show_bug.cgi?id=87534
25122
25123         Reviewed by Gustavo Noronha Silva.
25124
25125         Reset cache model to default before running each test to fix some
25126         flaky tests on EFL build bots. Also fix case value in setCacheModel.
25127
25128         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
25129         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
25130         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
25131         (LayoutTestController::setCacheModel):
25132
25133 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
25134
25135         [GTK] Memory leaks in DRT EventSender.cpp
25136         https://bugs.webkit.org/show_bug.cgi?id=88774
25137
25138         Reviewed by Martin Robinson.
25139
25140         Fix a few possible memory leaks in EventSender code.
25141
25142         * DumpRenderTree/gtk/EventSender.cpp:
25143         (contextClickCallback): Free the event returned by gdk_event_new().
25144         (mouseDownCallback): Ditto.
25145         (mouseUpCallback): Ditto.
25146
25147 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
25148
25149         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
25150         https://bugs.webkit.org/show_bug.cgi?id=88661
25151
25152         Reviewed by Dirk Pranke.
25153
25154         Pass string length explicitly when creating String object from
25155         non-null-terminated UChar* returned by characters().
25156
25157         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
25158         (LayoutTestController::pathToLocalResource):
25159
25160 2012-06-11  David Dorwin  <ddorwin@chromium.org>
25161
25162         [chromium] Provide access to the WebPlugin created by the helper plugin widget
25163         https://bugs.webkit.org/show_bug.cgi?id=88028
25164
25165         Reviewed by Adam Barth.
25166
25167         Added isPlaceholder() to WebPlugin.
25168
25169         * DumpRenderTree/chromium/TestWebPlugin.h:
25170         (TestWebPlugin::isPlaceholder):
25171
25172 2012-06-11  Tony Chang  <tony@chromium.org>
25173
25174         rebaseline from garden-o-matic leaves N processes each time it is run
25175         https://bugs.webkit.org/show_bug.cgi?id=88586
25176
25177         Reviewed by Dirk Pranke.
25178
25179         This appears to only be a problem on python 2.7. Maybe a bug causing
25180         pools to not be garbage collected?
25181
25182         * Scripts/webkitpy/common/system/executive.py:
25183         (Executive.run_in_parallel): close() and join() the process pool.
25184         * Scripts/webkitpy/common/system/executive_unittest.py:
25185         (ExecutiveTest.test_run_in_parallel):
25186
25187 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
25188
25189         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
25190         https://bugs.webkit.org/show_bug.cgi?id=87841
25191
25192         Reviewed by Simon Hausmann.
25193
25194         * qmake/config.tests/libwebp/libwebp.cpp: Added.
25195         (main):
25196         * qmake/config.tests/libwebp/libwebp.pro: Added.
25197         * qmake/sync.profile:
25198
25199 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
25200
25201         Expose layoutTestController as testRunner
25202         https://bugs.webkit.org/show_bug.cgi?id=88210
25203
25204         Reviewed by Darin Adler.
25205
25206         * DumpRenderTree/LayoutTestController.cpp:
25207         (LayoutTestController::makeWindowObject):
25208         * DumpRenderTree/chromium/TestShell.cpp:
25209         (TestShell::bindJSObjectsToWindow):
25210         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
25211         (WebCore::DumpRenderTree::initJSObjects):
25212         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
25213         (WTR::LayoutTestController::makeWindowObject):
25214
25215 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
25216
25217         [Chromium] Remove JavaScriptCore dependencies from gyp
25218         https://bugs.webkit.org/show_bug.cgi?id=88510
25219
25220         Reviewed by Adam Barth.
25221
25222         Chromium doesn't support JSC any more and there doesn't seem to be
25223         a strong interest in using GYP as the common build system in other
25224         ports.
25225
25226         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
25227         * Scripts/generate-project-files: Removed.
25228
25229 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
25230
25231         Add UNDO_MANAGER flag
25232         https://bugs.webkit.org/show_bug.cgi?id=87908
25233
25234         Reviewed by Tony Chang.
25235
25236         * Scripts/webkitperl/FeatureList.pm:
25237         * qmake/mkspecs/features/features.pri:
25238
25239 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
25240
25241         webkit-patch land-safely should set cq? if the patch author is not in committers.py
25242         https://bugs.webkit.org/show_bug.cgi?id=88689
25243
25244         Reviewed by Dirk Pranke.
25245
25246         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
25247         in committers.py or the contributor cannot commit. If anything, the contributor can still
25248         set cq+ on thier patches manually so I don't think this will be an issue for people who
25249         don't list their Bugzille email on committers.py.
25250
25251         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
25252         (Bugzilla._commit_queue_flag):
25253         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
25254         (test_commit_queue_flag):
25255         (test_commit_queue_flag.assert_commit_queue_flag):
25256
25257 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
25258
25259         remove obsolete NewRunWebKitTests buildbot master factory classes
25260         https://bugs.webkit.org/show_bug.cgi?id=88693
25261
25262         Reviewed by Ryosuke Niwa.
25263
25264         I believe these aren't used any more ...
25265
25266         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
25267         (RunWebKitTests.getText2):
25268         (BuildAndTestLeaksFactory):
25269
25270 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
25271
25272         [Chromium-Android] Build DumpRenderTree with Android SDK
25273         https://bugs.webkit.org/show_bug.cgi?id=88598
25274
25275         Change WebKit side of DRT related code according to some recent changes at chromium side.
25276
25277         Reviewed by Adam Barth.
25278
25279         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
25280         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
25281         (ChromiumAndroidPort.__init__):
25282         (ChromiumAndroidPort._path_to_driver):
25283
25284 2012-06-08  Wei James  <james.wei@intel.com>
25285
25286         Add app_abi option for DumpRenderTree_apk
25287         https://bugs.webkit.org/show_bug.cgi?id=88626
25288
25289         Reviewed by Adam Barth.
25290
25291         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
25292
25293 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
25294
25295         [GTK] Add API to get the library version to WebKit2 GTK+
25296         https://bugs.webkit.org/show_bug.cgi?id=88426
25297
25298         Reviewed by Martin Robinson.
25299
25300         * gtk/generate-gtkdoc:
25301         (get_webkit2_options): Add built sources to the list of files, but
25302         ignore enum types and marshallers.
25303
25304 2012-06-07  Vincent Scheib  <scheib@chromium.org>
25305
25306         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
25307         https://bugs.webkit.org/show_bug.cgi?id=88604
25308
25309         Reviewed by Kent Tamura.
25310
25311         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
25312         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
25313
25314         * DumpRenderTree/chromium/WebViewHost.cpp:
25315         (WebViewHost::requestPointerUnlock):
25316
25317 2012-06-08  Hans Wennborg  <hans@chromium.org>
25318
25319         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
25320         https://bugs.webkit.org/show_bug.cgi?id=87976
25321
25322         Reviewed by Kent Tamura.
25323
25324         Provide a mock implementation of WebSpeechRecognizer for
25325         DumpRenderTree. This will allow better testing of the API via layout
25326         tests.
25327
25328         * DumpRenderTree/DumpRenderTree.gypi:
25329         * DumpRenderTree/chromium/LayoutTestController.cpp:
25330         (LayoutTestController::LayoutTestController):
25331         (LayoutTestController::addMockSpeechRecognitionResult):
25332         * DumpRenderTree/chromium/LayoutTestController.h:
25333         (LayoutTestController):
25334         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
25335         (MockWebSpeechRecognizer::create):
25336         (MockWebSpeechRecognizer::start):
25337         (MockWebSpeechRecognizer::stop):
25338         (MockWebSpeechRecognizer::abort):
25339         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
25340         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
25341         (MockWebSpeechRecognizer::ResultTask::runIfValid):
25342         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
25343         (WebKit):
25344         (MockWebSpeechRecognizer):
25345         (MockWebSpeechRecognizer::addMockResult):
25346         (MockWebSpeechRecognizer::taskList):
25347         (ClientCallTask):
25348         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
25349         (ResultTask):
25350         (MockWebSpeechRecognizer::ResultTask::ResultTask):
25351         (NoMatchTask):
25352         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
25353         * DumpRenderTree/chromium/WebViewHost.cpp:
25354         (WebViewHost::speechRecognizer):
25355         * DumpRenderTree/chromium/WebViewHost.h:
25356         (WebViewHost):
25357         (WebViewHost::mockSpeechRecognizer):
25358
25359 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
25360
25361         check-webkit-style needs to be taught about <public/Foo.h>
25362         https://bugs.webkit.org/show_bug.cgi?id=88524
25363
25364         Reviewed by David Levin.
25365
25366         * Scripts/webkitpy/style/checkers/cpp.py:
25367         (_classify_include):
25368         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
25369         (OrderOfIncludesTest.test_public_primary_header):
25370         (OrderOfIncludesTest.test_classify_include):
25371
25372 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
25373
25374         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
25375         https://bugs.webkit.org/show_bug.cgi?id=67255
25376
25377         Reviewed by Dirk Pranke.
25378
25379         Implement pathToLocalResource to redirect file:///tmp URL's to
25380         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
25381         LayoutTests sub-directory of the WebKit source tree.
25382
25383         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
25384         (LayoutTestController::pathToLocalResource):
25385
25386 2012-06-07  Tony Payne  <tpayne@chromium.org>
25387
25388         [chromium] Allow LayoutTests under new git workflow
25389         https://bugs.webkit.org/show_bug.cgi?id=88575
25390
25391         On Windows, chromium indirects through git.bat. Adds the same hack that
25392         is currently used for discovering svn.bat to support the new git
25393         workflow.
25394
25395         Reviewed by Dirk Pranke.
25396
25397         * Scripts/webkitpy/common/checkout/scm/git.py:
25398         (Git): Replaces all hard-coded references to 'git' with the class
25399         variable executable_name.
25400         (Git._check_git_architecture):
25401         (Git.in_working_directory):
25402         (Git.find_checkout_root):
25403         (Git.read_git_config):
25404         (Git.discard_local_commits):
25405         (Git.local_commits):
25406         (Git.working_directory_is_clean):
25407         (Git.clean_working_directory):
25408         (Git.status_command):
25409         (Git.add_list):
25410         (Git.delete_list):
25411         (Git.exists):
25412         (Git._current_branch):
25413         (Git.changed_files):
25414         (Git._changes_files_for_commit):
25415         (Git.revisions_changing_file):
25416         (Git.conflicted_files):
25417         (Git.svn_revision):
25418         (Git.create_patch):
25419         (Git._run_git_svn_find_rev):
25420         (Git.contents_at_revision):
25421         (Git.diff_for_file):
25422         (Git.show_head):
25423         (Git.committer_email_for_revision):
25424         (Git.apply_reverse_diff):
25425         (Git.revert_files):
25426         (Git.commit_with_message):
25427         (Git._commit_on_branch):
25428         (Git.svn_commit_log):
25429         (Git.last_svn_commit_log):
25430         (Git.svn_blame):
25431         (Git._branch_ref_exists):
25432         (Git.delete_branch):
25433         (Git.remote_merge_base):
25434         (Git.commit_locally_with_message):
25435         (Git.push_local_commits_to_server):
25436         (Git.commit_ids_from_commitish_arguments):
25437         (Git.commit_message_for_local_commit):
25438         (Git.files_changed_summary_for_commit):
25439         * Scripts/webkitpy/common/host.py:
25440         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
25441         that duplicates the logic in the existing 'svn.bat' hack.
25442
25443 2012-06-07  Ojan Vafai  <ojan@chromium.org>
25444
25445         Style build architectures like build versions for non-layout test failures
25446         https://bugs.webkit.org/show_bug.cgi?id=88590
25447
25448         Reviewed by Tony Chang.
25449
25450         Since we show the list of failing tests after the architecture, we want the
25451         buildtype and architecture to be grouped together visually.
25452
25453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
25454         (.effects a.failing-builder>span.architecture):
25455
25456 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
25457
25458         [Chromium] Remove header dependency of ImageDiff to WTF
25459         https://bugs.webkit.org/show_bug.cgi?id=88422
25460
25461         Reviewed by Ryosuke Niwa.
25462
25463         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
25464         * DumpRenderTree/chromium/ImageDiff.cpp:
25465         (untestedCompareImages):
25466
25467 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
25468
25469         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
25470         https://bugs.webkit.org/show_bug.cgi?id=88491
25471
25472         Reviewed by Dirk Pranke.
25473
25474         DRT should enable WebAudio when WebAudio feature is enabled,
25475         so that the WebAudio feature could be tested by the Layouttest.
25476
25477         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
25478         (LayoutTestController::overridePreference):
25479
25480 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
25481
25482         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
25483         https://bugs.webkit.org/show_bug.cgi?id=88581
25484
25485         Reviewed by Ojan Vafai.
25486
25487         webkit-paptch rebaseline-expectations was ignoring what the
25488         expected results for a test were and pulling down all the result
25489         files from a bot. This could lead to us pulling down old,
25490         incorrect .txt or .png files. With this patch we will now only
25491         pull down expectations of the appropriate file types (so an
25492         IMAGE failure will only pull the png and not the txt file).
25493
25494         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
25495         (has_pixel_failures):
25496         (suffixes_for_expectations):
25497         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
25498         (FunctionsTest.test_suffixes_for_expectations):
25499         * Scripts/webkitpy/tool/commands/rebaseline.py:
25500         (AbstractRebaseliningCommand.__init__):
25501         (RebaselineExpectations._is_supported_port):
25502         (RebaselineExpectations._update_expectations_file):
25503         (RebaselineExpectations._tests_to_rebaseline):
25504         (RebaselineExpectations._rebaseline_port):
25505         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
25506         (test_overrides_are_included_correctly):
25507
25508 2012-06-07  Ojan Vafai  <ojan@chromium.org>
25509
25510         Fix recent null pointer error regression in the flakiness dashboard
25511         https://bugs.webkit.org/show_bug.cgi?id=88573
25512
25513         Reviewed by Dirk Pranke.
25514
25515         * TestResultServer/static-dashboards/builders.js:
25516         (requestBuilderList):
25517         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
25518
25519 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
25520
25521         Add Konrad Piascik to committers.py
25522         https://bugs.webkit.org/show_bug.cgi?id=88560
25523
25524         Unreviewed.
25525
25526         * Scripts/webkitpy/common/config/committers.py:
25527
25528 2012-06-07  Tony Chang  <tony@chromium.org>
25529
25530         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
25531         https://bugs.webkit.org/show_bug.cgi?id=77368
25532
25533         Reviewed by Ojan Vafai.
25534
25535         It doesn't look like we ever get a rect with width or height of 0.
25536         I ran css1, css2.1, fast/forms, and tables without any crashes.
25537
25538         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
25539         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
25540
25541 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
25542
25543         run-webkit-tests --lint-test-files gives an error when run on linux
25544         https://bugs.webkit.org/show_bug.cgi?id=88551
25545
25546         Reviewed by Ojan Vafai.
25547
25548         We weren't mapping the expectations properly for the
25549         google-chrome ports.
25550
25551         * Scripts/webkitpy/layout_tests/port/base.py:
25552         (Port.path_to_test_expectations_file):
25553         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
25554         (TestGoogleChromePort.test_path_to_expectations):
25555
25556 2012-06-07  Daniel Erat  <derat@chromium.org>
25557
25558         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
25559         https://bugs.webkit.org/show_bug.cgi?id=88263
25560
25561         Reviewed by Tony Chang.
25562
25563         * DumpRenderTree/chromium/LayoutTestController.cpp:
25564         (LayoutTestController::LayoutTestController):
25565         (LayoutTestController::reset):
25566         (LayoutTestController::setTextSubpixelPositioning):
25567         * DumpRenderTree/chromium/LayoutTestController.h:
25568         (LayoutTestController):
25569         * DumpRenderTree/chromium/fonts.conf:
25570
25571 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
25572
25573         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
25574         https://bugs.webkit.org/show_bug.cgi?id=88060
25575
25576         Reviewed by Martin Robinson.
25577
25578         Spin the main loop before acquiring the pixel content. This ensures things
25579         like late size allocations are finished before calling gtk_widget_draw,
25580         avoiding assertions and subsequent empty pixel results.
25581
25582         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
25583         (createBitmapContextFromWebView):
25584
25585 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
25586
25587         [Qt] Improve the visual of the viewport info box
25588         https://bugs.webkit.org/show_bug.cgi?id=88410
25589
25590         Reviewed by Tor Arne Vestbø.
25591
25592         Improve the visual and make it possible to see the content more easy.
25593
25594         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
25595
25596 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
25597
25598         [EFL][WK2] Compile webkit1 and webkit2 by default.
25599         https://bugs.webkit.org/show_bug.cgi?id=85041
25600
25601         Reviewed by Chang Shu.
25602
25603         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
25604         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
25605
25606         * Scripts/build-webkit:
25607
25608 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
25609
25610         Unreviewed, rolling out r119662.
25611         http://trac.webkit.org/changeset/119662
25612         https://bugs.webkit.org/show_bug.cgi?id=88487
25613
25614         Broke builds (Requested by rniwa on #webkit).
25615
25616         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
25617         * DumpRenderTree/chromium/ImageDiff.cpp:
25618         (untestedCompareImages):
25619
25620 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
25621
25622         [Chromium] Remove header dependency of ImageDiff to WTF
25623         https://bugs.webkit.org/show_bug.cgi?id=88422
25624
25625         Reviewed by Adam Barth.
25626
25627         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
25628         * DumpRenderTree/chromium/ImageDiff.cpp:
25629         (untestedCompareImages):
25630
25631 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
25632
25633         [WebKit] DeviceOrientation cleanup
25634         https://bugs.webkit.org/show_bug.cgi?id=88406
25635
25636         Reviewed by Kent Tamura.
25637
25638         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
25639
25640         * DumpRenderTree/chromium/LayoutTestController.cpp:
25641         (LayoutTestController::setMockDeviceOrientation):
25642
25643 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
25644
25645         webkitpy: add support for an ordered dict of test expectations
25646         https://bugs.webkit.org/show_bug.cgi?id=87802
25647
25648         Reviewed by Ojan Vafai.
25649
25650         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
25651         support a cascaded list of test expectations files. An easy way
25652         to think of this is as an ordered dictionary of name -> contents
25653         for files, where the name is usually a path on disk (I say
25654         usually because we want to support other kinds of expectations
25655         like the compile-time skips for unsupported features in
25656         webkit.py, and we want to continue to support "in-memory" test
25657         expectations that don't require a filesystem).
25658
25659         Conveniently there is an OrderedDict implementation in Python
25660         2.7+ and it is available as a backport, so the first step in
25661         adding this support is to use that implementation. Subsequent
25662         patches will update the test_expectations.py module (and other
25663         callers) to access the dict directly.
25664
25665         This patch just changes the base internal implementation and
25666         provides wrappers for compatibility. The derived ports
25667         (WebKitPort, TestPort, etc.) still need to be updated.
25668
25669         * Scripts/webkitpy/layout_tests/port/base.py:
25670         (Port._expectations_dict):
25671         (Port.test_expectations):
25672         (Port):
25673         (Port._expectations_overrides_dict):
25674         (Port.test_expectations_overrides):
25675         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
25676         (PortTestCase.test_expectations_ordering):
25677         (PortTestCase):
25678         (PortTestCase.test_expectations_overrides_ordering):
25679         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
25680         (OrderedDict):
25681         (OrderedDict.__init__):
25682         (OrderedDict.clear):
25683         (OrderedDict.__setitem__):
25684         (OrderedDict.__delitem__):
25685         (OrderedDict.__iter__):
25686         (OrderedDict.__reversed__):
25687         (OrderedDict.popitem):
25688         (OrderedDict.__reduce__):
25689         (OrderedDict.__repr__):
25690         (OrderedDict.copy):
25691         (OrderedDict.fromkeys):
25692
25693 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
25694
25695         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
25696
25697         * gtk/run-api-tests:
25698         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
25699
25700 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
25701
25702         nrwt should look in 'out' for binaries on chromium win to support ninja
25703         https://bugs.webkit.org/show_bug.cgi?id=88273
25704
25705         Reviewed by Tony Chang.
25706
25707         This patch standardizes the search algorithm the chromium ports
25708         use to figure out which driver to run. We will look in a
25709         chromium location before a webkit location (e.g., in
25710         Source/WebKit/chromium/out before out/) and we will look in the
25711         "legacy" directory (xcodebuild) before the directory ninja uses
25712         (out).
25713
25714         Unfortunately due to the way the test code is set up testing the
25715         properly requires some duplication of test code. I will fix that
25716         in a followup patch.
25717
25718         * Scripts/webkitpy/layout_tests/port/chromium.py:
25719         (ChromiumPort):
25720         (ChromiumPort._static_build_path):
25721         (ChromiumPort._build_path):
25722         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
25723         (ChromiumLinuxPort):
25724         (ChromiumLinuxPort._determine_driver_path_statically):
25725         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
25726         (ChromiumLinuxPortTest.test_build_path):
25727         (ChromiumLinuxPortTest):
25728         (ChromiumLinuxPortTest.test_driver_name_option):
25729         (ChromiumLinuxPortTest.path_to_image_diff):
25730         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
25731         (ChromiumMacPort):
25732         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
25733         (ChromiumMacPortTest.test_build_path):
25734         (ChromiumMacPortTest):
25735         (ChromiumMacPortTest.test_driver_name_option):
25736         (ChromiumMacPortTest.path_to_image_diff):
25737         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
25738         (ChromiumPortTest.test_overrides_and_builder_names):
25739         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
25740         (ChromiumWinPort):
25741         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
25742         (ChromiumWinTest.test_build_path):
25743         (ChromiumWinTest.test_operating_system):
25744         (ChromiumWinTest):
25745         (ChromiumWinTest.test_driver_name_option):
25746         (ChromiumWinPortTest.path_to_image_diff):
25747         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
25748         (PortTestCase.assert_build_path):
25749
25750 2012-06-06  Jessie Berlin  <jberlin@apple.com>
25751
25752         Remove very red Windows WebKit2 testers
25753         https://bugs.webkit.org/show_bug.cgi?id=88452
25754
25755         Reviewed by Steve Falkenburg.
25756
25757         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
25758         need to focus on getting the WK1 testers green.
25759
25760         * BuildSlaveSupport/build.webkit.org-config/config.json:
25761
25762 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
25763
25764         get rebaselining tools to kinda work with the skia overrides file
25765         https://bugs.webkit.org/show_bug.cgi?id=88456
25766
25767         Reviewed by Ryosuke Niwa.
25768
25769         Update rebaseline-expectations so that we read in the overrides
25770         when looking for tests to rebaseline, but don't read in the
25771         overrides when we are writing the expectations file back out.
25772         This prevents the overrides from getting written into the main
25773         file. This is kind of a hack but will have to do until we
25774         support multiple expectations files properly.
25775
25776         * Scripts/webkitpy/tool/commands/rebaseline.py:
25777         (RebaselineExpectations._expectations):
25778         (RebaselineExpectations._update_expectations_file):
25779         (RebaselineExpectations._tests_to_rebaseline):
25780         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
25781         (test_overrides_are_included_correctly):
25782
25783 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
25784
25785         webkitpy: two manager_worker_broker_unittest tests are broken
25786         https://bugs.webkit.org/show_bug.cgi?id=88445
25787
25788         Reviewed by Ojan Vafai.
25789
25790         These tests were never updated when we removed the
25791         --worker-model argument, and we were passing 'inline' instead of
25792         1 (for the number of workers) :(. As a result we were creating
25793         multiprocessing queues unnecessarily and that was failing on cygwin.
25794
25795         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
25796         (InterfaceTest.test_managerconnection_is_abstract):
25797         (InterfaceTest.test_workerconnection_is_abstract):
25798
25799 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
25800
25801         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
25802         https://bugs.webkit.org/show_bug.cgi?id=87406
25803
25804         Reviewed by Dirk Pranke.
25805
25806         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
25807         (TestExpectations.__init__):
25808         * Scripts/webkitpy/tool/commands/rebaseline.py:
25809         (RebaselineTest._update_expectations_file):
25810         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
25811         (test_rebaseline_does_not_include_overrides):
25812
25813 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
25814
25815         webkitpy: perf tests unit tests fail on chromium win
25816         https://bugs.webkit.org/show_bug.cgi?id=88279
25817
25818         Reviewed by Ryosuke Niwa.
25819
25820         I'm seeing weird failures running the unit tests in my win32
25821         checkout, and we don't really expect webpagereplay to work on
25822         win32 anyway, so I'm skipping the import of that module for now
25823         and adding a warning.
25824
25825         * Scripts/run-perf-tests:
25826         * Scripts/webkitpy/performance_tests/perftest.py:
25827
25828 2012-06-06  Yong Li <yoli@rim.com>
25829
25830         Unreviewed. Update my email address in committers.py.
25831
25832         * Scripts/webkitpy/common/config/committers.py:
25833
25834 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
25835
25836         Add Robert Kroeger  to commiters.py
25837         https://bugs.webkit.org/show_bug.cgi?id=88415
25838
25839         Unreviewed.
25840
25841         * Scripts/webkitpy/common/config/committers.py:
25842
25843 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
25844
25845         [EFL][DRT] http/tests/globalhistory testcases do not pass
25846         https://bugs.webkit.org/show_bug.cgi?id=82579
25847
25848         Reviewed by Csaba Osztrogonác.
25849
25850         DRT has provided callbacks for ewk_view "global history delegate" signals.
25851
25852         * DumpRenderTree/efl/DumpRenderTree.cpp:
25853         (isGlobalHistoryTest): Aux function to ident global history testcase.
25854         (createLayoutTestController):
25855         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
25856         (DumpRenderTreeChrome::createView):
25857         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
25858         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
25859         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
25860         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
25861         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
25862         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
25863         (DumpRenderTreeChrome):
25864
25865 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
25866
25867         [Qt] run-qtwebkit-tests hangs with -j1
25868         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
25869         This could happen due to an uncancelled timer after results were returned. This timer was
25870         started only if --timeout was set.
25871         https://bugs.webkit.org/show_bug.cgi?id=85475
25872
25873         Reviewed by Csaba Osztrogonác.
25874
25875         * Scripts/run-qtwebkit-tests:
25876         (run_test):
25877
25878 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
25879
25880         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
25881         https://bugs.webkit.org/show_bug.cgi?id=88327
25882
25883         Reviewed by Kenneth Rohde Christiansen.
25884
25885         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
25886         * MiniBrowser/qt/icons/contents_width.png: Added.
25887         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
25888         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
25889
25890 2012-06-05  Jon Lee  <jonlee@apple.com>
25891
25892         Buildbot fix.
25893
25894         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
25895         in the function. Store in a local variable.
25896         (loadBuilderConfig):
25897
25898 2012-06-05  Jon Lee  <jonlee@apple.com>
25899
25900         Buildbot fix.
25901
25902         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
25903         (loadBuilderConfig):
25904
25905 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
25906
25907         webkitpy: clean up win-specific path handling and tests
25908         https://bugs.webkit.org/show_bug.cgi?id=88281
25909
25910         Reviewed by Adam Barth.
25911
25912         There was a bunch of inconsistent logic for handling path
25913         conversions for win32 and cygwin paths due to us sometimes
25914         looking at sys.platform and sometimes using mock hosts. This
25915         patch cleans everything up so that we are required to pass
25916         PlatformInfo objects to the path module and stop trying to do
25917         different things when running on cygwin or win32 hosts (except
25918         in the path_unittest module itself).
25919
25920         This may slightly reduce test coverage for the win32 code paths
25921         but will be a lot easier to follow and maintain.
25922
25923         * Scripts/webkitpy/common/system/path.py:
25924         (abspath_to_uri):
25925         (_convert_path):
25926         * Scripts/webkitpy/common/system/path_unittest.py:
25927         (AbspathTest.platforminfo):
25928         (AbspathTest.test_abspath_to_uri_cygwin):
25929         (AbspathTest.test_abspath_to_uri_unixy):
25930         (AbspathTest.test_abspath_to_uri_win):
25931         (AbspathTest.test_abspath_to_uri_escaping_unixy):
25932         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
25933         (AbspathTest.test_stop_cygpath_subprocess):
25934         * Scripts/webkitpy/common/system/platforminfo.py:
25935         (PlatformInfo.__init__):
25936         (PlatformInfo.is_cygwin):
25937         * Scripts/webkitpy/common/system/platforminfo_mock.py:
25938         (MockPlatformInfo.is_cygwin):
25939         * Scripts/webkitpy/layout_tests/port/base.py:
25940         (Port.to.show_results_html_file):
25941         * Scripts/webkitpy/layout_tests/port/driver.py:
25942         (Driver.test_to_uri):
25943         (Driver.uri_to_test):
25944         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
25945         (DriverTest.test_test_to_uri):
25946         (DriverTest.test_uri_to_test):
25947         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
25948         (MockDRTPortTest.make_port):
25949         (MockDRTTest.input_line):
25950         (MockChromiumDRTTest.test_pixeltest__fails):
25951         * Scripts/webkitpy/layout_tests/port/test.py:
25952         * Scripts/webkitpy/layout_tests/port/win.py:
25953         (WinPort.show_results_html_file):
25954         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
25955         (MainTest.test_unexpected_failures):
25956         (MainTest.test_results_directory_absolute):
25957         (MainTest.test_results_directory_default):
25958         (MainTest.test_results_directory_relative):
25959
25960 2012-06-05  Jon Lee  <jonlee@apple.com>
25961
25962         Workaround buildbot bug when merging build requests.
25963         https://bugs.webkit.org/show_bug.cgi?id=88158
25964
25965         Reviewed by Mark Rowe.
25966
25967         For expediency, we still want testers to pick the latest build to test, but to ensure
25968         that the builders are reporting the correct revision number, we should let the building bots
25969         run as they normally would. That is, the builder picks the oldest revision, and merges
25970         subsequent requests. Because merged requests get appended to the list of changes for a given
25971         build, the last change in that list is also the latest change. When we used pickLatestBuild
25972         for the builders, this was not the case (it would always report the penultimate change).
25973
25974         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
25975
25976         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
25977         for all Apple builders.
25978         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
25979         the latest build to run.
25980         (loadBuilderConfig):
25981
25982 2012-06-05  Jessie Berlin  <jberlin@apple.com>
25983
25984         [Win] DumpRenderTree should call resetInternalsObject
25985         https://bugs.webkit.org/show_bug.cgi?id=88346
25986
25987         Reviewed by Simon Fraser.
25988
25989         Invoke it on Windows in the same place it is invoked on Mac.
25990
25991         * DumpRenderTree/win/DumpRenderTree.cpp:
25992         (resetWebViewToConsistentStateBeforeTesting):
25993
25994 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
25995
25996         [GTK] Fix two more memory leaks in DRT
25997         https://bugs.webkit.org/show_bug.cgi?id=88255
25998
25999         Reviewed by Martin Robinson.
26000
26001         Fixed memory leaks in GTK's DRT code.
26002
26003         * DumpRenderTree/gtk/DumpRenderTree.cpp:
26004         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
26005         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
26006         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
26007         (createBitmapContextFromWebView): Free the cairo surface.
26008
26009 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
26010
26011         [Qt] Building when a top directory is named Source
26012         https://bugs.webkit.org/show_bug.cgi?id=77727
26013
26014         Reviewed by Tor Arne Vestbø.
26015
26016         Change regex to only replace the last instance of OUT_PWD.
26017
26018         * qmake/mkspecs/features/default_pre.prf:
26019
26020 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
26021
26022         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
26023         https://bugs.webkit.org/show_bug.cgi?id=73176
26024
26025         Reviewed by Adam Barth.
26026
26027         Two more APIs are added in Custom Scheme Handler specification.
26028         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
26029         One is 'isProtocolHandlerRegistered' to query whether the specific URL
26030         is registered or not.
26031         The other is 'unregisterProtocolHandler' to remove the registered URL.
26032
26033         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
26034
26035 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
26036
26037         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
26038         https://bugs.webkit.org/show_bug.cgi?id=83879
26039
26040         Reviewed by Carlos Garcia Campos.
26041
26042         Make minibrowser connect to the new 'permission requests' signal
26043         to allow users handle the Geolocation permission requests.
26044
26045         * MiniBrowser/gtk/BrowserWindow.c:
26046         (geolocationRequestDialogCallback): Callback for the dialog asking
26047         the user for allowing or not geolocation permission requests.
26048         (webViewDecidePermissionRequest): Launch a dialog to ask the user
26049         whether to allow or deny geolocation permission requests.
26050         (browserWindowConstructed): Connect to 'permission-request' signal.
26051
26052 2012-06-04  Chase Phillips  <cmp@google.com>
26053
26054         Make a builder group support+expect multiple loads.
26055         https://bugs.webkit.org/show_bug.cgi?id=88260
26056
26057         Change BuilderGroup to allow expecting multiple
26058         loads.  This allows merging results for a given set
26059         of builders into one group.
26060
26061         Add a test that verifies that the group count
26062         increments correctly based on successful and failed
26063         list loads.
26064
26065         Reviewed by Ojan Vafai.
26066
26067         * TestResultServer/static-dashboards/builders.js:
26068         (BuilderGroup):
26069         (BuilderGroup.prototype.setbuilder):
26070         (BuilderGroup.prototype.append):
26071         (BuilderGroup.prototype.loaded):
26072         (requestBuilderList.xhr.onload):
26073         (requestBuilderList.xhr.onerror):
26074         (onErrorLoadingBuilderList):
26075         (loadBuildersList):
26076         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
26077         (test):
26078         * TestResultServer/static-dashboards/run-unittests.html:
26079
26080 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
26081
26082         Python test fix attempt for Chromium Windows.
26083
26084         * Scripts/webkitpy/layout_tests/port/driver.py:
26085         (Driver.uri_to_test):
26086
26087 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
26088
26089         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
26090         https://bugs.webkit.org/show_bug.cgi?id=88243
26091
26092         Reviewed by Adam Barth.
26093
26094         * qmake/mkspecs/features/features.prf:
26095
26096 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
26097
26098         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
26099         https://bugs.webkit.org/show_bug.cgi?id=88280
26100
26101         Unreviewed, build fix.
26102
26103         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
26104         (TestServerProcess.test_basic):
26105
26106 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
26107
26108         test-webkitpy is hanging under cygwin
26109         https://bugs.webkit.org/show_bug.cgi?id=88269
26110
26111         Reviewed by Ryosuke Niwa.
26112
26113         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
26114         so we need to skip any tests that use it.
26115
26116         * Scripts/webkitpy/common/system/executive.py:
26117         (Executive.run_in_parallel):
26118         * Scripts/webkitpy/common/system/executive_unittest.py:
26119         (ExecutiveTest.test_run_in_parallel):
26120
26121 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
26122
26123         test-webkitpy is failing on win32 after r115054
26124         https://bugs.webkit.org/show_bug.cgi?id=88264
26125
26126         Reviewed by Ryosuke Niwa.
26127
26128         The failing http_server test was improperly suppressed (the
26129         tuple was missing a comma, and so wasn't a tuple at all, just a
26130         string) and so we were skipping *all* tests on win32. The right
26131         way to skip a single test is to disable it inside the test
26132         itself.
26133
26134         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
26135         (TestHttpServer.test_start_cmd):
26136         * Scripts/webkitpy/test/test_finder.py:
26137         (TestFinder._default_names):
26138         * Scripts/webkitpy/test/main.py:
26139         (Tester.run): Add error message if we don't find any tests to run.
26140         * Scripts/webkitpy/test/main_unittest.py:
26141             
26142
26143 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
26144
26145         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
26146         https://bugs.webkit.org/show_bug.cgi?id=88215
26147
26148         Reviewed by Martin Robinson.
26149
26150         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
26151         for newly allocated strings.
26152
26153         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
26154         (attributeSetToString):
26155         (AccessibilityUIElement::allAttributes):
26156
26157 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
26158
26159         [GTK] Memory leaks in DumpRenderTree.cpp
26160         https://bugs.webkit.org/show_bug.cgi?id=88213
26161
26162         Reviewed by Martin Robinson.
26163
26164         Fixed memory leaks in DumpRenderTree.
26165
26166         * DumpRenderTree/gtk/DumpRenderTree.cpp:
26167         (appendString): Accepts const gchar* as the second argument.
26168         (dumpFramesAsText): Free the string returned by g_strdup_printf().
26169         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
26170
26171 2012-06-04  David Dorwin  <ddorwin@chromium.org>
26172
26173         Enable Chromium media player to instantiate a plugin
26174         https://bugs.webkit.org/show_bug.cgi?id=87399
26175
26176         Reviewed by Kent Tamura.
26177
26178         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
26179
26180         * DumpRenderTree/chromium/WebViewHost.cpp:
26181         (WebViewHost::createPopupMenu):
26182
26183 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
26184
26185         [GTK][WK2] Implement geolocation provider for the GTK port
26186         https://bugs.webkit.org/show_bug.cgi?id=83877
26187
26188         Reviewed by Carlos Garcia Campos.
26189
26190         * gtk/generate-gtkdoc:
26191         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
26192
26193 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
26194
26195         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
26196         https://bugs.webkit.org/show_bug.cgi?id=87668
26197
26198         Reviewed by Ryosuke Niwa.
26199
26200         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
26201         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
26202         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
26203
26204         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
26205         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
26206
26207 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
26208
26209         [EFL] Refactor ewk_view_context_paint code.
26210         https://bugs.webkit.org/show_bug.cgi?id=85588
26211
26212         Reviewed by Hajime Morita.
26213
26214         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
26215
26216 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
26217
26218         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
26219         https://bugs.webkit.org/show_bug.cgi?id=87869
26220
26221         Reviewed by Andreas Kling.
26222
26223         Replace %lld by PRId64 macro to print an int64_t value and silent a
26224         compilation warning on 64-Bit.
26225
26226         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
26227         (onExceededApplicationCacheQuota):
26228
26229 2012-06-03  Varun Jain  <varunjain@google.com>
26230
26231         [chromium] Add new gesture type (two finger tap) that triggers context menu.
26232         https://bugs.webkit.org/show_bug.cgi?id=88173
26233
26234         Reviewed by Adam Barth.
26235
26236         * DumpRenderTree/chromium/EventSender.cpp:
26237         (EventSender::EventSender):
26238         (EventSender::gestureTwoFingerTap):
26239         (EventSender::gestureEvent):
26240         * DumpRenderTree/chromium/EventSender.h:
26241         (EventSender):
26242
26243 2012-06-02  Zeno Albisser  <zeno@webkit.org>
26244
26245         Fix and enable WebGL for WebKit2 on Qt.
26246         https://bugs.webkit.org/show_bug.cgi?id=86214
26247
26248         Enable WebGL by default for Qt MiniBrowser.
26249
26250         Reviewed by Noam Rosenthal.
26251
26252         * MiniBrowser/qt/qml/BrowserWindow.qml:
26253
26254 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
26255
26256         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
26257         https://bugs.webkit.org/show_bug.cgi?id=88164
26258
26259         Reviewed by Kentaro Hara.
26260
26261         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
26262         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
26263
26264         * Scripts/VCSUtils.pm:
26265         (adjustPathForRecentRenamings):
26266         (fixChangeLogPatch):
26267
26268 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
26269
26270         Rename test_expectations.txt to TestExpectations
26271         https://bugs.webkit.org/show_bug.cgi?id=86690
26272
26273         Reviewed by Dirk Pranke.
26274
26275         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
26276         We can the code to read test_expectations.txt once we've successfully transitioned.
26277
26278         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
26279         (TestExpectationParser._check_path_does_not_exist):
26280         (TestExpectationParser._tokenize):
26281         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
26282         * Scripts/webkitpy/layout_tests/port/base.py:
26283         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
26284         test_expectations.txt if one exists and the path to TestExpectations otherwise.
26285         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
26286         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
26287         virtual.
26288         * Scripts/webkitpy/layout_tests/port/chromium.py:
26289         (ChromiumPort.path_from_chromium_base):
26290         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
26291         (ChromiumAndroidPort.test_expectations):
26292         * Scripts/webkitpy/layout_tests/port/test.py:
26293         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
26294         (TestPort.__init__):
26295         * Scripts/webkitpy/layout_tests/port/webkit.py:
26296         (WebKitPort.baseline_search_path):
26297         (WebKitPort.test_expectations):
26298         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
26299         tests to base as a follow up.
26300         (WebKitPortTest.test_path_to_test_expectations_file):
26301         (test_test_expectations):
26302         (test_legacy_test_expectations):
26303         * Scripts/webkitpy/style/checker.py:
26304         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
26305         with one for TestExpectations.
26306         * Scripts/webkitpy/style/checkers/test_expectations.py:
26307         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
26308         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
26309         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
26310         test_expectations.txt.
26311         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
26312         (TestExpectationsTestCase.assert_lines_lint):
26313         * Scripts/webkitpy/tool/commands/queries.py:
26314         (PrintExpectations.__init__):
26315         * Scripts/webkitpy/tool/commands/rebaseline.py:
26316         (RebaselineExpectations):
26317         * Scripts/webkitpy/tool/steps/commit.py:
26318         (Commit._check_test_expectations):
26319         * Scripts/webkitpy/tool/steps/commit_unittest.py:
26320         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
26321         (CommitTest.test_check_test_expectations): For TestExpectations.
26322         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
26323         * TestResultServer/static-dashboards/dashboard_base.js:
26324         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
26325         Error only when neither exists.
26326         * TestResultServer/static-dashboards/flakiness_dashboard.js:
26327         (processMissingAndExtraExpectations):
26328         (htmlForTestsWithExpectationsButNoFailures):
26329         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
26330
26331 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
26332
26333         Remove dependency from ImageDiff to WTF
26334         https://bugs.webkit.org/show_bug.cgi?id=88147
26335
26336         Reviewed by Adam Barth.
26337
26338         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
26339
26340 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
26341
26342         NRWT seems to leak (more?) temp dirs
26343         https://bugs.webkit.org/show_bug.cgi?id=88126
26344
26345         Re-land r119297 with chromium fix (weren't calling the
26346         super() method if not in --test-shell mode in start().
26347         Add unit tests to chromium_unittest as well to check.
26348
26349         * Scripts/webkitpy/layout_tests/port/chromium.py:
26350         (ChromiumDriver.start):
26351         * Scripts/webkitpy/layout_tests/port/webkit.py:
26352         (WebKitDriver.__del__):
26353         (WebKitDriver._start):
26354         (WebKitDriver.run_test):
26355         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
26356         (WebKitDriverTest.test_check_for_driver_crash):
26357         (WebKitDriverTest.test_stop_cleans_up_properly):
26358         (WebKitDriverTest):
26359         (WebKitDriverTest.test_two_starts_cleans_up_properly):
26360         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
26361         (ChromiumDriverTest.test_stop_cleans_up_properly):
26362         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
26363
26364 2012-06-01  Tim Horton  <timothy_horton@apple.com>
26365
26366         Lots of "failed download-built-product" on Apple bots
26367         https://bugs.webkit.org/show_bug.cgi?id=88158
26368
26369         Reviewed by Jessie Berlin.
26370         
26371         Disable mergeRequests on all Apple builders. This is a speculative fix.
26372
26373         * BuildSlaveSupport/build.webkit.org-config/config.json:
26374
26375 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
26376
26377         Unreviewed, rolling out r119297.
26378         http://trac.webkit.org/changeset/119297
26379         https://bugs.webkit.org/show_bug.cgi?id=88156
26380
26381         May have broken Chromium bots (Requested by rniwa on #webkit).
26382
26383         * Scripts/webkitpy/layout_tests/port/webkit.py:
26384         (WebKitDriver.__del__):
26385         (WebKitDriver.run_test):
26386         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
26387         (WebKitDriverTest.test_check_for_driver_crash):
26388         (WebKitDriverTest.test_stop_cleans_up_properly):
26389
26390 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
26391
26392         nrwt seems to leak tmpdirs
26393         https://bugs.webkit.org/show_bug.cgi?id=88126
26394
26395         Reviewed by Ojan Vafai.
26396
26397         Fix leak possibly introduced in r118979 - we now will
26398         make sure we clean up any stale temp directories during the
26399         start routine and attempt to clean up again in __del__. It
26400         turns out that asserting in __del__ logs a message but is
26401         caught by the runtime, so it's mostly useless.
26402
26403         * Scripts/webkitpy/layout_tests/port/webkit.py:
26404         (WebKitDriver.__del__):
26405         (WebKitDriver._start):
26406         (WebKitDriver.run_test):
26407         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
26408         (WebKitDriverTest.test_check_for_driver_crash):
26409         (WebKitDriverTest.test_stop_cleans_up_properly):
26410         (WebKitDriverTest):
26411         (WebKitDriverTest.test_two_starts_cleans_up_properly):
26412
26413 2012-06-01  Michael Saboff  <msaboff@apple.com>
26414
26415         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
26416         https://bugs.webkit.org/show_bug.cgi?id=88109
26417
26418         Reviewed by Geoffrey Garen.
26419
26420         Additional test case.
26421
26422         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
26423         (TestWebKitAPI::TEST):
26424
26425 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
26426
26427         [Qt] Use -Werror only in developer builds
26428
26429         Rubber-stamped by Tor Arne Vestbø.
26430
26431         In production builds -Werror with custom toolchains and wierd system
26432         headers, -Werror is of no use and just creates confusion. So use it
26433         only if Qt is configured with -developer-build.
26434
26435         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
26436         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
26437         only if qt_developer_build is set.
26438
26439 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
26440
26441         [watchlist] Add myself to loader and v8 bindings changes
26442         https://bugs.webkit.org/show_bug.cgi?id=88112
26443
26444         Reviewed by Adam Barth.
26445
26446         * Scripts/webkitpy/common/config/watchlist:
26447
26448 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
26449
26450         Adding Jacky Jiang to committers.py
26451         https://bugs.webkit.org/show_bug.cgi?id=88122
26452
26453         Reviewed by Rob Buis.
26454
26455         Adding myself to committers.py as a Committer.
26456
26457         * Scripts/webkitpy/common/config/committers.py:
26458
26459 2012-06-01  Jessie Berlin  <jberlin@apple.com>
26460
26461         Fix Windows build.
26462
26463         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
26464
26465 2012-06-01  Jessie Berlin  <jberlin@apple.com>
26466
26467         Windows WK2 MouseMoveAfterCrash API test failing
26468         https://bugs.webkit.org/show_bug.cgi?id=69982
26469
26470         Disable the test on Windows to get the bots greener.
26471
26472         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
26473         (TestWebKitAPI::TEST):
26474
26475 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
26476
26477         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
26478         https://bugs.webkit.org/show_bug.cgi?id=86866
26479
26480         Reviewed by Adam Barth.
26481
26482         Catch new "intent,service,register" signal on the frame and print out
26483         information about the Web Intent service in EFL's DumpRenderTree.
26484
26485         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
26486         (DumpRenderTreeChrome::createView):
26487         (DumpRenderTreeChrome::onFrameCreated):
26488         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
26489         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
26490         (DumpRenderTreeChrome):
26491
26492 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
26493
26494         The ChangeLog parser cannot handle reviewers with initials in their name
26495         https://bugs.webkit.org/show_bug.cgi?id=87864
26496
26497         Reviewed by Ryosuke Niwa.
26498
26499         Add support in the ChangeLog parser for reviewer names that have
26500         initials in them.
26501
26502         * Scripts/webkitpy/common/checkout/changelog.py:
26503         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
26504         in the replacement string. This allows for matching the word characters before a
26505         period, without totally throwing them away.
26506         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
26507         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
26508         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
26509
26510 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
26511
26512         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
26513         https://bugs.webkit.org/show_bug.cgi?id=86865
26514
26515         Reviewed by Adam Barth.
26516
26517         Add deliverWebIntent method to LayoutTestController and provide
26518         implementation for EFL port.
26519
26520         * DumpRenderTree/LayoutTestController.cpp:
26521         (deliverWebIntentCallback):
26522         (LayoutTestController::staticFunctions):
26523         * DumpRenderTree/LayoutTestController.h:
26524         (LayoutTestController):
26525         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
26526         (LayoutTestController::deliverWebIntent):
26527         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
26528         (LayoutTestController::deliverWebIntent):
26529         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
26530         (LayoutTestController::deliverWebIntent):
26531         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
26532         (LayoutTestController::deliverWebIntent):
26533         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
26534         (LayoutTestController::deliverWebIntent):
26535         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
26536         (LayoutTestController::deliverWebIntent):
26537
26538 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
26539
26540         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
26541
26542         Reviewed by Simon Hausmann.
26543
26544         * Tools.pro:
26545
26546 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
26547
26548         Add public page loading performance tests using web-page-replay
26549         https://bugs.webkit.org/show_bug.cgi?id=84008
26550
26551         Reviewed by Dirk Pranke.
26552
26553         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
26554         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
26555         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
26556
26557         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
26558         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
26559         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
26560         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
26561
26562         * Scripts/webkitpy/layout_tests/port/driver.py:
26563         (Driver.is_external_http_test): Added.
26564         * Scripts/webkitpy/layout_tests/port/webkit.py:
26565         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
26566         * Scripts/webkitpy/performance_tests/perftest.py:
26567         (PerfTest.__init__): Takes port.
26568         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
26569         (PerfTest):
26570         (PerfTest.run): Calls run_single.
26571         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
26572         (ChromiumStylePerfTest.__init__):
26573         (PageLoadingPerfTest.__init__):
26574         (PageLoadingPerfTest.run):
26575         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
26576         (ReplayServer.__init__):
26577         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
26578         but it caused a dead lock on some web pages.
26579         (ReplayServer.stop):
26580         (ReplayServer.__del__):
26581         (ReplayPerfTest):
26582         (ReplayPerfTest.__init__):
26583         (ReplayPerfTest._start_replay_server):
26584         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
26585         The subsequent runs of the same test will just use test.wpr.
26586         (ReplayPerfTest.run_single):
26587         (PerfTestFactory):
26588         (PerfTestFactory.create_perf_test):
26589         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
26590         (MainTest.test_parse_output):
26591         (MainTest.test_parse_output_with_failing_line):
26592         (TestPageLoadingPerfTest.test_run):
26593         (TestPageLoadingPerfTest.test_run_with_bad_output):
26594         (TestReplayPerfTest):
26595         (TestReplayPerfTest.ReplayTestPort):
26596         (TestReplayPerfTest.ReplayTestPort.__init__):
26597         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
26598         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
26599         (TestReplayPerfTest.ReplayTestPort._driver_class):
26600         (TestReplayPerfTest.MockReplayServer):
26601         (TestReplayPerfTest.MockReplayServer.__init__):
26602         (TestReplayPerfTest.MockReplayServer.stop):
26603         (TestReplayPerfTest._add_file):
26604         (TestReplayPerfTest._setup_test):
26605         (TestReplayPerfTest.test_run_single):
26606         (TestReplayPerfTest.test_run_single.run_test):
26607         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
26608         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
26609         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
26610         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
26611         (TestReplayPerfTest.test_prepare):
26612         (TestReplayPerfTest.test_prepare.run_test):
26613         (TestReplayPerfTest.test_prepare_calls_run_single):
26614         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
26615         (TestPerfTestFactory.test_regular_test):
26616         (TestPerfTestFactory.test_inspector_test):
26617         (TestPerfTestFactory.test_page_loading_test):
26618         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
26619         (PerfTestsRunner):
26620         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
26621         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
26622         (PerfTestsRunner._collect_tests._is_test_file):
26623         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
26624         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
26625         (create_runner):
26626         (run_test):
26627         (_tests_for_runner):
26628         (test_run_test_set):
26629         (test_run_test_set_kills_drt_per_run):
26630         (test_run_test_pause_before_testing):
26631         (test_run_test_set_for_parser_tests):
26632         (test_run_test_set_with_json_output):
26633         (test_run_test_set_with_json_source):
26634         (test_run_test_set_with_multiple_repositories):
26635         (test_run_with_upload_json):
26636         (test_upload_json):
26637         (test_upload_json.MockFileUploader.upload_single_text_file):
26638         (_add_file):
26639         (test_collect_tests):
26640         (test_collect_tests_with_multile_files):
26641         (test_collect_tests_with_multile_files.add_file):
26642         (test_collect_tests_with_skipped_list):
26643         (test_collect_tests_with_page_load_svg):
26644         (test_collect_tests_should_ignore_replay_tests_by_default):
26645         (test_collect_tests_with_replay_tests):
26646         (test_parse_args):
26647         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
26648         (AutoinstallImportHook.find_module):
26649         (AutoinstallImportHook._install_webpagereplay):
26650
26651 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
26652
26653         Support building the Android port of chromium with Ninja
26654         https://bugs.webkit.org/show_bug.cgi?id=87545
26655
26656         Reviewed by Adam Barth.
26657
26658         Ensures that shared libraries are looked up in a generator-agnostic
26659         way and that output is placed in the correct directory.
26660
26661         Depends on http://codereview.chromium.org/10386188/
26662
26663         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
26664
26665 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
26666
26667         [Chromium] Chromium DRT should be able to load external resources
26668         https://bugs.webkit.org/show_bug.cgi?id=87893
26669
26670         Reviewed by Dirk Pranke.
26671
26672         Allow external resources to be loaded when the main frame's URL is also an external resource.
26673         This change is analogous to r118231 for Mac port.
26674
26675         * DumpRenderTree/chromium/WebViewHost.cpp:
26676         (blockRequest):
26677         (isLocalhost):
26678         (hostIsUsedBySomeTestsToGenerateError):
26679         (WebViewHost::willSendRequest):
26680
26681 2012-05-31  Anders Carlsson  <andersca@apple.com>
26682
26683         Build fixes.
26684
26685         Disable the C++11 extensions warning.
26686
26687         * DumpRenderTree/mac/Configurations/Base.xcconfig:
26688         * TestWebKitAPI/Configurations/Base.xcconfig:
26689         * WebKitTestRunner/Configurations/Base.xcconfig:
26690
26691 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
26692
26693         [WK2] window.internals settings are not reset between tests
26694         https://bugs.webkit.org/show_bug.cgi?id=87783
26695
26696         Reviewed by Mihai Parparita.
26697
26698         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
26699         (WTR::InjectedBundle::done): Call resetAfterTest().
26700
26701         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
26702         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
26703         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
26704         This needs to be done after a tets, because the code assumes that there is an object
26705         with this name in global scope.
26706
26707         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
26708
26709 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
26710
26711         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
26712         https://bugs.webkit.org/show_bug.cgi?id=85006
26713
26714         Reviewed by Tor Arne Vestbø.
26715
26716         Added navigation_policy_decision implementation for DumpRenderTreeView.
26717         Added LayoutTestController::setCustomPolicyDelegate implementation.
26718         Modified LayoutTestController::waitForPolicyDelegate.
26719
26720         * DumpRenderTree/efl/DumpRenderTree.cpp:
26721         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
26722         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
26723         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
26724         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
26725         (navigationTypeToString): aux function
26726         (onNavigationPolicyDecision): navigation_policy_decision implementation
26727         (drtViewAdd):
26728         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
26729         (LayoutTestController::setCustomPolicyDelegate):
26730         (LayoutTestController::waitForPolicyDelegate):
26731
26732 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
26733
26734         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
26735         https://bugs.webkit.org/show_bug.cgi?id=86195
26736
26737         Reviewed by Gustavo Noronha Silva.
26738
26739         Implement clearApplicationCacheForOrigin in EFL
26740         LayoutTestController.
26741
26742         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
26743         (LayoutTestController::clearApplicationCacheForOrigin):
26744
26745 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
26746
26747         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
26748         https://bugs.webkit.org/show_bug.cgi?id=87955
26749
26750         Reviewed by Simon Hausmann.
26751
26752         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
26753         * DumpRenderTree/qt/EventSenderQt.cpp:
26754         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
26755         * DumpRenderTree/qt/main.cpp:
26756         * QtTestBrowser/cookiejar.cpp:
26757         * QtTestBrowser/launcherwindow.cpp:
26758         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
26759         * qmake/mkspecs/features/default_post.prf:
26760
26761 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
26762
26763         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
26764
26765         Rubber-stamped by Kenneth Rohde Christiansen.
26766
26767         * qmake/config.tests/libpng/libpng.pro:
26768
26769 2012-05-30  Peter Beverloo  <peter@chromium.org>
26770
26771         [Chromium] Automatically install 64-bit linker for Android
26772         https://bugs.webkit.org/show_bug.cgi?id=79780
26773
26774         Reviewed by Adam Barth.
26775
26776         Change the update-webkit-chromium script to check whether the 64-bit
26777         linker needs to be installed as part of the update process. The actual
26778         code for doing these checks and "installing" it has been added to the
26779         webkitdirs.pm script.
26780
26781         The linker itself is part of the third_party/aosp repository, which
26782         will be pulled in through the DEPS change.
26783
26784         * Scripts/update-webkit-chromium:
26785         * Scripts/webkitdirs.pm:
26786         (chromiumInstall64BitAndroidLinkerIfNeeded):
26787         (chromiumReplaceAndroidLinkerIfNeeded):
26788
26789 2012-05-30  Stephanie Lewis  <slewis@apple.com>
26790
26791         https://bugs.webkit.org/show_bug.cgi?id=87803
26792         Layout tests often fail trying to stat nonexistent logs 
26793
26794         Reviewed by Dirk Pranke.
26795
26796         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
26797         try/catch block around accessing the logs as a precaution.
26798
26799         * Scripts/webkitpy/common/system/crashlogs.py:
26800         (CrashLogs._find_newest_log_darwin):
26801
26802 2012-05-30  Gavin Peters  <gavinp@chromium.org>
26803
26804         Add a LayoutTest for prerender remove after stop.
26805         https://bugs.webkit.org/show_bug.cgi?id=87860
26806
26807         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
26808         can be tested by LayoutTests now.
26809
26810         Reviewed by Adam Barth.
26811
26812         * DumpRenderTree/DumpRenderTree.gypi:
26813         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
26814         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
26815         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
26816         (MockWebPrerenderingSupport::add):
26817         (MockWebPrerenderingSupport::cancel):
26818         (MockWebPrerenderingSupport::abandon):
26819         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
26820         (MockWebPrerenderingSupport):
26821         * DumpRenderTree/chromium/TestShell.cpp:
26822         (TestShell::initialize):
26823         * DumpRenderTree/chromium/TestShell.h:
26824         (TestShell):
26825         * DumpRenderTree/chromium/WebViewHost.cpp:
26826         (WebViewHost::willAddPrerender):
26827         (WebViewHost::setWebWidget):
26828         * DumpRenderTree/chromium/WebViewHost.h:
26829         (WebViewHost):
26830
26831 2012-05-30  Stephanie Lewis  <slewis@apple.com>
26832
26833         https://bugs.webkit.org/show_bug.cgi?id=87717
26834         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
26835
26836         Reviewed by Dirk Pranke.
26837
26838         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
26839         If there isn't a crash log found for the process add a message saying
26840         the process was unresponsive.
26841
26842         * Scripts/webkitpy/layout_tests/port/webkit.py:
26843         (WebKitDriver.__init__):
26844         (WebKitDriver._check_for_driver_crash):
26845         (WebKitDriver.run_test):
26846         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
26847         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
26848         (WebKitDriverTest):
26849         (WebKitDriverTest.test_check_for_driver_crash):
26850         * WebKitTestRunner/TestController.cpp:
26851         (WTR):
26852         (WTR::TestController::runTest):
26853
26854 2012-05-30  Stephanie Lewis  <slewis@apple.com>
26855
26856         https://bugs.webkit.org/show_bug.cgi?id=87714
26857         Mac crash logs can take a really long time to be written out.
26858
26859         Reviewed by Dirk Pranke.
26860
26861         Make a second pass looking for crash logs after the tests have completed running.
26862
26863         * Scripts/webkitpy/layout_tests/controllers/manager.py:
26864         (use_trac_links_in_results_html):
26865         (Manager.run):
26866         * Scripts/webkitpy/layout_tests/port/base.py:
26867         (Port.repository_paths):
26868         (Port.look_for_new_crash_logs):
26869         * Scripts/webkitpy/layout_tests/port/mac.py:
26870         (MacPort.look_for_new_crash_logs):
26871         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
26872         (test_get_crash_log):
26873         (test_look_for_new_crash_logs):
26874         (test_look_for_new_crash_logs.fake_time_cb):
26875
26876 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
26877
26878         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
26879
26880         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
26881         (LayoutWebViewEventHandler::OnAlertEvent):
26882         (LayoutWebViewEventHandler::OnConfirmEvent):
26883         (LayoutWebViewEventHandler):
26884         (LayoutWebViewEventHandler::OnPromptEvent):
26885         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
26886         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
26887
26888 2012-05-30  Ojan Vafai  <ojan@chromium.org>
26889
26890         Only give lint errors for -expected.png png files that lack a checksum
26891         https://bugs.webkit.org/show_bug.cgi?id=87875
26892
26893         Reviewed by Tony Chang.
26894
26895         We have other pngs in the tree, e.g. for the inspector, that legitimately
26896         lack a checksum.
26897
26898         * Scripts/webkitpy/style/checkers/png.py:
26899         (PNGChecker.check):
26900         * Scripts/webkitpy/style/checkers/png_unittest.py:
26901         (PNGCheckerTest.test_check):
26902
26903 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
26904
26905         nrwt: seems to leak temp dirs
26906         https://bugs.webkit.org/show_bug.cgi?id=87795
26907
26908         Reviewed by Ojan Vafai.
26909
26910         There appears to be a bug where the chromium bots are creating
26911         temporary directories and not cleaning them up that started
26912         after the switch to WebKitDriver. It's possible that __del__
26913         wasn't getting called in a timely manner (or at all), and it's
26914         generally bad style to rely on __del__ being called, so this
26915         code changes things so that we create a temp dir in
26916         driver.start() and remove it in driver.stop(). We could be
26917         paranoid and leave the __del__ code in, but there doesn't seem
26918         to be much advantage to it. If there are bugs that result in
26919         drivers being started but not stopped, we have other problems.
26920
26921         * Scripts/webkitpy/common/system/filesystem_mock.py:
26922         (MockFileSystem.__init__):
26923         (MockFileSystem._mktemp):
26924         (MockFileSystem.mkdtemp):
26925         * Scripts/webkitpy/layout_tests/port/webkit.py:
26926         (WebKitDriver.__init__):
26927         (WebKitDriver._start):
26928         (WebKitDriver.stop):
26929         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
26930         (WebKitDriverTest.test_check_for_driver_crash):
26931         (WebKitDriverTest):
26932         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
26933         (WebKitDriverTest.test_stop_cleans_up_properly):
26934
26935 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
26936
26937         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
26938         https://bugs.webkit.org/show_bug.cgi?id=86841
26939
26940         Reviewed by Adam Barth.
26941
26942         Print the number of MessagePorts for each new intent in EFL's DRT.
26943         This output is expected by several Web Intents test cases.
26944
26945         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
26946         (DumpRenderTreeChrome::onFrameIntentNew):
26947
26948 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
26949
26950         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
26951
26952         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
26953
26954 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
26955
26956         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
26957         https://bugs.webkit.org/show_bug.cgi?id=87829
26958
26959         Reviewed by Adam Barth.
26960
26961         EFL's LayoutTestController now makes uses of the new helper method in
26962         DumpRenderTreeSupportEfl in order to send the intent response. This is
26963         now needed because the Ewk_Intent_Request postResult / postFailure
26964         methods were made private.
26965
26966         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
26967         (LayoutTestController::sendWebIntentResponse):
26968
26969 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
26970
26971         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
26972         https://bugs.webkit.org/show_bug.cgi?id=86296
26973
26974         Reviewed by Tony Chang.
26975
26976         * DumpRenderTree/win/DRTDataObject.cpp: Added.
26977         (cfHDropFormat):
26978         (cfFileNameWFormat):
26979         (cfUrlWFormat):
26980         (WCEnumFormatEtc):
26981         (WCEnumFormatEtc::WCEnumFormatEtc):
26982         (WCEnumFormatEtc::QueryInterface):
26983         (WCEnumFormatEtc::AddRef):
26984         (WCEnumFormatEtc::Release):
26985         (WCEnumFormatEtc::Next):
26986         (WCEnumFormatEtc::Skip):
26987         (WCEnumFormatEtc::Reset):
26988         (WCEnumFormatEtc::Clone):
26989         (DRTDataObject::createInstance):
26990         (DRTDataObject::DRTDataObject):
26991         (DRTDataObject::~DRTDataObject):
26992         (DRTDataObject::QueryInterface):
26993         (DRTDataObject::AddRef):
26994         (DRTDataObject::Release):
26995         (DRTDataObject::GetData):
26996         (DRTDataObject::GetDataHere):
26997         (DRTDataObject::QueryGetData):
26998         (DRTDataObject::GetCanonicalFormatEtc):
26999         (DRTDataObject::SetData):
27000         (DRTDataObject::CopyMedium):
27001         (DRTDataObject::EnumFormatEtc):
27002         (DRTDataObject::DAdvise):
27003         (DRTDataObject::DUnadvise):
27004         (DRTDataObject::EnumDAdvise):
27005         (DRTDataObject::clearData):
27006         * DumpRenderTree/win/DRTDataObject.h: Added.
27007         (DRTDataObject):
27008         * DumpRenderTree/win/DRTDropSource.cpp: Added.
27009         (DRTDropSource::DRTDropSource):
27010         (DRTDropSource::~DRTDropSource):
27011         (DRTDropSource::QueryInterface):
27012         (DRTDropSource::AddRef):
27013         (DRTDropSource::Release):
27014         (DRTDropSource::createInstance):
27015         (DRTDropSource::QueryContinueDrag):
27016         (DRTDropSource::GiveFeedback):
27017         * DumpRenderTree/win/DRTDropSource.h: Added.
27018         (DRTDropSource):
27019         * DumpRenderTree/win/DumpRenderTree.vcproj:
27020         * DumpRenderTree/win/EventSender.cpp:
27021         (beginDragWithFilesCallback):
27022
27023 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
27024
27025         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
27026         https://bugs.webkit.org/show_bug.cgi?id=58593
27027
27028         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
27029         to WebKitTestRunner's LayoutTestController. The flag is modified via the
27030         public C API of the WebProcess.
27031
27032         Reviewed by Darin Adler.
27033
27034         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
27035         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
27036         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
27037         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
27038         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
27039
27040 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
27041
27042         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
27043         https://bugs.webkit.org/show_bug.cgi?id=87848
27044
27045         Reviewed by Csaba Osztrogonác.
27046
27047         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
27048         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
27049         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
27050
27051         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
27052         (DumpRenderTreeChrome::extraViews):
27053         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
27054         (DumpRenderTreeChrome):
27055
27056 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
27057
27058         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
27059         https://bugs.webkit.org/show_bug.cgi?id=87833
27060
27061         Reviewed by Tor Arne Vestbø.
27062
27063         Print "postProgressFinishedNotification" message if frame load finished 
27064         to unskip http/tests/loading/progress-finished-callback.html.
27065
27066         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
27067         (DumpRenderTreeChrome::onFrameLoadFinished):
27068
27069 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
27070
27071         [EFL][WK2] Fix WebKit2-EFL build
27072         https://bugs.webkit.org/show_bug.cgi?id=83693
27073
27074         Reviewed by Carlos Garcia Campos.
27075
27076         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
27077
27078 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
27079
27080         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
27081         (They only used to check for Skipped in platform/qt-5.0-wk1)
27082         https://bugs.webkit.org/show_bug.cgi?id=87376
27083
27084         Reviewed by Csaba Osztrogonác.
27085
27086         * Scripts/old-run-webkit-tests:
27087         (buildPlatformResultHierarchy):
27088         * Scripts/webkitpy/layout_tests/port/qt.py:
27089         (QtPort.baseline_search_path):
27090
27091 2012-05-29  Ojan Vafai  <ojan@chromium.org>
27092
27093         Add a linter error for pngs that lack an embedded checksum
27094         https://bugs.webkit.org/show_bug.cgi?id=87793
27095
27096         Reviewed by Dirk Pranke.
27097
27098         * Scripts/read-checksum-from-png:
27099         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
27100         (read_checksum):
27101         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
27102         (ReadChecksumFromPngTest):
27103         (ReadChecksumFromPngTest.test_read_checksum):
27104         * Scripts/webkitpy/layout_tests/port/base.py:
27105         * Scripts/webkitpy/style/checkers/png.py:
27106         (PNGChecker.check):
27107         * Scripts/webkitpy/style/checkers/png_unittest.py:
27108         (PNGCheckerTest.test_check):
27109
27110 2012-05-29  Stephanie Lewis  <slewis@apple.com>
27111
27112         https://bugs.webkit.org/show_bug.cgi?id=87720
27113         WebProcess is often killed due to being unresponsive on the bots
27114
27115         Reviewed by Alexey Proskuryakov.
27116
27117         Blind attempt to improve flakiness on the bots by reducing the number
27118         of crashes due to an unresponsive process.  This helped on my personal machine
27119         under stress conditions.  I don't have enough cores to hit the problem
27120         under normal conditions.
27121
27122         * WebKitTestRunner/TestController.cpp:
27123         (WTR):
27124
27125 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
27126
27127         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
27128         https://bugs.webkit.org/show_bug.cgi?id=87779
27129
27130         Reviewed by Eric Seidel.
27131
27132         Update output to match the names in scm.py as per
27133         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
27134
27135         * Scripts/webkitpy/tool/commands/rebaseline.py:
27136         (RebaselineTest.execute):
27137         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
27138         (test_rebaseline_test_and_print_scm_changes):
27139         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
27140         (GardeningServerTest.test_rebaselineall):
27141
27142 2012-05-29  Stephanie Lewis  <slewis@apple.com>
27143
27144         https://bugs.webkit.org/show_bug.cgi?id=87711
27145
27146         Reviewed by Jessie Berlin.
27147
27148         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
27149         are better maintained.
27150
27151         * BuildSlaveSupport/build.webkit.org-config/config.json:
27152
27153 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
27154
27155         webkit-patch optimize-baselines should add/delete files in batches from the vcs
27156         https://bugs.webkit.org/show_bug.cgi?id=87538
27157
27158         Reviewed by Ojan Vafai.
27159
27160         Invoking git and svn on one file at a time is kinda slow. We
27161         should batch the add and rm operations together.
27162
27163         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
27164         (BaselineOptimizer._move_baselines):
27165
27166 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
27167
27168         garden-o-matic should rebaseline baselines in parallel
27169         https://bugs.webkit.org/show_bug.cgi?id=87451
27170
27171         Reviewed by Ojan Vafai.
27172                                                                                
27173         This modifies garden-o-matic so that we will fetch all                  
27174         of the baselines in parallel from the bots, and then                    
27175         optimize the baselines serially (since that should be fairly            
27176         quick and we get into trouble if we optimize in parallel due            
27177         to concurrent access to the source control system).                     
27178
27179         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
27180         so that the files that need to be modified in the SCM are returned to 
27181         garden-o-matic rather than actually added or removed. This is done so that
27182         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
27183         concurrently). In order to safely return the files (as a JSON dict) I
27184         needed to shift all of the logging in rebaseline-test to use the logging
27185         module (and hence log to stderr).
27186
27187         I also had to stub out a line in chromium.py that would get confused if
27188         the skia overrides file didn't exist in a mock checkout.
27189
27190         * Scripts/webkitpy/common/system/executive.py:
27191         (Executive.popen):
27192         (Executive):
27193         (Executive.run_in_parallel):
27194         (_run_command_thunk):
27195         * Scripts/webkitpy/common/system/executive_mock.py:
27196         (MockExecutive.run_in_parallel):
27197         * Scripts/webkitpy/common/system/executive_unittest.py:
27198         (ExecutiveTest.test_run_in_parallel):
27199         * Scripts/webkitpy/layout_tests/port/chromium.py:
27200         (ChromiumPort._expectations_file_contents):
27201         * Scripts/webkitpy/tool/commands/rebaseline.py:
27202         (AbstractRebaseliningCommand.__init__):
27203         (RebaselineTest.__init__):
27204         (RebaselineTest._copy_existing_baseline):
27205         (RebaselineTest._save_baseline):
27206         (RebaselineTest):
27207         (RebaselineTest._add_to_scm):
27208         (RebaselineTest._rebaseline_test):
27209         (RebaselineTest.execute):
27210         (RebaselineExpectations._rebaseline_port):
27211         (RebaselineExpectations.execute):
27212         (Rebaseline._builder_to_pull_from):
27213         (Rebaseline.execute):
27214         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
27215         (test_rebaseline_updates_expectations_file):
27216         (test_rebaseline_test):
27217         (test_rebaseline_test_and_print_scm_changes):
27218         (test_rebaseline_and_copy_test):
27219         (test_rebaseline_and_copy_test_no_existing_result):
27220         (test_rebaseline_and_copy_test_with_lion_result):
27221         (test_rebaseline_and_copy_no_overwrite_test):
27222         (test_rebaseline_expectations):
27223         * Scripts/webkitpy/tool/servers/gardeningserver.py:
27224         (GardeningHTTPRequestHandler._rebaseline_commands):
27225         (GardeningHTTPRequestHandler):
27226         (GardeningHTTPRequestHandler._files_to_add):
27227         (GardeningHTTPRequestHandler._optimize_baselines):
27228         (GardeningHTTPRequestHandler.rebaselineall):
27229         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
27230         (GardeningServerTest._post_to_path):
27231         (GardeningServerTest.test_rebaselineall):
27232         (GardeningServerTest.test_rebaselineall.run_command):
27233
27234 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
27235
27236         Fix the type of dispatch_time() offset
27237
27238         Rubber-stamped by Joseph Pecoraro.
27239
27240         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
27241
27242         * DumpRenderTree/mac/FrameLoadDelegate.mm:
27243         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
27244
27245 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
27246
27247         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
27248
27249         [BlackBerry] OpenGL content is not rendered on simulator
27250         https://bugs.webkit.org/show_bug.cgi?id=87721
27251
27252         Reviewed by George Staikos.
27253
27254         Fixed by enabling GLES2 support in simulator builds.
27255
27256         To experiment with building without OpenGL support, you can set the
27257         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
27258
27259         PR #150695
27260
27261         * Scripts/webkitdirs.pm:
27262         (blackberryCMakeArguments):
27263
27264 2012-05-29  David Barr  <davidbarr@chromium.org>
27265
27266         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
27267         https://bugs.webkit.org/show_bug.cgi?id=87685
27268
27269         Reviewed by Eric Seidel.
27270
27271         Add a configuration option for CSS image-resolution support, disabling it by default.
27272
27273         * Scripts/webkitperl/FeatureList.pm:
27274         * qmake/mkspecs/features/features.pri:
27275
27276 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
27277
27278         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
27279
27280         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
27281             valid for C++/ObjC++ but not for C [enabled by default]"
27282
27283         Reviewed by Simon Hausmann.
27284
27285         * qmake/mkspecs/features/unix/default_post.prf:
27286
27287 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
27288
27289         [Qt] Sync up favicon-implementation with WebView url changes in r118158
27290
27291         https://bugs.webkit.org/show_bug.cgi?id=87133
27292
27293         We now base64-encode the page url in the image-provider url, so that any
27294         normalization done by QUrl will not mess up the page-url. The logic of
27295         creating and parsing the provider-url has been moved into the image
27296         provider, to keep it in one place.
27297
27298         We were also releasing icons (even ones we hadn't retained), which we can't
27299         do since we don't know when the icon url is no longer in use.
27300
27301         Reviewed-by Simon Hausmann.
27302
27303         * MiniBrowser/qt/icons/favicon.png:
27304         * MiniBrowser/qt/qml/BrowserWindow.qml:
27305
27306 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
27307
27308         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
27309         https://bugs.webkit.org/show_bug.cgi?id=87654
27310
27311         Reviewed by Csaba Osztrogonác.
27312
27313         Event sender provides strings for all the key events.
27314         Also KeyEventInfo constructor parameters order was changed to simplify the case when
27315         a key event has empty string.
27316
27317         * DumpRenderTree/efl/EventSender.cpp:
27318         (KeyEventInfo::KeyEventInfo):
27319         (keyPadNameFromJSValue):
27320         (keyNameFromJSValue):
27321
27322 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
27323
27324         [Qt] Cancel potential url-edit when going back/forward
27325
27326         Reviewed by Kenneth Rohde Christiansen.
27327
27328         * MiniBrowser/qt/qml/BrowserWindow.qml:
27329
27330 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
27331
27332         [EFL] Compilation warning in DumpRenderTreeView.cpp
27333         https://bugs.webkit.org/show_bug.cgi?id=87636
27334
27335         Reviewed by Filip Pizlo.
27336
27337         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
27338         specifier in printf. Also fix the return type for
27339         onExceededApplicationCacheQuota callback.
27340
27341         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
27342         (onExceededApplicationCacheQuota):
27343
27344 2012-05-29  Hironori Bono  <hbono@chromium.org>
27345
27346         Adding Hironori Bono to committers.py.
27347         https://bugs.webkit.org/show_bug.cgi?id=87697
27348
27349         * Scripts/webkitpy/common/config/committers.py:
27350
27351 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
27352
27353         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
27354         https://bugs.webkit.org/show_bug.cgi?id=80135
27355
27356         Reviewed by Rob Buis.
27357
27358         Implemented interface function didReceiveAuthenticationChallenge in class
27359         DumpRenderTree.
27360
27361         Resubmit the patch reverted by r115104 after the digest infinite loop
27362         issue for BlackBerry porting get identified and fixed.
27363
27364         Internally reviewed by Joe Mason <jmason@rim.com>
27365
27366         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
27367         (drtCredentialDescription):
27368         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
27369         (WebKit):
27370         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
27371         (WebCore):
27372         (DumpRenderTree):
27373
27374 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
27375
27376         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
27377         https://bugs.webkit.org/show_bug.cgi?id=42328
27378
27379         Reviewed by Eric Seidel.
27380
27381         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
27382         move to windows.internals.settings.
27383
27384         * DumpRenderTree/LayoutTestController.cpp:
27385         (LayoutTestController::staticFunctions):
27386         * DumpRenderTree/LayoutTestController.h:
27387         (LayoutTestController):
27388         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
27389         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
27390         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
27391         (DRTDevToolsAgent):
27392         * DumpRenderTree/chromium/LayoutTestController.cpp:
27393         (LayoutTestController::LayoutTestController):
27394         * DumpRenderTree/chromium/LayoutTestController.h:
27395         (LayoutTestController):
27396         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
27397         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
27398         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
27399         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
27400         * DumpRenderTree/mac/DumpRenderTree.mm:
27401         (resetWebViewToConsistentStateBeforeTesting):
27402         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
27403         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
27404         * DumpRenderTree/qt/LayoutTestControllerQt.h:
27405         (LayoutTestController):
27406         * DumpRenderTree/win/DumpRenderTree.cpp:
27407         (resetWebViewToConsistentStateBeforeTesting):
27408         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
27409         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
27410         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
27411         (LayoutTestController):
27412
27413 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
27414
27415         Move allowRoundingHacks to Internals interface
27416         https://bugs.webkit.org/show_bug.cgi?id=87328
27417
27418         Reviewed by Hajime Morita.
27419
27420         Remove allowRoundingHacks functions, because it is able to work in the
27421         cross-port way through the Internals interface.
27422
27423         * DumpRenderTree/LayoutTestController.cpp:
27424         (LayoutTestController::staticFunctions):
27425         * DumpRenderTree/LayoutTestController.h:
27426         (LayoutTestController):
27427         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
27428         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
27429         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
27430         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
27431         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
27432         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
27433
27434 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
27435
27436         Fix mac build with older XCode by defining NSEC_PER_MSEC.
27437         https://bugs.webkit.org/show_bug.cgi?id=87616
27438
27439         Reviewed by Hajime Morita.
27440
27441         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
27442         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
27443         Patch just adds a #ifndef / #define check.
27444
27445         * DumpRenderTree/mac/FrameLoadDelegate.mm:
27446         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
27447
27448 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
27449
27450         [EFL] Enable blob support for the EFL port
27451         https://bugs.webkit.org/show_bug.cgi?id=85363
27452
27453         Reviewed by Hajime Morita.
27454
27455         Enable Blob support by default for the EFL port.
27456
27457         * Scripts/webkitperl/FeatureList.pm:
27458
27459 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
27460
27461         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
27462         https://bugs.webkit.org/show_bug.cgi?id=87582
27463
27464         Reviewed by Darin Adler.
27465
27466         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
27467         possible to test pages in a similar way as they are loaded in Browsers.
27468
27469         * DumpRenderTree/LayoutTestController.cpp:
27470         (LayoutTestController::LayoutTestController):
27471         (setUseDeferredFrameLoadingCallback):
27472         (LayoutTestController::staticFunctions):
27473         * DumpRenderTree/LayoutTestController.h:
27474         (LayoutTestController::useDeferredFrameLoading):
27475         (LayoutTestController::setUseDeferredFrameLoading):
27476         (LayoutTestController):
27477         * DumpRenderTree/mac/FrameLoadDelegate.mm:
27478         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
27479
27480 2012-05-27  David Barton  <dbarton@mathscribe.com>
27481
27482         [watchlist] Improve MathML rule
27483         https://bugs.webkit.org/show_bug.cgi?id=87592
27484
27485         Reviewed by Adam Barth.
27486
27487         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
27488         but if this changed the rule would be slow. We protect against this, clarify the rule,
27489         and make it more similar to existing rules.
27490
27491         * Scripts/webkitpy/common/config/watchlist:
27492
27493 2012-05-27  David Barton  <dbarton@mathscribe.com>
27494
27495         [watchlist] Add myself & a rule for MathML
27496         https://bugs.webkit.org/show_bug.cgi?id=87586
27497
27498         Reviewed by Adam Barth.
27499
27500         * Scripts/webkitpy/common/config/watchlist:
27501
27502 2012-05-26  David Kilzer  <ddkilzer@apple.com>
27503
27504         Use xcrun to find path to nm for Mac port
27505         <http://webkit.org/b/87588>
27506
27507         Reviewed by Dan Bernstein.
27508
27509         * Scripts/webkitpy/layout_tests/port/mac.py:
27510         (MacPort.nm_command): Add. Tries to find a path for the nm
27511         command using xcrun.  Falls back to returning 'nm'.
27512         * Scripts/webkitpy/layout_tests/port/webkit.py:
27513         (WebKitPort.nm_command): Add. Returns 'nm'.
27514         (WebKitPort._webcore_symbols_string): Call self.nm_command().
27515
27516 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
27517
27518         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
27519
27520         Reviewed by Eric Seidel.
27521
27522         * DumpRenderTree/win/DumpRenderTree.vcproj:
27523         * DumpRenderTree/win/FrameLoadDelegate.cpp:
27524         (FrameLoadDelegate::FrameLoadDelegate):
27525         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
27526         * DumpRenderTree/win/FrameLoadDelegate.h:
27527         (FrameLoadDelegate):
27528         * DumpRenderTree/win/TextInputController.cpp: Added.
27529         (setMarkedTextCallback):
27530         (hasMarkedTextCallback):
27531         (unmarkTextCallback):
27532         (markedRangeCallback):
27533         (insertTextCallback):
27534         (firstRectForCharacterRangeCallback):
27535         (selectedRangeCallback):
27536         (TextInputController::makeWindowObject):
27537         (TextInputController::getJSClass):
27538         (TextInputController::staticValues):
27539         (TextInputController::staticFunctions):
27540         * DumpRenderTree/win/TextInputController.h: Added.
27541         (TextInputController):
27542         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
27543         (TextInputController::setMarkedText):
27544         (TextInputController::hasMarkedText):
27545         (TextInputController::unmarkText):
27546         (TextInputController::markedRange):
27547         (TextInputController::insertText):
27548         (TextInputController::firstRectForCharacterRange):
27549         (TextInputController::selectedRange):
27550
27551 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
27552
27553         webkitpy: change scm.add(), scm.delete() to accept multiple paths
27554         https://bugs.webkit.org/show_bug.cgi?id=87528
27555
27556         Reviewed by Ojan Vafai.
27557
27558         launching git or svn for individual files can be slow; this
27559         change will hand multiple paths at once to git and svn so they
27560         can be added in a batch.
27561
27562         * Scripts/webkitpy/common/checkout/scm/git.py:
27563         (Git.add_list):
27564         (Git.delete_list):
27565         * Scripts/webkitpy/common/checkout/scm/scm.py:
27566         (SCM.add):
27567         (SCM):
27568         (SCM.add_list):
27569         (SCM.delete):
27570         (SCM.delete_list):
27571         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
27572         (MockSCM.add):
27573         (MockSCM):
27574         (MockSCM.add_list):
27575         (MockSCM.delete):
27576         (MockSCM.delete_list):
27577         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
27578         (_shared_test_exists):
27579         (_shared_test_added_files):
27580         (_test_delete_list):
27581         * Scripts/webkitpy/common/checkout/scm/svn.py:
27582         (SVN.add_list):
27583         (SVN.delete_list):
27584
27585 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
27586
27587         [NRWT] Add unit testing for perf tests on locked shards
27588         https://bugs.webkit.org/show_bug.cgi?id=87489
27589
27590         Reviewed by Dirk Pranke.
27591
27592         Adding utests that makes sure that perf tests are running in locked
27593         shards and by passing --no-http won't break NRWT (r118421).
27594
27595         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
27596         (ShardingTests):
27597         (ShardingTests.test_shard_by_dir):
27598         (ShardingTests.test_shard_every_file):
27599         (ShardingTests.test_shard_in_two):
27600         (ShardingTests.test_multiple_locked_shards):
27601         (LockCheckingManager):
27602         (LockCheckingManager.__init__):
27603         (LockCheckingManager.handle_finished_list):
27604         (ManagerTest.test_http_locking):
27605         (ManagerTest):
27606         (ManagerTest.test_perf_locking):
27607         * Scripts/webkitpy/layout_tests/port/test.py:
27608
27609 2012-05-25  Jessie Berlin  <jberlin@apple.com>
27610
27611         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
27612         https://bugs.webkit.org/show_bug.cgi?id=87511
27613
27614         Reviewed by Alexey Proskuryakov.
27615
27616         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
27617
27618         * DumpRenderTree/win/EventSender.cpp:
27619         (keyDownCallback):
27620
27621 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
27622
27623         Adding Ken Buchanan to committers.py
27624         https://bugs.webkit.org/show_bug.cgi?id=87443
27625
27626         Unreviewed.
27627
27628         Adding self to committers.py as a Committer.
27629
27630         * Scripts/webkitpy/common/config/committers.py:
27631
27632 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
27633
27634         [Qt] Buildfix for newer Qt5
27635         https://bugs.webkit.org/show_bug.cgi?id=87257
27636
27637         Reviewed by Simon Hausmann.
27638
27639         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
27640
27641 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
27642
27643         [Qt] Unreviewed fix after r118484.
27644
27645         Enable CSS_EXCLUSIONS and CSS_REGIONS.
27646         They were enabled uncoditinally before r118484.
27647
27648         * qmake/mkspecs/features/features.pri:
27649
27650 2012-05-24  Tim Horton  <timothy_horton@apple.com>
27651
27652         Add feature defines for web-facing parts of CSS Regions and Exclusions
27653         https://bugs.webkit.org/show_bug.cgi?id=87442
27654         <rdar://problem/10887709>
27655
27656         Reviewed by Dan Bernstein.
27657
27658         * Scripts/webkitperl/FeatureList.pm:
27659
27660 2012-05-24  Hironori Bono  <hbono@chromium.org>
27661
27662         Enable grammar checking on Chromium when we paste text (Take 2)
27663         https://bugs.webkit.org/show_bug.cgi?id=74393
27664
27665         Reviewed by Ryosuke Niwa.
27666
27667         This change enables grammar checking on Chromium and implements a mock grammar
27668         checker to fix a failing test.
27669
27670         * DumpRenderTree/DumpRenderTree.gypi:
27671         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
27672         (MockGrammarCheck::checkGrammarOfString):
27673         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
27674         (WebKit):
27675         (MockGrammarCheck):
27676         * DumpRenderTree/chromium/WebViewHost.cpp:
27677         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
27678
27679 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
27680
27681         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
27682         https://bugs.webkit.org/show_bug.cgi?id=86842
27683
27684         Reviewed by Antonio Gomes.
27685
27686         Add support for overriding the application cache support preference
27687         through EFL's LayoutTestController.
27688
27689         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
27690         (LayoutTestController::overridePreference):
27691
27692 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
27693
27694         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
27695         https://bugs.webkit.org/show_bug.cgi?id=85209
27696
27697         Reviewed by Antonio Gomes.
27698
27699         Set developer extras setting called twice on the test startup. Hence, removing
27700         an unnecessary extra call which set wrong value. 
27701
27702         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
27703         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
27704
27705 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
27706
27707         garden-o-matic should not fetch from debug bots if it also knows about the release bots
27708         https://bugs.webkit.org/show_bug.cgi?id=86916
27709
27710         Reviewed by Adam Barth.
27711
27712         Note that if release and debug are failing differently, debug
27713         will be ignored ...
27714
27715         Note: also change the use of a fake port name from
27716         "mock-port-name" to "test-mac-leopard" to make it more friendly
27717         to the port factory ("mock" actually is a real port).
27718
27719         * Scripts/webkitpy/tool/servers/gardeningserver.py:
27720         (GardeningHTTPRequestHandler._builders_to_fetch_from):
27721         (GardeningHTTPRequestHandler.rebaselineall):
27722         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
27723         (GardeningServerTest.test_rebaselineall):
27724         (GardeningServerTest.test_rebaseline_new_port):
27725
27726 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
27727
27728         nrwt: fix baseline search path for official chrome builders
27729         https://bugs.webkit.org/show_bug.cgi?id=87432
27730
27731         Reviewed by Tony Chang.
27732
27733         The official chrome builders need to use the win7 and SL
27734         baseline paths, not the XP and Leopard paths. Linux is correct.
27735
27736         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
27737         (GoogleChromeMacPort.determine_full_port_name):
27738         (GoogleChromeWinPort.determine_full_port_name):
27739         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
27740         (TestGoogleChromePort._verify_baseline_search_path_startswith):
27741         (TestGoogleChromePort.test_get_google_chrome_port):
27742
27743 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
27744
27745         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
27746         https://bugs.webkit.org/show_bug.cgi?id=86800
27747
27748         Reviewed by Dirk Pranke.
27749
27750         Don't launch a HTTP server with lock based only on the existence of
27751         locked shards since we now run perf on locked shards too.
27752
27753         * Scripts/webkitpy/layout_tests/controllers/manager.py:
27754         (Manager._run_tests):
27755
27756 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
27757
27758         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
27759         https://bugs.webkit.org/show_bug.cgi?id=87128
27760
27761         Reviewed by Dirk Pranke.
27762
27763         * Scripts/webkitpy/layout_tests/port/base.py:
27764         (Port.driver_name):
27765         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
27766         (ChromiumLinuxPort._path_to_driver):
27767         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
27768         (ChromiumPortTest.test_driver_name_option):
27769         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
27770         (ChromiumWinPort._path_to_driver):
27771         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
27772         (parse_args):
27773
27774 2012-05-24  John Mellor  <johnme@chromium.org>
27775
27776         Font Boosting: Add compile flag and runtime setting
27777         https://bugs.webkit.org/show_bug.cgi?id=87394
27778
27779         Reviewed by Adam Barth.
27780
27781         Add ENABLE_FONT_BOOSTING.
27782
27783         * Scripts/webkitperl/FeatureList.pm:
27784         * qmake/mkspecs/features/features.pri:
27785
27786 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
27787
27788         [EFL] [DRT] keyboard-related tests do not pass
27789         https://bugs.webkit.org/show_bug.cgi?id=85369
27790
27791         Reviewed by Gustavo Noronha Silva.
27792
27793         Add SHIFT modifier for capital letters as VK_ 
27794         codes do not distinguish between lows and caps and also to be consistent
27795         with other ports which send caps as lowercase letters with the shift key down.
27796
27797         * DumpRenderTree/efl/EventSender.cpp:
27798         (keyNameFromJSValue): 
27799
27800 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
27801
27802         [WK2] Let the client give local files universal access on a case by case basis
27803         https://bugs.webkit.org/show_bug.cgi?id=87174
27804         <rdar://problem/11024330>
27805
27806         Reviewed by Maciej Stachowiak.
27807
27808         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
27809         Added initialization of a new structure member to prevent build failure.
27810
27811 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
27812
27813         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
27814         https://bugs.webkit.org/show_bug.cgi?id=87203
27815
27816         Reviewed by Andreas Kling.
27817
27818         Add the required changes to make
27819         fast/events/keydown-leftright-keys.html pass after r118001.
27820
27821         * DumpRenderTree/efl/EventSender.cpp:
27822         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
27823         into the proper X11 keysym definitions.
27824
27825 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
27826
27827         Unreviewed, rolling out r118352.
27828         http://trac.webkit.org/changeset/118352
27829         https://bugs.webkit.org/show_bug.cgi?id=87390
27830
27831         Caused 6 editing/spelling tests crash/fail on chromium in
27832         debug. (Requested by vsevik on #webkit).
27833
27834         * DumpRenderTree/DumpRenderTree.gypi:
27835         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
27836         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
27837         * DumpRenderTree/chromium/WebViewHost.cpp:
27838         (WebViewHost::finishLastTextCheck):
27839
27840 2012-05-24  Peter Beverloo  <peter@chromium.org>
27841
27842         Add John Mellor as a contributor
27843         https://bugs.webkit.org/show_bug.cgi?id=87389
27844
27845         Reviewed by Kenneth Rohde Christiansen.
27846
27847         John will be working on Font Boosting and is very involved with various
27848         web-facing subjects of Chrome for Android, such as viewport.
27849
27850         * Scripts/webkitpy/common/config/committers.py:
27851
27852 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
27853
27854         [EFL][DRT] LayoutTestController's setCacheModel() implementation
27855         https://bugs.webkit.org/show_bug.cgi?id=86840
27856
27857         Reviewed by Csaba Osztrogonác.
27858
27859         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
27860         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
27861         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
27862         (LayoutTestController::setCacheModel): Implementation added.
27863
27864 2012-05-24  Hironori Bono  <hbono@chromium.org>
27865
27866         Enable grammar checking on Chromium when we paste text.
27867         https://bugs.webkit.org/show_bug.cgi?id=74393
27868
27869         Reviewed by Hajime Morita.
27870
27871         This change enables grammar checking on Chromium and implements a mock grammar
27872         checker to fix a failing test.
27873
27874         * DumpRenderTree/DumpRenderTree.gypi:
27875         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
27876         (MockGrammarCheck::checkGrammarOfString):
27877         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
27878         (WebKit):
27879         (MockGrammarCheck):
27880         * DumpRenderTree/chromium/WebViewHost.cpp:
27881         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
27882
27883 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
27884
27885         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
27886
27887         * qmake/mkspecs/features/features.pri:
27888
27889 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
27890
27891         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
27892         https://bugs.webkit.org/show_bug.cgi?id=86867
27893
27894         Reviewed by Adam Barth.
27895
27896         Add implementation for sendWebIntentResponse() in EFL's
27897         LayoutTestController and add empty implementation for other ports.
27898
27899         * DumpRenderTree/LayoutTestController.cpp:
27900         (sendWebIntentResponseCallback):
27901         (LayoutTestController::staticFunctions):
27902         * DumpRenderTree/LayoutTestController.h:
27903         (LayoutTestController):
27904         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
27905         (LayoutTestController::sendWebIntentResponse):
27906         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
27907         (DumpRenderTreeChrome::currentIntentRequest):
27908         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
27909         (DumpRenderTreeChrome::onFrameIntentNew):
27910         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
27911         (DumpRenderTreeChrome):
27912         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
27913         (LayoutTestController::sendWebIntentResponse):
27914         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
27915         (LayoutTestController::sendWebIntentResponse):
27916         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
27917         (LayoutTestController::sendWebIntentResponse):
27918         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
27919         (LayoutTestController::sendWebIntentResponse):
27920         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
27921         (LayoutTestController::sendWebIntentResponse):
27922
27923 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
27924
27925         [EFL] The EFL port has no support for title directionality
27926         https://bugs.webkit.org/show_bug.cgi?id=86462
27927
27928         Reviewed by Gustavo Noronha Silva.
27929
27930         Update "title,changed" signal handlers in DRT and EWebLauncher to
27931         reflect the change from const char* to Ewk_Text_With_Direction* type
27932         for the title.
27933
27934         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
27935         (DumpRenderTreeChrome::onTitleChanged):
27936         * EWebLauncher/main.c:
27937         (title_set):
27938         (on_title_changed):
27939         (on_key_down):
27940
27941 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
27942
27943         Change EFL debug build name with more detail one
27944         https://bugs.webkit.org/show_bug.cgi?id=87254
27945
27946         Reviewed by Ryosuke Niwa.
27947
27948         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
27949         In addition, remove efl-linux-debug triggerable since nobody uses it.
27950
27951         * BuildSlaveSupport/build.webkit.org-config/config.json:
27952
27953 2012-05-23  Kangil Han  <kangil.han@samsung.com>
27954
27955         [EFL][DRT] Fix WebCore library path and rebaseline result
27956         https://bugs.webkit.org/show_bug.cgi?id=86355
27957
27958         Reviewed by Dirk Pranke.
27959
27960         Currently EFL DRT uses wrong WebCore library path when running DRT.
27961         Therefore, this patch adjusted the path correctly.
27962
27963         * Scripts/webkitpy/layout_tests/port/efl.py:
27964         (EflPort._path_to_webcore_library):
27965
27966 2012-05-23  Ojan Vafai  <ojan@chromium.org>
27967
27968         add back the ability to disable flexbox
27969         https://bugs.webkit.org/show_bug.cgi?id=87147
27970
27971         Reviewed by Tony Chang.
27972
27973         * Scripts/webkitperl/FeatureList.pm:
27974
27975 2012-05-23  Tony Chang  <tony@chromium.org>
27976
27977         Remove the Chromium Grid Layout bot from the waterfall
27978         https://bugs.webkit.org/show_bug.cgi?id=87311
27979
27980         Reviewed by Ryosuke Niwa.
27981
27982         I removed the compiler define in r117613, so we don't need a separate
27983         bot to compile/test this code.
27984
27985         * BuildSlaveSupport/build.webkit.org-config/config.json:
27986
27987 2012-05-23  Ian Vollick  <vollick@chromium.org>
27988
27989         Add vollick to list of contributors.
27990         https://bugs.webkit.org/show_bug.cgi?id=87305
27991
27992         Reviewed by Adam Barth.
27993
27994         * Scripts/webkitpy/common/config/committers.py:
27995
27996 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
27997
27998         [Chromium-Android] Fix chromium_android_unittest
27999         https://bugs.webkit.org/show_bug.cgi?id=87196
28000
28001         Reviewed by Tony Chang.
28002
28003         Update unit tests after ChromiumAndroidPort supported apk based
28004         DumpRenderTree.
28005
28006         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
28007         (ChromiumAndroidPortTest):
28008         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
28009         (ChromiumAndroidPortTest.test_get_last_stacktrace):
28010         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
28011         (ChromiumAndroidDriverTest):
28012         (ChromiumAndroidDriverTest.setUp):
28013         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
28014         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
28015
28016 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
28017
28018         [watchlist] Add myself and create a watch rule to catch Attribute related patches
28019         https://bugs.webkit.org/show_bug.cgi?id=87303
28020
28021         Reviewed by Alexis Menard.
28022
28023         * Scripts/webkitpy/common/config/watchlist:
28024
28025 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
28026
28027         garden-o-matic should not fetch from debug bots if it also knows about the release bots
28028         https://bugs.webkit.org/show_bug.cgi?id=86916
28029
28030         Reviewed by Adam Barth.
28031
28032         This change pushes all of the logic for rebaselining a cluster
28033         of failures (a list of tests failing a list of suffixes on a
28034         list of bots) onto the server, so there is a single call from
28035         the web page; we will then be able to optimize the performance
28036         of the rebaselining better.
28037
28038         Also remove the 'optimizebaseline' entry point on garden-o-matic
28039         (and the client-side call) since we don't need it any more.
28040
28041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
28042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
28043         * Scripts/webkitpy/tool/servers/gardeningserver.py:
28044         (GardeningHTTPRequestHandler.rebaselineall):
28045         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
28046
28047 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
28048
28049         Mac DRT should be able to load external URLs for replay performance tests
28050         https://bugs.webkit.org/show_bug.cgi?id=86191
28051
28052         Reviewed by Alexey Proskuryakov.
28053
28054         Let external URL requests go through if the test file is not a local file or hosted at localhost.
28055         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
28056         "DumpRenderTree http://localhost:8000/".
28057
28058         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
28059         (isLocalhost):
28060         (hostIsUsedBySomeTestsToGenerateError):
28061         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
28062
28063 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
28064
28065         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
28066         debug symbols for easier debugging.
28067         https://bugs.webkit.org/show_bug.cgi?id=87151
28068
28069         Reviewed by Kevin Ollivier.
28070
28071         * waf/build/settings.py:
28072         (common_configure):
28073
28074 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
28075
28076         Unreviewed. Move myself to reviewers.
28077
28078         * Scripts/webkitpy/common/config/committers.py:
28079
28080 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
28081
28082         [EFL] Implements the registerProtocolHandler method and option.
28083         https://bugs.webkit.org/show_bug.cgi?id=73638
28084
28085         Reviewed by Andreas Kling.
28086
28087         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
28088
28089 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
28090
28091         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
28092         https://bugs.webkit.org/show_bug.cgi?id=87221
28093
28094         Reviewed by Martin Robinson.
28095
28096         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
28097         rightShift key names into proper GDK key symbols.
28098
28099         * DumpRenderTree/gtk/EventSender.cpp:
28100         (createKeyPressEvent):
28101
28102 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
28103
28104         [Qt] Make the web view's url property follow the active url
28105
28106         https://bugs.webkit.org/show_bug.cgi?id=77554
28107
28108         Update  the location bar in the minibrowser to behave
28109         a bit more like normal browsers in terms of when the url will change
28110         and how active focus is handled.
28111
28112         Reviewed by Simon Hausmann.
28113
28114         * MiniBrowser/qt/qml/BrowserWindow.qml:
28115
28116 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
28117
28118         [Qt] Remove references to $$QT_SOURCE_TREE
28119
28120         With a modularized Qt, it's ambigious. What we really want is qtbase,
28121         which qtcore is a proxy for (we assume it will always live in qtbase).
28122
28123         Reviewed by Tor Arne Vestbø.
28124
28125         * DumpRenderTree/qt/DumpRenderTree.pro:
28126
28127 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
28128
28129         [Qt] Fix qmake conditional for c++-11 compat warnings
28130
28131         Reviewed by Tor Arne Vestbø.
28132
28133         * qmake/mkspecs/features/unix/default_post.prf:
28134
28135 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
28136
28137         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
28138         https://bugs.webkit.org/show_bug.cgi?id=85956
28139
28140         Reviewed by Gustavo Noronha Silva.
28141
28142         Catch new "load,provisional,failed" signal and print
28143         didFailProvisionalLoadWithError messages when LayoutTestController's
28144         dumpFrameLoadCallbacks() returns true. Also make sure the
28145         didFailLoadWithError message is not printed in case of provisional
28146         load failure.
28147
28148         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
28149         (DumpRenderTreeChrome::createView):
28150         (DumpRenderTreeChrome::onFrameCreated):
28151         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
28152         (DumpRenderTreeChrome::onFrameLoadError):
28153         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
28154         (DumpRenderTreeChrome):
28155
28156 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
28157
28158         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
28159         https://bugs.webkit.org/show_bug.cgi?id=86366
28160
28161         Reviewed by Antonio Gomes.
28162
28163         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
28164
28165         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
28166         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
28167
28168 2012-05-22  Darin Adler  <darin@apple.com>
28169
28170         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
28171         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
28172
28173 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
28174
28175         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
28176         https://bugs.webkit.org/show_bug.cgi?id=86922
28177
28178         Because we have new platformInit() in TestShellAndroid.cpp, and
28179         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
28180         is split into TestShellPosix.cpp and TestShellX11.cpp.
28181
28182         Reviewed by Kent Tamura.
28183
28184         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
28185         * DumpRenderTree/DumpRenderTree.gypi:
28186         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
28187         (platformInit):
28188         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
28189         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
28190         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
28191         (AlarmHandler):
28192         (TestShell::waitTestFinished):
28193         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
28194         (openStartupDialog): from TestShellGtk.cpp
28195         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
28196         (setupFontconfig):
28197         (platformInit):
28198
28199 2012-05-22  Kangil Han  <kangil.han@samsung.com>
28200
28201         [EFL][DRT] Implement touch event
28202         https://bugs.webkit.org/show_bug.cgi?id=86720
28203
28204         Reviewed by Hajime Morita.
28205
28206         Currently EFL DRT doesn't support touch event.
28207         Therefore, this patch enabled it and implemented some eventSender function callbacks.
28208
28209         * DumpRenderTree/efl/EventSender.cpp:
28210         (TouchEventInfo::TouchEventInfo):
28211         (TouchEventInfo):
28212         (touchPointList):
28213         (sendTouchEvent):
28214         (addTouchPointCallback):
28215         (touchStartCallback):
28216         (updateTouchPointCallback):
28217         (touchMoveCallback):
28218         (cancelTouchPointCallback):
28219         (touchCancelCallback):
28220         (releaseTouchPointCallback):
28221         (touchEndCallback):
28222         (clearTouchPointsCallback):
28223         (setTouchModifierCallback):
28224         * Scripts/webkitperl/FeatureList.pm:
28225
28226 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
28227
28228         [Chromium-Android] Fix chromium_android_unittest
28229         https://bugs.webkit.org/show_bug.cgi?id=87196
28230
28231         Not reviewed.
28232         Temporarily disable chromium_android_unittest.
28233
28234         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
28235         (ChromiumAndroidPortTest):
28236         (ChromiumAndroidDriverTest):
28237
28238 2012-05-22  Jessie Berlin  <jberlin@apple.com>
28239
28240         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
28241         https://bugs.webkit.org/show_bug.cgi?id=64313
28242
28243         Reviewed by Jon Honeycutt.
28244
28245         Add it.
28246
28247         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
28248         Make sure to generate the binding.
28249
28250         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
28251         (WTR::LayoutTestController::setDefersLoading):
28252         Call WKBundlePageSetDefersLoading.
28253         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
28254
28255 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
28256
28257         [Chromium-Android] Run DumpRenderTree as an apk (python part)
28258         https://bugs.webkit.org/show_bug.cgi?id=86923
28259
28260         chromium_android.py is modified to support running DumpRenderTree as
28261         an apk, so that we can run the tests (e.g. video) requiring features
28262         implemented in Java on Android.
28263
28264         Reviewed by Adam Barth.
28265
28266         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
28267         (ChromiumAndroidPort.__init__):
28268         (ChromiumAndroidPort.default_child_processes):
28269         (ChromiumAndroidPort.check_wdiff):
28270         (ChromiumAndroidPort.check_build):
28271         (ChromiumAndroidPort.start_helper):
28272         (ChromiumAndroidPort.skipped_layout_tests):
28273         (ChromiumAndroidPort):
28274         (ChromiumAndroidPort._path_to_driver):
28275         (ChromiumAndroidPort._get_crash_log):
28276         (ChromiumAndroidPort._push_executable):
28277         (ChromiumAndroidPort._run_adb_command):
28278         (ChromiumAndroidPort._get_last_stacktrace):
28279         (ChromiumAndroidPort._get_logcat):
28280         (ChromiumAndroidPort._setup_performance):
28281         (ChromiumAndroidDriver):
28282         (ChromiumAndroidDriver.__init__):
28283         (ChromiumAndroidDriver._command_wrapper):
28284         (ChromiumAndroidDriver.cmd_line):
28285         (ChromiumAndroidDriver._file_exists_on_device):
28286         (ChromiumAndroidDriver._deadlock_detector):
28287         (ChromiumAndroidDriver._start):
28288         (ChromiumAndroidDriver.run_test):
28289         (ChromiumAndroidDriver.stop):
28290         (ChromiumAndroidDriver._write_command_and_read_line):
28291         (ChromiumAndroidDriver._output_image):
28292         (ChromiumAndroidDriver._get_stderr):
28293
28294 2012-05-22  Joshua Bell  <jsbell@chromium.org>
28295
28296         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
28297
28298         Unreviewed gardening.
28299
28300         * Scripts/webkitpy/layout_tests/port/base.py:
28301         (Port.driver_name):
28302         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
28303         (ChromiumLinuxPort._path_to_driver):
28304         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
28305         (ChromiumPortTest.test_overrides_and_builder_names):
28306         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
28307         (ChromiumWinPort._path_to_driver):
28308         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
28309         (parse_args):
28310
28311 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
28312
28313         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
28314         https://bugs.webkit.org/show_bug.cgi?id=87176
28315
28316         Reviewed by Tony Chang.
28317
28318         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
28319         * DumpRenderTree/DumpRenderTree.gypi:
28320
28321 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
28322
28323         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
28324         https://bugs.webkit.org/show_bug.cgi?id=87128
28325
28326         Reviewed by Dirk Pranke.
28327
28328         * Scripts/webkitpy/layout_tests/port/base.py:
28329         (Port.driver_name):
28330         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
28331         (ChromiumLinuxPort._path_to_driver):
28332         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
28333         (ChromiumPortTest.test_driver_name_option):
28334         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
28335         (ChromiumWinPort._path_to_driver):
28336         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
28337         (parse_args):
28338
28339 2012-05-22  Jessie Berlin  <jberlin@apple.com>
28340
28341         WTR fix after r118001.
28342
28343         Rubber-stamped by Alexey Proskuryakov.
28344
28345         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
28346
28347         * WebKitTestRunner/mac/EventSenderProxy.mm:
28348         (WTR::EventSenderProxy::keyDown):
28349
28350 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
28351
28352         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
28353         https://bugs.webkit.org/show_bug.cgi?id=86684
28354
28355         Reviewed by Darin Fisher.
28356
28357         * DumpRenderTree/chromium/LayoutTestController.cpp:
28358         (LayoutTestController::numberOfPages):
28359         * DumpRenderTree/chromium/WebViewHost.cpp:
28360         (WebViewHost::printPage):
28361
28362 == Rolled over to ChangeLog-2012-05-22 ==