Tools/ChangeLog

   1 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
   2
   3         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
   4         https://bugs.webkit.org/show_bug.cgi?id=89734
   5
   6         Reviewed by Ryosuke Niwa.
   7
   8         Fix a crash in ServerProcess if you called .pid() after it
   9         crashed during a write(). We had a test for this case but the
  10         test wasn't calling pid(), just has_crashed(). Fixed the problem
  11         and the test.
  12
  13         * Scripts/webkitpy/layout_tests/port/server_process.py:
  14         (ServerProcess.__init__):
  15         (ServerProcess.pid):
  16         (ServerProcess._start):
  17         (ServerProcess.stop):
  18         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  19         (FakeServerProcess._start):
  20         (TestServerProcess.test_broken_pipe):
  21
  22 2012-05-30  Ojan Vafai  <ojan@chromium.org>
  23
  24         Only give lint errors for -expected.png png files that lack a checksum
  25         https://bugs.webkit.org/show_bug.cgi?id=87875
  26
  27         Reviewed by Tony Chang.
  28
  29         We have other pngs in the tree, e.g. for the inspector, that legitimately
  30         lack a checksum.
  31
  32         * Scripts/webkitpy/style/checkers/png.py:
  33         (PNGChecker.check):
  34         * Scripts/webkitpy/style/checkers/png_unittest.py:
  35         (PNGCheckerTest.test_check):
  36
  37 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
  38
  39         nrwt: seems to leak temp dirs
  40         https://bugs.webkit.org/show_bug.cgi?id=87795
  41
  42         Reviewed by Ojan Vafai.
  43
  44         There appears to be a bug where the chromium bots are creating
  45         temporary directories and not cleaning them up that started
  46         after the switch to WebKitDriver. It's possible that __del__
  47         wasn't getting called in a timely manner (or at all), and it's
  48         generally bad style to rely on __del__ being called, so this
  49         code changes things so that we create a temp dir in
  50         driver.start() and remove it in driver.stop(). We could be
  51         paranoid and leave the __del__ code in, but there doesn't seem
  52         to be much advantage to it. If there are bugs that result in
  53         drivers being started but not stopped, we have other problems.
  54
  55         * Scripts/webkitpy/common/system/filesystem_mock.py:
  56         (MockFileSystem.__init__):
  57         (MockFileSystem._mktemp):
  58         (MockFileSystem.mkdtemp):
  59         * Scripts/webkitpy/layout_tests/port/webkit.py:
  60         (WebKitDriver.__init__):
  61         (WebKitDriver._start):
  62         (WebKitDriver.stop):
  63         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  64         (WebKitDriverTest.test_check_for_driver_crash):
  65         (WebKitDriverTest):
  66         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
  67         (WebKitDriverTest.test_stop_cleans_up_properly):
  68
  69 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
  70
  71         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
  72         https://bugs.webkit.org/show_bug.cgi?id=86841
  73
  74         Reviewed by Adam Barth.
  75
  76         Print the number of MessagePorts for each new intent in EFL's DRT.
  77         This output is expected by several Web Intents test cases.
  78
  79         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  80         (DumpRenderTreeChrome::onFrameIntentNew):
  81
  82 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
  83
  84         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
  85
  86         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  87
  88 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
  89
  90         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
  91         https://bugs.webkit.org/show_bug.cgi?id=87829
  92
  93         Reviewed by Adam Barth.
  94
  95         EFL's LayoutTestController now makes uses of the new helper method in
  96         DumpRenderTreeSupportEfl in order to send the intent response. This is
  97         now needed because the Ewk_Intent_Request postResult / postFailure
  98         methods were made private.
  99
 100         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 101         (LayoutTestController::sendWebIntentResponse):
 102
 103 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
 104
 105         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
 106         https://bugs.webkit.org/show_bug.cgi?id=86296
 107
 108         Reviewed by Tony Chang.
 109
 110         * DumpRenderTree/win/DRTDataObject.cpp: Added.
 111         (cfHDropFormat):
 112         (cfFileNameWFormat):
 113         (cfUrlWFormat):
 114         (WCEnumFormatEtc):
 115         (WCEnumFormatEtc::WCEnumFormatEtc):
 116         (WCEnumFormatEtc::QueryInterface):
 117         (WCEnumFormatEtc::AddRef):
 118         (WCEnumFormatEtc::Release):
 119         (WCEnumFormatEtc::Next):
 120         (WCEnumFormatEtc::Skip):
 121         (WCEnumFormatEtc::Reset):
 122         (WCEnumFormatEtc::Clone):
 123         (DRTDataObject::createInstance):
 124         (DRTDataObject::DRTDataObject):
 125         (DRTDataObject::~DRTDataObject):
 126         (DRTDataObject::QueryInterface):
 127         (DRTDataObject::AddRef):
 128         (DRTDataObject::Release):
 129         (DRTDataObject::GetData):
 130         (DRTDataObject::GetDataHere):
 131         (DRTDataObject::QueryGetData):
 132         (DRTDataObject::GetCanonicalFormatEtc):
 133         (DRTDataObject::SetData):
 134         (DRTDataObject::CopyMedium):
 135         (DRTDataObject::EnumFormatEtc):
 136         (DRTDataObject::DAdvise):
 137         (DRTDataObject::DUnadvise):
 138         (DRTDataObject::EnumDAdvise):
 139         (DRTDataObject::clearData):
 140         * DumpRenderTree/win/DRTDataObject.h: Added.
 141         (DRTDataObject):
 142         * DumpRenderTree/win/DRTDropSource.cpp: Added.
 143         (DRTDropSource::DRTDropSource):
 144         (DRTDropSource::~DRTDropSource):
 145         (DRTDropSource::QueryInterface):
 146         (DRTDropSource::AddRef):
 147         (DRTDropSource::Release):
 148         (DRTDropSource::createInstance):
 149         (DRTDropSource::QueryContinueDrag):
 150         (DRTDropSource::GiveFeedback):
 151         * DumpRenderTree/win/DRTDropSource.h: Added.
 152         (DRTDropSource):
 153         * DumpRenderTree/win/DumpRenderTree.vcproj:
 154         * DumpRenderTree/win/EventSender.cpp:
 155         (beginDragWithFilesCallback):
 156
 157 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
 158
 159         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
 160         https://bugs.webkit.org/show_bug.cgi?id=58593
 161
 162         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
 163         to WebKitTestRunner's LayoutTestController. The flag is modified via the
 164         public C API of the WebProcess.
 165
 166         Reviewed by Darin Adler.
 167
 168         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 169         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 170         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
 171         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
 172         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 173
 174 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 175
 176         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
 177         https://bugs.webkit.org/show_bug.cgi?id=87848
 178
 179         Reviewed by Csaba Osztrogonác.
 180
 181         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
 182         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
 183         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
 184
 185         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 186         (DumpRenderTreeChrome::extraViews):
 187         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
 188         (DumpRenderTreeChrome):
 189
 190 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 191
 192         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
 193         https://bugs.webkit.org/show_bug.cgi?id=87833
 194
 195         Reviewed by Tor Arne Vestbø.
 196
 197         Print "postProgressFinishedNotification" message if frame load finished
 198         to unskip http/tests/loading/progress-finished-callback.html.
 199
 200         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 201         (DumpRenderTreeChrome::onFrameLoadFinished):
 202
 203 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
 204
 205         [EFL][WK2] Fix WebKit2-EFL build
 206         https://bugs.webkit.org/show_bug.cgi?id=83693
 207
 208         Reviewed by Carlos Garcia Campos.
 209
 210         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
 211
 212 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
 213
 214         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
 215         (They only used to check for Skipped in platform/qt-5.0-wk1)
 216         https://bugs.webkit.org/show_bug.cgi?id=87376
 217
 218         Reviewed by Csaba Osztrogonác.
 219
 220         * Scripts/old-run-webkit-tests:
 221         (buildPlatformResultHierarchy):
 222         * Scripts/webkitpy/layout_tests/port/qt.py:
 223         (QtPort.baseline_search_path):
 224
 225 2012-05-29  Ojan Vafai  <ojan@chromium.org>
 226
 227         Add a linter error for pngs that lack an embedded checksum
 228         https://bugs.webkit.org/show_bug.cgi?id=87793
 229
 230         Reviewed by Dirk Pranke.
 231
 232         * Scripts/read-checksum-from-png:
 233         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
 234         (read_checksum):
 235         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
 236         (ReadChecksumFromPngTest):
 237         (ReadChecksumFromPngTest.test_read_checksum):
 238         * Scripts/webkitpy/layout_tests/port/base.py:
 239         * Scripts/webkitpy/style/checkers/png.py:
 240         (PNGChecker.check):
 241         * Scripts/webkitpy/style/checkers/png_unittest.py:
 242         (PNGCheckerTest.test_check):
 243
 244 2012-05-29  Stephanie Lewis  <slewis@apple.com>
 245
 246         https://bugs.webkit.org/show_bug.cgi?id=87720
 247         WebProcess is often killed due to being unresponsive on the bots
 248
 249         Reviewed by Alexey Proskuryakov.
 250
 251         Blind attempt to improve flakiness on the bots by reducing the number
 252         of crashes due to an unresponsive process.  This helped on my personal machine
 253         under stress conditions.  I don't have enough cores to hit the problem
 254         under normal conditions.
 255
 256         * WebKitTestRunner/TestController.cpp:
 257         (WTR):
 258
 259 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
 260
 261         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
 262         https://bugs.webkit.org/show_bug.cgi?id=87779
 263
 264         Reviewed by Eric Seidel.
 265
 266         Update output to match the names in scm.py as per
 267         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
 268
 269         * Scripts/webkitpy/tool/commands/rebaseline.py:
 270         (RebaselineTest.execute):
 271         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 272         (test_rebaseline_test_and_print_scm_changes):
 273         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 274         (GardeningServerTest.test_rebaselineall):
 275
 276 2012-05-29  Stephanie Lewis  <slewis@apple.com>
 277
 278         https://bugs.webkit.org/show_bug.cgi?id=87711
 279
 280         Reviewed by Jessie Berlin.
 281
 282         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
 283         are better maintained.
 284
 285         * BuildSlaveSupport/build.webkit.org-config/config.json:
 286
 287 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
 288
 289         webkit-patch optimize-baselines should add/delete files in batches from the vcs
 290         https://bugs.webkit.org/show_bug.cgi?id=87538
 291
 292         Reviewed by Ojan Vafai.
 293
 294         Invoking git and svn on one file at a time is kinda slow. We
 295         should batch the add and rm operations together.
 296
 297         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
 298         (BaselineOptimizer._move_baselines):
 299
 300 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
 301
 302         garden-o-matic should rebaseline baselines in parallel
 303         https://bugs.webkit.org/show_bug.cgi?id=87451
 304
 305         Reviewed by Ojan Vafai.
 306
 307         This modifies garden-o-matic so that we will fetch all
 308         of the baselines in parallel from the bots, and then
 309         optimize the baselines serially (since that should be fairly
 310         quick and we get into trouble if we optimize in parallel due
 311         to concurrent access to the source control system).
 312
 313         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
 314         so that the files that need to be modified in the SCM are returned to
 315         garden-o-matic rather than actually added or removed. This is done so that
 316         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
 317         concurrently). In order to safely return the files (as a JSON dict) I
 318         needed to shift all of the logging in rebaseline-test to use the logging
 319         module (and hence log to stderr).
 320
 321         I also had to stub out a line in chromium.py that would get confused if
 322         the skia overrides file didn't exist in a mock checkout.
 323
 324         * Scripts/webkitpy/common/system/executive.py:
 325         (Executive.popen):
 326         (Executive):
 327         (Executive.run_in_parallel):
 328         (_run_command_thunk):
 329         * Scripts/webkitpy/common/system/executive_mock.py:
 330         (MockExecutive.run_in_parallel):
 331         * Scripts/webkitpy/common/system/executive_unittest.py:
 332         (ExecutiveTest.test_run_in_parallel):
 333         * Scripts/webkitpy/layout_tests/port/chromium.py:
 334         (ChromiumPort._expectations_file_contents):
 335         * Scripts/webkitpy/tool/commands/rebaseline.py:
 336         (AbstractRebaseliningCommand.__init__):
 337         (RebaselineTest.__init__):
 338         (RebaselineTest._copy_existing_baseline):
 339         (RebaselineTest._save_baseline):
 340         (RebaselineTest):
 341         (RebaselineTest._add_to_scm):
 342         (RebaselineTest._rebaseline_test):
 343         (RebaselineTest.execute):
 344         (RebaselineExpectations._rebaseline_port):
 345         (RebaselineExpectations.execute):
 346         (Rebaseline._builder_to_pull_from):
 347         (Rebaseline.execute):
 348         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 349         (test_rebaseline_updates_expectations_file):
 350         (test_rebaseline_test):
 351         (test_rebaseline_test_and_print_scm_changes):
 352         (test_rebaseline_and_copy_test):
 353         (test_rebaseline_and_copy_test_no_existing_result):
 354         (test_rebaseline_and_copy_test_with_lion_result):
 355         (test_rebaseline_and_copy_no_overwrite_test):
 356         (test_rebaseline_expectations):
 357         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 358         (GardeningHTTPRequestHandler._rebaseline_commands):
 359         (GardeningHTTPRequestHandler):
 360         (GardeningHTTPRequestHandler._files_to_add):
 361         (GardeningHTTPRequestHandler._optimize_baselines):
 362         (GardeningHTTPRequestHandler.rebaselineall):
 363         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 364         (GardeningServerTest._post_to_path):
 365         (GardeningServerTest.test_rebaselineall):
 366         (GardeningServerTest.test_rebaselineall.run_command):
 367
 368 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
 369
 370         Fix the type of dispatch_time() offset
 371
 372         Rubber-stamped by Joseph Pecoraro.
 373
 374         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
 375
 376         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 377         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
 378
 379 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
 380
 381         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
 382
 383         [BlackBerry] OpenGL content is not rendered on simulator
 384         https://bugs.webkit.org/show_bug.cgi?id=87721
 385
 386         Reviewed by George Staikos.
 387
 388         Fixed by enabling GLES2 support in simulator builds.
 389
 390         To experiment with building without OpenGL support, you can set the
 391         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
 392
 393         PR #150695
 394
 395         * Scripts/webkitdirs.pm:
 396         (blackberryCMakeArguments):
 397
 398 2012-05-29  David Barr  <davidbarr@chromium.org>
 399
 400         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
 401         https://bugs.webkit.org/show_bug.cgi?id=87685
 402
 403         Reviewed by Eric Seidel.
 404
 405         Add a configuration option for CSS image-resolution support, disabling it by default.
 406
 407         * Scripts/webkitperl/FeatureList.pm:
 408         * qmake/mkspecs/features/features.pri:
 409
 410 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 411
 412         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
 413
 414         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
 415             valid for C++/ObjC++ but not for C [enabled by default]"
 416
 417         Reviewed by Simon Hausmann.
 418
 419         * qmake/mkspecs/features/unix/default_post.prf:
 420
 421 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 422
 423         [Qt] Sync up favicon-implementation with WebView url changes in r118158
 424
 425         https://bugs.webkit.org/show_bug.cgi?id=87133
 426
 427         We now base64-encode the page url in the image-provider url, so that any
 428         normalization done by QUrl will not mess up the page-url. The logic of
 429         creating and parsing the provider-url has been moved into the image
 430         provider, to keep it in one place.
 431
 432         We were also releasing icons (even ones we hadn't retained), which we can't
 433         do since we don't know when the icon url is no longer in use.
 434
 435         Reviewed-by Simon Hausmann.
 436
 437         * MiniBrowser/qt/icons/favicon.png:
 438         * MiniBrowser/qt/qml/BrowserWindow.qml:
 439
 440 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 441
 442         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
 443         https://bugs.webkit.org/show_bug.cgi?id=87654
 444
 445         Reviewed by Csaba Osztrogonác.
 446
 447         Event sender provides strings for all the key events.
 448         Also KeyEventInfo constructor parameters order was changed to simplify the case when
 449         a key event has empty string.
 450
 451         * DumpRenderTree/efl/EventSender.cpp:
 452         (KeyEventInfo::KeyEventInfo):
 453         (keyPadNameFromJSValue):
 454         (keyNameFromJSValue):
 455
 456 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 457
 458         [Qt] Cancel potential url-edit when going back/forward
 459
 460         Reviewed by Kenneth Rohde Christiansen.
 461
 462         * MiniBrowser/qt/qml/BrowserWindow.qml:
 463
 464 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
 465
 466         [EFL] Compilation warning in DumpRenderTreeView.cpp
 467         https://bugs.webkit.org/show_bug.cgi?id=87636
 468
 469         Reviewed by Filip Pizlo.
 470
 471         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
 472         specifier in printf. Also fix the return type for
 473         onExceededApplicationCacheQuota callback.
 474
 475         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
 476         (onExceededApplicationCacheQuota):
 477
 478 2012-05-29  Hironori Bono  <hbono@chromium.org>
 479
 480         Adding Hironori Bono to committers.py.
 481         https://bugs.webkit.org/show_bug.cgi?id=87697
 482
 483         * Scripts/webkitpy/common/config/committers.py:
 484
 485 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
 486
 487         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
 488         https://bugs.webkit.org/show_bug.cgi?id=80135
 489
 490         Reviewed by Rob Buis.
 491
 492         Implemented interface function didReceiveAuthenticationChallenge in class
 493         DumpRenderTree.
 494
 495         Resubmit the patch reverted by r115104 after the digest infinite loop
 496         issue for BlackBerry porting get identified and fixed.
 497
 498         Internally reviewed by Joe Mason <jmason@rim.com>
 499
 500         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
 501         (drtCredentialDescription):
 502         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
 503         (WebKit):
 504         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
 505         (WebCore):
 506         (DumpRenderTree):
 507
 508 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
 509
 510         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
 511         https://bugs.webkit.org/show_bug.cgi?id=42328
 512
 513         Reviewed by Eric Seidel.
 514
 515         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
 516         move to windows.internals.settings.
 517
 518         * DumpRenderTree/LayoutTestController.cpp:
 519         (LayoutTestController::staticFunctions):
 520         * DumpRenderTree/LayoutTestController.h:
 521         (LayoutTestController):
 522         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
 523         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
 524         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
 525         (DRTDevToolsAgent):
 526         * DumpRenderTree/chromium/LayoutTestController.cpp:
 527         (LayoutTestController::LayoutTestController):
 528         * DumpRenderTree/chromium/LayoutTestController.h:
 529         (LayoutTestController):
 530         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 531         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 532         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 533         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 534         * DumpRenderTree/mac/DumpRenderTree.mm:
 535         (resetWebViewToConsistentStateBeforeTesting):
 536         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 537         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 538         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 539         (LayoutTestController):
 540         * DumpRenderTree/win/DumpRenderTree.cpp:
 541         (resetWebViewToConsistentStateBeforeTesting):
 542         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 543         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 544         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 545         (LayoutTestController):
 546
 547 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 548
 549         Move allowRoundingHacks to Internals interface
 550         https://bugs.webkit.org/show_bug.cgi?id=87328
 551
 552         Reviewed by Hajime Morita.
 553
 554         Remove allowRoundingHacks functions, because it is able to work in the
 555         cross-port way through the Internals interface.
 556
 557         * DumpRenderTree/LayoutTestController.cpp:
 558         (LayoutTestController::staticFunctions):
 559         * DumpRenderTree/LayoutTestController.h:
 560         (LayoutTestController):
 561         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
 562         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 563         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 564         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 565         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 566         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 567
 568 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
 569
 570         Fix mac build with older XCode by defining NSEC_PER_MSEC.
 571         https://bugs.webkit.org/show_bug.cgi?id=87616
 572
 573         Reviewed by Hajime Morita.
 574
 575         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
 576         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
 577         Patch just adds a #ifndef / #define check.
 578
 579         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 580         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
 581
 582 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 583
 584         [EFL] Enable blob support for the EFL port
 585         https://bugs.webkit.org/show_bug.cgi?id=85363
 586
 587         Reviewed by Hajime Morita.
 588
 589         Enable Blob support by default for the EFL port.
 590
 591         * Scripts/webkitperl/FeatureList.pm:
 592
 593 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
 594
 595         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
 596         https://bugs.webkit.org/show_bug.cgi?id=87582
 597
 598         Reviewed by Darin Adler.
 599
 600         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
 601         possible to test pages in a similar way as they are loaded in Browsers.
 602
 603         * DumpRenderTree/LayoutTestController.cpp:
 604         (LayoutTestController::LayoutTestController):
 605         (setUseDeferredFrameLoadingCallback):
 606         (LayoutTestController::staticFunctions):
 607         * DumpRenderTree/LayoutTestController.h:
 608         (LayoutTestController::useDeferredFrameLoading):
 609         (LayoutTestController::setUseDeferredFrameLoading):
 610         (LayoutTestController):
 611         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 612         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
 613
 614 2012-05-27  David Barton  <dbarton@mathscribe.com>
 615
 616         [watchlist] Improve MathML rule
 617         https://bugs.webkit.org/show_bug.cgi?id=87592
 618
 619         Reviewed by Adam Barth.
 620
 621         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
 622         but if this changed the rule would be slow. We protect against this, clarify the rule,
 623         and make it more similar to existing rules.
 624
 625         * Scripts/webkitpy/common/config/watchlist:
 626
 627 2012-05-27  David Barton  <dbarton@mathscribe.com>
 628
 629         [watchlist] Add myself & a rule for MathML
 630         https://bugs.webkit.org/show_bug.cgi?id=87586
 631
 632         Reviewed by Adam Barth.
 633
 634         * Scripts/webkitpy/common/config/watchlist:
 635
 636 2012-05-26  David Kilzer  <ddkilzer@apple.com>
 637
 638         Use xcrun to find path to nm for Mac port
 639         <http://webkit.org/b/87588>
 640
 641         Reviewed by Dan Bernstein.
 642
 643         * Scripts/webkitpy/layout_tests/port/mac.py:
 644         (MacPort.nm_command): Add. Tries to find a path for the nm
 645         command using xcrun.  Falls back to returning 'nm'.
 646         * Scripts/webkitpy/layout_tests/port/webkit.py:
 647         (WebKitPort.nm_command): Add. Returns 'nm'.
 648         (WebKitPort._webcore_symbols_string): Call self.nm_command().
 649
 650 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
 651
 652         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
 653
 654         Reviewed by Eric Seidel.
 655
 656         * DumpRenderTree/win/DumpRenderTree.vcproj:
 657         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 658         (FrameLoadDelegate::FrameLoadDelegate):
 659         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
 660         * DumpRenderTree/win/FrameLoadDelegate.h:
 661         (FrameLoadDelegate):
 662         * DumpRenderTree/win/TextInputController.cpp: Added.
 663         (setMarkedTextCallback):
 664         (hasMarkedTextCallback):
 665         (unmarkTextCallback):
 666         (markedRangeCallback):
 667         (insertTextCallback):
 668         (firstRectForCharacterRangeCallback):
 669         (selectedRangeCallback):
 670         (TextInputController::makeWindowObject):
 671         (TextInputController::getJSClass):
 672         (TextInputController::staticValues):
 673         (TextInputController::staticFunctions):
 674         * DumpRenderTree/win/TextInputController.h: Added.
 675         (TextInputController):
 676         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
 677         (TextInputController::setMarkedText):
 678         (TextInputController::hasMarkedText):
 679         (TextInputController::unmarkText):
 680         (TextInputController::markedRange):
 681         (TextInputController::insertText):
 682         (TextInputController::firstRectForCharacterRange):
 683         (TextInputController::selectedRange):
 684
 685 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
 686
 687         webkitpy: change scm.add(), scm.delete() to accept multiple paths
 688         https://bugs.webkit.org/show_bug.cgi?id=87528
 689
 690         Reviewed by Ojan Vafai.
 691
 692         launching git or svn for individual files can be slow; this
 693         change will hand multiple paths at once to git and svn so they
 694         can be added in a batch.
 695
 696         * Scripts/webkitpy/common/checkout/scm/git.py:
 697         (Git.add_list):
 698         (Git.delete_list):
 699         * Scripts/webkitpy/common/checkout/scm/scm.py:
 700         (SCM.add):
 701         (SCM):
 702         (SCM.add_list):
 703         (SCM.delete):
 704         (SCM.delete_list):
 705         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
 706         (MockSCM.add):
 707         (MockSCM):
 708         (MockSCM.add_list):
 709         (MockSCM.delete):
 710         (MockSCM.delete_list):
 711         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 712         (_shared_test_exists):
 713         (_shared_test_added_files):
 714         (_test_delete_list):
 715         * Scripts/webkitpy/common/checkout/scm/svn.py:
 716         (SVN.add_list):
 717         (SVN.delete_list):
 718
 719 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 720
 721         [NRWT] Add unit testing for perf tests on locked shards
 722         https://bugs.webkit.org/show_bug.cgi?id=87489
 723
 724         Reviewed by Dirk Pranke.
 725
 726         Adding utests that makes sure that perf tests are running in locked
 727         shards and by passing --no-http won't break NRWT (r118421).
 728
 729         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
 730         (ShardingTests):
 731         (ShardingTests.test_shard_by_dir):
 732         (ShardingTests.test_shard_every_file):
 733         (ShardingTests.test_shard_in_two):
 734         (ShardingTests.test_multiple_locked_shards):
 735         (LockCheckingManager):
 736         (LockCheckingManager.__init__):
 737         (LockCheckingManager.handle_finished_list):
 738         (ManagerTest.test_http_locking):
 739         (ManagerTest):
 740         (ManagerTest.test_perf_locking):
 741         * Scripts/webkitpy/layout_tests/port/test.py:
 742
 743 2012-05-25  Jessie Berlin  <jberlin@apple.com>
 744
 745         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
 746         https://bugs.webkit.org/show_bug.cgi?id=87511
 747
 748         Reviewed by Alexey Proskuryakov.
 749
 750         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
 751
 752         * DumpRenderTree/win/EventSender.cpp:
 753         (keyDownCallback):
 754
 755 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
 756
 757         Adding Ken Buchanan to committers.py
 758         https://bugs.webkit.org/show_bug.cgi?id=87443
 759
 760         Unreviewed.
 761
 762         Adding self to committers.py as a Committer.
 763
 764         * Scripts/webkitpy/common/config/committers.py:
 765
 766 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
 767
 768         [Qt] Buildfix for newer Qt5
 769         https://bugs.webkit.org/show_bug.cgi?id=87257
 770
 771         Reviewed by Simon Hausmann.
 772
 773         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
 774
 775 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
 776
 777         [Qt] Unreviewed fix after r118484.
 778
 779         Enable CSS_EXCLUSIONS and CSS_REGIONS.
 780         They were enabled uncoditinally before r118484.
 781
 782         * qmake/mkspecs/features/features.pri:
 783
 784 2012-05-24  Tim Horton  <timothy_horton@apple.com>
 785
 786         Add feature defines for web-facing parts of CSS Regions and Exclusions
 787         https://bugs.webkit.org/show_bug.cgi?id=87442
 788         <rdar://problem/10887709>
 789
 790         Reviewed by Dan Bernstein.
 791
 792         * Scripts/webkitperl/FeatureList.pm:
 793
 794 2012-05-24  Hironori Bono  <hbono@chromium.org>
 795
 796         Enable grammar checking on Chromium when we paste text (Take 2)
 797         https://bugs.webkit.org/show_bug.cgi?id=74393
 798
 799         Reviewed by Ryosuke Niwa.
 800
 801         This change enables grammar checking on Chromium and implements a mock grammar
 802         checker to fix a failing test.
 803
 804         * DumpRenderTree/DumpRenderTree.gypi:
 805         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
 806         (MockGrammarCheck::checkGrammarOfString):
 807         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
 808         (WebKit):
 809         (MockGrammarCheck):
 810         * DumpRenderTree/chromium/WebViewHost.cpp:
 811         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
 812
 813 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 814
 815         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
 816         https://bugs.webkit.org/show_bug.cgi?id=86842
 817
 818         Reviewed by Antonio Gomes.
 819
 820         Add support for overriding the application cache support preference
 821         through EFL's LayoutTestController.
 822
 823         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 824         (LayoutTestController::overridePreference):
 825
 826 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 827
 828         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
 829         https://bugs.webkit.org/show_bug.cgi?id=85209
 830
 831         Reviewed by Antonio Gomes.
 832
 833         Set developer extras setting called twice on the test startup. Hence, removing
 834         an unnecessary extra call which set wrong value.
 835
 836         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 837         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 838
 839 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
 840
 841         garden-o-matic should not fetch from debug bots if it also knows about the release bots
 842         https://bugs.webkit.org/show_bug.cgi?id=86916
 843
 844         Reviewed by Adam Barth.
 845
 846         Note that if release and debug are failing differently, debug
 847         will be ignored ...
 848
 849         Note: also change the use of a fake port name from
 850         "mock-port-name" to "test-mac-leopard" to make it more friendly
 851         to the port factory ("mock" actually is a real port).
 852
 853         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 854         (GardeningHTTPRequestHandler._builders_to_fetch_from):
 855         (GardeningHTTPRequestHandler.rebaselineall):
 856         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 857         (GardeningServerTest.test_rebaselineall):
 858         (GardeningServerTest.test_rebaseline_new_port):
 859
 860 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
 861
 862         nrwt: fix baseline search path for official chrome builders
 863         https://bugs.webkit.org/show_bug.cgi?id=87432
 864
 865         Reviewed by Tony Chang.
 866
 867         The official chrome builders need to use the win7 and SL
 868         baseline paths, not the XP and Leopard paths. Linux is correct.
 869
 870         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
 871         (GoogleChromeMacPort.determine_full_port_name):
 872         (GoogleChromeWinPort.determine_full_port_name):
 873         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 874         (TestGoogleChromePort._verify_baseline_search_path_startswith):
 875         (TestGoogleChromePort.test_get_google_chrome_port):
 876
 877 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 878
 879         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
 880         https://bugs.webkit.org/show_bug.cgi?id=86800
 881
 882         Reviewed by Dirk Pranke.
 883
 884         Don't launch a HTTP server with lock based only on the existence of
 885         locked shards since we now run perf on locked shards too.
 886
 887         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 888         (Manager._run_tests):
 889
 890 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
 891
 892         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
 893         https://bugs.webkit.org/show_bug.cgi?id=87128
 894
 895         Reviewed by Dirk Pranke.
 896
 897         * Scripts/webkitpy/layout_tests/port/base.py:
 898         (Port.driver_name):
 899         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 900         (ChromiumLinuxPort._path_to_driver):
 901         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 902         (ChromiumPortTest.test_driver_name_option):
 903         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 904         (ChromiumWinPort._path_to_driver):
 905         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 906         (parse_args):
 907
 908 2012-05-24  John Mellor  <johnme@chromium.org>
 909
 910         Font Boosting: Add compile flag and runtime setting
 911         https://bugs.webkit.org/show_bug.cgi?id=87394
 912
 913         Reviewed by Adam Barth.
 914
 915         Add ENABLE_FONT_BOOSTING.
 916
 917         * Scripts/webkitperl/FeatureList.pm:
 918         * qmake/mkspecs/features/features.pri:
 919
 920 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 921
 922         [EFL] [DRT] keyboard-related tests do not pass
 923         https://bugs.webkit.org/show_bug.cgi?id=85369
 924
 925         Reviewed by Gustavo Noronha Silva.
 926
 927         Add SHIFT modifier for capital letters as VK_
 928         codes do not distinguish between lows and caps and also to be consistent
 929         with other ports which send caps as lowercase letters with the shift key down.
 930
 931         * DumpRenderTree/efl/EventSender.cpp:
 932         (keyNameFromJSValue):
 933
 934 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
 935
 936         [WK2] Let the client give local files universal access on a case by case basis
 937         https://bugs.webkit.org/show_bug.cgi?id=87174
 938         <rdar://problem/11024330>
 939
 940         Reviewed by Maciej Stachowiak.
 941
 942         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
 943         Added initialization of a new structure member to prevent build failure.
 944
 945 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
 946
 947         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
 948         https://bugs.webkit.org/show_bug.cgi?id=87203
 949
 950         Reviewed by Andreas Kling.
 951
 952         Add the required changes to make
 953         fast/events/keydown-leftright-keys.html pass after r118001.
 954
 955         * DumpRenderTree/efl/EventSender.cpp:
 956         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
 957         into the proper X11 keysym definitions.
 958
 959 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
 960
 961         Unreviewed, rolling out r118352.
 962         http://trac.webkit.org/changeset/118352
 963         https://bugs.webkit.org/show_bug.cgi?id=87390
 964
 965         Caused 6 editing/spelling tests crash/fail on chromium in
 966         debug. (Requested by vsevik on #webkit).
 967
 968         * DumpRenderTree/DumpRenderTree.gypi:
 969         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
 970         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
 971         * DumpRenderTree/chromium/WebViewHost.cpp:
 972         (WebViewHost::finishLastTextCheck):
 973
 974 2012-05-24  Peter Beverloo  <peter@chromium.org>
 975
 976         Add John Mellor as a contributor
 977         https://bugs.webkit.org/show_bug.cgi?id=87389
 978
 979         Reviewed by Kenneth Rohde Christiansen.
 980
 981         John will be working on Font Boosting and is very involved with various
 982         web-facing subjects of Chrome for Android, such as viewport.
 983
 984         * Scripts/webkitpy/common/config/committers.py:
 985
 986 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 987
 988         [EFL][DRT] LayoutTestController's setCacheModel() implementation
 989         https://bugs.webkit.org/show_bug.cgi?id=86840
 990
 991         Reviewed by Csaba Osztrogonác.
 992
 993         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 994         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
 995         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 996         (LayoutTestController::setCacheModel): Implementation added.
 997
 998 2012-05-24  Hironori Bono  <hbono@chromium.org>
 999
1000         Enable grammar checking on Chromium when we paste text.
1001         https://bugs.webkit.org/show_bug.cgi?id=74393
1002
1003         Reviewed by Hajime Morita.
1004
1005         This change enables grammar checking on Chromium and implements a mock grammar
1006         checker to fix a failing test.
1007
1008         * DumpRenderTree/DumpRenderTree.gypi:
1009         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
1010         (MockGrammarCheck::checkGrammarOfString):
1011         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
1012         (WebKit):
1013         (MockGrammarCheck):
1014         * DumpRenderTree/chromium/WebViewHost.cpp:
1015         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
1016
1017 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1018
1019         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
1020
1021         * qmake/mkspecs/features/features.pri:
1022
1023 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
1024
1025         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
1026         https://bugs.webkit.org/show_bug.cgi?id=86867
1027
1028         Reviewed by Adam Barth.
1029
1030         Add implementation for sendWebIntentResponse() in EFL's
1031         LayoutTestController and add empty implementation for other ports.
1032
1033         * DumpRenderTree/LayoutTestController.cpp:
1034         (sendWebIntentResponseCallback):
1035         (LayoutTestController::staticFunctions):
1036         * DumpRenderTree/LayoutTestController.h:
1037         (LayoutTestController):
1038         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1039         (LayoutTestController::sendWebIntentResponse):
1040         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1041         (DumpRenderTreeChrome::currentIntentRequest):
1042         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1043         (DumpRenderTreeChrome::onFrameIntentNew):
1044         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1045         (DumpRenderTreeChrome):
1046         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1047         (LayoutTestController::sendWebIntentResponse):
1048         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1049         (LayoutTestController::sendWebIntentResponse):
1050         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1051         (LayoutTestController::sendWebIntentResponse):
1052         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1053         (LayoutTestController::sendWebIntentResponse):
1054         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1055         (LayoutTestController::sendWebIntentResponse):
1056
1057 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
1058
1059         [EFL] The EFL port has no support for title directionality
1060         https://bugs.webkit.org/show_bug.cgi?id=86462
1061
1062         Reviewed by Gustavo Noronha Silva.
1063
1064         Update "title,changed" signal handlers in DRT and EWebLauncher to
1065         reflect the change from const char* to Ewk_Text_With_Direction* type
1066         for the title.
1067
1068         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1069         (DumpRenderTreeChrome::onTitleChanged):
1070         * EWebLauncher/main.c:
1071         (title_set):
1072         (on_title_changed):
1073         (on_key_down):
1074
1075 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1076
1077         Change EFL debug build name with more detail one
1078         https://bugs.webkit.org/show_bug.cgi?id=87254
1079
1080         Reviewed by Ryosuke Niwa.
1081
1082         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
1083         In addition, remove efl-linux-debug triggerable since nobody uses it.
1084
1085         * BuildSlaveSupport/build.webkit.org-config/config.json:
1086
1087 2012-05-23  Kangil Han  <kangil.han@samsung.com>
1088
1089         [EFL][DRT] Fix WebCore library path and rebaseline result
1090         https://bugs.webkit.org/show_bug.cgi?id=86355
1091
1092         Reviewed by Dirk Pranke.
1093
1094         Currently EFL DRT uses wrong WebCore library path when running DRT.
1095         Therefore, this patch adjusted the path correctly.
1096
1097         * Scripts/webkitpy/layout_tests/port/efl.py:
1098         (EflPort._path_to_webcore_library):
1099
1100 2012-05-23  Ojan Vafai  <ojan@chromium.org>
1101
1102         add back the ability to disable flexbox
1103         https://bugs.webkit.org/show_bug.cgi?id=87147
1104
1105         Reviewed by Tony Chang.
1106
1107         * Scripts/webkitperl/FeatureList.pm:
1108
1109 2012-05-23  Tony Chang  <tony@chromium.org>
1110
1111         Remove the Chromium Grid Layout bot from the waterfall
1112         https://bugs.webkit.org/show_bug.cgi?id=87311
1113
1114         Reviewed by Ryosuke Niwa.
1115
1116         I removed the compiler define in r117613, so we don't need a separate
1117         bot to compile/test this code.
1118
1119         * BuildSlaveSupport/build.webkit.org-config/config.json:
1120
1121 2012-05-23  Ian Vollick  <vollick@chromium.org>
1122
1123         Add vollick to list of contributors.
1124         https://bugs.webkit.org/show_bug.cgi?id=87305
1125
1126         Reviewed by Adam Barth.
1127
1128         * Scripts/webkitpy/common/config/committers.py:
1129
1130 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
1131
1132         [Chromium-Android] Fix chromium_android_unittest
1133         https://bugs.webkit.org/show_bug.cgi?id=87196
1134
1135         Reviewed by Tony Chang.
1136
1137         Update unit tests after ChromiumAndroidPort supported apk based
1138         DumpRenderTree.
1139
1140         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1141         (ChromiumAndroidPortTest):
1142         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
1143         (ChromiumAndroidPortTest.test_get_last_stacktrace):
1144         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
1145         (ChromiumAndroidDriverTest):
1146         (ChromiumAndroidDriverTest.setUp):
1147         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
1148         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
1149
1150 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1151
1152         [watchlist] Add myself and create a watch rule to catch Attribute related patches
1153         https://bugs.webkit.org/show_bug.cgi?id=87303
1154
1155         Reviewed by Alexis Menard.
1156
1157         * Scripts/webkitpy/common/config/watchlist:
1158
1159 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
1160
1161         garden-o-matic should not fetch from debug bots if it also knows about the release bots
1162         https://bugs.webkit.org/show_bug.cgi?id=86916
1163
1164         Reviewed by Adam Barth.
1165
1166         This change pushes all of the logic for rebaselining a cluster
1167         of failures (a list of tests failing a list of suffixes on a
1168         list of bots) onto the server, so there is a single call from
1169         the web page; we will then be able to optimize the performance
1170         of the rebaselining better.
1171
1172         Also remove the 'optimizebaseline' entry point on garden-o-matic
1173         (and the client-side call) since we don't need it any more.
1174
1175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1177         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1178         (GardeningHTTPRequestHandler.rebaselineall):
1179         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1180
1181 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1182
1183         Mac DRT should be able to load external URLs for replay performance tests
1184         https://bugs.webkit.org/show_bug.cgi?id=86191
1185
1186         Reviewed by Alexey Proskuryakov.
1187
1188         Let external URL requests go through if the test file is not a local file or hosted at localhost.
1189         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
1190         "DumpRenderTree http://localhost:8000/".
1191
1192         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1193         (isLocalhost):
1194         (hostIsUsedBySomeTestsToGenerateError):
1195         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1196
1197 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
1198
1199         [wx] In wxWebKit release builds on MSW, keep release settings but also build the
1200         debug symbols for easier debugging.
1201         https://bugs.webkit.org/show_bug.cgi?id=87151
1202
1203         Reviewed by Kevin Ollivier.
1204
1205         * waf/build/settings.py:
1206         (common_configure):
1207
1208 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1209
1210         Unreviewed. Move myself to reviewers.
1211
1212         * Scripts/webkitpy/common/config/committers.py:
1213
1214 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
1215
1216         [EFL] Implements the registerProtocolHandler method and option.
1217         https://bugs.webkit.org/show_bug.cgi?id=73638
1218
1219         Reviewed by Andreas Kling.
1220
1221         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
1222
1223 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
1224
1225         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
1226         https://bugs.webkit.org/show_bug.cgi?id=87221
1227
1228         Reviewed by Martin Robinson.
1229
1230         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
1231         rightShift key names into proper GDK key symbols.
1232
1233         * DumpRenderTree/gtk/EventSender.cpp:
1234         (createKeyPressEvent):
1235
1236 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1237
1238         [Qt] Make the web view's url property follow the active url
1239
1240         https://bugs.webkit.org/show_bug.cgi?id=77554
1241
1242         Update  the location bar in the minibrowser to behave
1243         a bit more like normal browsers in terms of when the url will change
1244         and how active focus is handled.
1245
1246         Reviewed by Simon Hausmann.
1247
1248         * MiniBrowser/qt/qml/BrowserWindow.qml:
1249
1250 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1251
1252         [Qt] Remove references to $$QT_SOURCE_TREE
1253
1254         With a modularized Qt, it's ambigious. What we really want is qtbase,
1255         which qtcore is a proxy for (we assume it will always live in qtbase).
1256
1257         Reviewed by Tor Arne Vestbø.
1258
1259         * DumpRenderTree/qt/DumpRenderTree.pro:
1260
1261 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1262
1263         [Qt] Fix qmake conditional for c++-11 compat warnings
1264
1265         Reviewed by Tor Arne Vestbø.
1266
1267         * qmake/mkspecs/features/unix/default_post.prf:
1268
1269 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
1270
1271         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
1272         https://bugs.webkit.org/show_bug.cgi?id=85956
1273
1274         Reviewed by Gustavo Noronha Silva.
1275
1276         Catch new "load,provisional,failed" signal and print
1277         didFailProvisionalLoadWithError messages when LayoutTestController's
1278         dumpFrameLoadCallbacks() returns true. Also make sure the
1279         didFailLoadWithError message is not printed in case of provisional
1280         load failure.
1281
1282         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1283         (DumpRenderTreeChrome::createView):
1284         (DumpRenderTreeChrome::onFrameCreated):
1285         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
1286         (DumpRenderTreeChrome::onFrameLoadError):
1287         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1288         (DumpRenderTreeChrome):
1289
1290 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
1291
1292         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
1293         https://bugs.webkit.org/show_bug.cgi?id=86366
1294
1295         Reviewed by Antonio Gomes.
1296
1297         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
1298
1299         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1300         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1301
1302 2012-05-22  Darin Adler  <darin@apple.com>
1303
1304         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
1305         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
1306
1307 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1308
1309         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
1310         https://bugs.webkit.org/show_bug.cgi?id=86922
1311
1312         Because we have new platformInit() in TestShellAndroid.cpp, and
1313         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
1314         is split into TestShellPosix.cpp and TestShellX11.cpp.
1315
1316         Reviewed by Kent Tamura.
1317
1318         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1319         * DumpRenderTree/DumpRenderTree.gypi:
1320         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
1321         (platformInit):
1322         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
1323         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
1324         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
1325         (AlarmHandler):
1326         (TestShell::waitTestFinished):
1327         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
1328         (openStartupDialog): from TestShellGtk.cpp
1329         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
1330         (setupFontconfig):
1331         (platformInit):
1332
1333 2012-05-22  Kangil Han  <kangil.han@samsung.com>
1334
1335         [EFL][DRT] Implement touch event
1336         https://bugs.webkit.org/show_bug.cgi?id=86720
1337
1338         Reviewed by Hajime Morita.
1339
1340         Currently EFL DRT doesn't support touch event.
1341         Therefore, this patch enabled it and implemented some eventSender function callbacks.
1342
1343         * DumpRenderTree/efl/EventSender.cpp:
1344         (TouchEventInfo::TouchEventInfo):
1345         (TouchEventInfo):
1346         (touchPointList):
1347         (sendTouchEvent):
1348         (addTouchPointCallback):
1349         (touchStartCallback):
1350         (updateTouchPointCallback):
1351         (touchMoveCallback):
1352         (cancelTouchPointCallback):
1353         (touchCancelCallback):
1354         (releaseTouchPointCallback):
1355         (touchEndCallback):
1356         (clearTouchPointsCallback):
1357         (setTouchModifierCallback):
1358         * Scripts/webkitperl/FeatureList.pm:
1359
1360 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1361
1362         [Chromium-Android] Fix chromium_android_unittest
1363         https://bugs.webkit.org/show_bug.cgi?id=87196
1364
1365         Not reviewed.
1366         Temporarily disable chromium_android_unittest.
1367
1368         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1369         (ChromiumAndroidPortTest):
1370         (ChromiumAndroidDriverTest):
1371
1372 2012-05-22  Jessie Berlin  <jberlin@apple.com>
1373
1374         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
1375         https://bugs.webkit.org/show_bug.cgi?id=64313
1376
1377         Reviewed by Jon Honeycutt.
1378
1379         Add it.
1380
1381         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1382         Make sure to generate the binding.
1383
1384         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1385         (WTR::LayoutTestController::setDefersLoading):
1386         Call WKBundlePageSetDefersLoading.
1387         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1388
1389 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1390
1391         [Chromium-Android] Run DumpRenderTree as an apk (python part)
1392         https://bugs.webkit.org/show_bug.cgi?id=86923
1393
1394         chromium_android.py is modified to support running DumpRenderTree as
1395         an apk, so that we can run the tests (e.g. video) requiring features
1396         implemented in Java on Android.
1397
1398         Reviewed by Adam Barth.
1399
1400         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1401         (ChromiumAndroidPort.__init__):
1402         (ChromiumAndroidPort.default_child_processes):
1403         (ChromiumAndroidPort.check_wdiff):
1404         (ChromiumAndroidPort.check_build):
1405         (ChromiumAndroidPort.start_helper):
1406         (ChromiumAndroidPort.skipped_layout_tests):
1407         (ChromiumAndroidPort):
1408         (ChromiumAndroidPort._path_to_driver):
1409         (ChromiumAndroidPort._get_crash_log):
1410         (ChromiumAndroidPort._push_executable):
1411         (ChromiumAndroidPort._run_adb_command):
1412         (ChromiumAndroidPort._get_last_stacktrace):
1413         (ChromiumAndroidPort._get_logcat):
1414         (ChromiumAndroidPort._setup_performance):
1415         (ChromiumAndroidDriver):
1416         (ChromiumAndroidDriver.__init__):
1417         (ChromiumAndroidDriver._command_wrapper):
1418         (ChromiumAndroidDriver.cmd_line):
1419         (ChromiumAndroidDriver._file_exists_on_device):
1420         (ChromiumAndroidDriver._deadlock_detector):
1421         (ChromiumAndroidDriver._start):
1422         (ChromiumAndroidDriver.run_test):
1423         (ChromiumAndroidDriver.stop):
1424         (ChromiumAndroidDriver._write_command_and_read_line):
1425         (ChromiumAndroidDriver._output_image):
1426         (ChromiumAndroidDriver._get_stderr):
1427
1428 2012-05-22  Joshua Bell  <jsbell@chromium.org>
1429
1430         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
1431
1432         Unreviewed gardening.
1433
1434         * Scripts/webkitpy/layout_tests/port/base.py:
1435         (Port.driver_name):
1436         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1437         (ChromiumLinuxPort._path_to_driver):
1438         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1439         (ChromiumPortTest.test_overrides_and_builder_names):
1440         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1441         (ChromiumWinPort._path_to_driver):
1442         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1443         (parse_args):
1444
1445 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1446
1447         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
1448         https://bugs.webkit.org/show_bug.cgi?id=87176
1449
1450         Reviewed by Tony Chang.
1451
1452         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1453         * DumpRenderTree/DumpRenderTree.gypi:
1454
1455 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
1456
1457         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
1458         https://bugs.webkit.org/show_bug.cgi?id=87128
1459
1460         Reviewed by Dirk Pranke.
1461
1462         * Scripts/webkitpy/layout_tests/port/base.py:
1463         (Port.driver_name):
1464         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1465         (ChromiumLinuxPort._path_to_driver):
1466         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1467         (ChromiumPortTest.test_driver_name_option):
1468         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1469         (ChromiumWinPort._path_to_driver):
1470         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1471         (parse_args):
1472
1473 2012-05-22  Jessie Berlin  <jberlin@apple.com>
1474
1475         WTR fix after r118001.
1476
1477         Rubber-stamped by Alexey Proskuryakov.
1478
1479         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
1480
1481         * WebKitTestRunner/mac/EventSenderProxy.mm:
1482         (WTR::EventSenderProxy::keyDown):
1483
1484 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
1485
1486         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
1487         https://bugs.webkit.org/show_bug.cgi?id=86684
1488
1489         Reviewed by Darin Fisher.
1490
1491         * DumpRenderTree/chromium/LayoutTestController.cpp:
1492         (LayoutTestController::numberOfPages):
1493         * DumpRenderTree/chromium/WebViewHost.cpp:
1494         (WebViewHost::printPage):
1495
1496 == Rolled over to ChangeLog-2012-05-22 ==