Tools/ChangeLog

   1 2012-11-07  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
   2
   3         WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
   4         https://bugs.webkit.org/show_bug.cgi?id=93611
   5
   6         Reviewed by Gyuyoung Kim.
   7
   8         WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.
   9
  10         * WebKitTestRunner/TestController.cpp:
  11         (WTR::TestController::resetStateToConsistentValues):
  12         Enables spelling by WebKit2 C API.
  13
  14 2012-11-07  Christophe Dumez  <christophe.dumez@intel.com>
  15
  16         Add replaceWithLiteral() method to WTF::String
  17         https://bugs.webkit.org/show_bug.cgi?id=101257
  18
  19         Reviewed by Benjamin Poulain.
  20
  21         Add API tests for String::replaceWithLiteral() and corresponding
  22         StringImpl methods.
  23
  24         * TestWebKitAPI/CMakeLists.txt: Add WTFString API tests to CMake.
  25         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
  26         (TestWebKitAPI::TEST):
  27         (TestWebKitAPI):
  28         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
  29         (TestWebKitAPI::TEST):
  30
  31 2012-07-27  KwangYong Choi  <ky0.choi@samsung.com>
  32
  33         [WK2][EFL][WTR] TestNetscapePlugin is required.
  34         https://bugs.webkit.org/show_bug.cgi?id=88756
  35
  36         Reviewed by Simon Hausmann.
  37
  38         libTestNetscapePlugin.so should be required for DRT/WTR/EFL.
  39
  40         * CMakeLists.txt:
  41         * DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
  42
  43 2012-07-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
  44
  45         [EFL] Memory leaks in EFL DRT
  46         https://bugs.webkit.org/show_bug.cgi?id=92347
  47
  48         Reviewed by Simon Hausmann.
  49
  50         Fix a memory leak in EFL's DRT code by adopting an allocation
  51         of JSString created with JSStringCreateWithUTF8CString.
  52
  53         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  54         (DumpRenderTreeChrome::onWindowObjectCleared):
  55
  56 2012-07-27  Adam Barth  <abarth@webkit.org>
  57
  58         Simplify ExpectedFailures
  59         https://bugs.webkit.org/show_bug.cgi?id=92216
  60
  61         Reviewed by Eric Seidel.
  62
  63         This patch simplifies the ExpectedFailures class we use to remember
  64         which tests are currently failing on the bots. When we wrote this code
  65         originally, we weren't entirely sure how it would work. Now that we
  66         understand it more clearly, we can write the code more clearly.
  67
  68         * Scripts/webkitpy/tool/bot/expectedfailures.py:
  69         (_has_failures):
  70         (_is_trustworthy):
  71         (ExpectedFailures.__init__):
  72         (ExpectedFailures.failures_were_expected):
  73         (ExpectedFailures.unexpected_failures_observed):
  74         (ExpectedFailures.update):
  75         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
  76         (ExpectedFailuresTest._assert_can_trust):
  77         (ExpectedFailuresTest.test_failures_were_expected):
  78         (ExpectedFailuresTest.test_unexpected_failures_observed):
  79         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
  80         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  81         (PatchAnalysisTask._test):
  82         (PatchAnalysisTask._build_and_test_without_patch):
  83         (PatchAnalysisTask._test_patch):
  84
  85 2012-07-27  Csaba Osztrogonác  <ossy@webkit.org>
  86
  87         [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
  88         https://bugs.webkit.org/show_bug.cgi?id=88064
  89
  90         Reviewed by Zoltan Herczeg.
  91
  92         Use resetInternalsObject() instead of injectInternalsObject().
  93
  94         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  95         (WTR::InjectedBundlePage::resetAfterTest):
  96
  97 2012-07-26  Ryuan Choi  <ryuan.choi@samsung.com>
  98
  99         [EFL] Remove forwarding headers from MiniBrowser/Efl.
 100         https://bugs.webkit.org/show_bug.cgi?id=91627
 101
 102         Reviewed by Kentaro Hara.
 103
 104         * MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.
 105
 106 2012-07-26  Yoshifumi Inoue  <yosin@chromium.org>
 107
 108         [Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
 109         https://bugs.webkit.org/show_bug.cgi?id=92339
 110
 111         Reviewed by Kent Tamura.
 112
 113         This patch enables runtime features for input type datetime, datetime-local,
 114         month, time and week for Chromium DRT.
 115
 116         * DumpRenderTree/chromium/TestShell.cpp:
 117         (TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.
 118
 119 2012-07-26  Jeffrey Pfau  <jpfau@apple.com>
 120
 121         Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
 122         https://bugs.webkit.org/show_bug.cgi?id=84041
 123
 124         Reviewed by Brady Eidson.
 125
 126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 127         * TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
 128         (-[BackForwardListTest webView:didFinishLoadForFrame:]):
 129         (-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
 130         (TestWebKitAPI):
 131         (TestWebKitAPI::TEST):
 132
 133 2012-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
 134
 135         Unreviewed, rolling out r123799.
 136         http://trac.webkit.org/changeset/123799
 137         https://bugs.webkit.org/show_bug.cgi?id=92431
 138
 139         broke the Apple Mac build (Requested by bweinstein on
 140         #webkit).
 141
 142         * DumpRenderTree/chromium/TestWebPlugin.cpp:
 143         * DumpRenderTree/chromium/TestWebPlugin.h:
 144         (TestWebPlugin::acceptsInputEvents):
 145         (TestWebPlugin::handleInputEvent):
 146
 147 2012-07-26  Dirk Pranke  <dpranke@chromium.org>
 148
 149         nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
 150         https://bugs.webkit.org/show_bug.cgi?id=92172
 151
 152         Reviewed by Tony Chang.
 153
 154         Right now new-run-webkit-tests --verbose prints out too much
 155         information (it's like --verbose + debugging). I plan to fix
 156         this in bug 88702, and also clean up and simplify all of the
 157         --print options, but in preparation for these changes I need to
 158         pass --verbose twice to get the same level of output
 159         temporarily (for compatibility).
 160
 161         * Scripts/run-webkit-tests:
 162
 163 2012-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
 164
 165         Propagate gesture events to plugins.
 166         https://bugs.webkit.org/show_bug.cgi?id=92281
 167
 168         Reviewed by Adam Barth.
 169
 170         Update TestWebPlugin to receive events, and output logs for the events.
 171
 172         * DumpRenderTree/chromium/TestWebPlugin.cpp:
 173         (TestWebPlugin::handleInputEvent):
 174         * DumpRenderTree/chromium/TestWebPlugin.h:
 175         (TestWebPlugin::acceptsInputEvents):
 176         (TestWebPlugin):
 177
 178 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
 179
 180         [nrwt] get rid of --skip-pixel-test-if-no-baseline
 181         https://bugs.webkit.org/show_bug.cgi?id=92377
 182
 183         Reviewed by Adam Barth.
 184
 185         Remove the option and all code paths that handled it.
 186
 187         * Scripts/webkitpy/layout_tests/port/base.py:
 188         (Port.should_run_as_pixel_test):
 189         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 190         (_set_up_derived_options):
 191         (parse_args):
 192         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 193         (MainTest.test_repeat_each):
 194
 195 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
 196
 197         Add FastMalloc statistics in window.internals
 198         https://bugs.webkit.org/show_bug.cgi?id=91274
 199
 200         Reviewed by Ryosuke Niwa.
 201
 202         * GNUmakefile.am:
 203
 204 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
 205
 206         Add FastMalloc statistics in window.internals
 207         https://bugs.webkit.org/show_bug.cgi?id=91274
 208
 209         Reviewed by Ryosuke Niwa.
 210
 211         * GNUmakefile.am:
 212
 213 2012-07-20  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
 214
 215         buildbot: Remove the configuration of hfreyther*
 216         https://bugs.webkit.org/show_bug.cgi?id=91849
 217
 218         Reviewed by Adam Roben.
 219
 220         The machine running these configs was decommissioned and
 221         there is no replacement at this point. Remove them from the
 222         configuration.
 223
 224         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from
 225         the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
 226         them too.
 227
 228 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
 229
 230         Unreviewed speculative Mac buildfix after r123729 - 2nd attempt.
 231
 232         * WebKitTestRunner/TestController.cpp:
 233         (WTR::TestController::runTest):
 234
 235 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
 236
 237         Unreviewed speculative buildfix after r123729.
 238
 239         * WebKitTestRunner/TestController.cpp:
 240         (WTR::TestController::runTest): Fix sign errors.
 241
 242 2012-07-26  Zoltan Nyul  <zoltan.nyul@intel.com>
 243
 244         [EFL] EFL port should use XDG paths
 245         https://bugs.webkit.org/show_bug.cgi?id=91719
 246
 247         Reviewed by Kenneth Rohde Christiansen.
 248
 249         The appcache/localstorage/webdatabase path should be set in the
 250         ewk_main.cpp instead of the DumpRenderTree, and the XDG_DATA_HOME and
 251         XDG_CACHE_HOME should be set to different directory for each processes
 252         for the layout-tests.
 253
 254         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 255         (DumpRenderTreeChrome::initialize):
 256         * Scripts/webkitpy/layout_tests/port/efl.py:
 257         (EflPort.setup_environ_for_server):
 258         * efl/jhbuild.modules:
 259
 260 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
 261
 262         [NRWT] should have a way to restrict pixel tests for individual directories
 263         https://bugs.webkit.org/show_bug.cgi?id=91754
 264
 265         Reviewed by Dirk Pranke.
 266
 267         Added --pixel-test-directories option to nrwt. It implies --pixel-tests.
 268         If the platform supports this option only tests from these directories will
 269         be executed as pixel tests. Furthermore, platforms can have a default set of
 270         pixel test directories. To support the feature the test harness have to be
 271         able to inform the driver whether to dump pixels for each tests. For this
 272         purpose I changed WTR and the Qt DRT to handle a --pixel-test argument from
 273         the standard output and made NRWT use this argument with these drivers.
 274
 275         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 276         (WebCore::DumpRenderTree::DumpRenderTree):
 277         (WebCore::DumpRenderTree::open):
 278         (WebCore::DumpRenderTree::processLine):
 279         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
 280         (WebCore::DumpRenderTree::dump):
 281         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 282         (DumpRenderTree):
 283         * DumpRenderTree/qt/main.cpp:
 284         (main):
 285         Handle the --pixel-test argument.
 286
 287         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
 288         (SingleTestRunner._should_fetch_expected_checksum):
 289         (SingleTestRunner._overwrite_baselines):
 290         (SingleTestRunner._compare_output):
 291         * Scripts/webkitpy/layout_tests/controllers/worker.py:
 292         (Worker._update_test_input):
 293         * Scripts/webkitpy/layout_tests/port/base.py:
 294         (Port.supports_switching_pixel_tests_per_test): Ports can override this to inform
 295         the harness that --pixel-test argument is supported. True for WTR, otherwise calls
 296         private version that can be overridden by the actual platform. Only true with WTR
 297         and Qt DRT currently. This supposed to exist only temporary until there are ports
 298         that doesn't support the feature in their DRT's.
 299         (Port):
 300         (Port._supports_switching_pixel_tests_per_test):
 301         (Port.should_run_as_pixel_test):
 302         (Port._should_run_as_pixel_test): Ports can override this to define their
 303         default set of pixel tests directories.
 304         * Scripts/webkitpy/layout_tests/port/driver.py:
 305         (Driver.cmd_line): Don't pass --pixel-tests if the platform supports per test
 306         --pixel-test.
 307         (Driver._command_from_driver_input): Pass --pixel-test if it is supported and pixel
 308         tests are enabled.
 309         * Scripts/webkitpy/layout_tests/port/qt.py:
 310         (QtPort.check_sys_deps):
 311         (QtPort):
 312         (QtPort._supports_switching_pixel_tests_per_test):
 313         (QtPort._should_run_as_pixel_test):
 314         (QtPort._default_pixel_test_directories): Only compositing will be our default pixel
 315         test directory for the time being.
 316         * Scripts/webkitpy/layout_tests/port/test.py:
 317         (TestPort.supports_switching_pixel_tests_per_test):
 318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 319         (_set_up_derived_options):
 320         (parse_args):
 321         Handle the --pixel-test-directory option. It expect a directory below LayoutTests
 322         and can be specified multiple times. Added fixme's that we should improve how we
 323         handle these arguments.
 324
 325         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 326         (MainTest.test_run_singly_actually_runs_tests):
 327         (MainTest.test_pixel_test_directories):
 328         Added an integration test for the feature.
 329
 330         * WebKitTestRunner/TestController.cpp:
 331         (WTR::TestController::TestController):
 332         (WTR::TestController::initialize):
 333         (WTR::TestController::runTest):
 334         * WebKitTestRunner/TestController.h:
 335         (TestController):
 336         Handle the --pixel-test argument.
 337
 338 2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
 339
 340         [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
 341         https://bugs.webkit.org/show_bug.cgi?id=92349
 342
 343         Reviewed by Kentaro Hara.
 344
 345         Fix crash occurring after r123604, which replaced strdup()
 346         usage with eina_stringshare_add(). Unfortunately, the DRT
 347         was not updated accordingly to use eina_stringshare_del()
 348         instead of free() on the values returned by Ewk_Intent
 349         getters and it was causing
 350         webintents/web-intents-obj-constructor.html to crash.
 351
 352         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 353         (DumpRenderTreeChrome::onFrameIntentNew):
 354
 355 2012-07-26  Adam Barth  <abarth@webkit.org>
 356
 357         Unreviewed attempt to fix the chromium-win build.
 358
 359         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp:
 360
 361 2012-07-26  Kaustubh Atrawalkar  <kaustubh@motorola.com>
 362
 363         [DRT] LTC:: pageNumberForElementById() could be moved to Internals
 364         https://bugs.webkit.org/show_bug.cgi?id=92091
 365
 366         Reviewed by Adam Barth.
 367
 368         Move the pageNumberForElementById from LayoutTestCotroller to Internals and
 369         remove the old platform specific implementations as it exclusively tests WebCore functionality.
 370
 371         * DumpRenderTree/LayoutTestController.cpp:
 372         (LayoutTestController::staticFunctions):
 373         * DumpRenderTree/LayoutTestController.h:
 374         (LayoutTestController):
 375         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
 376         * DumpRenderTree/chromium/LayoutTestController.cpp:
 377         (LayoutTestController::LayoutTestController):
 378         (LayoutTestController::setPrinting):
 379         * DumpRenderTree/chromium/LayoutTestController.h:
 380         (LayoutTestController):
 381         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 382         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 383         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 384         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 385         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 386         (LayoutTestController):
 387         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 388         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 389         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 390         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 391         (WTR):
 392         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 393         (LayoutTestController):
 394
 395 2012-07-25  Adam Barth  <abarth@webkit.org>
 396
 397         TestRunner.a should contain a TestRunner object
 398         https://bugs.webkit.org/show_bug.cgi?id=92313
 399
 400         Reviewed by Kent Tamura.
 401
 402         This patch adds a stub implementation of TestRunner, which is the new
 403         home for our implementation of window.testRunner. A future patch will
 404         migrate functions from LayoutTestController to TestRunner.
 405
 406         * DumpRenderTree/DumpRenderTree.gypi:
 407         * DumpRenderTree/chromium/LayoutTestController.h:
 408         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
 409         * DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.
 410
 411 2012-07-25  Wei James  <james.wei@intel.com>
 412
 413         [Chromium] Fix infinite loop issue for chromium android layout test
 414         https://bugs.webkit.org/show_bug.cgi?id=92197
 415
 416         Reviewed by Adam Barth.
 417
 418         The change brought in by r123530 will cause infinite loop when running
 419         Chromium Android Layout Test.
 420         Revert the change for this line only.
 421
 422         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 423         (ChromiumAndroidPort._build_path):
 424
 425 2012-07-25  Adam Barth  <abarth@webkit.org>
 426
 427         Jochen is our a newest reviewer!
 428
 429         * Scripts/webkitpy/common/config/committers.py:
 430
 431 2012-07-25  Jochen Eisinger  <jochen@chromium.org>
 432
 433         [chromium] don't use webkit_support methods directly from test runners but through the test delegate
 434         https://bugs.webkit.org/show_bug.cgi?id=92256
 435
 436         Reviewed by Adam Barth.
 437
 438         This will allow for the content_shell to provide its own implementation
 439         for setting the Gamepad data instead.
 440
 441         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp:
 442         (GamepadController::setDelegate):
 443         (GamepadController::reset):
 444         (GamepadController::connect):
 445         (GamepadController::disconnect):
 446         (GamepadController::setId):
 447         (GamepadController::setButtonCount):
 448         (GamepadController::setButtonData):
 449         (GamepadController::setAxisCount):
 450         (GamepadController::setAxisData):
 451         * DumpRenderTree/chromium/TestRunner/GamepadController.h:
 452         (GamepadController):
 453         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
 454         (WebKit):
 455         (TestDelegate):
 456         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
 457         (TestInterfaces::Internal):
 458         (TestInterfaces::Internal::~Internal):
 459         (TestInterfaces::Internal::setDelegate):
 460         (TestInterfaces::setDelegate):
 461         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
 462         (TestInterfaces):
 463         * DumpRenderTree/chromium/TestShell.cpp:
 464         (TestShell::createMainWindow):
 465         (TestShell::~TestShell):
 466         * DumpRenderTree/chromium/WebViewHost.cpp:
 467         (WebViewHost::setGamepadData):
 468         * DumpRenderTree/chromium/WebViewHost.h:
 469         (WebViewHost):
 470
 471 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
 472
 473         [WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented
 474         https://bugs.webkit.org/show_bug.cgi?id=92227
 475
 476         Reviewed by Kenneth Rohde Christiansen.
 477
 478         Implement LayoutTestController.sendWebIntentResponse() so
 479         that a test case can reply to a Web intent request and
 480         test this functionality.
 481
 482         In order to support this functionality, we need to keep
 483         a pointer to the current intent request in
 484         InjectedBundlePage::didReceiveIntentForFrame() so that
 485         we can reuse it later in
 486         LayoutTestController::sendWebIntentResponse().
 487
 488         The following tests need this functionality:
 489         - webintents/web-intents-failure.html
 490         - webintents/web-intents-reply.html
 491
 492         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 493         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 494         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
 495         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 496         (InjectedBundlePage):
 497         (WTR::InjectedBundlePage::currentIntentRequest):
 498         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 499         (WTR::LayoutTestController::sendWebIntentResponse):
 500         (WTR):
 501         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 502         (LayoutTestController):
 503
 504 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 505
 506         [EFL][WK2][WTR] Alt, Shift and Ctrl keys are not handled by EventSenderProxy.
 507         https://bugs.webkit.org/show_bug.cgi?id=92241
 508
 509         Reviewed by Kenneth Rohde Christiansen.
 510
 511         Alt, Shift and Ctrl keys were not handled by EventSenderProxy.
 512         It caused failure of fast/events/keydown-leftright-keys.html test.
 513
 514         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added handling of Alt, Shift and Ctrl keys.
 515         (WTR::keyName):
 516
 517 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
 518
 519         [EFL][WK2] Fix timeout issues when debugging WebProcess.
 520         https://bugs.webkit.org/show_bug.cgi?id=92245
 521
 522         Reviewed by Dirk Pranke.
 523
 524         Fix timeout issues when debugging the WebProcess
 525         under valgrind or gdb.
 526
 527         * Scripts/webkitpy/layout_tests/port/efl.py:
 528         (EflPort.default_timeout_ms):
 529         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 530         (WTR::TestController::platformInitialize):
 531
 532 2012-07-25  Xianzhu Wang  <wangxianzhu@chromium.org>
 533
 534         [Chromium-Android] NRWT driver should not restart between reftests
 535         https://bugs.webkit.org/show_bug.cgi?id=92267
 536
 537         Reviewed by Dirk Pranke.
 538
 539         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 540         (ChromiumAndroidDriver.start): Resets self._pixel_tests when the pixel_tests parameter changes.
 541
 542 2012-07-25  Tommy Widenflycht  <tommyw@google.com>
 543
 544         MediaStream API: Update MediaStreamTrack to match the specification
 545         https://bugs.webkit.org/show_bug.cgi?id=90180
 546
 547         Reviewed by Adam Barth.
 548
 549         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
 550
 551         * DumpRenderTree/DumpRenderTree.gypi:
 552         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
 553         (MockWebKitPlatformSupport::createMediaStreamCenter):
 554         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
 555         (WebKit):
 556         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
 557         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
 558         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
 559         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
 560         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
 561         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
 562         (WebKit::MockWebMediaStreamCenter::constructSDP):
 563         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
 564         (WebKit):
 565         (MockWebMediaStreamCenter):
 566         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
 567
 568 2012-07-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
 569
 570         [NRWT] Rename baseline_search_path() to default_baseline_search_path()
 571         https://bugs.webkit.org/show_bug.cgi?id=92122
 572
 573         Reviewed by Dirk Pranke.
 574
 575         * Scripts/webkitpy/layout_tests/port/base.py:
 576         (Port.baseline_version_dir):
 577         (Port.baseline_search_path):
 578         (Port):
 579         (Port.default_baseline_search_path):
 580         (Port.expected_baselines):
 581         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 582         (PortTest.test_additional_platform_directory):
 583         * Scripts/webkitpy/layout_tests/port/mac.py:
 584         (MacPort.default_baseline_search_path):
 585         * Scripts/webkitpy/layout_tests/port/qt.py:
 586         (QtPort.default_baseline_search_path):
 587         * Scripts/webkitpy/layout_tests/port/win.py:
 588         (WinPort.default_baseline_search_path):
 589
 590 2012-07-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 591
 592         [EFL] Use eina_stringshare_add instead of strdup.
 593         https://bugs.webkit.org/show_bug.cgi?id=92072
 594
 595         Reviewed by Kentaro Hara.
 596
 597         Eina of EFL libraries supports a string functionality that replaces strdup. So, EFL port needs
 598         to replace strdup with eina_stringshare_add function.
 599
 600         DumpRenderTree also needs to be modified according to ewk APIs's parameter change.
 601
 602         * DumpRenderTree/efl/DumpRenderTree.cpp:
 603         (dumpFramesAsText):
 604         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 605         (DumpRenderTreeChrome::onFrameIntentNew):
 606         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
 607         (onJavaScriptPrompt):
 608
 609 2012-07-25  Alexander Shalamov  <alexander.shalamov@intel.com>
 610
 611         [WTR][EFL] Wheel events are not emitted
 612         https://bugs.webkit.org/show_bug.cgi?id=92094
 613
 614         Reviewed by Csaba Osztrogonác.
 615
 616         Wheel events are not emitted, therefore, layout tests that use mouseScrollBy method are failing.
 617
 618         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
 619         (WTR::dispatchMouseScrollByEvent):
 620         (WTR::EventSenderProxy::mouseScrollBy):
 621         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
 622         (WTR::PlatformWebView::PlatformWebView):
 623         (WTR::PlatformWebView::focus):
 624
 625 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 626
 627         [EFL][WK2] Add ewk_main.{cpp,h} to EFL WK2
 628         https://bugs.webkit.org/show_bug.cgi?id=92101
 629
 630         Reviewed by Kenneth Rohde Christiansen.
 631
 632         Added a centralized place for general initialization in UI process for EFL WK2.
 633
 634         * MiniBrowser/efl/main.c: Added using of newly added ewk_init() and ewk_shutdown() functions.
 635         (main):
 636         * WebKitTestRunner/efl/main.cpp: Ditto.
 637         (main):
 638
 639 2012-07-24  Benjamin Poulain  <bpoulain@apple.com> && Joseph Pecoraro  <pecoraro@apple.com>
 640
 641         QualifiedName's HashSet should be big enough to hold at least all the static names
 642         https://bugs.webkit.org/show_bug.cgi?id=91891
 643
 644         Reviewed by Darin Adler.
 645
 646         Add a test for WTF::hashTableCapacityForSize.
 647
 648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 649         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added.
 650         (InitialCapacityTestHashTraits):
 651         (TestWebKitAPI::testInitialCapacity):
 652         (TestWebKitAPI::generateTestCapacityUpToSize):
 653         (TestWebKitAPI::TEST):
 654
 655 2012-07-24  Adam Barth  <abarth@webkit.org>
 656
 657         The EWS bots get flaky when we hit the failure limit
 658         https://bugs.webkit.org/show_bug.cgi?id=92212
 659
 660         Reviewed by Eric Seidel.
 661
 662         Previously we were missing some failure types, which means we didn't
 663         notice that the bots were hitting the failure limit.
 664
 665         * Scripts/webkitpy/common/net/layouttestresults.py:
 666         (LayoutTestResults.failing_test_results):
 667         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
 668         (LayoutTestResultsTest.test_results_from_string):
 669         (LayoutTestResultsTest.test_tests_matching_failure_types):
 670
 671 2012-07-24  Raphael Kubo da Costa  <rakuco@webkit.org>
 672
 673         [EFL] Unreviewed build fix.
 674
 675         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h
 676         for usleep(3).
 677
 678 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
 679
 680         make test-webkitpy at least kinda work in parallel on win32
 681         https://bugs.webkit.org/show_bug.cgi?id=91700
 682
 683         Reviewed by Adam Barth.
 684
 685         This change makes the hoop-jumping we have to do to make running
 686         new-run-webkit-tests in parallel on win32 generic so that we can
 687         re-use it for test-webkitpy as well.
 688
 689         * Scripts/new-run-webkit-tests:
 690         * Scripts/test-webkitpy:
 691         * Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.
 692         (run):
 693         * Scripts/webkitpy/test/main.py:
 694         (main):
 695         (Tester._log_exception):
 696
 697 2012-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
 698
 699         Unreviewed, rolling out r123499.
 700         http://trac.webkit.org/changeset/123499
 701         https://bugs.webkit.org/show_bug.cgi?id=92161
 702
 703         Android fails to compile (Requested by zhenyao on #webkit).
 704
 705         * DumpRenderTree/DumpRenderTree.gypi:
 706         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
 707         (MockWebKitPlatformSupport::createMediaStreamCenter):
 708         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
 709         (MockWebKitPlatformSupport):
 710         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
 711         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.
 712
 713 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
 714
 715         nrwt: never finds binaries in the 'out' dir on chromium win
 716         https://bugs.webkit.org/show_bug.cgi?id=91890
 717
 718         Reviewed by Tony Chang.
 719
 720         Attempt to fix this bug yet again; it turns out that --root and
 721         --build-directory don't have the same meaning (--root should
 722         include the configuration, --build-directory should not).
 723
 724         * Scripts/webkitpy/layout_tests/port/base.py:
 725         (Port._build_path):
 726         * Scripts/webkitpy/layout_tests/port/chromium.py:
 727         (ChromiumPort._static_build_path):
 728         (ChromiumPort.default_results_directory):
 729         (ChromiumPort._build_path):
 730         (ChromiumPort):
 731         (ChromiumPort._build_path_with_configuration):
 732         (ChromiumPort._build_path_with_configuration.does):
 733         (ChromiumPort._path_to_image_diff):
 734         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 735         (ChromiumAndroidPort._build_path):
 736         (ChromiumAndroidPort):
 737         (ChromiumAndroidPort._build_path_with_configuration):
 738         (ChromiumAndroidPort._path_to_driver):
 739         (ChromiumAndroidPort._path_to_forwarder):
 740         (ChromiumAndroidPort._push_executable):
 741         (ChromiumAndroidPort._push_fonts):
 742         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 743         (ChromiumLinuxPort._determine_driver_path_statically):
 744         (ChromiumLinuxPort._modules_to_search_for_symbols):
 745         (ChromiumLinuxPort._path_to_driver):
 746         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
 747         (ChromiumLinuxPortTest.test_build_path):
 748         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 749         (ChromiumMacPort._modules_to_search_for_symbols):
 750         (ChromiumMacPort._path_to_driver):
 751         (ChromiumMacPort._path_to_helper):
 752         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
 753         (ChromiumMacPortTest.test_build_path):
 754         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 755         (ChromiumWinPort._path_to_driver):
 756         (ChromiumWinPort._path_to_helper):
 757         (ChromiumWinPort._path_to_image_diff):
 758         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
 759         (ChromiumWinTest.test_build_path):
 760         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 761         (parse_args):
 762
 763 2012-07-24  Peter Beverloo  <peter@chromium.org>
 764
 765         Android-chromium layout tests failing with GPU related crash
 766         https://bugs.webkit.org/show_bug.cgi?id=92126
 767
 768         Reviewed by Adam Barth.
 769
 770         Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
 771         as it's not being used by any port anymore, and neither is being passed
 772         on to the test runner. Instead, append the flag directly to DRT for the
 773         Chromium Android port, which does rely on this functionality.
 774
 775         The ChromiumAndroidUnitTest tests didn't catch this as the property was
 776         set to True, but it's unable to detect whether they'll actually be used.
 777         No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
 778         or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
 779
 780         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 781         (ChromiumAndroidPort.__init__):
 782         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
 783         (ChromiumAndroidPortTest.test_attributes):
 784         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 785         (parse_args):
 786
 787 2012-07-24  Alexander Shalamov  <alexander.shalamov@intel.com>
 788
 789         [WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
 790         https://bugs.webkit.org/show_bug.cgi?id=92107
 791
 792         Reviewed by Kenneth Rohde Christiansen.
 793
 794         Fixes mouse click events in EventSenderProxyEfl.
 795
 796         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
 797         (WTR::dispatchMouseDownEvent):
 798         (WTR::EventSenderProxy::dispatchEvent):
 799
 800 2012-07-24  Tommy Widenflycht  <tommyw@google.com>
 801
 802         MediaStream API: Update MediaStreamTrack to match the specification
 803         https://bugs.webkit.org/show_bug.cgi?id=90180
 804
 805         Reviewed by Adam Barth.
 806
 807         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
 808
 809         * DumpRenderTree/DumpRenderTree.gypi:
 810         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
 811         (MockWebKitPlatformSupport::createMediaStreamCenter):
 812         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
 813         (WebKit):
 814         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
 815         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
 816         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
 817         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
 818         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
 819         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
 820         (WebKit::MockWebMediaStreamCenter::constructSDP):
 821         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
 822         (WebKit):
 823         (MockWebMediaStreamCenter):
 824         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
 825
 826 2012-07-23  Ryosuke Niwa  <rniwa@webkit.org>
 827
 828         Fix regressions in replay performance tests
 829         https://bugs.webkit.org/show_bug.cgi?id=92052
 830
 831         Reviewed by Dirk Pranke.
 832
 833         Fix regression that accumulated over time to make replay tests work again.
 834
 835         * DumpRenderTree/chromium/WebViewHost.cpp:
 836         (WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
 837         URL hadn't been updated yet When requesting a new URL on the main frame.
 838         * Scripts/webkitpy/performance_tests/perftest.py:
 839         (ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
 840         (ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
 841         (ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.
 842         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
 843         (TestReplayPerfTest.test_run_single):
 844         (TestReplayPerfTest.test_prepare):
 845         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
 846         (TestReplayPerfTest):
 847
 848 2012-07-24  Simon Hausmann  <simon.hausmann@nokia.com>
 849
 850         [Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
 851         https://bugs.webkit.org/show_bug.cgi?id=91229
 852
 853         Reviewed by Jocelyn Turcotte.
 854
 855         In order to successfully link a DLL on Windows we need to have at least
 856         one object file (or compilation unit). The forward export header files were
 857         supposed to be that, but unfortunately the rule in win32/default_post.prf for
 858         creating the header files had some bugs, among others that it did an exists()
 859         check on the depending static library. At the time qmake is ran those libraries
 860         do not exist yet and therefore the corresponding extra compiler rules were never
 861         created, resulting in empty OBJECTS/SOURCES.
 862
 863         Even without such an exists() check, qmake extra compilers require the files
 864         referred to in the .input variable to exist at qmake time. In this case the input
 865         files were the static libraries, which do not exist yet.
 866
 867         This patch solves this by using a qmake extra target instead of extra
 868         compiler, which does not have this limitation. The target is referenced
 869         through the extension of GENERATED_SOURCES.
 870
 871         The patch also adds a d/_debug suffix for debug builds, do allow for separate
 872         symbol exports if necessary.
 873
 874         * Scripts/generate-win32-export-forwards: Support multiple input files, i.e.
 875         consider the last argument to be the output file and everything else input.
 876         * qmake/mkspecs/features/win32/default_post.prf:
 877
 878 2012-07-24  Balazs Kelemen  <kbalazs@webkit.org>
 879
 880         [Qt] Add quirks for running the web process in a profiler shell, like valgrind
 881         https://bugs.webkit.org/show_bug.cgi?id=87672
 882
 883         Reviewed by Jocelyn Turcotte.
 884
 885         Add --no-timeout-at-all command line switch to not time out no matter how
 886         long the web process does it's job. --no-timeout is not enough for profiling
 887         purposes because it only affects the timeout when we are waiting for the end
 888         of the test. We use another timeout to control how much we wait for the web
 889         process to initialize before and reset after the test and it could also easily
 890         expire when running under valgrind. We should keep the behavior of --no-timeout
 891         to not disable this timout check because --no-timeout is used by performace tests
 892         and those should not wait for the web process to initialize and reset more than
 893         normal tests.
 894
 895         * WebKitTestRunner/TestController.cpp:
 896         (WTR::TestController::TestController):
 897         (WTR::TestController::initialize):
 898         (WTR::TestController::runUntil):
 899         * WebKitTestRunner/TestController.h:
 900
 901 2012-07-24  Peter Beverloo  <peter@chromium.org>
 902
 903         [Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
 904         https://bugs.webkit.org/show_bug.cgi?id=92097
 905
 906         Unreviewed build fix.
 907
 908         WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
 909         but TestDelegate.h forward declares it as a class.
 910
 911         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
 912         (WebKit):
 913
 914 2012-07-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
 915
 916         [Qt] Fix compilation against namespaced Qt
 917
 918         Reviewed by Simon Hausmann.
 919
 920         * QtTestBrowser/launcherwindow.h:
 921         * WebKitTestRunner/PlatformWebView.h:
 922
 923 2012-07-24  Peter Beverloo  <peter@chromium.org>
 924
 925         Update a few Chromium Android contributors in committers.py
 926         https://bugs.webkit.org/show_bug.cgi?id=92090
 927
 928         Reviewed by Kent Tamura.
 929
 930         Add Sami Kyostila, who has been doing significant work on Chromium's
 931         compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
 932         remove John Grabowski who changed projects, and add my webkit.org alias.
 933
 934         * Scripts/webkitpy/common/config/committers.py:
 935
 936 2012-07-24  Pierre Rossi  <pierre.rossi@gmail.com>
 937
 938         [Qt] Enable touch slider when touch events are enabled
 939         https://bugs.webkit.org/show_bug.cgi?id=91013
 940
 941         Reviewed by Kenneth Rohde Christiansen.
 942
 943         TOUCH_SLIDER guards are used in WebCore, so we should really
 944         be setting the corresponding ENABLE define in features.prf.
 945
 946         * qmake/mkspecs/features/features.prf:
 947
 948 2012-07-24  Ryuan Choi  <ryuan.choi@samsung.com>
 949
 950         [EFL] EWebLauncher should not require config.h in the style check
 951         https://bugs.webkit.org/show_bug.cgi?id=92070
 952
 953         Reviewed by Kentaro Hara.
 954
 955         * Scripts/webkitpy/style/checker.py:
 956         Remove the include rules from the style-check for EWebLauncher because
 957         EWebLauncher is simple EFL application.
 958
 959 2012-07-24  Jochen Eisinger  <jochen@chromium.or>
 960
 961         [Chromium] EventSender shouldn't know about TestShell
 962         https://bugs.webkit.org/show_bug.cgi?id=91449
 963
 964         Reviewed by Adam Barth.
 965
 966         Original patch by Adam Barth.
 967
 968         This patch removes the dependency from EventSender to TestShell.  Most
 969         of EventSender works directly with a WebView, but there are a handful
 970         of references to WebViewHost.  We don't want to re-use WebViewHost in
 971         ContentShell because we want to use the multi-process embedding
 972         environment for WebViews.
 973
 974         To avoid the dependency on WebViewHost, this patch introduces
 975         TestDelegate, which is an abstract base class for WebViewHost.  In
 976         ContentShell, we'll need another object to implement these functions.
 977
 978         * DumpRenderTree/chromium/EventSender.cpp:
 979         (EventSender::EventSender):
 980         (EventSender::keyDown):
 981         (makeMenuItemStringsFor):
 982         (EventSender::contextClick):
 983         * DumpRenderTree/chromium/EventSender.h:
 984         (EventSender):
 985         (EventSender::setDelegate):
 986         (EventSender::setWebView):
 987         (EventSender::webview):
 988         * DumpRenderTree/chromium/TestRunner/TestDelegate.h: Added.
 989         (WebKit):
 990         (TestDelegate):
 991         * DumpRenderTree/chromium/TestShell.cpp:
 992         (TestShell::initialize):
 993         (TestShell::createMainWindow):
 994         (TestShell::~TestShell):
 995         * DumpRenderTree/chromium/WebViewHost.cpp:
 996         (WebViewHost::fillSpellingSuggestionList):
 997         * DumpRenderTree/chromium/WebViewHost.h:
 998         (WebViewHost):
 999
1000 2012-07-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1001
1002         Make WebIntents and WebIntentsTag a build option for the build-webkit script
1003         https://bugs.webkit.org/show_bug.cgi?id=91841
1004
1005         Reviewed by Philippe Normand.
1006
1007         And it will also be disabled when building with --minimal.
1008
1009         * Scripts/webkitperl/FeatureList.pm:
1010
1011 2012-07-23  Dirk Pranke  <dpranke@chromium.org>
1012
1013         Unreviewed, rolling out r123360.
1014         http://trac.webkit.org/changeset/123360
1015         https://bugs.webkit.org/show_bug.cgi?id=91890
1016
1017         broke the chromium bots
1018
1019         * Scripts/webkitpy/layout_tests/port/chromium.py:
1020         (ChromiumPort._static_build_path):
1021         (ChromiumPort.default_results_directory):
1022         (ChromiumPort._build_path):
1023         (ChromiumPort._path_to_image_diff):
1024         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1025         (ChromiumAndroidPort._build_path):
1026         (ChromiumAndroidPort._path_to_driver):
1027         (ChromiumAndroidPort._path_to_forwarder):
1028         (ChromiumAndroidPort._push_executable):
1029         (ChromiumAndroidPort._push_fonts):
1030         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1031         (ChromiumLinuxPort._determine_driver_path_statically):
1032         (ChromiumLinuxPort._modules_to_search_for_symbols):
1033         (ChromiumLinuxPort._path_to_driver):
1034         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1035         (ChromiumLinuxPortTest.test_build_path):
1036         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1037         (ChromiumMacPort._modules_to_search_for_symbols):
1038         (ChromiumMacPort._path_to_driver):
1039         (ChromiumMacPort._path_to_helper):
1040         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1041         (ChromiumMacPortTest.test_build_path):
1042         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1043         (ChromiumWinPort._path_to_driver):
1044         (ChromiumWinPort._path_to_helper):
1045         (ChromiumWinPort._path_to_image_diff):
1046         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1047         (ChromiumWinTest.test_build_path):
1048
1049 2012-07-23  Adam Barth  <abarth@webkit.org>
1050
1051         [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
1052         https://bugs.webkit.org/show_bug.cgi?id=91459
1053
1054         Reviewed by Ryosuke Niwa.
1055
1056         Rather than having TestShell own and bind each of these JavaScript APIs
1057         individually, TestShell should delegate that work to TestInterfaces.
1058         This patch moves AccessibilityController and TextInputController to be
1059         the responsibility of TestInterfaces.
1060
1061         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
1062         (TestInterfaces::TestInterfaces):
1063         (TestInterfaces::~TestInterfaces):
1064         (TestInterfaces::setWebView):
1065         (TestInterfaces::bindTo):
1066         (TestInterfaces::resetAll):
1067         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
1068         (WebKit):
1069         (TestInterfaces):
1070         (TestInterfaces::accessibilityController):
1071         * DumpRenderTree/chromium/TestShell.cpp:
1072         (TestShell::initialize):
1073         (TestShell::createMainWindow):
1074         (TestShell::~TestShell):
1075         (TestShell::resetTestController):
1076         (TestShell::bindJSObjectsToWindow):
1077         * DumpRenderTree/chromium/TestShell.h:
1078         (TestShell::accessibilityController):
1079         (TestShell):
1080
1081 2012-07-23  Balazs Kelemen  <kbalazs@webkit.org>
1082
1083         nrwt swallows early exceptions
1084         https://bugs.webkit.org/show_bug.cgi?id=91884
1085
1086         Reviewed by Dirk Pranke.
1087
1088         Put everything in a try block so we won't miss any error.
1089
1090         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1091         (run):
1092         (main):
1093
1094 2012-07-23  Christophe Dumez  <christophe.dumez@intel.com>
1095
1096         [WK2] WebKitTestRunner needs to print information about Web intents
1097         https://bugs.webkit.org/show_bug.cgi?id=90873
1098
1099         Reviewed by Anders Carlsson.
1100
1101         Print out information about new intents requests and intent
1102         services registrations in WebKitTestRunner. This is expected
1103         by tests under webintents/*.
1104
1105         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1106         (WTR::InjectedBundlePage::InjectedBundlePage):
1107         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1108         (WTR):
1109         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1110         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1111         (InjectedBundlePage):
1112
1113 2012-07-23  Dirk Pranke  <dpranke@chromium.org>
1114
1115         nrwt: never finds binaries in the 'out' dir on chromium win
1116         https://bugs.webkit.org/show_bug.cgi?id=91890
1117
1118         Reviewed by Tony Chang.
1119
1120         We were figuring out which directory look in for binaries by
1121         testing for the base directory (the directory above
1122         Debug/Release). In chromium-win's case, we look in src/build,
1123         which always exists because there are checked-in files in it,
1124         which means we'd always pick that directory over src/out. All of
1125         the other ports' build_path() implementation was including
1126         Debug/Release. If we matched that, we wouldn't have a problem,
1127         so this change fixes that and updates all of the callers of the
1128         chromium ports' implementation to not pass configuration as part
1129         of the path to look up; we still need to pass configuration in
1130         some cases (to test if the build is out of date between debug
1131         and release) so the implementation gets slightly more
1132         complicated.
1133
1134         * Scripts/webkitpy/layout_tests/port/chromium.py:
1135         (ChromiumPort._static_build_path):
1136         (ChromiumPort.default_results_directory):
1137         (ChromiumPort._build_path):
1138         (ChromiumPort._path_to_image_diff):
1139         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1140         (ChromiumAndroidPort._build_path):
1141         (ChromiumAndroidPort._path_to_driver):
1142         (ChromiumAndroidPort._path_to_forwarder):
1143         (ChromiumAndroidPort._push_executable):
1144         (ChromiumAndroidPort._push_fonts):
1145         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1146         (ChromiumLinuxPort._determine_driver_path_statically):
1147         (ChromiumLinuxPort._modules_to_search_for_symbols):
1148         (ChromiumLinuxPort._path_to_driver):
1149         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1150         (ChromiumLinuxPortTest.test_build_path):
1151         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1152         (ChromiumMacPort._modules_to_search_for_symbols):
1153         (ChromiumMacPort._path_to_driver):
1154         (ChromiumMacPort._path_to_helper):
1155         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1156         (ChromiumMacPortTest.test_build_path):
1157         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1158         (ChromiumWinPort._path_to_driver):
1159         (ChromiumWinPort._path_to_helper):
1160         (ChromiumWinPort._path_to_image_diff):
1161         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1162         (ChromiumWinTest.test_build_path):
1163
1164 2012-07-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1165
1166         Unreviewed, rolling out r123339.
1167         http://trac.webkit.org/changeset/123339
1168         https://bugs.webkit.org/show_bug.cgi?id=92006
1169
1170         massive media tests failure (Requested by philn on #webkit).
1171
1172         * Scripts/webkitdirs.pm:
1173         (buildAutotoolsProject):
1174         * gtk/jhbuild.modules:
1175
1176 2012-07-23  Tommy Widenflycht  <tommyw@google.com>
1177
1178         [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
1179         https://bugs.webkit.org/show_bug.cgi?id=91857
1180
1181         Reviewed by Adam Barth.
1182
1183         Made a few changes so that the destructor could be called at shutdown.
1184
1185         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1186         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
1187         (WebKitSupportTestEnvironment):
1188         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
1189         (MockWebKitPlatformSupport::create):
1190         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
1191         (MockWebKitPlatformSupport):
1192         (MockWebKitPlatformSupport::~MockWebKitPlatformSupport):
1193
1194 2012-07-23  Philippe Normand  <pnormand@igalia.com>
1195
1196         [GTK][jhbuild] Switch to GStreamer 0.11 build
1197         https://bugs.webkit.org/show_bug.cgi?id=91727
1198
1199         Reviewed by Gustavo Noronha Silva.
1200
1201         Switch build-webkit --gtk to GStreamer 0.11 support and build the
1202         necessary GStreamer git modules from JHBuild.
1203
1204         * Scripts/webkitdirs.pm:
1205         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
1206         * gtk/jhbuild.modules: GStreamer build support.
1207
1208 2012-07-23  Christophe Dumez  <christophe.dumez@intel.com>
1209
1210         WebKit2 needs layoutTestController.setAlwaysAcceptCookies
1211         https://bugs.webkit.org/show_bug.cgi?id=42778
1212
1213         Reviewed by Kenneth Rohde Christiansen.
1214
1215         Add support for layoutTestController.setAlwaysAcceptCookies()
1216         since it is required by some tests.
1217
1218         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1219         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1220         (WTR::LayoutTestController::setAlwaysAcceptCookies):
1221         (WTR):
1222         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1223         (LayoutTestController):
1224
1225 2012-07-23  Kent Tamura  <tkent@chromium.org>
1226
1227         Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
1228         https://bugs.webkit.org/show_bug.cgi?id=91941
1229
1230         Reviewed by Kentaro Hara.
1231
1232         A flag name for an elmement should be ENABLE_*_ELEMENT.
1233
1234         * Scripts/webkitperl/FeatureList.pm:
1235         * qmake/mkspecs/features/features.pri:
1236
1237 2012-07-22  Kent Tamura  <tkent@chromium.org>
1238
1239         Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
1240         https://bugs.webkit.org/show_bug.cgi?id=91928
1241
1242         Reviewed by Kentaro Hara.
1243
1244         A flag name for an elmement should be ENABLE_*_ELEMENT.
1245
1246         * Scripts/webkitperl/FeatureList.pm:
1247         * qmake/mkspecs/features/features.pri:
1248
1249 2012-07-20  Kent Tamura  <tkent@chromium.org>
1250
1251         Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT
1252         https://bugs.webkit.org/show_bug.cgi?id=91846
1253
1254         Reviewed by Kentaro Hara.
1255
1256         A flag name for an elmement should be ENABLE_*_ELEMENT.
1257
1258         * Scripts/webkitperl/FeatureList.pm:
1259         * qmake/mkspecs/features/features.pri:
1260
1261 2012-07-20  Xianzhu Wang  <wangxianzhu@chromium.org>
1262
1263         [Chromium-Android] Store test pipes in /data/local/tmp
1264         https://bugs.webkit.org/show_bug.cgi?id=91909
1265
1266         In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
1267         However after tests we found some devices don't allow the app to create pipes there.
1268         So /data/local/tmp is a better place for the pipes.
1269
1270         Reviewed by Adam Barth.
1271
1272         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1273
1274 2012-07-20  Xianzhu Wang  <wangxianzhu@chromium.org>
1275
1276         [Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
1277         https://bugs.webkit.org/show_bug.cgi?id=91873
1278
1279         Reviewed by Adam Barth.
1280
1281         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1282
1283 2012-07-20  Han Shen  <shenhan@google.com>
1284
1285         [Chromium] Compilation fails under gcc 4.7
1286         https://bugs.webkit.org/show_bug.cgi?id=90227
1287
1288         Reviewed by Tony Chang.
1289
1290         Disable warnings about c++0x compatibility in gcc newer than 4.6.
1291
1292         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1293
1294 2012-07-20  Dirk Pranke  <dpranke@chromium.org>
1295
1296         REGRESSION: run-perf-tests --pause-before-testing is broken
1297         https://bugs.webkit.org/show_bug.cgi?id=91789
1298
1299         Reviewed by Ryosuke Niwa.
1300
1301         Turns out start() wasn't actually starting things :(. Fixed, and
1302         added tests.
1303
1304         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1305         (ChromiumAndroidDriverTest.test_read_prompt):
1306         * Scripts/webkitpy/layout_tests/port/driver.py:
1307         (Driver.__init__):
1308         (Driver._start):
1309         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1310         (DriverTest.test_read_block):
1311         (DriverTest.test_read_binary_block):
1312         (DriverTest.test_read_base64_block):
1313         (DriverTest.test_stop_cleans_up_properly):
1314         (DriverTest.test_two_starts_cleans_up_properly):
1315         (DriverTest.test_start_actually_starts):
1316         (MockServerProcess.__init__):
1317         (MockServerProcess.start):
1318
1319 2012-07-20  Jochen Eisinger  <jochen@chromium.org>
1320
1321         [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
1322         https://bugs.webkit.org/show_bug.cgi?id=91847
1323
1324         Reviewed by Adam Barth.
1325
1326         This allows for including the TestIntefaces.h from content shell
1327         without introducing a dependency to WebCore/wtf
1328
1329         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
1330         (TestInterfaces::Internal):
1331         (TestInterfaces::Internal::Internal):
1332         (TestInterfaces::Internal::~Internal):
1333         (TestInterfaces::Internal::bindTo):
1334         (TestInterfaces::Internal::resetAll):
1335         (TestInterfaces::TestInterfaces):
1336         (TestInterfaces::~TestInterfaces):
1337         (TestInterfaces::bindTo):
1338         (TestInterfaces::resetAll):
1339         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
1340         (TestInterfaces):
1341
1342 2012-07-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1343
1344         [Qt] Make WTR use the same color palette as DRT
1345         https://bugs.webkit.org/show_bug.cgi?id=91870
1346
1347         Reviewed by Noam Rosenthal.
1348
1349         Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
1350         standard from QWindowsStyle.
1351
1352         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1353         (WTR::activateFonts): Moved code to platformInitialize since setting style is not
1354         exactly font related.
1355         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1356         (WTR::InjectedBundle::platformInitialize): Force the usage of the style's
1357         palette.  Because at this point QApplication was already instantiated, the
1358         default palette was already initialized to be the system one, so we need to
1359         explicitly set the palette to be the standard from style. This is not needed in
1360         DRT because there we set the style before instantiating QApplication.
1361
1362 2012-07-20  Tony Chang  <tony@chromium.org>
1363
1364         Baseline align text in the flakiness dashboard toolbar
1365         https://bugs.webkit.org/show_bug.cgi?id=91784
1366
1367         Reviewed by Ojan Vafai.
1368
1369         Baseline align the flex items.
1370
1371         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1372         (.forms): Add box-align: baseline
1373         (.forms > *): Use block display to force flex items rather than box.
1374         (#tests-form): Add box-align: baseline
1375         (#tests-form > *): Use block display to force flex items rather than box.
1376
1377 2012-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1378
1379         Unreviewed, rolling out r123220.
1380         http://trac.webkit.org/changeset/123220
1381         https://bugs.webkit.org/show_bug.cgi?id=91880
1382
1383         broke Debug build (Requested by philn on #webkit).
1384
1385         * Scripts/webkitdirs.pm:
1386         (buildAutotoolsProject):
1387         * gtk/jhbuild.modules:
1388
1389 2012-07-20  Philippe Normand  <pnormand@igalia.com>
1390
1391         [GTK][jhbuild] Switch to GStreamer 0.11 build
1392         https://bugs.webkit.org/show_bug.cgi?id=91727
1393
1394         Reviewed by Gustavo Noronha Silva.
1395
1396         Switch build-webkit --gtk to GStreamer 0.11 support and build the
1397         necessary GStreamer git modules from JHBuild.
1398
1399         * Scripts/webkitdirs.pm:
1400         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
1401         * gtk/jhbuild.modules: GStreamer build support.
1402
1403 2012-07-20  Christophe Dumez  <christophe.dumez@intel.com>
1404
1405         [EFL] Proxy configuration should honor the no_proxy environment variable
1406         https://bugs.webkit.org/show_bug.cgi?id=91747
1407
1408         Reviewed by Kenneth Rohde Christiansen.
1409
1410         Add ProxyResolverSoup to the list of classes that contain GObjects
1411         in style checker script so that it does not complain about naming
1412         convention issues that are mandated by GObject.
1413
1414         * Scripts/webkitpy/style/checker.py:
1415
1416 2012-07-20  Zeno Albisser  <zeno@webkit.org>
1417
1418         [Qt][WK2] Add configure tests for Xrender and GLX.
1419         https://bugs.webkit.org/show_bug.cgi?id=91845
1420
1421         GraphicsSurface on linux requires Xcomposite, Xrender
1422         and GLX. If any of these requirements is not met,
1423         we should disable GraphicsSurface.
1424
1425         Reviewed by Kenneth Rohde Christiansen.
1426
1427         * qmake/config.tests/glx/glx.cpp: Added.
1428         (main):
1429         * qmake/config.tests/glx/glx.pro: Added.
1430         * qmake/config.tests/libXrender/libXrender.cpp: Added.
1431         (main):
1432         * qmake/config.tests/libXrender/libXrender.pro: Added.
1433         * qmake/configure.pri:
1434         * qmake/mkspecs/features/features.prf:
1435
1436 2012-07-20  Kangil Han  <kangil.han@samsung.com>
1437
1438         [EFL][WK2][WTR] Implement EventSenderProxy
1439         https://bugs.webkit.org/show_bug.cgi?id=91731
1440
1441         Reviewed by Kentaro Hara.
1442
1443         This is an initial EFL port implementation of EventSenderProxy.
1444
1445         * WebKitTestRunner/EventSenderProxy.h:
1446         (WTR):
1447         (EventSenderProxy):
1448         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1449         * WebKitTestRunner/PlatformEfl.cmake:
1450         * WebKitTestRunner/TestController.cpp:
1451         (WTR::TestController::TestController):
1452         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1453         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added.
1454         (WTR):
1455         (WTREvent):
1456         (WTR::WTREvent::WTREvent):
1457         (WTR::KeyEventInfo::KeyEventInfo):
1458         (KeyEventInfo):
1459         (WTR::evasMouseButton):
1460         (WTR::setEvasModifiers):
1461         (WTR::dispatchMouseDownEvent):
1462         (WTR::dispatchMouseUpEvent):
1463         (WTR::dispatchMouseMoveEvent):
1464         (WTR::dispatchMouseScrollByEvent):
1465         (WTR::keyPadName):
1466         (WTR::keyName):
1467         (WTR::EventSenderProxy::EventSenderProxy):
1468         (WTR::EventSenderProxy::updateClickCountForButton):
1469         (WTR::EventSenderProxy::dispatchEvent):
1470         (WTR::EventSenderProxy::replaySavedEvents):
1471         (WTR::EventSenderProxy::sendOrQueueEvent):
1472         (WTR::EventSenderProxy::mouseDown):
1473         (WTR::EventSenderProxy::mouseUp):
1474         (WTR::EventSenderProxy::mouseMoveTo):
1475         (WTR::EventSenderProxy::mouseScrollBy):
1476         (WTR::EventSenderProxy::leapForward):
1477         (WTR::EventSenderProxy::keyDown):
1478         (WTR::EventSenderProxy::addTouchPoint):
1479         (WTR::EventSenderProxy::updateTouchPoint):
1480         (WTR::EventSenderProxy::setTouchModifier):
1481         (WTR::EventSenderProxy::touchStart):
1482         (WTR::EventSenderProxy::touchMove):
1483         (WTR::EventSenderProxy::touchEnd):
1484         (WTR::EventSenderProxy::touchCancel):
1485         (WTR::EventSenderProxy::clearTouchPoints):
1486         (WTR::EventSenderProxy::releaseTouchPoint):
1487         (WTR::EventSenderProxy::cancelTouchPoint):
1488         (WTR::EventSenderProxy::setTouchPointRadius):
1489
1490 2012-07-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1491
1492         Unreviewed, rolling out r123085.
1493         http://trac.webkit.org/changeset/123085
1494         https://bugs.webkit.org/show_bug.cgi?id=91719
1495
1496         r123085 causes crashes on EFL layout test bot.
1497
1498         * WebKitTestRunner/CMakeLists.txt:
1499         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
1500         (WTR::LayoutTestController::platformInitialize):
1501
1502 2012-07-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1503
1504         [WTR] Add *explicit* keyword to constructor which has a parameter
1505         https://bugs.webkit.org/show_bug.cgi?id=91745
1506
1507         Reviewed by Adam Barth.
1508
1509         Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
1510
1511         * WebKitTestRunner/EventSenderProxy.h:
1512         (EventSenderProxy):
1513         * WebKitTestRunner/TestInvocation.h:
1514         (TestInvocation):
1515
1516 2012-07-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1517
1518         [EFL] [WK2] Add methods to get/set a custom text encoding
1519         https://bugs.webkit.org/show_bug.cgi?id=90604
1520
1521         Reviewed by Kenneth Rohde Christiansen.
1522
1523         Added support for setting custom character encoding in MiniBrowser.
1524         Use 'F3' to set the custom character encoding.
1525
1526         * MiniBrowser/efl/main.c:
1527         (on_key_down):
1528
1529 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
1530
1531         webkitpy: executive_unittest still failing when run in parallel
1532         https://bugs.webkit.org/show_bug.cgi?id=91795
1533
1534         Reviewed by Adam Barth.
1535
1536         It turns out that test_kill_process and test_kill_all are both
1537         launching the same process, and so if they're run at the same
1538         time, test_kill_all interferes w/ test_kill_process.
1539
1540         Merging the two tests solves the issue :).
1541
1542         * Scripts/webkitpy/common/system/executive_unittest.py:
1543         (ExecutiveTest.test_kill_process):
1544         (ExecutiveTest._assert_windows_image_name):
1545         (ExecutiveTest):
1546         (ExecutiveTest.test_windows_image_name):
1547
1548 2012-07-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1549
1550         [EFL] [WK2] Add a callback to handle delete request in MiniBrowser
1551         https://bugs.webkit.org/show_bug.cgi?id=91483
1552
1553         Reviewed by Dirk Pranke.
1554
1555         Add a callback to handle delete request and quit the main loop when
1556         window is asked to be deleted so that all the resources allocated
1557         for the window will be freed properly.
1558
1559         * MiniBrowser/efl/main.c:
1560         (closeWindow):
1561         (browserCreate):
1562
1563 2012-07-19  No'am Rosenthal  <noam.rosenthal@nokia.com>
1564
1565         [Qt] Enable CSS shaders in Qt (software mode)
1566         https://bugs.webkit.org/show_bug.cgi?id=85140
1567
1568         Reviewed by Simon Hausmann.
1569
1570         Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
1571
1572         * qmake/mkspecs/features/features.prf:
1573
1574 2012-07-19  No'am Rosenthal  <noam.rosenthal@nokia.com>
1575
1576         [Qt] Enable CSS shaders in Qt (software mode)
1577         https://bugs.webkit.org/show_bug.cgi?id=85140
1578
1579         Reviewed by Simon Hausmann.
1580
1581         Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
1582
1583         * qmake/mkspecs/features/features.prf:
1584
1585 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
1586
1587         test-webkitpy: fix executive_unittest nits, including a missing 'errno' import
1588         https://bugs.webkit.org/show_bug.cgi?id=91770
1589
1590         Reviewed by Adam Barth.
1591
1592         The missing errno import is causing a flaky failure when run in
1593         parallel on the bots.
1594
1595         * Scripts/webkitpy/common/system/executive_unittest.py:
1596         (ExecutiveTest.assert_interpreter_for_content):
1597
1598 2012-07-19  Oliver Hunt  <oliver@apple.com>
1599
1600         Make style bot handle underscores in names more reasonably
1601         https://bugs.webkit.org/show_bug.cgi?id=91777
1602
1603         Reviewed by Gavin Barraclough.
1604
1605         This patch adds a naming/readability/underscores category for style errors.
1606         That allows us to use underscores in those portions of JSC (and potentially
1607         gtk?) without turning off all naming checks for the effected directories.
1608         We also filter out the DFG_OPERATION warning, and a few other minor changes
1609         to make the style bot less noisy when running over JSC at least.
1610
1611         * Scripts/webkitpy/style/checker.py:
1612         * Scripts/webkitpy/style/checkers/cpp.py:
1613         (check_identifier_name_in_declaration):
1614         (CppChecker):
1615         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1616         (WebKitStyleTest.test_names):
1617
1618 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
1619
1620         config_standalone.py is crashing on apple win's cygwin port
1621         https://bugs.webkit.org/show_bug.cgi?id=91682
1622
1623         Reviewed by Adam Roben.
1624
1625         Work around a weird interaction of ctypes and cygwin that
1626         is causing unit tests to crash for me locally.
1627
1628         * Scripts/webkitpy/common/system/executive.py:
1629         (Executive._win32_check_running_pid):
1630
1631 2012-07-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1632
1633         [GTK] WebKit test runner ignores all system environment variables
1634         https://bugs.webkit.org/show_bug.cgi?id=90284
1635
1636         Reviewed by Dirk Pranke.
1637
1638         Added support in unit test framework to pass a custom environment
1639         variable to the tests by using the --additional-env-var parameter.
1640
1641         * Scripts/webkitpy/layout_tests/port/base.py:
1642         (Port.to.setup_environ_for_server): Adding environment variables
1643         that come through the additional_env_var option.
1644         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1645         (PortTest.test_additional_env_var): Added unit test for the
1646         additional_env_var option
1647         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1648         (parse_args): Added the --additional-env-var parameter.
1649
1650 2012-07-19  Joshua Bell  <jsbell@chromium.org>
1651
1652         Roll out r121610 and r122487 which may have been causing flaky crashes
1653         https://bugs.webkit.org/show_bug.cgi?id=91637
1654
1655         Reviewed by Kentaro Hara.
1656
1657         Flaky crashes started in random tests following r121610. It's not clear
1658         that r121610 is to blame, but we'd like to prove or disprove it.
1659         If this doesn't resolve the crashes, this patch should be rolled out.
1660
1661         * DumpRenderTree/DumpRenderTree.gypi:
1662         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1663         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1664         (PluginTest):
1665         * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Removed.
1666
1667 2012-07-19  Pierre Rossi  <pierre.rossi@gmail.com>
1668
1669         [Qt][WK2] Map the elementRect exposed in QML to the view for popup menu
1670         https://bugs.webkit.org/show_bug.cgi?id=91645
1671
1672         Reviewed by Simon Hausmann.
1673
1674         Also improved the logic slightly for edge cases.
1675
1676         * MiniBrowser/qt/qml/ItemSelector.qml:
1677
1678 2012-07-19  Christophe Dumez  <christophe.dumez@intel.com>
1679
1680         [EFL] Bump libsoup dependency to v2.39.4.1 to fix cookie issues
1681         https://bugs.webkit.org/show_bug.cgi?id=91741
1682
1683         Reviewed by Kenneth Rohde Christiansen.
1684
1685         Bump libsoup dependency in jhbuild to v2.39.4.1 to fix issues
1686         with cookies in non-suffixed/private domains [GNOME #679230].
1687
1688         * efl/jhbuild.modules:
1689
1690 2012-07-19  Simon Hausmann  <simon.hausmann@nokia.com>
1691
1692         [Qt] Remove support for Qt versions before 4.8.0
1693         https://bugs.webkit.org/show_bug.cgi?id=91730
1694
1695         Reviewed by Kenneth Rohde Christiansen.
1696
1697         Remove Qt version check #ifdefs for Qt versions before 4.8.0.
1698
1699         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1700         (LayoutTestController::reset):
1701         (LayoutTestController::setAlwaysBlockCookies):
1702         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1703         (LayoutTestController):
1704
1705 2012-07-19  Mario Sanchez Prada  <msanchez@igalia.com>
1706
1707         [GTK] Enable MHTML support by default at build time
1708         https://bugs.webkit.org/show_bug.cgi?id=89987
1709
1710         Reviewed by Carlos Garcia Campos.
1711
1712         Enable MHTML support by default for GTK in build-webkit.
1713
1714         * Scripts/webkitperl/FeatureList.pm:
1715
1716 2012-07-19  Zoltan Nyul  <zoltan.nyul@intel.com>
1717
1718         [EFL][WK2] Using different cache directory for each WTR process
1719         https://bugs.webkit.org/show_bug.cgi?id=91719
1720
1721         Reviewed by Kenneth Rohde Christiansen.
1722
1723         The testrunner script may be running multiple processes in
1724         parallel, and it makes appcache tests fail if they are using the same
1725         directory. I modified the EFL's LayoutTestController to use the
1726         DUMPRENDERTREE_TEMP for application cache directory because it's
1727         different for each process.
1728
1729         * WebKitTestRunner/CMakeLists.txt:
1730         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
1731         (WTR::LayoutTestController::platformInitialize):
1732
1733 2012-07-19  Mario Sanchez Prada  <msanchez@igalia.com>
1734
1735         [WK2][GTK] Complete implementation of AccessibilityController in WKTR for GTK
1736         https://bugs.webkit.org/show_bug.cgi?id=89224
1737
1738         Reviewed by Chris Fleizach.
1739
1740         Implement logAccessibilityEvents() and resetToConsistentState(),
1741         so we can ask WKTR from the layout tests for logging all the
1742         accessibility related events into the result.
1743
1744         * WebKitTestRunner/GNUmakefile.am:
1745         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1746         (WTR::AccessibilityController::AccessibilityController):
1747         (WTR):
1748         (WTR::AccessibilityController::logAccessibilityEvents):
1749         (WTR::AccessibilityController::resetToConsistentState):
1750         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1751         (AccessibilityController):
1752         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp: Added.
1753         (WTR):
1754         (WTR::printAccessibilityEvent):
1755         (WTR::axObjectEventListener):
1756         (WTR::AccessibilityController::logAccessibilityEvents):
1757         (WTR::AccessibilityController::resetToConsistentState):
1758
1759         Ensure we reset the accessibility controller to a consistent
1760         whenever a test has finished running.
1761
1762         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1763         (WTR::InjectedBundle::done):
1764
1765 2012-07-19  Dominik Röttsches  <dominik.rottsches@intel.com>
1766
1767         [EFL][Wk2] Add a bot that runs WTR / WebKit2 tests
1768         https://bugs.webkit.org/show_bug.cgi?id=90788
1769
1770         Reviewed by Kentaro Hara.
1771
1772         Adding EFL 64bit WK2 BuildAndTest bot. At this point, we cannot transfer
1773         the build product from one bot to the other due to link path issues with jhbuild,
1774         so we do a full build and test cycle for WebKit2 on this bot.
1775
1776         * BuildSlaveSupport/build.webkit.org-config/config.json: Adding the new slave.
1777         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Adding a new factory for building and testing WebKit2.
1778         (BuildAndTestWebKit2Factory):
1779
1780 2012-07-18  Mihnea Ovidenie  <mihnea@adobe.com>
1781
1782         Unreviewed. Adding Andrei Bucur, Mihai Balan and Raul Hudea to the contributors list.
1783         They are Adobe contributors working on CSSRegions.
1784
1785         * Scripts/webkitpy/common/config/committers.py:
1786
1787 2012-07-18  Christophe Dumez  <christophe.dumez@intel.com>
1788
1789         [CMake][EFL] Should try to find the same libsoup version pulled by jhbuild
1790         https://bugs.webkit.org/show_bug.cgi?id=91626
1791
1792         Reviewed by Kenneth Rohde Christiansen.
1793
1794         Update jhbuild to pull libsoup 2.39.3 tarball from Gnome FTP instead
1795         of fetching a tag from Gnome GIT. We need to do this to map the version
1796         of libsoup that is required by our CMake config.
1797
1798         * efl/jhbuild.modules:
1799
1800 2012-07-18  MORITA Hajime  <morrita@google.com>
1801
1802         Add window resize benchmark
1803         https://bugs.webkit.org/show_bug.cgi?id=91070
1804
1805         Reviewed by Ryosuke Niwa.
1806
1807         Added some more output filters to take care of html5.html output.
1808
1809         * Scripts/webkitpy/performance_tests/perftest.py:
1810         (PerfTest):
1811
1812 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
1813
1814         nrwt: merge WebKitDriver into Driver
1815         https://bugs.webkit.org/show_bug.cgi?id=91696
1816
1817         Reviewed by Adam Barth.
1818
1819         As part of merging WebKitPort into Port, we also should merge
1820         WebKitDriver into Driver, since all of the non-test Drivers now
1821         inherit from WebKitDriver.
1822
1823         There are no functional changes in this patch, and all the changes should
1824         be covered by the existing tests.
1825
1826         * Scripts/webkitpy/layout_tests/port/base.py:
1827         (Port._driver_class):
1828         * Scripts/webkitpy/layout_tests/port/chromium.py:
1829         (ChromiumPort._check_file_exists):
1830         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1831         (ChromiumAndroidDriver):
1832         (ChromiumAndroidDriver.__init__):
1833         (ChromiumAndroidDriver._drt_cmd_line):
1834         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1835         (ChromiumAndroidDriverTest.test_read_prompt):
1836         * Scripts/webkitpy/layout_tests/port/driver.py:
1837         (Driver):
1838         (Driver.__init__):
1839         (Driver.__del__):
1840         (Driver.run_test):
1841         (Driver.has_crashed):
1842         (Driver.start):
1843         (Driver._start):
1844         (Driver.stop):
1845         (Driver.cmd_line):
1846         (Driver._check_for_driver_crash):
1847         (Driver._command_from_driver_input):
1848         (Driver._read_first_block):
1849         (Driver._read_optional_image_block):
1850         (Driver._read_header):
1851         (Driver._process_stdout_line):
1852         (Driver._strip_eof):
1853         (Driver._read_block):
1854         (ContentBlock):
1855         (ContentBlock.__init__):
1856         (ContentBlock.decode_content):
1857         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1858         (DriverTest.make_port):
1859         (DriverTest._assert_wrapper):
1860         (DriverTest.test_read_block):
1861         (DriverTest):
1862         (DriverTest.test_read_binary_block):
1863         (DriverTest.test_read_base64_block):
1864         (DriverTest.test_no_timeout):
1865         (DriverTest.test_check_for_driver_crash):
1866         (DriverTest.test_check_for_driver_crash.FakeServerProcess):
1867         (DriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
1868         (DriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
1869         (DriverTest.test_check_for_driver_crash.FakeServerProcess.name):
1870         (DriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
1871         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
1872         (DriverTest.test_check_for_driver_crash.assert_crash):
1873         (DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1874         (DriverTest.test_stop_cleans_up_properly):
1875         (DriverTest.test_two_starts_cleans_up_properly):
1876         (MockServerProcess):
1877         (MockServerProcess.__init__):
1878         (MockServerProcess.has_crashed):
1879         (MockServerProcess.read_stdout_line):
1880         (MockServerProcess.read_stdout):
1881         (MockServerProcess.read_either_stdout_or_stderr_line):
1882         (MockServerProcess.start):
1883         (MockServerProcess.stop):
1884         (MockServerProcess.kill):
1885         * Scripts/webkitpy/layout_tests/port/gtk.py:
1886         * Scripts/webkitpy/layout_tests/port/webkit.py:
1887         (WebKitPort._read_image_diff):
1888         (WebKitPort.skipped_layout_tests):
1889         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1890         (test_path_to_apache_config_file):
1891         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1892         (XvfbDriver):
1893         (XvfbDriver.stop):
1894
1895 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
1896
1897         webkitpy.common.system.executive_unittest.ExecutiveTest.test_kill_process is flaky
1898         https://bugs.webkit.org/show_bug.cgi?id=91698
1899
1900         Unreviewed, build fix.
1901
1902         This is a workaround for the test failing (apparently mostly?)
1903         when run in parallel with other tests. The underlying bug still
1904         needs to be diagnosed as we shouldn't be getting ECHILD from
1905         process.wait().
1906
1907         * Scripts/webkitpy/common/system/executive_unittest.py:
1908         (ExecutiveTest.test_kill_process):
1909
1910 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
1911
1912         Disable running python unit tests in parallel on win32 for now.
1913         https://bugs.webkit.org/show_bug.cgi?id=91697
1914
1915         Unreviewed, build fix.
1916
1917         * Scripts/webkitpy/test/main.py:
1918         (Tester._parse_args):
1919
1920 2012-07-18  Dave Tu  <dtu@chromium.org>
1921
1922         [chromium] Add gl_tests to flakiness dashboard.
1923         https://bugs.webkit.org/show_bug.cgi?id=91680
1924
1925         Reviewed by Dirk Pranke.
1926
1927         * TestResultServer/static-dashboards/builders.js:
1928         (loadBuildersList):
1929         * TestResultServer/static-dashboards/dashboard_base.js:
1930         (currentBuilderGroupCategory):
1931
1932 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
1933
1934         fix python unit tests failing under cygwin
1935         https://bugs.webkit.org/show_bug.cgi?id=91678
1936
1937         Reviewed by Adam Barth.
1938
1939         Fix a case where executive.kill_process was failing under cygwin
1940         (apple win port) in an unexpected way.
1941
1942         * Scripts/webkitpy/common/system/executive.py:
1943         (Executive.kill_process):
1944
1945 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
1946
1947         test-webkitpy: run tests in parallel by default
1948         https://bugs.webkit.org/show_bug.cgi?id=91422
1949
1950         Reviewed by Adam Barth.
1951
1952         We use multiprocessing.cpu_count() for the default number of
1953         jobs to run; memory overhead should be very low, so this should
1954         be fine.
1955
1956         * Scripts/webkitpy/test/main.py:
1957         (Tester._parse_args):
1958
1959 2012-07-18  Ryosuke Niwa  <rniwa@webkit.org>
1960
1961         Add Pravin D to the list of contributors.
1962
1963         * Scripts/webkitpy/common/config/committers.py:
1964
1965 2012-07-18  Balazs Kelemen  <kbalazs@webkit.org>
1966
1967         [Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
1968         https://bugs.webkit.org/show_bug.cgi?id=91514
1969
1970         Reviewed by Dirk Pranke.
1971
1972         Analyzing libQtWebKit.so is not enough in the case of force_static_libs_as_shared.
1973         We need to analyze all the shared library or at least the WebCore one.
1974
1975         * Scripts/webkitdirs.pm:
1976         (builtDylibPathForName):
1977         In orwt it is hard coded to search for symbols in the WebCore library.
1978         While in theory it is possible that symbols for a given feature are not
1979         located in that, it doesn't happen in practice, so returning the path of
1980         the WebCore library for a force_static_libs_as_shared build is enough to
1981         fix the bug and it doesn't require a bigger refactoring. For a default
1982         build we still return the path of the QtWebKit lib.
1983         * Scripts/webkitpy/layout_tests/port/qt.py:
1984         (QtPort._modules_to_search_for_symbols):
1985         Enumerate all dynamic libraries, not just the QtWebKit one.
1986
1987 2012-07-18  Tony Chang  <tony@chromium.org>
1988
1989         [chromium] Unreviewed, more compile fixes on Chromium Win.
1990
1991         * DumpRenderTree/chromium/TestShellWin.cpp:
1992         (TestShell::waitTestFinished):
1993         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1994
1995 2012-07-18  Christophe Dumez  <christophe.dumez@intel.com>
1996
1997         [EFL] Add central error management to EFL port
1998         https://bugs.webkit.org/show_bug.cgi?id=91598
1999
2000         Reviewed by Kenneth Rohde Christiansen.
2001
2002         Map WebKitNetworkError to NSURLErrorDomain when
2003         printing in DumpRenderTree so that the output
2004         matches the expected one.
2005
2006         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2007         (descriptionSuitableForTestResult):
2008
2009 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2010
2011         nrwt: start merging port/webkit.py into port/base.py
2012         https://bugs.webkit.org/show_bug.cgi?id=91559
2013
2014         Reviewed by Ojan Vafai.
2015
2016         Since all the non-test port implementations now derive from
2017         WebKitPort, there's no real point in keeping WebKitPort distinct
2018         from Port. This patch starts merging the two by moving nearly
2019         all of the webkit implementations of routines with no default
2020         behavior into base.py. The few that didn't move rely on
2021         additional infrastructure that should be refactored differently
2022         (like the image diffing, which should probably be its own
2023         class) and deserve their own patches.
2024
2025         This patch should just be moving code around, and require no
2026         additional tests; in fact, we can delete the tests that were
2027         asserting virtual methods in the base class.
2028
2029         * Scripts/webkitpy/layout_tests/port/base.py:
2030         (Port.baseline_search_path):
2031         (Port.check_build):
2032         (Port):
2033         (Port._check_driver):
2034         (Port._check_port_build):
2035         (Port.check_image_diff):
2036         (Port.driver_name):
2037         (Port.default_results_directory):
2038         (Port.to.setup_environ_for_server):
2039         (Port._path_to_apache):
2040         (Port._is_redhat_based):
2041         (Port._is_debian_based):
2042         (Port._apache_config_file_name_for_platform):
2043         (Port._path_to_apache_config_file):
2044         (Port._build_path):
2045         (Port._path_to_driver):
2046         (Port._path_to_webcore_library):
2047         (Port._path_to_helper):
2048         (Port._path_to_image_diff):
2049         (Port._path_to_wdiff):
2050         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2051         (PortTest.test_httpd_returns_error_code):
2052         * Scripts/webkitpy/layout_tests/port/webkit.py:
2053         (WebKitPort):
2054         (WebKitPort._build_driver_flags):
2055         (WebKitPort._read_image_diff):
2056         (WebKitPort.skipped_layout_tests):
2057
2058 2012-07-18  Tommy Widenflycht  <tommyw@google.com>
2059
2060         [chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
2061         https://bugs.webkit.org/show_bug.cgi?id=86215
2062
2063         Reviewed by Adam Barth.
2064
2065         Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
2066         instead create mock objects. No actual mock objects created yet.
2067
2068         * DumpRenderTree/DumpRenderTree.gypi:
2069         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2070         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2071         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.
2072         (MockWebKitPlatformSupport::create):
2073         (MockWebKitPlatformSupport::MockWebKitPlatformSupport):
2074         (MockWebKitPlatformSupport::cryptographicallyRandomValues):
2075         (MockWebKitPlatformSupport::createMediaStreamCenter):
2076         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.
2077         (MockWebKitPlatformSupport):
2078         * DumpRenderTree/chromium/config.h:
2079
2080 2012-07-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2081
2082         [CMake][EFL] Build and run TestWebKitAPI unit tests
2083         https://bugs.webkit.org/show_bug.cgi?id=90671
2084
2085         Reviewed by Daniel Bates.
2086
2087         This patch enables almost for free a significant amount of test for the
2088         WebKit C API, WTF and KURL. It makes easy for CMake based ports to
2089         enable TestWebKitAPI since the missing bits to implement are
2090         relatively simple.
2091
2092         * CMakeLists.txt:
2093         * TestWebKitAPI/CMakeLists.txt: Added.
2094         * TestWebKitAPI/PlatformEfl.cmake: Added.
2095         * TestWebKitAPI/PlatformWebView.h:
2096         * TestWebKitAPI/config.h:
2097         * TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
2098         (TestWebKitAPI):
2099         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2100         * TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
2101         (TestWebKitAPI):
2102         (Util):
2103         (TestWebKitAPI::Util::run):
2104         (TestWebKitAPI::Util::sleep):
2105         (TestWebKitAPI::Util::createURLForResource):
2106         (TestWebKitAPI::Util::createInjectedBundlePath):
2107         (TestWebKitAPI::Util::URLForNonExistentResource):
2108         * TestWebKitAPI/efl/PlatformWebView.cpp: Added.
2109         (TestWebKitAPI):
2110         (TestWebKitAPI::initEcoreEvas):
2111         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2112         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2113         (TestWebKitAPI::PlatformWebView::page):
2114         * TestWebKitAPI/efl/main.cpp: Added.
2115         (checkForUseX11WindowArgument):
2116         (main):
2117
2118 2012-07-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2119
2120         [CMake][EFL] Building jsc causes reconfiguration
2121         https://bugs.webkit.org/show_bug.cgi?id=91387
2122
2123         Reviewed by Daniel Bates.
2124
2125         We should remove CMakeCache only when running build-webkit script,
2126         otherwise it will cause a reconfiguration every time someone calls
2127         generateBuildSystemFromCMakeProject(). We were re-building "jsc" and
2128         not running WebKit2 unit tests on the bots because the project was
2129         reconfigured with default values by the scripts that run these tests.
2130
2131         * Scripts/build-webkit:
2132         * Scripts/webkitdirs.pm:
2133         (removeCMakeCache):
2134         (generateBuildSystemFromCMakeProject):
2135
2136 2012-07-18  Seokju Kwon  <seokju.kwon@samsung.com>
2137
2138         [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
2139         https://bugs.webkit.org/show_bug.cgi?id=87935
2140
2141         Reviewed by Andreas Kling.
2142
2143         Web Inspector will be shown when path or url contains "inspector/".
2144         Dumprendertree should wait util web inspector resources are loaded totally
2145         and handle the signals for creating or removing a view of web inspector.
2146         ("inspector,view,create" and "inspector,view,close")
2147
2148         * DumpRenderTree/efl/DumpRenderTree.cpp:
2149         (shouldOpenWebInspector):
2150         (createLayoutTestController):
2151         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2152         (DumpRenderTreeChrome::createView):
2153         (DumpRenderTreeChrome::createWebInspectorView):
2154         (DumpRenderTreeChrome::removeWebInspectorView):
2155         (DumpRenderTreeChrome::waitInspectorLoadFinished):
2156         (DumpRenderTreeChrome::onInspectorViewCreate):
2157         (DumpRenderTreeChrome::onInspectorViewClose):
2158         (DumpRenderTreeChrome::onInspectorFrameLoadFinished):
2159         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2160         (DumpRenderTreeChrome):
2161         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2162         (onConsoleMessage):
2163         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2164         (LayoutTestController::showWebInspector):
2165         (LayoutTestController::closeWebInspector):
2166         (LayoutTestController::evaluateInWebInspector):
2167
2168 2012-07-18  Simon Hausmann  <simon.hausmann@nokia.com>
2169
2170         [ANGLE] On QT, use Bison and Flex during ANGLE build
2171         https://bugs.webkit.org/show_bug.cgi?id=91108
2172
2173         Reviewed by Kenneth Rohde Christiansen.
2174
2175         * qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow
2176         generating not only for SOURCES but also ANGLE_SOURCES (in this bug)
2177
2178 2012-07-18  Balazs Kelemen  <kbalazs@webkit.org>
2179
2180         [Qt] plugin tests should not be disabled for WebKit1
2181         https://bugs.webkit.org/show_bug.cgi?id=91604
2182
2183         Reviewed by Simon Hausmann.
2184
2185         Instead of not building TestNetscapePlugIn, we could programatically
2186         disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
2187         has been solved, so we can still test plugins on WebKit1.
2188
2189         * Tools.pro:
2190         * WebKitTestRunner/TestController.cpp:
2191         (WTR::TestController::initialize):
2192         * WebKitTestRunner/qt/TestControllerQt.cpp:
2193         (WTR::TestController::initializeTestPluginDirectory):
2194
2195 2012-07-18  Mario Sanchez Prada  <msanchez@igalia.com>
2196
2197         [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
2198         https://bugs.webkit.org/show_bug.cgi?id=89223
2199
2200         Reviewed by Chris Fleizach.
2201
2202         Implemented AccessibilityUIElement in WKTR for GTK, based in the
2203         implementation present in DumpRenderTree.
2204
2205         Added new files in gtk/ and updated the cross-platform ones.
2206
2207         * WebKitTestRunner/GNUmakefile.am:
2208         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2209         (WTR):
2210         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2211         (AccessibilityUIElement):
2212         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp: Added.
2213         (WTR):
2214         (WTR::attributeSetToString):
2215         (WTR::checkElementState):
2216         (WTR::indexRangeInTable):
2217         (WTR::alterCurrentValue):
2218         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2219         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2220         (WTR::AccessibilityUIElement::isEqual):
2221         (WTR::AccessibilityUIElement::getChildren):
2222         (WTR::AccessibilityUIElement::getChildrenWithRange):
2223         (WTR::AccessibilityUIElement::childrenCount):
2224         (WTR::AccessibilityUIElement::elementAtPoint):
2225         (WTR::AccessibilityUIElement::indexOfChild):
2226         (WTR::AccessibilityUIElement::childAtIndex):
2227         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2228         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2229         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2230         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2231         (WTR::AccessibilityUIElement::rowAtIndex):
2232         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2233         (WTR::AccessibilityUIElement::selectedChildrenCount):
2234         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2235         (WTR::AccessibilityUIElement::titleUIElement):
2236         (WTR::AccessibilityUIElement::parentElement):
2237         (WTR::AccessibilityUIElement::disclosedByRow):
2238         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2239         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2240         (WTR::AccessibilityUIElement::attributesOfChildren):
2241         (WTR::AccessibilityUIElement::allAttributes):
2242         (WTR::AccessibilityUIElement::stringAttributeValue):
2243         (WTR::AccessibilityUIElement::numberAttributeValue):
2244         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2245         (WTR::AccessibilityUIElement::boolAttributeValue):
2246         (WTR::AccessibilityUIElement::isAttributeSettable):
2247         (WTR::AccessibilityUIElement::isAttributeSupported):
2248         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2249         (WTR::AccessibilityUIElement::role):
2250         (WTR::AccessibilityUIElement::subrole):
2251         (WTR::AccessibilityUIElement::roleDescription):
2252         (WTR::AccessibilityUIElement::title):
2253         (WTR::AccessibilityUIElement::description):
2254         (WTR::AccessibilityUIElement::orientation):
2255         (WTR::AccessibilityUIElement::stringValue):
2256         (WTR::AccessibilityUIElement::language):
2257         (WTR::AccessibilityUIElement::helpText):
2258         (WTR::AccessibilityUIElement::x):
2259         (WTR::AccessibilityUIElement::y):
2260         (WTR::AccessibilityUIElement::width):
2261         (WTR::AccessibilityUIElement::height):
2262         (WTR::AccessibilityUIElement::clickPointX):
2263         (WTR::AccessibilityUIElement::clickPointY):
2264         (WTR::AccessibilityUIElement::intValue):
2265         (WTR::AccessibilityUIElement::minValue):
2266         (WTR::AccessibilityUIElement::maxValue):
2267         (WTR::AccessibilityUIElement::valueDescription):
2268         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2269         (WTR::AccessibilityUIElement::isActionSupported):
2270         (WTR::AccessibilityUIElement::isEnabled):
2271         (WTR::AccessibilityUIElement::isRequired):
2272         (WTR::AccessibilityUIElement::isFocused):
2273         (WTR::AccessibilityUIElement::isSelected):
2274         (WTR::AccessibilityUIElement::isExpanded):
2275         (WTR::AccessibilityUIElement::isChecked):
2276         (WTR::AccessibilityUIElement::hierarchicalLevel):
2277         (WTR::AccessibilityUIElement::speak):
2278         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2279         (WTR::AccessibilityUIElement::ariaDropEffects):
2280         (WTR::AccessibilityUIElement::lineForIndex):
2281         (WTR::AccessibilityUIElement::rangeForLine):
2282         (WTR::AccessibilityUIElement::rangeForPosition):
2283         (WTR::AccessibilityUIElement::boundsForRange):
2284         (WTR::AccessibilityUIElement::stringForRange):
2285         (WTR::AccessibilityUIElement::attributedStringForRange):
2286         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2287         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2288         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2289         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2290         (WTR::AccessibilityUIElement::attributesOfColumns):
2291         (WTR::AccessibilityUIElement::attributesOfRows):
2292         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2293         (WTR::AccessibilityUIElement::attributesOfHeader):
2294         (WTR::AccessibilityUIElement::rowCount):
2295         (WTR::AccessibilityUIElement::columnCount):
2296         (WTR::AccessibilityUIElement::indexInTable):
2297         (WTR::AccessibilityUIElement::rowIndexRange):
2298         (WTR::AccessibilityUIElement::columnIndexRange):
2299         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2300         (WTR::AccessibilityUIElement::horizontalScrollbar):
2301         (WTR::AccessibilityUIElement::verticalScrollbar):
2302         (WTR::AccessibilityUIElement::selectedTextRange):
2303         (WTR::AccessibilityUIElement::setSelectedTextRange):
2304         (WTR::AccessibilityUIElement::increment):
2305         (WTR::AccessibilityUIElement::decrement):
2306         (WTR::AccessibilityUIElement::showMenu):
2307         (WTR::AccessibilityUIElement::press):
2308         (WTR::AccessibilityUIElement::setSelectedChild):
2309         (WTR::AccessibilityUIElement::accessibilityValue):
2310         (WTR::AccessibilityUIElement::documentEncoding):
2311         (WTR::AccessibilityUIElement::documentURI):
2312         (WTR::AccessibilityUIElement::url):
2313         (WTR::AccessibilityUIElement::addNotificationListener):
2314         (WTR::AccessibilityUIElement::removeNotificationListener):
2315         (WTR::AccessibilityUIElement::isFocusable):
2316         (WTR::AccessibilityUIElement::isSelectable):
2317         (WTR::AccessibilityUIElement::isMultiSelectable):
2318         (WTR::AccessibilityUIElement::isVisible):
2319         (WTR::AccessibilityUIElement::isOffScreen):
2320         (WTR::AccessibilityUIElement::isCollapsed):
2321         (WTR::AccessibilityUIElement::isIgnored):
2322         (WTR::AccessibilityUIElement::hasPopup):
2323         (WTR::AccessibilityUIElement::takeFocus):
2324         (WTR::AccessibilityUIElement::takeSelection):
2325         (WTR::AccessibilityUIElement::addSelection):
2326         (WTR::AccessibilityUIElement::removeSelection):
2327         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2328         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2329         (WTR::AccessibilityUIElement::previousTextMarker):
2330         (WTR::AccessibilityUIElement::nextTextMarker):
2331         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2332         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2333         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2334         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2335         (WTR::AccessibilityUIElement::textMarkerForPoint):
2336         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2337         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2338         (WTR::AccessibilityUIElement::indexForTextMarker):
2339         (WTR::AccessibilityUIElement::isTextMarkerValid):
2340         (WTR::AccessibilityUIElement::textMarkerForIndex):
2341
2342         Add documentEncoding and documentURI to AccessibilityUIElement.idl.
2343
2344         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2345
2346 2012-07-18  Alexis Menard  <alexis.menard@openbossa.org>
2347
2348         [EFL] Build fix in WebKitTestRunner.
2349         https://bugs.webkit.org/show_bug.cgi?id=91567
2350
2351         Reviewed by Kentaro Hara.
2352
2353         sleep() is defined in unistd.h, we need to include it.
2354
2355         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2356
2357 2012-07-18  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2358
2359         [NRWT] Unreviewed gardening after r122913
2360         https://bugs.webkit.org/show_bug.cgi?id=91601
2361
2362         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2363         (TrivialMockPort.process_kill_time):
2364
2365 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
2366
2367         [Chromium-Android] Run ref tests together to avoid expensive driver restarts
2368         https://bugs.webkit.org/show_bug.cgi?id=91533
2369
2370         Reviewed by Dirk Pranke.
2371
2372         Though DriverProxy maintains two drivers to support pixel tests and non-pixel tests,
2373         chromium-android uses another way because it can't support multiple drivers.
2374         It restarts the driver when pixel-test mode changes (e.g. when running a ref test after
2375         a normal test in --no-pixel-tests mode). However restarting driver is expensive on
2376         Android (several seconds each time). To reduce the cost, a command line option
2377         '--shard-ref-tests' is added to group ref tests in dedicated shards.
2378         The option is by default enabled on Android.
2379
2380         Will remove the option once DRT supports switching pixel test mode during one run.
2381         (https://bugs.webkit.org/show_bug.cgi?id=91538, https://bugs.webkit.org/show_bug.cgi?id=91539)
2382
2383         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2384         (Manager._shard_tests):
2385         (Manager._shard_in_two):
2386         (Manager._shard_by_directory):
2387         (Manager._run_tests):
2388         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2389         (Worker._update_test_input):
2390         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2391         (ChromiumAndroidPort.__init__):
2392         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2393         (parse_args):
2394
2395 2012-07-17  Don Olmstead  <don.olmstead@am.sony.com>
2396
2397         NRWT The time before server_process kills DRT should be variable
2398         https://bugs.webkit.org/show_bug.cgi?id=91542
2399
2400         Reviewed by Dirk Pranke.
2401
2402         Added the ability to configure the amount of time
2403         server_process waits before killing the DRT process
2404         during the call to stop.
2405
2406         * Scripts/webkitpy/layout_tests/port/base.py:
2407         (Port.variable.process_kill_time):
2408         * Scripts/webkitpy/layout_tests/port/server_process.py:
2409         (ServerProcess.stop):
2410
2411 2012-07-17  Alexis Menard  <alexis.menard@openbossa.org>
2412
2413         webkitdirs.pm should fallback to uname -m if arch is not present.
2414         https://bugs.webkit.org/show_bug.cgi?id=91543
2415
2416         Reviewed by Martin Robinson.
2417
2418         It seems that coreutils is moving away from the 'arch' command. Archlinux
2419         for example doesn't ship it anymore (coreutils 8.17). We can then fallback
2420         to 'uname -m' to find out the architecture.
2421
2422         * Scripts/webkitdirs.pm:
2423         (determineArchitecture):
2424
2425 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
2426
2427         nrwt: rename printer.print_update to printer.write_update to match metered_stream
2428         https://bugs.webkit.org/show_bug.cgi?id=91557
2429
2430         Reviewed by Ojan Vafai.
2431
2432         Now that all of the printing logic is in printer.py, I want the
2433         public interface to printer to follow the meteredstream
2434         interface where possible. renaming write_update() gets us close.
2435
2436         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2437         (Manager._run_tests):
2438         (Manager._set_up_run):
2439         (Manager.start_servers_with_lock):
2440         (Manager.stop_servers_with_lock):
2441         (Manager._clobber_old_results):
2442         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2443         (run):
2444         * Scripts/webkitpy/layout_tests/views/printing.py:
2445         (Printer.write_update):
2446         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2447         (Testprinter.test_write_update):
2448
2449 2012-07-17  Tony Chang  <tony@chromium.org>
2450
2451         Fix a bug where optimize-baselines would incorrectly fail to optimize
2452         https://bugs.webkit.org/show_bug.cgi?id=91551
2453
2454         Reviewed by Adam Barth.
2455
2456         In some cases, optimize-baseline would correctly optimize the results, but because
2457         we weren't filtering the virtual ports out of _results_by_port_name, we thought
2458         that we had failed to optimize.
2459
2460         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2461         (BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
2462         (BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
2463         (BaselineOptimizer.optimize): Filter out virtual ports.
2464         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2465         (TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
2466         (BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
2467         (BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
2468         (BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
2469         (BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.
2470
2471 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
2472
2473         [Chromium] Add --encode-binary command line option for DRT
2474         https://bugs.webkit.org/show_bug.cgi?id=91532
2475
2476         Reviewed by Adam Barth.
2477
2478         When the option presents, DRT will encode binary output data in base64.
2479         ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
2480         binary data output.
2481
2482         This change is a refactoring to replace the original hard-coded code for Android.
2483
2484         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2485         (main):
2486         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2487         (TestEventPrinter::TestEventPrinter):
2488         (TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
2489         (TestEventPrinter::handleImage):
2490         (TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage
2491         * DumpRenderTree/chromium/TestEventPrinter.h:
2492         (TestEventPrinter):
2493         * DumpRenderTree/chromium/TestShell.cpp:
2494         (TestShell::TestShell):
2495         (TestShell::initialize):
2496         (TestShell::dump):
2497         * DumpRenderTree/chromium/TestShell.h:
2498         (TestShell):
2499         (TestShell::setEncodeBinary):
2500         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags
2501         (ChromiumAndroidPort.__init__):
2502
2503 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
2504
2505         nrwt: move per-test result output into printing.py
2506         https://bugs.webkit.org/show_bug.cgi?id=91465
2507
2508         Reviewed by Ojan Vafai.
2509
2510         This moves the last substantive logging/printing code from the
2511         manager into printing.py. Subsequent patches in this thread can
2512         largely focus on cleaning up printing.py and will leave the rest
2513         of the code alone.
2514
2515         This patch also removes manager.update() and
2516         manager.update_summary(), two routines that were no longer being
2517         used or needed (they have been dead for a long time but I didn't
2518         notice them until now).
2519
2520         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2521         (Manager.results_directory):
2522         (Manager._look_for_new_crash_logs):
2523         (Manager._update_summary_with_result):
2524         * Scripts/webkitpy/layout_tests/views/printing.py:
2525         (Printer.print_finished_test):
2526
2527 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
2528
2529         nrwt: move config-specific logging to printing.py
2530         https://bugs.webkit.org/show_bug.cgi?id=91450
2531
2532         Reviewed by Ojan Vafai.
2533
2534         More refactoring ... this moves the 'config' output to
2535         printing.py.
2536
2537         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2538         (Manager._resize_shards):
2539         (Manager._run_tests):
2540         (Manager._upload_json_files):
2541         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2542         (ManagerTest.get_options):
2543         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2544         (run):
2545         * Scripts/webkitpy/layout_tests/views/printing.py:
2546         (Printer.print_config):
2547         (Printer.print_workers_and_shards):
2548         (Printer._print_config):
2549         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2550         (Testprinter.test_fallback_path_in_config):
2551         (Testprinter.test_print_config):
2552
2553 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
2554
2555         nrwt: clean up logging when we're only running one chunk of the tests
2556         https://bugs.webkit.org/show_bug.cgi?id=91447
2557
2558         Reviewed by Ojan Vafai.
2559
2560         Apparently we were creating a 'tests_run.txt' in the results
2561         directory if we were only running one chunk of the tests; after
2562         3+ years of hacking on this code, that was news to me, so I'm
2563         guessing no one uses this. I'm removing this, and changing the
2564         _print_expected calls to debug messages to simplify the
2565         layering.
2566
2567         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2568         (Manager._split_into_chunks_if_necessary):
2569
2570 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
2571
2572         Fix regression in style checker introduced in r122868.
2573         https://bugs.webkit.org/show_bug.cgi?id=91470
2574
2575         Unreviewed, build fix.
2576
2577         * Scripts/webkitpy/style/checkers/cpp.py:
2578         (_FileState.__init__):
2579
2580 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
2581
2582         nrwt: move the bulk of the "expected" output to printing.py
2583         https://bugs.webkit.org/show_bug.cgi?id=91442
2584
2585         Reviewed by Ojan Vafai.
2586
2587         More printing-related refactoring. This moves all of the code
2588         that prints the results we expect to get, but doesn't move a few
2589         dangling printfs (those'll get hit in a later patch).
2590
2591         No functional changes; covered by existing tests.
2592
2593         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2594         (Manager._split_into_chunks_if_necessary):
2595         (Manager.prepare_lists_and_print_output):
2596         (Manager.print_config):
2597         * Scripts/webkitpy/layout_tests/views/printing.py:
2598         (Printer.print_expected):
2599         (Printer):
2600         (Printer._print_expected_results_of_type):
2601         (Printer._num_digits):
2602         (Printer._print_expected):
2603         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2604         (Testprinter.test_print_expected):
2605
2606 2012-07-17  Christophe Dumez  <christophe.dumez@intel.com>
2607
2608         [EFL] Replace 0 by NULL in public headers documentation
2609         https://bugs.webkit.org/show_bug.cgi?id=91470
2610
2611         Reviewed by Dirk Pranke.
2612
2613         Fix style checking to properly detect C headers as C
2614         files. Without this change, the style script would
2615         complain if we use NULL (instead of 0 / null) in C
2616         headers.
2617
2618         * Scripts/webkitpy/style/checkers/cpp.py:
2619         (_FileState.__init__):
2620         (_FileState.is_c):
2621         (_FileState.is_c_or_objective_c):
2622
2623 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
2624
2625         [chromium] remove --test-shell support from DRT
2626         https://bugs.webkit.org/show_bug.cgi?id=86927
2627
2628         Reviewed by Adam Barth.
2629
2630         Now no one use --test-shell. All of us use the standard DRT mode.
2631
2632         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed support of --test-shell and --pixel-tests=filename options. (--pixel-tests without '=' is kept for DRT mode.)
2633         (runTest):
2634         (main):
2635         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2636         (TestEventPrinter::TestEventPrinter):
2637         (TestEventPrinter::~TestEventPrinter):
2638         (TestEventPrinter::handleTestHeader):
2639         (TestEventPrinter::handleTimedOut):
2640         (TestEventPrinter::handleTextHeader):
2641         (TestEventPrinter::handleTextFooter):
2642         (TestEventPrinter::handleAudioHeader):
2643         (TestEventPrinter::handleAudioFooter):
2644         (TestEventPrinter::handleImage): Removed the unused filename parameter.
2645         (TestEventPrinter::handleTestFooter):
2646         * DumpRenderTree/chromium/TestEventPrinter.h:
2647         (TestEventPrinter): Made it a concrete class because we have only one implementation.
2648         * DumpRenderTree/chromium/TestShell.cpp:
2649         (TestShell::TestShell):
2650         (TestShell::initialize):
2651         (TestShell::dumpImage):
2652         * DumpRenderTree/chromium/TestShell.h:
2653         (TestParams): Removed pixelFileName field.
2654         (TestShell):
2655
2656 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
2657
2658         remove ChromiumDriver from NRWT
2659         https://bugs.webkit.org/show_bug.cgi?id=88478
2660
2661         Now WebKitDriver has replaced ChromiumDriver since test_shell mode is deperecated.
2662
2663         Reviewed by Dirk Pranke.
2664
2665         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed ChromiumDriver code.
2666         (ChromiumPort._driver_class): Removed. WebKitPort._driver_class() will be used.
2667         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2668
2669 2012-07-17  No'am Rosenthal  <noam.rosenthal@nokia.com>
2670
2671         Unreviewed. Add QtGraphics, TextureMapper and OpenGL to watchlist.
2672
2673         * Scripts/webkitpy/common/config/watchlist:
2674
2675 2012-07-17  Sheriff Bot  <webkit.review.bot@gmail.com>
2676
2677         Unreviewed, rolling out r122828.
2678         http://trac.webkit.org/changeset/122828
2679         https://bugs.webkit.org/show_bug.cgi?id=91516
2680
2681         DumpRenderTree crashes after printing test results. (Requested
2682         by vsevik on #webkit).
2683
2684         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
2685         (TestInterfaces::TestInterfaces):
2686         (TestInterfaces::~TestInterfaces):
2687         (TestInterfaces::bindTo):
2688         (TestInterfaces::resetAll):
2689         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
2690         (TestInterfaces):
2691         * DumpRenderTree/chromium/TestShell.cpp:
2692         (TestShell::initialize):
2693         (TestShell::createMainWindow):
2694         (TestShell::~TestShell):
2695         (TestShell::resetTestController):
2696         (TestShell::bindJSObjectsToWindow):
2697         * DumpRenderTree/chromium/TestShell.h:
2698         (TestShell::accessibilityController):
2699         (TestShell):
2700
2701 2012-07-17  Gabor Ballabas  <gaborb@inf.u-szeged.hu>
2702
2703         [Qt][V8] Remove the V8 related codepaths and configuration
2704         https://bugs.webkit.org/show_bug.cgi?id=90863
2705
2706         Reviewed by Simon Hausmann.
2707
2708         * Scripts/build-webkit: Remove --v8 option.
2709
2710 2012-07-17  Sheriff Bot  <webkit.review.bot@gmail.com>
2711
2712         Unreviewed, rolling out r122834.
2713         http://trac.webkit.org/changeset/122834
2714         https://bugs.webkit.org/show_bug.cgi?id=91492
2715
2716         it broke the chromium (Requested by kkristof on #webkit).
2717
2718         * Scripts/build-webkit:
2719
2720 2012-07-17  Gabor Ballabas  <gaborb@inf.u-szeged.hu>
2721
2722         [Qt][V8] Remove the V8 related codepaths and configuration
2723         https://bugs.webkit.org/show_bug.cgi?id=90863
2724
2725         Reviewed by Simon Hausmann.
2726
2727         * Scripts/build-webkit: Remove --v8 option.
2728
2729 2012-07-17  Balazs Kelemen  <kbalazs@webkit.org>
2730
2731         [Qt] Add --use-test-fonts option to Minibrowser
2732         https://bugs.webkit.org/show_bug.cgi?id=91402
2733
2734         Reviewed by Tor Arne Vestbø.
2735
2736         Same stuff that already exists for QtTestBrowser.
2737
2738         * MiniBrowser/qt/MiniBrowser.pro:
2739         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2740         (MiniBrowserApplication::handleUserOptions):
2741
2742 2012-07-17  Adam Barth  <abarth@webkit.org>
2743
2744         [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
2745         https://bugs.webkit.org/show_bug.cgi?id=91459
2746
2747         Reviewed by Ryosuke Niwa.
2748
2749         Rather than having TestShell own and bind each of these JavaScript APIs
2750         individually, TestShell should delegate that work to TestInterfaces.
2751         This patch moves AccessibilityController and TextInputController to be
2752         the responsibility of TestInterfaces.
2753
2754         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
2755         (TestInterfaces::TestInterfaces):
2756         (TestInterfaces::~TestInterfaces):
2757         (TestInterfaces::setWebView):
2758         (TestInterfaces::bindTo):
2759         (TestInterfaces::resetAll):
2760         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
2761         (WebKit):
2762         (TestInterfaces):
2763         (TestInterfaces::accessibilityController):
2764         * DumpRenderTree/chromium/TestShell.cpp:
2765         (TestShell::initialize):
2766         (TestShell::createMainWindow):
2767         (TestShell::~TestShell):
2768         (TestShell::resetTestController):
2769         (TestShell::bindJSObjectsToWindow):
2770         * DumpRenderTree/chromium/TestShell.h:
2771         (TestShell::accessibilityController):
2772         (TestShell):
2773
2774 2012-07-17  Adam Barth  <abarth@webkit.org>
2775
2776         [Chromium] Move TextInputController into TestRunner.a
2777         https://bugs.webkit.org/show_bug.cgi?id=91457
2778
2779         Reviewed by Ryosuke Niwa.
2780
2781         This patch is purely moving code. TextInputController is one of the
2782         objects exposed to JavaScript and so should be in the TestRunner
2783         library.
2784
2785         * DumpRenderTree/DumpRenderTree.gypi:
2786         * DumpRenderTree/chromium/TestRunner/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TextInputController.cpp.
2787         * DumpRenderTree/chromium/TestRunner/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TextInputController.h.
2788
2789 2012-07-17  Adam Barth  <abarth@webkit.org>
2790
2791         [Chromium] TextInputController shouldn't know about TestShell
2792         https://bugs.webkit.org/show_bug.cgi?id=91455
2793
2794         Reviewed by Kent Tamura.
2795
2796         This patch uses the same pattern we used for the
2797         AccessibilityController to remove the dependency on TestShell.
2798
2799         * DumpRenderTree/chromium/TestShell.cpp:
2800         (TestShell::initialize):
2801         (TestShell::createMainWindow):
2802         (TestShell::~TestShell):
2803         * DumpRenderTree/chromium/TextInputController.cpp:
2804         (TextInputController::TextInputController):
2805         (TextInputController::insertText):
2806         (TextInputController::doCommand):
2807         (TextInputController::setMarkedText):
2808         (TextInputController::unmarkText):
2809         (TextInputController::hasMarkedText):
2810         (TextInputController::markedRange):
2811         (TextInputController::selectedRange):
2812         (TextInputController::firstRectForCharacterRange):
2813         (TextInputController::validAttributesForMarkedText):
2814         (TextInputController::setComposition):
2815         * DumpRenderTree/chromium/TextInputController.h:
2816         (WebKit):
2817         (TextInputController):
2818         (TextInputController::setWebView):
2819
2820 2012-07-17  David Barr  <davidbarr@chromium.org>
2821
2822         Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
2823         https://bugs.webkit.org/show_bug.cgi?id=89055
2824
2825         Reviewed by Kent Tamura.
2826
2827         The css3-images module is at candidate recommendation.
2828         http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
2829
2830         Add a configuration option for CSS image-orientation support, disabling it by default.
2831
2832         * Scripts/webkitperl/FeatureList.pm:
2833         * qmake/mkspecs/features/features.pri:
2834
2835 2012-07-16  Adam Barth  <abarth@webkit.org>
2836
2837         [Chromium] Move Task.(cpp|h) into TestRunner.a
2838         https://bugs.webkit.org/show_bug.cgi?id=91446
2839
2840         Reviewed by Ryosuke Niwa.
2841
2842         Task is a dependency of EventSender, which needs to move into TestRunner.a.
2843
2844         * DumpRenderTree/DumpRenderTree.gypi:
2845         * DumpRenderTree/chromium/TestRunner/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/Task.cpp.
2846         * DumpRenderTree/chromium/TestRunner/Task.h: Renamed from Tools/DumpRenderTree/chromium/Task.h.
2847
2848 2012-07-16  Adam Barth  <abarth@webkit.org>
2849
2850         [Chromium] Move AccessibilityController and AccessibilityUIElement into TestRunner.a
2851         https://bugs.webkit.org/show_bug.cgi?id=91443
2852
2853         Reviewed by Tony Chang.
2854
2855         Purely a file move (and a sorting of #includes).
2856
2857         * DumpRenderTree/DumpRenderTree.gypi:
2858         * DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.cpp.
2859         * DumpRenderTree/chromium/TestRunner/AccessibilityController.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.h.
2860         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.cpp.
2861         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.h.
2862
2863 2012-07-16  Adam Barth  <abarth@webkit.org>
2864
2865         [Chromium] AccessibilityController shouldn't know anything about TestShell
2866         https://bugs.webkit.org/show_bug.cgi?id=91441
2867
2868         Reviewed by Tony Chang.
2869
2870         This patch is a precursor to moving AccessibilityController.cpp into TestRunner.a.
2871
2872         * DumpRenderTree/chromium/AccessibilityController.cpp:
2873         (AccessibilityController::AccessibilityController):
2874         (AccessibilityController::getFocusedElement):
2875         (AccessibilityController::getRootElement):
2876         * DumpRenderTree/chromium/AccessibilityController.h:
2877         (WebKit):
2878         (AccessibilityController):
2879         (AccessibilityController::setWebView):
2880         * DumpRenderTree/chromium/TestShell.cpp:
2881         (TestShell::initialize):
2882         (TestShell::createMainWindow):
2883         (TestShell::~TestShell):
2884
2885 2012-07-16  Adam Barth  <abarth@webkit.org>
2886
2887         [Chromium] Introduce TestInterfaces to hold all the JavaScript interfaces needed for LayoutTests
2888         https://bugs.webkit.org/show_bug.cgi?id=91312
2889
2890         Reviewed by Ryosuke Niwa.
2891
2892         Looking forward to moving more objects into TestRunner.a, we're going
2893         to need an object to own all the interfaces and to put them through
2894         their lifecycle.
2895
2896         * DumpRenderTree/DumpRenderTree.gypi:
2897         * DumpRenderTree/chromium/TestShell.cpp:
2898         (TestShell::initialize):
2899         (TestShell::resetTestController):
2900         (TestShell::bindJSObjectsToWindow):
2901         * DumpRenderTree/chromium/TestShell.h:
2902         (TestShell):
2903         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: Added.
2904         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h: Added.
2905
2906 2012-07-16  Ryuan Choi  <ryuan.choi@samsung.com>
2907
2908         [EFL][WK2] Add APIs to support theme.
2909         https://bugs.webkit.org/show_bug.cgi?id=90107
2910
2911         Reviewed by Hajime Morita.
2912
2913         Override default theme path for MiniBrowser and WebKitTestRunner.
2914
2915         * MiniBrowser/efl/CMakeLists.txt:
2916         * MiniBrowser/efl/main.c:
2917         (browserCreate):
2918         * WebKitTestRunner/PlatformEfl.cmake:
2919         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2920         (WTR::PlatformWebView::PlatformWebView):
2921
2922 2012-07-16  Ryuan Choi  <ryuan.choi@samsung.com>
2923
2924         [EFL][DRT] Implement dumpFrameScrollPosition
2925         https://bugs.webkit.org/show_bug.cgi?id=87638
2926
2927         Reviewed by Hajime Morita.
2928
2929         * DumpRenderTree/efl/DumpRenderTree.cpp:
2930         (dumpFrameScrollPosition): Implemented.
2931         (shouldDumpFrameScrollPosition): Fixed wrong condition like other ports.
2932
2933 2012-07-16  Don Olmstead  <don.olmstead@am.sony.com>
2934
2935         NRWRT Should provide a VS project to work on
2936         https://bugs.webkit.org/show_bug.cgi?id=91436
2937
2938         Reviewed by Dirk Pranke.
2939
2940         Adding VS2010 project for modifying webkitpy. Uses pytools
2941         <http://pytools.codeplex.com> which integrates python into
2942         Visual Studio.
2943
2944         * Scripts/webkitpy/webkitpy.pyproj: Added.
2945         * Scripts/webkitpy/webkitpy.sln: Added.
2946
2947 2012-07-16  Adam Barth  <abarth@webkit.org>
2948
2949         [Chromium] Move GamepadController into TestRunner.a
2950         https://bugs.webkit.org/show_bug.cgi?id=91311
2951
2952         Reviewed by Tony Chang.
2953
2954         GamepadController looks like a simple class to move into TestRunner.a
2955         because it has almost zero dependence on TestShell.
2956
2957         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2958         * DumpRenderTree/DumpRenderTree.gypi:
2959         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.cpp.
2960         * DumpRenderTree/chromium/TestRunner/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.h.
2961         * DumpRenderTree/chromium/TestRunner/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/CppVariant.cpp.
2962         * DumpRenderTree/chromium/TestRunner/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/CppVariant.h.
2963             - GamepadController depends on these bindings helpers.
2964         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/GamepadController.cpp.
2965         * DumpRenderTree/chromium/TestRunner/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/GamepadController.h.
2966             - Just moved these files and removed the unused TestShell
2967               references.
2968         * DumpRenderTree/chromium/TestRunner/Stub.cpp: Removed.
2969             - No longer needed.
2970         * DumpRenderTree/chromium/TestShell.cpp:
2971             - Update call to constructor to avoid passing in this.
2972
2973 2012-07-16  Xianzhu Wang  <wangxianzhu@chromium.org>
2974
2975         [Chromium-android] Don't use test_shell mode of DRT
2976         https://bugs.webkit.org/show_bug.cgi?id=88542
2977
2978         Reviewed by Dirk Pranke.
2979
2980         Test shell mode is about to be removed.
2981         Switch to use DRT mode for chromium-android.
2982
2983         Summary of changes:
2984         1. ChromiumAndroidDriver now inherits from WebKitDriver instead of ChromiumDriver (to be deprecated).
2985         2. Conforms to the DRT mode protocol for input/output of DumpRenderTree.
2986         3. Added support for Android 'adb shell' input/output (base64, newline mode, etc.)
2987
2988         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2989         (DRTPrinter::handleImage): Outputs base64 on Android.
2990         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2991         (platformInit): Changed err_file to err_fifo, required by python ServerProcess.
2992         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2993         (ChromiumAndroidPort.__init__):
2994         (ChromiumAndroidPort.create_driver): Override to create driver without DriverProxy to ensure 1 Driver per run.
2995         (ChromiumAndroidDriver):
2996         (ChromiumAndroidDriver.__init__):
2997         (ChromiumAndroidDriver.cmd_line):
2998         (ChromiumAndroidDriver._deadlock_detector):
2999         (ChromiumAndroidDriver._drt_cmd_line):
3000         (ChromiumAndroidDriver.start):
3001         (ChromiumAndroidDriver._start):
3002         (ChromiumAndroidDriver._start_once):
3003         (ChromiumAndroidDriver.run_test):
3004         (ChromiumAndroidDriver.stop):
3005         (ChromiumAndroidDriver._command_from_driver_input):
3006         (ChromiumAndroidDriver._read_prompt):
3007         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3008         (ChromiumAndroidPortTest.test_driver_cmd_line):
3009         (ChromiumAndroidDriverTest.test_cmd_line):
3010         (ChromiumAndroidDriverTest):
3011         (ChromiumAndroidDriverTest.test_drt_cmd_line):
3012         (ChromiumAndroidDriverTest.test_read_prompt):
3013         (ChromiumAndroidDriverTest.test_command_from_driver_input):
3014         (ChromiumAndroidDriverTest.test_write_command_and_read_line):
3015         * Scripts/webkitpy/layout_tests/port/server_process.py:
3016         (ServerProcess.__init__): Added universal_newlines to handle Android 'adb shell' line ends.
3017         (ServerProcess._start):
3018         (ServerProcess._wait_for_data_and_update_buffers_using_select): Handles unexpected EOF which indicates crash on Android.
3019         (ServerProcess.stop): Added kill_directly parameter to kill the process without waiting it (which always timeouts for Android).
3020         (ServerProcess.replace_outputs): Added to combine different input/output pipes into one ServerProcess.
3021         * Scripts/webkitpy/layout_tests/port/webkit.py:
3022         (WebKitDriver._command_from_driver_input):
3023         (WebKitDriver.run_test): Changed timeout origin so that slow start() on Android won't cause timeout of layout test case.
3024         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3025         (MockServerProcess.read_stdout):
3026         (MockServerProcess.start):
3027         (MockServerProcess):
3028         (MockServerProcess.stop):
3029         (MockServerProcess.kill):
3030         (WebKitDriverTest.test_read_block):
3031         (WebKitDriverTest.test_read_binary_block):
3032         (WebKitDriverTest.test_read_base64_block):
3033
3034 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3035
3036         nrwt: move a bunch of printing code from manager.py to printing.py
3037         https://bugs.webkit.org/show_bug.cgi?id=91439
3038
3039         Reviewed by Ojan Vafai.
3040
3041         All of the logic that handles what gets logged should eventually
3042         live in printing.py; this patch moves a large chunk of code that
3043         prints all of the stuff after the run completes.
3044
3045         There are no functional changes, this is just moving code
3046         around. Covered by existing tests (updated as necessary).
3047
3048         This code is all pretty messy and most of it should be deleted
3049         (or extracted after the fact from results.json), but I'm saving
3050         that for further patches. My goal is just to manager.py to a
3051         more manageable state.
3052
3053         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3054         (Manager.prepare_lists_and_print_output):
3055         (Manager.run):
3056         (Manager._mark_interrupted_tests_as_skipped):
3057         (Manager._update_summary_with_result):
3058         (Manager._num_digits):
3059         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3060         (ManagerTest.test_interrupt_if_at_failure_limits):
3061         (ResultSummaryTest.summarized_results):
3062         * Scripts/webkitpy/layout_tests/models/result_summary.py:
3063         (ResultSummary.__init__):
3064         (ResultSummary.add):
3065         Here we had to add a list of the slow tests to the result
3066         summary so that we didn't need to call back into the manager and
3067         the test expectations object to figure out if a test is SLOW.
3068         * Scripts/webkitpy/layout_tests/views/printing.py:
3069         (Printer.print_results):
3070         (Printer):
3071         (Printer._print_timing_statistics):
3072         (Printer._print_aggregate_test_statistics):
3073         (Printer._print_individual_test_times):
3074         (Printer._print_test_list_timing):
3075         (Printer._print_directory_timings):
3076         (Printer._print_statistics_for_test_timings):
3077         (Printer._print_result_summary):
3078         (Printer._print_result_summary_entry):
3079         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3080         (Testprinter.test_print_unexpected_results.get_unexpected_results):
3081         (Testprinter):
3082
3083 2012-07-16  Adam Barth  <abarth@webkit.org>
3084
3085         [Chromium] Create a stub TestRunner.a target
3086         https://bugs.webkit.org/show_bug.cgi?id=91309
3087
3088         Reviewed by Ryosuke Niwa.
3089
3090         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3091         * DumpRenderTree/DumpRenderTree.gypi:
3092         * DumpRenderTree/chromium/TestRunner/Stub.cpp: Added.
3093
3094 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3095
3096         test-webkitpy: clean up logging to make it ninja-esque
3097         https://bugs.webkit.org/show_bug.cgi?id=91297
3098
3099         Reviewed by Adam Barth.
3100
3101         This patch changes the output of test-webkitpy to be closer to
3102         what ninja produces. Namely:
3103
3104         If you are running with stderr writing to a tty (and not -v), we
3105         will no longer print '...' as tests complete. Instead, we use a
3106         metered stream and print entries of the form:
3107            '[X/Y] test_name passed/failed/erred'
3108         where X is the current test # and Y is the total number of tests.
3109
3110         If you are running with stderr piped to a file or other non-tty
3111         object (or with -v), you get the same output, one per line for
3112         every test.
3113
3114         In addition, if tests fail or err out, you get the stack trace
3115         immediately; you don't have to wait until the end of the run.
3116
3117         Lastly, this change cleans up the unit tests for test-webkitpy
3118         itself to not confuse the logger and to work cleanly w/ multiple
3119         processes. It looks like between this and all the clean up in
3120         MessagePool that happened as it landed, we can now run
3121         multiprocessing tests in parallel.
3122
3123         * Scripts/webkitpy/test/finder.py:
3124         (Finder._default_names):
3125         * Scripts/webkitpy/test/finder_unittest.py:
3126         (FinderTest.setUp):
3127         (FinderTest.tearDown):
3128         * Scripts/webkitpy/test/printer.py:
3129         (Printer.__init__):
3130         (Printer.configure):
3131         (Printer.print_started_test):
3132         (Printer.print_finished_test):
3133         (Printer._test_line):
3134         (Printer.print_result):
3135         * Scripts/webkitpy/test/runner.py:
3136         (Runner.run):
3137         * Scripts/webkitpy/test/runner_unittest.py:
3138         (RunnerTest.setUp):
3139         (RunnerTest):
3140         (RunnerTest.tearDown):
3141         (RunnerTest.assert_run):
3142         (RunnerTest.test_regular):
3143         (RunnerTest.test_verbose):
3144         (RunnerTest.test_timing):
3145
3146 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3147
3148         test-webkitpy: handle failures properly when running in parallel
3149         https://bugs.webkit.org/show_bug.cgi?id=91416
3150
3151         Reviewed by Adam Barth.
3152
3153         It turns out that unittest.TestResults contain a handle to the
3154         test method itself, which isn't picklable; it's sufficient to just
3155         store the test name instead of the actual method. By doing so
3156         we can move the test_name() method from the printer to the
3157         runner where it belongs (so the printer is less dependent on the
3158         unittest framework's data structures).
3159
3160         This change should really have a test but I don't know how to
3161         write one that properly captures the behavior and won't cause
3162         test-webkitpy itself to fail. I've verified the fix by hand, at
3163         least, in the meantime.
3164
3165         * Scripts/webkitpy/test/printer.py:
3166         (Printer.__init__):
3167         (Printer.print_result):
3168         * Scripts/webkitpy/test/runner.py:
3169         (_test_name):
3170         (Runner.all_test_names):
3171         (_Worker.handle):
3172
3173 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3174
3175         test-webkitpy: handle failures properly when running in parallel
3176         https://bugs.webkit.org/show_bug.cgi?id=91416
3177
3178         Reviewed by Tony Chang.
3179
3180         It turns out that unittest.TestResults contain a handle to the
3181         test method itself, which isn't picklable; it's sufficient to just
3182         store the test name instead of the actual method. By doing so
3183         we can move the test_name() method from the printer to the
3184         runner where it belongs (so the printer is less dependent on the
3185         unittest framework's data structures).
3186
3187         This change should really have a test but I don't know how to
3188         write one that properly captures the behavior and won't cause
3189         test-webkitpy itself to fail. I've verified the fix by hand, at
3190         least, in the meantime.
3191
3192         * Scripts/webkitpy/test/printer.py:
3193         (Printer.__init__):
3194         (Printer.print_result):
3195         * Scripts/webkitpy/test/runner.py:
3196         (_test_name):
3197         (Runner.all_test_names):
3198         (_Worker.handle):
3199
3200 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3201
3202         test-webkitpy: run tests in parallel
3203         https://bugs.webkit.org/show_bug.cgi?id=91294
3204
3205         Reviewed by Ojan Vafai.
3206
3207         This change adds support for running tests in parallel. This is
3208         not yet on by default, since the logging isn't very pretty w/
3209         parallel tests.
3210
3211         Also, there are some (multiprocessing-related) tests that can't be
3212         run in parallel and so we skip them in that situation; I need to
3213         come up with a mechanism for dealing with this, since you
3214         apparently can't use multiprocessing as both a parent and a
3215         child process.
3216
3217         * Scripts/webkitpy/test/finder.py:
3218         (Finder.find_names):
3219         (Finder._default_names):
3220         * Scripts/webkitpy/test/main.py:
3221         (Tester._parse_args):
3222         (Tester.run):
3223         * Scripts/webkitpy/test/main_unittest.py:
3224         (TesterTest.test_no_tests_found):
3225         * Scripts/webkitpy/test/runner.py:
3226         (Runner.run):
3227         * Scripts/webkitpy/test/runner_unittest.py:
3228         (RunnerTest.test_regular):
3229         (RunnerTest.test_verbose):
3230         (RunnerTest.test_timing):
3231
3232 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3233
3234         test-webkitpy: use message pools
3235         https://bugs.webkit.org/show_bug.cgi?id=91292
3236
3237         Reviewed by Ojan Vafai.
3238
3239         Restructure the test-running code to be message-driven and
3240         use a MessagePool; note that this does not yet actually run the
3241         tests in parallel.
3242
3243         Also clean up the unit tests so that the fake loader is passed
3244         to the _Worker properly, and reduce a lot of the cut&pasted code
3245         in the tests.
3246
3247         No functional changes; covered by existing tests.
3248
3249         * Scripts/webkitpy/test/printer.py:
3250         (Printer.print_started_test):
3251         (Printer.print_finished_test):
3252         * Scripts/webkitpy/test/runner.py:
3253         (Runner.__init__):
3254         (Runner.run):
3255         (Runner.handle):
3256         (_Worker):
3257         (_Worker.__init__):
3258         (_Worker.handle):
3259         * Scripts/webkitpy/test/runner_unittest.py:
3260         (RunnerTest.assert_run):
3261         (RunnerTest.test_regular):
3262         (RunnerTest.test_verbose):
3263         (RunnerTest.test_timing):
3264
3265 2012-07-16  Simon Hausmann  <simon.hausmann@nokia.com>
3266
3267         [Qt] Fix Qt5 module dependencies
3268         https://bugs.webkit.org/show_bug.cgi?id=91388
3269
3270         Reviewed by Laszlo Gombos.
3271
3272         Removed ancient qtscript and qtxmlpatterns module dependencies.
3273
3274         * qmake/qt_webkit.pri:
3275
3276 2012-07-16  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3277
3278         run-webkit-test returns 254 at exit even when it succeeds
3279         https://bugs.webkit.org/show_bug.cgi?id=91370
3280
3281         Reviewed by Simon Hausmann.
3282
3283         sys.exit() is implemented by raising SystemExit which inherits from
3284         BaseException. Since we are catching BaseException, run_webkit_tests.py
3285         was always returning an error code.
3286
3287         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3288
3289 2012-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3290
3291         Unreviewed. Fix make distcheck.
3292
3293         * GNUmakefile.am: Add missing file to compilation.
3294
3295 2012-07-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3296
3297         Unreviewed. Add EFLWebKit2PublicAPI, EFLWebKit2PlatformSpecific to watch list.
3298
3299         * Scripts/webkitpy/common/config/watchlist:
3300
3301 2012-07-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3302
3303         Unreviewed. Add gyuyoung.kim@samsung.com to watch list.
3304
3305         * Scripts/webkitpy/common/config/watchlist:
3306
3307 2012-07-15  Joseph Pecoraro  <pecoraro@apple.com>
3308
3309         Windowless WebView not firing JavaScript load event if there is a media element
3310         https://bugs.webkit.org/show_bug.cgi?id=91331
3311
3312         Reviewed by Eric Carlson.
3313
3314         Test a windowless WebView loading a page with a media element. The load
3315         event should happen on the next spin of the run loop, but we spin check
3316         the page, with a timeout of 250ms.
3317
3318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3319         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.html: Added.
3320         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm: Added.
3321         (-[WindowlessWebViewWithMediaFrameLoadDelegate webView:didFinishLoadForFrame:]):
3322         (TestWebKitAPI::spinLoop): Spin check with timeout. Runs a block each spin to early bail.
3323         (TestWebKitAPI::TEST):
3324
3325 2012-07-14  Benjamin Poulain  <bpoulain@apple.com>
3326
3327         [Mac] Do not try to update the cache model for every WebPreferences change
3328         https://bugs.webkit.org/show_bug.cgi?id=91302
3329
3330         Reviewed by Joseph Pecoraro.
3331
3332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3333         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
3334         (TestWebKitAPI):
3335         (TestWebKitAPI::TEST):
3336
3337 2012-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3338
3339         Unreviewed, rolling out r122665.
3340         http://trac.webkit.org/changeset/122665
3341         https://bugs.webkit.org/show_bug.cgi?id=91321
3342
3343         Broke Mac builds (Requested by rniwa on #webkit).
3344
3345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3346         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Removed.
3347
3348 2012-07-13  Benjamin Poulain  <bpoulain@apple.com>
3349
3350         [Mac] Do not try to update the cache model for every WebPreferences change
3351         https://bugs.webkit.org/show_bug.cgi?id=91302
3352
3353         Reviewed by Joseph Pecoraro.
3354
3355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3356         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
3357         (TestWebKitAPI):
3358         (TestWebKitAPI::TEST):
3359
3360 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3361
3362         run-webkit-test outputs the wrong number of tests executed when some are skipped.
3363         https://bugs.webkit.org/show_bug.cgi?id=89894
3364
3365         Reviewed by Ojan Vafai.
3366
3367         Fix the logging of the actual number of tests run so that tests
3368         that are skipped aren't included.
3369
3370         Also revamp the 'expected' output so we distinguish the number
3371         of tests found from the number of tests run (to account for
3372         --repeat-each and --iterations).
3373
3374         Covered by existing tests.
3375
3376         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3377         (Manager.prepare_lists_and_print_output):
3378         (Manager._log_num_workers):
3379         (Manager.run):
3380         (Manager._print_result_summary):
3381         * Scripts/webkitpy/layout_tests/models/result_summary.py:
3382         (ResultSummary.__init__):
3383         (ResultSummary.add):
3384         * Scripts/webkitpy/layout_tests/views/printing.py:
3385         (Printer.print_one_line_summary):
3386         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3387         (Testprinter.test_print_one_line_summary):
3388
3389 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3390
3391         nrwt: actually print the exception name and message for otherwise unhandled exceptions
3392         https://bugs.webkit.org/show_bug.cgi?id=91305
3393
3394         Reviewed by Adam Barth.
3395
3396         Two more places where I was printing the stack trace but not the
3397         exception itself :(. These two spots can't easily be
3398         unit-tested, but I tested them by hand.
3399
3400         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3401         (run):
3402         (main):
3403
3404 2012-07-13  Josh Hawn  <jhawn@apple.com>
3405
3406         Fix for WebContext::getWebCoreStatistics() causes crash if no m_process
3407         https://bugs.webkit.org/show_bug.cgi?id=91116
3408
3409         Reviewed by Simon Fraser.
3410
3411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3412             Added new test file.
3413         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Added.
3414         (TestWebKitAPI::wkContextGetStatisticsCallback):
3415             Tests that callback function receives an error.
3416         (TestWebKitAPI::TEST):
3417             Creates a dummy web context object (no web process).
3418             Calls WKContextGetStatistics with the web context and test callback.
3419             The test callback should get an expected error.
3420
3421 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3422
3423         test-webkitpy: move printing-related code out of the runner
3424         https://bugs.webkit.org/show_bug.cgi?id=91289
3425
3426         Reviewed by Ryosuke Niwa.
3427
3428         More refactoring ... this moves all printing-related stuff out
3429         of runner.py and into printer.py.
3430
3431         No functional changes; covered by existing tests.
3432
3433         * Scripts/webkitpy/test/main.py:
3434         (Tester._run_tests):
3435         * Scripts/webkitpy/test/printer.py:
3436         (Printer.__init__):
3437         (Printer):
3438         (Printer.test_name):
3439         (Printer.print_started_test):
3440         (Printer.print_finished_test):
3441         (Printer.print_result):
3442         * Scripts/webkitpy/test/runner.py:
3443         (Runner.__init__):
3444         (Runner.all_test_names):
3445         (Runner.run):
3446         * Scripts/webkitpy/test/runner_unittest.py:
3447         (RunnerTest.test_regular):
3448         (RunnerTest.test_verbose):
3449         (RunnerTest.test_timing):
3450
3451 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3452
3453         webkitpy: split printing/logging code for test-webkitpy out into a new class
3454         https://bugs.webkit.org/show_bug.cgi?id=91282
3455
3456         Reviewed by Ojan Vafai.
3457
3458         This patch is the first step at splitting all of the
3459         printing/logging code out separately from the actual
3460         test-running code.
3461
3462         This is just moving stuff around; no new functionality and no
3463         new tests needed.
3464
3465         * Scripts/webkitpy/test/finder_unittest.py:
3466         (FinderTest.setUp):
3467         * Scripts/webkitpy/test/main.py:
3468         (Tester.__init__):
3469         (Tester._parse_args):
3470         (Tester.run):
3471         (Tester._run_tests):
3472         (Tester._log_exception):
3473         * Scripts/webkitpy/test/main_unittest.py:
3474         (TesterTest.test_no_tests_found):
3475         * Scripts/webkitpy/test/printer.py: Added.
3476         (Printer):
3477         (Printer.__init__):
3478         (Printer.configure):
3479         (Printer.configure.filter):
3480         (_CaptureAndPassThroughStream):
3481         (_CaptureAndPassThroughStream.__init__):
3482         (_CaptureAndPassThroughStream.write):
3483         (_CaptureAndPassThroughStream._message_is_from_pdb):
3484         (_CaptureAndPassThroughStream.flush):
3485         (_CaptureAndPassThroughStream.getvalue):
3486
3487 2012-07-13  James Simonsen  <simonjam@chromium.org>
3488
3489         [Navigation Timing] Imported W3C tests contain duplicates and are DOS formatted
3490         https://bugs.webkit.org/show_bug.cgi?id=91184
3491
3492         Reviewed by Adam Barth.
3493
3494         The upstream 'html5' tests are just duplicates of the 'html' tests.
3495
3496         * Scripts/import-w3c-performance-wg-tests:
3497
3498 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3499
3500         webkitpy: hide yield_to_caller from callers in MessagePool :)
3501         https://bugs.webkit.org/show_bug.cgi?id=91269
3502
3503         Reviewed by Adam Barth.
3504
3505         yield_to_caller() was an optimization/hack to allow us to run
3506         both manager and worker in a single process/loop without
3507         starving the manager while the worker is running tests. The
3508         worker was required to call yield_to_caller() periodically. It
3509         turns out that I can get equivalent responsiveness by yielding
3510         inside the MessagePool every time the worker posts a message, and this
3511         allows me to no longer need the worker to call the routine. Thus
3512         I rename yield_to_caller() to _yield_to_manager() to be a little
3513         clearer about its purpose.
3514
3515         Tested by existing tests.
3516
3517         * Scripts/webkitpy/common/message_pool.py:
3518         (_Worker.run):
3519         (_Worker.post):
3520         (_Worker._yield_to_manager):
3521         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3522         (Worker.handle):
3523
3524 2012-07-13  Adam Barth  <abarth@webkit.org>
3525
3526         EWSTools should be able to build a commit-queue instance from scratch
3527         https://bugs.webkit.org/show_bug.cgi?id=91264
3528
3529         Reviewed by Eric Seidel.
3530
3531         I've been using this script to build commit-queue instances on Google
3532         Compute Engine and it seems to work.
3533
3534         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Added.
3535
3536 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3537
3538         webkitpy: make worker.start() and worker.stop() optional in the messagepool
3539         https://bugs.webkit.org/show_bug.cgi?id=91170
3540
3541         Reviewed by Ojan Vafai.
3542
3543         test-webkitpy will use messagepool workers that don't actually
3544         have any per-worker state, so they don't need start() and stop()
3545         methods. Now we will only call the methods if they exist; this
3546         means that workers only need to expose a handle() method.
3547
3548         * Scripts/webkitpy/common/message_pool.py:
3549         (_Worker.terminate):
3550         (_Worker.run):
3551
3552 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3553
3554         NRWT doesn't print exceptions
3555         https://bugs.webkit.org/show_bug.cgi?id=91129
3556
3557         Reviewed by Ojan Vafai.
3558
3559         Although we printed exceptions in most cases, if an unexpected
3560         exception (like a runtime error) was raised when creating a
3561         port, we wouldn't. This patch fixes that, and also cleans up
3562         how we were logging exceptions from the workers to be less
3563         verbose.
3564
3565         Because of the corner cases where these errors are occurring,
3566         it's difficult to write automated unit tests for them. I've
3567         tested it quite a bit by hand, though.
3568
3569         * Scripts/webkitpy/common/message_pool.py:
3570         (_MessagePool._close):
3571         (_MessagePool._handle_worker_exception):
3572         (_Worker.run):
3573         (_Worker._raise):
3574         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3575         (Manager._run_tests):
3576         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3577         (main):
3578
3579 2012-07-13  Wei James  <james.wei@intel.com>
3580
3581         enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
3582         https://bugs.webkit.org/show_bug.cgi?id=91194
3583
3584         Reviewed by Adam Barth.
3585
3586         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3587
3588 2012-07-13  Simon Pena  <spena@igalia.com>
3589
3590         [GTK] Gardening: update API tests skipped list
3591         https://bugs.webkit.org/show_bug.cgi?id=91224
3592
3593         Unreviewed gardening.
3594
3595         Skip "next" and "previous" tests of FindController until bug #91083
3596         is fixed.
3597
3598         * gtk/run-api-tests:
3599         (TestRunner):
3600
3601 2012-07-13  Zeno Albisser  <zeno@webkit.org>
3602
3603         [Qt][WK2] Implement GraphicsSurface for Linux/GLX.
3604         https://bugs.webkit.org/show_bug.cgi?id=90881
3605
3606         Enable GraphicsSurface for Linux based platforms
3607         whenever the Xcomposite extension is available.
3608
3609         Reviewed by Noam Rosenthal.
3610
3611         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Added.
3612         (main):
3613         * qmake/config.tests/libXcomposite/libXcomposite.pro: Added.
3614           Add a configure test to detect Xcomposite extension and
3615           activate GraphicsSurface on linux in case the extension is available.
3616         * qmake/configure.pri:
3617         * qmake/mkspecs/features/features.prf:
3618
3619 2012-07-13  David Grogan  <dgrogan@chromium.org>
3620
3621         nrwt: don't choke when printing invalid utf-8 to stderr
3622         https://bugs.webkit.org/show_bug.cgi?id=91181
3623
3624         Reviewed by Dirk Pranke.
3625
3626         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3627         (TestResultWriter.write_stderr):
3628
3629 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3630
3631         test-webkitpy: more class renaming cleanup
3632         https://bugs.webkit.org/show_bug.cgi?id=91182
3633
3634         Reviewed by Adam Barth.
3635
3636         More removing of the unnecessary "Test" prefix.
3637
3638         * Scripts/webkitpy/test/finder.py:
3639         (_DirectoryTree):
3640         (Finder.add_tree):
3641         * Scripts/webkitpy/test/main.py:
3642         (Tester._run_tests):
3643         * Scripts/webkitpy/test/runner.py:
3644         (Runner):
3645         * Scripts/webkitpy/test/runner_unittest.py:
3646         (RunnerTest.test_regular):
3647         (RunnerTest.test_verbose):
3648         (RunnerTest.test_timing):
3649
3650 2012-07-12  Christophe Dumez  <christophe.dumez@intel.com>
3651
3652         [WK2][EFL] Facilitate debugging of the Web Process
3653         https://bugs.webkit.org/show_bug.cgi?id=90768
3654
3655         Reviewed by Kenneth Rohde Christiansen.
3656
3657         Add a new --webprocess-cmd-prefix argument to
3658         run-webkit-tests script for EFL port. If provided,
3659         the prefix will be prepended to the command used
3660         to spawn the Web process. This can be used for
3661         debugging purposes with prefixes such as:
3662         "xterm -title renderer -e gdb --args".
3663
3664         * Scripts/webkitpy/layout_tests/port/efl.py:
3665         (EflPort.__init__):
3666         (EflPort.setup_environ_for_server):
3667         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3668         (parse_args):
3669         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3670         (WTR::TestController::platformRunUntil): Implement support for
3671         m_noTimeout timeout value.
3672
3673 2012-07-12  Adam Barth  <abarth@webkit.org>
3674
3675         Fix crash in the commit-queue.  We need to initialize self.port during __init__.
3676
3677         * Scripts/webkitpy/tool/commands/queues.py:
3678         (CommitQueue.__init__):
3679         (CommitQueue.begin_work_queue):
3680
3681 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
3682
3683         test-webkitpy: rename test_finder to finder
3684         https://bugs.webkit.org/show_bug.cgi?id=91175
3685
3686         Reviewed by Adam Barth.
3687
3688         Rename test_finder -> finder, TestFinder -> Finder to remove
3689         some of the stutter in the names.
3690
3691         * Scripts/webkitpy/test/finder.py: Renamed from Tools/Scripts/webkitpy/test/test_finder.py.
3692         * Scripts/webkitpy/test/finder_unittest.py: Renamed from Tools/Scripts/webkitpy/test/test_finder_unittest.py.
3693         * Scripts/webkitpy/test/main.py:
3694         (Tester.__init__):
3695
3696 2012-07-12  Adam Barth  <abarth@webkit.org>
3697
3698         CommitQueue is confused about what port it is using
3699         https://bugs.webkit.org/show_bug.cgi?id=91040
3700
3701         Reviewed by Dirk Pranke.
3702
3703         On EC2, we explicitly pass --port to the commit-queue, but that
3704         requires editing the start-queue.sh script locally on each bot. In
3705         moving to Google Compute Engine, we're try to avoid any local edits to
3706         the EWSTools.
3707
3708         Rather than passing --port to the commit-queue, this patch teaches the
3709         CommitQueue which port its running, which is the approach we use for
3710         the EWS bots.
3711
3712         Mutating tool._deprecated_port is a bit ugly, but it's what we're doing
3713         currently for the EWS bots.
3714
3715         * Scripts/webkitpy/tool/commands/queues.py:
3716         (CommitQueue):
3717         (CommitQueue.begin_work_queue):
3718         (CommitQueue.run_command):
3719         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3720         (CommitQueueTest.test_commit_queue):
3721         (mock_run_webkit_patch):
3722         (test_rollout):
3723         (test_rollout_lands):
3724         (test_manual_reject_during_processing):
3725
3726 2012-07-12  James Simonsen  <simonjam@chromium.org>
3727
3728         [Navigation Timing] Import the W3C Navigation Timing test suite
3729         https://bugs.webkit.org/show_bug.cgi?id=84887
3730
3731         Reviewed by Tony Gentilcore.
3732
3733         * Scripts/import-w3c-performance-wg-tests: Added.
3734
3735 2012-07-12  Adam Barth  <abarth@webkit.org>
3736
3737         Unreviewed.  Nit: git config files use tabs, not spaces.
3738
3739         * EWSTools/cold-boot.sh:
3740
3741 2012-07-12  Kwang Yul Seo  <skyul@company100.net>
3742
3743         Unreviewed. Add Dongsung Huang to the list of contributors. He
3744         has submitted over 30 patches on texture mapper, canvas and image decoders.
3745
3746         * Scripts/webkitpy/common/config/committers.py:
3747
3748 2012-07-12  Kwang Yul Seo  <skyul@company100.net>
3749
3750         Unreviewed. Change my irc nickname to kseo.
3751
3752         * Scripts/webkitpy/common/config/committers.py:
3753
3754 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
3755
3756         webkitpy: clean up logging handlers, lint common.message_pool
3757         https://bugs.webkit.org/show_bug.cgi?id=91152
3758
3759         Reviewed by Ojan Vafai.
3760
3761         The unix implementation of multiprocessing clones any logging
3762         handlers from the parent process into the child; we currently
3763         don't want this behavior in our code, so I was hand-removing the
3764         installed handlers in the child process I knew about. After thinking
3765         about it further, I think it was simpler and safe enough to just
3766         remove all handlers in the child, since the message pool
3767         propagates any message from the child back into the parent.
3768
3769         We can always change this in the future if it turns out to be an issue.
3770
3771         I'm also fixing a couple of other lint warnings while I'm at it.
3772
3773         * Scripts/webkitpy/common/message_pool.py:
3774         (_MessagePool.__exit__):
3775         (_MessagePool._handle_worker_exception):
3776         (_Worker._set_up_logging):
3777
3778 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
3779
3780         webkitpy: rename manager_worker_broker to message_pool
3781         https://bugs.webkit.org/show_bug.cgi?id=91145
3782
3783         Reviewed by Ojan Vafai.
3784
3785         Since the MessagePool interface is more generic (and simpler)
3786         now and will be reused by test-webkitpy, I'm renaming it and
3787         moving it to webkitpy.common.
3788
3789         * Scripts/webkitpy/common/message_pool.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py.
3790         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3791         (TestRunInterruptedException.__reduce__):
3792         (Manager._run_tests.worker_factory):
3793         (Manager._run_tests):
3794         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3795
3796 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
3797
3798         nrwt crashes saving the output for a platform-specific expected test reference
3799         https://bugs.webkit.org/show_bug.cgi?id=90872
3800
3801         Reviewed by Ojan Vafai.
3802
3803         The expected output for a test is copied alongside the test
3804         itself in the layout-test-results directory; in other words, for
3805         foo/bar-expected.txt sits alongside foo/bar.html even if we're
3806         actually using platform/mac/foo/bar-expected.txt.
3807
3808         Unless the test is a reftest, in which case we would copy the
3809         output to platform/mac/foo/bar-expected.html and set a
3810         'ref_file' parameter in results.json to indicate the path. This
3811         can be useful in the cases where we have multiple references for
3812         a single test or when multiple tests share the same reference.
3813
3814         We found a bug where we weren't creating platform/mac/foo under
3815         the results directory, and so this wasn't actually working.
3816         However, treating reftests differently seems like a bad thing,
3817         so we should probably be consistent. This change puts the
3818         -expected.html next to the test, and reworks test_result_writer
3819         so that we create directories uniformly and consistently.
3820
3821         Note that we weren't catching this problem in unit tests because
3822         the MockFileSystem creates a directory automatically if it
3823         doesn't exist; this was done intentionally for convenience, but
3824         is really a bug and should be fixed; see https://bugs.webkit.org/show_bug.cgi?id=91028.
3825
3826         I have not added additional tests here since fixing that bug
3827         should be sufficient.
3828
3829         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3830         (interpret_test_failures):
3831         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3832         (ResultSummaryTest.test_interpret_test_failures):
3833         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3834         (write_test_result):
3835         (TestResultWriter._write_binary_file):
3836         (TestResultWriter):
3837         (TestResultWriter._write_text_file):
3838         (TestResultWriter.write_output_files):
3839         (TestResultWriter.write_stderr):
3840         (TestResultWriter.write_crash_log):
3841         (TestResultWriter.create_text_diff_and_write_result):
3842         (TestResultWriter.write_image_diff_files):
3843         (write_reftest):
3844         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3845         (EndToEndTest.test_reftest_with_two_notrefs):
3846
3847 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
3848
3849         nrwt: reimplement manager_worker_broker in a much simpler form
3850         https://bugs.webkit.org/show_bug.cgi?id=90513
3851
3852         Reviewed by Ojan Vafai.
3853
3854         This is a wholesale replacement of the MessagePool() implementation
3855         and the other classes in manager_worker_broker.py. All of the
3856         BrokerConnection*, Broker*, etc. classes are gone, and there are now
3857         just a MessagePool class and a _Worker class. Happiness ensues.
3858
3859         I'm removing manager_worker_broker_unittest.py as well; we get
3860         nearly complete coverage from the integration tests, and will
3861         get more coverage when test-webkitpy moves to use this as well,
3862         so having unit tests seems like unnecessary overhead. (running
3863         coverage numbers with test-webkitpy shows that pretty much the only
3864         uncovered lines are lines that are only run in the child processes,
3865         which coverage doesn't handle at the moment).
3866
3867         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3868         (_MessagePool.__init__):
3869         (_MessagePool.run):
3870         (_MessagePool._start_workers):
3871         (_MessagePool):
3872         (_MessagePool.wait):
3873         (_MessagePool._close):
3874         (_MessagePool._handle_done):
3875         (_MessagePool._can_pickle):
3876         (_MessagePool._loop):
3877         (WorkerException):
3878         (_Message.__init__):
3879         (_Message.__repr__):
3880         (_Worker):
3881         (_Worker.__init__):
3882         (_Worker.terminate):
3883         (_Worker._close):
3884         (_Worker.run):
3885         (_Worker.post):
3886         (_Worker.yield_to_caller):
3887         (_Worker._post):
3888         (_Worker._raise):
3889         (_Worker._set_up_logging):
3890         (_WorkerLogHandler.__init__):
3891         (_WorkerLogHandler.emit):
3892         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Removed.
3893
3894 2012-07-12  Tony Chang  <tony@chromium.org>
3895
3896         [chromium] Remove drag and drop API methods that are no longer used
3897         https://bugs.webkit.org/show_bug.cgi?id=90996
3898
3899         Reviewed by Adam Barth.
3900
3901         Migrate DRT to use the methods that take modifier keys.
3902
3903         * DumpRenderTree/chromium/EventSender.cpp:
3904         (EventSender::doDragDrop):
3905         (EventSender::doMouseUp):
3906         (EventSender::doMouseMove):
3907         (EventSender::beginDragWithFiles):
3908
3909 2012-07-12  Ojan Vafai  <ojan@chromium.org>
3910
3911         Allow putting ranges in user.py list prompts
3912         https://bugs.webkit.org/show_bug.cgi?id=91115
3913
3914         Reviewed by Adam Barth.
3915
3916         Ranges are inclusive and denoted by a dash. This is useful for rebaselining a whole port
3917         since the items are listed with each port's builders being contiguous.
3918
3919         * Scripts/webkitpy/common/system/user.py:
3920         (User._wait_on_list_response):
3921         * Scripts/webkitpy/common/system/user_unittest.py:
3922         (UserTest.test_prompt_with_multiple_lists.run_prompt_test):
3923         (UserTest.test_prompt_with_multiple_lists):
3924
3925 2012-07-12  Arnaud Renevier  <arno@renevier.net>
3926
3927         [GTK] Implement disableImageLoading in DRT
3928         https://bugs.webkit.org/show_bug.cgi?id=87973
3929
3930         Reviewed by Martin Robinson.
3931
3932         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3933         (resetDefaultsToConsistentValues):
3934         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3935         (LayoutTestController::disableImageLoading):
3936
3937 2012-07-12  Simon Hausmann  <simon.hausmann@nokia.com>
3938
3939         [Qt] Internal symbols are exported on Linux
3940         https://bugs.webkit.org/show_bug.cgi?id=90981
3941
3942         Reviewed by Jocelyn Turcotte.
3943
3944         I should've re-enabled ELF symbol visibility when removing the symbol map in
3945         r106650.
3946
3947         * qmake/mkspecs/features/default_post.prf:
3948
3949 2012-07-11  Mark Rowe  <mrowe@apple.com>
3950
3951         <http://webkit.org/b/91024> Build against the latest SDK when targeting older OS X versions.
3952
3953         Reviewed by Dan Bernstein.
3954
3955         The deployment target is already set to the version that we're targeting, and it's that setting
3956         which determines which functionality from the SDK is available to us.
3957
3958         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3959         * TestWebKitAPI/Configurations/Base.xcconfig:
3960         * WebKitTestRunner/Configurations/Base.xcconfig:
3961
3962 2012-07-11  Mark Rowe  <mrowe@apple.com>
3963
3964         Replace definitions of BUILDING_ON / TARGETING macros with macros that will error when used.
3965
3966         Part of <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros.
3967
3968         Reviewed by Anders Carlsson.
3969
3970         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Remove the macros completely from here since
3971         they're completely unused in TestNetscapePlugIn.
3972         * DumpRenderTree/config.h:
3973
3974 2012-07-11  Mark Rowe  <mrowe@apple.com>
3975
3976         <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros
3977
3978         This removal was handled by a script that translates the relevant macros in to the equivalent checks
3979         using the system availability macros.
3980
3981         Reviewed by Filip Pizlo.
3982
3983         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3984         * DumpRenderTree/mac/CheckedMalloc.cpp:
3985         * DumpRenderTree/mac/DumpRenderTree.mm:
3986         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3987         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3988         * DumpRenderTree/mac/TextInputController.m:
3989         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3990         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3991         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3992
3993 2012-07-11  Robert Kroeger  <rjkroege@chromium.org>
3994
3995         Suppress horizontal conversion of PlatformWheelEvents when hasPreciseScrollingDeltas is true
3996         https://bugs.webkit.org/show_bug.cgi?id=89580
3997
3998         WebKit GTK and Chromium Linux force vertical wheel events to
3999         scroll horizontally when over horizontal scroll bars.  This is
4000         undesirable for touchpad scrolling with
4001         hasPreciseScrollingDeltas() == true. Modified DumpRenderTree to
4002         let a layout test specify this attribute so that the change's impact
4003         on scrolling can be tested in a layout test.
4004
4005         Reviewed by Adam Barth.
4006
4007         * DumpRenderTree/chromium/EventSender.cpp:
4008         (EventSender::handleMouseWheel):
4009
4010 2012-07-11  Simon Fraser  <simon.fraser@apple.com>
4011
4012         Fix the build by declaring -isPaginated before use.
4013
4014         * MiniBrowser/mac/BrowserWindowController.m:
4015
4016 2012-07-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4017
4018         Unreviewed, rolling out r122358.
4019         http://trac.webkit.org/changeset/122358
4020         https://bugs.webkit.org/show_bug.cgi?id=91037
4021
4022         Build break on WebKit Win (Requested by hayato on #webkit).
4023
4024         * DumpRenderTree/chromium/EventSender.cpp:
4025         (EventSender::doDragDrop):
4026         (EventSender::doMouseUp):
4027         (EventSender::doMouseMove):
4028         (EventSender::beginDragWithFiles):
4029
4030 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
4031
4032         nrwt: add a MessagePool abstraction that the manager will call to replace the broker
4033         https://bugs.webkit.org/show_bug.cgi?id=90511
4034
4035         Reviewed by Ojan Vafai.
4036
4037         This change introduces the new MessagePool abstraction that will
4038         replace the classes in manager_worker_broker. It is a minimal
4039         interface that tries to follow the conventions in
4040         multiprocessing.Pool and concurrency.futures ... it provides a
4041         context manager and a run() method that sends N messages to M
4042         workers processes (starting workers as necessary) and waits for
4043         them all to complete, handling cleanup as necessary. The caller
4044         is responsible for providing a handle() method to handle
4045         messages received from the workers.
4046
4047         This interface basically hides all of the multiprocessing logic from
4048         the manager class.
4049
4050         The initial implementation of MessagePool is a simple shim
4051         around the existing broker classes; a subsequent change will
4052         replace all the other classes with a much simpler
4053         implementation.
4054
4055         No additional tests are provided for now; existing tests should
4056         provide adequate coverage, and I will add new unit tests for the
4057         MessagePool class when I replace the existing implementation.
4058
4059         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4060         (TestRunInterruptedException.__reduce__):
4061         (Manager.__init__):
4062         (Manager._run_tests):
4063         (Manager._run_tests.instead):
4064         (Manager.handle):
4065         (Manager._handle_started_test):
4066         (Manager._handle_finished_test_list):
4067         (Manager._handle_finished_test):
4068         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
4069         (get):
4070         (_MessagePool):
4071         (_MessagePool.__init__):
4072         (_MessagePool.__enter__):
4073         (_MessagePool.__exit__):
4074         (_MessagePool.run):
4075         (_MessagePool.wait):
4076         (_MessagePool.is_done):
4077         (_MessagePool._worker_is_done):
4078         (_MessagePool._close):
4079         (_MessagePool.handle_done):
4080         (_MessagePool.handle_started_test):
4081         (_MessagePool.handle_finished_test):
4082         (_MessagePool.handle_finished_test_list):
4083         (_MessagePool.handle_exception):
4084         (_MessagePool._log_messages):
4085         (_MessagePool._handle_worker_exception):
4086         (_WorkerState):
4087         (_WorkerState.for):
4088         (_WorkerState.__init__):
4089         (_WorkerState.__repr__):
4090         (_get_broker):
4091         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
4092         (make_broker):
4093
4094 2012-07-11  Simon Fraser  <simon.fraser@apple.com>
4095
4096         Add an option to enter paginated mode in MiniBrowser
4097         https://bugs.webkit.org/show_bug.cgi?id=91035
4098
4099         Reviewed by Dan Bernstein.
4100
4101         Add an item to the Debug menu for MiniBrowser that puts
4102         the web view into paginated mode. For now, we only
4103         do left-to-right pagination, with a fixed column width.
4104
4105         * MiniBrowser/mac/BrowserWindowController.h:
4106         * MiniBrowser/mac/BrowserWindowController.m:
4107         (-[BrowserWindowController validateMenuItem:]): Update the checked
4108         state of the menu item.
4109         (-[BrowserWindowController isPaginated]): Return YES if paginated.
4110         (-[BrowserWindowController togglePaginationMode:]): Toggle in
4111         and out of pagination mode.
4112         * MiniBrowser/mac/MainMenu.xib: Add the debug menu item.
4113
4114 2012-07-11  Adam Barth  <abarth@webkit.org>
4115
4116         commit-queue instances on Compute Engine are missing git-svn
4117         https://bugs.webkit.org/show_bug.cgi?id=91034
4118
4119         Reviewed by Eric Seidel.
4120
4121         git-svn is needed to actually commit to SVN from a git working copy.
4122
4123         * EWSTools/cold-boot.sh:
4124
4125 2012-07-11  Dirk Pranke  <dpranke@chromium.org>
4126
4127         webkitpy: lint code in webkitpy.layout_tests.models
4128         https://bugs.webkit.org/show_bug.cgi?id=90416
4129
4130         Reviewed by Ojan Vafai.
4131
4132         Cleaning up errors reported from lint-webkitpy.
4133
4134         Also, suppress the warnings about wildcard imports in pylintrc;
4135         we have nothing particularly against them.
4136
4137         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4138         (TestConfigurationConverter.combinations):
4139         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
4140         (TestConfigurationTest.test_hash.query_unknown_key):
4141         (TestConfigurationTest.test_eq):
4142         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4143         (ParseError.__init__):
4144         (TestExpectationLine.__init__):
4145         (TestExpectationsModel.get_expectations_string):
4146         (TestExpectationsModel):
4147         (TestExpectationsModel.expectation_to_string):
4148         (TestExpectationsModel.add_expectation_line):
4149         (TestExpectationsModel._clear_expectations_for_test):
4150         (TestExpectationsModel._remove_from_sets):
4151         (TestExpectations.get_expectations_string):
4152         (TestExpectations.expectation_to_string):
4153         (TestExpectations._report_warnings):
4154         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4155         (Base.__init__):
4156         (parse_exp):
4157         (SkippedTests.check):
4158         (TestExpectationParserTests.test_parse_empty_string):
4159         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4160         (FailureTimeout.__init__):
4161         (FailureCrash.__init__):
4162         (FailureImageHashMismatch.__init__):
4163         (FailureReftestMismatch.__init__):
4164         (FailureReftestMismatchDidNotOccur.__init__):
4165         (FailureReftestNoImagesGenerated.__init__):
4166         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
4167         (TestFailuresTest.test_unknown_failure_type.UnknownFailure.message):
4168         (TestFailuresTest.test_unknown_failure_type):
4169         (TestFailuresTest):
4170         (TestFailuresTest.test_message_is_virtual):
4171         * Scripts/webkitpy/layout_tests/models/test_results.py:
4172         (TestResult.loads):
4173         (TestResult.has_failure_matching_types):
4174         * Scripts/webkitpy/pylintrc:
4175
4176 2012-07-11  Dirk Pranke  <dpranke@chromium.org>
4177
4178         nrwt: clean up names in worker.py
4179         https://bugs.webkit.org/show_bug.cgi?id=90510
4180
4181         Reviewed by Ojan Vafai.
4182
4183         This is the last patch in the series of refactoring worker.py;
4184         all this does is change some names of methods, instance
4185         variables, and method parameters to be clearer (it also changes
4186         some code in manager.py and manager_worker.py to be consistent).
4187
4188         There are no functional changes in this patch and the existing
4189         tests should cover everything.
4190
4191         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4192         (Manager.__init__):
4193         (Manager.prepare_lists_and_print_output):
4194         (Manager._run_tests.worker_factory):
4195         (Manager._run_tests):
4196         (Manager._show_results_html_file):
4197         (Manager.handle_finished_test_list):
4198         (_WorkerState.__init__):
4199         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
4200         (_Broker.post_message):
4201         (_Broker._dispatch_message):
4202         (AbstractWorker.__init__):
4203         (AbstractWorker.run):
4204         (AbstractWorker.yield_to_caller):
4205         (AbstractWorker.post):
4206         (_WorkerConnection.__init__):
4207         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
4208         (_TestWorker.__init__):
4209         (_TestWorker.start):
4210         (_TestWorker.handle):
4211         (_TestWorker.stop):
4212         (_TestsMixin):
4213         (_TestsMixin.test_name):
4214         * Scripts/webkitpy/layout_tests/controllers/worker.py:
4215         (Worker.__init__):
4216         (Worker.__del__):
4217         (Worker.start):
4218         (Worker.handle):
4219         (Worker._run_test):
4220         (Worker.stop):
4221         (Worker._timeout):
4222         (Worker._kill_driver):
4223         (Worker._run_test_with_timeout):
4224         (Worker._clean_up_after_test):
4225         (Worker._run_test_in_another_thread.SingleTestThread.run):
4226         (Worker._run_test_in_this_thread):
4227         (Worker._run_single_test):
4228
4229 2012-07-11  Adam Barth  <abarth@webkit.org>
4230
4231         The commit-queue needs some extra git config to be able to commit
4232         https://bugs.webkit.org/show_bug.cgi?id=91025
4233
4234         Reviewed by Eric Seidel.
4235
4236         In order for the commit-queue to actually commit, it needs to know the
4237         location of the SVN server.
4238
4239         * EWSTools/cold-boot.sh:
4240
4241 2012-07-11  Adam Barth  <abarth@webkit.org>
4242
4243         Teach EWSTools how to configure SVN auth credentials
4244         https://bugs.webkit.org/show_bug.cgi?id=91021
4245
4246         Reviewed by Eric Seidel.
4247
4248         To move the commit-queue over to Google Compute Engine, we need a way
4249         to configure the commit-queue's credentials during the machine build
4250         process. There doesn't seem to be a nice command line way of
4251         configuring SVN auth credentials. I tried doing a bogus commit and
4252         supplying the credentials that way, but that's super hacky.
4253
4254         The approach in this patch is to write the config file directly. The
4255         format of these configurations files is documented in the SVN book, so
4256         this approach doesn't see too sketchy.
4257
4258         * EWSTools/configure-svn-auth.sh: Added.
4259
4260 2012-07-11  Ojan Vafai  <ojan@chromium.org>
4261
4262         Dedupe suffixes passed to webkit-patch rebaseline
4263         https://bugs.webkit.org/show_bug.cgi?id=91017
4264
4265         Reviewed by Dirk Pranke.
4266
4267         * Scripts/webkitpy/tool/commands/rebaseline.py:
4268         (Rebaseline._suffixes_to_update):
4269         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4270         (test_rebaseline_multiple_builders_and_tests_command_line):
4271
4272 2012-07-11  Kevin Ollivier  <kevino@theolliviers.com>
4273
4274         [wx] Unreviewed build fix. Add new directories and a new LayoutTestController method.
4275
4276         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4277         (LayoutTestController::setStorageDatabaseIdleInterval):
4278         * waf/build/settings.py:
4279
4280 2012-07-11  Tony Chang  <tony@chromium.org>
4281
4282         [chromium] Remove drag and drop API methods that are no longer used
4283         https://bugs.webkit.org/show_bug.cgi?id=90996
4284
4285         Reviewed by Adam Barth.
4286
4287         Migrate DRT to use the methods that take modifier keys.
4288
4289         * DumpRenderTree/chromium/EventSender.cpp:
4290         (EventSender::doDragDrop):
4291         (EventSender::doMouseUp):
4292         (EventSender::doMouseMove):
4293         (EventSender::beginDragWithFiles):
4294
4295 2012-07-11  Mark Rowe  <mrowe@apple.com>
4296
4297         Add a Mountain Lion version of libWebKitSystemInterface.a.
4298
4299         Reviewed by John Sullivan.
4300
4301         * Scripts/copy-webkitlibraries-to-product-directory: Include libWebKitSystemInterfaceMountainLion.a in the list of libraries to copy.
4302
4303 2012-07-09  Mark Rowe  <mrowe@apple.com>
4304
4305         <http://webkit.org/b/90835> Teach bisect-builds to work with a Safari.app that has entitlements.
4306
4307         Reviewed by Dan Bernstein.
4308
4309         * Scripts/bisect-builds: Use safariPathFromSafariBundle to determine which binary within the application
4310         should be invoked.
4311
4312 2012-07-11  Zan Dobersek  <zandobersek@gmail.com>
4313
4314         [Gtk] fast/events/keydown-function-keys.html is failing
4315         https://bugs.webkit.org/show_bug.cgi?id=90891
4316
4317         Reviewed by Martin Robinson.
4318
4319         Work around the context menu being shown on F10 key being pressed by
4320         unbiding the key when running tests in DumpRenderTree. The problem
4321         appears when using a recent version of the xkeyboard-config package.
4322
4323         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4324         (setDefaultsToConsistentStateValuesForTesting):
4325
4326 2012-07-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
4327
4328         [Qt] QRawWebView should notify when rendering is done, so that pixel results can be grabbed at the appropriate moment.
4329         https://bugs.webkit.org/show_bug.cgi?id=90641
4330
4331         Reviewed by Jocelyn Turcotte.
4332
4333         * MiniBrowser/qt/raw/View.h: Comment used old class name (WKView).
4334         (View):
4335
4336 2012-07-11  Min Qin  <qinmin@chromium.org>
4337
4338         [Android] sending an extra to the DRT apk so that DRT can be run in a seperate thread
4339         https://bugs.webkit.org/show_bug.cgi?id=90831
4340
4341         Reviewed by Adam Barth.
4342
4343         On android, DRT needs to run in a background thread to avoid ANR.
4344         However, the java tests are running on UI thread by default.
4345         We need to send an intent extra to the apk so that it can run on a sub thread.
4346
4347         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4348         (ChromiumAndroidDriver._start_once):
4349
4350 2012-07-11  Csaba Osztrogonác  <ossy@webkit.org>
4351
4352         [Qt] REGRESSION(r107171): Fix --timeout option of Qt's DRT
4353         https://bugs.webkit.org/show_bug.cgi?id=90966
4354
4355         Reviewed by Ryosuke Niwa.
4356
4357         * DumpRenderTree/qt/main.cpp:
4358         (main): Don't remove the argument, because takeOptionValue() did it before.
4359
4360 2012-07-11  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
4361
4362         First commit; moving myself to commiters.
4363
4364         Unreviewed.
4365
4366         * Scripts/webkitpy/common/config/committers.py:
4367
4368 2012-07-11  Balazs Ankes  <bank@inf.u-szeged.hu>
4369
4370         webkit-patch land should automatically add svn:mime-type for .png files
4371         https://bugs.webkit.org/show_bug.cgi?id=75825
4372
4373         Reviewed by Dirk Pranke.
4374
4375         Refactor the png.py to avoid code duplication.
4376
4377         * Scripts/webkitpy/common/checksvnconfigfile.py: Added.
4378         (check):
4379         (config_file_path):
4380         (errorstr_autoprop):
4381         (errorstr_png):
4382         * Scripts/webkitpy/style/checkers/png.py:
4383         (PNGChecker.check):
4384         * Scripts/webkitpy/tool/commands/download.py:
4385         (Land):
4386         * Scripts/webkitpy/tool/steps/__init__.py:
4387         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
4388         (AddSvnMimetypeForPng):
4389         (AddSvnMimetypeForPng.__init__):
4390         (AddSvnMimetypeForPng.run):
4391         (AddSvnMimetypeForPng._check_pngs):
4392         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
4393         (MockSCMDetector):
4394         (MockSCMDetector.__init__):
4395         (MockSCMDetector.display_name):
4396         (AddSvnMimetypeForPngTest):
4397         (AddSvnMimetypeForPngTest.test_run):
4398
4399 2012-07-11  Hayato Ito  <hayato@chromium.org>
4400
4401         Unreviewed gardening.
4402         One more fix for r122292.
4403
4404         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4405
4406 2012-07-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4407
4408         Unreviewed, rolling out r122301.
4409         http://trac.webkit.org/changeset/122301
4410         https://bugs.webkit.org/show_bug.cgi?id=90947
4411
4412         Android builder started to fail (Requested by hayato on
4413         #webkit).
4414
4415         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4416
4417 2012-07-10  Adam Barth  <abarth@webkit.org>
4418
4419         [Chromium] Merge final nits to DumpRenderTree.gyp for Android
4420         https://bugs.webkit.org/show_bug.cgi?id=90920
4421
4422         Reviewed by Tony Chang.
4423
4424         This patch contains the last few small changes to DumpRenderTree.gyp
4425         from the chromium-android branch. After this change, this file will be
4426         fully merged.
4427
4428         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4429
4430 2012-07-10  Adam Barth  <abarth@webkit.org>
4431
4432         [Chromium-Android] Add apk test targets for webkit_unit_tests and TestWebKitAPI
4433         https://bugs.webkit.org/show_bug.cgi?id=90918
4434
4435         Reviewed by Tony Chang.
4436
4437         The rules are similar to what we have added for DumpRenderTree apk.
4438         All references to gtest_target_type can be removed once we enable APK
4439         tests on the all bots.
4440
4441         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4442
4443 2012-07-10  Kenneth Russell  <kbr@google.com>
4444
4445         Add --no-build option to perf test runner
4446         https://bugs.webkit.org/show_bug.cgi?id=90916
4447
4448         Reviewed by Ryosuke Niwa.
4449
4450         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4451         (PerfTestsRunner._parse_args):
4452             Support --no-build option to perf tests, as in layout tests.
4453
4454 2012-07-10  Adam Barth  <abarth@webkit.org>
4455
4456         EWSTools should be able to build a chromium-ews bot from scratch
4457         https://bugs.webkit.org/show_bug.cgi?id=90912
4458
4459         Reviewed by Eric Seidel.
4460
4461         I've been using this script to kick off the build process for the
4462         chromium-ews bots on Google Compute Engine.
4463
4464         * EWSTools/GoogleComputeEngine: Added.
4465         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Added.
4466
4467 2012-07-10  Alec Flett  <alecflett@chromium.org>
4468
4469         Add alecflett to the list of committers
4470         https://bugs.webkit.org/show_bug.cgi?id=90903
4471
4472         Reviewed by Ojan Vafai.
4473
4474         * Scripts/webkitpy/common/config/committers.py:
4475
4476 2012-07-10  Xianzhu Wang  <wangxianzhu@chromium.org>
4477
4478         Unreviewed fix of webkitpy unittest break about chromium_android.py
4479         caused by r122251.
4480
4481         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
4482         (ChromiumAndroidDriverTest.test_cmd_line):
4483
4484 2012-07-10  Ojan Vafai  <ojan@chromium.org>
4485
4486         webkit-patch rebaseline doesn't work for audio/pixel tests
4487         https://bugs.webkit.org/show_bug.cgi?id=90905
4488
4489         Reviewed by Adam Barth.
4490
4491         We just need to pass the correct suffix list to rebaseline-test-internal
4492         and optimize-baselines. By default, pass all suffixes.
4493
4494         * Scripts/webkitpy/tool/commands/rebaseline.py:
4495         (Rebaseline):
4496         (Rebaseline.__init__):
4497         (Rebaseline._suffixes_to_update):
4498         (Rebaseline.execute):
4499         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4500         (test_rebaseline_multiple_builders_and_tests_command_line):
4501
4502 2012-07-10  Adam Barth  <abarth@webkit.org>
4503
4504         Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
4505         https://bugs.webkit.org/show_bug.cgi?id=90853
4506
4507         Reviewed by Eric Seidel.
4508
4509         WebKit no longer implements the Hixie76 version of the WebSocket
4510         protocol. We don't need to support it in our test framework.
4511
4512         * DumpRenderTree/chromium/LayoutTestController.cpp:
4513         (LayoutTestController::overridePreference):
4514         * DumpRenderTree/chromium/WebPreferences.cpp:
4515         (WebPreferences::reset):
4516         (WebPreferences::applyTo):
4517         * DumpRenderTree/chromium/WebPreferences.h:
4518         (WebPreferences):
4519         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4520         (resetDefaultsToConsistentValues):
4521         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4522         (LayoutTestController::overridePreference):
4523         * DumpRenderTree/mac/DumpRenderTree.mm:
4524         (resetDefaultsToConsistentValues):
4525         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4526         (WebCore::WebPage::resetSettings):
4527         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4528         (LayoutTestController::overridePreference):
4529         * DumpRenderTree/win/DumpRenderTree.cpp:
4530         (resetDefaultsToConsistentValues):
4531
4532 2012-07-10  Xianzhu Wang  <wangxianzhu@chromium.org>
4533
4534         [Chromium-Android] Fix typos in chromium_android.py in r151492
4535         https://bugs.webkit.org/show_bug.cgi?id=90904
4536
4537         Reviewed by Ojan Vafai.
4538
4539         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4540         (ChromiumAndroidPort.setup_test_run):
4541
4542 2012-07-10  Xianzhu Wang  <wangxianzhu@chromium.org>
4543
4544         [Chromium-Android] Use setup_test_runner() instead of start_helper() to setup test environment
4545         https://bugs.webkit.org/show_bug.cgi?id=90894
4546
4547         Reviewed by Adam Barth.
4548
4549         start_helper() is actually start_pixel_test_helper() since r115601 (bug 81729).
4550         Should use setup_test_runner() to setup test environment for chromium-android.
4551
4552         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4553         (ChromiumAndroidPort.setup_test_run): Renamed from start_helper(). Added cache cleanup code.
4554         (ChromiumAndroidPort.clean_up_test_run): Renamed from stop_helper().
4555         (ChromiumAndroidPort._path_to_helper): Returns None as we don't have a helper now.
4556         (ChromiumAndroidPort):
4557         (ChromiumAndroidPort._path_to_forwarder): Original _path_to_helper().
4558         (ChromiumAndroidPort._push_executable):
4559         (ChromiumAndroidDriver.__init__):
4560         (ChromiumAndroidDriver.cmd_line):
4561
4562 2012-07-09  Ojan Vafai  <ojan@chromium.org>
4563
4564         Improve webkit-patch rebaseline to work for more cases
4565         https://bugs.webkit.org/show_bug.cgi?id=90504
4566
4567         Reviewed by Adam Barth.
4568
4569         -Makes it work for the build.chromium.org bots.
4570         -Lets you rebaseline all builders instead of just one.
4571         -Lets you pass in the builders or tests to rebaseline.
4572
4573         * Scripts/webkitpy/common/host.py:
4574         (Host.buildbot_for_builder_name):
4575         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4576         (Builder.__init__):
4577         (Builder.latest_layout_test_results):
4578         Provide a way to get to the LayoutTestResults of the latest build.
4579         Most of the time we only need to get the latest one and the Chromium bots
4580         only expose the full_results.json file for the latest build.
4581
4582         (Builder):
4583         (Builder._fetch_file_from_results):
4584         (Builder.fetch_layout_test_results):
4585         Move these functions into Builder so that Builder and Build can both
4586         fetch layout test results.
4587
4588         (Build.results_zip_url):
4589         (Build.layout_test_results):
4590         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4591         (BuilderTest.test_latest_layout_test_results):
4592         (BuildTest.test_layout_test_results):
4593         * Scripts/webkitpy/common/system/user.py:
4594         (User.prompt_with_multiple_lists):
4595         Prompt with multiple sublists, but still have a global numbering.
4596         This lets the build.chromium.org bots be clearly separated from the
4597         build.webkit.org bots, which helps understand the builder names.
4598
4599         (User):
4600         (User._wait_on_list_response):
4601         (User.prompt_with_list):
4602         * Scripts/webkitpy/common/system/user_unittest.py:
4603         (UserTest.test_prompt_with_multiple_lists):
4604         (UserTest.test_prompt_with_multiple_lists.run_prompt_test):
4605         (UserTest.test_prompt_with_multiple_lists.run_prompt_test.mock_raw_input):
4606         * Scripts/webkitpy/layout_tests/port/base.py:
4607         (Port.is_chromium):
4608         Provide a way to tell if a port is a Chromium port that doesn't involve string
4609         manipulation on the port name or builder name.
4610
4611         * Scripts/webkitpy/layout_tests/port/builders.py:
4612         (builder_path_from_name):
4613         (all_builder_names):
4614         Memoizing here is incorrect because the test override _exact_matches,
4615         so these can return different values. In either case, I'm pretty sure these
4616         are not remotely hot codepaths. I manually inspected all call sites and they're
4617         all in high-level calls (e.g. execute calls for webkit-patch commands) and not
4618         called in a loop.
4619
4620         * Scripts/webkitpy/layout_tests/port/chromium.py:
4621         (ChromiumPort.is_chromium):
4622         * Scripts/webkitpy/tool/commands/rebaseline.py:
4623         (RebaselineTest._results_url):
4624         (AbstractParallelRebaselineCommand.__init__):
4625         (Rebaseline.__init__):
4626         (Rebaseline):
4627         (Rebaseline._builders_to_pull_from):
4628         (Rebaseline._tests_to_update):
4629         (Rebaseline.execute):
4630         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4631         (test_rebaseline.mock_builders_to_pull_from):
4632         (test_rebaseline):
4633         (test_rebaseline_command_line_flags):
4634         (test_rebaseline_multiple_builders):
4635         (test_rebaseline_multiple_builders.mock_builders_to_pull_from):
4636         (test_rebaseline_multiple_builders.mock_tests_to_update):
4637         (test_rebaseline_multiple_builders_and_tests_command_line):
4638         * Scripts/webkitpy/tool/mocktool.py:
4639         (MockTool.irc):
4640         (MockTool):
4641         (MockTool.buildbot_for_builder_name):
4642
4643 2012-07-10  Alice Cheng  <alice_cheng@apple.com>
4644
4645         Editing: Reproducible crasher when pasting a 0x0 image into Mail
4646         https://bugs.webkit.org/show_bug.cgi?id=90640
4647         <rdar://problem/11141920>
4648
4649         Reviewed by Brady Eidson.
4650
4651         Test cases for the patch. 0x0 images don't get a resource representation in the WebArchive, so we need a null check.
4652
4653         * TestWebKitAPI/Tests/mac/0.png: Added.
4654         * TestWebKitAPI/Tests/mac/WebViewCanPasteZeroPng.mm: Added.
4655         (TestWebKitAPI):
4656         (TestWebKitAPI::TEST):
4657
4658 2012-07-10  Leandro Gracia Gil  <leandrogracia@chromium.org>
4659
4660         WebSurroundingText layout tests should use the same code path as the rest of the feature.
4661         https://bugs.webkit.org/show_bug.cgi?id=90807
4662
4663         Reviewed by Adam Barth.
4664
4665         Make the textSurroundingNode method take a pair of point coordinates
4666         instead of a node offset.
4667
4668         * DumpRenderTree/chromium/LayoutTestController.cpp:
4669         (LayoutTestController::textSurroundingNode):
4670         * DumpRenderTree/chromium/LayoutTestController.h:
4671         (LayoutTestController):
4672
4673 2012-07-10  Csaba Osztrogonác  <ossy@webkit.org>
4674
4675         [Qt] REGRESSION(r122175): It broke the Windows build
4676         https://bugs.webkit.org/show_bug.cgi?id=90850
4677
4678         Reviewed by Noam Rosenthal.
4679
4680         * qmake/mkspecs/features/features.prf: Disable USE(3D_GRAPHICS) on Windows temporarily until proper fix.
4681
4682 2012-07-10  János Badics  <jbadics@inf.u-szeged.hu>
4683
4684         [Qt][NRWT] Enable cascaded TestExpectations
4685         https://bugs.webkit.org/show_bug.cgi?id=89108
4686
4687         Reviewed by Dirk Pranke.
4688
4689         * Scripts/webkitpy/layout_tests/port/qt.py:
4690         (QtPort.expectations_files):
4691         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4692         (QtPortTest._assert_expectations_files):
4693         (QtPortTest.test_expectations_files):
4694
4695 2012-07-10  Christophe Dumez  <christophe.dumez@intel.com>
4696
4697         [EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::*
4698         https://bugs.webkit.org/show_bug.cgi?id=90868
4699
4700         Unreviewed EFL build fix.
4701
4702         Correct CMake configuration to have EFL's DRT and WebKitTestRunner link
4703         WTF library. This is needed to resolve undefined reference to WTF::MD5::*.
4704
4705         * DumpRenderTree/efl/CMakeLists.txt:
4706         * WebKitTestRunner/PlatformEfl.cmake:
4707
4708 2012-07-10  Adam Barth  <abarth@webkit.org>
4709
4710         LayoutTestController.dumpConfigurationForViewport should move to Internals
4711         https://bugs.webkit.org/show_bug.cgi?id=45652
4712
4713         Reviewed by Eric Seidel.
4714
4715         Remove dumpConfigurationForViewport from LayoutTestController. This API
4716         has been replaced by an API on Internals that does the same thing in a
4717         port-agnostic way.
4718
4719         * DumpRenderTree/LayoutTestController.cpp:
4720         (LayoutTestController::staticFunctions):
4721         * DumpRenderTree/LayoutTestController.h:
4722         (LayoutTestController):
4723         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
4724         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4725         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4726         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4727         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4728         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4729         (LayoutTestController):
4730         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4731         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4732
4733 2012-07-09  Matt Falkenhagen  <falken@chromium.org>
4734
4735         Add ENABLE_DIALOG_ELEMENT and skeleton files
4736         https://bugs.webkit.org/show_bug.cgi?id=90521
4737
4738         Reviewed by Kent Tamura.
4739
4740         * Scripts/webkitperl/FeatureList.pm:
4741
4742 2012-07-09  Kent Tamura  <tkent@chromium.org>
4743
4744         Improve the boilerplate generated by prepare-ChangeLog
4745         https://bugs.webkit.org/show_bug.cgi?id=89560
4746
4747         Reviewed by Ryosuke Niwa.
4748
4749         Produce the following boilerplate:
4750
4751         > 2012-06-20  Kent Tamura  <tkent@chromium.org>
4752         >
4753         >         Need a short description (Oops!).
4754         >         Need the bug URL (Oops!).
4755         >
4756         >         Reviewed by NOBODY (Oops!).
4757         >
4758         >         Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
4759         >
4760         >         No new tests (Oops!).
4761
4762         * Scripts/prepare-ChangeLog:
4763         (generateNewChangeLogs): Generate the updated template.
4764         * Scripts/webkitpy/common/checkout/changelog.py:
4765         (ChangeLog.update_with_unreviewed_message):
4766         Update the pattern for the beginning of the boilerplate.
4767         (ChangeLog.set_short_description_and_bug_url):
4768         - Use self._changelog_indent
4769         - Update the pattern for the description line
4770         - Skip the bug boilerplate.
4771         We substitute the specified bug URL to the description boilerplate
4772         because we need to add it even if the bug URL boilerplate is missing.
4773         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Update the boilerplate data.
4774         (test_set_short_description_and_bug_url):
4775         - Update the description boilerplate.
4776         - Add a test for a case with both of the description boilerplace and the
4777           bug URL boilerplate.
4778         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
4779         (PrepareChangeLogTest.test_ensure_bug_url): Update the expected boilerplate.
4780
4781 2012-07-09  No'am Rosenthal  <noam.rosenthal@nokia.com>
4782
4783         Shared code that is guarded with ENABLE(WEBGL) should be guarded with USE()
4784         https://bugs.webkit.org/show_bug.cgi?id=90506
4785
4786         Reviewed by Martin Robinson.
4787
4788         Always enable the WTF_USE_3D_GRAPHICS flag in features.prf if we're compiling with Qt5
4789         or if the OpenGL module is enabled.
4790
4791         * qmake/mkspecs/features/features.prf:
4792
4793 2012-07-09  Yongjun Zhang  <yongjun_zhang@apple.com>
4794
4795         Consider closing unused localStorage database after a timeout.
4796         https://bugs.webkit.org/show_bug.cgi?id=90713
4797
4798         For a localStorage, if there is no active document referencing to it for certain amount of time (300 seconds),
4799         we can close the underlying sqlite database.
4800
4801         Reviewed by Brady Eidson.
4802
4803         * DumpRenderTree/LayoutTestController.cpp: add a JS method setStorageDatabaseIdleInterval to testRunner
4804             to set a different timeout value for closing localStorage database.
4805         (setStorageDatabaseIdleIntervalCallback):
4806         (LayoutTestController::staticFunctions):
4807         * DumpRenderTree/LayoutTestController.h:
4808         (LayoutTestController):
4809         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4810         (LayoutTestController::setStorageDatabaseIdleInterval): add empty method.
4811         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4812         (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
4813         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4814         (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
4815         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4816         (LayoutTestController::setStorageDatabaseIdleInterval): ditto.
4817
4818 2012-07-09  Adam Klein  <adamk@chromium.org>
4819
4820         Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver
4821         https://bugs.webkit.org/show_bug.cgi?id=90810
4822
4823         Reviewed by Ojan Vafai.
4824
4825         * DumpRenderTree/gtk/EventSender.cpp:
4826
4827 2012-07-09  Mihai Parparita  <mihaip@chromium.org>
4828
4829         Handle missing results in TestResultsServer better
4830         https://bugs.webkit.org/show_bug.cgi?id=90816
4831
4832         Reviewed by Ojan Vafai.
4833
4834         If we can't load the results JSON, don't try to wrap it with the JSONP
4835         callback invocation.
4836
4837         * TestResultServer/handlers/testfilehandler.py:
4838         (GetFile.get):
4839
4840 2012-07-09  Sheriff Bot  <webkit.review.bot@gmail.com>
4841
4842         Unreviewed, rolling out r122124.
4843         http://trac.webkit.org/changeset/122124
4844         https://bugs.webkit.org/show_bug.cgi?id=90815
4845
4846         It broke NRWT on Qt (Requested by Ossy_HOME on #webkit).
4847
4848         * Scripts/webkitpy/layout_tests/port/qt.py:
4849         (QtPort._skipped_file_search_paths):
4850         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4851         (QtPortTest._assert_skipped_path):
4852         (QtPortTest.test_skipped_file_search_path):
4853
4854 2012-07-09  Zan Dobersek  <zandobersek@gmail.com>
4855
4856         [Gtk] Implement dumpFrameScrollPosition in DumpRenderTree
4857         https://bugs.webkit.org/show_bug.cgi?id=89356
4858
4859         Reviewed by Martin Robinson.
4860
4861         Implement dumpFrameScrollPosition, acquiring the scroll position
4862         through WebKitDOMDOMWindow of the WebKitDOMDocument loaded in the frame
4863         whose scroll position is being dumped.
4864
4865         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4866         (dumpFrameScrollPosition):
4867
4868 2012-07-09  János Badics  <jbadics@inf.u-szeged.hu>
4869
4870         [Qt][NRWT] Enable cascaded TestExpectations
4871         https://bugs.webkit.org/show_bug.cgi?id=89108
4872
4873         Reviewed by Dirk Pranke.
4874
4875         * Scripts/webkitpy/layout_tests/port/qt.py:
4876         (QtPort.expectations_files):
4877         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4878         (QtPortTest._assert_expectations_files):
4879         (QtPortTest.test_expectations_files):
4880
4881 2012-07-09  Dan Bernstein  <mitz@apple.com>
4882
4883         Fixed clean builds of the All target in the DumpRenderTree project.
4884
4885         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode know that the
4886         DumpRenderTree Perl Support target depends on the DumpRenderTree target.
4887
4888 2012-07-09  Zan Dobersek  <zandobersek@gmail.com>
4889
4890         [Gtk] Unskip the CSS Regions layout tests
4891         https://bugs.webkit.org/show_bug.cgi?id=90771
4892
4893         Reviewed by Martin Robinson.
4894
4895         Use the DumpRenderTreeSupportGtk method for enabling the CSS Regions,
4896         calling it when resetting the defaults in DumpRenderTree or when the
4897         settings value is overriden through the testRunner.
4898
4899         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4900         (resetDefaultsToConsistentValues):
4901         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4902         (LayoutTestController::overridePreference):
4903
4904 2012-07-09  Sheriff Bot  <webkit.review.bot@gmail.com>
4905
4906         Unreviewed, rolling out r122107.
4907         http://trac.webkit.org/changeset/122107
4908         https://bugs.webkit.org/show_bug.cgi?id=90794
4909
4910         Build failure on Mac debug bots (Requested by falken_ on
4911         #webkit).
4912
4913         * Scripts/webkitperl/FeatureList.pm:
4914
4915 2012-07-09  Matt Falkenhagen  <falken@chromium.org>
4916
4917         Add ENABLE_DIALOG_ELEMENT and skeleton files
4918         https://bugs.webkit.org/show_bug.cgi?id=90521
4919
4920         Reviewed by Kent Tamura.
4921
4922         * Scripts/webkitperl/FeatureList.pm:
4923
4924 2012-07-08  Kent Tamura  <tkent@chromium.org>
4925
4926         Unreviewed, rolling out r122076.
4927         http://trac.webkit.org/changeset/122076
4928         https://bugs.webkit.org/show_bug.cgi?id=89560
4929
4930         Broke sheriffbot rollout
4931
4932         * Scripts/prepare-ChangeLog:
4933         (generateNewChangeLogs):
4934
4935 2012-07-08  Leandro Gracia Gil  <leandrogracia@chromium.org>
4936
4937         Update the description of LayoutTestController::textSurroundingElement
4938         https://bugs.webkit.org/show_bug.cgi?id=90620
4939
4940         Reviewed by Adam Barth.
4941
4942         Rename and fix the description of the method as its behaviour changed
4943         during the review of https://bugs.webkit.org/show_bug.cgi?id=82461
4944
4945         * DumpRenderTree/chromium/LayoutTestController.cpp:
4946         (LayoutTestController::LayoutTestController):
4947         (LayoutTestController::textSurroundingNode):
4948         * DumpRenderTree/chromium/LayoutTestController.h:
4949         (LayoutTestController):
4950
4951 2012-07-08  Kent Tamura  <tkent@chromium.org>
4952
4953         Improve the template generated by prepare-ChangeLog
4954         https://bugs.webkit.org/show_bug.cgi?id=89560
4955
4956         Reviewed by Ryosuke Niwa.
4957
4958         Produce the following template:
4959
4960         > 2012-06-20  Kent Tamura  <tkent@chromium.org>
4961         >
4962         >         Need a short description (Oops!).
4963         >         Need the bug URL (Oops!).
4964         >
4965         >         Reviewed by Ryosuke Niwa.
4966         >
4967         >         Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).
4968         >
4969         >         No new tests (Oops!).
4970
4971         * Scripts/prepare-ChangeLog:
4972         (generateNewChangeLogs):
4973
4974 2012-07-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4975
4976         [wx] Unreviewed. Fix notificaitons directory path after notifications move.
4977
4978         * waf/build/settings.py:
4979
4980 2012-07-07  Nuno Lopes  <nlopes@apple.com>
4981
4982         Fix build with recent clang.
4983         https://bugs.webkit.org/show_bug.cgi?id=90712
4984
4985         Reviewed by Alexey Proskuryakov.
4986
4987         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4988         (DOMWindowExtensionBasic):
4989         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
4990         (DOMWindowExtensionNoCache):
4991         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
4992         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
4993
4994 2012-07-06  Zan Dobersek  <zandobersek@gmail.com>
4995
4996         [Gtk] Add a configuration option for disabling unstable features in releases
4997         https://bugs.webkit.org/show_bug.cgi?id=87995
4998
4999         Reviewed by Martin Robinson.
5000
5001         Pass the --enable-unstable-features flag when building the Gtk port through build-webkit.
5002
5003         * Scripts/webkitdirs.pm:
5004         (buildAutotoolsProject):
5005
5006 2012-07-06  Jessie Berlin  <jberlin@apple.com>
5007
5008         WKContext should ask for its initialization data when it needs it so the client doesn't have
5009         to keep it up to date.
5010         https://bugs.webkit.org/show_bug.cgi?id=90627
5011
5012         Reviewed by Anders Carlsson.
5013
5014         Add tests and update other WKContextInjectedBundleClients.
5015
5016         * MiniBrowser/mac/AppDelegate.m:
5017         (-[BrowserAppDelegate init]):
5018         Updated for the change to WKContextInjectedBundleClient.
5019         * WebKitTestRunner/TestController.cpp:
5020         (WTR::TestController::initialize):
5021         Ditto.
5022
5023         * TestWebKitAPI/PlatformUtilities.cpp:
5024         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
5025         Moved the logic to create the initialization dictionary here ...
5026         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
5027         ... from here so that it can be used without automatically using
5028         WKContextSetInitializationUserDataForInjectedBundle.
5029         * TestWebKitAPI/PlatformUtilities.h:
5030
5031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5032         Add the new test files.
5033         * TestWebKitAPI/GNUmakefile.am:
5034         Ditto.
5035
5036         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Added.
5037         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
5038         Check that the message received from the injected bundle matches the user data it was
5039         initialized with.
5040         (TestWebKitAPI::getInjectedBundleInitializationUserData):
5041         Return the user data that the injected bundle should be initialized with.
5042         (TestWebKitAPI::TEST):
5043         Set up WKContextInjectedBundleClient and load a page.
5044         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Added.
5045         (TestWebKitAPI::GetInjectedBundleInitializationUserDataCallbackTest::initialize):
5046         Send the initialization user data back up to the UI Process.
5047
5048         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Added.
5049         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
5050         Check that the message received from the injected bundle matches the user data it was
5051         initialized with in the callback.
5052         (TestWebKitAPI::getInjectedBundleInitializationUserData):
5053         Return the user data that the injected bundle should be initialized with.
5054         (TestWebKitAPI::TEST):
5055         Set up the context and use WKContextSetInitializationUserDataForInjectedBundle to set the
5056         initialization user data (which should be overridden by the user data returned in
5057         getInjectedBundleInitializationUserData).
5058         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Added.
5059         (TestWebKitAPI::InjectedBundleInitializationUserDataCallbackWinsTest::initialize):
5060         Send the initialization user data back up to the UI Process.
5061
5062 2012-07-06  Dongwoo Im  <dw.im@samsung.com>
5063
5064         [EFL][GTK] jhbuild : Disable pixman demos build depending on GTK+
5065         https://bugs.webkit.org/show_bug.cgi?id=90593
5066
5067         Reviewed by Philippe Normand.
5068
5069         * efl/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
5070         * gtk/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
5071
5072 2012-07-06  Luciano Wolf <luciano.wolf@openbossa.org>
5073
5074         [Qt] DumpRenderTree does not use 'monospace' font when directed
5075         https://bugs.webkit.org/show_bug.cgi?id=85203
5076
5077         The test fonts used for Qt tests were moved to the Liberation font family.
5078
5079         Due to this change we are skipping tons of tests. They will be gradually
5080         unskipped in batches, ASAP.
5081
5082         Also, the now unneeded special font configuration for Qt5 WK1 was removed.
5083
5084         Reviewed by Tor Arne Vestbø.
5085
5086         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
5087         (WebKit::initializeTestFonts):
5088
5089 2012-07-06  Csaba Osztrogonác  <ossy@webkit.org>
5090
5091         [Qt] Buildfix for newer Qt5
5092         https://bugs.webkit.org/show_bug.cgi?id=90519
5093
5094         Reviewed by Tor Arne Vestbø.
5095
5096         * MiniBrowser/qt/MiniBrowser.pro: We also need to depend on gui-private in the MiniBrowser to get access to these headers.
5097         * MiniBrowser/qt/MiniBrowserApplication.h: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
5098         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
5099
5100 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
5101
5102         [Qt] Make use of Qt5 qmake's changed makefile recursion behavior
5103
5104         When not using the -r option, qmake now interleaves qmake and make calls,
5105         so we don't need custom logic for this. There's also an option to supress
5106         the effect of the -r option, which we use to make WebKit.pro the only
5107         project file parsed in a recursive qmake-run.
5108
5109         https://bugs.webkit.org/show_bug.cgi?id=90461
5110
5111         Reviewed by Tor Arne Vestbø.
5112
5113         * qmake/mkspecs/features/default_post.prf:
5114         * qmake/mkspecs/features/functions.prf:
5115
5116 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
5117
5118         [Qt] Remove custom qmake logic for module creation
5119
5120         Qmake now has the necessary hooks to cleanly override the build locations.
5121
5122         https://bugs.webkit.org/show_bug.cgi?id=90461
5123
5124         Reviewed by Tor Arne Vestbø.
5125
5126         * qmake/mkspecs/features/default_pre.prf:
5127
5128 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
5129
5130         [Qt] Add top-level .qmake.conf
5131
5132         With Qt5, this makes setting $QMAKEPATH externally unnecessary.
5133
5134         The magic in the perl scripts to set QMAKEPATH is still there, as it doesn't
5135         hurt, and is still required for Qt4.
5136
5137         https://bugs.webkit.org/show_bug.cgi?id=90461
5138
5139         Reviewed by Tor Arne Vestbø.
5140
5141         * qmake/mkspecs/features/default_pre.prf:
5142
5143 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
5144
5145         [Qt] Unify qtFeatureDefaults code paths
5146
5147         There's no reason to run qmake on features.prf directly anymore, as we
5148         can selectivly run configure tests in the project file now.
5149
5150         https://bugs.webkit.org/show_bug.cgi?id=90461
5151
5152         Reviewed by Tor Arne Vestbø.
5153
5154         * Scripts/webkitdirs.pm:
5155         (qtFeatureDefaults):
5156         * qmake/configure.pri:
5157         * qmake/mkspecs/features/features.prf:
5158
5159 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
5160
5161         [Qt] Don't let qt_webkit.pri proclaim its own location
5162
5163         This won't work any more with recent Qt5 versions, as the forwarding
5164         pri is created by qt_module_config, which needs MODULE_PRI to be set
5165         up already.
5166
5167         We also need to load build_config, not qt_module.
5168
5169         https://bugs.webkit.org/show_bug.cgi?id=90461
5170
5171         Reviewed by Tor Arne Vestbø.
5172
5173         * qmake/qt_webkit.pri:
5174
5175 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
5176
5177         [Qt] Remove redundant CONFIG+=module
5178
5179         qt_module_config takes care of that.
5180
5181         In api.pri we are actually testing the flag ourselves, so now we need to
5182         test a related flag qt_module_config sets instead.
5183
5184         Reviewed by Tor Arne Vestbø.
5185
5186         * qmake/mkspecs/features/default_post.prf:
5187
5188 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
5189
5190         [Qt] Switch to new-style Qt 5 configure tests
5191
5192         Use explicit project file action instead of syncqt magic.
5193
5194         https://bugs.webkit.org/show_bug.cgi?id=90461
5195
5196         Reviewed by Tor Arne Vestbø.
5197
5198         * Scripts/webkitdirs.pm:
5199         (buildQMakeProjects):
5200         * qmake/configure.pri: Copied from Tools/qmake/configure.pro.
5201         * qmake/configure.pro:
5202         * qmake/mkspecs/features/default_pre.prf:
5203         * qmake/mkspecs/features/features.prf:
5204         * qmake/sync.profile: Removed.
5205
5206 2012-07-05  Jason Liu  <jason.liu@torchmobile.com.cn>
5207
5208         Add Jason Liu to committers.py.
5209         https://bugs.webkit.org/show_bug.cgi?id=90654
5210
5211         Unreviewed.
5212
5213         * Scripts/webkitpy/common/config/committers.py:
5214
5215 2012-07-05  Benjamin Poulain  <bpoulain@apple.com>
5216
5217         Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
5218         https://bugs.webkit.org/show_bug.cgi?id=90431
5219
5220         Reviewed by Anders Carlsson.
5221
5222         Add a Mac API test.
5223
5224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
5225         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html: Added.
5226         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm: Added.
5227         (-[CancelLoadFromResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
5228         (-[CancelLoadFromResourceLoadDelegateFrameLoadDelegate webView:didFinishLoadForFrame:]):
5229         (TestWebKitAPI):
5230         (TestWebKitAPI::TEST):
5231
5232 2012-07-05  Dave Tharp  <dtharp@codeaurora.org>
5233
5234         Adding myself as committer to committers.py
5235
5236         Unreviewed.
5237
5238         * Scripts/webkitpy/common/config/committers.py:
5239
5240 2012-07-05  Alexey Proskuryakov  <ap@apple.com>
5241
5242         [Mac][WK2] Enable HTTPS tests
5243         https://bugs.webkit.org/show_bug.cgi?id=90600
5244
5245         Reviewed by Brady Eidson.
5246
5247         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.
5248         It explained why we were doing this here instead of a frame load delegate, but that's
5249         just history, not an explanation of why we need this code.
5250
5251         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
5252         Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
5253         for tests, it seems appropriate to have platform specific solutions in every WTR,
5254         and not add a WebKit2 API.
5255
5256 2012-07-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5257
5258         [Qt] Remove rpath-hacks in qt_webkit.pri
5259
5260         Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
5261         even if they were not using QtWebKit.
5262
5263         This is a regression for people who build client apps against a non-installed
5264         QtWebKit, as the client app will be missing a rpath to the standalone WebKit
5265         build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
5266         logic, until the real issue is fixed in Qt.
5267
5268         Reviewed by Csaba Osztrogonác.
5269
5270         * qmake/mkspecs/features/rpath.prf:
5271         * qmake/qt_webkit.pri:
5272
5273 2012-07-05  Dongwoo Im  <dw.im@samsung.com>
5274
5275         [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
5276         https://bugs.webkit.org/show_bug.cgi?id=88608
5277
5278         Reviewed by Hajime Morita.
5279
5280         * Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.
5281
5282 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
5283
5284         [Wk2][EFL] EFL needs a WebKitTestRunner
5285         https://bugs.webkit.org/show_bug.cgi?id=87659
5286
5287         Reviewed by Kenneth Rohde Christiansen.
5288
5289         Add an implementation of WebKitTestRunner for Efl port.
5290
5291         * CMakeLists.txt: Includes WebKitTestRunner build script.
5292         * Scripts/build-webkittestrunner: Added knowledge of WebKitTestRunner/Efl.
5293         * Scripts/webkitpy/layout_tests/port/efl.py: Ditto.
5294         (EflPort.setup_environ_for_server):
5295         * WebKitTestRunner/CMakeLists.txt: Added.
5296         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
5297         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Added.
5298         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
5299         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Added.
5300         * WebKitTestRunner/PlatformEfl.cmake: Added.
5301         * WebKitTestRunner/PlatformWebView.h:
5302         * WebKitTestRunner/TestController.cpp:
5303         * WebKitTestRunner/config.h: Added knowledge of WebKitTestRunner/Efl.
5304         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Added.
5305         * WebKitTestRunner/efl/TestControllerEfl.cpp: Added.
5306         * WebKitTestRunner/efl/main.cpp: Added.
5307         (main):
5308
5309 2012-07-05  Christophe Dumez  <christophe.dumez@intel.com>
5310
5311         [WK2][EFL] Ewk_View needs API to load HTML data
5312         https://bugs.webkit.org/show_bug.cgi?id=90540
5313
5314         Reviewed by Kenneth Rohde Christiansen.
5315
5316         Update EFL MiniBrowser to catch the "load,error" signal
5317         on the view and display an error page.
5318
5319         * MiniBrowser/efl/main.c:
5320         (on_error):
5321         (browserCreate):
5322
5323 2012-07-05  Sergio Villar Senin  <svillar@igalia.com>
5324
5325         Hidden dirs are not copied when creating the built product archive
5326         https://bugs.webkit.org/show_bug.cgi?id=90559
5327
5328         Reviewed by Carlos Garcia Campos.
5329
5330         Hidden dirs are not copied inside the built product archive
5331         because the recursive copy command was ignoring them. We need those
5332         hidden directories for the GTK WebKit2 testing bot to work fine.
5333
5334         * BuildSlaveSupport/built-product-archive:
5335         (archiveBuiltProduct): replaced "*" by "." to include hidden
5336         dirs/files.
5337
5338 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
5339
5340         Unreviewed Chromium gardening, Disable always failed python tests on Windows.
5341         https://bugs.webkit.org/show_bug.cgi?id=90587
5342
5343         PortTest.qt_linux and mac_lion are always failed on Chromium Windows at
5344         creating child process.
5345
5346         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
5347         (PortTest.disabled_test_qt_linux):
5348         (PortTest.disabled_test_mac_lion):
5349
5350 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
5351
5352         [Tools] webkit_unittest.py got assertion
5353         https://bugs.webkit.org/show_bug.cgi?id=90579
5354
5355         Reviewed by Hajime Morita.
5356
5357         This patch updates expectation of assertion in test_skipped_directories_for_symbols().
5358         r121874 added new (exclude) directory (inspector/styles/variables), however it didn't
5359         update one of two assertions.
5360
5361         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
5362
5363 2012-07-04  Balazs Ankes  <bank@inf.u-szeged.hu>
5364
5365         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
5366         https://bugs.webkit.org/show_bug.cgi?id=67935
5367
5368         Reviewed by Ryosuke Niwa.
5369
5370         * Scripts/webkitpy/common/checkout/changelog.py:
5371         (ChangeLog.set_reviewer):
5372         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
5373         (test_set_reviewer):
5374         (test_set_short_description_and_bug_url):
5375
5376 2012-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
5377
5378         Unreviewed, rolling out r121862.
5379         http://trac.webkit.org/changeset/121862
5380         https://bugs.webkit.org/show_bug.cgi?id=90569
5381
5382         It broke built-product-archive for GTK, Qt and EFL (Requested
5383         by svillar on #webkit).
5384
5385         * BuildSlaveSupport/built-product-archive:
5386         (archiveBuiltProduct):
5387
5388 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
5389
5390         Hidden dirs are not copied when creating the built product archive
5391         https://bugs.webkit.org/show_bug.cgi?id=90559
5392
5393         Reviewed by Carlos Garcia Campos.
5394
5395         Hidden dirs are not copied inside the built product archive because
5396         the recursive copy command was ignoring them. We need those hidden
5397         directories for the GTK WebKit2 testing bot to work fine.
5398
5399         * BuildSlaveSupport/built-product-archive:
5400         (archiveBuiltProduct): removed the trailing "*" from the copy
5401         command.
5402
5403 2012-07-04  John Mellor  <johnme@chromium.org>
5404
5405         Text Autosizing: Add compile flag and runtime setting
5406         https://bugs.webkit.org/show_bug.cgi?id=87394
5407
5408         This patch renames Font Boosting to Text Autosizing.
5409
5410         Reviewed by Adam Barth.
5411
5412         * Scripts/webkitperl/FeatureList.pm:
5413         * qmake/mkspecs/features/features.pri:
5414
5415 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5416
5417         [Qt] Replace deprecated IN_PWD with PWD
5418
5419         Reviewed by Csaba Osztrogonác.
5420
5421         * qmake/mkspecs/features/default_pre.prf:
5422
5423 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5424
5425         [Qt] Don't try to build WTR twice
5426
5427         Reviewed by Csaba Osztrogonác.
5428
5429         * Tools.pro:
5430
5431 2012-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
5432
5433         Unreviewed, rolling out r121821.
5434         http://trac.webkit.org/changeset/121821
5435         https://bugs.webkit.org/show_bug.cgi?id=90551
5436
5437         This patch did not receive a high-quality review and has a
5438         number of errors (Requested by abarth on #webkit).
5439
5440         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
5441         (Build.results_url):
5442         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
5443         (ChromiumBuilder.accumulated_results_url):
5444         * Scripts/webkitpy/layout_tests/port/builders.py:
5445         * Scripts/webkitpy/tool/commands/rebaseline.py:
5446         (AbstractParallelRebaselineCommand.__init__):
5447         (Rebaseline):
5448         (Rebaseline._builder_to_pull_from):
5449         (Rebaseline._tests_to_update):
5450         (Rebaseline.execute):
5451         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
5452         (test_rebaseline.mock_builder_to_pull_from):
5453         (test_rebaseline):
5454
5455 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5456
5457         [Qt] Get rid of un-needed QT += declarative for Qt 5
5458
5459         The declarative module has been renamed to quick1 in Qt 5, and the
5460         engine-only module for Qt 5 is named 'qml'. For many of the instances
5461         we could just remove 'declarative', since the project file was only
5462         used for Qt5/WebKit2 builds. In the other cases the module was wrapped
5463         in a haveQt(4) scope.
5464
5465         Reviewed by Csaba Osztrogonác.
5466
5467         * MiniBrowser/qt/MiniBrowser.pro:
5468         * WebKitTestRunner/InjectedBundle/Target.pri:
5469         * WebKitTestRunner/Target.pri:
5470
5471 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5472
5473         [Qt] Remove a few un-needed load(features) after r121777
5474
5475         The features are computed by configure.pro and cached in .qmake.cache.
5476
5477         Reviewed by Jocelyn Turcotte..
5478
5479         * MiniBrowser/qt/raw/Target.pri:
5480
5481 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5482
5483         [Qt] Use haveQtModule() in project files instead of manual checks
5484
5485         Reviewed by Jocelyn Turcotte.
5486
5487         * qmake/mkspecs/features/default_pre.prf:
5488         * qmake/mkspecs/features/features.prf:
5489
5490 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5491
5492         [Qt] Fix haveQtModule() check
5493
5494         Without {} brackets we were pulling out the value of the module.name variable.
5495
5496         Reviewed by Jocelyn Turcotte.
5497
5498         * qmake/mkspecs/features/functions.prf:
5499
5500 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
5501
5502         [WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
5503         https://bugs.webkit.org/show_bug.cgi?id=90541
5504
5505         Reviewed by Carlos Garcia Campos.
5506
5507         We must add the contents of WebKitBuild/*/Libraries/ directory to
5508         the file to be uploaded to b.w.o to successfully run WebKit2 tests
5509         in the WebKit2 testing bot.
5510
5511         * BuildSlaveSupport/built-product-archive:
5512         (archiveBuiltProduct): appended Libraries to the list of
5513         neededDirectories.
5514
5515 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
5516
5517         [GTK] WebKit2 testing bot unable to find the build directory
5518         https://bugs.webkit.org/show_bug.cgi?id=90523
5519
5520         Reviewed by Carlos Garcia Campos.
5521
5522         The presence of GNUmakefile was used to determine whether a given
5523         directory was a valid build directory or not. That's not correct for
5524         testing bots as we export only the minimum required stuff to run the
5525         tests.
5526
5527         * gtk/common.py:
5528         (get_build_path.is_valid_build_directory): added an extra check.:
5529
5530 2012-07-04  Joe Thomas  <joethomas@motorola.com>
5531
5532         Adding myself to committers list.
5533
5534         Unreviewed.
5535
5536         * Scripts/webkitpy/common/config/committers.py:
5537
5538 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
5539
5540         [WK2][EFL] Ewk_View should report the load progress
5541         https://bugs.webkit.org/show_bug.cgi?id=90457
5542
5543         Reviewed by Kenneth Rohde Christiansen.
5544
5545         Update EFL MiniBrowser so that it listens for the
5546         "load,progress" on the Ewk_View and updates its
5547         window title accordingly.
5548
5549         * MiniBrowser/efl/main.c:
5550         (title_set):
5551         (on_title_changed):
5552         (on_progress):
5553         (browserCreate):
5554
5555 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
5556
5557         disable failing mock-chromium-mac python unit tests
5558
5559         Unreviewed, build fix.
5560
5561         Disable these tests until I can figure out why they're failing
5562         on the bots.
5563
5564         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
5565         (PortTest.disabled_test_chromium_mac_lion):
5566         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
5567
5568 2012-07-03  Ian Vollick  <vollick@chromium.org>
5569
5570         Add vollick to the list of committers
5571         https://bugs.webkit.org/show_bug.cgi?id=90512
5572
5573         Reviewed by Adrienne Walker.
5574
5575         * Scripts/webkitpy/common/config/committers.py:
5576
5577 2012-07-03  Ojan Vafai  <ojan@chromium.org>
5578
5579         Improve webkit-patch rebaseline to work for more cases
5580         https://bugs.webkit.org/show_bug.cgi?id=90504
5581
5582         Reviewed by Dirk Pranke.
5583
5584         -Makes it work for the build.chromium.org bots.
5585         -Lets you rebaseline all builders instead of just one.
5586         -Lets you pass in the builder or test to rebaseline.
5587
5588         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
5589         (Build.results_url):
5590         Make this work for build.chromium.org builders as well.
5591
5592         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
5593         (ChromiumBuilder):
5594         (ChromiumBuilder.latest_cached_build):
5595         ChromiumBuilder doesn't support large parts of the Builder interface.
5596         This provides the bare minimum for this patch to work. Eventually,
5597         we should create a single interface that can be supported for both
5598         sets of buildbots.
5599
5600         * Scripts/webkitpy/layout_tests/port/builders.py:
5601         (builder_path_from_name):
5602         (all_builder_names):
5603         memoizing here is incorrect because the test override _exact_matches,
5604         so these can return different values. In either case, I'm pretty sure these
5605         are not remotely hot codepaths.
5606
5607         * Scripts/webkitpy/tool/commands/rebaseline.py:
5608         (AbstractParallelRebaselineCommand.__init__):
5609         (Rebaseline):
5610         (Rebaseline.__init__):
5611         (Rebaseline._builders_to_pull_from):
5612         (Rebaseline._builder_with_name):
5613         (Rebaseline._tests_to_update):
5614         (Rebaseline.execute):
5615         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
5616         (test_rebaseline.mock_builders_to_pull_from):
5617         (test_rebaseline):
5618         (test_rebaseline_command_line_flags):
5619         (test_rebaseline_multiple_builders):
5620         (test_rebaseline_multiple_builders.mock_builders_to_pull_from):
5621         (test_rebaseline_multiple_builders.mock_tests_to_update):
5622
5623 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
5624
5625         [EFL] Enable CSS variables support at compile time
5626         https://bugs.webkit.org/show_bug.cgi?id=90448
5627
5628         Reviewed by Kenneth Rohde Christiansen.
5629
5630         Turn on CSS_VARIABLES flag by default on EFL port.
5631
5632         * Scripts/webkitperl/FeatureList.pm:
5633
5634 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
5635
5636         nrwt: clean up exception handling and make sure we log some more failures
5637         https://bugs.webkit.org/show_bug.cgi?id=90503
5638
5639         Reviewed by Ojan Vafai.
5640
5641         There were several places where exceptions weren't getting
5642         logged, most notably if you passed a bad value to --platform.
5643         This change tests that and cleans things up a bit; more cleanup
5644         will be possible when we rework the manager_worker_broker code.
5645
5646         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
5647         (_BrokerConnection.raise_exception):
5648         (_InlineWorkerConnection.raise_exception):
5649         * Scripts/webkitpy/layout_tests/controllers/worker.py:
5650         (Worker.run):
5651         (Worker.kill_driver):
5652         * Scripts/webkitpy/layout_tests/port/factory.py:
5653         (PortFactory.get):
5654         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
5655         (run):
5656         (main):
5657         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
5658         (MainTest.test_unsupported_platfrom):
5659
5660 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
5661
5662         nrwt: fix mock port
5663         https://bugs.webkit.org/show_bug.cgi?id=90500
5664
5665         Reviewed by Ojan Vafai.
5666
5667         The MockDRT code was never updated when we switched the chromium
5668         ports to using "drt mode" by default. This change updates that
5669         code, fixes a typo in the chromium port that went undetected
5670         (default_test_timeout_ms -> default_timeout_ms), and adds tests
5671         that actually exercise some of the mock ports. These tests are
5672         useful in that they will exercise the port-specific code in an
5673         end-to-end-manner, but they are a bit slow for some reason (>1s
5674         each) that I need to look into.
5675
5676         * Scripts/webkitpy/layout_tests/port/chromium.py:
5677         (ChromiumDriver.stop):
5678         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
5679         (ChromiumAndroidPort.default_timeout_ms):
5680         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
5681         (TestChromiumAndroidPort.test_default_timeout_ms):
5682         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
5683         (main):
5684         (parse_options):
5685         (MockTestShell):
5686         (MockTestShell.output_for_test):
5687         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
5688         (MockDRTTest.assertTest):
5689         (MockTestShellTest):
5690         (MockTestShellTest.make_drt):
5691         (MockTestShellTest.test_test_shell_parse_options):
5692         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
5693         (PortTest):
5694         (PortTest.assert_mock_port_works):
5695         (PortTest.test_chromium_mac_lion):
5696         (PortTest.test_chromium_mac_lion_in_test_shell_mode):
5697         (PortTest.test_qt_linux):
5698         (PortTest.test_mac_lion):
5699
5700 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
5701
5702         nrwt: make the worker class stand alone with a cleaner interface
5703         https://bugs.webkit.org/show_bug.cgi?id=90409
5704
5705         Reviewed by Ojan Vafai.
5706
5707         Currently the Worker class derives from AbstractWorker, which is
5708         kind of crufty and awkward; it would be better if we did not
5709         rely on shared state.
5710
5711         This change changes that so that Worker derives from object, and
5712         exposes the following interface:
5713           __init__() - called in the manager process
5714           safe_init() - called in the worker process to initialize
5715             unpicklable state
5716           handle() - a single routine to handle all messages
5717           cleanup() - called so the worker can clean up
5718
5719         Also, all of the "administrative" messages that are handled by
5720         the worker (notification of start/stop/etc.) move into
5721         manager_worker_broker - this reduces worker.py to just handling
5722         the mechanics of actually running each test.
5723
5724         For the moment, we do this by creating Yet Another wrapper/proxy
5725         class in manager_worker_broker, but this will get simpler
5726         shortly when the rest of m_w_b is cleaned up.
5727
5728         With this change worker is now in its new form but there will be
5729         a follow-on change that cleans up some names and other minor
5730         things.
5731
5732         This change is again mostly just moving things around and should
5733         be covered by the (updated) existing tests.
5734
5735         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
5736         (get):
5737         (AbstractWorker.__init__):
5738         (AbstractWorker.run):
5739         (AbstractWorker):
5740         (AbstractWorker.handle_stop):
5741         (AbstractWorker.handle_test_list):
5742         (AbstractWorker.yield_to_broker):
5743         (AbstractWorker.post_message):
5744         (_WorkerConnection.__init__):
5745         (_Process.run):
5746         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
5747         (_TestWorker):
5748         (_TestWorker.__init__):
5749         (_TestWorker.name):
5750         (_TestWorker.cleanup):
5751         (_TestWorker.handle):
5752         (_TestWorker.safe_init):
5753         (_TestWorker.stop):
5754         (_TestsMixin.handle_finished_test):
5755         (_TestsMixin.setUp):
5756         (_TestsMixin.test_cancel):
5757         (_TestsMixin.test_done):
5758         * Scripts/webkitpy/layout_tests/controllers/worker.py:
5759         (Worker):
5760         (Worker.__init__):
5761         (Worker.safe_init):
5762         (Worker.handle):
5763
5764 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
5765
5766         nrwt: moving child process logging code into manager_worker_broker
5767         https://bugs.webkit.org/show_bug.cgi?id=90408
5768
5769         Reviewed by Ojan Vafai.
5770
5771         Users of manager_worker_broker should not have to be aware of
5772         whether they're in the same process or different processes and
5773         configure logging themselves; mwb should hide this complexity.
5774         We can't quite do this completely/correctly yet, since the
5775         manager expects to get a list of messages to log, but this
5776         change fixes the worker side of it, at least.
5777
5778         This is just moving code around, there is no new functionality
5779         and this should be covered by existing tests.
5780
5781         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
5782         (AbstractWorker.__init__):
5783         (_WorkerConnection.__init__):
5784         (_WorkerConnection.post_message):
5785         (_WorkerConnection):
5786         (_WorkerConnection.set_up_logging):
5787         (_WorkerConnection.clean_up_logging):
5788         (_InlineWorkerConnection.run):
5789         (_MultiProcessWorkerConnection.run):
5790         (_WorkerLogHandler):
5791         (_WorkerLogHandler.__init__):
5792         (_WorkerLogHandler.emit):
5793         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
5794         (_TestWorker.run):
5795         (_TestsMixin.handle_done):
5796         * Scripts/webkitpy/layout_tests/controllers/worker.py:
5797         (Worker.__init__):
5798         (Worker.run):
5799         (Worker._run_test):
5800         (Worker.cleanup):
5801         (Worker.run_single_test):
5802
5803 2012-07-03  Tony Chang  <tony@chromium.org>
5804
5805         [chromium] Don't archive build files generated by VS2010
5806         https://bugs.webkit.org/show_bug.cgi?id=90493
5807
5808         Reviewed by Ojan Vafai.
5809
5810         In particular, the pch (pre compiled header) files are gigantic, making
5811         release.zip almost a 1gb in size.
5812
5813         * BuildSlaveSupport/built-product-archive:
5814         (archiveBuiltProduct):
5815
5816 2012-07-03  Tony Chang  <tony@chromium.org>
5817
5818         [chromium] Unreviewed, update .gitignore to handle VS2010 files.
5819
5820         * .gitignore:
5821         * DumpRenderTree/DumpRenderTree.gyp/.gitignore:
5822         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore:
5823
5824 2012-07-03  Ojan Vafai  <ojan@chromium.org>
5825
5826         Have webkit-patch rebaseline use rebaseline-test-internal
5827         https://bugs.webkit.org/show_bug.cgi?id=90491
5828
5829         Reviewed by Dirk Pranke.
5830
5831         This lets it handle new files, reduces duplicate code and lays the
5832         groundwork for making rebaseline have a richer interface.
5833
5834         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
5835         (MockBuild):
5836         (MockBuild.__init__):
5837         (MockBuilder.build):
5838         * Scripts/webkitpy/tool/commands/rebaseline.py:
5839         (AbstractParallelRebaselineCommand._files_to_add):
5840         (Rebaseline):
5841         (Rebaseline._builder_to_pull_from):
5842         (Rebaseline._tests_to_update):
5843         (Rebaseline.execute):
5844         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
5845         (test_overrides_are_included_correctly):
5846         (test_rebaseline):
5847         (test_rebaseline.mock_builder_to_pull_from):
5848         (test_rebaseline.mock_tests_to_update):
5849
5850 2012-07-03  Ojan Vafai  <ojan@chromium.org>
5851
5852         Rename rebaseline-test to rebaseline-test-internal
5853         https://bugs.webkit.org/show_bug.cgi?id=90485
5854
5855         Reviewed by Adam Barth.
5856
5857         It's now only used by other rebaseline commands. It's still useful to leave it
5858         as it's own command to aid in debugging when something goes wrong. In a followup
5859         patch, I'll make webkit-patch rebaseline cover any use-cases that rebaseline-test
5860         might have covered.
5861
5862         We no longer need the --print-scm-changes option since the only caller always passes
5863         that option in.
5864
5865         Also, make all the arguments command-line flags instead. Simplifies the code
5866         a bit in my opinion.
5867
5868         * Scripts/webkitpy/tool/commands/rebaseline.py:
5869         (RebaselineTest):
5870         (RebaselineTest.__init__):
5871         (RebaselineTest.execute):
5872         (AbstractParallelRebaselineCommand._rebaseline_commands):
5873         (RebaselineExpectations.execute):
5874         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
5875         (test_rebaseline_all):
5876
5877 2012-07-03  Balazs Kelemen  <kbalazs@webkit.org>
5878
5879         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
5880         https://bugs.webkit.org/show_bug.cgi?id=90262
5881
5882         Unreviewed build fix.
5883
5884         Reverting r121550 manually because it caused build
5885         break on ARM and Mac. It turned out that the Qt build
5886         system is too broken for this change now, first we have
5887         to address two issues:
5888             * symbol hiding was forbidden accidentally on x86 Linux
5889             * Qt lacks a separate library for test support
5890
5891         * Tools.pro:
5892         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
5893         (WTR::InjectedBundlePage::resetAfterTest):
5894         (WTR::InjectedBundlePage::didClearWindowForFrame):
5895         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
5896
5897 2012-07-03  Tony Chang  <tony@chromium.org>
5898
5899         [chromium] Handle trailing backslash on %VSINSTALLDIR%
5900         https://bugs.webkit.org/show_bug.cgi?id=90410
5901
5902         Reviewed by Ojan Vafai.
5903
5904         * Scripts/webkitdirs.pm:
5905         (buildChromiumVisualStudioProject): Handle VSINSTALLDIR ending in a backslash, the backslash escapes the closing double quote.
5906
5907 2012-07-02  Ojan Vafai  <ojan@chromium.org>
5908
5909         Make the skia_test_expectations.txt file optional.
5910         https://bugs.webkit.org/show_bug.cgi?id=90400
5911
5912         Reviewed by Dirk Pranke.
5913
5914         It used to be optional. This regressed at some point. It's important that it be
5915         optional so that webkit-patch commands work in a pure-webkit checkout for chromium bots.
5916         Specifically, this was breaking webkit-patch rebaseline-test when it would go to update
5917         TestExpectations.
5918
5919         * Scripts/webkitpy/layout_tests/port/chromium.py:
5920         (ChromiumPort.expectations_files):
5921         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
5922         (ChromiumDriverTest.test_expectations_dict):
5923
5924 2012-07-03  Raphael Kubo da Costa  <rakuco@webkit.org>
5925
5926         [jhbuild][EFL] Bump libffi dependency.
5927         https://bugs.webkit.org/show_bug.cgi?id=85373
5928
5929         Reviewed by Gustavo Noronha Silva.
5930
5931         Update libffi to 3.0.11, which fixes the build on some platforms
5932         where 3.0.10 had problems.
5933
5934         * efl/jhbuild.modules:
5935
5936 2012-07-03  George Staikos  <staikos@webkit.org>
5937
5938         [BlackBerry] Enable microdata support for BlackBerry.
5939         https://bugs.webkit.org/show_bug.cgi?id=90429
5940
5941         Reviewed by Rob Buis.
5942
5943         * Scripts/webkitperl/FeatureList.pm:
5944
5945 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5946
5947         [Qt] Make use of .qmake.cache for caching features
5948
5949         Instead of loading() features from the files that need them (and re-running
5950         a bunch of checks), we now run feature detection as part of configure.pro,
5951         and have build-webkit write the computed feature-defines and CONFIG to
5952         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
5953         when building WebKit.pro.
5954
5955         At some point we'll be able to selectivly prevent running of config tests
5956         in configure.pro, which means we don't need a separate code-path for
5957         the build-webkit --help case.
5958
5959         We should also move the code in build-webkit that now uses .webkit.config
5960         to detect clean builds, to use .qmake.cache, since we now store the same
5961         thing there.
5962
5963         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
5964
5965         Reviewed by Tor Arne Vestbø.
5966
5967         * DumpRenderTree/qt/DumpRenderTree.pro:
5968         * QtTestBrowser/QtTestBrowser.pro:
5969         * Scripts/webkitdirs.pm:
5970         (qtFeatureDefaults):
5971         (buildQMakeProjects):
5972         * Tools.pro:
5973         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
5974         * WebKitTestRunner/InjectedBundle/Target.pri:
5975         * WebKitTestRunner/Target.pri:
5976         * qmake/.qmake.conf: Added.
5977         * qmake/configure.pro:
5978         * qmake/mkspecs/features/default_post.prf:
5979         * qmake/mkspecs/features/default_pre.prf:
5980         * qmake/mkspecs/features/features.prf:
5981
5982 2012-07-03  Nico Weber  <thakis@chromium.org>
5983
5984         -Wunused-private-field cleanup, linux edition
5985         https://bugs.webkit.org/show_bug.cgi?id=90463
5986
5987         Reviewed by Stephen White.
5988
5989         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
5990         * DumpRenderTree/chromium/GamepadController.h:
5991         (GamepadController):
5992         * DumpRenderTree/chromium/NotificationPresenter.h:
5993         (NotificationPresenter::NotificationPresenter):
5994         (NotificationPresenter):
5995
5996 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
5997
5998         Unreviewed, rolling out r121766.
5999         http://trac.webkit.org/changeset/121766
6000         https://bugs.webkit.org/show_bug.cgi?id=90465
6001
6002         It caused flakey build errors on the bots (Requested by Ossy
6003         on #webkit).
6004
6005         * DumpRenderTree/qt/DumpRenderTree.pro:
6006         * QtTestBrowser/QtTestBrowser.pro:
6007         * Scripts/webkitdirs.pm:
6008         (qtFeatureDefaults):
6009         (buildQMakeProjects):
6010         * Tools.pro:
6011         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
6012         * WebKitTestRunner/InjectedBundle/Target.pri:
6013         * WebKitTestRunner/Target.pri:
6014         * qmake/.qmake.conf: Removed.
6015         * qmake/configure.pro:
6016         * qmake/mkspecs/features/default_post.prf:
6017         * qmake/mkspecs/features/default_pre.prf:
6018         * qmake/mkspecs/features/features.prf:
6019
6020 2012-07-03  George Staikos  <staikos@webkit.org>
6021
6022         [BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
6023         https://bugs.webkit.org/show_bug.cgi?id=90422
6024
6025         Reviewed by Rob Buis.
6026
6027         * Scripts/webkitperl/FeatureList.pm:
6028
6029 2012-07-03  George Staikos  <staikos@webkit.org>
6030
6031         [BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
6032         https://bugs.webkit.org/show_bug.cgi?id=90422
6033
6034         Reviewed by Rob Buis.
6035
6036         * Scripts/webkitperl/FeatureList.pm:
6037
6038 2012-07-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
6039
6040         [EFL] Add run API tests as a step on the build bots
6041         https://bugs.webkit.org/show_bug.cgi?id=87252
6042
6043         Reviewed by Daniel Bates.
6044
6045         Run EFL API test suite on the build bots.
6046
6047         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
6048         (RunEflAPITests):
6049         (TestFactory.__init__):
6050         (BuildAndTestFactory.__init__):
6051         * Scripts/run-efl-tests: Added.
6052
6053 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
6054
6055         [Qt] Make use of .qmake.cache for caching features
6056
6057         Instead of loading() features from the files that need them (and re-running
6058         a bunch of checks), we now run feature detection as part of configure.pro,
6059         and have build-webkit write the computed feature-defines and CONFIG to
6060         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
6061         when building WebKit.pro.
6062
6063         At some point we'll be able to selectivly prevent running of config tests
6064         in configure.pro, which means we don't need a separate code-path for
6065         the build-webkit --help case.
6066
6067         We should also move the code in build-webkit that now uses .webkit.config
6068         to detect clean builds, to use .qmake.cache, since we now store the same
6069         thing there.
6070
6071         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
6072
6073         Reviewed by Tor Arne Vestbø.
6074
6075         * DumpRenderTree/qt/DumpRenderTree.pro:
6076         * QtTestBrowser/QtTestBrowser.pro:
6077         * Scripts/webkitdirs.pm:
6078         (qtFeatureDefaults):
6079         (buildQMakeProjects):
6080         * Tools.pro:
6081         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
6082         * WebKitTestRunner/InjectedBundle/Target.pri:
6083         * WebKitTestRunner/Target.pri:
6084         * qmake/.qmake.conf: Added.
6085         * qmake/configure.pro:
6086         * qmake/mkspecs/features/default_post.prf:
6087         * qmake/mkspecs/features/default_pre.prf:
6088         * qmake/mkspecs/features/features.prf:
6089
6090 2012-07-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>  Joel Dillon <joel.dillon@codethink.co.uk>
6091
6092         [Qt][Win] Fix broken QtWebKit5.lib linking
6093         https://bugs.webkit.org/show_bug.cgi?id=88321
6094
6095         Reviewed by Kenneth Rohde Christiansen.
6096
6097         On windows the import/export definition is part of the symbol's signature.
6098         Define STATICALLY_LINKED_WITH_$$library for each dependend module
6099         that is being linked statically to make sure that they can be linked together
6100         later on.
6101
6102         Also do not compile Assertions.cpp in DumpRenderTree anymore since all the
6103         used symbols are exported and it would cause a duplicate symbols error.
6104
6105         * DumpRenderTree/qt/DumpRenderTree.pro:
6106         * qmake/mkspecs/features/default_post.prf:
6107
6108 2012-07-03  Szilard Ledan  <szledan@inf.u-szeged.hu>
6109
6110         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
6111         https://bugs.webkit.org/show_bug.cgi?id=89001
6112
6113         Reviewed by Csaba Osztrogonác.
6114
6115         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
6116         (UploadBuiltProduct.__init__):
6117         (UploadTestResults.__init__):
6118         (ExtractTestResults.__init__):
6119         (Factory.__init__):
6120         (BuildFactory.__init__):
6121         (TestFactory.__init__):
6122         (BuildAndTestFactory.__init__):
6123         (BuildAndPerfTestFactory.__init__):
6124         (BuildAndPerfTestWebKit2Factory.__init__):
6125         (DownloadAndPerfTestFactory.__init__):
6126
6127 2012-07-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
6128
6129         Update unit test after r121724.
6130         https://bugs.webkit.org/show_bug.cgi?id=90444
6131
6132         Reviewed by Csaba Osztrogonác.
6133
6134         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
6135         (GardeningServerTest.test_rebaseline_new_port):
6136
6137 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
6138
6139         Unreviewed, rolling out r121749.
6140         http://trac.webkit.org/changeset/121749
6141         https://bugs.webkit.org/show_bug.cgi?id=90441
6142
6143         Tests crash on the paralel NRWT Qt bot (Requested by Ossy on
6144         #webkit).
6145
6146         * Scripts/webkitpy/layout_tests/port/qt.py:
6147         (QtPort._build_driver):
6148         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
6149         (XvfbDriver._start):
6150         (XvfbDriver._start.x_filter):
6151         (XvfbDriver.stop):
6152
6153 2012-07-03  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
6154
6155         [NRWT] XvfbDriver should choose the next free display
6156         https://bugs.webkit.org/show_bug.cgi?id=88414
6157
6158         Reviewed by Dirk Pranke.
6159
6160         * Scripts/webkitpy/layout_tests/port/qt.py:
6161         (QtPort._driver_class):
6162         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
6163         (XvfbDriver.__init__):
6164         (XvfbDriver._start):
6165         (XvfbDriver._start.next_free_id):
6166         (XvfbDriver.stop):
6167
6168 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
6169
6170         [EFL] Enable MICRODATA support
6171         https://bugs.webkit.org/show_bug.cgi?id=90377
6172
6173         Reviewed by Kenneth Rohde Christiansen.
6174
6175         Turn on MICRODATA flag for EFL port by default.
6176
6177         * Scripts/webkitperl/FeatureList.pm:
6178
6179 2012-07-02  George Staikos  <staikos@webkit.org>
6180
6181         [BlackBerry] Enable scoped style for BlackBerry.
6182         https://bugs.webkit.org/show_bug.cgi?id=90418
6183
6184         Reviewed by Rob Buis.
6185
6186         * Scripts/webkitperl/FeatureList.pm:
6187
6188 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
6189
6190         [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
6191         https://bugs.webkit.org/show_bug.cgi?id=90271
6192
6193         Reviewed by George Staikos.
6194
6195         RIM PR #154707
6196
6197         Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
6198         defined by default.
6199         We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
6200         need to rebuild webkit before running DRT.
6201
6202         * Scripts/webkitdirs.pm:
6203         (blackberryCMakeArguments):
6204
6205 2012-07-02  Ojan Vafai  <ojan@chromium.org>
6206
6207         webkit-patch rebaseline-expectations should share code with rebaseline-all
6208         https://bugs.webkit.org/show_bug.cgi?id=90413
6209
6210         Reviewed by Dirk Pranke.
6211
6212         Make them share code. In addition to reducing code duplication this makes
6213         rebaseline-expectations considerably faster by rebaselining in parallel.
6214
6215         * Scripts/webkitpy/tool/commands/rebaseline.py:
6216         (AbstractParallelRebaselineCommand):
6217         (AbstractParallelRebaselineCommand._run_webkit_patch):
6218         (AbstractParallelRebaselineCommand._rebaseline):
6219         (RebaselineJson):
6220         (RebaselineJson.execute):
6221         (RebaselineExpectations):
6222         (RebaselineExpectations._update_expectations_file):
6223         (RebaselineExpectations._tests_to_rebaseline):
6224         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
6225         (RebaselineExpectations.execute):
6226         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
6227         (test_rebaseline_all):
6228         (test_rebaseline_expectations.run_in_parallel):
6229         (test_rebaseline_expectations):
6230
6231 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
6232
6233         [BlackBerry] Update DumpRenderTree to have it work interactively in parallel
6234         https://bugs.webkit.org/show_bug.cgi?id=88326
6235
6236         Reviewed by Rob Buis.
6237
6238         1. Test name is sent to torch-launcher via PPS message(from host machine).
6239            So we get test list by monitoring and receiving PPS message instead of
6240            reading file index.drt.
6241         2. Torch-launcher create a <test file>.done file when it finished a test.
6242         3. We don't need to search for Ref-tests in DumpRenderTree.cpp any more. NRWT
6243            will get them for us.
6244
6245         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
6246         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
6247         (BlackBerry::WebKit::DumpRenderTree::doneDrt):
6248         (BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
6249         (BlackBerry::WebKit::DumpRenderTree::ensurePPS):
6250         (WebKit):
6251         (BlackBerry::WebKit::DumpRenderTree::handlePPSData):
6252         (BlackBerry::WebKit::DumpRenderTree::waitForTest):
6253         (BlackBerry::WebKit::DumpRenderTree::runTests):
6254         (BlackBerry::WebKit::DumpRenderTree::dump):
6255         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
6256         (DumpRenderTree):
6257
6258 2012-07-02  Adam Barth  <abarth@webkit.org>
6259
6260         Remove flashplugin-installer from the EWS image because it causes some tests to crash
6261         https://bugs.webkit.org/show_bug.cgi?id=90403
6262
6263         Reviewed by Tony Chang.
6264
6265         * EWSTools/cold-boot.sh:
6266
6267 2012-07-02  Leandro Gracia Gil  <leandrogracia@chromium.org>
6268
6269         [Chromium] Implement a Layout Test for editing/SurroundingText
6270         https://bugs.webkit.org/show_bug.cgi?id=82461
6271
6272         Reviewed by Ryosuke Niwa.
6273
6274         Add a new method to the layout test controller in order to retrieve the
6275         text surrounding a provided element.
6276
6277         * DumpRenderTree/chromium/LayoutTestController.cpp:
6278         (LayoutTestController::LayoutTestController):
6279         (LayoutTestController::textSurroundingElement):
6280         * DumpRenderTree/chromium/LayoutTestController.h:
6281         (LayoutTestController):
6282
6283 2012-07-02  Ojan Vafai  <ojan@chromium.org>
6284
6285         Delete unused rebaseline method in gardeningserver.py
6286         https://bugs.webkit.org/show_bug.cgi?id=90396
6287
6288         Reviewed by Eric Seidel.
6289
6290         As best I can tell, the only usage was in this unittest.
6291
6292         * Scripts/webkitpy/tool/servers/gardeningserver.py:
6293         (GardeningHTTPRequestHandler.updateexpectations):
6294         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
6295         (GardeningServerTest.test_rebaseline_new_port):
6296
6297 2012-07-02  Csaba Osztrogonác  <ossy@webkit.org>
6298
6299         REGRESSION(r121497): It switched off and broke many unittests
6300         https://bugs.webkit.org/show_bug.cgi?id=90371
6301
6302         Reviewed by Adam Barth.
6303
6304         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
6305         (ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
6306         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
6307         (ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
6308         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
6309         (PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.
6310
6311 2012-07-02  Ojan Vafai  <ojan@chromium.org>
6312
6313         Move rebaseline-all command from the gardening-server down into webkit-patch
6314         https://bugs.webkit.org/show_bug.cgi?id=90395
6315
6316         Reviewed by Adam Barth.
6317
6318         This is just moving code. It it in preparation for making rebaseline-expectations
6319         use the same code in order to get the parallelism benefits and reduces the amount
6320         of code we have for doing rebaselines.
6321
6322         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
6323         (CheckoutTest.test_apply_patch):
6324         Updated due to the change to executive_mock.
6325         * Scripts/webkitpy/common/system/executive_mock.py:
6326         (MockExecutive.run_command):
6327         Update to print out the input passed to stdin.
6328         * Scripts/webkitpy/tool/commands/download_unittest.py:
6329         Updated due to executive_mock change.
6330         * Scripts/webkitpy/tool/commands/rebaseline.py:
6331         (RebaselineAll):
6332         (RebaselineAll._run_webkit_patch):
6333         (RebaselineAll._builders_to_fetch_from):
6334         (RebaselineAll._rebaseline_commands):
6335         (RebaselineAll._files_to_add):
6336         (RebaselineAll._optimize_baselines):
6337         (RebaselineAll._rebaseline):
6338         (RebaselineAll.execute):
6339         All this code is just copy-pasted except for mechanical changes
6340         (e.g. self.server.tool --> self._tool) and the reading in of the
6341         JSON from stdin instead of the post body.
6342         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
6343         (test_rebaseline_all):
6344         Copied the test-case out of gardeningserver_unittest.py.
6345         * Scripts/webkitpy/tool/servers/gardeningserver.py:
6346         (GardeningHTTPRequestHandler):
6347         (GardeningHTTPRequestHandler.rebaseline):
6348         (GardeningHTTPRequestHandler.rebaselineall):
6349         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
6350         (GardeningServerTest.test_rebaselineall):
6351         (GardeningServerTest.test_rebaselineall.run_command):
6352
6353 2012-07-02  Ojan Vafai  <ojan@chromium.org>
6354
6355         Remove Leopard support from the flakiness dashboard
6356         https://bugs.webkit.org/show_bug.cgi?id=90390
6357
6358         Reviewed by Adam Barth.
6359
6360         * TestResultServer/static-dashboards/flakiness_dashboard.js:
6361         (nonChromiumPlatform):
6362         (chromiumPlatform):
6363         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
6364         (test):
6365         * TestResultServer/static-dashboards/run-embedded-unittests.html:
6366         * TestResultServer/static-dashboards/run-unittests.html:
6367
6368 2012-07-02  Ojan Vafai  <ojan@chromium.org>
6369
6370         Fix posting from garden-o-matic. This broke in moving away from jquery's ajax method
6371         in http://trac.webkit.org/changeset/121617.
6372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
6373
6374 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
6375
6376         [GTK] Read fonts path when running layout tests from alternative fonts dir when main dir doesn't exist
6377         https://bugs.webkit.org/show_bug.cgi?id=89437
6378
6379         Reviewed by Martin Robinson.
6380
6381         If main fonts directory doesn't exist, try with an alternative
6382         fonts directory at build directory.
6383
6384         * DumpRenderTree/gtk/DumpRenderTree.cpp:
6385         (getOutputDir):
6386         (getFontsPath):
6387         (initializeFonts):
6388         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
6389         (WTR::getOutputDir):
6390         (WTR):
6391         (WTR::getFontsPath):
6392         (WTR::inititializeFontConfigSetting):
6393
6394 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
6395
6396         [GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
6397         https://bugs.webkit.org/show_bug.cgi?id=89435
6398
6399         Reviewed by Martin Robinson.
6400
6401         * Scripts/new-run-webkit-tests: Don't run the tests with the
6402         jhbuild wrapper if there isn't a Dependencies directory inside the
6403         build directory.
6404
6405 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
6406
6407         [Qt] Simplify detection of non-installed module file
6408
6409         Has the additional advantage that we do not rely on additional information.
6410
6411         Reviewed by Tor Arne Vestbø.
6412
6413         * qmake/qt_webkit.pri:
6414
6415 2012-07-01  Christophe Dumez  <christophe.dumez@intel.com>
6416
6417         [EFL] Add Gamepad support
6418         https://bugs.webkit.org/show_bug.cgi?id=90170
6419
6420         Reviewed by Kenneth Rohde Christiansen.
6421
6422         * Scripts/webkitperl/FeatureList.pm: Turn on GAMEPAD flag
6423         by default for EFL port.
6424         * efl/jhbuild.modules: Bump dependency versions of EFL libs
6425         since the latest Eeze is required for gamepad support.
6426
6427 2012-07-01  Adam Barth  <abarth@webkit.org>
6428
6429         Unreviewed.
6430
6431         Using the default start cylinder for fdisk causes a warning about the
6432         partition not starting on physical sector boundary.  The Ubuntu forums
6433         recommend using a number that's divisible by 8, which is what we do in
6434         this patch.
6435
6436         * EWSTools/cold-boot.sh:
6437
6438 2012-07-01  Adam Barth  <abarth@webkit.org>
6439
6440         Unreviewed.
6441
6442         It turns out we need to use Ubuntu 10.04 to get the right image results
6443         for chromium-linux. This patch updates our scripts to be compatible
6444         with Ubuntu 10.04.
6445
6446         * EWSTools/cold-boot.sh:
6447             - fdisk doesn't have p and 1 as default commands in 10.04.
6448         * EWSTools/start-queue.sh:
6449             - git doesn't understanding the -B argument in 10.04. We've been
6450               using this change locally on the EC2 bots for a while.
6451
6452 2012-07-01  Adam Barth  <abarth@webkit.org>
6453
6454         Unreviewed.
6455
6456         * EWSTools/boot.sh:
6457             - We need to start the screen in detached mode so that we can run
6458               it remotely via ssh.
6459
6460 2012-07-01  Adam Barth  <abarth@webkit.org>
6461
6462         Unreviewed.
6463
6464         * EWSTools/cold-boot.sh:
6465             - Turns out we need to sudo this command in order for it to
6466               actually dimiss the EULA screen. :)
6467
6468 2012-06-29  Adam Barth  <abarth@webkit.org>
6469
6470         Turns out we need zip too.
6471
6472         * EWSTools/cold-boot.sh:
6473
6474 2012-06-29  Adam Barth  <abarth@webkit.org>
6475
6476         Add a cold-boot.sh script for the EWS
6477         https://bugs.webkit.org/show_bug.cgi?id=90330
6478
6479         Unreviewed.
6480
6481         * EWSTools/cold-boot.sh: Added.
6482             - This script can take us from a cold GCE instance to a running EWS
6483               bot in one fell swoop.
6484         * EWSTools/start-queue.sh:
6485             - The if-block at the top of this script was causing trouble. I
6486               removed it from the bots a while ago. Now that we're using SVN to
6487               cold-boot the EWS bots, we need to make this change in the repo.
6488
6489 2012-06-29  Luiz Agostini  <luiz.agostini@nokia.com>
6490
6491         [Qt][WK2] Private non-QtQuick API
6492         https://bugs.webkit.org/show_bug.cgi?id=84532
6493
6494         MiniBrowserRaw is an usage example for the QRawWebView API.
6495         It is only an example and is not fully implemented.
6496
6497         Reviewed by Noam Rosenthal.
6498
6499         * MiniBrowser/qt/raw/DerivedSources.pri: Added.
6500         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Added.
6501         * MiniBrowser/qt/raw/Target.pri: Added.
6502         * MiniBrowser/qt/raw/View.cpp: Added.
6503         * MiniBrowser/qt/raw/View.h: Added.
6504         * Scripts/webkitpy/style/checker.py:
6505         * Tools.pro:
6506
6507 2012-06-29  Ojan Vafai  <ojan@chromium.org>
6508
6509         Remove leopard bots from garden-o-matic
6510         https://bugs.webkit.org/show_bug.cgi?id=90328
6511
6512         Reviewed by Adam Barth.
6513
6514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
6515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
6516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
6517
6518 2012-06-29  Ojan Vafai  <ojan@chromium.org>
6519
6520         garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url')
6521         https://bugs.webkit.org/show_bug.cgi?id=90243
6522
6523         Reviewed by Dirk Pranke.
6524
6525         jQuery was trying to be too smart and parsing the jsonp as json because of it's content-type.
6526         Excise jQuery and just use XHR directly since it's easier to maintain something where we control it
6527         all.
6528
6529         Not really sure how to unittest this. I tested it all manually of course.
6530
6531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
6532         Made net.ajax a drop-in replacement for the features of $.ajax that we were using.
6533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
6534         Not related to this patch, but figured I'd update the failing test while I was at it.
6535
6536 2012-06-29  Yaron Friedman  <yfriedman@chromium.org>
6537
6538         Fix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id=88134
6539         https://bugs.webkit.org/show_bug.cgi?id=90309
6540
6541         Reviewed by Adam Barth.
6542
6543         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
6544         (ChromiumAndroidPort.start_http_server):
6545
6546 2012-06-29  James Weatherall  <wez@chromium.org>
6547
6548         NPObjectWrapper may not address all window script object lifetime issues
6549         https://bugs.webkit.org/show_bug.cgi?id=85679
6550
6551         TestNetscapePlugin now has a leak-window-scriptable-object test which takes a reference to the window script object, and a second reference to it via the "self" property, and does not release those references. This is used to simulate a leaky plugin in layout tests of the NPAPI scripting interface glue code.
6552
6553         Reviewed by Nate Chapin.
6554
6555         * DumpRenderTree/DumpRenderTree.gypi:
6556         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
6557         (PluginTest::NPN_GetProperty):
6558         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
6559         (PluginTest):
6560         * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Added.
6561         (LeakWindowScriptableObject):
6562         (LeakWindowScriptableObject::LeakWindowScriptableObject):
6563         (LeakWindowScriptableObject::NPP_New):
6564
6565 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
6566
6567         webkitpy: add comment about how determine_full_port_name() works for apple ports, fix -wk2 bug
6568         https://bugs.webkit.org/show_bug.cgi?id=90314
6569
6570         Reviewed by Ojan Vafai.
6571
6572         Add comments and fix a bug in how we would handle the mac-wk2
6573         and win-wk2 port names after confusion around in bug 90312 :).
6574
6575         * Scripts/webkitpy/layout_tests/port/apple.py:
6576         (ApplePort.determine_full_port_name):
6577
6578 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
6579
6580         webkitpy: remove support for mac leopard from chromium configurations
6581         https://bugs.webkit.org/show_bug.cgi?id=90313
6582
6583         Reviewed by Tony Chang.
6584
6585         Google has shipped the last version of Chrome that will support
6586         Mac OS 10.5 (Leopard), and we no longer have bots that run this
6587         configuration, so we're removing support for it.
6588
6589         A subsequent change will remove the baselines in platform/chromium-mac-leopard.
6590
6591         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
6592         (BaselineOptimizerTest.test_complex_shadowing):
6593         * Scripts/webkitpy/layout_tests/port/builders.py:
6594         * Scripts/webkitpy/layout_tests/port/chromium.py:
6595         (ChromiumPort):
6596         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
6597         (ChromiumMacPort):
6598         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
6599         (ChromiumMacPortTest.test_versions):
6600         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
6601         (FactoryTest.test_mac):
6602         (FactoryTest.test_chromium_mac):
6603         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
6604         (test_rebaseline_and_copy_test_with_lion_result):
6605
6606 2012-06-29  Ojan Vafai  <ojan@chromium.org>
6607
6608         Fix optimize-baselines to not move baselines from win to win-7sp0
6609         https://bugs.webkit.org/show_bug.cgi?id=90312
6610
6611         Reviewed by Dirk Pranke.
6612
6613         It used to consider win-7sp0 as the common directory for all the Apple
6614         windows ports and incorrectly move results out of win.
6615
6616         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
6617         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
6618         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
6619         (BaselineOptimizerTest.test_common_directory_includes_root):
6620
6621 2012-06-28  Ojan Vafai  <ojan@chromium.org>
6622
6623         Fix rebaselining for Qt and Apple ports
6624         https://bugs.webkit.org/show_bug.cgi?id=90204
6625
6626         Reviewed by Dirk Pranke.
6627
6628         -Apporpriately put wk2 results in the -wk2 directories.
6629         -Since Qt and Apple-Win don't have bots that correspond to the
6630         platform/qt and platform/win directories, we need to fudge it
6631         and always put the results in those directories for those ports.
6632
6633         * Scripts/webkitpy/layout_tests/port/builders.py:
6634         (rebaseline_override_dir):
6635         * Scripts/webkitpy/layout_tests/port/factory.py:
6636         (_builder_options):
6637         Identify webkit2 builders by the WK2 in the builder name.
6638         * Scripts/webkitpy/tool/commands/rebaseline.py:
6639         (RebaselineTest._baseline_directory):
6640         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
6641         (TestRebaseline.test_baseline_directory):
6642
6643 2012-06-29  Zoltan Horvath  <zoltan@webkit.org>
6644
6645         Add support for --force parameter to run-performance-tests
6646         https://bugs.webkit.org/show_bug.cgi?id=90279
6647
6648         Reviewed by Dirk Pranke.
6649
6650         It's helpful to be able to run tests from the Skipped list of the performance tests.
6651
6652         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
6653         (PerfTestsRunner._parse_args):
6654         (PerfTestsRunner._collect_tests):
6655         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.
6656         (test_collect_tests_with_skipped_list):
6657
6658 2012-06-29  Tony Chang  <tony@chromium.org>
6659
6660         [GTK] Enable CSS grid layout LayoutTests on GTK+
6661         https://bugs.webkit.org/show_bug.cgi?id=90226
6662
6663         Reviewed by Martin Robinson.
6664
6665         This feature is disabled via Settings by default, but for testing,
6666         we enable it using layoutTestController.overridePreferences. Add the
6667         necessary plumbing for DRT.
6668
6669         WTR already works because support was added for Apple Mac earlier.
6670
6671         * DumpRenderTree/gtk/DumpRenderTree.cpp:
6672         (resetDefaultsToConsistentValues): Feature is off by default.
6673         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
6674         (LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.
6675
6676 2012-06-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
6677
6678         [Qt] Added Qt port for garden-o-matic.
6679         https://bugs.webkit.org/show_bug.cgi?id=82719
6680
6681         Reviewed by Adam Barth.
6682
6683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
6684         (.):
6685
6686 2012-06-29  Balazs Kelemen  <kbalazs@webkit.org>
6687
6688         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
6689         https://bugs.webkit.org/show_bug.cgi?id=90262
6690
6691         Reviewed by Alexey Proskuryakov.
6692
6693         Now that we decided to not support v8 in WebKit2
6694         we can get rid of using DumpRenderTreeSupportQt
6695         in WebKitTestRunner.
6696
6697         * Tools.pro:
6698         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
6699         (WTR::InjectedBundlePage::resetAfterTest):
6700         (WTR::InjectedBundlePage::didClearWindowForFrame):
6701         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
6702
6703 2012-06-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
6704
6705         Revert r121540, it broke most Qt builds
6706
6707         * qmake/mkspecs/features/default_post.prf:
6708         * qmake/mkspecs/features/functions.prf:
6709
6710 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
6711
6712         [Qt] Make build-webkit reject uknown configurations, eg. --profile
6713
6714         The qmake-based buildsystem doesn't support it.
6715
6716         Reviewed by Tor Arne Vestbø.
6717
6718         * Scripts/webkitdirs.pm:
6719         (buildQMakeProjects):
6720
6721 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
6722
6723         [Qt] Don't add Qt module dependencies in features.prf
6724
6725         The required dependencies are already added in WebCore.pri.
6726
6727         Reviewed by Tor Arne Vestbø.
6728
6729         * qmake/mkspecs/features/features.prf:
6730
6731 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
6732
6733         [Qt] Use LIBS_PRIVATE instead of putting dependencies into LIBS
6734
6735         Reviewed by Tor Arne Vestbø..
6736
6737         * qmake/mkspecs/features/default_post.prf:
6738         * qmake/mkspecs/features/functions.prf:
6739
6740 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
6741
6742         DOMHTMLCollection::item may return a wrong element after namedItem is called
6743         https://bugs.webkit.org/show_bug.cgi?id=90240
6744
6745         Reviewed by Antti Koivisto.
6746
6747         Add a WebKit API test since namedItem is not used in the JS/V8 binding code.
6748
6749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6750         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.html: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html.
6751         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm.
6752         (TestWebKitAPI::TEST):
6753
6754 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
6755
6756         nrwt: remove the 'google-chrome' port code
6757         https://bugs.webkit.org/show_bug.cgi?id=88824
6758
6759         Reviewed by Ojan Vafai.
6760
6761         NRWT now supports passing additional baseline directories
6762         and expectations files on the command line, so there's no need
6763         to support the concept of a 'google-chrome' port directly.
6764
6765         * Scripts/webkitpy/layout_tests/port/base.py:
6766         (Port.path_to_test_expectations_file):
6767         * Scripts/webkitpy/layout_tests/port/builders.py:
6768         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
6769         (ChromiumMacPort.__init__):
6770         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
6771         (ChromiumWinPort.__init__):
6772         * Scripts/webkitpy/layout_tests/port/factory.py:
6773         (PortFactory):
6774         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
6775         (FactoryTest.test_win):
6776         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Removed.
6777         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: Removed.
6778
6779 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
6780
6781         nrwt: clean up how arguments are passed to workers
6782         https://bugs.webkit.org/show_bug.cgi?id=90126
6783
6784         Reviewed by Ojan Vafai.
6785
6786         The way arguments are passed to workers has been crufty. It
6787         turns out it can be a lot cleaner via two things:
6788         1) using a factory method instead of instantiating objects
6789         directly in manager_worker_broker removes the need for passing
6790         'worker arguments' to the broker.
6791         2) it turns out that since mock hosts and test ports are purely
6792         in-memory constructions, they can be pickled and passed to child
6793         workers, meaning that the worker no longer needs hacky code to
6794         pass the port in a special case or to guess what to do if we
6795         don't have a host - all of the test-specific logic can move to
6796         the test file, where we can stub out the mock host's
6797         port_factory to return the same already-created port when it
6798         needs to be shared.
6799
6800         This change also moves WorkerException to manager_worker_broker.py
6801         where it belongs, and removes several useless tests that were
6802         just a maintenance burden (and would've needed rewriting when we
6803         change the rest of the broker implementation).
6804
6805         * Scripts/webkitpy/layout_tests/controllers/manager.py:
6806         (Manager._run_tests.worker_factory):
6807         (Manager._run_tests):
6808         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
6809         (get):
6810         (WorkerException):
6811         (AbstractWorker.__init__):
6812         (_ManagerConnection.__init__):
6813         (_ManagerConnection.start_worker):
6814         (_InlineManager.__init__):
6815         (_InlineManager.start_worker):
6816         (_MultiProcessManager._can_pickle_host):
6817         (_MultiProcessManager):
6818         (_MultiProcessManager.start_worker):
6819         (_WorkerConnection.__init__):
6820         (_InlineWorkerConnection.__init__):
6821         (_InlineWorkerConnection.join):
6822         (_InlineWorkerConnection.run):
6823         (_Process.run):
6824         (_MultiProcessWorkerConnection.__init__):
6825         (_MultiProcessWorkerConnection.start):
6826         (_MultiProcessWorkerConnection):
6827         (_MultiProcessWorkerConnection.run):
6828         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
6829         (_TestWorker.__init__):
6830         (_TestWorker.run):
6831         (_TestsMixin.test_name):
6832         (_TestsMixin.test_cancel):
6833         (_TestsMixin.test_done):
6834         (_TestsMixin.test_unknown_message):
6835         (InlineBrokerTests.setUp):
6836         (MultiProcessBrokerTests.setUp):
6837         * Scripts/webkitpy/layout_tests/controllers/worker.py:
6838         (Worker.__init__):
6839         (Worker.run):
6840         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Removed.
6841         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
6842         (passing_run):
6843         (logging_run):
6844         (run_and_capture):
6845         (MainTest.test_child_processes_2):
6846         (MainTest.test_child_processes_min):
6847         (MainTest.test_exception_raised):
6848         (MainTest.test_keyboard_interrupt):
6849         (MainTest.test_retrying_and_flaky_tests):
6850         (MainTest.test_run_order__inline):
6851
6852 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
6853
6854         nrwt: don't try to catch worker exceptions in run_webkit_tests.__main__
6855         https://bugs.webkit.org/show_bug.cgi?id=90125
6856
6857         Reviewed by Ojan Vafai.
6858
6859         It turns out run_webkit_tests.py wasn't really using
6860         WorkerException and the catch we had for it was pointless. I've
6861         removed the symbol import and moved it to the integration tests
6862         where it is needed. Eventually the definition of the exception
6863         moves to the broker module, and so minimizing the number of
6864         users of it is a good thing.
6865
6866         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6867         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
6868         (MainTest.test_exception_raised):
6869
6870 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
6871
6872         nrwt: clean up passing of log messages between processes
6873         https://bugs.webkit.org/show_bug.cgi?id=90123
6874
6875         Reviewed by Ojan Vafai.
6876
6877         It turns out log messages are perfectly picklable by themselves
6878         and contain the process id of the process that generated the
6879         message, so if we just pass the record from the worker to the
6880         manager and call logger.handle() in the manager, everything just
6881         works :).
6882
6883         The change is covered by existing tests.
6884
6885         * Scripts/webkitpy/layout_tests/controllers/manager.py:
6886         (Manager._log_messages):
6887         * Scripts/webkitpy/layout_tests/controllers/worker.py:
6888         (_WorkerLogHandler.emit):
6889         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
6890         (MeteredStream.__init__):
6891         (_LogHandler.emit):
6892
6893 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
6894
6895         add a pylint wrapper for linting python code
6896         https://bugs.webkit.org/show_bug.cgi?id=90232
6897
6898         Reviewed by Adam Barth.
6899
6900         Currently we use 'pep8' to check python code in
6901         check-webkit-style. pep8 is fast but simple; pylint is slower
6902         but has much more robust linting capabilities and will catch
6903         variable typos and all sorts of other things. Eventually we
6904         should switch check-webkit-style to use this, but our code is
6905         far from linting now so it needs to be cleaned up first.
6906
6907         This change adds the infrastructure and a wrapper so we can
6908         start doing that.
6909
6910         * Scripts/lint-webkitpy: Added.
6911         * Scripts/webkitpy/pylintrc: Added.
6912         * Scripts/webkitpy/thirdparty/__init__.py:
6913         (AutoinstallImportHook.find_module):
6914         (AutoinstallImportHook._install_pylint):
6915
6916 2012-06-28  Tony Chang  <tony@chromium.org>
6917
6918         [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
6919         https://bugs.webkit.org/show_bug.cgi?id=90215
6920
6921         Reviewed by Martin Robinson.
6922
6923         * DumpRenderTree/gtk/DumpRenderTree.cpp:
6924         (initializeFonts): Check for WEBKITOUTPUTDIR first.
6925         * Scripts/webkitpy/layout_tests/port/gtk.py:
6926         (GtkPort.setup_environ_for_server): Copy the environment variable to the child process.
6927         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
6928         (WTR::inititializeFontConfigSetting): Check for WEBKITOUTPUTDIR first.
6929
6930 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
6931
6932         derive ChromiumPort from WebKitPort in NRWT in order to support skipping tests if symbols are missing
6933         https://bugs.webkit.org/show_bug.cgi?id=89706
6934
6935         Reviewed by Ojan Vafai.
6936
6937         Try again to land the change first landed in r121363. This patch
6938         adds a bunch more tests and reworks the handling of
6939         port-specific default values for --pixel-tests and --time-out-ms
6940         to be more consistent (adding a default_pixel_tests() method,
6941         pushing the webkit default_timeout_ms() value up into base.py,
6942         and overriding it properly in the chromium and apple mac ports.
6943
6944         Also change the logic in
6945         run_webkit_tests._setup_derived_options() to not second-guess
6946         what the port wants the timeout value to be for debug builds;
6947         computing this in two different places led to several bugs.
6948
6949         This change also changes the Chromium unittest ports to derive
6950         from ChromiumPortTestCase instead of PortTestCase, so that we
6951         ensure that we're running the same tests on all port variants
6952         more easily. There's more cleanup that can be done here, but
6953         this is good enough for now
6954
6955         * Scripts/webkitpy/layout_tests/port/base.py:
6956         (Port.default_pixel_tests):
6957         (Port):
6958         (Port.default_timeout_ms):
6959         * Scripts/webkitpy/layout_tests/port/chromium.py:
6960         (ChromiumPort):
6961         (ChromiumPort.__init__):
6962         (ChromiumPort.default_pixel_tests):
6963         (ChromiumPort.default_timeout_ms):
6964         (ChromiumPort.driver_name):
6965         (ChromiumPort._driver_class):
6966         (ChromiumPort._missing_symbol_to_skipped_tests):
6967         (ChromiumPort.skipped_layout_tests):
6968         (ChromiumPort.setup_test_run):
6969         (ChromiumPort._path_to_image_diff):
6970         (ChromiumPort._convert_path):
6971         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
6972         (ChromiumAndroidPortTest):
6973         (ChromiumAndroidPortTest.test_expectations_files):
6974         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
6975         (ChromiumLinuxPort._modules_to_search_for_symbols):
6976         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
6977         (ChromiumLinuxPortTest):
6978         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
6979         (ChromiumMacPort._modules_to_search_for_symbols):
6980         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
6981         (ChromiumMacPortTest):
6982         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
6983         split off from chromium_unittest.
6984         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
6985         (ChromiumWinPort._modules_to_search_for_symbols):
6986         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
6987         (ChromiumWinTest):
6988         * Scripts/webkitpy/layout_tests/port/mac.py:
6989         (MacPort.default_timeout_ms):
6990         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
6991         (MacTest.test_default_timeout_ms):
6992         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
6993         (MockDRTPort.start_http_server):
6994         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
6995         (PortTestCase.test_default_timeout_ms):
6996         (PortTestCase):
6997         (PortTestCase.test_default_pixel_tests):
6998         * Scripts/webkitpy/layout_tests/port/test.py:
6999         (TestPort.default_pixel_tests):
7000         * Scripts/webkitpy/layout_tests/port/webkit.py:
7001         (WebKitPort._modules_to_search_for_symbols):
7002         (WebKitPort):
7003         (WebKitPort._symbols_string):
7004         (WebKitPort._skipped_tests_for_unsupported_features):
7005         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
7006         (TestWebKitPort._symbols_string):
7007         (TestWebKitPort._tests_for_disabled_features):
7008         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7009         (_set_up_derived_options):
7010
7011 2012-06-28  Joshua Bell  <jsbell@chromium.org>
7012
7013         run-bindings-tests should return non-zero exit code on test failure
7014         https://bugs.webkit.org/show_bug.cgi?id=90205
7015
7016         Reviewed by Adam Barth.
7017
7018         * Scripts/run-bindings-tests:
7019         (main):
7020
7021 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
7022
7023         [chromium] Reset the device scale factor to 1 before each test is run
7024         https://bugs.webkit.org/show_bug.cgi?id=90212
7025
7026         Reviewed by Adam Barth.
7027
7028         Some tests change the device scale factor, so this needs to be reset to
7029         1.0 at the start of each test to avoid test flakiness.
7030
7031         * DumpRenderTree/chromium/LayoutTestController.cpp:
7032         (LayoutTestController::reset):
7033
7034 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
7035
7036         Cleanup HTMLFormCollection
7037         https://bugs.webkit.org/show_bug.cgi?id=90111
7038
7039         Reviewed by Andreas Kling.
7040
7041         Add a WebKit API test using copy-paste design pattern per kling's request.
7042
7043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7044         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html: Added.
7045         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm: Added.
7046         (-[HTMLFormCollectionNamedItemTest webView:didFinishLoadForFrame:]):
7047         (TestWebKitAPI):
7048         (TestWebKitAPI::TEST):
7049
7050 2012-06-28  Tim Horton  <timothy_horton@apple.com>
7051
7052         [mac] WKTR windows still don't stay off screen sometimes
7053         https://bugs.webkit.org/show_bug.cgi?id=90214
7054         <rdar://problem/11760263>
7055
7056         Reviewed by Simon Fraser.
7057
7058         In some cases, the system itself will consult [WebKitTestRunnerWindow frame], so we should refrain from
7059         overriding it and instead provide a different method to use when we want the web-facing "fake" window origin
7060         (for PlatformWebView::windowFrame()).
7061
7062         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
7063         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
7064         (WTR::PlatformWebView::windowFrame):
7065
7066 2012-06-28  Martin Robinson  <mrobinson@igalia.com>
7067
7068         [GTK] Add unit tests for GtkInputMethodFilter
7069         https://bugs.webkit.org/show_bug.cgi?id=88698
7070
7071         Reviewed by Carlos Garcia Campos.
7072
7073         Add unit tests for GtkInputMethodFilter in the WebCore platform layer.
7074         This change adds the TestGtk test suite which will be used for all non-API
7075         layer GTK unit tests.
7076
7077         * TestWebKitAPI/GNUmakefile.am: Update the build to include the new tests.
7078         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Added.
7079         (TestWebKitAPI::PlatformWebView::PlatformWebView): Remove the call to gtk_init here
7080         as it's now in main.cpp.
7081         * TestWebKitAPI/gtk/main.cpp: Change the g_type_init call to gtk_init, because now
7082         a majority of all unit tests depend on GTK+ being initialized.
7083
7084 2012-06-28  Christophe Dumez  <christophe.dumez@intel.com>
7085
7086         [EFL] Enable support for HTML5 datalist
7087         https://bugs.webkit.org/show_bug.cgi?id=90157
7088
7089         Reviewed by Martin Robinson.
7090
7091         Turn on DATALIST flag by default on EFL port to
7092         support HTML5 datalist tag.
7093
7094         * Scripts/webkitperl/FeatureList.pm:
7095
7096 2012-06-28  Tony Chang  <tony@chromium.org>
7097
7098         Enable CSS grid layout LayoutTests on platform Mac
7099         https://bugs.webkit.org/show_bug.cgi?id=90113
7100
7101         Reviewed by Ojan Vafai.
7102
7103         * DumpRenderTree/mac/DumpRenderTree.mm:
7104         (resetDefaultsToConsistentValues): Reset the value to NO between tests.
7105
7106 2012-06-28  Mike Fenton  <mifenton@rim.com>
7107
7108         [BlackBerry] Add watchlist options for Blackberry and editing.
7109         https://bugs.webkit.org/show_bug.cgi?id=90193
7110
7111         Unreviewed.
7112
7113         Add BlackBerry and Editing watchlist and monitor them.
7114
7115         * Scripts/webkitpy/common/config/watchlist:
7116
7117 2012-06-28  Tim Horton  <timothy_horton@apple.com>
7118
7119         Unreviewed, upgrade myself to a reviewer!
7120
7121         http://www.webkit.org/blog/2082/tim-horton-is-now-a-webkit-reviewer/
7122
7123         * Scripts/webkitpy/common/config/committers.py:
7124
7125 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
7126
7127         [Chromium] Chromium's LayoutTestController is missing setBackingScaleFactor
7128         https://bugs.webkit.org/show_bug.cgi?id=83635
7129
7130         Reviewed by Adam Barth.
7131
7132         Added InvokeCallbackTask, a new derived class of MethodTask. When
7133         setBackingScaleFactor is called, a call to setDeviceScaleFactor in
7134         WebView is made and then postTask is used to invoke the callback
7135         function specified in testRunner.setBackingScaleFactor.
7136
7137         * DumpRenderTree/chromium/LayoutTestController.cpp:
7138         (LayoutTestController::LayoutTestController):
7139         (InvokeCallbackTask):
7140         (InvokeCallbackTask::InvokeCallbackTask):
7141         (InvokeCallbackTask::runIfValid):
7142         (LayoutTestController::setBackingScaleFactor):
7143         * DumpRenderTree/chromium/LayoutTestController.h:
7144         (LayoutTestController):
7145
7146 2012-06-28  Ojan Vafai  <ojan@chromium.org>
7147
7148         Make rebaseline-test and rebaseline-expectations work for non-Chromium ports
7149         https://bugs.webkit.org/show_bug.cgi?id=90186
7150
7151         Reviewed by Adam Barth.
7152
7153         This makes rebaselining work for all ports that have a TestExpectations file
7154         in the tree. I didn't test other ports.
7155
7156         This doesn't address 100% of the problem. The rebaseline code puts the expectations
7157         in the most specific directory and relies on optimize-baselines to merge baselines
7158         appropriately. This only works if every platform directory has an equivalent bot
7159         that runs the tests, which is not true for most ports.
7160
7161         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
7162         (Builder._revision_and_build_for_filename):
7163         Some bots have filenames that aren't revision/build number pairs
7164         e.g. they are random junk like aQhxvx. Handle this gracefully.
7165         (Builder._fetch_revision_to_build_map):
7166         (Builder._file_info_list_to_revision_to_build_list):
7167         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
7168         (BuilderTest.test_build_and_revision_for_filename):
7169         (BuilderTest.test_file_info_list_to_revision_to_build_list):
7170         * Scripts/webkitpy/layout_tests/port/builders.py:
7171         Update the list of builders. This list needs to be kept up
7172         to date for the rebaseline tool to work.
7173         * Scripts/webkitpy/tool/commands/rebaseline.py:
7174         (RebaselineTest._results_url):
7175         (RebaselineExpectations._run_webkit_patch):
7176         (RebaselineExpectations._rebaseline_port):
7177         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
7178         Qt port uses qmake to determine the right version. Systems without qmake correctly fallback
7179         to a specific version.
7180
7181 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
7182
7183         [Qt][NRWT] Fix baseline and skipped file search path.
7184         https://bugs.webkit.org/show_bug.cgi?id=89882
7185
7186         Unreviewed trivial typo fix after r121430.
7187
7188         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
7189         (QtPortTest._assert_search_path):
7190         (QtPortTest._assert_skipped_path):
7191
7192 2012-06-28  János Badics  <jbadics@inf.u-szeged.hu>
7193
7194         [Qt][NRWT] Fix baseline and skipped file search path.
7195         https://bugs.webkit.org/show_bug.cgi?id=89882
7196
7197         Reviewed by Csaba Osztrogonác.
7198
7199         * Scripts/webkitpy/layout_tests/port/qt.py:
7200         (QtPort._search_paths):
7201         (QtPort):
7202         (QtPort.baseline_search_path):
7203         (QtPort._skipped_file_search_paths):
7204         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
7205         (QtPortTest):
7206         (QtPortTest._assert_skipped_path):
7207         (QtPortTest.test_baseline_search_path):
7208         (QtPortTest.test_skipped_file_search_path):
7209
7210 2012-06-28  Alexander Pavlov  <apavlov@chromium.org>
7211
7212         [Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS)
7213         https://bugs.webkit.org/show_bug.cgi?id=90167
7214
7215         Reviewed by Csaba Osztrogonác.
7216
7217         DRT should remove user stylesheets from the page group when resetting before running another test.
7218
7219         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
7220         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
7221
7222 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
7223
7224         [Qt][DRT] Reset AcceleratedCompositingEnabled between tests
7225         https://bugs.webkit.org/show_bug.cgi?id=90164
7226
7227         Reviewed by Simon Hausmann.
7228
7229         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
7230         (WebCore::WebPage::resetSettings):
7231
7232 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
7233
7234         [Qt] Restore original value of mock scrollbars between tests
7235         https://bugs.webkit.org/show_bug.cgi?id=90155
7236
7237         Reviewed by Simon Hausmann.
7238
7239         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
7240         (WebCore::WebPage::resetSettings):
7241         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
7242         (LayoutTestController::setMockScrollbarsEnabled):
7243         * DumpRenderTree/qt/LayoutTestControllerQt.h:
7244         (LayoutTestController):
7245
7246 2012-06-27  Mark Rowe  <mrowe@apple.com>
7247
7248         <http://webkit.org/b/90096> Building within Xcode sometimes does a full rebuild after building via build-webkit
7249
7250         We need to ensure that build-webkit uses the same setting for SHARED_PRECOMPS_DIR
7251         as what Xcode itself will use when building, otherwise switching between the two
7252         can result in the precompiled headers being rebuilt and thus the entire world
7253         rebuilding.
7254
7255         Reviewed by Dan Bernstein.
7256
7257         * Scripts/webkitdirs.pm:
7258         (determineBaseProductDir):
7259
7260 2012-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
7261
7262         Unreviewed, rolling out r121363, r121367, r121384, and
7263         r121390.
7264         http://trac.webkit.org/changeset/121363
7265         http://trac.webkit.org/changeset/121367
7266         http://trac.webkit.org/changeset/121384
7267         http://trac.webkit.org/changeset/121390
7268         https://bugs.webkit.org/show_bug.cgi?id=90134
7269
7270         It broke debug NRWT on GTK and on Qt (Requested by Ossy_NIGHT
7271         on #webkit).
7272
7273         * Scripts/webkitpy/layout_tests/port/chromium.py:
7274         (ChromiumPort):
7275         (ChromiumPort.__init__):
7276         (ChromiumPort._check_file_exists):
7277         (ChromiumPort.default_results_directory):
7278         (ChromiumPort._driver_class):
7279         (ChromiumPort._build_path):
7280         (ChromiumPort._path_to_image_diff):
7281         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
7282         (ChromiumLinuxPort.baseline_search_path):
7283         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
7284         (ChromiumMacPort.baseline_search_path):
7285         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
7286         (ChromiumPortTest):
7287         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
7288         (ChromiumWinPort.baseline_search_path):
7289         * Scripts/webkitpy/layout_tests/port/webkit.py:
7290         (WebKitPort.__init__):
7291         (WebKitPort._webcore_symbols_string):
7292         (WebKitPort._skipped_tests_for_unsupported_features):
7293         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
7294         (TestWebKitPort._webcore_symbols_string):
7295         (WebKitPortUnitTests.test_default_options):
7296
7297 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
7298
7299         Fix typo in r121384 :(
7300
7301         Unreviewed, build fix.
7302
7303         * Scripts/webkitpy/layout_tests/port/webkit.py:
7304         (WebKitPort.default_test_timeout_ms):
7305
7306 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
7307
7308         nrwt: default timeout for debug bots broke in r121363
7309         https://bugs.webkit.org/show_bug.cgi?id=90112
7310
7311         Unreviewed, build fix.
7312
7313         I forgot to account for release and debug having different
7314         default values :(.
7315
7316         * Scripts/webkitpy/layout_tests/port/chromium.py:
7317         (ChromiumPort.default_test_timeout_ms):
7318         * Scripts/webkitpy/layout_tests/port/webkit.py:
7319         (WebKitPort):
7320         (WebKitPort.default_test_timeout_ms):
7321         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
7322         (WebKitPortUnitTests.test_default_options):
7323
7324 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
7325
7326         webkitpy: fix a couple of issues running under cygwin
7327         https://bugs.webkit.org/show_bug.cgi?id=90035
7328
7329         Reviewed by Eric Seidel.
7330
7331         These were causing unit tests to fail on cygwin (apple win bot).
7332
7333         * Scripts/webkitpy/layout_tests/port/chromium.py:
7334         * Scripts/webkitpy/performance_tests/perftest.py:
7335
7336 2012-06-27  Adam Barth  <abarth@webkit.org>
7337
7338         [Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available
7339         https://bugs.webkit.org/show_bug.cgi?id=89801
7340
7341         Reviewed by Nate Chapin.
7342
7343         Let's call SkUseTestFontConfigFile now that it exists.
7344
7345         * DumpRenderTree/chromium/TestShellAndroid.cpp:
7346         (platformInit):
7347
7348 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
7349
7350         Fix typo introduced in r121363.
7351
7352         Unreviewed, build fix.
7353
7354         * Scripts/webkitpy/layout_tests/port/webkit.py:
7355         (WebKitPort._symbols_string):
7356
7357 2012-06-27  Mark Hahnenberg  <mhahnenberg@apple.com>
7358
7359         Moving from committers to reviewers :-)
7360
7361         Rubber stamped by Filip Pizlo.
7362
7363         * Scripts/webkitpy/common/config/committers.py:
7364
7365 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
7366
7367         Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests
7368         https://bugs.webkit.org/show_bug.cgi?id=89706
7369
7370         Reviewed by Adam Barth.
7371
7372         Based on the original patch by Raymond Toy.
7373
7374         This patch changes ChromiumPort to derive from webkit.WebKitPort
7375         instead of base.Port. This is a long-awaited change and a
7376         precursor to merging base.Port and webkit.WebKitPort, but is
7377         driven by the desire to dynamically detect whether the MP3 and
7378         AAC codecs are compiled into DRT on Chromium, for which we
7379         wanted to re-use the existing logic in WebKit port for determine
7380         what to skip at compile time.
7381
7382         Most of the changes are shuffling things around so that we don't
7383         change any other logic and so we override the necessary methods
7384         in WebKitPort (and try to follow the same method definition
7385         order where possible).
7386
7387         Also, on the Chromium port the mp3 and aac codecs are actually
7388         defined in a separate library, so scanning webcore isn't
7389         sufficient. This patch generalizes the symbol lookup to handle
7390         multiple libraries, and uses different libraries as appropriate
7391         for Chromium.
7392
7393         The only functional/visible changes should be in the value
7394         returned for skipped_layout_tests().
7395
7396         * Scripts/webkitpy/layout_tests/port/chromium.py:
7397         (ChromiumPort):
7398         (ChromiumPort.__init__):
7399         (ChromiumPort.driver_name):
7400         (ChromiumPort._driver_class):
7401         (ChromiumPort._missing_symbol_to_skipped_tests):
7402         (ChromiumPort.skipped_layout_tests):
7403         (ChromiumPort.setup_test_run):
7404         (ChromiumPort._path_to_image_diff):
7405         (ChromiumPort._convert_path):
7406         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
7407         (ChromiumPortTest.test_missing_symbol_to_skipped_tests):
7408         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
7409         (ChromiumLinuxPort._modules_to_search_for_symbols):
7410         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
7411         (ChromiumLinuxPort._modules_to_search_for_symbols):
7412         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
7413         (ChromiumLinuxPort._modules_to_search_for_symbols):
7414         * Scripts/webkitpy/layout_tests/port/webkit.py:
7415         (WebKitPort):
7416         (WebKitPort.__init__):
7417         (WebKitPort._symbols_string):
7418         (WebKitPort._modules_to_search_for_symbols):
7419
7420 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
7421
7422         [Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
7423         https://bugs.webkit.org/show_bug.cgi?id=90081
7424
7425         Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.
7426
7427         Reviewed by Noam Rosenthal.
7428
7429         * qmake/mkspecs/features/features.prf:
7430
7431 2012-06-27  Sergio Villar Senin  <svillar@igalia.com>
7432
7433         [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
7434         https://bugs.webkit.org/show_bug.cgi?id=90061
7435
7436         Reviewed by Gustavo Noronha Silva.
7437
7438         Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
7439         this flag libtool tells the linker to set the rpath for the output
7440         file to the full path of the .libs directory, instead of using a
7441         wrapper script to set up the LD_LIBRARY_PATH. This will allow us
7442         to directly reuse builds in the pure testing bots.
7443
7444         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
7445
7446 2012-06-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
7447
7448         [Qt] No need to save and restore TEMPLATE in a function
7449
7450         This was a leftover from when the logic was not in its own function scope.
7451
7452         QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
7453         will surprisingly affect the global scope as well, so we have to save and restore it.
7454
7455         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
7456
7457         Reviewed by Tor Arne Vestbø.
7458
7459         * qmake/mkspecs/features/functions.prf:
7460
7461 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
7462
7463         [Qt] Fix lookup location for sqlite sources
7464
7465         Don't look in the install dir - we are unlikely to find anything there
7466         unless we are doing a developer build.
7467
7468         Reviewed by Tor Arne Vestbø.
7469
7470         * qmake/mkspecs/features/features.prf:
7471
7472 2012-06-27  Zan Dobersek  <zandobersek@gmail.com>
7473
7474         [Gtk] Add support for the Gamepad API
7475         https://bugs.webkit.org/show_bug.cgi?id=87503
7476
7477         Reviewed by Carlos Garcia Campos.
7478
7479         Enable the gamepad support for the GTK port.
7480
7481         * Scripts/webkitperl/FeatureList.pm:
7482
7483 2012-06-27  Ryosuke Niwa  <rniwa@webkit.org>
7484
7485         Fix gcc build after r121302
7486         https://bugs.webkit.org/show_bug.cgi?id=90055
7487
7488         Reviewed by Mark Rowe.
7489
7490         Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
7491
7492         It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
7493
7494         * TestWebKitAPI/Configurations/Base.xcconfig:
7495         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
7496         (TestWebKitAPI::AcceptsFirstMouse::runTest):
7497
7498 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
7499
7500         Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
7501         https://bugs.webkit.org/show_bug.cgi?id=89564
7502
7503         Reviewed by Tony Chang.
7504
7505         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
7506         (BuildStepsConstructorTest):
7507         (BuildStepsConstructorTest.generateTests):
7508         (BuildStepsConstructorTest.createTest):
7509         (BuildStepsConstructorTest.createTest.doTest):
7510
7511 2012-06-26  Mark Hahnenberg  <mhahnenberg@apple.com>
7512
7513         Add support for preciseTime() to WebKitTestRunner
7514         https://bugs.webkit.org/show_bug.cgi?id=90027
7515
7516         Reviewed by Darin Adler.
7517
7518         It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
7519
7520         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
7521         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
7522         (WTR::LayoutTestController::preciseTime):
7523         (WTR):
7524         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
7525         (LayoutTestController):
7526
7527 2012-06-26  Lucas Forschler  <lforschler@apple.com>
7528
7529       Teach the Apple port how to build the test tools in build-webkit
7530       https://bugs.webkit.org/show_bug.cgi?id=89540
7531
7532       Reviewed by Jon Lee & Simon Fraser.
7533
7534       * BuildSlaveSupport/build.webkit.org-config/master.cfg:
7535       (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
7536       (RunUnitTests.start): ditto
7537       * Scripts/build-webkit: add tools to the projects build list
7538
7539 2012-06-26  Ojan Vafai  <ojan@chromium.org>
7540
7541         Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
7542         https://bugs.webkit.org/show_bug.cgi?id=90025
7543
7544         Reviewed by Simon Fraser.
7545
7546         Move the chromium-specific filtering code into config.js and replace it with a method on each platform
7547         config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
7548
7549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
7550         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
7551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
7552
7553 2012-06-26  Ojan Vafai  <ojan@chromium.org>
7554
7555         Fix failing garden-o-matic unittests
7556         https://bugs.webkit.org/show_bug.cgi?id=90021
7557
7558         Reviewed by Adam Barth.
7559
7560         These had all just fallen out of date.
7561
7562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
7563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
7564         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
7565
7566 2012-06-26  Ojan Vafai  <ojan@chromium.org>
7567
7568         Fix platform picker change handler in garden-o-matic
7569         https://bugs.webkit.org/show_bug.cgi?id=90010
7570
7571         Reviewed by Simon Fraser.
7572
7573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
7574         The old code never worked. This is hard to test because change handlers require
7575         a user-initiated action and the code is changing the window's location, which would
7576         navigate the test page.
7577
7578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
7579         Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
7580         due to the large margin-bottom.
7581
7582 2012-06-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
7583
7584         webkitpy: Make webkit-patch patches-to-review useful
7585         https://bugs.webkit.org/show_bug.cgi?id=89470
7586
7587         Reviewed by Eric Seidel.
7588
7589         webkit-patch patches-to-review will now output the list of
7590         bugs with patches pending for review that has the user on CC,
7591         excluding patches with cq-, sorted by the age of the patch.
7592
7593         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
7594         (BugzillaQueries.fetch_bugs_from_review_queue):
7595         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
7596         (MockBugzillaQueries.fetch_bugs_from_review_queue):
7597         (MockBugzilla.__init__):
7598         (MockBugzilla.authenticate):
7599         * Scripts/webkitpy/tool/commands/queries.py:
7600         (PatchesToReview):
7601         (PatchesToReview.__init__):
7602         (PatchesToReview._print_report):
7603         (PatchesToReview._generate_report):
7604         (PatchesToReview.execute):
7605         * Scripts/webkitpy/tool/commands/queries_unittest.py:
7606         (QueryCommandsTest.test_patches_to_review):
7607
7608 2012-06-26  Dirk Pranke  <dpranke@chromium.org>
7609
7610         nrwt: broken for chromium on vista
7611         https://bugs.webkit.org/show_bug.cgi?id=89988
7612
7613         Reviewed by Tony Chang.
7614
7615         r121194 removed support for 'chromium-win-vista' as a separate
7616         port, but this actually prevented the code from running on vista
7617         at all, which is unduly harsh and broke the websocket tests on
7618         the (non-webkit) chromium bots that are still running on vista.
7619
7620         It's probably good enough to pretend that vista is win7 instead;
7621         some layout tests will still fail but at least things'll run.
7622
7623         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
7624         (ChromiumWinPort.determine_full_port_name):
7625         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
7626         (ChromiumWinTest.test_versions):
7627
7628 2012-06-26  Csaba Osztrogonác  <ossy@webkit.org>
7629
7630         master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
7631         https://bugs.webkit.org/show_bug.cgi?id=89215
7632
7633         We need it because it is deprecated and will be dropped in buildbot 0.8.7
7634
7635         Reviewed by Tony Chang.
7636
7637         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
7638         (CheckOutSource.__init__):
7639         (Factory.__init__):
7640
7641 2012-06-26  Simon Hausmann  <simon.hausmann@nokia.com>
7642
7643         [Qt][Win] Symbols are not exported in QtWebKit5.dll
7644         https://bugs.webkit.org/show_bug.cgi?id=88873
7645
7646         Reviewed by Tor Arne Vestbø.
7647
7648         When linking the target dll make sure to re-export the symbols from
7649         the static libraries marked as export, with the help of a little python
7650         script and a qmake extra compiler.
7651
7652         * Scripts/generate-win32-export-forwards: Added.
7653         * qmake/mkspecs/features/win32/default_post.prf:
7654
7655 2012-06-25  Jocelyn Turcotte  <turcotte.j@gmail.com>
7656
7657         Add a note about hostname completion not working well with --cc completion
7658
7659         Reviewed by Simon Hausmann.
7660
7661         Hostname completion tries to resolve anything after an @ sign which is present
7662         in the completed list of contributor emails to CC.
7663
7664         * Scripts/webkit-tools-completion.sh:
7665
7666 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
7667
7668         Unreviewed, rolling out r121244.
7669         http://trac.webkit.org/changeset/121244
7670         https://bugs.webkit.org/show_bug.cgi?id=89966
7671
7672         skip list path is incorrect now. (Requested by Ossy on
7673         #webkit).
7674
7675         * Scripts/webkitpy/layout_tests/port/qt.py:
7676         (QtPort.baseline_search_path):
7677         (QtPort._skipped_file_search_paths):
7678         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
7679         (QtPortTest.test_baseline_search_path):
7680
7681 2012-06-26  János Badics  <jbadics@inf.u-szeged.hu>
7682
7683         [Qt][NRWT] Fix baseline and skipped file search path.
7684         https://bugs.webkit.org/show_bug.cgi?id=89882
7685
7686         Reviewed by Csaba Osztrogonác.
7687
7688         * Scripts/webkitpy/layout_tests/port/qt.py:
7689         (QtPort.baseline_search_path):
7690         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
7691         (QtPortTest.test_baseline_search_path):
7692
7693 2012-06-26  Tony Chang  <tony@chromium.org>
7694
7695         [Qt] Enable grid layout LayoutTests
7696         https://bugs.webkit.org/show_bug.cgi?id=89909
7697
7698         Reviewed by Csaba Osztrogonác.
7699
7700         These tests pass, we just need to hook up the overridePreference.
7701
7702         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
7703         (WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
7704         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
7705         (LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
7706
7707 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
7708
7709         Unreviewed, rolling out r121236.
7710         http://trac.webkit.org/changeset/121236
7711         https://bugs.webkit.org/show_bug.cgi?id=89956
7712
7713         It's broke the nrwt on qt and gtk platform (Requested by
7714         kkristof on #webkit).
7715
7716         * Scripts/webkitpy/layout_tests/port/qt.py:
7717         (QtPort._build_driver):
7718         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
7719         (XvfbDriver._start):
7720         (XvfbDriver._start.x_filter):
7721         (XvfbDriver.stop):
7722
7723 2012-06-26  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
7724
7725         [NRWT] XvfbDriver should choose the next free display
7726         https://bugs.webkit.org/show_bug.cgi?id=88414
7727
7728         Reviewed by Dirk Pranke.
7729
7730         * Scripts/webkitpy/layout_tests/port/qt.py:
7731         (QtPort._driver_class):
7732         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
7733         (XvfbDriver.__init__):
7734         (XvfbDriver._start):
7735         (XvfbDriver._start.next_free_id):
7736         (XvfbDriver.stop):
7737
7738 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
7739
7740         [Qt] Make it possible to build WebKit without QtWidgets
7741         https://bugs.webkit.org/show_bug.cgi?id=78109
7742
7743         Reviewed by Tor Arne Vestbø.
7744
7745         * Tools.pro: Disable various tools that depend on WK1.
7746         * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
7747         * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
7748         * qmake/mkspecs/modules/webkit1.prf: Added.
7749
7750 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
7751
7752         put vista back for chromium (non-webkit) bots ...
7753         https://bugs.webkit.org/show_bug.cgi?id=89929
7754
7755         Unreviewed, build fix.
7756
7757         Turns out we've only gotten rid of vista on the webkit tests so
7758         far. Put vista back for the other chromium bots ...
7759
7760         * TestResultServer/static-dashboards/flakiness_dashboard.js:
7761         (chromiumPlatform):
7762         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
7763         (test):
7764
7765 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
7766
7767         update flakiness dashboard after removing chromium-vista bots
7768         https://bugs.webkit.org/show_bug.cgi?id=89925
7769
7770         Unreviewed, build fix.
7771
7772         More changes missed in r121194 :(.
7773
7774         * TestResultServer/static-dashboards/flakiness_dashboard.js:
7775         (chromiumPlatform):
7776         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
7777         (test):
7778
7779 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
7780
7781         remove support for chromium vista from tools
7782         https://bugs.webkit.org/show_bug.cgi?id=89915
7783
7784         Reviewed by Tony Chang.
7785
7786         This change is all deleting code and updating tests to handle
7787         the configuration being gone. All tests now pass except for a
7788         few unittests for the flakiness dashboard which were failing
7789         before this patch.
7790
7791         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
7792         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
7793         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
7794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
7795         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
7796         (BaselineOptimizerTest.test_complex_shadowing):
7797         * Scripts/webkitpy/layout_tests/port/builders.py:
7798         * Scripts/webkitpy/layout_tests/port/chromium.py:
7799         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
7800         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
7801         (ChromiumWinPort):
7802         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
7803         (ChromiumWinTest.test_versions):
7804         (ChromiumWinTest.test_baseline_path):
7805         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
7806         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
7807         (BuildCoverageExtrapolatorTest.test_extrapolate):
7808
7809 2012-06-25  Scott Graham  <scottmg@chromium.org>
7810
7811         [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
7812         https://bugs.webkit.org/show_bug.cgi?id=89907
7813
7814         Not reviewed. Fix build in Chromium.
7815
7816         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
7817         (WebThemeEngineDRTWin::getSize):
7818         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
7819         (WebThemeEngineDRTWin):
7820
7821 2012-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
7822
7823         [EFL] Implement Network Information API
7824         https://bugs.webkit.org/show_bug.cgi?id=87067
7825
7826         Reviewed by Kenneth Rohde Christiansen.
7827
7828         * efl/jhbuild.modules: Add eeze library dependency.
7829
7830 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
7831
7832         [Qt] Fix Win32 debug build
7833
7834         Reviewed by Tor Arne Vestbø.
7835
7836         Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
7837
7838         * qmake/mkspecs/features/unix/default_pre.prf:
7839         * qmake/mkspecs/features/win32/default_pre.prf: Added.
7840
7841 2012-06-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
7842
7843         [Qt] Enable <input type="color"> support by default
7844         https://bugs.webkit.org/show_bug.cgi?id=89653
7845
7846         Reviewed by Kenneth Rohde Christiansen.
7847
7848         This feature is complete for Qt WebKit2. Enabling by default
7849         will help to mature the implementation.
7850
7851         * Scripts/webkitperl/FeatureList.pm:
7852         * qmake/mkspecs/features/features.pri:
7853
7854 2012-06-24  Dan Bernstein  <mitz@apple.com>
7855
7856         Made debug-{minibrowser,safari,test-runner} work with LLDB.
7857
7858         Reviewed by Sam Weinig.
7859
7860         * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
7861         printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
7862         * Scripts/debug-safari: Ditto.
7863         * Scripts/debug-test-runner: Ditto.
7864         * Scripts/webkitdirs.pm:
7865         (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
7866         (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
7867         and to "gdb" otherwise.
7868         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
7869         --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
7870         (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
7871
7872 2012-06-24  Adam Barth  <abarth@webkit.org>
7873
7874         [Chromium] Release media resources after each LayoutTest on Android
7875         https://bugs.webkit.org/show_bug.cgi?id=89720
7876
7877         Reviewed by Eric Carlson.
7878
7879         The LayoutTests can hang when run on Android because we sometimes run
7880         out of media resources. This patch causes us to release our media
7881         resources after each test in order to avoid running out of this
7882         resource. In production, there are other mechanisms that manage this
7883         resource.
7884
7885         * DumpRenderTree/chromium/TestShell.cpp:
7886         (TestShell::resetTestController):
7887
7888 2012-06-23  Zan Dobersek  <zandobersek@gmail.com>
7889
7890         [Gtk] REGRESSION(r120918): Causes flaky DND tests
7891         https://bugs.webkit.org/show_bug.cgi?id=89770
7892
7893         Reviewed by Martin Robinson.
7894
7895         Connect to the run-file-chooser signal of the WebKitWebView and
7896         return TRUE so no file chooser dialog is run. This prevents certain
7897         test failures.
7898
7899         * DumpRenderTree/gtk/DumpRenderTree.cpp:
7900         (webViewRunFileChooser):
7901         (createWebView):
7902
7903 2012-06-23  Dan Bernstein  <mitz@apple.com>
7904
7905         debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
7906
7907         Reviewed by Sam Weinig.
7908
7909         * Scripts/webkitdirs.pm:
7910         (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
7911
7912 2012-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
7913
7914         Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
7915
7916         It fails always when running it in Xvfb.
7917
7918         * gtk/run-api-tests:
7919         (TestRunner):
7920
7921 2012-06-23  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
7922
7923         [GTK][WK2]Mis-spelt defaultWindowTitle
7924         https://bugs.webkit.org/show_bug.cgi?id=89808
7925
7926         Reviewed by Carlos Garcia Campos.
7927
7928         * MiniBrowser/gtk/BrowserWindow.c:
7929
7930 2012-06-23  Sergio Villar Senin  <svillar@igalia.com>
7931
7932         [GTK] Add a new webkit2 tests slave bot
7933         https://bugs.webkit.org/show_bug.cgi?id=89336
7934
7935         Reviewed by Csaba Osztrogonác.
7936
7937         Slave configuration for a new GTK 64 bit release bot that will run
7938         WebKit2 tests.
7939
7940         Also BuildAndTest now accepts the "triggers" parametter,
7941         this means that apart from building and testing it can trigger
7942         some other build/test sequences in other slaves.
7943
7944         * BuildSlaveSupport/build.webkit.org-config/config.json:
7945         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
7946         (BuildAndTestFactory.__init__):
7947
7948 2012-06-23  Kwang Yul Seo  <skyul@company100.net>
7949
7950         Unreviewed. Update my email.
7951
7952         * Scripts/webkitpy/common/config/committers.py:
7953
7954 2012-06-22  Adam Barth  <abarth@webkit.org>
7955
7956         [Chromium] DumpRenderTree on Android needs to configure fonts for testing
7957         https://bugs.webkit.org/show_bug.cgi?id=89721
7958
7959         Reviewed by Nate Chapin.
7960
7961         This patch teaches DumpRenderTree to configure Skia to use the fallback
7962         fonts that the LayoutTests assume. This patch reduces the number result
7963         differences between chromium-android and chromium-linux.
7964
7965         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
7966         * DumpRenderTree/chromium/TestShellAndroid.cpp:
7967         (platformInit):
7968         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
7969         * DumpRenderTree/chromium/android_main_fonts.xml: Added.
7970         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
7971
7972 2012-06-22  Alexandru Chiculita  <achicu@adobe.com>
7973
7974         [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
7975         https://bugs.webkit.org/show_bug.cgi?id=89781
7976
7977         Reviewed by Dean Jackson.
7978
7979         Added CSS Shaders as enabled by default on Safari for Mac.
7980
7981         * Scripts/webkitperl/FeatureList.pm:
7982
7983 2012-06-22  Adam Barth  <abarth@webkit.org>
7984
7985         Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
7986         https://bugs.webkit.org/show_bug.cgi?id=89791
7987
7988         Reviewed by Dirk Pranke.
7989
7990         Downstream, the chromium-android port maintains a test expectations
7991         file to keep track of which tests pass or fail. That causes them to
7992         keep a patch in chromium_android.py in their branch.
7993
7994         This patch teaches chromium_android.py to use test_expectations_android.txt.
7995         We don't intend to use this file upstream, but having this code patch
7996         upstream lets us unfork webkitpy.
7997
7998         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
7999         (ChromiumAndroidPort.expectations_files):
8000
8001 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
8002
8003         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
8004         https://bugs.webkit.org/show_bug.cgi?id=89734
8005
8006         Reviewed by Ryosuke Niwa.
8007
8008         Fix a crash in ServerProcess if you called .pid() after it
8009         crashed during a write(). We had a test for this case but the
8010         test wasn't calling pid(), just has_crashed(). Fixed the problem
8011         and the test.
8012
8013         * Scripts/webkitpy/layout_tests/port/server_process.py:
8014         (ServerProcess.__init__):
8015         (ServerProcess.pid):
8016         (ServerProcess._start):
8017         (ServerProcess.stop):
8018         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
8019         (FakeServerProcess._start):
8020         (TestServerProcess.test_broken_pipe):
8021
8022 2012-06-22  Peter Beverloo  <peter@chromium.org>
8023
8024         [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
8025         https://bugs.webkit.org/show_bug.cgi?id=88853
8026
8027         Reviewed by Steve Block.
8028
8029         The Android exclusions were necessary to fix a gyp generation error, as
8030         the gcc_version variable wasn't being defined for Android. Remove these
8031         exceptions when Chromium is able to define the gcc_version variable.
8032
8033         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
8034
8035 2012-06-22  Mario Sanchez Prada  <msanchez@igalia.com>
8036
8037         Unreviewed gardening. Unskipping test passing after fixing bug 88419.
8038
8039         * gtk/run-api-tests:
8040         (TestRunner): Unskip WTF.HashMap.
8041
8042 2012-06-22  Zoltan Horvath  <zoltan@webkit.org>
8043
8044         [Qt] Allow DumpRenderTree to dump about:blank
8045         https://bugs.webkit.org/show_bug.cgi?id=89685
8046
8047         Reviewed by Ryosuke Niwa.
8048
8049         We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
8050         additionaly this behavior is required for running WTR performance tests.
8051
8052         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
8053         (WebCore::DumpRenderTree::processLine):
8054
8055 2012-06-21  Adam Barth  <abarth@webkit.org>
8056
8057         [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
8058         https://bugs.webkit.org/show_bug.cgi?id=89718
8059
8060         Reviewed by Kent Tamura.
8061
8062         We should reset this WebSetting to its default value so that it behaves
8063         consistently across tests.
8064
8065         * DumpRenderTree/chromium/WebPreferences.cpp:
8066         (WebPreferences::reset):
8067         (WebPreferences::applyTo):
8068         * DumpRenderTree/chromium/WebPreferences.h:
8069         (WebPreferences):
8070
8071 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
8072
8073         DRT/WTR python interface handles about:blank incorrectly
8074         https://bugs.webkit.org/show_bug.cgi?id=89563
8075
8076         Reviewed by Dirk Pranke.
8077
8078         Currently DRT/WTR python interface's _command_from_driver_input function
8079         puts the test directory path before about:blank. Remove this incorrect behavior.
8080
8081         * Scripts/webkitpy/layout_tests/port/webkit.py:
8082         (WebKitDriver._command_from_driver_input):
8083
8084 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
8085
8086         reenable perf tests on win
8087         https://bugs.webkit.org/show_bug.cgi?id=89690
8088
8089         Reviewed by Ryosuke Niwa.
8090
8091         Only the replay tests don't work, and those are disabled by
8092         default. This change also fixes the undefined _log reference
8093         that was causing a crash.
8094
8095         * Scripts/run-perf-tests:
8096
8097 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
8098
8099         Unreviewed, rolling out r120937.
8100         http://trac.webkit.org/changeset/120937
8101         https://bugs.webkit.org/show_bug.cgi?id=89679
8102
8103         This patch brought buildbot master down (Requested by svillar
8104         on #webkit).
8105
8106         * BuildSlaveSupport/build.webkit.org-config/config.json:
8107
8108 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
8109
8110         [GTK] Combine WebKit API tests into fewer binaries
8111         https://bugs.webkit.org/show_bug.cgi?id=88458
8112
8113         Reviewed by Carlos Garcia Campos.
8114
8115         Instead of creating one binary per-test file, create binaries for each
8116         category of tests. Right now this includes WTF and the WebKit2 C API,
8117         but later tests can be added for the GTK+ platform layer and the WebKit1
8118         and WebKit2 API layers.
8119
8120         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
8121           C API and one for WTF. Refresh the source list to ensure that new test are active.
8122         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
8123         concept of skipping a test and skipping a suite (program) of tests. Test cases are
8124         skipped because of legitimate failures, but entire programs are skipped because of
8125         problems in the harness. As of right now a test program is only skipped if the
8126         accessibility bus cannot be started.
8127         (SkippedTest.__init__): Make the test case a required argument and have one skipped
8128         test case per SkippedTest instance.
8129         (SkippedTest.__str__): Ditto.
8130         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
8131         in one directory. Reformat the test list to make it slightly easier to read.
8132         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
8133         test programs that are skipped.
8134         (TestRunner._setup_testing_environment): Use the new member.
8135         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
8136         the first SkippedTest that matches.
8137         (TestRunner._should_run_test_program): Take a look at the new member to make this
8138         decision.
8139         (TestRunner._run_test_command): Use the name test_program instead of test
8140         to disambiguate between test cases and test suites.
8141         (TestRunner._run_test_glib): ditto.
8142         (TestRunner._run_test_google): Ditto.
8143         (TestRunner._run_test): Ditto.
8144         (TestRunner.run_tests): Ditto.
8145
8146 2012-06-21  Yong Li  <yoli@rim.com>
8147
8148         Unreviewed. Moving myself from committer to reviewer.
8149
8150         * Scripts/webkitpy/common/config/committers.py:
8151
8152 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
8153
8154         [GTK] Add a new webkit2 tests slave bot
8155         https://bugs.webkit.org/show_bug.cgi?id=89336
8156
8157         Reviewed by Philippe Normand.
8158
8159         Slave configuration for a new GTK bot that will run WebKit2 tests.
8160
8161         * BuildSlaveSupport/build.webkit.org-config/config.json:
8162
8163 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
8164
8165         [Qt] Add a custom Color Chooser widget to MiniBrowser
8166         https://bugs.webkit.org/show_bug.cgi?id=87988
8167
8168         Reviewed by Alexis Menard.
8169
8170         Added custom color chooser example for the MiniBrowser.
8171
8172         * MiniBrowser/qt/MiniBrowser.qrc:
8173         * MiniBrowser/qt/qml/BrowserWindow.qml:
8174         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
8175
8176 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
8177
8178         Remove the warning "File not found" in MiniBrowser post-build event
8179         https://bugs.webkit.org/show_bug.cgi?id=89601
8180
8181         Reviewed by Adam Roben.
8182
8183         * MiniBrowser/MiniBrowserPostBuild.cmd:
8184
8185 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
8186
8187         [Qt] DRT in standalone mode hangs after the first test
8188         https://bugs.webkit.org/show_bug.cgi?id=89613
8189
8190         Reviewed by Csaba Osztrogonác.
8191
8192         Break an inline signal slot chain that ends up in setting
8193         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
8194         we emit done() which starts the chain that finishes in DumpRenderTree::open().
8195         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
8196         these two lines but it seems to be wrong in general to start the next load
8197         from this call chain. The server mode (when DRT is runned by the test harness)
8198         also uses a queued connection to read the next test from stdin.
8199
8200         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
8201         (WebCore::DumpRenderTree::processArgsLine):
8202
8203 2012-06-20  Hans Wennborg  <hans@chromium.org>
8204
8205         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
8206         https://bugs.webkit.org/show_bug.cgi?id=89217
8207
8208         Reviewed by Adam Barth.
8209
8210         Add a method for checking whether the mock speech
8211         recognition was aborted.
8212
8213         Also redo the way the mock posts tasks. Instead of posting them all at once,
8214         maintain an internal queue of task objects, and call postTask() for them
8215         once at the time. This means that for example when the page is navigated
8216         away and abort() is called, that call doesn't end up after a bunch
8217         of previously posted events on the event loop.
8218
8219         * DumpRenderTree/chromium/LayoutTestController.cpp:
8220         (LayoutTestController::LayoutTestController):
8221         (LayoutTestController::wasMockSpeechRecognitionAborted):
8222         * DumpRenderTree/chromium/LayoutTestController.h:
8223         (LayoutTestController):
8224         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
8225         (WebKit::ClientCallTask::ClientCallTask):
8226         (WebKit::ResultTask::ResultTask):
8227         (WebKit::NoMatchTask::NoMatchTask):
8228         (WebKit::ErrorTask::ErrorTask):
8229         (MockWebSpeechRecognizer::start):
8230         (MockWebSpeechRecognizer::abort):
8231         (MockWebSpeechRecognizer::setError):
8232         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
8233         (MockWebSpeechRecognizer::startTaskQueue):
8234         (MockWebSpeechRecognizer::StepTask::runIfValid):
8235         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
8236         (MockWebSpeechRecognizer::hasBeenAborted):
8237         (MockWebSpeechRecognizer):
8238         (MockWebSpeechRecognizer::taskList):
8239         (Task):
8240         (MockWebSpeechRecognizer::Task::Task):
8241         (MockWebSpeechRecognizer::Task::~Task):
8242         (StepTask):
8243         (MockWebSpeechRecognizer::StepTask::StepTask):
8244
8245 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
8246
8247         [GTK] Add support for window.showModalDialog in WebKit2GTK+
8248         https://bugs.webkit.org/show_bug.cgi?id=79500
8249
8250         Reviewed by Carlos Garcia Campos.
8251
8252         Add support for modal dialogs in GTK's MiniBrowser.
8253
8254         * MiniBrowser/gtk/BrowserWindow.c:
8255         (webViewRunAsModal):
8256         (webViewCreate):
8257         (webViewDecidePolicy):
8258         (browser_window_new):
8259         * MiniBrowser/gtk/BrowserWindow.h:
8260         * MiniBrowser/gtk/main.c:
8261         (createBrowserWindow):
8262
8263 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
8264
8265         [WinCairo] Unreviewed build fix.
8266         The wrapper script that launched new- and old-run-webkit-tests
8267         was discarding the --wincairo argument needed to get the proper
8268         test infrastructure to build under WinCairo.
8269
8270         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
8271         behavior to chain the --wincairo flag through to the new build
8272         and test scripts.
8273
8274 2012-06-20  Mark Rowe  <mrowe@apple.com>
8275
8276         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
8277
8278         Reviewed by Dan Bernstein.
8279
8280         * Scripts/webkitdirs.pm:
8281         (executableHasEntitlements):
8282         (safariPathFromSafariBundle):
8283
8284 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
8285
8286         Unreviewed, rolling out r120821.
8287         http://trac.webkit.org/changeset/120821
8288         https://bugs.webkit.org/show_bug.cgi?id=89605
8289
8290         It made duplicated reviewer entries (Requested by Ossy on
8291         #webkit).
8292
8293         * Scripts/webkitpy/common/checkout/changelog.py:
8294         (ChangeLog.set_reviewer):
8295         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
8296         (test_set_reviewer):
8297         (test_set_short_description_and_bug_url):
8298
8299 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
8300
8301         nrwt outputs empty files for wdiff output if wdiff is not installed
8302         https://bugs.webkit.org/show_bug.cgi?id=88709
8303
8304         Reviewed by Tony Chang.
8305
8306         Reviewed by Tony Chang.
8307
8308         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
8309         aren't available, and clean up the handling for them in the port
8310         code.
8311
8312         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
8313         (MainTest.test_output_diffs):
8314         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
8315         (TestResultWriter.create_text_diff_and_write_result):
8316         * Scripts/webkitpy/layout_tests/port/base.py:
8317         (Port.check_pretty_patch):
8318         (Port.check_wdiff):
8319         (Port._wdiff_missing_message):
8320         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
8321         (ChromiumLinuxPort.check_build):
8322         (ChromiumLinuxPort._wdiff_missing_message):
8323         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
8324         (ChromiumMacPort.check_build):
8325         (ChromiumMacPort):
8326         (ChromiumMacPort._wdiff_missing_message):
8327         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
8328         (ChromiumMacPortTest):
8329
8330 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
8331
8332         nrwt: fix unit tests for ensuring svn revision is correct
8333         https://bugs.webkit.org/show_bug.cgi?id=89498
8334
8335         Reviewed by Eric Seidel.
8336
8337         Reviewed by Eric Seidel.
8338
8339         Fix the unit tests for testing that we are embedding the SVN
8340         revision in the results json for NRWT properly; this was broken
8341         in r120646 but because the MockHost worked differently than the
8342         real one (by always initializing the MockSCM object) we didn't
8343         notice. Unfortunately, just changing the default breaks all
8344         sorts of unit tests ...
8345
8346         * Scripts/webkitpy/common/host_mock.py:
8347         (MockHost.__init__):
8348         (MockHost._initialize_scm):
8349         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
8350         (ResultSummaryTest.test_no_svn_revision):
8351         (ResultSummaryTest.test_svn_revision):
8352
8353 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
8354
8355         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
8356         https://bugs.webkit.org/show_bug.cgi?id=69360
8357
8358         Reviewed by Eric Seidel.
8359
8360         Reviewed by Eric Seidel.
8361
8362         Propagate the 'port_implementation' part of the platform (i.e.,
8363         gtk,qt,chromium) to webkit-build-directory so that we can pick
8364         up the gtk-specific handling of WEBKITOUTPUTDIR ...
8365
8366         I didn't write any additional tests for this; testing it
8367         properly is an integration test between the python code and the
8368         perl code, which I verified by hand.
8369
8370         * Scripts/webkitpy/layout_tests/port/base.py:
8371         (Port.__init__):
8372         * Scripts/webkitpy/layout_tests/port/config.py:
8373         (Config.__init__):
8374         (Config.build_directory):
8375         * Scripts/webkitpy/layout_tests/port/config_mock.py:
8376         (MockConfig.__init__):
8377         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
8378         (ConfigTest.test_build_directory_passes_port_implementation):
8379
8380 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
8381
8382         Fix import sorting missed in r120846
8383
8384         Reviewed by Tony Chang.
8385
8386         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
8387
8388 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
8389
8390         Fix chromium win http servers after breakage introduced in r120846.
8391
8392         Unreviewed, build fix.
8393
8394         * Scripts/webkitpy/layout_tests/port/base.py:
8395         (Port.to.start_http_server):
8396         * Scripts/webkitpy/layout_tests/servers/http_server.py:
8397         (Lighttpd.__init__):
8398
8399 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
8400
8401         tweak output of webkit-patch print-{baselines,expectations}
8402         https://bugs.webkit.org/show_bug.cgi?id=89588
8403
8404         Reviewed by Tony Chang.
8405
8406         Minor tweaks to the output to make it more readable, including
8407         turning off csv by default for print-baselines with multiple ports.
8408
8409         * Scripts/webkitpy/layout_tests/port/test.py:
8410         (TestPort):
8411         * Scripts/webkitpy/tool/commands/queries.py:
8412         (PrintExpectations.execute):
8413         (PrintBaselines.execute):
8414         * Scripts/webkitpy/tool/commands/queries_unittest.py:
8415         (PrintExpectationsTest.run_test):
8416         (PrintExpectationsTest.test_multiple):
8417         (PrintBaselinesTest.setUp):
8418         (PrintBaselinesTest.test_multiple):
8419
8420 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
8421
8422         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
8423         https://bugs.webkit.org/show_bug.cgi?id=88134
8424
8425         Reviewed by Tony Chang.
8426
8427         Change NRWT to spin up 2*min(child_processes, locked_shards)
8428         http servers by default so that we are less likely to get a
8429         bunch of http timeouts at the beginning of a test run.
8430
8431         Note that I had to tweak executive_mock to support mocked stderr
8432         because the apache_http_server code reads stderr when starting a
8433         process to ensure it started okay.
8434
8435         * Scripts/webkitpy/common/system/executive_mock.py:
8436         (MockProcess.__init__):
8437         * Scripts/webkitpy/common/system/outputcapture.py:
8438         * Scripts/webkitpy/layout_tests/controllers/manager.py:
8439         (Manager._run_tests):
8440         (Manager.start_servers_with_lock):
8441         * Scripts/webkitpy/layout_tests/port/base.py:
8442         (Port.to.start_http_server):
8443         * Scripts/webkitpy/layout_tests/port/test.py:
8444         (TestPort.start_http_server):
8445         (TestPort._path_to_apache):
8446         (TestPort):
8447         (TestPort._path_to_apache_config_file):
8448         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
8449         (LayoutTestApacheHttpd.__init__):
8450         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
8451         (LayoutTestApacheHttpd.__init__):
8452         * Scripts/webkitpy/layout_tests/servers/http_server.py:
8453         (Lighttpd.__init__):
8454         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
8455         (HttpServerBase.__init__):
8456
8457 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
8458
8459         Unreviewed: Back out accidentally checked in debug print which broke a test
8460
8461         * Scripts/webkitpy/performance_tests/perftest.py:
8462         (PerfTest.parse_output):
8463
8464 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
8465
8466         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
8467         https://bugs.webkit.org/show_bug.cgi?id=78789
8468
8469         Reviewed by Ryosuke Niwa.
8470
8471         Updated parser to include fps as a valid unit.
8472
8473         * Scripts/webkitpy/performance_tests/perftest.py:
8474         (PerfTest):
8475         (PerfTest.parse_output):
8476
8477 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
8478
8479         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
8480         https://bugs.webkit.org/show_bug.cgi?id=67935
8481
8482         Reviewed by Ryosuke Niwa.
8483
8484         * Scripts/webkitpy/common/checkout/changelog.py:
8485         (ChangeLog.set_reviewer):
8486         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
8487         (test_set_reviewer):
8488         (test_set_short_description_and_bug_url):
8489
8490 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
8491
8492         Unreviewed trivial permissions fix.
8493
8494         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
8495
8496 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
8497
8498         [EFL][Regression] Build break after r120786
8499         https://bugs.webkit.org/show_bug.cgi?id=89549
8500
8501         Unreviewed build fix for Efl port.
8502
8503         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
8504
8505 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
8506
8507         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
8508         https://bugs.webkit.org/show_bug.cgi?id=64489
8509
8510         Reviewed by Tony Chang.
8511
8512         This change changes NRWT so that we don't start the websocket
8513         server if we aren't running websocket tests and don't start the
8514         HTTP server if we aren't running http tests.
8515
8516         * Scripts/webkitpy/layout_tests/controllers/manager.py:
8517         (Manager._websocket_tests):
8518         (Manager.start_servers_with_lock):
8519         (Manager.stop_servers_with_lock):
8520         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
8521         (ManagerTest.test_servers_started):
8522
8523 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
8524
8525         test-webkitpy: add a -p flag to pass through captured output to enable debugging
8526         https://bugs.webkit.org/show_bug.cgi?id=89158
8527
8528         Reviewed by Eric Seidel.
8529
8530         Normally when outputcapture runs it intercepts stdout/stderr,
8531         which makes running under the debugger difficult and mostly
8532         pointless (since you can't see any output). This change adds a
8533         flag to test-webkitpy (-p) that will cause outputcapture to pass
8534         through the output as well as capture it.
8535
8536         * Scripts/webkitpy/common/system/outputcapture.py:
8537         (OutputCapture.stream_wrapper):
8538         (OutputCapture._capture_output_with_name):
8539         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
8540         (OutputCaptureTest.setUp):
8541         * Scripts/webkitpy/test/main.py:
8542         (Tester._parse_args):
8543         (Tester._run_tests):
8544         (Tester._log_exception):
8545         (_CaptureAndPassThroughStream):
8546         (_CaptureAndPassThroughStream.__init__):
8547         (_CaptureAndPassThroughStream.write):
8548         (_CaptureAndPassThroughStream._message_is_from_pdb):
8549         (_CaptureAndPassThroughStream.flush):
8550         (_CaptureAndPassThroughStream.getvalue):
8551
8552 2012-06-19  Adam Barth  <abarth@webkit.org>
8553
8554         garden-o-matic fails to rebaseline tests with MISSING results
8555         https://bugs.webkit.org/show_bug.cgi?id=89521
8556
8557         Reviewed by Kenneth Russell.
8558
8559         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
8560
8561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
8562
8563 2012-06-19  Adam Barth  <abarth@webkit.org>
8564
8565         svn.delete_list fails to delete empty parent directories
8566         https://bugs.webkit.org/show_bug.cgi?id=89520
8567
8568         Reviewed by Dirk Pranke.
8569
8570         These functions were calling scm.delete and scm.add, which already
8571         delete the parent directory. We'd get an exception when we tried to
8572         delete the parent directory again.
8573
8574         * Scripts/webkitpy/common/checkout/scm/svn.py:
8575         (SVN._add_parent_directories):
8576         (SVN._delete_parent_directories):
8577
8578 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
8579
8580         webkitpy: Simplify fetch_bugs_matching_search()
8581         https://bugs.webkit.org/show_bug.cgi?id=89497
8582
8583         Reviewed by Adam Barth.
8584
8585         Removed parameter with default value. It's not being used
8586         and the handling of the parameter was wrong. Saves a check.
8587
8588         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
8589         (BugzillaQueries.fetch_bugs_matching_search):
8590         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
8591         (MockBugzillaQueries.fetch_bugs_matching_search):
8592
8593 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
8594
8595         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
8596         https://bugs.webkit.org/show_bug.cgi?id=89522
8597
8598         Reviewed by Eric Seidel.
8599
8600         They were no longer being used. No tests necessary.
8601
8602         * Scripts/webkitpy/layout_tests/port/chromium.py:
8603
8604 2012-06-19  Adam Barth  <abarth@webkit.org>
8605
8606         Missing results aren't shown in garden-o-matic
8607
8608         Reviewed by Kenneth Russell.
8609
8610         Previously we didn't know to look for text and image results when the
8611         bot told us that results were missing.
8612
8613         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
8614
8615 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
8616
8617         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
8618
8619         Unreviewed, build fix.
8620
8621         It turns out that we store the svn revision two different ways
8622         in the JSON, and I only caught one of them :(. This should fix
8623         the other.
8624
8625         Also, this part of the code is poorly tested. I will investigate
8626         adding at least a basic test for this in a separate fix.
8627
8628         * Scripts/webkitpy/layout_tests/controllers/manager.py:
8629         (summarize_results):
8630
8631 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
8632
8633         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
8634         https://bugs.webkit.org/show_bug.cgi?id=78127
8635
8636         Reviewed by Ryosuke Niwa.
8637
8638         Add the --add-platform-exceptions flag from ORWT, and ensure
8639         that --new-baseline is equivalent to --reset-results
8640         --add-platform-exceptions. Also fix the default logic for where to
8641         put PNGs and render tree dumps if --new-test-results is true:
8642         if --add-platform-exceptions is False, baselines should go in
8643         the least-specific platform directory (e.g., platform/mac)
8644         rather than the most-specific (platform/mac-snowleopard).
8645
8646         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
8647         (SingleTestRunner):
8648         (SingleTestRunner.run):
8649         (SingleTestRunner._run_rebaseline):
8650         (SingleTestRunner._add_missing_baselines):
8651         (SingleTestRunner._location_for_new_baseline):
8652         (SingleTestRunner._overwrite_baselines):
8653         (SingleTestRunner._save_baseline_data):
8654         * Scripts/webkitpy/layout_tests/port/base.py:
8655         (Port.baseline_path):
8656         (Port):
8657         (Port.baseline_platform_dir):
8658         (Port.baseline_version_dir):
8659         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8660         (_set_up_derived_options):
8661         (parse_args):
8662         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
8663         (RebaselineTest.assertBaselines):
8664         (RebaselineTest.test_reset_results):
8665         (RebaselineTest.test_missing_results):
8666         (RebaselineTest.test_new_baseline):
8667
8668 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
8669
8670         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
8671         https://bugs.webkit.org/show_bug.cgi?id=81379
8672
8673         Reviewed by Eric Seidel.
8674
8675         The 'free memory' calculation we were running on the mac seemed
8676         to underestimate how many children we can run in parallel, and
8677         it was complex. This patch replaces that calculation with a
8678         simpler one that reserves 2GB for overhead and assumes 256MB per
8679         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
8680
8681         Also, there was a bug where we were truncating the memory
8682         installed on the machine to 4GB by casting to an int instead of
8683         a long; this was probably the source of some of the earlier
8684         problems when using total memory.
8685
8686         This patch also removes the no-longer-needed restrictions on the
8687         number of workers on beefy Lion boxes for both Apple Mac and Chromium
8688         Mac; we should now use all of the cores by default.
8689
8690         The memory calculations have only been implemented on the mac;
8691         having the calculation in base.default_child_processes() was IMO
8692         misleading, and so this patch also moves the computation into
8693         the MacPort. I have not heard of the # of workers being an issue
8694         on any other ports, so this should be fine.
8695
8696         * Scripts/webkitpy/common/system/platforminfo.py:
8697         (PlatformInfo.total_bytes_memory):
8698         * Scripts/webkitpy/common/system/platforminfo_mock.py:
8699         (PlatformInfo.total_bytes_memory):
8700         (PlatformInfo.total_bytes_memory):
8701         (PlatformInfo._win_version_tuple_from_cmd):
8702         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
8703         (TestPlatformInfo.test_total_bytes_memory):
8704         * Scripts/webkitpy/layout_tests/port/base.py:
8705         (Port.default_child_processes):
8706         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
8707         (PortTest.test_default_child_processes):
8708         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
8709         (ChromiumMacPort.operating_system):
8710         * Scripts/webkitpy/layout_tests/port/mac.py:
8711         (MacPort.default_child_processes):
8712         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
8713         (TestMacPort.test_default_child_processes):
8714
8715 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
8716
8717         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
8718         https://bugs.webkit.org/show_bug.cgi?id=85446
8719
8720         Reviewed by Simon Fraser.
8721
8722         Embed whether pixel testing was enabled into the results.json.
8723
8724         * Scripts/webkitpy/layout_tests/controllers/manager.py:
8725         (summarize_results):
8726
8727 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
8728
8729         [Qt] Modify HTTPS port to 8443 for performance tests
8730         https://bugs.webkit.org/show_bug.cgi?id=89442
8731
8732         Reviewed by Ryosuke Niwa.
8733
8734         We should be consistent with the default HTTPS port and with the changelog of r119188.
8735
8736         * Scripts/webkitpy/performance_tests/perftest.py:
8737         (ReplayServer.__init__):
8738
8739 2012-06-19  Mike West  <mkwst@chromium.org>
8740
8741         Introduce ENABLE_CSP_NEXT configuration flag.
8742         https://bugs.webkit.org/show_bug.cgi?id=89300
8743
8744         Reviewed by Adam Barth.
8745
8746         The 1.0 draft of the Content Security Policy spec is just about to
8747         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
8748         this ENABLE flag, disabled by default.
8749
8750         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
8751
8752         * Scripts/webkitperl/FeatureList.pm:
8753         * qmake/mkspecs/features/features.pri:
8754
8755 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
8756
8757         [EFL] EFL's LayoutTestController does not support setTextDirection
8758         https://bugs.webkit.org/show_bug.cgi?id=87481
8759
8760         Reviewed by Hajime Morita.
8761
8762         Implement setTextDirection in EFL's LayoutTestController and
8763         properly reset its value between test cases to avoid flakiness.
8764
8765         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
8766         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
8767         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
8768         (LayoutTestController::setTextDirection):
8769
8770 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
8771
8772         [Qt] Temporarily disable xvfb driver in nrwt
8773         https://bugs.webkit.org/show_bug.cgi?id=88414
8774
8775         Reviewed by Csaba Osztrogonác.
8776
8777         * Scripts/webkitpy/layout_tests/port/qt.py:
8778         (QtPort._build_driver):
8779
8780 2012-06-18  Joone Hur  <joone.hur@intel.com>
8781
8782         [EFL] Fontconfig can't be linked properly
8783         https://bugs.webkit.org/show_bug.cgi?id=89418
8784
8785         Unreviewed build fix.
8786
8787         Make Fontconfig be linked correctly.
8788
8789         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
8790
8791 2012-06-18  Joone Hur  <joone.hur@intel.com>
8792
8793         Unreviewed. Updating email for committers.py script.
8794
8795         * Scripts/webkitpy/common/config/committers.py:
8796
8797 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
8798
8799         Fix a typo that caused TestFailures to have a syntax error.
8800
8801         Sadly TestFailures is broken for another reason now too:
8802         https://bugs.webkit.org/show_bug.cgi?id=89419
8803
8804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
8805         (ViewController.prototype._domForBuildName):
8806
8807 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
8808
8809         Provide bug links for suspicious commits
8810         https://bugs.webkit.org/show_bug.cgi?id=89408
8811
8812         Reviewed by Adam Barth.
8813
8814         Add links to bugs for the suspicious commits if we have bug data.
8815
8816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
8817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
8818         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
8819         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
8820         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
8821
8822 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
8823
8824         [Chromium] DeviceOrientation Cleanup
8825         https://bugs.webkit.org/show_bug.cgi?id=89354
8826
8827         Reviewed by Kent Tamura.
8828
8829         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
8830         (WebViewHost):
8831
8832 2012-06-18  James Robinson  <jamesr@chromium.org>
8833
8834         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
8835         https://bugs.webkit.org/show_bug.cgi?id=89254
8836
8837         Reviewed by Adrienne Walker.
8838
8839         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
8840         upstream.
8841
8842         * DumpRenderTree/chromium/WebViewHost.cpp:
8843         (WebViewHost::createGraphicsContext3D):
8844
8845 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
8846
8847         Minor fix suggested by Adam Barth.
8848
8849         Use $(this._what).empty(); rather than removing children one at a time.
8850         For some reason removeAllChildren() is undefined on this node.
8851
8852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
8853
8854 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
8855
8856         Show TOT revision in garden-o-matic, and make the revisions into links
8857         https://bugs.webkit.org/show_bug.cgi?id=89396
8858
8859         Reviewed by Adam Barth.
8860
8861         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
8862         where the revisions are links to trac.
8863
8864         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
8865         the knock-on effect of flipping the target and href attributes for anchors in some test output.
8866
8867         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
8868         (ViewController.prototype._displayTesters.updateList.list):
8869         (ViewController.prototype._displayTesters.updateList):
8870         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
8871         (ViewController.prototype._domForRegressionRange):
8872         (ViewController.prototype._domForAuxiliaryUIElements):
8873         (ViewController.prototype._domForBuildName):
8874         (ViewController.prototype):
8875         (ViewController.prototype.):
8876         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
8877         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
8878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
8879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
8880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
8881
8882 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
8883
8884         REGRESSION(r100558): NRWT should work without SVN or GIT
8885         https://bugs.webkit.org/show_bug.cgi?id=76630
8886
8887         Reviewed by Dirk Pranke.
8888
8889         NRWT is not supposed to have a requirement that we have an
8890         actual SVN or Git checkout, and we were unnecessarily
8891         initializing the checkout. This patch removes that line :).
8892
8893         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8894         (main):
8895
8896 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
8897
8898         [garden-o-matic] Add support for the GTK builders
8899         https://bugs.webkit.org/show_bug.cgi?id=89360
8900
8901         Reviewed by Adam Barth.
8902
8903         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
8904         both get their data from build.webkit.org.
8905
8906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
8907         (.):
8908
8909 2012-06-18  Nico Weber  <thakis@chromium.org>
8910
8911         [chromium/mac] Unbreak smooth scrolling.
8912         https://bugs.webkit.org/show_bug.cgi?id=89327
8913
8914         Reviewed by Dimitri Glazkov.
8915
8916         Broken by Sam in r115589 / r115591.
8917
8918         * DumpRenderTree/mac/DumpRenderTree.mm:
8919         (resetDefaultsToConsistentValues):
8920         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
8921         (TestWebKitAPI::InjectedBundleController::platformInitialize):
8922         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
8923         (WTR::InjectedBundle::platformInitialize):
8924
8925 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
8926
8927         Unreviewed, rolling out r120541, r120547, and r120548.
8928         http://trac.webkit.org/changeset/120541
8929         http://trac.webkit.org/changeset/120547
8930         http://trac.webkit.org/changeset/120548
8931         https://bugs.webkit.org/show_bug.cgi?id=89383
8932
8933         This approach doesn't work for WebKit2 (Requested by abarth on
8934         #webkit).
8935
8936         * DumpRenderTree/LayoutTestController.cpp:
8937         (setBackingScaleFactorCallback):
8938         (LayoutTestController::staticFunctions):
8939         * DumpRenderTree/LayoutTestController.h:
8940         (LayoutTestController):
8941         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
8942         (LayoutTestController::setBackingScaleFactor):
8943         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
8944         (LayoutTestController::setBackingScaleFactor):
8945         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
8946         (LayoutTestController::setBackingScaleFactor):
8947         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
8948         (LayoutTestController::setBackingScaleFactor):
8949         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
8950         (LayoutTestController::setBackingScaleFactor):
8951         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
8952         (LayoutTestController::setBackingScaleFactor):
8953         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
8954         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
8955         (WTR::InjectedBundle::didReceiveMessage):
8956         (WTR::InjectedBundle::postSetBackingScaleFactor):
8957         (WTR):
8958         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
8959         (InjectedBundle):
8960         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
8961         (WTR::LayoutTestController::setBackingScaleFactor):
8962         (WTR):
8963         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
8964         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
8965         (LayoutTestController):
8966         * WebKitTestRunner/TestInvocation.cpp:
8967         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
8968
8969 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
8970
8971         REGRESSION(r120546): It made 3 webkitpy tests fail
8972         https://bugs.webkit.org/show_bug.cgi?id=89332
8973
8974         Reviewed by Adam Barth.
8975
8976         Update the BaselineOptimizer unittest after r120546.
8977
8978         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
8979         (BaselineOptimizerTest.test_no_add_mac_future):
8980         (BaselineOptimizerTest.test_mac_future):
8981         (BaselineOptimizerTest.test_complex_shadowing):
8982
8983 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
8984
8985         new-run-webkit-tests output gets confused when logging
8986         https://bugs.webkit.org/show_bug.cgi?id=63793
8987
8988         Reviewed by Adam Barth.
8989
8990         Ship all of the log messages generated in the worker back
8991         to the manager; this allows the messages to be properly
8992         serialized to stderr and for the meter to flush its output correctly.
8993
8994         Note however that this will likely result in messages to be
8995         logged out of order between workers; I'm not sure that there's
8996         an easy way to fix this short of buffering a potentially
8997         unbounded amount of data. It might be better to just log through
8998         stderr unless we're in 'metering' mode, but it's also worth
8999         noting that we already get messages out of order through stderr
9000         on Windows.
9001
9002         * Scripts/webkitpy/layout_tests/controllers/manager.py:
9003         (Manager.handle_done):
9004         (Manager.handle_finished_test):
9005         (Manager._log_messages):
9006         * Scripts/webkitpy/layout_tests/controllers/worker.py:
9007         (Worker.__init__):
9008         (Worker._set_up_logging):
9009         (Worker.run):
9010         (Worker._run_test):
9011         (Worker.cleanup):
9012         (Worker.run_single_test):
9013         (_WorkerLogHandler):
9014         (_WorkerLogHandler.__init__):
9015         (_WorkerLogHandler.emit):
9016         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
9017         (MeteredStream.write):
9018         (MeteredStream.writeln):
9019         * Scripts/webkitpy/layout_tests/views/printing.py:
9020         (Printer.writeln):
9021
9022 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
9023
9024         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
9025         https://bugs.webkit.org/show_bug.cgi?id=89362
9026
9027         Reviewed by Simon Fraser.
9028
9029         Replace white spaces, braces and dots in the builder name with underscores. This
9030         way the JQuery tabs will be properly matched with the according container.
9031
9032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
9033
9034 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
9035
9036         nrwt: metered output doesn't handle ^C cleanly
9037         https://bugs.webkit.org/show_bug.cgi?id=89249
9038
9039         Reviewed by Tony Chang.
9040
9041         If you ctrl-c a running nrwt (w/o --verbose), then all but
9042         two characters of the last update are erased, and then we print
9043         "interrupted, exiting" as an update, which itself then gets
9044         erased. Fix this so that we flush the meter (making the last
9045         update persistent, so that we print the ^C for a visual clue),
9046         print the interrupt message, and move on ...
9047
9048         * Scripts/webkitpy/layout_tests/controllers/manager.py:
9049         (Manager._run_tests):
9050         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
9051         (MeteredStream.flush):
9052         * Scripts/webkitpy/layout_tests/views/printing.py:
9053         (Printer._write):
9054         (Printer):
9055         (Printer.flush):
9056
9057 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
9058
9059         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
9060         https://bugs.webkit.org/show_bug.cgi?id=89228
9061
9062         Reviewed by Tony Chang.
9063
9064         * DumpRenderTree/chromium/LayoutTestController.cpp:
9065         * DumpRenderTree/chromium/TestShellAndroid.cpp:
9066
9067 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
9068
9069         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
9070         https://bugs.webkit.org/show_bug.cgi?id=89226
9071
9072         Reviewed by Martin Robinson.
9073
9074         Implement increment() and decrement() functions in term of the AtkValue interface,
9075         instead of using DumpRenderTreeSupportGtk helper class.
9076
9077         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
9078         (AccessibilityUIElement::intValue):
9079         (AccessibilityUIElement::minValue):
9080         (AccessibilityUIElement::maxValue):
9081         (alterCurrentValue):
9082         (AccessibilityUIElement::increment):
9083         (AccessibilityUIElement::decrement):
9084
9085 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
9086
9087         garden-o-matic 'Results' panel is broken for the Apple platform
9088         https://bugs.webkit.org/show_bug.cgi?id=89310
9089
9090         Reviewed by Adam Barth.
9091
9092         For platforms that don't use accumulated build directories on the server,
9093         carry along buildLocation data with buildInfo, so that we know where to
9094         look for the test results files for a given test.
9095
9096         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
9097         it now returns an array of objects with buildNumber, revision and url info.
9098
9099         Fixed results.fetchResultsURLs() to use this data to find results.
9100
9101         Fixed the results display to not scroll when you click on a test to see the results.
9102         Made the h3s look less ugly
9103
9104         Don't try to show the flakiness dashboard for the Apple platform.
9105
9106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
9107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
9108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
9109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
9110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
9111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
9112         (.results-view .top-panel):
9113         (.results-view h3):
9114
9115 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
9116
9117         Make garden-o-matic work for the Apple Mac port
9118         https://bugs.webkit.org/show_bug.cgi?id=84642
9119
9120         Reviewed by Adam Barth.
9121
9122         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
9123         educating the scripts in various ways:
9124         * Wrap up platform-related differences in config.kPlatforms[]
9125         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
9126         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
9127           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
9128           recent build with valid results.
9129         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
9130           try to test a build that has already been deleted). Make walkHistory() more robust here.
9131         * webkit.org uses differently named test result directories, that include the SVN revision as
9132           well as the build number. That forces us to fetch more build info before we can get the
9133           result directory URL.
9134         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
9135           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
9136           dirs.
9137         * Various URLs differ between webkit.org and chromium.org
9138         * Better UI for the failures info, so that some info is visible even when not hovered.
9139
9140         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
9141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
9142         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
9143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
9144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
9145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
9146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
9147         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
9148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
9149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
9150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
9151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
9152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
9153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
9154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
9155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
9156         (ol.notifications>li table.failures):
9157         (ol.notifications>li:hover table.failures):
9158         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
9159         (#onebar #platform-picker):
9160         * Scripts/webkitpy/layout_tests/port/builders.py:
9161
9162 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
9163
9164         Unreviewed, rolling out r120536.
9165         http://trac.webkit.org/changeset/120536
9166         https://bugs.webkit.org/show_bug.cgi?id=89296
9167
9168         Does not compile on chromium-linux (Requested by abarth on
9169         #webkit).
9170
9171         * DumpRenderTree/chromium/LayoutTestController.cpp:
9172         (LayoutTestController::reset):
9173         (LayoutTestController::setTextSubpixelPositioning):
9174         * DumpRenderTree/chromium/TestShellAndroid.cpp:
9175
9176 2012-06-16  Adam Barth  <abarth@webkit.org>
9177
9178         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
9179         https://bugs.webkit.org/show_bug.cgi?id=89274
9180
9181         Reviewed by Levi Weintraub.
9182
9183         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
9184         Note: The WebKit2 API that setBackingScaleFactor exercises is still
9185         tested by API-level tests.
9186
9187         * DumpRenderTree/LayoutTestController.cpp:
9188         (LayoutTestController::staticFunctions):
9189         * DumpRenderTree/LayoutTestController.h:
9190         (LayoutTestController):
9191         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
9192         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
9193         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
9194         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
9195         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
9196         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
9197         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
9198         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
9199         (WTR::InjectedBundle::didReceiveMessage):
9200         (WTR):
9201         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
9202         (InjectedBundle):
9203         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
9204         (WTR):
9205         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
9206         (LayoutTestController):
9207         * WebKitTestRunner/TestInvocation.cpp:
9208         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
9209
9210 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
9211
9212         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
9213         https://bugs.webkit.org/show_bug.cgi?id=89228
9214
9215         Reviewed by Tony Chang.
9216
9217         * DumpRenderTree/chromium/LayoutTestController.cpp:
9218         (LayoutTestController::reset):
9219         (LayoutTestController::setTextSubpixelPositioning):
9220         * DumpRenderTree/chromium/TestShellAndroid.cpp:
9221
9222 2012-06-15  Adam Barth  <abarth@webkit.org>
9223
9224         garden-o-matic's results.js should use RequestTracker
9225         https://bugs.webkit.org/show_bug.cgi?id=89257
9226
9227         Reviewed by Dimitri Glazkov.
9228
9229         We wrote results.js before we recognized the RequestTracker pattern.
9230         This patch replaces the manual implementations of RequestTracker with
9231         the real deal.
9232
9233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
9234
9235 2012-06-15  Darin Adler  <darin@apple.com>
9236
9237         * Scripts/webkitpy/bindings: Added property svn:ignore.
9238
9239 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
9240
9241         Unreviewed, rolling out r120511.
9242         http://trac.webkit.org/changeset/120511
9243         https://bugs.webkit.org/show_bug.cgi?id=89255
9244
9245         Breaks at least Android builder (Requested by wangxianzhu on
9246         #webkit).
9247
9248         * DumpRenderTree/chromium/LayoutTestController.cpp:
9249         (LayoutTestController::reset):
9250         (LayoutTestController::setTextSubpixelPositioning):
9251
9252 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
9253
9254         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
9255         https://bugs.webkit.org/show_bug.cgi?id=89228
9256
9257         Reviewed by Tony Chang.
9258
9259         * DumpRenderTree/chromium/LayoutTestController.cpp:
9260         (LayoutTestController::reset):
9261         (LayoutTestController::setTextSubpixelPositioning):
9262
9263 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
9264
9265         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
9266         https://bugs.webkit.org/show_bug.cgi?id=89135
9267
9268         Re-land change in r120370 with fix in
9269         PortFactory.get_from_builder_name() that changes BuilderOptions
9270         to an actual optparse.Values object.
9271
9272         * Scripts/webkitpy/layout_tests/port/base.py:
9273         (Port.__init__):
9274         (Port.get_option):
9275         (Port.set_option_default):
9276         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
9277         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
9278         * Scripts/webkitpy/layout_tests/port/factory.py:
9279         (_builder_options):
9280         (PortFactory.get_from_builder_name):
9281         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
9282         (FactoryTest.test_get_from_builder_name):
9283         * Scripts/webkitpy/style/checkers/test_expectations.py:
9284         (TestExpectationsChecker._determine_port_from_expectations_path):
9285         * Scripts/webkitpy/tool/mocktool.py:
9286         (MockOptions.ensure_value):
9287
9288 2012-06-15  Bill Budge  <bbudge@chromium.org>
9289
9290         Add bbudge@chromium.org to committers.py
9291
9292         Unreviewed.
9293
9294         * Scripts/webkitpy/common/config/committers.py:
9295
9296 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
9297
9298         Unreviewed style fix after r120351.
9299
9300         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
9301         (body.interface):
9302
9303 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
9304
9305         master.cfg cleanup, remove unnecessary workaround
9306         https://bugs.webkit.org/show_bug.cgi?id=88994
9307
9308         Reviewed by Lucas Forschler.
9309
9310         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9311         (loadBuilderConfig):
9312
9313 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
9314
9315         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
9316         https://bugs.webkit.org/show_bug.cgi?id=88581
9317
9318         Reviewed by Adam Barth.
9319
9320         Make sure we only optimize the suffixes we rebaselined during
9321         rebaseline-expectations, and not all suffixes for a test.
9322         While optimizing is somewhere between harmless and good, it's also confusing :)
9323
9324         * Scripts/webkitpy/tool/commands/rebaseline.py:
9325         (RebaselineExpectations._rebaseline_port):
9326         (RebaselineExpectations.execute):
9327         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
9328
9329 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
9330
9331         Update builder.html template for newer buildmaster
9332         https://bugs.webkit.org/show_bug.cgi?id=89207
9333
9334         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
9335
9336         Reviewed by Zoltan Herczeg.
9337
9338         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
9339
9340 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
9341
9342         Add ForceScheduler to build.webkit.org
9343         https://bugs.webkit.org/show_bug.cgi?id=88982
9344
9345         Reviewed by Ryosuke Niwa.
9346
9347         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9348         (loadBuilderConfig):
9349
9350 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
9351
9352         [EFL][WK2] Add title support to Ewk_View
9353         https://bugs.webkit.org/show_bug.cgi?id=89095
9354
9355         Reviewed by Kenneth Rohde Christiansen.
9356
9357         Update the MiniBrowser so it listens for the "title,change"
9358         signal on the view and keeps the browser window title
9359         up-to-date.
9360
9361         * MiniBrowser/efl/main.c:
9362         (on_title_changed):
9363         (browserCreate):
9364
9365 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
9366
9367         [WK2][EFL] Implement navigation back/forward in Ewk_View
9368         https://bugs.webkit.org/show_bug.cgi?id=89173
9369
9370         Reviewed by Kenneth Rohde Christiansen.
9371
9372         Implement navigation back / forward in MiniBrowser. Use
9373         'F1' to navigate back and 'F2' to navigate forward.
9374
9375         * MiniBrowser/efl/main.c:
9376         (on_key_down):
9377
9378 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
9379
9380         [EFL] EFL's LayoutTestController does not support titleTextDirection
9381         https://bugs.webkit.org/show_bug.cgi?id=86475
9382
9383         Reviewed by Hajime Morita.
9384
9385         Add titleTextDirection getter and setter to LayoutTestController and
9386         expose its value to JavaScript.
9387         Update the titleTextDirection value from EFL's "title,changed"
9388         callback in DumpRenderTree.
9389
9390         * DumpRenderTree/LayoutTestController.cpp:
9391         (LayoutTestController::LayoutTestController):
9392         (getTitleTextDirectionCallback):
9393         (LayoutTestController::staticValues):
9394         * DumpRenderTree/LayoutTestController.h:
9395         (LayoutTestController::titleTextDirection):
9396         (LayoutTestController::setTitleTextDirection):
9397         (LayoutTestController):
9398         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
9399         (DumpRenderTreeChrome::onFrameTitleChanged):
9400
9401 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
9402
9403         [EFL][WK2] Implement reload / stop in Ewk_View
9404         https://bugs.webkit.org/show_bug.cgi?id=89168
9405
9406         Reviewed by Kenneth Rohde Christiansen.
9407
9408         Implement view reload / stop loading in MiniBrowser.
9409         Use 'F5' for reload and 'F6' for stopping the load.
9410
9411         * MiniBrowser/efl/main.c:
9412         (on_key_down):
9413         (browserCreate):
9414
9415 2012-06-15  Hironori Bono  <hbono@chromium.org>
9416
9417         Allow platforms to choose whether to remove markers on editing
9418         https://bugs.webkit.org/show_bug.cgi?id=88838
9419
9420         Reviewed by Hajime Morita.
9421
9422         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
9423         run grammar tests.
9424
9425         * DumpRenderTree/chromium/WebViewHost.cpp:
9426         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
9427         * DumpRenderTree/chromium/WebViewHost.h:
9428         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
9429
9430 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
9431
9432         Unreviewed, rolling out r120370.
9433         http://trac.webkit.org/changeset/120370
9434         https://bugs.webkit.org/show_bug.cgi?id=89183
9435
9436         Broke webkit-patch rebaseline (Requested by zdobersek on
9437         #webkit).
9438
9439         * Scripts/webkitpy/layout_tests/port/base.py:
9440         (DummyOptions):
9441         (DummyOptions.__init__):
9442         (DummyOptions.__init__.this):
9443         (Port.__init__):
9444         (Port.get_option):
9445         (Port.set_option_default):
9446         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
9447         (ChromiumWinTest.RegisterCygwinOption):
9448         (ChromiumWinTest.RegisterCygwinOption.__init__):
9449         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
9450         * Scripts/webkitpy/style/checkers/test_expectations.py:
9451         (TestExpectationsChecker._determine_port_from_expectations_path):
9452         * Scripts/webkitpy/tool/mocktool.py:
9453         (MockOptions.update):
9454
9455 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
9456
9457         [Chromium-Android] Initialize font rendering in DumpRenderTree
9458         https://bugs.webkit.org/show_bug.cgi?id=89133
9459
9460         Reviewed by Adam Barth.
9461
9462         * DumpRenderTree/chromium/LayoutTestController.cpp:
9463         (LayoutTestController::reset):
9464         (LayoutTestController::setTextSubpixelPositioning):
9465         * DumpRenderTree/chromium/TestShellAndroid.cpp:
9466         (platformInit):
9467
9468 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
9469
9470         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
9471         https://bugs.webkit.org/show_bug.cgi?id=88622
9472
9473         Reviewed by Philippe Normand.
9474
9475         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
9476         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
9477
9478 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
9479
9480         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
9481         https://bugs.webkit.org/show_bug.cgi?id=89124
9482
9483         Reviewed by Dirk Pranke.
9484
9485         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
9486         (ChromiumAndroidDriver._start):
9487         (ChromiumAndroidDriver):
9488         (ChromiumAndroidDriver._start_once):
9489
9490 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
9491
9492         Update webpagereplay to 1.1.2
9493         https://bugs.webkit.org/show_bug.cgi?id=89118
9494
9495         This includes the following patch which avoids pkg_resources import errors:
9496         http://code.google.com/p/web-page-replay/source/detail?r=476
9497
9498         Reviewed by Dirk Pranke.
9499
9500         * Scripts/webkitpy/thirdparty/__init__.py:
9501         (AutoinstallImportHook._install_webpagereplay):
9502
9503 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
9504
9505         Get rid of FAIL test expectation
9506         https://bugs.webkit.org/show_bug.cgi?id=89137
9507
9508         Reviewed by Dirk Pranke.
9509
9510         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
9511         (ResultSummaryTest.test_summarized_results_wontfix):
9512         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
9513         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
9514         (JSONLayoutResultsGenerator):
9515         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
9516         (result_was_expected):
9517         (suffixes_for_expectations):
9518         (TestExpectationsModel._add_test):
9519         (TestExpectations):
9520         (TestExpectations.get_rebaselining_failures):
9521         (TestExpectations.remove_configuration_from_test):
9522         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
9523         (FunctionsTest.test_result_was_expected):
9524         (FunctionsTest.test_suffixes_for_expectations):
9525         (TestExpectationSerializerTests.test_parsed_expectations_string):
9526         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
9527         (test_test_expectations):
9528         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
9529         (TestExpectationsTestCase.test_valid_expectations):
9530
9531 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
9532
9533         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
9534         https://bugs.webkit.org/show_bug.cgi?id=89135
9535
9536         Reviewed by Ryosuke Niwa.
9537
9538         This patch is just some minor cleanup and simplification. There
9539         should be no functional changes here.
9540
9541         * Scripts/webkitpy/layout_tests/port/base.py:
9542         (Port.__init__):
9543         (Port.get_option):
9544         (Port.set_option_default):
9545         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
9546         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
9547         * Scripts/webkitpy/style/checkers/test_expectations.py:
9548         (TestExpectationsChecker._determine_port_from_expectations_path):
9549         * Scripts/webkitpy/tool/mocktool.py:
9550         (MockOptions.ensure_value):
9551
9552 2012-06-14  Ian Vollick  <vollick@chromium.org>
9553
9554         [chromium] Certain settings in CCSettings could be global
9555         https://bugs.webkit.org/show_bug.cgi?id=88384
9556
9557         Reviewed by James Robinson.
9558
9559         * DumpRenderTree/chromium/TestShell.cpp:
9560         (TestShell::TestShell):
9561         (TestShell::resetWebSettings):
9562         (TestShell::setPerTilePaintingEnabled):
9563         * DumpRenderTree/chromium/TestShell.h:
9564         (TestShell):
9565         * DumpRenderTree/chromium/WebPreferences.cpp:
9566         (WebPreferences::reset):
9567         (WebPreferences::applyTo):
9568         * DumpRenderTree/chromium/WebPreferences.h:
9569         (WebPreferences):
9570
9571 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
9572
9573         Unreviewed, rolling out r120352.
9574         http://trac.webkit.org/changeset/120352
9575         https://bugs.webkit.org/show_bug.cgi?id=89120
9576
9577         It seems something is still wrong with it :/ (Requested by
9578         Ossy on #webkit).
9579
9580         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9581         (Factory.__init__):
9582         (BuildFactory.__init__):
9583         (TestFactory.__init__):
9584         (BuildAndTestFactory.__init__):
9585         (BuildAndPerfTestFactory.__init__):
9586         (BuildAndPerfTestWebKit2Factory.__init__):
9587         (DownloadAndPerfTestFactory.__init__):
9588         (DownloadAndPerfTestWebKit2Factory.__init__):
9589
9590 2012-06-14  Jia Pu  <jpu@apple.com>
9591
9592         Mark text with text alternative with blue underline.
9593         https://bugs.webkit.org/show_bug.cgi?id=83047
9594
9595         Reviewed by NOBODY Enrica Casucci.
9596
9597         * DumpRenderTree/mac/TextInputController.m:
9598         (+[TextInputController isSelectorExcludedFromWebScript:]):
9599         (+[TextInputController webScriptNameForSelector:]):
9600         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
9601
9602 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
9603
9604         Unreviewed, rolling out r120353.
9605         http://trac.webkit.org/changeset/120353
9606         https://bugs.webkit.org/show_bug.cgi?id=89119
9607
9608         It seems we still need this workaround (Requested by Ossy on
9609         #webkit).
9610
9611         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9612         (loadBuilderConfig):
9613
9614 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
9615
9616         master.cfg cleanup, remove unnecessary workaround
9617         https://bugs.webkit.org/show_bug.cgi?id=88994
9618
9619         Reviewed by Lucas Forschler.
9620
9621         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9622         (loadBuilderConfig):
9623
9624 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
9625
9626         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
9627         https://bugs.webkit.org/show_bug.cgi?id=89001
9628
9629         Reviewed by Lucas Forschler.
9630
9631         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9632         (Factory.__init__):
9633         (BuildFactory.__init__):
9634         (TestFactory.__init__):
9635         (BuildAndTestFactory.__init__):
9636         (BuildAndPerfTestFactory.__init__):
9637         (BuildAndPerfTestWebKit2Factory.__init__):
9638         (DownloadAndPerfTestFactory.__init__):
9639         (DownloadAndPerfTestWebKit2Factory.__init__):
9640
9641 2012-06-14  Csaba Osztrogonác  <ossy@webkit.org>
9642
9643         Unhide login form on the build.webkit.org
9644         https://bugs.webkit.org/show_bug.cgi?id=88981
9645
9646         Reviewed by Lucas Forschler.
9647
9648         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
9649
9650 2012-06-14  Zan Dobersek  <zandobersek@gmail.com>
9651
9652         [Gtk] Add support in DumpRenderTree for tracking repaints
9653         https://bugs.webkit.org/show_bug.cgi?id=87658
9654
9655         Reviewed by Martin Robinson.
9656
9657         Reimplement the displayWebView method in DumpRenderTree - force a
9658         repaint before starting tracking repaints and resetting them.
9659
9660         When gathering pixel output from a web view, if tracking repaints,
9661         paint an overlay over the output with the overlay being clear in the
9662         areas where the repaints occurred.
9663
9664         * DumpRenderTree/gtk/DumpRenderTree.cpp:
9665         (displayWebView):
9666         (resetDefaultsToConsistentValues):
9667         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
9668         (paintOverlay):
9669         (fillRepaintOverlayIntoContext):
9670         (createBitmapContextFromWebView):
9671
9672 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
9673
9674         new-run-webkit-tests doesn't find similar platform tests for a keyword
9675         https://bugs.webkit.org/show_bug.cgi?id=37956
9676
9677         Reviewed by Ryosuke Niwa.
9678
9679         This patches adds support for NRWT so that if you type
9680         "new-run-webkit-tests foo" it will run all the tests in foo as
9681         well as platform/foo for all of the platforms that are normally
9682         searched (this only applies to directories, not to individual tests).
9683
9684         * Scripts/webkitpy/layout_tests/controllers/manager.py:
9685         (Manager.collect_tests):
9686         * Scripts/webkitpy/layout_tests/port/base.py:
9687         (Port.tests):
9688         (Port):
9689         (Port._expanded_paths):
9690         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
9691         (MainTest.test_no_http_tests):
9692         (MainTest):
9693         (MainTest.test_platform_tests_are_found):
9694
9695 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
9696
9697         NRWT should honor --skipped=[default|ignore|only], like ORWT does
9698         https://bugs.webkit.org/show_bug.cgi?id=66308
9699
9700         Reviewed by Ryosuke Niwa.
9701
9702         This patch adds support for ORWT's --skipped=(default|ignore|only)
9703         flag and cleans up the interaction between that and --ignore.
9704
9705         Individual tests (but not directories) explicitly listed on the
9706         command line will always be run regardless of what is passed
9707         for --skipped and --ignore.
9708
9709         This patch also changes the "found" and "running" log messages
9710         since it wasn't clear how the skipped tests were included in those numbers.
9711
9712         * Scripts/webkitpy/layout_tests/controllers/manager.py:
9713         (Manager.__init__):
9714         (Manager.collect_tests):
9715         (Manager.prepare_lists_and_print_output):
9716         * Scripts/webkitpy/layout_tests/port/test.py:
9717         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
9718         (_set_up_derived_options):
9719         (parse_args):
9720         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
9721         (MainTest.test_ignore_flag):
9722         (MainTest):
9723         (MainTest.test_skipped_flag):
9724
9725 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
9726
9727         new-run-webkit-websocketserver must handle TLS related arguments
9728         https://bugs.webkit.org/show_bug.cgi?id=89079
9729
9730         Reviewed by Dirk Pranke.
9731
9732         PyWebSocket class must accept private_key, certificate, and
9733         ca_certificate arguments and pass them to launching pywebsocket.
9734         Also add ca_certificate handling to new-run-webkit-websocketserver.
9735
9736         * Scripts/new-run-webkit-websocketserver:
9737         (main):
9738         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
9739         (PyWebSocket.__init__):
9740         (PyWebSocket._prepare_config):
9741
9742 2012-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
9743
9744         Unreviewed. Update my email.
9745
9746         * Scripts/webkitpy/common/config/committers.py:
9747
9748 2012-06-14  Takashi Toyoshima  <toyoshim@chromium.org>
9749
9750         Update pywebsocket to 0.7.6 from 0.7.4
9751         https://bugs.webkit.org/show_bug.cgi?id=88975
9752
9753         Reviewed by Kent Tamura.
9754
9755         This new version of pywebsocket introduce following features.
9756          - Allow handlers to send a close frame with empty body in response of
9757              a client initiated closing handshake
9758          - Implement perframe compression extension
9759          - Support client certificate authentication
9760
9761         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
9762         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
9763         (_create_control_frame):
9764         (Stream._receive_frame):
9765         (Stream.send_message):
9766         (Stream.receive_message):
9767         (Stream._send_closing_handshake):
9768         (Stream.close_connection):
9769         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
9770         (ExtensionParsingException):
9771         (ExtensionParsingException.__init__):
9772         (_parse_extension_param):
9773         (_parse_extension):
9774         (parse_extensions):
9775         (format_extension):
9776         (format_extensions):
9777         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
9778         (_parse_compression_method):
9779         (_create_accepted_method_desc):
9780         (PerFrameCompressionExtensionProcessor):
9781         (PerFrameCompressionExtensionProcessor.__init__):
9782         (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
9783         (PerFrameCompressionExtensionProcessor._get_compression_processor_response):
9784         (PerFrameCompressionExtensionProcessor.get_extension_response):
9785         (PerFrameCompressionExtensionProcessor.setup_stream_options):
9786         (PerFrameCompressionExtensionProcessor.get_compression_processor):
9787         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
9788         (parse_token_list):
9789         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
9790         (Handshaker._parse_extensions):
9791         (Handshaker._send_handshake):
9792         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
9793         (WebSocketServer._create_sockets):
9794         (_get_logger_from_class):
9795         (_configure_logging):
9796         (_build_option_parser):
9797         (_main.if):
9798         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
9799         (RepeatedXorMasker.mask):
9800
9801 2012-06-14  Zoltan Horvath  <zoltan@webkit.org>
9802
9803         [Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore
9804
9805         Reviewed by Noam Rosenthal.
9806
9807         * qmake/mkspecs/features/features.prf:
9808
9809 2012-06-14  Christophe Dumez  <christophe.dumez@intel.com>
9810
9811         [WK2] Add implementation for registerIntentService in WebFrameLoaderClient
9812         https://bugs.webkit.org/show_bug.cgi?id=88399
9813
9814         Reviewed by Kenneth Rohde Christiansen.
9815
9816         Update initialization of WKPageLoaderClient.
9817
9818         * MiniBrowser/mac/BrowserWindowController.m:
9819         (-[BrowserWindowController awakeFromNib]):
9820         * WebKitTestRunner/TestController.cpp:
9821         (WTR::TestController::initialize):
9822
9823 2012-06-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
9824
9825         [EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
9826         https://bugs.webkit.org/show_bug.cgi?id=84577
9827
9828         Reviewed by Ryosuke Niwa.
9829
9830         Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
9831         LayoutTestController.
9832
9833         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
9834         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
9835
9836 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
9837
9838         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
9839         https://bugs.webkit.org/show_bug.cgi?id=88340
9840
9841         Reviewed by Kenneth Rohde Christiansen.
9842
9843         Update initialization of WKPageLoaderClient.
9844
9845         * MiniBrowser/mac/BrowserWindowController.m:
9846         (-[BrowserWindowController awakeFromNib]):
9847         * WebKitTestRunner/TestController.cpp:
9848         (WTR::TestController::initialize):
9849
9850 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
9851
9852         Unreviewed, rolling out r120268.
9853         http://trac.webkit.org/changeset/120268
9854         https://bugs.webkit.org/show_bug.cgi?id=89060
9855
9856         WebCompositor::setPerTilePaintingEnabled hits an assertion in
9857         DEBUG (Requested by dominicc|work on #webkit).
9858
9859         * DumpRenderTree/chromium/WebPreferences.cpp:
9860         (WebPreferences::applyTo):
9861
9862 2012-06-13  Tim Horton  <timothy_horton@apple.com>
9863
9864         REGRESSION (r120252): run-webkit-tests on Mac fails
9865         https://bugs.webkit.org/show_bug.cgi?id=89057
9866
9867         Reviewed by Dan Bernstein.
9868
9869         get_option will happily return None (the default only kicks in if
9870         the option is actually *not set*). We should instead check get_option's
9871         return value and default to "x86_64" architecture ourselves.
9872
9873         * Scripts/webkitpy/layout_tests/port/mac.py:
9874         (MacPort.__init__):
9875
9876 2012-06-13  Ian Vollick  <vollick@chromium.org>
9877
9878         [chromium] Certain settings in CCSettings could be global
9879         https://bugs.webkit.org/show_bug.cgi?id=88384
9880
9881         Reviewed by James Robinson.
9882
9883         * DumpRenderTree/chromium/WebPreferences.cpp:
9884         (WebPreferences::applyTo):
9885
9886 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
9887
9888         new-run-webkit-tests does not support --32-bit like ORWT did
9889         https://bugs.webkit.org/show_bug.cgi?id=71634
9890
9891         Reviewed by Ojan Vafai.
9892
9893         This patch adds support for 32-bit apple mac builds, adding the
9894         --32-bit flag for compatibility with ORWT and fixing the port
9895         architecture() definition to actually return the correct values.
9896
9897         * Scripts/webkitpy/layout_tests/port/apple.py:
9898         (ApplePort._generate_all_test_configurations):
9899         * Scripts/webkitpy/layout_tests/port/factory.py:
9900         (port_options):
9901         * Scripts/webkitpy/layout_tests/port/mac.py:
9902         (MacPort):
9903         (MacPort.__init__):
9904         (MacPort._build_driver_flags):
9905         (MacPort.setup_environ_for_server):
9906         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
9907         (test_sample_process_throws_exception):
9908         (test_32bit):
9909         (test_32bit.run_script):
9910         (test_64bit):
9911         (test_64bit.run_script):
9912         * Scripts/webkitpy/layout_tests/port/webkit.py:
9913         (WebKitPort._build_driver):
9914         (WebKitPort._build_driver_flags):
9915         * Scripts/webkitpy/layout_tests/port/win.py:
9916         (WinPort):
9917
9918 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
9919
9920         Remove webkitpy code to support legacy test_expectations.txt files
9921         https://bugs.webkit.org/show_bug.cgi?id=89038
9922
9923         Reviewed by Dirk Pranke.
9924
9925         * Scripts/webkitpy/layout_tests/port/base.py:
9926         (Port.path_to_test_expectations_file):
9927         (Port.expectations_dict):
9928         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
9929         (PortTest.test_uses_test_expectations_file):
9930         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
9931         (WebKitPortTest.test_path_to_test_expectations_file):
9932         (test_test_expectations):
9933         * Scripts/webkitpy/style/checker.py:
9934         (CheckerDispatcher.should_skip_without_warning):
9935         (CheckerDispatcher._create_checker):
9936         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
9937         (TestExpectationsTestCase._expect_port_for_expectations_path):
9938         * Scripts/webkitpy/tool/steps/commit.py:
9939         (Commit._check_test_expectations):
9940         * Scripts/webkitpy/tool/steps/commit_unittest.py:
9941         (CommitTest.test_check_test_expectations):
9942
9943 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
9944
9945         nrwt: remove port.test_expectations() and port.test_expectations_overrides()
9946         https://bugs.webkit.org/show_bug.cgi?id=88948
9947
9948         Reviewed by Ojan Vafai.
9949
9950         In the final patch of this run, we remove the
9951         test_expectations() and test_expectation_overrides() methods
9952         from the Port class - callers must now use just
9953         expectations_dict().
9954
9955         Note that support for the cascade in new-run-webkit-tests is
9956         complete but only Chromium uses it; webkit-patch
9957         rebaseline-expectations still does not support updating entries
9958         in any file other than the first expectations file, however.
9959
9960         * Scripts/webkitpy/layout_tests/port/base.py:
9961         (Port.path_to_test_expectations_file):
9962         (Port.uses_test_expectations_file):
9963         (Port.expectations_files):
9964         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
9965         (PortTest.test_additional_expectations):
9966         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
9967         (ChromiumPortTest.test_expectations_files):
9968         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
9969         (TestGoogleChromePort.test_get_google_chrome_port):
9970         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
9971         (test_test_expectations):
9972         (test_legacy_test_expectations):
9973
9974 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
9975
9976         nrwt: implement the actual cascade of TestExpectations
9977         https://bugs.webkit.org/show_bug.cgi?id=88947
9978
9979         Reviewed by Ojan Vafai.
9980
9981         This change implements the actual cascade by removing the
9982         concept of 'overrides' from the TestExpectations object and
9983         parsing each file separately.
9984
9985         There is an actual semantic change in this patch, in that
9986         setting an expectation on a directory in one file will override
9987         the expectations on any individual tests set in prior files. The
9988         test_overrides__directory() unit test verifies this.
9989
9990         Otherwise, this patch mostly consists of deleting code :).
9991
9992         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
9993         (TestExpectationsModel.__init__):
9994         (TestExpectationsModel.add_expectation_line):
9995         (TestExpectationsModel._add_test):
9996         (TestExpectationsModel._already_seen_better_match):
9997         (TestExpectations.__init__):
9998         (TestExpectations._add_expectations):
9999         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
10000         (test_overrides__directory):
10001
10002 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
10003
10004         webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
10005         https://bugs.webkit.org/show_bug.cgi?id=88946
10006
10007         Reviewed by Ojan Vafai.
10008
10009         In preparation for fully supporting cascading expectations files
10010         and removing the 'overrides' concept.
10011
10012         There should be no functional changes in this patch.
10013
10014         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
10015         (ManagerTest.test_update_summary_with_result):
10016         (ResultSummaryTest.get_result_summary):
10017         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
10018         (TestExpectations.__init__):
10019         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
10020         (parse_exp):
10021         (SkippedTests.check):
10022         (RemoveConfigurationsTest.test_remove):
10023         (test_remove_line):
10024         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
10025         (LintTest.test_all_configurations.FakePort.__init__):
10026         (LintTest.test_all_configurations.FakePort.expectations_dict):
10027         (LintTest.test_lint_test_files__errors):
10028         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
10029         (test_overrides_are_included_correctly):
10030
10031 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
10032
10033         webkitpy: rework the TestExpectations style checker in preparation for the cascade
10034         https://bugs.webkit.org/show_bug.cgi?id=88945
10035
10036         Reviewed by Ojan Vafai.
10037
10038         This patch changes the style checker to call the
10039         TestExpectations parser directly and be oblivious as to what the
10040         port's actual expectations are.
10041
10042         * Scripts/webkitpy/style/checkers/test_expectations.py:
10043         (TestExpectationsChecker.__init__):
10044         (TestExpectationsChecker.check_test_expectations):
10045
10046 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
10047
10048         nrwt: restructure the port classes to handle multiple expectations files
10049         https://bugs.webkit.org/show_bug.cgi?id=88944
10050
10051         Reviewed by Ojan Vafai.
10052
10053         This patch restructures the Port classes so that each port
10054         returns a list of TestExpectations files to be used (in a new, public,
10055         expectations_files() method), and the base implementation rolls them
10056         up into the ordered expectations_dict(), which becomes a public
10057         method.
10058
10059         port.path_to_test_expectations_file(), port.test_expectations(),
10060         and port.test_expectations_overrides() are then reimplemented as
10061         wrappers around port.expectations_dict().
10062         port.test_expectations() and port.test_expectations_overrides()
10063         will eventually be removed when the cascade is fully completed,
10064         and port.path_to_test_expectations_file() will be removed when
10065         the rebaselining tool supports the cascade
10066         (expectations_files() may also become private at that point).
10067
10068         There should be no functional changes in this patch, but a bunch
10069         of custom logic gets deleted!
10070
10071         * Scripts/webkitpy/layout_tests/port/base.py:
10072         (Port.expectations_dict):
10073         (Port):
10074         (Port.expectations_files):
10075         (Port.test_expectations):
10076         (Port.test_expectations_overrides):
10077         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
10078         (PortTest.test_additional_expectations):
10079         (PortTest.test_uses_test_expectations_file):
10080         * Scripts/webkitpy/layout_tests/port/chromium.py:
10081         (ChromiumPort.all_baseline_variants):
10082         (ChromiumPort.expectations_files):
10083         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
10084         (ChromiumPortTest.test_overrides_and_builder_names):
10085         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
10086         (_expectations_files):
10087         (GoogleChromeLinux32Port.expectations_files):
10088         (GoogleChromeLinux64Port.expectations_files):
10089         (GoogleChromeMacPort.expectations_files):
10090         (GoogleChromeWinPort.expectations_files):
10091         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
10092         (TestGoogleChromePort._verify_expectations_overrides):
10093         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
10094         (PortTestCase.test_expectations_ordering):
10095         * Scripts/webkitpy/layout_tests/port/webkit.py:
10096         (WebKitPort._skipped_file_search_paths):
10097         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
10098         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
10099         (test_rebaseline_updates_expectations_file):
10100         (test_rebaseline_does_not_include_overrides):
10101         (test_rebaseline_expectations):
10102         (test_overrides_are_included_correctly):
10103
10104 2012-06-13  Brent Fulgham  <bfulgham@webkit.org>
10105
10106         [WinCairo] Update URL of WinCairoRequirements.zip download.
10107         https://bugs.webkit.org/show_bug.cgi?id=89009
10108
10109         Reviewed by Martin Robinson.
10110
10111         * Tools/Scripts/update-webkit-dependency: Put fallback code
10112         to download a "last update" time from servers that don't properly
10113         report Last-Modified in their HTTP header.
10114         * Tools/Scripts/update-webkit-wincairo-libs: Change download link
10115         for the WinCairo build requirements bundle.
10116
10117 2012-06-13  Dirk Pranke  <dpranke@chromium.org>
10118
10119         nrwt: preliminary cleanup before supporting cascading expectations files
10120         https://bugs.webkit.org/show_bug.cgi?id=88942
10121
10122         Reviewed by Ojan Vafai.
10123
10124         This change just prepares the TestExpectations parser to get filenames
10125         along with the expectations, and improves the warning messages so that
10126         they contain the filenames along with the line numbers.
10127
10128         There should be no functional changes in this patch.
10129
10130         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
10131         (TestExpectationEditorTests.make_parsed_expectation_lines):
10132         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
10133         (TestExpectationParser.parse):
10134         (TestExpectationParser.expectation_for_skipped_test):
10135         (TestExpectationParser._tokenize):
10136         (TestExpectationParser._tokenize_list):
10137         (TestExpectationLine):
10138         (TestExpectationsModel.__init__):
10139         (TestExpectationsModel._already_seen_better_match):
10140         (TestExpectations.__init__):
10141         (TestExpectations._shorten_filename):
10142         (TestExpectations._report_warnings):
10143         (TestExpectations._add_skipped_tests):
10144         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
10145         (TestExpectationParserTests._tokenize):
10146         (TestExpectationParserTests.test_tokenize_blank):
10147         (TestExpectationParserTests.test_tokenize_missing_colon):
10148         (TestExpectationParserTests.test_tokenize_extra_colon):
10149         (TestExpectationParserTests.test_tokenize_empty_comment):
10150         (TestExpectationParserTests.test_tokenize_comment):
10151         (TestExpectationParserTests.test_tokenize_missing_equal):
10152         (TestExpectationParserTests.test_tokenize_extra_equal):
10153         (TestExpectationParserTests.test_tokenize_valid):
10154         (TestExpectationParserTests.test_tokenize_valid_with_comment):
10155         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
10156         (TestExpectationParserTests.test_parse_empty_string):
10157         (TestExpectationSerializerTests._tokenize):
10158         (TestExpectationSerializerTests.assert_round_trip):
10159         (TestExpectationSerializerTests.assert_list_round_trip):
10160         * Scripts/webkitpy/tool/servers/gardeningserver.py:
10161         (GardeningExpectationsUpdater.update_expectations):
10162
10163 2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
10164
10165         [Gtk] Enable link prefetch support in the developer builds
10166         https://bugs.webkit.org/show_bug.cgi?id=89011
10167
10168         Reviewed by Martin Robinson.
10169
10170         Enable the link prefetch support for Gtk by default in developer
10171         builds.
10172
10173         * Scripts/webkitperl/FeatureList.pm:
10174
10175 2012-06-13  Csaba Osztrogonác  <ossy@webkit.org>
10176
10177         Update buildbot master in autoinstaller to match build.webkit.org
10178         https://bugs.webkit.org/show_bug.cgi?id=88992
10179
10180         Reviewed by Adam Barth.
10181
10182         * Scripts/webkitpy/thirdparty/__init__.py:
10183         (AutoinstallImportHook._install_buildbot):
10184
10185 2012-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
10186
10187         Unreviewed, rolling out r120209.
10188         http://trac.webkit.org/changeset/120209
10189         https://bugs.webkit.org/show_bug.cgi?id=89007
10190
10191         Broke the WebKit2 mac build. (Requested by andersca on
10192         #webkit).
10193
10194         * MiniBrowser/mac/BrowserWindowController.m:
10195         (-[BrowserWindowController awakeFromNib]):
10196         * WebKitTestRunner/TestController.cpp:
10197         (WTR::TestController::initialize):
10198
10199 2012-06-13  Zoltan Horvath  <zoltan@webkit.org>
10200
10201         check-webkit-style needs to respect Qt API coding style
10202         https://bugs.webkit.org/show_bug.cgi?id=88995
10203
10204         Reviewed by Csaba Osztrogonác.
10205
10206         Add -whitespace/declaration exception to Qt API files.
10207
10208         * Scripts/webkitpy/style/checker.py:
10209
10210 2012-06-13  Christophe Dumez  <christophe.dumez@intel.com>
10211
10212         [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
10213         https://bugs.webkit.org/show_bug.cgi?id=88340
10214
10215         Reviewed by Kenneth Rohde Christiansen.
10216
10217         Update initialization of WKPageLoaderClient.
10218
10219         * MiniBrowser/mac/BrowserWindowController.m:
10220         (-[BrowserWindowController awakeFromNib]):
10221         * WebKitTestRunner/TestController.cpp:
10222         (WTR::TestController::initialize):
10223
10224 2012-06-13  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
10225
10226         [Qt] Handle multiple held buttons in touch mocking.
10227         https://bugs.webkit.org/show_bug.cgi?id=88865
10228
10229         Reviewed by Kenneth Rohde Christiansen.
10230
10231         Add handling for multiple held mouse-buttons in the appropiate places.
10232         To do this last-pos and start-pos are now also read from the last recorded
10233         touch-point instead from object-global variables.
10234
10235         * MiniBrowser/qt/MiniBrowserApplication.cpp:
10236         (MiniBrowserApplication::notify):
10237         (MiniBrowserApplication::updateTouchPoint):
10238         * MiniBrowser/qt/MiniBrowserApplication.h:
10239         (MiniBrowserApplication):
10240
10241 2012-06-13  Simon Hausmann  <simon.hausmann@nokia.com>
10242
10243         [Qt] Make it possible to disable -Werror in production builds
10244
10245         Reviewed by Tor Arne Vestbø.
10246
10247         Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
10248         something qt5.git's qtwebkit.pri will soon do.
10249
10250         * qmake/mkspecs/features/unix/default_post.prf:
10251
10252 2012-06-13  Dominik Röttsches  <dominik.rottsches@intel.com>
10253
10254         [EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
10255         https://bugs.webkit.org/show_bug.cgi?id=85790
10256
10257         Reviewed by Gustavo Noronha Silva.
10258
10259         Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
10260         code in webkitdirs.pm.
10261
10262         * Scripts/webkitdirs.pm:
10263         (jhbuildConfigurationChanged):
10264         (saveJhbuildMd5):
10265         (cleanJhbuild):
10266         (buildAutotoolsProject):
10267         (generateBuildSystemFromCMakeProject):
10268
10269 2012-06-13  Qi Zhang  <qi.2.zhang@nokia.com>
10270
10271         [Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
10272         https://bugs.webkit.org/show_bug.cgi?id=88763
10273
10274         Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
10275         extension.
10276
10277         Reviewed by Simon Hausmann.
10278
10279         * qmake/config.tests/libzlib: Added.
10280         * qmake/config.tests/libzlib/libzlib.cpp: Added.
10281         (main):
10282         * qmake/config.tests/libzlib/libzlib.pro: Added.
10283         * qmake/mkspecs/features/features.prf:
10284         * qmake/sync.profile:
10285
10286 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
10287
10288         [BlackBerry] Enable MEDIA_STREAM by default
10289         https://bugs.webkit.org/show_bug.cgi?id=88849
10290
10291         Reviewed by Antonio Gomes.
10292
10293         * Scripts/webkitperl/FeatureList.pm:
10294
10295 2012-06-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
10296
10297         Prevent stderr output from messing up detection of build path
10298
10299         https://bugs.webkit.org/show_bug.cgi?id=88075
10300
10301         Warnings such as 'perl: warning: Setting locale failed' will otherwise
10302         end up as the build path when calling out to webkit-build-directory.
10303
10304         Reviewed by Ojan Vafai.
10305
10306         * Scripts/webkitpy/layout_tests/port/config.py:
10307         (Config.build_directory):
10308
10309 2012-06-13  Ryosuke Niwa  <rniwa@webkit.org>
10310
10311         Update the builder name for Apple Lion builders.
10312
10313         * Scripts/webkitpy/layout_tests/port/builders.py:
10314
10315 2012-06-13  Joel Dillon  <joel.dillon@codethink.co.uk>
10316
10317         [Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
10318         https://bugs.webkit.org/show_bug.cgi?id=88874
10319
10320         Reviewed by Simon Hausmann.
10321
10322         Rename main.cpp in QtTestBrowser because on Windows
10323         it conflicts with main.cpp from DumpRenderTree.
10324
10325         * QtTestBrowser/QtTestBrowser.pro:
10326         * QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.
10327         (launcherMain):
10328         (LauncherApplication):
10329         (LauncherApplication::urls):
10330         (LauncherApplication::isRobotized):
10331         (LauncherApplication::robotTimeout):
10332         (LauncherApplication::robotExtraTime):
10333         (LauncherApplication::applyDefaultSettings):
10334         (LauncherApplication::LauncherApplication):
10335         (requiresGraphicsView):
10336         (LauncherApplication::handleUserOptions):
10337         (main):
10338
10339 2012-06-12  Lucas Forschler  <lforschler@apple.com>
10340
10341         Wrap bot types inside ().
10342         https://bugs.webkit.org/show_bug.cgi?id=88893
10343
10344         Reviewed by Stephanie Lewis.
10345
10346         * BuildSlaveSupport/build.webkit.org-config/config.json:
10347
10348 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
10349
10350         [soup] Prevent setting or editing httpOnly cookies from JavaScript
10351         https://bugs.webkit.org/show_bug.cgi?id=88760
10352
10353         Reviewed by Gustavo Noronha Silva.
10354
10355         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
10356         to v2.33.2 for both GTK and EFL ports.
10357
10358         * efl/jhbuild.modules:
10359         * gtk/jhbuild.modules:
10360
10361 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
10362
10363         [EFL] Enable SHADOW_DOM flag
10364         https://bugs.webkit.org/show_bug.cgi?id=87732
10365
10366         Reviewed by Kentaro Hara.
10367
10368         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
10369         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
10370         SHADOW_DOM by default in DRT.
10371         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
10372         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
10373         Chromium and Mac ports.
10374         (drtViewAdd):
10375         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
10376         at compile time for EFL port.
10377
10378 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
10379
10380         WinLauncher should show loading errors
10381         https://bugs.webkit.org/show_bug.cgi?id=80760
10382
10383         Reviewed by Brent Fulgham.
10384
10385         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
10386         (WinLauncherWebHost::didFailProvisionalLoadWithError):
10387         * WinLauncher/WinLauncher.h:
10388         (WinLauncherWebHost::didFailProvisionalLoadWithError):
10389         (WinLauncherWebHost):
10390
10391 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
10392
10393         [EFL][WK2] Add MiniBrowserEfl.
10394         https://bugs.webkit.org/show_bug.cgi?id=61850
10395
10396         Reviewed by Chang Shu.
10397
10398         Implement MiniBrowser for EFL.
10399
10400         * CMakeLists.txt:
10401         * MiniBrowser/efl/CMakeLists.txt: Added.
10402         * MiniBrowser/efl/main.c: Added.
10403         (_MiniBrowser):
10404         (main_signal_exit):
10405         (on_ecore_evas_resize):
10406         (browserCreate):
10407         (main):
10408
10409 2012-06-12  Helder Correia  <helder.correia@nokia.com>
10410
10411         Unreviewed. Update my email address in committers.py.
10412
10413         * Scripts/webkitpy/common/config/committers.py:
10414
10415 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
10416
10417         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
10418         https://bugs.webkit.org/show_bug.cgi?id=84707
10419
10420         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
10421         use_lib64 variable is preconfigured to True by jhbuild.
10422
10423         Reviewed by Dirk Pranke.
10424
10425         * efl/jhbuildrc:
10426
10427 2012-06-12  Dana Jansens  <danakj@chromium.org>
10428
10429         Add zlieber@chromium.org to contributors list
10430         https://bugs.webkit.org/show_bug.cgi?id=88904
10431
10432         Unreviewed.
10433
10434         * Scripts/webkitpy/common/config/committers.py:
10435
10436 2012-06-12  Lucas Forschler  <lforschler@apple.com>
10437
10438         Rename Apple bots to a standard convention.
10439         https://bugs.webkit.org/show_bug.cgi?id=88893
10440
10441         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
10442
10443         Reviewed by Simon Fraser.
10444
10445         * BuildSlaveSupport/build.webkit.org-config/config.json:
10446
10447 2012-06-12  Mike West  <mkwst@chromium.org>
10448
10449         Make document.documentURI readonly from JavaScript
10450         https://bugs.webkit.org/show_bug.cgi?id=65187
10451
10452         Reviewed by Alexey Proskuryakov.
10453
10454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10455         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
10456         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
10457         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
10458         (TestWebKitAPI):
10459         (TestWebKitAPI::TEST):
10460
10461 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
10462
10463         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
10464         https://bugs.webkit.org/show_bug.cgi?id=88715
10465
10466         Reviewed by Noam Rosenthal.
10467
10468         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
10469
10470         * Scripts/webkitperl/FeatureList.pm:
10471
10472 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
10473
10474         [Qt] Fix -Werror for the buildbots
10475         https://bugs.webkit.org/show_bug.cgi?id=88223
10476
10477         Rubber-stamped by Tor Arne Vestbø.
10478
10479         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
10480
10481         * qmake/mkspecs/features/unix/default_post.prf:
10482
10483 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
10484
10485         [REGRESSION][WTR] Build fail with werror after r120054
10486         https://bugs.webkit.org/show_bug.cgi?id=88862
10487
10488         Reviewed by Csaba Osztrogonác.
10489
10490         Some static helpers become unused after counterValueForElementById
10491         has moved to Internals. Let's remove them.
10492
10493         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
10494         (WTR):
10495
10496 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
10497
10498         [Qt] Slave losts cause build break on bots
10499         https://bugs.webkit.org/show_bug.cgi?id=38980
10500
10501         Minor fix after r59261.
10502
10503         Reviewed by Tor Arne Vestbø.
10504
10505         * Scripts/build-webkit:
10506         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
10507
10508 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
10509
10510         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
10511         https://bugs.webkit.org/show_bug.cgi?id=84406
10512
10513         Reviewed by Hajime Morita.
10514
10515         Move the counterValueForElementById from LayoutTestCotroller to Internals and
10516         remove the old platform specific implementations as it exclusively tests WebCore functionality.
10517
10518         * DumpRenderTree/LayoutTestController.cpp:
10519         (LayoutTestController::staticFunctions):
10520         * DumpRenderTree/LayoutTestController.h:
10521         (LayoutTestController):
10522         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
10523         * DumpRenderTree/chromium/LayoutTestController.cpp:
10524         (LayoutTestController::LayoutTestController):
10525         (LayoutTestController::setPOSIXLocale):
10526         * DumpRenderTree/chromium/LayoutTestController.h:
10527         (LayoutTestController):
10528         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
10529         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
10530         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
10531         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
10532         * DumpRenderTree/qt/LayoutTestControllerQt.h:
10533         (LayoutTestController):
10534         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
10535         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
10536         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
10537         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
10538         (WTR):
10539         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
10540         (LayoutTestController):
10541
10542 2012-06-11  Hans Wennborg  <hans@chromium.org>
10543
10544         Speech JavaScript API: Make SpeechRecognitionError an Event
10545         https://bugs.webkit.org/show_bug.cgi?id=88784
10546
10547         Reviewed by Adam Barth.
10548
10549         Make it possible to have MockWebSpeechRecognizer fire error events.
10550
10551         * DumpRenderTree/chromium/LayoutTestController.cpp:
10552         (LayoutTestController::LayoutTestController):
10553         (LayoutTestController::setMockSpeechRecognitionError):
10554         * DumpRenderTree/chromium/LayoutTestController.h:
10555         (LayoutTestController):
10556         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
10557         (WebKit):
10558         (ErrorTask):
10559         (WebKit::ErrorTask::ErrorTask):
10560         (MockWebSpeechRecognizer::addMockResult):
10561         (MockWebSpeechRecognizer::setError):
10562         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
10563         (MockWebSpeechRecognizer):
10564
10565 2012-06-11  Ojan Vafai  <ojan@chromium.org>
10566
10567         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
10568         https://bugs.webkit.org/show_bug.cgi?id=88836
10569
10570         Reviewed by Dirk Pranke.
10571
10572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
10573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
10574
10575 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
10576
10577         [EFL] Remove CMakeCache.txt before building
10578         https://bugs.webkit.org/show_bug.cgi?id=88717
10579
10580         Reviewed by Antonio Gomes.
10581
10582         Remove CMake cache file before every build to avoid using outdated
10583         build flags when new features get enabled. This will avoid unexpected
10584         failures on the bots due to outdated build flags.
10585
10586         * Scripts/webkitdirs.pm:
10587         (generateBuildSystemFromCMakeProject):
10588
10589 2012-06-11  Vincent Scheib  <scheib@chromium.org>
10590
10591         Add new Pointer Lock spec attribute webkitPointerLockElement.
10592         https://bugs.webkit.org/show_bug.cgi?id=88799
10593
10594         Reviewed by Dimitri Glazkov.
10595
10596         Part of a series of refactoring changes to update pointer lock API to
10597         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
10598
10599         New attribute webkitPointerLockElement added. Follow up patches
10600         will remove the previous isLocked attribute. Tests updated to use
10601         the new attribute.
10602
10603         WebViewHost logic required modification to correctly repond to
10604         a lock, unlock, pointerLockElement call series. Specifically,
10605         unlocking must be queued after a lock command is issued always
10606         as the lock state may not be set yet with a lock request in flight.
10607
10608         * DumpRenderTree/chromium/WebViewHost.cpp:
10609         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
10610         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
10611
10612 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
10613
10614         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
10615         https://bugs.webkit.org/show_bug.cgi?id=88804
10616
10617         Reviewed by Tony Chang.
10618
10619         Protect box-decoration-break behind a feature flag enabled by default.
10620
10621         * Scripts/webkitperl/FeatureList.pm:
10622         * qmake/mkspecs/features/features.pri:
10623
10624 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
10625
10626         [CMAKE][EFL] Remove duplicated executable output path
10627         https://bugs.webkit.org/show_bug.cgi?id=88765
10628
10629         Reviewed by Daniel Bates.
10630
10631         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
10632         need to define again because it is already defined in top-level CMake file.
10633
10634         * DumpRenderTree/efl/CMakeLists.txt:
10635         * EWebLauncher/CMakeLists.txt:
10636
10637 2012-06-11  Ojan Vafai  <ojan@chromium.org>
10638
10639         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
10640         https://bugs.webkit.org/show_bug.cgi?id=88816
10641
10642         Reviewed by Dirk Pranke.
10643
10644         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
10645         Expose a way to clear AsynchronousCaches.
10646         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
10647         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
10648         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
10649
10650 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
10651
10652         nrwt exits early too frequently
10653         https://bugs.webkit.org/show_bug.cgi?id=73843
10654
10655         Reviewed by Ryosuke Niwa.
10656
10657         Change the defaults for new-run-webkit-tests for both
10658         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
10659         to zero (i.e., we will never exit early by default).
10660
10661         If people want their buildbots to exit early it is their
10662         responsibility to update their buildbot configs appropriately.
10663
10664         Note that we have tests that ensure that these flags work for
10665         non-zero numbers, but we don't have tests that either test the
10666         default or ensure that zero means "run all of the tests". I
10667         think that's okay but can add tests if others disagree.
10668
10669         Also note that it looks like no changes on the build.webkit.org
10670         master.cfg are necessary; all of the bots seem to be using the
10671         RunWebKitTests wrapper which is already setting the flags. There
10672         is a NewRunWebKitTests wrapper, but that looks to be unused; I
10673         will delete that in a separate patch.
10674
10675         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10676         (parse_args):
10677
10678 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
10679
10680         [EFL] [DRT] Reset CacheModel before running each test
10681         https://bugs.webkit.org/show_bug.cgi?id=87534
10682
10683         Reviewed by Gustavo Noronha Silva.
10684
10685         Reset cache model to default before running each test to fix some
10686         flaky tests on EFL build bots. Also fix case value in setCacheModel.
10687
10688         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
10689         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
10690         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
10691         (LayoutTestController::setCacheModel):
10692
10693 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
10694
10695         [GTK] Memory leaks in DRT EventSender.cpp
10696         https://bugs.webkit.org/show_bug.cgi?id=88774
10697
10698         Reviewed by Martin Robinson.
10699
10700         Fix a few possible memory leaks in EventSender code.
10701
10702         * DumpRenderTree/gtk/EventSender.cpp:
10703         (contextClickCallback): Free the event returned by gdk_event_new().
10704         (mouseDownCallback): Ditto.
10705         (mouseUpCallback): Ditto.
10706
10707 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
10708
10709         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
10710         https://bugs.webkit.org/show_bug.cgi?id=88661
10711
10712         Reviewed by Dirk Pranke.
10713
10714         Pass string length explicitly when creating String object from
10715         non-null-terminated UChar* returned by characters().
10716
10717         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
10718         (LayoutTestController::pathToLocalResource):
10719
10720 2012-06-11  David Dorwin  <ddorwin@chromium.org>
10721
10722         [chromium] Provide access to the WebPlugin created by the helper plugin widget
10723         https://bugs.webkit.org/show_bug.cgi?id=88028
10724
10725         Reviewed by Adam Barth.
10726
10727         Added isPlaceholder() to WebPlugin.
10728
10729         * DumpRenderTree/chromium/TestWebPlugin.h:
10730         (TestWebPlugin::isPlaceholder):
10731
10732 2012-06-11  Tony Chang  <tony@chromium.org>
10733
10734         rebaseline from garden-o-matic leaves N processes each time it is run
10735         https://bugs.webkit.org/show_bug.cgi?id=88586
10736
10737         Reviewed by Dirk Pranke.
10738
10739         This appears to only be a problem on python 2.7. Maybe a bug causing
10740         pools to not be garbage collected?
10741
10742         * Scripts/webkitpy/common/system/executive.py:
10743         (Executive.run_in_parallel): close() and join() the process pool.
10744         * Scripts/webkitpy/common/system/executive_unittest.py:
10745         (ExecutiveTest.test_run_in_parallel):
10746
10747 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
10748
10749         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
10750         https://bugs.webkit.org/show_bug.cgi?id=87841
10751
10752         Reviewed by Simon Hausmann.
10753
10754         * qmake/config.tests/libwebp/libwebp.cpp: Added.
10755         (main):
10756         * qmake/config.tests/libwebp/libwebp.pro: Added.
10757         * qmake/sync.profile:
10758
10759 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
10760
10761         Expose layoutTestController as testRunner
10762         https://bugs.webkit.org/show_bug.cgi?id=88210
10763
10764         Reviewed by Darin Adler.
10765
10766         * DumpRenderTree/LayoutTestController.cpp:
10767         (LayoutTestController::makeWindowObject):
10768         * DumpRenderTree/chromium/TestShell.cpp:
10769         (TestShell::bindJSObjectsToWindow):
10770         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
10771         (WebCore::DumpRenderTree::initJSObjects):
10772         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
10773         (WTR::LayoutTestController::makeWindowObject):
10774
10775 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
10776
10777         [Chromium] Remove JavaScriptCore dependencies from gyp
10778         https://bugs.webkit.org/show_bug.cgi?id=88510
10779
10780         Reviewed by Adam Barth.
10781
10782         Chromium doesn't support JSC any more and there doesn't seem to be
10783         a strong interest in using GYP as the common build system in other
10784         ports.
10785
10786         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
10787         * Scripts/generate-project-files: Removed.
10788
10789 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
10790
10791         Add UNDO_MANAGER flag
10792         https://bugs.webkit.org/show_bug.cgi?id=87908
10793
10794         Reviewed by Tony Chang.
10795
10796         * Scripts/webkitperl/FeatureList.pm:
10797         * qmake/mkspecs/features/features.pri:
10798
10799 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
10800
10801         webkit-patch land-safely should set cq? if the patch author is not in committers.py
10802         https://bugs.webkit.org/show_bug.cgi?id=88689
10803
10804         Reviewed by Dirk Pranke.
10805
10806         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
10807         in committers.py or the contributor cannot commit. If anything, the contributor can still
10808         set cq+ on thier patches manually so I don't think this will be an issue for people who
10809         don't list their Bugzille email on committers.py.
10810
10811         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
10812         (Bugzilla._commit_queue_flag):
10813         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
10814         (test_commit_queue_flag):
10815         (test_commit_queue_flag.assert_commit_queue_flag):
10816
10817 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
10818
10819         remove obsolete NewRunWebKitTests buildbot master factory classes
10820         https://bugs.webkit.org/show_bug.cgi?id=88693
10821
10822         Reviewed by Ryosuke Niwa.
10823
10824         I believe these aren't used any more ...
10825
10826         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10827         (RunWebKitTests.getText2):
10828         (BuildAndTestLeaksFactory):
10829
10830 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
10831
10832         [Chromium-Android] Build DumpRenderTree with Android SDK
10833         https://bugs.webkit.org/show_bug.cgi?id=88598
10834
10835         Change WebKit side of DRT related code according to some recent changes at chromium side.
10836
10837         Reviewed by Adam Barth.
10838
10839         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
10840         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
10841         (ChromiumAndroidPort.__init__):
10842         (ChromiumAndroidPort._path_to_driver):
10843
10844 2012-06-08  Wei James  <james.wei@intel.com>
10845
10846         Add app_abi option for DumpRenderTree_apk
10847         https://bugs.webkit.org/show_bug.cgi?id=88626
10848
10849         Reviewed by Adam Barth.
10850
10851         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
10852
10853 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
10854
10855         [GTK] Add API to get the library version to WebKit2 GTK+
10856         https://bugs.webkit.org/show_bug.cgi?id=88426
10857
10858         Reviewed by Martin Robinson.
10859
10860         * gtk/generate-gtkdoc:
10861         (get_webkit2_options): Add built sources to the list of files, but
10862         ignore enum types and marshallers.
10863
10864 2012-06-07  Vincent Scheib  <scheib@chromium.org>
10865
10866         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
10867         https://bugs.webkit.org/show_bug.cgi?id=88604
10868
10869         Reviewed by Kent Tamura.
10870
10871         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
10872         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
10873
10874         * DumpRenderTree/chromium/WebViewHost.cpp:
10875         (WebViewHost::requestPointerUnlock):
10876
10877 2012-06-08  Hans Wennborg  <hans@chromium.org>
10878
10879         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
10880         https://bugs.webkit.org/show_bug.cgi?id=87976
10881
10882         Reviewed by Kent Tamura.
10883
10884         Provide a mock implementation of WebSpeechRecognizer for
10885         DumpRenderTree. This will allow better testing of the API via layout
10886         tests.
10887
10888         * DumpRenderTree/DumpRenderTree.gypi:
10889         * DumpRenderTree/chromium/LayoutTestController.cpp:
10890         (LayoutTestController::LayoutTestController):
10891         (LayoutTestController::addMockSpeechRecognitionResult):
10892         * DumpRenderTree/chromium/LayoutTestController.h:
10893         (LayoutTestController):
10894         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
10895         (MockWebSpeechRecognizer::create):
10896         (MockWebSpeechRecognizer::start):
10897         (MockWebSpeechRecognizer::stop):
10898         (MockWebSpeechRecognizer::abort):
10899         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
10900         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
10901         (MockWebSpeechRecognizer::ResultTask::runIfValid):
10902         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
10903         (WebKit):
10904         (MockWebSpeechRecognizer):
10905         (MockWebSpeechRecognizer::addMockResult):
10906         (MockWebSpeechRecognizer::taskList):
10907         (ClientCallTask):
10908         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
10909         (ResultTask):
10910         (MockWebSpeechRecognizer::ResultTask::ResultTask):
10911         (NoMatchTask):
10912         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
10913         * DumpRenderTree/chromium/WebViewHost.cpp:
10914         (WebViewHost::speechRecognizer):
10915         * DumpRenderTree/chromium/WebViewHost.h:
10916         (WebViewHost):
10917         (WebViewHost::mockSpeechRecognizer):
10918
10919 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
10920
10921         check-webkit-style needs to be taught about <public/Foo.h>
10922         https://bugs.webkit.org/show_bug.cgi?id=88524
10923
10924         Reviewed by David Levin.
10925
10926         * Scripts/webkitpy/style/checkers/cpp.py:
10927         (_classify_include):
10928         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
10929         (OrderOfIncludesTest.test_public_primary_header):
10930         (OrderOfIncludesTest.test_classify_include):
10931
10932 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
10933
10934         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
10935         https://bugs.webkit.org/show_bug.cgi?id=67255
10936
10937         Reviewed by Dirk Pranke.
10938
10939         Implement pathToLocalResource to redirect file:///tmp URL's to
10940         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
10941         LayoutTests sub-directory of the WebKit source tree.
10942
10943         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
10944         (LayoutTestController::pathToLocalResource):
10945
10946 2012-06-07  Tony Payne  <tpayne@chromium.org>
10947
10948         [chromium] Allow LayoutTests under new git workflow
10949         https://bugs.webkit.org/show_bug.cgi?id=88575
10950
10951         On Windows, chromium indirects through git.bat. Adds the same hack that
10952         is currently used for discovering svn.bat to support the new git
10953         workflow.
10954
10955         Reviewed by Dirk Pranke.
10956
10957         * Scripts/webkitpy/common/checkout/scm/git.py:
10958         (Git): Replaces all hard-coded references to 'git' with the class
10959         variable executable_name.
10960         (Git._check_git_architecture):
10961         (Git.in_working_directory):
10962         (Git.find_checkout_root):
10963         (Git.read_git_config):
10964         (Git.discard_local_commits):
10965         (Git.local_commits):
10966         (Git.working_directory_is_clean):
10967         (Git.clean_working_directory):
10968         (Git.status_command):
10969         (Git.add_list):
10970         (Git.delete_list):
10971         (Git.exists):
10972         (Git._current_branch):
10973         (Git.changed_files):
10974         (Git._changes_files_for_commit):
10975         (Git.revisions_changing_file):
10976         (Git.conflicted_files):
10977         (Git.svn_revision):
10978         (Git.create_patch):
10979         (Git._run_git_svn_find_rev):
10980         (Git.contents_at_revision):
10981         (Git.diff_for_file):
10982         (Git.show_head):
10983         (Git.committer_email_for_revision):
10984         (Git.apply_reverse_diff):
10985         (Git.revert_files):
10986         (Git.commit_with_message):
10987         (Git._commit_on_branch):
10988         (Git.svn_commit_log):
10989         (Git.last_svn_commit_log):
10990         (Git.svn_blame):
10991         (Git._branch_ref_exists):
10992         (Git.delete_branch):
10993         (Git.remote_merge_base):
10994         (Git.commit_locally_with_message):
10995         (Git.push_local_commits_to_server):
10996         (Git.commit_ids_from_commitish_arguments):
10997         (Git.commit_message_for_local_commit):
10998         (Git.files_changed_summary_for_commit):
10999         * Scripts/webkitpy/common/host.py:
11000         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
11001         that duplicates the logic in the existing 'svn.bat' hack.
11002
11003 2012-06-07  Ojan Vafai  <ojan@chromium.org>
11004
11005         Style build architectures like build versions for non-layout test failures
11006         https://bugs.webkit.org/show_bug.cgi?id=88590
11007
11008         Reviewed by Tony Chang.
11009
11010         Since we show the list of failing tests after the architecture, we want the
11011         buildtype and architecture to be grouped together visually.
11012
11013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
11014         (.effects a.failing-builder>span.architecture):
11015
11016 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
11017
11018         [Chromium] Remove header dependency of ImageDiff to WTF
11019         https://bugs.webkit.org/show_bug.cgi?id=88422
11020
11021         Reviewed by Ryosuke Niwa.
11022
11023         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11024         * DumpRenderTree/chromium/ImageDiff.cpp:
11025         (untestedCompareImages):
11026
11027 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
11028
11029         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
11030         https://bugs.webkit.org/show_bug.cgi?id=88491
11031
11032         Reviewed by Dirk Pranke.
11033
11034         DRT should enable WebAudio when WebAudio feature is enabled,
11035         so that the WebAudio feature could be tested by the Layouttest.
11036
11037         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
11038         (LayoutTestController::overridePreference):
11039
11040 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
11041
11042         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
11043         https://bugs.webkit.org/show_bug.cgi?id=88581
11044
11045         Reviewed by Ojan Vafai.
11046
11047         webkit-paptch rebaseline-expectations was ignoring what the
11048         expected results for a test were and pulling down all the result
11049         files from a bot. This could lead to us pulling down old,
11050         incorrect .txt or .png files. With this patch we will now only
11051         pull down expectations of the appropriate file types (so an
11052         IMAGE failure will only pull the png and not the txt file).
11053
11054         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
11055         (has_pixel_failures):
11056         (suffixes_for_expectations):
11057         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
11058         (FunctionsTest.test_suffixes_for_expectations):
11059         * Scripts/webkitpy/tool/commands/rebaseline.py:
11060         (AbstractRebaseliningCommand.__init__):
11061         (RebaselineExpectations._is_supported_port):
11062         (RebaselineExpectations._update_expectations_file):
11063         (RebaselineExpectations._tests_to_rebaseline):
11064         (RebaselineExpectations._rebaseline_port):
11065         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
11066         (test_overrides_are_included_correctly):
11067
11068 2012-06-07  Ojan Vafai  <ojan@chromium.org>
11069
11070         Fix recent null pointer error regression in the flakiness dashboard
11071         https://bugs.webkit.org/show_bug.cgi?id=88573
11072
11073         Reviewed by Dirk Pranke.
11074
11075         * TestResultServer/static-dashboards/builders.js:
11076         (requestBuilderList):
11077         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
11078
11079 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
11080
11081         Add Konrad Piascik to committers.py
11082         https://bugs.webkit.org/show_bug.cgi?id=88560
11083
11084         Unreviewed.
11085
11086         * Scripts/webkitpy/common/config/committers.py:
11087
11088 2012-06-07  Tony Chang  <tony@chromium.org>
11089
11090         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
11091         https://bugs.webkit.org/show_bug.cgi?id=77368
11092
11093         Reviewed by Ojan Vafai.
11094
11095         It doesn't look like we ever get a rect with width or height of 0.
11096         I ran css1, css2.1, fast/forms, and tables without any crashes.
11097
11098         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
11099         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
11100
11101 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
11102
11103         run-webkit-tests --lint-test-files gives an error when run on linux
11104         https://bugs.webkit.org/show_bug.cgi?id=88551
11105
11106         Reviewed by Ojan Vafai.
11107
11108         We weren't mapping the expectations properly for the
11109         google-chrome ports.
11110
11111         * Scripts/webkitpy/layout_tests/port/base.py:
11112         (Port.path_to_test_expectations_file):
11113         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
11114         (TestGoogleChromePort.test_path_to_expectations):
11115
11116 2012-06-07  Daniel Erat  <derat@chromium.org>
11117
11118         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
11119         https://bugs.webkit.org/show_bug.cgi?id=88263
11120
11121         Reviewed by Tony Chang.
11122
11123         * DumpRenderTree/chromium/LayoutTestController.cpp:
11124         (LayoutTestController::LayoutTestController):
11125         (LayoutTestController::reset):
11126         (LayoutTestController::setTextSubpixelPositioning):
11127         * DumpRenderTree/chromium/LayoutTestController.h:
11128         (LayoutTestController):
11129         * DumpRenderTree/chromium/fonts.conf:
11130
11131 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
11132
11133         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
11134         https://bugs.webkit.org/show_bug.cgi?id=88060
11135
11136         Reviewed by Martin Robinson.
11137
11138         Spin the main loop before acquiring the pixel content. This ensures things
11139         like late size allocations are finished before calling gtk_widget_draw,
11140         avoiding assertions and subsequent empty pixel results.
11141
11142         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
11143         (createBitmapContextFromWebView):
11144
11145 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
11146
11147         [Qt] Improve the visual of the viewport info box
11148         https://bugs.webkit.org/show_bug.cgi?id=88410
11149
11150         Reviewed by Tor Arne Vestbø.
11151
11152         Improve the visual and make it possible to see the content more easy.
11153
11154         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
11155
11156 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
11157
11158         [EFL][WK2] Compile webkit1 and webkit2 by default.
11159         https://bugs.webkit.org/show_bug.cgi?id=85041
11160
11161         Reviewed by Chang Shu.
11162
11163         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
11164         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
11165
11166         * Scripts/build-webkit:
11167
11168 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
11169
11170         Unreviewed, rolling out r119662.
11171         http://trac.webkit.org/changeset/119662
11172         https://bugs.webkit.org/show_bug.cgi?id=88487
11173
11174         Broke builds (Requested by rniwa on #webkit).
11175
11176         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11177         * DumpRenderTree/chromium/ImageDiff.cpp:
11178         (untestedCompareImages):
11179
11180 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
11181
11182         [Chromium] Remove header dependency of ImageDiff to WTF
11183         https://bugs.webkit.org/show_bug.cgi?id=88422
11184
11185         Reviewed by Adam Barth.
11186
11187         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11188         * DumpRenderTree/chromium/ImageDiff.cpp:
11189         (untestedCompareImages):
11190
11191 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
11192
11193         [WebKit] DeviceOrientation cleanup
11194         https://bugs.webkit.org/show_bug.cgi?id=88406
11195
11196         Reviewed by Kent Tamura.
11197
11198         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
11199
11200         * DumpRenderTree/chromium/LayoutTestController.cpp:
11201         (LayoutTestController::setMockDeviceOrientation):
11202
11203 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
11204
11205         webkitpy: add support for an ordered dict of test expectations
11206         https://bugs.webkit.org/show_bug.cgi?id=87802
11207
11208         Reviewed by Ojan Vafai.
11209
11210         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
11211         support a cascaded list of test expectations files. An easy way
11212         to think of this is as an ordered dictionary of name -> contents
11213         for files, where the name is usually a path on disk (I say
11214         usually because we want to support other kinds of expectations
11215         like the compile-time skips for unsupported features in
11216         webkit.py, and we want to continue to support "in-memory" test
11217         expectations that don't require a filesystem).
11218
11219         Conveniently there is an OrderedDict implementation in Python
11220         2.7+ and it is available as a backport, so the first step in
11221         adding this support is to use that implementation. Subsequent
11222         patches will update the test_expectations.py module (and other
11223         callers) to access the dict directly.
11224
11225         This patch just changes the base internal implementation and
11226         provides wrappers for compatibility. The derived ports
11227         (WebKitPort, TestPort, etc.) still need to be updated.
11228
11229         * Scripts/webkitpy/layout_tests/port/base.py:
11230         (Port._expectations_dict):
11231         (Port.test_expectations):
11232         (Port):
11233         (Port._expectations_overrides_dict):
11234         (Port.test_expectations_overrides):
11235         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
11236         (PortTestCase.test_expectations_ordering):
11237         (PortTestCase):
11238         (PortTestCase.test_expectations_overrides_ordering):
11239         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
11240         (OrderedDict):
11241         (OrderedDict.__init__):
11242         (OrderedDict.clear):
11243         (OrderedDict.__setitem__):
11244         (OrderedDict.__delitem__):
11245         (OrderedDict.__iter__):
11246         (OrderedDict.__reversed__):
11247         (OrderedDict.popitem):
11248         (OrderedDict.__reduce__):
11249         (OrderedDict.__repr__):
11250         (OrderedDict.copy):
11251         (OrderedDict.fromkeys):
11252
11253 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
11254
11255         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
11256
11257         * gtk/run-api-tests:
11258         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
11259
11260 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
11261
11262         nrwt should look in 'out' for binaries on chromium win to support ninja
11263         https://bugs.webkit.org/show_bug.cgi?id=88273
11264
11265         Reviewed by Tony Chang.
11266
11267         This patch standardizes the search algorithm the chromium ports
11268         use to figure out which driver to run. We will look in a
11269         chromium location before a webkit location (e.g., in
11270         Source/WebKit/chromium/out before out/) and we will look in the
11271         "legacy" directory (xcodebuild) before the directory ninja uses
11272         (out).
11273
11274         Unfortunately due to the way the test code is set up testing the
11275         properly requires some duplication of test code. I will fix that
11276         in a followup patch.
11277
11278         * Scripts/webkitpy/layout_tests/port/chromium.py:
11279         (ChromiumPort):
11280         (ChromiumPort._static_build_path):
11281         (ChromiumPort._build_path):
11282         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
11283         (ChromiumLinuxPort):
11284         (ChromiumLinuxPort._determine_driver_path_statically):
11285         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
11286         (ChromiumLinuxPortTest.test_build_path):
11287         (ChromiumLinuxPortTest):
11288         (ChromiumLinuxPortTest.test_driver_name_option):
11289         (ChromiumLinuxPortTest.path_to_image_diff):
11290         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
11291         (ChromiumMacPort):
11292         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
11293         (ChromiumMacPortTest.test_build_path):
11294         (ChromiumMacPortTest):
11295         (ChromiumMacPortTest.test_driver_name_option):
11296         (ChromiumMacPortTest.path_to_image_diff):
11297         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
11298         (ChromiumPortTest.test_overrides_and_builder_names):
11299         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
11300         (ChromiumWinPort):
11301         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
11302         (ChromiumWinTest.test_build_path):
11303         (ChromiumWinTest.test_operating_system):
11304         (ChromiumWinTest):
11305         (ChromiumWinTest.test_driver_name_option):
11306         (ChromiumWinPortTest.path_to_image_diff):
11307         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
11308         (PortTestCase.assert_build_path):
11309
11310 2012-06-06  Jessie Berlin  <jberlin@apple.com>
11311
11312         Remove very red Windows WebKit2 testers
11313         https://bugs.webkit.org/show_bug.cgi?id=88452
11314
11315         Reviewed by Steve Falkenburg.
11316
11317         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
11318         need to focus on getting the WK1 testers green.
11319
11320         * BuildSlaveSupport/build.webkit.org-config/config.json:
11321
11322 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
11323
11324         get rebaselining tools to kinda work with the skia overrides file
11325         https://bugs.webkit.org/show_bug.cgi?id=88456
11326
11327         Reviewed by Ryosuke Niwa.
11328
11329         Update rebaseline-expectations so that we read in the overrides
11330         when looking for tests to rebaseline, but don't read in the
11331         overrides when we are writing the expectations file back out.
11332         This prevents the overrides from getting written into the main
11333         file. This is kind of a hack but will have to do until we
11334         support multiple expectations files properly.
11335
11336         * Scripts/webkitpy/tool/commands/rebaseline.py:
11337         (RebaselineExpectations._expectations):
11338         (RebaselineExpectations._update_expectations_file):
11339         (RebaselineExpectations._tests_to_rebaseline):
11340         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
11341         (test_overrides_are_included_correctly):
11342
11343 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
11344
11345         webkitpy: two manager_worker_broker_unittest tests are broken
11346         https://bugs.webkit.org/show_bug.cgi?id=88445
11347
11348         Reviewed by Ojan Vafai.
11349
11350         These tests were never updated when we removed the
11351         --worker-model argument, and we were passing 'inline' instead of
11352         1 (for the number of workers) :(. As a result we were creating
11353         multiprocessing queues unnecessarily and that was failing on cygwin.
11354
11355         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
11356         (InterfaceTest.test_managerconnection_is_abstract):
11357         (InterfaceTest.test_workerconnection_is_abstract):
11358
11359 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
11360
11361         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
11362         https://bugs.webkit.org/show_bug.cgi?id=87406
11363
11364         Reviewed by Dirk Pranke.
11365
11366         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
11367         (TestExpectations.__init__):
11368         * Scripts/webkitpy/tool/commands/rebaseline.py:
11369         (RebaselineTest._update_expectations_file):
11370         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
11371         (test_rebaseline_does_not_include_overrides):
11372
11373 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
11374
11375         webkitpy: perf tests unit tests fail on chromium win
11376         https://bugs.webkit.org/show_bug.cgi?id=88279
11377
11378         Reviewed by Ryosuke Niwa.
11379
11380         I'm seeing weird failures running the unit tests in my win32
11381         checkout, and we don't really expect webpagereplay to work on
11382         win32 anyway, so I'm skipping the import of that module for now
11383         and adding a warning.
11384
11385         * Scripts/run-perf-tests:
11386         * Scripts/webkitpy/performance_tests/perftest.py:
11387
11388 2012-06-06  Yong Li <yoli@rim.com>
11389
11390         Unreviewed. Update my email address in committers.py.
11391
11392         * Scripts/webkitpy/common/config/committers.py:
11393
11394 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
11395
11396         Add Robert Kroeger  to commiters.py
11397         https://bugs.webkit.org/show_bug.cgi?id=88415
11398
11399         Unreviewed.
11400
11401         * Scripts/webkitpy/common/config/committers.py:
11402
11403 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
11404
11405         [EFL][DRT] http/tests/globalhistory testcases do not pass
11406         https://bugs.webkit.org/show_bug.cgi?id=82579
11407
11408         Reviewed by Csaba Osztrogonác.
11409
11410         DRT has provided callbacks for ewk_view "global history delegate" signals.
11411
11412         * DumpRenderTree/efl/DumpRenderTree.cpp:
11413         (isGlobalHistoryTest): Aux function to ident global history testcase.
11414         (createLayoutTestController):
11415         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
11416         (DumpRenderTreeChrome::createView):
11417         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
11418         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
11419         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
11420         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
11421         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
11422         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
11423         (DumpRenderTreeChrome):
11424
11425 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
11426
11427         [Qt] run-qtwebkit-tests hangs with -j1
11428         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
11429         This could happen due to an uncancelled timer after results were returned. This timer was
11430         started only if --timeout was set.
11431         https://bugs.webkit.org/show_bug.cgi?id=85475
11432
11433         Reviewed by Csaba Osztrogonác.
11434
11435         * Scripts/run-qtwebkit-tests:
11436         (run_test):
11437
11438 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
11439
11440         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
11441         https://bugs.webkit.org/show_bug.cgi?id=88327
11442
11443         Reviewed by Kenneth Rohde Christiansen.
11444
11445         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
11446         * MiniBrowser/qt/icons/contents_width.png: Added.
11447         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
11448         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
11449
11450 2012-06-05  Jon Lee  <jonlee@apple.com>
11451
11452         Buildbot fix.
11453
11454         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
11455         in the function. Store in a local variable.
11456         (loadBuilderConfig):
11457
11458 2012-06-05  Jon Lee  <jonlee@apple.com>
11459
11460         Buildbot fix.
11461
11462         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
11463         (loadBuilderConfig):
11464
11465 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
11466
11467         webkitpy: clean up win-specific path handling and tests
11468         https://bugs.webkit.org/show_bug.cgi?id=88281
11469
11470         Reviewed by Adam Barth.
11471
11472         There was a bunch of inconsistent logic for handling path
11473         conversions for win32 and cygwin paths due to us sometimes
11474         looking at sys.platform and sometimes using mock hosts. This
11475         patch cleans everything up so that we are required to pass
11476         PlatformInfo objects to the path module and stop trying to do
11477         different things when running on cygwin or win32 hosts (except
11478         in the path_unittest module itself).
11479
11480         This may slightly reduce test coverage for the win32 code paths
11481         but will be a lot easier to follow and maintain.
11482
11483         * Scripts/webkitpy/common/system/path.py:
11484         (abspath_to_uri):
11485         (_convert_path):
11486         * Scripts/webkitpy/common/system/path_unittest.py:
11487         (AbspathTest.platforminfo):
11488         (AbspathTest.test_abspath_to_uri_cygwin):
11489         (AbspathTest.test_abspath_to_uri_unixy):
11490         (AbspathTest.test_abspath_to_uri_win):
11491         (AbspathTest.test_abspath_to_uri_escaping_unixy):
11492         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
11493         (AbspathTest.test_stop_cygpath_subprocess):
11494         * Scripts/webkitpy/common/system/platforminfo.py:
11495         (PlatformInfo.__init__):
11496         (PlatformInfo.is_cygwin):
11497         * Scripts/webkitpy/common/system/platforminfo_mock.py:
11498         (MockPlatformInfo.is_cygwin):
11499         * Scripts/webkitpy/layout_tests/port/base.py:
11500         (Port.to.show_results_html_file):
11501         * Scripts/webkitpy/layout_tests/port/driver.py:
11502         (Driver.test_to_uri):
11503         (Driver.uri_to_test):
11504         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
11505         (DriverTest.test_test_to_uri):
11506         (DriverTest.test_uri_to_test):
11507         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
11508         (MockDRTPortTest.make_port):
11509         (MockDRTTest.input_line):
11510         (MockChromiumDRTTest.test_pixeltest__fails):
11511         * Scripts/webkitpy/layout_tests/port/test.py:
11512         * Scripts/webkitpy/layout_tests/port/win.py:
11513         (WinPort.show_results_html_file):
11514         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11515         (MainTest.test_unexpected_failures):
11516         (MainTest.test_results_directory_absolute):
11517         (MainTest.test_results_directory_default):
11518         (MainTest.test_results_directory_relative):
11519
11520 2012-06-05  Jon Lee  <jonlee@apple.com>
11521
11522         Workaround buildbot bug when merging build requests.
11523         https://bugs.webkit.org/show_bug.cgi?id=88158
11524
11525         Reviewed by Mark Rowe.
11526
11527         For expediency, we still want testers to pick the latest build to test, but to ensure
11528         that the builders are reporting the correct revision number, we should let the building bots
11529         run as they normally would. That is, the builder picks the oldest revision, and merges
11530         subsequent requests. Because merged requests get appended to the list of changes for a given
11531         build, the last change in that list is also the latest change. When we used pickLatestBuild
11532         for the builders, this was not the case (it would always report the penultimate change).
11533
11534         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
11535
11536         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
11537         for all Apple builders.
11538         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
11539         the latest build to run.
11540         (loadBuilderConfig):
11541
11542 2012-06-05  Jessie Berlin  <jberlin@apple.com>
11543
11544         [Win] DumpRenderTree should call resetInternalsObject
11545         https://bugs.webkit.org/show_bug.cgi?id=88346
11546
11547         Reviewed by Simon Fraser.
11548
11549         Invoke it on Windows in the same place it is invoked on Mac.
11550
11551         * DumpRenderTree/win/DumpRenderTree.cpp:
11552         (resetWebViewToConsistentStateBeforeTesting):
11553
11554 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
11555
11556         [GTK] Fix two more memory leaks in DRT
11557         https://bugs.webkit.org/show_bug.cgi?id=88255
11558
11559         Reviewed by Martin Robinson.
11560
11561         Fixed memory leaks in GTK's DRT code.
11562
11563         * DumpRenderTree/gtk/DumpRenderTree.cpp:
11564         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
11565         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
11566         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
11567         (createBitmapContextFromWebView): Free the cairo surface.
11568
11569 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
11570
11571         [Qt] Building when a top directory is named Source
11572         https://bugs.webkit.org/show_bug.cgi?id=77727
11573
11574         Reviewed by Tor Arne Vestbø.
11575
11576         Change regex to only replace the last instance of OUT_PWD.
11577
11578         * qmake/mkspecs/features/default_pre.prf:
11579
11580 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
11581
11582         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
11583         https://bugs.webkit.org/show_bug.cgi?id=73176
11584
11585         Reviewed by Adam Barth.
11586
11587         Two more APIs are added in Custom Scheme Handler specification.
11588         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
11589         One is 'isProtocolHandlerRegistered' to query whether the specific URL
11590         is registered or not.
11591         The other is 'unregisterProtocolHandler' to remove the registered URL.
11592
11593         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
11594
11595 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
11596
11597         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
11598         https://bugs.webkit.org/show_bug.cgi?id=83879
11599
11600         Reviewed by Carlos Garcia Campos.
11601
11602         Make minibrowser connect to the new 'permission requests' signal
11603         to allow users handle the Geolocation permission requests.
11604
11605         * MiniBrowser/gtk/BrowserWindow.c:
11606         (geolocationRequestDialogCallback): Callback for the dialog asking
11607         the user for allowing or not geolocation permission requests.
11608         (webViewDecidePermissionRequest): Launch a dialog to ask the user
11609         whether to allow or deny geolocation permission requests.
11610         (browserWindowConstructed): Connect to 'permission-request' signal.
11611
11612 2012-06-04  Chase Phillips  <cmp@google.com>
11613
11614         Make a builder group support+expect multiple loads.
11615         https://bugs.webkit.org/show_bug.cgi?id=88260
11616
11617         Change BuilderGroup to allow expecting multiple
11618         loads.  This allows merging results for a given set
11619         of builders into one group.
11620
11621         Add a test that verifies that the group count
11622         increments correctly based on successful and failed
11623         list loads.
11624
11625         Reviewed by Ojan Vafai.
11626
11627         * TestResultServer/static-dashboards/builders.js:
11628         (BuilderGroup):
11629         (BuilderGroup.prototype.setbuilder):
11630         (BuilderGroup.prototype.append):
11631         (BuilderGroup.prototype.loaded):
11632         (requestBuilderList.xhr.onload):
11633         (requestBuilderList.xhr.onerror):
11634         (onErrorLoadingBuilderList):
11635         (loadBuildersList):
11636         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
11637         (test):
11638         * TestResultServer/static-dashboards/run-unittests.html:
11639
11640 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
11641
11642         Python test fix attempt for Chromium Windows.
11643
11644         * Scripts/webkitpy/layout_tests/port/driver.py:
11645         (Driver.uri_to_test):
11646
11647 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
11648
11649         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
11650         https://bugs.webkit.org/show_bug.cgi?id=88243
11651
11652         Reviewed by Adam Barth.
11653
11654         * qmake/mkspecs/features/features.prf:
11655
11656 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
11657
11658         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
11659         https://bugs.webkit.org/show_bug.cgi?id=88280
11660
11661         Unreviewed, build fix.
11662
11663         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
11664         (TestServerProcess.test_basic):
11665
11666 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
11667
11668         test-webkitpy is hanging under cygwin
11669         https://bugs.webkit.org/show_bug.cgi?id=88269
11670
11671         Reviewed by Ryosuke Niwa.
11672
11673         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
11674         so we need to skip any tests that use it.
11675
11676         * Scripts/webkitpy/common/system/executive.py:
11677         (Executive.run_in_parallel):
11678         * Scripts/webkitpy/common/system/executive_unittest.py:
11679         (ExecutiveTest.test_run_in_parallel):
11680
11681 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
11682
11683         test-webkitpy is failing on win32 after r115054
11684         https://bugs.webkit.org/show_bug.cgi?id=88264
11685
11686         Reviewed by Ryosuke Niwa.
11687
11688         The failing http_server test was improperly suppressed (the
11689         tuple was missing a comma, and so wasn't a tuple at all, just a
11690         string) and so we were skipping *all* tests on win32. The right
11691         way to skip a single test is to disable it inside the test
11692         itself.
11693
11694         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
11695         (TestHttpServer.test_start_cmd):
11696         * Scripts/webkitpy/test/test_finder.py:
11697         (TestFinder._default_names):
11698         * Scripts/webkitpy/test/main.py:
11699         (Tester.run): Add error message if we don't find any tests to run.
11700         * Scripts/webkitpy/test/main_unittest.py:
11701
11702
11703 >>>>>>> 14e896e636a91f96dffeff452a7686217190ea72
11704 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
11705
11706         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
11707         https://bugs.webkit.org/show_bug.cgi?id=88215
11708
11709         Reviewed by Martin Robinson.
11710
11711         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
11712         for newly allocated strings.
11713
11714         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
11715         (attributeSetToString):
11716         (AccessibilityUIElement::allAttributes):
11717
11718 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
11719
11720         [GTK] Memory leaks in DumpRenderTree.cpp
11721         https://bugs.webkit.org/show_bug.cgi?id=88213
11722
11723         Reviewed by Martin Robinson.
11724
11725         Fixed memory leaks in DumpRenderTree.
11726
11727         * DumpRenderTree/gtk/DumpRenderTree.cpp:
11728         (appendString): Accepts const gchar* as the second argument.
11729         (dumpFramesAsText): Free the string returned by g_strdup_printf().
11730         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
11731
11732 2012-06-04  David Dorwin  <ddorwin@chromium.org>
11733
11734         Enable Chromium media player to instantiate a plugin
11735         https://bugs.webkit.org/show_bug.cgi?id=87399
11736
11737         Reviewed by Kent Tamura.
11738
11739         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
11740
11741         * DumpRenderTree/chromium/WebViewHost.cpp:
11742         (WebViewHost::createPopupMenu):
11743
11744 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
11745
11746         [GTK][WK2] Implement geolocation provider for the GTK port
11747         https://bugs.webkit.org/show_bug.cgi?id=83877
11748
11749         Reviewed by Carlos Garcia Campos.
11750
11751         * gtk/generate-gtkdoc:
11752         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
11753
11754 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
11755
11756         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
11757         https://bugs.webkit.org/show_bug.cgi?id=87668
11758
11759         Reviewed by Ryosuke Niwa.
11760
11761         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
11762         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might
11763         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true).
11764
11765         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
11766         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
11767
11768 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
11769
11770         [EFL] Refactor ewk_view_context_paint code.
11771         https://bugs.webkit.org/show_bug.cgi?id=85588
11772
11773         Reviewed by Hajime Morita.
11774
11775         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
11776
11777 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
11778
11779         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
11780         https://bugs.webkit.org/show_bug.cgi?id=87869
11781
11782         Reviewed by Andreas Kling.
11783
11784         Replace %lld by PRId64 macro to print an int64_t value and silent a
11785         compilation warning on 64-Bit.
11786
11787         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
11788         (onExceededApplicationCacheQuota):
11789
11790 2012-06-03  Varun Jain  <varunjain@google.com>
11791
11792         [chromium] Add new gesture type (two finger tap) that triggers context menu.
11793         https://bugs.webkit.org/show_bug.cgi?id=88173
11794
11795         Reviewed by Adam Barth.
11796
11797         * DumpRenderTree/chromium/EventSender.cpp:
11798         (EventSender::EventSender):
11799         (EventSender::gestureTwoFingerTap):
11800         (EventSender::gestureEvent):
11801         * DumpRenderTree/chromium/EventSender.h:
11802         (EventSender):
11803
11804 2012-06-02  Zeno Albisser  <zeno@webkit.org>
11805
11806         Fix and enable WebGL for WebKit2 on Qt.
11807         https://bugs.webkit.org/show_bug.cgi?id=86214
11808
11809         Enable WebGL by default for Qt MiniBrowser.
11810
11811         Reviewed by Noam Rosenthal.
11812
11813         * MiniBrowser/qt/qml/BrowserWindow.qml:
11814
11815 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
11816
11817         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
11818         https://bugs.webkit.org/show_bug.cgi?id=88164
11819
11820         Reviewed by Kentaro Hara.
11821
11822         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
11823         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
11824
11825         * Scripts/VCSUtils.pm:
11826         (adjustPathForRecentRenamings):
11827         (fixChangeLogPatch):
11828
11829 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
11830
11831         Rename test_expectations.txt to TestExpectations
11832         https://bugs.webkit.org/show_bug.cgi?id=86690
11833
11834         Reviewed by Dirk Pranke.
11835
11836         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
11837         We can the code to read test_expectations.txt once we've successfully transitioned.
11838
11839         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
11840         (TestExpectationParser._check_path_does_not_exist):
11841         (TestExpectationParser._tokenize):
11842         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
11843         * Scripts/webkitpy/layout_tests/port/base.py:
11844         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
11845         test_expectations.txt if one exists and the path to TestExpectations otherwise.
11846         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
11847         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
11848         virtual.
11849         * Scripts/webkitpy/layout_tests/port/chromium.py:
11850         (ChromiumPort.path_from_chromium_base):
11851         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
11852         (ChromiumAndroidPort.test_expectations):
11853         * Scripts/webkitpy/layout_tests/port/test.py:
11854         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
11855         (TestPort.__init__):
11856         * Scripts/webkitpy/layout_tests/port/webkit.py:
11857         (WebKitPort.baseline_search_path):
11858         (WebKitPort.test_expectations):
11859         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
11860         tests to base as a follow up.
11861         (WebKitPortTest.test_path_to_test_expectations_file):
11862         (test_test_expectations):
11863         (test_legacy_test_expectations):
11864         * Scripts/webkitpy/style/checker.py:
11865         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
11866         with one for TestExpectations.
11867         * Scripts/webkitpy/style/checkers/test_expectations.py:
11868         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
11869         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
11870         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
11871         test_expectations.txt.
11872         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
11873         (TestExpectationsTestCase.assert_lines_lint):
11874         * Scripts/webkitpy/tool/commands/queries.py:
11875         (PrintExpectations.__init__):
11876         * Scripts/webkitpy/tool/commands/rebaseline.py:
11877         (RebaselineExpectations):
11878         * Scripts/webkitpy/tool/steps/commit.py:
11879         (Commit._check_test_expectations):
11880         * Scripts/webkitpy/tool/steps/commit_unittest.py:
11881         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
11882         (CommitTest.test_check_test_expectations): For TestExpectations.
11883         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
11884         * TestResultServer/static-dashboards/dashboard_base.js:
11885         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
11886         Error only when neither exists.
11887         * TestResultServer/static-dashboards/flakiness_dashboard.js:
11888         (processMissingAndExtraExpectations):
11889         (htmlForTestsWithExpectationsButNoFailures):
11890         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
11891
11892 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
11893
11894         Remove dependency from ImageDiff to WTF
11895         https://bugs.webkit.org/show_bug.cgi?id=88147
11896
11897         Reviewed by Adam Barth.
11898
11899         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11900
11901 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
11902
11903         NRWT seems to leak (more?) temp dirs
11904         https://bugs.webkit.org/show_bug.cgi?id=88126
11905
11906         Re-land r119297 with chromium fix (weren't calling the
11907         super() method if not in --test-shell mode in start().
11908         Add unit tests to chromium_unittest as well to check.
11909
11910         * Scripts/webkitpy/layout_tests/port/chromium.py:
11911         (ChromiumDriver.start):
11912         * Scripts/webkitpy/layout_tests/port/webkit.py:
11913         (WebKitDriver.__del__):
11914         (WebKitDriver._start):
11915         (WebKitDriver.run_test):
11916         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
11917         (WebKitDriverTest.test_check_for_driver_crash):
11918         (WebKitDriverTest.test_stop_cleans_up_properly):
11919         (WebKitDriverTest):
11920         (WebKitDriverTest.test_two_starts_cleans_up_properly):
11921         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
11922         (ChromiumDriverTest.test_stop_cleans_up_properly):
11923         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
11924
11925 2012-06-01  Tim Horton  <timothy_horton@apple.com>
11926
11927         Lots of "failed download-built-product" on Apple bots
11928         https://bugs.webkit.org/show_bug.cgi?id=88158
11929
11930         Reviewed by Jessie Berlin.
11931
11932         Disable mergeRequests on all Apple builders. This is a speculative fix.
11933
11934         * BuildSlaveSupport/build.webkit.org-config/config.json:
11935
11936 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
11937
11938         Unreviewed, rolling out r119297.
11939         http://trac.webkit.org/changeset/119297
11940         https://bugs.webkit.org/show_bug.cgi?id=88156
11941
11942         May have broken Chromium bots (Requested by rniwa on #webkit).
11943
11944         * Scripts/webkitpy/layout_tests/port/webkit.py:
11945         (WebKitDriver.__del__):
11946         (WebKitDriver.run_test):
11947         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
11948         (WebKitDriverTest.test_check_for_driver_crash):
11949         (WebKitDriverTest.test_stop_cleans_up_properly):
11950
11951 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
11952
11953         nrwt seems to leak tmpdirs
11954         https://bugs.webkit.org/show_bug.cgi?id=88126
11955
11956         Reviewed by Ojan Vafai.
11957
11958         Fix leak possibly introduced in r118979 - we now will
11959         make sure we clean up any stale temp directories during the
11960         start routine and attempt to clean up again in __del__. It
11961         turns out that asserting in __del__ logs a message but is
11962         caught by the runtime, so it's mostly useless.
11963
11964         * Scripts/webkitpy/layout_tests/port/webkit.py:
11965         (WebKitDriver.__del__):
11966         (WebKitDriver._start):
11967         (WebKitDriver.run_test):
11968         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
11969         (WebKitDriverTest.test_check_for_driver_crash):
11970         (WebKitDriverTest.test_stop_cleans_up_properly):
11971         (WebKitDriverTest):
11972         (WebKitDriverTest.test_two_starts_cleans_up_properly):
11973
11974 2012-06-01  Michael Saboff  <msaboff@apple.com>
11975
11976         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
11977         https://bugs.webkit.org/show_bug.cgi?id=88109
11978
11979         Reviewed by Geoffrey Garen.
11980
11981         Additional test case.
11982
11983         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
11984         (TestWebKitAPI::TEST):
11985
11986 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
11987
11988         [Qt] Use -Werror only in developer builds
11989
11990         Rubber-stamped by Tor Arne Vestbø.
11991
11992         In production builds -Werror with custom toolchains and wierd system
11993         headers, -Werror is of no use and just creates confusion. So use it
11994         only if Qt is configured with -developer-build.
11995
11996         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
11997         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
11998         only if qt_developer_build is set.
11999
12000 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
12001
12002         [watchlist] Add myself to loader and v8 bindings changes
12003         https://bugs.webkit.org/show_bug.cgi?id=88112
12004
12005         Reviewed by Adam Barth.
12006
12007         * Scripts/webkitpy/common/config/watchlist:
12008
12009 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
12010
12011         Adding Jacky Jiang to committers.py
12012         https://bugs.webkit.org/show_bug.cgi?id=88122
12013
12014         Reviewed by Rob Buis.
12015
12016         Adding myself to committers.py as a Committer.
12017
12018         * Scripts/webkitpy/common/config/committers.py:
12019
12020 2012-06-01  Jessie Berlin  <jberlin@apple.com>
12021
12022         Fix Windows build.
12023
12024         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
12025
12026 2012-06-01  Jessie Berlin  <jberlin@apple.com>
12027
12028         Windows WK2 MouseMoveAfterCrash API test failing
12029         https://bugs.webkit.org/show_bug.cgi?id=69982
12030
12031         Disable the test on Windows to get the bots greener.
12032
12033         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
12034         (TestWebKitAPI::TEST):
12035
12036 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
12037
12038         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
12039         https://bugs.webkit.org/show_bug.cgi?id=86866
12040
12041         Reviewed by Adam Barth.
12042
12043         Catch new "intent,service,register" signal on the frame and print out
12044         information about the Web Intent service in EFL's DumpRenderTree.
12045
12046         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
12047         (DumpRenderTreeChrome::createView):
12048         (DumpRenderTreeChrome::onFrameCreated):
12049         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
12050         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
12051         (DumpRenderTreeChrome):
12052
12053 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
12054
12055         The ChangeLog parser cannot handle reviewers with initials in their name
12056         https://bugs.webkit.org/show_bug.cgi?id=87864
12057
12058         Reviewed by Ryosuke Niwa.
12059
12060         Add support in the ChangeLog parser for reviewer names that have
12061         initials in them.
12062
12063         * Scripts/webkitpy/common/checkout/changelog.py:
12064         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
12065         in the replacement string. This allows for matching the word characters before a
12066         period, without totally throwing them away.
12067         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
12068         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
12069         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
12070
12071 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
12072
12073         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
12074         https://bugs.webkit.org/show_bug.cgi?id=86865
12075
12076         Reviewed by Adam Barth.
12077
12078         Add deliverWebIntent method to LayoutTestController and provide
12079         implementation for EFL port.
12080
12081         * DumpRenderTree/LayoutTestController.cpp:
12082         (deliverWebIntentCallback):
12083         (LayoutTestController::staticFunctions):
12084         * DumpRenderTree/LayoutTestController.h:
12085         (LayoutTestController):
12086         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
12087         (LayoutTestController::deliverWebIntent):
12088         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
12089         (LayoutTestController::deliverWebIntent):
12090         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
12091         (LayoutTestController::deliverWebIntent):
12092         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
12093         (LayoutTestController::deliverWebIntent):
12094         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
12095         (LayoutTestController::deliverWebIntent):
12096         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
12097         (LayoutTestController::deliverWebIntent):
12098
12099 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
12100
12101         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
12102
12103         Reviewed by Simon Hausmann.
12104
12105         * Tools.pro:
12106
12107 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
12108
12109         Add public page loading performance tests using web-page-replay
12110         https://bugs.webkit.org/show_bug.cgi?id=84008
12111
12112         Reviewed by Dirk Pranke.
12113
12114         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
12115         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
12116         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
12117
12118         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
12119         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
12120         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
12121         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
12122
12123         * Scripts/webkitpy/layout_tests/port/driver.py:
12124         (Driver.is_external_http_test): Added.
12125         * Scripts/webkitpy/layout_tests/port/webkit.py:
12126         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
12127         * Scripts/webkitpy/performance_tests/perftest.py:
12128         (PerfTest.__init__): Takes port.
12129         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
12130         (PerfTest):
12131         (PerfTest.run): Calls run_single.
12132         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
12133         (ChromiumStylePerfTest.__init__):
12134         (PageLoadingPerfTest.__init__):
12135         (PageLoadingPerfTest.run):
12136         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
12137         (ReplayServer.__init__):
12138         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
12139         but it caused a dead lock on some web pages.
12140         (ReplayServer.stop):
12141         (ReplayServer.__del__):
12142         (ReplayPerfTest):
12143         (ReplayPerfTest.__init__):
12144         (ReplayPerfTest._start_replay_server):
12145         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
12146         The subsequent runs of the same test will just use test.wpr.
12147         (ReplayPerfTest.run_single):
12148         (PerfTestFactory):
12149         (PerfTestFactory.create_perf_test):
12150         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
12151         (MainTest.test_parse_output):
12152         (MainTest.test_parse_output_with_failing_line):
12153         (TestPageLoadingPerfTest.test_run):
12154         (TestPageLoadingPerfTest.test_run_with_bad_output):
12155         (TestReplayPerfTest):
12156         (TestReplayPerfTest.ReplayTestPort):
12157         (TestReplayPerfTest.ReplayTestPort.__init__):
12158         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
12159         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
12160         (TestReplayPerfTest.ReplayTestPort._driver_class):
12161         (TestReplayPerfTest.MockReplayServer):
12162         (TestReplayPerfTest.MockReplayServer.__init__):
12163         (TestReplayPerfTest.MockReplayServer.stop):
12164         (TestReplayPerfTest._add_file):
12165         (TestReplayPerfTest._setup_test):
12166         (TestReplayPerfTest.test_run_single):
12167         (TestReplayPerfTest.test_run_single.run_test):
12168         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
12169         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
12170         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
12171         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
12172         (TestReplayPerfTest.test_prepare):
12173         (TestReplayPerfTest.test_prepare.run_test):
12174         (TestReplayPerfTest.test_prepare_calls_run_single):
12175         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
12176         (TestPerfTestFactory.test_regular_test):
12177         (TestPerfTestFactory.test_inspector_test):
12178         (TestPerfTestFactory.test_page_loading_test):
12179         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
12180         (PerfTestsRunner):
12181         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
12182         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
12183         (PerfTestsRunner._collect_tests._is_test_file):
12184         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
12185         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
12186         (create_runner):
12187         (run_test):
12188         (_tests_for_runner):
12189         (test_run_test_set):
12190         (test_run_test_set_kills_drt_per_run):
12191         (test_run_test_pause_before_testing):
12192         (test_run_test_set_for_parser_tests):
12193         (test_run_test_set_with_json_output):
12194         (test_run_test_set_with_json_source):
12195         (test_run_test_set_with_multiple_repositories):
12196         (test_run_with_upload_json):
12197         (test_upload_json):
12198         (test_upload_json.MockFileUploader.upload_single_text_file):
12199         (_add_file):
12200         (test_collect_tests):
12201         (test_collect_tests_with_multile_files):
12202         (test_collect_tests_with_multile_files.add_file):
12203         (test_collect_tests_with_skipped_list):
12204         (test_collect_tests_with_page_load_svg):
12205         (test_collect_tests_should_ignore_replay_tests_by_default):
12206         (test_collect_tests_with_replay_tests):
12207         (test_parse_args):
12208         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
12209         (AutoinstallImportHook.find_module):
12210         (AutoinstallImportHook._install_webpagereplay):
12211
12212 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
12213
12214         Support building the Android port of chromium with Ninja
12215         https://bugs.webkit.org/show_bug.cgi?id=87545
12216
12217         Reviewed by Adam Barth.
12218
12219         Ensures that shared libraries are looked up in a generator-agnostic
12220         way and that output is placed in the correct directory.
12221
12222         Depends on http://codereview.chromium.org/10386188/
12223
12224         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
12225
12226 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
12227
12228         [Chromium] Chromium DRT should be able to load external resources
12229         https://bugs.webkit.org/show_bug.cgi?id=87893
12230
12231         Reviewed by Dirk Pranke.
12232
12233         Allow external resources to be loaded when the main frame's URL is also an external resource.
12234         This change is analogous to r118231 for Mac port.
12235
12236         * DumpRenderTree/chromium/WebViewHost.cpp:
12237         (blockRequest):
12238         (isLocalhost):
12239         (hostIsUsedBySomeTestsToGenerateError):
12240         (WebViewHost::willSendRequest):
12241
12242 2012-05-31  Anders Carlsson  <andersca@apple.com>
12243
12244         Build fixes.
12245
12246         Disable the C++11 extensions warning.
12247
12248         * DumpRenderTree/mac/Configurations/Base.xcconfig:
12249         * TestWebKitAPI/Configurations/Base.xcconfig:
12250         * WebKitTestRunner/Configurations/Base.xcconfig:
12251
12252 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
12253
12254         [WK2] window.internals settings are not reset between tests
12255         https://bugs.webkit.org/show_bug.cgi?id=87783
12256
12257         Reviewed by Mihai Parparita.
12258
12259         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
12260         (WTR::InjectedBundle::done): Call resetAfterTest().
12261
12262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
12263         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
12264         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
12265         This needs to be done after a tets, because the code assumes that there is an object
12266         with this name in global scope.
12267
12268         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
12269
12270 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
12271
12272         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
12273         https://bugs.webkit.org/show_bug.cgi?id=85006
12274
12275         Reviewed by Tor Arne Vestbø.
12276
12277         Added navigation_policy_decision implementation for DumpRenderTreeView.
12278         Added LayoutTestController::setCustomPolicyDelegate implementation.
12279         Modified LayoutTestController::waitForPolicyDelegate.
12280
12281         * DumpRenderTree/efl/DumpRenderTree.cpp:
12282         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
12283         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
12284         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
12285         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
12286         (navigationTypeToString): aux function
12287         (onNavigationPolicyDecision): navigation_policy_decision implementation
12288         (drtViewAdd):
12289         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
12290         (LayoutTestController::setCustomPolicyDelegate):
12291         (LayoutTestController::waitForPolicyDelegate):
12292
12293 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
12294
12295         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
12296         https://bugs.webkit.org/show_bug.cgi?id=86195
12297
12298         Reviewed by Gustavo Noronha Silva.
12299
12300         Implement clearApplicationCacheForOrigin in EFL
12301         LayoutTestController.
12302
12303         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
12304         (LayoutTestController::clearApplicationCacheForOrigin):
12305
12306 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
12307
12308         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
12309         https://bugs.webkit.org/show_bug.cgi?id=87955
12310
12311         Reviewed by Simon Hausmann.
12312
12313         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
12314         * DumpRenderTree/qt/EventSenderQt.cpp:
12315         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
12316         * DumpRenderTree/qt/main.cpp:
12317         * QtTestBrowser/cookiejar.cpp:
12318         * QtTestBrowser/launcherwindow.cpp:
12319         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
12320         * qmake/mkspecs/features/default_post.prf:
12321
12322 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
12323
12324         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
12325
12326         Rubber-stamped by Kenneth Rohde Christiansen.
12327
12328         * qmake/config.tests/libpng/libpng.pro:
12329
12330 2012-05-30  Peter Beverloo  <peter@chromium.org>
12331
12332         [Chromium] Automatically install 64-bit linker for Android
12333         https://bugs.webkit.org/show_bug.cgi?id=79780
12334
12335         Reviewed by Adam Barth.
12336
12337         Change the update-webkit-chromium script to check whether the 64-bit
12338         linker needs to be installed as part of the update process. The actual
12339         code for doing these checks and "installing" it has been added to the
12340         webkitdirs.pm script.
12341
12342         The linker itself is part of the third_party/aosp repository, which
12343         will be pulled in through the DEPS change.
12344
12345         * Scripts/update-webkit-chromium:
12346         * Scripts/webkitdirs.pm:
12347         (chromiumInstall64BitAndroidLinkerIfNeeded):
12348         (chromiumReplaceAndroidLinkerIfNeeded):
12349
12350 2012-05-30  Stephanie Lewis  <slewis@apple.com>
12351
12352         https://bugs.webkit.org/show_bug.cgi?id=87803
12353         Layout tests often fail trying to stat nonexistent logs
12354
12355         Reviewed by Dirk Pranke.
12356
12357         CrashReporter removes logs using a heuristic to conserve space.  Wrap a
12358         try/catch block around accessing the logs as a precaution.
12359
12360         * Scripts/webkitpy/common/system/crashlogs.py:
12361         (CrashLogs._find_newest_log_darwin):
12362
12363 2012-05-30  Gavin Peters  <gavinp@chromium.org>
12364
12365         Add a LayoutTest for prerender remove after stop.
12366         https://bugs.webkit.org/show_bug.cgi?id=87860
12367
12368         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
12369         can be tested by LayoutTests now.
12370
12371         Reviewed by Adam Barth.
12372
12373         * DumpRenderTree/DumpRenderTree.gypi:
12374         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
12375         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
12376         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
12377         (MockWebPrerenderingSupport::add):
12378         (MockWebPrerenderingSupport::cancel):
12379         (MockWebPrerenderingSupport::abandon):
12380         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
12381         (MockWebPrerenderingSupport):
12382         * DumpRenderTree/chromium/TestShell.cpp:
12383         (TestShell::initialize):
12384         * DumpRenderTree/chromium/TestShell.h:
12385         (TestShell):
12386         * DumpRenderTree/chromium/WebViewHost.cpp:
12387         (WebViewHost::willAddPrerender):
12388         (WebViewHost::setWebWidget):
12389         * DumpRenderTree/chromium/WebViewHost.h:
12390         (WebViewHost):
12391
12392 2012-05-30  Stephanie Lewis  <slewis@apple.com>
12393
12394         https://bugs.webkit.org/show_bug.cgi?id=87717
12395         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
12396
12397         Reviewed by Dirk Pranke.
12398
12399         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
12400         If there isn't a crash log found for the process add a message saying
12401         the process was unresponsive.
12402
12403         * Scripts/webkitpy/layout_tests/port/webkit.py:
12404         (WebKitDriver.__init__):
12405         (WebKitDriver._check_for_driver_crash):
12406         (WebKitDriver.run_test):
12407         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12408         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
12409         (WebKitDriverTest):
12410         (WebKitDriverTest.test_check_for_driver_crash):
12411         * WebKitTestRunner/TestController.cpp:
12412         (WTR):
12413         (WTR::TestController::runTest):
12414
12415 2012-05-30  Stephanie Lewis  <slewis@apple.com>
12416
12417         https://bugs.webkit.org/show_bug.cgi?id=87714
12418         Mac crash logs can take a really long time to be written out.
12419
12420         Reviewed by Dirk Pranke.
12421
12422         Make a second pass looking for crash logs after the tests have completed running.
12423
12424         * Scripts/webkitpy/layout_tests/controllers/manager.py:
12425         (use_trac_links_in_results_html):
12426         (Manager.run):
12427         * Scripts/webkitpy/layout_tests/port/base.py:
12428         (Port.repository_paths):
12429         (Port.look_for_new_crash_logs):
12430         * Scripts/webkitpy/layout_tests/port/mac.py:
12431         (MacPort.look_for_new_crash_logs):
12432         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
12433         (test_get_crash_log):
12434         (test_look_for_new_crash_logs):
12435         (test_look_for_new_crash_logs.fake_time_cb):
12436
12437 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
12438
12439         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
12440
12441         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
12442         (LayoutWebViewEventHandler::OnAlertEvent):
12443         (LayoutWebViewEventHandler::OnConfirmEvent):
12444         (LayoutWebViewEventHandler):
12445         (LayoutWebViewEventHandler::OnPromptEvent):
12446         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
12447         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
12448 >>>>>>> b26c2f2c82d3f0b1f365b47339c570f0c77fe1ae
12449
12450 2012-05-30  Ojan Vafai  <ojan@chromium.org>
12451
12452         Only give lint errors for -expected.png png files that lack a checksum
12453         https://bugs.webkit.org/show_bug.cgi?id=87875
12454
12455         Reviewed by Tony Chang.
12456
12457         We have other pngs in the tree, e.g. for the inspector, that legitimately
12458         lack a checksum.
12459
12460         * Scripts/webkitpy/style/checkers/png.py:
12461         (PNGChecker.check):
12462         * Scripts/webkitpy/style/checkers/png_unittest.py:
12463         (PNGCheckerTest.test_check):
12464
12465 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
12466
12467         nrwt: seems to leak temp dirs
12468         https://bugs.webkit.org/show_bug.cgi?id=87795
12469
12470         Reviewed by Ojan Vafai.
12471
12472         There appears to be a bug where the chromium bots are creating
12473         temporary directories and not cleaning them up that started
12474         after the switch to WebKitDriver. It's possible that __del__
12475         wasn't getting called in a timely manner (or at all), and it's
12476         generally bad style to rely on __del__ being called, so this
12477         code changes things so that we create a temp dir in
12478         driver.start() and remove it in driver.stop(). We could be
12479         paranoid and leave the __del__ code in, but there doesn't seem
12480         to be much advantage to it. If there are bugs that result in
12481         drivers being started but not stopped, we have other problems.
12482
12483         * Scripts/webkitpy/common/system/filesystem_mock.py:
12484         (MockFileSystem.__init__):
12485         (MockFileSystem._mktemp):
12486         (MockFileSystem.mkdtemp):
12487         * Scripts/webkitpy/layout_tests/port/webkit.py:
12488         (WebKitDriver.__init__):
12489         (WebKitDriver._start):
12490         (WebKitDriver.stop):
12491         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12492         (WebKitDriverTest.test_check_for_driver_crash):
12493         (WebKitDriverTest):
12494         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
12495         (WebKitDriverTest.test_stop_cleans_up_properly):
12496
12497 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
12498
12499         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
12500         https://bugs.webkit.org/show_bug.cgi?id=86841
12501
12502         Reviewed by Adam Barth.
12503
12504         Print the number of MessagePorts for each new intent in EFL's DRT.
12505         This output is expected by several Web Intents test cases.
12506
12507         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
12508         (DumpRenderTreeChrome::onFrameIntentNew):
12509
12510 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
12511
12512         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
12513
12514         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
12515
12516 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
12517
12518         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
12519         https://bugs.webkit.org/show_bug.cgi?id=87829
12520
12521         Reviewed by Adam Barth.
12522
12523         EFL's LayoutTestController now makes uses of the new helper method in
12524         DumpRenderTreeSupportEfl in order to send the intent response. This is
12525         now needed because the Ewk_Intent_Request postResult / postFailure
12526         methods were made private.
12527
12528         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
12529         (LayoutTestController::sendWebIntentResponse):
12530
12531 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
12532
12533         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
12534         https://bugs.webkit.org/show_bug.cgi?id=86296
12535
12536         Reviewed by Tony Chang.
12537
12538         * DumpRenderTree/win/DRTDataObject.cpp: Added.
12539         (cfHDropFormat):
12540         (cfFileNameWFormat):
12541         (cfUrlWFormat):
12542         (WCEnumFormatEtc):
12543         (WCEnumFormatEtc::WCEnumFormatEtc):
12544         (WCEnumFormatEtc::QueryInterface):
12545         (WCEnumFormatEtc::AddRef):
12546         (WCEnumFormatEtc::Release):
12547         (WCEnumFormatEtc::Next):
12548         (WCEnumFormatEtc::Skip):
12549         (WCEnumFormatEtc::Reset):
12550         (WCEnumFormatEtc::Clone):
12551         (DRTDataObject::createInstance):
12552         (DRTDataObject::DRTDataObject):
12553         (DRTDataObject::~DRTDataObject):
12554         (DRTDataObject::QueryInterface):
12555         (DRTDataObject::AddRef):
12556         (DRTDataObject::Release):
12557         (DRTDataObject::GetData):
12558         (DRTDataObject::GetDataHere):
12559         (DRTDataObject::QueryGetData):
12560         (DRTDataObject::GetCanonicalFormatEtc):
12561         (DRTDataObject::SetData):
12562         (DRTDataObject::CopyMedium):
12563         (DRTDataObject::EnumFormatEtc):
12564         (DRTDataObject::DAdvise):
12565         (DRTDataObject::DUnadvise):
12566         (DRTDataObject::EnumDAdvise):
12567         (DRTDataObject::clearData):
12568         * DumpRenderTree/win/DRTDataObject.h: Added.
12569         (DRTDataObject):
12570         * DumpRenderTree/win/DRTDropSource.cpp: Added.
12571         (DRTDropSource::DRTDropSource):
12572         (DRTDropSource::~DRTDropSource):
12573         (DRTDropSource::QueryInterface):
12574         (DRTDropSource::AddRef):
12575         (DRTDropSource::Release):
12576         (DRTDropSource::createInstance):
12577         (DRTDropSource::QueryContinueDrag):
12578         (DRTDropSource::GiveFeedback):
12579         * DumpRenderTree/win/DRTDropSource.h: Added.
12580         (DRTDropSource):
12581         * DumpRenderTree/win/DumpRenderTree.vcproj:
12582         * DumpRenderTree/win/EventSender.cpp:
12583         (beginDragWithFilesCallback):
12584
12585 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
12586
12587         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
12588         https://bugs.webkit.org/show_bug.cgi?id=58593
12589
12590         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
12591         to WebKitTestRunner's LayoutTestController. The flag is modified via the
12592         public C API of the WebProcess.
12593
12594         Reviewed by Darin Adler.
12595
12596         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
12597         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
12598         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
12599         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
12600         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
12601
12602 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
12603
12604         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
12605         https://bugs.webkit.org/show_bug.cgi?id=87848
12606
12607         Reviewed by Csaba Osztrogonác.
12608
12609         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
12610         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
12611         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
12612
12613         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
12614         (DumpRenderTreeChrome::extraViews):
12615         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
12616         (DumpRenderTreeChrome):
12617
12618 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
12619
12620         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
12621         https://bugs.webkit.org/show_bug.cgi?id=87833
12622
12623         Reviewed by Tor Arne Vestbø.
12624
12625         Print "postProgressFinishedNotification" message if frame load finished
12626         to unskip http/tests/loading/progress-finished-callback.html.
12627
12628         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
12629         (DumpRenderTreeChrome::onFrameLoadFinished):
12630
12631 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
12632
12633         [EFL][WK2] Fix WebKit2-EFL build
12634         https://bugs.webkit.org/show_bug.cgi?id=83693
12635
12636         Reviewed by Carlos Garcia Campos.
12637
12638         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
12639
12640 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
12641
12642         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
12643         (They only used to check for Skipped in platform/qt-5.0-wk1)
12644         https://bugs.webkit.org/show_bug.cgi?id=87376
12645
12646         Reviewed by Csaba Osztrogonác.
12647
12648         * Scripts/old-run-webkit-tests:
12649         (buildPlatformResultHierarchy):
12650         * Scripts/webkitpy/layout_tests/port/qt.py:
12651         (QtPort.baseline_search_path):
12652
12653 2012-05-29  Ojan Vafai  <ojan@chromium.org>
12654
12655         Add a linter error for pngs that lack an embedded checksum
12656         https://bugs.webkit.org/show_bug.cgi?id=87793
12657
12658         Reviewed by Dirk Pranke.
12659
12660         * Scripts/read-checksum-from-png:
12661         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
12662         (read_checksum):
12663         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
12664         (ReadChecksumFromPngTest):
12665         (ReadChecksumFromPngTest.test_read_checksum):
12666         * Scripts/webkitpy/layout_tests/port/base.py:
12667         * Scripts/webkitpy/style/checkers/png.py:
12668         (PNGChecker.check):
12669         * Scripts/webkitpy/style/checkers/png_unittest.py:
12670         (PNGCheckerTest.test_check):
12671
12672 2012-05-29  Stephanie Lewis  <slewis@apple.com>
12673
12674         https://bugs.webkit.org/show_bug.cgi?id=87720
12675         WebProcess is often killed due to being unresponsive on the bots
12676
12677         Reviewed by Alexey Proskuryakov.
12678
12679         Blind attempt to improve flakiness on the bots by reducing the number
12680         of crashes due to an unresponsive process.  This helped on my personal machine
12681         under stress conditions.  I don't have enough cores to hit the problem
12682         under normal conditions.
12683
12684         * WebKitTestRunner/TestController.cpp:
12685         (WTR):
12686
12687 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
12688
12689         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
12690         https://bugs.webkit.org/show_bug.cgi?id=87779
12691
12692         Reviewed by Eric Seidel.
12693
12694         Update output to match the names in scm.py as per
12695         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
12696
12697         * Scripts/webkitpy/tool/commands/rebaseline.py:
12698         (RebaselineTest.execute):
12699         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
12700         (test_rebaseline_test_and_print_scm_changes):
12701         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
12702         (GardeningServerTest.test_rebaselineall):
12703
12704 2012-05-29  Stephanie Lewis  <slewis@apple.com>
12705
12706         https://bugs.webkit.org/show_bug.cgi?id=87711
12707
12708         Reviewed by Jessie Berlin.
12709
12710         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
12711         are better maintained.
12712
12713         * BuildSlaveSupport/build.webkit.org-config/config.json:
12714
12715 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
12716
12717         webkit-patch optimize-baselines should add/delete files in batches from the vcs
12718         https://bugs.webkit.org/show_bug.cgi?id=87538
12719
12720         Reviewed by Ojan Vafai.
12721
12722         Invoking git and svn on one file at a time is kinda slow. We
12723         should batch the add and rm operations together.
12724
12725         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
12726         (BaselineOptimizer._move_baselines):
12727
12728 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
12729
12730         garden-o-matic should rebaseline baselines in parallel
12731         https://bugs.webkit.org/show_bug.cgi?id=87451
12732
12733         Reviewed by Ojan Vafai.
12734
12735         This modifies garden-o-matic so that we will fetch all
12736         of the baselines in parallel from the bots, and then
12737         optimize the baselines serially (since that should be fairly
12738         quick and we get into trouble if we optimize in parallel due
12739         to concurrent access to the source control system).
12740
12741         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
12742         so that the files that need to be modified in the SCM are returned to
12743         garden-o-matic rather than actually added or removed. This is done so that
12744         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
12745         concurrently). In order to safely return the files (as a JSON dict) I
12746         needed to shift all of the logging in rebaseline-test to use the logging
12747         module (and hence log to stderr).
12748
12749         I also had to stub out a line in chromium.py that would get confused if
12750         the skia overrides file didn't exist in a mock checkout.
12751
12752         * Scripts/webkitpy/common/system/executive.py:
12753         (Executive.popen):
12754         (Executive):
12755         (Executive.run_in_parallel):
12756         (_run_command_thunk):
12757         * Scripts/webkitpy/common/system/executive_mock.py:
12758         (MockExecutive.run_in_parallel):
12759         * Scripts/webkitpy/common/system/executive_unittest.py:
12760         (ExecutiveTest.test_run_in_parallel):
12761         * Scripts/webkitpy/layout_tests/port/chromium.py:
12762         (ChromiumPort._expectations_file_contents):
12763         * Scripts/webkitpy/tool/commands/rebaseline.py:
12764         (AbstractRebaseliningCommand.__init__):
12765         (RebaselineTest.__init__):
12766         (RebaselineTest._copy_existing_baseline):
12767         (RebaselineTest._save_baseline):
12768         (RebaselineTest):
12769         (RebaselineTest._add_to_scm):
12770         (RebaselineTest._rebaseline_test):
12771         (RebaselineTest.execute):
12772         (RebaselineExpectations._rebaseline_port):
12773         (RebaselineExpectations.execute):
12774         (Rebaseline._builder_to_pull_from):
12775         (Rebaseline.execute):
12776         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
12777         (test_rebaseline_updates_expectations_file):
12778         (test_rebaseline_test):
12779         (test_rebaseline_test_and_print_scm_changes):
12780         (test_rebaseline_and_copy_test):
12781         (test_rebaseline_and_copy_test_no_existing_result):
12782         (test_rebaseline_and_copy_test_with_lion_result):
12783         (test_rebaseline_and_copy_no_overwrite_test):
12784         (test_rebaseline_expectations):
12785         * Scripts/webkitpy/tool/servers/gardeningserver.py:
12786         (GardeningHTTPRequestHandler._rebaseline_commands):
12787         (GardeningHTTPRequestHandler):
12788         (GardeningHTTPRequestHandler._files_to_add):
12789         (GardeningHTTPRequestHandler._optimize_baselines):
12790         (GardeningHTTPRequestHandler.rebaselineall):
12791         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
12792         (GardeningServerTest._post_to_path):
12793         (GardeningServerTest.test_rebaselineall):
12794         (GardeningServerTest.test_rebaselineall.run_command):
12795
12796 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
12797
12798         Fix the type of dispatch_time() offset
12799
12800         Rubber-stamped by Joseph Pecoraro.
12801
12802         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
12803
12804         * DumpRenderTree/mac/FrameLoadDelegate.mm:
12805         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
12806
12807 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
12808
12809         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
12810
12811         [BlackBerry] OpenGL content is not rendered on simulator
12812         https://bugs.webkit.org/show_bug.cgi?id=87721
12813
12814         Reviewed by George Staikos.
12815
12816         Fixed by enabling GLES2 support in simulator builds.
12817
12818         To experiment with building without OpenGL support, you can set the
12819         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
12820
12821         PR #150695
12822
12823         * Scripts/webkitdirs.pm:
12824         (blackberryCMakeArguments):
12825
12826 2012-05-29  David Barr  <davidbarr@chromium.org>
12827
12828         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
12829         https://bugs.webkit.org/show_bug.cgi?id=87685
12830
12831         Reviewed by Eric Seidel.
12832
12833         Add a configuration option for CSS image-resolution support, disabling it by default.
12834
12835         * Scripts/webkitperl/FeatureList.pm:
12836         * qmake/mkspecs/features/features.pri:
12837
12838 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
12839
12840         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
12841
12842         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
12843             valid for C++/ObjC++ but not for C [enabled by default]"
12844
12845         Reviewed by Simon Hausmann.
12846
12847         * qmake/mkspecs/features/unix/default_post.prf:
12848
12849 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
12850
12851         [Qt] Sync up favicon-implementation with WebView url changes in r118158
12852
12853         https://bugs.webkit.org/show_bug.cgi?id=87133
12854
12855         We now base64-encode the page url in the image-provider url, so that any
12856         normalization done by QUrl will not mess up the page-url. The logic of
12857         creating and parsing the provider-url has been moved into the image
12858         provider, to keep it in one place.
12859
12860         We were also releasing icons (even ones we hadn't retained), which we can't
12861         do since we don't know when the icon url is no longer in use.
12862
12863         Reviewed-by Simon Hausmann.
12864
12865         * MiniBrowser/qt/icons/favicon.png:
12866         * MiniBrowser/qt/qml/BrowserWindow.qml:
12867
12868 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
12869
12870         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
12871         https://bugs.webkit.org/show_bug.cgi?id=87654
12872
12873         Reviewed by Csaba Osztrogonác.
12874
12875         Event sender provides strings for all the key events.
12876         Also KeyEventInfo constructor parameters order was changed to simplify the case when
12877         a key event has empty string.
12878
12879         * DumpRenderTree/efl/EventSender.cpp:
12880         (KeyEventInfo::KeyEventInfo):
12881         (keyPadNameFromJSValue):
12882         (keyNameFromJSValue):
12883
12884 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
12885
12886         [Qt] Cancel potential url-edit when going back/forward
12887
12888         Reviewed by Kenneth Rohde Christiansen.
12889
12890         * MiniBrowser/qt/qml/BrowserWindow.qml:
12891
12892 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
12893
12894         [EFL] Compilation warning in DumpRenderTreeView.cpp
12895         https://bugs.webkit.org/show_bug.cgi?id=87636
12896
12897         Reviewed by Filip Pizlo.
12898
12899         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
12900         specifier in printf. Also fix the return type for
12901         onExceededApplicationCacheQuota callback.
12902
12903         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
12904         (onExceededApplicationCacheQuota):
12905
12906 2012-05-29  Hironori Bono  <hbono@chromium.org>
12907
12908         Adding Hironori Bono to committers.py.
12909         https://bugs.webkit.org/show_bug.cgi?id=87697
12910
12911         * Scripts/webkitpy/common/config/committers.py:
12912
12913 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
12914
12915         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
12916         https://bugs.webkit.org/show_bug.cgi?id=80135
12917
12918         Reviewed by Rob Buis.
12919
12920         Implemented interface function didReceiveAuthenticationChallenge in class
12921         DumpRenderTree.
12922
12923         Resubmit the patch reverted by r115104 after the digest infinite loop
12924         issue for BlackBerry porting get identified and fixed.
12925
12926         Internally reviewed by Joe Mason <jmason@rim.com>
12927
12928         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
12929         (drtCredentialDescription):
12930         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
12931         (WebKit):
12932         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
12933         (WebCore):
12934         (DumpRenderTree):
12935
12936 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
12937
12938         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
12939         https://bugs.webkit.org/show_bug.cgi?id=42328
12940
12941         Reviewed by Eric Seidel.
12942
12943         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
12944         move to windows.internals.settings.
12945
12946         * DumpRenderTree/LayoutTestController.cpp:
12947         (LayoutTestController::staticFunctions):
12948         * DumpRenderTree/LayoutTestController.h:
12949         (LayoutTestController):
12950         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
12951         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
12952         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
12953         (DRTDevToolsAgent):
12954         * DumpRenderTree/chromium/LayoutTestController.cpp:
12955         (LayoutTestController::LayoutTestController):
12956         * DumpRenderTree/chromium/LayoutTestController.h:
12957         (LayoutTestController):
12958         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
12959         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
12960         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
12961         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
12962         * DumpRenderTree/mac/DumpRenderTree.mm:
12963         (resetWebViewToConsistentStateBeforeTesting):
12964         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
12965         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
12966         * DumpRenderTree/qt/LayoutTestControllerQt.h:
12967         (LayoutTestController):
12968         * DumpRenderTree/win/DumpRenderTree.cpp:
12969         (resetWebViewToConsistentStateBeforeTesting):
12970         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
12971         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
12972         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
12973         (LayoutTestController):
12974
12975 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
12976
12977         Move allowRoundingHacks to Internals interface
12978         https://bugs.webkit.org/show_bug.cgi?id=87328
12979
12980         Reviewed by Hajime Morita.
12981
12982         Remove allowRoundingHacks functions, because it is able to work in the
12983         cross-port way through the Internals interface.
12984
12985         * DumpRenderTree/LayoutTestController.cpp:
12986         (LayoutTestController::staticFunctions):
12987         * DumpRenderTree/LayoutTestController.h:
12988         (LayoutTestController):
12989         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
12990         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
12991         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
12992         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
12993         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
12994         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
12995
12996 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
12997
12998         Fix mac build with older XCode by defining NSEC_PER_MSEC.
12999         https://bugs.webkit.org/show_bug.cgi?id=87616
13000
13001         Reviewed by Hajime Morita.
13002
13003         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
13004         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
13005         Patch just adds a #ifndef / #define check.
13006
13007         * DumpRenderTree/mac/FrameLoadDelegate.mm:
13008         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
13009
13010 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
13011
13012         [EFL] Enable blob support for the EFL port
13013         https://bugs.webkit.org/show_bug.cgi?id=85363
13014
13015         Reviewed by Hajime Morita.
13016
13017         Enable Blob support by default for the EFL port.
13018
13019         * Scripts/webkitperl/FeatureList.pm:
13020
13021 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
13022
13023         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
13024         https://bugs.webkit.org/show_bug.cgi?id=87582
13025
13026         Reviewed by Darin Adler.
13027
13028         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
13029         possible to test pages in a similar way as they are loaded in Browsers.
13030
13031         * DumpRenderTree/LayoutTestController.cpp:
13032         (LayoutTestController::LayoutTestController):
13033         (setUseDeferredFrameLoadingCallback):
13034         (LayoutTestController::staticFunctions):
13035         * DumpRenderTree/LayoutTestController.h:
13036         (LayoutTestController::useDeferredFrameLoading):
13037         (LayoutTestController::setUseDeferredFrameLoading):
13038         (LayoutTestController):
13039         * DumpRenderTree/mac/FrameLoadDelegate.mm:
13040         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
13041
13042 2012-05-27  David Barton  <dbarton@mathscribe.com>
13043
13044         [watchlist] Improve MathML rule
13045         https://bugs.webkit.org/show_bug.cgi?id=87592
13046
13047         Reviewed by Adam Barth.
13048
13049         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
13050         but if this changed the rule would be slow. We protect against this, clarify the rule,
13051         and make it more similar to existing rules.
13052
13053         * Scripts/webkitpy/common/config/watchlist:
13054
13055 2012-05-27  David Barton  <dbarton@mathscribe.com>
13056
13057         [watchlist] Add myself & a rule for MathML
13058         https://bugs.webkit.org/show_bug.cgi?id=87586
13059
13060         Reviewed by Adam Barth.
13061
13062         * Scripts/webkitpy/common/config/watchlist:
13063
13064 2012-05-26  David Kilzer  <ddkilzer@apple.com>
13065
13066         Use xcrun to find path to nm for Mac port
13067         <http://webkit.org/b/87588>
13068
13069         Reviewed by Dan Bernstein.
13070
13071         * Scripts/webkitpy/layout_tests/port/mac.py:
13072         (MacPort.nm_command): Add. Tries to find a path for the nm
13073         command using xcrun.  Falls back to returning 'nm'.
13074         * Scripts/webkitpy/layout_tests/port/webkit.py:
13075         (WebKitPort.nm_command): Add. Returns 'nm'.
13076         (WebKitPort._webcore_symbols_string): Call self.nm_command().
13077
13078 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
13079
13080         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
13081
13082         Reviewed by Eric Seidel.
13083
13084         * DumpRenderTree/win/DumpRenderTree.vcproj:
13085         * DumpRenderTree/win/FrameLoadDelegate.cpp:
13086         (FrameLoadDelegate::FrameLoadDelegate):
13087         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
13088         * DumpRenderTree/win/FrameLoadDelegate.h:
13089         (FrameLoadDelegate):
13090         * DumpRenderTree/win/TextInputController.cpp: Added.
13091         (setMarkedTextCallback):
13092         (hasMarkedTextCallback):
13093         (unmarkTextCallback):
13094         (markedRangeCallback):
13095         (insertTextCallback):
13096         (firstRectForCharacterRangeCallback):
13097         (selectedRangeCallback):
13098         (TextInputController::makeWindowObject):
13099         (TextInputController::getJSClass):
13100         (TextInputController::staticValues):
13101         (TextInputController::staticFunctions):
13102         * DumpRenderTree/win/TextInputController.h: Added.
13103         (TextInputController):
13104         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
13105         (TextInputController::setMarkedText):
13106         (TextInputController::hasMarkedText):
13107         (TextInputController::unmarkText):
13108         (TextInputController::markedRange):
13109         (TextInputController::insertText):
13110         (TextInputController::firstRectForCharacterRange):
13111         (TextInputController::selectedRange):
13112
13113 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
13114
13115         webkitpy: change scm.add(), scm.delete() to accept multiple paths
13116         https://bugs.webkit.org/show_bug.cgi?id=87528
13117
13118         Reviewed by Ojan Vafai.
13119
13120         launching git or svn for individual files can be slow; this
13121         change will hand multiple paths at once to git and svn so they
13122         can be added in a batch.
13123
13124         * Scripts/webkitpy/common/checkout/scm/git.py:
13125         (Git.add_list):
13126         (Git.delete_list):
13127         * Scripts/webkitpy/common/checkout/scm/scm.py:
13128         (SCM.add):
13129         (SCM):
13130         (SCM.add_list):
13131         (SCM.delete):
13132         (SCM.delete_list):
13133         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
13134         (MockSCM.add):
13135         (MockSCM):
13136         (MockSCM.add_list):
13137         (MockSCM.delete):
13138         (MockSCM.delete_list):
13139         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
13140         (_shared_test_exists):
13141         (_shared_test_added_files):
13142         (_test_delete_list):
13143         * Scripts/webkitpy/common/checkout/scm/svn.py:
13144         (SVN.add_list):
13145         (SVN.delete_list):
13146
13147 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
13148
13149         [NRWT] Add unit testing for perf tests on locked shards
13150         https://bugs.webkit.org/show_bug.cgi?id=87489
13151
13152         Reviewed by Dirk Pranke.
13153
13154         Adding utests that makes sure that perf tests are running in locked
13155         shards and by passing --no-http won't break NRWT (r118421).
13156
13157         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
13158         (ShardingTests):
13159         (ShardingTests.test_shard_by_dir):
13160         (ShardingTests.test_shard_every_file):
13161         (ShardingTests.test_shard_in_two):
13162         (ShardingTests.test_multiple_locked_shards):
13163         (LockCheckingManager):
13164         (LockCheckingManager.__init__):
13165         (LockCheckingManager.handle_finished_list):
13166         (ManagerTest.test_http_locking):
13167         (ManagerTest):
13168         (ManagerTest.test_perf_locking):
13169         * Scripts/webkitpy/layout_tests/port/test.py:
13170
13171 2012-05-25  Jessie Berlin  <jberlin@apple.com>
13172
13173         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
13174         https://bugs.webkit.org/show_bug.cgi?id=87511
13175
13176         Reviewed by Alexey Proskuryakov.
13177
13178         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
13179
13180         * DumpRenderTree/win/EventSender.cpp:
13181         (keyDownCallback):
13182
13183 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
13184
13185         Adding Ken Buchanan to committers.py
13186         https://bugs.webkit.org/show_bug.cgi?id=87443
13187
13188         Unreviewed.
13189
13190         Adding self to committers.py as a Committer.
13191
13192         * Scripts/webkitpy/common/config/committers.py:
13193
13194 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
13195
13196         [Qt] Buildfix for newer Qt5
13197         https://bugs.webkit.org/show_bug.cgi?id=87257
13198
13199         Reviewed by Simon Hausmann.
13200
13201         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
13202
13203 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
13204
13205         [Qt] Unreviewed fix after r118484.
13206
13207         Enable CSS_EXCLUSIONS and CSS_REGIONS.
13208         They were enabled uncoditinally before r118484.
13209
13210         * qmake/mkspecs/features/features.pri:
13211
13212 2012-05-24  Tim Horton  <timothy_horton@apple.com>
13213
13214         Add feature defines for web-facing parts of CSS Regions and Exclusions
13215         https://bugs.webkit.org/show_bug.cgi?id=87442
13216         <rdar://problem/10887709>
13217
13218         Reviewed by Dan Bernstein.
13219
13220         * Scripts/webkitperl/FeatureList.pm:
13221
13222 2012-05-24  Hironori Bono  <hbono@chromium.org>
13223
13224         Enable grammar checking on Chromium when we paste text (Take 2)
13225         https://bugs.webkit.org/show_bug.cgi?id=74393
13226
13227         Reviewed by Ryosuke Niwa.
13228
13229         This change enables grammar checking on Chromium and implements a mock grammar
13230         checker to fix a failing test.
13231
13232         * DumpRenderTree/DumpRenderTree.gypi:
13233         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
13234         (MockGrammarCheck::checkGrammarOfString):
13235         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
13236         (WebKit):
13237         (MockGrammarCheck):
13238         * DumpRenderTree/chromium/WebViewHost.cpp:
13239         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
13240
13241 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
13242
13243         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
13244         https://bugs.webkit.org/show_bug.cgi?id=86842
13245
13246         Reviewed by Antonio Gomes.
13247
13248         Add support for overriding the application cache support preference
13249         through EFL's LayoutTestController.
13250
13251         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
13252         (LayoutTestController::overridePreference):
13253
13254 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
13255
13256         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
13257         https://bugs.webkit.org/show_bug.cgi?id=85209
13258
13259         Reviewed by Antonio Gomes.
13260
13261         Set developer extras setting called twice on the test startup. Hence, removing
13262         an unnecessary extra call which set wrong value.
13263
13264         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
13265         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
13266
13267 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
13268
13269         garden-o-matic should not fetch from debug bots if it also knows about the release bots
13270         https://bugs.webkit.org/show_bug.cgi?id=86916
13271
13272         Reviewed by Adam Barth.
13273
13274         Note that if release and debug are failing differently, debug
13275         will be ignored ...
13276
13277         Note: also change the use of a fake port name from
13278         "mock-port-name" to "test-mac-leopard" to make it more friendly
13279         to the port factory ("mock" actually is a real port).
13280
13281         * Scripts/webkitpy/tool/servers/gardeningserver.py:
13282         (GardeningHTTPRequestHandler._builders_to_fetch_from):
13283         (GardeningHTTPRequestHandler.rebaselineall):
13284         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
13285         (GardeningServerTest.test_rebaselineall):
13286         (GardeningServerTest.test_rebaseline_new_port):
13287
13288 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
13289
13290         nrwt: fix baseline search path for official chrome builders
13291         https://bugs.webkit.org/show_bug.cgi?id=87432
13292
13293         Reviewed by Tony Chang.
13294
13295         The official chrome builders need to use the win7 and SL
13296         baseline paths, not the XP and Leopard paths. Linux is correct.
13297
13298         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
13299         (GoogleChromeMacPort.determine_full_port_name):
13300         (GoogleChromeWinPort.determine_full_port_name):
13301         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
13302         (TestGoogleChromePort._verify_baseline_search_path_startswith):
13303         (TestGoogleChromePort.test_get_google_chrome_port):
13304
13305 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
13306
13307         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
13308         https://bugs.webkit.org/show_bug.cgi?id=86800
13309
13310         Reviewed by Dirk Pranke.
13311
13312         Don't launch a HTTP server with lock based only on the existence of
13313         locked shards since we now run perf on locked shards too.
13314
13315         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13316         (Manager._run_tests):
13317
13318 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
13319
13320         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
13321         https://bugs.webkit.org/show_bug.cgi?id=87128
13322
13323         Reviewed by Dirk Pranke.
13324
13325         * Scripts/webkitpy/layout_tests/port/base.py:
13326         (Port.driver_name):
13327         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
13328         (ChromiumLinuxPort._path_to_driver):
13329         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
13330         (ChromiumPortTest.test_driver_name_option):
13331         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
13332         (ChromiumWinPort._path_to_driver):
13333         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
13334         (parse_args):
13335
13336 2012-05-24  John Mellor  <johnme@chromium.org>
13337
13338         Font Boosting: Add compile flag and runtime setting
13339         https://bugs.webkit.org/show_bug.cgi?id=87394
13340
13341         Reviewed by Adam Barth.
13342
13343         Add ENABLE_FONT_BOOSTING.
13344
13345         * Scripts/webkitperl/FeatureList.pm:
13346         * qmake/mkspecs/features/features.pri:
13347
13348 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
13349
13350         [EFL] [DRT] keyboard-related tests do not pass
13351         https://bugs.webkit.org/show_bug.cgi?id=85369
13352
13353         Reviewed by Gustavo Noronha Silva.
13354
13355         Add SHIFT modifier for capital letters as VK_
13356         codes do not distinguish between lows and caps and also to be consistent
13357         with other ports which send caps as lowercase letters with the shift key down.
13358
13359         * DumpRenderTree/efl/EventSender.cpp:
13360         (keyNameFromJSValue):
13361
13362 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
13363
13364         [WK2] Let the client give local files universal access on a case by case basis
13365         https://bugs.webkit.org/show_bug.cgi?id=87174
13366         <rdar://problem/11024330>
13367
13368         Reviewed by Maciej Stachowiak.
13369
13370         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
13371         Added initialization of a new structure member to prevent build failure.
13372
13373 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
13374
13375         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
13376         https://bugs.webkit.org/show_bug.cgi?id=87203
13377
13378         Reviewed by Andreas Kling.
13379
13380         Add the required changes to make
13381         fast/events/keydown-leftright-keys.html pass after r118001.
13382
13383         * DumpRenderTree/efl/EventSender.cpp:
13384         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
13385         into the proper X11 keysym definitions.
13386
13387 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
13388
13389         Unreviewed, rolling out r118352.
13390         http://trac.webkit.org/changeset/118352
13391         https://bugs.webkit.org/show_bug.cgi?id=87390
13392
13393         Caused 6 editing/spelling tests crash/fail on chromium in
13394         debug. (Requested by vsevik on #webkit).
13395
13396         * DumpRenderTree/DumpRenderTree.gypi:
13397         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
13398         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
13399         * DumpRenderTree/chromium/WebViewHost.cpp:
13400         (WebViewHost::finishLastTextCheck):
13401
13402 2012-05-24  Peter Beverloo  <peter@chromium.org>
13403
13404         Add John Mellor as a contributor
13405         https://bugs.webkit.org/show_bug.cgi?id=87389
13406
13407         Reviewed by Kenneth Rohde Christiansen.
13408
13409         John will be working on Font Boosting and is very involved with various
13410         web-facing subjects of Chrome for Android, such as viewport.
13411
13412         * Scripts/webkitpy/common/config/committers.py:
13413
13414 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
13415
13416         [EFL][DRT] LayoutTestController's setCacheModel() implementation
13417         https://bugs.webkit.org/show_bug.cgi?id=86840
13418
13419         Reviewed by Csaba Osztrogonác.
13420
13421         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
13422         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
13423         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
13424         (LayoutTestController::setCacheModel): Implementation added.
13425
13426 2012-05-24  Hironori Bono  <hbono@chromium.org>
13427
13428         Enable grammar checking on Chromium when we paste text.
13429         https://bugs.webkit.org/show_bug.cgi?id=74393
13430
13431         Reviewed by Hajime Morita.
13432
13433         This change enables grammar checking on Chromium and implements a mock grammar
13434         checker to fix a failing test.
13435
13436         * DumpRenderTree/DumpRenderTree.gypi:
13437         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
13438         (MockGrammarCheck::checkGrammarOfString):
13439         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
13440         (WebKit):
13441         (MockGrammarCheck):
13442         * DumpRenderTree/chromium/WebViewHost.cpp:
13443         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
13444
13445 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
13446
13447         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
13448
13449         * qmake/mkspecs/features/features.pri:
13450
13451 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
13452
13453         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
13454         https://bugs.webkit.org/show_bug.cgi?id=86867
13455
13456         Reviewed by Adam Barth.
13457
13458         Add implementation for sendWebIntentResponse() in EFL's
13459         LayoutTestController and add empty implementation for other ports.
13460
13461         * DumpRenderTree/LayoutTestController.cpp:
13462         (sendWebIntentResponseCallback):
13463         (LayoutTestController::staticFunctions):
13464         * DumpRenderTree/LayoutTestController.h:
13465         (LayoutTestController):
13466         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
13467         (LayoutTestController::sendWebIntentResponse):
13468         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
13469         (DumpRenderTreeChrome::currentIntentRequest):
13470         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
13471         (DumpRenderTreeChrome::onFrameIntentNew):
13472         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
13473         (DumpRenderTreeChrome):
13474         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
13475         (LayoutTestController::sendWebIntentResponse):
13476         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
13477         (LayoutTestController::sendWebIntentResponse):
13478         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
13479         (LayoutTestController::sendWebIntentResponse):
13480         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
13481         (LayoutTestController::sendWebIntentResponse):
13482         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
13483         (LayoutTestController::sendWebIntentResponse):
13484
13485 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
13486
13487         [EFL] The EFL port has no support for title directionality
13488         https://bugs.webkit.org/show_bug.cgi?id=86462
13489
13490         Reviewed by Gustavo Noronha Silva.
13491
13492         Update "title,changed" signal handlers in DRT and EWebLauncher to
13493         reflect the change from const char* to Ewk_Text_With_Direction* type
13494         for the title.
13495
13496         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
13497         (DumpRenderTreeChrome::onTitleChanged):
13498         * EWebLauncher/main.c:
13499         (title_set):
13500         (on_title_changed):
13501         (on_key_down):
13502
13503 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
13504
13505         Change EFL debug build name with more detail one
13506         https://bugs.webkit.org/show_bug.cgi?id=87254
13507
13508         Reviewed by Ryosuke Niwa.
13509
13510         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
13511         In addition, remove efl-linux-debug triggerable since nobody uses it.
13512
13513         * BuildSlaveSupport/build.webkit.org-config/config.json:
13514
13515 2012-05-23  Kangil Han  <kangil.han@samsung.com>
13516
13517         [EFL][DRT] Fix WebCore library path and rebaseline result
13518         https://bugs.webkit.org/show_bug.cgi?id=86355
13519
13520         Reviewed by Dirk Pranke.
13521
13522         Currently EFL DRT uses wrong WebCore library path when running DRT.
13523         Therefore, this patch adjusted the path correctly.
13524
13525         * Scripts/webkitpy/layout_tests/port/efl.py:
13526         (EflPort._path_to_webcore_library):
13527
13528 2012-05-23  Ojan Vafai  <ojan@chromium.org>
13529
13530         add back the ability to disable flexbox
13531         https://bugs.webkit.org/show_bug.cgi?id=87147
13532
13533         Reviewed by Tony Chang.
13534
13535         * Scripts/webkitperl/FeatureList.pm:
13536
13537 2012-05-23  Tony Chang  <tony@chromium.org>
13538
13539         Remove the Chromium Grid Layout bot from the waterfall
13540         https://bugs.webkit.org/show_bug.cgi?id=87311
13541
13542         Reviewed by Ryosuke Niwa.
13543
13544         I removed the compiler define in r117613, so we don't need a separate
13545         bot to compile/test this code.
13546
13547         * BuildSlaveSupport/build.webkit.org-config/config.json:
13548
13549 2012-05-23  Ian Vollick  <vollick@chromium.org>
13550
13551         Add vollick to list of contributors.
13552         https://bugs.webkit.org/show_bug.cgi?id=87305
13553
13554         Reviewed by Adam Barth.
13555
13556         * Scripts/webkitpy/common/config/committers.py:
13557
13558 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
13559
13560         [Chromium-Android] Fix chromium_android_unittest
13561         https://bugs.webkit.org/show_bug.cgi?id=87196
13562
13563         Reviewed by Tony Chang.
13564
13565         Update unit tests after ChromiumAndroidPort supported apk based
13566         DumpRenderTree.
13567
13568         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
13569         (ChromiumAndroidPortTest):
13570         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
13571         (ChromiumAndroidPortTest.test_get_last_stacktrace):
13572         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
13573         (ChromiumAndroidDriverTest):
13574         (ChromiumAndroidDriverTest.setUp):
13575         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
13576         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
13577
13578 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
13579
13580         [watchlist] Add myself and create a watch rule to catch Attribute related patches
13581         https://bugs.webkit.org/show_bug.cgi?id=87303
13582
13583         Reviewed by Alexis Menard.
13584
13585         * Scripts/webkitpy/common/config/watchlist:
13586
13587 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
13588
13589         garden-o-matic should not fetch from debug bots if it also knows about the release bots
13590         https://bugs.webkit.org/show_bug.cgi?id=86916
13591
13592         Reviewed by Adam Barth.
13593
13594         This change pushes all of the logic for rebaselining a cluster
13595         of failures (a list of tests failing a list of suffixes on a
13596         list of bots) onto the server, so there is a single call from
13597         the web page; we will then be able to optimize the performance
13598         of the rebaselining better.
13599
13600         Also remove the 'optimizebaseline' entry point on garden-o-matic
13601         (and the client-side call) since we don't need it any more.
13602
13603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
13604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
13605         * Scripts/webkitpy/tool/servers/gardeningserver.py:
13606         (GardeningHTTPRequestHandler.rebaselineall):
13607         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
13608
13609 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
13610
13611         Mac DRT should be able to load external URLs for replay performance tests
13612         https://bugs.webkit.org/show_bug.cgi?id=86191
13613
13614         Reviewed by Alexey Proskuryakov.
13615
13616         Let external URL requests go through if the test file is not a local file or hosted at localhost.
13617         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
13618         "DumpRenderTree http://localhost:8000/".
13619
13620         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
13621         (isLocalhost):
13622         (hostIsUsedBySomeTestsToGenerateError):
13623         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
13624
13625 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
13626
13627         [wx] In wxWebKit release builds on MSW, keep release settings but also build the
13628         debug symbols for easier debugging.
13629         https://bugs.webkit.org/show_bug.cgi?id=87151
13630
13631         Reviewed by Kevin Ollivier.
13632
13633         * waf/build/settings.py:
13634         (common_configure):
13635
13636 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
13637
13638         Unreviewed. Move myself to reviewers.
13639
13640         * Scripts/webkitpy/common/config/committers.py:
13641
13642 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
13643
13644         [EFL] Implements the registerProtocolHandler method and option.
13645         https://bugs.webkit.org/show_bug.cgi?id=73638
13646
13647         Reviewed by Andreas Kling.
13648
13649         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
13650
13651 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
13652
13653         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
13654         https://bugs.webkit.org/show_bug.cgi?id=87221
13655
13656         Reviewed by Martin Robinson.
13657
13658         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
13659         rightShift key names into proper GDK key symbols.
13660
13661         * DumpRenderTree/gtk/EventSender.cpp:
13662         (createKeyPressEvent):
13663
13664 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
13665
13666         [Qt] Make the web view's url property follow the active url
13667
13668         https://bugs.webkit.org/show_bug.cgi?id=77554
13669
13670         Update  the location bar in the minibrowser to behave
13671         a bit more like normal browsers in terms of when the url will change
13672         and how active focus is handled.
13673
13674         Reviewed by Simon Hausmann.
13675
13676         * MiniBrowser/qt/qml/BrowserWindow.qml:
13677
13678 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
13679
13680         [Qt] Remove references to $$QT_SOURCE_TREE
13681
13682         With a modularized Qt, it's ambigious. What we really want is qtbase,
13683         which qtcore is a proxy for (we assume it will always live in qtbase).
13684
13685         Reviewed by Tor Arne Vestbø.
13686
13687         * DumpRenderTree/qt/DumpRenderTree.pro:
13688
13689 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
13690
13691         [Qt] Fix qmake conditional for c++-11 compat warnings
13692
13693         Reviewed by Tor Arne Vestbø.
13694
13695         * qmake/mkspecs/features/unix/default_post.prf:
13696
13697 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
13698
13699         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
13700         https://bugs.webkit.org/show_bug.cgi?id=85956
13701
13702         Reviewed by Gustavo Noronha Silva.
13703
13704         Catch new "load,provisional,failed" signal and print
13705         didFailProvisionalLoadWithError messages when LayoutTestController's
13706         dumpFrameLoadCallbacks() returns true. Also make sure the
13707         didFailLoadWithError message is not printed in case of provisional
13708         load failure.
13709
13710         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
13711         (DumpRenderTreeChrome::createView):
13712         (DumpRenderTreeChrome::onFrameCreated):
13713         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
13714         (DumpRenderTreeChrome::onFrameLoadError):
13715         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
13716         (DumpRenderTreeChrome):
13717
13718 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
13719
13720         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
13721         https://bugs.webkit.org/show_bug.cgi?id=86366
13722
13723         Reviewed by Antonio Gomes.
13724
13725         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
13726
13727         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
13728         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
13729
13730 2012-05-22  Darin Adler  <darin@apple.com>
13731
13732         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
13733         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
13734
13735 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
13736
13737         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
13738         https://bugs.webkit.org/show_bug.cgi?id=86922
13739
13740         Because we have new platformInit() in TestShellAndroid.cpp, and
13741         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
13742         is split into TestShellPosix.cpp and TestShellX11.cpp.
13743
13744         Reviewed by Kent Tamura.
13745
13746         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
13747         * DumpRenderTree/DumpRenderTree.gypi:
13748         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
13749         (platformInit):
13750         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
13751         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
13752         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
13753         (AlarmHandler):
13754         (TestShell::waitTestFinished):
13755         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
13756         (openStartupDialog): from TestShellGtk.cpp
13757         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
13758         (setupFontconfig):
13759         (platformInit):
13760
13761 2012-05-22  Kangil Han  <kangil.han@samsung.com>
13762
13763         [EFL][DRT] Implement touch event
13764         https://bugs.webkit.org/show_bug.cgi?id=86720
13765
13766         Reviewed by Hajime Morita.
13767
13768         Currently EFL DRT doesn't support touch event.
13769         Therefore, this patch enabled it and implemented some eventSender function callbacks.
13770
13771         * DumpRenderTree/efl/EventSender.cpp:
13772         (TouchEventInfo::TouchEventInfo):
13773         (TouchEventInfo):
13774         (touchPointList):
13775         (sendTouchEvent):
13776         (addTouchPointCallback):
13777         (touchStartCallback):
13778         (updateTouchPointCallback):
13779         (touchMoveCallback):
13780         (cancelTouchPointCallback):
13781         (touchCancelCallback):
13782         (releaseTouchPointCallback):
13783         (touchEndCallback):
13784         (clearTouchPointsCallback):
13785         (setTouchModifierCallback):
13786         * Scripts/webkitperl/FeatureList.pm:
13787
13788 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
13789
13790         [Chromium-Android] Fix chromium_android_unittest
13791         https://bugs.webkit.org/show_bug.cgi?id=87196
13792
13793         Not reviewed.
13794         Temporarily disable chromium_android_unittest.
13795
13796         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
13797         (ChromiumAndroidPortTest):
13798         (ChromiumAndroidDriverTest):
13799
13800 2012-05-22  Jessie Berlin  <jberlin@apple.com>
13801
13802         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
13803         https://bugs.webkit.org/show_bug.cgi?id=64313
13804
13805         Reviewed by Jon Honeycutt.
13806
13807         Add it.
13808
13809         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
13810         Make sure to generate the binding.
13811
13812         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
13813         (WTR::LayoutTestController::setDefersLoading):
13814         Call WKBundlePageSetDefersLoading.
13815         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
13816
13817 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
13818
13819         [Chromium-Android] Run DumpRenderTree as an apk (python part)
13820         https://bugs.webkit.org/show_bug.cgi?id=86923
13821
13822         chromium_android.py is modified to support running DumpRenderTree as
13823         an apk, so that we can run the tests (e.g. video) requiring features
13824         implemented in Java on Android.
13825
13826         Reviewed by Adam Barth.
13827
13828         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
13829         (ChromiumAndroidPort.__init__):
13830         (ChromiumAndroidPort.default_child_processes):
13831         (ChromiumAndroidPort.check_wdiff):
13832         (ChromiumAndroidPort.check_build):
13833         (ChromiumAndroidPort.start_helper):
13834         (ChromiumAndroidPort.skipped_layout_tests):
13835         (ChromiumAndroidPort):
13836         (ChromiumAndroidPort._path_to_driver):
13837         (ChromiumAndroidPort._get_crash_log):
13838         (ChromiumAndroidPort._push_executable):
13839         (ChromiumAndroidPort._run_adb_command):
13840         (ChromiumAndroidPort._get_last_stacktrace):
13841         (ChromiumAndroidPort._get_logcat):
13842         (ChromiumAndroidPort._setup_performance):
13843         (ChromiumAndroidDriver):
13844         (ChromiumAndroidDriver.__init__):
13845         (ChromiumAndroidDriver._command_wrapper):
13846         (ChromiumAndroidDriver.cmd_line):
13847         (ChromiumAndroidDriver._file_exists_on_device):
13848         (ChromiumAndroidDriver._deadlock_detector):
13849         (ChromiumAndroidDriver._start):
13850         (ChromiumAndroidDriver.run_test):
13851         (ChromiumAndroidDriver.stop):
13852         (ChromiumAndroidDriver._write_command_and_read_line):
13853         (ChromiumAndroidDriver._output_image):
13854         (ChromiumAndroidDriver._get_stderr):
13855
13856 2012-05-22  Joshua Bell  <jsbell@chromium.org>
13857
13858         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
13859
13860         Unreviewed gardening.
13861
13862         * Scripts/webkitpy/layout_tests/port/base.py:
13863         (Port.driver_name):
13864         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
13865         (ChromiumLinuxPort._path_to_driver):
13866         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
13867         (ChromiumPortTest.test_overrides_and_builder_names):
13868         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
13869         (ChromiumWinPort._path_to_driver):
13870         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
13871         (parse_args):
13872
13873 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
13874
13875         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
13876         https://bugs.webkit.org/show_bug.cgi?id=87176
13877
13878         Reviewed by Tony Chang.
13879
13880         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
13881         * DumpRenderTree/DumpRenderTree.gypi:
13882
13883 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
13884
13885         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
13886         https://bugs.webkit.org/show_bug.cgi?id=87128
13887
13888         Reviewed by Dirk Pranke.
13889
13890         * Scripts/webkitpy/layout_tests/port/base.py:
13891         (Port.driver_name):
13892         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
13893         (ChromiumLinuxPort._path_to_driver):
13894         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
13895         (ChromiumPortTest.test_driver_name_option):
13896         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
13897         (ChromiumWinPort._path_to_driver):
13898         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
13899         (parse_args):
13900
13901 2012-05-22  Jessie Berlin  <jberlin@apple.com>
13902
13903         WTR fix after r118001.
13904
13905         Rubber-stamped by Alexey Proskuryakov.
13906
13907         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
13908
13909         * WebKitTestRunner/mac/EventSenderProxy.mm:
13910         (WTR::EventSenderProxy::keyDown):
13911
13912 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
13913
13914         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
13915         https://bugs.webkit.org/show_bug.cgi?id=86684
13916
13917         Reviewed by Darin Fisher.
13918
13919         * DumpRenderTree/chromium/LayoutTestController.cpp:
13920         (LayoutTestController::numberOfPages):
13921         * DumpRenderTree/chromium/WebViewHost.cpp:
13922         (WebViewHost::printPage):
13923
13924 == Rolled over to ChangeLog-2012-05-22 ==