1 2011-11-26 Pavel Feldman <pfeldman@google.com>
3 Web Inspector: remove disconnectFromBackend from the protocol.
4 https://bugs.webkit.org/show_bug.cgi?id=73127
6 Reviewed by Yury Semikhatsky.
8 * WebCoreSupport/WebInspectorClient.cpp:
9 (WebInspectorClient::inspectorDestroyed):
10 (WebInspectorClient::closeInspectorFrontend):
11 * WebCoreSupport/WebInspectorClient.h:
13 2011-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
15 Unreviewed, rolling out r101193.
16 http://trac.webkit.org/changeset/101193
17 https://bugs.webkit.org/show_bug.cgi?id=73158
19 Breaks Windows and Qt minimal. (Requested by pfeldman on
22 * WebCoreSupport/WebInspectorClient.cpp:
23 (WebInspectorClient::inspectorDestroyed):
24 (WebInspectorFrontendClient::disconnectFromBackend):
25 * WebCoreSupport/WebInspectorClient.h:
27 2011-11-26 Pavel Feldman <pfeldman@google.com>
29 Web Inspector: remove disconnectFromBackend from the protocol.
30 https://bugs.webkit.org/show_bug.cgi?id=73127
32 Reviewed by Yury Semikhatsky.
34 * WebCoreSupport/WebInspectorClient.cpp:
35 (WebInspectorClient::inspectorDestroyed):
36 (WebInspectorClient::closeInspectorFrontend):
37 * WebCoreSupport/WebInspectorClient.h:
39 2011-11-22 Pavel Feldman <pfeldman@google.com>
41 Web Inspector: remove Inspector::bringToFront from the protocol.
42 https://bugs.webkit.org/show_bug.cgi?id=72937
44 Reviewed by Yury Semikhatsky.
46 * WebCoreSupport/WebInspectorClient.cpp:
47 (WebInspectorClient::bringFrontendToFront):
48 * WebCoreSupport/WebInspectorClient.h:
50 2011-11-21 Pavel Feldman <pfeldman@google.com>
52 Not reviewed: an attempt to fix windows build.
55 (WebInspector::isJavaScriptProfilingEnabled):
56 (WebInspector::setJavaScriptProfilingEnabled):
58 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
60 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
61 https://bugs.webkit.org/show_bug.cgi?id=62985
63 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
64 methods for plumbing the menu action handlers through the WebKit and WebCore.
65 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
66 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
67 WebKit/win and WebKit2 to follow.
69 Reviewed by Yury Semikhatsky.
72 (WebInspector::createInstance):
73 (WebInspector::WebInspector):
74 (WebInspector::webViewClosed):
75 (WebInspector::showConsole):
76 (WebInspector::isDebuggingJavaScript):
77 (WebInspector::toggleDebuggingJavaScript):
78 (WebInspector::isProfilingJavaScript):
79 (WebInspector::toggleProfilingJavaScript):
80 (WebInspector::isJavaScriptProfilingEnabled):
81 (WebInspector::setJavaScriptProfilingEnabled):
82 (WebInspector::isTimelineProfilingEnabled):
83 (WebInspector::setTimelineProfilingEnabled):
88 (WebView::initWithFrame):
92 2011-10-17 Antonio Gomes <agomes@rim.com>
94 Pass a Frame* parameter in EditorClient::respondToChangedSelection
95 https://bugs.webkit.org/show_bug.cgi?id=70248
97 Reviewed by Ryosuke Niwa.
99 * WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter.
100 (WebEditorClient::respondToChangedSelection):
101 * WebCoreSupport/WebEditorClient.h:
103 2011-11-15 Jochen Eisinger <jochen@chromium.org>
105 Rename ReferrerPolicy to clarify its meaning
106 https://bugs.webkit.org/show_bug.cgi?id=72420
108 Reviewed by Nate Chapin.
110 * WebCoreSupport/WebContextMenuClient.cpp:
111 (WebContextMenuClient::searchWithGoogle):
113 2011-11-15 Anders Carlsson <andersca@apple.com>
115 HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
116 https://bugs.webkit.org/show_bug.cgi?id=72397
118 Reviewed by Dan Bernstein.
120 * WebCoreSupport/WebChromeClient.cpp:
121 (WebChromeClient::rootViewToScreen):
122 (WebChromeClient::screenToRootView):
123 * WebCoreSupport/WebChromeClient.h:
125 2011-11-14 Anders Carlsson <andersca@apple.com>
127 HostWindow invalidation functions should use root view coordinates
128 https://bugs.webkit.org/show_bug.cgi?id=72338
130 Reviewed by Dan Bernstein.
132 * WebCoreSupport/WebChromeClient.cpp:
133 (WebChromeClient::invalidateRootView):
134 (WebChromeClient::invalidateContentsAndRootView):
135 * WebCoreSupport/WebChromeClient.h:
137 2011-11-07 Adam Barth <abarth@webkit.org>
139 Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
140 https://bugs.webkit.org/show_bug.cgi?id=71755
142 Reviewed by Eric Seidel.
145 (WebView::addOriginAccessWhitelistEntry):
146 (WebView::removeOriginAccessWhitelistEntry):
147 (WebView::resetOriginAccessWhitelists):
149 2011-11-07 Adam Barth <abarth@webkit.org>
151 Move DomainRelaxationForbidden scheme registry to SchemeRegistry
152 https://bugs.webkit.org/show_bug.cgi?id=71750
154 Reviewed by Eric Seidel.
157 (WebView::setDomainRelaxationForbiddenForURLScheme):
159 2011-11-07 Beth Dakin <bdakin@apple.com>
161 https://bugs.webkit.org/show_bug.cgi?id=71490
162 Support uiStateTransitionProgress for scrollbars
164 <rdar://problem/9849612>
166 Reviewed by Sam Weinig.
168 Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.
170 (WebScrollBar::handleMouseEvent):
172 2011-11-02 Darin Adler <darin@apple.com>
174 Change remaining callers of releaseRef to call leakRef
175 https://bugs.webkit.org/show_bug.cgi?id=71422
177 Reviewed by Darin Fisher.
180 (WebCache::statistics):
181 * WebDatabaseManager.cpp:
182 (WebDatabaseManager::origins):
183 (WebDatabaseManager::databasesWithOrigin):
184 * WebHistoryItem.cpp:
185 (WebHistoryItem::redirectURLs):
186 * WebKitClassFactory.cpp:
187 (leakRefFromCreateInstance):
188 (WebKitClassFactory::CreateInstance):
189 * WebScriptWorld.cpp:
190 (WebScriptWorld::standardWorld):
193 2011-11-02 Jon Lee <jonlee@apple.com>
195 Expand DragController to provide more information about the dragging session
196 https://bugs.webkit.org/show_bug.cgi?id=71324
197 <rdar://problem/10379175>
199 Reviewed by Darin Adler.
202 (WebView::DragEnter): Minor refactoring because operation is stored in
203 new DragSession struct.
204 (WebView::DragOver): Ditto.
206 2011-11-02 Tom Sepez <tsepez@chromium.org>
209 https://bugs.webkit.org/show_bug.cgi?id=70973
211 Reviewed by Adam Barth.
213 * WebCoreSupport/WebFrameLoaderClient.cpp:
214 (WebFrameLoaderClient::didDetectXSS):
215 * WebCoreSupport/WebFrameLoaderClient.h:
217 2011-10-28 Jochen Eisinger <jochen@chromium.org>
219 Rename a number of methods mentioning JavaScript to just Script instead
220 https://bugs.webkit.org/show_bug.cgi?id=71105
222 Reviewed by Adam Barth.
225 (WebFrame::dispatchDidClearWindowObjectInWorld):
227 (WebView::notifyPreferencesChanged):
229 2011-10-24 Geoffrey Garen <ggaren@apple.com>
231 Build fix: removed some cases of threadsafeCopy() that I missed in
234 * WebDatabaseManager.cpp:
235 (DidModifyOriginData::dispatchToMainThread):
236 * WebDownloadCFNet.cpp:
237 (WebDownload::initToResumeWithBundle):
238 * WebIconDatabase.cpp:
239 (WebIconDatabase::didImportIconURLForPageURL):
241 2011-10-24 Ryosuke Niwa <rniwa@webkit.org>
243 threadsafeCopy has been renamed to isolatedCopy.
245 * WebDatabaseManager.cpp:
246 (DidModifyOriginData::dispatchToMainThread):
248 2011-10-24 Adam Barth <abarth@webkit.org>
250 Attempt to fix Windows build by updating to the new interface.
252 * DOMEventsClasses.cpp:
253 (DOMEvent::createInstance):
255 2011-10-18 Adam Barth <abarth@webkit.org>
257 Always enable ENABLE(XPATH)
258 https://bugs.webkit.org/show_bug.cgi?id=70217
260 Reviewed by Eric Seidel.
262 * Interfaces/DOMWindow.idl:
264 2011-10-14 Julien Chaffraix <jchaffraix@webkit.org>
266 Remove layerX / layerY from the Windows API
267 https://bugs.webkit.org/show_bug.cgi?id=70051
269 Reviewed by Darin Adler.
271 Renamed layerX to unused1 and layerY to unused2 to keep the
272 binary compatibility.
274 * DOMEventsClasses.cpp:
275 (DOMUIEvent::unused1):
276 (DOMUIEvent::unused2):
277 * DOMEventsClasses.h:
278 (DOMKeyboardEvent::unused1):
279 (DOMKeyboardEvent::unused2):
280 (DOMMouseEvent::unused1):
281 (DOMMouseEvent::unused2):
282 (DOMWheelEvent::unused1):
283 (DOMWheelEvent::unused2):
284 * Interfaces/DOMEvents.idl:
286 2011-10-11 Simon Fraser <simon.fraser@apple.com>
288 Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
289 https://bugs.webkit.org/show_bug.cgi?id=68134
291 Reviewed by Darin Adler.
293 Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.
295 Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
296 that reads the setting, and returns the mock theme if set. All callers now use
297 theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.
300 (WebScrollBar::requestedWidth):
301 (WebScrollBar::requestedHeight):
303 (WebView::WebViewWndProc):
305 2011-10-03 Anders Carlsson <andersca@apple.com>
307 Remove custom scrollbar painting hooks
308 https://bugs.webkit.org/show_bug.cgi?id=69163
310 Reviewed by Alexey Proskuryakov.
312 Remove now unused WebPreferences and ChromeClient overrides.
314 * Interfaces/IWebPreferences.idl:
315 * WebCoreSupport/WebChromeClient.cpp:
316 * WebCoreSupport/WebChromeClient.h:
317 * WebPreferenceKeysPrivate.h:
318 * WebPreferences.cpp:
319 (WebPreferences::unused3):
320 (WebPreferences::unused4):
323 (WebView::notifyPreferencesChanged):
325 2011-09-23 Adam Roben <aroben@apple.com>
329 WebKit part of <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
330 functionality (and names!)
332 Reviewed by Anders Carlsson.
334 * WebKit.vcproj/WebKit.sln: Removed WebKitAPITest.vcproj. Changed WebKitLauncherWin, which
335 formerly depended on WebKitAPITest, to now depend on DumpRenderTree, which WebKitAPITest
338 2011-09-24 Adam Barth <abarth@webkit.org>
340 Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
341 https://bugs.webkit.org/show_bug.cgi?id=68767
343 Reviewed by Eric Seidel.
345 * WebCoreSupport/WebChromeClient.cpp:
346 (WebChromeClient::reachedApplicationCacheOriginQuota):
347 * WebCoreSupport/WebChromeClient.h:
349 2011-09-22 Adam Roben <aroben@apple.com>
351 Remove FindSafari from all our .sln files
353 It isn't used anymore, so there's no point in building it.
355 Part of <http://webkit.org/b/68628> Remove FindSafari
357 Reviewed by Steve Falkenburg.
359 * WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.
361 2011-09-22 Adam Roben <aroben@apple.com>
363 Add testRegExp.vcproj to WebKit.sln
365 Fixes <http://webkit.org/b/68403> Windows bots don't build testRegExp.vcproj
367 Reviewed by Brian Weinstein.
369 * WebKit.vcproj/WebKit.sln: Added testRegExp. Made it build just after jsc, just like it
370 does when built as part of JavaScriptCore.sln.
372 2011-09-21 Steve Falkenburg <sfalken@apple.com>
374 Branch builds don't launch on Windows when run against trunk WebKit
375 https://bugs.webkit.org/show_bug.cgi?id=68546
377 Reviewed by Darin Adler.
379 * Interfaces/IWebPreferences.idl: Swap avFoundation and pictographicFontFamily
380 in IDL for binary compatibility between branch and trunk.
382 2011-09-21 Andras Becsi <andras.becsi@nokia.com>
384 [Qt] Remove Qt specific code from css/SelectorChecker.cpp
385 https://bugs.webkit.org/show_bug.cgi?id=67702
387 Reviewed by Csaba Osztrogonác.
389 * WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.
390 (WebPlatformStrategies::isLinkVisited):
391 * WebCoreSupport/WebPlatformStrategies.h: Ditto.
393 2011-09-17 Mihai Parparita <mihaip@chromium.org>
395 FrameLoaderClient BackForwardList-related methods are unsued
396 https://bugs.webkit.org/show_bug.cgi?id=68293
398 Reviewed by Darin Adler.
400 Remove FrameLoaderClient methods that were added by r51629, since only
401 the old (since-deleted) Android port needed them.
403 * WebCoreSupport/WebFrameLoaderClient.cpp:
404 * WebCoreSupport/WebFrameLoaderClient.h:
406 2011-09-15 Adam Barth <abarth@webkit.org>
408 Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
409 https://bugs.webkit.org/show_bug.cgi?id=68205
411 Reviewed by Eric Seidel.
414 * WebCoreSupport/WebChromeClient.cpp:
415 * WebCoreSupport/WebChromeClient.h:
416 * WebDatabaseManager.cpp:
417 * WebDatabaseManager.h:
418 * WebSecurityOrigin.cpp:
419 (WebSecurityOrigin::usage):
420 (WebSecurityOrigin::quota):
421 (WebSecurityOrigin::setQuota):
423 (WebView::initWithFrame):
424 (WebView::notifyPreferencesChanged):
426 2011-09-15 Kentaro Hara <haraken@google.com>
428 A single line must not be split into two pages.
429 https://bugs.webkit.org/show_bug.cgi?id=65005
431 Reviewed by David Hyatt.
433 When the document width of a page is overflowed, the last line of the page can be
434 split into the next page. This is the regression caused by r88737. r88737 tried to
435 fix rounding errors in rendering calculations by expanding and shrinking a page
436 using one common method, resizePageRectsKeepingRatio(), but overlooked the case where
437 a document width gets overflowed.
439 Test: printing/single-line-must-not-be-split-into-two-pages.html
442 (WebFrame::setPrinting): Passes an original page size to setPrinting().
443 (WebFrame::setInPrintingMode): Ditto.
446 2011-09-06 Ryosuke Niwa <rniwa@webkit.org>
448 Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
449 https://bugs.webkit.org/show_bug.cgi?id=67569
451 Reviewed by Antonio Gomes.
456 2011-08-29 Alexey Proskuryakov <ap@apple.com>
458 DumpRenderTree should begin each test with an empty cookie store
459 https://bugs.webkit.org/show_bug.cgi?id=63545
460 <rdar://problem/5666907>
462 Reviewed by Darin Adler.
464 * WebCookieManagerCFNet.cpp:
465 (WebCookieManager::cookieStorage):
466 (WebCookieManager::setCookieStorage):
467 Changed the API to work with new functions in WebCore. It's a bit ugly, because cookieStorage()
468 returns an unretained reference, which we cannot provide any more, but it should not be a
471 * WebView.cpp: (updateSharedSettingsFromPreferencesIfNeeded): Updated to use currentCFHTTPCookieStorage()
472 instead of currentCookieStorage().
474 2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
476 The unused ScrollView* argument can and should be removed from
478 https://bugs.webkit.org/show_bug.cgi?id=67117
480 Reviewed by Darin Adler.
482 * WebCoreSupport/WebChromeClient.h:
483 (WebChromeClient::scrollRectIntoView):
485 2011-08-29 Ryosuke Niwa <rniwa@webkit.org>
487 Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
488 https://bugs.webkit.org/show_bug.cgi?id=67152
490 Reviewed by Darin Adler.
492 Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
493 to HTMLTextFormControlElement.
495 * DOMHTMLClasses.cpp:
496 (DOMHTMLInputElement::isUserEdited):
497 (DOMHTMLTextAreaElement::isUserEdited):
499 2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
501 Unreviewed, rolling out r93987, r93992, r93995, r93998, and
503 http://trac.webkit.org/changeset/93987
504 http://trac.webkit.org/changeset/93992
505 http://trac.webkit.org/changeset/93995
506 http://trac.webkit.org/changeset/93998
507 http://trac.webkit.org/changeset/93999
508 https://bugs.webkit.org/show_bug.cgi?id=67147
510 Many failing tests (Requested by ap on #webkit).
512 * WebCookieManagerCFNet.cpp:
513 (WebCookieManager::cookieStorage):
514 (WebCookieManager::setCookieStorage):
516 (updateSharedSettingsFromPreferencesIfNeeded):
518 2011-08-29 Alexey Proskuryakov <ap@apple.com>
523 (updateSharedSettingsFromPreferencesIfNeeded):
524 Updated for new function name and signature: currentCFHTTPCookieStorage().
526 2011-08-26 Alexey Proskuryakov <ap@apple.com>
528 DumpRenderTree should begin each test with an empty cookie store
529 https://bugs.webkit.org/show_bug.cgi?id=63545
530 <rdar://problem/5666907>
532 Reviewed by Darin Adler.
534 * WebCookieManagerCFNet.cpp:
535 (WebCookieManager::cookieStorage):
536 (WebCookieManager::setCookieStorage):
537 Changed the API to work with new functions in WebCore. It's a bit ugly, because cookieStorage()
538 returns an unretained reference, which we cannot provide any more, but it should not be a
541 2011-08-17 Adam Roben <aroben@apple.com>
543 Make WebCore keep track of the current device scale factor
545 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
548 Reviewed by Darin Adler.
550 * WebCoreSupport/WebChromeClient.cpp:
551 * WebCoreSupport/WebChromeClient.h:
552 Removed deviceScaleFactor.
554 2011-08-15 Dmitry Titov <dimich@chromium.org>
556 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
557 https://bugs.webkit.org/show_bug.cgi?id=66165
559 Reviewed by Darin Fisher.
561 * WebCoreSupport/WebFrameLoaderClient.cpp:
562 (WebFrameLoaderClient::transferLoadingResourceFromPage):
563 * WebCoreSupport/WebFrameLoaderClient.h:
565 2011-08-15 Adam Roben <aroben@apple.com>
567 Touch a file to trigger a Windows build
569 I'm trying to ferret out some issues with our Debug builder.
571 * WebView.cpp: Sorted #includes.
573 2011-08-10 Adam Roben <aroben@apple.com>
575 Clear up scale factor terminology
577 WebKit by and large deals with two scale factors: one intrinsic to the device on which the
578 software is running, and one that is per-Page and can be controlled via API calls. This
579 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
580 code use those names. It should introduce no behavior changes.
582 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
585 Reviewed by Simon Fraser.
587 * WebCoreSupport/WebChromeClient.cpp:
588 * WebCoreSupport/WebChromeClient.h:
590 2011-08-13 Dan Bernstein <mitz@apple.com>
592 Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
594 Reviewed by Joseph Pecoraro.
596 * WebPreferenceKeysPrivate.h:
598 2011-08-13 Dan Bernstein <mitz@apple.com>
603 (WebView::notifyPreferencesChanged):
605 2011-08-12 Dan Bernstein <mitz@apple.com>
607 Add an option to automatically show tooltips (with the full text) over truncated text
608 https://bugs.webkit.org/show_bug.cgi?id=66178
610 Reviewed by Simon Fraser.
612 * Interfaces/IWebPreferencesPrivate.idl: Added accessors.
613 * WebPreferenceKeysPrivate.h: Defined a preference key.
614 * WebPreferences.cpp:
615 (WebPreferences::initializeDefaultSettings): Added a default value of
616 false for the ShowsToolTipOverTruncatedText preference.
617 (WebPreferences::showsToolTipOverTruncatedText): Added this getter.
618 (WebPreferences::setShowsToolTipOverTruncatedText): Added this setter.
621 (WebView::notifyPreferencesChanged): Added call to Settings::setShowsToolTipOverTruncatedText().
623 2011-08-05 Brent Fulgham <bfulgham@webkit.org>
625 WebView::performLayeredWindowUpdate() crashes with
626 NULL pointer when using layered window updates.
627 https://bugs.webkit.org/show_bug.cgi?id=60618
629 Reviewed by Adam Roben.
631 During resize operations, the backing store will be destroyed if
632 the window's size (either height or width) is set to zero. The
633 bug was identified when a user first resized a WebView to zero
634 dimensions, then attempted to perform a MoveWindow. The paint
635 message triggered by the MoveWindow attempted to use the layered
636 window update logic, which encountered the nulled backing store.
639 (WebView::performLayeredWindowUpdate): Add an early
640 return when there is no backing store to blend with.
642 2011-08-05 Anders Carlsson <andersca@apple.com>
645 https://bugs.webkit.org/show_bug.cgi?id=65729
647 Reviewed by Darin Adler.
649 Remove plug-in halter and associated classes.
651 * Interfaces/IWebPluginHalterDelegate.idl: Removed.
652 * Interfaces/IWebPreferencesPrivate.idl:
653 * Interfaces/IWebViewPrivate.idl:
654 * Interfaces/WebKit.idl:
655 * WebCoreSupport/WebPluginHalterClient.cpp: Removed.
656 * WebCoreSupport/WebPluginHalterClient.h: Removed.
657 * WebKit.vcproj/Interfaces.vcproj:
658 * WebKit.vcproj/WebKit.vcproj:
659 * WebPreferenceKeysPrivate.h:
660 * WebPreferences.cpp:
661 (WebPreferences::initializeDefaultSettings):
665 (WebView::initWithFrame):
666 (WebView::notifyPreferencesChanged):
674 2011-08-04 Jeff Miller <jeffm@apple.com>
676 Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
677 https://bugs.webkit.org/show_bug.cgi?id=65718
679 Reviewed by Adam Roben.
681 * Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().
683 * WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.
685 * WebPreferences.cpp:
686 (WebPreferences::avFoundationEnabled): Added.
687 (WebPreferences::setAVFoundationEnabled): Added.
689 * WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().
692 (WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.
694 2011-08-03 Kent Tamura <tkent@chromium.org>
696 [Windows] Fix build without ENABLE_VIDEO.
699 (WebView::enterFullscreenForNode):
701 2011-08-03 Kent Tamura <tkent@chromium.org>
703 Fix incorrect checks for HTMLMediaElement
704 https://bugs.webkit.org/show_bug.cgi?id=65590
706 Reviewed by Dimitri Glazkov.
708 <video> and <audio> can be an HTMLElement instance instead of
709 HTMLMediaElement if MediaPlayer::isAvailable() returns false or
710 the media feature is disabled at runtime.
713 (WebView::enterFullscreenForNode):
715 2011-08-03 Joseph Pecoraro <joepeck@webkit.org>
717 Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
718 https://bugs.webkit.org/show_bug.cgi?id=65582
720 Reviewed by Pavel Feldman.
722 * WebCoreSupport/WebInspectorClient.cpp:
723 * WebCoreSupport/WebInspectorClient.h:
725 2011-08-03 Adam Roben <aroben@apple.com>
727 Windows nightly build fix after r91777
729 * Interfaces/IWebPreferences.idl: Moved [set]PictographFontFamily to the end of the
730 interface to maintain binary compatibility with Safari 5.1.
732 2011-08-03 Pavel Feldman <pfeldman@google.com>
734 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
735 https://bugs.webkit.org/show_bug.cgi?id=65510
737 Reviewed by Yury Semikhatsky.
739 * WebNodeHighlight.cpp:
740 (WebNodeHighlight::update):
742 2011-08-03 Pavel Feldman <pfeldman@chromium.org>
744 Web Inspector: remove Node parameter from the InspectorClient::highlight
745 https://bugs.webkit.org/show_bug.cgi?id=65549
747 Reviewed by Yury Semikhatsky.
749 * WebCoreSupport/WebInspectorClient.cpp:
750 (WebInspectorClient::highlight):
751 * WebCoreSupport/WebInspectorClient.h:
753 2011-07-31 Daniel Bates <dbates@webkit.org>
755 Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).
757 * WebKit.vcproj/WebKit_Cairo.def: Export some symbols.
758 * WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
760 2011-07-30 Patrick Gansterer <paroga@webkit.org>
762 Remove inclusion of MainThread.h from Threading.h
763 https://bugs.webkit.org/show_bug.cgi?id=65081
765 Reviewed by Darin Adler.
767 Add missing include statements for MainThread.
769 * WebKitClassFactory.cpp:
772 2011-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org>
774 Add support for download='filename' attribute in anchors.
775 https://bugs.webkit.org/show_bug.cgi?id=64580
777 Reviewed by Adam Barth.
780 (WebFrame::startDownload):
783 2011-07-26 Dan Bernstein <mitz@apple.com>
785 <rdar://problem/9842889> Add a generic pictograph font family
786 https://bugs.webkit.org/show_bug.cgi?id=65197
788 Reviewed by Anders Carlsson.
790 * Interfaces/IWebPreferences.idl: Added pictographFontFamily() and
791 setPictographFontFamily().
792 * WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
793 * WebPreferences.cpp:
794 (WebPreferences::initializeDefaultSettings): Initialize the pictograph font
795 preference to "Times New Roman".
796 (WebPreferences::pictographFontFamily): Added this getter.
797 (WebPreferences::setPictographFontFamily): Added this setter.
800 (WebView::notifyPreferencesChanged): Pass the preference value through to
803 2011-07-18 Dean Jackson <dino@apple.com>
805 https://bugs.webkit.org/show_bug.cgi?id=64742
806 Expose WebPreferences for media playback requiring user gestures and inline playback
808 Reviewed by Simon Fraser.
810 Two new WebPreferences: MediaPlaybackRequiresUserGesture and
811 MediaPlaybackAllowsInline.
813 * Interfaces/IWebPreferencesPrivate.idl:
814 * WebPreferenceKeysPrivate.h:
815 * WebPreferences.cpp:
816 (WebPreferences::initializeDefaultSettings):
817 (WebPreferences::setMediaPlaybackRequiresUserGesture):
818 (WebPreferences::mediaPlaybackRequiresUserGesture):
819 (WebPreferences::setMediaPlaybackAllowsInline):
820 (WebPreferences::mediaPlaybackAllowsInline):
823 (WebView::notifyPreferencesChanged):
825 2011-07-16 Simon Fraser <simon.fraser@apple.com>
827 Add code to attempt to align compositing layers to pixel boundaries when page scale changes
828 https://bugs.webkit.org/show_bug.cgi?id=64658
830 Reviewed by Dan Bernstein.
832 Removed implementations of backingScaleFactor() and pageScaleFactor() now
833 that GraphicsLayerClient has default implementations.
837 2011-07-15 Simon Fraser <simon.fraser@apple.com>
842 (WebView::backingScaleFactor):
843 (WebView::pageScaleFactor):
845 2011-07-15 Dan Bernstein <mitz@apple.com>
847 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
848 https://bugs.webkit.org/show_bug.cgi?id=64615
850 Reviewed by Anders Carlsson.
852 * WebCoreSupport/WebChromeClient.cpp:
853 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
854 * WebCoreSupport/WebChromeClient.h:
856 2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
858 ApplicationCache update should not immediately fail when reaching per-origin quota
859 https://bugs.webkit.org/show_bug.cgi?id=64177
861 Reviewed by Alexey Proskuryakov.
863 * WebCoreSupport/WebChromeClient.cpp:
864 (WebChromeClient::reachedApplicationCacheOriginQuota):
865 * WebCoreSupport/WebChromeClient.h:
867 2011-07-11 Hironori Bono <hbono@chromium.org>
869 Reviewed by Adam Roben.
871 Implement layoutTestController.setTextDirection for WebKit2 and Windows.
872 https://bugs.webkit.org/show_bug.cgi?id=61931
874 This change implements layoutTextController.setTextDirection for WebKit2
875 and Windows so we can run a layout test added by r87770 on them. Each
876 implementation adds a wrapper function for Editor::setBaseWritingDirection()
877 so LayoutTestController can call it.
879 * Interfaces/IWebFramePrivate.idl: Added setTextDirection to allow
880 LayoutTestController to change the text direction.
881 * WebFrame.cpp: ditto.
882 (WebFrame::setTextDirection):
885 2011-07-08 Chang Shu <cshu@webkit.org>
887 Update calling sites after function renamed.
888 https://bugs.webkit.org/show_bug.cgi?id=59114
890 Reviewed by Alexey Proskuryakov.
892 * WebKitGraphics.cpp:
895 2011-06-30 Anders Carlsson <andersca@apple.com>
897 Reviewed by Dan Bernstein.
899 More ScrollableArea scaffolding
900 https://bugs.webkit.org/show_bug.cgi?id=63678
903 (WebScrollBar::enclosingScrollableArea):
904 Always return 0, WebScrollbar has no concept of an enclosing scrollable area.
906 2011-06-28 Ilya Sherman <isherman@chromium.org>
908 Reviewed by Adam Barth.
910 form.autocomplete="off" does not work
911 https://bugs.webkit.org/show_bug.cgi?id=35823
914 (WebFrame::elementDoesAutoComplete): Updated callsite.
916 2011-06-27 Brent Fulgham <bfulgham@webkit.org>
918 Reviewed by Adam Roben.
920 Avoid attempt to create a zero-size DIB.
921 https://bugs.webkit.org/show_bug.cgi?id=63484.
923 * WebNodeHighlight.cpp:
924 (WebNodeHighlight::update): Check for zero-height (or zero-width)
925 region for DIB, and exit early if attempting to create a zero-size
928 2011-06-24 Dan Bernstein <mitz@apple.com>
930 Reviewed by Anders Carlsson.
932 Add an option to enable legacy rounding hacks
933 https://bugs.webkit.org/show_bug.cgi?id=63363
935 * WebKitGraphics.cpp:
936 (CenterTruncateStringToWidth): Enabled rounding hacks in the string truncator.
937 (RightTruncateStringToWidth): Ditto.
939 2011-06-24 Yuta Kitamura <yutak@chromium.org>
941 Reviewed by Adam Barth.
943 WebSocket: Add run-time flag for new HyBi protocol
944 https://bugs.webkit.org/show_bug.cgi?id=60348
946 Make a new flag (Setting::m_useHixie76WebSocketProtocol)
947 switchable from WebView and WebPreferences.
949 * Interfaces/IWebPreferencesPrivate.idl:
950 * WebPreferenceKeysPrivate.h:
951 * WebPreferences.cpp:
952 (WebPreferences::initializeDefaultSettings):
953 (WebPreferences::setHixie76WebSocketProtocolEnabled):
954 (WebPreferences::hixie76WebSocketProtocolEnabled):
957 (WebView::notifyPreferencesChanged):
959 2011-06-22 Dominic Cooney <dominicc@chromium.org>
961 Reviewed by Mark Rowe.
963 Add window.internals to WebKit2's WebKitTestRunner.
964 https://bugs.webkit.org/show_bug.cgi?id=61073
966 * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
968 2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
970 Reviewed by Kent Tamura.
972 FileChooser should be only created when we need to choose files.
973 https://bugs.webkit.org/show_bug.cgi?id=63039
975 * WebCoreSupport/WebChromeClient.cpp:
976 (WebChromeClient::runOpenPanel): Changed to use settings.
978 2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
980 Unreviewed, rolling out r89354.
981 http://trac.webkit.org/changeset/89354
982 https://bugs.webkit.org/show_bug.cgi?id=63099
984 Broke tests on Mac (Requested by rniwa on #webkit).
986 * WebCoreSupport/WebInspectorClient.cpp:
987 (WebInspectorClient::WebInspectorClient):
988 (WebInspectorClient::openInspectorFrontend):
989 (WebInspectorFrontendClient::destroyInspectorView):
990 * WebCoreSupport/WebInspectorClient.h:
992 (WebInspector::createInstance):
993 (WebInspector::WebInspector):
994 (WebInspector::webViewClosed):
995 (WebInspector::showConsole):
996 (WebInspector::isDebuggingJavaScript):
997 (WebInspector::toggleDebuggingJavaScript):
998 (WebInspector::isProfilingJavaScript):
999 (WebInspector::toggleProfilingJavaScript):
1000 (WebInspector::isJavaScriptProfilingEnabled):
1001 (WebInspector::setJavaScriptProfilingEnabled):
1002 (WebInspector::isTimelineProfilingEnabled):
1003 (WebInspector::setTimelineProfilingEnabled):
1008 (WebView::initWithFrame):
1009 (WebView::inspector):
1012 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
1014 Reviewed by Yury Semikhatsky.
1016 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
1017 https://bugs.webkit.org/show_bug.cgi?id=62985
1019 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
1020 methods for plumbing the menu action handlers through the WebKit and WebCore.
1021 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
1022 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
1023 WebKit/win and WebKit2 to follow.
1026 (WebInspector::createInstance):
1027 (WebInspector::WebInspector):
1028 (WebInspector::webViewClosed):
1029 (WebInspector::showConsole):
1030 (WebInspector::isDebuggingJavaScript):
1031 (WebInspector::toggleDebuggingJavaScript):
1032 (WebInspector::isProfilingJavaScript):
1033 (WebInspector::toggleProfilingJavaScript):
1034 (WebInspector::isJavaScriptProfilingEnabled):
1035 (WebInspector::setJavaScriptProfilingEnabled):
1036 (WebInspector::isTimelineProfilingEnabled):
1037 (WebInspector::setTimelineProfilingEnabled):
1042 (WebView::initWithFrame):
1043 (WebView::inspector):
1046 2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
1048 Reviewed by Darin Adler.
1050 Separate concerns of loading file icons and choosing files.
1051 https://bugs.webkit.org/show_bug.cgi?id=62931
1053 * WebCoreSupport/WebChromeClient.cpp:
1054 (WebChromeClient::loadIconForFiles): Renamed.
1055 * WebCoreSupport/WebChromeClient.h:
1057 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
1059 Unreviewed, rolling out r89026.
1060 http://trac.webkit.org/changeset/89026
1061 https://bugs.webkit.org/show_bug.cgi?id=62804
1063 These patches were likely correct. I'll investigate the
1064 browser_test failures. (Requested by abarth on #webkit).
1066 * FullscreenVideoController.cpp:
1067 (FullscreenVideoController::play):
1068 (FullscreenVideoController::pause):
1070 2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
1074 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
1075 https://bugs.webkit.org/show_bug.cgi?id=62796
1077 The patches broke chromium browser tests.
1079 * FullscreenVideoController.cpp:
1080 (FullscreenVideoController::play):
1081 (FullscreenVideoController::pause):
1083 2011-06-16 Adam Barth <abarth@webkit.org>
1085 Reviewed by Eric Seidel.
1087 Remove HTMLVideoElement::processingUserGesture
1088 https://bugs.webkit.org/show_bug.cgi?id=62784
1090 * FullscreenVideoController.cpp:
1091 (FullscreenVideoController::play):
1092 (FullscreenVideoController::pause):
1094 2011-06-13 Kentaro Hara <haraken@google.com>
1096 Reviewed by Alexey Proskuryakov.
1098 Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
1099 https://bugs.webkit.org/show_bug.cgi?id=61256
1101 In order to prevent rounding error caused by expanding/shrinking a page
1102 using different calculation here and there, I added a common calculation
1103 method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
1104 keeping the ratio of width and height of the original page.
1105 WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
1106 expand/shrink a page.
1108 Test: printing/page-count-with-one-word.html
1111 (WebFrame::setPrinting):
1112 (WebFrame::setInPrintingMode):
1115 2011-06-12 MORITA Hajime <morrita@google.com>
1117 Unreviewed, rolling out r88625.
1118 http://trac.webkit.org/changeset/88625
1119 https://bugs.webkit.org/show_bug.cgi?id=61073
1121 Breaks SL Webkit2 Tests
1123 * WebKit.vcproj/WebKit.sln:
1125 2011-06-12 Adam Barth <abarth@webkit.org>
1127 Reviewed by Alexey Proskuryakov.
1129 Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
1130 https://bugs.webkit.org/show_bug.cgi?id=62516
1133 (WebFrame::interruptedForPolicyChangeError):
1136 2011-06-12 Dominic Cooney <dominicc@chromium.org>
1138 Reviewed by Hajime Morita.
1140 Add window.internals to WebKit2's WebKitTestRunner.
1141 https://bugs.webkit.org/show_bug.cgi?id=61073
1143 * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
1145 2011-06-12 Adam Barth <abarth@webkit.org>
1147 Reviewed by Alexey Proskuryakov.
1149 Remove trival "forward-to-client" member functions from FrameLoader
1150 https://bugs.webkit.org/show_bug.cgi?id=62510
1152 * WebCoreSupport/WebFrameNetworkingContext.cpp:
1153 (WebFrameNetworkingContext::blockedError):
1155 2011-06-06 Michael Saboff <msaboff@apple.com>
1157 Reviewed by Geoffrey Garen.
1159 Fonts returned by FontCache::getFontDataForCharacters() are never released
1160 https://bugs.webkit.org/show_bug.cgi?id=61875
1162 This change allows fonts allocated as system fallback fonts to be
1163 released. Previously, the reference counts for these fonts grew
1164 without bound. This is implemented as an auto release class that wraps
1165 accesses to the cache for system fallback fonts. All such accesses are
1166 via the method FontCache::getFontDataForCharacters. The new class is
1167 called FontCachePurgePreventer. When such an object exists, it protects
1168 these fonts from deletion.
1170 See more comments for this defect in Source/WebCore/ChangeLog.
1172 * WebKitGraphics.cpp:
1173 (CenterTruncateStringToWidth):
1174 (RightTruncateStringToWidth):
1175 Wrapped code accessing fallback fonts with local
1176 FontCachePurgePreventer in these methods.
1178 2011-06-04 Dominic Cooney <dominicc@chromium.org>
1180 Reviewed by Dimitri Glazkov.
1182 Add WebCoreTestSupport project containing window.internals.
1183 https://bugs.webkit.org/show_bug.cgi?id=61076
1185 * WebKit.vcproj/WebKit.sln:
1187 2011-05-18 Anthony Johnson <anthony.johnson@flexsim.com>
1189 Reviewed by Brent Fulgham.
1191 Implement the ability to add C++ event listeners to html dom
1192 elements and dom window.
1193 https://bugs.webkit.org/show_bug.cgi?id=60269
1195 * DOMCoreClasses.cpp: Add new DOMWindow class and implementations.
1196 (DOMNode::QueryInterface): Report that the DOMNode implements
1197 the IDomEventTarget interface.
1198 (DOMNode::addEventListener): Add implementation of a COM-based
1200 (DOMNode::removeEventListener):
1201 (DOMNode::dispatchEvent):
1202 (DOMDocument::createInstance):
1203 (DOMWindow::QueryInterface): New implementation.
1204 (DOMWindow::document): New implementation.
1205 (DOMWindow::getComputedStyle): Stub.
1206 (DOMWindow::getMatchedCSSRules): Stub.
1207 (DOMWindow::devicePixelRatio): Stub.
1208 (DOMWindow::addEventListener): New implementation.
1209 (DOMWindow::removeEventListener): New implementation.
1210 (DOMWindow::dispatchEvent): New implementation.
1211 (DOMWindow::DOMWindow): New implementation.
1212 (DOMWindow::~DOMWindow): New implementation.
1213 (DOMWindow::createInstance): New implementation.
1214 * DOMCoreClasses.h: Add new DOMWindow class and declarations.
1215 (DOMWindow::AddRef): New declaration.
1216 (DOMWindow::Release): New declaration.
1217 (DOMWindow::throwException): New declaration.
1218 (DOMWindow::callWebScriptMethod): New declaration.
1219 (DOMWindow::evaluateWebScript): New declaration.
1220 (DOMWindow::removeWebScriptKey): New declaration.
1221 (DOMWindow::stringRepresentation): New declaration.
1222 (DOMWindow::webScriptValueAtIndex): New declaration.
1223 (DOMWindow::setWebScriptValueAtIndex): New declaration.
1224 (DOMWindow::setException): New declaration.
1225 (DOMWindow::window): New declaration.
1226 * DOMEventsClasses.cpp: Add new WebEventListener and implementation.
1227 (DOMEventListener::handleEvent): New implementation.
1228 (WebEventListener::WebEventListener): New implementation.
1229 (WebEventListener::~WebEventListener): New implementation.
1230 (WebEventListener::operator==): New implementation.
1231 (WebEventListener::handleEvent): New implementation.
1232 (WebEventListener::create): New implementation.
1233 * DOMEventsClasses.h: Add new WebEventListener class declaration.
1234 * Interfaces/IWebFrame.idl: Add new DOMWindow accessor to the
1235 main Web Frame interface.
1236 * WebFrame.cpp: Add implementation of new DOMWindow creation method.
1237 (WebFrame::DOMWindow):
1238 * WebFrame.h: Add DOMWindow declaration.
1240 2011-05-20 Simon Fraser <simon.fraser@apple.com>
1242 Reviewed by Sam Weinig.
1244 numberOfActiveAnimations() can include animations from documents in the page cache
1245 https://bugs.webkit.org/show_bug.cgi?id=53641
1247 Pass the Frame's document as the one to count animations on.
1250 (WebFrame::numberOfActiveAnimations):
1252 2011-05-20 Jer Noble <jer.noble@apple.com>
1254 Reviewed by Maciej Stachowiak.
1256 Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
1257 https://bugs.webkit.org/show_bug.cgi?id=61108
1260 (WebView::fullScreenClientForceRepaint): Repaint the view and immediately notify the
1261 full screen controller.
1264 2011-05-13 Jon Lee <jonlee@apple.com>
1266 Reviewed by Simon Fraser.
1268 Can't horizontally scroll iframes and overflow because wheel events are always accepted
1269 https://bugs.webkit.org/show_bug.cgi?id=60779
1271 * WebCoreSupport/WebChromeClient.h:
1272 (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
1273 (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
1275 2011-05-13 Sam Weinig <sam@webkit.org>
1277 Reviewed by Anders Carlsson.
1279 Prune #includes from FrameView.h (Part 2)
1280 https://bugs.webkit.org/show_bug.cgi?id=60748
1282 - Update files that were depending on FrameView.h #including Frame.h or
1285 * WebCoreSupport/WebChromeClient.cpp:
1286 * WebCoreSupport/WebDragClient.cpp:
1287 * WebCoreSupport/WebFrameLoaderClient.cpp:
1289 (WebFrame::setPrinting):
1292 2011-05-12 Patrick Gansterer <paroga@webkit.org>
1294 Reviewed by Adam Barth.
1296 Enable OwnPtr strict mode in PluginHalter
1297 https://bugs.webkit.org/show_bug.cgi?id=60681
1300 (WebView::initWithFrame):
1302 2011-05-12 Adam Roben <aroben@apple.com>
1304 A little gtest cleanup after r86287
1306 * WebKit.vcproj/WebKit.sln:
1307 - Move gtest into the Tools folder
1308 - Make gtest build just before TestWebKitAPIGenerated
1309 - Use gtest's new Debug_All and Production configurations as appropriate
1311 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
1313 Reviewed by Darin Adler.
1315 String operator+ reallocates unnecessarily when concatting > 2 strings
1316 https://bugs.webkit.org/show_bug.cgi?id=58420
1318 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
1320 * AccessibleBase.cpp:
1321 (AccessibleBase::get_accKeyboardShortcut): Explicitely cast to Strings first, so operator BString() can be invoked.
1323 2011-05-11 Dmitry Lomov <dslomov@google.com>
1325 Reviewed by David Levin.
1327 https://bugs.webkit.org/show_bug.cgi?id=59561
1328 Switch TestWebKitAPI to GTest
1330 Fixes Makefiles and WinCairo build as well
1332 * WebKit.vcproj/WebKit.sln:
1334 2011-05-11 Jessie Berlin <jberlin@apple.com>
1336 Reviewed by Steve Falkenburg.
1338 [Windows WebKit2] Use cookies set in WebKit1
1339 https://bugs.webkit.org/show_bug.cgi?id=60274
1342 (WebView::setCacheModel):
1343 Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
1345 2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
1347 Unreviewed, rolling out r86255.
1348 http://trac.webkit.org/changeset/86255
1349 https://bugs.webkit.org/show_bug.cgi?id=60660
1351 REGRESSION (r86255): Lots of tests crashing in
1352 CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
1353 (WebKit2 Tests) (Requested by aroben on #webkit).
1356 (WebView::setCacheModel):
1358 2011-05-11 Jessie Berlin <jberlin@apple.com>
1360 Reviewed by Steve Falkenburg.
1362 [Windows WebKit2] Use cookies set in WebKit1
1363 https://bugs.webkit.org/show_bug.cgi?id=60274
1366 (WebView::setCacheModel):
1367 Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
1369 2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
1371 Unreviewed, rolling out r86108.
1372 http://trac.webkit.org/changeset/86108
1373 https://bugs.webkit.org/show_bug.cgi?id=60533
1375 Broke makefile based builds and Cairo (Requested by weinig on
1378 * WebKit.vcproj/WebKit.sln:
1380 2011-05-09 Dmitry Lomov <dslomov@google.com>
1382 Reviewed by Sam Weinig.
1384 Switch TestWebKitAPI to GTest
1385 https://bugs.webkit.org/show_bug.cgi?id=59561
1387 * WebKit.vcproj/WebKit.sln:
1389 2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
1391 Unreviewed, rolling out r86016.
1392 http://trac.webkit.org/changeset/86016
1393 https://bugs.webkit.org/show_bug.cgi?id=60445
1395 caused crashes on the WK2 Windows bots (Requested by
1396 jessieberlin on #webkit).
1399 (WebView::setCacheModel):
1401 2011-05-07 Jessie Berlin <jberlin@apple.com>
1403 Reviewed by Steve Falkenburg.
1405 [Windows WebKit2] Use cookies set in WebKit1
1406 https://bugs.webkit.org/show_bug.cgi?id=60274
1409 (WebView::setCacheModel):
1410 Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
1412 2011-05-06 Adam Roben <aroben@apple.com>
1414 Touch WebKit.idl to fix the build
1416 I needed this on my own machine. Maybe others will need it, too.
1418 * Interfaces/WebKit.idl:
1420 2011-05-04 Philippe Normand <pnormand@igalia.com>
1422 Reviewed by Dimitri Glazkov.
1424 Implement LayoutTestController::pseudoShadowId()
1425 https://bugs.webkit.org/show_bug.cgi?id=60034
1427 * DOMCoreClasses.cpp:
1428 (DOMElement::shadowPseudoId):
1431 2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
1433 Reviewed by Eric Seidel.
1435 Rename SelectionController to FrameSelection
1436 https://bugs.webkit.org/show_bug.cgi?id=60234
1440 2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
1442 Windows build fix attempt after r85823
1444 * WebCoreSupport/WebChromeClient.h:
1445 (WebChromeClient::webView):
1449 2011-05-04 Cris Neckar <cdn@chromium.org>
1451 Reviewed by Adam Barth.
1453 Expose WebView directly through ChromeClient.
1454 https://bugs.webkit.org/show_bug.cgi?id=49902
1456 * WebCoreSupport/WebChromeClient.h:
1457 (WebChromeClient::webView):
1459 2011-05-04 Tao Bai <michaelbai@chromium.org>
1461 Reviewed by David Kilzer.
1463 Populate touch-icon url to FrameLoaderClient
1464 https://bugs.webkit.org/show_bug.cgi?id=59143
1466 Respect the interface change in FrameLoaderClient.
1468 * WebCoreSupport/WebFrameLoaderClient.cpp:
1469 (WebFrameLoaderClient::dispatchDidChangeIcons):
1470 * WebCoreSupport/WebFrameLoaderClient.h:
1472 2011-05-02 Jer Noble <jer.noble@apple.com>
1474 Reviewed by Adam Roben.
1476 Implement FULLSCREEN_API on Windows, Part 3: WebKit2
1477 https://bugs.webkit.org/show_bug.cgi?id=59845
1479 Implementation of WebFullScreenController has been moved into WebCore, and
1480 required virutal functions of WebFullScreenControllerClient have been added to
1481 WebView. These functions are mostly simple accessors of existing ivars, but
1482 m_fullScreenElement and its accessors have also been added to WebView.
1484 * WebCoreSupport/WebChromeClient.cpp:
1485 (WebChromeClient::enterFullScreenForElement):
1486 * WebFullScreenController.cpp: Removed.
1487 * WebKit.vcproj/WebKit.vcproj:
1489 (WebView::setFullScreenElement): Added accessor.
1490 (WebVIew::fullScreenElement): Ditto.
1491 (WebView::fullScreenClientWindow): Ditto.
1492 (WebView::fullScreenClientParentWindow): Ditto.
1493 (WebView::fullScreenClientSetParentWindow): Ditto.
1494 (WebView::fullScreenClientWillEnterFullScreen): Pass through to Document.
1495 (WebView::fullScreenClientDidEnterFullScreen): Ditto.
1496 (WebView::fullScreenClientWillExitFullScreen): Ditto.
1497 (WebView::fullScreenClientDidExitFullScreen): Ditto.
1500 2011-05-03 Brian Weinstein <bweinstein@apple.com>
1502 Reviewed by Steve Falkenburg.
1504 REGRESSION(r84990): Nightly builds don't launch on Windows
1505 https://bugs.webkit.org/show_bug.cgi?id=60081
1506 <rdar://problem/9358635>
1508 Fix nightlies on Window by moving the layered window functions to the bottom
1509 of IWebViewPrivate and touch WebKit.idl to make sure Interfaces rebuild.
1511 * Interfaces/IWebViewPrivate.idl: Move functions added in r84990 to the bottom of the file.
1512 * Interfaces/WebKit.idl: Touch to force a rebuild.
1514 2011-05-03 David Kilzer <ddkilzer@apple.com>
1516 <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
1518 Reviewed by Antti Koivisto.
1520 * Interfaces/IWebViewPrivate.idl:
1521 (IWebViewPrivate::httpPipeliningEnabled): Added declaration.
1522 (IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.
1524 (WebView::httpPipeliningEnabled): Added.
1525 (WebView::setHTTPPipeliningEnabled): Added.
1527 (WebView::httpPipeliningEnabled): Added declaration.
1528 (WebView::setHTTPPipeliningEnabled): Added declaration.
1530 2011-05-03 Adam Roben <aroben@apple.com>
1532 Add some missing virtual keywords on derived-class destructors
1534 Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
1535 just matches our style of explicitly marking overrides "virtual".
1537 * WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and
1538 WebInspectorFrontendClient destructors explicitly virtual.
1540 2011-05-03 Adam Roben <aroben@apple.com>
1542 Fix most strict PassOwnPtr violations on Windows
1544 Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
1547 Reviewed by Anders Carlsson.
1549 * WebCoreSupport/WebInspectorClient.h: Made the destructor public, which is required now
1550 that this type is put into a PassOwnPtr. (Previously, only
1551 WebCore::InspectorFrontendClientLocal was put into a [Pass]OwnPtr.)
1553 * FullscreenVideoController.cpp:
1554 * WebCoreSupport/WebFrameLoaderClient.cpp:
1555 * WebCoreSupport/WebInspectorClient.cpp:
1557 * WebHistoryItem.cpp:
1560 2011-05-01 Sam Weinig <sam@webkit.org>
1566 2011-05-01 Patrick Gansterer <paroga@webkit.org>
1568 Reviewed by Adam Barth.
1570 Fix OwnPtr strict issues in windows build
1571 https://bugs.webkit.org/show_bug.cgi?id=59878
1573 * FullscreenVideoController.cpp:
1574 (FullscreenVideoController::FullscreenVideoController):
1575 (FullscreenVideoController::createHUDWindow):
1576 * WebCoreSupport/WebInspectorClient.cpp:
1577 (WebInspectorClient::highlight):
1578 * WebElementPropertyBag.cpp:
1579 (WebElementPropertyBag::WebElementPropertyBag):
1580 * WebNodeHighlight.cpp:
1581 (WebNodeHighlight::update):
1582 * WebNotificationCenter.cpp:
1583 (WebNotificationCenter::WebNotificationCenter):
1587 (WebView::handleMouseEvent):
1588 (WebView::registerEmbeddedViewMIMEType):
1590 2011-04-29 Jer Noble <jer.noble@apple.com>
1592 Reviewed by Adam Roben.
1594 Implement FULLSCREEN_API on Windows, Part 2: WebKit
1595 https://bugs.webkit.org/show_bug.cgi?id=59785
1597 Initial implementation of full screen API on windows. No animation
1598 occurs when entering or exiting full screen. Re-use existing window
1599 classes (MediaPlayerPrivateFullscreenWindow) to host the webView.
1601 * WebCoreSupport/WebChromeClient.cpp:
1602 (WebChromeClient::supportsFullScreenForElement): Call into WebView.
1603 (WebChromeClient::enterFullScreenForElement): Call into WebFullScreenController.
1604 (WebChromeClient::exitFullScreenForElement): Ditto.
1605 * WebFullScreenController.cpp: Added.
1606 (WebFullScreenController::Private::Private): Private data storage class.
1607 (WebFullScreenController::Private::~Private):
1608 (WebFullScreenController::Private::fullscreenClientWndProc): Handle window
1609 message for full screen window.
1610 (WebFullScreenController::WebFullScreenController):
1611 (WebFullScreenController::~WebFullScreenController):
1612 (WebFullScreenController::setElement): Added.
1613 (WebFullScreenController::element): Added.
1614 (WebFullScreenController::isFullScreen): Added.
1615 (WebFullScreenController::enterFullScreen): Create and display full screen
1616 window, moving webView as child window.
1617 (WebFullScreenController::exitFullScreen): Destroy full screen window and
1618 move webView back where we found it.
1619 * WebFullScreenController.h: Added.
1620 * WebKit.vcproj/WebKit.vcproj:
1622 (WebView::keyDown): Handle the ESC key.
1623 (WebView::notifyPreferencesChanged):
1624 (WebView::supportsFullScreenForElement): Do not support full screen if
1625 full screen preference is disabled, or if keyboard access is requested.
1626 (WebView::isFullScreen): Added.
1627 (WebView::fullScreenController): Added.
1630 2011-04-28 Jer Noble <jer.noble@apple.com>
1632 Reviewed by Jon Honeycutt.
1634 Implement FULLSCREEN_API on Windows, Part 1: Stubs
1635 https://bugs.webkit.org/show_bug.cgi?id=59778
1637 Create all the stubs necessary to for enabling FULLSCREEN_API
1638 on Windows. This includes the COM interfaces for preferences and
1639 for overriding full screen behavior in a UI Delegate.
1641 * Interfaces/IWebPreferencesPrivate.idl: Add functions for enabling
1642 full screen preference.
1643 * Interfaces/IWebUIDelegatePrivate.idl: Add functions for overriding
1644 full screen behavior.
1645 * WebCoreSupport/WebChromeClient.cpp:
1646 (WebChromeClient::supportsFullScreenForElement): Added.
1647 (WebChromeClient::enterFullScreenForElement): Added.
1648 (WebChromeClient::exitFullScreenForElement): Added.
1649 * WebCoreSupport/WebChromeClient.h:
1650 * WebPreferenceKeysPrivate.h: Added WebKitFullScreenEnable key.
1651 * WebPreferences.cpp:
1652 (WebPreferences::isFullScreenEnabled): Added. Implements function
1653 defined in IWebUIDelegatePrivate.
1654 (WebPreferences::setFullScreenEnabled): Ditto.
1657 2011-04-28 Adam Barth <abarth@webkit.org>
1659 Reviewed by Eric Seidel.
1662 https://bugs.webkit.org/show_bug.cgi?id=59678
1664 Remove WML-related enumeration.
1666 * Interfaces/IWebFramePrivate.idl:
1668 2011-04-26 Brent Fulgham <bfulgham@webkit.org>
1670 Reviewed by Adam Roben.
1672 Implement a transparent WebView under Windows. This feature
1673 allows the user to create small web-based applications, similar
1674 to the dashboard on Mac OS X.
1675 https://bugs.webkit.org/show_bug.cgi?id=58300
1677 * Interfaces/IWebViewPrivate.idl: Add new set/get accessors to
1678 change the state of a WebView into a Layered Window, or back
1679 into a standard window.
1680 * Interfaces/WebKit.idl: touch to force clean build
1682 (WebView::WebView): Set layered window state in constructor.
1683 (WebView::updateBackingStore): Cleanup old bitmap when finished.
1684 (WebView::performLayeredWindowUpdate): New method to do the work
1685 of calling ::UpdateLayeredWindow for the WebView with proper
1687 (WebView::paint): Small change to prevent accelerated compositing
1688 when using a layered window. DirectX is not compatible with
1689 ::UpdateLayeredWindow (at least currently).
1690 (WebView::WebViewWndProc): Adjust main window procedure to avoid
1691 painting a default background on a layered window (this is handled
1692 by Windows during compositing), and to deal with paint messages
1693 properly in the layered window case.
1694 (WebView::active): The layered window is not a child window,
1695 so the active state logic is slightly different.
1696 (WebView::setUsesLayeredWindow): New set method for layered stated.
1697 When called, it will convert a WebView into a Layered Window.
1698 (WebView::usesLayeredWindow): Accessor
1700 (WebView::setUsesLayeredWindow): Declare new accessor
1701 (WebView::usesLayeredWindow): Declare new accessor
1703 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
1707 * WebCoreSupport/WebEditorClient.h:
1709 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
1711 Reviewed by Sam Weinig.
1713 Add Frame* to the argument lists of canCopyCut and canPaste
1714 https://bugs.webkit.org/show_bug.cgi?id=59153
1716 * WebCoreSupport/WebEditorClient.cpp:
1717 (WebEditorClient::canCopyCut):
1718 (WebEditorClient::canPaste):
1719 * WebCoreSupport/WebEditorClient.h:
1721 2011-04-20 Brent Fulgham <bfulgham@webkit.org>
1723 Reviewed by Martin Robinson.
1725 Provide missing implementation of WebMutableURLRequest::mutableCopy.
1726 This was preventing DumpRenderTree from working properly under
1728 https://bugs.webkit.org/show_bug.cgi?id=59034
1730 * WebMutableURLRequest.cpp:
1731 (WebMutableURLRequest::mutableCopy): Implement cURL version of the
1734 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
1736 Reviewed by Pavel Feldman.
1738 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
1739 https://bugs.webkit.org/show_bug.cgi?id=58883
1741 * WebCoreSupport/WebFrameLoaderClient.h:
1743 2011-04-18 Timothy Hatcher <timothy@apple.com>
1745 Remove the two commands that make en.lproj and copy Localizable.strings.
1747 Rubber-stamped by Adam Roben.
1749 * WebKit.vcproj/WebKitLibPostBuild.cmd:
1751 2011-04-18 Patrick Gansterer <paroga@webkit.org>
1753 Reviewed by Adam Roben.
1755 Include <WebCore/COMPtr.h> instead of "COMPtr.h"
1756 https://bugs.webkit.org/show_bug.cgi?id=58744
1758 * DOMCoreClasses.cpp:
1759 * DOMHTMLClasses.cpp:
1760 * WebActionPropertyBag.cpp:
1761 * WebBackForwardList.cpp:
1762 * WebCoreSupport/WebGeolocationClient.h:
1766 * WebHistoryItem.cpp:
1767 * WebIconDatabase.cpp:
1768 * WebNavigationData.h:
1769 * WebPreferences.cpp:
1771 * WebURLAuthenticationChallenge.cpp:
1772 * WebURLAuthenticationChallengeSender.cpp:
1773 * WebURLAuthenticationChallengeSenderCFNet.cpp:
1774 * WebURLAuthenticationChallengeSenderCurl.cpp:
1777 2011-04-17 Patrick Gansterer <paroga@webkit.org>
1779 Reviewed by Adam Barth.
1781 Rename PLATFORM(CG) to USE(CG)
1782 https://bugs.webkit.org/show_bug.cgi?id=58729
1785 (WebFrame::spoolPages):
1787 * WebPreferences.cpp:
1788 (WebPreferences::setFontSmoothing):
1789 (WebPreferences::setFontSmoothingContrast):
1791 (systemParameterChanged):
1793 2011-04-16 Sam Weinig <sam@webkit.org>
1795 Reviewed by Simon Fraser.
1797 Windows should use WebCore localized strings
1798 <rdar://problem/9119405>
1799 https://bugs.webkit.org/show_bug.cgi?id=58733
1801 * WebCoreSupport/WebEditorClient.cpp:
1802 (undoNameForEditAction):
1803 (WebEditorClient::registerCommandForUndo):
1804 * WebPreferences.cpp:
1805 (WebPreferences::initializeDefaultSettings):
1806 * WebURLResponse.cpp:
1807 (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode):
1808 (WebURLResponse::localizedStringForStatusCode):
1809 Change to use WEB_UI_STRING.
1811 * WebCoreSupport/WebPlatformStrategies.cpp:
1812 * WebCoreSupport/WebPlatformStrategies.h:
1813 Remove the localization strategy in favor of using the default one.
1815 2011-04-16 Patrick Gansterer <paroga@webkit.org>
1817 Reviewed by Eric Seidel.
1819 Rename PLATFORM(CAIRO) to USE(CAIRO)
1820 https://bugs.webkit.org/show_bug.cgi?id=55192
1823 (WebFrame::spoolPages):
1826 2011-04-14 Adam Roben <aroben@apple.com>
1828 Replace some known-to-fail assertions with FIXMEs
1830 These assertions get hit during various layout tests. They indicate that we're sometimes
1831 doing some extra work when a page goes into accelerated compositing mode, but otherwise
1832 there's no bad effect.
1834 See <http://webkit.org/b/58539> for more details.
1836 Rubber-stamped by John Sullivan.
1839 (WebView::paintIntoBackingStore):
1840 (WebView::paintIntoWindow):
1841 Replaced assertions with FIXMEs.
1843 2011-04-13 James Robinson <jamesr@chromium.org>
1845 Reviewed by Simon Fraser.
1847 Allow setting composited backing stores for scrollbars and scroll corners
1848 https://bugs.webkit.org/show_bug.cgi?id=57202
1850 Update WebScrollBar to reflect ScrollableArea interface changes.
1853 (WebScrollBar::invalidateScrollCornerRect):
1854 (WebScrollBar::scrollCornerPresent):
1855 (WebScrollBar::scrollCornerRect):
1857 2011-04-12 Alice Liu <alice.liu@apple.com>
1859 Reviewed by Sam Weinig.
1861 https://bugs.webkit.org/show_bug.cgi?id=58292
1862 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
1864 * Interfaces/IWebPreferencesPrivate.idl: Added prefs.
1865 * Interfaces/WebKit.idl: Touch file to force autogeneration
1866 * WebPreferenceKeysPrivate.h: Add preference key.
1867 * WebPreferences.cpp:
1868 (WebPreferences::initializeDefaultSettings): Initialize setting to false.
1869 (WebPreferences::setLoadsSiteIconsIgnoringImageLoadingPreference): Added setter
1870 (WebPreferences::loadsSiteIconsIgnoringImageLoadingPreference): Added getter
1873 (WebView::notifyPreferencesChanged): Add to settings that get propagated upon changes.
1875 2011-04-11 Alexey Proskuryakov <ap@apple.com>
1877 Reviewed by Maciej Stachowiak.
1879 WebKit2: Cannot use Ctrl-Delete as a custom keyboard shortcut
1880 https://bugs.webkit.org/show_bug.cgi?id=58265
1881 <rdar://problem/9221468>
1883 * WebView.cpp: (WebView::keyDown): Removed special handling of Backspace, which is unnecessary
1884 now that WebCore implements it.
1886 2011-04-06 Brian Weinstein <bweinstein@apple.com>
1888 Reviewed by Adam Roben.
1890 WebKit2: Support Windows 7 Gestures
1891 https://bugs.webkit.org/show_bug.cgi?id=49824
1892 <rdar://problem/8689728>
1894 Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
1895 used in both WebKit and WebKit2.
1897 * WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
1898 * WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
1899 * WindowsTouch.h: Removed.
1901 2011-04-05 Martin Robinson <mrobinson@igalia.com>
1903 Reviewed by Eric Seidel.
1905 [Cairo] Better separate the concerns of GraphicsContextCairo
1906 https://bugs.webkit.org/show_bug.cgi?id=55150
1909 (hdcFromContext): Modify this method to take PlatformContextCairo
1910 instead of a cairo_t.
1911 (WebFrame::spoolPage): Update to reflect new platform context.
1912 (WebFrame::spoolPages): Ditto.
1913 * WebFrame.h: Ditto.
1915 2011-04-04 MORITA Hajime <morrita@google.com>
1917 Reviewed by Ryosuke Niwa.
1919 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
1920 https://bugs.webkit.org/show_bug.cgi?id=56085
1922 * WebCoreSupport/WebEditorClient.h:
1923 (WebEditorClient::requestCheckingOfString):
1925 2011-04-04 Alexey Proskuryakov <ap@apple.com>
1927 Reviewed by Dan Bernstein.
1929 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
1930 https://bugs.webkit.org/show_bug.cgi?id=51230
1931 <rdar://problem/8780989>
1933 * WebView.cpp: (WebView::keyDown): Moved Caps Lock handling from WebKits to WebCore,
1934 because WebKit shouldn't be smart.
1936 2011-04-04 Steve Falkenburg <sfalken@apple.com>
1938 Reviewed by Adam Roben.
1940 Remove unused AnalyzeWithLargeStack code from Windows build files
1941 https://bugs.webkit.org/show_bug.cgi?id=57771
1943 This was used for us to build with prefast automatically,
1944 but it is out-of-date and hasn't been used for some time.
1945 Removing completely for now.
1947 * WebKit.vcproj/WebKitLibPreBuild.cmd:
1949 2011-04-01 Adam Roben <aroben@apple.com>
1951 Remove the WebView's "this" pointer from its HWND when WM_DESTROY is received
1953 This will ensure we don't try to process any window messages after the window has been
1956 Covered by existing tests.
1958 Fixes <http://webkit.org/b/55054>.
1960 Reviewed by Steve Falkenburg and John Sullivan.
1963 (WebView::setIsBeingDestroyed): Moved here from the header file, and added a call to clear
1964 out the this pointer from the HWND.
1965 (WebView::WebViewWndProc): Changed a runtime check into an assertion.
1967 * WebView.h: Moved setIsBeingDestroyed from here to the .cpp file.
1969 2011-03-31 Evan Martin <evan@chromium.org>
1971 Reviewed by Eric Seidel.
1973 <title> should support dir attribute
1974 https://bugs.webkit.org/show_bug.cgi?id=50961
1976 Update to new FrameLoaderClient interface.
1978 * WebCoreSupport/WebFrameLoaderClient.cpp:
1979 (WebFrameLoaderClient::dispatchDidReceiveTitle):
1980 * WebCoreSupport/WebFrameLoaderClient.h:
1982 2011-03-30 Steve Falkenburg <sfalken@apple.com>
1984 Reviewed by Adam Roben.
1986 Share most vsprops between Release and Production builds in releaseproduction.vsprops
1987 https://bugs.webkit.org/show_bug.cgi?id=57508
1989 * WebKit.vcproj/InterfacesProduction.vsprops:
1990 * WebKit.vcproj/InterfacesRelease.vsprops:
1991 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
1992 * WebKit.vcproj/WebKitGUIDProduction.vsprops:
1993 * WebKit.vcproj/WebKitGUIDRelease.vsprops:
1994 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
1995 * WebKit.vcproj/WebKitLibProduction.vsprops:
1996 * WebKit.vcproj/WebKitLibRelease.vsprops:
1997 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:
1999 2011-03-30 Steve Falkenburg <sfalken@apple.com>
2001 Reviewed by Adam Roben.
2003 Update Windows production build logic for new production configurations
2004 https://bugs.webkit.org/show_bug.cgi?id=57494
2006 * WebKit.vcproj/InterfacesProduction.vsprops:
2007 * WebKit.vcproj/WebKit.make:
2008 * WebKit.vcproj/WebKitGUIDProduction.vsprops:
2009 * WebKit.vcproj/WebKitLibProduction.vsprops:
2011 2011-03-30 Steve Falkenburg <sfalken@apple.com>
2013 Reviewed by Adam Roben.
2015 Rename Windows configuration Release_LTCG to Production for clarity
2016 https://bugs.webkit.org/show_bug.cgi?id=57465
2018 * WebKit.vcproj/Interfaces.vcproj:
2019 * WebKit.vcproj/InterfacesProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/InterfacesReleaseLTCG.vsprops.
2020 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Removed.
2021 * WebKit.vcproj/WebKit.sln:
2022 * WebKit.vcproj/WebKit.submit.sln:
2023 * WebKit.vcproj/WebKit.vcproj:
2024 * WebKit.vcproj/WebKitGUID.vcproj:
2025 * WebKit.vcproj/WebKitGUIDProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops.
2026 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Removed.
2027 * WebKit.vcproj/WebKitLibProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitLibReleaseLTCG.vsprops.
2028 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Removed.
2030 2011-03-29 Patrick Gansterer <paroga@webkit.org>
2032 Reviewed by Adam Roben.
2034 [WIN] Remove unused GEN_DOMObject files
2035 https://bugs.webkit.org/show_bug.cgi?id=57370
2037 * GEN_DOMObject.cpp: Removed.
2038 * GEN_DOMObject.h: Removed.
2040 2011-03-29 Steve Falkenburg <sfalken@apple.com>
2044 * WebCoreSupport/WebPlatformStrategies.h:
2046 2011-03-29 Steve Falkenburg <sfalken@apple.com>
2050 * WebCoreSupport/WebPlatformStrategies.cpp:
2051 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
2053 2011-03-29 Patrick Gansterer <paroga@webkit.org>
2055 Unreviewed. Try to fix Windows build.
2057 * DOMEventsClasses.cpp: Added initguid.h again.
2059 2011-03-29 Patrick Gansterer <paroga@webkit.org>
2061 Reviewed by Adam Roben.
2063 [WIN] Cleanup includes in WebKit files
2064 https://bugs.webkit.org/show_bug.cgi?id=57381
2066 Add missing includes to fix build without precompiled header.
2067 Also fix paths in #include statements (e.g. WTF -> wtf).
2070 * AccessibleDocument.h: Replace using statement with a qualified name.
2071 * CFDictionaryPropertyBag.h:
2072 * DOMEventsClasses.cpp:
2074 * DefaultDownloadDelegate.cpp:
2075 * DefaultDownloadDelegate.h:
2076 * DefaultPolicyDelegate.cpp:
2077 * DefaultPolicyDelegate.h:
2078 * WebCoreSupport/EmbeddedWidget.h:
2079 * WebCoreSupport/WebInspectorDelegate.h:
2081 * WebDatabaseManager.h:
2082 * WebElementPropertyBag.h:
2083 * WebFramePolicyListener.h:
2084 * WebGeolocationPolicyListener.h:
2086 * WebKitClassFactory.h:
2088 * WebSerializedJSValue.h:
2089 * WebUserContentURLPattern.h:
2091 2011-03-29 Steve Falkenburg <sfalken@apple.com>
2093 Reviewed by Darin Adler.
2095 Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
2096 https://bugs.webkit.org/show_bug.cgi?id=57383
2098 Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
2099 InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
2100 the IDE. To avoid this, add a separate vsprops file for each project configuration that
2101 contains the required inherited property sheets.
2103 * WebKit.vcproj/Interfaces.vcproj:
2104 * WebKit.vcproj/InterfacesDebug.vsprops: Added.
2105 * WebKit.vcproj/InterfacesDebugAll.vsprops: Added.
2106 * WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops: Added.
2107 * WebKit.vcproj/InterfacesRelease.vsprops: Added.
2108 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: Added.
2109 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Added.
2110 * WebKit.vcproj/WebKit.vcproj:
2111 * WebKit.vcproj/WebKitGUID.vcproj:
2112 * WebKit.vcproj/WebKitGUIDDebug.vsprops: Added.
2113 * WebKit.vcproj/WebKitGUIDDebugAll.vsprops: Added.
2114 * WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops: Added.
2115 * WebKit.vcproj/WebKitGUIDRelease.vsprops: Added.
2116 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: Added.
2117 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Added.
2118 * WebKit.vcproj/WebKitLibDebug.vsprops: Added.
2119 * WebKit.vcproj/WebKitLibDebugAll.vsprops: Added.
2120 * WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Added.
2121 * WebKit.vcproj/WebKitLibRelease.vsprops: Added.
2122 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Added.
2123 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Added.
2125 2011-03-29 Patrick Gansterer <paroga@webkit.org>
2127 Reviewed by Adam Roben.
2129 Remove #pragma warning push and pop statements
2130 https://bugs.webkit.org/show_bug.cgi?id=57198
2132 We do not need to disable warnings via #pragma since we started
2133 compiling WebCore with the same compiler warnings flags as WebKit.
2135 * DOMCSSClasses.cpp:
2136 * DOMCoreClasses.cpp:
2137 * DOMEventsClasses.cpp:
2138 * DOMHTMLClasses.cpp:
2139 * DefaultDownloadDelegate.cpp:
2140 * DefaultPolicyDelegate.cpp:
2141 * MarshallingHelpers.cpp:
2142 * WebActionPropertyBag.cpp:
2143 * WebActionPropertyBag.h:
2145 * WebCoreSupport/WebDragClient.cpp:
2146 * WebCoreSupport/WebEditorClient.cpp:
2147 * WebCoreSupport/WebEditorClient.h:
2148 * WebCoreSupport/WebFrameLoaderClient.cpp:
2149 * WebCoreSupport/WebFrameLoaderClient.h:
2150 * WebCoreSupport/WebInspectorClient.cpp:
2151 * WebDocumentLoader.h:
2153 * WebDownloadCFNet.cpp:
2154 * WebDownloadCurl.cpp:
2155 * WebElementPropertyBag.cpp:
2160 * WebFramePolicyListener.cpp:
2161 * WebFramePolicyListener.h:
2163 * WebHistoryItem.cpp:
2164 * WebIconDatabase.cpp:
2165 * WebIconDatabase.h:
2167 * WebJavaScriptCollector.cpp:
2168 * WebKitGraphics.cpp:
2169 * WebKitSystemBits.cpp:
2170 * WebLocalizableStrings.cpp:
2171 * WebMutableURLRequest.cpp:
2172 * WebMutableURLRequest.h:
2173 * WebNodeHighlight.cpp:
2174 * WebNodeHighlight.h:
2175 * WebNotificationCenter.cpp:
2180 * WebURLAuthenticationChallenge.cpp:
2181 * WebURLAuthenticationChallenge.h:
2182 * WebURLAuthenticationChallengeSender.cpp:
2183 * WebURLAuthenticationChallengeSenderCFNet.cpp:
2184 * WebURLAuthenticationChallengeSenderCurl.cpp:
2185 * WebURLCredential.cpp:
2186 * WebURLCredential.h:
2187 * WebURLProtectionSpace.cpp:
2188 * WebURLProtectionSpace.h:
2189 * WebURLResponse.cpp:
2192 2011-03-29 Brent Fulgham <bfulgham@webkit.org>
2194 Unreviewed build fix after r82247.
2196 * WebMutableURLRequest.cpp: The new CertificateCFWin routines
2197 are not CFNetwork-specific. All CF-based ports can use them.
2199 2011-03-29 Patrick Gansterer <paroga@webkit.org>
2201 Reviewed by Adam Roben.
2203 [WIN] Use WCHAR instead of TCHAR
2204 https://bugs.webkit.org/show_bug.cgi?id=57191
2206 We always use the UNICODE versions of windows functions, so
2207 the usage of TCHAR makes no sense and mixing them is bad style.
2209 * DefaultDownloadDelegate.cpp:
2210 * WebCoreSupport/WebChromeClient.cpp:
2211 * WebCoreSupport/WebContextMenuClient.cpp:
2212 * WebCoreSupport/WebInspectorClient.cpp:
2214 * WebNotificationCenter.cpp:
2215 * WebPreferences.cpp:
2216 * WebURLResponse.cpp:
2219 2011-03-29 Jeff Miller <jeffm@apple.com>
2221 Reviewed by Jon Honeycutt.
2223 Add WebCore::copyCertificateToData() on Windows
2224 https://bugs.webkit.org/show_bug.cgi?id=57296
2226 Remove duplicate code that implemented this functionality in WebMutableURLRequest.cpp and use WebCore::copyCertificateToData() instead.
2228 * WebMutableURLRequest.cpp:
2229 (WebMutableURLRequest::setClientCertificate): Use WebCore::copyCertificateToData().
2231 2011-03-28 Patrick Gansterer <paroga@webkit.org>
2233 Reviewed by Adam Roben.
2235 [WIN] Remove unused DOMCreateInstance files
2236 https://bugs.webkit.org/show_bug.cgi?id=57193
2238 * DOMCreateInstance.cpp: Removed.
2239 * DOMCreateInstance.h: Removed.
2241 2011-03-28 Adele Peterson <adele@apple.com>
2245 * WebFrame.cpp: (WebFrame::hasSpellingMarker):
2246 Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
2248 2011-03-28 Jeff Miller <jeffm@apple.com>
2250 Reviewed by Adam Roben.
2252 Include certificate when sending a WebCore::ResourceError to UI process on Windows
2253 https://bugs.webkit.org/show_bug.cgi?id=57195
2255 Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*.
2258 (WebError::sslPeerCertificate):
2259 * WebURLResponse.cpp:
2260 (WebURLResponse::sslPeerCertificate):
2262 2011-03-28 Darin Adler <darin@apple.com>
2264 Set eol-style to native on more files. I noticed the last check-in had an entire file
2265 changing because of an EOL style change, and setting this property prevents that from
2266 happening in future. We may want to do this systematically for more of WebKit later.
2268 * AccessibleBase.cpp: Added property svn:eol-style.
2269 * AccessibleBase.h: Added property svn:eol-style.
2270 * AccessibleDocument.cpp: Added property svn:eol-style.
2271 * AccessibleDocument.h: Added property svn:eol-style.
2272 * AccessibleImage.cpp: Added property svn:eol-style.
2273 * AccessibleImage.h: Added property svn:eol-style.
2274 * COMVariantSetter.h: Added property svn:eol-style.
2275 * FullscreenVideoController.cpp: Added property svn:eol-style.
2276 * FullscreenVideoController.h: Added property svn:eol-style.
2277 * WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
2278 * WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
2279 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
2280 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
2281 * WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
2282 * WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
2283 * WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
2284 * WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
2285 * WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
2286 * WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
2287 * WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.
2289 2011-03-28 Patrick Gansterer <paroga@webkit.org>
2291 Unreviewed build fix.
2293 * COMPropertyBag.h: Added missing include.
2294 * WebKitCOMAPI.h: Ditto.
2295 * WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration.
2297 2011-03-25 Sam Weinig <sam@webkit.org>
2299 Reviewed by Jon Honeycutt.
2301 WebScrollBar not updating when calling WebScrollBar::setValue.
2302 <rdar://problem/9143871>
2305 (WebScrollBar::setValue):
2306 Call scrollToOffsetWithoutAnimation to actually update the scroll position.
2308 2011-03-25 Andy Estes <aestes@apple.com>
2310 Reviewed by Adele Peterson.
2312 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2313 https://bugs.webkit.org/show_bug.cgi?id=49016
2315 Update objectContentType() implementation to handle the
2316 shouldPreferPlugInsForImages flag.
2319 (WebFrame::objectContentType):
2322 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
2324 Unreviewed, rolling out r81916 and r81917.
2325 http://trac.webkit.org/changeset/81916
2326 http://trac.webkit.org/changeset/81917
2327 https://bugs.webkit.org/show_bug.cgi?id=57071
2329 broke a test on platforms that do not have QuickTime installed
2330 (Requested by estes on #webkit).
2333 (WebFrame::objectContentType):
2336 2011-03-24 Andy Estes <aestes@apple.com>
2338 Reviewed by Darin Adler.
2340 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2341 https://bugs.webkit.org/show_bug.cgi?id=49016
2343 Update objectContentType() implementation to handle the
2344 shouldPreferPlugInsForImages flag.
2347 (WebFrame::objectContentType):
2350 2011-03-23 Brady Eidson <beidson@apple.com>
2352 Reviewed by Sam Weinig.
2354 Change IconDatabase opening to allow for arbitrary filenames
2355 https://bugs.webkit.org/show_bug.cgi?id=56977
2357 * WebIconDatabase.cpp:
2358 (WebIconDatabase::startUpIconDatabase):
2360 2011-03-22 Brady Eidson <beidson@apple.com>
2362 Reviewed by Sam Weinig.
2364 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
2365 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
2367 Note that while the new client calls always come through on the main thread, our mechanisms to
2368 route dispatches to the main thread are still valid and will still work.
2370 Update to the new IconDatabaseClient interface:
2371 * WebIconDatabase.cpp:
2372 (WebIconDatabase::performImport):
2373 (WebIconDatabase::didRemoveAllIcons):
2374 (WebIconDatabase::didImportIconURLForPageURL):
2375 (WebIconDatabase::didImportIconDataForPageURL):
2376 (WebIconDatabase::didChangeIconForPageURL):
2377 (WebIconDatabase::didFinishURLImport):
2378 * WebIconDatabase.h:
2380 2011-03-17 Brady Eidson <beidson@apple.com>
2382 Reviewed by Sam Weinig.
2384 https://bugs.webkit.org/show_bug.cgi?id=56425
2385 More groundwork for WebKit2 IconDatabase
2387 Update already-used function names:
2388 * WebIconDatabase.cpp:
2389 (WebIconDatabase::iconForURL):
2390 (WebIconDatabase::iconURLForURL):
2391 (WebIconDatabase::hasIconForURL):
2393 2011-03-18 Pavel Podivilov <podivilov@chromium.org>
2395 Reviewed by Yury Semikhatsky.
2397 Web Inspector: implement inspector session storage.
2398 https://bugs.webkit.org/show_bug.cgi?id=56643
2400 * WebCoreSupport/WebInspectorClient.cpp:
2401 (WebInspectorClient::saveSessionSetting):
2402 (WebInspectorClient::loadSessionSetting):
2403 (WebInspectorFrontendClient::saveSessionSetting):
2404 (WebInspectorFrontendClient::loadSessionSetting):
2405 * WebCoreSupport/WebInspectorClient.h:
2407 2011-03-11 Brady Eidson <beidson@apple.com>
2409 More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
2411 * WebCoreStatistics.cpp:
2412 * WebIconDatabase.cpp:
2414 2011-03-09 Peter Kasting <pkasting@google.com>
2416 Reviewed by Mihai Parparita.
2418 Unify Windows version checks.
2419 https://bugs.webkit.org/show_bug.cgi?id=55979
2422 (WebView::standardUserAgentWithApplicationName):
2423 (webKitVersionString):
2425 2011-03-07 Sam Weinig <sam@webkit.org>
2427 Reviewed by Anders Carlsson.
2429 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2430 https://bugs.webkit.org/show_bug.cgi?id=55827
2432 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2433 and pass the entire response, instead of just the MIMEType.
2436 (WebFrame::dispatchDecidePolicyForResponse):
2439 2011-03-04 Steve Falkenburg <sfalken@apple.com>
2441 Reviewed by Darin Adler.
2443 Adopt VersionStamper tool for Windows WebKit DLLs
2444 https://bugs.webkit.org/show_bug.cgi?id=55784
2446 Calculate the WebKit version for the useragent via autoversion.h
2447 instead of reading it back from the DLL.
2449 We now use a tool to stamp the version number onto the Apple WebKit DLLs
2450 during the post-build step.
2452 * WebKit.vcproj/WebKit.rc: Removed. This file wasn't used.
2453 * WebKit.vcproj/WebKitLibCommon.vsprops: Fetch version from a string resource.
2455 (WebView::standardUserAgentWithApplicationName): Use __BUILD_NUMBER_SHORT__ for the version.
2456 (osVersion): Removed
2458 2011-03-03 Anders Carlsson <andersca@apple.com>
2460 Reviewed by Sam Weinig.
2462 Get rid of Page::globalHistoryItem
2463 https://bugs.webkit.org/show_bug.cgi?id=55738
2465 * WebCoreSupport/WebFrameLoaderClient.cpp:
2466 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
2467 Get the current history item and update it using WebView::setGlobalHistoryItem.
2469 * WebCoreSupport/WebFrameLoaderClient.h:
2471 (WebView::globalHistoryItem):
2472 (WebView::setGlobalHistoryItem):
2475 2011-03-03 Brent Fulgham <bfulgham@webkit.org>
2477 Unreviewed build correction.
2480 (scaleFactor): Update after 77286 to replace right/bottom
2481 with new maxX/maxY terminology.
2483 2011-03-03 Brady Eidson <beidson@apple.com>
2485 Reviewed by Darin Adler.
2487 https://bugs.webkit.org/show_bug.cgi?id=55721
2488 Global IconDatabase should be returned by reference, not as a pointer
2490 * WebCoreStatistics.cpp:
2491 (WebCoreStatistics::iconPageURLMappingCount):
2492 (WebCoreStatistics::iconRetainedPageURLCount):
2493 (WebCoreStatistics::iconRecordCount):
2494 (WebCoreStatistics::iconsWithDataCount):
2495 * WebIconDatabase.cpp:
2496 (WebIconDatabase::init):
2497 (WebIconDatabase::startUpIconDatabase):
2498 (WebIconDatabase::iconForURL):
2499 (WebIconDatabase::retainIconForURL):
2500 (WebIconDatabase::releaseIconForURL):
2501 (WebIconDatabase::removeAllIcons):
2502 (WebIconDatabase::iconURLForURL):
2503 (WebIconDatabase::isEnabled):
2504 (WebIconDatabase::setEnabled):
2505 (WebIconDatabase::hasIconForURL):
2506 (WebIconDatabase::getOrCreateDefaultIconBitmap):
2510 2011-03-03 Alexey Proskuryakov <ap@apple.com>
2512 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
2515 * WebCoreSupport/WebChromeClient.h:
2517 2011-03-02 Alexey Proskuryakov <ap@apple.com>
2519 Reviewed by Darin Adler.
2521 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
2522 https://bugs.webkit.org/show_bug.cgi?id=55633
2523 <rdar://problem/8963023>
2525 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::keyboardUIMode):
2526 * WebCoreSupport/WebChromeClient.h:
2527 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
2528 this platform doesn't observe or have full keyboard access state.
2530 2011-03-03 Peter Kasting <pkasting@google.com>
2532 Reviewed by James Robinson.
2534 Drop redundant "Windows; " from the Windows-specific User Agent string.
2535 https://bugs.webkit.org/show_bug.cgi?id=54567
2538 (WebView::standardUserAgentWithApplicationName):
2540 2011-03-01 Brian Weinstein <bweinstein@apple.com>
2542 Reviewed by Adam Roben.
2544 Part of WebKit2: Need a way to send notifications to client when cookies change
2545 https://bugs.webkit.org/show_bug.cgi?id=55427
2546 <rdar://problem/9056027>
2548 Add stubs for CookiesStrategy on Windows WebKit1.
2550 * WebCoreSupport/WebPlatformStrategies.cpp:
2551 (WebPlatformStrategies::createCookiesStrategy):
2552 (WebPlatformStrategies::notifyCookiesChanged):
2553 * WebCoreSupport/WebPlatformStrategies.h:
2555 2011-02-28 Chang Shu <cshu@webkit.org>
2557 Reviewed by Ryosuke Niwa.
2559 Remove the support of Frame::isContentEditable and its dependencies.
2560 https://bugs.webkit.org/show_bug.cgi?id=54292
2562 Remove the WebKit side implementation.
2564 * WebCoreSupport/WebEditorClient.cpp:
2565 * WebCoreSupport/WebEditorClient.h:
2567 2011-02-28 Adam Roben <aroben@apple.com>
2569 Build TestWebKitAPIInjectedBundle on Windows
2571 Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
2573 Reviewed by Darin Adler.
2575 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPIInjectedBundle. Let VS simplify the paths to
2578 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
2580 Unreviewed, rolling out r78789.
2581 http://trac.webkit.org/changeset/78789
2582 https://bugs.webkit.org/show_bug.cgi?id=55409
2584 Incorrect canvas fallback implementation (Requested by
2585 inferno-sec on #webkit).
2587 * AccessibleBase.cpp:
2590 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2592 Reviewed by Pavel Feldman.
2594 DumpRenderTree should reset frame opener between tests.
2595 https://bugs.webkit.org/show_bug.cgi?id=54874
2597 Added clearOpener method to IWebFramePrivate.
2598 Touched WebKit.idl to trigger build scripts.
2600 * Interfaces/IWebFramePrivate.idl:
2601 * Interfaces/WebKit.idl:
2603 (WebFrame::clearOpener):
2606 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
2608 Unreviewed, rolling out r79764.
2609 http://trac.webkit.org/changeset/79764
2610 https://bugs.webkit.org/show_bug.cgi?id=55295
2612 "broke Chromium builds" (Requested by rniwa on #webkit).
2614 * Interfaces/IWebFramePrivate.idl:
2615 * Interfaces/WebKit.idl:
2619 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
2621 Reviewed by Pavel Feldman.
2623 DumpRenderTree should reset frame opener between tests.
2624 https://bugs.webkit.org/show_bug.cgi?id=54874
2626 Added clearOpener method to IWebFramePrivate.
2627 Touched WebKit.idl to trigger build scripts.
2629 * Interfaces/IWebFramePrivate.idl:
2630 * Interfaces/WebKit.idl:
2632 (WebFrame::clearOpener):
2635 2011-02-24 Peter Kasting <pkasting@google.com>
2637 Reviewed by Eric Seidel.
2639 Drop the "U; " encryption level from the User Agent string.
2640 https://bugs.webkit.org/show_bug.cgi?id=54566
2643 (WebView::standardUserAgentWithApplicationName):
2645 2011-02-24 Andrew Wilson <atwilson@chromium.org>
2647 Unreviewed, rolling out r79570.
2648 http://trac.webkit.org/changeset/79570
2649 https://bugs.webkit.org/show_bug.cgi?id=54874
2651 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
2654 * Interfaces/IWebFramePrivate.idl:
2655 * Interfaces/WebKit.idl:
2659 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
2661 Reviewed by Alexey Proskuryakov.
2663 DumpRenderTree should reset frame opener between tests.
2664 https://bugs.webkit.org/show_bug.cgi?id=54874
2666 Added clearOpener method to IWebFramePrivate.
2667 Touched WebKit.idl to trigger build scripts.
2669 * Interfaces/IWebFramePrivate.idl:
2670 * Interfaces/WebKit.idl:
2672 (WebFrame::clearOpener):
2675 2011-02-23 Patrick Gansterer <paroga@webkit.org>
2677 Reviewed by Darin Adler.
2679 Rename PLATFORM(CF) to USE(CF)
2680 https://bugs.webkit.org/show_bug.cgi?id=53540
2684 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2686 Reviewed by Alexey Proskuryakov.
2688 Drop the language tag part from the User Agent string
2689 https://bugs.webkit.org/show_bug.cgi?id=54560
2692 (WebView::standardUserAgentWithApplicationName):
2694 2011-02-19 Charlie Reis <creis@chromium.org>
2696 Reviewed by Mihai Parparita.
2698 Ensure loading has stopped in HistoryController::goToItem
2699 https://bugs.webkit.org/show_bug.cgi?id=54517
2701 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
2703 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
2705 * WebCoreSupport/WebFrameLoaderClient.cpp:
2706 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
2707 * WebCoreSupport/WebFrameLoaderClient.h:
2709 2011-02-16 David Hyatt <hyatt@apple.com>
2711 Reviewed by Dan Bernstein.
2713 https://bugs.webkit.org/show_bug.cgi?id=54244
2715 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
2716 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
2718 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
2719 been changed as well.
2721 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
2723 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
2725 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
2726 still have a precise floating point position.
2728 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
2729 be rounding justification spacing in their font code.
2731 Many layout test results change on Mac, since rounding hacks were used there and are now gone.
2733 * WebKitGraphics.cpp:
2734 (CenterTruncateStringToWidth):
2735 (RightTruncateStringToWidth):
2737 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
2739 Reviewed by Adam Roben.
2741 HTML5 <details> and <summary>: localized text
2742 https://bugs.webkit.org/show_bug.cgi?id=54260
2744 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
2745 provide the default label to be used by a <details> tag that has no <summary> child.
2747 * WebCoreSupport/WebPlatformStrategies.cpp:
2748 (WebPlatformStrategies::defaultDetailsSummaryText):
2749 * WebCoreSupport/WebPlatformStrategies.h:
2751 2011-02-16 Dominic Mazzoni <dmazzoni@google.com>
2753 Reviewed by Chris Fleizach.
2755 Add new role for canvas elements.
2757 https://bugs.webkit.org/show_bug.cgi?id=50126
2759 Test: accessibility/canvas-fallback-content.html
2761 * AccessibleBase.cpp:
2764 2011-02-15 Kenneth Russell <kbr@google.com>
2766 Unreviewed. Remove whitespace-only change from
2767 http://trac.webkit.org/changeset/78620 (https://bugs.webkit.org/show_bug.cgi?id=54312)
2768 now that the patch has passed the Windows build bots.
2770 * Interfaces/WebKit.idl:
2772 2011-02-15 Kenneth Russell <kbr@google.com>
2774 Reviewed by Darin Fisher.
2776 Allow controlling minimum DOMTimer interval on a per-page basis
2777 https://bugs.webkit.org/show_bug.cgi?id=54312
2779 Added needed methods to implement LayoutTestController's new
2780 setMinimumTimerInterval method. Includes whitespace-only change to
2781 WebKit.idl to trigger proper rebuild on bots; will be removed in
2784 * Interfaces/IWebViewPrivate.idl:
2785 * Interfaces/WebKit.idl:
2787 (WebView::initWithFrame):
2788 (WebView::defaultMinimumTimerInterval):
2789 (WebView::setMinimumTimerInterval):
2792 2011-01-26 MORITA Hajime <morrita@google.com>
2794 Reviewed by Ryosuke Niwa.
2796 Refactoring: Extract TextCheckerClient from EditorClient
2797 https://bugs.webkit.org/show_bug.cgi?id=53213
2799 * WebCoreSupport/WebEditorClient.h:
2800 (WebEditorClient::textChecker):
2802 2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
2804 Reviewed by Adam Barth.
2806 Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
2807 https://bugs.webkit.org/show_bug.cgi?id=52417
2809 Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
2812 * WebCoreSupport/WebEditorClient.cpp:
2813 (WebEditorClient::canCopyCut): Added.
2814 (WebEditorClient::canPaste): Added.
2815 * WebCoreSupport/WebEditorClient.h:
2817 2011-02-14 Brian Weinstein <bweinstein@apple.com>
2819 Reviewed by Brady Eidson.
2821 Need WebKit API to determine whether we have a site icon for a given URL
2822 https://bugs.webkit.org/show_bug.cgi?id=54400
2824 This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
2825 we have a site icon for the given URL.
2827 * Interfaces/IWebIconDatabase.idl: Added new function.
2828 * Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
2829 * WebIconDatabase.cpp:
2830 (WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we
2831 load the icon from disk, and call iconURLForPageURL to determine whether or not
2832 we actually have an icon.
2833 * WebIconDatabase.h:
2835 2011-02-11 Geoffrey Garen <ggaren@apple.com>
2837 Reviewed by Oliver Hunt.
2839 A little more encapsulation for the heap: Removed CollectorHeapIterator
2840 https://bugs.webkit.org/show_bug.cgi?id=54298
2842 * WebCoreStatistics.cpp:
2843 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
2845 2011-02-09 Pavel Feldman <pfeldman@chromium.org>
2847 Reviewed by Yury Semikhatsky.
2849 Web Inspector: follow up on InspectorAgent split -
2850 removing unnecessary methods from InspectorController.
2851 https://bugs.webkit.org/show_bug.cgi?id=54093
2854 (WebInspector::showConsole):
2855 (WebInspector::toggleProfilingJavaScript):
2857 2011-02-08 Adam Barth <abarth@webkit.org>
2859 Reviewed by Eric Seidel.
2861 Remove orphan code from old parser
2862 https://bugs.webkit.org/show_bug.cgi?id=53984
2864 * WebCoreSupport/WebChromeClient.h:
2866 2011-02-08 David Hyatt <hyatt@apple.com>
2868 Reviewed by Adam Roben.
2870 <rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed
2872 Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
2873 value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
2877 (WebFrame::setPrinting):
2878 (WebFrame::setInPrintingMode):
2881 2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
2883 Reviewed by Yury Semikhatsky.
2885 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
2887 https://bugs.webkit.org/show_bug.cgi?id=53169
2889 Minor change enforced by major changes in WebCore/inspector/InspectorController.
2892 (WebInspector::isTimelineProfilingEnabled):
2894 2011-02-07 Enrica Casucci <enrica@apple.com>
2896 Reviewed Adam Roben and Darin Adler.
2898 WebKit2: drag and drop support on Windows.
2899 https://bugs.webkit.org/show_bug.cgi?id=52775
2901 Removed createDragImageForLink from DragClient.
2903 * WebCoreSupport/WebDragClient.cpp:
2904 (WebDragClient::startDrag):
2905 * WebCoreSupport/WebDragClient.h:
2907 2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
2909 Reviewed by Darin Adler.
2911 OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
2912 https://bugs.webkit.org/show_bug.cgi?id=52867
2915 (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
2916 * WebPreferences.cpp:
2917 (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.
2919 2011-02-03 Yury Semikhatsky <yurys@chromium.org>
2921 Reviewed by Pavel Feldman.
2923 Web Inspector: remove settings related methods from InspectorClient
2924 https://bugs.webkit.org/show_bug.cgi?id=53686
2926 * WebCoreSupport/WebInspectorClient.cpp:
2927 (WebInspectorClient::openInspectorFrontend):
2928 (WebInspectorFrontendClient::WebInspectorFrontendClient):
2929 * WebCoreSupport/WebInspectorClient.h:
2931 2011-02-03 Adam Langley <agl@chromium.org>
2933 Reviewed by Adam Barth.
2935 Plumb mixed script URL to FrameLoaderClient
2936 https://bugs.webkit.org/show_bug.cgi?id=52384
2938 Regressions covered by http/tests/security/mixedContent/*
2940 * WebCoreSupport/WebFrameLoaderClient.cpp:
2941 (WebFrameLoaderClient::didRunInsecureContent):
2942 * WebCoreSupport/WebFrameLoaderClient.h:
2944 2011-02-02 David Hyatt <hyatt@apple.com>
2946 Reviewed by Darin Adler.
2948 Removal of right()/bottom(), converting to maxX()/maxY().
2950 * DOMHTMLClasses.cpp:
2951 (DOMHTMLInputElement::rectOnScreen):
2952 * WebCoreSupport/EmbeddedWidget.cpp:
2953 (EmbeddedWidget::frameRectsChanged):
2955 (WebFrame::computePageRects):
2957 (WebScrollBar::frameRect):
2959 (WebView::addToDirtyRegion):
2960 (WebView::visibleContentRect):
2961 (WebView::prepareCandidateWindow):
2963 2011-01-31 Brady Eidson <beidson@apple.com>
2965 Reviewed by Adam Roben.
2967 Fix the clean Windows build.
2969 * WebKitGraphics.cpp:
2972 2011-01-28 Jon Honeycutt <jhoneycutt@apple.com>
2974 Downloads in WK2 on Windows should write resume data to bundle
2975 https://bugs.webkit.org/show_bug.cgi?id=53282
2976 <rdar://problem/8753077>
2978 Reviewed by Alice Liu.
2981 (WebDownload::bundlePathForTargetPath):
2982 Use the new WebCore::DownloadBundle function.
2983 (WebDownload::request):
2986 Removed declarations for functions that were moved to a new location.
2988 * WebDownloadCFNet.cpp:
2989 (WebDownload::initToResumeWithBundle):
2990 Use the new WebCore::DownloadBundle function.
2991 (WebDownload::cancelForResume):
2992 Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
2993 WebCore::DownloadBundle function.
2995 2011-01-28 Dan Bernstein <mitz@apple.com>
2997 Reviewed by Sam Weinig.
2999 <select> can't display right-to-left (rtl) languages
3000 https://bugs.webkit.org/show_bug.cgi?id=19785
3002 * WebCoreSupport/WebChromeClient.cpp:
3003 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
3004 * WebCoreSupport/WebChromeClient.h:
3006 2011-01-27 Nate Chapin <japhet@chromium.org>
3008 Reviewed by Adam Barth.
3010 Use Document::url() instead of FrameLoader::url().
3011 https://bugs.webkit.org/show_bug.cgi?id=41165
3016 2011-01-27 Sam Weinig <sam@webkit.org>
3018 Reviewed by Adam Roben.
3020 Fix scrollbars in Safari's Downloads window and Bookmarks view by
3021 implementing two needed functions from ScrollableArea.
3024 (WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if
3025 we are a horizontal scrollbar.
3026 (WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we
3027 are a vertical scrollbar.
3030 2011-01-27 Adam Roben <aroben@apple.com>
3032 Trim down #includes in WebView.h
3034 Rubber-stamped by Steve Falkenburg.
3036 * WebView.cpp: Moved some #includes here from the header file.
3038 * WebView.h: Replaced some broader #includes with more specific ones, plus a
3039 forward-declaration.
3041 2011-01-25 Steve Falkenburg <sfalken@apple.com>
3043 Windows production build fix.
3044 Build correct configuration of Interfaces for Debug_All.
3046 * WebKit.vcproj/WebKit.submit.sln:
3048 2011-01-25 Steve Falkenburg <sfalken@apple.com>
3050 Rubber-stamped by Adam Roben.
3052 Windows production build fix.
3053 Use correct environment variable escaping
3055 * WebKit.vcproj/WebKit.make:
3057 2011-01-24 Chris Marrin <cmarrin@apple.com>
3059 Reviewed by Eric Seidel.
3061 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
3062 https://bugs.webkit.org/show_bug.cgi?id=53041
3065 (WebView::notifyPreferencesChanged):
3067 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
3069 Reviewed by Pavel Feldman.
3071 Web Inspector: remove "attached" state related methods from InspectorAgent
3072 https://bugs.webkit.org/show_bug.cgi?id=53086
3074 * WebCoreSupport/WebInspectorClient.cpp:
3075 (WebInspectorFrontendClient::attachWindow):
3076 (WebInspectorFrontendClient::detachWindow):
3077 (WebInspectorFrontendClient::showWindowWithoutNotifications):
3078 * WebCoreSupport/WebInspectorClient.h:
3080 2011-01-24 Adam Roben <aroben@apple.com>
3082 Windows Production build fix
3084 * WebKit.vcproj/WebKit.make: Update for move of WebKit into Source.
3086 2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
3088 Reviewed by Dirk Schulze.
3090 Introduce FontMetrics abstraction
3091 https://bugs.webkit.org/show_bug.cgi?id=51456
3093 * FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics.
3094 (FullscreenVideoController::draw):
3095 * WebCoreSupport/WebDragClient.cpp: Ditto.
3096 (WebDragClient::createDragImageForLink):
3097 * WebKitGraphics.cpp: Ditto.
3100 2011-01-21 Chris Rogers <crogers@google.com>
3102 Reviewed by Darin Fisher.
3104 Add run-time enable support for the web audio API
3105 https://bugs.webkit.org/show_bug.cgi?id=52741
3107 * WebPreferenceKeysPrivate.h:
3109 (WebView::notifyPreferencesChanged):
3111 2011-01-21 Sam Weinig <sam@webkit.org>
3117 2011-01-21 Sam Weinig <sam@webkit.org>
3119 Reviewed by Anders Carlsson.
3121 Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
3122 https://bugs.webkit.org/show_bug.cgi?id=52779
3124 Rename ScrollbarClient -> ScrollableArea.
3127 (WebScrollBar::scroll):
3130 2011-01-20 Adam Roben <aroben@apple.com>
3132 Update for CACFLayerTreeHost changes
3134 Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
3135 CACFLayerTreeHost, but shouldn't be
3137 Reviewed by Simon Fraser.
3140 (WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
3141 to our own flushing function if needed.
3143 * WebView.h: Removed shouldRender, which is no longer used or needed.
3145 2011-01-21 Adam Roben <aroben@apple.com>
3147 Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename
3149 Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.
3151 Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
3153 Reviewed by Simon Fraser.
3155 * WebPreferences.cpp:
3157 (WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
3158 host before we get rid of the layer tree host itself.
3161 2011-01-21 Adam Roben <aroben@apple.com>
3163 Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"
3165 This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
3166 opposed to just "layer" because there are cases where we flush changes to CACFLayers that
3167 don't have a corresponding GraphicsLayer.
3169 Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
3170 WKCACFLayerRenderer and friends is confusing
3172 Reviewed by Simon Fraser.
3174 * WebCoreSupport/WebChromeClient.cpp:
3175 (WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.
3178 (WebView::paint): Updated for rename.
3179 (WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
3180 (WebView::notifySyncRequired): Updated for rename.
3181 (WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.
3183 * WebView.h: Did the renames.
3185 2011-01-20 Sam Weinig <sam@webkit.org>
3187 Reviewed by Dave Hyatt.
3189 Cleanup Scrollbar/ScrollbarClient relationship
3190 https://bugs.webkit.org/show_bug.cgi?id=52779
3193 (WebScrollBar::WebScrollBar):
3194 (WebScrollBar::setValue):
3195 (WebScrollBar::value):
3196 (WebScrollBar::scroll):
3197 (WebScrollBar::scrollPosition):
3198 (WebScrollBar::setScrollOffset):
3201 2011-01-19 Adam Roben <aroben@apple.com>
3203 Update for WKCACFLayerRenderer changes
3205 Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
3208 Reviewed by Simon Fraser.
3211 (WebView::~WebView): Added some assertions to make sure we've gotten rid of our
3212 compositing-related members. My biggest concern was making sure that m_layerRenderer was
3213 gone, which would also mean we had nulled out its client pointer.
3214 (WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
3215 of passing the client into create(), and to clear out the client before nulling out
3218 * WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
3220 2011-01-19 Adam Roben <aroben@apple.com>
3222 Teach WebView::scrollBackingStore about compositing mode
3225 compositing/scroll-painted-composited-content.html
3227 Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
3228 WebView::scrollBackingStore when scrolling page with composited content
3230 Reviewed by Anders Carlsson.
3233 (WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
3234 mode, rather than incorrectly asserting that this function is never called in that case. For
3235 now we just repaint the entire scrolled region; someday hopefully we can avoid having to
3236 repaint the areas that have just been moved.
3238 2011-01-19 Simon Fraser <simon.fraser@apple.com>
3240 Reviewed by Sam Weinig.
3242 GraphicsLayers in subframes can get sync'd multiple times
3243 https://bugs.webkit.org/show_bug.cgi?id=52489
3246 (WebView::syncCompositingState): syncCompositingStateRecursive()
3247 was renamed to syncCompositingStateIncludingSubframes().
3249 2011-01-17 Adam Roben <aroben@apple.com>
3251 Update for WKCACFLayerRenderer changes
3253 Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use
3255 Reviewed by Chris Marrin.
3258 (WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
3259 when handling WM_SHOWWINDOW. All this did was try to create the
3260 renderer, but it had already been created in setAcceleratedCompositing,
3262 (WebView::setAcceleratedCompositing): Removed call to createRenderer;
3263 setHostWindow does this for us now.
3265 * WebView.h: Removed animationsStarted and layerRendererBecameVisible.
3267 2011-01-17 Adam Roben <aroben@apple.com>
3269 Paint directly into a GraphicsLayer when using accelerated compositing
3271 Before this patch, we were painting into our normal backing store
3272 HBITMAP, wrapping it in a CGImage, and handing it off to Core
3273 Animation. This had at least two disadvantages:
3274 1) The bitmap could be modified while Core Animation was using it.
3275 2) It introduced extra complexity.
3277 When entering accelerated compositing mode, WebView now creates a
3278 GraphicsLayer to draw into. This GraphicsLayer sits between the root
3279 layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
3280 WebView invalidates, it just calls setNeedsDisplayInRect on its
3281 GraphicsLayer. When WebView paints, it just tells its
3282 WKCACFLayerRenderer to paint, which will call back to WebView to draw
3283 into the GraphicsLayer if it has a dirty region. This is very similar
3284 to the current implementation of LayerBackedDrawingArea in WebKit2.
3286 Fixes <http://webkit.org/b/52582> WebView should paint directly into a
3287 GraphicsLayer when in accelerated compositing mode
3289 Reviewed by Simon Fraser and Chris Marrin.
3291 * WebCoreSupport/WebChromeClient.cpp:
3292 (WebChromeClient::attachRootGraphicsLayer):
3293 (WebChromeClient::scheduleCompositingLayerSync):
3294 Updated for WebView changes.
3297 (WebView::repaint): When using accelerated compositing, just invalidate
3298 our backing layer. This matches the behavior of LayerBackedDrawingArea.
3299 (WebView::deleteBackingStore): Removed accelerated compositing code.
3300 The WKCACFLayerRenderer doesn't need to know about our backing store
3301 anymore; we don't use it at all when in accelerated compositing mode.
3302 (WebView::addToDirtyRegion): When using accelerated compositing, just
3303 invalidate our backing layer.
3304 (WebView::scrollBackingStore): Added an assertion that this isn't
3305 called in accelerated compositing mode.
3306 (WebView::sizeChanged): Update our backing layer's size, too, and
3308 (WebView::updateBackingStore): Added an assertion that this isn't
3309 called in accelerated compositing mode.
3310 (WebView::paint): If we're in accelerated compositing mode, sync our
3311 compositing state. If we're *still* in accelerated compositing mode,
3312 just tell our WKCACFLayerRenderer to paint and clear our dirty region.
3313 (The later changes in this function are just un-indenting code that
3314 used to be inside an if.)
3316 (WebView::paintIntoBackingStore):
3317 (WebView::paintIntoWindow):
3318 Added assertions that these aren't called in accelerated compositing
3321 (WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
3322 removal of setRootLayerNeedsDisplay.
3323 (WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
3324 set the layer as a child of our own backing layer.
3325 (WebView::scheduleCompositingLayerSync): Just call through to
3326 WKCACFLayerRenderer.
3327 (WebView::setAcceleratedCompositing): Create our backing layer and set
3328 it as the child of WKCACFLayerRenderer's root layer.
3329 (WebView::notifyAnimationStarted): Added. We never expect this
3330 GraphicsLayerClient override to be called, as we don't use animations
3331 on our backing layer.
3332 (WebView::notifySyncRequired): Added. Just schedule a sync.
3333 (WebView::paintContents): Added. Just clip and paint!
3335 (WebView::showDebugBorders):
3336 (WebView::showRepaintCounter):
3337 Added. These just call through to Settings.
3339 (WebView::syncCompositingState): Changed to first update layout, then
3340 sync state for our backing layer, then sync WebCore's state. This
3341 matches LayerBackedDrawingArea.
3343 * WebView.h: WebView now implements the GraphicsLayerClient interface.
3344 Removed setRootLayerNeedsDisplay; it's been replaced by calling
3345 setNeedsDisplay on our backing layer and calling
3346 syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
3347 updateRootLayerContents; that function was used to pass our backing
3348 store to Core Animation, which we no longer do. Added m_backingLayer.
3350 2011-01-17 Tony Gentilcore <tonyg@chromium.org>
3352 Reviewed by Alexey Proskuryakov.
3354 Fix some headers with missing or misspelled #ifndef guards
3355 https://bugs.webkit.org/show_bug.cgi?id=52545
3357 * WebKitStatistics.h:
3359 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
3361 Reviewed by Yury Semikhatsky.
3363 Web Inspector: simplify debugger enabling routine.
3364 https://bugs.webkit.org/show_bug.cgi?id=52472
3367 (WebInspector::toggleDebuggingJavaScript):
3369 2011-01-16 Adam Barth <abarth@webkit.org>
3371 Rubber-stamped by Eric Seidel.
3373 Move WebKit into Source
3374 https://bugs.webkit.org/show_bug.cgi?id=52530
3376 * WebKit.vcproj/Interfaces.vcproj:
3377 * WebKit.vcproj/WebKit.sln:
3378 * WebKit.vcproj/WebKit.vcproj:
3379 * WebKit.vcproj/WebKitGUID.vcproj:
3381 2011-01-15 Adam Barth <abarth@webkit.org>
3383 Rubber-stamped by Eric Seidel.
3385 Move WebKit2 into Source
3386 https://bugs.webkit.org/show_bug.cgi?id=52438
3388 Update reference to WebKit2.
3390 * WebKit.vcproj/WebKit.sln:
3392 2011-01-14 Yuzo Fujishima <yuzo@google.com>
3394 Reviewed by Antti Koivisto.
3396 Rename cache() to memoryCache()
3397 https://bugs.webkit.org/show_bug.cgi?id=52433
3400 (WebCache::statistics):
3402 (WebCache::setDisabled):
3403 (WebCache::disabled):
3405 (WebView::setCacheModel):
3407 2011-01-10 Geoffrey Garen <ggaren@apple.com>
3409 Try to fix Windows build.
3411 * WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch
3412 this one before because it was miscapitalized.)
3414 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
3416 Reviewed by Darin Fisher.
3418 https://bugs.webkit.org/show_bug.cgi?id=41441
3419 createWindow method should only do window-creating without URL navigation
3421 * WebCoreSupport/WebChromeClient.cpp:
3422 (WebChromeClient::createWindow):
3424 2011-01-07 Adam Barth <abarth@webkit.org>
3426 Rubber-stamped by Eric Seidel.
3428 Move WebCore to Source
3429 https://bugs.webkit.org/show_bug.cgi?id=52050
3431 * WebKit.vcproj/WebKit.sln:
3433 2011-01-06 Gavin Barraclough <barraclough@apple.com>
3435 Reviewed by Geoff Garen.
3437 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
3439 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
3440 destructor early, in order to release wrappers once we know we no longer intend to use them.
3441 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
3442 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
3443 A sequence of events that triggers the bug would look like this:
3445 (1) Create a DOMWrapperWorld.
3446 (2) Register a timer in the world.
3447 (3) Call unregisterWorld() on the world.
3448 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
3449 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
3450 called forgetWorld() none exists.
3451 (6) Attempt to add a wrapper to a NULL map.
3453 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
3455 * WebScriptWorld.cpp:
3456 (WebScriptWorld::unregisterWorld):
3458 2011-01-07 Chris Marrin <cmarrin@apple.com>
3460 Rubber-stamped by Simon Fraser.
3462 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
3463 https://bugs.webkit.org/show_bug.cgi?id=49388
3465 Change client API for the fullscreen video controller. It now uses a
3466 PlatformCALayerClient so it can use a PlaformCALayer directly. Also
3467 updated how to connect the layer tree to the view to reflect the updated
3468 hardware compositing logic.
3470 * FullscreenVideoController.cpp:
3471 (FullscreenVideoController::LayerClient::LayerClient):
3472 (FullscreenVideoController::LayerClient::platformCALayerRespondsToLayoutChanges):
3473 (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
3474 (FullscreenVideoController::LayerClient::platformCALayerContentsOrientation):
3475 (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3476 (FullscreenVideoController::LayerClient::platformCALayerShowDebugBorders):
3477 (FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):
3478 (FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
3479 (FullscreenVideoController::LayerClient::platformCALayerContentsOpaque):
3480 (FullscreenVideoController::LayerClient::platformCALayerDrawsContent):
3481 (FullscreenVideoController::LayerClient::platformCALayerLayerDidDisplay):
3482 (FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):
3483 (FullscreenVideoController::FullscreenVideoController):
3484 (FullscreenVideoController::~FullscreenVideoController):
3485 (FullscreenVideoController::enterFullscreen):
3486 * FullscreenVideoController.h:
3487 * WebCoreSupport/WebChromeClient.cpp:
3488 (WebChromeClient::attachRootGraphicsLayer):
3489 (WebChromeClient::scheduleCompositingLayerSync):
3491 (WebView::setRootChildLayer):
3492 (WebView::animationsStarted):
3493 (WebView::syncCompositingState):
3495 (WebView::setRootLayerNeedsDisplay):
3497 2011-01-05 Steve Falkenburg <sfalken@apple.com>
3499 Reviewed by Darin Adler.
3501 Debug and Release builds on Windows clobber each other
3502 https://bugs.webkit.org/show_bug.cgi?id=49185
3504 Changes the structure of WebKitBuild build products directory so we
3505 completely separate each build configuration into independent directories.
3507 Although we previously had per-configuration directories for obj, this change adds
3508 per-configuration directories for bin, lib, obj, and include. Each configuration's
3509 build products are stored within a directory inside of WebKitBuild.
3511 Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3512 defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3514 * WebKit.vcproj/InterfacesCommon.vsprops:
3515 * WebKit.vcproj/InterfacesPostBuild.cmd:
3516 * WebKit.vcproj/InterfacesPreBuild.cmd:
3517 * WebKit.vcproj/WebKit.make:
3518 * WebKit.vcproj/WebKitGUID.vcproj:
3519 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
3520 * WebKit.vcproj/WebKitGUIDPostBuild.cmd:
3521 * WebKit.vcproj/WebKitGUIDPreBuild.cmd:
3522 * WebKit.vcproj/WebKitLibCommon.vsprops:
3523 * WebKit.vcproj/WebKitLibPostBuild.cmd:
3524 * WebKit.vcproj/WebKitLibPreBuild.cmd:
3526 2011-01-04 Chris Fleizach <cfleizach@apple.com>
3528 Reviewed by Sam Weinig.
3530 WK2: Support Accessibility
3531 https://bugs.webkit.org/show_bug.cgi?id=51859
3533 Use rootObject() method to get the top of the AX tree.
3535 * AccessibleDocument.cpp:
3536 (AccessibleDocument::AccessibleDocument):
3538 2011-01-01 Adam Barth <abarth@webkit.org>
3540 Reviewed by Eric Seidel.
3542 Move JavaScriptCore to Source
3543 https://bugs.webkit.org/show_bug.cgi?id=51604
3545 * WebKit.vcproj/WebKit.sln:
3546 - Point to JavaScriptCore in its new location.
3548 2010-12-22 Sam Weinig <sam@webkit.org>
3550 Reviewed by Darin Adler.
3552 WebKit2 needs to mirror the frame tree in the UIProcess
3553 https://bugs.webkit.org/show_bug.cgi?id=51546
3555 - Add client functions to notify that a frame has been added or
3556 removed from the page cache.
3558 * WebCoreSupport/WebFrameLoaderClient.cpp:
3559 (WebFrameLoaderClient::didSaveToPageCache):
3560 (WebFrameLoaderClient::didRestoreFromPageCache):
3561 * WebCoreSupport/WebFrameLoaderClient.h:
3563 2010-12-22 Dan Bernstein <mitz@apple.com>
3565 Changed WebKitTools to Tools.
3567 * WebKit.vcproj/WebKit.sln:
3569 2010-12-14 Adam Roben <aroben@apple.com>
3571 Always record the last-set cursor, even when the UI delegate is
3572 setting the cursor for us
3574 Prior to r63339, the last-set cursor was recorded in Widget::setCursor.
3575 r63339 moved that code up to WebChromeClient, but failed to call it
3576 when the UI delegate was the one setting the cursor.
3578 Fixes <http://webkit.org/b/45692> <rdar://problem/8423464> REGRESSION
3579 (r63339): Mouse cursor disappears when holding mouse button down on
3582 Reviewed by Ada Chan.
3584 * WebCoreSupport/WebChromeClient.cpp:
3585 (WebChromeClient::setCursor): After the cursor is set, regardless of
3586 whether the UI delegate sets it or we set it, record the cursor that
3587 was just set. That way we'll be able to use the cursor later when
3588 responding to the WM_SETCURSOR message.
3590 2010-12-13 Alexey Proskuryakov <ap@apple.com>
3592 Reviewed by Adam Barth.
3594 https://bugs.webkit.org/show_bug.cgi?id=50953
3595 DNS Prefetch should be an opt-in feature
3597 * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default to NO.
3599 2010-10-28 MORITA Hajime <morrita@google.com>
3601 Reviewed by Ojan Vafai.
3603 spellcheck does not check pasted text
3604 https://bugs.webkit.org/show_bug.cgi?id=40092
3606 Added a stub implememntation.
3608 * WebCoreSupport/WebEditorClient.h:
3609 (WebEditorClient::requestCheckingOfString):
3611 2010-12-10 Chris Fleizach <cfleizach@apple.com>
3613 Reviewed by Darin Adler.
3615 AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
3616 https://bugs.webkit.org/show_bug.cgi?id=50574
3618 * AccessibleBase.cpp:
3619 (AccessibleBase::accHitTest):
3621 2010-12-09 Brian Weinstein <bweinstein@apple.com>
3623 Reviewed by Adam Roben.
3625 Prep for WebKit2: Context menu support on Windows
3626 https://bugs.webkit.org/show_bug.cgi?id=50514
3628 Update WebKit for the new CROSS_PLATFORM_CONTEXT_MENUS flag, and define customizeMenu
3629 instead of getCustomMenuFromDefaultItems.
3631 * WebCoreSupport/WebContextMenuClient.cpp:
3632 (WebContextMenuClient::customizeMenu): getCustomMenuFromDefaultItems was turned into
3633 this function, with refactoring using nativeMenu instead of platformDescription.
3634 (WebContextMenuClient::contextMenuItemSelected): Use nativeMenu instead of platformDescription.
3635 * WebCoreSupport/WebContextMenuClient.h:
3637 (WebView::handleContextMenuEvent): Call nativeMenu instead of platformDescription.
3638 (WebView::performContextMenuAction): Only call itemAtIndex with one argument, no need
3641 2010-12-07 Brian Weinstein <bweinstein@apple.com>
3643 Reviewed by John Sullivan.
3645 Layering Violation in ContextMenu - member variable of type HitTestResult
3646 https://bugs.webkit.org/show_bug.cgi?id=50586
3648 Update users of ContextMenu and ContextMenuController to match where the new functions
3651 * WebCoreSupport/WebContextMenuClient.cpp:
3652 (WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the
3653 ContextMenuController (from the page).
3654 (WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
3656 (WebView::handleContextMenuEvent): Ditto.
3658 2010-12-07 Jessie Berlin <jberlin@apple.com>
3660 Build fix. Unreviewed.
3662 * WebCoreSupport/WebContextMenuClient.cpp:
3663 (WebContextMenuClient::searchWithGoogle):
3664 FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.
3666 2010-12-06 Darin Adler <darin@apple.com>
3668 Reviewed by Sam Weinig.
3670 Pass security origin to make local file decision correctly
3671 https://bugs.webkit.org/show_bug.cgi?id=48603
3673 * WebCoreSupport/WebContextMenuClient.cpp:
3674 (WebContextMenuClient::searchWithGoogle): Pass security origin.
3676 2010-12-07 Kenichi Ishibashi <bashi@google.com>
3678 Reviewed by Kent Tamura.
3680 Let HTMLObjectElement be a form associated element
3681 https://bugs.webkit.org/show_bug.cgi?id=48821
3683 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
3686 (WebFrame::elementWithName): Modified to use FormAssociatedElement
3687 instead of HTMLFormControlElement.
3688 (WebFrame::controlsInForm): Ditto.
3690 2010-12-05 Adam Roben <aroben@apple.com>
3692 Windows production build fix
3694 Put spaces after trailing backslashes when setting
3695 %WebKitVSPropsRedirectionDir%. According to MSDN
3696 <http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>:
3698 A backslash ( \ ) followed by a newline character is interpreted as
3699 a space in the command; use a backslash at the end of a line to
3700 continue a command onto the next line. NMAKE interprets the
3701 backslash literally if any other character, including a space or
3702 tab, follows the backslash.
3704 * WebKit.vcproj/WebKit.make:
3706 2010-12-03 Sam Weinig <sam@webkit.org>
3708 Reviewed by Maciej Stachowiak.
3710 Enable <a ping> for Mac/Windows/WebKit2 builds
3711 <rdar://problem/8504473>
3712 https://bugs.webkit.org/show_bug.cgi?id=50488
3714 * WebPreferences.cpp:
3715 (WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.
3717 2010-12-03 Brian Weinstein <bweinstein@apple.com>
3719 Reviewed by Brady Eidson.
3721 WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows
3722 https://bugs.webkit.org/show_bug.cgi?id=50486
3724 Remove the static fixMenuReceivedFromOldSafari and isPreInspectElementTagSafari methods
3725 from WebContextMenuClient. There were there for when WebKit had the Inspect Element context menu
3726 item, but Safari didn't support it. We don't support that old Safari, so that code can go.
3728 * WebCoreSupport/WebContextMenuClient.cpp:
3729 (WebContextMenuClient::getCustomMenuFromDefaultItems):
3731 2010-12-02 John Knottenbelt <jknotten@chromium.org>
3733 Reviewed by Steve Block.
3735 Move requestGeolocationPermissionForFrame to GeolocationClient
3736 https://bugs.webkit.org/show_bug.cgi?id=50061
3738 This change facilitates client-based geolocation implementation by
3739 bringing together permission control into the geolocation client
3742 Move method ChromeClient::requestGeolocationPermissionForFrame to
3743 GeolocationClient::requestPermission. The moved code is unchanged
3744 except that requestPermission now takes only one argument (Geolocation*),
3745 the Frame parameter is retrieved from the Geolocation object and we need to
3746 call m_webView.get() as it is a COMPtr in GeolocationClient.
3748 * WebCoreSupport/WebChromeClient.cpp:
3749 * WebCoreSupport/WebChromeClient.h:
3750 * WebCoreSupport/WebGeolocationClient.cpp:
3751 (WebGeolocationClient::requestPermission):
3752 * WebCoreSupport/WebGeolocationClient.h:
3753 (WebGeolocationClient::cancelPermissionRequest):
3755 2010-12-01 Jia Pu <jpu@apple.com>
3757 Reviewed by Darin Adler.
3759 Support multiple correction candidates panel for misspelled word on Mac OS X.
3760 https://bugs.webkit.org/show_bug.cgi?id=50137
3761 <rdar://problem/8568059>
3763 Adopted new function signature defined in base class.
3765 * WebCoreSupport/WebEditorClient.cpp:
3766 (WebEditorClient::getGuessesForWord):
3767 * WebCoreSupport/WebEditorClient.h:
3769 2010-12-01 Steve Falkenburg <sfalken@apple.com>
3771 Reviewed by Adam Roben.
3773 WinCairo build should not use link-time code generation (LTCG)
3774 https://bugs.webkit.org/show_bug.cgi?id=50353
3776 * WebKit.vcproj/Interfaces.vcproj:
3777 * WebKit.vcproj/WebKit.vcproj:
3778 * WebKit.vcproj/WebKitGUID.vcproj:
3780 2010-12-01 Steve Falkenburg <sfalken@apple.com>
3782 Reviewed by Adam Roben.
3784 vcproj changes can't be applied cleanly by the Windows EWS bot
3785 https://bugs.webkit.org/show_bug.cgi?id=50328
3787 * WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style.
3788 * WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style.
3789 * WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
3790 * WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
3791 * WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style.
3792 * WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style.
3793 * WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style.
3794 * WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style.
3796 2010-11-30 Steve Falkenburg <sfalken@apple.com>
3798 Reviewed by Adam Roben.
3800 All projects on Windows should use cmd files for build events
3801 https://bugs.webkit.org/show_bug.cgi?id=50213
3803 * WebKit.vcproj/InterfacesCommon.vsprops:
3804 * WebKit.vcproj/InterfacesPostBuild.cmd: Added.
3805 * WebKit.vcproj/InterfacesPreBuild.cmd: Added.
3806 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
3807 * WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added.
3808 * WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added.
3809 * WebKit.vcproj/WebKitLibCommon.vsprops:
3810 * WebKit.vcproj/WebKitLibPostBuild.cmd: Added.
3811 * WebKit.vcproj/WebKitLibPreBuild.cmd: Added.
3813 2010-11-29 Brent Fulgham <bfulgham@webkit.org>
3815 Unreviewed build correction.
3817 * WebKit.vcproj/WebKit.vcproj: Update WebKit project to
3818 use WinCairo.vsprops definition for appropriate build targets.
3820 2010-11-22 Adam Roben <aroben@apple.com>
3822 Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3824 Apple's Windows build allows placing header files and import libraries for WebKit's
3825 dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3826 $WebKitLibrariesDir environment variable. This is both required for production builds and
3827 convenient for Apple-internal developer builds. Apple's production builds also require that
3828 WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3829 builds, the files are copied into that directory tree by the
3830 WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3832 JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3834 This .vsprops copying is problematic in one very important case: when a developer updates
3835 their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3836 project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3837 updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3838 build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3839 $WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
3840 will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3842 To fix this, we now use normal relative paths to access the .vsprops files in the source
3843 tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3844 variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3845 unset, so the normal relative paths are used to read the .vsprops files out of the source
3846 tree directly. In production builds, this environment variable is set to a fake directory
3847 that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3850 For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3852 $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3854 In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3855 files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3856 JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3857 "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3858 FeatureDefines.vsprops becomes:
3860 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3864 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3866 (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3867 actually exist since they are matched by an equal number of ".." path components.)
3869 Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3870 Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3872 Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3875 Reviewed by Dave Hyatt.
3877 * WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can
3878 find the .vsprops files.
3880 * WebKit.vcproj/WebKit.vcproj:
3881 * WebKit.vcproj/Interfaces.vcproj:
3882 * WebKit.vcproj/WebKitGUID.vcproj:
3883 Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3886 2010-11-19 Steve Falkenburg <sfalken@apple.com>
3888 Reviewed by Adam Roben.
3890 Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3891 https://bugs.webkit.org/show_bug.cgi?id=49819
3893 * WebKit.vcproj/Interfaces.vcproj:
3894 * WebKit.vcproj/WebKit.sln:
3895 * WebKit.vcproj/WebKit.vcproj:
3896 * WebKit.vcproj/WebKitGUID.vcproj:
3898 2010-11-19 Steve Falkenburg <sfalken@apple.com>
3900 Reviewed by Darin Adler.
3902 Normalize Cairo/CFLite project/solution configuration names
3903 https://bugs.webkit.org/show_bug.cgi?id=49818
3905 * WebKit.vcproj/WebKit.sln:
3906 * WebKit.vcproj/WebKit.vcproj:
3908 2010-11-18 Steve Falkenburg <sfalken@apple.com>
3910 Reviewed by Adam Roben.
3912 Windows vcproj configuration names should be normalized across projects
3913 https://bugs.webkit.org/show_bug.cgi?id=49776
3915 * WebKit.vcproj/Interfaces.vcproj:
3916 * WebKit.vcproj/WebKit.sln:
3918 2010-11-18 Steve Falkenburg <sfalken@apple.com>
3920 Reviewed by Adam Roben.
3922 Remove leftover Windows Debug_Internal configurations
3923 https://bugs.webkit.org/show_bug.cgi?id=49758
3925 * WebKit.vcproj/WebKit.vcproj:
3926 * WebKit.vcproj/WebKitGUID.vcproj:
3928 2010-11-18 Steve Falkenburg <sfalken@apple.com>
3930 Reviewed by Adam Roben.
3932 Debug_Internal Windows configuration is unnecessary, should be removed
3933 https://bugs.webkit.org/show_bug.cgi?id=49753
3937 2010-11-17 Steve Falkenburg <sfalken@apple.com>
3939 Reviewed by Adam Roben.
3941 WebKit Interfaces project should use vsprops file for common build settings
3942 https://bugs.webkit.org/show_bug.cgi?id=49713
3944 * WebKit.vcproj/Interfaces.vcproj:
3945 * WebKit.vcproj/InterfacesCommon.vsprops: Added.
3947 2010-11-16 Steve Falkenburg <sfalken@apple.com>
3949 Reviewed by Adam Roben.
3951 Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
3952 https://bugs.webkit.org/show_bug.cgi?id=49632
3954 * WebKit.vcproj/Interfaces.vcproj:
3955 * WebKit.vcproj/WebKit.make:
3956 * WebKit.vcproj/WebKit.sln:
3957 * WebKit.vcproj/WebKit.submit.sln:
3958 * WebKit.vcproj/WebKit.vcproj:
3959 * WebKit.vcproj/WebKitGUID.vcproj:
3961 2010-11-16 Dave Hyatt <hyatt@apple.com>
3963 Reviewed by Dan Bernstein.
3965 https://bugs.webkit.org/show_bug.cgi?id=11004
3967 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
3968 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
3969 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
3970 of the constructor rather than using [NSFont pointSize].
3972 https://bugs.webkit.org/show_bug.cgi?id=49582
3974 Negative leading is not handled correctly. There are two bugs here. The first is that
3975 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
3976 set them before so that we can allow them to be < 0.
3978 The second issue is that we should understand where fonts will end up relative to
3979 our baseline (excluding line height), and only allow those boxes to impact ascent and
3980 descent if the actual font box (without factoring in line height) is above or below the
3981 root line box baseline.
3983 Added fast/css/negative-leading.html
3985 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
3987 * WebPreferences.cpp:
3988 (WebPreferences::initializeDefaultSettings):
3990 2010-11-16 Steve Falkenburg <sfalken@apple.com>
3992 Reviewed by Adam Roben.
3994 Use vsprops files for common settings in Windows WebKit
3995 https://bugs.webkit.org/show_bug.cgi?id=49622
3997 * WebKit.vcproj/WebKit.vcproj:
3998 * WebKit.vcproj/WebKitCommon.vsprops: Added.
4000 2010-11-16 Steve Falkenburg <sfalken@apple.com>
4002 Rubber stamped by Adam Roben.
4004 Remove unnecessary def file, remove outdated def files from vcproj.
4006 * WebKit.vcproj/WebKit.vcproj:
4007 * WebKit.vcproj/WebKit_debug.def: Removed.
4009 2010-11-12 John Knottenbelt <jknotten@chromium.org>
4011 Reviewed by Steve Block.
4013 Rename GeolocationControllerClient to GeolocationClient.
4014 https://bugs.webkit.org/show_bug.cgi?id=49259
4016 * WebCoreSupport/WebGeolocationClient.cpp: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp.
4017 (WebGeolocationClient::WebGeolocationClient):
4018 (WebGeolocationClient::geolocationDestroyed):
4019 (WebGeolocationClient::startUpdating):
4020 (WebGeolocationClient::stopUpdating):
4021 (WebGeolocationClient::lastPosition):
4022 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h.
4023 (WebGeolocationClient::setEnableHighAccuracy):
4024 * WebKit.vcproj/WebKit.vcproj:
4026 (WebView::initWithFrame):
4028 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
4030 Reviewed by David Hyatt.
4032 HTML5 Ruby support should be mandatory feature
4033 https://bugs.webkit.org/show_bug.cgi?id=49272
4035 * WebKitPrefix.h: Touch it to avoid incremental build failure on Windows.
4037 2010-11-08 Alexey Proskuryakov <ap@apple.com>
4041 * WebCoreSupport/WebChromeClient.h: Added namespace prefix.
4043 2010-11-08 Alexey Proskuryakov <ap@apple.com>
4045 Reviewed by Darin Adler.
4047 https://bugs.webkit.org/show_bug.cgi?id=48685
4048 Notify UI process about focused frame
4050 Added an empty implementation of the new ChromeClient method.
4052 * WebCoreSupport/WebChromeClient.cpp:
4053 (WebChromeClient::focusedFrameChanged):
4054 * WebCoreSupport/WebChromeClient.h:
4056 2010-11-07 Adam Barth <abarth@webkit.org>
4058 Reviewed by Eric Seidel.
4060 Rename Cache to MemoryCache
4061 https://bugs.webkit.org/show_bug.cgi?id=49159
4064 (WebCache::statistics):
4068 2010-11-05 Chris Marrin <cmarrin@apple.com>
4070 Reviewed by Simon Fraser.
4072 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
4073 https://bugs.webkit.org/show_bug.cgi?id=49073
4076 (WebFrame::suspendAnimations):
4077 (WebFrame::resumeAnimations):
4079 2010-11-05 Brian Weinstein <bweinstein@apple.com>
4081 Reviewed by Anders Carlsson.
4083 Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html
4084 https://bugs.webkit.org/show_bug.cgi?id=48751
4085 <rdar://problem/8615536>
4087 Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were
4088 running into a case where we were trying to load an empty plugin document, which uses a manual loader, and
4089 PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire
4090 an assert in the PluginStream destructor.
4092 * WebCoreSupport/WebFrameLoaderClient.cpp:
4093 (WebFrameLoaderClient::finishedLoading):
4095 2010-11-05 Chris Marrin <cmarrin@apple.com>
4097 Reviewed by Simon Fraser.
4099 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
4100 https://bugs.webkit.org/show_bug.cgi?id=46945
4103 (WebFrame::suspendAnimations):
4104 (WebFrame::resumeAnimations):
4106 2010-11-05 Patrick Gansterer <paroga@webkit.org>
4108 Reviewed by David Kilzer.
4110 Replace ARRAYSIZE with WTF_ARRAY_LENGTH
4111 https://bugs.webkit.org/show_bug.cgi?id=48903
4113 * WebCoreSupport/WebChromeClient.cpp:
4114 (WebChromeClient::exceededDatabaseQuota):
4116 (DllGetClassObject):
4118 (WebView::mouseWheel):
4120 2010-11-02 Daniel Bates <dbates@rim.com>
4122 Reviewed by Adam Barth.
4124 For unnamed frames, window.name returns a generated name
4125 https://bugs.webkit.org/show_bug.cgi?id=6751
4129 Substitute FrameTree::uniqueName() for FrameTree::name() in the Apple Windows port.
4134 2010-11-02 Brady Eidson <beidson@apple.com>
4136 Reviewed by Anders Carlsson.
4138 <rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
4139 Implement IMutableWebRequest::setTimeoutInterval
4141 * WebMutableURLRequest.cpp:
4142 (WebMutableURLRequest::setTimeoutInterval):
4144 2010-11-02 Daniel Bates <dbates@rim.com>
4146 Reviewed by Martin Robinson.
4148 Set frame name before appending it to the frame tree in the Apple Windows,
4150 https://bugs.webkit.org/show_bug.cgi?id=48806
4152 Make the frame creation process in the Apple Windows-port consistent
4153 with the Mac, Qt, and Haiku ports. In particular, set the name of
4154 the new frame before it's appended to the frame tree.
4156 At this time we cannot test this change since it is being masked by
4157 HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
4158 We'll be able to test this once we fix bug #6751.
4160 * WebCoreSupport/WebFrameLoaderClient.cpp:
4161 (WebFrameLoaderClient::createFrame):
4163 2010-11-01 Jenn Braithwaite <jennb@chromium.org>
4165 Reviewed by Adam Roben.
4167 Windows: Update resource tracking when moving a frame between documents
4168 https://bugs.webkit.org/show_bug.cgi?id=48364
4170 * Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added
4171 Added removeIdentifierForRequest.
4172 * Interfaces/WebKit.idl:
4173 Added IWebResourceLoadDelegatePrivate2.idl.
4174 * WebCoreSupport/WebFrameLoaderClient.cpp:
4175 (WebFrameLoaderClient::transferLoadingResourceFromPage):
4177 2010-11-01 Brady Eidson <beidson@apple.com>
4179 Reviewed by Anders Carlsson.
4181 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
4182 Context menu support for WebKit 2.
4184 * WebCoreSupport/WebChromeClient.h:
4185 (WebChromeClient::showContextMenu):
4187 2010-11-01 Adam Roben <aroben@apple.com>
4189 Cancel main resource loads after we hand them off to the media engine
4191 This is the Windows equivalent of r51104. Clearly this code should be
4192 moved to a cross-platform location someday.
4194 Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
4195 failure in DocumentLoader::commitData when loading a media document in
4198 Reviewed by Dan Bernstein.
4200 * WebCoreSupport/WebFrameLoaderClient.cpp:
4201 (WebFrameLoaderClient::committedLoad): Cancel the main resource load
4202 after handing off the load to the media engine. This code originally
4203 came from -[WebHTMLRepresentation receivedData:withDataSource:].
4206 (WebFrame::shouldFallBack): Don't fall back when handing the resource
4207 load off to the media engine or a plugin. Added error domain checking
4208 so that we don't rely on error codes being unique.
4210 2010-10-29 Daniel Bates <dbates@rim.com>
4212 No review, rolling out 70971.
4213 http://trac.webkit.org/changeset/70971
4214 https://bugs.webkit.org/show_bug.cgi?id=6751
4216 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
4217 it caused layout test failures on all bots. In particular, the
4218 child count in a generated frame name differs after this patch. We need
4219 to look into this further.
4224 2010-10-28 Antonio Gomes <agomes@rim.com>
4226 Reviewed by Ojan Vafai.
4228 Needs a "LinuxEditingBehavior", perhaps with a better name
4229 https://bugs.webkit.org/show_bug.cgi?id=36627
4231 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
4233 * Interfaces/IWebPreferences.idl:
4235 2010-10-29 Daniel Bates <dbates@rim.com>
4237 Reviewed by Adam Barth.
4239 For unnamed frames, window.name returns a generated name
4240 https://bugs.webkit.org/show_bug.cgi?id=6751
4242 Modified Apple Windows-port to use FrameTree::uniqueName().
4247 2010-10-29 Darin Adler <darin@apple.com>
4249 Reviewed by Sam Weinig.
4251 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
4252 https://bugs.webkit.org/show_bug.cgi?id=48574
4254 * WebBackForwardList.cpp:
4255 (backForwardListWrappers):
4256 (WebBackForwardList::WebBackForwardList):
4257 (WebBackForwardList::createInstance):
4258 * WebBackForwardList.h:
4260 (WebView::backForwardList):
4261 Use BackForwardListImpl.
4263 2010-10-29 Adam Roben <aroben@apple.com>
4267 * WebKitPrefix.h: Touched to force a rebuild.
4269 2010-10-29 Alexey Proskuryakov <ap@apple.com>
4271 Reviewed by Darin Adler.
4273 https://bugs.webkit.org/show_bug.cgi?id=48576
4274 Let WebKit2 client know when a frame is a frameset
4276 Added a blank implementation of the new FrameLoaderClient method.
4278 * WebCoreSupport/WebFrameLoaderClient.h:
4279 * WebCoreSupport/WebFrameLoaderClient.cpp:
4280 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
4282 2010-10-26 Brent Fulgham <bfulgham@webkit.org>
4284 Unreviewed build fix.
4286 * WebView.cpp: Conditionalize includes for CFNetwork-specific
4287 Cookie implementation.
4288 * WebView.h: Conditionalize includes for ACCELERATED_COMPOSITION.
4289 WinCairo doesn't use CoreAnimation.
4291 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
4293 Reviewed by Dmitry Titov.
4295 Resource tracking failure when trying to move a frame between documents
4296 https://bugs.webkit.org/show_bug.cgi?id=44713
4298 * WebCoreSupport/WebFrameLoaderClient.cpp:
4299 (WebFrameLoaderClient::transferLoadingResourceFromPage):
4301 * WebCoreSupport/WebFrameLoaderClient.h:
4303 2010-10-25 Patrick Gansterer <paroga@webkit.org>
4305 Reviewed by David Kilzer.
4307 Replace _countof with WTF_ARRAY_LENGTH
4308 https://bugs.webkit.org/show_bug.cgi?id=48229
4310 * WebCoreSupport/WebContextMenuClient.cpp:
4311 (isPreInspectElementTagSafari):
4313 (WebView::interpretKeyEvent):
4315 2010-10-24 Dan Bernstein <mitz@apple.com>
4319 * Interfaces/WebKit.idl: Touched.
4321 2010-10-24 Dan Bernstein <mitz@apple.com>
4323 Reviewed by Anders Carlsson.
4325 Expose HitTestResult::absoluteMediaURL() via WebKit API
4326 https://bugs.webkit.org/show_bug.cgi?id=48219
4328 * Interfaces/IWebView.idl: Added WebElementMediaURLKey.
4329 * WebElementPropertyBag.cpp:
4330 (WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL().
4332 2010-10-22 Andy Estes <aestes@apple.com>
4334 Fix the Windows build.
4336 * WebCookieManagerCFNet.cpp: Rename CookieStorageWin.h to CookieStorageCFNet.h.
4337 * WebView.cpp: Ditto.
4339 2010-10-22 Jenn Braithwaite <jennb@chromium.org>
4341 Reviewed by Adam Roben.
4343 Windows client needs updating when live iframe element is moved between pages
4344 https://bugs.webkit.org/show_bug.cgi?id=46915
4346 * WebCoreSupport/WebFrameLoaderClient.cpp:
4347 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
4348 Update WebView in WebFrame to match that of the current page.
4350 (WebFrame::setWebView):
4354 2010-10-22 Sam Weinig <sam@webkit.org>
4358 * WebCoreSupport/WebChromeClient.h:
4360 2010-10-22 Sam Weinig <sam@webkit.org>
4362 Reviewed by Anders Carlsson.
4364 WebKit2 needs to pass the current event modifier flags when requesting a new window
4365 https://bugs.webkit.org/show_bug.cgi?id=48140
4367 * WebCoreSupport/WebChromeClient.cpp:
4368 (WebChromeClient::createWindow):
4369 * WebCoreSupport/WebFrameLoaderClient.cpp:
4370 (WebFrameLoaderClient::dispatchCreatePage):
4371 * WebCoreSupport/WebFrameLoaderClient.h:
4372 Add NavigationAction parameter.
4374 2010-10-21 MORITA Hajime <morrita@google.com>
4376 Unreviewed, touched it to fix the build.
4378 * Interfaces/WebKit.idl:
4380 2010-10-21 MORITA Hajime <morrita@google.com>
4382 Reviewed by Kent Tamura.
4384 [Win][DRT] should have LayoutTestController.hasSpellingMarker()
4385 https://bugs.webkit.org/show_bug.cgi?id=47885
4387 Added IWebFramePrivate::hasSpellingMarker() and impelmented it for
4388 LayoutTestController.
4390 * Interfaces/IWebFramePrivate.idl:
4392 (WebFrame::hasSpellingMarker):
4395 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
4397 Reviewed by David Levin.
4399 Repost the DatabaseTracker notifications to the main thread, if needed.
4400 https://bugs.webkit.org/show_bug.cgi?id=40655
4402 * WebDatabaseManager.cpp:
4403 (DidModifyOriginData::dispatchToMainThread):
4404 (DidModifyOriginData::DidModifyOriginData):
4405 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
4406 (WebDatabaseManager::dispatchDidModifyOrigin):
4407 (WebDatabaseManager::dispatchDidModifyDatabase):
4409 2010-10-20 Dirk Schulze <krit@webkit.org>
4411 Reviewed by Nikolas Zimmermann.
4413 Merge ColorSpace and ImageColorSpace enums
4414 https://bugs.webkit.org/show_bug.cgi?id=47922
4416 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
4417 to follow webkit style rules.
4419 * FullscreenVideoController.cpp:
4422 (FullscreenVideoController::draw):
4423 * WebCoreSupport/WebDragClient.cpp:
4424 (WebDragClient::createDragImageForLink):
4425 * WebKitGraphics.cpp:
4428 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
4430 Reviewed by Timothy Hatcher.
4432 Web Inspector: disable private browsing for inspector
4433 https://bugs.webkit.org/show_bug.cgi?id=47827
4435 * WebCoreSupport/WebInspectorClient.cpp:
4436 (WebInspectorClient::openInspectorFrontend):
4438 2010-10-17 Adam Barth <abarth@webkit.org>
4440 Reviewed by Dimitri Glazkov.
4442 FrameLoader doesn't need an explicit userGesture parameter
4443 https://bugs.webkit.org/show_bug.cgi?id=47777
4445 Update for the new API.
4447 * WebCoreSupport/WebContextMenuClient.cpp:
4448 (WebContextMenuClient::searchWithGoogle):
4450 2010-10-15 Brian Weinstein <bweinstein@apple.com>
4452 Reviewed by Sam Weinig.
4454 REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
4455 https://bugs.webkit.org/show_bug.cgi?id=47753
4456 <rdar://problem/8558242>
4458 VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
4459 when we turn it into a WebCore string, or else concatenation using this string will break.
4463 2010-10-15 Jessie Berlin <jberlin@apple.com>
4465 Windows build fix. Unreviewed.
4467 * WebCoreSupport/WebInspectorClient.cpp:
4468 Add a missing include.
4470 2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
4472 Reviewed by Dirk Schulze.
4474 Replace some String::format() usages by StringConcatenate in WebKit
4475 https://bugs.webkit.org/show_bug.cgi?id=47714
4477 * WebCoreSupport/WebInspectorClient.cpp:
4478 (WebInspectorFrontendClient::updateWindowTitle):
4480 (WebView::standardUserAgentWithApplicationName):
4483 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
4485 Reviewed by Pavel Feldman.
4487 Web Inspector: inspector settings/properties/states management
4488 should be extracted into separate class.
4490 We have a lot of flags/values in InspectorController.
4491 Some flags are persisting into profile.
4492 Others are part of inspector state for frontend.
4493 All these flags should keep their values after navigation.
4494 It'd be better to extract these flags/values into separate
4495 class which will care about theirs lifetime.
4497 https://bugs.webkit.org/show_bug.cgi?id=47275
4499 * WebCoreSupport/WebInspectorClient.cpp:
4500 (WebInspectorFrontendClient::attachWindow):
4501 (WebInspectorFrontendClient::detachWindow):
4502 (WebInspectorFrontendClient::showWindowWithoutNotifications):
4504 2010-10-13 Gavin Barraclough <barraclough@apple.com>
4506 Reviewed by Oliver Hunt.
4508 https://bugs.webkit.org/show_bug.cgi?id=43987
4509 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
4510 to construct their internal result string. Remove ScriptString (this is now
4513 * WebCoreSupport/WebFrameLoaderClient.cpp:
4515 2010-10-12 Adam Roben <aroben@apple.com>
4517 Build TestWebKitAPI on Windows
4519 Fixes <http://webkit.org/b/47552> <rdar://problem/8541708> Make
4520 TestWebKitAPI work on Windows
4522 Reviewed by Sam Weinig.
4524 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and
4525 TestWebKitAPIGenerated and made them build just after
4528 2010-10-11 Shinichiro Hamaji <hamaji@chromium.org>
4530 Attempt to fix windows build failure.
4532 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
4533 https://bugs.webkit.org/show_bug.cgi?id=47523
4535 * Interfaces/IWebFramePrivate.idl: s/unused1/unused2/
4536 * Interfaces/WebKit.idl: Touched.
4537 * WebFrame.cpp: s/unused1/unused2/
4538 (WebFrame::unused2):
4539 * WebFrame.h: s/unused1/unused2/
4541 2010-10-11 Anders Carlsson <andersca@apple.com>
4543 Reviewed by Darin Adler.
4545 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
4546 https://bugs.webkit.org/show_bug.cgi?id=47523
4548 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
4550 * Interfaces/IWebFramePrivate.idl:
4551 * Interfaces/IWebIconFetcher.idl: Removed.
4552 * Interfaces/WebKit.idl:
4554 (WebFrame::unused1):
4556 * WebIconFetcher.cpp: Removed.
4557 * WebIconFetcher.h: Removed.
4558 * WebKit.vcproj/Interfaces.vcproj:
4559 * WebKit.vcproj/WebKit.vcproj:
4561 2010-10-11 Jessie Berlin <jberlin@apple.com>
4563 Reviewed by Darin Adler.
4565 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
4566 representation of a WebKit1 WebSerializedJSValue.
4567 https://bugs.webkit.org/show_bug.cgi?id=47439
4569 * Interfaces/IWebSerializedJSValuePrivate.idl:
4570 Because it is taking a void** parameter, getInternalRepresentation must be declared [local].
4572 * WebSerializedJSValue.cpp:
4573 (WebSerializedJSValue::getInternalRepresentation):
4574 * WebSerializedJSValue.h:
4576 2010-10-07 Jessie Berlin <jberlin@apple.com>
4578 Reviewed by Sam Weinig.
4580 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
4581 representation of a WebKit2 WebSerializedScriptValue.
4582 https://bugs.webkit.org/show_bug.cgi?id=47390
4584 * Interfaces/WebKit.idl:
4585 Generate IWebSerializedJSValuePrivate.
4587 * Interfaces/IWebSerializedJSValuePrivate.idl: Added.
4588 Because it is taking a void* parameter, setInternalRepresentation must be declared [local].
4590 * WebKit.vcproj/Interfaces.vcproj:
4591 Add IWebSerializedJSValue.idl and IWebSerializedJSValuePrivate.idl.
4593 * WebSerializedJSValue.cpp:
4594 (WebSerializedJSValue::QueryInterface):
4595 Since there are now two interfaces that inherit from IUnknown, do not try to cast to
4596 IUnknown* anymore. Cast to IWebSerializedJSValue* instead.
4597 (WebSerializedJSValue::setInternalRepresentation):
4598 Only set the internal representation if it hasn't already been set.
4599 * WebSerializedJSValue.h:
4601 2010-10-04 Jon Honeycutt <jhoneycutt@apple.com>
4603 Prevent an assertion failure when trying to create a protection space
4606 Reviewed by Sam Weinig.
4608 * WebURLProtectionSpace.cpp:
4609 (WebURLProtectionSpace::initWithHost):
4610 Remove the ASSERT_NOT_REACHED().
4612 2010-10-05 Brent Fulgham <bfulgham@webkit.org>
4614 Unreviewed build correction.
4616 * WebKit.vcproj/WebKit.sln: Turn the QTMovieWin project
4617 off for WinCairo release builds. Somehow this was
4618 incorrectly turned on.
4620 2010-10-01 Mark Rowe <mrowe@apple.com>
4624 Clear the executable bit from a number of source files.
4629 2010-09-30 Darin Adler <darin@apple.com>
4631 Reviewed by Sam Weinig.
4633 Remove remaining calls to deprecatedParseURL
4634 https://bugs.webkit.org/show_bug.cgi?id=26599
4636 * WebCoreSupport/WebFrameLoaderClient.cpp:
4637 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
4638 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
4640 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
4642 Reviewed by Dmitry Titov.
4644 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
4645 https://bugs.webkit.org/show_bug.cgi?id=46663
4647 * WebCoreSupport/WebFrameLoaderClient.cpp:
4648 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
4649 * WebCoreSupport/WebFrameLoaderClient.h:
4651 2010-09-27 Andrey Kosyakov <caseq@chromium.org>
4653 Unreviewed build fix (win; broken in r68371)
4655 * WebFrame.cpp: remove include <WebCore/ResourceHandleWin.h>
4657 2010-09-23 Matthew Delaney <mdelaney@apple.com>
4659 Reviewed by Simon Fraser.
4661 Reduce minimum DOMTimer interval
4662 https://bugs.webkit.org/show_bug.cgi?id=45362
4665 Updating set interval call to use Settings' static version inside
4666 one time init block.
4668 2010-09-23 Nate Chapin <japhet@chromium.org>
4670 Unreviewed, build fix.
4672 Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl
4673 and touch WebKit.idl
4675 * Interfaces/IWebPreferences.idl:
4676 * Interfaces/IWebPreferencesPrivate.idl:
4677 * Interfaces/WebKit.idl:
4679 (WebView::notifyPreferencesChanged):
4681 2010-09-23 Nate Chapin <japhet@chromium.org>
4683 Unreviewed, build fix.
4685 Look for hyperlinkAuditingEnabled in the right set of preferences.
4688 (WebView::notifyPreferencesChanged):
4690 2010-09-23 Nate Chapin <japhet@chromium.org>
4692 Reviewed by Darin Fisher.
4694 Add hyperlink auditing settings (i.e., <a ping>).
4695 https://bugs.webkit.org/show_bug.cgi?id=30458
4697 * Interfaces/IWebPreferences.idl:
4698 * WebPreferenceKeysPrivate.h:
4699 * WebPreferences.cpp:
4700 (WebPreferences::initializeDefaultSettings):
4701 (WebPreferences::hyperlinkAuditingEnabled):
4702 (WebPreferences::setHyperlinkAuditingEnabled):
4705 (WebView::notifyPreferencesChanged):
4707 2010-09-23 Matthew Delaney <mdelaney@apple.com>
4709 Reviewed by Adam Roben.
4711 Create one time initialization block for WebView's initWithFrame
4712 https://bugs.webkit.org/show_bug.cgi?id=46307
4714 * WebView.cpp: Added one time initialization block for webview code
4715 that needs only be run once and not for each webview. This is just as
4716 the mac version WebView.mm does.
4718 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
4720 Reviewed by Martin Robinson.
4722 [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
4723 https://bugs.webkit.org/show_bug.cgi?id=46303.
4725 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
4726 Release_Cairo configurations to select appropriate build
4727 targets for WebKitTestRunner and MiniBrowser.
4729 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
4731 Reviewed by Martin Robinson.
4733 [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.rt
4734 https://bugs.webkit.org/show_bug.cgi?id=46303.
4736 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
4737 Release_Cairo configurations to select appropriate build
4738 targets for InjectionBundle.
4740 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
4742 Reviewed by Kenneth Rohde Christiansen.
4744 PluginStrategy should satisfy the needs of Qt
4745 https://bugs.webkit.org/show_bug.cgi?id=45857
4746 No new functionality so no new tests.
4748 * WebCoreSupport/WebPlatformStrategies.cpp:
4749 (WebPlatformStrategies::getPluginInfo):
4750 * WebCoreSupport/WebPlatformStrategies.h:
4752 2010-09-20 Philippe Normand <pnormand@igalia.com>
4754 Reviewed by Eric Carlson.
4756 [GTK] enhanced context menu for media elements
4757 https://bugs.webkit.org/show_bug.cgi?id=45021
4759 New localized strings for the media element context-menu.
4761 * WebCoreSupport/WebPlatformStrategies.cpp:
4762 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
4763 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
4764 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
4765 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
4766 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
4767 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
4768 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
4769 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
4770 (WebPlatformStrategies::contextMenuItemTagMediaPause):
4771 (WebPlatformStrategies::contextMenuItemTagMediaMute):
4772 * WebCoreSupport/WebPlatformStrategies.h:
4774 2010-09-17 Darin Adler <darin@apple.com>
4776 Reviewed by Sam Weinig.
4778 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
4779 https://bugs.webkit.org/show_bug.cgi?id=42863
4782 (WebView::setZoomMultiplier):
4783 Call functions on Frame instead of FrameView.
4785 2010-09-17 Matthew Delaney <mdelaney@apple.com>
4787 Reviewed by Simon Fraser.
4789 Reduce minimum DOMTimer interval
4790 https://bugs.webkit.org/show_bug.cgi?id=45362
4792 * WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
4794 2010-09-17 Simon Fraser <simon.fraser@apple.com>
4796 Reviewed by Chris Marrin.
4798 Remove scroll and clip layers for WKCACFLayerRenderer
4799 https://bugs.webkit.org/show_bug.cgi?id=45922
4801 WKCACFLayerRenderer no longer needs its own layers for managing scrolling
4802 and clipping, because RenderLayerCompositor provides this functionality.
4805 (WebView::sizeChanged): Moved code that handles the WM_SIZE message
4806 into this method. Use it to resize the layer renderer.
4807 (WebView::WebViewWndProc): Call sizeChanged().
4808 (WebView::updateRootLayerContents): No need to call setScrollFrame() any more.
4809 (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
4812 2010-09-16 Darin Adler <darin@apple.com>
4814 Reviewed by Andreas Kling.
4816 Reduce use of HTMLInputElement::inputType so we can remove it later
4817 https://bugs.webkit.org/show_bug.cgi?id=45903
4820 (WebFrame::elementDoesAutoComplete): Use isPasswordField.
4821 (WebFrame::elementIsPassword): Use isPasswordField.
4823 2010-09-14 Ada Chan <adachan@apple.com>
4825 Reviewed by Adam Roben.
4827 Add an IWebFramePrivate API to load string as plain text into the WebFrame.
4828 https://bugs.webkit.org/show_bug.cgi?id=45782
4830 * Interfaces/IWebFramePrivate.idl:
4831 * Interfaces/WebKit.idl: Touch the file.
4833 (WebFrame::loadPlainTextString):
4836 2010-09-13 Enrica Casucci <enrica@apple.com>
4838 Reviewed by Sam Weinig.
4840 Paste should be implemented in WebCore like Copy and Cut for Mac also.
4841 https://bugs.webkit.org/show_bug.cgi?id=45494
4842 <rdar://problem/7660537>
4844 On the Mac platform, the implementation of the paste operation is all done
4845 at the WebKit level. In order to support it on WebKit2 it is necessary to
4846 refactor the code and move this functionality at the level of WebCore like
4847 we already have on Windows.
4848 The original code relies on some in AppKit functions that call back into
4849 WebKit causing problems in WebKit2. All this functionality has been moved
4850 at the level of the editor client where it can be dealt with appropriately.
4853 (WebFrame::canShowMIMETypeASHTML): Added.
4855 2010-09-11 Adam Barth <abarth@webkit.org>
4857 Reviewed by Sam Weinig.
4859 Make SecurityOrigin::canDisplay an instance function
4860 https://bugs.webkit.org/show_bug.cgi?id=45219
4863 (WebFrame::allowsFollowingLink):
4865 2010-09-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
4867 Reviewed by Darin Adler.
4869 Add NetworkingContext to avoid layer violations
4870 https://bugs.webkit.org/show_bug.cgi?id=42292
4872 * WebCoreSupport/WebFrameNetworkingContext.cpp:
4873 (WebFrameNetworkingContext::blockedError):
4874 * WebCoreSupport/WebFrameNetworkingContext.h:
4876 2010-09-10 Jer Noble <jer.noble@apple.com>
4878 Reviewed by Simon Fraser.
4880 Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
4881 https://bugs.webkit.org/show_bug.cgi?id=45333
4883 The rootChild layer must be set as flipped, otherwise transformed movies will appear
4884 incorrectly rotated.
4886 * FullscreenVideoController.cpp:
4887 (FullscreenVideoController::enterFullscreen):
4889 2010-09-10 Sam Weinig <sam@webkit.org>
4891 Reviewed by Darin Adler.
4893 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
4894 Precursor to <rdar://problem/7660657>
4895 https://bugs.webkit.org/show_bug.cgi?id=45522
4903 (WebView::setZoomMultiplier):
4904 (WebView::zoomMultiplier):
4905 (WebView::canMakeTextLarger):
4906 (WebView::makeTextLarger):
4907 (WebView::canMakeTextSmaller):
4908 (WebView::makeTextSmaller):
4909 (WebView::notifyPreferencesChanged):
4911 Move tracking of text only zoom here from WebCore.
4913 2010-09-10 Brian Weinstein <bweinstein@apple.com>
4915 Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
4916 SelectionController instead of frame. Also fix a style issue.
4919 (WebFrame::currentForm):
4921 2010-09-10 Adam Barth <abarth@webkit.org>
4923 Reviewed by Darin Fisher.
4925 Move code from WebKit-layer to DocumentLoader
4926 https://bugs.webkit.org/show_bug.cgi?id=45569
4928 * WebCoreSupport/WebFrameLoaderClient.cpp:
4929 (WebFrameLoaderClient::committedLoad):
4930 * WebCoreSupport/WebFrameLoaderClient.h:
4932 2010-09-09 Darin Adler <darin@apple.com>
4934 Reviewed by Adam Barth.
4936 Move functions from Frame to SelectionController as planned
4937 https://bugs.webkit.org/show_bug.cgi?id=45508
4940 (WebView::selectionRect):
4941 (WebView::centerSelectionInVisibleArea):
4942 Call functions on selection().
4944 2010-09-10 Adam Barth <abarth@webkit.org>
4946 Reviewed by Eric Seidel.
4948 Main resource bytes shouldn't bounce through FrameLoader
4949 https://bugs.webkit.org/show_bug.cgi?id=45496
4951 Now return the bytes to the DocumentLoader.
4953 * WebCoreSupport/WebFrameLoaderClient.cpp:
4954 (WebFrameLoaderClient::receivedData):
4956 2010-09-09 Simon Fraser <simon.fraser@apple.com>
4958 Reviewed by Adam Roben.
4960 Scrollbars fail to render in composited iframes.
4961 https://bugs.webkit.org/show_bug.cgi?id=45335
4963 Use LocalWindowsContext when painting scrollbars.
4965 * WebCoreSupport/WebChromeClient.cpp:
4966 (WebChromeClient::paintCustomScrollbar):
4967 (WebChromeClient::paintCustomScrollCorner):
4969 2010-09-08 Darin Adler <darin@apple.com>
4971 Reviewed by Adam Barth.
4973 Move functions from Frame to Editor as planned
4974 https://bugs.webkit.org/show_bug.cgi?id=45218
4976 * WebCoreSupport/WebContextMenuClient.cpp:
4977 (WebContextMenuClient::searchWithGoogle):
4979 (WebFrame::selectedString):
4981 (WebView::selectedText):
4982 (WebView::prepareCandidateWindow):
4983 (WebView::onIMERequestCharPosition):
4984 Changed call sites to use editor().
4986 2010-09-08 Peter Kasting <pkasting@google.com>
4988 Not reviewed, build fix.
4991 (WebScrollBar::setScrollOffsetFromAnimation):
4993 2010-09-08 Peter Kasting <pkasting@google.com>
4995 Not reviewed, build fix.
4998 (WebScrollBar::scrollSize):
4999 (WebScrollBar::setScrollOffsetFromAnimation):
5001 2010-09-08 Peter Kasting <pkasting@google.com>
5003 Not reviewed, build fix.
5006 (WebScrollBar::setValue):
5007 (WebScrollBar::scrollSize):
5008 (WebScrollBar::setScrollOffsetFromAnimation):
5011 2010-09-08 Adam Barth <abarth@webkit.org>
5013 Attempted Window build fix.
5015 * WebDataSource.cpp:
5016 (WebDataSource::subresourceForURL):
5018 2010-09-08 Adam Barth <abarth@webkit.org>
5020 Rubber-stamped by Eric Seidel.
5022 Rename DocLoader to CachedResourceLoader because that's what it does.
5024 * WebDataSource.cpp:
5026 2010-09-07 Brent Fulgham <bfulgham@webkit.org>
5028 Reviewed by Adam Roben.
5030 Clean up a potential resource leak.
5031 https://bugs.webkit.org/show_bug.cgi?id=45198
5033 Several bitmap device context were being created and used,
5034 and destroyed without returning the context to its original
5035 state. This showed up as bitmap leaks in BoundsChecker.
5037 * FullscreenVideoController.cpp:
5039 (WebView::scrollBackingStore):
5042 2010-09-06 Adam Barth <abarth@webkit.org>
5044 Reviewed by Darin Adler.
5046 Rename SecurityOrigin::canLoad to canDisplay
5047 https://bugs.webkit.org/show_bug.cgi?id=45214
5049 Propagate name change.
5052 (WebFrame::allowsFollowingLink):
5054 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
5056 Reviewed by Darin Adler.
5058 Add NetworkingContext to avoid layer violations
5059 https://bugs.webkit.org/show_bug.cgi?id=42292
5061 Add Win's specific implementation of NetworkingContext.
5063 * WebCoreSupport/WebFrameNetworkingContext.cpp:
5064 (WebFrameNetworkingContext::create):
5065 (WebFrameNetworkingContext::userAgent):
5066 (WebFrameNetworkingContext::referrer):
5068 (WebFrame::createNetworkingContext):
5071 2010-09-03 Adam Roben <aroben@apple.com>
5073 Attempt to fixing Windows nightlies again
5075 The fix in r66438 should be sufficient, but we have to touch
5076 WebKit.idl to force that change to be picked up by the build.
5078 * Interfaces/WebKit.idl: Touched this file to force a build.
5080 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
5082 Reviewed by PavelFeldman.
5084 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
5085 https://bugs.webkit.org/show_bug.cgi?id=44230
5087 * WebCoreSupport/WebInspectorClient.cpp:
5088 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
5089 (WebInspectorFrontendClient::closeWindow):
5090 (WebInspectorFrontendClient::disconnectFromBackend):
5091 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
5092 (WebInspectorFrontendClient::destroyInspectorView):
5093 * WebCoreSupport/WebInspectorClient.h:
5095 2010-09-01 Jessie Berlin <jberlin@apple.com>
5097 Reviewed by Adam Roben.
5099 WebViews should allow their parent windows to handle WM_MOUSEACTIVATE messages.
5100 https://bugs.webkit.org/show_bug.cgi?id=45047
5103 (WebView::WebViewWndProc):
5105 2010-08-31 Dave Hyatt <hyatt@apple.com>
5107 Reviewed by Sam Weinig.
5109 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
5110 the former can occur in more places without having to do the latter.
5113 (WebFrame::paintDocumentRectToContext):
5115 (WebView::updateBackingStore):
5117 2010-08-30 Adam Roben <aroben@apple.com>
5119 Fix crash on launch on Windows due to changing IWebFramePrivate's
5122 This regressed in r65107.
5124 Fixes <http://webkit.org/b/44755>.
5126 Rubber-stamped by Jon Honeycutt.
5128 * Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and
5129 resumeAnimations to the end of the interface so that the vtable will
5130 match what Safari expects.
5132 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
5134 Unreviewed, rolling out r66198.
5135 http://trac.webkit.org/changeset/66198
5136 https://bugs.webkit.org/show_bug.cgi?id=44856
5138 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
5140 * WebCoreSupport/WebInspectorClient.cpp:
5141 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
5142 (WebInspectorFrontendClient::closeWindow):
5143 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
5144 (WebInspectorFrontendClient::destroyInspectorView):
5145 * WebCoreSupport/WebInspectorClient.h:
5147 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
5149 Reviewed by Pavel Feldman.
5151 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
5152 https://bugs.webkit.org/show_bug.cgi?id=44230
5154 * WebCoreSupport/WebInspectorClient.cpp:
5155 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
5156 (WebInspectorFrontendClient::closeWindow):
5157 (WebInspectorFrontendClient::disconnectFromBackend):
5158 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
5159 (WebInspectorFrontendClient::destroyInspectorView):
5160 * WebCoreSupport/WebInspectorClient.h:
5162 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
5164 Unreviewed. Revert r66103 since Qt tests are failing.
5166 * WebCoreSupport/WebInspectorClient.cpp:
5167 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
5168 (WebInspectorFrontendClient::closeWindow):
5169 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
5170 (WebInspectorFrontendClient::destroyInspectorView):
5171 * WebCoreSupport/WebInspectorClient.h:
5173 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
5175 Reviewed by Pavel Feldman.
5177 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
5178 https://bugs.webkit.org/show_bug.cgi?id=44230
5180 * WebCoreSupport/WebInspectorClient.cpp:
5181 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
5182 (WebInspectorFrontendClient::closeWindow):
5183 (WebInspectorFrontendClient::disconnectFromBackend):
5184 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
5185 (WebInspectorFrontendClient::destroyInspectorView):
5186 * WebCoreSupport/WebInspectorClient.h:
5188 2010-08-24 Ada Chan <adachan@apple.com>
5190 Reviewed by Steve Falkenburg.
5192 <rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType.
5193 https://bugs.webkit.org/show_bug.cgi?id=44564
5196 (WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL
5197 if plugins are disabled.
5199 2010-08-22 Daniel Bates <dbates@rim.com>
5201 Reviewed by Eric Seidel.
5203 Encapsulate document marker management into DocumentMarkerController
5204 https://bugs.webkit.org/show_bug.cgi?id=44383
5206 Modify call sites in the Apple Windows port to use DocumentMarkerController.
5208 No functionality was changed, so no new tests.
5211 (WebFrame::unmarkAllMisspellings):
5212 (WebFrame::unmarkAllBadGrammar):
5214 (WebView::rectsForTextMatches):
5216 2010-08-18 Jessie Berlin <jberlin@apple.com>
5218 Reviewed by Adam Roben.
5220 Bug 44180 - WebView::paint fails to paint a child WebView of a Layered Window.
5221 https://bugs.webkit.org/show_bug.cgi?id=44180
5223 Decide to end painting if the m_backingStoreBitmap is null after the call to
5224 ensureBackingStore() instead of when the rcPaint rect filled by BeginPaint is empty.
5225 The rcPaint rect filled by BeginPaint is always empty for a child WebView of a Layered
5226 Window, even if GetUpdateRect and GetUpdateRgn report a non-empty region that needs
5232 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
5234 Reviewed by Darin Adler.
5236 Add NetworkingContext to avoid layer violations
5237 https://bugs.webkit.org/show_bug.cgi?id=42292
5239 Preparation: Just add the files to the build system.
5241 * WebCoreSupport/WebFrameNetworkingContext.cpp: Added.
5242 Empty placeholder for now.
5243 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
5244 Placeholder with tentative code that might be changed when landing
5246 * WebKit.vcproj/WebKit.vcproj: Added new files.
5248 2010-08-17 Brady Eidson <beidson@apple.com>
5250 Reviewed by Sam Weinig.
5252 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
5253 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
5256 (WebView::canGoBack): Return false if loads are deferred.
5257 (WebView::canGoForward): Ditto.
5259 2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
5261 Unreviewed; build fix attempt for Windows.
5263 * DefaultDownloadDelegate.cpp:
5265 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
5268 https://bugs.webkit.org/show_bug.cgi?id=43794
5271 (WebView::initWithFrame):
5273 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
5275 Build fix. Matches solutions in qt and mac ports for
5276 https://bugs.webkit.org/show_bug.cgi?id=43794
5279 (WebView::initWithFrame):
5281 2010-08-10 Gavin Barraclough <barraclough@apple.com>
5283 Build fix (update more includes)
5286 * WebLocalizableStrings.cpp:
5287 * WebNotificationCenter.cpp:
5288 * WebPreferences.cpp:
5290 2010-08-10 Chris Marrin <cmarrin@apple.com>
5292 Reviewed by Oliver Hunt.
5294 Add suspendAnimations/resumeAnimation API to DRT
5295 https://bugs.webkit.org/show_bug.cgi?id=43733
5299 * Interfaces/IWebFramePrivate.idl:
5301 (WebFrame::suspendAnimations):
5302 (WebFrame::resumeAnimations):
5305 2010-08-06 Gavin Barraclough <barraclough@apple.com>
5307 Rubber stamped by Sam Weinig
5309 Bug 43594 - Add string forwards to Forward.h
5310 This allows us to remove forward declarations for these classes from
5311 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
5313 * COMVariantSetter.h:
5314 * MarshallingHelpers.h:
5315 * WebCoreSupport/WebContextMenuClient.h:
5316 * WebCoreSupport/WebPluginHalterClient.h:
5319 2010-08-06 Jessie Berlin <jberlin@apple.com>
5321 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
5324 * COMVariantSetter.h:
5325 * MarshallingHelpers.h:
5326 * WebCoreSupport/WebContextMenuClient.h:
5327 * WebCoreSupport/WebPluginHalterClient.h:
5330 2010-08-05 Jessie Berlin <jberlin@apple.com>
5332 Reviewed by Jon Honeycutt.
5334 Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL.
5335 https://bugs.webkit.org/show_bug.cgi?id=43593
5338 (WebView::backingStore):
5339 If m_backingStoreBitmap is NULL, return E_FAIL.
5341 2010-08-05 Gavin Barraclough <barraclough@apple.com>
5343 Rubber stamped by Sam Weinig
5345 Bug 43594 - Add string forwards to Forward.h
5346 This allows us to remove forward declarations for these classes from
5347 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
5349 * COMVariantSetter.h:
5350 * MarshallingHelpers.h:
5351 * WebCoreSupport/WebContextMenuClient.h:
5352 * WebCoreSupport/WebPluginHalterClient.h:
5355 2010-08-03 Adam Roben <aroben@apple.com>
5357 Turn on PLATFORM_STRATEGIES on Windows
5359 Fixes <http://webkit.org/b/43431>.
5361 Reviewed by Anders Carlsson.
5363 * WebCoreLocalizedStrings.cpp: Removed.
5364 * WebCoreSupport/WebPlatformStrategies.cpp: Added. Based on the Mac
5366 (WebPlatformStrategies::initialize): Creates the singleton instance.
5367 (WebPlatformStrategies::WebPlatformStrategies): Registers the
5368 singleton instance as the PlatformStrategies instance for WebCore.
5370 (WebPlatformStrategies::createPluginStrategy):
5371 (WebPlatformStrategies::createLocalizationStrategy):
5372 (WebPlatformStrategies::createVisitedLinkStrategy):
5373 Return ourselves as the strategy.
5375 (WebPlatformStrategies::refreshPlugins):
5376 (WebPlatformStrategies::getPluginInfo):
5377 Moved code here from WebCore's PluginDataWin.cpp file.
5379 (WebPlatformStrategies::searchableIndexIntroduction):
5380 (WebPlatformStrategies::submitButtonDefaultLabel):
5381 (WebPlatformStrategies::inputElementAltText):
5382 (WebPlatformStrategies::resetButtonDefaultLabel):
5383 (WebPlatformStrategies::fileButtonChooseFileLabel):
5384 (WebPlatformStrategies::fileButtonNoFileSelectedLabel):
5385 (WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow):
5386 (WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk):
5387 (WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard):
5388 (WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow):
5389 (WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk):
5390 (WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard):
5391 (WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow):
5392 (WebPlatformStrategies::contextMenuItemTagCopy):
5393 (WebPlatformStrategies::contextMenuItemTagGoBack):
5394 (WebPlatformStrategies::contextMenuItemTagGoForward):
5395 (WebPlatformStrategies::contextMenuItemTagStop):
5396 (WebPlatformStrategies::contextMenuItemTagReload):
5397 (WebPlatformStrategies::contextMenuItemTagCut):
5398 (WebPlatformStrategies::contextMenuItemTagPaste):
5399 (WebPlatformStrategies::contextMenuItemTagNoGuessesFound):
5400 (WebPlatformStrategies::contextMenuItemTagIgnoreSpelling):
5401 (WebPlatformStrategies::contextMenuItemTagLearnSpelling):
5402 (WebPlatformStrategies::contextMenuItemTagSearchWeb):
5403 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
5404 (WebPlatformStrategies::contextMenuItemTagOpenLink):
5405 (WebPlatformStrategies::contextMenuItemTagIgnoreGrammar):
5406 (WebPlatformStrategies::contextMenuItemTagSpellingMenu):
5407 (WebPlatformStrategies::contextMenuItemTagCheckSpelling):
5408 (WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping):
5409 (WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling):
5410 (WebPlatformStrategies::contextMenuItemTagFontMenu):
5411 (WebPlatformStrategies::contextMenuItemTagBold):
5412 (WebPlatformStrategies::contextMenuItemTagItalic):
5413 (WebPlatformStrategies::contextMenuItemTagUnderline):
5414 (WebPlatformStrategies::contextMenuItemTagOutline):
5415 (WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu):
5416 (WebPlatformStrategies::contextMenuItemTagTextDirectionMenu):
5417 (WebPlatformStrategies::contextMenuItemTagDefaultDirection):
5418 (WebPlatformStrategies::contextMenuItemTagLeftToRight):
5419 (WebPlatformStrategies::contextMenuItemTagRightToLeft):
5420 (WebPlatformStrategies::contextMenuItemTagShowSpellingPanel):
5421 (WebPlatformStrategies::contextMenuItemTagInspectElement):
5422 (WebPlatformStrategies::searchMenuNoRecentSearchesText):
5423 (WebPlatformStrategies::searchMenuRecentSearchesText):
5424 (WebPlatformStrategies::searchMenuClearRecentSearchesText):
5425 (WebPlatformStrategies::AXWebAreaText):
5426 (WebPlatformStrategies::AXLinkText):
5427 (WebPlatformStrategies::AXListMarkerText):
5428 (WebPlatformStrategies::AXImageMapText):
5429 (WebPlatformStrategies::AXHeadingText):
5430 (WebPlatformStrategies::AXDefinitionListTermText):
5431 (WebPlatformStrategies::AXDefinitionListDefinitionText):
5432 (WebPlatformStrategies::AXButtonActionVerb):
5433 (WebPlatformStrategies::AXRadioButtonActionVerb):
5434 (WebPlatformStrategies::AXTextFieldActionVerb):
5435 (WebPlatformStrategies::AXCheckedCheckBoxActionVerb):
5436 (WebPlatformStrategies::AXUncheckedCheckBoxActionVerb):
5437 (WebPlatformStrategies::AXLinkActionVerb):
5438 (WebPlatformStrategies::AXMenuListActionVerb):
5439 (WebPlatformStrategies::AXMenuListPopupActionVerb):
5440 (WebPlatformStrategies::unknownFileSizeText):
5441 (WebPlatformStrategies::uploadFileText):
5442 (WebPlatformStrategies::allFilesText):
5443 (WebPlatformStrategies::missingPluginText):
5444 (WebPlatformStrategies::crashedPluginText):
5445 (WebPlatformStrategies::imageTitle):
5446 (WebPlatformStrategies::multipleFileUploadText):
5447 (WebPlatformStrategies::mediaElementLoadingStateText):
5448 (WebPlatformStrategies::mediaElementLiveBroadcastStateText):
5449 (WebPlatformStrategies::localizedMediaControlElementString):
5450 (WebPlatformStrategies::localizedMediaControlElementHelpText):
5451 (WebPlatformStrategies::localizedMediaTimeDescription):
5452 (WebPlatformStrategies::validationMessageValueMissingText):
5453 (WebPlatformStrategies::validationMessageTypeMismatchText):
5454 (WebPlatformStrategies::validationMessagePatternMismatchText):
5455 (WebPlatformStrategies::validationMessageTooLongText):
5456 (WebPlatformStrategies::validationMessageRangeUnderflowText):
5457 (WebPlatformStrategies::validationMessageRangeOverflowText):
5458 (WebPlatformStrategies::validationMessageStepMismatchText):
5459 Moved code here from WebCoreLocalizedStrings.cpp (and slightly cleaned
5462 (WebPlatformStrategies::isLinkVisited):
5463 (WebPlatformStrategies::addVisitedLink):
5464 Copied code from WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm.
5466 * WebCoreSupport/WebPlatformStrategies.h: Added.
5468 * WebKit.vcproj/WebKit.vcproj: Removed WebCoreLocalizedStrings, added
5469 WebPlatformStrategies.
5472 (WebView::initWithFrame): Initialize WebPlatformStrategies.
5474 2010-08-03 Alexey Proskuryakov <ap@apple.com>
5476 Reviewed by Sam Weinig.
5478 https://bugs.webkit.org/show_bug.cgi?id=42939
5479 WebEditorClient::didBeginEditing is never called in WebKit2
5481 * WebView.cpp: (WebView::WebViewWndProc): Removed a call to setFocusedFrame. WebCore will
5482 now set it to main frame, and besides, this call should have been before setFocused(), not
5483 after it. My understanding is that we weren't getting all the same editing delegates on Windows,
5484 so this change may make WebKit1 on Windows behave more like Mac - but I haven't tested it.
5486 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
5488 Reviewed by Darin Fisher.
5490 PopupMenu refactoring in preparation to WebKit2
5491 https://bugs.webkit.org/show_bug.cgi?id=42592
5493 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
5494 instances, concrete classes that inherit from ChromeClient needed to be changed to
5495 implement the new methods.
5497 * WebCoreSupport/WebChromeClient.cpp:
5498 (WebChromeClient::selectItemWritingDirectionIsNatural):
5499 (WebChromeClient::createPopupMenu):
5500 (WebChromeClient::createSearchPopupMenu):
5501 * WebCoreSupport/WebChromeClient.h:
5503 2010-08-02 Jon Honeycutt <jhoneycutt@apple.com>
5505 Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
5507 Reviewed by Sam Weinig.
5509 * WebKit.vcproj/WebKit.sln:
5511 2010-08-02 Jeremy Orlow <jorlow@chromium.org>
5513 Speculative revert of 64425 due to Chromium instability
5514 https://bugs.webkit.org/show_bug.cgi?id=43347
5516 * WebCoreSupport/WebChromeClient.cpp:
5517 * WebCoreSupport/WebChromeClient.h:
5519 (WebView::mouseWheel):
5521 2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
5526 (WebView::mouseWheel):
5528 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
5530 Reviewed by Darin Fisher.
5532 PopupMenu refactoring in preparation to WebKit2
5533 https://bugs.webkit.org/show_bug.cgi?id=42592
5535 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
5536 instances, concrete classes that inherit from ChromeClient needed to be changed to
5537 implement the new methods.
5539 * WebCoreSupport/WebChromeClient.cpp:
5540 (WebChromeClient::selectItemWritingDirectionIsNatural):
5541 (WebChromeClient::createPopupMenu):
5542 (WebChromeClient::createSearchPopupMenu):
5543 * WebCoreSupport/WebChromeClient.h:
5545 2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
5547 Unreviewed, rolling out r64422.
5548 http://trac.webkit.org/changeset/64422
5549 https://bugs.webkit.org/show_bug.cgi?id=43304
5551 Build fixes are needed for Snow Leopard and Windows.
5552 (Requested by lca on #webkit).
5554 * WebCoreSupport/WebChromeClient.cpp:
5555 * WebCoreSupport/WebChromeClient.h:
5557 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
5559 Reviewed by Darin Fisher.
5561 PopupMenu refactoring in preparation to WebKit2
5562 https://bugs.webkit.org/show_bug.cgi?id=42592
5564 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
5565 instances, concrete classes that inherit from ChromeClient needed to be changed to
5566 implement the new methods.
5568 * WebCoreSupport/WebChromeClient.cpp:
5569 (WebChromeClient::selectItemWritingDirectionIsNatural):
5570 (WebChromeClient::createPopupMenu):
5571 (WebChromeClient::createSearchPopupMenu):
5572 * WebCoreSupport/WebChromeClient.h:
5574 2010-07-31 Daniel Bates <dbates@rim.com>
5576 Attempt to fix the Windows build after changeset 64409 <http://trac.webkit.org/changeset/64409>.
5579 (WebFrame::setPrinting):
5581 2010-07-30 Dan Bernstein <mitz@apple.com>
5583 Reviewed by Darin Adler.
5585 <rdar://problem/8257783> Short documents may print a second blank page
5586 https://bugs.webkit.org/show_bug.cgi?id=43271
5589 (WebFrame::setPrinting): Updated for changes to Frame::setPrinting(). Passing 0 for the
5590 page height, which maintains existing behavior.
5592 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
5594 Reviewed by David Kilzer.
5596 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
5597 https://bugs.webkit.org/show_bug.cgi?id=40627
5599 * WebCoreSupport/WebChromeClient.cpp:
5600 (WebChromeClient::reachedApplicationCacheOriginQuota):
5601 * WebCoreSupport/WebChromeClient.h:
5603 2010-07-26 Steve Block <steveblock@google.com>
5605 Reviewed by Jeremy Orlow.
5607 Page clients should be passed to Page constructor via structure of pointers
5608 https://bugs.webkit.org/show_bug.cgi?id=42834
5611 (WebView::initWithFrame):
5613 2010-07-27 Steve Block <steveblock@google.com>
5615 Reviewed by Alexey Proskuryakov.
5617 Client-based Geolocation does not pass enableHighAccuracy option to controller and client
5618 https://bugs.webkit.org/show_bug.cgi?id=40374
5620 Stub out setEnableHighAccuracy method for the Win port.
5622 * WebCoreSupport/WebGeolocationControllerClient.h:
5623 (WebGeolocationControllerClient::setEnableHighAccuracy):
5625 2010-07-22 Sam Weinig <sam@webkit.org>
5627 Reviewed by Maciej Stachowiak.
5629 Fix for <rdar://problem/8222626>
5630 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
5632 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
5633 should migrate to a new function name eventually
5635 * WebCoreSupport/WebEditorClient.cpp:
5636 (WebEditorClient::textDidChangeInTextField):
5638 2010-07-21 Brady Eidson <beidson@apple.com>
5640 Reviewed by Geoffrey Garen.
5642 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
5643 https://bugs.webkit.org/show_bug.cgi?id=42783
5646 (WebView::registerURLSchemeAsLocal):
5647 (WebView::registerURLSchemeAsSecure):
5649 2010-07-20 Steve Falkenburg <sfalken@apple.com>
5651 Reviewed by Adam Roben.
5653 WebKit on Windows should build optionally with an unversioned ICU DLL
5654 https://bugs.webkit.org/show_bug.cgi?id=42722
5655 <rdar://problem/8211767> WebKit needs to link against unversioned ICU
5657 To get the proper value for U_DISABLE_RENAMING into all source files, we force
5658 the include of ICUVersion.h (our generated header) via the compiler options.
5660 * WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h.
5662 2010-07-21 Adam Roben <aroben@apple.com>
5664 Update WebKit.sln for InjectedBundle's Debug_Internal configuration
5666 Fixes <http://webkit.org/b/42749> InjectedBundle's build
5667 configurations are screwy
5669 Reviewed by Darin Adler.
5671 * WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of
5672 InjectedBundle when we're using the Debug_Internal solution
5675 2010-07-21 Adam Roben <aroben@apple.com>
5677 Add MiniBrowser to WebKit.sln
5679 It is the last project to build.
5681 Fixes <http://webkit.org/b/42747> build-webkit should build
5684 Reviewed by Darin Adler.
5686 * WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on
5689 2010-07-20 Adam Roben <aroben@apple.com>
5691 Add WebKitTestRunner and friends to WebKit.sln
5693 We added these projects to WebKit2.sln in r63585, but removed them
5694 again in r63600 because WebKitTestRunner required getopt, which
5695 doesn't exist in WebKitAuxiliaryLibrary. r63700 and r63788 removed the
5696 use of getopt in WebKitTestRunner, so we can now add it to WebKit.sln
5697 (which has replaced WebKit2.sln).
5699 Fixes <http://webkit.org/b/42711> WebKit.sln should build
5702 Reviewed by Steve Falkenburg.
5704 * WebKit.vcproj/WebKit.sln: Added the following projects to the end of
5705 the build order (in first-built to last-built order):
5706 InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. Also
5707 removed an unnecessary dependency from testapi on WebKit2WebProcess.
5709 2010-07-19 Daniel Bates <dbates@rim.com>
5711 Reviewed by Adam Roben.
5713 [Win] Implement LayoutTestController::markerTextForListItem()
5714 https://bugs.webkit.org/show_bug.cgi?id=37930
5716 Implements support for markerTextForListItem in the Windows port.
5718 * DOMCoreClasses.cpp:
5719 (DOMElement::markerTextForListItem): Added.
5721 * Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
5722 * Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
5723 * Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
5725 (WebView::elementFromJS): Added.
5728 2010-07-16 Zhe Su <suzhe@chromium.org>
5730 Reviewed by Darin Adler.
5732 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
5733 https://bugs.webkit.org/show_bug.cgi?id=42253
5735 Dummy implementation of EditorClient::willSetInputMethodState.
5737 * WebCoreSupport/WebEditorClient.cpp:
5738 (WebEditorClient::willSetInputMethodState):
5739 * WebCoreSupport/WebEditorClient.h:
5741 2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
5743 Reviewed by Pavel Feldman.
5745 Make JS memory stats available via 'Performance' object (Web Timing).
5746 This statistics is populated only if 'WebKitMemoryInfoEnabled'
5749 'console.memory' is kept until Web Timing object becomes visible by
5750 default (currently it is hidden under compile-time flag). These stats
5751 are guarded with the same preference.
5753 https://bugs.webkit.org/show_bug.cgi?id=41617
5755 * Interfaces/IWebPreferencesPrivate.idl:
5756 * WebPreferenceKeysPrivate.h:
5757 * WebPreferences.cpp:
5758 (WebPreferences::initializeDefaultSettings):
5759 (WebPreferences::memoryInfoEnabled):
5760 (WebPreferences::setMemoryInfoEnabled):
5763 (WebView::notifyPreferencesChanged):
5765 2010-07-14 Brent Fulgham <bfulgham@webkit.org>
5767 Reviewed by Steve Falkenburg.
5769 Patch for https://bugs.webkit.org/show_bug.cgi?id=42299
5770 Correct WinCairo build for new WebKit2 project structure.
5772 * WebKit.vcproj/WebKit.sln:
5774 2010-07-14 Sam Weinig <sam@webkit.org>
5776 Reviewed by Darin Adler.
5778 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
5779 Make changing Cursors work in WebKit2.
5781 * WebCoreSupport/WebChromeClient.cpp:
5782 (WebChromeClient::setCursor):
5783 We now need to grab the native cursor out of the WebCore cursor.
5785 (WebChromeClient::setLastSetCursorToCurrentCursor):
5786 Sets the WebView's "last set cursor" to be the current cursor so that
5787 the cursor is set correctly for plugins.
5788 * WebCoreSupport/WebChromeClient.h:
5791 (WebView::WebViewWndProc):
5793 (WebView::setLastCursor):
5794 Change the "last set cursor" to be stored as a member instead of a global.
5796 2010-07-13 Steve Falkenburg <sfalken@apple.com>
5799 Make WebKit.sln build WebKit.dll as it used to in the past.
5800 (sln is updated to include necessary projects)
5802 * WebKit.vcproj/WebKit.sln:
5804 2010-07-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
5808 * Interfaces/WebKit.idl: Touched to force a build
5810 2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
5812 Reviewed by Darin Adler.
5814 Prevent assertion/duplicate loads for non-deferred subtitute-data loads
5816 https://bugs.webkit.org/show_bug.cgi?id=30879
5818 MainResourceLoader uses the member m_initialRequest to store requests for future
5819 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
5820 have to clear this request so that subsequent entries into the loader will not
5821 start yet another load.
5823 This can happen as a result of a PageGroupLoadDeferrer going out of scope when
5824 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
5825 but only in the case of using both substitute-data and non-deferred main resource
5826 load together. That's why two new DRT functions were added:
5828 * queueLoadHTMLString()
5829 * setDeferMainResourceLoad()
5831 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
5832 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
5833 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
5835 * Interfaces/IWebDataSource.idl:
5836 * WebDataSource.cpp:
5837 (WebDataSource::setDeferMainResourceDataLoad):
5840 2010-07-12 Steve Falkenburg <sfalken@apple.com>
5842 Reviewed by Alice Liu.
5844 <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
5845 https://bugs.webkit.org/show_bug.cgi?id=40921
5847 Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
5848 WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
5850 This is a first step. We'll likely want to migrate the remainder of
5851 the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
5853 * WebKit.vcproj/WebKit.def: Removed.
5854 * WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL.
5855 * WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib.
5856 Renamed project name to WebKitLib to avoid confusion and naming conflicts.
5857 Generate intermediate pdb file for debuggability of static lib.
5858 Removed DLL-related options.
5859 * WebKit.vcproj/deleteButton.png: Removed.
5860 * WebKit.vcproj/deleteButtonPressed.png: Removed.
5861 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed.
5862 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed.
5863 * WebKit.vcproj/fsVideoExitFullscreen.png: Removed.
5864 * WebKit.vcproj/fsVideoPause.png: Removed.
5865 * WebKit.vcproj/fsVideoPlay.png: Removed.
5866 * WebKit.vcproj/missingImage.png: Removed.
5867 * WebKit.vcproj/nullplugin.png: Removed.
5868 * WebKit.vcproj/panEastCursor.png: Removed.
5869 * WebKit.vcproj/panIcon.png: Removed.
5870 * WebKit.vcproj/panNorthCursor.png: Removed.
5871 * WebKit.vcproj/panNorthEastCursor.png: Removed.
5872 * WebKit.vcproj/panNorthWestCursor.png: Removed.
5873 * WebKit.vcproj/panSouthCursor.png: Removed.
5874 * WebKit.vcproj/panSouthEastCursor.png: Removed.
5875 * WebKit.vcproj/panSouthWestCursor.png: Removed.
5876 * WebKit.vcproj/panWestCursor.png: Removed.
5877 * WebKit.vcproj/searchCancel.png: Removed.
5878 * WebKit.vcproj/searchCancelPressed.png: Removed.
5879 * WebKit.vcproj/searchMagnifier.png: Removed.
5880 * WebKit.vcproj/searchMagnifierResults.png: Removed.
5881 * WebKit.vcproj/textAreaResizeCorner.png: Removed.
5882 * WebKit.vcproj/verticalTextCursor.png: Removed.
5883 * WebKit.vcproj/zoomInCursor.png: Removed.
5884 * WebKit.vcproj/zoomOutCursor.png: Removed.
5886 2010-07-08 Aaron Boodman <aa@chromium.org>
5888 Reviewed by Timothy Hatcher.
5890 Add the ability for user scripts and user styles to affect just the top frame.
5892 https://bugs.webkit.org/show_bug.cgi?id=41529
5895 (WebView::addUserScriptToGroup):
5896 (WebView::addUserStyleSheetToGroup):
5898 2010-07-08 Adele Peterson <adele@apple.com>
5900 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
5902 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721
5903 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
5905 Implement shouldMissingPluginMessageBeButton.
5907 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::shouldMissingPluginMessageBeButton):
5908 * WebCoreSupport/WebChromeClient.h:
5910 2010-07-07 Anders Carlsson <andersca@apple.com>
5912 Reviewed by Simon Fraser.
5914 Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
5915 https://bugs.webkit.org/show_bug.cgi?id=41781
5917 * WebKit.vcproj/WebKit.sln:
5919 2010-07-07 Sam Weinig <sam@webkit.org>
5921 Reviewed by Anders Carlsson.
5923 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
5924 Add basic piping for BackForwardControllerClient.
5927 (WebView::initWithFrame):
5929 2010-07-07 Adam Roben <aroben@apple.com>
5933 * Interfaces/WebKit.idl: Touched to force a build.
5935 2010-07-06 Steve Falkenburg <sfalken@apple.com>
5937 Reviewed by Simon Fraser.
5939 Expose URL matching from WebUserContentURLPattern
5940 https://bugs.webkit.org/show_bug.cgi?id=41726
5941 <rdar://problem/7910144>
5943 We previously had a way to construct WebUserContentURLPattern
5944 instances via WebKit, but no way for callers to perform matching.
5945 This patch adds the matchesURL functionality to allow for this.
5947 * Interfaces/IWebUserContentURLPattern.idl: Added matchesURL.
5948 * Interfaces/IWebView.idl: Touch to force a build.
5949 * WebUserContentURLPattern.cpp:
5950 (WebUserContentURLPattern::matchesURL): Added. Calls through to WebCore::UserContentURLPattern::matches.
5951 * WebUserContentURLPattern.h: Added matchesURL.
5953 2010-07-03 Jon Honeycutt <jhoneycutt@apple.com>
5955 The missing plug-in indicator should be clickable
5957 https://bugs.webkit.org/show_bug.cgi?id=41550
5958 <rdar://problem/8132162>
5960 From an original patch by Kevin Decker.
5962 Reviewed by Darin Adler.
5964 * Interfaces/IWebUIDelegatePrivate.idl:
5965 Added a new delegate interface, and declare a function
5966 didPressMissingPluginButton().
5968 * Interfaces/WebKit.idl:
5969 Touch this file to force interfaces to be rebuilt.
5971 * WebCoreSupport/WebChromeClient.cpp:
5972 (WebChromeClient::missingPluginButtonClicked):
5973 Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
5974 didPressMissingPluginButton() function.
5976 * WebCoreSupport/WebChromeClient.h:
5977 Declare an override of missingPluginButtonClicked().
5979 2010-07-03 Erik Arvidsson <arv@chromium.org>
5981 Reviewed by Ojan Vafai.
5983 Fix issue where a contextmenu event was reporting the wrong target
5984 if the context menu was shown due to pressing the context menu key
5988 (WebView::handleContextMenuEvent):
5990 2010-07-01 Steve Falkenburg <sfalken@apple.com>
5992 Reviewed by Adele Peterson.
5994 Provide a WebView preference to disable DNS prefetching on Windows
5995 https://bugs.webkit.org/show_bug.cgi?id=41504
5996 <rdar://problem/8151939>
5998 * Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
5999 * Interfaces/WebKit.idl: Touched to force IDL build.
6000 * WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
6001 * WebPreferences.cpp:
6002 (WebPreferences::initializeDefaultSettings): Default prefetch to true.
6003 (WebPreferences::setDNSPrefetchingEnabled): Added.
6004 (WebPreferences::isDNSPrefetchingEnabled): Added.
6005 * WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
6007 (WebView::notifyPreferencesChanged): Propagate prefetch pref into settings.
6009 2010-06-21 Nate Chapin <japhet@chromium.org>
6011 Unreviewed, Windows build fix.
6013 Update WebFrame to use FrameLoaderStateMachine in
6017 (WebFrame::firstLayoutDone):
6019 2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
6021 Reviewed by Adam Barth.
6023 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
6024 https://bugs.webkit.org/show_bug.cgi?id=39041
6027 (WebView::notifyPreferencesChanged):
6029 2010-06-16 Adam Roben <aroben@apple.com>
6031 Add a "forPrinting" boolean parameter to
6032 IWebFramePrivate::renderTreeAsExternalRepresentation
6034 Fixes <http://webkit.org/b/40727> Respect
6035 LayoutTestController::isPrinting on Windows.
6037 Reviewed by Dan Bernstein.
6039 * Interfaces/IWebFramePrivate.idl: Renamed the current
6040 renderTreeAsExternalRepresentation to unused1, and added a new version
6041 that takes a boolean "forPrinting" parameter.
6043 * Interfaces/WebKit.idl: Touched to force a build.
6046 (WebFrame::renderTreeAsExternalRepresentation): Added a boolean
6047 "forPrinting" parameter, and used it to tell externalRepresentation
6048 what kind of behavior to use.
6050 * WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and
6053 2010-06-15 Darin Adler <darin@apple.com>
6055 Reviewed by Adam Barth.
6057 Move functions out of Frame class that were marked "move to Chrome"
6058 https://bugs.webkit.org/show_bug.cgi?id=39636
6061 (WebView::shouldClose): Call shouldClose on FrameLoader instead of
6062 going through Frame.
6064 2010-06-14 Adam Roben <aroben@apple.com>
6066 Add WebKitLauncherWin to WebKit.sln
6068 Fixes <http://webkit.org/b/40583>.
6070 Reviewed by Darin Adler.
6072 * WebKit.vcproj/WebKit.sln: Added WebKitLauncherWin.vcproj. It depends
6073 on WebKitAPITest, so is the last project to build. (Also removed
6074 QTMovieWin's direct dependency on JavaScriptCore, since it already has
6075 an indirect dependency on it.)
6077 2010-06-14 Chang Shu <chang.shu@nokia.com>
6079 Reviewed by Kenneth Rohde Christiansen.
6081 [win] Make windows compile after API changes.
6083 https://bugs.webkit.org/show_bug.cgi?id=40434
6085 * WebKitGraphics.cpp:
6088 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
6090 Reviewed by Pavel Feldman.
6092 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
6093 data from inspected page to WebInspector as JSON string via http. The native
6094 serialization to JSON string is supported by InspectorValue's classes. This patch
6095 has the implementation of sendMessageToFrontend function. WebKit version of it still
6096 uses ScriptFunctionCall and will be switched to another transport a little bit later.
6097 https://bugs.webkit.org/show_bug.cgi?id=40134
6099 * WebCoreSupport/WebInspectorClient.cpp:
6100 (WebInspectorClient::WebInspectorClient):
6101 (WebInspectorClient::~WebInspectorClient):
6102 (WebInspectorClient::openInspectorFrontend):
6103 * WebCoreSupport/WebInspectorClient.h:
6105 2010-06-10 Eric Seidel <eric@webkit.org>
6107 Reviewed by Adam Barth.
6109 Reduce FrameView.h includes to speed up build times
6110 https://bugs.webkit.org/show_bug.cgi?id=40408
6112 Another fix for Windows.
6116 2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
6118 Unreviewed, rolling out r60889.
6119 http://trac.webkit.org/changeset/60889
6120 https://bugs.webkit.org/show_bug.cgi?id=40365
6122 gtk bot has some kind of memory corruption (Requested by
6125 * WebCoreSupport/WebInspectorClient.cpp:
6126 (WebInspectorClient::WebInspectorClient):
6127 (WebInspectorClient::~WebInspectorClient):
6128 (WebInspectorClient::openInspectorFrontend):
6129 * WebCoreSupport/WebInspectorClient.h:
6130 (WebInspectorClient::frontendClosing):
6132 2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
6134 Reviewed by Pavel Feldman.
6136 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
6137 data from inspected page to WebInspector as JSON string via http. The native
6138 serialization to JSON string is supported by InspectorValue's classes. This patch
6139 has the implementation of sendMessageToFrontend function. WebKit version of it still
6140 uses ScriptFunctionCall and will be switched to another transport a little bit later.
6141 https://bugs.webkit.org/show_bug.cgi?id=40134
6143 * WebCoreSupport/WebInspectorClient.cpp:
6144 (WebInspectorClient::WebInspectorClient):
6145 (WebInspectorClient::~WebInspectorClient):
6146 (WebInspectorClient::openInspectorFrontend):
6147 * WebCoreSupport/WebInspectorClient.h:
6149 2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
6151 Reviewed by Ojan Vafai and Darin Adler.
6153 Refactor platform dependent editing behavior code out of Settings
6154 https://bugs.webkit.org/show_bug.cgi?id=39854
6156 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
6157 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
6160 (WebView::notifyPreferencesChanged):
6162 2010-06-04 Alice Liu <alice.liu@apple.com>
6164 Reviewed by Jon Honeycutt.
6166 WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars
6167 https://bugs.webkit.org/show_bug.cgi?id=40034
6168 <rdar://problem/7799848>
6171 (WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint.
6172 Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint().
6174 Just renaming changes:
6175 * Interfaces/IWebFramePrivate.idl:
6176 * Interfaces/IWebViewPrivate.idl:
6179 (WebView::paintScrollViewRectToContextAtPoint):
6182 * Interfaces/WebKit.idl: Touched for rebuild.
6184 2010-05-30 Daniel Bates <dbates@rim.com>
6186 Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.
6189 (WebFrame::elementWithName):
6190 (WebFrame::controlsInForm):
6192 2010-05-22 Jer Noble <jer.noble@apple.com>
6194 Reviewed by Adam Roben.
6196 Full screen doesn't work for video elements
6197 https://bugs.webkit.org/show_bug.cgi?id=39557
6198 rdar://problem/8011813
6200 Modified FullscreenVideoController to work with MediaPlayerPrivateFullscreenWindow. The FullscreenVideoController
6201 is now MediaPlayerPrivate agnostic..
6203 * FullscreenVideoController.cpp:
6204 (FullscreenVideoController::LayoutClient::LayoutClient): New helper class which implements WKCACFLayerLayoutClient.
6205 (FullscreenVideoController::LayoutClient::layoutSublayersOfLayer):
6206 (FullscreenVideoController::FullscreenVideoController):
6207 (FullscreenVideoController::~FullscreenVideoController):
6208 (FullscreenVideoController::enterFullscreen):
6209 (FullscreenVideoController::exitFullscreen):
6210 (FullscreenVideoController::fullscreenClientWndProc): Handle WM_KEYDOWN.
6211 (FullscreenVideoController::createHUDWindow):
6212 (FullscreenVideoController::hudWndProc): Handle WM_KEYDOWN.
6213 (FullscreenVideoController::onChar):
6214 (FullscreenVideoController::onKeyDown): New function: handles the VK_ESCAPE case more reliably than WM_CHAR.
6215 * FullscreenVideoController.h:
6217 (WebView::viewWindow): Added a simple viewWindow() accessor.
6219 2010-05-25 Brady Eidson <beidson@apple.com>
6221 Reviewed by Darin Adler.
6223 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms)
6224 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486
6226 * WebDatabaseManager.cpp:
6227 (WebKitInitializeWebDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on
6228 an already created tracker that already has its origins populated.
6229 * WebDatabaseManager.h:
6232 (WebView::initWithFrame): Call a renamed method instead.
6234 2010-05-25 Ada Chan <adachan@apple.com>
6236 Reviewed by Steve Falkenburg.
6238 https://bugs.webkit.org/show_bug.cgi?id=39651
6240 Make m_closeWindowTimer a SuspendableTimer, so it is properly suspended
6241 when page loading is deferred.
6244 (WebView::WebView): m_closeWindowTimer is now a pointer to a SuspendableTimer.
6245 (WindowCloseTimer::create):
6246 (WindowCloseTimer::WindowCloseTimer):
6247 (WindowCloseTimer::contextDestroyed): Make sure we delete the WindowCloseTimer in the end.
6248 (WindowCloseTimer::fired):
6249 (WebView::closeWindowSoon):
6250 (WebView::closeWindowTimerFired):
6251 (WebView::notifyPreferencesChanged): Can just check for the existence m_closeWindowTimer, since
6252 we only create it when we need to start the timer.
6255 2010-05-24 Darin Adler <darin@apple.com>
6257 Reviewed by Eric Seidel.
6259 Move view-related functions from Frame to FrameView
6260 https://bugs.webkit.org/show_bug.cgi?id=39366
6263 (WebFrame::setTextSizeMultiplier): Call function on FrameView.
6265 (WebView::setZoomMultiplier): Ditto.
6267 2010-05-24 Anders Carlsson <andersca@apple.com>
6269 Yet another Windows build fix.
6272 (WebView::canShowMIMEType):
6273 Use the right capitalizatinon of 'MIME' (which also happens to be incorrect according to our guidelines).
6275 2010-05-24 Anders Carlsson <andersca@apple.com>
6277 Another Windows build fix.
6280 Don't include PlugInInfoStore.h, instead include PluginData.h
6282 2010-05-24 Anders Carlsson <andersca@apple.com>
6287 (WebView::canShowMIMEType):
6289 2010-05-21 Steve Block <steveblock@google.com>
6291 Reviewed by Jeremy Orlow.
6293 Add DeviceOrientation and DeviceOrientationClient
6294 https://bugs.webkit.org/show_bug.cgi?id=39479
6297 (WebView::initWithFrame):
6299 2010-05-20 Simon Fraser <simon.fraser@apple.com>
6301 Build fix, no review.
6303 Fix the non-accelerated-compositing Windows build with some
6304 #if USE(ACCELERATED_COMPOSITING) loving.
6309 2010-05-20 Simon Fraser <simon.fraser@apple.com>
6311 Reviewed by Adam Roben.
6313 Avoid flushing CA layers when a layout is pending
6314 https://bugs.webkit.org/show_bug.cgi?id=39463
6316 <rdar://problem/7999463>
6318 Avoid rendering the compositing layers to the screen if there's a layout pending,
6319 since the layer tree not in a state that should be presented to the user.
6321 This fixes flashes in some types of content that dynamically add and remove layers.
6323 Have the WebView implement WKCACFLayerRendererClient so that the
6324 WKCACFLayerRenderer can ask whether it's a good time to render. If the FrameView
6325 has a layout pending, say no.
6329 (WebView::setAcceleratedCompositing):
6330 (WebView::shouldRender):
6332 2010-05-18 Brent Fulgham <bfulgham@webkit.org>
6334 Reviewed by Adam Roben.
6336 [WinCairo] Correct scaling for print preview
6337 https://bugs.webkit.org/show_bug.cgi?id=39329
6339 Cairo does not properly deal with Windows HDCs that have been
6340 scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
6341 ViewportExt setting.
6342 (see http://bugs.freedesktop.org/show_bug.cgi?id=28161)
6344 Instead, reset the HDC's WorldTransform to be unscaled, then
6345 scale the cairo context to the desired scaling, and perform
6346 the drawing operation.
6349 (WebFrame::drawHeader): Use pre-positioned context to simplify
6351 (WebFrame::drawFooter): Use pre-positioned context to simplify
6353 (WebFrame::spoolPage): Revise scaling logic to turn off HDC
6354 scaling, and scale using only Cairo. Revert scaling at end
6355 so that user-defined GDI-based routines (e.g., header/footer)
6356 will draw in the right position.
6357 (WebFrame::spoolPages): Identify print preview case, and
6358 retrieve scaling factors from preview context. Set the
6359 Cairo context to use these factors during the spoolPage
6362 2010-05-20 Martin Robinson <mrobinson@igalia.com>
6366 Touch WebKit.idl to ensure that interfaces rebuild.
6368 * Interfaces/WebKit.idl: Touched.
6370 2010-05-20 Martin Robinson <mrobinson@igalia.com>
6372 Reviewed by Adam Roben.
6374 Fix the Windows build and move new IDL declarations to the bottom of the file.
6376 * Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
6377 * WebPreferences.cpp:
6378 (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.
6380 2010-05-20 Martin Robinson <mrobinson@igalia.com>
6384 Fix the Windows build.
6387 (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.
6389 2010-05-20 Martin Robinson <mrobinson@webkit.org>
6391 Reviewed by Ojan Vafai.
6393 Expose the editing behavior setting in DRT to test all editing code paths
6394 https://bugs.webkit.org/show_bug.cgi?id=38603
6396 Expose the EditingBehavior setting in the Windows API.
6398 * Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior.
6399 * WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting.
6400 * WebPreferences.cpp:
6401 (WebPreferences::editingBehavior): Added.
6402 (WebPreferences::setEditingBehavior): Added.
6403 * WebPreferences.h: Add method declarations.
6405 (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting.
6407 2010-05-20 Chris Jerdonek <cjerdonek@webkit.org>
6409 Reviewed by Eric Seidel.
6411 Modified FrameLoader::urlSelected() to accept a KURL instead of a
6414 https://bugs.webkit.org/show_bug.cgi?id=39320
6416 Since ResourceRequest has non-explicit single-parameter constructors for
6417 String and KURL, urlSelected() previously accepted any of String, KURL,
6418 and ResourceRequest. This revision changes urlSelected() to accept only
6419 a KURL to make the API tighter and easier to refactor.
6421 * WebCoreSupport/WebContextMenuClient.cpp:
6422 (WebContextMenuClient::searchWithGoogle):
6423 - Updated the call to urlSelected().
6425 2010-05-13 Brian Weinstein <bweinstein@apple.com>
6427 Reviewed by Tim Hatcher.
6429 <rdar://problem/7982652>
6431 Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.
6433 * Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
6434 * Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
6436 (WebView::reportException): Make sure the function was called with a context from a WebView, and call
6437 WebCore::reportException.
6440 2010-05-12 Jer Noble <jer.noble@apple.com>
6442 Reviewed by Darin Adler.
6444 Bug 38689: #34005 will break fullscreen video playback
6445 https://bugs.webkit.org/show_bug.cgi?id=38689
6447 Use the new definition of PlatformMedia to check the actual type
6448 returned by MediaPlayer.
6450 * FullscreenVideoController.cpp:
6451 (FullscreenVideoController::movie):
6453 2010-05-11 Jer Noble <jer.noble@apple.com>
6457 Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.
6459 * WebKit.vcproj/WebKit.sln:
6461 2010-05-11 Alice Liu <alice.liu@apple.com>
6463 Rubber-stamped by Gavin Barraclough.
6465 Fix build error when enabling debugging block in WebKit win painting code
6468 (WebView::paintIntoBackingStore):
6470 2010-05-11 Alice Liu <alice.liu@apple.com>
6472 Reviewed by Steve Falkenburg.
6474 https://bugs.webkit.org/show_bug.cgi?id=38937
6475 W7 window preview paints content at the wrong location
6478 (WebFrame::paintDocumentRectToContext): Revert r58895
6479 (WebFrame::paintDocumentRectToContextAtPoint): Added
6481 * Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
6482 * Interfaces/IWebViewPrivate.idl: ditto
6483 * Interfaces/WebKit.idl: touch to rebuild
6485 * WebView.cpp: ditto
6486 (WebView::paintDocumentRectToContextAtPoint): ditto
6489 2010-05-07 Jer Noble <jer.noble@apple.com>
6491 Reviewed by Adele Peterson.
6493 Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
6494 https://bugs.webkit.org/show_bug.cgi?id=34005
6496 QTMovieWin is now QTMovieGWorld.
6497 * FullscreenVideoController.cpp:
6498 (FullscreenVideoController::movie):
6499 * FullscreenVideoController.h:
6501 2010-05-06 Adam Roben <aroben@apple.com>
6503 Bail out of WebView::paint when there's nothing to paint
6505 Fixes <http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION
6506 (r58067): Crash in WebView::paint when Web Inspector is docked and
6507 window is resized so small that WebView disappears
6509 When the WebView is 0-sized, ensureBackingStore() bails out without
6510 creating a bitmap, leaving m_backingStoreBitmap null. Before r58067,
6511 m_backingStoreBitmap was an HBITMAP, so we were happily passing along
6512 a null HBITMAP to various Windows APIs. These calls would fail but not
6513 crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and
6514 dereferencing a null RefCountedHBITMAP* of course crashes.
6516 Reviewed by Steve Falkenburg.
6519 (WebView::paint): Bail if the rect to paint is empty.
6521 2010-05-06 Steve Falkenburg <sfalken@apple.com>
6523 Reviewed by Adam Roben.
6525 WebFrame::paintDocumentRectToContext paints content at the wrong location
6526 https://bugs.webkit.org/show_bug.cgi?id=38651
6529 (WebFrame::paintDocumentRectToContext):
6531 2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
6533 Reviewed by Darin Fisher.
6535 Update setFocus for the new boolean argument; no behavioral change.
6537 https://bugs.webkit.org/show_bug.cgi?id=37961
6539 * WebCoreSupport/EmbeddedWidget.cpp:
6540 (EmbeddedWidget::setFocus):
6541 * WebCoreSupport/EmbeddedWidget.h:
6543 2010-05-03 Abhishek Arya <inferno@chromium.org>
6545 Reviewed by Adam Barth.
6547 Add support for controlling clipboard access from javascript.
6548 Clipboard access from javascript is disabled by default.
6549 https://bugs.webkit.org/show_bug.cgi?id=27751
6551 * Interfaces/IWebPreferencesPrivate.idl:
6552 * WebPreferenceKeysPrivate.h:
6553 * WebPreferences.cpp:
6554 (WebPreferences::initializeDefaultSettings):
6555 (WebPreferences::javaScriptCanAccessClipboard):
6556 (WebPreferences::setJavaScriptCanAccessClipboard):
6559 (WebView::notifyPreferencesChanged):
6561 2010-05-03 Jens Alfke <snej@chromium.org>
6563 Reviewed by Darin Fisher.
6565 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
6566 https://bugs.webkit.org/show_bug.cgi?id=38397
6568 No tests (functionality is exposed only through native WebKit API.)
6572 2010-04-30 Jon Honeycutt <jhoneycutt@apple.com>
6574 Caret may fail to blink if a focus handler brings up a modal dialog
6575 https://bugs.webkit.org/show_bug.cgi?id=38372
6577 Reviewed by Darin Adler.
6580 (WebView::handleMouseEvent):
6581 If the message is WM_CANCELMODE, which indicates that we our capturing
6582 of mouse events has been cancelled, tell the EventHandler.
6583 It's possible to re-enter this function if handling a mouse event allows
6584 the message loop to run; moved up the call to setMouseActivated(), so
6585 that if we do re-enter this function, the later mouse event will not be
6586 considered as activating the window.
6587 (WebView::WebViewWndProc):
6588 Handle WM_CANCELMODE by calling handleMouseEvent().
6590 2010-04-29 Anders Carlsson <andersca@apple.com>
6592 Reviewed by Dan Bernstein.
6595 https://bugs.webkit.org/show_bug.cgi?id=20784
6596 move npapi.h to C99 integer types.
6598 * WebKit.vcproj/WebKit.vcproj:
6600 2010-04-28 Beth Dakin <bdakin@apple.com>
6602 Reviewed by Darin Adler.
6604 Fix for <rdar://problem/7474349>
6606 Add a synchronous display mechanism for WKCACFLayerRenderer.
6608 * Interfaces/IWebViewPrivate.idl:
6609 * Interfaces/WebKit.idl:
6612 (WebView::updateRootLayerContents):
6613 (WebView::nextDisplayIsSynchronous):
6616 2010-04-28 Steve Falkenburg <sfalken@apple.com>
6618 Reviewed by Maciej Stachowiak.
6620 WebView drawing code may access null backing store dirty region
6621 https://bugs.webkit.org/show_bug.cgi?id=38245
6622 <rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)
6625 (WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.
6627 2010-04-27 Jon Honeycutt <jhoneycutt@apple.com>
6629 <rdar://problem/7911140> Hitting the "delete" key goes back twice
6631 Reviewed by Maciej Stachowiak.
6635 Return true if we navigated back or forward from the key event to
6636 prevent the event from being propagated further.
6638 2010-04-25 Sam Weinig <sam@webkit.org>
6640 Reviewed by Maciej Stachowiak.
6642 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
6643 Disentangle initializing the main thread from initializing threading
6645 * WebKitClassFactory.cpp:
6646 (WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread.
6648 (WebView::WebView): Ditto.
6650 2010-04-25 Yury Semikhatsky <yurys@chromium.org>
6652 Reviewed by Pavel Feldman.
6654 Web Inspector: inspector client shouldn't check if it can be opened
6655 docked if it is already in that state.
6657 https://bugs.webkit.org/show_bug.cgi?id=37946
6659 * WebCoreSupport/WebInspectorClient.cpp:
6660 (WebInspectorFrontendClient::WebInspectorFrontendClient):
6661 (WebInspectorFrontendClient::showWindowWithoutNotifications):
6662 * WebCoreSupport/WebInspectorClient.h:
6664 2010-04-24 Steve Falkenburg <sfalken@apple.com>
6666 Reviewed by Sam Weinig.
6668 Typo in Geolocation code causes crashes when updates are stopped
6669 https://bugs.webkit.org/show_bug.cgi?id=38089
6670 <rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation
6672 * WebCoreSupport/WebGeolocationControllerClient.cpp:
6673 (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register.
6675 2010-04-23 Andy Estes <aestes@apple.com>
6677 Rubber stamped by Steve Falkenburg.
6679 Roll out http://trac.webkit.org/changeset/55385.
6681 <rdar://problem/7884444>
6683 * Interfaces/IWebUIDelegatePrivate.idl:
6684 * Interfaces/WebKit.idl:
6685 * WebCoreSupport/WebFrameLoaderClient.cpp:
6686 (WebFrameLoaderClient::createPlugin):
6688 2010-04-22 Dave Moore <davemoore@chromium.org>
6690 Reviewed by Dimitri Glazkov.
6692 Added notification when the favicons for a page are changed
6694 The Document object will notify the frame loader, which will
6695 notify the client. Implementations of FrameLoaderClient will
6696 have to add one method; dispatchDidChangeIcons().
6698 https://bugs.webkit.org/show_bug.cgi?id=33812
6700 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
6701 * WebCoreSupport/WebFrameLoaderClient.cpp:
6702 (WebFrameLoaderClient::dispatchDidChangeIcons):
6703 * WebCoreSupport/WebFrameLoaderClient.h:
6705 (WebFrame::didChangeIcons):
6708 2010-04-22 Adam Barth <abarth@webkit.org>
6710 Unreviewed, rolling out r58069.
6711 http://trac.webkit.org/changeset/58069
6712 https://bugs.webkit.org/show_bug.cgi?id=27751
6714 Broke compile on Windows.
6716 * Interfaces/IWebPreferencesPrivate.idl:
6717 * WebPreferenceKeysPrivate.h:
6718 * WebPreferences.cpp:
6719 (WebPreferences::initializeDefaultSettings):
6722 (WebView::notifyPreferencesChanged):
6724 2010-04-22 Abhishek Arya <inferno@chromium.org>
6726 Reviewed by Adam Barth.
6728 Add support for controlling clipboard access from javascript.
6729 Clipboard access from javascript is disabled by default.
6730 https://bugs.webkit.org/show_bug.cgi?id=27751
6732 * Interfaces/IWebPreferencesPrivate.idl:
6733 * WebPreferenceKeysPrivate.h:
6734 * WebPreferences.cpp:
6735 (WebPreferences::initializeDefaultSettings):
6736 (WebPreferences::javaScriptCanAccessClipboard):
6737 (WebPreferences::setJavaScriptCanAccessClipboard):
6740 (WebView::notifyPreferencesChanged):
6742 2010-04-21 Andy Estes <aestes@apple.com>
6744 Reviewed by Maciej Stachowiak.
6746 Reference count WebView's backing store bitmap to prevent
6747 deleteBackingStore() from freeing the bitmap while it is still being
6748 referenced by Core Animation.
6750 https://bugs.webkit.org/show_bug.cgi?id=37954
6753 (WebView::ensureBackingStore):
6754 (WebView::addToDirtyRegion):
6755 (WebView::scrollBackingStore):
6756 (WebView::updateBackingStore):
6758 (WebView::backingStore):
6759 (releaseBackingStoreCallback): deref m_backingStoreBitmap once Core
6760 Animation has dropeed its reference to the memory.
6761 (WebView::updateRootLayerContents): ref m_backingStoreBitmap before
6762 passing the memory to Core Animation to prevent deleteBackingStore()
6763 from freeing it while it is still referenced by CA.
6764 * WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>,
6765 and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>.
6767 2010-04-20 Adam Barth <abarth@webkit.org>
6769 Reviewed by Eric Seidel.
6771 Factor DocumentWriter out of FrameLoader
6772 https://bugs.webkit.org/show_bug.cgi?id=37175
6774 Update these callsites because the method moved to DocumentWriter.
6776 * WebCoreSupport/WebFrameLoaderClient.cpp:
6777 (WebFrameLoaderClient::receivedData):
6779 2010-04-20 Kent Tamura <tkent@chromium.org>
6781 Reviewed by Darin Adler.
6783 Change a parameter type of chooseIconForFiles()
6784 https://bugs.webkit.org/show_bug.cgi?id=37504
6786 * WebCoreSupport/WebChromeClient.cpp:
6787 (WebChromeClient::chooseIconForFiles):
6788 * WebCoreSupport/WebChromeClient.h:
6790 2010-04-16 Gavin Barraclough <barraclough@apple.com>
6792 Reviewed by NOBODY (Windows build fix).
6795 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
6797 (WebView::stringByEvaluatingJavaScriptFromString):
6799 2010-04-16 Adam Roben <aroben@apple.com>
6801 Make it possible for clients to instantiate a WebUserContentURLPattern
6803 Reviewed by Tim Hatcher.
6805 * ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which
6806 lists all our instantiatable classes.
6808 * WebKitClassFactory.cpp: Added a now-required #include.
6810 2010-04-15 Adam Roben <aroben@apple.com>
6812 Expose UserContentURLPattern as WebKit SPI
6814 Fixes <http://webkit.org/b/37354>.
6816 Reviewed by Tim Hatcher.
6818 * Interfaces/IWebUserContentURLPattern.idl: Added.
6820 * Interfaces/WebKit.idl: Added WebUserContentURLPattern.
6822 * WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern.
6824 * WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern.
6826 * WebUserContentURLPattern.cpp: Added.
6827 (WebUserContentURLPattern::WebUserContentURLPattern):
6828 (WebUserContentURLPattern::~WebUserContentURLPattern):
6829 (WebUserContentURLPattern::createInstance):
6830 (WebUserContentURLPattern::AddRef):
6831 (WebUserContentURLPattern::Release):
6832 (WebUserContentURLPattern::QueryInterface):
6833 Standard COM implementations.
6835 (WebUserContentURLPattern::parse): Parse the string into a
6836 UserContentURLPattern and store it.
6838 (WebUserContentURLPattern::isValid):
6839 (WebUserContentURLPattern::scheme):
6840 (WebUserContentURLPattern::host):
6841 (WebUserContentURLPattern::matchesSubdomains):
6842 Call through to UserContentURLPattern.
6844 * WebUserContentURLPattern.h: Added.
6846 2010-04-14 Adam Roben <aroben@apple.com>
6848 Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows
6850 Fixes <http://webkit.org/b/37619>.
6852 Reviewed by Steve Falkenburg.
6854 * Interfaces/IWebScriptWorld.idl: Added unregisterWorld.
6856 * Interfaces/WebKit.idl: Touched to force a build.
6858 * WebScriptWorld.cpp:
6859 (WebScriptWorld::unregisterWorld):
6861 Added. Just calls through to DOMWrapperWorld::unregisterWorld.
6863 2010-04-12 Timothy Hatcher <timothy@apple.com>
6865 SecurityOrigin needs a way to remove individual OriginAccessEntries
6866 https://bugs.webkit.org/show_bug.cgi?id=37449
6868 Reviewed by Dave Hyatt.
6870 * Interfaces/IWebViewPrivate.idl:
6872 (WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry.
6873 * WebView.h: Added removeOriginAccessWhitelistEntry.
6875 2010-04-13 Timothy Hatcher <timothy@apple.com>
6877 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
6878 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
6880 SecurityOrigin needs a way to remove individual OriginAccessEntries
6881 https://bugs.webkit.org/show_bug.cgi?id=37449
6883 Reviewed by Dave Hyatt.
6885 * Interfaces/IWebViewPrivate.idl:
6887 (WebView::addOriginAccessWhitelistEntry):
6888 (WebView::resetOriginAccessWhitelists):
6891 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
6893 Unreviewed, rolling out r57468.
6894 http://trac.webkit.org/changeset/57468
6895 https://bugs.webkit.org/show_bug.cgi?id=37433
6897 Broke the world... Must have applied the patch wrong
6898 (Requested by abarth on #webkit).
6900 * WebCoreSupport/WebFrameLoaderClient.cpp:
6901 (WebFrameLoaderClient::receivedData):
6903 2010-04-11 Adam Barth <abarth@webkit.org>
6905 Reviewed by Eric Seidel.
6907 Factor DocumentWriter out of FrameLoader
6908 https://bugs.webkit.org/show_bug.cgi?id=37175
6910 Update these callsites because the method moved to DocumentWriter.
6912 * WebCoreSupport/WebFrameLoaderClient.cpp:
6913 (WebFrameLoaderClient::receivedData):
6915 2010-04-09 Adam Roben <aroben@apple.com>
6917 Windows Debug/Release build fix after r57244
6919 * WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or
6920 QuartzCoreInterface.dll in any configurations. r57244 made this change
6921 only for Debug_Internal.
6923 2010-04-08 Steve Falkenburg <sfalken@apple.com>
6925 Reviewed by Darin Adler.
6927 WebView::isLoading should null check m_mainFrame
6928 https://bugs.webkit.org/show_bug.cgi?id=37294
6931 (WebView::isLoading):
6933 2010-04-07 Chris Marrin <cmarrin@apple.com>
6935 Reviewed by Steve Falkenburg.
6937 Remove QuartzCoreInterface from the build
6939 No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).
6941 * WebKit.vcproj/WebKit.vcproj:Removed delay load for QuartzCore and QuartzCoreInterface
6943 2010-04-07 Andrey Kosyakov <caseq@chromium.org>
6945 Reviewed by Yury Semikhatsky.
6947 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
6948 https://bugs.webkit.org/show_bug.cgi?id=36949
6950 * WebCoreSupport/WebFrameLoaderClient.cpp:
6951 * WebCoreSupport/WebFrameLoaderClient.h:
6953 2010-04-05 Peter Nelson <charn.opcode@gmail.com>
6955 Reviewed by Eric Seidel.
6957 Fixed style errors in DOMCoreClasses.h to bring it up to scratch
6958 for https://bugs.webkit.org/show_bug.cgi?id=34979.
6961 (DOMObject::throwException):
6962 (DOMObject::callWebScriptMethod):
6963 (DOMObject::evaluateWebScript):
6964 (DOMObject::removeWebScriptKey):
6965 (DOMObject::stringRepresentation):
6966 (DOMObject::webScriptValueAtIndex):
6967 (DOMObject::setWebScriptValueAtIndex):
6968 (DOMObject::setException):
6969 (DOMNodeList::throwException):
6970 (DOMNodeList::callWebScriptMethod):
6971 (DOMNodeList::evaluateWebScript):
6972 (DOMNodeList::removeWebScriptKey):
6973 (DOMNodeList::stringRepresentation):
6974 (DOMNodeList::webScriptValueAtIndex):
6975 (DOMNodeList::setWebScriptValueAtIndex):
6976 (DOMNodeList::setException):
6977 (DOMDocument::throwException):
6978 (DOMDocument::callWebScriptMethod):
6979 (DOMDocument::evaluateWebScript):
6980 (DOMDocument::removeWebScriptKey):
6981 (DOMDocument::stringRepresentation):
6982 (DOMDocument::webScriptValueAtIndex):
6983 (DOMDocument::setWebScriptValueAtIndex):
6984 (DOMDocument::setException):
6985 (DOMDocument::nodeName):
6986 (DOMDocument::nodeValue):
6987 (DOMDocument::setNodeValue):
6988 (DOMDocument::nodeType):
6989 (DOMDocument::parentNode):
6990 (DOMDocument::childNodes):
6991 (DOMDocument::firstChild):
6992 (DOMDocument::lastChild):
6993 (DOMDocument::previousSibling):
6994 (DOMDocument::nextSibling):
6995 (DOMDocument::attributes):
6996 (DOMDocument::ownerDocument):
6997 (DOMDocument::insertBefore):
6998 (DOMDocument::replaceChild):
6999 (DOMDocument::removeChild):
7000 (DOMDocument::appendChild):
7001 (DOMDocument::hasChildNodes):
7002 (DOMDocument::cloneNode):
7003 (DOMDocument::isSupported):
7004 (DOMDocument::namespaceURI):
7005 (DOMDocument::prefix):
7006 (DOMDocument::setPrefix):
7007 (DOMDocument::localName):
7008 (DOMDocument::hasAttributes):
7009 (DOMDocument::isSameNode):
7010 (DOMDocument::isEqualNode):
7011 (DOMDocument::textContent):
7012 (DOMDocument::setTextContent):
7013 (DOMElement::throwException):
7014 (DOMElement::callWebScriptMethod):
7015 (DOMElement::evaluateWebScript):
7016 (DOMElement::removeWebScriptKey):
7017 (DOMElement::stringRepresentation):
7018 (DOMElement::webScriptValueAtIndex):
7019 (DOMElement::setWebScriptValueAtIndex):
7020 (DOMElement::setException):
7021 (DOMElement::nodeName):
7022 (DOMElement::nodeValue):
7023 (DOMElement::setNodeValue):
7024 (DOMElement::nodeType):
7025 (DOMElement::parentNode):
7026 (DOMElement::childNodes):
7027 (DOMElement::firstChild):
7028 (DOMElement::lastChild):
7029 (DOMElement::previousSibling):
7030 (DOMElement::nextSibling):
7031 (DOMElement::attributes):
7032 (DOMElement::ownerDocument):
7033 (DOMElement::insertBefore):
7034 (DOMElement::replaceChild):
7035 (DOMElement::removeChild):
7036 (DOMElement::appendChild):
7037 (DOMElement::hasChildNodes):
7038 (DOMElement::cloneNode):
7039 (DOMElement::isSupported):
7040 (DOMElement::namespaceURI):
7041 (DOMElement::prefix):
7042 (DOMElement::setPrefix):
7043 (DOMElement::localName):
7044 (DOMElement::hasAttributes):
7045 (DOMElement::isSameNode):
7046 (DOMElement::isEqualNode):
7047 (DOMElement::textContent):
7048 (DOMElement::setTextContent):
7050 2010-04-05 Alexey Proskuryakov <ap@apple.com>
7052 Reviewed by Darin Adler.
7054 https://bugs.webkit.org/show_bug.cgi?id=37111
7055 <rdar://problem/7790327> Draw replacement text when plug-in host crashes
7057 * WebCoreLocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in
7060 2010-04-02 Rafael Weinstein <rafaelw@chromium.org>
7062 Reviewed by Adam Barth.
7064 Clean up unused calls after changes to checkPermission and requestPermission argument lists.
7066 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
7067 (WebDesktopNotificationsDelegate::requestPermission):
7068 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
7070 2010-04-01 Chris Marrin <cmarrin@apple.com>
7072 Reviewed by Simon Fraser.
7074 Added layerTreeAsText function to DRT (for Mac)
7075 https://bugs.webkit.org/show_bug.cgi?id=36782
7077 This is the WebKit side for Windows. It plumbs the
7078 call from WebCore to DRT.
7080 * Interfaces/IWebFramePrivate.idl:
7081 * WebFrame.cpp:WebKit (Windows) side of plumbing
7082 (WebFrame::layerTreeAsText):
7085 2010-03-31 Marcus Bulach <bulach@chromium.org>
7087 Reviewed by Jeremy Orlow.
7089 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
7090 https://bugs.webkit.org/show_bug.cgi?id=35031
7092 * WebCoreSupport/WebChromeClient.h:
7093 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
7095 2010-03-30 Gavin Barraclough <barraclough@apple.com>
7097 Rubber stamped by Sam Weinig.
7099 https://bugs.webkit.org/show_bug.cgi?id=36866
7103 * WebDownloadCFNet.cpp:
7104 * WebDownloadCurl.cpp:
7105 * WebHistoryItem.cpp:
7106 * WebLocalizableStrings.cpp:
7107 * WebMutableURLRequest.cpp:
7108 * WebPreferences.cpp:
7109 (WebPreferences::migrateWebKitPreferencesToCFPreferences):
7112 2010-03-30 Adam Roben <aroben@apple.com>
7116 * Interfaces/WebKit.idl: Touched this to force a build.
7118 2010-03-29 Steve Falkenburg <sfalken@apple.com>
7120 Reviewed by Adele Peterson.
7122 Default value of accelerated compositing should be false for Windows
7123 https://bugs.webkit.org/show_bug.cgi?id=36805
7125 * WebPreferences.cpp:
7126 (WebPreferences::initializeDefaultSettings):
7128 2010-03-29 Rafael Weinstein <rafaelw@chromium.org>
7130 Reviewed by Adam Barth.
7132 Change NotificationPresenter::checkPermission() to take the source frames full KURL,
7133 rather than its SecurityOrigin. This will aid chromium in having more fine grained
7134 permissions to control notification spam.
7136 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
7137 (WebDesktopNotificationsDelegate::checkPermission):
7138 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
7140 2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
7142 Reviewed by Antti Koivisto.
7144 Change method name due to it dealing with both flattening
7145 of frame sets and inner frames.
7147 * Interfaces/IWebPreferencesPrivate.idl:
7148 * WebPreferenceKeysPrivate.h:
7149 * WebPreferences.cpp:
7150 (WebPreferences::initializeDefaultSettings):
7151 (WebPreferences::isFrameFlatteningEnabled):
7152 (WebPreferences::setFrameFlatteningEnabled):
7155 (WebView::notifyPreferencesChanged):
7157 2010-03-24 Jon Honeycutt <jhoneycutt@apple.com>
7159 <rdar://problem/7780798> Missing plug-ins should be represented by text
7160 only, instead of lego block
7162 https://bugs.webkit.org/show_bug.cgi?id=36583
7164 Reviewed by Dan Bernstein.
7166 * WebCoreSupport/WebFrameLoaderClient.cpp:
7167 (WebFrameLoaderClient::createPlugin):
7168 Return 0 if we failed to initialize the plug-in, which causes the new
7169 "missing plug-in" text to draw.
7171 2010-03-24 Kent Tamura <tkent@chromium.org>
7173 Reviewed by Darin Adler.
7175 Make Icon::createIconForFiles() optional.
7176 https://bugs.webkit.org/show_bug.cgi?id=35072
7178 - Rename iconForFiles() to chooseIconForFiles().
7179 - Call Icon::createIconForFiles() from chooseIconForFiles().
7181 * WebCoreSupport/WebChromeClient.cpp:
7182 (WebChromeClient::chooseIconForFiles):
7183 * WebCoreSupport/WebChromeClient.h:
7185 2010-03-22 Darin Adler <darin@apple.com>
7187 * WebCoreLocalizedStrings.cpp:
7188 (WebCore::missingPluginText): Fixed localization helper text to match the same
7189 string from Mac WebKit.
7191 2010-03-22 Kevin Decker <kdecker@apple.com>
7193 Reviewed by John Sullivan.
7195 https://bugs.webkit.org/show_bug.cgi?id=36328
7197 * WebCoreLocalizedStrings.cpp:
7198 (WebCore::missingPluginText): Added.
7200 2010-03-17 Enrica Casucci <enrica@apple.com>
7202 Reviewed by Darin Adler.
7204 Missing support for showing compositing layers borders and repaint count on Windows.
7205 <rdar://problem/7760736>
7206 <https://bugs.webkit.org/show_bug.cgi?id=36197>
7208 * Interfaces/IWebPreferencesPrivate.idl:
7209 * WebPreferenceKeysPrivate.h:
7210 * WebPreferences.cpp:
7211 (WebPreferences::initializeDefaultSettings):
7212 (WebPreferences::showDebugBorders):
7213 (WebPreferences::setShowDebugBorders):
7214 (WebPreferences::showRepaintCounter):
7215 (WebPreferences::setShowRepaintCounter):
7218 (WebView::notifyPreferencesChanged):
7220 2010-03-16 Yury Semikhatsky <yurys@chromium.org>
7222 Reviewed by Pavel Feldman.
7224 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
7226 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
7227 https://bugs.webkit.org/show_bug.cgi?id=35036
7229 * WebCoreSupport/WebInspectorClient.cpp:
7230 (WebInspectorClient::WebInspectorClient):
7231 (WebInspectorClient::~WebInspectorClient):
7232 (WebInspectorClient::openInspectorFrontend):
7233 (WebInspectorClient::highlight):
7234 (WebInspectorClient::hideHighlight):
7235 (WebInspectorClient::updateHighlight):
7236 (WebInspectorFrontendClient::WebInspectorFrontendClient):
7237 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
7238 (WebInspectorFrontendClient::frontendLoaded):
7239 (WebInspectorFrontendClient::localizedStringsURL):
7240 (WebInspectorFrontendClient::hiddenPanels):
7241 (WebInspectorFrontendClient::bringToFront):
7242 (WebInspectorFrontendClient::closeWindow):
7243 (WebInspectorFrontendClient::attachWindow):
7244 (WebInspectorFrontendClient::detachWindow):
7245 (WebInspectorFrontendClient::setAttachedWindowHeight):
7246 (WebInspectorFrontendClient::inspectedURLChanged):
7247 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
7248 (WebInspectorFrontendClient::showWindowWithoutNotifications):
7249 (WebInspectorFrontendClient::destroyInspectorView):
7250 (WebInspectorFrontendClient::updateWindowTitle):
7251 (WebInspectorFrontendClient::onGetMinMaxInfo):
7252 (WebInspectorFrontendClient::onSize):
7253 (WebInspectorFrontendClient::onClose):
7254 (WebInspectorFrontendClient::onSetFocus):
7255 (WebInspectorFrontendClient::onWebViewWindowPosChanging):
7256 (WebInspectorWndProc):
7257 (WebInspectorFrontendClient::windowReceivedMessage):
7258 * WebCoreSupport/WebInspectorClient.h:
7259 (WebInspectorClient::frontendClosing):
7261 (WebInspector::attach):
7262 (WebInspector::detach):
7264 2010-03-14 Dan Bernstein <mitz@apple.com>
7266 Reviewed by Darin Adler.
7268 WebKit part of removing support for legacy versions of Core Graphics
7270 * WebKitClassFactory.cpp:
7271 (WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase().
7272 * WebKitGraphics.cpp:
7274 * WebTextRenderer.cpp:
7275 (WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath().
7277 2010-03-12 Enrica Casucci <enrica@apple.com>
7279 Fixed broken build on Windows.
7280 Added contditional compilation for accelerated compositing.
7283 (WebView::deleteBackingStore):
7284 (WebView::addToDirtyRegion):
7285 (WebView::updateBackingStore):
7287 2010-03-12 Beth Dakin <bdakin@apple.com>
7289 Reviewed by Simon Fraser.
7291 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
7292 API naming is inconsistent
7294 <rdar://problem/7729165>
7296 This patch changes all occurrences of "fullScreen" to the more
7297 popular "fullscreen."
7299 * FullscreenVideoController.cpp:
7300 (FullscreenVideoController::onMouseDown):
7301 (FullscreenVideoController::onMouseMove):
7302 (FullscreenVideoController::onMouseUp):
7303 * FullscreenVideoController.h:
7304 (FullscreenVideoController::fullscreenToHUDCoordinates):
7306 2010-03-12 Beth Dakin <bdakin@apple.com>
7308 Reviewed by Adam Roben.
7310 Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
7311 video HUD stays on top when switching to another window (e.g. via
7314 <rdar://problem/7547574>
7316 The HUD was always on top because it had the WS_EX_TOPMOST style.
7317 So I removed the style and made m_videoWindow the owner of
7318 m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
7319 is the focused window.
7321 * FullscreenVideoController.cpp:
7322 (FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
7323 (FullscreenVideoController::createHUDWindow):
7325 2010-03-12 Enrica Casucci <enrica@apple.com>
7327 Reviewed by Simon Fraser.
7329 Content of 3D tests appears at the bottom right corner sometimes.
7330 <rdar://problem/7556244>
7331 <https://bugs.webkit.org/show_bug.cgi?id=36027>
7333 See detailed comments in WebCore/ChangeLog.
7336 (WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
7337 (WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
7338 backing store dirty region.
7339 (WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
7340 (WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
7341 (WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
7342 We are passing width and height of the view content together with the offset for the scrolling.
7343 It was confusing to pass it all as a rectangle, when it is not a rectangle.
7345 2010-03-11 Aaron Boodman <aa@chromium.org>
7347 Kill WebDocument::applicationID() (part 1).
7349 Modify interface to WebCore::NotificationPresenter::checkPermission()
7350 and remove implementation of WebDocument::applicationID(). Breaking
7351 API changes will be in a subsequent change.
7352 https://bugs.webkit.org/show_bug.cgi?id=35846
7354 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
7355 (WebDesktopNotificationsDelegate::checkPermission):
7356 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
7358 2010-03-11 Anders Carlsson <andersca@apple.com>
7360 Reviewed by David Hyatt.
7362 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
7364 * WebCoreSupport/WebChromeClient.cpp:
7365 * WebCoreSupport/WebChromeClient.h:
7367 2010-03-10 Eric Uhrhane <ericu@chromium.org>
7369 Reviewed by David Levin.
7371 The build fix for my patch on bug #35763 wasn't quite right--it removed
7372 the call entirely, instead of replacing it with the new API. This adds
7373 the call to Database::setIsAvailable.
7375 https://bugs.webkit.org/show_bug.cgi?id=35763
7377 * WebView.cpp: Added a call to Database::setIsAvailable where change 55667 removed the old Settings API call <http://trac.webkit.org/changeset/55667>.
7378 (WebView::notifyPreferencesChanged):
7380 2010-03-10 John Sullivan <sullivan@apple.com>
7382 Reviewed by Tim Hatcher.
7384 <rdar://problem/7735387> input type other than text won't work with autofill
7385 <https://bugs.webkit.org/show_bug.cgi?id=35963>
7388 (WebFrame::elementDoesAutoComplete):
7389 Return true for any text field that's not a password, rather than only
7392 2010-03-09 Brady Eidson <beidson@apple.com>
7394 Reviewed by Tim Hatcher.
7396 REGRESSION: WebInspector docking busted on Windows
7397 <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
7399 * WebCoreSupport/WebInspectorClient.cpp:
7400 (WebInspectorClient::attachWindow): Use the InspectorController:: copy of the should attach settings key.
7401 (WebInspectorClient::detachWindow): Ditto.
7402 (WebInspectorClient::showWindowWithoutNotifications): Ditto.
7404 2010-03-09 John Sullivan <sullivan@apple.com>
7406 Fixed localized string key collision. update-webkit-localized-strings now
7407 runs without errors.
7409 Reviewed by Adam Roben.
7411 * WebCoreLocalizedStrings.cpp:
7412 (WebCore::AXMenuListPopupActionVerb):
7413 Used LPCTSTR_UI_STRING_KEY for the 2nd use of "press".
7415 2010-03-08 Adam Treat <atreat@rim.com>
7417 Unreviewed build fix for Windows.
7419 * WebCoreSupport/WebChromeClient.cpp:
7420 (WebChromeClient::invalidateContents):
7422 2010-03-02 Adam Treat <atreat@rim.com>
7424 Reviewed by Dave Hyatt.
7426 Adapt the win port to the refactoring of repaint methods.
7428 https://bugs.webkit.org/show_bug.cgi?id=34214
7430 * WebCoreSupport/WebChromeClient.cpp:
7431 (WebChromeClient::invalidateContents):
7432 (WebChromeClient::invalidateWindow):
7433 (WebChromeClient::invalidateContentsAndWindow):
7434 (WebChromeClient::invalidateContentsForSlowScroll):
7435 * WebCoreSupport/WebChromeClient.h:
7437 2010-03-08 Daniel Bates <dbates@rim.com>
7439 Unreviewed, build fix.
7441 Attempt to fix the Windows builds by applying the corresponding change
7442 made in bug #35763 <https://bugs.webkit.org/show_bug.cgi?id=35763>.
7444 * WebView.cpp: Removed call to settings->setDatabasesEnabled since this
7445 setting no longer exists following changeset 55666 <http://trac.webkit.org/changeset/55666>.
7446 (WebView::notifyPreferencesChanged):
7448 2010-03-07 Mark Rowe <mrowe@apple.com>
7452 * WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header
7453 since some WebCore headers rely on the types declared within being available via the prefix
7456 2010-03-05 Chris Marrin <cmarrin@apple.com>
7458 Reviewed by Simon Fraser.
7460 Got rid of platformLayer use in WebView.
7461 https://bugs.webkit.org/show_bug.cgi?id=35798
7463 WKCACFLayer no longer depends on GraphicsLayer, so I got rid of
7464 that dependency on WebView. Now WebChromeClient casts platformLayer
7465 to WKCACFLayer which will always be the case on Windows.
7467 * WebCoreSupport/WebChromeClient.cpp:
7468 (WebChromeClient::attachRootGraphicsLayer):
7470 (WebView::setRootChildLayer):
7473 2010-03-04 Beth Dakin <bdakin@apple.com>
7475 Reviewed by Anders Carlsson.
7477 WebCore::Page::setInstanceHandle() is now just
7478 WebCore::setInstanceHandle()
7483 2010-03-03 Alice Liu <alice.liu@apple.com>
7485 Reviewed by Jon Honeycutt.
7487 Add a way to get an iframe's content frame
7489 * DOMCoreClasses.cpp:
7490 (DOMElement::createInstance):
7491 Added case for DOMHTMLIFrameElement
7492 * DOMHTMLClasses.cpp:
7493 Adding the few DOMHTMLIFrameElement functions definitions that have
7494 distinct implementations (all others just call parent implementation)
7495 (DOMHTMLIFrameElement::QueryInterface):
7496 (DOMHTMLIFrameElement::contentFrame):
7498 Most of these function declarations have definitions that just call the parent implementation
7499 (DOMHTMLIFrameElement::DOMHTMLIFrameElement):
7500 (DOMHTMLIFrameElement::AddRef):
7501 (DOMHTMLIFrameElement::Release):
7502 (DOMHTMLIFrameElement::throwException):
7503 (DOMHTMLIFrameElement::callWebScriptMethod):
7504 (DOMHTMLIFrameElement::evaluateWebScript):
7505 (DOMHTMLIFrameElement::removeWebScriptKey):
7506 (DOMHTMLIFrameElement::stringRepresentation):
7507 (DOMHTMLIFrameElement::webScriptValueAtIndex):
7508 (DOMHTMLIFrameElement::setWebScriptValueAtIndex):
7509 (DOMHTMLIFrameElement::setException):
7510 (DOMHTMLIFrameElement::nodeName):
7511 (DOMHTMLIFrameElement::nodeValue):
7512 (DOMHTMLIFrameElement::setNodeValue):
7513 (DOMHTMLIFrameElement::nodeType):
7514 (DOMHTMLIFrameElement::parentNode):
7515 (DOMHTMLIFrameElement::childNodes):
7516 (DOMHTMLIFrameElement::firstChild):
7517 (DOMHTMLIFrameElement::lastChild):
7518 (DOMHTMLIFrameElement::previousSibling):
7519 (DOMHTMLIFrameElement::nextSibling):
7520 (DOMHTMLIFrameElement::attributes):
7521 (DOMHTMLIFrameElement::ownerDocument):
7522 (DOMHTMLIFrameElement::insertBefore):
7523 (DOMHTMLIFrameElement::replaceChild):
7524 (DOMHTMLIFrameElement::removeChild):
7525 (DOMHTMLIFrameElement::appendChild):
7526 (DOMHTMLIFrameElement::hasChildNodes):
7527 (DOMHTMLIFrameElement::cloneNode):
7528 (DOMHTMLIFrameElement::normalize):
7529 (DOMHTMLIFrameElement::isSupported):
7530 (DOMHTMLIFrameElement::namespaceURI):
7531 (DOMHTMLIFrameElement::prefix):
7532 (DOMHTMLIFrameElement::setPrefix):
7533 (DOMHTMLIFrameElement::localName):
7534 (DOMHTMLIFrameElement::hasAttributes):
7535 (DOMHTMLIFrameElement::isSameNode):
7536 (DOMHTMLIFrameElement::isEqualNode):
7537 (DOMHTMLIFrameElement::textContent):
7538 (DOMHTMLIFrameElement::setTextContent):
7539 (DOMHTMLIFrameElement::tagName):
7540 (DOMHTMLIFrameElement::getAttribute):
7541 (DOMHTMLIFrameElement::setAttribute):
7542 (DOMHTMLIFrameElement::removeAttribute):
7543 (DOMHTMLIFrameElement::getAttributeNode):
7544 (DOMHTMLIFrameElement::setAttributeNode):
7545 (DOMHTMLIFrameElement::removeAttributeNode):
7546 (DOMHTMLIFrameElement::getElementsByTagName):
7547 (DOMHTMLIFrameElement::getAttributeNS):
7548 (DOMHTMLIFrameElement::setAttributeNS):
7549 (DOMHTMLIFrameElement::removeAttributeNS):
7550 (DOMHTMLIFrameElement::getAttributeNodeNS):
7551 (DOMHTMLIFrameElement::setAttributeNodeNS):
7552 (DOMHTMLIFrameElement::getElementsByTagNameNS):
7553 (DOMHTMLIFrameElement::hasAttribute):
7554 (DOMHTMLIFrameElement::hasAttributeNS):
7555 (DOMHTMLIFrameElement::focus):
7556 (DOMHTMLIFrameElement::blur):
7557 (DOMHTMLIFrameElement::idName):
7558 (DOMHTMLIFrameElement::setIdName):
7559 (DOMHTMLIFrameElement::title):
7560 (DOMHTMLIFrameElement::setTitle):
7561 (DOMHTMLIFrameElement::lang):
7562 (DOMHTMLIFrameElement::setLang):
7563 (DOMHTMLIFrameElement::dir):
7564 (DOMHTMLIFrameElement::setDir):
7565 (DOMHTMLIFrameElement::className):
7566 (DOMHTMLIFrameElement::setClassName):
7567 (DOMHTMLIFrameElement::innerHTML):
7568 (DOMHTMLIFrameElement::setInnerHTML):
7569 (DOMHTMLIFrameElement::innerText):
7570 (DOMHTMLIFrameElement::setInnerText):
7571 * Interfaces/DOMHTML.idl:
7572 Added IDOMHTMLIFrameElement interface
7574 2010-03-03 Chris Marrin <cmarrin@apple.com>
7576 Reviewed by Simon Fraser.
7578 Export acceleratedCompositing flag in IWebPreferences.
7579 https://bugs.webkit.org/show_bug.cgi?id=35610
7581 * Interfaces/IWebPreferences.idl:
7583 2010-03-02 Beth Dakin <bdakin@apple.com>
7585 Reviewed by Darin Adler and Adam Roben.
7587 Tiny WebKit portion of fix for <rdar://problem/7485289> WebKit
7588 crashes on systems that don't support CoreAnimation
7590 setHostWindow() no longer calls createRenderer(), so now that has
7591 to be called manually.
7594 (WebView::setAcceleratedCompositing):
7596 2010-03-02 Adam Roben <aroben@apple.com>
7598 Add IWebViewPrivate::registerURLSchemeAsSecure
7600 Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose
7601 SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
7603 Reviewed by Tim Hatcher.
7605 * Interfaces/WebKit.idl: Touched to force a build.
7607 * Interfaces/IWebViewPrivate.idl:
7609 (WebView::registerURLSchemeAsSecure):
7611 Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
7613 2010-03-01 Jon Honeycutt <jhoneycutt@apple.com>
7615 Remove Windows line endings from some files.
7617 Rubber-stamped by Alice Liu.
7619 * Interfaces/IWebEmbeddedView.idl:
7621 * WebCoreSupport/EmbeddedWidget.cpp:
7622 (EmbeddedWidget::create):
7623 (EmbeddedWidget::~EmbeddedWidget):
7624 (EmbeddedWidget::createWindow):
7625 (EmbeddedWidget::invalidateRect):
7626 (EmbeddedWidget::setFrameRect):
7627 (EmbeddedWidget::frameRectsChanged):
7628 (EmbeddedWidget::setFocus):
7629 (EmbeddedWidget::show):
7630 (EmbeddedWidget::hide):
7631 (EmbeddedWidget::windowClipRect):
7632 (EmbeddedWidget::setParent):
7633 (EmbeddedWidget::attachToWindow):
7634 (EmbeddedWidget::detachFromWindow):
7635 (EmbeddedWidget::didReceiveResponse):
7636 (EmbeddedWidget::didReceiveData):
7637 (EmbeddedWidget::didFinishLoading):
7638 (EmbeddedWidget::didFail):
7640 * WebCoreSupport/EmbeddedWidget.h:
7641 (EmbeddedWidget::EmbeddedWidget):
7643 2010-03-01 Jon Honeycutt <jhoneycutt@apple.com>
7645 Some WebKit DOMNode API is unimplemented.
7646 https://bugs.webkit.org/show_bug.cgi?id=35554
7648 Reviewed by Alice Liu.
7650 * DOMCoreClasses.cpp:
7651 (DOMNode::nextSibling):
7652 Create a DOMNode to wrap m_node's next sibling, and assign it to the
7654 (DOMNode::insertBefore):
7655 Query for the DOMNode for newChild, and return early if we fail. Query
7656 refChild for DOMNode. Call insertBefore(), passing the newChild's
7657 WebCore node and refChild's WebCore node (if refChild is non-null). If
7658 we successfully insert the child, fill the result out param with
7659 newChild, ref it, and return S_OK. Otherwise, return E_FAIL.
7660 (DOMNode::removeChild):
7661 Query oldChild for DOMNode. If we fail, return E_FAIL. Call
7662 removeChild(), passing the node's WebCore node. If this fails, return
7663 E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and
7666 2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
7668 Reviewed by Adam Barth.
7670 Adapt to the new ZoomMode enum.
7671 https://bugs.webkit.org/show_bug.cgi?id=35347
7674 (WebFrame::setTextSizeMultiplier):
7676 (WebView::setZoomMultiplier):
7677 (WebView::zoomMultiplier):
7678 (WebView::canMakeTextLarger):
7679 (WebView::makeTextLarger):
7680 (WebView::canMakeTextSmaller):
7681 (WebView::makeTextSmaller):
7682 (WebView::notifyPreferencesChanged):
7684 2010-02-26 Jon Honeycutt <jhoneycutt@apple.com>
7686 <rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments
7687 is passed wrong arguments
7689 Reviewed by Adam Roben.
7691 * Interfaces/IWebUIDelegatePrivate.idl:
7692 Update copyright strings. Added a new key for the plug-in source URL.
7694 * Interfaces/WebKit.idl:
7695 Update copyright strings.
7697 * WebCoreSupport/WebFrameLoaderClient.cpp:
7698 (WebFrameLoaderClient::createPlugin):
7699 Pass the URL of the plug-in as the source URL. Pass the document's
7700 base URI for the base URL.
7702 2010-02-23 Brady Eidson <beidson@apple.com>
7704 Reviewed by Tim Hatcher and Pavel Feldman.
7706 Regression (r55107) - WebInspector docking is busted.
7707 https://bugs.webkit.org/show_bug.cgi?id=35274
7709 * WebCoreSupport/WebInspectorClient.cpp:
7710 (WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check
7711 to get the expected behavior.
7713 2010-02-23 Steve Block <steveblock@google.com>
7715 Reviewed by Darin Adler.
7717 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
7718 https://bugs.webkit.org/show_bug.cgi?id=34962
7720 This method is required so that a Geolocation object can cancel an
7721 asynchronous permission request. This allows the chrome client to cancel
7722 any UI it is showing for the permission request.
7724 * WebCoreSupport/WebChromeClient.h:
7725 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
7727 2010-02-22 Steve Falkenburg <sfalken@apple.com>
7729 Reviewed by Darin Adler.
7731 WebKit on Windows should pick up system setting changes without requiring explicit API calls
7732 https://bugs.webkit.org/show_bug.cgi?id=35269
7734 * WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged.
7735 * WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged.
7736 * WebKitGraphics.cpp: Removed WebKitSystemParameterChanged.
7737 * WebKitGraphics.h: Removed WebKitSystemParameterChanged.
7739 (systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes.
7740 (WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage.
7742 2010-02-22 Brady Eidson <beidson@apple.com>
7744 Reviewed by Tim Hatcher.
7746 Disable WebView docking to views that are too small.
7747 <rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
7749 * WebCoreSupport/WebInspectorClient.cpp:
7750 (WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector
7751 window attached if WebCore says it shouldn't be attached.
7753 2010-02-17 Steve Falkenburg <sfalken@apple.com>
7755 Reviewed by Dan Bernstein.
7757 WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages
7758 https://bugs.webkit.org/show_bug.cgi?id=35076
7760 * WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged.
7761 * WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged.
7762 * WebKitGraphics.cpp:
7763 (WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes.
7764 * WebKitGraphics.h: Added WebKitSystemParameterChanged.
7766 2010-02-17 Dmitry Titov <dimich@chromium.org>
7768 Reviewed by David Levin, Darin Fisher, Simon Hausmann.
7770 When a live iframe element is moved between pages, it still depends on the old page.
7771 https://bugs.webkit.org/show_bug.cgi?id=34382
7773 * WebCoreSupport/WebFrameLoaderClient.cpp:
7774 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
7775 Added empty implementation of a new virtual method.
7777 * WebCoreSupport/WebFrameLoaderClient.h:
7779 2010-02-17 Kent Tamura <tkent@chromium.org>
7781 Reviewed by Eric Seidel.
7783 Introduces new Icon loading interface in order to support
7784 asynchronous loading.
7785 https://bugs.webkit.org/show_bug.cgi?id=32054
7787 Add an empty implementation of ChromeClient::iconForFiles().
7789 * WebCoreSupport/WebChromeClient.cpp:
7790 (WebChromeClient::iconForFiles):
7791 * WebCoreSupport/WebChromeClient.h:
7793 2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
7795 Unreviewed. Touch WebKit.idl to fix the build.
7797 [Win] Implement test functions for printing
7798 https://bugs.webkit.org/show_bug.cgi?id=34570
7800 * Interfaces/WebKit.idl:
7802 2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
7804 Reviewed by Eric Seidel.
7806 [Win] Implement test functions for printing
7807 https://bugs.webkit.org/show_bug.cgi?id=34570
7809 * Interfaces/IWebFramePrivate.idl:
7811 (WebFrame::pageNumberForElementById):
7812 (WebFrame::numberOfPages):
7815 2010-02-16 Darin Adler <darin@apple.com>
7817 Reviewed by Sam Weinig.
7819 Generalize delayed plug-in start for background tabs for use for other media
7820 https://bugs.webkit.org/show_bug.cgi?id=34981
7823 (WebView::setCanStartPlugins): Change to call setCanStartMedia.
7824 In a later patch we can change the of the public function in the IDL file too,
7825 but for now this should be enough.
7827 2010-02-15 Adam Roben <aroben@apple.com>
7829 Add IWebFramePrivate::visibleContentRect
7831 Fixes <http://webkit.org/b/34956> Add API to get a WebFrame's visible
7834 Reviewed by Jon Honeycutt.
7836 * Interfaces/IWebFramePrivate.idl: Added visibleContentRect.
7838 * Interfaces/WebKit.idl: Touched to force a build.
7841 (WebFrame::visibleContentRect):
7843 Added. Calls through to FrameView::visibleContentRect.
7845 2010-02-12 Brian Weinstein <bweinstein@apple.com>
7847 Reviewed by Adam Roben.
7849 onmouseout fired when moving over tooltip on Windows
7850 https://bugs.webkit.org/show_bug.cgi?id=16794
7853 Add WS_EX_TRANSPARENT to out tooltip HWND so it isn't subject to hit testing, and when
7854 you mouse over the tooltip, it doesn't send a mouseout to the web content.
7857 (WebView::initializeToolTipWindow): Add WS_EX_TRANSPARENT.
7859 2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
7861 Reviewed by Kenneth Rohde Christiansen.
7863 Support frameset flattening
7864 https://bugs.webkit.org/show_bug.cgi?id=32717
7866 Add support for enabling/disabling FrameSet Flattening on the Windows port.
7868 * Interfaces/IWebPreferencesPrivate.idl:
7869 * WebPreferenceKeysPrivate.h:
7870 * WebPreferences.cpp:
7871 (WebPreferences::initializeDefaultSettings):
7872 (WebPreferences::isFrameSetFlatteningEnabled):
7873 (WebPreferences::setFrameSetFlatteningEnabled):
7876 (WebView::notifyPreferencesChanged):
7878 2010-02-10 Adam Roben <aroben@apple.com>
7880 Remove unnecessary #include of shfolder.h
7882 shfolder.h has been deprecated in newer versions of the Windows SDK.
7884 Fixes <http://webkit.org/b/34803> WebPreferences.cpp fails to compile
7885 under VS2010 RC due to #include of shfolder.h.
7887 Reviewed by Darin Adler.
7889 * WebPreferences.cpp: Removed #include.
7891 2010-02-08 Charlie Reis <creis@chromium.org>
7893 Reviewed by Darin Adler.
7895 onbeforeunload not called at window close + frame or iframe focused
7896 https://bugs.webkit.org/show_bug.cgi?id=27481
7898 Chromium and WebKit on Windows will now fire beforeunload handlers
7899 even if an inner frame is focused.
7901 Layout tests aren't able to test this bug, since it requires closing
7902 the actual browser window, not calling window.close(). Instead,
7903 test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
7906 (WebView::shouldClose):
7908 2010-02-08 Brent Fulgham <bfulgham@webkit.org>
7910 Reviewed by Adam Roben.
7912 Include header position in World Transform used for plugin positioning.
7913 https://bugs.webkit.org/show_bug.cgi?id=34709
7916 (WebFrame::spoolPage): Correct WinCairo plugin print positioning to
7917 account for header size. Existing code ignored this, causing
7918 plugins to overlay other elements.
7920 2010-02-04 Alice Liu <alice.liu@apple.com>
7922 Reviewed by Jon Honeycutt.
7924 https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
7925 codes for most elements that arent listbox or menupopup related"
7926 <rdar://problem/7436861>
7928 * AccessibleBase.cpp:
7929 (AccessibleBase::accSelect):
7930 - Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that
7931 aren't beneath listboxes or menupopups. This was too restrictive since
7932 any element can be selectable.
7933 - Correct the misinterpretation of MSDN's stipulation of situations involving
7934 adding, removing, and extending selection on single-select elements
7936 2010-02-04 Brent Fulgham <bfulgham@webkit.org>
7938 Reviewed by Adam Roben.
7940 Properly handle margin settings when printing Plugins in WinCairo.
7941 https://bugs.webkit.org/show_bug.cgi?id=34613
7944 (WebFrame::spoolPage): Adjust the GraphicsContext passed to the
7945 paintContents method so that the World Transform is properly
7946 positioned to account for margin settings at the time that
7947 PluginViewWin.cpp processes the drawing operations.
7949 2010-02-04 Brent Fulgham <bfulgham@webkit.org>
7951 Reviewed by Adam Roben.
7953 Properly handle margin settings in WinCairo.
7954 https://bugs.webkit.org/show_bug.cgi?id=34545
7957 (scaleFactor): Require the margin information as an input
7958 parameter, and use them when computing the scaling factor.
7959 (WebFrame::drawHeader): Pass margin size to scaleFactor.
7960 (WebFrame::drawFooter): Pass margin size to scaleFactor.
7961 (WebFrame::spoolPage):
7962 1. Pass margin size to scaleFactor.
7963 2. Recognize that the return value of printerMarginRect is
7964 already in device units, and therefore scale it so that
7965 the Cairo drawing is correct.
7966 3. Remove scaling call for margins in GDI code, as it is
7967 already in scaled units.
7969 2010-02-03 Brian Weinstein <bweinstein@apple.com>
7971 Reviewed by Steve Falkenburg.
7973 Scroll does not work with IBM Thinkpad.
7974 <https://bugs.webkit.org/show_bug.cgi?id=14227>
7977 When initializing the WebView, add two scrollbar Windows inside of
7978 our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
7979 (similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.
7981 Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
7982 like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.
7984 Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
7988 (WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down
7990 (WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right
7992 (WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
7993 (WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create
7994 vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.
7995 (WebView::shouldInitializeTrackPointHack): Check if there is a registry key for
7996 the some kind of IBM Trackpoint driver.
7999 2010-02-02 Steve Falkenburg <sfalken@apple.com>
8001 Reviewed by Darin Adler.
8003 Copyright year updating for Windows version resources should be automatic
8004 https://bugs.webkit.org/show_bug.cgi?id=34503
8006 * WebKit.vcproj/WebKit.rc:
8008 2010-02-02 Adam Roben <aroben@apple.com>
8010 Stop copying WebCore's IDL files from SRCROOT to OBJROOT
8012 WebKit doesn't use these anymore (as of r52921).
8014 Part of Bug 34496: Clean up WebCore's IDL/script copying
8015 <https://bugs.webkit.org/show_bug.cgi?id=34496>
8017 Reviewed by Steve Falkenburg.
8019 * WebKit.vcproj/WebKit.make:
8021 2010-01-29 Gavin Barraclough <barraclough@apple.com>
8023 Reviewed by Sam Weinig + Oliver Hunt.
8025 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
8027 Pass processeing user gensture flag to media play/pause methods.
8029 * FullscreenVideoController.cpp:
8030 (FullscreenVideoController::play):
8031 (FullscreenVideoController::pause):
8033 2010-01-29 Brian Weinstein <bweinstein@apple.com>
8035 Reviewed by Adam Roben.
8037 Drag and Drop: Windows uses "stop" sign as cursor when dragging
8038 https://bugs.webkit.org/show_bug.cgi?id=34305
8039 <rdar://problem/7589672>
8041 Add a preference in WebKit (that defaults to false), for whether or not
8042 we should show the custom cursors during drag and drop. However, this is
8043 currently only used on Windows, and only used to hide the "drop not allowed"
8044 icon inside the WebView is the preference is set to true.
8046 This will be off by default, so no change in behavior.
8048 * Interfaces/IWebPreferencesPrivate.idl: Added new functions.
8049 * Interfaces/WebKit.idl: Touched to force Interfaces build.
8050 * WebDropSource.cpp:
8051 (WebDropSource::GiveFeedback): Implementation of conditional showing cursor
8053 * WebPreferenceKeysPrivate.h: Added new preference key.
8054 * WebPreferences.cpp: Added new functions.
8055 (WebPreferences::setCustomDragCursorsEnabled):
8056 (WebPreferences::customDragCursorsEnabled):
8057 * WebPreferences.h: Added new functions.
8059 2010-01-28 Jon Honeycutt <jhoneycutt@apple.com>
8061 MSAA: Crash when posting a notification for a detached object
8063 https://bugs.webkit.org/show_bug.cgi?id=34309
8064 <rdar://problem/7409759>
8066 Reviewed by Darin Adler.
8068 * AccessibleBase.cpp:
8069 (AccessibleBase::QueryService):
8070 If an unrecognized service ID is passed, return early. Otherwise, return
8071 the result of QueryInterface.
8072 (AccessibleBase::QueryInterface):
8073 Add static_casts. Check for new UUIDs.
8074 (AccessibleBase::isSameObject):
8075 Query the object for AccessibleBase. Return whether the pointers or the
8076 wrapped objects match.
8079 Give the class a UUID so we can query for it in isSameObject(). Inherit
8080 from IAccessibleComparable; inherit from IServiceProvider so clients can
8081 use QueryService to query for a custom interface.
8083 * Interfaces/AccessibleComparable.idl: Added. Declares a function that
8084 can be called to compare to accessible objects.
8086 * Interfaces/WebKit.idl:
8087 Include the new IDL.
8089 * WebKit.vcproj/Interfaces.vcproj:
8090 Add the new IDL to the project.
8092 2010-01-27 Aaron Boodman <aa@chromium.org>
8094 Expand NotificationCenter::checkPermission() interface.
8095 It now passes the full URL instead of just the origin.
8097 https://bugs.webkit.org/show_bug.cgi?id=34238
8099 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
8100 (WebDesktopNotificationsDelegate::checkPermission):
8101 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
8103 2010-01-27 Adam Roben <aroben@apple.com>
8105 Make it possible to instantiate WebSerializedJSValue using
8106 WebKitCreateInstance
8108 Reviewed by Dave Hyatt.
8111 * WebKitClassFactory.cpp:
8112 Added WebSerializedJSValue.
8114 2010-01-26 Steve Falkenburg <sfalken@apple.com>
8116 Reviewed by Oliver Hunt.
8118 Windows build references non-existent include paths
8119 https://bugs.webkit.org/show_bug.cgi?id=34175
8121 * WebKit.vcproj/WebKit.vcproj:
8123 2010-01-25 Steve Falkenburg <sfalken@apple.com>
8125 Reviewed by Simon Fraser.
8127 A WebGeolocationControllerClient is leaked for every WebView
8128 https://bugs.webkit.org/show_bug.cgi?id=34145
8130 * WebCoreSupport/WebGeolocationControllerClient.cpp:
8131 (WebGeolocationControllerClient::geolocationDestroyed): Added.
8132 * WebCoreSupport/WebGeolocationControllerClient.h:
8134 2010-01-23 Dan Bernstein <mitz@apple.com>
8136 Reviewed by Maciej Stachowiak.
8138 <rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows
8139 https://bugs.webkit.org/show_bug.cgi?id=34006
8141 * WebPreferences.cpp:
8142 (WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey
8143 with a default value of true.
8145 2010-01-20 Steve Falkenburg <sfalken@apple.com>
8147 Reviewed by Sam Weinig.
8149 Add missing implementation for WebGeolocationPosition::initWithTimestamp.
8151 * WebGeolocationPosition.cpp:
8152 (WebGeolocationPosition::initWithTimestamp): Implemented.
8154 2010-01-20 Jon Honeycutt <jhoneycutt@apple.com>
8156 MSAA: accSelect() is not implemented
8158 https://bugs.webkit.org/show_bug.cgi?id=33918
8159 <rdar://problem/7436861>
8161 Reviewed by Darin Adler.
8163 * AccessibleBase.cpp:
8164 (AccessibleBase::accSelect):
8165 If there is an invalid combination of state flags, return early. If the
8166 caller passed the "take focus" flag, focus the object. If the "take
8167 selection" flag was passed, check whether the parent object is an
8168 AccessibilityListBox; if so, call the object's setSelectedChildren()
8169 function. If the parent is an AccessibilityMenuListPopup, call the
8170 child object's setSelected() function. Otherwise, if the parent is some
8171 other, unsupported object, return early.
8172 If the selection flags include "add", "remove", or "extend" selection,
8173 and the parent object is not multi-selectable, return early. Otherwise,
8174 set or unset the child's selected flag based on the passed flag.
8176 2010-01-20 Steve Falkenburg <sfalken@apple.com>
8178 Reviewed by Darin Adler and Adam Roben.
8180 Feature defines are difficult to maintain on Windows builds
8181 https://bugs.webkit.org/show_bug.cgi?id=33883
8183 FeatureDefines.vsprops are now maintained in a way similar to
8184 Configurations/FeatureDefines.xcconfig, with the added advantage
8185 of having a single FeatureDefines file across all projects.
8187 * WebKit.vcproj/Interfaces.vcproj: Add FeatureDefines.vsprops inherited property sheet.
8188 * WebKit.vcproj/WebKit.sln: Set up Cairo configuration for WebCoreGenerated.
8189 * WebKit.vcproj/WebKit.vcproj: Remove ENABLE_ preprocessor definitions.
8190 Add FeatureDefines.vsprops inherited property sheet.
8191 * WebKit.vcproj/WebKitGUID.vcproj: Add FeatureDefines.vsprops inherited property sheet.
8193 2010-01-17 Jon Honeycutt <jhoneycutt@apple.com>
8195 MSAA: The child <option> elements of a non-multiple <select> are not
8198 https://bugs.webkit.org/show_bug.cgi?id=33773
8199 <rdar://problem/7550556>
8201 Reviewed by Alice Liu.
8203 * AccessibleBase.cpp:
8204 (AccessibleBase::get_accState):
8205 If the object is invisible, set the invisible state flag. If the object
8206 is collapsed, set the collapsed state. If the object is a combo box,
8207 set the has popup flag, and if it's not collapsed, set the expanded
8210 Add new WebCore to MSAA role mappings.
8212 * WebCoreLocalizedStrings.cpp:
8213 (WebCore::AXMenuListActionVerb):
8214 Return the action verb that Firefox uses for <select> elements with
8216 (WebCore::AXMenuListPopupActionVerb):
8217 Return the verb that Firefox uses for a popup list.
8219 2010-01-19 John Sullivan <sullivan@apple.com>
8221 https://bugs.webkit.org/show_bug.cgi?id=33854
8222 Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns
8223 more info about where the result was found
8225 Reviewed by Darin Adler
8227 * Interfaces/IWebHTMLRepresentation.idl:
8228 Created variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
8230 * Interfaces/WebKit.idl:
8231 Touched in order to get other idl change to propagate correctly.
8233 * WebHTMLRepresentation.cpp:
8234 (WebHTMLRepresentation::deprecatedSearchForLabels):
8235 Renamed since iDL doesn't support two functions with the same name but different signatures.
8236 (WebHTMLRepresentation::searchForLabels):
8237 Implemented variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
8239 * WebHTMLRepresentation.h:
8240 Declared variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
8242 2010-01-19 Adam Roben <aroben@apple.com>
8246 * WebScriptWorld.cpp: Added missing #include.
8248 2010-01-19 Dave Hyatt <hyatt@apple.com>
8250 Build bustage fix. Make sure the newly added scriptWorldForGlobalContext function is [local] in the IDL.
8252 * Interfaces/IWebScriptWorld.idl:
8254 2010-01-19 Dave Hyatt <hyatt@apple.com>
8256 Reviewed by Adam Roben.
8258 Add an API to obtain a WebScriptWorld from a JSGlobalContextRef.
8260 * Interfaces/IWebScriptWorld.idl:
8261 * WebScriptWorld.cpp:
8262 (WebScriptWorld::scriptWorldForGlobalContext):
8265 2010-01-18 Adam Roben <aroben@apple.com>
8267 Add IWebViewPrivate::setDomainRelaxationForbiddenForURLScheme
8269 WebKit/win part of fixing <http://webkit.org/b/33806>
8270 <rdar://problem/7552837> Would like API to disallow setting of
8271 document.domain for pages with certain URL schemes
8273 Reviewed by Sam Weinig.
8275 * Interfaces/IWebViewPrivate.idl: Added
8276 setDomainRelaxationForbiddenForURLScheme.
8278 * Interfaces/WebKit.idl: Touched to force a build.
8281 (WebView::setDomainRelaxationForbiddenForURLScheme):
8283 Added. Calls through to SecurityOrigin.
8285 2010-01-18 Chris Marrin <cmarrin@apple.com>
8287 Reviewed by Darin Adler.
8289 Use new setScrollFrame API
8290 https://bugs.webkit.org/show_bug.cgi?id=32279
8293 (WebView::updateRootLayerContents):
8295 2010-01-15 Jon Honeycutt <jhoneycutt@apple.com>
8297 MSAA: Screen rect for <option> elements is always the zero rect
8299 https://bugs.webkit.org/show_bug.cgi?id=33758
8301 Reviewed by Oliver Hunt.
8303 * AccessibleBase.cpp:
8304 (AccessibleBase::accLocation):
8305 Use elementRect() rather than boundingBoxRect(), which
8306 AccessibilityListBoxOption overrides.
8308 2010-01-15 Jon Honeycutt <jhoneycutt@apple.com>
8310 get_accParent should try to retrieve parent AccessibilityObject, before
8313 https://bugs.webkit.org/show_bug.cgi?id=22893
8315 Reviewed by Darin Adler.
8317 * AccessibleBase.cpp:
8318 (AccessibleBase::get_accParent):
8319 If the object has a parent object, return it. If not, return the
8320 accessible for the WebView window.
8322 2010-01-12 Jon Honeycutt <jhoneycutt@apple.com>
8324 MSAA: selected, selectable, extended selectable, and multiple
8325 selectable states are not reported
8327 https://bugs.webkit.org/show_bug.cgi?id=33574
8328 <rdar://problem/7536826>
8330 Reviewed by Darin Adler.
8332 * AccessibleBase.cpp:
8333 (AccessibleBase::get_accState):
8334 Remove the call to isMultiSelect(). Call the correctly-named
8335 isMultiSelectable(), and if it returns true, set both the "extended
8336 selectable" and "multiple selectable" states. Check whether the object
8337 is selected or selectable, and report those states.
8339 2010-01-13 Steve Falkenburg <sfalken@apple.com>
8341 Reviewed by Adam Roben.
8343 Add additional Geolocation interfaces in WebKit for Windows.
8345 * Interfaces/IWebGeolocationPolicyListener.idl: Added.
8346 * Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2.
8347 Append since this version hasn't shipped.
8348 * Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl.
8349 * WebCoreSupport/WebChromeClient.cpp:
8350 (WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest.
8351 * WebCoreSupport/WebGeolocationControllerClient.cpp:
8352 (WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *.
8353 * WebGeolocationPolicyListener.cpp: Added.
8354 * WebGeolocationPolicyListener.h: Added.
8355 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener.
8356 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener.
8358 (WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE.
8359 (WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE.
8360 (WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE.
8361 (WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE.
8363 2010-01-12 Steve Falkenburg <sfalken@apple.com>
8365 Reviewed by Adam Roben, Sam Weinig.
8367 Add Geolocation interfaces in WebKit for Windows.
8369 * ForEachCoClass.h: Added WebGeolocationPosition.
8370 * Interfaces/IWebError.idl:
8371 * Interfaces/IWebGeolocationPosition.idl: Added.
8372 * Interfaces/IWebGeolocationProvider.idl: Added.
8373 * Interfaces/IWebViewPrivate.idl:
8374 * Interfaces/WebKit.idl:
8375 * WebCoreSupport/WebGeolocationControllerClient.cpp: Added.
8376 (WebGeolocationControllerClient::WebGeolocationControllerClient):
8377 (WebGeolocationControllerClient::startUpdating):
8378 (WebGeolocationControllerClient::stopUpdating):
8379 (WebGeolocationControllerClient::lastPosition):
8380 * WebCoreSupport/WebGeolocationControllerClient.h: Added.
8381 * WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation.
8382 * WebGeolocationPosition.h: Added IWebGeolocationPosition implementation.
8383 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl,
8384 relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl
8385 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp,
8386 * WebKitClassFactory.cpp: Add WebGeolocationPosition include.
8388 (WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled.
8389 (WebView::setGeolocationProvider): Added Geolocation-specific method.
8390 (WebView::geolocationProvider): Added Geolocation-specific method.
8391 (WebView::geolocationDidChangePosition): Added Geolocation-specific method.
8392 (WebView::geolocationDidFailWithError): Added Geolocation-specific method.
8393 * WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError.
8395 2010-01-11 Jon Honeycutt <jhoneycutt@apple.com>
8397 MSAA: Accessibility role of <select multiple> elements is wrong
8399 https://bugs.webkit.org/show_bug.cgi?id=33522
8401 Reviewed by Darin Adler.
8403 * AccessibleBase.cpp:
8405 Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
8406 "list" and "list item" roles.
8408 2010-01-08 Brent Fulgham <bfulgham@webkit.org>
8410 Build fix, no review.
8412 Protect video control logic inside ENABLE(VIDEO).
8415 (WebView::enterFullscreenForNode):
8416 (WebView::exitFullscreen):
8419 2010-01-08 Chris Marrin <cmarrin@apple.com>
8421 Reviewed by Adam Roben.
8423 Implement full-screen video for Windows
8424 https://bugs.webkit.org/show_bug.cgi?id=31318
8426 This adds a full-screen controller, FullscreenVideoController,
8427 which manages going in and out of full-screen. The actual
8428 full-screen window is created and managed by logic added
8429 to QTMovieWin. FullscreenVideoController also creates and
8430 manages a HUD. The HUD renders and manages events to
8431 control the playing video. Movie controller events go to
8432 FullscreenVideoController which then sends them to HTMLMediaElement,
8433 which is passed to the controller by WebView, which gets the call
8434 to go into full-screen mode from HTMLMediaElement via
8437 I've also updated the icons so the related sets (Play/Pause and
8438 volume high/volume low/exit fullscreen) are the same size. This
8439 allows me to position them using common code.
8441 * WebCoreSupport/WebChromeClient.cpp:
8442 (WebChromeClient::supportsFullscreenForNode):
8443 (WebChromeClient::enterFullscreenForNode):
8444 (WebChromeClient::exitFullscreenForNode):
8445 * WebCoreSupport/WebChromeClient.h:
8446 * WebKit.vcproj/WebKit.vcproj:
8447 * WebKit.vcproj/fsVideoAudioVolumeHigh.png:
8448 * WebKit.vcproj/fsVideoAudioVolumeLow.png:
8449 * WebKit.vcproj/fsVideoExitFullscreen.png:
8450 * WebKit.vcproj/fsVideoPause.png:
8451 * WebKit.vcproj/fsVideoPlay.png:
8453 (loadResourceIntoBuffer):
8454 * FullscreenVideoController.cpp: Added.
8455 * FullscreenVideoController.h: Added.
8457 (WebView::enterFullscreenForNode):
8458 (WebView::exitFullscreen):
8461 2010-01-08 Brent Fulgham <bfulgham@webkit.org>
8463 Unreviewed correction.
8465 Accidentally left unnecessary modification to hdcFromContext
8466 in when landing r52995.
8469 (hdcFromContext): Back out unneeded modification.
8471 2010-01-08 Brent Fulgham <bfulgham@webkit.org>
8473 Reviewed by Adam Roben.
8475 Use correct cairo surface data type for handling print operations.
8476 https://bugs.webkit.org/show_bug.cgi?id=33022.
8479 (scaleFactor): Handle 'scale = 0' case.
8480 (WebFrame::spoolPage): Use scaleFactor helper function. Account for
8481 margin size in region passed to header/footer routines.
8482 (WebFrame::spoolPages): Properly clean up Cairo surface.
8484 2010-01-07 Kent Tamura <tkent@chromium.org>
8486 Reviewed by Maciej Stachowiak.
8488 Remove COM code generation files.
8489 https://bugs.webkit.org/show_bug.cgi?id=32854
8491 * WebKit.vcproj/DerivedSources.make: Removed.
8492 * WebKit.vcproj/build-generated-files.sh: Removed.
8494 2010-01-05 Adam Roben <aroben@apple.com>
8496 Make IWebView::close and destroying a WebView's HWND optional for
8499 WebView will now take care of these operations itself when its last
8500 reference is released, if they haven't already been done.
8502 IWebView::close now also destroys the WebView's HWND. All WebKit
8503 clients were already performing these operations in succession anyway,
8504 or were attempting to by calling IWebView::close then destroying the
8505 WebView's host window (which actually resulted in the WebView's HWND
8506 leaking, and the crash in the below bug).
8508 Fixes <rdar://problem/7374218> <http://webkit.org/b/32827> Crash when
8509 calling IWebView::close, then releasing the WebView, without calling
8512 Fixes a few WebViewDestruction tests, too.
8514 Reviewed by Steve Falkenburg.
8517 (WebView::~WebView): Don't try to destroy m_viewWindow here. That
8518 should already have happened. Assert that this is the case.
8519 (WebView::close): If m_viewWindow isn't already being destroyed,
8520 destroy it now. Moved the call to revokeDragDrop() here from our
8521 WM_DESTROY handler because it needs to be done before m_viewWindow is
8523 (WebView::WebViewWndProc): Removed call to revokeDragDrop() that
8524 close() now performs.
8525 (WebView::Release): If our last reference is being released, call
8526 close() so that clients don't have to. (It's harmless to call close()
8527 multiple times.) We do this here instead of in the destructor because
8528 close() can cause AddRef() and Release() to be called, and calling
8529 those from within the destructor leads to double-destruction.
8530 (WebView::setHostWindow): Removed an unnecessary (and now harmful)
8532 (WebView::revokeDragDrop): Changed an assertion into a run-time check,
8533 since this will now sometimes be called when m_viewWindow hasn't been
8534 created yet. Changed the IsWindow call to a null-check because we
8535 never hold onto a destroyed m_viewWindow.
8536 (WebView::windowAncestryDidChange): If we don't have a view window,
8537 stop tracking changes to our parent's active state.
8539 2010-01-05 Adam Roben <aroben@apple.com>
8541 Make it safe to call IWebView::close when IWebView::initWithFrame
8544 Part of <rdar://problem/7374218> <http://webkit.org/b/32827> Crash
8545 when IWebView::close, then releasing the WebView, without calling
8548 Reviewed by Steve Falkenburg.
8551 (WebView::close): Null-check m_page and m_preferences before using
8552 them. They will be null if initWithFrame was never called.
8554 2010-01-05 Adam Roben <aroben@apple.com>
8556 Add assertions to catch double-destruction of WebViews earlier
8558 I basically copied the m_deletionHasBegun logic from WTF::RefCounted.
8560 Fixes <http://webkit.org/b/33219>.
8562 Reviewed by Darin Adler.
8565 (WebView::WebView): Initialize m_deletionHasBegun
8566 (WebView::AddRef): Assert that deletion hasn't already begun.
8567 (WebView::Release): Assert that deletion hasn't already begun, then
8568 record when deletion *does* begin.
8570 * WebView.h: Added m_deletionHasBegun.
8572 2010-01-05 Adam Roben <aroben@apple.com>
8574 Remove dead code in WebViewWndProc
8576 Fixes <http://webkit.org/b/33218>.
8578 Reviewed by Darin Adler.
8581 (WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check.
8582 We bail out much earlier in this function if isBeingDestroyed is true.
8584 2010-01-04 Jon Honeycutt <jhoneycutt@apple.com>
8586 MSAA: Accessibility role of <select> elements is wrong
8588 https://bugs.webkit.org/show_bug.cgi?id=33192
8590 Reviewed by Sam Weinig.
8592 * AccessibleBase.cpp:
8594 Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX.
8596 2010-01-04 Alexey Proskuryakov <ap@apple.com>
8598 Reviewed by Darin Adler.
8600 https://bugs.webkit.org/show_bug.cgi?id=33181
8601 The first letter is not removed properly from inline input hole
8603 * WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was
8604 confirmed, cancel it.
8606 2010-01-04 Alexey Proskuryakov <ap@apple.com>
8608 Reviewed by Darin Adler.
8610 https://bugs.webkit.org/show_bug.cgi?id=33161
8611 Assertion failure in WebView when using Chinese Simplified IME
8613 * WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode
8614 check. We can't make assertions about arguments passed from outside WebKit.
8616 2010-01-04 Alexey Proskuryakov <ap@apple.com>
8618 Reviewed by Darin Adler.
8620 https://bugs.webkit.org/show_bug.cgi?id=33157
8621 Implement TextInput logging channel on Windows
8623 * WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary):
8625 Added a TextInput channel in place of unused Network one.
8628 (WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward
8629 it to DefWindowProc, so there is no need to return an unused boolean result for "handled".
8630 (WebView::onIMEStartComposition): Added logging.
8631 (imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition.
8632 (imeNotificationName): A helper function for detailed logging in onIMENotify.
8633 (imeRequestName): A helper function for detailed logging in onIMERequest.
8634 (WebView::onIMEComposition): Added logging.
8635 (WebView::onIMEEndComposition): Ditto.
8636 (WebView::onIMEChar): Ditto.
8637 (WebView::onIMENotify): Ditto.
8638 (WebView::onIMERequestCharPosition): Changed to return result directly.
8639 (WebView::onIMERequestReconvertString): Ditto.
8640 (WebView::onIMERequest): Changed to return result directly. Added logging.
8641 (WebView::onIMESelect): Added logging.
8642 (WebView::onIMESetContext): Added logging.
8644 * WebView.h: onIMERequest functions now return result directly.
8647 2010-01-04 Adam Roben <aroben@apple.com>
8651 Fixes <http://webkit.org/b/33167>.
8653 Reviewed by Sam Weinig.
8655 * WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just
8656 after DumpRenderTree.vcproj.
8658 2010-01-04 Dan Bernstein <mitz@apple.com>
8660 Reviewed by Ada Chan and Mark Rowe.
8662 Updated copyright string
8664 * WebKit.vcproj/WebKit.rc:
8666 2009-12-22 Darin Adler <darin@apple.com>
8668 Another try at fixing Windows build.
8670 * WebKitPrefix.cpp: Touch it.
8672 2009-12-22 Darin Adler <darin@apple.com>
8674 Reviewed by Mark Rowe.
8676 Turn off datagrid by default, at least for all platforms Apple ships.
8677 The datagrid implementation isn't ready for general web use yet.
8679 * WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default.
8681 2009-12-21 Adam Roben <aroben@apple.com>
8683 Fix non-ACCELERATED_COMPOSITING builds
8685 * WebPreferences.cpp:
8686 (WebPreferences::acceleratedCompositingEnabled): Guard use of
8687 WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING).
8689 2009-12-18 Adam Roben <aroben@apple.com>
8691 Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled
8693 Fixes <http://webkit.org/b/32745>.
8695 Reviewed by Ada Chan.
8697 * Interfaces/IWebPreferencesPrivate.idl: Added
8698 [set]AcceleratedCompositingEnabled.
8700 * Interfaces/WebKit.idl: Touched to force a build.
8702 * WebPreferenceKeysPrivate.h: Added
8703 WebKitAcceleratedCompositingEnabledPreferenceKey.
8705 * WebPreferences.cpp:
8706 (WebPreferences::initializeDefaultSettings): Make accelerated
8707 compositing be on by default.
8708 (WebPreferences::setAcceleratedCompositingEnabled): Store the new
8710 (WebPreferences::acceleratedCompositingEnabled): If accelerated
8711 compositing isn't available, return false. Otherwise, return the value
8712 stored in preferences.
8714 * WebPreferences.h: Added [set]AcceleratedCompositingAvailable.
8717 (WebView::notifyPreferencesChanged): Just pass the value from
8718 WebPreferences on down.
8720 2009-12-17 Jon Honeycutt <jhoneycutt@apple.com>
8722 MSAA: Accessibility role of list items is wrong
8724 https://bugs.webkit.org/show_bug.cgi?id=32688
8726 Reviewed by Adam Roben.
8728 * AccessibleBase.cpp:
8730 Make the WebCore list item role map to the MSAA list item role.
8732 2009-12-17 Jon Honeycutt <jhoneycutt@apple.com>
8734 MSAA: Accessibility role of list markers is wrong
8736 https://bugs.webkit.org/show_bug.cgi?id=32687
8738 Reviewed by Adam Roben.
8740 * AccessibleBase.cpp:
8742 Make the WebCore list marker role map to the MSAA static text role.
8744 2009-12-18 Adam Roben <aroben@apple.com>
8746 Add #includes needed after WebCore clean-up
8748 Rubber-stamped by Anders Carlsson.
8750 Fixes <http://webkit.org/b/32718>.
8752 * WebCoreSupport/WebContextMenuClient.cpp:
8753 * WebDataSource.cpp:
8754 * WebHTMLRepresentation.cpp:
8758 2009-12-17 Benjamin Otte <otte@gnome.org>
8760 Reviewed by Adam Roben.
8762 Don't include all JSC headers everywhere
8763 https://bugs.webkit.org/show_bug.cgi?id=32663
8765 * WebCoreLocalizedStrings.cpp: Added now-needed #include of
8768 2009-12-17 Adam Roben <aroben@apple.com>
8770 Remove WebKit.sln's Debug_All and Debug_Internal configurations
8772 These configurations aren't buildable by people outside of Apple, and
8773 Apple doesn't use this solution file.
8775 Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration
8776 should default to Debug instead of Debug_all.
8778 Rubber-stamped by Dan Bernstein.
8780 * WebKit.vcproj/WebKit.sln:
8782 2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
8784 MSAA: Accessibility role of text nodes is wrong
8786 https://bugs.webkit.org/show_bug.cgi?id=32631
8787 <rdar://problem/7369084>
8789 Reviewed by Alice Liu.
8791 * AccessibleBase.cpp:
8793 If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT.
8794 (AccessibleBase::role):
8795 Call roleValueForMSAA().
8797 2009-12-14 Brent Fulgham <bfulgham@webkit.org>
8799 Reviewed by Adam Roben.
8801 Provide working printing support for WinCairo port.
8804 (WebFrame::spoolPage): Conditionalize initialization of
8805 PlatformGraphicsContext handling for CG vs. Cairo.
8806 (scaleFactor): Add helper function.
8807 (hdcFromContext): Add helper function.
8808 (WebFrame::drawHeader): Correct Cairo variation.
8809 (WebFrame::drawFooter): Correct Cairo variation.
8810 (WebFrame::spoolPages): Correct Cairo variation.
8812 2009-12-13 Sam Weinig <sam@webkit.org>
8814 Reviewed by Dan Bernstein.
8816 Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
8817 Add client based Geolocation provider
8819 Add first cut of a client based Geolocation provider. This is guarded by
8820 ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
8821 GeolocationControllerClient interface that no-one currently implements,
8822 but will in a subsequent patch.
8825 (WebView::initWithFrame):
8827 2009-12-14 Adam Roben <aroben@apple.com>
8829 Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4
8831 Reviewed by Steve Falkenburg.
8833 Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on
8834 a link element crashes WebKit nightly
8836 * Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end
8837 of the interface so the vtable that Safari 4.0.4 sees is unchanged.
8839 2009-12-14 Adam Roben <aroben@apple.com>
8843 * WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the
8844 libpath for all non-Cairo configurations (it was missing from most of
8847 2009-12-11 Chris Marrin <cmarrin@apple.com>
8849 Reviewed by Jon Honeycutt.
8851 Added icons for full-screen video on Windows
8852 https://bugs.webkit.org/show_bug.cgi?id=31318
8854 * WebKit.vcproj/WebKit.rc:
8855 * WebKit.vcproj/WebKit.vcproj:
8856 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Added.
8857 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Added.
8858 * WebKit.vcproj/fsVideoExitFullscreen.png: Added.
8859 * WebKit.vcproj/fsVideoPause.png: Added.
8860 * WebKit.vcproj/fsVideoPlay.png: Added.
8861 * WebKit.vcproj/resource.h:
8863 2009-12-11 Chris Marrin <cmarrin@apple.com>
8865 Reviewed by Adam Roben.
8867 Delay load DLLs for accelerated compositing
8868 https://bugs.webkit.org/show_bug.cgi?id=31856
8870 If the DLLs (d3d9 and QuartzCore). are not present it
8871 turns off accelerated compositing and avoids calling
8872 any of the functions in the DLLs.
8875 (WebView::notifyPreferencesChanged):
8877 2009-12-10 Jon Honeycutt <jhoneycutt@apple.com>
8879 Pass more information about a plug-in to the PluginHalterDelegate
8881 Reviewed by Adam Roben.
8883 * Interfaces/IWebPluginHalterDelegate.idl:
8886 * WebCoreSupport/WebPluginHalterClient.cpp:
8887 (WebPluginHalterClient::shouldHaltPlugin):
8888 Update for new parameters. Pass them when making the delegate call.
8890 * WebCoreSupport/WebPluginHalterClient.h:
8891 Update for new parameters.
8893 2009-12-09 Brent Fulgham <bfulgham@webkit.org>
8895 Revert incorrect commit-box update r51911.
8896 It mistakenly set the selectAll implementation in the
8900 (WebFrame::deselectAll):
8902 2009-12-09 Brent Fulgham <bfulgham@webkit.org>
8904 Reviewed by Darin Adler.
8906 Provide an implementation for 'selectAll'
8907 https://bugs.webkit.org/show_bug.cgi?id=32296
8910 (WebFrame::selectAll): Implement "SelectAll" command.
8912 2009-12-09 Brent Fulgham <bfulgham@webkit.org>
8914 Reviewed by Darin Adler.
8916 Provide an implementation for 'selectAll'
8917 https://bugs.webkit.org/show_bug.cgi?id=32296
8920 (WebFrame::selectAll): Implement "SelectAll" command.
8922 2009-12-08 Chris Marrin <cmarrin@apple.com>
8924 Reviewed by Adam Roben.
8926 Delay load DLLs for accelerated compositing
8927 https://bugs.webkit.org/show_bug.cgi?id=31856
8929 If the DLLs (d3d9 and QuartzCore). are not present it
8930 turns off accelerated compositing and avoids calling
8931 any of the functions in the DLLs.
8936 2009-12-08 Adam Roben <aroben@apple.com>
8940 * Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild.
8942 2009-12-08 John Sullivan <sullivan@apple.com>
8944 Reviewed by Dan Bernstein
8946 Split two-clause assertions into two separate assertions.
8948 * DOMHTMLClasses.cpp:
8949 (DOMHTMLInputElement::isTextField):
8950 Split a two-clause assertion into two separate assertions.
8951 (DOMHTMLInputElement::rectOnScreen):
8952 Added the two assertions here that all other functions in this group shared.
8953 (DOMHTMLInputElement::selectedRange):
8954 Split a two-clause assertion into two separate assertions.
8955 (DOMHTMLInputElement::setAutofilled):
8956 Split a two-clause assertion into two separate assertions.
8957 (DOMHTMLInputElement::isAutofilled):
8958 Split a two-clause assertion into two separate assertions.
8960 2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
8962 Rubber-stamped by Maciej Stachowiak.
8964 Turn on (SVG) Filters for Win.
8965 https://bugs.webkit.org/show_bug.cgi?id=32224
8967 * WebKit.vcproj/WebKit.vcproj:
8969 2009-12-08 John Sullivan <sullivan@apple.com>
8971 Add isAutofilled getter to match existing setter.
8973 Reviewed by Ada Chan.
8975 * DOMHTMLClasses.cpp:
8976 (DOMHTMLInputElement::isAutofilled):
8977 Implemented new cover function.
8980 Declared new cover function.
8982 * Interfaces/DOMPrivate.idl:
8983 Declared new interface.
8985 2009-12-07 Gavin Barraclough <barraclough@apple.com>
8987 Reviewed by NOBODY (Windows build fix part III).
8990 (WebView::stringByEvaluatingJavaScriptFromString):
8992 2009-12-07 Gavin Barraclough <barraclough@apple.com>
8994 Reviewed by NOBODY (Windows build fix part II).
8997 (WebView::stringByEvaluatingJavaScriptFromString):
8999 2009-12-03 Brady Eidson <beidson@apple.com>
9001 Reviewed by Sam Weinig.
9003 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
9005 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
9006 * WebCoreSupport/WebFrameLoaderClient.cpp:
9007 (WebFrameLoaderClient::dispatchDidPushStateWithinPage):
9008 (WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
9009 (WebFrameLoaderClient::dispatchDidPopStateWithinPage):
9010 * WebCoreSupport/WebFrameLoaderClient.h:
9012 2009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
9014 Reviewed by Timothy Hatcher.
9016 Web Inspector: Simplify the settings support in inspector controller.
9018 https://bugs.webkit.org/show_bug.cgi?id=32076
9020 * WebCoreSupport/WebInspectorClient.cpp:
9021 (WebInspectorClient::attachWindow):
9022 (WebInspectorClient::detachWindow):
9023 (WebInspectorClient::showWindowWithoutNotifications):
9024 * WebCoreSupport/WebInspectorClient.h:
9026 2009-12-03 Ben Murdoch <benm@google.com>
9028 Reviewed by Brady Eidson.
9030 [Android] The FrameLoaderClient is unaware of BackForwardList changes.
9031 https://bugs.webkit.org/show_bug.cgi?id=31914
9033 * WebCoreSupport/WebFrameLoaderClient.cpp:
9034 (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
9035 (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
9036 (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
9037 * WebCoreSupport/WebFrameLoaderClient.h:
9039 2009-12-02 Timothy Hatcher <timothy@apple.com>
9041 Move setValueForUser to the end of the DOMHTMLInputElement interface
9042 so it is fine for binary compatibility.
9044 Directed by Steve Falkenburg.
9046 * Interfaces/DOMHTML.idl:
9048 2009-12-02 Timothy Hatcher <timothy@apple.com>
9050 Expose setValueForUser for the COM DOMHTMLInputElement.
9052 <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
9054 Reviewed by Dan Bernstein.
9056 * DOMHTMLClasses.cpp:
9057 (DOMHTMLInputElement::setValueForUser):
9058 * Interfaces/DOMHTML.idl:
9060 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
9062 Not reviewed. Try to fix windows build.
9066 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
9068 Reviewed by Simon Fraser.
9070 Add SVG animation test framework with 'snapshot' functionality
9071 https://bugs.webkit.org/show_bug.cgi?id=31897
9073 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
9074 forwarding the call to SVGDocumentExtensions, if SVG is enabled.
9076 Implemented just like the existing pauseAnimation* methods for CSS animations.
9078 * Interfaces/IWebFramePrivate.idl:
9080 (WebFrame::pauseSVGAnimation):
9083 2009-11-30 Adam Roben <aroben@apple.com>
9085 Fix double-free of BSTRs passed to WebNavigationData::createInstance
9087 WebFrameLoaderClient::updateGlobalHistory was converting
9088 WebCore::Strings to WebCore::BStrings, then passing them to
9089 WebNavigationData::createInstance. But the latter function takes BSTR
9090 parameters and adopts them into WebCore::BStrings. So the end result
9091 was that two WebCore::BStrings would end up freeing each underlying
9094 The fix is to only convert to WebCore::BString inside
9097 Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
9098 (r49564): Crash in updateGlobalHistory when running Javascript iBench
9101 I couldn't find a way to reproduce this in DumpRenderTree.
9103 Reviewed by Steve Falkenburg.
9105 * WebCoreSupport/WebFrameLoaderClient.cpp:
9106 (WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
9107 WebNavigationData::createInstance.
9109 * WebNavigationData.cpp:
9110 (WebNavigationData::WebNavigationData):
9111 (WebNavigationData::createInstance):
9112 * WebNavigationData.h:
9113 Changed to take const WebCore::String&s instead of BSTRs and to
9114 convert the Strings to BStrings at this level.
9116 2009-11-30 Steve Falkenburg <sfalken@apple.com>
9118 Reviewed by Adam Roben.
9120 WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
9121 https://bugs.webkit.org/show_bug.cgi?id=31986
9124 (WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.
9126 2009-11-24 Chris Marrin <cmarrin@apple.com>
9128 Another Windows build fix
9130 Got rid of d3d.lib and d3dx9.lib dependency. Not needed until
9131 we turn on ACCELERATED_COMPOSITING
9133 * WebKit.vcproj/WebKit.vcproj:
9135 2009-11-24 Chris Marrin <cmarrin@apple.com>
9139 Got rid of QuartzCore.lib dependency. Not needed until
9140 we turn on ACCELERATED_COMPOSITING
9142 * WebKit.vcproj/WebKit.vcproj:
9144 2009-11-24 Chris Marrin <cmarrin@apple.com>
9146 Reviewed by Simon Fraser.
9148 Implement accelerated compositing
9149 https://bugs.webkit.org/show_bug.cgi?id=27314
9151 This is the WebKit side of the implementation. It plumbs the root layer
9152 from WebCore. It also makes changes to WebView which places the
9153 backing store of the page into the root compositing layer so it is
9154 properly composited with all the other layers. This deals with resizing,
9155 scrolling, and incremental repaint of the page.
9157 * WebCoreSupport/WebChromeClient.cpp:
9158 (WebChromeClient::attachRootGraphicsLayer):
9159 (WebChromeClient::scheduleCompositingLayerSync):
9160 * WebCoreSupport/WebChromeClient.h:
9161 (WebChromeClient::setNeedsOneShotDrawingSynchronization):
9162 * WebKit.vcproj/WebKit.vcproj:
9167 (WebView::scrollBackingStore):
9170 (WebView::setRootChildLayer):
9171 (WebView::setAcceleratedCompositing):
9172 (WebView::setRootLayerContents):
9174 (WebView::isAcceleratedCompositing):
9175 (WebView::resizeLayerWindow):
9176 (WebView::layerWindowBecameVisible):
9177 (WebView::setRootLayerNeedsDisplay):
9179 2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
9181 Reviewed by Kenneth Rohde Christiansen.
9183 Include "config.h" to meet Coding Style Guidelines
9184 https://bugs.webkit.org/show_bug.cgi?id=31792
9186 * GEN_DOMObject.cpp:
9187 * WebScriptObject.cpp:
9189 2009-11-21 Jon Honeycutt <jhoneycutt@apple.com>
9191 Windows build fix. Unreviewed.
9193 * Interfaces/IWebSerializedJSValue.idl:
9195 2009-11-20 Jon Honeycutt <jhoneycutt@apple.com>
9197 DOMElement::tagName() is unimplemented
9199 https://bugs.webkit.org/show_bug.cgi?id=31746
9201 Reviewed by Darin Adler.
9203 * DOMCoreClasses.cpp:
9204 (DOMElement::tagName):
9205 Create a BString from the element's tag name, and release its BSTR
9208 2009-11-20 Jon Honeycutt <jhoneycutt@apple.com>
9210 DOMNode::childNodes() is unimplemented
9212 https://bugs.webkit.org/show_bug.cgi?id=31745
9214 Reviewed by Darin Adler.
9216 * DOMCoreClasses.cpp:
9217 (DOMNode::childNodes):
9218 Create a DOMNodeList from the node's child nodes.
9220 2009-11-20 Dave Hyatt <hyatt@apple.com>
9222 Reviewed by Jon Honeycutt.
9224 Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
9225 serialization into a separate serialize() function that can be called after the object has been
9228 Fix a typo in serialize() caused when fixing build bustage (put a ! back in).
9230 * Interfaces/IWebSerializedJSValue.idl:
9231 * WebSerializedJSValue.cpp:
9232 (WebSerializedJSValue::WebSerializedJSValue):
9233 (WebSerializedJSValue::createInstance):
9234 (WebSerializedJSValue::serialize):
9235 (WebSerializedJSValue::deserialize):
9236 * WebSerializedJSValue.h:
9238 2009-11-20 Brian Weinstein <bweinstein@apple.com>
9240 Reviewed by Dave Hyatt.
9242 Another go at the Windows Build Fix - this is a couple steps of it,
9243 so a little more involved than most build fixes.
9245 * Interfaces/IWebSerializedJSValue.idl:
9246 * Interfaces/JavaScriptCoreAPITypes.idl:
9247 * WebKit.vcproj/Interfaces.vcproj:
9248 * WebSerializedJSValue.cpp:
9249 (WebSerializedJSValue::deserialize):
9250 * WebSerializedJSValue.h:
9252 2009-11-20 Brian Weinstein <bweinstein@apple.com>
9254 Reviewed by Dave Hyatt.
9256 Build fix for Windows - only declare JSContextRef once, instead
9257 of in two different idl files. Create a new file to hold the
9258 definition of JSContextRef.
9260 * Interfaces/IWebFrameLoadDelegate.idl:
9261 * Interfaces/IWebSerializedJSValue.idl:
9262 * Interfaces/JavaScriptCoreAPITypes.idl: Added.
9263 * Interfaces/WebKit.idl:
9264 * WebKit.vcproj/Interfaces.vcproj:
9266 2009-11-20 Dave Hyatt <hyatt@apple.com>
9268 Reviewed by Oliver Hunt and Jon Honeycutt.
9270 Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
9271 and exposes the ability to do JS value serialization/deserialization to WebKit clients.
9273 * Interfaces/IWebSerializedJSValue.idl: Added.
9274 * Interfaces/WebKit.idl:
9275 * WebKit.vcproj/WebKit.vcproj:
9276 * WebSerializedJSValue.cpp: Added.
9277 (WebSerializedJSValue::WebSerializedJSValue):
9278 (WebSerializedJSValue::~WebSerializedJSValue):
9279 (WebSerializedJSValue::createInstance):
9280 (WebSerializedJSValue::AddRef):
9281 (WebSerializedJSValue::Release):
9282 (WebSerializedJSValue::QueryInterface):
9283 (WebSerializedJSValue::deserialize):
9284 * WebSerializedJSValue.h: Added.
9286 2009-11-19 Alexey Proskuryakov <ap@apple.com>
9288 Reviewed by Darin Adler.
9290 https://bugs.webkit.org/show_bug.cgi?id=31690
9291 Make SocketStreamHandleCFNet work on Windows
9293 * WebDownloadCFNet.cpp:
9294 (WebDownload::init):
9295 (WebDownload::initWithRequest):
9296 (WebDownload::initToResumeWithBundle):
9297 Update for loaderRunLoop() now being in its own header.
9299 2009-11-19 Eric Carlson <eric.carlson@apple.com>
9301 Reviewed by Dan Bernstein.
9303 <rdar://problem/7035231>
9304 Support closed caption in <video> element
9306 * WebCoreLocalizedStrings.cpp:
9307 (WebCore::localizedMediaControlElementString):
9308 (WebCore::localizedMediaControlElementHelpText):
9309 Add accessibility help strings for media controller closed caption button.
9311 2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
9313 Reviewed by Darin Adler.
9315 Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
9316 Support for validationMessage attribute, as per HTML5 specs.
9318 * WebCoreLocalizedStrings.cpp:
9319 (WebCore::validationMessageValueMissingText):
9320 (WebCore::validationMessageTypeMismatchText):
9321 (WebCore::validationMessagePatternMismatchText):
9322 (WebCore::validationMessageTooLongText):
9323 (WebCore::validationMessageRangeUnderflowText):
9324 (WebCore::validationMessageRangeOverflowText):
9325 (WebCore::validationMessageStepMismatchText):
9327 2009-11-18 Daniel Bates <dbates@webkit.org>
9329 Reviewed by Darin Adler.
9331 https://bugs.webkit.org/show_bug.cgi?id=31186
9333 Changes associated with renaming RenderTextControl::isUserEdited.
9335 * DOMHTMLClasses.cpp:
9336 (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited.
9337 (DOMHTMLTextAreaElement::isUserEdited): Ditto.
9339 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
9341 Implement DOMHTMLInputElement::replaceCharactersInRange().
9343 https://bugs.webkit.org/show_bug.cgi?id=31492
9345 Reviewed by Dan Bernstein.
9347 * DOMHTMLClasses.cpp:
9348 (DOMHTMLInputElement::replaceCharactersInRange):
9349 Get the text of the input field. Replace the given range with the
9350 replacement text, and set this new string as the input element's value.
9351 Select from index to the end of the field. This matches the
9352 implementation in the Obj-C bindings.
9354 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
9356 DOMHTMLOptionElement is missing some functionality.
9358 https://bugs.webkit.org/show_bug.cgi?id=31491
9360 Reviewed by Dan Bernstein.
9362 * DOMHTMLClasses.cpp:
9363 (DOMHTMLOptionElement::text):
9364 Cast m_element to an HTMLOptionElement, and call its text() function.
9365 (DOMHTMLOptionElement::label):
9368 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
9370 DOMHTMLSelectElement is missing some implementation.
9372 https://bugs.webkit.org/show_bug.cgi?id=31489
9374 Reviewed by Dan Bernstein.
9376 * DOMHTMLClasses.cpp:
9377 (DOMHTMLSelectElement::options):
9378 Cast m_element to an HTMLSelectElement. If it has no options, return
9379 E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the
9380 options, and return it.
9381 (DOMHTMLSelectElement::activateItemAtIndex):
9382 If the index is out of bounds, return E_FAIL. Otherwise, select the
9385 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
9387 DOMHTMLOptionsCollection is missing some implementation.
9389 https://bugs.webkit.org/show_bug.cgi?id=31488
9391 Reviewed by Dan Bernstein.
9393 * DOMHTMLClasses.cpp:
9394 (DOMHTMLOptionsCollection::DOMHTMLOptionsCollection):
9395 Initialize m_collection.
9396 (DOMHTMLOptionsCollection::createInstance):
9397 Create a DOMHTMLOptionsCollection. If we fail to query for
9398 IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return
9400 (DOMHTMLOptionsCollection::length):
9401 (DOMHTMLOptionsCollection::item):
9402 Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL.
9403 (DOMHTMLOptionsCollection::namedItem):
9404 Correct the signature of this function.
9407 Declare DOMHTMLOptionsCollection::createInstance(). Correct the
9408 signature of namedItem() to match IDOMHTMLOptionsCollection. Add a
9409 member to DOMHTMLOptionsCollection to hold the WebCore object.
9411 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
9413 DOMHTMLInputElement::rectOnScreen() returns the wrong rect
9415 https://bugs.webkit.org/show_bug.cgi?id=31487
9417 Reviewed by Darin Adler.
9419 * DOMHTMLClasses.cpp:
9420 (DOMHTMLInputElement::rectOnScreen):
9421 Return the rect on screen, not the rect in the window.
9423 2009-11-17 Brent Fulgham <bfulgham@webkit.org>
9425 Reviewed by NOBODY - Build Fix.
9427 Correct build error in Debug_Cairo target after @49705.
9429 * WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib
9430 dependency to have proper "_debug" suffix needed by
9431 the Debug_Cairo target.
9433 2009-11-17 Brian Weinstein <bweinstein@apple.com>
9435 Reviewed by NOBODY - Build Fix.
9437 Touch files to try to fix the build.
9439 * Interfaces/IWebInspector.idl:
9440 * Interfaces/WebKit.idl:
9441 * WebKit.vcproj/Interfaces.vcproj:
9443 2009-11-17 Pavel Feldman <pfeldman@chromium.org>
9445 Reviewed by Timothy Hatcher.
9447 Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
9448 - Updated DRT to show/close inspector for all tests under /inspector
9449 - Introduced LayoutTestController::setTimelineProfilingEnabled and
9450 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
9451 - Removed reload on each inspector test
9452 - Renamed fast/inspector to fast/inspector-support in order not to trigger
9453 inspector for those.
9454 - Reimplemented timeline tests in order to get rid of reload there.
9455 - Moved tests that don't require harness into the fast group.
9457 https://bugs.webkit.org/show_bug.cgi?id=31472
9459 * Interfaces/IWebInspector.idl:
9461 (WebInspector::isTimelineProfilingEnabled):
9462 (WebInspector::setTimelineProfilingEnabled):
9465 2009-11-13 Adam Roben <aroben@apple.com>
9469 * Interfaces/WebKit.idl: Touch this to force interfaces to rebuild.
9471 2009-11-13 Adam Roben <aroben@apple.com>
9473 Tell the WebFrameLoadDelegate when window objects in isolated worlds
9476 Fixes <http://webkit.org/b/31124>.
9478 Reviewed by Dave Hyatt.
9480 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added
9481 didClearWindowObjectForFrameInScriptWorld.
9484 (WebFrame::dispatchDidClearWindowObjectInWorld):
9486 Replaced windowObjectCleared with this function. If the delegate
9487 implements IWebFrameLoadDelegatePrivate2, call
9488 didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in
9489 world is the mainThreadNormalWorld(), call
9490 didClearWindowObjectForFrame.
9492 * WebScriptWorld.cpp:
9493 (allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
9495 (WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds().
9496 (WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds().
9497 (WebScriptWorld::standardWorld): Added this non-COM getter for the
9498 standard world, which the COM getter now calls through to.
9499 (WebScriptWorld::findOrCreateWorld): Added. Returns the existing
9500 WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
9503 * WebScriptWorld.h: Added new standardWorld overload, made one
9504 overload of createInstance private, and added findOrCreateWorld.
9506 2009-11-13 Adam Roben <aroben@apple.com>
9510 * Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they
9511 are order-dependent!
9513 2009-11-13 Adam Roben <aroben@apple.com>
9515 Touch WebKit.idl to fix the Windows build
9517 * Interfaces/WebKit.idl: Sorted #includes.
9519 2009-11-13 Adam Roben <aroben@apple.com>
9521 Finish replacing worldIDs with world objects
9523 The only remaining use of worldIDs was in a method only used by DRT
9524 for the isolated worlds tests.
9526 Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
9528 Reviewed by Mark Rowe.
9530 * Interfaces/IWebFramePrivate.idl:
9532 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
9534 Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an
9535 IWebScriptWorld instead of a worldID, so we don't need to maintain a
9536 map of worldID -> world anymore.
9538 2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
9540 Reviewed by Darin Adler.
9542 externalRepresentation should take Frame as the argument
9543 https://bugs.webkit.org/show_bug.cgi?id=31393
9545 No new tests as this is just a refactoring.
9548 (WebFrame::renderTreeAsExternalRepresentation):
9550 2009-11-12 Adam Roben <aroben@apple.com>
9552 Replace worldIDs with world objects
9554 WebScriptWorld is the new object that represents a world. The only
9555 place worldID is still used is in
9556 IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but
9557 that will change soon.
9559 Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
9560 user scripts/stylesheets and isolated worlds
9562 Reviewed by Sam Weinig.
9564 * ForEachCoClass.h: Added WebScriptWorld.
9566 * Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with
9569 * Interfaces/IWebScriptWorld.idl: Added.
9571 * Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet
9572 functions to take an IWebScriptWorld instead of a worldID.
9574 * Interfaces/WebKit.idl: Added WebScriptWorld.
9577 (WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes
9579 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the
9580 bizarre world caching/creation logic that DRT depends on here from the
9581 findWorld function in ScriptController.cpp. Updated to use
9582 ScriptController::executeScriptInWorld instead of
9583 ScriptController::executeScriptInIsolatedWorld.
9585 * WebFrame.h: Replaced contextForWorldID with contextForWorld.
9587 * WebScriptWorld.cpp: Added.
9588 (WebScriptWorld::WebScriptWorld):
9589 (WebScriptWorld::~WebScriptWorld):
9590 (WebScriptWorld::createInstance):
9591 (WebScriptWorld::AddRef):
9592 (WebScriptWorld::Release):
9593 (WebScriptWorld::QueryInterface):
9594 Standard COM class implementations.
9596 (WebScriptWorld::standardWorld): Returns a shared instance that represents
9597 WebCore's mainThreadNormalWorld().
9599 * WebScriptWorld.h: Added.
9600 (WebScriptWorld::world): Simple getter.
9602 * WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl.
9604 * WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld.
9606 * WebKitClassFactory.cpp: Added WebScriptWorld.
9609 (WebView::addUserScriptToGroup):
9610 (WebView::addUserStyleSheetToGroup):
9611 (WebView::removeUserScriptFromGroup):
9612 (WebView::removeUserStyleSheetFromGroup):
9613 (WebView::removeUserScriptsFromGroup):
9614 (WebView::removeUserStyleSheetsFromGroup):
9616 Changed these functions to take an IWebScriptWorld instead of a worldID.
9618 2009-11-12 Adam Roben <aroben@apple.com>
9620 Small clean-up in WebView's user content functions
9622 Preparation for <http://webkit.org/b/31414> Implement new SPI for
9623 dealing with user scripts/stylesheets and isolated worlds
9625 Reviewed by Dave Hyatt.
9630 Added these helper functions to convert BSTRs to WebCore types.
9633 (WebView::addUserScriptToGroup):
9634 (WebView::addUserStyleSheetToGroup):
9635 (WebView::removeUserScriptFromGroup):
9636 (WebView::removeUserStyleSheetFromGroup):
9637 (WebView::removeUserScriptsFromGroup):
9638 (WebView::removeUserStyleSheetsFromGroup):
9639 (WebView::removeAllUserContentFromGroup):
9640 Use the new helper functions.
9642 2009-11-11 Beth Dakin <bdakin@apple.com>
9644 Build fix. No review needed.
9646 * WebKitGraphics.cpp:
9649 2009-11-10 Daniel Bates <dbates@webkit.org>
9651 Reviewed by Oliver Hunt.
9653 https://bugs.webkit.org/show_bug.cgi?id=30754
9655 Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo.
9657 * WebDropSource.cpp:
9658 (WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo.
9660 2009-11-10 Alexey Proskuryakov <ap@apple.com>
9662 Reviewed by Dan Bernstein.
9664 https://bugs.webkit.org/show_bug.cgi?id=31312
9665 Decouple authentication panel callbacks from ResourceHandle
9667 * WebCoreSupport/WebFrameLoaderClient.cpp:
9668 (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
9669 * WebURLAuthenticationChallenge.cpp:
9670 (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
9671 (WebURLAuthenticationChallenge::sender):
9672 * WebURLAuthenticationChallengeSender.cpp:
9673 (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
9674 (WebURLAuthenticationChallengeSender::createInstance):
9675 (WebURLAuthenticationChallengeSender::authenticationClient):
9676 * WebURLAuthenticationChallengeSender.h:
9677 * WebURLAuthenticationChallengeSenderCFNet.cpp:
9678 (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
9679 (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
9680 (WebURLAuthenticationChallengeSender::useCredential):
9681 Adjusted for WebCore changes.
9683 2009-11-10 Brian Weinstein <bweinstein@apple.com>
9685 Reviewed by NOBODY - Build Fix.
9687 Updated fillRoundedRect to take a ColorSpace argument.
9689 * WebCoreSupport/WebDragClient.cpp:
9690 (WebDragClient::createDragImageForLink):
9692 2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>
9694 Reviewed by Holger Freyther.
9696 ResourceRequest to be class instead of struct
9697 https://bugs.webkit.org/show_bug.cgi?id=30670
9699 Started as a compilation fix for Symbian where the compiler makes a distinction between
9700 class and struct in function argument signatures.
9701 Changed forward declaration of ResourceRequest to have class in the forward
9702 declaration instead of struct.
9706 2009-11-05 Adam Roben <aroben@apple.com>
9708 Make CFDictionaryPropertyBag::createInstance return a COMPtr
9710 I also cleaned up CFDictionaryPropertyBag's class declaration a little
9713 Part of <http://webkit.org/b/25294> <rdar://problem/6803127> All
9714 WebKit/win classes should return COMPtrs from their static constructor
9717 Reviewed by Steve Falkenburg.
9719 * CFDictionaryPropertyBag.cpp:
9720 (CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to
9721 initialize m_refCount to 0. m_refCount gets increased to 1 by
9723 (CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr.
9725 * CFDictionaryPropertyBag.h:
9726 - Updated copyright years
9727 - Fixed header guard to match current style
9728 - Replaced #include of CoreFoundation.h with forward-declaration of
9729 CFMutableDictionaryRef
9730 - Added #include of COMPtr.h
9731 - Fixed opening brace placement in class declaration
9732 - Made createInstance return a COMPtr
9733 - Made constructor/destructor private
9734 - Made QueryInterface and IPropertyBag functions private
9735 - Removed unnecessary parameter names and MIDL comments
9738 (WebCache::statistics): Updated for change to
9739 CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place
9740 the IPropertyBag pointers into the s array.
9742 * WebCoreSupport/WebFrameLoaderClient.cpp:
9743 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
9744 * WebDatabaseManager.cpp:
9745 (WebDatabaseManager::dispatchDidModifyDatabase):
9747 (WebFrame::createJavaAppletWidget):
9748 Updated for change to CFDictionaryPropertyBag::createInstance.
9750 * WebHistory.cpp: Removed releaseUserInfo, which is no longer needed.
9751 That function was also doing an unnecessary call to setDictionary(0).
9752 (createUserInfoFromArray):
9753 (createUserInfoFromHistoryItem):
9754 Changed to return COMPtr.
9756 (WebHistory::loadFromURL): Updated for change to
9757 CFDictionaryPropertyBag::createInstance.
9759 (WebHistory::removeAllItems): Updated for change to
9760 CFDictionaryPropertyBag::createInstance, which fixed a leak! We had
9761 forgotten to call releaseUserInfo here.
9763 (WebHistory::removeItem):
9764 (WebHistory::addItem):
9765 (WebHistory::visitedURL):
9766 * WebIconDatabase.cpp:
9767 (postDidAddIconNotification):
9768 Updated for change to CFDictionaryPropertyBag::createInstance.
9770 * WebKitClassFactory.cpp:
9771 (releaseRefFromCreateInstance): Added this overloaded function
9772 template to abstract away the difference between createInstance
9773 functions that return a ref'd pointer and createInstance functions
9774 that return a COMPtr.
9775 (WebKitClassFactory::CreateInstance): Changed to use
9776 releaseRefFromCreateInstance.
9778 2009-11-03 Brian Weinstein <bweinstein@apple.com>
9780 Reviewed by Steve Falkenburg.
9782 WebActionModifierFlagsKey should return an unsigned, because
9783 flags imply a bitmask, and that is what other classes expect from
9786 * WebActionPropertyBag.cpp:
9787 (WebActionPropertyBag::Read):
9789 2009-11-02 Eric Carlson <eric.carlson@apple.com>
9791 Reviewed by John Sullivan and Mark Rowe.
9793 <rdar://problem/7356733> Voiceover does not read correct media controller time values
9795 * WebCoreLocalizedStrings.cpp:
9796 (WebCore::localizedMediaTimeDescription):
9798 2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
9800 MSAA: Accessibility of headings is not correct
9802 https://bugs.webkit.org/show_bug.cgi?id=30937
9804 Reviewed by Alice Liu.
9806 * AccessibleBase.cpp:
9807 (AccessibleBase::get_accDescription):
9808 Call the object's descriptionForMSAA(). Moved the comment to the
9810 (AccessibleBase::get_accRole):
9811 If the object has a string role, return that. Otherwise, return the
9815 Removed description(), as this was moved to WebCore.
9817 2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
9819 MSAA: Accessibility of links is wrong
9821 https://bugs.webkit.org/show_bug.cgi?id=30928
9823 Reviewed by Darin Adler.
9825 * AccessibleBase.cpp:
9826 (AccessibleBase::get_accState):
9827 Check whether the element is linked, instead of whether the node is an
9828 anchor, so the child "linkable" elements of anchor elements will also
9830 (AccessibleBase::name):
9831 Return the name for MSAA.
9832 (AccessibleBase::value):
9833 Return the string value for MSAA.
9835 2009-10-30 Evan Stade <estade@chromium.org>
9837 Reviewed by David Levin.
9839 Notify the chrome when the focused node has changed.
9840 https://bugs.webkit.org/show_bug.cgi?id=30832
9842 Added stub implementation for new ChromeClient function.
9844 * WebCoreSupport/WebChromeClient.cpp:
9845 (WebChromeClient::focusedNodeChanged):
9846 * WebCoreSupport/WebChromeClient.h:
9848 2009-10-30 Roland Steiner <rolandsteiner@chromium.org>
9850 Reviewed by Eric Seidel.
9852 Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
9854 Bug 28420 - Implement HTML5 <ruby> rendering
9855 (https://bugs.webkit.org/show_bug.cgi?id=28420)
9857 No new tests (no functional change).
9859 * WebKit.vcproj/WebKit.vcproj:
9861 2009-10-29 Mark Rowe <mrowe@apple.com>
9863 Rubber-stamped by Dan Bernstein.
9865 <http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes
9866 to IWebFramePrivate vtable ordering
9868 * Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that
9869 it doesn't affect the ordering of the vtable.
9871 2009-10-28 Steve Falkenburg <sfalken@apple.com>
9873 Reviewed by Sam "Horatio" Weinig.
9875 Should not generate/build COM DOM bindings
9876 https://bugs.webkit.org/show_bug.cgi?id=30880
9878 * Interfaces/WebKit.idl: Remove generated interfaces.
9879 * WebKit.vcproj/InterfacesGenerated.vcproj: Removed.
9880 * WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj.
9881 * WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj.
9882 * WebKit.vcproj/WebKit.vcproj: Remove generated interfaces.
9884 2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
9886 Reviewed by Darin Adler.
9888 Provide a way to get counter values with layoutTestContoller
9889 https://bugs.webkit.org/show_bug.cgi?id=30555
9891 * Interfaces/IWebFramePrivate.idl:
9893 (WebFrame::counterValueForElementById):
9896 2009-10-28 Joe Mason <jmason@rim.com>
9898 Reviewed by Adam Treat.
9900 Call the shared FrameLoader::defaultObjectContentType instead of
9901 copying code into FrameLoaderClient::objectContentType. This causes no
9905 (WebFrame::objectContentType):
9907 2009-10-28 Holger Hans Peter Freyther <zecke@selfish.org>
9909 Speculative build-fix for WebElementPropertyBag.cpp
9911 * WebElementPropertyBag.cpp: Include RenderObject.h
9913 2009-10-27 Holger Hans Peter Freyther <zecke@selfish.org>
9915 Reviewed by Simon Fraser.
9917 Change HitTestResult methods to use (3d) transformation aware methods
9918 https://bugs.webkit.org/show_bug.cgi?id=27347
9920 The HitTestResult::boundingBox method was removed. The
9921 RenderObject must be used directly. In contrast to the
9922 old HitTestResult::boundingBox method this code must use
9923 a (3d) transformation aware method to not run into an
9924 assert in SVGRenderBase::mapLocalToContainer.
9926 * WebElementPropertyBag.cpp:
9927 (WebElementPropertyBag::Read): Replace HitTestResult::boundingBox()
9929 2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
9931 Reviewed by Darin Adler.
9933 Make .rc files compile on Windows without depending on MFC headers
9934 https://bugs.webkit.org/show_bug.cgi?id=30750
9936 * WebKit.vcproj/WebKit.rc: Use winresrc.h because it exists even
9937 when MFC is not installed, and is all that's needed here.
9939 2009-10-26 Sam Weinig <sam@webkit.org>
9941 Rubber-stamped by Darin Adler.
9943 Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
9944 inherit from HTMLCollection.
9946 * DOMCreateInstance.cpp:
9948 2009-10-25 Dan Bernstein <mitz@apple.com>
9950 Reviewed by John Sullivan.
9952 Add contextForWorldID to the IWebFramePrivate interface.
9954 * Interfaces/IWebFramePrivate.idl:
9957 2009-10-25 Sam Weinig <sam@webkit.org>
9959 Another try at fixing windows.
9961 * DOMCreateInstance.cpp:
9963 2009-10-25 Sam Weinig <sam@webkit.org>
9965 Touch WebKit.idl in an effort to try and regenerate the COM bindings.
9967 * Interfaces/WebKit.idl:
9969 2009-10-23 Mark Rowe <mrowe@apple.com>
9971 Build fix. Include config.h before including other files.
9973 * AccessibleImage.cpp:
9975 2009-10-23 Gavin Barraclough <barraclough@apple.com>
9977 Reviewed by Geoff Garen.
9979 https://bugs.webkit.org/show_bug.cgi?id=30729
9980 Provide private API to request the global context for a specific world.
9981 Used to initialize parameters on the global object.
9984 (WebFrame::contextForWorldID):
9987 2009-10-23 Brian Weinstein <bweinstein@apple.com>
9989 Reviewed by John Sullivan.
9991 Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
9992 <http://webkit.org/b/30732> and <rdar://7332018>.
9994 Turns off pan-scrolling on a WebView when it is about to lose focus.
9999 2009-10-23 Jon Honeycutt <jhoneycutt@apple.com>
10001 MSAA: Name for image elements should use alt attribute text
10003 https://bugs.webkit.org/show_bug.cgi?id=30727
10004 <rdar://problem/7328291>
10006 Reviewed by Alice Liu.
10008 * AccessibleBase.cpp:
10009 (AccessibleBase::createInstance):
10010 If the AccessibilityObject is an image, return an AccessibleImage.
10012 * AccessibleImage.cpp: Added.
10013 (AccessibleImage::AccessibleImage):
10014 Call the base constructor.
10015 (AccessibleImage::name):
10016 If the object is not an AccessibilityRenderObject, return the base's
10017 name(). Look first for an ARIA "labeled-by" attribute, then look for an
10018 alternate text attribute. Fall back to the base's name().
10020 * AccessibleImage.h: Added.
10021 (AccessibleImage::~AccessibleImage):
10023 * WebKit.vcproj/WebKit.vcproj:
10024 Add AccessibleImage to the project.
10026 2009-10-23 Sam Weinig <sam@webkit.org>
10028 Try and fix the windows build.
10030 * Interfaces/WebKit.idl:
10032 2009-10-22 Gavin Barraclough <barraclough@apple.com>
10034 Reviewed by Sam Weinig & Geoff Garen.
10036 https://bugs.webkit.org/show_bug.cgi?id=30696
10037 Update to incorporate support for IsolatedWorlds in JSC bindings.
10039 * Interfaces/IWebFramePrivate.idl:
10041 (WebFrame::globalContext):
10042 (WebFrame::windowObjectCleared):
10043 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):
10046 2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
10048 Reviewed by David Levin.
10050 Removed WebSocket runtime settings.
10051 https://bugs.webkit.org/show_bug.cgi?id=29896
10053 WebSocket runtime configuration is supported by chromium/v8 only.
10055 * Interfaces/IWebPreferencesPrivate.idl:
10056 * WebPreferenceKeysPrivate.h:
10057 * WebPreferences.cpp:
10058 (WebPreferences::initializeDefaultSettings):
10059 (WebPreferences::experimentalNotificationsEnabled):
10060 * WebPreferences.h:
10062 (WebView::notifyPreferencesChanged):
10064 2009-10-19 Adam Roben <aroben@apple.com>
10066 Fix crashes/assertions when calling WebLocalizedString from multiple
10067 threads concurrently
10069 Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called
10070 from multiple threads concurrently
10072 Reviewed by John Sullivan.
10074 * WebLocalizableStrings.cpp:
10075 (mainBundleLocStringsMutex):
10076 (frameworkLocStringsMutex):
10077 Added these new getters.
10079 (findCachedString):
10081 Lock the relevant mutex before accessing each string map. Otherwise
10082 bad things could happen if two threads end up here at the same time.
10084 2009-10-19 Adam Roben <aroben@apple.com>
10086 Get rid of a few static initializers/exit-time destructors in
10087 WebLocalizableStrings
10089 Reviewed by Dan Bernstein.
10091 * WebLocalizableStrings.cpp:
10092 (mainBundleLocStrings):
10093 (frameworkLocStrings):
10094 Added these functions instead of file-scope variables.
10096 (findCachedString):
10098 Updated to use the new functions.
10100 2009-10-19 Nate Chapin <japhet@chromium.org>
10102 Unreviewed, build fix.
10104 Update call to FrameLoader::urlSelected().
10106 * WebCoreSupport/WebContextMenuClient.cpp:
10107 (WebContextMenuClient::searchWithGoogle):
10109 2009-10-16 Steve Falkenburg <sfalken@apple.com>
10111 Reviewed by Dan Bernstein.
10113 https://bugs.webkit.org/show_bug.cgi?id=30456
10114 Fixes for new Debug_All Windows build configuration.
10116 * WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.
10118 2009-10-16 Jon Honeycutt <jhoneycutt@apple.com>
10120 Add SPI to determine whether a plug-in has ever been halted.
10122 Part of <rdar://problem/7312158>.
10124 Reviewed by Dan Bernstein.
10126 * Interfaces/IWebViewPrivate.idl:
10127 Add hasPluginForNodeBeenHalted().
10130 (pluginViewForNode):
10131 Code factored out of isNodeHaltedPlugin().
10132 (WebView::isNodeHaltedPlugin):
10133 Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
10134 pluginViewForNode().
10135 (WebView::restartHaltedPluginForNode):
10137 (WebView::hasPluginForNodeBeenHalted):
10138 Get the PluginView for the given node. Return the result of
10139 PluginView::hasBeenHalted().
10142 Declare hasPluginForNodeBeenHalted().
10144 2009-10-16 Steve Falkenburg <sfalken@apple.com>
10146 Reviewed by Adam Roben.
10148 Add a Debug_All configuration to build entire stack as debug.
10149 Change Debug_Internal to:
10150 - stop using _debug suffix for all WebKit/Safari binaries
10151 - not use _debug as a DLL naming suffix
10152 - use non-debug C runtime lib.
10154 * WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
10155 * WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
10156 * WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
10157 * WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
10158 * WebKit.vcproj/WebKit.vcproj:
10159 Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
10160 Add Debug_All configuration.
10161 * WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.
10163 2009-10-15 Jon Honeycutt <jhoneycutt@apple.com>
10165 Add SPI to restart a halted plug-in.
10167 Part of <rdar://problem/7273354> Halted plug-ins should restart on
10170 https://bugs.webkit.org/show_bug.cgi?id=30151
10172 Reviewed by Kevin Decker.
10174 * Interfaces/IWebViewPrivate.idl:
10175 Add restartHaltedPluginForNode().
10178 (WebView::restartHaltedPluginForNode):
10179 From the IDOMNode, query for the DOMNode. From the DOMNode, get the
10180 WebCore::Node. Get the node's renderer, and check whether it is a
10181 RenderWidget. If so, get its Widget, and check whether it's a
10182 PluginView. If so, call PluginView::restart().
10185 Declare restartHaltedPluginForNode().
10187 2009-10-14 Jon Honeycutt <jhoneycutt@apple.com>
10189 Add SPI to determine whether a node is a halted plug-in.
10191 Part of <rdar://problem/7273354> Halted plug-ins should restart on
10194 https://bugs.webkit.org/show_bug.cgi?id=30151
10196 Reviewed by Darin Adler.
10198 * Interfaces/IWebViewPrivate.idl:
10199 Add isNodehaltedPlugin().
10202 (WebView::isNodeHaltedPlugin):
10203 From the IDOMNode, query for the DOMNode. From the DOMNode, get the
10204 WebCore::Node. Get the node's renderer, and check whether it is a
10205 RenderWidget. If so, get its Widget, and check whether it's a
10206 PluginView. If so, return the result of PluginView::isHalted().
10209 Declare isNodeHaltedPlugin().
10211 2009-10-15 Daniel Bates <dbates@webkit.org>
10213 Reviewed by Adam Roben.
10215 https://bugs.webkit.org/show_bug.cgi?id=24731
10217 rdar://problem/5015961
10219 Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend)
10220 in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is
10223 The WebView and WebDropSource drag-and-drop functions, as called by function
10224 DoDragDrop in its event loop, neither used the drop effect as specified by
10225 event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed.
10226 Instead, these functions defaulted to some hardcoded drop effect and set of
10227 allowed drop effects, respectively.
10229 Tests: fast/events/drag-and-drop.html
10231 * WebCoreSupport/WebDragClient.cpp:
10232 (WebDragClient::startDrag):
10233 * WebDropSource.cpp:
10234 (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt
10235 into method WebDragClient::startDrag.
10238 (WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines
10239 appropriate drop effect from state of keyboard and allowed effects
10240 m_page->dragController()->sourceDragOperation().
10241 (WebView::DragEnter):
10242 (WebView::DragOver):
10246 2009-10-14 Adam Roben <aroben@apple.com>
10250 * WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
10251 IWebNavigationData from the build (they get #imported via WebKit.idl).
10253 2009-10-14 Brady Eidson <beidson@apple.com>
10255 Reviewed by Sam Weinig.
10257 WebKit Win API should provide a delegate interface for global history.
10258 https://bugs.webkit.org/show_bug.cgi?id=29905
10260 -Add IWebHistoryDelegate for clients to implement.
10261 -Add (I)WebNavigationData for the history delegate's use.
10262 -When it exists, call the history delegate instead of using WebHistory.
10264 * Interfaces/IWebHistoryDelegate.idl: Added.
10265 * Interfaces/IWebHistoryPrivate.idl:
10266 * Interfaces/IWebNavigationData.idl: Added.
10267 * Interfaces/IWebViewPrivate.idl:
10268 * Interfaces/WebKit.idl:
10270 * WebKit.vcproj/Interfaces.vcproj:
10271 * WebKit.vcproj/WebKit.vcproj:
10273 * WebCoreSupport/WebChromeClient.cpp:
10274 (WebChromeClient::populateVisitedLinks):
10275 * WebCoreSupport/WebFrameLoaderClient.cpp:
10276 (WebFrameLoaderClient::updateGlobalHistory):
10277 (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
10278 (WebFrameLoaderClient::setTitle):
10282 (WebView::mainFrameURL):
10283 (WebView::setHistoryDelegate):
10284 (WebView::historyDelegate):
10285 (WebView::addVisitedLinks):
10289 (WebHistory::setVisitedLinkTrackingEnabled):
10290 (WebHistory::removeAllVisitedLinks):
10293 * WebNavigationData.cpp: Added.
10294 (WebNavigationData::QueryInterface):
10295 (WebNavigationData::AddRef):
10296 (WebNavigationData::Release):
10297 (WebNavigationData::WebNavigationData):
10298 (WebNavigationData::~WebNavigationData):
10299 (WebNavigationData::createInstance):
10300 (WebNavigationData::url):
10301 (WebNavigationData::title):
10302 (WebNavigationData::originalRequest):
10303 (WebNavigationData::response):
10304 (WebNavigationData::hasSubstituteData):
10305 (WebNavigationData::clientRedirectSource):
10306 * WebNavigationData.h: Added.
10308 2009-10-13 Dave Hyatt <hyatt@apple.com>
10310 Fix more WebView bustage.
10313 (WebView::addUserScriptToGroup):
10314 (WebView::addUserStyleSheetToGroup):
10315 (WebView::removeUserScriptsFromGroup):
10316 (WebView::removeUserStyleSheetsFromGroup):
10318 2009-10-13 Dave Hyatt <hyatt@apple.com>
10320 Fix build bustage on Windows.
10323 (WebView::addUserScriptToGroup):
10324 (WebView::addUserStyleSheetToGroup):
10325 (WebView::removeUserScriptsFromGroup):
10326 (WebView::removeUserStyleSheetsFromGroup):
10328 2009-10-13 Dave Hyatt <hyatt@apple.com>
10330 Reviewed by Adam Roben..
10332 Split removal functions for user scripts and stylehseets based on type.
10334 * Interfaces/IWebViewPrivate.idl:
10336 (WebView::removeUserScriptFromGroup):
10337 (WebView::removeUserStyleSheetFromGroup):
10340 2009-10-09 Adam Barth <abarth@webkit.org>
10342 Reviewed by Darin Adler.
10344 Factor HistoryController out of FrameLoader
10345 https://bugs.webkit.org/show_bug.cgi?id=30246
10350 (WebView::loadBackForwardListFromOtherView):
10352 2009-10-08 Jon Honeycutt <jhoneycutt@apple.com>
10354 Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking
10355 for the existence of a PluginHalterDelegate.
10357 Reviewed by Dan Bernstein.
10359 * Interfaces/IWebPreferencesPrivate.idl:
10360 Remove the getter and setter.
10362 * WebCoreSupport/WebPluginHalterClient.cpp:
10363 (WebPluginHalterClient::enabled):
10364 Return true if the delegate exists.
10366 * WebCoreSupport/WebPluginHalterClient.h:
10367 Declare implementation of enabled().
10369 * WebPreferenceKeysPrivate.h:
10370 Removed the pref key.
10372 * WebPreferences.cpp:
10373 (WebPreferences::initializeDefaultSettings):
10374 Removed initialization of the pref.
10376 * WebPreferences.h:
10377 Removed declaration of the getter/setter.
10380 (WebView::notifyPreferencesChanged):
10381 Don't propagate the pref.
10383 2009-10-08 Adam Barth <abarth@webkit.org>
10385 Reviewed by Eric Seidel.
10387 Move executeScript from FrameLoader to ScriptController
10388 https://bugs.webkit.org/show_bug.cgi?id=30200
10393 (WebView::stringByEvaluatingJavaScriptFromString):
10395 2009-10-08 Anders Carlsson <andersca@apple.com>
10397 Reviewed by Sam Weinig.
10399 Remove the shouldLoadMediaElementURL implementation.
10401 * Interfaces/IWebPolicyDelegatePrivate.idl:
10402 * WebCoreSupport/WebFrameLoaderClient.cpp:
10403 (WebFrameLoaderClient::shouldUsePluginDocument):
10404 * WebCoreSupport/WebFrameLoaderClient.h:
10406 2009-10-08 Adam Roben <aroben@apple.com>
10408 Make IWebInspectorPrivate be accessed in a more standard way
10410 IWebViewPrivate::inspectorPrivate has been removed. Callers should
10411 instead use IWebViewPrivate::inspector and then use QueryInterface to
10412 get the IWebInspectorPrivate interface. This matches how our other COM
10415 Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
10416 accessed in a more standard way
10418 Reviewed by John Sullivan and Tim Hatcher.
10420 * Interfaces/IWebViewPrivate.idl: Removed inspectorPrivate.
10422 * WebInspector.cpp:
10423 (WebInspector::QueryInterface): Support querying to
10424 IWebInspectorPrivate.
10428 Removed inspectorPrivate.
10430 2009-10-08 Adam Roben <aroben@apple.com>
10432 Move the new IWebViewPrivate::inspectorPrivate function after all
10433 functions that existed when Safari 4.0.3 was released
10435 Fixes <http://webkit.org/b/30085> REGRESSION (r49091): run-safari
10436 crashes in Safari.dll
10438 Reviewed by John Sullivan.
10440 * Interfaces/IWebViewPrivate.idl: Moved inspectorPrivate to the end of
10441 the interface, so it won't modify the vtable that Safari 4.0.3 sees.
10443 2009-10-07 Adam Roben <aroben@apple.com>
10445 Expose origin whitelisting in the WebKit API on Windows
10447 Fixes <http://webkit.org/b/30185>.
10449 Reviewed by Eric Seidel.
10451 * Interfaces/IWebViewPrivate.idl: Added whiteListAccessFromOrigin and
10452 resetOriginAccessWhiteLists, to match the Mac SPI.
10455 (WebView::whiteListAccessFromOrigin):
10456 (WebView::resetOriginAccessWhiteLists):
10458 Added. These just call through to SecurityOrigin.
10460 2009-10-07 Adam Barth <abarth@webkit.org>
10462 Reviewed by Darin Adler.
10464 Factor PolicyChecker out of FrameLoader
10465 https://bugs.webkit.org/show_bug.cgi?id=30155
10467 Move the policy callback to the policy object.
10470 (WebFrame::dispatchWillSubmitForm):
10471 (WebFrame::receivedPolicyDecision):
10472 (WebFrame::dispatchDecidePolicyForMIMEType):
10473 (WebFrame::dispatchDecidePolicyForNewWindowAction):
10474 (WebFrame::dispatchDecidePolicyForNavigationAction):
10476 2009-10-07 Daniel Bates <dbates@webkit.org>
10478 Reviewed by Darin Adler.
10480 https://bugs.webkit.org/show_bug.cgi?id=30102
10482 <rdar://problem/5015957>
10484 Fixes an issue (in the Windows build) where the cursor does not change to the
10485 not-allowed cursor when the drag-and-drop operation is not allowed.
10487 The allowed effects in WebDragClient::startDrag are hard-coded to be
10488 DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of
10489 allowed drop effects should be determined by the allowed operations of the
10492 We cannot test this using DRT because DRT looks at the programmatic drop
10493 cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
10494 That is, there is a discrepancy in the Windows build between the Windows API-based
10495 drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer
10496 to determine the cursor, a manual test is needed.
10498 * WebCoreSupport/WebDragClient.cpp:
10499 (draggingSourceOperationMaskToDragCursors): Added method.
10500 (WebDragClient::startDrag):
10502 2009-10-07 Steve Falkenburg <sfalken@apple.com>
10504 Reviewed by Darin Adler.
10506 https://bugs.webkit.org/show_bug.cgi?id=30176
10507 <rdar://problem/7281553> Extra information in UA causes problems with gmail
10509 * WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.
10511 2009-10-06 Pavel Feldman <pfeldman@chromium.org>
10513 Reviewed by Timothy Hatcher.
10515 Web Inspector: default to an attached inspector window on Windows (as on Mac).
10517 https://bugs.webkit.org/show_bug.cgi?id=30134
10519 * WebCoreSupport/WebInspectorClient.cpp:
10520 (WebInspectorClient::showWindowWithoutNotifications):
10522 2009-10-06 Adam Barth <abarth@webkit.org>
10524 Reviewed by Eric Seidel.
10526 Move FrameLoader::canLoad to SecurityOrigin
10527 https://bugs.webkit.org/show_bug.cgi?id=30111
10530 (WebFrame::allowsFollowingLink):
10532 2009-10-06 Pavel Feldman <pfeldman@chromium.org>
10534 Reviewed by Timothy Hatcher.
10536 Web Inspector: close inspector client view on
10537 InspectorController::close API call.
10539 In order to run batch web inspector layout tests (and not affect
10540 subsequent tests) we should close inspector client's view upon
10541 InspectorController::close API call.
10543 https://bugs.webkit.org/show_bug.cgi?id=30009
10545 * WebCoreSupport/WebInspectorClient.cpp:
10546 (WebInspectorClient::createPage):
10548 2009-10-06 David Levin <levin@chromium.org>
10550 Reviewed by NOBODY (windows build fix).
10552 Speculative build fix for windows (due to r49160).
10554 * WebDownloadCFNet.cpp:
10555 (WebDownload::initToResumeWithBundle):
10556 * WebIconDatabase.cpp:
10557 (WebIconDatabase::dispatchDidAddIconForPageURL):
10559 2009-10-05 Pavel Feldman <pfeldman@chromium.org>
10561 Reviewed by Timothy Hatcher.
10563 Web Inspector: add testing harness for Web Inspector.
10565 https://bugs.webkit.org/show_bug.cgi?id=30010
10567 * Interfaces/IWebInspectorPrivate.idl: Added.
10568 * Interfaces/IWebViewPrivate.idl:
10569 * Interfaces/WebKit.idl:
10570 * WebInspector.cpp:
10571 (WebInspector::evaluateInFrontend):
10574 (WebView::inspectorPrivate):
10577 2009-10-02 Dave Hyatt <hyatt@apple.com>
10579 Reviewed by Adam Roben.
10581 Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.
10583 * Interfaces/IWebViewPrivate.idl:
10586 (WebView::addUserScriptToGroup):
10587 (WebView::addUserStyleSheetToGroup):
10590 2009-10-02 Steve Falkenburg <sfalken@apple.com>
10592 Reviewed by Mark Rowe.
10594 <https://bugs.webkit.org/show_bug.cgi?id=29989>
10595 Safari version number shouldn't be exposed in WebKit code
10597 For a WebKit version of 532.3.4:
10598 Product version is: 5.32.3.4 (was 4.0.3.0)
10599 File version is: 5.32.3.4 (was 4.532.3.4)
10601 * WebKit.vcproj/WebKit.rc:
10603 2009-09-30 Sam Weinig <sam@webkit.org>
10605 Reviewed by Dan Bernstein.
10607 Fix for <rdar://problem/7259706>
10608 Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window
10610 * Interfaces/IWebFramePrivate.idl:
10612 (WebFrame::allowsFollowingLink):
10615 2009-09-30 Dave Hyatt <hyatt@apple.com>
10617 Reviewed by Adam Roben.
10619 Add the ability to remove user stylesheets and scripts by URL.
10621 * Interfaces/IWebViewPrivate.idl:
10623 (WebView::removeUserContentWithURLFromGroup):
10626 2009-09-29 Kenneth Russell <kbr@google.com>
10628 Reviewed by Dimitri Glazkov.
10630 Add support for run-time flag for 3D canvas
10631 https://bugs.webkit.org/show_bug.cgi?id=29826
10634 (WebView::notifyPreferencesChanged): Enable experimental WebGL
10635 flag when 3D_CANVAS is enabled in the build.
10637 2009-09-28 Alexey Proskuryakov <ap@apple.com>
10639 Reviewed by Darin Adler and Sam Weinig.
10641 Onclick not fired for an element copied with cloneContents() or cloneNode()
10642 https://bugs.webkit.org/show_bug.cgi?id=25130
10644 * DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.
10646 * WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.
10648 2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
10650 Reviewed by Eric Seidel.
10652 Add experimentalWebSocketsEnabled in WebPreferences.
10653 https://bugs.webkit.org/show_bug.cgi?id=28941
10655 * Interfaces/IWebPreferencesPrivate.idl:
10656 * WebPreferenceKeysPrivate.h:
10657 * WebPreferences.cpp:
10658 (WebPreferences::initializeDefaultSettings):
10659 (WebPreferences::setExperimentalWebSocketsEnabled):
10660 (WebPreferences::experimentalWebSocketsEnabled):
10661 * WebPreferences.h:
10663 (WebView::notifyPreferencesChanged):
10666 2009-09-25 Darin Adler <darin@apple.com>
10668 Reviewed by Steve Falkenburg.
10670 Speed up access to history items by caching date computation.
10672 * History/WebHistory.mm:
10673 (getDayBoundaries): Refactored from timeIntervalForBeginningOfDay.
10674 Returns the beginning of the day that the passed time is within and
10675 the beginning of the next day.
10676 (beginningOfDay): Added. Uses getDayBoundaries so it can be fast for
10677 multiple dates within the same day, which is the common case.
10678 (dateKey): Added. Calls beginningOfDay and converts to an integer.
10679 (WebHistory::findKey): Changed to call dateKey instead of
10680 timeIntervalForBeginningOfDay.
10682 2009-09-25 Adam Roben <aroben@apple.com>
10684 Add SPI to invalidate a WebView's backing store
10686 This is useful in conjunction with
10687 IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI
10688 delegate to force WebView to get its background redrawn.
10690 Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's
10693 Reviewed by Anders Carlsson.
10695 * Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore.
10697 (WebView::invalidateBackingStore): If rect is 0, invalidate our whole
10698 client rect. Otherwise invalidate the intersection of rect with our
10702 2009-09-24 Jon Honeycutt <jhoneycutt@apple.com>
10704 Add a mechanism for automatically halting plug-ins.
10706 Reviewed by Oliver Hunt.
10708 * Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface
10709 for a delegate that determines whether plug-ins should be halted.
10711 * Interfaces/IWebPreferencesPrivate.idl:
10712 Declare functions to get and set the enabled state of the plug-in
10713 halter and the plug-in allowed run time.
10715 * Interfaces/IWebViewPrivate.idl:
10716 Declare functions to get and set the IWebPluginHalterDelegate.
10718 * Interfaces/WebKit.idl:
10720 * WebCoreSupport/WebPluginHalterClient.cpp: Added.
10721 (WebPluginHalterClient::WebPluginHalterClient):
10722 (WebPluginHalterClient::shouldHaltPlugin):
10723 Get the IWebPluginHalterDelegate for the WebView. Create a WebKit
10724 DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin().
10725 If the call fails, return false. Otherwise, return the result of the
10728 * WebCoreSupport/WebPluginHalterClient.h: Added.
10730 * WebKit.vcproj/Interfaces.vcproj:
10731 Add IWebPluginHalterDelegate.idl.
10733 * WebKit.vcproj/WebKit.vcproj:
10734 Add WebPluginHalterClient.{h,cpp}.
10736 * WebPreferenceKeysPrivate.h:
10737 Define WebKitPluginHalterEnabledPreferenceKey and
10738 WebKitPluginAllowedRunTimePreferenceKey.
10740 * WebPreferences.cpp:
10741 (WebPreferences::initializeDefaultSettings):
10742 Leave plug-in halting disabled by default. Set the default value for
10743 the plug-in allowed run time to the max value of an unsigned int.
10744 (WebPreferences::setPluginHalterEnabled):
10745 (WebPreferences::pluginHalterEnabled):
10746 (WebPreferences::setPluginAllowedRunTime):
10747 (WebPreferences::pluginAllowedRunTime):
10749 * WebPreferences.h:
10753 Clear the IWebPluginHalterDelegate.
10754 (WebView::initWithFrame):
10755 Pass a WebPluginHalterClient when creating the Page.
10756 (WebView::notifyPreferencesChanged):
10757 Set the new settings when the preferences changed notification is
10759 (WebView::setPluginHalterDelegate):
10760 (WebView::pluginHalterDelegate):
10763 Declare overrides of setPluginHalterDelegate() and
10764 pluginHalterDelegate(). Added a member to track the
10765 IWebPluginHalterDelegate.
10767 2009-09-14 John Gregg <johnnyg@google.com>
10769 Reviewed by Eric Seidel.
10771 Enable switch for notifications (experimental) in Page Settings
10772 https://bugs.webkit.org/show_bug.cgi?id=28930
10774 Adds support for the experimentalNotificationsEnabled flag in Settings through
10775 WebPreferencesPrivate interface. Also cleans up some issues accessing the
10776 notification delegate through DumpRenderTree.
10778 * Interfaces/IWebPreferencesPrivate.idl:
10779 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
10780 (WebDesktopNotificationsDelegate::hasNotificationDelegate):
10781 (WebDesktopNotificationsDelegate::notificationDelegate):
10782 * WebPreferenceKeysPrivate.h:
10783 * WebPreferences.cpp:
10784 (WebPreferences::initializeDefaultSettings):
10785 (WebPreferences::setExperimentalNotificationsEnabled):
10786 (WebPreferences::experimentalNotificationsEnabled):
10787 * WebPreferences.h:
10789 (WebView::notifyPreferencesChanged):
10791 2009-09-23 Anders Carlsson <andersca@apple.com>
10793 Reviewed by Adam Roben.
10795 <rdar://problem/7243354>
10796 REGRESSION(48580-48636): Crash clicking embedded QT preview button on apple.com/trailers
10798 Check for a null IWebPolicyDelegatePrivate.
10800 * WebCoreSupport/WebFrameLoaderClient.cpp:
10801 (WebFrameLoaderClient::shouldLoadMediaElementURL):
10803 2009-09-22 Sam Weinig <sam@webkit.org>
10805 Rubber-stamped by Adam Roben.
10807 Remove accidentally left in declaration of reloadFromOrigin in IWebFramePrivate.idl
10809 * Interfaces/IWebFramePrivate.idl:
10811 2009-09-22 Sam Weinig <sam@webkit.org>
10813 Reviewed by Steve Falkenburg.
10815 Fix for <rdar://problem/6451745>
10816 Windows WebKit needs to implement reloadFromOrigin()
10818 * Interfaces/IWebFrame.idl:
10819 * Interfaces/IWebFramePrivate.idl:
10820 * Interfaces/IWebView.idl:
10822 (WebFrame::reloadFromOrigin):
10825 (WebView::reloadFromOrigin):
10828 2009-09-22 Adam Roben <aroben@apple.com>
10830 Manage refcounts correctly in DefaultDownloadDelegate::willSendRequest
10832 Fixes <http://webkit.org/b/29650> Crash in
10833 WebDownload::willSendRequest when using DefaultDownloadDelegate
10835 Reviewed by Brady Eidson.
10837 * DefaultDownloadDelegate.cpp:
10838 (DefaultDownloadDelegate::willSendRequest): Call AddRef() on the
10839 object we're returning via the finalRequest out-parameter.
10841 2009-09-21 Anders Carlsson <andersca@apple.com>
10843 Reviewed by Adam Roben.
10845 <rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource
10847 Implement WebFrameLoaderClient::shouldLoadMediaElementURL and have it call the new private policy
10850 * Interfaces/IWebPolicyDelegatePrivate.idl: Added.
10851 * Interfaces/WebKit.idl:
10852 * WebCoreSupport/WebFrameLoaderClient.cpp:
10853 (WebFrameLoaderClient::shouldLoadMediaElementURL):
10854 * WebCoreSupport/WebFrameLoaderClient.h:
10855 * WebKit.vcproj/Interfaces.vcproj:
10857 2009-09-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
10859 Reviewed by Simon Hausmann.
10861 Make PlatformWindow return something else than PlatformWidget
10862 https://bugs.webkit.org/show_bug.cgi?id=29085
10864 Reflect the rename of platformWindow and it's return type.
10866 * AccessibleBase.cpp:
10867 (AccessibleBase::get_accParent):
10868 * WebCoreSupport/WebChromeClient.cpp:
10869 (WebChromeClient::platformPageClient):
10870 * WebCoreSupport/WebChromeClient.h:
10872 2009-09-17 Brian Weinstein <bweinstein@apple.com>
10874 Reviewed by Adam Roben.
10876 Remove assertions that were being hit by calls to
10877 m_verticalScrollbar->invalidate(). These assertions were valid,
10878 but they were causing tests to fail, so replacing with a FIXME
10879 until we can find out the real cause/solution that is being tracked
10880 by http://webkit.org/b/29350.
10883 (WebView::addToDirtyRegion):
10884 (WebView::paintIntoBackingStore):
10886 2009-09-17 Ada Chan <adachan@apple.com>
10888 Post WebViewDidChangeSelectionNotification when the text selection changes.
10890 Fixes <http://webkit.org/b/29321>
10892 Reviewed by Adam Roben.
10894 * Interfaces/IWebView.idl:
10895 * WebCoreSupport/WebEditorClient.cpp:
10896 (WebEditorClient::respondToChangedSelection):
10898 2009-09-17 Adam Roben <aroben@apple.com>
10900 Fix a crash when a WebView's HWND is destroyed before IWebView::close
10903 WebView's HWND was being sent a WM_TIMER message after the WebView was
10904 destroyed. This normally isn't possible (we call DestroyWindow inside
10905 WebView's destructor to ensure the HWND doesn't outlive the WebView),
10906 but r48060 changed WebView to call SetParent(m_viewWindow,
10907 HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the
10908 HWND into some weird half-destroyed state where it can still receive
10911 Fixes <http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION
10912 (r48060): unrepro but frequent crash in WebViewWndProc
10914 Reviewed by Steve Falkenburg.
10917 (WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed()
10918 before calling close(). This allows setHostWindow to detect that we're
10919 handling WM_DESTROY. No other code in close() cared whether
10920 isBeingDestroyed() was true or not.
10921 (WebView::setHostWindow): If our host window is being set to 0 and
10922 we're being destroyed, don't become a message-only window. Doing this
10923 while handling WM_DESTROY seems to lead to crashes.
10925 2009-09-16 Adam Roben <aroben@apple.com>
10927 Add a UI delegate callback to let the delegate draw a WebView's
10930 Fixes <http://webkit.org/b/29315>.
10932 Reviewed by Dave Hyatt.
10934 * Interfaces/IWebUIDelegatePrivate.idl: Added
10935 IWebUIDelegatePrivate2::drawBackground.
10938 (WebView::paintIntoBackingStore): After clearing or filling with
10939 white, let the delegate draw whatever background it wants. Also added
10940 an assertion that the dirty rect is within our bounds.
10942 2009-09-16 Adam Roben <aroben@apple.com>
10944 Prevent WebView from painting over sibling windows
10946 Fixes <http://webkit.org/b/29300> <rdar://problem/7227960> WebView can
10947 paint over sibling windows
10949 Reviewed by Darin Adler.
10952 (WebView::initWithFrame): Create the WebView's HWND with the
10953 WS_CLIPSIBLINGS style.
10955 2009-09-14 Brady Eidson <beidson@apple.com>
10957 Reviewed by Alexey Proskuryakov.
10959 Safari 4 cannot be used to update firmware on Linksys routers.
10960 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
10962 Adopt the new WebCore::CredentialStorage in WebKit/Win.
10964 * WebDownloadCFNet.cpp:
10965 (WebDownload::didReceiveAuthenticationChallenge):
10967 2009-09-11 Steve Falkenburg <sfalken@apple.com>
10969 Reviewed by Dan Bernstein.
10971 Properly propagate preference from WebPreferences to WebCore::Settings.
10972 https://bugs.webkit.org/show_bug.cgi?id=29192
10975 (WebView::initWithFrame): Apply setting when creating a new WebView.
10976 (WebView::notifyPreferencesChanged): Apply setting when preferences change.
10978 2009-09-11 Steve Falkenburg <sfalken@apple.com>
10980 Reviewed by Darin Adler.
10982 Allow WebKit clients to opt out of high resolution timers on Windows.
10983 https://bugs.webkit.org/show_bug.cgi?id=29192
10985 * Interfaces/IWebPreferencesPrivate.idl: Added getter/setter.
10986 Put this just after last 4.0.3 method for future merging.
10987 * Interfaces/WebKit.idl: Touched to force a rebuild.
10988 * WebPreferenceKeysPrivate.h: Added prefs key for high res timers.
10989 * WebPreferences.cpp:
10990 (WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled.
10991 (WebPreferences::setShouldUseHighResolutionTimers): Added.
10992 (WebPreferences::shouldUseHighResolutionTimers): Added.
10993 * WebPreferences.h: Added getter/setter.
10995 2009-09-11 Adam Roben <aroben@apple.com>
10997 Get user script/stylesheet tests running on Windows
10999 Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
11002 Reviewed by John Sullivan.
11004 * Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup,
11005 addUserStyleSheetToGroup, removeUserContentFromGroup,
11006 removeAllUserContentFromGropu to match the Mac SPI.
11009 (WebView::addUserScriptToGroup):
11010 (WebView::addUserStyleSheetToGroup):
11011 (WebView::removeUserContentFromGroup):
11012 (WebView::removeAllUserContentFromGroup):
11014 Added. Implementation was based on similar methods in WebView.mm.
11016 2009-09-11 Jon Honeycutt <jhoneycutt@apple.com>
11018 Fix crash on launch on Windows.
11020 Rubber-stamped by Mark Rowe.
11022 * WebKit.vcproj/WebKit.vcproj:
11023 Define ENABLE_WEB_SOCKETS for all configurations.
11025 2009-09-07 Drew Wilson <atwilson@google.com>
11027 Reviewed by David Levin.
11029 Enable SHARED_WORKERS by default.
11030 https://bugs.webkit.org/show_bug.cgi?id=28959
11032 * WebKit.vcproj/WebKit.vcproj:
11034 2009-09-04 Adam Roben <aroben@apple.com>
11036 Make WebView function without a parent window
11038 When WebView has no parent window, it becomes a message-only window,
11039 which hides it from the screen and prevents it from appearing on the
11042 Fixes <http://webkit.org/b/28971> <rdar://problem/4976998>
11043 WebView::initWithFrame fails if there's no host window
11045 Reviewed by Dave Hyatt.
11048 (WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as
11049 our parent window, which will make us a message-only window.
11050 (WebView::setHostWindow): If he new host window is null, use
11051 HWND_MESSAGE as our parent window, which will make us a message-only
11054 2009-09-04 Adam Barth <abarth@webkit.org>
11056 Unreviewed attempt at a build fix.
11058 Added missing include.
11060 * WebCoreSupport/WebFrameLoaderClient.cpp:
11062 2009-09-04 Adam Barth <abarth@webkit.org>
11064 Unreviewed attempt at a build fix.
11066 Fix typo of IWebFrameLoadDelegatePrivate2 and make
11067 IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate
11068 as requestd by Adam Roben.
11070 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
11071 * WebCoreSupport/WebFrameLoaderClient.cpp:
11072 (WebFrameLoaderClient::didDisplayInsecureContent):
11073 (WebFrameLoaderClient::didRunInsecureContent):
11075 2009-09-04 Adam Barth <abarth@webkit.org>
11077 Reviewed by Eric Seidel.
11079 https://bugs.webkit.org/show_bug.cgi?id=24696
11081 Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.
11083 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
11084 * Interfaces/WebKit.idl:
11085 * WebCoreSupport/WebFrameLoaderClient.cpp:
11086 (WebFrameLoaderClient::didDisplayInsecureContent):
11087 (WebFrameLoaderClient::didRunInsecureContent):
11088 * WebKit.vcproj/Interfaces.vcproj:
11090 2009-09-03 Adam Barth <abarth@webkit.org>
11092 Reviewed by eric@webkit.org.
11094 https://bugs.webkit.org/show_bug.cgi?id=24696
11096 Stub implementations of mixed content methods of FrameLoaderClient.
11098 * WebCoreSupport/WebFrameLoaderClient.cpp:
11099 (WebFrameLoaderClient::didDisplayInsecureContent):
11100 (WebFrameLoaderClient::didRunInsecureContent):
11101 * WebCoreSupport/WebFrameLoaderClient.h:
11103 2009-09-01 Adam Roben <aroben@apple.com>
11105 Post a notification when a WebView is closing
11107 This is useful for situations where some code wants to react to the
11108 WebView closing but isn't in charge of the WebView and can't otherwise
11109 be notified. This notification could replace
11110 IWebUIDelegatePrivate::webViewClosing if we decide that the
11111 notification system isn't too burdensome.
11113 <http://webkit.org/b/28875>
11115 Reviewed by John Sullivan.
11117 * Interfaces/IWebViewPrivate.idl: Added the
11118 WebViewWillCloseNotification string constant.
11119 * WebKit.vcproj/WebKit.vcproj: Link against comsuppw.lib in all
11120 configurations so that we can use _bstr_t.
11122 (WebView::close): Post the WebViewWillCloseNotification.
11124 2009-08-31 Alexey Proskuryakov <ap@webkit.org>
11126 Reviewed by Darin Adler.
11128 https://bugs.webkit.org/show_bug.cgi?id=28852
11129 Rename KURL single argument constructor to avoid confusion
11131 * WebURLResponse.cpp: (WebURLResponse::createInstance): Adapt to the change.
11133 2009-08-20 Adam Roben <aroben@apple.com>
11135 Give WebKit clients access to the window features specified in
11138 Reviewed by Steve Falkenburg.
11140 * COMVariantSetter.h: Added COMVariantSetters for bool and float.
11142 * Interfaces/IWebUIDelegatePrivate.idl: Added IWebUIDelegatePrivate2,
11143 which contains a new version of createWebViewWithRequest that also
11144 passes the window features as an IPropertyBag. This is analagous to
11145 the -createWebViewWithRequest:windowFeatures: method added to
11146 WebUIDelegate on Mac in r27452. Also added key strings for use with
11147 the window features property bag.
11149 * WebCoreSupport/WebChromeClient.cpp:
11150 (createWindowFeaturesPropertyBag): Added this helper function to turn
11151 a WebCore::WindowFeatures into an IPropertyBag for passing to WebKit
11153 (WebChromeClient::createWindow): If the UI delegate implements
11154 IWebUIDelegatePrivate2, call the new createWebViewWithRequest function
11155 that takes a window features property bag. If the delegate doesn't
11156 implement the new function, fall back to the old functions.
11158 2009-08-20 Adam Roben <aroben@apple.com>
11160 A little clean-up in WebChromeClient::createWindow
11162 Reviewed by Steve Falkenburg.
11164 * WebCoreSupport/WebChromeClient.cpp:
11165 (WebChromeClient::createWindow): Refactored to share more code between
11166 the dialog and non-dialog cases.
11168 2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
11170 Reviewed by Holger Freyther.
11172 https://bugs.webkit.org/show_bug.cgi?id=25889
11173 [GTK] scrollbar policy for main frame is not implementable
11175 Add empty implementation for new ChromeClient method.
11177 * WebCoreSupport/WebChromeClient.h:
11178 (WebChromeClient::scrollbarsModeDidChange):
11180 2009-08-27 Brent Fulgham <bfulgham@webkit.org>
11182 Reviewed by Adam Roben.
11184 Modify Release_Cairo target to build testapi using the
11185 Release_CFLite target so that the correct CoreFoundation
11186 (in this case, CFLite.dll) is linked.
11188 * WebKit.vcproj/WebKit.sln:
11190 2009-08-26 Adam Barth <abarth@webkit.org>
11192 Reviewed by Oliver Hunt.
11194 Don't let local files access web URLs
11195 https://bugs.webkit.org/show_bug.cgi?id=28480
11197 * WebPreferences.cpp:
11198 (WebPreferences::initializeDefaultSettings):
11200 2009-08-26 David Levin <levin@chromium.org>
11202 Reviewed by Darin Fisher.
11204 ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
11205 https://bugs.webkit.org/show_bug.cgi?id=28735
11207 * WebMutableURLRequest.cpp:
11208 (WebMutableURLRequest::setHTTPShouldHandleCookies):
11210 2009-08-25 Eric Carlson <eric.carlson@apple.com>
11212 Reviewed by Oliver Hunt.
11214 <video> and <audio> controller should be accessible
11215 https://bugs.webkit.org/show_bug.cgi?id=28081
11217 * WebCoreLocalizedStrings.cpp:
11218 (WebCore::localizedMediaControlElementString):
11219 (WebCore::localizedMediaControlElementHelpText):
11220 (WebCore::localizedMediaTimeDescription):
11223 2009-08-25 Brent Fulgham <bfulgham@webkit.org>
11225 Build fix for Windows.
11227 Revise Debug_Cairo build target to build testapi, jsc, WinLauncher,
11228 DumpRenderTree, and TestNetscapeAPI using WinCairo debug build
11229 settings so they link against the proper libraries.
11231 * WebKit.vcproj/WebKit.sln:
11233 2009-08-25 David Levin <levin@chromium.org>
11235 Reviewed by Adam Roben.
11237 PLATFORM(CFNETWORK) should be USE(CFNETWORK).
11238 https://bugs.webkit.org/show_bug.cgi?id=28713
11240 Also, moved the #if header section after the other #includes.
11243 (WebError::localizedDescription):
11245 2009-08-24 Brent Fulgham <bfulgham@webkit.org>
11247 Reviewed by Steve Falkenburg.
11249 Revise CFLite Debug build to emit DLL's with _debug label.
11250 https://bugs.webkit.org/show_bug.cgi?id=28695.
11252 * WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to
11253 inherit from new debug_wincairo property sheet, instead of
11254 the current debug sheet.
11256 2009-08-22 Adam Barth <abarth@webkit.org>
11258 Revert 47684. We're going to do this later once clients have had a
11259 chance to opt into the setting they like.
11261 * WebPreferences.cpp:
11262 (WebPreferences::initializeDefaultSettings):
11264 2009-08-22 Adam Barth <abarth@webkit.org>
11266 Reviewed by Eric Seidel.
11268 Don't let local files access web URLs
11269 https://bugs.webkit.org/show_bug.cgi?id=28480
11271 * WebPreferences.cpp:
11272 (WebPreferences::initializeDefaultSettings):
11274 2009-08-20 Brian Weinstein <bweinstein@apple.com>
11276 Reviewed by Adam Roben.
11278 Fix of <http://webkit.org/b/27850>. Panning by emulating Mouse Wheel Events breaks Google Maps.
11280 Switched to using RenderLayer::scrollByRecursively instead of emulating a mouse wheel,
11281 and switched to handling the hit testing in WebView from doing it as part of the mouse wheel event.
11282 One downside of this fix is that panning will not jump out of frames anymore (same behavior as pan-scrolling), but
11283 this is tracked in <http://webkit.org/b/28237>.
11286 (WebView::gestureNotify): Added hit testing here to figure out the node the user started the gesture on.
11287 (WebView::gesture): Switched from emulating mouse wheel events for panning to calling RenderLayer::scrollByRecursively.
11290 2009-08-18 Brian Weinstein <bweinstein@apple.com>
11292 Reviewed by Oliver Hunt.
11294 Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
11295 LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
11297 Added a setQuota interface method to IWebDatabaseManager and implemented it.
11299 * Interfaces/IWebDatabaseManager.idl:
11300 * WebDatabaseManager.cpp:
11301 (WebDatabaseManager::setQuota):
11302 * WebDatabaseManager.h:
11304 2009-08-18 Drew Wilson <atwilson@google.com>
11306 Unreviewed (build break).
11308 Added missing include for WebWorkersPrivate.h.
11310 * WebKitClassFactory.cpp:
11312 2009-08-18 Peter Kasting <pkasting@google.com>
11314 Reviewed by Eric Seidel.
11316 https://bugs.webkit.org/show_bug.cgi?id=28415
11317 Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
11320 * WebKit.vcproj/InterfacesGenerated.vcproj:
11322 2009-08-18 Drew Wilson <atwilson@google.com>
11324 Reviewed by Eric Seidel.
11326 Need to extend DumpRenderTree to expose number of worker threads
11327 https://bugs.webkit.org/show_bug.cgi?id=28292
11329 Defined/implemented COM interfaces to expose WorkerThread::workerThreadCount() for DumpRenderTree.
11331 * ForEachCoClass.h:
11332 Added WebWorkersPrivate.
11333 * Interfaces/IWebWorkersPrivate.idl: Added.
11334 * Interfaces/WebKit.idl:
11335 Added WebWorkersPrivate.
11336 * WebKit.vcproj/Interfaces.vcproj:
11337 * WebKit.vcproj/WebKit.vcproj:
11338 * WebWorkersPrivate.cpp: Added.
11339 Implementation of the IWebWorkersPrivate COM interface, to expose workerThreadCount() for DumpRenderTree.
11340 (WebWorkersPrivate::QueryInterface):
11341 (WebWorkersPrivate::AddRef):
11342 (WebWorkersPrivate::Release):
11343 (WebWorkersPrivate::workerThreadCount):
11344 (WebWorkersPrivate::createInstance):
11345 (WebWorkersPrivate::WebWorkersPrivate):
11346 (WebWorkersPrivate::~WebWorkersPrivate):
11347 * WebWorkersPrivate.h: Added.
11349 2009-08-17 Peter Kasting <pkasting@google.com>
11351 Reviewed by Steve Falkenburg.
11353 https://bugs.webkit.org/show_bug.cgi?id=27323
11354 Only add Cygwin to the path when it isn't already there. This avoids
11355 causing problems for people who purposefully have non-Cygwin versions of
11356 executables like svn in front of the Cygwin ones in their paths.
11358 * WebKit.vcproj/Interfaces.vcproj:
11359 * WebKit.vcproj/InterfacesGenerated.vcproj:
11360 * WebKit.vcproj/WebKit.vcproj:
11361 * WebKit.vcproj/WebKitGUID.vcproj:
11363 2009-08-17 Simon Fraser <simon.fraser@apple.com>
11365 Speculative fix for Windows build bustage.
11367 * DOMHTMLClasses.cpp:
11368 (DOMHTMLElement::idName):
11370 2009-08-13 Jon Honeycutt <jhoneycutt@apple.com>
11372 Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
11375 https://bugs.webkit.org/show_bug.cgi?id=20866
11377 Reviewed by Oliver Hunt.
11379 * AccessibleBase.cpp:
11380 (AccessibleBase::getAccessibilityObjectForChild):
11381 If the child ID is negative, negate it and treat it as an AXID.
11383 2009-08-12 Brian Weinstein <bweinstein@apple.com>
11385 Reviewed by Adam Roben.
11387 Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
11388 list detaches drop down.
11390 Added a check in mouseWheel to see if our focus is currently in a popup, if so, close
11391 the popup (matches other browser behavior).
11394 (WebView::mouseWheel):
11396 2009-08-12 Adam Roben <aroben@apple.com>
11398 Make WebPreferenceKeysPrivate.h available for client use
11400 Reviewed by Dave Hyatt.
11402 Fixes <http://webkit.org/b/28227>.
11404 * WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to
11405 $WebKitOutputDir, just like we do for a few other headers. Also let VS
11406 reorder some XML attributes.
11408 * WebPreferenceKeysPrivate.h: Touched this file to force a build.
11410 2009-08-11 Adam Roben <aroben@apple.com>
11412 Remove support for a window resizer within the WebView
11414 Starting with Safari 4, there is never a window resizer inside the
11415 WebView, so we no longer need to support that functionality.
11417 Fixes <http://webkit.org/b/28190> Remove support for a window resizer
11420 Reviewed by Dave Hyatt.
11422 * Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate
11423 functions related to the window resizer with unused*() functions. We
11424 can't remove them entirely because we need to keep the vtable
11425 unchanged so new versions of WebKit will work with old versions of
11426 Safari (e.g., for nightlies and WebKit development).
11428 * WebCoreSupport/WebChromeClient.cpp:
11429 (WebChromeClient::windowResizerRect): Now always returns an empty
11434 (WebView::handleMouseEvent):
11436 Removed window-resizer-related code.
11438 2009-08-11 John Gregg <johnnyg@google.com>
11440 Reviewed by Maciej Stachowiak.
11442 Move the accessor for notifications presenter from WebUIDelegate
11443 to WebUIDelegate2 which extends it. When making this call from
11444 WebCoreSupport, check using QueryInterface before calling.
11446 https://bugs.webkit.org/show_bug.cgi?id=28198
11448 * Interfaces/IWebUIDelegate.idl:
11449 * Interfaces/IWebUIDelegate2.idl: Added.
11450 * Interfaces/WebKit.idl:
11451 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
11452 (WebDesktopNotificationsDelegate::show):
11453 (WebDesktopNotificationsDelegate::cancel):
11454 (WebDesktopNotificationsDelegate::notificationObjectDestroyed):
11455 (WebDesktopNotificationsDelegate::requestPermission):
11456 (WebDesktopNotificationsDelegate::checkPermission):
11457 (WebDesktopNotificationsDelegate::hasNotificationDelegate):
11458 (WebDesktopNotificationsDelegate::notificationDelegate):
11459 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
11461 2009-08-11 Drew Wilson <atwilson@google.com>
11463 Reviewed by NOBODY (build break).
11465 Speculative Windows build fix - undo previous unnecessary change.
11467 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
11469 2009-08-11 Brian Weinstein <bweinstein@apple.com>
11471 Reviewed by Steve Falkenburg.
11473 Refactored MIMETypeforExtension to be a member of IWebViewPrivate
11474 instead of IWebView.
11476 * Interfaces/IWebView.idl:
11477 * Interfaces/IWebViewPrivate.idl:
11479 (WebView::MIMETypeForExtension):
11482 2009-08-11 Drew Wilson <atwilson@google.com>
11484 Reviewed by NOBODY (build break)
11486 Speculative fix for windows build break.
11488 * WebKitSupport/WebDesktopNotificationsDelegate.h:
11489 WebCore/Notification*.h => WebCore/notifications/Notification*.h
11491 2009-08-11 John Gregg <johnnyg@google.com>
11493 Reviewed by Maciej Stachowiak.
11495 Desktop Notifications API
11496 https://bugs.webkit.org/show_bug.cgi?id=25643
11498 Adds test hooks for notification features to WebCoreSupport for
11499 use in DumpRenderTree.
11501 * Interfaces/IWebDesktopNotificationsDelegate.idl: Added.
11502 * Interfaces/IWebUIDelegate.idl:
11503 * Interfaces/WebKit.idl:
11504 * WebCoreSupport/WebChromeClient.cpp:
11505 (WebChromeClient::WebChromeClient):
11506 * WebCoreSupport/WebChromeClient.h:
11507 (WebChromeClient::notificationPresenter):
11508 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added.
11509 (NotificationCOMWrapper::create):
11510 (NotificationCOMWrapper::NotificationCOMWrapper):
11511 (NotificationCOMWrapper::QueryInterface):
11512 (NotificationCOMWrapper::AddRef):
11513 (NotificationCOMWrapper::Release):
11514 (NotificationCOMWrapper::isHTML):
11515 (NotificationCOMWrapper::contentsURL):
11516 (NotificationCOMWrapper::iconURL):
11517 (NotificationCOMWrapper::title):
11518 (NotificationCOMWrapper::text):
11519 (NotificationCOMWrapper::notifyDisplay):
11520 (NotificationCOMWrapper::notifyError):
11521 (NotificationCOMWrapper::notifyClose):
11522 (WebDesktopNotificationsDelegate::WebDesktopNotificationsDelegate):
11523 (WebDesktopNotificationsDelegate::show):
11524 (WebDesktopNotificationsDelegate::cancel):
11525 (WebDesktopNotificationsDelegate::notificationObjectDestroyed):
11526 (WebDesktopNotificationsDelegate::requestPermission):
11527 (WebDesktopNotificationsDelegate::checkPermission):
11528 (WebDesktopNotificationsDelegate::notificationDelegate):
11529 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added.
11530 * WebCoreSupport/WebInspectorDelegate.h:
11531 (WebInspectorDelegate::desktopNotificationsDelegate):
11532 * WebKit.vcproj/Interfaces.vcproj:
11533 * WebKit.vcproj/WebKit.vcproj:
11535 2009-08-11 Brian Weinstein <bweinstein@apple.com>
11537 Reviewed by Adam Roben.
11539 Fix of <rdar://5016504> SVG file cannot be dragged to webview,
11540 but can be opened via Open File.
11542 Added a new function to IWebView that gets the MIME type for a given
11543 extension from the MIMETypeRegistry.
11545 * Interfaces/IWebView.idl:
11547 (WebView::MIMETypeForExtension):
11550 2009-08-11 Dmitry Titov <dimich@chromium.org>
11552 Reviewed by Adam Roben.
11554 Originally implemented by Glenn Wilson <gwilson@chromium.org>.
11556 Added support for overriding default preferences per-test.
11557 See https://bugs.webkit.org/show_bug.cgi?id=20534
11559 * Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
11560 * WebPreferences.cpp: same.
11561 * WebPreferences.h: same.
11563 2009-08-10 Dan Bernstein <mitz@apple.com>
11565 Reviewed by Darin Adler.
11567 Link drag images specify Lucida Grande on Windows and end up using Times
11569 <rdar://problem/7117835>
11571 * WebCoreSupport/WebDragClient.cpp:
11572 (dragLabelFont): Added a RenderingMode parameter and changed to use the
11573 same typeface as the Windows small caption font.
11574 (WebDragClient::createDragImageForLink): Changed to respect the
11575 page’s rendering mode.
11577 2009-08-10 Brent Fulgham <bfulgham@webkit.org>
11579 Reviewed by Adam Roben.
11581 https://bugs.webkit.org/show_bug.cgi?id=28048.
11582 Move various WinCairo build settings into *.vsprops file.
11584 * WebKit.vcproj/WebKit.vcproj: Add new cURL.vsprops property sheet
11585 (which contains link settings for cURL and its dependencies), and
11586 remove the corresponding entries from the vcproj file. Remove
11587 png, jpeg, cairo library linking flags from vcproj, now that they
11588 are in the WinCairo.vsprops file.
11590 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
11592 Reviewed by George Staikos.
11594 [WML] Deck access control is completly broken
11595 https://bugs.webkit.org/show_bug.cgi?id=27721
11597 Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.
11599 * Interfaces/IWebFramePrivate.idl:
11601 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
11603 Reviewed by Maciej Stachowiak.
11605 FrameLoadType / WebFrameLoadType enums are out of sync
11606 https://bugs.webkit.org/show_bug.cgi?id=28132
11608 Synchronize FrameLoadType <-> WebFrameLoadType enums (append missing 'WebFrameLoadTypeReloadFromOrigin' value)
11610 * Interfaces/IWebFramePrivate.idl:
11612 2009-08-06 Adam Barth <abarth@webkit.org>
11616 http://bugs.webkit.org/show_bug.cgi?id=27879
11618 Revert 46877 because it broke GTK.
11620 * COMPropertyBag.h:
11622 2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
11624 Reviewed by Adam Barth.
11626 Change Noncopyable inheriting to public
11627 http://bugs.webkit.org/show_bug.cgi?id=27879
11629 Since Noncopyable is inherited from FastAllocBase,
11630 Noncopyable's inheriting has been changed to public.
11632 * COMPropertyBag.h:
11634 2009-08-04 Alice Liu <alice.liu@apple.com>
11636 "Shift + Enter" should behave like "Enter" in editable fields.
11637 Affects backward search in find-in-page in Safari for Windows
11639 Reviewed by Jon Honeycutt.
11642 Register shift+enter as InsertNewline command, similar to other
11643 modifier+Enter combinations.
11645 2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>
11647 Part of <rdar://problem/5698113> Safari shouldn't auto-activate
11648 plug-ins in background tabs (make Win consistent with Mac)
11650 https://bugs.webkit.org/show_bug.cgi?id=27855
11652 Reviewed by Adam Roben and Anders Carlsson.
11654 * Interfaces/IWebViewPrivate.idl:
11655 Add setCanStartPlugins().
11657 * WebCoreSupport/WebFrameLoaderClient.cpp:
11658 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
11659 Added; code moved from createPlugin(). Modified to obtain the plug-in's
11660 page URL, the plug-ins "plug-ins page" parameter value, and the
11661 plug-in's MIME type by calling getter functions on the passed
11663 (WebFrameLoaderClient::createPlugin):
11664 If the plug-in status is not "success," call
11665 dispatchDidFailToStartPlugin().
11667 * WebCoreSupport/WebFrameLoaderClient.h:
11668 Declare an override of dispatchDidFailToStartPlugin().
11672 Add a missing ) to a comment.
11673 (WebView::setCanStartPlugins):
11674 Call the Page's setCanStartPlugins() function.
11678 2009-07-30 Darin Adler <darin@apple.com>
11680 Reviewed by David Levin.
11682 Use checked casts for render tree
11683 https://bugs.webkit.org/show_bug.cgi?id=23522
11685 * DOMHTMLClasses.cpp:
11686 (DOMHTMLInputElement::isUserEdited):
11687 (DOMHTMLTextAreaElement::isUserEdited):
11690 2009-07-31 Anders Carlsson <andersca@apple.com>
11692 Reviewed by Dan Bernstein.
11694 -Fix <rdar://problem/7104097>
11696 Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.
11698 * WebCoreSupport/EmbeddedWidget.cpp:
11699 (EmbeddedWidget::create):
11700 * WebCoreSupport/EmbeddedWidget.h:
11702 2009-07-29 Brian Weinstein <bweinstein@apple.com>
11704 Was doing the build fix wrong, NotImplemented.h is in WebCore.
11706 * WebCoreSupport/WebInspectorClient.cpp:
11708 2009-07-29 Brian Weinstein <bweinstein@apple.com>
11712 * WebCoreSupport/WebInspectorClient.cpp:
11714 2009-07-29 Kevin McCullough <kmccullough@apple.com>
11716 Reviewed by Darin Adler.
11718 Added foundation work to allow a testing infrastructure for the Web
11721 * WebCoreSupport/WebInspectorClient.cpp:
11722 (WebInspectorClient::inspectorWindowObjectCleared): Empty definition
11723 to let Windows compile but we should implement this at some point so
11724 that the tests can be run on Windows too.
11725 * WebCoreSupport/WebInspectorClient.h:
11727 2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
11729 Reviewed by Steve Falkenburg.
11731 Add output directory for VS pre-build steps to enable out-of-tree builds
11733 https://bugs.webkit.org/show_bug.cgi?id=27700
11735 The tmp.obj file is now placed in the intermediate build directory.
11737 * WebKit.vcproj/WebKit.vcproj:
11739 2009-07-27 Brian Weinstein <bweinstein@apple.com>
11741 Build fix for Windows.
11744 (WebView::stringByEvaluatingJavaScriptFromString):
11746 2009-07-27 Alexey Proskuryakov <ap@webkit.org>
11748 Reviewed by Darin Adler.
11750 https://bugs.webkit.org/show_bug.cgi?id=27735
11751 Give a helpful name to JSLock constructor argument
11753 * WebCoreStatistics.cpp:
11754 (WebCoreStatistics::javaScriptObjectsCount):
11755 (WebCoreStatistics::javaScriptGlobalObjectsCount):
11756 (WebCoreStatistics::javaScriptProtectedObjectsCount):
11757 (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
11758 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
11759 * WebJavaScriptCollector.cpp:
11760 (WebJavaScriptCollector::objectCount):
11762 (WebView::stringByEvaluatingJavaScriptFromString):
11764 2009-07-25 Kwang Yul Seo <skyul@company100.net>
11766 Reviewed by Darin Adler.
11768 Windows build break due to warning C4819
11769 https://bugs.webkit.org/show_bug.cgi?id=27416
11771 Disable C4819 warning to fix build.
11773 * WebKit.vcproj/WebKit.vcproj:
11775 2009-07-24 Brent Fulgham <bfulgham@webkit.org>
11777 Reviewed by Dave Hyatt.
11779 Clean up dependencies on Apple support libraries for non-Apple build.
11780 http://bugs.webkit.org/show_bug.cgi?id=27532.
11782 * DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
11783 * WebDownload.h: Conditionalize include of CFNetwork.h
11784 * WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
11786 2009-07-24 Andrei Popescu <andreip@google.com>
11788 Reviewed by Anders Carlsson.
11790 ApplicationCache should have size limit
11791 https://bugs.webkit.org/show_bug.cgi?id=22700
11793 * WebCoreSupport/WebChromeClient.cpp:
11794 (WebChromeClient::reachedMaxAppCacheSize):
11795 Adds empty implementation of the reachedMaxAppCacheSize callback.
11796 * WebCoreSupport/WebChromeClient.h:
11798 2009-07-23 Brady Eidson <beidson@apple.com>
11800 Reviewed by Geoff Garen.
11802 WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest.
11803 https://bugs.webkit.org/show_bug.cgi?id=27595
11805 * WebCoreSupport/WebFrameLoaderClient.cpp:
11806 (WebFrameLoaderClient::dispatchWillSendRequest):
11808 2009-07-22 Takeshi Yoshino <tyoshino@google.com>
11810 Reviewed by Darin Adler.
11812 VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
11813 https://bugs.webkit.org/show_bug.cgi?id=26375
11815 Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
11816 with hex escape sequences.
11818 VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
11819 treated as an error and stopped build).
11821 WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
11822 represented in the current code page (932). Save the file in Unicode format to prevent data loss
11824 A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
11825 localized string generation process.
11827 * WebCoreLocalizedStrings.cpp:
11828 (WebCore::imageTitle):
11830 2009-07-21 Roland Steiner <rolandsteiner@google.com>
11832 Reviewed by David Levin.
11834 Add ENABLE_RUBY to list of build options
11835 https://bugs.webkit.org/show_bug.cgi?id=27324
11837 * WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.
11839 2009-07-20 Peter Kasting <pkasting@google.com>
11841 Reviewed by Mark Rowe.
11843 https://bugs.webkit.org/show_bug.cgi?id=27468
11844 Back out r46060, which caused problems for some Apple developers.
11846 * WebKit.vcproj/Interfaces.vcproj:
11847 * WebKit.vcproj/InterfacesGenerated.vcproj:
11848 * WebKit.vcproj/WebKit.vcproj:
11849 * WebKit.vcproj/WebKitGUID.vcproj:
11851 2009-07-17 Brian Weinstein <bweinstein@apple.com>
11853 Reviewed by Adam Roben.
11855 Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
11856 https://bugs.webkit.org/show_bug.cgi?id=14272
11858 Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight
11859 to set window sizes and redraw the inspector and the inspected web view, and used stored preferences
11860 in InspectorController.cpp to remember user's preferred height.
11862 * WebCoreSupport/WebInspectorClient.cpp:
11864 2009-07-17 Peter Kasting <pkasting@google.com>
11866 Reviewed by Steve Falkenburg.
11868 https://bugs.webkit.org/show_bug.cgi?id=27323
11869 Only add Cygwin to the path when it isn't already there. This avoids
11870 causing problems for people who purposefully have non-Cygwin versions of
11871 executables like svn in front of the Cygwin ones in their paths.
11873 * WebKit.vcproj/Interfaces.vcproj:
11874 * WebKit.vcproj/InterfacesGenerated.vcproj:
11875 * WebKit.vcproj/WebKit.vcproj:
11876 * WebKit.vcproj/WebKitGUID.vcproj:
11878 2009-07-16 Fumitoshi Ukai <ukai@chromium.org>
11880 Reviewed by David Levin.
11882 Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
11883 https://bugs.webkit.org/show_bug.cgi?id=27206
11885 Add ENABLE_WEB_SOCKETS
11887 * WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS
11889 2009-07-16 Xiaomei Ji <xji@chromium.org>
11891 Reviewed by Darin Adler.
11893 Fix tooltip does not get its directionality from its element's directionality.
11894 https://bugs.webkit.org/show_bug.cgi?id=24187
11896 Per mitz's suggestion in comment #6, while getting the plain-text
11897 title, we also get the directionality of the title. How to handle
11898 the directionality is up to clients. Clients could ignore it,
11899 or use attribute or unicode control characters to display the title
11902 * WebCoreSupport/WebChromeClient.cpp:
11903 (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
11904 * WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
11905 * WebElementPropertyBag.cpp:
11906 (WebElementPropertyBag::Read): Change call of spellingToolTip() and title() due to signature change.
11908 2009-07-15 Darin Adler <darin@apple.com>
11910 Reviewed by Sam Weinig.
11912 Renamed parseURL to deprecatedParseURL.
11914 * WebCoreSupport/WebFrameLoaderClient.cpp:
11915 (WebFrameLoaderClient::createPlugin): Renamed.
11917 2009-07-14 Steve Falkenburg <sfalken@apple.com>
11919 Reorganize JavaScriptCore headers into:
11920 API: include/JavaScriptCore/
11921 Private: include/private/JavaScriptCore/
11923 Reviewed by Darin Adler.
11925 * WebKit.vcproj/WebKit.vcproj:
11927 2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
11929 Reviewed by Darin Adler.
11931 Change all Noncopyable inheriting visibility to public.
11932 https://bugs.webkit.org/show_bug.cgi?id=27225
11934 Change all Noncopyable inheriting visibility to public because
11935 it is needed to the custom allocation framework (bug #20422).
11937 * COMEnumVariant.h:
11938 * WebDatabaseManager.cpp:
11940 * WebLocalizableStrings.cpp:
11942 2009-07-13 Brent Fulgham <bfulgham@webkit.org>
11944 Reviewed by Adam Roben.
11946 Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
11947 https://bugs.webkit.org/show_bug.cgi?id=27240.
11950 (WebFrame::printHeader): New shared method to print the header.
11951 (WebFrame::printFooter): New shared method to print the footer.
11952 (WebFrame::spoolPage): New conditionally-compiled method to print
11954 (WebFrame::spoolPages): Revised to call the platform-specific spoolPage
11956 * WebFrame.h: Add new method prototypes.
11958 2009-07-13 Brent Fulgham <bfulgham@webkit.org>
11960 Reviewed by Adam Roben.
11962 Add new configuration flag for redistributable Windows build.
11963 https://bugs.webkit.org/show_bug.cgi=27087
11965 * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to
11966 Debug_Cairo and Release_Cairo targets.
11968 2009-07-12 Brent Fulgham <bfulgham@gmail.com>
11970 Speculative Windows build fix after http://trac.webkit.org/changeset/45786.
11972 * WebCoreSupport/WebChromeClient.cpp:
11973 (WebChromeClient::addMessageToConsole):
11975 2009-07-10 Adam Barth <abarth@webkit.org>
11977 Reviewed by Sam Weinig with the power of Grayskull.
11979 Enable XSSAuditor by default.
11981 * WebPreferences.cpp:
11982 (WebPreferences::initializeDefaultSettings):
11984 2009-07-09 Drew Wilson <atwilson@google.com>
11986 Reviewed by Alexey Proskuryakov.
11988 https://bugs.webkit.org/show_bug.cgi?id=26903
11990 Turned on CHANNEL_MESSAGING by default because the MessageChannel API
11991 can now be implemented for Web Workers and is reasonably stable.
11993 * WebKit.vcproj/WebKit.vcproj:
11995 2009-07-09 Brian Weinstein <bweinstein@apple.com>
11997 Reviewed by Alice Liu.
11999 Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271)
12000 https://bugs.webkit.org/show_bug.cgi?id=27140
12002 Added a preference key to remember whether the user prefers the inspector detached or attached.
12004 * WebCoreSupport/WebInspectorClient.cpp:
12005 (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible
12006 (WebInspectorClient::closeWindow): Ditto
12007 (WebInspectorClient::attachWindow): Set preference to attached windows here
12008 (WebInspectorClient::detachWindow): Set preference to detached windows here
12009 (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached
12010 (WebInspectorClient::onClose): Pass both parameters into setWindowVisible
12012 2009-07-09 Alexey Proskuryakov <ap@webkit.org>
12014 Reviewed by Oliver Hunt.
12016 <rdar://problem/6921671> Visit count shouldn't be incremented by redirects.
12018 * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
12019 Do not increase visit count if there is a redirect source. As a result, only pages that were
12020 explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking
12021 a link) will be counted.
12023 * Interfaces/IWebHistoryItemPrivate.idl:
12025 (WebHistory::visitedURL):
12027 * WebHistoryItem.cpp:
12028 (WebHistoryItem::visitedWithTitle):
12029 * WebHistoryItem.h:
12030 Marshal this new argument all the way down to WebCore.
12032 2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>
12034 Reviewed by Dave Hyatt.
12036 Make Widget RefCounted to fix:
12038 <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
12039 at WebCore::Widget::afterMouseDown() after clicking To Do's close
12041 <rdar://problem/6978804> WER #16: Repro Access Violation in
12042 WebCore::PluginView::bindingInstance (1310178023)
12044 <rdar://problem/6991251> WER #13: Crash in WebKit!
12045 WebCore::PluginView::performRequest+203 (1311461169)
12047 * WebCoreSupport/WebFrameLoaderClient.cpp:
12048 (WebFrameLoaderClient::createPlugin):
12049 * WebCoreSupport/WebFrameLoaderClient.h:
12051 (WebFrame::createJavaAppletWidget):
12054 2009-07-09 Sam Weinig <sam@webkit.org>
12056 Reviewed by Steve Falkenburg.
12058 Roll out r43848. The quirk is no longer necessary.
12061 (WebView::userAgentForKURL):
12063 2009-07-07 Ada Chan <adachan@apple.com>
12065 Reviewed by Dave Hyatt.
12067 Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView.
12068 https://bugs.webkit.org/show_bug.cgi?id=27057
12073 2009-07-02 Erik Arvidsson <arv@chromium.org>
12075 Reviewed by Adam Roben.
12077 [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
12078 https://bugs.webkit.org/show_bug.cgi?id=26699
12080 * WebDropSource.cpp:
12081 (WebDropSource::QueryContinueDrag):
12083 2009-07-02 Oliver Hunt <oliver@apple.com>
12085 Reviewed by Anders Carlsson.
12087 <rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670)
12088 <https://bugs.webkit.org/show_bug.cgi?id=26670>
12090 Make windows loader client match mac behaviour more closely.
12092 * WebCoreSupport/WebFrameLoaderClient.cpp:
12093 (WebFrameLoaderClient::forceLayout):
12095 2009-06-30 Brent Fulgham <bfulgham@gmail.com>
12097 Reviewed by Adam Roben.
12099 Build DumpRenderTree under Cairo.
12100 https://bugs.webkit.org/show_bug.cgi?id=26457
12102 * WebKit.vcproj/WebKit.sln: Add Cairo targets to the
12103 DumpRenderTree build, and use the in the Debug_Cairo
12104 and Release_Cairo targets.
12106 2009-07-02 Eric Carlson <eric.carlson@apple.com>
12108 Fix Windows build by including missing localized string methods.
12110 * WebCoreLocalizedStrings.cpp:
12111 (WebCore::mediaElementLoadingStateText):
12112 (WebCore::mediaElementLiveBroadcastStateText):
12114 2009-07-01 David Hyatt <hyatt@apple.com>
12116 Reviewed by Tim Hatcher.
12118 <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
12119 even though the field is not actually focused for keyboard input
12121 Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
12122 focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
12128 2009-06-29 David Hyatt <hyatt@apple.com>
12130 Fix Windows bustage. Missed two configurations for enabling DATAGRID.
12132 * WebKit.vcproj/WebKit.vcproj:
12134 2009-06-29 Jessie Berlin <jberlin@apple.com>
12136 Reviewed by Adam Roben.
12138 Fix the windows build.
12140 * WebCoreSupport/WebContextMenuClient.cpp:
12141 (WebContextMenuClient::isSpeaking):
12142 * WebCoreSupport/WebContextMenuClient.h:
12144 2009-06-29 David Hyatt <hyatt@apple.com>
12146 Reviewed by Adam Roben.
12148 Make sure to patch all configurations to have datagrid enabled.
12150 * WebKit.vcproj/WebKit.vcproj:
12152 2009-06-29 David Hyatt <hyatt@apple.com>
12154 Reviewed by Adam Roben.
12156 Put <datagrid> behind an ifdef.
12158 * WebKit.vcproj/WebKit.vcproj:
12160 2009-06-26 Brian Weinstein <bweinstein@apple.com>
12162 Reviewed by Simon Fraser.
12164 https://bugs.webkit.org/show_bug.cgi?id=26695
12166 Added hit testing on scrollbars, so if you start a gesture over a scrollbar,
12167 it isn't counted, and lets the user drag the scrollbar itself instead of a
12168 panning gesture. Also cleaned up code in gesture.
12171 (WebView::gestureNotify):
12172 (WebView::gesture):
12174 2009-06-26 Jeremy Orlow <jorlow@chromium.org>
12176 Reviewed by Adam Barth.
12178 https://bugs.webkit.org/show_bug.cgi?id=26767
12180 Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp
12181 despite it being deleted from the repo by the following patch/commit:
12182 https://bugs.webkit.org/show_bug.cgi?id=26732
12183 http://trac.webkit.org/changeset/45290
12187 2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
12189 Reviewed by Eric Seidel.
12191 Bug 20303: [Qt] Key events are not working in frames.
12193 Move the scroll handling code to EventHandler so that other
12194 ports can share the functionality.
12197 (WebView::keyDown):
12198 (EnumTextMatches::QueryInterface):
12200 2009-06-23 Anders Carlsson <andersca@apple.com>
12202 Reviewed by Darin Adler.
12204 WebKit side of <rdar://problem/6946094>.
12206 * Interfaces/IWebUIDelegate.idl:
12207 Add a newPasteboard out parameter to willPerformDragSourceAction.
12209 * WebCoreSupport/WebDragClient.cpp:
12210 (WebDragClient::willPerformDragSourceAction):
12211 Implement this. If the client returns a new pasteboard, use it for the drag.
12213 * WebCoreSupport/WebInspectorDelegate.h:
12214 (WebInspectorDelegate::willPerformDragSourceAction):
12215 Add the new parameter.
12217 2009-06-20 Darin Adler <darin@apple.com>
12219 Reviewed by Sam Weinig.
12221 <rdar://problem/6964221> Need more processing of pluginspage.
12223 * WebCoreSupport/WebFrameLoaderClient.cpp:
12224 (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
12226 2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
12228 Reviewed by Steve Falkenburg.
12230 https://bugs.webkit.org/show_bug.cgi?id=26494
12231 Bug 26494: RenderTheme::themeForPage reads from Settings before it has
12232 been initialized by WebKit
12234 Get the shouldPaintNativeControls preference and update the settings
12235 before initializing the page, as the page depends on it after the
12236 themeForPage change.
12239 (WebView::initWithFrame):
12241 2009-06-19 Brian Weinstein <bweinstein@apple.com>
12243 Reviewed by Steve Falkenburg.
12245 https://bugs.webkit.org/show_bug.cgi?id=26488
12246 No Support for Single Finger or Two Finger Panning in Windows 7
12248 Added the code necessary for single finger and two-finger panning with
12249 window bounce. We now register for WM_GESTURENOTIFY and WM_GESTURE messages,
12250 and interpret the panning command. Also, added WindowsTouch.h which contains
12251 structs and #defines from the Windows 7 SDK.
12253 * WebKit.vcproj/WebKit.vcproj:
12255 (WebView::gestureNotify): Checks if we are in a pannable region - IE: Not in the scrollbar
12256 (WebView::gesture): Handles the Panning gesture, creating the WheelEvent
12257 (WebViewWndProc): Added cases for WM_GESTURE and WM_GESTURENOTIFY
12259 * WindowsTouch.h: Added.
12261 2009-06-18 Adam Barth <abarth@webkit.org>
12263 Reviewed by Sam Weinig.
12265 https://bugs.webkit.org/show_bug.cgi?id=26199
12267 Added preference to enable the XSSAuditor.
12269 * Interfaces/IWebPreferencesPrivate.idl:
12270 * WebPreferenceKeysPrivate.h:
12271 * WebPreferences.cpp:
12272 (WebPreferences::initializeDefaultSettings):
12273 (WebPreferences::isXSSAuditorEnabled):
12274 (WebPreferences::setXSSAuditorEnabled):
12275 * WebPreferences.h:
12277 (WebView::notifyPreferencesChanged):
12279 2009-06-18 Brent Fulgham <bfulgham@gmail.com>
12281 Reviewed by Dave Levin.
12283 Remove some boilerplate using the BitmapInfo struct.
12284 https://bugs.webkit.org/show_bug.cgi?id=26425
12287 (WebFrame::spoolPages):
12288 * WebIconDatabase.cpp:
12290 * WebKit.vcproj/WebKit.sln:
12291 * WebNodeHighlight.cpp:
12292 (WebNodeHighlight::update):
12294 (WebView::ensureBackingStore):
12296 2009-06-17 Steve Falkenburg <sfalken@apple.com>
12298 Consolidate WebKit COM interfaces.
12299 Moved IID from the highest numbered COM interface to the first interface and combined all methods.
12301 Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.
12303 Reviewed by Adam Roben.
12305 * Interfaces/IWebFrameLoadDelegate.idl:
12306 * Interfaces/IWebFrameLoadDelegatePrivate.idl:
12307 * Interfaces/IWebResourceLoadDelegatePrivate.idl:
12308 * Interfaces/IWebUIDelegate.idl:
12309 * Interfaces/IWebUIDelegatePrivate.idl:
12310 * Interfaces/WebKit.idl:
12311 * WebCoreSupport/WebChromeClient.cpp:
12312 * WebCoreSupport/WebChromeClient.h:
12313 * WebCoreSupport/WebContextMenuClient.cpp:
12314 * WebCoreSupport/WebFrameLoaderClient.cpp:
12315 * WebCoreSupport/WebInspectorDelegate.h:
12319 2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
12321 Reviewed by Adam Roben.
12323 Create a different RenderTheme per page, so that RenderTheme has
12324 access to page specific theming. This is needed for the Qt port, as Qt
12325 supports setting the theme (style) per widget.
12327 This change was suggested and discussed with Dave Hyatt.
12331 1) Create a theme per page or one global one, depending on the needs
12333 2) Add an accesser to the theme from RenderObject.
12334 3) Change all uses of the theming to access the theme through
12335 RenderObject, using the global default theme as fallback, when the
12336 document of RenderObject has no page.
12337 When we don't have access to a RenderObject, use the default theme.
12338 4) Modify all RenderTheme platform implementations to work with the
12339 above changes, still creating only one global theme.
12342 (WebViewWndProc): Get the theme from the associated page.
12344 2009-06-16 Brian Weinstein <bweinstein@apple.com>
12346 Reviewed by Adam Roben.
12348 Switch Control+Mousewheel Zooming definitions to match other browsers on Windows.
12349 Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in.
12350 https://bugs.webkit.org/show_bug.cgi?id=25875.
12351 <rdar://problem/6903976>
12354 (WebView::mouseWheel):
12356 2009-06-16 Brent Fulgham <bfulgham@gmail.com>
12358 Reviewed by Darin Adler.
12360 Use consistent Windows GUID Comparison Functions.
12361 https://bugs.webkit.org/show_bug.cgi?id=26427.
12364 (EnumTextMatches::QueryInterface):
12366 == Rolled over to ChangeLog-2009-06-16 ==