1 2012-07-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3 [Mac] Fix build break on Apple win bot after r123711
4 https://bugs.webkit.org/show_bug.cgi?id=92354
6 Reviewed by Adam Barth.
11 (WebFrame::pageNumberForElementById):
13 2012-07-26 Kaustubh Atrawalkar <kaustubh@motorola.com>
15 [DRT] LTC:: pageNumberForElementById() could be moved to Internals
16 https://bugs.webkit.org/show_bug.cgi?id=92091
18 Reviewed by Adam Barth.
20 Moved the pageNumberForElementById from LayoutTestCotroller to Internals and
21 remove the old platform specific implementations as it exclusively tests WebCore functionality.
23 * WebFrame.cpp: Added comment for removing the function. Removed implementation.
25 2012-07-25 Roger Fong <roger_fong@apple.com>
27 Changes to the WebFrame API cause dependent apps to crash.
28 https://bugs.webkit.org/show_bug.cgi?id=91656
29 <rdar://problem/11904605>
31 Reviewed by Jon Honeycutt.
33 Changes to the WebFrame API cause certain apps to crash because of inconsistencies in the COM interface.
34 The resumeAnimations and suspendAnimations are removed, which are still needed.
35 The counterValueByElementId method was also removed, although is not needed there.
36 However, for all of these methods, no method stubs were added where appropriate after removal.
38 * Interfaces/IWebFramePrivate.idl:
39 Added resumeAnimations() and suspendAnimations() methods back in. Added unused method stub for counterValueByElementId method.
42 (WebFrame::resumeAnimations):
43 Added this method back in.
44 (WebFrame::suspendAnimations):
45 Added this method back in.
48 (Re)added methods and unused method stubs.
50 2012-07-23 Patrick Gansterer <paroga@webkit.org>
52 Build fix if NOMINMAX is defined by the build system.
54 * COMEnumVariant.h: Added #ifndef NOMINMAX around #define NOMINMAX.
55 * COMPropertyBag.h: Ditto.
57 2012-07-23 Pierre Rossi <pierre.rossi@gmail.com>
59 Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
60 https://bugs.webkit.org/show_bug.cgi?id=91006
62 Reviewed by Ryosuke Niwa.
64 Remove numTouchEventHandlersChanged stub.
66 * WebCoreSupport/WebChromeClient.h:
68 2012-07-17 Vivek Galatage <vivekgalatage@gmail.com>
70 Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
71 https://bugs.webkit.org/show_bug.cgi?id=91196
73 Reviewed by Pavel Feldman.
75 Refactoring InspectorClients. InspectorClient::openInspectorFrontend
76 now returning the InspectorFrontendChannel.
78 * WebCoreSupport/WebInspectorClient.cpp:
79 (WebInspectorClient::openInspectorFrontend):
80 * WebCoreSupport/WebInspectorClient.h:
83 2012-07-14 Eric Carlson <eric.carlson@apple.com>
85 Enable AVCF hardware video decoding
86 https://bugs.webkit.org/show_bug.cgi?id=90015
87 <rdar://problem/10770317>
89 Reviewed by Anders Carlsson.
91 * WebCoreSupport/WebChromeClient.cpp:
92 (WebChromeClient::graphicsDeviceAdapter): New, return the view's graphics adapter.
93 * WebCoreSupport/WebChromeClient.h:
97 (WebView::graphicsDeviceAdapter): New, return the layer tree host's graphics adapter.
102 2012-07-10 Adam Barth <abarth@webkit.org>
104 WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed
105 https://bugs.webkit.org/show_bug.cgi?id=90910
107 Reviewed by Eric Seidel.
109 * WebPreferences.cpp:
110 (WebPreferences::initializeDefaultSettings):
111 (WebPreferences::setHixie76WebSocketProtocolEnabled):
112 (WebPreferences::hixie76WebSocketProtocolEnabled):
114 (WebView::notifyPreferencesChanged):
116 2012-07-02 Ryosuke Niwa <rniwa@webkit.org>
118 Make HTMLCollection RefCounted
119 https://bugs.webkit.org/show_bug.cgi?id=90414
121 Reviewed by Sam Weinig.
123 * DOMHTMLClasses.cpp:
124 (DOMHTMLDocument::forms):
125 (DOMHTMLSelectElement::options):
127 2012-07-03 Mihai Balan <mibalan@adobe.com>
129 [CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
130 https://bugs.webkit.org/show_bug.cgi?id=90435
132 Reviewed by Csaba Osztrogonác.
134 Initial patch for enabling regions led to WebKit crashing on launch. Moving the
135 IDL declarations for CSS regions getter/setter at the end of the file solves the
136 problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
137 binary compatibility.
139 * Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file
141 2012-07-02 Benjamin Poulain <bpoulain@apple.com>
143 Do not do any logging initialization when logging is disabled
144 https://bugs.webkit.org/show_bug.cgi?id=90228
146 Reviewed by Simon Fraser.
149 (WebView::initWithFrame):
151 2012-06-29 Mihai Balan <mibalan@adobe.com>
153 [CSS Regions] Adding feature defines for CSS Regions for Windows
154 https://bugs.webkit.org/show_bug.cgi?id=88645
156 Reviewed by Tony Chang.
158 Re-trying to enable CSS regions on Windows. This time only enabling
159 regions since exclusions lead to some very strange compiling/linking
160 problems. This time adding preferences code to make sure the settings
161 get propagated to DRT (previous experiments by abucur showed they
164 * WebPreferenceKeysPrivate.h: Added preference key for CSS regions
165 * Interfaces/IWebPreferences.idl: Added getters and setters for CSS regions settings
166 * WebPreferences.cpp: ditto
167 (WebPreferences::initializeDefaultSettings):
168 (WebPreferences::isCSSRegionsEnabled):
169 (WebPreferences::setCSSRegionsEnabled):
170 * WebPreferences.h: ditto
172 * WebView.cpp: Added settings code to handle CSS regions, too
173 (WebView::notifyPreferencesChanged):
175 2012-06-25 Mark Hahnenberg <mhahnenberg@apple.com>
177 JSLock should be per-JSGlobalData
178 https://bugs.webkit.org/show_bug.cgi?id=89123
180 Reviewed by Geoffrey Garen.
182 Changed all sites that used JSLock to instead use the new JSLockHolder
183 and pass in the correct JS context that the code is about to interact with that
184 needs protection. Also added a couple JSLocks to places that didn't already
185 have it that needed it.
187 * WebCoreStatistics.cpp:
188 (WebCoreStatistics::javaScriptObjectsCount):
189 (WebCoreStatistics::javaScriptGlobalObjectsCount):
190 (WebCoreStatistics::javaScriptProtectedObjectsCount):
191 (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
192 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
194 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
195 * WebJavaScriptCollector.cpp:
196 (WebJavaScriptCollector::objectCount):
198 (WebView::stringByEvaluatingJavaScriptFromString):
199 (WebView::reportException):
200 (WebView::elementFromJS):
202 2012-06-23 Sheriff Bot <webkit.review.bot@gmail.com>
204 Unreviewed, rolling out r121058.
205 http://trac.webkit.org/changeset/121058
206 https://bugs.webkit.org/show_bug.cgi?id=89809
208 Patch causes plugins tests to crash in GTK debug builds
209 (Requested by zdobersek on #webkit).
211 * WebCoreStatistics.cpp:
212 (WebCoreStatistics::javaScriptObjectsCount):
213 (WebCoreStatistics::javaScriptGlobalObjectsCount):
214 (WebCoreStatistics::javaScriptProtectedObjectsCount):
215 (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
216 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
218 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
219 * WebJavaScriptCollector.cpp:
220 (WebJavaScriptCollector::objectCount):
222 (WebView::stringByEvaluatingJavaScriptFromString):
223 (WebView::reportException):
224 (WebView::elementFromJS):
226 2012-06-20 Mark Hahnenberg <mhahnenberg@apple.com>
228 JSLock should be per-JSGlobalData
229 https://bugs.webkit.org/show_bug.cgi?id=89123
231 Reviewed by Gavin Barraclough.
233 Changed all sites that used JSLock to instead use the new JSLockHolder
234 and pass in the correct JS context that the code is about to interact with that
237 * WebCoreStatistics.cpp:
238 (WebCoreStatistics::javaScriptObjectsCount):
239 (WebCoreStatistics::javaScriptGlobalObjectsCount):
240 (WebCoreStatistics::javaScriptProtectedObjectsCount):
241 (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
242 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
244 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
245 * WebJavaScriptCollector.cpp:
246 (WebJavaScriptCollector::objectCount):
248 (WebView::stringByEvaluatingJavaScriptFromString):
249 (WebView::reportException):
250 (WebView::elementFromJS):
252 2012-06-20 Garret Kelly <gdk@chromium.org>
254 Moving cookieEnabled/setCookieEnabled from Page to Settings.
255 https://bugs.webkit.org/show_bug.cgi?id=89545
257 Reviewed by Adam Barth.
260 (WebView::setCookieEnabled):
261 (WebView::cookieEnabled):
263 2012-06-20 Julien Chaffraix <jchaffraix@webkit.org>
265 Use IntSize in RenderLayer to represent scroll offsets
266 https://bugs.webkit.org/show_bug.cgi?id=89154
268 Reviewed by Eric Seidel.
272 Updated to pass an IntSize to scrollByRecursively.
274 2012-06-11 Kaustubh Atrawalkar <kaustubh@motorola.com>
276 [DRT] LTC:: counterValueForElementById() could be moved to Internals.
277 https://bugs.webkit.org/show_bug.cgi?id=84406
279 Reviewed by Hajime Morita.
281 Move the counterValueForElementById from LayoutTestCotroller to Internals and
282 remove the old platform specific implementations as it exclusively tests WebCore functionality.
284 * Interfaces/IWebFramePrivate.idl:
288 2012-06-11 Sam Weinig <sam@webkit.org>
290 Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
291 https://bugs.webkit.org/show_bug.cgi?id=88723
293 Reviewed by Dan Bernstein.
296 (WebFrame::setIsDisconnected):
297 (WebFrame::setExcludeFromTextSearch):
298 Stop doing anything in these functions.
300 2012-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
302 Unreviewed, rolling out r119955.
303 http://trac.webkit.org/changeset/119955
304 https://bugs.webkit.org/show_bug.cgi?id=88758
306 Breaks Chromium compile - Chromium depends on removed API
307 (Requested by dominicc on #webkit).
310 (WebFrame::setIsDisconnected):
311 (WebFrame::setExcludeFromTextSearch):
313 2012-06-10 Sam Weinig <sam@webkit.org>
315 Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
316 https://bugs.webkit.org/show_bug.cgi?id=88723
318 Reviewed by Dan Bernstein.
321 (WebFrame::setIsDisconnected):
322 (WebFrame::setExcludeFromTextSearch):
323 Stop doing anything in these functions.
325 2012-05-31 Hajime Morrita <morrita@chromium.org>
327 REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
328 https://bugs.webkit.org/show_bug.cgi?id=86859
330 Reviewed by Ryosuke Niwa.
332 * WebCoreSupport/WebEditorClient.h:
333 (WebEditorClient::requestCheckingOfString):
335 2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
337 WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
338 https://bugs.webkit.org/show_bug.cgi?id=42328
340 Reviewed by Eric Seidel.
343 (WebInspector::setJavaScriptProfilingEnabled):
345 2012-05-25 Lynn Neir <lynn.neir@skype.net>
347 Added methods needed to implement backend for DRT's TextInputController on windows, https://bugs.webkit.org/show_bug.cgi?id=32021
349 Reviewed by Eric Seidel.
351 * Interfaces/IWebViewPrivate.idl:
353 (WebView::setCompositionForTesting):
354 (WebView::hasCompositionForTesting):
355 (WebView::confirmCompositionForTesting):
356 (WebView::compositionRangeForTesting):
357 (WebView::firstRectForCharacterRangeForTesting):
358 (WebView::selectedRangeForTesting):
362 2012-05-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
364 Move setEditingBehavior() from layoutTestController to window.internals
365 https://bugs.webkit.org/show_bug.cgi?id=42689
367 Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
369 Remove Win private API to get/set the editing behavior. Follow the previous
370 removals that keep the virtual functions there but failing.
372 * Interfaces/IWebPreferences.idl:
373 * WebPreferenceKeysPrivate.h:
374 * WebPreferences.cpp:
375 (WebPreferences::unused5):
376 (WebPreferences::unused6):
380 (WebView::notifyPreferencesChanged):
382 2012-05-18 MORITA Hajime <morrita@google.com>
384 Another unreviewed attempt to fix build breakage on r117572.
386 * WebCoreSupport/WebEditorClient.h:
387 (WebEditorClient::frameWillDetachPage):
389 2012-05-18 MORITA Hajime <morrita@google.com>
391 https://bugs.webkit.org/show_bug.cgi?id=85515
392 Stale frame in WebCore::SpellChecker::didCheckSucceeded
394 Reviewed by Ryosuke Niwa.
396 * WebCoreSupport/WebEditorClient.h:
397 (WebEditorClient::frameWillDetachPage):
399 2012-05-17 Hironori Bono <hbono@chromium.org>
401 [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
402 https://bugs.webkit.org/show_bug.cgi?id=86591
404 Reviewed by Ryosuke Niwa.
406 This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
407 function to remove platform-specific code from Editor::respondToChangedSelection
410 No new tests, no change in behavior.
412 * WebCoreSupport/WebEditorClient.cpp:
413 (WebEditorClient::shouldEraseMarkersAfterChangeSelection):
414 * WebCoreSupport/WebEditorClient.h:
417 2012-05-17 Dan Bernstein <mitz@apple.com>
419 REGRESSION (r117428): WebKit API/SPI was removed
420 https://bugs.webkit.org/show_bug.cgi?id=86748
424 * Interfaces/IWebViewPrivate.idl:
426 (WebView::setDomainRelaxationForbiddenForURLScheme):
430 2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
432 Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
433 https://bugs.webkit.org/show_bug.cgi?id=86704
435 Reviewed by Eric Seidel.
437 Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
438 cross-port way through the InternalSettings interface.
440 * Interfaces/IWebViewPrivate.idl:
445 2012-05-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
447 Move resumeAnimations to use Internals interface
448 https://bugs.webkit.org/show_bug.cgi?id=86063
450 Reviewed by Alexey Proskuryakov.
452 Remove resumeAnimations functions, because it is able to work in the
453 cross-port way through the Internals interface.
455 * Interfaces/IWebFramePrivate.idl:
459 2012-05-10 Anders Carlsson <andersca@apple.com>
461 Rename the missing plug-in indicator to the unavailable plug-in indicator
462 https://bugs.webkit.org/show_bug.cgi?id=86136
464 Reviewed by Sam Weinig.
466 * WebCoreSupport/WebChromeClient.cpp:
467 (WebChromeClient::shouldUnavailablePluginMessageBeButton):
468 (WebChromeClient::unavailablePluginButtonClicked):
469 * WebCoreSupport/WebChromeClient.h:
472 2012-05-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
474 Move suspendAnimations to use Internals interface.
475 https://bugs.webkit.org/show_bug.cgi?id=85986
477 Reviewed by Ryosuke Niwa.
479 Remove suspendAnimations functions, because it is able to work in the
480 cross-port way through the Internals interface.
482 * Interfaces/IWebFramePrivate.idl:
486 2012-05-07 Julien Chaffraix <jchaffraix@webkit.org>
488 Refactor windowClipRectForLayer to remove the explicit RenderLayer dependency
489 https://bugs.webkit.org/show_bug.cgi?id=84090
491 Reviewed by David Hyatt.
493 * WebCoreSupport/EmbeddedWidget.cpp:
494 (EmbeddedWidget::windowClipRect):
495 Updated after windowClipRectForLayer name and signature change.
497 * WebCoreSupport/EmbeddedWidget.h:
499 (EmbeddedWidget::EmbeddedWidget):
500 Updated the internal DOM pointer to be an HTMLPlugInElement
501 as it was what was passed in anyway. Also fixed some style
502 issues detected by our tools.
504 2012-05-05 Dean Jackson <dino@apple.com>
506 Add new Setting/Preference to disable requestAnimationFrame
507 https://bugs.webkit.org/show_bug.cgi?id=85693
509 Reviewed by Simon Fraser.
511 Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
512 The default value is true. The majority of applications will leave
515 * Interfaces/IWebPreferencesPrivate.idl:
516 * WebPreferenceKeysPrivate.h:
517 * WebPreferences.cpp:
518 (WebPreferences::initializeDefaultSettings):
519 (WebPreferences::setRequestAnimationFrameEnabled):
520 (WebPreferences::requestAnimationFrameEnabled):
524 (WebView::notifyPreferencesChanged):
526 2012-05-04 Nate Chapin <japhet@chromium.org>
528 Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
529 https://bugs.webkit.org/show_bug.cgi?id=85533
531 Reviewed by Alexey Proskuryakov.
533 * WebCoreSupport/WebFrameLoaderClient.cpp:
534 (WebFrameLoaderClient::finishedLoading):
536 2012-04-27 Jon Lee <jonlee@apple.com>
538 Migrate permission functions to Notification from NotificationCenter
539 https://bugs.webkit.org/show_bug.cgi?id=80485
540 <rdar://problem/10965458>
544 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
545 (WebDesktopNotificationsDelegate::requestPermission):
546 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
547 (WebDesktopNotificationsDelegate): Add stub implementation of requestPermission.
549 2012-04-23 Jon Honeycutt <jhoneycutt@apple.com>
551 FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
552 information about the form being submitted
553 https://bugs.webkit.org/show_bug.cgi?id=84297
555 Reviewed by Andy Estes.
558 Fix function stub for new parameter.
560 2012-05-01 Ryosuke Niwa <rniwa@webkit.org>
562 *Command.h files shouldn't be exported to WebKit layer
563 https://bugs.webkit.org/show_bug.cgi?id=74778
565 Reviewed by Eric Seidel.
569 2012-04-20 Emil A Eklund <eae@chromium.org>
571 [win] Update windows platform code to use pixel snapped values
572 https://bugs.webkit.org/show_bug.cgi?id=84283
574 Reviewed by Eric Seidel.
576 * AccessibleBase.cpp:
577 (AccessibleBase::accLocation):
579 2012-04-18 Vivek Galatage <vivekgalatage@gmail.com>
581 Web Inspector: Disabling Inspector causes build failure on Windows
582 https://bugs.webkit.org/show_bug.cgi?id=83557
584 Reviewed by Pavel Feldman.
586 The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
587 This change brings all such API calls under the guard.
589 * WebCoreSupport/WebInspectorClient.cpp:
591 * WebNodeHighlight.cpp:
592 (WebNodeHighlight::WebNodeHighlight):
593 (WebNodeHighlight::update):
594 * WebNodeHighlight.h:
599 (WebView::initWithFrame):
600 (WebView::inspector):
604 2012-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
606 Unreviewed, rolling out r113836.
607 http://trac.webkit.org/changeset/113836
608 https://bugs.webkit.org/show_bug.cgi?id=83705
610 Broke all the WebKit2 inspector tests (Requested by andersca
613 * WebCoreSupport/WebInspectorClient.cpp:
614 (registerWindowClass):
616 (WebInspector::setTimelineProfilingEnabled):
617 * WebNodeHighlight.cpp:
618 (WebNodeHighlight::WebNodeHighlight):
619 (WebNodeHighlight::update):
620 * WebNodeHighlight.h:
625 (WebView::initWithFrame):
626 (WebView::inspector):
630 2012-04-11 Vivek Galatage <vivekgalatage@gmail.com>
632 Web Inspector: Disabling Inspector causes build failure on Windows
633 https://bugs.webkit.org/show_bug.cgi?id=83557
635 Reviewed by Pavel Feldman.
637 The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
638 This change brings all such API calls under the guard.
640 * WebCoreSupport/WebInspectorClient.cpp:
642 * WebNodeHighlight.cpp:
643 (WebNodeHighlight::WebNodeHighlight):
644 (WebNodeHighlight::update):
645 * WebNodeHighlight.h:
650 (WebView::initWithFrame):
651 (WebView::inspector):
655 2012-03-30 Mark Pilgrim <pilgrim@chromium.org>
657 GEOLOCATION should be implemented as Page Supplement
658 https://bugs.webkit.org/show_bug.cgi?id=82228
660 Reviewed by Adam Barth.
662 Geolocation is now a Supplement in Page so the interface
663 has changed for setting up the page's geolocation client
664 initially and accessing the controller later.
667 (WebView::initWithFrame):
668 (WebView::geolocationDidChangePosition):
669 (WebView::geolocationDidFailWithError):
671 2012-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
673 Unreviewed, rolling out r112553.
674 http://trac.webkit.org/changeset/112553
675 https://bugs.webkit.org/show_bug.cgi?id=82638
677 It made all tests crash on Qt WK2 (Requested by Ossy_away on
681 (WebView::initWithFrame):
682 (WebView::geolocationDidChangePosition):
683 (WebView::geolocationDidFailWithError):
685 2012-03-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
687 HashMap<>::add should return a more descriptive object
688 https://bugs.webkit.org/show_bug.cgi?id=71063
690 Reviewed by Ryosuke Niwa.
692 Update code to use AddResult instead of a pair.
697 2012-03-29 Mark Pilgrim <pilgrim@chromium.org>
699 GEOLOCATION should be implemented as Page Supplement
700 https://bugs.webkit.org/show_bug.cgi?id=82228
702 Reviewed by Adam Barth.
704 Geolocation is now a Supplement in Page so the interface
705 has changed for setting up the page's geolocation client
706 initially and accessing the controller later.
709 (WebView::initWithFrame):
710 (WebView::geolocationDidChangePosition):
711 (WebView::geolocationDidFailWithError):
713 2012-03-28 Nate Chapin <japhet@chromium.org>
715 Remove dispatchDidLoadMainResource callback, since no
717 https://bugs.webkit.org/show_bug.cgi?id=82539
719 Reviewed by Alexey Proskuryakov.
721 * WebCoreSupport/WebFrameLoaderClient.cpp:
722 * WebCoreSupport/WebFrameLoaderClient.h:
723 (WebFrameLoaderClient):
725 2012-03-26 Adam Barth <abarth@webkit.org>
727 FrameLoader::shouldAllowNavigation uses Frame for context rather than Document
728 https://bugs.webkit.org/show_bug.cgi?id=81020
730 Reviewed by Eric Seidel.
732 Update call site to new function name.
735 (WebFrame::dispatchWillSubmitForm):
737 2012-03-22 Anders Carlsson <andersca@apple.com>
739 ASSERT(!needsLayout) in RenderView.cpp when visiting http://www.panic.com/blog/
740 https://bugs.webkit.org/show_bug.cgi?id=81953
741 <rdar://problem/11086998>
743 Reviewed by Sam Weinig.
745 Update for changes to WebCore.
747 * FullscreenVideoController.cpp:
748 (FullscreenVideoController::LayerClient::platformCALayerDidCreateTiles):
750 2012-03-20 Steve Falkenburg <sfalken@apple.com>
752 Move WTF-related Windows project files out of JavaScriptCore
753 https://bugs.webkit.org/show_bug.cgi?id=80680
755 Reviewed by Jessie Berlin.
757 * WebKit.vcproj/WebKit.sln:
759 2012-03-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
761 Convert hasSpellingMarker to use Internals interface.
762 https://bugs.webkit.org/show_bug.cgi?id=81300
764 Reviewed by Ryosuke Niwa.
766 Remove hasSpellingMarker interface support, since it can support in the cross-port
767 way through the Internals interface.
769 * Interfaces/IWebFramePrivate.idl:
771 2012-03-19 Adam Barth <abarth@webkit.org>
773 Remove support for "magic" iframe
774 https://bugs.webkit.org/show_bug.cgi?id=81590
776 Reviewed by Eric Seidel.
778 Remove FrameLoaderClient methods that no longer exist.
780 * WebCoreSupport/WebFrameLoaderClient.cpp:
781 * WebCoreSupport/WebFrameLoaderClient.h:
782 (WebFrameLoaderClient):
784 2012-03-19 Anders Carlsson <andersca@apple.com>
788 * FullscreenVideoController.cpp:
789 (FullscreenVideoController::LayerClient::platformCALayerDeviceScaleFactor):
791 2012-03-13 Jon Lee <jonlee@apple.com>
793 Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
794 https://bugs.webkit.org/show_bug.cgi?id=80922
795 <rdar://problem/11035082>
799 You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
800 LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
801 new API. Therefore, APIs that are common between the two will have:
802 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
804 This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
805 the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
807 Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
808 * WebCoreSupport/WebChromeClient.cpp:
809 (WebChromeClient::WebChromeClient):
810 * WebCoreSupport/WebChromeClient.h:
812 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
813 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
815 2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
817 Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
818 https://bugs.webkit.org/show_bug.cgi?id=78853
820 Reviewed by Adam Barth.
822 * WebCoreSupport/WebChromeClient.h:
824 * WebCoreSupport/WebGeolocationClient.cpp:
825 (WebGeolocationClient::lastPosition):
826 * WebGeolocationPosition.cpp:
827 (WebGeolocationPosition::initWithTimestamp):
829 * WebGeolocationPosition.h:
830 (WebGeolocationPosition):
831 (WebGeolocationPosition::impl):
833 (WebView::initWithFrame):
834 (WebView::geolocationDidChangePosition):
835 (WebView::geolocationDidFailWithError):
837 2012-03-12 Jessie Berlin <jberlin@apple.com>
839 More Windows build fixing.
841 * MarshallingHelpers.cpp:
842 * WebDatabaseManager.cpp:
844 2012-03-09 Jon Lee <jonlee@apple.com>
846 Rename NotificationPresenter to NotificationClient
847 https://bugs.webkit.org/show_bug.cgi?id=80488
848 <rdar://problem/10965558>
850 Reviewed by Kentaro Hara.
852 Refactor to use renamed WebCore::NotificationClient.
853 * WebCoreSupport/WebChromeClient.h:
854 (WebChromeClient::notificationPresenter):
855 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
856 (WebDesktopNotificationsDelegate::checkPermission):
857 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
858 (WebDesktopNotificationsDelegate):
860 2012-03-09 Emil A Eklund <eae@chromium.org>
862 Add roundedPoint to HitTestResult and change platform code to use it
863 https://bugs.webkit.org/show_bug.cgi?id=80715
865 Reviewed by James Robinson.
867 Change ports to use roundedPoint to avoid exposing subpixel types to
871 (WebView::handleContextMenuEvent):
873 2012-03-08 Steve Falkenburg <sfalken@apple.com>
875 Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
876 https://bugs.webkit.org/show_bug.cgi?id=80657
878 Preparation for WTF separation from JavaScriptCore.
879 The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
880 dependencies for generated files.
882 Reviewed by Jessie Berlin.
884 * WebKit.vcproj/WebKit.sln: Add WTFGenerated, update dependent projects.
886 2012-03-03 Benjamin Poulain <benjamin@webkit.org>
888 Remove the redundant method KURL::protocolInHTTPFamily()
889 https://bugs.webkit.org/show_bug.cgi?id=80216
891 Reviewed by Anders Carlsson.
893 * WebCoreSupport/WebFrameLoaderClient.cpp:
894 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
896 (WebHistory::visitedURL):
898 2012-02-26 Hajime Morrita <morrita@chromium.org>
900 Move ChromeClient::showContextMenu() to ContextMenuClient
901 https://bugs.webkit.org/show_bug.cgi?id=79427
903 Reviewed by Adam Barth.
905 * WebCoreSupport/WebChromeClient.h:
908 2012-02-24 Shinya Kawanaka <shinyak@chromium.org>
910 SpellCheckRequest needs to know the context where the spellcheck happened.
911 https://bugs.webkit.org/show_bug.cgi?id=79320
913 Reviewed by Hajime Morita.
915 * WebCoreSupport/WebEditorClient.h:
916 (WebEditorClient::requestCheckingOfString):
919 2012-02-21 Ryosuke Niwa <rniwa@webkit.org>
921 Remove the remaining uses of CSSStyleDeclaration in Editor
922 https://bugs.webkit.org/show_bug.cgi?id=78939
924 Reviewed by Enrica Casucci.
926 * WebCoreSupport/WebEditorClient.cpp:
927 (WebEditorClient::shouldApplyStyle):
928 * WebCoreSupport/WebEditorClient.h:
931 2012-02-22 Ryosuke Niwa <rniwa@webkit.org>
933 Remove the remaining uses of CSSStyleDeclaration in Editor
934 https://bugs.webkit.org/show_bug.cgi?id=78939
936 Reviewed by Enrica Casucci.
938 * WebCoreSupport/WebEditorClient.cpp:
939 (WebEditorClient::shouldApplyStyle):
940 * WebCoreSupport/WebEditorClient.h:
943 2012-02-17 Kalev Lember <kalevlember@gmail.com>
945 Remove unused parameters from WTF threading API
946 https://bugs.webkit.org/show_bug.cgi?id=78389
948 Reviewed by Adam Roben.
950 waitForThreadCompletion() had an out param 'void **result' to get the
951 'void *' returned by ThreadFunction. However, the implementation in
952 ThreadingWin.cpp ignored the out param, not filling it in. This had
953 led to a situation where none of the client code made use of the param
956 To clean this up, the patch changes the signature of ThreadFunction to
957 return void instead of void* and drops the the unused 'void **result'
958 parameter from waitForThreadCompletion. Also, all client code is
959 updated for the API change.
961 As mentioned in https://bugs.webkit.org/show_bug.cgi?id=78389 , even
962 though the change only affects internal API, Safari is using it
963 directly and we'll need to keep the old versions around for ABI
964 compatibility. For this, the patch adds compatibility wrappers with
967 * WebKit.vcproj/WebKit_Cairo.def: Add the new functions.
968 * WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
970 2012-02-15 Sadrul Habib Chowdhury <sadrul@chromium.org>
972 Notify ChromeClient when touch-event handlers are installed/removed.
973 https://bugs.webkit.org/show_bug.cgi?id=77440
975 Reviewed by Darin Fisher and Ryosuke Niwa.
977 * WebCoreSupport/WebChromeClient.h:
978 (WebChromeClient::numTouchEventHandlersChanged):
980 2012-02-14 Alexey Proskuryakov <ap@apple.com>
982 [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
983 https://bugs.webkit.org/show_bug.cgi?id=78541
984 <rdar://problem/10036695>
986 Reviewed by Kent Tamura.
988 * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default value of
991 2012-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
993 Convert svg/animations to use SMIL methods for driving the timeline
994 https://bugs.webkit.org/show_bug.cgi?id=78422
996 Reviewed by Dirk Schulze.
998 Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
999 Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
1001 * Interfaces/IWebFramePrivate.idl:
1005 2012-02-13 Andy Estes <aestes@apple.com>
1007 Fix the Windows build.
1009 * WebCoreSupport/WebPlatformStrategies.cpp:
1010 (WebPlatformStrategies::createPasteboardStrategy):
1011 * WebCoreSupport/WebPlatformStrategies.h:
1012 (WebPlatformStrategies):
1014 2012-02-12 Andy Estes <aestes@apple.com>
1016 [Windows] Add API to enable inverted color drawing on a WebView
1017 https://bugs.webkit.org/show_bug.cgi?id=77382
1019 Reviewed by Adam Roben.
1021 Add a new private WebPreference key called "WebKitShouldInvertColors"
1022 and add private cover methods to get and set the preference. When this
1023 preference changes on a WebPreference object, all WebViews listening to
1024 that object will repaint to reflect the new value.
1026 * Interfaces/IWebPreferencesPrivate.idl: Add [setS|s]houldInvertColors()
1027 cover methods for WebKitShouldInvertColorsPreferenceKey.
1028 * WebPreferenceKeysPrivate.h: Add WebKitShouldInvertColorsPreferenceKey.
1029 * WebPreferences.cpp:
1030 (WebPreferences::shouldInvertColors):
1031 (WebPreferences::setShouldInvertColors):
1035 (WebView::setShouldInvertColors): If m_shouldInvertColors changes,
1036 update the value on the WebView and in m_layerTreeHost, then repaint
1038 (WebView::notifyPreferencesChanged):
1039 (WebView::setAcceleratedCompositing): When creating a new layer tree
1040 host, tell it whether it should be inverting colors.
1043 2012-02-07 MORITA Hajime <morrita@google.com>
1045 Replacement text should be available from the marker.
1046 https://bugs.webkit.org/show_bug.cgi?id=77934
1048 Reviewed by Kent Tamura.
1050 * WebKit.vcproj/WebKit_Cairo.def:
1051 * WebKit.vcproj/WebKit_Cairo_debug.def:
1053 2012-02-02 Jon Lee <jonlee@apple.com>
1055 Clear shown notifications when context is no longer active
1056 https://bugs.webkit.org/show_bug.cgi?id=77363
1057 <rdar://problem/10568907>
1059 Reviewed by Darin Adler.
1061 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
1062 (WebDesktopNotificationsDelegate): Add previously missing virtual functions.
1063 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
1064 (WebDesktopNotificationsDelegate::notificationControllerDestroyed):
1065 (WebDesktopNotificationsDelegate::cancelRequestsForPermission):
1067 2012-02-01 Anders Carlsson <andersca@apple.com>
1069 Another attempt to fix the Windows build.
1071 * FullscreenVideoController.cpp:
1072 (FullscreenVideoController::LayerClient::platformCALayerDidCreateTiles):
1074 2012-01-26 Andy Estes <aestes@apple.com>
1076 [Windows] Optionally invert colors when drawing to a WebView's backing store.
1077 https://bugs.webkit.org/show_bug.cgi?id=77168
1079 Reviewed by Sam Weinig.
1082 (WebView::WebView): Initialize m_shouldInvertColors to false.
1083 (WebView::paintIntoBackingStore): If m_shouldInvertColors is true, draw
1084 an opaque white quad using the CompositeDifference blend mode. This
1085 blend operation instructs CoreGraphics to take the difference between
1086 the source pixel (white) and the background pixel, resulting in an
1088 * WebView.h: Define m_shouldInvertColors.
1090 2012-01-23 Simon Fraser <simon.fraser@apple.com>
1092 Show layer borders for scrollbar layers
1093 https://bugs.webkit.org/show_bug.cgi?id=76888
1095 Reviewed by Beth Dakin.
1097 Update for new signature of GraphicsLayerClient::showDebugBorders()
1098 and GraphicsLayerClient::showRepaintCounter().
1101 (WebView::showDebugBorders):
1102 (WebView::showRepaintCounter):
1105 2012-01-23 David Levin <levin@chromium.org>
1107 [windows] Convert usages of GetDC to HWndDC Part 2.
1108 https://bugs.webkit.org/show_bug.cgi?id=76750
1110 Reviewed by Adam Roben.
1112 * FullscreenVideoController.cpp:
1113 (createCompatibleDCForWindow): Moved out the code which creates a DC for a window
1114 to keep the same scope for the DC lifetime.
1115 (FullscreenVideoController::draw): Switch to using OwnPtr<HDC>
1116 since createCompatibleDCForWindow returns a PassOwnPtr.
1117 * WebNodeHighlight.cpp:
1118 (WebNodeHighlight::update):
1119 Cleaned up leaks from calling GetDC without release.
1120 Note that there is a potential leak of hdc that previously existed
1121 and still does in an early exit scenario. (This could be easily fixed
1122 by using OwnPtr<HDC> but I was trying to keep this patch focused.)
1124 (WebView::scrollBackingStore): Typical conversion.
1125 (WebView::updateBackingStore): Reduced the scope of windowDC to be
1126 right where it is being used.
1127 (WebView::performLayeredWindowUpdate): Typical conversion.
1128 (WebView::paintIntoBackingStore): Ditto.
1130 2012-01-23 David Levin <levin@chromium.org>
1132 [windows] Convert usages of GetDC to HWndDC Part 1.
1133 https://bugs.webkit.org/show_bug.cgi?id=76744
1135 Reviewed by Adam Roben.
1137 * WebIconDatabase.cpp:
1138 (createDIB): Changed GetDC to HWndDC and removed ReleaseDC.
1140 2012-01-07 Andreas Kling <awesomekling@apple.com>
1144 * DOMHTMLClasses.cpp:
1145 (DOMHTMLDocument::forms):
1146 (DOMHTMLSelectElement::options):
1148 2012-01-06 Jessie Berlin <jberlin@apple.com>
1152 * Interfaces/IWebViewPrivate.idl:
1154 2012-01-05 Adam Roben <aroben@apple.com>
1156 Add WebKitTestRunnerLauncher to WebKit.sln.
1158 It builds just after WebKitTestRunner.
1160 Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1161 Windows port of DumpRenderTree/WebKitTestRunner
1163 Reviewed by Steve Falkenburg.
1165 * WebKit.vcproj/WebKit.sln:
1167 2012-01-05 Adam Roben <aroben@apple.com>
1169 Add DumpRenderTreeLauncher to WebKit.sln.
1171 It builds just after DumpRenderTree.
1173 Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1174 Windows port of DumpRenderTree/WebKitTestRunner
1176 Reviewed by Steve Falkenburg.
1178 * WebKit.vcproj/WebKit.sln:
1180 2012-01-04 Adam Roben <aroben@apple.com>
1182 Add ImageDiffLauncher to WebKit.sln
1184 It builds just after ImageDiff.
1186 Part of <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
1188 Reviewed by Anders Carlsson.
1190 * WebKit.vcproj/WebKit.sln:
1192 2012-01-04 Adam Roben <aroben@apple.com>
1194 Add MiniBrowserLauncher to WebKit.sln
1196 It builds just after MiniBrowser.
1198 Part of <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch
1201 Reviewed by Anders Carlsson.
1203 * WebKit.vcproj/WebKit.sln: Added MiniBrowserLauncher.
1205 2012-01-04 Adam Roben <aroben@apple.com>
1207 Add WinLauncherLauncher to WebKit.sln
1209 It builds just after WinLauncher.
1211 Part of <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch
1214 Reviewed by Anders Carlsson.
1216 * WebKit.vcproj/WebKit.sln: Added WinLauncherLauncher.
1218 2011-12-21 Jessie Berlin <jberlin@apple.com>
1220 Expose to Windows the way to allow a scheme access to Local Storage and Databases while
1221 Private Browsing is enabled.
1222 https://bugs.webkit.org/show_bug.cgi?id=75056
1224 Reviewed by Sam Weinig.
1226 Add the Windows WebKit API that corresponds to the Mac one added in r99439.
1229 (WebView::registerURLSchemeAsSecure):
1230 (WebView::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing):
1231 (WebView::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing):
1234 2011-12-20 Pavel Feldman <pavel.feldman@gmail.com>
1236 Web Inspector: reproducible crash after closing web inspector and browser window (iCab)
1237 https://bugs.webkit.org/show_bug.cgi?id=74255
1239 Reviewed by Yury Semikhatsky.
1241 * WebCoreSupport/WebInspectorClient.cpp:
1242 (WebInspectorClient::~WebInspectorClient):
1243 (WebInspectorFrontendClient::destroyInspectorView):
1244 * WebCoreSupport/WebInspectorClient.h:
1246 2011-12-19 Sam Weinig <sam@webkit.org>
1248 More PlatformEvent cleanup
1249 https://bugs.webkit.org/show_bug.cgi?id=74831
1251 Reviewed by Dan Bernstein.
1254 (WebView::handleMouseEvent):
1255 Update to use new names, access style.
1257 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
1259 Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
1260 https://bugs.webkit.org/show_bug.cgi?id=74748
1262 Reviewed by Eric Seidel.
1264 * WebCoreSupport/WebEditorClient.cpp:
1265 (WebEditorClient::registerUndoStep):
1266 (WebEditorClient::registerRedoStep):
1267 * WebCoreSupport/WebEditorClient.h:
1269 2011-12-16 Sam Weinig <sam@webkit.org>
1271 Give PlatformEvents a base class
1272 https://bugs.webkit.org/show_bug.cgi?id=74685
1274 Reviewed by Anders Carlsson.
1276 Add a base class for PlatformMouseEvent, PlatformKeyboardEvent, PlatformWheelEvent
1277 and PlatformGestureEvent and move Type enumeration and modifiers down to it.
1279 * AccessibleBase.cpp:
1280 (AccessibleBase::get_accKeyboardShortcut):
1281 * WebDropSource.cpp:
1282 (generateMouseEvent):
1285 (WebView::handleEditingKeyboardEvent):
1287 (WebView::keyPress):
1289 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
1291 Only EditCommandComposition should implement unapply and reapply
1292 https://bugs.webkit.org/show_bug.cgi?id=74490
1294 Reviewed by Eric Seidel.
1296 * WebCoreSupport/WebEditorClient.cpp:
1297 (WebEditorUndoCommand::WebEditorUndoCommand):
1298 (WebEditorUndoCommand::execute):
1299 (WebEditorClient::registerCommandForUndo):
1300 (WebEditorClient::registerCommandForRedo):
1301 * WebCoreSupport/WebEditorClient.h:
1303 2011-12-14 Jing Zhao <jingzhao@chromium.org>
1305 Opening two popup menus by dispatchEvent() makes problems.
1306 https://bugs.webkit.org/show_bug.cgi?id=73304
1308 Reviewed by Kent Tamura.
1310 * WebCoreSupport/WebChromeClient.cpp:
1311 (WebChromeClient::hasOpenedPopup): Not implemented.
1312 * WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().
1314 2011-12-14 Sam Weinig <weinig@apple.com>
1316 Remove whitespace from InheritedPropertySheets attributes in
1317 vsprops files to appease the Visual Studio project migrator.
1319 Reviewed by Adam Roben.
1321 * WebKit.vcproj/InterfacesDebug.vsprops:
1322 * WebKit.vcproj/InterfacesDebugAll.vsprops:
1323 * WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops:
1324 * WebKit.vcproj/InterfacesProduction.vsprops:
1325 * WebKit.vcproj/InterfacesRelease.vsprops:
1326 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
1327 * WebKit.vcproj/WebKitGUIDDebug.vsprops:
1328 * WebKit.vcproj/WebKitGUIDDebugAll.vsprops:
1329 * WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops:
1330 * WebKit.vcproj/WebKitGUIDProduction.vsprops:
1331 * WebKit.vcproj/WebKitGUIDRelease.vsprops:
1332 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
1333 * WebKit.vcproj/WebKitLibDebug.vsprops:
1334 * WebKit.vcproj/WebKitLibDebugAll.vsprops:
1335 * WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops:
1336 * WebKit.vcproj/WebKitLibProduction.vsprops:
1337 * WebKit.vcproj/WebKitLibRelease.vsprops:
1338 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:
1340 2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
1342 Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
1343 https://bugs.webkit.org/show_bug.cgi?id=73986
1345 Reviewed by Kenneth Rohde Christiansen.
1348 (WebView::initWithFrame):
1350 2011-12-05 Eric Carlson <eric.carlson@apple.com>
1352 WebKit/mac part of: Add WebKit preferences for text track settings
1353 https://bugs.webkit.org/show_bug.cgi?id=73721
1355 Reviewed by John Sullivan.
1357 * Interfaces/IWebPreferences.idl: Declare getters and setters for new properties.
1359 * WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
1360 and shouldDisplayTextDescriptions properties.
1362 * WebPreferences.cpp:
1363 (WebPreferences::setShouldDisplaySubtitles): Added.
1364 (WebPreferences::shouldDisplaySubtitles): Ditto.
1365 (WebPreferences::setShouldDisplayCaptions): Ditto.
1366 (WebPreferences::shouldDisplayCaptions): Ditto.
1367 (WebPreferences::setShouldDisplayTextDescriptions): Ditto.
1368 (WebPreferences::shouldDisplayTextDescriptions): Ditto.
1369 * WebPreferences.h: Declare new methods.
1372 (WebView::notifyPreferencesChanged): Updates WebCore settings from WebKit prefs.
1374 2011-12-02 Steve Falkenburg <sfalken@apple.com>
1376 Reviewed by Darin Adler.
1378 Changes to localStorageDatabasePath don't have any effect on Windows
1379 https://bugs.webkit.org/show_bug.cgi?id=73606
1380 <rdar://problem/10491296>
1383 (WebView::notifyPreferencesChanged): Propagate local storage path change to m_page's settings.
1385 2011-11-30 Alexey Proskuryakov <ap@apple.com>
1387 Remove an unneeded argument from FrameLoaderClient::download
1388 https://bugs.webkit.org/show_bug.cgi?id=73486
1390 Reviewed by Andreas Kling.
1393 (WebFrame::download):
1395 Updated for the change.
1397 2011-11-26 Pavel Feldman <pfeldman@google.com>
1399 Web Inspector: remove disconnectFromBackend from the protocol.
1400 https://bugs.webkit.org/show_bug.cgi?id=73127
1402 Reviewed by Yury Semikhatsky.
1404 * WebCoreSupport/WebInspectorClient.cpp:
1405 (WebInspectorClient::inspectorDestroyed):
1406 (WebInspectorClient::closeInspectorFrontend):
1407 * WebCoreSupport/WebInspectorClient.h:
1409 2011-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
1411 Unreviewed, rolling out r101193.
1412 http://trac.webkit.org/changeset/101193
1413 https://bugs.webkit.org/show_bug.cgi?id=73158
1415 Breaks Windows and Qt minimal. (Requested by pfeldman on
1418 * WebCoreSupport/WebInspectorClient.cpp:
1419 (WebInspectorClient::inspectorDestroyed):
1420 (WebInspectorFrontendClient::disconnectFromBackend):
1421 * WebCoreSupport/WebInspectorClient.h:
1423 2011-11-26 Pavel Feldman <pfeldman@google.com>
1425 Web Inspector: remove disconnectFromBackend from the protocol.
1426 https://bugs.webkit.org/show_bug.cgi?id=73127
1428 Reviewed by Yury Semikhatsky.
1430 * WebCoreSupport/WebInspectorClient.cpp:
1431 (WebInspectorClient::inspectorDestroyed):
1432 (WebInspectorClient::closeInspectorFrontend):
1433 * WebCoreSupport/WebInspectorClient.h:
1435 2011-11-22 Pavel Feldman <pfeldman@google.com>
1437 Web Inspector: remove Inspector::bringToFront from the protocol.
1438 https://bugs.webkit.org/show_bug.cgi?id=72937
1440 Reviewed by Yury Semikhatsky.
1442 * WebCoreSupport/WebInspectorClient.cpp:
1443 (WebInspectorClient::bringFrontendToFront):
1444 * WebCoreSupport/WebInspectorClient.h:
1446 2011-11-21 Pavel Feldman <pfeldman@google.com>
1448 Not reviewed: an attempt to fix windows build.
1451 (WebInspector::isJavaScriptProfilingEnabled):
1452 (WebInspector::setJavaScriptProfilingEnabled):
1454 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
1456 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
1457 https://bugs.webkit.org/show_bug.cgi?id=62985
1459 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
1460 methods for plumbing the menu action handlers through the WebKit and WebCore.
1461 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
1462 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
1463 WebKit/win and WebKit2 to follow.
1465 Reviewed by Yury Semikhatsky.
1468 (WebInspector::createInstance):
1469 (WebInspector::WebInspector):
1470 (WebInspector::webViewClosed):
1471 (WebInspector::showConsole):
1472 (WebInspector::isDebuggingJavaScript):
1473 (WebInspector::toggleDebuggingJavaScript):
1474 (WebInspector::isProfilingJavaScript):
1475 (WebInspector::toggleProfilingJavaScript):
1476 (WebInspector::isJavaScriptProfilingEnabled):
1477 (WebInspector::setJavaScriptProfilingEnabled):
1478 (WebInspector::isTimelineProfilingEnabled):
1479 (WebInspector::setTimelineProfilingEnabled):
1484 (WebView::initWithFrame):
1485 (WebView::inspector):
1488 2011-10-17 Antonio Gomes <agomes@rim.com>
1490 Pass a Frame* parameter in EditorClient::respondToChangedSelection
1491 https://bugs.webkit.org/show_bug.cgi?id=70248
1493 Reviewed by Ryosuke Niwa.
1495 * WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter.
1496 (WebEditorClient::respondToChangedSelection):
1497 * WebCoreSupport/WebEditorClient.h:
1499 2011-11-15 Jochen Eisinger <jochen@chromium.org>
1501 Rename ReferrerPolicy to clarify its meaning
1502 https://bugs.webkit.org/show_bug.cgi?id=72420
1504 Reviewed by Nate Chapin.
1506 * WebCoreSupport/WebContextMenuClient.cpp:
1507 (WebContextMenuClient::searchWithGoogle):
1509 2011-11-15 Anders Carlsson <andersca@apple.com>
1511 HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
1512 https://bugs.webkit.org/show_bug.cgi?id=72397
1514 Reviewed by Dan Bernstein.
1516 * WebCoreSupport/WebChromeClient.cpp:
1517 (WebChromeClient::rootViewToScreen):
1518 (WebChromeClient::screenToRootView):
1519 * WebCoreSupport/WebChromeClient.h:
1521 2011-11-14 Anders Carlsson <andersca@apple.com>
1523 HostWindow invalidation functions should use root view coordinates
1524 https://bugs.webkit.org/show_bug.cgi?id=72338
1526 Reviewed by Dan Bernstein.
1528 * WebCoreSupport/WebChromeClient.cpp:
1529 (WebChromeClient::invalidateRootView):
1530 (WebChromeClient::invalidateContentsAndRootView):
1531 * WebCoreSupport/WebChromeClient.h:
1533 2011-11-07 Adam Barth <abarth@webkit.org>
1535 Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
1536 https://bugs.webkit.org/show_bug.cgi?id=71755
1538 Reviewed by Eric Seidel.
1541 (WebView::addOriginAccessWhitelistEntry):
1542 (WebView::removeOriginAccessWhitelistEntry):
1543 (WebView::resetOriginAccessWhitelists):
1545 2011-11-07 Adam Barth <abarth@webkit.org>
1547 Move DomainRelaxationForbidden scheme registry to SchemeRegistry
1548 https://bugs.webkit.org/show_bug.cgi?id=71750
1550 Reviewed by Eric Seidel.
1553 (WebView::setDomainRelaxationForbiddenForURLScheme):
1555 2011-11-07 Beth Dakin <bdakin@apple.com>
1557 https://bugs.webkit.org/show_bug.cgi?id=71490
1558 Support uiStateTransitionProgress for scrollbars
1560 <rdar://problem/9849612>
1562 Reviewed by Sam Weinig.
1564 Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.
1566 (WebScrollBar::handleMouseEvent):
1568 2011-11-02 Darin Adler <darin@apple.com>
1570 Change remaining callers of releaseRef to call leakRef
1571 https://bugs.webkit.org/show_bug.cgi?id=71422
1573 Reviewed by Darin Fisher.
1576 (WebCache::statistics):
1577 * WebDatabaseManager.cpp:
1578 (WebDatabaseManager::origins):
1579 (WebDatabaseManager::databasesWithOrigin):
1580 * WebHistoryItem.cpp:
1581 (WebHistoryItem::redirectURLs):
1582 * WebKitClassFactory.cpp:
1583 (leakRefFromCreateInstance):
1584 (WebKitClassFactory::CreateInstance):
1585 * WebScriptWorld.cpp:
1586 (WebScriptWorld::standardWorld):
1589 2011-11-02 Jon Lee <jonlee@apple.com>
1591 Expand DragController to provide more information about the dragging session
1592 https://bugs.webkit.org/show_bug.cgi?id=71324
1593 <rdar://problem/10379175>
1595 Reviewed by Darin Adler.
1598 (WebView::DragEnter): Minor refactoring because operation is stored in
1599 new DragSession struct.
1600 (WebView::DragOver): Ditto.
1602 2011-11-02 Tom Sepez <tsepez@chromium.org>
1604 XSSAuditor is silent
1605 https://bugs.webkit.org/show_bug.cgi?id=70973
1607 Reviewed by Adam Barth.
1609 * WebCoreSupport/WebFrameLoaderClient.cpp:
1610 (WebFrameLoaderClient::didDetectXSS):
1611 * WebCoreSupport/WebFrameLoaderClient.h:
1613 2011-10-28 Jochen Eisinger <jochen@chromium.org>
1615 Rename a number of methods mentioning JavaScript to just Script instead
1616 https://bugs.webkit.org/show_bug.cgi?id=71105
1618 Reviewed by Adam Barth.
1621 (WebFrame::dispatchDidClearWindowObjectInWorld):
1623 (WebView::notifyPreferencesChanged):
1625 2011-10-24 Geoffrey Garen <ggaren@apple.com>
1627 Build fix: removed some cases of threadsafeCopy() that I missed in
1630 * WebDatabaseManager.cpp:
1631 (DidModifyOriginData::dispatchToMainThread):
1632 * WebDownloadCFNet.cpp:
1633 (WebDownload::initToResumeWithBundle):
1634 * WebIconDatabase.cpp:
1635 (WebIconDatabase::didImportIconURLForPageURL):
1637 2011-10-24 Ryosuke Niwa <rniwa@webkit.org>
1639 threadsafeCopy has been renamed to isolatedCopy.
1641 * WebDatabaseManager.cpp:
1642 (DidModifyOriginData::dispatchToMainThread):
1644 2011-10-24 Adam Barth <abarth@webkit.org>
1646 Attempt to fix Windows build by updating to the new interface.
1648 * DOMEventsClasses.cpp:
1649 (DOMEvent::createInstance):
1651 2011-10-18 Adam Barth <abarth@webkit.org>
1653 Always enable ENABLE(XPATH)
1654 https://bugs.webkit.org/show_bug.cgi?id=70217
1656 Reviewed by Eric Seidel.
1658 * Interfaces/DOMWindow.idl:
1660 2011-10-14 Julien Chaffraix <jchaffraix@webkit.org>
1662 Remove layerX / layerY from the Windows API
1663 https://bugs.webkit.org/show_bug.cgi?id=70051
1665 Reviewed by Darin Adler.
1667 Renamed layerX to unused1 and layerY to unused2 to keep the
1668 binary compatibility.
1670 * DOMEventsClasses.cpp:
1671 (DOMUIEvent::unused1):
1672 (DOMUIEvent::unused2):
1673 * DOMEventsClasses.h:
1674 (DOMKeyboardEvent::unused1):
1675 (DOMKeyboardEvent::unused2):
1676 (DOMMouseEvent::unused1):
1677 (DOMMouseEvent::unused2):
1678 (DOMWheelEvent::unused1):
1679 (DOMWheelEvent::unused2):
1680 * Interfaces/DOMEvents.idl:
1682 2011-10-11 Simon Fraser <simon.fraser@apple.com>
1684 Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
1685 https://bugs.webkit.org/show_bug.cgi?id=68134
1687 Reviewed by Darin Adler.
1689 Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.
1691 Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
1692 that reads the setting, and returns the mock theme if set. All callers now use
1693 theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.
1696 (WebScrollBar::requestedWidth):
1697 (WebScrollBar::requestedHeight):
1699 (WebView::WebViewWndProc):
1701 2011-10-03 Anders Carlsson <andersca@apple.com>
1703 Remove custom scrollbar painting hooks
1704 https://bugs.webkit.org/show_bug.cgi?id=69163
1706 Reviewed by Alexey Proskuryakov.
1708 Remove now unused WebPreferences and ChromeClient overrides.
1710 * Interfaces/IWebPreferences.idl:
1711 * WebCoreSupport/WebChromeClient.cpp:
1712 * WebCoreSupport/WebChromeClient.h:
1713 * WebPreferenceKeysPrivate.h:
1714 * WebPreferences.cpp:
1715 (WebPreferences::unused3):
1716 (WebPreferences::unused4):
1719 (WebView::notifyPreferencesChanged):
1721 2011-09-23 Adam Roben <aroben@apple.com>
1723 Remove WebKitAPITest
1725 WebKit part of <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
1726 functionality (and names!)
1728 Reviewed by Anders Carlsson.
1730 * WebKit.vcproj/WebKit.sln: Removed WebKitAPITest.vcproj. Changed WebKitLauncherWin, which
1731 formerly depended on WebKitAPITest, to now depend on DumpRenderTree, which WebKitAPITest
1734 2011-09-24 Adam Barth <abarth@webkit.org>
1736 Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1737 https://bugs.webkit.org/show_bug.cgi?id=68767
1739 Reviewed by Eric Seidel.
1741 * WebCoreSupport/WebChromeClient.cpp:
1742 (WebChromeClient::reachedApplicationCacheOriginQuota):
1743 * WebCoreSupport/WebChromeClient.h:
1745 2011-09-22 Adam Roben <aroben@apple.com>
1747 Remove FindSafari from all our .sln files
1749 It isn't used anymore, so there's no point in building it.
1751 Part of <http://webkit.org/b/68628> Remove FindSafari
1753 Reviewed by Steve Falkenburg.
1755 * WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.
1757 2011-09-22 Adam Roben <aroben@apple.com>
1759 Add testRegExp.vcproj to WebKit.sln
1761 Fixes <http://webkit.org/b/68403> Windows bots don't build testRegExp.vcproj
1763 Reviewed by Brian Weinstein.
1765 * WebKit.vcproj/WebKit.sln: Added testRegExp. Made it build just after jsc, just like it
1766 does when built as part of JavaScriptCore.sln.
1768 2011-09-21 Steve Falkenburg <sfalken@apple.com>
1770 Branch builds don't launch on Windows when run against trunk WebKit
1771 https://bugs.webkit.org/show_bug.cgi?id=68546
1773 Reviewed by Darin Adler.
1775 * Interfaces/IWebPreferences.idl: Swap avFoundation and pictographicFontFamily
1776 in IDL for binary compatibility between branch and trunk.
1778 2011-09-21 Andras Becsi <andras.becsi@nokia.com>
1780 [Qt] Remove Qt specific code from css/SelectorChecker.cpp
1781 https://bugs.webkit.org/show_bug.cgi?id=67702
1783 Reviewed by Csaba Osztrogonác.
1785 * WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.
1786 (WebPlatformStrategies::isLinkVisited):
1787 * WebCoreSupport/WebPlatformStrategies.h: Ditto.
1789 2011-09-17 Mihai Parparita <mihaip@chromium.org>
1791 FrameLoaderClient BackForwardList-related methods are unsued
1792 https://bugs.webkit.org/show_bug.cgi?id=68293
1794 Reviewed by Darin Adler.
1796 Remove FrameLoaderClient methods that were added by r51629, since only
1797 the old (since-deleted) Android port needed them.
1799 * WebCoreSupport/WebFrameLoaderClient.cpp:
1800 * WebCoreSupport/WebFrameLoaderClient.h:
1802 2011-09-15 Adam Barth <abarth@webkit.org>
1804 Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
1805 https://bugs.webkit.org/show_bug.cgi?id=68205
1807 Reviewed by Eric Seidel.
1810 * WebCoreSupport/WebChromeClient.cpp:
1811 * WebCoreSupport/WebChromeClient.h:
1812 * WebDatabaseManager.cpp:
1813 * WebDatabaseManager.h:
1814 * WebSecurityOrigin.cpp:
1815 (WebSecurityOrigin::usage):
1816 (WebSecurityOrigin::quota):
1817 (WebSecurityOrigin::setQuota):
1819 (WebView::initWithFrame):
1820 (WebView::notifyPreferencesChanged):
1822 2011-09-15 Kentaro Hara <haraken@google.com>
1824 A single line must not be split into two pages.
1825 https://bugs.webkit.org/show_bug.cgi?id=65005
1827 Reviewed by David Hyatt.
1829 When the document width of a page is overflowed, the last line of the page can be
1830 split into the next page. This is the regression caused by r88737. r88737 tried to
1831 fix rounding errors in rendering calculations by expanding and shrinking a page
1832 using one common method, resizePageRectsKeepingRatio(), but overlooked the case where
1833 a document width gets overflowed.
1835 Test: printing/single-line-must-not-be-split-into-two-pages.html
1838 (WebFrame::setPrinting): Passes an original page size to setPrinting().
1839 (WebFrame::setInPrintingMode): Ditto.
1842 2011-09-06 Ryosuke Niwa <rniwa@webkit.org>
1844 Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
1845 https://bugs.webkit.org/show_bug.cgi?id=67569
1847 Reviewed by Antonio Gomes.
1850 (WebView::resetIME):
1852 2011-08-29 Alexey Proskuryakov <ap@apple.com>
1854 DumpRenderTree should begin each test with an empty cookie store
1855 https://bugs.webkit.org/show_bug.cgi?id=63545
1856 <rdar://problem/5666907>
1858 Reviewed by Darin Adler.
1860 * WebCookieManagerCFNet.cpp:
1861 (WebCookieManager::cookieStorage):
1862 (WebCookieManager::setCookieStorage):
1863 Changed the API to work with new functions in WebCore. It's a bit ugly, because cookieStorage()
1864 returns an unretained reference, which we cannot provide any more, but it should not be a
1867 * WebView.cpp: (updateSharedSettingsFromPreferencesIfNeeded): Updated to use currentCFHTTPCookieStorage()
1868 instead of currentCookieStorage().
1870 2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
1872 The unused ScrollView* argument can and should be removed from
1874 https://bugs.webkit.org/show_bug.cgi?id=67117
1876 Reviewed by Darin Adler.
1878 * WebCoreSupport/WebChromeClient.h:
1879 (WebChromeClient::scrollRectIntoView):
1881 2011-08-29 Ryosuke Niwa <rniwa@webkit.org>
1883 Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
1884 https://bugs.webkit.org/show_bug.cgi?id=67152
1886 Reviewed by Darin Adler.
1888 Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
1889 to HTMLTextFormControlElement.
1891 * DOMHTMLClasses.cpp:
1892 (DOMHTMLInputElement::isUserEdited):
1893 (DOMHTMLTextAreaElement::isUserEdited):
1895 2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
1897 Unreviewed, rolling out r93987, r93992, r93995, r93998, and
1899 http://trac.webkit.org/changeset/93987
1900 http://trac.webkit.org/changeset/93992
1901 http://trac.webkit.org/changeset/93995
1902 http://trac.webkit.org/changeset/93998
1903 http://trac.webkit.org/changeset/93999
1904 https://bugs.webkit.org/show_bug.cgi?id=67147
1906 Many failing tests (Requested by ap on #webkit).
1908 * WebCookieManagerCFNet.cpp:
1909 (WebCookieManager::cookieStorage):
1910 (WebCookieManager::setCookieStorage):
1912 (updateSharedSettingsFromPreferencesIfNeeded):
1914 2011-08-29 Alexey Proskuryakov <ap@apple.com>
1919 (updateSharedSettingsFromPreferencesIfNeeded):
1920 Updated for new function name and signature: currentCFHTTPCookieStorage().
1922 2011-08-26 Alexey Proskuryakov <ap@apple.com>
1924 DumpRenderTree should begin each test with an empty cookie store
1925 https://bugs.webkit.org/show_bug.cgi?id=63545
1926 <rdar://problem/5666907>
1928 Reviewed by Darin Adler.
1930 * WebCookieManagerCFNet.cpp:
1931 (WebCookieManager::cookieStorage):
1932 (WebCookieManager::setCookieStorage):
1933 Changed the API to work with new functions in WebCore. It's a bit ugly, because cookieStorage()
1934 returns an unretained reference, which we cannot provide any more, but it should not be a
1937 2011-08-17 Adam Roben <aroben@apple.com>
1939 Make WebCore keep track of the current device scale factor
1941 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
1944 Reviewed by Darin Adler.
1946 * WebCoreSupport/WebChromeClient.cpp:
1947 * WebCoreSupport/WebChromeClient.h:
1948 Removed deviceScaleFactor.
1950 2011-08-15 Dmitry Titov <dimich@chromium.org>
1952 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
1953 https://bugs.webkit.org/show_bug.cgi?id=66165
1955 Reviewed by Darin Fisher.
1957 * WebCoreSupport/WebFrameLoaderClient.cpp:
1958 (WebFrameLoaderClient::transferLoadingResourceFromPage):
1959 * WebCoreSupport/WebFrameLoaderClient.h:
1961 2011-08-15 Adam Roben <aroben@apple.com>
1963 Touch a file to trigger a Windows build
1965 I'm trying to ferret out some issues with our Debug builder.
1967 * WebView.cpp: Sorted #includes.
1969 2011-08-10 Adam Roben <aroben@apple.com>
1971 Clear up scale factor terminology
1973 WebKit by and large deals with two scale factors: one intrinsic to the device on which the
1974 software is running, and one that is per-Page and can be controlled via API calls. This
1975 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
1976 code use those names. It should introduce no behavior changes.
1978 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
1981 Reviewed by Simon Fraser.
1983 * WebCoreSupport/WebChromeClient.cpp:
1984 * WebCoreSupport/WebChromeClient.h:
1986 2011-08-13 Dan Bernstein <mitz@apple.com>
1988 Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
1990 Reviewed by Joseph Pecoraro.
1992 * WebPreferenceKeysPrivate.h:
1994 2011-08-13 Dan Bernstein <mitz@apple.com>
1999 (WebView::notifyPreferencesChanged):
2001 2011-08-12 Dan Bernstein <mitz@apple.com>
2003 Add an option to automatically show tooltips (with the full text) over truncated text
2004 https://bugs.webkit.org/show_bug.cgi?id=66178
2006 Reviewed by Simon Fraser.
2008 * Interfaces/IWebPreferencesPrivate.idl: Added accessors.
2009 * WebPreferenceKeysPrivate.h: Defined a preference key.
2010 * WebPreferences.cpp:
2011 (WebPreferences::initializeDefaultSettings): Added a default value of
2012 false for the ShowsToolTipOverTruncatedText preference.
2013 (WebPreferences::showsToolTipOverTruncatedText): Added this getter.
2014 (WebPreferences::setShowsToolTipOverTruncatedText): Added this setter.
2017 (WebView::notifyPreferencesChanged): Added call to Settings::setShowsToolTipOverTruncatedText().
2019 2011-08-05 Brent Fulgham <bfulgham@webkit.org>
2021 WebView::performLayeredWindowUpdate() crashes with
2022 NULL pointer when using layered window updates.
2023 https://bugs.webkit.org/show_bug.cgi?id=60618
2025 Reviewed by Adam Roben.
2027 During resize operations, the backing store will be destroyed if
2028 the window's size (either height or width) is set to zero. The
2029 bug was identified when a user first resized a WebView to zero
2030 dimensions, then attempted to perform a MoveWindow. The paint
2031 message triggered by the MoveWindow attempted to use the layered
2032 window update logic, which encountered the nulled backing store.
2035 (WebView::performLayeredWindowUpdate): Add an early
2036 return when there is no backing store to blend with.
2038 2011-08-05 Anders Carlsson <andersca@apple.com>
2041 https://bugs.webkit.org/show_bug.cgi?id=65729
2043 Reviewed by Darin Adler.
2045 Remove plug-in halter and associated classes.
2047 * Interfaces/IWebPluginHalterDelegate.idl: Removed.
2048 * Interfaces/IWebPreferencesPrivate.idl:
2049 * Interfaces/IWebViewPrivate.idl:
2050 * Interfaces/WebKit.idl:
2051 * WebCoreSupport/WebPluginHalterClient.cpp: Removed.
2052 * WebCoreSupport/WebPluginHalterClient.h: Removed.
2053 * WebKit.vcproj/Interfaces.vcproj:
2054 * WebKit.vcproj/WebKit.vcproj:
2055 * WebPreferenceKeysPrivate.h:
2056 * WebPreferences.cpp:
2057 (WebPreferences::initializeDefaultSettings):
2061 (WebView::initWithFrame):
2062 (WebView::notifyPreferencesChanged):
2070 2011-08-04 Jeff Miller <jeffm@apple.com>
2072 Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
2073 https://bugs.webkit.org/show_bug.cgi?id=65718
2075 Reviewed by Adam Roben.
2077 * Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().
2079 * WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.
2081 * WebPreferences.cpp:
2082 (WebPreferences::avFoundationEnabled): Added.
2083 (WebPreferences::setAVFoundationEnabled): Added.
2085 * WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().
2088 (WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.
2090 2011-08-03 Kent Tamura <tkent@chromium.org>
2092 [Windows] Fix build without ENABLE_VIDEO.
2095 (WebView::enterFullscreenForNode):
2097 2011-08-03 Kent Tamura <tkent@chromium.org>
2099 Fix incorrect checks for HTMLMediaElement
2100 https://bugs.webkit.org/show_bug.cgi?id=65590
2102 Reviewed by Dimitri Glazkov.
2104 <video> and <audio> can be an HTMLElement instance instead of
2105 HTMLMediaElement if MediaPlayer::isAvailable() returns false or
2106 the media feature is disabled at runtime.
2109 (WebView::enterFullscreenForNode):
2111 2011-08-03 Joseph Pecoraro <joepeck@webkit.org>
2113 Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
2114 https://bugs.webkit.org/show_bug.cgi?id=65582
2116 Reviewed by Pavel Feldman.
2118 * WebCoreSupport/WebInspectorClient.cpp:
2119 * WebCoreSupport/WebInspectorClient.h:
2121 2011-08-03 Adam Roben <aroben@apple.com>
2123 Windows nightly build fix after r91777
2125 * Interfaces/IWebPreferences.idl: Moved [set]PictographFontFamily to the end of the
2126 interface to maintain binary compatibility with Safari 5.1.
2128 2011-08-03 Pavel Feldman <pfeldman@google.com>
2130 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
2131 https://bugs.webkit.org/show_bug.cgi?id=65510
2133 Reviewed by Yury Semikhatsky.
2135 * WebNodeHighlight.cpp:
2136 (WebNodeHighlight::update):
2138 2011-08-03 Pavel Feldman <pfeldman@chromium.org>
2140 Web Inspector: remove Node parameter from the InspectorClient::highlight
2141 https://bugs.webkit.org/show_bug.cgi?id=65549
2143 Reviewed by Yury Semikhatsky.
2145 * WebCoreSupport/WebInspectorClient.cpp:
2146 (WebInspectorClient::highlight):
2147 * WebCoreSupport/WebInspectorClient.h:
2149 2011-07-31 Daniel Bates <dbates@webkit.org>
2151 Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).
2153 * WebKit.vcproj/WebKit_Cairo.def: Export some symbols.
2154 * WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
2156 2011-07-30 Patrick Gansterer <paroga@webkit.org>
2158 Remove inclusion of MainThread.h from Threading.h
2159 https://bugs.webkit.org/show_bug.cgi?id=65081
2161 Reviewed by Darin Adler.
2163 Add missing include statements for MainThread.
2165 * WebKitClassFactory.cpp:
2168 2011-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org>
2170 Add support for download='filename' attribute in anchors.
2171 https://bugs.webkit.org/show_bug.cgi?id=64580
2173 Reviewed by Adam Barth.
2176 (WebFrame::startDownload):
2179 2011-07-26 Dan Bernstein <mitz@apple.com>
2181 <rdar://problem/9842889> Add a generic pictograph font family
2182 https://bugs.webkit.org/show_bug.cgi?id=65197
2184 Reviewed by Anders Carlsson.
2186 * Interfaces/IWebPreferences.idl: Added pictographFontFamily() and
2187 setPictographFontFamily().
2188 * WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
2189 * WebPreferences.cpp:
2190 (WebPreferences::initializeDefaultSettings): Initialize the pictograph font
2191 preference to "Times New Roman".
2192 (WebPreferences::pictographFontFamily): Added this getter.
2193 (WebPreferences::setPictographFontFamily): Added this setter.
2196 (WebView::notifyPreferencesChanged): Pass the preference value through to
2199 2011-07-18 Dean Jackson <dino@apple.com>
2201 https://bugs.webkit.org/show_bug.cgi?id=64742
2202 Expose WebPreferences for media playback requiring user gestures and inline playback
2204 Reviewed by Simon Fraser.
2206 Two new WebPreferences: MediaPlaybackRequiresUserGesture and
2207 MediaPlaybackAllowsInline.
2209 * Interfaces/IWebPreferencesPrivate.idl:
2210 * WebPreferenceKeysPrivate.h:
2211 * WebPreferences.cpp:
2212 (WebPreferences::initializeDefaultSettings):
2213 (WebPreferences::setMediaPlaybackRequiresUserGesture):
2214 (WebPreferences::mediaPlaybackRequiresUserGesture):
2215 (WebPreferences::setMediaPlaybackAllowsInline):
2216 (WebPreferences::mediaPlaybackAllowsInline):
2219 (WebView::notifyPreferencesChanged):
2221 2011-07-16 Simon Fraser <simon.fraser@apple.com>
2223 Add code to attempt to align compositing layers to pixel boundaries when page scale changes
2224 https://bugs.webkit.org/show_bug.cgi?id=64658
2226 Reviewed by Dan Bernstein.
2228 Removed implementations of backingScaleFactor() and pageScaleFactor() now
2229 that GraphicsLayerClient has default implementations.
2233 2011-07-15 Simon Fraser <simon.fraser@apple.com>
2238 (WebView::backingScaleFactor):
2239 (WebView::pageScaleFactor):
2241 2011-07-15 Dan Bernstein <mitz@apple.com>
2243 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
2244 https://bugs.webkit.org/show_bug.cgi?id=64615
2246 Reviewed by Anders Carlsson.
2248 * WebCoreSupport/WebChromeClient.cpp:
2249 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
2250 * WebCoreSupport/WebChromeClient.h:
2252 2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
2254 ApplicationCache update should not immediately fail when reaching per-origin quota
2255 https://bugs.webkit.org/show_bug.cgi?id=64177
2257 Reviewed by Alexey Proskuryakov.
2259 * WebCoreSupport/WebChromeClient.cpp:
2260 (WebChromeClient::reachedApplicationCacheOriginQuota):
2261 * WebCoreSupport/WebChromeClient.h:
2263 2011-07-11 Hironori Bono <hbono@chromium.org>
2265 Reviewed by Adam Roben.
2267 Implement layoutTestController.setTextDirection for WebKit2 and Windows.
2268 https://bugs.webkit.org/show_bug.cgi?id=61931
2270 This change implements layoutTextController.setTextDirection for WebKit2
2271 and Windows so we can run a layout test added by r87770 on them. Each
2272 implementation adds a wrapper function for Editor::setBaseWritingDirection()
2273 so LayoutTestController can call it.
2275 * Interfaces/IWebFramePrivate.idl: Added setTextDirection to allow
2276 LayoutTestController to change the text direction.
2277 * WebFrame.cpp: ditto.
2278 (WebFrame::setTextDirection):
2279 * WebFrame.h: ditto.
2281 2011-07-08 Chang Shu <cshu@webkit.org>
2283 Update calling sites after function renamed.
2284 https://bugs.webkit.org/show_bug.cgi?id=59114
2286 Reviewed by Alexey Proskuryakov.
2288 * WebKitGraphics.cpp:
2291 2011-06-30 Anders Carlsson <andersca@apple.com>
2293 Reviewed by Dan Bernstein.
2295 More ScrollableArea scaffolding
2296 https://bugs.webkit.org/show_bug.cgi?id=63678
2299 (WebScrollBar::enclosingScrollableArea):
2300 Always return 0, WebScrollbar has no concept of an enclosing scrollable area.
2302 2011-06-28 Ilya Sherman <isherman@chromium.org>
2304 Reviewed by Adam Barth.
2306 form.autocomplete="off" does not work
2307 https://bugs.webkit.org/show_bug.cgi?id=35823
2310 (WebFrame::elementDoesAutoComplete): Updated callsite.
2312 2011-06-27 Brent Fulgham <bfulgham@webkit.org>
2314 Reviewed by Adam Roben.
2316 Avoid attempt to create a zero-size DIB.
2317 https://bugs.webkit.org/show_bug.cgi?id=63484.
2319 * WebNodeHighlight.cpp:
2320 (WebNodeHighlight::update): Check for zero-height (or zero-width)
2321 region for DIB, and exit early if attempting to create a zero-size
2324 2011-06-24 Dan Bernstein <mitz@apple.com>
2326 Reviewed by Anders Carlsson.
2328 Add an option to enable legacy rounding hacks
2329 https://bugs.webkit.org/show_bug.cgi?id=63363
2331 * WebKitGraphics.cpp:
2332 (CenterTruncateStringToWidth): Enabled rounding hacks in the string truncator.
2333 (RightTruncateStringToWidth): Ditto.
2335 2011-06-24 Yuta Kitamura <yutak@chromium.org>
2337 Reviewed by Adam Barth.
2339 WebSocket: Add run-time flag for new HyBi protocol
2340 https://bugs.webkit.org/show_bug.cgi?id=60348
2342 Make a new flag (Setting::m_useHixie76WebSocketProtocol)
2343 switchable from WebView and WebPreferences.
2345 * Interfaces/IWebPreferencesPrivate.idl:
2346 * WebPreferenceKeysPrivate.h:
2347 * WebPreferences.cpp:
2348 (WebPreferences::initializeDefaultSettings):
2349 (WebPreferences::setHixie76WebSocketProtocolEnabled):
2350 (WebPreferences::hixie76WebSocketProtocolEnabled):
2353 (WebView::notifyPreferencesChanged):
2355 2011-06-22 Dominic Cooney <dominicc@chromium.org>
2357 Reviewed by Mark Rowe.
2359 Add window.internals to WebKit2's WebKitTestRunner.
2360 https://bugs.webkit.org/show_bug.cgi?id=61073
2362 * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
2364 2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
2366 Reviewed by Kent Tamura.
2368 FileChooser should be only created when we need to choose files.
2369 https://bugs.webkit.org/show_bug.cgi?id=63039
2371 * WebCoreSupport/WebChromeClient.cpp:
2372 (WebChromeClient::runOpenPanel): Changed to use settings.
2374 2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
2376 Unreviewed, rolling out r89354.
2377 http://trac.webkit.org/changeset/89354
2378 https://bugs.webkit.org/show_bug.cgi?id=63099
2380 Broke tests on Mac (Requested by rniwa on #webkit).
2382 * WebCoreSupport/WebInspectorClient.cpp:
2383 (WebInspectorClient::WebInspectorClient):
2384 (WebInspectorClient::openInspectorFrontend):
2385 (WebInspectorFrontendClient::destroyInspectorView):
2386 * WebCoreSupport/WebInspectorClient.h:
2388 (WebInspector::createInstance):
2389 (WebInspector::WebInspector):
2390 (WebInspector::webViewClosed):
2391 (WebInspector::showConsole):
2392 (WebInspector::isDebuggingJavaScript):
2393 (WebInspector::toggleDebuggingJavaScript):
2394 (WebInspector::isProfilingJavaScript):
2395 (WebInspector::toggleProfilingJavaScript):
2396 (WebInspector::isJavaScriptProfilingEnabled):
2397 (WebInspector::setJavaScriptProfilingEnabled):
2398 (WebInspector::isTimelineProfilingEnabled):
2399 (WebInspector::setTimelineProfilingEnabled):
2404 (WebView::initWithFrame):
2405 (WebView::inspector):
2408 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
2410 Reviewed by Yury Semikhatsky.
2412 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
2413 https://bugs.webkit.org/show_bug.cgi?id=62985
2415 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
2416 methods for plumbing the menu action handlers through the WebKit and WebCore.
2417 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
2418 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
2419 WebKit/win and WebKit2 to follow.
2422 (WebInspector::createInstance):
2423 (WebInspector::WebInspector):
2424 (WebInspector::webViewClosed):
2425 (WebInspector::showConsole):
2426 (WebInspector::isDebuggingJavaScript):
2427 (WebInspector::toggleDebuggingJavaScript):
2428 (WebInspector::isProfilingJavaScript):
2429 (WebInspector::toggleProfilingJavaScript):
2430 (WebInspector::isJavaScriptProfilingEnabled):
2431 (WebInspector::setJavaScriptProfilingEnabled):
2432 (WebInspector::isTimelineProfilingEnabled):
2433 (WebInspector::setTimelineProfilingEnabled):
2438 (WebView::initWithFrame):
2439 (WebView::inspector):
2442 2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
2444 Reviewed by Darin Adler.
2446 Separate concerns of loading file icons and choosing files.
2447 https://bugs.webkit.org/show_bug.cgi?id=62931
2449 * WebCoreSupport/WebChromeClient.cpp:
2450 (WebChromeClient::loadIconForFiles): Renamed.
2451 * WebCoreSupport/WebChromeClient.h:
2453 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
2455 Unreviewed, rolling out r89026.
2456 http://trac.webkit.org/changeset/89026
2457 https://bugs.webkit.org/show_bug.cgi?id=62804
2459 These patches were likely correct. I'll investigate the
2460 browser_test failures. (Requested by abarth on #webkit).
2462 * FullscreenVideoController.cpp:
2463 (FullscreenVideoController::play):
2464 (FullscreenVideoController::pause):
2466 2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
2470 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
2471 https://bugs.webkit.org/show_bug.cgi?id=62796
2473 The patches broke chromium browser tests.
2475 * FullscreenVideoController.cpp:
2476 (FullscreenVideoController::play):
2477 (FullscreenVideoController::pause):
2479 2011-06-16 Adam Barth <abarth@webkit.org>
2481 Reviewed by Eric Seidel.
2483 Remove HTMLVideoElement::processingUserGesture
2484 https://bugs.webkit.org/show_bug.cgi?id=62784
2486 * FullscreenVideoController.cpp:
2487 (FullscreenVideoController::play):
2488 (FullscreenVideoController::pause):
2490 2011-06-13 Kentaro Hara <haraken@google.com>
2492 Reviewed by Alexey Proskuryakov.
2494 Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
2495 https://bugs.webkit.org/show_bug.cgi?id=61256
2497 In order to prevent rounding error caused by expanding/shrinking a page
2498 using different calculation here and there, I added a common calculation
2499 method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
2500 keeping the ratio of width and height of the original page.
2501 WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
2502 expand/shrink a page.
2504 Test: printing/page-count-with-one-word.html
2507 (WebFrame::setPrinting):
2508 (WebFrame::setInPrintingMode):
2511 2011-06-12 MORITA Hajime <morrita@google.com>
2513 Unreviewed, rolling out r88625.
2514 http://trac.webkit.org/changeset/88625
2515 https://bugs.webkit.org/show_bug.cgi?id=61073
2517 Breaks SL Webkit2 Tests
2519 * WebKit.vcproj/WebKit.sln:
2521 2011-06-12 Adam Barth <abarth@webkit.org>
2523 Reviewed by Alexey Proskuryakov.
2525 Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
2526 https://bugs.webkit.org/show_bug.cgi?id=62516
2529 (WebFrame::interruptedForPolicyChangeError):
2532 2011-06-12 Dominic Cooney <dominicc@chromium.org>
2534 Reviewed by Hajime Morita.
2536 Add window.internals to WebKit2's WebKitTestRunner.
2537 https://bugs.webkit.org/show_bug.cgi?id=61073
2539 * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
2541 2011-06-12 Adam Barth <abarth@webkit.org>
2543 Reviewed by Alexey Proskuryakov.
2545 Remove trival "forward-to-client" member functions from FrameLoader
2546 https://bugs.webkit.org/show_bug.cgi?id=62510
2548 * WebCoreSupport/WebFrameNetworkingContext.cpp:
2549 (WebFrameNetworkingContext::blockedError):
2551 2011-06-06 Michael Saboff <msaboff@apple.com>
2553 Reviewed by Geoffrey Garen.
2555 Fonts returned by FontCache::getFontDataForCharacters() are never released
2556 https://bugs.webkit.org/show_bug.cgi?id=61875
2558 This change allows fonts allocated as system fallback fonts to be
2559 released. Previously, the reference counts for these fonts grew
2560 without bound. This is implemented as an auto release class that wraps
2561 accesses to the cache for system fallback fonts. All such accesses are
2562 via the method FontCache::getFontDataForCharacters. The new class is
2563 called FontCachePurgePreventer. When such an object exists, it protects
2564 these fonts from deletion.
2566 See more comments for this defect in Source/WebCore/ChangeLog.
2568 * WebKitGraphics.cpp:
2569 (CenterTruncateStringToWidth):
2570 (RightTruncateStringToWidth):
2571 Wrapped code accessing fallback fonts with local
2572 FontCachePurgePreventer in these methods.
2574 2011-06-04 Dominic Cooney <dominicc@chromium.org>
2576 Reviewed by Dimitri Glazkov.
2578 Add WebCoreTestSupport project containing window.internals.
2579 https://bugs.webkit.org/show_bug.cgi?id=61076
2581 * WebKit.vcproj/WebKit.sln:
2583 2011-05-18 Anthony Johnson <anthony.johnson@flexsim.com>
2585 Reviewed by Brent Fulgham.
2587 Implement the ability to add C++ event listeners to html dom
2588 elements and dom window.
2589 https://bugs.webkit.org/show_bug.cgi?id=60269
2591 * DOMCoreClasses.cpp: Add new DOMWindow class and implementations.
2592 (DOMNode::QueryInterface): Report that the DOMNode implements
2593 the IDomEventTarget interface.
2594 (DOMNode::addEventListener): Add implementation of a COM-based
2596 (DOMNode::removeEventListener):
2597 (DOMNode::dispatchEvent):
2598 (DOMDocument::createInstance):
2599 (DOMWindow::QueryInterface): New implementation.
2600 (DOMWindow::document): New implementation.
2601 (DOMWindow::getComputedStyle): Stub.
2602 (DOMWindow::getMatchedCSSRules): Stub.
2603 (DOMWindow::devicePixelRatio): Stub.
2604 (DOMWindow::addEventListener): New implementation.
2605 (DOMWindow::removeEventListener): New implementation.
2606 (DOMWindow::dispatchEvent): New implementation.
2607 (DOMWindow::DOMWindow): New implementation.
2608 (DOMWindow::~DOMWindow): New implementation.
2609 (DOMWindow::createInstance): New implementation.
2610 * DOMCoreClasses.h: Add new DOMWindow class and declarations.
2611 (DOMWindow::AddRef): New declaration.
2612 (DOMWindow::Release): New declaration.
2613 (DOMWindow::throwException): New declaration.
2614 (DOMWindow::callWebScriptMethod): New declaration.
2615 (DOMWindow::evaluateWebScript): New declaration.
2616 (DOMWindow::removeWebScriptKey): New declaration.
2617 (DOMWindow::stringRepresentation): New declaration.
2618 (DOMWindow::webScriptValueAtIndex): New declaration.
2619 (DOMWindow::setWebScriptValueAtIndex): New declaration.
2620 (DOMWindow::setException): New declaration.
2621 (DOMWindow::window): New declaration.
2622 * DOMEventsClasses.cpp: Add new WebEventListener and implementation.
2623 (DOMEventListener::handleEvent): New implementation.
2624 (WebEventListener::WebEventListener): New implementation.
2625 (WebEventListener::~WebEventListener): New implementation.
2626 (WebEventListener::operator==): New implementation.
2627 (WebEventListener::handleEvent): New implementation.
2628 (WebEventListener::create): New implementation.
2629 * DOMEventsClasses.h: Add new WebEventListener class declaration.
2630 * Interfaces/IWebFrame.idl: Add new DOMWindow accessor to the
2631 main Web Frame interface.
2632 * WebFrame.cpp: Add implementation of new DOMWindow creation method.
2633 (WebFrame::DOMWindow):
2634 * WebFrame.h: Add DOMWindow declaration.
2636 2011-05-20 Simon Fraser <simon.fraser@apple.com>
2638 Reviewed by Sam Weinig.
2640 numberOfActiveAnimations() can include animations from documents in the page cache
2641 https://bugs.webkit.org/show_bug.cgi?id=53641
2643 Pass the Frame's document as the one to count animations on.
2646 (WebFrame::numberOfActiveAnimations):
2648 2011-05-20 Jer Noble <jer.noble@apple.com>
2650 Reviewed by Maciej Stachowiak.
2652 Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
2653 https://bugs.webkit.org/show_bug.cgi?id=61108
2656 (WebView::fullScreenClientForceRepaint): Repaint the view and immediately notify the
2657 full screen controller.
2660 2011-05-13 Jon Lee <jonlee@apple.com>
2662 Reviewed by Simon Fraser.
2664 Can't horizontally scroll iframes and overflow because wheel events are always accepted
2665 https://bugs.webkit.org/show_bug.cgi?id=60779
2667 * WebCoreSupport/WebChromeClient.h:
2668 (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
2669 (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
2671 2011-05-13 Sam Weinig <sam@webkit.org>
2673 Reviewed by Anders Carlsson.
2675 Prune #includes from FrameView.h (Part 2)
2676 https://bugs.webkit.org/show_bug.cgi?id=60748
2678 - Update files that were depending on FrameView.h #including Frame.h or
2681 * WebCoreSupport/WebChromeClient.cpp:
2682 * WebCoreSupport/WebDragClient.cpp:
2683 * WebCoreSupport/WebFrameLoaderClient.cpp:
2685 (WebFrame::setPrinting):
2688 2011-05-12 Patrick Gansterer <paroga@webkit.org>
2690 Reviewed by Adam Barth.
2692 Enable OwnPtr strict mode in PluginHalter
2693 https://bugs.webkit.org/show_bug.cgi?id=60681
2696 (WebView::initWithFrame):
2698 2011-05-12 Adam Roben <aroben@apple.com>
2700 A little gtest cleanup after r86287
2702 * WebKit.vcproj/WebKit.sln:
2703 - Move gtest into the Tools folder
2704 - Make gtest build just before TestWebKitAPIGenerated
2705 - Use gtest's new Debug_All and Production configurations as appropriate
2707 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
2709 Reviewed by Darin Adler.
2711 String operator+ reallocates unnecessarily when concatting > 2 strings
2712 https://bugs.webkit.org/show_bug.cgi?id=58420
2714 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
2716 * AccessibleBase.cpp:
2717 (AccessibleBase::get_accKeyboardShortcut): Explicitely cast to Strings first, so operator BString() can be invoked.
2719 2011-05-11 Dmitry Lomov <dslomov@google.com>
2721 Reviewed by David Levin.
2723 https://bugs.webkit.org/show_bug.cgi?id=59561
2724 Switch TestWebKitAPI to GTest
2726 Fixes Makefiles and WinCairo build as well
2728 * WebKit.vcproj/WebKit.sln:
2730 2011-05-11 Jessie Berlin <jberlin@apple.com>
2732 Reviewed by Steve Falkenburg.
2734 [Windows WebKit2] Use cookies set in WebKit1
2735 https://bugs.webkit.org/show_bug.cgi?id=60274
2738 (WebView::setCacheModel):
2739 Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
2741 2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
2743 Unreviewed, rolling out r86255.
2744 http://trac.webkit.org/changeset/86255
2745 https://bugs.webkit.org/show_bug.cgi?id=60660
2747 REGRESSION (r86255): Lots of tests crashing in
2748 CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
2749 (WebKit2 Tests) (Requested by aroben on #webkit).
2752 (WebView::setCacheModel):
2754 2011-05-11 Jessie Berlin <jberlin@apple.com>
2756 Reviewed by Steve Falkenburg.
2758 [Windows WebKit2] Use cookies set in WebKit1
2759 https://bugs.webkit.org/show_bug.cgi?id=60274
2762 (WebView::setCacheModel):
2763 Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
2765 2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
2767 Unreviewed, rolling out r86108.
2768 http://trac.webkit.org/changeset/86108
2769 https://bugs.webkit.org/show_bug.cgi?id=60533
2771 Broke makefile based builds and Cairo (Requested by weinig on
2774 * WebKit.vcproj/WebKit.sln:
2776 2011-05-09 Dmitry Lomov <dslomov@google.com>
2778 Reviewed by Sam Weinig.
2780 Switch TestWebKitAPI to GTest
2781 https://bugs.webkit.org/show_bug.cgi?id=59561
2783 * WebKit.vcproj/WebKit.sln:
2785 2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
2787 Unreviewed, rolling out r86016.
2788 http://trac.webkit.org/changeset/86016
2789 https://bugs.webkit.org/show_bug.cgi?id=60445
2791 caused crashes on the WK2 Windows bots (Requested by
2792 jessieberlin on #webkit).
2795 (WebView::setCacheModel):
2797 2011-05-07 Jessie Berlin <jberlin@apple.com>
2799 Reviewed by Steve Falkenburg.
2801 [Windows WebKit2] Use cookies set in WebKit1
2802 https://bugs.webkit.org/show_bug.cgi?id=60274
2805 (WebView::setCacheModel):
2806 Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
2808 2011-05-06 Adam Roben <aroben@apple.com>
2810 Touch WebKit.idl to fix the build
2812 I needed this on my own machine. Maybe others will need it, too.
2814 * Interfaces/WebKit.idl:
2816 2011-05-04 Philippe Normand <pnormand@igalia.com>
2818 Reviewed by Dimitri Glazkov.
2820 Implement LayoutTestController::pseudoShadowId()
2821 https://bugs.webkit.org/show_bug.cgi?id=60034
2823 * DOMCoreClasses.cpp:
2824 (DOMElement::shadowPseudoId):
2827 2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
2829 Reviewed by Eric Seidel.
2831 Rename SelectionController to FrameSelection
2832 https://bugs.webkit.org/show_bug.cgi?id=60234
2836 2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
2838 Windows build fix attempt after r85823
2840 * WebCoreSupport/WebChromeClient.h:
2841 (WebChromeClient::webView):
2845 2011-05-04 Cris Neckar <cdn@chromium.org>
2847 Reviewed by Adam Barth.
2849 Expose WebView directly through ChromeClient.
2850 https://bugs.webkit.org/show_bug.cgi?id=49902
2852 * WebCoreSupport/WebChromeClient.h:
2853 (WebChromeClient::webView):
2855 2011-05-04 Tao Bai <michaelbai@chromium.org>
2857 Reviewed by David Kilzer.
2859 Populate touch-icon url to FrameLoaderClient
2860 https://bugs.webkit.org/show_bug.cgi?id=59143
2862 Respect the interface change in FrameLoaderClient.
2864 * WebCoreSupport/WebFrameLoaderClient.cpp:
2865 (WebFrameLoaderClient::dispatchDidChangeIcons):
2866 * WebCoreSupport/WebFrameLoaderClient.h:
2868 2011-05-02 Jer Noble <jer.noble@apple.com>
2870 Reviewed by Adam Roben.
2872 Implement FULLSCREEN_API on Windows, Part 3: WebKit2
2873 https://bugs.webkit.org/show_bug.cgi?id=59845
2875 Implementation of WebFullScreenController has been moved into WebCore, and
2876 required virutal functions of WebFullScreenControllerClient have been added to
2877 WebView. These functions are mostly simple accessors of existing ivars, but
2878 m_fullScreenElement and its accessors have also been added to WebView.
2880 * WebCoreSupport/WebChromeClient.cpp:
2881 (WebChromeClient::enterFullScreenForElement):
2882 * WebFullScreenController.cpp: Removed.
2883 * WebKit.vcproj/WebKit.vcproj:
2885 (WebView::setFullScreenElement): Added accessor.
2886 (WebVIew::fullScreenElement): Ditto.
2887 (WebView::fullScreenClientWindow): Ditto.
2888 (WebView::fullScreenClientParentWindow): Ditto.
2889 (WebView::fullScreenClientSetParentWindow): Ditto.
2890 (WebView::fullScreenClientWillEnterFullScreen): Pass through to Document.
2891 (WebView::fullScreenClientDidEnterFullScreen): Ditto.
2892 (WebView::fullScreenClientWillExitFullScreen): Ditto.
2893 (WebView::fullScreenClientDidExitFullScreen): Ditto.
2896 2011-05-03 Brian Weinstein <bweinstein@apple.com>
2898 Reviewed by Steve Falkenburg.
2900 REGRESSION(r84990): Nightly builds don't launch on Windows
2901 https://bugs.webkit.org/show_bug.cgi?id=60081
2902 <rdar://problem/9358635>
2904 Fix nightlies on Window by moving the layered window functions to the bottom
2905 of IWebViewPrivate and touch WebKit.idl to make sure Interfaces rebuild.
2907 * Interfaces/IWebViewPrivate.idl: Move functions added in r84990 to the bottom of the file.
2908 * Interfaces/WebKit.idl: Touch to force a rebuild.
2910 2011-05-03 David Kilzer <ddkilzer@apple.com>
2912 <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
2914 Reviewed by Antti Koivisto.
2916 * Interfaces/IWebViewPrivate.idl:
2917 (IWebViewPrivate::httpPipeliningEnabled): Added declaration.
2918 (IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.
2920 (WebView::httpPipeliningEnabled): Added.
2921 (WebView::setHTTPPipeliningEnabled): Added.
2923 (WebView::httpPipeliningEnabled): Added declaration.
2924 (WebView::setHTTPPipeliningEnabled): Added declaration.
2926 2011-05-03 Adam Roben <aroben@apple.com>
2928 Add some missing virtual keywords on derived-class destructors
2930 Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
2931 just matches our style of explicitly marking overrides "virtual".
2933 * WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and
2934 WebInspectorFrontendClient destructors explicitly virtual.
2936 2011-05-03 Adam Roben <aroben@apple.com>
2938 Fix most strict PassOwnPtr violations on Windows
2940 Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
2943 Reviewed by Anders Carlsson.
2945 * WebCoreSupport/WebInspectorClient.h: Made the destructor public, which is required now
2946 that this type is put into a PassOwnPtr. (Previously, only
2947 WebCore::InspectorFrontendClientLocal was put into a [Pass]OwnPtr.)
2949 * FullscreenVideoController.cpp:
2950 * WebCoreSupport/WebFrameLoaderClient.cpp:
2951 * WebCoreSupport/WebInspectorClient.cpp:
2953 * WebHistoryItem.cpp:
2956 2011-05-01 Sam Weinig <sam@webkit.org>
2962 2011-05-01 Patrick Gansterer <paroga@webkit.org>
2964 Reviewed by Adam Barth.
2966 Fix OwnPtr strict issues in windows build
2967 https://bugs.webkit.org/show_bug.cgi?id=59878
2969 * FullscreenVideoController.cpp:
2970 (FullscreenVideoController::FullscreenVideoController):
2971 (FullscreenVideoController::createHUDWindow):
2972 * WebCoreSupport/WebInspectorClient.cpp:
2973 (WebInspectorClient::highlight):
2974 * WebElementPropertyBag.cpp:
2975 (WebElementPropertyBag::WebElementPropertyBag):
2976 * WebNodeHighlight.cpp:
2977 (WebNodeHighlight::update):
2978 * WebNotificationCenter.cpp:
2979 (WebNotificationCenter::WebNotificationCenter):
2983 (WebView::handleMouseEvent):
2984 (WebView::registerEmbeddedViewMIMEType):
2986 2011-04-29 Jer Noble <jer.noble@apple.com>
2988 Reviewed by Adam Roben.
2990 Implement FULLSCREEN_API on Windows, Part 2: WebKit
2991 https://bugs.webkit.org/show_bug.cgi?id=59785
2993 Initial implementation of full screen API on windows. No animation
2994 occurs when entering or exiting full screen. Re-use existing window
2995 classes (MediaPlayerPrivateFullscreenWindow) to host the webView.
2997 * WebCoreSupport/WebChromeClient.cpp:
2998 (WebChromeClient::supportsFullScreenForElement): Call into WebView.
2999 (WebChromeClient::enterFullScreenForElement): Call into WebFullScreenController.
3000 (WebChromeClient::exitFullScreenForElement): Ditto.
3001 * WebFullScreenController.cpp: Added.
3002 (WebFullScreenController::Private::Private): Private data storage class.
3003 (WebFullScreenController::Private::~Private):
3004 (WebFullScreenController::Private::fullscreenClientWndProc): Handle window
3005 message for full screen window.
3006 (WebFullScreenController::WebFullScreenController):
3007 (WebFullScreenController::~WebFullScreenController):
3008 (WebFullScreenController::setElement): Added.
3009 (WebFullScreenController::element): Added.
3010 (WebFullScreenController::isFullScreen): Added.
3011 (WebFullScreenController::enterFullScreen): Create and display full screen
3012 window, moving webView as child window.
3013 (WebFullScreenController::exitFullScreen): Destroy full screen window and
3014 move webView back where we found it.
3015 * WebFullScreenController.h: Added.
3016 * WebKit.vcproj/WebKit.vcproj:
3018 (WebView::keyDown): Handle the ESC key.
3019 (WebView::notifyPreferencesChanged):
3020 (WebView::supportsFullScreenForElement): Do not support full screen if
3021 full screen preference is disabled, or if keyboard access is requested.
3022 (WebView::isFullScreen): Added.
3023 (WebView::fullScreenController): Added.
3026 2011-04-28 Jer Noble <jer.noble@apple.com>
3028 Reviewed by Jon Honeycutt.
3030 Implement FULLSCREEN_API on Windows, Part 1: Stubs
3031 https://bugs.webkit.org/show_bug.cgi?id=59778
3033 Create all the stubs necessary to for enabling FULLSCREEN_API
3034 on Windows. This includes the COM interfaces for preferences and
3035 for overriding full screen behavior in a UI Delegate.
3037 * Interfaces/IWebPreferencesPrivate.idl: Add functions for enabling
3038 full screen preference.
3039 * Interfaces/IWebUIDelegatePrivate.idl: Add functions for overriding
3040 full screen behavior.
3041 * WebCoreSupport/WebChromeClient.cpp:
3042 (WebChromeClient::supportsFullScreenForElement): Added.
3043 (WebChromeClient::enterFullScreenForElement): Added.
3044 (WebChromeClient::exitFullScreenForElement): Added.
3045 * WebCoreSupport/WebChromeClient.h:
3046 * WebPreferenceKeysPrivate.h: Added WebKitFullScreenEnable key.
3047 * WebPreferences.cpp:
3048 (WebPreferences::isFullScreenEnabled): Added. Implements function
3049 defined in IWebUIDelegatePrivate.
3050 (WebPreferences::setFullScreenEnabled): Ditto.
3053 2011-04-28 Adam Barth <abarth@webkit.org>
3055 Reviewed by Eric Seidel.
3058 https://bugs.webkit.org/show_bug.cgi?id=59678
3060 Remove WML-related enumeration.
3062 * Interfaces/IWebFramePrivate.idl:
3064 2011-04-26 Brent Fulgham <bfulgham@webkit.org>
3066 Reviewed by Adam Roben.
3068 Implement a transparent WebView under Windows. This feature
3069 allows the user to create small web-based applications, similar
3070 to the dashboard on Mac OS X.
3071 https://bugs.webkit.org/show_bug.cgi?id=58300
3073 * Interfaces/IWebViewPrivate.idl: Add new set/get accessors to
3074 change the state of a WebView into a Layered Window, or back
3075 into a standard window.
3076 * Interfaces/WebKit.idl: touch to force clean build
3078 (WebView::WebView): Set layered window state in constructor.
3079 (WebView::updateBackingStore): Cleanup old bitmap when finished.
3080 (WebView::performLayeredWindowUpdate): New method to do the work
3081 of calling ::UpdateLayeredWindow for the WebView with proper
3083 (WebView::paint): Small change to prevent accelerated compositing
3084 when using a layered window. DirectX is not compatible with
3085 ::UpdateLayeredWindow (at least currently).
3086 (WebView::WebViewWndProc): Adjust main window procedure to avoid
3087 painting a default background on a layered window (this is handled
3088 by Windows during compositing), and to deal with paint messages
3089 properly in the layered window case.
3090 (WebView::active): The layered window is not a child window,
3091 so the active state logic is slightly different.
3092 (WebView::setUsesLayeredWindow): New set method for layered stated.
3093 When called, it will convert a WebView into a Layered Window.
3094 (WebView::usesLayeredWindow): Accessor
3096 (WebView::setUsesLayeredWindow): Declare new accessor
3097 (WebView::usesLayeredWindow): Declare new accessor
3099 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
3103 * WebCoreSupport/WebEditorClient.h:
3105 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
3107 Reviewed by Sam Weinig.
3109 Add Frame* to the argument lists of canCopyCut and canPaste
3110 https://bugs.webkit.org/show_bug.cgi?id=59153
3112 * WebCoreSupport/WebEditorClient.cpp:
3113 (WebEditorClient::canCopyCut):
3114 (WebEditorClient::canPaste):
3115 * WebCoreSupport/WebEditorClient.h:
3117 2011-04-20 Brent Fulgham <bfulgham@webkit.org>
3119 Reviewed by Martin Robinson.
3121 Provide missing implementation of WebMutableURLRequest::mutableCopy.
3122 This was preventing DumpRenderTree from working properly under
3124 https://bugs.webkit.org/show_bug.cgi?id=59034
3126 * WebMutableURLRequest.cpp:
3127 (WebMutableURLRequest::mutableCopy): Implement cURL version of the
3130 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
3132 Reviewed by Pavel Feldman.
3134 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
3135 https://bugs.webkit.org/show_bug.cgi?id=58883
3137 * WebCoreSupport/WebFrameLoaderClient.h:
3139 2011-04-18 Timothy Hatcher <timothy@apple.com>
3141 Remove the two commands that make en.lproj and copy Localizable.strings.
3143 Rubber-stamped by Adam Roben.
3145 * WebKit.vcproj/WebKitLibPostBuild.cmd:
3147 2011-04-18 Patrick Gansterer <paroga@webkit.org>
3149 Reviewed by Adam Roben.
3151 Include <WebCore/COMPtr.h> instead of "COMPtr.h"
3152 https://bugs.webkit.org/show_bug.cgi?id=58744
3154 * DOMCoreClasses.cpp:
3155 * DOMHTMLClasses.cpp:
3156 * WebActionPropertyBag.cpp:
3157 * WebBackForwardList.cpp:
3158 * WebCoreSupport/WebGeolocationClient.h:
3162 * WebHistoryItem.cpp:
3163 * WebIconDatabase.cpp:
3164 * WebNavigationData.h:
3165 * WebPreferences.cpp:
3167 * WebURLAuthenticationChallenge.cpp:
3168 * WebURLAuthenticationChallengeSender.cpp:
3169 * WebURLAuthenticationChallengeSenderCFNet.cpp:
3170 * WebURLAuthenticationChallengeSenderCurl.cpp:
3173 2011-04-17 Patrick Gansterer <paroga@webkit.org>
3175 Reviewed by Adam Barth.
3177 Rename PLATFORM(CG) to USE(CG)
3178 https://bugs.webkit.org/show_bug.cgi?id=58729
3181 (WebFrame::spoolPages):
3183 * WebPreferences.cpp:
3184 (WebPreferences::setFontSmoothing):
3185 (WebPreferences::setFontSmoothingContrast):
3187 (systemParameterChanged):
3189 2011-04-16 Sam Weinig <sam@webkit.org>
3191 Reviewed by Simon Fraser.
3193 Windows should use WebCore localized strings
3194 <rdar://problem/9119405>
3195 https://bugs.webkit.org/show_bug.cgi?id=58733
3197 * WebCoreSupport/WebEditorClient.cpp:
3198 (undoNameForEditAction):
3199 (WebEditorClient::registerCommandForUndo):
3200 * WebPreferences.cpp:
3201 (WebPreferences::initializeDefaultSettings):
3202 * WebURLResponse.cpp:
3203 (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode):
3204 (WebURLResponse::localizedStringForStatusCode):
3205 Change to use WEB_UI_STRING.
3207 * WebCoreSupport/WebPlatformStrategies.cpp:
3208 * WebCoreSupport/WebPlatformStrategies.h:
3209 Remove the localization strategy in favor of using the default one.
3211 2011-04-16 Patrick Gansterer <paroga@webkit.org>
3213 Reviewed by Eric Seidel.
3215 Rename PLATFORM(CAIRO) to USE(CAIRO)
3216 https://bugs.webkit.org/show_bug.cgi?id=55192
3219 (WebFrame::spoolPages):
3222 2011-04-14 Adam Roben <aroben@apple.com>
3224 Replace some known-to-fail assertions with FIXMEs
3226 These assertions get hit during various layout tests. They indicate that we're sometimes
3227 doing some extra work when a page goes into accelerated compositing mode, but otherwise
3228 there's no bad effect.
3230 See <http://webkit.org/b/58539> for more details.
3232 Rubber-stamped by John Sullivan.
3235 (WebView::paintIntoBackingStore):
3236 (WebView::paintIntoWindow):
3237 Replaced assertions with FIXMEs.
3239 2011-04-13 James Robinson <jamesr@chromium.org>
3241 Reviewed by Simon Fraser.
3243 Allow setting composited backing stores for scrollbars and scroll corners
3244 https://bugs.webkit.org/show_bug.cgi?id=57202
3246 Update WebScrollBar to reflect ScrollableArea interface changes.
3249 (WebScrollBar::invalidateScrollCornerRect):
3250 (WebScrollBar::scrollCornerPresent):
3251 (WebScrollBar::scrollCornerRect):
3253 2011-04-12 Alice Liu <alice.liu@apple.com>
3255 Reviewed by Sam Weinig.
3257 https://bugs.webkit.org/show_bug.cgi?id=58292
3258 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
3260 * Interfaces/IWebPreferencesPrivate.idl: Added prefs.
3261 * Interfaces/WebKit.idl: Touch file to force autogeneration
3262 * WebPreferenceKeysPrivate.h: Add preference key.
3263 * WebPreferences.cpp:
3264 (WebPreferences::initializeDefaultSettings): Initialize setting to false.
3265 (WebPreferences::setLoadsSiteIconsIgnoringImageLoadingPreference): Added setter
3266 (WebPreferences::loadsSiteIconsIgnoringImageLoadingPreference): Added getter
3269 (WebView::notifyPreferencesChanged): Add to settings that get propagated upon changes.
3271 2011-04-11 Alexey Proskuryakov <ap@apple.com>
3273 Reviewed by Maciej Stachowiak.
3275 WebKit2: Cannot use Ctrl-Delete as a custom keyboard shortcut
3276 https://bugs.webkit.org/show_bug.cgi?id=58265
3277 <rdar://problem/9221468>
3279 * WebView.cpp: (WebView::keyDown): Removed special handling of Backspace, which is unnecessary
3280 now that WebCore implements it.
3282 2011-04-06 Brian Weinstein <bweinstein@apple.com>
3284 Reviewed by Adam Roben.
3286 WebKit2: Support Windows 7 Gestures
3287 https://bugs.webkit.org/show_bug.cgi?id=49824
3288 <rdar://problem/8689728>
3290 Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
3291 used in both WebKit and WebKit2.
3293 * WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
3294 * WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
3295 * WindowsTouch.h: Removed.
3297 2011-04-05 Martin Robinson <mrobinson@igalia.com>
3299 Reviewed by Eric Seidel.
3301 [Cairo] Better separate the concerns of GraphicsContextCairo
3302 https://bugs.webkit.org/show_bug.cgi?id=55150
3305 (hdcFromContext): Modify this method to take PlatformContextCairo
3306 instead of a cairo_t.
3307 (WebFrame::spoolPage): Update to reflect new platform context.
3308 (WebFrame::spoolPages): Ditto.
3309 * WebFrame.h: Ditto.
3311 2011-04-04 MORITA Hajime <morrita@google.com>
3313 Reviewed by Ryosuke Niwa.
3315 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
3316 https://bugs.webkit.org/show_bug.cgi?id=56085
3318 * WebCoreSupport/WebEditorClient.h:
3319 (WebEditorClient::requestCheckingOfString):
3321 2011-04-04 Alexey Proskuryakov <ap@apple.com>
3323 Reviewed by Dan Bernstein.
3325 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
3326 https://bugs.webkit.org/show_bug.cgi?id=51230
3327 <rdar://problem/8780989>
3329 * WebView.cpp: (WebView::keyDown): Moved Caps Lock handling from WebKits to WebCore,
3330 because WebKit shouldn't be smart.
3332 2011-04-04 Steve Falkenburg <sfalken@apple.com>
3334 Reviewed by Adam Roben.
3336 Remove unused AnalyzeWithLargeStack code from Windows build files
3337 https://bugs.webkit.org/show_bug.cgi?id=57771
3339 This was used for us to build with prefast automatically,
3340 but it is out-of-date and hasn't been used for some time.
3341 Removing completely for now.
3343 * WebKit.vcproj/WebKitLibPreBuild.cmd:
3345 2011-04-01 Adam Roben <aroben@apple.com>
3347 Remove the WebView's "this" pointer from its HWND when WM_DESTROY is received
3349 This will ensure we don't try to process any window messages after the window has been
3352 Covered by existing tests.
3354 Fixes <http://webkit.org/b/55054>.
3356 Reviewed by Steve Falkenburg and John Sullivan.
3359 (WebView::setIsBeingDestroyed): Moved here from the header file, and added a call to clear
3360 out the this pointer from the HWND.
3361 (WebView::WebViewWndProc): Changed a runtime check into an assertion.
3363 * WebView.h: Moved setIsBeingDestroyed from here to the .cpp file.
3365 2011-03-31 Evan Martin <evan@chromium.org>
3367 Reviewed by Eric Seidel.
3369 <title> should support dir attribute
3370 https://bugs.webkit.org/show_bug.cgi?id=50961
3372 Update to new FrameLoaderClient interface.
3374 * WebCoreSupport/WebFrameLoaderClient.cpp:
3375 (WebFrameLoaderClient::dispatchDidReceiveTitle):
3376 * WebCoreSupport/WebFrameLoaderClient.h:
3378 2011-03-30 Steve Falkenburg <sfalken@apple.com>
3380 Reviewed by Adam Roben.
3382 Share most vsprops between Release and Production builds in releaseproduction.vsprops
3383 https://bugs.webkit.org/show_bug.cgi?id=57508
3385 * WebKit.vcproj/InterfacesProduction.vsprops:
3386 * WebKit.vcproj/InterfacesRelease.vsprops:
3387 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
3388 * WebKit.vcproj/WebKitGUIDProduction.vsprops:
3389 * WebKit.vcproj/WebKitGUIDRelease.vsprops:
3390 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
3391 * WebKit.vcproj/WebKitLibProduction.vsprops:
3392 * WebKit.vcproj/WebKitLibRelease.vsprops:
3393 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:
3395 2011-03-30 Steve Falkenburg <sfalken@apple.com>
3397 Reviewed by Adam Roben.
3399 Update Windows production build logic for new production configurations
3400 https://bugs.webkit.org/show_bug.cgi?id=57494
3402 * WebKit.vcproj/InterfacesProduction.vsprops:
3403 * WebKit.vcproj/WebKit.make:
3404 * WebKit.vcproj/WebKitGUIDProduction.vsprops:
3405 * WebKit.vcproj/WebKitLibProduction.vsprops:
3407 2011-03-30 Steve Falkenburg <sfalken@apple.com>
3409 Reviewed by Adam Roben.
3411 Rename Windows configuration Release_LTCG to Production for clarity
3412 https://bugs.webkit.org/show_bug.cgi?id=57465
3414 * WebKit.vcproj/Interfaces.vcproj:
3415 * WebKit.vcproj/InterfacesProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/InterfacesReleaseLTCG.vsprops.
3416 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Removed.
3417 * WebKit.vcproj/WebKit.sln:
3418 * WebKit.vcproj/WebKit.submit.sln:
3419 * WebKit.vcproj/WebKit.vcproj:
3420 * WebKit.vcproj/WebKitGUID.vcproj:
3421 * WebKit.vcproj/WebKitGUIDProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops.
3422 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Removed.
3423 * WebKit.vcproj/WebKitLibProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitLibReleaseLTCG.vsprops.
3424 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Removed.
3426 2011-03-29 Patrick Gansterer <paroga@webkit.org>
3428 Reviewed by Adam Roben.
3430 [WIN] Remove unused GEN_DOMObject files
3431 https://bugs.webkit.org/show_bug.cgi?id=57370
3433 * GEN_DOMObject.cpp: Removed.
3434 * GEN_DOMObject.h: Removed.
3436 2011-03-29 Steve Falkenburg <sfalken@apple.com>
3440 * WebCoreSupport/WebPlatformStrategies.h:
3442 2011-03-29 Steve Falkenburg <sfalken@apple.com>
3446 * WebCoreSupport/WebPlatformStrategies.cpp:
3447 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
3449 2011-03-29 Patrick Gansterer <paroga@webkit.org>
3451 Unreviewed. Try to fix Windows build.
3453 * DOMEventsClasses.cpp: Added initguid.h again.
3455 2011-03-29 Patrick Gansterer <paroga@webkit.org>
3457 Reviewed by Adam Roben.
3459 [WIN] Cleanup includes in WebKit files
3460 https://bugs.webkit.org/show_bug.cgi?id=57381
3462 Add missing includes to fix build without precompiled header.
3463 Also fix paths in #include statements (e.g. WTF -> wtf).
3466 * AccessibleDocument.h: Replace using statement with a qualified name.
3467 * CFDictionaryPropertyBag.h:
3468 * DOMEventsClasses.cpp:
3470 * DefaultDownloadDelegate.cpp:
3471 * DefaultDownloadDelegate.h:
3472 * DefaultPolicyDelegate.cpp:
3473 * DefaultPolicyDelegate.h:
3474 * WebCoreSupport/EmbeddedWidget.h:
3475 * WebCoreSupport/WebInspectorDelegate.h:
3477 * WebDatabaseManager.h:
3478 * WebElementPropertyBag.h:
3479 * WebFramePolicyListener.h:
3480 * WebGeolocationPolicyListener.h:
3482 * WebKitClassFactory.h:
3484 * WebSerializedJSValue.h:
3485 * WebUserContentURLPattern.h:
3487 2011-03-29 Steve Falkenburg <sfalken@apple.com>
3489 Reviewed by Darin Adler.
3491 Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
3492 https://bugs.webkit.org/show_bug.cgi?id=57383
3494 Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
3495 InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
3496 the IDE. To avoid this, add a separate vsprops file for each project configuration that
3497 contains the required inherited property sheets.
3499 * WebKit.vcproj/Interfaces.vcproj:
3500 * WebKit.vcproj/InterfacesDebug.vsprops: Added.
3501 * WebKit.vcproj/InterfacesDebugAll.vsprops: Added.
3502 * WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops: Added.
3503 * WebKit.vcproj/InterfacesRelease.vsprops: Added.
3504 * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: Added.
3505 * WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Added.
3506 * WebKit.vcproj/WebKit.vcproj:
3507 * WebKit.vcproj/WebKitGUID.vcproj:
3508 * WebKit.vcproj/WebKitGUIDDebug.vsprops: Added.
3509 * WebKit.vcproj/WebKitGUIDDebugAll.vsprops: Added.
3510 * WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops: Added.
3511 * WebKit.vcproj/WebKitGUIDRelease.vsprops: Added.
3512 * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: Added.
3513 * WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Added.
3514 * WebKit.vcproj/WebKitLibDebug.vsprops: Added.
3515 * WebKit.vcproj/WebKitLibDebugAll.vsprops: Added.
3516 * WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Added.
3517 * WebKit.vcproj/WebKitLibRelease.vsprops: Added.
3518 * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Added.
3519 * WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Added.
3521 2011-03-29 Patrick Gansterer <paroga@webkit.org>
3523 Reviewed by Adam Roben.
3525 Remove #pragma warning push and pop statements
3526 https://bugs.webkit.org/show_bug.cgi?id=57198
3528 We do not need to disable warnings via #pragma since we started
3529 compiling WebCore with the same compiler warnings flags as WebKit.
3531 * DOMCSSClasses.cpp:
3532 * DOMCoreClasses.cpp:
3533 * DOMEventsClasses.cpp:
3534 * DOMHTMLClasses.cpp:
3535 * DefaultDownloadDelegate.cpp:
3536 * DefaultPolicyDelegate.cpp:
3537 * MarshallingHelpers.cpp:
3538 * WebActionPropertyBag.cpp:
3539 * WebActionPropertyBag.h:
3541 * WebCoreSupport/WebDragClient.cpp:
3542 * WebCoreSupport/WebEditorClient.cpp:
3543 * WebCoreSupport/WebEditorClient.h:
3544 * WebCoreSupport/WebFrameLoaderClient.cpp:
3545 * WebCoreSupport/WebFrameLoaderClient.h:
3546 * WebCoreSupport/WebInspectorClient.cpp:
3547 * WebDocumentLoader.h:
3549 * WebDownloadCFNet.cpp:
3550 * WebDownloadCurl.cpp:
3551 * WebElementPropertyBag.cpp:
3556 * WebFramePolicyListener.cpp:
3557 * WebFramePolicyListener.h:
3559 * WebHistoryItem.cpp:
3560 * WebIconDatabase.cpp:
3561 * WebIconDatabase.h:
3563 * WebJavaScriptCollector.cpp:
3564 * WebKitGraphics.cpp:
3565 * WebKitSystemBits.cpp:
3566 * WebLocalizableStrings.cpp:
3567 * WebMutableURLRequest.cpp:
3568 * WebMutableURLRequest.h:
3569 * WebNodeHighlight.cpp:
3570 * WebNodeHighlight.h:
3571 * WebNotificationCenter.cpp:
3576 * WebURLAuthenticationChallenge.cpp:
3577 * WebURLAuthenticationChallenge.h:
3578 * WebURLAuthenticationChallengeSender.cpp:
3579 * WebURLAuthenticationChallengeSenderCFNet.cpp:
3580 * WebURLAuthenticationChallengeSenderCurl.cpp:
3581 * WebURLCredential.cpp:
3582 * WebURLCredential.h:
3583 * WebURLProtectionSpace.cpp:
3584 * WebURLProtectionSpace.h:
3585 * WebURLResponse.cpp:
3588 2011-03-29 Brent Fulgham <bfulgham@webkit.org>
3590 Unreviewed build fix after r82247.
3592 * WebMutableURLRequest.cpp: The new CertificateCFWin routines
3593 are not CFNetwork-specific. All CF-based ports can use them.
3595 2011-03-29 Patrick Gansterer <paroga@webkit.org>
3597 Reviewed by Adam Roben.
3599 [WIN] Use WCHAR instead of TCHAR
3600 https://bugs.webkit.org/show_bug.cgi?id=57191
3602 We always use the UNICODE versions of windows functions, so
3603 the usage of TCHAR makes no sense and mixing them is bad style.
3605 * DefaultDownloadDelegate.cpp:
3606 * WebCoreSupport/WebChromeClient.cpp:
3607 * WebCoreSupport/WebContextMenuClient.cpp:
3608 * WebCoreSupport/WebInspectorClient.cpp:
3610 * WebNotificationCenter.cpp:
3611 * WebPreferences.cpp:
3612 * WebURLResponse.cpp:
3615 2011-03-29 Jeff Miller <jeffm@apple.com>
3617 Reviewed by Jon Honeycutt.
3619 Add WebCore::copyCertificateToData() on Windows
3620 https://bugs.webkit.org/show_bug.cgi?id=57296
3622 Remove duplicate code that implemented this functionality in WebMutableURLRequest.cpp and use WebCore::copyCertificateToData() instead.
3624 * WebMutableURLRequest.cpp:
3625 (WebMutableURLRequest::setClientCertificate): Use WebCore::copyCertificateToData().
3627 2011-03-28 Patrick Gansterer <paroga@webkit.org>
3629 Reviewed by Adam Roben.
3631 [WIN] Remove unused DOMCreateInstance files
3632 https://bugs.webkit.org/show_bug.cgi?id=57193
3634 * DOMCreateInstance.cpp: Removed.
3635 * DOMCreateInstance.h: Removed.
3637 2011-03-28 Adele Peterson <adele@apple.com>
3641 * WebFrame.cpp: (WebFrame::hasSpellingMarker):
3642 Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
3644 2011-03-28 Jeff Miller <jeffm@apple.com>
3646 Reviewed by Adam Roben.
3648 Include certificate when sending a WebCore::ResourceError to UI process on Windows
3649 https://bugs.webkit.org/show_bug.cgi?id=57195
3651 Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*.
3654 (WebError::sslPeerCertificate):
3655 * WebURLResponse.cpp:
3656 (WebURLResponse::sslPeerCertificate):
3658 2011-03-28 Darin Adler <darin@apple.com>
3660 Set eol-style to native on more files. I noticed the last check-in had an entire file
3661 changing because of an EOL style change, and setting this property prevents that from
3662 happening in future. We may want to do this systematically for more of WebKit later.
3664 * AccessibleBase.cpp: Added property svn:eol-style.
3665 * AccessibleBase.h: Added property svn:eol-style.
3666 * AccessibleDocument.cpp: Added property svn:eol-style.
3667 * AccessibleDocument.h: Added property svn:eol-style.
3668 * AccessibleImage.cpp: Added property svn:eol-style.
3669 * AccessibleImage.h: Added property svn:eol-style.
3670 * COMVariantSetter.h: Added property svn:eol-style.
3671 * FullscreenVideoController.cpp: Added property svn:eol-style.
3672 * FullscreenVideoController.h: Added property svn:eol-style.
3673 * WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
3674 * WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
3675 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
3676 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
3677 * WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
3678 * WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
3679 * WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
3680 * WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
3681 * WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
3682 * WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
3683 * WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.
3685 2011-03-28 Patrick Gansterer <paroga@webkit.org>
3687 Unreviewed build fix.
3689 * COMPropertyBag.h: Added missing include.
3690 * WebKitCOMAPI.h: Ditto.
3691 * WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration.
3693 2011-03-25 Sam Weinig <sam@webkit.org>
3695 Reviewed by Jon Honeycutt.
3697 WebScrollBar not updating when calling WebScrollBar::setValue.
3698 <rdar://problem/9143871>
3701 (WebScrollBar::setValue):
3702 Call scrollToOffsetWithoutAnimation to actually update the scroll position.
3704 2011-03-25 Andy Estes <aestes@apple.com>
3706 Reviewed by Adele Peterson.
3708 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3709 https://bugs.webkit.org/show_bug.cgi?id=49016
3711 Update objectContentType() implementation to handle the
3712 shouldPreferPlugInsForImages flag.
3715 (WebFrame::objectContentType):
3718 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
3720 Unreviewed, rolling out r81916 and r81917.
3721 http://trac.webkit.org/changeset/81916
3722 http://trac.webkit.org/changeset/81917
3723 https://bugs.webkit.org/show_bug.cgi?id=57071
3725 broke a test on platforms that do not have QuickTime installed
3726 (Requested by estes on #webkit).
3729 (WebFrame::objectContentType):
3732 2011-03-24 Andy Estes <aestes@apple.com>
3734 Reviewed by Darin Adler.
3736 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3737 https://bugs.webkit.org/show_bug.cgi?id=49016
3739 Update objectContentType() implementation to handle the
3740 shouldPreferPlugInsForImages flag.
3743 (WebFrame::objectContentType):
3746 2011-03-23 Brady Eidson <beidson@apple.com>
3748 Reviewed by Sam Weinig.
3750 Change IconDatabase opening to allow for arbitrary filenames
3751 https://bugs.webkit.org/show_bug.cgi?id=56977
3753 * WebIconDatabase.cpp:
3754 (WebIconDatabase::startUpIconDatabase):
3756 2011-03-22 Brady Eidson <beidson@apple.com>
3758 Reviewed by Sam Weinig.
3760 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
3761 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
3763 Note that while the new client calls always come through on the main thread, our mechanisms to
3764 route dispatches to the main thread are still valid and will still work.
3766 Update to the new IconDatabaseClient interface:
3767 * WebIconDatabase.cpp:
3768 (WebIconDatabase::performImport):
3769 (WebIconDatabase::didRemoveAllIcons):
3770 (WebIconDatabase::didImportIconURLForPageURL):
3771 (WebIconDatabase::didImportIconDataForPageURL):
3772 (WebIconDatabase::didChangeIconForPageURL):
3773 (WebIconDatabase::didFinishURLImport):
3774 * WebIconDatabase.h:
3776 2011-03-17 Brady Eidson <beidson@apple.com>
3778 Reviewed by Sam Weinig.
3780 https://bugs.webkit.org/show_bug.cgi?id=56425
3781 More groundwork for WebKit2 IconDatabase
3783 Update already-used function names:
3784 * WebIconDatabase.cpp:
3785 (WebIconDatabase::iconForURL):
3786 (WebIconDatabase::iconURLForURL):
3787 (WebIconDatabase::hasIconForURL):
3789 2011-03-18 Pavel Podivilov <podivilov@chromium.org>
3791 Reviewed by Yury Semikhatsky.
3793 Web Inspector: implement inspector session storage.
3794 https://bugs.webkit.org/show_bug.cgi?id=56643
3796 * WebCoreSupport/WebInspectorClient.cpp:
3797 (WebInspectorClient::saveSessionSetting):
3798 (WebInspectorClient::loadSessionSetting):
3799 (WebInspectorFrontendClient::saveSessionSetting):
3800 (WebInspectorFrontendClient::loadSessionSetting):
3801 * WebCoreSupport/WebInspectorClient.h:
3803 2011-03-11 Brady Eidson <beidson@apple.com>
3805 More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
3807 * WebCoreStatistics.cpp:
3808 * WebIconDatabase.cpp:
3810 2011-03-09 Peter Kasting <pkasting@google.com>
3812 Reviewed by Mihai Parparita.
3814 Unify Windows version checks.
3815 https://bugs.webkit.org/show_bug.cgi?id=55979
3818 (WebView::standardUserAgentWithApplicationName):
3819 (webKitVersionString):
3821 2011-03-07 Sam Weinig <sam@webkit.org>
3823 Reviewed by Anders Carlsson.
3825 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3826 https://bugs.webkit.org/show_bug.cgi?id=55827
3828 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
3829 and pass the entire response, instead of just the MIMEType.
3832 (WebFrame::dispatchDecidePolicyForResponse):
3835 2011-03-04 Steve Falkenburg <sfalken@apple.com>
3837 Reviewed by Darin Adler.
3839 Adopt VersionStamper tool for Windows WebKit DLLs
3840 https://bugs.webkit.org/show_bug.cgi?id=55784
3842 Calculate the WebKit version for the useragent via autoversion.h
3843 instead of reading it back from the DLL.
3845 We now use a tool to stamp the version number onto the Apple WebKit DLLs
3846 during the post-build step.
3848 * WebKit.vcproj/WebKit.rc: Removed. This file wasn't used.
3849 * WebKit.vcproj/WebKitLibCommon.vsprops: Fetch version from a string resource.
3851 (WebView::standardUserAgentWithApplicationName): Use __BUILD_NUMBER_SHORT__ for the version.
3852 (osVersion): Removed
3854 2011-03-03 Anders Carlsson <andersca@apple.com>
3856 Reviewed by Sam Weinig.
3858 Get rid of Page::globalHistoryItem
3859 https://bugs.webkit.org/show_bug.cgi?id=55738
3861 * WebCoreSupport/WebFrameLoaderClient.cpp:
3862 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
3863 Get the current history item and update it using WebView::setGlobalHistoryItem.
3865 * WebCoreSupport/WebFrameLoaderClient.h:
3867 (WebView::globalHistoryItem):
3868 (WebView::setGlobalHistoryItem):
3871 2011-03-03 Brent Fulgham <bfulgham@webkit.org>
3873 Unreviewed build correction.
3876 (scaleFactor): Update after 77286 to replace right/bottom
3877 with new maxX/maxY terminology.
3879 2011-03-03 Brady Eidson <beidson@apple.com>
3881 Reviewed by Darin Adler.
3883 https://bugs.webkit.org/show_bug.cgi?id=55721
3884 Global IconDatabase should be returned by reference, not as a pointer
3886 * WebCoreStatistics.cpp:
3887 (WebCoreStatistics::iconPageURLMappingCount):
3888 (WebCoreStatistics::iconRetainedPageURLCount):
3889 (WebCoreStatistics::iconRecordCount):
3890 (WebCoreStatistics::iconsWithDataCount):
3891 * WebIconDatabase.cpp:
3892 (WebIconDatabase::init):
3893 (WebIconDatabase::startUpIconDatabase):
3894 (WebIconDatabase::iconForURL):
3895 (WebIconDatabase::retainIconForURL):
3896 (WebIconDatabase::releaseIconForURL):
3897 (WebIconDatabase::removeAllIcons):
3898 (WebIconDatabase::iconURLForURL):
3899 (WebIconDatabase::isEnabled):
3900 (WebIconDatabase::setEnabled):
3901 (WebIconDatabase::hasIconForURL):
3902 (WebIconDatabase::getOrCreateDefaultIconBitmap):
3906 2011-03-03 Alexey Proskuryakov <ap@apple.com>
3908 Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
3911 * WebCoreSupport/WebChromeClient.h:
3913 2011-03-02 Alexey Proskuryakov <ap@apple.com>
3915 Reviewed by Darin Adler.
3917 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
3918 https://bugs.webkit.org/show_bug.cgi?id=55633
3919 <rdar://problem/8963023>
3921 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::keyboardUIMode):
3922 * WebCoreSupport/WebChromeClient.h:
3923 Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
3924 this platform doesn't observe or have full keyboard access state.
3926 2011-03-03 Peter Kasting <pkasting@google.com>
3928 Reviewed by James Robinson.
3930 Drop redundant "Windows; " from the Windows-specific User Agent string.
3931 https://bugs.webkit.org/show_bug.cgi?id=54567
3934 (WebView::standardUserAgentWithApplicationName):
3936 2011-03-01 Brian Weinstein <bweinstein@apple.com>
3938 Reviewed by Adam Roben.
3940 Part of WebKit2: Need a way to send notifications to client when cookies change
3941 https://bugs.webkit.org/show_bug.cgi?id=55427
3942 <rdar://problem/9056027>
3944 Add stubs for CookiesStrategy on Windows WebKit1.
3946 * WebCoreSupport/WebPlatformStrategies.cpp:
3947 (WebPlatformStrategies::createCookiesStrategy):
3948 (WebPlatformStrategies::notifyCookiesChanged):
3949 * WebCoreSupport/WebPlatformStrategies.h:
3951 2011-02-28 Chang Shu <cshu@webkit.org>
3953 Reviewed by Ryosuke Niwa.
3955 Remove the support of Frame::isContentEditable and its dependencies.
3956 https://bugs.webkit.org/show_bug.cgi?id=54292
3958 Remove the WebKit side implementation.
3960 * WebCoreSupport/WebEditorClient.cpp:
3961 * WebCoreSupport/WebEditorClient.h:
3963 2011-02-28 Adam Roben <aroben@apple.com>
3965 Build TestWebKitAPIInjectedBundle on Windows
3967 Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
3969 Reviewed by Darin Adler.
3971 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPIInjectedBundle. Let VS simplify the paths to
3974 2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
3976 Unreviewed, rolling out r78789.
3977 http://trac.webkit.org/changeset/78789
3978 https://bugs.webkit.org/show_bug.cgi?id=55409
3980 Incorrect canvas fallback implementation (Requested by
3981 inferno-sec on #webkit).
3983 * AccessibleBase.cpp:
3986 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
3988 Reviewed by Pavel Feldman.
3990 DumpRenderTree should reset frame opener between tests.
3991 https://bugs.webkit.org/show_bug.cgi?id=54874
3993 Added clearOpener method to IWebFramePrivate.
3994 Touched WebKit.idl to trigger build scripts.
3996 * Interfaces/IWebFramePrivate.idl:
3997 * Interfaces/WebKit.idl:
3999 (WebFrame::clearOpener):
4002 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
4004 Unreviewed, rolling out r79764.
4005 http://trac.webkit.org/changeset/79764
4006 https://bugs.webkit.org/show_bug.cgi?id=55295
4008 "broke Chromium builds" (Requested by rniwa on #webkit).
4010 * Interfaces/IWebFramePrivate.idl:
4011 * Interfaces/WebKit.idl:
4015 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
4017 Reviewed by Pavel Feldman.
4019 DumpRenderTree should reset frame opener between tests.
4020 https://bugs.webkit.org/show_bug.cgi?id=54874
4022 Added clearOpener method to IWebFramePrivate.
4023 Touched WebKit.idl to trigger build scripts.
4025 * Interfaces/IWebFramePrivate.idl:
4026 * Interfaces/WebKit.idl:
4028 (WebFrame::clearOpener):
4031 2011-02-24 Peter Kasting <pkasting@google.com>
4033 Reviewed by Eric Seidel.
4035 Drop the "U; " encryption level from the User Agent string.
4036 https://bugs.webkit.org/show_bug.cgi?id=54566
4039 (WebView::standardUserAgentWithApplicationName):
4041 2011-02-24 Andrew Wilson <atwilson@chromium.org>
4043 Unreviewed, rolling out r79570.
4044 http://trac.webkit.org/changeset/79570
4045 https://bugs.webkit.org/show_bug.cgi?id=54874
4047 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
4050 * Interfaces/IWebFramePrivate.idl:
4051 * Interfaces/WebKit.idl:
4055 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
4057 Reviewed by Alexey Proskuryakov.
4059 DumpRenderTree should reset frame opener between tests.
4060 https://bugs.webkit.org/show_bug.cgi?id=54874
4062 Added clearOpener method to IWebFramePrivate.
4063 Touched WebKit.idl to trigger build scripts.
4065 * Interfaces/IWebFramePrivate.idl:
4066 * Interfaces/WebKit.idl:
4068 (WebFrame::clearOpener):
4071 2011-02-23 Patrick Gansterer <paroga@webkit.org>
4073 Reviewed by Darin Adler.
4075 Rename PLATFORM(CF) to USE(CF)
4076 https://bugs.webkit.org/show_bug.cgi?id=53540
4080 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
4082 Reviewed by Alexey Proskuryakov.
4084 Drop the language tag part from the User Agent string
4085 https://bugs.webkit.org/show_bug.cgi?id=54560
4088 (WebView::standardUserAgentWithApplicationName):
4090 2011-02-19 Charlie Reis <creis@chromium.org>
4092 Reviewed by Mihai Parparita.
4094 Ensure loading has stopped in HistoryController::goToItem
4095 https://bugs.webkit.org/show_bug.cgi?id=54517
4097 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
4099 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
4101 * WebCoreSupport/WebFrameLoaderClient.cpp:
4102 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
4103 * WebCoreSupport/WebFrameLoaderClient.h:
4105 2011-02-16 David Hyatt <hyatt@apple.com>
4107 Reviewed by Dan Bernstein.
4109 https://bugs.webkit.org/show_bug.cgi?id=54244
4111 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
4112 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
4114 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
4115 been changed as well.
4117 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
4119 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
4121 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
4122 still have a precise floating point position.
4124 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
4125 be rounding justification spacing in their font code.
4127 Many layout test results change on Mac, since rounding hacks were used there and are now gone.
4129 * WebKitGraphics.cpp:
4130 (CenterTruncateStringToWidth):
4131 (RightTruncateStringToWidth):
4133 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
4135 Reviewed by Adam Roben.
4137 HTML5 <details> and <summary>: localized text
4138 https://bugs.webkit.org/show_bug.cgi?id=54260
4140 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
4141 provide the default label to be used by a <details> tag that has no <summary> child.
4143 * WebCoreSupport/WebPlatformStrategies.cpp:
4144 (WebPlatformStrategies::defaultDetailsSummaryText):
4145 * WebCoreSupport/WebPlatformStrategies.h:
4147 2011-02-16 Dominic Mazzoni <dmazzoni@google.com>
4149 Reviewed by Chris Fleizach.
4151 Add new role for canvas elements.
4153 https://bugs.webkit.org/show_bug.cgi?id=50126
4155 Test: accessibility/canvas-fallback-content.html
4157 * AccessibleBase.cpp:
4160 2011-02-15 Kenneth Russell <kbr@google.com>
4162 Unreviewed. Remove whitespace-only change from
4163 http://trac.webkit.org/changeset/78620 (https://bugs.webkit.org/show_bug.cgi?id=54312)
4164 now that the patch has passed the Windows build bots.
4166 * Interfaces/WebKit.idl:
4168 2011-02-15 Kenneth Russell <kbr@google.com>
4170 Reviewed by Darin Fisher.
4172 Allow controlling minimum DOMTimer interval on a per-page basis
4173 https://bugs.webkit.org/show_bug.cgi?id=54312
4175 Added needed methods to implement LayoutTestController's new
4176 setMinimumTimerInterval method. Includes whitespace-only change to
4177 WebKit.idl to trigger proper rebuild on bots; will be removed in
4180 * Interfaces/IWebViewPrivate.idl:
4181 * Interfaces/WebKit.idl:
4183 (WebView::initWithFrame):
4184 (WebView::defaultMinimumTimerInterval):
4185 (WebView::setMinimumTimerInterval):
4188 2011-01-26 MORITA Hajime <morrita@google.com>
4190 Reviewed by Ryosuke Niwa.
4192 Refactoring: Extract TextCheckerClient from EditorClient
4193 https://bugs.webkit.org/show_bug.cgi?id=53213
4195 * WebCoreSupport/WebEditorClient.h:
4196 (WebEditorClient::textChecker):
4198 2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
4200 Reviewed by Adam Barth.
4202 Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
4203 https://bugs.webkit.org/show_bug.cgi?id=52417
4205 Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
4208 * WebCoreSupport/WebEditorClient.cpp:
4209 (WebEditorClient::canCopyCut): Added.
4210 (WebEditorClient::canPaste): Added.
4211 * WebCoreSupport/WebEditorClient.h:
4213 2011-02-14 Brian Weinstein <bweinstein@apple.com>
4215 Reviewed by Brady Eidson.
4217 Need WebKit API to determine whether we have a site icon for a given URL
4218 https://bugs.webkit.org/show_bug.cgi?id=54400
4220 This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
4221 we have a site icon for the given URL.
4223 * Interfaces/IWebIconDatabase.idl: Added new function.
4224 * Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
4225 * WebIconDatabase.cpp:
4226 (WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we
4227 load the icon from disk, and call iconURLForPageURL to determine whether or not
4228 we actually have an icon.
4229 * WebIconDatabase.h:
4231 2011-02-11 Geoffrey Garen <ggaren@apple.com>
4233 Reviewed by Oliver Hunt.
4235 A little more encapsulation for the heap: Removed CollectorHeapIterator
4236 https://bugs.webkit.org/show_bug.cgi?id=54298
4238 * WebCoreStatistics.cpp:
4239 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
4241 2011-02-09 Pavel Feldman <pfeldman@chromium.org>
4243 Reviewed by Yury Semikhatsky.
4245 Web Inspector: follow up on InspectorAgent split -
4246 removing unnecessary methods from InspectorController.
4247 https://bugs.webkit.org/show_bug.cgi?id=54093
4250 (WebInspector::showConsole):
4251 (WebInspector::toggleProfilingJavaScript):
4253 2011-02-08 Adam Barth <abarth@webkit.org>
4255 Reviewed by Eric Seidel.
4257 Remove orphan code from old parser
4258 https://bugs.webkit.org/show_bug.cgi?id=53984
4260 * WebCoreSupport/WebChromeClient.h:
4262 2011-02-08 David Hyatt <hyatt@apple.com>
4264 Reviewed by Adam Roben.
4266 <rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed
4268 Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
4269 value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
4273 (WebFrame::setPrinting):
4274 (WebFrame::setInPrintingMode):
4277 2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
4279 Reviewed by Yury Semikhatsky.
4281 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
4283 https://bugs.webkit.org/show_bug.cgi?id=53169
4285 Minor change enforced by major changes in WebCore/inspector/InspectorController.
4288 (WebInspector::isTimelineProfilingEnabled):
4290 2011-02-07 Enrica Casucci <enrica@apple.com>
4292 Reviewed Adam Roben and Darin Adler.
4294 WebKit2: drag and drop support on Windows.
4295 https://bugs.webkit.org/show_bug.cgi?id=52775
4297 Removed createDragImageForLink from DragClient.
4299 * WebCoreSupport/WebDragClient.cpp:
4300 (WebDragClient::startDrag):
4301 * WebCoreSupport/WebDragClient.h:
4303 2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
4305 Reviewed by Darin Adler.
4307 OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
4308 https://bugs.webkit.org/show_bug.cgi?id=52867
4311 (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
4312 * WebPreferences.cpp:
4313 (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.
4315 2011-02-03 Yury Semikhatsky <yurys@chromium.org>
4317 Reviewed by Pavel Feldman.
4319 Web Inspector: remove settings related methods from InspectorClient
4320 https://bugs.webkit.org/show_bug.cgi?id=53686
4322 * WebCoreSupport/WebInspectorClient.cpp:
4323 (WebInspectorClient::openInspectorFrontend):
4324 (WebInspectorFrontendClient::WebInspectorFrontendClient):
4325 * WebCoreSupport/WebInspectorClient.h:
4327 2011-02-03 Adam Langley <agl@chromium.org>
4329 Reviewed by Adam Barth.
4331 Plumb mixed script URL to FrameLoaderClient
4332 https://bugs.webkit.org/show_bug.cgi?id=52384
4334 Regressions covered by http/tests/security/mixedContent/*
4336 * WebCoreSupport/WebFrameLoaderClient.cpp:
4337 (WebFrameLoaderClient::didRunInsecureContent):
4338 * WebCoreSupport/WebFrameLoaderClient.h:
4340 2011-02-02 David Hyatt <hyatt@apple.com>
4342 Reviewed by Darin Adler.
4344 Removal of right()/bottom(), converting to maxX()/maxY().
4346 * DOMHTMLClasses.cpp:
4347 (DOMHTMLInputElement::rectOnScreen):
4348 * WebCoreSupport/EmbeddedWidget.cpp:
4349 (EmbeddedWidget::frameRectsChanged):
4351 (WebFrame::computePageRects):
4353 (WebScrollBar::frameRect):
4355 (WebView::addToDirtyRegion):
4356 (WebView::visibleContentRect):
4357 (WebView::prepareCandidateWindow):
4359 2011-01-31 Brady Eidson <beidson@apple.com>
4361 Reviewed by Adam Roben.
4363 Fix the clean Windows build.
4365 * WebKitGraphics.cpp:
4368 2011-01-28 Jon Honeycutt <jhoneycutt@apple.com>
4370 Downloads in WK2 on Windows should write resume data to bundle
4371 https://bugs.webkit.org/show_bug.cgi?id=53282
4372 <rdar://problem/8753077>
4374 Reviewed by Alice Liu.
4377 (WebDownload::bundlePathForTargetPath):
4378 Use the new WebCore::DownloadBundle function.
4379 (WebDownload::request):
4382 Removed declarations for functions that were moved to a new location.
4384 * WebDownloadCFNet.cpp:
4385 (WebDownload::initToResumeWithBundle):
4386 Use the new WebCore::DownloadBundle function.
4387 (WebDownload::cancelForResume):
4388 Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
4389 WebCore::DownloadBundle function.
4391 2011-01-28 Dan Bernstein <mitz@apple.com>
4393 Reviewed by Sam Weinig.
4395 <select> can't display right-to-left (rtl) languages
4396 https://bugs.webkit.org/show_bug.cgi?id=19785
4398 * WebCoreSupport/WebChromeClient.cpp:
4399 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
4400 * WebCoreSupport/WebChromeClient.h:
4402 2011-01-27 Nate Chapin <japhet@chromium.org>
4404 Reviewed by Adam Barth.
4406 Use Document::url() instead of FrameLoader::url().
4407 https://bugs.webkit.org/show_bug.cgi?id=41165
4412 2011-01-27 Sam Weinig <sam@webkit.org>
4414 Reviewed by Adam Roben.
4416 Fix scrollbars in Safari's Downloads window and Bookmarks view by
4417 implementing two needed functions from ScrollableArea.
4420 (WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if
4421 we are a horizontal scrollbar.
4422 (WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we
4423 are a vertical scrollbar.
4426 2011-01-27 Adam Roben <aroben@apple.com>
4428 Trim down #includes in WebView.h
4430 Rubber-stamped by Steve Falkenburg.
4432 * WebView.cpp: Moved some #includes here from the header file.
4434 * WebView.h: Replaced some broader #includes with more specific ones, plus a
4435 forward-declaration.
4437 2011-01-25 Steve Falkenburg <sfalken@apple.com>
4439 Windows production build fix.
4440 Build correct configuration of Interfaces for Debug_All.
4442 * WebKit.vcproj/WebKit.submit.sln:
4444 2011-01-25 Steve Falkenburg <sfalken@apple.com>
4446 Rubber-stamped by Adam Roben.
4448 Windows production build fix.
4449 Use correct environment variable escaping
4451 * WebKit.vcproj/WebKit.make:
4453 2011-01-24 Chris Marrin <cmarrin@apple.com>
4455 Reviewed by Eric Seidel.
4457 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
4458 https://bugs.webkit.org/show_bug.cgi?id=53041
4461 (WebView::notifyPreferencesChanged):
4463 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
4465 Reviewed by Pavel Feldman.
4467 Web Inspector: remove "attached" state related methods from InspectorAgent
4468 https://bugs.webkit.org/show_bug.cgi?id=53086
4470 * WebCoreSupport/WebInspectorClient.cpp:
4471 (WebInspectorFrontendClient::attachWindow):
4472 (WebInspectorFrontendClient::detachWindow):
4473 (WebInspectorFrontendClient::showWindowWithoutNotifications):
4474 * WebCoreSupport/WebInspectorClient.h:
4476 2011-01-24 Adam Roben <aroben@apple.com>
4478 Windows Production build fix
4480 * WebKit.vcproj/WebKit.make: Update for move of WebKit into Source.
4482 2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
4484 Reviewed by Dirk Schulze.
4486 Introduce FontMetrics abstraction
4487 https://bugs.webkit.org/show_bug.cgi?id=51456
4489 * FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics.
4490 (FullscreenVideoController::draw):
4491 * WebCoreSupport/WebDragClient.cpp: Ditto.
4492 (WebDragClient::createDragImageForLink):
4493 * WebKitGraphics.cpp: Ditto.
4496 2011-01-21 Chris Rogers <crogers@google.com>
4498 Reviewed by Darin Fisher.
4500 Add run-time enable support for the web audio API
4501 https://bugs.webkit.org/show_bug.cgi?id=52741
4503 * WebPreferenceKeysPrivate.h:
4505 (WebView::notifyPreferencesChanged):
4507 2011-01-21 Sam Weinig <sam@webkit.org>
4513 2011-01-21 Sam Weinig <sam@webkit.org>
4515 Reviewed by Anders Carlsson.
4517 Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
4518 https://bugs.webkit.org/show_bug.cgi?id=52779
4520 Rename ScrollbarClient -> ScrollableArea.
4523 (WebScrollBar::scroll):
4526 2011-01-20 Adam Roben <aroben@apple.com>
4528 Update for CACFLayerTreeHost changes
4530 Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
4531 CACFLayerTreeHost, but shouldn't be
4533 Reviewed by Simon Fraser.
4536 (WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
4537 to our own flushing function if needed.
4539 * WebView.h: Removed shouldRender, which is no longer used or needed.
4541 2011-01-21 Adam Roben <aroben@apple.com>
4543 Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename
4545 Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.
4547 Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
4549 Reviewed by Simon Fraser.
4551 * WebPreferences.cpp:
4553 (WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
4554 host before we get rid of the layer tree host itself.
4557 2011-01-21 Adam Roben <aroben@apple.com>
4559 Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"
4561 This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
4562 opposed to just "layer" because there are cases where we flush changes to CACFLayers that
4563 don't have a corresponding GraphicsLayer.
4565 Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
4566 WKCACFLayerRenderer and friends is confusing
4568 Reviewed by Simon Fraser.
4570 * WebCoreSupport/WebChromeClient.cpp:
4571 (WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.
4574 (WebView::paint): Updated for rename.
4575 (WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
4576 (WebView::notifySyncRequired): Updated for rename.
4577 (WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.
4579 * WebView.h: Did the renames.
4581 2011-01-20 Sam Weinig <sam@webkit.org>
4583 Reviewed by Dave Hyatt.
4585 Cleanup Scrollbar/ScrollbarClient relationship
4586 https://bugs.webkit.org/show_bug.cgi?id=52779
4589 (WebScrollBar::WebScrollBar):
4590 (WebScrollBar::setValue):
4591 (WebScrollBar::value):
4592 (WebScrollBar::scroll):
4593 (WebScrollBar::scrollPosition):
4594 (WebScrollBar::setScrollOffset):
4597 2011-01-19 Adam Roben <aroben@apple.com>
4599 Update for WKCACFLayerRenderer changes
4601 Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
4604 Reviewed by Simon Fraser.
4607 (WebView::~WebView): Added some assertions to make sure we've gotten rid of our
4608 compositing-related members. My biggest concern was making sure that m_layerRenderer was
4609 gone, which would also mean we had nulled out its client pointer.
4610 (WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
4611 of passing the client into create(), and to clear out the client before nulling out
4614 * WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
4616 2011-01-19 Adam Roben <aroben@apple.com>
4618 Teach WebView::scrollBackingStore about compositing mode
4621 compositing/scroll-painted-composited-content.html
4623 Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
4624 WebView::scrollBackingStore when scrolling page with composited content
4626 Reviewed by Anders Carlsson.
4629 (WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
4630 mode, rather than incorrectly asserting that this function is never called in that case. For
4631 now we just repaint the entire scrolled region; someday hopefully we can avoid having to
4632 repaint the areas that have just been moved.
4634 2011-01-19 Simon Fraser <simon.fraser@apple.com>
4636 Reviewed by Sam Weinig.
4638 GraphicsLayers in subframes can get sync'd multiple times
4639 https://bugs.webkit.org/show_bug.cgi?id=52489
4642 (WebView::syncCompositingState): syncCompositingStateRecursive()
4643 was renamed to syncCompositingStateIncludingSubframes().
4645 2011-01-17 Adam Roben <aroben@apple.com>
4647 Update for WKCACFLayerRenderer changes
4649 Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use
4651 Reviewed by Chris Marrin.
4654 (WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
4655 when handling WM_SHOWWINDOW. All this did was try to create the
4656 renderer, but it had already been created in setAcceleratedCompositing,
4658 (WebView::setAcceleratedCompositing): Removed call to createRenderer;
4659 setHostWindow does this for us now.
4661 * WebView.h: Removed animationsStarted and layerRendererBecameVisible.
4663 2011-01-17 Adam Roben <aroben@apple.com>
4665 Paint directly into a GraphicsLayer when using accelerated compositing
4667 Before this patch, we were painting into our normal backing store
4668 HBITMAP, wrapping it in a CGImage, and handing it off to Core
4669 Animation. This had at least two disadvantages:
4670 1) The bitmap could be modified while Core Animation was using it.
4671 2) It introduced extra complexity.
4673 When entering accelerated compositing mode, WebView now creates a
4674 GraphicsLayer to draw into. This GraphicsLayer sits between the root
4675 layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
4676 WebView invalidates, it just calls setNeedsDisplayInRect on its
4677 GraphicsLayer. When WebView paints, it just tells its
4678 WKCACFLayerRenderer to paint, which will call back to WebView to draw
4679 into the GraphicsLayer if it has a dirty region. This is very similar
4680 to the current implementation of LayerBackedDrawingArea in WebKit2.
4682 Fixes <http://webkit.org/b/52582> WebView should paint directly into a
4683 GraphicsLayer when in accelerated compositing mode
4685 Reviewed by Simon Fraser and Chris Marrin.
4687 * WebCoreSupport/WebChromeClient.cpp:
4688 (WebChromeClient::attachRootGraphicsLayer):
4689 (WebChromeClient::scheduleCompositingLayerSync):
4690 Updated for WebView changes.
4693 (WebView::repaint): When using accelerated compositing, just invalidate
4694 our backing layer. This matches the behavior of LayerBackedDrawingArea.
4695 (WebView::deleteBackingStore): Removed accelerated compositing code.
4696 The WKCACFLayerRenderer doesn't need to know about our backing store
4697 anymore; we don't use it at all when in accelerated compositing mode.
4698 (WebView::addToDirtyRegion): When using accelerated compositing, just
4699 invalidate our backing layer.
4700 (WebView::scrollBackingStore): Added an assertion that this isn't
4701 called in accelerated compositing mode.
4702 (WebView::sizeChanged): Update our backing layer's size, too, and
4704 (WebView::updateBackingStore): Added an assertion that this isn't
4705 called in accelerated compositing mode.
4706 (WebView::paint): If we're in accelerated compositing mode, sync our
4707 compositing state. If we're *still* in accelerated compositing mode,
4708 just tell our WKCACFLayerRenderer to paint and clear our dirty region.
4709 (The later changes in this function are just un-indenting code that
4710 used to be inside an if.)
4712 (WebView::paintIntoBackingStore):
4713 (WebView::paintIntoWindow):
4714 Added assertions that these aren't called in accelerated compositing
4717 (WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
4718 removal of setRootLayerNeedsDisplay.
4719 (WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
4720 set the layer as a child of our own backing layer.
4721 (WebView::scheduleCompositingLayerSync): Just call through to
4722 WKCACFLayerRenderer.
4723 (WebView::setAcceleratedCompositing): Create our backing layer and set
4724 it as the child of WKCACFLayerRenderer's root layer.
4725 (WebView::notifyAnimationStarted): Added. We never expect this
4726 GraphicsLayerClient override to be called, as we don't use animations
4727 on our backing layer.
4728 (WebView::notifySyncRequired): Added. Just schedule a sync.
4729 (WebView::paintContents): Added. Just clip and paint!
4731 (WebView::showDebugBorders):
4732 (WebView::showRepaintCounter):
4733 Added. These just call through to Settings.
4735 (WebView::syncCompositingState): Changed to first update layout, then
4736 sync state for our backing layer, then sync WebCore's state. This
4737 matches LayerBackedDrawingArea.
4739 * WebView.h: WebView now implements the GraphicsLayerClient interface.
4740 Removed setRootLayerNeedsDisplay; it's been replaced by calling
4741 setNeedsDisplay on our backing layer and calling
4742 syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
4743 updateRootLayerContents; that function was used to pass our backing
4744 store to Core Animation, which we no longer do. Added m_backingLayer.
4746 2011-01-17 Tony Gentilcore <tonyg@chromium.org>
4748 Reviewed by Alexey Proskuryakov.
4750 Fix some headers with missing or misspelled #ifndef guards
4751 https://bugs.webkit.org/show_bug.cgi?id=52545
4753 * WebKitStatistics.h:
4755 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
4757 Reviewed by Yury Semikhatsky.
4759 Web Inspector: simplify debugger enabling routine.
4760 https://bugs.webkit.org/show_bug.cgi?id=52472
4763 (WebInspector::toggleDebuggingJavaScript):
4765 2011-01-16 Adam Barth <abarth@webkit.org>
4767 Rubber-stamped by Eric Seidel.
4769 Move WebKit into Source
4770 https://bugs.webkit.org/show_bug.cgi?id=52530
4772 * WebKit.vcproj/Interfaces.vcproj:
4773 * WebKit.vcproj/WebKit.sln:
4774 * WebKit.vcproj/WebKit.vcproj:
4775 * WebKit.vcproj/WebKitGUID.vcproj:
4777 2011-01-15 Adam Barth <abarth@webkit.org>
4779 Rubber-stamped by Eric Seidel.
4781 Move WebKit2 into Source
4782 https://bugs.webkit.org/show_bug.cgi?id=52438
4784 Update reference to WebKit2.
4786 * WebKit.vcproj/WebKit.sln:
4788 2011-01-14 Yuzo Fujishima <yuzo@google.com>
4790 Reviewed by Antti Koivisto.
4792 Rename cache() to memoryCache()
4793 https://bugs.webkit.org/show_bug.cgi?id=52433
4796 (WebCache::statistics):
4798 (WebCache::setDisabled):
4799 (WebCache::disabled):
4801 (WebView::setCacheModel):
4803 2011-01-10 Geoffrey Garen <ggaren@apple.com>
4805 Try to fix Windows build.
4807 * WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch
4808 this one before because it was miscapitalized.)
4810 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
4812 Reviewed by Darin Fisher.
4814 https://bugs.webkit.org/show_bug.cgi?id=41441
4815 createWindow method should only do window-creating without URL navigation
4817 * WebCoreSupport/WebChromeClient.cpp:
4818 (WebChromeClient::createWindow):
4820 2011-01-07 Adam Barth <abarth@webkit.org>
4822 Rubber-stamped by Eric Seidel.
4824 Move WebCore to Source
4825 https://bugs.webkit.org/show_bug.cgi?id=52050
4827 * WebKit.vcproj/WebKit.sln:
4829 2011-01-06 Gavin Barraclough <barraclough@apple.com>
4831 Reviewed by Geoff Garen.
4833 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
4835 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
4836 destructor early, in order to release wrappers once we know we no longer intend to use them.
4837 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
4838 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
4839 A sequence of events that triggers the bug would look like this:
4841 (1) Create a DOMWrapperWorld.
4842 (2) Register a timer in the world.
4843 (3) Call unregisterWorld() on the world.
4844 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
4845 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
4846 called forgetWorld() none exists.
4847 (6) Attempt to add a wrapper to a NULL map.
4849 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
4851 * WebScriptWorld.cpp:
4852 (WebScriptWorld::unregisterWorld):
4854 2011-01-07 Chris Marrin <cmarrin@apple.com>
4856 Rubber-stamped by Simon Fraser.
4858 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
4859 https://bugs.webkit.org/show_bug.cgi?id=49388
4861 Change client API for the fullscreen video controller. It now uses a
4862 PlatformCALayerClient so it can use a PlaformCALayer directly. Also
4863 updated how to connect the layer tree to the view to reflect the updated
4864 hardware compositing logic.
4866 * FullscreenVideoController.cpp:
4867 (FullscreenVideoController::LayerClient::LayerClient):
4868 (FullscreenVideoController::LayerClient::platformCALayerRespondsToLayoutChanges):
4869 (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
4870 (FullscreenVideoController::LayerClient::platformCALayerContentsOrientation):
4871 (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
4872 (FullscreenVideoController::LayerClient::platformCALayerShowDebugBorders):
4873 (FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):
4874 (FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
4875 (FullscreenVideoController::LayerClient::platformCALayerContentsOpaque):
4876 (FullscreenVideoController::LayerClient::platformCALayerDrawsContent):
4877 (FullscreenVideoController::LayerClient::platformCALayerLayerDidDisplay):
4878 (FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):
4879 (FullscreenVideoController::FullscreenVideoController):
4880 (FullscreenVideoController::~FullscreenVideoController):
4881 (FullscreenVideoController::enterFullscreen):
4882 * FullscreenVideoController.h:
4883 * WebCoreSupport/WebChromeClient.cpp:
4884 (WebChromeClient::attachRootGraphicsLayer):
4885 (WebChromeClient::scheduleCompositingLayerSync):
4887 (WebView::setRootChildLayer):
4888 (WebView::animationsStarted):
4889 (WebView::syncCompositingState):
4891 (WebView::setRootLayerNeedsDisplay):
4893 2011-01-05 Steve Falkenburg <sfalken@apple.com>
4895 Reviewed by Darin Adler.
4897 Debug and Release builds on Windows clobber each other
4898 https://bugs.webkit.org/show_bug.cgi?id=49185
4900 Changes the structure of WebKitBuild build products directory so we
4901 completely separate each build configuration into independent directories.
4903 Although we previously had per-configuration directories for obj, this change adds
4904 per-configuration directories for bin, lib, obj, and include. Each configuration's
4905 build products are stored within a directory inside of WebKitBuild.
4907 Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
4908 defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
4910 * WebKit.vcproj/InterfacesCommon.vsprops:
4911 * WebKit.vcproj/InterfacesPostBuild.cmd:
4912 * WebKit.vcproj/InterfacesPreBuild.cmd:
4913 * WebKit.vcproj/WebKit.make:
4914 * WebKit.vcproj/WebKitGUID.vcproj:
4915 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
4916 * WebKit.vcproj/WebKitGUIDPostBuild.cmd:
4917 * WebKit.vcproj/WebKitGUIDPreBuild.cmd:
4918 * WebKit.vcproj/WebKitLibCommon.vsprops:
4919 * WebKit.vcproj/WebKitLibPostBuild.cmd:
4920 * WebKit.vcproj/WebKitLibPreBuild.cmd:
4922 2011-01-04 Chris Fleizach <cfleizach@apple.com>
4924 Reviewed by Sam Weinig.
4926 WK2: Support Accessibility
4927 https://bugs.webkit.org/show_bug.cgi?id=51859
4929 Use rootObject() method to get the top of the AX tree.
4931 * AccessibleDocument.cpp:
4932 (AccessibleDocument::AccessibleDocument):
4934 2011-01-01 Adam Barth <abarth@webkit.org>
4936 Reviewed by Eric Seidel.
4938 Move JavaScriptCore to Source
4939 https://bugs.webkit.org/show_bug.cgi?id=51604
4941 * WebKit.vcproj/WebKit.sln:
4942 - Point to JavaScriptCore in its new location.
4944 2010-12-22 Sam Weinig <sam@webkit.org>
4946 Reviewed by Darin Adler.
4948 WebKit2 needs to mirror the frame tree in the UIProcess
4949 https://bugs.webkit.org/show_bug.cgi?id=51546
4951 - Add client functions to notify that a frame has been added or
4952 removed from the page cache.
4954 * WebCoreSupport/WebFrameLoaderClient.cpp:
4955 (WebFrameLoaderClient::didSaveToPageCache):
4956 (WebFrameLoaderClient::didRestoreFromPageCache):
4957 * WebCoreSupport/WebFrameLoaderClient.h:
4959 2010-12-22 Dan Bernstein <mitz@apple.com>
4961 Changed WebKitTools to Tools.
4963 * WebKit.vcproj/WebKit.sln:
4965 2010-12-14 Adam Roben <aroben@apple.com>
4967 Always record the last-set cursor, even when the UI delegate is
4968 setting the cursor for us
4970 Prior to r63339, the last-set cursor was recorded in Widget::setCursor.
4971 r63339 moved that code up to WebChromeClient, but failed to call it
4972 when the UI delegate was the one setting the cursor.
4974 Fixes <http://webkit.org/b/45692> <rdar://problem/8423464> REGRESSION
4975 (r63339): Mouse cursor disappears when holding mouse button down on
4978 Reviewed by Ada Chan.
4980 * WebCoreSupport/WebChromeClient.cpp:
4981 (WebChromeClient::setCursor): After the cursor is set, regardless of
4982 whether the UI delegate sets it or we set it, record the cursor that
4983 was just set. That way we'll be able to use the cursor later when
4984 responding to the WM_SETCURSOR message.
4986 2010-12-13 Alexey Proskuryakov <ap@apple.com>
4988 Reviewed by Adam Barth.
4990 https://bugs.webkit.org/show_bug.cgi?id=50953
4991 DNS Prefetch should be an opt-in feature
4993 * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default to NO.
4995 2010-10-28 MORITA Hajime <morrita@google.com>
4997 Reviewed by Ojan Vafai.
4999 spellcheck does not check pasted text
5000 https://bugs.webkit.org/show_bug.cgi?id=40092
5002 Added a stub implememntation.
5004 * WebCoreSupport/WebEditorClient.h:
5005 (WebEditorClient::requestCheckingOfString):
5007 2010-12-10 Chris Fleizach <cfleizach@apple.com>
5009 Reviewed by Darin Adler.
5011 AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
5012 https://bugs.webkit.org/show_bug.cgi?id=50574
5014 * AccessibleBase.cpp:
5015 (AccessibleBase::accHitTest):
5017 2010-12-09 Brian Weinstein <bweinstein@apple.com>
5019 Reviewed by Adam Roben.
5021 Prep for WebKit2: Context menu support on Windows
5022 https://bugs.webkit.org/show_bug.cgi?id=50514
5024 Update WebKit for the new CROSS_PLATFORM_CONTEXT_MENUS flag, and define customizeMenu
5025 instead of getCustomMenuFromDefaultItems.
5027 * WebCoreSupport/WebContextMenuClient.cpp:
5028 (WebContextMenuClient::customizeMenu): getCustomMenuFromDefaultItems was turned into
5029 this function, with refactoring using nativeMenu instead of platformDescription.
5030 (WebContextMenuClient::contextMenuItemSelected): Use nativeMenu instead of platformDescription.
5031 * WebCoreSupport/WebContextMenuClient.h:
5033 (WebView::handleContextMenuEvent): Call nativeMenu instead of platformDescription.
5034 (WebView::performContextMenuAction): Only call itemAtIndex with one argument, no need
5037 2010-12-07 Brian Weinstein <bweinstein@apple.com>
5039 Reviewed by John Sullivan.
5041 Layering Violation in ContextMenu - member variable of type HitTestResult
5042 https://bugs.webkit.org/show_bug.cgi?id=50586
5044 Update users of ContextMenu and ContextMenuController to match where the new functions
5047 * WebCoreSupport/WebContextMenuClient.cpp:
5048 (WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the
5049 ContextMenuController (from the page).
5050 (WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
5052 (WebView::handleContextMenuEvent): Ditto.
5054 2010-12-07 Jessie Berlin <jberlin@apple.com>
5056 Build fix. Unreviewed.
5058 * WebCoreSupport/WebContextMenuClient.cpp:
5059 (WebContextMenuClient::searchWithGoogle):
5060 FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.
5062 2010-12-06 Darin Adler <darin@apple.com>
5064 Reviewed by Sam Weinig.
5066 Pass security origin to make local file decision correctly
5067 https://bugs.webkit.org/show_bug.cgi?id=48603
5069 * WebCoreSupport/WebContextMenuClient.cpp:
5070 (WebContextMenuClient::searchWithGoogle): Pass security origin.
5072 2010-12-07 Kenichi Ishibashi <bashi@google.com>
5074 Reviewed by Kent Tamura.
5076 Let HTMLObjectElement be a form associated element
5077 https://bugs.webkit.org/show_bug.cgi?id=48821
5079 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
5082 (WebFrame::elementWithName): Modified to use FormAssociatedElement
5083 instead of HTMLFormControlElement.
5084 (WebFrame::controlsInForm): Ditto.
5086 2010-12-05 Adam Roben <aroben@apple.com>
5088 Windows production build fix
5090 Put spaces after trailing backslashes when setting
5091 %WebKitVSPropsRedirectionDir%. According to MSDN
5092 <http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>:
5094 A backslash ( \ ) followed by a newline character is interpreted as
5095 a space in the command; use a backslash at the end of a line to
5096 continue a command onto the next line. NMAKE interprets the
5097 backslash literally if any other character, including a space or
5098 tab, follows the backslash.
5100 * WebKit.vcproj/WebKit.make:
5102 2010-12-03 Sam Weinig <sam@webkit.org>
5104 Reviewed by Maciej Stachowiak.
5106 Enable <a ping> for Mac/Windows/WebKit2 builds
5107 <rdar://problem/8504473>
5108 https://bugs.webkit.org/show_bug.cgi?id=50488
5110 * WebPreferences.cpp:
5111 (WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.
5113 2010-12-03 Brian Weinstein <bweinstein@apple.com>
5115 Reviewed by Brady Eidson.
5117 WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows
5118 https://bugs.webkit.org/show_bug.cgi?id=50486
5120 Remove the static fixMenuReceivedFromOldSafari and isPreInspectElementTagSafari methods
5121 from WebContextMenuClient. There were there for when WebKit had the Inspect Element context menu
5122 item, but Safari didn't support it. We don't support that old Safari, so that code can go.
5124 * WebCoreSupport/WebContextMenuClient.cpp:
5125 (WebContextMenuClient::getCustomMenuFromDefaultItems):
5127 2010-12-02 John Knottenbelt <jknotten@chromium.org>
5129 Reviewed by Steve Block.
5131 Move requestGeolocationPermissionForFrame to GeolocationClient
5132 https://bugs.webkit.org/show_bug.cgi?id=50061
5134 This change facilitates client-based geolocation implementation by
5135 bringing together permission control into the geolocation client
5138 Move method ChromeClient::requestGeolocationPermissionForFrame to
5139 GeolocationClient::requestPermission. The moved code is unchanged
5140 except that requestPermission now takes only one argument (Geolocation*),
5141 the Frame parameter is retrieved from the Geolocation object and we need to
5142 call m_webView.get() as it is a COMPtr in GeolocationClient.
5144 * WebCoreSupport/WebChromeClient.cpp:
5145 * WebCoreSupport/WebChromeClient.h:
5146 * WebCoreSupport/WebGeolocationClient.cpp:
5147 (WebGeolocationClient::requestPermission):
5148 * WebCoreSupport/WebGeolocationClient.h:
5149 (WebGeolocationClient::cancelPermissionRequest):
5151 2010-12-01 Jia Pu <jpu@apple.com>
5153 Reviewed by Darin Adler.
5155 Support multiple correction candidates panel for misspelled word on Mac OS X.
5156 https://bugs.webkit.org/show_bug.cgi?id=50137
5157 <rdar://problem/8568059>
5159 Adopted new function signature defined in base class.
5161 * WebCoreSupport/WebEditorClient.cpp:
5162 (WebEditorClient::getGuessesForWord):
5163 * WebCoreSupport/WebEditorClient.h:
5165 2010-12-01 Steve Falkenburg <sfalken@apple.com>
5167 Reviewed by Adam Roben.
5169 WinCairo build should not use link-time code generation (LTCG)
5170 https://bugs.webkit.org/show_bug.cgi?id=50353
5172 * WebKit.vcproj/Interfaces.vcproj:
5173 * WebKit.vcproj/WebKit.vcproj:
5174 * WebKit.vcproj/WebKitGUID.vcproj:
5176 2010-12-01 Steve Falkenburg <sfalken@apple.com>
5178 Reviewed by Adam Roben.
5180 vcproj changes can't be applied cleanly by the Windows EWS bot
5181 https://bugs.webkit.org/show_bug.cgi?id=50328
5183 * WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style.
5184 * WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style.
5185 * WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
5186 * WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
5187 * WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style.
5188 * WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style.
5189 * WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style.
5190 * WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style.
5192 2010-11-30 Steve Falkenburg <sfalken@apple.com>
5194 Reviewed by Adam Roben.
5196 All projects on Windows should use cmd files for build events
5197 https://bugs.webkit.org/show_bug.cgi?id=50213
5199 * WebKit.vcproj/InterfacesCommon.vsprops:
5200 * WebKit.vcproj/InterfacesPostBuild.cmd: Added.
5201 * WebKit.vcproj/InterfacesPreBuild.cmd: Added.
5202 * WebKit.vcproj/WebKitGUIDCommon.vsprops:
5203 * WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added.
5204 * WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added.
5205 * WebKit.vcproj/WebKitLibCommon.vsprops:
5206 * WebKit.vcproj/WebKitLibPostBuild.cmd: Added.
5207 * WebKit.vcproj/WebKitLibPreBuild.cmd: Added.
5209 2010-11-29 Brent Fulgham <bfulgham@webkit.org>
5211 Unreviewed build correction.
5213 * WebKit.vcproj/WebKit.vcproj: Update WebKit project to
5214 use WinCairo.vsprops definition for appropriate build targets.
5216 2010-11-22 Adam Roben <aroben@apple.com>
5218 Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
5220 Apple's Windows build allows placing header files and import libraries for WebKit's
5221 dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
5222 $WebKitLibrariesDir environment variable. This is both required for production builds and
5223 convenient for Apple-internal developer builds. Apple's production builds also require that
5224 WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
5225 builds, the files are copied into that directory tree by the
5226 WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
5228 JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
5230 This .vsprops copying is problematic in one very important case: when a developer updates
5231 their source tree and then tries to build. Visual Studio only reads .vsprops files when a
5232 project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
5233 updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
5234 build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
5235 $WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
5236 will proceed with out-of-date .vsprops files, which will likely result in a build failure.
5238 To fix this, we now use normal relative paths to access the .vsprops files in the source
5239 tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
5240 variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
5241 unset, so the normal relative paths are used to read the .vsprops files out of the source
5242 tree directly. In production builds, this environment variable is set to a fake directory
5243 that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
5246 For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
5248 $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
5250 In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
5251 files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
5252 JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
5253 "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
5254 FeatureDefines.vsprops becomes:
5256 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
5260 $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
5262 (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
5263 actually exist since they are matched by an equal number of ".." path components.)
5265 Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
5266 Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
5268 Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
5271 Reviewed by Dave Hyatt.
5273 * WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can
5274 find the .vsprops files.
5276 * WebKit.vcproj/WebKit.vcproj:
5277 * WebKit.vcproj/Interfaces.vcproj:
5278 * WebKit.vcproj/WebKitGUID.vcproj:
5279 Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
5282 2010-11-19 Steve Falkenburg <sfalken@apple.com>
5284 Reviewed by Adam Roben.
5286 Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
5287 https://bugs.webkit.org/show_bug.cgi?id=49819
5289 * WebKit.vcproj/Interfaces.vcproj:
5290 * WebKit.vcproj/WebKit.sln:
5291 * WebKit.vcproj/WebKit.vcproj:
5292 * WebKit.vcproj/WebKitGUID.vcproj:
5294 2010-11-19 Steve Falkenburg <sfalken@apple.com>
5296 Reviewed by Darin Adler.
5298 Normalize Cairo/CFLite project/solution configuration names
5299 https://bugs.webkit.org/show_bug.cgi?id=49818
5301 * WebKit.vcproj/WebKit.sln:
5302 * WebKit.vcproj/WebKit.vcproj:
5304 2010-11-18 Steve Falkenburg <sfalken@apple.com>
5306 Reviewed by Adam Roben.
5308 Windows vcproj configuration names should be normalized across projects
5309 https://bugs.webkit.org/show_bug.cgi?id=49776
5311 * WebKit.vcproj/Interfaces.vcproj:
5312 * WebKit.vcproj/WebKit.sln:
5314 2010-11-18 Steve Falkenburg <sfalken@apple.com>
5316 Reviewed by Adam Roben.
5318 Remove leftover Windows Debug_Internal configurations
5319 https://bugs.webkit.org/show_bug.cgi?id=49758
5321 * WebKit.vcproj/WebKit.vcproj:
5322 * WebKit.vcproj/WebKitGUID.vcproj:
5324 2010-11-18 Steve Falkenburg <sfalken@apple.com>
5326 Reviewed by Adam Roben.
5328 Debug_Internal Windows configuration is unnecessary, should be removed
5329 https://bugs.webkit.org/show_bug.cgi?id=49753
5333 2010-11-17 Steve Falkenburg <sfalken@apple.com>
5335 Reviewed by Adam Roben.
5337 WebKit Interfaces project should use vsprops file for common build settings
5338 https://bugs.webkit.org/show_bug.cgi?id=49713
5340 * WebKit.vcproj/Interfaces.vcproj:
5341 * WebKit.vcproj/InterfacesCommon.vsprops: Added.
5343 2010-11-16 Steve Falkenburg <sfalken@apple.com>
5345 Reviewed by Adam Roben.
5347 Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
5348 https://bugs.webkit.org/show_bug.cgi?id=49632
5350 * WebKit.vcproj/Interfaces.vcproj:
5351 * WebKit.vcproj/WebKit.make:
5352 * WebKit.vcproj/WebKit.sln:
5353 * WebKit.vcproj/WebKit.submit.sln:
5354 * WebKit.vcproj/WebKit.vcproj:
5355 * WebKit.vcproj/WebKitGUID.vcproj:
5357 2010-11-16 Dave Hyatt <hyatt@apple.com>
5359 Reviewed by Dan Bernstein.
5361 https://bugs.webkit.org/show_bug.cgi?id=11004
5363 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
5364 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
5365 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
5366 of the constructor rather than using [NSFont pointSize].
5368 https://bugs.webkit.org/show_bug.cgi?id=49582
5370 Negative leading is not handled correctly. There are two bugs here. The first is that
5371 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
5372 set them before so that we can allow them to be < 0.
5374 The second issue is that we should understand where fonts will end up relative to
5375 our baseline (excluding line height), and only allow those boxes to impact ascent and
5376 descent if the actual font box (without factoring in line height) is above or below the
5377 root line box baseline.
5379 Added fast/css/negative-leading.html
5381 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
5383 * WebPreferences.cpp:
5384 (WebPreferences::initializeDefaultSettings):
5386 2010-11-16 Steve Falkenburg <sfalken@apple.com>
5388 Reviewed by Adam Roben.
5390 Use vsprops files for common settings in Windows WebKit
5391 https://bugs.webkit.org/show_bug.cgi?id=49622
5393 * WebKit.vcproj/WebKit.vcproj:
5394 * WebKit.vcproj/WebKitCommon.vsprops: Added.
5396 2010-11-16 Steve Falkenburg <sfalken@apple.com>
5398 Rubber stamped by Adam Roben.
5400 Remove unnecessary def file, remove outdated def files from vcproj.
5402 * WebKit.vcproj/WebKit.vcproj:
5403 * WebKit.vcproj/WebKit_debug.def: Removed.
5405 2010-11-12 John Knottenbelt <jknotten@chromium.org>
5407 Reviewed by Steve Block.
5409 Rename GeolocationControllerClient to GeolocationClient.
5410 https://bugs.webkit.org/show_bug.cgi?id=49259
5412 * WebCoreSupport/WebGeolocationClient.cpp: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp.
5413 (WebGeolocationClient::WebGeolocationClient):
5414 (WebGeolocationClient::geolocationDestroyed):
5415 (WebGeolocationClient::startUpdating):
5416 (WebGeolocationClient::stopUpdating):
5417 (WebGeolocationClient::lastPosition):
5418 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h.
5419 (WebGeolocationClient::setEnableHighAccuracy):
5420 * WebKit.vcproj/WebKit.vcproj:
5422 (WebView::initWithFrame):
5424 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
5426 Reviewed by David Hyatt.
5428 HTML5 Ruby support should be mandatory feature
5429 https://bugs.webkit.org/show_bug.cgi?id=49272
5431 * WebKitPrefix.h: Touch it to avoid incremental build failure on Windows.
5433 2010-11-08 Alexey Proskuryakov <ap@apple.com>
5437 * WebCoreSupport/WebChromeClient.h: Added namespace prefix.
5439 2010-11-08 Alexey Proskuryakov <ap@apple.com>
5441 Reviewed by Darin Adler.
5443 https://bugs.webkit.org/show_bug.cgi?id=48685
5444 Notify UI process about focused frame
5446 Added an empty implementation of the new ChromeClient method.
5448 * WebCoreSupport/WebChromeClient.cpp:
5449 (WebChromeClient::focusedFrameChanged):
5450 * WebCoreSupport/WebChromeClient.h:
5452 2010-11-07 Adam Barth <abarth@webkit.org>
5454 Reviewed by Eric Seidel.
5456 Rename Cache to MemoryCache
5457 https://bugs.webkit.org/show_bug.cgi?id=49159
5460 (WebCache::statistics):
5464 2010-11-05 Chris Marrin <cmarrin@apple.com>
5466 Reviewed by Simon Fraser.
5468 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
5469 https://bugs.webkit.org/show_bug.cgi?id=49073
5472 (WebFrame::suspendAnimations):
5473 (WebFrame::resumeAnimations):
5475 2010-11-05 Brian Weinstein <bweinstein@apple.com>
5477 Reviewed by Anders Carlsson.
5479 Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html
5480 https://bugs.webkit.org/show_bug.cgi?id=48751
5481 <rdar://problem/8615536>
5483 Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were
5484 running into a case where we were trying to load an empty plugin document, which uses a manual loader, and
5485 PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire
5486 an assert in the PluginStream destructor.
5488 * WebCoreSupport/WebFrameLoaderClient.cpp:
5489 (WebFrameLoaderClient::finishedLoading):
5491 2010-11-05 Chris Marrin <cmarrin@apple.com>
5493 Reviewed by Simon Fraser.
5495 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
5496 https://bugs.webkit.org/show_bug.cgi?id=46945
5499 (WebFrame::suspendAnimations):
5500 (WebFrame::resumeAnimations):
5502 2010-11-05 Patrick Gansterer <paroga@webkit.org>
5504 Reviewed by David Kilzer.
5506 Replace ARRAYSIZE with WTF_ARRAY_LENGTH
5507 https://bugs.webkit.org/show_bug.cgi?id=48903
5509 * WebCoreSupport/WebChromeClient.cpp:
5510 (WebChromeClient::exceededDatabaseQuota):
5512 (DllGetClassObject):
5514 (WebView::mouseWheel):
5516 2010-11-02 Daniel Bates <dbates@rim.com>
5518 Reviewed by Adam Barth.
5520 For unnamed frames, window.name returns a generated name
5521 https://bugs.webkit.org/show_bug.cgi?id=6751
5525 Substitute FrameTree::uniqueName() for FrameTree::name() in the Apple Windows port.
5530 2010-11-02 Brady Eidson <beidson@apple.com>
5532 Reviewed by Anders Carlsson.
5534 <rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
5535 Implement IMutableWebRequest::setTimeoutInterval
5537 * WebMutableURLRequest.cpp:
5538 (WebMutableURLRequest::setTimeoutInterval):
5540 2010-11-02 Daniel Bates <dbates@rim.com>
5542 Reviewed by Martin Robinson.
5544 Set frame name before appending it to the frame tree in the Apple Windows,
5546 https://bugs.webkit.org/show_bug.cgi?id=48806
5548 Make the frame creation process in the Apple Windows-port consistent
5549 with the Mac, Qt, and Haiku ports. In particular, set the name of
5550 the new frame before it's appended to the frame tree.
5552 At this time we cannot test this change since it is being masked by
5553 HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
5554 We'll be able to test this once we fix bug #6751.
5556 * WebCoreSupport/WebFrameLoaderClient.cpp:
5557 (WebFrameLoaderClient::createFrame):
5559 2010-11-01 Jenn Braithwaite <jennb@chromium.org>
5561 Reviewed by Adam Roben.
5563 Windows: Update resource tracking when moving a frame between documents
5564 https://bugs.webkit.org/show_bug.cgi?id=48364
5566 * Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added
5567 Added removeIdentifierForRequest.
5568 * Interfaces/WebKit.idl:
5569 Added IWebResourceLoadDelegatePrivate2.idl.
5570 * WebCoreSupport/WebFrameLoaderClient.cpp:
5571 (WebFrameLoaderClient::transferLoadingResourceFromPage):
5573 2010-11-01 Brady Eidson <beidson@apple.com>
5575 Reviewed by Anders Carlsson.
5577 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
5578 Context menu support for WebKit 2.
5580 * WebCoreSupport/WebChromeClient.h:
5581 (WebChromeClient::showContextMenu):
5583 2010-11-01 Adam Roben <aroben@apple.com>
5585 Cancel main resource loads after we hand them off to the media engine
5587 This is the Windows equivalent of r51104. Clearly this code should be
5588 moved to a cross-platform location someday.
5590 Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
5591 failure in DocumentLoader::commitData when loading a media document in
5594 Reviewed by Dan Bernstein.
5596 * WebCoreSupport/WebFrameLoaderClient.cpp:
5597 (WebFrameLoaderClient::committedLoad): Cancel the main resource load
5598 after handing off the load to the media engine. This code originally
5599 came from -[WebHTMLRepresentation receivedData:withDataSource:].
5602 (WebFrame::shouldFallBack): Don't fall back when handing the resource
5603 load off to the media engine or a plugin. Added error domain checking
5604 so that we don't rely on error codes being unique.
5606 2010-10-29 Daniel Bates <dbates@rim.com>
5608 No review, rolling out 70971.
5609 http://trac.webkit.org/changeset/70971
5610 https://bugs.webkit.org/show_bug.cgi?id=6751
5612 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
5613 it caused layout test failures on all bots. In particular, the
5614 child count in a generated frame name differs after this patch. We need
5615 to look into this further.
5620 2010-10-28 Antonio Gomes <agomes@rim.com>
5622 Reviewed by Ojan Vafai.
5624 Needs a "LinuxEditingBehavior", perhaps with a better name
5625 https://bugs.webkit.org/show_bug.cgi?id=36627
5627 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
5629 * Interfaces/IWebPreferences.idl:
5631 2010-10-29 Daniel Bates <dbates@rim.com>
5633 Reviewed by Adam Barth.
5635 For unnamed frames, window.name returns a generated name
5636 https://bugs.webkit.org/show_bug.cgi?id=6751
5638 Modified Apple Windows-port to use FrameTree::uniqueName().
5643 2010-10-29 Darin Adler <darin@apple.com>
5645 Reviewed by Sam Weinig.
5647 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
5648 https://bugs.webkit.org/show_bug.cgi?id=48574
5650 * WebBackForwardList.cpp:
5651 (backForwardListWrappers):
5652 (WebBackForwardList::WebBackForwardList):
5653 (WebBackForwardList::createInstance):
5654 * WebBackForwardList.h:
5656 (WebView::backForwardList):
5657 Use BackForwardListImpl.
5659 2010-10-29 Adam Roben <aroben@apple.com>
5663 * WebKitPrefix.h: Touched to force a rebuild.
5665 2010-10-29 Alexey Proskuryakov <ap@apple.com>
5667 Reviewed by Darin Adler.
5669 https://bugs.webkit.org/show_bug.cgi?id=48576
5670 Let WebKit2 client know when a frame is a frameset
5672 Added a blank implementation of the new FrameLoaderClient method.
5674 * WebCoreSupport/WebFrameLoaderClient.h:
5675 * WebCoreSupport/WebFrameLoaderClient.cpp:
5676 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
5678 2010-10-26 Brent Fulgham <bfulgham@webkit.org>
5680 Unreviewed build fix.
5682 * WebView.cpp: Conditionalize includes for CFNetwork-specific
5683 Cookie implementation.
5684 * WebView.h: Conditionalize includes for ACCELERATED_COMPOSITION.
5685 WinCairo doesn't use CoreAnimation.
5687 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
5689 Reviewed by Dmitry Titov.
5691 Resource tracking failure when trying to move a frame between documents
5692 https://bugs.webkit.org/show_bug.cgi?id=44713
5694 * WebCoreSupport/WebFrameLoaderClient.cpp:
5695 (WebFrameLoaderClient::transferLoadingResourceFromPage):
5697 * WebCoreSupport/WebFrameLoaderClient.h:
5699 2010-10-25 Patrick Gansterer <paroga@webkit.org>
5701 Reviewed by David Kilzer.
5703 Replace _countof with WTF_ARRAY_LENGTH
5704 https://bugs.webkit.org/show_bug.cgi?id=48229
5706 * WebCoreSupport/WebContextMenuClient.cpp:
5707 (isPreInspectElementTagSafari):
5709 (WebView::interpretKeyEvent):
5711 2010-10-24 Dan Bernstein <mitz@apple.com>
5715 * Interfaces/WebKit.idl: Touched.
5717 2010-10-24 Dan Bernstein <mitz@apple.com>
5719 Reviewed by Anders Carlsson.
5721 Expose HitTestResult::absoluteMediaURL() via WebKit API
5722 https://bugs.webkit.org/show_bug.cgi?id=48219
5724 * Interfaces/IWebView.idl: Added WebElementMediaURLKey.
5725 * WebElementPropertyBag.cpp:
5726 (WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL().
5728 2010-10-22 Andy Estes <aestes@apple.com>
5730 Fix the Windows build.
5732 * WebCookieManagerCFNet.cpp: Rename CookieStorageWin.h to CookieStorageCFNet.h.
5733 * WebView.cpp: Ditto.
5735 2010-10-22 Jenn Braithwaite <jennb@chromium.org>
5737 Reviewed by Adam Roben.
5739 Windows client needs updating when live iframe element is moved between pages
5740 https://bugs.webkit.org/show_bug.cgi?id=46915
5742 * WebCoreSupport/WebFrameLoaderClient.cpp:
5743 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
5744 Update WebView in WebFrame to match that of the current page.
5746 (WebFrame::setWebView):
5750 2010-10-22 Sam Weinig <sam@webkit.org>
5754 * WebCoreSupport/WebChromeClient.h:
5756 2010-10-22 Sam Weinig <sam@webkit.org>
5758 Reviewed by Anders Carlsson.
5760 WebKit2 needs to pass the current event modifier flags when requesting a new window
5761 https://bugs.webkit.org/show_bug.cgi?id=48140
5763 * WebCoreSupport/WebChromeClient.cpp:
5764 (WebChromeClient::createWindow):
5765 * WebCoreSupport/WebFrameLoaderClient.cpp:
5766 (WebFrameLoaderClient::dispatchCreatePage):
5767 * WebCoreSupport/WebFrameLoaderClient.h:
5768 Add NavigationAction parameter.
5770 2010-10-21 MORITA Hajime <morrita@google.com>
5772 Unreviewed, touched it to fix the build.
5774 * Interfaces/WebKit.idl:
5776 2010-10-21 MORITA Hajime <morrita@google.com>
5778 Reviewed by Kent Tamura.
5780 [Win][DRT] should have LayoutTestController.hasSpellingMarker()
5781 https://bugs.webkit.org/show_bug.cgi?id=47885
5783 Added IWebFramePrivate::hasSpellingMarker() and impelmented it for
5784 LayoutTestController.
5786 * Interfaces/IWebFramePrivate.idl:
5788 (WebFrame::hasSpellingMarker):
5791 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
5793 Reviewed by David Levin.
5795 Repost the DatabaseTracker notifications to the main thread, if needed.
5796 https://bugs.webkit.org/show_bug.cgi?id=40655
5798 * WebDatabaseManager.cpp:
5799 (DidModifyOriginData::dispatchToMainThread):
5800 (DidModifyOriginData::DidModifyOriginData):
5801 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
5802 (WebDatabaseManager::dispatchDidModifyOrigin):
5803 (WebDatabaseManager::dispatchDidModifyDatabase):
5805 2010-10-20 Dirk Schulze <krit@webkit.org>
5807 Reviewed by Nikolas Zimmermann.
5809 Merge ColorSpace and ImageColorSpace enums
5810 https://bugs.webkit.org/show_bug.cgi?id=47922
5812 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
5813 to follow webkit style rules.
5815 * FullscreenVideoController.cpp:
5818 (FullscreenVideoController::draw):
5819 * WebCoreSupport/WebDragClient.cpp:
5820 (WebDragClient::createDragImageForLink):
5821 * WebKitGraphics.cpp:
5824 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
5826 Reviewed by Timothy Hatcher.
5828 Web Inspector: disable private browsing for inspector
5829 https://bugs.webkit.org/show_bug.cgi?id=47827
5831 * WebCoreSupport/WebInspectorClient.cpp:
5832 (WebInspectorClient::openInspectorFrontend):
5834 2010-10-17 Adam Barth <abarth@webkit.org>
5836 Reviewed by Dimitri Glazkov.
5838 FrameLoader doesn't need an explicit userGesture parameter
5839 https://bugs.webkit.org/show_bug.cgi?id=47777
5841 Update for the new API.
5843 * WebCoreSupport/WebContextMenuClient.cpp:
5844 (WebContextMenuClient::searchWithGoogle):
5846 2010-10-15 Brian Weinstein <bweinstein@apple.com>
5848 Reviewed by Sam Weinig.
5850 REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
5851 https://bugs.webkit.org/show_bug.cgi?id=47753
5852 <rdar://problem/8558242>
5854 VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
5855 when we turn it into a WebCore string, or else concatenation using this string will break.
5859 2010-10-15 Jessie Berlin <jberlin@apple.com>
5861 Windows build fix. Unreviewed.
5863 * WebCoreSupport/WebInspectorClient.cpp:
5864 Add a missing include.
5866 2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
5868 Reviewed by Dirk Schulze.
5870 Replace some String::format() usages by StringConcatenate in WebKit
5871 https://bugs.webkit.org/show_bug.cgi?id=47714
5873 * WebCoreSupport/WebInspectorClient.cpp:
5874 (WebInspectorFrontendClient::updateWindowTitle):
5876 (WebView::standardUserAgentWithApplicationName):
5879 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
5881 Reviewed by Pavel Feldman.
5883 Web Inspector: inspector settings/properties/states management
5884 should be extracted into separate class.
5886 We have a lot of flags/values in InspectorController.
5887 Some flags are persisting into profile.
5888 Others are part of inspector state for frontend.
5889 All these flags should keep their values after navigation.
5890 It'd be better to extract these flags/values into separate
5891 class which will care about theirs lifetime.
5893 https://bugs.webkit.org/show_bug.cgi?id=47275
5895 * WebCoreSupport/WebInspectorClient.cpp:
5896 (WebInspectorFrontendClient::attachWindow):
5897 (WebInspectorFrontendClient::detachWindow):
5898 (WebInspectorFrontendClient::showWindowWithoutNotifications):
5900 2010-10-13 Gavin Barraclough <barraclough@apple.com>
5902 Reviewed by Oliver Hunt.
5904 https://bugs.webkit.org/show_bug.cgi?id=43987
5905 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
5906 to construct their internal result string. Remove ScriptString (this is now
5909 * WebCoreSupport/WebFrameLoaderClient.cpp:
5911 2010-10-12 Adam Roben <aroben@apple.com>
5913 Build TestWebKitAPI on Windows
5915 Fixes <http://webkit.org/b/47552> <rdar://problem/8541708> Make
5916 TestWebKitAPI work on Windows
5918 Reviewed by Sam Weinig.
5920 * WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and
5921 TestWebKitAPIGenerated and made them build just after
5924 2010-10-11 Shinichiro Hamaji <hamaji@chromium.org>
5926 Attempt to fix windows build failure.
5928 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
5929 https://bugs.webkit.org/show_bug.cgi?id=47523
5931 * Interfaces/IWebFramePrivate.idl: s/unused1/unused2/
5932 * Interfaces/WebKit.idl: Touched.
5933 * WebFrame.cpp: s/unused1/unused2/
5934 (WebFrame::unused2):
5935 * WebFrame.h: s/unused1/unused2/
5937 2010-10-11 Anders Carlsson <andersca@apple.com>
5939 Reviewed by Darin Adler.
5941 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
5942 https://bugs.webkit.org/show_bug.cgi?id=47523
5944 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
5946 * Interfaces/IWebFramePrivate.idl:
5947 * Interfaces/IWebIconFetcher.idl: Removed.
5948 * Interfaces/WebKit.idl:
5950 (WebFrame::unused1):
5952 * WebIconFetcher.cpp: Removed.
5953 * WebIconFetcher.h: Removed.
5954 * WebKit.vcproj/Interfaces.vcproj:
5955 * WebKit.vcproj/WebKit.vcproj:
5957 2010-10-11 Jessie Berlin <jberlin@apple.com>
5959 Reviewed by Darin Adler.
5961 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
5962 representation of a WebKit1 WebSerializedJSValue.
5963 https://bugs.webkit.org/show_bug.cgi?id=47439
5965 * Interfaces/IWebSerializedJSValuePrivate.idl:
5966 Because it is taking a void** parameter, getInternalRepresentation must be declared [local].
5968 * WebSerializedJSValue.cpp:
5969 (WebSerializedJSValue::getInternalRepresentation):
5970 * WebSerializedJSValue.h:
5972 2010-10-07 Jessie Berlin <jberlin@apple.com>
5974 Reviewed by Sam Weinig.
5976 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
5977 representation of a WebKit2 WebSerializedScriptValue.
5978 https://bugs.webkit.org/show_bug.cgi?id=47390
5980 * Interfaces/WebKit.idl:
5981 Generate IWebSerializedJSValuePrivate.
5983 * Interfaces/IWebSerializedJSValuePrivate.idl: Added.
5984 Because it is taking a void* parameter, setInternalRepresentation must be declared [local].
5986 * WebKit.vcproj/Interfaces.vcproj:
5987 Add IWebSerializedJSValue.idl and IWebSerializedJSValuePrivate.idl.
5989 * WebSerializedJSValue.cpp:
5990 (WebSerializedJSValue::QueryInterface):
5991 Since there are now two interfaces that inherit from IUnknown, do not try to cast to
5992 IUnknown* anymore. Cast to IWebSerializedJSValue* instead.
5993 (WebSerializedJSValue::setInternalRepresentation):
5994 Only set the internal representation if it hasn't already been set.
5995 * WebSerializedJSValue.h:
5997 2010-10-04 Jon Honeycutt <jhoneycutt@apple.com>
5999 Prevent an assertion failure when trying to create a protection space
6002 Reviewed by Sam Weinig.
6004 * WebURLProtectionSpace.cpp:
6005 (WebURLProtectionSpace::initWithHost):
6006 Remove the ASSERT_NOT_REACHED().
6008 2010-10-05 Brent Fulgham <bfulgham@webkit.org>
6010 Unreviewed build correction.
6012 * WebKit.vcproj/WebKit.sln: Turn the QTMovieWin project
6013 off for WinCairo release builds. Somehow this was
6014 incorrectly turned on.
6016 2010-10-01 Mark Rowe <mrowe@apple.com>
6020 Clear the executable bit from a number of source files.
6025 2010-09-30 Darin Adler <darin@apple.com>
6027 Reviewed by Sam Weinig.
6029 Remove remaining calls to deprecatedParseURL
6030 https://bugs.webkit.org/show_bug.cgi?id=26599
6032 * WebCoreSupport/WebFrameLoaderClient.cpp:
6033 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
6034 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
6036 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
6038 Reviewed by Dmitry Titov.
6040 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
6041 https://bugs.webkit.org/show_bug.cgi?id=46663
6043 * WebCoreSupport/WebFrameLoaderClient.cpp:
6044 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
6045 * WebCoreSupport/WebFrameLoaderClient.h:
6047 2010-09-27 Andrey Kosyakov <caseq@chromium.org>
6049 Unreviewed build fix (win; broken in r68371)
6051 * WebFrame.cpp: remove include <WebCore/ResourceHandleWin.h>
6053 2010-09-23 Matthew Delaney <mdelaney@apple.com>
6055 Reviewed by Simon Fraser.
6057 Reduce minimum DOMTimer interval
6058 https://bugs.webkit.org/show_bug.cgi?id=45362
6061 Updating set interval call to use Settings' static version inside
6062 one time init block.
6064 2010-09-23 Nate Chapin <japhet@chromium.org>
6066 Unreviewed, build fix.
6068 Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl
6069 and touch WebKit.idl
6071 * Interfaces/IWebPreferences.idl:
6072 * Interfaces/IWebPreferencesPrivate.idl:
6073 * Interfaces/WebKit.idl:
6075 (WebView::notifyPreferencesChanged):
6077 2010-09-23 Nate Chapin <japhet@chromium.org>
6079 Unreviewed, build fix.
6081 Look for hyperlinkAuditingEnabled in the right set of preferences.
6084 (WebView::notifyPreferencesChanged):
6086 2010-09-23 Nate Chapin <japhet@chromium.org>
6088 Reviewed by Darin Fisher.
6090 Add hyperlink auditing settings (i.e., <a ping>).
6091 https://bugs.webkit.org/show_bug.cgi?id=30458
6093 * Interfaces/IWebPreferences.idl:
6094 * WebPreferenceKeysPrivate.h:
6095 * WebPreferences.cpp:
6096 (WebPreferences::initializeDefaultSettings):
6097 (WebPreferences::hyperlinkAuditingEnabled):
6098 (WebPreferences::setHyperlinkAuditingEnabled):
6101 (WebView::notifyPreferencesChanged):
6103 2010-09-23 Matthew Delaney <mdelaney@apple.com>
6105 Reviewed by Adam Roben.
6107 Create one time initialization block for WebView's initWithFrame
6108 https://bugs.webkit.org/show_bug.cgi?id=46307
6110 * WebView.cpp: Added one time initialization block for webview code
6111 that needs only be run once and not for each webview. This is just as
6112 the mac version WebView.mm does.
6114 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
6116 Reviewed by Martin Robinson.
6118 [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
6119 https://bugs.webkit.org/show_bug.cgi?id=46303.
6121 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
6122 Release_Cairo configurations to select appropriate build
6123 targets for WebKitTestRunner and MiniBrowser.
6125 2010-09-22 Brent Fulgham <bfulgham@webkit.org>
6127 Reviewed by Martin Robinson.
6129 [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.rt
6130 https://bugs.webkit.org/show_bug.cgi?id=46303.
6132 * WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
6133 Release_Cairo configurations to select appropriate build
6134 targets for InjectionBundle.
6136 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
6138 Reviewed by Kenneth Rohde Christiansen.
6140 PluginStrategy should satisfy the needs of Qt
6141 https://bugs.webkit.org/show_bug.cgi?id=45857
6142 No new functionality so no new tests.
6144 * WebCoreSupport/WebPlatformStrategies.cpp:
6145 (WebPlatformStrategies::getPluginInfo):
6146 * WebCoreSupport/WebPlatformStrategies.h:
6148 2010-09-20 Philippe Normand <pnormand@igalia.com>
6150 Reviewed by Eric Carlson.
6152 [GTK] enhanced context menu for media elements
6153 https://bugs.webkit.org/show_bug.cgi?id=45021
6155 New localized strings for the media element context-menu.
6157 * WebCoreSupport/WebPlatformStrategies.cpp:
6158 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
6159 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
6160 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
6161 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
6162 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
6163 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
6164 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
6165 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
6166 (WebPlatformStrategies::contextMenuItemTagMediaPause):
6167 (WebPlatformStrategies::contextMenuItemTagMediaMute):
6168 * WebCoreSupport/WebPlatformStrategies.h:
6170 2010-09-17 Darin Adler <darin@apple.com>
6172 Reviewed by Sam Weinig.
6174 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
6175 https://bugs.webkit.org/show_bug.cgi?id=42863
6178 (WebView::setZoomMultiplier):
6179 Call functions on Frame instead of FrameView.
6181 2010-09-17 Matthew Delaney <mdelaney@apple.com>
6183 Reviewed by Simon Fraser.
6185 Reduce minimum DOMTimer interval
6186 https://bugs.webkit.org/show_bug.cgi?id=45362
6188 * WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
6190 2010-09-17 Simon Fraser <simon.fraser@apple.com>
6192 Reviewed by Chris Marrin.
6194 Remove scroll and clip layers for WKCACFLayerRenderer
6195 https://bugs.webkit.org/show_bug.cgi?id=45922
6197 WKCACFLayerRenderer no longer needs its own layers for managing scrolling
6198 and clipping, because RenderLayerCompositor provides this functionality.
6201 (WebView::sizeChanged): Moved code that handles the WM_SIZE message
6202 into this method. Use it to resize the layer renderer.
6203 (WebView::WebViewWndProc): Call sizeChanged().
6204 (WebView::updateRootLayerContents): No need to call setScrollFrame() any more.
6205 (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
6208 2010-09-16 Darin Adler <darin@apple.com>
6210 Reviewed by Andreas Kling.
6212 Reduce use of HTMLInputElement::inputType so we can remove it later
6213 https://bugs.webkit.org/show_bug.cgi?id=45903
6216 (WebFrame::elementDoesAutoComplete): Use isPasswordField.
6217 (WebFrame::elementIsPassword): Use isPasswordField.
6219 2010-09-14 Ada Chan <adachan@apple.com>
6221 Reviewed by Adam Roben.
6223 Add an IWebFramePrivate API to load string as plain text into the WebFrame.
6224 https://bugs.webkit.org/show_bug.cgi?id=45782
6226 * Interfaces/IWebFramePrivate.idl:
6227 * Interfaces/WebKit.idl: Touch the file.
6229 (WebFrame::loadPlainTextString):
6232 2010-09-13 Enrica Casucci <enrica@apple.com>
6234 Reviewed by Sam Weinig.
6236 Paste should be implemented in WebCore like Copy and Cut for Mac also.
6237 https://bugs.webkit.org/show_bug.cgi?id=45494
6238 <rdar://problem/7660537>
6240 On the Mac platform, the implementation of the paste operation is all done
6241 at the WebKit level. In order to support it on WebKit2 it is necessary to
6242 refactor the code and move this functionality at the level of WebCore like
6243 we already have on Windows.
6244 The original code relies on some in AppKit functions that call back into
6245 WebKit causing problems in WebKit2. All this functionality has been moved
6246 at the level of the editor client where it can be dealt with appropriately.
6249 (WebFrame::canShowMIMETypeASHTML): Added.
6251 2010-09-11 Adam Barth <abarth@webkit.org>
6253 Reviewed by Sam Weinig.
6255 Make SecurityOrigin::canDisplay an instance function
6256 https://bugs.webkit.org/show_bug.cgi?id=45219
6259 (WebFrame::allowsFollowingLink):
6261 2010-09-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
6263 Reviewed by Darin Adler.
6265 Add NetworkingContext to avoid layer violations
6266 https://bugs.webkit.org/show_bug.cgi?id=42292
6268 * WebCoreSupport/WebFrameNetworkingContext.cpp:
6269 (WebFrameNetworkingContext::blockedError):
6270 * WebCoreSupport/WebFrameNetworkingContext.h:
6272 2010-09-10 Jer Noble <jer.noble@apple.com>
6274 Reviewed by Simon Fraser.
6276 Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
6277 https://bugs.webkit.org/show_bug.cgi?id=45333
6279 The rootChild layer must be set as flipped, otherwise transformed movies will appear
6280 incorrectly rotated.
6282 * FullscreenVideoController.cpp:
6283 (FullscreenVideoController::enterFullscreen):
6285 2010-09-10 Sam Weinig <sam@webkit.org>
6287 Reviewed by Darin Adler.
6289 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
6290 Precursor to <rdar://problem/7660657>
6291 https://bugs.webkit.org/show_bug.cgi?id=45522
6299 (WebView::setZoomMultiplier):
6300 (WebView::zoomMultiplier):
6301 (WebView::canMakeTextLarger):
6302 (WebView::makeTextLarger):
6303 (WebView::canMakeTextSmaller):
6304 (WebView::makeTextSmaller):
6305 (WebView::notifyPreferencesChanged):
6307 Move tracking of text only zoom here from WebCore.
6309 2010-09-10 Brian Weinstein <bweinstein@apple.com>
6311 Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
6312 SelectionController instead of frame. Also fix a style issue.
6315 (WebFrame::currentForm):
6317 2010-09-10 Adam Barth <abarth@webkit.org>
6319 Reviewed by Darin Fisher.
6321 Move code from WebKit-layer to DocumentLoader
6322 https://bugs.webkit.org/show_bug.cgi?id=45569
6324 * WebCoreSupport/WebFrameLoaderClient.cpp:
6325 (WebFrameLoaderClient::committedLoad):
6326 * WebCoreSupport/WebFrameLoaderClient.h:
6328 2010-09-09 Darin Adler <darin@apple.com>
6330 Reviewed by Adam Barth.
6332 Move functions from Frame to SelectionController as planned
6333 https://bugs.webkit.org/show_bug.cgi?id=45508
6336 (WebView::selectionRect):
6337 (WebView::centerSelectionInVisibleArea):
6338 Call functions on selection().
6340 2010-09-10 Adam Barth <abarth@webkit.org>
6342 Reviewed by Eric Seidel.
6344 Main resource bytes shouldn't bounce through FrameLoader
6345 https://bugs.webkit.org/show_bug.cgi?id=45496
6347 Now return the bytes to the DocumentLoader.
6349 * WebCoreSupport/WebFrameLoaderClient.cpp:
6350 (WebFrameLoaderClient::receivedData):
6352 2010-09-09 Simon Fraser <simon.fraser@apple.com>
6354 Reviewed by Adam Roben.
6356 Scrollbars fail to render in composited iframes.
6357 https://bugs.webkit.org/show_bug.cgi?id=45335
6359 Use LocalWindowsContext when painting scrollbars.
6361 * WebCoreSupport/WebChromeClient.cpp:
6362 (WebChromeClient::paintCustomScrollbar):
6363 (WebChromeClient::paintCustomScrollCorner):
6365 2010-09-08 Darin Adler <darin@apple.com>
6367 Reviewed by Adam Barth.
6369 Move functions from Frame to Editor as planned
6370 https://bugs.webkit.org/show_bug.cgi?id=45218
6372 * WebCoreSupport/WebContextMenuClient.cpp:
6373 (WebContextMenuClient::searchWithGoogle):
6375 (WebFrame::selectedString):
6377 (WebView::selectedText):
6378 (WebView::prepareCandidateWindow):
6379 (WebView::onIMERequestCharPosition):
6380 Changed call sites to use editor().
6382 2010-09-08 Peter Kasting <pkasting@google.com>
6384 Not reviewed, build fix.
6387 (WebScrollBar::setScrollOffsetFromAnimation):
6389 2010-09-08 Peter Kasting <pkasting@google.com>
6391 Not reviewed, build fix.
6394 (WebScrollBar::scrollSize):
6395 (WebScrollBar::setScrollOffsetFromAnimation):
6397 2010-09-08 Peter Kasting <pkasting@google.com>
6399 Not reviewed, build fix.
6402 (WebScrollBar::setValue):
6403 (WebScrollBar::scrollSize):
6404 (WebScrollBar::setScrollOffsetFromAnimation):
6407 2010-09-08 Adam Barth <abarth@webkit.org>
6409 Attempted Window build fix.
6411 * WebDataSource.cpp:
6412 (WebDataSource::subresourceForURL):
6414 2010-09-08 Adam Barth <abarth@webkit.org>
6416 Rubber-stamped by Eric Seidel.
6418 Rename DocLoader to CachedResourceLoader because that's what it does.
6420 * WebDataSource.cpp:
6422 2010-09-07 Brent Fulgham <bfulgham@webkit.org>
6424 Reviewed by Adam Roben.
6426 Clean up a potential resource leak.
6427 https://bugs.webkit.org/show_bug.cgi?id=45198
6429 Several bitmap device context were being created and used,
6430 and destroyed without returning the context to its original
6431 state. This showed up as bitmap leaks in BoundsChecker.
6433 * FullscreenVideoController.cpp:
6435 (WebView::scrollBackingStore):
6438 2010-09-06 Adam Barth <abarth@webkit.org>
6440 Reviewed by Darin Adler.
6442 Rename SecurityOrigin::canLoad to canDisplay
6443 https://bugs.webkit.org/show_bug.cgi?id=45214
6445 Propagate name change.
6448 (WebFrame::allowsFollowingLink):
6450 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
6452 Reviewed by Darin Adler.
6454 Add NetworkingContext to avoid layer violations
6455 https://bugs.webkit.org/show_bug.cgi?id=42292
6457 Add Win's specific implementation of NetworkingContext.
6459 * WebCoreSupport/WebFrameNetworkingContext.cpp:
6460 (WebFrameNetworkingContext::create):
6461 (WebFrameNetworkingContext::userAgent):
6462 (WebFrameNetworkingContext::referrer):
6464 (WebFrame::createNetworkingContext):
6467 2010-09-03 Adam Roben <aroben@apple.com>
6469 Attempt to fixing Windows nightlies again
6471 The fix in r66438 should be sufficient, but we have to touch
6472 WebKit.idl to force that change to be picked up by the build.
6474 * Interfaces/WebKit.idl: Touched this file to force a build.
6476 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
6478 Reviewed by PavelFeldman.
6480 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
6481 https://bugs.webkit.org/show_bug.cgi?id=44230
6483 * WebCoreSupport/WebInspectorClient.cpp:
6484 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
6485 (WebInspectorFrontendClient::closeWindow):
6486 (WebInspectorFrontendClient::disconnectFromBackend):
6487 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
6488 (WebInspectorFrontendClient::destroyInspectorView):
6489 * WebCoreSupport/WebInspectorClient.h:
6491 2010-09-01 Jessie Berlin <jberlin@apple.com>
6493 Reviewed by Adam Roben.
6495 WebViews should allow their parent windows to handle WM_MOUSEACTIVATE messages.
6496 https://bugs.webkit.org/show_bug.cgi?id=45047
6499 (WebView::WebViewWndProc):
6501 2010-08-31 Dave Hyatt <hyatt@apple.com>
6503 Reviewed by Sam Weinig.
6505 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
6506 the former can occur in more places without having to do the latter.
6509 (WebFrame::paintDocumentRectToContext):
6511 (WebView::updateBackingStore):
6513 2010-08-30 Adam Roben <aroben@apple.com>
6515 Fix crash on launch on Windows due to changing IWebFramePrivate's
6518 This regressed in r65107.
6520 Fixes <http://webkit.org/b/44755>.
6522 Rubber-stamped by Jon Honeycutt.
6524 * Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and
6525 resumeAnimations to the end of the interface so that the vtable will
6526 match what Safari expects.
6528 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
6530 Unreviewed, rolling out r66198.
6531 http://trac.webkit.org/changeset/66198
6532 https://bugs.webkit.org/show_bug.cgi?id=44856
6534 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
6536 * WebCoreSupport/WebInspectorClient.cpp:
6537 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
6538 (WebInspectorFrontendClient::closeWindow):
6539 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
6540 (WebInspectorFrontendClient::destroyInspectorView):
6541 * WebCoreSupport/WebInspectorClient.h:
6543 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
6545 Reviewed by Pavel Feldman.
6547 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
6548 https://bugs.webkit.org/show_bug.cgi?id=44230
6550 * WebCoreSupport/WebInspectorClient.cpp:
6551 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
6552 (WebInspectorFrontendClient::closeWindow):
6553 (WebInspectorFrontendClient::disconnectFromBackend):
6554 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
6555 (WebInspectorFrontendClient::destroyInspectorView):
6556 * WebCoreSupport/WebInspectorClient.h:
6558 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
6560 Unreviewed. Revert r66103 since Qt tests are failing.
6562 * WebCoreSupport/WebInspectorClient.cpp:
6563 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
6564 (WebInspectorFrontendClient::closeWindow):
6565 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
6566 (WebInspectorFrontendClient::destroyInspectorView):
6567 * WebCoreSupport/WebInspectorClient.h:
6569 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
6571 Reviewed by Pavel Feldman.
6573 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
6574 https://bugs.webkit.org/show_bug.cgi?id=44230
6576 * WebCoreSupport/WebInspectorClient.cpp:
6577 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
6578 (WebInspectorFrontendClient::closeWindow):
6579 (WebInspectorFrontendClient::disconnectFromBackend):
6580 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
6581 (WebInspectorFrontendClient::destroyInspectorView):
6582 * WebCoreSupport/WebInspectorClient.h:
6584 2010-08-24 Ada Chan <adachan@apple.com>
6586 Reviewed by Steve Falkenburg.
6588 <rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType.
6589 https://bugs.webkit.org/show_bug.cgi?id=44564
6592 (WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL
6593 if plugins are disabled.
6595 2010-08-22 Daniel Bates <dbates@rim.com>
6597 Reviewed by Eric Seidel.
6599 Encapsulate document marker management into DocumentMarkerController
6600 https://bugs.webkit.org/show_bug.cgi?id=44383
6602 Modify call sites in the Apple Windows port to use DocumentMarkerController.
6604 No functionality was changed, so no new tests.
6607 (WebFrame::unmarkAllMisspellings):
6608 (WebFrame::unmarkAllBadGrammar):
6610 (WebView::rectsForTextMatches):
6612 2010-08-18 Jessie Berlin <jberlin@apple.com>
6614 Reviewed by Adam Roben.
6616 Bug 44180 - WebView::paint fails to paint a child WebView of a Layered Window.
6617 https://bugs.webkit.org/show_bug.cgi?id=44180
6619 Decide to end painting if the m_backingStoreBitmap is null after the call to
6620 ensureBackingStore() instead of when the rcPaint rect filled by BeginPaint is empty.
6621 The rcPaint rect filled by BeginPaint is always empty for a child WebView of a Layered
6622 Window, even if GetUpdateRect and GetUpdateRgn report a non-empty region that needs
6628 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
6630 Reviewed by Darin Adler.
6632 Add NetworkingContext to avoid layer violations
6633 https://bugs.webkit.org/show_bug.cgi?id=42292
6635 Preparation: Just add the files to the build system.
6637 * WebCoreSupport/WebFrameNetworkingContext.cpp: Added.
6638 Empty placeholder for now.
6639 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
6640 Placeholder with tentative code that might be changed when landing
6642 * WebKit.vcproj/WebKit.vcproj: Added new files.
6644 2010-08-17 Brady Eidson <beidson@apple.com>
6646 Reviewed by Sam Weinig.
6648 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
6649 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
6652 (WebView::canGoBack): Return false if loads are deferred.
6653 (WebView::canGoForward): Ditto.
6655 2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
6657 Unreviewed; build fix attempt for Windows.
6659 * DefaultDownloadDelegate.cpp:
6661 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
6664 https://bugs.webkit.org/show_bug.cgi?id=43794
6667 (WebView::initWithFrame):
6669 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
6671 Build fix. Matches solutions in qt and mac ports for
6672 https://bugs.webkit.org/show_bug.cgi?id=43794
6675 (WebView::initWithFrame):
6677 2010-08-10 Gavin Barraclough <barraclough@apple.com>
6679 Build fix (update more includes)
6682 * WebLocalizableStrings.cpp:
6683 * WebNotificationCenter.cpp:
6684 * WebPreferences.cpp:
6686 2010-08-10 Chris Marrin <cmarrin@apple.com>
6688 Reviewed by Oliver Hunt.
6690 Add suspendAnimations/resumeAnimation API to DRT
6691 https://bugs.webkit.org/show_bug.cgi?id=43733
6695 * Interfaces/IWebFramePrivate.idl:
6697 (WebFrame::suspendAnimations):
6698 (WebFrame::resumeAnimations):
6701 2010-08-06 Gavin Barraclough <barraclough@apple.com>
6703 Rubber stamped by Sam Weinig
6705 Bug 43594 - Add string forwards to Forward.h
6706 This allows us to remove forward declarations for these classes from
6707 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
6709 * COMVariantSetter.h:
6710 * MarshallingHelpers.h:
6711 * WebCoreSupport/WebContextMenuClient.h:
6712 * WebCoreSupport/WebPluginHalterClient.h:
6715 2010-08-06 Jessie Berlin <jberlin@apple.com>
6717 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
6720 * COMVariantSetter.h:
6721 * MarshallingHelpers.h:
6722 * WebCoreSupport/WebContextMenuClient.h:
6723 * WebCoreSupport/WebPluginHalterClient.h:
6726 2010-08-05 Jessie Berlin <jberlin@apple.com>
6728 Reviewed by Jon Honeycutt.
6730 Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL.
6731 https://bugs.webkit.org/show_bug.cgi?id=43593
6734 (WebView::backingStore):
6735 If m_backingStoreBitmap is NULL, return E_FAIL.
6737 2010-08-05 Gavin Barraclough <barraclough@apple.com>
6739 Rubber stamped by Sam Weinig
6741 Bug 43594 - Add string forwards to Forward.h
6742 This allows us to remove forward declarations for these classes from
6743 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
6745 * COMVariantSetter.h:
6746 * MarshallingHelpers.h:
6747 * WebCoreSupport/WebContextMenuClient.h:
6748 * WebCoreSupport/WebPluginHalterClient.h:
6751 2010-08-03 Adam Roben <aroben@apple.com>
6753 Turn on PLATFORM_STRATEGIES on Windows
6755 Fixes <http://webkit.org/b/43431>.
6757 Reviewed by Anders Carlsson.
6759 * WebCoreLocalizedStrings.cpp: Removed.
6760 * WebCoreSupport/WebPlatformStrategies.cpp: Added. Based on the Mac
6762 (WebPlatformStrategies::initialize): Creates the singleton instance.
6763 (WebPlatformStrategies::WebPlatformStrategies): Registers the
6764 singleton instance as the PlatformStrategies instance for WebCore.
6766 (WebPlatformStrategies::createPluginStrategy):
6767 (WebPlatformStrategies::createLocalizationStrategy):
6768 (WebPlatformStrategies::createVisitedLinkStrategy):
6769 Return ourselves as the strategy.
6771 (WebPlatformStrategies::refreshPlugins):
6772 (WebPlatformStrategies::getPluginInfo):
6773 Moved code here from WebCore's PluginDataWin.cpp file.
6775 (WebPlatformStrategies::searchableIndexIntroduction):
6776 (WebPlatformStrategies::submitButtonDefaultLabel):
6777 (WebPlatformStrategies::inputElementAltText):
6778 (WebPlatformStrategies::resetButtonDefaultLabel):
6779 (WebPlatformStrategies::fileButtonChooseFileLabel):
6780 (WebPlatformStrategies::fileButtonNoFileSelectedLabel):
6781 (WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow):
6782 (WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk):
6783 (WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard):
6784 (WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow):
6785 (WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk):
6786 (WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard):
6787 (WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow):
6788 (WebPlatformStrategies::contextMenuItemTagCopy):
6789 (WebPlatformStrategies::contextMenuItemTagGoBack):
6790 (WebPlatformStrategies::contextMenuItemTagGoForward):
6791 (WebPlatformStrategies::contextMenuItemTagStop):
6792 (WebPlatformStrategies::contextMenuItemTagReload):
6793 (WebPlatformStrategies::contextMenuItemTagCut):
6794 (WebPlatformStrategies::contextMenuItemTagPaste):
6795 (WebPlatformStrategies::contextMenuItemTagNoGuessesFound):
6796 (WebPlatformStrategies::contextMenuItemTagIgnoreSpelling):
6797 (WebPlatformStrategies::contextMenuItemTagLearnSpelling):
6798 (WebPlatformStrategies::contextMenuItemTagSearchWeb):
6799 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
6800 (WebPlatformStrategies::contextMenuItemTagOpenLink):
6801 (WebPlatformStrategies::contextMenuItemTagIgnoreGrammar):
6802 (WebPlatformStrategies::contextMenuItemTagSpellingMenu):
6803 (WebPlatformStrategies::contextMenuItemTagCheckSpelling):
6804 (WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping):
6805 (WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling):
6806 (WebPlatformStrategies::contextMenuItemTagFontMenu):
6807 (WebPlatformStrategies::contextMenuItemTagBold):
6808 (WebPlatformStrategies::contextMenuItemTagItalic):
6809 (WebPlatformStrategies::contextMenuItemTagUnderline):
6810 (WebPlatformStrategies::contextMenuItemTagOutline):
6811 (WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu):
6812 (WebPlatformStrategies::contextMenuItemTagTextDirectionMenu):
6813 (WebPlatformStrategies::contextMenuItemTagDefaultDirection):
6814 (WebPlatformStrategies::contextMenuItemTagLeftToRight):
6815 (WebPlatformStrategies::contextMenuItemTagRightToLeft):
6816 (WebPlatformStrategies::contextMenuItemTagShowSpellingPanel):
6817 (WebPlatformStrategies::contextMenuItemTagInspectElement):
6818 (WebPlatformStrategies::searchMenuNoRecentSearchesText):
6819 (WebPlatformStrategies::searchMenuRecentSearchesText):
6820 (WebPlatformStrategies::searchMenuClearRecentSearchesText):
6821 (WebPlatformStrategies::AXWebAreaText):
6822 (WebPlatformStrategies::AXLinkText):
6823 (WebPlatformStrategies::AXListMarkerText):
6824 (WebPlatformStrategies::AXImageMapText):
6825 (WebPlatformStrategies::AXHeadingText):
6826 (WebPlatformStrategies::AXDefinitionListTermText):
6827 (WebPlatformStrategies::AXDefinitionListDefinitionText):
6828 (WebPlatformStrategies::AXButtonActionVerb):
6829 (WebPlatformStrategies::AXRadioButtonActionVerb):
6830 (WebPlatformStrategies::AXTextFieldActionVerb):
6831 (WebPlatformStrategies::AXCheckedCheckBoxActionVerb):
6832 (WebPlatformStrategies::AXUncheckedCheckBoxActionVerb):
6833 (WebPlatformStrategies::AXLinkActionVerb):
6834 (WebPlatformStrategies::AXMenuListActionVerb):
6835 (WebPlatformStrategies::AXMenuListPopupActionVerb):
6836 (WebPlatformStrategies::unknownFileSizeText):
6837 (WebPlatformStrategies::uploadFileText):
6838 (WebPlatformStrategies::allFilesText):
6839 (WebPlatformStrategies::missingPluginText):
6840 (WebPlatformStrategies::crashedPluginText):
6841 (WebPlatformStrategies::imageTitle):
6842 (WebPlatformStrategies::multipleFileUploadText):
6843 (WebPlatformStrategies::mediaElementLoadingStateText):
6844 (WebPlatformStrategies::mediaElementLiveBroadcastStateText):
6845 (WebPlatformStrategies::localizedMediaControlElementString):
6846 (WebPlatformStrategies::localizedMediaControlElementHelpText):
6847 (WebPlatformStrategies::localizedMediaTimeDescription):
6848 (WebPlatformStrategies::validationMessageValueMissingText):
6849 (WebPlatformStrategies::validationMessageTypeMismatchText):
6850 (WebPlatformStrategies::validationMessagePatternMismatchText):
6851 (WebPlatformStrategies::validationMessageTooLongText):
6852 (WebPlatformStrategies::validationMessageRangeUnderflowText):
6853 (WebPlatformStrategies::validationMessageRangeOverflowText):
6854 (WebPlatformStrategies::validationMessageStepMismatchText):
6855 Moved code here from WebCoreLocalizedStrings.cpp (and slightly cleaned
6858 (WebPlatformStrategies::isLinkVisited):
6859 (WebPlatformStrategies::addVisitedLink):
6860 Copied code from WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm.
6862 * WebCoreSupport/WebPlatformStrategies.h: Added.
6864 * WebKit.vcproj/WebKit.vcproj: Removed WebCoreLocalizedStrings, added
6865 WebPlatformStrategies.
6868 (WebView::initWithFrame): Initialize WebPlatformStrategies.
6870 2010-08-03 Alexey Proskuryakov <ap@apple.com>
6872 Reviewed by Sam Weinig.
6874 https://bugs.webkit.org/show_bug.cgi?id=42939
6875 WebEditorClient::didBeginEditing is never called in WebKit2
6877 * WebView.cpp: (WebView::WebViewWndProc): Removed a call to setFocusedFrame. WebCore will
6878 now set it to main frame, and besides, this call should have been before setFocused(), not
6879 after it. My understanding is that we weren't getting all the same editing delegates on Windows,
6880 so this change may make WebKit1 on Windows behave more like Mac - but I haven't tested it.
6882 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
6884 Reviewed by Darin Fisher.
6886 PopupMenu refactoring in preparation to WebKit2
6887 https://bugs.webkit.org/show_bug.cgi?id=42592
6889 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
6890 instances, concrete classes that inherit from ChromeClient needed to be changed to
6891 implement the new methods.
6893 * WebCoreSupport/WebChromeClient.cpp:
6894 (WebChromeClient::selectItemWritingDirectionIsNatural):
6895 (WebChromeClient::createPopupMenu):
6896 (WebChromeClient::createSearchPopupMenu):
6897 * WebCoreSupport/WebChromeClient.h:
6899 2010-08-02 Jon Honeycutt <jhoneycutt@apple.com>
6901 Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
6903 Reviewed by Sam Weinig.
6905 * WebKit.vcproj/WebKit.sln:
6907 2010-08-02 Jeremy Orlow <jorlow@chromium.org>
6909 Speculative revert of 64425 due to Chromium instability
6910 https://bugs.webkit.org/show_bug.cgi?id=43347
6912 * WebCoreSupport/WebChromeClient.cpp:
6913 * WebCoreSupport/WebChromeClient.h:
6915 (WebView::mouseWheel):
6917 2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
6922 (WebView::mouseWheel):
6924 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
6926 Reviewed by Darin Fisher.
6928 PopupMenu refactoring in preparation to WebKit2
6929 https://bugs.webkit.org/show_bug.cgi?id=42592
6931 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
6932 instances, concrete classes that inherit from ChromeClient needed to be changed to
6933 implement the new methods.
6935 * WebCoreSupport/WebChromeClient.cpp:
6936 (WebChromeClient::selectItemWritingDirectionIsNatural):
6937 (WebChromeClient::createPopupMenu):
6938 (WebChromeClient::createSearchPopupMenu):
6939 * WebCoreSupport/WebChromeClient.h:
6941 2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
6943 Unreviewed, rolling out r64422.
6944 http://trac.webkit.org/changeset/64422
6945 https://bugs.webkit.org/show_bug.cgi?id=43304
6947 Build fixes are needed for Snow Leopard and Windows.
6948 (Requested by lca on #webkit).
6950 * WebCoreSupport/WebChromeClient.cpp:
6951 * WebCoreSupport/WebChromeClient.h:
6953 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
6955 Reviewed by Darin Fisher.
6957 PopupMenu refactoring in preparation to WebKit2
6958 https://bugs.webkit.org/show_bug.cgi?id=42592
6960 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
6961 instances, concrete classes that inherit from ChromeClient needed to be changed to
6962 implement the new methods.
6964 * WebCoreSupport/WebChromeClient.cpp:
6965 (WebChromeClient::selectItemWritingDirectionIsNatural):
6966 (WebChromeClient::createPopupMenu):
6967 (WebChromeClient::createSearchPopupMenu):
6968 * WebCoreSupport/WebChromeClient.h:
6970 2010-07-31 Daniel Bates <dbates@rim.com>
6972 Attempt to fix the Windows build after changeset 64409 <http://trac.webkit.org/changeset/64409>.
6975 (WebFrame::setPrinting):
6977 2010-07-30 Dan Bernstein <mitz@apple.com>
6979 Reviewed by Darin Adler.
6981 <rdar://problem/8257783> Short documents may print a second blank page
6982 https://bugs.webkit.org/show_bug.cgi?id=43271
6985 (WebFrame::setPrinting): Updated for changes to Frame::setPrinting(). Passing 0 for the
6986 page height, which maintains existing behavior.
6988 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
6990 Reviewed by David Kilzer.
6992 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
6993 https://bugs.webkit.org/show_bug.cgi?id=40627
6995 * WebCoreSupport/WebChromeClient.cpp:
6996 (WebChromeClient::reachedApplicationCacheOriginQuota):
6997 * WebCoreSupport/WebChromeClient.h:
6999 2010-07-26 Steve Block <steveblock@google.com>
7001 Reviewed by Jeremy Orlow.
7003 Page clients should be passed to Page constructor via structure of pointers
7004 https://bugs.webkit.org/show_bug.cgi?id=42834
7007 (WebView::initWithFrame):
7009 2010-07-27 Steve Block <steveblock@google.com>
7011 Reviewed by Alexey Proskuryakov.
7013 Client-based Geolocation does not pass enableHighAccuracy option to controller and client
7014 https://bugs.webkit.org/show_bug.cgi?id=40374
7016 Stub out setEnableHighAccuracy method for the Win port.
7018 * WebCoreSupport/WebGeolocationControllerClient.h:
7019 (WebGeolocationControllerClient::setEnableHighAccuracy):
7021 2010-07-22 Sam Weinig <sam@webkit.org>
7023 Reviewed by Maciej Stachowiak.
7025 Fix for <rdar://problem/8222626>
7026 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
7028 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
7029 should migrate to a new function name eventually
7031 * WebCoreSupport/WebEditorClient.cpp:
7032 (WebEditorClient::textDidChangeInTextField):
7034 2010-07-21 Brady Eidson <beidson@apple.com>
7036 Reviewed by Geoffrey Garen.
7038 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
7039 https://bugs.webkit.org/show_bug.cgi?id=42783
7042 (WebView::registerURLSchemeAsLocal):
7043 (WebView::registerURLSchemeAsSecure):
7045 2010-07-20 Steve Falkenburg <sfalken@apple.com>
7047 Reviewed by Adam Roben.
7049 WebKit on Windows should build optionally with an unversioned ICU DLL
7050 https://bugs.webkit.org/show_bug.cgi?id=42722
7051 <rdar://problem/8211767> WebKit needs to link against unversioned ICU
7053 To get the proper value for U_DISABLE_RENAMING into all source files, we force
7054 the include of ICUVersion.h (our generated header) via the compiler options.
7056 * WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h.
7058 2010-07-21 Adam Roben <aroben@apple.com>
7060 Update WebKit.sln for InjectedBundle's Debug_Internal configuration
7062 Fixes <http://webkit.org/b/42749> InjectedBundle's build
7063 configurations are screwy
7065 Reviewed by Darin Adler.
7067 * WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of
7068 InjectedBundle when we're using the Debug_Internal solution
7071 2010-07-21 Adam Roben <aroben@apple.com>
7073 Add MiniBrowser to WebKit.sln
7075 It is the last project to build.
7077 Fixes <http://webkit.org/b/42747> build-webkit should build
7080 Reviewed by Darin Adler.
7082 * WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on
7085 2010-07-20 Adam Roben <aroben@apple.com>
7087 Add WebKitTestRunner and friends to WebKit.sln
7089 We added these projects to WebKit2.sln in r63585, but removed them
7090 again in r63600 because WebKitTestRunner required getopt, which
7091 doesn't exist in WebKitAuxiliaryLibrary. r63700 and r63788 removed the
7092 use of getopt in WebKitTestRunner, so we can now add it to WebKit.sln
7093 (which has replaced WebKit2.sln).
7095 Fixes <http://webkit.org/b/42711> WebKit.sln should build
7098 Reviewed by Steve Falkenburg.
7100 * WebKit.vcproj/WebKit.sln: Added the following projects to the end of
7101 the build order (in first-built to last-built order):
7102 InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. Also
7103 removed an unnecessary dependency from testapi on WebKit2WebProcess.
7105 2010-07-19 Daniel Bates <dbates@rim.com>
7107 Reviewed by Adam Roben.
7109 [Win] Implement LayoutTestController::markerTextForListItem()
7110 https://bugs.webkit.org/show_bug.cgi?id=37930
7112 Implements support for markerTextForListItem in the Windows port.
7114 * DOMCoreClasses.cpp:
7115 (DOMElement::markerTextForListItem): Added.
7117 * Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
7118 * Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
7119 * Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
7121 (WebView::elementFromJS): Added.
7124 2010-07-16 Zhe Su <suzhe@chromium.org>
7126 Reviewed by Darin Adler.
7128 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
7129 https://bugs.webkit.org/show_bug.cgi?id=42253
7131 Dummy implementation of EditorClient::willSetInputMethodState.
7133 * WebCoreSupport/WebEditorClient.cpp:
7134 (WebEditorClient::willSetInputMethodState):
7135 * WebCoreSupport/WebEditorClient.h:
7137 2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
7139 Reviewed by Pavel Feldman.
7141 Make JS memory stats available via 'Performance' object (Web Timing).
7142 This statistics is populated only if 'WebKitMemoryInfoEnabled'
7145 'console.memory' is kept until Web Timing object becomes visible by
7146 default (currently it is hidden under compile-time flag). These stats
7147 are guarded with the same preference.
7149 https://bugs.webkit.org/show_bug.cgi?id=41617
7151 * Interfaces/IWebPreferencesPrivate.idl:
7152 * WebPreferenceKeysPrivate.h:
7153 * WebPreferences.cpp:
7154 (WebPreferences::initializeDefaultSettings):
7155 (WebPreferences::memoryInfoEnabled):
7156 (WebPreferences::setMemoryInfoEnabled):
7159 (WebView::notifyPreferencesChanged):
7161 2010-07-14 Brent Fulgham <bfulgham@webkit.org>
7163 Reviewed by Steve Falkenburg.
7165 Patch for https://bugs.webkit.org/show_bug.cgi?id=42299
7166 Correct WinCairo build for new WebKit2 project structure.
7168 * WebKit.vcproj/WebKit.sln:
7170 2010-07-14 Sam Weinig <sam@webkit.org>
7172 Reviewed by Darin Adler.
7174 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
7175 Make changing Cursors work in WebKit2.
7177 * WebCoreSupport/WebChromeClient.cpp:
7178 (WebChromeClient::setCursor):
7179 We now need to grab the native cursor out of the WebCore cursor.
7181 (WebChromeClient::setLastSetCursorToCurrentCursor):
7182 Sets the WebView's "last set cursor" to be the current cursor so that
7183 the cursor is set correctly for plugins.
7184 * WebCoreSupport/WebChromeClient.h:
7187 (WebView::WebViewWndProc):
7189 (WebView::setLastCursor):
7190 Change the "last set cursor" to be stored as a member instead of a global.
7192 2010-07-13 Steve Falkenburg <sfalken@apple.com>
7195 Make WebKit.sln build WebKit.dll as it used to in the past.
7196 (sln is updated to include necessary projects)
7198 * WebKit.vcproj/WebKit.sln:
7200 2010-07-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
7204 * Interfaces/WebKit.idl: Touched to force a build
7206 2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
7208 Reviewed by Darin Adler.
7210 Prevent assertion/duplicate loads for non-deferred subtitute-data loads
7212 https://bugs.webkit.org/show_bug.cgi?id=30879
7214 MainResourceLoader uses the member m_initialRequest to store requests for future
7215 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
7216 have to clear this request so that subsequent entries into the loader will not
7217 start yet another load.
7219 This can happen as a result of a PageGroupLoadDeferrer going out of scope when
7220 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
7221 but only in the case of using both substitute-data and non-deferred main resource
7222 load together. That's why two new DRT functions were added:
7224 * queueLoadHTMLString()
7225 * setDeferMainResourceLoad()
7227 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
7228 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
7229 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
7231 * Interfaces/IWebDataSource.idl:
7232 * WebDataSource.cpp:
7233 (WebDataSource::setDeferMainResourceDataLoad):
7236 2010-07-12 Steve Falkenburg <sfalken@apple.com>
7238 Reviewed by Alice Liu.
7240 <rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
7241 https://bugs.webkit.org/show_bug.cgi?id=40921
7243 Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
7244 WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
7246 This is a first step. We'll likely want to migrate the remainder of
7247 the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
7249 * WebKit.vcproj/WebKit.def: Removed.
7250 * WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL.
7251 * WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib.
7252 Renamed project name to WebKitLib to avoid confusion and naming conflicts.
7253 Generate intermediate pdb file for debuggability of static lib.
7254 Removed DLL-related options.
7255 * WebKit.vcproj/deleteButton.png: Removed.
7256 * WebKit.vcproj/deleteButtonPressed.png: Removed.
7257 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed.
7258 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed.
7259 * WebKit.vcproj/fsVideoExitFullscreen.png: Removed.
7260 * WebKit.vcproj/fsVideoPause.png: Removed.
7261 * WebKit.vcproj/fsVideoPlay.png: Removed.
7262 * WebKit.vcproj/missingImage.png: Removed.
7263 * WebKit.vcproj/nullplugin.png: Removed.
7264 * WebKit.vcproj/panEastCursor.png: Removed.
7265 * WebKit.vcproj/panIcon.png: Removed.
7266 * WebKit.vcproj/panNorthCursor.png: Removed.
7267 * WebKit.vcproj/panNorthEastCursor.png: Removed.
7268 * WebKit.vcproj/panNorthWestCursor.png: Removed.
7269 * WebKit.vcproj/panSouthCursor.png: Removed.
7270 * WebKit.vcproj/panSouthEastCursor.png: Removed.
7271 * WebKit.vcproj/panSouthWestCursor.png: Removed.
7272 * WebKit.vcproj/panWestCursor.png: Removed.
7273 * WebKit.vcproj/searchCancel.png: Removed.
7274 * WebKit.vcproj/searchCancelPressed.png: Removed.
7275 * WebKit.vcproj/searchMagnifier.png: Removed.
7276 * WebKit.vcproj/searchMagnifierResults.png: Removed.
7277 * WebKit.vcproj/textAreaResizeCorner.png: Removed.
7278 * WebKit.vcproj/verticalTextCursor.png: Removed.
7279 * WebKit.vcproj/zoomInCursor.png: Removed.
7280 * WebKit.vcproj/zoomOutCursor.png: Removed.
7282 2010-07-08 Aaron Boodman <aa@chromium.org>
7284 Reviewed by Timothy Hatcher.
7286 Add the ability for user scripts and user styles to affect just the top frame.
7288 https://bugs.webkit.org/show_bug.cgi?id=41529
7291 (WebView::addUserScriptToGroup):
7292 (WebView::addUserStyleSheetToGroup):
7294 2010-07-08 Adele Peterson <adele@apple.com>
7296 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
7298 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721
7299 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
7301 Implement shouldMissingPluginMessageBeButton.
7303 * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::shouldMissingPluginMessageBeButton):
7304 * WebCoreSupport/WebChromeClient.h:
7306 2010-07-07 Anders Carlsson <andersca@apple.com>
7308 Reviewed by Simon Fraser.
7310 Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
7311 https://bugs.webkit.org/show_bug.cgi?id=41781
7313 * WebKit.vcproj/WebKit.sln:
7315 2010-07-07 Sam Weinig <sam@webkit.org>
7317 Reviewed by Anders Carlsson.
7319 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
7320 Add basic piping for BackForwardControllerClient.
7323 (WebView::initWithFrame):
7325 2010-07-07 Adam Roben <aroben@apple.com>
7329 * Interfaces/WebKit.idl: Touched to force a build.
7331 2010-07-06 Steve Falkenburg <sfalken@apple.com>
7333 Reviewed by Simon Fraser.
7335 Expose URL matching from WebUserContentURLPattern
7336 https://bugs.webkit.org/show_bug.cgi?id=41726
7337 <rdar://problem/7910144>
7339 We previously had a way to construct WebUserContentURLPattern
7340 instances via WebKit, but no way for callers to perform matching.
7341 This patch adds the matchesURL functionality to allow for this.
7343 * Interfaces/IWebUserContentURLPattern.idl: Added matchesURL.
7344 * Interfaces/IWebView.idl: Touch to force a build.
7345 * WebUserContentURLPattern.cpp:
7346 (WebUserContentURLPattern::matchesURL): Added. Calls through to WebCore::UserContentURLPattern::matches.
7347 * WebUserContentURLPattern.h: Added matchesURL.
7349 2010-07-03 Jon Honeycutt <jhoneycutt@apple.com>
7351 The missing plug-in indicator should be clickable
7353 https://bugs.webkit.org/show_bug.cgi?id=41550
7354 <rdar://problem/8132162>
7356 From an original patch by Kevin Decker.
7358 Reviewed by Darin Adler.
7360 * Interfaces/IWebUIDelegatePrivate.idl:
7361 Added a new delegate interface, and declare a function
7362 didPressMissingPluginButton().
7364 * Interfaces/WebKit.idl:
7365 Touch this file to force interfaces to be rebuilt.
7367 * WebCoreSupport/WebChromeClient.cpp:
7368 (WebChromeClient::missingPluginButtonClicked):
7369 Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
7370 didPressMissingPluginButton() function.
7372 * WebCoreSupport/WebChromeClient.h:
7373 Declare an override of missingPluginButtonClicked().
7375 2010-07-03 Erik Arvidsson <arv@chromium.org>
7377 Reviewed by Ojan Vafai.
7379 Fix issue where a contextmenu event was reporting the wrong target
7380 if the context menu was shown due to pressing the context menu key
7384 (WebView::handleContextMenuEvent):
7386 2010-07-01 Steve Falkenburg <sfalken@apple.com>
7388 Reviewed by Adele Peterson.
7390 Provide a WebView preference to disable DNS prefetching on Windows
7391 https://bugs.webkit.org/show_bug.cgi?id=41504
7392 <rdar://problem/8151939>
7394 * Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
7395 * Interfaces/WebKit.idl: Touched to force IDL build.
7396 * WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
7397 * WebPreferences.cpp:
7398 (WebPreferences::initializeDefaultSettings): Default prefetch to true.
7399 (WebPreferences::setDNSPrefetchingEnabled): Added.
7400 (WebPreferences::isDNSPrefetchingEnabled): Added.
7401 * WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
7403 (WebView::notifyPreferencesChanged): Propagate prefetch pref into settings.
7405 2010-06-21 Nate Chapin <japhet@chromium.org>
7407 Unreviewed, Windows build fix.
7409 Update WebFrame to use FrameLoaderStateMachine in
7413 (WebFrame::firstLayoutDone):
7415 2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
7417 Reviewed by Adam Barth.
7419 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
7420 https://bugs.webkit.org/show_bug.cgi?id=39041
7423 (WebView::notifyPreferencesChanged):
7425 2010-06-16 Adam Roben <aroben@apple.com>
7427 Add a "forPrinting" boolean parameter to
7428 IWebFramePrivate::renderTreeAsExternalRepresentation
7430 Fixes <http://webkit.org/b/40727> Respect
7431 LayoutTestController::isPrinting on Windows.
7433 Reviewed by Dan Bernstein.
7435 * Interfaces/IWebFramePrivate.idl: Renamed the current
7436 renderTreeAsExternalRepresentation to unused1, and added a new version
7437 that takes a boolean "forPrinting" parameter.
7439 * Interfaces/WebKit.idl: Touched to force a build.
7442 (WebFrame::renderTreeAsExternalRepresentation): Added a boolean
7443 "forPrinting" parameter, and used it to tell externalRepresentation
7444 what kind of behavior to use.
7446 * WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and
7449 2010-06-15 Darin Adler <darin@apple.com>
7451 Reviewed by Adam Barth.
7453 Move functions out of Frame class that were marked "move to Chrome"
7454 https://bugs.webkit.org/show_bug.cgi?id=39636
7457 (WebView::shouldClose): Call shouldClose on FrameLoader instead of
7458 going through Frame.
7460 2010-06-14 Adam Roben <aroben@apple.com>
7462 Add WebKitLauncherWin to WebKit.sln
7464 Fixes <http://webkit.org/b/40583>.
7466 Reviewed by Darin Adler.
7468 * WebKit.vcproj/WebKit.sln: Added WebKitLauncherWin.vcproj. It depends
7469 on WebKitAPITest, so is the last project to build. (Also removed
7470 QTMovieWin's direct dependency on JavaScriptCore, since it already has
7471 an indirect dependency on it.)
7473 2010-06-14 Chang Shu <chang.shu@nokia.com>
7475 Reviewed by Kenneth Rohde Christiansen.
7477 [win] Make windows compile after API changes.
7479 https://bugs.webkit.org/show_bug.cgi?id=40434
7481 * WebKitGraphics.cpp:
7484 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
7486 Reviewed by Pavel Feldman.
7488 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
7489 data from inspected page to WebInspector as JSON string via http. The native
7490 serialization to JSON string is supported by InspectorValue's classes. This patch
7491 has the implementation of sendMessageToFrontend function. WebKit version of it still
7492 uses ScriptFunctionCall and will be switched to another transport a little bit later.
7493 https://bugs.webkit.org/show_bug.cgi?id=40134
7495 * WebCoreSupport/WebInspectorClient.cpp:
7496 (WebInspectorClient::WebInspectorClient):
7497 (WebInspectorClient::~WebInspectorClient):
7498 (WebInspectorClient::openInspectorFrontend):
7499 * WebCoreSupport/WebInspectorClient.h:
7501 2010-06-10 Eric Seidel <eric@webkit.org>
7503 Reviewed by Adam Barth.
7505 Reduce FrameView.h includes to speed up build times
7506 https://bugs.webkit.org/show_bug.cgi?id=40408
7508 Another fix for Windows.
7512 2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
7514 Unreviewed, rolling out r60889.
7515 http://trac.webkit.org/changeset/60889
7516 https://bugs.webkit.org/show_bug.cgi?id=40365
7518 gtk bot has some kind of memory corruption (Requested by
7521 * WebCoreSupport/WebInspectorClient.cpp:
7522 (WebInspectorClient::WebInspectorClient):
7523 (WebInspectorClient::~WebInspectorClient):
7524 (WebInspectorClient::openInspectorFrontend):
7525 * WebCoreSupport/WebInspectorClient.h:
7526 (WebInspectorClient::frontendClosing):
7528 2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
7530 Reviewed by Pavel Feldman.
7532 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
7533 data from inspected page to WebInspector as JSON string via http. The native
7534 serialization to JSON string is supported by InspectorValue's classes. This patch
7535 has the implementation of sendMessageToFrontend function. WebKit version of it still
7536 uses ScriptFunctionCall and will be switched to another transport a little bit later.
7537 https://bugs.webkit.org/show_bug.cgi?id=40134
7539 * WebCoreSupport/WebInspectorClient.cpp:
7540 (WebInspectorClient::WebInspectorClient):
7541 (WebInspectorClient::~WebInspectorClient):
7542 (WebInspectorClient::openInspectorFrontend):
7543 * WebCoreSupport/WebInspectorClient.h:
7545 2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
7547 Reviewed by Ojan Vafai and Darin Adler.
7549 Refactor platform dependent editing behavior code out of Settings
7550 https://bugs.webkit.org/show_bug.cgi?id=39854
7552 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
7553 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
7556 (WebView::notifyPreferencesChanged):
7558 2010-06-04 Alice Liu <alice.liu@apple.com>
7560 Reviewed by Jon Honeycutt.
7562 WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars
7563 https://bugs.webkit.org/show_bug.cgi?id=40034
7564 <rdar://problem/7799848>
7567 (WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint.
7568 Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint().
7570 Just renaming changes:
7571 * Interfaces/IWebFramePrivate.idl:
7572 * Interfaces/IWebViewPrivate.idl:
7575 (WebView::paintScrollViewRectToContextAtPoint):
7578 * Interfaces/WebKit.idl: Touched for rebuild.
7580 2010-05-30 Daniel Bates <dbates@rim.com>
7582 Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.
7585 (WebFrame::elementWithName):
7586 (WebFrame::controlsInForm):
7588 2010-05-22 Jer Noble <jer.noble@apple.com>
7590 Reviewed by Adam Roben.
7592 Full screen doesn't work for video elements
7593 https://bugs.webkit.org/show_bug.cgi?id=39557
7594 rdar://problem/8011813
7596 Modified FullscreenVideoController to work with MediaPlayerPrivateFullscreenWindow. The FullscreenVideoController
7597 is now MediaPlayerPrivate agnostic..
7599 * FullscreenVideoController.cpp:
7600 (FullscreenVideoController::LayoutClient::LayoutClient): New helper class which implements WKCACFLayerLayoutClient.
7601 (FullscreenVideoController::LayoutClient::layoutSublayersOfLayer):
7602 (FullscreenVideoController::FullscreenVideoController):
7603 (FullscreenVideoController::~FullscreenVideoController):
7604 (FullscreenVideoController::enterFullscreen):
7605 (FullscreenVideoController::exitFullscreen):
7606 (FullscreenVideoController::fullscreenClientWndProc): Handle WM_KEYDOWN.
7607 (FullscreenVideoController::createHUDWindow):
7608 (FullscreenVideoController::hudWndProc): Handle WM_KEYDOWN.
7609 (FullscreenVideoController::onChar):
7610 (FullscreenVideoController::onKeyDown): New function: handles the VK_ESCAPE case more reliably than WM_CHAR.
7611 * FullscreenVideoController.h:
7613 (WebView::viewWindow): Added a simple viewWindow() accessor.
7615 2010-05-25 Brady Eidson <beidson@apple.com>
7617 Reviewed by Darin Adler.
7619 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms)
7620 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486
7622 * WebDatabaseManager.cpp:
7623 (WebKitInitializeWebDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on
7624 an already created tracker that already has its origins populated.
7625 * WebDatabaseManager.h:
7628 (WebView::initWithFrame): Call a renamed method instead.
7630 2010-05-25 Ada Chan <adachan@apple.com>
7632 Reviewed by Steve Falkenburg.
7634 https://bugs.webkit.org/show_bug.cgi?id=39651
7636 Make m_closeWindowTimer a SuspendableTimer, so it is properly suspended
7637 when page loading is deferred.
7640 (WebView::WebView): m_closeWindowTimer is now a pointer to a SuspendableTimer.
7641 (WindowCloseTimer::create):
7642 (WindowCloseTimer::WindowCloseTimer):
7643 (WindowCloseTimer::contextDestroyed): Make sure we delete the WindowCloseTimer in the end.
7644 (WindowCloseTimer::fired):
7645 (WebView::closeWindowSoon):
7646 (WebView::closeWindowTimerFired):
7647 (WebView::notifyPreferencesChanged): Can just check for the existence m_closeWindowTimer, since
7648 we only create it when we need to start the timer.
7651 2010-05-24 Darin Adler <darin@apple.com>
7653 Reviewed by Eric Seidel.
7655 Move view-related functions from Frame to FrameView
7656 https://bugs.webkit.org/show_bug.cgi?id=39366
7659 (WebFrame::setTextSizeMultiplier): Call function on FrameView.
7661 (WebView::setZoomMultiplier): Ditto.
7663 2010-05-24 Anders Carlsson <andersca@apple.com>
7665 Yet another Windows build fix.
7668 (WebView::canShowMIMEType):
7669 Use the right capitalizatinon of 'MIME' (which also happens to be incorrect according to our guidelines).
7671 2010-05-24 Anders Carlsson <andersca@apple.com>
7673 Another Windows build fix.
7676 Don't include PlugInInfoStore.h, instead include PluginData.h
7678 2010-05-24 Anders Carlsson <andersca@apple.com>
7683 (WebView::canShowMIMEType):
7685 2010-05-21 Steve Block <steveblock@google.com>
7687 Reviewed by Jeremy Orlow.
7689 Add DeviceOrientation and DeviceOrientationClient
7690 https://bugs.webkit.org/show_bug.cgi?id=39479
7693 (WebView::initWithFrame):
7695 2010-05-20 Simon Fraser <simon.fraser@apple.com>
7697 Build fix, no review.
7699 Fix the non-accelerated-compositing Windows build with some
7700 #if USE(ACCELERATED_COMPOSITING) loving.
7705 2010-05-20 Simon Fraser <simon.fraser@apple.com>
7707 Reviewed by Adam Roben.
7709 Avoid flushing CA layers when a layout is pending
7710 https://bugs.webkit.org/show_bug.cgi?id=39463
7712 <rdar://problem/7999463>
7714 Avoid rendering the compositing layers to the screen if there's a layout pending,
7715 since the layer tree not in a state that should be presented to the user.
7717 This fixes flashes in some types of content that dynamically add and remove layers.
7719 Have the WebView implement WKCACFLayerRendererClient so that the
7720 WKCACFLayerRenderer can ask whether it's a good time to render. If the FrameView
7721 has a layout pending, say no.
7725 (WebView::setAcceleratedCompositing):
7726 (WebView::shouldRender):
7728 2010-05-18 Brent Fulgham <bfulgham@webkit.org>
7730 Reviewed by Adam Roben.
7732 [WinCairo] Correct scaling for print preview
7733 https://bugs.webkit.org/show_bug.cgi?id=39329
7735 Cairo does not properly deal with Windows HDCs that have been
7736 scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
7737 ViewportExt setting.
7738 (see http://bugs.freedesktop.org/show_bug.cgi?id=28161)
7740 Instead, reset the HDC's WorldTransform to be unscaled, then
7741 scale the cairo context to the desired scaling, and perform
7742 the drawing operation.
7745 (WebFrame::drawHeader): Use pre-positioned context to simplify
7747 (WebFrame::drawFooter): Use pre-positioned context to simplify
7749 (WebFrame::spoolPage): Revise scaling logic to turn off HDC
7750 scaling, and scale using only Cairo. Revert scaling at end
7751 so that user-defined GDI-based routines (e.g., header/footer)
7752 will draw in the right position.
7753 (WebFrame::spoolPages): Identify print preview case, and
7754 retrieve scaling factors from preview context. Set the
7755 Cairo context to use these factors during the spoolPage
7758 2010-05-20 Martin Robinson <mrobinson@igalia.com>
7762 Touch WebKit.idl to ensure that interfaces rebuild.
7764 * Interfaces/WebKit.idl: Touched.
7766 2010-05-20 Martin Robinson <mrobinson@igalia.com>
7768 Reviewed by Adam Roben.
7770 Fix the Windows build and move new IDL declarations to the bottom of the file.
7772 * Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
7773 * WebPreferences.cpp:
7774 (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.
7776 2010-05-20 Martin Robinson <mrobinson@igalia.com>
7780 Fix the Windows build.
7783 (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.
7785 2010-05-20 Martin Robinson <mrobinson@webkit.org>
7787 Reviewed by Ojan Vafai.
7789 Expose the editing behavior setting in DRT to test all editing code paths
7790 https://bugs.webkit.org/show_bug.cgi?id=38603
7792 Expose the EditingBehavior setting in the Windows API.
7794 * Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior.
7795 * WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting.
7796 * WebPreferences.cpp:
7797 (WebPreferences::editingBehavior): Added.
7798 (WebPreferences::setEditingBehavior): Added.
7799 * WebPreferences.h: Add method declarations.
7801 (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting.
7803 2010-05-20 Chris Jerdonek <cjerdonek@webkit.org>
7805 Reviewed by Eric Seidel.
7807 Modified FrameLoader::urlSelected() to accept a KURL instead of a
7810 https://bugs.webkit.org/show_bug.cgi?id=39320
7812 Since ResourceRequest has non-explicit single-parameter constructors for
7813 String and KURL, urlSelected() previously accepted any of String, KURL,
7814 and ResourceRequest. This revision changes urlSelected() to accept only
7815 a KURL to make the API tighter and easier to refactor.
7817 * WebCoreSupport/WebContextMenuClient.cpp:
7818 (WebContextMenuClient::searchWithGoogle):
7819 - Updated the call to urlSelected().
7821 2010-05-13 Brian Weinstein <bweinstein@apple.com>
7823 Reviewed by Tim Hatcher.
7825 <rdar://problem/7982652>
7827 Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.
7829 * Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
7830 * Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
7832 (WebView::reportException): Make sure the function was called with a context from a WebView, and call
7833 WebCore::reportException.
7836 2010-05-12 Jer Noble <jer.noble@apple.com>
7838 Reviewed by Darin Adler.
7840 Bug 38689: #34005 will break fullscreen video playback
7841 https://bugs.webkit.org/show_bug.cgi?id=38689
7843 Use the new definition of PlatformMedia to check the actual type
7844 returned by MediaPlayer.
7846 * FullscreenVideoController.cpp:
7847 (FullscreenVideoController::movie):
7849 2010-05-11 Jer Noble <jer.noble@apple.com>
7853 Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.
7855 * WebKit.vcproj/WebKit.sln:
7857 2010-05-11 Alice Liu <alice.liu@apple.com>
7859 Rubber-stamped by Gavin Barraclough.
7861 Fix build error when enabling debugging block in WebKit win painting code
7864 (WebView::paintIntoBackingStore):
7866 2010-05-11 Alice Liu <alice.liu@apple.com>
7868 Reviewed by Steve Falkenburg.
7870 https://bugs.webkit.org/show_bug.cgi?id=38937
7871 W7 window preview paints content at the wrong location
7874 (WebFrame::paintDocumentRectToContext): Revert r58895
7875 (WebFrame::paintDocumentRectToContextAtPoint): Added
7877 * Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
7878 * Interfaces/IWebViewPrivate.idl: ditto
7879 * Interfaces/WebKit.idl: touch to rebuild
7881 * WebView.cpp: ditto
7882 (WebView::paintDocumentRectToContextAtPoint): ditto
7885 2010-05-07 Jer Noble <jer.noble@apple.com>
7887 Reviewed by Adele Peterson.
7889 Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
7890 https://bugs.webkit.org/show_bug.cgi?id=34005
7892 QTMovieWin is now QTMovieGWorld.
7893 * FullscreenVideoController.cpp:
7894 (FullscreenVideoController::movie):
7895 * FullscreenVideoController.h:
7897 2010-05-06 Adam Roben <aroben@apple.com>
7899 Bail out of WebView::paint when there's nothing to paint
7901 Fixes <http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION
7902 (r58067): Crash in WebView::paint when Web Inspector is docked and
7903 window is resized so small that WebView disappears
7905 When the WebView is 0-sized, ensureBackingStore() bails out without
7906 creating a bitmap, leaving m_backingStoreBitmap null. Before r58067,
7907 m_backingStoreBitmap was an HBITMAP, so we were happily passing along
7908 a null HBITMAP to various Windows APIs. These calls would fail but not
7909 crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and
7910 dereferencing a null RefCountedHBITMAP* of course crashes.
7912 Reviewed by Steve Falkenburg.
7915 (WebView::paint): Bail if the rect to paint is empty.
7917 2010-05-06 Steve Falkenburg <sfalken@apple.com>
7919 Reviewed by Adam Roben.
7921 WebFrame::paintDocumentRectToContext paints content at the wrong location
7922 https://bugs.webkit.org/show_bug.cgi?id=38651
7925 (WebFrame::paintDocumentRectToContext):
7927 2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
7929 Reviewed by Darin Fisher.
7931 Update setFocus for the new boolean argument; no behavioral change.
7933 https://bugs.webkit.org/show_bug.cgi?id=37961
7935 * WebCoreSupport/EmbeddedWidget.cpp:
7936 (EmbeddedWidget::setFocus):
7937 * WebCoreSupport/EmbeddedWidget.h:
7939 2010-05-03 Abhishek Arya <inferno@chromium.org>
7941 Reviewed by Adam Barth.
7943 Add support for controlling clipboard access from javascript.
7944 Clipboard access from javascript is disabled by default.
7945 https://bugs.webkit.org/show_bug.cgi?id=27751
7947 * Interfaces/IWebPreferencesPrivate.idl:
7948 * WebPreferenceKeysPrivate.h:
7949 * WebPreferences.cpp:
7950 (WebPreferences::initializeDefaultSettings):
7951 (WebPreferences::javaScriptCanAccessClipboard):
7952 (WebPreferences::setJavaScriptCanAccessClipboard):
7955 (WebView::notifyPreferencesChanged):
7957 2010-05-03 Jens Alfke <snej@chromium.org>
7959 Reviewed by Darin Fisher.
7961 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
7962 https://bugs.webkit.org/show_bug.cgi?id=38397
7964 No tests (functionality is exposed only through native WebKit API.)
7968 2010-04-30 Jon Honeycutt <jhoneycutt@apple.com>
7970 Caret may fail to blink if a focus handler brings up a modal dialog
7971 https://bugs.webkit.org/show_bug.cgi?id=38372
7973 Reviewed by Darin Adler.
7976 (WebView::handleMouseEvent):
7977 If the message is WM_CANCELMODE, which indicates that we our capturing
7978 of mouse events has been cancelled, tell the EventHandler.
7979 It's possible to re-enter this function if handling a mouse event allows
7980 the message loop to run; moved up the call to setMouseActivated(), so
7981 that if we do re-enter this function, the later mouse event will not be
7982 considered as activating the window.
7983 (WebView::WebViewWndProc):
7984 Handle WM_CANCELMODE by calling handleMouseEvent().
7986 2010-04-29 Anders Carlsson <andersca@apple.com>
7988 Reviewed by Dan Bernstein.
7991 https://bugs.webkit.org/show_bug.cgi?id=20784
7992 move npapi.h to C99 integer types.
7994 * WebKit.vcproj/WebKit.vcproj:
7996 2010-04-28 Beth Dakin <bdakin@apple.com>
7998 Reviewed by Darin Adler.
8000 Fix for <rdar://problem/7474349>
8002 Add a synchronous display mechanism for WKCACFLayerRenderer.
8004 * Interfaces/IWebViewPrivate.idl:
8005 * Interfaces/WebKit.idl:
8008 (WebView::updateRootLayerContents):
8009 (WebView::nextDisplayIsSynchronous):
8012 2010-04-28 Steve Falkenburg <sfalken@apple.com>
8014 Reviewed by Maciej Stachowiak.
8016 WebView drawing code may access null backing store dirty region
8017 https://bugs.webkit.org/show_bug.cgi?id=38245
8018 <rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)
8021 (WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.
8023 2010-04-27 Jon Honeycutt <jhoneycutt@apple.com>
8025 <rdar://problem/7911140> Hitting the "delete" key goes back twice
8027 Reviewed by Maciej Stachowiak.
8031 Return true if we navigated back or forward from the key event to
8032 prevent the event from being propagated further.
8034 2010-04-25 Sam Weinig <sam@webkit.org>
8036 Reviewed by Maciej Stachowiak.
8038 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
8039 Disentangle initializing the main thread from initializing threading
8041 * WebKitClassFactory.cpp:
8042 (WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread.
8044 (WebView::WebView): Ditto.
8046 2010-04-25 Yury Semikhatsky <yurys@chromium.org>
8048 Reviewed by Pavel Feldman.
8050 Web Inspector: inspector client shouldn't check if it can be opened
8051 docked if it is already in that state.
8053 https://bugs.webkit.org/show_bug.cgi?id=37946
8055 * WebCoreSupport/WebInspectorClient.cpp:
8056 (WebInspectorFrontendClient::WebInspectorFrontendClient):
8057 (WebInspectorFrontendClient::showWindowWithoutNotifications):
8058 * WebCoreSupport/WebInspectorClient.h:
8060 2010-04-24 Steve Falkenburg <sfalken@apple.com>
8062 Reviewed by Sam Weinig.
8064 Typo in Geolocation code causes crashes when updates are stopped
8065 https://bugs.webkit.org/show_bug.cgi?id=38089
8066 <rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation
8068 * WebCoreSupport/WebGeolocationControllerClient.cpp:
8069 (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register.
8071 2010-04-23 Andy Estes <aestes@apple.com>
8073 Rubber stamped by Steve Falkenburg.
8075 Roll out http://trac.webkit.org/changeset/55385.
8077 <rdar://problem/7884444>
8079 * Interfaces/IWebUIDelegatePrivate.idl:
8080 * Interfaces/WebKit.idl:
8081 * WebCoreSupport/WebFrameLoaderClient.cpp:
8082 (WebFrameLoaderClient::createPlugin):
8084 2010-04-22 Dave Moore <davemoore@chromium.org>
8086 Reviewed by Dimitri Glazkov.
8088 Added notification when the favicons for a page are changed
8090 The Document object will notify the frame loader, which will
8091 notify the client. Implementations of FrameLoaderClient will
8092 have to add one method; dispatchDidChangeIcons().
8094 https://bugs.webkit.org/show_bug.cgi?id=33812
8096 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
8097 * WebCoreSupport/WebFrameLoaderClient.cpp:
8098 (WebFrameLoaderClient::dispatchDidChangeIcons):
8099 * WebCoreSupport/WebFrameLoaderClient.h:
8101 (WebFrame::didChangeIcons):
8104 2010-04-22 Adam Barth <abarth@webkit.org>
8106 Unreviewed, rolling out r58069.
8107 http://trac.webkit.org/changeset/58069
8108 https://bugs.webkit.org/show_bug.cgi?id=27751
8110 Broke compile on Windows.
8112 * Interfaces/IWebPreferencesPrivate.idl:
8113 * WebPreferenceKeysPrivate.h:
8114 * WebPreferences.cpp:
8115 (WebPreferences::initializeDefaultSettings):
8118 (WebView::notifyPreferencesChanged):
8120 2010-04-22 Abhishek Arya <inferno@chromium.org>
8122 Reviewed by Adam Barth.
8124 Add support for controlling clipboard access from javascript.
8125 Clipboard access from javascript is disabled by default.
8126 https://bugs.webkit.org/show_bug.cgi?id=27751
8128 * Interfaces/IWebPreferencesPrivate.idl:
8129 * WebPreferenceKeysPrivate.h:
8130 * WebPreferences.cpp:
8131 (WebPreferences::initializeDefaultSettings):
8132 (WebPreferences::javaScriptCanAccessClipboard):
8133 (WebPreferences::setJavaScriptCanAccessClipboard):
8136 (WebView::notifyPreferencesChanged):
8138 2010-04-21 Andy Estes <aestes@apple.com>
8140 Reviewed by Maciej Stachowiak.
8142 Reference count WebView's backing store bitmap to prevent
8143 deleteBackingStore() from freeing the bitmap while it is still being
8144 referenced by Core Animation.
8146 https://bugs.webkit.org/show_bug.cgi?id=37954
8149 (WebView::ensureBackingStore):
8150 (WebView::addToDirtyRegion):
8151 (WebView::scrollBackingStore):
8152 (WebView::updateBackingStore):
8154 (WebView::backingStore):
8155 (releaseBackingStoreCallback): deref m_backingStoreBitmap once Core
8156 Animation has dropeed its reference to the memory.
8157 (WebView::updateRootLayerContents): ref m_backingStoreBitmap before
8158 passing the memory to Core Animation to prevent deleteBackingStore()
8159 from freeing it while it is still referenced by CA.
8160 * WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>,
8161 and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>.
8163 2010-04-20 Adam Barth <abarth@webkit.org>
8165 Reviewed by Eric Seidel.
8167 Factor DocumentWriter out of FrameLoader
8168 https://bugs.webkit.org/show_bug.cgi?id=37175
8170 Update these callsites because the method moved to DocumentWriter.
8172 * WebCoreSupport/WebFrameLoaderClient.cpp:
8173 (WebFrameLoaderClient::receivedData):
8175 2010-04-20 Kent Tamura <tkent@chromium.org>
8177 Reviewed by Darin Adler.
8179 Change a parameter type of chooseIconForFiles()
8180 https://bugs.webkit.org/show_bug.cgi?id=37504
8182 * WebCoreSupport/WebChromeClient.cpp:
8183 (WebChromeClient::chooseIconForFiles):
8184 * WebCoreSupport/WebChromeClient.h:
8186 2010-04-16 Gavin Barraclough <barraclough@apple.com>
8188 Reviewed by NOBODY (Windows build fix).
8191 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
8193 (WebView::stringByEvaluatingJavaScriptFromString):
8195 2010-04-16 Adam Roben <aroben@apple.com>
8197 Make it possible for clients to instantiate a WebUserContentURLPattern
8199 Reviewed by Tim Hatcher.
8201 * ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which
8202 lists all our instantiatable classes.
8204 * WebKitClassFactory.cpp: Added a now-required #include.
8206 2010-04-15 Adam Roben <aroben@apple.com>
8208 Expose UserContentURLPattern as WebKit SPI
8210 Fixes <http://webkit.org/b/37354>.
8212 Reviewed by Tim Hatcher.
8214 * Interfaces/IWebUserContentURLPattern.idl: Added.
8216 * Interfaces/WebKit.idl: Added WebUserContentURLPattern.
8218 * WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern.
8220 * WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern.
8222 * WebUserContentURLPattern.cpp: Added.
8223 (WebUserContentURLPattern::WebUserContentURLPattern):
8224 (WebUserContentURLPattern::~WebUserContentURLPattern):
8225 (WebUserContentURLPattern::createInstance):
8226 (WebUserContentURLPattern::AddRef):
8227 (WebUserContentURLPattern::Release):
8228 (WebUserContentURLPattern::QueryInterface):
8229 Standard COM implementations.
8231 (WebUserContentURLPattern::parse): Parse the string into a
8232 UserContentURLPattern and store it.
8234 (WebUserContentURLPattern::isValid):
8235 (WebUserContentURLPattern::scheme):
8236 (WebUserContentURLPattern::host):
8237 (WebUserContentURLPattern::matchesSubdomains):
8238 Call through to UserContentURLPattern.
8240 * WebUserContentURLPattern.h: Added.
8242 2010-04-14 Adam Roben <aroben@apple.com>
8244 Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows
8246 Fixes <http://webkit.org/b/37619>.
8248 Reviewed by Steve Falkenburg.
8250 * Interfaces/IWebScriptWorld.idl: Added unregisterWorld.
8252 * Interfaces/WebKit.idl: Touched to force a build.
8254 * WebScriptWorld.cpp:
8255 (WebScriptWorld::unregisterWorld):
8257 Added. Just calls through to DOMWrapperWorld::unregisterWorld.
8259 2010-04-12 Timothy Hatcher <timothy@apple.com>
8261 SecurityOrigin needs a way to remove individual OriginAccessEntries
8262 https://bugs.webkit.org/show_bug.cgi?id=37449
8264 Reviewed by Dave Hyatt.
8266 * Interfaces/IWebViewPrivate.idl:
8268 (WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry.
8269 * WebView.h: Added removeOriginAccessWhitelistEntry.
8271 2010-04-13 Timothy Hatcher <timothy@apple.com>
8273 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
8274 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
8276 SecurityOrigin needs a way to remove individual OriginAccessEntries
8277 https://bugs.webkit.org/show_bug.cgi?id=37449
8279 Reviewed by Dave Hyatt.
8281 * Interfaces/IWebViewPrivate.idl:
8283 (WebView::addOriginAccessWhitelistEntry):
8284 (WebView::resetOriginAccessWhitelists):
8287 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
8289 Unreviewed, rolling out r57468.
8290 http://trac.webkit.org/changeset/57468
8291 https://bugs.webkit.org/show_bug.cgi?id=37433
8293 Broke the world... Must have applied the patch wrong
8294 (Requested by abarth on #webkit).
8296 * WebCoreSupport/WebFrameLoaderClient.cpp:
8297 (WebFrameLoaderClient::receivedData):
8299 2010-04-11 Adam Barth <abarth@webkit.org>
8301 Reviewed by Eric Seidel.
8303 Factor DocumentWriter out of FrameLoader
8304 https://bugs.webkit.org/show_bug.cgi?id=37175
8306 Update these callsites because the method moved to DocumentWriter.
8308 * WebCoreSupport/WebFrameLoaderClient.cpp:
8309 (WebFrameLoaderClient::receivedData):
8311 2010-04-09 Adam Roben <aroben@apple.com>
8313 Windows Debug/Release build fix after r57244
8315 * WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or
8316 QuartzCoreInterface.dll in any configurations. r57244 made this change
8317 only for Debug_Internal.
8319 2010-04-08 Steve Falkenburg <sfalken@apple.com>
8321 Reviewed by Darin Adler.
8323 WebView::isLoading should null check m_mainFrame
8324 https://bugs.webkit.org/show_bug.cgi?id=37294
8327 (WebView::isLoading):
8329 2010-04-07 Chris Marrin <cmarrin@apple.com>
8331 Reviewed by Steve Falkenburg.
8333 Remove QuartzCoreInterface from the build
8335 No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).
8337 * WebKit.vcproj/WebKit.vcproj:Removed delay load for QuartzCore and QuartzCoreInterface
8339 2010-04-07 Andrey Kosyakov <caseq@chromium.org>
8341 Reviewed by Yury Semikhatsky.
8343 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
8344 https://bugs.webkit.org/show_bug.cgi?id=36949
8346 * WebCoreSupport/WebFrameLoaderClient.cpp:
8347 * WebCoreSupport/WebFrameLoaderClient.h:
8349 2010-04-05 Peter Nelson <charn.opcode@gmail.com>
8351 Reviewed by Eric Seidel.
8353 Fixed style errors in DOMCoreClasses.h to bring it up to scratch
8354 for https://bugs.webkit.org/show_bug.cgi?id=34979.
8357 (DOMObject::throwException):
8358 (DOMObject::callWebScriptMethod):
8359 (DOMObject::evaluateWebScript):
8360 (DOMObject::removeWebScriptKey):
8361 (DOMObject::stringRepresentation):
8362 (DOMObject::webScriptValueAtIndex):
8363 (DOMObject::setWebScriptValueAtIndex):
8364 (DOMObject::setException):
8365 (DOMNodeList::throwException):
8366 (DOMNodeList::callWebScriptMethod):
8367 (DOMNodeList::evaluateWebScript):
8368 (DOMNodeList::removeWebScriptKey):
8369 (DOMNodeList::stringRepresentation):
8370 (DOMNodeList::webScriptValueAtIndex):
8371 (DOMNodeList::setWebScriptValueAtIndex):
8372 (DOMNodeList::setException):
8373 (DOMDocument::throwException):
8374 (DOMDocument::callWebScriptMethod):
8375 (DOMDocument::evaluateWebScript):
8376 (DOMDocument::removeWebScriptKey):
8377 (DOMDocument::stringRepresentation):
8378 (DOMDocument::webScriptValueAtIndex):
8379 (DOMDocument::setWebScriptValueAtIndex):
8380 (DOMDocument::setException):
8381 (DOMDocument::nodeName):
8382 (DOMDocument::nodeValue):
8383 (DOMDocument::setNodeValue):
8384 (DOMDocument::nodeType):
8385 (DOMDocument::parentNode):
8386 (DOMDocument::childNodes):
8387 (DOMDocument::firstChild):
8388 (DOMDocument::lastChild):
8389 (DOMDocument::previousSibling):
8390 (DOMDocument::nextSibling):
8391 (DOMDocument::attributes):
8392 (DOMDocument::ownerDocument):
8393 (DOMDocument::insertBefore):
8394 (DOMDocument::replaceChild):
8395 (DOMDocument::removeChild):
8396 (DOMDocument::appendChild):
8397 (DOMDocument::hasChildNodes):
8398 (DOMDocument::cloneNode):
8399 (DOMDocument::isSupported):
8400 (DOMDocument::namespaceURI):
8401 (DOMDocument::prefix):
8402 (DOMDocument::setPrefix):
8403 (DOMDocument::localName):
8404 (DOMDocument::hasAttributes):
8405 (DOMDocument::isSameNode):
8406 (DOMDocument::isEqualNode):
8407 (DOMDocument::textContent):
8408 (DOMDocument::setTextContent):
8409 (DOMElement::throwException):
8410 (DOMElement::callWebScriptMethod):
8411 (DOMElement::evaluateWebScript):
8412 (DOMElement::removeWebScriptKey):
8413 (DOMElement::stringRepresentation):
8414 (DOMElement::webScriptValueAtIndex):
8415 (DOMElement::setWebScriptValueAtIndex):
8416 (DOMElement::setException):
8417 (DOMElement::nodeName):
8418 (DOMElement::nodeValue):
8419 (DOMElement::setNodeValue):
8420 (DOMElement::nodeType):
8421 (DOMElement::parentNode):
8422 (DOMElement::childNodes):
8423 (DOMElement::firstChild):
8424 (DOMElement::lastChild):
8425 (DOMElement::previousSibling):
8426 (DOMElement::nextSibling):
8427 (DOMElement::attributes):
8428 (DOMElement::ownerDocument):
8429 (DOMElement::insertBefore):
8430 (DOMElement::replaceChild):
8431 (DOMElement::removeChild):
8432 (DOMElement::appendChild):
8433 (DOMElement::hasChildNodes):
8434 (DOMElement::cloneNode):
8435 (DOMElement::isSupported):
8436 (DOMElement::namespaceURI):
8437 (DOMElement::prefix):
8438 (DOMElement::setPrefix):
8439 (DOMElement::localName):
8440 (DOMElement::hasAttributes):
8441 (DOMElement::isSameNode):
8442 (DOMElement::isEqualNode):
8443 (DOMElement::textContent):
8444 (DOMElement::setTextContent):
8446 2010-04-05 Alexey Proskuryakov <ap@apple.com>
8448 Reviewed by Darin Adler.
8450 https://bugs.webkit.org/show_bug.cgi?id=37111
8451 <rdar://problem/7790327> Draw replacement text when plug-in host crashes
8453 * WebCoreLocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in
8456 2010-04-02 Rafael Weinstein <rafaelw@chromium.org>
8458 Reviewed by Adam Barth.
8460 Clean up unused calls after changes to checkPermission and requestPermission argument lists.
8462 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
8463 (WebDesktopNotificationsDelegate::requestPermission):
8464 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
8466 2010-04-01 Chris Marrin <cmarrin@apple.com>
8468 Reviewed by Simon Fraser.
8470 Added layerTreeAsText function to DRT (for Mac)
8471 https://bugs.webkit.org/show_bug.cgi?id=36782
8473 This is the WebKit side for Windows. It plumbs the
8474 call from WebCore to DRT.
8476 * Interfaces/IWebFramePrivate.idl:
8477 * WebFrame.cpp:WebKit (Windows) side of plumbing
8478 (WebFrame::layerTreeAsText):
8481 2010-03-31 Marcus Bulach <bulach@chromium.org>
8483 Reviewed by Jeremy Orlow.
8485 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
8486 https://bugs.webkit.org/show_bug.cgi?id=35031
8488 * WebCoreSupport/WebChromeClient.h:
8489 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
8491 2010-03-30 Gavin Barraclough <barraclough@apple.com>
8493 Rubber stamped by Sam Weinig.
8495 https://bugs.webkit.org/show_bug.cgi?id=36866
8499 * WebDownloadCFNet.cpp:
8500 * WebDownloadCurl.cpp:
8501 * WebHistoryItem.cpp:
8502 * WebLocalizableStrings.cpp:
8503 * WebMutableURLRequest.cpp:
8504 * WebPreferences.cpp:
8505 (WebPreferences::migrateWebKitPreferencesToCFPreferences):
8508 2010-03-30 Adam Roben <aroben@apple.com>
8512 * Interfaces/WebKit.idl: Touched this to force a build.
8514 2010-03-29 Steve Falkenburg <sfalken@apple.com>
8516 Reviewed by Adele Peterson.
8518 Default value of accelerated compositing should be false for Windows
8519 https://bugs.webkit.org/show_bug.cgi?id=36805
8521 * WebPreferences.cpp:
8522 (WebPreferences::initializeDefaultSettings):
8524 2010-03-29 Rafael Weinstein <rafaelw@chromium.org>
8526 Reviewed by Adam Barth.
8528 Change NotificationPresenter::checkPermission() to take the source frames full KURL,
8529 rather than its SecurityOrigin. This will aid chromium in having more fine grained
8530 permissions to control notification spam.
8532 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
8533 (WebDesktopNotificationsDelegate::checkPermission):
8534 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
8536 2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
8538 Reviewed by Antti Koivisto.
8540 Change method name due to it dealing with both flattening
8541 of frame sets and inner frames.
8543 * Interfaces/IWebPreferencesPrivate.idl:
8544 * WebPreferenceKeysPrivate.h:
8545 * WebPreferences.cpp:
8546 (WebPreferences::initializeDefaultSettings):
8547 (WebPreferences::isFrameFlatteningEnabled):
8548 (WebPreferences::setFrameFlatteningEnabled):
8551 (WebView::notifyPreferencesChanged):
8553 2010-03-24 Jon Honeycutt <jhoneycutt@apple.com>
8555 <rdar://problem/7780798> Missing plug-ins should be represented by text
8556 only, instead of lego block
8558 https://bugs.webkit.org/show_bug.cgi?id=36583
8560 Reviewed by Dan Bernstein.
8562 * WebCoreSupport/WebFrameLoaderClient.cpp:
8563 (WebFrameLoaderClient::createPlugin):
8564 Return 0 if we failed to initialize the plug-in, which causes the new
8565 "missing plug-in" text to draw.
8567 2010-03-24 Kent Tamura <tkent@chromium.org>
8569 Reviewed by Darin Adler.
8571 Make Icon::createIconForFiles() optional.
8572 https://bugs.webkit.org/show_bug.cgi?id=35072
8574 - Rename iconForFiles() to chooseIconForFiles().
8575 - Call Icon::createIconForFiles() from chooseIconForFiles().
8577 * WebCoreSupport/WebChromeClient.cpp:
8578 (WebChromeClient::chooseIconForFiles):
8579 * WebCoreSupport/WebChromeClient.h:
8581 2010-03-22 Darin Adler <darin@apple.com>
8583 * WebCoreLocalizedStrings.cpp:
8584 (WebCore::missingPluginText): Fixed localization helper text to match the same
8585 string from Mac WebKit.
8587 2010-03-22 Kevin Decker <kdecker@apple.com>
8589 Reviewed by John Sullivan.
8591 https://bugs.webkit.org/show_bug.cgi?id=36328
8593 * WebCoreLocalizedStrings.cpp:
8594 (WebCore::missingPluginText): Added.
8596 2010-03-17 Enrica Casucci <enrica@apple.com>
8598 Reviewed by Darin Adler.
8600 Missing support for showing compositing layers borders and repaint count on Windows.
8601 <rdar://problem/7760736>
8602 <https://bugs.webkit.org/show_bug.cgi?id=36197>
8604 * Interfaces/IWebPreferencesPrivate.idl:
8605 * WebPreferenceKeysPrivate.h:
8606 * WebPreferences.cpp:
8607 (WebPreferences::initializeDefaultSettings):
8608 (WebPreferences::showDebugBorders):
8609 (WebPreferences::setShowDebugBorders):
8610 (WebPreferences::showRepaintCounter):
8611 (WebPreferences::setShowRepaintCounter):
8614 (WebView::notifyPreferencesChanged):
8616 2010-03-16 Yury Semikhatsky <yurys@chromium.org>
8618 Reviewed by Pavel Feldman.
8620 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
8622 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
8623 https://bugs.webkit.org/show_bug.cgi?id=35036
8625 * WebCoreSupport/WebInspectorClient.cpp:
8626 (WebInspectorClient::WebInspectorClient):
8627 (WebInspectorClient::~WebInspectorClient):
8628 (WebInspectorClient::openInspectorFrontend):
8629 (WebInspectorClient::highlight):
8630 (WebInspectorClient::hideHighlight):
8631 (WebInspectorClient::updateHighlight):
8632 (WebInspectorFrontendClient::WebInspectorFrontendClient):
8633 (WebInspectorFrontendClient::~WebInspectorFrontendClient):
8634 (WebInspectorFrontendClient::frontendLoaded):
8635 (WebInspectorFrontendClient::localizedStringsURL):
8636 (WebInspectorFrontendClient::hiddenPanels):
8637 (WebInspectorFrontendClient::bringToFront):
8638 (WebInspectorFrontendClient::closeWindow):
8639 (WebInspectorFrontendClient::attachWindow):
8640 (WebInspectorFrontendClient::detachWindow):
8641 (WebInspectorFrontendClient::setAttachedWindowHeight):
8642 (WebInspectorFrontendClient::inspectedURLChanged):
8643 (WebInspectorFrontendClient::closeWindowWithoutNotifications):
8644 (WebInspectorFrontendClient::showWindowWithoutNotifications):
8645 (WebInspectorFrontendClient::destroyInspectorView):
8646 (WebInspectorFrontendClient::updateWindowTitle):
8647 (WebInspectorFrontendClient::onGetMinMaxInfo):
8648 (WebInspectorFrontendClient::onSize):
8649 (WebInspectorFrontendClient::onClose):
8650 (WebInspectorFrontendClient::onSetFocus):
8651 (WebInspectorFrontendClient::onWebViewWindowPosChanging):
8652 (WebInspectorWndProc):
8653 (WebInspectorFrontendClient::windowReceivedMessage):
8654 * WebCoreSupport/WebInspectorClient.h:
8655 (WebInspectorClient::frontendClosing):
8657 (WebInspector::attach):
8658 (WebInspector::detach):
8660 2010-03-14 Dan Bernstein <mitz@apple.com>
8662 Reviewed by Darin Adler.
8664 WebKit part of removing support for legacy versions of Core Graphics
8666 * WebKitClassFactory.cpp:
8667 (WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase().
8668 * WebKitGraphics.cpp:
8670 * WebTextRenderer.cpp:
8671 (WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath().
8673 2010-03-12 Enrica Casucci <enrica@apple.com>
8675 Fixed broken build on Windows.
8676 Added contditional compilation for accelerated compositing.
8679 (WebView::deleteBackingStore):
8680 (WebView::addToDirtyRegion):
8681 (WebView::updateBackingStore):
8683 2010-03-12 Beth Dakin <bdakin@apple.com>
8685 Reviewed by Simon Fraser.
8687 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
8688 API naming is inconsistent
8690 <rdar://problem/7729165>
8692 This patch changes all occurrences of "fullScreen" to the more
8693 popular "fullscreen."
8695 * FullscreenVideoController.cpp:
8696 (FullscreenVideoController::onMouseDown):
8697 (FullscreenVideoController::onMouseMove):
8698 (FullscreenVideoController::onMouseUp):
8699 * FullscreenVideoController.h:
8700 (FullscreenVideoController::fullscreenToHUDCoordinates):
8702 2010-03-12 Beth Dakin <bdakin@apple.com>
8704 Reviewed by Adam Roben.
8706 Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
8707 video HUD stays on top when switching to another window (e.g. via
8710 <rdar://problem/7547574>
8712 The HUD was always on top because it had the WS_EX_TOPMOST style.
8713 So I removed the style and made m_videoWindow the owner of
8714 m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
8715 is the focused window.
8717 * FullscreenVideoController.cpp:
8718 (FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
8719 (FullscreenVideoController::createHUDWindow):
8721 2010-03-12 Enrica Casucci <enrica@apple.com>
8723 Reviewed by Simon Fraser.
8725 Content of 3D tests appears at the bottom right corner sometimes.
8726 <rdar://problem/7556244>
8727 <https://bugs.webkit.org/show_bug.cgi?id=36027>
8729 See detailed comments in WebCore/ChangeLog.
8732 (WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
8733 (WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
8734 backing store dirty region.
8735 (WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
8736 (WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
8737 (WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
8738 We are passing width and height of the view content together with the offset for the scrolling.
8739 It was confusing to pass it all as a rectangle, when it is not a rectangle.
8741 2010-03-11 Aaron Boodman <aa@chromium.org>
8743 Kill WebDocument::applicationID() (part 1).
8745 Modify interface to WebCore::NotificationPresenter::checkPermission()
8746 and remove implementation of WebDocument::applicationID(). Breaking
8747 API changes will be in a subsequent change.
8748 https://bugs.webkit.org/show_bug.cgi?id=35846
8750 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
8751 (WebDesktopNotificationsDelegate::checkPermission):
8752 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
8754 2010-03-11 Anders Carlsson <andersca@apple.com>
8756 Reviewed by David Hyatt.
8758 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
8760 * WebCoreSupport/WebChromeClient.cpp:
8761 * WebCoreSupport/WebChromeClient.h:
8763 2010-03-10 Eric Uhrhane <ericu@chromium.org>
8765 Reviewed by David Levin.
8767 The build fix for my patch on bug #35763 wasn't quite right--it removed
8768 the call entirely, instead of replacing it with the new API. This adds
8769 the call to Database::setIsAvailable.
8771 https://bugs.webkit.org/show_bug.cgi?id=35763
8773 * WebView.cpp: Added a call to Database::setIsAvailable where change 55667 removed the old Settings API call <http://trac.webkit.org/changeset/55667>.
8774 (WebView::notifyPreferencesChanged):
8776 2010-03-10 John Sullivan <sullivan@apple.com>
8778 Reviewed by Tim Hatcher.
8780 <rdar://problem/7735387> input type other than text won't work with autofill
8781 <https://bugs.webkit.org/show_bug.cgi?id=35963>
8784 (WebFrame::elementDoesAutoComplete):
8785 Return true for any text field that's not a password, rather than only
8788 2010-03-09 Brady Eidson <beidson@apple.com>
8790 Reviewed by Tim Hatcher.
8792 REGRESSION: WebInspector docking busted on Windows
8793 <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
8795 * WebCoreSupport/WebInspectorClient.cpp:
8796 (WebInspectorClient::attachWindow): Use the InspectorController:: copy of the should attach settings key.
8797 (WebInspectorClient::detachWindow): Ditto.
8798 (WebInspectorClient::showWindowWithoutNotifications): Ditto.
8800 2010-03-09 John Sullivan <sullivan@apple.com>
8802 Fixed localized string key collision. update-webkit-localized-strings now
8803 runs without errors.
8805 Reviewed by Adam Roben.
8807 * WebCoreLocalizedStrings.cpp:
8808 (WebCore::AXMenuListPopupActionVerb):
8809 Used LPCTSTR_UI_STRING_KEY for the 2nd use of "press".
8811 2010-03-08 Adam Treat <atreat@rim.com>
8813 Unreviewed build fix for Windows.
8815 * WebCoreSupport/WebChromeClient.cpp:
8816 (WebChromeClient::invalidateContents):
8818 2010-03-02 Adam Treat <atreat@rim.com>
8820 Reviewed by Dave Hyatt.
8822 Adapt the win port to the refactoring of repaint methods.
8824 https://bugs.webkit.org/show_bug.cgi?id=34214
8826 * WebCoreSupport/WebChromeClient.cpp:
8827 (WebChromeClient::invalidateContents):
8828 (WebChromeClient::invalidateWindow):
8829 (WebChromeClient::invalidateContentsAndWindow):
8830 (WebChromeClient::invalidateContentsForSlowScroll):
8831 * WebCoreSupport/WebChromeClient.h:
8833 2010-03-08 Daniel Bates <dbates@rim.com>
8835 Unreviewed, build fix.
8837 Attempt to fix the Windows builds by applying the corresponding change
8838 made in bug #35763 <https://bugs.webkit.org/show_bug.cgi?id=35763>.
8840 * WebView.cpp: Removed call to settings->setDatabasesEnabled since this
8841 setting no longer exists following changeset 55666 <http://trac.webkit.org/changeset/55666>.
8842 (WebView::notifyPreferencesChanged):
8844 2010-03-07 Mark Rowe <mrowe@apple.com>
8848 * WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header
8849 since some WebCore headers rely on the types declared within being available via the prefix
8852 2010-03-05 Chris Marrin <cmarrin@apple.com>
8854 Reviewed by Simon Fraser.
8856 Got rid of platformLayer use in WebView.
8857 https://bugs.webkit.org/show_bug.cgi?id=35798
8859 WKCACFLayer no longer depends on GraphicsLayer, so I got rid of
8860 that dependency on WebView. Now WebChromeClient casts platformLayer
8861 to WKCACFLayer which will always be the case on Windows.
8863 * WebCoreSupport/WebChromeClient.cpp:
8864 (WebChromeClient::attachRootGraphicsLayer):
8866 (WebView::setRootChildLayer):
8869 2010-03-04 Beth Dakin <bdakin@apple.com>
8871 Reviewed by Anders Carlsson.
8873 WebCore::Page::setInstanceHandle() is now just
8874 WebCore::setInstanceHandle()
8879 2010-03-03 Alice Liu <alice.liu@apple.com>
8881 Reviewed by Jon Honeycutt.
8883 Add a way to get an iframe's content frame
8885 * DOMCoreClasses.cpp:
8886 (DOMElement::createInstance):
8887 Added case for DOMHTMLIFrameElement
8888 * DOMHTMLClasses.cpp:
8889 Adding the few DOMHTMLIFrameElement functions definitions that have
8890 distinct implementations (all others just call parent implementation)
8891 (DOMHTMLIFrameElement::QueryInterface):
8892 (DOMHTMLIFrameElement::contentFrame):
8894 Most of these function declarations have definitions that just call the parent implementation
8895 (DOMHTMLIFrameElement::DOMHTMLIFrameElement):
8896 (DOMHTMLIFrameElement::AddRef):
8897 (DOMHTMLIFrameElement::Release):
8898 (DOMHTMLIFrameElement::throwException):
8899 (DOMHTMLIFrameElement::callWebScriptMethod):
8900 (DOMHTMLIFrameElement::evaluateWebScript):
8901 (DOMHTMLIFrameElement::removeWebScriptKey):
8902 (DOMHTMLIFrameElement::stringRepresentation):
8903 (DOMHTMLIFrameElement::webScriptValueAtIndex):
8904 (DOMHTMLIFrameElement::setWebScriptValueAtIndex):
8905 (DOMHTMLIFrameElement::setException):
8906 (DOMHTMLIFrameElement::nodeName):
8907 (DOMHTMLIFrameElement::nodeValue):
8908 (DOMHTMLIFrameElement::setNodeValue):
8909 (DOMHTMLIFrameElement::nodeType):
8910 (DOMHTMLIFrameElement::parentNode):
8911 (DOMHTMLIFrameElement::childNodes):
8912 (DOMHTMLIFrameElement::firstChild):
8913 (DOMHTMLIFrameElement::lastChild):
8914 (DOMHTMLIFrameElement::previousSibling):
8915 (DOMHTMLIFrameElement::nextSibling):
8916 (DOMHTMLIFrameElement::attributes):
8917 (DOMHTMLIFrameElement::ownerDocument):
8918 (DOMHTMLIFrameElement::insertBefore):
8919 (DOMHTMLIFrameElement::replaceChild):
8920 (DOMHTMLIFrameElement::removeChild):
8921 (DOMHTMLIFrameElement::appendChild):
8922 (DOMHTMLIFrameElement::hasChildNodes):
8923 (DOMHTMLIFrameElement::cloneNode):
8924 (DOMHTMLIFrameElement::normalize):
8925 (DOMHTMLIFrameElement::isSupported):
8926 (DOMHTMLIFrameElement::namespaceURI):
8927 (DOMHTMLIFrameElement::prefix):
8928 (DOMHTMLIFrameElement::setPrefix):
8929 (DOMHTMLIFrameElement::localName):
8930 (DOMHTMLIFrameElement::hasAttributes):
8931 (DOMHTMLIFrameElement::isSameNode):
8932 (DOMHTMLIFrameElement::isEqualNode):
8933 (DOMHTMLIFrameElement::textContent):
8934 (DOMHTMLIFrameElement::setTextContent):
8935 (DOMHTMLIFrameElement::tagName):
8936 (DOMHTMLIFrameElement::getAttribute):
8937 (DOMHTMLIFrameElement::setAttribute):
8938 (DOMHTMLIFrameElement::removeAttribute):
8939 (DOMHTMLIFrameElement::getAttributeNode):
8940 (DOMHTMLIFrameElement::setAttributeNode):
8941 (DOMHTMLIFrameElement::removeAttributeNode):
8942 (DOMHTMLIFrameElement::getElementsByTagName):
8943 (DOMHTMLIFrameElement::getAttributeNS):
8944 (DOMHTMLIFrameElement::setAttributeNS):
8945 (DOMHTMLIFrameElement::removeAttributeNS):
8946 (DOMHTMLIFrameElement::getAttributeNodeNS):
8947 (DOMHTMLIFrameElement::setAttributeNodeNS):
8948 (DOMHTMLIFrameElement::getElementsByTagNameNS):
8949 (DOMHTMLIFrameElement::hasAttribute):
8950 (DOMHTMLIFrameElement::hasAttributeNS):
8951 (DOMHTMLIFrameElement::focus):
8952 (DOMHTMLIFrameElement::blur):
8953 (DOMHTMLIFrameElement::idName):
8954 (DOMHTMLIFrameElement::setIdName):
8955 (DOMHTMLIFrameElement::title):
8956 (DOMHTMLIFrameElement::setTitle):
8957 (DOMHTMLIFrameElement::lang):
8958 (DOMHTMLIFrameElement::setLang):
8959 (DOMHTMLIFrameElement::dir):
8960 (DOMHTMLIFrameElement::setDir):
8961 (DOMHTMLIFrameElement::className):
8962 (DOMHTMLIFrameElement::setClassName):
8963 (DOMHTMLIFrameElement::innerHTML):
8964 (DOMHTMLIFrameElement::setInnerHTML):
8965 (DOMHTMLIFrameElement::innerText):
8966 (DOMHTMLIFrameElement::setInnerText):
8967 * Interfaces/DOMHTML.idl:
8968 Added IDOMHTMLIFrameElement interface
8970 2010-03-03 Chris Marrin <cmarrin@apple.com>
8972 Reviewed by Simon Fraser.
8974 Export acceleratedCompositing flag in IWebPreferences.
8975 https://bugs.webkit.org/show_bug.cgi?id=35610
8977 * Interfaces/IWebPreferences.idl:
8979 2010-03-02 Beth Dakin <bdakin@apple.com>
8981 Reviewed by Darin Adler and Adam Roben.
8983 Tiny WebKit portion of fix for <rdar://problem/7485289> WebKit
8984 crashes on systems that don't support CoreAnimation
8986 setHostWindow() no longer calls createRenderer(), so now that has
8987 to be called manually.
8990 (WebView::setAcceleratedCompositing):
8992 2010-03-02 Adam Roben <aroben@apple.com>
8994 Add IWebViewPrivate::registerURLSchemeAsSecure
8996 Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose
8997 SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
8999 Reviewed by Tim Hatcher.
9001 * Interfaces/WebKit.idl: Touched to force a build.
9003 * Interfaces/IWebViewPrivate.idl:
9005 (WebView::registerURLSchemeAsSecure):
9007 Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
9009 2010-03-01 Jon Honeycutt <jhoneycutt@apple.com>
9011 Remove Windows line endings from some files.
9013 Rubber-stamped by Alice Liu.
9015 * Interfaces/IWebEmbeddedView.idl:
9017 * WebCoreSupport/EmbeddedWidget.cpp:
9018 (EmbeddedWidget::create):
9019 (EmbeddedWidget::~EmbeddedWidget):
9020 (EmbeddedWidget::createWindow):
9021 (EmbeddedWidget::invalidateRect):
9022 (EmbeddedWidget::setFrameRect):
9023 (EmbeddedWidget::frameRectsChanged):
9024 (EmbeddedWidget::setFocus):
9025 (EmbeddedWidget::show):
9026 (EmbeddedWidget::hide):
9027 (EmbeddedWidget::windowClipRect):
9028 (EmbeddedWidget::setParent):
9029 (EmbeddedWidget::attachToWindow):
9030 (EmbeddedWidget::detachFromWindow):
9031 (EmbeddedWidget::didReceiveResponse):
9032 (EmbeddedWidget::didReceiveData):
9033 (EmbeddedWidget::didFinishLoading):
9034 (EmbeddedWidget::didFail):
9036 * WebCoreSupport/EmbeddedWidget.h:
9037 (EmbeddedWidget::EmbeddedWidget):
9039 2010-03-01 Jon Honeycutt <jhoneycutt@apple.com>
9041 Some WebKit DOMNode API is unimplemented.
9042 https://bugs.webkit.org/show_bug.cgi?id=35554
9044 Reviewed by Alice Liu.
9046 * DOMCoreClasses.cpp:
9047 (DOMNode::nextSibling):
9048 Create a DOMNode to wrap m_node's next sibling, and assign it to the
9050 (DOMNode::insertBefore):
9051 Query for the DOMNode for newChild, and return early if we fail. Query
9052 refChild for DOMNode. Call insertBefore(), passing the newChild's
9053 WebCore node and refChild's WebCore node (if refChild is non-null). If
9054 we successfully insert the child, fill the result out param with
9055 newChild, ref it, and return S_OK. Otherwise, return E_FAIL.
9056 (DOMNode::removeChild):
9057 Query oldChild for DOMNode. If we fail, return E_FAIL. Call
9058 removeChild(), passing the node's WebCore node. If this fails, return
9059 E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and
9062 2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
9064 Reviewed by Adam Barth.
9066 Adapt to the new ZoomMode enum.
9067 https://bugs.webkit.org/show_bug.cgi?id=35347
9070 (WebFrame::setTextSizeMultiplier):
9072 (WebView::setZoomMultiplier):
9073 (WebView::zoomMultiplier):
9074 (WebView::canMakeTextLarger):
9075 (WebView::makeTextLarger):
9076 (WebView::canMakeTextSmaller):
9077 (WebView::makeTextSmaller):
9078 (WebView::notifyPreferencesChanged):
9080 2010-02-26 Jon Honeycutt <jhoneycutt@apple.com>
9082 <rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments
9083 is passed wrong arguments
9085 Reviewed by Adam Roben.
9087 * Interfaces/IWebUIDelegatePrivate.idl:
9088 Update copyright strings. Added a new key for the plug-in source URL.
9090 * Interfaces/WebKit.idl:
9091 Update copyright strings.
9093 * WebCoreSupport/WebFrameLoaderClient.cpp:
9094 (WebFrameLoaderClient::createPlugin):
9095 Pass the URL of the plug-in as the source URL. Pass the document's
9096 base URI for the base URL.
9098 2010-02-23 Brady Eidson <beidson@apple.com>
9100 Reviewed by Tim Hatcher and Pavel Feldman.
9102 Regression (r55107) - WebInspector docking is busted.
9103 https://bugs.webkit.org/show_bug.cgi?id=35274
9105 * WebCoreSupport/WebInspectorClient.cpp:
9106 (WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check
9107 to get the expected behavior.
9109 2010-02-23 Steve Block <steveblock@google.com>
9111 Reviewed by Darin Adler.
9113 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
9114 https://bugs.webkit.org/show_bug.cgi?id=34962
9116 This method is required so that a Geolocation object can cancel an
9117 asynchronous permission request. This allows the chrome client to cancel
9118 any UI it is showing for the permission request.
9120 * WebCoreSupport/WebChromeClient.h:
9121 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
9123 2010-02-22 Steve Falkenburg <sfalken@apple.com>
9125 Reviewed by Darin Adler.
9127 WebKit on Windows should pick up system setting changes without requiring explicit API calls
9128 https://bugs.webkit.org/show_bug.cgi?id=35269
9130 * WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged.
9131 * WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged.
9132 * WebKitGraphics.cpp: Removed WebKitSystemParameterChanged.
9133 * WebKitGraphics.h: Removed WebKitSystemParameterChanged.
9135 (systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes.
9136 (WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage.
9138 2010-02-22 Brady Eidson <beidson@apple.com>
9140 Reviewed by Tim Hatcher.
9142 Disable WebView docking to views that are too small.
9143 <rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
9145 * WebCoreSupport/WebInspectorClient.cpp:
9146 (WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector
9147 window attached if WebCore says it shouldn't be attached.
9149 2010-02-17 Steve Falkenburg <sfalken@apple.com>
9151 Reviewed by Dan Bernstein.
9153 WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages
9154 https://bugs.webkit.org/show_bug.cgi?id=35076
9156 * WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged.
9157 * WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged.
9158 * WebKitGraphics.cpp:
9159 (WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes.
9160 * WebKitGraphics.h: Added WebKitSystemParameterChanged.
9162 2010-02-17 Dmitry Titov <dimich@chromium.org>
9164 Reviewed by David Levin, Darin Fisher, Simon Hausmann.
9166 When a live iframe element is moved between pages, it still depends on the old page.
9167 https://bugs.webkit.org/show_bug.cgi?id=34382
9169 * WebCoreSupport/WebFrameLoaderClient.cpp:
9170 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
9171 Added empty implementation of a new virtual method.
9173 * WebCoreSupport/WebFrameLoaderClient.h:
9175 2010-02-17 Kent Tamura <tkent@chromium.org>
9177 Reviewed by Eric Seidel.
9179 Introduces new Icon loading interface in order to support
9180 asynchronous loading.
9181 https://bugs.webkit.org/show_bug.cgi?id=32054
9183 Add an empty implementation of ChromeClient::iconForFiles().
9185 * WebCoreSupport/WebChromeClient.cpp:
9186 (WebChromeClient::iconForFiles):
9187 * WebCoreSupport/WebChromeClient.h:
9189 2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
9191 Unreviewed. Touch WebKit.idl to fix the build.
9193 [Win] Implement test functions for printing
9194 https://bugs.webkit.org/show_bug.cgi?id=34570
9196 * Interfaces/WebKit.idl:
9198 2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
9200 Reviewed by Eric Seidel.
9202 [Win] Implement test functions for printing
9203 https://bugs.webkit.org/show_bug.cgi?id=34570
9205 * Interfaces/IWebFramePrivate.idl:
9207 (WebFrame::pageNumberForElementById):
9208 (WebFrame::numberOfPages):
9211 2010-02-16 Darin Adler <darin@apple.com>
9213 Reviewed by Sam Weinig.
9215 Generalize delayed plug-in start for background tabs for use for other media
9216 https://bugs.webkit.org/show_bug.cgi?id=34981
9219 (WebView::setCanStartPlugins): Change to call setCanStartMedia.
9220 In a later patch we can change the of the public function in the IDL file too,
9221 but for now this should be enough.
9223 2010-02-15 Adam Roben <aroben@apple.com>
9225 Add IWebFramePrivate::visibleContentRect
9227 Fixes <http://webkit.org/b/34956> Add API to get a WebFrame's visible
9230 Reviewed by Jon Honeycutt.
9232 * Interfaces/IWebFramePrivate.idl: Added visibleContentRect.
9234 * Interfaces/WebKit.idl: Touched to force a build.
9237 (WebFrame::visibleContentRect):
9239 Added. Calls through to FrameView::visibleContentRect.
9241 2010-02-12 Brian Weinstein <bweinstein@apple.com>
9243 Reviewed by Adam Roben.
9245 onmouseout fired when moving over tooltip on Windows
9246 https://bugs.webkit.org/show_bug.cgi?id=16794
9249 Add WS_EX_TRANSPARENT to out tooltip HWND so it isn't subject to hit testing, and when
9250 you mouse over the tooltip, it doesn't send a mouseout to the web content.
9253 (WebView::initializeToolTipWindow): Add WS_EX_TRANSPARENT.
9255 2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
9257 Reviewed by Kenneth Rohde Christiansen.
9259 Support frameset flattening
9260 https://bugs.webkit.org/show_bug.cgi?id=32717
9262 Add support for enabling/disabling FrameSet Flattening on the Windows port.
9264 * Interfaces/IWebPreferencesPrivate.idl:
9265 * WebPreferenceKeysPrivate.h:
9266 * WebPreferences.cpp:
9267 (WebPreferences::initializeDefaultSettings):
9268 (WebPreferences::isFrameSetFlatteningEnabled):
9269 (WebPreferences::setFrameSetFlatteningEnabled):
9272 (WebView::notifyPreferencesChanged):
9274 2010-02-10 Adam Roben <aroben@apple.com>
9276 Remove unnecessary #include of shfolder.h
9278 shfolder.h has been deprecated in newer versions of the Windows SDK.
9280 Fixes <http://webkit.org/b/34803> WebPreferences.cpp fails to compile
9281 under VS2010 RC due to #include of shfolder.h.
9283 Reviewed by Darin Adler.
9285 * WebPreferences.cpp: Removed #include.
9287 2010-02-08 Charlie Reis <creis@chromium.org>
9289 Reviewed by Darin Adler.
9291 onbeforeunload not called at window close + frame or iframe focused
9292 https://bugs.webkit.org/show_bug.cgi?id=27481
9294 Chromium and WebKit on Windows will now fire beforeunload handlers
9295 even if an inner frame is focused.
9297 Layout tests aren't able to test this bug, since it requires closing
9298 the actual browser window, not calling window.close(). Instead,
9299 test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
9302 (WebView::shouldClose):
9304 2010-02-08 Brent Fulgham <bfulgham@webkit.org>
9306 Reviewed by Adam Roben.
9308 Include header position in World Transform used for plugin positioning.
9309 https://bugs.webkit.org/show_bug.cgi?id=34709
9312 (WebFrame::spoolPage): Correct WinCairo plugin print positioning to
9313 account for header size. Existing code ignored this, causing
9314 plugins to overlay other elements.
9316 2010-02-04 Alice Liu <alice.liu@apple.com>
9318 Reviewed by Jon Honeycutt.
9320 https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
9321 codes for most elements that arent listbox or menupopup related"
9322 <rdar://problem/7436861>
9324 * AccessibleBase.cpp:
9325 (AccessibleBase::accSelect):
9326 - Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that
9327 aren't beneath listboxes or menupopups. This was too restrictive since
9328 any element can be selectable.
9329 - Correct the misinterpretation of MSDN's stipulation of situations involving
9330 adding, removing, and extending selection on single-select elements
9332 2010-02-04 Brent Fulgham <bfulgham@webkit.org>
9334 Reviewed by Adam Roben.
9336 Properly handle margin settings when printing Plugins in WinCairo.
9337 https://bugs.webkit.org/show_bug.cgi?id=34613
9340 (WebFrame::spoolPage): Adjust the GraphicsContext passed to the
9341 paintContents method so that the World Transform is properly
9342 positioned to account for margin settings at the time that
9343 PluginViewWin.cpp processes the drawing operations.
9345 2010-02-04 Brent Fulgham <bfulgham@webkit.org>
9347 Reviewed by Adam Roben.
9349 Properly handle margin settings in WinCairo.
9350 https://bugs.webkit.org/show_bug.cgi?id=34545
9353 (scaleFactor): Require the margin information as an input
9354 parameter, and use them when computing the scaling factor.
9355 (WebFrame::drawHeader): Pass margin size to scaleFactor.
9356 (WebFrame::drawFooter): Pass margin size to scaleFactor.
9357 (WebFrame::spoolPage):
9358 1. Pass margin size to scaleFactor.
9359 2. Recognize that the return value of printerMarginRect is
9360 already in device units, and therefore scale it so that
9361 the Cairo drawing is correct.
9362 3. Remove scaling call for margins in GDI code, as it is
9363 already in scaled units.
9365 2010-02-03 Brian Weinstein <bweinstein@apple.com>
9367 Reviewed by Steve Falkenburg.
9369 Scroll does not work with IBM Thinkpad.
9370 <https://bugs.webkit.org/show_bug.cgi?id=14227>
9373 When initializing the WebView, add two scrollbar Windows inside of
9374 our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
9375 (similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.
9377 Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
9378 like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.
9380 Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
9384 (WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down
9386 (WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right
9388 (WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
9389 (WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create
9390 vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.
9391 (WebView::shouldInitializeTrackPointHack): Check if there is a registry key for
9392 the some kind of IBM Trackpoint driver.
9395 2010-02-02 Steve Falkenburg <sfalken@apple.com>
9397 Reviewed by Darin Adler.
9399 Copyright year updating for Windows version resources should be automatic
9400 https://bugs.webkit.org/show_bug.cgi?id=34503
9402 * WebKit.vcproj/WebKit.rc:
9404 2010-02-02 Adam Roben <aroben@apple.com>
9406 Stop copying WebCore's IDL files from SRCROOT to OBJROOT
9408 WebKit doesn't use these anymore (as of r52921).
9410 Part of Bug 34496: Clean up WebCore's IDL/script copying
9411 <https://bugs.webkit.org/show_bug.cgi?id=34496>
9413 Reviewed by Steve Falkenburg.
9415 * WebKit.vcproj/WebKit.make:
9417 2010-01-29 Gavin Barraclough <barraclough@apple.com>
9419 Reviewed by Sam Weinig + Oliver Hunt.
9421 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
9423 Pass processeing user gensture flag to media play/pause methods.
9425 * FullscreenVideoController.cpp:
9426 (FullscreenVideoController::play):
9427 (FullscreenVideoController::pause):
9429 2010-01-29 Brian Weinstein <bweinstein@apple.com>
9431 Reviewed by Adam Roben.
9433 Drag and Drop: Windows uses "stop" sign as cursor when dragging
9434 https://bugs.webkit.org/show_bug.cgi?id=34305
9435 <rdar://problem/7589672>
9437 Add a preference in WebKit (that defaults to false), for whether or not
9438 we should show the custom cursors during drag and drop. However, this is
9439 currently only used on Windows, and only used to hide the "drop not allowed"
9440 icon inside the WebView is the preference is set to true.
9442 This will be off by default, so no change in behavior.
9444 * Interfaces/IWebPreferencesPrivate.idl: Added new functions.
9445 * Interfaces/WebKit.idl: Touched to force Interfaces build.
9446 * WebDropSource.cpp:
9447 (WebDropSource::GiveFeedback): Implementation of conditional showing cursor
9449 * WebPreferenceKeysPrivate.h: Added new preference key.
9450 * WebPreferences.cpp: Added new functions.
9451 (WebPreferences::setCustomDragCursorsEnabled):
9452 (WebPreferences::customDragCursorsEnabled):
9453 * WebPreferences.h: Added new functions.
9455 2010-01-28 Jon Honeycutt <jhoneycutt@apple.com>
9457 MSAA: Crash when posting a notification for a detached object
9459 https://bugs.webkit.org/show_bug.cgi?id=34309
9460 <rdar://problem/7409759>
9462 Reviewed by Darin Adler.
9464 * AccessibleBase.cpp:
9465 (AccessibleBase::QueryService):
9466 If an unrecognized service ID is passed, return early. Otherwise, return
9467 the result of QueryInterface.
9468 (AccessibleBase::QueryInterface):
9469 Add static_casts. Check for new UUIDs.
9470 (AccessibleBase::isSameObject):
9471 Query the object for AccessibleBase. Return whether the pointers or the
9472 wrapped objects match.
9475 Give the class a UUID so we can query for it in isSameObject(). Inherit
9476 from IAccessibleComparable; inherit from IServiceProvider so clients can
9477 use QueryService to query for a custom interface.
9479 * Interfaces/AccessibleComparable.idl: Added. Declares a function that
9480 can be called to compare to accessible objects.
9482 * Interfaces/WebKit.idl:
9483 Include the new IDL.
9485 * WebKit.vcproj/Interfaces.vcproj:
9486 Add the new IDL to the project.
9488 2010-01-27 Aaron Boodman <aa@chromium.org>
9490 Expand NotificationCenter::checkPermission() interface.
9491 It now passes the full URL instead of just the origin.
9493 https://bugs.webkit.org/show_bug.cgi?id=34238
9495 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
9496 (WebDesktopNotificationsDelegate::checkPermission):
9497 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
9499 2010-01-27 Adam Roben <aroben@apple.com>
9501 Make it possible to instantiate WebSerializedJSValue using
9502 WebKitCreateInstance
9504 Reviewed by Dave Hyatt.
9507 * WebKitClassFactory.cpp:
9508 Added WebSerializedJSValue.
9510 2010-01-26 Steve Falkenburg <sfalken@apple.com>
9512 Reviewed by Oliver Hunt.
9514 Windows build references non-existent include paths
9515 https://bugs.webkit.org/show_bug.cgi?id=34175
9517 * WebKit.vcproj/WebKit.vcproj:
9519 2010-01-25 Steve Falkenburg <sfalken@apple.com>
9521 Reviewed by Simon Fraser.
9523 A WebGeolocationControllerClient is leaked for every WebView
9524 https://bugs.webkit.org/show_bug.cgi?id=34145
9526 * WebCoreSupport/WebGeolocationControllerClient.cpp:
9527 (WebGeolocationControllerClient::geolocationDestroyed): Added.
9528 * WebCoreSupport/WebGeolocationControllerClient.h:
9530 2010-01-23 Dan Bernstein <mitz@apple.com>
9532 Reviewed by Maciej Stachowiak.
9534 <rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows
9535 https://bugs.webkit.org/show_bug.cgi?id=34006
9537 * WebPreferences.cpp:
9538 (WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey
9539 with a default value of true.
9541 2010-01-20 Steve Falkenburg <sfalken@apple.com>
9543 Reviewed by Sam Weinig.
9545 Add missing implementation for WebGeolocationPosition::initWithTimestamp.
9547 * WebGeolocationPosition.cpp:
9548 (WebGeolocationPosition::initWithTimestamp): Implemented.
9550 2010-01-20 Jon Honeycutt <jhoneycutt@apple.com>
9552 MSAA: accSelect() is not implemented
9554 https://bugs.webkit.org/show_bug.cgi?id=33918
9555 <rdar://problem/7436861>
9557 Reviewed by Darin Adler.
9559 * AccessibleBase.cpp:
9560 (AccessibleBase::accSelect):
9561 If there is an invalid combination of state flags, return early. If the
9562 caller passed the "take focus" flag, focus the object. If the "take
9563 selection" flag was passed, check whether the parent object is an
9564 AccessibilityListBox; if so, call the object's setSelectedChildren()
9565 function. If the parent is an AccessibilityMenuListPopup, call the
9566 child object's setSelected() function. Otherwise, if the parent is some
9567 other, unsupported object, return early.
9568 If the selection flags include "add", "remove", or "extend" selection,
9569 and the parent object is not multi-selectable, return early. Otherwise,
9570 set or unset the child's selected flag based on the passed flag.
9572 2010-01-20 Steve Falkenburg <sfalken@apple.com>
9574 Reviewed by Darin Adler and Adam Roben.
9576 Feature defines are difficult to maintain on Windows builds
9577 https://bugs.webkit.org/show_bug.cgi?id=33883
9579 FeatureDefines.vsprops are now maintained in a way similar to
9580 Configurations/FeatureDefines.xcconfig, with the added advantage
9581 of having a single FeatureDefines file across all projects.
9583 * WebKit.vcproj/Interfaces.vcproj: Add FeatureDefines.vsprops inherited property sheet.
9584 * WebKit.vcproj/WebKit.sln: Set up Cairo configuration for WebCoreGenerated.
9585 * WebKit.vcproj/WebKit.vcproj: Remove ENABLE_ preprocessor definitions.
9586 Add FeatureDefines.vsprops inherited property sheet.
9587 * WebKit.vcproj/WebKitGUID.vcproj: Add FeatureDefines.vsprops inherited property sheet.
9589 2010-01-17 Jon Honeycutt <jhoneycutt@apple.com>
9591 MSAA: The child <option> elements of a non-multiple <select> are not
9594 https://bugs.webkit.org/show_bug.cgi?id=33773
9595 <rdar://problem/7550556>
9597 Reviewed by Alice Liu.
9599 * AccessibleBase.cpp:
9600 (AccessibleBase::get_accState):
9601 If the object is invisible, set the invisible state flag. If the object
9602 is collapsed, set the collapsed state. If the object is a combo box,
9603 set the has popup flag, and if it's not collapsed, set the expanded
9606 Add new WebCore to MSAA role mappings.
9608 * WebCoreLocalizedStrings.cpp:
9609 (WebCore::AXMenuListActionVerb):
9610 Return the action verb that Firefox uses for <select> elements with
9612 (WebCore::AXMenuListPopupActionVerb):
9613 Return the verb that Firefox uses for a popup list.
9615 2010-01-19 John Sullivan <sullivan@apple.com>
9617 https://bugs.webkit.org/show_bug.cgi?id=33854
9618 Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns
9619 more info about where the result was found
9621 Reviewed by Darin Adler
9623 * Interfaces/IWebHTMLRepresentation.idl:
9624 Created variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
9626 * Interfaces/WebKit.idl:
9627 Touched in order to get other idl change to propagate correctly.
9629 * WebHTMLRepresentation.cpp:
9630 (WebHTMLRepresentation::deprecatedSearchForLabels):
9631 Renamed since iDL doesn't support two functions with the same name but different signatures.
9632 (WebHTMLRepresentation::searchForLabels):
9633 Implemented variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
9635 * WebHTMLRepresentation.h:
9636 Declared variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
9638 2010-01-19 Adam Roben <aroben@apple.com>
9642 * WebScriptWorld.cpp: Added missing #include.
9644 2010-01-19 Dave Hyatt <hyatt@apple.com>
9646 Build bustage fix. Make sure the newly added scriptWorldForGlobalContext function is [local] in the IDL.
9648 * Interfaces/IWebScriptWorld.idl:
9650 2010-01-19 Dave Hyatt <hyatt@apple.com>
9652 Reviewed by Adam Roben.
9654 Add an API to obtain a WebScriptWorld from a JSGlobalContextRef.
9656 * Interfaces/IWebScriptWorld.idl:
9657 * WebScriptWorld.cpp:
9658 (WebScriptWorld::scriptWorldForGlobalContext):
9661 2010-01-18 Adam Roben <aroben@apple.com>
9663 Add IWebViewPrivate::setDomainRelaxationForbiddenForURLScheme
9665 WebKit/win part of fixing <http://webkit.org/b/33806>
9666 <rdar://problem/7552837> Would like API to disallow setting of
9667 document.domain for pages with certain URL schemes
9669 Reviewed by Sam Weinig.
9671 * Interfaces/IWebViewPrivate.idl: Added
9672 setDomainRelaxationForbiddenForURLScheme.
9674 * Interfaces/WebKit.idl: Touched to force a build.
9677 (WebView::setDomainRelaxationForbiddenForURLScheme):
9679 Added. Calls through to SecurityOrigin.
9681 2010-01-18 Chris Marrin <cmarrin@apple.com>
9683 Reviewed by Darin Adler.
9685 Use new setScrollFrame API
9686 https://bugs.webkit.org/show_bug.cgi?id=32279
9689 (WebView::updateRootLayerContents):
9691 2010-01-15 Jon Honeycutt <jhoneycutt@apple.com>
9693 MSAA: Screen rect for <option> elements is always the zero rect
9695 https://bugs.webkit.org/show_bug.cgi?id=33758
9697 Reviewed by Oliver Hunt.
9699 * AccessibleBase.cpp:
9700 (AccessibleBase::accLocation):
9701 Use elementRect() rather than boundingBoxRect(), which
9702 AccessibilityListBoxOption overrides.
9704 2010-01-15 Jon Honeycutt <jhoneycutt@apple.com>
9706 get_accParent should try to retrieve parent AccessibilityObject, before
9709 https://bugs.webkit.org/show_bug.cgi?id=22893
9711 Reviewed by Darin Adler.
9713 * AccessibleBase.cpp:
9714 (AccessibleBase::get_accParent):
9715 If the object has a parent object, return it. If not, return the
9716 accessible for the WebView window.
9718 2010-01-12 Jon Honeycutt <jhoneycutt@apple.com>
9720 MSAA: selected, selectable, extended selectable, and multiple
9721 selectable states are not reported
9723 https://bugs.webkit.org/show_bug.cgi?id=33574
9724 <rdar://problem/7536826>
9726 Reviewed by Darin Adler.
9728 * AccessibleBase.cpp:
9729 (AccessibleBase::get_accState):
9730 Remove the call to isMultiSelect(). Call the correctly-named
9731 isMultiSelectable(), and if it returns true, set both the "extended
9732 selectable" and "multiple selectable" states. Check whether the object
9733 is selected or selectable, and report those states.
9735 2010-01-13 Steve Falkenburg <sfalken@apple.com>
9737 Reviewed by Adam Roben.
9739 Add additional Geolocation interfaces in WebKit for Windows.
9741 * Interfaces/IWebGeolocationPolicyListener.idl: Added.
9742 * Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2.
9743 Append since this version hasn't shipped.
9744 * Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl.
9745 * WebCoreSupport/WebChromeClient.cpp:
9746 (WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest.
9747 * WebCoreSupport/WebGeolocationControllerClient.cpp:
9748 (WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *.
9749 * WebGeolocationPolicyListener.cpp: Added.
9750 * WebGeolocationPolicyListener.h: Added.
9751 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener.
9752 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener.
9754 (WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE.
9755 (WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE.
9756 (WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE.
9757 (WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE.
9759 2010-01-12 Steve Falkenburg <sfalken@apple.com>
9761 Reviewed by Adam Roben, Sam Weinig.
9763 Add Geolocation interfaces in WebKit for Windows.
9765 * ForEachCoClass.h: Added WebGeolocationPosition.
9766 * Interfaces/IWebError.idl:
9767 * Interfaces/IWebGeolocationPosition.idl: Added.
9768 * Interfaces/IWebGeolocationProvider.idl: Added.
9769 * Interfaces/IWebViewPrivate.idl:
9770 * Interfaces/WebKit.idl:
9771 * WebCoreSupport/WebGeolocationControllerClient.cpp: Added.
9772 (WebGeolocationControllerClient::WebGeolocationControllerClient):
9773 (WebGeolocationControllerClient::startUpdating):
9774 (WebGeolocationControllerClient::stopUpdating):
9775 (WebGeolocationControllerClient::lastPosition):
9776 * WebCoreSupport/WebGeolocationControllerClient.h: Added.
9777 * WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation.
9778 * WebGeolocationPosition.h: Added IWebGeolocationPosition implementation.
9779 * WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl,
9780 relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl
9781 * WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp,
9782 * WebKitClassFactory.cpp: Add WebGeolocationPosition include.
9784 (WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled.
9785 (WebView::setGeolocationProvider): Added Geolocation-specific method.
9786 (WebView::geolocationProvider): Added Geolocation-specific method.
9787 (WebView::geolocationDidChangePosition): Added Geolocation-specific method.
9788 (WebView::geolocationDidFailWithError): Added Geolocation-specific method.
9789 * WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError.
9791 2010-01-11 Jon Honeycutt <jhoneycutt@apple.com>
9793 MSAA: Accessibility role of <select multiple> elements is wrong
9795 https://bugs.webkit.org/show_bug.cgi?id=33522
9797 Reviewed by Darin Adler.
9799 * AccessibleBase.cpp:
9801 Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
9802 "list" and "list item" roles.
9804 2010-01-08 Brent Fulgham <bfulgham@webkit.org>
9806 Build fix, no review.
9808 Protect video control logic inside ENABLE(VIDEO).
9811 (WebView::enterFullscreenForNode):
9812 (WebView::exitFullscreen):
9815 2010-01-08 Chris Marrin <cmarrin@apple.com>
9817 Reviewed by Adam Roben.
9819 Implement full-screen video for Windows
9820 https://bugs.webkit.org/show_bug.cgi?id=31318
9822 This adds a full-screen controller, FullscreenVideoController,
9823 which manages going in and out of full-screen. The actual
9824 full-screen window is created and managed by logic added
9825 to QTMovieWin. FullscreenVideoController also creates and
9826 manages a HUD. The HUD renders and manages events to
9827 control the playing video. Movie controller events go to
9828 FullscreenVideoController which then sends them to HTMLMediaElement,
9829 which is passed to the controller by WebView, which gets the call
9830 to go into full-screen mode from HTMLMediaElement via
9833 I've also updated the icons so the related sets (Play/Pause and
9834 volume high/volume low/exit fullscreen) are the same size. This
9835 allows me to position them using common code.
9837 * WebCoreSupport/WebChromeClient.cpp:
9838 (WebChromeClient::supportsFullscreenForNode):
9839 (WebChromeClient::enterFullscreenForNode):
9840 (WebChromeClient::exitFullscreenForNode):
9841 * WebCoreSupport/WebChromeClient.h:
9842 * WebKit.vcproj/WebKit.vcproj:
9843 * WebKit.vcproj/fsVideoAudioVolumeHigh.png:
9844 * WebKit.vcproj/fsVideoAudioVolumeLow.png:
9845 * WebKit.vcproj/fsVideoExitFullscreen.png:
9846 * WebKit.vcproj/fsVideoPause.png:
9847 * WebKit.vcproj/fsVideoPlay.png:
9849 (loadResourceIntoBuffer):
9850 * FullscreenVideoController.cpp: Added.
9851 * FullscreenVideoController.h: Added.
9853 (WebView::enterFullscreenForNode):
9854 (WebView::exitFullscreen):
9857 2010-01-08 Brent Fulgham <bfulgham@webkit.org>
9859 Unreviewed correction.
9861 Accidentally left unnecessary modification to hdcFromContext
9862 in when landing r52995.
9865 (hdcFromContext): Back out unneeded modification.
9867 2010-01-08 Brent Fulgham <bfulgham@webkit.org>
9869 Reviewed by Adam Roben.
9871 Use correct cairo surface data type for handling print operations.
9872 https://bugs.webkit.org/show_bug.cgi?id=33022.
9875 (scaleFactor): Handle 'scale = 0' case.
9876 (WebFrame::spoolPage): Use scaleFactor helper function. Account for
9877 margin size in region passed to header/footer routines.
9878 (WebFrame::spoolPages): Properly clean up Cairo surface.
9880 2010-01-07 Kent Tamura <tkent@chromium.org>
9882 Reviewed by Maciej Stachowiak.
9884 Remove COM code generation files.
9885 https://bugs.webkit.org/show_bug.cgi?id=32854
9887 * WebKit.vcproj/DerivedSources.make: Removed.
9888 * WebKit.vcproj/build-generated-files.sh: Removed.
9890 2010-01-05 Adam Roben <aroben@apple.com>
9892 Make IWebView::close and destroying a WebView's HWND optional for
9895 WebView will now take care of these operations itself when its last
9896 reference is released, if they haven't already been done.
9898 IWebView::close now also destroys the WebView's HWND. All WebKit
9899 clients were already performing these operations in succession anyway,
9900 or were attempting to by calling IWebView::close then destroying the
9901 WebView's host window (which actually resulted in the WebView's HWND
9902 leaking, and the crash in the below bug).
9904 Fixes <rdar://problem/7374218> <http://webkit.org/b/32827> Crash when
9905 calling IWebView::close, then releasing the WebView, without calling
9908 Fixes a few WebViewDestruction tests, too.
9910 Reviewed by Steve Falkenburg.
9913 (WebView::~WebView): Don't try to destroy m_viewWindow here. That
9914 should already have happened. Assert that this is the case.
9915 (WebView::close): If m_viewWindow isn't already being destroyed,
9916 destroy it now. Moved the call to revokeDragDrop() here from our
9917 WM_DESTROY handler because it needs to be done before m_viewWindow is
9919 (WebView::WebViewWndProc): Removed call to revokeDragDrop() that
9920 close() now performs.
9921 (WebView::Release): If our last reference is being released, call
9922 close() so that clients don't have to. (It's harmless to call close()
9923 multiple times.) We do this here instead of in the destructor because
9924 close() can cause AddRef() and Release() to be called, and calling
9925 those from within the destructor leads to double-destruction.
9926 (WebView::setHostWindow): Removed an unnecessary (and now harmful)
9928 (WebView::revokeDragDrop): Changed an assertion into a run-time check,
9929 since this will now sometimes be called when m_viewWindow hasn't been
9930 created yet. Changed the IsWindow call to a null-check because we
9931 never hold onto a destroyed m_viewWindow.
9932 (WebView::windowAncestryDidChange): If we don't have a view window,
9933 stop tracking changes to our parent's active state.
9935 2010-01-05 Adam Roben <aroben@apple.com>
9937 Make it safe to call IWebView::close when IWebView::initWithFrame
9940 Part of <rdar://problem/7374218> <http://webkit.org/b/32827> Crash
9941 when IWebView::close, then releasing the WebView, without calling
9944 Reviewed by Steve Falkenburg.
9947 (WebView::close): Null-check m_page and m_preferences before using
9948 them. They will be null if initWithFrame was never called.
9950 2010-01-05 Adam Roben <aroben@apple.com>
9952 Add assertions to catch double-destruction of WebViews earlier
9954 I basically copied the m_deletionHasBegun logic from WTF::RefCounted.
9956 Fixes <http://webkit.org/b/33219>.
9958 Reviewed by Darin Adler.
9961 (WebView::WebView): Initialize m_deletionHasBegun
9962 (WebView::AddRef): Assert that deletion hasn't already begun.
9963 (WebView::Release): Assert that deletion hasn't already begun, then
9964 record when deletion *does* begin.
9966 * WebView.h: Added m_deletionHasBegun.
9968 2010-01-05 Adam Roben <aroben@apple.com>
9970 Remove dead code in WebViewWndProc
9972 Fixes <http://webkit.org/b/33218>.
9974 Reviewed by Darin Adler.
9977 (WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check.
9978 We bail out much earlier in this function if isBeingDestroyed is true.
9980 2010-01-04 Jon Honeycutt <jhoneycutt@apple.com>
9982 MSAA: Accessibility role of <select> elements is wrong
9984 https://bugs.webkit.org/show_bug.cgi?id=33192
9986 Reviewed by Sam Weinig.
9988 * AccessibleBase.cpp:
9990 Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX.
9992 2010-01-04 Alexey Proskuryakov <ap@apple.com>
9994 Reviewed by Darin Adler.
9996 https://bugs.webkit.org/show_bug.cgi?id=33181
9997 The first letter is not removed properly from inline input hole
9999 * WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was
10000 confirmed, cancel it.
10002 2010-01-04 Alexey Proskuryakov <ap@apple.com>
10004 Reviewed by Darin Adler.
10006 https://bugs.webkit.org/show_bug.cgi?id=33161
10007 Assertion failure in WebView when using Chinese Simplified IME
10009 * WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode
10010 check. We can't make assertions about arguments passed from outside WebKit.
10012 2010-01-04 Alexey Proskuryakov <ap@apple.com>
10014 Reviewed by Darin Adler.
10016 https://bugs.webkit.org/show_bug.cgi?id=33157
10017 Implement TextInput logging channel on Windows
10019 * WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary):
10021 Added a TextInput channel in place of unused Network one.
10024 (WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward
10025 it to DefWindowProc, so there is no need to return an unused boolean result for "handled".
10026 (WebView::onIMEStartComposition): Added logging.
10027 (imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition.
10028 (imeNotificationName): A helper function for detailed logging in onIMENotify.
10029 (imeRequestName): A helper function for detailed logging in onIMERequest.
10030 (WebView::onIMEComposition): Added logging.
10031 (WebView::onIMEEndComposition): Ditto.
10032 (WebView::onIMEChar): Ditto.
10033 (WebView::onIMENotify): Ditto.
10034 (WebView::onIMERequestCharPosition): Changed to return result directly.
10035 (WebView::onIMERequestReconvertString): Ditto.
10036 (WebView::onIMERequest): Changed to return result directly. Added logging.
10037 (WebView::onIMESelect): Added logging.
10038 (WebView::onIMESetContext): Added logging.
10040 * WebView.h: onIMERequest functions now return result directly.
10043 2010-01-04 Adam Roben <aroben@apple.com>
10047 Fixes <http://webkit.org/b/33167>.
10049 Reviewed by Sam Weinig.
10051 * WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just
10052 after DumpRenderTree.vcproj.
10054 2010-01-04 Dan Bernstein <mitz@apple.com>
10056 Reviewed by Ada Chan and Mark Rowe.
10058 Updated copyright string
10060 * WebKit.vcproj/WebKit.rc:
10062 2009-12-22 Darin Adler <darin@apple.com>
10064 Another try at fixing Windows build.
10066 * WebKitPrefix.cpp: Touch it.
10068 2009-12-22 Darin Adler <darin@apple.com>
10070 Reviewed by Mark Rowe.
10072 Turn off datagrid by default, at least for all platforms Apple ships.
10073 The datagrid implementation isn't ready for general web use yet.
10075 * WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default.
10077 2009-12-21 Adam Roben <aroben@apple.com>
10079 Fix non-ACCELERATED_COMPOSITING builds
10081 * WebPreferences.cpp:
10082 (WebPreferences::acceleratedCompositingEnabled): Guard use of
10083 WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING).
10085 2009-12-18 Adam Roben <aroben@apple.com>
10087 Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled
10089 Fixes <http://webkit.org/b/32745>.
10091 Reviewed by Ada Chan.
10093 * Interfaces/IWebPreferencesPrivate.idl: Added
10094 [set]AcceleratedCompositingEnabled.
10096 * Interfaces/WebKit.idl: Touched to force a build.
10098 * WebPreferenceKeysPrivate.h: Added
10099 WebKitAcceleratedCompositingEnabledPreferenceKey.
10101 * WebPreferences.cpp:
10102 (WebPreferences::initializeDefaultSettings): Make accelerated
10103 compositing be on by default.
10104 (WebPreferences::setAcceleratedCompositingEnabled): Store the new
10106 (WebPreferences::acceleratedCompositingEnabled): If accelerated
10107 compositing isn't available, return false. Otherwise, return the value
10108 stored in preferences.
10110 * WebPreferences.h: Added [set]AcceleratedCompositingAvailable.
10113 (WebView::notifyPreferencesChanged): Just pass the value from
10114 WebPreferences on down.
10116 2009-12-17 Jon Honeycutt <jhoneycutt@apple.com>
10118 MSAA: Accessibility role of list items is wrong
10120 https://bugs.webkit.org/show_bug.cgi?id=32688
10122 Reviewed by Adam Roben.
10124 * AccessibleBase.cpp:
10126 Make the WebCore list item role map to the MSAA list item role.
10128 2009-12-17 Jon Honeycutt <jhoneycutt@apple.com>
10130 MSAA: Accessibility role of list markers is wrong
10132 https://bugs.webkit.org/show_bug.cgi?id=32687
10134 Reviewed by Adam Roben.
10136 * AccessibleBase.cpp:
10138 Make the WebCore list marker role map to the MSAA static text role.
10140 2009-12-18 Adam Roben <aroben@apple.com>
10142 Add #includes needed after WebCore clean-up
10144 Rubber-stamped by Anders Carlsson.
10146 Fixes <http://webkit.org/b/32718>.
10148 * WebCoreSupport/WebContextMenuClient.cpp:
10149 * WebDataSource.cpp:
10150 * WebHTMLRepresentation.cpp:
10154 2009-12-17 Benjamin Otte <otte@gnome.org>
10156 Reviewed by Adam Roben.
10158 Don't include all JSC headers everywhere
10159 https://bugs.webkit.org/show_bug.cgi?id=32663
10161 * WebCoreLocalizedStrings.cpp: Added now-needed #include of
10164 2009-12-17 Adam Roben <aroben@apple.com>
10166 Remove WebKit.sln's Debug_All and Debug_Internal configurations
10168 These configurations aren't buildable by people outside of Apple, and
10169 Apple doesn't use this solution file.
10171 Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration
10172 should default to Debug instead of Debug_all.
10174 Rubber-stamped by Dan Bernstein.
10176 * WebKit.vcproj/WebKit.sln:
10178 2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
10180 MSAA: Accessibility role of text nodes is wrong
10182 https://bugs.webkit.org/show_bug.cgi?id=32631
10183 <rdar://problem/7369084>
10185 Reviewed by Alice Liu.
10187 * AccessibleBase.cpp:
10189 If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT.
10190 (AccessibleBase::role):
10191 Call roleValueForMSAA().
10193 2009-12-14 Brent Fulgham <bfulgham@webkit.org>
10195 Reviewed by Adam Roben.
10197 Provide working printing support for WinCairo port.
10200 (WebFrame::spoolPage): Conditionalize initialization of
10201 PlatformGraphicsContext handling for CG vs. Cairo.
10202 (scaleFactor): Add helper function.
10203 (hdcFromContext): Add helper function.
10204 (WebFrame::drawHeader): Correct Cairo variation.
10205 (WebFrame::drawFooter): Correct Cairo variation.
10206 (WebFrame::spoolPages): Correct Cairo variation.
10208 2009-12-13 Sam Weinig <sam@webkit.org>
10210 Reviewed by Dan Bernstein.
10212 Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
10213 Add client based Geolocation provider
10215 Add first cut of a client based Geolocation provider. This is guarded by
10216 ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
10217 GeolocationControllerClient interface that no-one currently implements,
10218 but will in a subsequent patch.
10221 (WebView::initWithFrame):
10223 2009-12-14 Adam Roben <aroben@apple.com>
10225 Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4
10227 Reviewed by Steve Falkenburg.
10229 Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on
10230 a link element crashes WebKit nightly
10232 * Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end
10233 of the interface so the vtable that Safari 4.0.4 sees is unchanged.
10235 2009-12-14 Adam Roben <aroben@apple.com>
10239 * WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the
10240 libpath for all non-Cairo configurations (it was missing from most of
10243 2009-12-11 Chris Marrin <cmarrin@apple.com>
10245 Reviewed by Jon Honeycutt.
10247 Added icons for full-screen video on Windows
10248 https://bugs.webkit.org/show_bug.cgi?id=31318
10250 * WebKit.vcproj/WebKit.rc:
10251 * WebKit.vcproj/WebKit.vcproj:
10252 * WebKit.vcproj/fsVideoAudioVolumeHigh.png: Added.
10253 * WebKit.vcproj/fsVideoAudioVolumeLow.png: Added.
10254 * WebKit.vcproj/fsVideoExitFullscreen.png: Added.
10255 * WebKit.vcproj/fsVideoPause.png: Added.
10256 * WebKit.vcproj/fsVideoPlay.png: Added.
10257 * WebKit.vcproj/resource.h:
10259 2009-12-11 Chris Marrin <cmarrin@apple.com>
10261 Reviewed by Adam Roben.
10263 Delay load DLLs for accelerated compositing
10264 https://bugs.webkit.org/show_bug.cgi?id=31856
10266 If the DLLs (d3d9 and QuartzCore). are not present it
10267 turns off accelerated compositing and avoids calling
10268 any of the functions in the DLLs.
10271 (WebView::notifyPreferencesChanged):
10273 2009-12-10 Jon Honeycutt <jhoneycutt@apple.com>
10275 Pass more information about a plug-in to the PluginHalterDelegate
10277 Reviewed by Adam Roben.
10279 * Interfaces/IWebPluginHalterDelegate.idl:
10280 Add new parameters.
10282 * WebCoreSupport/WebPluginHalterClient.cpp:
10283 (WebPluginHalterClient::shouldHaltPlugin):
10284 Update for new parameters. Pass them when making the delegate call.
10286 * WebCoreSupport/WebPluginHalterClient.h:
10287 Update for new parameters.
10289 2009-12-09 Brent Fulgham <bfulgham@webkit.org>
10291 Revert incorrect commit-box update r51911.
10292 It mistakenly set the selectAll implementation in the
10296 (WebFrame::deselectAll):
10298 2009-12-09 Brent Fulgham <bfulgham@webkit.org>
10300 Reviewed by Darin Adler.
10302 Provide an implementation for 'selectAll'
10303 https://bugs.webkit.org/show_bug.cgi?id=32296
10306 (WebFrame::selectAll): Implement "SelectAll" command.
10308 2009-12-09 Brent Fulgham <bfulgham@webkit.org>
10310 Reviewed by Darin Adler.
10312 Provide an implementation for 'selectAll'
10313 https://bugs.webkit.org/show_bug.cgi?id=32296
10316 (WebFrame::selectAll): Implement "SelectAll" command.
10318 2009-12-08 Chris Marrin <cmarrin@apple.com>
10320 Reviewed by Adam Roben.
10322 Delay load DLLs for accelerated compositing
10323 https://bugs.webkit.org/show_bug.cgi?id=31856
10325 If the DLLs (d3d9 and QuartzCore). are not present it
10326 turns off accelerated compositing and avoids calling
10327 any of the functions in the DLLs.
10332 2009-12-08 Adam Roben <aroben@apple.com>
10336 * Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild.
10338 2009-12-08 John Sullivan <sullivan@apple.com>
10340 Reviewed by Dan Bernstein
10342 Split two-clause assertions into two separate assertions.
10344 * DOMHTMLClasses.cpp:
10345 (DOMHTMLInputElement::isTextField):
10346 Split a two-clause assertion into two separate assertions.
10347 (DOMHTMLInputElement::rectOnScreen):
10348 Added the two assertions here that all other functions in this group shared.
10349 (DOMHTMLInputElement::selectedRange):
10350 Split a two-clause assertion into two separate assertions.
10351 (DOMHTMLInputElement::setAutofilled):
10352 Split a two-clause assertion into two separate assertions.
10353 (DOMHTMLInputElement::isAutofilled):
10354 Split a two-clause assertion into two separate assertions.
10356 2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
10358 Rubber-stamped by Maciej Stachowiak.
10360 Turn on (SVG) Filters for Win.
10361 https://bugs.webkit.org/show_bug.cgi?id=32224
10363 * WebKit.vcproj/WebKit.vcproj:
10365 2009-12-08 John Sullivan <sullivan@apple.com>
10367 Add isAutofilled getter to match existing setter.
10369 Reviewed by Ada Chan.
10371 * DOMHTMLClasses.cpp:
10372 (DOMHTMLInputElement::isAutofilled):
10373 Implemented new cover function.
10375 * DOMHTMLClasses.h:
10376 Declared new cover function.
10378 * Interfaces/DOMPrivate.idl:
10379 Declared new interface.
10381 2009-12-07 Gavin Barraclough <barraclough@apple.com>
10383 Reviewed by NOBODY (Windows build fix part III).
10386 (WebView::stringByEvaluatingJavaScriptFromString):
10388 2009-12-07 Gavin Barraclough <barraclough@apple.com>
10390 Reviewed by NOBODY (Windows build fix part II).
10393 (WebView::stringByEvaluatingJavaScriptFromString):
10395 2009-12-03 Brady Eidson <beidson@apple.com>
10397 Reviewed by Sam Weinig.
10399 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
10401 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
10402 * WebCoreSupport/WebFrameLoaderClient.cpp:
10403 (WebFrameLoaderClient::dispatchDidPushStateWithinPage):
10404 (WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
10405 (WebFrameLoaderClient::dispatchDidPopStateWithinPage):
10406 * WebCoreSupport/WebFrameLoaderClient.h:
10408 2009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
10410 Reviewed by Timothy Hatcher.
10412 Web Inspector: Simplify the settings support in inspector controller.
10414 https://bugs.webkit.org/show_bug.cgi?id=32076
10416 * WebCoreSupport/WebInspectorClient.cpp:
10417 (WebInspectorClient::attachWindow):
10418 (WebInspectorClient::detachWindow):
10419 (WebInspectorClient::showWindowWithoutNotifications):
10420 * WebCoreSupport/WebInspectorClient.h:
10422 2009-12-03 Ben Murdoch <benm@google.com>
10424 Reviewed by Brady Eidson.
10426 [Android] The FrameLoaderClient is unaware of BackForwardList changes.
10427 https://bugs.webkit.org/show_bug.cgi?id=31914
10429 * WebCoreSupport/WebFrameLoaderClient.cpp:
10430 (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
10431 (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
10432 (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
10433 * WebCoreSupport/WebFrameLoaderClient.h:
10435 2009-12-02 Timothy Hatcher <timothy@apple.com>
10437 Move setValueForUser to the end of the DOMHTMLInputElement interface
10438 so it is fine for binary compatibility.
10440 Directed by Steve Falkenburg.
10442 * Interfaces/DOMHTML.idl:
10444 2009-12-02 Timothy Hatcher <timothy@apple.com>
10446 Expose setValueForUser for the COM DOMHTMLInputElement.
10448 <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
10450 Reviewed by Dan Bernstein.
10452 * DOMHTMLClasses.cpp:
10453 (DOMHTMLInputElement::setValueForUser):
10454 * Interfaces/DOMHTML.idl:
10456 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
10458 Not reviewed. Try to fix windows build.
10462 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
10464 Reviewed by Simon Fraser.
10466 Add SVG animation test framework with 'snapshot' functionality
10467 https://bugs.webkit.org/show_bug.cgi?id=31897
10469 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
10470 forwarding the call to SVGDocumentExtensions, if SVG is enabled.
10472 Implemented just like the existing pauseAnimation* methods for CSS animations.
10474 * Interfaces/IWebFramePrivate.idl:
10476 (WebFrame::pauseSVGAnimation):
10479 2009-11-30 Adam Roben <aroben@apple.com>
10481 Fix double-free of BSTRs passed to WebNavigationData::createInstance
10483 WebFrameLoaderClient::updateGlobalHistory was converting
10484 WebCore::Strings to WebCore::BStrings, then passing them to
10485 WebNavigationData::createInstance. But the latter function takes BSTR
10486 parameters and adopts them into WebCore::BStrings. So the end result
10487 was that two WebCore::BStrings would end up freeing each underlying
10490 The fix is to only convert to WebCore::BString inside
10493 Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
10494 (r49564): Crash in updateGlobalHistory when running Javascript iBench
10497 I couldn't find a way to reproduce this in DumpRenderTree.
10499 Reviewed by Steve Falkenburg.
10501 * WebCoreSupport/WebFrameLoaderClient.cpp:
10502 (WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
10503 WebNavigationData::createInstance.
10505 * WebNavigationData.cpp:
10506 (WebNavigationData::WebNavigationData):
10507 (WebNavigationData::createInstance):
10508 * WebNavigationData.h:
10509 Changed to take const WebCore::String&s instead of BSTRs and to
10510 convert the Strings to BStrings at this level.
10512 2009-11-30 Steve Falkenburg <sfalken@apple.com>
10514 Reviewed by Adam Roben.
10516 WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
10517 https://bugs.webkit.org/show_bug.cgi?id=31986
10520 (WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.
10522 2009-11-24 Chris Marrin <cmarrin@apple.com>
10524 Another Windows build fix
10526 Got rid of d3d.lib and d3dx9.lib dependency. Not needed until
10527 we turn on ACCELERATED_COMPOSITING
10529 * WebKit.vcproj/WebKit.vcproj:
10531 2009-11-24 Chris Marrin <cmarrin@apple.com>
10533 Fixed Windows build
10535 Got rid of QuartzCore.lib dependency. Not needed until
10536 we turn on ACCELERATED_COMPOSITING
10538 * WebKit.vcproj/WebKit.vcproj:
10540 2009-11-24 Chris Marrin <cmarrin@apple.com>
10542 Reviewed by Simon Fraser.
10544 Implement accelerated compositing
10545 https://bugs.webkit.org/show_bug.cgi?id=27314
10547 This is the WebKit side of the implementation. It plumbs the root layer
10548 from WebCore. It also makes changes to WebView which places the
10549 backing store of the page into the root compositing layer so it is
10550 properly composited with all the other layers. This deals with resizing,
10551 scrolling, and incremental repaint of the page.
10553 * WebCoreSupport/WebChromeClient.cpp:
10554 (WebChromeClient::attachRootGraphicsLayer):
10555 (WebChromeClient::scheduleCompositingLayerSync):
10556 * WebCoreSupport/WebChromeClient.h:
10557 (WebChromeClient::setNeedsOneShotDrawingSynchronization):
10558 * WebKit.vcproj/WebKit.vcproj:
10560 (WebView::WebView):
10562 (WebView::repaint):
10563 (WebView::scrollBackingStore):
10566 (WebView::setRootChildLayer):
10567 (WebView::setAcceleratedCompositing):
10568 (WebView::setRootLayerContents):
10570 (WebView::isAcceleratedCompositing):
10571 (WebView::resizeLayerWindow):
10572 (WebView::layerWindowBecameVisible):
10573 (WebView::setRootLayerNeedsDisplay):
10575 2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
10577 Reviewed by Kenneth Rohde Christiansen.
10579 Include "config.h" to meet Coding Style Guidelines
10580 https://bugs.webkit.org/show_bug.cgi?id=31792
10582 * GEN_DOMObject.cpp:
10583 * WebScriptObject.cpp:
10585 2009-11-21 Jon Honeycutt <jhoneycutt@apple.com>
10587 Windows build fix. Unreviewed.
10589 * Interfaces/IWebSerializedJSValue.idl:
10591 2009-11-20 Jon Honeycutt <jhoneycutt@apple.com>
10593 DOMElement::tagName() is unimplemented
10595 https://bugs.webkit.org/show_bug.cgi?id=31746
10597 Reviewed by Darin Adler.
10599 * DOMCoreClasses.cpp:
10600 (DOMElement::tagName):
10601 Create a BString from the element's tag name, and release its BSTR
10604 2009-11-20 Jon Honeycutt <jhoneycutt@apple.com>
10606 DOMNode::childNodes() is unimplemented
10608 https://bugs.webkit.org/show_bug.cgi?id=31745
10610 Reviewed by Darin Adler.
10612 * DOMCoreClasses.cpp:
10613 (DOMNode::childNodes):
10614 Create a DOMNodeList from the node's child nodes.
10616 2009-11-20 Dave Hyatt <hyatt@apple.com>
10618 Reviewed by Jon Honeycutt.
10620 Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
10621 serialization into a separate serialize() function that can be called after the object has been
10624 Fix a typo in serialize() caused when fixing build bustage (put a ! back in).
10626 * Interfaces/IWebSerializedJSValue.idl:
10627 * WebSerializedJSValue.cpp:
10628 (WebSerializedJSValue::WebSerializedJSValue):
10629 (WebSerializedJSValue::createInstance):
10630 (WebSerializedJSValue::serialize):
10631 (WebSerializedJSValue::deserialize):
10632 * WebSerializedJSValue.h:
10634 2009-11-20 Brian Weinstein <bweinstein@apple.com>
10636 Reviewed by Dave Hyatt.
10638 Another go at the Windows Build Fix - this is a couple steps of it,
10639 so a little more involved than most build fixes.
10641 * Interfaces/IWebSerializedJSValue.idl:
10642 * Interfaces/JavaScriptCoreAPITypes.idl:
10643 * WebKit.vcproj/Interfaces.vcproj:
10644 * WebSerializedJSValue.cpp:
10645 (WebSerializedJSValue::deserialize):
10646 * WebSerializedJSValue.h:
10648 2009-11-20 Brian Weinstein <bweinstein@apple.com>
10650 Reviewed by Dave Hyatt.
10652 Build fix for Windows - only declare JSContextRef once, instead
10653 of in two different idl files. Create a new file to hold the
10654 definition of JSContextRef.
10656 * Interfaces/IWebFrameLoadDelegate.idl:
10657 * Interfaces/IWebSerializedJSValue.idl:
10658 * Interfaces/JavaScriptCoreAPITypes.idl: Added.
10659 * Interfaces/WebKit.idl:
10660 * WebKit.vcproj/Interfaces.vcproj:
10662 2009-11-20 Dave Hyatt <hyatt@apple.com>
10664 Reviewed by Oliver Hunt and Jon Honeycutt.
10666 Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
10667 and exposes the ability to do JS value serialization/deserialization to WebKit clients.
10669 * Interfaces/IWebSerializedJSValue.idl: Added.
10670 * Interfaces/WebKit.idl:
10671 * WebKit.vcproj/WebKit.vcproj:
10672 * WebSerializedJSValue.cpp: Added.
10673 (WebSerializedJSValue::WebSerializedJSValue):
10674 (WebSerializedJSValue::~WebSerializedJSValue):
10675 (WebSerializedJSValue::createInstance):
10676 (WebSerializedJSValue::AddRef):
10677 (WebSerializedJSValue::Release):
10678 (WebSerializedJSValue::QueryInterface):
10679 (WebSerializedJSValue::deserialize):
10680 * WebSerializedJSValue.h: Added.
10682 2009-11-19 Alexey Proskuryakov <ap@apple.com>
10684 Reviewed by Darin Adler.
10686 https://bugs.webkit.org/show_bug.cgi?id=31690
10687 Make SocketStreamHandleCFNet work on Windows
10689 * WebDownloadCFNet.cpp:
10690 (WebDownload::init):
10691 (WebDownload::initWithRequest):
10692 (WebDownload::initToResumeWithBundle):
10693 Update for loaderRunLoop() now being in its own header.
10695 2009-11-19 Eric Carlson <eric.carlson@apple.com>
10697 Reviewed by Dan Bernstein.
10699 <rdar://problem/7035231>
10700 Support closed caption in <video> element
10702 * WebCoreLocalizedStrings.cpp:
10703 (WebCore::localizedMediaControlElementString):
10704 (WebCore::localizedMediaControlElementHelpText):
10705 Add accessibility help strings for media controller closed caption button.
10707 2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
10709 Reviewed by Darin Adler.
10711 Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
10712 Support for validationMessage attribute, as per HTML5 specs.
10714 * WebCoreLocalizedStrings.cpp:
10715 (WebCore::validationMessageValueMissingText):
10716 (WebCore::validationMessageTypeMismatchText):
10717 (WebCore::validationMessagePatternMismatchText):
10718 (WebCore::validationMessageTooLongText):
10719 (WebCore::validationMessageRangeUnderflowText):
10720 (WebCore::validationMessageRangeOverflowText):
10721 (WebCore::validationMessageStepMismatchText):
10723 2009-11-18 Daniel Bates <dbates@webkit.org>
10725 Reviewed by Darin Adler.
10727 https://bugs.webkit.org/show_bug.cgi?id=31186
10729 Changes associated with renaming RenderTextControl::isUserEdited.
10731 * DOMHTMLClasses.cpp:
10732 (DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited.
10733 (DOMHTMLTextAreaElement::isUserEdited): Ditto.
10735 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
10737 Implement DOMHTMLInputElement::replaceCharactersInRange().
10739 https://bugs.webkit.org/show_bug.cgi?id=31492
10741 Reviewed by Dan Bernstein.
10743 * DOMHTMLClasses.cpp:
10744 (DOMHTMLInputElement::replaceCharactersInRange):
10745 Get the text of the input field. Replace the given range with the
10746 replacement text, and set this new string as the input element's value.
10747 Select from index to the end of the field. This matches the
10748 implementation in the Obj-C bindings.
10750 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
10752 DOMHTMLOptionElement is missing some functionality.
10754 https://bugs.webkit.org/show_bug.cgi?id=31491
10756 Reviewed by Dan Bernstein.
10758 * DOMHTMLClasses.cpp:
10759 (DOMHTMLOptionElement::text):
10760 Cast m_element to an HTMLOptionElement, and call its text() function.
10761 (DOMHTMLOptionElement::label):
10762 Ditto, for label().
10764 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
10766 DOMHTMLSelectElement is missing some implementation.
10768 https://bugs.webkit.org/show_bug.cgi?id=31489
10770 Reviewed by Dan Bernstein.
10772 * DOMHTMLClasses.cpp:
10773 (DOMHTMLSelectElement::options):
10774 Cast m_element to an HTMLSelectElement. If it has no options, return
10775 E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the
10776 options, and return it.
10777 (DOMHTMLSelectElement::activateItemAtIndex):
10778 If the index is out of bounds, return E_FAIL. Otherwise, select the
10781 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
10783 DOMHTMLOptionsCollection is missing some implementation.
10785 https://bugs.webkit.org/show_bug.cgi?id=31488
10787 Reviewed by Dan Bernstein.
10789 * DOMHTMLClasses.cpp:
10790 (DOMHTMLOptionsCollection::DOMHTMLOptionsCollection):
10791 Initialize m_collection.
10792 (DOMHTMLOptionsCollection::createInstance):
10793 Create a DOMHTMLOptionsCollection. If we fail to query for
10794 IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return
10796 (DOMHTMLOptionsCollection::length):
10797 (DOMHTMLOptionsCollection::item):
10798 Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL.
10799 (DOMHTMLOptionsCollection::namedItem):
10800 Correct the signature of this function.
10802 * DOMHTMLClasses.h:
10803 Declare DOMHTMLOptionsCollection::createInstance(). Correct the
10804 signature of namedItem() to match IDOMHTMLOptionsCollection. Add a
10805 member to DOMHTMLOptionsCollection to hold the WebCore object.
10807 2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
10809 DOMHTMLInputElement::rectOnScreen() returns the wrong rect
10811 https://bugs.webkit.org/show_bug.cgi?id=31487
10813 Reviewed by Darin Adler.
10815 * DOMHTMLClasses.cpp:
10816 (DOMHTMLInputElement::rectOnScreen):
10817 Return the rect on screen, not the rect in the window.
10819 2009-11-17 Brent Fulgham <bfulgham@webkit.org>
10821 Reviewed by NOBODY - Build Fix.
10823 Correct build error in Debug_Cairo target after @49705.
10825 * WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib
10826 dependency to have proper "_debug" suffix needed by
10827 the Debug_Cairo target.
10829 2009-11-17 Brian Weinstein <bweinstein@apple.com>
10831 Reviewed by NOBODY - Build Fix.
10833 Touch files to try to fix the build.
10835 * Interfaces/IWebInspector.idl:
10836 * Interfaces/WebKit.idl:
10837 * WebKit.vcproj/Interfaces.vcproj:
10839 2009-11-17 Pavel Feldman <pfeldman@chromium.org>
10841 Reviewed by Timothy Hatcher.
10843 Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
10844 - Updated DRT to show/close inspector for all tests under /inspector
10845 - Introduced LayoutTestController::setTimelineProfilingEnabled and
10846 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
10847 - Removed reload on each inspector test
10848 - Renamed fast/inspector to fast/inspector-support in order not to trigger
10849 inspector for those.
10850 - Reimplemented timeline tests in order to get rid of reload there.
10851 - Moved tests that don't require harness into the fast group.
10853 https://bugs.webkit.org/show_bug.cgi?id=31472
10855 * Interfaces/IWebInspector.idl:
10856 * WebInspector.cpp:
10857 (WebInspector::isTimelineProfilingEnabled):
10858 (WebInspector::setTimelineProfilingEnabled):
10861 2009-11-13 Adam Roben <aroben@apple.com>
10865 * Interfaces/WebKit.idl: Touch this to force interfaces to rebuild.
10867 2009-11-13 Adam Roben <aroben@apple.com>
10869 Tell the WebFrameLoadDelegate when window objects in isolated worlds
10872 Fixes <http://webkit.org/b/31124>.
10874 Reviewed by Dave Hyatt.
10876 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added
10877 didClearWindowObjectForFrameInScriptWorld.
10880 (WebFrame::dispatchDidClearWindowObjectInWorld):
10882 Replaced windowObjectCleared with this function. If the delegate
10883 implements IWebFrameLoadDelegatePrivate2, call
10884 didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in
10885 world is the mainThreadNormalWorld(), call
10886 didClearWindowObjectForFrame.
10888 * WebScriptWorld.cpp:
10889 (allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
10891 (WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds().
10892 (WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds().
10893 (WebScriptWorld::standardWorld): Added this non-COM getter for the
10894 standard world, which the COM getter now calls through to.
10895 (WebScriptWorld::findOrCreateWorld): Added. Returns the existing
10896 WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
10899 * WebScriptWorld.h: Added new standardWorld overload, made one
10900 overload of createInstance private, and added findOrCreateWorld.
10902 2009-11-13 Adam Roben <aroben@apple.com>
10906 * Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they
10907 are order-dependent!
10909 2009-11-13 Adam Roben <aroben@apple.com>
10911 Touch WebKit.idl to fix the Windows build
10913 * Interfaces/WebKit.idl: Sorted #includes.
10915 2009-11-13 Adam Roben <aroben@apple.com>
10917 Finish replacing worldIDs with world objects
10919 The only remaining use of worldIDs was in a method only used by DRT
10920 for the isolated worlds tests.
10922 Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
10924 Reviewed by Mark Rowe.
10926 * Interfaces/IWebFramePrivate.idl:
10928 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
10930 Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an
10931 IWebScriptWorld instead of a worldID, so we don't need to maintain a
10932 map of worldID -> world anymore.
10934 2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
10936 Reviewed by Darin Adler.
10938 externalRepresentation should take Frame as the argument
10939 https://bugs.webkit.org/show_bug.cgi?id=31393
10941 No new tests as this is just a refactoring.
10944 (WebFrame::renderTreeAsExternalRepresentation):
10946 2009-11-12 Adam Roben <aroben@apple.com>
10948 Replace worldIDs with world objects
10950 WebScriptWorld is the new object that represents a world. The only
10951 place worldID is still used is in
10952 IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but
10953 that will change soon.
10955 Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
10956 user scripts/stylesheets and isolated worlds
10958 Reviewed by Sam Weinig.
10960 * ForEachCoClass.h: Added WebScriptWorld.
10962 * Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with
10965 * Interfaces/IWebScriptWorld.idl: Added.
10967 * Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet
10968 functions to take an IWebScriptWorld instead of a worldID.
10970 * Interfaces/WebKit.idl: Added WebScriptWorld.
10973 (WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes
10974 an IWebScriptWorld.
10975 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the
10976 bizarre world caching/creation logic that DRT depends on here from the
10977 findWorld function in ScriptController.cpp. Updated to use
10978 ScriptController::executeScriptInWorld instead of
10979 ScriptController::executeScriptInIsolatedWorld.
10981 * WebFrame.h: Replaced contextForWorldID with contextForWorld.
10983 * WebScriptWorld.cpp: Added.
10984 (WebScriptWorld::WebScriptWorld):
10985 (WebScriptWorld::~WebScriptWorld):
10986 (WebScriptWorld::createInstance):
10987 (WebScriptWorld::AddRef):
10988 (WebScriptWorld::Release):
10989 (WebScriptWorld::QueryInterface):
10990 Standard COM class implementations.
10992 (WebScriptWorld::standardWorld): Returns a shared instance that represents
10993 WebCore's mainThreadNormalWorld().
10995 * WebScriptWorld.h: Added.
10996 (WebScriptWorld::world): Simple getter.
10998 * WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl.
11000 * WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld.
11002 * WebKitClassFactory.cpp: Added WebScriptWorld.
11005 (WebView::addUserScriptToGroup):
11006 (WebView::addUserStyleSheetToGroup):
11007 (WebView::removeUserScriptFromGroup):
11008 (WebView::removeUserStyleSheetFromGroup):
11009 (WebView::removeUserScriptsFromGroup):
11010 (WebView::removeUserStyleSheetsFromGroup):
11012 Changed these functions to take an IWebScriptWorld instead of a worldID.
11014 2009-11-12 Adam Roben <aroben@apple.com>
11016 Small clean-up in WebView's user content functions
11018 Preparation for <http://webkit.org/b/31414> Implement new SPI for
11019 dealing with user scripts/stylesheets and isolated worlds
11021 Reviewed by Dave Hyatt.
11026 Added these helper functions to convert BSTRs to WebCore types.
11029 (WebView::addUserScriptToGroup):
11030 (WebView::addUserStyleSheetToGroup):
11031 (WebView::removeUserScriptFromGroup):
11032 (WebView::removeUserStyleSheetFromGroup):
11033 (WebView::removeUserScriptsFromGroup):
11034 (WebView::removeUserStyleSheetsFromGroup):
11035 (WebView::removeAllUserContentFromGroup):
11036 Use the new helper functions.
11038 2009-11-11 Beth Dakin <bdakin@apple.com>
11040 Build fix. No review needed.
11042 * WebKitGraphics.cpp:
11045 2009-11-10 Daniel Bates <dbates@webkit.org>
11047 Reviewed by Oliver Hunt.
11049 https://bugs.webkit.org/show_bug.cgi?id=30754
11051 Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo.
11053 * WebDropSource.cpp:
11054 (WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo.
11056 2009-11-10 Alexey Proskuryakov <ap@apple.com>
11058 Reviewed by Dan Bernstein.
11060 https://bugs.webkit.org/show_bug.cgi?id=31312
11061 Decouple authentication panel callbacks from ResourceHandle
11063 * WebCoreSupport/WebFrameLoaderClient.cpp:
11064 (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
11065 * WebURLAuthenticationChallenge.cpp:
11066 (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
11067 (WebURLAuthenticationChallenge::sender):
11068 * WebURLAuthenticationChallengeSender.cpp:
11069 (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
11070 (WebURLAuthenticationChallengeSender::createInstance):
11071 (WebURLAuthenticationChallengeSender::authenticationClient):
11072 * WebURLAuthenticationChallengeSender.h:
11073 * WebURLAuthenticationChallengeSenderCFNet.cpp:
11074 (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
11075 (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
11076 (WebURLAuthenticationChallengeSender::useCredential):
11077 Adjusted for WebCore changes.
11079 2009-11-10 Brian Weinstein <bweinstein@apple.com>
11081 Reviewed by NOBODY - Build Fix.
11083 Updated fillRoundedRect to take a ColorSpace argument.
11085 * WebCoreSupport/WebDragClient.cpp:
11086 (WebDragClient::createDragImageForLink):
11088 2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>
11090 Reviewed by Holger Freyther.
11092 ResourceRequest to be class instead of struct
11093 https://bugs.webkit.org/show_bug.cgi?id=30670
11095 Started as a compilation fix for Symbian where the compiler makes a distinction between
11096 class and struct in function argument signatures.
11097 Changed forward declaration of ResourceRequest to have class in the forward
11098 declaration instead of struct.
11102 2009-11-05 Adam Roben <aroben@apple.com>
11104 Make CFDictionaryPropertyBag::createInstance return a COMPtr
11106 I also cleaned up CFDictionaryPropertyBag's class declaration a little
11109 Part of <http://webkit.org/b/25294> <rdar://problem/6803127> All
11110 WebKit/win classes should return COMPtrs from their static constructor
11113 Reviewed by Steve Falkenburg.
11115 * CFDictionaryPropertyBag.cpp:
11116 (CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to
11117 initialize m_refCount to 0. m_refCount gets increased to 1 by
11119 (CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr.
11121 * CFDictionaryPropertyBag.h:
11122 - Updated copyright years
11123 - Fixed header guard to match current style
11124 - Replaced #include of CoreFoundation.h with forward-declaration of
11125 CFMutableDictionaryRef
11126 - Added #include of COMPtr.h
11127 - Fixed opening brace placement in class declaration
11128 - Made createInstance return a COMPtr
11129 - Made constructor/destructor private
11130 - Made QueryInterface and IPropertyBag functions private
11131 - Removed unnecessary parameter names and MIDL comments
11134 (WebCache::statistics): Updated for change to
11135 CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place
11136 the IPropertyBag pointers into the s array.
11138 * WebCoreSupport/WebFrameLoaderClient.cpp:
11139 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
11140 * WebDatabaseManager.cpp:
11141 (WebDatabaseManager::dispatchDidModifyDatabase):
11143 (WebFrame::createJavaAppletWidget):
11144 Updated for change to CFDictionaryPropertyBag::createInstance.
11146 * WebHistory.cpp: Removed releaseUserInfo, which is no longer needed.
11147 That function was also doing an unnecessary call to setDictionary(0).
11148 (createUserInfoFromArray):
11149 (createUserInfoFromHistoryItem):
11150 Changed to return COMPtr.
11152 (WebHistory::loadFromURL): Updated for change to
11153 CFDictionaryPropertyBag::createInstance.
11155 (WebHistory::removeAllItems): Updated for change to
11156 CFDictionaryPropertyBag::createInstance, which fixed a leak! We had
11157 forgotten to call releaseUserInfo here.
11159 (WebHistory::removeItem):
11160 (WebHistory::addItem):
11161 (WebHistory::visitedURL):
11162 * WebIconDatabase.cpp:
11163 (postDidAddIconNotification):
11164 Updated for change to CFDictionaryPropertyBag::createInstance.
11166 * WebKitClassFactory.cpp:
11167 (releaseRefFromCreateInstance): Added this overloaded function
11168 template to abstract away the difference between createInstance
11169 functions that return a ref'd pointer and createInstance functions
11170 that return a COMPtr.
11171 (WebKitClassFactory::CreateInstance): Changed to use
11172 releaseRefFromCreateInstance.
11174 2009-11-03 Brian Weinstein <bweinstein@apple.com>
11176 Reviewed by Steve Falkenburg.
11178 WebActionModifierFlagsKey should return an unsigned, because
11179 flags imply a bitmask, and that is what other classes expect from
11182 * WebActionPropertyBag.cpp:
11183 (WebActionPropertyBag::Read):
11185 2009-11-02 Eric Carlson <eric.carlson@apple.com>
11187 Reviewed by John Sullivan and Mark Rowe.
11189 <rdar://problem/7356733> Voiceover does not read correct media controller time values
11191 * WebCoreLocalizedStrings.cpp:
11192 (WebCore::localizedMediaTimeDescription):
11194 2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
11196 MSAA: Accessibility of headings is not correct
11198 https://bugs.webkit.org/show_bug.cgi?id=30937
11200 Reviewed by Alice Liu.
11202 * AccessibleBase.cpp:
11203 (AccessibleBase::get_accDescription):
11204 Call the object's descriptionForMSAA(). Moved the comment to the
11206 (AccessibleBase::get_accRole):
11207 If the object has a string role, return that. Otherwise, return the
11210 * AccessibleBase.h:
11211 Removed description(), as this was moved to WebCore.
11213 2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
11215 MSAA: Accessibility of links is wrong
11217 https://bugs.webkit.org/show_bug.cgi?id=30928
11219 Reviewed by Darin Adler.
11221 * AccessibleBase.cpp:
11222 (AccessibleBase::get_accState):
11223 Check whether the element is linked, instead of whether the node is an
11224 anchor, so the child "linkable" elements of anchor elements will also
11226 (AccessibleBase::name):
11227 Return the name for MSAA.
11228 (AccessibleBase::value):
11229 Return the string value for MSAA.
11231 2009-10-30 Evan Stade <estade@chromium.org>
11233 Reviewed by David Levin.
11235 Notify the chrome when the focused node has changed.
11236 https://bugs.webkit.org/show_bug.cgi?id=30832
11238 Added stub implementation for new ChromeClient function.
11240 * WebCoreSupport/WebChromeClient.cpp:
11241 (WebChromeClient::focusedNodeChanged):
11242 * WebCoreSupport/WebChromeClient.h:
11244 2009-10-30 Roland Steiner <rolandsteiner@chromium.org>
11246 Reviewed by Eric Seidel.
11248 Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
11250 Bug 28420 - Implement HTML5 <ruby> rendering
11251 (https://bugs.webkit.org/show_bug.cgi?id=28420)
11253 No new tests (no functional change).
11255 * WebKit.vcproj/WebKit.vcproj:
11257 2009-10-29 Mark Rowe <mrowe@apple.com>
11259 Rubber-stamped by Dan Bernstein.
11261 <http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes
11262 to IWebFramePrivate vtable ordering
11264 * Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that
11265 it doesn't affect the ordering of the vtable.
11267 2009-10-28 Steve Falkenburg <sfalken@apple.com>
11269 Reviewed by Sam "Horatio" Weinig.
11271 Should not generate/build COM DOM bindings
11272 https://bugs.webkit.org/show_bug.cgi?id=30880
11274 * Interfaces/WebKit.idl: Remove generated interfaces.
11275 * WebKit.vcproj/InterfacesGenerated.vcproj: Removed.
11276 * WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj.
11277 * WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj.
11278 * WebKit.vcproj/WebKit.vcproj: Remove generated interfaces.
11280 2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
11282 Reviewed by Darin Adler.
11284 Provide a way to get counter values with layoutTestContoller
11285 https://bugs.webkit.org/show_bug.cgi?id=30555
11287 * Interfaces/IWebFramePrivate.idl:
11289 (WebFrame::counterValueForElementById):
11292 2009-10-28 Joe Mason <jmason@rim.com>
11294 Reviewed by Adam Treat.
11296 Call the shared FrameLoader::defaultObjectContentType instead of
11297 copying code into FrameLoaderClient::objectContentType. This causes no
11298 behavioural change.
11301 (WebFrame::objectContentType):
11303 2009-10-28 Holger Hans Peter Freyther <zecke@selfish.org>
11305 Speculative build-fix for WebElementPropertyBag.cpp
11307 * WebElementPropertyBag.cpp: Include RenderObject.h
11309 2009-10-27 Holger Hans Peter Freyther <zecke@selfish.org>
11311 Reviewed by Simon Fraser.
11313 Change HitTestResult methods to use (3d) transformation aware methods
11314 https://bugs.webkit.org/show_bug.cgi?id=27347
11316 The HitTestResult::boundingBox method was removed. The
11317 RenderObject must be used directly. In contrast to the
11318 old HitTestResult::boundingBox method this code must use
11319 a (3d) transformation aware method to not run into an
11320 assert in SVGRenderBase::mapLocalToContainer.
11322 * WebElementPropertyBag.cpp:
11323 (WebElementPropertyBag::Read): Replace HitTestResult::boundingBox()
11325 2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
11327 Reviewed by Darin Adler.
11329 Make .rc files compile on Windows without depending on MFC headers
11330 https://bugs.webkit.org/show_bug.cgi?id=30750
11332 * WebKit.vcproj/WebKit.rc: Use winresrc.h because it exists even
11333 when MFC is not installed, and is all that's needed here.
11335 2009-10-26 Sam Weinig <sam@webkit.org>
11337 Rubber-stamped by Darin Adler.
11339 Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
11340 inherit from HTMLCollection.
11342 * DOMCreateInstance.cpp:
11344 2009-10-25 Dan Bernstein <mitz@apple.com>
11346 Reviewed by John Sullivan.
11348 Add contextForWorldID to the IWebFramePrivate interface.
11350 * Interfaces/IWebFramePrivate.idl:
11353 2009-10-25 Sam Weinig <sam@webkit.org>
11355 Another try at fixing windows.
11357 * DOMCreateInstance.cpp:
11359 2009-10-25 Sam Weinig <sam@webkit.org>
11361 Touch WebKit.idl in an effort to try and regenerate the COM bindings.
11363 * Interfaces/WebKit.idl:
11365 2009-10-23 Mark Rowe <mrowe@apple.com>
11367 Build fix. Include config.h before including other files.
11369 * AccessibleImage.cpp:
11371 2009-10-23 Gavin Barraclough <barraclough@apple.com>
11373 Reviewed by Geoff Garen.
11375 https://bugs.webkit.org/show_bug.cgi?id=30729
11376 Provide private API to request the global context for a specific world.
11377 Used to initialize parameters on the global object.
11380 (WebFrame::contextForWorldID):
11383 2009-10-23 Brian Weinstein <bweinstein@apple.com>
11385 Reviewed by John Sullivan.
11387 Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
11388 <http://webkit.org/b/30732> and <rdar://7332018>.
11390 Turns off pan-scrolling on a WebView when it is about to lose focus.
11395 2009-10-23 Jon Honeycutt <jhoneycutt@apple.com>
11397 MSAA: Name for image elements should use alt attribute text
11399 https://bugs.webkit.org/show_bug.cgi?id=30727
11400 <rdar://problem/7328291>
11402 Reviewed by Alice Liu.
11404 * AccessibleBase.cpp:
11405 (AccessibleBase::createInstance):
11406 If the AccessibilityObject is an image, return an AccessibleImage.
11408 * AccessibleImage.cpp: Added.
11409 (AccessibleImage::AccessibleImage):
11410 Call the base constructor.
11411 (AccessibleImage::name):
11412 If the object is not an AccessibilityRenderObject, return the base's
11413 name(). Look first for an ARIA "labeled-by" attribute, then look for an
11414 alternate text attribute. Fall back to the base's name().
11416 * AccessibleImage.h: Added.
11417 (AccessibleImage::~AccessibleImage):
11419 * WebKit.vcproj/WebKit.vcproj:
11420 Add AccessibleImage to the project.
11422 2009-10-23 Sam Weinig <sam@webkit.org>
11424 Try and fix the windows build.
11426 * Interfaces/WebKit.idl:
11428 2009-10-22 Gavin Barraclough <barraclough@apple.com>
11430 Reviewed by Sam Weinig & Geoff Garen.
11432 https://bugs.webkit.org/show_bug.cgi?id=30696
11433 Update to incorporate support for IsolatedWorlds in JSC bindings.
11435 * Interfaces/IWebFramePrivate.idl:
11437 (WebFrame::globalContext):
11438 (WebFrame::windowObjectCleared):
11439 (WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):
11442 2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
11444 Reviewed by David Levin.
11446 Removed WebSocket runtime settings.
11447 https://bugs.webkit.org/show_bug.cgi?id=29896
11449 WebSocket runtime configuration is supported by chromium/v8 only.
11451 * Interfaces/IWebPreferencesPrivate.idl:
11452 * WebPreferenceKeysPrivate.h:
11453 * WebPreferences.cpp:
11454 (WebPreferences::initializeDefaultSettings):
11455 (WebPreferences::experimentalNotificationsEnabled):
11456 * WebPreferences.h:
11458 (WebView::notifyPreferencesChanged):
11460 2009-10-19 Adam Roben <aroben@apple.com>
11462 Fix crashes/assertions when calling WebLocalizedString from multiple
11463 threads concurrently
11465 Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called
11466 from multiple threads concurrently
11468 Reviewed by John Sullivan.
11470 * WebLocalizableStrings.cpp:
11471 (mainBundleLocStringsMutex):
11472 (frameworkLocStringsMutex):
11473 Added these new getters.
11475 (findCachedString):
11477 Lock the relevant mutex before accessing each string map. Otherwise
11478 bad things could happen if two threads end up here at the same time.
11480 2009-10-19 Adam Roben <aroben@apple.com>
11482 Get rid of a few static initializers/exit-time destructors in
11483 WebLocalizableStrings
11485 Reviewed by Dan Bernstein.
11487 * WebLocalizableStrings.cpp:
11488 (mainBundleLocStrings):
11489 (frameworkLocStrings):
11490 Added these functions instead of file-scope variables.
11492 (findCachedString):
11494 Updated to use the new functions.
11496 2009-10-19 Nate Chapin <japhet@chromium.org>
11498 Unreviewed, build fix.
11500 Update call to FrameLoader::urlSelected().
11502 * WebCoreSupport/WebContextMenuClient.cpp:
11503 (WebContextMenuClient::searchWithGoogle):
11505 2009-10-16 Steve Falkenburg <sfalken@apple.com>
11507 Reviewed by Dan Bernstein.
11509 https://bugs.webkit.org/show_bug.cgi?id=30456
11510 Fixes for new Debug_All Windows build configuration.
11512 * WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.
11514 2009-10-16 Jon Honeycutt <jhoneycutt@apple.com>
11516 Add SPI to determine whether a plug-in has ever been halted.
11518 Part of <rdar://problem/7312158>.
11520 Reviewed by Dan Bernstein.
11522 * Interfaces/IWebViewPrivate.idl:
11523 Add hasPluginForNodeBeenHalted().
11526 (pluginViewForNode):
11527 Code factored out of isNodeHaltedPlugin().
11528 (WebView::isNodeHaltedPlugin):
11529 Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
11530 pluginViewForNode().
11531 (WebView::restartHaltedPluginForNode):
11533 (WebView::hasPluginForNodeBeenHalted):
11534 Get the PluginView for the given node. Return the result of
11535 PluginView::hasBeenHalted().
11538 Declare hasPluginForNodeBeenHalted().
11540 2009-10-16 Steve Falkenburg <sfalken@apple.com>
11542 Reviewed by Adam Roben.
11544 Add a Debug_All configuration to build entire stack as debug.
11545 Change Debug_Internal to:
11546 - stop using _debug suffix for all WebKit/Safari binaries
11547 - not use _debug as a DLL naming suffix
11548 - use non-debug C runtime lib.
11550 * WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
11551 * WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
11552 * WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
11553 * WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
11554 * WebKit.vcproj/WebKit.vcproj:
11555 Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
11556 Add Debug_All configuration.
11557 * WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.
11559 2009-10-15 Jon Honeycutt <jhoneycutt@apple.com>
11561 Add SPI to restart a halted plug-in.
11563 Part of <rdar://problem/7273354> Halted plug-ins should restart on
11566 https://bugs.webkit.org/show_bug.cgi?id=30151
11568 Reviewed by Kevin Decker.
11570 * Interfaces/IWebViewPrivate.idl:
11571 Add restartHaltedPluginForNode().
11574 (WebView::restartHaltedPluginForNode):
11575 From the IDOMNode, query for the DOMNode. From the DOMNode, get the
11576 WebCore::Node. Get the node's renderer, and check whether it is a
11577 RenderWidget. If so, get its Widget, and check whether it's a
11578 PluginView. If so, call PluginView::restart().
11581 Declare restartHaltedPluginForNode().
11583 2009-10-14 Jon Honeycutt <jhoneycutt@apple.com>
11585 Add SPI to determine whether a node is a halted plug-in.
11587 Part of <rdar://problem/7273354> Halted plug-ins should restart on
11590 https://bugs.webkit.org/show_bug.cgi?id=30151
11592 Reviewed by Darin Adler.
11594 * Interfaces/IWebViewPrivate.idl:
11595 Add isNodehaltedPlugin().
11598 (WebView::isNodeHaltedPlugin):
11599 From the IDOMNode, query for the DOMNode. From the DOMNode, get the
11600 WebCore::Node. Get the node's renderer, and check whether it is a
11601 RenderWidget. If so, get its Widget, and check whether it's a
11602 PluginView. If so, return the result of PluginView::isHalted().
11605 Declare isNodeHaltedPlugin().
11607 2009-10-15 Daniel Bates <dbates@webkit.org>
11609 Reviewed by Adam Roben.
11611 https://bugs.webkit.org/show_bug.cgi?id=24731
11613 rdar://problem/5015961
11615 Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend)
11616 in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is
11619 The WebView and WebDropSource drag-and-drop functions, as called by function
11620 DoDragDrop in its event loop, neither used the drop effect as specified by
11621 event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed.
11622 Instead, these functions defaulted to some hardcoded drop effect and set of
11623 allowed drop effects, respectively.
11625 Tests: fast/events/drag-and-drop.html
11627 * WebCoreSupport/WebDragClient.cpp:
11628 (WebDragClient::startDrag):
11629 * WebDropSource.cpp:
11630 (WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt
11631 into method WebDragClient::startDrag.
11634 (WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines
11635 appropriate drop effect from state of keyboard and allowed effects
11636 m_page->dragController()->sourceDragOperation().
11637 (WebView::DragEnter):
11638 (WebView::DragOver):
11642 2009-10-14 Adam Roben <aroben@apple.com>
11646 * WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
11647 IWebNavigationData from the build (they get #imported via WebKit.idl).
11649 2009-10-14 Brady Eidson <beidson@apple.com>
11651 Reviewed by Sam Weinig.
11653 WebKit Win API should provide a delegate interface for global history.
11654 https://bugs.webkit.org/show_bug.cgi?id=29905
11656 -Add IWebHistoryDelegate for clients to implement.
11657 -Add (I)WebNavigationData for the history delegate's use.
11658 -When it exists, call the history delegate instead of using WebHistory.
11660 * Interfaces/IWebHistoryDelegate.idl: Added.
11661 * Interfaces/IWebHistoryPrivate.idl:
11662 * Interfaces/IWebNavigationData.idl: Added.
11663 * Interfaces/IWebViewPrivate.idl:
11664 * Interfaces/WebKit.idl:
11666 * WebKit.vcproj/Interfaces.vcproj:
11667 * WebKit.vcproj/WebKit.vcproj:
11669 * WebCoreSupport/WebChromeClient.cpp:
11670 (WebChromeClient::populateVisitedLinks):
11671 * WebCoreSupport/WebFrameLoaderClient.cpp:
11672 (WebFrameLoaderClient::updateGlobalHistory):
11673 (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
11674 (WebFrameLoaderClient::setTitle):
11678 (WebView::mainFrameURL):
11679 (WebView::setHistoryDelegate):
11680 (WebView::historyDelegate):
11681 (WebView::addVisitedLinks):
11685 (WebHistory::setVisitedLinkTrackingEnabled):
11686 (WebHistory::removeAllVisitedLinks):
11689 * WebNavigationData.cpp: Added.
11690 (WebNavigationData::QueryInterface):
11691 (WebNavigationData::AddRef):
11692 (WebNavigationData::Release):
11693 (WebNavigationData::WebNavigationData):
11694 (WebNavigationData::~WebNavigationData):
11695 (WebNavigationData::createInstance):
11696 (WebNavigationData::url):
11697 (WebNavigationData::title):
11698 (WebNavigationData::originalRequest):
11699 (WebNavigationData::response):
11700 (WebNavigationData::hasSubstituteData):
11701 (WebNavigationData::clientRedirectSource):
11702 * WebNavigationData.h: Added.
11704 2009-10-13 Dave Hyatt <hyatt@apple.com>
11706 Fix more WebView bustage.
11709 (WebView::addUserScriptToGroup):
11710 (WebView::addUserStyleSheetToGroup):
11711 (WebView::removeUserScriptsFromGroup):
11712 (WebView::removeUserStyleSheetsFromGroup):
11714 2009-10-13 Dave Hyatt <hyatt@apple.com>
11716 Fix build bustage on Windows.
11719 (WebView::addUserScriptToGroup):
11720 (WebView::addUserStyleSheetToGroup):
11721 (WebView::removeUserScriptsFromGroup):
11722 (WebView::removeUserStyleSheetsFromGroup):
11724 2009-10-13 Dave Hyatt <hyatt@apple.com>
11726 Reviewed by Adam Roben..
11728 Split removal functions for user scripts and stylehseets based on type.
11730 * Interfaces/IWebViewPrivate.idl:
11732 (WebView::removeUserScriptFromGroup):
11733 (WebView::removeUserStyleSheetFromGroup):
11736 2009-10-09 Adam Barth <abarth@webkit.org>
11738 Reviewed by Darin Adler.
11740 Factor HistoryController out of FrameLoader
11741 https://bugs.webkit.org/show_bug.cgi?id=30246
11746 (WebView::loadBackForwardListFromOtherView):
11748 2009-10-08 Jon Honeycutt <jhoneycutt@apple.com>
11750 Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking
11751 for the existence of a PluginHalterDelegate.
11753 Reviewed by Dan Bernstein.
11755 * Interfaces/IWebPreferencesPrivate.idl:
11756 Remove the getter and setter.
11758 * WebCoreSupport/WebPluginHalterClient.cpp:
11759 (WebPluginHalterClient::enabled):
11760 Return true if the delegate exists.
11762 * WebCoreSupport/WebPluginHalterClient.h:
11763 Declare implementation of enabled().
11765 * WebPreferenceKeysPrivate.h:
11766 Removed the pref key.
11768 * WebPreferences.cpp:
11769 (WebPreferences::initializeDefaultSettings):
11770 Removed initialization of the pref.
11772 * WebPreferences.h:
11773 Removed declaration of the getter/setter.
11776 (WebView::notifyPreferencesChanged):
11777 Don't propagate the pref.
11779 2009-10-08 Adam Barth <abarth@webkit.org>
11781 Reviewed by Eric Seidel.
11783 Move executeScript from FrameLoader to ScriptController
11784 https://bugs.webkit.org/show_bug.cgi?id=30200
11789 (WebView::stringByEvaluatingJavaScriptFromString):
11791 2009-10-08 Anders Carlsson <andersca@apple.com>
11793 Reviewed by Sam Weinig.
11795 Remove the shouldLoadMediaElementURL implementation.
11797 * Interfaces/IWebPolicyDelegatePrivate.idl:
11798 * WebCoreSupport/WebFrameLoaderClient.cpp:
11799 (WebFrameLoaderClient::shouldUsePluginDocument):
11800 * WebCoreSupport/WebFrameLoaderClient.h:
11802 2009-10-08 Adam Roben <aroben@apple.com>
11804 Make IWebInspectorPrivate be accessed in a more standard way
11806 IWebViewPrivate::inspectorPrivate has been removed. Callers should
11807 instead use IWebViewPrivate::inspector and then use QueryInterface to
11808 get the IWebInspectorPrivate interface. This matches how our other COM
11811 Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
11812 accessed in a more standard way
11814 Reviewed by John Sullivan and Tim Hatcher.
11816 * Interfaces/IWebViewPrivate.idl: Removed inspectorPrivate.
11818 * WebInspector.cpp:
11819 (WebInspector::QueryInterface): Support querying to
11820 IWebInspectorPrivate.
11824 Removed inspectorPrivate.
11826 2009-10-08 Adam Roben <aroben@apple.com>
11828 Move the new IWebViewPrivate::inspectorPrivate function after all
11829 functions that existed when Safari 4.0.3 was released
11831 Fixes <http://webkit.org/b/30085> REGRESSION (r49091): run-safari
11832 crashes in Safari.dll
11834 Reviewed by John Sullivan.
11836 * Interfaces/IWebViewPrivate.idl: Moved inspectorPrivate to the end of
11837 the interface, so it won't modify the vtable that Safari 4.0.3 sees.
11839 2009-10-07 Adam Roben <aroben@apple.com>
11841 Expose origin whitelisting in the WebKit API on Windows
11843 Fixes <http://webkit.org/b/30185>.
11845 Reviewed by Eric Seidel.
11847 * Interfaces/IWebViewPrivate.idl: Added whiteListAccessFromOrigin and
11848 resetOriginAccessWhiteLists, to match the Mac SPI.
11851 (WebView::whiteListAccessFromOrigin):
11852 (WebView::resetOriginAccessWhiteLists):
11854 Added. These just call through to SecurityOrigin.
11856 2009-10-07 Adam Barth <abarth@webkit.org>
11858 Reviewed by Darin Adler.
11860 Factor PolicyChecker out of FrameLoader
11861 https://bugs.webkit.org/show_bug.cgi?id=30155
11863 Move the policy callback to the policy object.
11866 (WebFrame::dispatchWillSubmitForm):
11867 (WebFrame::receivedPolicyDecision):
11868 (WebFrame::dispatchDecidePolicyForMIMEType):
11869 (WebFrame::dispatchDecidePolicyForNewWindowAction):
11870 (WebFrame::dispatchDecidePolicyForNavigationAction):
11872 2009-10-07 Daniel Bates <dbates@webkit.org>
11874 Reviewed by Darin Adler.
11876 https://bugs.webkit.org/show_bug.cgi?id=30102
11878 <rdar://problem/5015957>
11880 Fixes an issue (in the Windows build) where the cursor does not change to the
11881 not-allowed cursor when the drag-and-drop operation is not allowed.
11883 The allowed effects in WebDragClient::startDrag are hard-coded to be
11884 DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of
11885 allowed drop effects should be determined by the allowed operations of the
11888 We cannot test this using DRT because DRT looks at the programmatic drop
11889 cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
11890 That is, there is a discrepancy in the Windows build between the Windows API-based
11891 drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer
11892 to determine the cursor, a manual test is needed.
11894 * WebCoreSupport/WebDragClient.cpp:
11895 (draggingSourceOperationMaskToDragCursors): Added method.
11896 (WebDragClient::startDrag):
11898 2009-10-07 Steve Falkenburg <sfalken@apple.com>
11900 Reviewed by Darin Adler.
11902 https://bugs.webkit.org/show_bug.cgi?id=30176
11903 <rdar://problem/7281553> Extra information in UA causes problems with gmail
11905 * WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.
11907 2009-10-06 Pavel Feldman <pfeldman@chromium.org>
11909 Reviewed by Timothy Hatcher.
11911 Web Inspector: default to an attached inspector window on Windows (as on Mac).
11913 https://bugs.webkit.org/show_bug.cgi?id=30134
11915 * WebCoreSupport/WebInspectorClient.cpp:
11916 (WebInspectorClient::showWindowWithoutNotifications):
11918 2009-10-06 Adam Barth <abarth@webkit.org>
11920 Reviewed by Eric Seidel.
11922 Move FrameLoader::canLoad to SecurityOrigin
11923 https://bugs.webkit.org/show_bug.cgi?id=30111
11926 (WebFrame::allowsFollowingLink):
11928 2009-10-06 Pavel Feldman <pfeldman@chromium.org>
11930 Reviewed by Timothy Hatcher.
11932 Web Inspector: close inspector client view on
11933 InspectorController::close API call.
11935 In order to run batch web inspector layout tests (and not affect
11936 subsequent tests) we should close inspector client's view upon
11937 InspectorController::close API call.
11939 https://bugs.webkit.org/show_bug.cgi?id=30009
11941 * WebCoreSupport/WebInspectorClient.cpp:
11942 (WebInspectorClient::createPage):
11944 2009-10-06 David Levin <levin@chromium.org>
11946 Reviewed by NOBODY (windows build fix).
11948 Speculative build fix for windows (due to r49160).
11950 * WebDownloadCFNet.cpp:
11951 (WebDownload::initToResumeWithBundle):
11952 * WebIconDatabase.cpp:
11953 (WebIconDatabase::dispatchDidAddIconForPageURL):
11955 2009-10-05 Pavel Feldman <pfeldman@chromium.org>
11957 Reviewed by Timothy Hatcher.
11959 Web Inspector: add testing harness for Web Inspector.
11961 https://bugs.webkit.org/show_bug.cgi?id=30010
11963 * Interfaces/IWebInspectorPrivate.idl: Added.
11964 * Interfaces/IWebViewPrivate.idl:
11965 * Interfaces/WebKit.idl:
11966 * WebInspector.cpp:
11967 (WebInspector::evaluateInFrontend):
11970 (WebView::inspectorPrivate):
11973 2009-10-02 Dave Hyatt <hyatt@apple.com>
11975 Reviewed by Adam Roben.
11977 Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.
11979 * Interfaces/IWebViewPrivate.idl:
11982 (WebView::addUserScriptToGroup):
11983 (WebView::addUserStyleSheetToGroup):
11986 2009-10-02 Steve Falkenburg <sfalken@apple.com>
11988 Reviewed by Mark Rowe.
11990 <https://bugs.webkit.org/show_bug.cgi?id=29989>
11991 Safari version number shouldn't be exposed in WebKit code
11993 For a WebKit version of 532.3.4:
11994 Product version is: 5.32.3.4 (was 4.0.3.0)
11995 File version is: 5.32.3.4 (was 4.532.3.4)
11997 * WebKit.vcproj/WebKit.rc:
11999 2009-09-30 Sam Weinig <sam@webkit.org>
12001 Reviewed by Dan Bernstein.
12003 Fix for <rdar://problem/7259706>
12004 Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window
12006 * Interfaces/IWebFramePrivate.idl:
12008 (WebFrame::allowsFollowingLink):
12011 2009-09-30 Dave Hyatt <hyatt@apple.com>
12013 Reviewed by Adam Roben.
12015 Add the ability to remove user stylesheets and scripts by URL.
12017 * Interfaces/IWebViewPrivate.idl:
12019 (WebView::removeUserContentWithURLFromGroup):
12022 2009-09-29 Kenneth Russell <kbr@google.com>
12024 Reviewed by Dimitri Glazkov.
12026 Add support for run-time flag for 3D canvas
12027 https://bugs.webkit.org/show_bug.cgi?id=29826
12030 (WebView::notifyPreferencesChanged): Enable experimental WebGL
12031 flag when 3D_CANVAS is enabled in the build.
12033 2009-09-28 Alexey Proskuryakov <ap@apple.com>
12035 Reviewed by Darin Adler and Sam Weinig.
12037 Onclick not fired for an element copied with cloneContents() or cloneNode()
12038 https://bugs.webkit.org/show_bug.cgi?id=25130
12040 * DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.
12042 * WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.
12044 2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
12046 Reviewed by Eric Seidel.
12048 Add experimentalWebSocketsEnabled in WebPreferences.
12049 https://bugs.webkit.org/show_bug.cgi?id=28941
12051 * Interfaces/IWebPreferencesPrivate.idl:
12052 * WebPreferenceKeysPrivate.h:
12053 * WebPreferences.cpp:
12054 (WebPreferences::initializeDefaultSettings):
12055 (WebPreferences::setExperimentalWebSocketsEnabled):
12056 (WebPreferences::experimentalWebSocketsEnabled):
12057 * WebPreferences.h:
12059 (WebView::notifyPreferencesChanged):
12062 2009-09-25 Darin Adler <darin@apple.com>
12064 Reviewed by Steve Falkenburg.
12066 Speed up access to history items by caching date computation.
12068 * History/WebHistory.mm:
12069 (getDayBoundaries): Refactored from timeIntervalForBeginningOfDay.
12070 Returns the beginning of the day that the passed time is within and
12071 the beginning of the next day.
12072 (beginningOfDay): Added. Uses getDayBoundaries so it can be fast for
12073 multiple dates within the same day, which is the common case.
12074 (dateKey): Added. Calls beginningOfDay and converts to an integer.
12075 (WebHistory::findKey): Changed to call dateKey instead of
12076 timeIntervalForBeginningOfDay.
12078 2009-09-25 Adam Roben <aroben@apple.com>
12080 Add SPI to invalidate a WebView's backing store
12082 This is useful in conjunction with
12083 IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI
12084 delegate to force WebView to get its background redrawn.
12086 Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's
12089 Reviewed by Anders Carlsson.
12091 * Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore.
12093 (WebView::invalidateBackingStore): If rect is 0, invalidate our whole
12094 client rect. Otherwise invalidate the intersection of rect with our
12098 2009-09-24 Jon Honeycutt <jhoneycutt@apple.com>
12100 Add a mechanism for automatically halting plug-ins.
12102 Reviewed by Oliver Hunt.
12104 * Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface
12105 for a delegate that determines whether plug-ins should be halted.
12107 * Interfaces/IWebPreferencesPrivate.idl:
12108 Declare functions to get and set the enabled state of the plug-in
12109 halter and the plug-in allowed run time.
12111 * Interfaces/IWebViewPrivate.idl:
12112 Declare functions to get and set the IWebPluginHalterDelegate.
12114 * Interfaces/WebKit.idl:
12116 * WebCoreSupport/WebPluginHalterClient.cpp: Added.
12117 (WebPluginHalterClient::WebPluginHalterClient):
12118 (WebPluginHalterClient::shouldHaltPlugin):
12119 Get the IWebPluginHalterDelegate for the WebView. Create a WebKit
12120 DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin().
12121 If the call fails, return false. Otherwise, return the result of the
12124 * WebCoreSupport/WebPluginHalterClient.h: Added.
12126 * WebKit.vcproj/Interfaces.vcproj:
12127 Add IWebPluginHalterDelegate.idl.
12129 * WebKit.vcproj/WebKit.vcproj:
12130 Add WebPluginHalterClient.{h,cpp}.
12132 * WebPreferenceKeysPrivate.h:
12133 Define WebKitPluginHalterEnabledPreferenceKey and
12134 WebKitPluginAllowedRunTimePreferenceKey.
12136 * WebPreferences.cpp:
12137 (WebPreferences::initializeDefaultSettings):
12138 Leave plug-in halting disabled by default. Set the default value for
12139 the plug-in allowed run time to the max value of an unsigned int.
12140 (WebPreferences::setPluginHalterEnabled):
12141 (WebPreferences::pluginHalterEnabled):
12142 (WebPreferences::setPluginAllowedRunTime):
12143 (WebPreferences::pluginAllowedRunTime):
12145 * WebPreferences.h:
12149 Clear the IWebPluginHalterDelegate.
12150 (WebView::initWithFrame):
12151 Pass a WebPluginHalterClient when creating the Page.
12152 (WebView::notifyPreferencesChanged):
12153 Set the new settings when the preferences changed notification is
12155 (WebView::setPluginHalterDelegate):
12156 (WebView::pluginHalterDelegate):
12159 Declare overrides of setPluginHalterDelegate() and
12160 pluginHalterDelegate(). Added a member to track the
12161 IWebPluginHalterDelegate.
12163 2009-09-14 John Gregg <johnnyg@google.com>
12165 Reviewed by Eric Seidel.
12167 Enable switch for notifications (experimental) in Page Settings
12168 https://bugs.webkit.org/show_bug.cgi?id=28930
12170 Adds support for the experimentalNotificationsEnabled flag in Settings through
12171 WebPreferencesPrivate interface. Also cleans up some issues accessing the
12172 notification delegate through DumpRenderTree.
12174 * Interfaces/IWebPreferencesPrivate.idl:
12175 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
12176 (WebDesktopNotificationsDelegate::hasNotificationDelegate):
12177 (WebDesktopNotificationsDelegate::notificationDelegate):
12178 * WebPreferenceKeysPrivate.h:
12179 * WebPreferences.cpp:
12180 (WebPreferences::initializeDefaultSettings):
12181 (WebPreferences::setExperimentalNotificationsEnabled):
12182 (WebPreferences::experimentalNotificationsEnabled):
12183 * WebPreferences.h:
12185 (WebView::notifyPreferencesChanged):
12187 2009-09-23 Anders Carlsson <andersca@apple.com>
12189 Reviewed by Adam Roben.
12191 <rdar://problem/7243354>
12192 REGRESSION(48580-48636): Crash clicking embedded QT preview button on apple.com/trailers
12194 Check for a null IWebPolicyDelegatePrivate.
12196 * WebCoreSupport/WebFrameLoaderClient.cpp:
12197 (WebFrameLoaderClient::shouldLoadMediaElementURL):
12199 2009-09-22 Sam Weinig <sam@webkit.org>
12201 Rubber-stamped by Adam Roben.
12203 Remove accidentally left in declaration of reloadFromOrigin in IWebFramePrivate.idl
12205 * Interfaces/IWebFramePrivate.idl:
12207 2009-09-22 Sam Weinig <sam@webkit.org>
12209 Reviewed by Steve Falkenburg.
12211 Fix for <rdar://problem/6451745>
12212 Windows WebKit needs to implement reloadFromOrigin()
12214 * Interfaces/IWebFrame.idl:
12215 * Interfaces/IWebFramePrivate.idl:
12216 * Interfaces/IWebView.idl:
12218 (WebFrame::reloadFromOrigin):
12221 (WebView::reloadFromOrigin):
12224 2009-09-22 Adam Roben <aroben@apple.com>
12226 Manage refcounts correctly in DefaultDownloadDelegate::willSendRequest
12228 Fixes <http://webkit.org/b/29650> Crash in
12229 WebDownload::willSendRequest when using DefaultDownloadDelegate
12231 Reviewed by Brady Eidson.
12233 * DefaultDownloadDelegate.cpp:
12234 (DefaultDownloadDelegate::willSendRequest): Call AddRef() on the
12235 object we're returning via the finalRequest out-parameter.
12237 2009-09-21 Anders Carlsson <andersca@apple.com>
12239 Reviewed by Adam Roben.
12241 <rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource
12243 Implement WebFrameLoaderClient::shouldLoadMediaElementURL and have it call the new private policy
12246 * Interfaces/IWebPolicyDelegatePrivate.idl: Added.
12247 * Interfaces/WebKit.idl:
12248 * WebCoreSupport/WebFrameLoaderClient.cpp:
12249 (WebFrameLoaderClient::shouldLoadMediaElementURL):
12250 * WebCoreSupport/WebFrameLoaderClient.h:
12251 * WebKit.vcproj/Interfaces.vcproj:
12253 2009-09-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
12255 Reviewed by Simon Hausmann.
12257 Make PlatformWindow return something else than PlatformWidget
12258 https://bugs.webkit.org/show_bug.cgi?id=29085
12260 Reflect the rename of platformWindow and it's return type.
12262 * AccessibleBase.cpp:
12263 (AccessibleBase::get_accParent):
12264 * WebCoreSupport/WebChromeClient.cpp:
12265 (WebChromeClient::platformPageClient):
12266 * WebCoreSupport/WebChromeClient.h:
12268 2009-09-17 Brian Weinstein <bweinstein@apple.com>
12270 Reviewed by Adam Roben.
12272 Remove assertions that were being hit by calls to
12273 m_verticalScrollbar->invalidate(). These assertions were valid,
12274 but they were causing tests to fail, so replacing with a FIXME
12275 until we can find out the real cause/solution that is being tracked
12276 by http://webkit.org/b/29350.
12279 (WebView::addToDirtyRegion):
12280 (WebView::paintIntoBackingStore):
12282 2009-09-17 Ada Chan <adachan@apple.com>
12284 Post WebViewDidChangeSelectionNotification when the text selection changes.
12286 Fixes <http://webkit.org/b/29321>
12288 Reviewed by Adam Roben.
12290 * Interfaces/IWebView.idl:
12291 * WebCoreSupport/WebEditorClient.cpp:
12292 (WebEditorClient::respondToChangedSelection):
12294 2009-09-17 Adam Roben <aroben@apple.com>
12296 Fix a crash when a WebView's HWND is destroyed before IWebView::close
12299 WebView's HWND was being sent a WM_TIMER message after the WebView was
12300 destroyed. This normally isn't possible (we call DestroyWindow inside
12301 WebView's destructor to ensure the HWND doesn't outlive the WebView),
12302 but r48060 changed WebView to call SetParent(m_viewWindow,
12303 HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the
12304 HWND into some weird half-destroyed state where it can still receive
12307 Fixes <http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION
12308 (r48060): unrepro but frequent crash in WebViewWndProc
12310 Reviewed by Steve Falkenburg.
12313 (WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed()
12314 before calling close(). This allows setHostWindow to detect that we're
12315 handling WM_DESTROY. No other code in close() cared whether
12316 isBeingDestroyed() was true or not.
12317 (WebView::setHostWindow): If our host window is being set to 0 and
12318 we're being destroyed, don't become a message-only window. Doing this
12319 while handling WM_DESTROY seems to lead to crashes.
12321 2009-09-16 Adam Roben <aroben@apple.com>
12323 Add a UI delegate callback to let the delegate draw a WebView's
12326 Fixes <http://webkit.org/b/29315>.
12328 Reviewed by Dave Hyatt.
12330 * Interfaces/IWebUIDelegatePrivate.idl: Added
12331 IWebUIDelegatePrivate2::drawBackground.
12334 (WebView::paintIntoBackingStore): After clearing or filling with
12335 white, let the delegate draw whatever background it wants. Also added
12336 an assertion that the dirty rect is within our bounds.
12338 2009-09-16 Adam Roben <aroben@apple.com>
12340 Prevent WebView from painting over sibling windows
12342 Fixes <http://webkit.org/b/29300> <rdar://problem/7227960> WebView can
12343 paint over sibling windows
12345 Reviewed by Darin Adler.
12348 (WebView::initWithFrame): Create the WebView's HWND with the
12349 WS_CLIPSIBLINGS style.
12351 2009-09-14 Brady Eidson <beidson@apple.com>
12353 Reviewed by Alexey Proskuryakov.
12355 Safari 4 cannot be used to update firmware on Linksys routers.
12356 <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
12358 Adopt the new WebCore::CredentialStorage in WebKit/Win.
12360 * WebDownloadCFNet.cpp:
12361 (WebDownload::didReceiveAuthenticationChallenge):
12363 2009-09-11 Steve Falkenburg <sfalken@apple.com>
12365 Reviewed by Dan Bernstein.
12367 Properly propagate preference from WebPreferences to WebCore::Settings.
12368 https://bugs.webkit.org/show_bug.cgi?id=29192
12371 (WebView::initWithFrame): Apply setting when creating a new WebView.
12372 (WebView::notifyPreferencesChanged): Apply setting when preferences change.
12374 2009-09-11 Steve Falkenburg <sfalken@apple.com>
12376 Reviewed by Darin Adler.
12378 Allow WebKit clients to opt out of high resolution timers on Windows.
12379 https://bugs.webkit.org/show_bug.cgi?id=29192
12381 * Interfaces/IWebPreferencesPrivate.idl: Added getter/setter.
12382 Put this just after last 4.0.3 method for future merging.
12383 * Interfaces/WebKit.idl: Touched to force a rebuild.
12384 * WebPreferenceKeysPrivate.h: Added prefs key for high res timers.
12385 * WebPreferences.cpp:
12386 (WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled.
12387 (WebPreferences::setShouldUseHighResolutionTimers): Added.
12388 (WebPreferences::shouldUseHighResolutionTimers): Added.
12389 * WebPreferences.h: Added getter/setter.
12391 2009-09-11 Adam Roben <aroben@apple.com>
12393 Get user script/stylesheet tests running on Windows
12395 Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
12398 Reviewed by John Sullivan.
12400 * Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup,
12401 addUserStyleSheetToGroup, removeUserContentFromGroup,
12402 removeAllUserContentFromGropu to match the Mac SPI.
12405 (WebView::addUserScriptToGroup):
12406 (WebView::addUserStyleSheetToGroup):
12407 (WebView::removeUserContentFromGroup):
12408 (WebView::removeAllUserContentFromGroup):
12410 Added. Implementation was based on similar methods in WebView.mm.
12412 2009-09-11 Jon Honeycutt <jhoneycutt@apple.com>
12414 Fix crash on launch on Windows.
12416 Rubber-stamped by Mark Rowe.
12418 * WebKit.vcproj/WebKit.vcproj:
12419 Define ENABLE_WEB_SOCKETS for all configurations.
12421 2009-09-07 Drew Wilson <atwilson@google.com>
12423 Reviewed by David Levin.
12425 Enable SHARED_WORKERS by default.
12426 https://bugs.webkit.org/show_bug.cgi?id=28959
12428 * WebKit.vcproj/WebKit.vcproj:
12430 2009-09-04 Adam Roben <aroben@apple.com>
12432 Make WebView function without a parent window
12434 When WebView has no parent window, it becomes a message-only window,
12435 which hides it from the screen and prevents it from appearing on the
12438 Fixes <http://webkit.org/b/28971> <rdar://problem/4976998>
12439 WebView::initWithFrame fails if there's no host window
12441 Reviewed by Dave Hyatt.
12444 (WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as
12445 our parent window, which will make us a message-only window.
12446 (WebView::setHostWindow): If he new host window is null, use
12447 HWND_MESSAGE as our parent window, which will make us a message-only
12450 2009-09-04 Adam Barth <abarth@webkit.org>
12452 Unreviewed attempt at a build fix.
12454 Added missing include.
12456 * WebCoreSupport/WebFrameLoaderClient.cpp:
12458 2009-09-04 Adam Barth <abarth@webkit.org>
12460 Unreviewed attempt at a build fix.
12462 Fix typo of IWebFrameLoadDelegatePrivate2 and make
12463 IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate
12464 as requestd by Adam Roben.
12466 * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
12467 * WebCoreSupport/WebFrameLoaderClient.cpp:
12468 (WebFrameLoaderClient::didDisplayInsecureContent):
12469 (WebFrameLoaderClient::didRunInsecureContent):
12471 2009-09-04 Adam Barth <abarth@webkit.org>
12473 Reviewed by Eric Seidel.
12475 https://bugs.webkit.org/show_bug.cgi?id=24696
12477 Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.
12479 * Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
12480 * Interfaces/WebKit.idl:
12481 * WebCoreSupport/WebFrameLoaderClient.cpp:
12482 (WebFrameLoaderClient::didDisplayInsecureContent):
12483 (WebFrameLoaderClient::didRunInsecureContent):
12484 * WebKit.vcproj/Interfaces.vcproj:
12486 2009-09-03 Adam Barth <abarth@webkit.org>
12488 Reviewed by eric@webkit.org.
12490 https://bugs.webkit.org/show_bug.cgi?id=24696
12492 Stub implementations of mixed content methods of FrameLoaderClient.
12494 * WebCoreSupport/WebFrameLoaderClient.cpp:
12495 (WebFrameLoaderClient::didDisplayInsecureContent):
12496 (WebFrameLoaderClient::didRunInsecureContent):
12497 * WebCoreSupport/WebFrameLoaderClient.h:
12499 2009-09-01 Adam Roben <aroben@apple.com>
12501 Post a notification when a WebView is closing
12503 This is useful for situations where some code wants to react to the
12504 WebView closing but isn't in charge of the WebView and can't otherwise
12505 be notified. This notification could replace
12506 IWebUIDelegatePrivate::webViewClosing if we decide that the
12507 notification system isn't too burdensome.
12509 <http://webkit.org/b/28875>
12511 Reviewed by John Sullivan.
12513 * Interfaces/IWebViewPrivate.idl: Added the
12514 WebViewWillCloseNotification string constant.
12515 * WebKit.vcproj/WebKit.vcproj: Link against comsuppw.lib in all
12516 configurations so that we can use _bstr_t.
12518 (WebView::close): Post the WebViewWillCloseNotification.
12520 2009-08-31 Alexey Proskuryakov <ap@webkit.org>
12522 Reviewed by Darin Adler.
12524 https://bugs.webkit.org/show_bug.cgi?id=28852
12525 Rename KURL single argument constructor to avoid confusion
12527 * WebURLResponse.cpp: (WebURLResponse::createInstance): Adapt to the change.
12529 2009-08-20 Adam Roben <aroben@apple.com>
12531 Give WebKit clients access to the window features specified in
12534 Reviewed by Steve Falkenburg.
12536 * COMVariantSetter.h: Added COMVariantSetters for bool and float.
12538 * Interfaces/IWebUIDelegatePrivate.idl: Added IWebUIDelegatePrivate2,
12539 which contains a new version of createWebViewWithRequest that also
12540 passes the window features as an IPropertyBag. This is analagous to
12541 the -createWebViewWithRequest:windowFeatures: method added to
12542 WebUIDelegate on Mac in r27452. Also added key strings for use with
12543 the window features property bag.
12545 * WebCoreSupport/WebChromeClient.cpp:
12546 (createWindowFeaturesPropertyBag): Added this helper function to turn
12547 a WebCore::WindowFeatures into an IPropertyBag for passing to WebKit
12549 (WebChromeClient::createWindow): If the UI delegate implements
12550 IWebUIDelegatePrivate2, call the new createWebViewWithRequest function
12551 that takes a window features property bag. If the delegate doesn't
12552 implement the new function, fall back to the old functions.
12554 2009-08-20 Adam Roben <aroben@apple.com>
12556 A little clean-up in WebChromeClient::createWindow
12558 Reviewed by Steve Falkenburg.
12560 * WebCoreSupport/WebChromeClient.cpp:
12561 (WebChromeClient::createWindow): Refactored to share more code between
12562 the dialog and non-dialog cases.
12564 2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
12566 Reviewed by Holger Freyther.
12568 https://bugs.webkit.org/show_bug.cgi?id=25889
12569 [GTK] scrollbar policy for main frame is not implementable
12571 Add empty implementation for new ChromeClient method.
12573 * WebCoreSupport/WebChromeClient.h:
12574 (WebChromeClient::scrollbarsModeDidChange):
12576 2009-08-27 Brent Fulgham <bfulgham@webkit.org>
12578 Reviewed by Adam Roben.
12580 Modify Release_Cairo target to build testapi using the
12581 Release_CFLite target so that the correct CoreFoundation
12582 (in this case, CFLite.dll) is linked.
12584 * WebKit.vcproj/WebKit.sln:
12586 2009-08-26 Adam Barth <abarth@webkit.org>
12588 Reviewed by Oliver Hunt.
12590 Don't let local files access web URLs
12591 https://bugs.webkit.org/show_bug.cgi?id=28480
12593 * WebPreferences.cpp:
12594 (WebPreferences::initializeDefaultSettings):
12596 2009-08-26 David Levin <levin@chromium.org>
12598 Reviewed by Darin Fisher.
12600 ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
12601 https://bugs.webkit.org/show_bug.cgi?id=28735
12603 * WebMutableURLRequest.cpp:
12604 (WebMutableURLRequest::setHTTPShouldHandleCookies):
12606 2009-08-25 Eric Carlson <eric.carlson@apple.com>
12608 Reviewed by Oliver Hunt.
12610 <video> and <audio> controller should be accessible
12611 https://bugs.webkit.org/show_bug.cgi?id=28081
12613 * WebCoreLocalizedStrings.cpp:
12614 (WebCore::localizedMediaControlElementString):
12615 (WebCore::localizedMediaControlElementHelpText):
12616 (WebCore::localizedMediaTimeDescription):
12619 2009-08-25 Brent Fulgham <bfulgham@webkit.org>
12621 Build fix for Windows.
12623 Revise Debug_Cairo build target to build testapi, jsc, WinLauncher,
12624 DumpRenderTree, and TestNetscapeAPI using WinCairo debug build
12625 settings so they link against the proper libraries.
12627 * WebKit.vcproj/WebKit.sln:
12629 2009-08-25 David Levin <levin@chromium.org>
12631 Reviewed by Adam Roben.
12633 PLATFORM(CFNETWORK) should be USE(CFNETWORK).
12634 https://bugs.webkit.org/show_bug.cgi?id=28713
12636 Also, moved the #if header section after the other #includes.
12639 (WebError::localizedDescription):
12641 2009-08-24 Brent Fulgham <bfulgham@webkit.org>
12643 Reviewed by Steve Falkenburg.
12645 Revise CFLite Debug build to emit DLL's with _debug label.
12646 https://bugs.webkit.org/show_bug.cgi?id=28695.
12648 * WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to
12649 inherit from new debug_wincairo property sheet, instead of
12650 the current debug sheet.
12652 2009-08-22 Adam Barth <abarth@webkit.org>
12654 Revert 47684. We're going to do this later once clients have had a
12655 chance to opt into the setting they like.
12657 * WebPreferences.cpp:
12658 (WebPreferences::initializeDefaultSettings):
12660 2009-08-22 Adam Barth <abarth@webkit.org>
12662 Reviewed by Eric Seidel.
12664 Don't let local files access web URLs
12665 https://bugs.webkit.org/show_bug.cgi?id=28480
12667 * WebPreferences.cpp:
12668 (WebPreferences::initializeDefaultSettings):
12670 2009-08-20 Brian Weinstein <bweinstein@apple.com>
12672 Reviewed by Adam Roben.
12674 Fix of <http://webkit.org/b/27850>. Panning by emulating Mouse Wheel Events breaks Google Maps.
12676 Switched to using RenderLayer::scrollByRecursively instead of emulating a mouse wheel,
12677 and switched to handling the hit testing in WebView from doing it as part of the mouse wheel event.
12678 One downside of this fix is that panning will not jump out of frames anymore (same behavior as pan-scrolling), but
12679 this is tracked in <http://webkit.org/b/28237>.
12682 (WebView::gestureNotify): Added hit testing here to figure out the node the user started the gesture on.
12683 (WebView::gesture): Switched from emulating mouse wheel events for panning to calling RenderLayer::scrollByRecursively.
12686 2009-08-18 Brian Weinstein <bweinstein@apple.com>
12688 Reviewed by Oliver Hunt.
12690 Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
12691 LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
12693 Added a setQuota interface method to IWebDatabaseManager and implemented it.
12695 * Interfaces/IWebDatabaseManager.idl:
12696 * WebDatabaseManager.cpp:
12697 (WebDatabaseManager::setQuota):
12698 * WebDatabaseManager.h:
12700 2009-08-18 Drew Wilson <atwilson@google.com>
12702 Unreviewed (build break).
12704 Added missing include for WebWorkersPrivate.h.
12706 * WebKitClassFactory.cpp:
12708 2009-08-18 Peter Kasting <pkasting@google.com>
12710 Reviewed by Eric Seidel.
12712 https://bugs.webkit.org/show_bug.cgi?id=28415
12713 Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
12716 * WebKit.vcproj/InterfacesGenerated.vcproj:
12718 2009-08-18 Drew Wilson <atwilson@google.com>
12720 Reviewed by Eric Seidel.
12722 Need to extend DumpRenderTree to expose number of worker threads
12723 https://bugs.webkit.org/show_bug.cgi?id=28292
12725 Defined/implemented COM interfaces to expose WorkerThread::workerThreadCount() for DumpRenderTree.
12727 * ForEachCoClass.h:
12728 Added WebWorkersPrivate.
12729 * Interfaces/IWebWorkersPrivate.idl: Added.
12730 * Interfaces/WebKit.idl:
12731 Added WebWorkersPrivate.
12732 * WebKit.vcproj/Interfaces.vcproj:
12733 * WebKit.vcproj/WebKit.vcproj:
12734 * WebWorkersPrivate.cpp: Added.
12735 Implementation of the IWebWorkersPrivate COM interface, to expose workerThreadCount() for DumpRenderTree.
12736 (WebWorkersPrivate::QueryInterface):
12737 (WebWorkersPrivate::AddRef):
12738 (WebWorkersPrivate::Release):
12739 (WebWorkersPrivate::workerThreadCount):
12740 (WebWorkersPrivate::createInstance):
12741 (WebWorkersPrivate::WebWorkersPrivate):
12742 (WebWorkersPrivate::~WebWorkersPrivate):
12743 * WebWorkersPrivate.h: Added.
12745 2009-08-17 Peter Kasting <pkasting@google.com>
12747 Reviewed by Steve Falkenburg.
12749 https://bugs.webkit.org/show_bug.cgi?id=27323
12750 Only add Cygwin to the path when it isn't already there. This avoids
12751 causing problems for people who purposefully have non-Cygwin versions of
12752 executables like svn in front of the Cygwin ones in their paths.
12754 * WebKit.vcproj/Interfaces.vcproj:
12755 * WebKit.vcproj/InterfacesGenerated.vcproj:
12756 * WebKit.vcproj/WebKit.vcproj:
12757 * WebKit.vcproj/WebKitGUID.vcproj:
12759 2009-08-17 Simon Fraser <simon.fraser@apple.com>
12761 Speculative fix for Windows build bustage.
12763 * DOMHTMLClasses.cpp:
12764 (DOMHTMLElement::idName):
12766 2009-08-13 Jon Honeycutt <jhoneycutt@apple.com>
12768 Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
12771 https://bugs.webkit.org/show_bug.cgi?id=20866
12773 Reviewed by Oliver Hunt.
12775 * AccessibleBase.cpp:
12776 (AccessibleBase::getAccessibilityObjectForChild):
12777 If the child ID is negative, negate it and treat it as an AXID.
12779 2009-08-12 Brian Weinstein <bweinstein@apple.com>
12781 Reviewed by Adam Roben.
12783 Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
12784 list detaches drop down.
12786 Added a check in mouseWheel to see if our focus is currently in a popup, if so, close
12787 the popup (matches other browser behavior).
12790 (WebView::mouseWheel):
12792 2009-08-12 Adam Roben <aroben@apple.com>
12794 Make WebPreferenceKeysPrivate.h available for client use
12796 Reviewed by Dave Hyatt.
12798 Fixes <http://webkit.org/b/28227>.
12800 * WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to
12801 $WebKitOutputDir, just like we do for a few other headers. Also let VS
12802 reorder some XML attributes.
12804 * WebPreferenceKeysPrivate.h: Touched this file to force a build.
12806 2009-08-11 Adam Roben <aroben@apple.com>
12808 Remove support for a window resizer within the WebView
12810 Starting with Safari 4, there is never a window resizer inside the
12811 WebView, so we no longer need to support that functionality.
12813 Fixes <http://webkit.org/b/28190> Remove support for a window resizer
12816 Reviewed by Dave Hyatt.
12818 * Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate
12819 functions related to the window resizer with unused*() functions. We
12820 can't remove them entirely because we need to keep the vtable
12821 unchanged so new versions of WebKit will work with old versions of
12822 Safari (e.g., for nightlies and WebKit development).
12824 * WebCoreSupport/WebChromeClient.cpp:
12825 (WebChromeClient::windowResizerRect): Now always returns an empty
12830 (WebView::handleMouseEvent):
12832 Removed window-resizer-related code.
12834 2009-08-11 John Gregg <johnnyg@google.com>
12836 Reviewed by Maciej Stachowiak.
12838 Move the accessor for notifications presenter from WebUIDelegate
12839 to WebUIDelegate2 which extends it. When making this call from
12840 WebCoreSupport, check using QueryInterface before calling.
12842 https://bugs.webkit.org/show_bug.cgi?id=28198
12844 * Interfaces/IWebUIDelegate.idl:
12845 * Interfaces/IWebUIDelegate2.idl: Added.
12846 * Interfaces/WebKit.idl:
12847 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
12848 (WebDesktopNotificationsDelegate::show):
12849 (WebDesktopNotificationsDelegate::cancel):
12850 (WebDesktopNotificationsDelegate::notificationObjectDestroyed):
12851 (WebDesktopNotificationsDelegate::requestPermission):
12852 (WebDesktopNotificationsDelegate::checkPermission):
12853 (WebDesktopNotificationsDelegate::hasNotificationDelegate):
12854 (WebDesktopNotificationsDelegate::notificationDelegate):
12855 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
12857 2009-08-11 Drew Wilson <atwilson@google.com>
12859 Reviewed by NOBODY (build break).
12861 Speculative Windows build fix - undo previous unnecessary change.
12863 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
12865 2009-08-11 Brian Weinstein <bweinstein@apple.com>
12867 Reviewed by Steve Falkenburg.
12869 Refactored MIMETypeforExtension to be a member of IWebViewPrivate
12870 instead of IWebView.
12872 * Interfaces/IWebView.idl:
12873 * Interfaces/IWebViewPrivate.idl:
12875 (WebView::MIMETypeForExtension):
12878 2009-08-11 Drew Wilson <atwilson@google.com>
12880 Reviewed by NOBODY (build break)
12882 Speculative fix for windows build break.
12884 * WebKitSupport/WebDesktopNotificationsDelegate.h:
12885 WebCore/Notification*.h => WebCore/notifications/Notification*.h
12887 2009-08-11 John Gregg <johnnyg@google.com>
12889 Reviewed by Maciej Stachowiak.
12891 Desktop Notifications API
12892 https://bugs.webkit.org/show_bug.cgi?id=25643
12894 Adds test hooks for notification features to WebCoreSupport for
12895 use in DumpRenderTree.
12897 * Interfaces/IWebDesktopNotificationsDelegate.idl: Added.
12898 * Interfaces/IWebUIDelegate.idl:
12899 * Interfaces/WebKit.idl:
12900 * WebCoreSupport/WebChromeClient.cpp:
12901 (WebChromeClient::WebChromeClient):
12902 * WebCoreSupport/WebChromeClient.h:
12903 (WebChromeClient::notificationPresenter):
12904 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added.
12905 (NotificationCOMWrapper::create):
12906 (NotificationCOMWrapper::NotificationCOMWrapper):
12907 (NotificationCOMWrapper::QueryInterface):
12908 (NotificationCOMWrapper::AddRef):
12909 (NotificationCOMWrapper::Release):
12910 (NotificationCOMWrapper::isHTML):
12911 (NotificationCOMWrapper::contentsURL):
12912 (NotificationCOMWrapper::iconURL):
12913 (NotificationCOMWrapper::title):
12914 (NotificationCOMWrapper::text):
12915 (NotificationCOMWrapper::notifyDisplay):
12916 (NotificationCOMWrapper::notifyError):
12917 (NotificationCOMWrapper::notifyClose):
12918 (WebDesktopNotificationsDelegate::WebDesktopNotificationsDelegate):
12919 (WebDesktopNotificationsDelegate::show):
12920 (WebDesktopNotificationsDelegate::cancel):
12921 (WebDesktopNotificationsDelegate::notificationObjectDestroyed):
12922 (WebDesktopNotificationsDelegate::requestPermission):
12923 (WebDesktopNotificationsDelegate::checkPermission):
12924 (WebDesktopNotificationsDelegate::notificationDelegate):
12925 * WebCoreSupport/WebDesktopNotificationsDelegate.h: Added.
12926 * WebCoreSupport/WebInspectorDelegate.h:
12927 (WebInspectorDelegate::desktopNotificationsDelegate):
12928 * WebKit.vcproj/Interfaces.vcproj:
12929 * WebKit.vcproj/WebKit.vcproj:
12931 2009-08-11 Brian Weinstein <bweinstein@apple.com>
12933 Reviewed by Adam Roben.
12935 Fix of <rdar://5016504> SVG file cannot be dragged to webview,
12936 but can be opened via Open File.
12938 Added a new function to IWebView that gets the MIME type for a given
12939 extension from the MIMETypeRegistry.
12941 * Interfaces/IWebView.idl:
12943 (WebView::MIMETypeForExtension):
12946 2009-08-11 Dmitry Titov <dimich@chromium.org>
12948 Reviewed by Adam Roben.
12950 Originally implemented by Glenn Wilson <gwilson@chromium.org>.
12952 Added support for overriding default preferences per-test.
12953 See https://bugs.webkit.org/show_bug.cgi?id=20534
12955 * Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
12956 * WebPreferences.cpp: same.
12957 * WebPreferences.h: same.
12959 2009-08-10 Dan Bernstein <mitz@apple.com>
12961 Reviewed by Darin Adler.
12963 Link drag images specify Lucida Grande on Windows and end up using Times
12965 <rdar://problem/7117835>
12967 * WebCoreSupport/WebDragClient.cpp:
12968 (dragLabelFont): Added a RenderingMode parameter and changed to use the
12969 same typeface as the Windows small caption font.
12970 (WebDragClient::createDragImageForLink): Changed to respect the
12971 page’s rendering mode.
12973 2009-08-10 Brent Fulgham <bfulgham@webkit.org>
12975 Reviewed by Adam Roben.
12977 https://bugs.webkit.org/show_bug.cgi?id=28048.
12978 Move various WinCairo build settings into *.vsprops file.
12980 * WebKit.vcproj/WebKit.vcproj: Add new cURL.vsprops property sheet
12981 (which contains link settings for cURL and its dependencies), and
12982 remove the corresponding entries from the vcproj file. Remove
12983 png, jpeg, cairo library linking flags from vcproj, now that they
12984 are in the WinCairo.vsprops file.
12986 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
12988 Reviewed by George Staikos.
12990 [WML] Deck access control is completly broken
12991 https://bugs.webkit.org/show_bug.cgi?id=27721
12993 Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.
12995 * Interfaces/IWebFramePrivate.idl:
12997 2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
12999 Reviewed by Maciej Stachowiak.
13001 FrameLoadType / WebFrameLoadType enums are out of sync
13002 https://bugs.webkit.org/show_bug.cgi?id=28132
13004 Synchronize FrameLoadType <-> WebFrameLoadType enums (append missing 'WebFrameLoadTypeReloadFromOrigin' value)
13006 * Interfaces/IWebFramePrivate.idl:
13008 2009-08-06 Adam Barth <abarth@webkit.org>
13012 http://bugs.webkit.org/show_bug.cgi?id=27879
13014 Revert 46877 because it broke GTK.
13016 * COMPropertyBag.h:
13018 2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
13020 Reviewed by Adam Barth.
13022 Change Noncopyable inheriting to public
13023 http://bugs.webkit.org/show_bug.cgi?id=27879
13025 Since Noncopyable is inherited from FastAllocBase,
13026 Noncopyable's inheriting has been changed to public.
13028 * COMPropertyBag.h:
13030 2009-08-04 Alice Liu <alice.liu@apple.com>
13032 "Shift + Enter" should behave like "Enter" in editable fields.
13033 Affects backward search in find-in-page in Safari for Windows
13035 Reviewed by Jon Honeycutt.
13038 Register shift+enter as InsertNewline command, similar to other
13039 modifier+Enter combinations.
13041 2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>
13043 Part of <rdar://problem/5698113> Safari shouldn't auto-activate
13044 plug-ins in background tabs (make Win consistent with Mac)
13046 https://bugs.webkit.org/show_bug.cgi?id=27855
13048 Reviewed by Adam Roben and Anders Carlsson.
13050 * Interfaces/IWebViewPrivate.idl:
13051 Add setCanStartPlugins().
13053 * WebCoreSupport/WebFrameLoaderClient.cpp:
13054 (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
13055 Added; code moved from createPlugin(). Modified to obtain the plug-in's
13056 page URL, the plug-ins "plug-ins page" parameter value, and the
13057 plug-in's MIME type by calling getter functions on the passed
13059 (WebFrameLoaderClient::createPlugin):
13060 If the plug-in status is not "success," call
13061 dispatchDidFailToStartPlugin().
13063 * WebCoreSupport/WebFrameLoaderClient.h:
13064 Declare an override of dispatchDidFailToStartPlugin().
13068 Add a missing ) to a comment.
13069 (WebView::setCanStartPlugins):
13070 Call the Page's setCanStartPlugins() function.
13074 2009-07-30 Darin Adler <darin@apple.com>
13076 Reviewed by David Levin.
13078 Use checked casts for render tree
13079 https://bugs.webkit.org/show_bug.cgi?id=23522
13081 * DOMHTMLClasses.cpp:
13082 (DOMHTMLInputElement::isUserEdited):
13083 (DOMHTMLTextAreaElement::isUserEdited):
13086 2009-07-31 Anders Carlsson <andersca@apple.com>
13088 Reviewed by Dan Bernstein.
13090 -Fix <rdar://problem/7104097>
13092 Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.
13094 * WebCoreSupport/EmbeddedWidget.cpp:
13095 (EmbeddedWidget::create):
13096 * WebCoreSupport/EmbeddedWidget.h:
13098 2009-07-29 Brian Weinstein <bweinstein@apple.com>
13100 Was doing the build fix wrong, NotImplemented.h is in WebCore.
13102 * WebCoreSupport/WebInspectorClient.cpp:
13104 2009-07-29 Brian Weinstein <bweinstein@apple.com>
13108 * WebCoreSupport/WebInspectorClient.cpp:
13110 2009-07-29 Kevin McCullough <kmccullough@apple.com>
13112 Reviewed by Darin Adler.
13114 Added foundation work to allow a testing infrastructure for the Web
13117 * WebCoreSupport/WebInspectorClient.cpp:
13118 (WebInspectorClient::inspectorWindowObjectCleared): Empty definition
13119 to let Windows compile but we should implement this at some point so
13120 that the tests can be run on Windows too.
13121 * WebCoreSupport/WebInspectorClient.h:
13123 2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
13125 Reviewed by Steve Falkenburg.
13127 Add output directory for VS pre-build steps to enable out-of-tree builds
13129 https://bugs.webkit.org/show_bug.cgi?id=27700
13131 The tmp.obj file is now placed in the intermediate build directory.
13133 * WebKit.vcproj/WebKit.vcproj:
13135 2009-07-27 Brian Weinstein <bweinstein@apple.com>
13137 Build fix for Windows.
13140 (WebView::stringByEvaluatingJavaScriptFromString):
13142 2009-07-27 Alexey Proskuryakov <ap@webkit.org>
13144 Reviewed by Darin Adler.
13146 https://bugs.webkit.org/show_bug.cgi?id=27735
13147 Give a helpful name to JSLock constructor argument
13149 * WebCoreStatistics.cpp:
13150 (WebCoreStatistics::javaScriptObjectsCount):
13151 (WebCoreStatistics::javaScriptGlobalObjectsCount):
13152 (WebCoreStatistics::javaScriptProtectedObjectsCount):
13153 (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
13154 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
13155 * WebJavaScriptCollector.cpp:
13156 (WebJavaScriptCollector::objectCount):
13158 (WebView::stringByEvaluatingJavaScriptFromString):
13160 2009-07-25 Kwang Yul Seo <skyul@company100.net>
13162 Reviewed by Darin Adler.
13164 Windows build break due to warning C4819
13165 https://bugs.webkit.org/show_bug.cgi?id=27416
13167 Disable C4819 warning to fix build.
13169 * WebKit.vcproj/WebKit.vcproj:
13171 2009-07-24 Brent Fulgham <bfulgham@webkit.org>
13173 Reviewed by Dave Hyatt.
13175 Clean up dependencies on Apple support libraries for non-Apple build.
13176 http://bugs.webkit.org/show_bug.cgi?id=27532.
13178 * DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
13179 * WebDownload.h: Conditionalize include of CFNetwork.h
13180 * WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
13182 2009-07-24 Andrei Popescu <andreip@google.com>
13184 Reviewed by Anders Carlsson.
13186 ApplicationCache should have size limit
13187 https://bugs.webkit.org/show_bug.cgi?id=22700
13189 * WebCoreSupport/WebChromeClient.cpp:
13190 (WebChromeClient::reachedMaxAppCacheSize):
13191 Adds empty implementation of the reachedMaxAppCacheSize callback.
13192 * WebCoreSupport/WebChromeClient.h:
13194 2009-07-23 Brady Eidson <beidson@apple.com>
13196 Reviewed by Geoff Garen.
13198 WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest.
13199 https://bugs.webkit.org/show_bug.cgi?id=27595
13201 * WebCoreSupport/WebFrameLoaderClient.cpp:
13202 (WebFrameLoaderClient::dispatchWillSendRequest):
13204 2009-07-22 Takeshi Yoshino <tyoshino@google.com>
13206 Reviewed by Darin Adler.
13208 VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
13209 https://bugs.webkit.org/show_bug.cgi?id=26375
13211 Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
13212 with hex escape sequences.
13214 VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
13215 treated as an error and stopped build).
13217 WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
13218 represented in the current code page (932). Save the file in Unicode format to prevent data loss
13220 A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
13221 localized string generation process.
13223 * WebCoreLocalizedStrings.cpp:
13224 (WebCore::imageTitle):
13226 2009-07-21 Roland Steiner <rolandsteiner@google.com>
13228 Reviewed by David Levin.
13230 Add ENABLE_RUBY to list of build options
13231 https://bugs.webkit.org/show_bug.cgi?id=27324
13233 * WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.
13235 2009-07-20 Peter Kasting <pkasting@google.com>
13237 Reviewed by Mark Rowe.
13239 https://bugs.webkit.org/show_bug.cgi?id=27468
13240 Back out r46060, which caused problems for some Apple developers.
13242 * WebKit.vcproj/Interfaces.vcproj:
13243 * WebKit.vcproj/InterfacesGenerated.vcproj:
13244 * WebKit.vcproj/WebKit.vcproj:
13245 * WebKit.vcproj/WebKitGUID.vcproj:
13247 2009-07-17 Brian Weinstein <bweinstein@apple.com>
13249 Reviewed by Adam Roben.
13251 Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
13252 https://bugs.webkit.org/show_bug.cgi?id=14272
13254 Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight
13255 to set window sizes and redraw the inspector and the inspected web view, and used stored preferences
13256 in InspectorController.cpp to remember user's preferred height.
13258 * WebCoreSupport/WebInspectorClient.cpp:
13260 2009-07-17 Peter Kasting <pkasting@google.com>
13262 Reviewed by Steve Falkenburg.
13264 https://bugs.webkit.org/show_bug.cgi?id=27323
13265 Only add Cygwin to the path when it isn't already there. This avoids
13266 causing problems for people who purposefully have non-Cygwin versions of
13267 executables like svn in front of the Cygwin ones in their paths.
13269 * WebKit.vcproj/Interfaces.vcproj:
13270 * WebKit.vcproj/InterfacesGenerated.vcproj:
13271 * WebKit.vcproj/WebKit.vcproj:
13272 * WebKit.vcproj/WebKitGUID.vcproj:
13274 2009-07-16 Fumitoshi Ukai <ukai@chromium.org>
13276 Reviewed by David Levin.
13278 Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
13279 https://bugs.webkit.org/show_bug.cgi?id=27206
13281 Add ENABLE_WEB_SOCKETS
13283 * WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS
13285 2009-07-16 Xiaomei Ji <xji@chromium.org>
13287 Reviewed by Darin Adler.
13289 Fix tooltip does not get its directionality from its element's directionality.
13290 https://bugs.webkit.org/show_bug.cgi?id=24187
13292 Per mitz's suggestion in comment #6, while getting the plain-text
13293 title, we also get the directionality of the title. How to handle
13294 the directionality is up to clients. Clients could ignore it,
13295 or use attribute or unicode control characters to display the title
13298 * WebCoreSupport/WebChromeClient.cpp:
13299 (WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
13300 * WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
13301 * WebElementPropertyBag.cpp:
13302 (WebElementPropertyBag::Read): Change call of spellingToolTip() and title() due to signature change.
13304 2009-07-15 Darin Adler <darin@apple.com>
13306 Reviewed by Sam Weinig.
13308 Renamed parseURL to deprecatedParseURL.
13310 * WebCoreSupport/WebFrameLoaderClient.cpp:
13311 (WebFrameLoaderClient::createPlugin): Renamed.
13313 2009-07-14 Steve Falkenburg <sfalken@apple.com>
13315 Reorganize JavaScriptCore headers into:
13316 API: include/JavaScriptCore/
13317 Private: include/private/JavaScriptCore/
13319 Reviewed by Darin Adler.
13321 * WebKit.vcproj/WebKit.vcproj:
13323 2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
13325 Reviewed by Darin Adler.
13327 Change all Noncopyable inheriting visibility to public.
13328 https://bugs.webkit.org/show_bug.cgi?id=27225
13330 Change all Noncopyable inheriting visibility to public because
13331 it is needed to the custom allocation framework (bug #20422).
13333 * COMEnumVariant.h:
13334 * WebDatabaseManager.cpp:
13336 * WebLocalizableStrings.cpp:
13338 2009-07-13 Brent Fulgham <bfulgham@webkit.org>
13340 Reviewed by Adam Roben.
13342 Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
13343 https://bugs.webkit.org/show_bug.cgi?id=27240.
13346 (WebFrame::printHeader): New shared method to print the header.
13347 (WebFrame::printFooter): New shared method to print the footer.
13348 (WebFrame::spoolPage): New conditionally-compiled method to print
13350 (WebFrame::spoolPages): Revised to call the platform-specific spoolPage
13352 * WebFrame.h: Add new method prototypes.
13354 2009-07-13 Brent Fulgham <bfulgham@webkit.org>
13356 Reviewed by Adam Roben.
13358 Add new configuration flag for redistributable Windows build.
13359 https://bugs.webkit.org/show_bug.cgi=27087
13361 * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to
13362 Debug_Cairo and Release_Cairo targets.
13364 2009-07-12 Brent Fulgham <bfulgham@gmail.com>
13366 Speculative Windows build fix after http://trac.webkit.org/changeset/45786.
13368 * WebCoreSupport/WebChromeClient.cpp:
13369 (WebChromeClient::addMessageToConsole):
13371 2009-07-10 Adam Barth <abarth@webkit.org>
13373 Reviewed by Sam Weinig with the power of Grayskull.
13375 Enable XSSAuditor by default.
13377 * WebPreferences.cpp:
13378 (WebPreferences::initializeDefaultSettings):
13380 2009-07-09 Drew Wilson <atwilson@google.com>
13382 Reviewed by Alexey Proskuryakov.
13384 https://bugs.webkit.org/show_bug.cgi?id=26903
13386 Turned on CHANNEL_MESSAGING by default because the MessageChannel API
13387 can now be implemented for Web Workers and is reasonably stable.
13389 * WebKit.vcproj/WebKit.vcproj:
13391 2009-07-09 Brian Weinstein <bweinstein@apple.com>
13393 Reviewed by Alice Liu.
13395 Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271)
13396 https://bugs.webkit.org/show_bug.cgi?id=27140
13398 Added a preference key to remember whether the user prefers the inspector detached or attached.
13400 * WebCoreSupport/WebInspectorClient.cpp:
13401 (WebInspectorClient::showWindow): Pass both parameters into setWindowVisible
13402 (WebInspectorClient::closeWindow): Ditto
13403 (WebInspectorClient::attachWindow): Set preference to attached windows here
13404 (WebInspectorClient::detachWindow): Set preference to detached windows here
13405 (WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached
13406 (WebInspectorClient::onClose): Pass both parameters into setWindowVisible
13408 2009-07-09 Alexey Proskuryakov <ap@webkit.org>
13410 Reviewed by Oliver Hunt.
13412 <rdar://problem/6921671> Visit count shouldn't be incremented by redirects.
13414 * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
13415 Do not increase visit count if there is a redirect source. As a result, only pages that were
13416 explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking
13417 a link) will be counted.
13419 * Interfaces/IWebHistoryItemPrivate.idl:
13421 (WebHistory::visitedURL):
13423 * WebHistoryItem.cpp:
13424 (WebHistoryItem::visitedWithTitle):
13425 * WebHistoryItem.h:
13426 Marshal this new argument all the way down to WebCore.
13428 2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>
13430 Reviewed by Dave Hyatt.
13432 Make Widget RefCounted to fix:
13434 <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
13435 at WebCore::Widget::afterMouseDown() after clicking To Do's close
13437 <rdar://problem/6978804> WER #16: Repro Access Violation in
13438 WebCore::PluginView::bindingInstance (1310178023)
13440 <rdar://problem/6991251> WER #13: Crash in WebKit!
13441 WebCore::PluginView::performRequest+203 (1311461169)
13443 * WebCoreSupport/WebFrameLoaderClient.cpp:
13444 (WebFrameLoaderClient::createPlugin):
13445 * WebCoreSupport/WebFrameLoaderClient.h:
13447 (WebFrame::createJavaAppletWidget):
13450 2009-07-09 Sam Weinig <sam@webkit.org>
13452 Reviewed by Steve Falkenburg.
13454 Roll out r43848. The quirk is no longer necessary.
13457 (WebView::userAgentForKURL):
13459 2009-07-07 Ada Chan <adachan@apple.com>
13461 Reviewed by Dave Hyatt.
13463 Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView.
13464 https://bugs.webkit.org/show_bug.cgi?id=27057
13469 2009-07-02 Erik Arvidsson <arv@chromium.org>
13471 Reviewed by Adam Roben.
13473 [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
13474 https://bugs.webkit.org/show_bug.cgi?id=26699
13476 * WebDropSource.cpp:
13477 (WebDropSource::QueryContinueDrag):
13479 2009-07-02 Oliver Hunt <oliver@apple.com>
13481 Reviewed by Anders Carlsson.
13483 <rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670)
13484 <https://bugs.webkit.org/show_bug.cgi?id=26670>
13486 Make windows loader client match mac behaviour more closely.
13488 * WebCoreSupport/WebFrameLoaderClient.cpp:
13489 (WebFrameLoaderClient::forceLayout):
13491 2009-06-30 Brent Fulgham <bfulgham@gmail.com>
13493 Reviewed by Adam Roben.
13495 Build DumpRenderTree under Cairo.
13496 https://bugs.webkit.org/show_bug.cgi?id=26457
13498 * WebKit.vcproj/WebKit.sln: Add Cairo targets to the
13499 DumpRenderTree build, and use the in the Debug_Cairo
13500 and Release_Cairo targets.
13502 2009-07-02 Eric Carlson <eric.carlson@apple.com>
13504 Fix Windows build by including missing localized string methods.
13506 * WebCoreLocalizedStrings.cpp:
13507 (WebCore::mediaElementLoadingStateText):
13508 (WebCore::mediaElementLiveBroadcastStateText):
13510 2009-07-01 David Hyatt <hyatt@apple.com>
13512 Reviewed by Tim Hatcher.
13514 <rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
13515 even though the field is not actually focused for keyboard input
13517 Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
13518 focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
13524 2009-06-29 David Hyatt <hyatt@apple.com>
13526 Fix Windows bustage. Missed two configurations for enabling DATAGRID.
13528 * WebKit.vcproj/WebKit.vcproj:
13530 2009-06-29 Jessie Berlin <jberlin@apple.com>
13532 Reviewed by Adam Roben.
13534 Fix the windows build.
13536 * WebCoreSupport/WebContextMenuClient.cpp:
13537 (WebContextMenuClient::isSpeaking):
13538 * WebCoreSupport/WebContextMenuClient.h:
13540 2009-06-29 David Hyatt <hyatt@apple.com>
13542 Reviewed by Adam Roben.
13544 Make sure to patch all configurations to have datagrid enabled.
13546 * WebKit.vcproj/WebKit.vcproj:
13548 2009-06-29 David Hyatt <hyatt@apple.com>
13550 Reviewed by Adam Roben.
13552 Put <datagrid> behind an ifdef.
13554 * WebKit.vcproj/WebKit.vcproj:
13556 2009-06-26 Brian Weinstein <bweinstein@apple.com>
13558 Reviewed by Simon Fraser.
13560 https://bugs.webkit.org/show_bug.cgi?id=26695
13562 Added hit testing on scrollbars, so if you start a gesture over a scrollbar,
13563 it isn't counted, and lets the user drag the scrollbar itself instead of a
13564 panning gesture. Also cleaned up code in gesture.
13567 (WebView::gestureNotify):
13568 (WebView::gesture):
13570 2009-06-26 Jeremy Orlow <jorlow@chromium.org>
13572 Reviewed by Adam Barth.
13574 https://bugs.webkit.org/show_bug.cgi?id=26767
13576 Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp
13577 despite it being deleted from the repo by the following patch/commit:
13578 https://bugs.webkit.org/show_bug.cgi?id=26732
13579 http://trac.webkit.org/changeset/45290
13583 2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
13585 Reviewed by Eric Seidel.
13587 Bug 20303: [Qt] Key events are not working in frames.
13589 Move the scroll handling code to EventHandler so that other
13590 ports can share the functionality.
13593 (WebView::keyDown):
13594 (EnumTextMatches::QueryInterface):
13596 2009-06-23 Anders Carlsson <andersca@apple.com>
13598 Reviewed by Darin Adler.
13600 WebKit side of <rdar://problem/6946094>.
13602 * Interfaces/IWebUIDelegate.idl:
13603 Add a newPasteboard out parameter to willPerformDragSourceAction.
13605 * WebCoreSupport/WebDragClient.cpp:
13606 (WebDragClient::willPerformDragSourceAction):
13607 Implement this. If the client returns a new pasteboard, use it for the drag.
13609 * WebCoreSupport/WebInspectorDelegate.h:
13610 (WebInspectorDelegate::willPerformDragSourceAction):
13611 Add the new parameter.
13613 2009-06-20 Darin Adler <darin@apple.com>
13615 Reviewed by Sam Weinig.
13617 <rdar://problem/6964221> Need more processing of pluginspage.
13619 * WebCoreSupport/WebFrameLoaderClient.cpp:
13620 (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
13622 2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
13624 Reviewed by Steve Falkenburg.
13626 https://bugs.webkit.org/show_bug.cgi?id=26494
13627 Bug 26494: RenderTheme::themeForPage reads from Settings before it has
13628 been initialized by WebKit
13630 Get the shouldPaintNativeControls preference and update the settings
13631 before initializing the page, as the page depends on it after the
13632 themeForPage change.
13635 (WebView::initWithFrame):
13637 2009-06-19 Brian Weinstein <bweinstein@apple.com>
13639 Reviewed by Steve Falkenburg.
13641 https://bugs.webkit.org/show_bug.cgi?id=26488
13642 No Support for Single Finger or Two Finger Panning in Windows 7
13644 Added the code necessary for single finger and two-finger panning with
13645 window bounce. We now register for WM_GESTURENOTIFY and WM_GESTURE messages,
13646 and interpret the panning command. Also, added WindowsTouch.h which contains
13647 structs and #defines from the Windows 7 SDK.
13649 * WebKit.vcproj/WebKit.vcproj:
13651 (WebView::gestureNotify): Checks if we are in a pannable region - IE: Not in the scrollbar
13652 (WebView::gesture): Handles the Panning gesture, creating the WheelEvent
13653 (WebViewWndProc): Added cases for WM_GESTURE and WM_GESTURENOTIFY
13655 * WindowsTouch.h: Added.
13657 2009-06-18 Adam Barth <abarth@webkit.org>
13659 Reviewed by Sam Weinig.
13661 https://bugs.webkit.org/show_bug.cgi?id=26199
13663 Added preference to enable the XSSAuditor.
13665 * Interfaces/IWebPreferencesPrivate.idl:
13666 * WebPreferenceKeysPrivate.h:
13667 * WebPreferences.cpp:
13668 (WebPreferences::initializeDefaultSettings):
13669 (WebPreferences::isXSSAuditorEnabled):
13670 (WebPreferences::setXSSAuditorEnabled):
13671 * WebPreferences.h:
13673 (WebView::notifyPreferencesChanged):
13675 2009-06-18 Brent Fulgham <bfulgham@gmail.com>
13677 Reviewed by Dave Levin.
13679 Remove some boilerplate using the BitmapInfo struct.
13680 https://bugs.webkit.org/show_bug.cgi?id=26425
13683 (WebFrame::spoolPages):
13684 * WebIconDatabase.cpp:
13686 * WebKit.vcproj/WebKit.sln:
13687 * WebNodeHighlight.cpp:
13688 (WebNodeHighlight::update):
13690 (WebView::ensureBackingStore):
13692 2009-06-17 Steve Falkenburg <sfalken@apple.com>
13694 Consolidate WebKit COM interfaces.
13695 Moved IID from the highest numbered COM interface to the first interface and combined all methods.
13697 Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.
13699 Reviewed by Adam Roben.
13701 * Interfaces/IWebFrameLoadDelegate.idl:
13702 * Interfaces/IWebFrameLoadDelegatePrivate.idl:
13703 * Interfaces/IWebResourceLoadDelegatePrivate.idl:
13704 * Interfaces/IWebUIDelegate.idl:
13705 * Interfaces/IWebUIDelegatePrivate.idl:
13706 * Interfaces/WebKit.idl:
13707 * WebCoreSupport/WebChromeClient.cpp:
13708 * WebCoreSupport/WebChromeClient.h:
13709 * WebCoreSupport/WebContextMenuClient.cpp:
13710 * WebCoreSupport/WebFrameLoaderClient.cpp:
13711 * WebCoreSupport/WebInspectorDelegate.h:
13715 2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
13717 Reviewed by Adam Roben.
13719 Create a different RenderTheme per page, so that RenderTheme has
13720 access to page specific theming. This is needed for the Qt port, as Qt
13721 supports setting the theme (style) per widget.
13723 This change was suggested and discussed with Dave Hyatt.
13727 1) Create a theme per page or one global one, depending on the needs
13729 2) Add an accesser to the theme from RenderObject.
13730 3) Change all uses of the theming to access the theme through
13731 RenderObject, using the global default theme as fallback, when the
13732 document of RenderObject has no page.
13733 When we don't have access to a RenderObject, use the default theme.
13734 4) Modify all RenderTheme platform implementations to work with the
13735 above changes, still creating only one global theme.
13738 (WebViewWndProc): Get the theme from the associated page.
13740 2009-06-16 Brian Weinstein <bweinstein@apple.com>
13742 Reviewed by Adam Roben.
13744 Switch Control+Mousewheel Zooming definitions to match other browsers on Windows.
13745 Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in.
13746 https://bugs.webkit.org/show_bug.cgi?id=25875.
13747 <rdar://problem/6903976>
13750 (WebView::mouseWheel):
13752 2009-06-16 Brent Fulgham <bfulgham@gmail.com>
13754 Reviewed by Darin Adler.
13756 Use consistent Windows GUID Comparison Functions.
13757 https://bugs.webkit.org/show_bug.cgi?id=26427.
13760 (EnumTextMatches::QueryInterface):
13762 == Rolled over to ChangeLog-2009-06-16 ==