1 2011-11-30 Alexey Proskuryakov <ap@apple.com>
3 Download page URL should be set by WebCore
4 https://bugs.webkit.org/show_bug.cgi?id=73358
6 Reviewed by Darin Adler.
8 * WebCoreSupport/WebFrameLoaderClient.h: Removed setOriginalURLForDownload, which is now
11 * WebCoreSupport/WebFrameLoaderClient.mm:
12 (WebFrameLoaderClient::download): There is no need to set original URL post factum any more.
13 (WebFrameLoaderClient::startDownload): Ditto.
15 2011-11-29 David Levin <levin@chromium.org>
17 Add a way to revert a variable to its previous value after leaving a scope.
18 https://bugs.webkit.org/show_bug.cgi?id=73371
20 Reviewed by Adam Barth.
22 * ForwardingHeaders/wtf/TemporarilyChange.h: Added.
24 2011-11-29 Jessie Berlin <jberlin@apple.com>
26 WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins
27 the first time it is called.
28 https://bugs.webkit.org/show_bug.cgi?id=73374 (<rdar://problem/10196057>)
30 Reviewed by Brady Eidson.
32 * Storage/WebStorageTrackerClient.h:
33 * Storage/WebStorageTrackerClient.mm:
34 (WebStorageTrackerClient::didFinishLoadingOrigins):
36 2011-11-15 Anders Carlsson <andersca@apple.com>
38 DragClient::dragSourceActionMaskForPoint should use root view coordinates
39 https://bugs.webkit.org/show_bug.cgi?id=72409
41 Reviewed by Sam Weinig.
43 * WebCoreSupport/WebDragClient.mm:
44 (WebDragClient::dragSourceActionMaskForPoint):
45 Use -[WebView _convertPointFromRootView:] to convert the point to the web view coordinate system.
47 2011-11-15 Anders Carlsson <andersca@apple.com>
49 EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates
50 https://bugs.webkit.org/show_bug.cgi?id=72408
52 Reviewed by Sam Weinig.
54 * WebCoreSupport/CorrectionPanel.mm:
55 (CorrectionPanel::show):
56 Convert the bounding rect to web view coordinates.
59 (-[WebView _convertPointFromRootView:]):
60 (-[WebView _convertRectFromRootView:]):
61 * WebView/WebViewInternal.h:
62 Add helper methods for converting from root view coordinates to web view coordinates.
64 2011-11-29 Roland Steiner <rolandsteiner@chromium.org>
66 <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
67 https://bugs.webkit.org/show_bug.cgi?id=72848
69 Reviewed by Dimitri Glazkov.
71 * Configurations/FeatureDefines.xcconfig:
73 2011-11-28 Jon Lee <jonlee@apple.com>
75 Create skeleton framework for notifications support in WK2
76 https://bugs.webkit.org/show_bug.cgi?id=73253
77 <rdar://problem/10356943>
79 Reviewed by Sam Weinig.
81 * Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
83 * WebCoreSupport/WebNotificationClient.h: Added.
84 (WebNotificationClient::webView):
85 * WebCoreSupport/WebNotificationClient.mm: Added. Implemented as stubs for now.
86 (WebNotificationClient::WebNotificationClient):
87 (WebNotificationClient::show):
88 (WebNotificationClient::cancel):
89 (WebNotificationClient::notificationObjectDestroyed):
90 (WebNotificationClient::requestPermission):
91 (WebNotificationClient::cancelRequestsForPermission):
92 (WebNotificationClient::checkPermission):
93 * WebView/WebView.mm: Set PageClient's notification client to an instance of this stubbed class.
95 2011-11-28 Adam Roben <aroben@apple.com>
97 Properly retain the OS X version string
99 Fixes <http://webkit.org/b/73214> REGRESSION (r101215): Crash on launch beneath +[WebView
100 _standardUserAgentWithApplicationName:]
102 Reviewed by Antti Koivisto.
104 * WebView/WebView.mm:
105 (createMacOSXVersionString): Retain the string we're returning, since this function is
106 supposed to return an owning reference to the caller.
108 2011-11-28 Hayato Ito <hayato@chromium.org>
110 Fix chromium canary build after r101215.
111 Unreviewed. Build fix.
113 * WebCoreSupport/WebSystemInterface.mm:
114 (InitWebCoreSystemInterface):
116 2011-11-27 Mark Rowe <mrowe@apple.com>
118 <http://webkit.org/b/72665> Switch to a more modern approach to retrieving the OS marketing version
120 Reviewed by Dan Bernstein.
122 * WebCoreSupport/WebSystemInterface.mm:
123 (InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.
124 * WebView/WebView.mm:
125 (createMacOSXVersionString): Use WKGetMacOSXVersionString.
127 2011-11-26 Pavel Feldman <pfeldman@google.com>
129 Web Inspector: remove disconnectFromBackend from the protocol.
130 https://bugs.webkit.org/show_bug.cgi?id=73127
132 Reviewed by Yury Semikhatsky.
134 * WebCoreSupport/WebInspectorClient.h:
135 * WebCoreSupport/WebInspectorClient.mm:
136 (WebInspectorClient::inspectorDestroyed):
137 (WebInspectorClient::closeInspectorFrontend):
139 2011-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
141 Unreviewed, rolling out r101193.
142 http://trac.webkit.org/changeset/101193
143 https://bugs.webkit.org/show_bug.cgi?id=73158
145 Breaks Windows and Qt minimal. (Requested by pfeldman on
148 * WebCoreSupport/WebInspectorClient.h:
149 * WebCoreSupport/WebInspectorClient.mm:
150 (WebInspectorClient::inspectorDestroyed):
152 2011-11-26 Pavel Feldman <pfeldman@google.com>
154 Web Inspector: remove disconnectFromBackend from the protocol.
155 https://bugs.webkit.org/show_bug.cgi?id=73127
157 Reviewed by Yury Semikhatsky.
159 * WebCoreSupport/WebInspectorClient.h:
160 * WebCoreSupport/WebInspectorClient.mm:
161 (WebInspectorClient::inspectorDestroyed):
162 (WebInspectorClient::closeInspectorFrontend):
164 2011-11-22 Pavel Feldman <pfeldman@google.com>
166 Web Inspector: remove Inspector::bringToFront from the protocol.
167 https://bugs.webkit.org/show_bug.cgi?id=72937
169 Reviewed by Yury Semikhatsky.
171 * WebCoreSupport/WebInspectorClient.h:
172 * WebCoreSupport/WebInspectorClient.mm:
173 (WebInspectorClient::openInspectorFrontend):
174 (WebInspectorClient::bringFrontendToFront):
176 2011-11-21 Mark Rowe <mrowe@apple.com>
178 Fix the SnowLeopard build.
180 * Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was
181 not yet declared in a public header.
183 2011-11-20 Mark Rowe <mrowe@apple.com>
185 <http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name
187 Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon
190 Reviewed by Dan Bernstein.
192 * Misc/WebNSFileManagerExtras.mm:
193 (-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy
194 the volume name from its description dictionary.
196 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
198 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
199 https://bugs.webkit.org/show_bug.cgi?id=62985
201 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
202 methods for plumbing the menu action handlers through the WebKit and WebCore.
203 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
204 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
205 WebKit/win and WebKit2 to follow.
207 Reviewed by Yury Semikhatsky.
209 * WebCoreSupport/WebInspectorClient.mm:
210 (-[WebInspectorWindowController destroyInspectorView:]):
211 * WebInspector/WebInspector.mm:
212 (-[WebInspector showWindow]):
213 (-[WebInspector show:]):
214 (-[WebInspector showConsole:]):
215 (-[WebInspector isDebuggingJavaScript]):
216 (-[WebInspector toggleDebuggingJavaScript:]):
217 (-[WebInspector startDebuggingJavaScript:]):
218 (-[WebInspector stopDebuggingJavaScript:]):
219 (-[WebInspector isProfilingJavaScript]):
220 (-[WebInspector toggleProfilingJavaScript:]):
221 (-[WebInspector startProfilingJavaScript:]):
222 (-[WebInspector stopProfilingJavaScript:]):
223 (-[WebInspector isJavaScriptProfilingEnabled]):
224 (-[WebInspector setJavaScriptProfilingEnabled:]):
225 (-[WebInspector isTimelineProfilingEnabled]):
226 (-[WebInspector setTimelineProfilingEnabled:]):
227 (-[WebInspector setFrontend:]):
228 (-[WebInspector releaseFrontend]):
229 (-[WebInspector showWindow:]):
230 * WebInspector/WebInspectorFrontend.h:
231 * WebInspector/WebInspectorFrontend.mm:
232 (-[WebInspectorFrontend isDebuggingEnabled]):
233 (-[WebInspectorFrontend setDebuggingEnabled:]):
234 (-[WebInspectorFrontend isProfilingJavaScript]):
235 (-[WebInspectorFrontend startProfilingJavaScript]):
236 (-[WebInspectorFrontend stopProfilingJavaScript]):
237 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
238 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
239 (-[WebInspectorFrontend isTimelineProfilingEnabled]):
240 (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
241 * WebInspector/WebInspectorPrivate.h:
243 2011-11-21 Jochen Eisinger <jochen@chromium.org>
245 Implement Meta referrer
246 https://bugs.webkit.org/show_bug.cgi?id=72674
248 Reviewed by Adam Barth.
250 * Plugins/Hosted/HostedNetscapePluginStream.mm:
251 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
252 * Plugins/WebNetscapePluginStream.mm:
253 (WebNetscapePluginStream::WebNetscapePluginStream):
255 2011-10-17 Antonio Gomes <agomes@rim.com>
257 Pass a Frame* parameter in EditorClient::respondToChangedSelection
258 https://bugs.webkit.org/show_bug.cgi?id=70248
260 Reviewed by Ryosuke Niwa.
262 * WebCoreSupport/WebEditorClient.h:
263 * WebCoreSupport/WebEditorClient.mm: Make use of the newly added Frame* parameter.
264 (WebEditorClient::respondToChangedSelection):
266 2011-11-17 Mark Rowe <mrowe@apple.com>
268 <http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
269 switch away from the deprecated APIs.
271 Reviewed by Sam Weinig.
273 * Plugins/WebBasePluginPackage.mm:
274 * Plugins/WebNetscapePluginPackage.mm:
275 (-[WebNetscapePluginPackage _tryLoad]):
277 2011-11-18 Anton D'Auria <adauria@apple.com>
279 bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true
280 https://bugs.webkit.org/show_bug.cgi?id=72568
282 Reviewed by David Kilzer.
284 WebChromeClient::shouldInterruptJavaScript called CallUIDelegate, which used an id
285 as the return value, which was then cast to a bool and always returned true. This
286 patch uses CallUIDelegateReturningBoolean instead of CallUIDelegate, with the default
289 * WebCoreSupport/WebChromeClient.mm:
290 (WebChromeClient::shouldInterruptJavaScript):
292 2011-11-16 Dan Bernstein <mitz@apple.com>
294 WebKit/mac part of <rdar://problem/10262242> Add API for paginated display
295 https://bugs.webkit.org/show_bug.cgi?id=72537
297 Reviewed by Anders Carlsson.
299 * WebView/WebView.mm:
300 (-[WebView _setPaginationMode:]): Added this accessor.
301 (-[WebView _paginationMode]): Ditto.
302 (-[WebView _setGapBetweenPages:]): Ditto.
303 (-[WebView _gapBetweenPages]): Ditto.
304 (-[WebView _pageCount]): Ditto.
305 * WebView/WebViewPrivate.h: Defined WebPaginationMode enum and values.
307 2011-11-15 Andy Estes <aestes@apple.com>
309 Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
310 https://bugs.webkit.org/show_bug.cgi?id=72106
312 Reviewed by Anders Carlsson.
314 Remove code that schedules layer flushes and use LayerFlushScheduler instead.
316 * WebView/WebView.mm:
317 (-[WebView _close]): Invalidate the run loop observer and destroy the
318 LayerFlushController.
319 (LayerFlushController::flushLayers): Perform the work that
320 layerSyncRunLoopObserverCallBack used to do.
321 (-[WebView _scheduleCompositingLayerSync]): If layerFlushController has
322 yet to be created, create it, then schedule a layer flush.
323 * WebView/WebViewData.h:
324 (LayerFlushController::create): Create a LayerFlushController that
325 implements the LayerFlushSchedulerClient interface and contains a
326 LayerFlushScheduler with itself as the client.
327 * WebView/WebViewData.mm:
328 (LayerFlushController::scheduleLayerFlush):
329 (LayerFlushController::invalidateObserver):
330 (LayerFlushController::LayerFlushController):
332 2011-11-15 Jochen Eisinger <jochen@chromium.org>
334 Rename ReferrerPolicy to clarify its meaning
335 https://bugs.webkit.org/show_bug.cgi?id=72420
337 Reviewed by Nate Chapin.
339 * WebView/WebPDFView.mm:
340 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
342 2011-11-15 Anders Carlsson <andersca@apple.com>
344 HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
345 https://bugs.webkit.org/show_bug.cgi?id=72397
347 Reviewed by Dan Bernstein.
349 * WebCoreSupport/WebChromeClient.h:
350 * WebCoreSupport/WebChromeClient.mm:
351 (WebChromeClient::screenToRootView):
352 (WebChromeClient::rootViewToScreen):
354 2011-11-14 Anders Carlsson <andersca@apple.com>
356 HostWindow invalidation functions should use root view coordinates
357 https://bugs.webkit.org/show_bug.cgi?id=72338
359 Reviewed by Dan Bernstein.
361 * WebCoreSupport/WebChromeClient.h:
362 * WebCoreSupport/WebChromeClient.mm:
363 (WebChromeClient::invalidateRootView):
364 (WebChromeClient::invalidateContentsAndRootView):
365 (WebChromeClient::invalidateContentsForSlowScroll):
367 2011-11-14 Julien Chaffraix <jchaffraix@webkit.org>
369 Add --css-grid-layout to build-webkit and the build systems
370 https://bugs.webkit.org/show_bug.cgi?id=72320
372 Reviewed by Ojan Vafai.
374 * Configurations/FeatureDefines.xcconfig:
376 2011-11-14 Tony Chang <tony@chromium.org>
378 Remove the CSS3_FLEXBOX compile time flag and enable on all ports
379 https://bugs.webkit.org/show_bug.cgi?id=72196
381 Reviewed by Ojan Vafai.
383 * Configurations/FeatureDefines.xcconfig:
385 2011-11-07 Adam Barth <abarth@webkit.org>
387 Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
388 https://bugs.webkit.org/show_bug.cgi?id=71755
390 Reviewed by Eric Seidel.
392 * Plugins/Hosted/HostedNetscapePluginStream.mm:
393 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
394 * Plugins/WebNetscapePluginStream.mm:
395 (WebNetscapePluginStream::WebNetscapePluginStream):
396 * WebView/WebView.mm:
397 (-[WebView _commonInitializationWithFrameName:groupName:]):
398 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
399 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
400 (+[WebView _resetOriginAccessWhitelists]):
402 2011-11-08 Joseph Pecoraro <pecoraro@apple.com>
404 Move NSRange / DOMRange functions back to WebFrameInternal
405 https://bugs.webkit.org/show_bug.cgi?id=71844
407 Reviewed by Alexey Proskuryakov.
409 * WebView/WebFrame.mm:
410 (-[WebFrame _convertNSRangeToDOMRange:]):
411 (-[WebFrame _convertDOMRangeToNSRange:]):
412 * WebView/WebFrameInternal.h:
413 * WebView/WebFramePrivate.h:
415 2011-11-08 Michael Saboff <msaboff@apple.com>
417 Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
418 https://bugs.webkit.org/show_bug.cgi?id=71761
420 Changed WKPCEvaluate() to use emptyString() when the source is
423 Reviewed by Gavin Barraclough.
425 * Plugins/Hosted/NetscapePluginHostProxy.mm:
428 2011-11-08 Beth Dakin <bdakin@apple.com>
430 https://bugs.webkit.org/show_bug.cgi?id=71856
431 WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of
432 old NSWindowDidChangeResolutionNotification
434 <rdar://problem/10317253>
436 Reviewed by Tim Hatcher.
438 * WebView/WebView.mm:
439 (-[WebView addWindowObserversForWindow:]):
440 (-[WebView removeWindowObservers]):
442 We have to check that the backing scale factor actually changed since this
443 notification can also be used to signify other changes.
444 (-[WebView _windowDidChangeBackingProperties:]):
446 2011-11-07 Adam Barth <abarth@webkit.org>
448 Move DomainRelaxationForbidden scheme registry to SchemeRegistry
449 https://bugs.webkit.org/show_bug.cgi?id=71750
451 Reviewed by Eric Seidel.
453 * WebView/WebView.mm:
454 (+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
456 2011-11-07 Jessie Berlin <jberlin@apple.com>
458 Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
460 https://bugs.webkit.org/show_bug.cgi?id=71631
462 Reviewed by Jon Honeycutt.
464 Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and
467 * WebView/WebView.mm:
468 (+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]):
469 Call through to the SchemeRegistry function.
470 (+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]):
472 * WebView/WebViewPrivate.h:
474 2011-11-03 Mark Hahnenberg <mhahnenberg@apple.com>
476 De-virtualize JSObject::getPropertyNames
477 https://bugs.webkit.org/show_bug.cgi?id=71306
479 Reviewed by Darin Adler.
481 Added getPropertyNames to the MethodTable, changed all the virtual
482 implementations of getPropertyNames to static ones, and replaced
483 all call sites with corresponding lookups in the MethodTable.
485 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
486 (WebKit::NetscapePluginInstanceProxy::enumerate):
488 2011-11-02 Darin Adler <darin@apple.com>
490 Change remaining callers of releaseRef to call leakRef
491 https://bugs.webkit.org/show_bug.cgi?id=71422
493 Reviewed by Darin Fisher.
495 * History/WebBackForwardList.mm:
496 (-[WebBackForwardList initWithBackForwardList:]):
497 * History/WebHistoryItem.mm:
498 (-[WebHistoryItem copyWithZone:]):
499 (-[WebHistoryItem initWithWebCoreHistoryItem:]):
500 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
501 (-[WebHostedNetscapePluginView createPlugin]):
502 * Plugins/WebNetscapePluginView.mm:
503 (-[WebNetscapePluginView createPlugin]):
504 * WebCoreSupport/WebOpenPanelResultListener.mm:
505 * WebView/WebDataSource.mm:
506 (-[WebDataSource _initWithDocumentLoader:]):
507 * WebView/WebResource.mm:
508 (-[WebResourcePrivate initWithCoreResource:]):
511 2011-11-02 Joseph Pecoraro <pecoraro@apple.com>
513 Move NSRange / DOMRange conversion functions to WebFramePrivate
514 https://bugs.webkit.org/show_bug.cgi?id=71435
516 Reviewed by Sam Weinig.
518 Move conversion functions to WebFramePrivate,
519 and remove the no longer used versions.
521 * WebView/WebFrame.mm:
522 (-[WebFrame _convertNSRangeToDOMRange:]):
523 (-[WebFrame _convertDOMRangeToNSRange:]):
524 * WebView/WebFrameInternal.h:
525 * WebView/WebFramePrivate.h:
527 2011-11-02 Dean Jackson <dino@apple.com>
529 Add ENABLE_CSS_SHADERS flag
530 https://bugs.webkit.org/show_bug.cgi?id=71394
532 Reviewed by Sam Weinig.
534 * Configurations/FeatureDefines.xcconfig:
536 2011-11-02 Jon Lee <jonlee@apple.com>
538 Expand DragController to provide more information about the dragging session
539 https://bugs.webkit.org/show_bug.cgi?id=71324
540 <rdar://problem/10379175>
542 Reviewed by Darin Adler.
544 * WebView/WebView.mm:
545 (-[WebView draggingEntered:]): DragOperation is now inside the DragSession struct.
546 (-[WebView draggingUpdated:]):
548 2011-11-02 Tom Sepez <tsepez@chromium.org>
551 https://bugs.webkit.org/show_bug.cgi?id=70973
553 Reviewed by Adam Barth.
555 * WebCoreSupport/WebFrameLoaderClient.h:
556 * WebCoreSupport/WebFrameLoaderClient.mm:
557 (WebFrameLoaderClient::didRunInsecureContent):
558 (WebFrameLoaderClient::didDetectXSS):
559 * WebView/WebDelegateImplementationCaching.h:
560 * WebView/WebFrameLoadDelegatePrivate.h:
561 * WebView/WebView.mm:
562 (-[WebView _cacheFrameLoadDelegateImplementations]):
564 2011-11-01 Darin Adler <darin@apple.com>
566 Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences
567 https://bugs.webkit.org/show_bug.cgi?id=71289
569 Reviewed by Dan Bernstein.
571 Just adding a null check. I don't have access to an actual PDF with
572 this problem but crashes from the field indicate they exist.
574 * WebView/WebPDFDocumentExtras.mm:
575 (allScriptsInPDFDocument): Skip the code to add the script text
576 to an array when the script is null.
578 2011-10-28 John Sullivan <sullivan@apple.com>
581 https://bugs.webkit.org/show_bug.cgi?id=71142
582 Whether backspace goes Back should be configurable
584 Reviewed by Sam Weinig.
586 * WebView/WebFrameView.mm:
587 (-[WebFrameView keyDown:]):
588 Honor the new preference.
590 * WebView/WebPreferenceKeysPrivate.h:
591 Added #define for WebKitBackspaceKeyNavigationEnabledKey
593 * WebView/WebPreferences.mm:
594 (+[WebPreferences initialize]):
595 Initialize new pref to YES, to match current behavior.
596 (-[WebPreferences setBackspaceKeyNavigationEnabled:]):
597 New method, standard prefs setter.
598 (-[WebPreferences backspaceKeyNavigationEnabled]):
599 New method, standard prefs getter.
601 * WebView/WebPreferencesPrivate.h:
602 Declared new methods.
604 * WebView/WebView.mm:
605 (-[WebView _preferencesChanged:]):
606 Updates WebCore settings from WebKit prefs.
608 2011-10-28 Jochen Eisinger <jochen@chromium.org>
610 Rename a number of methods mentioning JavaScript to just Script instead
611 https://bugs.webkit.org/show_bug.cgi?id=71105
613 Reviewed by Adam Barth.
615 * WebView/WebView.mm:
616 (-[WebView _preferencesChanged:]):
618 2011-10-27 Joseph Pecoraro <pecoraro@apple.com>
620 Reviewed by David Kilzer.
622 Make FeatureDefines Identical Across OS X Projects
623 https://bugs.webkit.org/show_bug.cgi?id=71051
625 * Configurations/FeatureDefines.xcconfig:
627 2011-10-27 Mark Hahnenberg <mhahnenberg@apple.com>
629 De-virtualize JSCell::toThisObject
630 https://bugs.webkit.org/show_bug.cgi?id=70958
632 Reviewed by Geoffrey Garen.
634 Converted all instances of toThisObject to static functions,
635 added toThisObject to the MethodTable, and replaced all call sites
636 with a corresponding lookup in the MethodTable.
638 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
639 (WebKit::NetscapePluginInstanceProxy::invoke):
640 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
642 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
644 Remove deletePropertyVirtual
645 https://bugs.webkit.org/show_bug.cgi?id=70738
647 Reviewed by Geoffrey Garen.
649 Removed all declarations and definitions of deletePropertyVirtual.
650 Also replaced all call sites to deletePropertyVirtual with a
651 corresponding lookup in the MethodTable.
653 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
654 (WebKit::NetscapePluginInstanceProxy::removeProperty):
656 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
659 https://bugs.webkit.org/show_bug.cgi?id=70740
661 Reviewed by Geoffrey Garen.
663 Removed all declarations and definitions of putVirtual.
664 Also replaced all call sites to putVirtual with a
665 corresponding lookup in the MethodTable.
667 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
668 (WebKit::NetscapePluginInstanceProxy::setProperty):
670 2011-10-24 Geoffrey Garen <ggaren@apple.com>
672 Removed SharedUChar and tightened language around its previous uses
673 https://bugs.webkit.org/show_bug.cgi?id=70698
675 Reviewed by David Levin.
677 - Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
678 the former names gave the dangerous misimpression that the resulting object
679 was thread-safe, which is not true.
681 * Storage/WebDatabaseTrackerClient.mm:
682 (DidModifyOriginData::dispatchToMainThread):
684 2011-10-24 Michael Saboff <msaboff@apple.com>
686 WebKit doesn't build with recent changes to libdispatch
687 https://bugs.webkit.org/show_bug.cgi?id=70737
689 Added initialization for new WebKitSystemInterface function
690 CreateVMPressureDispatchOnMainQueue.
692 Reviewed by Geoffrey Garen.
694 * WebCoreSupport/WebSystemInterface.mm:
695 (InitWebCoreSystemInterface):
697 2011-10-23 Mark Hahnenberg <mhahnenberg@apple.com>
699 Remove getConstructDataVirtual
700 https://bugs.webkit.org/show_bug.cgi?id=70638
702 Reviewed by Darin Adler.
704 Removed all declarations and definitions of getConstructDataVirtual.
705 Also replaced all call sites to getConstructDataVirtual with a
706 corresponding lookup in the MethodTable.
708 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
709 (WebKit::NetscapePluginInstanceProxy::construct):
711 2011-10-20 Ian Henderson <ianh@apple.com>
713 https://bugs.webkit.org/show_bug.cgi?id=70541
714 There are two WebFrameLoadDelegatePrivate categories on NSObject
716 Reviewed by David Kilzer.
718 * WebView/WebViewPrivate.h: Rename the private delegate categories in
719 WebViewPrivate.h with a "WebView" prefix to avoid collision.
721 2011-10-20 Alexey Proskuryakov <ap@apple.com>
723 REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in
724 https://bugs.webkit.org/show_bug.cgi?id=70534
725 <rdar://problem/10308827>
727 Reviewed by Darin Adler.
729 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Return true
730 for contextmenu event, so that plug-ins won't get a default WebKit context menu. We can't
731 know if the plug-in is handling mousedown (or even mouseup) by displaying a menu.
733 2011-10-19 Beth Dakin <bdakin@apple.com>
735 https://bugs.webkit.org/show_bug.cgi?id=70396
736 Focus rings are too thin in HiDPI in WebKit2
738 <rdar://problem/10086876>
740 Reviewed by Dan Bernstein.
742 Rename wkSetPatternBaseCTM to wkSetBaseCTM
743 * WebCoreSupport/WebSystemInterface.mm:
744 (InitWebCoreSystemInterface):
746 To create a HiDPI context in DRT, we have to set the base CTM, which currently
747 requires CG SPI, so we have to do it through WebKitSystemInterface.
748 * WebView/WebView.mm:
749 (-[WebView _setBaseCTM:forContext:]):
750 * WebView/WebViewPrivate.h:
752 2011-10-18 Adam Barth <abarth@webkit.org>
754 Always enable ENABLE(XPATH)
755 https://bugs.webkit.org/show_bug.cgi?id=70217
757 Reviewed by Eric Seidel.
759 * Configurations/FeatureDefines.xcconfig:
761 2011-10-14 Chris Marrin <cmarrin@apple.com>
763 Throttle rate of requestAnimationFrame when page is not visible
764 https://bugs.webkit.org/show_bug.cgi?id=67873
766 Reviewed by Anders Carlsson.
768 Plumb through notification when the window is hidden/shown or
769 minimized/unminimized
771 * WebView/WebView.mm:
772 (-[WebView _windowWillOrderOnScreen:]):
773 (-[WebView _windowWillOrderOffScreen:]):
775 2011-10-16 Adam Barth <abarth@webkit.org>
777 Always enable ENABLE(DOM_STORAGE)
778 https://bugs.webkit.org/show_bug.cgi?id=70189
780 Reviewed by Eric Seidel.
782 * Configurations/FeatureDefines.xcconfig:
783 * Storage/WebStorageManager.mm:
784 * Storage/WebStorageManagerInternal.h:
785 * Storage/WebStorageTrackerClient.h:
786 * Storage/WebStorageTrackerClient.mm:
787 (WebStorageTrackerClient::dispatchDidModifyOrigin):
788 * WebView/WebView.mm:
789 (-[WebView _commonInitializationWithFrameName:groupName:]):
791 2011-10-14 David Kilzer <ddkilzer@apple.com>
793 <http://webkit.org/b/70158> Fix clang compiler warnings
795 Reviewed by Darin Adler.
797 The following two methods in WebDelegateImplementationCaching.h
798 are ambiguous in WebChromeClient::runJavaScriptPrompt() because
799 the compiler can't decide how to convert the WTF::String
800 defaultText argument:
802 id CallUIDelegate(WebView *, SEL, id, id);
803 id CallUIDelegate(WebView *, SEL, id, BOOL);
805 The fix is to perform the conversion explicitly.
807 * WebCoreSupport/WebChromeClient.mm:
808 (WebChromeClient::runJavaScriptPrompt): Extract a defaultString
809 variable to convert the WTF::String to an NSString*, then
810 use defaultString in place of defaultText.
812 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
814 Rename virtual put to putVirtual
815 https://bugs.webkit.org/show_bug.cgi?id=69851
817 Reviewed by Darin Adler.
819 Renamed virtual versions of put to putVirtual in prepration for
820 adding the static put to the MethodTable in ClassInfo since the
821 compiler gets mad if the virtual and static versions have the same
824 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
825 (WebKit::NetscapePluginInstanceProxy::setProperty):
827 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
829 Rename virtual deleteProperty to deletePropertyVirtual
830 https://bugs.webkit.org/show_bug.cgi?id=69884
832 Reviewed by Darin Adler.
834 Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
835 adding the static deleteProperty to the MethodTable in ClassInfo since the
836 compiler gets mad if the virtual and static versions have the same name.
838 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
839 (WebKit::NetscapePluginInstanceProxy::removeProperty):
841 2011-10-12 Ryosuke Niwa <rniwa@webkit.org>
843 Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent
844 https://bugs.webkit.org/show_bug.cgi?id=69964
846 Reviewed by Enrica Casucci.
848 * WebView/WebFrame.mm:
849 (-[WebFrame _convertToNSRange:]):
850 (-[WebFrame _convertToDOMRange:]):
852 2011-10-13 Mark Hahnenberg <mhahnenberg@apple.com>
854 Rename virtual getConstructData to getConstructDataVirtual
855 https://bugs.webkit.org/show_bug.cgi?id=69872
857 Reviewed by Geoffrey Garen.
859 Renamed virtual getConstructData functions to getConstructDataVirtual to
860 avoid conflicts when we add static getConstructData to the MethodTable.
862 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
863 (WebKit::NetscapePluginInstanceProxy::construct):
865 2011-10-13 Beth Dakin <bdakin@apple.com>
867 https://bugs.webkit.org/show_bug.cgi?id=70050
868 DRT and WRT should have HiDPI testing capabilities
870 Reviewed by Darin Adler.
872 New method _backingScaleFactor matches SPI of a similar name that I added
873 recently to WKPage in WebKit2. Equivalent functionality is needed for
874 DumpRenderTree's HiDPI support.
875 * WebView/WebView.mm:
876 (-[WebView _backingScaleFactor]):
877 * WebView/WebViewPrivate.h:
879 2011-10-12 Chris Marrin <cmarrin@apple.com>
881 Sync requestAnimationFrame callback to CVDisplayLink on Mac
882 https://bugs.webkit.org/show_bug.cgi?id=68911
884 Reviewed by Simon Fraser.
886 Add windowDidChangeScreen function which listens for the window changing
887 screens and passes the new displayID along to WebCore::Page. It also sends
888 one on windowWillOrderOnScreen, so the Page has a fresh displayID after it's
891 * WebView/WebView.mm:
892 (-[WebView addWindowObserversForWindow:]):
893 (-[WebView removeWindowObservers]):
894 (-[WebView _windowDidChangeScreen:]):
895 (-[WebView _windowWillOrderOnScreen:]):
897 2011-10-12 Adam Barth <abarth@webkit.org>
899 Remove ENABLE(XHTMLMP) and associated code
900 https://bugs.webkit.org/show_bug.cgi?id=69729
902 Reviewed by David Levin.
904 * Configurations/FeatureDefines.xcconfig:
906 2011-10-10 Nate Chapin <japhet@chromium.org>
908 Use a CachedImageClient instead of CachedResourceClient
910 https://bugs.webkit.org/show_bug.cgi?id=69790
912 Reviewed by Adam Barth.
914 * WebView/WebHTMLView.mm:
915 (promisedDataClient):
917 2011-10-10 Mark Hahnenberg <mhahnenberg@apple.com>
919 Remove getCallDataVirtual methods
920 https://bugs.webkit.org/show_bug.cgi?id=69186
922 Reviewed by Geoffrey Garen.
924 Removed all getCallDataVirtual methods and replaced their call sites
925 with an explicit lookup in the MethodTable.
927 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
928 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
930 2011-10-10 Joseph Pecoraro <joepeck@webkit.org>
932 Extract WebOpenPanelResultListener out into its own file
933 https://bugs.webkit.org/show_bug.cgi?id=69575
935 Reviewed by David Kilzer.
937 Extract the WebOpenPanelResultListener class out into
938 its own file. No functional change.
940 * WebCoreSupport/WebChromeClient.mm:
941 * WebCoreSupport/WebOpenPanelResultListener.h: Added.
942 * WebCoreSupport/WebOpenPanelResultListener.mm: Added.
943 (-[WebOpenPanelResultListener dealloc]):
944 (-[WebOpenPanelResultListener finalize]):
945 (-[WebOpenPanelResultListener cancel]):
946 (-[WebOpenPanelResultListener chooseFilename:]):
947 (-[WebOpenPanelResultListener chooseFilenames:]):
948 * WebView/WebUIDelegate.h:
950 2011-10-08 Sheriff Bot <webkit.review.bot@gmail.com>
952 Unreviewed, rolling out r96996.
953 http://trac.webkit.org/changeset/96996
954 https://bugs.webkit.org/show_bug.cgi?id=69697
956 It broke all tests on the Qt bot (Requested by Ossy_night on
959 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
960 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
962 2011-10-07 Mark Hahnenberg <mhahnenberg@apple.com>
964 Remove getCallDataVirtual methods
965 https://bugs.webkit.org/show_bug.cgi?id=69186
967 Reviewed by Geoffrey Garen.
969 Removed all getCallDataVirtual methods and replaced their call sites
970 with an explicit lookup in the MethodTable.
972 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
973 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
975 2011-10-06 Anders Carlsson <andersca@apple.com>
977 When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
978 https://bugs.webkit.org/show_bug.cgi?id=69586
980 Reviewed by Darin Adler.
982 * Configurations/Base.xcconfig:
983 Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.
985 2011-10-06 Anders Carlsson <andersca@apple.com>
987 Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
988 https://bugs.webkit.org/show_bug.cgi?id=69584
990 Reviewed by Darin Adler.
992 Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.
994 * Plugins/Hosted/HostedNetscapePluginStream.mm:
995 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
997 2011-10-03 Andy Estes <aestes@apple.com>
999 Add an option to suppress rendering until the document's load event fires.
1000 https://bugs.webkit.org/show_bug.cgi?id=69298
1002 Reviewed by Simon Fraser.
1004 Add a new private WebPreference.
1006 * WebView/WebPreferenceKeysPrivate.h:
1007 * WebView/WebPreferences.mm:
1008 (+[WebPreferences initialize]):
1009 (-[WebPreferences setSuppressRenderingWhileInitiallyLoading:]):
1010 (-[WebPreferences suppressRenderingWhileInitiallyLoading]):
1011 * WebView/WebPreferencesPrivate.h:
1012 * WebView/WebView.mm:
1013 (-[WebView _preferencesChanged:]):
1015 2011-10-05 Jer Noble <jer.noble@apple.com>
1017 Enable WEB_AUDIO by default in the WebKit/mac port.
1018 https://bugs.webkit.org/show_bug.cgi?id=68587
1020 Reviewed by Simon Fraser.
1022 * Configurations/FeatureDefines.xcconfig:
1024 2011-10-05 David Kilzer <ddkilzer@apple.com>
1026 <http://webkit.org/b/69386> REGRESSION: Curious Location of StorageTracker.db
1028 Reviewed by Alexey Proskuryakov.
1030 * Storage/WebStorageManager.mm:
1031 (+[WebStorageManager _storageDirectoryPath]): Restore call to
1032 -[NSString stringByStandardizingPath]. Also fix over-release of
1033 sLocalStoragePath if the initial -objectForKey: call returned an
1034 NSString object. Use pthread_once to be thread-safe.
1036 2011-10-04 Kent Tamura <tkent@chromium.org>
1038 Introduce feature flags for incomplete input types
1039 https://bugs.webkit.org/show_bug.cgi?id=68971
1041 Reviewed by Hajime Morita.
1043 * Configurations/FeatureDefines.xcconfig:
1044 Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.
1046 2011-10-03 Geoffrey Garen <ggaren@apple.com>
1048 Some JSValue cleanup
1049 https://bugs.webkit.org/show_bug.cgi?id=69320
1051 Reviewed by Darin Adler.
1053 * WebView/WebView.mm:
1054 (aeDescFromJSValue): Updated for JSC changes.
1056 2011-10-04 Scott Graham <scottmg@chromium.org>
1058 Add GAMEPAD feature flag
1059 https://bugs.webkit.org/show_bug.cgi?id=66859
1061 Reviewed by Darin Fisher.
1063 * Configurations/FeatureDefines.xcconfig:
1065 2011-10-03 Jer Noble <jer.noble@apple.com>
1067 Unreviewed, rolling out r96526.
1068 http://trac.webkit.org/changeset/96526
1069 https://bugs.webkit.org/show_bug.cgi?id=68587
1071 WEB_AUDIO has numerous 64->32 bit casting warnings, causing
1072 build breakages where -Wall is enabled.
1074 * Configurations/FeatureDefines.xcconfig:
1076 2011-10-03 Jer Noble <jer.noble@apple.com>
1078 Enable WEB_AUDIO by default in the WebKit/mac port.
1079 https://bugs.webkit.org/show_bug.cgi?id=68587
1081 Reviewed by Simon Fraser.
1083 * Configurations/FeatureDefines.xcconfig:
1085 2011-10-02 Sam Weinig <sam@webkit.org>
1087 Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
1088 https://bugs.webkit.org/show_bug.cgi?id=69230
1090 Reviewed by Anders Carlsson.
1092 * WebView/WebHTMLRepresentation.mm:
1094 (searchForLabelsBeforeElement):
1095 (matchLabelsAgainstString):
1096 (matchLabelsAgainstElement):
1097 (-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
1098 (-[WebHTMLRepresentation matchLabels:againstElement:]):
1100 2011-10-02 Alexey Proskuryakov <ap@apple.com>
1102 REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
1103 https://bugs.webkit.org/show_bug.cgi?id=68542
1105 Reviewed by Mark Rowe.
1107 * WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.
1109 2011-10-01 Geoffrey Garen <ggaren@apple.com>
1111 Leopard build fix: Updated for Strong<T> changes.
1113 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1114 * WebView/WebScriptDebugger.mm:
1116 2011-09-28 Joseph Pecoraro <joepeck@webkit.org>
1118 ASSERT if WebView's UIDelegate does not implement webView:runOpenPanel
1119 https://bugs.webkit.org/show_bug.cgi?id=69037
1121 Reviewed by Alexey Proskuryakov.
1123 * WebCoreSupport/WebChromeClient.mm:
1124 (WebChromeClient::runOpenPanel):
1125 If no delegate is implemented, dismiss the listener
1126 with a cancel. It expects some action.
1128 2011-09-28 Anton D'Auria <adauria@apple.com>
1130 Expose +[WebStorageManager _storageDirectoryPath] as SPI
1131 https://bugs.webkit.org/show_bug.cgi?id=68951
1133 Reviewed by Brady Eidson.
1135 This patch exposes +[WebStorageManager _storageDirectoryPath], which
1136 pulls the path from NSUserDefaults if the preference is set. Otherwise,
1137 it falls back on the default path.
1139 * Storage/WebStorageManager.mm:
1140 (+[WebStorageManager _storageDirectoryPath]): Adding static variable
1141 so that we don't reread user defaults repeatedly.
1142 (WebKitInitializeStorageIfNecessary):
1143 * Storage/WebStorageManagerPrivate.h:
1145 2011-09-27 Andy Estes <aestes@apple.com>
1147 WebKitLinkedOnOrAfter() check is ineffective for Solar Walk app-specific hack.
1148 https://bugs.webkit.org/show_bug.cgi?id=68863
1150 Reviewed by Darin Adler.
1152 The SolarWalk binary does not link against WebKit.framework directly,
1153 so calling NSVersionOfLinkTimeLibrary() will not return the version of
1154 WebKit against which SolarWalk was linked. Since Solar Walk has
1155 released an update that addresses the issue for which this app-specific
1156 hack was originally added, we should just remove the hack.
1158 * Misc/SolarWalkQuirksUserScript.js: Removed.
1159 * WebView/WebView.mm: Removed needsSolarWalkQuirksScript(),
1160 leakSolarWalkQuirksUserScriptContents(), and
1161 -[WebView _injectSolarWalkQuirksScript].
1162 (-[WebView _commonInitializationWithFrameName:groupName:]): Do not
1163 inject the Solar Walk quirks script.
1165 2011-09-27 Mark Hahnenberg <mhahnenberg@apple.com>
1167 Add static version of JSCell::getCallData
1168 https://bugs.webkit.org/show_bug.cgi?id=68741
1170 Reviewed by Darin Adler.
1172 In this patch we just extract the bodies of the virtual getCallData methods
1173 throughout the JSCell inheritance hierarchy out into static methods, which are
1174 now called from the virtual methods. This is an intermediate step in trying to
1175 move the virtual-ness of getCallData into our own method table stored in
1176 ClassInfo. We need to convert the methods to static methods because static methods
1177 can be represented as function pointers rather than pointers to member functions, and
1178 function pointers are smaller and faster to call than pointers to member functions.
1180 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1181 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1183 2011-09-23 Simon Fraser <simon.fraser@apple.com>
1185 Repaint tests don't work in WebKit2
1186 https://bugs.webkit.org/show_bug.cgi?id=68453
1188 Reviewed by Sam Weinig.
1190 Have FrameView keep track of repaint rects when asked to, and
1191 expose this set of repaint rects via private WebKit API for later
1192 use by DumpRenderTree.
1194 * WebView/WebView.mm:
1195 (-[WebView setTracksRepaints:]):
1196 (-[WebView isTrackingRepaints]):
1197 (-[WebView resetTrackedRepaints]):
1198 (-[WebView trackedRepaintRects]):
1199 * WebView/WebViewPrivate.h:
1201 2011-09-25 Mark Hahnenberg <mhahnenberg@apple.com>
1203 Add custom vtable struct to ClassInfo struct
1204 https://bugs.webkit.org/show_bug.cgi?id=68567
1206 Reviewed by Oliver Hunt.
1208 Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
1209 specified class in its ClassInfo. Also added to it the first function to use
1210 this macro, visitChildren. This is part of the process of getting rid of all
1211 C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
1212 that can't easily be converted to non-virtual functions will be put into
1213 this custom vtable structure.
1215 * Plugins/Hosted/ProxyInstance.mm:
1216 * Plugins/Hosted/ProxyRuntimeObject.mm:
1218 2011-09-24 Adam Barth <abarth@webkit.org>
1220 Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1221 https://bugs.webkit.org/show_bug.cgi?id=68767
1223 Reviewed by Eric Seidel.
1225 * Configurations/FeatureDefines.xcconfig:
1227 (+[WebCache empty]):
1228 * WebCoreSupport/WebApplicationCache.mm:
1229 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
1230 (-[WebApplicationCacheQuotaManager usage]):
1231 (-[WebApplicationCacheQuotaManager quota]):
1232 (-[WebApplicationCacheQuotaManager setQuota:]):
1233 * WebCoreSupport/WebChromeClient.h:
1234 * WebCoreSupport/WebChromeClient.mm:
1235 * WebView/WebDataSource.mm:
1236 (-[WebDataSource _transferApplicationCache:]):
1237 * WebView/WebFrame.mm:
1238 (-[WebFrame _cacheabilityDictionary]):
1239 * WebView/WebView.mm:
1240 (WebKitInitializeApplicationCachePathIfNecessary):
1242 2011-09-23 Adam Klein <adamk@chromium.org>
1244 Add ENABLE_MUTATION_OBSERVERS feature flag
1245 https://bugs.webkit.org/show_bug.cgi?id=68732
1247 Reviewed by Ojan Vafai.
1249 This flag will guard an implementation of the "Mutation Observers" proposed in
1250 http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
1252 * Configurations/FeatureDefines.xcconfig:
1254 2011-09-23 Anders Carlsson <andersca@apple.com>
1256 Axe WebImageRendererFactory
1257 https://bugs.webkit.org/show_bug.cgi?id=68715
1259 Reviewed by Darin Adler.
1261 Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.
1263 * WebCoreSupport/WebImageRendererFactory.m: Removed.
1265 2011-09-23 Anders Carlsson <andersca@apple.com>
1267 Add OVERRIDE to a bunch of virtual member functions on clients
1268 https://bugs.webkit.org/show_bug.cgi?id=68712
1270 Reviewed by Sam Weinig.
1272 * Configurations/Base.xcconfig:
1273 * WebCoreSupport/WebChromeClient.h:
1274 * WebCoreSupport/WebContextMenuClient.h:
1275 * WebCoreSupport/WebDeviceOrientationClient.h:
1276 * WebCoreSupport/WebDragClient.h:
1277 * WebCoreSupport/WebEditorClient.h:
1278 * WebCoreSupport/WebFrameLoaderClient.h:
1279 * WebCoreSupport/WebFrameNetworkingContext.h:
1280 * WebCoreSupport/WebGeolocationClient.h:
1281 * WebCoreSupport/WebIconDatabaseClient.h:
1282 * WebCoreSupport/WebInspectorClient.h:
1283 * WebCoreSupport/WebPlatformStrategies.h:
1285 2011-09-22 Dean Jackson <dino@apple.com>
1287 Add ENABLE_CSS_FILTERS
1288 https://bugs.webkit.org/show_bug.cgi?id=68652
1290 Reviewed by Simon Fraser.
1292 * Configurations/FeatureDefines.xcconfig:
1294 2011-09-22 Anders Carlsson <andersca@apple.com>
1296 Get rid of Widget::setBoundsSize
1297 https://bugs.webkit.org/show_bug.cgi?id=68491
1299 Reviewed by Sam Weinig.
1301 This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
1302 which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
1303 anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
1304 will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.
1306 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1307 (-[WebHostedNetscapePluginView updateAndSetWindow]):
1308 * WebView/WebFrameView.mm:
1310 2011-09-19 Jer Noble <jer.noble@apple.com>
1312 Add settings to control the availability of the Web Audio API to WebKit and WebKit2.
1313 https://bugs.webkit.org/show_bug.cgi?id=68382
1315 Reviewed by Darin Adler.
1317 Initialize the webAudioEnabled preference to NO by default.
1319 * WebView/WebPreferences.mm:
1320 (+[WebPreferences initialize]):
1322 2011-09-21 Anders Carlsson <andersca@apple.com>
1324 Remove checks for Leopard-only Objective-C APIs
1325 https://bugs.webkit.org/show_bug.cgi?id=68579
1327 Reviewed by Sam Weinig.
1329 We can always assume that OBJC_API_VERSION is at least 2, it's been 2 since Leopard.
1331 * Misc/WebNSObjectExtras.h:
1333 2011-09-21 Andras Becsi <andras.becsi@nokia.com>
1335 [Qt] Remove Qt specific code from css/SelectorChecker.cpp
1336 https://bugs.webkit.org/show_bug.cgi?id=67702
1338 Reviewed by Csaba Osztrogonác.
1340 * WebCoreSupport/WebPlatformStrategies.h:
1341 * WebCoreSupport/WebPlatformStrategies.mm:
1342 (WebPlatformStrategies::isLinkVisited):
1344 2011-09-20 Anders Carlsson <andersca@apple.com>
1346 Remove ScrollView::platformContentsSize
1347 https://bugs.webkit.org/show_bug.cgi?id=68188
1349 Reviewed by Darin Adler.
1351 When creating the document view, make sure it's zero sized which matches the initial size
1352 of the ScrollView. This is fine to do early since DocumentWriter::begin sets the contents
1353 size to a zero size anyway.
1355 * WebView/WebFrameView.mm:
1356 (-[WebFrameView _makeDocumentViewForDataSource:]):
1358 2011-09-19 Pavel Feldman <pfeldman@google.com>
1360 Web Inspector: streamline Console's MessageType and MessageSource semantics.
1361 https://bugs.webkit.org/show_bug.cgi?id=68342
1363 This change fixes semantics of the MessageSource and MessageType:
1364 MessageSource is now the source of the message (be it Network, HTML
1365 parser or Console API). MessageType is only defined for the Console API
1366 messages and contains the name of the API call (log, dir, dirxml, etc.).
1367 Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
1368 private to the inspector.
1370 Reviewed by Tony Gentilcore.
1372 * WebCoreSupport/WebChromeClient.mm:
1373 (stringForMessageSource):
1374 (stringForMessageType):
1375 * WebView/WebUIDelegatePrivate.h:
1377 2011-09-19 Timothy Hatcher <timothy@apple.com>
1379 Make WebViews in NSPopovers render as they would in active windows.
1381 The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
1382 are shown or hidden since they share key with the parent window. So WebView
1383 and WebHTMLView need to also observe the will order on/off screen notifications.
1385 https://webkit.org/b/68402
1386 rdar://problem/9754099
1388 Reviewed by John Sullivan.
1390 * WebView/WebHTMLView.mm:
1391 (-[WebHTMLView _removeWindowObservers]): Remove order on/off screen notification obversers.
1392 (-[WebHTMLView addWindowObservers]): Add order on/off screen notification obversers.
1393 (-[WebHTMLView windowWillOrderOnScreen:]): Check if the window is already a key window,
1394 which can be the case for NSPopovers.
1395 (-[WebHTMLView windowWillOrderOffScreen:]): Remove the mouse moved observer.
1396 * WebView/WebView.mm:
1397 (-[WebView addWindowObserversForWindow:]): Add order off screen notification obverser.
1398 (-[WebView removeWindowObservers]): Remove order off screen notification obverser.
1399 (-[WebView _windowWillOrderOnScreen:]): Call _updateActiveState.
1400 (-[WebView _windowWillOrderOffScreen:]): Ditto.
1402 2011-09-19 Mark Rowe <mrowe@apple.com>
1404 <http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect
1406 On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking
1407 in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and
1408 a NoIdleSleep assertion as the latter is implied by the former.
1410 Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController.
1412 Reviewed by Dan Bernstein.
1414 * WebView/WebFullScreenController.h:
1415 * WebView/WebFullScreenController.mm:
1416 (-[WebFullScreenController dealloc]):
1417 (-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
1418 display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
1419 disabler that we own.
1421 2011-09-19 Adam Barth <abarth@webkit.org>
1423 Always enable ENABLE(EVENTSOURCE)
1424 https://bugs.webkit.org/show_bug.cgi?id=68414
1426 Reviewed by Eric Seidel.
1428 * Configurations/FeatureDefines.xcconfig:
1430 2011-09-19 Anders Carlsson <andersca@apple.com>
1432 Fix crashes when running WebKit1 tests.
1434 -[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
1435 equivalent code directly into -[WebHTMLView drawRect:].
1437 * WebView/WebHTMLView.mm:
1438 (-[WebHTMLView drawRect:]):
1439 * WebView/WebViewInternal.h:
1441 2011-09-19 Anders Carlsson <andersca@apple.com>
1443 Remove the last remains of viewless WebKit1
1444 https://bugs.webkit.org/show_bug.cgi?id=68388
1446 Reviewed by Darin Adler.
1448 * WebCoreSupport/WebFrameLoaderClient.mm:
1449 (WebFrameLoaderClient::forceLayoutForNonHTML):
1452 * WebView/WebView.mm:
1453 (-[WebView _commonInitializationWithFrameName:groupName:]):
1454 Remove usesDocumentViews parameter and checks.
1456 (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
1457 Add an assertion that usesDocumentViews is always true.
1459 (-[WebView _isUsingAcceleratedCompositing]):
1460 Remove usesDocumentViews check.
1462 (-[WebView _isSoftwareRenderable]):
1463 Remove usesDocumentViews check.
1465 (-[WebView initWithFrame:frameName:groupName:]):
1466 Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.
1468 (-[WebView initWithCoder:]):
1469 Remove usesDocumentViews parameter.
1471 (-[WebView _frameViewAtWindowPoint:]):
1472 Remove usesDocumentViews check.
1474 * WebView/WebViewData.h:
1475 Remove usesDocumentViews ivar.
1477 * WebView/WebViewPrivate.h:
1478 Remove usesDocumentViews parameters.
1480 2011-09-19 Anders Carlsson <andersca@apple.com>
1482 Remove WebViewEventHandling.mm
1483 https://bugs.webkit.org/show_bug.cgi?id=68387
1485 Reviewed by Adam Roben.
1487 WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
1488 we're getting rid of viewless WebKit1.
1490 * WebView/WebView.mm:
1491 (-[WebView _close]):
1492 * WebView/WebViewData.h:
1493 * WebView/WebViewEventHandling.mm: Removed.
1494 * WebView/WebViewInternal.h:
1496 2011-09-19 Anders Carlsson <andersca@apple.com>
1498 Remove -[WebView _selectionChanged] and -[WebView _setTooltip:]
1499 https://bugs.webkit.org/show_bug.cgi?id=68385
1501 Reviewed by Adam Roben.
1503 Move these functions back into the respective clients and remove usesDocumentViews checks.
1505 * WebCoreSupport/WebChromeClient.mm:
1506 (WebChromeClient::setToolTip):
1507 * WebCoreSupport/WebEditorClient.mm:
1508 (WebEditorClient::respondToChangedSelection):
1509 * WebView/WebView.mm:
1510 * WebView/WebViewEventHandling.mm:
1511 * WebView/WebViewInternal.h:
1513 2011-09-19 Anders Carlsson <andersca@apple.com>
1515 Begin removing -[WebView _usesDocumentCalls] from WebView.mm
1516 https://bugs.webkit.org/show_bug.cgi?id=68383
1518 Reviewed by Adam Roben.
1520 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
1521 returns true, since viewless WebKit1 has been abandoned.
1523 * WebView/WebView.mm:
1524 (-[WebView selectedFrame]):
1525 (-[WebView setHostWindow:]):
1526 (-[WebView acceptsFirstResponder]):
1527 (-[WebView becomeFirstResponder]):
1528 (-[WebView _webcore_effectiveFirstResponder]):
1529 (-[WebView setNextKeyView:]):
1530 (-[WebView setHoverFeedbackSuspended:]):
1532 2011-09-19 Anders Carlsson <andersca@apple.com>
1534 Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
1535 https://bugs.webkit.org/show_bug.cgi?id=68379
1537 Reviewed by Adam Roben.
1539 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
1540 returns true, since viewless WebKit1 has been abandoned.
1542 * WebCoreSupport/WebFrameLoaderClient.mm:
1543 (WebFrameLoaderClient::hasHTMLView):
1544 (WebFrameLoaderClient::dispatchDidCommitLoad):
1545 (WebFrameLoaderClient::transitionToCommittedForNewPage):
1546 (WebFrameLoaderClient::createFrame):
1547 * WebView/WebFrame.mm:
1548 (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1549 (-[WebFrame _hasSelection]):
1550 (-[WebFrame _clearSelection]):
1551 (-[WebFrame _shouldFlattenCompositingLayers:]):
1552 (-[WebFrame _dragSourceEndedAt:operation:]):
1553 (-[WebFrame frameView]):
1555 2011-09-19 Anders Carlsson <andersca@apple.com>
1557 Remove calls to -[WebView _usesDocumentViews]
1558 https://bugs.webkit.org/show_bug.cgi?id=68377
1560 Reviewed by Adam Roben.
1562 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
1563 returns true, since viewless WebKit1 has been abandoned.
1565 * WebCoreSupport/WebChromeClient.mm:
1566 (WebChromeClient::windowResizerRect):
1567 (WebChromeClient::invalidateContentsAndWindow):
1568 (WebChromeClient::screenToWindow):
1569 (WebChromeClient::windowToScreen):
1570 (WebChromeClient::platformPageClient):
1571 (WebChromeClient::scrollRectIntoView):
1572 (WebChromeClient::print):
1573 * WebView/WebDataSource.mm:
1574 (-[WebDataSource _receivedData:]):
1576 2011-09-19 Dan Bernstein <mitz@apple.com>
1578 WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
1579 https://bugs.webkit.org/show_bug.cgi?id=68323
1581 Reviewed by Sam Weinig.
1583 Renamed NonBlockingPanel to WebNonBlockingPanel.
1584 Renamed ThreadEnabler to WebCocoaThreadingEnabler.
1585 Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.
1587 * Misc/WebIconDatabase.mm:
1588 (+[WebCocoaThreadingEnabler enableThreading]):
1589 (importToWebCoreFormat):
1590 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
1591 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
1592 * Panels/WebAuthenticationPanel.h:
1593 * Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to
1594 WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
1595 cause nightly builds to log an error message when showing the Safari
1596 HTTP authentication sheet and disable the Quit command while the sheet
1598 * WebView/WebPDFView.mm:
1599 (-[WebPDFView initWithFrame:]):
1600 (-[WebPDFView _updatePreferencesSoon]):
1602 2011-09-17 Mihai Parparita <mihaip@chromium.org>
1604 FrameLoaderClient BackForwardList-related methods are unsued
1605 https://bugs.webkit.org/show_bug.cgi?id=68293
1607 Reviewed by Darin Adler.
1609 Remove FrameLoaderClient methods that were added by r51629, since only
1610 the old (since-deleted) Android port needed them.
1612 * WebCoreSupport/WebFrameLoaderClient.h:
1613 * WebCoreSupport/WebFrameLoaderClient.mm:
1616 2011-09-16 Simon Fraser <simon.fraser@apple.com>
1618 Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
1619 https://bugs.webkit.org/show_bug.cgi?id=68134
1621 Reviewed by Sam Weinig.
1623 Hook up a private preference that enables the mock scrollbar theme.
1625 * WebView/WebPreferenceKeysPrivate.h:
1626 * WebView/WebPreferences.mm:
1627 (-[WebPreferences mockScrollbarsEnabled]):
1628 (-[WebPreferences setMockScrollbarsEnabled:]):
1629 * WebView/WebPreferencesPrivate.h:
1631 2011-09-15 Adam Barth <abarth@webkit.org>
1633 Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
1634 https://bugs.webkit.org/show_bug.cgi?id=68205
1636 Reviewed by Eric Seidel.
1638 * Storage/WebDatabaseManager.mm:
1639 * Storage/WebDatabaseManagerInternal.h:
1640 * Storage/WebDatabaseManagerPrivate.h:
1641 * Storage/WebDatabaseQuotaManager.mm:
1642 (-[WebDatabaseQuotaManager usage]):
1643 (-[WebDatabaseQuotaManager quota]):
1644 (-[WebDatabaseQuotaManager setQuota:]):
1645 * Storage/WebDatabaseTrackerClient.h:
1646 * Storage/WebDatabaseTrackerClient.mm:
1647 * WebCoreSupport/WebChromeClient.h:
1648 * WebCoreSupport/WebChromeClient.mm:
1649 * WebCoreSupport/WebSecurityOrigin.mm:
1650 (-[WebSecurityOrigin usage]):
1651 (-[WebSecurityOrigin quota]):
1652 (-[WebSecurityOrigin setQuota:]):
1653 * WebView/WebFrame.mm:
1654 (-[WebFrame _cacheabilityDictionary]):
1655 * WebView/WebView.mm:
1656 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
1657 (-[WebView _preferencesChanged:]):
1659 2011-09-15 Mark Hahnenberg <mhahnenberg@apple.com>
1661 Unzip initialization lists and constructors in JSCell hierarchy (7/7)
1662 https://bugs.webkit.org/show_bug.cgi?id=68122
1664 Reviewed by Geoffrey Garen.
1666 Completed the seventh and final level of the refactoring to add finishCreation()
1667 methods to all classes within the JSCell hierarchy with non-trivial
1670 * Plugins/Hosted/ProxyInstance.mm:
1671 (WebKit::ProxyRuntimeMethod::create):
1672 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
1673 * Plugins/Hosted/ProxyRuntimeObject.h:
1674 (WebKit::ProxyRuntimeObject::create):
1675 * Plugins/Hosted/ProxyRuntimeObject.mm:
1676 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1678 2011-09-15 Kentaro Hara <haraken@google.com>
1680 A single line must not be split into two pages.
1681 https://bugs.webkit.org/show_bug.cgi?id=65005
1683 Reviewed by David Hyatt.
1685 When the document width of a page is overflowed, the last line of the page can be
1686 split into the next page. This is the regression caused by r88737. r88737 tried to
1687 fix rounding errors in rendering calculations by expanding and shrinking a page
1688 using one common method, resizePageRectsKeepingRatio(), but overlooked the case where
1689 a document width gets overflowed.
1691 Test: printing/single-line-must-not-be-split-into-two-pages.html
1693 * WebView/WebHTMLView.mm:
1694 (-[WebHTMLView _web_setPrintingModeRecursive]): Passes an original page size to setPrinting().
1695 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
1696 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
1697 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Ditto.
1698 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Ditto.
1699 (-[WebHTMLView _endPrintMode]): Ditto.
1700 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): Ditto.
1701 (-[WebHTMLView _endScreenPaginationMode]): Ditto.
1702 (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]): Ditto.
1703 (-[WebHTMLView layout]): Ditto.
1704 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): Ditto.
1705 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1706 (-[WebHTMLView setPageWidthForPrinting:]): Ditto.
1708 2011-09-15 Eric Seidel <eric@webkit.org>
1710 Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
1711 https://bugs.webkit.org/show_bug.cgi?id=68182
1713 Reviewed by Adam Barth.
1715 * Configurations/FeatureDefines.xcconfig:
1717 2011-09-15 Eric Seidel <eric@webkit.org>
1719 Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
1720 https://bugs.webkit.org/show_bug.cgi?id=68022
1722 Reviewed by Ryosuke Niwa.
1724 * Configurations/FeatureDefines.xcconfig:
1726 2011-09-14 Anders Carlsson <andersca@apple.com>
1728 Get rid of WebCoreViewFactory and its WebViewFactory subclass
1729 https://bugs.webkit.org/show_bug.cgi?id=68124
1731 Reviewed by Sam Weinig.
1733 * WebCoreSupport/WebContextMenuClient.mm:
1734 * WebCoreSupport/WebViewFactory.h: Removed.
1735 * WebCoreSupport/WebViewFactory.mm: Removed.
1736 * WebView/WebFrameView.mm:
1737 (-[WebFrameView initWithFrame:]):
1739 2011-09-14 Mark Hahnenberg <mhahnenberg@apple.com>
1741 Unzip initialization lists and constructors in JSCell hierarchy (6/7)
1742 https://bugs.webkit.org/show_bug.cgi?id=67692
1744 Reviewed by Geoffrey Garen.
1746 Completed the sixth level of the refactoring to add finishCreation()
1747 methods to all classes within the JSCell hierarchy with non-trivial
1750 This primarily consists of pushing the calls to finishCreation() down
1751 into the constructors of the subclasses of the fifth level of the hierarchy
1752 as well as pulling the finishCreation() calls out into the class's corresponding
1753 create() method if it has one. Doing both simultaneously allows us to
1754 maintain the invariant that the finishCreation() method chain is called exactly
1755 once during the creation of an object, since calling it any other number of
1756 times (0, 2, or more) will cause an assertion failure.
1758 * Plugins/Hosted/ProxyInstance.mm:
1759 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
1760 (WebKit::ProxyRuntimeMethod::finishCreation):
1762 2011-09-13 Eric Seidel <eric@webkit.org>
1764 Remove ENABLE_SVG_USE as <use> is required by HTML5
1765 https://bugs.webkit.org/show_bug.cgi?id=68019
1767 Reviewed by Ryosuke Niwa.
1769 * Configurations/FeatureDefines.xcconfig:
1771 2011-09-13 Anders Carlsson <andersca@apple.com>
1773 Disable C++ exceptions when building with clang
1774 https://bugs.webkit.org/show_bug.cgi?id=68031
1775 <rdar://problem/9556880>
1777 Reviewed by Mark Rowe.
1779 * Configurations/Base.xcconfig:
1781 2011-09-13 Eric Seidel <eric@webkit.org>
1783 Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
1784 https://bugs.webkit.org/show_bug.cgi?id=68018
1786 Reviewed by Ryosuke Niwa.
1788 * Configurations/FeatureDefines.xcconfig:
1790 2011-09-09 Oliver Hunt <oliver@apple.com>
1792 Remove support for anonymous storage from jsobjects
1793 https://bugs.webkit.org/show_bug.cgi?id=67881
1795 Reviewed by Sam Weinig.
1797 Remove the use of AnonymousSlotCount
1799 * Plugins/Hosted/ProxyInstance.mm:
1800 (WebKit::ProxyRuntimeMethod::createStructure):
1801 * Plugins/Hosted/ProxyRuntimeObject.h:
1802 (WebKit::ProxyRuntimeObject::createStructure):
1804 2011-09-09 Chris Marrin <cmarrin@apple.com>
1806 requestAnimationFrame doesn't throttle on Mac
1807 https://bugs.webkit.org/show_bug.cgi?id=67171
1809 Reviewed by Simon Fraser.
1811 Removed runLoopObserver for requestAnimationFrame. It's now
1812 done by a Timer in ScriptedAnimationController in WebCore.
1814 * WebCoreSupport/WebChromeClient.h:
1815 * WebCoreSupport/WebChromeClient.mm:
1816 * WebView/WebView.mm:
1817 (-[WebView _close]):
1818 * WebView/WebViewData.h:
1819 * WebView/WebViewInternal.h:
1821 2011-09-09 Fady Samuel <fsamuel@chromium.org>
1823 Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp}
1824 https://bugs.webkit.org/show_bug.cgi?id=67250
1826 Reviewed by Simon Fraser.
1828 * WebView/WebView.mm:
1829 (-[WebView _scaleWebView:atOrigin:]):
1830 (-[WebView _viewScaleFactor]):
1832 2011-09-09 Mark Hahnenberg <mhahnenberg@apple.com>
1834 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
1835 https://bugs.webkit.org/show_bug.cgi?id=67420
1837 Reviewed by Geoffrey Garen.
1839 Completed the fifth level of the refactoring to add finishCreation()
1840 methods to all classes within the JSCell hierarchy with non-trivial
1843 This primarily consists of pushing the calls to finishCreation() down
1844 into the constructors of the subclasses of the second level of the hierarchy
1845 as well as pulling the finishCreation() calls out into the class's corresponding
1846 create() method if it has one. Doing both simultaneously allows us to
1847 maintain the invariant that the finishCreation() method chain is called exactly
1848 once during the creation of an object, since calling it any other number of
1849 times (0, 2, or more) will cause an assertion failure.
1851 * Plugins/Hosted/ProxyRuntimeObject.h:
1852 * Plugins/Hosted/ProxyRuntimeObject.mm:
1853 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1854 (WebKit::ProxyRuntimeObject::finishCreation):
1856 2011-09-08 Sam Weinig <sam@webkit.org>
1858 Remove the Completion object from JSC, I have never liked it
1859 https://bugs.webkit.org/show_bug.cgi?id=67755
1861 Reviewed by Gavin Barraclough.
1863 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1864 (WebKit::NetscapePluginInstanceProxy::evaluate):
1866 2011-09-07 Sheriff Bot <webkit.review.bot@gmail.com>
1868 Unreviewed, rolling out r94627 and r94632.
1869 http://trac.webkit.org/changeset/94627
1870 http://trac.webkit.org/changeset/94632
1871 https://bugs.webkit.org/show_bug.cgi?id=67698
1873 It broke tests on GTK and Qt (Requested by Ossy on #webkit).
1875 * Plugins/Hosted/ProxyRuntimeObject.h:
1876 * Plugins/Hosted/ProxyRuntimeObject.mm:
1877 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1879 2011-09-06 Mark Hahnenberg <mhahnenberg@apple.com>
1881 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
1882 https://bugs.webkit.org/show_bug.cgi?id=67420
1884 Reviewed by Geoffrey Garen.
1886 Completed the fifth level of the refactoring to add finishCreation()
1887 methods to all classes within the JSCell hierarchy with non-trivial
1890 This primarily consists of pushing the calls to finishCreation() down
1891 into the constructors of the subclasses of the second level of the hierarchy
1892 as well as pulling the finishCreation() calls out into the class's corresponding
1893 create() method if it has one. Doing both simultaneously allows us to
1894 maintain the invariant that the finishCreation() method chain is called exactly
1895 once during the creation of an object, since calling it any other number of
1896 times (0, 2, or more) will cause an assertion failure.
1898 * Plugins/Hosted/ProxyRuntimeObject.h:
1899 * Plugins/Hosted/ProxyRuntimeObject.mm:
1900 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
1901 (WebKit::ProxyRuntimeObject::finishCreation):
1903 2011-09-06 Ryosuke Niwa <rniwa@webkit.org>
1905 Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
1906 https://bugs.webkit.org/show_bug.cgi?id=67569
1908 Reviewed by Antonio Gomes.
1910 * WebView/WebHTMLView.mm:
1911 (-[WebHTMLView _updateSelectionForInputManager]):
1913 2011-09-05 Oliver Hunt <oliver@apple.com>
1915 An object's structure should reference the global object responsible for its creation
1916 https://bugs.webkit.org/show_bug.cgi?id=67624
1918 Reviewed by Gavin Barraclough.
1920 Update for new Structure::create() globalObject parameter.
1922 * Plugins/Hosted/ProxyInstance.mm:
1923 (WebKit::ProxyRuntimeMethod::createStructure):
1924 * Plugins/Hosted/ProxyRuntimeObject.h:
1925 (WebKit::ProxyRuntimeObject::createStructure):
1927 2011-09-01 Mark Rowe <mrowe@apple.com>
1929 Fix the build by adding some more missing return types.
1931 * WebView/WebDashboardRegion.h:
1932 * WebView/WebDashboardRegion.mm:
1933 (-[WebDashboardRegion initWithRect:clip:type:]):
1935 2011-09-01 Tim Horton <timothy_horton@apple.com>
1937 REGRESSION: Rendering artifacts on a rotated, pattern filled shape
1938 https://bugs.webkit.org/show_bug.cgi?id=53055
1939 <rdar://problem/8910917>
1941 Reviewed by Simon Fraser.
1943 Introduce wkCGPatternCreateWithImageAndTransform.
1945 * WebCoreSupport/WebSystemInterface.mm:
1946 (InitWebCoreSystemInterface):
1948 2011-08-31 Beth Dakin <bdakin@apple.com>
1950 https://bugs.webkit.org/show_bug.cgi?id=67322
1951 Re-name overrideBackingScaleFactor
1953 Reviewed by John Sullivan.
1955 _setOverrideBackingScaleFactor is now _setCustomBackingScaleFactor
1956 * WebView/WebView.mm:
1957 (-[WebView _setCustomBackingScaleFactor:]):
1958 (-[WebView _deviceScaleFactor]):
1959 * WebView/WebViewData.h:
1960 * WebView/WebViewPrivate.h:
1962 2011-08-30 Dan Bernstein <mitz@apple.com>
1964 <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
1965 https://bugs.webkit.org/show_bug.cgi?id=67230
1967 Reviewed by Darin Adler.
1969 * WebView/WebHTMLView.mm:
1970 * WebView/WebView.mm:
1971 (coreOptions): Moved this function from WebHTMLView.mm to here and made
1972 it accessible from both this file and WebHTMLView.mm.
1973 (-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API.
1974 * WebView/WebViewInternal.h:
1975 * WebView/WebViewPrivate.h:
1977 2011-08-30 Beth Dakin <bdakin@apple.com>
1979 https://bugs.webkit.org/show_bug.cgi?id=67150
1980 Would like API to use a custom device scale factor for a particular WebView/WKView
1982 <rdar://problem/10041016>
1984 Reviewed by Darin Adler.
1986 New API is _setOverrideBackingScaleFactor:(CGFloat)
1987 * WebView/WebView.mm:
1988 (-[WebView _setOverrideBackingScaleFactor:]):
1989 (-[WebView _deviceScaleFactor]):
1990 * WebView/WebViewData.h:
1991 * WebView/WebViewPrivate.h:
1993 2011-08-30 Aaron Colwell <acolwell@chromium.org>
1995 Add MediaSource API to HTMLMediaElement
1996 https://bugs.webkit.org/show_bug.cgi?id=64731
1998 Reviewed by Eric Carlson.
2000 * Configurations/FeatureDefines.xcconfig:
2002 2011-08-29 Alexey Proskuryakov <ap@apple.com>
2004 DumpRenderTree should begin each test with an empty cookie store
2005 https://bugs.webkit.org/show_bug.cgi?id=63545
2006 <rdar://problem/5666907>
2008 Reviewed by Darin Adler.
2010 * WebView/WebPreferences.mm:
2011 (+[WebPreferences initialize]):
2012 (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2013 (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
2014 * WebView/WebPreferencesPrivate.h:
2015 Exposed an SPI to use a private default session. It's separate from private browsing,
2016 because some tests enable the latter, and we don't want to mix them up.
2017 Also exposed an SPI to set cookie accept policy regardless of what session we are currently
2020 * WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): Updated to use currentStorageSession()
2021 instead of privateBrowsingStorageSession().
2023 2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
2025 The unused ScrollView* argument can and should be removed from
2027 https://bugs.webkit.org/show_bug.cgi?id=67117
2029 Reviewed by Darin Adler.
2031 * WebCoreSupport/WebChromeClient.h:
2032 * WebCoreSupport/WebChromeClient.mm:
2033 (WebChromeClient::scrollRectIntoView):
2035 2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
2037 Unreviewed, rolling out r93987, r93992, r93995, r93998, and
2039 http://trac.webkit.org/changeset/93987
2040 http://trac.webkit.org/changeset/93992
2041 http://trac.webkit.org/changeset/93995
2042 http://trac.webkit.org/changeset/93998
2043 http://trac.webkit.org/changeset/93999
2044 https://bugs.webkit.org/show_bug.cgi?id=67147
2046 Many failing tests (Requested by ap on #webkit).
2048 * WebView/WebPreferences.mm:
2049 (+[WebPreferences initialize]):
2050 * WebView/WebPreferencesPrivate.h:
2052 2011-08-26 Alexey Proskuryakov <ap@apple.com>
2054 DumpRenderTree should begin each test with an empty cookie store
2055 https://bugs.webkit.org/show_bug.cgi?id=63545
2056 <rdar://problem/5666907>
2058 Reviewed by Darin Adler.
2060 * WebView/WebPreferences.mm:
2061 (+[WebPreferences initialize]):
2062 (+[WebPreferences _usePrivateSessionForNetworkLoading]):
2063 * WebView/WebPreferencesPrivate.h:
2064 Exposed an SPI to use a private default session. It's separate from private browsing,
2065 because some tests enable the latter, and we don't want to mix them up.
2067 2011-08-23 Chris Marrin <cmarrin@apple.com>
2069 [mac] requestAnimationFrame support for mac port
2070 https://bugs.webkit.org/show_bug.cgi?id=59146
2072 Reviewed by Simon Fraser.
2074 Implement requestAnimationFrame for WebKit. Add a
2075 CFRunLoopObserver to WebView, which runs just before
2076 the syncCompositingState RLO and calls into the
2077 ScriptedAnimationController if scheduleAnimation() has
2080 * Configurations/FeatureDefines.xcconfig:
2081 * WebCoreSupport/WebChromeClient.h:
2082 * WebCoreSupport/WebChromeClient.mm:
2083 (WebChromeClient::scheduleAnimation):
2084 * WebView/WebView.mm:
2085 (-[WebView _close]):
2086 (-[WebView _unscheduleAnimation]):
2087 (-[WebView _scheduleCompositingLayerSync]):
2088 (requestAnimationFrameRunLoopObserverCallback):
2089 (-[WebView _scheduleAnimation]):
2090 * WebView/WebViewData.h:
2091 * WebView/WebViewInternal.h:
2093 2011-08-24 Alexey Proskuryakov <ap@apple.com>
2095 Plug-in tests are flaky on Mac
2096 https://bugs.webkit.org/show_bug.cgi?id=66822
2098 Reviewed by Anders Carlsson.
2100 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2101 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
2102 Protect objects that can be removed by a script.
2104 * WebView/WebFrame.mm:
2105 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
2106 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto.
2107 Also fixed some nonsense code.
2109 2011-08-23 Mark Hahnenberg <mhahnenberg@apple.com>
2111 Add checks to ensure allocation does not take place during initialization of GC-managed objects
2112 https://bugs.webkit.org/show_bug.cgi?id=65288
2114 Reviewed by Darin Adler.
2116 Adding the new validation functionality. In its current state, it will performs checks,
2117 but they don't fail unless you do allocation in the arguments to the parent constructor in the
2118 initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
2119 allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
2120 allowed in constructor bodies while other refactoring efforts continue.
2122 * Plugins/Hosted/ProxyRuntimeObject.h:
2123 (WebKit::ProxyRuntimeObject::create):
2124 * Plugins/Hosted/ProxyRuntimeObject.mm:
2125 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
2127 2011-08-18 Beth Dakin <bdakin@apple.com>
2129 Reviewed by Sam Weinig.
2131 https://bugs.webkit.org/show_bug.cgi?id=66495
2132 Lion-specific scroller SPIs can use forward declaration instead of
2133 WebKitSystemInterface
2135 * WebCoreSupport/WebSystemInterface.mm:
2136 (InitWebCoreSystemInterface):
2138 2011-08-18 Anders Carlsson <andersca@apple.com>
2140 More C++0x libc++ build fixes
2141 https://bugs.webkit.org/show_bug.cgi?id=66476
2143 Reviewed by Adam Roben.
2145 * Plugins/Hosted/NetscapePluginHostProxy.mm:
2147 Use a WTF String here instead of an STL string.
2149 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2150 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
2151 std::make_pair now takes rvalue references, so get rid of the template arguments and let
2152 the compiler deduce them instead.
2154 2011-08-18 Adam Roben <aroben@apple.com>
2156 Update the device scale factor when the WebView's window changes
2158 Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
2159 WebView is moved between windows with different backing scale factors
2161 Reviewed by Anders Carlsson.
2163 * WebView/WebView.mm:
2164 (-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
2165 window at all) might have a different backing scale factor than the previous one.
2166 (-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.
2168 2011-08-17 Adam Roben <aroben@apple.com>
2170 Make WebCore keep track of the current device scale factor
2172 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
2175 Reviewed by Darin Adler.
2177 * WebCoreSupport/WebChromeClient.h:
2178 * WebCoreSupport/WebChromeClient.mm:
2179 Moved code to calculate the device scale factor from here...
2181 * WebView/WebView.mm:
2182 (-[WebView _deviceScaleFactor]):
2185 (-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.
2187 2011-08-17 Dan Bernstein <mitz@apple.com>
2189 Removed some code that is not needed when building for Leopard or later.
2191 Reviewed by Anders Carlsson.
2193 * WebCoreSupport/WebContextMenuClient.mm:
2194 (fixMenusToSendToOldClients): Removed check for Tiger Mail.
2195 * WebCoreSupport/WebFrameLoaderClient.mm:
2196 (WebFrameLoaderClient::objectContentType):
2197 * WebView/WebView.mm:
2198 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2199 (-[WebView _preferencesChanged:]):
2201 2011-08-17 Dan Bernstein <mitz@apple.com>
2203 Eliminate the WebCGFloat compatibility definition that was needed for Tiger.
2205 Rubber-stamped by Anders Carlsson.
2207 * WebView/WebHTMLViewPrivate.h:
2209 2011-08-17 Dan Bernstein <mitz@apple.com>
2211 Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
2214 Reviewed by Darin Adler.
2216 * History/WebBackForwardList.h:
2217 * WebView/WebDocumentInternal.h:
2218 * WebView/WebHTMLRepresentation.h:
2219 * WebView/WebPreferences.h:
2220 * WebView/WebResourceLoadDelegate.h:
2221 * WebView/WebResourceLoadDelegatePrivate.h:
2222 * WebView/WebScriptDebugDelegate.h:
2223 * WebView/WebTextIterator.h:
2224 * WebView/WebUIDelegate.h:
2225 * WebView/WebView.h:
2226 * WebView/WebViewPrivate.h:
2228 2011-08-15 Dmitry Titov <dimich@chromium.org>
2230 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
2231 https://bugs.webkit.org/show_bug.cgi?id=66165
2233 Reviewed by Darin Fisher.
2235 * WebCoreSupport/WebFrameLoaderClient.h:
2236 * WebCoreSupport/WebFrameLoaderClient.mm:
2237 (WebFrameLoaderClient::transferLoadingResourceFromPage):
2239 2011-08-15 Mark Hahnenberg <mhahnenberg@apple.com>
2241 Refactor JS objects to allocate in static create methods rather than constructors
2242 https://bugs.webkit.org/show_bug.cgi?id=65347
2244 Reviewed by Geoffrey Garen.
2246 Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
2247 larger refactoring to get rid of all allocation during initialization.
2249 * Plugins/Hosted/ProxyInstance.mm:
2250 (WebKit::ProxyRuntimeMethod::create):
2251 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2253 2011-08-15 Adam Roben <aroben@apple.com>
2255 Update pages' style and content scale when the window's backing scale factor changes
2257 Unfortunately, I couldn't think of a way to test this in an automated fashion.
2259 Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
2260 scale factor changes
2262 Reviewed by Simon Fraser.
2264 * WebView/WebView.mm:
2265 (-[WebView addWindowObserversForWindow:]):
2266 (-[WebView removeWindowObservers]):
2267 Listen for the notification that tells us the window's backing scale has changed.
2269 (-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale
2270 factor so that, e.g., scale-factor-dependent media queries will be reevaluated.
2272 2011-08-10 Adam Roben <aroben@apple.com>
2274 Clear up scale factor terminology
2276 WebKit by and large deals with two scale factors: one intrinsic to the device on which the
2277 software is running, and one that is per-Page and can be controlled via API calls. This
2278 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
2279 code use those names. It should introduce no behavior changes.
2281 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
2284 Reviewed by Simon Fraser.
2286 * Misc/WebNSControlExtras.m:
2287 (-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
2288 AppKit scale factor terminology. (This is unrelated to the rest of the patch.)
2290 * WebCoreSupport/WebChromeClient.h:
2291 * WebCoreSupport/WebChromeClient.mm:
2293 2011-08-13 Dan Bernstein <mitz@apple.com>
2295 Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
2297 Reviewed by Joseph Pecoraro.
2299 * WebView/WebPreferenceKeysPrivate.h:
2301 2011-08-13 Sam Weinig <sam@webkit.org>
2303 Remove unused variables from WebView/WebFullScreenController.h
2304 https://bugs.webkit.org/show_bug.cgi?id=66194
2306 Reviewed by Dan Bernstein.
2308 * WebView/WebFullScreenController.h:
2309 Remove a few variables which were not used.
2311 2011-08-12 Dan Bernstein <mitz@apple.com>
2313 Add an option to automatically show tooltips (with the full text) over truncated text
2314 https://bugs.webkit.org/show_bug.cgi?id=66178
2316 Reviewed by Simon Fraser.
2318 * WebView/WebPreferenceKeysPrivate.h: Defined a preference key.
2319 * WebView/WebPreferences.mm:
2320 (+[WebPreferences initialize]): Added a default value of NO for the
2321 ShowsToolTipOverTruncatedText preference.
2322 (-[WebPreferences showsToolTipOverTruncatedText]): Added this getter.
2323 (-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter.
2324 * WebView/WebPreferencesPrivate.h:
2325 * WebView/WebView.mm:
2326 (-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText().
2328 2011-08-12 Sam Weinig <sam@webkit.org>
2330 Use __builtin_trap() for CRASH when building with clang
2331 https://bugs.webkit.org/show_bug.cgi?id=66152
2333 Reviewed by Anders Carlsson.
2335 * Plugins/WebBaseNetscapePluginView.mm:
2336 (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
2337 (-[WebBaseNetscapePluginView handleMouseMoved:]):
2338 (-[WebBaseNetscapePluginView handleMouseEntered:]):
2339 (-[WebBaseNetscapePluginView handleMouseExited:]):
2340 (-[WebBaseNetscapePluginView focusChanged]):
2341 (-[WebBaseNetscapePluginView windowFocusChanged:]):
2342 (-[WebBaseNetscapePluginView createPlugin]):
2343 (-[WebBaseNetscapePluginView loadStream]):
2344 (-[WebBaseNetscapePluginView shouldStop]):
2345 (-[WebBaseNetscapePluginView destroyPlugin]):
2346 (-[WebBaseNetscapePluginView updateAndSetWindow]):
2347 (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
2348 (-[WebBaseNetscapePluginView pluginLayer]):
2349 (-[WebBaseNetscapePluginView getFormValue:]):
2350 Remove the ASSERT_NOT_REACHED from the base class methods. They were not
2351 adding much value and were getting in the way of making the static analyzer
2352 work. A better way to do this would be to use a formal protocol.
2354 2011-08-12 Mark Rowe <mrowe@apple.com>
2356 Be more forward-looking in the choice of compiler.
2358 Rubber-stamped by Jon Honeycutt.
2360 * Configurations/CompilerVersion.xcconfig:
2362 2011-08-10 David Hyatt <hyatt@apple.com>
2364 https://bugs.webkit.org/show_bug.cgi?id=66004
2366 Removing the CSS Regions and Exclusions ifdefs.
2368 Reviewed by Adam Roben.
2370 * Configurations/FeatureDefines.xcconfig:
2372 2011-08-09 Mark Hahnenberg <mhahnenberg@apple.com>
2374 Add ParentClass typedef in all JSC classes
2375 https://bugs.webkit.org/show_bug.cgi?id=65731
2377 Reviewed by Oliver Hunt.
2379 Just added the Base typedefs in all the classes that are a subclass of JSCell
2380 to point at their parent classes. This is a change to support future changes to the way
2381 constructors and destructors are implemented in JS objects, among other things.
2383 * Plugins/Hosted/ProxyInstance.mm:
2384 * Plugins/Hosted/ProxyRuntimeObject.h:
2386 2011-08-08 Chris Marrin <cmarrin@apple.com>
2388 Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState
2389 https://bugs.webkit.org/show_bug.cgi?id=65708
2391 Supply initial display rects for the full-screen case
2393 Reviewed by Simon Fraser.
2395 * WebView/WebFullScreenController.mm:
2396 (-[WebFullScreenController enterFullscreen:]):
2397 (-[WebFullScreenController exitFullscreen]):
2399 2011-08-06 Joseph Pecoraro <joepeck@webkit.org>
2401 Potential Leaks - RetainPtr<> over retaining Create'd objects
2402 https://bugs.webkit.org/show_bug.cgi?id=65806
2404 Reviewed by Darin Adler.
2406 Fix a possible leak by adopting an allocation instead of retaining it.
2408 * WebView/WebView.mm:
2409 (-[WebView previousValidKeyView]):
2411 2011-08-05 Anders Carlsson <andersca@apple.com>
2414 https://bugs.webkit.org/show_bug.cgi?id=65729
2416 Reviewed by Darin Adler.
2418 Remove plug-in halter and associated classes.
2420 * Plugins/WebBaseNetscapePluginView.h:
2421 * Plugins/WebBaseNetscapePluginView.mm:
2422 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
2423 (-[WebBaseNetscapePluginView start]):
2424 (-[WebBaseNetscapePluginView stop]):
2425 * WebCoreSupport/WebPluginHalterClient.h: Removed.
2426 * WebCoreSupport/WebPluginHalterClient.mm: Removed.
2427 * WebView/WebPreferenceKeysPrivate.h:
2428 * WebView/WebPreferences.mm:
2429 (+[WebPreferences initialize]):
2430 * WebView/WebPreferencesPrivate.h:
2431 * WebView/WebView.mm:
2432 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2433 (-[WebView _preferencesChanged:]):
2434 * WebView/WebViewPrivate.h:
2436 2011-08-04 Mark Rowe <mrowe@apple.com>
2438 Future-proof Xcode configuration settings.
2440 * Configurations/Base.xcconfig:
2441 * Configurations/DebugRelease.xcconfig:
2442 * Configurations/Version.xcconfig:
2443 * Configurations/WebKit.xcconfig:
2445 2011-08-03 Kent Tamura <tkent@chromium.org>
2447 Fix incorrect checks for HTMLMediaElement
2448 https://bugs.webkit.org/show_bug.cgi?id=65590
2450 Reviewed by Dimitri Glazkov.
2452 <video> and <audio> can be an HTMLElement instance instead of
2453 HTMLMediaElement if MediaPlayer::isAvailable() returns false or
2454 the media feature is disabled at runtime.
2456 * WebView/WebFullScreenController.mm:
2457 (-[WebFullScreenController _isAnyMoviePlaying]):
2459 2011-08-03 Mark Rowe <mrowe@apple.com>
2461 Bring some order to FeatureDefines.xcconfig to make it easier to follow.
2463 Reviewed by Sam Weinig.
2465 * Configurations/FeatureDefines.xcconfig:
2467 2011-08-03 Mark Rowe <mrowe@apple.com>
2469 Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
2471 Reviewed by Dave Kilzer.
2473 * Configurations/FeatureDefines.xcconfig:
2475 2011-08-03 Joseph Pecoraro <joepeck@webkit.org>
2477 Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
2478 https://bugs.webkit.org/show_bug.cgi?id=65582
2480 Reviewed by Pavel Feldman.
2482 * WebCoreSupport/WebInspectorClient.h:
2483 * WebCoreSupport/WebInspectorClient.mm:
2485 2011-08-03 Pavel Feldman <pfeldman@google.com>
2487 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
2488 https://bugs.webkit.org/show_bug.cgi?id=65510
2490 Reviewed by Yury Semikhatsky.
2492 * WebInspector/WebNodeHighlightView.mm:
2493 (-[WebNodeHighlightView drawRect:]):
2495 2011-08-03 Pavel Feldman <pfeldman@chromium.org>
2497 Web Inspector: remove Node parameter from the InspectorClient::highlight
2498 https://bugs.webkit.org/show_bug.cgi?id=65549
2500 Reviewed by Yury Semikhatsky.
2502 * WebCoreSupport/WebInspectorClient.h:
2503 * WebCoreSupport/WebInspectorClient.mm:
2504 (WebInspectorClient::highlight):
2505 * WebInspector/WebNodeHighlighter.h:
2506 * WebInspector/WebNodeHighlighter.mm:
2507 (-[WebNodeHighlighter highlight]):
2509 2011-07-30 Patrick Gansterer <paroga@webkit.org>
2511 Remove inclusion of MainThread.h from Threading.h
2512 https://bugs.webkit.org/show_bug.cgi?id=65081
2514 Reviewed by Darin Adler.
2516 Add missing include statements for MainThread.
2518 * Carbon/CarbonWindowAdapter.mm:
2519 * History/WebBackForwardList.mm:
2520 * History/WebHistoryItem.mm:
2521 * Misc/WebElementDictionary.mm:
2522 * Misc/WebIconDatabase.mm:
2523 * Misc/WebLocalizableStrings.mm:
2524 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2525 * Plugins/WebBaseNetscapePluginView.mm:
2526 * Plugins/WebBasePluginPackage.mm:
2527 * Plugins/WebNetscapePluginView.mm:
2528 * WebCoreSupport/WebEditorClient.mm:
2529 * WebCoreSupport/WebFrameLoaderClient.mm:
2530 * WebView/WebArchive.mm:
2531 * WebView/WebDataSource.mm:
2532 * WebView/WebHTMLView.mm:
2533 * WebView/WebResource.mm:
2534 * WebView/WebTextIterator.mm:
2535 * WebView/WebView.mm:
2536 * WebView/WebViewData.mm:
2538 2011-07-28 Dan Bernstein <mitz@apple.com>
2540 <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds
2542 Reviewed by Darin Adler.
2544 * WebCoreSupport/WebSystemInterface.mm:
2545 (InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters.
2547 2011-07-28 Brady Eidson <beidson@apple.com>
2549 <rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306
2550 WebKitInitializeStorageIfNecessary() can take awhile performing i/o, isn't necessary for every WebView
2552 Reviewed by Maciej Stachowiak.
2554 * Storage/WebStorageManager.mm:
2555 (WebKitInitializeStorageIfNecessary): Pass the client along in initializeTracker().
2557 2011-07-27 Mark Hahnenberg <mhahnenberg@apple.com>
2559 Remove operator new from JSCell
2560 https://bugs.webkit.org/show_bug.cgi?id=64999
2562 Reviewed by Oliver Hunt.
2564 Removed the implementation of operator new in JSCell, so any further uses
2565 will not successfully link. Also removed any remaining uses of operator new.
2567 * Plugins/Hosted/ProxyInstance.mm:
2568 (WebKit::ProxyInstance::newRuntimeObject):
2569 (WebKit::ProxyRuntimeMethod::create):
2570 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
2571 (WebKit::ProxyInstance::getMethod):
2572 * Plugins/Hosted/ProxyRuntimeObject.h:
2573 (WebKit::ProxyRuntimeObject::create):
2574 * WebView/WebScriptDebugDelegate.mm:
2575 (-[WebScriptCallFrame scopeChain]):
2577 2011-07-26 Dan Bernstein <mitz@apple.com>
2579 <rdar://problem/9842889> Add a generic pictograph font family
2580 https://bugs.webkit.org/show_bug.cgi?id=65197
2582 Reviewed by Anders Carlsson.
2584 * WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
2585 * WebView/WebPreferences.mm:
2586 (+[WebPreferences initialize]): Set the default pictograph font family to
2587 "Apple Color Emoji".
2588 (-[WebPreferences pictographFontFamily]): Added this getter.
2589 (-[WebPreferences setPictographFontFamily:]): Added this setter.
2590 * WebView/WebPreferencesPrivate.h:
2591 * WebView/WebView.mm:
2592 (-[WebView _preferencesChanged:]): Pass the preference through to WebCore.
2594 2011-07-25 Ian Henderson <ianh@apple.com>
2596 WebFrame should have a method to determine its visual emptiness
2597 https://bugs.webkit.org/show_bug.cgi?id=64223
2599 Reviewed by Dan Bernstein.
2601 * WebView/WebFrame.mm:
2602 (-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
2604 * WebView/WebFramePrivate.h:
2606 2011-07-19 Leo Yang <leoyang.webkit@gmail.com>
2608 SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
2609 https://bugs.webkit.org/show_bug.cgi?id=60850
2611 Reviewed by Nikolas Zimmermann.
2613 SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions.
2614 This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef>
2615 elements for alternative glyph features.
2617 * MigrateHeaders.make:
2619 2011-07-18 Andy Estes <aestes@apple.com>
2621 Solar Walk app-specific hack accidentally strips stylesheets from the document.
2622 https://bugs.webkit.org/show_bug.cgi?id=64777
2624 Reviewed by Adam Barth.
2626 Solar Walk uses a self-closed title tag in its documents ("<title />").
2627 The HTML5 parser does not recognize this as a valid self-closing tag,
2628 so it treats the remainder of the document as title text.
2630 We work around this in WebKit by injecting a script that calls
2631 document.write() on the contents of document.title, thereby restoring
2632 the contents of the document. Unfortunately this overwrote several
2633 <style> tags that existed before the <title>, thereby causing the
2634 document to not have the intended styling.
2636 Fix this by having the injected script concatenate document.title to
2637 the document instead of overwriting it during document.write(). We can
2638 also take the opportunity to remove document.title since it does not
2639 contain useful information.
2641 * Misc/SolarWalkQuirksUserScript.js:
2643 2011-07-18 Dean Jackson <dino@apple.com>
2645 https://bugs.webkit.org/show_bug.cgi?id=64742
2646 Expose WebPreferences for media playback requiring user gestures and inline playback
2648 Reviewed by Simon Fraser.
2650 Two new WebPreferences: MediaPlaybackRequiresUserGesture and
2651 MediaPlaybackAllowsInline.
2653 * WebView/WebPreferenceKeysPrivate.h:
2654 * WebView/WebPreferences.mm:
2655 (+[WebPreferences initialize]):
2656 (-[WebPreferences mediaPlaybackRequiresUserGesture]):
2657 (-[WebPreferences setMediaPlaybackRequiresUserGesture:]):
2658 (-[WebPreferences mediaPlaybackAllowsInline]):
2659 (-[WebPreferences setMediaPlaybackAllowsInline:]):
2660 * WebView/WebPreferencesPrivate.h:
2661 * WebView/WebView.mm:
2662 (-[WebView _preferencesChanged:]):
2664 2011-07-18 Pratik Solanki <psolanki@apple.com>
2666 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
2667 Get webkit to compile with USE(CFNETWORK) enabled on Mac
2669 Reviewed by David Kilzer.
2671 Create an NSURLDownload from the CF objects that we have.
2673 * Misc/WebDownload.mm:
2674 (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
2675 * Misc/WebDownloadInternal.h:
2676 * WebCoreSupport/WebFrameLoaderClient.mm:
2677 (WebFrameLoaderClient::download):
2679 2011-07-15 Pratik Solanki <psolanki@apple.com>
2681 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
2682 Get webkit to compile with USE(CFNETWORK) enabled on Mac
2684 Reviewed by David Kilzer.
2686 New WebKitSystemInterface functions for CFNetwork-based loader.
2688 * WebCoreSupport/WebSystemInterface.mm:
2689 (InitWebCoreSystemInterface):
2691 2011-07-15 Tim Horton <timothy_horton@apple.com>
2693 Overlay scrollbars in overflow areas no longer pulse when revealed
2694 https://bugs.webkit.org/show_bug.cgi?id=64606
2695 <rdar://problem/9390674>
2697 Reviewed by Simon Fraser.
2699 Ensure that the state of the scrollbar implementation is kept in sync
2700 with WebCore's internal representation. Previously, we synchronized them
2701 at paint time, causing pulsing to be skipped due to the scrollbars being
2704 * WebCoreSupport/WebSystemInterface.mm:
2705 (InitWebCoreSystemInterface):
2707 2011-07-15 Andy Estes <aestes@apple.com>
2709 Rename applicationIsSolarWalk() to applicationIsSolarWalkMac().
2710 https://bugs.webkit.org/show_bug.cgi?id=64641
2712 Reviewed by Brian Weinstein.
2714 * WebView/WebView.mm:
2715 (needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac().
2717 2011-07-15 Dan Bernstein <mitz@apple.com>
2719 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
2720 https://bugs.webkit.org/show_bug.cgi?id=64615
2722 Reviewed by Anders Carlsson.
2724 * WebCoreSupport/WebChromeClient.h:
2725 * WebCoreSupport/WebChromeClient.mm:
2726 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
2727 +[NSCursor setHiddenUntilMouseMoves:].
2729 2011-07-14 Gavin Barraclough <barraclough@apple.com>
2731 https://bugs.webkit.org/show_bug.cgi?id=64250
2732 Global strict mode function leaking global object as "this".
2734 Reviewed by Oliver Hunt.
2736 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2737 (WebKit::NetscapePluginInstanceProxy::invoke):
2738 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2739 - Change call to pass DOM Window shell, instead of the global varaible object.
2741 2011-07-13 Joseph Pecoraro <joepeck@webkit.org>
2743 Improve names of some ApplicationCacheStorage accessor methods
2744 https://bugs.webkit.org/show_bug.cgi?id=64433
2746 Reviewed by Alexey Proskuryakov.
2748 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
2749 (-[WebApplicationCacheQuotaManager usage]):
2750 (-[WebApplicationCacheQuotaManager quota]):
2753 2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
2755 ApplicationCache update should not immediately fail when reaching per-origin quota
2756 https://bugs.webkit.org/show_bug.cgi?id=64177
2758 Reviewed by Alexey Proskuryakov.
2760 * WebView/WebUIDelegatePrivate.h:
2761 * DefaultDelegates/WebDefaultUIDelegate.m:
2762 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
2763 Update the delegate to include a space needed parameter.
2765 * WebCoreSupport/WebChromeClient.h:
2766 * WebCoreSupport/WebChromeClient.mm:
2767 (WebChromeClient::reachedApplicationCacheOriginQuota):
2768 Call the delegate with the new space needed information.
2770 2011-07-12 Adam Roben <aroben@apple.com>
2772 Delete some redundant code in WebHTMLView
2774 This code had no user-visible effect, as we were just duplicating work that AppKit would do
2775 for us at a slightly different time.
2777 Fixes <http://webkit.org/b/64390> WebHTMLView sets its root layer's transform unnecessarily
2779 Reviewed by Simon Fraser.
2781 * WebView/WebHTMLView.mm:
2782 (-[WebHTMLView viewDidMoveToWindow]):
2783 (-[WebHTMLView attachRootLayer:]):
2784 Don't bother setting the root layer's transform to account for the scale factor. AppKit
2785 takes care of this for us nowadays.
2787 2011-07-10 Kenichi Ishibashi <bashi@chromium.org>
2789 Let plugins participate in form submission
2790 https://bugs.webkit.org/show_bug.cgi?id=13061
2792 Adds methods to get form value from NPAPI plugins.
2794 Reviewed by Anders Carlsson.
2796 * Plugins/Hosted/WebHostedNetscapePluginView.h:
2797 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2798 (-[WebHostedNetscapePluginView getFormValue:]): Added.
2799 * Plugins/WebBaseNetscapePluginView.h:
2800 * Plugins/WebBaseNetscapePluginView.mm:
2801 (-[WebBaseNetscapePluginView getFormValue:]): Added.
2802 * Plugins/WebNetscapePluginPackage.h:
2803 * Plugins/WebNetscapePluginPackage.mm:
2804 (-[WebNetscapePluginPackage browserFuncs]): Added.
2805 * Plugins/WebNetscapePluginView.h:
2806 * Plugins/WebNetscapePluginView.mm:
2807 (-[WebNetscapePluginView getFormValue:]): Added.
2808 * WebCoreSupport/WebFrameLoaderClient.mm:
2809 (NetscapePluginWidget::getFormValue): Added.
2811 2011-07-04 Dan Bernstein <mitz@apple.com>
2813 Moved handling of frame size changes into its own method.
2815 Reviewed by Oliver Hunt.
2817 * WebView/WebFrameView.mm:
2818 (-[WebFrameView _frameSizeChanged]): Added. Moved code here...
2819 (-[WebFrameView setFrameSize:]): ...from here.
2820 * WebView/WebFrameViewInternal.h:
2822 2011-07-01 Adele Peterson <adele@apple.com>
2824 Reviewed by Darin Adler.
2826 WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
2827 <rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body
2829 * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2830 Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word,
2831 space, and after-white-space properties to subframes in the editable document.
2833 2011-07-01 Andy Estes <aestes@apple.com>
2835 Reviewed by Mark Rowe.
2837 Simplify MailQuirksUserScript.js
2838 https://bugs.webkit.org/show_bug.cgi?id=63800
2840 MailQuirksUserScript.js is injected into WebViews in Mail.app on
2841 Leopard to resolve an incompatibility between it and the HTML5 parser.
2842 It did so by taking all nodes in the document between <html> and <body>
2843 and moving them to be children of <body>. This maintains Mail.app's
2844 assumption that document.firstChild.firstChild == document.body.
2846 While this script fixed a specific issue with the Signature panel in
2847 Mail.app, it caused regressions in other WebViews. Since the issue with
2848 the Signature panel is with the empty <head> node implicitly created by
2849 the parser, we can simplify this script by removing this implicit
2850 <head> in the case it has no attributes and no children. This fixes the
2851 Signature panel without affecting other WebViews that have non-trivial
2854 * Misc/MailQuirksUserScript.js: If <head> exists but has no attributes
2855 and no children, remove it.
2857 2011-06-30 Dan Bernstein <mitz@apple.com>
2859 Reviewed by Adele Peterson.
2861 Add +[WebView _allowsRoundingHacks]
2862 https://bugs.webkit.org/show_bug.cgi?id=63734
2864 * WebView/WebView.mm:
2865 (+[WebView _allowsRoundingHacks]): Added this accessor.
2866 * WebView/WebViewPrivate.h:
2868 2011-06-29 Darin Adler <darin@apple.com>
2870 Reviewed by Dan Bernstein.
2872 [Mac] Use system cursors instead of custom bitmaps where possible
2873 https://bugs.webkit.org/show_bug.cgi?id=63679
2875 * WebCoreSupport/WebSystemInterface.mm:
2876 (InitWebCoreSystemInterface): Added WKCursor.
2878 2011-06-28 Ilya Sherman <isherman@chromium.org>
2880 Reviewed by Adam Barth.
2882 form.autocomplete="off" does not work
2883 https://bugs.webkit.org/show_bug.cgi?id=35823
2885 * WebView/WebHTMLRepresentation.mm:
2886 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.
2888 2011-06-26 Mark Rowe <mrowe@apple.com>
2890 Reviewed by Dan Bernstein.
2892 Use a separate file name for Lion's WebKitSystemInterface.
2894 * Configurations/DebugRelease.xcconfig:
2896 2011-06-24 Dan Bernstein <mitz@apple.com>
2898 Reviewed by Anders Carlsson.
2900 Add an option to enable legacy rounding hacks
2901 https://bugs.webkit.org/show_bug.cgi?id=63363
2903 * Misc/WebKitNSStringExtras.mm:
2904 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
2905 Disabled rounding hacks.
2906 (-[NSString _web_widthWithFont:]): Ditto.
2907 * WebView/WebView.mm:
2908 (+[WebView _setAllowsRoundingHacks:]): Added this setter.
2909 * WebView/WebViewPrivate.h:
2911 2011-06-24 Dominic Cooney <dominicc@chromium.org>
2913 Reviewed by Dimitri Glazkov.
2915 Convert shadow DOM-related tests to use window.internals
2916 https://bugs.webkit.org/show_bug.cgi?id=61671
2918 Remove shadow DOM-related methods from Mac API. These are not
2921 * DOM/WebDOMOperations.mm:
2922 * DOM/WebDOMOperationsPrivate.h:
2924 2011-06-24 Yuta Kitamura <yutak@chromium.org>
2926 Reviewed by Adam Barth.
2928 WebSocket: Add run-time flag for new HyBi protocol
2929 https://bugs.webkit.org/show_bug.cgi?id=60348
2931 Make a new flag (Setting::m_useHixie76WebSocketProtocol)
2932 switchable from WebView and WebPreferences.
2934 * WebView/WebPreferenceKeysPrivate.h:
2935 * WebView/WebPreferences.mm:
2936 (+[WebPreferences initialize]):
2937 (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
2938 (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
2939 * WebView/WebPreferencesPrivate.h:
2940 * WebView/WebView.mm:
2941 (-[WebView _preferencesChanged:]):
2943 2011-06-22 Sam Weinig <sam@webkit.org>
2945 Roll out r89469 (Add preference for setting the html parser depth limit)
2947 The preference is not needed at this time, so there is no reason to expose it.
2949 * WebView/WebPreferenceKeysPrivate.h:
2950 * WebView/WebPreferences.mm:
2951 (+[WebPreferences initialize]):
2952 * WebView/WebPreferencesPrivate.h:
2953 * WebView/WebView.mm:
2954 (-[WebView _preferencesChanged:]):
2956 2011-06-22 Sam Weinig <sam@webkit.org>
2958 Reviewed by Adam Barth.
2960 Add preference for setting the html parser depth limit
2961 https://bugs.webkit.org/show_bug.cgi?id=63163
2963 * WebView/WebPreferenceKeysPrivate.h:
2964 * WebView/WebPreferences.mm:
2965 (+[WebPreferences initialize]):
2966 (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
2967 (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
2968 * WebView/WebPreferencesPrivate.h:
2969 * WebView/WebView.mm:
2970 (-[WebView _preferencesChanged:]):
2971 Add private preference for setting the parser depth limit.
2973 2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
2975 Reviewed by Darin Adler.
2977 Make instantiation of legacy editing position more explicit
2978 https://bugs.webkit.org/show_bug.cgi?id=63037
2980 Create new positions since we can't create a legacy editing position outside of WebCore anymore.
2982 * WebView/WebFrame.mm:
2983 (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition.
2984 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
2986 2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
2988 Reviewed by Kent Tamura.
2990 FileChooser should be only created when we need to choose files.
2991 https://bugs.webkit.org/show_bug.cgi?id=63039
2993 * WebCoreSupport/WebChromeClient.mm:
2994 (WebChromeClient::runOpenPanel): Changed to use settings.
2996 2011-06-21 MORITA Hajime <morrita@google.com>
2998 Unreviewed, rolling out r89401 and r89403.
2999 http://trac.webkit.org/changeset/89401
3000 http://trac.webkit.org/changeset/89403
3001 https://bugs.webkit.org/show_bug.cgi?id=62970
3003 Breaks mac build and mistakenly enables the spellcheck API
3005 * Configurations/FeatureDefines.xcconfig:
3007 2011-06-20 MORITA Hajime <morrita@google.com>
3009 Reviewed by Kent Tamura.
3011 Spellcheck API should be build-able.
3012 https://bugs.webkit.org/show_bug.cgi?id=62970
3014 No new tests, changing only build related files
3016 * Configurations/FeatureDefines.xcconfig:
3018 2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
3020 Unreviewed, rolling out r89354.
3021 http://trac.webkit.org/changeset/89354
3022 https://bugs.webkit.org/show_bug.cgi?id=63099
3024 Broke tests on Mac (Requested by rniwa on #webkit).
3026 * WebCoreSupport/WebInspectorClient.mm:
3027 (-[WebInspectorWindowController destroyInspectorView:]):
3028 * WebInspector/WebInspector.mm:
3029 (-[WebInspector show:]):
3030 (-[WebInspector showConsole:]):
3031 (-[WebInspector isDebuggingJavaScript]):
3032 (-[WebInspector toggleDebuggingJavaScript:]):
3033 (-[WebInspector startDebuggingJavaScript:]):
3034 (-[WebInspector stopDebuggingJavaScript:]):
3035 (-[WebInspector isProfilingJavaScript]):
3036 (-[WebInspector toggleProfilingJavaScript:]):
3037 (-[WebInspector startProfilingJavaScript:]):
3038 (-[WebInspector stopProfilingJavaScript:]):
3039 (-[WebInspector isJavaScriptProfilingEnabled]):
3040 (-[WebInspector setJavaScriptProfilingEnabled:]):
3041 (-[WebInspector isTimelineProfilingEnabled]):
3042 (-[WebInspector setTimelineProfilingEnabled:]):
3043 (-[WebInspector setFrontend:]):
3044 (-[WebInspector showWindow:]):
3045 * WebInspector/WebInspectorFrontend.h:
3046 * WebInspector/WebInspectorFrontend.mm:
3047 * WebInspector/WebInspectorPrivate.h:
3049 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
3051 Reviewed by Yury Semikhatsky.
3053 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
3054 https://bugs.webkit.org/show_bug.cgi?id=62985
3056 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
3057 methods for plumbing the menu action handlers through the WebKit and WebCore.
3058 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
3059 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
3060 WebKit/win and WebKit2 to follow.
3062 * WebCoreSupport/WebInspectorClient.mm:
3063 (-[WebInspectorWindowController destroyInspectorView:]):
3064 * WebInspector/WebInspector.mm:
3065 (-[WebInspector showWindow]):
3066 (-[WebInspector show:]):
3067 (-[WebInspector showConsole:]):
3068 (-[WebInspector isDebuggingJavaScript]):
3069 (-[WebInspector toggleDebuggingJavaScript:]):
3070 (-[WebInspector startDebuggingJavaScript:]):
3071 (-[WebInspector stopDebuggingJavaScript:]):
3072 (-[WebInspector isProfilingJavaScript]):
3073 (-[WebInspector toggleProfilingJavaScript:]):
3074 (-[WebInspector startProfilingJavaScript:]):
3075 (-[WebInspector stopProfilingJavaScript:]):
3076 (-[WebInspector isJavaScriptProfilingEnabled]):
3077 (-[WebInspector setJavaScriptProfilingEnabled:]):
3078 (-[WebInspector isTimelineProfilingEnabled]):
3079 (-[WebInspector setTimelineProfilingEnabled:]):
3080 (-[WebInspector setFrontend:]):
3081 (-[WebInspector releaseFrontend]):
3082 (-[WebInspector showWindow:]):
3083 * WebInspector/WebInspectorFrontend.h:
3084 * WebInspector/WebInspectorFrontend.mm:
3085 (-[WebInspectorFrontend isDebuggingEnabled]):
3086 (-[WebInspectorFrontend setDebuggingEnabled:]):
3087 (-[WebInspectorFrontend isProfilingJavaScript]):
3088 (-[WebInspectorFrontend startProfilingJavaScript]):
3089 (-[WebInspectorFrontend stopProfilingJavaScript]):
3090 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
3091 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
3092 (-[WebInspectorFrontend isTimelineProfilingEnabled]):
3093 (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
3094 * WebInspector/WebInspectorPrivate.h:
3096 2011-06-01 Jer Noble <jer.noble@apple.com>
3098 Reviewed by Eric Carlson.
3100 Move Full Screen Controllers into WebCore.
3102 Remove dependency on QTKit from wekitExitFullscreen()
3103 https://bugs.webkit.org/show_bug.cgi?id=61843
3105 WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation
3106 have been moved into WebCore.
3108 * WebCoreSupport/WebSystemInterface.mm:
3109 (InitWebCoreSystemInterface): Add support for four WKSI functions in WCSI.
3110 * WebView/WebFullScreenController.mm: Remove unused #include.
3111 * WebView/WebView.mm: Change the include location of
3112 WebVideoFullscreenController.h
3114 2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
3116 Reviewed by Darin Adler.
3118 Separate concerns of loading file icons and choosing files.
3119 https://bugs.webkit.org/show_bug.cgi?id=62931
3121 * WebCoreSupport/WebChromeClient.h:
3122 * WebCoreSupport/WebChromeClient.mm:
3123 (WebChromeClient::loadIconForFiles): Renamed.
3125 2011-06-18 Andrew Wellington <andrew@webkit.org>
3127 Reviewed by Alexey Proskuryakov.
3129 https://bugs.webkit.org/show_bug.cgi?id=62843
3130 WebKit Mac API calls didReceiveAuthenticationChallenge instead of
3131 didCancelAuthenticationChallenge
3133 * WebView/WebView.mm:
3134 (-[WebView _cacheResourceLoadDelegateImplementations]):
3136 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
3138 Unreviewed, rolling out r89026.
3139 http://trac.webkit.org/changeset/89026
3140 https://bugs.webkit.org/show_bug.cgi?id=62804
3142 These patches were likely correct. I'll investigate the
3143 browser_test failures. (Requested by abarth on #webkit).
3145 * WebView/WebVideoFullscreenHUDWindowController.mm:
3146 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
3148 2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
3152 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
3153 https://bugs.webkit.org/show_bug.cgi?id=62796
3155 The patches broke chromium browser tests.
3157 * WebView/WebVideoFullscreenHUDWindowController.mm:
3158 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
3160 2011-06-16 Adam Barth <abarth@webkit.org>
3162 Reviewed by Eric Seidel.
3164 Remove HTMLVideoElement::processingUserGesture
3165 https://bugs.webkit.org/show_bug.cgi?id=62784
3167 * WebView/WebVideoFullscreenHUDWindowController.mm:
3168 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
3170 2011-06-15 Adam Barth <abarth@webkit.org>
3172 Reviewed by Eric Seidel.
3174 Remove ScriptController::setAllowPopupsFromPlugin
3175 https://bugs.webkit.org/show_bug.cgi?id=62706
3177 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3178 (WebKit::NetscapePluginInstanceProxy::evaluate):
3179 * Plugins/WebNetscapePluginView.mm:
3180 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
3182 2011-06-15 David Kilzer <ddkilzer@apple.com>
3184 <http://webkit.org/b/62745> Convert WebNSFileManagerExtras.m to Objective-C++
3186 Reviewed by Joseph Pecoraro.
3188 * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
3189 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3190 Added static_cast<MetaDataInfo *>.
3192 2011-06-14 Stephanie Lewis <slewis@apple.com>
3194 Rubber stamped by Oliver Hunt.
3196 <rdar://problem/9511169>
3201 2011-06-13 Kentaro Hara <haraken@google.com>
3203 Reviewed by Alexey Proskuryakov.
3205 Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
3206 https://bugs.webkit.org/show_bug.cgi?id=61256
3208 In order to prevent rounding error caused by expanding/shrinking a page
3209 using different calculation here and there, I added a common calculation
3210 method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
3211 keeping the ratio of width and height of the original page.
3212 [WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
3213 and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
3214 use resizePageRectsKeepingRatio() to expand/shrink a page.
3216 Test: printing/page-count-with-one-word.html
3218 * WebView/WebHTMLView.mm:
3219 (-[WebHTMLView _web_setPrintingModeRecursive]):
3220 (-[WebHTMLView _web_clearPrintingModeRecursive]):
3221 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
3222 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]):
3223 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
3224 (-[WebHTMLView _endPrintMode]):
3225 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
3226 (-[WebHTMLView _endScreenPaginationMode]):
3227 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]):
3228 (-[WebHTMLView layout]):
3229 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3230 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
3231 (-[WebHTMLView setPageWidthForPrinting:]):
3233 2011-06-13 Tony Chang <tony@chromium.org>
3235 Reviewed by Dimitri Glazkov.
3237 rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
3238 https://bugs.webkit.org/show_bug.cgi?id=62578
3240 * Configurations/FeatureDefines.xcconfig:
3242 2011-06-13 Tony Chang <tony@chromium.org>
3244 Reviewed by Adam Barth.
3246 rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
3247 https://bugs.webkit.org/show_bug.cgi?id=62545
3249 * Configurations/FeatureDefines.xcconfig:
3251 2011-06-12 Adam Barth <abarth@webkit.org>
3253 Reviewed by Alexey Proskuryakov.
3255 Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
3256 https://bugs.webkit.org/show_bug.cgi?id=62516
3258 * WebCoreSupport/WebFrameLoaderClient.h:
3259 * WebCoreSupport/WebFrameLoaderClient.mm:
3260 (WebFrameLoaderClient::interruptedForPolicyChangeError):
3262 2011-06-12 Adam Barth <abarth@webkit.org>
3264 Reviewed by Eric Seidel.
3266 Remove FrameLoader::isProcessingUserGesture
3267 https://bugs.webkit.org/show_bug.cgi?id=62519
3269 * WebView/WebView.mm:
3270 (-[WebView _isProcessingUserGesture]):
3272 2011-06-12 Adam Barth <abarth@webkit.org>
3274 Reviewed by Alexey Proskuryakov.
3276 Remove trival "forward-to-client" member functions from FrameLoader
3277 https://bugs.webkit.org/show_bug.cgi?id=62510
3279 * WebCoreSupport/WebFrameNetworkingContext.mm:
3280 (WebFrameNetworkingContext::blockedError):
3282 2011-06-10 Tony Chang <tony@chromium.org>
3284 Reviewed by Ojan Vafai.
3286 add a compile guard ENABLE(FLEXBOX)
3287 https://bugs.webkit.org/show_bug.cgi?id=62049
3289 * Configurations/FeatureDefines.xcconfig:
3291 2011-06-06 Michael Saboff <msaboff@apple.com>
3293 Reviewed by Geoffrey Garen.
3295 Fonts returned by FontCache::getFontDataForCharacters() are never released
3296 https://bugs.webkit.org/show_bug.cgi?id=61875
3298 This change allows fonts allocated as system fallback fonts to be
3299 released. Previously, the reference counts for these fonts grew
3300 without bound. This is implemented as an auto release class that wraps
3301 accesses to the cache for system fallback fonts. All such accesses are
3302 via the method FontCache::getFontDataForCharacters. The new class is
3303 called FontCachePurgePreventer. When such an object exists, it protects
3304 these fonts from deletion.
3306 See more comments for this defect in Source/WebCore/ChangeLog.
3308 * Misc/WebKitNSStringExtras.mm:
3309 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
3310 (-[NSString _web_widthWithFont:]):
3311 Wrapped code accessing fallback fonts with local
3312 FontCachePurgePreventer in these methods.
3314 * Misc/WebStringTruncator.mm:
3315 (+[WebStringTruncator centerTruncateString:toWidth:]):
3316 (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
3317 (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
3318 (+[WebStringTruncator widthOfString:font:]):
3319 Wrapped code accessing fallback fonts with local
3320 FontCachePurgePreventer in these methods.
3322 2011-06-06 Peter Kasting <pkasting@google.com>
3324 Reviewed by Antonio Gomes.
3326 Remove unnecessary args from scroll functions.
3327 https://bugs.webkit.org/show_bug.cgi?id=61648
3329 * WebView/WebFrame.mm:
3330 (-[WebFrame _scrollDOMRangeToVisible:]):
3332 2011-06-06 Alexandru Chiculita <achicu@adobe.com>
3334 Reviewed by Kent Tamura.
3336 Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
3337 https://bugs.webkit.org/show_bug.cgi?id=61628
3339 * Configurations/FeatureDefines.xcconfig:
3341 2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
3343 Reviewed by Kent Tamura.
3345 Add ENABLE(CSS_REGIONS) guard for CSS Regions support
3346 https://bugs.webkit.org/show_bug.cgi?id=61631
3348 * Configurations/FeatureDefines.xcconfig:
3350 2011-06-02 Anders Carlsson <andersca@apple.com>
3352 Reviewed by Sam Weinig.
3354 Need a way to install the memory pressure handler without initializing WebKit1
3355 https://bugs.webkit.org/show_bug.cgi?id=61975
3357 Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
3358 -[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
3359 but we'd like to be able to install a memory pressure handler without creating a WebView or even
3360 calling any WebView method since that will call +[WebView initialize].
3363 * WebView/WebView.mm:
3364 (WebInstallMemoryPressureHandler):
3365 * WebView/WebViewPrivate.h:
3367 2011-05-27 Stephanie Lewis <slewis@apple.com>
3371 Fix a typo in the order_file flag.
3373 * Configurations/Base.xcconfig:
3375 2011-05-27 Stephanie Lewis <slewis@apple.com>
3377 Rubber Stamped by Adam Roben.
3379 Update Order Files. Use -order_file flag since it can order more of the binary.
3381 * Configurations/Base.xcconfig:
3384 2011-05-25 Stephanie Lewis <slewis@apple.com>
3386 Reviewed by Brady Eidson.
3388 https://bugs.webkit.org/show_bug.cgi?id=61407
3389 part of <rdar://problem/8675177>
3390 Remove Quicklook pref. Moving it enirely down into WebCore so it can
3391 be calculated only on reloads.
3393 * WebView/WebPreferenceKeysPrivate.h:
3394 * WebView/WebPreferences.mm:
3395 (+[WebPreferences initialize]):
3396 * WebView/WebPreferencesPrivate.h:
3397 * WebView/WebView.mm:
3398 (-[WebView _preferencesChanged:]):
3400 2011-05-24 Jer Noble <jer.noble@apple.com>
3402 Reviewed by Darin Adler.
3404 Video fails to play on Vimeo
3405 https://bugs.webkit.org/show_bug.cgi?id=61403
3407 * WebCoreSupport/WebSystemInterface.mm:
3408 (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
3409 wkQTMovieResolvedURL.
3411 2011-05-24 Keishi Hattori <keishi@webkit.org>
3413 Reviewed by Kent Tamura.
3415 Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
3416 https://bugs.webkit.org/show_bug.cgi?id=61273
3418 * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
3420 2011-05-24 Adam Barth <abarth@webkit.org>
3422 Reviewed by Eric Seidel.
3424 Add FIXME comments about removing FrameLoader::isProcessingUserGesture
3425 https://bugs.webkit.org/show_bug.cgi?id=61395
3427 * WebView/WebView.mm:
3428 (-[WebView _isProcessingUserGesture]):
3430 2011-05-24 Michael Saboff <msaboff@apple.com>
3432 Reviewed by Geoffrey Garen.
3434 Improve handling in WebCore of low memory situations
3435 https://bugs.webkit.org/show_bug.cgi?id=61222
3437 Added call to enable memory pressure handling.
3439 * WebView/WebView.mm:
3440 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3441 * WebView/WebViewInternal.h:
3443 2011-05-24 Jay Civelli <jcivelli@chromium.org>
3445 Rubberstamped by David Kilzer.
3447 Updated some files that I forgot in my previous MHTML CL.
3449 * Configurations/FeatureDefines.xcconfig:
3451 2011-05-20 Jeremy Noble <jer.noble@apple.com>
3453 Reviewed by Simon Fraser.
3455 Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
3456 https://bugs.webkit.org/show_bug.cgi?id=61224
3458 Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
3461 * WebView/WebFullScreenController.mm:
3462 (-[WebFullScreenController windowDidEnterFullscreen:]):
3463 (-[WebFullScreenController enterFullscreen:]):
3464 (-[WebFullScreenController exitFullscreen]):
3465 (-[WebFullscreenWindow setRendererLayer:]):
3467 2011-05-20 Andy Estes <aestes@apple.com>
3469 Reviewed by Darin Adler.
3471 WebView loses firstResponder status when entering full-screen mode.
3472 https://bugs.webkit.org/show_bug.cgi?id=61153
3474 * Misc/WebNSWindowExtras.h:
3475 * Misc/WebNSWindowExtras.m:
3476 (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a
3477 convenience method to NSWindow that makes the given NSResponder first
3478 responder only if it is a descendant of the given view.
3479 * WebView/WebFullScreenController.mm:
3480 (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView
3481 was a descendant of the browser window's first responder when entering
3482 full-screen mode, set the full-screen window's first responder to that
3484 (-[WebFullScreenController exitFullscreen]): Do the reverse of what is
3485 done in windowDidEnterFullscreen:.
3487 2011-05-20 Enrica Casucci <enrica@apple.com>
3489 Reviewed by David Kilzer.
3491 Add delegate methods about focus and blur to all elements.
3492 https://bugs.webkit.org/show_bug.cgi?id=61218
3494 We want to have delegates for these events for all the elements, not only the form elements.
3495 The patch changes the name of the methods in a way that is not form element specific.
3497 * WebCoreSupport/WebChromeClient.h:
3498 * WebCoreSupport/WebChromeClient.mm:
3499 (WebChromeClient::elementDidFocus):
3500 (WebChromeClient::elementDidBlur):
3501 * WebView/WebUIDelegatePrivate.h:
3503 2011-05-20 Simon Fraser <simon.fraser@apple.com>
3505 Reviewed by Sam Weinig.
3507 numberOfActiveAnimations() can include animations from documents in the page cache
3508 https://bugs.webkit.org/show_bug.cgi?id=53641
3510 Pass the Frame's document as the one to count animations on.
3512 * WebView/WebFrame.mm:
3513 (-[WebFrame _numberOfActiveAnimations]):
3515 2011-05-17 Timothy Hatcher <timothy@apple.com>
3517 Update the the context menu to reflect the system search provider on Mac.
3519 <rdar://problem/9198419>
3521 Reviewed by Sam Weinig.
3523 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3524 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
3525 create the web search context menu title.
3526 * WebCoreSupport/WebSystemInterface.mm:
3527 (InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.
3529 2011-05-16 Emil A Eklund <eae@chromium.org>
3531 Reviewed by Eric Seidel.
3533 Replace docTop/Right/Bottom/Left/Width/Height with documentRect
3534 https://bugs.webkit.org/show_bug.cgi?id=60743
3536 Replace uses of docWidth/Height with documentRect.
3538 * WebView/WebFrame.mm:
3539 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
3541 2011-05-16 Yuzo Fujishima <yuzo@google.com>
3543 Reviewed by Antti Koivisto.
3545 Fix for Bug 43704 - Web font is printed as blank if it is not cached
3546 https://bugs.webkit.org/show_bug.cgi?id=43704
3548 * WebView/WebHTMLView.mm:
3549 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
3551 2011-05-16 David Kilzer <ddkilzer@apple.com>
3553 <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
3554 <rdar://problem/9446430>
3556 Reviewed by Mark Rowe.
3558 * Configurations/Base.xcconfig: Fixed typo.
3560 2011-05-13 Jon Lee <jonlee@apple.com>
3562 Reviewed by Simon Fraser.
3564 Can't horizontally scroll iframes and overflow because wheel events are always accepted
3565 https://bugs.webkit.org/show_bug.cgi?id=60779
3567 * WebCoreSupport/WebChromeClient.h:
3568 (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
3569 (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
3571 2011-05-13 Sam Weinig <sam@webkit.org>
3573 Reviewed by Anders Carlsson.
3575 Prune #includes from FrameView.h (Part 2)
3576 https://bugs.webkit.org/show_bug.cgi?id=60748
3578 - Update files that were depending on FrameView.h #including Frame.h or
3581 * WebView/WebClipView.mm:
3582 * WebView/WebHTMLView.mm:
3583 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
3585 2011-05-12 Pratik Solanki <psolanki@apple.com>
3587 Reviewed by Antti Koivisto.
3589 Part of WebCore should use CFNetwork-based loader on Mac
3590 https://bugs.webkit.org/show_bug.cgi?id=51836
3592 Use CFRunLoop when using CFNetwork.
3594 * WebView/WebView.mm:
3595 (-[WebView scheduleInRunLoop:forMode:]):
3596 (-[WebView unscheduleFromRunLoop:forMode:]):
3598 2011-05-12 Pratik Solanki <psolanki@apple.com>
3600 Reviewed by Antti Koivisto.
3602 Part of WebCore should use CFNetwork-based loader on Mac
3603 https://bugs.webkit.org/show_bug.cgi?id=51836
3605 Include AuthenticationCF.h header file.
3607 * Misc/WebDownload.mm:
3608 * Plugins/WebBaseNetscapePluginView.mm:
3609 * WebCoreSupport/WebFrameLoaderClient.mm:
3611 2011-05-12 Adele Peterson <adele@apple.com>
3613 Reviewed by Darin Adler and Adam Barth.
3615 Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
3616 https://bugs.webkit.org/show_bug.cgi?id=60685
3618 Solar Walk uses a self closing title tag, so to match the behavior of the old parser,
3619 we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
3621 * Misc/SolarWalkQuirksUserScript.js: Added.
3622 * WebView/WebView.mm:
3623 (needsSolarWalkQuirksScript):
3624 (leakSolarWalkQuirksUserScriptContents):
3625 (-[WebView _injectSolarWalkQuirksScript]):
3626 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3628 2011-05-12 Jia Pu <jpu@apple.com>
3630 Reviewed by Darin Adler.
3632 Regression caused by changeset 86281
3633 https://bugs.webkit.org/show_bug.cgi?id=60712
3634 <rdar://problem/9427970>
3636 Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
3637 So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
3638 returns. So we don't need to use the condition to coordinate between these two function. In fact,
3639 all callbacks are delivered on main thread. We don't really need any locking here.
3641 Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
3644 * WebCoreSupport/CorrectionPanel.h:
3645 * WebCoreSupport/CorrectionPanel.mm:
3646 (CorrectionPanel::CorrectionPanel):
3647 (CorrectionPanel::show):
3648 (CorrectionPanel::dismiss):
3649 (CorrectionPanel::dismissInternal):
3650 (CorrectionPanel::handleAcceptedReplacement):
3651 * WebCoreSupport/WebEditorClient.mm:
3652 (WebEditorClient::dismissCorrectionPanelSoon):
3654 2011-05-12 Patrick Gansterer <paroga@webkit.org>
3656 Reviewed by Adam Barth.
3658 Enable OwnPtr strict mode in PluginHalter
3659 https://bugs.webkit.org/show_bug.cgi?id=60681
3661 * WebView/WebView.mm:
3662 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
3664 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
3666 Reviewed by Darin Adler.
3668 String operator+ reallocates unnecessarily when concatting > 2 strings
3669 https://bugs.webkit.org/show_bug.cgi?id=58420
3671 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
3673 * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
3674 (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):
3676 2011-05-10 Tony Gentilcore <tonyg@chromium.org>
3678 Reviewed by Darin Adler.
3680 Perform some forward declarations suggested by include-what-you-use
3681 https://bugs.webkit.org/show_bug.cgi?id=60545
3683 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3684 * WebView/WebFrame.mm:
3686 2011-05-11 Jia Pu <jpu@apple.com>
3688 Reviewed by Darin Adler.
3690 CorrectionPanel sometimes hangs in dismissSoon().
3691 https://bugs.webkit.org/show_bug.cgi?id=60599
3692 <rdar://problem/9313628>
3694 Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
3695 to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
3696 for condition checking.
3698 * WebCoreSupport/CorrectionPanel.h:
3699 * WebCoreSupport/CorrectionPanel.mm:
3700 (CorrectionPanel::CorrectionPanel):
3701 (CorrectionPanel::show):
3702 (CorrectionPanel::dismissSoon):
3703 (CorrectionPanel::dismissInternal):
3704 (CorrectionPanel::handleAcceptedReplacement):
3706 2011-05-10 Anton D'Auria <adauria@apple.com>
3708 Reviewed by David Levin.
3710 Add ApplicationCache API to get disk usage per origin
3711 https://bugs.webkit.org/show_bug.cgi?id=57127
3715 * WebCoreSupport/WebApplicationCache.h:
3716 * WebCoreSupport/WebApplicationCache.mm:
3717 (+[WebApplicationCache diskUsageForOrigin:]):
3719 2011-05-10 Anton D'Auria <adauria@apple.com>
3721 Reviewed by Alexey Proskuryakov.
3723 Add ApplicationCache API to get disk usage per origin
3724 https://bugs.webkit.org/show_bug.cgi?id=57127
3728 * WebCoreSupport/WebApplicationCache.h:
3729 * WebCoreSupport/WebApplicationCache.mm:
3730 (+[WebApplicationCache diskUsageForOrigin:]):
3732 2011-05-10 Beth Dakin <bdakin@apple.com>
3734 Reviewed by Darin Adler.
3736 https://bugs.webkit.org/show_bug.cgi?id=60582
3737 Crash switching overlay/non-overlay scrollbar preference still possible
3739 <rdar://problem/9323983>
3741 * WebCoreSupport/WebSystemInterface.mm:
3742 (InitWebCoreSystemInterface):
3744 2011-05-09 Jeremy Noble <jer.noble@apple.com>
3746 Reviewed by Darin Adler.
3748 Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
3749 https://bugs.webkit.org/show_bug.cgi?id=60496
3751 When animating into and out of full screen, order out and back in the original webView window,
3752 disabling animations when necessary. The exitFullscreen method was targeting the wrong window,
3753 as the webView is hosted in the full screen window when we ask for it's parent window.
3755 * WebView/WebFullScreenController.mm:
3756 (-[WebFullScreenController windowDidEnterFullscreen:]):
3757 (-[WebFullScreenController exitFullscreen]):
3759 2011-05-04 Philippe Normand <pnormand@igalia.com>
3761 Reviewed by Dimitri Glazkov.
3763 Implement LayoutTestController::pseudoShadowId()
3764 https://bugs.webkit.org/show_bug.cgi?id=60034
3766 * DOM/WebDOMOperations.mm:
3767 (-[DOMElement _shadowPseudoId]):
3768 * DOM/WebDOMOperationsPrivate.h:
3770 2011-05-05 Dan Bernstein <mitz@apple.com>
3772 Reviewed by Simon Fraser.
3774 WebKit part of <rdar://problem/9155590> Broken animation in iAd producer
3776 * WebCoreSupport/WebSystemInterface.mm:
3777 (InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
3779 2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
3781 Reviewed by Eric Seidel.
3783 Rename SelectionController to FrameSelection
3784 https://bugs.webkit.org/show_bug.cgi?id=60234
3786 * WebView/WebFrame.mm:
3787 (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
3788 * WebView/WebFrameInternal.h:
3789 * WebView/WebHTMLView.mm:
3790 * WebView/WebTextCompletionController.mm:
3791 (-[WebTextCompletionController doCompletion]):
3792 * WebView/WebView.mm:
3794 2011-05-04 Cris Neckar <cdn@chromium.org>
3796 Reviewed by Adam Barth.
3798 Expose WebView directly through ChromeClient.
3799 https://bugs.webkit.org/show_bug.cgi?id=49902
3801 * WebCoreSupport/WebChromeClient.h:
3802 (WebChromeClient::webView):
3803 * WebView/WebFrame.mm:
3806 2011-05-04 Tao Bai <michaelbai@chromium.org>
3808 Reviewed by David Kilzer.
3810 Populate touch-icon url to FrameLoaderClient
3811 https://bugs.webkit.org/show_bug.cgi?id=59143
3813 Respect the interface change in FrameLoaderClient.
3815 * Configurations/FeatureDefines.xcconfig:
3816 * WebCoreSupport/WebFrameLoaderClient.h:
3817 * WebCoreSupport/WebFrameLoaderClient.mm:
3818 (WebFrameLoaderClient::dispatchDidChangeIcons):
3820 2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
3822 Reviewed by Dimitri Glazkov.
3824 Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
3825 https://bugs.webkit.org/show_bug.cgi?id=58703
3827 * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
3829 2011-05-02 Adam Roben <aroben@apple.com>
3831 Take advantage of implicit conversion from nullptr_t to PassOwnPtr
3833 Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
3834 doesn't work, but should
3836 Reviewed by Adam Barth.
3838 * History/WebHistory.mm:
3839 * Plugins/WebNetscapePluginEventHandler.mm:
3840 * WebView/WebView.mm:
3842 2011-05-02 Brady Eidson <beidson@apple.com>
3844 Reviewed by Anders Carlsson.
3846 <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
3847 In Aperture, a WebView might be dealloc'ed before it finishes loading.
3849 * WebView/WebView.mm:
3850 (needsSelfRetainWhileLoadingQuirk):
3851 (-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
3852 (-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
3853 (-[WebView _didFailLoadWithError:forFrame:]): Ditto.
3854 (-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.
3856 2011-05-02 Adam Barth <abarth@webkit.org>
3858 Reviewed by David Levin.
3860 PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
3861 https://bugs.webkit.org/show_bug.cgi?id=59924
3863 * History/WebHistory.mm:
3864 (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
3865 * Plugins/WebBaseNetscapePluginView.mm:
3866 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
3867 * WebCoreSupport/WebFrameLoaderClient.mm:
3868 (WebFrameLoaderClient::savePlatformDataToCachedFrame):
3869 * WebView/WebView.mm:
3870 (-[WebView _injectMailQuirksScript]):
3871 (-[WebView _injectOutlookQuirksScript]):
3874 2011-05-02 Sam Weinig <sam@webkit.org>
3876 Reviewed by Adam Barth.
3878 Prune some #includes from DOMWindow.h
3879 https://bugs.webkit.org/show_bug.cgi?id=59907
3881 * Plugins/WebBaseNetscapePluginView.mm:
3882 * WebView/WebFrame.mm:
3883 Add now missing SecurityOrigin.h #includes.
3885 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
3887 Reviewed by Eric Seidel.
3889 Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
3890 https://bugs.webkit.org/show_bug.cgi?id=59837
3892 Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
3894 * WebView/WebHTMLView.mm:
3895 (-[WebHTMLView menuForEvent:]):
3896 (-[WebHTMLView acceptsFirstMouse:]):
3897 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
3899 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
3901 Reviewed by Eric Seidel.
3903 Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
3904 https://bugs.webkit.org/show_bug.cgi?id=59835
3906 Moved currentKeyboardEvent.
3908 * WebView/WebHTMLView.mm:
3909 (currentKeyboardEvent):
3910 (-[WebHTMLView becomeFirstResponder]):
3912 2011-04-29 Dean Jackson <dino@apple.com>
3914 Reviewed by Simon Fraser.
3916 Add ENABLE macro for WebKitAnimation
3917 https://bugs.webkit.org/show_bug.cgi?id=59729
3919 Add new feature to toggle WebKit Animation API.
3921 * Configurations/FeatureDefines.xcconfig:
3923 2011-04-28 David Kilzer <ddkilzer@apple.com>
3925 <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods
3927 Reviewed by Anders Carlsson.
3929 * History/WebHistory.mm:
3930 (-[WebHistoryPrivate init]):
3931 * Misc/WebElementDictionary.mm:
3932 (-[WebElementDictionary initWithHitTestResult:]):
3933 * Misc/WebIconDatabase.mm:
3934 (-[WebIconDatabase init]):
3935 * Plugins/WebPluginController.mm:
3936 (-[WebPluginController initWithDocumentView:]):
3937 * Plugins/WebPluginRequest.m:
3938 (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
3939 * WebCoreSupport/WebEditorClient.mm:
3940 (-[WebEditCommand initWithEditCommand:]):
3941 * WebCoreSupport/WebJavaScriptTextInputPanel.m:
3942 (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
3943 * WebView/WebNavigationData.mm:
3944 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
3946 2011-04-28 David Levin <levin@chromium.org>
3948 Reviewed by Adam Barth.
3950 Remove IMAGE_RESIZER related code.
3951 https://bugs.webkit.org/show_bug.cgi?id=59735
3953 * Configurations/FeatureDefines.xcconfig:
3955 2011-04-28 Adam Barth <abarth@webkit.org>
3957 Reviewed by Eric Seidel.
3960 https://bugs.webkit.org/show_bug.cgi?id=59678
3962 Remove WML-related configuration options and private APIs.
3964 * Configurations/FeatureDefines.xcconfig:
3965 * WebCoreSupport/WebChromeClient.mm:
3966 (stringForMessageSource):
3967 * WebView/WebFramePrivate.h:
3968 * WebView/WebUIDelegatePrivate.h:
3970 2011-04-28 Brian Weinstein <bweinstein@apple.com>
3972 Reviewed by Timothy Hatcher.
3974 Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
3975 https://bugs.webkit.org/show_bug.cgi?id=59747
3977 Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
3978 Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.
3980 * WebCoreSupport/WebInspectorClient.mm:
3981 (-[WebInspectorWindowController showWebInspector:]):
3982 (-[WebInspectorWindowController showErrorConsole:]):
3983 (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
3984 (-[WebInspectorWindowController toggleProfilingJavaScript:]):
3985 (-[WebInspectorWindowController validateUserInterfaceItem:]):
3987 2011-04-28 David Kilzer <ddkilzer@apple.com>
3989 <http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer
3991 Reviewed by Dan Bernstein.
3993 * WebView/WebFullScreenController.mm:
3994 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
3995 Use a RetainPtr to hold the CALayer and to fix the leak.
3997 2011-04-28 David Kilzer <ddkilzer@apple.com>
3999 Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
4001 Addresses review comment from Darin Adler.
4003 * WebView/WebPDFView.mm:
4004 (-[WebPDFView menuForEvent:]): Use a local variable and -release
4005 instead of -autorelease.
4007 2011-04-28 Anders Carlsson <andersca@apple.com>
4009 Fix a thinko - separateRealmLabel is not an NSImageView.
4011 * Panels/WebAuthenticationPanel.h:
4013 2011-04-28 David Kilzer <ddkilzer@apple.com>
4015 <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
4017 Reviewed by Dan Bernstein.
4019 * WebView/WebPDFView.mm:
4020 (-[WebPDFView menuForEvent:]): Call -autorelease after copying
4021 each NSMenuItem. Regressed in r9566 for Bug 3711.
4023 2011-04-28 Enrica Casucci <enrica@apple.com>
4025 Reviewed by Beth Dakin.
4027 Momentum scroll tweak for WebKit.
4028 https://bugs.webkit.org/show_bug.cgi?id=59723
4029 <rdar://problem/9259933>
4031 * WebView/WebDynamicScrollBarsView.mm:
4032 (-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.
4034 2011-04-27 Anders Carlsson <andersca@apple.com>
4036 Follow-up Leopard build fix.
4038 * Carbon/HIViewAdapter.m:
4039 (_webkit_NSView_setNeedsDisplayInRect):
4041 2011-04-27 Anders Carlsson <andersca@apple.com>
4043 More clang++ 32-bit build fixes.
4045 * Carbon/CarbonWindowAdapter.mm:
4046 (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
4047 (-[CarbonWindowAdapter setContentView:]):
4048 (-[CarbonWindowAdapter _handleContentBoundsChanged]):
4049 * Carbon/HIViewAdapter.m:
4050 (_webkit_NSView_setNeedsDisplayInRect):
4051 * Panels/WebAuthenticationPanel.h:
4052 * Plugins/WebBaseNetscapePluginView.mm:
4053 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
4054 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
4056 * WebCoreSupport/WebChromeClient.mm:
4057 (WebChromeClient::scrollRectIntoView):
4058 * WebCoreSupport/WebViewFactory.mm:
4059 (-[WebViewFactory accessibilityConvertScreenRect:]):
4060 * WebView/WebFrameView.mm:
4061 (-[WebFrameView _scrollToBeginningOfDocument]):
4062 (-[WebFrameView _scrollToEndOfDocument]):
4063 * WebView/WebFullScreenController.mm:
4064 (-[WebFullScreenController windowDidEnterFullscreen:]):
4065 * WebView/WebHTMLView.mm:
4066 (-[WebHTMLView _hitViewForEvent:]):
4067 (coreGraphicsScreenPointForAppKitScreenPoint):
4068 * WebView/WebPDFView.mm:
4069 (-[WebPDFView setScrollPoint:]):
4071 2011-04-27 Yury Semikhatsky <yurys@chromium.org>
4073 Reviewed by Pavel Feldman.
4075 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
4076 https://bugs.webkit.org/show_bug.cgi?id=44230
4078 Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
4079 inspector is closed.
4081 * WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed
4082 comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining
4083 pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient.
4084 There is only one reference to it from WebInspectorFrontendClient which is held by the inspector
4087 Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
4088 (-[WebInspectorWindowController initWithInspectedWebView:]):
4089 (-[WebInspectorWindowController close]):
4090 (-[WebInspectorWindowController showWindow:]):
4091 (-[WebInspectorWindowController setAttachedWindowHeight:]):
4092 (-[WebInspectorWindowController destroyInspectorView:]):
4094 2011-04-26 Sam Weinig <sam@webkit.org>
4096 Reviewed by David Hyatt.
4098 Remove Datagrid from the tree
4099 https://bugs.webkit.org/show_bug.cgi?id=59543
4101 * Configurations/FeatureDefines.xcconfig:
4104 2011-04-26 Dan Bernstein <mitz@apple.com>
4106 Reviewed by Mark Rowe.
4108 Choose the compiler based on the Xcode version for Snow Leopard debug builds.
4110 * Configurations/Base.xcconfig:
4111 * Configurations/CompilerVersion.xcconfig: Added.
4113 2011-04-25 Adam Barth <abarth@webkit.org>
4115 Reviewed by David Levin.
4117 WebKit2 should play nice with strict OwnPtrs
4118 https://bugs.webkit.org/show_bug.cgi?id=59426
4120 Fix include ordering.
4122 * WebView/WebDeviceOrientationProviderMock.mm:
4124 2011-04-25 Adam Barth <abarth@webkit.org>
4126 Reviewed by David Levin.
4128 WebKit1 should build cleanly with strict OwnPtrs
4129 https://bugs.webkit.org/show_bug.cgi?id=59424
4131 * History/WebHistoryItem.mm:
4132 (-[WebHistoryItem initFromDictionaryRepresentation:]):
4133 * Plugins/WebNetscapePluginEventHandler.h:
4134 * Plugins/WebNetscapePluginEventHandler.mm:
4135 (WebNetscapePluginEventHandler::create):
4136 * Plugins/WebNetscapePluginView.mm:
4137 (-[WebNetscapePluginView createPlugin]):
4138 * WebView/WebDeviceOrientationProviderMock.mm:
4139 * WebView/WebTextIterator.mm:
4140 (-[WebTextIterator initWithRange:]):
4142 2011-04-25 Jon Lee <jonlee@apple.com>
4144 Reviewed by Maciej Stachowiak.
4146 Overlay scroller hard to see on pages with dark background (59183)
4147 https://bugs.webkit.org/show_bug.cgi?id=59183
4148 <rdar://problem/8975367>
4150 * WebCoreSupport/WebSystemInterface.mm:
4151 (InitWebCoreSystemInterface): adding method to allow changing style
4153 2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
4155 Unreviewed, rolling out r84740.
4156 http://trac.webkit.org/changeset/84740
4157 https://bugs.webkit.org/show_bug.cgi?id=59290
4159 change breaks apple internal builds and is incorrect
4160 (Requested by smfr on #webkit).
4162 * WebCoreSupport/WebSystemInterface.mm:
4163 (InitWebCoreSystemInterface):
4165 2011-04-22 Jon Lee <jonlee@apple.com>
4167 Reviewed by Beth Dakin.
4169 Overlay scroller hard to see on pages with dark background (59183)
4170 https://bugs.webkit.org/show_bug.cgi?id=59183
4171 <rdar://problem/8975367>
4173 * WebCoreSupport/WebSystemInterface.mm:
4174 (InitWebCoreSystemInterface): adding method to allow changing style
4176 2011-04-19 Jer Noble <jer.noble@apple.com>
4178 Reviewed by Daniel Bates.
4180 Full Screen from within an <iframe> does not cause <iframe> to resize.
4181 https://bugs.webkit.org/show_bug.cgi?id=58638
4183 Tests: fullscreen/full-screen-frameset-allowed.html
4184 fullscreen/full-screen-frameset-not-allowed.html
4186 Return the _element's document instead of the WKView's document, which
4187 will be different in the case of elements within <iframe>s.
4189 * WebView/WebFullScreenController.mm:
4190 (-[WebFullScreenController _document]):
4192 2011-04-22 Jer Noble <jer.noble@apple.com>
4194 Reviewed by Maciej Stachowiak.
4196 Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
4197 https://bugs.webkit.org/show_bug.cgi?id=59147
4199 Add a new user default preference, and plumb that preference down to WebCore
4200 Settings. Allow the fullScreenEnabled preference to override the new
4201 isAVFoundationEnabled preference, so that clients of the legacy full screen
4202 mode will continue to use that mode normally.
4204 * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
4205 * WebView/WebPreferences.mm:
4206 (+[WebPreferences initialize]): Set the default value of new
4208 (-[WebPreferences setAVFoundationEnabled:]): Added.
4209 (-[WebPreferences isAVFoundationEnabled]): Added.
4210 * WebView/WebPreferencesPrivate.h:
4211 * WebView/WebView.mm:
4212 (-[WebView _preferencesChanged:]): Update the WebCore settings with the
4213 new values from WebPreferences.
4215 2011-04-22 Sam Weinig <sam@webkit.org>
4217 Reviewed by Gavin Barraclough.
4219 Remove remaining uses of deprecated version of toJS
4220 https://bugs.webkit.org/show_bug.cgi?id=59170
4222 * DOM/WebDOMOperations.mm:
4223 (-[DOMElement _shadowRoot:]):
4224 (-[DOMElement _ensureShadowRoot:]):
4225 Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
4227 2011-04-21 Maciej Stachowiak <mjs@apple.com>
4229 Reviewed by Adam Roben.
4231 Add a feature define to allow <details> and <summary> to be disabled
4232 https://bugs.webkit.org/show_bug.cgi?id=59118
4233 <rdar://problem/9257045>
4235 * Configurations/FeatureDefines.xcconfig:
4237 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
4239 Reviewed by Sam Weinig.
4241 Add Frame* to the argument lists of canCopyCut and canPaste
4242 https://bugs.webkit.org/show_bug.cgi?id=59153
4244 * WebCoreSupport/WebEditorClient.h:
4245 * WebCoreSupport/WebEditorClient.mm:
4246 (WebEditorClient::canCopyCut):
4247 (WebEditorClient::canPaste):
4249 2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
4251 Unreviewed, rolling out r82052.
4252 http://trac.webkit.org/changeset/82052
4253 https://bugs.webkit.org/show_bug.cgi?id=59135
4255 New full screen api should be opt-in, not opt-out. (Requested
4256 by jernoble on #webkit).
4258 * WebView/WebPreferences.mm:
4259 (+[WebPreferences initialize]):
4261 2011-04-21 Beth Dakin <bdakin@apple.com>
4263 Reviewed by Dan Bernstein.
4265 https://bugs.webkit.org/show_bug.cgi?id=59048
4266 Need to track whether overlay scrollbar is currently visible and in lower-
4269 <rdar://problem/9211232>
4271 A new WebSystemInterface is needed for this.
4272 * WebCoreSupport/WebSystemInterface.mm:
4273 (InitWebCoreSystemInterface):
4275 2011-04-21 Dirk Schulze <krit@webkit.org>
4277 Reviewed by Nikolas Zimmermann.
4279 SVG feDropShadow implementation of SVG Filters 1.2
4280 https://bugs.webkit.org/show_bug.cgi?id=52513
4282 * MigrateHeaders.make:
4284 2011-04-20 Dominic Cooney <dominicc@chromium.org>
4286 Reviewed by Dimitri Glazkov.
4288 layoutTestController can create and destroy shadow DOM
4289 https://bugs.webkit.org/show_bug.cgi?id=59058
4291 Support for new methods in Mac DRT.
4293 * DOM/WebDOMOperations.mm:
4294 (-[DOMElement _ensureShadowRoot:]):
4295 (-[DOMElement _removeShadowRoot]):
4296 * DOM/WebDOMOperationsPrivate.h:
4298 2011-04-20 Eric Carlson <eric.carlson@apple.com>
4300 Reviewed by Dan Bernstein.
4302 Adopt QTKit API for listing and deleting file in its media cache.
4303 <rdar://problem/9130029>
4305 * WebCoreSupport/WebSystemInterface.mm:
4306 (InitWebCoreSystemInterface): Initialize new functions.
4308 2011-04-19 Matthew Delaney <mdelaney@apple.com>
4310 Reviewed by Simon Fraser.
4312 WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
4313 https://bugs.webkit.org/show_bug.cgi?id=58936
4315 * WebView/WebPreferences.mm:
4316 (+[WebPreferences initialize]):
4318 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
4320 Reviewed by Pavel Feldman.
4322 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
4323 https://bugs.webkit.org/show_bug.cgi?id=58883
4325 * WebCoreSupport/WebFrameLoaderClient.h:
4326 * WebCoreSupport/WebFrameLoaderClient.mm:
4327 (WebFrameLoaderClient::dispatchDidReceiveContentLength):
4329 2011-04-18 Jia Pu <jpu@apple.com>
4331 Reviewed by Mark Rowe.
4333 WebKit needs to stop importing <AppKit/NSTextChecker.h>
4334 https://bugs.webkit.org/show_bug.cgi?id=58798
4335 <rdar://problem/9294938>
4337 Use public header <AppKit/NSSpellChecker.h> instead.
4339 * WebCoreSupport/CorrectionPanel.h:
4340 * WebCoreSupport/CorrectionPanel.mm:
4341 (correctionIndicatorType):
4342 (CorrectionPanel::show):
4343 (CorrectionPanel::dismissInternal):
4344 (CorrectionPanel::handleAcceptedReplacement):
4345 * WebCoreSupport/WebEditorClient.mm:
4346 * WebView/WebView.mm:
4348 2011-04-17 Cameron Zwarich <zwarich@apple.com>
4350 Reviewed by Timothy Hatcher.
4352 Stop using -[NSString initWithContentsOfFile:]
4353 https://bugs.webkit.org/show_bug.cgi?id=58763
4355 -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
4357 * WebView/WebView.mm:
4358 (leakMailQuirksUserScriptContents):
4359 (leakOutlookQuirksUserScriptContents):
4361 2011-04-17 David Kilzer <ddkilzer@apple.com>
4363 <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
4364 <rdar://problem/9268729>
4366 Reviewed by Dan Bernstein.
4368 This replaces support for the WebKitEnableHTTPPipelining user
4369 default with methods on the WebCore::ResourceRequest class in
4370 WebCore, the WebView class in WebKit1, and the WebContext class
4371 in WebKit2. It also removes support for the
4372 WebKitForceHTTPPipeliningPriorityHigh user default which was not
4375 * WebView/WebView.mm:
4376 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
4377 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
4378 * WebView/WebViewPrivate.h:
4379 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
4380 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
4382 2011-04-17 Joseph Pecoraro <joepeck@webkit.org>
4384 Reviewed by Dan Bernstein.
4386 Assign to self in WebInspectorWindowController constructors
4387 https://bugs.webkit.org/show_bug.cgi?id=58749
4389 * WebCoreSupport/WebInspectorClient.mm:
4390 (-[WebInspectorWindowController init]):
4391 (-[WebInspectorWindowController initWithInspectedWebView:]):
4393 2011-04-17 Joseph Pecoraro <joepeck@webkit.org>
4395 Reviewed by Timothy Hatcher.
4397 Move WebNodeHighlighter into its own file
4398 https://bugs.webkit.org/show_bug.cgi?id=58746
4400 Extract this class into its own file alongside the
4401 other WebNodeHighlight files. In doing so do some
4402 cleanup on WebInspectorClient removing some methods
4403 that were never called.
4405 * WebCoreSupport/WebInspectorClient.mm:
4406 (WebInspectorClient::WebInspectorClient): style fix.
4407 * WebInspector/WebNodeHighlighter.h: Added.
4408 * WebInspector/WebNodeHighlighter.mm: Added.
4409 (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
4410 (-[WebNodeHighlighter dealloc]):
4411 (-[WebNodeHighlighter highlightNode:]):
4412 (-[WebNodeHighlighter hideHighlight]):
4413 (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
4414 (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
4416 2011-04-15 Jia Pu <jpu@apple.com>
4418 Reviewed by Dan Bernstein.
4420 [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
4421 https://bugs.webkit.org/show_bug.cgi?id=58717
4423 Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
4425 * WebCoreSupport/CorrectionPanel.mm:
4426 (CorrectionPanel::show):
4428 2011-04-15 Shishir Agrawal <shishir@chromium.org>
4430 Reviewed by James Robinson.
4432 Add a flag to guard Page Visibility API changes.
4433 https://bugs.webkit.org/show_bug.cgi?id=58464
4435 * Configurations/FeatureDefines.xcconfig:
4437 2011-04-15 Oliver Hunt <oliver@apple.com>
4439 GC allocate Structure
4440 https://bugs.webkit.org/show_bug.cgi?id=58483
4442 Rolling r83894 r83827 r83810 r83809 r83808 back in with
4443 a workaround for the gcc bug seen by the gtk bots
4445 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
4446 * Plugins/Hosted/ProxyInstance.mm:
4447 (WebKit::ProxyRuntimeMethod::createStructure):
4448 * Plugins/Hosted/ProxyRuntimeObject.h:
4449 (WebKit::ProxyRuntimeObject::createStructure):
4451 2011-04-14 Alexey Proskuryakov <ap@apple.com>
4453 Reviewed by Dan Bernstein.
4455 WebKit2: Password field input does not switch to ASCII-compatible source
4456 https://bugs.webkit.org/show_bug.cgi?id=58583
4457 <rdar://problem/9059651>
4459 Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
4460 necessary logic, needed to return a nil text input context when in password fields.
4462 * WebView/WebHTMLView.mm:
4463 (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
4464 (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
4465 (-[WebHTMLView windowDidResignKey:]): Ditto.
4466 (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
4467 because the first responder is still different an this point, so set a boolean variable to
4468 let _updateSecureInputState know what's going on.
4469 (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
4470 (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
4471 allowed input sources accorsing to current selection.
4472 (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
4474 2011-04-15 Sam Weinig <sam@webkit.org>
4476 Reviewed by Maciej Stachowiak.
4478 Make mac WebKit1 use the default localization strategy
4479 https://bugs.webkit.org/show_bug.cgi?id=58628
4481 * WebCoreSupport/WebPlatformStrategies.h:
4482 * WebCoreSupport/WebPlatformStrategies.mm:
4483 Remove the localization strategy code. The equivalent is now
4484 in WebCore/platform/DefaultLocalizationStrategy.cpp.
4486 2011-04-15 Anna Cavender <annacc@chromium.org>
4488 Reviewed by Eric Carlson.
4490 Renaming TRACK feature define to VIDEO_TRACK
4491 https://bugs.webkit.org/show_bug.cgi?id=53556
4493 * Configurations/FeatureDefines.xcconfig:
4495 2011-04-14 Pratik Solanki <psolanki@apple.com>
4497 Reviewed by David Kilzer.
4499 Set minimum priority for fast lane connections
4500 https://bugs.webkit.org/show_bug.cgi?id=58353
4502 * WebCoreSupport/WebSystemInterface.mm:
4503 (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
4505 2011-04-13 Sam Weinig <sam@webkit.org>
4507 Reviewed by Gavin Barraclough.
4509 WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
4510 <rdar://problem/9260518>
4512 * WebCoreSupport/WebSystemInterface.mm:
4513 (InitWebCoreSystemInterface):
4514 Initialize new WKSI functions.
4516 2011-04-13 David Kilzer <ddkilzer@apple.com>
4518 <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
4520 Reviewed by Anders Carlsson.
4522 Fixes the following warning with -Wcast-align enabled:
4524 Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
4525 archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
4526 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4528 * Plugins/WebBasePluginPackage.mm:
4529 (-[WebBasePluginPackage isNativeLibraryData:]): Added
4530 COMPILE_ASSERT() to make sure our pointer math is valid.
4531 Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
4532 by sizeof(uint32_t) to fix the pointer math. Replaced C-style
4533 casts with reinterpret_cast.
4535 2011-04-12 Enrica Casucci <enrica@apple.com>
4537 Reviewed by Alexey Proskuryakov.
4539 Infinite recursion in WebHTMLView executeSavedKeypressCommands.
4540 https://bugs.webkit.org/show_bug.cgi?id=58382
4541 <rdar://problem/9239370>
4543 Execution of some editing commands could trigger a call to selectedRange that
4544 internally calls executeSavedKeypressCommands creating an infinite recursion.
4546 * WebView/WebHTMLView.mm:
4547 (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
4548 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
4550 2011-04-12 Alice Liu <alice.liu@apple.com>
4552 Reviewed by Sam Weinig.
4554 https://bugs.webkit.org/show_bug.cgi?id=58292
4555 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
4557 * WebView/WebPreferenceKeysPrivate.h: Add preference key.
4558 * WebView/WebPreferences.mm:
4559 (+[WebPreferences initialize]): Initialize to false.
4560 (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
4561 (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
4562 * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
4563 * WebView/WebView.mm:
4564 (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes.
4566 2011-04-11 Alexey Proskuryakov <ap@apple.com>
4568 Reviewed by Maciej Stachowiak.
4570 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
4571 https://bugs.webkit.org/show_bug.cgi?id=58175
4572 <rdar://problem/9060555>
4574 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
4575 should be changed to match WebKit2.
4577 2011-04-06 Timothy Hatcher <timothy@apple.com>
4579 Fix a bug where the context menu does not show in PDF documents if there is no
4580 UI delegate or the UI delegate does not respond to the context menu selector.
4582 https://webkit.org/b/57958
4584 Reviewed by Darin Adler.
4586 * WebView/WebView.mm:
4587 (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
4588 if UIDelegate is nil or doesn't respond to the selector. So check that
4589 here to distinguish between using defaultMenuItems or the delegate
4590 really returning nil to say "no context menu".
4592 2011-04-11 Jer Noble <jer.noble@apple.com>
4594 Unreviewed; roll out unintentional change to WebFullScreenController.mm.
4596 * WebView/WebFullScreenController.mm:
4597 (-[WebFullScreenController enterFullscreen:]):
4599 2011-04-08 Geoffrey Garen <ggaren@apple.com>
4601 Reviewed by Oliver Hunt.
4603 A few heap-related renames and file moves.
4605 WeakGCPtr<T> => Weak<T>
4606 Global<T> => Strong<T>
4608 collector/* => heap/*
4609 runtime/WeakGCPtr.h => heap/Weak.h
4611 (Eventually, even more files should move into the heap directory. Like
4612 Heap.h and Heap.cpp, for example.)
4614 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
4615 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4616 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
4617 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
4618 (WebKit::NetscapePluginInstanceProxy::evaluate):
4619 * WebView/WebScriptDebugger.h:
4621 2011-04-08 Alexey Proskuryakov <ap@apple.com>
4623 Reviewed by Darin Adler.
4625 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
4626 https://bugs.webkit.org/show_bug.cgi?id=58175
4627 <rdar://problem/9060555>
4629 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
4630 should be changed to match WebKit2.
4632 2011-04-08 Alpha Lam <hclam@chromium.org>
4634 Unreviewed, rolling out r83335.
4635 http://trac.webkit.org/changeset/83335
4636 https://bugs.webkit.org/show_bug.cgi?id=53556
4638 GTK and QT bots are broken
4640 * Configurations/FeatureDefines.xcconfig:
4642 2011-04-07 Anna Cavender <annacc@chromium.org>
4644 Reviewed by Eric Carlson.
4646 Setup ENABLE(TRACK) feature define
4647 https://bugs.webkit.org/show_bug.cgi?id=53556
4649 * Configurations/FeatureDefines.xcconfig:
4651 2011-04-08 Maciej Stachowiak <mjs@apple.com>
4653 Reviewed by Darin Adler.
4655 -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
4656 https://bugs.webkit.org/show_bug.cgi?id=58128
4657 <rdar://problem/9244553>
4659 The root of the problem here was an O(N^2) issue - each WebView,
4660 upon having its preferences initialized, would broadcast a
4661 notification that was listened to by all other WebViews sharing
4664 To maintain the API contract, I split the notification into two,
4665 one that is for public API consumption, and the other which is for
4666 internal use only. Changes that don't need to be picked up by
4667 other WebViews broadcast the public notification only. And we
4668 avoid WebView broadcasting a notification just to get itself to
4671 * Misc/WebIconDatabase.mm:
4672 (-[WebIconDatabase _startUpIconDatabase]):
4673 (-[WebIconDatabase _shutDownIconDatabase]):
4674 * Plugins/WebBaseNetscapePluginView.mm:
4675 (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
4676 (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
4677 (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
4678 (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
4679 * WebView/WebPreferences.mm:
4680 (-[WebPreferences initWithIdentifier:]):
4681 (-[WebPreferences _setStringValue:forKey:]):
4682 (-[WebPreferences _setIntegerValue:forKey:]):
4683 (-[WebPreferences _setFloatValue:forKey:]):
4684 (-[WebPreferences _setBoolValue:forKey:]):
4685 (-[WebPreferences _setLongLongValue:forKey:]):
4686 (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
4687 (-[WebPreferences _postPreferencesChangedNotification]):
4688 (-[WebPreferences _postPreferencesChangedAPINotification]):
4689 * WebView/WebPreferencesPrivate.h:
4690 * WebView/WebView.mm:
4691 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
4692 (-[WebView _preferencesChangedNotification:]):
4693 (-[WebView _preferencesChanged:]):
4694 (-[WebView setUsesPageCache:]):
4695 (+[WebView initialize]):
4696 (-[WebView setPreferences:]):
4697 (-[WebView _keyboardUIMode]):
4698 * WebView/WebViewInternal.h:
4700 2011-04-07 Andrew Scherkus <scherkus@chromium.org>
4702 Revert ENABLE_TRACK patch due to compile failures.
4704 * Configurations/FeatureDefines.xcconfig:
4706 2011-04-07 Alexey Proskuryakov <ap@apple.com>
4708 Reviewed by Anders Carlsson.
4710 REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
4711 https://bugs.webkit.org/show_bug.cgi?id=58066
4712 <rdar://problem/8965302>
4714 * WebView/WebHTMLRepresentation.mm:
4715 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
4716 * WebView/WebHTMLView.mm:
4717 (-[WebHTMLView attributedSubstringFromRange:]):
4718 (-[WebHTMLView attributedString]):
4719 (-[WebHTMLView selectedAttributedString]):
4720 Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
4722 2011-04-07 Andy Estes <aestes@apple.com>
4724 Reviewed by Darin Adler.
4726 REGRESSION (r64712): Microsoft Outlook 2011: original message contents
4727 not included when replying to an email.
4728 https://bugs.webkit.org/show_bug.cgi?id=57794
4730 Outlook populates a reply message by creating an empty WebView and
4731 using DOM API to populate the WebView's empty document with content
4732 from the original message. It expects the initial empty document to
4733 simply be "<html></html>", and it proceeds to dynamically create and
4734 append a BODY node and add the original message content as a child of
4735 that node. Outlook then takes the innerHTML of the frame's first body
4736 element and copies it into a *new* document that is displayed and
4737 edited in the reply message window.
4739 Due to implementing the HTML5 tree building algorithm in r64712,
4740 initial empty documents went from being "<html></html>" to being
4741 "<html><head></head><body></body></html>". Outlook still dynamically
4742 creates a BODY node to parent the original message content, but this
4743 BODY node duplicates the one created by the tree builder. When Outlook
4744 then takes the innerHTML of the first body element to populate the
4745 reply message window it gets the empty body element created by the
4746 parser, not the one it created with the original message content.
4748 Fix this by injecting a user script into the initial empty document
4749 that removes the HEAD and BODY nodes created by the parser. This
4750 ensures that the BODY created by Outlook is the only BODY in the
4753 * Misc/OutlookQuirksUserScript.js: Added.
4754 * WebView/WebView.mm:
4755 (leakMailQuirksUserScriptContents):
4756 (-[WebView _injectMailQuirksScript]):
4757 (needsOutlookQuirksScript):
4758 (leakOutlookQuirksUserScriptContents):
4759 (-[WebView _injectOutlookQuirksScript]):
4760 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
4762 2011-04-06 Dai Mikurube <dmikurube@chromium.org>
4764 Reviewed by David Levin.
4766 Add QUOTA build flag for unified quota API
4767 https://bugs.webkit.org/show_bug.cgi?id=57918
4769 * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
4771 2011-04-06 Robert Sesek <rsesek@chromium.org>
4773 Reviewed by Alexey Proskuryakov.
4775 Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
4776 https://bugs.webkit.org/show_bug.cgi?id=54969
4778 * WebView/WebFrame.mm:
4779 (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
4780 (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
4782 2011-04-05 Alexey Proskuryakov <ap@apple.com>
4784 Reviewed by Darin Adler.
4786 Move attributedStringFromRange down to WebCore
4787 https://bugs.webkit.org/show_bug.cgi?id=57905
4789 * Misc/WebNSAttributedStringExtras.h: Removed.
4790 * Misc/WebNSAttributedStringExtras.mm: Removed.
4791 * WebView/WebHTMLRepresentation.mm:
4792 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
4793 * WebView/WebHTMLView.mm:
4794 (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
4795 (-[WebHTMLView attributedSubstringFromRange:]):
4796 (-[WebHTMLView attributedString]):
4797 (-[WebHTMLView selectedAttributedString]):
4798 * WebView/WebPDFView.mm:
4799 (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
4801 2011-04-04 MORITA Hajime <morrita@google.com>
4803 Reviewed by Ryosuke Niwa.
4805 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
4806 https://bugs.webkit.org/show_bug.cgi?id=56085
4808 Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
4809 NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
4810 for requestCheckingOfString method.
4812 * WebCoreSupport/WebEditorClient.h:
4813 * WebCoreSupport/WebEditorClient.mm:
4814 (toCoreTextCheckingResults):
4815 (WebEditorClient::checkTextOfParagraph):
4816 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
4817 (-[WebEditorSpellCheckResponder perform]):
4818 (WebEditorClient::requestCheckingOfString):
4819 * WebView/WebFrame.mm:
4820 (-[WebFrame markersForSelectionStartAsText]):
4821 * WebView/WebFramePrivate.h:
4823 2011-04-05 Anders Carlsson <andersca@apple.com>
4825 Didn't mean to land this.
4827 * Plugins/WebNetscapePluginView.mm:
4828 (-[WebNetscapePluginView getVariable:value:]):
4830 2011-04-04 David Kilzer <ddkilzer@apple.com>
4832 <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
4834 Reviewed by Alexey Proskuryakov.
4836 * WebCoreSupport/WebSystemInterface.mm:
4837 (InitWebCoreSystemInterface): Added initialization for
4838 wkSetHTTPPipeliningMaximumPriority().
4840 2011-04-04 Alexey Proskuryakov <ap@apple.com>
4842 Reviewed by Dan Bernstein.
4844 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
4845 https://bugs.webkit.org/show_bug.cgi?id=51230
4846 <rdar://problem/8780989>
4848 * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
4849 WebKits to WebCore, because WebKit shouldn't be smart.
4851 2011-04-01 Alexey Proskuryakov <ap@apple.com>
4853 Reviewed by Darin Adler.
4855 REGRESSION: Assertion failure when executing a complex custom key binding
4856 https://bugs.webkit.org/show_bug.cgi?id=57681
4858 * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
4859 commands when they can't possibly change the result.
4861 2011-04-01 Anders Carlsson <andersca@apple.com>
4863 Reviewed by Sam Weinig.
4865 Shockwave plug-in doesn't accept mouse events
4866 https://bugs.webkit.org/show_bug.cgi?id=57653
4867 <rdar://problem/8483273>
4869 Fix an unrelated bug found by the added test.
4871 * Plugins/WebBaseNetscapePluginView.mm:
4872 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
4873 Make sure to always set destX and destY.
4875 2011-04-01 Alexey Proskuryakov <ap@apple.com>
4877 Reviewed by Darin Adler.
4879 Make WebKit2 text input handling more like WebKit1
4880 https://bugs.webkit.org/show_bug.cgi?id=57649
4882 * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
4883 * WebView/WebHTMLView.mm:
4884 (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
4885 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
4886 (-[WebHTMLView characterIndexForPoint:]): Ditto.
4887 (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
4888 (-[WebHTMLView selectedRange]): Ditto.
4889 (-[WebHTMLView markedRange]): Ditto.
4890 (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
4891 (-[WebHTMLView hasMarkedText]): Ditto.
4892 (-[WebHTMLView unmarkText]): Ditto.
4893 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
4894 type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
4895 be able to call text input protocol methods from here (and we didn't even reset it back on
4896 return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
4897 (-[WebHTMLView insertText:]): Ditto.
4899 2011-04-01 Timothy Hatcher <timothy@apple.com>
4901 Make momentum scroll event latching work in WebKit2 on Mac.
4903 <rdar://problem/8751861>
4905 Reviewed by Darin Adler.
4907 * WebCoreSupport/WebSystemInterface.mm:
4908 (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
4909 * WebView/WebDynamicScrollBarsView.mm:
4910 (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
4912 2011-03-31 Darin Adler <darin@apple.com>
4914 Reviewed by Anders Carlsson.
4916 Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
4917 https://bugs.webkit.org/show_bug.cgi?id=26667
4919 * WebView/WebHTMLView.mm:
4920 (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
4921 nil rather than asserting that it is non-nil. One case where WebView will be nil
4922 is when the frame is closed, but in any case where it is nil, the correct thing
4923 to do is to not try to handle the style key.
4925 2011-03-31 Alexey Proskuryakov <ap@apple.com>
4927 Patch by John Harvey, reviewed and tweaked by me.
4929 <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
4931 * Plugins/Hosted/WebTextInputWindowController.m:
4932 (-[WebTextInputPanel _interpretKeyEvent:string:]):
4934 2011-03-31 Evan Martin <evan@chromium.org>
4936 Reviewed by Eric Seidel.
4938 <title> should support dir attribute
4939 https://bugs.webkit.org/show_bug.cgi?id=50961
4941 Update to new FrameLoaderClient interface.
4943 * WebCoreSupport/WebFrameLoaderClient.h:
4944 * WebCoreSupport/WebFrameLoaderClient.mm:
4945 (WebFrameLoaderClient::dispatchDidReceiveTitle):
4946 (WebFrameLoaderClient::setTitle):
4948 2011-03-30 Dominic Cooney <dominicc@google.com>
4950 Reviewed by Dimitri Glazkov.
4952 Adds layoutTestController.shadowRoot accessor to Mac DRT.
4953 https://bugs.webkit.org/show_bug.cgi?id=57415
4955 * DOM/WebDOMOperations.mm:
4956 (-[DOMElement _shadowRoot:]):
4957 * DOM/WebDOMOperationsPrivate.h:
4959 2011-03-30 Alexey Proskuryakov <ap@apple.com>
4961 Reviewed by Darin Adler.
4963 WebHTMLView shouldn't resend noop: commands
4964 https://bugs.webkit.org/show_bug.cgi?id=57504
4965 <rdar://problem/9209390>
4967 * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
4968 which we get e.g. when handling Cmd-key combos.
4970 2011-03-30 Alexey Proskuryakov <ap@apple.com>
4972 Reviewed by Darin Adler.
4974 REGRESSION (r82320): Spacebar no longer pages down
4975 https://bugs.webkit.org/show_bug.cgi?id=57423
4976 <rdar://problem/9207702>
4978 Also includes some unrelated cleanup that I had in my tree.
4980 * WebView/WebHTMLView.mm:
4981 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
4982 being dispatched to the right frame.
4983 (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
4984 (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
4985 Even if this specific command hasn't been handled, that doesn't nullify side effects from
4987 (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
4988 bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
4989 another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
4990 going to look at it.
4992 2011-03-30 Sam Weinig <sam@webkit.org>
4994 Reviewed by Brady Eidson.
4996 WebKit2: Attempting to view css file from url causes it to download
4997 <rdar://problem/9102611>
4998 https://bugs.webkit.org/show_bug.cgi?id=57501
5000 * WebView/WebHTMLRepresentation.h:
5001 * WebView/WebHTMLRepresentation.mm:
5002 (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
5003 * WebView/WebHTMLView.mm:
5004 (+[WebHTMLView unsupportedTextMIMETypes]):
5005 Re-factor unsupportedTextMIMETypes to pull from WebCore's
5006 MIMETypeRegistry, so that the list can be shared with WebKit2.
5008 2011-03-29 Beth Dakin <bdakin@apple.com>
5010 Reviewed by Maciej Stachowiak.
5012 Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
5013 webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
5015 <rdar://problem/8665411>
5017 * Misc/WebNSControlExtras.m:
5018 (-[NSControl sizeToFitAndAdjustWindowHeight]):
5019 * WebCoreSupport/WebChromeClient.mm:
5020 (WebChromeClient::scaleFactor):
5021 * WebView/WebHTMLView.mm:
5022 (-[WebHTMLView viewDidMoveToWindow]):
5023 (-[WebHTMLView attachRootLayer:]):
5025 2011-03-29 Kent Tamura <tkent@chromium.org>
5027 Reviewed by Dimitri Glazkov.
5029 Make validation message bubble testable
5030 https://bugs.webkit.org/show_bug.cgi?id=57290
5032 * WebView/WebView.mm:
5033 (-[WebView _preferencesChangedNotification:]): Copy the private value of
5034 the timer magnification to WebCore::Settings.
5035 (-[WebView validationMessageTimerMagnification]): Added.
5036 (-[WebView setValidationMessageTimerMagnification:]): Added.
5037 * WebView/WebViewData.h: Declare a member for the timer magnification.
5038 * WebView/WebViewData.mm:
5039 (-[WebViewPrivate init]): Initialize the timer magnification.
5040 * WebView/WebViewPrivate.h:
5041 Declare a setter and a getter for the timer magnification.
5043 2011-03-29 Kent Tamura <tkent@chromium.org>
5045 Reviewed by Dimitri Glazkov.
5047 [Mac] Enable interactive-validation tests on Mac DRT
5048 https://bugs.webkit.org/show_bug.cgi?id=57308
5050 * WebView/WebView.mm:
5051 (-[WebView _preferencesChangedNotification:]):
5052 Convey a WebView flag for interactive validation to WebCore::Settings.
5053 (-[WebView interactiveFormValidationEnabled]): Added.
5054 (-[WebView setInteractiveFormValidationEnabled:]): Added.
5055 * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
5056 * WebView/WebViewData.mm:
5057 (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
5058 * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
5060 2011-03-29 Timothy Hatcher <timothy@apple.com>
5062 Update the order of the context menu to better match AppKit on Mac.
5064 <rdar://problem/9054893>
5066 Reviewed by John Sullivan.
5068 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
5069 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
5070 * WebCoreSupport/WebPlatformStrategies.h:
5071 * WebCoreSupport/WebPlatformStrategies.mm:
5072 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
5074 2011-03-29 Alexey Proskuryakov <ap@apple.com>
5076 Reviewed by Darin Adler.
5078 https://bugs.webkit.org/show_bug.cgi?id=57379
5079 Clean up WK1 key event handling logic
5081 No bugs knowingly fixed, but this makes the code more consistent.
5083 * WebView/WebHTMLView.mm:
5084 (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
5085 eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
5086 (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
5087 from other functions. We need to execute saved commands when an input method asks for current
5088 state, because providing stale state could confuse it.
5089 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
5091 (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
5092 the answer would be stale.
5093 (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
5094 (-[WebHTMLView selectedRange]): Ditto.
5095 (-[WebHTMLView markedRange]): Ditto.
5096 (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
5097 (-[WebHTMLView hasMarkedText]): Ditto.
5098 (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
5099 operating on stale data. Also, updated for eventWasHandled renaming.
5100 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
5101 (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
5102 it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
5103 fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
5104 could have a noop: as one of its commands, although that's hardly practical).
5105 Added the same "from input method" logic that we have in insertText: - I don't know of any
5106 IMs that call this method, but we clearly need to execute it as part of IM processing when
5107 there is marked text.
5108 (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
5109 eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
5110 if current selection isn't editable. This is different from doCommandBySelector:, where we
5111 need to give super class a chance to handle the event if our processing fails.
5112 Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
5113 return value of _interpretKeyEvent is computed differently.
5115 2011-03-28 Adele Peterson <adele@apple.com>
5117 Reviewed by Eric Seidel.
5119 Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
5120 https://bugs.webkit.org/show_bug.cgi?id=57173
5122 * WebView/WebFrame.mm:
5123 (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
5124 (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
5125 * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
5127 2011-03-28 Alexey Proskuryakov <ap@apple.com>
5129 Reviewed by Darin Adler.
5131 https://bugs.webkit.org/show_bug.cgi?id=57260
5132 Clean up text input code a little
5134 * WebCoreSupport/WebEditorClient.mm:
5135 (WebEditorClient::handleKeyboardEvent):
5136 (WebEditorClient::handleInputMethodKeydown):
5137 * WebView/WebHTMLViewInternal.h:
5138 Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
5139 anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
5140 and also possibly saves resulting commands for later execution.
5142 * WebView/WebHTMLView.mm:
5143 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
5144 return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
5145 WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
5146 handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
5147 because the first call resulted in no saved commands, becasue it's confusing and apparently
5148 useless (I couldn't find any broken behavior).
5149 (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
5150 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
5151 (-[WebHTMLView doCommandBySelector:]): Ditto.
5152 (-[WebHTMLView insertText:]): Ditto.
5154 * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
5157 2011-03-27 Jer Noble <jer.noble@apple.com>
5159 Reviewed by Maciej Stachowiak.
5161 Full Screen: disable keyboard access by default
5162 https://bugs.webkit.org/show_bug.cgi?id=56684
5164 Take into account whether keyboard access was requested when deciding whether full
5165 screen mode is supported.
5167 * WebCoreSupport/WebChromeClient.h:
5168 * WebCoreSupport/WebChromeClient.mm:
5169 (WebChromeClient::supportsFullScreenForElement):
5170 * WebView/WebView.mm:
5171 (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
5172 * WebView/WebViewInternal.h:
5174 2011-03-26 Jer Noble <jer.noble@apple.com>
5176 Reviewed by Eric Carlson.
5178 Enable the Full Screen API by default in WebKit/mac and WebKit2
5179 https://bugs.webkit.org/show_bug.cgi?id=56956
5181 * WebView/WebPreferences.mm:
5182 (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
5184 2011-03-25 Andy Estes <aestes@apple.com>
5186 Reviewed by Adele Peterson.
5188 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
5189 https://bugs.webkit.org/show_bug.cgi?id=49016
5191 Update objectContentType() implementation to handle the
5192 shouldPreferPlugInsForImages flag.
5194 * WebCoreSupport/WebFrameLoaderClient.h:
5195 * WebCoreSupport/WebFrameLoaderClient.mm:
5196 (WebFrameLoaderClient::objectContentType):
5198 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
5200 Unreviewed, rolling out r81939.
5201 http://trac.webkit.org/changeset/81939
5202 https://bugs.webkit.org/show_bug.cgi?id=57084
5204 Rolling out 81939, as it's causing a number of app cache test
5205 failures. (Requested by jernoble on #webkit).
5207 * WebView/WebView.mm:
5208 (-[WebView _preferencesChangedNotification:]):
5210 2011-03-23 Jer Noble <jer.noble@apple.com>
5212 Reviewed by Maciej Stachowiak.
5214 Application Cache should save audio/ and video/ mime types as flat files
5215 https://bugs.webkit.org/show_bug.cgi?id=53784
5216 <rdar://problem/8932473>
5220 Initialize the AppCache Total size quotas with the values for WebKitPreferences
5223 * WebView/WebView.mm:
5224 (-[WebView _preferencesChangedNotification:]):
5226 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
5228 Unreviewed, rolling out r81916 and r81917.
5229 http://trac.webkit.org/changeset/81916
5230 http://trac.webkit.org/changeset/81917
5231 https://bugs.webkit.org/show_bug.cgi?id=57071
5233 broke a test on platforms that do not have QuickTime installed
5234 (Requested by estes on #webkit).
5236 * WebCoreSupport/WebFrameLoaderClient.h:
5237 * WebCoreSupport/WebFrameLoaderClient.mm:
5238 (WebFrameLoaderClient::objectContentType):
5240 2011-03-24 Andy Estes <aestes@apple.com>
5242 Reviewed by Darin Adler.
5244 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
5245 https://bugs.webkit.org/show_bug.cgi?id=49016
5247 Update objectContentType() implementation to handle the
5248 shouldPreferPlugInsForImages flag.
5250 * WebCoreSupport/WebFrameLoaderClient.h:
5251 * WebCoreSupport/WebFrameLoaderClient.mm:
5252 (WebFrameLoaderClient::objectContentType):
5254 2011-03-24 Geoffrey Garen <ggaren@apple.com>
5256 Reviewed by Oliver Hunt.
5258 Ensure that all compilation takes place within a dynamic global object scope
5259 https://bugs.webkit.org/show_bug.cgi?id=57054
5261 * WebView/WebScriptDebugDelegate.mm:
5262 (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
5264 2011-03-24 Jia Pu <jpu@apple.com>
5266 Reviewed by Darin Adler.
5268 Dismissed reversion suggestion is incorrectly learned.
5269 https://bugs.webkit.org/show_bug.cgi?id=57039
5271 CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
5272 [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
5273 is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
5274 incorrect automatic learning.
5276 * WebCoreSupport/CorrectionPanel.mm:
5277 (CorrectionPanel::dismissInternal):
5279 2011-03-24 David Kilzer <ddkilzer@apple.com>
5281 <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
5283 Reviewed by Joseph Pecoraro.
5285 * Plugins/WebPluginContainerPrivate.h: Changed value of
5286 ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
5288 2011-03-23 Jia Pu <jpu@apple.com>
5290 Reviewed by Darin Adler.
5292 Hook up new AppKit autocorrection UI with WK2.
5293 https://bugs.webkit.org/show_bug.cgi?id=56055
5294 <rdar://problem/8947463>
5296 Please see WebCore/ChangeLog for detail.
5298 * WebCoreSupport/CorrectionPanel.h: Added.
5299 (CorrectionPanel::isShowing):
5300 * WebCoreSupport/CorrectionPanel.mm: Added.
5301 (correctionBubbleType):
5302 (CorrectionPanel::CorrectionPanel):
5303 (CorrectionPanel::~CorrectionPanel):
5304 (CorrectionPanel::show):
5305 (CorrectionPanel::dismiss):
5306 (CorrectionPanel::dismissSoon):
5307 (CorrectionPanel::dismissInternal):
5308 (CorrectionPanel::recordAutocorrectionResponse):
5309 * WebCoreSupport/WebEditorClient.h:
5310 * WebCoreSupport/WebEditorClient.mm:
5311 (WebEditorClient::WebEditorClient):
5312 (WebEditorClient::showCorrectionPanel):
5313 (WebEditorClient::dismissCorrectionPanel):
5314 (WebEditorClient::dismissCorrectionPanelSoon):
5315 (WebEditorClient::recordAutocorrectionResponse):
5316 * WebView/WebView.mm:
5317 (-[WebView handleCorrectionPanelResult:]):
5318 * WebView/WebViewPrivate.h:
5320 2011-03-23 Enrica Casucci <enrica@apple.com>
5322 Reviewed by Alexey Proskuryakov.
5324 Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
5325 https://bugs.webkit.org/show_bug.cgi?id=56974
5326 <rdar://problem/8284642>
5328 This fixes a regression introduced by http://trac.webkit.org/changeset/61794
5329 where readSelectionFromPasteboard was accidentally removed.
5330 This method and writeSelectionToPasteboard are needed to support Mac OS X
5333 * WebView/WebHTMLView.mm:
5334 (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
5335 (-[WebHTMLView readSelectionFromPasteboard:]): Added.
5337 2011-03-23 Brady Eidson <beidson@apple.com>
5339 Reviewed by Sam Weinig.
5341 Change IconDatabase opening to allow for arbitrary filenames
5342 https://bugs.webkit.org/show_bug.cgi?id=56977
5344 * Misc/WebIconDatabase.mm:
5345 (-[WebIconDatabase _startUpIconDatabase]):
5347 2011-03-22 Anton D'Auria <adauria@apple.com>
5349 Reviewed by Alexey Proskuryakov.
5351 Add +[WebApplicationCache getOriginsWithCache]
5352 https://bugs.webkit.org/show_bug.cgi?id=56722
5354 Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
5356 * WebCoreSupport/WebApplicationCache.h:
5357 * WebCoreSupport/WebApplicationCache.mm:
5358 (+[WebApplicationCache originsWithCache]):
5360 2011-03-22 Anders Carlsson <andersca@apple.com>
5362 Reviewed by Sam Weinig.
5364 OBJECT element with DivX source is always downloaded
5365 https://bugs.webkit.org/show_bug.cgi?id=56879
5367 * Plugins/WebBasePluginPackage.mm:
5368 (-[WebBasePluginPackage getPluginInfoFromPLists]):
5369 Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
5370 specifies multiple file extensions in a single element.
5372 2011-03-22 Brady Eidson <beidson@apple.com>
5374 Reviewed by Sam Weinig.
5376 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
5377 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
5379 Note that while the new client calls always come through on the main thread, our mechanisms to
5380 route dispatches to the main thread are still valid and will still work.
5382 Update to the new IconDatabaseClient interface:
5383 * WebCoreSupport/WebIconDatabaseClient.h:
5384 * WebCoreSupport/WebIconDatabaseClient.mm:
5385 (WebIconDatabaseClient::didRemoveAllIcons):
5386 (WebIconDatabaseClient::didImportIconURLForPageURL):
5387 (WebIconDatabaseClient::didImportIconDataForPageURL):
5388 (WebIconDatabaseClient::didChangeIconForPageURL):
5389 (WebIconDatabaseClient::didFinishURLImport):
5391 2011-03-22 Matthew Delaney <mdelaney@apple.com>
5393 Reviewed by Simon Fraser.
5395 Have WebKit push acceleratedDrawing preferences to settings
5396 https://bugs.webkit.org/show_bug.cgi?id=56792
5398 * WebView/WebView.mm:
5400 2011-03-21 Nate Chapin <japhet@chromium.org>
5402 Reviewed by Brady Eidson.
5404 Expose a preference to use caching quirks for QuickLook,
5405 and use it if the QuickLook framework is loaded.
5407 https://bugs.webkit.org/show_bug.cgi?id=38690
5409 * WebView/WebPreferenceKeysPrivate.h:
5410 * WebView/WebPreferences.mm:
5411 (useQuickLookQuirks):
5412 (+[WebPreferences initialize]):
5413 (-[WebPreferences useQuickLookResourceCachingQuirks]):
5414 * WebView/WebPreferencesPrivate.h:
5415 * WebView/WebView.mm:
5416 (-[WebView _preferencesChangedNotification:]):
5418 2011-03-21 Chris Fleizach <cfleizach@apple.com>
5420 Reviewed by Darin Adler.
5422 AX: showContextMenu not working in WK2
5423 https://bugs.webkit.org/show_bug.cgi?id=56734
5425 Implement showContextMenu() so accessibility related code can call this
5426 independent of whether WK1 or WK2 is running.
5428 * WebCoreSupport/WebChromeClient.h:
5429 * WebCoreSupport/WebChromeClient.mm:
5430 (WebChromeClient::showContextMenu):
5432 2011-03-21 Chang Shu <cshu@webkit.org>
5434 Reviewed by Alexey Proskuryakov.
5436 REGRESSION (r79953): Can't type in MS Outlook 2011
5437 https://bugs.webkit.org/show_bug.cgi?id=56665
5439 r79953 removed the WebView level editablity which is persistent no matter whether
5440 underlying document itself is changed and editability gets lost. The resolution is to
5441 set this WebView editable value to WebCore. This avoids the callback from WebCore to
5442 WebKit which was the main goal in r79953 to improve performance.
5444 * WebView/WebView.mm:
5445 (-[WebView setEditable:]):
5446 (-[WebView isEditable]):
5448 2011-03-19 Anton D'Auria <adauria@apple.com>
5450 Reviewed by Alexey Proskuryakov.
5452 ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
5453 https://bugs.webkit.org/show_bug.cgi?id=56415
5455 Use new ApplicationCache API to delete all cache for an origin.
5457 * WebCoreSupport/WebApplicationCache.h:
5458 * WebCoreSupport/WebApplicationCache.mm:
5459 (+[WebApplicationCache deleteOrigin:]):
5461 2011-03-17 Brady Eidson <beidson@apple.com>
5463 Reviewed by Sam Weinig.
5465 https://bugs.webkit.org/show_bug.cgi?id=56425
5466 More groundwork for WebKit2 IconDatabase
5468 Update already-used function names:
5469 * Misc/WebIconDatabase.mm:
5470 (-[WebIconDatabase iconForURL:withSize:cache:]):
5471 (-[WebIconDatabase iconURLForURL:]):
5472 * WebView/WebView.mm:
5473 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
5475 2011-03-18 Pavel Podivilov <podivilov@chromium.org>
5477 Reviewed by Yury Semikhatsky.
5479 Web Inspector: implement inspector session storage.
5480 https://bugs.webkit.org/show_bug.cgi?id=56643
5482 * WebCoreSupport/WebInspectorClient.h:
5483 * WebCoreSupport/WebInspectorClient.mm:
5484 (WebInspectorClient::saveSessionSetting):
5485 (WebInspectorClient::loadSessionSetting):
5486 (WebInspectorFrontendClient::saveSessionSetting):
5487 (WebInspectorFrontendClient::loadSessionSetting):
5488 (-[WebInspectorWindowController inspectorClient]):
5490 2011-03-17 Geoffrey Garen <ggaren@apple.com>
5492 Reviewed by Oliver Hunt.
5494 Fixed a leak seen on the buildbot.
5496 * WebCoreSupport/WebInspectorClient.mm:
5497 (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
5499 2011-03-16 Jeff Johnson <github@lapcatsoftware.com>
5501 Reviewed by Alexey Proskuryakov.
5503 Logic error in -[WebHTMLView close]
5504 https://bugs.webkit.org/show_bug.cgi?id=56445
5506 Page is always nil at this point, because [self _webView] is nil,
5507 so the conditional code is never run.
5509 * WebView/WebHTMLView.mm:
5510 (-[WebHTMLView close]):
5512 2011-03-16 Chris Fleizach <cfleizach@apple.com>
5514 Reviewed by Darin Adler.
5516 WK2: Need to propagate enhanced accessibility flag from UI -> web process
5517 https://bugs.webkit.org/show_bug.cgi?id=56379
5519 * WebView/WebFrame.mm:
5520 (-[WebFrame accessibilityRoot]):
5522 2011-03-15 Oliver Hunt <oliver@apple.com>
5524 Reviewed by Geoffrey Garen.
5526 Make Structure creation require a JSGlobalData
5527 https://bugs.webkit.org/show_bug.cgi?id=56438
5529 Mechanical change to make all Structure creation use a JSGlobalData&
5531 * Plugins/Hosted/ProxyInstance.mm:
5532 (WebKit::ProxyRuntimeMethod::createStructure):
5533 * Plugins/Hosted/ProxyRuntimeObject.h:
5534 (WebKit::ProxyRuntimeObject::createStructure):
5536 2011-03-15 Alexey Proskuryakov <ap@apple.com>
5538 Forgot to save a modification to this file when committing.
5540 * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
5542 2011-03-15 Alexey Proskuryakov <ap@apple.com>
5544 Reviewed by Darin Adler.
5546 REGRESSION (WebKit2): keygen element doesn't work
5547 https://bugs.webkit.org/show_bug.cgi?id=56402
5548 <rdar://problem/9006545>
5550 * WebCoreSupport/WebKeyGenerator.h:
5551 * WebCoreSupport/WebKeyGenerator.m: Removed.
5552 * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
5553 (+[WebKeyGenerator sharedGenerator]):
5554 (toWebCertificateParseResult):
5555 WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
5556 this misnamed and misplaced code for now.
5558 * WebCoreSupport/WebPlatformStrategies.h:
5559 * WebCoreSupport/WebPlatformStrategies.mm:
5560 (WebPlatformStrategies::keygenMenuItem512):
5561 (WebPlatformStrategies::keygenMenuItem1024):
5562 (WebPlatformStrategies::keygenMenuItem2048):
5563 (WebPlatformStrategies::keygenKeychainItemName):
5564 Added strings used by keygen.
5566 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
5567 pointer to a function used by keygen.
5569 * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
5572 2011-03-15 Beth Dakin <bdakin@apple.com>
5574 Reviewed by Simon Fraser.
5576 WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
5578 New WebKitystemInterface function to force the scrollbars to flash
5579 * WebCoreSupport/WebSystemInterface.mm:
5580 (InitWebCoreSystemInterface):
5582 2011-03-15 Ilya Sherman <isherman@chromium.org>
5584 Reviewed by Tony Chang.
5586 Autofilled form elements are assigned fixed background color but not text color
5587 https://bugs.webkit.org/show_bug.cgi?id=48382
5589 * DOM/WebDOMOperations.mm:
5590 (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
5591 * DOM/WebDOMOperationsPrivate.h:
5593 2011-03-15 Adam Roben <aroben@apple.com>
5595 Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
5597 Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
5598 WebStorageTrackerClient::dispatchDidModifyOrigin
5600 Reviewed by Antti Koivisto.
5602 * Storage/WebStorageTrackerClient.mm:
5603 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
5604 to us by dispatchDidModifyOrigin.
5605 (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
5608 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
5610 Reviewed by Darin Adler.
5612 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
5613 info into the headers rather than in export symbol definition files, but disable it on
5614 all platforms initially so we can deal with port build issues one port at a time.
5616 https://bugs.webkit.org/show_bug.cgi?id=27551
5620 2011-03-14 Brady Eidson <beidson@apple.com>
5622 Reviewed by Anders Carlsson.
5624 https://bugs.webkit.org/show_bug.cgi?id=56320
5625 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
5627 * History/WebHistoryItem.mm:
5628 (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
5630 2011-03-13 Pratik Solanki <psolanki@apple.com>
5632 Reviewed by Brady Eidson.
5634 Make adjustMIMETypeIfNecessary use CFNetwork directly
5635 https://bugs.webkit.org/show_bug.cgi?id=55912
5637 * WebCoreSupport/WebSystemInterface.mm:
5638 (InitWebCoreSystemInterface): Support for new WKSI functions.
5640 2011-03-12 Mark Rowe <mrowe@apple.com>
5642 Fix the 32-bit build.
5644 * Carbon/CarbonWindowAdapter.mm:
5645 (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
5646 (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
5648 2011-03-11 Brady Eidson <beidson@apple.com>
5650 Reviewed by Anders Carlsson
5652 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
5653 Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
5655 * Misc/WebIconDatabase.mm:
5656 (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
5657 (-[WebIconDatabase _startUpIconDatabase]): Ditto.
5658 (importToWebCoreFormat):
5660 2011-03-11 Anton D'Auria <adauria@apple.com>
5662 Reviewed and landed by Brady Eidson.
5664 https://bugs.webkit.org/show_bug.cgi?id=51878
5665 Add WebKit1 API to view and delete local storage
5667 * Storage/WebStorageManager.mm: Added.
5668 (+[WebStorageManager sharedWebStorageManager]):
5669 (-[WebStorageManager origins]):
5670 (-[WebStorageManager deleteAllOrigins]):
5671 (-[WebStorageManager deleteOrigin:]):
5672 (-[WebStorageManager syncLocalStorage]):
5673 (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
5674 (storageDirectoryPath):
5675 (WebKitInitializeStorageIfNecessary):
5676 * Storage/WebStorageManagerInternal.h: Added.
5677 * Storage/WebStorageManagerPrivate.h: Added.
5678 * Storage/WebStorageTrackerClient.h: Added.
5679 * Storage/WebStorageTrackerClient.mm: Added.
5680 (WebStorageTrackerClient::sharedWebStorageTrackerClient):
5681 (WebStorageTrackerClient::WebStorageTrackerClient):
5682 (WebStorageTrackerClient::~WebStorageTrackerClient):
5683 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
5684 (WebStorageTrackerClient::dispatchDidModifyOrigin):
5685 * WebCoreSupport/WebSecurityOrigin.mm:
5686 (-[WebSecurityOrigin protocol]):
5687 (-[WebSecurityOrigin host]):
5688 (-[WebSecurityOrigin databaseIdentifier]):
5689 (-[WebSecurityOrigin domain]):
5690 (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
5691 * WebCoreSupport/WebSecurityOriginPrivate.h:
5693 * WebView/WebView.mm:
5694 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
5696 2011-03-10 Anders Carlsson <andersca@apple.com>
5698 Reviewed by Sam Weinig.
5700 <rdar://problem/9117047>
5701 Don't paint more than 60 times per second even when scrolling
5703 * WebView/WebClipView.mm:
5704 (-[WebClipView _immediateScrollToPoint:]):
5706 2011-03-09 Matthew Delaney <mdelaney@apple.com>
5708 Reviewed by Simon Fraser.
5710 Plumb through settings for accelerated drawing for canvas
5711 https://bugs.webkit.org/show_bug.cgi?id=56039
5713 * WebView/WebPreferenceKeysPrivate.h:
5714 * WebView/WebPreferences.mm:
5715 * WebView/WebPreferencesPrivate.h:
5717 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
5719 Reviewed by Tony Chang.
5721 VisiblePosition's next and previous should take an enum instead of a boolean
5722 https://bugs.webkit.org/show_bug.cgi?id=56135
5724 SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
5725 StayInEditableContent.
5727 * WebView/WebView.mm:
5728 (-[WebView _selectionIsAll]):
5730 2011-03-09 Jessie Berlin <jberlin@apple.com>
5732 Reviewed by Adam Roben.
5734 Use the Cookie Storage from the Private Browsing Storage Session directly
5735 https://bugs.webkit.org/show_bug.cgi?id=55986
5737 * WebCoreSupport/WebSystemInterface.mm:
5738 (InitWebCoreSystemInterface):
5740 2011-03-08 Darin Adler <darin@apple.com>
5742 Reviewed by Timothy Hatcher.
5744 Promote a method used outside WebKit from internal to private
5745 https://bugs.webkit.org/show_bug.cgi?id=55949
5747 * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
5748 Minor tweak, not directly related to the rest of this patch.
5750 * WebView/WebFrame.mm:
5751 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
5752 this method from the internal category into the private category.
5753 Streamlined the code a bit.
5755 * WebView/WebFrameInternal.h: Removed _computePageRects method.
5756 * WebView/WebFramePrivate.h: Added _computePageRects method.
5758 2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
5760 Reviewed by Darin Adler.
5762 selectionHasStyle and selectionStartHasStyle should use EditingStyle
5763 https://bugs.webkit.org/show_bug.cgi?id=55902
5765 selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
5767 * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
5768 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
5770 2011-03-07 Dan Bernstein <mitz@apple.com>
5772 LLVM Compiler build fix.
5774 * WebCoreSupport/WebEditorClient.mm:
5775 (WebEditorClient::checkGrammarOfString):
5777 2011-03-07 Chris Fleizach <cfleizach@apple.com>
5779 Reviewed by Beth Dakin.
5781 AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
5782 https://bugs.webkit.org/show_bug.cgi?id=55706
5784 Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
5785 returns the scroll bar objects).
5786 Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
5787 will expect that as its child, instead of the WebCore ScrollView object.
5789 * WebView/WebDynamicScrollBarsView.mm:
5790 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
5791 * WebView/WebFrame.mm:
5792 (-[WebFrame accessibilityRoot]):
5794 2011-03-07 Sam Weinig <sam@webkit.org>
5796 Reviewed by Anders Carlsson.
5798 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
5799 https://bugs.webkit.org/show_bug.cgi?id=55827
5801 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
5802 and pass the entire response, instead of just the MIMEType.
5804 * WebCoreSupport/WebFrameLoaderClient.h:
5805 * WebCoreSupport/WebFrameLoaderClient.mm:
5806 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
5808 2011-03-06 Dan Bernstein <mitz@apple.com>
5810 LLVM Compiler build fix.
5812 * DOM/WebDOMOperations.mm:
5813 (-[DOMHTMLInputElement _setValueForUser:]):
5815 2011-03-06 Jessie Berlin <jberlin@apple.com>
5817 Reviewed by Sam Weinig.
5819 WebKit2: Use CFNetwork Sessions API.
5820 https://bugs.webkit.org/show_bug.cgi?id=55435.
5822 When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
5823 Private Browsing Storage Session.
5825 * WebCoreSupport/WebSystemInterface.mm:
5826 (InitWebCoreSystemInterface):
5827 Add support for using the new WKSI functions in WebCore.
5829 2011-03-05 Ilya Sherman <isherman@chromium.org>
5831 Reviewed by Darin Adler.
5833 HTMLInputElement::setValue() should schedule change event when the element is focused
5834 In service of https://code.google.com/p/chromium/issues/detail?id=42716
5835 https://bugs.webkit.org/show_bug.cgi?id=53160
5837 * DOM/WebDOMOperations.mm:
5838 (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
5839 * DOM/WebDOMOperationsPrivate.h:
5840 * WebView/WebViewInternal.h:
5842 2011-03-04 Jia Pu <jpu@apple.com>
5844 Reviewed by Darin Adler.
5846 On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
5847 https://bugs.webkit.org/show_bug.cgi?id=55717
5848 <rdar://problem/9018127>
5850 With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
5851 is already in window coordinate. We don't need to do further conversion anymore.
5853 * WebCoreSupport/WebEditorClient.mm:
5854 (WebEditorClient::showCorrectionPanel):
5856 2011-03-04 Jessie Berlin <jberlin@apple.com>
5858 Reviewed by Maciej Stachowiak.
5860 WebKit2: Use CFNetwork Sessions API.
5861 https://bugs.webkit.org/show_bug.cgi?id=55435.
5863 When Private Browsing is enabled, get the cached url response from the cache associated with
5864 the Private Browsing Storage Session.
5866 * WebView/WebView.mm:
5867 (-[WebView _cachedResponseForURL:]):
5869 2011-03-03 Anders Carlsson <andersca@apple.com>
5871 Reviewed by Sam Weinig.
5873 Get rid of Page::globalHistoryItem
5874 https://bugs.webkit.org/show_bug.cgi?id=55738
5876 * WebCoreSupport/WebFrameLoaderClient.h:
5877 * WebCoreSupport/WebFrameLoaderClient.mm:
5878 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
5879 Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
5881 * WebView/WebView.mm:
5882 (-[WebView _globalHistoryItem]):
5883 (-[WebView _setGlobalHistoryItem:]):
5884 Set _globalHistoryItem ivar.
5886 * WebView/WebViewData.h:
5887 * WebView/WebViewData.mm:
5888 Add _globalHistoryItem ivar.
5890 2011-03-03 Brady Eidson <beidson@apple.com>
5892 Reviewed by Darin Adler.
5894 https://bugs.webkit.org/show_bug.cgi?id=55721
5895 Global IconDatabase should be returned by reference, not as a pointer
5897 * Misc/WebCoreStatistics.mm:
5898 (+[WebCoreStatistics iconPageURLMappingCount]):
5899 (+[WebCoreStatistics iconRetainedPageURLCount]):
5900 (+[WebCoreStatistics iconRecordCount]):
5901 (+[WebCoreStatistics iconsWithDataCount]):
5902 * Misc/WebIconDatabase.mm:
5903 (-[WebIconDatabase init]):
5904 (-[WebIconDatabase iconForURL:withSize:cache:]):
5905 (-[WebIconDatabase iconURLForURL:]):
5906 (-[WebIconDatabase defaultIconWithSize:]):
5907 (-[WebIconDatabase retainIconForURL:]):
5908 (-[WebIconDatabase releaseIconForURL:]):
5909 (-[WebIconDatabase isEnabled]):
5910 (-[WebIconDatabase setEnabled:]):
5911 (-[WebIconDatabase removeAllIcons]):
5912 (+[WebIconDatabase _checkIntegrityBeforeOpening]):
5913 (-[WebIconDatabase _startUpIconDatabase]):
5914 (-[WebIconDatabase _applicationWillTerminate:]):
5915 (-[WebIconDatabase _resetCachedWebPreferences:]):
5916 (importToWebCoreFormat):
5917 * WebView/WebView.mm:
5918 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
5920 2011-03-03 Jessie Berlin <jberlin@apple.com>
5922 Reviewed by Adam Roben.
5924 WebKit2: Use CFNetwork Sessions API.
5925 https://bugs.webkit.org/show_bug.cgi?id=55435.
5927 Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
5929 * WebCoreSupport/WebSystemInterface.mm:
5930 (InitWebCoreSystemInterface):
5931 Support using WKCopyRequestWithStorageSession in WebCore.
5933 2011-03-02 Alexey Proskuryakov <ap@apple.com>
5935 Reviewed by Darin Adler.
5937 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
5938 https://bugs.webkit.org/show_bug.cgi?id=55633
5939 <rdar://problem/8963023>
5941 * WebCoreSupport/WebChromeClient.h:
5942 * WebCoreSupport/WebChromeClient.mm:
5943 Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
5945 * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
5946 Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
5947 require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
5948 so I've preserved it.
5950 2011-03-02 Jessie Berlin <jberlin@apple.com>
5952 Rubber-stamped by Dan Bernstein.
5954 Fix crashes in private browsing tests in WK1 on Snow Leopard.
5956 * WebCoreSupport/WebSystemInterface.mm:
5957 (InitWebCoreSystemInterface):
5958 Put the INIT call for wkCreatePrivateStorageSession outside of the
5959 #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
5962 2011-03-02 Jessie Berlin <jberlin@apple.com>
5964 Reviewed by Adam Roben.
5966 WebKit2: Use CFNetwork Sessions API.
5967 https://bugs.webkit.org/show_bug.cgi?id=55435.
5969 Add the ability to create a Private Browsing Storage Session.
5971 * WebCoreSupport/WebSystemInterface.mm:
5972 (InitWebCoreSystemInterface):
5973 Support calling wkCreatePrivateStorageSession from WebCore.
5975 2011-03-02 Daniel Cheng <dcheng@chromium.org>
5977 Reviewed by David Levin.
5979 Add feature define for data transfer items
5980 https://bugs.webkit.org/show_bug.cgi?id=55510
5982 * Configurations/FeatureDefines.xcconfig:
5984 2011-03-02 Sam Weinig <sam@webkit.org>
5986 Reviewed by Anders Carlsson.
5988 Fix remaining localization issues by piping all localized strings through WebCore's
5989 localization bottleneck.
5990 <rdar://problem/8728860>
5992 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
5993 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
5994 * Misc/WebKitErrors.m:
5995 * Misc/WebLocalizableStringsInternal.h: Added.
5996 * Misc/WebLocalizableStringsInternal.mm: Added.
5997 (WebLocalizedStringInternal):
5998 * Panels/WebAuthenticationPanel.m:
5999 (-[WebAuthenticationPanel setUpForChallenge:]):
6000 * Plugins/Hosted/NetscapePluginHostManager.mm:
6001 (WebKit::NetscapePluginHostManager::spawnPluginHost):
6002 * WebCoreSupport/WebEditorClient.mm:
6003 (undoNameForEditAction):
6004 * WebCoreSupport/WebInspectorClient.mm:
6005 (WebInspectorFrontendClient::updateWindowTitle):
6006 (-[WebInspectorWindowController validateUserInterfaceItem:]):
6007 * WebCoreSupport/WebKeyGenerator.m:
6008 (-[WebKeyGenerator strengthMenuItemTitles]):
6009 (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
6010 * WebCoreSupport/WebPlatformStrategies.mm:
6011 * WebView/WebHTMLView.mm:
6012 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
6013 * WebView/WebPDFView.mm:
6014 (-[WebPDFView menuForEvent:]):
6016 2011-03-01 Brian Weinstein <bweinstein@apple.com>
6018 Reviewed by Adam Roben.
6020 Part of WebKit2: Need a way to send notifications to client when cookies change
6021 https://bugs.webkit.org/show_bug.cgi?id=55427
6022 <rdar://problem/9056027>
6024 Add stubs for CookiesStrategy on Mac WebKit1.
6026 * WebCoreSupport/WebPlatformStrategies.h:
6027 * WebCoreSupport/WebPlatformStrategies.mm:
6028 (WebPlatformStrategies::createCookiesStrategy):
6029 (WebPlatformStrategies::notifyCookiesChanged):
6031 2011-03-01 Philippe Normand <pnormand@igalia.com>
6033 Reviewed by Eric Carlson.
6035 [GStreamer] support in mac video fullscreen controller
6036 https://bugs.webkit.org/show_bug.cgi?id=52280
6038 Factored the code to configure the video overlay in a new private
6039 method of the controller and added GStreamer support to it.
6041 * WebView/WebVideoFullscreenController.h:
6042 * WebView/WebVideoFullscreenController.mm:
6043 (-[WebVideoFullscreenController setupVideoOverlay:]):
6044 (-[WebVideoFullscreenController windowDidLoad]):
6045 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
6046 (-[WebVideoFullscreenController windowDidExitFullscreen]):
6048 2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
6050 Reviewed by Timothy Hatcher.
6052 All Console Messages should be passed to ChromeClients.
6053 https://bugs.webkit.org/show_bug.cgi?id=54926
6055 Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
6056 which supersedes -webView:addMessageToConsole if it exists. The new delegate
6057 does not filter to only JavaScript originated console messages. The old
6058 delegate is left around for clients that expect filtered messages, like
6059 DashCode and older versions of Safari.
6061 The dictionary message passed to the delegate now includes more information
6062 about the message source, type, and level.
6064 * WebCoreSupport/WebChromeClient.mm:
6065 (stringForMessageSource):
6066 (stringForMessageType):
6067 (stringForMessageLevel):
6068 (WebChromeClient::addMessageToConsole):
6069 * WebView/WebUIDelegatePrivate.h:
6071 2011-03-01 Levi Weintraub <leviw@chromium.org>
6073 Reviewed by Ryosuke Niwa.
6075 Stop instantiating legacy editing Positions in VisiblePosition
6076 https://bugs.webkit.org/show_bug.cgi?id=52919
6078 Changing usage of legacy VisiblePosition constructor. Since we were dealing
6079 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
6081 * WebView/WebFrame.mm:
6082 (-[WebFrame _caretRectAtPosition:affinity:]):
6083 * WebView/WebFrameInternal.h:
6084 * WebView/WebTextCompletionController.mm:
6085 (-[WebTextCompletionController doCompletion]):
6087 2011-03-01 Sam Weinig <sam@webkit.org>
6089 Reviewed by Timothy Hatcher.
6091 WebKit2 needs to be made localizable
6092 https://bugs.webkit.org/show_bug.cgi?id=55483
6094 * WebCoreSupport/WebPlatformStrategies.mm:
6095 Use WebCore's localizedString function instead of WebLocalizableStrings
6096 since WebCore is now responsible for localization.
6098 2011-02-25 Steve Block <steveblock@google.com>
6100 Reviewed by Jeremy Orlow.
6102 Bridge.h should not include BridgeJSC.h
6103 https://bugs.webkit.org/show_bug.cgi?id=55212
6105 Include BridgeJSC.h directly instead.
6107 * Plugins/Hosted/ProxyInstance.h:
6108 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
6110 2011-02-28 Chang Shu <cshu@webkit.org>
6112 Reviewed by Ryosuke Niwa.
6114 Remove the support of Frame::isContentEditable and its dependencies.
6115 https://bugs.webkit.org/show_bug.cgi?id=54292
6117 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
6119 * WebCoreSupport/WebEditorClient.h:
6120 * WebCoreSupport/WebEditorClient.mm:
6121 * WebView/WebView.mm:
6122 (-[WebView setEditable:]):
6123 (-[WebView isEditable]):
6124 * WebView/WebViewData.h:
6126 2011-02-28 Oliver Hunt <oliver@apple.com>
6128 Reviewed by Gavin Barraclough.
6130 Make ScopeChainNode GC allocated
6131 https://bugs.webkit.org/show_bug.cgi?id=55283
6133 More updates for the absence of the ScopeChain class
6135 * WebView/WebScriptDebugDelegate.mm:
6136 (-[WebScriptCallFrame scopeChain]):
6138 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
6140 Reviewed by Pavel Feldman.
6142 DumpRenderTree should reset frame opener between tests.
6143 https://bugs.webkit.org/show_bug.cgi?id=54874
6145 Added clearOpener method to WebFramePrivate.
6147 * WebView/WebFrame.mm:
6148 (-[WebFrame _clearOpener]):
6149 * WebView/WebFramePrivate.h:
6151 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
6153 Unreviewed, rolling out r79764.
6154 http://trac.webkit.org/changeset/79764
6155 https://bugs.webkit.org/show_bug.cgi?id=55295
6157 "broke Chromium builds" (Requested by rniwa on #webkit).
6159 * WebView/WebFrame.mm:
6160 * WebView/WebFramePrivate.h:
6162 2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
6164 Reviewed by David Kilzer.
6166 https://bugs.webkit.org/show_bug.cgi?id=48781
6168 Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
6170 Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
6171 should paint the default broken image when an image fails to load or decode. The method also passes the
6172 URL of the failed image.
6174 * WebCoreSupport/WebFrameLoaderClient.h:
6175 * WebCoreSupport/WebFrameLoaderClient.mm:
6176 (WebFrameLoaderClient::shouldPaintBrokenImage):
6177 * WebView/WebDelegateImplementationCaching.h:
6178 * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
6179 (CallResourceLoadDelegateReturningBoolean):
6180 * WebView/WebResourceLoadDelegatePrivate.h:
6181 * WebView/WebView.mm:
6182 (-[WebView _cacheResourceLoadDelegateImplementations]):
6184 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
6186 Reviewed by Pavel Feldman.
6188 DumpRenderTree should reset frame opener between tests.
6189 https://bugs.webkit.org/show_bug.cgi?id=54874
6191 Added clearOpener method to WebFramePrivate.
6193 * WebView/WebFrame.mm:
6194 (-[WebFrame _clearOpener]):
6195 * WebView/WebFramePrivate.h:
6197 2011-02-25 Mark Rowe <mrowe@apple.com>
6199 <rdar://problem/8902546> Build fix.
6201 * Misc/QuickDrawCompatibility.h:
6203 2011-02-24 Anders Carlsson <andersca@apple.com>
6207 * WebCoreSupport/WebKeyGenerator.m:
6208 (toWebCertificateParseResult):
6209 (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
6210 * WebView/WebTextCompletionController.mm:
6212 2011-02-24 Peter Kasting <pkasting@google.com>
6214 Reviewed by Eric Seidel.
6216 Drop the "U; " encryption level from the User Agent string.
6217 https://bugs.webkit.org/show_bug.cgi?id=54566
6219 * WebView/WebView.mm:
6220 (+[WebView _standardUserAgentWithApplicationName:]):
6222 2011-02-24 Andrew Wilson <atwilson@chromium.org>
6224 Unreviewed, rolling out r79570.
6225 http://trac.webkit.org/changeset/79570
6226 https://bugs.webkit.org/show_bug.cgi?id=54874
6228 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
6231 * WebView/WebFrame.mm:
6232 * WebView/WebFramePrivate.h:
6234 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
6236 Reviewed by Alexey Proskuryakov.
6238 DumpRenderTree should reset frame opener between tests.
6239 https://bugs.webkit.org/show_bug.cgi?id=54874
6241 Added clearOpener method to WebFramePrivate.
6243 * WebView/WebFrame.mm:
6244 (-[WebFrame _clearOpener]):
6245 * WebView/WebFramePrivate.h:
6247 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
6249 Reviewed by Alexey Proskuryakov.
6251 Drop the language tag part from the User Agent string
6252 https://bugs.webkit.org/show_bug.cgi?id=54560
6254 * WebView/WebView.mm:
6255 (+[WebView _standardUserAgentWithApplicationName:]): Drop the
6258 2011-02-22 Brady Eidson <beidson@apple.com>
6260 Reviewed by Anders Carlsson.
6262 Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
6263 API to view and delete Application Cache data by origin.
6265 * WebCoreSupport/WebApplicationCache.mm:
6266 (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
6268 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
6270 Reviewed by Kent Tamura.
6272 Rename Position::node() to Position::deprecatedNode()
6273 https://bugs.webkit.org/show_bug.cgi?id=54622
6275 * WebView/WebFrame.mm:
6276 (-[WebFrame _smartDeleteRangeForProposedRange:]):
6278 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
6280 Reviewed by Kent Tamura.
6282 Rename Position::node() to Position::deprecatedNode()
6283 https://bugs.webkit.org/show_bug.cgi?id=54622
6287 * WebView/WebFrame.mm:
6288 (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
6289 use containerNode() and offsetInContainerNode() instead of deprecated member functions.
6291 2011-02-18 Gavin Barraclough <barraclough@apple.com>
6293 Reviewed by Sam Weinig.
6295 Bug 54786 - Devirtualize JSCell::classInfo()
6297 Instead of making a virtual function call, add a pointer to the ClassInfo
6300 This removes a virtual function call, and paves the way towards removing all
6301 the createStructure methods, and StructureFlags/AnonymousSlotCount properties
6302 (these should be able to move onto ClassInfo).
6304 Calls to Structure::create must now pass a pointer to the ClassInfo for the
6305 structure. All objects now have a ClassInfo pointer, non-object cell types
6308 Changes are most mechanical, involving three steps:
6309 * Remove virtual classInfo() methods.
6310 * Add &s_info parameter to calls to Structure::create.
6311 * Rename ClassInfo static members on classes from 'info' to 's_info',
6314 * Plugins/Hosted/ProxyInstance.mm:
6315 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
6316 (WebKit::ProxyRuntimeMethod::createStructure):
6317 * Plugins/Hosted/ProxyRuntimeObject.h:
6318 (WebKit::ProxyRuntimeObject::createStructure):
6319 * Plugins/Hosted/ProxyRuntimeObject.mm:
6320 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
6321 * WebView/WebView.mm:
6322 (aeDescFromJSValue):
6324 2011-02-19 Brian Ryner <bryner@chromium.org>
6326 Reviewed by Adam Barth.
6328 Add missing #include of DocumentLoader.h, needed since the transitive
6329 include through Document.h is removed.
6330 https://bugs.webkit.org/show_bug.cgi?id=50489
6332 * WebView/WebFrame.mm:
6334 2011-02-19 Charlie Reis <creis@chromium.org>
6336 Reviewed by Mihai Parparita.
6338 Ensure loading has stopped in HistoryController::goToItem
6339 https://bugs.webkit.org/show_bug.cgi?id=54517
6341 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
6343 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
6345 * WebCoreSupport/WebFrameLoaderClient.mm:
6346 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
6347 * WebCoreSupport/WebFrameLoaderClient.h:
6349 2011-02-16 David Hyatt <hyatt@apple.com>
6351 Reviewed by Dan Bernstein.
6353 https://bugs.webkit.org/show_bug.cgi?id=54244
6355 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
6356 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
6358 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
6359 been changed as well.
6361 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
6363 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
6365 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
6366 still have a precise floating point position.
6368 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
6369 be rounding justification spacing in their font code.
6371 Many layout test results change on Mac, since rounding hacks were used there and are now gone.
6373 * Misc/WebKitNSStringExtras.mm:
6374 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
6375 (-[NSString _web_widthWithFont:]):
6377 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
6379 Reviewed by Adam Roben.
6381 HTML5 <details> and <summary>: localized text
6382 https://bugs.webkit.org/show_bug.cgi?id=54260
6384 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
6385 provide the default label to be used by a <details> tag that has no <summary> child.
6387 * WebCoreSupport/WebPlatformStrategies.h:
6388 * WebCoreSupport/WebPlatformStrategies.mm:
6389 (WebPlatformStrategies::defaultDetailsSummaryText):
6391 2011-02-16 Matthew Delaney <mdelaney@apple.com>
6393 Reviewed by Simon Fraser.
6395 Allow acceleratesDrawing for WebKit2
6396 https://bugs.webkit.org/show_bug.cgi?id=54511
6398 Plumb through preference for accelerated drawing.
6400 * WebView/WebPreferenceKeysPrivate.h:
6401 * WebView/WebPreferences.mm:
6402 (+[WebPreferences initialize]):
6403 (-[WebPreferences acceleratedDrawingEnabled]):
6404 (-[WebPreferences setAcceleratedDrawingEnabled:]):
6405 * WebView/WebPreferencesPrivate.h:
6407 2011-02-15 David Kilzer <ddkilzer@apple.com>
6409 <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
6411 Reviewed by Darin Adler.
6413 * WebView/WebDynamicScrollBarsView.h:
6414 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
6416 * WebView/WebDynamicScrollBarsView.mm:
6417 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
6418 implementation into correct category.
6419 * WebView/WebDynamicScrollBarsViewInternal.h:
6420 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
6422 * WebView/WebHTMLView.mm: Included
6423 WebDynamicScrollBarsViewInternal.h instead of
6424 WebDynamicScrollBarsView.h.
6426 2011-02-14 Oliver Hunt <oliver@apple.com>
6428 Reviewed by Gavin Barraclough and Geoff Garen.
6430 Refactor handles and weak pointers to become nicer and more automatic
6431 https://bugs.webkit.org/show_bug.cgi?id=54415
6433 Update to use Global<> instead of ProtectedPtr, and refactored slightly
6434 to get global data to places it's needed for when we're assigning to
6437 * ForwardingHeaders/collector/handles/Global.h: Added.
6438 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
6439 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
6440 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
6441 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
6442 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
6443 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
6444 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
6445 (WebKit::NetscapePluginInstanceProxy::evaluate):
6446 (WebKit::NetscapePluginInstanceProxy::invoke):
6447 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
6448 (WebKit::NetscapePluginInstanceProxy::construct):
6449 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
6450 * WebView/WebScriptDebugger.h:
6451 * WebView/WebScriptDebugger.mm:
6452 (WebScriptDebugger::WebScriptDebugger):
6454 2011-02-15 Jia Pu <jpu@apple.com>
6456 Reviewed by Darin Adler.
6458 Autocorrection should respect undo.
6459 https://bugs.webkit.org/show_bug.cgi?id=52221
6460 <rdar://problem/8663399>
6462 Please see WebCore/ChangeLog for detailed description.
6464 * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
6466 * WebCoreSupport/WebEditorClient.mm:
6467 (WebEditorClient::recordAutocorrectionResponse): Ditto.
6469 * WebView/WebFrame.mm:
6470 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
6471 Adopted new signature of ReplaceSelectionCommand::create().
6473 2011-02-15 David Kilzer <ddkilzer@apple.com>
6475 <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
6477 Reviewed by Darin Adler.
6479 * WebView/WebDynamicScrollBarsView.h:
6480 * WebView/WebDynamicScrollBarsView.mm:
6481 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
6482 -inProgramaticScroll.
6483 * WebView/WebHTMLView.mm:
6484 (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
6486 2011-02-15 Kenneth Russell <kbr@google.com>
6488 Reviewed by Darin Fisher.
6490 Allow controlling minimum DOMTimer interval on a per-page basis
6491 https://bugs.webkit.org/show_bug.cgi?id=54312
6493 Added needed methods to implement LayoutTestController's new
6494 setMinimumTimerInterval method.
6496 * WebView/WebView.mm:
6497 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
6498 (+[WebView _defaultMinimumTimerInterval]):
6499 (-[WebView _setMinimumTimerInterval:]):
6500 * WebView/WebViewPrivate.h:
6502 2011-02-11 Geoffrey Garen <ggaren@apple.com>
6504 Reviewed by Oliver Hunt.
6506 A little more encapsulation for the heap: Removed CollectorHeapIterator
6507 https://bugs.webkit.org/show_bug.cgi?id=54298
6509 * Misc/WebCoreStatistics.mm:
6510 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
6511 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
6513 2011-02-10 Nate Chapin <japhet@chromium.org>
6515 Reviewed by Adam Barth.
6517 Update calls to DocumentWriter.
6518 https://bugs.webkit.org/show_bug.cgi?id=50489
6520 * WebView/WebFrame.mm:
6521 (-[WebFrame _canProvideDocumentSource]):
6523 2011-02-10 Chris Fleizach <cfleizach@apple.com>
6525 Reviewed by Anders Carlsson.
6527 AX: AX needs to stop using WebCoreViewFactory
6528 https://bugs.webkit.org/show_bug.cgi?id=54153
6530 * WebCoreSupport/WebSystemInterface.mm:
6531 (InitWebCoreSystemInterface):
6533 2011-02-10 Peter Varga <pvarga@webkit.org>
6535 Reviewed by Csaba Osztrogonác.
6537 Remove PCRE source from trunk
6538 https://bugs.webkit.org/show_bug.cgi?id=54188
6540 * ForwardingHeaders/pcre/pcre.h: Removed.
6542 2011-02-09 Pavel Feldman <pfeldman@chromium.org>
6544 Reviewed by Yury Semikhatsky.
6546 Web Inspector: follow up on InspectorAgent split -
6547 removing unnecessary methods from InspectorController.
6548 https://bugs.webkit.org/show_bug.cgi?id=54093
6550 * WebInspector/WebInspector.mm:
6551 (-[WebInspector showConsole:]):
6552 (-[WebInspector stopProfilingJavaScript:]):
6554 2011-02-08 Dan Bernstein <mitz@apple.com>
6556 Reviewed by Jon Honeycutt and Maciej Stachowiak.
6558 <rdar://problem/8959420> Find in Mail no longer cycles around
6560 * WebView/WebHTMLView.mm:
6561 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
6562 the wrap option according to the flag.
6564 2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
6566 Unreviewed, rolling out r77980.
6567 http://trac.webkit.org/changeset/77980
6568 https://bugs.webkit.org/show_bug.cgi?id=54043
6570 "Crashes on Windows and Linux..." (Requested by leviw on
6573 * WebView/WebFrame.mm:
6574 (-[WebFrame _caretRectAtNode:offset:affinity:]):
6575 * WebView/WebFrameInternal.h:
6576 * WebView/WebTextCompletionController.mm:
6577 (-[WebTextCompletionController doCompletion]):
6579 2011-02-08 Levi Weintraub <leviw@chromium.org>
6581 Reviewed by Ryosuke Niwa.
6583 Stop instantiating legacy editing Positions in VisiblePosition
6584 https://bugs.webkit.org/show_bug.cgi?id=52919
6586 Changing usage of legacy VisiblePosition constructor. Since we were dealing
6587 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
6589 * WebView/WebFrame.mm:
6590 (-[WebFrame _caretRectAtPosition:affinity:]):
6591 * WebView/WebFrameInternal.h:
6592 * WebView/WebTextCompletionController.mm:
6593 (-[WebTextCompletionController doCompletion]):
6595 2011-02-08 Adam Barth <abarth@webkit.org>
6597 Reviewed by Eric Seidel.
6599 Remove orphan code from old parser
6600 https://bugs.webkit.org/show_bug.cgi?id=53984
6602 * WebCoreSupport/WebChromeClient.h:
6604 2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
6606 Reviewed by Yury Semikhatsky.
6608 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
6610 https://bugs.webkit.org/show_bug.cgi?id=53169
6612 Minor change enforced by major changes in WebCore/inspector/InspectorController.
6614 * WebInspector/WebInspector.mm:
6615 (-[WebInspector isTimelineProfilingEnabled]):
6617 2011-02-07 Enrica Casucci <enrica@apple.com>
6619 Reviewed Adam Roben and Darin Adler.
6621 WebKit2: drag and drop support on Windows.
6622 https://bugs.webkit.org/show_bug.cgi?id=52775
6624 Removed createDragImageForLink from DragClient.
6626 * WebCoreSupport/WebDragClient.h:
6627 * WebCoreSupport/WebDragClient.mm:
6628 (WebDragClient::startDrag):
6630 2011-02-03 Yury Semikhatsky <yurys@chromium.org>
6632 Reviewed by Pavel Feldman.
6634 Web Inspector: remove settings related methods from InspectorClient
6635 https://bugs.webkit.org/show_bug.cgi?id=53686
6637 * WebCoreSupport/WebInspectorClient.h:
6638 * WebCoreSupport/WebInspectorClient.mm:
6639 (WebInspectorClient::openInspectorFrontend):
6640 (WebInspectorFrontendClient::WebInspectorFrontendClient):
6642 2011-02-03 James Kozianski <koz@chromium.org>
6644 Reviewed by Dimitri Glazkov.
6646 Add navigator.registerProtocolHandler behind a flag.
6647 https://bugs.webkit.org/show_bug.cgi?id=52609
6649 * Configurations/FeatureDefines.xcconfig:
6651 2011-02-03 Adam Langley <agl@chromium.org>
6653 Reviewed by Adam Barth.
6655 Plumb mixed script URL to FrameLoaderClient
6656 https://bugs.webkit.org/show_bug.cgi?id=52384
6658 Regressions covered by http/tests/security/mixedContent/*
6660 * WebCoreSupport/WebFrameLoaderClient.h:
6661 * WebCoreSupport/WebFrameLoaderClient.mm:
6662 (WebFrameLoaderClient::didRunInsecureContent):
6664 2011-02-03 Beth Dakin <bdakin@apple.com>
6666 Reviewed by Sam Weinig.
6668 Fix for <rdar://problem/8944544> Ability to animate track
6669 for WKPainter scrollers
6671 * WebCoreSupport/WebSystemInterface.mm:
6672 (InitWebCoreSystemInterface):
6674 2011-02-02 Mark Rowe <mrowe@apple.com>
6676 Reviewed by Beth Dakin.
6678 <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
6680 * WebCoreSupport/WebSystemInterface.mm:
6681 (InitWebCoreSystemInterface): Add some missing initializers.
6683 2011-02-02 Steve Lacey <sjl@chromium.org>
6685 Reviewed by Eric Carlson.
6687 Implement basic media statistics on media elements.
6688 https://bugs.webkit.org/show_bug.cgi?id=53322
6690 * Configurations/FeatureDefines.xcconfig:
6692 2011-02-01 Sam Weinig <sam@webkit.org>
6694 Reviewed by Beth Dakin.
6696 Part 2 for <rdar://problem/8492788>
6697 Adopt WKScrollbarPainterController
6699 Use header detection to define scrollbar painting controller #define.
6701 * WebCoreSupport/WebSystemInterface.mm:
6702 (InitWebCoreSystemInterface):
6704 2011-02-01 David Hyatt <hyatt@apple.com>
6706 Reviewed by Oliver Hunt.
6708 https://bugs.webkit.org/show_bug.cgi?id=53520
6710 Remove the physical terminology from IntRect and FloatRect.
6712 Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
6713 we need to update our terminology to be more accurate.
6715 I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
6716 renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
6717 even for flipped rectangles.
6719 * WebView/WebHTMLView.mm:
6720 (setNeedsDisplayInRect):
6722 2011-02-01 Beth Dakin <bdakin@apple.com>
6724 Reviewed by Sam Weinig.
6726 Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
6728 * WebCoreSupport/WebSystemInterface.mm:
6729 (InitWebCoreSystemInterface):
6731 2011-02-01 Dave Hyatt <hyatt@apple.com>
6733 Reviewed by Darin Adler.
6735 https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
6738 Change printing functions to check writing-mode and properly swap width and height
6741 * WebView/WebDynamicScrollBarsView.mm:
6742 (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
6743 * WebView/WebFrame.mm:
6744 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
6745 * WebView/WebFrameInternal.h:
6746 * WebView/WebHTMLView.mm:
6747 (-[WebHTMLView _web_setPrintingModeRecursive]):
6748 (-[WebHTMLView _web_clearPrintingModeRecursive]):
6749 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
6750 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
6751 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
6752 (-[WebHTMLView _endPrintMode]):
6753 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
6754 (-[WebHTMLView _endScreenPaginationMode]):
6755 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
6756 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
6757 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
6758 (-[WebHTMLView _scaleFactorForPrintOperation:]):
6759 (-[WebHTMLView setPageWidthForPrinting:]):
6760 (-[WebHTMLView knowsPageRange:]):
6762 2011-01-31 Oliver Hunt <oliver@apple.com>
6764 Convert markstack to a slot visitor API
6765 https://bugs.webkit.org/show_bug.cgi?id=53219
6767 rolling r77098, r77099, r77100, r77109, and
6768 r77111 back in, along with a few more Qt fix attempts.
6770 * WebView/WebScriptDebugDelegate.mm:
6771 (-[WebScriptCallFrame scopeChain]):
6773 2011-01-30 Csaba Osztrogonác <ossy@webkit.org>
6775 Unreviewed, rolling out r77098, r77099, r77100, r77109, and
6777 http://trac.webkit.org/changeset/77098
6778 http://trac.webkit.org/changeset/77099
6779 http://trac.webkit.org/changeset/77100
6780 http://trac.webkit.org/changeset/77109
6781 http://trac.webkit.org/changeset/77111
6782 https://bugs.webkit.org/show_bug.cgi?id=53219
6786 * WebView/WebScriptDebugDelegate.mm:
6787 (-[WebScriptCallFrame scopeChain]):
6789 2011-01-30 Oliver Hunt <oliver@apple.com>
6791 Convert markstack to a slot visitor API
6792 https://bugs.webkit.org/show_bug.cgi?id=53219
6794 rolling r77006 and r77020 back in.
6796 * WebView/WebScriptDebugDelegate.mm:
6797 (-[WebScriptCallFrame scopeChain]):
6799 2011-01-28 Geoffrey Garen <ggaren@apple.com>
6801 Reviewed by Maciej Stachowiak.
6803 Some more Heap cleanup.
6804 https://bugs.webkit.org/show_bug.cgi?id=53357
6806 Updated for JavaScriptCore changes.
6808 * Misc/WebCoreStatistics.mm:
6809 (+[WebCoreStatistics memoryStatistics]):
6811 2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
6813 Unreviewed, rolling out r77006 and r77020.
6814 http://trac.webkit.org/changeset/77006
6815 http://trac.webkit.org/changeset/77020
6816 https://bugs.webkit.org/show_bug.cgi?id=53360
6818 "Broke Windows tests" (Requested by rniwa on #webkit).
6820 * WebView/WebScriptDebugDelegate.mm:
6821 (-[WebScriptCallFrame scopeChain]):
6823 2011-01-27 Oliver Hunt <oliver@apple.com>
6825 Reviewed by Geoffrey Garen.
6827 Convert markstack to a slot visitor API
6828 https://bugs.webkit.org/show_bug.cgi?id=53219
6830 Update to new marking api
6832 * WebView/WebScriptDebugDelegate.mm:
6833 (-[WebScriptCallFrame scopeChain]):
6835 2011-01-28 Dan Bernstein <mitz@apple.com>
6837 Reviewed by Sam Weinig.
6839 <select> can't display right-to-left (rtl) languages
6840 https://bugs.webkit.org/show_bug.cgi?id=19785
6842 * WebCoreSupport/WebChromeClient.h:
6843 * WebCoreSupport/WebChromeClient.mm:
6844 (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
6845 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
6847 2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
6849 Unreviewed, rolling out r76891.
6850 http://trac.webkit.org/changeset/76891
6851 https://bugs.webkit.org/show_bug.cgi?id=53280
6853 Makes every layout test crash (Requested by othermaciej on
6856 * Misc/WebIconDatabase.mm:
6857 (-[ThreadEnabler threadEnablingSelector:]):
6858 (importToWebCoreFormat):
6860 2011-01-27 Nate Chapin <japhet@chromium.org>
6862 Reviewed by Adam Barth.
6864 Use Document::url() instead of FrameLoader::url().
6865 https://bugs.webkit.org/show_bug.cgi?id=41165
6867 * WebView/WebView.mm:
6868 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
6870 2011-01-27 Dan Bernstein <mitz@apple.com>
6872 Rubber-stamped by Anders Carlsson.
6874 Reverted an accidental change in r76561.
6876 * WebView/WebHTMLView.mm:
6878 2011-01-26 David Kilzer <ddkilzer@apple.com>
6880 <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
6881 <rdar://problem/8821760>
6883 Reviewed by Antti Koivisto.
6885 * WebCoreSupport/WebSystemInterface.mm:
6886 (InitWebCoreSystemInterface): Added initialization for
6887 GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
6889 2011-01-26 Beth Dakin <bdakin@apple.com>
6891 Reviewed by Darin Adler.
6893 Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
6894 when using WKScrollbars.
6896 * WebCoreSupport/WebSystemInterface.mm:
6897 (InitWebCoreSystemInterface):
6899 2011-01-25 Darin Adler <darin@apple.com>
6901 Reviewed by Anders Carlsson.
6903 WebKit is using CSBackupSetItemExcluded incorrectly
6904 https://bugs.webkit.org/show_bug.cgi?id=53095
6905 rdar://problem/8790540
6907 * Misc/WebIconDatabase.mm:
6908 (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
6909 It was incorrect, and this responsibility has been moved to WebCore.
6911 2011-01-24 Chris Marrin <cmarrin@apple.com>
6913 Reviewed by Eric Seidel.
6915 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
6916 https://bugs.webkit.org/show_bug.cgi?id=53041
6918 * Configurations/FeatureDefines.xcconfig:
6920 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
6922 Reviewed by Pavel Feldman.
6924 Web Inspector: remove "attached" state related methods from InspectorAgent
6925 https://bugs.webkit.org/show_bug.cgi?id=53086
6927 * WebCoreSupport/WebInspectorClient.h:
6928 * WebCoreSupport/WebInspectorClient.mm:
6929 (-[WebInspectorWindowController showWindow:]):
6930 (-[WebInspectorWindowController attach]):
6931 (-[WebInspectorWindowController detach]):
6933 2011-01-23 Dan Bernstein <mitz@apple.com>
6935 Reviewed by John Sullivan.
6937 <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
6939 * WebCoreSupport/WebChromeClient.mm:
6940 (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
6942 2011-01-22 Alexey Proskuryakov <ap@apple.com>
6944 Reviewed by Darin Adler.
6946 https://bugs.webkit.org/show_bug.cgi?id=52473
6947 Auto-scaling to avoid orphans is broken, remove dysfunctional code
6949 * WebView/WebHTMLView.mm:
6950 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
6951 (-[WebHTMLView _scaleFactorForPrintOperation:]):
6952 (-[WebHTMLView knowsPageRange:]):
6954 2011-01-21 Mark Rowe <mrowe@apple.com>
6956 Rubber-stamped by Jon Honeycutt.
6958 Fix the build when using Clang by removing some unused variables.
6960 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
6961 (-[WebHostedNetscapePluginView updateAndSetWindow]):
6962 * WebView/WebFullScreenController.mm:
6963 (-[WebFullScreenController enterFullscreen:]):
6964 (-[WebFullScreenController exitFullscreen]):
6966 2011-01-21 Chris Rogers <crogers@google.com>
6968 Reviewed by Darin Fisher.
6970 Add run-time enable support for the web audio API
6971 https://bugs.webkit.org/show_bug.cgi?id=52741
6973 * WebView/WebPreferenceKeysPrivate.h:
6974 * WebView/WebPreferences.mm:
6975 (-[WebPreferences webAudioEnabled]):
6976 (-[WebPreferences setWebAudioEnabled:]):
6977 * WebView/WebPreferencesPrivate.h:
6978 * WebView/WebView.mm:
6979 (-[WebView _preferencesChangedNotification:]):
6981 2011-01-20 John Sullivan <sullivan@apple.com>
6983 Reviewed by Mark Rowe.
6985 Shift-tab doesn't cycle through fields in http authentication panel
6986 https://bugs.webkit.org/show_bug.cgi?id=52850
6988 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
6989 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
6990 Re-wired the key loop so that there aren't two views with the same nextKeyView.
6992 2011-01-20 Beth Dakin <bdakin@apple.com>
6994 Reviewed by Geoffrey Garen.
6996 Fix for <rdar://problem/8890255>
6998 Allow WebKitSystemInterface to draw scrollbars
7000 * WebCoreSupport/WebSystemInterface.mm:
7001 (InitWebCoreSystemInterface):
7003 2011-01-19 Simon Fraser <simon.fraser@apple.com>
7005 Reviewed by Sam Weinig.
7007 GraphicsLayers in subframes can get sync'd multiple times
7008 https://bugs.webkit.org/show_bug.cgi?id=52489
7010 * WebView/WebView.mm:
7011 (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
7012 was renamed to syncCompositingStateIncludingSubframes().
7014 2011-01-19 Darin Adler <darin@apple.com>
7016 Reviewed by Sam Weinig.
7018 Would like script debugging protocol method to differentiate between caught and uncaught exceptions
7019 https://bugs.webkit.org/show_bug.cgi?id=52104
7020 rdar://problem/8704226
7022 * WebView/WebDelegateImplementationCaching.h:
7023 Fix type of second integer in CallScriptDebugDelegate function overload
7024 to be int to match the actual Objective-C method. Added a new overload
7025 that includes a BOOL in the right place. Added a boolean named
7026 exceptionWasRaisedExpectsHasHandlerFlag.
7028 * WebView/WebDelegateImplementationCaching.mm:
7029 (CallDelegate): Added overloads as above.
7030 (CallScriptDebugDelegate): Ditto.
7032 * WebView/WebScriptDebugDelegate.h: Added new method with the additional
7033 boolean argument. Marked the old method informally deprecated.
7035 * WebView/WebScriptDebugger.mm:
7036 (WebScriptDebugger::exception): Added code to call with or without the
7037 boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
7039 * WebView/WebView.mm:
7040 (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
7041 exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
7042 guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
7044 2011-01-19 Tony Gentilcore <tonyg@chromium.org>
7046 Reviewed by Mihai Parparita.
7048 Perform some forward declaration
7049 https://bugs.webkit.org/show_bug.cgi?id=52522
7051 * Misc/WebKitNSStringExtras.mm:
7053 2011-01-19 Pavel Podivilov <podivilov@chromium.org>
7055 Reviewed by Yury Semikhatsky.
7057 Web Inspector: [JSC] scripts have incorrect starting line (always 1).
7058 https://bugs.webkit.org/show_bug.cgi?id=52721
7060 * WebView/WebScriptDebugger.h:
7061 * WebView/WebScriptDebugger.mm:
7063 (WebScriptDebugger::sourceParsed):
7065 2011-01-19 Levi Weintraub <leviw@google.com>
7067 Reviewed by Ryosuke Niwa.
7069 Updating to use Position::parentAnchoredEquivalent instead of
7070 the old htmlediting rangeCompliantEquivalent.
7072 remove rangeCompliantEquivalent and replace it with Position methods
7073 https://bugs.webkit.org/show_bug.cgi?id=25057
7075 * WebView/WebFrame.mm:
7076 (-[WebFrame _smartDeleteRangeForProposedRange:]):
7078 2011-01-18 Chris Fleizach <cfleizach@apple.com>
7080 Reviewed by Darin Adler.
7082 REGRESSION: A problem with Voiceover and finding links
7083 https://bugs.webkit.org/show_bug.cgi?id=52324
7085 * WebView/WebDynamicScrollBarsView.mm:
7086 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
7088 2011-01-17 David Kilzer <ddkilzer@apple.com>
7090 <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
7092 Reviewed by Dan Bernstein.
7094 * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
7095 DOMDocumentPrivate.h to the PrivateHeaders directory.
7097 2011-01-17 Enrica Casucci <enrica@apple.com>
7099 Reviewed by Alexey Proskuryakov.
7101 Drag and drop support: refactoring of image from link and image from selection
7102 https://bugs.webkit.org/show_bug.cgi?id=52496
7104 This work cleans up the Mac code and makes it more similar to the Windows implementation,
7105 avoiding the use of an NSView when the FrameView can be used.
7106 The refactoring is a necessary step towards the complete support of drag and drop
7109 * WebCoreSupport/WebDragClient.mm:
7110 (WebDragClient::createDragImageForLink): Added.
7111 * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
7112 * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
7114 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
7116 Reviewed by Yury Semikhatsky.
7118 Web Inspector: simplify debugger enabling routine.
7119 https://bugs.webkit.org/show_bug.cgi?id=52472
7121 * WebInspector/WebInspector.mm:
7122 (-[WebInspector startDebuggingJavaScript:]):
7124 2011-01-16 Dan Bernstein <mitz@apple.com>
7126 Reviewed by Simon Fraser.
7128 Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
7129 https://bugs.webkit.org/show_bug.cgi?id=52550
7131 * Plugins/WebNetscapePluginView.mm:
7132 (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
7133 that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
7135 2011-01-16 Simon Fraser <simon.fraser@apple.com>
7137 Reviewed by Dan Bernstein.
7139 Issues with iframes and plugins when the WebView is scaled.
7140 <rdar://problem/6213380>
7142 When _scaleWebView has been called on a WebView, iframes
7143 in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
7144 This is caused by AppKit NSViews not playing nicely with the scale
7145 applied through style.
7147 Work around most of these issues by adjusting the bounds size
7148 of widgets to allow iframe contents to paint with the correct scale,
7149 and fix various places in the code where we relied on coordinate
7150 transforms via NSViews (which ignore CSS transforms).
7152 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
7153 (-[WebHostedNetscapePluginView updateAndSetWindow]):
7154 * WebView/WebFrameView.mm:
7155 (-[WebFrameView setBoundsSize:]):
7157 2011-01-16 Beth Dakin <bdakin@apple.com>
7159 Reviewed by Kevin Decker.
7161 Fix for <rdar://problem/8871204>
7163 Don't try to save elasticity state. Just rely on
7164 NSScrollElasticityAutomatic to restore the correct state.
7165 * WebCoreSupport/WebFrameLoaderClient.h:
7166 * WebCoreSupport/WebFrameLoaderClient.mm:
7167 (WebFrameLoaderClient::WebFrameLoaderClient):
7168 (WebFrameLoaderClient::dispatchDidFirstLayout):
7169 (WebFrameLoaderClient::provisionalLoadStarted):
7171 2011-01-14 Simon Fraser <simon.fraser@apple.com>
7173 Reviewed by Dan Bernstein.
7175 Plugins render incorrectly with transformed ancestors
7176 https://bugs.webkit.org/show_bug.cgi?id=52507
7178 -[NSView visibleRect] gives the wrong answer if there are CSS transforms
7179 in the ancestor chain of a plugin.
7181 So use of this method with calls to -actualVisibleRectInWindow, which
7182 maps rects through the render tree to compute the correct rect,
7183 clipping via windowClipRect() if necessary.
7185 Not testable, because doing so relies on the behavior of some
7186 plugins, which stop rendering if setWindow passes an empty rect.
7188 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
7189 (-[WebHostedNetscapePluginView updateAndSetWindow]):
7190 * Plugins/WebBaseNetscapePluginView.h:
7191 * Plugins/WebBaseNetscapePluginView.mm:
7192 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
7193 * Plugins/WebNetscapePluginView.mm:
7194 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
7196 2011-01-14 Yuzo Fujishima <yuzo@google.com>
7198 Reviewed by Antti Koivisto.
7200 Rename cache() to memoryCache()
7201 https://bugs.webkit.org/show_bug.cgi?id=52433
7204 (+[WebCache statistics]):
7205 (+[WebCache setDisabled:]):
7206 (+[WebCache isDisabled]):
7207 * WebView/WebView.mm:
7208 (+[WebView _setCacheModel:]):
7210 2011-01-13 Geoffrey Garen <ggaren@apple.com>
7212 Reviewed by Oliver Hunt.
7214 Split out a MarkedSpace strategy object from Heap.
7215 https://bugs.webkit.org/show_bug.cgi?id=52421
7217 * Misc/WebCoreStatistics.mm:
7218 (+[WebCoreStatistics memoryStatistics]): Updated for class move.
7220 2011-01-14 Dan Bernstein <mitz@apple.com>
7222 Reviewed by Simon Fraser.
7224 WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
7226 * WebView/WebHTMLView.mm:
7227 (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
7228 to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
7229 that the NSView tree doesn’t change from under AppKit as it traverses it.
7231 2011-01-14 Beth Dakin <bdakin@apple.com>
7233 Reviewed by Mark Rowe.
7235 Fix for <rdar://problem/7793902> Artifacts when scrolling
7236 page in Safari while page is loading
7238 Call setDrawsBackground:YES on the scrollView in
7239 dispatchDidFirstLayout() rather than waiting until
7240 frameLoadCompleted(). Also suspend scrolling elasticity
7241 between provisionalLoadStarted() and dispatchDidFirstLayout()
7242 * WebCoreSupport/WebFrameLoaderClient.h:
7243 * WebCoreSupport/WebFrameLoaderClient.mm:
7244 (WebFrameLoaderClient::WebFrameLoaderClient):
7245 (WebFrameLoaderClient::dispatchDidFirstLayout):
7246 (WebFrameLoaderClient::provisionalLoadStarted):
7248 2011-01-12 Enrica Casucci <enrica@apple.com>
7250 Reviewed by Darin Adler.
7252 WebKit2: Add support for drag and drop
7253 https://bugs.webkit.org/show_bug.cgi?id=52343
7254 <rdar://problem/7660558>
7256 The DragData class has been extended to provide
7257 additional context from the application (keyboard state, modal windows, etc.)
7258 as well as information of the drag pasteboard being used.
7259 These are the changes to align the behavior for WebKit.
7261 * WebView/WebView.mm:
7262 (-[WebView applicationFlags:]): Added.
7263 (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
7264 (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
7265 (-[WebView draggingExited:]): Added parameter to the DragData constructor.
7266 (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
7268 2011-01-12 Beth Dakin <bdakin@apple.com>
7270 Reviewed by Anders Carlsson.
7272 Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
7273 Expose fixed layout through WebKit SPI
7275 <rdar://problem/8844464>
7277 And now with getters!
7278 * WebView/WebView.mm:
7279 (-[WebView _useFixedLayout]):
7280 (-[WebView _fixedLayoutSize]):
7281 * WebView/WebViewPrivate.h:
7283 2011-01-12 Beth Dakin <bdakin@apple.com>
7285 Reviewed by Anders Carlsson.
7287 Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
7288 fixed layout through WebKit SPI
7290 <rdar://problem/8844464>
7292 * WebView/WebView.mm:
7293 (-[WebView _setUseFixedLayout:]):
7294 (-[WebView _setFixedLayoutSize:]):
7295 * WebView/WebViewPrivate.h:
7297 2011-01-07 Enrica Casucci <enrica@apple.com>
7299 Reviewed by Alexey Proskuryakov.
7301 Paste and drag and drop use different code paths to interact with the pasteboard.
7302 https://bugs.webkit.org/show_bug.cgi?id=52093
7303 The change consists in a refactoring of the code to have only one class that
7304 deals with the pasteboard on Mac.
7306 * WebCoreSupport/WebEditorClient.h:
7307 * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
7308 exposed by NSURLExtras.
7309 (WebEditorClient::canonicalizeURL):
7310 (WebEditorClient::canonicalizeURLString):
7311 * WebCoreSupport/WebPasteboardHelper.h: Removed.
7312 * WebCoreSupport/WebPasteboardHelper.mm: Removed.
7313 * WebView/WebHTMLView.mm: Removed comment.
7314 * WebView/WebView.mm: The following methods have been changed to use the new DragData
7315 constructor that doesn't use the WebPasteboardHelper reference.
7316 (-[WebView draggingEntered:]):
7317 (-[WebView draggingUpdated:]):
7318 (-[WebView draggingExited:]):
7319 (-[WebView performDragOperation:]):
7321 2011-01-09 Tony Gentilcore <tonyg@chromium.org>
7323 Reviewed by Alexey Proskuryakov.
7325 Forward declare some headers where possible
7326 https://bugs.webkit.org/show_bug.cgi?id=52133
7328 * WebView/WebFrame.mm:
7330 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
7332 Reviewed by Darin Fisher.
7334 https://bugs.webkit.org/show_bug.cgi?id=41441
7335 createWindow method should only do window-creating without URL navigation
7337 * WebCoreSupport/WebChromeClient.mm:
7338 (WebChromeClient::createWindow):
7340 2011-01-08 Dan Bernstein <mitz@apple.com>
7342 Try to fix the Leopard build.
7344 * WebView/WebFullScreenController.mm:
7346 2011-01-07 Jer Noble <jer.noble@apple.com>
7348 Yet another Leopard build fix: NSRect and CGRect are not inter-
7349 changable in 32-bit.
7351 * WebView/WebFullScreenController.mm:
7352 (-[WebFullScreenController exitFullscreen]):
7354 2011-01-07 Jer Noble <jer.noble@apple.com>
7356 Fix the Leopard build: Replace CoreAnimation SL-only functions
7357 with Leopard equivalents.
7359 * WebView/WebFullScreenController.mm:
7360 (+[CATransaction setDisableActions:]):
7361 (+[CATransaction setAnimationDuration:]):
7362 (-[WebFullScreenController _animationDuration]):
7363 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
7365 2010-12-21 Jer Noble <jer.noble@apple.com>
7367 Reviewed by Simon Fraser.
7369 Implement WebKit Full Screen support.
7370 https://bugs.webkit.org/show_bug.cgi?id=49481
7371 rdar://problem/8247444
7373 Support the new fullscreen Chrome client requests. WebView will pass
7374 through these requests to a WebFullscreenController.
7376 * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
7377 * WebView/WebView.mm:
7378 (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
7379 (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
7380 (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
7381 (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
7382 * WebView/WebViewData.h: Add ivar newFullscreenController.
7384 2010-12-17 Jer Noble <jer@kokode.apple.com>
7386 Reviewed by Simon Fraser.
7388 Implement WebKit Full Screen support.
7389 https://bugs.webkit.org/show_bug.cgi?id=49481
7390 rdar://problem/8247444
7392 This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
7393 Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
7394 window, and a custom CAAnimation animates that layer between the initial screen rect of the
7395 full screen element, to its final value. WebFullscreenController will swap the WebView out of
7396 its original window, and into the fullscreen window. The controller will replace the WebView
7397 with a placeholder view, so that if the placeholder moves or resized while the WebView is
7398 absent, the WebView will move back to the correct location when exiting fullscreen.
7400 * WebView/WebFullscreenController.h: Added.
7401 * WebView/WebFullscreenController.mm: Added.
7402 (-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
7403 (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
7404 (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
7405 (-[WebFullscreenController applicationDidResignActive:]):
7406 (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
7407 the new screen parameters.
7408 (-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element
7409 from its original screen rect into fullscreen.
7410 (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
7411 Set up the animation that will take the fullscreen element back into its original screen
7413 (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
7414 whether to disable screensaver and sleep.
7415 (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
7416 looking for HTMLVideoElements; returns whether any are found to be playing.
7417 (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
7419 (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
7420 (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
7421 (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
7422 (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
7423 (-[WebFullscreenWindow setRendererLayer:]): Ditto.
7424 (-[WebFullscreenWindow backgroundLayer]): Ditto.
7425 (-[WebFullscreenWindow animationView]): Ditto.
7426 (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
7427 (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
7429 2011-01-07 James Robinson <jamesr@chromium.org>
7431 Revert "Implement mozilla's animationTime property"
7432 https://bugs.webkit.org/show_bug.cgi?id=51952
7434 This approach isn't quite right.
7436 * WebView/WebHTMLView.mm:
7437 (-[WebHTMLView drawRect:]):
7438 * WebView/WebView.mm:
7439 (layerSyncRunLoopObserverCallBack):
7441 2011-01-06 Gavin Barraclough <barraclough@apple.com>
7443 Reviewed by Geoff Garen.
7445 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
7447 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
7448 destructor early, in order to release wrappers once we know we no longer intend to use them.
7449 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
7450 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
7451 A sequence of events that triggers the bug would look like this:
7453 (1) Create a DOMWrapperWorld.
7454 (2) Register a timer in the world.
7455 (3) Call unregisterWorld() on the world.
7456 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
7457 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
7458 called forgetWorld() none exists.
7459 (6) Attempt to add a wrapper to a NULL map.
7461 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
7463 * WebView/WebScriptWorld.mm:
7464 (-[WebScriptWorld unregisterWorld]):
7466 2011-01-04 Chris Fleizach <cfleizach@apple.com>
7468 Reviewed by Sam Weinig.
7470 WK2: Support Accessibility
7471 https://bugs.webkit.org/show_bug.cgi?id=51859
7473 Use rootObject() method to get top of AX tree.
7475 * WebCoreSupport/WebFrameLoaderClient.h:
7476 (WebFrameLoaderClient::accessibilityRemoteObject):
7477 * WebView/WebFrame.mm:
7478 (-[WebFrame setAccessibleName:]):
7479 (-[WebFrame accessibilityRoot]):
7480 * WebView/WebFrameInternal.h:
7481 * WebView/WebFramePrivate.h:
7482 * WebView/WebHTMLView.mm:
7483 (-[WebHTMLView accessibilityAttributeValue:]):
7484 (-[WebHTMLView accessibilityFocusedUIElement]):
7485 (-[WebHTMLView accessibilityHitTest:]):
7486 (-[WebHTMLView _accessibilityParentForSubview:]):
7488 2011-01-04 David Kilzer <ddkilzer@apple.com>
7490 <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
7492 Reviewed by Eric Carlson.
7494 This originally broke in r61581. It is inside an
7495 ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
7498 * WebCoreSupport/WebFrameLoaderClient.mm: Call
7499 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
7500 use WebCore::PluginInfo.name instead of
7501 -[WebBasePluginPackage name].
7503 2011-01-02 Dan Bernstein <mitz@apple.com>
7505 Rubber-stamped by Simon Fraser.
7507 <rdar://problem/8812159> Update copyright strings
7511 2010-12-29 Dan Bernstein <mitz@apple.com>
7513 Reviewed by Ada Chan.
7515 <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
7516 https://bugs.webkit.org/show_bug.cgi?id=51717
7518 Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
7519 protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
7521 * WebView/WebDocumentInternal.h:
7522 * WebView/WebHTMLView.mm:
7523 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
7524 (-[WebHTMLView _findString:options:]):
7525 * WebView/WebView.mm:
7528 2010-12-28 Daniel Bates <dbates@rim.com>
7530 Reviewed by Sam Weinig.
7532 Substitute // MARK: for compiler-specific #pragma mark
7533 https://bugs.webkit.org/show_bug.cgi?id=51657
7535 For consistency, we should substitute "// MARK:" for compiler-
7536 specific "#pragma mark" in the source files for the Mac port.
7538 * History/WebHistory.mm:
7539 * Plugins/WebBaseNetscapePluginView.mm:
7540 * Plugins/WebNetscapePluginView.mm:
7541 * WebCoreSupport/WebInspectorClient.mm:
7542 * WebCoreSupport/WebSecurityOrigin.mm:
7543 * WebView/WebPDFView.mm:
7544 * WebView/WebVideoFullscreenController.mm:
7545 * WebView/WebVideoFullscreenHUDWindowController.mm:
7547 2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
7549 Reviewed by Darin Adler.
7551 WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
7552 https://bugs.webkit.org/show_bug.cgi?id=38535
7554 WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result,
7555 if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
7556 WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top
7557 call frame from this stack when an exception throws because the saved top frame could be invalid.
7559 To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
7560 callEvent and returnEvent.
7562 * WebView/WebScriptDebugger.mm:
7563 (WebScriptDebugger::willExecuteProgram):
7564 (WebScriptDebugger::didExecuteProgram):
7566 2010-12-22 Sam Weinig <sam@webkit.org>
7568 Reviewed by Darin Adler.
7570 WebKit2 needs to mirror the frame tree in the UIProcess
7571 https://bugs.webkit.org/show_bug.cgi?id=51546
7573 - Add client functions to notify that a frame has been added or
7574 removed from the page cache.
7576 * WebCoreSupport/WebFrameLoaderClient.h:
7577 * WebCoreSupport/WebFrameLoaderClient.mm:
7578 (WebFrameLoaderClient::didSaveToPageCache):
7579 (WebFrameLoaderClient::didRestoreFromPageCache):
7581 2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
7583 Reviewed by Eric Seidel.
7585 Editor.h doesn't need to include SelectionController.h
7586 https://bugs.webkit.org/show_bug.cgi?id=51441
7588 Renamed SelectionController::EDirection to SelectionDirection.
7590 * WebView/WebFrame.mm:
7591 (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
7592 Takes SelectionDirection instead of SelectionController::EDirection.
7593 * WebView/WebFrameInternal.h:
7594 * WebView/WebTextCompletionController.mm:
7595 (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
7597 2010-12-22 Simon Fraser <simon.fraser@apple.com>
7599 Reviewed by Darin Adler.
7601 Cache snapshots of plug-ins before painting, to avoid script running during painting
7602 https://bugs.webkit.org/show_bug.cgi?id=51493
7604 When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
7605 or when printing), plug-ins which otherwise use the CA rendering model
7606 are sent a paint event. Some plug-ins may run script while handling this event,
7607 or out of process plug-ins may process queued requests at this time. Running
7608 script while inside layout or painting can have bad consequences, because it
7609 can result in arbitrary changes to the render tree.
7611 This patch avoids sending plug-ins paint events inside of painting. Instead,
7612 we ask the plug-ins to cache a snapshot before we paint, and then the software
7613 paint simply draws that snapshot.
7615 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
7616 (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
7617 draw it. Also only send the snapshot message to the plugin proxy if we
7618 know we're snapshotting, since even if creating the snapshot image failed,
7619 we still don't want to call to the plug-in.
7621 * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
7622 * Plugins/WebBaseNetscapePluginView.mm:
7623 (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
7624 (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
7626 * Plugins/WebNetscapePluginView.mm:
7627 (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
7628 * WebCoreSupport/WebFrameLoaderClient.mm:
7629 (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
7630 to cache and clear the snapshots.
7632 2010-12-21 Cameron Zwarich <zwarich@apple.com>
7634 Reviewed by Darin Adler.
7636 -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
7637 https://bugs.webkit.org/show_bug.cgi?id=51431
7638 <rdar://problem/8791757>
7640 * Plugins/WebBasePluginPackage.mm:
7641 (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
7642 it doesn't underflow.
7644 2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
7646 Reviewed by Cameron Zwarich.
7648 REGRESSION(r74172): 125 java tests fail on Mac
7649 https://bugs.webkit.org/show_bug.cgi?id=51214
7651 The regression was caused by an incorrectly adding sizeof(struct fat_header)
7652 to a pointer for uint32_t as supposed to uint8_t.
7654 Fixed the bug by explicitly casting it to uint8_t* before the addition.
7656 * Plugins/WebBasePluginPackage.mm:
7657 (-[WebBasePluginPackage isNativeLibraryData:]):
7659 2010-12-15 Cameron Zwarich <zwarich@apple.com>
7661 Reviewed by Darin Adler.
7663 Clang -Wcast-align gives an error in WebBasePluginPackage.mm
7664 https://bugs.webkit.org/show_bug.cgi?id=51144
7666 Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
7667 we were calling it on a byte array 32 bits at a time. While this is okay in practice,
7668 since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
7669 inline storage is at the beginning of the Vector, it is still better to fix this
7670 and silence the warning.
7672 * Plugins/WebBasePluginPackage.mm:
7674 (-[WebBasePluginPackage isNativeLibraryData:]):
7676 2010-12-14 Mark Rowe <mrowe@apple.com>
7678 Reviewed by Sam Weinig.
7680 <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
7682 * History/WebHistoryItem.mm:
7683 (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
7684 always including the target in the output.
7686 2010-12-13 Alexey Proskuryakov <ap@apple.com>
7688 Reviewed by Adam Barth.
7690 https://bugs.webkit.org/show_bug.cgi?id=50953
7691 DNS Prefetch should be an opt-in feature
7693 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
7695 2010-12-13 Mike Thole <mthole@apple.com>
7697 Rubber-stamped by John Sullivan.
7699 https://bugs.webkit.org/show_bug.cgi?id=50956
7700 WebAuthenticationPanel.nib appears to have a cut-off sentence
7702 Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
7703 The contents of this text field are updated dynamically before the sheet is displayed.
7705 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
7706 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
7708 2010-12-13 Antti Koivisto <antti@apple.com>
7710 Reviewed by Alexey Proskuryakov.
7712 https://bugs.webkit.org/show_bug.cgi?id=50758
7713 <rdar://problem/8722094>
7714 Defer loading print stylesheets
7716 Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
7718 * WebView/WebView.mm:
7719 (+[WebView _setLoadResourcesSerially:forHost:]):
7720 * WebView/WebViewPrivate.h:
7722 2010-12-09 Matthew Delaney <mdelaney@apple.com>
7724 Reviewed by Simon Fraser.
7726 Adopt new CG API for canvas
7727 https://bugs.webkit.org/show_bug.cgi?id=50591
7729 * WebCoreSupport/WebSystemInterface.mm:
7731 2010-10-28 MORITA Hajime <morrita@google.com>
7733 Reviewed by Ojan Vafai.
7735 spellcheck does not check pasted text
7736 https://bugs.webkit.org/show_bug.cgi?id=40092
7738 Added asynchronous spell checking API to WebEditorClient using
7739 -[NSSpellChecker requestCheckingOfString].
7740 Note that WebEditorSpellCheckResponder is a small class to receive
7741 requested spell-checking result. Note that this feature is
7742 disabled at default.
7744 Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
7745 enable the feature from LayoutTestController.
7747 * WebCoreSupport/WebEditorClient.h:
7748 * WebCoreSupport/WebEditorClient.mm:
7749 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
7750 (-[WebEditorSpellCheckResponder perform]):
7751 (toCoreSpellingResult):
7752 (-[WebEditorSpellCheckResponder WTF::WebCore::]):
7753 (WebEditorClient::requestCheckingOfString):
7754 * WebView/WebPreferenceKeysPrivate.h:
7755 * WebView/WebPreferences.mm:
7756 (+[WebPreferences initialize]):
7757 (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
7758 (-[WebPreferences asynchronousSpellCheckingEnabled]):
7759 * WebView/WebPreferencesPrivate.h:
7760 * WebView/WebView.mm:
7761 (-[WebView _preferencesChangedNotification:]):
7763 2010-12-09 Anders Carlsson <andersca@apple.com>
7765 Fix a bug uncovered by clang++.
7767 * WebView/WebHTMLView.mm:
7768 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
7770 2010-12-09 Anders Carlsson <andersca@apple.com>
7772 Clang++ build fixes.
7774 Silence a couple of warnings.
7776 * WebView/WebFrame.mm:
7777 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
7778 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
7779 * WebView/WebTextCompletionController.mm:
7780 (-[WebTextCompletionController filterKeyDown:]):
7782 2010-12-09 David Hyatt <hyatt@apple.com>
7784 Reviewed by Dan Bernstein.
7786 https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
7787 writing-mode. This first part of the patch just patches Mac WebKit 1 views.
7789 * WebView/WebFrameView.mm:
7790 (-[WebFrameView _isVerticalDocument]):
7791 (-[WebFrameView _isFlippedDocument]):
7792 (-[WebFrameView _scrollToEndOfDocument]):
7793 (-[WebFrameView _pageInBlockProgressionDirection:]):
7794 (-[WebFrameView scrollPageUp:]):
7795 (-[WebFrameView scrollPageDown:]):
7797 2010-12-08 Andy Estes <aestes@apple.com>
7799 Reviewed by Darin Adler.
7801 Enable pre-HTML5 parser quirks for Apple Mail.app
7802 https://bugs.webkit.org/show_bug.cgi?id=50727
7804 * WebView/WebView.mm:
7805 (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
7806 application is Mail.app.
7808 2010-12-08 Brian Weinstein <bweinstein@apple.com>
7810 Reviewed by John Sullivan.
7812 REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
7813 https://bugs.webkit.org/show_bug.cgi?id=50683
7815 If our context menu item already has an action, don't overwrite the action with the context menu
7818 * WebView/WebHTMLView.mm:
7819 (setMenuItemTarget):
7821 2010-12-08 Anders Carlsson <andersca@apple.com>
7823 Remove an unused variable.
7825 * WebView/WebDynamicScrollBarsView.mm:
7826 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
7828 2010-12-07 Brian Weinstein <bweinstein@apple.com>
7830 Reviewed by John Sullivan.
7832 Layering Violation in ContextMenu - member variable of type HitTestResult
7833 https://bugs.webkit.org/show_bug.cgi?id=50586
7835 Update users of ContextMenu and ContextMenuController to match where the new functions
7838 * WebCoreSupport/WebContextMenuClient.mm:
7839 (WebContextMenuClient::getCustomMenuFromDefaultItems):
7840 (WebContextMenuClient::contextMenuItemSelected):
7841 * WebView/WebHTMLView.mm:
7842 (-[WebMenuTarget validateMenuItem:]):
7844 2010-12-07 Brian Weinstein <bweinstein@apple.com>
7846 Reviewed by John Sullivan.
7848 Part of Layering Violation in ContextMenu
7849 https://bugs.webkit.org/show_bug.cgi?id=50586
7851 Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
7852 was a layering violation. Also, make sure we set the menu item targets for all menu
7853 items before showing them, because the ContextMenu constructor doesn't do that anymore.
7855 * WebView/WebHTMLView.mm:
7856 (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
7857 (-[WebMenuTarget WebCore::]): Ditto.
7858 (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
7859 (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
7860 (-[WebMenuTarget validateMenuItem:]): Ditto.
7862 (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
7863 (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
7864 submenus), and calls setMenuItemTarget on them.
7865 (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
7868 2010-12-06 Darin Adler <darin@apple.com>
7870 Reviewed by Sam Weinig.
7872 Pass security origin to make local file decision correctly
7873 https://bugs.webkit.org/show_bug.cgi?id=48603
7875 * WebView/WebPDFView.mm:
7876 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
7878 2010-12-07 Martin Robinson <mrobinson@igalia.com>
7880 Unreviewed, rolling out r73392.
7881 http://trac.webkit.org/changeset/73392
7882 https://bugs.webkit.org/show_bug.cgi?id=50489
7884 This commit caused crashes on the GTK+ bots
7886 * WebView/WebFrame.mm:
7887 (-[WebFrame _canProvideDocumentSource]):
7889 2010-12-07 Kenichi Ishibashi <bashi@google.com>
7891 Reviewed by Kent Tamura.
7893 Let HTMLObjectElement be a form associated element
7894 https://bugs.webkit.org/show_bug.cgi?id=48821
7896 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
7898 * WebView/WebHTMLRepresentation.mm:
7899 (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
7900 FormAssociatedElement instead of HTMLFormControlElement.
7901 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
7903 2010-12-06 Nate Chapin <japhet@chromium.org>
7905 Reviewed by Adam Barth.
7907 Update calls to DocumentWriter.
7908 https://bugs.webkit.org/show_bug.cgi?id=50489
7910 * WebView/WebFrame.mm:
7911 (-[WebFrame _canProvideDocumentSource]):
7913 2010-12-06 Chris Marrin <cmarrin@apple.com>
7915 Reviewed by Simon Fraser.
7917 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
7918 https://bugs.webkit.org/show_bug.cgi?id=49388
7920 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
7921 GraphicsLayer::platformLayer().
7923 * WebCoreSupport/WebChromeClient.mm:
7924 (WebChromeClient::attachRootGraphicsLayer):
7926 2010-12-04 Dan Bernstein <mitz@apple.com>
7928 Reviewed by Sam Weinig.
7930 WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
7931 https://bugs.webkit.org/show_bug.cgi?id=50530
7933 * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
7934 * WebView/WebHTMLView.mm:
7935 (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
7936 which is passed through to WebCore.
7937 * WebView/WebPDFView.mm:
7938 (isFrameInRange): Added this helper function.
7939 (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
7940 a check if the frame is in the range.
7941 * WebView/WebView.mm:
7942 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
7943 (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
7944 parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
7945 * WebView/WebViewPrivate.h:
7947 2010-12-03 Sam Weinig <sam@webkit.org>
7949 Reviewed by Maciej Stachowiak.
7951 Enable <a ping> for Mac/Windows/WebKit2 builds
7952 <rdar://problem/8504473>
7953 https://bugs.webkit.org/show_bug.cgi?id=50488
7955 * WebView/WebPreferences.mm:
7956 (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
7958 2010-12-03 Jia Pu <jpu@apple.com>
7960 Reviewed by Darin Adler.
7962 Need to move all code that applies correction into correction panel callback.
7963 https://bugs.webkit.org/show_bug.cgi?id=50426
7964 <rdar://problem/8720832>
7966 * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
7968 * WebCoreSupport/WebEditorClient.mm:
7969 (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
7970 (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
7971 (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
7973 2010-12-02 Simon Fraser <simon.fraser@apple.com>
7975 Revert r73217 and r73227 because of continued bustage.
7977 * WebCoreSupport/WebChromeClient.mm:
7978 (WebChromeClient::attachRootGraphicsLayer):
7980 2010-12-02 Chris Marrin <cmarrin@apple.com>
7982 Reviewed by Simon Fraser.
7984 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
7985 https://bugs.webkit.org/show_bug.cgi?id=49388
7987 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
7988 GraphicsLayer::platformLayer().
7990 * WebCoreSupport/WebChromeClient.mm:
7991 (WebChromeClient::attachRootGraphicsLayer):
7993 2010-12-02 Mark Rowe <mrowe@apple.com>
7995 Reviewed by Beth Dakin.
7997 <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
7999 * Misc/WebNSFileManagerExtras.m:
8000 (setMetaData): Create an autorelease pool for the duration of the thread body.
8002 2010-12-02 John Knottenbelt <jknotten@chromium.org>
8004 Reviewed by Steve Block.
8006 Move requestGeolocationPermissionForFrame to GeolocationClient
8007 https://bugs.webkit.org/show_bug.cgi?id=50061
8009 This change facilitates client-based geolocation implementation by
8010 bringing together permission control into the geolocation client
8013 Move method ChromeClient::requestGeolocationPermissionForFrame to
8014 GeolocationClient::requestPermission, and supporting class
8015 WebGeolocationPolicyListener. The moved code is unchanged except
8016 that requestPermission now takes only one argument (Geolocation*)
8017 and the Frame parameter is retrieved from the Geolocation object.
8019 * WebCoreSupport/WebChromeClient.h:
8020 * WebCoreSupport/WebChromeClient.mm:
8021 * WebCoreSupport/WebGeolocationClient.h:
8022 (WebGeolocationClient::cancelPermissionRequest):
8023 * WebCoreSupport/WebGeolocationClient.mm:
8024 (WebGeolocationClient::requestPermission):
8025 (-[WebGeolocationPolicyListener initWithGeolocation:]):
8026 (-[WebGeolocationPolicyListener allow]):
8027 (-[WebGeolocationPolicyListener deny]):
8029 2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
8031 Reviewed by Eric Carlson.
8033 Style Fixes in WebPluginController
8034 https://bugs.webkit.org/show_bug.cgi?id=50397
8036 * Plugins/WebPluginController.mm:
8037 (-[WebPluginController startAllPlugins]):
8038 (-[WebPluginController stopAllPlugins]):
8040 2010-12-02 John Sullivan <sullivan@apple.com>
8042 Reviewed by Adam Roben.
8044 Slightly speculative fix for:
8046 <rdar://problem/8712674>
8047 <https://bugs.webkit.org/show_bug.cgi?id=50393>
8048 setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
8050 * Panels/WebAuthenticationPanel.m:
8051 (-[WebAuthenticationPanel setUpForChallenge:]):
8052 If the realm is nil, use @"" instead.
8054 2010-12-01 Jia Pu <jpu@apple.com>
8056 Reviewed by Darin Adler.
8058 Support multiple correction candidates panel for misspelled word on Mac OS X.
8059 https://bugs.webkit.org/show_bug.cgi?id=50137
8060 <rdar://problem/8568059>
8062 This patch is for supporting multiple correction suggestion panel on Mac OS X.
8063 The behavior and implementation is similar to that of reversion candiate panel.
8065 * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
8067 * WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class.
8068 Added code to handle new multiple suggestion canidate panel type.
8069 (WebEditorClient::showCorrectionPanel):
8070 (WebEditorClient::getGuessesForWord):
8072 2010-12-01 David Hyatt <hyatt@apple.com>
8074 Reviewed by Darin Adler.
8076 https://bugs.webkit.org/show_bug.cgi?id=46645
8078 Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
8079 recently added for horizontal RTL documents and applies it to writing modes as well. Now the
8080 scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
8082 This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
8083 makes them behave the same as the cross-platform code (allowing for cross-platform results to be
8086 * WebView/WebDynamicScrollBarsView.mm:
8087 (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
8088 (-[WebDynamicScrollBarsView updateScrollers]):
8089 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
8090 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
8091 (-[WebDynamicScrollBarsView scrollOrigin]):
8092 * WebView/WebFrameView.mm:
8093 (-[WebFrameView _scrollToBeginningOfDocument]):
8094 (-[WebFrameView _scrollToEndOfDocument]):
8096 2010-11-29 Dan Bernstein <mitz@apple.com>
8098 Reviewed by Darin Adler.
8100 WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
8101 https://bugs.webkit.org/show_bug.cgi?id=50038
8102 Based on a patch from Darin Adler.
8104 * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
8105 replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
8106 method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
8107 method. Made WebHTMLView conform to the new protocol.
8108 * WebView/WebHTMLView.mm:
8109 (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
8110 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
8111 -findString:options:.
8112 (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
8113 (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
8114 * WebView/WebPDFView.mm:
8115 (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
8116 * WebView/WebView.mm:
8117 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
8118 -countMatchesForText:options:highlight:limit:markMatches.
8119 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
8120 (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
8121 -findString:options:.
8122 (incrementFrame): Changed to use WebFindOptions.
8123 (findString): Added this helper method that performs the search using the best supported
8124 method for the document view.
8125 (-[WebView findString:options:]): Changed -searchFor::::: into this.
8126 (-[WebView canMarkAllTextMatches]):
8127 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
8129 (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
8130 (-[WebView rectsForTextMatches]): Ditto.
8131 * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
8132 of countMatchesForText:.
8134 2010-11-29 Jeremy Moskovich <jeremy@chromium.org>
8136 Reviewed by David Hyatt.
8138 Right-to-left pages should be scrollable to reveal left overflow.
8139 https://bugs.webkit.org/show_bug.cgi?id=23556
8141 Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
8142 Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
8143 pages with a left overflow.
8145 * WebView/WebDynamicScrollBarsView.h:
8146 * WebView/WebDynamicScrollBarsView.mm:
8147 (-[WebDynamicScrollBarsView inProgramaticScroll]):
8148 (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
8149 (-[WebDynamicScrollBarsView updateScrollers]):
8150 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
8151 (-[WebDynamicScrollBarsView setScrollOriginX:]):
8152 (-[WebDynamicScrollBarsView scrollOriginX]):
8153 * WebView/WebFrameView.mm:
8154 (-[WebFrameView _scrollToBeginningOfDocument]):
8155 (-[WebFrameView _scrollToEndOfDocument]):
8156 * WebView/WebHTMLView.mm:
8157 (-[WebHTMLView _frameOrBoundsChanged]):
8159 2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
8161 Reviewed by Tony Chang.
8163 SelectionController::typingStyle() should return EditingStyle*
8164 https://bugs.webkit.org/show_bug.cgi?id=49813
8166 Changed the return value of SelectionController::typingStyle() to EditingStyle*.
8167 Also added SelectionController::copyTypingStyle() to copy the typing style
8168 as an instance of CSSMutableStyleDeclaration.
8170 No tests are added since this is no behavioral change.
8172 * WebView/WebFrame.mm:
8173 (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
8175 2010-11-19 Michael Saboff <msaboff@apple.com>
8177 Reviewed by Sam Weinig
8179 Remove DOMSVGAnimatedPathData.h from all: target to fix build.
8181 * MigrateHeaders.make:
8183 2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
8185 Reviewed by Dirk Schulze.
8187 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
8188 https://bugs.webkit.org/show_bug.cgi?id=49580
8190 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
8192 2010-11-18 Mark Rowe <mrowe@apple.com>
8194 Rubber-stamped by Adam Roben.
8196 <rdar://problem/8602509&8602717&8602724> Enable compaction support.
8198 * Configurations/WebKit.xcconfig:
8200 2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
8202 Unreviewed, rolling out r72288.
8203 http://trac.webkit.org/changeset/72288
8204 https://bugs.webkit.org/show_bug.cgi?id=49730
8206 'krit attempted to do that, but revert got stuck' (Requested
8207 by antonm on #webkit).
8209 * WebView/WebRenderLayer.mm:
8211 2010-11-17 Nikolas Zimmermann <nzimmermann@rim.com>
8213 Reviewed by Dirk Schulze.
8215 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
8216 https://bugs.webkit.org/show_bug.cgi?id=49580
8218 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
8220 2010-11-16 Stephanie Lewis <slewis@apple.com>
8222 Reviewed by Geoff Garen.
8224 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
8226 Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
8227 every WebView, and the WebKit API doesn't support that ownership model.
8229 * WebView/WebDeviceOrientationProviderMock.h:
8230 * WebView/WebDeviceOrientationProviderMock.mm:
8231 (+[WebDeviceOrientationProviderMock shared]):
8233 2010-11-16 Dave Hyatt <hyatt@apple.com>
8235 Reviewed by Dan Bernstein.
8237 https://bugs.webkit.org/show_bug.cgi?id=11004
8239 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
8240 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
8241 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
8242 of the constructor rather than using [NSFont pointSize].
8244 https://bugs.webkit.org/show_bug.cgi?id=49582
8246 Negative leading is not handled correctly. There are two bugs here. The first is that
8247 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
8248 set them before so that we can allow them to be < 0.
8250 The second issue is that we should understand where fonts will end up relative to
8251 our baseline (excluding line height), and only allow those boxes to impact ascent and
8252 descent if the actual font box (without factoring in line height) is above or below the
8253 root line box baseline.
8255 Added fast/css/negative-leading.html
8257 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
8259 * Misc/WebKitNSStringExtras.mm:
8260 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
8261 (-[NSString _web_widthWithFont:]):
8262 * Misc/WebStringTruncator.mm:
8264 * WebView/WebPreferences.mm:
8265 (+[WebPreferences initialize]):
8267 2010-11-16 Anders Carlsson <andersca@apple.com>
8271 * WebCoreSupport/WebFrameLoaderClient.mm:
8273 2010-11-14 Kent Tamura <tkent@chromium.org>
8275 Reviewed by Andreas Kling.
8277 KeyboardEvent::keyIdentifier() should return "const String&"
8278 https://bugs.webkit.org/show_bug.cgi?id=49426
8280 * WebCoreSupport/WebEditorClient.mm:
8281 (selectorForKeyEvent):
8282 Change the type of a variable to have keyIdentifier(); String -> const String&
8284 2010-11-12 John Knottenbelt <jknotten@chromium.org>
8286 Reviewed by Steve Block.
8288 Rename GeolocationControllerClient to GeolocationClient.
8289 https://bugs.webkit.org/show_bug.cgi?id=49259
8291 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
8292 (WebGeolocationClient::webView):
8293 (WebGeolocationClient::setEnableHighAccuracy):
8294 * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
8295 (WebGeolocationClient::WebGeolocationClient):
8296 (WebGeolocationClient::geolocationDestroyed):
8297 (WebGeolocationClient::startUpdating):
8298 (WebGeolocationClient::stopUpdating):
8299 (WebGeolocationClient::lastPosition):
8301 * WebView/WebView.mm:
8302 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
8304 2010-11-10 Beth Dakin <bdakin@apple.com>
8306 Reviewed by Simon Fraser.
8308 Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
8309 -[WebView _scaleWebView:] should take and origin and scroll the
8312 <rdar://problem/8643921>
8314 * WebView/WebView.mm:
8315 (-[WebView _scaleWebView:atOrigin:]):
8316 * WebView/WebViewPrivate.h:
8318 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
8320 Reviewed by David Hyatt.
8322 HTML5 Ruby support should be mandatory feature
8323 https://bugs.webkit.org/show_bug.cgi?id=49272
8325 Remove Ruby as optional feature.
8327 * Configurations/FeatureDefines.xcconfig:
8329 2010-11-08 Ned Holbrook <nholbrook@apple.com>
8331 Reviewed by Adam Barth.
8333 Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
8334 https://bugs.webkit.org/show_bug.cgi?id=48886
8336 * WebCoreSupport/WebSystemInterface.mm:
8337 (InitWebCoreSystemInterface):
8339 2010-11-08 Nate Chapin <japhet@chromium.org>
8341 Unreviewed, build fix.
8343 Clumsy typo in r71562.
8345 * Plugins/Hosted/HostedNetscapePluginStream.mm:
8346 (WebKit::HostedNetscapePluginStream::start):
8348 2010-11-08 Nate Chapin <japhet@chromium.org>
8350 Reviewed by Alexey Proskuryakov.
8352 Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
8354 * Plugins/Hosted/HostedNetscapePluginStream.mm:
8355 (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
8356 * Plugins/WebNetscapePluginStream.mm:
8357 (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
8358 * WebView/WebView.mm:
8359 (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
8361 2010-11-08 Anders Carlsson <andersca@apple.com>
8363 Reviewed by Dan Bernstein.
8365 Plug-in views should not assume that plugins are RenderEmbeddedObjects
8366 https://bugs.webkit.org/show_bug.cgi?id=49196
8367 <rdar://problem/8638467>
8369 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
8370 (-[WebHostedNetscapePluginView pluginHostDied]):
8372 2010-11-08 Alexey Proskuryakov <ap@apple.com>
8374 Reviewed by Darin Adler.
8376 https://bugs.webkit.org/show_bug.cgi?id=48685
8377 Notify UI process about focused frame
8379 Added an empty implementation of the new ChromeClient method.
8381 * WebCoreSupport/WebChromeClient.h:
8382 * WebCoreSupport/WebChromeClient.mm:
8383 (WebChromeClient::focusedFrameChanged):
8385 2010-11-08 Anders Carlsson <andersca@apple.com>
8389 * MigrateHeaders.make:
8391 2010-11-08 Anders Carlsson <andersca@apple.com>
8393 Reviewed by Adam Roben.
8395 Remove use of HIGetScaleFactor
8396 https://bugs.webkit.org/show_bug.cgi?id=49186
8397 <rdar://problem/8618410>
8399 Scale factors can vary on a display-by-display basis and it doesn't make sense
8400 to compute scale factor event coordinates like this.
8402 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
8405 2010-11-08 Simon Fraser <simon.fraser@apple.com>
8407 Reviewed by Sam Weinig.
8409 Allow applets to participate in accelerated compositing
8410 https://bugs.webkit.org/show_bug.cgi?id=49117
8411 <rdar://problem/8625819>
8413 If Java is being loaded via the Netscape Plugin API, create a
8414 NetscapePluginWidget so that it has an implementation of platformLayer().
8416 Also clean up by using early returns.
8418 * WebCoreSupport/WebFrameLoaderClient.mm:
8420 2010-11-07 Adam Barth <abarth@webkit.org>
8422 Reviewed by Eric Seidel.
8424 Rename Cache to MemoryCache
8425 https://bugs.webkit.org/show_bug.cgi?id=49159
8428 (+[WebCache statistics]):
8429 * WebCoreSupport/WebDeviceOrientationClient.mm:
8430 (WebDeviceOrientationClient::setController):
8431 * WebView/WebView.mm:
8433 2010-11-05 Alexey Proskuryakov <ap@apple.com>
8435 Reviewed by Darin Adler.
8437 https://bugs.webkit.org/show_bug.cgi?id=49100
8438 ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
8440 * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
8441 Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
8442 (see bug comments), and there seems to be no harm in executing this function in that case.
8444 2010-11-05 Chris Marrin <cmarrin@apple.com>
8446 Reviewed by Simon Fraser.
8448 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
8449 https://bugs.webkit.org/show_bug.cgi?id=49073
8451 * WebView/WebFrame.mm:
8452 (-[WebFrame _suspendAnimations]):
8453 (-[WebFrame _resumeAnimations]):
8455 2010-11-04 Alexey Proskuryakov <ap@apple.com>
8457 Reviewed by Darin Adler.
8459 https://bugs.webkit.org/show_bug.cgi?id=49008
8460 <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
8462 Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
8463 the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
8464 deleted during wait:
8466 - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
8469 We didn't recognize the latter.
8471 * Plugins/Hosted/NetscapePluginHostProxy.mm:
8472 (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
8473 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
8474 (WebKit::NetscapePluginInstanceProxy::waitForReply):
8475 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
8476 (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
8478 2010-11-05 Chris Marrin <cmarrin@apple.com>
8480 Reviewed by Simon Fraser.
8482 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
8483 https://bugs.webkit.org/show_bug.cgi?id=46945
8485 * WebView/WebFrame.mm:
8486 (-[WebFrame _suspendAnimations]):
8487 (-[WebFrame _resumeAnimations]):
8489 2010-11-04 Jia Pu <jpu@apple.com>
8491 Reviewed by Dan Bernstein.
8493 reversion bubble in WebViews
8494 https://bugs.webkit.org/show_bug.cgi?id=47630
8495 <rdar://problem/8530960>
8497 This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
8499 * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
8500 * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
8501 change to use new reversion API in AppKit.
8502 (WebEditorClient::WebEditorClient):
8503 (WebEditorClient::~WebEditorClient):
8504 (WebEditorClient::respondToChangedSelection):
8505 (WebEditorClient::showCorrectionPanel):
8506 (WebEditorClient::dismissCorrectionPanel):
8507 (WebEditorClient::isShowingCorrectionPanel):
8509 2010-11-04 Mike Thole <mthole@apple.com>
8511 Reviewed by Dan Bernstein.
8513 Title for images should use localized numerals
8514 https://bugs.webkit.org/show_bug.cgi?id=49017
8516 * WebCoreSupport/WebPlatformStrategies.mm:
8517 (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
8519 2010-11-02 Daniel Bates <dbates@rim.com>
8521 Reviewed by Adam Barth.
8523 For unnamed frames, window.name returns a generated name
8524 https://bugs.webkit.org/show_bug.cgi?id=6751
8528 Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.
8530 * WebView/WebFrame.mm:
8533 2010-11-01 Brady Eidson <beidson@apple.com>
8535 Reviewed by Anders Carlsson.
8537 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
8538 Context menu support for WebKit 2.
8540 * WebCoreSupport/WebChromeClient.h:
8541 (WebChromeClient::showContextMenu):
8543 2010-10-29 Daniel Bates <dbates@rim.com>
8545 No review, rolling out 70971.
8546 http://trac.webkit.org/changeset/70971
8547 https://bugs.webkit.org/show_bug.cgi?id=6751
8549 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
8550 it caused layout test failures on all bots. In particular, the
8551 child count in a generated frame name differs after this patch. We need
8552 to look into this further.
8554 * WebView/WebFrame.mm:
8557 2010-10-28 Antonio Gomes <agomes@rim.com>
8559 Reviewed by Ojan Vafai.
8561 Needs a "LinuxEditingBehavior", perhaps with a better name
8562 https://bugs.webkit.org/show_bug.cgi?id=36627
8564 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
8566 * WebView/WebFrame.mm:
8568 * WebView/WebPreferencesPrivate.h:
8570 2010-10-29 Daniel Bates <dbates@rim.com>
8572 Reviewed by Adam Barth.
8574 For unnamed frames, window.name returns a generated name
8575 https://bugs.webkit.org/show_bug.cgi?id=6751
8577 Modified Mac-port to use FrameTree::uniqueName().
8579 * WebView/WebFrame.mm:
8582 2010-10-29 Darin Adler <darin@apple.com>
8584 Reviewed by Sam Weinig.
8586 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
8587 https://bugs.webkit.org/show_bug.cgi?id=48574
8589 * History/WebBackForwardList.mm:
8590 Use BackForwardListImpl.
8592 2010-10-29 Alexey Proskuryakov <ap@apple.com>
8594 Rubber-stamped by Sam Weinig.
8596 Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
8597 create views for subframes.
8599 * WebView/WebViewData.h: Double negation is better than a lie.
8601 2010-10-27 Jer Noble <jer.noble@apple.com>
8603 Reviewed by Darin Adler.
8605 Full screen video in Safari (still) exits full-screen if you switch to another
8606 app on a multi-display system.
8607 https://bugs.webkit.org/show_bug.cgi?id=47364
8608 <rdar://problem/8382299>
8610 The FullScreen window does not technically close when it deactivates, but the
8611 two NSWindows that make up the FullScreen feature should not hide when deactivated.
8613 * WebView/WebVideoFullscreenController.mm:
8614 (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
8615 (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
8616 * WebView/WebVideoFullscreenHUDWindowController.mm:
8617 (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
8619 2010-10-29 Alexey Proskuryakov <ap@apple.com>
8621 Reviewed by Darin Adler.
8623 https://bugs.webkit.org/show_bug.cgi?id=48576
8624 Let WebKit2 client know when a frame is a frameset
8626 Added a blank implementation of the new FrameLoaderClient method.
8628 * WebCoreSupport/WebFrameLoaderClient.h:
8629 * WebCoreSupport/WebFrameLoaderClient.mm:
8630 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
8632 2010-10-29 Csaba Osztrogonác <ossy@webkit.org>
8634 Reviewed by Adam Roben and David Kilzer.
8636 Fix and cleanup of build systems
8637 https://bugs.webkit.org/show_bug.cgi?id=48342
8639 * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
8641 2010-10-28 Dan Bernstein <mitz@apple.com>
8643 Reviewed by Mark Rowe.
8645 LLVM compiler build fix
8647 * Misc/WebDownload.mm:
8648 (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
8649 id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
8651 2010-10-28 Ivan Krstić <ike@apple.com>
8653 Reviewed by Mark Rowe.
8655 Remove unused experimental proxied panel interface.
8656 <rdar://problem/7237059>
8658 * Plugins/Hosted/NetscapePluginHostManager.h:
8659 * Plugins/Hosted/NetscapePluginHostManager.mm:
8660 (WebKit::NetscapePluginHostManager::hostForPlugin):
8661 (WebKit::NetscapePluginHostManager::spawnPluginHost):
8662 (WebKit::NetscapePluginHostManager::instantiatePlugin):
8663 * Plugins/Hosted/NetscapePluginHostProxy.mm:
8664 * Plugins/Hosted/WebKitPluginClient.defs:
8665 * Plugins/Hosted/WebKitPluginHost.defs:
8666 * WebCoreSupport/WebSystemInterface.mm:
8667 (InitWebCoreSystemInterface):
8668 * WebView/WebPreferenceKeysPrivate.h:
8669 * WebView/WebPreferences.mm:
8670 (+[WebPreferences initialize]):
8671 * WebView/WebPreferencesPrivate.h:
8673 2010-10-27 Pratik Solanki <psolanki@apple.com>
8675 Reviewed by Darin Adler.
8677 Improve memSize calculation in [WebView _setCacheModel]
8678 https://bugs.webkit.org/show_bug.cgi?id=48484
8680 * WebView/WebView.mm:
8681 (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
8682 (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
8683 bigger power of 2. Also update WebCore cache settings.
8685 2010-10-26 Darin Adler <darin@apple.com>
8687 Reviewed by Sam Weinig.
8689 WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
8690 https://bugs.webkit.org/show_bug.cgi?id=42322
8691 rdar://problem/8193631
8693 WebKitTestRunner needs to support layoutTestController.clearBackForwardList
8694 https://bugs.webkit.org/show_bug.cgi?id=42333
8695 rdar://problem/8193643
8697 * History/WebBackForwardList.mm:
8698 (core): Return BackForwardListImpl.
8699 (kit): Take BackForwardListImpl.
8700 (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
8701 (-[WebBackForwardList dealloc]): Ditto.
8702 (-[WebBackForwardList finalize]): Ditto.
8703 (-[WebBackForwardList description]): Ditto.
8704 (-[WebBackForwardList setPageCacheSize:]): Ditto.
8705 (-[WebBackForwardList pageCacheSize]): Ditto.
8706 * History/WebBackForwardListInternal.h: Ditto.
8707 * WebView/WebFrameView.mm:
8708 (-[WebFrameView keyDown:]): Ditto.
8709 * WebView/WebView.mm:
8710 (-[WebView initWithCoder:]): Ditto.
8711 (-[WebView encodeWithCoder:]): Ditto.
8712 (-[WebView backForwardList]): Ditto.
8713 (-[WebView setMaintainsBackForwardList:]): Ditto.
8715 2010-10-27 Chris Rogers <crogers@google.com>
8717 Reviewed by Chris Marrin.
8719 Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
8720 https://bugs.webkit.org/show_bug.cgi?id=48279
8722 * Configurations/FeatureDefines.xcconfig:
8724 2010-10-27 Beth Dakin <bdakin@apple.com>
8726 Reviewed by Darin Adler.
8728 Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
8729 SPI to scale a WebView
8731 <rdar://problem/8107667>
8733 This patch adds SPI to Mac WebKit that scales the page by the given
8736 * WebView/WebView.mm:
8737 (-[WebView _scaleWebView:]):
8738 (-[WebView _viewScaleFactor]):
8739 * WebView/WebViewPrivate.h:
8741 2010-10-27 Dan Bernstein <mitz@apple.com>
8743 Reviewed by Darin Adler.
8745 REGRESSION (r70335): Incorrect article layout in Safari Reader
8746 https://bugs.webkit.org/show_bug.cgi?id=48436
8748 * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
8749 * WebView/WebView.mm:
8750 (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
8751 versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
8752 (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
8755 2010-10-18 Jer Noble <jer.noble@apple.com>
8757 Reviewed by Eric Carlson.
8759 Safari fullscreen media element tickles when it should not.
8761 https://bugs.webkit.org/show_bug.cgi?id=47861
8763 * WebView/WebVideoFullscreenController.mm:
8764 (-[WebVideoFullscreenController updatePowerAssertions]):
8766 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
8768 Reviewed by Dmitry Titov.
8770 Resource tracking failure when trying to move a frame between documents
8771 https://bugs.webkit.org/show_bug.cgi?id=44713
8773 * WebCoreSupport/WebFrameLoaderClient.h:
8774 * WebCoreSupport/WebFrameLoaderClient.mm:
8775 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
8777 (WebFrameLoaderClient::transferLoadingResourceFromPage):
8778 Update resource tracking for a resource load that has been transferred
8781 2010-10-25 Oliver Hunt <oliver@apple.com>
8783 Reviewed by Gavin Barraclough.
8785 Remove exec and globalData arguments from jsNumber
8786 https://bugs.webkit.org/show_bug.cgi?id=48270
8788 Mechanical removal of exec parameter to jsNumber
8790 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
8791 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
8792 * Plugins/Hosted/ProxyInstance.mm:
8793 (WebKit::ProxyInstance::numberValue):
8795 2010-10-24 Dan Bernstein <mitz@apple.com>
8797 Reviewed by Anders Carlsson.
8799 Expose HitTestResult::absoluteMediaURL() via WebKit API
8800 https://bugs.webkit.org/show_bug.cgi?id=48219
8802 * Misc/WebElementDictionary.mm:
8803 (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
8805 (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
8806 * WebKit.exp: Export WebElementMediaURLKey.
8807 * WebView/WebView.mm: Define WebElementMediaURLKey.
8808 * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
8810 2010-10-24 Dan Bernstein <mitz@apple.com>
8812 Reviewed by Simon Fraser.
8814 Removed deprecated methods from the WebHTMLHighlighter private protocol.
8816 * WebCoreSupport/WebChromeClient.mm:
8817 (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
8819 (WebChromeClient::paintCustomHighlight): Call
8820 -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
8821 * WebView/WebHTMLViewPrivate.h:
8823 2010-10-23 Xan Lopez <xlopez@igalia.com>
8825 Reviewed by Sam Weinig.
8827 Unify globalData APIs
8828 https://bugs.webkit.org/show_bug.cgi?id=47969
8830 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
8831 (WebKit::NetscapePluginInstanceProxy::evaluate):
8832 (WebKit::NetscapePluginInstanceProxy::invoke):
8833 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
8834 (WebKit::NetscapePluginInstanceProxy::construct):
8835 * WebView/WebScriptDebugDelegate.mm:
8836 (-[WebScriptCallFrame evaluateWebScript:]):
8838 2010-10-23 David Kilzer <ddkilzer@apple.com>
8840 <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
8842 Reviewed by Sam Weinig.
8844 The only method defined in WebHTMLRepresentationInternal.h is
8845 also defined in WebHTMLRepresentation.h, so use that instead.
8847 * WebView/WebHTMLRepresentationInternal.h: Removed.
8849 2010-10-23 Alexey Proskuryakov <ap@apple.com>
8851 Reviewed by Anders Carlsson.
8853 https://bugs.webkit.org/show_bug.cgi?id=48083
8854 <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
8856 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
8858 2010-10-22 Sam Weinig <sam@webkit.org>
8860 Reviewed by Anders Carlsson.
8862 WebKit2 needs to pass the current event modifier flags when requesting a new window
8863 https://bugs.webkit.org/show_bug.cgi?id=48140
8865 * WebCoreSupport/WebChromeClient.h:
8866 * WebCoreSupport/WebChromeClient.mm:
8867 (WebChromeClient::createWindow):
8868 * WebCoreSupport/WebFrameLoaderClient.h:
8869 * WebCoreSupport/WebFrameLoaderClient.mm:
8870 (WebFrameLoaderClient::dispatchCreatePage):
8871 Add NavigationAction parameter.
8873 2010-10-21 Andy Estes <aestes@apple.com>
8875 Reviewed by Eric Carlson.
8877 WebKit shouldn't load a plug-in based on file extension if a MIME type
8879 https://bugs.webkit.org/show_bug.cgi?id=48046
8881 If a MIME type is specified in an object or embed element, and that MIME
8882 type isn't supported by an installed plug-in, WebKit shouldn't attempt
8883 to find a plug-in based on the file extension of the url attribute.
8884 Doing so can lead to cases where a plug-in is loaded that can't handle
8885 resources of the MIME type specified by the author.
8887 * WebCoreSupport/WebFrameLoaderClient.mm:
8888 (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
8889 extension if MIME type is the empty string.
8891 2010-10-20 Simon Fraser <simon.fraser@apple.com>
8893 Reviewed by Dan Bernstein.
8895 Composited elements drawn twice when WebView is layer-backed
8896 https://bugs.webkit.org/show_bug.cgi?id=48024
8897 <rdar://problem/7916580>
8899 When drawing content in a layer-backed WebView, WebFrame's test
8900 for drawing to a bitmap succeeded, causing us to paint flattened
8901 compositing layers into the view. They would also be rendered
8902 by the normal compositing path, resulting in double rendering.
8904 Fix this by detecting when the WebHTMLView is being drawn into
8905 a layer, and avoiding flattening in that case.
8907 * WebView/WebFrame.mm:
8908 (-[WebFrame _showFlattenedCompositingLayers:]):
8909 (-[WebFrame _drawRect:contentsOnly:]):
8910 * WebView/WebHTMLView.mm:
8911 (-[WebHTMLView drawLayer:inContext:]):
8912 (-[WebHTMLView _web_isDrawingIntoLayer]):
8913 * WebView/WebHTMLViewInternal.h:
8915 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
8917 Reviewed by David Levin.
8919 Repost the DatabaseTracker notifications to the main thread, if needed.
8920 https://bugs.webkit.org/show_bug.cgi?id=40655
8922 * Storage/WebDatabaseTrackerClient.mm:
8923 (DidModifyOriginData::dispatchToMainThread):
8924 (DidModifyOriginData::DidModifyOriginData):
8925 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
8926 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
8927 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
8929 2010-10-20 Simon Fraser <simon.fraser@apple.com>
8931 Reviewed by Darin Adler.
8933 REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
8934 https://bugs.webkit.org/show_bug.cgi?id=47369
8936 r46947 added code that limits the size of the layer-backed view on Leopard when
8937 the page height exceeds 4096px (later adjusted to 2048px in r48401).
8939 Later, r67576 altered the geometry flipping behavior to push the geometry flipping
8940 down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
8941 to account for layer-backed view size-limiting was not fixed at the same time.
8942 This change corrects that.
8944 * WebView/WebHTMLView.mm:
8945 (-[WebHTMLView _updateLayerHostingViewPosition]):
8947 2010-10-19 Simon Fraser <simon.fraser@apple.com>
8949 Reviewed by Dan Bernstein.
8951 <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
8953 AppKit has some special code to prevent it meddling with view's layers
8954 under layer-backed WebViews. When a layer-backed WebView became composited,
8955 this caused our layer to remain zero-sized. Fix this by manually
8956 setting the geometry for our layer, if the WebHTMLView has a layer.
8958 This does not seem to be a problem if the WebView becomes layer-backed, or
8959 stops being layer-backed after the WebView starts using compositing.
8961 * WebView/WebHTMLView.mm:
8962 (-[WebHTMLView attachRootLayer:]):
8964 2010-10-20 Dirk Schulze <krit@webkit.org>
8966 Reviewed by Nikolas Zimmermann.
8968 Merge ColorSpace and ImageColorSpace enums
8969 https://bugs.webkit.org/show_bug.cgi?id=47922
8971 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
8972 to follow webkit style rules.
8974 * Misc/WebKitNSStringExtras.mm:
8975 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
8977 2010-10-19 Alexey Proskuryakov <ap@apple.com>
8979 Reviewed by Anders Carlsson.
8981 https://bugs.webkit.org/show_bug.cgi?id=47933
8982 <rdar://problem/8494337> navigator.language doesn't work in WebKit2
8984 * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
8985 We need to keep _webkit_preferredLanguageCode for Safari.
8987 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
8988 Initialize wkCopyCFLocalizationPreferredName.
8990 * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
8992 2010-10-18 Alexey Proskuryakov <ap@apple.com>
8994 Reviewed by David Kilzer.
8996 https://bugs.webkit.org/show_bug.cgi?id=47864
8997 Convert WebNSUserDefaultsExtras.m to .mm
8999 Also, fixed some issues in the process:
9000 - removed locking, which was only necessary when this code was in Foundation;
9001 - fixed notification center observer to actually work (previously, it picked up changes
9002 when application preferences changed, not when system language did);
9003 - removed unused NSString category;
9006 * Misc/WebNSUserDefaultsExtras.m: Removed.
9007 * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
9008 (createHTTPStyleLanguageCode):
9009 (+[NSUserDefaults _webkit_defaultsDidChange]):
9010 (addLanguageChangeObserver):
9011 (+[NSUserDefaults _webkit_preferredLanguageCode]):
9013 2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
9015 Reviewed by Eric Seidel.
9017 Switch to using the new Carbon NPAPI event declarations, and remove
9020 https://bugs.webkit.org/show_bug.cgi?id=40784
9022 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
9023 (WebNetscapePluginEventHandlerCarbon::mouseEntered):
9024 (WebNetscapePluginEventHandlerCarbon::mouseExited):
9025 (WebNetscapePluginEventHandlerCarbon::mouseMoved):
9026 (WebNetscapePluginEventHandlerCarbon::focusChanged):
9028 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
9030 Reviewed by Timothy Hatcher.
9032 Web Inspector: disable private browsing for inspector
9033 https://bugs.webkit.org/show_bug.cgi?id=47827
9035 * WebCoreSupport/WebInspectorClient.mm:
9036 (-[WebInspectorWindowController init]):
9038 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
9040 Reviewed by Pavel Feldman.
9042 Web Inspector: inspector settings/properties/states management
9043 should be extracted into separate class.
9045 We have a lot of flags/values in InspectorController.
9046 Some flags are persisting into profile.
9047 Others are part of inspector state for frontend.
9048 All these flags should keep their values after navigation.
9049 It'd be better to extract these flags/values into separate
9050 class which will care about theirs lifetime.
9052 https://bugs.webkit.org/show_bug.cgi?id=47275
9054 * WebCoreSupport/WebInspectorClient.mm:
9055 (-[WebInspectorWindowController showWindow:]):
9056 (-[WebInspectorWindowController attach]):
9057 (-[WebInspectorWindowController detach]):
9059 2010-10-13 Gavin Barraclough <barraclough@apple.com>
9061 Reviewed by Oliver Hunt.
9063 https://bugs.webkit.org/show_bug.cgi?id=43987
9064 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
9065 to construct their internal result string. Remove ScriptString (this is now
9068 * WebCoreSupport/WebFrameLoaderClient.mm:
9070 2010-10-12 Andy Estes <aestes@apple.com>
9072 Rubber-stamped by Darin Adler.
9074 Check in some cleanup from the previous commit.
9076 * WebView/WebView.mm:
9077 (leakMailQuirksUserScriptPath): Renamed to indicate that this function
9079 (-[WebView _injectMailQuirksScript]): Moved a static initialization from
9080 a separate class method into the only method that used it and removed
9081 the now-unnecessary class method.
9083 2010-10-12 Eric Seidel <eric@webkit.org>
9085 Reviewed by Darin Adler.
9087 REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
9088 https://bugs.webkit.org/show_bug.cgi?id=45693
9090 Re-implement this former WebCore parser quirk as a
9091 Mac-only userscript-based quirk. As far as I can tell
9092 from Darin's description this should satisfy Mail's needs.
9094 * Misc/MailQuirksUserScript.js: Added.
9095 * WebView/WebView.mm:
9096 (+[WebView _mailQuirksUserScript]):
9097 (-[WebView _injectMailQuirksScript]):
9098 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
9100 2010-10-12 Simon Fraser <simon.fraser@apple.com>
9102 Reviewed by Sam Weinig.
9104 Add 'didDraw' callback for framerate tracking
9105 https://bugs.webkit.org/show_bug.cgi?id=47478
9107 Add a callback at the end of -[WebHTMLView drawRect:] so
9108 a delegate can get notified when a draw happens.
9110 * WebView/WebHTMLView.mm:
9111 (-[WebHTMLView drawRect:]):
9112 * WebView/WebUIDelegatePrivate.h:
9114 2010-10-11 Anders Carlsson <andersca@apple.com>
9116 Reviewed by Darin Adler.
9118 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
9119 https://bugs.webkit.org/show_bug.cgi?id=47523
9121 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
9123 * Misc/WebIconFetcher.h: Removed.
9124 * Misc/WebIconFetcher.mm: Removed.
9125 * Misc/WebIconFetcherInternal.h: Removed.
9126 * WebView/WebFrame.mm:
9127 * WebView/WebFramePrivate.h:
9129 2010-10-11 Jessie Berlin <jberlin@apple.com>
9131 Reviewed by Darin Adler.
9133 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
9134 representation of a WebKit1 WebSerializedJSValue.
9135 https://bugs.webkit.org/show_bug.cgi?id=47439
9137 * WebView/WebSerializedJSValue.mm:
9138 (-[WebSerializedJSValue internalRepresentation]):
9139 * WebView/WebSerializedJSValuePrivate.h:
9141 2010-10-07 Jessie Berlin <jberlin@apple.com>
9143 Reviewed by Sam Weinig.
9145 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
9146 representation of a WebKit2 WebSerializedScriptValue.
9147 https://bugs.webkit.org/show_bug.cgi?id=47390
9149 * WebView/WebSerializedJSValue.mm:
9150 (-[WebSerializedJSValue initWithInternalRepresentation:]):
9151 Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
9152 internal representation.
9153 * WebView/WebSerializedJSValuePrivate.h: Added.
9155 2010-10-07 Antonio Gomes <agomes@rim.com>
9157 Reviewed by Simon Fraser.
9159 [Mac] [DRT] implement setSpatialNavigationEnabled
9160 https://bugs.webkit.org/show_bug.cgi?id=47291
9162 Added the needed bits to make it possible to enabled spatial navigation
9163 for the Mac port. For now it is being only used by DRT.
9165 * WebView/WebPreferenceKeysPrivate.h:
9166 * WebView/WebPreferences.mm:
9167 (+[WebPreferences initialize]):
9168 (-[WebPreferences isSpatialNavigationEnabled]):
9169 (-[WebPreferences setSpatialNavigationEnabled:]):
9170 * WebView/WebPreferencesPrivate.h:
9171 * WebView/WebView.mm:
9172 (-[WebView _preferencesChangedNotification:]):
9174 2010-10-07 Jer Noble <jer.noble@apple.com>
9176 Fix the Leopard 64-bit build.
9178 * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
9179 framework search path.
9180 * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
9182 2010-10-06 Jer Noble <jer.noble@apple.com>
9184 Reviewed by Darin Adler.
9186 Screensaver starts while watching fullscreen playback.
9187 https://bugs.webkit.org/show_bug.cgi?id=47299
9188 <rdar://problem/8478956>
9190 To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
9192 * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
9193 * WebView/WebVideoFullscreenController.mm:
9194 (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
9195 (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer.
9196 (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
9197 (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
9198 (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
9199 or _disableTickleTimer.
9201 2010-10-05 Philippe Normand <pnormand@igalia.com>
9203 Reviewed by Martin Robinson.
9205 check for ENABLE(GLIB_SUPPORT) in WebView
9206 https://bugs.webkit.org/show_bug.cgi?id=46788
9208 Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.
9210 * WebView/WebView.mm:
9211 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
9212 (-[WebView _close]):
9213 * WebView/WebViewData.h:
9214 * WebView/WebViewInternal.h:
9216 2010-10-01 Anders Carlsson <andersca@apple.com>
9218 Fix Snow Leopard build.
9220 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
9221 (WebKit::NetscapePluginInstanceProxy::getProxy):
9223 2010-10-01 Anders Carlsson <andersca@apple.com>
9225 Reviewed by Dan Bernstein.
9227 Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
9228 https://bugs.webkit.org/show_bug.cgi?id=47022
9229 <rdar://problem/8504712>
9231 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
9232 (WebKit::NetscapePluginInstanceProxy::getProxy):
9233 * Plugins/WebBaseNetscapePluginView.h:
9234 * Plugins/WebBaseNetscapePluginView.mm:
9235 * Plugins/WebNetscapePluginView.mm:
9236 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
9238 2010-09-30 Darin Adler <darin@apple.com>
9240 Reviewed by Sam Weinig.
9242 Remove remaining calls to deprecatedParseURL
9243 https://bugs.webkit.org/show_bug.cgi?id=26599
9245 * DOM/WebDOMOperations.mm:
9246 (-[DOMDocument URLWithAttributeString:]):
9247 * WebCoreSupport/WebFrameLoaderClient.mm:
9248 (WebFrameLoaderClient::createPlugin):
9249 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
9251 2010-09-30 Anders Carlsson <andersca@apple.com>
9253 Reviewed by Darin Adler.
9255 -[DOMDocument _documentRange] throws an exception if there is no document element
9256 https://bugs.webkit.org/show_bug.cgi?id=46934
9257 <rdar://problem/8169260>
9259 If there is no document element, just return an empty range. Otherwise we'll try to call
9260 Range::selectNode with a null Node which will throw a NOT_FOUND exception.
9262 * DOM/WebDOMOperations.mm:
9263 (-[DOMDocument _documentRange]):
9265 2010-09-30 Chris Marrin <cmarrin@apple.com>
9267 Reviewed by Simon Fraser.
9269 Make 2D accelerated canvas rendering build on Mac
9270 https://bugs.webkit.org/show_bug.cgi?id=46007
9272 Added ACCELERATED_2D_CANVAS to FeatureDefines
9274 * Configurations/FeatureDefines.xcconfig:
9276 2010-09-30 Dan Bernstein <mitz@apple.com>
9278 Reviewed by John Sullivan.
9280 Add printing SPI allowing full control over shrink-to-fit
9281 https://bugs.webkit.org/show_bug.cgi?id=46877
9283 * WebView/WebHTMLView.mm:
9284 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
9285 * WebView/WebHTMLViewPrivate.h:
9287 2010-09-28 Johnny Ding <jnd@chromium.org>
9289 Reviewed by Adam Barth.
9291 https://bugs.webkit.org/show_bug.cgi?id=41292
9292 Some windowed plugins did not handle events through EventHandler, so we
9293 never set right gesture state for those events.
9294 This change is to set right allowPopupsFromPlugin flag to current
9295 execution frame, so WeKit can always get right gesture state on Mac.
9296 From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
9297 process, that process passes the allowPopupsFromPlugin flag to
9298 WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
9299 NetscapePluginInstanceProxy::evaluate.
9301 * Plugins/WebNetscapePluginView.mm:
9302 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
9304 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
9306 Reviewed by Dmitry Titov.
9308 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
9309 https://bugs.webkit.org/show_bug.cgi?id=46663
9311 * WebCoreSupport/WebFrameLoaderClient.h:
9312 * WebCoreSupport/WebFrameLoaderClient.mm:
9313 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
9315 2010-09-26 Antonio Gomes <agomes@rim.com>
9317 Reviewed by Kenneth Rohde Christiansen.
9319 DRT/Mac nodesFromRect support
9321 [Mac][DRT] Implement LayoutTestController::nodesFromRect
9322 https://bugs.webkit.org/show_bug.cgi?id=46580
9324 Implement nodesFromRect as a private method to access non-exposed Document
9325 methods, similarly to computedStyleIncludingVisitedInfo.
9327 * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
9328 These headers makes it possible to:
9329 1) Get a Document off of a JSDocument;
9330 2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
9331 gotten from Document::nodesFromRect to JS bindings.
9332 (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
9333 * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
9334 Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.
9336 2010-09-24 Jia Pu <jpu@apple.com>
9338 Reviewed by Dan Bernstein.
9340 automaticSpellingCorrectionEnabled isn't updated.
9341 https://bugs.webkit.org/show_bug.cgi?id=46486
9342 <rdar://problem/8475212>
9344 * WebView/WebView.mm:
9345 (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
9346 instead of "automaticTextReplacementEnabled".
9348 2010-09-23 Alexey Proskuryakov <ap@apple.com>
9350 Reviewed by Darin Adler.
9352 https://bugs.webkit.org/show_bug.cgi?id=46380
9353 REGRESSION: Crash when downloading a file
9355 Downloading cannot be tested in DRT.
9357 * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
9358 Don't copy null strings.
9360 2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
9362 Reviewed by Yury Semikhatsky.
9364 Web Inspector: CRASH at node highlight on MAC Safari.
9365 1) run-safari --debug
9367 3) open elements panel
9368 4) hover mouse over elements panel items multiple times
9370 Looks like it is a race condition. WebNodeHighlightView doesn't check
9371 the pointer to WebNodeHighligh object and it can be nil.
9373 https://bugs.webkit.org/show_bug.cgi?id=46261
9375 * WebInspector/WebNodeHighlightView.mm:
9376 (-[WebNodeHighlightView drawRect:]):
9378 2010-09-23 Andy Estes <aestes@apple.com>
9380 Reviewed by Darin Adler.
9382 REGRESSION (r61285): some Dashboard widgets are always invisible due to
9383 HTML parser changes.
9384 https://bugs.webkit.org/show_bug.cgi?id=46435
9386 Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
9389 * WebView/WebView.mm:
9390 (-[WebView _needsPreHTML5ParserQuirks]): Renamed from
9391 shouldUsePreHTML5ParserQuirks(). Return true if
9392 WebCore::Settings::usesDashboardCompatibilityMode() is true.
9393 (-[WebView _preferencesChangedNotification:]):
9394 (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks
9395 if Dashboard behavior is set to backward compatibility mode.
9397 2010-09-23 Matthew Delaney <mdelaney@apple.com>
9399 Reviewed by Simon Fraser.
9401 Reduce minimum DOMTimer interval
9402 https://bugs.webkit.org/show_bug.cgi?id=45362
9404 * WebView/WebView.mm:
9405 Updating set interval call to use Settings' static version inside
9406 one time init block.
9408 2010-09-22 Andy Estes <aestes@apple.com>
9410 Reviewed by Darin Adler.
9412 REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
9413 https://bugs.webkit.org/show_bug.cgi?id=46334
9415 Microsoft My Day loads scripts using self-closing script tags, markup
9416 which is incompatible with the HTML5 parser. Enable parser quirks for
9419 * WebView/WebView.mm:
9420 (shouldUsePreHTML5ParserQuirks): Return true if the application is
9421 Microsoft My Day and was linked against a version of WebKit prior to the
9422 introduction of the HTML5 parser.
9424 2010-09-23 Nate Chapin <japhet@chromium.org>
9426 Reviewed by Darin Fisher.
9428 Add hyperlink auditing settings (i.e., <a ping>).
9429 https://bugs.webkit.org/show_bug.cgi?id=30458
9431 * WebView/WebPreferenceKeysPrivate.h:
9432 * WebView/WebPreferences.mm:
9433 (+[WebPreferences initialize]):
9434 (-[WebPreferences setMemoryInfoEnabled:]):
9435 (-[WebPreferences hyperlinkAuditingEnabled]):
9436 (-[WebPreferences setHyperlinkAuditingEnabled:]):
9437 * WebView/WebPreferencesPrivate.h:
9438 * WebView/WebView.mm:
9439 (-[WebView _preferencesChangedNotification:]):
9441 2010-09-22 Alexey Proskuryakov <ap@apple.com>
9443 Reviewed by Anders Carlsson.
9445 https://bugs.webkit.org/show_bug.cgi?id=43667
9446 ASSERT failure in NetscapePluginInstanceProxy::disconnectStream
9448 Test: plugins/get-javascript-url.html
9450 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
9451 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just
9454 2010-09-21 Darin Adler <darin@apple.com>
9456 Reviewed by Anders Carlsson.
9458 Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
9459 https://bugs.webkit.org/show_bug.cgi?id=46220
9461 * Misc/WebNSFileManagerExtras.m:
9462 (setMetaData): Use CFRelease instead of HardRelease.
9463 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy
9464 instead of -[NSObject copy] combined with HardRetainWithNSRelease.
9466 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
9468 Reviewed by Kenneth Rohde Christiansen.
9470 PluginStrategy should satisfy the needs of Qt
9471 https://bugs.webkit.org/show_bug.cgi?id=45857
9472 No new functionality so no new tests.
9474 * WebCoreSupport/WebPlatformStrategies.h:
9475 * WebCoreSupport/WebPlatformStrategies.mm:
9476 (WebPlatformStrategies::getPluginInfo):
9478 2010-09-22 Paul Knight <pknight@apple.com>
9480 Reviewed by Simon Fraser.
9482 -[WebView _scheduleCompositingLayerSync] should wake the run loop
9483 https://bugs.webkit.org/show_bug.cgi?id=46226
9485 Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.
9487 * WebView/WebView.mm:
9488 (-[WebView _scheduleCompositingLayerSync]):
9490 2010-09-21 Andy Estes <aestes@apple.com>
9492 Reviewed by Darin Adler.
9494 REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
9495 https://bugs.webkit.org/show_bug.cgi?id=46134
9497 AIM clients linked against versions of WebKit prior to the introduction
9498 of the HTML5 parser contain markup incompatible with the new parser.
9499 Enable parser quirks in this case to remain compatible with these
9502 * WebView/WebView.mm:
9503 (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
9504 application is AIM and was linked against a version of WebKit prior to
9505 the introduction of the HTML5 parser, or if the
9506 WebKitPreHTML5ParserQuirks WebPreference is enabled.
9507 (-[WebView _preferencesChangedNotification:]): Call
9508 WebCore::Settings::setUsePreHTML5ParserQuirks().
9510 2010-09-21 Steve Block <steveblock@google.com>
9512 Reviewed by Jeremy Orlow.
9514 DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
9515 https://bugs.webkit.org/show_bug.cgi?id=45891
9517 Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.
9519 * WebCoreSupport/WebDeviceOrientationClient.h:
9520 * WebCoreSupport/WebDeviceOrientationClient.mm:
9521 (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
9523 2010-09-20 Philippe Normand <pnormand@igalia.com>
9525 Reviewed by Eric Carlson.
9527 [GTK] enhanced context menu for media elements
9528 https://bugs.webkit.org/show_bug.cgi?id=45021
9530 New localized strings for the media element context-menu.
9532 * WebCoreSupport/WebPlatformStrategies.h:
9533 * WebCoreSupport/WebPlatformStrategies.mm:
9534 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
9535 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
9536 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
9537 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
9538 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
9539 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
9540 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
9541 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
9542 (WebPlatformStrategies::contextMenuItemTagMediaPause):
9543 (WebPlatformStrategies::contextMenuItemTagMediaMute):
9545 2010-09-20 Andy Estes <aestes@apple.com>
9547 Reviewed by Adam Barth.
9549 REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
9550 https://bugs.webkit.org/show_bug.cgi?id=40961
9552 Implement WebKitUsePreHTML5ParserQuirks preference.
9554 * WebView/WebPreferenceKeysPrivate.h:
9555 * WebView/WebPreferences.mm:
9556 (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to
9558 (-[WebPreferences usePreHTML5ParserQuirks]):
9559 (-[WebPreferences setUsePreHTML5ParserQuirks:]):
9560 * WebView/WebPreferencesPrivate.h:
9561 * WebView/WebView.mm:
9562 (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings
9563 with the value of WebKitUsePreHTML5ParserQuirks when a preference
9566 2010-09-20 Enrica Casucci <enrica@apple.com>
9568 Reviewed by Sam Weinig.
9570 Pasteboard doesn't work in WebKit2.
9571 https://bugs.webkit.org/show_bug.cgi?id=42317
9572 <rdar://problem/7660537>
9574 Some changes to fix style inconsistencies.
9575 Added OBJC 2.0 style enumeration.
9577 * WebCoreSupport/WebEditorClient.h:
9578 * WebCoreSupport/WebEditorClient.mm:
9579 (WebEditorClient::userVisibleString):
9580 (createExcludedElementsForAttributedStringConversion):
9581 (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
9583 (WebEditorClient::setInsertionPasteboard):
9584 (WebEditorClient::pasteboardTypesForSelection):
9586 2010-09-17 David Hyatt <hyatt@apple.com>
9588 Reviewed by Simon Fraser.
9590 https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
9592 Make printing store the page height in the RenderView and push that into the layout state to
9593 use the new pagination model. The old pagination model is retained because it is still used
9594 for embedded WebViews.
9596 * WebView/WebHTMLView.mm:
9597 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
9599 2010-09-17 Darin Adler <darin@apple.com>
9601 Reviewed by Sam Weinig.
9603 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
9604 https://bugs.webkit.org/show_bug.cgi?id=42863
9606 * WebView/WebView.mm:
9607 (-[WebView _setZoomMultiplier:isTextOnly:]):
9608 Call functions on Frame instead of FrameView.
9610 2010-09-17 Matthew Delaney <mdelaney@apple.com>
9612 Reviewed by Simon Fraser.
9614 Reduce minimum DOMTimer interval
9615 https://bugs.webkit.org/show_bug.cgi?id=45362
9617 * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
9619 2010-09-17 Chris Marrin <cmarrin@apple.com>
9621 Reviewed by Simon Fraser.
9623 Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
9624 https://bugs.webkit.org/show_bug.cgi?id=45911
9626 * WebView/WebPreferenceKeysPrivate.h:
9627 * WebView/WebPreferences.mm:
9628 (+[WebPreferences initialize]):
9629 (-[WebPreferences accelerated2dCanvasEnabled]):
9630 (-[WebPreferences setAccelerated2dCanvasEnabled:]):
9631 * WebView/WebPreferencesPrivate.h:
9632 * WebView/WebView.mm:
9633 (-[WebView _preferencesChangedNotification:]):
9635 2010-09-17 Jia Pu <jpu@apple.com>
9637 Reviewed by Dan Bernstein.
9639 WebKit should use system wide spell checking preference when application specific one isn't set.
9640 https://bugs.webkit.org/show_bug.cgi?id=45789
9641 <rdar://problem/8416041>
9643 * WebView/WebView.mm:
9644 (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
9645 when the application level preferences are not set.
9647 2010-09-16 John Sullivan <sullivan@apple.com>
9649 Reviewed by Darin Adler.
9651 <rdar://problem/8395558>
9652 https://bugs.webkit.org/show_bug.cgi?id=45938
9653 _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
9655 * WebView/WebHTMLView.mm:
9656 (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
9657 Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
9658 was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
9659 this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
9660 before enumerating it, to ensure that the selector can't mutate the array being enumerated.
9661 (-[WebHTMLView viewWillMoveToHostWindow:]):
9662 Updated for _web_makePluginSubviewsPerformSelector:: signature change.
9663 (-[WebHTMLView viewDidMoveToHostWindow]):
9666 2010-09-16 Darin Adler <darin@apple.com>
9668 Reviewed by Andreas Kling.
9670 Reduce use of HTMLInputElement::inputType so we can remove it later
9671 https://bugs.webkit.org/show_bug.cgi?id=45903
9673 * WebView/WebHTMLRepresentation.mm:
9674 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField.
9675 (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
9677 2010-09-16 Patrick Gansterer <paroga@paroga.com>
9679 Reviewed by Darin Adler.
9681 Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
9682 https://bugs.webkit.org/show_bug.cgi?id=41510
9684 This prevents usage of nil value, which would cause an uncaught exception.
9686 * WebView/WebPreferences.mm:
9687 (-[WebPreferences setUserStyleSheetLocation:]):
9689 2010-09-16 Dan Bernstein <mitz@apple.com>
9691 Reverted the previous change because r67628 has been reverted.
9693 * WebCoreSupport/WebPlatformStrategies.h:
9694 * WebCoreSupport/WebPlatformStrategies.mm:
9696 2010-09-16 Dan Bernstein <mitz@apple.com>
9698 Build fix after r67628. Added context menu item localizable strings for the items
9699 added in r67628, following equivalent menu items in Mac OS X when possible. However,
9700 this set of menu items does not make much sense for Mac OS X, and this should be
9701 addressed separately.
9703 * WebCoreSupport/WebPlatformStrategies.h:
9704 * WebCoreSupport/WebPlatformStrategies.mm:
9705 (WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
9706 (WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
9707 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
9708 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
9709 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
9710 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
9711 (WebPlatformStrategies::contextMenuItemTagMediaPause):
9712 (WebPlatformStrategies::contextMenuItemTagMediaMute):
9713 (WebPlatformStrategies::contextMenuItemTagMediaUnMute):
9715 2010-09-16 Eric Uhrhane <ericu@chromium.org>
9717 Reviewed by Jian Li.
9719 Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
9720 https://bugs.webkit.org/show_bug.cgi?id=45798
9722 * Configurations/FeatureDefines.xcconfig:
9724 2010-09-15 Simon Fraser <simon.fraser@apple.com>
9726 Reviewed by Adam Roben.
9728 https://bugs.webkit.org/show_bug.cgi?id=44715
9729 maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
9731 Move geometry flipping to platform-specific code.
9733 * WebView/WebHTMLView.mm:
9734 (-[WebHTMLView attachRootLayer:]):
9736 2010-09-14 Jia Pu <jpu@apple.com>
9738 Reviewed by Dan Bernstein.
9740 Only intercept ESC key press when autocorrection UI is visible.
9741 https://bugs.webkit.org/show_bug.cgi?id=45071
9743 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
9744 which provides an inteface to query whether autocorrection panel is shown.
9746 * WebCoreSupport/WebEditorClient.mm:
9747 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
9748 for invalid correction panel tag. Replaced -1 with this constant.
9749 (WebEditorClient::dismissCorrectionPanel): Ditto
9750 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
9752 2010-09-14 Mark Rowe <mrowe@apple.com>
9754 Reviewed by John Sullivan.
9756 Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.
9758 * Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
9759 * Misc/WebKitVersionChecks.m:
9760 (WebKitLinkedOnOrAfter):
9761 (setWebKitLinkTimeVersion): Set the overridden version.
9762 (WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
9763 * WebView/WebPreferences.mm:
9764 (+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
9765 * WebView/WebPreferencesPrivate.h:
9767 2010-09-14 Eric Seidel <eric@webkit.org>
9769 Unreviewed, reverting changes r67451 and r67451.
9770 Broke lots of builders.
9772 Only intercept ESC key press when autocorrection UI is visible.
9773 https://bugs.webkit.org/show_bug.cgi?id=45071
9775 * WebCoreSupport/WebEditorClient.h:
9776 * WebCoreSupport/WebEditorClient.mm:
9777 (WebEditorClient::WebEditorClient):
9778 (WebEditorClient::dismissCorrectionPanel):
9780 2010-09-14 Jia Pu <jpu@apple.com>
9782 Reviewed by Dan Bernstein.
9784 Only intercept ESC key press when autocorrection UI is visible.
9785 https://bugs.webkit.org/show_bug.cgi?id=45071
9787 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
9788 which provides an inteface to query whether autocorrection panel is shown.
9790 * WebCoreSupport/WebEditorClient.mm:
9791 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
9792 for invalid correction panel tag. Replaced -1 with this constant.
9793 (WebEditorClient::dismissCorrectionPanel): Ditto
9794 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
9796 2010-09-13 Darin Adler <darin@apple.com>
9798 Reviewed by Adam Barth.
9800 Preparation for eliminating deprecatedParseURL
9801 https://bugs.webkit.org/show_bug.cgi?id=45695
9803 * DOM/WebDOMOperations.mm:
9804 (-[DOMDocument webFrame]): Get rid of unneeded local variable.
9805 (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
9807 2010-09-13 Enrica Casucci <enrica@apple.com>
9809 Reviewed by Sam Weinig.
9811 Paste should be implemented in WebCore like Copy and Cut for Mac also.
9812 https://bugs.webkit.org/show_bug.cgi?id=45494
9813 <rdar://problem/7660537>
9815 On the Mac platform, the implementation of the paste operation is all done
9816 at the WebKit level. In order to support it on WebKit2 it is necessary to
9817 refactor the code and move this functionality at the level of WebCore like
9818 we already have on Windows.
9819 The original code relies on some in AppKit functions that call back into
9820 WebKit causing problems in WebKit2. All this functionality has been moved
9821 at the level of the editor client where it can be dealt with appropriately.
9823 * WebCoreSupport/WebEditorClient.h:
9824 * WebCoreSupport/WebEditorClient.mm:
9825 (excludedElementsForAttributedStringConversion):
9826 (WebEditorClient::documentFragmentFromAttributedString): Added.
9827 (WebEditorClient::setInsertionPasteboard):
9828 * WebCoreSupport/WebFrameLoaderClient.h:
9829 * WebCoreSupport/WebFrameLoaderClient.mm:
9830 (WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
9831 of the editor client.
9832 * WebView/WebHTMLView.mm: Removed paste method.
9834 2010-09-13 John Sullivan <sullivan@apple.com>
9836 Reviewed by Adam Roben.
9838 https://bugs.webkit.org/show_bug.cgi?id=45677
9839 [WebView canMarkAllTextMatches] can crash if called after [WebView close]
9841 <rdar://problem/8404890>
9843 * WebView/WebView.mm:
9844 (-[WebView canMarkAllTextMatches]):
9845 Return NO immediately if the webview has already been closed. This was an overlooked
9846 case from the fix for 45175.
9848 2010-09-10 MORITA Hajime <morrita@google.com>
9850 Reviewed by Tony Chang.
9852 [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
9853 https://bugs.webkit.org/show_bug.cgi?id=45441
9855 Moved the actual logic of hasSpellingMarker into WebCore to share
9856 it with other ports.
9858 * WebView/WebFrame.mm:
9859 (-[WebFrame hasSpellingMarker:length:]):
9861 2010-09-11 Adam Barth <abarth@webkit.org>
9863 Reviewed by Sam Weinig.
9865 Make SecurityOrigin::canDisplay an instance function
9866 https://bugs.webkit.org/show_bug.cgi?id=45219
9868 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
9869 (WebKit::NetscapePluginInstanceProxy::loadRequest):
9870 * Plugins/WebNetscapePluginStream.mm:
9871 (WebNetscapePluginStream::WebNetscapePluginStream):
9872 * Plugins/WebNetscapePluginView.mm:
9873 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
9874 * Plugins/WebPluginContainerCheck.mm:
9875 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
9876 * WebView/WebFrame.mm:
9877 (-[WebFrame _allowsFollowingLink:]):
9879 2010-09-10 Sam Weinig <sam@webkit.org>
9881 Reviewed by Darin Adler.
9883 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
9884 Precursor to <rdar://problem/7660657>
9885 https://bugs.webkit.org/show_bug.cgi?id=45522
9887 * WebView/WebView.mm:
9888 (-[WebView _preferencesChangedNotification:]):
9889 (-[WebView _setZoomMultiplier:isTextOnly:]):
9890 (-[WebView _realZoomMultiplierIsTextOnly]):
9891 * WebView/WebViewData.h:
9892 * WebView/WebViewData.mm:
9893 (-[WebViewPrivate init]):
9894 Move tracking of text only zoom here from WebCore.
9896 2010-09-10 Stephanie Lewis <slewis@apple.com>
9898 Reviewed by Alexey Proskuryakov.
9900 Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
9901 other implementation details of JavaScriptCore. Necessary to fix PPC build.
9903 https://bugs.webkit.org/show_bug.cgi?id=45528
9905 * Misc/WebCoreStatistics.mm:
9906 (+[WebCoreStatistics memoryStatistics]):
9908 2010-09-10 Darin Adler <darin@apple.com>
9910 Reviewed by Sam Weinig.
9912 Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
9913 https://bugs.webkit.org/show_bug.cgi?id=45582
9915 * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
9917 * WebCoreSupport/WebChromeClient.mm:
9918 (WebChromeClient::dashboardRegionsChanged): Changed this to call
9919 -[WebView _dashboardRegions] so we don't have two copies of that code.
9921 * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
9922 * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
9924 * WebView/WebView.mm:
9925 (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
9927 2010-09-10 Adam Barth <abarth@webkit.org>
9929 Reviewed by Darin Fisher.
9931 Move code from WebKit-layer to DocumentLoader
9932 https://bugs.webkit.org/show_bug.cgi?id=45569
9934 This code is the most confused, but now should be a bit cleaner.
9935 There's still a magical fake-setting for creating renderers that needs
9936 to be cleaned up, but we can do that in a separate patch.
9938 * WebView/WebFrame.mm:
9939 (-[WebFrame _commitData:]):
9940 * WebView/WebFrameInternal.h:
9941 * WebView/WebHTMLRepresentation.mm:
9942 (-[WebHTMLRepresentation receivedData:withDataSource:]):
9943 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
9945 2010-09-09 Darin Adler <darin@apple.com>
9947 Reviewed by Adam Barth.
9949 Move functions from Frame to SelectionController as planned
9950 https://bugs.webkit.org/show_bug.cgi?id=45508
9952 * WebView/WebFrame.mm:
9953 (-[WebFrame _selectionGranularity]):
9954 (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
9955 (-[WebFrame _typingStyle]):
9956 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
9957 * WebView/WebHTMLRepresentation.mm:
9958 (-[WebHTMLRepresentation currentForm]):
9959 * WebView/WebHTMLView.mm:
9960 (-[WebHTMLView jumpToSelection:]):
9961 (-[WebHTMLView centerSelectionInVisibleArea:]):
9962 (-[WebHTMLView _canSmartCopyOrDelete]):
9963 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
9964 (-[WebHTMLView selectionRect]):
9965 (-[WebHTMLView selectionTextRects]):
9966 (-[WebHTMLView selectionImageRect]):
9967 * WebView/WebView.mm:
9968 (-[WebView setEditable:]):
9969 Call functions on selection().
9971 2010-09-10 Adam Barth <abarth@webkit.org>
9973 Reviewed by Eric Seidel.
9975 Main resource bytes shouldn't bounce through FrameLoader
9976 https://bugs.webkit.org/show_bug.cgi?id=45496
9978 Now return the bytes to the DocumentLoader.
9980 Previously, we were checking the document for null. However, Frame can
9981 never have a null document, so this check is no longer needed.
9983 * WebView/WebFrame.mm:
9984 (-[WebFrame _addData:]):
9986 2010-09-09 John Therrell <jtherrell@apple.com>
9988 Reviewed by Alexey Proskuryakov.
9990 Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes
9991 https://bugs.webkit.org/show_bug.cgi?id=45134
9993 Added ability to enable new JavaScriptCore statistics sampling and reporting for RegisterFile
9994 and ExecutableAllocator classes. Added reporting of JavaScriptCore's stack committed memory
9995 and JIT code committed memory statistics to WebCoreStatistics memoryStatistics.
9997 * Misc/WebCoreStatistics.mm:
9998 (+[WebCoreStatistics memoryStatistics]):
9999 Added statistics reporting for JSC RegisterFile and ExecutableAllocator.
10001 2010-09-09 Jer Noble <jer.noble@apple.com>
10003 Reviewed by Mark Rowe.
10005 Use of ENABLE macro in WebUIDelegatePrivate.h breaks use from outside WebKit
10006 <rdar://problem/8412657>
10008 * WebView/WebUIDelegatePrivate.h: Use ENABLE_FULLSCREEN_API instead of ENABLE(FULLSCREEN_API)
10010 2010-09-08 Darin Adler <darin@apple.com>
10012 Reviewed by Adam Barth.
10014 Move functions from Frame to Editor as planned
10015 https://bugs.webkit.org/show_bug.cgi?id=45218
10017 * WebView/WebFrame.mm:
10018 (-[WebFrame _selectedString]):
10019 (-[WebFrame _firstRectForDOMRange:]):
10020 (-[WebFrame _markDOMRange]):
10021 (-[WebFrame _setTypingStyle:withUndoAction:]):
10022 * WebView/WebHTMLRepresentation.mm:
10023 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
10024 * WebView/WebHTMLView.mm:
10025 (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
10026 (-[WebHTMLView toggleBaseWritingDirection:]):
10027 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
10028 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
10029 (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
10030 (-[WebHTMLView markedTextMatchesAreHighlighted]):
10031 * WebView/WebView.mm:
10032 (-[WebView setEditable:]):
10033 Changed call sites to use editor().
10035 2010-09-08 MORITA Hajime <morrita@google.com>
10037 Reviewed by Ojan Vafai.
10039 spellcheck does not check pasted text
10040 https://bugs.webkit.org/show_bug.cgi?id=40092
10042 Implemented async spell-check APIs on WebEditorClient.
10043 The implementations are using [NSSpellChecker requestCheckingOfString]
10044 which is available only on Mac OS 10.6 or later.
10046 Note that [NSSpellChecker requestCheckingOfString] could invoke
10047 the callback block on on of their worker thread, so we need to
10048 return the result to the main thread where WebCore is running.
10049 For that purpose, we made WebEditorSpellCheckResponder class.
10051 Test: editing/spelling/spellcheck-pasted-text-001.html
10053 * WebCoreSupport/WebEditorClient.h:
10054 * WebCoreSupport/WebEditorClient.mm:
10055 (WebEditorClient::isAsynchronousSpellCheckingEnabled): Added.
10056 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): Added.
10057 (-[WebEditorSpellCheckResponder perform]): Added.
10058 (WebEditorClient::requestCheckingOfString): Added.
10059 * WebView/WebFramePrivate.h:
10061 2010-09-08 MORITA Hajime <morrita@google.com>
10063 Reviewed by Tony Chang.
10065 spelling underline gets lost on backspace
10066 https://bugs.webkit.org/show_bug.cgi?id=41423
10068 Switched to use a anchorNode of the selection instead of a focused
10069 node for finer control of node selection in spellingNode():
10070 With the focused node, we cannot select other nodes but the first
10071 child of that node. In some case, we need to inspect these.
10073 The API is only for LayoutTests, and the change is compatible for
10074 existing test cases.
10076 * WebView/WebFrame.mm:
10079 2010-09-08 Adam Barth <abarth@webkit.org>
10081 Rubber-stamped by Eric Seidel.
10083 Rename DocLoader to CachedResourceLoader because that's what it does.
10085 * WebView/WebFrame.mm:
10087 2010-09-07 Anders Carlsson <andersca@apple.com>
10089 Reviewed by Oliver Hunt.
10093 * Misc/WebLocalizableStrings.h:
10094 Fix a struct/tag mismatch.
10096 * WebView/WebDeviceOrientationProviderMock.mm:
10097 (-[WebDeviceOrientationProviderMock init]):
10098 Remove stray semicolon.
10100 * WebView/WebViewData.h:
10101 Remove unused class forward declaration.
10103 2010-09-07 Anders Carlsson <andersca@apple.com>
10105 Reviewed by Darin Adler.
10107 <rdar://problem/8381749> -Wcast-align warning emitted when building with clang
10109 Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
10111 * Configurations/Base.xcconfig:
10113 2010-09-06 Adam Barth <abarth@webkit.org>
10115 Reviewed by Darin Adler.
10117 Rename SecurityOrigin::canLoad to canDisplay
10118 https://bugs.webkit.org/show_bug.cgi?id=45214
10120 Propagate name change.
10122 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
10123 (WebKit::NetscapePluginInstanceProxy::loadRequest):
10124 * Plugins/WebNetscapePluginStream.mm:
10125 (WebNetscapePluginStream::WebNetscapePluginStream):
10126 * Plugins/WebNetscapePluginView.mm:
10127 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
10128 * Plugins/WebPluginContainerCheck.mm:
10129 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
10130 * WebView/WebFrame.mm:
10131 (-[WebFrame _allowsFollowingLink:]):
10133 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
10135 Reviewed by Darin Adler.
10137 Add NetworkingContext to avoid layer violations
10138 https://bugs.webkit.org/show_bug.cgi?id=42292
10140 Add Mac's specific implementation of FrameNetworkingContext.
10142 * WebCoreSupport/WebFrameLoaderClient.h:
10143 * WebCoreSupport/WebFrameLoaderClient.mm:
10144 * WebCoreSupport/WebFrameNetworkingContext.mm:
10145 (WebFrameNetworkingContext::needsSiteSpecificQuirks):
10146 (WebFrameNetworkingContext::localFileContentSniffingEnabled):
10147 (WebFrameNetworkingContext::scheduledRunLoopPairs):
10148 (WebFrameNetworkingContext::blockedError):
10150 2010-09-03 John Sullivan <sullivan@apple.com>
10152 Reviewed by Dan Bernstein.
10154 https://bugs.webkit.org/show_bug.cgi?id=45175
10155 [WebView unmarkAllTextMatches] will crash if the webview is already closed
10157 Made this and related methods robust against being called when the WebView is closed.
10159 * WebView/WebView.mm:
10160 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
10161 Bail out if the WebView is closed.
10162 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
10164 (-[WebView unmarkAllTextMatches]):
10166 (-[WebView rectsForTextMatches]):
10169 2010-09-03 Hironori Bono <hbono@chromium.org>
10171 Reviewed by Kent Tamura.
10173 Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
10174 and implements it for Mac.
10175 https://bugs.webkit.org/show_bug.cgi?id=41832
10177 * WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:].
10179 (-[WebFrame hasSpellingMarker:length:]):
10180 * WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it.
10182 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
10184 Reviewed by Pavel Feldman.
10186 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
10187 https://bugs.webkit.org/show_bug.cgi?id=44230
10189 * WebCoreSupport/WebInspectorClient.h:
10190 * WebCoreSupport/WebInspectorClient.mm:
10191 (WebInspectorFrontendClient::closeWindow):
10192 (WebInspectorFrontendClient::disconnectFromBackend):
10193 (-[WebInspectorWindowController windowShouldClose:]):
10194 (-[WebInspectorWindowController destroyInspectorView:]):
10196 2010-09-02 Steve Block <steveblock@google.com>
10198 Reviewed by Adam Barth.
10200 Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
10201 https://bugs.webkit.org/show_bug.cgi?id=43181
10203 This patch hooks up the mock device orientation client on Mac for use
10206 The patch adds a new WebDeviceOrientationClient for Mac. This client acts
10207 as a proxy to either a real or mock device orientation provider, both of
10208 which implement a new WebDeviceOrientationProvider interface.
10210 The provider is created by the embedder and passed to the WebView, from
10211 where WebDeviceOrientationClient can access it.
10213 The mock provider, WebDeviceOrientationProviderMock, is a wrapper around
10214 the existing WebCore mock.
10216 * WebCoreSupport/WebDeviceOrientationClient.h: Added.
10217 * WebCoreSupport/WebDeviceOrientationClient.mm: Added.
10218 (WebDeviceOrientationClient::WebDeviceOrientationClient):
10219 (WebDeviceOrientationClient::setController):
10220 (WebDeviceOrientationClient::startUpdating):
10221 (WebDeviceOrientationClient::stopUpdating):
10222 (WebDeviceOrientationClient::lastOrientation):
10224 * WebView/WebDeviceOrientation.h: Added.
10225 * WebView/WebDeviceOrientation.mm: Added.
10226 (-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]):
10228 (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
10229 (-[WebDeviceOrientation dealloc]):
10230 * WebView/WebDeviceOrientationInternal.h: Added.
10231 * WebView/WebDeviceOrientationProvider.h: Added.
10232 * WebView/WebDeviceOrientationProviderMock.h: Added.
10233 * WebView/WebDeviceOrientationProviderMock.mm: Added.
10234 (-[WebDeviceOrientationProviderMockInternal setOrientation:]):
10235 (-[WebDeviceOrientationProviderMockInternal setController:]):
10236 (-[WebDeviceOrientationProviderMockInternal startUpdating]):
10237 (-[WebDeviceOrientationProviderMockInternal stopUpdating]):
10238 (-[WebDeviceOrientationProviderMockInternal lastOrientation]):
10239 (-[WebDeviceOrientationProviderMock init]):
10240 (-[WebDeviceOrientationProviderMock dealloc]):
10241 (-[WebDeviceOrientationProviderMock setOrientation:]):
10242 (-[WebDeviceOrientationProviderMock setController:]):
10243 (-[WebDeviceOrientationProviderMock startUpdating]):
10244 (-[WebDeviceOrientationProviderMock stopUpdating]):
10245 (-[WebDeviceOrientationProviderMock lastOrientation]):
10246 * WebView/WebDeviceOrientationProviderMockInternal.h: Added.
10247 * WebView/WebView.mm:
10248 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
10249 (-[WebView _setDeviceOrientationProvider:]):
10250 (-[WebView _deviceOrientationProvider]):
10251 * WebView/WebViewData.h:
10252 * WebView/WebViewPrivate.h:
10254 2010-09-01 Jia Pu <jpu@apple.com>
10256 Reviewed by Dan Bernstein.
10258 Add support for autocorrection UI on Mac OS X.
10259 https://bugs.webkit.org/show_bug.cgi?id=44958
10260 <rdar://problem/7326847>
10262 See detailed high level description in WebCore/ChangeLog.
10264 * WebCoreSupport/WebEditorClient.h: Added new member methods declared in
10265 EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object.
10267 * WebCoreSupport/WebEditorClient.mm:
10268 (WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag.
10269 (WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is
10270 dismissed before destroying the object.
10271 (WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes.
10272 (WebEditorClient::showCorrectionPanel): Show autocorrection UI.
10273 (WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI.
10275 2010-09-01 Mark Rowe <mrowe@apple.com>
10277 Reviewed by Adam Roben.
10279 <rdar://problem/8374711> WebKit needs to compile without access to QuickDraw private headers.
10281 * Carbon/HIViewAdapter.m:
10282 * Carbon/HIWebView.mm:
10283 * Misc/QuickDrawCompatibility.h: Added.
10284 * Plugins/WebNetscapePluginView.mm:
10286 2010-08-31 Dave Hyatt <hyatt@apple.com>
10288 Reviewed by Sam Weinig.
10290 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
10291 the former can occur in more places without having to do the latter.
10293 Eliminate Mac-specific code for style re-application and recursive layout/style updating in
10294 favor of the cross-platform code that all the other ports use.
10296 * Carbon/HIWebView.mm:
10298 * WebCoreSupport/WebFrameLoaderClient.mm:
10299 (WebFrameLoaderClient::forceLayout):
10300 * WebView/WebHTMLView.mm:
10301 (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
10302 (-[WebHTMLView viewWillDraw]):
10303 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
10304 (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
10305 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
10306 (-[WebHTMLView reapplyStyles]):
10307 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
10308 (-[WebHTMLView setNeedsToApplyStyles:]):
10309 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
10310 (-[WebHTMLView _layoutIfNeeded]):
10311 (-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):
10312 * WebView/WebHTMLViewInternal.h:
10313 * WebView/WebView.mm:
10314 (-[WebView _viewWillDrawInternal]):
10316 2010-08-31 Sam Weinig <sam@webkit.org>
10318 Reviewed by Darin Adler.
10320 Add ability to count text matches without marking
10321 https://bugs.webkit.org/show_bug.cgi?id=43996
10323 Safari needs to be able to count text matches without triggering lots of repainting.
10324 Rename markAllMatchesForText: to countMatchesForText: and add a markMatches:
10325 parameter. For backwards compatibility markAllMatchesForText: calls
10326 countMatchesForText: and passes YES for markMatches:.
10328 * WebView/WebDocumentInternal.h:
10329 * WebView/WebHTMLView.mm:
10330 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
10331 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
10332 * WebView/WebPDFView.mm:
10333 (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
10334 (-[WebPDFView countMatchesForText:caseSensitive:limit:markMatches:]):
10335 * WebView/WebView.mm:
10336 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
10337 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
10338 * WebView/WebViewPrivate.h:
10340 2010-08-31 Darin Adler <darin@apple.com>
10342 Reviewed by Anders Carlsson.
10344 * WebInspector/WebInspectorFrontend.mm:
10345 (-[WebInspectorFrontend initWithFrontendClient:]): Remove a stray semicolon.
10347 2010-08-30 Mark Rowe <mrowe@apple.com>
10349 Reviewed by Darin Adler.
10351 <rdar://problem/8369736> WebKit build fails.
10353 Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed.
10355 * Carbon/HIViewAdapter.m:
10356 * Carbon/HIWebView.mm:
10357 * Plugins/WebNetscapePluginView.mm:
10359 2010-08-30 Andy Estes <aestes@apple.com>
10361 Reviewed by Darin Adler.
10363 REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in.
10364 https://bugs.webkit.org/show_bug.cgi?id=44865
10366 After http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in
10367 for authentication fail to log in. This is due to a bug in AppleConnect that r66156
10368 exposed, but since this will have a significant impact on users of WebKit nightly
10369 builds, a plugin-specific hack should be added while the underlying issue is being
10372 * WebCoreSupport/WebFrameLoaderClient.mm:
10373 (WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase
10374 if the plugin is of type 'application/x-snkp'.
10376 2010-08-27 Jer Noble <jer.noble@apple.com>
10378 Reviewed by Eric Carlson.
10380 text/plain non-video files cause <video> to hang (while reading them?)
10381 https://bugs.webkit.org/show_bug.cgi?id=44212
10383 Add the new WebKitSystemInterface function WKQTMovieDisableComponent to
10384 the initialization routine.
10386 * WebCoreSupport/WebSystemInterface.mm:
10387 (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent.
10389 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
10391 Unreviewed, rolling out r66198.
10392 http://trac.webkit.org/changeset/66198
10393 https://bugs.webkit.org/show_bug.cgi?id=44856
10395 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
10397 * WebCoreSupport/WebInspectorClient.h:
10398 * WebCoreSupport/WebInspectorClient.mm:
10399 (WebInspectorFrontendClient::closeWindow):
10400 (-[WebInspectorWindowController windowShouldClose:]):
10401 (-[WebInspectorWindowController destroyInspectorView]):
10403 2010-08-28 Darin Adler <darin@apple.com>
10405 Reviewed by Sam Weinig.
10407 Make an internal method used by Apple Mail into SPI
10408 https://bugs.webkit.org/show_bug.cgi?id=44832
10409 rdar://problem/5748951
10411 * WebView/WebFrame.mm:
10412 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
10413 from the internal section to the private section.
10414 * WebView/WebFrameInternal.h: Moved the method declaration out of here.
10415 * WebView/WebFramePrivate.h: Moved the method declaration in here.
10417 2010-08-27 Jer Noble <jer.noble@apple.com>
10419 Reviewed by Eric Carlson.
10421 Add JavaScript API to allow a page to go fullscreen.
10422 rdar://problem/6867795
10424 Added chrome client overrides which support entering and exiting full screen. A new preference has
10425 been added (setFullScreenEnabled:) to control at runtime whether full screen support is enabled
10426 (defaults to disabled). Added a new WebKitFullScreenListener callback object which notifies WebCore
10427 when the chrome has started/finished its full screen animation.
10429 * Configurations/FeatureDefines.xcconfig:
10430 * WebCoreSupport/WebChromeClient.h:
10431 * WebCoreSupport/WebChromeClient.mm:
10432 (WebChromeClient::supportsFullscreenForElement):
10433 (WebChromeClient::enterFullscreenForElement):
10434 (WebChromeClient::exitFullscreenForElement):
10435 (-[WebKitFullScreenListener initWithElement:]):
10436 (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
10437 (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
10438 (-[WebKitFullScreenListener webkitWillExitFullScreen]):
10439 (-[WebKitFullScreenListener webkitDidExitFullScreen]):
10440 * WebView/WebPreferenceKeysPrivate.h:
10441 * WebView/WebPreferences.h:
10442 * WebView/WebPreferences.mm:
10443 (+[WebPreferences initialize]):
10444 (-[WebPreferences setFullScreenEnabled:]):
10445 (-[WebPreferences fullScreenEnabled]):
10446 * WebView/WebUIDelegatePrivate.h:
10447 * WebView/WebView.mm:
10448 (-[WebView _preferencesChangedNotification:]):
10450 2010-08-27 David Hyatt <hyatt@apple.com>
10452 Reviewed by Simon Fraser.
10454 https://bugs.webkit.org/show_bug.cgi?id=44788, implement HTML5-compliant doctype switching.
10456 Rename the various modes to match the HTML5 specification:
10457 ParseMode -> CompatibilityMode
10458 CompatMode -> QuirksMode
10459 AlmostStrictMode -> LimitedQuirksMode
10460 StrictMode -> NoQuirksMode
10462 Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
10463 instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.
10465 Clean up user stylesheets to minimize style recalculation when the mode is switched.
10467 Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
10468 dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
10469 Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
10472 determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
10475 * WebView/WebView.mm:
10476 (-[WebView _preferencesChangedNotification:]):
10478 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
10480 Reviewed by Pavel Feldman.
10482 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
10483 https://bugs.webkit.org/show_bug.cgi?id=44230
10485 * WebCoreSupport/WebInspectorClient.h:
10486 * WebCoreSupport/WebInspectorClient.mm:
10487 (WebInspectorFrontendClient::closeWindow):
10488 (WebInspectorFrontendClient::disconnectFromBackend):
10489 (-[WebInspectorWindowController windowShouldClose:]):
10490 (-[WebInspectorWindowController destroyInspectorView:]):
10492 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
10494 Unreviewed. Revert r66103 since Qt tests are failing.
10496 * WebCoreSupport/WebInspectorClient.h:
10497 * WebCoreSupport/WebInspectorClient.mm:
10498 (WebInspectorFrontendClient::closeWindow):
10499 (-[WebInspectorWindowController windowShouldClose:]):
10500 (-[WebInspectorWindowController destroyInspectorView]):
10502 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
10504 Reviewed by Pavel Feldman.
10506 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
10507 https://bugs.webkit.org/show_bug.cgi?id=44230
10509 * WebCoreSupport/WebInspectorClient.h:
10510 * WebCoreSupport/WebInspectorClient.mm:
10511 (WebInspectorFrontendClient::closeWindow):
10512 (WebInspectorFrontendClient::disconnectFromBackend):
10513 (-[WebInspectorWindowController windowShouldClose:]):
10514 (-[WebInspectorWindowController destroyInspectorView:]):
10516 2010-08-24 Eric Seidel <eric@webkit.org>
10518 Reviewed by Adam Barth.
10520 Remove HTML5 parser testing infrastructure now that we don't need it
10521 https://bugs.webkit.org/show_bug.cgi?id=44581
10523 * WebView/WebPreferenceKeysPrivate.h:
10524 * WebView/WebPreferences.mm:
10525 (+[WebPreferences initialize]):
10526 * WebView/WebPreferencesPrivate.h:
10527 * WebView/WebView.mm:
10528 (-[WebView _preferencesChangedNotification:]):
10530 2010-08-24 Sam Weinig <sam@webkit.org>
10532 Reviewed by Oliver Hunt.
10534 Paste event fires twice for mac WebKit
10535 <rdar://problem/8094611>
10536 https://bugs.webkit.org/show_bug.cgi?id=44535
10538 The mac implementation of paste in WebKit was accidentally calling
10539 Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
10540 in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
10541 Use the new pasteAsPlainTextBypassingDHTML function to bypass the
10544 * WebView/WebHTMLView.mm:
10545 (-[WebHTMLView paste:]):
10547 2010-08-24 Daniel Cheng <dcheng@chromium.org>
10549 Reviewed by Eric Seidel.
10551 [chromium] Generate drag images for HTML elements and selections.
10552 https://bugs.webkit.org/show_bug.cgi?id=43449
10554 Fix up calls to Frame::nodeImage, which has a new signature.
10556 * Plugins/WebBaseNetscapePluginView.mm:
10557 (-[WebBaseNetscapePluginView halt]):
10559 2010-08-23 Mike Thole <mthole@apple.com>
10561 Reviewed by Dan Bernstein.
10563 WebPDFView should remove itself as the delegate of its PDFView before being dealloced
10564 https://bugs.webkit.org/show_bug.cgi?id=44441
10566 * WebView/WebPDFView.mm:
10567 (-[WebPDFView dealloc]): Set the PDFView's delegate to nil.
10569 2010-08-22 Daniel Bates <dbates@rim.com>
10571 Reviewed by Eric Seidel.
10573 Encapsulate document marker management into DocumentMarkerController
10574 https://bugs.webkit.org/show_bug.cgi?id=44383
10576 Modify call sites in the Apple Mac port to use DocumentMarkerController.
10578 No functionality was changed, so no new tests.
10580 * WebView/WebFrame.mm:
10581 (-[WebFrame _unmarkAllBadGrammar]):
10582 (-[WebFrame _unmarkAllMisspellings]):
10583 * WebView/WebHTMLView.mm:
10584 (-[WebHTMLView unmarkAllTextMatches]):
10585 (-[WebHTMLView rectsForTextMatches]):
10587 2010-08-19 David Kilzer <ddkilzer@apple.com>
10589 <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
10591 Reviewed by Joseph Pecoraro.
10593 * Plugins/Hosted/HostedNetscapePluginStream.mm: Changed
10594 USE(PLUGIN_HOST_PROCESS) to
10595 USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API).
10596 * Plugins/Hosted/NetscapePluginHostManager.mm: Ditto.
10597 * Plugins/Hosted/NetscapePluginHostProxy.mm: Ditto.
10598 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Ditto.
10599 * Plugins/Hosted/ProxyInstance.mm: Ditto.
10600 * Plugins/Hosted/WebHostedNetscapePluginView.mm: Ditto.
10601 * WebCoreSupport/WebChromeClient.mm: Ditto.
10602 (WebChromeClient::createWindow):
10603 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
10604 (WebFrameLoaderClient::dispatchCreatePage):
10605 * WebView/WebHTMLView.mm:
10606 (needsCursorRectsSupportAtPoint): Added #if
10607 ENABLE(NETSCAPE_PLUGIN_API) and #endif macros as needed.
10608 * WebView/WebView.mm:
10609 (+[WebView _isNodeHaltedPlugin:]): Ditto.
10610 (+[WebView _hasPluginForNodeBeenHalted:]): Ditto.
10611 (+[WebView _restartHaltedPluginForNode:]): Ditto.
10613 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
10615 Reviewed by Darin Adler.
10617 Add NetworkingContext to avoid layer violations
10618 https://bugs.webkit.org/show_bug.cgi?id=42292
10620 Preparation: Just add the files to the build system.
10622 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
10623 Placeholder with tentative code that might be changed when landing
10625 * WebCoreSupport/WebFrameNetworkingContext.mm: Added.
10626 Empty placeholder for now.
10628 2010-08-17 Brady Eidson <beidson@apple.com>
10630 Reviewed by Sam Weinig.
10632 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
10633 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
10635 * WebView/WebView.mm:
10636 (-[WebView canGoBack]): Return false if loads are deferred.
10637 (-[WebView canGoForward]): Ditto.
10639 2010-08-14 Joseph Pecoraro <joepeck@webkit.org>
10641 Reviewed by Pavel Feldman.
10643 Web Inspector: -[WebInspector attach] and detach should work
10644 https://bugs.webkit.org/show_bug.cgi?id=43924
10646 For actions that relate only to the Web Inspector's Frontend
10647 window (actions on the InspectorFrontendClient) the new Obj-C
10648 wrapper class WebInspectorFrontend can be used. For now, this
10649 is just attach and detach.
10651 * WebCoreSupport/WebInspectorClient.mm:
10652 (WebInspectorClient::openInspectorFrontend): setup and attach the WebInspectorFrontend to the WebInspector.
10653 * WebInspector/WebInspector.h:
10654 * WebInspector/WebInspector.mm:
10655 (-[WebInspector dealloc]):
10656 (-[WebInspector attach:]): delegate to the frontend.
10657 (-[WebInspector detach:]): delegate to the frontend.
10658 (-[WebInspector setFrontend:]):
10659 * WebInspector/WebInspectorFrontend.h: Added.
10660 * WebInspector/WebInspectorFrontend.mm: Added.
10661 (-[WebInspectorFrontend initWithFrontendClient:]):
10662 (-[WebInspectorFrontend attach]):
10663 (-[WebInspectorFrontend detach]):
10664 * WebInspector/WebInspectorPrivate.h:
10666 2010-08-13 Gavin Barraclough <barraclough@apple.com>
10668 Rubber stamped by Sam Weinig.
10669 Switch String::/UString::ascii() to return a CString.
10671 * Plugins/Hosted/ProxyInstance.mm:
10672 (WebKit::ProxyInstance::methodsNamed):
10673 (WebKit::ProxyInstance::fieldNamed):
10675 2010-08-13 Gavin Barraclough <barraclough@apple.com>
10677 Reviewed by Sam Weinig
10679 Unify UString::UTF8String() & String::utf8() methods,
10680 remove UString::cost() & make atArrayIndex a free function.
10682 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
10683 (WebKit::NetscapePluginInstanceProxy::enumerate):
10685 2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
10687 Unreviewed, rolling out r65295.
10688 http://trac.webkit.org/changeset/65295
10689 https://bugs.webkit.org/show_bug.cgi?id=43950
10691 It broke 4 sputnik tests (Requested by Ossy on #webkit).
10693 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
10694 (WebKit::NetscapePluginInstanceProxy::enumerate):
10696 2010-08-12 Gavin Barraclough <barraclough@apple.com>
10698 Reviewed by Sam Weinig
10700 Unify UString::UTF8String() & String::utf8() methods,
10701 remove UString::cost() & make atArrayIndex a free function.
10703 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
10704 (WebKit::NetscapePluginInstanceProxy::enumerate):
10706 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
10709 https://bugs.webkit.org/show_bug.cgi?id=43794
10711 * WebView/WebView.mm:
10712 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
10713 (-[WebView _preferencesChangedNotification:]):
10715 2010-08-10 Jeremy Orlow <jorlow@chromium.org>
10717 Reviewed by Adam Barth.
10719 Some settings are linked to the PageGroup not the Page. Create a new class for those.
10720 https://bugs.webkit.org/show_bug.cgi?id=43794
10722 Change WebView to use the new GroupSettings class rather than Settings for the
10723 settings that moved. This is sub-optimal since the settings aren't really
10724 per-view, but we can't really change the API at this point.
10726 * WebView/WebView.mm:
10727 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
10728 (-[WebView _preferencesChangedNotification:]):
10730 2010-08-11 Gavin Barraclough <barraclough@apple.com>
10732 Rubber stamps by Darin Adler & Sam Weinig.
10734 Bug 43867 - Some UString cleanup
10736 Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
10737 Move string concatenation methods to a new header to simplify down UString.h. Remove is8Bit().
10739 * WebView/WebScriptDebugger.mm:
10742 2010-08-10 David Hyatt <hyatt@apple.com>
10744 Reviewed by Dan Bernstein.
10746 https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.
10748 Add SPI for entering and exiting screen pagination mode. This is similar to printing mode but it can be done for on-screen
10751 * WebView/WebHTMLView.mm:
10752 (-[WebHTMLView _web_setPrintingModeRecursive]):
10753 (-[WebHTMLView _web_clearPrintingModeRecursive]):
10754 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
10755 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
10756 (-[WebHTMLView _endPrintMode]):
10757 (-[WebHTMLView _isInScreenPaginationMode]):
10758 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
10759 (-[WebHTMLView _endScreenPaginationMode]):
10760 (-[WebHTMLView reapplyStyles]):
10761 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
10762 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
10763 (-[WebHTMLView setPageWidthForPrinting:]):
10764 * WebView/WebHTMLViewPrivate.h:
10766 2010-08-10 Gavin Barraclough <barraclough@apple.com>
10768 Build fix (update more includes)
10770 * Plugins/Hosted/NetscapePluginHostManager.h:
10772 2010-08-10 Chris Marrin <cmarrin@apple.com>
10774 Reviewed by Oliver Hunt.
10776 Add suspendAnimations/resumeAnimation API to DRT
10777 https://bugs.webkit.org/show_bug.cgi?id=43733
10779 Mac specific API. Plumbs suspendAnimations/resumeAnimations down to WebCore.
10781 * WebView/WebFrame.mm:
10782 (-[WebFrame _suspendAnimations]):
10783 (-[WebFrame _resumeAnimations]):
10784 * WebView/WebFramePrivate.h:
10786 2010-08-10 Gavin Barraclough <barraclough@apple.com>
10788 Rubber stamped by Sam Weinig
10790 Bug 43817 - Remove UString::Rep
10791 UString::Rep has for a long time been replaced by UStringImpl (Rep
10792 remaining as a typedef). UStringImpl has since been removed too
10793 (unified with StringImpl). Remove Rep, rename rep() to impl() and
10794 m_rep to m_impl. Also add impl() method to Identifier, and rename
10795 its UString member from _ustring to m_string.
10797 * Plugins/Hosted/ProxyInstance.mm:
10798 (WebKit::ProxyInstance::methodsNamed):
10799 (WebKit::ProxyInstance::fieldNamed):
10801 2010-08-06 Gavin Barraclough <barraclough@apple.com>
10803 Rubber stamped by Sam Weinig
10805 Bug 43594 - Add string forwards to Forward.h
10806 This allows us to remove forward declarations for these classes from
10807 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
10809 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
10810 * Plugins/WebBaseNetscapePluginView.h:
10811 * WebCoreSupport/WebFrameLoaderClient.h:
10812 * WebCoreSupport/WebIconDatabaseClient.h:
10813 * WebCoreSupport/WebPluginHalterClient.h:
10814 * WebView/WebViewInternal.h:
10816 2010-08-04 MORITA Hajime <morrita@google.com>
10818 Reviewed by Tony Chang.
10820 Pasting should fire textInput event.
10821 https://bugs.webkit.org/show_bug.cgi?id=42958
10823 On paste, invoke Editor instead of direct command invocation,
10824 which allows dispatching events before actual paste.
10826 * WebView/WebHTMLView.mm:
10827 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
10829 2010-08-06 Yongjun Zhang <yongjun_zhang@apple.com>
10831 Reviewed by Eric Seidel.
10833 add "const" to WebChromeClient::webView().
10834 https://bugs.webkit.org/show_bug.cgi?id=43631
10836 Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments
10837 is const method now, and calling webView() inside port-specific didReceiveViewportArguments
10838 implementation fails compiling if webView() is not const.
10840 * WebCoreSupport/WebChromeClient.h:
10841 (WebChromeClient::webView):
10843 2010-08-06 Jessie Berlin <jberlin@apple.com>
10845 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
10848 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
10849 * Plugins/WebBaseNetscapePluginView.h:
10850 * WebCoreSupport/WebFrameLoaderClient.h:
10851 * WebCoreSupport/WebIconDatabaseClient.h:
10852 * WebCoreSupport/WebPluginHalterClient.h:
10853 * WebView/WebViewInternal.h:
10855 2010-08-05 Joseph Pecoraro <joepeck@webkit.org>
10857 Reviewed by David Kilzer.
10859 Remove Invalid Asserts for Application Cache Quotas
10860 https://bugs.webkit.org/show_bug.cgi?id=43585
10862 Removed Invalid ASSERTs that would always happen for quotas
10863 that were not noQuota().
10865 * WebView/WebPreferences.mm:
10866 (-[WebPreferences applicationCacheTotalQuota]):
10867 (-[WebPreferences applicationCacheDefaultOriginQuota]):
10869 2010-08-05 Gavin Barraclough <barraclough@apple.com>
10871 Rubber stamped by Sam Weinig
10873 Bug 43594 - Add string forwards to Forward.h
10874 This allows us to remove forward declarations for these classes from
10875 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
10877 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
10878 * Plugins/WebBaseNetscapePluginView.h:
10879 * WebCoreSupport/WebFrameLoaderClient.h:
10880 * WebCoreSupport/WebIconDatabaseClient.h:
10881 * WebCoreSupport/WebPluginHalterClient.h:
10882 * WebView/WebViewInternal.h:
10884 2010-08-05 Jian Li <jianli@chromium.org>
10886 Reviewed by David Levin.
10888 Unify blob related feature defines to ENABLE(BLOB).
10889 https://bugs.webkit.org/show_bug.cgi?id=43081
10891 * Configurations/FeatureDefines.xcconfig:
10893 2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
10895 Reviewed by David Kilzer.
10897 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
10898 https://bugs.webkit.org/show_bug.cgi?id=40627
10900 Part 6 - LayoutTest and Cleanup
10902 * WebCoreSupport/WebApplicationCache.h:
10903 * WebCoreSupport/WebApplicationCache.mm:
10904 (+[WebApplicationCache setMaximumSize:]): refactor out deleting the application caches.
10905 (+[WebApplicationCache deleteAllApplicationCaches]): delete application caches.
10907 2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
10909 Reviewed by David Kilzer.
10911 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
10912 https://bugs.webkit.org/show_bug.cgi?id=40627
10914 Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
10916 Per-Origin quotas exist for Databases and Application Caches. Clients
10917 given a WebSecurityOrigin have the ability to set the quota for any
10918 per-origin quota type. This puts quota management into an interface
10919 and WebSecurityOrigin allows access to quota managers for the
10920 different types of quotas.
10922 This also deprecates the old methods on WebSecurityOrigin. They are
10923 left in for now to prevent breaking older clients.
10925 The WebQuotaManager interface allows querying and modifying a
10926 per-origin quota. This is implemented for both Databases and
10927 Application Caches.
10929 * Misc/WebQuotaManager.h: Added. Interface for quota management (usage, quota, setQuota).
10930 * Storage/WebDatabaseQuotaManager.h: Added.
10931 * Storage/WebDatabaseQuotaManager.mm: Added.
10932 (-[WebDatabaseQuotaManager origin]):
10933 (-[WebDatabaseQuotaManager usage]):
10934 (-[WebDatabaseQuotaManager quota]):
10935 (-[WebDatabaseQuotaManager setQuota:]):
10936 * Storage/WebDatabaseSecurityOrigin.h: Removed.
10937 * Storage/WebDatabaseSecurityOrigin.mm: Removed.
10938 * WebCoreSupport/WebApplicationCacheQuotaManager.h: Added.
10939 * WebCoreSupport/WebApplicationCacheQuotaManager.mm: Added.
10940 (-[WebApplicationCacheQuotaManager origin]):
10941 (-[WebApplicationCacheQuotaManager usage]):
10942 (-[WebApplicationCacheQuotaManager quota]):
10943 (-[WebApplicationCacheQuotaManager setQuota:]):
10944 * WebCoreSupport/WebSecurityOriginPrivate.h: Added a category to access managers. Deprecated old methods.
10946 Remove the WebSecurityOrigin sub-classes. Managers are better.
10948 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Removed.
10949 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Removed.
10951 Create the managers lazily. Change old style calls to make use
10954 * WebCoreSupport/WebChromeClient.mm:
10955 (WebChromeClient::exceededDatabaseQuota):
10956 (WebChromeClient::reachedApplicationCacheOriginQuota):
10957 * WebCoreSupport/WebSecurityOrigin.mm:
10958 (-[WebSecurityOrigin applicationCacheQuotaManager]):
10959 (-[WebSecurityOrigin databaseQuotaManager]):
10960 (-[WebSecurityOrigin dealloc]): release the managers if they exist.
10962 2010-08-03 Alex Milowski <alex@milowski.com>
10964 Reviewed by Beth Dakin.
10966 Changed the ENABLE_MATHML value to enable MathML by default.
10968 * Configurations/FeatureDefines.xcconfig:
10970 2010-08-02 Brady Eidson <beidson@apple.com>
10972 Reviewed by Anders Carlsson.
10974 Add VisitedLinkStrategy for each platform to implement
10975 https://bugs.webkit.org/show_bug.cgi?id=43393
10977 * WebCoreSupport/WebPlatformStrategies.h:
10978 * WebCoreSupport/WebPlatformStrategies.mm:
10979 (WebPlatformStrategies::createVisitedLinkStrategy):
10980 (WebPlatformStrategies::isLinkVisited): Call back into PageGroup's visited links.
10981 (WebPlatformStrategies::addVisitedLink): Ditto.
10983 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
10985 Reviewed by Darin Fisher.
10987 PopupMenu refactoring in preparation to WebKit2
10988 https://bugs.webkit.org/show_bug.cgi?id=42592
10990 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
10991 instances, concrete classes that inherit from ChromeClient needed to be changed to
10992 implement the new methods.
10994 * WebCoreSupport/WebChromeClient.h:
10995 * WebCoreSupport/WebChromeClient.mm:
10996 (WebChromeClient::selectItemWritingDirectionIsNatural):
10997 (WebChromeClient::createPopupMenu):
10998 (WebChromeClient::createSearchPopupMenu):
11000 2010-08-02 Jeremy Orlow <jorlow@chromium.org>
11002 Speculative revert of 64425 due to Chromium instability
11003 https://bugs.webkit.org/show_bug.cgi?id=43347
11005 * WebCoreSupport/WebChromeClient.h:
11006 * WebCoreSupport/WebChromeClient.mm:
11008 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
11010 Reviewed by Darin Fisher.
11012 PopupMenu refactoring in preparation to WebKit2
11013 https://bugs.webkit.org/show_bug.cgi?id=42592
11015 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
11016 instances, concrete classes that inherit from ChromeClient needed to be changed to
11017 implement the new methods.
11019 * WebCoreSupport/WebChromeClient.h:
11020 * WebCoreSupport/WebChromeClient.mm:
11021 (WebChromeClient::selectItemWritingDirectionIsNatural):
11022 (WebChromeClient::createPopupMenu):
11023 (WebChromeClient::createSearchPopupMenu):
11025 2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
11027 Unreviewed, rolling out r64422.
11028 http://trac.webkit.org/changeset/64422
11029 https://bugs.webkit.org/show_bug.cgi?id=43304
11031 Build fixes are needed for Snow Leopard and Windows.
11032 (Requested by lca on #webkit).
11034 * WebCoreSupport/WebChromeClient.h:
11035 * WebCoreSupport/WebChromeClient.mm:
11037 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
11039 Reviewed by Darin Fisher.
11041 PopupMenu refactoring in preparation to WebKit2
11042 https://bugs.webkit.org/show_bug.cgi?id=42592
11044 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
11045 instances, concrete classes that inherit from ChromeClient needed to be changed to
11046 implement the new methods.
11048 * WebCoreSupport/WebChromeClient.h:
11049 * WebCoreSupport/WebChromeClient.mm:
11050 (WebChromeClient::selectItemWritingDirectionIsNatural):
11051 (WebChromeClient::createPopupMenu):
11052 (WebChromeClient::createSearchPopupMenu):
11054 2010-07-31 David Kilzer <ddkilzer@apple.com>
11056 <http://webkit.org/b/43300> Simplify variables in *.xcconfig files after adding iOS support
11058 Reviewed by Darin Adler.
11060 * Configurations/WebKit.xcconfig: Extracted
11061 PRODUCTION_FRAMEWORKS_DIR and PRODUCTION_ROOT variables.
11063 2010-07-30 Dan Bernstein <mitz@apple.com>
11065 Reviewed by Darin Adler.
11067 <rdar://problem/8257783> Short documents may print a second blank page
11068 https://bugs.webkit.org/show_bug.cgi?id=43271
11070 * WebView/WebHTMLView.mm:
11071 (-[WebHTMLView _web_setPrintingModeRecursive]): Updated for additional height parameter
11072 to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
11073 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
11074 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
11075 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Added height parameter,
11076 which is scaled and passed on to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
11077 (-[WebHTMLView _endPrintMode]): Updated for additional height parameter to
11078 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
11079 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): Added
11080 height parameter, which is passed on to FrameView::forceLayoutForPagination().
11081 (-[WebHTMLView layout]): Updated for additional height parameter.
11082 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:]): Added height
11083 parameter, which is passed on to -layoutToMinimumPageWidth:height:maximumPageWidth:adjustViewSize:.
11084 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Updated for additional height
11086 (-[WebHTMLView setPageWidthForPrinting:]): Ditto.
11087 (-[WebHTMLView knowsPageRange:]): Pass the available height on the page on to
11088 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize.
11089 * WebView/WebHTMLViewPrivate.h:
11091 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
11093 Fix for tests that broke after r64400. Tracking a more
11094 ideal solution in https://bugs.webkit.org/show_bug.cgi?id=40627
11096 Switch the interface back to (unsigned long long), and move
11097 the WebDatabaseSecurityOrigin implementation up into WebSecurityOrigin.
11098 The subclasses' implementations were not getting called.
11100 * Storage/WebDatabaseSecurityOrigin.mm:
11101 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm:
11102 (-[WebApplicationCacheSecurityOrigin quota]):
11103 (-[WebApplicationCacheSecurityOrigin setQuota:]):
11104 * WebCoreSupport/WebSecurityOrigin.mm:
11105 (-[WebSecurityOrigin usage]):
11106 (-[WebSecurityOrigin quota]):
11107 (-[WebSecurityOrigin setQuota:]):
11108 * WebCoreSupport/WebSecurityOriginPrivate.h:
11110 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
11112 Reviewed by David Kilzer.
11114 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
11115 https://bugs.webkit.org/show_bug.cgi?id=40627
11117 Part 4 - Client Notification when the Quota is Reached
11119 Notify the WebKit client when the per-origin quota is reached
11120 via a delegate method reachedApplicationCacheOriginQuota.
11122 Refactor the WebSecurityOrigin class to be generic enough to
11123 allow quota management of both Databases or Application Caches
11126 * Storage/WebDatabaseSecurityOrigin.h: Added.
11127 * Storage/WebDatabaseSecurityOrigin.mm: Added.
11128 (-[WebDatabaseSecurityOrigin quota]):
11129 (-[WebDatabaseSecurityOrigin setQuota:]):
11130 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Added.
11131 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Added.
11132 (-[WebApplicationCacheSecurityOrigin quota]):
11133 (-[WebApplicationCacheSecurityOrigin setQuota:]):
11134 * Storage/WebSecurityOrigin.mm: Removed. (Moved to WebCoreSupport)
11135 * Storage/WebSecurityOriginPrivate.h: Removed. (Moved to WebCoreSupport)
11136 * WebCoreSupport/WebSecurityOrigin.mm: Added.
11137 (-[WebSecurityOrigin usage]): to be implemented by subclasses.
11138 (-[WebSecurityOrigin quota]): to be implemented by subclasses.
11139 (-[WebSecurityOrigin setQuota:]): to be implemented by subclasses.
11140 * WebCoreSupport/WebSecurityOriginInternal.h: Renamed from WebKit/mac/Storage/WebSecurityOriginInternal.h.
11141 * WebCoreSupport/WebSecurityOriginPrivate.h: Added.
11143 Turn the notification into a WebUI Delegate to call. Following
11144 the example of Databases.
11146 * DefaultDelegates/WebDefaultUIDelegate.m:
11147 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]):
11148 * WebCoreSupport/WebChromeClient.h:
11149 * WebCoreSupport/WebChromeClient.mm:
11150 (WebChromeClient::exceededDatabaseQuota): use the Databases Security Origin subclass.
11151 (WebChromeClient::reachedApplicationCacheOriginQuota): use the Application Cache Security Origin subclass.
11152 * WebView/WebUIDelegatePrivate.h:
11154 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
11156 Reviewed by David Kilzer.
11158 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
11159 https://bugs.webkit.org/show_bug.cgi?id=40627
11161 Part 1 - Add Total and Per-Origin Quota Preferences.
11163 Allow the application cache total size to be a preference, and
11164 add a new preference for the default per-origin quota.
11166 Storage quotas were int64_t (long long). Boilerplate for
11167 these types added for consistency.
11169 * Misc/WebNSDictionaryExtras.h:
11170 * Misc/WebNSDictionaryExtras.m:
11171 (-[NSMutableDictionary _webkit_setLongLong:forKey:]):
11172 * WebCoreSupport/WebApplicationCache.h: setters and accessors for WebCore's cacheStorage.
11173 * WebCoreSupport/WebApplicationCache.mm:
11174 (+[WebApplicationCache maximumSize:]):
11175 (+[WebApplicationCache setMaximumSize:]):
11176 (+[WebApplicationCache defaultOriginQuota]):
11177 (+[WebApplicationCache setDefaultOriginQuota:]):
11178 * WebView/WebPreferenceKeysPrivate.h:
11179 * WebView/WebPreferences.mm:
11180 (+[WebPreferences initialize]): defaults to noQuota for both preferences.
11181 (-[WebPreferences _longLongValueForKey:]):
11182 (-[WebPreferences _setLongLongValue:forKey:]):
11183 (-[WebPreferences applicationCacheTotalQuota]):
11184 (-[WebPreferences setApplicationCacheTotalQuota:]):
11185 (-[WebPreferences applicationCacheDefaultOriginQuota]):
11186 (-[WebPreferences setApplicationCacheDefaultOriginQuota:]):
11187 * WebView/WebPreferencesPrivate.h:
11188 * WebView/WebView.mm:
11189 (-[WebView _preferencesChangedNotification:]): respect updates to the preferences.
11191 2010-07-30 Andy Estes <aestes@apple.com>
11193 Reviewed by David Kilzer.
11195 Add Xcode support for compiling WebKit against iOS SDKs.
11196 https://bugs.webkit.org/show_bug.cgi?id=42796
11198 * Configurations/Base.xcconfig:
11199 * Configurations/DebugRelease.xcconfig:
11200 * Configurations/FeatureDefines.xcconfig:
11201 * Configurations/Version.xcconfig:
11202 * Configurations/WebKit.xcconfig:
11204 2010-07-26 Steve Block <steveblock@google.com>
11206 Reviewed by Jeremy Orlow.
11208 Page clients should be passed to Page constructor via structure of pointers
11209 https://bugs.webkit.org/show_bug.cgi?id=42834
11211 * WebView/WebView.mm:
11212 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
11214 2010-07-27 Kinuko Yasuda <kinuko@chromium.org>
11216 Reviewed by Ojan Vafai.
11218 Add FILE_SYSTEM build flag for FileSystem API
11219 https://bugs.webkit.org/show_bug.cgi?id=42915
11221 * Configurations/FeatureDefines.xcconfig:
11223 2010-07-27 Steve Block <steveblock@google.com>
11225 Reviewed by Jeremy Orlow.
11227 Client-based Geolocation does not pass enableHighAccuracy option to controller and client
11228 https://bugs.webkit.org/show_bug.cgi?id=40374
11230 Stub out setEnableHighAccuracy method for the Mac port.
11232 * WebCoreSupport/WebGeolocationControllerClient.h:
11233 (WebGeolocationControllerClient::setEnableHighAccuracy):
11235 2010-07-22 Sam Weinig <sam@webkit.org>
11237 Reviewed by Maciej Stachowiak.
11239 Fix for <rdar://problem/8222626>
11240 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
11242 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
11243 should migrate to a new function name eventually
11245 * WebCoreSupport/WebEditorClient.mm:
11246 (WebEditorClient::textDidChangeInTextField):
11248 2010-07-22 Sam Weinig <sam@webkit.org>
11250 Reviewed by Anders Carlsson.
11252 Patch for https://bugs.webkit.org/show_bug.cgi?id=42836
11253 Add localized strings stubs for WebKit2.
11255 - Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
11256 for localized strings.
11258 Gets us below 200 tests failing in WebKitTestRunner.
11260 * WebCoreSupport/WebContextMenuClient.mm:
11261 (fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory.
11262 * WebCoreSupport/WebPlatformStrategies.h:
11263 * WebCoreSupport/WebPlatformStrategies.mm:
11264 * WebCoreSupport/WebViewFactory.mm:
11266 2010-07-21 Brady Eidson <beidson@apple.com>
11268 Reviewed by Geoffrey Garen.
11270 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
11271 https://bugs.webkit.org/show_bug.cgi?id=42783
11273 * WebView/WebView.mm:
11274 (+[WebView _registerURLSchemeAsSecure:]):
11275 (+[WebView registerURLSchemeAsLocal:]):
11277 2010-07-21 Simon Fraser <simon.fraser@apple.com>
11279 Reviewed by Anders Carlsson.
11281 Composited layers don't scroll in WebKit2
11282 https://bugs.webkit.org/show_bug.cgi?id=42771
11284 Prep work: FrameView::scrollPositionChanged() sounds like a generic "did scroll" bottleneck,
11285 but this is deceiving. It's only every called on one platform (Mac) when the NSScrollView gets
11286 scrolled, so rename it to FrameView::scrollPositionChangedViaPlatformWidget().
11288 * WebView/WebHTMLView.mm:
11289 (-[WebHTMLView _frameOrBoundsChanged]):
11291 2010-07-21 Eric Carlson <eric.carlson@apple.com>
11293 Reviewed by Simon Fraser.
11295 Update plug-in proxy backed <video> and <audio> elements.
11296 https://bugs.webkit.org/show_bug.cgi?id=42770
11297 <rdar://problem/7963467>
11299 * Plugins/WebPluginController.h:
11300 * Plugins/WebPluginController.mm:
11301 (-[WebPluginController dealloc]): Release _viewsNotInDocument.
11302 (-[WebPluginController stopAllPlugins]): Stop plug-ins not in the document.
11303 (-[WebPluginController pluginViewCreated:]): New, add a View (plug-in) to _viewsNotInDocument.
11304 (+[WebPluginController pluginViewHidden:]): New, remove the view (plug-in) from pluginViews.
11305 (-[WebPluginController addPlugin:]): Remove the new plug-in from _viewsNotInDocument.
11307 * WebCoreSupport/WebFrameLoaderClient.h:
11308 * WebCoreSupport/WebFrameLoaderClient.mm:
11309 (WebFrameLoaderClient::createPlugin): Remove PLUGIN_PROXY_FOR_VIDEO code, the media
11310 player proxy plug-in should never be allocated by this method.
11311 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): New, allocate a media player proxy.
11313 * WebView/WebView.mm:
11314 (-[WebView _videoProxyPluginForMIMEType:]): New. Identical to _pluginForMIMEType except it doesn't
11315 consider the arePlugInsEnabled preference.
11316 * WebView/WebViewInternal.h:
11319 2010-07-19 Chris Marrin <cmarrin@apple.com>
11321 Reviewed by Darin Adler.
11323 https://bugs.webkit.org/show_bug.cgi?id=42118
11324 Disable WebGL on Leopard for now.
11326 LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
11327 GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
11328 SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
11329 software OpenGL driver on machines without this support.
11331 * Configurations/FeatureDefines.xcconfig:
11333 2010-07-18 Anders Carlsson <andersca@apple.com>
11335 Reviewed by Sam Weinig.
11337 Move PluginWidget to WebKit
11338 https://bugs.webkit.org/show_bug.cgi?id=42530
11340 * Plugins/WebBaseNetscapePluginView.h:
11341 * Plugins/WebBaseNetscapePluginView.mm:
11342 (-[WebBaseNetscapePluginView pluginLayer]):
11343 Add default pluginLayer implementation.
11345 * WebCoreSupport/WebFrameLoaderClient.mm:
11346 (PluginWidget::PluginWidget):
11347 (PluginWidget::invalidateRect):
11348 Move the guts of PluginWidget here from WebCore.
11350 (NetscapePluginWidget::platformLayer):
11351 Get the layer from the plug-in view.
11353 2010-07-18 David Kilzer <ddkilzer@apple.com>
11355 <http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods
11357 Reviewed by Dan Bernstein.
11359 * Carbon/CarbonWindowAdapter.mm:
11360 (-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]):
11361 (-[CarbonWindowAdapter _destroyRealWindow:]):
11362 (-[CarbonWindowAdapter _clearModalWindowLevel]):
11363 * Misc/WebIconDatabase.mm:
11364 (-[WebIconDatabase init]):
11365 * Misc/WebNSPasteboardExtras.mm:
11366 (-[NSFilePromiseDragSource initWithSource:]):
11367 * WebView/WebHTMLRepresentation.mm:
11368 (-[WebHTMLRepresentation init]):
11369 * WebView/WebPreferences.mm:
11370 (-[WebPreferences init]):
11371 * WebView/WebView.mm:
11372 (-[WebView UIDelegate]):
11373 (-[WebView resourceLoadDelegate]):
11374 (-[WebView downloadDelegate]):
11375 (-[WebView policyDelegate]):
11376 (-[WebView frameLoadDelegate]):
11378 2010-07-16 Zhe Su <suzhe@chromium.org>
11380 Reviewed by Darin Adler.
11382 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
11383 https://bugs.webkit.org/show_bug.cgi?id=42253
11385 Dummy implementation of EditorClient::willSetInputMethodState.
11387 * WebCoreSupport/WebEditorClient.h:
11388 * WebCoreSupport/WebEditorClient.mm:
11389 (WebEditorClient::willSetInputMethodState):
11391 2010-07-16 Dan Bernstein <mitz@apple.com>
11393 Reviewed by Sam Weinig.
11395 Part of <rdar://problem/7233974> Deprecate +[WebView _setShouldUseFontSmoothing:]
11396 https://bugs.webkit.org/show_bug.cgi?id=29355
11398 * Misc/WebKitNSStringExtras.h:
11399 * Misc/WebKitNSStringExtras.mm:
11400 (-[NSString _web_drawAtPoint:font:textColor:]): Now calls through to
11401 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing YES for the last
11403 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Added
11404 allowingFontSmoothing:. If font smoothing is not allowed, sets the font smoothing
11405 mode to antialiased. Otherwise, sets it to auto.
11406 (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Instead of
11407 changing the font smoothing setting in the graphics context, call
11408 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing NO for the last
11411 2010-07-16 Anders Carlsson <andersca@apple.com>
11413 Reviewed by Sam Weinig.
11415 Remove semicolons from Objective-C method declarations.
11417 * WebView/WebRenderLayer.mm:
11418 (+[WebRenderLayer nameForLayer:]):
11419 (+[WebRenderLayer compositingInfoForLayer:]):
11421 2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
11423 Reviewed by Pavel Feldman.
11425 Make JS memory stats available via 'Performance' object (Web Timing).
11426 This statistics is populated only if 'WebKitMemoryInfoEnabled'
11429 'console.memory' is kept until Web Timing object becomes visible by
11430 default (currently it is hidden under compile-time flag). These stats
11431 are guarded with the same preference.
11433 https://bugs.webkit.org/show_bug.cgi?id=41617
11436 * WebView/WebPreferenceKeysPrivate.h:
11437 * WebView/WebPreferences.mm:
11438 (+[WebPreferences initialize]):
11439 (-[WebPreferences memoryInfoEnabled]):
11440 (-[WebPreferences setMemoryInfoEnabled:]):
11441 * WebView/WebPreferencesPrivate.h:
11442 * WebView/WebView.mm:
11443 (-[WebView _preferencesChangedNotification:]):
11445 2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>
11447 Reviewed by Darin Adler.
11449 Printing test results differ between machines, we should use ImageDiff instead
11450 https://bugs.webkit.org/show_bug.cgi?id=20011
11452 * Misc/WebCoreStatistics.h:
11453 * Misc/WebCoreStatistics.mm:
11454 (-[WebFrame printToCGContext:cgContext:pageWidthInPixels:]):
11456 2010-07-15 Daniel Bates <dbates@rim.com>
11458 Reviewed by Darin Adler.
11460 [Mac] Implement LayoutTestController::markerTextForListItem()
11461 https://bugs.webkit.org/show_bug.cgi?id=37929
11463 Implements support for markerTextForListItem in the Mac port.
11465 * DOM/WebDOMOperations.mm:
11466 (+[DOMElement _DOMElementFromJSContext]): Added.
11467 (-[DOMElement _markerTextForListItem]): Added.
11468 * DOM/WebDOMOperationsPrivate.h:
11470 2010-07-14 Simon Fraser <simon.fraser@apple.com>
11472 Fix non-ACCELERATED_COMPOSITING build.
11474 * WebView/WebRenderLayer.mm:
11475 (+[WebRenderLayer compositingInfoForLayer:]):
11477 2010-07-14 Simon Fraser <simon.fraser@apple.com>
11479 Reviewed by John Sullivan.
11481 <rdar://problem/8186963> Expose information about compositing layers.
11483 Use RenderLayerBacking::compositingLayerType() to add more information about compositing to
11484 WebRenderLayer, via a compositingInfo property. Also show element classnames.
11486 Also add separator items between the various z-order lists.
11488 * WebView/WebRenderLayer.h:
11489 * WebView/WebRenderLayer.mm:
11490 (+[WebRenderLayer nameForLayer:]):
11491 (+[WebRenderLayer compositingInfoForLayer:]):
11492 (-[WebRenderLayer initWithRenderLayer:]):
11493 (-[WebRenderLayer initWithName:]):
11494 (-[WebRenderLayer initWithWebFrame:]):
11495 (-[WebRenderLayer dealloc]):
11496 (-[WebRenderLayer buildDescendantLayers:]):
11497 (-[WebRenderLayer compositingInfo]):
11498 (-[WebRenderLayer isComposited]):
11499 (-[WebRenderLayer isSeparator]):
11501 2010-07-14 Darin Adler <darin@apple.com>
11503 Another try at fixing the Tiger build.
11505 Avoid non-ASCII in source files to keep Tiger compiler happy.
11507 * WebView/WebRenderLayer.mm:
11508 (+[WebRenderLayer nameForLayer:]): Use %C for the non-ASCII characters.
11510 2010-07-14 Sam Weinig <sam@webkit.org>
11512 Reviewed by Darin Adler.
11514 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
11515 Make changing Cursors work in WebKit2.
11517 * WebCoreSupport/WebChromeClient.h:
11518 * WebCoreSupport/WebChromeClient.mm:
11519 (WebChromeClient::setCursor):
11520 * WebView/WebView.mm:
11521 Implement cursor changing at the WebKit level for the sake of WebKit2.
11522 This functionality is being moved from WidgetMac.mm.
11523 (+[WebView _pointingHandCursor]):
11524 Update to use platformCursor() instead of impl().
11526 2010-07-13 Simon Fraser <simon.fraser@apple.com>
11530 Avoid non-ASCII in souce files to keep Tiger compiler happy.
11532 * WebView/WebRenderLayer.mm:
11533 (+[WebRenderLayer nameForLayer:]):
11535 2010-07-13 Simon Fraser <simon.fraser@apple.com>
11537 Reviewed by Dan Bernstein.
11539 <rdar://problem/8186963> Expose RenderLayer hierarchy via Obj-C for debugging.
11541 Add a WebRenderLayer class that reflects the RenderLayer tree into a hierarchy
11542 of Objective-C objects suitable for display in an outline view.
11544 * WebKit.exp: Export the WebRenderLayer Objective-C class.
11545 * WebView/WebRenderLayer.h: Added.
11546 * WebView/WebRenderLayer.mm: Added.
11548 2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
11550 Reviewed by Darin Adler.
11552 Prevent assertion/duplicate loads for non-deferred subtitute-data loads
11554 https://bugs.webkit.org/show_bug.cgi?id=30879
11556 MainResourceLoader uses the member m_initialRequest to store requests for future
11557 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
11558 have to clear this request so that subsequent entries into the loader will not
11559 start yet another load.
11561 This can happen as a result of a PageGroupLoadDeferrer going out of scope when
11562 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
11563 but only in the case of using both substitute-data and non-deferred main resource
11564 load together. That's why two new DRT functions were added:
11566 * queueLoadHTMLString()
11567 * setDeferMainResourceLoad()
11569 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
11570 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
11571 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
11573 * WebView/WebDataSource.mm:
11574 (-[WebDataSource _setDeferMainResourceDataLoad:]):
11575 * WebView/WebDataSourcePrivate.h:
11577 2010-07-13 Philippe Normand <pnormand@igalia.com>
11579 Rubber-stamped by Xan Lopez.
11581 Updated the copyright headers of the files modified in r62476.
11583 * WebView/WebView.mm:
11584 * WebView/WebViewData.h:
11585 * WebView/WebViewInternal.h:
11587 2010-07-09 Alexey Proskuryakov <ap@apple.com>
11589 Reviewed by Darin Adler.
11591 https://bugs.webkit.org/show_bug.cgi?id=13075
11592 XMLHttpRequest with failed authentication should set status to 401
11594 https://bugs.webkit.org/show_bug.cgi?id=6871
11595 <rdar://problem/3363403> 401 error page is never shown
11597 * Panels/WebPanelAuthenticationHandler.m:
11598 (-[WebPanelAuthenticationHandler startAuthentication:window:]): Updated a comment - this
11599 code cancels loading, not authentication (canceling authentication means telling to
11600 continue without credentials).
11601 (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]): If there were
11602 no credentials provided, tell to continue without any. There may be alternative content
11605 2010-07-09 Leon Clarke <leonclarke@google.com>
11607 Reviewed by Adam Barth.
11609 add support for link prefetching
11610 https://bugs.webkit.org/show_bug.cgi?id=3652
11612 * Configurations/FeatureDefines.xcconfig:
11614 2010-07-08 Aaron Boodman <aa@chromium.org>
11616 Reviewed by Timothy Hatcher.
11618 Add the ability for user scripts and user styles to affect just the top frame.
11620 https://bugs.webkit.org/show_bug.cgi?id=41529
11622 * WebView/WebView.mm:
11623 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]):
11624 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
11625 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]):
11626 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
11627 * WebView/WebViewPrivate.h:
11629 2010-07-08 Adele Peterson <adele@apple.com>
11631 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
11633 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721
11634 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
11636 Implement shouldMissingPluginMessageBeButton.
11638 * WebCoreSupport/WebChromeClient.h:
11639 * WebCoreSupport/WebChromeClient.mm:
11640 (WebChromeClient::shouldMissingPluginMessageBeButton):
11642 2010-07-08 Brady Eidson <beidson@apple.com>
11644 Reviewed by Tim Hatcher.
11646 <rdar://problem/8136327> - Crash in Entourage calling WebCache method from background thread
11648 * Misc/WebCache.mm:
11649 (+[WebCache setDisabled:]): Forward the call to the main thread if called from a background thread.
11651 * Misc/WebNSObjectExtras.h:
11652 * Misc/WebNSObjectExtras.mm:
11653 (+[NSObject _webkit_invokeOnMainThread]): Add a class version of the main thread invoker.
11655 2010-07-08 Mike Thole <mthole@apple.com>
11657 Reviewed by Darin Adler.
11659 Patch for https://bugs.webkit.org/show_bug.cgi?id=41896
11660 Crash under allScriptsInPDFDocument() in WebPDFDocumentExtras.mm for certain PDFs
11662 * WebView/WebPDFDocumentExtras.mm:
11663 (allScriptsInPDFDocument): Null-check 'data', as CGPDFStreamCopyData() may have returned 0.
11665 2010-07-08 Sam Weinig <sam@webkit.org>
11667 Reviewed by Anders Carlsson.
11669 Patch for https://bugs.webkit.org/show_bug.cgi?id=41826
11670 Convert BackForwardList to an abstract base class and add BackForwardListImpl
11671 as the concrete implementation of it.
11673 * History/WebBackForwardList.mm:
11674 (-[WebBackForwardList init]):
11675 (-[WebBackForwardList setPageCacheSize:]):
11676 (-[WebBackForwardList pageCacheSize]):
11678 2010-07-07 Sam Weinig <sam@webkit.org>
11680 Reviewed by Anders Carlsson.
11682 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
11683 Add basic piping for BackForwardControllerClient.
11685 * WebView/WebView.mm:
11686 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
11688 2010-07-07 Anders Carlsson <andersca@apple.com>
11690 Reviewed by Sam Weinig.
11692 Change requestURL to a KURL.
11693 https://bugs.webkit.org/show_bug.cgi?id=41775
11695 * Plugins/WebNetscapePluginStream.h:
11696 (WebNetscapePluginStream::setRequestURL):
11697 * Plugins/WebNetscapePluginStream.mm:
11698 (WebNetscapePluginStream::pluginCancelledConnectionError):
11699 (WebNetscapePluginStream::errorForReason):
11700 (WebNetscapePluginStream::startStream):
11701 (WebNetscapePluginStream::didReceiveResponse):
11702 (WebNetscapePluginStream::destroyStream):
11704 2010-07-07 Anders Carlsson <andersca@apple.com>
11706 Reviewed by Sam Weinig.
11708 Rename the WebBaseNetscapePluginStream.cpp and .h files to WebNetscapePluginStream.cpp and .h to match the class name.
11710 * Plugins/WebNetscapePluginStream.h: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.h.
11711 * Plugins/WebNetscapePluginStream.mm: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.mm.
11713 2010-07-06 Steve Falkenburg <sfalken@apple.com>
11715 Reviewed by Simon Fraser.
11717 Expose URL matching from WebUserContentURLPattern
11718 https://bugs.webkit.org/show_bug.cgi?id=41726
11719 <rdar://problem/7910144>
11721 We previously had a way to construct WebUserContentURLPattern
11722 instances via WebKit, but no way for callers to perform matching.
11723 This patch adds the matchesURL functionality to allow for this.
11725 * Misc/WebUserContentURLPattern.h: Added matchesURL.
11726 * Misc/WebUserContentURLPattern.mm:
11727 (-[WebUserContentURLPattern matchesURL:]): Added. Calls through to WebCore::UserContentURLPattern::matches.
11729 2010-06-23 Philippe Normand <pnormand@igalia.com>
11731 Reviewed by Eric Carlson.
11733 [GStreamer] on Mac OS use a runloop observer to process the glib context iterations
11734 https://bugs.webkit.org/show_bug.cgi?id=35747
11736 If VIDEO and GSTREAMER are enabled, make the WebView start a
11737 runloop observer that will trigger the glib main context
11738 iterations. Those are needed by the GStreamer player only at the
11739 moment but could later be used for other GLib-dependant components
11742 * WebView/WebView.mm:
11743 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
11744 (-[WebView _close]):
11745 (-[WebView _clearGlibLoopObserver]):
11746 (glibContextIterationCallback):
11747 (-[WebView _scheduleGlibContextIterations]):
11748 * WebView/WebViewData.h:
11749 * WebView/WebViewInternal.h:
11751 2010-07-03 Jon Honeycutt <jhoneycutt@apple.com>
11753 The missing plug-in indicator should be clickable
11755 https://bugs.webkit.org/show_bug.cgi?id=41550
11756 <rdar://problem/8132162>
11758 From an original patch by Kevin Decker.
11760 Reviewed by Darin Adler.
11762 * WebCoreSupport/WebChromeClient.h:
11763 Declare an override of missingPluginButtonClicked().
11765 * WebCoreSupport/WebChromeClient.mm:
11766 (WebChromeClient::missingPluginButtonClicked):
11767 Call the UIDelegate's method.
11769 * WebView/WebUIDelegatePrivate.h:
11770 Declare didPressMissingPluginButton.
11772 2010-07-01 Timothy Hatcher <timothy@apple.com>
11774 Provide a WebView preference to disable DNS prefetching.
11776 https://bugs.webkit.org/show_bug.cgi?id=28825
11777 rdar://problem/7181249
11779 Reviewed by Darin Adler.
11781 * WebView/WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
11782 * WebView/WebPreferences.mm:
11783 (+[WebPreferences initialize]): Set WebKitDNSPrefetchingEnabledPreferenceKey to YES.
11784 (-[WebPreferences isDNSPrefetchingEnabled]): Added. Return WebKitDNSPrefetchingEnabledPreferenceKey's value.
11785 (-[WebPreferences setDNSPrefetchingEnabled:]): Added. Set WebKitDNSPrefetchingEnabledPreferenceKey's value.
11786 * WebView/WebPreferencesPrivate.h: Added isDNSPrefetchingEnabled and setDNSPrefetchingEnabled:.
11787 * WebView/WebView.mm:
11788 (-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setDNSPrefetchingEnabled.
11790 2010-07-01 Alexey Proskuryakov <ap@apple.com>
11792 Reviewed by Anders Carlsson.
11794 <rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
11795 REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction
11797 Strengthen m_inDestroy "swipe under the carpet" fix.
11799 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Added a long comment about m_inDestroy, and
11800 changed it to static.
11802 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
11803 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): m_inDestroy is now
11804 static, so we don't initialize it in constructor.
11805 (WebKit::NetscapePluginInstanceProxy::destroy): Assert that we aren't already destroying
11807 (WebKit::NetscapePluginInstanceProxy::evaluate): This function accidentally lacked an
11808 m_inDestroy check in r42789.
11810 2010-06-29 Zoltan Herczeg <zherczeg@webkit.org>
11812 Reviewed by Nikolas Zimmermann.
11814 Add ConvolveMatrixElement to MigrateHeaders.make
11815 https://bugs.webkit.org/show_bug.cgi?id=5861
11817 * MigrateHeaders.make:
11819 2010-06-23 John Gregg <johnnyg@google.com>
11821 Reviewed by Kent Tamura.
11823 add ENABLE_DIRECTORY_UPLOAD build support
11824 https://bugs.webkit.org/show_bug.cgi?id=41100
11826 * Configurations/FeatureDefines.xcconfig:
11828 2010-06-28 Eric Seidel <eric@webkit.org>
11830 Reviewed by Adam Barth.
11832 Make it possible to test the new HTML5 TreeBuilder
11833 https://bugs.webkit.org/show_bug.cgi?id=41276
11835 Adam was concerned that someone might make their port
11836 depend on this setting (I guess we had some trouble with that
11837 with the HTML5Parser setting), so I littered the code with warnings.
11839 test-html5-parser now tests this code path.
11841 * WebView/WebPreferenceKeysPrivate.h:
11842 * WebView/WebPreferences.mm:
11843 (+[WebPreferences initialize]):
11844 (-[WebPreferences html5TreeBuilderEnabled]):
11845 (-[WebPreferences setHTML5TreeBuilderEnabled:]):
11846 * WebView/WebPreferencesPrivate.h:
11847 * WebView/WebView.mm:
11848 (-[WebView _preferencesChangedNotification:]):
11850 2010-06-25 Yuzo Fujishima <yuzo@google.com>
11852 Reviewed by Shinichiro Hamaji.
11854 Improve default value handling for page format properties.
11855 https://bugs.webkit.org/show_bug.cgi?id=41150
11857 * Misc/WebCoreStatistics.h:
11858 * Misc/WebCoreStatistics.mm:
11859 (-[WebFrame pageSizeAndMarginsInPixels:pageNumber:width:height:marginTop:marginRight:marginBottom:]):
11861 2010-06-26 Tony Gentilcore <tonyg@chromium.org>
11863 Reviewed by Dimitri Glazkov.
11865 Add an ENABLE_WEB_TIMING option for enabling Web Timing support.
11866 https://bugs.webkit.org/show_bug.cgi?id=38924
11868 * Configurations/FeatureDefines.xcconfig:
11870 2010-06-24 Jer Noble <jer.noble@apple.com>
11872 Reviewed by Eric Carlson.
11874 Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
11875 https://bugs.webkit.org/show_bug.cgi?id=40939
11876 rdar://problem/7996172
11878 Take a IOKit power assertion when playing video in fullscreen mode. Release the
11879 assertion when paused in fullscreen mode, and when exiting fullscreen mode.
11881 * WebView/WebVideoFullscreenController.h:
11882 * WebView/WebVideoFullscreenController.mm:
11883 (-[WebVideoFullscreenController windowDidExitFullscreen]): Call updatePowerAssertions.
11884 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Call updatePowerAssertions.
11885 (-[WebVideoFullscreenController _disableIdleDisplaySleep]):
11886 (-[WebVideoFullscreenController _enableIdleDisplaySleep]):
11887 (-[WebVideoFullscreenController _disableIdleSystemSleep]):
11888 (-[WebVideoFullscreenController _enableIdleSystemSleep]):
11889 (-[WebVideoFullscreenController updatePowerAssertions]): Call _(enable|disable)Idle(System|Display)sleep depending on current playback rate and fullscreen status.
11890 (-[WebVideoFullscreenController rateChanged:]): Call updatePowerAssertions.
11892 2010-06-24 Jer Noble <jer.noble@apple.com>
11894 Reviewed by Darin Adler.
11896 Playing movie full screen on second monitor hides menu bar and title bar on main monitor
11897 https://bugs.webkit.org/show_bug.cgi?id=40933
11898 rdar://problem/7858452
11900 Remove all references to GetSystemUIMode and SetSystemUIMode. Replace these calls with
11901 [NSApplication setPresentationOptions:]. Do not auto-hide the menu bar if the fullscreen
11902 screen is does not contain the menu-bar. Do not auto-hide the dock if the fullscreen screen
11903 is both not the menu-bar screen and not the dock screen.
11905 * WebView/WebVideoFullscreenController.mm:
11906 (-[WebVideoFullscreenController windowDidLoad]): Register the applicationDidChangeScreenParameters: listener.
11907 (-[WebVideoFullscreenController windowDidExitFullscreen]): Calls updateMenuAndDockForFullscreen.
11908 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Calls updateMenuAndDockForFullscreen.
11909 (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]): New notification handler; catches NSApplicationDidChangeScreenParameters.
11910 (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]): Hide/show the menu-bar and dock according to the fullscreen window's screen.
11912 2010-06-24 Jer Noble <jer.noble@apple.com>
11914 Reviewed by Eric Carlson.
11916 Full screen video in Safari exits full-screen if you switch to another app
11917 https://bugs.webkit.org/show_bug.cgi?id=40635
11918 rdar://problem/7885101
11920 Implement the following rules for exiting full screen when switching apps:
11921 1. If the system has a single screen, switching apps will cause Safari to exit full-screen.
11922 2. Otherwise, if the full-screen screen is the "main screen" (the one with the title bar),
11923 switching apps will cause Safari to exit full-screen.
11924 3. Overriding rules 1 & 2, if the full-screen screen is not on the "current space",
11925 switching apps will NOT cause Safari to exit full-screen.
11927 * WebView/WebVideoFullscreenController.mm:
11928 (-[WebVideoFullscreenController windowDidLoad]):
11929 (-[WebVideoFullscreenController applicationDidResignActive:]):
11931 2010-06-24 Adele Peterson <adele@apple.com>
11933 Reviewed by Sam Weinig.
11935 Updated fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
11936 https://bugs.webkit.org/show_bug.cgi?id=41085
11938 * WebView/WebHTMLView.mm: Use the WebCore command system for the pasteAsPlainText selector.
11939 Also remove internal methods that no one is using.
11941 2010-06-24 Damian Kaleta <dkaleta@apple.com>
11943 Reviewed by Sam Weinig.
11945 Added an ObjC wrapper to Node::renderRect(bool&).
11947 * DOM/WebDOMOperations.mm:
11948 (-[DOMNode _renderRect:]):
11949 * DOM/WebDOMOperationsPrivate.h:
11951 2010-06-24 Adele Peterson <adele@apple.com>
11953 Reviewed by Eric Carlson.
11955 Fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
11956 https://bugs.webkit.org/show_bug.cgi?id=41085
11958 * WebView/WebHTMLView.mm: (-[WebHTMLView pasteAsPlainText:]): Reuse code in WebCore
11959 which does everything done here and also fires paste events.
11961 2010-06-23 Yuzo Fujishima <yuzo@google.com>
11963 Reviewed by Shinichiro Hamaji.
11965 Implement page format data programming interface.
11966 Add methods for testing.
11967 https://bugs.webkit.org/show_bug.cgi?id=37538
11969 * Misc/WebCoreStatistics.h:
11970 * Misc/WebCoreStatistics.mm:
11971 (-[WebFrame isPageBoxVisible:]):
11972 (-[WebFrame pageAreaRectInPixels:]):
11973 (-[WebFrame preferredPageSizeInPixels:]):
11975 2010-06-22 Anders Carlsson <andersca@apple.com>
11977 Reviewed by Sam Weinig.
11979 Get rid of more USE_LIBDISPATCH code.
11981 * Plugins/Hosted/NetscapePluginHostProxy.h:
11983 2010-06-22 Anders Carlsson <andersca@apple.com>
11985 Reviewed by Sam Weinig.
11987 Get rid of the USE_LIBDISPATCH code.
11989 * Plugins/Hosted/NetscapePluginHostProxy.mm:
11990 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
11991 (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
11993 2010-06-22 Anders Carlsson <andersca@apple.com>
11995 Reviewed by Sam Weinig.
11997 Wean NetscapePluginHostManager of any knowledge about WebNetscapePluginPackage
11998 https://bugs.webkit.org/show_bug.cgi?id=41006
12000 * Plugins/Hosted/NetscapePluginHostManager.h:
12001 * Plugins/Hosted/NetscapePluginHostManager.mm:
12002 (WebKit::NetscapePluginHostManager::hostForPlugin):
12003 (WebKit::NetscapePluginHostManager::spawnPluginHost):
12004 (WebKit::NetscapePluginHostManager::instantiatePlugin):
12005 (WebKit::NetscapePluginHostManager::createPropertyListFile):
12006 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
12007 (-[WebHostedNetscapePluginView createPlugin]):
12008 * Plugins/WebNetscapePluginPackage.mm:
12009 (-[WebNetscapePluginPackage createPropertyListFile]):
12011 2010-06-21 Anders Carlsson <andersca@apple.com>
12013 Reviewed by Sam Weinig.
12015 Fix an off-by-one bug I introduced.
12017 * Plugins/WebNetscapePluginPackage.mm:
12018 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
12020 2010-06-21 Nate Chapin <japhet@chromium.org>
12022 Reviewed by Adam Barth.
12024 FrameLoader cleanup: Split high level subframe and plugin
12025 loading functions into a separate class.
12026 https://bugs.webkit.org/show_bug.cgi?id=40453
12028 * WebView/WebFrame.mm:
12029 (-[WebFrame _cacheabilityDictionary]):
12031 2010-06-21 Anders Carlsson <andersca@apple.com>
12033 Another Tiger build fix.
12035 * Plugins/WebNetscapePluginPackage.mm:
12036 (-[WebNetscapePluginPackage _tryLoad]):
12038 2010-06-21 Anders Carlsson <andersca@apple.com>
12040 Reviewed by Sam Weinig.
12042 More WebBasePluginPackage cleanup
12043 https://bugs.webkit.org/show_bug.cgi?id=40944
12045 * Plugins/Hosted/HostedNetscapePluginStream.mm:
12046 (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError):
12047 * Plugins/Hosted/NetscapePluginHostManager.mm:
12048 (WebKit::NetscapePluginHostManager::spawnPluginHost):
12049 * Plugins/WebBaseNetscapePluginStream.mm:
12050 (WebNetscapePluginStream::pluginCancelledConnectionError):
12051 * Plugins/WebBaseNetscapePluginView.mm:
12052 (WebHaltablePlugin::pluginName):
12053 * Plugins/WebBasePluginPackage.h:
12054 * Plugins/WebBasePluginPackage.mm:
12055 (-[WebBasePluginPackage initWithPath:]):
12056 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]):
12057 (-[WebBasePluginPackage getPluginInfoFromPLists]):
12058 (-[WebBasePluginPackage load]):
12059 (-[WebBasePluginPackage dealloc]):
12060 (-[WebBasePluginPackage finalize]):
12061 (-[WebBasePluginPackage pluginInfo]):
12062 (-[WebBasePluginPackage supportsExtension:]):
12063 (-[WebBasePluginPackage supportsMIMEType:WebCore::]):
12064 (-[WebBasePluginPackage MIMETypeForExtension:]):
12065 (-[WebBasePluginPackage isJavaPlugIn]):
12066 (-[WebBasePluginPackage versionNumber]):
12067 (-[WebBasePluginPackage WebCore::]):
12068 * Plugins/WebNetscapePluginPackage.mm:
12069 (-[WebNetscapePluginPackage openResourceFile]):
12070 (-[WebNetscapePluginPackage closeResourceFile:]):
12071 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
12072 (-[WebNetscapePluginPackage _initWithPath:]):
12073 (-[WebNetscapePluginPackage _applyDjVuWorkaround]):
12074 (-[WebNetscapePluginPackage _tryLoad]):
12075 (-[WebNetscapePluginPackage supportsSnapshotting]):
12076 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
12077 * Plugins/WebPluginDatabase.mm:
12078 (-[WebPluginDatabase refresh]):
12079 (-[WebPluginDatabase _removePlugin:]):
12080 * Plugins/WebPluginPackage.mm:
12081 (-[WebPluginPackage initWithPath:]):
12082 (-[WebPluginPackage load]):
12083 * WebCoreSupport/WebFrameLoaderClient.mm:
12084 (WebFrameLoaderClient::createPlugin):
12085 * WebCoreSupport/WebPlatformStrategies.mm:
12086 (WebPlatformStrategies::getPluginInfo):
12088 2010-06-21 Anders Carlsson <andersca@apple.com>
12090 Another PowerPC build fix.
12092 * Plugins/WebNetscapePluginPackage.mm:
12093 (-[WebNetscapePluginPackage openResourceFile]):
12094 (-[WebNetscapePluginPackage _tryLoad]):
12096 2010-06-21 Anders Carlsson <andersca@apple.com>
12098 Try to fix the PowerPC build.
12100 * Plugins/WebNetscapePluginPackage.mm:
12101 (-[WebNetscapePluginPackage _tryLoad]):
12103 2010-06-21 Nate Chapin <japhet@chromium.org>
12105 Reviewed by Adam Barth.
12107 Update relevant calls into FrameLoader to make use of
12108 FrameLoaderStateMachine.
12109 https://bugs.webkit.org/show_bug.cgi?id=39695
12111 * WebCoreSupport/WebFrameLoaderClient.mm:
12112 (WebFrameLoaderClient::transitionToCommittedForNewPage):
12113 * WebView/WebFrame.mm:
12114 (-[WebFrame _firstLayoutDone]):
12116 2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>
12118 Reviewed by Dan Bernstein.
12120 Chromium/Mac build fix.
12122 * WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other
12125 2010-06-21 Anders Carlsson <andersca@apple.com>
12127 Reviewed by Dan Bernstein.
12129 Make all of WebKit build with clang++
12131 * DefaultDelegates/WebDefaultPolicyDelegate.m:
12132 (-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
12133 * Plugins/Hosted/NetscapePluginHostManager.mm:
12134 * Plugins/WebBaseNetscapePluginView.mm:
12135 (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
12136 * WebView/WebDynamicScrollBarsView.mm:
12137 (-[WebDynamicScrollBarsView setSuppressLayout:]):
12138 * WebView/WebHTMLRepresentation.mm:
12139 * WebView/WebNavigationData.mm:
12140 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
12141 * WebView/WebPDFRepresentation.mm:
12142 (-[WebPDFRepresentation setDataSource:]):
12143 (-[WebPDFRepresentation receivedData:withDataSource:]):
12144 (-[WebPDFRepresentation receivedError:withDataSource:]):
12145 * WebView/WebResource.mm:
12146 (-[WebResource description]):
12147 * WebView/WebSerializedJSValue.mm:
12148 (-[WebSerializedJSValue initWithValue:context:exception:]):
12149 * WebView/WebVideoFullscreenController.mm:
12150 (-[WebVideoFullscreenController WebCore::]):
12151 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
12152 (-[WebVideoFullscreenController setDelegate:]):
12153 (-[WebVideoFullscreenController enterFullscreen:]):
12154 * WebView/WebView.mm:
12155 (-[WebView _openFrameInNewWindowFromMenu:]):
12156 (-[WebView _geolocationDidChangePosition:]):
12158 2010-06-21 Anders Carlsson <andersca@apple.com>
12160 Reviewed by Sam Weinig.
12162 Remove unused dictionary ivars from WebBasePluginPackage
12163 https://bugs.webkit.org/show_bug.cgi?id=40928
12165 * Plugins/WebBasePluginPackage.h:
12166 * Plugins/WebBasePluginPackage.mm:
12167 (-[WebBasePluginPackage getPluginInfoFromPLists]):
12168 (-[WebBasePluginPackage dealloc]):
12169 * Plugins/WebNetscapePluginPackage.mm:
12170 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
12172 2010-06-21 Dan Bernstein <mitz@apple.com>
12176 * WebCoreSupport/WebSystemInterface.mm:
12177 (InitWebCoreSystemInterface):
12179 2010-06-21 Dan Bernstein <mitz@apple.com>
12181 Reviewed by Darin Adler.
12183 WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties
12184 https://bugs.webkit.org/show_bug.cgi?id=10228
12186 * WebCoreSupport/WebSystemInterface.mm:
12187 (InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex.
12189 2010-06-21 Satish Sampath <satish@chromium.org>
12191 Reviewed by Steve Block.
12193 Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
12194 https://bugs.webkit.org/show_bug.cgi?id=40878
12196 * Configurations/FeatureDefines.xcconfig:
12198 2010-06-20 Anders Carlsson <andersca@apple.com>
12202 * Plugins/WebNetscapePluginPackage.mm:
12204 2010-06-20 Anders Carlsson <andersca@apple.com>
12206 Reviewed by Dan Bernstein.
12208 Get rid of the old MIMETypes getter method
12209 https://bugs.webkit.org/show_bug.cgi?id=40898
12211 * Plugins/WebBasePluginPackage.h:
12212 * Plugins/WebBasePluginPackage.mm:
12213 (-[WebBasePluginPackage supportsExtension:]):
12214 (-[WebBasePluginPackage supportsMIMEType:WebCore::]):
12215 (-[WebBasePluginPackage MIMETypeForExtension:]):
12216 * Plugins/WebPluginDatabase.mm:
12217 (-[WebPluginDatabase refresh]):
12218 (-[WebPluginDatabase _removePlugin:]):
12220 2010-06-20 Anders Carlsson <andersca@apple.com>
12222 Reviewed by Dan Bernstein.
12224 Remove bogus const qualifiers.
12226 * WebCoreSupport/WebPasteboardHelper.h:
12227 * WebCoreSupport/WebPasteboardHelper.mm:
12228 (WebPasteboardHelper::urlFromPasteboard):
12229 (WebPasteboardHelper::plainTextFromPasteboard):
12230 (WebPasteboardHelper::fragmentFromPasteboard):
12232 2010-06-20 Anders Carlsson <andersca@apple.com>
12234 Reviewed by Dan Bernstein.
12236 Get rid of the extensionToMIME mapping in WebBasePluginPackage
12237 https://bugs.webkit.org/show_bug.cgi?id=40897
12239 Instead of using the extensionToMIME mutable dictionary, use the MIME types vector.
12240 While this makes lookup of MIME types based on extensions linear instead of constant,
12241 the number of extensions per plug-in is too small for it to matter.
12243 * Plugins/WebBasePluginPackage.h:
12244 * Plugins/WebBasePluginPackage.mm:
12245 (-[WebBasePluginPackage initWithPath:]):
12246 (-[WebBasePluginPackage dealloc]):
12247 (-[WebBasePluginPackage supportsExtension:]):
12248 (-[WebBasePluginPackage MIMETypeForExtension:]):
12249 (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
12251 2010-06-20 Anders Carlsson <andersca@apple.com>
12253 Reviewed by Dan Bernstein.
12255 Add a MimeClassInfo Vector to WebBasePluginPackage
12256 https://bugs.webkit.org/show_bug.cgi?id=40896
12258 * Plugins/WebBasePluginPackage.h:
12259 * Plugins/WebBasePluginPackage.mm:
12260 (-[WebBasePluginPackage getPluginInfoFromPLists]):
12261 (-[WebBasePluginPackage WebCore::]):
12262 * Plugins/WebNetscapePluginPackage.mm:
12263 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
12264 * WebCoreSupport/WebPlatformStrategies.mm:
12265 (WebPlatformStrategies::getPluginInfo):
12267 2010-06-20 Anders Carlsson <andersca@apple.com>
12269 Reviewed by Dan Bernstein.
12271 Move the NSBundle ivar to WebPluginPackage
12272 https://bugs.webkit.org/show_bug.cgi?id=40894
12274 * Plugins/WebBasePluginPackage.h:
12275 * Plugins/WebBasePluginPackage.mm:
12276 (-[WebBasePluginPackage initWithPath:]):
12277 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]):
12278 (-[WebBasePluginPackage getPluginInfoFromPLists]):
12279 (-[WebBasePluginPackage load]):
12280 (-[WebBasePluginPackage dealloc]):
12281 * Plugins/WebNetscapePluginPackage.mm:
12282 (-[WebNetscapePluginPackage _initWithPath:]):
12283 * Plugins/WebPluginPackage.h:
12284 * Plugins/WebPluginPackage.mm:
12285 (-[WebPluginPackage initWithPath:]):
12286 (-[WebPluginPackage dealloc]):
12287 (-[WebPluginPackage viewFactory]):
12288 (-[WebPluginPackage load]):
12290 2010-06-20 Anders Carlsson <andersca@apple.com>
12292 Reviewed by Sam Weinig.
12294 Remove -[WebBasePluginPackage bundle]
12295 https://bugs.webkit.org/show_bug.cgi?id=40892
12297 Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it.
12299 Move the supportsSnapshotting method over to the plug-in package.
12301 * Plugins/Hosted/NetscapePluginHostManager.mm:
12302 (WebKit::NetscapePluginHostManager::hostForPackage):
12303 * Plugins/WebBaseNetscapePluginView.mm:
12304 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
12305 (-[WebBaseNetscapePluginView supportsSnapshotting]):
12306 * Plugins/WebBasePluginPackage.h:
12307 * Plugins/WebBasePluginPackage.mm:
12308 (-[WebBasePluginPackage isQuickTimePlugIn]):
12309 (-[WebBasePluginPackage isJavaPlugIn]):
12310 (-[WebBasePluginPackage WebCore::]):
12311 Call bundleIdentifier directly instead of asking the bundle
12312 * Plugins/WebNetscapePluginPackage.h:
12313 * Plugins/WebNetscapePluginPackage.mm:
12314 (-[WebNetscapePluginPackage supportsSnapshotting]):
12315 * Plugins/WebNetscapePluginView.mm:
12316 (-[WebNetscapePluginView setAttributeKeys:andValues:]):
12317 (-[WebNetscapePluginView _createPlugin]):
12318 * Plugins/WebPluginDatabase.mm:
12321 2010-06-20 Anders Carlsson <andersca@apple.com>
12323 Reviewed by Dan Bernstein.
12325 Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
12326 https://bugs.webkit.org/show_bug.cgi?id=40869
12328 Re-land r61459, with extra null-checks in WebFrameLoaderClient.
12330 * Plugins/Hosted/NetscapePluginHostManager.mm:
12331 (WebKit::NetscapePluginHostManager::spawnPluginHost):
12332 * Plugins/WebBasePluginPackage.h:
12333 * Plugins/WebBasePluginPackage.mm:
12334 (-[WebBasePluginPackage initWithPath:]):
12335 (-[WebBasePluginPackage getPluginInfoFromPLists]):
12336 (-[WebBasePluginPackage dealloc]):
12337 (-[WebBasePluginPackage name]):
12338 (-[WebBasePluginPackage path]):
12339 (-[WebBasePluginPackage filename]):
12340 (-[WebBasePluginPackage pluginDescription]):
12341 (-[WebBasePluginPackage description]):
12342 (-[WebBasePluginPackage isJavaPlugIn]):
12343 * Plugins/WebNetscapePluginPackage.mm:
12344 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
12345 (-[WebNetscapePluginPackage _tryLoad]):
12346 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
12347 * Plugins/WebPluginPackage.mm:
12348 (-[WebPluginPackage load]):
12349 * WebCoreSupport/WebFrameLoaderClient.mm:
12350 (WebFrameLoaderClient::createPlugin):
12352 2010-06-18 Adam Barth <abarth@webkit.org>
12354 Unreviewed, rolling out r61459.
12355 http://trac.webkit.org/changeset/61459
12356 https://bugs.webkit.org/show_bug.cgi?id=40869
12358 Seems to have broken two tests on the Tiger buildbot:
12360 dom/html/level2/html/AppletsCollection.html
12361 plugins/qt-qwidget-plugin.html
12363 Anders wasn't on #webkit...
12365 * Plugins/Hosted/NetscapePluginHostManager.mm:
12366 (WebKit::NetscapePluginHostManager::spawnPluginHost):
12367 * Plugins/WebBasePluginPackage.h:
12368 * Plugins/WebBasePluginPackage.mm:
12369 (-[WebBasePluginPackage initWithPath:]):
12370 (-[WebBasePluginPackage getPluginInfoFromPLists]):
12371 (-[WebBasePluginPackage dealloc]):
12372 (-[WebBasePluginPackage name]):
12373 (-[WebBasePluginPackage path]):
12374 (-[WebBasePluginPackage filename]):
12375 (-[WebBasePluginPackage pluginDescription]):
12376 (-[WebBasePluginPackage setName:]):
12377 (-[WebBasePluginPackage setPath:]):
12378 (-[WebBasePluginPackage setPluginDescription:]):
12379 (-[WebBasePluginPackage description]):
12380 (-[WebBasePluginPackage isJavaPlugIn]):
12381 * Plugins/WebNetscapePluginPackage.mm:
12382 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
12383 (-[WebNetscapePluginPackage _tryLoad]):
12384 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
12385 * Plugins/WebPluginPackage.mm:
12386 (-[WebPluginPackage load]):
12388 2010-06-18 Anders Carlsson <andersca@apple.com>
12392 * Plugins/WebBasePluginPackage.mm:
12393 (-[WebBasePluginPackage isJavaPlugIn]):
12395 2010-06-18 Anders Carlsson <andersca@apple.com>
12397 Reviewed by Sam Weinig.
12399 Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
12400 https://bugs.webkit.org/show_bug.cgi?id=40869
12402 * Plugins/Hosted/NetscapePluginHostManager.mm:
12403 (WebKit::NetscapePluginHostManager::spawnPluginHost):
12404 * Plugins/WebBasePluginPackage.h:
12405 * Plugins/WebBasePluginPackage.mm:
12406 (-[WebBasePluginPackage initWithPath:]):
12407 (-[WebBasePluginPackage getPluginInfoFromPLists]):
12408 (-[WebBasePluginPackage dealloc]):
12409 (-[WebBasePluginPackage name]):
12410 (-[WebBasePluginPackage path]):
12411 (-[WebBasePluginPackage filename]):
12412 (-[WebBasePluginPackage pluginDescription]):
12413 (-[WebBasePluginPackage description]):
12414 (-[WebBasePluginPackage isJavaPlugIn]):
12415 * Plugins/WebNetscapePluginPackage.mm:
12416 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
12417 (-[WebNetscapePluginPackage _tryLoad]):
12418 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
12419 * Plugins/WebPluginPackage.mm:
12420 (-[WebPluginPackage load]):
12422 2010-06-18 Anders Carlsson <andersca@apple.com>
12424 Reviewed by Sam Weinig.
12426 Rename WebPluginPackage.m to make it an Objective-C++ file.
12428 * Plugins/WebPluginPackage.m: Removed.
12429 * Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m.
12431 2010-06-18 Anders Carlsson <andersca@apple.com>
12433 Reviewed by Sam Weinig.
12435 Get rid of the NSEnumerators from WebBasePluginPackage
12436 https://bugs.webkit.org/show_bug.cgi?id=40868
12438 * Plugins/WebBasePluginPackage.h:
12439 * Plugins/WebBasePluginPackage.mm:
12440 (-[WebBasePluginPackage MIMETypes]):
12441 (-[WebBasePluginPackage supportsExtension:]):
12442 (-[WebBasePluginPackage supportsMIMEType:]):
12443 * Plugins/WebPluginDatabase.mm:
12444 (-[WebPluginDatabase pluginForMIMEType:]):
12445 (-[WebPluginDatabase pluginForExtension:]):
12446 (-[WebPluginDatabase refresh]):
12447 (-[WebPluginDatabase _removePlugin:]):
12448 * WebCoreSupport/WebPlatformStrategies.mm:
12449 (WebPlatformStrategies::getPluginInfo):
12451 2010-06-18 Anders Carlsson <andersca@apple.com>
12453 Reviewed by Sam Weinig.
12455 Make WebCoreSystemInterface.h a C++ only header
12456 https://bugs.webkit.org/show_bug.cgi?id=40867
12458 * WebCoreSupport/WebSystemInterface.h:
12459 * WebCoreSupport/WebSystemInterface.m: Removed.
12460 * WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m.
12462 2010-06-18 Anders Carlsson <andersca@apple.com>
12464 Reviewed by Sam Weinig.
12466 Clean up WebPluginDatabase.mm
12467 https://bugs.webkit.org/show_bug.cgi?id=40866
12469 * Plugins/WebBasePluginPackage.h:
12470 * Plugins/WebBasePluginPackage.mm:
12471 (pathByResolvingSymlinksAndAliases):
12472 (-[WebBasePluginPackage initWithPath:]):
12473 Change an instance method into a static function.
12475 * Plugins/WebPluginDatabase.mm:
12476 (PluginPackageCandidates::PluginPackageCandidates):
12477 (PluginPackageCandidates::update):
12478 (PluginPackageCandidates::bestCandidate):
12479 Add a new PluginPackageCandidates class.
12481 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
12482 Use PluginPackageCandidates here.
12484 2010-06-18 Anders Carlsson <andersca@apple.com>
12488 * WebCoreSupport/WebPlatformStrategies.mm:
12490 2010-06-18 Anders Carlsson <andersca@apple.com>
12492 Reviewed by Darin Adler.
12494 Get rid of PluginDataMac.mm and use the plug-in strategy instead
12495 https://bugs.webkit.org/show_bug.cgi?id=40860
12497 * Plugins/WebBasePluginPackage.h:
12498 * WebCoreSupport/WebPlatformStrategies.h:
12499 * WebCoreSupport/WebPlatformStrategies.mm:
12500 (WebPlatformStrategies::createPluginStrategy):
12501 (WebPlatformStrategies::refreshPlugins):
12502 (WebPlatformStrategies::getPluginInfo):
12503 * WebCoreSupport/WebViewFactory.mm:
12505 2010-06-18 Anders Carlsson <andersca@apple.com>
12507 Reviewed by Dan Bernstein.
12509 Add stubbed out WebPlatformStrategies class to WebKit.
12510 https://bugs.webkit.org/show_bug.cgi?id=40851
12512 * WebCoreSupport/WebPlatformStrategies.h: Added.
12513 * WebCoreSupport/WebPlatformStrategies.mm: Added.
12514 (WebPlatformStrategies::initialize):
12515 (WebPlatformStrategies::WebPlatformStrategies):
12516 (WebPlatformStrategies::createPluginStrategy):
12517 * WebView/WebView.mm:
12518 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
12520 2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
12522 Reviewed by Adam Barth.
12524 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
12525 https://bugs.webkit.org/show_bug.cgi?id=39041
12527 * WebView/WebView.mm:
12528 (-[WebView _preferencesChangedNotification:]):
12530 2010-06-17 Darin Adler <darin@apple.com>
12532 Reviewed by Sam Weinig.
12534 Use adoptRef and create functions in more code paths
12535 https://bugs.webkit.org/show_bug.cgi?id=40760
12537 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer
12538 be an inline function.
12540 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12541 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
12542 Moved the call to addPluginInstance out of here.
12543 (WebKit::NetscapePluginInstanceProxy::create): Move it in here.
12544 This makes sure we call adoptRef on the new proxy before any caller
12547 2010-06-16 Eric Seidel <eric@webkit.org>
12549 Reviewed by Adam Barth.
12551 Enable HTML5 Parser in Safari on Mac
12552 https://bugs.webkit.org/show_bug.cgi?id=40739
12554 The HTML5 parser is probably off on all webkit ports.
12555 We should either flip the meaning of the default so that
12556 "false" means HTML5 on all ports, or we'll have to write
12557 more code like this for all the other ports.
12559 * WebView/WebPreferences.mm:
12560 (+[WebPreferences initialize]):
12562 2010-06-15 Mark Rowe <mrowe@apple.com>
12564 Reviewed by Sam Weinig.
12566 Don't leak WebGeolocationPositionInternal and GeolocationPosition instances for every WebGeolocationPosition created.
12568 * WebView/WebGeolocationPosition.mm:
12569 (-[WebGeolocationPosition dealloc]): Implement -dealloc and release our WebGeolocationPositionInternal instance.
12571 2010-06-10 Yuzo Fujishima <yuzo@google.com>
12573 Reviewed by Shinichiro Hamaji.
12575 Implement render style selection for pages to support CSS3 Paged Media.
12576 https://bugs.webkit.org/show_bug.cgi?id=35961
12578 * Misc/WebCoreStatistics.h:
12579 * Misc/WebCoreStatistics.mm:
12580 (-[WebFrame pageProperty:propertyName:]):
12582 2010-06-15 Darin Adler <darin@apple.com>
12584 Reviewed by Adam Barth.
12586 Move functions out of Frame class that were marked "move to Chrome"
12587 https://bugs.webkit.org/show_bug.cgi?id=39636
12589 * WebView/WebView.mm:
12590 (-[WebView shouldClose]): Call shouldClose on FrameLoader instead of
12591 going through Frame.
12593 2010-06-15 Anders Carlsson <andersca@apple.com>
12595 Reviewed by Dan Bernstein.
12597 Remove getPluginInfoFromBundleAndMIMEDictionary:
12599 * Plugins/WebBasePluginPackage.mm:
12601 2010-06-15 Anders Carlsson <andersca@apple.com>
12603 Reviewed by Dan Bernstein.
12605 Fold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller.
12607 * Plugins/WebBasePluginPackage.mm:
12608 (-[WebBasePluginPackage getPluginInfoFromPLists]):
12610 2010-06-11 Simon Fraser <simon.fraser@apple.com>
12612 Reviewed by Darin Adler.
12614 <rdar://problem/8084721> Pages using accelerated compositing fail to update correctly in Carbon apps
12616 The run loop observer used to commit compositing layer changes does not do
12617 updates if [window viewsNeedDisplay] is true, because this indicates that a delayed window
12618 update is pending (added in r58623).
12620 However, Carbon apps don't use the NSWindow updating mechanism, so [window viewsNeedDisplay] always returns YES.
12621 This caused us to never sync compositing layers.
12623 So detect if the current window is wrapping a carbon window, and in that case consult the root
12624 HIView to detect if display is pending.
12626 * WebView/WebView.mm:
12627 (layerSyncRunLoopObserverCallBack):
12629 2010-06-15 Dan Bernstein <mitz@apple.com>
12631 Reviewed by John Sullivan.
12633 <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email
12635 Test: platform/mac/editing/input/NSBackgroundColor-transparent.html
12637 r50796 changed the initial background color from invalid to transparent. As a result,
12638 NSAttributedStrings returned from +_web_attributedStringFromRange started including the
12639 NSBackgroundColor attribute, with a transparent color as the value. This caused problems for
12640 components in the system that ignore the alpha component, turning the color into opaque black.
12642 * Misc/WebNSAttributedStringExtras.mm:
12643 (+[NSAttributedString _web_attributedStringFromRange:]): Change to not include the background
12644 and foreground color attributes if the color are transparent.
12646 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
12648 Reviewed by Pavel Feldman.
12650 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
12651 data from inspected page to WebInspector as JSON string via http. The native
12652 serialization to JSON string is supported by InspectorValue's classes. This patch
12653 has the implementation of sendMessageToFrontend function. WebKit version of it still
12654 uses ScriptFunctionCall and will be switched to another transport a little bit later.
12655 https://bugs.webkit.org/show_bug.cgi?id=40134
12657 * WebCoreSupport/WebInspectorClient.h:
12658 * WebCoreSupport/WebInspectorClient.mm:
12659 (WebInspectorClient::WebInspectorClient):
12660 (WebInspectorClient::openInspectorFrontend):
12662 2010-06-10 David Hyatt <hyatt@apple.com>
12664 Reviewed by John Sullivan.
12666 https://bugs.webkit.org/show_bug.cgi?id=40441, back out the original fix for 29601, since it has broken continuous
12667 wheel delta values.
12669 * WebView/WebDynamicScrollBarsView.mm:
12670 (-[WebDynamicScrollBarsView scrollWheel:]):
12672 2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
12674 Unreviewed, rolling out r60889.
12675 http://trac.webkit.org/changeset/60889
12676 https://bugs.webkit.org/show_bug.cgi?id=40365
12678 gtk bot has some kind of memory corruption (Requested by
12679 loislo on #webkit).
12681 * WebCoreSupport/WebInspectorClient.h:
12682 * WebCoreSupport/WebInspectorClient.mm:
12683 (WebInspectorClient::WebInspectorClient):
12684 (WebInspectorClient::openInspectorFrontend):
12685 (-[WebInspectorWindowController destroyInspectorView]):
12687 2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
12689 Reviewed by Pavel Feldman.
12691 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
12692 data from inspected page to WebInspector as JSON string via http. The native
12693 serialization to JSON string is supported by InspectorValue's classes. This patch
12694 has the implementation of sendMessageToFrontend function. WebKit version of it still
12695 uses ScriptFunctionCall and will be switched to another transport a little bit later.
12696 https://bugs.webkit.org/show_bug.cgi?id=40134
12698 * WebCoreSupport/WebInspectorClient.h:
12699 * WebCoreSupport/WebInspectorClient.mm:
12700 (WebInspectorClient::WebInspectorClient):
12701 (WebInspectorClient::openInspectorFrontend):
12703 2010-06-08 Mark Rowe <mrowe@apple.com>
12705 Reviewed by Adele Peterson.
12707 <rdar://problem/8072136> REGRESSION (r56051): Inspect Element context menu does nothing in applications linked against 10.4 SDK
12709 * WebCoreSupport/WebContextMenuClient.mm:
12710 (fixMenusReceivedFromOldClients): Fix up the tag on the Inspect Element menu item. This ensures that even if the
12711 context menu layout doesn't match our expectations that the menu item will continue to trigger the web inspector.
12713 2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
12715 Reviewed by Ojan Vafai and Darin Adler.
12717 Refactor platform dependent editing behavior code out of Settings
12718 https://bugs.webkit.org/show_bug.cgi?id=39854
12720 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
12721 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
12723 * WebView/WebFrame.mm:
12725 * WebView/WebFrameInternal.h:
12726 * WebView/WebView.mm:
12727 (-[WebView _preferencesChangedNotification:]):
12729 2010-06-06 MORITA Hajime <morrita@google.com>
12731 Unreviewd, follow up to r60820
12733 https://bugs.webkit.org/show_bug.cgi?id=40219
12734 [Mac] ENABLE_METER_TAG should be enabled
12736 Added ENABLE_METER_TAG.
12738 * Configurations/FeatureDefines.xcconfig:
12740 2010-06-06 Gavin Barraclough <barraclough@apple.com>
12742 Reviewed by Sam Weinig.
12744 Bug 40214 - Clean up error construction / throwing in JSC.
12746 The one egregious insanity here is that creating an error requires
12747 a VM-entry-esqe-host call (the string argument is wrapped as a JS
12748 object & pushed on the RegisterFile, then unwrapped back to a
12749 UString). Changing this also means you only require a global
12750 object, not an ExecState, to create an error.
12752 The methods to create error objects are also parameterized
12753 requiring a switch on the type, which can be made cleaner and
12754 faster by moving to a separate method per error type. Code to add
12755 divot information to error had been duplicated, and is coalesced
12756 back into a single function.
12758 Convenience methods added to create & throw type & syntax error
12759 with a default error message, since this is a common case.
12761 Also, errors are currently thrown either using
12762 "throwError(exec, error)" or "exec->setException(error)" - unify
12763 on the former, since this is more commonly used. Add
12764 "throwVMError(exec, error)" equivalents, as a convenience for
12765 cases where the result was being wrapped in "JSValue::encode(...)".
12767 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12768 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
12769 * Plugins/Hosted/ProxyInstance.mm:
12770 (WebKit::ProxyInstance::invokeMethod):
12772 2010-06-02 Gavin Barraclough <barraclough@apple.com>
12774 Reviewed by Oliver Hunt.
12776 Bug 40094 - The return type of NativeFunction should be EncodedJSValue
12777 On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not.
12779 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
12780 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12781 (WebKit::NetscapePluginInstanceProxy::invoke):
12783 2010-06-02 Sterling Swigart <sswigart@google.com>
12785 Reviewed by David Levin.
12787 Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
12788 https://bugs.webkit.org/show_bug.cgi?id=39906
12790 * Configurations/FeatureDefines.xcconfig:
12792 2010-06-01 David Hyatt <hyatt@apple.com>
12794 Reviewed by Anders Carlsson.
12796 Add a preference for paginating during layout (the new model for computing page breaks).
12798 * WebView/WebPreferenceKeysPrivate.h:
12799 * WebView/WebPreferences.mm:
12800 (-[WebPreferences paginateDuringLayoutEnabled]):
12801 (-[WebPreferences setPaginateDuringLayoutEnabled:]):
12802 * WebView/WebPreferencesPrivate.h:
12803 * WebView/WebView.mm:
12804 (-[WebView _preferencesChangedNotification:]):
12806 2010-06-01 Kevin Decker <kdecker@apple.com>
12808 Reviewed by Simon Fraser.
12810 https://bugs.webkit.org/show_bug.cgi?id=40025
12811 <rdar://problem/8046273> All Flash content crashes after installing CS5 Design Premium.
12813 * Plugins/WebBaseNetscapePluginView.mm:
12814 (-[WebBaseNetscapePluginView supportsSnapshotting]): Do not support snapshotting Flash 10.1 if
12815 the version is less than 10.1.53.60.
12817 2010-06-01 Alexey Proskuryakov <ap@apple.com>
12819 Reviewed by Sam Weinig.
12821 https://bugs.webkit.org/show_bug.cgi?id=39434
12822 REGRESSION (r59811): Geolocation callbacks cannot be created
12824 Removing unused WebGeolocationMock.
12826 * WebCoreSupport/WebGeolocationMock.mm: Removed.
12827 * WebCoreSupport/WebGeolocationMockPrivate.h: Removed.
12830 2010-05-30 Darin Adler <darin@apple.com>
12832 Reviewed by Sam Weinig.
12834 Make more HTML DOM members private, especially constructors, third and final batch
12835 https://bugs.webkit.org/show_bug.cgi?id=39916
12837 * WebView/WebHTMLRepresentation.mm:
12838 (-[WebHTMLRepresentation elementWithName:inForm:]): Use the new HTMLFormElement
12839 function, associatedElements, rather than getting directly at a data member
12840 named formElements.
12841 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
12843 2010-05-28 Geoffrey Garen <ggaren@apple.com>
12845 Reviewed by Sam Weinig, Gavin Barraclough, Oliver Hunt.
12847 Simplified the host calling convention.
12849 PART ONE: Functional code changes.
12853 PART TWO: Global search and replace.
12855 In the areas below, I used global search-and-replace to change
12856 (ExecState*, JSObject*, JSValue, const ArgList&) => (ExecState*)
12857 args.size() => exec->argumentCount()
12858 args.at(i) => exec->argument(i)
12860 * Plugins/Hosted/ProxyInstance.h:
12861 * Plugins/Hosted/ProxyInstance.mm:
12862 (WebKit::ProxyInstance::invoke):
12863 (WebKit::ProxyInstance::invokeMethod):
12864 (WebKit::ProxyInstance::invokeDefaultMethod):
12866 2010-05-27 Beth Dakin <bdakin@apple.com>
12868 Reviewed by Simon Fraser.
12870 Change z-component to 1.
12872 * WebView/WebHTMLView.mm:
12873 (-[WebHTMLView viewDidMoveToWindow]):
12874 (-[WebHTMLView attachRootLayer:]):
12876 2010-05-26 Simon Fraser <simon.fraser@apple.com>
12878 Reviewed by Beth Dakin and Darin Adler.
12880 Fix for <rdar://problem/7464703> HiDPI: [Layers] Compositing layers
12881 do not scale properly when running with a resolution independent
12884 Apply the userSpaceScaleFactor as a scale on the layerHostingView.
12886 * WebView/WebHTMLView.mm:
12887 (-[WebHTMLView viewDidMoveToWindow]):
12888 (-[WebHTMLView attachRootLayer:]):
12890 2010-05-25 Alexey Proskuryakov <ap@apple.com>
12892 Reviewed by Darin Adler.
12894 https://bugs.webkit.org/show_bug.cgi?id=39621
12895 <rdar://problem/8009738> Extreme memory growth on DOM Hanoi test
12897 Removed formStateDidChange support, which is not needed by any client.
12899 * WebCoreSupport/WebChromeClient.h:
12900 (WebChromeClient::formStateDidChange):
12901 * WebCoreSupport/WebChromeClient.mm:
12902 * WebView/WebUIDelegatePrivate.h:
12904 2010-05-25 Brady Eidson <beidson@apple.com>
12906 Reviewed by Darin Adler.
12908 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms)
12909 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486
12911 * Storage/WebDatabaseManager.mm:
12912 (WebKitInitializeDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on
12913 an already created tracker that already has its origins populated.
12915 2010-05-24 Darin Adler <darin@apple.com>
12917 Reviewed by Eric Seidel.
12919 Move view-related functions from Frame to FrameView
12920 https://bugs.webkit.org/show_bug.cgi?id=39366
12922 * WebView/WebView.mm:
12923 (-[WebView _setZoomMultiplier:isTextOnly:]): Call function on FrameView.
12924 (-[WebView setEditable:]): Get rid of call to empty function,
12925 removeEditingStyleFromBodyElement.
12927 2010-05-21 David Hyatt <hyatt@apple.com>
12929 Reviewed by Dan Bernstein.
12931 https://bugs.webkit.org/show_bug.cgi?id=39420
12933 Make sure everyone who needs to is using visitedDependentColor rather than accessing styles
12936 * Misc/WebNSAttributedStringExtras.mm:
12937 (+[NSAttributedString _web_attributedStringFromRange:]):
12938 * WebView/WebFrame.mm:
12939 (-[WebFrame _bodyBackgroundColor]):
12941 2010-05-21 Oliver Hunt <oliver@apple.com>
12943 Reviewed by Geoffrey Garen.
12945 All callable objects should have a global object reference
12946 https://bugs.webkit.org/show_bug.cgi?id=39495
12948 Update the plugin proxy to handle the need for global object.
12950 * Plugins/Hosted/ProxyInstance.mm:
12951 (WebKit::ProxyInstance::newRuntimeObject):
12952 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
12953 (WebKit::ProxyInstance::getMethod):
12954 * Plugins/Hosted/ProxyRuntimeObject.h:
12955 * Plugins/Hosted/ProxyRuntimeObject.mm:
12956 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
12958 2010-05-21 Steve Block <steveblock@google.com>
12960 Reviewed by Jeremy Orlow.
12962 Add DeviceOrientation and DeviceOrientationClient
12963 https://bugs.webkit.org/show_bug.cgi?id=39479
12965 * WebView/WebView.mm:
12966 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
12968 2010-05-20 Mike Thole <mthole@apple.com>
12970 Reviewed by Dave Hyatt.
12972 When using a scale factor > 1, scrollbars sometimes appear when not necessary
12973 https://bugs.webkit.org/show_bug.cgi?id=39458
12975 * WebView/WebDynamicScrollBarsView.mm:
12976 (-[WebDynamicScrollBarsView updateScrollers]): Round up non-integral sizes from AppKit
12977 so that they can be compared against the integral document size.
12979 2010-05-20 Kevin Decker <kdecker@apple.com>
12981 Reviewed by Anders Carlsson.
12983 https://bugs.webkit.org/show_bug.cgi?id=39441
12984 <rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click
12985 <rdar://problem/7986109> Youtube video controller UI entirely missing
12986 <rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region)
12988 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
12989 (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and
12990 it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale
12991 factors this assumption is false. Accordingly we now convert to the window contentView
12992 coordinate system when computing bounds in "window" and the visible rect.
12993 * Plugins/WebNetscapePluginView.mm:
12994 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto.
12996 2010-05-20 Steve Block <steveblock@google.com>
12998 Reviewed by Jeremy Orlow.
13000 Provide bindings for DeviceOrientation
13001 https://bugs.webkit.org/show_bug.cgi?id=39210
13003 Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.
13005 * Configurations/FeatureDefines.xcconfig:
13007 2010-05-20 Martin Robinson <mrobinson@webkit.org>
13009 Reviewed by Ojan Vafai.
13011 Expose the editing behavior setting in DRT to test all editing code paths
13012 https://bugs.webkit.org/show_bug.cgi?id=38603
13014 * WebView/WebFrame.mm:
13016 * WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum.
13017 * WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting.
13018 * WebView/WebPreferences.mm:
13019 (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style.
13020 (-[WebPreferences editingBehavior]): Added.
13021 (-[WebPreferences setEditingBehavior:]): Added.
13022 * WebView/WebPreferencesPrivate.h: Added the new API points to the private API.
13023 * WebView/WebView.mm:
13024 (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting.
13026 2010-05-19 Anders Carlsson <andersca@apple.com>
13028 Reviewed by Kevin Decker and Simon Fraser.
13030 <rdar://problem/8004528>
13031 REGRESSION: Coordinate system for Core Animation NPAPI plug-ins is flipped with accelerated compositing turned on
13033 When needed, create a new CALayer and set it's geometry to be flipped. Add the plug-in layer as a sublayer and then return
13034 the newly created layer.
13036 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
13037 (-[WebHostedNetscapePluginView createPlugin]):
13038 * Plugins/WebNetscapePluginView.mm:
13039 (-[WebNetscapePluginView createPlugin]):
13041 2010-05-18 Tony Chang <tony@chromium.org>
13043 Reviewed by Darin Adler.
13045 https://bugs.webkit.org/show_bug.cgi?id=24943
13046 Command-B and Command-I do not generate keydown events in contentEditable regions.
13048 Manual test because performKeyEquivalent is not called by DRT.
13050 Test: manual-tests/style-keypress-events.html
13052 * WebView/WebHTMLView.mm:
13053 (-[WebHTMLView performKeyEquivalent:]): Move style key handling until after webcore gets a chance to handle the event
13055 2010-05-18 Daniel Cheng <dcheng@chromium.org>
13057 Reviewed by Darin Adler, Jian Li.
13059 DragData::asURL() shouldn't do file validity checks
13060 https://bugs.webkit.org/show_bug.cgi?id=38711
13062 Change [NSPasteboard _web_bestURL] to still return a file URL for paths
13063 that don't exist. Callers who care about the existence of the file or
13064 whether or not it is a directory should check themselves when they
13065 want to use the file. The directory check has been left in for now,
13066 since the Mac implementation of ResourceHandle, which uses this function
13067 indirectly via DragController::performDrag) handles directories somewhat
13068 non-intuitively: it opens the parent directory in the Finder, rather
13069 than opening the directory itself.
13071 * Misc/WebNSPasteboardExtras.mm:
13072 (-[NSPasteboard _web_bestURL]):
13074 2010-05-18 Eric Seidel <eric@webkit.org>
13076 Reviewed by Adam Barth (and Maciej Stachowiak).
13078 Make it possible to enable the new HTML5Tokenizer for testing
13079 https://bugs.webkit.org/show_bug.cgi?id=39275
13081 Expose the WebCore::Settings::html5ParserEnabled as a private WebKit setting.
13083 * WebView/WebPreferenceKeysPrivate.h:
13084 * WebView/WebPreferences.mm:
13085 (-[WebPreferences html5ParserEnabled]):
13086 (-[WebPreferences setHTML5ParserEnabled:]):
13087 * WebView/WebPreferencesPrivate.h:
13088 * WebView/WebView.mm:
13089 (-[WebView _preferencesChangedNotification:]):
13091 2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
13093 Unreviewed, rolling out r59652.
13094 http://trac.webkit.org/changeset/59652
13095 https://bugs.webkit.org/show_bug.cgi?id=39268
13097 file-input-files-access test is broken on Mac (Requested by
13098 dcheng on #webkit).
13100 * Misc/WebNSPasteboardExtras.mm:
13101 (-[NSPasteboard _web_bestURL]):
13103 2010-05-17 Daniel Cheng <dcheng@chromium.org>
13105 Reviewed by Darin Adler.
13107 DragData::asURL() shouldn't do file validity checks
13108 https://bugs.webkit.org/show_bug.cgi?id=38711
13110 Change [NSPasteboard _web_bestURL] to still return a file URL for paths
13111 that don't exist. Callers who care about the existence of the file or
13112 whether or not it is a directory should check themselves when they
13113 want to use the file. The directory check has been left in for now,
13114 since the Mac implementation of ResourceHandle, which uses this function
13115 indirectly via DragController::performDrag) handles directories somewhat
13116 non-intuitively: it opens the parent directory in the Finder, rather
13117 than opening the directory itself.
13119 * Misc/WebNSPasteboardExtras.mm:
13120 (-[NSPasteboard _web_bestURL]):
13122 2010-05-14 Stephanie Lewis <slewis@apple.com>
13124 Rubber-stamped by Mark Rowe.
13126 Update order files.
13130 2010-05-13 Timothy Hatcher <timothy@apple.com>
13132 Allow reporting exceptions that occur when using JavaScriptCore APIs
13133 to the Web Inspector.
13135 <rdar://problem/7975410>
13137 Reviewed by Sam Weinig.
13139 * WebView/WebView.mm:
13140 (+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
13141 that the global object is a DOMWindow.
13142 * WebView/WebViewPrivate.h: Added _reportException:inContext:.
13144 2010-05-13 Alexey Proskuryakov <ap@apple.com>
13146 Reviewed by Darin Adler.
13148 https://bugs.webkit.org/show_bug.cgi?id=39089
13149 <rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode
13151 Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
13152 investigate a more extensible solution when there are more, and we know what the
13153 typical restictions are.
13155 * Misc/WebNSURLExtras.mm:
13156 (allCharactersAllowedByTLDRules):
13157 (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
13159 2010-05-12 Simon Fraser <simon.fraser@apple.com>
13161 Reviewed by David Hyatt.
13163 Composited plug-ins can cause missed painting
13164 https://bugs.webkit.org/show_bug.cgi?id=39033
13165 <rdar://problem/7972478>
13167 Eagerly enable compositing mode via the enclosing FrameView when the plug-in tells us it wants
13170 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
13171 (-[WebHostedNetscapePluginView createPlugin]):
13172 * Plugins/WebNetscapePluginView.mm:
13173 (-[WebNetscapePluginView createPlugin]):
13175 2010-05-12 Jer Noble <jer.noble@apple.com>
13177 Reviewed by Darin Adler.
13179 Bug 38689: #34005 will break fullscreen video playback
13180 https://bugs.webkit.org/show_bug.cgi?id=38689
13182 Use the new definition of PlatformMedia to check the actual type
13183 returned by MediaPlayer.
13185 * WebView/WebVideoFullscreenController.mm:
13186 (-[WebVideoFullscreenController windowDidLoad]):
13188 2010-05-11 Mark Rowe <mrowe@apple.com>
13192 In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
13193 The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
13194 that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
13195 in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
13196 and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
13197 function in WebCore being called.
13199 We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
13200 other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
13203 * Configurations/FeatureDefines.xcconfig:
13205 2010-05-10 Simon Fraser <simon.fraser@apple.com>
13207 Reviewed by Anders Carlsson.
13209 Allow compositing layers to be connected across iframe boundaries on Mac
13210 https://bugs.webkit.org/show_bug.cgi?id=38856
13212 When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers"
13213 flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused
13214 content to show up in both compositing layers, and the painted background inside the iframe.
13216 Fix by taking the flattening state from the parent frame, if there is one. For the root
13217 frame, we continue to look to see if we're painting into a bitmap.
13219 * WebView/WebFrame.mm:
13220 (-[WebFrame _drawRect:contentsOnly:]):
13222 2010-05-10 Timothy Hatcher <timothy@apple.com>
13224 Fix a crash when closing a WebView while the Web Inspector is open.
13226 <rdar://problem/7966830>
13228 Reviewed by Mark Rowe.
13230 * WebCoreSupport/WebInspectorClient.mm:
13231 (-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.
13232 * WebView/WebView.mm:
13233 (-[WebView _close]): Null out _private->page before deleting the page, so code called
13234 during destruction don't access a half deleted Page object.
13236 2010-05-10 Anders Carlsson <andersca@apple.com>
13238 Unbreak the world. (Fix Mac builds).
13240 * Plugins/Hosted/WebKitPluginHostTypes.h:
13242 2010-05-10 Anders Carlsson <andersca@apple.com>
13244 Reviewed by Simon Fraser.
13246 Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
13247 use accelerated compositing and not layer backed views.
13249 * Plugins/Hosted/WebKitPluginHostTypes.h:
13251 2010-05-07 Anders Carlsson <andersca@apple.com>
13253 Reviewed by Sam Weinig and Simon Fraser.
13255 <rdar://problem/7947356>
13256 QT Plug-in in hardware-accelerated WebKit is missing the controller
13258 Replace the useSoftwareRenderer boolean with an enum that lets the plug-in host opt into using a layer
13259 backed NSView instead of inserting the layer into the WebCore layer hierarchy.
13261 * Plugins/Hosted/NetscapePluginHostManager.mm:
13262 (WebKit::NetscapePluginHostManager::instantiatePlugin):
13263 * Plugins/Hosted/NetscapePluginHostProxy.mm:
13264 (WKPCInstantiatePluginReply):
13265 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
13266 (WebKit::NetscapePluginInstanceProxy::rendererType):
13267 (WebKit::NetscapePluginInstanceProxy::setRendererType):
13268 (WebKit::NetscapePluginInstanceProxy::InstantiatePluginReply::InstantiatePluginReply):
13269 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13270 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
13271 Replace the useSoftwareRenderer boolean everywhere with the RendererType enum.
13273 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
13274 (-[WebHostedNetscapePluginView createPlugin]):
13275 Only go into full compositing mode when the renderer type returned is UseAcceleratedCompositing.
13276 Otherwise, use a layer backed NSView.
13278 * Plugins/Hosted/WebKitPluginHostTypes.h:
13279 Add a RendererType enum.
13281 2010-05-06 Anders Carlsson <andersca@apple.com>
13283 Reviewed by Darin Adler and Dan Bernstein..
13285 REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
13286 https://bugs.webkit.org/show_bug.cgi?id=38698
13287 <rdar://problem/7942075>
13289 When the plug-in database is initialized, we will register all the MIME types it supports with the global
13290 WebView dictionary. When plug-ins are disabled for a single web view, the MIME types still need to be
13291 in the global mapping (because other web views might still have plug-ins enabled).
13293 Prior to r51617 we would always look at the plug-in database to determine that the MIME type belongs to a
13294 plug-in, but now we won't even touch the plug-in database when plug-ins are disabled.
13296 In order to fix this, a new set of registered MIME types that are known to be plug-ins is added. When
13297 +[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:] is called and allowingPlugins is FALSE
13298 we check if the MIME type is a known plug-in MIME type and return false in that case.
13300 * Plugins/WebPluginDatabase.mm:
13301 (-[WebPluginDatabase refresh]):
13302 (-[WebPluginDatabase _removePlugin:]):
13303 * WebView/WebView.mm:
13304 (knownPluginMIMETypes):
13305 (+[WebView _registerPluginMIMEType:]):
13306 (+[WebView _unregisterPluginMIMEType:]):
13307 (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
13308 * WebView/WebViewInternal.h:
13310 2010-05-06 Dan Bernstein <mitz@apple.com>
13312 Reviewed by Simon Fraser.
13314 <rdar://problem/7951285> REGRESSION (r58847): Composited iframe content obscures Safari's application chrome
13316 Fixed this other regression from r58847. The regression was caused by overriding -visibleRect to
13317 return the WebClipView’s full bounds. AppKit uses -visibleRect to determine the geometry
13318 of the surface for the child WebFrameView. The fix is to restrict the special behavior of
13319 -[WebClipView visibleRect] to when AppKit is consulting it for the purpose of invalidating
13320 areas while scrolling.
13322 * WebView/WebClipView.h:
13323 * WebView/WebClipView.mm:
13324 (-[WebClipView visibleRect]): If the WebClipView is not scrolling, always return
13325 [super visibleRect].
13326 (-[WebClipView _immediateScrollToPoint:]): Override this internal NSClipView method
13327 to set a flag telling -visibleRect that the view is scrolling.
13328 * WebView/WebView.mm:
13329 (layerSyncRunLoopObserverCallBack): Ensure that screen updates, disabled by AppKit
13330 when it thinks an upcoming window flush will re-enable them, are enabled here in
13331 case the -setNeedsDisplayInRect: override has prevented the window from needing to be
13334 2010-05-06 Steve Block <steveblock@google.com>
13336 Reviewed by Eric Seidel.
13338 MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
13339 https://bugs.webkit.org/show_bug.cgi?id=38544
13341 * WebCoreSupport/WebFrameLoaderClient.h:
13342 * WebCoreSupport/WebFrameLoaderClient.mm:
13344 2010-05-05 Dan Bernstein <mitz@apple.com>
13346 Reviewed by Mark Rowe.
13348 Fixed a crash when closing Top Sites after r58847.
13350 * WebView/WebFrameView.mm:
13351 (-[WebFrameView webFrame]): Null-check _private.
13353 2010-05-05 Dan Bernstein <mitz@apple.com>
13355 Rubber-stamped by Mark Rowe.
13357 Fixed test crashes after r58847.
13359 * WebView/WebHTMLView.mm:
13360 (setNeedsDisplayInRect): Null-check the frame.
13362 2010-05-05 Dan Bernstein <mitz@apple.com>
13364 Reviewed by Simon Fraser.
13366 <rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
13367 https://bugs.webkit.org/show_bug.cgi?id=38427
13369 * WebView/WebClipView.m: Renamed to WebClipView.mm.
13370 * WebView/WebClipView.mm:
13371 (-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in
13372 composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to
13373 AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy.
13374 Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping.
13375 * WebView/WebHTMLView.mm:
13376 (setCursor): Style tweak.
13377 (setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:],
13378 so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation
13379 is routed back through the WebCore FrameView, which propagates it to the layer.
13380 (+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in.
13381 (-[WebHTMLView visibleRect]): Removed whitespace.
13382 * WebView/WebView.mm:
13383 (layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout
13384 in preparation for the displaying of compositing layers.
13386 2010-05-05 John Sullivan <sullivan@apple.com>
13388 <rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened
13390 Reviewed by Mark Rowe.
13392 * WebView/WebView.mm:
13393 (+[WebView closeAllWebViews]):
13394 Make copy of allWebViewsSet to avoid mutating it while iterating through it.
13396 2010-05-04 Simon Fraser <simon.fraser@apple.com>
13398 Reviewed by Dan Bernstein.
13400 Improve check for drawing into the window that was added in r58623
13401 https://bugs.webkit.org/show_bug.cgi?id=38562
13403 Rather than assuming that any non-bitmap context is the window's context,
13404 compare the current graphics context with -[NSWindow graphicsContext] to
13405 determine that we're drawing into the window.
13407 * WebView/WebHTMLView.mm:
13408 (-[WebHTMLView drawRect:]):
13410 2010-05-04 Ada Chan <adachan@apple.com>
13412 Reviewed by David Kilzer.
13414 https://bugs.webkit.org/show_bug.cgi?id=38555
13416 Small code refactoring: move the logic to figure out the path to the
13417 databases directory to another method.
13419 * Storage/WebDatabaseManager.mm:
13420 (databasesDirectoryPath):
13421 (WebKitInitializeDatabasesIfNecessary):
13423 2010-05-04 Beth Dakin <bdakin@apple.com>
13425 Reviewed by Mike Thole.
13427 Fix for <rdar://problem/7818509> Crash occurs when exiting Safari
13429 We can avoid this crash if we call [self _removeFromAllWebViewsSet]
13430 even in the case when we are doing a fastDocumentTeardown. This is
13431 a much safer approach.
13432 * WebView/WebView.mm:
13433 (-[WebView _close]):
13435 2010-05-03 Abhishek Arya <inferno@chromium.org>
13437 Reviewed by Adam Barth.
13439 Add support for controlling clipboard access from javascript.
13440 Clipboard access from javascript is disabled by default.
13441 https://bugs.webkit.org/show_bug.cgi?id=27751
13443 * WebView/WebPreferenceKeysPrivate.h:
13444 * WebView/WebPreferences.mm:
13445 (+[WebPreferences initialize]):
13446 (-[WebPreferences javaScriptCanAccessClipboard]):
13447 (-[WebPreferences setJavaScriptCanAccessClipboard:]):
13448 * WebView/WebPreferencesPrivate.h:
13449 * WebView/WebView.mm:
13450 (-[WebView _preferencesChangedNotification:]):
13452 2010-05-03 Jens Alfke <snej@chromium.org>
13454 Reviewed by Darin Fisher.
13456 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
13457 https://bugs.webkit.org/show_bug.cgi?id=38397
13459 No tests (functionality is exposed only through native WebKit API.)
13461 * WebCoreSupport/WebFrameLoaderClient.h:
13462 (WebFrameLoaderClient::dispatchWillSendSubmitEvent):
13464 2010-04-30 Simon Fraser <simon.fraser@apple.com>
13466 Reviewed by Dan Bernstein.
13468 <rdar://problem/7477071> REGRESSION: Bad flicker when wheel-scrolling Google Maps, iPad gallery and other sites
13470 Sites that frequently toggle content in and out of compositing layers (like http://www.tumblr.com/boothed)
13471 can cause flickering because of unsychronized compositing layer and view-based updates. There were two
13474 1. On SnowLeopard, AppKit can throttle window updates, thus breaking an assumption that
13475 NSView drawing will happen on the runloop cycle after a repaint. This provided a window
13476 for the layerSyncRunLoopObserver to fire and commit layer changes too early.
13478 Fix this by having the layerSyncRunLoopObserver in WebView check to see if a display is pending,
13479 and not commit layer changes in that case. We'll commit layer changes later when we
13482 2. The change in r49269 was wrong; it was attempting to fix an issue that was actually caused
13483 by -drawRects: coming in for page snapshots. The correct approach is to avoid hitting the
13484 synchronization and update disabling code in WebHTMLView for draws that are not to the screen.
13486 * WebView/WebHTMLView.mm:
13487 (-[WebHTMLView drawRect:]):
13488 * WebView/WebView.mm:
13489 (layerSyncRunLoopObserverCallBack):
13490 (-[WebView _scheduleCompositingLayerSync]):
13492 2010-04-30 Anders Carlsson <andersca@apple.com>
13494 Part of the previous part (forgot to save).
13496 * Plugins/WebNetscapePluginView.mm:
13497 (-[WebNetscapePluginView stopTimers]):
13498 (-[WebNetscapePluginView startTimers]):
13499 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
13500 (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
13501 (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]):
13502 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
13503 (-[WebNetscapePluginView unscheduleTimer:]):
13504 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
13505 (-[WebNetscapePluginView setVariable:forURL:value:length:]):
13507 2010-04-30 Anders Carlsson <andersca@apple.com>
13509 Reviewed by Darin Adler.
13511 Use C99 integer types in more places.
13513 * Plugins/WebNetscapePluginView.mm:
13516 2010-04-30 Anders Carlsson <andersca@apple.com>
13520 * Plugins/WebBaseNetscapePluginStream.h:
13521 * Plugins/WebBaseNetscapePluginStream.mm:
13522 (WebNetscapePluginStream::startStream):
13524 2010-04-30 Anders Carlsson <andersca@apple.com>
13526 Another 32-bit build fix.
13528 * Plugins/WebNetscapePluginView.mm:
13529 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
13531 2010-04-30 Anders Carlsson <andersca@apple.com>
13533 Fix 32-bit build (again).
13535 * Plugins/WebNetscapeContainerCheckContextInfo.h:
13536 * Plugins/WebNetscapeContainerCheckContextInfo.mm:
13537 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
13538 (-[WebNetscapeContainerCheckContextInfo checkRequestID]):
13539 (-[WebNetscapeContainerCheckContextInfo callback]):
13540 * Plugins/WebNetscapePluginPackage.h:
13542 2010-04-30 Anders Carlsson <andersca@apple.com>
13546 * Plugins/WebNetscapeContainerCheckContextInfo.h:
13547 * Plugins/WebNetscapeContainerCheckContextInfo.mm:
13548 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
13549 * Plugins/WebNetscapeContainerCheckPrivate.h:
13550 * Plugins/WebNetscapePluginPackage.mm:
13551 (functionPointerForTVector):
13552 * Plugins/WebNetscapePluginView.mm:
13553 (PluginTimer::PluginTimer):
13554 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
13555 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
13557 2010-04-30 Anders Carlsson <andersca@apple.com>
13559 Reviewed by Timothy Hatcher.
13561 Next step towards fixing
13563 https://bugs.webkit.org/show_bug.cgi?id=20784
13564 move npapi.h to C99 integer types
13566 Use the C99 types everywhere. The "old" types are still around but will be removed
13567 in a subsequent commit.
13569 * Plugins/WebBaseNetscapePluginStream.h:
13570 * Plugins/WebBaseNetscapePluginStream.mm:
13571 (WebNetscapePluginStream::deliverData):
13572 * Plugins/WebNetscapePluginView.h:
13573 * Plugins/WebNetscapePluginView.mm:
13574 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
13575 (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]):
13576 * Plugins/npapi.mm:
13579 (NPN_PostURLNotify):
13582 (NPN_ScheduleTimer):
13583 (NPN_UnscheduleTimer):
13584 (NPN_GetValueForURL):
13585 (NPN_SetValueForURL):
13586 (NPN_GetAuthenticationInfo):
13587 (WKN_CheckIfAllowedToLoadURL):
13588 (WKN_CancelCheckIfAllowedToLoadURL):
13590 2010-04-29 Anders Carlsson <andersca@apple.com>
13592 Reviewed by Dan Bernstein.
13595 https://bugs.webkit.org/show_bug.cgi?id=20784
13596 move npapi.h to C99 integer types.
13598 * MigrateHeaders.make:
13600 2010-04-28 Mike Thole <mthole@apple.com>
13602 Reviewed by David Kilzer.
13604 Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
13605 can be inspected before attempting to authenticate against it
13606 https://bugs.webkit.org/show_bug.cgi?id=38271
13608 * WebCoreSupport/WebFrameLoaderClient.h:
13609 * WebCoreSupport/WebFrameLoaderClient.mm:
13610 (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
13611 Added. If the resource load delegate implements the callback, use its answer. If it does
13612 not, then only send authentication challenges for pre-10.6 protection spaces, which matches
13613 CFNetwork's default behavior.
13614 * WebView/WebDelegateImplementationCaching.h:
13615 * WebView/WebDelegateImplementationCaching.mm:
13616 (CallResourceLoadDelegateReturningBoolean): Added case for passing three objects.
13617 * WebView/WebResourceLoadDelegatePrivate.h:
13618 Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:
13619 * WebView/WebView.mm:
13620 (-[WebView _cacheResourceLoadDelegateImplementations]):
13622 2010-04-28 Simon Fraser <simon.fraser@apple.com>
13624 Reviewed by Sam Weinig.
13626 <rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing()
13628 Ensure that the WebView +initialize method initializes threading, so that things are correctly
13629 initialized when the first call into the WebKit framework is via a WebView class method.
13631 * WebView/WebView.mm:
13632 (+[WebView initialize]):
13634 2010-04-28 Darin Adler <darin@apple.com>
13636 Reviewed by Adele Peterson.
13638 REGRESSION: Autoscroll does not work in Mail messages
13639 https://bugs.webkit.org/show_bug.cgi?id=38267
13640 rdar://problem/7559799
13642 The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
13643 view had gotten broken in multiple ways. For some reason, a combination of bugs made it
13644 partly work until around r48064. This brings it back.
13646 * WebCoreSupport/WebChromeClient.mm:
13647 (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view
13648 rather than the WebView itself. This logic may not be correct for the case where
13649 usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later.
13651 2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>
13653 Reviewed by Darin Adler and Eric Seidel.
13655 Add layoutTestController.setPrinting()
13656 https://bugs.webkit.org/show_bug.cgi?id=37203
13658 * Misc/WebCoreStatistics.h:
13659 * Misc/WebCoreStatistics.mm:
13660 (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):
13662 2010-04-25 Sam Weinig <sam@webkit.org>
13664 Reviewed by Maciej Stachowiak.
13666 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
13667 Disentangle initializing the main thread from initializing threading
13669 Calls initializeMainThreadToProcessMainThread since there is no way to ensure
13670 that the initialize method will be called on the main thread.
13672 * Carbon/CarbonWindowAdapter.mm:
13673 (+[CarbonWindowAdapter initialize]): Add call to initializeMainThreadToProcessMainThread.
13674 * History/WebBackForwardList.mm:
13675 (+[WebBackForwardList initialize]): Ditto.
13676 * History/WebHistoryItem.mm:
13677 (+[WebHistoryItem initialize]): Ditto.
13678 * Misc/WebElementDictionary.mm:
13679 (+[WebElementDictionary initialize]): Ditto.
13680 * Misc/WebIconDatabase.mm:
13681 (+[WebIconDatabase initialize]): Ditto.
13682 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
13683 (+[WebHostedNetscapePluginView initialize]): Ditto.
13684 * Plugins/WebBaseNetscapePluginView.mm:
13685 (+[WebBaseNetscapePluginView initialize]): Ditto.
13686 * Plugins/WebBasePluginPackage.mm:
13687 (+[WebBasePluginPackage initialize]): Ditto.
13688 * Plugins/WebNetscapePluginView.mm:
13689 (+[WebNetscapePluginView initialize]): Ditto.
13690 * WebCoreSupport/WebEditorClient.mm:
13691 (+[WebEditCommand initialize]): Ditto.
13692 * WebCoreSupport/WebFrameLoaderClient.mm:
13693 (+[WebFramePolicyListener initialize]): Ditto.
13694 * WebView/WebArchive.mm:
13695 (+[WebArchivePrivate initialize]): Ditto.
13696 * WebView/WebDataSource.mm:
13697 (+[WebDataSourcePrivate initialize]): Ditto.
13698 * WebView/WebHTMLView.mm:
13699 (+[WebHTMLViewPrivate initialize]): Ditto.
13700 (+[WebHTMLView initialize]): Ditto.
13701 * WebView/WebResource.mm:
13702 (+[WebResourcePrivate initialize]): Ditto.
13703 * WebView/WebTextIterator.mm:
13704 (+[WebTextIteratorPrivate initialize]): Ditto.
13705 * WebView/WebView.mm:
13706 * WebView/WebViewData.mm: Ditto.
13707 (+[WebViewPrivate initialize]): Ditto.
13709 2010-04-24 Dan Bernstein <mitz@apple.com>
13711 Reviewed by Darin Adler.
13713 <rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME types
13714 https://bugs.webkit.org/show_bug.cgi?id=38085
13716 WebView was calling -_webView in a few places where it should have just used itself. It never
13717 makes sense for WebView to call -_webView on itself, and these calls look like they were copied
13718 from similar code in WebHTMLView, WebFrameView and WebDataSource, where -_webView has a different,
13721 * WebView/WebView.mm:
13722 (-[WebView drawSingleRect:]): Replaced [self _webView] with self.
13723 (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Replaced [[self _webView] preferences]
13724 with _private->preferences.
13725 (-[WebView _canShowMIMEType:]): Ditto.
13727 2010-04-23 Simon Fraser <simon.fraser@apple.com>
13729 Reviewed by Anders Carlsson.
13731 <rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint
13733 When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling
13734 NPPrint with a GWorldPtr, since Flash prefers the CGContext path.
13736 * Plugins/WebNetscapePluginView.mm:
13737 (-[WebNetscapePluginView drawRect:]):
13739 2010-04-22 David Kilzer <ddkilzer@apple.com>
13741 <http://webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call to JSC::initializeThreading()
13743 Reviewed by Timothy Hatcher.
13745 Every other Objective-C class that calls
13746 WebCoreObjCFinalizeOnMainThread(self) in +initialize also calls
13747 JSC::initializeThreading(). The WebTextIteratorPrivate class
13748 was the only one missing this call.
13750 * WebView/WebTextIterator.mm:
13751 (+[WebTextIteratorPrivate initialize]): Added call to
13752 JSC::initializeThreading().
13754 2010-04-22 Alexey Proskuryakov <ap@apple.com>
13756 Rubber-stamped by Mark Rowe.
13758 <rdar://problem/7805969> REGRESSION: iTunes unable to play trailers
13760 Undo the changes made for https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>)
13761 for now. Clients rely on the old behavior, so a fix that changes it will need to account for
13764 * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL
13765 instead of baseURL again.
13767 2010-04-22 Dave Moore <davemoore@chromium.org>
13769 Reviewed by Dimitri Glazkov.
13771 Added notification when the favicons for a page are changed
13773 The Document object will notify the frame loader, which will
13774 notify the client. Implementations of FrameLoaderClient will
13775 have to add one method; dispatchDidChangeIcons().
13777 https://bugs.webkit.org/show_bug.cgi?id=33812
13779 * WebCoreSupport/WebFrameLoaderClient.h:
13780 * WebCoreSupport/WebFrameLoaderClient.mm:
13781 (WebFrameLoaderClient::dispatchDidChangeIcons):
13783 2010-04-22 Adam Barth <abarth@webkit.org>
13785 Unreviewed, rolling out r58069.
13786 http://trac.webkit.org/changeset/58069
13787 https://bugs.webkit.org/show_bug.cgi?id=27751
13789 Broke compile on Windows.
13791 * WebView/WebPreferenceKeysPrivate.h:
13792 * WebView/WebPreferences.mm:
13793 (+[WebPreferences initialize]):
13794 * WebView/WebPreferencesPrivate.h:
13795 * WebView/WebView.mm:
13796 (-[WebView _preferencesChangedNotification:]):
13798 2010-04-22 Abhishek Arya <inferno@chromium.org>
13800 Reviewed by Adam Barth.
13802 Add support for controlling clipboard access from javascript.
13803 Clipboard access from javascript is disabled by default.
13804 https://bugs.webkit.org/show_bug.cgi?id=27751
13806 * WebView/WebPreferenceKeysPrivate.h:
13807 * WebView/WebPreferences.mm:
13808 (+[WebPreferences initialize]):
13809 (-[WebPreferences javaScriptCanAccessClipboard]):
13810 (-[WebPreferences setJavaScriptCanAccessClipboard:]):
13811 * WebView/WebPreferencesPrivate.h:
13812 * WebView/WebView.mm:
13813 (-[WebView _preferencesChangedNotification:]):
13815 2010-04-21 Alexey Proskuryakov <ap@apple.com>
13817 Reviewed by Shinichiro Hamaji.
13819 https://bugs.webkit.org/show_bug.cgi?id=37964
13820 Fix a typo in comments - Korean encoding name is windows-949, not windows-939
13822 * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
13824 2010-04-21 Mark Rowe <mrowe@apple.com>
13828 * Plugins/WebPluginController.mm: Add an #import that is necessary on Tiger.
13830 2010-04-21 Mark Rowe <mrowe@apple.com>
13832 Reviewed by Eric Carlson.
13834 <rdar://problem/7313430> Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:]
13836 Existing versions of the Flip4Mac WebKit plug-in have an object lifetime bug related to an NSAlert that is
13837 used to notify the user about updates to the plug-in. This bug can result in Safari crashing if the page
13838 containing the plug-in navigates while the alert is displayed (<rdar://problem/7313430>).
13840 The gist of the bug is thus: Flip4Mac sets an instance of the TSUpdateCheck class as the modal delegate of the
13841 NSAlert instance. This TSUpdateCheck instance itself has a delegate. The delegate is set to the WmvPlugin
13842 instance which is the NSView subclass that is exposed to WebKit as the plug-in view. Since this relationship
13843 is that of delegates the TSUpdateCheck does not retain the WmvPlugin. This leads to a bug if the WmvPlugin
13844 instance is destroyed before the TSUpdateCheck instance as the TSUpdateCheck instance will be left with a
13845 pointer to a stale object. This will happen if a page containing the Flip4Mac plug-in triggers a navigation
13846 while the update sheet is visible as the WmvPlugin instance is removed from the view hierarchy and there are
13847 no other references to keep the object alive.
13849 We work around this bug by patching the following two messages:
13851 1) -[NSAlert beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:]
13852 2) -[TSUpdateCheck alertDidEnd:returnCode:contextInfo:]
13854 Our override of 1) detects whether it is Flip4Mac's update sheet triggering the alert by checking whether the
13855 modal delegate is an instance of TSUpdateCheck. If it is, it retains the modal delegate's delegate.
13857 Our override of 2) then autoreleases the delegate, balancing the retain we added in 1).
13859 These two overrides have the effect of ensuring that the WmvPlugin instance will always outlive the TSUpdateCheck
13860 instance, preventing the TSUpdateCheck instance from accessing a stale delegate pointer and crashing the application.
13862 * Plugins/WebPluginController.mm:
13863 (-[WebPluginController addPlugin:]): Check whether the plug-in being instantiated is the Flip4Mac plug-in and
13864 install our workaround if it is.
13865 (isKindOfClass): Helper function that checks whether the given object is an instance of the named class.
13866 (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_): Autorelease the delegate.
13867 (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_): Retain the modal delegate's
13868 delegate if this NSAlert belongs to the Flip4Mac plug-in.
13869 (installFlip4MacPlugInWorkaroundIfNecessary): Swizzle the necessary methods. We swizzle the TSUpdateCheck methods
13870 first since it is possible that in some versions of Flip4Mac the TSUpdateCheck class may not exist or may not have
13871 the method we're interested in. In that case we want to bail out before patching any methods.
13873 2010-04-20 Mark Rowe <mrowe@apple.com>
13875 Reviewed by Maciej Stachowiak.
13877 <rdar://problem/7856151> REGRESSION: NPP_Destroy is not called when page navigates when plug-in is displaying modal dialog
13879 An interaction between the plug-in host and WebKit was resulting in WKPCSetModal being called while
13880 NetscapePluginInstanceProxy was waiting on a reply to the GetScriptableNPObject message. This resulted
13881 in calls to stop the plug-in being deferred due to the presence of plug-in code up the stack. This
13882 could lead to crashes as it was possible for the plug-in view to be deallocated during the modal runloop.
13884 * Plugins/Hosted/NetscapePluginHostProxy.mm:
13885 (WKPCInvalidateRect):
13886 (WKPCSetModal): Defer the handling of setModal until the next runloop iteration if the host proxy
13887 is already processing requests. This ensures that there will be no plug-in code on the stack when
13888 the modal runloop is entered, which allows the plug-in to be stopped when the page is navigated while
13889 a modal dialog is displayed.
13891 2010-04-20 Adam Barth <abarth@webkit.org>
13893 Reviewed by Eric Seidel.
13895 Factor DocumentWriter out of FrameLoader
13896 https://bugs.webkit.org/show_bug.cgi?id=37175
13898 Update these callsites because the method moved to DocumentWriter.
13900 * WebView/WebFrame.mm:
13901 (-[WebFrame _canProvideDocumentSource]):
13902 (-[WebFrame _receivedData:textEncodingName:]):
13904 2010-04-20 Kent Tamura <tkent@chromium.org>
13906 Reviewed by Darin Adler.
13908 Change a parameter type of chooseIconForFiles()
13909 https://bugs.webkit.org/show_bug.cgi?id=37504
13911 * WebCoreSupport/WebChromeClient.h:
13912 * WebCoreSupport/WebChromeClient.mm:
13913 (WebChromeClient::chooseIconForFiles):
13915 2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
13917 Unreviewed, rolling out r57892.
13918 http://trac.webkit.org/changeset/57892
13919 https://bugs.webkit.org/show_bug.cgi?id=37864
13921 Caused an assertion in Mac builds (Requested by smfr on
13924 * WebView/WebFrame.mm:
13925 (-[WebFrame _getVisibleRect:]):
13926 * WebView/WebFrameView.mm:
13927 (-[WebFrameView _install]):
13929 2010-04-20 Simon Fraser <simon.fraser@apple.com>
13931 Reviewed by Dan Bernstein.
13933 Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
13934 https://bugs.webkit.org/show_bug.cgi?id=37741
13936 Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
13937 RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().
13939 * WebView/WebFrame.mm:
13940 (-[WebFrame _getVisibleRect:]):
13941 * WebView/WebFrameView.mm:
13942 (-[WebFrameView _install]):
13944 2010-04-19 Dan Bernstein <mitz@apple.com>
13946 Reviewed by Sam Weinig.
13948 Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
13949 printing width as SPI.
13951 * WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.
13953 2010-04-15 Gavin Barraclough <barraclough@apple.com>
13955 Reviewed by Sam Weinig & Oliver Hunt.
13957 https://bugs.webkit.org/show_bug.cgi?id=37675
13958 Remove casts/constructors to/from JSC::UString type from WebCore::String
13960 WebCore's strings should not know about JSC::UString, this should be abstracted
13961 away in the bindings. Add explicit conversion methods rather than relying on
13962 overloaded cast operators / constructors being implicitly called.
13964 This patch only changes the class String, once this has landed StringImpl, and
13965 hopefully AtomicString too, should follow suit.
13967 * Plugins/Hosted/NetscapePluginHostProxy.mm:
13968 (identifierFromIdentifierRep):
13969 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13970 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
13971 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
13972 * Plugins/Hosted/ProxyInstance.mm:
13973 (WebKit::ProxyInstance::getPropertyNames):
13974 * WebView/WebFrame.mm:
13975 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
13976 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
13977 * WebView/WebScriptDebugDelegate.mm:
13978 (-[WebScriptCallFrame evaluateWebScript:]):
13979 * WebView/WebScriptDebugger.mm:
13981 * WebView/WebView.mm:
13982 (aeDescFromJSValue):
13984 2010-04-16 Dan Bernstein <mitz@apple.com>
13986 Reviewed by John Sullivan.
13988 Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
13989 printing width as SPI.
13991 * WebView/WebHTMLView.mm:
13992 Replaced two macros with constants.
13993 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
13994 (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
13995 * WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and
13996 _WebHTMLViewPrintingMaximumShrinkFactor.
13998 2010-04-15 Mark Rowe <mrowe@apple.com>
14000 Reviewed by Sam Weinig.
14002 <rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors when included in plain Objective-C files.
14004 * WebView/WebDynamicScrollBarsView.h:
14006 2010-04-15 Adam Roben <aroben@apple.com>
14008 Export WebUserContentURLPattern from WebKit
14010 Rubber-stamped by Mark Rowe.
14014 2010-04-15 Dan Bernstein <mitz@apple.com>
14016 Reviewed by Simon Fraser.
14018 Made consecutive calls to -[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:] work
14019 without intermediate calls -[WebHTMLView _endPrintMode].
14021 * WebView/WebHTMLView.mm:
14022 (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
14024 2010-04-15 Adam Roben <aroben@apple.com>
14026 Expose UserContentURLPattern as WebKit SPI
14028 Fixes <http://webkit.org/b/37354>.
14030 Reviewed by Tim Hatcher.
14032 * Misc/WebUserContentURLPattern.h: Added.
14034 * Misc/WebUserContentURLPattern.mm: Added.
14035 (-[WebUserContentURLPattern initWithPatternString:]): Initialize
14036 _private and then parse the passed-in string into a
14037 UserContentURLPattern.
14038 (-[WebUserContentURLPattern dealloc]): Release _private.
14040 (-[WebUserContentURLPattern isValid]):
14041 (-[WebUserContentURLPattern scheme]):
14042 (-[WebUserContentURLPattern host]):
14043 (-[WebUserContentURLPattern matchesSubdomains]):
14044 Call through to UserContentURLPattern.
14046 2010-04-13 Geoffrey Garen <ggaren@apple.com>
14048 Reviewed by Oliver Hunt.
14050 Separated a DOMWrapperWorld's behavior of keeping wrappers alive from
14051 its own lifetime, so a DOMWrapperWorld's controller can throw away
14052 its wrappers even before its refcount reaches 0.
14054 * WebView/WebScriptWorld.h:
14055 * WebView/WebScriptWorld.mm:
14056 (-[WebScriptWorld unregisterWorld]): Exported this function through WebKit.
14058 2010-04-12 Timothy Hatcher <timothy@apple.com>
14060 SecurityOrigin needs a way to remove individual OriginAccessEntries
14061 https://bugs.webkit.org/show_bug.cgi?id=37449
14063 Reviewed by Dave Hyatt.
14065 * WebView/WebView.mm:
14066 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
14067 Call SecurityOrigin::removeOriginAccessWhitelistEntry.
14068 * WebView/WebViewPrivate.h: Added _removeOriginAccessWhitelistEntryWithSourceOrigin.
14070 2010-04-13 Timothy Hatcher <timothy@apple.com>
14072 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
14073 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
14075 SecurityOrigin needs a way to remove individual OriginAccessEntries
14076 https://bugs.webkit.org/show_bug.cgi?id=37449
14078 Reviewed by Dave Hyatt.
14080 * WebView/WebView.mm:
14081 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
14082 (+[WebView _resetOriginAccessWhitelists]):
14083 * WebView/WebViewPrivate.h:
14085 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
14087 Unreviewed, rolling out r57468.
14088 http://trac.webkit.org/changeset/57468
14089 https://bugs.webkit.org/show_bug.cgi?id=37433
14091 Broke the world... Must have applied the patch wrong
14092 (Requested by abarth on #webkit).
14094 * WebView/WebFrame.mm:
14095 (-[WebFrame _canProvideDocumentSource]):
14096 (-[WebFrame _receivedData:textEncodingName:]):
14098 2010-04-11 Adam Barth <abarth@webkit.org>
14100 Reviewed by Eric Seidel.
14102 Factor DocumentWriter out of FrameLoader
14103 https://bugs.webkit.org/show_bug.cgi?id=37175
14105 Update these callsites because the method moved to DocumentWriter.
14107 * WebView/WebFrame.mm:
14108 (-[WebFrame _canProvideDocumentSource]):
14109 (-[WebFrame _receivedData:textEncodingName:]):
14111 2010-04-10 Mark Rowe <mrowe@apple.com>
14113 Reviewed by Dan Bernstein.
14115 <rdar://problem/7845305> Further adoption of formal protocols for delegates.
14117 Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places.
14119 * Misc/EmptyProtocolDefinitions.h: Removed.
14120 * Misc/WebDownload.mm:
14123 2010-04-09 Jer Noble <jer.noble@apple.com>
14125 Reviewed by Darin Adler.
14127 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
14128 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
14130 * WebView/WebVideoFullscreenController.mm:
14131 (-[WebVideoFullscreenController windowDidLoad]):
14132 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
14134 2010-04-09 Alexey Proskuryakov <ap@apple.com>
14136 Reviewed by Maciej Stachowiak.
14138 https://bugs.webkit.org/show_bug.cgi?id=24572
14139 XMLHttpRequest.statusText returns always "OK" on Mac
14141 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
14143 2010-04-09 Eric Seidel <eric@webkit.org>
14145 Unreviewed, rolling out r57343.
14146 http://trac.webkit.org/changeset/57343
14147 https://bugs.webkit.org/show_bug.cgi?id=37311
14149 Broke Tiger compile.
14151 * WebView/WebVideoFullscreenController.mm:
14152 (-[WebVideoFullscreenController windowDidLoad]):
14153 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
14155 2010-04-09 Dan Bernstein <mitz@apple.com>
14157 Reviewed by Darin Adler.
14159 <rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window
14161 * WebView/WebDynamicScrollBarsView.mm:
14162 (-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private.
14164 2010-04-09 Jer Noble <jer.noble@apple.com>
14166 Reviewed by Darin Adler.
14168 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
14169 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
14171 * WebView/WebVideoFullscreenController.mm:
14172 (-[WebVideoFullscreenController windowDidLoad]):
14173 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
14175 2010-04-08 Mark Rowe <mrowe@apple.com>
14177 Reviewed by John Sullivan.
14179 <rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]
14181 In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
14182 This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
14183 size and layout of their subclasses is baked in at compile time. This results in instances
14184 being allocated that are smaller than the new code expects, and may result in the new instance
14185 variables sharing the same memory space as any instance variables that the subclass defines.
14187 We can avoid this problem by having the class contain only a single member that acts as a pointer
14188 to a heap-allocated structure that acts as storage for the real instance variables. This makes
14189 us free to add instance variables in the future without risk of changing the size of the class.
14190 To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
14191 are able to run against older versions of WebKit we pad the class out to its previous size. This
14192 results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
14193 with both versions of the code.
14195 This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
14196 instance variables of its superclass. However, this is a private header and no known subclasses
14197 of WebDynamicScrollBarsView access superclass instance variables in this fashion.
14199 * WebView/WebDynamicScrollBarsView.h:
14200 * WebView/WebDynamicScrollBarsView.mm:
14201 (-[WebDynamicScrollBarsView initWithFrame:]):
14202 (-[WebDynamicScrollBarsView dealloc]):
14203 (-[WebDynamicScrollBarsView finalize]):
14204 (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
14205 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
14206 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
14207 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
14208 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
14209 (-[WebDynamicScrollBarsView verticalScrollingAllowed]):
14210 (-[WebDynamicScrollBarsView contentViewFrame]):
14211 (-[WebDynamicScrollBarsView tile]):
14212 (-[WebDynamicScrollBarsView setSuppressLayout:]):
14213 (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
14214 (-[WebDynamicScrollBarsView updateScrollers]):
14215 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
14216 (-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
14217 (-[WebDynamicScrollBarsView allowsVerticalScrolling]):
14218 (-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
14219 (-[WebDynamicScrollBarsView horizontalScrollingMode]):
14220 (-[WebDynamicScrollBarsView verticalScrollingMode]):
14221 (-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
14222 (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
14223 (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
14224 (-[WebDynamicScrollBarsView setScrollingModesLocked:]):
14225 (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
14226 (-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
14227 (-[WebDynamicScrollBarsView scrollWheel:]):
14229 2010-04-07 David Hyatt <hyatt@apple.com>
14231 Reviewed by Oliver Hunt.
14233 https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS
14235 Add SPI so that layout tests can access computed style including :visited information.
14237 * WebView/WebRenderNode.mm:
14239 * WebView/WebView.mm:
14240 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
14241 * WebView/WebViewInternal.h:
14242 * WebView/WebViewPrivate.h:
14244 2010-04-07 Dan Bernstein <mitz@apple.com>
14246 Reviewed by Adele Peterson.
14248 Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
14249 https://bugs.webkit.org/show_bug.cgi?id=37246
14251 * Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
14252 * Misc/WebNSPrintOperationExtras.m:
14253 (-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
14255 (-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
14257 * WebView/WebHTMLView.mm:
14258 (-[WebHTMLView _isInPrintMode]): Added this accessor.
14259 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
14260 computes the layout widths and enters printing mode into this private method.
14261 (-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
14262 (-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
14263 (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
14265 (-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
14266 (-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
14267 -[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
14269 (-[WebHTMLView beginDocument]): Updated for rename.
14270 (-[WebHTMLView endDocument]): Ditto.
14271 * WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,
14272 -_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.
14274 2010-04-07 Andrey Kosyakov <caseq@chromium.org>
14276 Reviewed by Yury Semikhatsky.
14278 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
14279 https://bugs.webkit.org/show_bug.cgi?id=36949
14281 * WebCoreSupport/WebFrameLoaderClient.h:
14282 * WebCoreSupport/WebFrameLoaderClient.mm:
14284 2010-04-06 Dan Bernstein <mitz@apple.com>
14286 Tiger build fix after r57184.
14288 * WebView/WebHTMLViewPrivate.h:
14290 2010-04-06 Dan Bernstein <mitz@apple.com>
14292 Tiger build fix after r57184.
14294 * WebView/WebHTMLViewPrivate.h:
14296 2010-04-06 Adam Barth <abarth@webkit.org>
14300 Speculative build fix for Tiger.
14302 * WebView/WebHTMLViewPrivate.h:
14304 2010-04-06 Dan Bernstein <mitz@apple.com>
14306 Reviewed by Sam Weinig and Anders Carlsson.
14308 Expose WebHTMLView’s page breaking logic as SPI.
14310 * WebView/WebHTMLView.mm:
14311 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
14312 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:
14313 * WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:
14315 2010-04-06 Mark Rowe <mrowe@apple.com>
14317 Add an #if in order to make Tiger happy.
14319 * WebView/WebViewData.mm:
14320 (-[WebViewPrivate init]):
14322 2010-04-06 Mark Rowe <mrowe@apple.com>
14326 * WebView/WebViewData.mm:
14327 (-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.
14329 2010-04-05 Mark Rowe <mrowe@apple.com>
14331 Reviewed by Adele Peterson.
14333 Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
14334 REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI
14336 * WebView/WebHTMLView.mm:
14337 (-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
14338 manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.
14340 2010-04-05 Alexey Proskuryakov <ap@apple.com>
14342 Reviewed by Darin Adler.
14344 https://bugs.webkit.org/show_bug.cgi?id=37111
14345 <rdar://problem/7790327> Draw replacement text when plug-in host crashes
14347 * Plugins/Hosted/WebHostedNetscapePluginView.h: Removed _pluginDied - it was only used
14348 for drawing replacement icon, and this information is now in WebCore.
14349 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
14350 (-[WebHostedNetscapePluginView pluginHostDied]): Tell RenderEmbeddedObject that the plug-in
14352 (-[WebHostedNetscapePluginView drawRect:]): Removed the case for crashed plug-in host. It is
14353 handled by WebCore now.
14355 * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory crashedPluginText]): Added a string
14356 for plug-in failure.
14358 2010-04-03 yael aharon <yael.aharon@nokia.com>
14360 Reviewed by Darin Adler.
14362 Enable HTMLProgressElement for Safari on OSX
14363 https://bugs.webkit.org/show_bug.cgi?id=36961
14365 * Configurations/FeatureDefines.xcconfig:
14367 2010-04-02 Jer Noble <jer.noble@apple.com>
14369 Reviewed by Eric Carlson.
14371 https://bugs.webkit.org/show_bug.cgi?id=36624
14372 Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.
14374 * WebCoreSupport/WebSystemInterface.m:
14375 (InitWebCoreSystemInterface):
14377 2010-04-02 Alexey Proskuryakov <ap@apple.com>
14379 Reviewed by Darin Adler.
14381 https://bugs.webkit.org/show_bug.cgi?id=37043
14382 Java regression tests spam stderr about being unable to set status message
14384 With this change, there is still spam about "Attempt to access JavaScript from destroyed
14385 applet, type 9." I haven't investigated if that indicates a problem or not.
14387 * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]):
14388 Removed check for _documentView. We don't seem to care.
14390 2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
14392 Reviewed by Dmitry Titov.
14394 Add FileThread for async file operation support in FileReader and FileWriter
14395 https://bugs.webkit.org/show_bug.cgi?id=36896
14397 Add FILE_READER or FILE_WRITER feature defines.
14399 * Configurations/FeatureDefines.xcconfig:
14401 2010-04-01 Ada Chan <adachan@apple.com>
14403 Reviewed by Darin Adler.
14405 Change WebDatabaseManager::deleteOrigin() to return true if there are no errors in deleting the origin.
14406 Ditto for WebDatabaseManager::deleteDatabase().
14408 https://bugs.webkit.org/show_bug.cgi?id=36988
14410 * Storage/WebDatabaseManager.mm:
14411 (-[WebDatabaseManager deleteOrigin:]):
14412 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
14413 * Storage/WebDatabaseManagerPrivate.h:
14415 2010-04-01 Alexey Proskuryakov <ap@apple.com>
14417 Reviewed by Darin Adler.
14419 https://bugs.webkit.org/show_bug.cgi?id=36976
14420 <rdar://problem/7817498>
14421 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
14423 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14424 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): The HashTable assertions aren't
14425 there to catch potential future attempts to store empty/deleted values before these happen -
14426 it's actually wrong to try to look up these values. Added an early return.
14427 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Ditto.
14429 2010-04-01 Chris Marrin <cmarrin@apple.com>
14431 Reviewed by Simon Fraser.
14433 Added layerTreeAsText function to DRT (for Mac)
14434 https://bugs.webkit.org/show_bug.cgi?id=36782
14436 This is the WebKit side for Mac. It plumbs the
14437 call from WebCore to DRT.
14439 * WebView/WebFrame.mm:WebKit (Mac) side of plumbing
14440 (-[WebFrame _layerTreeAsText]):
14441 * WebView/WebFramePrivate.h:
14443 2010-04-01 Alexey Proskuryakov <ap@apple.com>
14445 Reviewed by Oliver Hunt.
14447 https://bugs.webkit.org/show_bug.cgi?id=36976
14448 <rdar://problem/7817498>
14449 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
14451 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14452 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(),
14453 because the latter fails with an assertion when looking up 0 or -1.
14454 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Be prepared for unexpected
14455 object IDs coming from plug-in host.
14457 2010-03-31 Chris Fleizach <cfleizach@apple.com>
14459 Reviewed by Darin Adler.
14461 Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
14462 https://bugs.webkit.org/show_bug.cgi?id=36845
14464 Provide a way through WebKit to set an accessible label that describes the web area.
14466 * WebView/WebFrame.mm:
14467 (-[WebFrame setAccessibleName:]):
14468 * WebView/WebFramePrivate.h:
14470 2010-03-31 Marcus Bulach <bulach@chromium.org>
14472 Reviewed by Jeremy Orlow.
14474 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
14475 https://bugs.webkit.org/show_bug.cgi?id=35031
14477 * WebCoreSupport/WebChromeClient.h:
14478 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
14480 2010-03-30 Gavin Barraclough <barraclough@apple.com>
14482 Rubber stamped by Sam Weinig.
14484 https://bugs.webkit.org/show_bug.cgi?id=36866
14485 Move CString to WTF
14487 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14488 (WebKit::NetscapePluginInstanceProxy::getCookies):
14489 (WebKit::NetscapePluginInstanceProxy::getProxy):
14490 (WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo):
14491 (WebKit::NetscapePluginInstanceProxy::resolveURL):
14492 * Plugins/WebBaseNetscapePluginView.h:
14493 * Plugins/WebBaseNetscapePluginView.mm:
14494 * Plugins/WebNetscapePluginView.mm:
14495 (-[WebNetscapePluginView resolveURL:forTarget:]):
14497 2010-03-30 John Sullivan <sullivan@apple.com>
14499 Reviewed by Dan Bernstein.
14501 https://bugs.webkit.org/show_bug.cgi?id=36848
14502 <rdar://problem/7362913>
14503 Menu items appropriate only for rich-content editing can appear in plain-text contexts
14505 * WebView/WebHTMLView.mm:
14506 (-[WebHTMLView validRequestorForSendType:returnType:]):
14507 Don't return self for non-string content if _canEditRichly is false.
14509 2010-03-29 Alexey Proskuryakov <ap@apple.com>
14511 Reviewed by Darin Adler.
14513 https://bugs.webkit.org/show_bug.cgi?id=36791
14514 Add assertions for instance proxy validity
14516 Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw
14517 pointer to one across complicated function calls, relying on the caller to protect the
14520 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14521 (WebKit::NetscapePluginInstanceProxy::renderContextID):
14522 (WebKit::NetscapePluginInstanceProxy::pluginView):
14523 (WebKit::NetscapePluginInstanceProxy::hostProxy):
14525 2010-03-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
14527 Reviewed by David Kilzer.
14529 Explicit guards for ENABLE_GEOLOCATION
14530 https://bugs.webkit.org/show_bug.cgi?id=25756
14532 * WebCoreSupport/WebGeolocationMock.mm:
14533 (-[WebGeolocationMock setError:code:]): Make the body conditional on
14534 ENABLE(GEOLOCATION)
14535 (-[WebGeolocationMock setPosition:]): Ditto.
14537 2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
14539 Reviewed by Antti Koivisto.
14541 Change method name due to it dealing with both flattening
14542 of frame sets and inner frames.
14544 * WebView/WebPreferenceKeysPrivate.h:
14545 * WebView/WebPreferences.mm:
14546 (+[WebPreferences initialize]):
14547 (-[WebPreferences isFrameFlatteningEnabled]):
14548 (-[WebPreferences setFrameFlatteningEnabled:]):
14549 * WebView/WebPreferencesPrivate.h:
14550 * WebView/WebView.mm:
14551 (-[WebView _preferencesChangedNotification:]):
14553 2010-03-27 Darin Adler <darin@apple.com>
14555 * Misc/WebNSFileManagerExtras.m:
14556 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
14557 Removed stray "!". How did that get in there?
14559 2010-03-27 Darin Adler <darin@apple.com>
14561 Reviewed by Mark Rowe.
14563 WebKit NSFileManager methods don't handle broken symlinks correctly.
14564 Part of <rdar://problem/7574046>.
14566 * Misc/WebNSFileManagerExtras.h: Removed unused defines and methods.
14567 * Misc/WebNSFileManagerExtras.m: Removed unused methods.
14568 (fileExists): Added. For use instead of fileExistsAtPath: for cases where we'd like
14569 to treat a broken symlink as a file that does indeed exist.
14570 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use fileExists.
14572 2010-03-25 Alexey Proskuryakov <ap@apple.com>
14574 Reviewed by Mark Rowe.
14576 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in
14577 a way that works in a function that doesn't have a pluginID argument for some reason.
14579 2010-03-25 Simon Fraser <simon.fraser@apple.com>
14581 Build fix: no review.
14583 Another c_str() -> data().
14585 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14586 (WebKit::NetscapePluginInstanceProxy::enumerate):
14588 2010-03-25 Alexey Proskuryakov <ap@apple.com>
14590 Reviewed by Mark Rowe.
14592 Correctness fix after r56493.
14594 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update
14595 our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees
14596 that the host proxy won't go away while the open panel is up.
14598 2010-03-24 Mark Rowe <mrowe@apple.com>
14600 Build fix after r56474.
14602 * Plugins/Hosted/NetscapePluginHostProxy.mm:
14603 (WKPCRunSyncOpenPanel):
14605 2010-03-24 Alexey Proskuryakov <ap@apple.com>
14607 Reviewed by Anders Carlsson.
14609 https://bugs.webkit.org/show_bug.cgi?id=36563
14610 A plug-in makes Safari crash on http://www.itscodingtime.com/
14612 * Plugins/Hosted/NetscapePluginHostProxy.h:
14613 (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't
14614 beautifully systemic, but helped catch a bug, and may help catch more.
14615 (WebKit::NetscapePluginHostProxy::clientPort): Ditto.
14616 (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a
14617 static. This doesn't change behavior much, but helps avoid writing into deallocated memory.
14619 * Plugins/Hosted/NetscapePluginHostProxy.mm:
14620 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests
14622 (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests
14623 after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there
14624 wasn't much time for some other object to be allocated at this address.
14625 (WKPCEvaluate): Refetch host proxy, as it may have been destroyed.
14626 (WKPCInvoke): Ditto.
14627 (WKPCInvokeDefault): Ditto.
14628 (WKPCGetProperty): Ditto.
14629 (WKPCSetProperty): Ditto.
14630 (WKPCRemoveProperty): Ditto.
14631 (WKPCHasProperty): Ditto.
14632 (WKPCHasMethod): Ditto.
14633 (WKPCEnumerate): Ditto.
14634 (WKPCRunSyncOpenPanel): Ditto.
14636 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14637 (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the
14638 "event loop" if host proxy went away while processing a request.
14640 2010-03-24 Hayato Ito <hayato@chromium.org>
14642 Reviewed by Shinichiro Hamaji.
14644 Refactor computePageRects so that Mac can make use of it.
14645 https://bugs.webkit.org/show_bug.cgi?id=36159
14647 Refactoring only, so no new tests.
14649 * WebView/WebFrame.mm:
14650 (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):
14652 2010-03-24 Kent Tamura <tkent@chromium.org>
14654 Reviewed by Darin Adler.
14656 Make Icon::createIconForFiles() optional.
14657 https://bugs.webkit.org/show_bug.cgi?id=35072
14659 - Rename iconForFiles() to chooseIconForFiles().
14660 - Call Icon::createIconForFiles() from chooseIconForFiles().
14662 * WebCoreSupport/WebChromeClient.h:
14663 * WebCoreSupport/WebChromeClient.mm:
14664 (WebChromeClient::chooseIconForFiles):
14666 2010-03-23 Dan Bernstein <mitz@apple.com>
14668 Reverted accidental change from r56429.
14670 * WebCoreSupport/WebContextMenuClient.mm:
14671 (WebContextMenuClient::getCustomMenuFromDefaultItems):
14673 2010-03-23 Dan Bernstein <mitz@apple.com>
14675 Reviewed by John Sullivan.
14678 <rdar://problem/7197736> Plug-in clip rect does not update when overflow
14680 https://bugs.webkit.org/show_bug.cgi?id=36479.
14682 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
14683 (-[WebHostedNetscapePluginView visibleRectDidChange]): Added. Calls
14684 WKSyncSurfaceToView().
14685 * Plugins/WebBaseNetscapePluginView.h:
14686 * Plugins/WebBaseNetscapePluginView.mm:
14687 (-[WebBaseNetscapePluginView _windowClipRect]): Changed to use Widget::windowClipRect().
14688 (-[WebBaseNetscapePluginView visibleRectDidChange]): Added. Invokes -renewGState.
14690 2010-03-22 Kevin Decker <kdecker@apple.com>
14692 Reviewed by Simon Fraser.
14694 https://bugs.webkit.org/show_bug.cgi?id=36328
14696 This patch entirely WebNullPluginView.
14698 * Plugins/WebNetscapePluginView.mm:
14699 * Plugins/WebNullPluginView.h: Removed.
14700 * Plugins/WebNullPluginView.mm: Removed.
14701 * Resources/nullplugin.tiff: Removed.
14702 * WebCoreSupport/WebFrameLoaderClient.mm:
14703 (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
14705 2010-03-22 Alexey Proskuryakov <ap@apple.com>
14707 Reviewed by John Sullivan.
14709 https://bugs.webkit.org/show_bug.cgi?id=36455
14710 Make WebKit more resistant against plug-in crashes
14712 No tests, because crashing on build bots isn't good, even if it's only helper processes
14715 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14716 (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function
14717 needs it after waiting for reply. Some callers used to do this, but not all, and we really
14718 shouldn't depend on callers here.
14720 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14721 (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy,
14722 because this function doesn't use it after waiting for reply.
14723 (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.
14725 * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy
14726 null check for another code path.
14728 2010-03-22 Kevin Decker <kdecker@apple.com>
14730 Reviewed by John Sullivan.
14732 https://bugs.webkit.org/show_bug.cgi?id=36328
14734 * WebCoreSupport/WebViewFactory.mm:
14735 (-[WebViewFactory missingPluginText]): Added.
14737 2010-03-18 Alexey Proskuryakov <ap@apple.com>
14739 Reviewed by Darin Adler.
14741 https://bugs.webkit.org/show_bug.cgi?id=36337
14742 Log an error when an OOP plug-in sends an unknown object id
14744 Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look
14745 temporary or redundant.
14747 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14748 (WebKit::NetscapePluginInstanceProxy::evaluate):
14749 (WebKit::NetscapePluginInstanceProxy::invoke):
14750 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
14751 (WebKit::NetscapePluginInstanceProxy::construct):
14752 (WebKit::NetscapePluginInstanceProxy::getProperty):
14753 (WebKit::NetscapePluginInstanceProxy::setProperty):
14754 (WebKit::NetscapePluginInstanceProxy::removeProperty):
14755 (WebKit::NetscapePluginInstanceProxy::hasProperty):
14756 (WebKit::NetscapePluginInstanceProxy::hasMethod):
14757 (WebKit::NetscapePluginInstanceProxy::enumerate):
14759 2010-03-16 Alexey Proskuryakov <ap@apple.com>
14761 Reviewed by Darin Adler.
14763 https://bugs.webkit.org/show_bug.cgi?id=36184
14764 YouTube video resizing doesn't work with OOP plug-ins
14766 Test: plugins/resize-from-plugin.html
14768 We were calling _WKPHResizePluginInstance synchronously or asynchronously, depending on
14769 whether the size has changed. But sync and async messages are not necessarily delivered in
14770 order - plug-in host listens only to the former while waiting for a response to a message it
14771 sent (a call to invoke() in this case).
14773 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14774 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14775 (WebKit::NetscapePluginInstanceProxy::resize):
14776 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
14777 (-[WebHostedNetscapePluginView updateAndSetWindow]):
14779 2010-03-16 Yury Semikhatsky <yurys@chromium.org>
14781 Reviewed by Pavel Feldman.
14783 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
14785 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
14786 https://bugs.webkit.org/show_bug.cgi?id=35036
14788 * WebCoreSupport/WebInspectorClient.h:
14789 * WebCoreSupport/WebInspectorClient.mm:
14790 (WebInspectorClient::WebInspectorClient):
14791 (WebInspectorClient::inspectorDestroyed):
14792 (WebInspectorClient::openInspectorFrontend):
14793 (WebInspectorClient::highlight):
14794 (WebInspectorClient::hideHighlight):
14795 (WebInspectorFrontendClient::WebInspectorFrontendClient):
14796 (WebInspectorFrontendClient::frontendLoaded):
14797 (WebInspectorFrontendClient::localizedStringsURL):
14798 (WebInspectorFrontendClient::hiddenPanels):
14799 (WebInspectorFrontendClient::bringToFront):
14800 (WebInspectorFrontendClient::closeWindow):
14801 (WebInspectorFrontendClient::attachWindow):
14802 (WebInspectorFrontendClient::detachWindow):
14803 (WebInspectorFrontendClient::setAttachedWindowHeight):
14804 (WebInspectorFrontendClient::inspectedURLChanged):
14805 (WebInspectorFrontendClient::updateWindowTitle):
14806 (-[WebInspectorWindowController dealloc]):
14807 (-[WebInspectorWindowController windowShouldClose:]):
14808 (-[WebInspectorWindowController close]):
14809 (-[WebInspectorWindowController showWindow:]):
14810 (-[WebInspectorWindowController attach]):
14811 (-[WebInspectorWindowController detach]):
14812 (-[WebInspectorWindowController attached]):
14813 (-[WebInspectorWindowController setFrontendClient:]):
14814 (-[WebInspectorWindowController destroyInspectorView]):
14815 (-[WebNodeHighlighter initWithInspectedWebView:]):
14816 (-[WebNodeHighlighter dealloc]):
14817 (-[WebNodeHighlighter highlightNode:]):
14818 (-[WebNodeHighlighter hideHighlight]):
14819 (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
14820 (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
14821 * WebInspector/WebInspector.mm:
14822 (-[WebInspector attach:]):
14823 (-[WebInspector detach:]):
14825 2010-03-15 Andy Estes <aestes@apple.com>
14827 Reviewed by John Sullivan.
14829 Updated call to WKGetWheelEventDeltas() to match new method signature.
14831 https://bugs.webkit.org/show_bug.cgi?id=29601
14832 <rdar://problem/7453254>
14834 * WebView/WebDynamicScrollBarsView.mm:
14835 (-[WebDynamicScrollBarsView scrollWheel:]):
14837 2010-03-15 John Sullivan <sullivan@apple.com>
14839 Reviewed by Adam Roben.
14841 -[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
14842 <https://bugs.webkit.org/show_bug.cgi?id=36125>
14844 * WebView/WebDynamicScrollBarsView.h:
14845 Added instance variables horizontalScrollingAllowedButScrollerHidden and
14846 verticalScrollingAllowedButScrollerHidden. Renamed instance variables
14847 hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity.
14848 Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed.
14851 * WebView/WebDynamicScrollBarsView.mm:
14852 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
14853 Updated for instance variable renaming.
14854 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
14856 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
14857 New method, returns YES if the scroller is showing or the only reason that the scroller
14858 is not showing is that setAlwaysHideHorizontalScrolling has been called.
14859 (-[WebDynamicScrollBarsView verticalScrollingAllowed]):
14860 New method, returns YES if the scroller is showing or the only reason that the scroller
14861 is not showing is that setAlwaysHideVerticalScrolling has been called.
14862 (-[WebDynamicScrollBarsView updateScrollers]):
14863 Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden
14864 and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account
14865 in the early-return code path, to avoid taking it into account twice in the regular code path.
14867 * WebView/WebFrameView.mm:
14868 (-[WebFrameView _scrollToBeginningOfDocument]):
14869 Use _isScrollable instead of _hasScrollBars.
14870 (-[WebFrameView _scrollToEndOfDocument]):
14872 (-[WebFrameView scrollToBeginningOfDocument:]):
14873 Use _largestScrollableChild instead of _largestChildWithScrollBars.
14874 (-[WebFrameView scrollToEndOfDocument:]):
14876 (-[WebFrameView _pageVertically:]):
14877 Use _isScrollable and _largestScrollableChild instead of _hasScrollBars
14878 and _largestChildWithScrollBars.
14879 (-[WebFrameView _pageHorizontally:]):
14881 (-[WebFrameView _scrollLineVertically:]):
14883 (-[WebFrameView _scrollLineHorizontally:]):
14885 (-[WebFrameView keyDown:]):
14886 Use _largestScrollableChild instead of _largestChildWithScrollBars.
14887 (-[WebFrameView _isScrollable]):
14888 New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and
14889 -[WebDynamicScrollBarsView verticalScrollingAllowed]
14890 (-[WebFrameView _largestScrollableChild]):
14891 New method, like _largestChildWithScrollBars but uses _isScrollable.
14892 (-[WebFrameView _hasScrollBars]):
14893 Added a comment that this is no longer used by Safari, and can thus probably be
14894 deleted once we no longer want to support it for nightly build compatibility with
14895 old versions of Safari.
14896 (-[WebFrameView _largestChildWithScrollBars]):
14899 * WebView/WebFrameViewPrivate.h:
14900 Declared -_isScrollable and -_largestScrollableChild. Added comments to
14901 _hasScrollBars and _largestChildWithScrollBars saying that they are no longer
14902 used by Safari, and can thus probably be deleted once we no longer want to
14903 support them for nightly build compatibility with old versions of Safari.
14905 2010-03-15 John Sullivan <sullivan@apple.com>
14907 Method name and parameter name mistakes from recent SPI addition
14908 <https://bugs.webkit.org/show_bug.cgi?id=36119>
14910 Reviewed by Dan Bernstein.
14912 * WebView/WebDynamicScrollBarsView.h:
14913 Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX".
14915 * WebView/WebDynamicScrollBarsView.mm:
14916 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
14917 Updated for renamed instance variable and method.
14918 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
14919 Changed parameter name from shouldBeVisible to shouldBeHidden.
14920 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
14922 (-[WebDynamicScrollBarsView contentViewFrame]):
14923 Updated for renamed instance variable.
14924 (-[WebDynamicScrollBarsView tile]):
14926 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
14929 * WebView/WebFrame.mm:
14930 (-[WebFrame setAllowsScrollersToOverlapContent:]):
14931 Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView.
14933 * WebView/WebFramePrivate.h:
14934 Renamed method name from "setAllowXXX" to "setAllowsXXX".
14936 2010-03-14 Darin Adler <darin@apple.com>
14938 Reviewed by Mark Rowe.
14940 Remove unneeded dependency on non-string identifier for an NSTableColumn
14941 https://bugs.webkit.org/show_bug.cgi?id=36106
14943 * WebView/WebTextCompletionController.mm:
14944 (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier:
14945 because the table has only one column and that column does not need an identifier.
14947 2010-03-12 Beth Dakin <bdakin@apple.com>
14949 Reviewed by Simon Fraser.
14951 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
14952 API naming is inconsistent
14953 -and corresponding-
14954 <rdar://problem/7729165>
14956 This patch changes all occurrences of "fullScreen" to the more
14957 popular "fullscreen."
14959 * Plugins/Hosted/NetscapePluginHostProxy.h:
14960 (WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):
14961 * Plugins/Hosted/NetscapePluginHostProxy.mm:
14962 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
14963 (WebKit::NetscapePluginHostProxy::didEnterFullscreen):
14964 (WebKit::NetscapePluginHostProxy::didExitFullscreen):
14965 (WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
14966 (WKPCSetFullscreenWindowIsShowing):
14967 * Plugins/Hosted/WebKitPluginClient.defs:
14968 * Plugins/WebNetscapePluginView.mm:
14969 (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
14970 (-[WebNetscapePluginView _createPlugin]):
14971 (-[WebNetscapePluginView _destroyPlugin]):
14972 * WebView/WebVideoFullscreenHUDWindowController.mm:
14973 (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
14975 2010-03-12 Andy Estes <aestes@apple.com>
14977 Reviewed by Brady Eidson.
14979 Expose WebPDFView's underlying PDFDocument.
14981 https://bugs.webkit.org/show_bug.cgi?id=36045
14983 * WebView/WebDocumentPrivate.h: Create a new protocol called
14985 * WebView/WebPDFView.h: Have WebPDFView implement said protocol.
14986 * WebView/WebPDFView.mm:
14987 (-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
14988 PDFDocument by implementing -(PDFDocument*)PDFDocument from
14991 2010-03-12 Andy Estes <aestes@apple.com>
14993 Reviewed by Brady Eidson.
14995 Remove an unused method.
14997 https://bugs.webkit.org/show_bug.cgi?id=35940
14999 * Plugins/WebPluginController.mm:
15000 removed - (void)showURL:(NSURL *) inFrame:(NSString *)
15002 2010-03-11 Mark Rowe <mrowe@apple.com>
15004 Reviewed by David Kilzer.
15006 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
15008 Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
15010 * Configurations/Base.xcconfig:
15012 2010-03-11 Mark Rowe <mrowe@apple.com>
15014 Reviewed by Tim Hatcher.
15016 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
15018 Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
15019 current Mac OS X version unless otherwise specified.
15021 Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
15023 Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
15024 may not be usable when targetting a different Mac OS X version.
15026 Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
15027 MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
15029 * Configurations/Base.xcconfig:
15030 * Configurations/DebugRelease.xcconfig:
15031 * Configurations/FeatureDefines.xcconfig:
15032 * Configurations/Version.xcconfig:
15034 2010-03-11 Anders Carlsson <andersca@apple.com>
15036 Reviewed by David Hyatt.
15038 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
15040 * WebCoreSupport/WebChromeClient.h:
15041 * WebCoreSupport/WebChromeClient.mm:
15043 2010-03-11 Alexey Proskuryakov <ap@apple.com>
15045 Reviewed by Geoff Garen.
15047 https://bugs.webkit.org/show_bug.cgi?id=35965
15048 <rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in
15050 Test: plugins/round-trip-npobject.html
15052 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15053 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is
15054 now a separate ProxyRuntimeObject class for proxy pbjects.
15055 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
15057 * Plugins/Hosted/ProxyInstance.mm:
15058 (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in
15059 could have crashed while we were waiting for response.
15060 (WebKit::ProxyInstance::setFieldValue): Ditto.
15062 2010-03-10 Simon Fraser <simon.fraser@apple.com>
15064 Reviewed by Darin Adler.
15066 https://bugs.webkit.org/show_bug.cgi?id=35975
15067 <rdar://problem/7739922> Flash 10.1b crashes when generating snapshots
15069 Do a version check before sending a drawRect event to a Flash plugin,
15070 since 10.1.d51 has a bug that crashes when called this way.
15072 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
15073 (-[WebHostedNetscapePluginView drawRect:]):
15074 * Plugins/WebBaseNetscapePluginView.h:
15075 * Plugins/WebBaseNetscapePluginView.mm:
15076 (-[WebBaseNetscapePluginView supportsSnapshotting]):
15077 * Plugins/WebNetscapePluginView.mm:
15078 (-[WebNetscapePluginView drawRect:]):
15080 2010-03-10 John Sullivan <sullivan@apple.com>
15082 Reviewed by Tim Hatcher.
15084 <rdar://problem/7735387> input type other than text won't work with autofill
15085 <https://bugs.webkit.org/show_bug.cgi?id=35963>
15087 * WebView/WebHTMLRepresentation.mm:
15088 (-[WebHTMLRepresentation elementDoesAutoComplete:]):
15089 Return true for any text field that's not a password, rather than only
15092 2010-03-09 Brady Eidson <beidson@apple.com>
15094 Reviewed by Tim Hatcher.
15096 REGRESSION: WebInspector docking busted on Windows
15097 <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
15099 * WebCoreSupport/WebInspectorClient.mm:
15100 (-[WebInspectorWindowController showWindow:]): Use the InspectorController:: copy of the should attach settings key.
15101 (-[WebInspectorWindowController attach]): Ditto.
15102 (-[WebInspectorWindowController detach]): Ditto.
15104 2010-03-09 Geoffrey Garen <ggaren@apple.com>
15106 Reviewed by Darin Adler.
15108 Updated for FastMalloc reporting changes.
15110 * Misc/WebCoreStatistics.mm:
15111 (+[WebCoreStatistics memoryStatistics]):
15113 2010-03-08 Simon Fraser <simon.fraser@apple.com>
15115 Reviewed by Mark Rowe.
15117 Move the new method to the end of the MIG definitions file, to avoid breaking
15118 compatibility between WebKit and older versions of WebKitPluginHost.
15120 * Plugins/Hosted/WebKitPluginHost.defs:
15122 2010-03-08 Simon Fraser <simon.fraser@apple.com>
15124 Reviewed by Kevin Decker.
15126 <rdar://problem/7714340> Need to grab image snapshot of Core Animation plugins
15128 Allow plug-ins using the Core Animation drawing model to be captured when doing a flattening paint,
15129 by sending them a drawRect event as if they were software-painting.
15131 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
15132 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15133 (WebKit::NetscapePluginInstanceProxy::snapshot):
15134 New snapshot() method that calls over to the plugin host, and then draws the image that comes back.
15136 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
15137 (-[WebHostedNetscapePluginView drawRect:]): If we don't have a software renderer, but we're doing
15138 a flattening paint, then call the snapshot method.
15140 * Plugins/Hosted/WebKitPluginHost.defs: Added snapshot method.
15142 * Plugins/WebBaseNetscapePluginView.h:
15143 * Plugins/WebBaseNetscapePluginView.mm:
15144 (-[WebBaseNetscapePluginView inFlatteningPaint]):
15145 New utility method that asks the FrameView whether the current paint behavior is
15148 * Plugins/WebNetscapePluginView.mm:
15149 (-[WebNetscapePluginView drawRect:]): If the plug-in is using CA but this is a flattening
15150 paint, go ahead and send a drawRect event to the plug-in.
15152 2010-03-08 Darin Adler <darin@apple.com>
15154 Reviewed by Dan Bernstein.
15156 Fix crash when you quit inside an unload handler.
15157 rdar://problem/6958347
15159 Test: manual-tests/quit-inside-unload.html
15161 * WebView/WebView.mm:
15162 (-[WebView _closeWithFastTeardown]): Removed code to set
15163 _private->closed since _close now does this earlier, before
15164 calling this method.
15165 (-[WebView _close]): Moved code to set _private->closed to the
15166 top of this method.
15167 (-[WebView setHostWindow:]): Rewrote the code that forbade
15168 setting the host window after closing so that it only forbids
15169 non-nil host windows. That way, the code to clear away the host
15170 window can run safely after setting _private->closed, yet client
15171 code cannot set a new host window after closing.
15173 2010-03-08 Darin Adler <darin@apple.com>
15175 Roll out a file I checked in by accident.
15177 * WebView/WebView.mm: Back to previous version.
15179 2010-03-08 Chris Marrin <cmarrin@apple.com>
15181 Reviewed by Darin Adler.
15183 Turn on HW accel on Leopard even if coreVideoHas7228836Fix() is false, when WebGL is enabled
15184 https://bugs.webkit.org/show_bug.cgi?id=35759
15186 This allows WebGL to work on Leopard without the fix. It exposes these users to the crash
15187 that happens because of the CoreVideo bug, but it limits the exposure to those who have
15188 chosen to enable WebGL.
15190 * WebView/WebView.mm:
15191 (-[WebView _preferencesChangedNotification:]):
15193 2010-03-02 Adam Treat <atreat@rim.com>
15195 Reviewed by Dave Hyatt.
15197 Adapt the mac port to the refactoring of repaint methods.
15199 https://bugs.webkit.org/show_bug.cgi?id=34214
15201 * WebCoreSupport/WebChromeClient.h:
15202 * WebCoreSupport/WebChromeClient.mm:
15203 (WebChromeClient::invalidateContents):
15204 (WebChromeClient::invalidateWindow):
15205 (WebChromeClient::invalidateContentsAndWindow):
15206 (WebChromeClient::invalidateContentsForSlowScroll):
15208 2010-03-08 Jian Li <jianli@chromium.org>
15210 Reviewed by Dmitry Titov.
15212 Blob.slice support.
15213 https://bugs.webkit.org/show_bug.cgi?id=32993
15215 Add ENABLE_BLOB_SLICE feature define.
15217 * Configurations/FeatureDefines.xcconfig:
15219 2010-03-08 Eric Uhrhane <ericu@chromium.org>
15221 Reviewed by David Levin.
15223 Remove the now-redundant Settings fields for the Database
15224 https://bugs.webkit.org/show_bug.cgi?id=35763
15226 No new tests; this code isn't called.
15228 * WebView/WebView.mm: Remove the call into Settings.
15229 (-[WebView _preferencesChangedNotification:]):
15231 2010-03-07 Mark Rowe <mrowe@apple.com>
15233 Rubber-stamped by Cameron Zwarich.
15235 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
15237 * Misc/WebIconDatabase.mm:
15239 2010-03-07 Mark Rowe <mrowe@apple.com>
15241 Rubber-stamped by Cameron Zwarich.
15243 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
15245 * Misc/WebNSPasteboardExtras.mm:
15247 2010-03-04 Mark Rowe <mrowe@apple.com>
15249 Reviewed by Sam Weinig.
15251 <rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h
15253 * MigrateHeaders.make: Migrate DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h.
15255 2010-03-04 Mark Rowe <mrowe@apple.com>
15257 Reviewed by Sam Weinig.
15259 Use a framework-style include to pull in WebInspector.h for consistency
15260 with other parts of WebKit.
15262 * WebInspector/WebInspectorPrivate.h:
15264 2010-03-04 Brady Eidson <beidson@apple.com>
15266 Reviewed by Geoff Garen.
15268 REGRESSION (31281): -[WebArchive initWithCoder:] leaks
15269 <rdar://problem/7702420> and https://bugs.webkit.org/show_bug.cgi?id=35534
15271 * WebView/WebArchive.mm:
15272 (-[WebArchive initWithCoder:]): Don't retain objects we don't own.
15274 2010-03-03 Alexey Proskuryakov <ap@apple.com>
15276 Reviewed by Timothy Hatcher.
15278 https://bugs.webkit.org/show_bug.cgi?id=35692
15279 <rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView
15281 * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
15282 Retain the challenge, just like it's done for sheet.
15284 2010-03-02 Eric Uhrhane <ericu@chromium.org>
15286 Reviewed by David Levin.
15288 Move database enable bit fully out of settings
15289 This is stage one of a three-stage commit [webkit, then chromium, then
15290 webkit again]. In this change I'm adding calls to
15291 Database::setIsAvailable inside Settings::setDatabaseEnabled and
15292 anywhere else that called it, and switching webkit fully over to using
15293 that flag [added in a previous checkin]. Phase two will remove
15294 Chromium's use of Settings for the Database, and phase three will remove
15295 the Setting for the Database enable entirely, leaving only
15296 Database::isAvailable/setIsAvailable.
15298 No new tests; tested by existing storage tests.
15300 https://bugs.webkit.org/show_bug.cgi?id=35310
15302 * WebView/WebView.mm: Added a call to Database::setIsAvailable.
15303 (-[WebView _preferencesChangedNotification:]):
15305 2010-03-02 Adam Roben <aroben@apple.com>
15307 Add -[WebView _registerURLSchemeAsSecure:]
15309 Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose
15310 SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
15312 Reviewed by Tim Hatcher.
15314 * WebView/WebView.mm:
15315 (+[WebView _registerURLSchemeAsSecure:]):
15316 * WebView/WebViewPrivate.h:
15317 Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
15319 2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
15321 Reviewed by Adam Barth.
15323 Adapt to the new ZoomMode enum.
15324 https://bugs.webkit.org/show_bug.cgi?id=35347
15326 * WebView/WebView.mm:
15327 (-[WebView _preferencesChangedNotification:]):
15328 (-[WebView _setZoomMultiplier:isTextOnly:]):
15329 (-[WebView _realZoomMultiplierIsTextOnly]):
15331 2010-02-27 Jing Jin <jjin@apple.com>
15333 Reviewed by Timothy Hatcher.
15335 Move implementation of Bug 35449 into WebFramePrivate.
15337 * WebView/WebFrame.h:
15338 * WebView/WebFrame.mm:
15339 (-[WebFrame setAllowScrollersToOverlapContent:]):
15340 (-[WebFrame setAlwaysHideHorizontalScroller:]):
15341 (-[WebFrame setAlwaysHideVerticalScroller:]):
15342 * WebView/WebFramePrivate.h:
15344 2010-02-26 Jing Jin <jjin@apple.com>
15346 Reviewed by Timothy Hatcher.
15348 https://bugs.webkit.org/show_bug.cgi?id=35449
15349 Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.
15351 * WebView/WebDynamicScrollBarsView.h:
15352 * WebView/WebDynamicScrollBarsView.mm:
15353 (-[WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]): Allows scrollbars to
15354 overlap with the document and re-layouts the document.
15355 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): Hides the horizontal scrollbar.
15356 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): Hides the vertical scrollbar.
15357 (-[WebDynamicScrollBarsView contentViewFrame]): Calculates the appropriate frame based
15358 on allowScrollersToOverlapContent.
15359 (-[WebDynamicScrollBarsView tile]): If allowScrollersToOverlapContent is YES, set the
15360 contentView's frame so it overlaps with the scrollbar.
15361 (-[WebDynamicScrollBarsView updateScrollers]): Take into account hideHorizontalScroller
15362 and hideVerticalScroller.
15363 (-[WebDynamicScrollBarsView reflectScrolledClipView:]): set drawsBackground to NO when
15364 scrollbars are overlapping with content, so we don't get trails during scrollbar draw updates.
15365 * WebView/WebDynamicScrollBarsViewInternal.h:
15366 * WebView/WebFrame.h:
15367 * WebView/WebFrame.mm:
15368 (-[WebFrame setAllowScrollersToOverlapContent:]): Hook for [WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]
15369 (-[WebFrame setAlwaysHideHorizontalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]
15370 (-[WebFrame setAlwaysHideVerticalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]
15372 2010-02-26 Gavin Barraclough <barraclough@apple.com>
15374 Reviewed by Alexey Proskuryakov.
15376 Bug 35401 - Fix handling of errors in handling calls over bridge,
15377 where base object bridge-type does not match method bridge-type.
15379 The code assumes users will only attempt to invoke a Java method
15380 on a Java base object, etc.
15381 Add language specific subclasses of RuntimeMethod, and pass the
15382 RuntimeMethod into invokeMethod, so we can typecheck before
15383 casting. Throw an exception on type mismatch.
15385 * Plugins/Hosted/ProxyInstance.h:
15386 * Plugins/Hosted/ProxyInstance.mm:
15387 (WebKit::PluginRuntimeMethod::PluginRuntimeMethod): new class to distinguish this type of RuntimeMethod.
15388 (WebKit::ProxyInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
15389 (WebKit::ProxyInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
15391 2010-02-25 Alexey Proskuryakov <ap@apple.com>
15393 Reviewed by Geoffrey Garen.
15395 https://bugs.webkit.org/show_bug.cgi?id=35394
15396 <rdar://problem/7685262> Make passing objects between Java and plug-ins work
15398 Added a ProxyInstance implementation of RuntimeObject.
15400 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15401 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
15402 * Plugins/Hosted/ProxyInstance.h:
15403 * Plugins/Hosted/ProxyInstance.mm:
15404 (WebKit::ProxyInstance::newRuntimeObject):
15405 (WebKit::ProxyInstance::getClass):
15406 * Plugins/Hosted/ProxyRuntimeObject.h: Added.
15407 (WebKit::ProxyRuntimeObject::classInfo):
15408 * Plugins/Hosted/ProxyRuntimeObject.mm: Added.
15409 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
15410 (WebKit::ProxyRuntimeObject::~ProxyRuntimeObject):
15411 (WebKit::ProxyRuntimeObject::getInternalProxyInstance):
15413 2010-02-24 Adam Barth <abarth@webkit.org>
15415 Reviewed by Darin Fisher.
15417 [Chromium API] Disambiguate allowJavaScript from didNotAllowScript
15418 https://bugs.webkit.org/show_bug.cgi?id=35205
15420 Make these two callsites explicit about not running script immediately.
15422 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15423 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
15424 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
15426 2010-02-23 Brady Eidson <beidson@apple.com>
15428 Reviewed by Tim Hatcher and Pavel Feldman.
15430 Regression (r55107) - WebInspector docking is busted.
15431 https://bugs.webkit.org/show_bug.cgi?id=35274
15433 * WebCoreSupport/WebInspectorClient.mm:
15434 (-[WebInspectorWindowController showWindow:]): Swap the order of the "should attach?" check
15435 to get the expected behavior.
15437 2010-02-23 Dan Bernstein <mitz@apple.com>
15439 Reviewed by Simon Fraser.
15441 <rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
15442 https://bugs.webkit.org/show_bug.cgi?id=34381
15444 Test: fast/repaint/repaint-during-scroll.html
15446 NSClipView offsets any rects marked as needing display during scrolling
15447 by the scroll offset. Compensate for this when -setNeedsDisplay: is called
15450 * WebView/WebHTMLView.mm:
15451 (-[WebHTMLView _frameOrBoundsChanged]): Set inScrollPositionChanged to YES
15452 around to call to FrameView::scrollPositionChanged().
15453 (-[WebHTMLView setNeedsDisplayInRect:]): When called beneath
15454 scrollPositionChanged(), adjust the rect by the inverse of the scroll offset.
15456 2010-02-23 Steve Block <steveblock@google.com>
15458 Reviewed by Darin Adler.
15460 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
15461 https://bugs.webkit.org/show_bug.cgi?id=34962
15463 This method is required so that a Geolocation object can cancel an
15464 asynchronous permission request. This allows the chrome client to cancel
15465 any UI it is showing for the permission request.
15467 * WebCoreSupport/WebChromeClient.h:
15468 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
15470 2010-02-22 Alexey Proskuryakov <ap@apple.com>
15472 Rubber-stamped by Geoff Garen.
15474 Rename RuntimeObjectImp to RuntimeObject.
15476 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15477 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
15478 (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
15479 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
15481 2010-02-22 Brady Eidson <beidson@apple.com>
15483 Reviewed by Tim Hatcher.
15485 Disable WebView docking to views that are too small.
15486 <rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
15488 * WebCoreSupport/WebInspectorClient.mm:
15489 (-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector
15490 window attached if WebCore says it shouldn't be attached.
15492 2010-02-22 Simon Fraser <simon.fraser@apple.com>
15494 Reviewed by John Sullivan.
15496 <rdar://problem/7285392>
15497 On Leopard, we have to disable hardware acceleration if we detect that the
15498 installed Core Video framework has bug <rdar://problem/7228836>.
15500 * WebView/WebView.mm:
15501 (coreVideoHas7228836Fix):
15502 (-[WebView _preferencesChangedNotification:]):
15504 2010-02-21 Dan Bernstein <mitz@apple.com>
15506 Reviewed by Darin Adler.
15508 False warnings about needing layout in
15509 -[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
15510 https://bugs.webkit.org/show_bug.cgi?id=35218
15512 * WebView/WebHTMLView.mm:
15513 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
15514 Suppress the warning and the forced layout if the view is not being drawn
15515 in this display operation.
15517 2010-02-21 Kevin Decker <kdecker@apple.com>
15519 Reviewed by Sam Weinig.
15521 plugInViewWithArguments: API sends wrong parameter for WebPlugInBaseURLKey
15522 https://bugs.webkit.org/show_bug.cgi?id=35215
15523 <rdar://problem/7673157>
15525 The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters
15526 is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing
15527 the plug-in's view. Instead of sending the base URL, code in WebFrameLoaderClient::createPlugin
15528 would incorrectly pass the source URL of the plug-in resource.
15530 * WebCoreSupport/WebFrameLoaderClient.mm:
15531 (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the
15532 real base URL for the WebPlugInBaseURLKey key.
15534 2010-02-19 Maciej Stachowiak <mjs@apple.com>
15536 Reviewed by David Levin.
15538 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
15539 https://bugs.webkit.org/show_bug.cgi?id=35147
15541 * Configurations/FeatureDefines.xcconfig:
15543 2010-02-19 Alexey Proskuryakov <ap@apple.com>
15545 Reviewed by Maciej Stachowiak.
15547 https://bugs.webkit.org/show_bug.cgi?id=35132
15548 <rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)
15550 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
15551 (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse
15552 move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout
15553 resorting to techniques such as fast firing timers.
15555 * Plugins/WebNetscapePluginView.mm:
15556 (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally,
15557 but those that don't just need to get an arrow cursor (matching Firefox). This means that
15558 e.g. a plugin inside <A> won't get a finger mouse pointer.
15560 * Plugins/WebHostedNetscapePluginView.mm:
15561 (-[WebNetscapePluginView handleMouseEntered:]):
15562 (-[WebNetscapePluginView handleMouseExited:]):
15563 Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on
15564 mouse exit, which it needed to do.
15566 * WebView/WebHTMLView.mm:
15567 (needsCursorRectsSupportAtPoint):
15569 (resetCursorRects):
15570 Make sure that the same workaround we have for Web content also applies to Netscape plug-ins,
15571 as AppKit would reset the mouse pointer to arrow if given a chance.
15572 (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent
15573 confusion - the method we override is completely different.
15574 (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.
15576 2010-02-19 Simon Fraser <simon.fraser@apple.com>
15578 Reviewed by Dan Bernstein.
15580 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
15582 Followup to avoid capturing compositing layers twice in snapshots. Add private
15583 methods to WebView to specify whether drawing the WebView into an image will
15584 include flattened compositing layers (the default behavior) or not.
15586 * WebView/WebFrame.mm:
15587 (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we
15590 * WebView/WebViewPrivate.h: New methods.
15591 * WebView/WebView.mm: Ditto.
15592 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
15593 (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]):
15594 (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):
15596 * WebView/WebViewData.h: New member variable.
15598 2010-02-19 Alexey Proskuryakov <ap@apple.com>
15600 Reviewed by Dan Bernstein.
15602 https://bugs.webkit.org/show_bug.cgi?id=35165
15603 plugins/set-status.html fails on Windows bot
15605 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15606 (WebKit::NetscapePluginInstanceProxy::status):
15607 * Plugins/WebNetscapePluginView.mm:
15608 (-[WebNetscapePluginView status:]):
15609 Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as
15610 empty ones to chrome.
15612 2010-02-18 Simon Fraser <simon.fraser@apple.com>
15614 Reviewed by Dan Bernstein.
15616 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
15618 Add logic to determine when painting via the software rendering path will give an equivalent
15619 result to the accelerated compositing presentation. This tests for the presence of 3D transforms.
15621 Also have -[WebFrame _drawRect:contentsOnly:] set the PaintBehaviorFlattenCompositingLayers
15622 paint behavior when painting into a bitmap context, so that snapshots contain composited layers.
15624 * WebView/WebFrame.mm:
15625 (-[WebFrame _drawRect:contentsOnly:]): Set the PaintBehaviorFlattenCompositingLayers flag
15626 when painting into a bitmap context.
15627 * WebView/WebView.mm:
15628 (-[WebView _isSoftwareRenderable]): Returns YES if all frames can be software-rendered.
15629 * WebView/WebViewPrivate.h: New _isSoftwareRenderable method.
15631 2010-02-18 Alexey Proskuryakov <ap@apple.com>
15633 Reviewed by Dan Bernstein.
15635 https://bugs.webkit.org/show_bug.cgi?id=35134
15636 <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
15638 Test: plugins/set-status.html
15640 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15641 (WebKit::NetscapePluginInstanceProxy::status):
15642 (WebKit::NetscapePluginInstanceProxy::loadURL):
15643 Added null checks for CFStringCreateWithCString arguments.
15645 2010-02-17 Dmitry Titov <dimich@chromium.org>
15647 Reviewed by David Levin, Darin Fisher, Simon Hausmann.
15649 When a live iframe element is moved between pages, it still depends on the old page.
15650 https://bugs.webkit.org/show_bug.cgi?id=34382
15652 * WebCoreSupport/WebFrameLoaderClient.h:
15653 * WebCoreSupport/WebFrameLoaderClient.mm:
15654 Added empty implementation of a new virtual method.
15656 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
15658 2010-02-17 Kent Tamura <tkent@chromium.org>
15660 Reviewed by Eric Seidel.
15662 Introduces new Icon loading interface in order to support
15663 asynchronous loading.
15664 https://bugs.webkit.org/show_bug.cgi?id=32054
15666 Add an empty implementation of ChromeClient::iconForFiles().
15668 * WebCoreSupport/WebChromeClient.h:
15669 * WebCoreSupport/WebChromeClient.mm:
15670 (WebChromeClient::iconForFiles):
15672 2010-02-17 Timothy Hatcher <timothy@apple.com>
15674 Add a way for WebView and its dependancies to be selectively included
15675 in WebKitStatistics leak tracking. By default WebView is not included and
15676 you need to subclass WebView and implement +isIncludedInWebKitStatistics
15679 rdar://problem/7567677&7572900
15680 https://webkit.org/b/35045
15682 Reviewed by Adam Roben.
15684 * WebView/WebDataSource.mm:
15685 (-[WebDataSource _initWithDocumentLoader:]): Increment WebDataSourceCount if the WebFrame is included in statistics.
15686 (-[WebDataSource dealloc]): Only --WebDataSourceCount if _private->includedInWebKitStatistics is YES.
15687 (-[WebDataSource finalize]): Ditto.
15688 * WebView/WebFrame.mm:
15689 (-[WebFrame _isIncludedInWebKitStatistics]): Return _private->includedInWebKitStatistics.
15690 (-[WebFrame _initWithWebFrameView:webView:]): Increment WebFrameCount if the WebView's class is included in statistics.
15691 (-[WebFrame dealloc]): Only --WebFrameCount if _private->includedInWebKitStatistics is YES.
15692 (-[WebFrame finalize]): Ditto.
15693 * WebView/WebFrameInternal.h:
15694 * WebView/WebFrameView.mm:
15695 (-[WebFrameView _setWebFrame:]): Increment WebFrameViewCount if the WebFrame is included in statistics.
15696 (-[WebFrameView initWithFrame:]): Move ++WebFrameViewCount from here since we don't
15697 know what WebFrame we belong to yet.
15698 (-[WebFrameView dealloc]): Only --WebFrameViewCount if _private->includedInWebKitStatistics is YES.
15699 (-[WebFrameView finalize]): Ditto.
15700 * WebView/WebHTMLRepresentation.mm:
15701 (-[WebHTMLRepresentation init]): Move ++WebHTMLRepresentationCount from here since we don't
15702 know what WebFrame we belong to yet.
15703 (-[WebHTMLRepresentation dealloc]): Only --WebHTMLRepresentationCount if _private->includedInWebKitStatistics is YES.
15704 (-[WebHTMLRepresentation finalize]): Ditto.
15705 (-[WebHTMLRepresentation setDataSource:]): Increment WebHTMLRepresentationCount if the WebFrame of the dataSource is
15706 included in statistics.
15707 * WebView/WebView.mm:
15708 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
15709 (-[WebView dealloc]):
15710 (+[WebView shouldIncludeInWebKitStatistics]): Return NO, so any WebView wont be included.
15711 Subclasses that care can return YES to be included.
15712 * WebView/WebViewInternal.h:
15714 2010-02-16 Darin Adler <darin@apple.com>
15716 Reviewed by Sam Weinig.
15718 Generalize delayed plug-in start for background tabs for use for other media
15719 https://bugs.webkit.org/show_bug.cgi?id=34981
15721 * WebView/WebHTMLView.mm:
15722 (-[WebHTMLView viewWillMoveToWindow:]): Added comment.
15723 (-[WebHTMLView viewDidMoveToWindow]): Ditto.
15725 * WebView/WebView.mm:
15726 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
15727 Call setCanStartMedia right away so that if this view is not in a window, it
15728 will not start any media.
15729 (-[WebView viewWillMoveToWindow:]): Call setCanStartMedia(false) when moving
15730 to a window of nil.
15731 (-[WebView viewDidMoveToWindow]): Call setCanStartMedia(true) when moved to
15732 a window that is non-nil.
15734 2010-02-16 Eric Carlson <eric.carlson@apple.com>
15736 Reviewed by Simon Fraser.
15738 https://bugs.webkit.org/show_bug.cgi?id=34988
15739 WebHTMLView.mm has two -willRemoveSubview: methods
15741 * WebView/WebHTMLView.mm:
15742 (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method.
15744 2010-02-16 Alexey Proskuryakov <ap@apple.com>
15746 Reviewed by Geoffrey Garen and Kevin Decker.
15748 https://bugs.webkit.org/show_bug.cgi?id=34989
15749 <rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content
15751 This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited
15752 in the former case, and adjustCursor in the latter).
15754 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
15755 (-[WebHostedNetscapePluginView handleMouseEntered:]):
15756 (-[WebHostedNetscapePluginView handleMouseExited:]):
15757 * Plugins/WebBaseNetscapePluginView.h:
15758 * Plugins/WebBaseNetscapePluginView.mm:
15759 (-[WebBaseNetscapePluginView handleMouseEntered:]):
15760 (-[WebBaseNetscapePluginView handleMouseExited:]):
15761 * Plugins/WebNetscapePluginView.h:
15762 * Plugins/WebNetscapePluginView.mm:
15763 (-[WebNetscapePluginView handleMouseEntered:]):
15764 (-[WebNetscapePluginView handleMouseExited:]):
15765 AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to
15766 notify plug-in views of mouse entered/exited as part of DOM event dispatch.
15768 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides
15769 mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event
15770 handler. Other mouse events are passed down by EventHandler.
15772 2010-02-15 Alexey Proskuryakov <ap@apple.com>
15774 More build fixing (for what is actually a 64-bit failure, as 32-bit apparently includes
15775 headers that aren't included in 64-bit).
15777 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
15778 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15779 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::contains):
15780 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
15781 Move inline functions to .cpp; also made the class Noncopyable.
15783 2010-02-15 Alexey Proskuryakov <ap@apple.com>
15785 Mac release build fix attempt.
15787 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
15788 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15789 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::~LocalObjectMap):
15790 Implement destructor in .cpp file, where necessary headers are already included.
15792 2010-02-12 Alexey Proskuryakov <ap@apple.com>
15794 Reviewed by Kevin Decker.
15796 <rdar://problem/7130641> Browser objects identity is not preserved by Safari
15798 Out of process part.
15800 To avoid excessive IPC, plugin process doesn't send each NPObject release/retain call to
15801 Safari. It only sends one when the last one is removed, and it can destroy the proxy
15804 However, the browser may be sending the same object out to plug-in as a function call
15805 argument at the same time - neither side can know what the other one is up to. The solution
15806 is to make the "destroying object" call return a boolean result, making it possible for
15807 the browser to make plugin host keep the proxy with zero refcount for a little longer.
15809 * Plugins/Hosted/NetscapePluginHostProxy.mm:
15810 (WKPCForgetBrowserObject): This function (that used to be named ReleaseObject) is only
15811 called when plug-in releases all of its references, so renamed it. Its boolean result
15812 is returned as call success or failure.
15814 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
15815 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap): Made the numeric ID to JSObject map
15818 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15819 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): This method is tricky
15820 in that it creates objects with refcount of 1, but doesn't increase refcount when returning
15821 found objects. This extra count accounts for the "reference" kept by plugin process.
15822 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): Only retaining for the
15823 duration of calls out to plug-in, which means that refcount is almost always equal to 1.
15824 Note that we can't use "++" here, due to how std::pair works!
15825 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): Ditto.
15826 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::clear): Clear all references when
15828 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Like release(), but only
15829 functional when recount is 1 (meaning that the object is not being sent out to plug-in at
15831 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Updated for other changes.
15832 (WebKit::NetscapePluginInstanceProxy::cleanup): Ditto.
15833 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): Ditto.
15834 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): Ditto.
15835 (WebKit::NetscapePluginInstanceProxy::forgetBrowserObjectID): Ditto.
15836 (WebKit::NetscapePluginInstanceProxy::evaluate): Ditto.
15837 (WebKit::NetscapePluginInstanceProxy::invoke): Ditto.
15838 (WebKit::NetscapePluginInstanceProxy::invokeDefault): Ditto.
15839 (WebKit::NetscapePluginInstanceProxy::construct): Ditto.
15840 (WebKit::NetscapePluginInstanceProxy::getProperty): Ditto.
15841 (WebKit::NetscapePluginInstanceProxy::setProperty): Ditto.
15842 (WebKit::NetscapePluginInstanceProxy::removeProperty): Ditto.
15843 (WebKit::NetscapePluginInstanceProxy::hasProperty): Ditto.
15844 (WebKit::NetscapePluginInstanceProxy::hasMethod): Ditto.
15845 (WebKit::NetscapePluginInstanceProxy::enumerate): Ditto.
15846 (WebKit::NetscapePluginInstanceProxy::addValueToArray): Ditto.
15847 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
15848 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Helper for calling retain when
15849 making calls out to plug-in. No-op for objects that aren't wrapped to be sent (i.e. for
15850 objects wrapping ProxyInstance wrappers for plug-in objects being sent bak).
15851 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
15853 * Plugins/Hosted/ProxyInstance.mm:
15854 (WebKit::ProxyInstance::invoke): Retain/release arguments during call.
15855 (WebKit::ProxyInstance::setFieldValue): Ditto.
15857 * Plugins/Hosted/WebKitPluginClient.defs: Renamed PCReleaseObject to PCForgetBrowserObject.
15859 2010-02-12 Darin Adler <darin@apple.com>
15861 Reviewed by Sam Weinig.
15863 Removed unneeded custom implementation of isDescendantOf.
15865 * Plugins/WebBaseNetscapePluginView.mm:
15866 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Use the
15867 -[NSView isDescendantOf:] method instead of our own method
15868 named superviewsHaveSuperviews.
15870 2010-02-12 Dan Bernstein <mitz@apple.com>
15872 Reviewed by Darin Adler.
15874 <rdar://problem/7615234> REGRESSION (r48586): Loading an HTML page causes
15875 PDFKit to be loaded
15877 * WebView/WebPDFDocumentExtras.h: Removed the category declaration and
15878 addWebPDFDocumentExtras(). Declare allScriptsInPDFDocument().
15879 * WebView/WebPDFDocumentExtras.mm:
15880 (allScriptsInPDFDocument): Changed the -_web_allScripts method into this function.
15881 * WebView/WebPDFRepresentation.mm: Removed +initialize.
15882 (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use
15883 allScriptsInPDFDocument() instead of -_web_allScripts.
15885 2010-02-10 Geoffrey Garen <ggaren@apple.com>
15887 Reviewed by Oliver Hunt.
15889 Exported some new JavaScript heap introspection.
15891 * Misc/WebCoreStatistics.h:
15892 * Misc/WebCoreStatistics.mm:
15893 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Just like
15894 javaScriptProtectedObjectTypeCounts, except this function enumerates all
15895 live objects, not just protected objects.
15897 2010-02-08 Maciej Stachowiak <mjs@apple.com>
15899 Reviewed by Cameron Zwarich.
15901 Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
15902 https://bugs.webkit.org/show_bug.cgi?id=34698
15904 * Configurations/FeatureDefines.xcconfig:
15906 2010-02-09 Alexey Proskuryakov <ap@apple.com>
15908 Reviewed by Geoffrey Garen.
15910 https://bugs.webkit.org/show_bug.cgi?id=34490
15911 WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions
15913 * ForwardingHeaders/wtf/ValueCheck.h: Added.
15915 2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
15917 Reviewed by Kenneth Rohde Christiansen.
15919 Support frameset flattening
15920 https://bugs.webkit.org/show_bug.cgi?id=32717
15922 Add support for enabling/disabling FrameSet Flattening on the Mac port.
15924 * WebView/WebPreferenceKeysPrivate.h:
15925 * WebView/WebPreferences.mm:
15926 (+[WebPreferences initialize]):
15927 (-[WebPreferences isFrameSetFlatteningEnabled]):
15928 (-[WebPreferences setFrameSetFlatteningEnabled:]):
15929 * WebView/WebPreferencesPrivate.h:
15930 * WebView/WebView.mm:
15931 (-[WebView _preferencesChangedNotification:]):
15933 2010-02-09 Alexey Proskuryakov <ap@apple.com>
15935 Reviewed by Anders Carlsson.
15937 https://bugs.webkit.org/show_bug.cgi?id=34771
15938 A stray mouse moved event is sent to plug-ins after mouse exit
15940 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): A mouseout
15941 DOM event is dispatched while handling NSMouseMoved - but we shouldn't be sending a
15942 mouse moved event to plug-ins at this point.
15944 2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
15946 Reviewed by Darin Adler.
15948 Provide a way to get total number of pages to be printed
15949 https://bugs.webkit.org/show_bug.cgi?id=34699
15951 * Misc/WebCoreStatistics.h:
15952 * Misc/WebCoreStatistics.mm:
15953 (-[WebFrame numberOfPages:pageWidthInPixels:]):
15955 2010-02-08 Alexey Proskuryakov <ap@apple.com>
15957 Reviewed by Darin Adler.
15959 https://bugs.webkit.org/show_bug.cgi?id=34727
15960 Assertion crashes and freezes when plug-in property access results in an exception
15962 * Plugins/Hosted/WebKitPluginClient.defs: Made PCSetProperty and PCRemoveProperty async.
15963 A plug-in can call back whil processing this call (e.g. for NPN_SetException), so we need
15964 to listen for messages while waiting for reply.
15966 * Plugins/Hosted/NetscapePluginHostProxy.mm:
15967 (WKPCEvaluate): If there is no instance proxy, return KERN_FAILURE. This improves consistency
15968 between method implementations, and leaves us with one less IPC call to make in failure case
15969 (returning false with KERN_SUCCESS and returning KERN_FAILURE looks the same from plugin
15971 (WKPCInvoke): Ditto.
15972 (WKPCInvokeDefault): Ditto.
15973 (WKPCGetProperty): Ditto.
15974 (WKPCSetProperty): Send a reply once done.
15975 (WKPCRemoveProperty): Ditto.
15976 (WKPCHasProperty): If there is no instance proxy, return KERN_FAILURE.
15977 (WKPCHasMethod): Ditto.
15978 (WKPCEnumerate): Ditto.
15980 2010-02-08 Alexey Proskuryakov <ap@apple.com>
15982 Reviewed by Anders Carlsson.
15984 <rdar://problem/6530010> OOP: Support NPN_SetException
15986 Tested by plugins/netscape-throw-exception.html (removed it from skipped list).
15988 * Plugins/Hosted/NetscapePluginHostProxy.mm:
15989 (WKPCSetException):
15990 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
15991 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15992 (WebKit::globalExceptionString):
15993 (WebKit::NetscapePluginInstanceProxy::setGlobalException):
15994 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
15995 * Plugins/Hosted/ProxyInstance.mm:
15996 (WebKit::ProxyInstance::invoke):
15997 (WebKit::ProxyInstance::getPropertyNames):
15998 (WebKit::ProxyInstance::fieldValue):
15999 (WebKit::ProxyInstance::setFieldValue):
16000 * Plugins/Hosted/WebKitPluginClient.defs:
16001 Route exception string to a global that's checked after calling into plug-in (just like in
16004 2010-02-05 Kevin Decker <kdecker@apple.com>
16006 Reviewed by Mark Rowe.
16008 https://bugs.webkit.org/show_bug.cgi?id=34661
16009 <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden
16011 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
16012 (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
16013 * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
16014 * Plugins/WebBaseNetscapePluginView.mm:
16015 (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView.
16016 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
16017 * Plugins/WebNetscapePluginView.mm:
16018 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
16020 2010-02-04 Mark Rowe <mrowe@apple.com>
16022 Rubber-stamped by Dan Bernstein.
16024 Fix the ability to #include <WebKit/DOMFile.h>.
16026 * MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
16028 2010-02-04 John Sullivan <sullivan@apple.com>
16030 https://bugs.webkit.org/show_bug.cgi?id=34611
16031 WebLocalizedString() could use an assertion that it is being called on the main thread
16033 Reviewed by Tim Hatcher.
16035 * Misc/WebLocalizableStrings.m: Removed.
16036 * Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
16037 Renamed to use .mm extension so it can include a C++ header.
16038 (WebLocalizedString):
16039 Added an assertion that this is being called on the main thread.
16041 2010-02-04 Dan Bernstein <mitz@apple.com>
16043 Reviewed by Simon Fraser.
16045 REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
16046 https://bugs.webkit.org/show_bug.cgi?id=34371
16048 * WebView/WebFrameView.mm:
16049 (-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
16050 constants, and cap the scroll distance.
16051 (-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
16052 cScrollbarPixelsPerLineStep.
16053 (-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
16054 constants, and cap the scroll distance.
16056 2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
16058 Reviewed by Eric Seidel.
16060 Provide a way to get page number with layoutTestController
16061 https://bugs.webkit.org/show_bug.cgi?id=33840
16063 * Misc/WebCoreStatistics.h:
16064 * Misc/WebCoreStatistics.mm:
16065 (-[WebFrame pageNumberForElement:element:pageWidth:]):
16067 2010-01-29 Gavin Barraclough <barraclough@apple.com>
16069 Reviewed by Sam Weinig + Oliver Hunt.
16071 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
16073 Pass processeing user gensture flag to media play/pause methods.
16075 * WebView/WebVideoFullscreenHUDWindowController.mm:
16076 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
16078 2010-02-01 Dan Bernstein <mitz@apple.com>
16080 Reviewed by Anders Carlsson.
16082 <rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()
16084 The crash was caused by having two streams with a streamID of 1.
16086 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
16087 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
16088 correctly increments m_currentURLRequestID to account for the manual stream.
16089 (WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
16090 null it out instead of trying to remove it from the map. Added an assertion.
16091 (WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.
16093 == Rolled over to ChangeLog-2010-01-29 ==