1 2012-05-29 David Barr <davidbarr@chromium.org>
3 Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
4 https://bugs.webkit.org/show_bug.cgi?id=87685
6 Reviewed by Eric Seidel.
8 Add a configuration option for CSS image-resolution support, disabling it by default.
10 * Configurations/FeatureDefines.xcconfig:
12 2012-05-29 Nikolas Zimmermann <nzimmermann@rim.com>
14 SVGViewSpec DOM bindings aka SVGSVGElement.currentView is unimplemented
15 https://bugs.webkit.org/show_bug.cgi?id=15495
19 * MigrateHeaders.make: Copy DOMSVGViewSpec*.h headers.
21 2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
23 WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
24 https://bugs.webkit.org/show_bug.cgi?id=42328
26 Reviewed by Eric Seidel.
28 * WebInspector/WebInspector.mm:
29 (-[WebInspector setJavaScriptProfilingEnabled:]):
31 2012-05-24 Tim Horton <timothy_horton@apple.com>
33 Add feature defines for web-facing parts of CSS Regions and Exclusions
34 https://bugs.webkit.org/show_bug.cgi?id=87442
35 <rdar://problem/10887709>
37 Reviewed by Dan Bernstein.
39 * Configurations/FeatureDefines.xcconfig:
41 2012-05-24 John Mellor <johnme@chromium.org>
43 Font Boosting: Add compile flag and runtime setting
44 https://bugs.webkit.org/show_bug.cgi?id=87394
46 Reviewed by Adam Barth.
48 Add ENABLE_FONT_BOOSTING.
50 * Configurations/FeatureDefines.xcconfig:
52 2012-05-23 Ojan Vafai <ojan@chromium.org>
54 add back the ability to disable flexbox
55 https://bugs.webkit.org/show_bug.cgi?id=87147
57 Reviewed by Tony Chang.
59 * Configurations/FeatureDefines.xcconfig:
61 2012-05-22 Tim Horton <timothy_horton@apple.com>
63 Add a quirk for applications that depend on the relative ordering of progressCompleted/didFinishLoad
64 https://bugs.webkit.org/show_bug.cgi?id=87178
65 <rdar://problem/11468434>
67 Reviewed by Maciej Stachowiak.
69 Add plumbing for the quirk to flip the relative ordering of progressCompleted/didFinishLoad back
70 to the behavior before http://trac.webkit.org/changeset/94105. Make it apply to any Mail.app linked
71 against WebKit before that revision.
73 * Misc/WebKitVersionChecks.h:
75 (-[WebView _needsDidFinishLoadOrderQuirk]):
76 (-[WebView _preferencesChanged:]):
78 2012-05-21 Gavin Barraclough <barraclough@apple.com>
80 Disable private names by default in WebCore
81 https://bugs.webkit.org/show_bug.cgi?id=87088
83 Reviewed by Geoff Garen.
85 r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.
86 These are probably not yet ready to be web-facing, so disabling by default in WebCore.
87 Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.
89 * WebView/WebPreferenceKeysPrivate.h:
90 * WebView/WebPreferences.mm:
91 (+[WebPreferences initialize]):
92 (-[WebPreferences setJavaScriptExperimentsEnabled:]):
93 (-[WebPreferences javaScriptExperimentsEnabled]):
94 * WebView/WebPreferencesPrivate.h:
96 (-[WebView _preferencesChanged:]):
97 - Added JavaScriptExperimentsEnabled to WebPreferences.
99 2012-05-15 Gavin Barraclough <barraclough@apple.com>
101 Add support for private names
102 https://bugs.webkit.org/show_bug.cgi?id=86509
104 Reviewed by Oliver Hunt.
106 The spec isn't final, but we can start adding support to allow property maps
107 to contain keys that aren't identifiers.
109 * Plugins/Hosted/ProxyInstance.mm:
110 (WebKit::ProxyClass::methodsNamed):
111 (WebKit::ProxyClass::fieldNamed):
112 (WebKit::ProxyInstance::getMethod):
113 (WebKit::ProxyInstance::methodsNamed):
114 (WebKit::ProxyInstance::fieldNamed):
115 - Removed PropertyName::impl(), call publicName() to get the string associated with a name.
117 2012-05-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
119 Move setEditingBehavior() from layoutTestController to window.internals
120 https://bugs.webkit.org/show_bug.cgi?id=42689
122 Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
124 Remove Mac private API to get/set the editing behavior, since it was only there
128 * WebView/WebFrame.mm:
129 * WebView/WebFrameInternal.h:
130 * WebView/WebPreferenceKeysPrivate.h:
131 * WebView/WebPreferences.mm:
132 (+[WebPreferences initialize]):
133 * WebView/WebPreferencesPrivate.h:
134 * WebView/WebView.mm:
135 (-[WebView _preferencesChanged:]):
137 2012-05-20 Ryosuke Niwa <rniwa@webkit.org>
139 Using createContextualFragment to insert a <script> does not cause the script to execute
140 https://bugs.webkit.org/show_bug.cgi?id=12234
142 Reviewed by Adam Barth.
144 Renamed FragmentScriptingNotAllowed to DisallowScriptingContent.
146 * WebView/WebFrame.mm:
147 (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
149 2012-05-19 Andy Estes <aestes@apple.com>
151 Fix build errors found when disabling ENABLE_DRAG_SUPPORT
152 https://bugs.webkit.org/show_bug.cgi?id=86947
154 Reviewed by Jon Honeycutt.
156 * WebCoreSupport/WebDragClient.h:
157 * WebCoreSupport/WebDragClient.mm:
158 * WebView/WebFrame.mm:
159 * WebView/WebFrameInternal.h:
160 * WebView/WebFrameView.mm:
161 (-[WebFrameView _setDocumentView:]):
162 * WebView/WebHTMLView.mm:
163 (-[WebHTMLView acceptsFirstMouse:]):
164 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
165 (matchesExtensionOrEquivalent):
166 * WebView/WebView.mm:
167 (-[WebView _commonInitializationWithFrameName:groupName:]):
168 (-[WebView moveDragCaretToPoint:]):
169 (-[WebView removeDragCaret]):
171 2012-04-27 Filip Pizlo <fpizlo@apple.com>
173 DFG should have control flow graph simplification
174 https://bugs.webkit.org/show_bug.cgi?id=84553
176 Reviewed by Oliver Hunt.
178 Merged r115512 from dfgopt.
180 JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()
182 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
183 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
185 2012-05-18 Tony Chang <tony@chromium.org>
187 remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
188 https://bugs.webkit.org/show_bug.cgi?id=86767
190 Reviewed by Ojan Vafai.
192 * Configurations/FeatureDefines.xcconfig:
193 * WebView/WebPreferenceKeysPrivate.h:
194 * WebView/WebPreferences.mm:
195 (+[WebPreferences initialize]):
196 (-[WebPreferences cssGridLayoutEnabled]):
197 (-[WebPreferences setCSSGridLayoutEnabled:]):
198 * WebView/WebPreferencesPrivate.h:
199 * WebView/WebView.mm:
200 (-[WebView _preferencesChanged:]):
202 2012-05-18 MORITA Hajime <morrita@google.com>
204 Another unreviewed attempt to fix build breakage on r117572.
206 * WebCoreSupport/WebEditorClient.h:
208 2012-05-18 MORITA Hajime <morrita@google.com>
210 https://bugs.webkit.org/show_bug.cgi?id=85515
211 Stale frame in WebCore::SpellChecker::didCheckSucceeded
213 Reviewed by Ryosuke Niwa.
215 * WebCoreSupport/WebEditorClient.h:
217 2012-05-17 Andy Estes <aestes@apple.com>
219 Don't let -[CALayer renderInContext:] try to render WebView's root layer
220 https://bugs.webkit.org/show_bug.cgi?id=86773
221 <rdar://problem/10950075>
223 Reviewed by Dan Bernstein.
225 -[CALayer renderInContext:] doesn't correctly render our layer tree, so
226 don't let it try. Calling drawRect: with a bitmap context will already
227 do the right thing for WebViews.
229 * WebView/WebHTMLView.mm: Create a subclass of CALayer called WebLayerHostingLayer.
230 (-[WebLayerHostingLayer renderInContext:]): override renderInContext: to be a NOOP.
231 (-[WebHTMLView attachRootLayer:]): Create a WebLayerHostingLayer rather than a CALayer.
233 2012-05-17 Hironori Bono <hbono@chromium.org>
235 [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
236 https://bugs.webkit.org/show_bug.cgi?id=86591
238 Reviewed by Ryosuke Niwa.
240 This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
241 function to remove platform-specific code from Editor::respondToChangedSelection
244 No new tests, no change in behavior.
246 * WebCoreSupport/WebEditorClient.h:
247 * WebCoreSupport/WebEditorClient.mm:
248 (WebEditorClient::shouldEraseMarkersAfterChangeSelection):
250 2012-05-17 Dan Bernstein <mitz@apple.com>
252 REGRESSION (r117428): WebKit API/SPI was removed
253 https://bugs.webkit.org/show_bug.cgi?id=86748
258 * WebView/WebView.mm:
259 (+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
260 * WebView/WebViewPrivate.h:
262 2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
264 Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
265 https://bugs.webkit.org/show_bug.cgi?id=86704
267 Reviewed by Eric Seidel.
269 Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
270 cross-port way through the InternalSettings interface.
273 * WebView/WebView.mm:
274 * WebView/WebViewPrivate.h:
276 2012-05-15 Anders Carlsson <andersca@apple.com>
278 Use unaccelerated scrolling deltas when rubber-banding
279 https://bugs.webkit.org/show_bug.cgi?id=86503
280 <rdar://problem/11378742>
282 Reviewed by Sam Weinig.
284 * WebCoreSupport/WebSystemInterface.mm:
285 (InitWebCoreSystemInterface):
286 Init new WKSI functions.
288 2012-05-14 Luke Macpherson <macpherson@chromium.org>
290 Introduce ENABLE_CSS_VARIABLES compile flag.
291 https://bugs.webkit.org/show_bug.cgi?id=86338
293 Reviewed by Dimitri Glazkov.
295 Add a configuration option for CSS Variables support, disabling it by default.
297 * Configurations/FeatureDefines.xcconfig:
299 2012-05-14 Michael Saboff <msaboff@apple.com>
301 Enh: Add the Ability to Disable / Enable JavaScript GC Timer
302 https://bugs.webkit.org/show_bug.cgi?id=86382
304 Reviewed by Darin Adler.
306 Plumbing to set / clear JS GC activity timer enable flag.
308 * Misc/WebCoreStatistics.h:
309 * Misc/WebCoreStatistics.mm:
310 (+[WebCoreStatistics setJavaScriptGarbageCollectorTimerEnabled:]):
312 2012-05-11 Gavin Barraclough <barraclough@apple.com>
314 Introduce PropertyName class
315 https://bugs.webkit.org/show_bug.cgi?id=86241
317 Reviewed by Geoff Garen.
319 Replace 'const Identifier&' arguments to functions accessing object properties with a new 'PropertyName' type.
320 This change paves the way to allow for properties keyed by values that are not Identifiers.
322 This change is largely a mechanical find & replace.
323 It also changes JSFunction's constructor to take a UString& instead of an Identifier&
324 (since in some cases we can no longer guarantee that we'lll have an Identifier), and
325 unifies Identifier's methods to obtain array indices onto PropertyName.
327 The new PropertyName class retains the ability to support .impl() and .ustring(), but
328 in a future patch we may need to rework this, since not all PropertyNames should be
329 equal based on their string representation.
331 * Plugins/Hosted/ProxyInstance.h:
333 * Plugins/Hosted/ProxyInstance.mm:
335 (WebKit::ProxyClass::methodsNamed):
336 (WebKit::ProxyClass::fieldNamed):
337 (WebKit::ProxyRuntimeMethod::create):
338 (WebKit::ProxyRuntimeMethod::finishCreation):
339 (WebKit::ProxyInstance::getMethod):
340 (WebKit::ProxyInstance::methodsNamed):
341 (WebKit::ProxyInstance::fieldNamed):
343 2012-05-11 Brady Eidson <beidson@apple.com>
345 <rdar://problem/11361907> and https://bugs.webkit.org/show_bug.cgi?id=86265
346 REGRESSION(r104885): Images missing from printed YummySoup! recipes
348 We thought clients were passing paths as URLs.
349 It turns out it was more likely they were passing file: URLs with the file: scheme removed.
350 And that jives perfectly with the behavior change caused by r104885.
352 Reviewed by Alexey Proskuryakov.
354 Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrSchemelessFileURL, and change it
355 to create the new URL simply by appending "file:":
356 * Misc/WebNSURLExtras.h:
357 * Misc/WebNSURLExtras.mm:
358 (-[NSURL _webkit_URLFromURLOrSchemelessFileURL]):
360 * WebView/WebFrame.mm:
361 (-[WebFrame loadRequest:]): Create the fixed url simply by appending "file:" to the
363 (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
364 (-[WebFrame loadHTMLString:baseURL:]):
365 (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]):
367 2012-05-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
369 Move resumeAnimations to use Internals interface
370 https://bugs.webkit.org/show_bug.cgi?id=86063
372 Reviewed by Alexey Proskuryakov.
374 Remove resumeAnimations functions, because it is able to work in the
375 cross-port way through the Internals interface.
378 * WebView/WebFrame.mm:
379 * WebView/WebFramePrivate.h:
381 2012-05-10 Anders Carlsson <andersca@apple.com>
383 WebKit1: Add a way to blacklist specific plug-ins/plug-in versions
384 https://bugs.webkit.org/show_bug.cgi?id=86150
385 <rdar://problem/9551196>
387 Reviewed by Sam Weinig.
389 * Misc/WebKitErrors.h:
390 Add WebKitErrorInsecurePlugInVersion enum.
392 * Plugins/WebBasePluginPackage.h:
393 * Plugins/WebBasePluginPackage.mm:
394 (-[WebBasePluginPackage bundleIdentifier]):
395 (-[WebBasePluginPackage bundleVersion]):
396 Add bundleIdentifier and bundleVersion getters.
398 * WebCoreSupport/WebFrameLoaderClient.mm:
399 (WebFrameLoaderClient::createPlugin):
400 Check if the plug-in is blocked. If it is, set the unavailability reason and the error code.
402 2012-05-10 Anders Carlsson <andersca@apple.com>
404 Rename the missing plug-in indicator to the unavailable plug-in indicator
405 https://bugs.webkit.org/show_bug.cgi?id=86136
407 Reviewed by Sam Weinig.
409 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
410 (-[WebHostedNetscapePluginView pluginHostDied]):
411 * WebCoreSupport/WebChromeClient.h:
412 * WebCoreSupport/WebChromeClient.mm:
413 (WebChromeClient::shouldUnavailablePluginMessageBeButton):
414 (WebChromeClient::unavailablePluginButtonClicked):
416 2012-05-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
418 Move suspendAnimations to use Internals interface.
419 https://bugs.webkit.org/show_bug.cgi?id=85986
421 Reviewed by Ryosuke Niwa.
423 Remove suspendAnimations functions, because it is able to work in the
424 cross-port way through the Internals interface.
427 * WebView/WebFrame.mm:
428 * WebView/WebFramePrivate.h:
430 2012-05-08 Kent Tamura <tkent@chromium.org>
432 Fixe Chromium build, and add a FIXME comment about a layering violation.
434 * WebCoreSupport/WebSystemInterface.mm:
435 (InitWebCoreSystemInterface):
437 2012-05-08 Jon Lee <jonlee@apple.com>
439 Safari warns that it needs to resend the form in an iFrame when going back
440 https://bugs.webkit.org/show_bug.cgi?id=82658
441 <rdar://problem/11292558>
443 Reviewed by Darin Adler.
445 * WebCoreSupport/WebSystemInterface.mm:
446 (InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.
448 2012-05-08 Timothy Hatcher <timothy@apple.com>
450 Fix the SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL macro so it passes the full path to dlopen.
452 <rdar://problem/11406517>
454 Reviewed by Mark Rowe.
456 * WebCoreSupport/WebInspectorClient.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.
458 2012-05-07 Andy Estes <aestes@apple.com>
460 ENABLE_IFRAME_SEAMLESS should be part of FEATURE_DEFINES.
462 * Configurations/FeatureDefines.xcconfig:
464 2012-05-07 Eric Seidel <eric@webkit.org>
466 Add ENABLE_IFRAME_SEAMLESS so Apple can turn off SEAMLESS if needed
467 https://bugs.webkit.org/show_bug.cgi?id=85822
469 Reviewed by Adam Barth.
471 * Configurations/FeatureDefines.xcconfig:
473 2012-05-05 Dean Jackson <dino@apple.com>
475 Add new Setting/Preference to disable requestAnimationFrame
476 https://bugs.webkit.org/show_bug.cgi?id=85693
478 Reviewed by Simon Fraser.
480 Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
481 The default value is true. The majority of applications will leave
484 * WebView/WebPreferenceKeysPrivate.h:
485 * WebView/WebPreferences.mm:
486 (+[WebPreferences initialize]):
487 (-[WebPreferences requestAnimationFrameEnabled]):
488 (-[WebPreferences setRequestAnimationFrameEnabled:]):
489 * WebView/WebPreferencesPrivate.h:
490 * WebView/WebView.mm:
491 (-[WebView _preferencesChanged:]):
493 2012-05-04 Jer Noble <jer.noble@apple.com>
495 REGRESSION (r116127-r116165): 6 tests failing on Lion Debug (Tests)
496 https://bugs.webkit.org/show_bug.cgi?id=85674
498 Reviewed by Oliver Hunt.
500 Null check the results of core([frame DOMDocument]).
502 * WebView/WebView.mm:
503 (-[WebView _didStartProvisionalLoadForFrame:]):
505 2012-05-02 Jer Noble <jer.noble@apple.com>
507 Taking a visibility:hidden element full screen causes full screen window to disappear.
508 https://bugs.webkit.org/show_bug.cgi?id=85432
510 Reviewed by Maciej Stachowiak.
512 When given an initial or final frame with a zero width or height, return a rect representing
513 the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
514 confuse the window server when it's instructed to scale the full screen window to that size.
516 * WebView/WebFullScreenController.mm:
517 (windowFrameFromApparentFrames):
519 2012-05-04 Jer Noble <jer.noble@apple.com>
521 Full screen will exit during a provisional load of a non-ancestor iframe.
522 https://bugs.webkit.org/show_bug.cgi?id=85230
524 Reviewed by Maciej Stachowiak .
526 Only exit full screen mode if the frame being loaded contains the full
529 * WebView/WebView.mm:
530 (-[WebView _didStartProvisionalLoadForFrame:]): Give the UIDelegate a first crack at handling the
531 request to close the full screen window when a provisional load occurs.
533 2012-05-04 Jer Noble <jer.noble@apple.com>
535 Move WebKitFullScreenListener into its own file.
536 https://bugs.webkit.org/show_bug.cgi?id=85640
538 Reviewed by Maciej Stachowiak.
540 Move WebKitFullScreenListener into its own file, so it can be used by multiple classes.
542 * WebCoreSupport/WebKitFullScreenListener.h: Added.
543 * WebCoreSupport/WebKitFullScreenListener.mm: Added.
544 (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
545 (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
546 (-[WebKitFullScreenListener webkitWillExitFullScreen]):
547 (-[WebKitFullScreenListener webkitDidExitFullScreen]):
548 * WebCoreSupport/WebChromeClient.mm:
550 2012-05-04 Brady Eidson <beidson@apple.com>
552 <rdar://problem/11312853> and https://bugs.webkit.org/show_bug.cgi?id=85635
553 Exception in [WebFrame loadRequest:] breaks some WebKit apps
555 Reviewed by Alexey Proskuryakov.
557 Some API clients pass in nil requests or requests with nil URLs.
558 In r112571 we started rewriting these URLs resulting in an exception.
559 Since we've supported nil requests until now, we should not try to rewrite these URLs.
561 * WebView/WebFrame.mm:
562 (-[WebFrame loadRequest:]): Don't try to rewrite invalid URLs if they are also null.
564 2012-05-04 Nate Chapin <japhet@chromium.org>
566 Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
567 https://bugs.webkit.org/show_bug.cgi?id=85533
569 Reviewed by Alexey Proskuryakov.
571 * WebView/WebHTMLRepresentation.mm:
572 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Calling commitData when finishing is no longer necessary,
573 as WebCore will take care of simulating the receipt of data and ensuring the requisite work gets done in the blank document case.
575 2012-05-03 Anders Carlsson <andersca@apple.com>
577 useWebKitWebInspector should be more robust against missing files
578 https://bugs.webkit.org/show_bug.cgi?id=85563
579 <rdar://problem/11373948>
581 Reviewed by Dan Bernstein.
583 * WebCoreSupport/WebInspectorClient.mm:
584 (useWebKitWebInspector):
586 2012-05-03 Tobias Netzel <tobias.netzel@googlemail.com>
588 Bugs in WebFullScreenController
589 https://bugs.webkit.org/show_bug.cgi?id=85388
591 Reviewed by Alexey Proskuryakov.
593 Leopard specific fixes:
594 NSWindow doesn't respond to isOnActiveSpace so find out first.
595 Values passed to SetSystemUIMode were swapped.
597 * WebView/WebFullScreenController.mm:
598 (-[WebFullScreenController exitFullScreen]):
599 (-[WebFullScreenController _updateMenuAndDockForFullScreen]):
601 2012-05-02 Jon Lee <jonlee@apple.com>
603 Migrate permission functions to Notification from NotificationCenter
604 https://bugs.webkit.org/show_bug.cgi?id=80485
605 <rdar://problem/10965458>
609 * WebCoreSupport/WebNotificationClient.h: *
610 WebCoreSupport/WebNotificationClient.mm: Add a separate callback
611 variable depending on the notifications API enabled.
612 (WebNotificationClient::requestPermission): Add
613 NotificationPermissionCallback version of the same
614 function. And refactor common code into private function.
615 (-[WebNotificationPolicyListener initWithCallback:]): Refactor to
616 take the NotificationPermissionCallback as a parameter.
617 (-[WebNotificationPolicyListener initWithVoidCallback:]): Add new
618 init method to handle legacy API.
619 (-[WebNotificationPolicyListener allow]): Invoke the callback for
620 both variables. If only one of the APIs is enabled, we are
621 guaranteed that the relevant callback variable exists. If both
622 APIs are supported, it is possible that _voidCallback will be nil
623 if the callback is NotificationPermissionCallback, so we need the
625 (-[WebNotificationPolicyListener deny]): Ditto.
627 2012-05-02 Eric Seidel <eric@webkit.org>
629 Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate)
630 https://bugs.webkit.org/show_bug.cgi?id=85433
632 Reviewed by Adam Barth.
634 I have a script which can autogenerate these xcconfig files as well as the
635 vsprops files (and soon the Chromium, cmake, gnumake and qmake) feature lists
636 from a central feature list file.
637 In preparation for posting such a tool, I'm re-sorting these xcconfig files to be
638 alphabetically ordered (currently they're close, but not quite).
639 There is also at least one inconsistency between these files (CSS_LEGACY_PREFIXES) which
640 I will fix in a second pass. I will also sort the FEATURE_DEFINES = line in a follow-up patch.
642 * Configurations/FeatureDefines.xcconfig:
644 2012-04-18 Jon Honeycutt <jhoneycutt@apple.com>
646 FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
647 information about the form being submitted
648 https://bugs.webkit.org/show_bug.cgi?id=84297
650 Reviewed by Andy Estes.
652 * WebCoreSupport/WebFrameLoaderClient.h:
653 Updated method declaration.
655 2012-05-01 Jon Honeycutt <jhoneycutt@apple.com>
657 Make Page::setDefersLoading() have a call count so that each time
658 loading is deferred, it must be balanced with a call to resume.
659 https://bugs.webkit.org/show_bug.cgi?id=84522
661 Reviewed by Andy Estes.
663 * WebView/WebPreferenceKeysPrivate.h:
664 Declare a new key for this preference.
666 * WebView/WebPreferences.mm:
667 (+[WebPreferences initialize]):
668 Initialize new preference to NO.
669 (-[WebPreferences setWantsBalancedSetDefersLoadingBehavior:]):
671 (-[WebPreferences wantsBalancedSetDefersLoadingBehavior]):
674 * WebView/WebPreferencesPrivate.h:
675 Declare setter and getter.
677 * WebView/WebView.mm:
678 (-[WebView _preferencesChanged:]):
679 Set the setting from the WebPreferences object's value.
681 2012-05-01 Jeffrey Pfau <jpfau@apple.com>
683 <rdar://problem/10422318> Support for web content filter delegate for filtering https content
684 https://bugs.webkit.org/show_bug.cgi?id=85300
686 Reviewed by Alexey Proskuryakov.
688 * WebCoreSupport/WebSystemInterface.mm:
689 (InitWebCoreSystemInterface):
691 2012-05-01 Ryosuke Niwa <rniwa@webkit.org>
693 *Command.h files shouldn't be exported to WebKit layer
694 https://bugs.webkit.org/show_bug.cgi?id=74778
696 Reviewed by Eric Seidel.
698 * WebView/WebFrame.mm:
699 (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
701 2012-04-28 Geoffrey Garen <ggaren@apple.com>
703 Clarified JSGlobalData (JavaScript VM) lifetime
704 https://bugs.webkit.org/show_bug.cgi?id=85142
706 Reviewed by Anders Carlsson.
708 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
709 (WebKit::NetscapePluginInstanceProxy::invoke):
710 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
711 (WebKit::NetscapePluginInstanceProxy::construct):
713 2012-04-27 Gavin Peters <gavinp@chromium.org>
715 Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
716 https://bugs.webkit.org/show_bug.cgi?id=84871
718 Reviewed by Adam Barth.
720 Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
721 API separates it from prefetching. Having separate include guards lets ports enable prefetching,
722 a relatively easy change, without needing to build the infrastructure for prerendering, which
723 is considerably more complicated.
725 2012-04-26 Jon Lee <jonlee@apple.com>
727 [WK2] AlternativeTextClient leaks when the page is destroyed
728 https://bugs.webkit.org/show_bug.cgi?id=84307
729 <rdar://problem/11328431>
731 Reviewed by Enrica Casucci.
733 * WebCoreSupport/WebAlternativeTextClient.h: Implement pageDestroyed(), as in EditorClient.
734 (WebAlternativeTextClient):
735 * WebCoreSupport/WebAlternativeTextClient.mm:
736 (WebAlternativeTextClient::pageDestroyed): Deletes itself.
738 2012-04-26 Jer Noble <jer.noble@apple.com>
740 Full Screen mode does not preserve CALayer ordering after exiting.
741 https://bugs.webkit.org/show_bug.cgi?id=83931
743 Reviewed by Eric Carlson.
745 Further corrections to r114567. When swapping view for otherView, give the correct
746 relative view to -[NSView addSubview:positioned:relativeTo:].
748 * WebView/WebFullScreenController.mm:
749 (-[WebFullScreenController _swapView:with:]):
751 2012-04-25 Jer Noble <jer.noble@apple.com>
753 Placeholder view is immediately removed from hosting window upon entering full screen.
754 https://bugs.webkit.org/show_bug.cgi?id=84916
756 Reviewed by Darin Adler.
758 Correct a mistake added in r114567. When swapping view for otherView, add otherView and
759 remove view (rather than adding otherView and removing otherView).
761 * WebView/WebFullScreenController.mm:
762 (-[WebFullScreenController _swapView:with:]):
764 2012-04-25 Beth Dakin <bdakin@apple.com>
766 https://bugs.webkit.org/show_bug.cgi?id=84913
767 WebKit 1: Initialize deviceScaleFactor on creation of the WebView
769 <rdar://problem/11322716>
771 Reviewed by Darin Adler.
773 Before this patch, we weren't setting the deviceScaleFactor until
774 viewDidMoveToWindow which is quite late for background tabs. setHostWindow will
775 happen early on though. For applications that don't use host windows, also set it
777 * WebView/WebView.mm:
778 (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
779 (-[WebView setHostWindow:]):
780 (-[WebView _deviceScaleFactor]):
782 2012-04-24 Alexis Menard <alexis.menard@openbossa.org>
784 Replace occurences of style selector from variables and methods names by style resolver.
785 https://bugs.webkit.org/show_bug.cgi?id=84765
787 Reviewed by Andreas Kling.
789 Rename methods and variables to follow the new name StyleResolver. It requires to update the
790 local variables, methods parameters, and function names to match the new name and to remove
791 the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
792 will be to rename CSSStyleSelector file and update the includes.
794 * WebView/WebHTMLView.mm:
795 (-[WebHTMLView reapplyStyles]):
796 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
798 2012-04-23 Andy Estes <aestes@apple.com>
800 Incremental rendering should be unsuppressed after the load event or a configurable timeout, whichever occurs first.
801 https://bugs.webkit.org/show_bug.cgi?id=84583
803 Add a private WebPreference for setting the incremental rendering suppression timeout.
805 Reviewed by Anders Carlsson.
807 * WebView/WebPreferenceKeysPrivate.h:
808 * WebView/WebPreferences.mm:
809 (-[WebPreferences setIncrementalRenderingSuppressionTimeoutInSeconds:]):
810 (-[WebPreferences incrementalRenderingSuppressionTimeoutInSeconds]):
811 * WebView/WebPreferencesPrivate.h:
812 * WebView/WebView.mm:
813 (-[WebView _preferencesChanged:]):
815 2012-04-23 Julien Chaffraix <jchaffraix@webkit.org>
817 Cut dependency on RenderLayer::scrollRectToVisible outside rendering
818 https://bugs.webkit.org/show_bug.cgi?id=84607
820 Reviewed by Simon Fraser.
822 * WebView/WebFrame.mm:
823 (-[WebFrame _scrollDOMRangeToVisible:]):
824 Updated to use RenderObject::scrollRectToVisible and not depend on RenderLayer.
826 2012-04-22 Jon Lee <jonlee@apple.com>
828 Remove notifications support on Mac Lion.
829 https://bugs.webkit.org/show_bug.cgi?id=84554
830 <rdar://problem/11297128>
832 Reviewed by Sam Weinig.
834 * Configurations/FeatureDefines.xcconfig:
836 2012-04-20 Jon Lee <jonlee@apple.com>
838 Add Notification constructor
839 https://bugs.webkit.org/show_bug.cgi?id=80477
840 <rdar://problem/10912431>
844 * WebCoreSupport/WebNotificationClient.mm:
845 (WebNotificationClient::clearNotifications): When clearing notifications, finalize
846 them so that they can be cleaned up by the GC.
848 2012-04-20 Timothy Hatcher <timothy@apple.com>
850 Make the Web Inspector be the first responder when opening docked.
852 <rdar://problem/11294217>
854 Reviewed by Brian Weinstein.
856 * WebCoreSupport/WebInspectorClient.mm:
857 (-[WebInspectorWindowController showWindow:]): Call makeFirstResponder: on
858 the window and pass the Inspector's WebView.
860 2012-04-18 Hironori Bono <hbono@chromium.org>
862 Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
863 https://bugs.webkit.org/show_bug.cgi?id=83748
865 Reviewed by Ryosuke Niwa.
867 This change replaces a call for SpellChecker::didCheck() with one for
868 SpellChecker::didCheckSucceeded() because didCheck has been split into
869 didCheckSucceeded(0 and didCheckCanceled().
871 * WebCoreSupport/WebEditorClient.mm:
872 (-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.
874 2012-04-18 Jer Noble <jer.noble@apple.com>
876 Full Screen mode does not preserve CALayer ordering after exiting.
877 https://bugs.webkit.org/show_bug.cgi?id=83931
879 Reviewed by Eric Carlson.
881 When swapping the placeholder and web views, use -[NSView addSubview:positioned:relativeTo:]
882 instead of -[NSView replaceSubview:with:], as the latter does not preserve the relative order
883 of the view's backing CALayers.
885 * WebView/WebFullScreenController.mm:
886 (-[WebFullScreenController _swapView:with:]):
888 2012-04-18 Alexey Proskuryakov <ap@apple.com>
890 [WK2] Sandbox violations prevent attaching files to gmail messages
891 https://bugs.webkit.org/show_bug.cgi?id=84263
892 <rdar://problem/11248260>
894 Reviewed by Oliver Hunt.
896 * WebCoreSupport/WebDragClient.mm: (WebDragClient::willPerformDragDestinationAction):
897 DragDestinationActionUpload no longer exists, so we don't need a special case for it.
899 2012-04-17 Jer Noble <jer.noble@apple.com>
901 Exiting full screen video brings the wrong Safari window to the foreground
902 https://bugs.webkit.org/show_bug.cgi?id=83936
904 Reviewed by Adele Peterson.
906 Tell the original webView's window to makeKeyAndOrderFront once the exit
909 * WebView/WebFullScreenController.mm:
910 (-[WebFullScreenController finishedExitFullScreenAnimation:]):
912 2012-04-16 Anders Carlsson <andersca@apple.com>
914 Use a MIG call when creating a plug-in property list file
915 https://bugs.webkit.org/show_bug.cgi?id=84084
916 <rdar://problem/11197341>
918 Reviewed by Sam Weinig.
920 * Plugins/Hosted/NetscapePluginHostManager.mm:
921 (WebKit::NetscapePluginHostManager::createPropertyListFile):
922 Get a plug-in host and call _WKPHCreatePluginMIMETypesPreferences instead.
924 * Plugins/Hosted/WebKitPluginHost.defs:
925 Add PHCreatePluginMIMETypesPreferences.
927 * Plugins/WebNetscapePluginPackage.mm:
928 (-[WebNetscapePluginPackage createPropertyListFile]):
929 NetscapePluginHostManager::createPropertyListFile is no longer a static member function.
931 2012-04-12 Andy Estes <aestes@apple.com>
933 REGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters respecting '!important'
934 https://bugs.webkit.org/show_bug.cgi?id=83832
936 Reviewed by Alexey Proskuryakov.
938 * Misc/WebKitVersionChecks.h: Indicate that 535.13.0 was the first
939 version of WebKit.framework to ignore '!important' in
940 CSSStyleDeclaration property setters.
941 * WebView/WebView.mm:
942 (shouldRespectPriorityInCSSAttributeSetters):
943 (-[WebView _commonInitializationWithFrameName:groupName:]): Enable a
944 quirk to restore pre-r102262 behavior if the application is iAd Producer
945 and was linked against a version of WebKit.framework that had the old behavior.
947 2012-04-12 Andy Estes <aestes@apple.com>
949 Remove unused WebKit1 SPI for suppressing incremental rendering.
950 https://bugs.webkit.org/show_bug.cgi?id=83801
952 Reviewed by Simon Fraser.
954 This SPI is unused and has been replaced by API ([setS|s]uppressesIncrementalRendering).
956 * WebView/WebPreferences.mm:
957 * WebView/WebPreferencesPrivate.h:
959 2012-04-08 Dan Bernstein <mitz@apple.com>
961 [mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html
962 https://bugs.webkit.org/show_bug.cgi?id=83453
964 Reviewed by Sam Weinig.
966 * WebView/WebView.mm:
967 (-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning
968 no custom scale factor, this method was setting the Page scale factor to 0, and that value
969 was used by canvas. Changed it to correctly set the Page scale factor back to the device
972 2012-04-06 Alexey Proskuryakov <ap@apple.com>
974 [Mac] Adopt a different method of telling AppKit when inline input isn't supported
975 https://bugs.webkit.org/show_bug.cgi?id=83408
976 <rdar://problem/9205734>
978 Reviewed by Adele Peterson.
980 * Plugins/Hosted/WebTextInputWindowController.m:
981 (-[WebTextInputView validAttributesForMarkedText]):
982 (-[WebTextInputPanel init]):
983 (-[WebTextInputPanel _interpretKeyEvent:string:]): Added a comment about old approach.
985 2012-04-06 Enrica Casucci <enrica@apple.com>
987 Provide Obj-C private API to simplify markup.
988 https://bugs.webkit.org/show_bug.cgi?id=83334
989 <rdar://problem/11033861>
991 Reviewed by Sam Weinig.
993 * WebView/WebView.mm:
994 (-[WebView _simplifyMarkup:endNode:]): Added.
995 * WebView/WebViewPrivate.h:
997 2012-04-06 Tim Horton <timothy_horton@apple.com>
999 Add autodetection of image orientation from EXIF information
1000 https://bugs.webkit.org/show_bug.cgi?id=19688
1001 <rdar://problem/4126979> and <rdar://problem/11091578>
1003 Original patch by David Carson and Eric Seidel.
1005 Reviewed by Simon Fraser.
1007 Add a preference, ShouldRespectImageOrientation, which will cause WebCore to respect EXIF orientation in all images.
1009 * WebView/WebPreferenceKeysPrivate.h:
1010 * WebView/WebPreferences.mm:
1011 (+[WebPreferences initialize]):
1012 (-[WebPreferences setShouldRespectImageOrientation:]):
1013 (-[WebPreferences shouldRespectImageOrientation]):
1014 * WebView/WebPreferencesPrivate.h:
1015 * WebView/WebView.mm:
1016 (-[WebView _preferencesChanged:]):
1018 2012-04-06 Dan Bernstein <mitz@apple.com>
1020 <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
1022 Reviewed by Sam Weinig.
1024 * Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.
1026 2012-04-05 Jia Pu <jpu@apple.com>
1028 Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
1029 https://bugs.webkit.org/show_bug.cgi?id=82970
1031 Reviewed by Enrica Casucci.
1033 Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
1034 See WebCore/ChangeLog for details.
1036 * WebCoreSupport/CorrectionPanel.h:
1037 * WebCoreSupport/CorrectionPanel.mm:
1038 * WebCoreSupport/WebAlternativeTextClient.h: Added.
1039 (WebAlternativeTextClient):
1040 * WebCoreSupport/WebAlternativeTextClient.mm: Added.
1041 (WebAlternativeTextClient::WebAlternativeTextClient):
1042 (WebAlternativeTextClient::~WebAlternativeTextClient):
1043 (WebAlternativeTextClient::showCorrectionAlternative):
1044 (WebAlternativeTextClient::dismissAlternative):
1045 (WebAlternativeTextClient::dismissAlternativeSoon):
1046 (WebAlternativeTextClient::recordAutocorrectionResponse):
1047 * WebCoreSupport/WebEditorClient.h:
1048 * WebCoreSupport/WebEditorClient.mm:
1049 (WebEditorClient::~WebEditorClient):
1050 * WebView/WebView.mm:
1051 (-[WebView _commonInitializationWithFrameName:groupName:]):
1053 2012-03-15 Jer Noble <jer.noble@apple.com>
1055 Full Screen mode should cancel before navigation.
1056 https://bugs.webkit.org/show_bug.cgi?id=81295
1058 Reviewed by Anders Carlsson.
1060 When a provisional load is started, if the page is currently in full screen mode, instruct
1061 the full screen controller to close the full screen window immediately.
1063 * WebView/WebFullScreenController.h:
1064 * WebView/WebFullScreenController.mm:
1065 (-[WebFullScreenController isFullScreen]): Added.
1066 * WebView/WebView.mm:
1067 (-[WebView _didStartProvisionalLoadForFrame:]): Close the full screen window controller, if
1068 present and in full screen mode.
1070 2012-04-03 Keishi Hattori <keishi@webkit.org>
1072 Disable ENABLE_DATALIST for now
1073 https://bugs.webkit.org/show_bug.cgi?id=82871
1075 Reviewed by Kent Tamura.
1077 * Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.
1079 2012-04-03 Anders Carlsson <andersca@apple.com>
1081 Add audit token to PHCheckInWithPluginHost
1082 https://bugs.webkit.org/show_bug.cgi?id=83102
1084 Reviewed by Sam Weinig.
1086 * Plugins/Hosted/WebKitPluginHost.defs:
1088 2012-04-02 Jia Pu <jpu@apple.com>
1090 Rename SpellingCorrectionController to AlternativeTextController.
1091 https://bugs.webkit.org/show_bug.cgi?id=82942
1093 Reviewed by Enrica Casucci.
1095 These changes are simply adopting new class names.
1097 * WebCoreSupport/CorrectionPanel.h:
1099 * WebCoreSupport/CorrectionPanel.mm:
1100 (correctionIndicatorType):
1101 (CorrectionPanel::CorrectionPanel):
1102 (CorrectionPanel::~CorrectionPanel):
1103 (CorrectionPanel::show):
1104 (CorrectionPanel::dismiss):
1105 (CorrectionPanel::dismissInternal):
1106 (CorrectionPanel::handleAcceptedReplacement):
1107 * WebCoreSupport/WebEditorClient.h:
1108 * WebCoreSupport/WebEditorClient.mm:
1109 (WebEditorClient::~WebEditorClient):
1110 (WebEditorClient::showCorrectionPanel):
1111 (WebEditorClient::dismissCorrectionPanel):
1112 (WebEditorClient::dismissCorrectionPanelSoon):
1113 * WebView/WebView.mm:
1114 (-[WebView handleCorrectionPanelResult:]):
1116 2012-04-03 Jer Noble <jer.noble@apple.com>
1118 ESC key in full screen does not result in webkitFullScreenChange event.
1119 https://bugs.webkit.org/show_bug.cgi?id=82755
1120 <rdar://problem/11093513>
1122 Reviewed by Eric Carlson.
1124 Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures
1125 that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent
1128 * WebView/WebFullScreenController.mm:
1129 (-[WebFullScreenController cancelOperation:]):
1130 (-[WebFullScreenController requestExitFullScreen]):
1132 2012-04-01 Jon Lee <jonlee@apple.com>
1134 Rename notification properties and functions
1135 https://bugs.webkit.org/show_bug.cgi?id=80482
1136 <rdar://problem/10912432>
1138 Reviewed by Kentaro Hara.
1140 * WebView/WebNotification.h: Rename replaceID to tag.
1141 * WebView/WebNotification.mm:
1142 (-[WebNotification tag]):
1144 2012-03-31 Timothy Hatcher <timothy@apple.com>
1146 Prevent opening external URLs in the Web Inspector's WebView.
1148 All URLs not handled by the Inspector's JavaScript are now opened in the inspected WebView.
1150 https://webkit.org/b/82812
1151 rdar://problem/9488558
1153 Reviewed by Joseph Pecoraro.
1155 * WebCoreSupport/WebInspectorClient.mm:
1156 (-[WebInspectorWindowController init]): Factored the URL code out of here into inspectorPagePath.
1157 (-[WebInspectorWindowController inspectorPagePath]): Added.
1158 (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added.
1159 Only allow non-main frame and the inspector page. All other URLs will be opened in the inspected page.
1161 2012-03-30 Emil A Eklund <eae@chromium.org>
1163 Change WebKit/WebKit2 platform code to use pixel snapped values
1164 https://bugs.webkit.org/show_bug.cgi?id=82549
1166 Change WebKit and WebKit2 platform code to use rounded locations and
1167 pixel snapped rects and sizes. This largely avoids having to expose the
1168 fractional layout types to the platform code.
1170 Reviewed by Eric Seidel.
1172 * DOM/WebDOMOperations.mm:
1173 (-[DOMNode _renderRect:]):
1175 2012-03-30 Mark Pilgrim <pilgrim@chromium.org>
1177 GEOLOCATION should be implemented as Page Supplement
1178 https://bugs.webkit.org/show_bug.cgi?id=82228
1180 Reviewed by Adam Barth.
1182 Geolocation is now a Supplement in Page so the interface
1183 has changed for setting up the page's geolocation client
1184 initially and accessing the controller later.
1186 * WebView/WebView.mm:
1187 (-[WebView _commonInitializationWithFrameName:groupName:]):
1188 (-[WebView _geolocationDidChangePosition:]):
1189 (-[WebView _geolocationDidFailWithError:]):
1191 2012-03-30 Keishi Hattori <keishi@webkit.org>
1193 Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
1194 https://bugs.webkit.org/show_bug.cgi?id=80972
1196 Reviewed by Kent Tamura.
1198 * Configurations/FeatureDefines.xcconfig:
1200 2012-03-28 Alexey Proskuryakov <ap@apple.com>
1202 [Mac] REGRESSION: Removing translation of local paths in KURL constructor broke some applications
1203 https://bugs.webkit.org/show_bug.cgi?id=82548
1204 <rdar://problem/11125355>
1205 <rdar://problem/11142152>
1207 Reviewed by Brady Eidson.
1209 * WebView/WebFrame.mm:
1210 (-[WebFrame loadRequest:]): Fixed this bug.
1211 (-[WebFrame loadHTMLString:baseURL:]): Also added translation to another API, so that I don't
1212 have to come back again.
1213 (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
1215 * WebView/WebView.mm: (-[WebView setMainFrameURL:]): Changed another place where clients used
1216 to pass file paths instead of URLs.
1218 2012-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
1220 Unreviewed, rolling out r112553.
1221 http://trac.webkit.org/changeset/112553
1222 https://bugs.webkit.org/show_bug.cgi?id=82638
1224 It made all tests crash on Qt WK2 (Requested by Ossy_away on
1227 * WebView/WebView.mm:
1228 (-[WebView _commonInitializationWithFrameName:groupName:]):
1229 (-[WebView _geolocationDidChangePosition:]):
1230 (-[WebView _geolocationDidFailWithError:]):
1232 2012-03-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1234 HashMap<>::add should return a more descriptive object
1235 https://bugs.webkit.org/show_bug.cgi?id=71063
1237 Reviewed by Ryosuke Niwa.
1239 Update code to use AddResult instead of a pair.
1241 * Plugins/Hosted/NetscapePluginHostManager.mm:
1242 (WebKit::NetscapePluginHostManager::hostForPlugin):
1243 * Plugins/Hosted/ProxyInstance.mm:
1244 (WebKit::ProxyInstance::methodsNamed):
1245 (WebKit::ProxyInstance::fieldNamed):
1246 * WebCoreSupport/WebNotificationClient.mm:
1247 (WebNotificationClient::show):
1249 2012-03-29 Mark Pilgrim <pilgrim@chromium.org>
1251 GEOLOCATION should be implemented as Page Supplement
1252 https://bugs.webkit.org/show_bug.cgi?id=82228
1254 Reviewed by Adam Barth.
1256 Geolocation is now a Supplement in Page so the interface
1257 has changed for setting up the page's geolocation client
1258 initially and accessing the controller later.
1260 * WebView/WebView.mm:
1261 (-[WebView _commonInitializationWithFrameName:groupName:]):
1262 (-[WebView _geolocationDidChangePosition:]):
1263 (-[WebView _geolocationDidFailWithError:]):
1265 2012-03-28 Nate Chapin <japhet@chromium.org>
1267 Remove dispatchDidLoadMainResource callback, since no
1269 https://bugs.webkit.org/show_bug.cgi?id=82539
1271 Reviewed by Alexey Proskuryakov.
1273 * WebCoreSupport/WebFrameLoaderClient.h:
1274 * WebCoreSupport/WebFrameLoaderClient.mm:
1277 2012-03-28 Joseph Pecoraro <pecoraro@apple.com>
1279 <http://webkit.org/b/82419> Web Inspector: Create -[DOMNode inspect] from IDL
1281 Reviewed by Timothy Hatcher.
1283 * MigrateHeaders.make: Copy DOMNodePrivate.h to PrivateHeaders.
1285 2012-03-27 Timothy Hatcher <timothy@apple.com>
1287 Make WebKit properly load a staged framework when soft linking.
1289 https://webkit.org/b/82371
1290 rdar://problem/11125989
1292 Reviewed by Dan Bernstein.
1294 * WebCoreSupport/WebInspectorClient.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
1295 load the WebInspector framework.
1297 2012-03-26 Adam Barth <abarth@webkit.org>
1299 FrameLoader::shouldAllowNavigation uses Frame for context rather than Document
1300 https://bugs.webkit.org/show_bug.cgi?id=81020
1302 Reviewed by Eric Seidel.
1304 Update call site to new function name.
1306 * WebCoreSupport/WebFrameLoaderClient.mm:
1307 (WebFrameLoaderClient::dispatchWillSubmitForm):
1309 2012-03-23 Alexey Proskuryakov <ap@apple.com>
1311 [Mac] No need for platform-specific ENABLE_BLOB values
1312 https://bugs.webkit.org/show_bug.cgi?id=82102
1314 Reviewed by David Kilzer.
1316 * Configurations/FeatureDefines.xcconfig:
1318 2012-03-23 Dean Jackson <dino@apple.com>
1320 Disable CSS_SHADERS in Apple builds
1321 https://bugs.webkit.org/show_bug.cgi?id=81996
1323 Reviewed by Simon Fraser.
1325 Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.
1327 * Configurations/FeatureDefines.xcconfig:
1329 2012-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1331 Convert hasGrammarMarker to use Internals interface
1332 https://bugs.webkit.org/show_bug.cgi?id=82004
1334 Reviewed by Ryosuke Niwa.
1336 Remove hasGrammarMarker support, since it can support in the cross-port way
1337 through the Internals interface.
1340 * WebView/WebFrame.mm:
1341 * WebView/WebFramePrivate.h:
1343 2012-03-22 Benjamin Poulain <bpoulain@apple.com>
1345 Build fix for WebHistory is busted after changing time zone
1346 https://bugs.webkit.org/show_bug.cgi?id=81849
1348 Unreviewed build fix.
1350 When generating warning for undefined message signature, rebuildHistoryByDayIfNeeded
1351 fail to compile due to addItemToDateCaches: being undefined.
1353 Move the definition to the right place in the file to use the private method.
1355 * History/WebHistory.mm:
1356 (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1358 2012-03-22 Benjamin Poulain <bpoulain@apple.com>
1360 WebHistory is busted after changing time zone
1361 https://bugs.webkit.org/show_bug.cgi?id=81849
1363 Reviewed by Brady Eidson.
1365 The date used for choosing the bucket of a new entry is computed
1366 with the system TimeZone.
1368 When the Time Zone change, or the daylight saving time change, all the dates
1369 in _entriesByDate are offset from the new entries.
1371 This patch solves the issue by re-distributing the WebHistoryItems if the time zone
1373 The clients of WebHistory are notified of this change through the regular Notifications.
1375 * History/WebHistory.mm:
1376 (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1377 (-[WebHistoryPrivate init]):
1378 (-[WebHistory timeZoneChanged:]):
1379 (-[WebHistory init]):
1380 (-[WebHistory dealloc]):
1381 (-[WebHistory finalize]):
1383 2012-03-21 Tim Horton <timothy_horton@apple.com>
1385 Make use of CG rounded-rect primitives
1386 https://bugs.webkit.org/show_bug.cgi?id=79932
1387 <rdar://problem/9274953>
1389 Reviewed by Simon Fraser.
1391 Portions of patch by Nikolas Zimmermann and Mustafizur Rahaman.
1393 Add wkCGPathAddRoundedRect.
1395 * WebCoreSupport/WebSystemInterface.mm:
1396 (InitWebCoreSystemInterface):
1398 2012-03-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1400 Convert hasSpellingMarker to use Internals interface.
1401 https://bugs.webkit.org/show_bug.cgi?id=81300
1403 Reviewed by Ryosuke Niwa.
1405 Remove hasSpellingMarker support, since it can support in the cross-port way
1406 through the Internals interface.
1409 * WebView/WebFrame.mm:
1410 * WebView/WebFramePrivate.h:
1412 2012-03-19 Adam Barth <abarth@webkit.org>
1414 Remove support for "magic" iframe
1415 https://bugs.webkit.org/show_bug.cgi?id=81590
1417 Reviewed by Eric Seidel.
1419 Remove FrameLoaderClient methods that no longer exist.
1421 * WebCoreSupport/WebFrameLoaderClient.h:
1422 * WebCoreSupport/WebFrameLoaderClient.mm:
1424 2012-03-19 Enrica Casucci <enrica@apple.com>
1426 WebKit2: create sandbox extensions for files that are dropped in an input control.
1427 https://bugs.webkit.org/show_bug.cgi?id=81153
1428 <rdar://problem/11031207>
1430 Reviewed by Alexey Proskuryakov.
1432 * WebCoreSupport/WebDragClient.mm:
1433 (WebDragClient::willPerformDragDestinationAction): Avoid calling the delegate with the new drag action.
1434 We want to avoid any unwanted side effects for the WebKit clients.
1436 2012-03-19 Emil A Eklund <eae@chromium.org>
1438 [mac/chromium] Change platform code to use pixelSnappedRect methods
1439 https://bugs.webkit.org/show_bug.cgi?id=81016
1441 Reviewed by Eric Seidel.
1443 * Plugins/WebBaseNetscapePluginView.mm:
1444 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
1445 * WebView/WebFrame.mm:
1446 (-[WebFrame _getVisibleRect:]):
1447 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
1448 * WebView/WebView.mm:
1449 (-[WebView _dashboardRegions]):
1450 (-[WebView trackedRepaintRects]):
1452 2012-03-16 Brady Eidson <beidson@apple.com>
1454 <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
1455 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
1457 Reviewed by Geoff Garen.
1459 * WebCoreSupport/WebEditorClient.mm:
1460 (WebEditorClient::setInsertionPasteboard):
1461 * WebCoreSupport/WebPlatformStrategies.h:
1462 (WebPlatformStrategies):
1463 * WebCoreSupport/WebPlatformStrategies.mm:
1464 (WebPlatformStrategies::url):
1466 2012-03-08 Jer Noble <jer.noble@apple.com>
1468 Support W3C Full Screen API proposal
1469 https://bugs.webkit.org/show_bug.cgi?id=80660
1471 Reviewed by Alexey Proskuryakov.
1473 Allow full screen elements to access the keyboard.
1475 * WebView/WebView.mm:
1476 (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
1478 2012-03-07 Jon Lee <jonlee@apple.com>
1480 Move NotificationContents into Notification
1481 https://bugs.webkit.org/show_bug.cgi?id=80487
1482 <rdar://problem/10965519>
1484 Reviewed by Jian Li.
1486 * WebView/WebNotification.mm: Refactor to use accessor methods on Notification.
1487 (-[WebNotification title]):
1488 (-[WebNotification body]):
1490 2012-03-15 David Hyatt <hyatt@apple.com>
1492 https://bugs.webkit.org/show_bug.cgi?id=81258
1494 Add a preference for enabling the new multi-column layout code that will be based on regions.
1496 Reviewed by Beth Dakin.
1498 * WebView/WebPreferenceKeysPrivate.h:
1499 * WebView/WebPreferences.mm:
1500 (+[WebPreferences initialize]):
1501 (-[WebPreferences setRegionBasedColumnsEnabled:]):
1502 (-[WebPreferences regionBasedColumnsEnabled]):
1503 * WebView/WebPreferencesPrivate.h:
1504 * WebView/WebView.mm:
1505 (-[WebView _preferencesChanged:]):
1507 2012-03-15 Brady Eidson <beidson@apple.com>
1509 <rdar://problem/11036900> and https://bugs.webkit.org/show_bug.cgi?id=81079
1510 REGRESSION(r107844): Clipboard API only remembers most recent data set on clipboard
1512 Reviewed by Sam Weinig.
1514 Add the non-destructive "addTypes" to supplement the destructive "setTypes"
1515 * WebCoreSupport/WebPlatformStrategies.h:
1516 * WebCoreSupport/WebPlatformStrategies.mm:
1517 (WebPlatformStrategies::addTypes):
1519 2012-03-14 Anders Carlsson <andersca@apple.com>
1521 java/java-and-plugins.html test failing
1522 https://bugs.webkit.org/show_bug.cgi?id=81188
1523 <rdar://problem/11048657>
1525 Reviewed by Sam Weinig.
1527 When we're marshaling JSObjects that wrap plug-in objects, make sure to check that the
1528 current plug-in instance is the same as the plug-in instance the object came from and don't
1529 pass the unwrapped object ID if that is the case.
1531 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1532 (WebKit::getObjectID):
1533 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
1534 (WebKit::NetscapePluginInstanceProxy::marshalValues):
1535 * Plugins/Hosted/ProxyInstance.h:
1537 (WebKit::ProxyInstance::instanceProxy):
1539 2012-03-14 Michael Saboff <msaboff@apple.com>
1541 REGRESSION(r110383): ASSERTION failures in JSCell::finishCreation causing multiple tests to "crash" on the Lion Intel Debug Bots
1542 https://bugs.webkit.org/show_bug.cgi?id=80993
1544 Reviewed by Mark Rowe.
1546 Moved $(BUILT_PRODUCTS_DIR)/usr/local/include to the front of HEADER_SEARCH_PATH
1547 to fix builds given the wtf move.
1549 * Configurations/WebKit.xcconfig:
1551 2012-03-13 Jon Lee <jonlee@apple.com>
1553 Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
1554 https://bugs.webkit.org/show_bug.cgi?id=80922
1555 <rdar://problem/11035082>
1557 Reviewed by Jian Li.
1559 You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
1560 LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
1561 new API. Therefore, APIs that are common between the two will have:
1562 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1564 This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
1565 the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
1567 Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1568 * WebCoreSupport/WebNotificationClient.h:
1569 * WebCoreSupport/WebNotificationClient.mm:
1570 (WebNotificationClient::show):
1571 (WebNotificationClient::cancel):
1572 (WebNotificationClient::clearNotifications):
1573 (WebNotificationClient::notificationObjectDestroyed):
1574 (WebNotificationClient::notificationControllerDestroyed):
1575 (WebNotificationClient::requestPermission):
1576 (WebNotificationClient::checkPermission):
1577 * WebView/WebNotification.mm:
1578 (-[WebNotification title]):
1579 (-[WebNotification body]):
1580 (-[WebNotification replaceID]):
1581 (-[WebNotification origin]):
1582 (-[WebNotification notificationID]):
1583 (-[WebNotification dispatchShowEvent]):
1584 (-[WebNotification dispatchCloseEvent]):
1585 (-[WebNotification dispatchClickEvent]):
1586 (-[WebNotification dispatchErrorEvent]):
1587 * WebView/WebNotificationInternal.h:
1588 * WebView/WebView.mm:
1589 (-[WebView _commonInitializationWithFrameName:groupName:]):
1591 2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
1593 Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
1594 https://bugs.webkit.org/show_bug.cgi?id=78853
1596 Reviewed by Adam Barth.
1598 * Configurations/FeatureDefines.xcconfig:
1599 * WebCoreSupport/WebChromeClient.h:
1601 * WebCoreSupport/WebGeolocationClient.mm:
1602 (WebGeolocationClient::lastPosition):
1603 * WebView/WebGeolocationPosition.mm:
1604 (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1606 (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1607 * WebView/WebGeolocationPositionInternal.h:
1608 * WebView/WebView.mm:
1609 (-[WebView _commonInitializationWithFrameName:groupName:]):
1610 (-[WebView _geolocationDidChangePosition:]):
1611 (-[WebView _geolocationDidFailWithError:]):
1613 2012-03-12 Antonio Gomes <agomes@rim.com>
1615 Convert nodesFromRect tests to use Internals interface
1616 https://bugs.webkit.org/show_bug.cgi?id=80886
1618 Reviewed by Ryosuke Niwa.
1620 Removed mac specific support for nodesFromRect for testing purposes only,
1621 since it can work in a cross-port way through the Internals interface.
1624 * WebView/WebView.mm:
1625 * WebView/WebViewPrivate.h:
1627 2012-03-13 Anders Carlsson <andersca@apple.com>
1629 Remove a nonexistent WebUIDelegate method from WebUIDelegatePrivate.h
1630 https://bugs.webkit.org/show_bug.cgi?id=81014
1632 Reviewed by Sam Weinig.
1634 Remove a plug-in halter related WebUIDelegate method.
1636 * WebView/WebUIDelegatePrivate.h:
1638 2012-03-13 Shinya Kawanaka <shinyak@chromium.org>
1640 REGRESSION: Spellcheck tests hit assertions on Mac.
1641 https://bugs.webkit.org/show_bug.cgi?id=80883
1643 Reviewed by Ryosuke Niwa.
1645 The bug was caused by the closure object created in requestCheckingOfString accessing
1646 request's member variables even though the request object is not an NSObject or allocated
1647 in stack. This resulted in the closure not being able to access those variables when invoked.
1649 Fixed the bug by making local copies of those member variables.
1651 * WebCoreSupport/WebEditorClient.mm:
1652 (WebEditorClient::requestCheckingOfString):
1654 2012-03-11 Timothy Hatcher <timothy@apple.com>
1656 Update how the Web Inspector resources are loaded.
1658 https://bugs.webkit.org/show_bug.cgi?id=80798
1659 rdar://problem/10359959
1661 Reviewed by Brian Weinstein.
1663 * WebCoreSupport/WebInspectorClient.mm:
1664 (useWebKitWebInspector): Return if we are using the WebCore resources for compatibility
1665 with local and nightly builds.
1666 (WebInspectorFrontendClient::localizedStringsURL): Decide what path to use.
1667 (-[WebInspectorWindowController init]): Ditto.
1668 (-[WebInspectorWindowController window]): Decide if the window is textured or not.
1670 2012-03-09 Jon Lee <jonlee@apple.com>
1672 Rename NotificationPresenter to NotificationClient
1673 https://bugs.webkit.org/show_bug.cgi?id=80488
1674 <rdar://problem/10965558>
1676 Reviewed by Kentaro Hara.
1678 Refactor to use renamed WebCore::NotificationClient.
1679 * WebCoreSupport/WebNotificationClient.h:
1680 * WebCoreSupport/WebNotificationClient.mm:
1681 (WebNotificationClient::checkPermission):
1682 * WebView/WebViewPrivate.h:
1684 2012-03-09 Enrica Casucci <enrica@apple.com>
1686 Move WebNSURLExtras code down to WebCore.
1687 https://bugs.webkit.org/show_bug.cgi?id=80611
1689 Reviewed by Alexey Proskuryakov.
1691 Changed the implementation to use newly moved WebCore functions.
1693 * Misc/WebKitNSStringExtras.mm:
1694 (-[NSString _webkit_hasCaseInsensitivePrefix:]):
1695 * Misc/WebNSURLExtras.mm:
1696 (+[NSURL _web_URLWithUserTypedString:]):
1697 (+[NSURL _web_URLWithDataAsString:relativeToURL:]):
1698 (+[NSURL _web_URLWithData:]):
1699 (+[NSURL _web_URLWithData:relativeToURL:]):
1700 (-[NSURL _web_originalData]):
1701 (-[NSURL _web_originalDataAsString]):
1702 (-[NSURL _web_userVisibleString]):
1703 (-[NSURL _web_isEmpty]):
1704 (-[NSURL _web_URLCString]):
1705 (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]):
1706 (-[NSURL _webkit_URLByRemovingFragment]):
1707 (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
1708 (-[NSURL _web_URLByRemovingUserInfo]):
1709 (-[NSURL _web_dataForURLComponentType:]):
1710 (-[NSURL _web_schemeData]):
1711 (-[NSURL _web_hostData]):
1712 (-[NSString _web_isUserVisibleURL]):
1713 (-[NSString _web_hostNameNeedsDecodingWithRange:]):
1714 (-[NSString _web_hostNameNeedsEncodingWithRange:]):
1715 (-[NSString _web_decodeHostNameWithRange:]):
1716 (-[NSString _web_encodeHostNameWithRange:]):
1717 (-[NSString _web_decodeHostName]):
1718 (-[NSString _web_encodeHostName]):
1719 * WebCoreSupport/WebSystemInterface.mm:
1720 (InitWebCoreSystemInterface):
1722 2012-03-09 Emil A Eklund <eae@chromium.org>
1724 Add roundedPoint to HitTestResult and change platform code to use it
1725 https://bugs.webkit.org/show_bug.cgi?id=80715
1727 Reviewed by James Robinson.
1729 Change ports to use roundedPoint to avoid exposing subpixel types to
1732 * WebCoreSupport/WebContextMenuClient.mm:
1733 (WebContextMenuClient::showContextMenu):
1735 2012-03-09 Jon Lee <jonlee@apple.com>
1737 Add support for ENABLE(LEGACY_NOTIFICATIONS)
1738 https://bugs.webkit.org/show_bug.cgi?id=80497
1740 Reviewed by Adam Barth.
1742 Prep for b80472: Update API for Web Notifications
1743 * Configurations/FeatureDefines.xcconfig:
1745 2012-03-08 Ryosuke Niwa <rniwa@webkit.org>
1747 Mac build fix for micro data API.
1749 * Configurations/FeatureDefines.xcconfig:
1751 2012-03-08 Jer Noble <jer.noble@apple.com>
1753 Unreviewed Snow Leopard build fix.
1755 On Leopard and Snow Leopard, provide an implementation for -[NSWindow convertRectToScreen:].
1757 * WebView/WebFullScreenController.mm:
1758 (-[NSWindow convertRectToScreen:]):
1760 2012-02-20 Jer Noble <jer.noble@apple.com>
1762 Full Screen Refactor Part 4: Animate into Full Screen mode using new animation classes, WebKit edition.
1763 https://bugs.webkit.org/show_bug.cgi?id=78930
1765 Reviewed by Anders Carlsson.
1767 Revise WebFullScreenController to have the same general functionality and code path as WKFullScreenWindowController
1768 in WebKit2. As such, the following functions are copies of their equivalents in WKFullScreenWindowController:
1769 * WebView/WebFullScreenController.mm:
1770 (-[WebFullScreenController init]):
1771 (-[WebFullScreenController dealloc]):
1772 (-[WebFullScreenController windowDidLoad]):
1773 (-[WebFullScreenController cancelOperation:]):
1774 (-[WebFullScreenController applicationDidResignActive:]):
1775 (-[WebFullScreenController applicationDidChangeScreenParameters:]):
1776 (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1777 (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1778 (-[WebFullScreenController close]):
1779 (-[WebFullScreenController animationDidEnd:]):
1780 (-[WebFullScreenController _updateMenuAndDockForFullScreen]):
1781 (-[WebFullScreenController _swapView:with:]):
1782 (createBackgroundFullscreenWindow):
1783 (windowFrameFromApparentFrames):
1784 (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1785 (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1787 The following is a copy of the equivalent function in WebFullScreenManager:
1788 * WebView/WebFullScreenController.mm:
1789 (screenRectOfContents):
1791 * WebCoreSupport/WebChromeClient.mm:
1792 (WebChromeClient::fullScreenRendererChanged): No longer tell the WebView the renderer changed (as it doesn't care.)
1793 * WebView/WebFullScreenController.h:
1794 * WebView/WebFullScreenController.mm:
1795 (-[WebFullScreenController setElement:]): No need to add event listeners to the media element.
1796 (-[WebFullScreenController enterFullScreen:]): Same as WKFullScreenWindowController, but not asynchronous.
1797 (-[WebFullScreenController exitFullScreen]): Ditto.
1798 * WebView/WebView.mm:
1799 (-[WebView _enterFullScreenForElement:WebCore::]): Fullscreen -> FullScreen.
1800 (-[WebView _exitFullScreenForElement:WebCore::]): Ditto.
1802 2012-03-08 Matt Lilek <mrl@apple.com>
1804 Don't enable VIDEO_TRACK on all OS X platforms
1805 https://bugs.webkit.org/show_bug.cgi?id=80635
1807 Reviewed by Eric Carlson.
1809 * Configurations/FeatureDefines.xcconfig:
1811 2012-03-07 Joseph Pecoraro <pecoraro@apple.com>
1813 <http://webkit.org/b/80510> Web Inspector crash (iCab)
1815 Reviewed by Timothy Hatcher.
1817 * WebCoreSupport/WebInspectorClient.mm:
1818 (WebInspectorClient::didResizeMainFrame):
1820 2012-03-06 Benjamin Poulain <bpoulain@apple.com>
1822 [Mac] Update the configuration files for iOS
1823 https://bugs.webkit.org/show_bug.cgi?id=80435
1825 Reviewed by David Kilzer.
1827 * Configurations/WebKit.xcconfig:
1829 2012-03-06 Eric Seidel <eric@webkit.org>
1831 Make WTF public headers use fully-qualified include paths and remove ForwardingHeaders/wtf
1832 https://bugs.webkit.org/show_bug.cgi?id=80363
1834 Reviewed by Mark Rowe.
1836 ForwardingHeaders/wtf is no longer necessary (or functional) now that JavaScriptCore
1837 no longer includes the WTF headers as private headers.
1839 * ForwardingHeaders/wtf/ASCIICType.h: Removed.
1840 * ForwardingHeaders/wtf/AlwaysInline.h: Removed.
1841 * ForwardingHeaders/wtf/Assertions.h: Removed.
1842 * ForwardingHeaders/wtf/Deque.h: Removed.
1843 * ForwardingHeaders/wtf/DisallowCType.h: Removed.
1844 * ForwardingHeaders/wtf/FastMalloc.h: Removed.
1845 * ForwardingHeaders/wtf/Forward.h: Removed.
1846 * ForwardingHeaders/wtf/GetPtr.h: Removed.
1847 * ForwardingHeaders/wtf/HashCountedSet.h: Removed.
1848 * ForwardingHeaders/wtf/HashMap.h: Removed.
1849 * ForwardingHeaders/wtf/HashSet.h: Removed.
1850 * ForwardingHeaders/wtf/HashTraits.h: Removed.
1851 * ForwardingHeaders/wtf/ListHashSet.h: Removed.
1852 * ForwardingHeaders/wtf/ListRefPtr.h: Removed.
1853 * ForwardingHeaders/wtf/Locker.h: Removed.
1854 * ForwardingHeaders/wtf/MathExtras.h: Removed.
1855 * ForwardingHeaders/wtf/Noncopyable.h: Removed.
1856 * ForwardingHeaders/wtf/OwnArrayPtr.h: Removed.
1857 * ForwardingHeaders/wtf/OwnPtr.h: Removed.
1858 * ForwardingHeaders/wtf/OwnPtrCommon.h: Removed.
1859 * ForwardingHeaders/wtf/PassOwnPtr.h: Removed.
1860 * ForwardingHeaders/wtf/PassRefPtr.h: Removed.
1861 * ForwardingHeaders/wtf/Platform.h: Removed.
1862 * ForwardingHeaders/wtf/RefCounted.h: Removed.
1863 * ForwardingHeaders/wtf/RefCountedLeakCounter.h: Removed.
1864 * ForwardingHeaders/wtf/RefPtr.h: Removed.
1865 * ForwardingHeaders/wtf/RetainPtr.h: Removed.
1866 * ForwardingHeaders/wtf/StdLibExtras.h: Removed.
1867 * ForwardingHeaders/wtf/TemporaryChange.h: Removed.
1868 * ForwardingHeaders/wtf/Threading.h: Removed.
1869 * ForwardingHeaders/wtf/UnusedParam.h: Removed.
1870 * ForwardingHeaders/wtf/VMTags.h: Removed.
1871 * ForwardingHeaders/wtf/ValueCheck.h: Removed.
1872 * ForwardingHeaders/wtf/Vector.h: Removed.
1873 * ForwardingHeaders/wtf/VectorTraits.h: Removed.
1874 * ForwardingHeaders/wtf/unicode/Unicode.h: Removed.
1875 * ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Removed.
1877 2012-03-05 Joseph Pecoraro <pecoraro@apple.com>
1879 Web Inspector: Hide dock button when not allowed to dock
1880 https://bugs.webkit.org/show_bug.cgi?id=78575
1882 Reviewed by Pavel Feldman.
1884 * WebCoreSupport/WebInspectorClient.h:
1886 (WebInspectorClient):
1887 * WebCoreSupport/WebInspectorClient.mm:
1888 (WebInspectorClient::didResizeMainFrame):
1890 2012-03-05 Gavin Barraclough <barraclough@apple.com>
1892 putByIndex should throw in strict mode
1893 https://bugs.webkit.org/show_bug.cgi?id=80335
1895 Reviewed by Filip Pizlo.
1897 Make the MethodTable PutByIndex trap take a boolean 'shouldThrow' parameter.
1899 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1900 (WebKit::NetscapePluginInstanceProxy::setProperty):
1902 2012-03-05 Joseph Pecoraro <pecoraro@apple.com>
1904 Unreviewed rollout of r109858 for restructuring.
1906 2012-03-05 Joseph Pecoraro <pecoraro@apple.com>
1908 <http://webkit.org/b/78575> Web Inspector: Hide dock button when not allowed to dock
1910 Reviewed by Timothy Hatcher.
1912 * WebCoreSupport/WebInspectorClient.h:
1913 (WebInspectorClient):
1914 * WebCoreSupport/WebInspectorClient.mm:
1915 (WebInspectorClient::updateDockingAvailability):
1917 2012-03-02 Jon Lee <jonlee@apple.com>
1919 Add support for notification replaceId in Mac WebKit and WK2
1920 https://bugs.webkit.org/show_bug.cgi?id=80206
1921 <rdar://problem/10965574>
1923 Reviewed by Sam Weinig.
1925 * WebView/WebNotification.h: Add replaceID method.
1926 * WebView/WebNotification.mm:
1927 (-[WebNotification replaceID]):
1929 2012-03-05 Adam Barth <abarth@webkit.org>
1931 Geolocation should use a ScriptExecutionContext as its context object
1932 https://bugs.webkit.org/show_bug.cgi?id=80248
1934 Reviewed by Kentaro Hara.
1936 * WebView/WebFrame.mm:
1937 (-[WebFrame _cacheabilityDictionary]):
1938 - We no longer special-case Geolocation.
1940 2012-03-03 Benjamin Poulain <benjamin@webkit.org>
1942 Remove the redundant method KURL::protocolInHTTPFamily()
1943 https://bugs.webkit.org/show_bug.cgi?id=80216
1945 Reviewed by Anders Carlsson.
1947 * WebCoreSupport/WebFrameLoaderClient.mm:
1948 (WebFrameLoaderClient::createPlugin):
1950 2012-03-03 Hans Wennborg <hans@chromium.org>
1952 Implement Speech JavaScript API
1953 https://bugs.webkit.org/show_bug.cgi?id=80019
1955 Reviewed by Adam Barth.
1957 Add ENABLE_SCRIPTED_SPEECH.
1959 * Configurations/FeatureDefines.xcconfig:
1961 2012-03-03 Anders Carlsson <andersca@apple.com>
1963 Fix build with newer versions of clang.
1965 * Panels/WebAuthenticationPanel.m:
1966 (-[WebAuthenticationPanel setUpForChallenge:]):
1967 Use %ld and cast to long.
1969 * Plugins/WebNetscapePluginView.mm:
1970 (-[WebNetscapePluginView getVariable:value:]):
1971 Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
1973 2012-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
1975 Unreviewed, rolling out r109255.
1976 http://trac.webkit.org/changeset/109255
1977 https://bugs.webkit.org/show_bug.cgi?id=79932
1979 Breaks rounded rects with dashed strokes in SVG
1981 * WebCoreSupport/WebSystemInterface.mm:
1982 (InitWebCoreSystemInterface):
1984 2012-02-29 Adam Barth <abarth@webkit.org>
1986 ScriptExecutionContext has too many ifdef ENABLE(SQL_DATABASE)
1987 https://bugs.webkit.org/show_bug.cgi?id=79633
1989 Reviewed by Eric Seidel.
1991 * WebView/WebFrame.mm:
1992 (-[WebFrame _cacheabilityDictionary]):
1994 2012-02-29 Tim Horton <timothy_horton@apple.com>
1996 Make use of CG rounded-rect primitives
1997 https://bugs.webkit.org/show_bug.cgi?id=79932
1998 <rdar://problem/9274953>
2000 Reviewed by Simon Fraser.
2002 Add wkCGPathAddRoundedRect.
2004 * WebCoreSupport/WebSystemInterface.mm:
2005 (InitWebCoreSystemInterface):
2007 2012-02-29 Enrica Casucci <enrica@apple.com>
2009 Crash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:]
2010 https://bugs.webkit.org/show_bug.cgi?id=79937
2011 <rdar://problem/10942936>
2013 Reviewed by Dan Bernstein.
2015 * WebView/WebFrame.mm:
2016 (-[WebFrame _setTypingStyle:withUndoAction:]): Adding a null check.
2018 2012-02-28 Simon Fraser <simon.fraser@apple.com>
2020 Update WebKitSystemInterface.
2022 Reviewed by Sam Weinig.
2024 * WebCoreSupport/WebSystemInterface.mm:
2025 (InitWebCoreSystemInterface):
2027 2012-02-28 Enrica Casucci <enrica@apple.com>
2029 More Pasteboard code cleanup.
2030 https://bugs.webkit.org/show_bug.cgi?id=79816
2032 Removing the last references to NSPasteboard.
2034 Reviewed by Alexey Proskuryakov.
2036 * WebCoreSupport/WebEditorClient.h:
2037 * WebCoreSupport/WebEditorClient.mm:
2038 (WebEditorClient::setInsertionPasteboard):
2040 2012-02-26 Hajime Morrita <morrita@chromium.org>
2042 Move ChromeClient::showContextMenu() to ContextMenuClient
2043 https://bugs.webkit.org/show_bug.cgi?id=79427
2045 Reviewed by Adam Barth.
2047 * WebCoreSupport/WebContextMenuClient.h:
2048 (WebContextMenuClient):
2049 * WebCoreSupport/WebContextMenuClient.mm:
2050 (WebContextMenuClient::showContextMenu): Moved from WebChromeClient
2051 * WebCoreSupport/WebChromeClient.h:
2052 * WebCoreSupport/WebChromeClient.mm:
2054 2012-02-25 Sam Weinig <sam@webkit.org>
2056 QuickLook events don't make it to WebKit plugins.
2057 <rdar://problem/10931721>
2059 Reviewed by Anders Carlsson.
2061 * WebView/WebHTMLView.mm:
2063 (-[WebHTMLView hitTest:]):
2064 Allow QuickLook events to hit test down to subviews.
2066 2012-02-24 Brady Eidson <beidson@apple.com>
2068 <rdar://problem/10805709> and https://bugs.webkit.org/show_bug.cgi?id=79421
2069 Need a WK1 Mac API to filter which subframes go into WebArchives as they are created
2071 Reviewed by Sam Weinig (with additional comments by Adam Roben)
2073 Add webArchiveByFilteringSubframes: which takes a callback block:
2074 * DOM/WebDOMOperationsPrivate.h:
2076 Add FrameFilter that adapts the block, and use it to implement the new SPI:
2077 * DOM/WebDOMOperations.mm:
2079 (WebFrameFilter::WebFrameFilter):
2080 (WebFrameFilter::~WebFrameFilter):
2081 (WebFrameFilter::shouldIncludeSubframe):
2082 (-[DOMNode webArchiveByFilteringSubframes:]):
2084 2012-02-24 Shinya Kawanaka <shinyak@chromium.org>
2086 SpellCheckRequest needs to know the context where the spellcheck happened.
2087 https://bugs.webkit.org/show_bug.cgi?id=79320
2089 Reviewed by Hajime Morita.
2091 * WebCoreSupport/WebEditorClient.h:
2092 * WebCoreSupport/WebEditorClient.mm:
2093 (WebEditorClient::requestCheckingOfString):
2095 2012-02-23 Andy Estes <aestes@apple.com>
2097 Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API.
2098 https://bugs.webkit.org/show_bug.cgi?id=79433
2100 Reviewed by Dan Bernstein.
2102 * WebCoreSupport/WebInspectorClient.mm:
2103 (-[WebInspectorWindowController init]):
2104 * WebView/WebPreferenceKeysPrivate.h:
2105 * WebView/WebPreferences.h:
2106 * WebView/WebPreferences.mm:
2107 (+[WebPreferences initialize]):
2108 (-[WebPreferences setSuppressesIncrementalRendering:]):
2109 (-[WebPreferences suppressesIncrementalRendering]):
2110 (-[WebPreferences setSuppressIncrementalRendering:]):
2111 (-[WebPreferences suppressIncrementalRendering]):
2112 * WebView/WebView.mm:
2113 (-[WebView _preferencesChanged:]):
2115 2012-02-22 Hajime Morrita <morrita@chromium.org>
2117 NOTIFICATIONS should be implemented as PageSupplement
2118 https://bugs.webkit.org/show_bug.cgi?id=79052
2120 Reviewed by Adam Barth.
2122 * WebView/WebView.mm:
2123 (-[WebView _commonInitializationWithFrameName:groupName:]):
2125 2012-02-21 Ryosuke Niwa <rniwa@webkit.org>
2127 Remove the remaining uses of CSSStyleDeclaration in Editor
2128 https://bugs.webkit.org/show_bug.cgi?id=78939
2130 Reviewed by Enrica Casucci.
2132 * WebCoreSupport/WebEditorClient.h:
2134 * WebCoreSupport/WebEditorClient.mm:
2135 (WebEditorClient::shouldApplyStyle):
2136 * WebView/WebFrame.mm:
2137 (-[WebFrame _setTypingStyle:withUndoAction:]):
2138 * WebView/WebHTMLView.mm:
2139 (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2140 (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2141 * WebView/WebView.mm:
2142 (-[WebView applyStyle:]):
2144 2012-02-22 Ryosuke Niwa <rniwa@webkit.org>
2146 Remove the remaining uses of CSSStyleDeclaration in Editor
2147 https://bugs.webkit.org/show_bug.cgi?id=78939
2149 Reviewed by Enrica Casucci.
2151 * WebCoreSupport/WebEditorClient.h:
2153 * WebCoreSupport/WebEditorClient.mm:
2154 (WebEditorClient::shouldApplyStyle):
2155 * WebView/WebFrame.mm:
2156 (-[WebFrame _setTypingStyle:withUndoAction:]):
2157 * WebView/WebHTMLView.mm:
2158 (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
2159 (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
2160 * WebView/WebView.mm:
2161 (-[WebView applyStyle:]):
2163 2012-02-22 Jon Lee <jonlee@apple.com>
2165 Part of r108409 was incorrect, and incorporated an older version of a sub-patch.
2166 This is the actual sub-patch that should have been submitted.
2168 * WebCoreSupport/WebNotificationClient.h:
2169 * WebCoreSupport/WebNotificationClient.mm:
2170 (WebNotificationClient::show):
2171 (WebNotificationClient::cancel):
2172 (WebNotificationClient::clearNotifications):
2173 (WebNotificationClient::notificationObjectDestroyed):
2174 (WebNotificationClient::notificationControllerDestroyed):
2176 2012-02-21 Jon Lee <jonlee@apple.com>
2178 Build fix. Push ENABLE_NOTIFICATIONS into .mm file.
2180 * WebCoreSupport/WebNotificationClient.h:
2181 * WebView/WebNotification.h:
2182 * WebView/WebNotification.mm:
2183 (-[WebNotification title]):
2184 (-[WebNotification body]):
2185 (-[WebNotification origin]):
2186 (-[WebNotification notificationID]):
2187 (-[WebNotification dispatchShowEvent]):
2188 (-[WebNotification dispatchCloseEvent]):
2189 (-[WebNotification dispatchClickEvent]):
2190 (-[WebNotification dispatchErrorEvent]):
2192 2012-02-21 John Sullivan <sullivan@apple.com>
2196 * WebView/WebUIDelegatePrivate.h:
2197 Added @class declarations for DOMNode and DOMElement.
2199 2012-02-21 Jon Lee <jonlee@apple.com>
2201 Build fix for r108409.
2203 * WebCoreSupport/WebNotificationClient.h:
2205 * WebCoreSupport/WebNotificationClient.mm:
2206 * WebView/WebNotification.h:
2207 (WebSecurityOrigin):
2208 * WebView/WebNotification.mm:
2210 (-[WebNotification initWithCoreNotification:notificationID:]):
2212 2012-02-21 Jon Lee <jonlee@apple.com>
2214 Bring notifications support to WK1 mac: permission requests
2215 https://bugs.webkit.org/show_bug.cgi?id=78783
2216 <rdar://problem/10610578>
2218 Reviewed by Anders Carlsson.
2220 * WebCoreSupport/WebNotificationClient.h:
2221 * WebCoreSupport/WebNotificationClient.mm: Create policy listener, which conforms to the
2222 WebAllowDenyPolicyListener protocol, similar to geolocation.
2223 (WebNotificationClient::requestPermission):
2224 (WebNotificationClient::checkPermission):
2225 (-[WebNotificationPolicyListener initWithCallback:]):
2226 (-[WebNotificationPolicyListener allow]): Call the callback.
2227 (-[WebNotificationPolicyListener deny]): Call the callback.
2228 * WebView/WebUIDelegatePrivate.h: Define new UI delegate method to ask the user to decide a
2229 policy for navigations.
2232 Bring notifications support to WK1 mac: showing, canceling, removing notifications
2234 Create a WebKit wrapper object for WebCore::Notification, which also keeps track of an assigned
2236 * WebView/WebNotification.h: Added.
2237 (WebSecurityOrigin):
2238 * WebView/WebNotification.mm: Added.
2240 (-[WebNotification initWithCoreNotification:notificationID:]):
2241 (-[WebNotification init]):
2242 (-[WebNotification dealloc]):
2243 (-[WebNotification title]):
2244 (-[WebNotification body]):
2245 (-[WebNotification origin]):
2246 (-[WebNotification notificationID]):
2247 (-[WebNotification dispatchShowEvent]):
2248 (-[WebNotification dispatchCloseEvent]):
2249 (-[WebNotification dispatchClickEvent]):
2250 (-[WebNotification dispatchErrorEvent]):
2251 * WebView/WebNotificationInternal.h: Added.
2252 (WebCore): Internal category to allow creating instances with WebCore objects.
2254 Extend WebView to include a WebNotificationProvider, which clients implement.
2255 * WebView/WebViewData.h: Add a private member for the provider.
2256 * WebView/WebViewPrivate.h:
2257 * Define an enum WebNotificationPermission that mirrors WebCore::NotificationPresenter::Permission
2258 that client which implement the provider can use to return policy decisions.
2259 * Define WebNotificationProvider.
2260 * Category WebViewNotification extends WebView with methods that set and manager the
2261 notification provider, and handle events from the platform notifications.
2262 * WebView/WebView.mm:
2263 (-[WebView _setNotificationProvider:]): Sets the provider when initializing the WebView.
2264 (-[WebView _notificationControllerDestroyed]):
2265 (-[WebView _notificationProvider]):
2266 (-[WebView _notificationDidShow:]):
2267 (-[WebView _notificationDidClick:]):
2268 (-[WebView _notificationsDidClose:]):
2270 * WebCoreSupport/WebNotificationClient.h: Add variables that map between WebCore::Notification
2271 instances, their assigned IDs, their contexts, and corresponding WebKit wrapper objects.
2272 * WebCoreSupport/WebNotificationClient.mm:
2273 (generateNotificationID): Created unique IDs for each shown notification.
2274 (WebNotificationClient::show): Create wrapper object for notification, assign ID, cache the
2275 mappings between the objects, and forward it to the provider.
2276 (WebNotificationClient::cancel):
2277 (WebNotificationClient::clearNotifications): Clear all notifications associated with the
2279 (WebNotificationClient::notificationObjectDestroyed): Remove the notification from the maps.
2280 (WebNotificationClient::notificationControllerDestroyed): If the controller is destroyed, tell
2281 the provider to clear of the notifications related to this web view.
2284 (Prep work for) Bring notifications support to WK1 mac
2286 Rename WebGeolocationPolicyListener. The interface is generic enough to be reused for
2287 notification requests. To avoid having to create a new listener type, instead rename it
2288 to WebAllowDenyPolicyListener.
2289 * WebView/WebUIDelegatePrivate.h: Rename the protocol.
2290 * WebCoreSupport/WebGeolocationClient.mm: Refactor geolocation request listener to use
2293 Add preference to keep track of whether notifications are enabled in general.
2294 * WebView/WebPreferenceKeysPrivate.h: Add WebNotificationsEnabledKey for storing the
2296 * WebView/WebPreferences.mm:
2297 (+[WebPreferences initialize]): By default have them enabled.
2298 (-[WebPreferences setNotificationsEnabled:]):
2299 (-[WebPreferences notificationsEnabled]):
2300 * WebView/WebPreferencesPrivate.h:
2302 Add a stringValue method that exposes WebCore::SecurityOrigin::toString() for storing the
2303 notification policy for a given origin.
2304 * WebCoreSupport/WebSecurityOrigin.mm:
2305 (-[WebSecurityOrigin stringValue]):
2306 * WebCoreSupport/WebSecurityOriginPrivate.h:
2308 2012-02-21 Sam Weinig <sam@webkit.org>
2310 Attempt to fix the Snow Leopard build.
2312 * Configurations/Base.xcconfig:
2314 2012-02-21 Sam Weinig <sam@webkit.org>
2316 Use libc++ when building with Clang on Mac
2317 https://bugs.webkit.org/show_bug.cgi?id=78981
2319 Reviewed by Dan Bernstein.
2321 * Configurations/Base.xcconfig:
2323 2012-02-17 Mihnea Ovidenie <mihnea@adobe.com>
2325 CSS regions enabled by default
2326 https://bugs.webkit.org/show_bug.cgi?id=78525
2328 Reviewed by David Hyatt.
2330 Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
2331 CSSRegions are still enabled by default.
2332 In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
2334 * WebView/WebPreferenceKeysPrivate.h:
2335 * WebView/WebPreferences.mm:
2336 (+[WebPreferences initialize]):
2337 (-[WebPreferences cssRegionsEnabled]):
2338 (-[WebPreferences setCSSRegionsEnabled:]):
2339 * WebView/WebPreferencesPrivate.h:
2340 * WebView/WebView.mm:
2341 (-[WebView _preferencesChanged:]):
2343 2012-02-17 Enrica Casucci <enrica@apple.com>
2345 Refactor DragData class to use PlatformStrategies in the Mac implementation.
2346 https://bugs.webkit.org/show_bug.cgi?id=78768
2348 Reviewed by Darin Adler.
2350 * WebCoreSupport/WebPlatformStrategies.h: Added color() method.
2351 * WebCoreSupport/WebPlatformStrategies.mm:
2352 (WebPlatformStrategies::color):
2354 2012-02-16 Brady Eidson <beidson@apple.com>
2356 <rdar://problem/10616280> and https://bugs.webkit.org/show_bug.cgi?id=78767
2357 REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages
2359 Reviewed by Sam Weinig.
2361 * WebView/WebView.mm:
2362 (-[WebView _needsIsLoadingInAPISenseQuirk]):
2363 (-[WebView _preferencesChanged:]):
2365 2012-02-15 Enrica Casucci <enrica@apple.com>
2367 Refactor ClipboardMac class to use PlatformStrategies.
2368 https://bugs.webkit.org/show_bug.cgi?id=78554
2370 Reviewed by Anders Carlsson.
2372 * WebCoreSupport/WebDragClient.h: Changed methods signature to use name based pasteboard.
2373 * WebCoreSupport/WebDragClient.mm: Ditto.
2374 (WebDragClient::willPerformDragSourceAction):
2375 (WebDragClient::startDrag):
2376 (WebDragClient::declareAndWriteDragImage):
2377 * WebCoreSupport/WebPlatformStrategies.h: Added new methods.
2378 * WebCoreSupport/WebPlatformStrategies.mm:
2379 (WebPlatformStrategies::changeCount):
2380 (WebPlatformStrategies::uniqueName):
2382 2012-02-15 Sadrul Habib Chowdhury <sadrul@chromium.org>
2384 Notify ChromeClient when touch-event handlers are installed/removed.
2385 https://bugs.webkit.org/show_bug.cgi?id=77440
2387 Reviewed by Darin Fisher and Ryosuke Niwa.
2389 * WebCoreSupport/WebChromeClient.h:
2391 2012-02-14 Matt Lilek <mrl@apple.com>
2393 Don't ENABLE_DASHBOARD_SUPPORT unconditionally on all Mac platforms
2394 https://bugs.webkit.org/show_bug.cgi?id=78629
2396 Reviewed by David Kilzer.
2398 * Configurations/FeatureDefines.xcconfig:
2400 2012-02-14 Alexey Proskuryakov <ap@apple.com>
2402 [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
2403 https://bugs.webkit.org/show_bug.cgi?id=78541
2404 <rdar://problem/10036695>
2406 Reviewed by Kent Tamura.
2408 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default value of the
2411 2012-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
2413 Convert svg/animations to use SMIL methods for driving the timeline
2414 https://bugs.webkit.org/show_bug.cgi?id=78422
2416 Reviewed by Dirk Schulze.
2418 Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
2419 Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
2422 * WebView/WebFrame.mm:
2423 * WebView/WebFramePrivate.h:
2425 2012-02-13 Enrica Casucci <enrica@apple.com>
2427 Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
2428 https://bugs.webkit.org/show_bug.cgi?id=78282
2430 This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
2431 now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
2432 WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
2433 class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
2434 interface but this one more step in the direction of removing access to NSPasteboard from
2436 As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.
2438 Reviewed by Anders Carlsson.
2440 * WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
2441 * WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface.
2442 (WebPlatformStrategies::createPasteboardStrategy):
2443 (WebPlatformStrategies::getTypes):
2444 (WebPlatformStrategies::bufferForType):
2445 (WebPlatformStrategies::getPathnamesForType):
2446 (WebPlatformStrategies::stringForType):
2447 (WebPlatformStrategies::copy):
2448 (WebPlatformStrategies::setTypes):
2449 (WebPlatformStrategies::setBufferForType):
2450 (WebPlatformStrategies::setPathnamesForType):
2451 (WebPlatformStrategies::setStringForType):
2453 2012-02-12 Hajime Morrita <morrita@chromium.org>
2455 Page should have less intrusive way to associate API implementation objects.
2456 https://bugs.webkit.org/show_bug.cgi?id=78085
2458 Reviewed by Adam Barth.
2460 * WebView/WebView.mm:
2461 (-[WebView _commonInitializationWithFrameName:groupName:]):
2463 2012-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
2465 Unreviewed, rolling out r107435.
2466 http://trac.webkit.org/changeset/107435
2467 https://bugs.webkit.org/show_bug.cgi?id=78410
2469 It broke the Qt build (Requested by Ossy on #webkit).
2471 * WebCoreSupport/WebPlatformStrategies.h:
2472 (WebPlatformStrategies):
2473 * WebCoreSupport/WebPlatformStrategies.mm:
2474 (WebPlatformStrategies::addVisitedLink):
2476 2012-02-10 Adam Klein <adamk@chromium.org>
2478 Enable MUTATION_OBSERVERS by default on all platforms
2479 https://bugs.webkit.org/show_bug.cgi?id=78196
2481 Reviewed by Ojan Vafai.
2483 * Configurations/FeatureDefines.xcconfig:
2485 2012-02-10 Enrica Casucci <enrica@apple.com>
2487 Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
2488 https://bugs.webkit.org/show_bug.cgi?id=78282
2490 This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
2491 now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
2492 WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
2493 class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
2494 interface but this one more step in the direction of removing access to NSPasteboard from
2496 As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.
2498 Reviewed by Anders Carlsson.
2500 * WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
2501 * WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface.
2502 (WebPlatformStrategies::createPasteboardStrategy):
2503 (WebPlatformStrategies::getTypes):
2504 (WebPlatformStrategies::bufferForType):
2505 (WebPlatformStrategies::getPathnamesForType):
2506 (WebPlatformStrategies::stringForType):
2507 (WebPlatformStrategies::copy):
2508 (WebPlatformStrategies::setTypes):
2509 (WebPlatformStrategies::setBufferForType):
2510 (WebPlatformStrategies::setPathnamesForType):
2511 (WebPlatformStrategies::setStringForType):
2513 2012-02-10 Benjamin Poulain <bpoulain@apple.com>
2515 [Mac] DYLIB_INSTALL_NAME_BASE should not be prefixed by the SDKROOT
2516 https://bugs.webkit.org/show_bug.cgi?id=78320
2518 Reviewed by Joseph Pecoraro.
2520 <rdar://problem/10839750>
2522 * Configurations/WebKit.xcconfig:
2524 2012-02-09 Alexey Proskuryakov <ap@apple.com>
2526 REGRESSION (r104885): Articles not displayed in Vienna RSS reader
2527 https://bugs.webkit.org/show_bug.cgi?id=78280
2528 <rdar://problem/10762545>
2530 Reviewed by Oliver Hunt.
2532 * Misc/WebNSURLExtras.h:
2533 * Misc/WebNSURLExtras.mm: (-[NSURL _webkit_URLFromURLOrPath]):
2534 Added a method to create a URL from a path, similarly to what KURL used to do.
2536 * WebView/WebFrame.mm: (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
2537 Use it in an API where a known regression occurred.
2539 2012-02-07 Antti Koivisto <antti@apple.com>
2541 REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
2542 https://bugs.webkit.org/show_bug.cgi?id=78080
2544 Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
2546 * WebView/WebFrame.mm:
2547 (-[WebFrame _typingStyle]):
2549 2012-02-07 Tony Chang <tony@chromium.org>
2551 merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
2552 https://bugs.webkit.org/show_bug.cgi?id=78036
2554 Reviewed by Darin Adler.
2556 * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
2558 2012-02-06 Anders Carlsson <andersca@apple.com>
2560 Overlay scrollbars flash when window is simply activated
2561 https://bugs.webkit.org/show_bug.cgi?id=77911
2562 <rdar://problem/10211995>
2564 Reviewed by Kenneth Russell.
2566 * WebView/WebView.mm:
2567 (-[WebView _windowWillOrderOnScreen:]):
2568 (-[WebView _windowWillOrderOffScreen:]):
2569 Call FocusController::setContainingWindowIsVisible.
2572 2012-02-06 Matthew Delaney <mdelaney@apple.com>
2574 toDataURL() uses stale data after putImageData()
2575 https://bugs.webkit.org/show_bug.cgi?id=65767
2577 Reviewed by Chris Marrin.
2579 * WebCoreSupport/WebSystemInterface.mm:
2581 2012-02-03 Antti Koivisto <antti@apple.com>
2583 Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp
2584 https://bugs.webkit.org/show_bug.cgi?id=77779
2586 Reviewed by Darin Adler.
2588 * WebView/WebHTMLView.mm:
2590 2012-02-03 Antti Koivisto <antti@apple.com>
2592 https://bugs.webkit.org/show_bug.cgi?id=77740
2593 Split CSSMutableStyleDeclaration into separate internal and CSSOM types
2595 Reviewed by Andreas Kling and Darin Adler.
2597 * WebView/WebFrame.mm:
2598 (-[WebFrame _typingStyle]):
2600 2012-02-03 Beth Dakin <bdakin@apple.com>
2602 https://bugs.webkit.org/show_bug.cgi?id=77691
2603 Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use
2606 Reviewed by Andy Estes.
2608 toUserSpace() and toDeviceSpace() don't need to take device scale. Also
2609 restore a comment that I needlessly removed.
2610 * WebCoreSupport/WebChromeClient.mm:
2611 (WebChromeClient::setWindowRect):
2612 (WebChromeClient::windowRect):
2614 2012-02-01 Dan Bernstein <mitz@apple.com>
2616 WebKit/mac part of <rdar://problem/10442663> Paginated display does not respect page-break-{before,after}
2617 https://bugs.webkit.org/show_bug.cgi?id=77505
2619 Reviewed by Darin Adler.
2621 * WebView/WebView.mm:
2622 (-[WebView _setPaginationBehavesLikeColumns:]): Added this setter.
2623 (-[WebView _paginationBehavesLikeColumns]): Added this getter.
2624 * WebView/WebViewPrivate.h:
2626 2012-01-25 Eric Seidel <eric@webkit.org>
2628 HTMLIsIndexElement should not expose HTMLInputElement properties
2629 https://bugs.webkit.org/show_bug.cgi?id=76095
2631 Reviewed by Adam Barth.
2633 * MigrateHeaders.make:
2635 2012-01-31 Pablo Flouret <pablof@motorola.com>
2637 Fix compilation errors on build-webkit --debug --no-workers on mac.
2638 https://bugs.webkit.org/show_bug.cgi?id=75869
2640 Reviewed by Adam Barth.
2642 * Workers/WebWorkersPrivate.mm:
2643 (+[WebWorkersPrivate workerThreadCount]):
2645 2012-01-30 Beth Dakin <bdakin@apple.com>
2647 https://bugs.webkit.org/show_bug.cgi?id=77263
2648 PlatformScreenMac should not rely on NSWindow for important bits of data
2650 Reviewed by Geoff Garen.
2652 toUserSpace() and toDeviceSpace() now take a parameter for the
2654 * WebCoreSupport/WebChromeClient.mm:
2655 (windowScaleFactor):
2656 (WebChromeClient::setWindowRect):
2657 (WebChromeClient::windowRect):
2659 2012-01-25 Mark Rowe <mrowe@apple.com>
2661 Build in to an alternate location when USE_STAGING_INSTALL_PATH is set.
2663 <rdar://problem/10609417> Adopt USE_STAGING_INSTALL_PATH
2665 Reviewed by David Kilzer.
2667 * Configurations/WebKit.xcconfig: Define NORMAL_WEBKIT_FRAMEWORKS_DIR, which contains
2668 the path where WebKit is normally installed. Update WEBKIT_FRAMEWORKS_DIR to point to
2669 the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Define
2670 NORMAL_PRODUCTION_FRAMEWORKS_DIR, which contains the path where our public frameworks
2671 are normally installed. Update PRODUCTION_FRAMEWORKS_DIR to point to the staged frameworks
2672 directory when USE_STAGING_INSTALL_PATH is set. Always set the framework's install name
2673 based on the normal framework location. This prevents an incorrect install name from being
2674 used when installing in to the staged frameworks directory. Look for our other frameworks
2675 in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Update
2676 WEBCORE_PRIVATE_HEADERS_DIR to find WebCore at the top level of the staged frameworks
2677 directory when USE_STAGING_INSTALL_PATH is set, rather than finding it embedded inside of
2680 2012-01-25 Eric Seidel <eric@webkit.org>
2682 HTMLIsIndexElement should not expose HTMLInputElement properties
2683 https://bugs.webkit.org/show_bug.cgi?id=76095
2685 Reviewed by Adam Barth.
2687 * MigrateHeaders.make:
2689 2012-01-25 Hajime Morita <morrita@google.com>
2691 ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
2692 https://bugs.webkit.org/show_bug.cgi?id=76863
2694 Reviewed by Dimitri Glazkov.
2696 Added a feature flag.
2698 * Configurations/FeatureDefines.xcconfig:
2700 2012-01-25 Enrica Casucci <enrica@apple.com>
2702 WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2703 https://bugs.webkit.org/show_bug.cgi?id=76951
2704 <rdar://problem/9325158>
2706 Reviewed by Alexey Proskuryakov.
2708 * WebView/WebHTMLView.mm: Removed typingAttributes implementation.
2709 * WebView/WebView.mm:
2710 (-[WebView typingAttributes]): Added.
2712 2012-01-24 Enrica Casucci <enrica@apple.com>
2714 WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2715 https://bugs.webkit.org/show_bug.cgi?id=76951
2716 <rdar://problem/9325158>
2718 The Inspector bar calls the typingAttributes methods on the clients that support it
2719 to retrieve the set of attributes representing the style at the selection and uses
2720 this information to update the state of the B, I and U buttons.
2721 If this method is not supported, it defaults to the attributes of the previous
2722 character position, reporting an incorrect state.
2723 This occurs only when we have a caret selection.
2725 Reviewed by Alexey Proskuryakov.
2727 * WebView/WebHTMLView.mm:
2728 (-[WebHTMLView _styleForAttributeChange:]): Removed dead code.
2729 (-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore.
2730 (-[WebHTMLView typingAttributes]): Added.
2732 2012-01-24 Benjamin Poulain <bpoulain@apple.com>
2734 pageCacheSupportsPlugins should default to true on WebKit1
2735 https://bugs.webkit.org/show_bug.cgi?id=76891
2737 Reviewed by Joseph Pecoraro.
2739 The default was left out of r102619 by accident.
2741 * WebView/WebPreferences.mm:
2742 (+[WebPreferences initialize]):
2744 2012-01-23 Geoffrey Garen <ggaren@apple.com>
2746 JSValue::toString() should return a JSString* instead of a UString
2747 https://bugs.webkit.org/show_bug.cgi?id=76861
2749 Reviewed by Gavin Barraclough.
2751 Mechanical changes to call value() after calling toString(), to
2752 convert from "JS string" (JSString*) to "C++ string" (UString), since
2753 toString() no longer returns a "C++ string".
2755 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2756 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
2757 * WebView/WebFrame.mm:
2758 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2759 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2761 2012-01-20 Sam Weinig <sam@webkit.org>
2763 Make WebCore RunLoop work for WebKit1
2764 https://bugs.webkit.org/show_bug.cgi?id=76739
2766 Reviewed by Anders Carlsson.
2768 * Carbon/CarbonWindowAdapter.mm:
2769 (+[CarbonWindowAdapter initialize]):
2770 * History/WebBackForwardList.mm:
2771 (+[WebBackForwardList initialize]):
2772 * History/WebHistoryItem.mm:
2773 (+[WebHistoryItem initialize]):
2774 * Misc/WebElementDictionary.mm:
2775 (+[WebElementDictionary initialize]):
2776 * Misc/WebIconDatabase.mm:
2777 (+[WebIconDatabase initialize]):
2778 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2779 (+[WebHostedNetscapePluginView initialize]):
2780 * Plugins/WebBaseNetscapePluginView.mm:
2781 * Plugins/WebBasePluginPackage.mm:
2782 * Plugins/WebNetscapePluginView.mm:
2783 (+[WebNetscapePluginView initialize]):
2784 * WebCoreSupport/WebEditorClient.mm:
2785 (+[WebUndoStep initialize]):
2786 * WebCoreSupport/WebFrameLoaderClient.mm:
2787 * WebView/WebArchive.mm:
2788 (+[WebArchivePrivate initialize]):
2789 * WebView/WebDataSource.mm:
2790 (+[WebDataSourcePrivate initialize]):
2791 * WebView/WebHTMLView.mm:
2792 (+[WebHTMLViewPrivate initialize]):
2793 (+[WebHTMLView initialize]):
2794 * WebView/WebResource.mm:
2795 (+[WebResourcePrivate initialize]):
2796 * WebView/WebTextIterator.mm:
2797 (+[WebTextIteratorPrivate initialize]):
2798 * WebView/WebView.mm:
2799 (+[WebView initialize]):
2800 * WebView/WebViewData.mm:
2801 (+[WebViewPrivate initialize]):
2802 Initialized the main run loop in addition to other initialization.
2804 2012-01-20 Simon Fraser <simon.fraser@apple.com>
2806 https://bugs.webkit.org/show_bug.cgi?id=76444
2808 #if ENABLE(CSS_SHADERS) cannot appear in framework headers.
2811 * WebView/WebPreferences.mm:
2812 * WebView/WebPreferencesPrivate.h:
2814 2012-01-20 Alexandru Chiculita <achicu@adobe.com>
2816 CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at runtime
2817 https://bugs.webkit.org/show_bug.cgi?id=76444
2819 Added private WebPreference property called "WebKitCSSCustomFilterEnabled".
2821 Reviewed by Nikolas Zimmermann.
2823 * WebView/WebPreferenceKeysPrivate.h:
2824 * WebView/WebPreferences.mm:
2825 (+[WebPreferences initialize]):
2826 (-[WebPreferences cssCustomFilterEnabled]):
2827 (-[WebPreferences setCSSCustomFilterEnabled:]):
2828 * WebView/WebPreferencesPrivate.h:
2829 * WebView/WebView.mm:
2830 (-[WebView _preferencesChanged:]):
2832 2012-01-17 Enrica Casucci <enrica@apple.com>
2834 Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
2835 https://bugs.webkit.org/show_bug.cgi?id=76490
2836 <rdar://problem/9460733>
2838 Starting with Lion, there is no more NSForegroundColor attribute in the dictionary
2839 if the color matches the default (solid black).
2840 The fix consists in treating the lack of color as solid black instead of transparent as
2843 Added a TestWebKitAPI test.
2845 Reviewed by Darin Adler and Dan Bernstein.
2847 * WebView/WebHTMLView.mm:
2848 (-[WebHTMLView _styleForAttributeChange:]):
2850 2012-01-17 Matthew Delaney <mdelaney@apple.com>
2852 On post-Lion releases, preserve the Lion behavior where WebKit explicitly calls -setGeometryFlipped on the hosting layer for applications that were linked on Lion or earlier.
2853 <rdar://problem/10692025>
2855 Reviewed by Simon Fraser.
2857 * WebCoreSupport/WebSystemInterface.mm: Init newly added function.
2858 * WebView/WebHTMLView.mm: Added case for post-Lion builds that calls -setGeometryFlipped if the app is linked on or before Lion.
2860 2012-01-17 Enrica Casucci <enrica@apple.com>
2862 REGRESSION (r101413): Correction panel overlaps misspelled text.
2863 https://bugs.webkit.org/show_bug.cgi?id=74589
2864 <rdar://problem/10585115>
2866 When converting the rectangle from the root view, we need
2867 to take into account the height of the rectangle.
2869 Reviewed by Anders Carlsson.
2871 * WebView/WebView.mm:
2872 (-[WebView _convertRectFromRootView:]):
2874 2012-01-16 Simon Fraser <simon.fraser@apple.com>
2876 <rdar://problem/10703228> ASSERTION FAILED: Uncaught exception - Cannot lock focus on image <NSImage 0x1206572a0 Size={0, 0} Reps=( )>, because it is size zero loading techcrunch.com
2878 Reviewed by Anders Carlsson.
2880 Avoid trying to create image snapshots for zero-sized plugins, because
2881 it causes -[NSView lockFocus] to throw an exception.
2883 * Plugins/WebBaseNetscapePluginView.mm:
2884 (-[WebBaseNetscapePluginView cacheSnapshot]):
2886 2012-01-16 Alexey Proskuryakov <ap@apple.com>
2888 A follow-up fix for:
2889 A warning is logged to console when typing a bare "/" in Safari address bar
2890 https://bugs.webkit.org/show_bug.cgi?id=76236
2892 <rdar://problem/10702986>
2894 Reviewed by John Sullivan.
2896 * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): It's OK to have a
2897 path when there is a base URL.
2899 2012-01-16 Jon Lee <jonlee@apple.com>
2901 Build fix for r105086.
2903 * Configurations/FeatureDefines.xcconfig:
2905 2012-01-12 Alexey Proskuryakov <ap@apple.com>
2907 A warning is logged to console when typing a bare "/" in Safari address bar
2908 https://bugs.webkit.org/show_bug.cgi?id=76236
2910 Reviewed by John Sullivan.
2912 * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): Bail out early for paths.
2914 2012-01-16 Pablo Flouret <pablof@motorola.com>
2916 Fix compilation errors on build-webkit --debug --no-svg --no-svg-fonts --no-svg-dom-objc-bindings on mac.
2917 https://bugs.webkit.org/show_bug.cgi?id=75865
2919 Reviewed by Hajime Morita.
2921 * WebView/WebFrame.mm:
2922 (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):
2924 2012-01-15 Pablo Flouret <pablof@motorola.com>
2926 Fix compilation errors on build-webkit --debug --no-video on mac.
2927 https://bugs.webkit.org/show_bug.cgi?id=75867
2929 Reviewed by Philippe Normand.
2931 - WebChromeClient::fullScreenRendererChanged() declaration wrongly guarded
2932 by VIDEO feature instead of FULLSCREEN_API.
2933 - _isAnyMoviePlaying implementation depends on VIDEO.
2935 * WebCoreSupport/WebChromeClient.h:
2936 * WebView/WebFullScreenController.mm:
2937 (-[WebFullScreenController _isAnyMoviePlaying]):
2939 2012-01-11 Beth Dakin <bdakin@apple.com>
2941 https://bugs.webkit.org/show_bug.cgi?id=75904
2942 WebKit 1: Scrollbar uiStateTransitionProgress requires tracking the mouse all
2945 <rdar://problem/10498816>
2947 Reviewed by Darin Adler.
2949 New ivar trackingAreaForNonKeyWindow stores our NSTrackingArea whenever we
2951 * WebView/WebHTMLView.mm:
2952 (-[WebHTMLViewPrivate dealloc]):
2953 (-[WebHTMLViewPrivate clear]):
2955 When we know that mouse movements won't affect anything other than
2956 scrollbars, call our new function passMouseMovedEventToScrollbars(),
2957 otherwise we'll call the old mouseMoved().
2958 (mouseEventIsPartOfClickOrDrag):
2959 (-[WebHTMLView _updateMouseoverWithEvent:]):
2961 Make sure not to remove the mouse observer when there are legacy scrollbars.
2962 (-[WebHTMLView removeMouseMovedObserver]):
2964 Set up a tracking area when the window is not key to ensure that the WebView
2965 gets the relevant events. Remove it when the window is key again so that we
2966 rely on the existing mechanism.
2967 (-[WebHTMLView windowDidBecomeKey:]):
2968 (-[WebHTMLView windowDidResignKey:]):
2970 2012-01-10 Dan Bernstein <mitz@apple.com>
2972 Made -[WebHistoryItem copyWithZone:] allocate an object of the same class as the receiver.
2974 Reviewed by Mark Rowe.
2976 * History/WebHistoryItem.mm:
2977 (-[WebHistoryItem copyWithZone:]):
2979 2012-01-10 Chris Marrin <cmarrin@apple.com>
2981 Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work
2985 * WebCoreSupport/WebChromeClient.h:
2987 2012-01-10 Chris Marrin <cmarrin@apple.com>
2989 Turn off the FilterTrigger in WebKit and WebKit2
2990 https://bugs.webkit.org/show_bug.cgi?id=75914
2992 Reviewed by Simon Fraser.
2994 Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.
2996 * WebCoreSupport/WebChromeClient.h:
2997 (WebChromeClient::allowedCompositingTriggers):
2999 2012-01-10 Dan Bernstein <mitz@apple.com>
3001 Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
3002 https://bugs.webkit.org/show_bug.cgi?id=75980
3004 Reviewed by Mark Rowe.
3006 * History/WebHistoryItem.mm:
3007 (-[WebHistoryItem copyWithZone:]): Replaced NSCopyObject() with
3008 -alloc, -initWithWebCoreHistoryItem:.
3010 2012-01-06 Simon Fraser <simon.fraser@apple.com>
3012 Mitigate scrollbar differences when running pixel tests
3013 https://bugs.webkit.org/show_bug.cgi?id=67217
3015 Reviewed by Dan Bernstein.
3017 Make it possible to register a custom NSScroller class, which
3018 the WebDynamicScrollBarsView will use when mock scrollbars are enabled.
3020 Also ensure that the WebPreferences mock scrollbars preference is
3021 migrated into Settings.
3023 * WebView/WebDynamicScrollBarsView.h:
3024 * WebView/WebDynamicScrollBarsView.mm:
3025 (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
3026 (+[WebDynamicScrollBarsView _verticalScrollerClass]):
3027 (+[WebDynamicScrollBarsView setCustomScrollerClass:]):
3028 * WebView/WebView.mm:
3029 (-[WebView _preferencesChanged:]):
3031 2012-01-05 Dan Bernstein <mitz@apple.com>
3033 <rdar://problem/10633760> Update copyright strings
3035 Reviewed by Mark Rowe.
3039 2012-01-05 Pratik Solanki <psolanki@apple.com>
3041 WebFrameLoaderClient::userAgent does unnecessary NSString/NSURL conversions
3042 https://bugs.webkit.org/show_bug.cgi?id=75586
3044 Reviewed by Alexey Proskuryakov.
3046 We do unnecessary KURL->NSURL* and String<->NSString* when calling [WebView
3047 userAgentForURL:] from WebFrameLoaderClient::userAgent. Instead we add a separate function,
3048 _userAgentString that returns a WTF::String to make this call faster.
3050 * WebCoreSupport/WebFrameLoaderClient.mm:
3051 (WebFrameLoaderClient::userAgent):
3052 * WebView/WebView.mm:
3053 (-[WebView _userAgentString]):
3054 (-[WebView userAgentForURL:]):
3055 * WebView/WebViewInternal.h:
3057 2012-01-04 Anders Carlsson <andersca@apple.com>
3059 Ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm
3060 https://bugs.webkit.org/show_bug.cgi?id=75447
3062 Reviewed by Brian Weinstein.
3064 Resolve the ambiguity.
3066 * Misc/WebNSPasteboardExtras.mm:
3067 (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
3069 2012-01-04 Mihnea Ovidenie <mihnea@adobe.com>
3071 [Mac]Fix build after changeset 103997
3072 https://bugs.webkit.org/show_bug.cgi?id=75530
3074 Reviewed by Andreas Kling.
3076 * WebView/WebFrame.mm:
3077 * WebView/WebHTMLView.mm:
3078 * WebView/WebPDFView.mm:
3079 * WebView/WebView.mm:
3081 2012-01-03 Jon Lee <jonlee@apple.com>
3083 Leak of WebNotificationClient when page is destroyed
3084 https://bugs.webkit.org/show_bug.cgi?id=74980
3085 <rdar://problem/10611231>
3087 Reviewed by Mark Rowe.
3089 * WebCoreSupport/WebNotificationClient.h:
3090 * WebCoreSupport/WebNotificationClient.mm:
3091 (WebNotificationClient::notificationControllerDestroyed): Remove the instance.
3093 2012-01-02 Dan Bernstein <mitz@apple.com>
3095 [mac] Remove -[WebView setHoverFeedbackSuspended:]
3096 https://bugs.webkit.org/show_bug.cgi?id=75406
3098 Reviewed by Tim Hatcher.
3100 * WebView/WebHTMLView.mm:
3101 (-[WebHTMLView _updateMouseoverWithEvent:]): Removed check for suspended hover updates.
3102 * WebView/WebHTMLViewInternal.h: Removed -_hoverFeedbackSuspendedChanged.
3103 * WebView/WebView.mm:
3104 (-[WebView setHoverFeedbackSuspended:]): Left empty implementation to support versions of
3105 Safari that call this.
3106 (-[WebView isHoverFeedbackSuspended]): Left implementation that always returns NO to support
3107 versions of Safari that call this.
3108 * WebView/WebViewData.h: Removed hoverFeedbackSuspended ivar.
3109 * WebView/WebViewPrivate.h: Removed method definitions.
3111 2011-12-31 Dan Bernstein <mitz@apple.com>
3113 WebKit/mac changes for: REGRESSION (WebKit2): Cursor, hover states not updated when page scrolls under stationary mouse pointer
3114 https://bugs.webkit.org/show_bug.cgi?id=75405
3116 Reviewed by Anders Carlsson.
3118 Removed the WebKit/mac mechanism for dispatching fake mouse moved events
3119 when an HTML frame scrolls, since FrameView now does this.
3121 * WebView/WebHTMLView.mm:
3122 (-[WebHTMLViewPrivate dealloc]): Removed an assertion about a removed ivar.
3123 (-[WebHTMLView _updateMouseoverWithFakeEvent]): Removed call to
3124 -_cancelUpdateMouseoverTimer.
3125 (-[WebHTMLView _frameOrBoundsChanged]): Removed code to schedule a timer
3126 for dispatching a mouse moved event on scroll.
3127 (-[WebHTMLView close]): Removed call to _cancelUpdateMouseoverTimer.
3128 (-[WebHTMLView viewWillMoveToWindow:]): Ditto.
3129 (-[WebHTMLView mouseDown:]): Ditto.
3131 2011-12-23 Ryosuke Niwa <rniwa@webkit.org>
3133 Chromium Mac build fix.
3135 * WebCoreSupport/WebSystemInterface.mm:
3136 (InitWebCoreSystemInterface):
3138 2011-12-21 Sam Weinig <sam@webkit.org>
3140 Start extracting platform specific bits out of PlatformEvents
3141 https://bugs.webkit.org/show_bug.cgi?id=75063
3143 Reviewed by Anders Carlsson.
3145 * WebCoreSupport/WebSystemInterface.mm:
3146 (InitWebCoreSystemInterface):
3147 * WebView/WebFrame.mm:
3148 * WebView/WebHTMLView.mm:
3149 (-[WebHTMLView menuForEvent:]):
3150 (-[WebHTMLView acceptsFirstMouse:]):
3151 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
3152 (currentKeyboardEvent):
3153 (-[WebHTMLView flagsChanged:]):
3154 * WebView/WebPDFView.mm:
3155 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3156 * WebView/WebView.mm:
3158 2011-12-21 Timothy Hatcher <timothy@apple.com>
3160 Web Inspector: suppress incremental rendering and use application chrome mode
3162 https://webkit.org/b/75026
3164 Reviewed by Joseph Pecoraro.
3166 * WebCoreSupport/WebInspectorClient.mm:
3167 (-[WebInspectorWindowController init]): Sort the preferences, remove the Leopard font family setting,
3168 set suppress incremental rendering and use application chrome mode.
3170 2011-12-20 Pavel Feldman <pavel.feldman@gmail.com>
3172 Web Inspector: reproducible crash after closing web inspector and browser window (iCab)
3173 https://bugs.webkit.org/show_bug.cgi?id=74255
3175 Reviewed by Yury Semikhatsky.
3177 * WebCoreSupport/WebInspectorClient.h:
3178 * WebCoreSupport/WebInspectorClient.mm:
3179 (WebInspectorClient::bringFrontendToFront):
3180 (-[WebInspectorWindowController destroyInspectorView:]):
3182 2011-12-19 Eric Carlson <eric.carlson@apple.com>
3184 Enable <track> for Mac build
3185 https://bugs.webkit.org/show_bug.cgi?id=74838
3187 Reviewed by Darin Adler.
3189 * Configurations/FeatureDefines.xcconfig:
3191 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
3193 Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
3194 https://bugs.webkit.org/show_bug.cgi?id=74748
3196 Reviewed by Eric Seidel.
3198 * WebCoreSupport/WebEditorClient.h:
3199 * WebCoreSupport/WebEditorClient.mm:
3200 (WebEditorClient::registerUndoOrRedoStep):
3201 (WebEditorClient::registerUndoStep):
3202 (WebEditorClient::registerRedoStep):
3204 2011-12-16 Sam Weinig <sam@webkit.org>
3206 Give PlatformEvents a base class
3207 https://bugs.webkit.org/show_bug.cgi?id=74685
3209 Reviewed by Anders Carlsson.
3211 Add a base class for PlatformMouseEvent, PlatformKeyboardEvent, PlatformWheelEvent
3212 and PlatformGestureEvent and move Type enumeration and modifiers down to it.
3214 * WebView/WebFrame.mm:
3215 (-[WebFrame _dragSourceEndedAt:operation:]):
3216 * WebView/WebHTMLView.mm:
3217 (currentKeyboardEvent):
3218 (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
3219 * WebView/WebPDFView.mm:
3220 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3222 2011-12-16 Simon Fraser <simon.fraser@apple.com>
3224 Fix a #elsif fumble in my earlier commit.
3226 * WebView/WebHTMLView.mm:
3227 (-[WebHTMLView attachRootLayer:]):
3229 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
3231 Only EditCommandComposition should implement unapply and reapply
3232 https://bugs.webkit.org/show_bug.cgi?id=74490
3234 Reviewed by Eric Seidel.
3236 * WebCoreSupport/WebEditorClient.h:
3237 * WebCoreSupport/WebEditorClient.mm:
3238 (-[WebUndoStep initWithUndoStep:]):
3239 (-[WebUndoStep dealloc]):
3240 (+[WebUndoStep stepWithUndoStep:]):
3241 (-[WebUndoStep step]):
3242 (-[WebEditorUndoTarget undoEditing:]):
3243 (-[WebEditorUndoTarget redoEditing:]):
3244 (WebEditorClient::registerCommandForUndoOrRedo):
3245 (WebEditorClient::registerCommandForUndo):
3246 (WebEditorClient::registerCommandForRedo):
3248 2011-12-16 Simon Fraser <simon.fraser@apple.com>
3250 <rdar://problem/10589427> Avoid calling -setGeometryFlipped ourselves on the layer hosting view's layer
3252 Reviewed by Sam Weinig.
3254 Now that we're using a flipped view to host the compositing layers,
3255 we should not set geometryFlipped on the root layer ourselves.
3257 * WebView/WebHTMLView.mm:
3258 (-[WebHTMLView attachRootLayer:]):
3260 2011-12-16 Mark Hahnenberg <mhahnenberg@apple.com>
3262 De-virtualize destructors
3263 https://bugs.webkit.org/show_bug.cgi?id=74331
3265 Reviewed by Geoffrey Garen.
3267 * Plugins/Hosted/ProxyRuntimeObject.h: Remove empty virtual destructor.
3268 * Plugins/Hosted/ProxyRuntimeObject.mm:
3270 2011-12-14 Ryosuke Niwa <rniwa@webkit.org>
3272 Mac build fix after r102874.
3274 * WebCoreSupport/WebChromeClient.mm:
3276 2011-12-14 Jing Zhao <jingzhao@chromium.org>
3278 Opening two popup menus by dispatchEvent() makes problems.
3279 https://bugs.webkit.org/show_bug.cgi?id=73304
3281 Reviewed by Kent Tamura.
3283 * WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().
3284 * WebCoreSupport/WebChromeClient.mm:
3285 (WebChromeClient::hasOpenedPopup): Not implemented.
3287 2011-12-14 Michael Saboff <msaboff@apple.com>
3289 Mac WebScriptDebugger crashes beneath sourceParsed()
3290 https://bugs.webkit.org/show_bug.cgi?id=74564
3292 Reviewed by Gavin Barraclough.
3294 * WebView/WebScriptDebugger.mm:
3295 (toNSString): Change to use ->characters() method to
3296 actually get characters for string conversion.
3298 2011-12-14 Hajime Morrita <morrita@chromium.org>
3300 JS_INLINE and WTF_INLINE should be visible from WebCore
3301 https://bugs.webkit.org/show_bug.cgi?id=73191
3303 Reviewed by Kevin Ollivier.
3305 Removed macro definitions which is now provided by Platform.h
3309 2011-12-13 Jon Lee <jonlee@apple.com>
3311 Enable notifications on Mac.
3313 Reviewed by Sam Weinig.
3315 * Configurations/FeatureDefines.xcconfig:
3317 2011-12-12 Ryosuke Niwa <rniwa@webkit.org>
3319 WebKit code shouldn't be calling applyCommand directly
3320 https://bugs.webkit.org/show_bug.cgi?id=74337
3322 Reviewed by Darin Adler.
3324 * WebView/WebFrame.mm:
3325 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3327 2011-12-12 Brady Eidson <beidson@apple.com>
3329 Page cache should support pages with plugins.
3330 <rdar://problem/5190122> and https://bugs.webkit.org/show_bug.cgi?id=13634
3332 Expose a WebKit preference for the page cache supporting plugins (on by default).
3334 Reviewed by Anders Carlsson.
3336 * WebView/WebPreferenceKeysPrivate.h:
3338 * WebView/WebPreferences.mm:
3339 (-[WebPreferences pageCacheSupportsPlugins]):
3340 (-[WebPreferences setPageCacheSupportsPlugins:]):
3341 * WebView/WebPreferencesPrivate.h:
3343 * WebView/WebView.mm:
3344 (-[WebView _preferencesChanged:]):
3346 2011-12-12 Dan Bernstein <mitz@apple.com>
3348 <rdar://problem/10328474> Text highlight changes to gray selection color when menu extra is shown
3350 Reviewed by John Sullivan.
3352 * WebView/WebView.mm:
3353 (-[WebView _updateActiveState]): Changed to use -[NSWindow _hasKeyAppearance] instead
3354 of -isKeyWindow. The former also returns YES when a menu extra is open.
3355 (-[WebView addWindowObserversForWindow:]): Removed code to observe
3356 NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification.
3357 (-[WebView removeWindowObservers]): Removed code to stop observing the above.
3358 (-[WebView _windowChangedKeyState]): Overridden this to call _updateActiveState.
3359 This is called when the result of -_hasKeyAppearance changes.
3360 (-[WebView _windowWillOrderOnScreen:]): Removed call to _updateActiveState,
3361 previously needed for popovers, because _windowChangedKeyState is invoked
3362 at the right time for them.
3363 (-[WebView _windowWillOrderOffScreen:]): Ditto.
3365 2011-12-07 Mark Rowe <mrowe@apple.com>
3367 Fix the 32-bit build.
3369 Ignore some warnings that only occur in 32-bit.
3371 * Plugins/WebNetscapePluginPackage.mm:
3373 2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
3375 Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
3376 https://bugs.webkit.org/show_bug.cgi?id=73986
3378 Reviewed by Kenneth Rohde Christiansen.
3380 * WebView/WebView.mm:
3381 (-[WebView _commonInitializationWithFrameName:groupName:]):
3383 2011-12-06 Alexey Proskuryakov <ap@apple.com>
3385 REGRESSION (WebKit2): Kill ring is not cleared when selection changes
3386 https://bugs.webkit.org/show_bug.cgi?id=73888
3387 <rdar://problem/10532310>
3389 Reviewed by Mark Rowe.
3391 * WebView/WebHTMLView.mm:
3392 (-[WebHTMLView becomeFirstResponder]): Added a FIXME comment.
3393 (-[WebHTMLView _selectionChanged]): Moved the code to clear kill ring to WebCore. The rest
3394 of kill ring implementation is there, so it makes no sense to have this call in WebKits.
3396 2011-12-05 Anders Carlsson <andersca@apple.com>
3398 Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not
3399 https://bugs.webkit.org/show_bug.cgi?id=73862
3401 Reviewed by Andy Estes.
3403 Remove the call to LayerFlushScheduler::invalidate and return true instead. Return false for the cases
3404 where we don't want the layer flush scheduler to be invalidated.
3406 * WebView/WebView.mm:
3407 (LayerFlushController::flushLayers):
3408 * WebView/WebViewData.h:
3410 2011-12-05 Eric Carlson <eric.carlson@apple.com>
3412 Add WebKit preferences for text track settings
3413 https://bugs.webkit.org/show_bug.cgi?id=73721
3415 Reviewed by John Sullivan.
3417 * WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
3418 and shouldDisplayTextDescriptions properties.
3420 * WebView/WebPreferences.mm:
3421 (+[WebPreferences initialize]): Initialize new preferences to NO.
3422 (-[WebPreferences setShouldDisplaySubtitles:]): Added.
3423 (-[WebPreferences shouldDisplaySubtitles]): Ditto.
3424 (-[WebPreferences setShouldDisplayCaptions:]): Ditto.
3425 (-[WebPreferences shouldDisplayCaptions]): Ditto.
3426 (-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto.
3427 (-[WebPreferences shouldDisplayTextDescriptions]): Ditto.
3428 * WebView/WebPreferencesPrivate.h:
3430 * WebView/WebView.mm:
3431 (-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs.
3433 2011-12-03 Dan Bernstein <mitz@apple.com>
3435 <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
3436 Reviewed by Darin Adler.
3438 * WebView/WebView.mm:
3439 (-[WebView _removeObjectForIdentifier:]): Changed the CFRelease(self) into
3440 a WebCFAutorelease(self). This prevents re-entry into this method due to
3441 the WebView closing and canceling all subresource loads, including the
3442 one we have just removed.
3444 2011-12-02 David Levin <levin@chromium.org>
3446 Rename WTF class from TemporarilyChange to TemporaryChange.
3447 https://bugs.webkit.org/show_bug.cgi?id=73479
3449 Reviewed by Eric Seidel.
3451 * ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
3452 * ForwardingHeaders/wtf/TemporaryChange.h: Added.
3454 2011-12-02 Simon Fraser <simon.fraser@apple.com>
3456 <rdar://problem/10423627> Layers are flipped in WebKit1 views
3458 Reviewed by Sam Weinig.
3460 Host the compositing layers in an NSView which is flipped, which helps AppKit
3461 get the geometry right in some situations.
3463 * WebView/WebHTMLView.mm:
3464 (-[WebLayerHostingFlippedView isFlipped]):
3465 (-[WebHTMLView attachRootLayer:]):
3467 2011-12-02 Hajime Morrita <morrita@chromium.org>
3469 Unreviewed, rolling out r101751 and r101775.
3470 http://trac.webkit.org/changeset/101751
3471 http://trac.webkit.org/changeset/101775
3472 https://bugs.webkit.org/show_bug.cgi?id=73191
3474 breaks Windows build
3478 2011-12-01 Hajime Morrita <morrita@chromium.org>
3480 JS_INLINE and WTF_INLINE should be visible from WebCore
3481 https://bugs.webkit.org/show_bug.cgi?id=73191
3483 Reviewed by Kevin Ollivier.
3485 Removed macro definitions which is now provided by Platform.h
3489 2011-11-30 Alexey Proskuryakov <ap@apple.com>
3491 Remove an unneeded argument from FrameLoaderClient::download
3492 https://bugs.webkit.org/show_bug.cgi?id=73486
3494 Reviewed by Andreas Kling.
3496 * WebCoreSupport/WebFrameLoaderClient.h:
3497 * WebCoreSupport/WebFrameLoaderClient.mm:
3498 (WebFrameLoaderClient::download):
3499 Updated for the change.
3501 2011-11-30 Dan Bernstein <mitz@apple.com>
3503 WebKit/mac part of: Allow the length of a page along the pagination axis to differ from the length of the view
3504 https://bugs.webkit.org/show_bug.cgi?id=73476
3506 Reviewed by Anders Carlsson.
3508 * WebView/WebView.mm:
3509 (-[WebView _setPageLength:]): Added this accessor.
3510 (-[WebView _pageLength]): Ditto.
3511 * WebView/WebViewPrivate.h:
3513 2011-11-30 Alexey Proskuryakov <ap@apple.com>
3515 Download page URL should be set by WebCore
3516 https://bugs.webkit.org/show_bug.cgi?id=73358
3518 Reviewed by Darin Adler.
3520 * WebCoreSupport/WebFrameLoaderClient.h: Removed setOriginalURLForDownload, which is now
3523 * WebCoreSupport/WebFrameLoaderClient.mm:
3524 (WebFrameLoaderClient::download): There is no need to set original URL post factum any more.
3525 (WebFrameLoaderClient::startDownload): Ditto.
3527 2011-11-29 David Levin <levin@chromium.org>
3529 Add a way to revert a variable to its previous value after leaving a scope.
3530 https://bugs.webkit.org/show_bug.cgi?id=73371
3532 Reviewed by Adam Barth.
3534 * ForwardingHeaders/wtf/TemporarilyChange.h: Added.
3536 2011-11-29 Jessie Berlin <jberlin@apple.com>
3538 WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins
3539 the first time it is called.
3540 https://bugs.webkit.org/show_bug.cgi?id=73374 (<rdar://problem/10196057>)
3542 Reviewed by Brady Eidson.
3544 * Storage/WebStorageTrackerClient.h:
3545 * Storage/WebStorageTrackerClient.mm:
3546 (WebStorageTrackerClient::didFinishLoadingOrigins):
3548 2011-11-15 Anders Carlsson <andersca@apple.com>
3550 DragClient::dragSourceActionMaskForPoint should use root view coordinates
3551 https://bugs.webkit.org/show_bug.cgi?id=72409
3553 Reviewed by Sam Weinig.
3555 * WebCoreSupport/WebDragClient.mm:
3556 (WebDragClient::dragSourceActionMaskForPoint):
3557 Use -[WebView _convertPointFromRootView:] to convert the point to the web view coordinate system.
3559 2011-11-15 Anders Carlsson <andersca@apple.com>
3561 EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates
3562 https://bugs.webkit.org/show_bug.cgi?id=72408
3564 Reviewed by Sam Weinig.
3566 * WebCoreSupport/CorrectionPanel.mm:
3567 (CorrectionPanel::show):
3568 Convert the bounding rect to web view coordinates.
3570 * WebView/WebView.mm:
3571 (-[WebView _convertPointFromRootView:]):
3572 (-[WebView _convertRectFromRootView:]):
3573 * WebView/WebViewInternal.h:
3574 Add helper methods for converting from root view coordinates to web view coordinates.
3576 2011-11-29 Roland Steiner <rolandsteiner@chromium.org>
3578 <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
3579 https://bugs.webkit.org/show_bug.cgi?id=72848
3581 Reviewed by Dimitri Glazkov.
3583 * Configurations/FeatureDefines.xcconfig:
3585 2011-11-28 Jon Lee <jonlee@apple.com>
3587 Create skeleton framework for notifications support in WK2
3588 https://bugs.webkit.org/show_bug.cgi?id=73253
3589 <rdar://problem/10356943>
3591 Reviewed by Sam Weinig.
3593 * Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
3595 * WebCoreSupport/WebNotificationClient.h: Added.
3596 (WebNotificationClient::webView):
3597 * WebCoreSupport/WebNotificationClient.mm: Added. Implemented as stubs for now.
3598 (WebNotificationClient::WebNotificationClient):
3599 (WebNotificationClient::show):
3600 (WebNotificationClient::cancel):
3601 (WebNotificationClient::notificationObjectDestroyed):
3602 (WebNotificationClient::requestPermission):
3603 (WebNotificationClient::cancelRequestsForPermission):
3604 (WebNotificationClient::checkPermission):
3605 * WebView/WebView.mm: Set PageClient's notification client to an instance of this stubbed class.
3607 2011-11-28 Adam Roben <aroben@apple.com>
3609 Properly retain the OS X version string
3611 Fixes <http://webkit.org/b/73214> REGRESSION (r101215): Crash on launch beneath +[WebView
3612 _standardUserAgentWithApplicationName:]
3614 Reviewed by Antti Koivisto.
3616 * WebView/WebView.mm:
3617 (createMacOSXVersionString): Retain the string we're returning, since this function is
3618 supposed to return an owning reference to the caller.
3620 2011-11-28 Hayato Ito <hayato@chromium.org>
3622 Fix chromium canary build after r101215.
3623 Unreviewed. Build fix.
3625 * WebCoreSupport/WebSystemInterface.mm:
3626 (InitWebCoreSystemInterface):
3628 2011-11-27 Mark Rowe <mrowe@apple.com>
3630 <http://webkit.org/b/72665> Switch to a more modern approach to retrieving the OS marketing version
3632 Reviewed by Dan Bernstein.
3634 * WebCoreSupport/WebSystemInterface.mm:
3635 (InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.
3636 * WebView/WebView.mm:
3637 (createMacOSXVersionString): Use WKGetMacOSXVersionString.
3639 2011-11-26 Pavel Feldman <pfeldman@google.com>
3641 Web Inspector: remove disconnectFromBackend from the protocol.
3642 https://bugs.webkit.org/show_bug.cgi?id=73127
3644 Reviewed by Yury Semikhatsky.
3646 * WebCoreSupport/WebInspectorClient.h:
3647 * WebCoreSupport/WebInspectorClient.mm:
3648 (WebInspectorClient::inspectorDestroyed):
3649 (WebInspectorClient::closeInspectorFrontend):
3651 2011-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
3653 Unreviewed, rolling out r101193.
3654 http://trac.webkit.org/changeset/101193
3655 https://bugs.webkit.org/show_bug.cgi?id=73158
3657 Breaks Windows and Qt minimal. (Requested by pfeldman on
3660 * WebCoreSupport/WebInspectorClient.h:
3661 * WebCoreSupport/WebInspectorClient.mm:
3662 (WebInspectorClient::inspectorDestroyed):
3664 2011-11-26 Pavel Feldman <pfeldman@google.com>
3666 Web Inspector: remove disconnectFromBackend from the protocol.
3667 https://bugs.webkit.org/show_bug.cgi?id=73127
3669 Reviewed by Yury Semikhatsky.
3671 * WebCoreSupport/WebInspectorClient.h:
3672 * WebCoreSupport/WebInspectorClient.mm:
3673 (WebInspectorClient::inspectorDestroyed):
3674 (WebInspectorClient::closeInspectorFrontend):
3676 2011-11-22 Pavel Feldman <pfeldman@google.com>
3678 Web Inspector: remove Inspector::bringToFront from the protocol.
3679 https://bugs.webkit.org/show_bug.cgi?id=72937
3681 Reviewed by Yury Semikhatsky.
3683 * WebCoreSupport/WebInspectorClient.h:
3684 * WebCoreSupport/WebInspectorClient.mm:
3685 (WebInspectorClient::openInspectorFrontend):
3686 (WebInspectorClient::bringFrontendToFront):
3688 2011-11-21 Mark Rowe <mrowe@apple.com>
3690 Fix the SnowLeopard build.
3692 * Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was
3693 not yet declared in a public header.
3695 2011-11-20 Mark Rowe <mrowe@apple.com>
3697 <http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name
3699 Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon
3702 Reviewed by Dan Bernstein.
3704 * Misc/WebNSFileManagerExtras.mm:
3705 (-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy
3706 the volume name from its description dictionary.
3708 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
3710 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
3711 https://bugs.webkit.org/show_bug.cgi?id=62985
3713 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
3714 methods for plumbing the menu action handlers through the WebKit and WebCore.
3715 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
3716 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
3717 WebKit/win and WebKit2 to follow.
3719 Reviewed by Yury Semikhatsky.
3721 * WebCoreSupport/WebInspectorClient.mm:
3722 (-[WebInspectorWindowController destroyInspectorView:]):
3723 * WebInspector/WebInspector.mm:
3724 (-[WebInspector showWindow]):
3725 (-[WebInspector show:]):
3726 (-[WebInspector showConsole:]):
3727 (-[WebInspector isDebuggingJavaScript]):
3728 (-[WebInspector toggleDebuggingJavaScript:]):
3729 (-[WebInspector startDebuggingJavaScript:]):
3730 (-[WebInspector stopDebuggingJavaScript:]):
3731 (-[WebInspector isProfilingJavaScript]):
3732 (-[WebInspector toggleProfilingJavaScript:]):
3733 (-[WebInspector startProfilingJavaScript:]):
3734 (-[WebInspector stopProfilingJavaScript:]):
3735 (-[WebInspector isJavaScriptProfilingEnabled]):
3736 (-[WebInspector setJavaScriptProfilingEnabled:]):
3737 (-[WebInspector isTimelineProfilingEnabled]):
3738 (-[WebInspector setTimelineProfilingEnabled:]):
3739 (-[WebInspector setFrontend:]):
3740 (-[WebInspector releaseFrontend]):
3741 (-[WebInspector showWindow:]):
3742 * WebInspector/WebInspectorFrontend.h:
3743 * WebInspector/WebInspectorFrontend.mm:
3744 (-[WebInspectorFrontend isDebuggingEnabled]):
3745 (-[WebInspectorFrontend setDebuggingEnabled:]):
3746 (-[WebInspectorFrontend isProfilingJavaScript]):
3747 (-[WebInspectorFrontend startProfilingJavaScript]):
3748 (-[WebInspectorFrontend stopProfilingJavaScript]):
3749 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
3750 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
3751 (-[WebInspectorFrontend isTimelineProfilingEnabled]):
3752 (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
3753 * WebInspector/WebInspectorPrivate.h:
3755 2011-11-21 Jochen Eisinger <jochen@chromium.org>
3757 Implement Meta referrer
3758 https://bugs.webkit.org/show_bug.cgi?id=72674
3760 Reviewed by Adam Barth.
3762 * Plugins/Hosted/HostedNetscapePluginStream.mm:
3763 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
3764 * Plugins/WebNetscapePluginStream.mm:
3765 (WebNetscapePluginStream::WebNetscapePluginStream):
3767 2011-10-17 Antonio Gomes <agomes@rim.com>
3769 Pass a Frame* parameter in EditorClient::respondToChangedSelection
3770 https://bugs.webkit.org/show_bug.cgi?id=70248
3772 Reviewed by Ryosuke Niwa.
3774 * WebCoreSupport/WebEditorClient.h:
3775 * WebCoreSupport/WebEditorClient.mm: Make use of the newly added Frame* parameter.
3776 (WebEditorClient::respondToChangedSelection):
3778 2011-11-17 Mark Rowe <mrowe@apple.com>
3780 <http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
3781 switch away from the deprecated APIs.
3783 Reviewed by Sam Weinig.
3785 * Plugins/WebBasePluginPackage.mm:
3786 * Plugins/WebNetscapePluginPackage.mm:
3787 (-[WebNetscapePluginPackage _tryLoad]):
3789 2011-11-18 Anton D'Auria <adauria@apple.com>
3791 bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true
3792 https://bugs.webkit.org/show_bug.cgi?id=72568
3794 Reviewed by David Kilzer.
3796 WebChromeClient::shouldInterruptJavaScript called CallUIDelegate, which used an id
3797 as the return value, which was then cast to a bool and always returned true. This
3798 patch uses CallUIDelegateReturningBoolean instead of CallUIDelegate, with the default
3801 * WebCoreSupport/WebChromeClient.mm:
3802 (WebChromeClient::shouldInterruptJavaScript):
3804 2011-11-16 Dan Bernstein <mitz@apple.com>
3806 WebKit/mac part of <rdar://problem/10262242> Add API for paginated display
3807 https://bugs.webkit.org/show_bug.cgi?id=72537
3809 Reviewed by Anders Carlsson.
3811 * WebView/WebView.mm:
3812 (-[WebView _setPaginationMode:]): Added this accessor.
3813 (-[WebView _paginationMode]): Ditto.
3814 (-[WebView _setGapBetweenPages:]): Ditto.
3815 (-[WebView _gapBetweenPages]): Ditto.
3816 (-[WebView _pageCount]): Ditto.
3817 * WebView/WebViewPrivate.h: Defined WebPaginationMode enum and values.
3819 2011-11-15 Andy Estes <aestes@apple.com>
3821 Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
3822 https://bugs.webkit.org/show_bug.cgi?id=72106
3824 Reviewed by Anders Carlsson.
3826 Remove code that schedules layer flushes and use LayerFlushScheduler instead.
3828 * WebView/WebView.mm:
3829 (-[WebView _close]): Invalidate the run loop observer and destroy the
3830 LayerFlushController.
3831 (LayerFlushController::flushLayers): Perform the work that
3832 layerSyncRunLoopObserverCallBack used to do.
3833 (-[WebView _scheduleCompositingLayerSync]): If layerFlushController has
3834 yet to be created, create it, then schedule a layer flush.
3835 * WebView/WebViewData.h:
3836 (LayerFlushController::create): Create a LayerFlushController that
3837 implements the LayerFlushSchedulerClient interface and contains a
3838 LayerFlushScheduler with itself as the client.
3839 * WebView/WebViewData.mm:
3840 (LayerFlushController::scheduleLayerFlush):
3841 (LayerFlushController::invalidateObserver):
3842 (LayerFlushController::LayerFlushController):
3844 2011-11-15 Jochen Eisinger <jochen@chromium.org>
3846 Rename ReferrerPolicy to clarify its meaning
3847 https://bugs.webkit.org/show_bug.cgi?id=72420
3849 Reviewed by Nate Chapin.
3851 * WebView/WebPDFView.mm:
3852 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3854 2011-11-15 Anders Carlsson <andersca@apple.com>
3856 HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
3857 https://bugs.webkit.org/show_bug.cgi?id=72397
3859 Reviewed by Dan Bernstein.
3861 * WebCoreSupport/WebChromeClient.h:
3862 * WebCoreSupport/WebChromeClient.mm:
3863 (WebChromeClient::screenToRootView):
3864 (WebChromeClient::rootViewToScreen):
3866 2011-11-14 Anders Carlsson <andersca@apple.com>
3868 HostWindow invalidation functions should use root view coordinates
3869 https://bugs.webkit.org/show_bug.cgi?id=72338
3871 Reviewed by Dan Bernstein.
3873 * WebCoreSupport/WebChromeClient.h:
3874 * WebCoreSupport/WebChromeClient.mm:
3875 (WebChromeClient::invalidateRootView):
3876 (WebChromeClient::invalidateContentsAndRootView):
3877 (WebChromeClient::invalidateContentsForSlowScroll):
3879 2011-11-14 Julien Chaffraix <jchaffraix@webkit.org>
3881 Add --css-grid-layout to build-webkit and the build systems
3882 https://bugs.webkit.org/show_bug.cgi?id=72320
3884 Reviewed by Ojan Vafai.
3886 * Configurations/FeatureDefines.xcconfig:
3888 2011-11-14 Tony Chang <tony@chromium.org>
3890 Remove the CSS3_FLEXBOX compile time flag and enable on all ports
3891 https://bugs.webkit.org/show_bug.cgi?id=72196
3893 Reviewed by Ojan Vafai.
3895 * Configurations/FeatureDefines.xcconfig:
3897 2011-11-07 Adam Barth <abarth@webkit.org>
3899 Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
3900 https://bugs.webkit.org/show_bug.cgi?id=71755
3902 Reviewed by Eric Seidel.
3904 * Plugins/Hosted/HostedNetscapePluginStream.mm:
3905 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
3906 * Plugins/WebNetscapePluginStream.mm:
3907 (WebNetscapePluginStream::WebNetscapePluginStream):
3908 * WebView/WebView.mm:
3909 (-[WebView _commonInitializationWithFrameName:groupName:]):
3910 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
3911 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
3912 (+[WebView _resetOriginAccessWhitelists]):
3914 2011-11-08 Joseph Pecoraro <pecoraro@apple.com>
3916 Move NSRange / DOMRange functions back to WebFrameInternal
3917 https://bugs.webkit.org/show_bug.cgi?id=71844
3919 Reviewed by Alexey Proskuryakov.
3921 * WebView/WebFrame.mm:
3922 (-[WebFrame _convertNSRangeToDOMRange:]):
3923 (-[WebFrame _convertDOMRangeToNSRange:]):
3924 * WebView/WebFrameInternal.h:
3925 * WebView/WebFramePrivate.h:
3927 2011-11-08 Michael Saboff <msaboff@apple.com>
3929 Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
3930 https://bugs.webkit.org/show_bug.cgi?id=71761
3932 Changed WKPCEvaluate() to use emptyString() when the source is
3935 Reviewed by Gavin Barraclough.
3937 * Plugins/Hosted/NetscapePluginHostProxy.mm:
3940 2011-11-08 Beth Dakin <bdakin@apple.com>
3942 https://bugs.webkit.org/show_bug.cgi?id=71856
3943 WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of
3944 old NSWindowDidChangeResolutionNotification
3946 <rdar://problem/10317253>
3948 Reviewed by Tim Hatcher.
3950 * WebView/WebView.mm:
3951 (-[WebView addWindowObserversForWindow:]):
3952 (-[WebView removeWindowObservers]):
3954 We have to check that the backing scale factor actually changed since this
3955 notification can also be used to signify other changes.
3956 (-[WebView _windowDidChangeBackingProperties:]):
3958 2011-11-07 Adam Barth <abarth@webkit.org>
3960 Move DomainRelaxationForbidden scheme registry to SchemeRegistry
3961 https://bugs.webkit.org/show_bug.cgi?id=71750
3963 Reviewed by Eric Seidel.
3965 * WebView/WebView.mm:
3966 (+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
3968 2011-11-07 Jessie Berlin <jberlin@apple.com>
3970 Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
3972 https://bugs.webkit.org/show_bug.cgi?id=71631
3974 Reviewed by Jon Honeycutt.
3976 Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and
3979 * WebView/WebView.mm:
3980 (+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]):
3981 Call through to the SchemeRegistry function.
3982 (+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]):
3984 * WebView/WebViewPrivate.h:
3986 2011-11-03 Mark Hahnenberg <mhahnenberg@apple.com>
3988 De-virtualize JSObject::getPropertyNames
3989 https://bugs.webkit.org/show_bug.cgi?id=71306
3991 Reviewed by Darin Adler.
3993 Added getPropertyNames to the MethodTable, changed all the virtual
3994 implementations of getPropertyNames to static ones, and replaced
3995 all call sites with corresponding lookups in the MethodTable.
3997 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3998 (WebKit::NetscapePluginInstanceProxy::enumerate):
4000 2011-11-02 Darin Adler <darin@apple.com>
4002 Change remaining callers of releaseRef to call leakRef
4003 https://bugs.webkit.org/show_bug.cgi?id=71422
4005 Reviewed by Darin Fisher.
4007 * History/WebBackForwardList.mm:
4008 (-[WebBackForwardList initWithBackForwardList:]):
4009 * History/WebHistoryItem.mm:
4010 (-[WebHistoryItem copyWithZone:]):
4011 (-[WebHistoryItem initWithWebCoreHistoryItem:]):
4012 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
4013 (-[WebHostedNetscapePluginView createPlugin]):
4014 * Plugins/WebNetscapePluginView.mm:
4015 (-[WebNetscapePluginView createPlugin]):
4016 * WebCoreSupport/WebOpenPanelResultListener.mm:
4017 * WebView/WebDataSource.mm:
4018 (-[WebDataSource _initWithDocumentLoader:]):
4019 * WebView/WebResource.mm:
4020 (-[WebResourcePrivate initWithCoreResource:]):
4023 2011-11-02 Joseph Pecoraro <pecoraro@apple.com>
4025 Move NSRange / DOMRange conversion functions to WebFramePrivate
4026 https://bugs.webkit.org/show_bug.cgi?id=71435
4028 Reviewed by Sam Weinig.
4030 Move conversion functions to WebFramePrivate,
4031 and remove the no longer used versions.
4033 * WebView/WebFrame.mm:
4034 (-[WebFrame _convertNSRangeToDOMRange:]):
4035 (-[WebFrame _convertDOMRangeToNSRange:]):
4036 * WebView/WebFrameInternal.h:
4037 * WebView/WebFramePrivate.h:
4039 2011-11-02 Dean Jackson <dino@apple.com>
4041 Add ENABLE_CSS_SHADERS flag
4042 https://bugs.webkit.org/show_bug.cgi?id=71394
4044 Reviewed by Sam Weinig.
4046 * Configurations/FeatureDefines.xcconfig:
4048 2011-11-02 Jon Lee <jonlee@apple.com>
4050 Expand DragController to provide more information about the dragging session
4051 https://bugs.webkit.org/show_bug.cgi?id=71324
4052 <rdar://problem/10379175>
4054 Reviewed by Darin Adler.
4056 * WebView/WebView.mm:
4057 (-[WebView draggingEntered:]): DragOperation is now inside the DragSession struct.
4058 (-[WebView draggingUpdated:]):
4060 2011-11-02 Tom Sepez <tsepez@chromium.org>
4062 XSSAuditor is silent
4063 https://bugs.webkit.org/show_bug.cgi?id=70973
4065 Reviewed by Adam Barth.
4067 * WebCoreSupport/WebFrameLoaderClient.h:
4068 * WebCoreSupport/WebFrameLoaderClient.mm:
4069 (WebFrameLoaderClient::didRunInsecureContent):
4070 (WebFrameLoaderClient::didDetectXSS):
4071 * WebView/WebDelegateImplementationCaching.h:
4072 * WebView/WebFrameLoadDelegatePrivate.h:
4073 * WebView/WebView.mm:
4074 (-[WebView _cacheFrameLoadDelegateImplementations]):
4076 2011-11-01 Darin Adler <darin@apple.com>
4078 Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences
4079 https://bugs.webkit.org/show_bug.cgi?id=71289
4081 Reviewed by Dan Bernstein.
4083 Just adding a null check. I don't have access to an actual PDF with
4084 this problem but crashes from the field indicate they exist.
4086 * WebView/WebPDFDocumentExtras.mm:
4087 (allScriptsInPDFDocument): Skip the code to add the script text
4088 to an array when the script is null.
4090 2011-10-28 John Sullivan <sullivan@apple.com>
4093 https://bugs.webkit.org/show_bug.cgi?id=71142
4094 Whether backspace goes Back should be configurable
4096 Reviewed by Sam Weinig.
4098 * WebView/WebFrameView.mm:
4099 (-[WebFrameView keyDown:]):
4100 Honor the new preference.
4102 * WebView/WebPreferenceKeysPrivate.h:
4103 Added #define for WebKitBackspaceKeyNavigationEnabledKey
4105 * WebView/WebPreferences.mm:
4106 (+[WebPreferences initialize]):
4107 Initialize new pref to YES, to match current behavior.
4108 (-[WebPreferences setBackspaceKeyNavigationEnabled:]):
4109 New method, standard prefs setter.
4110 (-[WebPreferences backspaceKeyNavigationEnabled]):
4111 New method, standard prefs getter.
4113 * WebView/WebPreferencesPrivate.h:
4114 Declared new methods.
4116 * WebView/WebView.mm:
4117 (-[WebView _preferencesChanged:]):
4118 Updates WebCore settings from WebKit prefs.
4120 2011-10-28 Jochen Eisinger <jochen@chromium.org>
4122 Rename a number of methods mentioning JavaScript to just Script instead
4123 https://bugs.webkit.org/show_bug.cgi?id=71105
4125 Reviewed by Adam Barth.
4127 * WebView/WebView.mm:
4128 (-[WebView _preferencesChanged:]):
4130 2011-10-27 Joseph Pecoraro <pecoraro@apple.com>
4132 Reviewed by David Kilzer.
4134 Make FeatureDefines Identical Across OS X Projects
4135 https://bugs.webkit.org/show_bug.cgi?id=71051
4137 * Configurations/FeatureDefines.xcconfig:
4139 2011-10-27 Mark Hahnenberg <mhahnenberg@apple.com>
4141 De-virtualize JSCell::toThisObject
4142 https://bugs.webkit.org/show_bug.cgi?id=70958
4144 Reviewed by Geoffrey Garen.
4146 Converted all instances of toThisObject to static functions,
4147 added toThisObject to the MethodTable, and replaced all call sites
4148 with a corresponding lookup in the MethodTable.
4150 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4151 (WebKit::NetscapePluginInstanceProxy::invoke):
4152 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
4154 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
4156 Remove deletePropertyVirtual
4157 https://bugs.webkit.org/show_bug.cgi?id=70738
4159 Reviewed by Geoffrey Garen.
4161 Removed all declarations and definitions of deletePropertyVirtual.
4162 Also replaced all call sites to deletePropertyVirtual with a
4163 corresponding lookup in the MethodTable.
4165 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4166 (WebKit::NetscapePluginInstanceProxy::removeProperty):
4168 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
4171 https://bugs.webkit.org/show_bug.cgi?id=70740
4173 Reviewed by Geoffrey Garen.
4175 Removed all declarations and definitions of putVirtual.
4176 Also replaced all call sites to putVirtual with a
4177 corresponding lookup in the MethodTable.
4179 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4180 (WebKit::NetscapePluginInstanceProxy::setProperty):
4182 2011-10-24 Geoffrey Garen <ggaren@apple.com>
4184 Removed SharedUChar and tightened language around its previous uses
4185 https://bugs.webkit.org/show_bug.cgi?id=70698
4187 Reviewed by David Levin.
4189 - Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
4190 the former names gave the dangerous misimpression that the resulting object
4191 was thread-safe, which is not true.
4193 * Storage/WebDatabaseTrackerClient.mm:
4194 (DidModifyOriginData::dispatchToMainThread):
4196 2011-10-24 Michael Saboff <msaboff@apple.com>
4198 WebKit doesn't build with recent changes to libdispatch
4199 https://bugs.webkit.org/show_bug.cgi?id=70737
4201 Added initialization for new WebKitSystemInterface function
4202 CreateVMPressureDispatchOnMainQueue.
4204 Reviewed by Geoffrey Garen.
4206 * WebCoreSupport/WebSystemInterface.mm:
4207 (InitWebCoreSystemInterface):
4209 2011-10-23 Mark Hahnenberg <mhahnenberg@apple.com>
4211 Remove getConstructDataVirtual
4212 https://bugs.webkit.org/show_bug.cgi?id=70638
4214 Reviewed by Darin Adler.
4216 Removed all declarations and definitions of getConstructDataVirtual.
4217 Also replaced all call sites to getConstructDataVirtual with a
4218 corresponding lookup in the MethodTable.
4220 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4221 (WebKit::NetscapePluginInstanceProxy::construct):
4223 2011-10-20 Ian Henderson <ianh@apple.com>
4225 https://bugs.webkit.org/show_bug.cgi?id=70541
4226 There are two WebFrameLoadDelegatePrivate categories on NSObject
4228 Reviewed by David Kilzer.
4230 * WebView/WebViewPrivate.h: Rename the private delegate categories in
4231 WebViewPrivate.h with a "WebView" prefix to avoid collision.
4233 2011-10-20 Alexey Proskuryakov <ap@apple.com>
4235 REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in
4236 https://bugs.webkit.org/show_bug.cgi?id=70534
4237 <rdar://problem/10308827>
4239 Reviewed by Darin Adler.
4241 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Return true
4242 for contextmenu event, so that plug-ins won't get a default WebKit context menu. We can't
4243 know if the plug-in is handling mousedown (or even mouseup) by displaying a menu.
4245 2011-10-19 Beth Dakin <bdakin@apple.com>
4247 https://bugs.webkit.org/show_bug.cgi?id=70396
4248 Focus rings are too thin in HiDPI in WebKit2
4250 <rdar://problem/10086876>
4252 Reviewed by Dan Bernstein.
4254 Rename wkSetPatternBaseCTM to wkSetBaseCTM
4255 * WebCoreSupport/WebSystemInterface.mm:
4256 (InitWebCoreSystemInterface):
4258 To create a HiDPI context in DRT, we have to set the base CTM, which currently
4259 requires CG SPI, so we have to do it through WebKitSystemInterface.
4260 * WebView/WebView.mm:
4261 (-[WebView _setBaseCTM:forContext:]):
4262 * WebView/WebViewPrivate.h:
4264 2011-10-18 Adam Barth <abarth@webkit.org>
4266 Always enable ENABLE(XPATH)
4267 https://bugs.webkit.org/show_bug.cgi?id=70217
4269 Reviewed by Eric Seidel.
4271 * Configurations/FeatureDefines.xcconfig:
4273 2011-10-14 Chris Marrin <cmarrin@apple.com>
4275 Throttle rate of requestAnimationFrame when page is not visible
4276 https://bugs.webkit.org/show_bug.cgi?id=67873
4278 Reviewed by Anders Carlsson.
4280 Plumb through notification when the window is hidden/shown or
4281 minimized/unminimized
4283 * WebView/WebView.mm:
4284 (-[WebView _windowWillOrderOnScreen:]):
4285 (-[WebView _windowWillOrderOffScreen:]):
4287 2011-10-16 Adam Barth <abarth@webkit.org>
4289 Always enable ENABLE(DOM_STORAGE)
4290 https://bugs.webkit.org/show_bug.cgi?id=70189
4292 Reviewed by Eric Seidel.
4294 * Configurations/FeatureDefines.xcconfig:
4295 * Storage/WebStorageManager.mm:
4296 * Storage/WebStorageManagerInternal.h:
4297 * Storage/WebStorageTrackerClient.h:
4298 * Storage/WebStorageTrackerClient.mm:
4299 (WebStorageTrackerClient::dispatchDidModifyOrigin):
4300 * WebView/WebView.mm:
4301 (-[WebView _commonInitializationWithFrameName:groupName:]):
4303 2011-10-14 David Kilzer <ddkilzer@apple.com>
4305 <http://webkit.org/b/70158> Fix clang compiler warnings
4307 Reviewed by Darin Adler.
4309 The following two methods in WebDelegateImplementationCaching.h
4310 are ambiguous in WebChromeClient::runJavaScriptPrompt() because
4311 the compiler can't decide how to convert the WTF::String
4312 defaultText argument:
4314 id CallUIDelegate(WebView *, SEL, id, id);
4315 id CallUIDelegate(WebView *, SEL, id, BOOL);
4317 The fix is to perform the conversion explicitly.
4319 * WebCoreSupport/WebChromeClient.mm:
4320 (WebChromeClient::runJavaScriptPrompt): Extract a defaultString
4321 variable to convert the WTF::String to an NSString*, then
4322 use defaultString in place of defaultText.
4324 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
4326 Rename virtual put to putVirtual
4327 https://bugs.webkit.org/show_bug.cgi?id=69851
4329 Reviewed by Darin Adler.
4331 Renamed virtual versions of put to putVirtual in prepration for
4332 adding the static put to the MethodTable in ClassInfo since the
4333 compiler gets mad if the virtual and static versions have the same
4336 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4337 (WebKit::NetscapePluginInstanceProxy::setProperty):
4339 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
4341 Rename virtual deleteProperty to deletePropertyVirtual
4342 https://bugs.webkit.org/show_bug.cgi?id=69884
4344 Reviewed by Darin Adler.
4346 Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
4347 adding the static deleteProperty to the MethodTable in ClassInfo since the
4348 compiler gets mad if the virtual and static versions have the same name.
4350 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4351 (WebKit::NetscapePluginInstanceProxy::removeProperty):
4353 2011-10-12 Ryosuke Niwa <rniwa@webkit.org>
4355 Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent
4356 https://bugs.webkit.org/show_bug.cgi?id=69964
4358 Reviewed by Enrica Casucci.
4360 * WebView/WebFrame.mm:
4361 (-[WebFrame _convertToNSRange:]):
4362 (-[WebFrame _convertToDOMRange:]):
4364 2011-10-13 Mark Hahnenberg <mhahnenberg@apple.com>
4366 Rename virtual getConstructData to getConstructDataVirtual
4367 https://bugs.webkit.org/show_bug.cgi?id=69872
4369 Reviewed by Geoffrey Garen.
4371 Renamed virtual getConstructData functions to getConstructDataVirtual to
4372 avoid conflicts when we add static getConstructData to the MethodTable.
4374 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4375 (WebKit::NetscapePluginInstanceProxy::construct):
4377 2011-10-13 Beth Dakin <bdakin@apple.com>
4379 https://bugs.webkit.org/show_bug.cgi?id=70050
4380 DRT and WRT should have HiDPI testing capabilities
4382 Reviewed by Darin Adler.
4384 New method _backingScaleFactor matches SPI of a similar name that I added
4385 recently to WKPage in WebKit2. Equivalent functionality is needed for
4386 DumpRenderTree's HiDPI support.
4387 * WebView/WebView.mm:
4388 (-[WebView _backingScaleFactor]):
4389 * WebView/WebViewPrivate.h:
4391 2011-10-12 Chris Marrin <cmarrin@apple.com>
4393 Sync requestAnimationFrame callback to CVDisplayLink on Mac
4394 https://bugs.webkit.org/show_bug.cgi?id=68911
4396 Reviewed by Simon Fraser.
4398 Add windowDidChangeScreen function which listens for the window changing
4399 screens and passes the new displayID along to WebCore::Page. It also sends
4400 one on windowWillOrderOnScreen, so the Page has a fresh displayID after it's
4403 * WebView/WebView.mm:
4404 (-[WebView addWindowObserversForWindow:]):
4405 (-[WebView removeWindowObservers]):
4406 (-[WebView _windowDidChangeScreen:]):
4407 (-[WebView _windowWillOrderOnScreen:]):
4409 2011-10-12 Adam Barth <abarth@webkit.org>
4411 Remove ENABLE(XHTMLMP) and associated code
4412 https://bugs.webkit.org/show_bug.cgi?id=69729
4414 Reviewed by David Levin.
4416 * Configurations/FeatureDefines.xcconfig:
4418 2011-10-10 Nate Chapin <japhet@chromium.org>
4420 Use a CachedImageClient instead of CachedResourceClient
4422 https://bugs.webkit.org/show_bug.cgi?id=69790
4424 Reviewed by Adam Barth.
4426 * WebView/WebHTMLView.mm:
4427 (promisedDataClient):
4429 2011-10-10 Mark Hahnenberg <mhahnenberg@apple.com>
4431 Remove getCallDataVirtual methods
4432 https://bugs.webkit.org/show_bug.cgi?id=69186
4434 Reviewed by Geoffrey Garen.
4436 Removed all getCallDataVirtual methods and replaced their call sites
4437 with an explicit lookup in the MethodTable.
4439 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4440 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
4442 2011-10-10 Joseph Pecoraro <joepeck@webkit.org>
4444 Extract WebOpenPanelResultListener out into its own file
4445 https://bugs.webkit.org/show_bug.cgi?id=69575
4447 Reviewed by David Kilzer.
4449 Extract the WebOpenPanelResultListener class out into
4450 its own file. No functional change.
4452 * WebCoreSupport/WebChromeClient.mm:
4453 * WebCoreSupport/WebOpenPanelResultListener.h: Added.
4454 * WebCoreSupport/WebOpenPanelResultListener.mm: Added.
4455 (-[WebOpenPanelResultListener dealloc]):
4456 (-[WebOpenPanelResultListener finalize]):
4457 (-[WebOpenPanelResultListener cancel]):
4458 (-[WebOpenPanelResultListener chooseFilename:]):
4459 (-[WebOpenPanelResultListener chooseFilenames:]):
4460 * WebView/WebUIDelegate.h:
4462 2011-10-08 Sheriff Bot <webkit.review.bot@gmail.com>
4464 Unreviewed, rolling out r96996.
4465 http://trac.webkit.org/changeset/96996
4466 https://bugs.webkit.org/show_bug.cgi?id=69697
4468 It broke all tests on the Qt bot (Requested by Ossy_night on
4471 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4472 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
4474 2011-10-07 Mark Hahnenberg <mhahnenberg@apple.com>
4476 Remove getCallDataVirtual methods
4477 https://bugs.webkit.org/show_bug.cgi?id=69186
4479 Reviewed by Geoffrey Garen.
4481 Removed all getCallDataVirtual methods and replaced their call sites
4482 with an explicit lookup in the MethodTable.
4484 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4485 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
4487 2011-10-06 Anders Carlsson <andersca@apple.com>
4489 When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
4490 https://bugs.webkit.org/show_bug.cgi?id=69586
4492 Reviewed by Darin Adler.
4494 * Configurations/Base.xcconfig:
4495 Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.
4497 2011-10-06 Anders Carlsson <andersca@apple.com>
4499 Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
4500 https://bugs.webkit.org/show_bug.cgi?id=69584
4502 Reviewed by Darin Adler.
4504 Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.
4506 * Plugins/Hosted/HostedNetscapePluginStream.mm:
4507 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4509 2011-10-03 Andy Estes <aestes@apple.com>
4511 Add an option to suppress rendering until the document's load event fires.
4512 https://bugs.webkit.org/show_bug.cgi?id=69298
4514 Reviewed by Simon Fraser.
4516 Add a new private WebPreference.
4518 * WebView/WebPreferenceKeysPrivate.h:
4519 * WebView/WebPreferences.mm:
4520 (+[WebPreferences initialize]):
4521 (-[WebPreferences setSuppressRenderingWhileInitiallyLoading:]):
4522 (-[WebPreferences suppressRenderingWhileInitiallyLoading]):
4523 * WebView/WebPreferencesPrivate.h:
4524 * WebView/WebView.mm:
4525 (-[WebView _preferencesChanged:]):
4527 2011-10-05 Jer Noble <jer.noble@apple.com>
4529 Enable WEB_AUDIO by default in the WebKit/mac port.
4530 https://bugs.webkit.org/show_bug.cgi?id=68587
4532 Reviewed by Simon Fraser.
4534 * Configurations/FeatureDefines.xcconfig:
4536 2011-10-05 David Kilzer <ddkilzer@apple.com>
4538 <http://webkit.org/b/69386> REGRESSION: Curious Location of StorageTracker.db
4540 Reviewed by Alexey Proskuryakov.
4542 * Storage/WebStorageManager.mm:
4543 (+[WebStorageManager _storageDirectoryPath]): Restore call to
4544 -[NSString stringByStandardizingPath]. Also fix over-release of
4545 sLocalStoragePath if the initial -objectForKey: call returned an
4546 NSString object. Use pthread_once to be thread-safe.
4548 2011-10-04 Kent Tamura <tkent@chromium.org>
4550 Introduce feature flags for incomplete input types
4551 https://bugs.webkit.org/show_bug.cgi?id=68971
4553 Reviewed by Hajime Morita.
4555 * Configurations/FeatureDefines.xcconfig:
4556 Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.
4558 2011-10-03 Geoffrey Garen <ggaren@apple.com>
4560 Some JSValue cleanup
4561 https://bugs.webkit.org/show_bug.cgi?id=69320
4563 Reviewed by Darin Adler.
4565 * WebView/WebView.mm:
4566 (aeDescFromJSValue): Updated for JSC changes.
4568 2011-10-04 Scott Graham <scottmg@chromium.org>
4570 Add GAMEPAD feature flag
4571 https://bugs.webkit.org/show_bug.cgi?id=66859
4573 Reviewed by Darin Fisher.
4575 * Configurations/FeatureDefines.xcconfig:
4577 2011-10-03 Jer Noble <jer.noble@apple.com>
4579 Unreviewed, rolling out r96526.
4580 http://trac.webkit.org/changeset/96526
4581 https://bugs.webkit.org/show_bug.cgi?id=68587
4583 WEB_AUDIO has numerous 64->32 bit casting warnings, causing
4584 build breakages where -Wall is enabled.
4586 * Configurations/FeatureDefines.xcconfig:
4588 2011-10-03 Jer Noble <jer.noble@apple.com>
4590 Enable WEB_AUDIO by default in the WebKit/mac port.
4591 https://bugs.webkit.org/show_bug.cgi?id=68587
4593 Reviewed by Simon Fraser.
4595 * Configurations/FeatureDefines.xcconfig:
4597 2011-10-02 Sam Weinig <sam@webkit.org>
4599 Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
4600 https://bugs.webkit.org/show_bug.cgi?id=69230
4602 Reviewed by Anders Carlsson.
4604 * WebView/WebHTMLRepresentation.mm:
4606 (searchForLabelsBeforeElement):
4607 (matchLabelsAgainstString):
4608 (matchLabelsAgainstElement):
4609 (-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
4610 (-[WebHTMLRepresentation matchLabels:againstElement:]):
4612 2011-10-02 Alexey Proskuryakov <ap@apple.com>
4614 REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
4615 https://bugs.webkit.org/show_bug.cgi?id=68542
4617 Reviewed by Mark Rowe.
4619 * WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.
4621 2011-10-01 Geoffrey Garen <ggaren@apple.com>
4623 Leopard build fix: Updated for Strong<T> changes.
4625 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4626 * WebView/WebScriptDebugger.mm:
4628 2011-09-28 Joseph Pecoraro <joepeck@webkit.org>
4630 ASSERT if WebView's UIDelegate does not implement webView:runOpenPanel
4631 https://bugs.webkit.org/show_bug.cgi?id=69037
4633 Reviewed by Alexey Proskuryakov.
4635 * WebCoreSupport/WebChromeClient.mm:
4636 (WebChromeClient::runOpenPanel):
4637 If no delegate is implemented, dismiss the listener
4638 with a cancel. It expects some action.
4640 2011-09-28 Anton D'Auria <adauria@apple.com>
4642 Expose +[WebStorageManager _storageDirectoryPath] as SPI
4643 https://bugs.webkit.org/show_bug.cgi?id=68951
4645 Reviewed by Brady Eidson.
4647 This patch exposes +[WebStorageManager _storageDirectoryPath], which
4648 pulls the path from NSUserDefaults if the preference is set. Otherwise,
4649 it falls back on the default path.
4651 * Storage/WebStorageManager.mm:
4652 (+[WebStorageManager _storageDirectoryPath]): Adding static variable
4653 so that we don't reread user defaults repeatedly.
4654 (WebKitInitializeStorageIfNecessary):
4655 * Storage/WebStorageManagerPrivate.h:
4657 2011-09-27 Andy Estes <aestes@apple.com>
4659 WebKitLinkedOnOrAfter() check is ineffective for Solar Walk app-specific hack.
4660 https://bugs.webkit.org/show_bug.cgi?id=68863
4662 Reviewed by Darin Adler.
4664 The SolarWalk binary does not link against WebKit.framework directly,
4665 so calling NSVersionOfLinkTimeLibrary() will not return the version of
4666 WebKit against which SolarWalk was linked. Since Solar Walk has
4667 released an update that addresses the issue for which this app-specific
4668 hack was originally added, we should just remove the hack.
4670 * Misc/SolarWalkQuirksUserScript.js: Removed.
4671 * WebView/WebView.mm: Removed needsSolarWalkQuirksScript(),
4672 leakSolarWalkQuirksUserScriptContents(), and
4673 -[WebView _injectSolarWalkQuirksScript].
4674 (-[WebView _commonInitializationWithFrameName:groupName:]): Do not
4675 inject the Solar Walk quirks script.
4677 2011-09-27 Mark Hahnenberg <mhahnenberg@apple.com>
4679 Add static version of JSCell::getCallData
4680 https://bugs.webkit.org/show_bug.cgi?id=68741
4682 Reviewed by Darin Adler.
4684 In this patch we just extract the bodies of the virtual getCallData methods
4685 throughout the JSCell inheritance hierarchy out into static methods, which are
4686 now called from the virtual methods. This is an intermediate step in trying to
4687 move the virtual-ness of getCallData into our own method table stored in
4688 ClassInfo. We need to convert the methods to static methods because static methods
4689 can be represented as function pointers rather than pointers to member functions, and
4690 function pointers are smaller and faster to call than pointers to member functions.
4692 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
4693 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
4695 2011-09-23 Simon Fraser <simon.fraser@apple.com>
4697 Repaint tests don't work in WebKit2
4698 https://bugs.webkit.org/show_bug.cgi?id=68453
4700 Reviewed by Sam Weinig.
4702 Have FrameView keep track of repaint rects when asked to, and
4703 expose this set of repaint rects via private WebKit API for later
4704 use by DumpRenderTree.
4706 * WebView/WebView.mm:
4707 (-[WebView setTracksRepaints:]):
4708 (-[WebView isTrackingRepaints]):
4709 (-[WebView resetTrackedRepaints]):
4710 (-[WebView trackedRepaintRects]):
4711 * WebView/WebViewPrivate.h:
4713 2011-09-25 Mark Hahnenberg <mhahnenberg@apple.com>
4715 Add custom vtable struct to ClassInfo struct
4716 https://bugs.webkit.org/show_bug.cgi?id=68567
4718 Reviewed by Oliver Hunt.
4720 Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
4721 specified class in its ClassInfo. Also added to it the first function to use
4722 this macro, visitChildren. This is part of the process of getting rid of all
4723 C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
4724 that can't easily be converted to non-virtual functions will be put into
4725 this custom vtable structure.
4727 * Plugins/Hosted/ProxyInstance.mm:
4728 * Plugins/Hosted/ProxyRuntimeObject.mm:
4730 2011-09-24 Adam Barth <abarth@webkit.org>
4732 Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
4733 https://bugs.webkit.org/show_bug.cgi?id=68767
4735 Reviewed by Eric Seidel.
4737 * Configurations/FeatureDefines.xcconfig:
4739 (+[WebCache empty]):
4740 * WebCoreSupport/WebApplicationCache.mm:
4741 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
4742 (-[WebApplicationCacheQuotaManager usage]):
4743 (-[WebApplicationCacheQuotaManager quota]):
4744 (-[WebApplicationCacheQuotaManager setQuota:]):
4745 * WebCoreSupport/WebChromeClient.h:
4746 * WebCoreSupport/WebChromeClient.mm:
4747 * WebView/WebDataSource.mm:
4748 (-[WebDataSource _transferApplicationCache:]):
4749 * WebView/WebFrame.mm:
4750 (-[WebFrame _cacheabilityDictionary]):
4751 * WebView/WebView.mm:
4752 (WebKitInitializeApplicationCachePathIfNecessary):
4754 2011-09-23 Adam Klein <adamk@chromium.org>
4756 Add ENABLE_MUTATION_OBSERVERS feature flag
4757 https://bugs.webkit.org/show_bug.cgi?id=68732
4759 Reviewed by Ojan Vafai.
4761 This flag will guard an implementation of the "Mutation Observers" proposed in
4762 http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
4764 * Configurations/FeatureDefines.xcconfig:
4766 2011-09-23 Anders Carlsson <andersca@apple.com>
4768 Axe WebImageRendererFactory
4769 https://bugs.webkit.org/show_bug.cgi?id=68715
4771 Reviewed by Darin Adler.
4773 Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.
4775 * WebCoreSupport/WebImageRendererFactory.m: Removed.
4777 2011-09-23 Anders Carlsson <andersca@apple.com>
4779 Add OVERRIDE to a bunch of virtual member functions on clients
4780 https://bugs.webkit.org/show_bug.cgi?id=68712
4782 Reviewed by Sam Weinig.
4784 * Configurations/Base.xcconfig:
4785 * WebCoreSupport/WebChromeClient.h:
4786 * WebCoreSupport/WebContextMenuClient.h:
4787 * WebCoreSupport/WebDeviceOrientationClient.h:
4788 * WebCoreSupport/WebDragClient.h:
4789 * WebCoreSupport/WebEditorClient.h:
4790 * WebCoreSupport/WebFrameLoaderClient.h:
4791 * WebCoreSupport/WebFrameNetworkingContext.h:
4792 * WebCoreSupport/WebGeolocationClient.h:
4793 * WebCoreSupport/WebIconDatabaseClient.h:
4794 * WebCoreSupport/WebInspectorClient.h:
4795 * WebCoreSupport/WebPlatformStrategies.h:
4797 2011-09-22 Dean Jackson <dino@apple.com>
4799 Add ENABLE_CSS_FILTERS
4800 https://bugs.webkit.org/show_bug.cgi?id=68652
4802 Reviewed by Simon Fraser.
4804 * Configurations/FeatureDefines.xcconfig:
4806 2011-09-22 Anders Carlsson <andersca@apple.com>
4808 Get rid of Widget::setBoundsSize
4809 https://bugs.webkit.org/show_bug.cgi?id=68491
4811 Reviewed by Sam Weinig.
4813 This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
4814 which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
4815 anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
4816 will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.
4818 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
4819 (-[WebHostedNetscapePluginView updateAndSetWindow]):
4820 * WebView/WebFrameView.mm:
4822 2011-09-19 Jer Noble <jer.noble@apple.com>
4824 Add settings to control the availability of the Web Audio API to WebKit and WebKit2.
4825 https://bugs.webkit.org/show_bug.cgi?id=68382
4827 Reviewed by Darin Adler.
4829 Initialize the webAudioEnabled preference to NO by default.
4831 * WebView/WebPreferences.mm:
4832 (+[WebPreferences initialize]):
4834 2011-09-21 Anders Carlsson <andersca@apple.com>
4836 Remove checks for Leopard-only Objective-C APIs
4837 https://bugs.webkit.org/show_bug.cgi?id=68579
4839 Reviewed by Sam Weinig.
4841 We can always assume that OBJC_API_VERSION is at least 2, it's been 2 since Leopard.
4843 * Misc/WebNSObjectExtras.h:
4845 2011-09-21 Andras Becsi <andras.becsi@nokia.com>
4847 [Qt] Remove Qt specific code from css/SelectorChecker.cpp
4848 https://bugs.webkit.org/show_bug.cgi?id=67702
4850 Reviewed by Csaba Osztrogonác.
4852 * WebCoreSupport/WebPlatformStrategies.h:
4853 * WebCoreSupport/WebPlatformStrategies.mm:
4854 (WebPlatformStrategies::isLinkVisited):
4856 2011-09-20 Anders Carlsson <andersca@apple.com>
4858 Remove ScrollView::platformContentsSize
4859 https://bugs.webkit.org/show_bug.cgi?id=68188
4861 Reviewed by Darin Adler.
4863 When creating the document view, make sure it's zero sized which matches the initial size
4864 of the ScrollView. This is fine to do early since DocumentWriter::begin sets the contents
4865 size to a zero size anyway.
4867 * WebView/WebFrameView.mm:
4868 (-[WebFrameView _makeDocumentViewForDataSource:]):
4870 2011-09-19 Pavel Feldman <pfeldman@google.com>
4872 Web Inspector: streamline Console's MessageType and MessageSource semantics.
4873 https://bugs.webkit.org/show_bug.cgi?id=68342
4875 This change fixes semantics of the MessageSource and MessageType:
4876 MessageSource is now the source of the message (be it Network, HTML
4877 parser or Console API). MessageType is only defined for the Console API
4878 messages and contains the name of the API call (log, dir, dirxml, etc.).
4879 Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
4880 private to the inspector.
4882 Reviewed by Tony Gentilcore.
4884 * WebCoreSupport/WebChromeClient.mm:
4885 (stringForMessageSource):
4886 (stringForMessageType):
4887 * WebView/WebUIDelegatePrivate.h:
4889 2011-09-19 Timothy Hatcher <timothy@apple.com>
4891 Make WebViews in NSPopovers render as they would in active windows.
4893 The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
4894 are shown or hidden since they share key with the parent window. So WebView
4895 and WebHTMLView need to also observe the will order on/off screen notifications.
4897 https://webkit.org/b/68402
4898 rdar://problem/9754099
4900 Reviewed by John Sullivan.
4902 * WebView/WebHTMLView.mm:
4903 (-[WebHTMLView _removeWindowObservers]): Remove order on/off screen notification obversers.
4904 (-[WebHTMLView addWindowObservers]): Add order on/off screen notification obversers.
4905 (-[WebHTMLView windowWillOrderOnScreen:]): Check if the window is already a key window,
4906 which can be the case for NSPopovers.
4907 (-[WebHTMLView windowWillOrderOffScreen:]): Remove the mouse moved observer.
4908 * WebView/WebView.mm:
4909 (-[WebView addWindowObserversForWindow:]): Add order off screen notification obverser.
4910 (-[WebView removeWindowObservers]): Remove order off screen notification obverser.
4911 (-[WebView _windowWillOrderOnScreen:]): Call _updateActiveState.
4912 (-[WebView _windowWillOrderOffScreen:]): Ditto.
4914 2011-09-19 Mark Rowe <mrowe@apple.com>
4916 <http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect
4918 On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking
4919 in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and
4920 a NoIdleSleep assertion as the latter is implied by the former.
4922 Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController.
4924 Reviewed by Dan Bernstein.
4926 * WebView/WebFullScreenController.h:
4927 * WebView/WebFullScreenController.mm:
4928 (-[WebFullScreenController dealloc]):
4929 (-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
4930 display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
4931 disabler that we own.
4933 2011-09-19 Adam Barth <abarth@webkit.org>
4935 Always enable ENABLE(EVENTSOURCE)
4936 https://bugs.webkit.org/show_bug.cgi?id=68414
4938 Reviewed by Eric Seidel.
4940 * Configurations/FeatureDefines.xcconfig:
4942 2011-09-19 Anders Carlsson <andersca@apple.com>
4944 Fix crashes when running WebKit1 tests.
4946 -[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
4947 equivalent code directly into -[WebHTMLView drawRect:].
4949 * WebView/WebHTMLView.mm:
4950 (-[WebHTMLView drawRect:]):
4951 * WebView/WebViewInternal.h:
4953 2011-09-19 Anders Carlsson <andersca@apple.com>
4955 Remove the last remains of viewless WebKit1
4956 https://bugs.webkit.org/show_bug.cgi?id=68388
4958 Reviewed by Darin Adler.
4960 * WebCoreSupport/WebFrameLoaderClient.mm:
4961 (WebFrameLoaderClient::forceLayoutForNonHTML):
4964 * WebView/WebView.mm:
4965 (-[WebView _commonInitializationWithFrameName:groupName:]):
4966 Remove usesDocumentViews parameter and checks.
4968 (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
4969 Add an assertion that usesDocumentViews is always true.
4971 (-[WebView _isUsingAcceleratedCompositing]):
4972 Remove usesDocumentViews check.
4974 (-[WebView _isSoftwareRenderable]):
4975 Remove usesDocumentViews check.
4977 (-[WebView initWithFrame:frameName:groupName:]):
4978 Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.
4980 (-[WebView initWithCoder:]):
4981 Remove usesDocumentViews parameter.
4983 (-[WebView _frameViewAtWindowPoint:]):
4984 Remove usesDocumentViews check.
4986 * WebView/WebViewData.h:
4987 Remove usesDocumentViews ivar.
4989 * WebView/WebViewPrivate.h:
4990 Remove usesDocumentViews parameters.
4992 2011-09-19 Anders Carlsson <andersca@apple.com>
4994 Remove WebViewEventHandling.mm
4995 https://bugs.webkit.org/show_bug.cgi?id=68387
4997 Reviewed by Adam Roben.
4999 WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
5000 we're getting rid of viewless WebKit1.
5002 * WebView/WebView.mm:
5003 (-[WebView _close]):
5004 * WebView/WebViewData.h:
5005 * WebView/WebViewEventHandling.mm: Removed.
5006 * WebView/WebViewInternal.h:
5008 2011-09-19 Anders Carlsson <andersca@apple.com>
5010 Remove -[WebView _selectionChanged] and -[WebView _setTooltip:]
5011 https://bugs.webkit.org/show_bug.cgi?id=68385
5013 Reviewed by Adam Roben.
5015 Move these functions back into the respective clients and remove usesDocumentViews checks.
5017 * WebCoreSupport/WebChromeClient.mm:
5018 (WebChromeClient::setToolTip):
5019 * WebCoreSupport/WebEditorClient.mm:
5020 (WebEditorClient::respondToChangedSelection):
5021 * WebView/WebView.mm:
5022 * WebView/WebViewEventHandling.mm:
5023 * WebView/WebViewInternal.h:
5025 2011-09-19 Anders Carlsson <andersca@apple.com>
5027 Begin removing -[WebView _usesDocumentCalls] from WebView.mm
5028 https://bugs.webkit.org/show_bug.cgi?id=68383
5030 Reviewed by Adam Roben.
5032 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
5033 returns true, since viewless WebKit1 has been abandoned.
5035 * WebView/WebView.mm:
5036 (-[WebView selectedFrame]):
5037 (-[WebView setHostWindow:]):
5038 (-[WebView acceptsFirstResponder]):
5039 (-[WebView becomeFirstResponder]):
5040 (-[WebView _webcore_effectiveFirstResponder]):
5041 (-[WebView setNextKeyView:]):
5042 (-[WebView setHoverFeedbackSuspended:]):
5044 2011-09-19 Anders Carlsson <andersca@apple.com>
5046 Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
5047 https://bugs.webkit.org/show_bug.cgi?id=68379
5049 Reviewed by Adam Roben.
5051 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
5052 returns true, since viewless WebKit1 has been abandoned.
5054 * WebCoreSupport/WebFrameLoaderClient.mm:
5055 (WebFrameLoaderClient::hasHTMLView):
5056 (WebFrameLoaderClient::dispatchDidCommitLoad):
5057 (WebFrameLoaderClient::transitionToCommittedForNewPage):
5058 (WebFrameLoaderClient::createFrame):
5059 * WebView/WebFrame.mm:
5060 (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
5061 (-[WebFrame _hasSelection]):
5062 (-[WebFrame _clearSelection]):
5063 (-[WebFrame _shouldFlattenCompositingLayers:]):
5064 (-[WebFrame _dragSourceEndedAt:operation:]):
5065 (-[WebFrame frameView]):
5067 2011-09-19 Anders Carlsson <andersca@apple.com>
5069 Remove calls to -[WebView _usesDocumentViews]
5070 https://bugs.webkit.org/show_bug.cgi?id=68377
5072 Reviewed by Adam Roben.
5074 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
5075 returns true, since viewless WebKit1 has been abandoned.
5077 * WebCoreSupport/WebChromeClient.mm:
5078 (WebChromeClient::windowResizerRect):
5079 (WebChromeClient::invalidateContentsAndWindow):
5080 (WebChromeClient::screenToWindow):
5081 (WebChromeClient::windowToScreen):
5082 (WebChromeClient::platformPageClient):
5083 (WebChromeClient::scrollRectIntoView):
5084 (WebChromeClient::print):
5085 * WebView/WebDataSource.mm:
5086 (-[WebDataSource _receivedData:]):
5088 2011-09-19 Dan Bernstein <mitz@apple.com>
5090 WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
5091 https://bugs.webkit.org/show_bug.cgi?id=68323
5093 Reviewed by Sam Weinig.
5095 Renamed NonBlockingPanel to WebNonBlockingPanel.
5096 Renamed ThreadEnabler to WebCocoaThreadingEnabler.
5097 Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.
5099 * Misc/WebIconDatabase.mm:
5100 (+[WebCocoaThreadingEnabler enableThreading]):
5101 (importToWebCoreFormat):
5102 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
5103 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
5104 * Panels/WebAuthenticationPanel.h:
5105 * Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to
5106 WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
5107 cause nightly builds to log an error message when showing the Safari
5108 HTTP authentication sheet and disable the Quit command while the sheet
5110 * WebView/WebPDFView.mm:
5111 (-[WebPDFView initWithFrame:]):
5112 (-[WebPDFView _updatePreferencesSoon]):
5114 2011-09-17 Mihai Parparita <mihaip@chromium.org>
5116 FrameLoaderClient BackForwardList-related methods are unsued
5117 https://bugs.webkit.org/show_bug.cgi?id=68293
5119 Reviewed by Darin Adler.
5121 Remove FrameLoaderClient methods that were added by r51629, since only
5122 the old (since-deleted) Android port needed them.
5124 * WebCoreSupport/WebFrameLoaderClient.h:
5125 * WebCoreSupport/WebFrameLoaderClient.mm:
5128 2011-09-16 Simon Fraser <simon.fraser@apple.com>
5130 Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
5131 https://bugs.webkit.org/show_bug.cgi?id=68134
5133 Reviewed by Sam Weinig.
5135 Hook up a private preference that enables the mock scrollbar theme.
5137 * WebView/WebPreferenceKeysPrivate.h:
5138 * WebView/WebPreferences.mm:
5139 (-[WebPreferences mockScrollbarsEnabled]):
5140 (-[WebPreferences setMockScrollbarsEnabled:]):
5141 * WebView/WebPreferencesPrivate.h:
5143 2011-09-15 Adam Barth <abarth@webkit.org>
5145 Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
5146 https://bugs.webkit.org/show_bug.cgi?id=68205
5148 Reviewed by Eric Seidel.
5150 * Storage/WebDatabaseManager.mm:
5151 * Storage/WebDatabaseManagerInternal.h:
5152 * Storage/WebDatabaseManagerPrivate.h:
5153 * Storage/WebDatabaseQuotaManager.mm:
5154 (-[WebDatabaseQuotaManager usage]):
5155 (-[WebDatabaseQuotaManager quota]):
5156 (-[WebDatabaseQuotaManager setQuota:]):
5157 * Storage/WebDatabaseTrackerClient.h:
5158 * Storage/WebDatabaseTrackerClient.mm:
5159 * WebCoreSupport/WebChromeClient.h:
5160 * WebCoreSupport/WebChromeClient.mm:
5161 * WebCoreSupport/WebSecurityOrigin.mm:
5162 (-[WebSecurityOrigin usage]):
5163 (-[WebSecurityOrigin quota]):
5164 (-[WebSecurityOrigin setQuota:]):
5165 * WebView/WebFrame.mm:
5166 (-[WebFrame _cacheabilityDictionary]):
5167 * WebView/WebView.mm:
5168 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
5169 (-[WebView _preferencesChanged:]):
5171 2011-09-15 Mark Hahnenberg <mhahnenberg@apple.com>
5173 Unzip initialization lists and constructors in JSCell hierarchy (7/7)
5174 https://bugs.webkit.org/show_bug.cgi?id=68122
5176 Reviewed by Geoffrey Garen.
5178 Completed the seventh and final level of the refactoring to add finishCreation()
5179 methods to all classes within the JSCell hierarchy with non-trivial
5182 * Plugins/Hosted/ProxyInstance.mm:
5183 (WebKit::ProxyRuntimeMethod::create):
5184 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
5185 * Plugins/Hosted/ProxyRuntimeObject.h:
5186 (WebKit::ProxyRuntimeObject::create):
5187 * Plugins/Hosted/ProxyRuntimeObject.mm:
5188 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
5190 2011-09-15 Kentaro Hara <haraken@google.com>
5192 A single line must not be split into two pages.
5193 https://bugs.webkit.org/show_bug.cgi?id=65005
5195 Reviewed by David Hyatt.
5197 When the document width of a page is overflowed, the last line of the page can be
5198 split into the next page. This is the regression caused by r88737. r88737 tried to
5199 fix rounding errors in rendering calculations by expanding and shrinking a page
5200 using one common method, resizePageRectsKeepingRatio(), but overlooked the case where
5201 a document width gets overflowed.
5203 Test: printing/single-line-must-not-be-split-into-two-pages.html
5205 * WebView/WebHTMLView.mm:
5206 (-[WebHTMLView _web_setPrintingModeRecursive]): Passes an original page size to setPrinting().
5207 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
5208 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
5209 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Ditto.
5210 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Ditto.
5211 (-[WebHTMLView _endPrintMode]): Ditto.
5212 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): Ditto.
5213 (-[WebHTMLView _endScreenPaginationMode]): Ditto.
5214 (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]): Ditto.
5215 (-[WebHTMLView layout]): Ditto.
5216 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): Ditto.
5217 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
5218 (-[WebHTMLView setPageWidthForPrinting:]): Ditto.
5220 2011-09-15 Eric Seidel <eric@webkit.org>
5222 Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
5223 https://bugs.webkit.org/show_bug.cgi?id=68182
5225 Reviewed by Adam Barth.
5227 * Configurations/FeatureDefines.xcconfig:
5229 2011-09-15 Eric Seidel <eric@webkit.org>
5231 Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
5232 https://bugs.webkit.org/show_bug.cgi?id=68022
5234 Reviewed by Ryosuke Niwa.
5236 * Configurations/FeatureDefines.xcconfig:
5238 2011-09-14 Anders Carlsson <andersca@apple.com>
5240 Get rid of WebCoreViewFactory and its WebViewFactory subclass
5241 https://bugs.webkit.org/show_bug.cgi?id=68124
5243 Reviewed by Sam Weinig.
5245 * WebCoreSupport/WebContextMenuClient.mm:
5246 * WebCoreSupport/WebViewFactory.h: Removed.
5247 * WebCoreSupport/WebViewFactory.mm: Removed.
5248 * WebView/WebFrameView.mm:
5249 (-[WebFrameView initWithFrame:]):
5251 2011-09-14 Mark Hahnenberg <mhahnenberg@apple.com>
5253 Unzip initialization lists and constructors in JSCell hierarchy (6/7)
5254 https://bugs.webkit.org/show_bug.cgi?id=67692
5256 Reviewed by Geoffrey Garen.
5258 Completed the sixth level of the refactoring to add finishCreation()
5259 methods to all classes within the JSCell hierarchy with non-trivial
5262 This primarily consists of pushing the calls to finishCreation() down
5263 into the constructors of the subclasses of the fifth level of the hierarchy
5264 as well as pulling the finishCreation() calls out into the class's corresponding
5265 create() method if it has one. Doing both simultaneously allows us to
5266 maintain the invariant that the finishCreation() method chain is called exactly
5267 once during the creation of an object, since calling it any other number of
5268 times (0, 2, or more) will cause an assertion failure.
5270 * Plugins/Hosted/ProxyInstance.mm:
5271 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
5272 (WebKit::ProxyRuntimeMethod::finishCreation):
5274 2011-09-13 Eric Seidel <eric@webkit.org>
5276 Remove ENABLE_SVG_USE as <use> is required by HTML5
5277 https://bugs.webkit.org/show_bug.cgi?id=68019
5279 Reviewed by Ryosuke Niwa.
5281 * Configurations/FeatureDefines.xcconfig:
5283 2011-09-13 Anders Carlsson <andersca@apple.com>
5285 Disable C++ exceptions when building with clang
5286 https://bugs.webkit.org/show_bug.cgi?id=68031
5287 <rdar://problem/9556880>
5289 Reviewed by Mark Rowe.
5291 * Configurations/Base.xcconfig:
5293 2011-09-13 Eric Seidel <eric@webkit.org>
5295 Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
5296 https://bugs.webkit.org/show_bug.cgi?id=68018
5298 Reviewed by Ryosuke Niwa.
5300 * Configurations/FeatureDefines.xcconfig:
5302 2011-09-09 Oliver Hunt <oliver@apple.com>
5304 Remove support for anonymous storage from jsobjects
5305 https://bugs.webkit.org/show_bug.cgi?id=67881
5307 Reviewed by Sam Weinig.
5309 Remove the use of AnonymousSlotCount
5311 * Plugins/Hosted/ProxyInstance.mm:
5312 (WebKit::ProxyRuntimeMethod::createStructure):
5313 * Plugins/Hosted/ProxyRuntimeObject.h:
5314 (WebKit::ProxyRuntimeObject::createStructure):
5316 2011-09-09 Chris Marrin <cmarrin@apple.com>
5318 requestAnimationFrame doesn't throttle on Mac
5319 https://bugs.webkit.org/show_bug.cgi?id=67171
5321 Reviewed by Simon Fraser.
5323 Removed runLoopObserver for requestAnimationFrame. It's now
5324 done by a Timer in ScriptedAnimationController in WebCore.
5326 * WebCoreSupport/WebChromeClient.h:
5327 * WebCoreSupport/WebChromeClient.mm:
5328 * WebView/WebView.mm:
5329 (-[WebView _close]):
5330 * WebView/WebViewData.h:
5331 * WebView/WebViewInternal.h:
5333 2011-09-09 Fady Samuel <fsamuel@chromium.org>
5335 Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp}
5336 https://bugs.webkit.org/show_bug.cgi?id=67250
5338 Reviewed by Simon Fraser.
5340 * WebView/WebView.mm:
5341 (-[WebView _scaleWebView:atOrigin:]):
5342 (-[WebView _viewScaleFactor]):
5344 2011-09-09 Mark Hahnenberg <mhahnenberg@apple.com>
5346 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
5347 https://bugs.webkit.org/show_bug.cgi?id=67420
5349 Reviewed by Geoffrey Garen.
5351 Completed the fifth level of the refactoring to add finishCreation()
5352 methods to all classes within the JSCell hierarchy with non-trivial
5355 This primarily consists of pushing the calls to finishCreation() down
5356 into the constructors of the subclasses of the second level of the hierarchy
5357 as well as pulling the finishCreation() calls out into the class's corresponding
5358 create() method if it has one. Doing both simultaneously allows us to
5359 maintain the invariant that the finishCreation() method chain is called exactly
5360 once during the creation of an object, since calling it any other number of
5361 times (0, 2, or more) will cause an assertion failure.
5363 * Plugins/Hosted/ProxyRuntimeObject.h:
5364 * Plugins/Hosted/ProxyRuntimeObject.mm:
5365 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
5366 (WebKit::ProxyRuntimeObject::finishCreation):
5368 2011-09-08 Sam Weinig <sam@webkit.org>
5370 Remove the Completion object from JSC, I have never liked it
5371 https://bugs.webkit.org/show_bug.cgi?id=67755
5373 Reviewed by Gavin Barraclough.
5375 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5376 (WebKit::NetscapePluginInstanceProxy::evaluate):
5378 2011-09-07 Sheriff Bot <webkit.review.bot@gmail.com>
5380 Unreviewed, rolling out r94627 and r94632.
5381 http://trac.webkit.org/changeset/94627
5382 http://trac.webkit.org/changeset/94632
5383 https://bugs.webkit.org/show_bug.cgi?id=67698
5385 It broke tests on GTK and Qt (Requested by Ossy on #webkit).
5387 * Plugins/Hosted/ProxyRuntimeObject.h:
5388 * Plugins/Hosted/ProxyRuntimeObject.mm:
5389 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
5391 2011-09-06 Mark Hahnenberg <mhahnenberg@apple.com>
5393 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
5394 https://bugs.webkit.org/show_bug.cgi?id=67420
5396 Reviewed by Geoffrey Garen.
5398 Completed the fifth level of the refactoring to add finishCreation()
5399 methods to all classes within the JSCell hierarchy with non-trivial
5402 This primarily consists of pushing the calls to finishCreation() down
5403 into the constructors of the subclasses of the second level of the hierarchy
5404 as well as pulling the finishCreation() calls out into the class's corresponding
5405 create() method if it has one. Doing both simultaneously allows us to
5406 maintain the invariant that the finishCreation() method chain is called exactly
5407 once during the creation of an object, since calling it any other number of
5408 times (0, 2, or more) will cause an assertion failure.
5410 * Plugins/Hosted/ProxyRuntimeObject.h:
5411 * Plugins/Hosted/ProxyRuntimeObject.mm:
5412 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
5413 (WebKit::ProxyRuntimeObject::finishCreation):
5415 2011-09-06 Ryosuke Niwa <rniwa@webkit.org>
5417 Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
5418 https://bugs.webkit.org/show_bug.cgi?id=67569
5420 Reviewed by Antonio Gomes.
5422 * WebView/WebHTMLView.mm:
5423 (-[WebHTMLView _updateSelectionForInputManager]):
5425 2011-09-05 Oliver Hunt <oliver@apple.com>
5427 An object's structure should reference the global object responsible for its creation
5428 https://bugs.webkit.org/show_bug.cgi?id=67624
5430 Reviewed by Gavin Barraclough.
5432 Update for new Structure::create() globalObject parameter.
5434 * Plugins/Hosted/ProxyInstance.mm:
5435 (WebKit::ProxyRuntimeMethod::createStructure):
5436 * Plugins/Hosted/ProxyRuntimeObject.h:
5437 (WebKit::ProxyRuntimeObject::createStructure):
5439 2011-09-01 Mark Rowe <mrowe@apple.com>
5441 Fix the build by adding some more missing return types.
5443 * WebView/WebDashboardRegion.h:
5444 * WebView/WebDashboardRegion.mm:
5445 (-[WebDashboardRegion initWithRect:clip:type:]):
5447 2011-09-01 Tim Horton <timothy_horton@apple.com>
5449 REGRESSION: Rendering artifacts on a rotated, pattern filled shape
5450 https://bugs.webkit.org/show_bug.cgi?id=53055
5451 <rdar://problem/8910917>
5453 Reviewed by Simon Fraser.
5455 Introduce wkCGPatternCreateWithImageAndTransform.
5457 * WebCoreSupport/WebSystemInterface.mm:
5458 (InitWebCoreSystemInterface):
5460 2011-08-31 Beth Dakin <bdakin@apple.com>
5462 https://bugs.webkit.org/show_bug.cgi?id=67322
5463 Re-name overrideBackingScaleFactor
5465 Reviewed by John Sullivan.
5467 _setOverrideBackingScaleFactor is now _setCustomBackingScaleFactor
5468 * WebView/WebView.mm:
5469 (-[WebView _setCustomBackingScaleFactor:]):
5470 (-[WebView _deviceScaleFactor]):
5471 * WebView/WebViewData.h:
5472 * WebView/WebViewPrivate.h:
5474 2011-08-30 Dan Bernstein <mitz@apple.com>
5476 <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
5477 https://bugs.webkit.org/show_bug.cgi?id=67230
5479 Reviewed by Darin Adler.
5481 * WebView/WebHTMLView.mm:
5482 * WebView/WebView.mm:
5483 (coreOptions): Moved this function from WebHTMLView.mm to here and made
5484 it accessible from both this file and WebHTMLView.mm.
5485 (-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API.
5486 * WebView/WebViewInternal.h:
5487 * WebView/WebViewPrivate.h:
5489 2011-08-30 Beth Dakin <bdakin@apple.com>
5491 https://bugs.webkit.org/show_bug.cgi?id=67150
5492 Would like API to use a custom device scale factor for a particular WebView/WKView
5494 <rdar://problem/10041016>
5496 Reviewed by Darin Adler.
5498 New API is _setOverrideBackingScaleFactor:(CGFloat)
5499 * WebView/WebView.mm:
5500 (-[WebView _setOverrideBackingScaleFactor:]):
5501 (-[WebView _deviceScaleFactor]):
5502 * WebView/WebViewData.h:
5503 * WebView/WebViewPrivate.h:
5505 2011-08-30 Aaron Colwell <acolwell@chromium.org>
5507 Add MediaSource API to HTMLMediaElement
5508 https://bugs.webkit.org/show_bug.cgi?id=64731
5510 Reviewed by Eric Carlson.
5512 * Configurations/FeatureDefines.xcconfig:
5514 2011-08-29 Alexey Proskuryakov <ap@apple.com>
5516 DumpRenderTree should begin each test with an empty cookie store
5517 https://bugs.webkit.org/show_bug.cgi?id=63545
5518 <rdar://problem/5666907>
5520 Reviewed by Darin Adler.
5522 * WebView/WebPreferences.mm:
5523 (+[WebPreferences initialize]):
5524 (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
5525 (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
5526 * WebView/WebPreferencesPrivate.h:
5527 Exposed an SPI to use a private default session. It's separate from private browsing,
5528 because some tests enable the latter, and we don't want to mix them up.
5529 Also exposed an SPI to set cookie accept policy regardless of what session we are currently
5532 * WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): Updated to use currentStorageSession()
5533 instead of privateBrowsingStorageSession().
5535 2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
5537 The unused ScrollView* argument can and should be removed from
5539 https://bugs.webkit.org/show_bug.cgi?id=67117
5541 Reviewed by Darin Adler.
5543 * WebCoreSupport/WebChromeClient.h:
5544 * WebCoreSupport/WebChromeClient.mm:
5545 (WebChromeClient::scrollRectIntoView):
5547 2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
5549 Unreviewed, rolling out r93987, r93992, r93995, r93998, and
5551 http://trac.webkit.org/changeset/93987
5552 http://trac.webkit.org/changeset/93992
5553 http://trac.webkit.org/changeset/93995
5554 http://trac.webkit.org/changeset/93998
5555 http://trac.webkit.org/changeset/93999
5556 https://bugs.webkit.org/show_bug.cgi?id=67147
5558 Many failing tests (Requested by ap on #webkit).
5560 * WebView/WebPreferences.mm:
5561 (+[WebPreferences initialize]):
5562 * WebView/WebPreferencesPrivate.h:
5564 2011-08-26 Alexey Proskuryakov <ap@apple.com>
5566 DumpRenderTree should begin each test with an empty cookie store
5567 https://bugs.webkit.org/show_bug.cgi?id=63545
5568 <rdar://problem/5666907>
5570 Reviewed by Darin Adler.
5572 * WebView/WebPreferences.mm:
5573 (+[WebPreferences initialize]):
5574 (+[WebPreferences _usePrivateSessionForNetworkLoading]):
5575 * WebView/WebPreferencesPrivate.h:
5576 Exposed an SPI to use a private default session. It's separate from private browsing,
5577 because some tests enable the latter, and we don't want to mix them up.
5579 2011-08-23 Chris Marrin <cmarrin@apple.com>
5581 [mac] requestAnimationFrame support for mac port
5582 https://bugs.webkit.org/show_bug.cgi?id=59146
5584 Reviewed by Simon Fraser.
5586 Implement requestAnimationFrame for WebKit. Add a
5587 CFRunLoopObserver to WebView, which runs just before
5588 the syncCompositingState RLO and calls into the
5589 ScriptedAnimationController if scheduleAnimation() has
5592 * Configurations/FeatureDefines.xcconfig:
5593 * WebCoreSupport/WebChromeClient.h:
5594 * WebCoreSupport/WebChromeClient.mm:
5595 (WebChromeClient::scheduleAnimation):
5596 * WebView/WebView.mm:
5597 (-[WebView _close]):
5598 (-[WebView _unscheduleAnimation]):
5599 (-[WebView _scheduleCompositingLayerSync]):
5600 (requestAnimationFrameRunLoopObserverCallback):
5601 (-[WebView _scheduleAnimation]):
5602 * WebView/WebViewData.h:
5603 * WebView/WebViewInternal.h:
5605 2011-08-24 Alexey Proskuryakov <ap@apple.com>
5607 Plug-in tests are flaky on Mac
5608 https://bugs.webkit.org/show_bug.cgi?id=66822
5610 Reviewed by Anders Carlsson.
5612 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5613 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
5614 Protect objects that can be removed by a script.
5616 * WebView/WebFrame.mm:
5617 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
5618 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto.
5619 Also fixed some nonsense code.
5621 2011-08-23 Mark Hahnenberg <mhahnenberg@apple.com>
5623 Add checks to ensure allocation does not take place during initialization of GC-managed objects
5624 https://bugs.webkit.org/show_bug.cgi?id=65288
5626 Reviewed by Darin Adler.
5628 Adding the new validation functionality. In its current state, it will performs checks,
5629 but they don't fail unless you do allocation in the arguments to the parent constructor in the
5630 initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
5631 allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
5632 allowed in constructor bodies while other refactoring efforts continue.
5634 * Plugins/Hosted/ProxyRuntimeObject.h:
5635 (WebKit::ProxyRuntimeObject::create):
5636 * Plugins/Hosted/ProxyRuntimeObject.mm:
5637 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
5639 2011-08-18 Beth Dakin <bdakin@apple.com>
5641 Reviewed by Sam Weinig.
5643 https://bugs.webkit.org/show_bug.cgi?id=66495
5644 Lion-specific scroller SPIs can use forward declaration instead of
5645 WebKitSystemInterface
5647 * WebCoreSupport/WebSystemInterface.mm:
5648 (InitWebCoreSystemInterface):
5650 2011-08-18 Anders Carlsson <andersca@apple.com>
5652 More C++0x libc++ build fixes
5653 https://bugs.webkit.org/show_bug.cgi?id=66476
5655 Reviewed by Adam Roben.
5657 * Plugins/Hosted/NetscapePluginHostProxy.mm:
5659 Use a WTF String here instead of an STL string.
5661 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5662 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
5663 std::make_pair now takes rvalue references, so get rid of the template arguments and let
5664 the compiler deduce them instead.
5666 2011-08-18 Adam Roben <aroben@apple.com>
5668 Update the device scale factor when the WebView's window changes
5670 Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
5671 WebView is moved between windows with different backing scale factors
5673 Reviewed by Anders Carlsson.
5675 * WebView/WebView.mm:
5676 (-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
5677 window at all) might have a different backing scale factor than the previous one.
5678 (-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.
5680 2011-08-17 Adam Roben <aroben@apple.com>
5682 Make WebCore keep track of the current device scale factor
5684 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
5687 Reviewed by Darin Adler.
5689 * WebCoreSupport/WebChromeClient.h:
5690 * WebCoreSupport/WebChromeClient.mm:
5691 Moved code to calculate the device scale factor from here...
5693 * WebView/WebView.mm:
5694 (-[WebView _deviceScaleFactor]):
5697 (-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.
5699 2011-08-17 Dan Bernstein <mitz@apple.com>
5701 Removed some code that is not needed when building for Leopard or later.
5703 Reviewed by Anders Carlsson.
5705 * WebCoreSupport/WebContextMenuClient.mm:
5706 (fixMenusToSendToOldClients): Removed check for Tiger Mail.
5707 * WebCoreSupport/WebFrameLoaderClient.mm:
5708 (WebFrameLoaderClient::objectContentType):
5709 * WebView/WebView.mm:
5710 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
5711 (-[WebView _preferencesChanged:]):
5713 2011-08-17 Dan Bernstein <mitz@apple.com>
5715 Eliminate the WebCGFloat compatibility definition that was needed for Tiger.
5717 Rubber-stamped by Anders Carlsson.
5719 * WebView/WebHTMLViewPrivate.h:
5721 2011-08-17 Dan Bernstein <mitz@apple.com>
5723 Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
5726 Reviewed by Darin Adler.
5728 * History/WebBackForwardList.h:
5729 * WebView/WebDocumentInternal.h:
5730 * WebView/WebHTMLRepresentation.h:
5731 * WebView/WebPreferences.h:
5732 * WebView/WebResourceLoadDelegate.h:
5733 * WebView/WebResourceLoadDelegatePrivate.h:
5734 * WebView/WebScriptDebugDelegate.h:
5735 * WebView/WebTextIterator.h:
5736 * WebView/WebUIDelegate.h:
5737 * WebView/WebView.h:
5738 * WebView/WebViewPrivate.h:
5740 2011-08-15 Dmitry Titov <dimich@chromium.org>
5742 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
5743 https://bugs.webkit.org/show_bug.cgi?id=66165
5745 Reviewed by Darin Fisher.
5747 * WebCoreSupport/WebFrameLoaderClient.h:
5748 * WebCoreSupport/WebFrameLoaderClient.mm:
5749 (WebFrameLoaderClient::transferLoadingResourceFromPage):
5751 2011-08-15 Mark Hahnenberg <mhahnenberg@apple.com>
5753 Refactor JS objects to allocate in static create methods rather than constructors
5754 https://bugs.webkit.org/show_bug.cgi?id=65347
5756 Reviewed by Geoffrey Garen.
5758 Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
5759 larger refactoring to get rid of all allocation during initialization.
5761 * Plugins/Hosted/ProxyInstance.mm:
5762 (WebKit::ProxyRuntimeMethod::create):
5763 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
5765 2011-08-15 Adam Roben <aroben@apple.com>
5767 Update pages' style and content scale when the window's backing scale factor changes
5769 Unfortunately, I couldn't think of a way to test this in an automated fashion.
5771 Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
5772 scale factor changes
5774 Reviewed by Simon Fraser.
5776 * WebView/WebView.mm:
5777 (-[WebView addWindowObserversForWindow:]):
5778 (-[WebView removeWindowObservers]):
5779 Listen for the notification that tells us the window's backing scale has changed.
5781 (-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale
5782 factor so that, e.g., scale-factor-dependent media queries will be reevaluated.
5784 2011-08-10 Adam Roben <aroben@apple.com>
5786 Clear up scale factor terminology
5788 WebKit by and large deals with two scale factors: one intrinsic to the device on which the
5789 software is running, and one that is per-Page and can be controlled via API calls. This
5790 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
5791 code use those names. It should introduce no behavior changes.
5793 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
5796 Reviewed by Simon Fraser.
5798 * Misc/WebNSControlExtras.m:
5799 (-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
5800 AppKit scale factor terminology. (This is unrelated to the rest of the patch.)
5802 * WebCoreSupport/WebChromeClient.h:
5803 * WebCoreSupport/WebChromeClient.mm:
5805 2011-08-13 Dan Bernstein <mitz@apple.com>
5807 Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
5809 Reviewed by Joseph Pecoraro.
5811 * WebView/WebPreferenceKeysPrivate.h:
5813 2011-08-13 Sam Weinig <sam@webkit.org>
5815 Remove unused variables from WebView/WebFullScreenController.h
5816 https://bugs.webkit.org/show_bug.cgi?id=66194
5818 Reviewed by Dan Bernstein.
5820 * WebView/WebFullScreenController.h:
5821 Remove a few variables which were not used.
5823 2011-08-12 Dan Bernstein <mitz@apple.com>
5825 Add an option to automatically show tooltips (with the full text) over truncated text
5826 https://bugs.webkit.org/show_bug.cgi?id=66178
5828 Reviewed by Simon Fraser.
5830 * WebView/WebPreferenceKeysPrivate.h: Defined a preference key.
5831 * WebView/WebPreferences.mm:
5832 (+[WebPreferences initialize]): Added a default value of NO for the
5833 ShowsToolTipOverTruncatedText preference.
5834 (-[WebPreferences showsToolTipOverTruncatedText]): Added this getter.
5835 (-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter.
5836 * WebView/WebPreferencesPrivate.h:
5837 * WebView/WebView.mm:
5838 (-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText().
5840 2011-08-12 Sam Weinig <sam@webkit.org>
5842 Use __builtin_trap() for CRASH when building with clang
5843 https://bugs.webkit.org/show_bug.cgi?id=66152
5845 Reviewed by Anders Carlsson.
5847 * Plugins/WebBaseNetscapePluginView.mm:
5848 (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
5849 (-[WebBaseNetscapePluginView handleMouseMoved:]):
5850 (-[WebBaseNetscapePluginView handleMouseEntered:]):
5851 (-[WebBaseNetscapePluginView handleMouseExited:]):
5852 (-[WebBaseNetscapePluginView focusChanged]):
5853 (-[WebBaseNetscapePluginView windowFocusChanged:]):
5854 (-[WebBaseNetscapePluginView createPlugin]):
5855 (-[WebBaseNetscapePluginView loadStream]):
5856 (-[WebBaseNetscapePluginView shouldStop]):
5857 (-[WebBaseNetscapePluginView destroyPlugin]):
5858 (-[WebBaseNetscapePluginView updateAndSetWindow]):
5859 (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
5860 (-[WebBaseNetscapePluginView pluginLayer]):
5861 (-[WebBaseNetscapePluginView getFormValue:]):
5862 Remove the ASSERT_NOT_REACHED from the base class methods. They were not
5863 adding much value and were getting in the way of making the static analyzer
5864 work. A better way to do this would be to use a formal protocol.
5866 2011-08-12 Mark Rowe <mrowe@apple.com>
5868 Be more forward-looking in the choice of compiler.
5870 Rubber-stamped by Jon Honeycutt.
5872 * Configurations/CompilerVersion.xcconfig:
5874 2011-08-10 David Hyatt <hyatt@apple.com>
5876 https://bugs.webkit.org/show_bug.cgi?id=66004
5878 Removing the CSS Regions and Exclusions ifdefs.
5880 Reviewed by Adam Roben.
5882 * Configurations/FeatureDefines.xcconfig:
5884 2011-08-09 Mark Hahnenberg <mhahnenberg@apple.com>
5886 Add ParentClass typedef in all JSC classes
5887 https://bugs.webkit.org/show_bug.cgi?id=65731
5889 Reviewed by Oliver Hunt.
5891 Just added the Base typedefs in all the classes that are a subclass of JSCell
5892 to point at their parent classes. This is a change to support future changes to the way
5893 constructors and destructors are implemented in JS objects, among other things.
5895 * Plugins/Hosted/ProxyInstance.mm:
5896 * Plugins/Hosted/ProxyRuntimeObject.h:
5898 2011-08-08 Chris Marrin <cmarrin@apple.com>
5900 Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState
5901 https://bugs.webkit.org/show_bug.cgi?id=65708
5903 Supply initial display rects for the full-screen case
5905 Reviewed by Simon Fraser.
5907 * WebView/WebFullScreenController.mm:
5908 (-[WebFullScreenController enterFullscreen:]):
5909 (-[WebFullScreenController exitFullscreen]):
5911 2011-08-06 Joseph Pecoraro <joepeck@webkit.org>
5913 Potential Leaks - RetainPtr<> over retaining Create'd objects
5914 https://bugs.webkit.org/show_bug.cgi?id=65806
5916 Reviewed by Darin Adler.
5918 Fix a possible leak by adopting an allocation instead of retaining it.
5920 * WebView/WebView.mm:
5921 (-[WebView previousValidKeyView]):
5923 2011-08-05 Anders Carlsson <andersca@apple.com>
5926 https://bugs.webkit.org/show_bug.cgi?id=65729
5928 Reviewed by Darin Adler.
5930 Remove plug-in halter and associated classes.
5932 * Plugins/WebBaseNetscapePluginView.h:
5933 * Plugins/WebBaseNetscapePluginView.mm:
5934 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
5935 (-[WebBaseNetscapePluginView start]):
5936 (-[WebBaseNetscapePluginView stop]):
5937 * WebCoreSupport/WebPluginHalterClient.h: Removed.
5938 * WebCoreSupport/WebPluginHalterClient.mm: Removed.
5939 * WebView/WebPreferenceKeysPrivate.h:
5940 * WebView/WebPreferences.mm:
5941 (+[WebPreferences initialize]):
5942 * WebView/WebPreferencesPrivate.h:
5943 * WebView/WebView.mm:
5944 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
5945 (-[WebView _preferencesChanged:]):
5946 * WebView/WebViewPrivate.h:
5948 2011-08-04 Mark Rowe <mrowe@apple.com>
5950 Future-proof Xcode configuration settings.
5952 * Configurations/Base.xcconfig:
5953 * Configurations/DebugRelease.xcconfig:
5954 * Configurations/Version.xcconfig:
5955 * Configurations/WebKit.xcconfig:
5957 2011-08-03 Kent Tamura <tkent@chromium.org>
5959 Fix incorrect checks for HTMLMediaElement
5960 https://bugs.webkit.org/show_bug.cgi?id=65590
5962 Reviewed by Dimitri Glazkov.
5964 <video> and <audio> can be an HTMLElement instance instead of
5965 HTMLMediaElement if MediaPlayer::isAvailable() returns false or
5966 the media feature is disabled at runtime.
5968 * WebView/WebFullScreenController.mm:
5969 (-[WebFullScreenController _isAnyMoviePlaying]):
5971 2011-08-03 Mark Rowe <mrowe@apple.com>
5973 Bring some order to FeatureDefines.xcconfig to make it easier to follow.
5975 Reviewed by Sam Weinig.
5977 * Configurations/FeatureDefines.xcconfig:
5979 2011-08-03 Mark Rowe <mrowe@apple.com>
5981 Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
5983 Reviewed by Dave Kilzer.
5985 * Configurations/FeatureDefines.xcconfig:
5987 2011-08-03 Joseph Pecoraro <joepeck@webkit.org>
5989 Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
5990 https://bugs.webkit.org/show_bug.cgi?id=65582
5992 Reviewed by Pavel Feldman.
5994 * WebCoreSupport/WebInspectorClient.h:
5995 * WebCoreSupport/WebInspectorClient.mm:
5997 2011-08-03 Pavel Feldman <pfeldman@google.com>
5999 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
6000 https://bugs.webkit.org/show_bug.cgi?id=65510
6002 Reviewed by Yury Semikhatsky.
6004 * WebInspector/WebNodeHighlightView.mm:
6005 (-[WebNodeHighlightView drawRect:]):
6007 2011-08-03 Pavel Feldman <pfeldman@chromium.org>
6009 Web Inspector: remove Node parameter from the InspectorClient::highlight
6010 https://bugs.webkit.org/show_bug.cgi?id=65549
6012 Reviewed by Yury Semikhatsky.
6014 * WebCoreSupport/WebInspectorClient.h:
6015 * WebCoreSupport/WebInspectorClient.mm:
6016 (WebInspectorClient::highlight):
6017 * WebInspector/WebNodeHighlighter.h:
6018 * WebInspector/WebNodeHighlighter.mm:
6019 (-[WebNodeHighlighter highlight]):
6021 2011-07-30 Patrick Gansterer <paroga@webkit.org>
6023 Remove inclusion of MainThread.h from Threading.h
6024 https://bugs.webkit.org/show_bug.cgi?id=65081
6026 Reviewed by Darin Adler.
6028 Add missing include statements for MainThread.
6030 * Carbon/CarbonWindowAdapter.mm:
6031 * History/WebBackForwardList.mm:
6032 * History/WebHistoryItem.mm:
6033 * Misc/WebElementDictionary.mm:
6034 * Misc/WebIconDatabase.mm:
6035 * Misc/WebLocalizableStrings.mm:
6036 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
6037 * Plugins/WebBaseNetscapePluginView.mm:
6038 * Plugins/WebBasePluginPackage.mm:
6039 * Plugins/WebNetscapePluginView.mm:
6040 * WebCoreSupport/WebEditorClient.mm:
6041 * WebCoreSupport/WebFrameLoaderClient.mm:
6042 * WebView/WebArchive.mm:
6043 * WebView/WebDataSource.mm:
6044 * WebView/WebHTMLView.mm:
6045 * WebView/WebResource.mm:
6046 * WebView/WebTextIterator.mm:
6047 * WebView/WebView.mm:
6048 * WebView/WebViewData.mm:
6050 2011-07-28 Dan Bernstein <mitz@apple.com>
6052 <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds
6054 Reviewed by Darin Adler.
6056 * WebCoreSupport/WebSystemInterface.mm:
6057 (InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters.
6059 2011-07-28 Brady Eidson <beidson@apple.com>
6061 <rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306
6062 WebKitInitializeStorageIfNecessary() can take awhile performing i/o, isn't necessary for every WebView
6064 Reviewed by Maciej Stachowiak.
6066 * Storage/WebStorageManager.mm:
6067 (WebKitInitializeStorageIfNecessary): Pass the client along in initializeTracker().
6069 2011-07-27 Mark Hahnenberg <mhahnenberg@apple.com>
6071 Remove operator new from JSCell
6072 https://bugs.webkit.org/show_bug.cgi?id=64999
6074 Reviewed by Oliver Hunt.
6076 Removed the implementation of operator new in JSCell, so any further uses
6077 will not successfully link. Also removed any remaining uses of operator new.
6079 * Plugins/Hosted/ProxyInstance.mm:
6080 (WebKit::ProxyInstance::newRuntimeObject):
6081 (WebKit::ProxyRuntimeMethod::create):
6082 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
6083 (WebKit::ProxyInstance::getMethod):
6084 * Plugins/Hosted/ProxyRuntimeObject.h:
6085 (WebKit::ProxyRuntimeObject::create):
6086 * WebView/WebScriptDebugDelegate.mm:
6087 (-[WebScriptCallFrame scopeChain]):
6089 2011-07-26 Dan Bernstein <mitz@apple.com>
6091 <rdar://problem/9842889> Add a generic pictograph font family
6092 https://bugs.webkit.org/show_bug.cgi?id=65197
6094 Reviewed by Anders Carlsson.
6096 * WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
6097 * WebView/WebPreferences.mm:
6098 (+[WebPreferences initialize]): Set the default pictograph font family to
6099 "Apple Color Emoji".
6100 (-[WebPreferences pictographFontFamily]): Added this getter.
6101 (-[WebPreferences setPictographFontFamily:]): Added this setter.
6102 * WebView/WebPreferencesPrivate.h:
6103 * WebView/WebView.mm:
6104 (-[WebView _preferencesChanged:]): Pass the preference through to WebCore.
6106 2011-07-25 Ian Henderson <ianh@apple.com>
6108 WebFrame should have a method to determine its visual emptiness
6109 https://bugs.webkit.org/show_bug.cgi?id=64223
6111 Reviewed by Dan Bernstein.
6113 * WebView/WebFrame.mm:
6114 (-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
6116 * WebView/WebFramePrivate.h:
6118 2011-07-19 Leo Yang <leoyang.webkit@gmail.com>
6120 SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
6121 https://bugs.webkit.org/show_bug.cgi?id=60850
6123 Reviewed by Nikolas Zimmermann.
6125 SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions.
6126 This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef>
6127 elements for alternative glyph features.
6129 * MigrateHeaders.make:
6131 2011-07-18 Andy Estes <aestes@apple.com>
6133 Solar Walk app-specific hack accidentally strips stylesheets from the document.
6134 https://bugs.webkit.org/show_bug.cgi?id=64777
6136 Reviewed by Adam Barth.
6138 Solar Walk uses a self-closed title tag in its documents ("<title />").
6139 The HTML5 parser does not recognize this as a valid self-closing tag,
6140 so it treats the remainder of the document as title text.
6142 We work around this in WebKit by injecting a script that calls
6143 document.write() on the contents of document.title, thereby restoring
6144 the contents of the document. Unfortunately this overwrote several
6145 <style> tags that existed before the <title>, thereby causing the
6146 document to not have the intended styling.
6148 Fix this by having the injected script concatenate document.title to
6149 the document instead of overwriting it during document.write(). We can
6150 also take the opportunity to remove document.title since it does not
6151 contain useful information.
6153 * Misc/SolarWalkQuirksUserScript.js:
6155 2011-07-18 Dean Jackson <dino@apple.com>
6157 https://bugs.webkit.org/show_bug.cgi?id=64742
6158 Expose WebPreferences for media playback requiring user gestures and inline playback
6160 Reviewed by Simon Fraser.
6162 Two new WebPreferences: MediaPlaybackRequiresUserGesture and
6163 MediaPlaybackAllowsInline.
6165 * WebView/WebPreferenceKeysPrivate.h:
6166 * WebView/WebPreferences.mm:
6167 (+[WebPreferences initialize]):
6168 (-[WebPreferences mediaPlaybackRequiresUserGesture]):
6169 (-[WebPreferences setMediaPlaybackRequiresUserGesture:]):
6170 (-[WebPreferences mediaPlaybackAllowsInline]):
6171 (-[WebPreferences setMediaPlaybackAllowsInline:]):
6172 * WebView/WebPreferencesPrivate.h:
6173 * WebView/WebView.mm:
6174 (-[WebView _preferencesChanged:]):
6176 2011-07-18 Pratik Solanki <psolanki@apple.com>
6178 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
6179 Get webkit to compile with USE(CFNETWORK) enabled on Mac
6181 Reviewed by David Kilzer.
6183 Create an NSURLDownload from the CF objects that we have.
6185 * Misc/WebDownload.mm:
6186 (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
6187 * Misc/WebDownloadInternal.h:
6188 * WebCoreSupport/WebFrameLoaderClient.mm:
6189 (WebFrameLoaderClient::download):
6191 2011-07-15 Pratik Solanki <psolanki@apple.com>
6193 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
6194 Get webkit to compile with USE(CFNETWORK) enabled on Mac
6196 Reviewed by David Kilzer.
6198 New WebKitSystemInterface functions for CFNetwork-based loader.
6200 * WebCoreSupport/WebSystemInterface.mm:
6201 (InitWebCoreSystemInterface):
6203 2011-07-15 Tim Horton <timothy_horton@apple.com>
6205 Overlay scrollbars in overflow areas no longer pulse when revealed
6206 https://bugs.webkit.org/show_bug.cgi?id=64606
6207 <rdar://problem/9390674>
6209 Reviewed by Simon Fraser.
6211 Ensure that the state of the scrollbar implementation is kept in sync
6212 with WebCore's internal representation. Previously, we synchronized them
6213 at paint time, causing pulsing to be skipped due to the scrollbars being
6216 * WebCoreSupport/WebSystemInterface.mm:
6217 (InitWebCoreSystemInterface):
6219 2011-07-15 Andy Estes <aestes@apple.com>
6221 Rename applicationIsSolarWalk() to applicationIsSolarWalkMac().
6222 https://bugs.webkit.org/show_bug.cgi?id=64641
6224 Reviewed by Brian Weinstein.
6226 * WebView/WebView.mm:
6227 (needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac().
6229 2011-07-15 Dan Bernstein <mitz@apple.com>
6231 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
6232 https://bugs.webkit.org/show_bug.cgi?id=64615
6234 Reviewed by Anders Carlsson.
6236 * WebCoreSupport/WebChromeClient.h:
6237 * WebCoreSupport/WebChromeClient.mm:
6238 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
6239 +[NSCursor setHiddenUntilMouseMoves:].
6241 2011-07-14 Gavin Barraclough <barraclough@apple.com>
6243 https://bugs.webkit.org/show_bug.cgi?id=64250
6244 Global strict mode function leaking global object as "this".
6246 Reviewed by Oliver Hunt.
6248 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
6249 (WebKit::NetscapePluginInstanceProxy::invoke):
6250 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
6251 - Change call to pass DOM Window shell, instead of the global varaible object.
6253 2011-07-13 Joseph Pecoraro <joepeck@webkit.org>
6255 Improve names of some ApplicationCacheStorage accessor methods
6256 https://bugs.webkit.org/show_bug.cgi?id=64433
6258 Reviewed by Alexey Proskuryakov.
6260 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
6261 (-[WebApplicationCacheQuotaManager usage]):
6262 (-[WebApplicationCacheQuotaManager quota]):
6265 2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
6267 ApplicationCache update should not immediately fail when reaching per-origin quota
6268 https://bugs.webkit.org/show_bug.cgi?id=64177
6270 Reviewed by Alexey Proskuryakov.
6272 * WebView/WebUIDelegatePrivate.h:
6273 * DefaultDelegates/WebDefaultUIDelegate.m:
6274 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
6275 Update the delegate to include a space needed parameter.
6277 * WebCoreSupport/WebChromeClient.h:
6278 * WebCoreSupport/WebChromeClient.mm:
6279 (WebChromeClient::reachedApplicationCacheOriginQuota):
6280 Call the delegate with the new space needed information.
6282 2011-07-12 Adam Roben <aroben@apple.com>
6284 Delete some redundant code in WebHTMLView
6286 This code had no user-visible effect, as we were just duplicating work that AppKit would do
6287 for us at a slightly different time.
6289 Fixes <http://webkit.org/b/64390> WebHTMLView sets its root layer's transform unnecessarily
6291 Reviewed by Simon Fraser.
6293 * WebView/WebHTMLView.mm:
6294 (-[WebHTMLView viewDidMoveToWindow]):
6295 (-[WebHTMLView attachRootLayer:]):
6296 Don't bother setting the root layer's transform to account for the scale factor. AppKit
6297 takes care of this for us nowadays.
6299 2011-07-10 Kenichi Ishibashi <bashi@chromium.org>
6301 Let plugins participate in form submission
6302 https://bugs.webkit.org/show_bug.cgi?id=13061
6304 Adds methods to get form value from NPAPI plugins.
6306 Reviewed by Anders Carlsson.
6308 * Plugins/Hosted/WebHostedNetscapePluginView.h:
6309 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
6310 (-[WebHostedNetscapePluginView getFormValue:]): Added.
6311 * Plugins/WebBaseNetscapePluginView.h:
6312 * Plugins/WebBaseNetscapePluginView.mm:
6313 (-[WebBaseNetscapePluginView getFormValue:]): Added.
6314 * Plugins/WebNetscapePluginPackage.h:
6315 * Plugins/WebNetscapePluginPackage.mm:
6316 (-[WebNetscapePluginPackage browserFuncs]): Added.
6317 * Plugins/WebNetscapePluginView.h:
6318 * Plugins/WebNetscapePluginView.mm:
6319 (-[WebNetscapePluginView getFormValue:]): Added.
6320 * WebCoreSupport/WebFrameLoaderClient.mm:
6321 (NetscapePluginWidget::getFormValue): Added.
6323 2011-07-04 Dan Bernstein <mitz@apple.com>
6325 Moved handling of frame size changes into its own method.
6327 Reviewed by Oliver Hunt.
6329 * WebView/WebFrameView.mm:
6330 (-[WebFrameView _frameSizeChanged]): Added. Moved code here...
6331 (-[WebFrameView setFrameSize:]): ...from here.
6332 * WebView/WebFrameViewInternal.h:
6334 2011-07-01 Adele Peterson <adele@apple.com>
6336 Reviewed by Darin Adler.
6338 WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
6339 <rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body
6341 * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
6342 Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word,
6343 space, and after-white-space properties to subframes in the editable document.
6345 2011-07-01 Andy Estes <aestes@apple.com>
6347 Reviewed by Mark Rowe.
6349 Simplify MailQuirksUserScript.js
6350 https://bugs.webkit.org/show_bug.cgi?id=63800
6352 MailQuirksUserScript.js is injected into WebViews in Mail.app on
6353 Leopard to resolve an incompatibility between it and the HTML5 parser.
6354 It did so by taking all nodes in the document between <html> and <body>
6355 and moving them to be children of <body>. This maintains Mail.app's
6356 assumption that document.firstChild.firstChild == document.body.
6358 While this script fixed a specific issue with the Signature panel in
6359 Mail.app, it caused regressions in other WebViews. Since the issue with
6360 the Signature panel is with the empty <head> node implicitly created by
6361 the parser, we can simplify this script by removing this implicit
6362 <head> in the case it has no attributes and no children. This fixes the
6363 Signature panel without affecting other WebViews that have non-trivial
6366 * Misc/MailQuirksUserScript.js: If <head> exists but has no attributes
6367 and no children, remove it.
6369 2011-06-30 Dan Bernstein <mitz@apple.com>
6371 Reviewed by Adele Peterson.
6373 Add +[WebView _allowsRoundingHacks]
6374 https://bugs.webkit.org/show_bug.cgi?id=63734
6376 * WebView/WebView.mm:
6377 (+[WebView _allowsRoundingHacks]): Added this accessor.
6378 * WebView/WebViewPrivate.h:
6380 2011-06-29 Darin Adler <darin@apple.com>
6382 Reviewed by Dan Bernstein.
6384 [Mac] Use system cursors instead of custom bitmaps where possible
6385 https://bugs.webkit.org/show_bug.cgi?id=63679
6387 * WebCoreSupport/WebSystemInterface.mm:
6388 (InitWebCoreSystemInterface): Added WKCursor.
6390 2011-06-28 Ilya Sherman <isherman@chromium.org>
6392 Reviewed by Adam Barth.
6394 form.autocomplete="off" does not work
6395 https://bugs.webkit.org/show_bug.cgi?id=35823
6397 * WebView/WebHTMLRepresentation.mm:
6398 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.
6400 2011-06-26 Mark Rowe <mrowe@apple.com>
6402 Reviewed by Dan Bernstein.
6404 Use a separate file name for Lion's WebKitSystemInterface.
6406 * Configurations/DebugRelease.xcconfig:
6408 2011-06-24 Dan Bernstein <mitz@apple.com>
6410 Reviewed by Anders Carlsson.
6412 Add an option to enable legacy rounding hacks
6413 https://bugs.webkit.org/show_bug.cgi?id=63363
6415 * Misc/WebKitNSStringExtras.mm:
6416 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
6417 Disabled rounding hacks.
6418 (-[NSString _web_widthWithFont:]): Ditto.
6419 * WebView/WebView.mm:
6420 (+[WebView _setAllowsRoundingHacks:]): Added this setter.
6421 * WebView/WebViewPrivate.h:
6423 2011-06-24 Dominic Cooney <dominicc@chromium.org>
6425 Reviewed by Dimitri Glazkov.
6427 Convert shadow DOM-related tests to use window.internals
6428 https://bugs.webkit.org/show_bug.cgi?id=61671
6430 Remove shadow DOM-related methods from Mac API. These are not
6433 * DOM/WebDOMOperations.mm:
6434 * DOM/WebDOMOperationsPrivate.h:
6436 2011-06-24 Yuta Kitamura <yutak@chromium.org>
6438 Reviewed by Adam Barth.
6440 WebSocket: Add run-time flag for new HyBi protocol
6441 https://bugs.webkit.org/show_bug.cgi?id=60348
6443 Make a new flag (Setting::m_useHixie76WebSocketProtocol)
6444 switchable from WebView and WebPreferences.
6446 * WebView/WebPreferenceKeysPrivate.h:
6447 * WebView/WebPreferences.mm:
6448 (+[WebPreferences initialize]):
6449 (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
6450 (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
6451 * WebView/WebPreferencesPrivate.h:
6452 * WebView/WebView.mm:
6453 (-[WebView _preferencesChanged:]):
6455 2011-06-22 Sam Weinig <sam@webkit.org>
6457 Roll out r89469 (Add preference for setting the html parser depth limit)
6459 The preference is not needed at this time, so there is no reason to expose it.
6461 * WebView/WebPreferenceKeysPrivate.h:
6462 * WebView/WebPreferences.mm:
6463 (+[WebPreferences initialize]):
6464 * WebView/WebPreferencesPrivate.h:
6465 * WebView/WebView.mm:
6466 (-[WebView _preferencesChanged:]):
6468 2011-06-22 Sam Weinig <sam@webkit.org>
6470 Reviewed by Adam Barth.
6472 Add preference for setting the html parser depth limit
6473 https://bugs.webkit.org/show_bug.cgi?id=63163
6475 * WebView/WebPreferenceKeysPrivate.h:
6476 * WebView/WebPreferences.mm:
6477 (+[WebPreferences initialize]):
6478 (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
6479 (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
6480 * WebView/WebPreferencesPrivate.h:
6481 * WebView/WebView.mm:
6482 (-[WebView _preferencesChanged:]):
6483 Add private preference for setting the parser depth limit.
6485 2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
6487 Reviewed by Darin Adler.
6489 Make instantiation of legacy editing position more explicit
6490 https://bugs.webkit.org/show_bug.cgi?id=63037
6492 Create new positions since we can't create a legacy editing position outside of WebCore anymore.
6494 * WebView/WebFrame.mm:
6495 (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition.
6496 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
6498 2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
6500 Reviewed by Kent Tamura.
6502 FileChooser should be only created when we need to choose files.
6503 https://bugs.webkit.org/show_bug.cgi?id=63039
6505 * WebCoreSupport/WebChromeClient.mm:
6506 (WebChromeClient::runOpenPanel): Changed to use settings.
6508 2011-06-21 MORITA Hajime <morrita@google.com>
6510 Unreviewed, rolling out r89401 and r89403.
6511 http://trac.webkit.org/changeset/89401
6512 http://trac.webkit.org/changeset/89403
6513 https://bugs.webkit.org/show_bug.cgi?id=62970
6515 Breaks mac build and mistakenly enables the spellcheck API
6517 * Configurations/FeatureDefines.xcconfig:
6519 2011-06-20 MORITA Hajime <morrita@google.com>
6521 Reviewed by Kent Tamura.
6523 Spellcheck API should be build-able.
6524 https://bugs.webkit.org/show_bug.cgi?id=62970
6526 No new tests, changing only build related files
6528 * Configurations/FeatureDefines.xcconfig:
6530 2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
6532 Unreviewed, rolling out r89354.
6533 http://trac.webkit.org/changeset/89354
6534 https://bugs.webkit.org/show_bug.cgi?id=63099
6536 Broke tests on Mac (Requested by rniwa on #webkit).
6538 * WebCoreSupport/WebInspectorClient.mm:
6539 (-[WebInspectorWindowController destroyInspectorView:]):
6540 * WebInspector/WebInspector.mm:
6541 (-[WebInspector show:]):
6542 (-[WebInspector showConsole:]):
6543 (-[WebInspector isDebuggingJavaScript]):
6544 (-[WebInspector toggleDebuggingJavaScript:]):
6545 (-[WebInspector startDebuggingJavaScript:]):
6546 (-[WebInspector stopDebuggingJavaScript:]):
6547 (-[WebInspector isProfilingJavaScript]):
6548 (-[WebInspector toggleProfilingJavaScript:]):
6549 (-[WebInspector startProfilingJavaScript:]):
6550 (-[WebInspector stopProfilingJavaScript:]):
6551 (-[WebInspector isJavaScriptProfilingEnabled]):
6552 (-[WebInspector setJavaScriptProfilingEnabled:]):
6553 (-[WebInspector isTimelineProfilingEnabled]):
6554 (-[WebInspector setTimelineProfilingEnabled:]):
6555 (-[WebInspector setFrontend:]):
6556 (-[WebInspector showWindow:]):
6557 * WebInspector/WebInspectorFrontend.h:
6558 * WebInspector/WebInspectorFrontend.mm:
6559 * WebInspector/WebInspectorPrivate.h:
6561 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
6563 Reviewed by Yury Semikhatsky.
6565 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
6566 https://bugs.webkit.org/show_bug.cgi?id=62985
6568 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
6569 methods for plumbing the menu action handlers through the WebKit and WebCore.
6570 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
6571 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
6572 WebKit/win and WebKit2 to follow.
6574 * WebCoreSupport/WebInspectorClient.mm:
6575 (-[WebInspectorWindowController destroyInspectorView:]):
6576 * WebInspector/WebInspector.mm:
6577 (-[WebInspector showWindow]):
6578 (-[WebInspector show:]):
6579 (-[WebInspector showConsole:]):
6580 (-[WebInspector isDebuggingJavaScript]):
6581 (-[WebInspector toggleDebuggingJavaScript:]):
6582 (-[WebInspector startDebuggingJavaScript:]):
6583 (-[WebInspector stopDebuggingJavaScript:]):
6584 (-[WebInspector isProfilingJavaScript]):
6585 (-[WebInspector toggleProfilingJavaScript:]):
6586 (-[WebInspector startProfilingJavaScript:]):
6587 (-[WebInspector stopProfilingJavaScript:]):
6588 (-[WebInspector isJavaScriptProfilingEnabled]):
6589 (-[WebInspector setJavaScriptProfilingEnabled:]):
6590 (-[WebInspector isTimelineProfilingEnabled]):
6591 (-[WebInspector setTimelineProfilingEnabled:]):
6592 (-[WebInspector setFrontend:]):
6593 (-[WebInspector releaseFrontend]):
6594 (-[WebInspector showWindow:]):
6595 * WebInspector/WebInspectorFrontend.h:
6596 * WebInspector/WebInspectorFrontend.mm:
6597 (-[WebInspectorFrontend isDebuggingEnabled]):
6598 (-[WebInspectorFrontend setDebuggingEnabled:]):
6599 (-[WebInspectorFrontend isProfilingJavaScript]):
6600 (-[WebInspectorFrontend startProfilingJavaScript]):
6601 (-[WebInspectorFrontend stopProfilingJavaScript]):
6602 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
6603 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
6604 (-[WebInspectorFrontend isTimelineProfilingEnabled]):
6605 (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
6606 * WebInspector/WebInspectorPrivate.h:
6608 2011-06-01 Jer Noble <jer.noble@apple.com>
6610 Reviewed by Eric Carlson.
6612 Move Full Screen Controllers into WebCore.
6614 Remove dependency on QTKit from wekitExitFullscreen()
6615 https://bugs.webkit.org/show_bug.cgi?id=61843
6617 WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation
6618 have been moved into WebCore.
6620 * WebCoreSupport/WebSystemInterface.mm:
6621 (InitWebCoreSystemInterface): Add support for four WKSI functions in WCSI.
6622 * WebView/WebFullScreenController.mm: Remove unused #include.
6623 * WebView/WebView.mm: Change the include location of
6624 WebVideoFullscreenController.h
6626 2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
6628 Reviewed by Darin Adler.
6630 Separate concerns of loading file icons and choosing files.
6631 https://bugs.webkit.org/show_bug.cgi?id=62931
6633 * WebCoreSupport/WebChromeClient.h:
6634 * WebCoreSupport/WebChromeClient.mm:
6635 (WebChromeClient::loadIconForFiles): Renamed.
6637 2011-06-18 Andrew Wellington <andrew@webkit.org>
6639 Reviewed by Alexey Proskuryakov.
6641 https://bugs.webkit.org/show_bug.cgi?id=62843
6642 WebKit Mac API calls didReceiveAuthenticationChallenge instead of
6643 didCancelAuthenticationChallenge
6645 * WebView/WebView.mm:
6646 (-[WebView _cacheResourceLoadDelegateImplementations]):
6648 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
6650 Unreviewed, rolling out r89026.
6651 http://trac.webkit.org/changeset/89026
6652 https://bugs.webkit.org/show_bug.cgi?id=62804
6654 These patches were likely correct. I'll investigate the
6655 browser_test failures. (Requested by abarth on #webkit).
6657 * WebView/WebVideoFullscreenHUDWindowController.mm:
6658 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
6660 2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
6664 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
6665 https://bugs.webkit.org/show_bug.cgi?id=62796
6667 The patches broke chromium browser tests.
6669 * WebView/WebVideoFullscreenHUDWindowController.mm:
6670 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
6672 2011-06-16 Adam Barth <abarth@webkit.org>
6674 Reviewed by Eric Seidel.
6676 Remove HTMLVideoElement::processingUserGesture
6677 https://bugs.webkit.org/show_bug.cgi?id=62784
6679 * WebView/WebVideoFullscreenHUDWindowController.mm:
6680 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
6682 2011-06-15 Adam Barth <abarth@webkit.org>
6684 Reviewed by Eric Seidel.
6686 Remove ScriptController::setAllowPopupsFromPlugin
6687 https://bugs.webkit.org/show_bug.cgi?id=62706
6689 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
6690 (WebKit::NetscapePluginInstanceProxy::evaluate):
6691 * Plugins/WebNetscapePluginView.mm:
6692 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
6694 2011-06-15 David Kilzer <ddkilzer@apple.com>
6696 <http://webkit.org/b/62745> Convert WebNSFileManagerExtras.m to Objective-C++
6698 Reviewed by Joseph Pecoraro.
6700 * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
6701 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
6702 Added static_cast<MetaDataInfo *>.
6704 2011-06-14 Stephanie Lewis <slewis@apple.com>
6706 Rubber stamped by Oliver Hunt.
6708 <rdar://problem/9511169>
6713 2011-06-13 Kentaro Hara <haraken@google.com>
6715 Reviewed by Alexey Proskuryakov.
6717 Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
6718 https://bugs.webkit.org/show_bug.cgi?id=61256
6720 In order to prevent rounding error caused by expanding/shrinking a page
6721 using different calculation here and there, I added a common calculation
6722 method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
6723 keeping the ratio of width and height of the original page.
6724 [WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
6725 and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
6726 use resizePageRectsKeepingRatio() to expand/shrink a page.
6728 Test: printing/page-count-with-one-word.html
6730 * WebView/WebHTMLView.mm:
6731 (-[WebHTMLView _web_setPrintingModeRecursive]):
6732 (-[WebHTMLView _web_clearPrintingModeRecursive]):
6733 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
6734 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]):
6735 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
6736 (-[WebHTMLView _endPrintMode]):
6737 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
6738 (-[WebHTMLView _endScreenPaginationMode]):
6739 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]):
6740 (-[WebHTMLView layout]):
6741 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
6742 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
6743 (-[WebHTMLView setPageWidthForPrinting:]):
6745 2011-06-13 Tony Chang <tony@chromium.org>
6747 Reviewed by Dimitri Glazkov.
6749 rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
6750 https://bugs.webkit.org/show_bug.cgi?id=62578
6752 * Configurations/FeatureDefines.xcconfig:
6754 2011-06-13 Tony Chang <tony@chromium.org>
6756 Reviewed by Adam Barth.
6758 rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
6759 https://bugs.webkit.org/show_bug.cgi?id=62545
6761 * Configurations/FeatureDefines.xcconfig:
6763 2011-06-12 Adam Barth <abarth@webkit.org>
6765 Reviewed by Alexey Proskuryakov.
6767 Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
6768 https://bugs.webkit.org/show_bug.cgi?id=62516
6770 * WebCoreSupport/WebFrameLoaderClient.h:
6771 * WebCoreSupport/WebFrameLoaderClient.mm:
6772 (WebFrameLoaderClient::interruptedForPolicyChangeError):
6774 2011-06-12 Adam Barth <abarth@webkit.org>
6776 Reviewed by Eric Seidel.
6778 Remove FrameLoader::isProcessingUserGesture
6779 https://bugs.webkit.org/show_bug.cgi?id=62519
6781 * WebView/WebView.mm:
6782 (-[WebView _isProcessingUserGesture]):
6784 2011-06-12 Adam Barth <abarth@webkit.org>
6786 Reviewed by Alexey Proskuryakov.
6788 Remove trival "forward-to-client" member functions from FrameLoader
6789 https://bugs.webkit.org/show_bug.cgi?id=62510
6791 * WebCoreSupport/WebFrameNetworkingContext.mm:
6792 (WebFrameNetworkingContext::blockedError):
6794 2011-06-10 Tony Chang <tony@chromium.org>
6796 Reviewed by Ojan Vafai.
6798 add a compile guard ENABLE(FLEXBOX)
6799 https://bugs.webkit.org/show_bug.cgi?id=62049
6801 * Configurations/FeatureDefines.xcconfig:
6803 2011-06-06 Michael Saboff <msaboff@apple.com>
6805 Reviewed by Geoffrey Garen.
6807 Fonts returned by FontCache::getFontDataForCharacters() are never released
6808 https://bugs.webkit.org/show_bug.cgi?id=61875
6810 This change allows fonts allocated as system fallback fonts to be
6811 released. Previously, the reference counts for these fonts grew
6812 without bound. This is implemented as an auto release class that wraps
6813 accesses to the cache for system fallback fonts. All such accesses are
6814 via the method FontCache::getFontDataForCharacters. The new class is
6815 called FontCachePurgePreventer. When such an object exists, it protects
6816 these fonts from deletion.
6818 See more comments for this defect in Source/WebCore/ChangeLog.
6820 * Misc/WebKitNSStringExtras.mm:
6821 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
6822 (-[NSString _web_widthWithFont:]):
6823 Wrapped code accessing fallback fonts with local
6824 FontCachePurgePreventer in these methods.
6826 * Misc/WebStringTruncator.mm:
6827 (+[WebStringTruncator centerTruncateString:toWidth:]):
6828 (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
6829 (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
6830 (+[WebStringTruncator widthOfString:font:]):
6831 Wrapped code accessing fallback fonts with local
6832 FontCachePurgePreventer in these methods.
6834 2011-06-06 Peter Kasting <pkasting@google.com>
6836 Reviewed by Antonio Gomes.
6838 Remove unnecessary args from scroll functions.
6839 https://bugs.webkit.org/show_bug.cgi?id=61648
6841 * WebView/WebFrame.mm:
6842 (-[WebFrame _scrollDOMRangeToVisible:]):
6844 2011-06-06 Alexandru Chiculita <achicu@adobe.com>
6846 Reviewed by Kent Tamura.
6848 Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
6849 https://bugs.webkit.org/show_bug.cgi?id=61628
6851 * Configurations/FeatureDefines.xcconfig:
6853 2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
6855 Reviewed by Kent Tamura.
6857 Add ENABLE(CSS_REGIONS) guard for CSS Regions support
6858 https://bugs.webkit.org/show_bug.cgi?id=61631
6860 * Configurations/FeatureDefines.xcconfig:
6862 2011-06-02 Anders Carlsson <andersca@apple.com>
6864 Reviewed by Sam Weinig.
6866 Need a way to install the memory pressure handler without initializing WebKit1
6867 https://bugs.webkit.org/show_bug.cgi?id=61975
6869 Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
6870 -[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
6871 but we'd like to be able to install a memory pressure handler without creating a WebView or even
6872 calling any WebView method since that will call +[WebView initialize].
6875 * WebView/WebView.mm:
6876 (WebInstallMemoryPressureHandler):
6877 * WebView/WebViewPrivate.h:
6879 2011-05-27 Stephanie Lewis <slewis@apple.com>
6883 Fix a typo in the order_file flag.
6885 * Configurations/Base.xcconfig:
6887 2011-05-27 Stephanie Lewis <slewis@apple.com>
6889 Rubber Stamped by Adam Roben.
6891 Update Order Files. Use -order_file flag since it can order more of the binary.
6893 * Configurations/Base.xcconfig:
6896 2011-05-25 Stephanie Lewis <slewis@apple.com>
6898 Reviewed by Brady Eidson.
6900 https://bugs.webkit.org/show_bug.cgi?id=61407
6901 part of <rdar://problem/8675177>
6902 Remove Quicklook pref. Moving it enirely down into WebCore so it can
6903 be calculated only on reloads.
6905 * WebView/WebPreferenceKeysPrivate.h:
6906 * WebView/WebPreferences.mm:
6907 (+[WebPreferences initialize]):
6908 * WebView/WebPreferencesPrivate.h:
6909 * WebView/WebView.mm:
6910 (-[WebView _preferencesChanged:]):
6912 2011-05-24 Jer Noble <jer.noble@apple.com>
6914 Reviewed by Darin Adler.
6916 Video fails to play on Vimeo
6917 https://bugs.webkit.org/show_bug.cgi?id=61403
6919 * WebCoreSupport/WebSystemInterface.mm:
6920 (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
6921 wkQTMovieResolvedURL.
6923 2011-05-24 Keishi Hattori <keishi@webkit.org>
6925 Reviewed by Kent Tamura.
6927 Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
6928 https://bugs.webkit.org/show_bug.cgi?id=61273
6930 * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
6932 2011-05-24 Adam Barth <abarth@webkit.org>
6934 Reviewed by Eric Seidel.
6936 Add FIXME comments about removing FrameLoader::isProcessingUserGesture
6937 https://bugs.webkit.org/show_bug.cgi?id=61395
6939 * WebView/WebView.mm:
6940 (-[WebView _isProcessingUserGesture]):
6942 2011-05-24 Michael Saboff <msaboff@apple.com>
6944 Reviewed by Geoffrey Garen.
6946 Improve handling in WebCore of low memory situations
6947 https://bugs.webkit.org/show_bug.cgi?id=61222
6949 Added call to enable memory pressure handling.
6951 * WebView/WebView.mm:
6952 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
6953 * WebView/WebViewInternal.h:
6955 2011-05-24 Jay Civelli <jcivelli@chromium.org>
6957 Rubberstamped by David Kilzer.
6959 Updated some files that I forgot in my previous MHTML CL.
6961 * Configurations/FeatureDefines.xcconfig:
6963 2011-05-20 Jeremy Noble <jer.noble@apple.com>
6965 Reviewed by Simon Fraser.
6967 Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
6968 https://bugs.webkit.org/show_bug.cgi?id=61224
6970 Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
6973 * WebView/WebFullScreenController.mm:
6974 (-[WebFullScreenController windowDidEnterFullscreen:]):
6975 (-[WebFullScreenController enterFullscreen:]):
6976 (-[WebFullScreenController exitFullscreen]):
6977 (-[WebFullscreenWindow setRendererLayer:]):
6979 2011-05-20 Andy Estes <aestes@apple.com>
6981 Reviewed by Darin Adler.
6983 WebView loses firstResponder status when entering full-screen mode.
6984 https://bugs.webkit.org/show_bug.cgi?id=61153
6986 * Misc/WebNSWindowExtras.h:
6987 * Misc/WebNSWindowExtras.m:
6988 (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a
6989 convenience method to NSWindow that makes the given NSResponder first
6990 responder only if it is a descendant of the given view.
6991 * WebView/WebFullScreenController.mm:
6992 (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView
6993 was a descendant of the browser window's first responder when entering
6994 full-screen mode, set the full-screen window's first responder to that
6996 (-[WebFullScreenController exitFullscreen]): Do the reverse of what is
6997 done in windowDidEnterFullscreen:.
6999 2011-05-20 Enrica Casucci <enrica@apple.com>
7001 Reviewed by David Kilzer.
7003 Add delegate methods about focus and blur to all elements.
7004 https://bugs.webkit.org/show_bug.cgi?id=61218
7006 We want to have delegates for these events for all the elements, not only the form elements.
7007 The patch changes the name of the methods in a way that is not form element specific.
7009 * WebCoreSupport/WebChromeClient.h:
7010 * WebCoreSupport/WebChromeClient.mm:
7011 (WebChromeClient::elementDidFocus):
7012 (WebChromeClient::elementDidBlur):
7013 * WebView/WebUIDelegatePrivate.h:
7015 2011-05-20 Simon Fraser <simon.fraser@apple.com>
7017 Reviewed by Sam Weinig.
7019 numberOfActiveAnimations() can include animations from documents in the page cache
7020 https://bugs.webkit.org/show_bug.cgi?id=53641
7022 Pass the Frame's document as the one to count animations on.
7024 * WebView/WebFrame.mm:
7025 (-[WebFrame _numberOfActiveAnimations]):
7027 2011-05-17 Timothy Hatcher <timothy@apple.com>
7029 Update the the context menu to reflect the system search provider on Mac.
7031 <rdar://problem/9198419>
7033 Reviewed by Sam Weinig.
7035 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
7036 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
7037 create the web search context menu title.
7038 * WebCoreSupport/WebSystemInterface.mm:
7039 (InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.
7041 2011-05-16 Emil A Eklund <eae@chromium.org>
7043 Reviewed by Eric Seidel.
7045 Replace docTop/Right/Bottom/Left/Width/Height with documentRect
7046 https://bugs.webkit.org/show_bug.cgi?id=60743
7048 Replace uses of docWidth/Height with documentRect.
7050 * WebView/WebFrame.mm:
7051 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
7053 2011-05-16 Yuzo Fujishima <yuzo@google.com>
7055 Reviewed by Antti Koivisto.
7057 Fix for Bug 43704 - Web font is printed as blank if it is not cached
7058 https://bugs.webkit.org/show_bug.cgi?id=43704
7060 * WebView/WebHTMLView.mm:
7061 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
7063 2011-05-16 David Kilzer <ddkilzer@apple.com>
7065 <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
7066 <rdar://problem/9446430>
7068 Reviewed by Mark Rowe.
7070 * Configurations/Base.xcconfig: Fixed typo.
7072 2011-05-13 Jon Lee <jonlee@apple.com>
7074 Reviewed by Simon Fraser.
7076 Can't horizontally scroll iframes and overflow because wheel events are always accepted
7077 https://bugs.webkit.org/show_bug.cgi?id=60779
7079 * WebCoreSupport/WebChromeClient.h:
7080 (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
7081 (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
7083 2011-05-13 Sam Weinig <sam@webkit.org>
7085 Reviewed by Anders Carlsson.
7087 Prune #includes from FrameView.h (Part 2)
7088 https://bugs.webkit.org/show_bug.cgi?id=60748
7090 - Update files that were depending on FrameView.h #including Frame.h or
7093 * WebView/WebClipView.mm:
7094 * WebView/WebHTMLView.mm:
7095 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
7097 2011-05-12 Pratik Solanki <psolanki@apple.com>
7099 Reviewed by Antti Koivisto.
7101 Part of WebCore should use CFNetwork-based loader on Mac
7102 https://bugs.webkit.org/show_bug.cgi?id=51836
7104 Use CFRunLoop when using CFNetwork.
7106 * WebView/WebView.mm:
7107 (-[WebView scheduleInRunLoop:forMode:]):
7108 (-[WebView unscheduleFromRunLoop:forMode:]):
7110 2011-05-12 Pratik Solanki <psolanki@apple.com>
7112 Reviewed by Antti Koivisto.
7114 Part of WebCore should use CFNetwork-based loader on Mac
7115 https://bugs.webkit.org/show_bug.cgi?id=51836
7117 Include AuthenticationCF.h header file.
7119 * Misc/WebDownload.mm:
7120 * Plugins/WebBaseNetscapePluginView.mm:
7121 * WebCoreSupport/WebFrameLoaderClient.mm:
7123 2011-05-12 Adele Peterson <adele@apple.com>
7125 Reviewed by Darin Adler and Adam Barth.
7127 Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
7128 https://bugs.webkit.org/show_bug.cgi?id=60685
7130 Solar Walk uses a self closing title tag, so to match the behavior of the old parser,
7131 we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
7133 * Misc/SolarWalkQuirksUserScript.js: Added.
7134 * WebView/WebView.mm:
7135 (needsSolarWalkQuirksScript):
7136 (leakSolarWalkQuirksUserScriptContents):
7137 (-[WebView _injectSolarWalkQuirksScript]):
7138 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
7140 2011-05-12 Jia Pu <jpu@apple.com>
7142 Reviewed by Darin Adler.
7144 Regression caused by changeset 86281
7145 https://bugs.webkit.org/show_bug.cgi?id=60712
7146 <rdar://problem/9427970>
7148 Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
7149 So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
7150 returns. So we don't need to use the condition to coordinate between these two function. In fact,
7151 all callbacks are delivered on main thread. We don't really need any locking here.
7153 Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
7156 * WebCoreSupport/CorrectionPanel.h:
7157 * WebCoreSupport/CorrectionPanel.mm:
7158 (CorrectionPanel::CorrectionPanel):
7159 (CorrectionPanel::show):
7160 (CorrectionPanel::dismiss):
7161 (CorrectionPanel::dismissInternal):
7162 (CorrectionPanel::handleAcceptedReplacement):
7163 * WebCoreSupport/WebEditorClient.mm:
7164 (WebEditorClient::dismissCorrectionPanelSoon):
7166 2011-05-12 Patrick Gansterer <paroga@webkit.org>
7168 Reviewed by Adam Barth.
7170 Enable OwnPtr strict mode in PluginHalter
7171 https://bugs.webkit.org/show_bug.cgi?id=60681
7173 * WebView/WebView.mm:
7174 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
7176 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
7178 Reviewed by Darin Adler.
7180 String operator+ reallocates unnecessarily when concatting > 2 strings
7181 https://bugs.webkit.org/show_bug.cgi?id=58420
7183 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
7185 * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
7186 (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):
7188 2011-05-10 Tony Gentilcore <tonyg@chromium.org>
7190 Reviewed by Darin Adler.
7192 Perform some forward declarations suggested by include-what-you-use
7193 https://bugs.webkit.org/show_bug.cgi?id=60545
7195 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
7196 * WebView/WebFrame.mm:
7198 2011-05-11 Jia Pu <jpu@apple.com>
7200 Reviewed by Darin Adler.
7202 CorrectionPanel sometimes hangs in dismissSoon().
7203 https://bugs.webkit.org/show_bug.cgi?id=60599
7204 <rdar://problem/9313628>
7206 Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
7207 to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
7208 for condition checking.
7210 * WebCoreSupport/CorrectionPanel.h:
7211 * WebCoreSupport/CorrectionPanel.mm:
7212 (CorrectionPanel::CorrectionPanel):
7213 (CorrectionPanel::show):
7214 (CorrectionPanel::dismissSoon):
7215 (CorrectionPanel::dismissInternal):
7216 (CorrectionPanel::handleAcceptedReplacement):
7218 2011-05-10 Anton D'Auria <adauria@apple.com>
7220 Reviewed by David Levin.
7222 Add ApplicationCache API to get disk usage per origin
7223 https://bugs.webkit.org/show_bug.cgi?id=57127
7227 * WebCoreSupport/WebApplicationCache.h:
7228 * WebCoreSupport/WebApplicationCache.mm:
7229 (+[WebApplicationCache diskUsageForOrigin:]):
7231 2011-05-10 Anton D'Auria <adauria@apple.com>
7233 Reviewed by Alexey Proskuryakov.
7235 Add ApplicationCache API to get disk usage per origin
7236 https://bugs.webkit.org/show_bug.cgi?id=57127
7240 * WebCoreSupport/WebApplicationCache.h:
7241 * WebCoreSupport/WebApplicationCache.mm:
7242 (+[WebApplicationCache diskUsageForOrigin:]):
7244 2011-05-10 Beth Dakin <bdakin@apple.com>
7246 Reviewed by Darin Adler.
7248 https://bugs.webkit.org/show_bug.cgi?id=60582
7249 Crash switching overlay/non-overlay scrollbar preference still possible
7251 <rdar://problem/9323983>
7253 * WebCoreSupport/WebSystemInterface.mm:
7254 (InitWebCoreSystemInterface):
7256 2011-05-09 Jeremy Noble <jer.noble@apple.com>
7258 Reviewed by Darin Adler.
7260 Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
7261 https://bugs.webkit.org/show_bug.cgi?id=60496
7263 When animating into and out of full screen, order out and back in the original webView window,
7264 disabling animations when necessary. The exitFullscreen method was targeting the wrong window,
7265 as the webView is hosted in the full screen window when we ask for it's parent window.
7267 * WebView/WebFullScreenController.mm:
7268 (-[WebFullScreenController windowDidEnterFullscreen:]):
7269 (-[WebFullScreenController exitFullscreen]):
7271 2011-05-04 Philippe Normand <pnormand@igalia.com>
7273 Reviewed by Dimitri Glazkov.
7275 Implement LayoutTestController::pseudoShadowId()
7276 https://bugs.webkit.org/show_bug.cgi?id=60034
7278 * DOM/WebDOMOperations.mm:
7279 (-[DOMElement _shadowPseudoId]):
7280 * DOM/WebDOMOperationsPrivate.h:
7282 2011-05-05 Dan Bernstein <mitz@apple.com>
7284 Reviewed by Simon Fraser.
7286 WebKit part of <rdar://problem/9155590> Broken animation in iAd producer
7288 * WebCoreSupport/WebSystemInterface.mm:
7289 (InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
7291 2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
7293 Reviewed by Eric Seidel.
7295 Rename SelectionController to FrameSelection
7296 https://bugs.webkit.org/show_bug.cgi?id=60234
7298 * WebView/WebFrame.mm:
7299 (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
7300 * WebView/WebFrameInternal.h:
7301 * WebView/WebHTMLView.mm:
7302 * WebView/WebTextCompletionController.mm:
7303 (-[WebTextCompletionController doCompletion]):
7304 * WebView/WebView.mm:
7306 2011-05-04 Cris Neckar <cdn@chromium.org>
7308 Reviewed by Adam Barth.
7310 Expose WebView directly through ChromeClient.
7311 https://bugs.webkit.org/show_bug.cgi?id=49902
7313 * WebCoreSupport/WebChromeClient.h:
7314 (WebChromeClient::webView):
7315 * WebView/WebFrame.mm:
7318 2011-05-04 Tao Bai <michaelbai@chromium.org>
7320 Reviewed by David Kilzer.
7322 Populate touch-icon url to FrameLoaderClient
7323 https://bugs.webkit.org/show_bug.cgi?id=59143
7325 Respect the interface change in FrameLoaderClient.
7327 * Configurations/FeatureDefines.xcconfig:
7328 * WebCoreSupport/WebFrameLoaderClient.h:
7329 * WebCoreSupport/WebFrameLoaderClient.mm:
7330 (WebFrameLoaderClient::dispatchDidChangeIcons):
7332 2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
7334 Reviewed by Dimitri Glazkov.
7336 Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
7337 https://bugs.webkit.org/show_bug.cgi?id=58703
7339 * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
7341 2011-05-02 Adam Roben <aroben@apple.com>
7343 Take advantage of implicit conversion from nullptr_t to PassOwnPtr
7345 Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
7346 doesn't work, but should
7348 Reviewed by Adam Barth.
7350 * History/WebHistory.mm:
7351 * Plugins/WebNetscapePluginEventHandler.mm:
7352 * WebView/WebView.mm:
7354 2011-05-02 Brady Eidson <beidson@apple.com>
7356 Reviewed by Anders Carlsson.
7358 <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
7359 In Aperture, a WebView might be dealloc'ed before it finishes loading.
7361 * WebView/WebView.mm:
7362 (needsSelfRetainWhileLoadingQuirk):
7363 (-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
7364 (-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
7365 (-[WebView _didFailLoadWithError:forFrame:]): Ditto.
7366 (-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.
7368 2011-05-02 Adam Barth <abarth@webkit.org>
7370 Reviewed by David Levin.
7372 PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
7373 https://bugs.webkit.org/show_bug.cgi?id=59924
7375 * History/WebHistory.mm:
7376 (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
7377 * Plugins/WebBaseNetscapePluginView.mm:
7378 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
7379 * WebCoreSupport/WebFrameLoaderClient.mm:
7380 (WebFrameLoaderClient::savePlatformDataToCachedFrame):
7381 * WebView/WebView.mm:
7382 (-[WebView _injectMailQuirksScript]):
7383 (-[WebView _injectOutlookQuirksScript]):
7386 2011-05-02 Sam Weinig <sam@webkit.org>
7388 Reviewed by Adam Barth.
7390 Prune some #includes from DOMWindow.h
7391 https://bugs.webkit.org/show_bug.cgi?id=59907
7393 * Plugins/WebBaseNetscapePluginView.mm:
7394 * WebView/WebFrame.mm:
7395 Add now missing SecurityOrigin.h #includes.
7397 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
7399 Reviewed by Eric Seidel.
7401 Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
7402 https://bugs.webkit.org/show_bug.cgi?id=59837
7404 Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
7406 * WebView/WebHTMLView.mm:
7407 (-[WebHTMLView menuForEvent:]):
7408 (-[WebHTMLView acceptsFirstMouse:]):
7409 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
7411 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
7413 Reviewed by Eric Seidel.
7415 Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
7416 https://bugs.webkit.org/show_bug.cgi?id=59835
7418 Moved currentKeyboardEvent.
7420 * WebView/WebHTMLView.mm:
7421 (currentKeyboardEvent):
7422 (-[WebHTMLView becomeFirstResponder]):
7424 2011-04-29 Dean Jackson <dino@apple.com>
7426 Reviewed by Simon Fraser.
7428 Add ENABLE macro for WebKitAnimation
7429 https://bugs.webkit.org/show_bug.cgi?id=59729
7431 Add new feature to toggle WebKit Animation API.
7433 * Configurations/FeatureDefines.xcconfig:
7435 2011-04-28 David Kilzer <ddkilzer@apple.com>
7437 <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods
7439 Reviewed by Anders Carlsson.
7441 * History/WebHistory.mm:
7442 (-[WebHistoryPrivate init]):
7443 * Misc/WebElementDictionary.mm:
7444 (-[WebElementDictionary initWithHitTestResult:]):
7445 * Misc/WebIconDatabase.mm:
7446 (-[WebIconDatabase init]):
7447 * Plugins/WebPluginController.mm:
7448 (-[WebPluginController initWithDocumentView:]):
7449 * Plugins/WebPluginRequest.m:
7450 (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
7451 * WebCoreSupport/WebEditorClient.mm:
7452 (-[WebEditCommand initWithEditCommand:]):
7453 * WebCoreSupport/WebJavaScriptTextInputPanel.m:
7454 (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
7455 * WebView/WebNavigationData.mm:
7456 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
7458 2011-04-28 David Levin <levin@chromium.org>
7460 Reviewed by Adam Barth.
7462 Remove IMAGE_RESIZER related code.
7463 https://bugs.webkit.org/show_bug.cgi?id=59735
7465 * Configurations/FeatureDefines.xcconfig:
7467 2011-04-28 Adam Barth <abarth@webkit.org>
7469 Reviewed by Eric Seidel.
7472 https://bugs.webkit.org/show_bug.cgi?id=59678
7474 Remove WML-related configuration options and private APIs.
7476 * Configurations/FeatureDefines.xcconfig:
7477 * WebCoreSupport/WebChromeClient.mm:
7478 (stringForMessageSource):
7479 * WebView/WebFramePrivate.h:
7480 * WebView/WebUIDelegatePrivate.h:
7482 2011-04-28 Brian Weinstein <bweinstein@apple.com>
7484 Reviewed by Timothy Hatcher.
7486 Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
7487 https://bugs.webkit.org/show_bug.cgi?id=59747
7489 Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
7490 Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.
7492 * WebCoreSupport/WebInspectorClient.mm:
7493 (-[WebInspectorWindowController showWebInspector:]):
7494 (-[WebInspectorWindowController showErrorConsole:]):
7495 (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
7496 (-[WebInspectorWindowController toggleProfilingJavaScript:]):
7497 (-[WebInspectorWindowController validateUserInterfaceItem:]):
7499 2011-04-28 David Kilzer <ddkilzer@apple.com>
7501 <http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer
7503 Reviewed by Dan Bernstein.
7505 * WebView/WebFullScreenController.mm:
7506 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
7507 Use a RetainPtr to hold the CALayer and to fix the leak.
7509 2011-04-28 David Kilzer <ddkilzer@apple.com>
7511 Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
7513 Addresses review comment from Darin Adler.
7515 * WebView/WebPDFView.mm:
7516 (-[WebPDFView menuForEvent:]): Use a local variable and -release
7517 instead of -autorelease.
7519 2011-04-28 Anders Carlsson <andersca@apple.com>
7521 Fix a thinko - separateRealmLabel is not an NSImageView.
7523 * Panels/WebAuthenticationPanel.h:
7525 2011-04-28 David Kilzer <ddkilzer@apple.com>
7527 <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
7529 Reviewed by Dan Bernstein.
7531 * WebView/WebPDFView.mm:
7532 (-[WebPDFView menuForEvent:]): Call -autorelease after copying
7533 each NSMenuItem. Regressed in r9566 for Bug 3711.
7535 2011-04-28 Enrica Casucci <enrica@apple.com>
7537 Reviewed by Beth Dakin.
7539 Momentum scroll tweak for WebKit.
7540 https://bugs.webkit.org/show_bug.cgi?id=59723
7541 <rdar://problem/9259933>
7543 * WebView/WebDynamicScrollBarsView.mm:
7544 (-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.
7546 2011-04-27 Anders Carlsson <andersca@apple.com>
7548 Follow-up Leopard build fix.
7550 * Carbon/HIViewAdapter.m:
7551 (_webkit_NSView_setNeedsDisplayInRect):
7553 2011-04-27 Anders Carlsson <andersca@apple.com>
7555 More clang++ 32-bit build fixes.
7557 * Carbon/CarbonWindowAdapter.mm:
7558 (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
7559 (-[CarbonWindowAdapter setContentView:]):
7560 (-[CarbonWindowAdapter _handleContentBoundsChanged]):
7561 * Carbon/HIViewAdapter.m:
7562 (_webkit_NSView_setNeedsDisplayInRect):
7563 * Panels/WebAuthenticationPanel.h:
7564 * Plugins/WebBaseNetscapePluginView.mm:
7565 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
7566 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
7568 * WebCoreSupport/WebChromeClient.mm:
7569 (WebChromeClient::scrollRectIntoView):
7570 * WebCoreSupport/WebViewFactory.mm:
7571 (-[WebViewFactory accessibilityConvertScreenRect:]):
7572 * WebView/WebFrameView.mm:
7573 (-[WebFrameView _scrollToBeginningOfDocument]):
7574 (-[WebFrameView _scrollToEndOfDocument]):
7575 * WebView/WebFullScreenController.mm:
7576 (-[WebFullScreenController windowDidEnterFullscreen:]):
7577 * WebView/WebHTMLView.mm:
7578 (-[WebHTMLView _hitViewForEvent:]):
7579 (coreGraphicsScreenPointForAppKitScreenPoint):
7580 * WebView/WebPDFView.mm:
7581 (-[WebPDFView setScrollPoint:]):
7583 2011-04-27 Yury Semikhatsky <yurys@chromium.org>
7585 Reviewed by Pavel Feldman.
7587 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
7588 https://bugs.webkit.org/show_bug.cgi?id=44230
7590 Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
7591 inspector is closed.
7593 * WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed
7594 comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining
7595 pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient.
7596 There is only one reference to it from WebInspectorFrontendClient which is held by the inspector
7599 Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
7600 (-[WebInspectorWindowController initWithInspectedWebView:]):
7601 (-[WebInspectorWindowController close]):
7602 (-[WebInspectorWindowController showWindow:]):
7603 (-[WebInspectorWindowController setAttachedWindowHeight:]):
7604 (-[WebInspectorWindowController destroyInspectorView:]):
7606 2011-04-26 Sam Weinig <sam@webkit.org>
7608 Reviewed by David Hyatt.
7610 Remove Datagrid from the tree
7611 https://bugs.webkit.org/show_bug.cgi?id=59543
7613 * Configurations/FeatureDefines.xcconfig:
7616 2011-04-26 Dan Bernstein <mitz@apple.com>
7618 Reviewed by Mark Rowe.
7620 Choose the compiler based on the Xcode version for Snow Leopard debug builds.
7622 * Configurations/Base.xcconfig:
7623 * Configurations/CompilerVersion.xcconfig: Added.
7625 2011-04-25 Adam Barth <abarth@webkit.org>
7627 Reviewed by David Levin.
7629 WebKit2 should play nice with strict OwnPtrs
7630 https://bugs.webkit.org/show_bug.cgi?id=59426
7632 Fix include ordering.
7634 * WebView/WebDeviceOrientationProviderMock.mm:
7636 2011-04-25 Adam Barth <abarth@webkit.org>
7638 Reviewed by David Levin.
7640 WebKit1 should build cleanly with strict OwnPtrs
7641 https://bugs.webkit.org/show_bug.cgi?id=59424
7643 * History/WebHistoryItem.mm:
7644 (-[WebHistoryItem initFromDictionaryRepresentation:]):
7645 * Plugins/WebNetscapePluginEventHandler.h:
7646 * Plugins/WebNetscapePluginEventHandler.mm:
7647 (WebNetscapePluginEventHandler::create):
7648 * Plugins/WebNetscapePluginView.mm:
7649 (-[WebNetscapePluginView createPlugin]):
7650 * WebView/WebDeviceOrientationProviderMock.mm:
7651 * WebView/WebTextIterator.mm:
7652 (-[WebTextIterator initWithRange:]):
7654 2011-04-25 Jon Lee <jonlee@apple.com>
7656 Reviewed by Maciej Stachowiak.
7658 Overlay scroller hard to see on pages with dark background (59183)
7659 https://bugs.webkit.org/show_bug.cgi?id=59183
7660 <rdar://problem/8975367>
7662 * WebCoreSupport/WebSystemInterface.mm:
7663 (InitWebCoreSystemInterface): adding method to allow changing style
7665 2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
7667 Unreviewed, rolling out r84740.
7668 http://trac.webkit.org/changeset/84740
7669 https://bugs.webkit.org/show_bug.cgi?id=59290
7671 change breaks apple internal builds and is incorrect
7672 (Requested by smfr on #webkit).
7674 * WebCoreSupport/WebSystemInterface.mm:
7675 (InitWebCoreSystemInterface):
7677 2011-04-22 Jon Lee <jonlee@apple.com>
7679 Reviewed by Beth Dakin.
7681 Overlay scroller hard to see on pages with dark background (59183)
7682 https://bugs.webkit.org/show_bug.cgi?id=59183
7683 <rdar://problem/8975367>
7685 * WebCoreSupport/WebSystemInterface.mm:
7686 (InitWebCoreSystemInterface): adding method to allow changing style
7688 2011-04-19 Jer Noble <jer.noble@apple.com>
7690 Reviewed by Daniel Bates.
7692 Full Screen from within an <iframe> does not cause <iframe> to resize.
7693 https://bugs.webkit.org/show_bug.cgi?id=58638
7695 Tests: fullscreen/full-screen-frameset-allowed.html
7696 fullscreen/full-screen-frameset-not-allowed.html
7698 Return the _element's document instead of the WKView's document, which
7699 will be different in the case of elements within <iframe>s.
7701 * WebView/WebFullScreenController.mm:
7702 (-[WebFullScreenController _document]):
7704 2011-04-22 Jer Noble <jer.noble@apple.com>
7706 Reviewed by Maciej Stachowiak.
7708 Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
7709 https://bugs.webkit.org/show_bug.cgi?id=59147
7711 Add a new user default preference, and plumb that preference down to WebCore
7712 Settings. Allow the fullScreenEnabled preference to override the new
7713 isAVFoundationEnabled preference, so that clients of the legacy full screen
7714 mode will continue to use that mode normally.
7716 * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
7717 * WebView/WebPreferences.mm:
7718 (+[WebPreferences initialize]): Set the default value of new
7720 (-[WebPreferences setAVFoundationEnabled:]): Added.
7721 (-[WebPreferences isAVFoundationEnabled]): Added.
7722 * WebView/WebPreferencesPrivate.h:
7723 * WebView/WebView.mm:
7724 (-[WebView _preferencesChanged:]): Update the WebCore settings with the
7725 new values from WebPreferences.
7727 2011-04-22 Sam Weinig <sam@webkit.org>
7729 Reviewed by Gavin Barraclough.
7731 Remove remaining uses of deprecated version of toJS
7732 https://bugs.webkit.org/show_bug.cgi?id=59170
7734 * DOM/WebDOMOperations.mm:
7735 (-[DOMElement _shadowRoot:]):
7736 (-[DOMElement _ensureShadowRoot:]):
7737 Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
7739 2011-04-21 Maciej Stachowiak <mjs@apple.com>
7741 Reviewed by Adam Roben.
7743 Add a feature define to allow <details> and <summary> to be disabled
7744 https://bugs.webkit.org/show_bug.cgi?id=59118
7745 <rdar://problem/9257045>
7747 * Configurations/FeatureDefines.xcconfig:
7749 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
7751 Reviewed by Sam Weinig.
7753 Add Frame* to the argument lists of canCopyCut and canPaste
7754 https://bugs.webkit.org/show_bug.cgi?id=59153
7756 * WebCoreSupport/WebEditorClient.h:
7757 * WebCoreSupport/WebEditorClient.mm:
7758 (WebEditorClient::canCopyCut):
7759 (WebEditorClient::canPaste):
7761 2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
7763 Unreviewed, rolling out r82052.
7764 http://trac.webkit.org/changeset/82052
7765 https://bugs.webkit.org/show_bug.cgi?id=59135
7767 New full screen api should be opt-in, not opt-out. (Requested
7768 by jernoble on #webkit).
7770 * WebView/WebPreferences.mm:
7771 (+[WebPreferences initialize]):
7773 2011-04-21 Beth Dakin <bdakin@apple.com>
7775 Reviewed by Dan Bernstein.
7777 https://bugs.webkit.org/show_bug.cgi?id=59048
7778 Need to track whether overlay scrollbar is currently visible and in lower-
7781 <rdar://problem/9211232>
7783 A new WebSystemInterface is needed for this.
7784 * WebCoreSupport/WebSystemInterface.mm:
7785 (InitWebCoreSystemInterface):
7787 2011-04-21 Dirk Schulze <krit@webkit.org>
7789 Reviewed by Nikolas Zimmermann.
7791 SVG feDropShadow implementation of SVG Filters 1.2
7792 https://bugs.webkit.org/show_bug.cgi?id=52513
7794 * MigrateHeaders.make:
7796 2011-04-20 Dominic Cooney <dominicc@chromium.org>
7798 Reviewed by Dimitri Glazkov.
7800 layoutTestController can create and destroy shadow DOM
7801 https://bugs.webkit.org/show_bug.cgi?id=59058
7803 Support for new methods in Mac DRT.
7805 * DOM/WebDOMOperations.mm:
7806 (-[DOMElement _ensureShadowRoot:]):
7807 (-[DOMElement _removeShadowRoot]):
7808 * DOM/WebDOMOperationsPrivate.h:
7810 2011-04-20 Eric Carlson <eric.carlson@apple.com>
7812 Reviewed by Dan Bernstein.
7814 Adopt QTKit API for listing and deleting file in its media cache.
7815 <rdar://problem/9130029>
7817 * WebCoreSupport/WebSystemInterface.mm:
7818 (InitWebCoreSystemInterface): Initialize new functions.
7820 2011-04-19 Matthew Delaney <mdelaney@apple.com>
7822 Reviewed by Simon Fraser.
7824 WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
7825 https://bugs.webkit.org/show_bug.cgi?id=58936
7827 * WebView/WebPreferences.mm:
7828 (+[WebPreferences initialize]):
7830 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
7832 Reviewed by Pavel Feldman.
7834 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
7835 https://bugs.webkit.org/show_bug.cgi?id=58883
7837 * WebCoreSupport/WebFrameLoaderClient.h:
7838 * WebCoreSupport/WebFrameLoaderClient.mm:
7839 (WebFrameLoaderClient::dispatchDidReceiveContentLength):
7841 2011-04-18 Jia Pu <jpu@apple.com>
7843 Reviewed by Mark Rowe.
7845 WebKit needs to stop importing <AppKit/NSTextChecker.h>
7846 https://bugs.webkit.org/show_bug.cgi?id=58798
7847 <rdar://problem/9294938>
7849 Use public header <AppKit/NSSpellChecker.h> instead.
7851 * WebCoreSupport/CorrectionPanel.h:
7852 * WebCoreSupport/CorrectionPanel.mm:
7853 (correctionIndicatorType):
7854 (CorrectionPanel::show):
7855 (CorrectionPanel::dismissInternal):
7856 (CorrectionPanel::handleAcceptedReplacement):
7857 * WebCoreSupport/WebEditorClient.mm:
7858 * WebView/WebView.mm:
7860 2011-04-17 Cameron Zwarich <zwarich@apple.com>
7862 Reviewed by Timothy Hatcher.
7864 Stop using -[NSString initWithContentsOfFile:]
7865 https://bugs.webkit.org/show_bug.cgi?id=58763
7867 -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
7869 * WebView/WebView.mm:
7870 (leakMailQuirksUserScriptContents):
7871 (leakOutlookQuirksUserScriptContents):
7873 2011-04-17 David Kilzer <ddkilzer@apple.com>
7875 <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
7876 <rdar://problem/9268729>
7878 Reviewed by Dan Bernstein.
7880 This replaces support for the WebKitEnableHTTPPipelining user
7881 default with methods on the WebCore::ResourceRequest class in
7882 WebCore, the WebView class in WebKit1, and the WebContext class
7883 in WebKit2. It also removes support for the
7884 WebKitForceHTTPPipeliningPriorityHigh user default which was not
7887 * WebView/WebView.mm:
7888 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
7889 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
7890 * WebView/WebViewPrivate.h:
7891 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
7892 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
7894 2011-04-17 Joseph Pecoraro <joepeck@webkit.org>
7896 Reviewed by Dan Bernstein.
7898 Assign to self in WebInspectorWindowController constructors
7899 https://bugs.webkit.org/show_bug.cgi?id=58749
7901 * WebCoreSupport/WebInspectorClient.mm:
7902 (-[WebInspectorWindowController init]):
7903 (-[WebInspectorWindowController initWithInspectedWebView:]):
7905 2011-04-17 Joseph Pecoraro <joepeck@webkit.org>
7907 Reviewed by Timothy Hatcher.
7909 Move WebNodeHighlighter into its own file
7910 https://bugs.webkit.org/show_bug.cgi?id=58746
7912 Extract this class into its own file alongside the
7913 other WebNodeHighlight files. In doing so do some
7914 cleanup on WebInspectorClient removing some methods
7915 that were never called.
7917 * WebCoreSupport/WebInspectorClient.mm:
7918 (WebInspectorClient::WebInspectorClient): style fix.
7919 * WebInspector/WebNodeHighlighter.h: Added.
7920 * WebInspector/WebNodeHighlighter.mm: Added.
7921 (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
7922 (-[WebNodeHighlighter dealloc]):
7923 (-[WebNodeHighlighter highlightNode:]):
7924 (-[WebNodeHighlighter hideHighlight]):
7925 (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
7926 (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
7928 2011-04-15 Jia Pu <jpu@apple.com>
7930 Reviewed by Dan Bernstein.
7932 [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
7933 https://bugs.webkit.org/show_bug.cgi?id=58717
7935 Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
7937 * WebCoreSupport/CorrectionPanel.mm:
7938 (CorrectionPanel::show):
7940 2011-04-15 Shishir Agrawal <shishir@chromium.org>
7942 Reviewed by James Robinson.
7944 Add a flag to guard Page Visibility API changes.
7945 https://bugs.webkit.org/show_bug.cgi?id=58464
7947 * Configurations/FeatureDefines.xcconfig:
7949 2011-04-15 Oliver Hunt <oliver@apple.com>
7951 GC allocate Structure
7952 https://bugs.webkit.org/show_bug.cgi?id=58483
7954 Rolling r83894 r83827 r83810 r83809 r83808 back in with
7955 a workaround for the gcc bug seen by the gtk bots
7957 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
7958 * Plugins/Hosted/ProxyInstance.mm:
7959 (WebKit::ProxyRuntimeMethod::createStructure):
7960 * Plugins/Hosted/ProxyRuntimeObject.h:
7961 (WebKit::ProxyRuntimeObject::createStructure):
7963 2011-04-14 Alexey Proskuryakov <ap@apple.com>
7965 Reviewed by Dan Bernstein.
7967 WebKit2: Password field input does not switch to ASCII-compatible source
7968 https://bugs.webkit.org/show_bug.cgi?id=58583
7969 <rdar://problem/9059651>
7971 Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
7972 necessary logic, needed to return a nil text input context when in password fields.
7974 * WebView/WebHTMLView.mm:
7975 (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
7976 (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
7977 (-[WebHTMLView windowDidResignKey:]): Ditto.
7978 (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
7979 because the first responder is still different an this point, so set a boolean variable to
7980 let _updateSecureInputState know what's going on.
7981 (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
7982 (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
7983 allowed input sources accorsing to current selection.
7984 (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
7986 2011-04-15 Sam Weinig <sam@webkit.org>
7988 Reviewed by Maciej Stachowiak.
7990 Make mac WebKit1 use the default localization strategy
7991 https://bugs.webkit.org/show_bug.cgi?id=58628
7993 * WebCoreSupport/WebPlatformStrategies.h:
7994 * WebCoreSupport/WebPlatformStrategies.mm:
7995 Remove the localization strategy code. The equivalent is now
7996 in WebCore/platform/DefaultLocalizationStrategy.cpp.
7998 2011-04-15 Anna Cavender <annacc@chromium.org>
8000 Reviewed by Eric Carlson.
8002 Renaming TRACK feature define to VIDEO_TRACK
8003 https://bugs.webkit.org/show_bug.cgi?id=53556
8005 * Configurations/FeatureDefines.xcconfig:
8007 2011-04-14 Pratik Solanki <psolanki@apple.com>
8009 Reviewed by David Kilzer.
8011 Set minimum priority for fast lane connections
8012 https://bugs.webkit.org/show_bug.cgi?id=58353
8014 * WebCoreSupport/WebSystemInterface.mm:
8015 (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
8017 2011-04-13 Sam Weinig <sam@webkit.org>
8019 Reviewed by Gavin Barraclough.
8021 WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
8022 <rdar://problem/9260518>
8024 * WebCoreSupport/WebSystemInterface.mm:
8025 (InitWebCoreSystemInterface):
8026 Initialize new WKSI functions.
8028 2011-04-13 David Kilzer <ddkilzer@apple.com>
8030 <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
8032 Reviewed by Anders Carlsson.
8034 Fixes the following warning with -Wcast-align enabled:
8036 Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
8037 archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
8038 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
8040 * Plugins/WebBasePluginPackage.mm:
8041 (-[WebBasePluginPackage isNativeLibraryData:]): Added
8042 COMPILE_ASSERT() to make sure our pointer math is valid.
8043 Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
8044 by sizeof(uint32_t) to fix the pointer math. Replaced C-style
8045 casts with reinterpret_cast.
8047 2011-04-12 Enrica Casucci <enrica@apple.com>
8049 Reviewed by Alexey Proskuryakov.
8051 Infinite recursion in WebHTMLView executeSavedKeypressCommands.
8052 https://bugs.webkit.org/show_bug.cgi?id=58382
8053 <rdar://problem/9239370>
8055 Execution of some editing commands could trigger a call to selectedRange that
8056 internally calls executeSavedKeypressCommands creating an infinite recursion.
8058 * WebView/WebHTMLView.mm:
8059 (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
8060 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
8062 2011-04-12 Alice Liu <alice.liu@apple.com>
8064 Reviewed by Sam Weinig.
8066 https://bugs.webkit.org/show_bug.cgi?id=58292
8067 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
8069 * WebView/WebPreferenceKeysPrivate.h: Add preference key.
8070 * WebView/WebPreferences.mm:
8071 (+[WebPreferences initialize]): Initialize to false.
8072 (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
8073 (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
8074 * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
8075 * WebView/WebView.mm:
8076 (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes.
8078 2011-04-11 Alexey Proskuryakov <ap@apple.com>
8080 Reviewed by Maciej Stachowiak.
8082 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
8083 https://bugs.webkit.org/show_bug.cgi?id=58175
8084 <rdar://problem/9060555>
8086 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
8087 should be changed to match WebKit2.
8089 2011-04-06 Timothy Hatcher <timothy@apple.com>
8091 Fix a bug where the context menu does not show in PDF documents if there is no
8092 UI delegate or the UI delegate does not respond to the context menu selector.
8094 https://webkit.org/b/57958
8096 Reviewed by Darin Adler.
8098 * WebView/WebView.mm:
8099 (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
8100 if UIDelegate is nil or doesn't respond to the selector. So check that
8101 here to distinguish between using defaultMenuItems or the delegate
8102 really returning nil to say "no context menu".
8104 2011-04-11 Jer Noble <jer.noble@apple.com>
8106 Unreviewed; roll out unintentional change to WebFullScreenController.mm.
8108 * WebView/WebFullScreenController.mm:
8109 (-[WebFullScreenController enterFullscreen:]):
8111 2011-04-08 Geoffrey Garen <ggaren@apple.com>
8113 Reviewed by Oliver Hunt.
8115 A few heap-related renames and file moves.
8117 WeakGCPtr<T> => Weak<T>
8118 Global<T> => Strong<T>
8120 collector/* => heap/*
8121 runtime/WeakGCPtr.h => heap/Weak.h
8123 (Eventually, even more files should move into the heap directory. Like
8124 Heap.h and Heap.cpp, for example.)
8126 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
8127 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
8128 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
8129 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
8130 (WebKit::NetscapePluginInstanceProxy::evaluate):
8131 * WebView/WebScriptDebugger.h:
8133 2011-04-08 Alexey Proskuryakov <ap@apple.com>
8135 Reviewed by Darin Adler.
8137 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
8138 https://bugs.webkit.org/show_bug.cgi?id=58175
8139 <rdar://problem/9060555>
8141 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
8142 should be changed to match WebKit2.
8144 2011-04-08 Alpha Lam <hclam@chromium.org>
8146 Unreviewed, rolling out r83335.
8147 http://trac.webkit.org/changeset/83335
8148 https://bugs.webkit.org/show_bug.cgi?id=53556
8150 GTK and QT bots are broken
8152 * Configurations/FeatureDefines.xcconfig:
8154 2011-04-07 Anna Cavender <annacc@chromium.org>
8156 Reviewed by Eric Carlson.
8158 Setup ENABLE(TRACK) feature define
8159 https://bugs.webkit.org/show_bug.cgi?id=53556
8161 * Configurations/FeatureDefines.xcconfig:
8163 2011-04-08 Maciej Stachowiak <mjs@apple.com>
8165 Reviewed by Darin Adler.
8167 -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
8168 https://bugs.webkit.org/show_bug.cgi?id=58128
8169 <rdar://problem/9244553>
8171 The root of the problem here was an O(N^2) issue - each WebView,
8172 upon having its preferences initialized, would broadcast a
8173 notification that was listened to by all other WebViews sharing
8176 To maintain the API contract, I split the notification into two,
8177 one that is for public API consumption, and the other which is for
8178 internal use only. Changes that don't need to be picked up by
8179 other WebViews broadcast the public notification only. And we
8180 avoid WebView broadcasting a notification just to get itself to
8183 * Misc/WebIconDatabase.mm:
8184 (-[WebIconDatabase _startUpIconDatabase]):
8185 (-[WebIconDatabase _shutDownIconDatabase]):
8186 * Plugins/WebBaseNetscapePluginView.mm:
8187 (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
8188 (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
8189 (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
8190 (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
8191 * WebView/WebPreferences.mm:
8192 (-[WebPreferences initWithIdentifier:]):
8193 (-[WebPreferences _setStringValue:forKey:]):
8194 (-[WebPreferences _setIntegerValue:forKey:]):
8195 (-[WebPreferences _setFloatValue:forKey:]):
8196 (-[WebPreferences _setBoolValue:forKey:]):
8197 (-[WebPreferences _setLongLongValue:forKey:]):
8198 (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
8199 (-[WebPreferences _postPreferencesChangedNotification]):
8200 (-[WebPreferences _postPreferencesChangedAPINotification]):
8201 * WebView/WebPreferencesPrivate.h:
8202 * WebView/WebView.mm:
8203 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
8204 (-[WebView _preferencesChangedNotification:]):
8205 (-[WebView _preferencesChanged:]):
8206 (-[WebView setUsesPageCache:]):
8207 (+[WebView initialize]):
8208 (-[WebView setPreferences:]):
8209 (-[WebView _keyboardUIMode]):
8210 * WebView/WebViewInternal.h:
8212 2011-04-07 Andrew Scherkus <scherkus@chromium.org>
8214 Revert ENABLE_TRACK patch due to compile failures.
8216 * Configurations/FeatureDefines.xcconfig:
8218 2011-04-07 Alexey Proskuryakov <ap@apple.com>
8220 Reviewed by Anders Carlsson.
8222 REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
8223 https://bugs.webkit.org/show_bug.cgi?id=58066
8224 <rdar://problem/8965302>
8226 * WebView/WebHTMLRepresentation.mm:
8227 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
8228 * WebView/WebHTMLView.mm:
8229 (-[WebHTMLView attributedSubstringFromRange:]):
8230 (-[WebHTMLView attributedString]):
8231 (-[WebHTMLView selectedAttributedString]):
8232 Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
8234 2011-04-07 Andy Estes <aestes@apple.com>
8236 Reviewed by Darin Adler.
8238 REGRESSION (r64712): Microsoft Outlook 2011: original message contents
8239 not included when replying to an email.
8240 https://bugs.webkit.org/show_bug.cgi?id=57794
8242 Outlook populates a reply message by creating an empty WebView and
8243 using DOM API to populate the WebView's empty document with content
8244 from the original message. It expects the initial empty document to
8245 simply be "<html></html>", and it proceeds to dynamically create and
8246 append a BODY node and add the original message content as a child of
8247 that node. Outlook then takes the innerHTML of the frame's first body
8248 element and copies it into a *new* document that is displayed and
8249 edited in the reply message window.
8251 Due to implementing the HTML5 tree building algorithm in r64712,
8252 initial empty documents went from being "<html></html>" to being
8253 "<html><head></head><body></body></html>". Outlook still dynamically
8254 creates a BODY node to parent the original message content, but this
8255 BODY node duplicates the one created by the tree builder. When Outlook
8256 then takes the innerHTML of the first body element to populate the
8257 reply message window it gets the empty body element created by the
8258 parser, not the one it created with the original message content.
8260 Fix this by injecting a user script into the initial empty document
8261 that removes the HEAD and BODY nodes created by the parser. This
8262 ensures that the BODY created by Outlook is the only BODY in the
8265 * Misc/OutlookQuirksUserScript.js: Added.
8266 * WebView/WebView.mm:
8267 (leakMailQuirksUserScriptContents):
8268 (-[WebView _injectMailQuirksScript]):
8269 (needsOutlookQuirksScript):
8270 (leakOutlookQuirksUserScriptContents):
8271 (-[WebView _injectOutlookQuirksScript]):
8272 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
8274 2011-04-06 Dai Mikurube <dmikurube@chromium.org>
8276 Reviewed by David Levin.
8278 Add QUOTA build flag for unified quota API
8279 https://bugs.webkit.org/show_bug.cgi?id=57918
8281 * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
8283 2011-04-06 Robert Sesek <rsesek@chromium.org>
8285 Reviewed by Alexey Proskuryakov.
8287 Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
8288 https://bugs.webkit.org/show_bug.cgi?id=54969
8290 * WebView/WebFrame.mm:
8291 (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
8292 (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
8294 2011-04-05 Alexey Proskuryakov <ap@apple.com>
8296 Reviewed by Darin Adler.
8298 Move attributedStringFromRange down to WebCore
8299 https://bugs.webkit.org/show_bug.cgi?id=57905
8301 * Misc/WebNSAttributedStringExtras.h: Removed.
8302 * Misc/WebNSAttributedStringExtras.mm: Removed.
8303 * WebView/WebHTMLRepresentation.mm:
8304 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
8305 * WebView/WebHTMLView.mm:
8306 (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
8307 (-[WebHTMLView attributedSubstringFromRange:]):
8308 (-[WebHTMLView attributedString]):
8309 (-[WebHTMLView selectedAttributedString]):
8310 * WebView/WebPDFView.mm:
8311 (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
8313 2011-04-04 MORITA Hajime <morrita@google.com>
8315 Reviewed by Ryosuke Niwa.
8317 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
8318 https://bugs.webkit.org/show_bug.cgi?id=56085
8320 Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
8321 NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
8322 for requestCheckingOfString method.
8324 * WebCoreSupport/WebEditorClient.h:
8325 * WebCoreSupport/WebEditorClient.mm:
8326 (toCoreTextCheckingResults):
8327 (WebEditorClient::checkTextOfParagraph):
8328 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
8329 (-[WebEditorSpellCheckResponder perform]):
8330 (WebEditorClient::requestCheckingOfString):
8331 * WebView/WebFrame.mm:
8332 (-[WebFrame markersForSelectionStartAsText]):
8333 * WebView/WebFramePrivate.h:
8335 2011-04-05 Anders Carlsson <andersca@apple.com>
8337 Didn't mean to land this.
8339 * Plugins/WebNetscapePluginView.mm:
8340 (-[WebNetscapePluginView getVariable:value:]):
8342 2011-04-04 David Kilzer <ddkilzer@apple.com>
8344 <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
8346 Reviewed by Alexey Proskuryakov.
8348 * WebCoreSupport/WebSystemInterface.mm:
8349 (InitWebCoreSystemInterface): Added initialization for
8350 wkSetHTTPPipeliningMaximumPriority().
8352 2011-04-04 Alexey Proskuryakov <ap@apple.com>
8354 Reviewed by Dan Bernstein.
8356 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
8357 https://bugs.webkit.org/show_bug.cgi?id=51230
8358 <rdar://problem/8780989>
8360 * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
8361 WebKits to WebCore, because WebKit shouldn't be smart.
8363 2011-04-01 Alexey Proskuryakov <ap@apple.com>
8365 Reviewed by Darin Adler.
8367 REGRESSION: Assertion failure when executing a complex custom key binding
8368 https://bugs.webkit.org/show_bug.cgi?id=57681
8370 * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
8371 commands when they can't possibly change the result.
8373 2011-04-01 Anders Carlsson <andersca@apple.com>
8375 Reviewed by Sam Weinig.
8377 Shockwave plug-in doesn't accept mouse events
8378 https://bugs.webkit.org/show_bug.cgi?id=57653
8379 <rdar://problem/8483273>
8381 Fix an unrelated bug found by the added test.
8383 * Plugins/WebBaseNetscapePluginView.mm:
8384 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
8385 Make sure to always set destX and destY.
8387 2011-04-01 Alexey Proskuryakov <ap@apple.com>
8389 Reviewed by Darin Adler.
8391 Make WebKit2 text input handling more like WebKit1
8392 https://bugs.webkit.org/show_bug.cgi?id=57649
8394 * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
8395 * WebView/WebHTMLView.mm:
8396 (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
8397 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
8398 (-[WebHTMLView characterIndexForPoint:]): Ditto.
8399 (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
8400 (-[WebHTMLView selectedRange]): Ditto.
8401 (-[WebHTMLView markedRange]): Ditto.
8402 (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
8403 (-[WebHTMLView hasMarkedText]): Ditto.
8404 (-[WebHTMLView unmarkText]): Ditto.
8405 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
8406 type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
8407 be able to call text input protocol methods from here (and we didn't even reset it back on
8408 return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
8409 (-[WebHTMLView insertText:]): Ditto.
8411 2011-04-01 Timothy Hatcher <timothy@apple.com>
8413 Make momentum scroll event latching work in WebKit2 on Mac.
8415 <rdar://problem/8751861>
8417 Reviewed by Darin Adler.
8419 * WebCoreSupport/WebSystemInterface.mm:
8420 (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
8421 * WebView/WebDynamicScrollBarsView.mm:
8422 (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
8424 2011-03-31 Darin Adler <darin@apple.com>
8426 Reviewed by Anders Carlsson.
8428 Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
8429 https://bugs.webkit.org/show_bug.cgi?id=26667
8431 * WebView/WebHTMLView.mm:
8432 (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
8433 nil rather than asserting that it is non-nil. One case where WebView will be nil
8434 is when the frame is closed, but in any case where it is nil, the correct thing
8435 to do is to not try to handle the style key.
8437 2011-03-31 Alexey Proskuryakov <ap@apple.com>
8439 Patch by John Harvey, reviewed and tweaked by me.
8441 <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
8443 * Plugins/Hosted/WebTextInputWindowController.m:
8444 (-[WebTextInputPanel _interpretKeyEvent:string:]):
8446 2011-03-31 Evan Martin <evan@chromium.org>
8448 Reviewed by Eric Seidel.
8450 <title> should support dir attribute
8451 https://bugs.webkit.org/show_bug.cgi?id=50961
8453 Update to new FrameLoaderClient interface.
8455 * WebCoreSupport/WebFrameLoaderClient.h:
8456 * WebCoreSupport/WebFrameLoaderClient.mm:
8457 (WebFrameLoaderClient::dispatchDidReceiveTitle):
8458 (WebFrameLoaderClient::setTitle):
8460 2011-03-30 Dominic Cooney <dominicc@google.com>
8462 Reviewed by Dimitri Glazkov.
8464 Adds layoutTestController.shadowRoot accessor to Mac DRT.
8465 https://bugs.webkit.org/show_bug.cgi?id=57415
8467 * DOM/WebDOMOperations.mm:
8468 (-[DOMElement _shadowRoot:]):
8469 * DOM/WebDOMOperationsPrivate.h:
8471 2011-03-30 Alexey Proskuryakov <ap@apple.com>
8473 Reviewed by Darin Adler.
8475 WebHTMLView shouldn't resend noop: commands
8476 https://bugs.webkit.org/show_bug.cgi?id=57504
8477 <rdar://problem/9209390>
8479 * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
8480 which we get e.g. when handling Cmd-key combos.
8482 2011-03-30 Alexey Proskuryakov <ap@apple.com>
8484 Reviewed by Darin Adler.
8486 REGRESSION (r82320): Spacebar no longer pages down
8487 https://bugs.webkit.org/show_bug.cgi?id=57423
8488 <rdar://problem/9207702>
8490 Also includes some unrelated cleanup that I had in my tree.
8492 * WebView/WebHTMLView.mm:
8493 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
8494 being dispatched to the right frame.
8495 (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
8496 (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
8497 Even if this specific command hasn't been handled, that doesn't nullify side effects from
8499 (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
8500 bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
8501 another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
8502 going to look at it.
8504 2011-03-30 Sam Weinig <sam@webkit.org>
8506 Reviewed by Brady Eidson.
8508 WebKit2: Attempting to view css file from url causes it to download
8509 <rdar://problem/9102611>
8510 https://bugs.webkit.org/show_bug.cgi?id=57501
8512 * WebView/WebHTMLRepresentation.h:
8513 * WebView/WebHTMLRepresentation.mm:
8514 (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
8515 * WebView/WebHTMLView.mm:
8516 (+[WebHTMLView unsupportedTextMIMETypes]):
8517 Re-factor unsupportedTextMIMETypes to pull from WebCore's
8518 MIMETypeRegistry, so that the list can be shared with WebKit2.
8520 2011-03-29 Beth Dakin <bdakin@apple.com>
8522 Reviewed by Maciej Stachowiak.
8524 Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
8525 webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
8527 <rdar://problem/8665411>
8529 * Misc/WebNSControlExtras.m:
8530 (-[NSControl sizeToFitAndAdjustWindowHeight]):
8531 * WebCoreSupport/WebChromeClient.mm:
8532 (WebChromeClient::scaleFactor):
8533 * WebView/WebHTMLView.mm:
8534 (-[WebHTMLView viewDidMoveToWindow]):
8535 (-[WebHTMLView attachRootLayer:]):
8537 2011-03-29 Kent Tamura <tkent@chromium.org>
8539 Reviewed by Dimitri Glazkov.
8541 Make validation message bubble testable
8542 https://bugs.webkit.org/show_bug.cgi?id=57290
8544 * WebView/WebView.mm:
8545 (-[WebView _preferencesChangedNotification:]): Copy the private value of
8546 the timer magnification to WebCore::Settings.
8547 (-[WebView validationMessageTimerMagnification]): Added.
8548 (-[WebView setValidationMessageTimerMagnification:]): Added.
8549 * WebView/WebViewData.h: Declare a member for the timer magnification.
8550 * WebView/WebViewData.mm:
8551 (-[WebViewPrivate init]): Initialize the timer magnification.
8552 * WebView/WebViewPrivate.h:
8553 Declare a setter and a getter for the timer magnification.
8555 2011-03-29 Kent Tamura <tkent@chromium.org>
8557 Reviewed by Dimitri Glazkov.
8559 [Mac] Enable interactive-validation tests on Mac DRT
8560 https://bugs.webkit.org/show_bug.cgi?id=57308
8562 * WebView/WebView.mm:
8563 (-[WebView _preferencesChangedNotification:]):
8564 Convey a WebView flag for interactive validation to WebCore::Settings.
8565 (-[WebView interactiveFormValidationEnabled]): Added.
8566 (-[WebView setInteractiveFormValidationEnabled:]): Added.
8567 * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
8568 * WebView/WebViewData.mm:
8569 (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
8570 * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
8572 2011-03-29 Timothy Hatcher <timothy@apple.com>
8574 Update the order of the context menu to better match AppKit on Mac.
8576 <rdar://problem/9054893>
8578 Reviewed by John Sullivan.
8580 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
8581 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
8582 * WebCoreSupport/WebPlatformStrategies.h:
8583 * WebCoreSupport/WebPlatformStrategies.mm:
8584 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
8586 2011-03-29 Alexey Proskuryakov <ap@apple.com>
8588 Reviewed by Darin Adler.
8590 https://bugs.webkit.org/show_bug.cgi?id=57379
8591 Clean up WK1 key event handling logic
8593 No bugs knowingly fixed, but this makes the code more consistent.
8595 * WebView/WebHTMLView.mm:
8596 (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
8597 eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
8598 (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
8599 from other functions. We need to execute saved commands when an input method asks for current
8600 state, because providing stale state could confuse it.
8601 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
8603 (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
8604 the answer would be stale.
8605 (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
8606 (-[WebHTMLView selectedRange]): Ditto.
8607 (-[WebHTMLView markedRange]): Ditto.
8608 (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
8609 (-[WebHTMLView hasMarkedText]): Ditto.
8610 (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
8611 operating on stale data. Also, updated for eventWasHandled renaming.
8612 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
8613 (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
8614 it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
8615 fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
8616 could have a noop: as one of its commands, although that's hardly practical).
8617 Added the same "from input method" logic that we have in insertText: - I don't know of any
8618 IMs that call this method, but we clearly need to execute it as part of IM processing when
8619 there is marked text.
8620 (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
8621 eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
8622 if current selection isn't editable. This is different from doCommandBySelector:, where we
8623 need to give super class a chance to handle the event if our processing fails.
8624 Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
8625 return value of _interpretKeyEvent is computed differently.
8627 2011-03-28 Adele Peterson <adele@apple.com>
8629 Reviewed by Eric Seidel.
8631 Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
8632 https://bugs.webkit.org/show_bug.cgi?id=57173
8634 * WebView/WebFrame.mm:
8635 (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
8636 (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
8637 * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
8639 2011-03-28 Alexey Proskuryakov <ap@apple.com>
8641 Reviewed by Darin Adler.
8643 https://bugs.webkit.org/show_bug.cgi?id=57260
8644 Clean up text input code a little
8646 * WebCoreSupport/WebEditorClient.mm:
8647 (WebEditorClient::handleKeyboardEvent):
8648 (WebEditorClient::handleInputMethodKeydown):
8649 * WebView/WebHTMLViewInternal.h:
8650 Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
8651 anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
8652 and also possibly saves resulting commands for later execution.
8654 * WebView/WebHTMLView.mm:
8655 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
8656 return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
8657 WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
8658 handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
8659 because the first call resulted in no saved commands, becasue it's confusing and apparently
8660 useless (I couldn't find any broken behavior).
8661 (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
8662 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
8663 (-[WebHTMLView doCommandBySelector:]): Ditto.
8664 (-[WebHTMLView insertText:]): Ditto.
8666 * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
8669 2011-03-27 Jer Noble <jer.noble@apple.com>
8671 Reviewed by Maciej Stachowiak.
8673 Full Screen: disable keyboard access by default
8674 https://bugs.webkit.org/show_bug.cgi?id=56684
8676 Take into account whether keyboard access was requested when deciding whether full
8677 screen mode is supported.
8679 * WebCoreSupport/WebChromeClient.h:
8680 * WebCoreSupport/WebChromeClient.mm:
8681 (WebChromeClient::supportsFullScreenForElement):
8682 * WebView/WebView.mm:
8683 (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
8684 * WebView/WebViewInternal.h:
8686 2011-03-26 Jer Noble <jer.noble@apple.com>
8688 Reviewed by Eric Carlson.
8690 Enable the Full Screen API by default in WebKit/mac and WebKit2
8691 https://bugs.webkit.org/show_bug.cgi?id=56956
8693 * WebView/WebPreferences.mm:
8694 (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
8696 2011-03-25 Andy Estes <aestes@apple.com>
8698 Reviewed by Adele Peterson.
8700 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
8701 https://bugs.webkit.org/show_bug.cgi?id=49016
8703 Update objectContentType() implementation to handle the
8704 shouldPreferPlugInsForImages flag.
8706 * WebCoreSupport/WebFrameLoaderClient.h:
8707 * WebCoreSupport/WebFrameLoaderClient.mm:
8708 (WebFrameLoaderClient::objectContentType):
8710 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
8712 Unreviewed, rolling out r81939.
8713 http://trac.webkit.org/changeset/81939
8714 https://bugs.webkit.org/show_bug.cgi?id=57084
8716 Rolling out 81939, as it's causing a number of app cache test
8717 failures. (Requested by jernoble on #webkit).
8719 * WebView/WebView.mm:
8720 (-[WebView _preferencesChangedNotification:]):
8722 2011-03-23 Jer Noble <jer.noble@apple.com>
8724 Reviewed by Maciej Stachowiak.
8726 Application Cache should save audio/ and video/ mime types as flat files
8727 https://bugs.webkit.org/show_bug.cgi?id=53784
8728 <rdar://problem/8932473>
8732 Initialize the AppCache Total size quotas with the values for WebKitPreferences
8735 * WebView/WebView.mm:
8736 (-[WebView _preferencesChangedNotification:]):
8738 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
8740 Unreviewed, rolling out r81916 and r81917.
8741 http://trac.webkit.org/changeset/81916
8742 http://trac.webkit.org/changeset/81917
8743 https://bugs.webkit.org/show_bug.cgi?id=57071
8745 broke a test on platforms that do not have QuickTime installed
8746 (Requested by estes on #webkit).
8748 * WebCoreSupport/WebFrameLoaderClient.h:
8749 * WebCoreSupport/WebFrameLoaderClient.mm:
8750 (WebFrameLoaderClient::objectContentType):
8752 2011-03-24 Andy Estes <aestes@apple.com>
8754 Reviewed by Darin Adler.
8756 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
8757 https://bugs.webkit.org/show_bug.cgi?id=49016
8759 Update objectContentType() implementation to handle the
8760 shouldPreferPlugInsForImages flag.
8762 * WebCoreSupport/WebFrameLoaderClient.h:
8763 * WebCoreSupport/WebFrameLoaderClient.mm:
8764 (WebFrameLoaderClient::objectContentType):
8766 2011-03-24 Geoffrey Garen <ggaren@apple.com>
8768 Reviewed by Oliver Hunt.
8770 Ensure that all compilation takes place within a dynamic global object scope
8771 https://bugs.webkit.org/show_bug.cgi?id=57054
8773 * WebView/WebScriptDebugDelegate.mm:
8774 (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
8776 2011-03-24 Jia Pu <jpu@apple.com>
8778 Reviewed by Darin Adler.
8780 Dismissed reversion suggestion is incorrectly learned.
8781 https://bugs.webkit.org/show_bug.cgi?id=57039
8783 CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
8784 [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
8785 is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
8786 incorrect automatic learning.
8788 * WebCoreSupport/CorrectionPanel.mm:
8789 (CorrectionPanel::dismissInternal):
8791 2011-03-24 David Kilzer <ddkilzer@apple.com>
8793 <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
8795 Reviewed by Joseph Pecoraro.
8797 * Plugins/WebPluginContainerPrivate.h: Changed value of
8798 ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
8800 2011-03-23 Jia Pu <jpu@apple.com>
8802 Reviewed by Darin Adler.
8804 Hook up new AppKit autocorrection UI with WK2.
8805 https://bugs.webkit.org/show_bug.cgi?id=56055
8806 <rdar://problem/8947463>
8808 Please see WebCore/ChangeLog for detail.
8810 * WebCoreSupport/CorrectionPanel.h: Added.
8811 (CorrectionPanel::isShowing):
8812 * WebCoreSupport/CorrectionPanel.mm: Added.
8813 (correctionBubbleType):
8814 (CorrectionPanel::CorrectionPanel):
8815 (CorrectionPanel::~CorrectionPanel):
8816 (CorrectionPanel::show):
8817 (CorrectionPanel::dismiss):
8818 (CorrectionPanel::dismissSoon):
8819 (CorrectionPanel::dismissInternal):
8820 (CorrectionPanel::recordAutocorrectionResponse):
8821 * WebCoreSupport/WebEditorClient.h:
8822 * WebCoreSupport/WebEditorClient.mm:
8823 (WebEditorClient::WebEditorClient):
8824 (WebEditorClient::showCorrectionPanel):
8825 (WebEditorClient::dismissCorrectionPanel):
8826 (WebEditorClient::dismissCorrectionPanelSoon):
8827 (WebEditorClient::recordAutocorrectionResponse):
8828 * WebView/WebView.mm:
8829 (-[WebView handleCorrectionPanelResult:]):
8830 * WebView/WebViewPrivate.h:
8832 2011-03-23 Enrica Casucci <enrica@apple.com>
8834 Reviewed by Alexey Proskuryakov.
8836 Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
8837 https://bugs.webkit.org/show_bug.cgi?id=56974
8838 <rdar://problem/8284642>
8840 This fixes a regression introduced by http://trac.webkit.org/changeset/61794
8841 where readSelectionFromPasteboard was accidentally removed.
8842 This method and writeSelectionToPasteboard are needed to support Mac OS X
8845 * WebView/WebHTMLView.mm:
8846 (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
8847 (-[WebHTMLView readSelectionFromPasteboard:]): Added.
8849 2011-03-23 Brady Eidson <beidson@apple.com>
8851 Reviewed by Sam Weinig.
8853 Change IconDatabase opening to allow for arbitrary filenames
8854 https://bugs.webkit.org/show_bug.cgi?id=56977
8856 * Misc/WebIconDatabase.mm:
8857 (-[WebIconDatabase _startUpIconDatabase]):
8859 2011-03-22 Anton D'Auria <adauria@apple.com>
8861 Reviewed by Alexey Proskuryakov.
8863 Add +[WebApplicationCache getOriginsWithCache]
8864 https://bugs.webkit.org/show_bug.cgi?id=56722
8866 Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
8868 * WebCoreSupport/WebApplicationCache.h:
8869 * WebCoreSupport/WebApplicationCache.mm:
8870 (+[WebApplicationCache originsWithCache]):
8872 2011-03-22 Anders Carlsson <andersca@apple.com>
8874 Reviewed by Sam Weinig.
8876 OBJECT element with DivX source is always downloaded
8877 https://bugs.webkit.org/show_bug.cgi?id=56879
8879 * Plugins/WebBasePluginPackage.mm:
8880 (-[WebBasePluginPackage getPluginInfoFromPLists]):
8881 Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
8882 specifies multiple file extensions in a single element.
8884 2011-03-22 Brady Eidson <beidson@apple.com>
8886 Reviewed by Sam Weinig.
8888 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
8889 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
8891 Note that while the new client calls always come through on the main thread, our mechanisms to
8892 route dispatches to the main thread are still valid and will still work.
8894 Update to the new IconDatabaseClient interface:
8895 * WebCoreSupport/WebIconDatabaseClient.h:
8896 * WebCoreSupport/WebIconDatabaseClient.mm:
8897 (WebIconDatabaseClient::didRemoveAllIcons):
8898 (WebIconDatabaseClient::didImportIconURLForPageURL):
8899 (WebIconDatabaseClient::didImportIconDataForPageURL):
8900 (WebIconDatabaseClient::didChangeIconForPageURL):
8901 (WebIconDatabaseClient::didFinishURLImport):
8903 2011-03-22 Matthew Delaney <mdelaney@apple.com>
8905 Reviewed by Simon Fraser.
8907 Have WebKit push acceleratedDrawing preferences to settings
8908 https://bugs.webkit.org/show_bug.cgi?id=56792
8910 * WebView/WebView.mm:
8912 2011-03-21 Nate Chapin <japhet@chromium.org>
8914 Reviewed by Brady Eidson.
8916 Expose a preference to use caching quirks for QuickLook,
8917 and use it if the QuickLook framework is loaded.
8919 https://bugs.webkit.org/show_bug.cgi?id=38690
8921 * WebView/WebPreferenceKeysPrivate.h:
8922 * WebView/WebPreferences.mm:
8923 (useQuickLookQuirks):
8924 (+[WebPreferences initialize]):
8925 (-[WebPreferences useQuickLookResourceCachingQuirks]):
8926 * WebView/WebPreferencesPrivate.h:
8927 * WebView/WebView.mm:
8928 (-[WebView _preferencesChangedNotification:]):
8930 2011-03-21 Chris Fleizach <cfleizach@apple.com>
8932 Reviewed by Darin Adler.
8934 AX: showContextMenu not working in WK2
8935 https://bugs.webkit.org/show_bug.cgi?id=56734
8937 Implement showContextMenu() so accessibility related code can call this
8938 independent of whether WK1 or WK2 is running.
8940 * WebCoreSupport/WebChromeClient.h:
8941 * WebCoreSupport/WebChromeClient.mm:
8942 (WebChromeClient::showContextMenu):
8944 2011-03-21 Chang Shu <cshu@webkit.org>
8946 Reviewed by Alexey Proskuryakov.
8948 REGRESSION (r79953): Can't type in MS Outlook 2011
8949 https://bugs.webkit.org/show_bug.cgi?id=56665
8951 r79953 removed the WebView level editablity which is persistent no matter whether
8952 underlying document itself is changed and editability gets lost. The resolution is to
8953 set this WebView editable value to WebCore. This avoids the callback from WebCore to
8954 WebKit which was the main goal in r79953 to improve performance.
8956 * WebView/WebView.mm:
8957 (-[WebView setEditable:]):
8958 (-[WebView isEditable]):
8960 2011-03-19 Anton D'Auria <adauria@apple.com>
8962 Reviewed by Alexey Proskuryakov.
8964 ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
8965 https://bugs.webkit.org/show_bug.cgi?id=56415
8967 Use new ApplicationCache API to delete all cache for an origin.
8969 * WebCoreSupport/WebApplicationCache.h:
8970 * WebCoreSupport/WebApplicationCache.mm:
8971 (+[WebApplicationCache deleteOrigin:]):
8973 2011-03-17 Brady Eidson <beidson@apple.com>
8975 Reviewed by Sam Weinig.
8977 https://bugs.webkit.org/show_bug.cgi?id=56425
8978 More groundwork for WebKit2 IconDatabase
8980 Update already-used function names:
8981 * Misc/WebIconDatabase.mm:
8982 (-[WebIconDatabase iconForURL:withSize:cache:]):
8983 (-[WebIconDatabase iconURLForURL:]):
8984 * WebView/WebView.mm:
8985 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
8987 2011-03-18 Pavel Podivilov <podivilov@chromium.org>
8989 Reviewed by Yury Semikhatsky.
8991 Web Inspector: implement inspector session storage.
8992 https://bugs.webkit.org/show_bug.cgi?id=56643
8994 * WebCoreSupport/WebInspectorClient.h:
8995 * WebCoreSupport/WebInspectorClient.mm:
8996 (WebInspectorClient::saveSessionSetting):
8997 (WebInspectorClient::loadSessionSetting):
8998 (WebInspectorFrontendClient::saveSessionSetting):
8999 (WebInspectorFrontendClient::loadSessionSetting):
9000 (-[WebInspectorWindowController inspectorClient]):
9002 2011-03-17 Geoffrey Garen <ggaren@apple.com>
9004 Reviewed by Oliver Hunt.
9006 Fixed a leak seen on the buildbot.
9008 * WebCoreSupport/WebInspectorClient.mm:
9009 (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
9011 2011-03-16 Jeff Johnson <github@lapcatsoftware.com>
9013 Reviewed by Alexey Proskuryakov.
9015 Logic error in -[WebHTMLView close]
9016 https://bugs.webkit.org/show_bug.cgi?id=56445
9018 Page is always nil at this point, because [self _webView] is nil,
9019 so the conditional code is never run.
9021 * WebView/WebHTMLView.mm:
9022 (-[WebHTMLView close]):
9024 2011-03-16 Chris Fleizach <cfleizach@apple.com>
9026 Reviewed by Darin Adler.
9028 WK2: Need to propagate enhanced accessibility flag from UI -> web process
9029 https://bugs.webkit.org/show_bug.cgi?id=56379
9031 * WebView/WebFrame.mm:
9032 (-[WebFrame accessibilityRoot]):
9034 2011-03-15 Oliver Hunt <oliver@apple.com>
9036 Reviewed by Geoffrey Garen.
9038 Make Structure creation require a JSGlobalData
9039 https://bugs.webkit.org/show_bug.cgi?id=56438
9041 Mechanical change to make all Structure creation use a JSGlobalData&
9043 * Plugins/Hosted/ProxyInstance.mm:
9044 (WebKit::ProxyRuntimeMethod::createStructure):
9045 * Plugins/Hosted/ProxyRuntimeObject.h:
9046 (WebKit::ProxyRuntimeObject::createStructure):
9048 2011-03-15 Alexey Proskuryakov <ap@apple.com>
9050 Forgot to save a modification to this file when committing.
9052 * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
9054 2011-03-15 Alexey Proskuryakov <ap@apple.com>
9056 Reviewed by Darin Adler.
9058 REGRESSION (WebKit2): keygen element doesn't work
9059 https://bugs.webkit.org/show_bug.cgi?id=56402
9060 <rdar://problem/9006545>
9062 * WebCoreSupport/WebKeyGenerator.h:
9063 * WebCoreSupport/WebKeyGenerator.m: Removed.
9064 * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
9065 (+[WebKeyGenerator sharedGenerator]):
9066 (toWebCertificateParseResult):
9067 WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
9068 this misnamed and misplaced code for now.
9070 * WebCoreSupport/WebPlatformStrategies.h:
9071 * WebCoreSupport/WebPlatformStrategies.mm:
9072 (WebPlatformStrategies::keygenMenuItem512):
9073 (WebPlatformStrategies::keygenMenuItem1024):
9074 (WebPlatformStrategies::keygenMenuItem2048):
9075 (WebPlatformStrategies::keygenKeychainItemName):
9076 Added strings used by keygen.
9078 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
9079 pointer to a function used by keygen.
9081 * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
9084 2011-03-15 Beth Dakin <bdakin@apple.com>
9086 Reviewed by Simon Fraser.
9088 WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
9090 New WebKitystemInterface function to force the scrollbars to flash
9091 * WebCoreSupport/WebSystemInterface.mm:
9092 (InitWebCoreSystemInterface):
9094 2011-03-15 Ilya Sherman <isherman@chromium.org>
9096 Reviewed by Tony Chang.
9098 Autofilled form elements are assigned fixed background color but not text color
9099 https://bugs.webkit.org/show_bug.cgi?id=48382
9101 * DOM/WebDOMOperations.mm:
9102 (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
9103 * DOM/WebDOMOperationsPrivate.h:
9105 2011-03-15 Adam Roben <aroben@apple.com>
9107 Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
9109 Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
9110 WebStorageTrackerClient::dispatchDidModifyOrigin
9112 Reviewed by Antti Koivisto.
9114 * Storage/WebStorageTrackerClient.mm:
9115 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
9116 to us by dispatchDidModifyOrigin.
9117 (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
9120 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
9122 Reviewed by Darin Adler.
9124 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
9125 info into the headers rather than in export symbol definition files, but disable it on
9126 all platforms initially so we can deal with port build issues one port at a time.
9128 https://bugs.webkit.org/show_bug.cgi?id=27551
9132 2011-03-14 Brady Eidson <beidson@apple.com>
9134 Reviewed by Anders Carlsson.
9136 https://bugs.webkit.org/show_bug.cgi?id=56320
9137 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
9139 * History/WebHistoryItem.mm:
9140 (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
9142 2011-03-13 Pratik Solanki <psolanki@apple.com>
9144 Reviewed by Brady Eidson.
9146 Make adjustMIMETypeIfNecessary use CFNetwork directly
9147 https://bugs.webkit.org/show_bug.cgi?id=55912
9149 * WebCoreSupport/WebSystemInterface.mm:
9150 (InitWebCoreSystemInterface): Support for new WKSI functions.
9152 2011-03-12 Mark Rowe <mrowe@apple.com>
9154 Fix the 32-bit build.
9156 * Carbon/CarbonWindowAdapter.mm:
9157 (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
9158 (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
9160 2011-03-11 Brady Eidson <beidson@apple.com>
9162 Reviewed by Anders Carlsson
9164 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
9165 Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
9167 * Misc/WebIconDatabase.mm:
9168 (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
9169 (-[WebIconDatabase _startUpIconDatabase]): Ditto.
9170 (importToWebCoreFormat):
9172 2011-03-11 Anton D'Auria <adauria@apple.com>
9174 Reviewed and landed by Brady Eidson.
9176 https://bugs.webkit.org/show_bug.cgi?id=51878
9177 Add WebKit1 API to view and delete local storage
9179 * Storage/WebStorageManager.mm: Added.
9180 (+[WebStorageManager sharedWebStorageManager]):
9181 (-[WebStorageManager origins]):
9182 (-[WebStorageManager deleteAllOrigins]):
9183 (-[WebStorageManager deleteOrigin:]):
9184 (-[WebStorageManager syncLocalStorage]):
9185 (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
9186 (storageDirectoryPath):
9187 (WebKitInitializeStorageIfNecessary):
9188 * Storage/WebStorageManagerInternal.h: Added.
9189 * Storage/WebStorageManagerPrivate.h: Added.
9190 * Storage/WebStorageTrackerClient.h: Added.
9191 * Storage/WebStorageTrackerClient.mm: Added.
9192 (WebStorageTrackerClient::sharedWebStorageTrackerClient):
9193 (WebStorageTrackerClient::WebStorageTrackerClient):
9194 (WebStorageTrackerClient::~WebStorageTrackerClient):
9195 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
9196 (WebStorageTrackerClient::dispatchDidModifyOrigin):
9197 * WebCoreSupport/WebSecurityOrigin.mm:
9198 (-[WebSecurityOrigin protocol]):
9199 (-[WebSecurityOrigin host]):
9200 (-[WebSecurityOrigin databaseIdentifier]):
9201 (-[WebSecurityOrigin domain]):
9202 (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
9203 * WebCoreSupport/WebSecurityOriginPrivate.h:
9205 * WebView/WebView.mm:
9206 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
9208 2011-03-10 Anders Carlsson <andersca@apple.com>
9210 Reviewed by Sam Weinig.
9212 <rdar://problem/9117047>
9213 Don't paint more than 60 times per second even when scrolling
9215 * WebView/WebClipView.mm:
9216 (-[WebClipView _immediateScrollToPoint:]):
9218 2011-03-09 Matthew Delaney <mdelaney@apple.com>
9220 Reviewed by Simon Fraser.
9222 Plumb through settings for accelerated drawing for canvas
9223 https://bugs.webkit.org/show_bug.cgi?id=56039
9225 * WebView/WebPreferenceKeysPrivate.h:
9226 * WebView/WebPreferences.mm:
9227 * WebView/WebPreferencesPrivate.h:
9229 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
9231 Reviewed by Tony Chang.
9233 VisiblePosition's next and previous should take an enum instead of a boolean
9234 https://bugs.webkit.org/show_bug.cgi?id=56135
9236 SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
9237 StayInEditableContent.
9239 * WebView/WebView.mm:
9240 (-[WebView _selectionIsAll]):
9242 2011-03-09 Jessie Berlin <jberlin@apple.com>
9244 Reviewed by Adam Roben.
9246 Use the Cookie Storage from the Private Browsing Storage Session directly
9247 https://bugs.webkit.org/show_bug.cgi?id=55986
9249 * WebCoreSupport/WebSystemInterface.mm:
9250 (InitWebCoreSystemInterface):
9252 2011-03-08 Darin Adler <darin@apple.com>
9254 Reviewed by Timothy Hatcher.
9256 Promote a method used outside WebKit from internal to private
9257 https://bugs.webkit.org/show_bug.cgi?id=55949
9259 * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
9260 Minor tweak, not directly related to the rest of this patch.
9262 * WebView/WebFrame.mm:
9263 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
9264 this method from the internal category into the private category.
9265 Streamlined the code a bit.
9267 * WebView/WebFrameInternal.h: Removed _computePageRects method.
9268 * WebView/WebFramePrivate.h: Added _computePageRects method.
9270 2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
9272 Reviewed by Darin Adler.
9274 selectionHasStyle and selectionStartHasStyle should use EditingStyle
9275 https://bugs.webkit.org/show_bug.cgi?id=55902
9277 selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
9279 * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
9280 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
9282 2011-03-07 Dan Bernstein <mitz@apple.com>
9284 LLVM Compiler build fix.
9286 * WebCoreSupport/WebEditorClient.mm:
9287 (WebEditorClient::checkGrammarOfString):
9289 2011-03-07 Chris Fleizach <cfleizach@apple.com>
9291 Reviewed by Beth Dakin.
9293 AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
9294 https://bugs.webkit.org/show_bug.cgi?id=55706
9296 Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
9297 returns the scroll bar objects).
9298 Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
9299 will expect that as its child, instead of the WebCore ScrollView object.
9301 * WebView/WebDynamicScrollBarsView.mm:
9302 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
9303 * WebView/WebFrame.mm:
9304 (-[WebFrame accessibilityRoot]):
9306 2011-03-07 Sam Weinig <sam@webkit.org>
9308 Reviewed by Anders Carlsson.
9310 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
9311 https://bugs.webkit.org/show_bug.cgi?id=55827
9313 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
9314 and pass the entire response, instead of just the MIMEType.
9316 * WebCoreSupport/WebFrameLoaderClient.h:
9317 * WebCoreSupport/WebFrameLoaderClient.mm:
9318 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
9320 2011-03-06 Dan Bernstein <mitz@apple.com>
9322 LLVM Compiler build fix.
9324 * DOM/WebDOMOperations.mm:
9325 (-[DOMHTMLInputElement _setValueForUser:]):
9327 2011-03-06 Jessie Berlin <jberlin@apple.com>
9329 Reviewed by Sam Weinig.
9331 WebKit2: Use CFNetwork Sessions API.
9332 https://bugs.webkit.org/show_bug.cgi?id=55435.
9334 When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
9335 Private Browsing Storage Session.
9337 * WebCoreSupport/WebSystemInterface.mm:
9338 (InitWebCoreSystemInterface):
9339 Add support for using the new WKSI functions in WebCore.
9341 2011-03-05 Ilya Sherman <isherman@chromium.org>
9343 Reviewed by Darin Adler.
9345 HTMLInputElement::setValue() should schedule change event when the element is focused
9346 In service of https://code.google.com/p/chromium/issues/detail?id=42716
9347 https://bugs.webkit.org/show_bug.cgi?id=53160
9349 * DOM/WebDOMOperations.mm:
9350 (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
9351 * DOM/WebDOMOperationsPrivate.h:
9352 * WebView/WebViewInternal.h:
9354 2011-03-04 Jia Pu <jpu@apple.com>
9356 Reviewed by Darin Adler.
9358 On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
9359 https://bugs.webkit.org/show_bug.cgi?id=55717
9360 <rdar://problem/9018127>
9362 With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
9363 is already in window coordinate. We don't need to do further conversion anymore.
9365 * WebCoreSupport/WebEditorClient.mm:
9366 (WebEditorClient::showCorrectionPanel):
9368 2011-03-04 Jessie Berlin <jberlin@apple.com>
9370 Reviewed by Maciej Stachowiak.
9372 WebKit2: Use CFNetwork Sessions API.
9373 https://bugs.webkit.org/show_bug.cgi?id=55435.
9375 When Private Browsing is enabled, get the cached url response from the cache associated with
9376 the Private Browsing Storage Session.
9378 * WebView/WebView.mm:
9379 (-[WebView _cachedResponseForURL:]):
9381 2011-03-03 Anders Carlsson <andersca@apple.com>
9383 Reviewed by Sam Weinig.
9385 Get rid of Page::globalHistoryItem
9386 https://bugs.webkit.org/show_bug.cgi?id=55738
9388 * WebCoreSupport/WebFrameLoaderClient.h:
9389 * WebCoreSupport/WebFrameLoaderClient.mm:
9390 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
9391 Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
9393 * WebView/WebView.mm:
9394 (-[WebView _globalHistoryItem]):
9395 (-[WebView _setGlobalHistoryItem:]):
9396 Set _globalHistoryItem ivar.
9398 * WebView/WebViewData.h:
9399 * WebView/WebViewData.mm:
9400 Add _globalHistoryItem ivar.
9402 2011-03-03 Brady Eidson <beidson@apple.com>
9404 Reviewed by Darin Adler.
9406 https://bugs.webkit.org/show_bug.cgi?id=55721
9407 Global IconDatabase should be returned by reference, not as a pointer
9409 * Misc/WebCoreStatistics.mm:
9410 (+[WebCoreStatistics iconPageURLMappingCount]):
9411 (+[WebCoreStatistics iconRetainedPageURLCount]):
9412 (+[WebCoreStatistics iconRecordCount]):
9413 (+[WebCoreStatistics iconsWithDataCount]):
9414 * Misc/WebIconDatabase.mm:
9415 (-[WebIconDatabase init]):
9416 (-[WebIconDatabase iconForURL:withSize:cache:]):
9417 (-[WebIconDatabase iconURLForURL:]):
9418 (-[WebIconDatabase defaultIconWithSize:]):
9419 (-[WebIconDatabase retainIconForURL:]):
9420 (-[WebIconDatabase releaseIconForURL:]):
9421 (-[WebIconDatabase isEnabled]):
9422 (-[WebIconDatabase setEnabled:]):
9423 (-[WebIconDatabase removeAllIcons]):
9424 (+[WebIconDatabase _checkIntegrityBeforeOpening]):
9425 (-[WebIconDatabase _startUpIconDatabase]):
9426 (-[WebIconDatabase _applicationWillTerminate:]):
9427 (-[WebIconDatabase _resetCachedWebPreferences:]):
9428 (importToWebCoreFormat):
9429 * WebView/WebView.mm:
9430 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
9432 2011-03-03 Jessie Berlin <jberlin@apple.com>
9434 Reviewed by Adam Roben.
9436 WebKit2: Use CFNetwork Sessions API.
9437 https://bugs.webkit.org/show_bug.cgi?id=55435.
9439 Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
9441 * WebCoreSupport/WebSystemInterface.mm:
9442 (InitWebCoreSystemInterface):
9443 Support using WKCopyRequestWithStorageSession in WebCore.
9445 2011-03-02 Alexey Proskuryakov <ap@apple.com>
9447 Reviewed by Darin Adler.
9449 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
9450 https://bugs.webkit.org/show_bug.cgi?id=55633
9451 <rdar://problem/8963023>
9453 * WebCoreSupport/WebChromeClient.h:
9454 * WebCoreSupport/WebChromeClient.mm:
9455 Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
9457 * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
9458 Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
9459 require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
9460 so I've preserved it.
9462 2011-03-02 Jessie Berlin <jberlin@apple.com>
9464 Rubber-stamped by Dan Bernstein.
9466 Fix crashes in private browsing tests in WK1 on Snow Leopard.
9468 * WebCoreSupport/WebSystemInterface.mm:
9469 (InitWebCoreSystemInterface):
9470 Put the INIT call for wkCreatePrivateStorageSession outside of the
9471 #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
9474 2011-03-02 Jessie Berlin <jberlin@apple.com>
9476 Reviewed by Adam Roben.
9478 WebKit2: Use CFNetwork Sessions API.
9479 https://bugs.webkit.org/show_bug.cgi?id=55435.
9481 Add the ability to create a Private Browsing Storage Session.
9483 * WebCoreSupport/WebSystemInterface.mm:
9484 (InitWebCoreSystemInterface):
9485 Support calling wkCreatePrivateStorageSession from WebCore.
9487 2011-03-02 Daniel Cheng <dcheng@chromium.org>
9489 Reviewed by David Levin.
9491 Add feature define for data transfer items
9492 https://bugs.webkit.org/show_bug.cgi?id=55510
9494 * Configurations/FeatureDefines.xcconfig:
9496 2011-03-02 Sam Weinig <sam@webkit.org>
9498 Reviewed by Anders Carlsson.
9500 Fix remaining localization issues by piping all localized strings through WebCore's
9501 localization bottleneck.
9502 <rdar://problem/8728860>
9504 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
9505 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
9506 * Misc/WebKitErrors.m:
9507 * Misc/WebLocalizableStringsInternal.h: Added.
9508 * Misc/WebLocalizableStringsInternal.mm: Added.
9509 (WebLocalizedStringInternal):
9510 * Panels/WebAuthenticationPanel.m:
9511 (-[WebAuthenticationPanel setUpForChallenge:]):
9512 * Plugins/Hosted/NetscapePluginHostManager.mm:
9513 (WebKit::NetscapePluginHostManager::spawnPluginHost):
9514 * WebCoreSupport/WebEditorClient.mm:
9515 (undoNameForEditAction):
9516 * WebCoreSupport/WebInspectorClient.mm:
9517 (WebInspectorFrontendClient::updateWindowTitle):
9518 (-[WebInspectorWindowController validateUserInterfaceItem:]):
9519 * WebCoreSupport/WebKeyGenerator.m:
9520 (-[WebKeyGenerator strengthMenuItemTitles]):
9521 (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
9522 * WebCoreSupport/WebPlatformStrategies.mm:
9523 * WebView/WebHTMLView.mm:
9524 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
9525 * WebView/WebPDFView.mm:
9526 (-[WebPDFView menuForEvent:]):
9528 2011-03-01 Brian Weinstein <bweinstein@apple.com>
9530 Reviewed by Adam Roben.
9532 Part of WebKit2: Need a way to send notifications to client when cookies change
9533 https://bugs.webkit.org/show_bug.cgi?id=55427
9534 <rdar://problem/9056027>
9536 Add stubs for CookiesStrategy on Mac WebKit1.
9538 * WebCoreSupport/WebPlatformStrategies.h:
9539 * WebCoreSupport/WebPlatformStrategies.mm:
9540 (WebPlatformStrategies::createCookiesStrategy):
9541 (WebPlatformStrategies::notifyCookiesChanged):
9543 2011-03-01 Philippe Normand <pnormand@igalia.com>
9545 Reviewed by Eric Carlson.
9547 [GStreamer] support in mac video fullscreen controller
9548 https://bugs.webkit.org/show_bug.cgi?id=52280
9550 Factored the code to configure the video overlay in a new private
9551 method of the controller and added GStreamer support to it.
9553 * WebView/WebVideoFullscreenController.h:
9554 * WebView/WebVideoFullscreenController.mm:
9555 (-[WebVideoFullscreenController setupVideoOverlay:]):
9556 (-[WebVideoFullscreenController windowDidLoad]):
9557 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
9558 (-[WebVideoFullscreenController windowDidExitFullscreen]):
9560 2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
9562 Reviewed by Timothy Hatcher.
9564 All Console Messages should be passed to ChromeClients.
9565 https://bugs.webkit.org/show_bug.cgi?id=54926
9567 Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
9568 which supersedes -webView:addMessageToConsole if it exists. The new delegate
9569 does not filter to only JavaScript originated console messages. The old
9570 delegate is left around for clients that expect filtered messages, like
9571 DashCode and older versions of Safari.
9573 The dictionary message passed to the delegate now includes more information
9574 about the message source, type, and level.
9576 * WebCoreSupport/WebChromeClient.mm:
9577 (stringForMessageSource):
9578 (stringForMessageType):
9579 (stringForMessageLevel):
9580 (WebChromeClient::addMessageToConsole):
9581 * WebView/WebUIDelegatePrivate.h:
9583 2011-03-01 Levi Weintraub <leviw@chromium.org>
9585 Reviewed by Ryosuke Niwa.
9587 Stop instantiating legacy editing Positions in VisiblePosition
9588 https://bugs.webkit.org/show_bug.cgi?id=52919
9590 Changing usage of legacy VisiblePosition constructor. Since we were dealing
9591 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
9593 * WebView/WebFrame.mm:
9594 (-[WebFrame _caretRectAtPosition:affinity:]):
9595 * WebView/WebFrameInternal.h:
9596 * WebView/WebTextCompletionController.mm:
9597 (-[WebTextCompletionController doCompletion]):
9599 2011-03-01 Sam Weinig <sam@webkit.org>
9601 Reviewed by Timothy Hatcher.
9603 WebKit2 needs to be made localizable
9604 https://bugs.webkit.org/show_bug.cgi?id=55483
9606 * WebCoreSupport/WebPlatformStrategies.mm:
9607 Use WebCore's localizedString function instead of WebLocalizableStrings
9608 since WebCore is now responsible for localization.
9610 2011-02-25 Steve Block <steveblock@google.com>
9612 Reviewed by Jeremy Orlow.
9614 Bridge.h should not include BridgeJSC.h
9615 https://bugs.webkit.org/show_bug.cgi?id=55212
9617 Include BridgeJSC.h directly instead.
9619 * Plugins/Hosted/ProxyInstance.h:
9620 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
9622 2011-02-28 Chang Shu <cshu@webkit.org>
9624 Reviewed by Ryosuke Niwa.
9626 Remove the support of Frame::isContentEditable and its dependencies.
9627 https://bugs.webkit.org/show_bug.cgi?id=54292
9629 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
9631 * WebCoreSupport/WebEditorClient.h:
9632 * WebCoreSupport/WebEditorClient.mm:
9633 * WebView/WebView.mm:
9634 (-[WebView setEditable:]):
9635 (-[WebView isEditable]):
9636 * WebView/WebViewData.h:
9638 2011-02-28 Oliver Hunt <oliver@apple.com>
9640 Reviewed by Gavin Barraclough.
9642 Make ScopeChainNode GC allocated
9643 https://bugs.webkit.org/show_bug.cgi?id=55283
9645 More updates for the absence of the ScopeChain class
9647 * WebView/WebScriptDebugDelegate.mm:
9648 (-[WebScriptCallFrame scopeChain]):
9650 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
9652 Reviewed by Pavel Feldman.
9654 DumpRenderTree should reset frame opener between tests.
9655 https://bugs.webkit.org/show_bug.cgi?id=54874
9657 Added clearOpener method to WebFramePrivate.
9659 * WebView/WebFrame.mm:
9660 (-[WebFrame _clearOpener]):
9661 * WebView/WebFramePrivate.h:
9663 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
9665 Unreviewed, rolling out r79764.
9666 http://trac.webkit.org/changeset/79764
9667 https://bugs.webkit.org/show_bug.cgi?id=55295
9669 "broke Chromium builds" (Requested by rniwa on #webkit).
9671 * WebView/WebFrame.mm:
9672 * WebView/WebFramePrivate.h:
9674 2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
9676 Reviewed by David Kilzer.
9678 https://bugs.webkit.org/show_bug.cgi?id=48781
9680 Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
9682 Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
9683 should paint the default broken image when an image fails to load or decode. The method also passes the
9684 URL of the failed image.
9686 * WebCoreSupport/WebFrameLoaderClient.h:
9687 * WebCoreSupport/WebFrameLoaderClient.mm:
9688 (WebFrameLoaderClient::shouldPaintBrokenImage):
9689 * WebView/WebDelegateImplementationCaching.h:
9690 * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
9691 (CallResourceLoadDelegateReturningBoolean):
9692 * WebView/WebResourceLoadDelegatePrivate.h:
9693 * WebView/WebView.mm:
9694 (-[WebView _cacheResourceLoadDelegateImplementations]):
9696 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
9698 Reviewed by Pavel Feldman.
9700 DumpRenderTree should reset frame opener between tests.
9701 https://bugs.webkit.org/show_bug.cgi?id=54874
9703 Added clearOpener method to WebFramePrivate.
9705 * WebView/WebFrame.mm:
9706 (-[WebFrame _clearOpener]):
9707 * WebView/WebFramePrivate.h:
9709 2011-02-25 Mark Rowe <mrowe@apple.com>
9711 <rdar://problem/8902546> Build fix.
9713 * Misc/QuickDrawCompatibility.h:
9715 2011-02-24 Anders Carlsson <andersca@apple.com>
9719 * WebCoreSupport/WebKeyGenerator.m:
9720 (toWebCertificateParseResult):
9721 (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
9722 * WebView/WebTextCompletionController.mm:
9724 2011-02-24 Peter Kasting <pkasting@google.com>
9726 Reviewed by Eric Seidel.
9728 Drop the "U; " encryption level from the User Agent string.
9729 https://bugs.webkit.org/show_bug.cgi?id=54566
9731 * WebView/WebView.mm:
9732 (+[WebView _standardUserAgentWithApplicationName:]):
9734 2011-02-24 Andrew Wilson <atwilson@chromium.org>
9736 Unreviewed, rolling out r79570.
9737 http://trac.webkit.org/changeset/79570
9738 https://bugs.webkit.org/show_bug.cgi?id=54874
9740 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
9743 * WebView/WebFrame.mm:
9744 * WebView/WebFramePrivate.h:
9746 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
9748 Reviewed by Alexey Proskuryakov.
9750 DumpRenderTree should reset frame opener between tests.
9751 https://bugs.webkit.org/show_bug.cgi?id=54874
9753 Added clearOpener method to WebFramePrivate.
9755 * WebView/WebFrame.mm:
9756 (-[WebFrame _clearOpener]):
9757 * WebView/WebFramePrivate.h:
9759 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
9761 Reviewed by Alexey Proskuryakov.
9763 Drop the language tag part from the User Agent string
9764 https://bugs.webkit.org/show_bug.cgi?id=54560
9766 * WebView/WebView.mm:
9767 (+[WebView _standardUserAgentWithApplicationName:]): Drop the
9770 2011-02-22 Brady Eidson <beidson@apple.com>
9772 Reviewed by Anders Carlsson.
9774 Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
9775 API to view and delete Application Cache data by origin.
9777 * WebCoreSupport/WebApplicationCache.mm:
9778 (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
9780 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
9782 Reviewed by Kent Tamura.
9784 Rename Position::node() to Position::deprecatedNode()
9785 https://bugs.webkit.org/show_bug.cgi?id=54622
9787 * WebView/WebFrame.mm:
9788 (-[WebFrame _smartDeleteRangeForProposedRange:]):
9790 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
9792 Reviewed by Kent Tamura.
9794 Rename Position::node() to Position::deprecatedNode()
9795 https://bugs.webkit.org/show_bug.cgi?id=54622
9799 * WebView/WebFrame.mm:
9800 (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
9801 use containerNode() and offsetInContainerNode() instead of deprecated member functions.
9803 2011-02-18 Gavin Barraclough <barraclough@apple.com>
9805 Reviewed by Sam Weinig.
9807 Bug 54786 - Devirtualize JSCell::classInfo()
9809 Instead of making a virtual function call, add a pointer to the ClassInfo
9812 This removes a virtual function call, and paves the way towards removing all
9813 the createStructure methods, and StructureFlags/AnonymousSlotCount properties
9814 (these should be able to move onto ClassInfo).
9816 Calls to Structure::create must now pass a pointer to the ClassInfo for the
9817 structure. All objects now have a ClassInfo pointer, non-object cell types
9820 Changes are most mechanical, involving three steps:
9821 * Remove virtual classInfo() methods.
9822 * Add &s_info parameter to calls to Structure::create.
9823 * Rename ClassInfo static members on classes from 'info' to 's_info',
9826 * Plugins/Hosted/ProxyInstance.mm:
9827 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
9828 (WebKit::ProxyRuntimeMethod::createStructure):
9829 * Plugins/Hosted/ProxyRuntimeObject.h:
9830 (WebKit::ProxyRuntimeObject::createStructure):
9831 * Plugins/Hosted/ProxyRuntimeObject.mm:
9832 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
9833 * WebView/WebView.mm:
9834 (aeDescFromJSValue):
9836 2011-02-19 Brian Ryner <bryner@chromium.org>
9838 Reviewed by Adam Barth.
9840 Add missing #include of DocumentLoader.h, needed since the transitive
9841 include through Document.h is removed.
9842 https://bugs.webkit.org/show_bug.cgi?id=50489
9844 * WebView/WebFrame.mm:
9846 2011-02-19 Charlie Reis <creis@chromium.org>
9848 Reviewed by Mihai Parparita.
9850 Ensure loading has stopped in HistoryController::goToItem
9851 https://bugs.webkit.org/show_bug.cgi?id=54517
9853 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
9855 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
9857 * WebCoreSupport/WebFrameLoaderClient.mm:
9858 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
9859 * WebCoreSupport/WebFrameLoaderClient.h:
9861 2011-02-16 David Hyatt <hyatt@apple.com>
9863 Reviewed by Dan Bernstein.
9865 https://bugs.webkit.org/show_bug.cgi?id=54244
9867 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
9868 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
9870 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
9871 been changed as well.
9873 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
9875 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
9877 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
9878 still have a precise floating point position.
9880 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
9881 be rounding justification spacing in their font code.
9883 Many layout test results change on Mac, since rounding hacks were used there and are now gone.
9885 * Misc/WebKitNSStringExtras.mm:
9886 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
9887 (-[NSString _web_widthWithFont:]):
9889 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
9891 Reviewed by Adam Roben.
9893 HTML5 <details> and <summary>: localized text
9894 https://bugs.webkit.org/show_bug.cgi?id=54260
9896 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
9897 provide the default label to be used by a <details> tag that has no <summary> child.
9899 * WebCoreSupport/WebPlatformStrategies.h:
9900 * WebCoreSupport/WebPlatformStrategies.mm:
9901 (WebPlatformStrategies::defaultDetailsSummaryText):
9903 2011-02-16 Matthew Delaney <mdelaney@apple.com>
9905 Reviewed by Simon Fraser.
9907 Allow acceleratesDrawing for WebKit2
9908 https://bugs.webkit.org/show_bug.cgi?id=54511
9910 Plumb through preference for accelerated drawing.
9912 * WebView/WebPreferenceKeysPrivate.h:
9913 * WebView/WebPreferences.mm:
9914 (+[WebPreferences initialize]):
9915 (-[WebPreferences acceleratedDrawingEnabled]):
9916 (-[WebPreferences setAcceleratedDrawingEnabled:]):
9917 * WebView/WebPreferencesPrivate.h:
9919 2011-02-15 David Kilzer <ddkilzer@apple.com>
9921 <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
9923 Reviewed by Darin Adler.
9925 * WebView/WebDynamicScrollBarsView.h:
9926 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
9928 * WebView/WebDynamicScrollBarsView.mm:
9929 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
9930 implementation into correct category.
9931 * WebView/WebDynamicScrollBarsViewInternal.h:
9932 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
9934 * WebView/WebHTMLView.mm: Included
9935 WebDynamicScrollBarsViewInternal.h instead of
9936 WebDynamicScrollBarsView.h.
9938 2011-02-14 Oliver Hunt <oliver@apple.com>
9940 Reviewed by Gavin Barraclough and Geoff Garen.
9942 Refactor handles and weak pointers to become nicer and more automatic
9943 https://bugs.webkit.org/show_bug.cgi?id=54415
9945 Update to use Global<> instead of ProtectedPtr, and refactored slightly
9946 to get global data to places it's needed for when we're assigning to
9949 * ForwardingHeaders/collector/handles/Global.h: Added.
9950 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
9951 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
9952 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
9953 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
9954 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
9955 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
9956 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
9957 (WebKit::NetscapePluginInstanceProxy::evaluate):
9958 (WebKit::NetscapePluginInstanceProxy::invoke):
9959 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
9960 (WebKit::NetscapePluginInstanceProxy::construct):
9961 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
9962 * WebView/WebScriptDebugger.h:
9963 * WebView/WebScriptDebugger.mm:
9964 (WebScriptDebugger::WebScriptDebugger):
9966 2011-02-15 Jia Pu <jpu@apple.com>
9968 Reviewed by Darin Adler.
9970 Autocorrection should respect undo.
9971 https://bugs.webkit.org/show_bug.cgi?id=52221
9972 <rdar://problem/8663399>
9974 Please see WebCore/ChangeLog for detailed description.
9976 * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
9978 * WebCoreSupport/WebEditorClient.mm:
9979 (WebEditorClient::recordAutocorrectionResponse): Ditto.
9981 * WebView/WebFrame.mm:
9982 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
9983 Adopted new signature of ReplaceSelectionCommand::create().
9985 2011-02-15 David Kilzer <ddkilzer@apple.com>
9987 <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
9989 Reviewed by Darin Adler.
9991 * WebView/WebDynamicScrollBarsView.h:
9992 * WebView/WebDynamicScrollBarsView.mm:
9993 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
9994 -inProgramaticScroll.
9995 * WebView/WebHTMLView.mm:
9996 (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
9998 2011-02-15 Kenneth Russell <kbr@google.com>
10000 Reviewed by Darin Fisher.
10002 Allow controlling minimum DOMTimer interval on a per-page basis
10003 https://bugs.webkit.org/show_bug.cgi?id=54312
10005 Added needed methods to implement LayoutTestController's new
10006 setMinimumTimerInterval method.
10008 * WebView/WebView.mm:
10009 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
10010 (+[WebView _defaultMinimumTimerInterval]):
10011 (-[WebView _setMinimumTimerInterval:]):
10012 * WebView/WebViewPrivate.h:
10014 2011-02-11 Geoffrey Garen <ggaren@apple.com>
10016 Reviewed by Oliver Hunt.
10018 A little more encapsulation for the heap: Removed CollectorHeapIterator
10019 https://bugs.webkit.org/show_bug.cgi?id=54298
10021 * Misc/WebCoreStatistics.mm:
10022 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
10023 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
10025 2011-02-10 Nate Chapin <japhet@chromium.org>
10027 Reviewed by Adam Barth.
10029 Update calls to DocumentWriter.
10030 https://bugs.webkit.org/show_bug.cgi?id=50489
10032 * WebView/WebFrame.mm:
10033 (-[WebFrame _canProvideDocumentSource]):
10035 2011-02-10 Chris Fleizach <cfleizach@apple.com>
10037 Reviewed by Anders Carlsson.
10039 AX: AX needs to stop using WebCoreViewFactory
10040 https://bugs.webkit.org/show_bug.cgi?id=54153
10042 * WebCoreSupport/WebSystemInterface.mm:
10043 (InitWebCoreSystemInterface):
10045 2011-02-10 Peter Varga <pvarga@webkit.org>
10047 Reviewed by Csaba Osztrogonác.
10049 Remove PCRE source from trunk
10050 https://bugs.webkit.org/show_bug.cgi?id=54188
10052 * ForwardingHeaders/pcre/pcre.h: Removed.
10054 2011-02-09 Pavel Feldman <pfeldman@chromium.org>
10056 Reviewed by Yury Semikhatsky.
10058 Web Inspector: follow up on InspectorAgent split -
10059 removing unnecessary methods from InspectorController.
10060 https://bugs.webkit.org/show_bug.cgi?id=54093
10062 * WebInspector/WebInspector.mm:
10063 (-[WebInspector showConsole:]):
10064 (-[WebInspector stopProfilingJavaScript:]):
10066 2011-02-08 Dan Bernstein <mitz@apple.com>
10068 Reviewed by Jon Honeycutt and Maciej Stachowiak.
10070 <rdar://problem/8959420> Find in Mail no longer cycles around
10072 * WebView/WebHTMLView.mm:
10073 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
10074 the wrap option according to the flag.
10076 2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
10078 Unreviewed, rolling out r77980.
10079 http://trac.webkit.org/changeset/77980
10080 https://bugs.webkit.org/show_bug.cgi?id=54043
10082 "Crashes on Windows and Linux..." (Requested by leviw on
10085 * WebView/WebFrame.mm:
10086 (-[WebFrame _caretRectAtNode:offset:affinity:]):
10087 * WebView/WebFrameInternal.h:
10088 * WebView/WebTextCompletionController.mm:
10089 (-[WebTextCompletionController doCompletion]):
10091 2011-02-08 Levi Weintraub <leviw@chromium.org>
10093 Reviewed by Ryosuke Niwa.
10095 Stop instantiating legacy editing Positions in VisiblePosition
10096 https://bugs.webkit.org/show_bug.cgi?id=52919
10098 Changing usage of legacy VisiblePosition constructor. Since we were dealing
10099 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
10101 * WebView/WebFrame.mm:
10102 (-[WebFrame _caretRectAtPosition:affinity:]):
10103 * WebView/WebFrameInternal.h:
10104 * WebView/WebTextCompletionController.mm:
10105 (-[WebTextCompletionController doCompletion]):
10107 2011-02-08 Adam Barth <abarth@webkit.org>
10109 Reviewed by Eric Seidel.
10111 Remove orphan code from old parser
10112 https://bugs.webkit.org/show_bug.cgi?id=53984
10114 * WebCoreSupport/WebChromeClient.h:
10116 2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
10118 Reviewed by Yury Semikhatsky.
10120 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
10122 https://bugs.webkit.org/show_bug.cgi?id=53169
10124 Minor change enforced by major changes in WebCore/inspector/InspectorController.
10126 * WebInspector/WebInspector.mm:
10127 (-[WebInspector isTimelineProfilingEnabled]):
10129 2011-02-07 Enrica Casucci <enrica@apple.com>
10131 Reviewed Adam Roben and Darin Adler.
10133 WebKit2: drag and drop support on Windows.
10134 https://bugs.webkit.org/show_bug.cgi?id=52775
10136 Removed createDragImageForLink from DragClient.
10138 * WebCoreSupport/WebDragClient.h:
10139 * WebCoreSupport/WebDragClient.mm:
10140 (WebDragClient::startDrag):
10142 2011-02-03 Yury Semikhatsky <yurys@chromium.org>
10144 Reviewed by Pavel Feldman.
10146 Web Inspector: remove settings related methods from InspectorClient
10147 https://bugs.webkit.org/show_bug.cgi?id=53686
10149 * WebCoreSupport/WebInspectorClient.h:
10150 * WebCoreSupport/WebInspectorClient.mm:
10151 (WebInspectorClient::openInspectorFrontend):
10152 (WebInspectorFrontendClient::WebInspectorFrontendClient):
10154 2011-02-03 James Kozianski <koz@chromium.org>
10156 Reviewed by Dimitri Glazkov.
10158 Add navigator.registerProtocolHandler behind a flag.
10159 https://bugs.webkit.org/show_bug.cgi?id=52609
10161 * Configurations/FeatureDefines.xcconfig:
10163 2011-02-03 Adam Langley <agl@chromium.org>
10165 Reviewed by Adam Barth.
10167 Plumb mixed script URL to FrameLoaderClient
10168 https://bugs.webkit.org/show_bug.cgi?id=52384
10170 Regressions covered by http/tests/security/mixedContent/*
10172 * WebCoreSupport/WebFrameLoaderClient.h:
10173 * WebCoreSupport/WebFrameLoaderClient.mm:
10174 (WebFrameLoaderClient::didRunInsecureContent):
10176 2011-02-03 Beth Dakin <bdakin@apple.com>
10178 Reviewed by Sam Weinig.
10180 Fix for <rdar://problem/8944544> Ability to animate track
10181 for WKPainter scrollers
10183 * WebCoreSupport/WebSystemInterface.mm:
10184 (InitWebCoreSystemInterface):
10186 2011-02-02 Mark Rowe <mrowe@apple.com>
10188 Reviewed by Beth Dakin.
10190 <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
10192 * WebCoreSupport/WebSystemInterface.mm:
10193 (InitWebCoreSystemInterface): Add some missing initializers.
10195 2011-02-02 Steve Lacey <sjl@chromium.org>
10197 Reviewed by Eric Carlson.
10199 Implement basic media statistics on media elements.
10200 https://bugs.webkit.org/show_bug.cgi?id=53322
10202 * Configurations/FeatureDefines.xcconfig:
10204 2011-02-01 Sam Weinig <sam@webkit.org>
10206 Reviewed by Beth Dakin.
10208 Part 2 for <rdar://problem/8492788>
10209 Adopt WKScrollbarPainterController
10211 Use header detection to define scrollbar painting controller #define.
10213 * WebCoreSupport/WebSystemInterface.mm:
10214 (InitWebCoreSystemInterface):
10216 2011-02-01 David Hyatt <hyatt@apple.com>
10218 Reviewed by Oliver Hunt.
10220 https://bugs.webkit.org/show_bug.cgi?id=53520
10222 Remove the physical terminology from IntRect and FloatRect.
10224 Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
10225 we need to update our terminology to be more accurate.
10227 I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
10228 renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
10229 even for flipped rectangles.
10231 * WebView/WebHTMLView.mm:
10232 (setNeedsDisplayInRect):
10234 2011-02-01 Beth Dakin <bdakin@apple.com>
10236 Reviewed by Sam Weinig.
10238 Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
10240 * WebCoreSupport/WebSystemInterface.mm:
10241 (InitWebCoreSystemInterface):
10243 2011-02-01 Dave Hyatt <hyatt@apple.com>
10245 Reviewed by Darin Adler.
10247 https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
10248 with vertical text.
10250 Change printing functions to check writing-mode and properly swap width and height
10253 * WebView/WebDynamicScrollBarsView.mm:
10254 (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
10255 * WebView/WebFrame.mm:
10256 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
10257 * WebView/WebFrameInternal.h:
10258 * WebView/WebHTMLView.mm:
10259 (-[WebHTMLView _web_setPrintingModeRecursive]):
10260 (-[WebHTMLView _web_clearPrintingModeRecursive]):
10261 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
10262 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
10263 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
10264 (-[WebHTMLView _endPrintMode]):
10265 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
10266 (-[WebHTMLView _endScreenPaginationMode]):
10267 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
10268 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
10269 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
10270 (-[WebHTMLView _scaleFactorForPrintOperation:]):
10271 (-[WebHTMLView setPageWidthForPrinting:]):
10272 (-[WebHTMLView knowsPageRange:]):
10274 2011-01-31 Oliver Hunt <oliver@apple.com>
10276 Convert markstack to a slot visitor API
10277 https://bugs.webkit.org/show_bug.cgi?id=53219
10279 rolling r77098, r77099, r77100, r77109, and
10280 r77111 back in, along with a few more Qt fix attempts.
10282 * WebView/WebScriptDebugDelegate.mm:
10283 (-[WebScriptCallFrame scopeChain]):
10285 2011-01-30 Csaba Osztrogonác <ossy@webkit.org>
10287 Unreviewed, rolling out r77098, r77099, r77100, r77109, and
10289 http://trac.webkit.org/changeset/77098
10290 http://trac.webkit.org/changeset/77099
10291 http://trac.webkit.org/changeset/77100
10292 http://trac.webkit.org/changeset/77109
10293 http://trac.webkit.org/changeset/77111
10294 https://bugs.webkit.org/show_bug.cgi?id=53219
10298 * WebView/WebScriptDebugDelegate.mm:
10299 (-[WebScriptCallFrame scopeChain]):
10301 2011-01-30 Oliver Hunt <oliver@apple.com>
10303 Convert markstack to a slot visitor API
10304 https://bugs.webkit.org/show_bug.cgi?id=53219
10306 rolling r77006 and r77020 back in.
10308 * WebView/WebScriptDebugDelegate.mm:
10309 (-[WebScriptCallFrame scopeChain]):
10311 2011-01-28 Geoffrey Garen <ggaren@apple.com>
10313 Reviewed by Maciej Stachowiak.
10315 Some more Heap cleanup.
10316 https://bugs.webkit.org/show_bug.cgi?id=53357
10318 Updated for JavaScriptCore changes.
10320 * Misc/WebCoreStatistics.mm:
10321 (+[WebCoreStatistics memoryStatistics]):
10323 2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
10325 Unreviewed, rolling out r77006 and r77020.
10326 http://trac.webkit.org/changeset/77006
10327 http://trac.webkit.org/changeset/77020
10328 https://bugs.webkit.org/show_bug.cgi?id=53360
10330 "Broke Windows tests" (Requested by rniwa on #webkit).
10332 * WebView/WebScriptDebugDelegate.mm:
10333 (-[WebScriptCallFrame scopeChain]):
10335 2011-01-27 Oliver Hunt <oliver@apple.com>
10337 Reviewed by Geoffrey Garen.
10339 Convert markstack to a slot visitor API
10340 https://bugs.webkit.org/show_bug.cgi?id=53219
10342 Update to new marking api
10344 * WebView/WebScriptDebugDelegate.mm:
10345 (-[WebScriptCallFrame scopeChain]):
10347 2011-01-28 Dan Bernstein <mitz@apple.com>
10349 Reviewed by Sam Weinig.
10351 <select> can't display right-to-left (rtl) languages
10352 https://bugs.webkit.org/show_bug.cgi?id=19785
10354 * WebCoreSupport/WebChromeClient.h:
10355 * WebCoreSupport/WebChromeClient.mm:
10356 (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
10357 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
10359 2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
10361 Unreviewed, rolling out r76891.
10362 http://trac.webkit.org/changeset/76891
10363 https://bugs.webkit.org/show_bug.cgi?id=53280
10365 Makes every layout test crash (Requested by othermaciej on
10368 * Misc/WebIconDatabase.mm:
10369 (-[ThreadEnabler threadEnablingSelector:]):
10370 (importToWebCoreFormat):
10372 2011-01-27 Nate Chapin <japhet@chromium.org>
10374 Reviewed by Adam Barth.
10376 Use Document::url() instead of FrameLoader::url().
10377 https://bugs.webkit.org/show_bug.cgi?id=41165
10379 * WebView/WebView.mm:
10380 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
10382 2011-01-27 Dan Bernstein <mitz@apple.com>
10384 Rubber-stamped by Anders Carlsson.
10386 Reverted an accidental change in r76561.
10388 * WebView/WebHTMLView.mm:
10390 2011-01-26 David Kilzer <ddkilzer@apple.com>
10392 <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
10393 <rdar://problem/8821760>
10395 Reviewed by Antti Koivisto.
10397 * WebCoreSupport/WebSystemInterface.mm:
10398 (InitWebCoreSystemInterface): Added initialization for
10399 GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
10401 2011-01-26 Beth Dakin <bdakin@apple.com>
10403 Reviewed by Darin Adler.
10405 Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
10406 when using WKScrollbars.
10408 * WebCoreSupport/WebSystemInterface.mm:
10409 (InitWebCoreSystemInterface):
10411 2011-01-25 Darin Adler <darin@apple.com>
10413 Reviewed by Anders Carlsson.
10415 WebKit is using CSBackupSetItemExcluded incorrectly
10416 https://bugs.webkit.org/show_bug.cgi?id=53095
10417 rdar://problem/8790540
10419 * Misc/WebIconDatabase.mm:
10420 (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
10421 It was incorrect, and this responsibility has been moved to WebCore.
10423 2011-01-24 Chris Marrin <cmarrin@apple.com>
10425 Reviewed by Eric Seidel.
10427 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
10428 https://bugs.webkit.org/show_bug.cgi?id=53041
10430 * Configurations/FeatureDefines.xcconfig:
10432 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
10434 Reviewed by Pavel Feldman.
10436 Web Inspector: remove "attached" state related methods from InspectorAgent
10437 https://bugs.webkit.org/show_bug.cgi?id=53086
10439 * WebCoreSupport/WebInspectorClient.h:
10440 * WebCoreSupport/WebInspectorClient.mm:
10441 (-[WebInspectorWindowController showWindow:]):
10442 (-[WebInspectorWindowController attach]):
10443 (-[WebInspectorWindowController detach]):
10445 2011-01-23 Dan Bernstein <mitz@apple.com>
10447 Reviewed by John Sullivan.
10449 <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
10451 * WebCoreSupport/WebChromeClient.mm:
10452 (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
10454 2011-01-22 Alexey Proskuryakov <ap@apple.com>
10456 Reviewed by Darin Adler.
10458 https://bugs.webkit.org/show_bug.cgi?id=52473
10459 Auto-scaling to avoid orphans is broken, remove dysfunctional code
10461 * WebView/WebHTMLView.mm:
10462 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
10463 (-[WebHTMLView _scaleFactorForPrintOperation:]):
10464 (-[WebHTMLView knowsPageRange:]):
10466 2011-01-21 Mark Rowe <mrowe@apple.com>
10468 Rubber-stamped by Jon Honeycutt.
10470 Fix the build when using Clang by removing some unused variables.
10472 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
10473 (-[WebHostedNetscapePluginView updateAndSetWindow]):
10474 * WebView/WebFullScreenController.mm:
10475 (-[WebFullScreenController enterFullscreen:]):
10476 (-[WebFullScreenController exitFullscreen]):
10478 2011-01-21 Chris Rogers <crogers@google.com>
10480 Reviewed by Darin Fisher.
10482 Add run-time enable support for the web audio API
10483 https://bugs.webkit.org/show_bug.cgi?id=52741
10485 * WebView/WebPreferenceKeysPrivate.h:
10486 * WebView/WebPreferences.mm:
10487 (-[WebPreferences webAudioEnabled]):
10488 (-[WebPreferences setWebAudioEnabled:]):
10489 * WebView/WebPreferencesPrivate.h:
10490 * WebView/WebView.mm:
10491 (-[WebView _preferencesChangedNotification:]):
10493 2011-01-20 John Sullivan <sullivan@apple.com>
10495 Reviewed by Mark Rowe.
10497 Shift-tab doesn't cycle through fields in http authentication panel
10498 https://bugs.webkit.org/show_bug.cgi?id=52850
10500 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
10501 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
10502 Re-wired the key loop so that there aren't two views with the same nextKeyView.
10504 2011-01-20 Beth Dakin <bdakin@apple.com>
10506 Reviewed by Geoffrey Garen.
10508 Fix for <rdar://problem/8890255>
10510 Allow WebKitSystemInterface to draw scrollbars
10512 * WebCoreSupport/WebSystemInterface.mm:
10513 (InitWebCoreSystemInterface):
10515 2011-01-19 Simon Fraser <simon.fraser@apple.com>
10517 Reviewed by Sam Weinig.
10519 GraphicsLayers in subframes can get sync'd multiple times
10520 https://bugs.webkit.org/show_bug.cgi?id=52489
10522 * WebView/WebView.mm:
10523 (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
10524 was renamed to syncCompositingStateIncludingSubframes().
10526 2011-01-19 Darin Adler <darin@apple.com>
10528 Reviewed by Sam Weinig.
10530 Would like script debugging protocol method to differentiate between caught and uncaught exceptions
10531 https://bugs.webkit.org/show_bug.cgi?id=52104
10532 rdar://problem/8704226
10534 * WebView/WebDelegateImplementationCaching.h:
10535 Fix type of second integer in CallScriptDebugDelegate function overload
10536 to be int to match the actual Objective-C method. Added a new overload
10537 that includes a BOOL in the right place. Added a boolean named
10538 exceptionWasRaisedExpectsHasHandlerFlag.
10540 * WebView/WebDelegateImplementationCaching.mm:
10541 (CallDelegate): Added overloads as above.
10542 (CallScriptDebugDelegate): Ditto.
10544 * WebView/WebScriptDebugDelegate.h: Added new method with the additional
10545 boolean argument. Marked the old method informally deprecated.
10547 * WebView/WebScriptDebugger.mm:
10548 (WebScriptDebugger::exception): Added code to call with or without the
10549 boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
10551 * WebView/WebView.mm:
10552 (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
10553 exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
10554 guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
10556 2011-01-19 Tony Gentilcore <tonyg@chromium.org>
10558 Reviewed by Mihai Parparita.
10560 Perform some forward declaration
10561 https://bugs.webkit.org/show_bug.cgi?id=52522
10563 * Misc/WebKitNSStringExtras.mm:
10565 2011-01-19 Pavel Podivilov <podivilov@chromium.org>
10567 Reviewed by Yury Semikhatsky.
10569 Web Inspector: [JSC] scripts have incorrect starting line (always 1).
10570 https://bugs.webkit.org/show_bug.cgi?id=52721
10572 * WebView/WebScriptDebugger.h:
10573 * WebView/WebScriptDebugger.mm:
10575 (WebScriptDebugger::sourceParsed):
10577 2011-01-19 Levi Weintraub <leviw@google.com>
10579 Reviewed by Ryosuke Niwa.
10581 Updating to use Position::parentAnchoredEquivalent instead of
10582 the old htmlediting rangeCompliantEquivalent.
10584 remove rangeCompliantEquivalent and replace it with Position methods
10585 https://bugs.webkit.org/show_bug.cgi?id=25057
10587 * WebView/WebFrame.mm:
10588 (-[WebFrame _smartDeleteRangeForProposedRange:]):
10590 2011-01-18 Chris Fleizach <cfleizach@apple.com>
10592 Reviewed by Darin Adler.
10594 REGRESSION: A problem with Voiceover and finding links
10595 https://bugs.webkit.org/show_bug.cgi?id=52324
10597 * WebView/WebDynamicScrollBarsView.mm:
10598 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
10600 2011-01-17 David Kilzer <ddkilzer@apple.com>
10602 <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
10604 Reviewed by Dan Bernstein.
10606 * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
10607 DOMDocumentPrivate.h to the PrivateHeaders directory.
10609 2011-01-17 Enrica Casucci <enrica@apple.com>
10611 Reviewed by Alexey Proskuryakov.
10613 Drag and drop support: refactoring of image from link and image from selection
10614 https://bugs.webkit.org/show_bug.cgi?id=52496
10616 This work cleans up the Mac code and makes it more similar to the Windows implementation,
10617 avoiding the use of an NSView when the FrameView can be used.
10618 The refactoring is a necessary step towards the complete support of drag and drop
10621 * WebCoreSupport/WebDragClient.mm:
10622 (WebDragClient::createDragImageForLink): Added.
10623 * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
10624 * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
10626 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
10628 Reviewed by Yury Semikhatsky.
10630 Web Inspector: simplify debugger enabling routine.
10631 https://bugs.webkit.org/show_bug.cgi?id=52472
10633 * WebInspector/WebInspector.mm:
10634 (-[WebInspector startDebuggingJavaScript:]):
10636 2011-01-16 Dan Bernstein <mitz@apple.com>
10638 Reviewed by Simon Fraser.
10640 Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
10641 https://bugs.webkit.org/show_bug.cgi?id=52550
10643 * Plugins/WebNetscapePluginView.mm:
10644 (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
10645 that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
10647 2011-01-16 Simon Fraser <simon.fraser@apple.com>
10649 Reviewed by Dan Bernstein.
10651 Issues with iframes and plugins when the WebView is scaled.
10652 <rdar://problem/6213380>
10654 When _scaleWebView has been called on a WebView, iframes
10655 in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
10656 This is caused by AppKit NSViews not playing nicely with the scale
10657 applied through style.
10659 Work around most of these issues by adjusting the bounds size
10660 of widgets to allow iframe contents to paint with the correct scale,
10661 and fix various places in the code where we relied on coordinate
10662 transforms via NSViews (which ignore CSS transforms).
10664 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
10665 (-[WebHostedNetscapePluginView updateAndSetWindow]):
10666 * WebView/WebFrameView.mm:
10667 (-[WebFrameView setBoundsSize:]):
10669 2011-01-16 Beth Dakin <bdakin@apple.com>
10671 Reviewed by Kevin Decker.
10673 Fix for <rdar://problem/8871204>
10675 Don't try to save elasticity state. Just rely on
10676 NSScrollElasticityAutomatic to restore the correct state.
10677 * WebCoreSupport/WebFrameLoaderClient.h:
10678 * WebCoreSupport/WebFrameLoaderClient.mm:
10679 (WebFrameLoaderClient::WebFrameLoaderClient):
10680 (WebFrameLoaderClient::dispatchDidFirstLayout):
10681 (WebFrameLoaderClient::provisionalLoadStarted):
10683 2011-01-14 Simon Fraser <simon.fraser@apple.com>
10685 Reviewed by Dan Bernstein.
10687 Plugins render incorrectly with transformed ancestors
10688 https://bugs.webkit.org/show_bug.cgi?id=52507
10690 -[NSView visibleRect] gives the wrong answer if there are CSS transforms
10691 in the ancestor chain of a plugin.
10693 So use of this method with calls to -actualVisibleRectInWindow, which
10694 maps rects through the render tree to compute the correct rect,
10695 clipping via windowClipRect() if necessary.
10697 Not testable, because doing so relies on the behavior of some
10698 plugins, which stop rendering if setWindow passes an empty rect.
10700 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
10701 (-[WebHostedNetscapePluginView updateAndSetWindow]):
10702 * Plugins/WebBaseNetscapePluginView.h:
10703 * Plugins/WebBaseNetscapePluginView.mm:
10704 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
10705 * Plugins/WebNetscapePluginView.mm:
10706 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
10708 2011-01-14 Yuzo Fujishima <yuzo@google.com>
10710 Reviewed by Antti Koivisto.
10712 Rename cache() to memoryCache()
10713 https://bugs.webkit.org/show_bug.cgi?id=52433
10715 * Misc/WebCache.mm:
10716 (+[WebCache statistics]):
10717 (+[WebCache setDisabled:]):
10718 (+[WebCache isDisabled]):
10719 * WebView/WebView.mm:
10720 (+[WebView _setCacheModel:]):
10722 2011-01-13 Geoffrey Garen <ggaren@apple.com>
10724 Reviewed by Oliver Hunt.
10726 Split out a MarkedSpace strategy object from Heap.
10727 https://bugs.webkit.org/show_bug.cgi?id=52421
10729 * Misc/WebCoreStatistics.mm:
10730 (+[WebCoreStatistics memoryStatistics]): Updated for class move.
10732 2011-01-14 Dan Bernstein <mitz@apple.com>
10734 Reviewed by Simon Fraser.
10736 WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
10738 * WebView/WebHTMLView.mm:
10739 (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
10740 to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
10741 that the NSView tree doesn’t change from under AppKit as it traverses it.
10743 2011-01-14 Beth Dakin <bdakin@apple.com>
10745 Reviewed by Mark Rowe.
10747 Fix for <rdar://problem/7793902> Artifacts when scrolling
10748 page in Safari while page is loading
10750 Call setDrawsBackground:YES on the scrollView in
10751 dispatchDidFirstLayout() rather than waiting until
10752 frameLoadCompleted(). Also suspend scrolling elasticity
10753 between provisionalLoadStarted() and dispatchDidFirstLayout()
10754 * WebCoreSupport/WebFrameLoaderClient.h:
10755 * WebCoreSupport/WebFrameLoaderClient.mm:
10756 (WebFrameLoaderClient::WebFrameLoaderClient):
10757 (WebFrameLoaderClient::dispatchDidFirstLayout):
10758 (WebFrameLoaderClient::provisionalLoadStarted):
10760 2011-01-12 Enrica Casucci <enrica@apple.com>
10762 Reviewed by Darin Adler.
10764 WebKit2: Add support for drag and drop
10765 https://bugs.webkit.org/show_bug.cgi?id=52343
10766 <rdar://problem/7660558>
10768 The DragData class has been extended to provide
10769 additional context from the application (keyboard state, modal windows, etc.)
10770 as well as information of the drag pasteboard being used.
10771 These are the changes to align the behavior for WebKit.
10773 * WebView/WebView.mm:
10774 (-[WebView applicationFlags:]): Added.
10775 (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
10776 (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
10777 (-[WebView draggingExited:]): Added parameter to the DragData constructor.
10778 (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
10780 2011-01-12 Beth Dakin <bdakin@apple.com>
10782 Reviewed by Anders Carlsson.
10784 Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
10785 Expose fixed layout through WebKit SPI
10786 -and corresponding-
10787 <rdar://problem/8844464>
10789 And now with getters!
10790 * WebView/WebView.mm:
10791 (-[WebView _useFixedLayout]):
10792 (-[WebView _fixedLayoutSize]):
10793 * WebView/WebViewPrivate.h:
10795 2011-01-12 Beth Dakin <bdakin@apple.com>
10797 Reviewed by Anders Carlsson.
10799 Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
10800 fixed layout through WebKit SPI
10801 -and corresponding-
10802 <rdar://problem/8844464>
10804 * WebView/WebView.mm:
10805 (-[WebView _setUseFixedLayout:]):
10806 (-[WebView _setFixedLayoutSize:]):
10807 * WebView/WebViewPrivate.h:
10809 2011-01-07 Enrica Casucci <enrica@apple.com>
10811 Reviewed by Alexey Proskuryakov.
10813 Paste and drag and drop use different code paths to interact with the pasteboard.
10814 https://bugs.webkit.org/show_bug.cgi?id=52093
10815 The change consists in a refactoring of the code to have only one class that
10816 deals with the pasteboard on Mac.
10818 * WebCoreSupport/WebEditorClient.h:
10819 * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
10820 exposed by NSURLExtras.
10821 (WebEditorClient::canonicalizeURL):
10822 (WebEditorClient::canonicalizeURLString):
10823 * WebCoreSupport/WebPasteboardHelper.h: Removed.
10824 * WebCoreSupport/WebPasteboardHelper.mm: Removed.
10825 * WebView/WebHTMLView.mm: Removed comment.
10826 * WebView/WebView.mm: The following methods have been changed to use the new DragData
10827 constructor that doesn't use the WebPasteboardHelper reference.
10828 (-[WebView draggingEntered:]):
10829 (-[WebView draggingUpdated:]):
10830 (-[WebView draggingExited:]):
10831 (-[WebView performDragOperation:]):
10833 2011-01-09 Tony Gentilcore <tonyg@chromium.org>
10835 Reviewed by Alexey Proskuryakov.
10837 Forward declare some headers where possible
10838 https://bugs.webkit.org/show_bug.cgi?id=52133
10840 * WebView/WebFrame.mm:
10842 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
10844 Reviewed by Darin Fisher.
10846 https://bugs.webkit.org/show_bug.cgi?id=41441
10847 createWindow method should only do window-creating without URL navigation
10849 * WebCoreSupport/WebChromeClient.mm:
10850 (WebChromeClient::createWindow):
10852 2011-01-08 Dan Bernstein <mitz@apple.com>
10854 Try to fix the Leopard build.
10856 * WebView/WebFullScreenController.mm:
10858 2011-01-07 Jer Noble <jer.noble@apple.com>
10860 Yet another Leopard build fix: NSRect and CGRect are not inter-
10861 changable in 32-bit.
10863 * WebView/WebFullScreenController.mm:
10864 (-[WebFullScreenController exitFullscreen]):
10866 2011-01-07 Jer Noble <jer.noble@apple.com>
10868 Fix the Leopard build: Replace CoreAnimation SL-only functions
10869 with Leopard equivalents.
10871 * WebView/WebFullScreenController.mm:
10872 (+[CATransaction setDisableActions:]):
10873 (+[CATransaction setAnimationDuration:]):
10874 (-[WebFullScreenController _animationDuration]):
10875 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
10877 2010-12-21 Jer Noble <jer.noble@apple.com>
10879 Reviewed by Simon Fraser.
10881 Implement WebKit Full Screen support.
10882 https://bugs.webkit.org/show_bug.cgi?id=49481
10883 rdar://problem/8247444
10885 Support the new fullscreen Chrome client requests. WebView will pass
10886 through these requests to a WebFullscreenController.
10888 * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
10889 * WebView/WebView.mm:
10890 (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
10891 (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
10892 (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
10893 (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
10894 * WebView/WebViewData.h: Add ivar newFullscreenController.
10896 2010-12-17 Jer Noble <jer@kokode.apple.com>
10898 Reviewed by Simon Fraser.
10900 Implement WebKit Full Screen support.
10901 https://bugs.webkit.org/show_bug.cgi?id=49481
10902 rdar://problem/8247444
10904 This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
10905 Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
10906 window, and a custom CAAnimation animates that layer between the initial screen rect of the
10907 full screen element, to its final value. WebFullscreenController will swap the WebView out of
10908 its original window, and into the fullscreen window. The controller will replace the WebView
10909 with a placeholder view, so that if the placeholder moves or resized while the WebView is
10910 absent, the WebView will move back to the correct location when exiting fullscreen.
10912 * WebView/WebFullscreenController.h: Added.
10913 * WebView/WebFullscreenController.mm: Added.
10914 (-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
10915 (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
10916 (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
10917 (-[WebFullscreenController applicationDidResignActive:]):
10918 (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
10919 the new screen parameters.
10920 (-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element
10921 from its original screen rect into fullscreen.
10922 (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
10923 Set up the animation that will take the fullscreen element back into its original screen
10925 (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
10926 whether to disable screensaver and sleep.
10927 (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
10928 looking for HTMLVideoElements; returns whether any are found to be playing.
10929 (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
10931 (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
10932 (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
10933 (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
10934 (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
10935 (-[WebFullscreenWindow setRendererLayer:]): Ditto.
10936 (-[WebFullscreenWindow backgroundLayer]): Ditto.
10937 (-[WebFullscreenWindow animationView]): Ditto.
10938 (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
10939 (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
10941 2011-01-07 James Robinson <jamesr@chromium.org>
10943 Revert "Implement mozilla's animationTime property"
10944 https://bugs.webkit.org/show_bug.cgi?id=51952
10946 This approach isn't quite right.
10948 * WebView/WebHTMLView.mm:
10949 (-[WebHTMLView drawRect:]):
10950 * WebView/WebView.mm:
10951 (layerSyncRunLoopObserverCallBack):
10953 2011-01-06 Gavin Barraclough <barraclough@apple.com>
10955 Reviewed by Geoff Garen.
10957 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
10959 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
10960 destructor early, in order to release wrappers once we know we no longer intend to use them.
10961 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
10962 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
10963 A sequence of events that triggers the bug would look like this:
10965 (1) Create a DOMWrapperWorld.
10966 (2) Register a timer in the world.
10967 (3) Call unregisterWorld() on the world.
10968 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
10969 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
10970 called forgetWorld() none exists.
10971 (6) Attempt to add a wrapper to a NULL map.
10973 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
10975 * WebView/WebScriptWorld.mm:
10976 (-[WebScriptWorld unregisterWorld]):
10978 2011-01-04 Chris Fleizach <cfleizach@apple.com>
10980 Reviewed by Sam Weinig.
10982 WK2: Support Accessibility
10983 https://bugs.webkit.org/show_bug.cgi?id=51859
10985 Use rootObject() method to get top of AX tree.
10987 * WebCoreSupport/WebFrameLoaderClient.h:
10988 (WebFrameLoaderClient::accessibilityRemoteObject):
10989 * WebView/WebFrame.mm:
10990 (-[WebFrame setAccessibleName:]):
10991 (-[WebFrame accessibilityRoot]):
10992 * WebView/WebFrameInternal.h:
10993 * WebView/WebFramePrivate.h:
10994 * WebView/WebHTMLView.mm:
10995 (-[WebHTMLView accessibilityAttributeValue:]):
10996 (-[WebHTMLView accessibilityFocusedUIElement]):
10997 (-[WebHTMLView accessibilityHitTest:]):
10998 (-[WebHTMLView _accessibilityParentForSubview:]):
11000 2011-01-04 David Kilzer <ddkilzer@apple.com>
11002 <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
11004 Reviewed by Eric Carlson.
11006 This originally broke in r61581. It is inside an
11007 ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
11010 * WebCoreSupport/WebFrameLoaderClient.mm: Call
11011 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
11012 use WebCore::PluginInfo.name instead of
11013 -[WebBasePluginPackage name].
11015 2011-01-02 Dan Bernstein <mitz@apple.com>
11017 Rubber-stamped by Simon Fraser.
11019 <rdar://problem/8812159> Update copyright strings
11023 2010-12-29 Dan Bernstein <mitz@apple.com>
11025 Reviewed by Ada Chan.
11027 <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
11028 https://bugs.webkit.org/show_bug.cgi?id=51717
11030 Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
11031 protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
11033 * WebView/WebDocumentInternal.h:
11034 * WebView/WebHTMLView.mm:
11035 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
11036 (-[WebHTMLView _findString:options:]):
11037 * WebView/WebView.mm:
11040 2010-12-28 Daniel Bates <dbates@rim.com>
11042 Reviewed by Sam Weinig.
11044 Substitute // MARK: for compiler-specific #pragma mark
11045 https://bugs.webkit.org/show_bug.cgi?id=51657
11047 For consistency, we should substitute "// MARK:" for compiler-
11048 specific "#pragma mark" in the source files for the Mac port.
11050 * History/WebHistory.mm:
11051 * Plugins/WebBaseNetscapePluginView.mm:
11052 * Plugins/WebNetscapePluginView.mm:
11053 * WebCoreSupport/WebInspectorClient.mm:
11054 * WebCoreSupport/WebSecurityOrigin.mm:
11055 * WebView/WebPDFView.mm:
11056 * WebView/WebVideoFullscreenController.mm:
11057 * WebView/WebVideoFullscreenHUDWindowController.mm:
11059 2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
11061 Reviewed by Darin Adler.
11063 WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
11064 https://bugs.webkit.org/show_bug.cgi?id=38535
11066 WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result,
11067 if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
11068 WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top
11069 call frame from this stack when an exception throws because the saved top frame could be invalid.
11071 To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
11072 callEvent and returnEvent.
11074 * WebView/WebScriptDebugger.mm:
11075 (WebScriptDebugger::willExecuteProgram):
11076 (WebScriptDebugger::didExecuteProgram):
11078 2010-12-22 Sam Weinig <sam@webkit.org>
11080 Reviewed by Darin Adler.
11082 WebKit2 needs to mirror the frame tree in the UIProcess
11083 https://bugs.webkit.org/show_bug.cgi?id=51546
11085 - Add client functions to notify that a frame has been added or
11086 removed from the page cache.
11088 * WebCoreSupport/WebFrameLoaderClient.h:
11089 * WebCoreSupport/WebFrameLoaderClient.mm:
11090 (WebFrameLoaderClient::didSaveToPageCache):
11091 (WebFrameLoaderClient::didRestoreFromPageCache):
11093 2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
11095 Reviewed by Eric Seidel.
11097 Editor.h doesn't need to include SelectionController.h
11098 https://bugs.webkit.org/show_bug.cgi?id=51441
11100 Renamed SelectionController::EDirection to SelectionDirection.
11102 * WebView/WebFrame.mm:
11103 (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
11104 Takes SelectionDirection instead of SelectionController::EDirection.
11105 * WebView/WebFrameInternal.h:
11106 * WebView/WebTextCompletionController.mm:
11107 (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
11109 2010-12-22 Simon Fraser <simon.fraser@apple.com>
11111 Reviewed by Darin Adler.
11113 Cache snapshots of plug-ins before painting, to avoid script running during painting
11114 https://bugs.webkit.org/show_bug.cgi?id=51493
11116 When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
11117 or when printing), plug-ins which otherwise use the CA rendering model
11118 are sent a paint event. Some plug-ins may run script while handling this event,
11119 or out of process plug-ins may process queued requests at this time. Running
11120 script while inside layout or painting can have bad consequences, because it
11121 can result in arbitrary changes to the render tree.
11123 This patch avoids sending plug-ins paint events inside of painting. Instead,
11124 we ask the plug-ins to cache a snapshot before we paint, and then the software
11125 paint simply draws that snapshot.
11127 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11128 (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
11129 draw it. Also only send the snapshot message to the plugin proxy if we
11130 know we're snapshotting, since even if creating the snapshot image failed,
11131 we still don't want to call to the plug-in.
11133 * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
11134 * Plugins/WebBaseNetscapePluginView.mm:
11135 (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
11136 (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
11138 * Plugins/WebNetscapePluginView.mm:
11139 (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
11140 * WebCoreSupport/WebFrameLoaderClient.mm:
11141 (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
11142 to cache and clear the snapshots.
11144 2010-12-21 Cameron Zwarich <zwarich@apple.com>
11146 Reviewed by Darin Adler.
11148 -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
11149 https://bugs.webkit.org/show_bug.cgi?id=51431
11150 <rdar://problem/8791757>
11152 * Plugins/WebBasePluginPackage.mm:
11153 (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
11154 it doesn't underflow.
11156 2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
11158 Reviewed by Cameron Zwarich.
11160 REGRESSION(r74172): 125 java tests fail on Mac
11161 https://bugs.webkit.org/show_bug.cgi?id=51214
11163 The regression was caused by an incorrectly adding sizeof(struct fat_header)
11164 to a pointer for uint32_t as supposed to uint8_t.
11166 Fixed the bug by explicitly casting it to uint8_t* before the addition.
11168 * Plugins/WebBasePluginPackage.mm:
11169 (-[WebBasePluginPackage isNativeLibraryData:]):
11171 2010-12-15 Cameron Zwarich <zwarich@apple.com>
11173 Reviewed by Darin Adler.
11175 Clang -Wcast-align gives an error in WebBasePluginPackage.mm
11176 https://bugs.webkit.org/show_bug.cgi?id=51144
11178 Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
11179 we were calling it on a byte array 32 bits at a time. While this is okay in practice,
11180 since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
11181 inline storage is at the beginning of the Vector, it is still better to fix this
11182 and silence the warning.
11184 * Plugins/WebBasePluginPackage.mm:
11185 (swapIntsInHeader):
11186 (-[WebBasePluginPackage isNativeLibraryData:]):
11188 2010-12-14 Mark Rowe <mrowe@apple.com>
11190 Reviewed by Sam Weinig.
11192 <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
11194 * History/WebHistoryItem.mm:
11195 (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
11196 always including the target in the output.
11198 2010-12-13 Alexey Proskuryakov <ap@apple.com>
11200 Reviewed by Adam Barth.
11202 https://bugs.webkit.org/show_bug.cgi?id=50953
11203 DNS Prefetch should be an opt-in feature
11205 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
11207 2010-12-13 Mike Thole <mthole@apple.com>
11209 Rubber-stamped by John Sullivan.
11211 https://bugs.webkit.org/show_bug.cgi?id=50956
11212 WebAuthenticationPanel.nib appears to have a cut-off sentence
11214 Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
11215 The contents of this text field are updated dynamically before the sheet is displayed.
11217 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
11218 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
11220 2010-12-13 Antti Koivisto <antti@apple.com>
11222 Reviewed by Alexey Proskuryakov.
11224 https://bugs.webkit.org/show_bug.cgi?id=50758
11225 <rdar://problem/8722094>
11226 Defer loading print stylesheets
11228 Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
11230 * WebView/WebView.mm:
11231 (+[WebView _setLoadResourcesSerially:forHost:]):
11232 * WebView/WebViewPrivate.h:
11234 2010-12-09 Matthew Delaney <mdelaney@apple.com>
11236 Reviewed by Simon Fraser.
11238 Adopt new CG API for canvas
11239 https://bugs.webkit.org/show_bug.cgi?id=50591
11241 * WebCoreSupport/WebSystemInterface.mm:
11243 2010-10-28 MORITA Hajime <morrita@google.com>
11245 Reviewed by Ojan Vafai.
11247 spellcheck does not check pasted text
11248 https://bugs.webkit.org/show_bug.cgi?id=40092
11250 Added asynchronous spell checking API to WebEditorClient using
11251 -[NSSpellChecker requestCheckingOfString].
11252 Note that WebEditorSpellCheckResponder is a small class to receive
11253 requested spell-checking result. Note that this feature is
11254 disabled at default.
11256 Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
11257 enable the feature from LayoutTestController.
11259 * WebCoreSupport/WebEditorClient.h:
11260 * WebCoreSupport/WebEditorClient.mm:
11261 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
11262 (-[WebEditorSpellCheckResponder perform]):
11263 (toCoreSpellingResult):
11264 (-[WebEditorSpellCheckResponder WTF::WebCore::]):
11265 (WebEditorClient::requestCheckingOfString):
11266 * WebView/WebPreferenceKeysPrivate.h:
11267 * WebView/WebPreferences.mm:
11268 (+[WebPreferences initialize]):
11269 (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
11270 (-[WebPreferences asynchronousSpellCheckingEnabled]):
11271 * WebView/WebPreferencesPrivate.h:
11272 * WebView/WebView.mm:
11273 (-[WebView _preferencesChangedNotification:]):
11275 2010-12-09 Anders Carlsson <andersca@apple.com>
11277 Fix a bug uncovered by clang++.
11279 * WebView/WebHTMLView.mm:
11280 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
11282 2010-12-09 Anders Carlsson <andersca@apple.com>
11284 Clang++ build fixes.
11286 Silence a couple of warnings.
11288 * WebView/WebFrame.mm:
11289 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
11290 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
11291 * WebView/WebTextCompletionController.mm:
11292 (-[WebTextCompletionController filterKeyDown:]):
11294 2010-12-09 David Hyatt <hyatt@apple.com>
11296 Reviewed by Dan Bernstein.
11298 https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
11299 writing-mode. This first part of the patch just patches Mac WebKit 1 views.
11301 * WebView/WebFrameView.mm:
11302 (-[WebFrameView _isVerticalDocument]):
11303 (-[WebFrameView _isFlippedDocument]):
11304 (-[WebFrameView _scrollToEndOfDocument]):
11305 (-[WebFrameView _pageInBlockProgressionDirection:]):
11306 (-[WebFrameView scrollPageUp:]):
11307 (-[WebFrameView scrollPageDown:]):
11309 2010-12-08 Andy Estes <aestes@apple.com>
11311 Reviewed by Darin Adler.
11313 Enable pre-HTML5 parser quirks for Apple Mail.app
11314 https://bugs.webkit.org/show_bug.cgi?id=50727
11316 * WebView/WebView.mm:
11317 (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
11318 application is Mail.app.
11320 2010-12-08 Brian Weinstein <bweinstein@apple.com>
11322 Reviewed by John Sullivan.
11324 REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
11325 https://bugs.webkit.org/show_bug.cgi?id=50683
11327 If our context menu item already has an action, don't overwrite the action with the context menu
11330 * WebView/WebHTMLView.mm:
11331 (setMenuItemTarget):
11333 2010-12-08 Anders Carlsson <andersca@apple.com>
11335 Remove an unused variable.
11337 * WebView/WebDynamicScrollBarsView.mm:
11338 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
11340 2010-12-07 Brian Weinstein <bweinstein@apple.com>
11342 Reviewed by John Sullivan.
11344 Layering Violation in ContextMenu - member variable of type HitTestResult
11345 https://bugs.webkit.org/show_bug.cgi?id=50586
11347 Update users of ContextMenu and ContextMenuController to match where the new functions
11350 * WebCoreSupport/WebContextMenuClient.mm:
11351 (WebContextMenuClient::getCustomMenuFromDefaultItems):
11352 (WebContextMenuClient::contextMenuItemSelected):
11353 * WebView/WebHTMLView.mm:
11354 (-[WebMenuTarget validateMenuItem:]):
11356 2010-12-07 Brian Weinstein <bweinstein@apple.com>
11358 Reviewed by John Sullivan.
11360 Part of Layering Violation in ContextMenu
11361 https://bugs.webkit.org/show_bug.cgi?id=50586
11363 Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
11364 was a layering violation. Also, make sure we set the menu item targets for all menu
11365 items before showing them, because the ContextMenu constructor doesn't do that anymore.
11367 * WebView/WebHTMLView.mm:
11368 (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
11369 (-[WebMenuTarget WebCore::]): Ditto.
11370 (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
11371 (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
11372 (-[WebMenuTarget validateMenuItem:]): Ditto.
11374 (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
11375 (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
11376 submenus), and calls setMenuItemTarget on them.
11377 (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
11380 2010-12-06 Darin Adler <darin@apple.com>
11382 Reviewed by Sam Weinig.
11384 Pass security origin to make local file decision correctly
11385 https://bugs.webkit.org/show_bug.cgi?id=48603
11387 * WebView/WebPDFView.mm:
11388 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
11390 2010-12-07 Martin Robinson <mrobinson@igalia.com>
11392 Unreviewed, rolling out r73392.
11393 http://trac.webkit.org/changeset/73392
11394 https://bugs.webkit.org/show_bug.cgi?id=50489
11396 This commit caused crashes on the GTK+ bots
11398 * WebView/WebFrame.mm:
11399 (-[WebFrame _canProvideDocumentSource]):
11401 2010-12-07 Kenichi Ishibashi <bashi@google.com>
11403 Reviewed by Kent Tamura.
11405 Let HTMLObjectElement be a form associated element
11406 https://bugs.webkit.org/show_bug.cgi?id=48821
11408 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
11410 * WebView/WebHTMLRepresentation.mm:
11411 (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
11412 FormAssociatedElement instead of HTMLFormControlElement.
11413 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
11415 2010-12-06 Nate Chapin <japhet@chromium.org>
11417 Reviewed by Adam Barth.
11419 Update calls to DocumentWriter.
11420 https://bugs.webkit.org/show_bug.cgi?id=50489
11422 * WebView/WebFrame.mm:
11423 (-[WebFrame _canProvideDocumentSource]):
11425 2010-12-06 Chris Marrin <cmarrin@apple.com>
11427 Reviewed by Simon Fraser.
11429 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
11430 https://bugs.webkit.org/show_bug.cgi?id=49388
11432 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
11433 GraphicsLayer::platformLayer().
11435 * WebCoreSupport/WebChromeClient.mm:
11436 (WebChromeClient::attachRootGraphicsLayer):
11438 2010-12-04 Dan Bernstein <mitz@apple.com>
11440 Reviewed by Sam Weinig.
11442 WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
11443 https://bugs.webkit.org/show_bug.cgi?id=50530
11445 * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
11446 * WebView/WebHTMLView.mm:
11447 (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
11448 which is passed through to WebCore.
11449 * WebView/WebPDFView.mm:
11450 (isFrameInRange): Added this helper function.
11451 (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
11452 a check if the frame is in the range.
11453 * WebView/WebView.mm:
11454 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
11455 (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
11456 parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
11457 * WebView/WebViewPrivate.h:
11459 2010-12-03 Sam Weinig <sam@webkit.org>
11461 Reviewed by Maciej Stachowiak.
11463 Enable <a ping> for Mac/Windows/WebKit2 builds
11464 <rdar://problem/8504473>
11465 https://bugs.webkit.org/show_bug.cgi?id=50488
11467 * WebView/WebPreferences.mm:
11468 (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
11470 2010-12-03 Jia Pu <jpu@apple.com>
11472 Reviewed by Darin Adler.
11474 Need to move all code that applies correction into correction panel callback.
11475 https://bugs.webkit.org/show_bug.cgi?id=50426
11476 <rdar://problem/8720832>
11478 * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
11480 * WebCoreSupport/WebEditorClient.mm:
11481 (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
11482 (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
11483 (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
11485 2010-12-02 Simon Fraser <simon.fraser@apple.com>
11487 Revert r73217 and r73227 because of continued bustage.
11489 * WebCoreSupport/WebChromeClient.mm:
11490 (WebChromeClient::attachRootGraphicsLayer):
11492 2010-12-02 Chris Marrin <cmarrin@apple.com>
11494 Reviewed by Simon Fraser.
11496 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
11497 https://bugs.webkit.org/show_bug.cgi?id=49388
11499 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
11500 GraphicsLayer::platformLayer().
11502 * WebCoreSupport/WebChromeClient.mm:
11503 (WebChromeClient::attachRootGraphicsLayer):
11505 2010-12-02 Mark Rowe <mrowe@apple.com>
11507 Reviewed by Beth Dakin.
11509 <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
11511 * Misc/WebNSFileManagerExtras.m:
11512 (setMetaData): Create an autorelease pool for the duration of the thread body.
11514 2010-12-02 John Knottenbelt <jknotten@chromium.org>
11516 Reviewed by Steve Block.
11518 Move requestGeolocationPermissionForFrame to GeolocationClient
11519 https://bugs.webkit.org/show_bug.cgi?id=50061
11521 This change facilitates client-based geolocation implementation by
11522 bringing together permission control into the geolocation client
11525 Move method ChromeClient::requestGeolocationPermissionForFrame to
11526 GeolocationClient::requestPermission, and supporting class
11527 WebGeolocationPolicyListener. The moved code is unchanged except
11528 that requestPermission now takes only one argument (Geolocation*)
11529 and the Frame parameter is retrieved from the Geolocation object.
11531 * WebCoreSupport/WebChromeClient.h:
11532 * WebCoreSupport/WebChromeClient.mm:
11533 * WebCoreSupport/WebGeolocationClient.h:
11534 (WebGeolocationClient::cancelPermissionRequest):
11535 * WebCoreSupport/WebGeolocationClient.mm:
11536 (WebGeolocationClient::requestPermission):
11537 (-[WebGeolocationPolicyListener initWithGeolocation:]):
11538 (-[WebGeolocationPolicyListener allow]):
11539 (-[WebGeolocationPolicyListener deny]):
11541 2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
11543 Reviewed by Eric Carlson.
11545 Style Fixes in WebPluginController
11546 https://bugs.webkit.org/show_bug.cgi?id=50397
11548 * Plugins/WebPluginController.mm:
11549 (-[WebPluginController startAllPlugins]):
11550 (-[WebPluginController stopAllPlugins]):
11552 2010-12-02 John Sullivan <sullivan@apple.com>
11554 Reviewed by Adam Roben.
11556 Slightly speculative fix for:
11558 <rdar://problem/8712674>
11559 <https://bugs.webkit.org/show_bug.cgi?id=50393>
11560 setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
11562 * Panels/WebAuthenticationPanel.m:
11563 (-[WebAuthenticationPanel setUpForChallenge:]):
11564 If the realm is nil, use @"" instead.
11566 2010-12-01 Jia Pu <jpu@apple.com>
11568 Reviewed by Darin Adler.
11570 Support multiple correction candidates panel for misspelled word on Mac OS X.
11571 https://bugs.webkit.org/show_bug.cgi?id=50137
11572 <rdar://problem/8568059>
11574 This patch is for supporting multiple correction suggestion panel on Mac OS X.
11575 The behavior and implementation is similar to that of reversion candiate panel.
11577 * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
11579 * WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class.
11580 Added code to handle new multiple suggestion canidate panel type.
11581 (WebEditorClient::showCorrectionPanel):
11582 (WebEditorClient::getGuessesForWord):
11584 2010-12-01 David Hyatt <hyatt@apple.com>
11586 Reviewed by Darin Adler.
11588 https://bugs.webkit.org/show_bug.cgi?id=46645
11590 Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
11591 recently added for horizontal RTL documents and applies it to writing modes as well. Now the
11592 scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
11594 This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
11595 makes them behave the same as the cross-platform code (allowing for cross-platform results to be
11598 * WebView/WebDynamicScrollBarsView.mm:
11599 (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
11600 (-[WebDynamicScrollBarsView updateScrollers]):
11601 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
11602 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
11603 (-[WebDynamicScrollBarsView scrollOrigin]):
11604 * WebView/WebFrameView.mm:
11605 (-[WebFrameView _scrollToBeginningOfDocument]):
11606 (-[WebFrameView _scrollToEndOfDocument]):
11608 2010-11-29 Dan Bernstein <mitz@apple.com>
11610 Reviewed by Darin Adler.
11612 WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
11613 https://bugs.webkit.org/show_bug.cgi?id=50038
11614 Based on a patch from Darin Adler.
11616 * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
11617 replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
11618 method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
11619 method. Made WebHTMLView conform to the new protocol.
11620 * WebView/WebHTMLView.mm:
11621 (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
11622 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
11623 -findString:options:.
11624 (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
11625 (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
11626 * WebView/WebPDFView.mm:
11627 (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
11628 * WebView/WebView.mm:
11629 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
11630 -countMatchesForText:options:highlight:limit:markMatches.
11631 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
11632 (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
11633 -findString:options:.
11634 (incrementFrame): Changed to use WebFindOptions.
11635 (findString): Added this helper method that performs the search using the best supported
11636 method for the document view.
11637 (-[WebView findString:options:]): Changed -searchFor::::: into this.
11638 (-[WebView canMarkAllTextMatches]):
11639 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
11641 (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
11642 (-[WebView rectsForTextMatches]): Ditto.
11643 * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
11644 of countMatchesForText:.
11646 2010-11-29 Jeremy Moskovich <jeremy@chromium.org>
11648 Reviewed by David Hyatt.
11650 Right-to-left pages should be scrollable to reveal left overflow.
11651 https://bugs.webkit.org/show_bug.cgi?id=23556
11653 Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
11654 Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
11655 pages with a left overflow.
11657 * WebView/WebDynamicScrollBarsView.h:
11658 * WebView/WebDynamicScrollBarsView.mm:
11659 (-[WebDynamicScrollBarsView inProgramaticScroll]):
11660 (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
11661 (-[WebDynamicScrollBarsView updateScrollers]):
11662 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
11663 (-[WebDynamicScrollBarsView setScrollOriginX:]):
11664 (-[WebDynamicScrollBarsView scrollOriginX]):
11665 * WebView/WebFrameView.mm:
11666 (-[WebFrameView _scrollToBeginningOfDocument]):
11667 (-[WebFrameView _scrollToEndOfDocument]):
11668 * WebView/WebHTMLView.mm:
11669 (-[WebHTMLView _frameOrBoundsChanged]):
11671 2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
11673 Reviewed by Tony Chang.
11675 SelectionController::typingStyle() should return EditingStyle*
11676 https://bugs.webkit.org/show_bug.cgi?id=49813
11678 Changed the return value of SelectionController::typingStyle() to EditingStyle*.
11679 Also added SelectionController::copyTypingStyle() to copy the typing style
11680 as an instance of CSSMutableStyleDeclaration.
11682 No tests are added since this is no behavioral change.
11684 * WebView/WebFrame.mm:
11685 (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
11687 2010-11-19 Michael Saboff <msaboff@apple.com>
11689 Reviewed by Sam Weinig
11691 Remove DOMSVGAnimatedPathData.h from all: target to fix build.
11693 * MigrateHeaders.make:
11695 2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
11697 Reviewed by Dirk Schulze.
11699 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
11700 https://bugs.webkit.org/show_bug.cgi?id=49580
11702 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
11704 2010-11-18 Mark Rowe <mrowe@apple.com>
11706 Rubber-stamped by Adam Roben.
11708 <rdar://problem/8602509&8602717&8602724> Enable compaction support.
11710 * Configurations/WebKit.xcconfig:
11712 2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
11714 Unreviewed, rolling out r72288.
11715 http://trac.webkit.org/changeset/72288
11716 https://bugs.webkit.org/show_bug.cgi?id=49730
11718 'krit attempted to do that, but revert got stuck' (Requested
11719 by antonm on #webkit).
11721 * WebView/WebRenderLayer.mm:
11723 2010-11-17 Nikolas Zimmermann <nzimmermann@rim.com>
11725 Reviewed by Dirk Schulze.
11727 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
11728 https://bugs.webkit.org/show_bug.cgi?id=49580
11730 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
11732 2010-11-16 Stephanie Lewis <slewis@apple.com>
11734 Reviewed by Geoff Garen.
11736 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
11738 Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
11739 every WebView, and the WebKit API doesn't support that ownership model.
11741 * WebView/WebDeviceOrientationProviderMock.h:
11742 * WebView/WebDeviceOrientationProviderMock.mm:
11743 (+[WebDeviceOrientationProviderMock shared]):
11745 2010-11-16 Dave Hyatt <hyatt@apple.com>
11747 Reviewed by Dan Bernstein.
11749 https://bugs.webkit.org/show_bug.cgi?id=11004
11751 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
11752 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
11753 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
11754 of the constructor rather than using [NSFont pointSize].
11756 https://bugs.webkit.org/show_bug.cgi?id=49582
11758 Negative leading is not handled correctly. There are two bugs here. The first is that
11759 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
11760 set them before so that we can allow them to be < 0.
11762 The second issue is that we should understand where fonts will end up relative to
11763 our baseline (excluding line height), and only allow those boxes to impact ascent and
11764 descent if the actual font box (without factoring in line height) is above or below the
11765 root line box baseline.
11767 Added fast/css/negative-leading.html
11769 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
11771 * Misc/WebKitNSStringExtras.mm:
11772 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
11773 (-[NSString _web_widthWithFont:]):
11774 * Misc/WebStringTruncator.mm:
11776 * WebView/WebPreferences.mm:
11777 (+[WebPreferences initialize]):
11779 2010-11-16 Anders Carlsson <andersca@apple.com>
11783 * WebCoreSupport/WebFrameLoaderClient.mm:
11785 2010-11-14 Kent Tamura <tkent@chromium.org>
11787 Reviewed by Andreas Kling.
11789 KeyboardEvent::keyIdentifier() should return "const String&"
11790 https://bugs.webkit.org/show_bug.cgi?id=49426
11792 * WebCoreSupport/WebEditorClient.mm:
11793 (selectorForKeyEvent):
11794 Change the type of a variable to have keyIdentifier(); String -> const String&
11796 2010-11-12 John Knottenbelt <jknotten@chromium.org>
11798 Reviewed by Steve Block.
11800 Rename GeolocationControllerClient to GeolocationClient.
11801 https://bugs.webkit.org/show_bug.cgi?id=49259
11803 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
11804 (WebGeolocationClient::webView):
11805 (WebGeolocationClient::setEnableHighAccuracy):
11806 * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
11807 (WebGeolocationClient::WebGeolocationClient):
11808 (WebGeolocationClient::geolocationDestroyed):
11809 (WebGeolocationClient::startUpdating):
11810 (WebGeolocationClient::stopUpdating):
11811 (WebGeolocationClient::lastPosition):
11813 * WebView/WebView.mm:
11814 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
11816 2010-11-10 Beth Dakin <bdakin@apple.com>
11818 Reviewed by Simon Fraser.
11820 Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
11821 -[WebView _scaleWebView:] should take and origin and scroll the
11823 -and corresponding-
11824 <rdar://problem/8643921>
11826 * WebView/WebView.mm:
11827 (-[WebView _scaleWebView:atOrigin:]):
11828 * WebView/WebViewPrivate.h:
11830 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
11832 Reviewed by David Hyatt.
11834 HTML5 Ruby support should be mandatory feature
11835 https://bugs.webkit.org/show_bug.cgi?id=49272
11837 Remove Ruby as optional feature.
11839 * Configurations/FeatureDefines.xcconfig:
11841 2010-11-08 Ned Holbrook <nholbrook@apple.com>
11843 Reviewed by Adam Barth.
11845 Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
11846 https://bugs.webkit.org/show_bug.cgi?id=48886
11848 * WebCoreSupport/WebSystemInterface.mm:
11849 (InitWebCoreSystemInterface):
11851 2010-11-08 Nate Chapin <japhet@chromium.org>
11853 Unreviewed, build fix.
11855 Clumsy typo in r71562.
11857 * Plugins/Hosted/HostedNetscapePluginStream.mm:
11858 (WebKit::HostedNetscapePluginStream::start):
11860 2010-11-08 Nate Chapin <japhet@chromium.org>
11862 Reviewed by Alexey Proskuryakov.
11864 Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
11866 * Plugins/Hosted/HostedNetscapePluginStream.mm:
11867 (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
11868 * Plugins/WebNetscapePluginStream.mm:
11869 (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
11870 * WebView/WebView.mm:
11871 (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
11873 2010-11-08 Anders Carlsson <andersca@apple.com>
11875 Reviewed by Dan Bernstein.
11877 Plug-in views should not assume that plugins are RenderEmbeddedObjects
11878 https://bugs.webkit.org/show_bug.cgi?id=49196
11879 <rdar://problem/8638467>
11881 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11882 (-[WebHostedNetscapePluginView pluginHostDied]):
11884 2010-11-08 Alexey Proskuryakov <ap@apple.com>
11886 Reviewed by Darin Adler.
11888 https://bugs.webkit.org/show_bug.cgi?id=48685
11889 Notify UI process about focused frame
11891 Added an empty implementation of the new ChromeClient method.
11893 * WebCoreSupport/WebChromeClient.h:
11894 * WebCoreSupport/WebChromeClient.mm:
11895 (WebChromeClient::focusedFrameChanged):
11897 2010-11-08 Anders Carlsson <andersca@apple.com>
11901 * MigrateHeaders.make:
11903 2010-11-08 Anders Carlsson <andersca@apple.com>
11905 Reviewed by Adam Roben.
11907 Remove use of HIGetScaleFactor
11908 https://bugs.webkit.org/show_bug.cgi?id=49186
11909 <rdar://problem/8618410>
11911 Scale factors can vary on a display-by-display basis and it doesn't make sense
11912 to compute scale factor event coordinates like this.
11914 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
11917 2010-11-08 Simon Fraser <simon.fraser@apple.com>
11919 Reviewed by Sam Weinig.
11921 Allow applets to participate in accelerated compositing
11922 https://bugs.webkit.org/show_bug.cgi?id=49117
11923 <rdar://problem/8625819>
11925 If Java is being loaded via the Netscape Plugin API, create a
11926 NetscapePluginWidget so that it has an implementation of platformLayer().
11928 Also clean up by using early returns.
11930 * WebCoreSupport/WebFrameLoaderClient.mm:
11932 2010-11-07 Adam Barth <abarth@webkit.org>
11934 Reviewed by Eric Seidel.
11936 Rename Cache to MemoryCache
11937 https://bugs.webkit.org/show_bug.cgi?id=49159
11939 * Misc/WebCache.mm:
11940 (+[WebCache statistics]):
11941 * WebCoreSupport/WebDeviceOrientationClient.mm:
11942 (WebDeviceOrientationClient::setController):
11943 * WebView/WebView.mm:
11945 2010-11-05 Alexey Proskuryakov <ap@apple.com>
11947 Reviewed by Darin Adler.
11949 https://bugs.webkit.org/show_bug.cgi?id=49100
11950 ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
11952 * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
11953 Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
11954 (see bug comments), and there seems to be no harm in executing this function in that case.
11956 2010-11-05 Chris Marrin <cmarrin@apple.com>
11958 Reviewed by Simon Fraser.
11960 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
11961 https://bugs.webkit.org/show_bug.cgi?id=49073
11963 * WebView/WebFrame.mm:
11964 (-[WebFrame _suspendAnimations]):
11965 (-[WebFrame _resumeAnimations]):
11967 2010-11-04 Alexey Proskuryakov <ap@apple.com>
11969 Reviewed by Darin Adler.
11971 https://bugs.webkit.org/show_bug.cgi?id=49008
11972 <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
11974 Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
11975 the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
11976 deleted during wait:
11978 - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
11981 We didn't recognize the latter.
11983 * Plugins/Hosted/NetscapePluginHostProxy.mm:
11984 (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
11985 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
11986 (WebKit::NetscapePluginInstanceProxy::waitForReply):
11987 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
11988 (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
11990 2010-11-05 Chris Marrin <cmarrin@apple.com>
11992 Reviewed by Simon Fraser.
11994 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
11995 https://bugs.webkit.org/show_bug.cgi?id=46945
11997 * WebView/WebFrame.mm:
11998 (-[WebFrame _suspendAnimations]):
11999 (-[WebFrame _resumeAnimations]):
12001 2010-11-04 Jia Pu <jpu@apple.com>
12003 Reviewed by Dan Bernstein.
12005 reversion bubble in WebViews
12006 https://bugs.webkit.org/show_bug.cgi?id=47630
12007 <rdar://problem/8530960>
12009 This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
12011 * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
12012 * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
12013 change to use new reversion API in AppKit.
12014 (WebEditorClient::WebEditorClient):
12015 (WebEditorClient::~WebEditorClient):
12016 (WebEditorClient::respondToChangedSelection):
12017 (WebEditorClient::showCorrectionPanel):
12018 (WebEditorClient::dismissCorrectionPanel):
12019 (WebEditorClient::isShowingCorrectionPanel):
12021 2010-11-04 Mike Thole <mthole@apple.com>
12023 Reviewed by Dan Bernstein.
12025 Title for images should use localized numerals
12026 https://bugs.webkit.org/show_bug.cgi?id=49017
12028 * WebCoreSupport/WebPlatformStrategies.mm:
12029 (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
12031 2010-11-02 Daniel Bates <dbates@rim.com>
12033 Reviewed by Adam Barth.
12035 For unnamed frames, window.name returns a generated name
12036 https://bugs.webkit.org/show_bug.cgi?id=6751
12040 Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.
12042 * WebView/WebFrame.mm:
12043 (-[WebFrame name]):
12045 2010-11-01 Brady Eidson <beidson@apple.com>
12047 Reviewed by Anders Carlsson.
12049 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
12050 Context menu support for WebKit 2.
12052 * WebCoreSupport/WebChromeClient.h:
12053 (WebChromeClient::showContextMenu):
12055 2010-10-29 Daniel Bates <dbates@rim.com>
12057 No review, rolling out 70971.
12058 http://trac.webkit.org/changeset/70971
12059 https://bugs.webkit.org/show_bug.cgi?id=6751
12061 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
12062 it caused layout test failures on all bots. In particular, the
12063 child count in a generated frame name differs after this patch. We need
12064 to look into this further.
12066 * WebView/WebFrame.mm:
12067 (-[WebFrame name]):
12069 2010-10-28 Antonio Gomes <agomes@rim.com>
12071 Reviewed by Ojan Vafai.
12073 Needs a "LinuxEditingBehavior", perhaps with a better name
12074 https://bugs.webkit.org/show_bug.cgi?id=36627
12076 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
12078 * WebView/WebFrame.mm:
12080 * WebView/WebPreferencesPrivate.h:
12082 2010-10-29 Daniel Bates <dbates@rim.com>
12084 Reviewed by Adam Barth.
12086 For unnamed frames, window.name returns a generated name
12087 https://bugs.webkit.org/show_bug.cgi?id=6751
12089 Modified Mac-port to use FrameTree::uniqueName().
12091 * WebView/WebFrame.mm:
12092 (-[WebFrame name]):
12094 2010-10-29 Darin Adler <darin@apple.com>
12096 Reviewed by Sam Weinig.
12098 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
12099 https://bugs.webkit.org/show_bug.cgi?id=48574
12101 * History/WebBackForwardList.mm:
12102 Use BackForwardListImpl.
12104 2010-10-29 Alexey Proskuryakov <ap@apple.com>
12106 Rubber-stamped by Sam Weinig.
12108 Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
12109 create views for subframes.
12111 * WebView/WebViewData.h: Double negation is better than a lie.
12113 2010-10-27 Jer Noble <jer.noble@apple.com>
12115 Reviewed by Darin Adler.
12117 Full screen video in Safari (still) exits full-screen if you switch to another
12118 app on a multi-display system.
12119 https://bugs.webkit.org/show_bug.cgi?id=47364
12120 <rdar://problem/8382299>
12122 The FullScreen window does not technically close when it deactivates, but the
12123 two NSWindows that make up the FullScreen feature should not hide when deactivated.
12125 * WebView/WebVideoFullscreenController.mm:
12126 (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
12127 (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
12128 * WebView/WebVideoFullscreenHUDWindowController.mm:
12129 (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
12131 2010-10-29 Alexey Proskuryakov <ap@apple.com>
12133 Reviewed by Darin Adler.
12135 https://bugs.webkit.org/show_bug.cgi?id=48576
12136 Let WebKit2 client know when a frame is a frameset
12138 Added a blank implementation of the new FrameLoaderClient method.
12140 * WebCoreSupport/WebFrameLoaderClient.h:
12141 * WebCoreSupport/WebFrameLoaderClient.mm:
12142 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
12144 2010-10-29 Csaba Osztrogonác <ossy@webkit.org>
12146 Reviewed by Adam Roben and David Kilzer.
12148 Fix and cleanup of build systems
12149 https://bugs.webkit.org/show_bug.cgi?id=48342
12151 * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
12153 2010-10-28 Dan Bernstein <mitz@apple.com>
12155 Reviewed by Mark Rowe.
12157 LLVM compiler build fix
12159 * Misc/WebDownload.mm:
12160 (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
12161 id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
12163 2010-10-28 Ivan Krstić <ike@apple.com>
12165 Reviewed by Mark Rowe.
12167 Remove unused experimental proxied panel interface.
12168 <rdar://problem/7237059>
12170 * Plugins/Hosted/NetscapePluginHostManager.h:
12171 * Plugins/Hosted/NetscapePluginHostManager.mm:
12172 (WebKit::NetscapePluginHostManager::hostForPlugin):
12173 (WebKit::NetscapePluginHostManager::spawnPluginHost):
12174 (WebKit::NetscapePluginHostManager::instantiatePlugin):
12175 * Plugins/Hosted/NetscapePluginHostProxy.mm:
12176 * Plugins/Hosted/WebKitPluginClient.defs:
12177 * Plugins/Hosted/WebKitPluginHost.defs:
12178 * WebCoreSupport/WebSystemInterface.mm:
12179 (InitWebCoreSystemInterface):
12180 * WebView/WebPreferenceKeysPrivate.h:
12181 * WebView/WebPreferences.mm:
12182 (+[WebPreferences initialize]):
12183 * WebView/WebPreferencesPrivate.h:
12185 2010-10-27 Pratik Solanki <psolanki@apple.com>
12187 Reviewed by Darin Adler.
12189 Improve memSize calculation in [WebView _setCacheModel]
12190 https://bugs.webkit.org/show_bug.cgi?id=48484
12192 * WebView/WebView.mm:
12193 (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
12194 (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
12195 bigger power of 2. Also update WebCore cache settings.
12197 2010-10-26 Darin Adler <darin@apple.com>
12199 Reviewed by Sam Weinig.
12201 WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
12202 https://bugs.webkit.org/show_bug.cgi?id=42322
12203 rdar://problem/8193631
12205 WebKitTestRunner needs to support layoutTestController.clearBackForwardList
12206 https://bugs.webkit.org/show_bug.cgi?id=42333
12207 rdar://problem/8193643
12209 * History/WebBackForwardList.mm:
12210 (core): Return BackForwardListImpl.
12211 (kit): Take BackForwardListImpl.
12212 (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
12213 (-[WebBackForwardList dealloc]): Ditto.
12214 (-[WebBackForwardList finalize]): Ditto.
12215 (-[WebBackForwardList description]): Ditto.
12216 (-[WebBackForwardList setPageCacheSize:]): Ditto.
12217 (-[WebBackForwardList pageCacheSize]): Ditto.
12218 * History/WebBackForwardListInternal.h: Ditto.
12219 * WebView/WebFrameView.mm:
12220 (-[WebFrameView keyDown:]): Ditto.
12221 * WebView/WebView.mm:
12222 (-[WebView initWithCoder:]): Ditto.
12223 (-[WebView encodeWithCoder:]): Ditto.
12224 (-[WebView backForwardList]): Ditto.
12225 (-[WebView setMaintainsBackForwardList:]): Ditto.
12227 2010-10-27 Chris Rogers <crogers@google.com>
12229 Reviewed by Chris Marrin.
12231 Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
12232 https://bugs.webkit.org/show_bug.cgi?id=48279
12234 * Configurations/FeatureDefines.xcconfig:
12236 2010-10-27 Beth Dakin <bdakin@apple.com>
12238 Reviewed by Darin Adler.
12240 Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
12241 SPI to scale a WebView
12242 -and corresponding-
12243 <rdar://problem/8107667>
12245 This patch adds SPI to Mac WebKit that scales the page by the given
12248 * WebView/WebView.mm:
12249 (-[WebView _scaleWebView:]):
12250 (-[WebView _viewScaleFactor]):
12251 * WebView/WebViewPrivate.h:
12253 2010-10-27 Dan Bernstein <mitz@apple.com>
12255 Reviewed by Darin Adler.
12257 REGRESSION (r70335): Incorrect article layout in Safari Reader
12258 https://bugs.webkit.org/show_bug.cgi?id=48436
12260 * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
12261 * WebView/WebView.mm:
12262 (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
12263 versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
12264 (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
12265 based on the above.
12267 2010-10-18 Jer Noble <jer.noble@apple.com>
12269 Reviewed by Eric Carlson.
12271 Safari fullscreen media element tickles when it should not.
12273 https://bugs.webkit.org/show_bug.cgi?id=47861
12275 * WebView/WebVideoFullscreenController.mm:
12276 (-[WebVideoFullscreenController updatePowerAssertions]):
12278 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
12280 Reviewed by Dmitry Titov.
12282 Resource tracking failure when trying to move a frame between documents
12283 https://bugs.webkit.org/show_bug.cgi?id=44713
12285 * WebCoreSupport/WebFrameLoaderClient.h:
12286 * WebCoreSupport/WebFrameLoaderClient.mm:
12287 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
12289 (WebFrameLoaderClient::transferLoadingResourceFromPage):
12290 Update resource tracking for a resource load that has been transferred
12293 2010-10-25 Oliver Hunt <oliver@apple.com>
12295 Reviewed by Gavin Barraclough.
12297 Remove exec and globalData arguments from jsNumber
12298 https://bugs.webkit.org/show_bug.cgi?id=48270
12300 Mechanical removal of exec parameter to jsNumber
12302 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12303 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
12304 * Plugins/Hosted/ProxyInstance.mm:
12305 (WebKit::ProxyInstance::numberValue):
12307 2010-10-24 Dan Bernstein <mitz@apple.com>
12309 Reviewed by Anders Carlsson.
12311 Expose HitTestResult::absoluteMediaURL() via WebKit API
12312 https://bugs.webkit.org/show_bug.cgi?id=48219
12314 * Misc/WebElementDictionary.mm:
12315 (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
12317 (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
12318 * WebKit.exp: Export WebElementMediaURLKey.
12319 * WebView/WebView.mm: Define WebElementMediaURLKey.
12320 * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
12322 2010-10-24 Dan Bernstein <mitz@apple.com>
12324 Reviewed by Simon Fraser.
12326 Removed deprecated methods from the WebHTMLHighlighter private protocol.
12328 * WebCoreSupport/WebChromeClient.mm:
12329 (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
12331 (WebChromeClient::paintCustomHighlight): Call
12332 -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
12333 * WebView/WebHTMLViewPrivate.h:
12335 2010-10-23 Xan Lopez <xlopez@igalia.com>
12337 Reviewed by Sam Weinig.
12339 Unify globalData APIs
12340 https://bugs.webkit.org/show_bug.cgi?id=47969
12342 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12343 (WebKit::NetscapePluginInstanceProxy::evaluate):
12344 (WebKit::NetscapePluginInstanceProxy::invoke):
12345 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
12346 (WebKit::NetscapePluginInstanceProxy::construct):
12347 * WebView/WebScriptDebugDelegate.mm:
12348 (-[WebScriptCallFrame evaluateWebScript:]):
12350 2010-10-23 David Kilzer <ddkilzer@apple.com>
12352 <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
12354 Reviewed by Sam Weinig.
12356 The only method defined in WebHTMLRepresentationInternal.h is
12357 also defined in WebHTMLRepresentation.h, so use that instead.
12359 * WebView/WebHTMLRepresentationInternal.h: Removed.
12361 2010-10-23 Alexey Proskuryakov <ap@apple.com>
12363 Reviewed by Anders Carlsson.
12365 https://bugs.webkit.org/show_bug.cgi?id=48083
12366 <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
12368 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
12370 2010-10-22 Sam Weinig <sam@webkit.org>
12372 Reviewed by Anders Carlsson.
12374 WebKit2 needs to pass the current event modifier flags when requesting a new window
12375 https://bugs.webkit.org/show_bug.cgi?id=48140
12377 * WebCoreSupport/WebChromeClient.h:
12378 * WebCoreSupport/WebChromeClient.mm:
12379 (WebChromeClient::createWindow):
12380 * WebCoreSupport/WebFrameLoaderClient.h:
12381 * WebCoreSupport/WebFrameLoaderClient.mm:
12382 (WebFrameLoaderClient::dispatchCreatePage):
12383 Add NavigationAction parameter.
12385 2010-10-21 Andy Estes <aestes@apple.com>
12387 Reviewed by Eric Carlson.
12389 WebKit shouldn't load a plug-in based on file extension if a MIME type
12391 https://bugs.webkit.org/show_bug.cgi?id=48046
12393 If a MIME type is specified in an object or embed element, and that MIME
12394 type isn't supported by an installed plug-in, WebKit shouldn't attempt
12395 to find a plug-in based on the file extension of the url attribute.
12396 Doing so can lead to cases where a plug-in is loaded that can't handle
12397 resources of the MIME type specified by the author.
12399 * WebCoreSupport/WebFrameLoaderClient.mm:
12400 (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
12401 extension if MIME type is the empty string.
12403 2010-10-20 Simon Fraser <simon.fraser@apple.com>
12405 Reviewed by Dan Bernstein.
12407 Composited elements drawn twice when WebView is layer-backed
12408 https://bugs.webkit.org/show_bug.cgi?id=48024
12409 <rdar://problem/7916580>
12411 When drawing content in a layer-backed WebView, WebFrame's test
12412 for drawing to a bitmap succeeded, causing us to paint flattened
12413 compositing layers into the view. They would also be rendered
12414 by the normal compositing path, resulting in double rendering.
12416 Fix this by detecting when the WebHTMLView is being drawn into
12417 a layer, and avoiding flattening in that case.
12419 * WebView/WebFrame.mm:
12420 (-[WebFrame _showFlattenedCompositingLayers:]):
12421 (-[WebFrame _drawRect:contentsOnly:]):
12422 * WebView/WebHTMLView.mm:
12423 (-[WebHTMLView drawLayer:inContext:]):
12424 (-[WebHTMLView _web_isDrawingIntoLayer]):
12425 * WebView/WebHTMLViewInternal.h:
12427 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
12429 Reviewed by David Levin.
12431 Repost the DatabaseTracker notifications to the main thread, if needed.
12432 https://bugs.webkit.org/show_bug.cgi?id=40655
12434 * Storage/WebDatabaseTrackerClient.mm:
12435 (DidModifyOriginData::dispatchToMainThread):
12436 (DidModifyOriginData::DidModifyOriginData):
12437 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
12438 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
12439 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
12441 2010-10-20 Simon Fraser <simon.fraser@apple.com>
12443 Reviewed by Darin Adler.
12445 REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
12446 https://bugs.webkit.org/show_bug.cgi?id=47369
12448 r46947 added code that limits the size of the layer-backed view on Leopard when
12449 the page height exceeds 4096px (later adjusted to 2048px in r48401).
12451 Later, r67576 altered the geometry flipping behavior to push the geometry flipping
12452 down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
12453 to account for layer-backed view size-limiting was not fixed at the same time.
12454 This change corrects that.
12456 * WebView/WebHTMLView.mm:
12457 (-[WebHTMLView _updateLayerHostingViewPosition]):
12459 2010-10-19 Simon Fraser <simon.fraser@apple.com>
12461 Reviewed by Dan Bernstein.
12463 <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
12465 AppKit has some special code to prevent it meddling with view's layers
12466 under layer-backed WebViews. When a layer-backed WebView became composited,
12467 this caused our layer to remain zero-sized. Fix this by manually
12468 setting the geometry for our layer, if the WebHTMLView has a layer.
12470 This does not seem to be a problem if the WebView becomes layer-backed, or
12471 stops being layer-backed after the WebView starts using compositing.
12473 * WebView/WebHTMLView.mm:
12474 (-[WebHTMLView attachRootLayer:]):
12476 2010-10-20 Dirk Schulze <krit@webkit.org>
12478 Reviewed by Nikolas Zimmermann.
12480 Merge ColorSpace and ImageColorSpace enums
12481 https://bugs.webkit.org/show_bug.cgi?id=47922
12483 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
12484 to follow webkit style rules.
12486 * Misc/WebKitNSStringExtras.mm:
12487 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
12489 2010-10-19 Alexey Proskuryakov <ap@apple.com>
12491 Reviewed by Anders Carlsson.
12493 https://bugs.webkit.org/show_bug.cgi?id=47933
12494 <rdar://problem/8494337> navigator.language doesn't work in WebKit2
12496 * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
12497 We need to keep _webkit_preferredLanguageCode for Safari.
12499 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
12500 Initialize wkCopyCFLocalizationPreferredName.
12502 * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
12504 2010-10-18 Alexey Proskuryakov <ap@apple.com>
12506 Reviewed by David Kilzer.
12508 https://bugs.webkit.org/show_bug.cgi?id=47864
12509 Convert WebNSUserDefaultsExtras.m to .mm
12511 Also, fixed some issues in the process:
12512 - removed locking, which was only necessary when this code was in Foundation;
12513 - fixed notification center observer to actually work (previously, it picked up changes
12514 when application preferences changed, not when system language did);
12515 - removed unused NSString category;
12518 * Misc/WebNSUserDefaultsExtras.m: Removed.
12519 * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
12520 (createHTTPStyleLanguageCode):
12521 (+[NSUserDefaults _webkit_defaultsDidChange]):
12522 (addLanguageChangeObserver):
12523 (+[NSUserDefaults _webkit_preferredLanguageCode]):
12525 2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
12527 Reviewed by Eric Seidel.
12529 Switch to using the new Carbon NPAPI event declarations, and remove
12532 https://bugs.webkit.org/show_bug.cgi?id=40784
12534 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
12535 (WebNetscapePluginEventHandlerCarbon::mouseEntered):
12536 (WebNetscapePluginEventHandlerCarbon::mouseExited):
12537 (WebNetscapePluginEventHandlerCarbon::mouseMoved):
12538 (WebNetscapePluginEventHandlerCarbon::focusChanged):
12540 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
12542 Reviewed by Timothy Hatcher.
12544 Web Inspector: disable private browsing for inspector
12545 https://bugs.webkit.org/show_bug.cgi?id=47827
12547 * WebCoreSupport/WebInspectorClient.mm:
12548 (-[WebInspectorWindowController init]):
12550 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
12552 Reviewed by Pavel Feldman.
12554 Web Inspector: inspector settings/properties/states management
12555 should be extracted into separate class.
12557 We have a lot of flags/values in InspectorController.
12558 Some flags are persisting into profile.
12559 Others are part of inspector state for frontend.
12560 All these flags should keep their values after navigation.
12561 It'd be better to extract these flags/values into separate
12562 class which will care about theirs lifetime.
12564 https://bugs.webkit.org/show_bug.cgi?id=47275
12566 * WebCoreSupport/WebInspectorClient.mm:
12567 (-[WebInspectorWindowController showWindow:]):
12568 (-[WebInspectorWindowController attach]):
12569 (-[WebInspectorWindowController detach]):
12571 2010-10-13 Gavin Barraclough <barraclough@apple.com>
12573 Reviewed by Oliver Hunt.
12575 https://bugs.webkit.org/show_bug.cgi?id=43987
12576 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
12577 to construct their internal result string. Remove ScriptString (this is now
12580 * WebCoreSupport/WebFrameLoaderClient.mm:
12582 2010-10-12 Andy Estes <aestes@apple.com>
12584 Rubber-stamped by Darin Adler.
12586 Check in some cleanup from the previous commit.
12588 * WebView/WebView.mm:
12589 (leakMailQuirksUserScriptPath): Renamed to indicate that this function
12591 (-[WebView _injectMailQuirksScript]): Moved a static initialization from
12592 a separate class method into the only method that used it and removed
12593 the now-unnecessary class method.
12595 2010-10-12 Eric Seidel <eric@webkit.org>
12597 Reviewed by Darin Adler.
12599 REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
12600 https://bugs.webkit.org/show_bug.cgi?id=45693
12602 Re-implement this former WebCore parser quirk as a
12603 Mac-only userscript-based quirk. As far as I can tell
12604 from Darin's description this should satisfy Mail's needs.
12606 * Misc/MailQuirksUserScript.js: Added.
12607 * WebView/WebView.mm:
12608 (+[WebView _mailQuirksUserScript]):
12609 (-[WebView _injectMailQuirksScript]):
12610 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
12612 2010-10-12 Simon Fraser <simon.fraser@apple.com>
12614 Reviewed by Sam Weinig.
12616 Add 'didDraw' callback for framerate tracking
12617 https://bugs.webkit.org/show_bug.cgi?id=47478
12619 Add a callback at the end of -[WebHTMLView drawRect:] so
12620 a delegate can get notified when a draw happens.
12622 * WebView/WebHTMLView.mm:
12623 (-[WebHTMLView drawRect:]):
12624 * WebView/WebUIDelegatePrivate.h:
12626 2010-10-11 Anders Carlsson <andersca@apple.com>
12628 Reviewed by Darin Adler.
12630 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
12631 https://bugs.webkit.org/show_bug.cgi?id=47523
12633 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
12635 * Misc/WebIconFetcher.h: Removed.
12636 * Misc/WebIconFetcher.mm: Removed.
12637 * Misc/WebIconFetcherInternal.h: Removed.
12638 * WebView/WebFrame.mm:
12639 * WebView/WebFramePrivate.h:
12641 2010-10-11 Jessie Berlin <jberlin@apple.com>
12643 Reviewed by Darin Adler.
12645 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
12646 representation of a WebKit1 WebSerializedJSValue.
12647 https://bugs.webkit.org/show_bug.cgi?id=47439
12649 * WebView/WebSerializedJSValue.mm:
12650 (-[WebSerializedJSValue internalRepresentation]):
12651 * WebView/WebSerializedJSValuePrivate.h:
12653 2010-10-07 Jessie Berlin <jberlin@apple.com>
12655 Reviewed by Sam Weinig.
12657 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
12658 representation of a WebKit2 WebSerializedScriptValue.
12659 https://bugs.webkit.org/show_bug.cgi?id=47390
12661 * WebView/WebSerializedJSValue.mm:
12662 (-[WebSerializedJSValue initWithInternalRepresentation:]):
12663 Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
12664 internal representation.
12665 * WebView/WebSerializedJSValuePrivate.h: Added.
12667 2010-10-07 Antonio Gomes <agomes@rim.com>
12669 Reviewed by Simon Fraser.
12671 [Mac] [DRT] implement setSpatialNavigationEnabled
12672 https://bugs.webkit.org/show_bug.cgi?id=47291
12674 Added the needed bits to make it possible to enabled spatial navigation
12675 for the Mac port. For now it is being only used by DRT.
12677 * WebView/WebPreferenceKeysPrivate.h:
12678 * WebView/WebPreferences.mm:
12679 (+[WebPreferences initialize]):
12680 (-[WebPreferences isSpatialNavigationEnabled]):
12681 (-[WebPreferences setSpatialNavigationEnabled:]):
12682 * WebView/WebPreferencesPrivate.h:
12683 * WebView/WebView.mm:
12684 (-[WebView _preferencesChangedNotification:]):
12686 2010-10-07 Jer Noble <jer.noble@apple.com>
12688 Fix the Leopard 64-bit build.
12690 * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
12691 framework search path.
12692 * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
12694 2010-10-06 Jer Noble <jer.noble@apple.com>
12696 Reviewed by Darin Adler.
12698 Screensaver starts while watching fullscreen playback.
12699 https://bugs.webkit.org/show_bug.cgi?id=47299
12700 <rdar://problem/8478956>
12702 To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
12704 * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
12705 * WebView/WebVideoFullscreenController.mm:
12706 (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
12707 (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer.
12708 (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
12709 (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
12710 (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
12711 or _disableTickleTimer.
12713 2010-10-05 Philippe Normand <pnormand@igalia.com>
12715 Reviewed by Martin Robinson.
12717 check for ENABLE(GLIB_SUPPORT) in WebView
12718 https://bugs.webkit.org/show_bug.cgi?id=46788
12720 Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.
12722 * WebView/WebView.mm:
12723 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
12724 (-[WebView _close]):
12725 * WebView/WebViewData.h:
12726 * WebView/WebViewInternal.h:
12728 2010-10-01 Anders Carlsson <andersca@apple.com>
12730 Fix Snow Leopard build.
12732 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12733 (WebKit::NetscapePluginInstanceProxy::getProxy):
12735 2010-10-01 Anders Carlsson <andersca@apple.com>
12737 Reviewed by Dan Bernstein.
12739 Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
12740 https://bugs.webkit.org/show_bug.cgi?id=47022
12741 <rdar://problem/8504712>
12743 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12744 (WebKit::NetscapePluginInstanceProxy::getProxy):
12745 * Plugins/WebBaseNetscapePluginView.h:
12746 * Plugins/WebBaseNetscapePluginView.mm:
12747 * Plugins/WebNetscapePluginView.mm:
12748 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
12750 2010-09-30 Darin Adler <darin@apple.com>
12752 Reviewed by Sam Weinig.
12754 Remove remaining calls to deprecatedParseURL
12755 https://bugs.webkit.org/show_bug.cgi?id=26599
12757 * DOM/WebDOMOperations.mm:
12758 (-[DOMDocument URLWithAttributeString:]):
12759 * WebCoreSupport/WebFrameLoaderClient.mm:
12760 (WebFrameLoaderClient::createPlugin):
12761 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
12763 2010-09-30 Anders Carlsson <andersca@apple.com>
12765 Reviewed by Darin Adler.
12767 -[DOMDocument _documentRange] throws an exception if there is no document element
12768 https://bugs.webkit.org/show_bug.cgi?id=46934
12769 <rdar://problem/8169260>
12771 If there is no document element, just return an empty range. Otherwise we'll try to call
12772 Range::selectNode with a null Node which will throw a NOT_FOUND exception.
12774 * DOM/WebDOMOperations.mm:
12775 (-[DOMDocument _documentRange]):
12777 2010-09-30 Chris Marrin <cmarrin@apple.com>
12779 Reviewed by Simon Fraser.
12781 Make 2D accelerated canvas rendering build on Mac
12782 https://bugs.webkit.org/show_bug.cgi?id=46007
12784 Added ACCELERATED_2D_CANVAS to FeatureDefines
12786 * Configurations/FeatureDefines.xcconfig:
12788 2010-09-30 Dan Bernstein <mitz@apple.com>
12790 Reviewed by John Sullivan.
12792 Add printing SPI allowing full control over shrink-to-fit
12793 https://bugs.webkit.org/show_bug.cgi?id=46877
12795 * WebView/WebHTMLView.mm:
12796 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
12797 * WebView/WebHTMLViewPrivate.h:
12799 2010-09-28 Johnny Ding <jnd@chromium.org>
12801 Reviewed by Adam Barth.
12803 https://bugs.webkit.org/show_bug.cgi?id=41292
12804 Some windowed plugins did not handle events through EventHandler, so we
12805 never set right gesture state for those events.
12806 This change is to set right allowPopupsFromPlugin flag to current
12807 execution frame, so WeKit can always get right gesture state on Mac.
12808 From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
12809 process, that process passes the allowPopupsFromPlugin flag to
12810 WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
12811 NetscapePluginInstanceProxy::evaluate.
12813 * Plugins/WebNetscapePluginView.mm:
12814 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
12816 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
12818 Reviewed by Dmitry Titov.
12820 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
12821 https://bugs.webkit.org/show_bug.cgi?id=46663
12823 * WebCoreSupport/WebFrameLoaderClient.h:
12824 * WebCoreSupport/WebFrameLoaderClient.mm:
12825 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
12827 2010-09-26 Antonio Gomes <agomes@rim.com>
12829 Reviewed by Kenneth Rohde Christiansen.
12831 DRT/Mac nodesFromRect support
12833 [Mac][DRT] Implement LayoutTestController::nodesFromRect
12834 https://bugs.webkit.org/show_bug.cgi?id=46580
12836 Implement nodesFromRect as a private method to access non-exposed Document
12837 methods, similarly to computedStyleIncludingVisitedInfo.
12839 * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
12840 These headers makes it possible to:
12841 1) Get a Document off of a JSDocument;
12842 2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
12843 gotten from Document::nodesFromRect to JS bindings.
12844 (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
12845 * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
12846 Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.
12848 2010-09-24 Jia Pu <jpu@apple.com>
12850 Reviewed by Dan Bernstein.
12852 automaticSpellingCorrectionEnabled isn't updated.
12853 https://bugs.webkit.org/show_bug.cgi?id=46486
12854 <rdar://problem/8475212>
12856 * WebView/WebView.mm:
12857 (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
12858 instead of "automaticTextReplacementEnabled".
12860 2010-09-23 Alexey Proskuryakov <ap@apple.com>
12862 Reviewed by Darin Adler.
12864 https://bugs.webkit.org/show_bug.cgi?id=46380
12865 REGRESSION: Crash when downloading a file
12867 Downloading cannot be tested in DRT.
12869 * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
12870 Don't copy null strings.
12872 2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
12874 Reviewed by Yury Semikhatsky.
12876 Web Inspector: CRASH at node highlight on MAC Safari.
12877 1) run-safari --debug
12879 3) open elements panel
12880 4) hover mouse over elements panel items multiple times
12882 Looks like it is a race condition. WebNodeHighlightView doesn't check
12883 the pointer to WebNodeHighligh object and it can be nil.
12885 https://bugs.webkit.org/show_bug.cgi?id=46261
12887 * WebInspector/WebNodeHighlightView.mm:
12888 (-[WebNodeHighlightView drawRect:]):
12890 2010-09-23 Andy Estes <aestes@apple.com>
12892 Reviewed by Darin Adler.
12894 REGRESSION (r61285): some Dashboard widgets are always invisible due to
12895 HTML parser changes.
12896 https://bugs.webkit.org/show_bug.cgi?id=46435
12898 Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
12901 * WebView/WebView.mm:
12902 (-[WebView _needsPreHTML5ParserQuirks]): Renamed from
12903 shouldUsePreHTML5ParserQuirks(). Return true if
12904 WebCore::Settings::usesDashboardCompatibilityMode() is true.
12905 (-[WebView _preferencesChangedNotification:]):
12906 (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks
12907 if Dashboard behavior is set to backward compatibility mode.
12909 2010-09-23 Matthew Delaney <mdelaney@apple.com>
12911 Reviewed by Simon Fraser.
12913 Reduce minimum DOMTimer interval
12914 https://bugs.webkit.org/show_bug.cgi?id=45362
12916 * WebView/WebView.mm:
12917 Updating set interval call to use Settings' static version inside
12918 one time init block.
12920 2010-09-22 Andy Estes <aestes@apple.com>
12922 Reviewed by Darin Adler.
12924 REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
12925 https://bugs.webkit.org/show_bug.cgi?id=46334
12927 Microsoft My Day loads scripts using self-closing script tags, markup
12928 which is incompatible with the HTML5 parser. Enable parser quirks for
12931 * WebView/WebView.mm:
12932 (shouldUsePreHTML5ParserQuirks): Return true if the application is
12933 Microsoft My Day and was linked against a version of WebKit prior to the
12934 introduction of the HTML5 parser.
12936 2010-09-23 Nate Chapin <japhet@chromium.org>
12938 Reviewed by Darin Fisher.
12940 Add hyperlink auditing settings (i.e., <a ping>).
12941 https://bugs.webkit.org/show_bug.cgi?id=30458
12943 * WebView/WebPreferenceKeysPrivate.h:
12944 * WebView/WebPreferences.mm:
12945 (+[WebPreferences initialize]):
12946 (-[WebPreferences setMemoryInfoEnabled:]):
12947 (-[WebPreferences hyperlinkAuditingEnabled]):
12948 (-[WebPreferences setHyperlinkAuditingEnabled:]):
12949 * WebView/WebPreferencesPrivate.h:
12950 * WebView/WebView.mm:
12951 (-[WebView _preferencesChangedNotification:]):
12953 2010-09-22 Alexey Proskuryakov <ap@apple.com>
12955 Reviewed by Anders Carlsson.
12957 https://bugs.webkit.org/show_bug.cgi?id=43667
12958 ASSERT failure in NetscapePluginInstanceProxy::disconnectStream
12960 Test: plugins/get-javascript-url.html
12962 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12963 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just
12964 like any other one.
12966 2010-09-21 Darin Adler <darin@apple.com>
12968 Reviewed by Anders Carlsson.
12970 Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
12971 https://bugs.webkit.org/show_bug.cgi?id=46220
12973 * Misc/WebNSFileManagerExtras.m:
12974 (setMetaData): Use CFRelease instead of HardRelease.
12975 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy
12976 instead of -[NSObject copy] combined with HardRetainWithNSRelease.
12978 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
12980 Reviewed by Kenneth Rohde Christiansen.
12982 PluginStrategy should satisfy the needs of Qt
12983 https://bugs.webkit.org/show_bug.cgi?id=45857
12984 No new functionality so no new tests.
12986 * WebCoreSupport/WebPlatformStrategies.h:
12987 * WebCoreSupport/WebPlatformStrategies.mm:
12988 (WebPlatformStrategies::getPluginInfo):
12990 2010-09-22 Paul Knight <pknight@apple.com>
12992 Reviewed by Simon Fraser.
12994 -[WebView _scheduleCompositingLayerSync] should wake the run loop
12995 https://bugs.webkit.org/show_bug.cgi?id=46226
12997 Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.
12999 * WebView/WebView.mm:
13000 (-[WebView _scheduleCompositingLayerSync]):
13002 2010-09-21 Andy Estes <aestes@apple.com>
13004 Reviewed by Darin Adler.
13006 REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
13007 https://bugs.webkit.org/show_bug.cgi?id=46134
13009 AIM clients linked against versions of WebKit prior to the introduction
13010 of the HTML5 parser contain markup incompatible with the new parser.
13011 Enable parser quirks in this case to remain compatible with these
13014 * WebView/WebView.mm:
13015 (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
13016 application is AIM and was linked against a version of WebKit prior to
13017 the introduction of the HTML5 parser, or if the
13018 WebKitPreHTML5ParserQuirks WebPreference is enabled.
13019 (-[WebView _preferencesChangedNotification:]): Call
13020 WebCore::Settings::setUsePreHTML5ParserQuirks().
13022 2010-09-21 Steve Block <steveblock@google.com>
13024 Reviewed by Jeremy Orlow.
13026 DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
13027 https://bugs.webkit.org/show_bug.cgi?id=45891
13029 Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.
13031 * WebCoreSupport/WebDeviceOrientationClient.h:
13032 * WebCoreSupport/WebDeviceOrientationClient.mm:
13033 (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
13035 2010-09-20 Philippe Normand <pnormand@igalia.com>
13037 Reviewed by Eric Carlson.
13039 [GTK] enhanced context menu for media elements
13040 https://bugs.webkit.org/show_bug.cgi?id=45021
13042 New localized strings for the media element context-menu.
13044 * WebCoreSupport/WebPlatformStrategies.h:
13045 * WebCoreSupport/WebPlatformStrategies.mm:
13046 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
13047 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
13048 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
13049 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
13050 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
13051 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
13052 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
13053 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
13054 (WebPlatformStrategies::contextMenuItemTagMediaPause):
13055 (WebPlatformStrategies::contextMenuItemTagMediaMute):
13057 2010-09-20 Andy Estes <aestes@apple.com>
13059 Reviewed by Adam Barth.
13061 REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
13062 https://bugs.webkit.org/show_bug.cgi?id=40961
13064 Implement WebKitUsePreHTML5ParserQuirks preference.
13066 * WebView/WebPreferenceKeysPrivate.h:
13067 * WebView/WebPreferences.mm:
13068 (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to
13070 (-[WebPreferences usePreHTML5ParserQuirks]):
13071 (-[WebPreferences setUsePreHTML5ParserQuirks:]):
13072 * WebView/WebPreferencesPrivate.h:
13073 * WebView/WebView.mm:
13074 (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings
13075 with the value of WebKitUsePreHTML5ParserQuirks when a preference
13078 2010-09-20 Enrica Casucci <enrica@apple.com>
13080 Reviewed by Sam Weinig.
13082 Pasteboard doesn't work in WebKit2.
13083 https://bugs.webkit.org/show_bug.cgi?id=42317
13084 <rdar://problem/7660537>
13086 Some changes to fix style inconsistencies.
13087 Added OBJC 2.0 style enumeration.
13089 * WebCoreSupport/WebEditorClient.h:
13090 * WebCoreSupport/WebEditorClient.mm:
13091 (WebEditorClient::userVisibleString):
13092 (createExcludedElementsForAttributedStringConversion):
13093 (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
13094 a Vector of RefPtr.
13095 (WebEditorClient::setInsertionPasteboard):
13096 (WebEditorClient::pasteboardTypesForSelection):
13098 2010-09-17 David Hyatt <hyatt@apple.com>
13100 Reviewed by Simon Fraser.
13102 https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
13104 Make printing store the page height in the RenderView and push that into the layout state to
13105 use the new pagination model. The old pagination model is retained because it is still used
13106 for embedded WebViews.
13108 * WebView/WebHTMLView.mm:
13109 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
13111 2010-09-17 Darin Adler <darin@apple.com>
13113 Reviewed by Sam Weinig.
13115 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
13116 https://bugs.webkit.org/show_bug.cgi?id=42863
13118 * WebView/WebView.mm:
13119 (-[WebView _setZoomMultiplier:isTextOnly:]):
13120 Call functions on Frame instead of FrameView.
13122 2010-09-17 Matthew Delaney <mdelaney@apple.com>
13124 Reviewed by Simon Fraser.
13126 Reduce minimum DOMTimer interval
13127 https://bugs.webkit.org/show_bug.cgi?id=45362
13129 * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
13131 2010-09-17 Chris Marrin <cmarrin@apple.com>
13133 Reviewed by Simon Fraser.
13135 Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
13136 https://bugs.webkit.org/show_bug.cgi?id=45911
13138 * WebView/WebPreferenceKeysPrivate.h:
13139 * WebView/WebPreferences.mm:
13140 (+[WebPreferences initialize]):
13141 (-[WebPreferences accelerated2dCanvasEnabled]):
13142 (-[WebPreferences setAccelerated2dCanvasEnabled:]):
13143 * WebView/WebPreferencesPrivate.h:
13144 * WebView/WebView.mm:
13145 (-[WebView _preferencesChangedNotification:]):
13147 2010-09-17 Jia Pu <jpu@apple.com>
13149 Reviewed by Dan Bernstein.
13151 WebKit should use system wide spell checking preference when application specific one isn't set.
13152 https://bugs.webkit.org/show_bug.cgi?id=45789
13153 <rdar://problem/8416041>
13155 * WebView/WebView.mm:
13156 (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
13157 when the application level preferences are not set.
13159 2010-09-16 John Sullivan <sullivan@apple.com>
13161 Reviewed by Darin Adler.
13163 <rdar://problem/8395558>
13164 https://bugs.webkit.org/show_bug.cgi?id=45938
13165 _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
13167 * WebView/WebHTMLView.mm:
13168 (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
13169 Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
13170 was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
13171 this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
13172 before enumerating it, to ensure that the selector can't mutate the array being enumerated.
13173 (-[WebHTMLView viewWillMoveToHostWindow:]):
13174 Updated for _web_makePluginSubviewsPerformSelector:: signature change.
13175 (-[WebHTMLView viewDidMoveToHostWindow]):
13178 2010-09-16 Darin Adler <darin@apple.com>
13180 Reviewed by Andreas Kling.
13182 Reduce use of HTMLInputElement::inputType so we can remove it later
13183 https://bugs.webkit.org/show_bug.cgi?id=45903
13185 * WebView/WebHTMLRepresentation.mm:
13186 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField.
13187 (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
13189 2010-09-16 Patrick Gansterer <paroga@paroga.com>
13191 Reviewed by Darin Adler.
13193 Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
13194 https://bugs.webkit.org/show_bug.cgi?id=41510
13196 This prevents usage of nil value, which would cause an uncaught exception.
13198 * WebView/WebPreferences.mm:
13199 (-[WebPreferences setUserStyleSheetLocation:]):
13201 2010-09-16 Dan Bernstein <mitz@apple.com>
13203 Reverted the previous change because r67628 has been reverted.
13205 * WebCoreSupport/WebPlatformStrategies.h:
13206 * WebCoreSupport/WebPlatformStrategies.mm:
13208 2010-09-16 Dan Bernstein <mitz@apple.com>
13210 Build fix after r67628. Added context menu item localizable strings for the items
13211 added in r67628, following equivalent menu items in Mac OS X when possible. However,
13212 this set of menu items does not make much sense for Mac OS X, and this should be
13213 addressed separately.
13215 * WebCoreSupport/WebPlatformStrategies.h:
13216 * WebCoreSupport/WebPlatformStrategies.mm:
13217 (WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
13218 (WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
13219 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
13220 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
13221 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
13222 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
13223 (WebPlatformStrategies::contextMenuItemTagMediaPause):
13224 (WebPlatformStrategies::contextMenuItemTagMediaMute):
13225 (WebPlatformStrategies::contextMenuItemTagMediaUnMute):
13227 2010-09-16 Eric Uhrhane <ericu@chromium.org>
13229 Reviewed by Jian Li.
13231 Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
13232 https://bugs.webkit.org/show_bug.cgi?id=45798
13234 * Configurations/FeatureDefines.xcconfig:
13236 2010-09-15 Simon Fraser <simon.fraser@apple.com>
13238 Reviewed by Adam Roben.
13240 https://bugs.webkit.org/show_bug.cgi?id=44715
13241 maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
13243 Move geometry flipping to platform-specific code.
13245 * WebView/WebHTMLView.mm:
13246 (-[WebHTMLView attachRootLayer:]):
13248 2010-09-14 Jia Pu <jpu@apple.com>
13250 Reviewed by Dan Bernstein.
13252 Only intercept ESC key press when autocorrection UI is visible.
13253 https://bugs.webkit.org/show_bug.cgi?id=45071
13255 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
13256 which provides an inteface to query whether autocorrection panel is shown.
13258 * WebCoreSupport/WebEditorClient.mm:
13259 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
13260 for invalid correction panel tag. Replaced -1 with this constant.
13261 (WebEditorClient::dismissCorrectionPanel): Ditto
13262 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
13264 2010-09-14 Mark Rowe <mrowe@apple.com>
13266 Reviewed by John Sullivan.
13268 Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.
13270 * Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
13271 * Misc/WebKitVersionChecks.m:
13272 (WebKitLinkedOnOrAfter):
13273 (setWebKitLinkTimeVersion): Set the overridden version.
13274 (WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
13275 * WebView/WebPreferences.mm:
13276 (+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
13277 * WebView/WebPreferencesPrivate.h:
13279 2010-09-14 Eric Seidel <eric@webkit.org>
13281 Unreviewed, reverting changes r67451 and r67451.
13282 Broke lots of builders.
13284 Only intercept ESC key press when autocorrection UI is visible.
13285 https://bugs.webkit.org/show_bug.cgi?id=45071
13287 * WebCoreSupport/WebEditorClient.h:
13288 * WebCoreSupport/WebEditorClient.mm:
13289 (WebEditorClient::WebEditorClient):
13290 (WebEditorClient::dismissCorrectionPanel):
13292 2010-09-14 Jia Pu <jpu@apple.com>
13294 Reviewed by Dan Bernstein.
13296 Only intercept ESC key press when autocorrection UI is visible.
13297 https://bugs.webkit.org/show_bug.cgi?id=45071
13299 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
13300 which provides an inteface to query whether autocorrection panel is shown.
13302 * WebCoreSupport/WebEditorClient.mm:
13303 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
13304 for invalid correction panel tag. Replaced -1 with this constant.
13305 (WebEditorClient::dismissCorrectionPanel): Ditto
13306 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
13308 2010-09-13 Darin Adler <darin@apple.com>
13310 Reviewed by Adam Barth.
13312 Preparation for eliminating deprecatedParseURL
13313 https://bugs.webkit.org/show_bug.cgi?id=45695
13315 * DOM/WebDOMOperations.mm:
13316 (-[DOMDocument webFrame]): Get rid of unneeded local variable.
13317 (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
13319 2010-09-13 Enrica Casucci <enrica@apple.com>
13321 Reviewed by Sam Weinig.
13323 Paste should be implemented in WebCore like Copy and Cut for Mac also.
13324 https://bugs.webkit.org/show_bug.cgi?id=45494
13325 <rdar://problem/7660537>
13327 On the Mac platform, the implementation of the paste operation is all done
13328 at the WebKit level. In order to support it on WebKit2 it is necessary to
13329 refactor the code and move this functionality at the level of WebCore like
13330 we already have on Windows.
13331 The original code relies on some in AppKit functions that call back into
13332 WebKit causing problems in WebKit2. All this functionality has been moved
13333 at the level of the editor client where it can be dealt with appropriately.
13335 * WebCoreSupport/WebEditorClient.h:
13336 * WebCoreSupport/WebEditorClient.mm:
13337 (excludedElementsForAttributedStringConversion):
13338 (WebEditorClient::documentFragmentFromAttributedString): Added.
13339 (WebEditorClient::setInsertionPasteboard):
13340 * WebCoreSupport/WebFrameLoaderClient.h:
13341 * WebCoreSupport/WebFrameLoaderClient.mm:
13342 (WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
13343 of the editor client.
13344 * WebView/WebHTMLView.mm: Removed paste method.
13346 2010-09-13 John Sullivan <sullivan@apple.com>
13348 Reviewed by Adam Roben.
13350 https://bugs.webkit.org/show_bug.cgi?id=45677
13351 [WebView canMarkAllTextMatches] can crash if called after [WebView close]
13353 <rdar://problem/8404890>
13355 * WebView/WebView.mm:
13356 (-[WebView canMarkAllTextMatches]):
13357 Return NO immediately if the webview has already been closed. This was an overlooked
13358 case from the fix for 45175.
13360 2010-09-10 MORITA Hajime <morrita@google.com>
13362 Reviewed by Tony Chang.
13364 [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
13365 https://bugs.webkit.org/show_bug.cgi?id=45441
13367 Moved the actual logic of hasSpellingMarker into WebCore to share
13368 it with other ports.
13370 * WebView/WebFrame.mm:
13371 (-[WebFrame hasSpellingMarker:length:]):
13373 2010-09-11 Adam Barth <abarth@webkit.org>
13375 Reviewed by Sam Weinig.
13377 Make SecurityOrigin::canDisplay an instance function
13378 https://bugs.webkit.org/show_bug.cgi?id=45219
13380 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13381 (WebKit::NetscapePluginInstanceProxy::loadRequest):
13382 * Plugins/WebNetscapePluginStream.mm:
13383 (WebNetscapePluginStream::WebNetscapePluginStream):
13384 * Plugins/WebNetscapePluginView.mm:
13385 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
13386 * Plugins/WebPluginContainerCheck.mm:
13387 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
13388 * WebView/WebFrame.mm:
13389 (-[WebFrame _allowsFollowingLink:]):
13391 2010-09-10 Sam Weinig <sam@webkit.org>
13393 Reviewed by Darin Adler.
13395 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
13396 Precursor to <rdar://problem/7660657>
13397 https://bugs.webkit.org/show_bug.cgi?id=45522
13399 * WebView/WebView.mm:
13400 (-[WebView _preferencesChangedNotification:]):
13401 (-[WebView _setZoomMultiplier:isTextOnly:]):
13402 (-[WebView _realZoomMultiplierIsTextOnly]):
13403 * WebView/WebViewData.h:
13404 * WebView/WebViewData.mm:
13405 (-[WebViewPrivate init]):
13406 Move tracking of text only zoom here from WebCore.
13408 2010-09-10 Stephanie Lewis <slewis@apple.com>
13410 Reviewed by Alexey Proskuryakov.
13412 Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
13413 other implementation details of JavaScriptCore. Necessary to fix PPC build.
13415 https://bugs.webkit.org/show_bug.cgi?id=45528
13417 * Misc/WebCoreStatistics.mm:
13418 (+[WebCoreStatistics memoryStatistics]):
13420 2010-09-10 Darin Adler <darin@apple.com>
13422 Reviewed by Sam Weinig.
13424 Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
13425 https://bugs.webkit.org/show_bug.cgi?id=45582
13427 * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
13429 * WebCoreSupport/WebChromeClient.mm:
13430 (WebChromeClient::dashboardRegionsChanged): Changed this to call
13431 -[WebView _dashboardRegions] so we don't have two copies of that code.
13433 * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
13434 * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
13436 * WebView/WebView.mm:
13437 (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
13439 2010-09-10 Adam Barth <abarth@webkit.org>
13441 Reviewed by Darin Fisher.
13443 Move code from WebKit-layer to DocumentLoader
13444 https://bugs.webkit.org/show_bug.cgi?id=45569
13446 This code is the most confused, but now should be a bit cleaner.
13447 There's still a magical fake-setting for creating renderers that needs
13448 to be cleaned up, but we can do that in a separate patch.
13450 * WebView/WebFrame.mm:
13451 (-[WebFrame _commitData:]):
13452 * WebView/WebFrameInternal.h:
13453 * WebView/WebHTMLRepresentation.mm:
13454 (-[WebHTMLRepresentation receivedData:withDataSource:]):
13455 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
13457 2010-09-09 Darin Adler <darin@apple.com>
13459 Reviewed by Adam Barth.
13461 Move functions from Frame to SelectionController as planned
13462 https://bugs.webkit.org/show_bug.cgi?id=45508
13464 * WebView/WebFrame.mm:
13465 (-[WebFrame _selectionGranularity]):
13466 (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
13467 (-[WebFrame _typingStyle]):
13468 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
13469 * WebView/WebHTMLRepresentation.mm:
13470 (-[WebHTMLRepresentation currentForm]):
13471 * WebView/WebHTMLView.mm:
13472 (-[WebHTMLView jumpToSelection:]):
13473 (-[WebHTMLView centerSelectionInVisibleArea:]):
13474 (-[WebHTMLView _canSmartCopyOrDelete]):
13475 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
13476 (-[WebHTMLView selectionRect]):
13477 (-[WebHTMLView selectionTextRects]):
13478 (-[WebHTMLView selectionImageRect]):
13479 * WebView/WebView.mm:
13480 (-[WebView setEditable:]):
13481 Call functions on selection().
13483 2010-09-10 Adam Barth <abarth@webkit.org>
13485 Reviewed by Eric Seidel.
13487 Main resource bytes shouldn't bounce through FrameLoader
13488 https://bugs.webkit.org/show_bug.cgi?id=45496
13490 Now return the bytes to the DocumentLoader.
13492 Previously, we were checking the document for null. However, Frame can
13493 never have a null document, so this check is no longer needed.
13495 * WebView/WebFrame.mm:
13496 (-[WebFrame _addData:]):
13498 2010-09-09 John Therrell <jtherrell@apple.com>
13500 Reviewed by Alexey Proskuryakov.
13502 Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes
13503 https://bugs.webkit.org/show_bug.cgi?id=45134
13505 Added ability to enable new JavaScriptCore statistics sampling and reporting for RegisterFile
13506 and ExecutableAllocator classes. Added reporting of JavaScriptCore's stack committed memory
13507 and JIT code committed memory statistics to WebCoreStatistics memoryStatistics.
13509 * Misc/WebCoreStatistics.mm:
13510 (+[WebCoreStatistics memoryStatistics]):
13511 Added statistics reporting for JSC RegisterFile and ExecutableAllocator.
13513 2010-09-09 Jer Noble <jer.noble@apple.com>
13515 Reviewed by Mark Rowe.
13517 Use of ENABLE macro in WebUIDelegatePrivate.h breaks use from outside WebKit
13518 <rdar://problem/8412657>
13520 * WebView/WebUIDelegatePrivate.h: Use ENABLE_FULLSCREEN_API instead of ENABLE(FULLSCREEN_API)
13522 2010-09-08 Darin Adler <darin@apple.com>
13524 Reviewed by Adam Barth.
13526 Move functions from Frame to Editor as planned
13527 https://bugs.webkit.org/show_bug.cgi?id=45218
13529 * WebView/WebFrame.mm:
13530 (-[WebFrame _selectedString]):
13531 (-[WebFrame _firstRectForDOMRange:]):
13532 (-[WebFrame _markDOMRange]):
13533 (-[WebFrame _setTypingStyle:withUndoAction:]):
13534 * WebView/WebHTMLRepresentation.mm:
13535 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
13536 * WebView/WebHTMLView.mm:
13537 (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
13538 (-[WebHTMLView toggleBaseWritingDirection:]):
13539 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
13540 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
13541 (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
13542 (-[WebHTMLView markedTextMatchesAreHighlighted]):
13543 * WebView/WebView.mm:
13544 (-[WebView setEditable:]):
13545 Changed call sites to use editor().
13547 2010-09-08 MORITA Hajime <morrita@google.com>
13549 Reviewed by Ojan Vafai.
13551 spellcheck does not check pasted text
13552 https://bugs.webkit.org/show_bug.cgi?id=40092
13554 Implemented async spell-check APIs on WebEditorClient.
13555 The implementations are using [NSSpellChecker requestCheckingOfString]
13556 which is available only on Mac OS 10.6 or later.
13558 Note that [NSSpellChecker requestCheckingOfString] could invoke
13559 the callback block on on of their worker thread, so we need to
13560 return the result to the main thread where WebCore is running.
13561 For that purpose, we made WebEditorSpellCheckResponder class.
13563 Test: editing/spelling/spellcheck-pasted-text-001.html
13565 * WebCoreSupport/WebEditorClient.h:
13566 * WebCoreSupport/WebEditorClient.mm:
13567 (WebEditorClient::isAsynchronousSpellCheckingEnabled): Added.
13568 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): Added.
13569 (-[WebEditorSpellCheckResponder perform]): Added.
13570 (WebEditorClient::requestCheckingOfString): Added.
13571 * WebView/WebFramePrivate.h:
13573 2010-09-08 MORITA Hajime <morrita@google.com>
13575 Reviewed by Tony Chang.
13577 spelling underline gets lost on backspace
13578 https://bugs.webkit.org/show_bug.cgi?id=41423
13580 Switched to use a anchorNode of the selection instead of a focused
13581 node for finer control of node selection in spellingNode():
13582 With the focused node, we cannot select other nodes but the first
13583 child of that node. In some case, we need to inspect these.
13585 The API is only for LayoutTests, and the change is compatible for
13586 existing test cases.
13588 * WebView/WebFrame.mm:
13591 2010-09-08 Adam Barth <abarth@webkit.org>
13593 Rubber-stamped by Eric Seidel.
13595 Rename DocLoader to CachedResourceLoader because that's what it does.
13597 * WebView/WebFrame.mm:
13599 2010-09-07 Anders Carlsson <andersca@apple.com>
13601 Reviewed by Oliver Hunt.
13605 * Misc/WebLocalizableStrings.h:
13606 Fix a struct/tag mismatch.
13608 * WebView/WebDeviceOrientationProviderMock.mm:
13609 (-[WebDeviceOrientationProviderMock init]):
13610 Remove stray semicolon.
13612 * WebView/WebViewData.h:
13613 Remove unused class forward declaration.
13615 2010-09-07 Anders Carlsson <andersca@apple.com>
13617 Reviewed by Darin Adler.
13619 <rdar://problem/8381749> -Wcast-align warning emitted when building with clang
13621 Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
13623 * Configurations/Base.xcconfig:
13625 2010-09-06 Adam Barth <abarth@webkit.org>
13627 Reviewed by Darin Adler.
13629 Rename SecurityOrigin::canLoad to canDisplay
13630 https://bugs.webkit.org/show_bug.cgi?id=45214
13632 Propagate name change.
13634 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13635 (WebKit::NetscapePluginInstanceProxy::loadRequest):
13636 * Plugins/WebNetscapePluginStream.mm:
13637 (WebNetscapePluginStream::WebNetscapePluginStream):
13638 * Plugins/WebNetscapePluginView.mm:
13639 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
13640 * Plugins/WebPluginContainerCheck.mm:
13641 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
13642 * WebView/WebFrame.mm:
13643 (-[WebFrame _allowsFollowingLink:]):
13645 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
13647 Reviewed by Darin Adler.
13649 Add NetworkingContext to avoid layer violations
13650 https://bugs.webkit.org/show_bug.cgi?id=42292
13652 Add Mac's specific implementation of FrameNetworkingContext.
13654 * WebCoreSupport/WebFrameLoaderClient.h:
13655 * WebCoreSupport/WebFrameLoaderClient.mm:
13656 * WebCoreSupport/WebFrameNetworkingContext.mm:
13657 (WebFrameNetworkingContext::needsSiteSpecificQuirks):
13658 (WebFrameNetworkingContext::localFileContentSniffingEnabled):
13659 (WebFrameNetworkingContext::scheduledRunLoopPairs):
13660 (WebFrameNetworkingContext::blockedError):
13662 2010-09-03 John Sullivan <sullivan@apple.com>
13664 Reviewed by Dan Bernstein.
13666 https://bugs.webkit.org/show_bug.cgi?id=45175
13667 [WebView unmarkAllTextMatches] will crash if the webview is already closed
13669 Made this and related methods robust against being called when the WebView is closed.
13671 * WebView/WebView.mm:
13672 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
13673 Bail out if the WebView is closed.
13674 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
13676 (-[WebView unmarkAllTextMatches]):
13678 (-[WebView rectsForTextMatches]):
13681 2010-09-03 Hironori Bono <hbono@chromium.org>
13683 Reviewed by Kent Tamura.
13685 Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
13686 and implements it for Mac.
13687 https://bugs.webkit.org/show_bug.cgi?id=41832
13689 * WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:].
13691 (-[WebFrame hasSpellingMarker:length:]):
13692 * WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it.
13694 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
13696 Reviewed by Pavel Feldman.
13698 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
13699 https://bugs.webkit.org/show_bug.cgi?id=44230
13701 * WebCoreSupport/WebInspectorClient.h:
13702 * WebCoreSupport/WebInspectorClient.mm:
13703 (WebInspectorFrontendClient::closeWindow):
13704 (WebInspectorFrontendClient::disconnectFromBackend):
13705 (-[WebInspectorWindowController windowShouldClose:]):
13706 (-[WebInspectorWindowController destroyInspectorView:]):
13708 2010-09-02 Steve Block <steveblock@google.com>
13710 Reviewed by Adam Barth.
13712 Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
13713 https://bugs.webkit.org/show_bug.cgi?id=43181
13715 This patch hooks up the mock device orientation client on Mac for use
13718 The patch adds a new WebDeviceOrientationClient for Mac. This client acts
13719 as a proxy to either a real or mock device orientation provider, both of
13720 which implement a new WebDeviceOrientationProvider interface.
13722 The provider is created by the embedder and passed to the WebView, from
13723 where WebDeviceOrientationClient can access it.
13725 The mock provider, WebDeviceOrientationProviderMock, is a wrapper around
13726 the existing WebCore mock.
13728 * WebCoreSupport/WebDeviceOrientationClient.h: Added.
13729 * WebCoreSupport/WebDeviceOrientationClient.mm: Added.
13730 (WebDeviceOrientationClient::WebDeviceOrientationClient):
13731 (WebDeviceOrientationClient::setController):
13732 (WebDeviceOrientationClient::startUpdating):
13733 (WebDeviceOrientationClient::stopUpdating):
13734 (WebDeviceOrientationClient::lastOrientation):
13736 * WebView/WebDeviceOrientation.h: Added.
13737 * WebView/WebDeviceOrientation.mm: Added.
13738 (-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]):
13740 (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
13741 (-[WebDeviceOrientation dealloc]):
13742 * WebView/WebDeviceOrientationInternal.h: Added.
13743 * WebView/WebDeviceOrientationProvider.h: Added.
13744 * WebView/WebDeviceOrientationProviderMock.h: Added.
13745 * WebView/WebDeviceOrientationProviderMock.mm: Added.
13746 (-[WebDeviceOrientationProviderMockInternal setOrientation:]):
13747 (-[WebDeviceOrientationProviderMockInternal setController:]):
13748 (-[WebDeviceOrientationProviderMockInternal startUpdating]):
13749 (-[WebDeviceOrientationProviderMockInternal stopUpdating]):
13750 (-[WebDeviceOrientationProviderMockInternal lastOrientation]):
13751 (-[WebDeviceOrientationProviderMock init]):
13752 (-[WebDeviceOrientationProviderMock dealloc]):
13753 (-[WebDeviceOrientationProviderMock setOrientation:]):
13754 (-[WebDeviceOrientationProviderMock setController:]):
13755 (-[WebDeviceOrientationProviderMock startUpdating]):
13756 (-[WebDeviceOrientationProviderMock stopUpdating]):
13757 (-[WebDeviceOrientationProviderMock lastOrientation]):
13758 * WebView/WebDeviceOrientationProviderMockInternal.h: Added.
13759 * WebView/WebView.mm:
13760 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
13761 (-[WebView _setDeviceOrientationProvider:]):
13762 (-[WebView _deviceOrientationProvider]):
13763 * WebView/WebViewData.h:
13764 * WebView/WebViewPrivate.h:
13766 2010-09-01 Jia Pu <jpu@apple.com>
13768 Reviewed by Dan Bernstein.
13770 Add support for autocorrection UI on Mac OS X.
13771 https://bugs.webkit.org/show_bug.cgi?id=44958
13772 <rdar://problem/7326847>
13774 See detailed high level description in WebCore/ChangeLog.
13776 * WebCoreSupport/WebEditorClient.h: Added new member methods declared in
13777 EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object.
13779 * WebCoreSupport/WebEditorClient.mm:
13780 (WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag.
13781 (WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is
13782 dismissed before destroying the object.
13783 (WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes.
13784 (WebEditorClient::showCorrectionPanel): Show autocorrection UI.
13785 (WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI.
13787 2010-09-01 Mark Rowe <mrowe@apple.com>
13789 Reviewed by Adam Roben.
13791 <rdar://problem/8374711> WebKit needs to compile without access to QuickDraw private headers.
13793 * Carbon/HIViewAdapter.m:
13794 * Carbon/HIWebView.mm:
13795 * Misc/QuickDrawCompatibility.h: Added.
13796 * Plugins/WebNetscapePluginView.mm:
13798 2010-08-31 Dave Hyatt <hyatt@apple.com>
13800 Reviewed by Sam Weinig.
13802 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
13803 the former can occur in more places without having to do the latter.
13805 Eliminate Mac-specific code for style re-application and recursive layout/style updating in
13806 favor of the cross-platform code that all the other ports use.
13808 * Carbon/HIWebView.mm:
13810 * WebCoreSupport/WebFrameLoaderClient.mm:
13811 (WebFrameLoaderClient::forceLayout):
13812 * WebView/WebHTMLView.mm:
13813 (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
13814 (-[WebHTMLView viewWillDraw]):
13815 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
13816 (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
13817 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
13818 (-[WebHTMLView reapplyStyles]):
13819 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
13820 (-[WebHTMLView setNeedsToApplyStyles:]):
13821 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
13822 (-[WebHTMLView _layoutIfNeeded]):
13823 (-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):
13824 * WebView/WebHTMLViewInternal.h:
13825 * WebView/WebView.mm:
13826 (-[WebView _viewWillDrawInternal]):
13828 2010-08-31 Sam Weinig <sam@webkit.org>
13830 Reviewed by Darin Adler.
13832 Add ability to count text matches without marking
13833 https://bugs.webkit.org/show_bug.cgi?id=43996
13835 Safari needs to be able to count text matches without triggering lots of repainting.
13836 Rename markAllMatchesForText: to countMatchesForText: and add a markMatches:
13837 parameter. For backwards compatibility markAllMatchesForText: calls
13838 countMatchesForText: and passes YES for markMatches:.
13840 * WebView/WebDocumentInternal.h:
13841 * WebView/WebHTMLView.mm:
13842 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
13843 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
13844 * WebView/WebPDFView.mm:
13845 (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
13846 (-[WebPDFView countMatchesForText:caseSensitive:limit:markMatches:]):
13847 * WebView/WebView.mm:
13848 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
13849 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
13850 * WebView/WebViewPrivate.h:
13852 2010-08-31 Darin Adler <darin@apple.com>
13854 Reviewed by Anders Carlsson.
13856 * WebInspector/WebInspectorFrontend.mm:
13857 (-[WebInspectorFrontend initWithFrontendClient:]): Remove a stray semicolon.
13859 2010-08-30 Mark Rowe <mrowe@apple.com>
13861 Reviewed by Darin Adler.
13863 <rdar://problem/8369736> WebKit build fails.
13865 Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed.
13867 * Carbon/HIViewAdapter.m:
13868 * Carbon/HIWebView.mm:
13869 * Plugins/WebNetscapePluginView.mm:
13871 2010-08-30 Andy Estes <aestes@apple.com>
13873 Reviewed by Darin Adler.
13875 REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in.
13876 https://bugs.webkit.org/show_bug.cgi?id=44865
13878 After http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in
13879 for authentication fail to log in. This is due to a bug in AppleConnect that r66156
13880 exposed, but since this will have a significant impact on users of WebKit nightly
13881 builds, a plugin-specific hack should be added while the underlying issue is being
13884 * WebCoreSupport/WebFrameLoaderClient.mm:
13885 (WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase
13886 if the plugin is of type 'application/x-snkp'.
13888 2010-08-27 Jer Noble <jer.noble@apple.com>
13890 Reviewed by Eric Carlson.
13892 text/plain non-video files cause <video> to hang (while reading them?)
13893 https://bugs.webkit.org/show_bug.cgi?id=44212
13895 Add the new WebKitSystemInterface function WKQTMovieDisableComponent to
13896 the initialization routine.
13898 * WebCoreSupport/WebSystemInterface.mm:
13899 (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent.
13901 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
13903 Unreviewed, rolling out r66198.
13904 http://trac.webkit.org/changeset/66198
13905 https://bugs.webkit.org/show_bug.cgi?id=44856
13907 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
13909 * WebCoreSupport/WebInspectorClient.h:
13910 * WebCoreSupport/WebInspectorClient.mm:
13911 (WebInspectorFrontendClient::closeWindow):
13912 (-[WebInspectorWindowController windowShouldClose:]):
13913 (-[WebInspectorWindowController destroyInspectorView]):
13915 2010-08-28 Darin Adler <darin@apple.com>
13917 Reviewed by Sam Weinig.
13919 Make an internal method used by Apple Mail into SPI
13920 https://bugs.webkit.org/show_bug.cgi?id=44832
13921 rdar://problem/5748951
13923 * WebView/WebFrame.mm:
13924 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
13925 from the internal section to the private section.
13926 * WebView/WebFrameInternal.h: Moved the method declaration out of here.
13927 * WebView/WebFramePrivate.h: Moved the method declaration in here.
13929 2010-08-27 Jer Noble <jer.noble@apple.com>
13931 Reviewed by Eric Carlson.
13933 Add JavaScript API to allow a page to go fullscreen.
13934 rdar://problem/6867795
13936 Added chrome client overrides which support entering and exiting full screen. A new preference has
13937 been added (setFullScreenEnabled:) to control at runtime whether full screen support is enabled
13938 (defaults to disabled). Added a new WebKitFullScreenListener callback object which notifies WebCore
13939 when the chrome has started/finished its full screen animation.
13941 * Configurations/FeatureDefines.xcconfig:
13942 * WebCoreSupport/WebChromeClient.h:
13943 * WebCoreSupport/WebChromeClient.mm:
13944 (WebChromeClient::supportsFullscreenForElement):
13945 (WebChromeClient::enterFullscreenForElement):
13946 (WebChromeClient::exitFullscreenForElement):
13947 (-[WebKitFullScreenListener initWithElement:]):
13948 (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
13949 (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
13950 (-[WebKitFullScreenListener webkitWillExitFullScreen]):
13951 (-[WebKitFullScreenListener webkitDidExitFullScreen]):
13952 * WebView/WebPreferenceKeysPrivate.h:
13953 * WebView/WebPreferences.h:
13954 * WebView/WebPreferences.mm:
13955 (+[WebPreferences initialize]):
13956 (-[WebPreferences setFullScreenEnabled:]):
13957 (-[WebPreferences fullScreenEnabled]):
13958 * WebView/WebUIDelegatePrivate.h:
13959 * WebView/WebView.mm:
13960 (-[WebView _preferencesChangedNotification:]):
13962 2010-08-27 David Hyatt <hyatt@apple.com>
13964 Reviewed by Simon Fraser.
13966 https://bugs.webkit.org/show_bug.cgi?id=44788, implement HTML5-compliant doctype switching.
13968 Rename the various modes to match the HTML5 specification:
13969 ParseMode -> CompatibilityMode
13970 CompatMode -> QuirksMode
13971 AlmostStrictMode -> LimitedQuirksMode
13972 StrictMode -> NoQuirksMode
13974 Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
13975 instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.
13977 Clean up user stylesheets to minimize style recalculation when the mode is switched.
13979 Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
13980 dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
13981 Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
13984 determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
13987 * WebView/WebView.mm:
13988 (-[WebView _preferencesChangedNotification:]):
13990 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
13992 Reviewed by Pavel Feldman.
13994 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
13995 https://bugs.webkit.org/show_bug.cgi?id=44230
13997 * WebCoreSupport/WebInspectorClient.h:
13998 * WebCoreSupport/WebInspectorClient.mm:
13999 (WebInspectorFrontendClient::closeWindow):
14000 (WebInspectorFrontendClient::disconnectFromBackend):
14001 (-[WebInspectorWindowController windowShouldClose:]):
14002 (-[WebInspectorWindowController destroyInspectorView:]):
14004 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
14006 Unreviewed. Revert r66103 since Qt tests are failing.
14008 * WebCoreSupport/WebInspectorClient.h:
14009 * WebCoreSupport/WebInspectorClient.mm:
14010 (WebInspectorFrontendClient::closeWindow):
14011 (-[WebInspectorWindowController windowShouldClose:]):
14012 (-[WebInspectorWindowController destroyInspectorView]):
14014 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
14016 Reviewed by Pavel Feldman.
14018 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
14019 https://bugs.webkit.org/show_bug.cgi?id=44230
14021 * WebCoreSupport/WebInspectorClient.h:
14022 * WebCoreSupport/WebInspectorClient.mm:
14023 (WebInspectorFrontendClient::closeWindow):
14024 (WebInspectorFrontendClient::disconnectFromBackend):
14025 (-[WebInspectorWindowController windowShouldClose:]):
14026 (-[WebInspectorWindowController destroyInspectorView:]):
14028 2010-08-24 Eric Seidel <eric@webkit.org>
14030 Reviewed by Adam Barth.
14032 Remove HTML5 parser testing infrastructure now that we don't need it
14033 https://bugs.webkit.org/show_bug.cgi?id=44581
14035 * WebView/WebPreferenceKeysPrivate.h:
14036 * WebView/WebPreferences.mm:
14037 (+[WebPreferences initialize]):
14038 * WebView/WebPreferencesPrivate.h:
14039 * WebView/WebView.mm:
14040 (-[WebView _preferencesChangedNotification:]):
14042 2010-08-24 Sam Weinig <sam@webkit.org>
14044 Reviewed by Oliver Hunt.
14046 Paste event fires twice for mac WebKit
14047 <rdar://problem/8094611>
14048 https://bugs.webkit.org/show_bug.cgi?id=44535
14050 The mac implementation of paste in WebKit was accidentally calling
14051 Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
14052 in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
14053 Use the new pasteAsPlainTextBypassingDHTML function to bypass the
14056 * WebView/WebHTMLView.mm:
14057 (-[WebHTMLView paste:]):
14059 2010-08-24 Daniel Cheng <dcheng@chromium.org>
14061 Reviewed by Eric Seidel.
14063 [chromium] Generate drag images for HTML elements and selections.
14064 https://bugs.webkit.org/show_bug.cgi?id=43449
14066 Fix up calls to Frame::nodeImage, which has a new signature.
14068 * Plugins/WebBaseNetscapePluginView.mm:
14069 (-[WebBaseNetscapePluginView halt]):
14071 2010-08-23 Mike Thole <mthole@apple.com>
14073 Reviewed by Dan Bernstein.
14075 WebPDFView should remove itself as the delegate of its PDFView before being dealloced
14076 https://bugs.webkit.org/show_bug.cgi?id=44441
14078 * WebView/WebPDFView.mm:
14079 (-[WebPDFView dealloc]): Set the PDFView's delegate to nil.
14081 2010-08-22 Daniel Bates <dbates@rim.com>
14083 Reviewed by Eric Seidel.
14085 Encapsulate document marker management into DocumentMarkerController
14086 https://bugs.webkit.org/show_bug.cgi?id=44383
14088 Modify call sites in the Apple Mac port to use DocumentMarkerController.
14090 No functionality was changed, so no new tests.
14092 * WebView/WebFrame.mm:
14093 (-[WebFrame _unmarkAllBadGrammar]):
14094 (-[WebFrame _unmarkAllMisspellings]):
14095 * WebView/WebHTMLView.mm:
14096 (-[WebHTMLView unmarkAllTextMatches]):
14097 (-[WebHTMLView rectsForTextMatches]):
14099 2010-08-19 David Kilzer <ddkilzer@apple.com>
14101 <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
14103 Reviewed by Joseph Pecoraro.
14105 * Plugins/Hosted/HostedNetscapePluginStream.mm: Changed
14106 USE(PLUGIN_HOST_PROCESS) to
14107 USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API).
14108 * Plugins/Hosted/NetscapePluginHostManager.mm: Ditto.
14109 * Plugins/Hosted/NetscapePluginHostProxy.mm: Ditto.
14110 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Ditto.
14111 * Plugins/Hosted/ProxyInstance.mm: Ditto.
14112 * Plugins/Hosted/WebHostedNetscapePluginView.mm: Ditto.
14113 * WebCoreSupport/WebChromeClient.mm: Ditto.
14114 (WebChromeClient::createWindow):
14115 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
14116 (WebFrameLoaderClient::dispatchCreatePage):
14117 * WebView/WebHTMLView.mm:
14118 (needsCursorRectsSupportAtPoint): Added #if
14119 ENABLE(NETSCAPE_PLUGIN_API) and #endif macros as needed.
14120 * WebView/WebView.mm:
14121 (+[WebView _isNodeHaltedPlugin:]): Ditto.
14122 (+[WebView _hasPluginForNodeBeenHalted:]): Ditto.
14123 (+[WebView _restartHaltedPluginForNode:]): Ditto.
14125 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
14127 Reviewed by Darin Adler.
14129 Add NetworkingContext to avoid layer violations
14130 https://bugs.webkit.org/show_bug.cgi?id=42292
14132 Preparation: Just add the files to the build system.
14134 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
14135 Placeholder with tentative code that might be changed when landing
14137 * WebCoreSupport/WebFrameNetworkingContext.mm: Added.
14138 Empty placeholder for now.
14140 2010-08-17 Brady Eidson <beidson@apple.com>
14142 Reviewed by Sam Weinig.
14144 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
14145 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
14147 * WebView/WebView.mm:
14148 (-[WebView canGoBack]): Return false if loads are deferred.
14149 (-[WebView canGoForward]): Ditto.
14151 2010-08-14 Joseph Pecoraro <joepeck@webkit.org>
14153 Reviewed by Pavel Feldman.
14155 Web Inspector: -[WebInspector attach] and detach should work
14156 https://bugs.webkit.org/show_bug.cgi?id=43924
14158 For actions that relate only to the Web Inspector's Frontend
14159 window (actions on the InspectorFrontendClient) the new Obj-C
14160 wrapper class WebInspectorFrontend can be used. For now, this
14161 is just attach and detach.
14163 * WebCoreSupport/WebInspectorClient.mm:
14164 (WebInspectorClient::openInspectorFrontend): setup and attach the WebInspectorFrontend to the WebInspector.
14165 * WebInspector/WebInspector.h:
14166 * WebInspector/WebInspector.mm:
14167 (-[WebInspector dealloc]):
14168 (-[WebInspector attach:]): delegate to the frontend.
14169 (-[WebInspector detach:]): delegate to the frontend.
14170 (-[WebInspector setFrontend:]):
14171 * WebInspector/WebInspectorFrontend.h: Added.
14172 * WebInspector/WebInspectorFrontend.mm: Added.
14173 (-[WebInspectorFrontend initWithFrontendClient:]):
14174 (-[WebInspectorFrontend attach]):
14175 (-[WebInspectorFrontend detach]):
14176 * WebInspector/WebInspectorPrivate.h:
14178 2010-08-13 Gavin Barraclough <barraclough@apple.com>
14180 Rubber stamped by Sam Weinig.
14181 Switch String::/UString::ascii() to return a CString.
14183 * Plugins/Hosted/ProxyInstance.mm:
14184 (WebKit::ProxyInstance::methodsNamed):
14185 (WebKit::ProxyInstance::fieldNamed):
14187 2010-08-13 Gavin Barraclough <barraclough@apple.com>
14189 Reviewed by Sam Weinig
14191 Unify UString::UTF8String() & String::utf8() methods,
14192 remove UString::cost() & make atArrayIndex a free function.
14194 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14195 (WebKit::NetscapePluginInstanceProxy::enumerate):
14197 2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
14199 Unreviewed, rolling out r65295.
14200 http://trac.webkit.org/changeset/65295
14201 https://bugs.webkit.org/show_bug.cgi?id=43950
14203 It broke 4 sputnik tests (Requested by Ossy on #webkit).
14205 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14206 (WebKit::NetscapePluginInstanceProxy::enumerate):
14208 2010-08-12 Gavin Barraclough <barraclough@apple.com>
14210 Reviewed by Sam Weinig
14212 Unify UString::UTF8String() & String::utf8() methods,
14213 remove UString::cost() & make atArrayIndex a free function.
14215 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14216 (WebKit::NetscapePluginInstanceProxy::enumerate):
14218 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
14221 https://bugs.webkit.org/show_bug.cgi?id=43794
14223 * WebView/WebView.mm:
14224 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
14225 (-[WebView _preferencesChangedNotification:]):
14227 2010-08-10 Jeremy Orlow <jorlow@chromium.org>
14229 Reviewed by Adam Barth.
14231 Some settings are linked to the PageGroup not the Page. Create a new class for those.
14232 https://bugs.webkit.org/show_bug.cgi?id=43794
14234 Change WebView to use the new GroupSettings class rather than Settings for the
14235 settings that moved. This is sub-optimal since the settings aren't really
14236 per-view, but we can't really change the API at this point.
14238 * WebView/WebView.mm:
14239 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
14240 (-[WebView _preferencesChangedNotification:]):
14242 2010-08-11 Gavin Barraclough <barraclough@apple.com>
14244 Rubber stamps by Darin Adler & Sam Weinig.
14246 Bug 43867 - Some UString cleanup
14248 Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
14249 Move string concatenation methods to a new header to simplify down UString.h. Remove is8Bit().
14251 * WebView/WebScriptDebugger.mm:
14254 2010-08-10 David Hyatt <hyatt@apple.com>
14256 Reviewed by Dan Bernstein.
14258 https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.
14260 Add SPI for entering and exiting screen pagination mode. This is similar to printing mode but it can be done for on-screen
14263 * WebView/WebHTMLView.mm:
14264 (-[WebHTMLView _web_setPrintingModeRecursive]):
14265 (-[WebHTMLView _web_clearPrintingModeRecursive]):
14266 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
14267 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
14268 (-[WebHTMLView _endPrintMode]):
14269 (-[WebHTMLView _isInScreenPaginationMode]):
14270 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
14271 (-[WebHTMLView _endScreenPaginationMode]):
14272 (-[WebHTMLView reapplyStyles]):
14273 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
14274 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
14275 (-[WebHTMLView setPageWidthForPrinting:]):
14276 * WebView/WebHTMLViewPrivate.h:
14278 2010-08-10 Gavin Barraclough <barraclough@apple.com>
14280 Build fix (update more includes)
14282 * Plugins/Hosted/NetscapePluginHostManager.h:
14284 2010-08-10 Chris Marrin <cmarrin@apple.com>
14286 Reviewed by Oliver Hunt.
14288 Add suspendAnimations/resumeAnimation API to DRT
14289 https://bugs.webkit.org/show_bug.cgi?id=43733
14291 Mac specific API. Plumbs suspendAnimations/resumeAnimations down to WebCore.
14293 * WebView/WebFrame.mm:
14294 (-[WebFrame _suspendAnimations]):
14295 (-[WebFrame _resumeAnimations]):
14296 * WebView/WebFramePrivate.h:
14298 2010-08-10 Gavin Barraclough <barraclough@apple.com>
14300 Rubber stamped by Sam Weinig
14302 Bug 43817 - Remove UString::Rep
14303 UString::Rep has for a long time been replaced by UStringImpl (Rep
14304 remaining as a typedef). UStringImpl has since been removed too
14305 (unified with StringImpl). Remove Rep, rename rep() to impl() and
14306 m_rep to m_impl. Also add impl() method to Identifier, and rename
14307 its UString member from _ustring to m_string.
14309 * Plugins/Hosted/ProxyInstance.mm:
14310 (WebKit::ProxyInstance::methodsNamed):
14311 (WebKit::ProxyInstance::fieldNamed):
14313 2010-08-06 Gavin Barraclough <barraclough@apple.com>
14315 Rubber stamped by Sam Weinig
14317 Bug 43594 - Add string forwards to Forward.h
14318 This allows us to remove forward declarations for these classes from
14319 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
14321 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14322 * Plugins/WebBaseNetscapePluginView.h:
14323 * WebCoreSupport/WebFrameLoaderClient.h:
14324 * WebCoreSupport/WebIconDatabaseClient.h:
14325 * WebCoreSupport/WebPluginHalterClient.h:
14326 * WebView/WebViewInternal.h:
14328 2010-08-04 MORITA Hajime <morrita@google.com>
14330 Reviewed by Tony Chang.
14332 Pasting should fire textInput event.
14333 https://bugs.webkit.org/show_bug.cgi?id=42958
14335 On paste, invoke Editor instead of direct command invocation,
14336 which allows dispatching events before actual paste.
14338 * WebView/WebHTMLView.mm:
14339 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
14341 2010-08-06 Yongjun Zhang <yongjun_zhang@apple.com>
14343 Reviewed by Eric Seidel.
14345 add "const" to WebChromeClient::webView().
14346 https://bugs.webkit.org/show_bug.cgi?id=43631
14348 Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments
14349 is const method now, and calling webView() inside port-specific didReceiveViewportArguments
14350 implementation fails compiling if webView() is not const.
14352 * WebCoreSupport/WebChromeClient.h:
14353 (WebChromeClient::webView):
14355 2010-08-06 Jessie Berlin <jberlin@apple.com>
14357 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
14360 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14361 * Plugins/WebBaseNetscapePluginView.h:
14362 * WebCoreSupport/WebFrameLoaderClient.h:
14363 * WebCoreSupport/WebIconDatabaseClient.h:
14364 * WebCoreSupport/WebPluginHalterClient.h:
14365 * WebView/WebViewInternal.h:
14367 2010-08-05 Joseph Pecoraro <joepeck@webkit.org>
14369 Reviewed by David Kilzer.
14371 Remove Invalid Asserts for Application Cache Quotas
14372 https://bugs.webkit.org/show_bug.cgi?id=43585
14374 Removed Invalid ASSERTs that would always happen for quotas
14375 that were not noQuota().
14377 * WebView/WebPreferences.mm:
14378 (-[WebPreferences applicationCacheTotalQuota]):
14379 (-[WebPreferences applicationCacheDefaultOriginQuota]):
14381 2010-08-05 Gavin Barraclough <barraclough@apple.com>
14383 Rubber stamped by Sam Weinig
14385 Bug 43594 - Add string forwards to Forward.h
14386 This allows us to remove forward declarations for these classes from
14387 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
14389 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
14390 * Plugins/WebBaseNetscapePluginView.h:
14391 * WebCoreSupport/WebFrameLoaderClient.h:
14392 * WebCoreSupport/WebIconDatabaseClient.h:
14393 * WebCoreSupport/WebPluginHalterClient.h:
14394 * WebView/WebViewInternal.h:
14396 2010-08-05 Jian Li <jianli@chromium.org>
14398 Reviewed by David Levin.
14400 Unify blob related feature defines to ENABLE(BLOB).
14401 https://bugs.webkit.org/show_bug.cgi?id=43081
14403 * Configurations/FeatureDefines.xcconfig:
14405 2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
14407 Reviewed by David Kilzer.
14409 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
14410 https://bugs.webkit.org/show_bug.cgi?id=40627
14412 Part 6 - LayoutTest and Cleanup
14414 * WebCoreSupport/WebApplicationCache.h:
14415 * WebCoreSupport/WebApplicationCache.mm:
14416 (+[WebApplicationCache setMaximumSize:]): refactor out deleting the application caches.
14417 (+[WebApplicationCache deleteAllApplicationCaches]): delete application caches.
14419 2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
14421 Reviewed by David Kilzer.
14423 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
14424 https://bugs.webkit.org/show_bug.cgi?id=40627
14426 Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
14428 Per-Origin quotas exist for Databases and Application Caches. Clients
14429 given a WebSecurityOrigin have the ability to set the quota for any
14430 per-origin quota type. This puts quota management into an interface
14431 and WebSecurityOrigin allows access to quota managers for the
14432 different types of quotas.
14434 This also deprecates the old methods on WebSecurityOrigin. They are
14435 left in for now to prevent breaking older clients.
14437 The WebQuotaManager interface allows querying and modifying a
14438 per-origin quota. This is implemented for both Databases and
14439 Application Caches.
14441 * Misc/WebQuotaManager.h: Added. Interface for quota management (usage, quota, setQuota).
14442 * Storage/WebDatabaseQuotaManager.h: Added.
14443 * Storage/WebDatabaseQuotaManager.mm: Added.
14444 (-[WebDatabaseQuotaManager origin]):
14445 (-[WebDatabaseQuotaManager usage]):
14446 (-[WebDatabaseQuotaManager quota]):
14447 (-[WebDatabaseQuotaManager setQuota:]):
14448 * Storage/WebDatabaseSecurityOrigin.h: Removed.
14449 * Storage/WebDatabaseSecurityOrigin.mm: Removed.
14450 * WebCoreSupport/WebApplicationCacheQuotaManager.h: Added.
14451 * WebCoreSupport/WebApplicationCacheQuotaManager.mm: Added.
14452 (-[WebApplicationCacheQuotaManager origin]):
14453 (-[WebApplicationCacheQuotaManager usage]):
14454 (-[WebApplicationCacheQuotaManager quota]):
14455 (-[WebApplicationCacheQuotaManager setQuota:]):
14456 * WebCoreSupport/WebSecurityOriginPrivate.h: Added a category to access managers. Deprecated old methods.
14458 Remove the WebSecurityOrigin sub-classes. Managers are better.
14460 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Removed.
14461 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Removed.
14463 Create the managers lazily. Change old style calls to make use
14466 * WebCoreSupport/WebChromeClient.mm:
14467 (WebChromeClient::exceededDatabaseQuota):
14468 (WebChromeClient::reachedApplicationCacheOriginQuota):
14469 * WebCoreSupport/WebSecurityOrigin.mm:
14470 (-[WebSecurityOrigin applicationCacheQuotaManager]):
14471 (-[WebSecurityOrigin databaseQuotaManager]):
14472 (-[WebSecurityOrigin dealloc]): release the managers if they exist.
14474 2010-08-03 Alex Milowski <alex@milowski.com>
14476 Reviewed by Beth Dakin.
14478 Changed the ENABLE_MATHML value to enable MathML by default.
14480 * Configurations/FeatureDefines.xcconfig:
14482 2010-08-02 Brady Eidson <beidson@apple.com>
14484 Reviewed by Anders Carlsson.
14486 Add VisitedLinkStrategy for each platform to implement
14487 https://bugs.webkit.org/show_bug.cgi?id=43393
14489 * WebCoreSupport/WebPlatformStrategies.h:
14490 * WebCoreSupport/WebPlatformStrategies.mm:
14491 (WebPlatformStrategies::createVisitedLinkStrategy):
14492 (WebPlatformStrategies::isLinkVisited): Call back into PageGroup's visited links.
14493 (WebPlatformStrategies::addVisitedLink): Ditto.
14495 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
14497 Reviewed by Darin Fisher.
14499 PopupMenu refactoring in preparation to WebKit2
14500 https://bugs.webkit.org/show_bug.cgi?id=42592
14502 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
14503 instances, concrete classes that inherit from ChromeClient needed to be changed to
14504 implement the new methods.
14506 * WebCoreSupport/WebChromeClient.h:
14507 * WebCoreSupport/WebChromeClient.mm:
14508 (WebChromeClient::selectItemWritingDirectionIsNatural):
14509 (WebChromeClient::createPopupMenu):
14510 (WebChromeClient::createSearchPopupMenu):
14512 2010-08-02 Jeremy Orlow <jorlow@chromium.org>
14514 Speculative revert of 64425 due to Chromium instability
14515 https://bugs.webkit.org/show_bug.cgi?id=43347
14517 * WebCoreSupport/WebChromeClient.h:
14518 * WebCoreSupport/WebChromeClient.mm:
14520 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
14522 Reviewed by Darin Fisher.
14524 PopupMenu refactoring in preparation to WebKit2
14525 https://bugs.webkit.org/show_bug.cgi?id=42592
14527 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
14528 instances, concrete classes that inherit from ChromeClient needed to be changed to
14529 implement the new methods.
14531 * WebCoreSupport/WebChromeClient.h:
14532 * WebCoreSupport/WebChromeClient.mm:
14533 (WebChromeClient::selectItemWritingDirectionIsNatural):
14534 (WebChromeClient::createPopupMenu):
14535 (WebChromeClient::createSearchPopupMenu):
14537 2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
14539 Unreviewed, rolling out r64422.
14540 http://trac.webkit.org/changeset/64422
14541 https://bugs.webkit.org/show_bug.cgi?id=43304
14543 Build fixes are needed for Snow Leopard and Windows.
14544 (Requested by lca on #webkit).
14546 * WebCoreSupport/WebChromeClient.h:
14547 * WebCoreSupport/WebChromeClient.mm:
14549 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
14551 Reviewed by Darin Fisher.
14553 PopupMenu refactoring in preparation to WebKit2
14554 https://bugs.webkit.org/show_bug.cgi?id=42592
14556 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
14557 instances, concrete classes that inherit from ChromeClient needed to be changed to
14558 implement the new methods.
14560 * WebCoreSupport/WebChromeClient.h:
14561 * WebCoreSupport/WebChromeClient.mm:
14562 (WebChromeClient::selectItemWritingDirectionIsNatural):
14563 (WebChromeClient::createPopupMenu):
14564 (WebChromeClient::createSearchPopupMenu):
14566 2010-07-31 David Kilzer <ddkilzer@apple.com>
14568 <http://webkit.org/b/43300> Simplify variables in *.xcconfig files after adding iOS support
14570 Reviewed by Darin Adler.
14572 * Configurations/WebKit.xcconfig: Extracted
14573 PRODUCTION_FRAMEWORKS_DIR and PRODUCTION_ROOT variables.
14575 2010-07-30 Dan Bernstein <mitz@apple.com>
14577 Reviewed by Darin Adler.
14579 <rdar://problem/8257783> Short documents may print a second blank page
14580 https://bugs.webkit.org/show_bug.cgi?id=43271
14582 * WebView/WebHTMLView.mm:
14583 (-[WebHTMLView _web_setPrintingModeRecursive]): Updated for additional height parameter
14584 to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
14585 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
14586 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
14587 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Added height parameter,
14588 which is scaled and passed on to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
14589 (-[WebHTMLView _endPrintMode]): Updated for additional height parameter to
14590 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
14591 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): Added
14592 height parameter, which is passed on to FrameView::forceLayoutForPagination().
14593 (-[WebHTMLView layout]): Updated for additional height parameter.
14594 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:]): Added height
14595 parameter, which is passed on to -layoutToMinimumPageWidth:height:maximumPageWidth:adjustViewSize:.
14596 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Updated for additional height
14598 (-[WebHTMLView setPageWidthForPrinting:]): Ditto.
14599 (-[WebHTMLView knowsPageRange:]): Pass the available height on the page on to
14600 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize.
14601 * WebView/WebHTMLViewPrivate.h:
14603 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
14605 Fix for tests that broke after r64400. Tracking a more
14606 ideal solution in https://bugs.webkit.org/show_bug.cgi?id=40627
14608 Switch the interface back to (unsigned long long), and move
14609 the WebDatabaseSecurityOrigin implementation up into WebSecurityOrigin.
14610 The subclasses' implementations were not getting called.
14612 * Storage/WebDatabaseSecurityOrigin.mm:
14613 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm:
14614 (-[WebApplicationCacheSecurityOrigin quota]):
14615 (-[WebApplicationCacheSecurityOrigin setQuota:]):
14616 * WebCoreSupport/WebSecurityOrigin.mm:
14617 (-[WebSecurityOrigin usage]):
14618 (-[WebSecurityOrigin quota]):
14619 (-[WebSecurityOrigin setQuota:]):
14620 * WebCoreSupport/WebSecurityOriginPrivate.h:
14622 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
14624 Reviewed by David Kilzer.
14626 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
14627 https://bugs.webkit.org/show_bug.cgi?id=40627
14629 Part 4 - Client Notification when the Quota is Reached
14631 Notify the WebKit client when the per-origin quota is reached
14632 via a delegate method reachedApplicationCacheOriginQuota.
14634 Refactor the WebSecurityOrigin class to be generic enough to
14635 allow quota management of both Databases or Application Caches
14638 * Storage/WebDatabaseSecurityOrigin.h: Added.
14639 * Storage/WebDatabaseSecurityOrigin.mm: Added.
14640 (-[WebDatabaseSecurityOrigin quota]):
14641 (-[WebDatabaseSecurityOrigin setQuota:]):
14642 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Added.
14643 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Added.
14644 (-[WebApplicationCacheSecurityOrigin quota]):
14645 (-[WebApplicationCacheSecurityOrigin setQuota:]):
14646 * Storage/WebSecurityOrigin.mm: Removed. (Moved to WebCoreSupport)
14647 * Storage/WebSecurityOriginPrivate.h: Removed. (Moved to WebCoreSupport)
14648 * WebCoreSupport/WebSecurityOrigin.mm: Added.
14649 (-[WebSecurityOrigin usage]): to be implemented by subclasses.
14650 (-[WebSecurityOrigin quota]): to be implemented by subclasses.
14651 (-[WebSecurityOrigin setQuota:]): to be implemented by subclasses.
14652 * WebCoreSupport/WebSecurityOriginInternal.h: Renamed from WebKit/mac/Storage/WebSecurityOriginInternal.h.
14653 * WebCoreSupport/WebSecurityOriginPrivate.h: Added.
14655 Turn the notification into a WebUI Delegate to call. Following
14656 the example of Databases.
14658 * DefaultDelegates/WebDefaultUIDelegate.m:
14659 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]):
14660 * WebCoreSupport/WebChromeClient.h:
14661 * WebCoreSupport/WebChromeClient.mm:
14662 (WebChromeClient::exceededDatabaseQuota): use the Databases Security Origin subclass.
14663 (WebChromeClient::reachedApplicationCacheOriginQuota): use the Application Cache Security Origin subclass.
14664 * WebView/WebUIDelegatePrivate.h:
14666 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
14668 Reviewed by David Kilzer.
14670 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
14671 https://bugs.webkit.org/show_bug.cgi?id=40627
14673 Part 1 - Add Total and Per-Origin Quota Preferences.
14675 Allow the application cache total size to be a preference, and
14676 add a new preference for the default per-origin quota.
14678 Storage quotas were int64_t (long long). Boilerplate for
14679 these types added for consistency.
14681 * Misc/WebNSDictionaryExtras.h:
14682 * Misc/WebNSDictionaryExtras.m:
14683 (-[NSMutableDictionary _webkit_setLongLong:forKey:]):
14684 * WebCoreSupport/WebApplicationCache.h: setters and accessors for WebCore's cacheStorage.
14685 * WebCoreSupport/WebApplicationCache.mm:
14686 (+[WebApplicationCache maximumSize:]):
14687 (+[WebApplicationCache setMaximumSize:]):
14688 (+[WebApplicationCache defaultOriginQuota]):
14689 (+[WebApplicationCache setDefaultOriginQuota:]):
14690 * WebView/WebPreferenceKeysPrivate.h:
14691 * WebView/WebPreferences.mm:
14692 (+[WebPreferences initialize]): defaults to noQuota for both preferences.
14693 (-[WebPreferences _longLongValueForKey:]):
14694 (-[WebPreferences _setLongLongValue:forKey:]):
14695 (-[WebPreferences applicationCacheTotalQuota]):
14696 (-[WebPreferences setApplicationCacheTotalQuota:]):
14697 (-[WebPreferences applicationCacheDefaultOriginQuota]):
14698 (-[WebPreferences setApplicationCacheDefaultOriginQuota:]):
14699 * WebView/WebPreferencesPrivate.h:
14700 * WebView/WebView.mm:
14701 (-[WebView _preferencesChangedNotification:]): respect updates to the preferences.
14703 2010-07-30 Andy Estes <aestes@apple.com>
14705 Reviewed by David Kilzer.
14707 Add Xcode support for compiling WebKit against iOS SDKs.
14708 https://bugs.webkit.org/show_bug.cgi?id=42796
14710 * Configurations/Base.xcconfig:
14711 * Configurations/DebugRelease.xcconfig:
14712 * Configurations/FeatureDefines.xcconfig:
14713 * Configurations/Version.xcconfig:
14714 * Configurations/WebKit.xcconfig:
14716 2010-07-26 Steve Block <steveblock@google.com>
14718 Reviewed by Jeremy Orlow.
14720 Page clients should be passed to Page constructor via structure of pointers
14721 https://bugs.webkit.org/show_bug.cgi?id=42834
14723 * WebView/WebView.mm:
14724 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
14726 2010-07-27 Kinuko Yasuda <kinuko@chromium.org>
14728 Reviewed by Ojan Vafai.
14730 Add FILE_SYSTEM build flag for FileSystem API
14731 https://bugs.webkit.org/show_bug.cgi?id=42915
14733 * Configurations/FeatureDefines.xcconfig:
14735 2010-07-27 Steve Block <steveblock@google.com>
14737 Reviewed by Jeremy Orlow.
14739 Client-based Geolocation does not pass enableHighAccuracy option to controller and client
14740 https://bugs.webkit.org/show_bug.cgi?id=40374
14742 Stub out setEnableHighAccuracy method for the Mac port.
14744 * WebCoreSupport/WebGeolocationControllerClient.h:
14745 (WebGeolocationControllerClient::setEnableHighAccuracy):
14747 2010-07-22 Sam Weinig <sam@webkit.org>
14749 Reviewed by Maciej Stachowiak.
14751 Fix for <rdar://problem/8222626>
14752 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
14754 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
14755 should migrate to a new function name eventually
14757 * WebCoreSupport/WebEditorClient.mm:
14758 (WebEditorClient::textDidChangeInTextField):
14760 2010-07-22 Sam Weinig <sam@webkit.org>
14762 Reviewed by Anders Carlsson.
14764 Patch for https://bugs.webkit.org/show_bug.cgi?id=42836
14765 Add localized strings stubs for WebKit2.
14767 - Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
14768 for localized strings.
14770 Gets us below 200 tests failing in WebKitTestRunner.
14772 * WebCoreSupport/WebContextMenuClient.mm:
14773 (fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory.
14774 * WebCoreSupport/WebPlatformStrategies.h:
14775 * WebCoreSupport/WebPlatformStrategies.mm:
14776 * WebCoreSupport/WebViewFactory.mm:
14778 2010-07-21 Brady Eidson <beidson@apple.com>
14780 Reviewed by Geoffrey Garen.
14782 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
14783 https://bugs.webkit.org/show_bug.cgi?id=42783
14785 * WebView/WebView.mm:
14786 (+[WebView _registerURLSchemeAsSecure:]):
14787 (+[WebView registerURLSchemeAsLocal:]):
14789 2010-07-21 Simon Fraser <simon.fraser@apple.com>
14791 Reviewed by Anders Carlsson.
14793 Composited layers don't scroll in WebKit2
14794 https://bugs.webkit.org/show_bug.cgi?id=42771
14796 Prep work: FrameView::scrollPositionChanged() sounds like a generic "did scroll" bottleneck,
14797 but this is deceiving. It's only every called on one platform (Mac) when the NSScrollView gets
14798 scrolled, so rename it to FrameView::scrollPositionChangedViaPlatformWidget().
14800 * WebView/WebHTMLView.mm:
14801 (-[WebHTMLView _frameOrBoundsChanged]):
14803 2010-07-21 Eric Carlson <eric.carlson@apple.com>
14805 Reviewed by Simon Fraser.
14807 Update plug-in proxy backed <video> and <audio> elements.
14808 https://bugs.webkit.org/show_bug.cgi?id=42770
14809 <rdar://problem/7963467>
14811 * Plugins/WebPluginController.h:
14812 * Plugins/WebPluginController.mm:
14813 (-[WebPluginController dealloc]): Release _viewsNotInDocument.
14814 (-[WebPluginController stopAllPlugins]): Stop plug-ins not in the document.
14815 (-[WebPluginController pluginViewCreated:]): New, add a View (plug-in) to _viewsNotInDocument.
14816 (+[WebPluginController pluginViewHidden:]): New, remove the view (plug-in) from pluginViews.
14817 (-[WebPluginController addPlugin:]): Remove the new plug-in from _viewsNotInDocument.
14819 * WebCoreSupport/WebFrameLoaderClient.h:
14820 * WebCoreSupport/WebFrameLoaderClient.mm:
14821 (WebFrameLoaderClient::createPlugin): Remove PLUGIN_PROXY_FOR_VIDEO code, the media
14822 player proxy plug-in should never be allocated by this method.
14823 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): New, allocate a media player proxy.
14825 * WebView/WebView.mm:
14826 (-[WebView _videoProxyPluginForMIMEType:]): New. Identical to _pluginForMIMEType except it doesn't
14827 consider the arePlugInsEnabled preference.
14828 * WebView/WebViewInternal.h:
14831 2010-07-19 Chris Marrin <cmarrin@apple.com>
14833 Reviewed by Darin Adler.
14835 https://bugs.webkit.org/show_bug.cgi?id=42118
14836 Disable WebGL on Leopard for now.
14838 LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
14839 GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
14840 SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
14841 software OpenGL driver on machines without this support.
14843 * Configurations/FeatureDefines.xcconfig:
14845 2010-07-18 Anders Carlsson <andersca@apple.com>
14847 Reviewed by Sam Weinig.
14849 Move PluginWidget to WebKit
14850 https://bugs.webkit.org/show_bug.cgi?id=42530
14852 * Plugins/WebBaseNetscapePluginView.h:
14853 * Plugins/WebBaseNetscapePluginView.mm:
14854 (-[WebBaseNetscapePluginView pluginLayer]):
14855 Add default pluginLayer implementation.
14857 * WebCoreSupport/WebFrameLoaderClient.mm:
14858 (PluginWidget::PluginWidget):
14859 (PluginWidget::invalidateRect):
14860 Move the guts of PluginWidget here from WebCore.
14862 (NetscapePluginWidget::platformLayer):
14863 Get the layer from the plug-in view.
14865 2010-07-18 David Kilzer <ddkilzer@apple.com>
14867 <http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods
14869 Reviewed by Dan Bernstein.
14871 * Carbon/CarbonWindowAdapter.mm:
14872 (-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]):
14873 (-[CarbonWindowAdapter _destroyRealWindow:]):
14874 (-[CarbonWindowAdapter _clearModalWindowLevel]):
14875 * Misc/WebIconDatabase.mm:
14876 (-[WebIconDatabase init]):
14877 * Misc/WebNSPasteboardExtras.mm:
14878 (-[NSFilePromiseDragSource initWithSource:]):
14879 * WebView/WebHTMLRepresentation.mm:
14880 (-[WebHTMLRepresentation init]):
14881 * WebView/WebPreferences.mm:
14882 (-[WebPreferences init]):
14883 * WebView/WebView.mm:
14884 (-[WebView UIDelegate]):
14885 (-[WebView resourceLoadDelegate]):
14886 (-[WebView downloadDelegate]):
14887 (-[WebView policyDelegate]):
14888 (-[WebView frameLoadDelegate]):
14890 2010-07-16 Zhe Su <suzhe@chromium.org>
14892 Reviewed by Darin Adler.
14894 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
14895 https://bugs.webkit.org/show_bug.cgi?id=42253
14897 Dummy implementation of EditorClient::willSetInputMethodState.
14899 * WebCoreSupport/WebEditorClient.h:
14900 * WebCoreSupport/WebEditorClient.mm:
14901 (WebEditorClient::willSetInputMethodState):
14903 2010-07-16 Dan Bernstein <mitz@apple.com>
14905 Reviewed by Sam Weinig.
14907 Part of <rdar://problem/7233974> Deprecate +[WebView _setShouldUseFontSmoothing:]
14908 https://bugs.webkit.org/show_bug.cgi?id=29355
14910 * Misc/WebKitNSStringExtras.h:
14911 * Misc/WebKitNSStringExtras.mm:
14912 (-[NSString _web_drawAtPoint:font:textColor:]): Now calls through to
14913 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing YES for the last
14915 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Added
14916 allowingFontSmoothing:. If font smoothing is not allowed, sets the font smoothing
14917 mode to antialiased. Otherwise, sets it to auto.
14918 (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Instead of
14919 changing the font smoothing setting in the graphics context, call
14920 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing NO for the last
14923 2010-07-16 Anders Carlsson <andersca@apple.com>
14925 Reviewed by Sam Weinig.
14927 Remove semicolons from Objective-C method declarations.
14929 * WebView/WebRenderLayer.mm:
14930 (+[WebRenderLayer nameForLayer:]):
14931 (+[WebRenderLayer compositingInfoForLayer:]):
14933 2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
14935 Reviewed by Pavel Feldman.
14937 Make JS memory stats available via 'Performance' object (Web Timing).
14938 This statistics is populated only if 'WebKitMemoryInfoEnabled'
14941 'console.memory' is kept until Web Timing object becomes visible by
14942 default (currently it is hidden under compile-time flag). These stats
14943 are guarded with the same preference.
14945 https://bugs.webkit.org/show_bug.cgi?id=41617
14948 * WebView/WebPreferenceKeysPrivate.h:
14949 * WebView/WebPreferences.mm:
14950 (+[WebPreferences initialize]):
14951 (-[WebPreferences memoryInfoEnabled]):
14952 (-[WebPreferences setMemoryInfoEnabled:]):
14953 * WebView/WebPreferencesPrivate.h:
14954 * WebView/WebView.mm:
14955 (-[WebView _preferencesChangedNotification:]):
14957 2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>
14959 Reviewed by Darin Adler.
14961 Printing test results differ between machines, we should use ImageDiff instead
14962 https://bugs.webkit.org/show_bug.cgi?id=20011
14964 * Misc/WebCoreStatistics.h:
14965 * Misc/WebCoreStatistics.mm:
14966 (-[WebFrame printToCGContext:cgContext:pageWidthInPixels:]):
14968 2010-07-15 Daniel Bates <dbates@rim.com>
14970 Reviewed by Darin Adler.
14972 [Mac] Implement LayoutTestController::markerTextForListItem()
14973 https://bugs.webkit.org/show_bug.cgi?id=37929
14975 Implements support for markerTextForListItem in the Mac port.
14977 * DOM/WebDOMOperations.mm:
14978 (+[DOMElement _DOMElementFromJSContext]): Added.
14979 (-[DOMElement _markerTextForListItem]): Added.
14980 * DOM/WebDOMOperationsPrivate.h:
14982 2010-07-14 Simon Fraser <simon.fraser@apple.com>
14984 Fix non-ACCELERATED_COMPOSITING build.
14986 * WebView/WebRenderLayer.mm:
14987 (+[WebRenderLayer compositingInfoForLayer:]):
14989 2010-07-14 Simon Fraser <simon.fraser@apple.com>
14991 Reviewed by John Sullivan.
14993 <rdar://problem/8186963> Expose information about compositing layers.
14995 Use RenderLayerBacking::compositingLayerType() to add more information about compositing to
14996 WebRenderLayer, via a compositingInfo property. Also show element classnames.
14998 Also add separator items between the various z-order lists.
15000 * WebView/WebRenderLayer.h:
15001 * WebView/WebRenderLayer.mm:
15002 (+[WebRenderLayer nameForLayer:]):
15003 (+[WebRenderLayer compositingInfoForLayer:]):
15004 (-[WebRenderLayer initWithRenderLayer:]):
15005 (-[WebRenderLayer initWithName:]):
15006 (-[WebRenderLayer initWithWebFrame:]):
15007 (-[WebRenderLayer dealloc]):
15008 (-[WebRenderLayer buildDescendantLayers:]):
15009 (-[WebRenderLayer compositingInfo]):
15010 (-[WebRenderLayer isComposited]):
15011 (-[WebRenderLayer isSeparator]):
15013 2010-07-14 Darin Adler <darin@apple.com>
15015 Another try at fixing the Tiger build.
15017 Avoid non-ASCII in source files to keep Tiger compiler happy.
15019 * WebView/WebRenderLayer.mm:
15020 (+[WebRenderLayer nameForLayer:]): Use %C for the non-ASCII characters.
15022 2010-07-14 Sam Weinig <sam@webkit.org>
15024 Reviewed by Darin Adler.
15026 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
15027 Make changing Cursors work in WebKit2.
15029 * WebCoreSupport/WebChromeClient.h:
15030 * WebCoreSupport/WebChromeClient.mm:
15031 (WebChromeClient::setCursor):
15032 * WebView/WebView.mm:
15033 Implement cursor changing at the WebKit level for the sake of WebKit2.
15034 This functionality is being moved from WidgetMac.mm.
15035 (+[WebView _pointingHandCursor]):
15036 Update to use platformCursor() instead of impl().
15038 2010-07-13 Simon Fraser <simon.fraser@apple.com>
15042 Avoid non-ASCII in souce files to keep Tiger compiler happy.
15044 * WebView/WebRenderLayer.mm:
15045 (+[WebRenderLayer nameForLayer:]):
15047 2010-07-13 Simon Fraser <simon.fraser@apple.com>
15049 Reviewed by Dan Bernstein.
15051 <rdar://problem/8186963> Expose RenderLayer hierarchy via Obj-C for debugging.
15053 Add a WebRenderLayer class that reflects the RenderLayer tree into a hierarchy
15054 of Objective-C objects suitable for display in an outline view.
15056 * WebKit.exp: Export the WebRenderLayer Objective-C class.
15057 * WebView/WebRenderLayer.h: Added.
15058 * WebView/WebRenderLayer.mm: Added.
15060 2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
15062 Reviewed by Darin Adler.
15064 Prevent assertion/duplicate loads for non-deferred subtitute-data loads
15066 https://bugs.webkit.org/show_bug.cgi?id=30879
15068 MainResourceLoader uses the member m_initialRequest to store requests for future
15069 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
15070 have to clear this request so that subsequent entries into the loader will not
15071 start yet another load.
15073 This can happen as a result of a PageGroupLoadDeferrer going out of scope when
15074 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
15075 but only in the case of using both substitute-data and non-deferred main resource
15076 load together. That's why two new DRT functions were added:
15078 * queueLoadHTMLString()
15079 * setDeferMainResourceLoad()
15081 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
15082 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
15083 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
15085 * WebView/WebDataSource.mm:
15086 (-[WebDataSource _setDeferMainResourceDataLoad:]):
15087 * WebView/WebDataSourcePrivate.h:
15089 2010-07-13 Philippe Normand <pnormand@igalia.com>
15091 Rubber-stamped by Xan Lopez.
15093 Updated the copyright headers of the files modified in r62476.
15095 * WebView/WebView.mm:
15096 * WebView/WebViewData.h:
15097 * WebView/WebViewInternal.h:
15099 2010-07-09 Alexey Proskuryakov <ap@apple.com>
15101 Reviewed by Darin Adler.
15103 https://bugs.webkit.org/show_bug.cgi?id=13075
15104 XMLHttpRequest with failed authentication should set status to 401
15106 https://bugs.webkit.org/show_bug.cgi?id=6871
15107 <rdar://problem/3363403> 401 error page is never shown
15109 * Panels/WebPanelAuthenticationHandler.m:
15110 (-[WebPanelAuthenticationHandler startAuthentication:window:]): Updated a comment - this
15111 code cancels loading, not authentication (canceling authentication means telling to
15112 continue without credentials).
15113 (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]): If there were
15114 no credentials provided, tell to continue without any. There may be alternative content
15117 2010-07-09 Leon Clarke <leonclarke@google.com>
15119 Reviewed by Adam Barth.
15121 add support for link prefetching
15122 https://bugs.webkit.org/show_bug.cgi?id=3652
15124 * Configurations/FeatureDefines.xcconfig:
15126 2010-07-08 Aaron Boodman <aa@chromium.org>
15128 Reviewed by Timothy Hatcher.
15130 Add the ability for user scripts and user styles to affect just the top frame.
15132 https://bugs.webkit.org/show_bug.cgi?id=41529
15134 * WebView/WebView.mm:
15135 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]):
15136 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
15137 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]):
15138 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
15139 * WebView/WebViewPrivate.h:
15141 2010-07-08 Adele Peterson <adele@apple.com>
15143 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
15145 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721
15146 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
15148 Implement shouldMissingPluginMessageBeButton.
15150 * WebCoreSupport/WebChromeClient.h:
15151 * WebCoreSupport/WebChromeClient.mm:
15152 (WebChromeClient::shouldMissingPluginMessageBeButton):
15154 2010-07-08 Brady Eidson <beidson@apple.com>
15156 Reviewed by Tim Hatcher.
15158 <rdar://problem/8136327> - Crash in Entourage calling WebCache method from background thread
15160 * Misc/WebCache.mm:
15161 (+[WebCache setDisabled:]): Forward the call to the main thread if called from a background thread.
15163 * Misc/WebNSObjectExtras.h:
15164 * Misc/WebNSObjectExtras.mm:
15165 (+[NSObject _webkit_invokeOnMainThread]): Add a class version of the main thread invoker.
15167 2010-07-08 Mike Thole <mthole@apple.com>
15169 Reviewed by Darin Adler.
15171 Patch for https://bugs.webkit.org/show_bug.cgi?id=41896
15172 Crash under allScriptsInPDFDocument() in WebPDFDocumentExtras.mm for certain PDFs
15174 * WebView/WebPDFDocumentExtras.mm:
15175 (allScriptsInPDFDocument): Null-check 'data', as CGPDFStreamCopyData() may have returned 0.
15177 2010-07-08 Sam Weinig <sam@webkit.org>
15179 Reviewed by Anders Carlsson.
15181 Patch for https://bugs.webkit.org/show_bug.cgi?id=41826
15182 Convert BackForwardList to an abstract base class and add BackForwardListImpl
15183 as the concrete implementation of it.
15185 * History/WebBackForwardList.mm:
15186 (-[WebBackForwardList init]):
15187 (-[WebBackForwardList setPageCacheSize:]):
15188 (-[WebBackForwardList pageCacheSize]):
15190 2010-07-07 Sam Weinig <sam@webkit.org>
15192 Reviewed by Anders Carlsson.
15194 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
15195 Add basic piping for BackForwardControllerClient.
15197 * WebView/WebView.mm:
15198 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
15200 2010-07-07 Anders Carlsson <andersca@apple.com>
15202 Reviewed by Sam Weinig.
15204 Change requestURL to a KURL.
15205 https://bugs.webkit.org/show_bug.cgi?id=41775
15207 * Plugins/WebNetscapePluginStream.h:
15208 (WebNetscapePluginStream::setRequestURL):
15209 * Plugins/WebNetscapePluginStream.mm:
15210 (WebNetscapePluginStream::pluginCancelledConnectionError):
15211 (WebNetscapePluginStream::errorForReason):
15212 (WebNetscapePluginStream::startStream):
15213 (WebNetscapePluginStream::didReceiveResponse):
15214 (WebNetscapePluginStream::destroyStream):
15216 2010-07-07 Anders Carlsson <andersca@apple.com>
15218 Reviewed by Sam Weinig.
15220 Rename the WebBaseNetscapePluginStream.cpp and .h files to WebNetscapePluginStream.cpp and .h to match the class name.
15222 * Plugins/WebNetscapePluginStream.h: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.h.
15223 * Plugins/WebNetscapePluginStream.mm: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.mm.
15225 2010-07-06 Steve Falkenburg <sfalken@apple.com>
15227 Reviewed by Simon Fraser.
15229 Expose URL matching from WebUserContentURLPattern
15230 https://bugs.webkit.org/show_bug.cgi?id=41726
15231 <rdar://problem/7910144>
15233 We previously had a way to construct WebUserContentURLPattern
15234 instances via WebKit, but no way for callers to perform matching.
15235 This patch adds the matchesURL functionality to allow for this.
15237 * Misc/WebUserContentURLPattern.h: Added matchesURL.
15238 * Misc/WebUserContentURLPattern.mm:
15239 (-[WebUserContentURLPattern matchesURL:]): Added. Calls through to WebCore::UserContentURLPattern::matches.
15241 2010-06-23 Philippe Normand <pnormand@igalia.com>
15243 Reviewed by Eric Carlson.
15245 [GStreamer] on Mac OS use a runloop observer to process the glib context iterations
15246 https://bugs.webkit.org/show_bug.cgi?id=35747
15248 If VIDEO and GSTREAMER are enabled, make the WebView start a
15249 runloop observer that will trigger the glib main context
15250 iterations. Those are needed by the GStreamer player only at the
15251 moment but could later be used for other GLib-dependant components
15254 * WebView/WebView.mm:
15255 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
15256 (-[WebView _close]):
15257 (-[WebView _clearGlibLoopObserver]):
15258 (glibContextIterationCallback):
15259 (-[WebView _scheduleGlibContextIterations]):
15260 * WebView/WebViewData.h:
15261 * WebView/WebViewInternal.h:
15263 2010-07-03 Jon Honeycutt <jhoneycutt@apple.com>
15265 The missing plug-in indicator should be clickable
15267 https://bugs.webkit.org/show_bug.cgi?id=41550
15268 <rdar://problem/8132162>
15270 From an original patch by Kevin Decker.
15272 Reviewed by Darin Adler.
15274 * WebCoreSupport/WebChromeClient.h:
15275 Declare an override of missingPluginButtonClicked().
15277 * WebCoreSupport/WebChromeClient.mm:
15278 (WebChromeClient::missingPluginButtonClicked):
15279 Call the UIDelegate's method.
15281 * WebView/WebUIDelegatePrivate.h:
15282 Declare didPressMissingPluginButton.
15284 2010-07-01 Timothy Hatcher <timothy@apple.com>
15286 Provide a WebView preference to disable DNS prefetching.
15288 https://bugs.webkit.org/show_bug.cgi?id=28825
15289 rdar://problem/7181249
15291 Reviewed by Darin Adler.
15293 * WebView/WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
15294 * WebView/WebPreferences.mm:
15295 (+[WebPreferences initialize]): Set WebKitDNSPrefetchingEnabledPreferenceKey to YES.
15296 (-[WebPreferences isDNSPrefetchingEnabled]): Added. Return WebKitDNSPrefetchingEnabledPreferenceKey's value.
15297 (-[WebPreferences setDNSPrefetchingEnabled:]): Added. Set WebKitDNSPrefetchingEnabledPreferenceKey's value.
15298 * WebView/WebPreferencesPrivate.h: Added isDNSPrefetchingEnabled and setDNSPrefetchingEnabled:.
15299 * WebView/WebView.mm:
15300 (-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setDNSPrefetchingEnabled.
15302 2010-07-01 Alexey Proskuryakov <ap@apple.com>
15304 Reviewed by Anders Carlsson.
15306 <rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
15307 REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction
15309 Strengthen m_inDestroy "swipe under the carpet" fix.
15311 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Added a long comment about m_inDestroy, and
15312 changed it to static.
15314 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15315 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): m_inDestroy is now
15316 static, so we don't initialize it in constructor.
15317 (WebKit::NetscapePluginInstanceProxy::destroy): Assert that we aren't already destroying
15319 (WebKit::NetscapePluginInstanceProxy::evaluate): This function accidentally lacked an
15320 m_inDestroy check in r42789.
15322 2010-06-29 Zoltan Herczeg <zherczeg@webkit.org>
15324 Reviewed by Nikolas Zimmermann.
15326 Add ConvolveMatrixElement to MigrateHeaders.make
15327 https://bugs.webkit.org/show_bug.cgi?id=5861
15329 * MigrateHeaders.make:
15331 2010-06-23 John Gregg <johnnyg@google.com>
15333 Reviewed by Kent Tamura.
15335 add ENABLE_DIRECTORY_UPLOAD build support
15336 https://bugs.webkit.org/show_bug.cgi?id=41100
15338 * Configurations/FeatureDefines.xcconfig:
15340 2010-06-28 Eric Seidel <eric@webkit.org>
15342 Reviewed by Adam Barth.
15344 Make it possible to test the new HTML5 TreeBuilder
15345 https://bugs.webkit.org/show_bug.cgi?id=41276
15347 Adam was concerned that someone might make their port
15348 depend on this setting (I guess we had some trouble with that
15349 with the HTML5Parser setting), so I littered the code with warnings.
15351 test-html5-parser now tests this code path.
15353 * WebView/WebPreferenceKeysPrivate.h:
15354 * WebView/WebPreferences.mm:
15355 (+[WebPreferences initialize]):
15356 (-[WebPreferences html5TreeBuilderEnabled]):
15357 (-[WebPreferences setHTML5TreeBuilderEnabled:]):
15358 * WebView/WebPreferencesPrivate.h:
15359 * WebView/WebView.mm:
15360 (-[WebView _preferencesChangedNotification:]):
15362 2010-06-25 Yuzo Fujishima <yuzo@google.com>
15364 Reviewed by Shinichiro Hamaji.
15366 Improve default value handling for page format properties.
15367 https://bugs.webkit.org/show_bug.cgi?id=41150
15369 * Misc/WebCoreStatistics.h:
15370 * Misc/WebCoreStatistics.mm:
15371 (-[WebFrame pageSizeAndMarginsInPixels:pageNumber:width:height:marginTop:marginRight:marginBottom:]):
15373 2010-06-26 Tony Gentilcore <tonyg@chromium.org>
15375 Reviewed by Dimitri Glazkov.
15377 Add an ENABLE_WEB_TIMING option for enabling Web Timing support.
15378 https://bugs.webkit.org/show_bug.cgi?id=38924
15380 * Configurations/FeatureDefines.xcconfig:
15382 2010-06-24 Jer Noble <jer.noble@apple.com>
15384 Reviewed by Eric Carlson.
15386 Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
15387 https://bugs.webkit.org/show_bug.cgi?id=40939
15388 rdar://problem/7996172
15390 Take a IOKit power assertion when playing video in fullscreen mode. Release the
15391 assertion when paused in fullscreen mode, and when exiting fullscreen mode.
15393 * WebView/WebVideoFullscreenController.h:
15394 * WebView/WebVideoFullscreenController.mm:
15395 (-[WebVideoFullscreenController windowDidExitFullscreen]): Call updatePowerAssertions.
15396 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Call updatePowerAssertions.
15397 (-[WebVideoFullscreenController _disableIdleDisplaySleep]):
15398 (-[WebVideoFullscreenController _enableIdleDisplaySleep]):
15399 (-[WebVideoFullscreenController _disableIdleSystemSleep]):
15400 (-[WebVideoFullscreenController _enableIdleSystemSleep]):
15401 (-[WebVideoFullscreenController updatePowerAssertions]): Call _(enable|disable)Idle(System|Display)sleep depending on current playback rate and fullscreen status.
15402 (-[WebVideoFullscreenController rateChanged:]): Call updatePowerAssertions.
15404 2010-06-24 Jer Noble <jer.noble@apple.com>
15406 Reviewed by Darin Adler.
15408 Playing movie full screen on second monitor hides menu bar and title bar on main monitor
15409 https://bugs.webkit.org/show_bug.cgi?id=40933
15410 rdar://problem/7858452
15412 Remove all references to GetSystemUIMode and SetSystemUIMode. Replace these calls with
15413 [NSApplication setPresentationOptions:]. Do not auto-hide the menu bar if the fullscreen
15414 screen is does not contain the menu-bar. Do not auto-hide the dock if the fullscreen screen
15415 is both not the menu-bar screen and not the dock screen.
15417 * WebView/WebVideoFullscreenController.mm:
15418 (-[WebVideoFullscreenController windowDidLoad]): Register the applicationDidChangeScreenParameters: listener.
15419 (-[WebVideoFullscreenController windowDidExitFullscreen]): Calls updateMenuAndDockForFullscreen.
15420 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Calls updateMenuAndDockForFullscreen.
15421 (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]): New notification handler; catches NSApplicationDidChangeScreenParameters.
15422 (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]): Hide/show the menu-bar and dock according to the fullscreen window's screen.
15424 2010-06-24 Jer Noble <jer.noble@apple.com>
15426 Reviewed by Eric Carlson.
15428 Full screen video in Safari exits full-screen if you switch to another app
15429 https://bugs.webkit.org/show_bug.cgi?id=40635
15430 rdar://problem/7885101
15432 Implement the following rules for exiting full screen when switching apps:
15433 1. If the system has a single screen, switching apps will cause Safari to exit full-screen.
15434 2. Otherwise, if the full-screen screen is the "main screen" (the one with the title bar),
15435 switching apps will cause Safari to exit full-screen.
15436 3. Overriding rules 1 & 2, if the full-screen screen is not on the "current space",
15437 switching apps will NOT cause Safari to exit full-screen.
15439 * WebView/WebVideoFullscreenController.mm:
15440 (-[WebVideoFullscreenController windowDidLoad]):
15441 (-[WebVideoFullscreenController applicationDidResignActive:]):
15443 2010-06-24 Adele Peterson <adele@apple.com>
15445 Reviewed by Sam Weinig.
15447 Updated fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
15448 https://bugs.webkit.org/show_bug.cgi?id=41085
15450 * WebView/WebHTMLView.mm: Use the WebCore command system for the pasteAsPlainText selector.
15451 Also remove internal methods that no one is using.
15453 2010-06-24 Damian Kaleta <dkaleta@apple.com>
15455 Reviewed by Sam Weinig.
15457 Added an ObjC wrapper to Node::renderRect(bool&).
15459 * DOM/WebDOMOperations.mm:
15460 (-[DOMNode _renderRect:]):
15461 * DOM/WebDOMOperationsPrivate.h:
15463 2010-06-24 Adele Peterson <adele@apple.com>
15465 Reviewed by Eric Carlson.
15467 Fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
15468 https://bugs.webkit.org/show_bug.cgi?id=41085
15470 * WebView/WebHTMLView.mm: (-[WebHTMLView pasteAsPlainText:]): Reuse code in WebCore
15471 which does everything done here and also fires paste events.
15473 2010-06-23 Yuzo Fujishima <yuzo@google.com>
15475 Reviewed by Shinichiro Hamaji.
15477 Implement page format data programming interface.
15478 Add methods for testing.
15479 https://bugs.webkit.org/show_bug.cgi?id=37538
15481 * Misc/WebCoreStatistics.h:
15482 * Misc/WebCoreStatistics.mm:
15483 (-[WebFrame isPageBoxVisible:]):
15484 (-[WebFrame pageAreaRectInPixels:]):
15485 (-[WebFrame preferredPageSizeInPixels:]):
15487 2010-06-22 Anders Carlsson <andersca@apple.com>
15489 Reviewed by Sam Weinig.
15491 Get rid of more USE_LIBDISPATCH code.
15493 * Plugins/Hosted/NetscapePluginHostProxy.h:
15495 2010-06-22 Anders Carlsson <andersca@apple.com>
15497 Reviewed by Sam Weinig.
15499 Get rid of the USE_LIBDISPATCH code.
15501 * Plugins/Hosted/NetscapePluginHostProxy.mm:
15502 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
15503 (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
15505 2010-06-22 Anders Carlsson <andersca@apple.com>
15507 Reviewed by Sam Weinig.
15509 Wean NetscapePluginHostManager of any knowledge about WebNetscapePluginPackage
15510 https://bugs.webkit.org/show_bug.cgi?id=41006
15512 * Plugins/Hosted/NetscapePluginHostManager.h:
15513 * Plugins/Hosted/NetscapePluginHostManager.mm:
15514 (WebKit::NetscapePluginHostManager::hostForPlugin):
15515 (WebKit::NetscapePluginHostManager::spawnPluginHost):
15516 (WebKit::NetscapePluginHostManager::instantiatePlugin):
15517 (WebKit::NetscapePluginHostManager::createPropertyListFile):
15518 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
15519 (-[WebHostedNetscapePluginView createPlugin]):
15520 * Plugins/WebNetscapePluginPackage.mm:
15521 (-[WebNetscapePluginPackage createPropertyListFile]):
15523 2010-06-21 Anders Carlsson <andersca@apple.com>
15525 Reviewed by Sam Weinig.
15527 Fix an off-by-one bug I introduced.
15529 * Plugins/WebNetscapePluginPackage.mm:
15530 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
15532 2010-06-21 Nate Chapin <japhet@chromium.org>
15534 Reviewed by Adam Barth.
15536 FrameLoader cleanup: Split high level subframe and plugin
15537 loading functions into a separate class.
15538 https://bugs.webkit.org/show_bug.cgi?id=40453
15540 * WebView/WebFrame.mm:
15541 (-[WebFrame _cacheabilityDictionary]):
15543 2010-06-21 Anders Carlsson <andersca@apple.com>
15545 Another Tiger build fix.
15547 * Plugins/WebNetscapePluginPackage.mm:
15548 (-[WebNetscapePluginPackage _tryLoad]):
15550 2010-06-21 Anders Carlsson <andersca@apple.com>
15552 Reviewed by Sam Weinig.
15554 More WebBasePluginPackage cleanup
15555 https://bugs.webkit.org/show_bug.cgi?id=40944
15557 * Plugins/Hosted/HostedNetscapePluginStream.mm:
15558 (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError):
15559 * Plugins/Hosted/NetscapePluginHostManager.mm:
15560 (WebKit::NetscapePluginHostManager::spawnPluginHost):
15561 * Plugins/WebBaseNetscapePluginStream.mm:
15562 (WebNetscapePluginStream::pluginCancelledConnectionError):
15563 * Plugins/WebBaseNetscapePluginView.mm:
15564 (WebHaltablePlugin::pluginName):
15565 * Plugins/WebBasePluginPackage.h:
15566 * Plugins/WebBasePluginPackage.mm:
15567 (-[WebBasePluginPackage initWithPath:]):
15568 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]):
15569 (-[WebBasePluginPackage getPluginInfoFromPLists]):
15570 (-[WebBasePluginPackage load]):
15571 (-[WebBasePluginPackage dealloc]):
15572 (-[WebBasePluginPackage finalize]):
15573 (-[WebBasePluginPackage pluginInfo]):
15574 (-[WebBasePluginPackage supportsExtension:]):
15575 (-[WebBasePluginPackage supportsMIMEType:WebCore::]):
15576 (-[WebBasePluginPackage MIMETypeForExtension:]):
15577 (-[WebBasePluginPackage isJavaPlugIn]):
15578 (-[WebBasePluginPackage versionNumber]):
15579 (-[WebBasePluginPackage WebCore::]):
15580 * Plugins/WebNetscapePluginPackage.mm:
15581 (-[WebNetscapePluginPackage openResourceFile]):
15582 (-[WebNetscapePluginPackage closeResourceFile:]):
15583 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
15584 (-[WebNetscapePluginPackage _initWithPath:]):
15585 (-[WebNetscapePluginPackage _applyDjVuWorkaround]):
15586 (-[WebNetscapePluginPackage _tryLoad]):
15587 (-[WebNetscapePluginPackage supportsSnapshotting]):
15588 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
15589 * Plugins/WebPluginDatabase.mm:
15590 (-[WebPluginDatabase refresh]):
15591 (-[WebPluginDatabase _removePlugin:]):
15592 * Plugins/WebPluginPackage.mm:
15593 (-[WebPluginPackage initWithPath:]):
15594 (-[WebPluginPackage load]):
15595 * WebCoreSupport/WebFrameLoaderClient.mm:
15596 (WebFrameLoaderClient::createPlugin):
15597 * WebCoreSupport/WebPlatformStrategies.mm:
15598 (WebPlatformStrategies::getPluginInfo):
15600 2010-06-21 Anders Carlsson <andersca@apple.com>
15602 Another PowerPC build fix.
15604 * Plugins/WebNetscapePluginPackage.mm:
15605 (-[WebNetscapePluginPackage openResourceFile]):
15606 (-[WebNetscapePluginPackage _tryLoad]):
15608 2010-06-21 Anders Carlsson <andersca@apple.com>
15610 Try to fix the PowerPC build.
15612 * Plugins/WebNetscapePluginPackage.mm:
15613 (-[WebNetscapePluginPackage _tryLoad]):
15615 2010-06-21 Nate Chapin <japhet@chromium.org>
15617 Reviewed by Adam Barth.
15619 Update relevant calls into FrameLoader to make use of
15620 FrameLoaderStateMachine.
15621 https://bugs.webkit.org/show_bug.cgi?id=39695
15623 * WebCoreSupport/WebFrameLoaderClient.mm:
15624 (WebFrameLoaderClient::transitionToCommittedForNewPage):
15625 * WebView/WebFrame.mm:
15626 (-[WebFrame _firstLayoutDone]):
15628 2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>
15630 Reviewed by Dan Bernstein.
15632 Chromium/Mac build fix.
15634 * WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other
15637 2010-06-21 Anders Carlsson <andersca@apple.com>
15639 Reviewed by Dan Bernstein.
15641 Make all of WebKit build with clang++
15643 * DefaultDelegates/WebDefaultPolicyDelegate.m:
15644 (-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
15645 * Plugins/Hosted/NetscapePluginHostManager.mm:
15646 * Plugins/WebBaseNetscapePluginView.mm:
15647 (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
15648 * WebView/WebDynamicScrollBarsView.mm:
15649 (-[WebDynamicScrollBarsView setSuppressLayout:]):
15650 * WebView/WebHTMLRepresentation.mm:
15651 * WebView/WebNavigationData.mm:
15652 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
15653 * WebView/WebPDFRepresentation.mm:
15654 (-[WebPDFRepresentation setDataSource:]):
15655 (-[WebPDFRepresentation receivedData:withDataSource:]):
15656 (-[WebPDFRepresentation receivedError:withDataSource:]):
15657 * WebView/WebResource.mm:
15658 (-[WebResource description]):
15659 * WebView/WebSerializedJSValue.mm:
15660 (-[WebSerializedJSValue initWithValue:context:exception:]):
15661 * WebView/WebVideoFullscreenController.mm:
15662 (-[WebVideoFullscreenController WebCore::]):
15663 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
15664 (-[WebVideoFullscreenController setDelegate:]):
15665 (-[WebVideoFullscreenController enterFullscreen:]):
15666 * WebView/WebView.mm:
15667 (-[WebView _openFrameInNewWindowFromMenu:]):
15668 (-[WebView _geolocationDidChangePosition:]):
15670 2010-06-21 Anders Carlsson <andersca@apple.com>
15672 Reviewed by Sam Weinig.
15674 Remove unused dictionary ivars from WebBasePluginPackage
15675 https://bugs.webkit.org/show_bug.cgi?id=40928
15677 * Plugins/WebBasePluginPackage.h:
15678 * Plugins/WebBasePluginPackage.mm:
15679 (-[WebBasePluginPackage getPluginInfoFromPLists]):
15680 (-[WebBasePluginPackage dealloc]):
15681 * Plugins/WebNetscapePluginPackage.mm:
15682 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
15684 2010-06-21 Dan Bernstein <mitz@apple.com>
15688 * WebCoreSupport/WebSystemInterface.mm:
15689 (InitWebCoreSystemInterface):
15691 2010-06-21 Dan Bernstein <mitz@apple.com>
15693 Reviewed by Darin Adler.
15695 WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties
15696 https://bugs.webkit.org/show_bug.cgi?id=10228
15698 * WebCoreSupport/WebSystemInterface.mm:
15699 (InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex.
15701 2010-06-21 Satish Sampath <satish@chromium.org>
15703 Reviewed by Steve Block.
15705 Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
15706 https://bugs.webkit.org/show_bug.cgi?id=40878
15708 * Configurations/FeatureDefines.xcconfig:
15710 2010-06-20 Anders Carlsson <andersca@apple.com>
15714 * Plugins/WebNetscapePluginPackage.mm:
15716 2010-06-20 Anders Carlsson <andersca@apple.com>
15718 Reviewed by Dan Bernstein.
15720 Get rid of the old MIMETypes getter method
15721 https://bugs.webkit.org/show_bug.cgi?id=40898
15723 * Plugins/WebBasePluginPackage.h:
15724 * Plugins/WebBasePluginPackage.mm:
15725 (-[WebBasePluginPackage supportsExtension:]):
15726 (-[WebBasePluginPackage supportsMIMEType:WebCore::]):
15727 (-[WebBasePluginPackage MIMETypeForExtension:]):
15728 * Plugins/WebPluginDatabase.mm:
15729 (-[WebPluginDatabase refresh]):
15730 (-[WebPluginDatabase _removePlugin:]):
15732 2010-06-20 Anders Carlsson <andersca@apple.com>
15734 Reviewed by Dan Bernstein.
15736 Remove bogus const qualifiers.
15738 * WebCoreSupport/WebPasteboardHelper.h:
15739 * WebCoreSupport/WebPasteboardHelper.mm:
15740 (WebPasteboardHelper::urlFromPasteboard):
15741 (WebPasteboardHelper::plainTextFromPasteboard):
15742 (WebPasteboardHelper::fragmentFromPasteboard):
15744 2010-06-20 Anders Carlsson <andersca@apple.com>
15746 Reviewed by Dan Bernstein.
15748 Get rid of the extensionToMIME mapping in WebBasePluginPackage
15749 https://bugs.webkit.org/show_bug.cgi?id=40897
15751 Instead of using the extensionToMIME mutable dictionary, use the MIME types vector.
15752 While this makes lookup of MIME types based on extensions linear instead of constant,
15753 the number of extensions per plug-in is too small for it to matter.
15755 * Plugins/WebBasePluginPackage.h:
15756 * Plugins/WebBasePluginPackage.mm:
15757 (-[WebBasePluginPackage initWithPath:]):
15758 (-[WebBasePluginPackage dealloc]):
15759 (-[WebBasePluginPackage supportsExtension:]):
15760 (-[WebBasePluginPackage MIMETypeForExtension:]):
15761 (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
15763 2010-06-20 Anders Carlsson <andersca@apple.com>
15765 Reviewed by Dan Bernstein.
15767 Add a MimeClassInfo Vector to WebBasePluginPackage
15768 https://bugs.webkit.org/show_bug.cgi?id=40896
15770 * Plugins/WebBasePluginPackage.h:
15771 * Plugins/WebBasePluginPackage.mm:
15772 (-[WebBasePluginPackage getPluginInfoFromPLists]):
15773 (-[WebBasePluginPackage WebCore::]):
15774 * Plugins/WebNetscapePluginPackage.mm:
15775 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
15776 * WebCoreSupport/WebPlatformStrategies.mm:
15777 (WebPlatformStrategies::getPluginInfo):
15779 2010-06-20 Anders Carlsson <andersca@apple.com>
15781 Reviewed by Dan Bernstein.
15783 Move the NSBundle ivar to WebPluginPackage
15784 https://bugs.webkit.org/show_bug.cgi?id=40894
15786 * Plugins/WebBasePluginPackage.h:
15787 * Plugins/WebBasePluginPackage.mm:
15788 (-[WebBasePluginPackage initWithPath:]):
15789 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]):
15790 (-[WebBasePluginPackage getPluginInfoFromPLists]):
15791 (-[WebBasePluginPackage load]):
15792 (-[WebBasePluginPackage dealloc]):
15793 * Plugins/WebNetscapePluginPackage.mm:
15794 (-[WebNetscapePluginPackage _initWithPath:]):
15795 * Plugins/WebPluginPackage.h:
15796 * Plugins/WebPluginPackage.mm:
15797 (-[WebPluginPackage initWithPath:]):
15798 (-[WebPluginPackage dealloc]):
15799 (-[WebPluginPackage viewFactory]):
15800 (-[WebPluginPackage load]):
15802 2010-06-20 Anders Carlsson <andersca@apple.com>
15804 Reviewed by Sam Weinig.
15806 Remove -[WebBasePluginPackage bundle]
15807 https://bugs.webkit.org/show_bug.cgi?id=40892
15809 Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it.
15811 Move the supportsSnapshotting method over to the plug-in package.
15813 * Plugins/Hosted/NetscapePluginHostManager.mm:
15814 (WebKit::NetscapePluginHostManager::hostForPackage):
15815 * Plugins/WebBaseNetscapePluginView.mm:
15816 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
15817 (-[WebBaseNetscapePluginView supportsSnapshotting]):
15818 * Plugins/WebBasePluginPackage.h:
15819 * Plugins/WebBasePluginPackage.mm:
15820 (-[WebBasePluginPackage isQuickTimePlugIn]):
15821 (-[WebBasePluginPackage isJavaPlugIn]):
15822 (-[WebBasePluginPackage WebCore::]):
15823 Call bundleIdentifier directly instead of asking the bundle
15824 * Plugins/WebNetscapePluginPackage.h:
15825 * Plugins/WebNetscapePluginPackage.mm:
15826 (-[WebNetscapePluginPackage supportsSnapshotting]):
15827 * Plugins/WebNetscapePluginView.mm:
15828 (-[WebNetscapePluginView setAttributeKeys:andValues:]):
15829 (-[WebNetscapePluginView _createPlugin]):
15830 * Plugins/WebPluginDatabase.mm:
15833 2010-06-20 Anders Carlsson <andersca@apple.com>
15835 Reviewed by Dan Bernstein.
15837 Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
15838 https://bugs.webkit.org/show_bug.cgi?id=40869
15840 Re-land r61459, with extra null-checks in WebFrameLoaderClient.
15842 * Plugins/Hosted/NetscapePluginHostManager.mm:
15843 (WebKit::NetscapePluginHostManager::spawnPluginHost):
15844 * Plugins/WebBasePluginPackage.h:
15845 * Plugins/WebBasePluginPackage.mm:
15846 (-[WebBasePluginPackage initWithPath:]):
15847 (-[WebBasePluginPackage getPluginInfoFromPLists]):
15848 (-[WebBasePluginPackage dealloc]):
15849 (-[WebBasePluginPackage name]):
15850 (-[WebBasePluginPackage path]):
15851 (-[WebBasePluginPackage filename]):
15852 (-[WebBasePluginPackage pluginDescription]):
15853 (-[WebBasePluginPackage description]):
15854 (-[WebBasePluginPackage isJavaPlugIn]):
15855 * Plugins/WebNetscapePluginPackage.mm:
15856 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
15857 (-[WebNetscapePluginPackage _tryLoad]):
15858 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
15859 * Plugins/WebPluginPackage.mm:
15860 (-[WebPluginPackage load]):
15861 * WebCoreSupport/WebFrameLoaderClient.mm:
15862 (WebFrameLoaderClient::createPlugin):
15864 2010-06-18 Adam Barth <abarth@webkit.org>
15866 Unreviewed, rolling out r61459.
15867 http://trac.webkit.org/changeset/61459
15868 https://bugs.webkit.org/show_bug.cgi?id=40869
15870 Seems to have broken two tests on the Tiger buildbot:
15872 dom/html/level2/html/AppletsCollection.html
15873 plugins/qt-qwidget-plugin.html
15875 Anders wasn't on #webkit...
15877 * Plugins/Hosted/NetscapePluginHostManager.mm:
15878 (WebKit::NetscapePluginHostManager::spawnPluginHost):
15879 * Plugins/WebBasePluginPackage.h:
15880 * Plugins/WebBasePluginPackage.mm:
15881 (-[WebBasePluginPackage initWithPath:]):
15882 (-[WebBasePluginPackage getPluginInfoFromPLists]):
15883 (-[WebBasePluginPackage dealloc]):
15884 (-[WebBasePluginPackage name]):
15885 (-[WebBasePluginPackage path]):
15886 (-[WebBasePluginPackage filename]):
15887 (-[WebBasePluginPackage pluginDescription]):
15888 (-[WebBasePluginPackage setName:]):
15889 (-[WebBasePluginPackage setPath:]):
15890 (-[WebBasePluginPackage setPluginDescription:]):
15891 (-[WebBasePluginPackage description]):
15892 (-[WebBasePluginPackage isJavaPlugIn]):
15893 * Plugins/WebNetscapePluginPackage.mm:
15894 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
15895 (-[WebNetscapePluginPackage _tryLoad]):
15896 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
15897 * Plugins/WebPluginPackage.mm:
15898 (-[WebPluginPackage load]):
15900 2010-06-18 Anders Carlsson <andersca@apple.com>
15904 * Plugins/WebBasePluginPackage.mm:
15905 (-[WebBasePluginPackage isJavaPlugIn]):
15907 2010-06-18 Anders Carlsson <andersca@apple.com>
15909 Reviewed by Sam Weinig.
15911 Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
15912 https://bugs.webkit.org/show_bug.cgi?id=40869
15914 * Plugins/Hosted/NetscapePluginHostManager.mm:
15915 (WebKit::NetscapePluginHostManager::spawnPluginHost):
15916 * Plugins/WebBasePluginPackage.h:
15917 * Plugins/WebBasePluginPackage.mm:
15918 (-[WebBasePluginPackage initWithPath:]):
15919 (-[WebBasePluginPackage getPluginInfoFromPLists]):
15920 (-[WebBasePluginPackage dealloc]):
15921 (-[WebBasePluginPackage name]):
15922 (-[WebBasePluginPackage path]):
15923 (-[WebBasePluginPackage filename]):
15924 (-[WebBasePluginPackage pluginDescription]):
15925 (-[WebBasePluginPackage description]):
15926 (-[WebBasePluginPackage isJavaPlugIn]):
15927 * Plugins/WebNetscapePluginPackage.mm:
15928 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
15929 (-[WebNetscapePluginPackage _tryLoad]):
15930 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
15931 * Plugins/WebPluginPackage.mm:
15932 (-[WebPluginPackage load]):
15934 2010-06-18 Anders Carlsson <andersca@apple.com>
15936 Reviewed by Sam Weinig.
15938 Rename WebPluginPackage.m to make it an Objective-C++ file.
15940 * Plugins/WebPluginPackage.m: Removed.
15941 * Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m.
15943 2010-06-18 Anders Carlsson <andersca@apple.com>
15945 Reviewed by Sam Weinig.
15947 Get rid of the NSEnumerators from WebBasePluginPackage
15948 https://bugs.webkit.org/show_bug.cgi?id=40868
15950 * Plugins/WebBasePluginPackage.h:
15951 * Plugins/WebBasePluginPackage.mm:
15952 (-[WebBasePluginPackage MIMETypes]):
15953 (-[WebBasePluginPackage supportsExtension:]):
15954 (-[WebBasePluginPackage supportsMIMEType:]):
15955 * Plugins/WebPluginDatabase.mm:
15956 (-[WebPluginDatabase pluginForMIMEType:]):
15957 (-[WebPluginDatabase pluginForExtension:]):
15958 (-[WebPluginDatabase refresh]):
15959 (-[WebPluginDatabase _removePlugin:]):
15960 * WebCoreSupport/WebPlatformStrategies.mm:
15961 (WebPlatformStrategies::getPluginInfo):
15963 2010-06-18 Anders Carlsson <andersca@apple.com>
15965 Reviewed by Sam Weinig.
15967 Make WebCoreSystemInterface.h a C++ only header
15968 https://bugs.webkit.org/show_bug.cgi?id=40867
15970 * WebCoreSupport/WebSystemInterface.h:
15971 * WebCoreSupport/WebSystemInterface.m: Removed.
15972 * WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m.
15974 2010-06-18 Anders Carlsson <andersca@apple.com>
15976 Reviewed by Sam Weinig.
15978 Clean up WebPluginDatabase.mm
15979 https://bugs.webkit.org/show_bug.cgi?id=40866
15981 * Plugins/WebBasePluginPackage.h:
15982 * Plugins/WebBasePluginPackage.mm:
15983 (pathByResolvingSymlinksAndAliases):
15984 (-[WebBasePluginPackage initWithPath:]):
15985 Change an instance method into a static function.
15987 * Plugins/WebPluginDatabase.mm:
15988 (PluginPackageCandidates::PluginPackageCandidates):
15989 (PluginPackageCandidates::update):
15990 (PluginPackageCandidates::bestCandidate):
15991 Add a new PluginPackageCandidates class.
15993 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
15994 Use PluginPackageCandidates here.
15996 2010-06-18 Anders Carlsson <andersca@apple.com>
16000 * WebCoreSupport/WebPlatformStrategies.mm:
16002 2010-06-18 Anders Carlsson <andersca@apple.com>
16004 Reviewed by Darin Adler.
16006 Get rid of PluginDataMac.mm and use the plug-in strategy instead
16007 https://bugs.webkit.org/show_bug.cgi?id=40860
16009 * Plugins/WebBasePluginPackage.h:
16010 * WebCoreSupport/WebPlatformStrategies.h:
16011 * WebCoreSupport/WebPlatformStrategies.mm:
16012 (WebPlatformStrategies::createPluginStrategy):
16013 (WebPlatformStrategies::refreshPlugins):
16014 (WebPlatformStrategies::getPluginInfo):
16015 * WebCoreSupport/WebViewFactory.mm:
16017 2010-06-18 Anders Carlsson <andersca@apple.com>
16019 Reviewed by Dan Bernstein.
16021 Add stubbed out WebPlatformStrategies class to WebKit.
16022 https://bugs.webkit.org/show_bug.cgi?id=40851
16024 * WebCoreSupport/WebPlatformStrategies.h: Added.
16025 * WebCoreSupport/WebPlatformStrategies.mm: Added.
16026 (WebPlatformStrategies::initialize):
16027 (WebPlatformStrategies::WebPlatformStrategies):
16028 (WebPlatformStrategies::createPluginStrategy):
16029 * WebView/WebView.mm:
16030 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
16032 2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
16034 Reviewed by Adam Barth.
16036 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
16037 https://bugs.webkit.org/show_bug.cgi?id=39041
16039 * WebView/WebView.mm:
16040 (-[WebView _preferencesChangedNotification:]):
16042 2010-06-17 Darin Adler <darin@apple.com>
16044 Reviewed by Sam Weinig.
16046 Use adoptRef and create functions in more code paths
16047 https://bugs.webkit.org/show_bug.cgi?id=40760
16049 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer
16050 be an inline function.
16052 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
16053 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
16054 Moved the call to addPluginInstance out of here.
16055 (WebKit::NetscapePluginInstanceProxy::create): Move it in here.
16056 This makes sure we call adoptRef on the new proxy before any caller
16059 2010-06-16 Eric Seidel <eric@webkit.org>
16061 Reviewed by Adam Barth.
16063 Enable HTML5 Parser in Safari on Mac
16064 https://bugs.webkit.org/show_bug.cgi?id=40739
16066 The HTML5 parser is probably off on all webkit ports.
16067 We should either flip the meaning of the default so that
16068 "false" means HTML5 on all ports, or we'll have to write
16069 more code like this for all the other ports.
16071 * WebView/WebPreferences.mm:
16072 (+[WebPreferences initialize]):
16074 2010-06-15 Mark Rowe <mrowe@apple.com>
16076 Reviewed by Sam Weinig.
16078 Don't leak WebGeolocationPositionInternal and GeolocationPosition instances for every WebGeolocationPosition created.
16080 * WebView/WebGeolocationPosition.mm:
16081 (-[WebGeolocationPosition dealloc]): Implement -dealloc and release our WebGeolocationPositionInternal instance.
16083 2010-06-10 Yuzo Fujishima <yuzo@google.com>
16085 Reviewed by Shinichiro Hamaji.
16087 Implement render style selection for pages to support CSS3 Paged Media.
16088 https://bugs.webkit.org/show_bug.cgi?id=35961
16090 * Misc/WebCoreStatistics.h:
16091 * Misc/WebCoreStatistics.mm:
16092 (-[WebFrame pageProperty:propertyName:]):
16094 2010-06-15 Darin Adler <darin@apple.com>
16096 Reviewed by Adam Barth.
16098 Move functions out of Frame class that were marked "move to Chrome"
16099 https://bugs.webkit.org/show_bug.cgi?id=39636
16101 * WebView/WebView.mm:
16102 (-[WebView shouldClose]): Call shouldClose on FrameLoader instead of
16103 going through Frame.
16105 2010-06-15 Anders Carlsson <andersca@apple.com>
16107 Reviewed by Dan Bernstein.
16109 Remove getPluginInfoFromBundleAndMIMEDictionary:
16111 * Plugins/WebBasePluginPackage.mm:
16113 2010-06-15 Anders Carlsson <andersca@apple.com>
16115 Reviewed by Dan Bernstein.
16117 Fold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller.
16119 * Plugins/WebBasePluginPackage.mm:
16120 (-[WebBasePluginPackage getPluginInfoFromPLists]):
16122 2010-06-11 Simon Fraser <simon.fraser@apple.com>
16124 Reviewed by Darin Adler.
16126 <rdar://problem/8084721> Pages using accelerated compositing fail to update correctly in Carbon apps
16128 The run loop observer used to commit compositing layer changes does not do
16129 updates if [window viewsNeedDisplay] is true, because this indicates that a delayed window
16130 update is pending (added in r58623).
16132 However, Carbon apps don't use the NSWindow updating mechanism, so [window viewsNeedDisplay] always returns YES.
16133 This caused us to never sync compositing layers.
16135 So detect if the current window is wrapping a carbon window, and in that case consult the root
16136 HIView to detect if display is pending.
16138 * WebView/WebView.mm:
16139 (layerSyncRunLoopObserverCallBack):
16141 2010-06-15 Dan Bernstein <mitz@apple.com>
16143 Reviewed by John Sullivan.
16145 <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email
16147 Test: platform/mac/editing/input/NSBackgroundColor-transparent.html
16149 r50796 changed the initial background color from invalid to transparent. As a result,
16150 NSAttributedStrings returned from +_web_attributedStringFromRange started including the
16151 NSBackgroundColor attribute, with a transparent color as the value. This caused problems for
16152 components in the system that ignore the alpha component, turning the color into opaque black.
16154 * Misc/WebNSAttributedStringExtras.mm:
16155 (+[NSAttributedString _web_attributedStringFromRange:]): Change to not include the background
16156 and foreground color attributes if the color are transparent.
16158 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
16160 Reviewed by Pavel Feldman.
16162 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
16163 data from inspected page to WebInspector as JSON string via http. The native
16164 serialization to JSON string is supported by InspectorValue's classes. This patch
16165 has the implementation of sendMessageToFrontend function. WebKit version of it still
16166 uses ScriptFunctionCall and will be switched to another transport a little bit later.
16167 https://bugs.webkit.org/show_bug.cgi?id=40134
16169 * WebCoreSupport/WebInspectorClient.h:
16170 * WebCoreSupport/WebInspectorClient.mm:
16171 (WebInspectorClient::WebInspectorClient):
16172 (WebInspectorClient::openInspectorFrontend):
16174 2010-06-10 David Hyatt <hyatt@apple.com>
16176 Reviewed by John Sullivan.
16178 https://bugs.webkit.org/show_bug.cgi?id=40441, back out the original fix for 29601, since it has broken continuous
16179 wheel delta values.
16181 * WebView/WebDynamicScrollBarsView.mm:
16182 (-[WebDynamicScrollBarsView scrollWheel:]):
16184 2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
16186 Unreviewed, rolling out r60889.
16187 http://trac.webkit.org/changeset/60889
16188 https://bugs.webkit.org/show_bug.cgi?id=40365
16190 gtk bot has some kind of memory corruption (Requested by
16191 loislo on #webkit).
16193 * WebCoreSupport/WebInspectorClient.h:
16194 * WebCoreSupport/WebInspectorClient.mm:
16195 (WebInspectorClient::WebInspectorClient):
16196 (WebInspectorClient::openInspectorFrontend):
16197 (-[WebInspectorWindowController destroyInspectorView]):
16199 2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
16201 Reviewed by Pavel Feldman.
16203 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
16204 data from inspected page to WebInspector as JSON string via http. The native
16205 serialization to JSON string is supported by InspectorValue's classes. This patch
16206 has the implementation of sendMessageToFrontend function. WebKit version of it still
16207 uses ScriptFunctionCall and will be switched to another transport a little bit later.
16208 https://bugs.webkit.org/show_bug.cgi?id=40134
16210 * WebCoreSupport/WebInspectorClient.h:
16211 * WebCoreSupport/WebInspectorClient.mm:
16212 (WebInspectorClient::WebInspectorClient):
16213 (WebInspectorClient::openInspectorFrontend):
16215 2010-06-08 Mark Rowe <mrowe@apple.com>
16217 Reviewed by Adele Peterson.
16219 <rdar://problem/8072136> REGRESSION (r56051): Inspect Element context menu does nothing in applications linked against 10.4 SDK
16221 * WebCoreSupport/WebContextMenuClient.mm:
16222 (fixMenusReceivedFromOldClients): Fix up the tag on the Inspect Element menu item. This ensures that even if the
16223 context menu layout doesn't match our expectations that the menu item will continue to trigger the web inspector.
16225 2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
16227 Reviewed by Ojan Vafai and Darin Adler.
16229 Refactor platform dependent editing behavior code out of Settings
16230 https://bugs.webkit.org/show_bug.cgi?id=39854
16232 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
16233 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
16235 * WebView/WebFrame.mm:
16237 * WebView/WebFrameInternal.h:
16238 * WebView/WebView.mm:
16239 (-[WebView _preferencesChangedNotification:]):
16241 2010-06-06 MORITA Hajime <morrita@google.com>
16243 Unreviewd, follow up to r60820
16245 https://bugs.webkit.org/show_bug.cgi?id=40219
16246 [Mac] ENABLE_METER_TAG should be enabled
16248 Added ENABLE_METER_TAG.
16250 * Configurations/FeatureDefines.xcconfig:
16252 2010-06-06 Gavin Barraclough <barraclough@apple.com>
16254 Reviewed by Sam Weinig.
16256 Bug 40214 - Clean up error construction / throwing in JSC.
16258 The one egregious insanity here is that creating an error requires
16259 a VM-entry-esqe-host call (the string argument is wrapped as a JS
16260 object & pushed on the RegisterFile, then unwrapped back to a
16261 UString). Changing this also means you only require a global
16262 object, not an ExecState, to create an error.
16264 The methods to create error objects are also parameterized
16265 requiring a switch on the type, which can be made cleaner and
16266 faster by moving to a separate method per error type. Code to add
16267 divot information to error had been duplicated, and is coalesced
16268 back into a single function.
16270 Convenience methods added to create & throw type & syntax error
16271 with a default error message, since this is a common case.
16273 Also, errors are currently thrown either using
16274 "throwError(exec, error)" or "exec->setException(error)" - unify
16275 on the former, since this is more commonly used. Add
16276 "throwVMError(exec, error)" equivalents, as a convenience for
16277 cases where the result was being wrapped in "JSValue::encode(...)".
16279 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
16280 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
16281 * Plugins/Hosted/ProxyInstance.mm:
16282 (WebKit::ProxyInstance::invokeMethod):
16284 2010-06-02 Gavin Barraclough <barraclough@apple.com>
16286 Reviewed by Oliver Hunt.
16288 Bug 40094 - The return type of NativeFunction should be EncodedJSValue
16289 On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not.
16291 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
16292 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
16293 (WebKit::NetscapePluginInstanceProxy::invoke):
16295 2010-06-02 Sterling Swigart <sswigart@google.com>
16297 Reviewed by David Levin.
16299 Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
16300 https://bugs.webkit.org/show_bug.cgi?id=39906
16302 * Configurations/FeatureDefines.xcconfig:
16304 2010-06-01 David Hyatt <hyatt@apple.com>
16306 Reviewed by Anders Carlsson.
16308 Add a preference for paginating during layout (the new model for computing page breaks).
16310 * WebView/WebPreferenceKeysPrivate.h:
16311 * WebView/WebPreferences.mm:
16312 (-[WebPreferences paginateDuringLayoutEnabled]):
16313 (-[WebPreferences setPaginateDuringLayoutEnabled:]):
16314 * WebView/WebPreferencesPrivate.h:
16315 * WebView/WebView.mm:
16316 (-[WebView _preferencesChangedNotification:]):
16318 2010-06-01 Kevin Decker <kdecker@apple.com>
16320 Reviewed by Simon Fraser.
16322 https://bugs.webkit.org/show_bug.cgi?id=40025
16323 <rdar://problem/8046273> All Flash content crashes after installing CS5 Design Premium.
16325 * Plugins/WebBaseNetscapePluginView.mm:
16326 (-[WebBaseNetscapePluginView supportsSnapshotting]): Do not support snapshotting Flash 10.1 if
16327 the version is less than 10.1.53.60.
16329 2010-06-01 Alexey Proskuryakov <ap@apple.com>
16331 Reviewed by Sam Weinig.
16333 https://bugs.webkit.org/show_bug.cgi?id=39434
16334 REGRESSION (r59811): Geolocation callbacks cannot be created
16336 Removing unused WebGeolocationMock.
16338 * WebCoreSupport/WebGeolocationMock.mm: Removed.
16339 * WebCoreSupport/WebGeolocationMockPrivate.h: Removed.
16342 2010-05-30 Darin Adler <darin@apple.com>
16344 Reviewed by Sam Weinig.
16346 Make more HTML DOM members private, especially constructors, third and final batch
16347 https://bugs.webkit.org/show_bug.cgi?id=39916
16349 * WebView/WebHTMLRepresentation.mm:
16350 (-[WebHTMLRepresentation elementWithName:inForm:]): Use the new HTMLFormElement
16351 function, associatedElements, rather than getting directly at a data member
16352 named formElements.
16353 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
16355 2010-05-28 Geoffrey Garen <ggaren@apple.com>
16357 Reviewed by Sam Weinig, Gavin Barraclough, Oliver Hunt.
16359 Simplified the host calling convention.
16361 PART ONE: Functional code changes.
16365 PART TWO: Global search and replace.
16367 In the areas below, I used global search-and-replace to change
16368 (ExecState*, JSObject*, JSValue, const ArgList&) => (ExecState*)
16369 args.size() => exec->argumentCount()
16370 args.at(i) => exec->argument(i)
16372 * Plugins/Hosted/ProxyInstance.h:
16373 * Plugins/Hosted/ProxyInstance.mm:
16374 (WebKit::ProxyInstance::invoke):
16375 (WebKit::ProxyInstance::invokeMethod):
16376 (WebKit::ProxyInstance::invokeDefaultMethod):
16378 2010-05-27 Beth Dakin <bdakin@apple.com>
16380 Reviewed by Simon Fraser.
16382 Change z-component to 1.
16384 * WebView/WebHTMLView.mm:
16385 (-[WebHTMLView viewDidMoveToWindow]):
16386 (-[WebHTMLView attachRootLayer:]):
16388 2010-05-26 Simon Fraser <simon.fraser@apple.com>
16390 Reviewed by Beth Dakin and Darin Adler.
16392 Fix for <rdar://problem/7464703> HiDPI: [Layers] Compositing layers
16393 do not scale properly when running with a resolution independent
16396 Apply the userSpaceScaleFactor as a scale on the layerHostingView.
16398 * WebView/WebHTMLView.mm:
16399 (-[WebHTMLView viewDidMoveToWindow]):
16400 (-[WebHTMLView attachRootLayer:]):
16402 2010-05-25 Alexey Proskuryakov <ap@apple.com>
16404 Reviewed by Darin Adler.
16406 https://bugs.webkit.org/show_bug.cgi?id=39621
16407 <rdar://problem/8009738> Extreme memory growth on DOM Hanoi test
16409 Removed formStateDidChange support, which is not needed by any client.
16411 * WebCoreSupport/WebChromeClient.h:
16412 (WebChromeClient::formStateDidChange):
16413 * WebCoreSupport/WebChromeClient.mm:
16414 * WebView/WebUIDelegatePrivate.h:
16416 2010-05-25 Brady Eidson <beidson@apple.com>
16418 Reviewed by Darin Adler.
16420 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms)
16421 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486
16423 * Storage/WebDatabaseManager.mm:
16424 (WebKitInitializeDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on
16425 an already created tracker that already has its origins populated.
16427 2010-05-24 Darin Adler <darin@apple.com>
16429 Reviewed by Eric Seidel.
16431 Move view-related functions from Frame to FrameView
16432 https://bugs.webkit.org/show_bug.cgi?id=39366
16434 * WebView/WebView.mm:
16435 (-[WebView _setZoomMultiplier:isTextOnly:]): Call function on FrameView.
16436 (-[WebView setEditable:]): Get rid of call to empty function,
16437 removeEditingStyleFromBodyElement.
16439 2010-05-21 David Hyatt <hyatt@apple.com>
16441 Reviewed by Dan Bernstein.
16443 https://bugs.webkit.org/show_bug.cgi?id=39420
16445 Make sure everyone who needs to is using visitedDependentColor rather than accessing styles
16448 * Misc/WebNSAttributedStringExtras.mm:
16449 (+[NSAttributedString _web_attributedStringFromRange:]):
16450 * WebView/WebFrame.mm:
16451 (-[WebFrame _bodyBackgroundColor]):
16453 2010-05-21 Oliver Hunt <oliver@apple.com>
16455 Reviewed by Geoffrey Garen.
16457 All callable objects should have a global object reference
16458 https://bugs.webkit.org/show_bug.cgi?id=39495
16460 Update the plugin proxy to handle the need for global object.
16462 * Plugins/Hosted/ProxyInstance.mm:
16463 (WebKit::ProxyInstance::newRuntimeObject):
16464 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
16465 (WebKit::ProxyInstance::getMethod):
16466 * Plugins/Hosted/ProxyRuntimeObject.h:
16467 * Plugins/Hosted/ProxyRuntimeObject.mm:
16468 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
16470 2010-05-21 Steve Block <steveblock@google.com>
16472 Reviewed by Jeremy Orlow.
16474 Add DeviceOrientation and DeviceOrientationClient
16475 https://bugs.webkit.org/show_bug.cgi?id=39479
16477 * WebView/WebView.mm:
16478 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
16480 2010-05-20 Mike Thole <mthole@apple.com>
16482 Reviewed by Dave Hyatt.
16484 When using a scale factor > 1, scrollbars sometimes appear when not necessary
16485 https://bugs.webkit.org/show_bug.cgi?id=39458
16487 * WebView/WebDynamicScrollBarsView.mm:
16488 (-[WebDynamicScrollBarsView updateScrollers]): Round up non-integral sizes from AppKit
16489 so that they can be compared against the integral document size.
16491 2010-05-20 Kevin Decker <kdecker@apple.com>
16493 Reviewed by Anders Carlsson.
16495 https://bugs.webkit.org/show_bug.cgi?id=39441
16496 <rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click
16497 <rdar://problem/7986109> Youtube video controller UI entirely missing
16498 <rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region)
16500 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
16501 (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and
16502 it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale
16503 factors this assumption is false. Accordingly we now convert to the window contentView
16504 coordinate system when computing bounds in "window" and the visible rect.
16505 * Plugins/WebNetscapePluginView.mm:
16506 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto.
16508 2010-05-20 Steve Block <steveblock@google.com>
16510 Reviewed by Jeremy Orlow.
16512 Provide bindings for DeviceOrientation
16513 https://bugs.webkit.org/show_bug.cgi?id=39210
16515 Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.
16517 * Configurations/FeatureDefines.xcconfig:
16519 2010-05-20 Martin Robinson <mrobinson@webkit.org>
16521 Reviewed by Ojan Vafai.
16523 Expose the editing behavior setting in DRT to test all editing code paths
16524 https://bugs.webkit.org/show_bug.cgi?id=38603
16526 * WebView/WebFrame.mm:
16528 * WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum.
16529 * WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting.
16530 * WebView/WebPreferences.mm:
16531 (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style.
16532 (-[WebPreferences editingBehavior]): Added.
16533 (-[WebPreferences setEditingBehavior:]): Added.
16534 * WebView/WebPreferencesPrivate.h: Added the new API points to the private API.
16535 * WebView/WebView.mm:
16536 (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting.
16538 2010-05-19 Anders Carlsson <andersca@apple.com>
16540 Reviewed by Kevin Decker and Simon Fraser.
16542 <rdar://problem/8004528>
16543 REGRESSION: Coordinate system for Core Animation NPAPI plug-ins is flipped with accelerated compositing turned on
16545 When needed, create a new CALayer and set it's geometry to be flipped. Add the plug-in layer as a sublayer and then return
16546 the newly created layer.
16548 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
16549 (-[WebHostedNetscapePluginView createPlugin]):
16550 * Plugins/WebNetscapePluginView.mm:
16551 (-[WebNetscapePluginView createPlugin]):
16553 2010-05-18 Tony Chang <tony@chromium.org>
16555 Reviewed by Darin Adler.
16557 https://bugs.webkit.org/show_bug.cgi?id=24943
16558 Command-B and Command-I do not generate keydown events in contentEditable regions.
16560 Manual test because performKeyEquivalent is not called by DRT.
16562 Test: manual-tests/style-keypress-events.html
16564 * WebView/WebHTMLView.mm:
16565 (-[WebHTMLView performKeyEquivalent:]): Move style key handling until after webcore gets a chance to handle the event
16567 2010-05-18 Daniel Cheng <dcheng@chromium.org>
16569 Reviewed by Darin Adler, Jian Li.
16571 DragData::asURL() shouldn't do file validity checks
16572 https://bugs.webkit.org/show_bug.cgi?id=38711
16574 Change [NSPasteboard _web_bestURL] to still return a file URL for paths
16575 that don't exist. Callers who care about the existence of the file or
16576 whether or not it is a directory should check themselves when they
16577 want to use the file. The directory check has been left in for now,
16578 since the Mac implementation of ResourceHandle, which uses this function
16579 indirectly via DragController::performDrag) handles directories somewhat
16580 non-intuitively: it opens the parent directory in the Finder, rather
16581 than opening the directory itself.
16583 * Misc/WebNSPasteboardExtras.mm:
16584 (-[NSPasteboard _web_bestURL]):
16586 2010-05-18 Eric Seidel <eric@webkit.org>
16588 Reviewed by Adam Barth (and Maciej Stachowiak).
16590 Make it possible to enable the new HTML5Tokenizer for testing
16591 https://bugs.webkit.org/show_bug.cgi?id=39275
16593 Expose the WebCore::Settings::html5ParserEnabled as a private WebKit setting.
16595 * WebView/WebPreferenceKeysPrivate.h:
16596 * WebView/WebPreferences.mm:
16597 (-[WebPreferences html5ParserEnabled]):
16598 (-[WebPreferences setHTML5ParserEnabled:]):
16599 * WebView/WebPreferencesPrivate.h:
16600 * WebView/WebView.mm:
16601 (-[WebView _preferencesChangedNotification:]):
16603 2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
16605 Unreviewed, rolling out r59652.
16606 http://trac.webkit.org/changeset/59652
16607 https://bugs.webkit.org/show_bug.cgi?id=39268
16609 file-input-files-access test is broken on Mac (Requested by
16610 dcheng on #webkit).
16612 * Misc/WebNSPasteboardExtras.mm:
16613 (-[NSPasteboard _web_bestURL]):
16615 2010-05-17 Daniel Cheng <dcheng@chromium.org>
16617 Reviewed by Darin Adler.
16619 DragData::asURL() shouldn't do file validity checks
16620 https://bugs.webkit.org/show_bug.cgi?id=38711
16622 Change [NSPasteboard _web_bestURL] to still return a file URL for paths
16623 that don't exist. Callers who care about the existence of the file or
16624 whether or not it is a directory should check themselves when they
16625 want to use the file. The directory check has been left in for now,
16626 since the Mac implementation of ResourceHandle, which uses this function
16627 indirectly via DragController::performDrag) handles directories somewhat
16628 non-intuitively: it opens the parent directory in the Finder, rather
16629 than opening the directory itself.
16631 * Misc/WebNSPasteboardExtras.mm:
16632 (-[NSPasteboard _web_bestURL]):
16634 2010-05-14 Stephanie Lewis <slewis@apple.com>
16636 Rubber-stamped by Mark Rowe.
16638 Update order files.
16642 2010-05-13 Timothy Hatcher <timothy@apple.com>
16644 Allow reporting exceptions that occur when using JavaScriptCore APIs
16645 to the Web Inspector.
16647 <rdar://problem/7975410>
16649 Reviewed by Sam Weinig.
16651 * WebView/WebView.mm:
16652 (+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
16653 that the global object is a DOMWindow.
16654 * WebView/WebViewPrivate.h: Added _reportException:inContext:.
16656 2010-05-13 Alexey Proskuryakov <ap@apple.com>
16658 Reviewed by Darin Adler.
16660 https://bugs.webkit.org/show_bug.cgi?id=39089
16661 <rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode
16663 Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
16664 investigate a more extensible solution when there are more, and we know what the
16665 typical restictions are.
16667 * Misc/WebNSURLExtras.mm:
16668 (allCharactersAllowedByTLDRules):
16669 (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
16671 2010-05-12 Simon Fraser <simon.fraser@apple.com>
16673 Reviewed by David Hyatt.
16675 Composited plug-ins can cause missed painting
16676 https://bugs.webkit.org/show_bug.cgi?id=39033
16677 <rdar://problem/7972478>
16679 Eagerly enable compositing mode via the enclosing FrameView when the plug-in tells us it wants
16682 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
16683 (-[WebHostedNetscapePluginView createPlugin]):
16684 * Plugins/WebNetscapePluginView.mm:
16685 (-[WebNetscapePluginView createPlugin]):
16687 2010-05-12 Jer Noble <jer.noble@apple.com>
16689 Reviewed by Darin Adler.
16691 Bug 38689: #34005 will break fullscreen video playback
16692 https://bugs.webkit.org/show_bug.cgi?id=38689
16694 Use the new definition of PlatformMedia to check the actual type
16695 returned by MediaPlayer.
16697 * WebView/WebVideoFullscreenController.mm:
16698 (-[WebVideoFullscreenController windowDidLoad]):
16700 2010-05-11 Mark Rowe <mrowe@apple.com>
16704 In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
16705 The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
16706 that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
16707 in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
16708 and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
16709 function in WebCore being called.
16711 We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
16712 other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
16715 * Configurations/FeatureDefines.xcconfig:
16717 2010-05-10 Simon Fraser <simon.fraser@apple.com>
16719 Reviewed by Anders Carlsson.
16721 Allow compositing layers to be connected across iframe boundaries on Mac
16722 https://bugs.webkit.org/show_bug.cgi?id=38856
16724 When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers"
16725 flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused
16726 content to show up in both compositing layers, and the painted background inside the iframe.
16728 Fix by taking the flattening state from the parent frame, if there is one. For the root
16729 frame, we continue to look to see if we're painting into a bitmap.
16731 * WebView/WebFrame.mm:
16732 (-[WebFrame _drawRect:contentsOnly:]):
16734 2010-05-10 Timothy Hatcher <timothy@apple.com>
16736 Fix a crash when closing a WebView while the Web Inspector is open.
16738 <rdar://problem/7966830>
16740 Reviewed by Mark Rowe.
16742 * WebCoreSupport/WebInspectorClient.mm:
16743 (-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.
16744 * WebView/WebView.mm:
16745 (-[WebView _close]): Null out _private->page before deleting the page, so code called
16746 during destruction don't access a half deleted Page object.
16748 2010-05-10 Anders Carlsson <andersca@apple.com>
16750 Unbreak the world. (Fix Mac builds).
16752 * Plugins/Hosted/WebKitPluginHostTypes.h:
16754 2010-05-10 Anders Carlsson <andersca@apple.com>
16756 Reviewed by Simon Fraser.
16758 Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
16759 use accelerated compositing and not layer backed views.
16761 * Plugins/Hosted/WebKitPluginHostTypes.h:
16763 2010-05-07 Anders Carlsson <andersca@apple.com>
16765 Reviewed by Sam Weinig and Simon Fraser.
16767 <rdar://problem/7947356>
16768 QT Plug-in in hardware-accelerated WebKit is missing the controller
16770 Replace the useSoftwareRenderer boolean with an enum that lets the plug-in host opt into using a layer
16771 backed NSView instead of inserting the layer into the WebCore layer hierarchy.
16773 * Plugins/Hosted/NetscapePluginHostManager.mm:
16774 (WebKit::NetscapePluginHostManager::instantiatePlugin):
16775 * Plugins/Hosted/NetscapePluginHostProxy.mm:
16776 (WKPCInstantiatePluginReply):
16777 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
16778 (WebKit::NetscapePluginInstanceProxy::rendererType):
16779 (WebKit::NetscapePluginInstanceProxy::setRendererType):
16780 (WebKit::NetscapePluginInstanceProxy::InstantiatePluginReply::InstantiatePluginReply):
16781 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
16782 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
16783 Replace the useSoftwareRenderer boolean everywhere with the RendererType enum.
16785 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
16786 (-[WebHostedNetscapePluginView createPlugin]):
16787 Only go into full compositing mode when the renderer type returned is UseAcceleratedCompositing.
16788 Otherwise, use a layer backed NSView.
16790 * Plugins/Hosted/WebKitPluginHostTypes.h:
16791 Add a RendererType enum.
16793 2010-05-06 Anders Carlsson <andersca@apple.com>
16795 Reviewed by Darin Adler and Dan Bernstein..
16797 REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
16798 https://bugs.webkit.org/show_bug.cgi?id=38698
16799 <rdar://problem/7942075>
16801 When the plug-in database is initialized, we will register all the MIME types it supports with the global
16802 WebView dictionary. When plug-ins are disabled for a single web view, the MIME types still need to be
16803 in the global mapping (because other web views might still have plug-ins enabled).
16805 Prior to r51617 we would always look at the plug-in database to determine that the MIME type belongs to a
16806 plug-in, but now we won't even touch the plug-in database when plug-ins are disabled.
16808 In order to fix this, a new set of registered MIME types that are known to be plug-ins is added. When
16809 +[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:] is called and allowingPlugins is FALSE
16810 we check if the MIME type is a known plug-in MIME type and return false in that case.
16812 * Plugins/WebPluginDatabase.mm:
16813 (-[WebPluginDatabase refresh]):
16814 (-[WebPluginDatabase _removePlugin:]):
16815 * WebView/WebView.mm:
16816 (knownPluginMIMETypes):
16817 (+[WebView _registerPluginMIMEType:]):
16818 (+[WebView _unregisterPluginMIMEType:]):
16819 (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
16820 * WebView/WebViewInternal.h:
16822 2010-05-06 Dan Bernstein <mitz@apple.com>
16824 Reviewed by Simon Fraser.
16826 <rdar://problem/7951285> REGRESSION (r58847): Composited iframe content obscures Safari's application chrome
16828 Fixed this other regression from r58847. The regression was caused by overriding -visibleRect to
16829 return the WebClipView’s full bounds. AppKit uses -visibleRect to determine the geometry
16830 of the surface for the child WebFrameView. The fix is to restrict the special behavior of
16831 -[WebClipView visibleRect] to when AppKit is consulting it for the purpose of invalidating
16832 areas while scrolling.
16834 * WebView/WebClipView.h:
16835 * WebView/WebClipView.mm:
16836 (-[WebClipView visibleRect]): If the WebClipView is not scrolling, always return
16837 [super visibleRect].
16838 (-[WebClipView _immediateScrollToPoint:]): Override this internal NSClipView method
16839 to set a flag telling -visibleRect that the view is scrolling.
16840 * WebView/WebView.mm:
16841 (layerSyncRunLoopObserverCallBack): Ensure that screen updates, disabled by AppKit
16842 when it thinks an upcoming window flush will re-enable them, are enabled here in
16843 case the -setNeedsDisplayInRect: override has prevented the window from needing to be
16846 2010-05-06 Steve Block <steveblock@google.com>
16848 Reviewed by Eric Seidel.
16850 MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
16851 https://bugs.webkit.org/show_bug.cgi?id=38544
16853 * WebCoreSupport/WebFrameLoaderClient.h:
16854 * WebCoreSupport/WebFrameLoaderClient.mm:
16856 2010-05-05 Dan Bernstein <mitz@apple.com>
16858 Reviewed by Mark Rowe.
16860 Fixed a crash when closing Top Sites after r58847.
16862 * WebView/WebFrameView.mm:
16863 (-[WebFrameView webFrame]): Null-check _private.
16865 2010-05-05 Dan Bernstein <mitz@apple.com>
16867 Rubber-stamped by Mark Rowe.
16869 Fixed test crashes after r58847.
16871 * WebView/WebHTMLView.mm:
16872 (setNeedsDisplayInRect): Null-check the frame.
16874 2010-05-05 Dan Bernstein <mitz@apple.com>
16876 Reviewed by Simon Fraser.
16878 <rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
16879 https://bugs.webkit.org/show_bug.cgi?id=38427
16881 * WebView/WebClipView.m: Renamed to WebClipView.mm.
16882 * WebView/WebClipView.mm:
16883 (-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in
16884 composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to
16885 AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy.
16886 Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping.
16887 * WebView/WebHTMLView.mm:
16888 (setCursor): Style tweak.
16889 (setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:],
16890 so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation
16891 is routed back through the WebCore FrameView, which propagates it to the layer.
16892 (+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in.
16893 (-[WebHTMLView visibleRect]): Removed whitespace.
16894 * WebView/WebView.mm:
16895 (layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout
16896 in preparation for the displaying of compositing layers.
16898 2010-05-05 John Sullivan <sullivan@apple.com>
16900 <rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened
16902 Reviewed by Mark Rowe.
16904 * WebView/WebView.mm:
16905 (+[WebView closeAllWebViews]):
16906 Make copy of allWebViewsSet to avoid mutating it while iterating through it.
16908 2010-05-04 Simon Fraser <simon.fraser@apple.com>
16910 Reviewed by Dan Bernstein.
16912 Improve check for drawing into the window that was added in r58623
16913 https://bugs.webkit.org/show_bug.cgi?id=38562
16915 Rather than assuming that any non-bitmap context is the window's context,
16916 compare the current graphics context with -[NSWindow graphicsContext] to
16917 determine that we're drawing into the window.
16919 * WebView/WebHTMLView.mm:
16920 (-[WebHTMLView drawRect:]):
16922 2010-05-04 Ada Chan <adachan@apple.com>
16924 Reviewed by David Kilzer.
16926 https://bugs.webkit.org/show_bug.cgi?id=38555
16928 Small code refactoring: move the logic to figure out the path to the
16929 databases directory to another method.
16931 * Storage/WebDatabaseManager.mm:
16932 (databasesDirectoryPath):
16933 (WebKitInitializeDatabasesIfNecessary):
16935 2010-05-04 Beth Dakin <bdakin@apple.com>
16937 Reviewed by Mike Thole.
16939 Fix for <rdar://problem/7818509> Crash occurs when exiting Safari
16941 We can avoid this crash if we call [self _removeFromAllWebViewsSet]
16942 even in the case when we are doing a fastDocumentTeardown. This is
16943 a much safer approach.
16944 * WebView/WebView.mm:
16945 (-[WebView _close]):
16947 2010-05-03 Abhishek Arya <inferno@chromium.org>
16949 Reviewed by Adam Barth.
16951 Add support for controlling clipboard access from javascript.
16952 Clipboard access from javascript is disabled by default.
16953 https://bugs.webkit.org/show_bug.cgi?id=27751
16955 * WebView/WebPreferenceKeysPrivate.h:
16956 * WebView/WebPreferences.mm:
16957 (+[WebPreferences initialize]):
16958 (-[WebPreferences javaScriptCanAccessClipboard]):
16959 (-[WebPreferences setJavaScriptCanAccessClipboard:]):
16960 * WebView/WebPreferencesPrivate.h:
16961 * WebView/WebView.mm:
16962 (-[WebView _preferencesChangedNotification:]):
16964 2010-05-03 Jens Alfke <snej@chromium.org>
16966 Reviewed by Darin Fisher.
16968 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
16969 https://bugs.webkit.org/show_bug.cgi?id=38397
16971 No tests (functionality is exposed only through native WebKit API.)
16973 * WebCoreSupport/WebFrameLoaderClient.h:
16974 (WebFrameLoaderClient::dispatchWillSendSubmitEvent):
16976 2010-04-30 Simon Fraser <simon.fraser@apple.com>
16978 Reviewed by Dan Bernstein.
16980 <rdar://problem/7477071> REGRESSION: Bad flicker when wheel-scrolling Google Maps, iPad gallery and other sites
16982 Sites that frequently toggle content in and out of compositing layers (like http://www.tumblr.com/boothed)
16983 can cause flickering because of unsychronized compositing layer and view-based updates. There were two
16986 1. On SnowLeopard, AppKit can throttle window updates, thus breaking an assumption that
16987 NSView drawing will happen on the runloop cycle after a repaint. This provided a window
16988 for the layerSyncRunLoopObserver to fire and commit layer changes too early.
16990 Fix this by having the layerSyncRunLoopObserver in WebView check to see if a display is pending,
16991 and not commit layer changes in that case. We'll commit layer changes later when we
16994 2. The change in r49269 was wrong; it was attempting to fix an issue that was actually caused
16995 by -drawRects: coming in for page snapshots. The correct approach is to avoid hitting the
16996 synchronization and update disabling code in WebHTMLView for draws that are not to the screen.
16998 * WebView/WebHTMLView.mm:
16999 (-[WebHTMLView drawRect:]):
17000 * WebView/WebView.mm:
17001 (layerSyncRunLoopObserverCallBack):
17002 (-[WebView _scheduleCompositingLayerSync]):
17004 2010-04-30 Anders Carlsson <andersca@apple.com>
17006 Part of the previous part (forgot to save).
17008 * Plugins/WebNetscapePluginView.mm:
17009 (-[WebNetscapePluginView stopTimers]):
17010 (-[WebNetscapePluginView startTimers]):
17011 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
17012 (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
17013 (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]):
17014 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
17015 (-[WebNetscapePluginView unscheduleTimer:]):
17016 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
17017 (-[WebNetscapePluginView setVariable:forURL:value:length:]):
17019 2010-04-30 Anders Carlsson <andersca@apple.com>
17021 Reviewed by Darin Adler.
17023 Use C99 integer types in more places.
17025 * Plugins/WebNetscapePluginView.mm:
17028 2010-04-30 Anders Carlsson <andersca@apple.com>
17032 * Plugins/WebBaseNetscapePluginStream.h:
17033 * Plugins/WebBaseNetscapePluginStream.mm:
17034 (WebNetscapePluginStream::startStream):
17036 2010-04-30 Anders Carlsson <andersca@apple.com>
17038 Another 32-bit build fix.
17040 * Plugins/WebNetscapePluginView.mm:
17041 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
17043 2010-04-30 Anders Carlsson <andersca@apple.com>
17045 Fix 32-bit build (again).
17047 * Plugins/WebNetscapeContainerCheckContextInfo.h:
17048 * Plugins/WebNetscapeContainerCheckContextInfo.mm:
17049 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
17050 (-[WebNetscapeContainerCheckContextInfo checkRequestID]):
17051 (-[WebNetscapeContainerCheckContextInfo callback]):
17052 * Plugins/WebNetscapePluginPackage.h:
17054 2010-04-30 Anders Carlsson <andersca@apple.com>
17058 * Plugins/WebNetscapeContainerCheckContextInfo.h:
17059 * Plugins/WebNetscapeContainerCheckContextInfo.mm:
17060 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
17061 * Plugins/WebNetscapeContainerCheckPrivate.h:
17062 * Plugins/WebNetscapePluginPackage.mm:
17063 (functionPointerForTVector):
17064 * Plugins/WebNetscapePluginView.mm:
17065 (PluginTimer::PluginTimer):
17066 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
17067 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
17069 2010-04-30 Anders Carlsson <andersca@apple.com>
17071 Reviewed by Timothy Hatcher.
17073 Next step towards fixing
17075 https://bugs.webkit.org/show_bug.cgi?id=20784
17076 move npapi.h to C99 integer types
17078 Use the C99 types everywhere. The "old" types are still around but will be removed
17079 in a subsequent commit.
17081 * Plugins/WebBaseNetscapePluginStream.h:
17082 * Plugins/WebBaseNetscapePluginStream.mm:
17083 (WebNetscapePluginStream::deliverData):
17084 * Plugins/WebNetscapePluginView.h:
17085 * Plugins/WebNetscapePluginView.mm:
17086 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
17087 (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]):
17088 * Plugins/npapi.mm:
17091 (NPN_PostURLNotify):
17094 (NPN_ScheduleTimer):
17095 (NPN_UnscheduleTimer):
17096 (NPN_GetValueForURL):
17097 (NPN_SetValueForURL):
17098 (NPN_GetAuthenticationInfo):
17099 (WKN_CheckIfAllowedToLoadURL):
17100 (WKN_CancelCheckIfAllowedToLoadURL):
17102 2010-04-29 Anders Carlsson <andersca@apple.com>
17104 Reviewed by Dan Bernstein.
17107 https://bugs.webkit.org/show_bug.cgi?id=20784
17108 move npapi.h to C99 integer types.
17110 * MigrateHeaders.make:
17112 2010-04-28 Mike Thole <mthole@apple.com>
17114 Reviewed by David Kilzer.
17116 Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
17117 can be inspected before attempting to authenticate against it
17118 https://bugs.webkit.org/show_bug.cgi?id=38271
17120 * WebCoreSupport/WebFrameLoaderClient.h:
17121 * WebCoreSupport/WebFrameLoaderClient.mm:
17122 (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
17123 Added. If the resource load delegate implements the callback, use its answer. If it does
17124 not, then only send authentication challenges for pre-10.6 protection spaces, which matches
17125 CFNetwork's default behavior.
17126 * WebView/WebDelegateImplementationCaching.h:
17127 * WebView/WebDelegateImplementationCaching.mm:
17128 (CallResourceLoadDelegateReturningBoolean): Added case for passing three objects.
17129 * WebView/WebResourceLoadDelegatePrivate.h:
17130 Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:
17131 * WebView/WebView.mm:
17132 (-[WebView _cacheResourceLoadDelegateImplementations]):
17134 2010-04-28 Simon Fraser <simon.fraser@apple.com>
17136 Reviewed by Sam Weinig.
17138 <rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing()
17140 Ensure that the WebView +initialize method initializes threading, so that things are correctly
17141 initialized when the first call into the WebKit framework is via a WebView class method.
17143 * WebView/WebView.mm:
17144 (+[WebView initialize]):
17146 2010-04-28 Darin Adler <darin@apple.com>
17148 Reviewed by Adele Peterson.
17150 REGRESSION: Autoscroll does not work in Mail messages
17151 https://bugs.webkit.org/show_bug.cgi?id=38267
17152 rdar://problem/7559799
17154 The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
17155 view had gotten broken in multiple ways. For some reason, a combination of bugs made it
17156 partly work until around r48064. This brings it back.
17158 * WebCoreSupport/WebChromeClient.mm:
17159 (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view
17160 rather than the WebView itself. This logic may not be correct for the case where
17161 usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later.
17163 2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>
17165 Reviewed by Darin Adler and Eric Seidel.
17167 Add layoutTestController.setPrinting()
17168 https://bugs.webkit.org/show_bug.cgi?id=37203
17170 * Misc/WebCoreStatistics.h:
17171 * Misc/WebCoreStatistics.mm:
17172 (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):
17174 2010-04-25 Sam Weinig <sam@webkit.org>
17176 Reviewed by Maciej Stachowiak.
17178 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
17179 Disentangle initializing the main thread from initializing threading
17181 Calls initializeMainThreadToProcessMainThread since there is no way to ensure
17182 that the initialize method will be called on the main thread.
17184 * Carbon/CarbonWindowAdapter.mm:
17185 (+[CarbonWindowAdapter initialize]): Add call to initializeMainThreadToProcessMainThread.
17186 * History/WebBackForwardList.mm:
17187 (+[WebBackForwardList initialize]): Ditto.
17188 * History/WebHistoryItem.mm:
17189 (+[WebHistoryItem initialize]): Ditto.
17190 * Misc/WebElementDictionary.mm:
17191 (+[WebElementDictionary initialize]): Ditto.
17192 * Misc/WebIconDatabase.mm:
17193 (+[WebIconDatabase initialize]): Ditto.
17194 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
17195 (+[WebHostedNetscapePluginView initialize]): Ditto.
17196 * Plugins/WebBaseNetscapePluginView.mm:
17197 (+[WebBaseNetscapePluginView initialize]): Ditto.
17198 * Plugins/WebBasePluginPackage.mm:
17199 (+[WebBasePluginPackage initialize]): Ditto.
17200 * Plugins/WebNetscapePluginView.mm:
17201 (+[WebNetscapePluginView initialize]): Ditto.
17202 * WebCoreSupport/WebEditorClient.mm:
17203 (+[WebEditCommand initialize]): Ditto.
17204 * WebCoreSupport/WebFrameLoaderClient.mm:
17205 (+[WebFramePolicyListener initialize]): Ditto.
17206 * WebView/WebArchive.mm:
17207 (+[WebArchivePrivate initialize]): Ditto.
17208 * WebView/WebDataSource.mm:
17209 (+[WebDataSourcePrivate initialize]): Ditto.
17210 * WebView/WebHTMLView.mm:
17211 (+[WebHTMLViewPrivate initialize]): Ditto.
17212 (+[WebHTMLView initialize]): Ditto.
17213 * WebView/WebResource.mm:
17214 (+[WebResourcePrivate initialize]): Ditto.
17215 * WebView/WebTextIterator.mm:
17216 (+[WebTextIteratorPrivate initialize]): Ditto.
17217 * WebView/WebView.mm:
17218 * WebView/WebViewData.mm: Ditto.
17219 (+[WebViewPrivate initialize]): Ditto.
17221 2010-04-24 Dan Bernstein <mitz@apple.com>
17223 Reviewed by Darin Adler.
17225 <rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME types
17226 https://bugs.webkit.org/show_bug.cgi?id=38085
17228 WebView was calling -_webView in a few places where it should have just used itself. It never
17229 makes sense for WebView to call -_webView on itself, and these calls look like they were copied
17230 from similar code in WebHTMLView, WebFrameView and WebDataSource, where -_webView has a different,
17233 * WebView/WebView.mm:
17234 (-[WebView drawSingleRect:]): Replaced [self _webView] with self.
17235 (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Replaced [[self _webView] preferences]
17236 with _private->preferences.
17237 (-[WebView _canShowMIMEType:]): Ditto.
17239 2010-04-23 Simon Fraser <simon.fraser@apple.com>
17241 Reviewed by Anders Carlsson.
17243 <rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint
17245 When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling
17246 NPPrint with a GWorldPtr, since Flash prefers the CGContext path.
17248 * Plugins/WebNetscapePluginView.mm:
17249 (-[WebNetscapePluginView drawRect:]):
17251 2010-04-22 David Kilzer <ddkilzer@apple.com>
17253 <http://webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call to JSC::initializeThreading()
17255 Reviewed by Timothy Hatcher.
17257 Every other Objective-C class that calls
17258 WebCoreObjCFinalizeOnMainThread(self) in +initialize also calls
17259 JSC::initializeThreading(). The WebTextIteratorPrivate class
17260 was the only one missing this call.
17262 * WebView/WebTextIterator.mm:
17263 (+[WebTextIteratorPrivate initialize]): Added call to
17264 JSC::initializeThreading().
17266 2010-04-22 Alexey Proskuryakov <ap@apple.com>
17268 Rubber-stamped by Mark Rowe.
17270 <rdar://problem/7805969> REGRESSION: iTunes unable to play trailers
17272 Undo the changes made for https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>)
17273 for now. Clients rely on the old behavior, so a fix that changes it will need to account for
17276 * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL
17277 instead of baseURL again.
17279 2010-04-22 Dave Moore <davemoore@chromium.org>
17281 Reviewed by Dimitri Glazkov.
17283 Added notification when the favicons for a page are changed
17285 The Document object will notify the frame loader, which will
17286 notify the client. Implementations of FrameLoaderClient will
17287 have to add one method; dispatchDidChangeIcons().
17289 https://bugs.webkit.org/show_bug.cgi?id=33812
17291 * WebCoreSupport/WebFrameLoaderClient.h:
17292 * WebCoreSupport/WebFrameLoaderClient.mm:
17293 (WebFrameLoaderClient::dispatchDidChangeIcons):
17295 2010-04-22 Adam Barth <abarth@webkit.org>
17297 Unreviewed, rolling out r58069.
17298 http://trac.webkit.org/changeset/58069
17299 https://bugs.webkit.org/show_bug.cgi?id=27751
17301 Broke compile on Windows.
17303 * WebView/WebPreferenceKeysPrivate.h:
17304 * WebView/WebPreferences.mm:
17305 (+[WebPreferences initialize]):
17306 * WebView/WebPreferencesPrivate.h:
17307 * WebView/WebView.mm:
17308 (-[WebView _preferencesChangedNotification:]):
17310 2010-04-22 Abhishek Arya <inferno@chromium.org>
17312 Reviewed by Adam Barth.
17314 Add support for controlling clipboard access from javascript.
17315 Clipboard access from javascript is disabled by default.
17316 https://bugs.webkit.org/show_bug.cgi?id=27751
17318 * WebView/WebPreferenceKeysPrivate.h:
17319 * WebView/WebPreferences.mm:
17320 (+[WebPreferences initialize]):
17321 (-[WebPreferences javaScriptCanAccessClipboard]):
17322 (-[WebPreferences setJavaScriptCanAccessClipboard:]):
17323 * WebView/WebPreferencesPrivate.h:
17324 * WebView/WebView.mm:
17325 (-[WebView _preferencesChangedNotification:]):
17327 2010-04-21 Alexey Proskuryakov <ap@apple.com>
17329 Reviewed by Shinichiro Hamaji.
17331 https://bugs.webkit.org/show_bug.cgi?id=37964
17332 Fix a typo in comments - Korean encoding name is windows-949, not windows-939
17334 * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
17336 2010-04-21 Mark Rowe <mrowe@apple.com>
17340 * Plugins/WebPluginController.mm: Add an #import that is necessary on Tiger.
17342 2010-04-21 Mark Rowe <mrowe@apple.com>
17344 Reviewed by Eric Carlson.
17346 <rdar://problem/7313430> Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:]
17348 Existing versions of the Flip4Mac WebKit plug-in have an object lifetime bug related to an NSAlert that is
17349 used to notify the user about updates to the plug-in. This bug can result in Safari crashing if the page
17350 containing the plug-in navigates while the alert is displayed (<rdar://problem/7313430>).
17352 The gist of the bug is thus: Flip4Mac sets an instance of the TSUpdateCheck class as the modal delegate of the
17353 NSAlert instance. This TSUpdateCheck instance itself has a delegate. The delegate is set to the WmvPlugin
17354 instance which is the NSView subclass that is exposed to WebKit as the plug-in view. Since this relationship
17355 is that of delegates the TSUpdateCheck does not retain the WmvPlugin. This leads to a bug if the WmvPlugin
17356 instance is destroyed before the TSUpdateCheck instance as the TSUpdateCheck instance will be left with a
17357 pointer to a stale object. This will happen if a page containing the Flip4Mac plug-in triggers a navigation
17358 while the update sheet is visible as the WmvPlugin instance is removed from the view hierarchy and there are
17359 no other references to keep the object alive.
17361 We work around this bug by patching the following two messages:
17363 1) -[NSAlert beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:]
17364 2) -[TSUpdateCheck alertDidEnd:returnCode:contextInfo:]
17366 Our override of 1) detects whether it is Flip4Mac's update sheet triggering the alert by checking whether the
17367 modal delegate is an instance of TSUpdateCheck. If it is, it retains the modal delegate's delegate.
17369 Our override of 2) then autoreleases the delegate, balancing the retain we added in 1).
17371 These two overrides have the effect of ensuring that the WmvPlugin instance will always outlive the TSUpdateCheck
17372 instance, preventing the TSUpdateCheck instance from accessing a stale delegate pointer and crashing the application.
17374 * Plugins/WebPluginController.mm:
17375 (-[WebPluginController addPlugin:]): Check whether the plug-in being instantiated is the Flip4Mac plug-in and
17376 install our workaround if it is.
17377 (isKindOfClass): Helper function that checks whether the given object is an instance of the named class.
17378 (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_): Autorelease the delegate.
17379 (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_): Retain the modal delegate's
17380 delegate if this NSAlert belongs to the Flip4Mac plug-in.
17381 (installFlip4MacPlugInWorkaroundIfNecessary): Swizzle the necessary methods. We swizzle the TSUpdateCheck methods
17382 first since it is possible that in some versions of Flip4Mac the TSUpdateCheck class may not exist or may not have
17383 the method we're interested in. In that case we want to bail out before patching any methods.
17385 2010-04-20 Mark Rowe <mrowe@apple.com>
17387 Reviewed by Maciej Stachowiak.
17389 <rdar://problem/7856151> REGRESSION: NPP_Destroy is not called when page navigates when plug-in is displaying modal dialog
17391 An interaction between the plug-in host and WebKit was resulting in WKPCSetModal being called while
17392 NetscapePluginInstanceProxy was waiting on a reply to the GetScriptableNPObject message. This resulted
17393 in calls to stop the plug-in being deferred due to the presence of plug-in code up the stack. This
17394 could lead to crashes as it was possible for the plug-in view to be deallocated during the modal runloop.
17396 * Plugins/Hosted/NetscapePluginHostProxy.mm:
17397 (WKPCInvalidateRect):
17398 (WKPCSetModal): Defer the handling of setModal until the next runloop iteration if the host proxy
17399 is already processing requests. This ensures that there will be no plug-in code on the stack when
17400 the modal runloop is entered, which allows the plug-in to be stopped when the page is navigated while
17401 a modal dialog is displayed.
17403 2010-04-20 Adam Barth <abarth@webkit.org>
17405 Reviewed by Eric Seidel.
17407 Factor DocumentWriter out of FrameLoader
17408 https://bugs.webkit.org/show_bug.cgi?id=37175
17410 Update these callsites because the method moved to DocumentWriter.
17412 * WebView/WebFrame.mm:
17413 (-[WebFrame _canProvideDocumentSource]):
17414 (-[WebFrame _receivedData:textEncodingName:]):
17416 2010-04-20 Kent Tamura <tkent@chromium.org>
17418 Reviewed by Darin Adler.
17420 Change a parameter type of chooseIconForFiles()
17421 https://bugs.webkit.org/show_bug.cgi?id=37504
17423 * WebCoreSupport/WebChromeClient.h:
17424 * WebCoreSupport/WebChromeClient.mm:
17425 (WebChromeClient::chooseIconForFiles):
17427 2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
17429 Unreviewed, rolling out r57892.
17430 http://trac.webkit.org/changeset/57892
17431 https://bugs.webkit.org/show_bug.cgi?id=37864
17433 Caused an assertion in Mac builds (Requested by smfr on
17436 * WebView/WebFrame.mm:
17437 (-[WebFrame _getVisibleRect:]):
17438 * WebView/WebFrameView.mm:
17439 (-[WebFrameView _install]):
17441 2010-04-20 Simon Fraser <simon.fraser@apple.com>
17443 Reviewed by Dan Bernstein.
17445 Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
17446 https://bugs.webkit.org/show_bug.cgi?id=37741
17448 Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
17449 RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().
17451 * WebView/WebFrame.mm:
17452 (-[WebFrame _getVisibleRect:]):
17453 * WebView/WebFrameView.mm:
17454 (-[WebFrameView _install]):
17456 2010-04-19 Dan Bernstein <mitz@apple.com>
17458 Reviewed by Sam Weinig.
17460 Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
17461 printing width as SPI.
17463 * WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.
17465 2010-04-15 Gavin Barraclough <barraclough@apple.com>
17467 Reviewed by Sam Weinig & Oliver Hunt.
17469 https://bugs.webkit.org/show_bug.cgi?id=37675
17470 Remove casts/constructors to/from JSC::UString type from WebCore::String
17472 WebCore's strings should not know about JSC::UString, this should be abstracted
17473 away in the bindings. Add explicit conversion methods rather than relying on
17474 overloaded cast operators / constructors being implicitly called.
17476 This patch only changes the class String, once this has landed StringImpl, and
17477 hopefully AtomicString too, should follow suit.
17479 * Plugins/Hosted/NetscapePluginHostProxy.mm:
17480 (identifierFromIdentifierRep):
17481 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
17482 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
17483 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
17484 * Plugins/Hosted/ProxyInstance.mm:
17485 (WebKit::ProxyInstance::getPropertyNames):
17486 * WebView/WebFrame.mm:
17487 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
17488 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
17489 * WebView/WebScriptDebugDelegate.mm:
17490 (-[WebScriptCallFrame evaluateWebScript:]):
17491 * WebView/WebScriptDebugger.mm:
17493 * WebView/WebView.mm:
17494 (aeDescFromJSValue):
17496 2010-04-16 Dan Bernstein <mitz@apple.com>
17498 Reviewed by John Sullivan.
17500 Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
17501 printing width as SPI.
17503 * WebView/WebHTMLView.mm:
17504 Replaced two macros with constants.
17505 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
17506 (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
17507 * WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and
17508 _WebHTMLViewPrintingMaximumShrinkFactor.
17510 2010-04-15 Mark Rowe <mrowe@apple.com>
17512 Reviewed by Sam Weinig.
17514 <rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors when included in plain Objective-C files.
17516 * WebView/WebDynamicScrollBarsView.h:
17518 2010-04-15 Adam Roben <aroben@apple.com>
17520 Export WebUserContentURLPattern from WebKit
17522 Rubber-stamped by Mark Rowe.
17526 2010-04-15 Dan Bernstein <mitz@apple.com>
17528 Reviewed by Simon Fraser.
17530 Made consecutive calls to -[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:] work
17531 without intermediate calls -[WebHTMLView _endPrintMode].
17533 * WebView/WebHTMLView.mm:
17534 (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
17536 2010-04-15 Adam Roben <aroben@apple.com>
17538 Expose UserContentURLPattern as WebKit SPI
17540 Fixes <http://webkit.org/b/37354>.
17542 Reviewed by Tim Hatcher.
17544 * Misc/WebUserContentURLPattern.h: Added.
17546 * Misc/WebUserContentURLPattern.mm: Added.
17547 (-[WebUserContentURLPattern initWithPatternString:]): Initialize
17548 _private and then parse the passed-in string into a
17549 UserContentURLPattern.
17550 (-[WebUserContentURLPattern dealloc]): Release _private.
17552 (-[WebUserContentURLPattern isValid]):
17553 (-[WebUserContentURLPattern scheme]):
17554 (-[WebUserContentURLPattern host]):
17555 (-[WebUserContentURLPattern matchesSubdomains]):
17556 Call through to UserContentURLPattern.
17558 2010-04-13 Geoffrey Garen <ggaren@apple.com>
17560 Reviewed by Oliver Hunt.
17562 Separated a DOMWrapperWorld's behavior of keeping wrappers alive from
17563 its own lifetime, so a DOMWrapperWorld's controller can throw away
17564 its wrappers even before its refcount reaches 0.
17566 * WebView/WebScriptWorld.h:
17567 * WebView/WebScriptWorld.mm:
17568 (-[WebScriptWorld unregisterWorld]): Exported this function through WebKit.
17570 2010-04-12 Timothy Hatcher <timothy@apple.com>
17572 SecurityOrigin needs a way to remove individual OriginAccessEntries
17573 https://bugs.webkit.org/show_bug.cgi?id=37449
17575 Reviewed by Dave Hyatt.
17577 * WebView/WebView.mm:
17578 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
17579 Call SecurityOrigin::removeOriginAccessWhitelistEntry.
17580 * WebView/WebViewPrivate.h: Added _removeOriginAccessWhitelistEntryWithSourceOrigin.
17582 2010-04-13 Timothy Hatcher <timothy@apple.com>
17584 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
17585 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
17587 SecurityOrigin needs a way to remove individual OriginAccessEntries
17588 https://bugs.webkit.org/show_bug.cgi?id=37449
17590 Reviewed by Dave Hyatt.
17592 * WebView/WebView.mm:
17593 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
17594 (+[WebView _resetOriginAccessWhitelists]):
17595 * WebView/WebViewPrivate.h:
17597 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
17599 Unreviewed, rolling out r57468.
17600 http://trac.webkit.org/changeset/57468
17601 https://bugs.webkit.org/show_bug.cgi?id=37433
17603 Broke the world... Must have applied the patch wrong
17604 (Requested by abarth on #webkit).
17606 * WebView/WebFrame.mm:
17607 (-[WebFrame _canProvideDocumentSource]):
17608 (-[WebFrame _receivedData:textEncodingName:]):
17610 2010-04-11 Adam Barth <abarth@webkit.org>
17612 Reviewed by Eric Seidel.
17614 Factor DocumentWriter out of FrameLoader
17615 https://bugs.webkit.org/show_bug.cgi?id=37175
17617 Update these callsites because the method moved to DocumentWriter.
17619 * WebView/WebFrame.mm:
17620 (-[WebFrame _canProvideDocumentSource]):
17621 (-[WebFrame _receivedData:textEncodingName:]):
17623 2010-04-10 Mark Rowe <mrowe@apple.com>
17625 Reviewed by Dan Bernstein.
17627 <rdar://problem/7845305> Further adoption of formal protocols for delegates.
17629 Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places.
17631 * Misc/EmptyProtocolDefinitions.h: Removed.
17632 * Misc/WebDownload.mm:
17635 2010-04-09 Jer Noble <jer.noble@apple.com>
17637 Reviewed by Darin Adler.
17639 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
17640 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
17642 * WebView/WebVideoFullscreenController.mm:
17643 (-[WebVideoFullscreenController windowDidLoad]):
17644 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
17646 2010-04-09 Alexey Proskuryakov <ap@apple.com>
17648 Reviewed by Maciej Stachowiak.
17650 https://bugs.webkit.org/show_bug.cgi?id=24572
17651 XMLHttpRequest.statusText returns always "OK" on Mac
17653 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
17655 2010-04-09 Eric Seidel <eric@webkit.org>
17657 Unreviewed, rolling out r57343.
17658 http://trac.webkit.org/changeset/57343
17659 https://bugs.webkit.org/show_bug.cgi?id=37311
17661 Broke Tiger compile.
17663 * WebView/WebVideoFullscreenController.mm:
17664 (-[WebVideoFullscreenController windowDidLoad]):
17665 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
17667 2010-04-09 Dan Bernstein <mitz@apple.com>
17669 Reviewed by Darin Adler.
17671 <rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window
17673 * WebView/WebDynamicScrollBarsView.mm:
17674 (-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private.
17676 2010-04-09 Jer Noble <jer.noble@apple.com>
17678 Reviewed by Darin Adler.
17680 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
17681 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
17683 * WebView/WebVideoFullscreenController.mm:
17684 (-[WebVideoFullscreenController windowDidLoad]):
17685 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
17687 2010-04-08 Mark Rowe <mrowe@apple.com>
17689 Reviewed by John Sullivan.
17691 <rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]
17693 In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
17694 This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
17695 size and layout of their subclasses is baked in at compile time. This results in instances
17696 being allocated that are smaller than the new code expects, and may result in the new instance
17697 variables sharing the same memory space as any instance variables that the subclass defines.
17699 We can avoid this problem by having the class contain only a single member that acts as a pointer
17700 to a heap-allocated structure that acts as storage for the real instance variables. This makes
17701 us free to add instance variables in the future without risk of changing the size of the class.
17702 To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
17703 are able to run against older versions of WebKit we pad the class out to its previous size. This
17704 results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
17705 with both versions of the code.
17707 This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
17708 instance variables of its superclass. However, this is a private header and no known subclasses
17709 of WebDynamicScrollBarsView access superclass instance variables in this fashion.
17711 * WebView/WebDynamicScrollBarsView.h:
17712 * WebView/WebDynamicScrollBarsView.mm:
17713 (-[WebDynamicScrollBarsView initWithFrame:]):
17714 (-[WebDynamicScrollBarsView dealloc]):
17715 (-[WebDynamicScrollBarsView finalize]):
17716 (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
17717 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
17718 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
17719 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
17720 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
17721 (-[WebDynamicScrollBarsView verticalScrollingAllowed]):
17722 (-[WebDynamicScrollBarsView contentViewFrame]):
17723 (-[WebDynamicScrollBarsView tile]):
17724 (-[WebDynamicScrollBarsView setSuppressLayout:]):
17725 (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
17726 (-[WebDynamicScrollBarsView updateScrollers]):
17727 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
17728 (-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
17729 (-[WebDynamicScrollBarsView allowsVerticalScrolling]):
17730 (-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
17731 (-[WebDynamicScrollBarsView horizontalScrollingMode]):
17732 (-[WebDynamicScrollBarsView verticalScrollingMode]):
17733 (-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
17734 (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
17735 (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
17736 (-[WebDynamicScrollBarsView setScrollingModesLocked:]):
17737 (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
17738 (-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
17739 (-[WebDynamicScrollBarsView scrollWheel:]):
17741 2010-04-07 David Hyatt <hyatt@apple.com>
17743 Reviewed by Oliver Hunt.
17745 https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS
17747 Add SPI so that layout tests can access computed style including :visited information.
17749 * WebView/WebRenderNode.mm:
17751 * WebView/WebView.mm:
17752 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
17753 * WebView/WebViewInternal.h:
17754 * WebView/WebViewPrivate.h:
17756 2010-04-07 Dan Bernstein <mitz@apple.com>
17758 Reviewed by Adele Peterson.
17760 Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
17761 https://bugs.webkit.org/show_bug.cgi?id=37246
17763 * Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
17764 * Misc/WebNSPrintOperationExtras.m:
17765 (-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
17767 (-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
17769 * WebView/WebHTMLView.mm:
17770 (-[WebHTMLView _isInPrintMode]): Added this accessor.
17771 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
17772 computes the layout widths and enters printing mode into this private method.
17773 (-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
17774 (-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
17775 (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
17777 (-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
17778 (-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
17779 -[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
17781 (-[WebHTMLView beginDocument]): Updated for rename.
17782 (-[WebHTMLView endDocument]): Ditto.
17783 * WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,
17784 -_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.
17786 2010-04-07 Andrey Kosyakov <caseq@chromium.org>
17788 Reviewed by Yury Semikhatsky.
17790 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
17791 https://bugs.webkit.org/show_bug.cgi?id=36949
17793 * WebCoreSupport/WebFrameLoaderClient.h:
17794 * WebCoreSupport/WebFrameLoaderClient.mm:
17796 2010-04-06 Dan Bernstein <mitz@apple.com>
17798 Tiger build fix after r57184.
17800 * WebView/WebHTMLViewPrivate.h:
17802 2010-04-06 Dan Bernstein <mitz@apple.com>
17804 Tiger build fix after r57184.
17806 * WebView/WebHTMLViewPrivate.h:
17808 2010-04-06 Adam Barth <abarth@webkit.org>
17812 Speculative build fix for Tiger.
17814 * WebView/WebHTMLViewPrivate.h:
17816 2010-04-06 Dan Bernstein <mitz@apple.com>
17818 Reviewed by Sam Weinig and Anders Carlsson.
17820 Expose WebHTMLView’s page breaking logic as SPI.
17822 * WebView/WebHTMLView.mm:
17823 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
17824 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:
17825 * WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:
17827 2010-04-06 Mark Rowe <mrowe@apple.com>
17829 Add an #if in order to make Tiger happy.
17831 * WebView/WebViewData.mm:
17832 (-[WebViewPrivate init]):
17834 2010-04-06 Mark Rowe <mrowe@apple.com>
17838 * WebView/WebViewData.mm:
17839 (-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.
17841 2010-04-05 Mark Rowe <mrowe@apple.com>
17843 Reviewed by Adele Peterson.
17845 Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
17846 REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI
17848 * WebView/WebHTMLView.mm:
17849 (-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
17850 manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.
17852 2010-04-05 Alexey Proskuryakov <ap@apple.com>
17854 Reviewed by Darin Adler.
17856 https://bugs.webkit.org/show_bug.cgi?id=37111
17857 <rdar://problem/7790327> Draw replacement text when plug-in host crashes
17859 * Plugins/Hosted/WebHostedNetscapePluginView.h: Removed _pluginDied - it was only used
17860 for drawing replacement icon, and this information is now in WebCore.
17861 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
17862 (-[WebHostedNetscapePluginView pluginHostDied]): Tell RenderEmbeddedObject that the plug-in
17864 (-[WebHostedNetscapePluginView drawRect:]): Removed the case for crashed plug-in host. It is
17865 handled by WebCore now.
17867 * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory crashedPluginText]): Added a string
17868 for plug-in failure.
17870 2010-04-03 yael aharon <yael.aharon@nokia.com>
17872 Reviewed by Darin Adler.
17874 Enable HTMLProgressElement for Safari on OSX
17875 https://bugs.webkit.org/show_bug.cgi?id=36961
17877 * Configurations/FeatureDefines.xcconfig:
17879 2010-04-02 Jer Noble <jer.noble@apple.com>
17881 Reviewed by Eric Carlson.
17883 https://bugs.webkit.org/show_bug.cgi?id=36624
17884 Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.
17886 * WebCoreSupport/WebSystemInterface.m:
17887 (InitWebCoreSystemInterface):
17889 2010-04-02 Alexey Proskuryakov <ap@apple.com>
17891 Reviewed by Darin Adler.
17893 https://bugs.webkit.org/show_bug.cgi?id=37043
17894 Java regression tests spam stderr about being unable to set status message
17896 With this change, there is still spam about "Attempt to access JavaScript from destroyed
17897 applet, type 9." I haven't investigated if that indicates a problem or not.
17899 * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]):
17900 Removed check for _documentView. We don't seem to care.
17902 2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
17904 Reviewed by Dmitry Titov.
17906 Add FileThread for async file operation support in FileReader and FileWriter
17907 https://bugs.webkit.org/show_bug.cgi?id=36896
17909 Add FILE_READER or FILE_WRITER feature defines.
17911 * Configurations/FeatureDefines.xcconfig:
17913 2010-04-01 Ada Chan <adachan@apple.com>
17915 Reviewed by Darin Adler.
17917 Change WebDatabaseManager::deleteOrigin() to return true if there are no errors in deleting the origin.
17918 Ditto for WebDatabaseManager::deleteDatabase().
17920 https://bugs.webkit.org/show_bug.cgi?id=36988
17922 * Storage/WebDatabaseManager.mm:
17923 (-[WebDatabaseManager deleteOrigin:]):
17924 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
17925 * Storage/WebDatabaseManagerPrivate.h:
17927 2010-04-01 Alexey Proskuryakov <ap@apple.com>
17929 Reviewed by Darin Adler.
17931 https://bugs.webkit.org/show_bug.cgi?id=36976
17932 <rdar://problem/7817498>
17933 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
17935 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
17936 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): The HashTable assertions aren't
17937 there to catch potential future attempts to store empty/deleted values before these happen -
17938 it's actually wrong to try to look up these values. Added an early return.
17939 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Ditto.
17941 2010-04-01 Chris Marrin <cmarrin@apple.com>
17943 Reviewed by Simon Fraser.
17945 Added layerTreeAsText function to DRT (for Mac)
17946 https://bugs.webkit.org/show_bug.cgi?id=36782
17948 This is the WebKit side for Mac. It plumbs the
17949 call from WebCore to DRT.
17951 * WebView/WebFrame.mm:WebKit (Mac) side of plumbing
17952 (-[WebFrame _layerTreeAsText]):
17953 * WebView/WebFramePrivate.h:
17955 2010-04-01 Alexey Proskuryakov <ap@apple.com>
17957 Reviewed by Oliver Hunt.
17959 https://bugs.webkit.org/show_bug.cgi?id=36976
17960 <rdar://problem/7817498>
17961 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
17963 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
17964 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(),
17965 because the latter fails with an assertion when looking up 0 or -1.
17966 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Be prepared for unexpected
17967 object IDs coming from plug-in host.
17969 2010-03-31 Chris Fleizach <cfleizach@apple.com>
17971 Reviewed by Darin Adler.
17973 Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
17974 https://bugs.webkit.org/show_bug.cgi?id=36845
17976 Provide a way through WebKit to set an accessible label that describes the web area.
17978 * WebView/WebFrame.mm:
17979 (-[WebFrame setAccessibleName:]):
17980 * WebView/WebFramePrivate.h:
17982 2010-03-31 Marcus Bulach <bulach@chromium.org>
17984 Reviewed by Jeremy Orlow.
17986 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
17987 https://bugs.webkit.org/show_bug.cgi?id=35031
17989 * WebCoreSupport/WebChromeClient.h:
17990 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
17992 2010-03-30 Gavin Barraclough <barraclough@apple.com>
17994 Rubber stamped by Sam Weinig.
17996 https://bugs.webkit.org/show_bug.cgi?id=36866
17997 Move CString to WTF
17999 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18000 (WebKit::NetscapePluginInstanceProxy::getCookies):
18001 (WebKit::NetscapePluginInstanceProxy::getProxy):
18002 (WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo):
18003 (WebKit::NetscapePluginInstanceProxy::resolveURL):
18004 * Plugins/WebBaseNetscapePluginView.h:
18005 * Plugins/WebBaseNetscapePluginView.mm:
18006 * Plugins/WebNetscapePluginView.mm:
18007 (-[WebNetscapePluginView resolveURL:forTarget:]):
18009 2010-03-30 John Sullivan <sullivan@apple.com>
18011 Reviewed by Dan Bernstein.
18013 https://bugs.webkit.org/show_bug.cgi?id=36848
18014 <rdar://problem/7362913>
18015 Menu items appropriate only for rich-content editing can appear in plain-text contexts
18017 * WebView/WebHTMLView.mm:
18018 (-[WebHTMLView validRequestorForSendType:returnType:]):
18019 Don't return self for non-string content if _canEditRichly is false.
18021 2010-03-29 Alexey Proskuryakov <ap@apple.com>
18023 Reviewed by Darin Adler.
18025 https://bugs.webkit.org/show_bug.cgi?id=36791
18026 Add assertions for instance proxy validity
18028 Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw
18029 pointer to one across complicated function calls, relying on the caller to protect the
18032 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
18033 (WebKit::NetscapePluginInstanceProxy::renderContextID):
18034 (WebKit::NetscapePluginInstanceProxy::pluginView):
18035 (WebKit::NetscapePluginInstanceProxy::hostProxy):
18037 2010-03-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
18039 Reviewed by David Kilzer.
18041 Explicit guards for ENABLE_GEOLOCATION
18042 https://bugs.webkit.org/show_bug.cgi?id=25756
18044 * WebCoreSupport/WebGeolocationMock.mm:
18045 (-[WebGeolocationMock setError:code:]): Make the body conditional on
18046 ENABLE(GEOLOCATION)
18047 (-[WebGeolocationMock setPosition:]): Ditto.
18049 2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
18051 Reviewed by Antti Koivisto.
18053 Change method name due to it dealing with both flattening
18054 of frame sets and inner frames.
18056 * WebView/WebPreferenceKeysPrivate.h:
18057 * WebView/WebPreferences.mm:
18058 (+[WebPreferences initialize]):
18059 (-[WebPreferences isFrameFlatteningEnabled]):
18060 (-[WebPreferences setFrameFlatteningEnabled:]):
18061 * WebView/WebPreferencesPrivate.h:
18062 * WebView/WebView.mm:
18063 (-[WebView _preferencesChangedNotification:]):
18065 2010-03-27 Darin Adler <darin@apple.com>
18067 * Misc/WebNSFileManagerExtras.m:
18068 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
18069 Removed stray "!". How did that get in there?
18071 2010-03-27 Darin Adler <darin@apple.com>
18073 Reviewed by Mark Rowe.
18075 WebKit NSFileManager methods don't handle broken symlinks correctly.
18076 Part of <rdar://problem/7574046>.
18078 * Misc/WebNSFileManagerExtras.h: Removed unused defines and methods.
18079 * Misc/WebNSFileManagerExtras.m: Removed unused methods.
18080 (fileExists): Added. For use instead of fileExistsAtPath: for cases where we'd like
18081 to treat a broken symlink as a file that does indeed exist.
18082 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use fileExists.
18084 2010-03-25 Alexey Proskuryakov <ap@apple.com>
18086 Reviewed by Mark Rowe.
18088 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in
18089 a way that works in a function that doesn't have a pluginID argument for some reason.
18091 2010-03-25 Simon Fraser <simon.fraser@apple.com>
18093 Build fix: no review.
18095 Another c_str() -> data().
18097 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18098 (WebKit::NetscapePluginInstanceProxy::enumerate):
18100 2010-03-25 Alexey Proskuryakov <ap@apple.com>
18102 Reviewed by Mark Rowe.
18104 Correctness fix after r56493.
18106 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update
18107 our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees
18108 that the host proxy won't go away while the open panel is up.
18110 2010-03-24 Mark Rowe <mrowe@apple.com>
18112 Build fix after r56474.
18114 * Plugins/Hosted/NetscapePluginHostProxy.mm:
18115 (WKPCRunSyncOpenPanel):
18117 2010-03-24 Alexey Proskuryakov <ap@apple.com>
18119 Reviewed by Anders Carlsson.
18121 https://bugs.webkit.org/show_bug.cgi?id=36563
18122 A plug-in makes Safari crash on http://www.itscodingtime.com/
18124 * Plugins/Hosted/NetscapePluginHostProxy.h:
18125 (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't
18126 beautifully systemic, but helped catch a bug, and may help catch more.
18127 (WebKit::NetscapePluginHostProxy::clientPort): Ditto.
18128 (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a
18129 static. This doesn't change behavior much, but helps avoid writing into deallocated memory.
18131 * Plugins/Hosted/NetscapePluginHostProxy.mm:
18132 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests
18134 (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests
18135 after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there
18136 wasn't much time for some other object to be allocated at this address.
18137 (WKPCEvaluate): Refetch host proxy, as it may have been destroyed.
18138 (WKPCInvoke): Ditto.
18139 (WKPCInvokeDefault): Ditto.
18140 (WKPCGetProperty): Ditto.
18141 (WKPCSetProperty): Ditto.
18142 (WKPCRemoveProperty): Ditto.
18143 (WKPCHasProperty): Ditto.
18144 (WKPCHasMethod): Ditto.
18145 (WKPCEnumerate): Ditto.
18146 (WKPCRunSyncOpenPanel): Ditto.
18148 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18149 (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the
18150 "event loop" if host proxy went away while processing a request.
18152 2010-03-24 Hayato Ito <hayato@chromium.org>
18154 Reviewed by Shinichiro Hamaji.
18156 Refactor computePageRects so that Mac can make use of it.
18157 https://bugs.webkit.org/show_bug.cgi?id=36159
18159 Refactoring only, so no new tests.
18161 * WebView/WebFrame.mm:
18162 (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):
18164 2010-03-24 Kent Tamura <tkent@chromium.org>
18166 Reviewed by Darin Adler.
18168 Make Icon::createIconForFiles() optional.
18169 https://bugs.webkit.org/show_bug.cgi?id=35072
18171 - Rename iconForFiles() to chooseIconForFiles().
18172 - Call Icon::createIconForFiles() from chooseIconForFiles().
18174 * WebCoreSupport/WebChromeClient.h:
18175 * WebCoreSupport/WebChromeClient.mm:
18176 (WebChromeClient::chooseIconForFiles):
18178 2010-03-23 Dan Bernstein <mitz@apple.com>
18180 Reverted accidental change from r56429.
18182 * WebCoreSupport/WebContextMenuClient.mm:
18183 (WebContextMenuClient::getCustomMenuFromDefaultItems):
18185 2010-03-23 Dan Bernstein <mitz@apple.com>
18187 Reviewed by John Sullivan.
18190 <rdar://problem/7197736> Plug-in clip rect does not update when overflow
18192 https://bugs.webkit.org/show_bug.cgi?id=36479.
18194 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
18195 (-[WebHostedNetscapePluginView visibleRectDidChange]): Added. Calls
18196 WKSyncSurfaceToView().
18197 * Plugins/WebBaseNetscapePluginView.h:
18198 * Plugins/WebBaseNetscapePluginView.mm:
18199 (-[WebBaseNetscapePluginView _windowClipRect]): Changed to use Widget::windowClipRect().
18200 (-[WebBaseNetscapePluginView visibleRectDidChange]): Added. Invokes -renewGState.
18202 2010-03-22 Kevin Decker <kdecker@apple.com>
18204 Reviewed by Simon Fraser.
18206 https://bugs.webkit.org/show_bug.cgi?id=36328
18208 This patch entirely WebNullPluginView.
18210 * Plugins/WebNetscapePluginView.mm:
18211 * Plugins/WebNullPluginView.h: Removed.
18212 * Plugins/WebNullPluginView.mm: Removed.
18213 * Resources/nullplugin.tiff: Removed.
18214 * WebCoreSupport/WebFrameLoaderClient.mm:
18215 (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
18217 2010-03-22 Alexey Proskuryakov <ap@apple.com>
18219 Reviewed by John Sullivan.
18221 https://bugs.webkit.org/show_bug.cgi?id=36455
18222 Make WebKit more resistant against plug-in crashes
18224 No tests, because crashing on build bots isn't good, even if it's only helper processes
18227 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
18228 (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function
18229 needs it after waiting for reply. Some callers used to do this, but not all, and we really
18230 shouldn't depend on callers here.
18232 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18233 (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy,
18234 because this function doesn't use it after waiting for reply.
18235 (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.
18237 * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy
18238 null check for another code path.
18240 2010-03-22 Kevin Decker <kdecker@apple.com>
18242 Reviewed by John Sullivan.
18244 https://bugs.webkit.org/show_bug.cgi?id=36328
18246 * WebCoreSupport/WebViewFactory.mm:
18247 (-[WebViewFactory missingPluginText]): Added.
18249 2010-03-18 Alexey Proskuryakov <ap@apple.com>
18251 Reviewed by Darin Adler.
18253 https://bugs.webkit.org/show_bug.cgi?id=36337
18254 Log an error when an OOP plug-in sends an unknown object id
18256 Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look
18257 temporary or redundant.
18259 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18260 (WebKit::NetscapePluginInstanceProxy::evaluate):
18261 (WebKit::NetscapePluginInstanceProxy::invoke):
18262 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
18263 (WebKit::NetscapePluginInstanceProxy::construct):
18264 (WebKit::NetscapePluginInstanceProxy::getProperty):
18265 (WebKit::NetscapePluginInstanceProxy::setProperty):
18266 (WebKit::NetscapePluginInstanceProxy::removeProperty):
18267 (WebKit::NetscapePluginInstanceProxy::hasProperty):
18268 (WebKit::NetscapePluginInstanceProxy::hasMethod):
18269 (WebKit::NetscapePluginInstanceProxy::enumerate):
18271 2010-03-16 Alexey Proskuryakov <ap@apple.com>
18273 Reviewed by Darin Adler.
18275 https://bugs.webkit.org/show_bug.cgi?id=36184
18276 YouTube video resizing doesn't work with OOP plug-ins
18278 Test: plugins/resize-from-plugin.html
18280 We were calling _WKPHResizePluginInstance synchronously or asynchronously, depending on
18281 whether the size has changed. But sync and async messages are not necessarily delivered in
18282 order - plug-in host listens only to the former while waiting for a response to a message it
18283 sent (a call to invoke() in this case).
18285 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
18286 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18287 (WebKit::NetscapePluginInstanceProxy::resize):
18288 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
18289 (-[WebHostedNetscapePluginView updateAndSetWindow]):
18291 2010-03-16 Yury Semikhatsky <yurys@chromium.org>
18293 Reviewed by Pavel Feldman.
18295 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
18297 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
18298 https://bugs.webkit.org/show_bug.cgi?id=35036
18300 * WebCoreSupport/WebInspectorClient.h:
18301 * WebCoreSupport/WebInspectorClient.mm:
18302 (WebInspectorClient::WebInspectorClient):
18303 (WebInspectorClient::inspectorDestroyed):
18304 (WebInspectorClient::openInspectorFrontend):
18305 (WebInspectorClient::highlight):
18306 (WebInspectorClient::hideHighlight):
18307 (WebInspectorFrontendClient::WebInspectorFrontendClient):
18308 (WebInspectorFrontendClient::frontendLoaded):
18309 (WebInspectorFrontendClient::localizedStringsURL):
18310 (WebInspectorFrontendClient::hiddenPanels):
18311 (WebInspectorFrontendClient::bringToFront):
18312 (WebInspectorFrontendClient::closeWindow):
18313 (WebInspectorFrontendClient::attachWindow):
18314 (WebInspectorFrontendClient::detachWindow):
18315 (WebInspectorFrontendClient::setAttachedWindowHeight):
18316 (WebInspectorFrontendClient::inspectedURLChanged):
18317 (WebInspectorFrontendClient::updateWindowTitle):
18318 (-[WebInspectorWindowController dealloc]):
18319 (-[WebInspectorWindowController windowShouldClose:]):
18320 (-[WebInspectorWindowController close]):
18321 (-[WebInspectorWindowController showWindow:]):
18322 (-[WebInspectorWindowController attach]):
18323 (-[WebInspectorWindowController detach]):
18324 (-[WebInspectorWindowController attached]):
18325 (-[WebInspectorWindowController setFrontendClient:]):
18326 (-[WebInspectorWindowController destroyInspectorView]):
18327 (-[WebNodeHighlighter initWithInspectedWebView:]):
18328 (-[WebNodeHighlighter dealloc]):
18329 (-[WebNodeHighlighter highlightNode:]):
18330 (-[WebNodeHighlighter hideHighlight]):
18331 (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
18332 (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
18333 * WebInspector/WebInspector.mm:
18334 (-[WebInspector attach:]):
18335 (-[WebInspector detach:]):
18337 2010-03-15 Andy Estes <aestes@apple.com>
18339 Reviewed by John Sullivan.
18341 Updated call to WKGetWheelEventDeltas() to match new method signature.
18343 https://bugs.webkit.org/show_bug.cgi?id=29601
18344 <rdar://problem/7453254>
18346 * WebView/WebDynamicScrollBarsView.mm:
18347 (-[WebDynamicScrollBarsView scrollWheel:]):
18349 2010-03-15 John Sullivan <sullivan@apple.com>
18351 Reviewed by Adam Roben.
18353 -[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
18354 <https://bugs.webkit.org/show_bug.cgi?id=36125>
18356 * WebView/WebDynamicScrollBarsView.h:
18357 Added instance variables horizontalScrollingAllowedButScrollerHidden and
18358 verticalScrollingAllowedButScrollerHidden. Renamed instance variables
18359 hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity.
18360 Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed.
18363 * WebView/WebDynamicScrollBarsView.mm:
18364 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
18365 Updated for instance variable renaming.
18366 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
18368 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
18369 New method, returns YES if the scroller is showing or the only reason that the scroller
18370 is not showing is that setAlwaysHideHorizontalScrolling has been called.
18371 (-[WebDynamicScrollBarsView verticalScrollingAllowed]):
18372 New method, returns YES if the scroller is showing or the only reason that the scroller
18373 is not showing is that setAlwaysHideVerticalScrolling has been called.
18374 (-[WebDynamicScrollBarsView updateScrollers]):
18375 Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden
18376 and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account
18377 in the early-return code path, to avoid taking it into account twice in the regular code path.
18379 * WebView/WebFrameView.mm:
18380 (-[WebFrameView _scrollToBeginningOfDocument]):
18381 Use _isScrollable instead of _hasScrollBars.
18382 (-[WebFrameView _scrollToEndOfDocument]):
18384 (-[WebFrameView scrollToBeginningOfDocument:]):
18385 Use _largestScrollableChild instead of _largestChildWithScrollBars.
18386 (-[WebFrameView scrollToEndOfDocument:]):
18388 (-[WebFrameView _pageVertically:]):
18389 Use _isScrollable and _largestScrollableChild instead of _hasScrollBars
18390 and _largestChildWithScrollBars.
18391 (-[WebFrameView _pageHorizontally:]):
18393 (-[WebFrameView _scrollLineVertically:]):
18395 (-[WebFrameView _scrollLineHorizontally:]):
18397 (-[WebFrameView keyDown:]):
18398 Use _largestScrollableChild instead of _largestChildWithScrollBars.
18399 (-[WebFrameView _isScrollable]):
18400 New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and
18401 -[WebDynamicScrollBarsView verticalScrollingAllowed]
18402 (-[WebFrameView _largestScrollableChild]):
18403 New method, like _largestChildWithScrollBars but uses _isScrollable.
18404 (-[WebFrameView _hasScrollBars]):
18405 Added a comment that this is no longer used by Safari, and can thus probably be
18406 deleted once we no longer want to support it for nightly build compatibility with
18407 old versions of Safari.
18408 (-[WebFrameView _largestChildWithScrollBars]):
18411 * WebView/WebFrameViewPrivate.h:
18412 Declared -_isScrollable and -_largestScrollableChild. Added comments to
18413 _hasScrollBars and _largestChildWithScrollBars saying that they are no longer
18414 used by Safari, and can thus probably be deleted once we no longer want to
18415 support them for nightly build compatibility with old versions of Safari.
18417 2010-03-15 John Sullivan <sullivan@apple.com>
18419 Method name and parameter name mistakes from recent SPI addition
18420 <https://bugs.webkit.org/show_bug.cgi?id=36119>
18422 Reviewed by Dan Bernstein.
18424 * WebView/WebDynamicScrollBarsView.h:
18425 Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX".
18427 * WebView/WebDynamicScrollBarsView.mm:
18428 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
18429 Updated for renamed instance variable and method.
18430 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
18431 Changed parameter name from shouldBeVisible to shouldBeHidden.
18432 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
18434 (-[WebDynamicScrollBarsView contentViewFrame]):
18435 Updated for renamed instance variable.
18436 (-[WebDynamicScrollBarsView tile]):
18438 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
18441 * WebView/WebFrame.mm:
18442 (-[WebFrame setAllowsScrollersToOverlapContent:]):
18443 Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView.
18445 * WebView/WebFramePrivate.h:
18446 Renamed method name from "setAllowXXX" to "setAllowsXXX".
18448 2010-03-14 Darin Adler <darin@apple.com>
18450 Reviewed by Mark Rowe.
18452 Remove unneeded dependency on non-string identifier for an NSTableColumn
18453 https://bugs.webkit.org/show_bug.cgi?id=36106
18455 * WebView/WebTextCompletionController.mm:
18456 (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier:
18457 because the table has only one column and that column does not need an identifier.
18459 2010-03-12 Beth Dakin <bdakin@apple.com>
18461 Reviewed by Simon Fraser.
18463 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
18464 API naming is inconsistent
18465 -and corresponding-
18466 <rdar://problem/7729165>
18468 This patch changes all occurrences of "fullScreen" to the more
18469 popular "fullscreen."
18471 * Plugins/Hosted/NetscapePluginHostProxy.h:
18472 (WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):
18473 * Plugins/Hosted/NetscapePluginHostProxy.mm:
18474 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
18475 (WebKit::NetscapePluginHostProxy::didEnterFullscreen):
18476 (WebKit::NetscapePluginHostProxy::didExitFullscreen):
18477 (WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
18478 (WKPCSetFullscreenWindowIsShowing):
18479 * Plugins/Hosted/WebKitPluginClient.defs:
18480 * Plugins/WebNetscapePluginView.mm:
18481 (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
18482 (-[WebNetscapePluginView _createPlugin]):
18483 (-[WebNetscapePluginView _destroyPlugin]):
18484 * WebView/WebVideoFullscreenHUDWindowController.mm:
18485 (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
18487 2010-03-12 Andy Estes <aestes@apple.com>
18489 Reviewed by Brady Eidson.
18491 Expose WebPDFView's underlying PDFDocument.
18493 https://bugs.webkit.org/show_bug.cgi?id=36045
18495 * WebView/WebDocumentPrivate.h: Create a new protocol called
18497 * WebView/WebPDFView.h: Have WebPDFView implement said protocol.
18498 * WebView/WebPDFView.mm:
18499 (-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
18500 PDFDocument by implementing -(PDFDocument*)PDFDocument from
18503 2010-03-12 Andy Estes <aestes@apple.com>
18505 Reviewed by Brady Eidson.
18507 Remove an unused method.
18509 https://bugs.webkit.org/show_bug.cgi?id=35940
18511 * Plugins/WebPluginController.mm:
18512 removed - (void)showURL:(NSURL *) inFrame:(NSString *)
18514 2010-03-11 Mark Rowe <mrowe@apple.com>
18516 Reviewed by David Kilzer.
18518 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
18520 Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
18522 * Configurations/Base.xcconfig:
18524 2010-03-11 Mark Rowe <mrowe@apple.com>
18526 Reviewed by Tim Hatcher.
18528 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
18530 Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
18531 current Mac OS X version unless otherwise specified.
18533 Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
18535 Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
18536 may not be usable when targetting a different Mac OS X version.
18538 Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
18539 MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
18541 * Configurations/Base.xcconfig:
18542 * Configurations/DebugRelease.xcconfig:
18543 * Configurations/FeatureDefines.xcconfig:
18544 * Configurations/Version.xcconfig:
18546 2010-03-11 Anders Carlsson <andersca@apple.com>
18548 Reviewed by David Hyatt.
18550 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
18552 * WebCoreSupport/WebChromeClient.h:
18553 * WebCoreSupport/WebChromeClient.mm:
18555 2010-03-11 Alexey Proskuryakov <ap@apple.com>
18557 Reviewed by Geoff Garen.
18559 https://bugs.webkit.org/show_bug.cgi?id=35965
18560 <rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in
18562 Test: plugins/round-trip-npobject.html
18564 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18565 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is
18566 now a separate ProxyRuntimeObject class for proxy pbjects.
18567 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
18569 * Plugins/Hosted/ProxyInstance.mm:
18570 (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in
18571 could have crashed while we were waiting for response.
18572 (WebKit::ProxyInstance::setFieldValue): Ditto.
18574 2010-03-10 Simon Fraser <simon.fraser@apple.com>
18576 Reviewed by Darin Adler.
18578 https://bugs.webkit.org/show_bug.cgi?id=35975
18579 <rdar://problem/7739922> Flash 10.1b crashes when generating snapshots
18581 Do a version check before sending a drawRect event to a Flash plugin,
18582 since 10.1.d51 has a bug that crashes when called this way.
18584 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
18585 (-[WebHostedNetscapePluginView drawRect:]):
18586 * Plugins/WebBaseNetscapePluginView.h:
18587 * Plugins/WebBaseNetscapePluginView.mm:
18588 (-[WebBaseNetscapePluginView supportsSnapshotting]):
18589 * Plugins/WebNetscapePluginView.mm:
18590 (-[WebNetscapePluginView drawRect:]):
18592 2010-03-10 John Sullivan <sullivan@apple.com>
18594 Reviewed by Tim Hatcher.
18596 <rdar://problem/7735387> input type other than text won't work with autofill
18597 <https://bugs.webkit.org/show_bug.cgi?id=35963>
18599 * WebView/WebHTMLRepresentation.mm:
18600 (-[WebHTMLRepresentation elementDoesAutoComplete:]):
18601 Return true for any text field that's not a password, rather than only
18604 2010-03-09 Brady Eidson <beidson@apple.com>
18606 Reviewed by Tim Hatcher.
18608 REGRESSION: WebInspector docking busted on Windows
18609 <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
18611 * WebCoreSupport/WebInspectorClient.mm:
18612 (-[WebInspectorWindowController showWindow:]): Use the InspectorController:: copy of the should attach settings key.
18613 (-[WebInspectorWindowController attach]): Ditto.
18614 (-[WebInspectorWindowController detach]): Ditto.
18616 2010-03-09 Geoffrey Garen <ggaren@apple.com>
18618 Reviewed by Darin Adler.
18620 Updated for FastMalloc reporting changes.
18622 * Misc/WebCoreStatistics.mm:
18623 (+[WebCoreStatistics memoryStatistics]):
18625 2010-03-08 Simon Fraser <simon.fraser@apple.com>
18627 Reviewed by Mark Rowe.
18629 Move the new method to the end of the MIG definitions file, to avoid breaking
18630 compatibility between WebKit and older versions of WebKitPluginHost.
18632 * Plugins/Hosted/WebKitPluginHost.defs:
18634 2010-03-08 Simon Fraser <simon.fraser@apple.com>
18636 Reviewed by Kevin Decker.
18638 <rdar://problem/7714340> Need to grab image snapshot of Core Animation plugins
18640 Allow plug-ins using the Core Animation drawing model to be captured when doing a flattening paint,
18641 by sending them a drawRect event as if they were software-painting.
18643 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
18644 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18645 (WebKit::NetscapePluginInstanceProxy::snapshot):
18646 New snapshot() method that calls over to the plugin host, and then draws the image that comes back.
18648 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
18649 (-[WebHostedNetscapePluginView drawRect:]): If we don't have a software renderer, but we're doing
18650 a flattening paint, then call the snapshot method.
18652 * Plugins/Hosted/WebKitPluginHost.defs: Added snapshot method.
18654 * Plugins/WebBaseNetscapePluginView.h:
18655 * Plugins/WebBaseNetscapePluginView.mm:
18656 (-[WebBaseNetscapePluginView inFlatteningPaint]):
18657 New utility method that asks the FrameView whether the current paint behavior is
18660 * Plugins/WebNetscapePluginView.mm:
18661 (-[WebNetscapePluginView drawRect:]): If the plug-in is using CA but this is a flattening
18662 paint, go ahead and send a drawRect event to the plug-in.
18664 2010-03-08 Darin Adler <darin@apple.com>
18666 Reviewed by Dan Bernstein.
18668 Fix crash when you quit inside an unload handler.
18669 rdar://problem/6958347
18671 Test: manual-tests/quit-inside-unload.html
18673 * WebView/WebView.mm:
18674 (-[WebView _closeWithFastTeardown]): Removed code to set
18675 _private->closed since _close now does this earlier, before
18676 calling this method.
18677 (-[WebView _close]): Moved code to set _private->closed to the
18678 top of this method.
18679 (-[WebView setHostWindow:]): Rewrote the code that forbade
18680 setting the host window after closing so that it only forbids
18681 non-nil host windows. That way, the code to clear away the host
18682 window can run safely after setting _private->closed, yet client
18683 code cannot set a new host window after closing.
18685 2010-03-08 Darin Adler <darin@apple.com>
18687 Roll out a file I checked in by accident.
18689 * WebView/WebView.mm: Back to previous version.
18691 2010-03-08 Chris Marrin <cmarrin@apple.com>
18693 Reviewed by Darin Adler.
18695 Turn on HW accel on Leopard even if coreVideoHas7228836Fix() is false, when WebGL is enabled
18696 https://bugs.webkit.org/show_bug.cgi?id=35759
18698 This allows WebGL to work on Leopard without the fix. It exposes these users to the crash
18699 that happens because of the CoreVideo bug, but it limits the exposure to those who have
18700 chosen to enable WebGL.
18702 * WebView/WebView.mm:
18703 (-[WebView _preferencesChangedNotification:]):
18705 2010-03-02 Adam Treat <atreat@rim.com>
18707 Reviewed by Dave Hyatt.
18709 Adapt the mac port to the refactoring of repaint methods.
18711 https://bugs.webkit.org/show_bug.cgi?id=34214
18713 * WebCoreSupport/WebChromeClient.h:
18714 * WebCoreSupport/WebChromeClient.mm:
18715 (WebChromeClient::invalidateContents):
18716 (WebChromeClient::invalidateWindow):
18717 (WebChromeClient::invalidateContentsAndWindow):
18718 (WebChromeClient::invalidateContentsForSlowScroll):
18720 2010-03-08 Jian Li <jianli@chromium.org>
18722 Reviewed by Dmitry Titov.
18724 Blob.slice support.
18725 https://bugs.webkit.org/show_bug.cgi?id=32993
18727 Add ENABLE_BLOB_SLICE feature define.
18729 * Configurations/FeatureDefines.xcconfig:
18731 2010-03-08 Eric Uhrhane <ericu@chromium.org>
18733 Reviewed by David Levin.
18735 Remove the now-redundant Settings fields for the Database
18736 https://bugs.webkit.org/show_bug.cgi?id=35763
18738 No new tests; this code isn't called.
18740 * WebView/WebView.mm: Remove the call into Settings.
18741 (-[WebView _preferencesChangedNotification:]):
18743 2010-03-07 Mark Rowe <mrowe@apple.com>
18745 Rubber-stamped by Cameron Zwarich.
18747 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
18749 * Misc/WebIconDatabase.mm:
18751 2010-03-07 Mark Rowe <mrowe@apple.com>
18753 Rubber-stamped by Cameron Zwarich.
18755 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
18757 * Misc/WebNSPasteboardExtras.mm:
18759 2010-03-04 Mark Rowe <mrowe@apple.com>
18761 Reviewed by Sam Weinig.
18763 <rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h
18765 * MigrateHeaders.make: Migrate DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h.
18767 2010-03-04 Mark Rowe <mrowe@apple.com>
18769 Reviewed by Sam Weinig.
18771 Use a framework-style include to pull in WebInspector.h for consistency
18772 with other parts of WebKit.
18774 * WebInspector/WebInspectorPrivate.h:
18776 2010-03-04 Brady Eidson <beidson@apple.com>
18778 Reviewed by Geoff Garen.
18780 REGRESSION (31281): -[WebArchive initWithCoder:] leaks
18781 <rdar://problem/7702420> and https://bugs.webkit.org/show_bug.cgi?id=35534
18783 * WebView/WebArchive.mm:
18784 (-[WebArchive initWithCoder:]): Don't retain objects we don't own.
18786 2010-03-03 Alexey Proskuryakov <ap@apple.com>
18788 Reviewed by Timothy Hatcher.
18790 https://bugs.webkit.org/show_bug.cgi?id=35692
18791 <rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView
18793 * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
18794 Retain the challenge, just like it's done for sheet.
18796 2010-03-02 Eric Uhrhane <ericu@chromium.org>
18798 Reviewed by David Levin.
18800 Move database enable bit fully out of settings
18801 This is stage one of a three-stage commit [webkit, then chromium, then
18802 webkit again]. In this change I'm adding calls to
18803 Database::setIsAvailable inside Settings::setDatabaseEnabled and
18804 anywhere else that called it, and switching webkit fully over to using
18805 that flag [added in a previous checkin]. Phase two will remove
18806 Chromium's use of Settings for the Database, and phase three will remove
18807 the Setting for the Database enable entirely, leaving only
18808 Database::isAvailable/setIsAvailable.
18810 No new tests; tested by existing storage tests.
18812 https://bugs.webkit.org/show_bug.cgi?id=35310
18814 * WebView/WebView.mm: Added a call to Database::setIsAvailable.
18815 (-[WebView _preferencesChangedNotification:]):
18817 2010-03-02 Adam Roben <aroben@apple.com>
18819 Add -[WebView _registerURLSchemeAsSecure:]
18821 Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose
18822 SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
18824 Reviewed by Tim Hatcher.
18826 * WebView/WebView.mm:
18827 (+[WebView _registerURLSchemeAsSecure:]):
18828 * WebView/WebViewPrivate.h:
18829 Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
18831 2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
18833 Reviewed by Adam Barth.
18835 Adapt to the new ZoomMode enum.
18836 https://bugs.webkit.org/show_bug.cgi?id=35347
18838 * WebView/WebView.mm:
18839 (-[WebView _preferencesChangedNotification:]):
18840 (-[WebView _setZoomMultiplier:isTextOnly:]):
18841 (-[WebView _realZoomMultiplierIsTextOnly]):
18843 2010-02-27 Jing Jin <jjin@apple.com>
18845 Reviewed by Timothy Hatcher.
18847 Move implementation of Bug 35449 into WebFramePrivate.
18849 * WebView/WebFrame.h:
18850 * WebView/WebFrame.mm:
18851 (-[WebFrame setAllowScrollersToOverlapContent:]):
18852 (-[WebFrame setAlwaysHideHorizontalScroller:]):
18853 (-[WebFrame setAlwaysHideVerticalScroller:]):
18854 * WebView/WebFramePrivate.h:
18856 2010-02-26 Jing Jin <jjin@apple.com>
18858 Reviewed by Timothy Hatcher.
18860 https://bugs.webkit.org/show_bug.cgi?id=35449
18861 Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.
18863 * WebView/WebDynamicScrollBarsView.h:
18864 * WebView/WebDynamicScrollBarsView.mm:
18865 (-[WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]): Allows scrollbars to
18866 overlap with the document and re-layouts the document.
18867 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): Hides the horizontal scrollbar.
18868 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): Hides the vertical scrollbar.
18869 (-[WebDynamicScrollBarsView contentViewFrame]): Calculates the appropriate frame based
18870 on allowScrollersToOverlapContent.
18871 (-[WebDynamicScrollBarsView tile]): If allowScrollersToOverlapContent is YES, set the
18872 contentView's frame so it overlaps with the scrollbar.
18873 (-[WebDynamicScrollBarsView updateScrollers]): Take into account hideHorizontalScroller
18874 and hideVerticalScroller.
18875 (-[WebDynamicScrollBarsView reflectScrolledClipView:]): set drawsBackground to NO when
18876 scrollbars are overlapping with content, so we don't get trails during scrollbar draw updates.
18877 * WebView/WebDynamicScrollBarsViewInternal.h:
18878 * WebView/WebFrame.h:
18879 * WebView/WebFrame.mm:
18880 (-[WebFrame setAllowScrollersToOverlapContent:]): Hook for [WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]
18881 (-[WebFrame setAlwaysHideHorizontalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]
18882 (-[WebFrame setAlwaysHideVerticalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]
18884 2010-02-26 Gavin Barraclough <barraclough@apple.com>
18886 Reviewed by Alexey Proskuryakov.
18888 Bug 35401 - Fix handling of errors in handling calls over bridge,
18889 where base object bridge-type does not match method bridge-type.
18891 The code assumes users will only attempt to invoke a Java method
18892 on a Java base object, etc.
18893 Add language specific subclasses of RuntimeMethod, and pass the
18894 RuntimeMethod into invokeMethod, so we can typecheck before
18895 casting. Throw an exception on type mismatch.
18897 * Plugins/Hosted/ProxyInstance.h:
18898 * Plugins/Hosted/ProxyInstance.mm:
18899 (WebKit::PluginRuntimeMethod::PluginRuntimeMethod): new class to distinguish this type of RuntimeMethod.
18900 (WebKit::ProxyInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
18901 (WebKit::ProxyInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
18903 2010-02-25 Alexey Proskuryakov <ap@apple.com>
18905 Reviewed by Geoffrey Garen.
18907 https://bugs.webkit.org/show_bug.cgi?id=35394
18908 <rdar://problem/7685262> Make passing objects between Java and plug-ins work
18910 Added a ProxyInstance implementation of RuntimeObject.
18912 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18913 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
18914 * Plugins/Hosted/ProxyInstance.h:
18915 * Plugins/Hosted/ProxyInstance.mm:
18916 (WebKit::ProxyInstance::newRuntimeObject):
18917 (WebKit::ProxyInstance::getClass):
18918 * Plugins/Hosted/ProxyRuntimeObject.h: Added.
18919 (WebKit::ProxyRuntimeObject::classInfo):
18920 * Plugins/Hosted/ProxyRuntimeObject.mm: Added.
18921 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
18922 (WebKit::ProxyRuntimeObject::~ProxyRuntimeObject):
18923 (WebKit::ProxyRuntimeObject::getInternalProxyInstance):
18925 2010-02-24 Adam Barth <abarth@webkit.org>
18927 Reviewed by Darin Fisher.
18929 [Chromium API] Disambiguate allowJavaScript from didNotAllowScript
18930 https://bugs.webkit.org/show_bug.cgi?id=35205
18932 Make these two callsites explicit about not running script immediately.
18934 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18935 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
18936 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
18938 2010-02-23 Brady Eidson <beidson@apple.com>
18940 Reviewed by Tim Hatcher and Pavel Feldman.
18942 Regression (r55107) - WebInspector docking is busted.
18943 https://bugs.webkit.org/show_bug.cgi?id=35274
18945 * WebCoreSupport/WebInspectorClient.mm:
18946 (-[WebInspectorWindowController showWindow:]): Swap the order of the "should attach?" check
18947 to get the expected behavior.
18949 2010-02-23 Dan Bernstein <mitz@apple.com>
18951 Reviewed by Simon Fraser.
18953 <rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
18954 https://bugs.webkit.org/show_bug.cgi?id=34381
18956 Test: fast/repaint/repaint-during-scroll.html
18958 NSClipView offsets any rects marked as needing display during scrolling
18959 by the scroll offset. Compensate for this when -setNeedsDisplay: is called
18962 * WebView/WebHTMLView.mm:
18963 (-[WebHTMLView _frameOrBoundsChanged]): Set inScrollPositionChanged to YES
18964 around to call to FrameView::scrollPositionChanged().
18965 (-[WebHTMLView setNeedsDisplayInRect:]): When called beneath
18966 scrollPositionChanged(), adjust the rect by the inverse of the scroll offset.
18968 2010-02-23 Steve Block <steveblock@google.com>
18970 Reviewed by Darin Adler.
18972 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
18973 https://bugs.webkit.org/show_bug.cgi?id=34962
18975 This method is required so that a Geolocation object can cancel an
18976 asynchronous permission request. This allows the chrome client to cancel
18977 any UI it is showing for the permission request.
18979 * WebCoreSupport/WebChromeClient.h:
18980 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
18982 2010-02-22 Alexey Proskuryakov <ap@apple.com>
18984 Rubber-stamped by Geoff Garen.
18986 Rename RuntimeObjectImp to RuntimeObject.
18988 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18989 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
18990 (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
18991 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
18993 2010-02-22 Brady Eidson <beidson@apple.com>
18995 Reviewed by Tim Hatcher.
18997 Disable WebView docking to views that are too small.
18998 <rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
19000 * WebCoreSupport/WebInspectorClient.mm:
19001 (-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector
19002 window attached if WebCore says it shouldn't be attached.
19004 2010-02-22 Simon Fraser <simon.fraser@apple.com>
19006 Reviewed by John Sullivan.
19008 <rdar://problem/7285392>
19009 On Leopard, we have to disable hardware acceleration if we detect that the
19010 installed Core Video framework has bug <rdar://problem/7228836>.
19012 * WebView/WebView.mm:
19013 (coreVideoHas7228836Fix):
19014 (-[WebView _preferencesChangedNotification:]):
19016 2010-02-21 Dan Bernstein <mitz@apple.com>
19018 Reviewed by Darin Adler.
19020 False warnings about needing layout in
19021 -[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
19022 https://bugs.webkit.org/show_bug.cgi?id=35218
19024 * WebView/WebHTMLView.mm:
19025 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
19026 Suppress the warning and the forced layout if the view is not being drawn
19027 in this display operation.
19029 2010-02-21 Kevin Decker <kdecker@apple.com>
19031 Reviewed by Sam Weinig.
19033 plugInViewWithArguments: API sends wrong parameter for WebPlugInBaseURLKey
19034 https://bugs.webkit.org/show_bug.cgi?id=35215
19035 <rdar://problem/7673157>
19037 The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters
19038 is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing
19039 the plug-in's view. Instead of sending the base URL, code in WebFrameLoaderClient::createPlugin
19040 would incorrectly pass the source URL of the plug-in resource.
19042 * WebCoreSupport/WebFrameLoaderClient.mm:
19043 (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the
19044 real base URL for the WebPlugInBaseURLKey key.
19046 2010-02-19 Maciej Stachowiak <mjs@apple.com>
19048 Reviewed by David Levin.
19050 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
19051 https://bugs.webkit.org/show_bug.cgi?id=35147
19053 * Configurations/FeatureDefines.xcconfig:
19055 2010-02-19 Alexey Proskuryakov <ap@apple.com>
19057 Reviewed by Maciej Stachowiak.
19059 https://bugs.webkit.org/show_bug.cgi?id=35132
19060 <rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)
19062 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
19063 (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse
19064 move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout
19065 resorting to techniques such as fast firing timers.
19067 * Plugins/WebNetscapePluginView.mm:
19068 (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally,
19069 but those that don't just need to get an arrow cursor (matching Firefox). This means that
19070 e.g. a plugin inside <A> won't get a finger mouse pointer.
19072 * Plugins/WebHostedNetscapePluginView.mm:
19073 (-[WebNetscapePluginView handleMouseEntered:]):
19074 (-[WebNetscapePluginView handleMouseExited:]):
19075 Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on
19076 mouse exit, which it needed to do.
19078 * WebView/WebHTMLView.mm:
19079 (needsCursorRectsSupportAtPoint):
19081 (resetCursorRects):
19082 Make sure that the same workaround we have for Web content also applies to Netscape plug-ins,
19083 as AppKit would reset the mouse pointer to arrow if given a chance.
19084 (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent
19085 confusion - the method we override is completely different.
19086 (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.
19088 2010-02-19 Simon Fraser <simon.fraser@apple.com>
19090 Reviewed by Dan Bernstein.
19092 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
19094 Followup to avoid capturing compositing layers twice in snapshots. Add private
19095 methods to WebView to specify whether drawing the WebView into an image will
19096 include flattened compositing layers (the default behavior) or not.
19098 * WebView/WebFrame.mm:
19099 (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we
19102 * WebView/WebViewPrivate.h: New methods.
19103 * WebView/WebView.mm: Ditto.
19104 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
19105 (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]):
19106 (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):
19108 * WebView/WebViewData.h: New member variable.
19110 2010-02-19 Alexey Proskuryakov <ap@apple.com>
19112 Reviewed by Dan Bernstein.
19114 https://bugs.webkit.org/show_bug.cgi?id=35165
19115 plugins/set-status.html fails on Windows bot
19117 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19118 (WebKit::NetscapePluginInstanceProxy::status):
19119 * Plugins/WebNetscapePluginView.mm:
19120 (-[WebNetscapePluginView status:]):
19121 Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as
19122 empty ones to chrome.
19124 2010-02-18 Simon Fraser <simon.fraser@apple.com>
19126 Reviewed by Dan Bernstein.
19128 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
19130 Add logic to determine when painting via the software rendering path will give an equivalent
19131 result to the accelerated compositing presentation. This tests for the presence of 3D transforms.
19133 Also have -[WebFrame _drawRect:contentsOnly:] set the PaintBehaviorFlattenCompositingLayers
19134 paint behavior when painting into a bitmap context, so that snapshots contain composited layers.
19136 * WebView/WebFrame.mm:
19137 (-[WebFrame _drawRect:contentsOnly:]): Set the PaintBehaviorFlattenCompositingLayers flag
19138 when painting into a bitmap context.
19139 * WebView/WebView.mm:
19140 (-[WebView _isSoftwareRenderable]): Returns YES if all frames can be software-rendered.
19141 * WebView/WebViewPrivate.h: New _isSoftwareRenderable method.
19143 2010-02-18 Alexey Proskuryakov <ap@apple.com>
19145 Reviewed by Dan Bernstein.
19147 https://bugs.webkit.org/show_bug.cgi?id=35134
19148 <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
19150 Test: plugins/set-status.html
19152 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19153 (WebKit::NetscapePluginInstanceProxy::status):
19154 (WebKit::NetscapePluginInstanceProxy::loadURL):
19155 Added null checks for CFStringCreateWithCString arguments.
19157 2010-02-17 Dmitry Titov <dimich@chromium.org>
19159 Reviewed by David Levin, Darin Fisher, Simon Hausmann.
19161 When a live iframe element is moved between pages, it still depends on the old page.
19162 https://bugs.webkit.org/show_bug.cgi?id=34382
19164 * WebCoreSupport/WebFrameLoaderClient.h:
19165 * WebCoreSupport/WebFrameLoaderClient.mm:
19166 Added empty implementation of a new virtual method.
19168 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
19170 2010-02-17 Kent Tamura <tkent@chromium.org>
19172 Reviewed by Eric Seidel.
19174 Introduces new Icon loading interface in order to support
19175 asynchronous loading.
19176 https://bugs.webkit.org/show_bug.cgi?id=32054
19178 Add an empty implementation of ChromeClient::iconForFiles().
19180 * WebCoreSupport/WebChromeClient.h:
19181 * WebCoreSupport/WebChromeClient.mm:
19182 (WebChromeClient::iconForFiles):
19184 2010-02-17 Timothy Hatcher <timothy@apple.com>
19186 Add a way for WebView and its dependancies to be selectively included
19187 in WebKitStatistics leak tracking. By default WebView is not included and
19188 you need to subclass WebView and implement +isIncludedInWebKitStatistics
19191 rdar://problem/7567677&7572900
19192 https://webkit.org/b/35045
19194 Reviewed by Adam Roben.
19196 * WebView/WebDataSource.mm:
19197 (-[WebDataSource _initWithDocumentLoader:]): Increment WebDataSourceCount if the WebFrame is included in statistics.
19198 (-[WebDataSource dealloc]): Only --WebDataSourceCount if _private->includedInWebKitStatistics is YES.
19199 (-[WebDataSource finalize]): Ditto.
19200 * WebView/WebFrame.mm:
19201 (-[WebFrame _isIncludedInWebKitStatistics]): Return _private->includedInWebKitStatistics.
19202 (-[WebFrame _initWithWebFrameView:webView:]): Increment WebFrameCount if the WebView's class is included in statistics.
19203 (-[WebFrame dealloc]): Only --WebFrameCount if _private->includedInWebKitStatistics is YES.
19204 (-[WebFrame finalize]): Ditto.
19205 * WebView/WebFrameInternal.h:
19206 * WebView/WebFrameView.mm:
19207 (-[WebFrameView _setWebFrame:]): Increment WebFrameViewCount if the WebFrame is included in statistics.
19208 (-[WebFrameView initWithFrame:]): Move ++WebFrameViewCount from here since we don't
19209 know what WebFrame we belong to yet.
19210 (-[WebFrameView dealloc]): Only --WebFrameViewCount if _private->includedInWebKitStatistics is YES.
19211 (-[WebFrameView finalize]): Ditto.
19212 * WebView/WebHTMLRepresentation.mm:
19213 (-[WebHTMLRepresentation init]): Move ++WebHTMLRepresentationCount from here since we don't
19214 know what WebFrame we belong to yet.
19215 (-[WebHTMLRepresentation dealloc]): Only --WebHTMLRepresentationCount if _private->includedInWebKitStatistics is YES.
19216 (-[WebHTMLRepresentation finalize]): Ditto.
19217 (-[WebHTMLRepresentation setDataSource:]): Increment WebHTMLRepresentationCount if the WebFrame of the dataSource is
19218 included in statistics.
19219 * WebView/WebView.mm:
19220 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
19221 (-[WebView dealloc]):
19222 (+[WebView shouldIncludeInWebKitStatistics]): Return NO, so any WebView wont be included.
19223 Subclasses that care can return YES to be included.
19224 * WebView/WebViewInternal.h:
19226 2010-02-16 Darin Adler <darin@apple.com>
19228 Reviewed by Sam Weinig.
19230 Generalize delayed plug-in start for background tabs for use for other media
19231 https://bugs.webkit.org/show_bug.cgi?id=34981
19233 * WebView/WebHTMLView.mm:
19234 (-[WebHTMLView viewWillMoveToWindow:]): Added comment.
19235 (-[WebHTMLView viewDidMoveToWindow]): Ditto.
19237 * WebView/WebView.mm:
19238 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
19239 Call setCanStartMedia right away so that if this view is not in a window, it
19240 will not start any media.
19241 (-[WebView viewWillMoveToWindow:]): Call setCanStartMedia(false) when moving
19242 to a window of nil.
19243 (-[WebView viewDidMoveToWindow]): Call setCanStartMedia(true) when moved to
19244 a window that is non-nil.
19246 2010-02-16 Eric Carlson <eric.carlson@apple.com>
19248 Reviewed by Simon Fraser.
19250 https://bugs.webkit.org/show_bug.cgi?id=34988
19251 WebHTMLView.mm has two -willRemoveSubview: methods
19253 * WebView/WebHTMLView.mm:
19254 (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method.
19256 2010-02-16 Alexey Proskuryakov <ap@apple.com>
19258 Reviewed by Geoffrey Garen and Kevin Decker.
19260 https://bugs.webkit.org/show_bug.cgi?id=34989
19261 <rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content
19263 This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited
19264 in the former case, and adjustCursor in the latter).
19266 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
19267 (-[WebHostedNetscapePluginView handleMouseEntered:]):
19268 (-[WebHostedNetscapePluginView handleMouseExited:]):
19269 * Plugins/WebBaseNetscapePluginView.h:
19270 * Plugins/WebBaseNetscapePluginView.mm:
19271 (-[WebBaseNetscapePluginView handleMouseEntered:]):
19272 (-[WebBaseNetscapePluginView handleMouseExited:]):
19273 * Plugins/WebNetscapePluginView.h:
19274 * Plugins/WebNetscapePluginView.mm:
19275 (-[WebNetscapePluginView handleMouseEntered:]):
19276 (-[WebNetscapePluginView handleMouseExited:]):
19277 AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to
19278 notify plug-in views of mouse entered/exited as part of DOM event dispatch.
19280 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides
19281 mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event
19282 handler. Other mouse events are passed down by EventHandler.
19284 2010-02-15 Alexey Proskuryakov <ap@apple.com>
19286 More build fixing (for what is actually a 64-bit failure, as 32-bit apparently includes
19287 headers that aren't included in 64-bit).
19289 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
19290 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19291 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::contains):
19292 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
19293 Move inline functions to .cpp; also made the class Noncopyable.
19295 2010-02-15 Alexey Proskuryakov <ap@apple.com>
19297 Mac release build fix attempt.
19299 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
19300 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19301 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::~LocalObjectMap):
19302 Implement destructor in .cpp file, where necessary headers are already included.
19304 2010-02-12 Alexey Proskuryakov <ap@apple.com>
19306 Reviewed by Kevin Decker.
19308 <rdar://problem/7130641> Browser objects identity is not preserved by Safari
19310 Out of process part.
19312 To avoid excessive IPC, plugin process doesn't send each NPObject release/retain call to
19313 Safari. It only sends one when the last one is removed, and it can destroy the proxy
19316 However, the browser may be sending the same object out to plug-in as a function call
19317 argument at the same time - neither side can know what the other one is up to. The solution
19318 is to make the "destroying object" call return a boolean result, making it possible for
19319 the browser to make plugin host keep the proxy with zero refcount for a little longer.
19321 * Plugins/Hosted/NetscapePluginHostProxy.mm:
19322 (WKPCForgetBrowserObject): This function (that used to be named ReleaseObject) is only
19323 called when plug-in releases all of its references, so renamed it. Its boolean result
19324 is returned as call success or failure.
19326 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
19327 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap): Made the numeric ID to JSObject map
19330 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19331 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): This method is tricky
19332 in that it creates objects with refcount of 1, but doesn't increase refcount when returning
19333 found objects. This extra count accounts for the "reference" kept by plugin process.
19334 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): Only retaining for the
19335 duration of calls out to plug-in, which means that refcount is almost always equal to 1.
19336 Note that we can't use "++" here, due to how std::pair works!
19337 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): Ditto.
19338 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::clear): Clear all references when
19340 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Like release(), but only
19341 functional when recount is 1 (meaning that the object is not being sent out to plug-in at
19343 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Updated for other changes.
19344 (WebKit::NetscapePluginInstanceProxy::cleanup): Ditto.
19345 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): Ditto.
19346 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): Ditto.
19347 (WebKit::NetscapePluginInstanceProxy::forgetBrowserObjectID): Ditto.
19348 (WebKit::NetscapePluginInstanceProxy::evaluate): Ditto.
19349 (WebKit::NetscapePluginInstanceProxy::invoke): Ditto.
19350 (WebKit::NetscapePluginInstanceProxy::invokeDefault): Ditto.
19351 (WebKit::NetscapePluginInstanceProxy::construct): Ditto.
19352 (WebKit::NetscapePluginInstanceProxy::getProperty): Ditto.
19353 (WebKit::NetscapePluginInstanceProxy::setProperty): Ditto.
19354 (WebKit::NetscapePluginInstanceProxy::removeProperty): Ditto.
19355 (WebKit::NetscapePluginInstanceProxy::hasProperty): Ditto.
19356 (WebKit::NetscapePluginInstanceProxy::hasMethod): Ditto.
19357 (WebKit::NetscapePluginInstanceProxy::enumerate): Ditto.
19358 (WebKit::NetscapePluginInstanceProxy::addValueToArray): Ditto.
19359 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
19360 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Helper for calling retain when
19361 making calls out to plug-in. No-op for objects that aren't wrapped to be sent (i.e. for
19362 objects wrapping ProxyInstance wrappers for plug-in objects being sent bak).
19363 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
19365 * Plugins/Hosted/ProxyInstance.mm:
19366 (WebKit::ProxyInstance::invoke): Retain/release arguments during call.
19367 (WebKit::ProxyInstance::setFieldValue): Ditto.
19369 * Plugins/Hosted/WebKitPluginClient.defs: Renamed PCReleaseObject to PCForgetBrowserObject.
19371 2010-02-12 Darin Adler <darin@apple.com>
19373 Reviewed by Sam Weinig.
19375 Removed unneeded custom implementation of isDescendantOf.
19377 * Plugins/WebBaseNetscapePluginView.mm:
19378 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Use the
19379 -[NSView isDescendantOf:] method instead of our own method
19380 named superviewsHaveSuperviews.
19382 2010-02-12 Dan Bernstein <mitz@apple.com>
19384 Reviewed by Darin Adler.
19386 <rdar://problem/7615234> REGRESSION (r48586): Loading an HTML page causes
19387 PDFKit to be loaded
19389 * WebView/WebPDFDocumentExtras.h: Removed the category declaration and
19390 addWebPDFDocumentExtras(). Declare allScriptsInPDFDocument().
19391 * WebView/WebPDFDocumentExtras.mm:
19392 (allScriptsInPDFDocument): Changed the -_web_allScripts method into this function.
19393 * WebView/WebPDFRepresentation.mm: Removed +initialize.
19394 (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use
19395 allScriptsInPDFDocument() instead of -_web_allScripts.
19397 2010-02-10 Geoffrey Garen <ggaren@apple.com>
19399 Reviewed by Oliver Hunt.
19401 Exported some new JavaScript heap introspection.
19403 * Misc/WebCoreStatistics.h:
19404 * Misc/WebCoreStatistics.mm:
19405 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Just like
19406 javaScriptProtectedObjectTypeCounts, except this function enumerates all
19407 live objects, not just protected objects.
19409 2010-02-08 Maciej Stachowiak <mjs@apple.com>
19411 Reviewed by Cameron Zwarich.
19413 Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
19414 https://bugs.webkit.org/show_bug.cgi?id=34698
19416 * Configurations/FeatureDefines.xcconfig:
19418 2010-02-09 Alexey Proskuryakov <ap@apple.com>
19420 Reviewed by Geoffrey Garen.
19422 https://bugs.webkit.org/show_bug.cgi?id=34490
19423 WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions
19425 * ForwardingHeaders/wtf/ValueCheck.h: Added.
19427 2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
19429 Reviewed by Kenneth Rohde Christiansen.
19431 Support frameset flattening
19432 https://bugs.webkit.org/show_bug.cgi?id=32717
19434 Add support for enabling/disabling FrameSet Flattening on the Mac port.
19436 * WebView/WebPreferenceKeysPrivate.h:
19437 * WebView/WebPreferences.mm:
19438 (+[WebPreferences initialize]):
19439 (-[WebPreferences isFrameSetFlatteningEnabled]):
19440 (-[WebPreferences setFrameSetFlatteningEnabled:]):
19441 * WebView/WebPreferencesPrivate.h:
19442 * WebView/WebView.mm:
19443 (-[WebView _preferencesChangedNotification:]):
19445 2010-02-09 Alexey Proskuryakov <ap@apple.com>
19447 Reviewed by Anders Carlsson.
19449 https://bugs.webkit.org/show_bug.cgi?id=34771
19450 A stray mouse moved event is sent to plug-ins after mouse exit
19452 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): A mouseout
19453 DOM event is dispatched while handling NSMouseMoved - but we shouldn't be sending a
19454 mouse moved event to plug-ins at this point.
19456 2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
19458 Reviewed by Darin Adler.
19460 Provide a way to get total number of pages to be printed
19461 https://bugs.webkit.org/show_bug.cgi?id=34699
19463 * Misc/WebCoreStatistics.h:
19464 * Misc/WebCoreStatistics.mm:
19465 (-[WebFrame numberOfPages:pageWidthInPixels:]):
19467 2010-02-08 Alexey Proskuryakov <ap@apple.com>
19469 Reviewed by Darin Adler.
19471 https://bugs.webkit.org/show_bug.cgi?id=34727
19472 Assertion crashes and freezes when plug-in property access results in an exception
19474 * Plugins/Hosted/WebKitPluginClient.defs: Made PCSetProperty and PCRemoveProperty async.
19475 A plug-in can call back whil processing this call (e.g. for NPN_SetException), so we need
19476 to listen for messages while waiting for reply.
19478 * Plugins/Hosted/NetscapePluginHostProxy.mm:
19479 (WKPCEvaluate): If there is no instance proxy, return KERN_FAILURE. This improves consistency
19480 between method implementations, and leaves us with one less IPC call to make in failure case
19481 (returning false with KERN_SUCCESS and returning KERN_FAILURE looks the same from plugin
19483 (WKPCInvoke): Ditto.
19484 (WKPCInvokeDefault): Ditto.
19485 (WKPCGetProperty): Ditto.
19486 (WKPCSetProperty): Send a reply once done.
19487 (WKPCRemoveProperty): Ditto.
19488 (WKPCHasProperty): If there is no instance proxy, return KERN_FAILURE.
19489 (WKPCHasMethod): Ditto.
19490 (WKPCEnumerate): Ditto.
19492 2010-02-08 Alexey Proskuryakov <ap@apple.com>
19494 Reviewed by Anders Carlsson.
19496 <rdar://problem/6530010> OOP: Support NPN_SetException
19498 Tested by plugins/netscape-throw-exception.html (removed it from skipped list).
19500 * Plugins/Hosted/NetscapePluginHostProxy.mm:
19501 (WKPCSetException):
19502 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
19503 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19504 (WebKit::globalExceptionString):
19505 (WebKit::NetscapePluginInstanceProxy::setGlobalException):
19506 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
19507 * Plugins/Hosted/ProxyInstance.mm:
19508 (WebKit::ProxyInstance::invoke):
19509 (WebKit::ProxyInstance::getPropertyNames):
19510 (WebKit::ProxyInstance::fieldValue):
19511 (WebKit::ProxyInstance::setFieldValue):
19512 * Plugins/Hosted/WebKitPluginClient.defs:
19513 Route exception string to a global that's checked after calling into plug-in (just like in
19516 2010-02-05 Kevin Decker <kdecker@apple.com>
19518 Reviewed by Mark Rowe.
19520 https://bugs.webkit.org/show_bug.cgi?id=34661
19521 <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden
19523 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
19524 (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
19525 * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
19526 * Plugins/WebBaseNetscapePluginView.mm:
19527 (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView.
19528 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
19529 * Plugins/WebNetscapePluginView.mm:
19530 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
19532 2010-02-04 Mark Rowe <mrowe@apple.com>
19534 Rubber-stamped by Dan Bernstein.
19536 Fix the ability to #include <WebKit/DOMFile.h>.
19538 * MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
19540 2010-02-04 John Sullivan <sullivan@apple.com>
19542 https://bugs.webkit.org/show_bug.cgi?id=34611
19543 WebLocalizedString() could use an assertion that it is being called on the main thread
19545 Reviewed by Tim Hatcher.
19547 * Misc/WebLocalizableStrings.m: Removed.
19548 * Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
19549 Renamed to use .mm extension so it can include a C++ header.
19550 (WebLocalizedString):
19551 Added an assertion that this is being called on the main thread.
19553 2010-02-04 Dan Bernstein <mitz@apple.com>
19555 Reviewed by Simon Fraser.
19557 REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
19558 https://bugs.webkit.org/show_bug.cgi?id=34371
19560 * WebView/WebFrameView.mm:
19561 (-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
19562 constants, and cap the scroll distance.
19563 (-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
19564 cScrollbarPixelsPerLineStep.
19565 (-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
19566 constants, and cap the scroll distance.
19568 2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
19570 Reviewed by Eric Seidel.
19572 Provide a way to get page number with layoutTestController
19573 https://bugs.webkit.org/show_bug.cgi?id=33840
19575 * Misc/WebCoreStatistics.h:
19576 * Misc/WebCoreStatistics.mm:
19577 (-[WebFrame pageNumberForElement:element:pageWidth:]):
19579 2010-01-29 Gavin Barraclough <barraclough@apple.com>
19581 Reviewed by Sam Weinig + Oliver Hunt.
19583 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
19585 Pass processeing user gensture flag to media play/pause methods.
19587 * WebView/WebVideoFullscreenHUDWindowController.mm:
19588 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
19590 2010-02-01 Dan Bernstein <mitz@apple.com>
19592 Reviewed by Anders Carlsson.
19594 <rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()
19596 The crash was caused by having two streams with a streamID of 1.
19598 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19599 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
19600 correctly increments m_currentURLRequestID to account for the manual stream.
19601 (WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
19602 null it out instead of trying to remove it from the map. Added an assertion.
19603 (WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.
19605 == Rolled over to ChangeLog-2010-01-29 ==