1 2012-07-29 Rik Cabanier <cabanier@adobe.com>
3 Add ENABLE_CSS_COMPOSITING flag
4 https://bugs.webkit.org/show_bug.cgi?id=92553
6 Reviewed by Dirk Schulze.
8 Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
10 * Configurations/FeatureDefines.xcconfig:
12 2012-07-27 Anders Carlsson <andersca@apple.com>
14 Show the unavailable plug-in indicator for Java applets as well
15 https://bugs.webkit.org/show_bug.cgi?id=92521
17 Reviewed by Sam Weinig.
19 Check if the Java plug-in is blocked before trying to instantiate it.
21 * WebCoreSupport/WebFrameLoaderClient.mm:
23 2012-07-25 Jer Noble <jer.noble@apple.com>
25 Add setting to enable and disable diagnostic logging.
26 https://bugs.webkit.org/show_bug.cgi?id=92337
28 Reviewed by Anders Carlsson.
30 Add a WebKit WebPreferences API to set set the WebCore diagnosticLoggingEnabled setting.
32 * WebView/WebPreferenceKeysPrivate.h:
33 * WebView/WebPreferences.mm:
34 (+[WebPreferences initialize]): Register the default value to false.
35 (-[WebPreferences diagnosticLoggingEnabled]): Simple userDefaults accessor.
36 (-[WebPreferences setDiagnosticLoggingEnabled:]): Ditto.
37 * WebView/WebPreferencesPrivate.h:
39 (-[WebView _preferencesChanged:]): Ensure this preference is propagated to Settings
40 whenever the preferences change.
42 2012-07-25 Pratik Solanki <psolanki@apple.com>
44 Remove catchesDelegateExceptions from WebViewData and related accessor methods
45 https://bugs.webkit.org/show_bug.cgi?id=90898
47 Reviewed by Darin Adler.
49 Remove catchesDelegateException ivar from WebViewData and all its accesor methods from
50 WebView. All uses of this flag in WebKit set it to YES and no one calls
51 _setCatchesDelegateExceptions with NO.
53 * WebCoreSupport/WebDragClient.mm:
54 (WebDragClient::startDrag):
55 * WebView/WebDelegateImplementationCaching.mm:
57 (CallDelegateReturningFloat):
58 (CallDelegateReturningBoolean):
59 (CallResourceLoadDelegateReturningBoolean):
61 (CallFormDelegateReturningBoolean):
63 (-[WebView _commonInitializationWithFrameName:groupName:]):
64 (-[WebView _policyDelegateForwarder]):
65 (-[WebView _UIDelegateForwarder]):
66 (-[WebView _editingDelegateForwarder]):
67 (-[_WebSafeForwarder initWithTarget:defaultTarget:]):
68 (-[_WebSafeForwarder forwardInvocation:]):
69 * WebView/WebViewData.h:
70 * WebView/WebViewPrivate.h:
72 2012-07-23 Simon Fraser <simon.fraser@apple.com>
74 Part 2 of: Implement sticky positioning
75 https://bugs.webkit.org/show_bug.cgi?id=90046
77 Reviewed by Ojan Vafai.
79 Turn on ENABLE_CSS_STICKY_POSITION.
81 * Configurations/FeatureDefines.xcconfig:
83 2012-07-23 Pierre Rossi <pierre.rossi@gmail.com>
85 Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
86 https://bugs.webkit.org/show_bug.cgi?id=91006
88 Reviewed by Ryosuke Niwa.
90 Remove numTouchEventHandlersChanged stub.
92 * WebCoreSupport/WebChromeClient.h:
94 2012-07-23 Simon Fraser <simon.fraser@apple.com>
96 Part 1 of: Implement sticky positioning
97 https://bugs.webkit.org/show_bug.cgi?id=90046
99 Reviewed by Ojan Vafai.
101 Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.
103 Sort the ENABLE_CSS lines in the file. Make sure all the flags
104 are in FEATURE_DEFINES.
106 * Configurations/FeatureDefines.xcconfig:
108 2012-07-23 Kent Tamura <tkent@chromium.org>
110 Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
111 https://bugs.webkit.org/show_bug.cgi?id=91941
113 Reviewed by Kentaro Hara.
115 A flag name for an elmement should be ENABLE_*_ELEMENT.
117 * Configurations/FeatureDefines.xcconfig:
119 2012-07-22 Kent Tamura <tkent@chromium.org>
121 Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
122 https://bugs.webkit.org/show_bug.cgi?id=91928
124 Reviewed by Kentaro Hara.
126 A flag name for an elmement should be ENABLE_*_ELEMENT.
128 * Configurations/FeatureDefines.xcconfig:
130 2012-07-20 Kent Tamura <tkent@chromium.org>
132 Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT
133 https://bugs.webkit.org/show_bug.cgi?id=91846
135 Reviewed by Kentaro Hara.
137 A flag name for an elmement should be ENABLE_*_ELEMENT.
139 * Configurations/FeatureDefines.xcconfig:
141 2012-07-18 Benjamin Poulain <bpoulain@apple.com>
143 [Mac] Make WebDataSourcePrivate lighter
144 https://bugs.webkit.org/show_bug.cgi?id=91511
146 Reviewed by Anders Carlsson.
148 Make WebDataSourcePrivate a simple C++ class and use smart pointers for memory management.
150 Since the "loader" attribute is only set on initialization, all the assertions spread in
151 various function are removed in favor of assertions on initialization.
153 * WebView/WebDataSource.h:
154 * WebView/WebDataSource.mm:
155 (WebDataSourcePrivate):
156 (WebDataSourcePrivate::WebDataSourcePrivate):
157 (WebDataSourcePrivate::~WebDataSourcePrivate):
158 Use a class instead of a Objective-C object for WebDataSourcePrivate.
159 Use smart pointers instead of ref counting manually.
161 (-[WebDataSource _setRepresentation:]):
162 (-[WebDataSource _addSubframeArchives:]):
163 (-[WebDataSource _transferApplicationCache:]):
164 (-[WebDataSource _setDeferMainResourceDataLoad:]):
165 (-[WebDataSource _documentFragmentWithArchive:]):
166 (-[WebDataSource _initWithDocumentLoader:]):
168 (+[WebDataSource initialize]):
169 (-[WebDataSource dealloc]):
170 (-[WebDataSource finalize]):
171 WebDataSource takes the special initialization and destruction that was done in WebDataSourcePrivate.
173 (-[WebDataSource representation]):
175 2012-07-17 Vivek Galatage <vivekgalatage@gmail.com>
177 Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
178 https://bugs.webkit.org/show_bug.cgi?id=91196
180 Reviewed by Pavel Feldman.
182 Refactoring InspectorClients. InspectorClient::openInspectorFrontend
183 now returning the InspectorFrontendChannel.
185 * WebCoreSupport/WebInspectorClient.h:
186 (WebInspectorClient):
187 * WebCoreSupport/WebInspectorClient.mm:
188 (WebInspectorClient::openInspectorFrontend):
190 2012-07-17 David Barr <davidbarr@chromium.org>
192 Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
193 https://bugs.webkit.org/show_bug.cgi?id=89055
195 Reviewed by Kent Tamura.
197 The css3-images module is at candidate recommendation.
198 http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
200 Add a configuration option for CSS image-orientation support, disabling it by default.
202 * Configurations/FeatureDefines.xcconfig:
204 2012-07-15 Joseph Pecoraro <pecoraro@apple.com>
206 Fix case sensitive build issue.
208 Unreviewed build fix.
210 * WebView/WebPreferences.mm:
212 2012-07-15 Benjamin Poulain <benjamin@webkit.org>
214 Make WebPreferencesPrivate a simple struct
215 https://bugs.webkit.org/show_bug.cgi?id=91330
217 Reviewed by Filip Pizlo.
219 To avoid taking time creating a new Objective-C object for WebPreferencesPrivate, we can just make
222 * WebView/WebPreferences.h:
223 * WebView/WebPreferences.mm:
224 (WebPreferencesPrivate):
225 (WebPreferencesPrivate::WebPreferencesPrivate):
226 Replace the Objective-C WebPreferencesPrivate by a struct.
227 Remove IBCreatorID from the object as it is unused.
228 Use RetainPtr for the Objective-C attribute to avoid tracking their memory manually.
230 (-[WebPreferences initWithIdentifier:]):
231 Change the order of the initialization to avoid allocating anyting if a WebPreferences exists
233 Both [NSObject init] and WebPreferencesPrivate allocation are moved after the fast path.
235 (-[WebPreferences initWithCoder:]):
236 (-[WebPreferences encodeWithCoder:]):
237 (-[WebPreferences dealloc]):
238 (-[WebPreferences identifier]):
239 (-[WebPreferences _valueForKey:]):
240 (-[WebPreferences _setStringValue:forKey:]):
241 (-[WebPreferences _setIntegerValue:forKey:]):
242 (-[WebPreferences _setFloatValue:forKey:]):
243 (-[WebPreferences _setBoolValue:forKey:]):
244 (-[WebPreferences _setLongLongValue:forKey:]):
245 (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
247 2012-07-14 Benjamin Poulain <bpoulain@apple.com>
249 [Mac] Do not try to update the cache model for every WebPreferences change
250 https://bugs.webkit.org/show_bug.cgi?id=91302
252 Reviewed by Joseph Pecoraro.
254 WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases,
255 we can just listen to updates of the CacheModel property.
257 * WebView/WebPreferences.mm:
258 (-[WebPreferences initWithIdentifier:]):
259 (-[WebPreferences _postCacheModelChangedNotification]):
260 (-[WebPreferences setCacheModel:]):
261 * WebView/WebPreferencesPrivate.h:
262 * WebView/WebView.mm:
263 (+[WebView initialize]):
264 (+[WebView _cacheModelChangedNotification:]):
266 2012-07-14 Sheriff Bot <webkit.review.bot@gmail.com>
268 Unreviewed, rolling out r122665.
269 http://trac.webkit.org/changeset/122665
270 https://bugs.webkit.org/show_bug.cgi?id=91321
272 Broke Mac builds (Requested by rniwa on #webkit).
274 * WebView/WebPreferences.mm:
275 (-[WebPreferences initWithIdentifier:]):
276 (-[WebPreferences setCacheModel:]):
277 * WebView/WebPreferencesPrivate.h:
278 * WebView/WebView.mm:
279 (+[WebView initialize]):
280 (+[WebView _preferencesChangedNotification:]):
282 2012-07-13 Benjamin Poulain <bpoulain@apple.com>
284 [Mac] Do not try to update the cache model for every WebPreferences change
285 https://bugs.webkit.org/show_bug.cgi?id=91302
287 Reviewed by Joseph Pecoraro.
289 WebView was listening to any change on any WebPreferences in order to update the cache model. This is unneeded in most cases,
290 we can just listen to updates of the CacheModel property.
292 * WebView/WebPreferences.mm:
293 (-[WebPreferences initWithIdentifier:]):
294 (-[WebPreferences _postCacheModelChangedNotification]):
295 (-[WebPreferences setCacheModel:]):
296 * WebView/WebPreferencesPrivate.h:
297 * WebView/WebView.mm:
298 (+[WebView initialize]):
299 (+[WebView _cacheModelChangedNotification:]):
301 2012-07-11 Mark Rowe <mrowe@apple.com>
303 Fix a logic error in the #if so that the correct code is compiled on Snow Leopard.
305 I introduced this in r122403 when I inverted the sense of the #if.
307 * WebView/WebFullScreenController.mm:
309 2012-07-11 Mark Rowe <mrowe@apple.com>
311 <http://webkit.org/b/91024> Build against the latest SDK when targeting older OS X versions.
313 Reviewed by Dan Bernstein.
315 The deployment target is already set to the version that we're targeting, and it's that setting
316 which determines which functionality from the SDK is available to us.
318 * Configurations/Base.xcconfig:
320 2012-07-11 Mark Rowe <mrowe@apple.com>
322 <http://webkit.org/b/91022> WebFullScreenController and WKFullScreenWindowController shouldn't add unprefixed methods to AppKit classes
324 Reviewed by Dan Bernstein.
326 * WebView/WebFullScreenController.mm:
327 (convertRectToScreen): Add a static helper method that calls through to -[NSWindow convertRectToScreen:] on OS versions where it exists
328 but otherwise provides a compatibility implementation of it.
329 (-[WebFullScreenController enterFullScreen:]): Call our new helper.
331 2012-07-11 Mark Rowe <mrowe@apple.com>
333 <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros
335 This removal was handled by a script that translates the relevant macros in to the equivalent checks
336 using the system availability macros.
338 Reviewed by Filip Pizlo.
340 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
341 * Misc/WebKitErrors.m:
342 * Misc/WebNSControlExtras.m:
343 * Misc/WebNSFileManagerExtras.mm:
344 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
345 * Plugins/WebBaseNetscapePluginView.mm:
346 * Plugins/WebNetscapePluginView.mm:
347 * WebCoreSupport/WebChromeClient.mm:
348 * WebCoreSupport/WebEditorClient.mm:
349 * WebCoreSupport/WebFrameLoaderClient.mm:
350 * WebCoreSupport/WebSystemInterface.mm:
351 * WebView/WebClipView.mm:
352 * WebView/WebDynamicScrollBarsView.mm:
353 * WebView/WebFrameView.mm:
354 * WebView/WebFullScreenController.mm:
355 * WebView/WebHTMLView.mm:
356 * WebView/WebHTMLViewInternal.h:
357 * WebView/WebPDFDocumentExtras.mm:
358 * WebView/WebPreferences.mm:
359 * WebView/WebResourceInternal.h:
360 * WebView/WebScriptDebugDelegate.h:
361 * WebView/WebView.mm:
362 * WebView/WebViewPrivate.h:
364 2012-07-11 Anders Carlsson <andersca@apple.com>
366 Add -Wtautological-compare and -Wsign-compare warning flags
367 https://bugs.webkit.org/show_bug.cgi?id=90994
369 Reviewed by Mark Rowe.
371 * Configurations/Base.xcconfig:
373 2012-07-11 Mark Rowe <mrowe@apple.com>
375 Add a Mountain Lion version of libWebKitSystemInterface.a.
377 Reviewed by John Sullivan.
379 * Configurations/DebugRelease.xcconfig: Look for the library under its expected name.
381 2012-07-10 Adam Barth <abarth@webkit.org>
383 WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed
384 https://bugs.webkit.org/show_bug.cgi?id=90910
386 Reviewed by Eric Seidel.
388 * WebView/WebPreferences.mm:
389 (+[WebPreferences initialize]):
390 (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
391 (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
392 * WebView/WebView.mm:
393 (-[WebView _preferencesChanged:]):
395 2012-07-09 Matt Falkenhagen <falken@chromium.org>
397 Add ENABLE_DIALOG_ELEMENT and skeleton files
398 https://bugs.webkit.org/show_bug.cgi?id=90521
400 Reviewed by Kent Tamura.
402 * Configurations/FeatureDefines.xcconfig:
404 2012-07-09 Yongjun Zhang <yongjun_zhang@apple.com>
406 Consider closing unused localStorage database after a timeout.
407 https://bugs.webkit.org/show_bug.cgi?id=90713
409 For a localStorage, if there is no active document referencing to it for certain amount of time (300 seconds),
410 we can close the underlying sqlite database.
412 Reviewed by Brady Eidson.
414 * Storage/WebStorageManager.mm:
415 (+[WebStorageManager setStorageDatabaseIdleInterval:]): add a new method for DumpRenderTree to set the timeout
416 that we will wait before closing database.
417 (initializeLocalStoragePath):
418 * Storage/WebStorageManagerPrivate.h:
420 2012-07-09 Sheriff Bot <webkit.review.bot@gmail.com>
422 Unreviewed, rolling out r122107.
423 http://trac.webkit.org/changeset/122107
424 https://bugs.webkit.org/show_bug.cgi?id=90794
426 Build failure on Mac debug bots (Requested by falken_ on
429 * Configurations/FeatureDefines.xcconfig:
431 2012-07-09 Matt Falkenhagen <falken@chromium.org>
433 Add ENABLE_DIALOG_ELEMENT and skeleton files
434 https://bugs.webkit.org/show_bug.cgi?id=90521
436 Reviewed by Kent Tamura.
438 * Configurations/FeatureDefines.xcconfig:
440 2012-07-04 John Mellor <johnme@chromium.org>
442 Text Autosizing: Add compile flag and runtime setting
443 https://bugs.webkit.org/show_bug.cgi?id=87394
445 This patch renames Font Boosting to Text Autosizing.
447 Reviewed by Adam Barth.
449 * Configurations/FeatureDefines.xcconfig:
451 2012-07-02 Benjamin Poulain <bpoulain@apple.com>
453 Do not do any logging initialization when logging is disabled
454 https://bugs.webkit.org/show_bug.cgi?id=90228
456 Reviewed by Simon Fraser.
458 * Misc/WebIconDatabase.mm:
459 (-[WebIconDatabase _scaleIcon:toSize:]):
460 * Misc/WebKitLogging.h:
461 * Misc/WebKitLogging.m:
462 * WebView/WebHTMLView.mm:
463 (-[WebHTMLView _attributeStringFromDOMRange:]):
464 * WebView/WebView.mm:
465 (-[WebView _commonInitializationWithFrameName:groupName:]):
467 2012-07-01 Timothy Hatcher <timothy@apple.com>
469 Make the "Inspect Element" context menu item appear in nightly builds again.
471 rdar://problem/11702613
472 https://webkit.org/b/89323
474 Reviewed by Dan Bernstein.
476 * WebView/WebUIDelegatePrivate.h:
477 Add missing enums that were added in ContextMenuItem.h but left out here.
479 2012-06-29 Sheriff Bot <webkit.review.bot@gmail.com>
481 Unreviewed, rolling out r121529.
482 http://trac.webkit.org/changeset/121529
483 https://bugs.webkit.org/show_bug.cgi?id=90260
485 Failed to compile on Chromium WebKitMacBuilder (Requested by
488 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
489 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
490 * Misc/WebNSControlExtras.m:
491 (-[NSControl sizeToFitAndAdjustWindowHeight]):
492 * WebCoreSupport/WebEditorClient.mm:
493 (WebEditorClient::shouldEraseMarkersAfterChangeSelection):
494 (WebEditorClient::getGuessesForWord):
495 * WebCoreSupport/WebFrameLoaderClient.mm:
496 (WebFrameLoaderClient::dispatchDidFirstLayout):
497 (WebFrameLoaderClient::provisionalLoadStarted):
498 * WebCoreSupport/WebSystemInterface.mm:
499 (InitWebCoreSystemInterface):
500 * WebView/WebDynamicScrollBarsView.mm:
501 (-[WebDynamicScrollBarsView scrollWheel:]):
502 * WebView/WebFullScreenController.mm:
503 (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
504 (-[WebFullScreenController exitFullScreen]):
505 * WebView/WebHTMLView.mm:
506 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
507 * WebView/WebView.mm:
508 (+[WebView initialize]):
509 (-[WebView _deviceScaleFactor]):
511 2012-06-29 Eric Seidel <eric@webkit.org>
513 Remove more BUILDING_ON_LEOPARD branches now that no port builds on Leopard
514 https://bugs.webkit.org/show_bug.cgi?id=90252
516 Reviewed by Ryosuke Niwa.
518 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
519 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
520 * Misc/WebNSControlExtras.m:
521 (-[NSControl sizeToFitAndAdjustWindowHeight]):
522 * WebCoreSupport/WebEditorClient.mm:
523 (WebEditorClient::shouldEraseMarkersAfterChangeSelection):
524 (WebEditorClient::getGuessesForWord):
525 * WebCoreSupport/WebFrameLoaderClient.mm:
526 (WebFrameLoaderClient::dispatchDidFirstLayout):
527 (WebFrameLoaderClient::provisionalLoadStarted):
528 * WebCoreSupport/WebSystemInterface.mm:
529 (InitWebCoreSystemInterface):
530 * WebView/WebDynamicScrollBarsView.mm:
531 (-[WebDynamicScrollBarsView scrollWheel:]):
532 * WebView/WebFullScreenController.mm:
533 (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
534 (-[WebFullScreenController exitFullScreen]):
535 * WebView/WebHTMLView.mm:
536 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
537 * WebView/WebView.mm:
538 (+[WebView initialize]):
539 (-[WebView _deviceScaleFactor]):
541 2012-06-25 Mark Hahnenberg <mhahnenberg@apple.com>
543 JSLock should be per-JSGlobalData
544 https://bugs.webkit.org/show_bug.cgi?id=89123
546 Reviewed by Geoffrey Garen.
548 Changed all sites that used JSLock to instead use the new JSLockHolder
549 and pass in the correct JS context that the code is about to interact with that
550 needs protection. Also added a couple JSLocks to places that didn't already
551 have it that needed it.
553 * DOM/WebDOMOperations.mm:
555 * Misc/WebCoreStatistics.mm:
556 (+[WebCoreStatistics javaScriptObjectsCount]):
557 (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
558 (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
559 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
560 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
561 (+[WebCoreStatistics javaScriptObjectTypeCounts]):
562 (+[WebCoreStatistics shouldPrintExceptions]):
563 (+[WebCoreStatistics setShouldPrintExceptions:]):
564 (+[WebCoreStatistics memoryStatistics]):
565 (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
566 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
567 (WebKit::NetscapePluginInstanceProxy::evaluate):
568 (WebKit::NetscapePluginInstanceProxy::invoke):
569 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
570 (WebKit::NetscapePluginInstanceProxy::construct):
571 (WebKit::NetscapePluginInstanceProxy::getProperty):
572 (WebKit::NetscapePluginInstanceProxy::setProperty):
573 (WebKit::NetscapePluginInstanceProxy::removeProperty):
574 (WebKit::NetscapePluginInstanceProxy::hasMethod):
575 (WebKit::NetscapePluginInstanceProxy::enumerate):
576 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
577 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
578 * Plugins/WebNetscapePluginStream.mm:
579 (WebNetscapePluginStream::wantsAllStreams):
580 * Plugins/WebNetscapePluginView.mm:
581 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
582 (-[WebNetscapePluginView privateBrowsingModeDidChange]):
583 (-[WebNetscapePluginView setWindowIfNecessary]):
584 (-[WebNetscapePluginView createPluginScriptableObject]):
585 (-[WebNetscapePluginView getFormValue:]):
586 (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
587 (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
588 (-[WebNetscapePluginView loadPluginRequest:]):
589 (-[WebNetscapePluginView _printedPluginBitmap]):
590 * Plugins/WebPluginController.mm:
591 (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
592 (-[WebPluginController stopOnePlugin:]):
593 (-[WebPluginController destroyOnePlugin:]):
594 (-[WebPluginController startAllPlugins]):
595 (-[WebPluginController addPlugin:]):
596 * WebView/WebFrame.mm:
597 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
598 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
599 * WebView/WebScriptDebugDelegate.mm:
600 (-[WebScriptCallFrame scopeChain]):
601 (-[WebScriptCallFrame evaluateWebScript:]):
602 * WebView/WebView.mm:
603 (+[WebView _reportException:inContext:]):
604 (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
605 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
607 2012-06-23 Sheriff Bot <webkit.review.bot@gmail.com>
609 Unreviewed, rolling out r121058.
610 http://trac.webkit.org/changeset/121058
611 https://bugs.webkit.org/show_bug.cgi?id=89809
613 Patch causes plugins tests to crash in GTK debug builds
614 (Requested by zdobersek on #webkit).
616 * DOM/WebDOMOperations.mm:
618 * Misc/WebCoreStatistics.mm:
619 (+[WebCoreStatistics javaScriptObjectsCount]):
620 (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
621 (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
622 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
623 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
624 (+[WebCoreStatistics javaScriptObjectTypeCounts]):
625 (+[WebCoreStatistics shouldPrintExceptions]):
626 (+[WebCoreStatistics setShouldPrintExceptions:]):
627 (+[WebCoreStatistics memoryStatistics]):
628 (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
629 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
630 (WebKit::NetscapePluginInstanceProxy::evaluate):
631 (WebKit::NetscapePluginInstanceProxy::invoke):
632 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
633 (WebKit::NetscapePluginInstanceProxy::construct):
634 (WebKit::NetscapePluginInstanceProxy::getProperty):
635 (WebKit::NetscapePluginInstanceProxy::setProperty):
636 (WebKit::NetscapePluginInstanceProxy::removeProperty):
637 (WebKit::NetscapePluginInstanceProxy::hasMethod):
638 (WebKit::NetscapePluginInstanceProxy::enumerate):
639 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
640 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
641 * Plugins/WebNetscapePluginStream.mm:
642 (WebNetscapePluginStream::wantsAllStreams):
643 * Plugins/WebNetscapePluginView.mm:
644 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
645 (-[WebNetscapePluginView privateBrowsingModeDidChange]):
646 (-[WebNetscapePluginView setWindowIfNecessary]):
647 (-[WebNetscapePluginView createPluginScriptableObject]):
648 (-[WebNetscapePluginView getFormValue:]):
649 (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
650 (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
651 (-[WebNetscapePluginView loadPluginRequest:]):
652 (-[WebNetscapePluginView _printedPluginBitmap]):
653 * Plugins/WebPluginController.mm:
654 (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
655 (-[WebPluginController stopOnePlugin:]):
656 (-[WebPluginController destroyOnePlugin:]):
657 (-[WebPluginController startAllPlugins]):
658 (-[WebPluginController addPlugin:]):
659 * WebView/WebFrame.mm:
660 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
661 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
662 * WebView/WebScriptDebugDelegate.mm:
663 (-[WebScriptCallFrame scopeChain]):
664 (-[WebScriptCallFrame evaluateWebScript:]):
665 * WebView/WebView.mm:
666 (+[WebView _reportException:inContext:]):
667 (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
668 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
670 2012-06-22 Alexandru Chiculita <achicu@adobe.com>
672 [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
673 https://bugs.webkit.org/show_bug.cgi?id=89781
675 Reviewed by Dean Jackson.
677 Added ENABLE_CSS_SHADERS flag as enabled by default on Safari for Mac.
679 * Configurations/FeatureDefines.xcconfig:
681 2012-06-20 Mark Hahnenberg <mhahnenberg@apple.com>
683 JSLock should be per-JSGlobalData
684 https://bugs.webkit.org/show_bug.cgi?id=89123
686 Reviewed by Gavin Barraclough.
688 Changed all sites that used JSLock to instead use the new JSLockHolder
689 and pass in the correct JS context that the code is about to interact with that
692 * DOM/WebDOMOperations.mm:
694 * Misc/WebCoreStatistics.mm:
695 (+[WebCoreStatistics javaScriptObjectsCount]):
696 (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
697 (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
698 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
699 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
700 (+[WebCoreStatistics javaScriptObjectTypeCounts]):
701 (+[WebCoreStatistics shouldPrintExceptions]):
702 (+[WebCoreStatistics setShouldPrintExceptions:]):
703 (+[WebCoreStatistics memoryStatistics]):
704 (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
705 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
706 (WebKit::NetscapePluginInstanceProxy::evaluate):
707 (WebKit::NetscapePluginInstanceProxy::invoke):
708 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
709 (WebKit::NetscapePluginInstanceProxy::construct):
710 (WebKit::NetscapePluginInstanceProxy::getProperty):
711 (WebKit::NetscapePluginInstanceProxy::setProperty):
712 (WebKit::NetscapePluginInstanceProxy::removeProperty):
713 (WebKit::NetscapePluginInstanceProxy::hasMethod):
714 (WebKit::NetscapePluginInstanceProxy::enumerate):
715 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
716 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
717 * Plugins/WebNetscapePluginStream.mm:
718 (WebNetscapePluginStream::wantsAllStreams):
719 * Plugins/WebNetscapePluginView.mm:
720 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
721 (-[WebNetscapePluginView privateBrowsingModeDidChange]):
722 (-[WebNetscapePluginView setWindowIfNecessary]):
723 (-[WebNetscapePluginView createPluginScriptableObject]):
724 (-[WebNetscapePluginView getFormValue:]):
725 (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
726 (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
727 (-[WebNetscapePluginView loadPluginRequest:]):
728 (-[WebNetscapePluginView _printedPluginBitmap]):
729 * Plugins/WebPluginController.mm:
730 (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
731 (-[WebPluginController stopOnePlugin:]):
732 (-[WebPluginController destroyOnePlugin:]):
733 (-[WebPluginController startAllPlugins]):
734 (-[WebPluginController addPlugin:]):
735 * WebView/WebFrame.mm:
736 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
737 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
738 * WebView/WebScriptDebugDelegate.mm:
739 (-[WebScriptCallFrame scopeChain]):
740 (-[WebScriptCallFrame evaluateWebScript:]):
741 * WebView/WebView.mm:
742 (+[WebView _reportException:inContext:]):
743 (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
744 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
746 2012-06-22 Amy Ousterhout <aousterh@chromium.org>
748 Renamed DeviceOrientation to DeviceOrientationData
749 https://bugs.webkit.org/show_bug.cgi?id=88663
751 Reviewed by Steve Block.
753 Updated files to use the renamed DeviceOrientationData instead of DeviceOrientation.
754 This change makes DeviceOrientationData consistent with DeviceMotionData.
755 * WebCoreSupport/WebDeviceOrientationClient.h:
756 (WebDeviceOrientationClient):
757 * WebCoreSupport/WebDeviceOrientationClient.mm:
758 (WebDeviceOrientationClient::lastOrientation):
759 * WebView/WebDeviceOrientation.mm:
760 * WebView/WebDeviceOrientationInternal.h:
762 2012-06-20 Garret Kelly <gdk@chromium.org>
764 Moving cookieEnabled/setCookieEnabled from Page to Settings.
765 https://bugs.webkit.org/show_bug.cgi?id=89545
767 Reviewed by Adam Barth.
769 * WebView/WebView.mm:
770 (-[WebView _cookieEnabled]):
771 (-[WebView _setCookieEnabled:]):
773 2012-06-19 Dan Bernstein <mitz@apple.com>
775 WebKit/mac part of: Paginated display API doesn’t allow setting the page progression direction
776 https://bugs.webkit.org/show_bug.cgi?id=89394
778 Reviewed by Darin Adler.
780 * WebView/WebView.mm:
781 (-[WebView _setPaginationMode:]): Changed to map new WebPaginationMode values to new
782 Pagination::Mode values.
783 (-[WebView _paginationMode]): Similarly, in the opposite direction.
784 * WebView/WebViewPrivate.h: Replaced WebPaginationMode values with ones that specify an
785 axis and a direction along that axis.
787 2012-06-18 Andy Estes <aestes@apple.com>
789 [Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems
790 https://bugs.webkit.org/show_bug.cgi?id=89434
792 Reviewed by Darin Adler.
794 * WebView/WebPDFView.mm:
795 (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Release copied
796 NSMenuItems once they're stored in copiedItems.
798 2012-06-19 Mike West <mkwst@chromium.org>
800 Introduce ENABLE_CSP_NEXT configuration flag.
801 https://bugs.webkit.org/show_bug.cgi?id=89300
803 Reviewed by Adam Barth.
805 The 1.0 draft of the Content Security Policy spec is just about to
806 move to Last Call. We'll hide work on the upcoming 1.1 spec behind
807 this ENABLE flag, disabled by default.
809 Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
811 * Configurations/FeatureDefines.xcconfig:
813 2012-06-14 Jia Pu <jpu@apple.com>
815 Mark text with text alternative with blue underline.
816 https://bugs.webkit.org/show_bug.cgi?id=83047
818 Reviewed by Enrica Casucci.
820 Changes in WebKit include implementation of new functions declared in AlternativeTextClient,
821 and logic for calling Editor::insertDictatedText() instead of Editor::insertText() when there's
822 alternatives attached to the input string.
824 * WebCoreSupport/CorrectionPanel.mm:
825 (correctionIndicatorType):
826 (CorrectionPanel::handleAcceptedReplacement):
827 * WebCoreSupport/WebAlternativeTextClient.h:
828 (WebAlternativeTextClient):
829 * WebCoreSupport/WebAlternativeTextClient.mm:
830 (WebAlternativeTextClient::showCorrectionAlternative):
831 (WebAlternativeTextClient::dismissAlternative):
832 (WebAlternativeTextClient::dismissAlternativeSoon):
833 (WebAlternativeTextClient::recordAutocorrectionResponse):
834 (WebAlternativeTextClient::removeDictationAlternatives):
835 (WebAlternativeTextClient::showDictationAlternativeUI):
836 (WebAlternativeTextClient::dismissDictationAlternativeUI):
837 (WebAlternativeTextClient::dictationAlternatives):
838 * WebView/WebHTMLView.mm:
839 (-[WebHTMLView validAttributesForMarkedText]):
840 (-[WebHTMLView insertText:]):
841 * WebView/WebView.mm:
842 (-[WebView handleAcceptedAlternativeText:]):
843 (-[WebView _getWebCoreDictationAlternatives:fromTextAlternatives:]):
844 (-[WebView _showDictationAlternativeUI:WebCore::forDictationContext:]):
845 (-[WebView _dismissDictationAlternativeUI]):
846 (-[WebView _removeDictationAlternatives:]):
847 (-[WebView _dictationAlternatives:]):
848 * WebView/WebViewData.h:
849 * WebView/WebViewData.mm:
850 (-[WebViewPrivate init]):
851 * WebView/WebViewInternal.h:
852 * WebView/WebViewPrivate.h:
854 2012-06-11 Alexis Menard <alexis.menard@openbossa.org>
856 [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
857 https://bugs.webkit.org/show_bug.cgi?id=88804
859 Reviewed by Tony Chang.
861 Protect box-decoration-break behind a feature flag enabled by default.
863 * Configurations/FeatureDefines.xcconfig:
865 2012-06-11 Sam Weinig <sam@webkit.org>
867 Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
868 https://bugs.webkit.org/show_bug.cgi?id=88723
870 Reviewed by Dan Bernstein.
872 * WebView/WebFrame.mm:
873 * WebView/WebFramePrivate.h:
874 Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]
876 2012-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
878 Unreviewed, rolling out r119955.
879 http://trac.webkit.org/changeset/119955
880 https://bugs.webkit.org/show_bug.cgi?id=88758
882 Breaks Chromium compile - Chromium depends on removed API
883 (Requested by dominicc on #webkit).
885 * WebView/WebFrame.mm:
886 (-[WebFrame _setIsDisconnected:]):
887 (-[WebFrame _setExcludeFromTextSearch:]):
888 * WebView/WebFramePrivate.h:
890 2012-06-10 Sam Weinig <sam@webkit.org>
892 Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
893 https://bugs.webkit.org/show_bug.cgi?id=88723
895 Reviewed by Dan Bernstein.
897 * WebView/WebFrame.mm:
898 * WebView/WebFramePrivate.h:
899 Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]
901 2012-06-09 Sukolsak Sakshuwong <sukolsak@google.com>
903 Add UNDO_MANAGER flag
904 https://bugs.webkit.org/show_bug.cgi?id=87908
906 Reviewed by Tony Chang.
908 * Configurations/FeatureDefines.xcconfig:
910 2012-06-07 Kentaro Hara <haraken@chromium.org>
912 Reduce Node object size from 72 byte to 64 byte
913 https://bugs.webkit.org/show_bug.cgi?id=88528
915 Reviewed by Ryosuke Niwa.
917 Added a symbol for callRemovedLastRef().
921 2012-06-06 Andy Estes <aestes@apple.com>
923 Wrap uppercaseWord, lowercaseWord, and capitalizeWord with USE(APPKIT)
924 https://bugs.webkit.org/show_bug.cgi?id=88504
926 Reviewed by Dan Bernstein.
928 uppercaseWord, lowercaseWord, and capitalizeWord are methods declared
929 by NSResponder that subclasses are expected to implement. WebKit should
930 only support these implementations on platforms that use AppKit.
932 * WebCoreSupport/WebEditorClient.h:
933 * WebCoreSupport/WebEditorClient.mm:
935 2012-06-05 Anders Carlsson <andersca@apple.com>
939 * WebCoreSupport/WebFrameLoaderClient.mm:
940 (WebFrameLoaderClient::createPlugin):
941 The error constant has been renamed.
943 2012-06-05 Anders Carlsson <andersca@apple.com>
945 Rename a plug-in loading error constant
946 https://bugs.webkit.org/show_bug.cgi?id=88381
947 <rdar://problem/11602601>
949 Reviewed by Sam Weinig.
951 * Misc/WebKitErrors.h:
953 2012-06-05 Dongwoo Im <dw.im@samsung.com>
955 Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
956 https://bugs.webkit.org/show_bug.cgi?id=73176
958 Reviewed by Adam Barth.
960 Two more APIs are added in Custom Scheme Handler specification.
961 http://dev.w3.org/html5/spec/Overview.html#custom-handlers
962 One is 'isProtocolHandlerRegistered' to query whether the specific URL
963 is registered or not.
964 The other is 'unregisterProtocolHandler' to remove the registered URL.
966 * Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
968 2012-06-04 David Kilzer <ddkilzer@apple.com>
970 BUILD FIX: FeatureDefines.xcconfig should match across projects
972 * Configurations/FeatureDefines.xcconfig:
973 - Fix sort order of ENABLE_CSS3_FLEXBOX.
974 - Fix typo in ENABLE_FONT_BOOSTING.
975 - Add missing ENABLE_LEGACY_CSS_VENDOR_PREFIXES.
977 2012-06-02 Yongjun Zhang <yongjun_zhang@apple.com>
979 loadRequest should check for empty URLs.
980 https://bugs.webkit.org/show_bug.cgi?id=88154
982 In [WebFrame loadRequest], if the url is invalid and not nil, we transform it to file: url.
983 However, WebKit client could send down an empty URL that makes us transform it to file: url
984 as well. We should skip that as we did for nil URLs.
986 Reviewed by Brady Eidson.
988 * WebView/WebFrame.mm:
989 (-[WebFrame loadRequest:]):
991 2012-06-01 Michael Saboff <msaboff@apple.com>
993 WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
994 https://bugs.webkit.org/show_bug.cgi?id=88109
996 Reviewed by Geoffrey Garen.
998 Added short circuit return when the NSString to evaluate is nil.
1000 * WebView/WebFrame.mm:
1001 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1002 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
1004 2012-05-31 Hajime Morrita <morrita@chromium.org>
1006 REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
1007 https://bugs.webkit.org/show_bug.cgi?id=86859
1009 Reviewed by Ryosuke Niwa.
1011 * WebCoreSupport/WebEditorClient.h:
1012 * WebCoreSupport/WebEditorClient.mm:
1013 (-[WebEditorSpellCheckResponder initWithClient:sequence:results:]):
1014 (-[WebEditorSpellCheckResponder perform]):
1015 (WebEditorClient::didCheckSucceeded):
1016 (WebEditorClient::requestCheckingOfString):
1018 2012-05-31 Andy Estes <aestes@apple.com>
1020 Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC)
1021 https://bugs.webkit.org/show_bug.cgi?id=87933
1023 Reviewed by Dan Bernstein.
1025 * WebCoreSupport/WebEditorClient.h:
1026 * WebCoreSupport/WebEditorClient.mm:
1028 2012-05-29 David Barr <davidbarr@chromium.org>
1030 Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1031 https://bugs.webkit.org/show_bug.cgi?id=87685
1033 Reviewed by Eric Seidel.
1035 Add a configuration option for CSS image-resolution support, disabling it by default.
1037 * Configurations/FeatureDefines.xcconfig:
1039 2012-05-29 Nikolas Zimmermann <nzimmermann@rim.com>
1041 SVGViewSpec DOM bindings aka SVGSVGElement.currentView is unimplemented
1042 https://bugs.webkit.org/show_bug.cgi?id=15495
1044 Reviewed by Rob Buis.
1046 * MigrateHeaders.make: Copy DOMSVGViewSpec*.h headers.
1048 2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
1050 WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
1051 https://bugs.webkit.org/show_bug.cgi?id=42328
1053 Reviewed by Eric Seidel.
1055 * WebInspector/WebInspector.mm:
1056 (-[WebInspector setJavaScriptProfilingEnabled:]):
1058 2012-05-24 Tim Horton <timothy_horton@apple.com>
1060 Add feature defines for web-facing parts of CSS Regions and Exclusions
1061 https://bugs.webkit.org/show_bug.cgi?id=87442
1062 <rdar://problem/10887709>
1064 Reviewed by Dan Bernstein.
1066 * Configurations/FeatureDefines.xcconfig:
1068 2012-05-24 John Mellor <johnme@chromium.org>
1070 Font Boosting: Add compile flag and runtime setting
1071 https://bugs.webkit.org/show_bug.cgi?id=87394
1073 Reviewed by Adam Barth.
1075 Add ENABLE_FONT_BOOSTING.
1077 * Configurations/FeatureDefines.xcconfig:
1079 2012-05-23 Ojan Vafai <ojan@chromium.org>
1081 add back the ability to disable flexbox
1082 https://bugs.webkit.org/show_bug.cgi?id=87147
1084 Reviewed by Tony Chang.
1086 * Configurations/FeatureDefines.xcconfig:
1088 2012-05-22 Tim Horton <timothy_horton@apple.com>
1090 Add a quirk for applications that depend on the relative ordering of progressCompleted/didFinishLoad
1091 https://bugs.webkit.org/show_bug.cgi?id=87178
1092 <rdar://problem/11468434>
1094 Reviewed by Maciej Stachowiak.
1096 Add plumbing for the quirk to flip the relative ordering of progressCompleted/didFinishLoad back
1097 to the behavior before http://trac.webkit.org/changeset/94105. Make it apply to any Mail.app linked
1098 against WebKit before that revision.
1100 * Misc/WebKitVersionChecks.h:
1101 * WebView/WebView.mm:
1102 (-[WebView _needsDidFinishLoadOrderQuirk]):
1103 (-[WebView _preferencesChanged:]):
1105 2012-05-21 Gavin Barraclough <barraclough@apple.com>
1107 Disable private names by default in WebCore
1108 https://bugs.webkit.org/show_bug.cgi?id=87088
1110 Reviewed by Geoff Garen.
1112 r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.
1113 These are probably not yet ready to be web-facing, so disabling by default in WebCore.
1114 Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.
1116 * WebView/WebPreferenceKeysPrivate.h:
1117 * WebView/WebPreferences.mm:
1118 (+[WebPreferences initialize]):
1119 (-[WebPreferences setJavaScriptExperimentsEnabled:]):
1120 (-[WebPreferences javaScriptExperimentsEnabled]):
1121 * WebView/WebPreferencesPrivate.h:
1122 * WebView/WebView.mm:
1123 (-[WebView _preferencesChanged:]):
1124 - Added JavaScriptExperimentsEnabled to WebPreferences.
1126 2012-05-15 Gavin Barraclough <barraclough@apple.com>
1128 Add support for private names
1129 https://bugs.webkit.org/show_bug.cgi?id=86509
1131 Reviewed by Oliver Hunt.
1133 The spec isn't final, but we can start adding support to allow property maps
1134 to contain keys that aren't identifiers.
1136 * Plugins/Hosted/ProxyInstance.mm:
1137 (WebKit::ProxyClass::methodsNamed):
1138 (WebKit::ProxyClass::fieldNamed):
1139 (WebKit::ProxyInstance::getMethod):
1140 (WebKit::ProxyInstance::methodsNamed):
1141 (WebKit::ProxyInstance::fieldNamed):
1142 - Removed PropertyName::impl(), call publicName() to get the string associated with a name.
1144 2012-05-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1146 Move setEditingBehavior() from layoutTestController to window.internals
1147 https://bugs.webkit.org/show_bug.cgi?id=42689
1149 Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
1151 Remove Mac private API to get/set the editing behavior, since it was only there
1155 * WebView/WebFrame.mm:
1156 * WebView/WebFrameInternal.h:
1157 * WebView/WebPreferenceKeysPrivate.h:
1158 * WebView/WebPreferences.mm:
1159 (+[WebPreferences initialize]):
1160 * WebView/WebPreferencesPrivate.h:
1161 * WebView/WebView.mm:
1162 (-[WebView _preferencesChanged:]):
1164 2012-05-20 Ryosuke Niwa <rniwa@webkit.org>
1166 Using createContextualFragment to insert a <script> does not cause the script to execute
1167 https://bugs.webkit.org/show_bug.cgi?id=12234
1169 Reviewed by Adam Barth.
1171 Renamed FragmentScriptingNotAllowed to DisallowScriptingContent.
1173 * WebView/WebFrame.mm:
1174 (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
1176 2012-05-19 Andy Estes <aestes@apple.com>
1178 Fix build errors found when disabling ENABLE_DRAG_SUPPORT
1179 https://bugs.webkit.org/show_bug.cgi?id=86947
1181 Reviewed by Jon Honeycutt.
1183 * WebCoreSupport/WebDragClient.h:
1184 * WebCoreSupport/WebDragClient.mm:
1185 * WebView/WebFrame.mm:
1186 * WebView/WebFrameInternal.h:
1187 * WebView/WebFrameView.mm:
1188 (-[WebFrameView _setDocumentView:]):
1189 * WebView/WebHTMLView.mm:
1190 (-[WebHTMLView acceptsFirstMouse:]):
1191 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
1192 (matchesExtensionOrEquivalent):
1193 * WebView/WebView.mm:
1194 (-[WebView _commonInitializationWithFrameName:groupName:]):
1195 (-[WebView moveDragCaretToPoint:]):
1196 (-[WebView removeDragCaret]):
1198 2012-04-27 Filip Pizlo <fpizlo@apple.com>
1200 DFG should have control flow graph simplification
1201 https://bugs.webkit.org/show_bug.cgi?id=84553
1203 Reviewed by Oliver Hunt.
1205 Merged r115512 from dfgopt.
1207 JSValue::toBoolean(ExecState*) -> JSValue::toBoolean()
1209 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1210 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
1212 2012-05-18 Tony Chang <tony@chromium.org>
1214 remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
1215 https://bugs.webkit.org/show_bug.cgi?id=86767
1217 Reviewed by Ojan Vafai.
1219 * Configurations/FeatureDefines.xcconfig:
1220 * WebView/WebPreferenceKeysPrivate.h:
1221 * WebView/WebPreferences.mm:
1222 (+[WebPreferences initialize]):
1223 (-[WebPreferences cssGridLayoutEnabled]):
1224 (-[WebPreferences setCSSGridLayoutEnabled:]):
1225 * WebView/WebPreferencesPrivate.h:
1226 * WebView/WebView.mm:
1227 (-[WebView _preferencesChanged:]):
1229 2012-05-18 MORITA Hajime <morrita@google.com>
1231 Another unreviewed attempt to fix build breakage on r117572.
1233 * WebCoreSupport/WebEditorClient.h:
1235 2012-05-18 MORITA Hajime <morrita@google.com>
1237 https://bugs.webkit.org/show_bug.cgi?id=85515
1238 Stale frame in WebCore::SpellChecker::didCheckSucceeded
1240 Reviewed by Ryosuke Niwa.
1242 * WebCoreSupport/WebEditorClient.h:
1244 2012-05-17 Andy Estes <aestes@apple.com>
1246 Don't let -[CALayer renderInContext:] try to render WebView's root layer
1247 https://bugs.webkit.org/show_bug.cgi?id=86773
1248 <rdar://problem/10950075>
1250 Reviewed by Dan Bernstein.
1252 -[CALayer renderInContext:] doesn't correctly render our layer tree, so
1253 don't let it try. Calling drawRect: with a bitmap context will already
1254 do the right thing for WebViews.
1256 * WebView/WebHTMLView.mm: Create a subclass of CALayer called WebLayerHostingLayer.
1257 (-[WebLayerHostingLayer renderInContext:]): override renderInContext: to be a NOOP.
1258 (-[WebHTMLView attachRootLayer:]): Create a WebLayerHostingLayer rather than a CALayer.
1260 2012-05-17 Hironori Bono <hbono@chromium.org>
1262 [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
1263 https://bugs.webkit.org/show_bug.cgi?id=86591
1265 Reviewed by Ryosuke Niwa.
1267 This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
1268 function to remove platform-specific code from Editor::respondToChangedSelection
1271 No new tests, no change in behavior.
1273 * WebCoreSupport/WebEditorClient.h:
1274 * WebCoreSupport/WebEditorClient.mm:
1275 (WebEditorClient::shouldEraseMarkersAfterChangeSelection):
1277 2012-05-17 Dan Bernstein <mitz@apple.com>
1279 REGRESSION (r117428): WebKit API/SPI was removed
1280 https://bugs.webkit.org/show_bug.cgi?id=86748
1285 * WebView/WebView.mm:
1286 (+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
1287 * WebView/WebViewPrivate.h:
1289 2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1291 Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
1292 https://bugs.webkit.org/show_bug.cgi?id=86704
1294 Reviewed by Eric Seidel.
1296 Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
1297 cross-port way through the InternalSettings interface.
1300 * WebView/WebView.mm:
1301 * WebView/WebViewPrivate.h:
1303 2012-05-15 Anders Carlsson <andersca@apple.com>
1305 Use unaccelerated scrolling deltas when rubber-banding
1306 https://bugs.webkit.org/show_bug.cgi?id=86503
1307 <rdar://problem/11378742>
1309 Reviewed by Sam Weinig.
1311 * WebCoreSupport/WebSystemInterface.mm:
1312 (InitWebCoreSystemInterface):
1313 Init new WKSI functions.
1315 2012-05-14 Luke Macpherson <macpherson@chromium.org>
1317 Introduce ENABLE_CSS_VARIABLES compile flag.
1318 https://bugs.webkit.org/show_bug.cgi?id=86338
1320 Reviewed by Dimitri Glazkov.
1322 Add a configuration option for CSS Variables support, disabling it by default.
1324 * Configurations/FeatureDefines.xcconfig:
1326 2012-05-14 Michael Saboff <msaboff@apple.com>
1328 Enh: Add the Ability to Disable / Enable JavaScript GC Timer
1329 https://bugs.webkit.org/show_bug.cgi?id=86382
1331 Reviewed by Darin Adler.
1333 Plumbing to set / clear JS GC activity timer enable flag.
1335 * Misc/WebCoreStatistics.h:
1336 * Misc/WebCoreStatistics.mm:
1337 (+[WebCoreStatistics setJavaScriptGarbageCollectorTimerEnabled:]):
1339 2012-05-11 Gavin Barraclough <barraclough@apple.com>
1341 Introduce PropertyName class
1342 https://bugs.webkit.org/show_bug.cgi?id=86241
1344 Reviewed by Geoff Garen.
1346 Replace 'const Identifier&' arguments to functions accessing object properties with a new 'PropertyName' type.
1347 This change paves the way to allow for properties keyed by values that are not Identifiers.
1349 This change is largely a mechanical find & replace.
1350 It also changes JSFunction's constructor to take a UString& instead of an Identifier&
1351 (since in some cases we can no longer guarantee that we'lll have an Identifier), and
1352 unifies Identifier's methods to obtain array indices onto PropertyName.
1354 The new PropertyName class retains the ability to support .impl() and .ustring(), but
1355 in a future patch we may need to rework this, since not all PropertyNames should be
1356 equal based on their string representation.
1358 * Plugins/Hosted/ProxyInstance.h:
1360 * Plugins/Hosted/ProxyInstance.mm:
1362 (WebKit::ProxyClass::methodsNamed):
1363 (WebKit::ProxyClass::fieldNamed):
1364 (WebKit::ProxyRuntimeMethod::create):
1365 (WebKit::ProxyRuntimeMethod::finishCreation):
1366 (WebKit::ProxyInstance::getMethod):
1367 (WebKit::ProxyInstance::methodsNamed):
1368 (WebKit::ProxyInstance::fieldNamed):
1370 2012-05-11 Brady Eidson <beidson@apple.com>
1372 <rdar://problem/11361907> and https://bugs.webkit.org/show_bug.cgi?id=86265
1373 REGRESSION(r104885): Images missing from printed YummySoup! recipes
1375 We thought clients were passing paths as URLs.
1376 It turns out it was more likely they were passing file: URLs with the file: scheme removed.
1377 And that jives perfectly with the behavior change caused by r104885.
1379 Reviewed by Alexey Proskuryakov.
1381 Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrSchemelessFileURL, and change it
1382 to create the new URL simply by appending "file:":
1383 * Misc/WebNSURLExtras.h:
1384 * Misc/WebNSURLExtras.mm:
1385 (-[NSURL _webkit_URLFromURLOrSchemelessFileURL]):
1387 * WebView/WebFrame.mm:
1388 (-[WebFrame loadRequest:]): Create the fixed url simply by appending "file:" to the
1389 existing URL string.
1390 (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
1391 (-[WebFrame loadHTMLString:baseURL:]):
1392 (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]):
1394 2012-05-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1396 Move resumeAnimations to use Internals interface
1397 https://bugs.webkit.org/show_bug.cgi?id=86063
1399 Reviewed by Alexey Proskuryakov.
1401 Remove resumeAnimations functions, because it is able to work in the
1402 cross-port way through the Internals interface.
1405 * WebView/WebFrame.mm:
1406 * WebView/WebFramePrivate.h:
1408 2012-05-10 Anders Carlsson <andersca@apple.com>
1410 WebKit1: Add a way to blacklist specific plug-ins/plug-in versions
1411 https://bugs.webkit.org/show_bug.cgi?id=86150
1412 <rdar://problem/9551196>
1414 Reviewed by Sam Weinig.
1416 * Misc/WebKitErrors.h:
1417 Add WebKitErrorInsecurePlugInVersion enum.
1419 * Plugins/WebBasePluginPackage.h:
1420 * Plugins/WebBasePluginPackage.mm:
1421 (-[WebBasePluginPackage bundleIdentifier]):
1422 (-[WebBasePluginPackage bundleVersion]):
1423 Add bundleIdentifier and bundleVersion getters.
1425 * WebCoreSupport/WebFrameLoaderClient.mm:
1426 (WebFrameLoaderClient::createPlugin):
1427 Check if the plug-in is blocked. If it is, set the unavailability reason and the error code.
1429 2012-05-10 Anders Carlsson <andersca@apple.com>
1431 Rename the missing plug-in indicator to the unavailable plug-in indicator
1432 https://bugs.webkit.org/show_bug.cgi?id=86136
1434 Reviewed by Sam Weinig.
1436 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1437 (-[WebHostedNetscapePluginView pluginHostDied]):
1438 * WebCoreSupport/WebChromeClient.h:
1439 * WebCoreSupport/WebChromeClient.mm:
1440 (WebChromeClient::shouldUnavailablePluginMessageBeButton):
1441 (WebChromeClient::unavailablePluginButtonClicked):
1443 2012-05-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1445 Move suspendAnimations to use Internals interface.
1446 https://bugs.webkit.org/show_bug.cgi?id=85986
1448 Reviewed by Ryosuke Niwa.
1450 Remove suspendAnimations functions, because it is able to work in the
1451 cross-port way through the Internals interface.
1454 * WebView/WebFrame.mm:
1455 * WebView/WebFramePrivate.h:
1457 2012-05-08 Kent Tamura <tkent@chromium.org>
1459 Fixe Chromium build, and add a FIXME comment about a layering violation.
1461 * WebCoreSupport/WebSystemInterface.mm:
1462 (InitWebCoreSystemInterface):
1464 2012-05-08 Jon Lee <jonlee@apple.com>
1466 Safari warns that it needs to resend the form in an iFrame when going back
1467 https://bugs.webkit.org/show_bug.cgi?id=82658
1468 <rdar://problem/11292558>
1470 Reviewed by Darin Adler.
1472 * WebCoreSupport/WebSystemInterface.mm:
1473 (InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.
1475 2012-05-08 Timothy Hatcher <timothy@apple.com>
1477 Fix the SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL macro so it passes the full path to dlopen.
1479 <rdar://problem/11406517>
1481 Reviewed by Mark Rowe.
1483 * WebCoreSupport/WebInspectorClient.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.
1485 2012-05-07 Andy Estes <aestes@apple.com>
1487 ENABLE_IFRAME_SEAMLESS should be part of FEATURE_DEFINES.
1489 * Configurations/FeatureDefines.xcconfig:
1491 2012-05-07 Eric Seidel <eric@webkit.org>
1493 Add ENABLE_IFRAME_SEAMLESS so Apple can turn off SEAMLESS if needed
1494 https://bugs.webkit.org/show_bug.cgi?id=85822
1496 Reviewed by Adam Barth.
1498 * Configurations/FeatureDefines.xcconfig:
1500 2012-05-05 Dean Jackson <dino@apple.com>
1502 Add new Setting/Preference to disable requestAnimationFrame
1503 https://bugs.webkit.org/show_bug.cgi?id=85693
1505 Reviewed by Simon Fraser.
1507 Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
1508 The default value is true. The majority of applications will leave
1511 * WebView/WebPreferenceKeysPrivate.h:
1512 * WebView/WebPreferences.mm:
1513 (+[WebPreferences initialize]):
1514 (-[WebPreferences requestAnimationFrameEnabled]):
1515 (-[WebPreferences setRequestAnimationFrameEnabled:]):
1516 * WebView/WebPreferencesPrivate.h:
1517 * WebView/WebView.mm:
1518 (-[WebView _preferencesChanged:]):
1520 2012-05-04 Jer Noble <jer.noble@apple.com>
1522 REGRESSION (r116127-r116165): 6 tests failing on Lion Debug (Tests)
1523 https://bugs.webkit.org/show_bug.cgi?id=85674
1525 Reviewed by Oliver Hunt.
1527 Null check the results of core([frame DOMDocument]).
1529 * WebView/WebView.mm:
1530 (-[WebView _didStartProvisionalLoadForFrame:]):
1532 2012-05-02 Jer Noble <jer.noble@apple.com>
1534 Taking a visibility:hidden element full screen causes full screen window to disappear.
1535 https://bugs.webkit.org/show_bug.cgi?id=85432
1537 Reviewed by Maciej Stachowiak.
1539 When given an initial or final frame with a zero width or height, return a rect representing
1540 the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
1541 confuse the window server when it's instructed to scale the full screen window to that size.
1543 * WebView/WebFullScreenController.mm:
1544 (windowFrameFromApparentFrames):
1546 2012-05-04 Jer Noble <jer.noble@apple.com>
1548 Full screen will exit during a provisional load of a non-ancestor iframe.
1549 https://bugs.webkit.org/show_bug.cgi?id=85230
1551 Reviewed by Maciej Stachowiak .
1553 Only exit full screen mode if the frame being loaded contains the full
1556 * WebView/WebView.mm:
1557 (-[WebView _didStartProvisionalLoadForFrame:]): Give the UIDelegate a first crack at handling the
1558 request to close the full screen window when a provisional load occurs.
1560 2012-05-04 Jer Noble <jer.noble@apple.com>
1562 Move WebKitFullScreenListener into its own file.
1563 https://bugs.webkit.org/show_bug.cgi?id=85640
1565 Reviewed by Maciej Stachowiak.
1567 Move WebKitFullScreenListener into its own file, so it can be used by multiple classes.
1569 * WebCoreSupport/WebKitFullScreenListener.h: Added.
1570 * WebCoreSupport/WebKitFullScreenListener.mm: Added.
1571 (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
1572 (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
1573 (-[WebKitFullScreenListener webkitWillExitFullScreen]):
1574 (-[WebKitFullScreenListener webkitDidExitFullScreen]):
1575 * WebCoreSupport/WebChromeClient.mm:
1577 2012-05-04 Brady Eidson <beidson@apple.com>
1579 <rdar://problem/11312853> and https://bugs.webkit.org/show_bug.cgi?id=85635
1580 Exception in [WebFrame loadRequest:] breaks some WebKit apps
1582 Reviewed by Alexey Proskuryakov.
1584 Some API clients pass in nil requests or requests with nil URLs.
1585 In r112571 we started rewriting these URLs resulting in an exception.
1586 Since we've supported nil requests until now, we should not try to rewrite these URLs.
1588 * WebView/WebFrame.mm:
1589 (-[WebFrame loadRequest:]): Don't try to rewrite invalid URLs if they are also null.
1591 2012-05-04 Nate Chapin <japhet@chromium.org>
1593 Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
1594 https://bugs.webkit.org/show_bug.cgi?id=85533
1596 Reviewed by Alexey Proskuryakov.
1598 * WebView/WebHTMLRepresentation.mm:
1599 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Calling commitData when finishing is no longer necessary,
1600 as WebCore will take care of simulating the receipt of data and ensuring the requisite work gets done in the blank document case.
1602 2012-05-03 Anders Carlsson <andersca@apple.com>
1604 useWebKitWebInspector should be more robust against missing files
1605 https://bugs.webkit.org/show_bug.cgi?id=85563
1606 <rdar://problem/11373948>
1608 Reviewed by Dan Bernstein.
1610 * WebCoreSupport/WebInspectorClient.mm:
1611 (useWebKitWebInspector):
1613 2012-05-03 Tobias Netzel <tobias.netzel@googlemail.com>
1615 Bugs in WebFullScreenController
1616 https://bugs.webkit.org/show_bug.cgi?id=85388
1618 Reviewed by Alexey Proskuryakov.
1620 Leopard specific fixes:
1621 NSWindow doesn't respond to isOnActiveSpace so find out first.
1622 Values passed to SetSystemUIMode were swapped.
1624 * WebView/WebFullScreenController.mm:
1625 (-[WebFullScreenController exitFullScreen]):
1626 (-[WebFullScreenController _updateMenuAndDockForFullScreen]):
1628 2012-05-02 Jon Lee <jonlee@apple.com>
1630 Migrate permission functions to Notification from NotificationCenter
1631 https://bugs.webkit.org/show_bug.cgi?id=80485
1632 <rdar://problem/10965458>
1634 Reviewed by Jian Li.
1636 * WebCoreSupport/WebNotificationClient.h: *
1637 WebCoreSupport/WebNotificationClient.mm: Add a separate callback
1638 variable depending on the notifications API enabled.
1639 (WebNotificationClient::requestPermission): Add
1640 NotificationPermissionCallback version of the same
1641 function. And refactor common code into private function.
1642 (-[WebNotificationPolicyListener initWithCallback:]): Refactor to
1643 take the NotificationPermissionCallback as a parameter.
1644 (-[WebNotificationPolicyListener initWithVoidCallback:]): Add new
1645 init method to handle legacy API.
1646 (-[WebNotificationPolicyListener allow]): Invoke the callback for
1647 both variables. If only one of the APIs is enabled, we are
1648 guaranteed that the relevant callback variable exists. If both
1649 APIs are supported, it is possible that _voidCallback will be nil
1650 if the callback is NotificationPermissionCallback, so we need the
1651 extra pointer check.
1652 (-[WebNotificationPolicyListener deny]): Ditto.
1654 2012-05-02 Eric Seidel <eric@webkit.org>
1656 Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate)
1657 https://bugs.webkit.org/show_bug.cgi?id=85433
1659 Reviewed by Adam Barth.
1661 I have a script which can autogenerate these xcconfig files as well as the
1662 vsprops files (and soon the Chromium, cmake, gnumake and qmake) feature lists
1663 from a central feature list file.
1664 In preparation for posting such a tool, I'm re-sorting these xcconfig files to be
1665 alphabetically ordered (currently they're close, but not quite).
1666 There is also at least one inconsistency between these files (CSS_LEGACY_PREFIXES) which
1667 I will fix in a second pass. I will also sort the FEATURE_DEFINES = line in a follow-up patch.
1669 * Configurations/FeatureDefines.xcconfig:
1671 2012-04-18 Jon Honeycutt <jhoneycutt@apple.com>
1673 FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
1674 information about the form being submitted
1675 https://bugs.webkit.org/show_bug.cgi?id=84297
1677 Reviewed by Andy Estes.
1679 * WebCoreSupport/WebFrameLoaderClient.h:
1680 Updated method declaration.
1682 2012-05-01 Jon Honeycutt <jhoneycutt@apple.com>
1684 Make Page::setDefersLoading() have a call count so that each time
1685 loading is deferred, it must be balanced with a call to resume.
1686 https://bugs.webkit.org/show_bug.cgi?id=84522
1688 Reviewed by Andy Estes.
1690 * WebView/WebPreferenceKeysPrivate.h:
1691 Declare a new key for this preference.
1693 * WebView/WebPreferences.mm:
1694 (+[WebPreferences initialize]):
1695 Initialize new preference to NO.
1696 (-[WebPreferences setWantsBalancedSetDefersLoadingBehavior:]):
1698 (-[WebPreferences wantsBalancedSetDefersLoadingBehavior]):
1701 * WebView/WebPreferencesPrivate.h:
1702 Declare setter and getter.
1704 * WebView/WebView.mm:
1705 (-[WebView _preferencesChanged:]):
1706 Set the setting from the WebPreferences object's value.
1708 2012-05-01 Jeffrey Pfau <jpfau@apple.com>
1710 <rdar://problem/10422318> Support for web content filter delegate for filtering https content
1711 https://bugs.webkit.org/show_bug.cgi?id=85300
1713 Reviewed by Alexey Proskuryakov.
1715 * WebCoreSupport/WebSystemInterface.mm:
1716 (InitWebCoreSystemInterface):
1718 2012-05-01 Ryosuke Niwa <rniwa@webkit.org>
1720 *Command.h files shouldn't be exported to WebKit layer
1721 https://bugs.webkit.org/show_bug.cgi?id=74778
1723 Reviewed by Eric Seidel.
1725 * WebView/WebFrame.mm:
1726 (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
1728 2012-04-28 Geoffrey Garen <ggaren@apple.com>
1730 Clarified JSGlobalData (JavaScript VM) lifetime
1731 https://bugs.webkit.org/show_bug.cgi?id=85142
1733 Reviewed by Anders Carlsson.
1735 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1736 (WebKit::NetscapePluginInstanceProxy::invoke):
1737 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1738 (WebKit::NetscapePluginInstanceProxy::construct):
1740 2012-04-27 Gavin Peters <gavinp@chromium.org>
1742 Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
1743 https://bugs.webkit.org/show_bug.cgi?id=84871
1745 Reviewed by Adam Barth.
1747 Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
1748 API separates it from prefetching. Having separate include guards lets ports enable prefetching,
1749 a relatively easy change, without needing to build the infrastructure for prerendering, which
1750 is considerably more complicated.
1752 2012-04-26 Jon Lee <jonlee@apple.com>
1754 [WK2] AlternativeTextClient leaks when the page is destroyed
1755 https://bugs.webkit.org/show_bug.cgi?id=84307
1756 <rdar://problem/11328431>
1758 Reviewed by Enrica Casucci.
1760 * WebCoreSupport/WebAlternativeTextClient.h: Implement pageDestroyed(), as in EditorClient.
1761 (WebAlternativeTextClient):
1762 * WebCoreSupport/WebAlternativeTextClient.mm:
1763 (WebAlternativeTextClient::pageDestroyed): Deletes itself.
1765 2012-04-26 Jer Noble <jer.noble@apple.com>
1767 Full Screen mode does not preserve CALayer ordering after exiting.
1768 https://bugs.webkit.org/show_bug.cgi?id=83931
1770 Reviewed by Eric Carlson.
1772 Further corrections to r114567. When swapping view for otherView, give the correct
1773 relative view to -[NSView addSubview:positioned:relativeTo:].
1775 * WebView/WebFullScreenController.mm:
1776 (-[WebFullScreenController _swapView:with:]):
1778 2012-04-25 Jer Noble <jer.noble@apple.com>
1780 Placeholder view is immediately removed from hosting window upon entering full screen.
1781 https://bugs.webkit.org/show_bug.cgi?id=84916
1783 Reviewed by Darin Adler.
1785 Correct a mistake added in r114567. When swapping view for otherView, add otherView and
1786 remove view (rather than adding otherView and removing otherView).
1788 * WebView/WebFullScreenController.mm:
1789 (-[WebFullScreenController _swapView:with:]):
1791 2012-04-25 Beth Dakin <bdakin@apple.com>
1793 https://bugs.webkit.org/show_bug.cgi?id=84913
1794 WebKit 1: Initialize deviceScaleFactor on creation of the WebView
1796 <rdar://problem/11322716>
1798 Reviewed by Darin Adler.
1800 Before this patch, we weren't setting the deviceScaleFactor until
1801 viewDidMoveToWindow which is quite late for background tabs. setHostWindow will
1802 happen early on though. For applications that don't use host windows, also set it
1803 from _initWithFrame.
1804 * WebView/WebView.mm:
1805 (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
1806 (-[WebView setHostWindow:]):
1807 (-[WebView _deviceScaleFactor]):
1809 2012-04-24 Alexis Menard <alexis.menard@openbossa.org>
1811 Replace occurences of style selector from variables and methods names by style resolver.
1812 https://bugs.webkit.org/show_bug.cgi?id=84765
1814 Reviewed by Andreas Kling.
1816 Rename methods and variables to follow the new name StyleResolver. It requires to update the
1817 local variables, methods parameters, and function names to match the new name and to remove
1818 the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
1819 will be to rename CSSStyleSelector file and update the includes.
1821 * WebView/WebHTMLView.mm:
1822 (-[WebHTMLView reapplyStyles]):
1823 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1825 2012-04-23 Andy Estes <aestes@apple.com>
1827 Incremental rendering should be unsuppressed after the load event or a configurable timeout, whichever occurs first.
1828 https://bugs.webkit.org/show_bug.cgi?id=84583
1830 Add a private WebPreference for setting the incremental rendering suppression timeout.
1832 Reviewed by Anders Carlsson.
1834 * WebView/WebPreferenceKeysPrivate.h:
1835 * WebView/WebPreferences.mm:
1836 (-[WebPreferences setIncrementalRenderingSuppressionTimeoutInSeconds:]):
1837 (-[WebPreferences incrementalRenderingSuppressionTimeoutInSeconds]):
1838 * WebView/WebPreferencesPrivate.h:
1839 * WebView/WebView.mm:
1840 (-[WebView _preferencesChanged:]):
1842 2012-04-23 Julien Chaffraix <jchaffraix@webkit.org>
1844 Cut dependency on RenderLayer::scrollRectToVisible outside rendering
1845 https://bugs.webkit.org/show_bug.cgi?id=84607
1847 Reviewed by Simon Fraser.
1849 * WebView/WebFrame.mm:
1850 (-[WebFrame _scrollDOMRangeToVisible:]):
1851 Updated to use RenderObject::scrollRectToVisible and not depend on RenderLayer.
1853 2012-04-22 Jon Lee <jonlee@apple.com>
1855 Remove notifications support on Mac Lion.
1856 https://bugs.webkit.org/show_bug.cgi?id=84554
1857 <rdar://problem/11297128>
1859 Reviewed by Sam Weinig.
1861 * Configurations/FeatureDefines.xcconfig:
1863 2012-04-20 Jon Lee <jonlee@apple.com>
1865 Add Notification constructor
1866 https://bugs.webkit.org/show_bug.cgi?id=80477
1867 <rdar://problem/10912431>
1869 Reviewed by Jian Li.
1871 * WebCoreSupport/WebNotificationClient.mm:
1872 (WebNotificationClient::clearNotifications): When clearing notifications, finalize
1873 them so that they can be cleaned up by the GC.
1875 2012-04-20 Timothy Hatcher <timothy@apple.com>
1877 Make the Web Inspector be the first responder when opening docked.
1879 <rdar://problem/11294217>
1881 Reviewed by Brian Weinstein.
1883 * WebCoreSupport/WebInspectorClient.mm:
1884 (-[WebInspectorWindowController showWindow:]): Call makeFirstResponder: on
1885 the window and pass the Inspector's WebView.
1887 2012-04-18 Hironori Bono <hbono@chromium.org>
1889 Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
1890 https://bugs.webkit.org/show_bug.cgi?id=83748
1892 Reviewed by Ryosuke Niwa.
1894 This change replaces a call for SpellChecker::didCheck() with one for
1895 SpellChecker::didCheckSucceeded() because didCheck has been split into
1896 didCheckSucceeded(0 and didCheckCanceled().
1898 * WebCoreSupport/WebEditorClient.mm:
1899 (-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.
1901 2012-04-18 Jer Noble <jer.noble@apple.com>
1903 Full Screen mode does not preserve CALayer ordering after exiting.
1904 https://bugs.webkit.org/show_bug.cgi?id=83931
1906 Reviewed by Eric Carlson.
1908 When swapping the placeholder and web views, use -[NSView addSubview:positioned:relativeTo:]
1909 instead of -[NSView replaceSubview:with:], as the latter does not preserve the relative order
1910 of the view's backing CALayers.
1912 * WebView/WebFullScreenController.mm:
1913 (-[WebFullScreenController _swapView:with:]):
1915 2012-04-18 Alexey Proskuryakov <ap@apple.com>
1917 [WK2] Sandbox violations prevent attaching files to gmail messages
1918 https://bugs.webkit.org/show_bug.cgi?id=84263
1919 <rdar://problem/11248260>
1921 Reviewed by Oliver Hunt.
1923 * WebCoreSupport/WebDragClient.mm: (WebDragClient::willPerformDragDestinationAction):
1924 DragDestinationActionUpload no longer exists, so we don't need a special case for it.
1926 2012-04-17 Jer Noble <jer.noble@apple.com>
1928 Exiting full screen video brings the wrong Safari window to the foreground
1929 https://bugs.webkit.org/show_bug.cgi?id=83936
1931 Reviewed by Adele Peterson.
1933 Tell the original webView's window to makeKeyAndOrderFront once the exit
1934 animation completes.
1936 * WebView/WebFullScreenController.mm:
1937 (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1939 2012-04-16 Anders Carlsson <andersca@apple.com>
1941 Use a MIG call when creating a plug-in property list file
1942 https://bugs.webkit.org/show_bug.cgi?id=84084
1943 <rdar://problem/11197341>
1945 Reviewed by Sam Weinig.
1947 * Plugins/Hosted/NetscapePluginHostManager.mm:
1948 (WebKit::NetscapePluginHostManager::createPropertyListFile):
1949 Get a plug-in host and call _WKPHCreatePluginMIMETypesPreferences instead.
1951 * Plugins/Hosted/WebKitPluginHost.defs:
1952 Add PHCreatePluginMIMETypesPreferences.
1954 * Plugins/WebNetscapePluginPackage.mm:
1955 (-[WebNetscapePluginPackage createPropertyListFile]):
1956 NetscapePluginHostManager::createPropertyListFile is no longer a static member function.
1958 2012-04-12 Andy Estes <aestes@apple.com>
1960 REGRESSION (r102262): iAd Producer relies on CSSStyleDeclaration property setters respecting '!important'
1961 https://bugs.webkit.org/show_bug.cgi?id=83832
1963 Reviewed by Alexey Proskuryakov.
1965 * Misc/WebKitVersionChecks.h: Indicate that 535.13.0 was the first
1966 version of WebKit.framework to ignore '!important' in
1967 CSSStyleDeclaration property setters.
1968 * WebView/WebView.mm:
1969 (shouldRespectPriorityInCSSAttributeSetters):
1970 (-[WebView _commonInitializationWithFrameName:groupName:]): Enable a
1971 quirk to restore pre-r102262 behavior if the application is iAd Producer
1972 and was linked against a version of WebKit.framework that had the old behavior.
1974 2012-04-12 Andy Estes <aestes@apple.com>
1976 Remove unused WebKit1 SPI for suppressing incremental rendering.
1977 https://bugs.webkit.org/show_bug.cgi?id=83801
1979 Reviewed by Simon Fraser.
1981 This SPI is unused and has been replaced by API ([setS|s]uppressesIncrementalRendering).
1983 * WebView/WebPreferences.mm:
1984 * WebView/WebPreferencesPrivate.h:
1986 2012-04-08 Dan Bernstein <mitz@apple.com>
1988 [mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html
1989 https://bugs.webkit.org/show_bug.cgi?id=83453
1991 Reviewed by Sam Weinig.
1993 * WebView/WebView.mm:
1994 (-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning
1995 no custom scale factor, this method was setting the Page scale factor to 0, and that value
1996 was used by canvas. Changed it to correctly set the Page scale factor back to the device
1999 2012-04-06 Alexey Proskuryakov <ap@apple.com>
2001 [Mac] Adopt a different method of telling AppKit when inline input isn't supported
2002 https://bugs.webkit.org/show_bug.cgi?id=83408
2003 <rdar://problem/9205734>
2005 Reviewed by Adele Peterson.
2007 * Plugins/Hosted/WebTextInputWindowController.m:
2008 (-[WebTextInputView validAttributesForMarkedText]):
2009 (-[WebTextInputPanel init]):
2010 (-[WebTextInputPanel _interpretKeyEvent:string:]): Added a comment about old approach.
2012 2012-04-06 Enrica Casucci <enrica@apple.com>
2014 Provide Obj-C private API to simplify markup.
2015 https://bugs.webkit.org/show_bug.cgi?id=83334
2016 <rdar://problem/11033861>
2018 Reviewed by Sam Weinig.
2020 * WebView/WebView.mm:
2021 (-[WebView _simplifyMarkup:endNode:]): Added.
2022 * WebView/WebViewPrivate.h:
2024 2012-04-06 Tim Horton <timothy_horton@apple.com>
2026 Add autodetection of image orientation from EXIF information
2027 https://bugs.webkit.org/show_bug.cgi?id=19688
2028 <rdar://problem/4126979> and <rdar://problem/11091578>
2030 Original patch by David Carson and Eric Seidel.
2032 Reviewed by Simon Fraser.
2034 Add a preference, ShouldRespectImageOrientation, which will cause WebCore to respect EXIF orientation in all images.
2036 * WebView/WebPreferenceKeysPrivate.h:
2037 * WebView/WebPreferences.mm:
2038 (+[WebPreferences initialize]):
2039 (-[WebPreferences setShouldRespectImageOrientation:]):
2040 (-[WebPreferences shouldRespectImageOrientation]):
2041 * WebView/WebPreferencesPrivate.h:
2042 * WebView/WebView.mm:
2043 (-[WebView _preferencesChanged:]):
2045 2012-04-06 Dan Bernstein <mitz@apple.com>
2047 <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
2049 Reviewed by Sam Weinig.
2051 * Configurations/FeatureDefines.xcconfig: Added ENABLE_HIGH_DPI_CANVAS.
2053 2012-04-05 Jia Pu <jpu@apple.com>
2055 Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
2056 https://bugs.webkit.org/show_bug.cgi?id=82970
2058 Reviewed by Enrica Casucci.
2060 Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
2061 See WebCore/ChangeLog for details.
2063 * WebCoreSupport/CorrectionPanel.h:
2064 * WebCoreSupport/CorrectionPanel.mm:
2065 * WebCoreSupport/WebAlternativeTextClient.h: Added.
2066 (WebAlternativeTextClient):
2067 * WebCoreSupport/WebAlternativeTextClient.mm: Added.
2068 (WebAlternativeTextClient::WebAlternativeTextClient):
2069 (WebAlternativeTextClient::~WebAlternativeTextClient):
2070 (WebAlternativeTextClient::showCorrectionAlternative):
2071 (WebAlternativeTextClient::dismissAlternative):
2072 (WebAlternativeTextClient::dismissAlternativeSoon):
2073 (WebAlternativeTextClient::recordAutocorrectionResponse):
2074 * WebCoreSupport/WebEditorClient.h:
2075 * WebCoreSupport/WebEditorClient.mm:
2076 (WebEditorClient::~WebEditorClient):
2077 * WebView/WebView.mm:
2078 (-[WebView _commonInitializationWithFrameName:groupName:]):
2080 2012-03-15 Jer Noble <jer.noble@apple.com>
2082 Full Screen mode should cancel before navigation.
2083 https://bugs.webkit.org/show_bug.cgi?id=81295
2085 Reviewed by Anders Carlsson.
2087 When a provisional load is started, if the page is currently in full screen mode, instruct
2088 the full screen controller to close the full screen window immediately.
2090 * WebView/WebFullScreenController.h:
2091 * WebView/WebFullScreenController.mm:
2092 (-[WebFullScreenController isFullScreen]): Added.
2093 * WebView/WebView.mm:
2094 (-[WebView _didStartProvisionalLoadForFrame:]): Close the full screen window controller, if
2095 present and in full screen mode.
2097 2012-04-03 Keishi Hattori <keishi@webkit.org>
2099 Disable ENABLE_DATALIST for now
2100 https://bugs.webkit.org/show_bug.cgi?id=82871
2102 Reviewed by Kent Tamura.
2104 * Configurations/FeatureDefines.xcconfig: Disabled ENABLE_DATALIST.
2106 2012-04-03 Anders Carlsson <andersca@apple.com>
2108 Add audit token to PHCheckInWithPluginHost
2109 https://bugs.webkit.org/show_bug.cgi?id=83102
2111 Reviewed by Sam Weinig.
2113 * Plugins/Hosted/WebKitPluginHost.defs:
2115 2012-04-02 Jia Pu <jpu@apple.com>
2117 Rename SpellingCorrectionController to AlternativeTextController.
2118 https://bugs.webkit.org/show_bug.cgi?id=82942
2120 Reviewed by Enrica Casucci.
2122 These changes are simply adopting new class names.
2124 * WebCoreSupport/CorrectionPanel.h:
2126 * WebCoreSupport/CorrectionPanel.mm:
2127 (correctionIndicatorType):
2128 (CorrectionPanel::CorrectionPanel):
2129 (CorrectionPanel::~CorrectionPanel):
2130 (CorrectionPanel::show):
2131 (CorrectionPanel::dismiss):
2132 (CorrectionPanel::dismissInternal):
2133 (CorrectionPanel::handleAcceptedReplacement):
2134 * WebCoreSupport/WebEditorClient.h:
2135 * WebCoreSupport/WebEditorClient.mm:
2136 (WebEditorClient::~WebEditorClient):
2137 (WebEditorClient::showCorrectionPanel):
2138 (WebEditorClient::dismissCorrectionPanel):
2139 (WebEditorClient::dismissCorrectionPanelSoon):
2140 * WebView/WebView.mm:
2141 (-[WebView handleCorrectionPanelResult:]):
2143 2012-04-03 Jer Noble <jer.noble@apple.com>
2145 ESC key in full screen does not result in webkitFullScreenChange event.
2146 https://bugs.webkit.org/show_bug.cgi?id=82755
2147 <rdar://problem/11093513>
2149 Reviewed by Eric Carlson.
2151 Instead of exiting full screen directly, ask the document to initiate exiting full screen. This ensures
2152 that the entire full screen element stack is cleared and that webkitFullScreenChange events are sent
2155 * WebView/WebFullScreenController.mm:
2156 (-[WebFullScreenController cancelOperation:]):
2157 (-[WebFullScreenController requestExitFullScreen]):
2159 2012-04-01 Jon Lee <jonlee@apple.com>
2161 Rename notification properties and functions
2162 https://bugs.webkit.org/show_bug.cgi?id=80482
2163 <rdar://problem/10912432>
2165 Reviewed by Kentaro Hara.
2167 * WebView/WebNotification.h: Rename replaceID to tag.
2168 * WebView/WebNotification.mm:
2169 (-[WebNotification tag]):
2171 2012-03-31 Timothy Hatcher <timothy@apple.com>
2173 Prevent opening external URLs in the Web Inspector's WebView.
2175 All URLs not handled by the Inspector's JavaScript are now opened in the inspected WebView.
2177 https://webkit.org/b/82812
2178 rdar://problem/9488558
2180 Reviewed by Joseph Pecoraro.
2182 * WebCoreSupport/WebInspectorClient.mm:
2183 (-[WebInspectorWindowController init]): Factored the URL code out of here into inspectorPagePath.
2184 (-[WebInspectorWindowController inspectorPagePath]): Added.
2185 (-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added.
2186 Only allow non-main frame and the inspector page. All other URLs will be opened in the inspected page.
2188 2012-03-30 Emil A Eklund <eae@chromium.org>
2190 Change WebKit/WebKit2 platform code to use pixel snapped values
2191 https://bugs.webkit.org/show_bug.cgi?id=82549
2193 Change WebKit and WebKit2 platform code to use rounded locations and
2194 pixel snapped rects and sizes. This largely avoids having to expose the
2195 fractional layout types to the platform code.
2197 Reviewed by Eric Seidel.
2199 * DOM/WebDOMOperations.mm:
2200 (-[DOMNode _renderRect:]):
2202 2012-03-30 Mark Pilgrim <pilgrim@chromium.org>
2204 GEOLOCATION should be implemented as Page Supplement
2205 https://bugs.webkit.org/show_bug.cgi?id=82228
2207 Reviewed by Adam Barth.
2209 Geolocation is now a Supplement in Page so the interface
2210 has changed for setting up the page's geolocation client
2211 initially and accessing the controller later.
2213 * WebView/WebView.mm:
2214 (-[WebView _commonInitializationWithFrameName:groupName:]):
2215 (-[WebView _geolocationDidChangePosition:]):
2216 (-[WebView _geolocationDidFailWithError:]):
2218 2012-03-30 Keishi Hattori <keishi@webkit.org>
2220 Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
2221 https://bugs.webkit.org/show_bug.cgi?id=80972
2223 Reviewed by Kent Tamura.
2225 * Configurations/FeatureDefines.xcconfig:
2227 2012-03-28 Alexey Proskuryakov <ap@apple.com>
2229 [Mac] REGRESSION: Removing translation of local paths in KURL constructor broke some applications
2230 https://bugs.webkit.org/show_bug.cgi?id=82548
2231 <rdar://problem/11125355>
2232 <rdar://problem/11142152>
2234 Reviewed by Brady Eidson.
2236 * WebView/WebFrame.mm:
2237 (-[WebFrame loadRequest:]): Fixed this bug.
2238 (-[WebFrame loadHTMLString:baseURL:]): Also added translation to another API, so that I don't
2239 have to come back again.
2240 (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
2242 * WebView/WebView.mm: (-[WebView setMainFrameURL:]): Changed another place where clients used
2243 to pass file paths instead of URLs.
2245 2012-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
2247 Unreviewed, rolling out r112553.
2248 http://trac.webkit.org/changeset/112553
2249 https://bugs.webkit.org/show_bug.cgi?id=82638
2251 It made all tests crash on Qt WK2 (Requested by Ossy_away on
2254 * WebView/WebView.mm:
2255 (-[WebView _commonInitializationWithFrameName:groupName:]):
2256 (-[WebView _geolocationDidChangePosition:]):
2257 (-[WebView _geolocationDidFailWithError:]):
2259 2012-03-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2261 HashMap<>::add should return a more descriptive object
2262 https://bugs.webkit.org/show_bug.cgi?id=71063
2264 Reviewed by Ryosuke Niwa.
2266 Update code to use AddResult instead of a pair.
2268 * Plugins/Hosted/NetscapePluginHostManager.mm:
2269 (WebKit::NetscapePluginHostManager::hostForPlugin):
2270 * Plugins/Hosted/ProxyInstance.mm:
2271 (WebKit::ProxyInstance::methodsNamed):
2272 (WebKit::ProxyInstance::fieldNamed):
2273 * WebCoreSupport/WebNotificationClient.mm:
2274 (WebNotificationClient::show):
2276 2012-03-29 Mark Pilgrim <pilgrim@chromium.org>
2278 GEOLOCATION should be implemented as Page Supplement
2279 https://bugs.webkit.org/show_bug.cgi?id=82228
2281 Reviewed by Adam Barth.
2283 Geolocation is now a Supplement in Page so the interface
2284 has changed for setting up the page's geolocation client
2285 initially and accessing the controller later.
2287 * WebView/WebView.mm:
2288 (-[WebView _commonInitializationWithFrameName:groupName:]):
2289 (-[WebView _geolocationDidChangePosition:]):
2290 (-[WebView _geolocationDidFailWithError:]):
2292 2012-03-28 Nate Chapin <japhet@chromium.org>
2294 Remove dispatchDidLoadMainResource callback, since no
2296 https://bugs.webkit.org/show_bug.cgi?id=82539
2298 Reviewed by Alexey Proskuryakov.
2300 * WebCoreSupport/WebFrameLoaderClient.h:
2301 * WebCoreSupport/WebFrameLoaderClient.mm:
2304 2012-03-28 Joseph Pecoraro <pecoraro@apple.com>
2306 <http://webkit.org/b/82419> Web Inspector: Create -[DOMNode inspect] from IDL
2308 Reviewed by Timothy Hatcher.
2310 * MigrateHeaders.make: Copy DOMNodePrivate.h to PrivateHeaders.
2312 2012-03-27 Timothy Hatcher <timothy@apple.com>
2314 Make WebKit properly load a staged framework when soft linking.
2316 https://webkit.org/b/82371
2317 rdar://problem/11125989
2319 Reviewed by Dan Bernstein.
2321 * WebCoreSupport/WebInspectorClient.mm: Use SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL to properly
2322 load the WebInspector framework.
2324 2012-03-26 Adam Barth <abarth@webkit.org>
2326 FrameLoader::shouldAllowNavigation uses Frame for context rather than Document
2327 https://bugs.webkit.org/show_bug.cgi?id=81020
2329 Reviewed by Eric Seidel.
2331 Update call site to new function name.
2333 * WebCoreSupport/WebFrameLoaderClient.mm:
2334 (WebFrameLoaderClient::dispatchWillSubmitForm):
2336 2012-03-23 Alexey Proskuryakov <ap@apple.com>
2338 [Mac] No need for platform-specific ENABLE_BLOB values
2339 https://bugs.webkit.org/show_bug.cgi?id=82102
2341 Reviewed by David Kilzer.
2343 * Configurations/FeatureDefines.xcconfig:
2345 2012-03-23 Dean Jackson <dino@apple.com>
2347 Disable CSS_SHADERS in Apple builds
2348 https://bugs.webkit.org/show_bug.cgi?id=81996
2350 Reviewed by Simon Fraser.
2352 Remove ENABLE_CSS_SHADERS from FeatureDefines. It's now in Platform.h.
2354 * Configurations/FeatureDefines.xcconfig:
2356 2012-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2358 Convert hasGrammarMarker to use Internals interface
2359 https://bugs.webkit.org/show_bug.cgi?id=82004
2361 Reviewed by Ryosuke Niwa.
2363 Remove hasGrammarMarker support, since it can support in the cross-port way
2364 through the Internals interface.
2367 * WebView/WebFrame.mm:
2368 * WebView/WebFramePrivate.h:
2370 2012-03-22 Benjamin Poulain <bpoulain@apple.com>
2372 Build fix for WebHistory is busted after changing time zone
2373 https://bugs.webkit.org/show_bug.cgi?id=81849
2375 Unreviewed build fix.
2377 When generating warning for undefined message signature, rebuildHistoryByDayIfNeeded
2378 fail to compile due to addItemToDateCaches: being undefined.
2380 Move the definition to the right place in the file to use the private method.
2382 * History/WebHistory.mm:
2383 (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2385 2012-03-22 Benjamin Poulain <bpoulain@apple.com>
2387 WebHistory is busted after changing time zone
2388 https://bugs.webkit.org/show_bug.cgi?id=81849
2390 Reviewed by Brady Eidson.
2392 The date used for choosing the bucket of a new entry is computed
2393 with the system TimeZone.
2395 When the Time Zone change, or the daylight saving time change, all the dates
2396 in _entriesByDate are offset from the new entries.
2398 This patch solves the issue by re-distributing the WebHistoryItems if the time zone
2400 The clients of WebHistory are notified of this change through the regular Notifications.
2402 * History/WebHistory.mm:
2403 (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2404 (-[WebHistoryPrivate init]):
2405 (-[WebHistory timeZoneChanged:]):
2406 (-[WebHistory init]):
2407 (-[WebHistory dealloc]):
2408 (-[WebHistory finalize]):
2410 2012-03-21 Tim Horton <timothy_horton@apple.com>
2412 Make use of CG rounded-rect primitives
2413 https://bugs.webkit.org/show_bug.cgi?id=79932
2414 <rdar://problem/9274953>
2416 Reviewed by Simon Fraser.
2418 Portions of patch by Nikolas Zimmermann and Mustafizur Rahaman.
2420 Add wkCGPathAddRoundedRect.
2422 * WebCoreSupport/WebSystemInterface.mm:
2423 (InitWebCoreSystemInterface):
2425 2012-03-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2427 Convert hasSpellingMarker to use Internals interface.
2428 https://bugs.webkit.org/show_bug.cgi?id=81300
2430 Reviewed by Ryosuke Niwa.
2432 Remove hasSpellingMarker support, since it can support in the cross-port way
2433 through the Internals interface.
2436 * WebView/WebFrame.mm:
2437 * WebView/WebFramePrivate.h:
2439 2012-03-19 Adam Barth <abarth@webkit.org>
2441 Remove support for "magic" iframe
2442 https://bugs.webkit.org/show_bug.cgi?id=81590
2444 Reviewed by Eric Seidel.
2446 Remove FrameLoaderClient methods that no longer exist.
2448 * WebCoreSupport/WebFrameLoaderClient.h:
2449 * WebCoreSupport/WebFrameLoaderClient.mm:
2451 2012-03-19 Enrica Casucci <enrica@apple.com>
2453 WebKit2: create sandbox extensions for files that are dropped in an input control.
2454 https://bugs.webkit.org/show_bug.cgi?id=81153
2455 <rdar://problem/11031207>
2457 Reviewed by Alexey Proskuryakov.
2459 * WebCoreSupport/WebDragClient.mm:
2460 (WebDragClient::willPerformDragDestinationAction): Avoid calling the delegate with the new drag action.
2461 We want to avoid any unwanted side effects for the WebKit clients.
2463 2012-03-19 Emil A Eklund <eae@chromium.org>
2465 [mac/chromium] Change platform code to use pixelSnappedRect methods
2466 https://bugs.webkit.org/show_bug.cgi?id=81016
2468 Reviewed by Eric Seidel.
2470 * Plugins/WebBaseNetscapePluginView.mm:
2471 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
2472 * WebView/WebFrame.mm:
2473 (-[WebFrame _getVisibleRect:]):
2474 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
2475 * WebView/WebView.mm:
2476 (-[WebView _dashboardRegions]):
2477 (-[WebView trackedRepaintRects]):
2479 2012-03-16 Brady Eidson <beidson@apple.com>
2481 <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
2482 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
2484 Reviewed by Geoff Garen.
2486 * WebCoreSupport/WebEditorClient.mm:
2487 (WebEditorClient::setInsertionPasteboard):
2488 * WebCoreSupport/WebPlatformStrategies.h:
2489 (WebPlatformStrategies):
2490 * WebCoreSupport/WebPlatformStrategies.mm:
2491 (WebPlatformStrategies::url):
2493 2012-03-08 Jer Noble <jer.noble@apple.com>
2495 Support W3C Full Screen API proposal
2496 https://bugs.webkit.org/show_bug.cgi?id=80660
2498 Reviewed by Alexey Proskuryakov.
2500 Allow full screen elements to access the keyboard.
2502 * WebView/WebView.mm:
2503 (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
2505 2012-03-07 Jon Lee <jonlee@apple.com>
2507 Move NotificationContents into Notification
2508 https://bugs.webkit.org/show_bug.cgi?id=80487
2509 <rdar://problem/10965519>
2511 Reviewed by Jian Li.
2513 * WebView/WebNotification.mm: Refactor to use accessor methods on Notification.
2514 (-[WebNotification title]):
2515 (-[WebNotification body]):
2517 2012-03-15 David Hyatt <hyatt@apple.com>
2519 https://bugs.webkit.org/show_bug.cgi?id=81258
2521 Add a preference for enabling the new multi-column layout code that will be based on regions.
2523 Reviewed by Beth Dakin.
2525 * WebView/WebPreferenceKeysPrivate.h:
2526 * WebView/WebPreferences.mm:
2527 (+[WebPreferences initialize]):
2528 (-[WebPreferences setRegionBasedColumnsEnabled:]):
2529 (-[WebPreferences regionBasedColumnsEnabled]):
2530 * WebView/WebPreferencesPrivate.h:
2531 * WebView/WebView.mm:
2532 (-[WebView _preferencesChanged:]):
2534 2012-03-15 Brady Eidson <beidson@apple.com>
2536 <rdar://problem/11036900> and https://bugs.webkit.org/show_bug.cgi?id=81079
2537 REGRESSION(r107844): Clipboard API only remembers most recent data set on clipboard
2539 Reviewed by Sam Weinig.
2541 Add the non-destructive "addTypes" to supplement the destructive "setTypes"
2542 * WebCoreSupport/WebPlatformStrategies.h:
2543 * WebCoreSupport/WebPlatformStrategies.mm:
2544 (WebPlatformStrategies::addTypes):
2546 2012-03-14 Anders Carlsson <andersca@apple.com>
2548 java/java-and-plugins.html test failing
2549 https://bugs.webkit.org/show_bug.cgi?id=81188
2550 <rdar://problem/11048657>
2552 Reviewed by Sam Weinig.
2554 When we're marshaling JSObjects that wrap plug-in objects, make sure to check that the
2555 current plug-in instance is the same as the plug-in instance the object came from and don't
2556 pass the unwrapped object ID if that is the case.
2558 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2559 (WebKit::getObjectID):
2560 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
2561 (WebKit::NetscapePluginInstanceProxy::marshalValues):
2562 * Plugins/Hosted/ProxyInstance.h:
2564 (WebKit::ProxyInstance::instanceProxy):
2566 2012-03-14 Michael Saboff <msaboff@apple.com>
2568 REGRESSION(r110383): ASSERTION failures in JSCell::finishCreation causing multiple tests to "crash" on the Lion Intel Debug Bots
2569 https://bugs.webkit.org/show_bug.cgi?id=80993
2571 Reviewed by Mark Rowe.
2573 Moved $(BUILT_PRODUCTS_DIR)/usr/local/include to the front of HEADER_SEARCH_PATH
2574 to fix builds given the wtf move.
2576 * Configurations/WebKit.xcconfig:
2578 2012-03-13 Jon Lee <jonlee@apple.com>
2580 Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
2581 https://bugs.webkit.org/show_bug.cgi?id=80922
2582 <rdar://problem/11035082>
2584 Reviewed by Jian Li.
2586 You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
2587 LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
2588 new API. Therefore, APIs that are common between the two will have:
2589 #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2591 This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
2592 the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
2594 Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2595 * WebCoreSupport/WebNotificationClient.h:
2596 * WebCoreSupport/WebNotificationClient.mm:
2597 (WebNotificationClient::show):
2598 (WebNotificationClient::cancel):
2599 (WebNotificationClient::clearNotifications):
2600 (WebNotificationClient::notificationObjectDestroyed):
2601 (WebNotificationClient::notificationControllerDestroyed):
2602 (WebNotificationClient::requestPermission):
2603 (WebNotificationClient::checkPermission):
2604 * WebView/WebNotification.mm:
2605 (-[WebNotification title]):
2606 (-[WebNotification body]):
2607 (-[WebNotification replaceID]):
2608 (-[WebNotification origin]):
2609 (-[WebNotification notificationID]):
2610 (-[WebNotification dispatchShowEvent]):
2611 (-[WebNotification dispatchCloseEvent]):
2612 (-[WebNotification dispatchClickEvent]):
2613 (-[WebNotification dispatchErrorEvent]):
2614 * WebView/WebNotificationInternal.h:
2615 * WebView/WebView.mm:
2616 (-[WebView _commonInitializationWithFrameName:groupName:]):
2618 2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
2620 Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
2621 https://bugs.webkit.org/show_bug.cgi?id=78853
2623 Reviewed by Adam Barth.
2625 * Configurations/FeatureDefines.xcconfig:
2626 * WebCoreSupport/WebChromeClient.h:
2628 * WebCoreSupport/WebGeolocationClient.mm:
2629 (WebGeolocationClient::lastPosition):
2630 * WebView/WebGeolocationPosition.mm:
2631 (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2633 (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2634 * WebView/WebGeolocationPositionInternal.h:
2635 * WebView/WebView.mm:
2636 (-[WebView _commonInitializationWithFrameName:groupName:]):
2637 (-[WebView _geolocationDidChangePosition:]):
2638 (-[WebView _geolocationDidFailWithError:]):
2640 2012-03-12 Antonio Gomes <agomes@rim.com>
2642 Convert nodesFromRect tests to use Internals interface
2643 https://bugs.webkit.org/show_bug.cgi?id=80886
2645 Reviewed by Ryosuke Niwa.
2647 Removed mac specific support for nodesFromRect for testing purposes only,
2648 since it can work in a cross-port way through the Internals interface.
2651 * WebView/WebView.mm:
2652 * WebView/WebViewPrivate.h:
2654 2012-03-13 Anders Carlsson <andersca@apple.com>
2656 Remove a nonexistent WebUIDelegate method from WebUIDelegatePrivate.h
2657 https://bugs.webkit.org/show_bug.cgi?id=81014
2659 Reviewed by Sam Weinig.
2661 Remove a plug-in halter related WebUIDelegate method.
2663 * WebView/WebUIDelegatePrivate.h:
2665 2012-03-13 Shinya Kawanaka <shinyak@chromium.org>
2667 REGRESSION: Spellcheck tests hit assertions on Mac.
2668 https://bugs.webkit.org/show_bug.cgi?id=80883
2670 Reviewed by Ryosuke Niwa.
2672 The bug was caused by the closure object created in requestCheckingOfString accessing
2673 request's member variables even though the request object is not an NSObject or allocated
2674 in stack. This resulted in the closure not being able to access those variables when invoked.
2676 Fixed the bug by making local copies of those member variables.
2678 * WebCoreSupport/WebEditorClient.mm:
2679 (WebEditorClient::requestCheckingOfString):
2681 2012-03-11 Timothy Hatcher <timothy@apple.com>
2683 Update how the Web Inspector resources are loaded.
2685 https://bugs.webkit.org/show_bug.cgi?id=80798
2686 rdar://problem/10359959
2688 Reviewed by Brian Weinstein.
2690 * WebCoreSupport/WebInspectorClient.mm:
2691 (useWebKitWebInspector): Return if we are using the WebCore resources for compatibility
2692 with local and nightly builds.
2693 (WebInspectorFrontendClient::localizedStringsURL): Decide what path to use.
2694 (-[WebInspectorWindowController init]): Ditto.
2695 (-[WebInspectorWindowController window]): Decide if the window is textured or not.
2697 2012-03-09 Jon Lee <jonlee@apple.com>
2699 Rename NotificationPresenter to NotificationClient
2700 https://bugs.webkit.org/show_bug.cgi?id=80488
2701 <rdar://problem/10965558>
2703 Reviewed by Kentaro Hara.
2705 Refactor to use renamed WebCore::NotificationClient.
2706 * WebCoreSupport/WebNotificationClient.h:
2707 * WebCoreSupport/WebNotificationClient.mm:
2708 (WebNotificationClient::checkPermission):
2709 * WebView/WebViewPrivate.h:
2711 2012-03-09 Enrica Casucci <enrica@apple.com>
2713 Move WebNSURLExtras code down to WebCore.
2714 https://bugs.webkit.org/show_bug.cgi?id=80611
2716 Reviewed by Alexey Proskuryakov.
2718 Changed the implementation to use newly moved WebCore functions.
2720 * Misc/WebKitNSStringExtras.mm:
2721 (-[NSString _webkit_hasCaseInsensitivePrefix:]):
2722 * Misc/WebNSURLExtras.mm:
2723 (+[NSURL _web_URLWithUserTypedString:]):
2724 (+[NSURL _web_URLWithDataAsString:relativeToURL:]):
2725 (+[NSURL _web_URLWithData:]):
2726 (+[NSURL _web_URLWithData:relativeToURL:]):
2727 (-[NSURL _web_originalData]):
2728 (-[NSURL _web_originalDataAsString]):
2729 (-[NSURL _web_userVisibleString]):
2730 (-[NSURL _web_isEmpty]):
2731 (-[NSURL _web_URLCString]):
2732 (-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]):
2733 (-[NSURL _webkit_URLByRemovingFragment]):
2734 (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
2735 (-[NSURL _web_URLByRemovingUserInfo]):
2736 (-[NSURL _web_dataForURLComponentType:]):
2737 (-[NSURL _web_schemeData]):
2738 (-[NSURL _web_hostData]):
2739 (-[NSString _web_isUserVisibleURL]):
2740 (-[NSString _web_hostNameNeedsDecodingWithRange:]):
2741 (-[NSString _web_hostNameNeedsEncodingWithRange:]):
2742 (-[NSString _web_decodeHostNameWithRange:]):
2743 (-[NSString _web_encodeHostNameWithRange:]):
2744 (-[NSString _web_decodeHostName]):
2745 (-[NSString _web_encodeHostName]):
2746 * WebCoreSupport/WebSystemInterface.mm:
2747 (InitWebCoreSystemInterface):
2749 2012-03-09 Emil A Eklund <eae@chromium.org>
2751 Add roundedPoint to HitTestResult and change platform code to use it
2752 https://bugs.webkit.org/show_bug.cgi?id=80715
2754 Reviewed by James Robinson.
2756 Change ports to use roundedPoint to avoid exposing subpixel types to
2759 * WebCoreSupport/WebContextMenuClient.mm:
2760 (WebContextMenuClient::showContextMenu):
2762 2012-03-09 Jon Lee <jonlee@apple.com>
2764 Add support for ENABLE(LEGACY_NOTIFICATIONS)
2765 https://bugs.webkit.org/show_bug.cgi?id=80497
2767 Reviewed by Adam Barth.
2769 Prep for b80472: Update API for Web Notifications
2770 * Configurations/FeatureDefines.xcconfig:
2772 2012-03-08 Ryosuke Niwa <rniwa@webkit.org>
2774 Mac build fix for micro data API.
2776 * Configurations/FeatureDefines.xcconfig:
2778 2012-03-08 Jer Noble <jer.noble@apple.com>
2780 Unreviewed Snow Leopard build fix.
2782 On Leopard and Snow Leopard, provide an implementation for -[NSWindow convertRectToScreen:].
2784 * WebView/WebFullScreenController.mm:
2785 (-[NSWindow convertRectToScreen:]):
2787 2012-02-20 Jer Noble <jer.noble@apple.com>
2789 Full Screen Refactor Part 4: Animate into Full Screen mode using new animation classes, WebKit edition.
2790 https://bugs.webkit.org/show_bug.cgi?id=78930
2792 Reviewed by Anders Carlsson.
2794 Revise WebFullScreenController to have the same general functionality and code path as WKFullScreenWindowController
2795 in WebKit2. As such, the following functions are copies of their equivalents in WKFullScreenWindowController:
2796 * WebView/WebFullScreenController.mm:
2797 (-[WebFullScreenController init]):
2798 (-[WebFullScreenController dealloc]):
2799 (-[WebFullScreenController windowDidLoad]):
2800 (-[WebFullScreenController cancelOperation:]):
2801 (-[WebFullScreenController applicationDidResignActive:]):
2802 (-[WebFullScreenController applicationDidChangeScreenParameters:]):
2803 (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2804 (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2805 (-[WebFullScreenController close]):
2806 (-[WebFullScreenController animationDidEnd:]):
2807 (-[WebFullScreenController _updateMenuAndDockForFullScreen]):
2808 (-[WebFullScreenController _swapView:with:]):
2809 (createBackgroundFullscreenWindow):
2810 (windowFrameFromApparentFrames):
2811 (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2812 (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2814 The following is a copy of the equivalent function in WebFullScreenManager:
2815 * WebView/WebFullScreenController.mm:
2816 (screenRectOfContents):
2818 * WebCoreSupport/WebChromeClient.mm:
2819 (WebChromeClient::fullScreenRendererChanged): No longer tell the WebView the renderer changed (as it doesn't care.)
2820 * WebView/WebFullScreenController.h:
2821 * WebView/WebFullScreenController.mm:
2822 (-[WebFullScreenController setElement:]): No need to add event listeners to the media element.
2823 (-[WebFullScreenController enterFullScreen:]): Same as WKFullScreenWindowController, but not asynchronous.
2824 (-[WebFullScreenController exitFullScreen]): Ditto.
2825 * WebView/WebView.mm:
2826 (-[WebView _enterFullScreenForElement:WebCore::]): Fullscreen -> FullScreen.
2827 (-[WebView _exitFullScreenForElement:WebCore::]): Ditto.
2829 2012-03-08 Matt Lilek <mrl@apple.com>
2831 Don't enable VIDEO_TRACK on all OS X platforms
2832 https://bugs.webkit.org/show_bug.cgi?id=80635
2834 Reviewed by Eric Carlson.
2836 * Configurations/FeatureDefines.xcconfig:
2838 2012-03-07 Joseph Pecoraro <pecoraro@apple.com>
2840 <http://webkit.org/b/80510> Web Inspector crash (iCab)
2842 Reviewed by Timothy Hatcher.
2844 * WebCoreSupport/WebInspectorClient.mm:
2845 (WebInspectorClient::didResizeMainFrame):
2847 2012-03-06 Benjamin Poulain <bpoulain@apple.com>
2849 [Mac] Update the configuration files for iOS
2850 https://bugs.webkit.org/show_bug.cgi?id=80435
2852 Reviewed by David Kilzer.
2854 * Configurations/WebKit.xcconfig:
2856 2012-03-06 Eric Seidel <eric@webkit.org>
2858 Make WTF public headers use fully-qualified include paths and remove ForwardingHeaders/wtf
2859 https://bugs.webkit.org/show_bug.cgi?id=80363
2861 Reviewed by Mark Rowe.
2863 ForwardingHeaders/wtf is no longer necessary (or functional) now that JavaScriptCore
2864 no longer includes the WTF headers as private headers.
2866 * ForwardingHeaders/wtf/ASCIICType.h: Removed.
2867 * ForwardingHeaders/wtf/AlwaysInline.h: Removed.
2868 * ForwardingHeaders/wtf/Assertions.h: Removed.
2869 * ForwardingHeaders/wtf/Deque.h: Removed.
2870 * ForwardingHeaders/wtf/DisallowCType.h: Removed.
2871 * ForwardingHeaders/wtf/FastMalloc.h: Removed.
2872 * ForwardingHeaders/wtf/Forward.h: Removed.
2873 * ForwardingHeaders/wtf/GetPtr.h: Removed.
2874 * ForwardingHeaders/wtf/HashCountedSet.h: Removed.
2875 * ForwardingHeaders/wtf/HashMap.h: Removed.
2876 * ForwardingHeaders/wtf/HashSet.h: Removed.
2877 * ForwardingHeaders/wtf/HashTraits.h: Removed.
2878 * ForwardingHeaders/wtf/ListHashSet.h: Removed.
2879 * ForwardingHeaders/wtf/ListRefPtr.h: Removed.
2880 * ForwardingHeaders/wtf/Locker.h: Removed.
2881 * ForwardingHeaders/wtf/MathExtras.h: Removed.
2882 * ForwardingHeaders/wtf/Noncopyable.h: Removed.
2883 * ForwardingHeaders/wtf/OwnArrayPtr.h: Removed.
2884 * ForwardingHeaders/wtf/OwnPtr.h: Removed.
2885 * ForwardingHeaders/wtf/OwnPtrCommon.h: Removed.
2886 * ForwardingHeaders/wtf/PassOwnPtr.h: Removed.
2887 * ForwardingHeaders/wtf/PassRefPtr.h: Removed.
2888 * ForwardingHeaders/wtf/Platform.h: Removed.
2889 * ForwardingHeaders/wtf/RefCounted.h: Removed.
2890 * ForwardingHeaders/wtf/RefCountedLeakCounter.h: Removed.
2891 * ForwardingHeaders/wtf/RefPtr.h: Removed.
2892 * ForwardingHeaders/wtf/RetainPtr.h: Removed.
2893 * ForwardingHeaders/wtf/StdLibExtras.h: Removed.
2894 * ForwardingHeaders/wtf/TemporaryChange.h: Removed.
2895 * ForwardingHeaders/wtf/Threading.h: Removed.
2896 * ForwardingHeaders/wtf/UnusedParam.h: Removed.
2897 * ForwardingHeaders/wtf/VMTags.h: Removed.
2898 * ForwardingHeaders/wtf/ValueCheck.h: Removed.
2899 * ForwardingHeaders/wtf/Vector.h: Removed.
2900 * ForwardingHeaders/wtf/VectorTraits.h: Removed.
2901 * ForwardingHeaders/wtf/unicode/Unicode.h: Removed.
2902 * ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Removed.
2904 2012-03-05 Joseph Pecoraro <pecoraro@apple.com>
2906 Web Inspector: Hide dock button when not allowed to dock
2907 https://bugs.webkit.org/show_bug.cgi?id=78575
2909 Reviewed by Pavel Feldman.
2911 * WebCoreSupport/WebInspectorClient.h:
2913 (WebInspectorClient):
2914 * WebCoreSupport/WebInspectorClient.mm:
2915 (WebInspectorClient::didResizeMainFrame):
2917 2012-03-05 Gavin Barraclough <barraclough@apple.com>
2919 putByIndex should throw in strict mode
2920 https://bugs.webkit.org/show_bug.cgi?id=80335
2922 Reviewed by Filip Pizlo.
2924 Make the MethodTable PutByIndex trap take a boolean 'shouldThrow' parameter.
2926 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2927 (WebKit::NetscapePluginInstanceProxy::setProperty):
2929 2012-03-05 Joseph Pecoraro <pecoraro@apple.com>
2931 Unreviewed rollout of r109858 for restructuring.
2933 2012-03-05 Joseph Pecoraro <pecoraro@apple.com>
2935 <http://webkit.org/b/78575> Web Inspector: Hide dock button when not allowed to dock
2937 Reviewed by Timothy Hatcher.
2939 * WebCoreSupport/WebInspectorClient.h:
2940 (WebInspectorClient):
2941 * WebCoreSupport/WebInspectorClient.mm:
2942 (WebInspectorClient::updateDockingAvailability):
2944 2012-03-02 Jon Lee <jonlee@apple.com>
2946 Add support for notification replaceId in Mac WebKit and WK2
2947 https://bugs.webkit.org/show_bug.cgi?id=80206
2948 <rdar://problem/10965574>
2950 Reviewed by Sam Weinig.
2952 * WebView/WebNotification.h: Add replaceID method.
2953 * WebView/WebNotification.mm:
2954 (-[WebNotification replaceID]):
2956 2012-03-05 Adam Barth <abarth@webkit.org>
2958 Geolocation should use a ScriptExecutionContext as its context object
2959 https://bugs.webkit.org/show_bug.cgi?id=80248
2961 Reviewed by Kentaro Hara.
2963 * WebView/WebFrame.mm:
2964 (-[WebFrame _cacheabilityDictionary]):
2965 - We no longer special-case Geolocation.
2967 2012-03-03 Benjamin Poulain <benjamin@webkit.org>
2969 Remove the redundant method KURL::protocolInHTTPFamily()
2970 https://bugs.webkit.org/show_bug.cgi?id=80216
2972 Reviewed by Anders Carlsson.
2974 * WebCoreSupport/WebFrameLoaderClient.mm:
2975 (WebFrameLoaderClient::createPlugin):
2977 2012-03-03 Hans Wennborg <hans@chromium.org>
2979 Implement Speech JavaScript API
2980 https://bugs.webkit.org/show_bug.cgi?id=80019
2982 Reviewed by Adam Barth.
2984 Add ENABLE_SCRIPTED_SPEECH.
2986 * Configurations/FeatureDefines.xcconfig:
2988 2012-03-03 Anders Carlsson <andersca@apple.com>
2990 Fix build with newer versions of clang.
2992 * Panels/WebAuthenticationPanel.m:
2993 (-[WebAuthenticationPanel setUpForChallenge:]):
2994 Use %ld and cast to long.
2996 * Plugins/WebNetscapePluginView.mm:
2997 (-[WebNetscapePluginView getVariable:value:]):
2998 Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
3000 2012-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
3002 Unreviewed, rolling out r109255.
3003 http://trac.webkit.org/changeset/109255
3004 https://bugs.webkit.org/show_bug.cgi?id=79932
3006 Breaks rounded rects with dashed strokes in SVG
3008 * WebCoreSupport/WebSystemInterface.mm:
3009 (InitWebCoreSystemInterface):
3011 2012-02-29 Adam Barth <abarth@webkit.org>
3013 ScriptExecutionContext has too many ifdef ENABLE(SQL_DATABASE)
3014 https://bugs.webkit.org/show_bug.cgi?id=79633
3016 Reviewed by Eric Seidel.
3018 * WebView/WebFrame.mm:
3019 (-[WebFrame _cacheabilityDictionary]):
3021 2012-02-29 Tim Horton <timothy_horton@apple.com>
3023 Make use of CG rounded-rect primitives
3024 https://bugs.webkit.org/show_bug.cgi?id=79932
3025 <rdar://problem/9274953>
3027 Reviewed by Simon Fraser.
3029 Add wkCGPathAddRoundedRect.
3031 * WebCoreSupport/WebSystemInterface.mm:
3032 (InitWebCoreSystemInterface):
3034 2012-02-29 Enrica Casucci <enrica@apple.com>
3036 Crash at -[WebFrame(WebInternal) _setTypingStyle:withUndoAction:]
3037 https://bugs.webkit.org/show_bug.cgi?id=79937
3038 <rdar://problem/10942936>
3040 Reviewed by Dan Bernstein.
3042 * WebView/WebFrame.mm:
3043 (-[WebFrame _setTypingStyle:withUndoAction:]): Adding a null check.
3045 2012-02-28 Simon Fraser <simon.fraser@apple.com>
3047 Update WebKitSystemInterface.
3049 Reviewed by Sam Weinig.
3051 * WebCoreSupport/WebSystemInterface.mm:
3052 (InitWebCoreSystemInterface):
3054 2012-02-28 Enrica Casucci <enrica@apple.com>
3056 More Pasteboard code cleanup.
3057 https://bugs.webkit.org/show_bug.cgi?id=79816
3059 Removing the last references to NSPasteboard.
3061 Reviewed by Alexey Proskuryakov.
3063 * WebCoreSupport/WebEditorClient.h:
3064 * WebCoreSupport/WebEditorClient.mm:
3065 (WebEditorClient::setInsertionPasteboard):
3067 2012-02-26 Hajime Morrita <morrita@chromium.org>
3069 Move ChromeClient::showContextMenu() to ContextMenuClient
3070 https://bugs.webkit.org/show_bug.cgi?id=79427
3072 Reviewed by Adam Barth.
3074 * WebCoreSupport/WebContextMenuClient.h:
3075 (WebContextMenuClient):
3076 * WebCoreSupport/WebContextMenuClient.mm:
3077 (WebContextMenuClient::showContextMenu): Moved from WebChromeClient
3078 * WebCoreSupport/WebChromeClient.h:
3079 * WebCoreSupport/WebChromeClient.mm:
3081 2012-02-25 Sam Weinig <sam@webkit.org>
3083 QuickLook events don't make it to WebKit plugins.
3084 <rdar://problem/10931721>
3086 Reviewed by Anders Carlsson.
3088 * WebView/WebHTMLView.mm:
3090 (-[WebHTMLView hitTest:]):
3091 Allow QuickLook events to hit test down to subviews.
3093 2012-02-24 Brady Eidson <beidson@apple.com>
3095 <rdar://problem/10805709> and https://bugs.webkit.org/show_bug.cgi?id=79421
3096 Need a WK1 Mac API to filter which subframes go into WebArchives as they are created
3098 Reviewed by Sam Weinig (with additional comments by Adam Roben)
3100 Add webArchiveByFilteringSubframes: which takes a callback block:
3101 * DOM/WebDOMOperationsPrivate.h:
3103 Add FrameFilter that adapts the block, and use it to implement the new SPI:
3104 * DOM/WebDOMOperations.mm:
3106 (WebFrameFilter::WebFrameFilter):
3107 (WebFrameFilter::~WebFrameFilter):
3108 (WebFrameFilter::shouldIncludeSubframe):
3109 (-[DOMNode webArchiveByFilteringSubframes:]):
3111 2012-02-24 Shinya Kawanaka <shinyak@chromium.org>
3113 SpellCheckRequest needs to know the context where the spellcheck happened.
3114 https://bugs.webkit.org/show_bug.cgi?id=79320
3116 Reviewed by Hajime Morita.
3118 * WebCoreSupport/WebEditorClient.h:
3119 * WebCoreSupport/WebEditorClient.mm:
3120 (WebEditorClient::requestCheckingOfString):
3122 2012-02-23 Andy Estes <aestes@apple.com>
3124 Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API.
3125 https://bugs.webkit.org/show_bug.cgi?id=79433
3127 Reviewed by Dan Bernstein.
3129 * WebCoreSupport/WebInspectorClient.mm:
3130 (-[WebInspectorWindowController init]):
3131 * WebView/WebPreferenceKeysPrivate.h:
3132 * WebView/WebPreferences.h:
3133 * WebView/WebPreferences.mm:
3134 (+[WebPreferences initialize]):
3135 (-[WebPreferences setSuppressesIncrementalRendering:]):
3136 (-[WebPreferences suppressesIncrementalRendering]):
3137 (-[WebPreferences setSuppressIncrementalRendering:]):
3138 (-[WebPreferences suppressIncrementalRendering]):
3139 * WebView/WebView.mm:
3140 (-[WebView _preferencesChanged:]):
3142 2012-02-22 Hajime Morrita <morrita@chromium.org>
3144 NOTIFICATIONS should be implemented as PageSupplement
3145 https://bugs.webkit.org/show_bug.cgi?id=79052
3147 Reviewed by Adam Barth.
3149 * WebView/WebView.mm:
3150 (-[WebView _commonInitializationWithFrameName:groupName:]):
3152 2012-02-21 Ryosuke Niwa <rniwa@webkit.org>
3154 Remove the remaining uses of CSSStyleDeclaration in Editor
3155 https://bugs.webkit.org/show_bug.cgi?id=78939
3157 Reviewed by Enrica Casucci.
3159 * WebCoreSupport/WebEditorClient.h:
3161 * WebCoreSupport/WebEditorClient.mm:
3162 (WebEditorClient::shouldApplyStyle):
3163 * WebView/WebFrame.mm:
3164 (-[WebFrame _setTypingStyle:withUndoAction:]):
3165 * WebView/WebHTMLView.mm:
3166 (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
3167 (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
3168 * WebView/WebView.mm:
3169 (-[WebView applyStyle:]):
3171 2012-02-22 Ryosuke Niwa <rniwa@webkit.org>
3173 Remove the remaining uses of CSSStyleDeclaration in Editor
3174 https://bugs.webkit.org/show_bug.cgi?id=78939
3176 Reviewed by Enrica Casucci.
3178 * WebCoreSupport/WebEditorClient.h:
3180 * WebCoreSupport/WebEditorClient.mm:
3181 (WebEditorClient::shouldApplyStyle):
3182 * WebView/WebFrame.mm:
3183 (-[WebFrame _setTypingStyle:withUndoAction:]):
3184 * WebView/WebHTMLView.mm:
3185 (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
3186 (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
3187 * WebView/WebView.mm:
3188 (-[WebView applyStyle:]):
3190 2012-02-22 Jon Lee <jonlee@apple.com>
3192 Part of r108409 was incorrect, and incorporated an older version of a sub-patch.
3193 This is the actual sub-patch that should have been submitted.
3195 * WebCoreSupport/WebNotificationClient.h:
3196 * WebCoreSupport/WebNotificationClient.mm:
3197 (WebNotificationClient::show):
3198 (WebNotificationClient::cancel):
3199 (WebNotificationClient::clearNotifications):
3200 (WebNotificationClient::notificationObjectDestroyed):
3201 (WebNotificationClient::notificationControllerDestroyed):
3203 2012-02-21 Jon Lee <jonlee@apple.com>
3205 Build fix. Push ENABLE_NOTIFICATIONS into .mm file.
3207 * WebCoreSupport/WebNotificationClient.h:
3208 * WebView/WebNotification.h:
3209 * WebView/WebNotification.mm:
3210 (-[WebNotification title]):
3211 (-[WebNotification body]):
3212 (-[WebNotification origin]):
3213 (-[WebNotification notificationID]):
3214 (-[WebNotification dispatchShowEvent]):
3215 (-[WebNotification dispatchCloseEvent]):
3216 (-[WebNotification dispatchClickEvent]):
3217 (-[WebNotification dispatchErrorEvent]):
3219 2012-02-21 John Sullivan <sullivan@apple.com>
3223 * WebView/WebUIDelegatePrivate.h:
3224 Added @class declarations for DOMNode and DOMElement.
3226 2012-02-21 Jon Lee <jonlee@apple.com>
3228 Build fix for r108409.
3230 * WebCoreSupport/WebNotificationClient.h:
3232 * WebCoreSupport/WebNotificationClient.mm:
3233 * WebView/WebNotification.h:
3234 (WebSecurityOrigin):
3235 * WebView/WebNotification.mm:
3237 (-[WebNotification initWithCoreNotification:notificationID:]):
3239 2012-02-21 Jon Lee <jonlee@apple.com>
3241 Bring notifications support to WK1 mac: permission requests
3242 https://bugs.webkit.org/show_bug.cgi?id=78783
3243 <rdar://problem/10610578>
3245 Reviewed by Anders Carlsson.
3247 * WebCoreSupport/WebNotificationClient.h:
3248 * WebCoreSupport/WebNotificationClient.mm: Create policy listener, which conforms to the
3249 WebAllowDenyPolicyListener protocol, similar to geolocation.
3250 (WebNotificationClient::requestPermission):
3251 (WebNotificationClient::checkPermission):
3252 (-[WebNotificationPolicyListener initWithCallback:]):
3253 (-[WebNotificationPolicyListener allow]): Call the callback.
3254 (-[WebNotificationPolicyListener deny]): Call the callback.
3255 * WebView/WebUIDelegatePrivate.h: Define new UI delegate method to ask the user to decide a
3256 policy for navigations.
3259 Bring notifications support to WK1 mac: showing, canceling, removing notifications
3261 Create a WebKit wrapper object for WebCore::Notification, which also keeps track of an assigned
3263 * WebView/WebNotification.h: Added.
3264 (WebSecurityOrigin):
3265 * WebView/WebNotification.mm: Added.
3267 (-[WebNotification initWithCoreNotification:notificationID:]):
3268 (-[WebNotification init]):
3269 (-[WebNotification dealloc]):
3270 (-[WebNotification title]):
3271 (-[WebNotification body]):
3272 (-[WebNotification origin]):
3273 (-[WebNotification notificationID]):
3274 (-[WebNotification dispatchShowEvent]):
3275 (-[WebNotification dispatchCloseEvent]):
3276 (-[WebNotification dispatchClickEvent]):
3277 (-[WebNotification dispatchErrorEvent]):
3278 * WebView/WebNotificationInternal.h: Added.
3279 (WebCore): Internal category to allow creating instances with WebCore objects.
3281 Extend WebView to include a WebNotificationProvider, which clients implement.
3282 * WebView/WebViewData.h: Add a private member for the provider.
3283 * WebView/WebViewPrivate.h:
3284 * Define an enum WebNotificationPermission that mirrors WebCore::NotificationPresenter::Permission
3285 that client which implement the provider can use to return policy decisions.
3286 * Define WebNotificationProvider.
3287 * Category WebViewNotification extends WebView with methods that set and manager the
3288 notification provider, and handle events from the platform notifications.
3289 * WebView/WebView.mm:
3290 (-[WebView _setNotificationProvider:]): Sets the provider when initializing the WebView.
3291 (-[WebView _notificationControllerDestroyed]):
3292 (-[WebView _notificationProvider]):
3293 (-[WebView _notificationDidShow:]):
3294 (-[WebView _notificationDidClick:]):
3295 (-[WebView _notificationsDidClose:]):
3297 * WebCoreSupport/WebNotificationClient.h: Add variables that map between WebCore::Notification
3298 instances, their assigned IDs, their contexts, and corresponding WebKit wrapper objects.
3299 * WebCoreSupport/WebNotificationClient.mm:
3300 (generateNotificationID): Created unique IDs for each shown notification.
3301 (WebNotificationClient::show): Create wrapper object for notification, assign ID, cache the
3302 mappings between the objects, and forward it to the provider.
3303 (WebNotificationClient::cancel):
3304 (WebNotificationClient::clearNotifications): Clear all notifications associated with the
3306 (WebNotificationClient::notificationObjectDestroyed): Remove the notification from the maps.
3307 (WebNotificationClient::notificationControllerDestroyed): If the controller is destroyed, tell
3308 the provider to clear of the notifications related to this web view.
3311 (Prep work for) Bring notifications support to WK1 mac
3313 Rename WebGeolocationPolicyListener. The interface is generic enough to be reused for
3314 notification requests. To avoid having to create a new listener type, instead rename it
3315 to WebAllowDenyPolicyListener.
3316 * WebView/WebUIDelegatePrivate.h: Rename the protocol.
3317 * WebCoreSupport/WebGeolocationClient.mm: Refactor geolocation request listener to use
3320 Add preference to keep track of whether notifications are enabled in general.
3321 * WebView/WebPreferenceKeysPrivate.h: Add WebNotificationsEnabledKey for storing the
3323 * WebView/WebPreferences.mm:
3324 (+[WebPreferences initialize]): By default have them enabled.
3325 (-[WebPreferences setNotificationsEnabled:]):
3326 (-[WebPreferences notificationsEnabled]):
3327 * WebView/WebPreferencesPrivate.h:
3329 Add a stringValue method that exposes WebCore::SecurityOrigin::toString() for storing the
3330 notification policy for a given origin.
3331 * WebCoreSupport/WebSecurityOrigin.mm:
3332 (-[WebSecurityOrigin stringValue]):
3333 * WebCoreSupport/WebSecurityOriginPrivate.h:
3335 2012-02-21 Sam Weinig <sam@webkit.org>
3337 Attempt to fix the Snow Leopard build.
3339 * Configurations/Base.xcconfig:
3341 2012-02-21 Sam Weinig <sam@webkit.org>
3343 Use libc++ when building with Clang on Mac
3344 https://bugs.webkit.org/show_bug.cgi?id=78981
3346 Reviewed by Dan Bernstein.
3348 * Configurations/Base.xcconfig:
3350 2012-02-17 Mihnea Ovidenie <mihnea@adobe.com>
3352 CSS regions enabled by default
3353 https://bugs.webkit.org/show_bug.cgi?id=78525
3355 Reviewed by David Hyatt.
3357 Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
3358 CSSRegions are still enabled by default.
3359 In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
3361 * WebView/WebPreferenceKeysPrivate.h:
3362 * WebView/WebPreferences.mm:
3363 (+[WebPreferences initialize]):
3364 (-[WebPreferences cssRegionsEnabled]):
3365 (-[WebPreferences setCSSRegionsEnabled:]):
3366 * WebView/WebPreferencesPrivate.h:
3367 * WebView/WebView.mm:
3368 (-[WebView _preferencesChanged:]):
3370 2012-02-17 Enrica Casucci <enrica@apple.com>
3372 Refactor DragData class to use PlatformStrategies in the Mac implementation.
3373 https://bugs.webkit.org/show_bug.cgi?id=78768
3375 Reviewed by Darin Adler.
3377 * WebCoreSupport/WebPlatformStrategies.h: Added color() method.
3378 * WebCoreSupport/WebPlatformStrategies.mm:
3379 (WebPlatformStrategies::color):
3381 2012-02-16 Brady Eidson <beidson@apple.com>
3383 <rdar://problem/10616280> and https://bugs.webkit.org/show_bug.cgi?id=78767
3384 REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages
3386 Reviewed by Sam Weinig.
3388 * WebView/WebView.mm:
3389 (-[WebView _needsIsLoadingInAPISenseQuirk]):
3390 (-[WebView _preferencesChanged:]):
3392 2012-02-15 Enrica Casucci <enrica@apple.com>
3394 Refactor ClipboardMac class to use PlatformStrategies.
3395 https://bugs.webkit.org/show_bug.cgi?id=78554
3397 Reviewed by Anders Carlsson.
3399 * WebCoreSupport/WebDragClient.h: Changed methods signature to use name based pasteboard.
3400 * WebCoreSupport/WebDragClient.mm: Ditto.
3401 (WebDragClient::willPerformDragSourceAction):
3402 (WebDragClient::startDrag):
3403 (WebDragClient::declareAndWriteDragImage):
3404 * WebCoreSupport/WebPlatformStrategies.h: Added new methods.
3405 * WebCoreSupport/WebPlatformStrategies.mm:
3406 (WebPlatformStrategies::changeCount):
3407 (WebPlatformStrategies::uniqueName):
3409 2012-02-15 Sadrul Habib Chowdhury <sadrul@chromium.org>
3411 Notify ChromeClient when touch-event handlers are installed/removed.
3412 https://bugs.webkit.org/show_bug.cgi?id=77440
3414 Reviewed by Darin Fisher and Ryosuke Niwa.
3416 * WebCoreSupport/WebChromeClient.h:
3418 2012-02-14 Matt Lilek <mrl@apple.com>
3420 Don't ENABLE_DASHBOARD_SUPPORT unconditionally on all Mac platforms
3421 https://bugs.webkit.org/show_bug.cgi?id=78629
3423 Reviewed by David Kilzer.
3425 * Configurations/FeatureDefines.xcconfig:
3427 2012-02-14 Alexey Proskuryakov <ap@apple.com>
3429 [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
3430 https://bugs.webkit.org/show_bug.cgi?id=78541
3431 <rdar://problem/10036695>
3433 Reviewed by Kent Tamura.
3435 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default value of the
3438 2012-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
3440 Convert svg/animations to use SMIL methods for driving the timeline
3441 https://bugs.webkit.org/show_bug.cgi?id=78422
3443 Reviewed by Dirk Schulze.
3445 Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
3446 Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
3449 * WebView/WebFrame.mm:
3450 * WebView/WebFramePrivate.h:
3452 2012-02-13 Enrica Casucci <enrica@apple.com>
3454 Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
3455 https://bugs.webkit.org/show_bug.cgi?id=78282
3457 This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
3458 now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
3459 WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
3460 class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
3461 interface but this one more step in the direction of removing access to NSPasteboard from
3463 As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.
3465 Reviewed by Anders Carlsson.
3467 * WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
3468 * WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface.
3469 (WebPlatformStrategies::createPasteboardStrategy):
3470 (WebPlatformStrategies::getTypes):
3471 (WebPlatformStrategies::bufferForType):
3472 (WebPlatformStrategies::getPathnamesForType):
3473 (WebPlatformStrategies::stringForType):
3474 (WebPlatformStrategies::copy):
3475 (WebPlatformStrategies::setTypes):
3476 (WebPlatformStrategies::setBufferForType):
3477 (WebPlatformStrategies::setPathnamesForType):
3478 (WebPlatformStrategies::setStringForType):
3480 2012-02-12 Hajime Morrita <morrita@chromium.org>
3482 Page should have less intrusive way to associate API implementation objects.
3483 https://bugs.webkit.org/show_bug.cgi?id=78085
3485 Reviewed by Adam Barth.
3487 * WebView/WebView.mm:
3488 (-[WebView _commonInitializationWithFrameName:groupName:]):
3490 2012-02-11 Sheriff Bot <webkit.review.bot@gmail.com>
3492 Unreviewed, rolling out r107435.
3493 http://trac.webkit.org/changeset/107435
3494 https://bugs.webkit.org/show_bug.cgi?id=78410
3496 It broke the Qt build (Requested by Ossy on #webkit).
3498 * WebCoreSupport/WebPlatformStrategies.h:
3499 (WebPlatformStrategies):
3500 * WebCoreSupport/WebPlatformStrategies.mm:
3501 (WebPlatformStrategies::addVisitedLink):
3503 2012-02-10 Adam Klein <adamk@chromium.org>
3505 Enable MUTATION_OBSERVERS by default on all platforms
3506 https://bugs.webkit.org/show_bug.cgi?id=78196
3508 Reviewed by Ojan Vafai.
3510 * Configurations/FeatureDefines.xcconfig:
3512 2012-02-10 Enrica Casucci <enrica@apple.com>
3514 Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
3515 https://bugs.webkit.org/show_bug.cgi?id=78282
3517 This patch removes any accesss to the NSPasteboard object from the Pasteboard class which
3518 now makes use of a new pasteboardStrategy object that is implemented both in WebKit and
3519 WebKit2. The actual access to NSPasteboard is now performed inside the PlatformPasteboard
3520 class. Currently both WebKit and WebKit2 use the same implementation of the PasteboardStrategy
3521 interface but this one more step in the direction of removing access to NSPasteboard from
3523 As part of the refactoring the I've reduced to a minimum the use of OBJ-C classes.
3525 Reviewed by Anders Carlsson.
3527 * WebCoreSupport/WebPlatformStrategies.h: Added PasteboardStrategy.
3528 * WebCoreSupport/WebPlatformStrategies.mm: Added implementation of PasteboardStrategy interface.
3529 (WebPlatformStrategies::createPasteboardStrategy):
3530 (WebPlatformStrategies::getTypes):
3531 (WebPlatformStrategies::bufferForType):
3532 (WebPlatformStrategies::getPathnamesForType):
3533 (WebPlatformStrategies::stringForType):
3534 (WebPlatformStrategies::copy):
3535 (WebPlatformStrategies::setTypes):
3536 (WebPlatformStrategies::setBufferForType):
3537 (WebPlatformStrategies::setPathnamesForType):
3538 (WebPlatformStrategies::setStringForType):
3540 2012-02-10 Benjamin Poulain <bpoulain@apple.com>
3542 [Mac] DYLIB_INSTALL_NAME_BASE should not be prefixed by the SDKROOT
3543 https://bugs.webkit.org/show_bug.cgi?id=78320
3545 Reviewed by Joseph Pecoraro.
3547 <rdar://problem/10839750>
3549 * Configurations/WebKit.xcconfig:
3551 2012-02-09 Alexey Proskuryakov <ap@apple.com>
3553 REGRESSION (r104885): Articles not displayed in Vienna RSS reader
3554 https://bugs.webkit.org/show_bug.cgi?id=78280
3555 <rdar://problem/10762545>
3557 Reviewed by Oliver Hunt.
3559 * Misc/WebNSURLExtras.h:
3560 * Misc/WebNSURLExtras.mm: (-[NSURL _webkit_URLFromURLOrPath]):
3561 Added a method to create a URL from a path, similarly to what KURL used to do.
3563 * WebView/WebFrame.mm: (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
3564 Use it in an API where a known regression occurred.
3566 2012-02-07 Antti Koivisto <antti@apple.com>
3568 REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
3569 https://bugs.webkit.org/show_bug.cgi?id=78080
3571 Reviewed by Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
3573 * WebView/WebFrame.mm:
3574 (-[WebFrame _typingStyle]):
3576 2012-02-07 Tony Chang <tony@chromium.org>
3578 merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
3579 https://bugs.webkit.org/show_bug.cgi?id=78036
3581 Reviewed by Darin Adler.
3583 * Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
3585 2012-02-06 Anders Carlsson <andersca@apple.com>
3587 Overlay scrollbars flash when window is simply activated
3588 https://bugs.webkit.org/show_bug.cgi?id=77911
3589 <rdar://problem/10211995>
3591 Reviewed by Kenneth Russell.
3593 * WebView/WebView.mm:
3594 (-[WebView _windowWillOrderOnScreen:]):
3595 (-[WebView _windowWillOrderOffScreen:]):
3596 Call FocusController::setContainingWindowIsVisible.
3599 2012-02-06 Matthew Delaney <mdelaney@apple.com>
3601 toDataURL() uses stale data after putImageData()
3602 https://bugs.webkit.org/show_bug.cgi?id=65767
3604 Reviewed by Chris Marrin.
3606 * WebCoreSupport/WebSystemInterface.mm:
3608 2012-02-03 Antti Koivisto <antti@apple.com>
3610 Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp
3611 https://bugs.webkit.org/show_bug.cgi?id=77779
3613 Reviewed by Darin Adler.
3615 * WebView/WebHTMLView.mm:
3617 2012-02-03 Antti Koivisto <antti@apple.com>
3619 https://bugs.webkit.org/show_bug.cgi?id=77740
3620 Split CSSMutableStyleDeclaration into separate internal and CSSOM types
3622 Reviewed by Andreas Kling and Darin Adler.
3624 * WebView/WebFrame.mm:
3625 (-[WebFrame _typingStyle]):
3627 2012-02-03 Beth Dakin <bdakin@apple.com>
3629 https://bugs.webkit.org/show_bug.cgi?id=77691
3630 Fix PlatformScreen layering violation and PlatformScreenMac's incorrect use
3633 Reviewed by Andy Estes.
3635 toUserSpace() and toDeviceSpace() don't need to take device scale. Also
3636 restore a comment that I needlessly removed.
3637 * WebCoreSupport/WebChromeClient.mm:
3638 (WebChromeClient::setWindowRect):
3639 (WebChromeClient::windowRect):
3641 2012-02-01 Dan Bernstein <mitz@apple.com>
3643 WebKit/mac part of <rdar://problem/10442663> Paginated display does not respect page-break-{before,after}
3644 https://bugs.webkit.org/show_bug.cgi?id=77505
3646 Reviewed by Darin Adler.
3648 * WebView/WebView.mm:
3649 (-[WebView _setPaginationBehavesLikeColumns:]): Added this setter.
3650 (-[WebView _paginationBehavesLikeColumns]): Added this getter.
3651 * WebView/WebViewPrivate.h:
3653 2012-01-25 Eric Seidel <eric@webkit.org>
3655 HTMLIsIndexElement should not expose HTMLInputElement properties
3656 https://bugs.webkit.org/show_bug.cgi?id=76095
3658 Reviewed by Adam Barth.
3660 * MigrateHeaders.make:
3662 2012-01-31 Pablo Flouret <pablof@motorola.com>
3664 Fix compilation errors on build-webkit --debug --no-workers on mac.
3665 https://bugs.webkit.org/show_bug.cgi?id=75869
3667 Reviewed by Adam Barth.
3669 * Workers/WebWorkersPrivate.mm:
3670 (+[WebWorkersPrivate workerThreadCount]):
3672 2012-01-30 Beth Dakin <bdakin@apple.com>
3674 https://bugs.webkit.org/show_bug.cgi?id=77263
3675 PlatformScreenMac should not rely on NSWindow for important bits of data
3677 Reviewed by Geoff Garen.
3679 toUserSpace() and toDeviceSpace() now take a parameter for the
3681 * WebCoreSupport/WebChromeClient.mm:
3682 (windowScaleFactor):
3683 (WebChromeClient::setWindowRect):
3684 (WebChromeClient::windowRect):
3686 2012-01-25 Mark Rowe <mrowe@apple.com>
3688 Build in to an alternate location when USE_STAGING_INSTALL_PATH is set.
3690 <rdar://problem/10609417> Adopt USE_STAGING_INSTALL_PATH
3692 Reviewed by David Kilzer.
3694 * Configurations/WebKit.xcconfig: Define NORMAL_WEBKIT_FRAMEWORKS_DIR, which contains
3695 the path where WebKit is normally installed. Update WEBKIT_FRAMEWORKS_DIR to point to
3696 the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Define
3697 NORMAL_PRODUCTION_FRAMEWORKS_DIR, which contains the path where our public frameworks
3698 are normally installed. Update PRODUCTION_FRAMEWORKS_DIR to point to the staged frameworks
3699 directory when USE_STAGING_INSTALL_PATH is set. Always set the framework's install name
3700 based on the normal framework location. This prevents an incorrect install name from being
3701 used when installing in to the staged frameworks directory. Look for our other frameworks
3702 in the staged frameworks directory when USE_STAGING_INSTALL_PATH is set. Update
3703 WEBCORE_PRIVATE_HEADERS_DIR to find WebCore at the top level of the staged frameworks
3704 directory when USE_STAGING_INSTALL_PATH is set, rather than finding it embedded inside of
3707 2012-01-25 Eric Seidel <eric@webkit.org>
3709 HTMLIsIndexElement should not expose HTMLInputElement properties
3710 https://bugs.webkit.org/show_bug.cgi?id=76095
3712 Reviewed by Adam Barth.
3714 * MigrateHeaders.make:
3716 2012-01-25 Hajime Morita <morrita@google.com>
3718 ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
3719 https://bugs.webkit.org/show_bug.cgi?id=76863
3721 Reviewed by Dimitri Glazkov.
3723 Added a feature flag.
3725 * Configurations/FeatureDefines.xcconfig:
3727 2012-01-25 Enrica Casucci <enrica@apple.com>
3729 WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
3730 https://bugs.webkit.org/show_bug.cgi?id=76951
3731 <rdar://problem/9325158>
3733 Reviewed by Alexey Proskuryakov.
3735 * WebView/WebHTMLView.mm: Removed typingAttributes implementation.
3736 * WebView/WebView.mm:
3737 (-[WebView typingAttributes]): Added.
3739 2012-01-24 Enrica Casucci <enrica@apple.com>
3741 WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
3742 https://bugs.webkit.org/show_bug.cgi?id=76951
3743 <rdar://problem/9325158>
3745 The Inspector bar calls the typingAttributes methods on the clients that support it
3746 to retrieve the set of attributes representing the style at the selection and uses
3747 this information to update the state of the B, I and U buttons.
3748 If this method is not supported, it defaults to the attributes of the previous
3749 character position, reporting an incorrect state.
3750 This occurs only when we have a caret selection.
3752 Reviewed by Alexey Proskuryakov.
3754 * WebView/WebHTMLView.mm:
3755 (-[WebHTMLView _styleForAttributeChange:]): Removed dead code.
3756 (-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore.
3757 (-[WebHTMLView typingAttributes]): Added.
3759 2012-01-24 Benjamin Poulain <bpoulain@apple.com>
3761 pageCacheSupportsPlugins should default to true on WebKit1
3762 https://bugs.webkit.org/show_bug.cgi?id=76891
3764 Reviewed by Joseph Pecoraro.
3766 The default was left out of r102619 by accident.
3768 * WebView/WebPreferences.mm:
3769 (+[WebPreferences initialize]):
3771 2012-01-23 Geoffrey Garen <ggaren@apple.com>
3773 JSValue::toString() should return a JSString* instead of a UString
3774 https://bugs.webkit.org/show_bug.cgi?id=76861
3776 Reviewed by Gavin Barraclough.
3778 Mechanical changes to call value() after calling toString(), to
3779 convert from "JS string" (JSString*) to "C++ string" (UString), since
3780 toString() no longer returns a "C++ string".
3782 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3783 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
3784 * WebView/WebFrame.mm:
3785 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
3786 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3788 2012-01-20 Sam Weinig <sam@webkit.org>
3790 Make WebCore RunLoop work for WebKit1
3791 https://bugs.webkit.org/show_bug.cgi?id=76739
3793 Reviewed by Anders Carlsson.
3795 * Carbon/CarbonWindowAdapter.mm:
3796 (+[CarbonWindowAdapter initialize]):
3797 * History/WebBackForwardList.mm:
3798 (+[WebBackForwardList initialize]):
3799 * History/WebHistoryItem.mm:
3800 (+[WebHistoryItem initialize]):
3801 * Misc/WebElementDictionary.mm:
3802 (+[WebElementDictionary initialize]):
3803 * Misc/WebIconDatabase.mm:
3804 (+[WebIconDatabase initialize]):
3805 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3806 (+[WebHostedNetscapePluginView initialize]):
3807 * Plugins/WebBaseNetscapePluginView.mm:
3808 * Plugins/WebBasePluginPackage.mm:
3809 * Plugins/WebNetscapePluginView.mm:
3810 (+[WebNetscapePluginView initialize]):
3811 * WebCoreSupport/WebEditorClient.mm:
3812 (+[WebUndoStep initialize]):
3813 * WebCoreSupport/WebFrameLoaderClient.mm:
3814 * WebView/WebArchive.mm:
3815 (+[WebArchivePrivate initialize]):
3816 * WebView/WebDataSource.mm:
3817 (+[WebDataSourcePrivate initialize]):
3818 * WebView/WebHTMLView.mm:
3819 (+[WebHTMLViewPrivate initialize]):
3820 (+[WebHTMLView initialize]):
3821 * WebView/WebResource.mm:
3822 (+[WebResourcePrivate initialize]):
3823 * WebView/WebTextIterator.mm:
3824 (+[WebTextIteratorPrivate initialize]):
3825 * WebView/WebView.mm:
3826 (+[WebView initialize]):
3827 * WebView/WebViewData.mm:
3828 (+[WebViewPrivate initialize]):
3829 Initialized the main run loop in addition to other initialization.
3831 2012-01-20 Simon Fraser <simon.fraser@apple.com>
3833 https://bugs.webkit.org/show_bug.cgi?id=76444
3835 #if ENABLE(CSS_SHADERS) cannot appear in framework headers.
3838 * WebView/WebPreferences.mm:
3839 * WebView/WebPreferencesPrivate.h:
3841 2012-01-20 Alexandru Chiculita <achicu@adobe.com>
3843 CSS Shaders: Add a Settings flag to enable/disable CSS Shaders at runtime
3844 https://bugs.webkit.org/show_bug.cgi?id=76444
3846 Added private WebPreference property called "WebKitCSSCustomFilterEnabled".
3848 Reviewed by Nikolas Zimmermann.
3850 * WebView/WebPreferenceKeysPrivate.h:
3851 * WebView/WebPreferences.mm:
3852 (+[WebPreferences initialize]):
3853 (-[WebPreferences cssCustomFilterEnabled]):
3854 (-[WebPreferences setCSSCustomFilterEnabled:]):
3855 * WebView/WebPreferencesPrivate.h:
3856 * WebView/WebView.mm:
3857 (-[WebView _preferencesChanged:]):
3859 2012-01-17 Enrica Casucci <enrica@apple.com>
3861 Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
3862 https://bugs.webkit.org/show_bug.cgi?id=76490
3863 <rdar://problem/9460733>
3865 Starting with Lion, there is no more NSForegroundColor attribute in the dictionary
3866 if the color matches the default (solid black).
3867 The fix consists in treating the lack of color as solid black instead of transparent as
3870 Added a TestWebKitAPI test.
3872 Reviewed by Darin Adler and Dan Bernstein.
3874 * WebView/WebHTMLView.mm:
3875 (-[WebHTMLView _styleForAttributeChange:]):
3877 2012-01-17 Matthew Delaney <mdelaney@apple.com>
3879 On post-Lion releases, preserve the Lion behavior where WebKit explicitly calls -setGeometryFlipped on the hosting layer for applications that were linked on Lion or earlier.
3880 <rdar://problem/10692025>
3882 Reviewed by Simon Fraser.
3884 * WebCoreSupport/WebSystemInterface.mm: Init newly added function.
3885 * WebView/WebHTMLView.mm: Added case for post-Lion builds that calls -setGeometryFlipped if the app is linked on or before Lion.
3887 2012-01-17 Enrica Casucci <enrica@apple.com>
3889 REGRESSION (r101413): Correction panel overlaps misspelled text.
3890 https://bugs.webkit.org/show_bug.cgi?id=74589
3891 <rdar://problem/10585115>
3893 When converting the rectangle from the root view, we need
3894 to take into account the height of the rectangle.
3896 Reviewed by Anders Carlsson.
3898 * WebView/WebView.mm:
3899 (-[WebView _convertRectFromRootView:]):
3901 2012-01-16 Simon Fraser <simon.fraser@apple.com>
3903 <rdar://problem/10703228> ASSERTION FAILED: Uncaught exception - Cannot lock focus on image <NSImage 0x1206572a0 Size={0, 0} Reps=( )>, because it is size zero loading techcrunch.com
3905 Reviewed by Anders Carlsson.
3907 Avoid trying to create image snapshots for zero-sized plugins, because
3908 it causes -[NSView lockFocus] to throw an exception.
3910 * Plugins/WebBaseNetscapePluginView.mm:
3911 (-[WebBaseNetscapePluginView cacheSnapshot]):
3913 2012-01-16 Alexey Proskuryakov <ap@apple.com>
3915 A follow-up fix for:
3916 A warning is logged to console when typing a bare "/" in Safari address bar
3917 https://bugs.webkit.org/show_bug.cgi?id=76236
3919 <rdar://problem/10702986>
3921 Reviewed by John Sullivan.
3923 * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): It's OK to have a
3924 path when there is a base URL.
3926 2012-01-16 Jon Lee <jonlee@apple.com>
3928 Build fix for r105086.
3930 * Configurations/FeatureDefines.xcconfig:
3932 2012-01-12 Alexey Proskuryakov <ap@apple.com>
3934 A warning is logged to console when typing a bare "/" in Safari address bar
3935 https://bugs.webkit.org/show_bug.cgi?id=76236
3937 Reviewed by John Sullivan.
3939 * Misc/WebNSURLExtras.mm: (+[NSURL _web_URLWithData:relativeToURL:]): Bail out early for paths.
3941 2012-01-16 Pablo Flouret <pablof@motorola.com>
3943 Fix compilation errors on build-webkit --debug --no-svg --no-svg-fonts --no-svg-dom-objc-bindings on mac.
3944 https://bugs.webkit.org/show_bug.cgi?id=75865
3946 Reviewed by Hajime Morita.
3948 * WebView/WebFrame.mm:
3949 (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):
3951 2012-01-15 Pablo Flouret <pablof@motorola.com>
3953 Fix compilation errors on build-webkit --debug --no-video on mac.
3954 https://bugs.webkit.org/show_bug.cgi?id=75867
3956 Reviewed by Philippe Normand.
3958 - WebChromeClient::fullScreenRendererChanged() declaration wrongly guarded
3959 by VIDEO feature instead of FULLSCREEN_API.
3960 - _isAnyMoviePlaying implementation depends on VIDEO.
3962 * WebCoreSupport/WebChromeClient.h:
3963 * WebView/WebFullScreenController.mm:
3964 (-[WebFullScreenController _isAnyMoviePlaying]):
3966 2012-01-11 Beth Dakin <bdakin@apple.com>
3968 https://bugs.webkit.org/show_bug.cgi?id=75904
3969 WebKit 1: Scrollbar uiStateTransitionProgress requires tracking the mouse all
3972 <rdar://problem/10498816>
3974 Reviewed by Darin Adler.
3976 New ivar trackingAreaForNonKeyWindow stores our NSTrackingArea whenever we
3978 * WebView/WebHTMLView.mm:
3979 (-[WebHTMLViewPrivate dealloc]):
3980 (-[WebHTMLViewPrivate clear]):
3982 When we know that mouse movements won't affect anything other than
3983 scrollbars, call our new function passMouseMovedEventToScrollbars(),
3984 otherwise we'll call the old mouseMoved().
3985 (mouseEventIsPartOfClickOrDrag):
3986 (-[WebHTMLView _updateMouseoverWithEvent:]):
3988 Make sure not to remove the mouse observer when there are legacy scrollbars.
3989 (-[WebHTMLView removeMouseMovedObserver]):
3991 Set up a tracking area when the window is not key to ensure that the WebView
3992 gets the relevant events. Remove it when the window is key again so that we
3993 rely on the existing mechanism.
3994 (-[WebHTMLView windowDidBecomeKey:]):
3995 (-[WebHTMLView windowDidResignKey:]):
3997 2012-01-10 Dan Bernstein <mitz@apple.com>
3999 Made -[WebHistoryItem copyWithZone:] allocate an object of the same class as the receiver.
4001 Reviewed by Mark Rowe.
4003 * History/WebHistoryItem.mm:
4004 (-[WebHistoryItem copyWithZone:]):
4006 2012-01-10 Chris Marrin <cmarrin@apple.com>
4008 Wrapped allowedCompositingTriggers in ACCELERATED_COMPOSITING ifdef to make non-accelerated builds work
4012 * WebCoreSupport/WebChromeClient.h:
4014 2012-01-10 Chris Marrin <cmarrin@apple.com>
4016 Turn off the FilterTrigger in WebKit and WebKit2
4017 https://bugs.webkit.org/show_bug.cgi?id=75914
4019 Reviewed by Simon Fraser.
4021 Implement allowedCompositingTriggers to turn on all compositing triggers except FilterTrigger.
4023 * WebCoreSupport/WebChromeClient.h:
4024 (WebChromeClient::allowedCompositingTriggers):
4026 2012-01-10 Dan Bernstein <mitz@apple.com>
4028 Change -[WebHistoryItem copyWithZone:] to not use NSCopyObject()
4029 https://bugs.webkit.org/show_bug.cgi?id=75980
4031 Reviewed by Mark Rowe.
4033 * History/WebHistoryItem.mm:
4034 (-[WebHistoryItem copyWithZone:]): Replaced NSCopyObject() with
4035 -alloc, -initWithWebCoreHistoryItem:.
4037 2012-01-06 Simon Fraser <simon.fraser@apple.com>
4039 Mitigate scrollbar differences when running pixel tests
4040 https://bugs.webkit.org/show_bug.cgi?id=67217
4042 Reviewed by Dan Bernstein.
4044 Make it possible to register a custom NSScroller class, which
4045 the WebDynamicScrollBarsView will use when mock scrollbars are enabled.
4047 Also ensure that the WebPreferences mock scrollbars preference is
4048 migrated into Settings.
4050 * WebView/WebDynamicScrollBarsView.h:
4051 * WebView/WebDynamicScrollBarsView.mm:
4052 (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
4053 (+[WebDynamicScrollBarsView _verticalScrollerClass]):
4054 (+[WebDynamicScrollBarsView setCustomScrollerClass:]):
4055 * WebView/WebView.mm:
4056 (-[WebView _preferencesChanged:]):
4058 2012-01-05 Dan Bernstein <mitz@apple.com>
4060 <rdar://problem/10633760> Update copyright strings
4062 Reviewed by Mark Rowe.
4066 2012-01-05 Pratik Solanki <psolanki@apple.com>
4068 WebFrameLoaderClient::userAgent does unnecessary NSString/NSURL conversions
4069 https://bugs.webkit.org/show_bug.cgi?id=75586
4071 Reviewed by Alexey Proskuryakov.
4073 We do unnecessary KURL->NSURL* and String<->NSString* when calling [WebView
4074 userAgentForURL:] from WebFrameLoaderClient::userAgent. Instead we add a separate function,
4075 _userAgentString that returns a WTF::String to make this call faster.
4077 * WebCoreSupport/WebFrameLoaderClient.mm:
4078 (WebFrameLoaderClient::userAgent):
4079 * WebView/WebView.mm:
4080 (-[WebView _userAgentString]):
4081 (-[WebView userAgentForURL:]):
4082 * WebView/WebViewInternal.h:
4084 2012-01-04 Anders Carlsson <andersca@apple.com>
4086 Ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm
4087 https://bugs.webkit.org/show_bug.cgi?id=75447
4089 Reviewed by Brian Weinstein.
4091 Resolve the ambiguity.
4093 * Misc/WebNSPasteboardExtras.mm:
4094 (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
4096 2012-01-04 Mihnea Ovidenie <mihnea@adobe.com>
4098 [Mac]Fix build after changeset 103997
4099 https://bugs.webkit.org/show_bug.cgi?id=75530
4101 Reviewed by Andreas Kling.
4103 * WebView/WebFrame.mm:
4104 * WebView/WebHTMLView.mm:
4105 * WebView/WebPDFView.mm:
4106 * WebView/WebView.mm:
4108 2012-01-03 Jon Lee <jonlee@apple.com>
4110 Leak of WebNotificationClient when page is destroyed
4111 https://bugs.webkit.org/show_bug.cgi?id=74980
4112 <rdar://problem/10611231>
4114 Reviewed by Mark Rowe.
4116 * WebCoreSupport/WebNotificationClient.h:
4117 * WebCoreSupport/WebNotificationClient.mm:
4118 (WebNotificationClient::notificationControllerDestroyed): Remove the instance.
4120 2012-01-02 Dan Bernstein <mitz@apple.com>
4122 [mac] Remove -[WebView setHoverFeedbackSuspended:]
4123 https://bugs.webkit.org/show_bug.cgi?id=75406
4125 Reviewed by Tim Hatcher.
4127 * WebView/WebHTMLView.mm:
4128 (-[WebHTMLView _updateMouseoverWithEvent:]): Removed check for suspended hover updates.
4129 * WebView/WebHTMLViewInternal.h: Removed -_hoverFeedbackSuspendedChanged.
4130 * WebView/WebView.mm:
4131 (-[WebView setHoverFeedbackSuspended:]): Left empty implementation to support versions of
4132 Safari that call this.
4133 (-[WebView isHoverFeedbackSuspended]): Left implementation that always returns NO to support
4134 versions of Safari that call this.
4135 * WebView/WebViewData.h: Removed hoverFeedbackSuspended ivar.
4136 * WebView/WebViewPrivate.h: Removed method definitions.
4138 2011-12-31 Dan Bernstein <mitz@apple.com>
4140 WebKit/mac changes for: REGRESSION (WebKit2): Cursor, hover states not updated when page scrolls under stationary mouse pointer
4141 https://bugs.webkit.org/show_bug.cgi?id=75405
4143 Reviewed by Anders Carlsson.
4145 Removed the WebKit/mac mechanism for dispatching fake mouse moved events
4146 when an HTML frame scrolls, since FrameView now does this.
4148 * WebView/WebHTMLView.mm:
4149 (-[WebHTMLViewPrivate dealloc]): Removed an assertion about a removed ivar.
4150 (-[WebHTMLView _updateMouseoverWithFakeEvent]): Removed call to
4151 -_cancelUpdateMouseoverTimer.
4152 (-[WebHTMLView _frameOrBoundsChanged]): Removed code to schedule a timer
4153 for dispatching a mouse moved event on scroll.
4154 (-[WebHTMLView close]): Removed call to _cancelUpdateMouseoverTimer.
4155 (-[WebHTMLView viewWillMoveToWindow:]): Ditto.
4156 (-[WebHTMLView mouseDown:]): Ditto.
4158 2011-12-23 Ryosuke Niwa <rniwa@webkit.org>
4160 Chromium Mac build fix.
4162 * WebCoreSupport/WebSystemInterface.mm:
4163 (InitWebCoreSystemInterface):
4165 2011-12-21 Sam Weinig <sam@webkit.org>
4167 Start extracting platform specific bits out of PlatformEvents
4168 https://bugs.webkit.org/show_bug.cgi?id=75063
4170 Reviewed by Anders Carlsson.
4172 * WebCoreSupport/WebSystemInterface.mm:
4173 (InitWebCoreSystemInterface):
4174 * WebView/WebFrame.mm:
4175 * WebView/WebHTMLView.mm:
4176 (-[WebHTMLView menuForEvent:]):
4177 (-[WebHTMLView acceptsFirstMouse:]):
4178 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
4179 (currentKeyboardEvent):
4180 (-[WebHTMLView flagsChanged:]):
4181 * WebView/WebPDFView.mm:
4182 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4183 * WebView/WebView.mm:
4185 2011-12-21 Timothy Hatcher <timothy@apple.com>
4187 Web Inspector: suppress incremental rendering and use application chrome mode
4189 https://webkit.org/b/75026
4191 Reviewed by Joseph Pecoraro.
4193 * WebCoreSupport/WebInspectorClient.mm:
4194 (-[WebInspectorWindowController init]): Sort the preferences, remove the Leopard font family setting,
4195 set suppress incremental rendering and use application chrome mode.
4197 2011-12-20 Pavel Feldman <pavel.feldman@gmail.com>
4199 Web Inspector: reproducible crash after closing web inspector and browser window (iCab)
4200 https://bugs.webkit.org/show_bug.cgi?id=74255
4202 Reviewed by Yury Semikhatsky.
4204 * WebCoreSupport/WebInspectorClient.h:
4205 * WebCoreSupport/WebInspectorClient.mm:
4206 (WebInspectorClient::bringFrontendToFront):
4207 (-[WebInspectorWindowController destroyInspectorView:]):
4209 2011-12-19 Eric Carlson <eric.carlson@apple.com>
4211 Enable <track> for Mac build
4212 https://bugs.webkit.org/show_bug.cgi?id=74838
4214 Reviewed by Darin Adler.
4216 * Configurations/FeatureDefines.xcconfig:
4218 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
4220 Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
4221 https://bugs.webkit.org/show_bug.cgi?id=74748
4223 Reviewed by Eric Seidel.
4225 * WebCoreSupport/WebEditorClient.h:
4226 * WebCoreSupport/WebEditorClient.mm:
4227 (WebEditorClient::registerUndoOrRedoStep):
4228 (WebEditorClient::registerUndoStep):
4229 (WebEditorClient::registerRedoStep):
4231 2011-12-16 Sam Weinig <sam@webkit.org>
4233 Give PlatformEvents a base class
4234 https://bugs.webkit.org/show_bug.cgi?id=74685
4236 Reviewed by Anders Carlsson.
4238 Add a base class for PlatformMouseEvent, PlatformKeyboardEvent, PlatformWheelEvent
4239 and PlatformGestureEvent and move Type enumeration and modifiers down to it.
4241 * WebView/WebFrame.mm:
4242 (-[WebFrame _dragSourceEndedAt:operation:]):
4243 * WebView/WebHTMLView.mm:
4244 (currentKeyboardEvent):
4245 (-[WebHTMLView _interpretKeyEvent:savingCommands:]):
4246 * WebView/WebPDFView.mm:
4247 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4249 2011-12-16 Simon Fraser <simon.fraser@apple.com>
4251 Fix a #elsif fumble in my earlier commit.
4253 * WebView/WebHTMLView.mm:
4254 (-[WebHTMLView attachRootLayer:]):
4256 2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
4258 Only EditCommandComposition should implement unapply and reapply
4259 https://bugs.webkit.org/show_bug.cgi?id=74490
4261 Reviewed by Eric Seidel.
4263 * WebCoreSupport/WebEditorClient.h:
4264 * WebCoreSupport/WebEditorClient.mm:
4265 (-[WebUndoStep initWithUndoStep:]):
4266 (-[WebUndoStep dealloc]):
4267 (+[WebUndoStep stepWithUndoStep:]):
4268 (-[WebUndoStep step]):
4269 (-[WebEditorUndoTarget undoEditing:]):
4270 (-[WebEditorUndoTarget redoEditing:]):
4271 (WebEditorClient::registerCommandForUndoOrRedo):
4272 (WebEditorClient::registerCommandForUndo):
4273 (WebEditorClient::registerCommandForRedo):
4275 2011-12-16 Simon Fraser <simon.fraser@apple.com>
4277 <rdar://problem/10589427> Avoid calling -setGeometryFlipped ourselves on the layer hosting view's layer
4279 Reviewed by Sam Weinig.
4281 Now that we're using a flipped view to host the compositing layers,
4282 we should not set geometryFlipped on the root layer ourselves.
4284 * WebView/WebHTMLView.mm:
4285 (-[WebHTMLView attachRootLayer:]):
4287 2011-12-16 Mark Hahnenberg <mhahnenberg@apple.com>
4289 De-virtualize destructors
4290 https://bugs.webkit.org/show_bug.cgi?id=74331
4292 Reviewed by Geoffrey Garen.
4294 * Plugins/Hosted/ProxyRuntimeObject.h: Remove empty virtual destructor.
4295 * Plugins/Hosted/ProxyRuntimeObject.mm:
4297 2011-12-14 Ryosuke Niwa <rniwa@webkit.org>
4299 Mac build fix after r102874.
4301 * WebCoreSupport/WebChromeClient.mm:
4303 2011-12-14 Jing Zhao <jingzhao@chromium.org>
4305 Opening two popup menus by dispatchEvent() makes problems.
4306 https://bugs.webkit.org/show_bug.cgi?id=73304
4308 Reviewed by Kent Tamura.
4310 * WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().
4311 * WebCoreSupport/WebChromeClient.mm:
4312 (WebChromeClient::hasOpenedPopup): Not implemented.
4314 2011-12-14 Michael Saboff <msaboff@apple.com>
4316 Mac WebScriptDebugger crashes beneath sourceParsed()
4317 https://bugs.webkit.org/show_bug.cgi?id=74564
4319 Reviewed by Gavin Barraclough.
4321 * WebView/WebScriptDebugger.mm:
4322 (toNSString): Change to use ->characters() method to
4323 actually get characters for string conversion.
4325 2011-12-14 Hajime Morrita <morrita@chromium.org>
4327 JS_INLINE and WTF_INLINE should be visible from WebCore
4328 https://bugs.webkit.org/show_bug.cgi?id=73191
4330 Reviewed by Kevin Ollivier.
4332 Removed macro definitions which is now provided by Platform.h
4336 2011-12-13 Jon Lee <jonlee@apple.com>
4338 Enable notifications on Mac.
4340 Reviewed by Sam Weinig.
4342 * Configurations/FeatureDefines.xcconfig:
4344 2011-12-12 Ryosuke Niwa <rniwa@webkit.org>
4346 WebKit code shouldn't be calling applyCommand directly
4347 https://bugs.webkit.org/show_bug.cgi?id=74337
4349 Reviewed by Darin Adler.
4351 * WebView/WebFrame.mm:
4352 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
4354 2011-12-12 Brady Eidson <beidson@apple.com>
4356 Page cache should support pages with plugins.
4357 <rdar://problem/5190122> and https://bugs.webkit.org/show_bug.cgi?id=13634
4359 Expose a WebKit preference for the page cache supporting plugins (on by default).
4361 Reviewed by Anders Carlsson.
4363 * WebView/WebPreferenceKeysPrivate.h:
4365 * WebView/WebPreferences.mm:
4366 (-[WebPreferences pageCacheSupportsPlugins]):
4367 (-[WebPreferences setPageCacheSupportsPlugins:]):
4368 * WebView/WebPreferencesPrivate.h:
4370 * WebView/WebView.mm:
4371 (-[WebView _preferencesChanged:]):
4373 2011-12-12 Dan Bernstein <mitz@apple.com>
4375 <rdar://problem/10328474> Text highlight changes to gray selection color when menu extra is shown
4377 Reviewed by John Sullivan.
4379 * WebView/WebView.mm:
4380 (-[WebView _updateActiveState]): Changed to use -[NSWindow _hasKeyAppearance] instead
4381 of -isKeyWindow. The former also returns YES when a menu extra is open.
4382 (-[WebView addWindowObserversForWindow:]): Removed code to observe
4383 NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification.
4384 (-[WebView removeWindowObservers]): Removed code to stop observing the above.
4385 (-[WebView _windowChangedKeyState]): Overridden this to call _updateActiveState.
4386 This is called when the result of -_hasKeyAppearance changes.
4387 (-[WebView _windowWillOrderOnScreen:]): Removed call to _updateActiveState,
4388 previously needed for popovers, because _windowChangedKeyState is invoked
4389 at the right time for them.
4390 (-[WebView _windowWillOrderOffScreen:]): Ditto.
4392 2011-12-07 Mark Rowe <mrowe@apple.com>
4394 Fix the 32-bit build.
4396 Ignore some warnings that only occur in 32-bit.
4398 * Plugins/WebNetscapePluginPackage.mm:
4400 2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
4402 Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
4403 https://bugs.webkit.org/show_bug.cgi?id=73986
4405 Reviewed by Kenneth Rohde Christiansen.
4407 * WebView/WebView.mm:
4408 (-[WebView _commonInitializationWithFrameName:groupName:]):
4410 2011-12-06 Alexey Proskuryakov <ap@apple.com>
4412 REGRESSION (WebKit2): Kill ring is not cleared when selection changes
4413 https://bugs.webkit.org/show_bug.cgi?id=73888
4414 <rdar://problem/10532310>
4416 Reviewed by Mark Rowe.
4418 * WebView/WebHTMLView.mm:
4419 (-[WebHTMLView becomeFirstResponder]): Added a FIXME comment.
4420 (-[WebHTMLView _selectionChanged]): Moved the code to clear kill ring to WebCore. The rest
4421 of kill ring implementation is there, so it makes no sense to have this call in WebKits.
4423 2011-12-05 Anders Carlsson <andersca@apple.com>
4425 Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not
4426 https://bugs.webkit.org/show_bug.cgi?id=73862
4428 Reviewed by Andy Estes.
4430 Remove the call to LayerFlushScheduler::invalidate and return true instead. Return false for the cases
4431 where we don't want the layer flush scheduler to be invalidated.
4433 * WebView/WebView.mm:
4434 (LayerFlushController::flushLayers):
4435 * WebView/WebViewData.h:
4437 2011-12-05 Eric Carlson <eric.carlson@apple.com>
4439 Add WebKit preferences for text track settings
4440 https://bugs.webkit.org/show_bug.cgi?id=73721
4442 Reviewed by John Sullivan.
4444 * WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
4445 and shouldDisplayTextDescriptions properties.
4447 * WebView/WebPreferences.mm:
4448 (+[WebPreferences initialize]): Initialize new preferences to NO.
4449 (-[WebPreferences setShouldDisplaySubtitles:]): Added.
4450 (-[WebPreferences shouldDisplaySubtitles]): Ditto.
4451 (-[WebPreferences setShouldDisplayCaptions:]): Ditto.
4452 (-[WebPreferences shouldDisplayCaptions]): Ditto.
4453 (-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto.
4454 (-[WebPreferences shouldDisplayTextDescriptions]): Ditto.
4455 * WebView/WebPreferencesPrivate.h:
4457 * WebView/WebView.mm:
4458 (-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs.
4460 2011-12-03 Dan Bernstein <mitz@apple.com>
4462 <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
4463 Reviewed by Darin Adler.
4465 * WebView/WebView.mm:
4466 (-[WebView _removeObjectForIdentifier:]): Changed the CFRelease(self) into
4467 a WebCFAutorelease(self). This prevents re-entry into this method due to
4468 the WebView closing and canceling all subresource loads, including the
4469 one we have just removed.
4471 2011-12-02 David Levin <levin@chromium.org>
4473 Rename WTF class from TemporarilyChange to TemporaryChange.
4474 https://bugs.webkit.org/show_bug.cgi?id=73479
4476 Reviewed by Eric Seidel.
4478 * ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
4479 * ForwardingHeaders/wtf/TemporaryChange.h: Added.
4481 2011-12-02 Simon Fraser <simon.fraser@apple.com>
4483 <rdar://problem/10423627> Layers are flipped in WebKit1 views
4485 Reviewed by Sam Weinig.
4487 Host the compositing layers in an NSView which is flipped, which helps AppKit
4488 get the geometry right in some situations.
4490 * WebView/WebHTMLView.mm:
4491 (-[WebLayerHostingFlippedView isFlipped]):
4492 (-[WebHTMLView attachRootLayer:]):
4494 2011-12-02 Hajime Morrita <morrita@chromium.org>
4496 Unreviewed, rolling out r101751 and r101775.
4497 http://trac.webkit.org/changeset/101751
4498 http://trac.webkit.org/changeset/101775
4499 https://bugs.webkit.org/show_bug.cgi?id=73191
4501 breaks Windows build
4505 2011-12-01 Hajime Morrita <morrita@chromium.org>
4507 JS_INLINE and WTF_INLINE should be visible from WebCore
4508 https://bugs.webkit.org/show_bug.cgi?id=73191
4510 Reviewed by Kevin Ollivier.
4512 Removed macro definitions which is now provided by Platform.h
4516 2011-11-30 Alexey Proskuryakov <ap@apple.com>
4518 Remove an unneeded argument from FrameLoaderClient::download
4519 https://bugs.webkit.org/show_bug.cgi?id=73486
4521 Reviewed by Andreas Kling.
4523 * WebCoreSupport/WebFrameLoaderClient.h:
4524 * WebCoreSupport/WebFrameLoaderClient.mm:
4525 (WebFrameLoaderClient::download):
4526 Updated for the change.
4528 2011-11-30 Dan Bernstein <mitz@apple.com>
4530 WebKit/mac part of: Allow the length of a page along the pagination axis to differ from the length of the view
4531 https://bugs.webkit.org/show_bug.cgi?id=73476
4533 Reviewed by Anders Carlsson.
4535 * WebView/WebView.mm:
4536 (-[WebView _setPageLength:]): Added this accessor.
4537 (-[WebView _pageLength]): Ditto.
4538 * WebView/WebViewPrivate.h:
4540 2011-11-30 Alexey Proskuryakov <ap@apple.com>
4542 Download page URL should be set by WebCore
4543 https://bugs.webkit.org/show_bug.cgi?id=73358
4545 Reviewed by Darin Adler.
4547 * WebCoreSupport/WebFrameLoaderClient.h: Removed setOriginalURLForDownload, which is now
4550 * WebCoreSupport/WebFrameLoaderClient.mm:
4551 (WebFrameLoaderClient::download): There is no need to set original URL post factum any more.
4552 (WebFrameLoaderClient::startDownload): Ditto.
4554 2011-11-29 David Levin <levin@chromium.org>
4556 Add a way to revert a variable to its previous value after leaving a scope.
4557 https://bugs.webkit.org/show_bug.cgi?id=73371
4559 Reviewed by Adam Barth.
4561 * ForwardingHeaders/wtf/TemporarilyChange.h: Added.
4563 2011-11-29 Jessie Berlin <jberlin@apple.com>
4565 WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins
4566 the first time it is called.
4567 https://bugs.webkit.org/show_bug.cgi?id=73374 (<rdar://problem/10196057>)
4569 Reviewed by Brady Eidson.
4571 * Storage/WebStorageTrackerClient.h:
4572 * Storage/WebStorageTrackerClient.mm:
4573 (WebStorageTrackerClient::didFinishLoadingOrigins):
4575 2011-11-15 Anders Carlsson <andersca@apple.com>
4577 DragClient::dragSourceActionMaskForPoint should use root view coordinates
4578 https://bugs.webkit.org/show_bug.cgi?id=72409
4580 Reviewed by Sam Weinig.
4582 * WebCoreSupport/WebDragClient.mm:
4583 (WebDragClient::dragSourceActionMaskForPoint):
4584 Use -[WebView _convertPointFromRootView:] to convert the point to the web view coordinate system.
4586 2011-11-15 Anders Carlsson <andersca@apple.com>
4588 EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates
4589 https://bugs.webkit.org/show_bug.cgi?id=72408
4591 Reviewed by Sam Weinig.
4593 * WebCoreSupport/CorrectionPanel.mm:
4594 (CorrectionPanel::show):
4595 Convert the bounding rect to web view coordinates.
4597 * WebView/WebView.mm:
4598 (-[WebView _convertPointFromRootView:]):
4599 (-[WebView _convertRectFromRootView:]):
4600 * WebView/WebViewInternal.h:
4601 Add helper methods for converting from root view coordinates to web view coordinates.
4603 2011-11-29 Roland Steiner <rolandsteiner@chromium.org>
4605 <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
4606 https://bugs.webkit.org/show_bug.cgi?id=72848
4608 Reviewed by Dimitri Glazkov.
4610 * Configurations/FeatureDefines.xcconfig:
4612 2011-11-28 Jon Lee <jonlee@apple.com>
4614 Create skeleton framework for notifications support in WK2
4615 https://bugs.webkit.org/show_bug.cgi?id=73253
4616 <rdar://problem/10356943>
4618 Reviewed by Sam Weinig.
4620 * Configurations/FeatureDefines.xcconfig: Split out ENABLE_NOTIFICATIONS based on platform.
4622 * WebCoreSupport/WebNotificationClient.h: Added.
4623 (WebNotificationClient::webView):
4624 * WebCoreSupport/WebNotificationClient.mm: Added. Implemented as stubs for now.
4625 (WebNotificationClient::WebNotificationClient):
4626 (WebNotificationClient::show):
4627 (WebNotificationClient::cancel):
4628 (WebNotificationClient::notificationObjectDestroyed):
4629 (WebNotificationClient::requestPermission):
4630 (WebNotificationClient::cancelRequestsForPermission):
4631 (WebNotificationClient::checkPermission):
4632 * WebView/WebView.mm: Set PageClient's notification client to an instance of this stubbed class.
4634 2011-11-28 Adam Roben <aroben@apple.com>
4636 Properly retain the OS X version string
4638 Fixes <http://webkit.org/b/73214> REGRESSION (r101215): Crash on launch beneath +[WebView
4639 _standardUserAgentWithApplicationName:]
4641 Reviewed by Antti Koivisto.
4643 * WebView/WebView.mm:
4644 (createMacOSXVersionString): Retain the string we're returning, since this function is
4645 supposed to return an owning reference to the caller.
4647 2011-11-28 Hayato Ito <hayato@chromium.org>
4649 Fix chromium canary build after r101215.
4650 Unreviewed. Build fix.
4652 * WebCoreSupport/WebSystemInterface.mm:
4653 (InitWebCoreSystemInterface):
4655 2011-11-27 Mark Rowe <mrowe@apple.com>
4657 <http://webkit.org/b/72665> Switch to a more modern approach to retrieving the OS marketing version
4659 Reviewed by Dan Bernstein.
4661 * WebCoreSupport/WebSystemInterface.mm:
4662 (InitWebCoreSystemInterface): Set up wkGetMacOSXVersionString.
4663 * WebView/WebView.mm:
4664 (createMacOSXVersionString): Use WKGetMacOSXVersionString.
4666 2011-11-26 Pavel Feldman <pfeldman@google.com>
4668 Web Inspector: remove disconnectFromBackend from the protocol.
4669 https://bugs.webkit.org/show_bug.cgi?id=73127
4671 Reviewed by Yury Semikhatsky.
4673 * WebCoreSupport/WebInspectorClient.h:
4674 * WebCoreSupport/WebInspectorClient.mm:
4675 (WebInspectorClient::inspectorDestroyed):
4676 (WebInspectorClient::closeInspectorFrontend):
4678 2011-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
4680 Unreviewed, rolling out r101193.
4681 http://trac.webkit.org/changeset/101193
4682 https://bugs.webkit.org/show_bug.cgi?id=73158
4684 Breaks Windows and Qt minimal. (Requested by pfeldman on
4687 * WebCoreSupport/WebInspectorClient.h:
4688 * WebCoreSupport/WebInspectorClient.mm:
4689 (WebInspectorClient::inspectorDestroyed):
4691 2011-11-26 Pavel Feldman <pfeldman@google.com>
4693 Web Inspector: remove disconnectFromBackend from the protocol.
4694 https://bugs.webkit.org/show_bug.cgi?id=73127
4696 Reviewed by Yury Semikhatsky.
4698 * WebCoreSupport/WebInspectorClient.h:
4699 * WebCoreSupport/WebInspectorClient.mm:
4700 (WebInspectorClient::inspectorDestroyed):
4701 (WebInspectorClient::closeInspectorFrontend):
4703 2011-11-22 Pavel Feldman <pfeldman@google.com>
4705 Web Inspector: remove Inspector::bringToFront from the protocol.
4706 https://bugs.webkit.org/show_bug.cgi?id=72937
4708 Reviewed by Yury Semikhatsky.
4710 * WebCoreSupport/WebInspectorClient.h:
4711 * WebCoreSupport/WebInspectorClient.mm:
4712 (WebInspectorClient::openInspectorFrontend):
4713 (WebInspectorClient::bringFrontendToFront):
4715 2011-11-21 Mark Rowe <mrowe@apple.com>
4717 Fix the SnowLeopard build.
4719 * Misc/WebNSFileManagerExtras.mm: Forward-declare DADiskCreateFromVolumePath on SnowLeopard as it was
4720 not yet declared in a public header.
4722 2011-11-20 Mark Rowe <mrowe@apple.com>
4724 <http://webkit.org/b/72661> Switch to a more modern approach to retrieving the startup volume name
4726 Use the DiskArbitration framework to retrieve the name of the startup volume rather than using Carbon
4729 Reviewed by Dan Bernstein.
4731 * Misc/WebNSFileManagerExtras.mm:
4732 (-[NSFileManager _webkit_startupVolumeName]): Retrieve a DADiskRef for the startup volume and copy
4733 the volume name from its description dictionary.
4735 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
4737 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
4738 https://bugs.webkit.org/show_bug.cgi?id=62985
4740 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
4741 methods for plumbing the menu action handlers through the WebKit and WebCore.
4742 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
4743 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
4744 WebKit/win and WebKit2 to follow.
4746 Reviewed by Yury Semikhatsky.
4748 * WebCoreSupport/WebInspectorClient.mm:
4749 (-[WebInspectorWindowController destroyInspectorView:]):
4750 * WebInspector/WebInspector.mm:
4751 (-[WebInspector showWindow]):
4752 (-[WebInspector show:]):
4753 (-[WebInspector showConsole:]):
4754 (-[WebInspector isDebuggingJavaScript]):
4755 (-[WebInspector toggleDebuggingJavaScript:]):
4756 (-[WebInspector startDebuggingJavaScript:]):
4757 (-[WebInspector stopDebuggingJavaScript:]):
4758 (-[WebInspector isProfilingJavaScript]):
4759 (-[WebInspector toggleProfilingJavaScript:]):
4760 (-[WebInspector startProfilingJavaScript:]):
4761 (-[WebInspector stopProfilingJavaScript:]):
4762 (-[WebInspector isJavaScriptProfilingEnabled]):
4763 (-[WebInspector setJavaScriptProfilingEnabled:]):
4764 (-[WebInspector isTimelineProfilingEnabled]):
4765 (-[WebInspector setTimelineProfilingEnabled:]):
4766 (-[WebInspector setFrontend:]):
4767 (-[WebInspector releaseFrontend]):
4768 (-[WebInspector showWindow:]):
4769 * WebInspector/WebInspectorFrontend.h:
4770 * WebInspector/WebInspectorFrontend.mm:
4771 (-[WebInspectorFrontend isDebuggingEnabled]):
4772 (-[WebInspectorFrontend setDebuggingEnabled:]):
4773 (-[WebInspectorFrontend isProfilingJavaScript]):
4774 (-[WebInspectorFrontend startProfilingJavaScript]):
4775 (-[WebInspectorFrontend stopProfilingJavaScript]):
4776 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
4777 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
4778 (-[WebInspectorFrontend isTimelineProfilingEnabled]):
4779 (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
4780 * WebInspector/WebInspectorPrivate.h:
4782 2011-11-21 Jochen Eisinger <jochen@chromium.org>
4784 Implement Meta referrer
4785 https://bugs.webkit.org/show_bug.cgi?id=72674
4787 Reviewed by Adam Barth.
4789 * Plugins/Hosted/HostedNetscapePluginStream.mm:
4790 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
4791 * Plugins/WebNetscapePluginStream.mm:
4792 (WebNetscapePluginStream::WebNetscapePluginStream):
4794 2011-10-17 Antonio Gomes <agomes@rim.com>
4796 Pass a Frame* parameter in EditorClient::respondToChangedSelection
4797 https://bugs.webkit.org/show_bug.cgi?id=70248
4799 Reviewed by Ryosuke Niwa.
4801 * WebCoreSupport/WebEditorClient.h:
4802 * WebCoreSupport/WebEditorClient.mm: Make use of the newly added Frame* parameter.
4803 (WebEditorClient::respondToChangedSelection):
4805 2011-11-17 Mark Rowe <mrowe@apple.com>
4807 <http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
4808 switch away from the deprecated APIs.
4810 Reviewed by Sam Weinig.
4812 * Plugins/WebBasePluginPackage.mm:
4813 * Plugins/WebNetscapePluginPackage.mm:
4814 (-[WebNetscapePluginPackage _tryLoad]):
4816 2011-11-18 Anton D'Auria <adauria@apple.com>
4818 bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true
4819 https://bugs.webkit.org/show_bug.cgi?id=72568
4821 Reviewed by David Kilzer.
4823 WebChromeClient::shouldInterruptJavaScript called CallUIDelegate, which used an id
4824 as the return value, which was then cast to a bool and always returned true. This
4825 patch uses CallUIDelegateReturningBoolean instead of CallUIDelegate, with the default
4828 * WebCoreSupport/WebChromeClient.mm:
4829 (WebChromeClient::shouldInterruptJavaScript):
4831 2011-11-16 Dan Bernstein <mitz@apple.com>
4833 WebKit/mac part of <rdar://problem/10262242> Add API for paginated display
4834 https://bugs.webkit.org/show_bug.cgi?id=72537
4836 Reviewed by Anders Carlsson.
4838 * WebView/WebView.mm:
4839 (-[WebView _setPaginationMode:]): Added this accessor.
4840 (-[WebView _paginationMode]): Ditto.
4841 (-[WebView _setGapBetweenPages:]): Ditto.
4842 (-[WebView _gapBetweenPages]): Ditto.
4843 (-[WebView _pageCount]): Ditto.
4844 * WebView/WebViewPrivate.h: Defined WebPaginationMode enum and values.
4846 2011-11-15 Andy Estes <aestes@apple.com>
4848 Consolidate the logic that creates run loop observers for flushing layer tree changes to CoreAnimation
4849 https://bugs.webkit.org/show_bug.cgi?id=72106
4851 Reviewed by Anders Carlsson.
4853 Remove code that schedules layer flushes and use LayerFlushScheduler instead.
4855 * WebView/WebView.mm:
4856 (-[WebView _close]): Invalidate the run loop observer and destroy the
4857 LayerFlushController.
4858 (LayerFlushController::flushLayers): Perform the work that
4859 layerSyncRunLoopObserverCallBack used to do.
4860 (-[WebView _scheduleCompositingLayerSync]): If layerFlushController has
4861 yet to be created, create it, then schedule a layer flush.
4862 * WebView/WebViewData.h:
4863 (LayerFlushController::create): Create a LayerFlushController that
4864 implements the LayerFlushSchedulerClient interface and contains a
4865 LayerFlushScheduler with itself as the client.
4866 * WebView/WebViewData.mm:
4867 (LayerFlushController::scheduleLayerFlush):
4868 (LayerFlushController::invalidateObserver):
4869 (LayerFlushController::LayerFlushController):
4871 2011-11-15 Jochen Eisinger <jochen@chromium.org>
4873 Rename ReferrerPolicy to clarify its meaning
4874 https://bugs.webkit.org/show_bug.cgi?id=72420
4876 Reviewed by Nate Chapin.
4878 * WebView/WebPDFView.mm:
4879 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4881 2011-11-15 Anders Carlsson <andersca@apple.com>
4883 HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
4884 https://bugs.webkit.org/show_bug.cgi?id=72397
4886 Reviewed by Dan Bernstein.
4888 * WebCoreSupport/WebChromeClient.h:
4889 * WebCoreSupport/WebChromeClient.mm:
4890 (WebChromeClient::screenToRootView):
4891 (WebChromeClient::rootViewToScreen):
4893 2011-11-14 Anders Carlsson <andersca@apple.com>
4895 HostWindow invalidation functions should use root view coordinates
4896 https://bugs.webkit.org/show_bug.cgi?id=72338
4898 Reviewed by Dan Bernstein.
4900 * WebCoreSupport/WebChromeClient.h:
4901 * WebCoreSupport/WebChromeClient.mm:
4902 (WebChromeClient::invalidateRootView):
4903 (WebChromeClient::invalidateContentsAndRootView):
4904 (WebChromeClient::invalidateContentsForSlowScroll):
4906 2011-11-14 Julien Chaffraix <jchaffraix@webkit.org>
4908 Add --css-grid-layout to build-webkit and the build systems
4909 https://bugs.webkit.org/show_bug.cgi?id=72320
4911 Reviewed by Ojan Vafai.
4913 * Configurations/FeatureDefines.xcconfig:
4915 2011-11-14 Tony Chang <tony@chromium.org>
4917 Remove the CSS3_FLEXBOX compile time flag and enable on all ports
4918 https://bugs.webkit.org/show_bug.cgi?id=72196
4920 Reviewed by Ojan Vafai.
4922 * Configurations/FeatureDefines.xcconfig:
4924 2011-11-07 Adam Barth <abarth@webkit.org>
4926 Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
4927 https://bugs.webkit.org/show_bug.cgi?id=71755
4929 Reviewed by Eric Seidel.
4931 * Plugins/Hosted/HostedNetscapePluginStream.mm:
4932 (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
4933 * Plugins/WebNetscapePluginStream.mm:
4934 (WebNetscapePluginStream::WebNetscapePluginStream):
4935 * WebView/WebView.mm:
4936 (-[WebView _commonInitializationWithFrameName:groupName:]):
4937 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
4938 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
4939 (+[WebView _resetOriginAccessWhitelists]):
4941 2011-11-08 Joseph Pecoraro <pecoraro@apple.com>
4943 Move NSRange / DOMRange functions back to WebFrameInternal
4944 https://bugs.webkit.org/show_bug.cgi?id=71844
4946 Reviewed by Alexey Proskuryakov.
4948 * WebView/WebFrame.mm:
4949 (-[WebFrame _convertNSRangeToDOMRange:]):
4950 (-[WebFrame _convertDOMRangeToNSRange:]):
4951 * WebView/WebFrameInternal.h:
4952 * WebView/WebFramePrivate.h:
4954 2011-11-08 Michael Saboff <msaboff@apple.com>
4956 Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
4957 https://bugs.webkit.org/show_bug.cgi?id=71761
4959 Changed WKPCEvaluate() to use emptyString() when the source is
4962 Reviewed by Gavin Barraclough.
4964 * Plugins/Hosted/NetscapePluginHostProxy.mm:
4967 2011-11-08 Beth Dakin <bdakin@apple.com>
4969 https://bugs.webkit.org/show_bug.cgi?id=71856
4970 WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of
4971 old NSWindowDidChangeResolutionNotification
4973 <rdar://problem/10317253>
4975 Reviewed by Tim Hatcher.
4977 * WebView/WebView.mm:
4978 (-[WebView addWindowObserversForWindow:]):
4979 (-[WebView removeWindowObservers]):
4981 We have to check that the backing scale factor actually changed since this
4982 notification can also be used to signify other changes.
4983 (-[WebView _windowDidChangeBackingProperties:]):
4985 2011-11-07 Adam Barth <abarth@webkit.org>
4987 Move DomainRelaxationForbidden scheme registry to SchemeRegistry
4988 https://bugs.webkit.org/show_bug.cgi?id=71750
4990 Reviewed by Eric Seidel.
4992 * WebView/WebView.mm:
4993 (+[WebView _setDomainRelaxationForbidden:forURLScheme:]):
4995 2011-11-07 Jessie Berlin <jberlin@apple.com>
4997 Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is
4999 https://bugs.webkit.org/show_bug.cgi?id=71631
5001 Reviewed by Jon Honeycutt.
5003 Add WebKit1 API to register a scheme as ignoring Private Browsing for Local Storage and
5006 * WebView/WebView.mm:
5007 (+[WebView _registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing:]):
5008 Call through to the SchemeRegistry function.
5009 (+[WebView _registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing:]):
5011 * WebView/WebViewPrivate.h:
5013 2011-11-03 Mark Hahnenberg <mhahnenberg@apple.com>
5015 De-virtualize JSObject::getPropertyNames
5016 https://bugs.webkit.org/show_bug.cgi?id=71306
5018 Reviewed by Darin Adler.
5020 Added getPropertyNames to the MethodTable, changed all the virtual
5021 implementations of getPropertyNames to static ones, and replaced
5022 all call sites with corresponding lookups in the MethodTable.
5024 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5025 (WebKit::NetscapePluginInstanceProxy::enumerate):
5027 2011-11-02 Darin Adler <darin@apple.com>
5029 Change remaining callers of releaseRef to call leakRef
5030 https://bugs.webkit.org/show_bug.cgi?id=71422
5032 Reviewed by Darin Fisher.
5034 * History/WebBackForwardList.mm:
5035 (-[WebBackForwardList initWithBackForwardList:]):
5036 * History/WebHistoryItem.mm:
5037 (-[WebHistoryItem copyWithZone:]):
5038 (-[WebHistoryItem initWithWebCoreHistoryItem:]):
5039 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
5040 (-[WebHostedNetscapePluginView createPlugin]):
5041 * Plugins/WebNetscapePluginView.mm:
5042 (-[WebNetscapePluginView createPlugin]):
5043 * WebCoreSupport/WebOpenPanelResultListener.mm:
5044 * WebView/WebDataSource.mm:
5045 (-[WebDataSource _initWithDocumentLoader:]):
5046 * WebView/WebResource.mm:
5047 (-[WebResourcePrivate initWithCoreResource:]):
5050 2011-11-02 Joseph Pecoraro <pecoraro@apple.com>
5052 Move NSRange / DOMRange conversion functions to WebFramePrivate
5053 https://bugs.webkit.org/show_bug.cgi?id=71435
5055 Reviewed by Sam Weinig.
5057 Move conversion functions to WebFramePrivate,
5058 and remove the no longer used versions.
5060 * WebView/WebFrame.mm:
5061 (-[WebFrame _convertNSRangeToDOMRange:]):
5062 (-[WebFrame _convertDOMRangeToNSRange:]):
5063 * WebView/WebFrameInternal.h:
5064 * WebView/WebFramePrivate.h:
5066 2011-11-02 Dean Jackson <dino@apple.com>
5068 Add ENABLE_CSS_SHADERS flag
5069 https://bugs.webkit.org/show_bug.cgi?id=71394
5071 Reviewed by Sam Weinig.
5073 * Configurations/FeatureDefines.xcconfig:
5075 2011-11-02 Jon Lee <jonlee@apple.com>
5077 Expand DragController to provide more information about the dragging session
5078 https://bugs.webkit.org/show_bug.cgi?id=71324
5079 <rdar://problem/10379175>
5081 Reviewed by Darin Adler.
5083 * WebView/WebView.mm:
5084 (-[WebView draggingEntered:]): DragOperation is now inside the DragSession struct.
5085 (-[WebView draggingUpdated:]):
5087 2011-11-02 Tom Sepez <tsepez@chromium.org>
5089 XSSAuditor is silent
5090 https://bugs.webkit.org/show_bug.cgi?id=70973
5092 Reviewed by Adam Barth.
5094 * WebCoreSupport/WebFrameLoaderClient.h:
5095 * WebCoreSupport/WebFrameLoaderClient.mm:
5096 (WebFrameLoaderClient::didRunInsecureContent):
5097 (WebFrameLoaderClient::didDetectXSS):
5098 * WebView/WebDelegateImplementationCaching.h:
5099 * WebView/WebFrameLoadDelegatePrivate.h:
5100 * WebView/WebView.mm:
5101 (-[WebView _cacheFrameLoadDelegateImplementations]):
5103 2011-11-01 Darin Adler <darin@apple.com>
5105 Crash in PDF code when script has illegal UTF-8 or UTF-16 sequences
5106 https://bugs.webkit.org/show_bug.cgi?id=71289
5108 Reviewed by Dan Bernstein.
5110 Just adding a null check. I don't have access to an actual PDF with
5111 this problem but crashes from the field indicate they exist.
5113 * WebView/WebPDFDocumentExtras.mm:
5114 (allScriptsInPDFDocument): Skip the code to add the script text
5115 to an array when the script is null.
5117 2011-10-28 John Sullivan <sullivan@apple.com>
5120 https://bugs.webkit.org/show_bug.cgi?id=71142
5121 Whether backspace goes Back should be configurable
5123 Reviewed by Sam Weinig.
5125 * WebView/WebFrameView.mm:
5126 (-[WebFrameView keyDown:]):
5127 Honor the new preference.
5129 * WebView/WebPreferenceKeysPrivate.h:
5130 Added #define for WebKitBackspaceKeyNavigationEnabledKey
5132 * WebView/WebPreferences.mm:
5133 (+[WebPreferences initialize]):
5134 Initialize new pref to YES, to match current behavior.
5135 (-[WebPreferences setBackspaceKeyNavigationEnabled:]):
5136 New method, standard prefs setter.
5137 (-[WebPreferences backspaceKeyNavigationEnabled]):
5138 New method, standard prefs getter.
5140 * WebView/WebPreferencesPrivate.h:
5141 Declared new methods.
5143 * WebView/WebView.mm:
5144 (-[WebView _preferencesChanged:]):
5145 Updates WebCore settings from WebKit prefs.
5147 2011-10-28 Jochen Eisinger <jochen@chromium.org>
5149 Rename a number of methods mentioning JavaScript to just Script instead
5150 https://bugs.webkit.org/show_bug.cgi?id=71105
5152 Reviewed by Adam Barth.
5154 * WebView/WebView.mm:
5155 (-[WebView _preferencesChanged:]):
5157 2011-10-27 Joseph Pecoraro <pecoraro@apple.com>
5159 Reviewed by David Kilzer.
5161 Make FeatureDefines Identical Across OS X Projects
5162 https://bugs.webkit.org/show_bug.cgi?id=71051
5164 * Configurations/FeatureDefines.xcconfig:
5166 2011-10-27 Mark Hahnenberg <mhahnenberg@apple.com>
5168 De-virtualize JSCell::toThisObject
5169 https://bugs.webkit.org/show_bug.cgi?id=70958
5171 Reviewed by Geoffrey Garen.
5173 Converted all instances of toThisObject to static functions,
5174 added toThisObject to the MethodTable, and replaced all call sites
5175 with a corresponding lookup in the MethodTable.
5177 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5178 (WebKit::NetscapePluginInstanceProxy::invoke):
5179 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
5181 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
5183 Remove deletePropertyVirtual
5184 https://bugs.webkit.org/show_bug.cgi?id=70738
5186 Reviewed by Geoffrey Garen.
5188 Removed all declarations and definitions of deletePropertyVirtual.
5189 Also replaced all call sites to deletePropertyVirtual with a
5190 corresponding lookup in the MethodTable.
5192 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5193 (WebKit::NetscapePluginInstanceProxy::removeProperty):
5195 2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
5198 https://bugs.webkit.org/show_bug.cgi?id=70740
5200 Reviewed by Geoffrey Garen.
5202 Removed all declarations and definitions of putVirtual.
5203 Also replaced all call sites to putVirtual with a
5204 corresponding lookup in the MethodTable.
5206 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5207 (WebKit::NetscapePluginInstanceProxy::setProperty):
5209 2011-10-24 Geoffrey Garen <ggaren@apple.com>
5211 Removed SharedUChar and tightened language around its previous uses
5212 https://bugs.webkit.org/show_bug.cgi?id=70698
5214 Reviewed by David Levin.
5216 - Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
5217 the former names gave the dangerous misimpression that the resulting object
5218 was thread-safe, which is not true.
5220 * Storage/WebDatabaseTrackerClient.mm:
5221 (DidModifyOriginData::dispatchToMainThread):
5223 2011-10-24 Michael Saboff <msaboff@apple.com>
5225 WebKit doesn't build with recent changes to libdispatch
5226 https://bugs.webkit.org/show_bug.cgi?id=70737
5228 Added initialization for new WebKitSystemInterface function
5229 CreateVMPressureDispatchOnMainQueue.
5231 Reviewed by Geoffrey Garen.
5233 * WebCoreSupport/WebSystemInterface.mm:
5234 (InitWebCoreSystemInterface):
5236 2011-10-23 Mark Hahnenberg <mhahnenberg@apple.com>
5238 Remove getConstructDataVirtual
5239 https://bugs.webkit.org/show_bug.cgi?id=70638
5241 Reviewed by Darin Adler.
5243 Removed all declarations and definitions of getConstructDataVirtual.
5244 Also replaced all call sites to getConstructDataVirtual with a
5245 corresponding lookup in the MethodTable.
5247 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5248 (WebKit::NetscapePluginInstanceProxy::construct):
5250 2011-10-20 Ian Henderson <ianh@apple.com>
5252 https://bugs.webkit.org/show_bug.cgi?id=70541
5253 There are two WebFrameLoadDelegatePrivate categories on NSObject
5255 Reviewed by David Kilzer.
5257 * WebView/WebViewPrivate.h: Rename the private delegate categories in
5258 WebViewPrivate.h with a "WebView" prefix to avoid collision.
5260 2011-10-20 Alexey Proskuryakov <ap@apple.com>
5262 REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in
5263 https://bugs.webkit.org/show_bug.cgi?id=70534
5264 <rdar://problem/10308827>
5266 Reviewed by Darin Adler.
5268 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Return true
5269 for contextmenu event, so that plug-ins won't get a default WebKit context menu. We can't
5270 know if the plug-in is handling mousedown (or even mouseup) by displaying a menu.
5272 2011-10-19 Beth Dakin <bdakin@apple.com>
5274 https://bugs.webkit.org/show_bug.cgi?id=70396
5275 Focus rings are too thin in HiDPI in WebKit2
5277 <rdar://problem/10086876>
5279 Reviewed by Dan Bernstein.
5281 Rename wkSetPatternBaseCTM to wkSetBaseCTM
5282 * WebCoreSupport/WebSystemInterface.mm:
5283 (InitWebCoreSystemInterface):
5285 To create a HiDPI context in DRT, we have to set the base CTM, which currently
5286 requires CG SPI, so we have to do it through WebKitSystemInterface.
5287 * WebView/WebView.mm:
5288 (-[WebView _setBaseCTM:forContext:]):
5289 * WebView/WebViewPrivate.h:
5291 2011-10-18 Adam Barth <abarth@webkit.org>
5293 Always enable ENABLE(XPATH)
5294 https://bugs.webkit.org/show_bug.cgi?id=70217
5296 Reviewed by Eric Seidel.
5298 * Configurations/FeatureDefines.xcconfig:
5300 2011-10-14 Chris Marrin <cmarrin@apple.com>
5302 Throttle rate of requestAnimationFrame when page is not visible
5303 https://bugs.webkit.org/show_bug.cgi?id=67873
5305 Reviewed by Anders Carlsson.
5307 Plumb through notification when the window is hidden/shown or
5308 minimized/unminimized
5310 * WebView/WebView.mm:
5311 (-[WebView _windowWillOrderOnScreen:]):
5312 (-[WebView _windowWillOrderOffScreen:]):
5314 2011-10-16 Adam Barth <abarth@webkit.org>
5316 Always enable ENABLE(DOM_STORAGE)
5317 https://bugs.webkit.org/show_bug.cgi?id=70189
5319 Reviewed by Eric Seidel.
5321 * Configurations/FeatureDefines.xcconfig:
5322 * Storage/WebStorageManager.mm:
5323 * Storage/WebStorageManagerInternal.h:
5324 * Storage/WebStorageTrackerClient.h:
5325 * Storage/WebStorageTrackerClient.mm:
5326 (WebStorageTrackerClient::dispatchDidModifyOrigin):
5327 * WebView/WebView.mm:
5328 (-[WebView _commonInitializationWithFrameName:groupName:]):
5330 2011-10-14 David Kilzer <ddkilzer@apple.com>
5332 <http://webkit.org/b/70158> Fix clang compiler warnings
5334 Reviewed by Darin Adler.
5336 The following two methods in WebDelegateImplementationCaching.h
5337 are ambiguous in WebChromeClient::runJavaScriptPrompt() because
5338 the compiler can't decide how to convert the WTF::String
5339 defaultText argument:
5341 id CallUIDelegate(WebView *, SEL, id, id);
5342 id CallUIDelegate(WebView *, SEL, id, BOOL);
5344 The fix is to perform the conversion explicitly.
5346 * WebCoreSupport/WebChromeClient.mm:
5347 (WebChromeClient::runJavaScriptPrompt): Extract a defaultString
5348 variable to convert the WTF::String to an NSString*, then
5349 use defaultString in place of defaultText.
5351 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
5353 Rename virtual put to putVirtual
5354 https://bugs.webkit.org/show_bug.cgi?id=69851
5356 Reviewed by Darin Adler.
5358 Renamed virtual versions of put to putVirtual in prepration for
5359 adding the static put to the MethodTable in ClassInfo since the
5360 compiler gets mad if the virtual and static versions have the same
5363 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5364 (WebKit::NetscapePluginInstanceProxy::setProperty):
5366 2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
5368 Rename virtual deleteProperty to deletePropertyVirtual
5369 https://bugs.webkit.org/show_bug.cgi?id=69884
5371 Reviewed by Darin Adler.
5373 Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
5374 adding the static deleteProperty to the MethodTable in ClassInfo since the
5375 compiler gets mad if the virtual and static versions have the same name.
5377 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5378 (WebKit::NetscapePluginInstanceProxy::removeProperty):
5380 2011-10-12 Ryosuke Niwa <rniwa@webkit.org>
5382 Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent
5383 https://bugs.webkit.org/show_bug.cgi?id=69964
5385 Reviewed by Enrica Casucci.
5387 * WebView/WebFrame.mm:
5388 (-[WebFrame _convertToNSRange:]):
5389 (-[WebFrame _convertToDOMRange:]):
5391 2011-10-13 Mark Hahnenberg <mhahnenberg@apple.com>
5393 Rename virtual getConstructData to getConstructDataVirtual
5394 https://bugs.webkit.org/show_bug.cgi?id=69872
5396 Reviewed by Geoffrey Garen.
5398 Renamed virtual getConstructData functions to getConstructDataVirtual to
5399 avoid conflicts when we add static getConstructData to the MethodTable.
5401 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5402 (WebKit::NetscapePluginInstanceProxy::construct):
5404 2011-10-13 Beth Dakin <bdakin@apple.com>
5406 https://bugs.webkit.org/show_bug.cgi?id=70050
5407 DRT and WRT should have HiDPI testing capabilities
5409 Reviewed by Darin Adler.
5411 New method _backingScaleFactor matches SPI of a similar name that I added
5412 recently to WKPage in WebKit2. Equivalent functionality is needed for
5413 DumpRenderTree's HiDPI support.
5414 * WebView/WebView.mm:
5415 (-[WebView _backingScaleFactor]):
5416 * WebView/WebViewPrivate.h:
5418 2011-10-12 Chris Marrin <cmarrin@apple.com>
5420 Sync requestAnimationFrame callback to CVDisplayLink on Mac
5421 https://bugs.webkit.org/show_bug.cgi?id=68911
5423 Reviewed by Simon Fraser.
5425 Add windowDidChangeScreen function which listens for the window changing
5426 screens and passes the new displayID along to WebCore::Page. It also sends
5427 one on windowWillOrderOnScreen, so the Page has a fresh displayID after it's
5430 * WebView/WebView.mm:
5431 (-[WebView addWindowObserversForWindow:]):
5432 (-[WebView removeWindowObservers]):
5433 (-[WebView _windowDidChangeScreen:]):
5434 (-[WebView _windowWillOrderOnScreen:]):
5436 2011-10-12 Adam Barth <abarth@webkit.org>
5438 Remove ENABLE(XHTMLMP) and associated code
5439 https://bugs.webkit.org/show_bug.cgi?id=69729
5441 Reviewed by David Levin.
5443 * Configurations/FeatureDefines.xcconfig:
5445 2011-10-10 Nate Chapin <japhet@chromium.org>
5447 Use a CachedImageClient instead of CachedResourceClient
5449 https://bugs.webkit.org/show_bug.cgi?id=69790
5451 Reviewed by Adam Barth.
5453 * WebView/WebHTMLView.mm:
5454 (promisedDataClient):
5456 2011-10-10 Mark Hahnenberg <mhahnenberg@apple.com>
5458 Remove getCallDataVirtual methods
5459 https://bugs.webkit.org/show_bug.cgi?id=69186
5461 Reviewed by Geoffrey Garen.
5463 Removed all getCallDataVirtual methods and replaced their call sites
5464 with an explicit lookup in the MethodTable.
5466 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5467 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
5469 2011-10-10 Joseph Pecoraro <joepeck@webkit.org>
5471 Extract WebOpenPanelResultListener out into its own file
5472 https://bugs.webkit.org/show_bug.cgi?id=69575
5474 Reviewed by David Kilzer.
5476 Extract the WebOpenPanelResultListener class out into
5477 its own file. No functional change.
5479 * WebCoreSupport/WebChromeClient.mm:
5480 * WebCoreSupport/WebOpenPanelResultListener.h: Added.
5481 * WebCoreSupport/WebOpenPanelResultListener.mm: Added.
5482 (-[WebOpenPanelResultListener dealloc]):
5483 (-[WebOpenPanelResultListener finalize]):
5484 (-[WebOpenPanelResultListener cancel]):
5485 (-[WebOpenPanelResultListener chooseFilename:]):
5486 (-[WebOpenPanelResultListener chooseFilenames:]):
5487 * WebView/WebUIDelegate.h:
5489 2011-10-08 Sheriff Bot <webkit.review.bot@gmail.com>
5491 Unreviewed, rolling out r96996.
5492 http://trac.webkit.org/changeset/96996
5493 https://bugs.webkit.org/show_bug.cgi?id=69697
5495 It broke all tests on the Qt bot (Requested by Ossy_night on
5498 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5499 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
5501 2011-10-07 Mark Hahnenberg <mhahnenberg@apple.com>
5503 Remove getCallDataVirtual methods
5504 https://bugs.webkit.org/show_bug.cgi?id=69186
5506 Reviewed by Geoffrey Garen.
5508 Removed all getCallDataVirtual methods and replaced their call sites
5509 with an explicit lookup in the MethodTable.
5511 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5512 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
5514 2011-10-06 Anders Carlsson <andersca@apple.com>
5516 When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
5517 https://bugs.webkit.org/show_bug.cgi?id=69586
5519 Reviewed by Darin Adler.
5521 * Configurations/Base.xcconfig:
5522 Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.
5524 2011-10-06 Anders Carlsson <andersca@apple.com>
5526 Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
5527 https://bugs.webkit.org/show_bug.cgi?id=69584
5529 Reviewed by Darin Adler.
5531 Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.
5533 * Plugins/Hosted/HostedNetscapePluginStream.mm:
5534 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5536 2011-10-03 Andy Estes <aestes@apple.com>
5538 Add an option to suppress rendering until the document's load event fires.
5539 https://bugs.webkit.org/show_bug.cgi?id=69298
5541 Reviewed by Simon Fraser.
5543 Add a new private WebPreference.
5545 * WebView/WebPreferenceKeysPrivate.h:
5546 * WebView/WebPreferences.mm:
5547 (+[WebPreferences initialize]):
5548 (-[WebPreferences setSuppressRenderingWhileInitiallyLoading:]):
5549 (-[WebPreferences suppressRenderingWhileInitiallyLoading]):
5550 * WebView/WebPreferencesPrivate.h:
5551 * WebView/WebView.mm:
5552 (-[WebView _preferencesChanged:]):
5554 2011-10-05 Jer Noble <jer.noble@apple.com>
5556 Enable WEB_AUDIO by default in the WebKit/mac port.
5557 https://bugs.webkit.org/show_bug.cgi?id=68587
5559 Reviewed by Simon Fraser.
5561 * Configurations/FeatureDefines.xcconfig:
5563 2011-10-05 David Kilzer <ddkilzer@apple.com>
5565 <http://webkit.org/b/69386> REGRESSION: Curious Location of StorageTracker.db
5567 Reviewed by Alexey Proskuryakov.
5569 * Storage/WebStorageManager.mm:
5570 (+[WebStorageManager _storageDirectoryPath]): Restore call to
5571 -[NSString stringByStandardizingPath]. Also fix over-release of
5572 sLocalStoragePath if the initial -objectForKey: call returned an
5573 NSString object. Use pthread_once to be thread-safe.
5575 2011-10-04 Kent Tamura <tkent@chromium.org>
5577 Introduce feature flags for incomplete input types
5578 https://bugs.webkit.org/show_bug.cgi?id=68971
5580 Reviewed by Hajime Morita.
5582 * Configurations/FeatureDefines.xcconfig:
5583 Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.
5585 2011-10-03 Geoffrey Garen <ggaren@apple.com>
5587 Some JSValue cleanup
5588 https://bugs.webkit.org/show_bug.cgi?id=69320
5590 Reviewed by Darin Adler.
5592 * WebView/WebView.mm:
5593 (aeDescFromJSValue): Updated for JSC changes.
5595 2011-10-04 Scott Graham <scottmg@chromium.org>
5597 Add GAMEPAD feature flag
5598 https://bugs.webkit.org/show_bug.cgi?id=66859
5600 Reviewed by Darin Fisher.
5602 * Configurations/FeatureDefines.xcconfig:
5604 2011-10-03 Jer Noble <jer.noble@apple.com>
5606 Unreviewed, rolling out r96526.
5607 http://trac.webkit.org/changeset/96526
5608 https://bugs.webkit.org/show_bug.cgi?id=68587
5610 WEB_AUDIO has numerous 64->32 bit casting warnings, causing
5611 build breakages where -Wall is enabled.
5613 * Configurations/FeatureDefines.xcconfig:
5615 2011-10-03 Jer Noble <jer.noble@apple.com>
5617 Enable WEB_AUDIO by default in the WebKit/mac port.
5618 https://bugs.webkit.org/show_bug.cgi?id=68587
5620 Reviewed by Simon Fraser.
5622 * Configurations/FeatureDefines.xcconfig:
5624 2011-10-02 Sam Weinig <sam@webkit.org>
5626 Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
5627 https://bugs.webkit.org/show_bug.cgi?id=69230
5629 Reviewed by Anders Carlsson.
5631 * WebView/WebHTMLRepresentation.mm:
5633 (searchForLabelsBeforeElement):
5634 (matchLabelsAgainstString):
5635 (matchLabelsAgainstElement):
5636 (-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
5637 (-[WebHTMLRepresentation matchLabels:againstElement:]):
5639 2011-10-02 Alexey Proskuryakov <ap@apple.com>
5641 REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
5642 https://bugs.webkit.org/show_bug.cgi?id=68542
5644 Reviewed by Mark Rowe.
5646 * WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.
5648 2011-10-01 Geoffrey Garen <ggaren@apple.com>
5650 Leopard build fix: Updated for Strong<T> changes.
5652 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5653 * WebView/WebScriptDebugger.mm:
5655 2011-09-28 Joseph Pecoraro <joepeck@webkit.org>
5657 ASSERT if WebView's UIDelegate does not implement webView:runOpenPanel
5658 https://bugs.webkit.org/show_bug.cgi?id=69037
5660 Reviewed by Alexey Proskuryakov.
5662 * WebCoreSupport/WebChromeClient.mm:
5663 (WebChromeClient::runOpenPanel):
5664 If no delegate is implemented, dismiss the listener
5665 with a cancel. It expects some action.
5667 2011-09-28 Anton D'Auria <adauria@apple.com>
5669 Expose +[WebStorageManager _storageDirectoryPath] as SPI
5670 https://bugs.webkit.org/show_bug.cgi?id=68951
5672 Reviewed by Brady Eidson.
5674 This patch exposes +[WebStorageManager _storageDirectoryPath], which
5675 pulls the path from NSUserDefaults if the preference is set. Otherwise,
5676 it falls back on the default path.
5678 * Storage/WebStorageManager.mm:
5679 (+[WebStorageManager _storageDirectoryPath]): Adding static variable
5680 so that we don't reread user defaults repeatedly.
5681 (WebKitInitializeStorageIfNecessary):
5682 * Storage/WebStorageManagerPrivate.h:
5684 2011-09-27 Andy Estes <aestes@apple.com>
5686 WebKitLinkedOnOrAfter() check is ineffective for Solar Walk app-specific hack.
5687 https://bugs.webkit.org/show_bug.cgi?id=68863
5689 Reviewed by Darin Adler.
5691 The SolarWalk binary does not link against WebKit.framework directly,
5692 so calling NSVersionOfLinkTimeLibrary() will not return the version of
5693 WebKit against which SolarWalk was linked. Since Solar Walk has
5694 released an update that addresses the issue for which this app-specific
5695 hack was originally added, we should just remove the hack.
5697 * Misc/SolarWalkQuirksUserScript.js: Removed.
5698 * WebView/WebView.mm: Removed needsSolarWalkQuirksScript(),
5699 leakSolarWalkQuirksUserScriptContents(), and
5700 -[WebView _injectSolarWalkQuirksScript].
5701 (-[WebView _commonInitializationWithFrameName:groupName:]): Do not
5702 inject the Solar Walk quirks script.
5704 2011-09-27 Mark Hahnenberg <mhahnenberg@apple.com>
5706 Add static version of JSCell::getCallData
5707 https://bugs.webkit.org/show_bug.cgi?id=68741
5709 Reviewed by Darin Adler.
5711 In this patch we just extract the bodies of the virtual getCallData methods
5712 throughout the JSCell inheritance hierarchy out into static methods, which are
5713 now called from the virtual methods. This is an intermediate step in trying to
5714 move the virtual-ness of getCallData into our own method table stored in
5715 ClassInfo. We need to convert the methods to static methods because static methods
5716 can be represented as function pointers rather than pointers to member functions, and
5717 function pointers are smaller and faster to call than pointers to member functions.
5719 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
5720 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
5722 2011-09-23 Simon Fraser <simon.fraser@apple.com>
5724 Repaint tests don't work in WebKit2
5725 https://bugs.webkit.org/show_bug.cgi?id=68453
5727 Reviewed by Sam Weinig.
5729 Have FrameView keep track of repaint rects when asked to, and
5730 expose this set of repaint rects via private WebKit API for later
5731 use by DumpRenderTree.
5733 * WebView/WebView.mm:
5734 (-[WebView setTracksRepaints:]):
5735 (-[WebView isTrackingRepaints]):
5736 (-[WebView resetTrackedRepaints]):
5737 (-[WebView trackedRepaintRects]):
5738 * WebView/WebViewPrivate.h:
5740 2011-09-25 Mark Hahnenberg <mhahnenberg@apple.com>
5742 Add custom vtable struct to ClassInfo struct
5743 https://bugs.webkit.org/show_bug.cgi?id=68567
5745 Reviewed by Oliver Hunt.
5747 Added CREATE_METHOD_TABLE macro to generate the custom vtable for the
5748 specified class in its ClassInfo. Also added to it the first function to use
5749 this macro, visitChildren. This is part of the process of getting rid of all
5750 C++ virtual methods in JSCell. Eventually all virtual functions in JSCell
5751 that can't easily be converted to non-virtual functions will be put into
5752 this custom vtable structure.
5754 * Plugins/Hosted/ProxyInstance.mm:
5755 * Plugins/Hosted/ProxyRuntimeObject.mm:
5757 2011-09-24 Adam Barth <abarth@webkit.org>
5759 Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
5760 https://bugs.webkit.org/show_bug.cgi?id=68767
5762 Reviewed by Eric Seidel.
5764 * Configurations/FeatureDefines.xcconfig:
5766 (+[WebCache empty]):
5767 * WebCoreSupport/WebApplicationCache.mm:
5768 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
5769 (-[WebApplicationCacheQuotaManager usage]):
5770 (-[WebApplicationCacheQuotaManager quota]):
5771 (-[WebApplicationCacheQuotaManager setQuota:]):
5772 * WebCoreSupport/WebChromeClient.h:
5773 * WebCoreSupport/WebChromeClient.mm:
5774 * WebView/WebDataSource.mm:
5775 (-[WebDataSource _transferApplicationCache:]):
5776 * WebView/WebFrame.mm:
5777 (-[WebFrame _cacheabilityDictionary]):
5778 * WebView/WebView.mm:
5779 (WebKitInitializeApplicationCachePathIfNecessary):
5781 2011-09-23 Adam Klein <adamk@chromium.org>
5783 Add ENABLE_MUTATION_OBSERVERS feature flag
5784 https://bugs.webkit.org/show_bug.cgi?id=68732
5786 Reviewed by Ojan Vafai.
5788 This flag will guard an implementation of the "Mutation Observers" proposed in
5789 http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
5791 * Configurations/FeatureDefines.xcconfig:
5793 2011-09-23 Anders Carlsson <andersca@apple.com>
5795 Axe WebImageRendererFactory
5796 https://bugs.webkit.org/show_bug.cgi?id=68715
5798 Reviewed by Darin Adler.
5800 Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.
5802 * WebCoreSupport/WebImageRendererFactory.m: Removed.
5804 2011-09-23 Anders Carlsson <andersca@apple.com>
5806 Add OVERRIDE to a bunch of virtual member functions on clients
5807 https://bugs.webkit.org/show_bug.cgi?id=68712
5809 Reviewed by Sam Weinig.
5811 * Configurations/Base.xcconfig:
5812 * WebCoreSupport/WebChromeClient.h:
5813 * WebCoreSupport/WebContextMenuClient.h:
5814 * WebCoreSupport/WebDeviceOrientationClient.h:
5815 * WebCoreSupport/WebDragClient.h:
5816 * WebCoreSupport/WebEditorClient.h:
5817 * WebCoreSupport/WebFrameLoaderClient.h:
5818 * WebCoreSupport/WebFrameNetworkingContext.h:
5819 * WebCoreSupport/WebGeolocationClient.h:
5820 * WebCoreSupport/WebIconDatabaseClient.h:
5821 * WebCoreSupport/WebInspectorClient.h:
5822 * WebCoreSupport/WebPlatformStrategies.h:
5824 2011-09-22 Dean Jackson <dino@apple.com>
5826 Add ENABLE_CSS_FILTERS
5827 https://bugs.webkit.org/show_bug.cgi?id=68652
5829 Reviewed by Simon Fraser.
5831 * Configurations/FeatureDefines.xcconfig:
5833 2011-09-22 Anders Carlsson <andersca@apple.com>
5835 Get rid of Widget::setBoundsSize
5836 https://bugs.webkit.org/show_bug.cgi?id=68491
5838 Reviewed by Sam Weinig.
5840 This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
5841 which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
5842 anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
5843 will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.
5845 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
5846 (-[WebHostedNetscapePluginView updateAndSetWindow]):
5847 * WebView/WebFrameView.mm:
5849 2011-09-19 Jer Noble <jer.noble@apple.com>
5851 Add settings to control the availability of the Web Audio API to WebKit and WebKit2.
5852 https://bugs.webkit.org/show_bug.cgi?id=68382
5854 Reviewed by Darin Adler.
5856 Initialize the webAudioEnabled preference to NO by default.
5858 * WebView/WebPreferences.mm:
5859 (+[WebPreferences initialize]):
5861 2011-09-21 Anders Carlsson <andersca@apple.com>
5863 Remove checks for Leopard-only Objective-C APIs
5864 https://bugs.webkit.org/show_bug.cgi?id=68579
5866 Reviewed by Sam Weinig.
5868 We can always assume that OBJC_API_VERSION is at least 2, it's been 2 since Leopard.
5870 * Misc/WebNSObjectExtras.h:
5872 2011-09-21 Andras Becsi <andras.becsi@nokia.com>
5874 [Qt] Remove Qt specific code from css/SelectorChecker.cpp
5875 https://bugs.webkit.org/show_bug.cgi?id=67702
5877 Reviewed by Csaba Osztrogonác.
5879 * WebCoreSupport/WebPlatformStrategies.h:
5880 * WebCoreSupport/WebPlatformStrategies.mm:
5881 (WebPlatformStrategies::isLinkVisited):
5883 2011-09-20 Anders Carlsson <andersca@apple.com>
5885 Remove ScrollView::platformContentsSize
5886 https://bugs.webkit.org/show_bug.cgi?id=68188
5888 Reviewed by Darin Adler.
5890 When creating the document view, make sure it's zero sized which matches the initial size
5891 of the ScrollView. This is fine to do early since DocumentWriter::begin sets the contents
5892 size to a zero size anyway.
5894 * WebView/WebFrameView.mm:
5895 (-[WebFrameView _makeDocumentViewForDataSource:]):
5897 2011-09-19 Pavel Feldman <pfeldman@google.com>
5899 Web Inspector: streamline Console's MessageType and MessageSource semantics.
5900 https://bugs.webkit.org/show_bug.cgi?id=68342
5902 This change fixes semantics of the MessageSource and MessageType:
5903 MessageSource is now the source of the message (be it Network, HTML
5904 parser or Console API). MessageType is only defined for the Console API
5905 messages and contains the name of the API call (log, dir, dirxml, etc.).
5906 Subsequent https://bugs.webkit.org/show_bug.cgi?id=66371 will make MessageType
5907 private to the inspector.
5909 Reviewed by Tony Gentilcore.
5911 * WebCoreSupport/WebChromeClient.mm:
5912 (stringForMessageSource):
5913 (stringForMessageType):
5914 * WebView/WebUIDelegatePrivate.h:
5916 2011-09-19 Timothy Hatcher <timothy@apple.com>
5918 Make WebViews in NSPopovers render as they would in active windows.
5920 The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
5921 are shown or hidden since they share key with the parent window. So WebView
5922 and WebHTMLView need to also observe the will order on/off screen notifications.
5924 https://webkit.org/b/68402
5925 rdar://problem/9754099
5927 Reviewed by John Sullivan.
5929 * WebView/WebHTMLView.mm:
5930 (-[WebHTMLView _removeWindowObservers]): Remove order on/off screen notification obversers.
5931 (-[WebHTMLView addWindowObservers]): Add order on/off screen notification obversers.
5932 (-[WebHTMLView windowWillOrderOnScreen:]): Check if the window is already a key window,
5933 which can be the case for NSPopovers.
5934 (-[WebHTMLView windowWillOrderOffScreen:]): Remove the mouse moved observer.
5935 * WebView/WebView.mm:
5936 (-[WebView addWindowObserversForWindow:]): Add order off screen notification obverser.
5937 (-[WebView removeWindowObservers]): Remove order off screen notification obverser.
5938 (-[WebView _windowWillOrderOnScreen:]): Call _updateActiveState.
5939 (-[WebView _windowWillOrderOffScreen:]): Ditto.
5941 2011-09-19 Mark Rowe <mrowe@apple.com>
5943 <http://webkit.org/b/68421> Stop calling UpdateSystemActivity in places where we hold power assertions that achieve the same effect
5945 On SnowLeopard and newer it's not necessary to call UpdateSystemActivity to prevent the screensaver from kicking
5946 in as the NoDisplaySleep assertion now has that effect. It's also not necessary to hold both a NoDisplaySleep and
5947 a NoIdleSleep assertion as the latter is implied by the former.
5949 Adopt the DisplaySleepDisabler class that was added to WebCore and remove all of duplicated logic from WebFullScreenController.
5951 Reviewed by Dan Bernstein.
5953 * WebView/WebFullScreenController.h:
5954 * WebView/WebFullScreenController.mm:
5955 (-[WebFullScreenController dealloc]):
5956 (-[WebFullScreenController _updatePowerAssertions]): Create a DisplaySleepDisabler instance when transitioning from permitting
5957 display sleep to disabling display sleep. Clear out our reference when sleep should be permitted, destroying any
5958 disabler that we own.
5960 2011-09-19 Adam Barth <abarth@webkit.org>
5962 Always enable ENABLE(EVENTSOURCE)
5963 https://bugs.webkit.org/show_bug.cgi?id=68414
5965 Reviewed by Eric Seidel.
5967 * Configurations/FeatureDefines.xcconfig:
5969 2011-09-19 Anders Carlsson <andersca@apple.com>
5971 Fix crashes when running WebKit1 tests.
5973 -[WebView _mustDrawUnionedRect:singleRects:count:] was removed, so just put back the
5974 equivalent code directly into -[WebHTMLView drawRect:].
5976 * WebView/WebHTMLView.mm:
5977 (-[WebHTMLView drawRect:]):
5978 * WebView/WebViewInternal.h:
5980 2011-09-19 Anders Carlsson <andersca@apple.com>
5982 Remove the last remains of viewless WebKit1
5983 https://bugs.webkit.org/show_bug.cgi?id=68388
5985 Reviewed by Darin Adler.
5987 * WebCoreSupport/WebFrameLoaderClient.mm:
5988 (WebFrameLoaderClient::forceLayoutForNonHTML):
5991 * WebView/WebView.mm:
5992 (-[WebView _commonInitializationWithFrameName:groupName:]):
5993 Remove usesDocumentViews parameter and checks.
5995 (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
5996 Add an assertion that usesDocumentViews is always true.
5998 (-[WebView _isUsingAcceleratedCompositing]):
5999 Remove usesDocumentViews check.
6001 (-[WebView _isSoftwareRenderable]):
6002 Remove usesDocumentViews check.
6004 (-[WebView initWithFrame:frameName:groupName:]):
6005 Remove usesDocumentViews parameter and always pass YES to the _initWithFrame method.
6007 (-[WebView initWithCoder:]):
6008 Remove usesDocumentViews parameter.
6010 (-[WebView _frameViewAtWindowPoint:]):
6011 Remove usesDocumentViews check.
6013 * WebView/WebViewData.h:
6014 Remove usesDocumentViews ivar.
6016 * WebView/WebViewPrivate.h:
6017 Remove usesDocumentViews parameters.
6019 2011-09-19 Anders Carlsson <andersca@apple.com>
6021 Remove WebViewEventHandling.mm
6022 https://bugs.webkit.org/show_bug.cgi?id=68387
6024 Reviewed by Adam Roben.
6026 WebViewEventHandling.mm was all about event handling in viewless WebKit, so rip it out since
6027 we're getting rid of viewless WebKit1.
6029 * WebView/WebView.mm:
6030 (-[WebView _close]):
6031 * WebView/WebViewData.h:
6032 * WebView/WebViewEventHandling.mm: Removed.
6033 * WebView/WebViewInternal.h:
6035 2011-09-19 Anders Carlsson <andersca@apple.com>
6037 Remove -[WebView _selectionChanged] and -[WebView _setTooltip:]
6038 https://bugs.webkit.org/show_bug.cgi?id=68385
6040 Reviewed by Adam Roben.
6042 Move these functions back into the respective clients and remove usesDocumentViews checks.
6044 * WebCoreSupport/WebChromeClient.mm:
6045 (WebChromeClient::setToolTip):
6046 * WebCoreSupport/WebEditorClient.mm:
6047 (WebEditorClient::respondToChangedSelection):
6048 * WebView/WebView.mm:
6049 * WebView/WebViewEventHandling.mm:
6050 * WebView/WebViewInternal.h:
6052 2011-09-19 Anders Carlsson <andersca@apple.com>
6054 Begin removing -[WebView _usesDocumentCalls] from WebView.mm
6055 https://bugs.webkit.org/show_bug.cgi?id=68383
6057 Reviewed by Adam Roben.
6059 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
6060 returns true, since viewless WebKit1 has been abandoned.
6062 * WebView/WebView.mm:
6063 (-[WebView selectedFrame]):
6064 (-[WebView setHostWindow:]):
6065 (-[WebView acceptsFirstResponder]):
6066 (-[WebView becomeFirstResponder]):
6067 (-[WebView _webcore_effectiveFirstResponder]):
6068 (-[WebView setNextKeyView:]):
6069 (-[WebView setHoverFeedbackSuspended:]):
6071 2011-09-19 Anders Carlsson <andersca@apple.com>
6073 Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm
6074 https://bugs.webkit.org/show_bug.cgi?id=68379
6076 Reviewed by Adam Roben.
6078 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
6079 returns true, since viewless WebKit1 has been abandoned.
6081 * WebCoreSupport/WebFrameLoaderClient.mm:
6082 (WebFrameLoaderClient::hasHTMLView):
6083 (WebFrameLoaderClient::dispatchDidCommitLoad):
6084 (WebFrameLoaderClient::transitionToCommittedForNewPage):
6085 (WebFrameLoaderClient::createFrame):
6086 * WebView/WebFrame.mm:
6087 (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
6088 (-[WebFrame _hasSelection]):
6089 (-[WebFrame _clearSelection]):
6090 (-[WebFrame _shouldFlattenCompositingLayers:]):
6091 (-[WebFrame _dragSourceEndedAt:operation:]):
6092 (-[WebFrame frameView]):
6094 2011-09-19 Anders Carlsson <andersca@apple.com>
6096 Remove calls to -[WebView _usesDocumentViews]
6097 https://bugs.webkit.org/show_bug.cgi?id=68377
6099 Reviewed by Adam Roben.
6101 Remove checks and begin assuming that -[WebView _usesDocumentViews] always
6102 returns true, since viewless WebKit1 has been abandoned.
6104 * WebCoreSupport/WebChromeClient.mm:
6105 (WebChromeClient::windowResizerRect):
6106 (WebChromeClient::invalidateContentsAndWindow):
6107 (WebChromeClient::screenToWindow):
6108 (WebChromeClient::windowToScreen):
6109 (WebChromeClient::platformPageClient):
6110 (WebChromeClient::scrollRectIntoView):
6111 (WebChromeClient::print):
6112 * WebView/WebDataSource.mm:
6113 (-[WebDataSource _receivedData:]):
6115 2011-09-19 Dan Bernstein <mitz@apple.com>
6117 WebKit part of [mac] WebKit contains Objective-C classes that are not prefixed with its standard prefixes
6118 https://bugs.webkit.org/show_bug.cgi?id=68323
6120 Reviewed by Sam Weinig.
6122 Renamed NonBlockingPanel to WebNonBlockingPanel.
6123 Renamed ThreadEnabler to WebCocoaThreadingEnabler.
6124 Renamed PDFPrefUpdatingProxy to WebPDFPrefUpdatingProxy.
6126 * Misc/WebIconDatabase.mm:
6127 (+[WebCocoaThreadingEnabler enableThreading]):
6128 (importToWebCoreFormat):
6129 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
6130 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
6131 * Panels/WebAuthenticationPanel.h:
6132 * Panels/WebAuthenticationPanel.m: Renamed NonBlockingPanel to
6133 WebNonBlockingPanel. Because Safari 5.1 uses NonBlockingPanel, this will
6134 cause nightly builds to log an error message when showing the Safari
6135 HTTP authentication sheet and disable the Quit command while the sheet
6137 * WebView/WebPDFView.mm:
6138 (-[WebPDFView initWithFrame:]):
6139 (-[WebPDFView _updatePreferencesSoon]):
6141 2011-09-17 Mihai Parparita <mihaip@chromium.org>
6143 FrameLoaderClient BackForwardList-related methods are unsued
6144 https://bugs.webkit.org/show_bug.cgi?id=68293
6146 Reviewed by Darin Adler.
6148 Remove FrameLoaderClient methods that were added by r51629, since only
6149 the old (since-deleted) Android port needed them.
6151 * WebCoreSupport/WebFrameLoaderClient.h:
6152 * WebCoreSupport/WebFrameLoaderClient.mm:
6155 2011-09-16 Simon Fraser <simon.fraser@apple.com>
6157 Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
6158 https://bugs.webkit.org/show_bug.cgi?id=68134
6160 Reviewed by Sam Weinig.
6162 Hook up a private preference that enables the mock scrollbar theme.
6164 * WebView/WebPreferenceKeysPrivate.h:
6165 * WebView/WebPreferences.mm:
6166 (-[WebPreferences mockScrollbarsEnabled]):
6167 (-[WebPreferences setMockScrollbarsEnabled:]):
6168 * WebView/WebPreferencesPrivate.h:
6170 2011-09-15 Adam Barth <abarth@webkit.org>
6172 Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
6173 https://bugs.webkit.org/show_bug.cgi?id=68205
6175 Reviewed by Eric Seidel.
6177 * Storage/WebDatabaseManager.mm:
6178 * Storage/WebDatabaseManagerInternal.h:
6179 * Storage/WebDatabaseManagerPrivate.h:
6180 * Storage/WebDatabaseQuotaManager.mm:
6181 (-[WebDatabaseQuotaManager usage]):
6182 (-[WebDatabaseQuotaManager quota]):
6183 (-[WebDatabaseQuotaManager setQuota:]):
6184 * Storage/WebDatabaseTrackerClient.h:
6185 * Storage/WebDatabaseTrackerClient.mm:
6186 * WebCoreSupport/WebChromeClient.h:
6187 * WebCoreSupport/WebChromeClient.mm:
6188 * WebCoreSupport/WebSecurityOrigin.mm:
6189 (-[WebSecurityOrigin usage]):
6190 (-[WebSecurityOrigin quota]):
6191 (-[WebSecurityOrigin setQuota:]):
6192 * WebView/WebFrame.mm:
6193 (-[WebFrame _cacheabilityDictionary]):
6194 * WebView/WebView.mm:
6195 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
6196 (-[WebView _preferencesChanged:]):
6198 2011-09-15 Mark Hahnenberg <mhahnenberg@apple.com>
6200 Unzip initialization lists and constructors in JSCell hierarchy (7/7)
6201 https://bugs.webkit.org/show_bug.cgi?id=68122
6203 Reviewed by Geoffrey Garen.
6205 Completed the seventh and final level of the refactoring to add finishCreation()
6206 methods to all classes within the JSCell hierarchy with non-trivial
6209 * Plugins/Hosted/ProxyInstance.mm:
6210 (WebKit::ProxyRuntimeMethod::create):
6211 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
6212 * Plugins/Hosted/ProxyRuntimeObject.h:
6213 (WebKit::ProxyRuntimeObject::create):
6214 * Plugins/Hosted/ProxyRuntimeObject.mm:
6215 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
6217 2011-09-15 Kentaro Hara <haraken@google.com>
6219 A single line must not be split into two pages.
6220 https://bugs.webkit.org/show_bug.cgi?id=65005
6222 Reviewed by David Hyatt.
6224 When the document width of a page is overflowed, the last line of the page can be
6225 split into the next page. This is the regression caused by r88737. r88737 tried to
6226 fix rounding errors in rendering calculations by expanding and shrinking a page
6227 using one common method, resizePageRectsKeepingRatio(), but overlooked the case where
6228 a document width gets overflowed.
6230 Test: printing/single-line-must-not-be-split-into-two-pages.html
6232 * WebView/WebHTMLView.mm:
6233 (-[WebHTMLView _web_setPrintingModeRecursive]): Passes an original page size to setPrinting().
6234 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
6235 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
6236 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Ditto.
6237 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Ditto.
6238 (-[WebHTMLView _endPrintMode]): Ditto.
6239 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]): Ditto.
6240 (-[WebHTMLView _endScreenPaginationMode]): Ditto.
6241 (-[WebHTMLView layoutToMinimumPageWidth:height:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustingViewSize:]): Ditto.
6242 (-[WebHTMLView layout]): Ditto.
6243 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]): Ditto.
6244 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
6245 (-[WebHTMLView setPageWidthForPrinting:]): Ditto.
6247 2011-09-15 Eric Seidel <eric@webkit.org>
6249 Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
6250 https://bugs.webkit.org/show_bug.cgi?id=68182
6252 Reviewed by Adam Barth.
6254 * Configurations/FeatureDefines.xcconfig:
6256 2011-09-15 Eric Seidel <eric@webkit.org>
6258 Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
6259 https://bugs.webkit.org/show_bug.cgi?id=68022
6261 Reviewed by Ryosuke Niwa.
6263 * Configurations/FeatureDefines.xcconfig:
6265 2011-09-14 Anders Carlsson <andersca@apple.com>
6267 Get rid of WebCoreViewFactory and its WebViewFactory subclass
6268 https://bugs.webkit.org/show_bug.cgi?id=68124
6270 Reviewed by Sam Weinig.
6272 * WebCoreSupport/WebContextMenuClient.mm:
6273 * WebCoreSupport/WebViewFactory.h: Removed.
6274 * WebCoreSupport/WebViewFactory.mm: Removed.
6275 * WebView/WebFrameView.mm:
6276 (-[WebFrameView initWithFrame:]):
6278 2011-09-14 Mark Hahnenberg <mhahnenberg@apple.com>
6280 Unzip initialization lists and constructors in JSCell hierarchy (6/7)
6281 https://bugs.webkit.org/show_bug.cgi?id=67692
6283 Reviewed by Geoffrey Garen.
6285 Completed the sixth level of the refactoring to add finishCreation()
6286 methods to all classes within the JSCell hierarchy with non-trivial
6289 This primarily consists of pushing the calls to finishCreation() down
6290 into the constructors of the subclasses of the fifth level of the hierarchy
6291 as well as pulling the finishCreation() calls out into the class's corresponding
6292 create() method if it has one. Doing both simultaneously allows us to
6293 maintain the invariant that the finishCreation() method chain is called exactly
6294 once during the creation of an object, since calling it any other number of
6295 times (0, 2, or more) will cause an assertion failure.
6297 * Plugins/Hosted/ProxyInstance.mm:
6298 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
6299 (WebKit::ProxyRuntimeMethod::finishCreation):
6301 2011-09-13 Eric Seidel <eric@webkit.org>
6303 Remove ENABLE_SVG_USE as <use> is required by HTML5
6304 https://bugs.webkit.org/show_bug.cgi?id=68019
6306 Reviewed by Ryosuke Niwa.
6308 * Configurations/FeatureDefines.xcconfig:
6310 2011-09-13 Anders Carlsson <andersca@apple.com>
6312 Disable C++ exceptions when building with clang
6313 https://bugs.webkit.org/show_bug.cgi?id=68031
6314 <rdar://problem/9556880>
6316 Reviewed by Mark Rowe.
6318 * Configurations/Base.xcconfig:
6320 2011-09-13 Eric Seidel <eric@webkit.org>
6322 Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
6323 https://bugs.webkit.org/show_bug.cgi?id=68018
6325 Reviewed by Ryosuke Niwa.
6327 * Configurations/FeatureDefines.xcconfig:
6329 2011-09-09 Oliver Hunt <oliver@apple.com>
6331 Remove support for anonymous storage from jsobjects
6332 https://bugs.webkit.org/show_bug.cgi?id=67881
6334 Reviewed by Sam Weinig.
6336 Remove the use of AnonymousSlotCount
6338 * Plugins/Hosted/ProxyInstance.mm:
6339 (WebKit::ProxyRuntimeMethod::createStructure):
6340 * Plugins/Hosted/ProxyRuntimeObject.h:
6341 (WebKit::ProxyRuntimeObject::createStructure):
6343 2011-09-09 Chris Marrin <cmarrin@apple.com>
6345 requestAnimationFrame doesn't throttle on Mac
6346 https://bugs.webkit.org/show_bug.cgi?id=67171
6348 Reviewed by Simon Fraser.
6350 Removed runLoopObserver for requestAnimationFrame. It's now
6351 done by a Timer in ScriptedAnimationController in WebCore.
6353 * WebCoreSupport/WebChromeClient.h:
6354 * WebCoreSupport/WebChromeClient.mm:
6355 * WebView/WebView.mm:
6356 (-[WebView _close]):
6357 * WebView/WebViewData.h:
6358 * WebView/WebViewInternal.h:
6360 2011-09-09 Fady Samuel <fsamuel@chromium.org>
6362 Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp}
6363 https://bugs.webkit.org/show_bug.cgi?id=67250
6365 Reviewed by Simon Fraser.
6367 * WebView/WebView.mm:
6368 (-[WebView _scaleWebView:atOrigin:]):
6369 (-[WebView _viewScaleFactor]):
6371 2011-09-09 Mark Hahnenberg <mhahnenberg@apple.com>
6373 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
6374 https://bugs.webkit.org/show_bug.cgi?id=67420
6376 Reviewed by Geoffrey Garen.
6378 Completed the fifth level of the refactoring to add finishCreation()
6379 methods to all classes within the JSCell hierarchy with non-trivial
6382 This primarily consists of pushing the calls to finishCreation() down
6383 into the constructors of the subclasses of the second level of the hierarchy
6384 as well as pulling the finishCreation() calls out into the class's corresponding
6385 create() method if it has one. Doing both simultaneously allows us to
6386 maintain the invariant that the finishCreation() method chain is called exactly
6387 once during the creation of an object, since calling it any other number of
6388 times (0, 2, or more) will cause an assertion failure.
6390 * Plugins/Hosted/ProxyRuntimeObject.h:
6391 * Plugins/Hosted/ProxyRuntimeObject.mm:
6392 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
6393 (WebKit::ProxyRuntimeObject::finishCreation):
6395 2011-09-08 Sam Weinig <sam@webkit.org>
6397 Remove the Completion object from JSC, I have never liked it
6398 https://bugs.webkit.org/show_bug.cgi?id=67755
6400 Reviewed by Gavin Barraclough.
6402 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
6403 (WebKit::NetscapePluginInstanceProxy::evaluate):
6405 2011-09-07 Sheriff Bot <webkit.review.bot@gmail.com>
6407 Unreviewed, rolling out r94627 and r94632.
6408 http://trac.webkit.org/changeset/94627
6409 http://trac.webkit.org/changeset/94632
6410 https://bugs.webkit.org/show_bug.cgi?id=67698
6412 It broke tests on GTK and Qt (Requested by Ossy on #webkit).
6414 * Plugins/Hosted/ProxyRuntimeObject.h:
6415 * Plugins/Hosted/ProxyRuntimeObject.mm:
6416 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
6418 2011-09-06 Mark Hahnenberg <mhahnenberg@apple.com>
6420 Unzip initialization lists and constructors in JSCell hierarchy (5/7)
6421 https://bugs.webkit.org/show_bug.cgi?id=67420
6423 Reviewed by Geoffrey Garen.
6425 Completed the fifth level of the refactoring to add finishCreation()
6426 methods to all classes within the JSCell hierarchy with non-trivial
6429 This primarily consists of pushing the calls to finishCreation() down
6430 into the constructors of the subclasses of the second level of the hierarchy
6431 as well as pulling the finishCreation() calls out into the class's corresponding
6432 create() method if it has one. Doing both simultaneously allows us to
6433 maintain the invariant that the finishCreation() method chain is called exactly
6434 once during the creation of an object, since calling it any other number of
6435 times (0, 2, or more) will cause an assertion failure.
6437 * Plugins/Hosted/ProxyRuntimeObject.h:
6438 * Plugins/Hosted/ProxyRuntimeObject.mm:
6439 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
6440 (WebKit::ProxyRuntimeObject::finishCreation):
6442 2011-09-06 Ryosuke Niwa <rniwa@webkit.org>
6444 Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
6445 https://bugs.webkit.org/show_bug.cgi?id=67569
6447 Reviewed by Antonio Gomes.
6449 * WebView/WebHTMLView.mm:
6450 (-[WebHTMLView _updateSelectionForInputManager]):
6452 2011-09-05 Oliver Hunt <oliver@apple.com>
6454 An object's structure should reference the global object responsible for its creation
6455 https://bugs.webkit.org/show_bug.cgi?id=67624
6457 Reviewed by Gavin Barraclough.
6459 Update for new Structure::create() globalObject parameter.
6461 * Plugins/Hosted/ProxyInstance.mm:
6462 (WebKit::ProxyRuntimeMethod::createStructure):
6463 * Plugins/Hosted/ProxyRuntimeObject.h:
6464 (WebKit::ProxyRuntimeObject::createStructure):
6466 2011-09-01 Mark Rowe <mrowe@apple.com>
6468 Fix the build by adding some more missing return types.
6470 * WebView/WebDashboardRegion.h:
6471 * WebView/WebDashboardRegion.mm:
6472 (-[WebDashboardRegion initWithRect:clip:type:]):
6474 2011-09-01 Tim Horton <timothy_horton@apple.com>
6476 REGRESSION: Rendering artifacts on a rotated, pattern filled shape
6477 https://bugs.webkit.org/show_bug.cgi?id=53055
6478 <rdar://problem/8910917>
6480 Reviewed by Simon Fraser.
6482 Introduce wkCGPatternCreateWithImageAndTransform.
6484 * WebCoreSupport/WebSystemInterface.mm:
6485 (InitWebCoreSystemInterface):
6487 2011-08-31 Beth Dakin <bdakin@apple.com>
6489 https://bugs.webkit.org/show_bug.cgi?id=67322
6490 Re-name overrideBackingScaleFactor
6492 Reviewed by John Sullivan.
6494 _setOverrideBackingScaleFactor is now _setCustomBackingScaleFactor
6495 * WebView/WebView.mm:
6496 (-[WebView _setCustomBackingScaleFactor:]):
6497 (-[WebView _deviceScaleFactor]):
6498 * WebView/WebViewData.h:
6499 * WebView/WebViewPrivate.h:
6501 2011-08-30 Dan Bernstein <mitz@apple.com>
6503 <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
6504 https://bugs.webkit.org/show_bug.cgi?id=67230
6506 Reviewed by Darin Adler.
6508 * WebView/WebHTMLView.mm:
6509 * WebView/WebView.mm:
6510 (coreOptions): Moved this function from WebHTMLView.mm to here and made
6511 it accessible from both this file and WebHTMLView.mm.
6512 (-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API.
6513 * WebView/WebViewInternal.h:
6514 * WebView/WebViewPrivate.h:
6516 2011-08-30 Beth Dakin <bdakin@apple.com>
6518 https://bugs.webkit.org/show_bug.cgi?id=67150
6519 Would like API to use a custom device scale factor for a particular WebView/WKView
6521 <rdar://problem/10041016>
6523 Reviewed by Darin Adler.
6525 New API is _setOverrideBackingScaleFactor:(CGFloat)
6526 * WebView/WebView.mm:
6527 (-[WebView _setOverrideBackingScaleFactor:]):
6528 (-[WebView _deviceScaleFactor]):
6529 * WebView/WebViewData.h:
6530 * WebView/WebViewPrivate.h:
6532 2011-08-30 Aaron Colwell <acolwell@chromium.org>
6534 Add MediaSource API to HTMLMediaElement
6535 https://bugs.webkit.org/show_bug.cgi?id=64731
6537 Reviewed by Eric Carlson.
6539 * Configurations/FeatureDefines.xcconfig:
6541 2011-08-29 Alexey Proskuryakov <ap@apple.com>
6543 DumpRenderTree should begin each test with an empty cookie store
6544 https://bugs.webkit.org/show_bug.cgi?id=63545
6545 <rdar://problem/5666907>
6547 Reviewed by Darin Adler.
6549 * WebView/WebPreferences.mm:
6550 (+[WebPreferences initialize]):
6551 (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
6552 (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
6553 * WebView/WebPreferencesPrivate.h:
6554 Exposed an SPI to use a private default session. It's separate from private browsing,
6555 because some tests enable the latter, and we don't want to mix them up.
6556 Also exposed an SPI to set cookie accept policy regardless of what session we are currently
6559 * WebView/WebView.mm: (-[WebView _cachedResponseForURL:]): Updated to use currentStorageSession()
6560 instead of privateBrowsingStorageSession().
6562 2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
6564 The unused ScrollView* argument can and should be removed from
6566 https://bugs.webkit.org/show_bug.cgi?id=67117
6568 Reviewed by Darin Adler.
6570 * WebCoreSupport/WebChromeClient.h:
6571 * WebCoreSupport/WebChromeClient.mm:
6572 (WebChromeClient::scrollRectIntoView):
6574 2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
6576 Unreviewed, rolling out r93987, r93992, r93995, r93998, and
6578 http://trac.webkit.org/changeset/93987
6579 http://trac.webkit.org/changeset/93992
6580 http://trac.webkit.org/changeset/93995
6581 http://trac.webkit.org/changeset/93998
6582 http://trac.webkit.org/changeset/93999
6583 https://bugs.webkit.org/show_bug.cgi?id=67147
6585 Many failing tests (Requested by ap on #webkit).
6587 * WebView/WebPreferences.mm:
6588 (+[WebPreferences initialize]):
6589 * WebView/WebPreferencesPrivate.h:
6591 2011-08-26 Alexey Proskuryakov <ap@apple.com>
6593 DumpRenderTree should begin each test with an empty cookie store
6594 https://bugs.webkit.org/show_bug.cgi?id=63545
6595 <rdar://problem/5666907>
6597 Reviewed by Darin Adler.
6599 * WebView/WebPreferences.mm:
6600 (+[WebPreferences initialize]):
6601 (+[WebPreferences _usePrivateSessionForNetworkLoading]):
6602 * WebView/WebPreferencesPrivate.h:
6603 Exposed an SPI to use a private default session. It's separate from private browsing,
6604 because some tests enable the latter, and we don't want to mix them up.
6606 2011-08-23 Chris Marrin <cmarrin@apple.com>
6608 [mac] requestAnimationFrame support for mac port
6609 https://bugs.webkit.org/show_bug.cgi?id=59146
6611 Reviewed by Simon Fraser.
6613 Implement requestAnimationFrame for WebKit. Add a
6614 CFRunLoopObserver to WebView, which runs just before
6615 the syncCompositingState RLO and calls into the
6616 ScriptedAnimationController if scheduleAnimation() has
6619 * Configurations/FeatureDefines.xcconfig:
6620 * WebCoreSupport/WebChromeClient.h:
6621 * WebCoreSupport/WebChromeClient.mm:
6622 (WebChromeClient::scheduleAnimation):
6623 * WebView/WebView.mm:
6624 (-[WebView _close]):
6625 (-[WebView _unscheduleAnimation]):
6626 (-[WebView _scheduleCompositingLayerSync]):
6627 (requestAnimationFrameRunLoopObserverCallback):
6628 (-[WebView _scheduleAnimation]):
6629 * WebView/WebViewData.h:
6630 * WebView/WebViewInternal.h:
6632 2011-08-24 Alexey Proskuryakov <ap@apple.com>
6634 Plug-in tests are flaky on Mac
6635 https://bugs.webkit.org/show_bug.cgi?id=66822
6637 Reviewed by Anders Carlsson.
6639 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
6640 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
6641 Protect objects that can be removed by a script.
6643 * WebView/WebFrame.mm:
6644 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
6645 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]): Ditto.
6646 Also fixed some nonsense code.
6648 2011-08-23 Mark Hahnenberg <mhahnenberg@apple.com>
6650 Add checks to ensure allocation does not take place during initialization of GC-managed objects
6651 https://bugs.webkit.org/show_bug.cgi?id=65288
6653 Reviewed by Darin Adler.
6655 Adding the new validation functionality. In its current state, it will performs checks,
6656 but they don't fail unless you do allocation in the arguments to the parent constructor in the
6657 initialization list of a class. The allocateCell() method turns on the global flag disallowing any new
6658 allocations, and the constructorBody() method in JSCell turns it off. This way, allocation is still
6659 allowed in constructor bodies while other refactoring efforts continue.
6661 * Plugins/Hosted/ProxyRuntimeObject.h:
6662 (WebKit::ProxyRuntimeObject::create):
6663 * Plugins/Hosted/ProxyRuntimeObject.mm:
6664 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
6666 2011-08-18 Beth Dakin <bdakin@apple.com>
6668 Reviewed by Sam Weinig.
6670 https://bugs.webkit.org/show_bug.cgi?id=66495
6671 Lion-specific scroller SPIs can use forward declaration instead of
6672 WebKitSystemInterface
6674 * WebCoreSupport/WebSystemInterface.mm:
6675 (InitWebCoreSystemInterface):
6677 2011-08-18 Anders Carlsson <andersca@apple.com>
6679 More C++0x libc++ build fixes
6680 https://bugs.webkit.org/show_bug.cgi?id=66476
6682 Reviewed by Adam Roben.
6684 * Plugins/Hosted/NetscapePluginHostProxy.mm:
6686 Use a WTF String here instead of an STL string.
6688 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
6689 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
6690 std::make_pair now takes rvalue references, so get rid of the template arguments and let
6691 the compiler deduce them instead.
6693 2011-08-18 Adam Roben <aroben@apple.com>
6695 Update the device scale factor when the WebView's window changes
6697 Fixes <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
6698 WebView is moved between windows with different backing scale factors
6700 Reviewed by Anders Carlsson.
6702 * WebView/WebView.mm:
6703 (-[WebView viewDidMoveToWindow]): Call setDeviceScaleFactor because our new window (or no
6704 window at all) might have a different backing scale factor than the previous one.
6705 (-[WebView _deviceScaleFactor]): Moved to the WebFileInternal category.
6707 2011-08-17 Adam Roben <aroben@apple.com>
6709 Make WebCore keep track of the current device scale factor
6711 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
6714 Reviewed by Darin Adler.
6716 * WebCoreSupport/WebChromeClient.h:
6717 * WebCoreSupport/WebChromeClient.mm:
6718 Moved code to calculate the device scale factor from here...
6720 * WebView/WebView.mm:
6721 (-[WebView _deviceScaleFactor]):
6724 (-[WebView _windowDidChangeResolution:]): Now calls Page::setDeviceScaleFactor.
6726 2011-08-17 Dan Bernstein <mitz@apple.com>
6728 Removed some code that is not needed when building for Leopard or later.
6730 Reviewed by Anders Carlsson.
6732 * WebCoreSupport/WebContextMenuClient.mm:
6733 (fixMenusToSendToOldClients): Removed check for Tiger Mail.
6734 * WebCoreSupport/WebFrameLoaderClient.mm:
6735 (WebFrameLoaderClient::objectContentType):
6736 * WebView/WebView.mm:
6737 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
6738 (-[WebView _preferencesChanged:]):
6740 2011-08-17 Dan Bernstein <mitz@apple.com>
6742 Eliminate the WebCGFloat compatibility definition that was needed for Tiger.
6744 Rubber-stamped by Anders Carlsson.
6746 * WebView/WebHTMLViewPrivate.h:
6748 2011-08-17 Dan Bernstein <mitz@apple.com>
6750 Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
6753 Reviewed by Darin Adler.
6755 * History/WebBackForwardList.h:
6756 * WebView/WebDocumentInternal.h:
6757 * WebView/WebHTMLRepresentation.h:
6758 * WebView/WebPreferences.h:
6759 * WebView/WebResourceLoadDelegate.h:
6760 * WebView/WebResourceLoadDelegatePrivate.h:
6761 * WebView/WebScriptDebugDelegate.h:
6762 * WebView/WebTextIterator.h:
6763 * WebView/WebUIDelegate.h:
6764 * WebView/WebView.h:
6765 * WebView/WebViewPrivate.h:
6767 2011-08-15 Dmitry Titov <dimich@chromium.org>
6769 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
6770 https://bugs.webkit.org/show_bug.cgi?id=66165
6772 Reviewed by Darin Fisher.
6774 * WebCoreSupport/WebFrameLoaderClient.h:
6775 * WebCoreSupport/WebFrameLoaderClient.mm:
6776 (WebFrameLoaderClient::transferLoadingResourceFromPage):
6778 2011-08-15 Mark Hahnenberg <mhahnenberg@apple.com>
6780 Refactor JS objects to allocate in static create methods rather than constructors
6781 https://bugs.webkit.org/show_bug.cgi?id=65347
6783 Reviewed by Geoffrey Garen.
6785 Removed all calls to deprecatedGetDOMObject from initialization lists as part of a
6786 larger refactoring to get rid of all allocation during initialization.
6788 * Plugins/Hosted/ProxyInstance.mm:
6789 (WebKit::ProxyRuntimeMethod::create):
6790 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
6792 2011-08-15 Adam Roben <aroben@apple.com>
6794 Update pages' style and content scale when the window's backing scale factor changes
6796 Unfortunately, I couldn't think of a way to test this in an automated fashion.
6798 Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device
6799 scale factor changes
6801 Reviewed by Simon Fraser.
6803 * WebView/WebView.mm:
6804 (-[WebView addWindowObserversForWindow:]):
6805 (-[WebView removeWindowObservers]):
6806 Listen for the notification that tells us the window's backing scale has changed.
6808 (-[WebView _windowDidChangeResolution:]): Tell the page about the change to the device scale
6809 factor so that, e.g., scale-factor-dependent media queries will be reevaluated.
6811 2011-08-10 Adam Roben <aroben@apple.com>
6813 Clear up scale factor terminology
6815 WebKit by and large deals with two scale factors: one intrinsic to the device on which the
6816 software is running, and one that is per-Page and can be controlled via API calls. This
6817 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
6818 code use those names. It should introduce no behavior changes.
6820 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
6823 Reviewed by Simon Fraser.
6825 * Misc/WebNSControlExtras.m:
6826 (-[NSControl sizeToFitAndAdjustWindowHeight]): Updated this function to use more modern
6827 AppKit scale factor terminology. (This is unrelated to the rest of the patch.)
6829 * WebCoreSupport/WebChromeClient.h:
6830 * WebCoreSupport/WebChromeClient.mm:
6832 2011-08-13 Dan Bernstein <mitz@apple.com>
6834 Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
6836 Reviewed by Joseph Pecoraro.
6838 * WebView/WebPreferenceKeysPrivate.h:
6840 2011-08-13 Sam Weinig <sam@webkit.org>
6842 Remove unused variables from WebView/WebFullScreenController.h
6843 https://bugs.webkit.org/show_bug.cgi?id=66194
6845 Reviewed by Dan Bernstein.
6847 * WebView/WebFullScreenController.h:
6848 Remove a few variables which were not used.
6850 2011-08-12 Dan Bernstein <mitz@apple.com>
6852 Add an option to automatically show tooltips (with the full text) over truncated text
6853 https://bugs.webkit.org/show_bug.cgi?id=66178
6855 Reviewed by Simon Fraser.
6857 * WebView/WebPreferenceKeysPrivate.h: Defined a preference key.
6858 * WebView/WebPreferences.mm:
6859 (+[WebPreferences initialize]): Added a default value of NO for the
6860 ShowsToolTipOverTruncatedText preference.
6861 (-[WebPreferences showsToolTipOverTruncatedText]): Added this getter.
6862 (-[WebPreferences setShowsToolTipOverTruncatedText:]): Added this setter.
6863 * WebView/WebPreferencesPrivate.h:
6864 * WebView/WebView.mm:
6865 (-[WebView _preferencesChanged:]): Added call to Settings::setShowsToolTipOverTruncatedText().
6867 2011-08-12 Sam Weinig <sam@webkit.org>
6869 Use __builtin_trap() for CRASH when building with clang
6870 https://bugs.webkit.org/show_bug.cgi?id=66152
6872 Reviewed by Anders Carlsson.
6874 * Plugins/WebBaseNetscapePluginView.mm:
6875 (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]):
6876 (-[WebBaseNetscapePluginView handleMouseMoved:]):
6877 (-[WebBaseNetscapePluginView handleMouseEntered:]):
6878 (-[WebBaseNetscapePluginView handleMouseExited:]):
6879 (-[WebBaseNetscapePluginView focusChanged]):
6880 (-[WebBaseNetscapePluginView windowFocusChanged:]):
6881 (-[WebBaseNetscapePluginView createPlugin]):
6882 (-[WebBaseNetscapePluginView loadStream]):
6883 (-[WebBaseNetscapePluginView shouldStop]):
6884 (-[WebBaseNetscapePluginView destroyPlugin]):
6885 (-[WebBaseNetscapePluginView updateAndSetWindow]):
6886 (-[WebBaseNetscapePluginView sendModifierEventWithKeyCode:character:]):
6887 (-[WebBaseNetscapePluginView pluginLayer]):
6888 (-[WebBaseNetscapePluginView getFormValue:]):
6889 Remove the ASSERT_NOT_REACHED from the base class methods. They were not
6890 adding much value and were getting in the way of making the static analyzer
6891 work. A better way to do this would be to use a formal protocol.
6893 2011-08-12 Mark Rowe <mrowe@apple.com>
6895 Be more forward-looking in the choice of compiler.
6897 Rubber-stamped by Jon Honeycutt.
6899 * Configurations/CompilerVersion.xcconfig:
6901 2011-08-10 David Hyatt <hyatt@apple.com>
6903 https://bugs.webkit.org/show_bug.cgi?id=66004
6905 Removing the CSS Regions and Exclusions ifdefs.
6907 Reviewed by Adam Roben.
6909 * Configurations/FeatureDefines.xcconfig:
6911 2011-08-09 Mark Hahnenberg <mhahnenberg@apple.com>
6913 Add ParentClass typedef in all JSC classes
6914 https://bugs.webkit.org/show_bug.cgi?id=65731
6916 Reviewed by Oliver Hunt.
6918 Just added the Base typedefs in all the classes that are a subclass of JSCell
6919 to point at their parent classes. This is a change to support future changes to the way
6920 constructors and destructors are implemented in JS objects, among other things.
6922 * Plugins/Hosted/ProxyInstance.mm:
6923 * Plugins/Hosted/ProxyRuntimeObject.h:
6925 2011-08-08 Chris Marrin <cmarrin@apple.com>
6927 Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState
6928 https://bugs.webkit.org/show_bug.cgi?id=65708
6930 Supply initial display rects for the full-screen case
6932 Reviewed by Simon Fraser.
6934 * WebView/WebFullScreenController.mm:
6935 (-[WebFullScreenController enterFullscreen:]):
6936 (-[WebFullScreenController exitFullscreen]):
6938 2011-08-06 Joseph Pecoraro <joepeck@webkit.org>
6940 Potential Leaks - RetainPtr<> over retaining Create'd objects
6941 https://bugs.webkit.org/show_bug.cgi?id=65806
6943 Reviewed by Darin Adler.
6945 Fix a possible leak by adopting an allocation instead of retaining it.
6947 * WebView/WebView.mm:
6948 (-[WebView previousValidKeyView]):
6950 2011-08-05 Anders Carlsson <andersca@apple.com>
6953 https://bugs.webkit.org/show_bug.cgi?id=65729
6955 Reviewed by Darin Adler.
6957 Remove plug-in halter and associated classes.
6959 * Plugins/WebBaseNetscapePluginView.h:
6960 * Plugins/WebBaseNetscapePluginView.mm:
6961 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
6962 (-[WebBaseNetscapePluginView start]):
6963 (-[WebBaseNetscapePluginView stop]):
6964 * WebCoreSupport/WebPluginHalterClient.h: Removed.
6965 * WebCoreSupport/WebPluginHalterClient.mm: Removed.
6966 * WebView/WebPreferenceKeysPrivate.h:
6967 * WebView/WebPreferences.mm:
6968 (+[WebPreferences initialize]):
6969 * WebView/WebPreferencesPrivate.h:
6970 * WebView/WebView.mm:
6971 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
6972 (-[WebView _preferencesChanged:]):
6973 * WebView/WebViewPrivate.h:
6975 2011-08-04 Mark Rowe <mrowe@apple.com>
6977 Future-proof Xcode configuration settings.
6979 * Configurations/Base.xcconfig:
6980 * Configurations/DebugRelease.xcconfig:
6981 * Configurations/Version.xcconfig:
6982 * Configurations/WebKit.xcconfig:
6984 2011-08-03 Kent Tamura <tkent@chromium.org>
6986 Fix incorrect checks for HTMLMediaElement
6987 https://bugs.webkit.org/show_bug.cgi?id=65590
6989 Reviewed by Dimitri Glazkov.
6991 <video> and <audio> can be an HTMLElement instance instead of
6992 HTMLMediaElement if MediaPlayer::isAvailable() returns false or
6993 the media feature is disabled at runtime.
6995 * WebView/WebFullScreenController.mm:
6996 (-[WebFullScreenController _isAnyMoviePlaying]):
6998 2011-08-03 Mark Rowe <mrowe@apple.com>
7000 Bring some order to FeatureDefines.xcconfig to make it easier to follow.
7002 Reviewed by Sam Weinig.
7004 * Configurations/FeatureDefines.xcconfig:
7006 2011-08-03 Mark Rowe <mrowe@apple.com>
7008 Clean up FeatureDefines.xcconfig to remove some unnecessary conditional settings
7010 Reviewed by Dave Kilzer.
7012 * Configurations/FeatureDefines.xcconfig:
7014 2011-08-03 Joseph Pecoraro <joepeck@webkit.org>
7016 Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
7017 https://bugs.webkit.org/show_bug.cgi?id=65582
7019 Reviewed by Pavel Feldman.
7021 * WebCoreSupport/WebInspectorClient.h:
7022 * WebCoreSupport/WebInspectorClient.mm:
7024 2011-08-03 Pavel Feldman <pfeldman@google.com>
7026 Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
7027 https://bugs.webkit.org/show_bug.cgi?id=65510
7029 Reviewed by Yury Semikhatsky.
7031 * WebInspector/WebNodeHighlightView.mm:
7032 (-[WebNodeHighlightView drawRect:]):
7034 2011-08-03 Pavel Feldman <pfeldman@chromium.org>
7036 Web Inspector: remove Node parameter from the InspectorClient::highlight
7037 https://bugs.webkit.org/show_bug.cgi?id=65549
7039 Reviewed by Yury Semikhatsky.
7041 * WebCoreSupport/WebInspectorClient.h:
7042 * WebCoreSupport/WebInspectorClient.mm:
7043 (WebInspectorClient::highlight):
7044 * WebInspector/WebNodeHighlighter.h:
7045 * WebInspector/WebNodeHighlighter.mm:
7046 (-[WebNodeHighlighter highlight]):
7048 2011-07-30 Patrick Gansterer <paroga@webkit.org>
7050 Remove inclusion of MainThread.h from Threading.h
7051 https://bugs.webkit.org/show_bug.cgi?id=65081
7053 Reviewed by Darin Adler.
7055 Add missing include statements for MainThread.
7057 * Carbon/CarbonWindowAdapter.mm:
7058 * History/WebBackForwardList.mm:
7059 * History/WebHistoryItem.mm:
7060 * Misc/WebElementDictionary.mm:
7061 * Misc/WebIconDatabase.mm:
7062 * Misc/WebLocalizableStrings.mm:
7063 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
7064 * Plugins/WebBaseNetscapePluginView.mm:
7065 * Plugins/WebBasePluginPackage.mm:
7066 * Plugins/WebNetscapePluginView.mm:
7067 * WebCoreSupport/WebEditorClient.mm:
7068 * WebCoreSupport/WebFrameLoaderClient.mm:
7069 * WebView/WebArchive.mm:
7070 * WebView/WebDataSource.mm:
7071 * WebView/WebHTMLView.mm:
7072 * WebView/WebResource.mm:
7073 * WebView/WebTextIterator.mm:
7074 * WebView/WebView.mm:
7075 * WebView/WebViewData.mm:
7077 2011-07-28 Dan Bernstein <mitz@apple.com>
7079 <rdar://problem/9589433> Displaying Japanese dictionary contents in vertical orientation takes a couple of seconds
7081 Reviewed by Darin Adler.
7083 * WebCoreSupport/WebSystemInterface.mm:
7084 (InitWebCoreSystemInterface): Initialize wkGetVerticalGlyphsForCharacters.
7086 2011-07-28 Brady Eidson <beidson@apple.com>
7088 <rdar://problem/9714337> and https://bugs.webkit.org/show_bug.cgi?id=65306
7089 WebKitInitializeStorageIfNecessary() can take awhile performing i/o, isn't necessary for every WebView
7091 Reviewed by Maciej Stachowiak.
7093 * Storage/WebStorageManager.mm:
7094 (WebKitInitializeStorageIfNecessary): Pass the client along in initializeTracker().
7096 2011-07-27 Mark Hahnenberg <mhahnenberg@apple.com>
7098 Remove operator new from JSCell
7099 https://bugs.webkit.org/show_bug.cgi?id=64999
7101 Reviewed by Oliver Hunt.
7103 Removed the implementation of operator new in JSCell, so any further uses
7104 will not successfully link. Also removed any remaining uses of operator new.
7106 * Plugins/Hosted/ProxyInstance.mm:
7107 (WebKit::ProxyInstance::newRuntimeObject):
7108 (WebKit::ProxyRuntimeMethod::create):
7109 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
7110 (WebKit::ProxyInstance::getMethod):
7111 * Plugins/Hosted/ProxyRuntimeObject.h:
7112 (WebKit::ProxyRuntimeObject::create):
7113 * WebView/WebScriptDebugDelegate.mm:
7114 (-[WebScriptCallFrame scopeChain]):
7116 2011-07-26 Dan Bernstein <mitz@apple.com>
7118 <rdar://problem/9842889> Add a generic pictograph font family
7119 https://bugs.webkit.org/show_bug.cgi?id=65197
7121 Reviewed by Anders Carlsson.
7123 * WebView/WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
7124 * WebView/WebPreferences.mm:
7125 (+[WebPreferences initialize]): Set the default pictograph font family to
7126 "Apple Color Emoji".
7127 (-[WebPreferences pictographFontFamily]): Added this getter.
7128 (-[WebPreferences setPictographFontFamily:]): Added this setter.
7129 * WebView/WebPreferencesPrivate.h:
7130 * WebView/WebView.mm:
7131 (-[WebView _preferencesChanged:]): Pass the preference through to WebCore.
7133 2011-07-25 Ian Henderson <ianh@apple.com>
7135 WebFrame should have a method to determine its visual emptiness
7136 https://bugs.webkit.org/show_bug.cgi?id=64223
7138 Reviewed by Dan Bernstein.
7140 * WebView/WebFrame.mm:
7141 (-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
7143 * WebView/WebFramePrivate.h:
7145 2011-07-19 Leo Yang <leoyang.webkit@gmail.com>
7147 SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
7148 https://bugs.webkit.org/show_bug.cgi?id=60850
7150 Reviewed by Nikolas Zimmermann.
7152 SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions.
7153 This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef>
7154 elements for alternative glyph features.
7156 * MigrateHeaders.make:
7158 2011-07-18 Andy Estes <aestes@apple.com>
7160 Solar Walk app-specific hack accidentally strips stylesheets from the document.
7161 https://bugs.webkit.org/show_bug.cgi?id=64777
7163 Reviewed by Adam Barth.
7165 Solar Walk uses a self-closed title tag in its documents ("<title />").
7166 The HTML5 parser does not recognize this as a valid self-closing tag,
7167 so it treats the remainder of the document as title text.
7169 We work around this in WebKit by injecting a script that calls
7170 document.write() on the contents of document.title, thereby restoring
7171 the contents of the document. Unfortunately this overwrote several
7172 <style> tags that existed before the <title>, thereby causing the
7173 document to not have the intended styling.
7175 Fix this by having the injected script concatenate document.title to
7176 the document instead of overwriting it during document.write(). We can
7177 also take the opportunity to remove document.title since it does not
7178 contain useful information.
7180 * Misc/SolarWalkQuirksUserScript.js:
7182 2011-07-18 Dean Jackson <dino@apple.com>
7184 https://bugs.webkit.org/show_bug.cgi?id=64742
7185 Expose WebPreferences for media playback requiring user gestures and inline playback
7187 Reviewed by Simon Fraser.
7189 Two new WebPreferences: MediaPlaybackRequiresUserGesture and
7190 MediaPlaybackAllowsInline.
7192 * WebView/WebPreferenceKeysPrivate.h:
7193 * WebView/WebPreferences.mm:
7194 (+[WebPreferences initialize]):
7195 (-[WebPreferences mediaPlaybackRequiresUserGesture]):
7196 (-[WebPreferences setMediaPlaybackRequiresUserGesture:]):
7197 (-[WebPreferences mediaPlaybackAllowsInline]):
7198 (-[WebPreferences setMediaPlaybackAllowsInline:]):
7199 * WebView/WebPreferencesPrivate.h:
7200 * WebView/WebView.mm:
7201 (-[WebView _preferencesChanged:]):
7203 2011-07-18 Pratik Solanki <psolanki@apple.com>
7205 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
7206 Get webkit to compile with USE(CFNETWORK) enabled on Mac
7208 Reviewed by David Kilzer.
7210 Create an NSURLDownload from the CF objects that we have.
7212 * Misc/WebDownload.mm:
7213 (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]):
7214 * Misc/WebDownloadInternal.h:
7215 * WebCoreSupport/WebFrameLoaderClient.mm:
7216 (WebFrameLoaderClient::download):
7218 2011-07-15 Pratik Solanki <psolanki@apple.com>
7220 Part of https://bugs.webkit.org/show_bug.cgi?id=63674
7221 Get webkit to compile with USE(CFNETWORK) enabled on Mac
7223 Reviewed by David Kilzer.
7225 New WebKitSystemInterface functions for CFNetwork-based loader.
7227 * WebCoreSupport/WebSystemInterface.mm:
7228 (InitWebCoreSystemInterface):
7230 2011-07-15 Tim Horton <timothy_horton@apple.com>
7232 Overlay scrollbars in overflow areas no longer pulse when revealed
7233 https://bugs.webkit.org/show_bug.cgi?id=64606
7234 <rdar://problem/9390674>
7236 Reviewed by Simon Fraser.
7238 Ensure that the state of the scrollbar implementation is kept in sync
7239 with WebCore's internal representation. Previously, we synchronized them
7240 at paint time, causing pulsing to be skipped due to the scrollbars being
7243 * WebCoreSupport/WebSystemInterface.mm:
7244 (InitWebCoreSystemInterface):
7246 2011-07-15 Andy Estes <aestes@apple.com>
7248 Rename applicationIsSolarWalk() to applicationIsSolarWalkMac().
7249 https://bugs.webkit.org/show_bug.cgi?id=64641
7251 Reviewed by Brian Weinstein.
7253 * WebView/WebView.mm:
7254 (needsSolarWalkQuirksScript): Call applicationIsSolarWalkMac().
7256 2011-07-15 Dan Bernstein <mitz@apple.com>
7258 REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
7259 https://bugs.webkit.org/show_bug.cgi?id=64615
7261 Reviewed by Anders Carlsson.
7263 * WebCoreSupport/WebChromeClient.h:
7264 * WebCoreSupport/WebChromeClient.mm:
7265 (WebChromeClient::setCursorHiddenUntilMouseMoves): Added. Calls
7266 +[NSCursor setHiddenUntilMouseMoves:].
7268 2011-07-14 Gavin Barraclough <barraclough@apple.com>
7270 https://bugs.webkit.org/show_bug.cgi?id=64250
7271 Global strict mode function leaking global object as "this".
7273 Reviewed by Oliver Hunt.
7275 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
7276 (WebKit::NetscapePluginInstanceProxy::invoke):
7277 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
7278 - Change call to pass DOM Window shell, instead of the global varaible object.
7280 2011-07-13 Joseph Pecoraro <joepeck@webkit.org>
7282 Improve names of some ApplicationCacheStorage accessor methods
7283 https://bugs.webkit.org/show_bug.cgi?id=64433
7285 Reviewed by Alexey Proskuryakov.
7287 * WebCoreSupport/WebApplicationCacheQuotaManager.mm:
7288 (-[WebApplicationCacheQuotaManager usage]):
7289 (-[WebApplicationCacheQuotaManager quota]):
7292 2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
7294 ApplicationCache update should not immediately fail when reaching per-origin quota
7295 https://bugs.webkit.org/show_bug.cgi?id=64177
7297 Reviewed by Alexey Proskuryakov.
7299 * WebView/WebUIDelegatePrivate.h:
7300 * DefaultDelegates/WebDefaultUIDelegate.m:
7301 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
7302 Update the delegate to include a space needed parameter.
7304 * WebCoreSupport/WebChromeClient.h:
7305 * WebCoreSupport/WebChromeClient.mm:
7306 (WebChromeClient::reachedApplicationCacheOriginQuota):
7307 Call the delegate with the new space needed information.
7309 2011-07-12 Adam Roben <aroben@apple.com>
7311 Delete some redundant code in WebHTMLView
7313 This code had no user-visible effect, as we were just duplicating work that AppKit would do
7314 for us at a slightly different time.
7316 Fixes <http://webkit.org/b/64390> WebHTMLView sets its root layer's transform unnecessarily
7318 Reviewed by Simon Fraser.
7320 * WebView/WebHTMLView.mm:
7321 (-[WebHTMLView viewDidMoveToWindow]):
7322 (-[WebHTMLView attachRootLayer:]):
7323 Don't bother setting the root layer's transform to account for the scale factor. AppKit
7324 takes care of this for us nowadays.
7326 2011-07-10 Kenichi Ishibashi <bashi@chromium.org>
7328 Let plugins participate in form submission
7329 https://bugs.webkit.org/show_bug.cgi?id=13061
7331 Adds methods to get form value from NPAPI plugins.
7333 Reviewed by Anders Carlsson.
7335 * Plugins/Hosted/WebHostedNetscapePluginView.h:
7336 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
7337 (-[WebHostedNetscapePluginView getFormValue:]): Added.
7338 * Plugins/WebBaseNetscapePluginView.h:
7339 * Plugins/WebBaseNetscapePluginView.mm:
7340 (-[WebBaseNetscapePluginView getFormValue:]): Added.
7341 * Plugins/WebNetscapePluginPackage.h:
7342 * Plugins/WebNetscapePluginPackage.mm:
7343 (-[WebNetscapePluginPackage browserFuncs]): Added.
7344 * Plugins/WebNetscapePluginView.h:
7345 * Plugins/WebNetscapePluginView.mm:
7346 (-[WebNetscapePluginView getFormValue:]): Added.
7347 * WebCoreSupport/WebFrameLoaderClient.mm:
7348 (NetscapePluginWidget::getFormValue): Added.
7350 2011-07-04 Dan Bernstein <mitz@apple.com>
7352 Moved handling of frame size changes into its own method.
7354 Reviewed by Oliver Hunt.
7356 * WebView/WebFrameView.mm:
7357 (-[WebFrameView _frameSizeChanged]): Added. Moved code here...
7358 (-[WebFrameView setFrameSize:]): ...from here.
7359 * WebView/WebFrameViewInternal.h:
7361 2011-07-01 Adele Peterson <adele@apple.com>
7363 Reviewed by Darin Adler.
7365 WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
7366 <rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body
7368 * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
7369 Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word,
7370 space, and after-white-space properties to subframes in the editable document.
7372 2011-07-01 Andy Estes <aestes@apple.com>
7374 Reviewed by Mark Rowe.
7376 Simplify MailQuirksUserScript.js
7377 https://bugs.webkit.org/show_bug.cgi?id=63800
7379 MailQuirksUserScript.js is injected into WebViews in Mail.app on
7380 Leopard to resolve an incompatibility between it and the HTML5 parser.
7381 It did so by taking all nodes in the document between <html> and <body>
7382 and moving them to be children of <body>. This maintains Mail.app's
7383 assumption that document.firstChild.firstChild == document.body.
7385 While this script fixed a specific issue with the Signature panel in
7386 Mail.app, it caused regressions in other WebViews. Since the issue with
7387 the Signature panel is with the empty <head> node implicitly created by
7388 the parser, we can simplify this script by removing this implicit
7389 <head> in the case it has no attributes and no children. This fixes the
7390 Signature panel without affecting other WebViews that have non-trivial
7393 * Misc/MailQuirksUserScript.js: If <head> exists but has no attributes
7394 and no children, remove it.
7396 2011-06-30 Dan Bernstein <mitz@apple.com>
7398 Reviewed by Adele Peterson.
7400 Add +[WebView _allowsRoundingHacks]
7401 https://bugs.webkit.org/show_bug.cgi?id=63734
7403 * WebView/WebView.mm:
7404 (+[WebView _allowsRoundingHacks]): Added this accessor.
7405 * WebView/WebViewPrivate.h:
7407 2011-06-29 Darin Adler <darin@apple.com>
7409 Reviewed by Dan Bernstein.
7411 [Mac] Use system cursors instead of custom bitmaps where possible
7412 https://bugs.webkit.org/show_bug.cgi?id=63679
7414 * WebCoreSupport/WebSystemInterface.mm:
7415 (InitWebCoreSystemInterface): Added WKCursor.
7417 2011-06-28 Ilya Sherman <isherman@chromium.org>
7419 Reviewed by Adam Barth.
7421 form.autocomplete="off" does not work
7422 https://bugs.webkit.org/show_bug.cgi?id=35823
7424 * WebView/WebHTMLRepresentation.mm:
7425 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.
7427 2011-06-26 Mark Rowe <mrowe@apple.com>
7429 Reviewed by Dan Bernstein.
7431 Use a separate file name for Lion's WebKitSystemInterface.
7433 * Configurations/DebugRelease.xcconfig:
7435 2011-06-24 Dan Bernstein <mitz@apple.com>
7437 Reviewed by Anders Carlsson.
7439 Add an option to enable legacy rounding hacks
7440 https://bugs.webkit.org/show_bug.cgi?id=63363
7442 * Misc/WebKitNSStringExtras.mm:
7443 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
7444 Disabled rounding hacks.
7445 (-[NSString _web_widthWithFont:]): Ditto.
7446 * WebView/WebView.mm:
7447 (+[WebView _setAllowsRoundingHacks:]): Added this setter.
7448 * WebView/WebViewPrivate.h:
7450 2011-06-24 Dominic Cooney <dominicc@chromium.org>
7452 Reviewed by Dimitri Glazkov.
7454 Convert shadow DOM-related tests to use window.internals
7455 https://bugs.webkit.org/show_bug.cgi?id=61671
7457 Remove shadow DOM-related methods from Mac API. These are not
7460 * DOM/WebDOMOperations.mm:
7461 * DOM/WebDOMOperationsPrivate.h:
7463 2011-06-24 Yuta Kitamura <yutak@chromium.org>
7465 Reviewed by Adam Barth.
7467 WebSocket: Add run-time flag for new HyBi protocol
7468 https://bugs.webkit.org/show_bug.cgi?id=60348
7470 Make a new flag (Setting::m_useHixie76WebSocketProtocol)
7471 switchable from WebView and WebPreferences.
7473 * WebView/WebPreferenceKeysPrivate.h:
7474 * WebView/WebPreferences.mm:
7475 (+[WebPreferences initialize]):
7476 (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
7477 (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
7478 * WebView/WebPreferencesPrivate.h:
7479 * WebView/WebView.mm:
7480 (-[WebView _preferencesChanged:]):
7482 2011-06-22 Sam Weinig <sam@webkit.org>
7484 Roll out r89469 (Add preference for setting the html parser depth limit)
7486 The preference is not needed at this time, so there is no reason to expose it.
7488 * WebView/WebPreferenceKeysPrivate.h:
7489 * WebView/WebPreferences.mm:
7490 (+[WebPreferences initialize]):
7491 * WebView/WebPreferencesPrivate.h:
7492 * WebView/WebView.mm:
7493 (-[WebView _preferencesChanged:]):
7495 2011-06-22 Sam Weinig <sam@webkit.org>
7497 Reviewed by Adam Barth.
7499 Add preference for setting the html parser depth limit
7500 https://bugs.webkit.org/show_bug.cgi?id=63163
7502 * WebView/WebPreferenceKeysPrivate.h:
7503 * WebView/WebPreferences.mm:
7504 (+[WebPreferences initialize]):
7505 (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
7506 (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
7507 * WebView/WebPreferencesPrivate.h:
7508 * WebView/WebView.mm:
7509 (-[WebView _preferencesChanged:]):
7510 Add private preference for setting the parser depth limit.
7512 2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
7514 Reviewed by Darin Adler.
7516 Make instantiation of legacy editing position more explicit
7517 https://bugs.webkit.org/show_bug.cgi?id=63037
7519 Create new positions since we can't create a legacy editing position outside of WebCore anymore.
7521 * WebView/WebFrame.mm:
7522 (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition.
7523 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
7525 2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
7527 Reviewed by Kent Tamura.
7529 FileChooser should be only created when we need to choose files.
7530 https://bugs.webkit.org/show_bug.cgi?id=63039
7532 * WebCoreSupport/WebChromeClient.mm:
7533 (WebChromeClient::runOpenPanel): Changed to use settings.
7535 2011-06-21 MORITA Hajime <morrita@google.com>
7537 Unreviewed, rolling out r89401 and r89403.
7538 http://trac.webkit.org/changeset/89401
7539 http://trac.webkit.org/changeset/89403
7540 https://bugs.webkit.org/show_bug.cgi?id=62970
7542 Breaks mac build and mistakenly enables the spellcheck API
7544 * Configurations/FeatureDefines.xcconfig:
7546 2011-06-20 MORITA Hajime <morrita@google.com>
7548 Reviewed by Kent Tamura.
7550 Spellcheck API should be build-able.
7551 https://bugs.webkit.org/show_bug.cgi?id=62970
7553 No new tests, changing only build related files
7555 * Configurations/FeatureDefines.xcconfig:
7557 2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
7559 Unreviewed, rolling out r89354.
7560 http://trac.webkit.org/changeset/89354
7561 https://bugs.webkit.org/show_bug.cgi?id=63099
7563 Broke tests on Mac (Requested by rniwa on #webkit).
7565 * WebCoreSupport/WebInspectorClient.mm:
7566 (-[WebInspectorWindowController destroyInspectorView:]):
7567 * WebInspector/WebInspector.mm:
7568 (-[WebInspector show:]):
7569 (-[WebInspector showConsole:]):
7570 (-[WebInspector isDebuggingJavaScript]):
7571 (-[WebInspector toggleDebuggingJavaScript:]):
7572 (-[WebInspector startDebuggingJavaScript:]):
7573 (-[WebInspector stopDebuggingJavaScript:]):
7574 (-[WebInspector isProfilingJavaScript]):
7575 (-[WebInspector toggleProfilingJavaScript:]):
7576 (-[WebInspector startProfilingJavaScript:]):
7577 (-[WebInspector stopProfilingJavaScript:]):
7578 (-[WebInspector isJavaScriptProfilingEnabled]):
7579 (-[WebInspector setJavaScriptProfilingEnabled:]):
7580 (-[WebInspector isTimelineProfilingEnabled]):
7581 (-[WebInspector setTimelineProfilingEnabled:]):
7582 (-[WebInspector setFrontend:]):
7583 (-[WebInspector showWindow:]):
7584 * WebInspector/WebInspectorFrontend.h:
7585 * WebInspector/WebInspectorFrontend.mm:
7586 * WebInspector/WebInspectorPrivate.h:
7588 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
7590 Reviewed by Yury Semikhatsky.
7592 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
7593 https://bugs.webkit.org/show_bug.cgi?id=62985
7595 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
7596 methods for plumbing the menu action handlers through the WebKit and WebCore.
7597 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
7598 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
7599 WebKit/win and WebKit2 to follow.
7601 * WebCoreSupport/WebInspectorClient.mm:
7602 (-[WebInspectorWindowController destroyInspectorView:]):
7603 * WebInspector/WebInspector.mm:
7604 (-[WebInspector showWindow]):
7605 (-[WebInspector show:]):
7606 (-[WebInspector showConsole:]):
7607 (-[WebInspector isDebuggingJavaScript]):
7608 (-[WebInspector toggleDebuggingJavaScript:]):
7609 (-[WebInspector startDebuggingJavaScript:]):
7610 (-[WebInspector stopDebuggingJavaScript:]):
7611 (-[WebInspector isProfilingJavaScript]):
7612 (-[WebInspector toggleProfilingJavaScript:]):
7613 (-[WebInspector startProfilingJavaScript:]):
7614 (-[WebInspector stopProfilingJavaScript:]):
7615 (-[WebInspector isJavaScriptProfilingEnabled]):
7616 (-[WebInspector setJavaScriptProfilingEnabled:]):
7617 (-[WebInspector isTimelineProfilingEnabled]):
7618 (-[WebInspector setTimelineProfilingEnabled:]):
7619 (-[WebInspector setFrontend:]):
7620 (-[WebInspector releaseFrontend]):
7621 (-[WebInspector showWindow:]):
7622 * WebInspector/WebInspectorFrontend.h:
7623 * WebInspector/WebInspectorFrontend.mm:
7624 (-[WebInspectorFrontend isDebuggingEnabled]):
7625 (-[WebInspectorFrontend setDebuggingEnabled:]):
7626 (-[WebInspectorFrontend isProfilingJavaScript]):
7627 (-[WebInspectorFrontend startProfilingJavaScript]):
7628 (-[WebInspectorFrontend stopProfilingJavaScript]):
7629 (-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
7630 (-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
7631 (-[WebInspectorFrontend isTimelineProfilingEnabled]):
7632 (-[WebInspectorFrontend setTimelineProfilingEnabled:]):
7633 * WebInspector/WebInspectorPrivate.h:
7635 2011-06-01 Jer Noble <jer.noble@apple.com>
7637 Reviewed by Eric Carlson.
7639 Move Full Screen Controllers into WebCore.
7641 Remove dependency on QTKit from wekitExitFullscreen()
7642 https://bugs.webkit.org/show_bug.cgi?id=61843
7644 WebVideoFullscreenController, WebVideoFullscreenHUDController, and WebWindowAnimation
7645 have been moved into WebCore.
7647 * WebCoreSupport/WebSystemInterface.mm:
7648 (InitWebCoreSystemInterface): Add support for four WKSI functions in WCSI.
7649 * WebView/WebFullScreenController.mm: Remove unused #include.
7650 * WebView/WebView.mm: Change the include location of
7651 WebVideoFullscreenController.h
7653 2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
7655 Reviewed by Darin Adler.
7657 Separate concerns of loading file icons and choosing files.
7658 https://bugs.webkit.org/show_bug.cgi?id=62931
7660 * WebCoreSupport/WebChromeClient.h:
7661 * WebCoreSupport/WebChromeClient.mm:
7662 (WebChromeClient::loadIconForFiles): Renamed.
7664 2011-06-18 Andrew Wellington <andrew@webkit.org>
7666 Reviewed by Alexey Proskuryakov.
7668 https://bugs.webkit.org/show_bug.cgi?id=62843
7669 WebKit Mac API calls didReceiveAuthenticationChallenge instead of
7670 didCancelAuthenticationChallenge
7672 * WebView/WebView.mm:
7673 (-[WebView _cacheResourceLoadDelegateImplementations]):
7675 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
7677 Unreviewed, rolling out r89026.
7678 http://trac.webkit.org/changeset/89026
7679 https://bugs.webkit.org/show_bug.cgi?id=62804
7681 These patches were likely correct. I'll investigate the
7682 browser_test failures. (Requested by abarth on #webkit).
7684 * WebView/WebVideoFullscreenHUDWindowController.mm:
7685 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
7687 2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
7691 Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
7692 https://bugs.webkit.org/show_bug.cgi?id=62796
7694 The patches broke chromium browser tests.
7696 * WebView/WebVideoFullscreenHUDWindowController.mm:
7697 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
7699 2011-06-16 Adam Barth <abarth@webkit.org>
7701 Reviewed by Eric Seidel.
7703 Remove HTMLVideoElement::processingUserGesture
7704 https://bugs.webkit.org/show_bug.cgi?id=62784
7706 * WebView/WebVideoFullscreenHUDWindowController.mm:
7707 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
7709 2011-06-15 Adam Barth <abarth@webkit.org>
7711 Reviewed by Eric Seidel.
7713 Remove ScriptController::setAllowPopupsFromPlugin
7714 https://bugs.webkit.org/show_bug.cgi?id=62706
7716 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
7717 (WebKit::NetscapePluginInstanceProxy::evaluate):
7718 * Plugins/WebNetscapePluginView.mm:
7719 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
7721 2011-06-15 David Kilzer <ddkilzer@apple.com>
7723 <http://webkit.org/b/62745> Convert WebNSFileManagerExtras.m to Objective-C++
7725 Reviewed by Joseph Pecoraro.
7727 * Misc/WebNSFileManagerExtras.mm: Renamed from Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
7728 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
7729 Added static_cast<MetaDataInfo *>.
7731 2011-06-14 Stephanie Lewis <slewis@apple.com>
7733 Rubber stamped by Oliver Hunt.
7735 <rdar://problem/9511169>
7740 2011-06-13 Kentaro Hara <haraken@google.com>
7742 Reviewed by Alexey Proskuryakov.
7744 Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
7745 https://bugs.webkit.org/show_bug.cgi?id=61256
7747 In order to prevent rounding error caused by expanding/shrinking a page
7748 using different calculation here and there, I added a common calculation
7749 method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
7750 keeping the ratio of width and height of the original page.
7751 [WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
7752 and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
7753 use resizePageRectsKeepingRatio() to expand/shrink a page.
7755 Test: printing/page-count-with-one-word.html
7757 * WebView/WebHTMLView.mm:
7758 (-[WebHTMLView _web_setPrintingModeRecursive]):
7759 (-[WebHTMLView _web_clearPrintingModeRecursive]):
7760 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
7761 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]):
7762 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
7763 (-[WebHTMLView _endPrintMode]):
7764 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
7765 (-[WebHTMLView _endScreenPaginationMode]):
7766 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]):
7767 (-[WebHTMLView layout]):
7768 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
7769 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
7770 (-[WebHTMLView setPageWidthForPrinting:]):
7772 2011-06-13 Tony Chang <tony@chromium.org>
7774 Reviewed by Dimitri Glazkov.
7776 rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
7777 https://bugs.webkit.org/show_bug.cgi?id=62578
7779 * Configurations/FeatureDefines.xcconfig:
7781 2011-06-13 Tony Chang <tony@chromium.org>
7783 Reviewed by Adam Barth.
7785 rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
7786 https://bugs.webkit.org/show_bug.cgi?id=62545
7788 * Configurations/FeatureDefines.xcconfig:
7790 2011-06-12 Adam Barth <abarth@webkit.org>
7792 Reviewed by Alexey Proskuryakov.
7794 Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
7795 https://bugs.webkit.org/show_bug.cgi?id=62516
7797 * WebCoreSupport/WebFrameLoaderClient.h:
7798 * WebCoreSupport/WebFrameLoaderClient.mm:
7799 (WebFrameLoaderClient::interruptedForPolicyChangeError):
7801 2011-06-12 Adam Barth <abarth@webkit.org>
7803 Reviewed by Eric Seidel.
7805 Remove FrameLoader::isProcessingUserGesture
7806 https://bugs.webkit.org/show_bug.cgi?id=62519
7808 * WebView/WebView.mm:
7809 (-[WebView _isProcessingUserGesture]):
7811 2011-06-12 Adam Barth <abarth@webkit.org>
7813 Reviewed by Alexey Proskuryakov.
7815 Remove trival "forward-to-client" member functions from FrameLoader
7816 https://bugs.webkit.org/show_bug.cgi?id=62510
7818 * WebCoreSupport/WebFrameNetworkingContext.mm:
7819 (WebFrameNetworkingContext::blockedError):
7821 2011-06-10 Tony Chang <tony@chromium.org>
7823 Reviewed by Ojan Vafai.
7825 add a compile guard ENABLE(FLEXBOX)
7826 https://bugs.webkit.org/show_bug.cgi?id=62049
7828 * Configurations/FeatureDefines.xcconfig:
7830 2011-06-06 Michael Saboff <msaboff@apple.com>
7832 Reviewed by Geoffrey Garen.
7834 Fonts returned by FontCache::getFontDataForCharacters() are never released
7835 https://bugs.webkit.org/show_bug.cgi?id=61875
7837 This change allows fonts allocated as system fallback fonts to be
7838 released. Previously, the reference counts for these fonts grew
7839 without bound. This is implemented as an auto release class that wraps
7840 accesses to the cache for system fallback fonts. All such accesses are
7841 via the method FontCache::getFontDataForCharacters. The new class is
7842 called FontCachePurgePreventer. When such an object exists, it protects
7843 these fonts from deletion.
7845 See more comments for this defect in Source/WebCore/ChangeLog.
7847 * Misc/WebKitNSStringExtras.mm:
7848 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
7849 (-[NSString _web_widthWithFont:]):
7850 Wrapped code accessing fallback fonts with local
7851 FontCachePurgePreventer in these methods.
7853 * Misc/WebStringTruncator.mm:
7854 (+[WebStringTruncator centerTruncateString:toWidth:]):
7855 (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
7856 (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
7857 (+[WebStringTruncator widthOfString:font:]):
7858 Wrapped code accessing fallback fonts with local
7859 FontCachePurgePreventer in these methods.
7861 2011-06-06 Peter Kasting <pkasting@google.com>
7863 Reviewed by Antonio Gomes.
7865 Remove unnecessary args from scroll functions.
7866 https://bugs.webkit.org/show_bug.cgi?id=61648
7868 * WebView/WebFrame.mm:
7869 (-[WebFrame _scrollDOMRangeToVisible:]):
7871 2011-06-06 Alexandru Chiculita <achicu@adobe.com>
7873 Reviewed by Kent Tamura.
7875 Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
7876 https://bugs.webkit.org/show_bug.cgi?id=61628
7878 * Configurations/FeatureDefines.xcconfig:
7880 2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
7882 Reviewed by Kent Tamura.
7884 Add ENABLE(CSS_REGIONS) guard for CSS Regions support
7885 https://bugs.webkit.org/show_bug.cgi?id=61631
7887 * Configurations/FeatureDefines.xcconfig:
7889 2011-06-02 Anders Carlsson <andersca@apple.com>
7891 Reviewed by Sam Weinig.
7893 Need a way to install the memory pressure handler without initializing WebKit1
7894 https://bugs.webkit.org/show_bug.cgi?id=61975
7896 Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
7897 -[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
7898 but we'd like to be able to install a memory pressure handler without creating a WebView or even
7899 calling any WebView method since that will call +[WebView initialize].
7902 * WebView/WebView.mm:
7903 (WebInstallMemoryPressureHandler):
7904 * WebView/WebViewPrivate.h:
7906 2011-05-27 Stephanie Lewis <slewis@apple.com>
7910 Fix a typo in the order_file flag.
7912 * Configurations/Base.xcconfig:
7914 2011-05-27 Stephanie Lewis <slewis@apple.com>
7916 Rubber Stamped by Adam Roben.
7918 Update Order Files. Use -order_file flag since it can order more of the binary.
7920 * Configurations/Base.xcconfig:
7923 2011-05-25 Stephanie Lewis <slewis@apple.com>
7925 Reviewed by Brady Eidson.
7927 https://bugs.webkit.org/show_bug.cgi?id=61407
7928 part of <rdar://problem/8675177>
7929 Remove Quicklook pref. Moving it enirely down into WebCore so it can
7930 be calculated only on reloads.
7932 * WebView/WebPreferenceKeysPrivate.h:
7933 * WebView/WebPreferences.mm:
7934 (+[WebPreferences initialize]):
7935 * WebView/WebPreferencesPrivate.h:
7936 * WebView/WebView.mm:
7937 (-[WebView _preferencesChanged:]):
7939 2011-05-24 Jer Noble <jer.noble@apple.com>
7941 Reviewed by Darin Adler.
7943 Video fails to play on Vimeo
7944 https://bugs.webkit.org/show_bug.cgi?id=61403
7946 * WebCoreSupport/WebSystemInterface.mm:
7947 (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
7948 wkQTMovieResolvedURL.
7950 2011-05-24 Keishi Hattori <keishi@webkit.org>
7952 Reviewed by Kent Tamura.
7954 Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
7955 https://bugs.webkit.org/show_bug.cgi?id=61273
7957 * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
7959 2011-05-24 Adam Barth <abarth@webkit.org>
7961 Reviewed by Eric Seidel.
7963 Add FIXME comments about removing FrameLoader::isProcessingUserGesture
7964 https://bugs.webkit.org/show_bug.cgi?id=61395
7966 * WebView/WebView.mm:
7967 (-[WebView _isProcessingUserGesture]):
7969 2011-05-24 Michael Saboff <msaboff@apple.com>
7971 Reviewed by Geoffrey Garen.
7973 Improve handling in WebCore of low memory situations
7974 https://bugs.webkit.org/show_bug.cgi?id=61222
7976 Added call to enable memory pressure handling.
7978 * WebView/WebView.mm:
7979 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
7980 * WebView/WebViewInternal.h:
7982 2011-05-24 Jay Civelli <jcivelli@chromium.org>
7984 Rubberstamped by David Kilzer.
7986 Updated some files that I forgot in my previous MHTML CL.
7988 * Configurations/FeatureDefines.xcconfig:
7990 2011-05-20 Jeremy Noble <jer.noble@apple.com>
7992 Reviewed by Simon Fraser.
7994 Stack overflow in WebFullScreenController when built on Leopard and run on SnowLeopard.
7995 https://bugs.webkit.org/show_bug.cgi?id=61224
7997 Remove the CATransaction(SnowLeopardConvenience) functions, and replace them with the Leopard
8000 * WebView/WebFullScreenController.mm:
8001 (-[WebFullScreenController windowDidEnterFullscreen:]):
8002 (-[WebFullScreenController enterFullscreen:]):
8003 (-[WebFullScreenController exitFullscreen]):
8004 (-[WebFullscreenWindow setRendererLayer:]):
8006 2011-05-20 Andy Estes <aestes@apple.com>
8008 Reviewed by Darin Adler.
8010 WebView loses firstResponder status when entering full-screen mode.
8011 https://bugs.webkit.org/show_bug.cgi?id=61153
8013 * Misc/WebNSWindowExtras.h:
8014 * Misc/WebNSWindowExtras.m:
8015 (-[NSWindow makeResponder:firstResponderIfDescendantOfView:]): Add a
8016 convenience method to NSWindow that makes the given NSResponder first
8017 responder only if it is a descendant of the given view.
8018 * WebView/WebFullScreenController.mm:
8019 (-[WebFullScreenController windowDidEnterFullscreen:]): If the WebView
8020 was a descendant of the browser window's first responder when entering
8021 full-screen mode, set the full-screen window's first responder to that
8023 (-[WebFullScreenController exitFullscreen]): Do the reverse of what is
8024 done in windowDidEnterFullscreen:.
8026 2011-05-20 Enrica Casucci <enrica@apple.com>
8028 Reviewed by David Kilzer.
8030 Add delegate methods about focus and blur to all elements.
8031 https://bugs.webkit.org/show_bug.cgi?id=61218
8033 We want to have delegates for these events for all the elements, not only the form elements.
8034 The patch changes the name of the methods in a way that is not form element specific.
8036 * WebCoreSupport/WebChromeClient.h:
8037 * WebCoreSupport/WebChromeClient.mm:
8038 (WebChromeClient::elementDidFocus):
8039 (WebChromeClient::elementDidBlur):
8040 * WebView/WebUIDelegatePrivate.h:
8042 2011-05-20 Simon Fraser <simon.fraser@apple.com>
8044 Reviewed by Sam Weinig.
8046 numberOfActiveAnimations() can include animations from documents in the page cache
8047 https://bugs.webkit.org/show_bug.cgi?id=53641
8049 Pass the Frame's document as the one to count animations on.
8051 * WebView/WebFrame.mm:
8052 (-[WebFrame _numberOfActiveAnimations]):
8054 2011-05-17 Timothy Hatcher <timothy@apple.com>
8056 Update the the context menu to reflect the system search provider on Mac.
8058 <rdar://problem/9198419>
8060 Reviewed by Sam Weinig.
8062 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
8063 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
8064 create the web search context menu title.
8065 * WebCoreSupport/WebSystemInterface.mm:
8066 (InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.
8068 2011-05-16 Emil A Eklund <eae@chromium.org>
8070 Reviewed by Eric Seidel.
8072 Replace docTop/Right/Bottom/Left/Width/Height with documentRect
8073 https://bugs.webkit.org/show_bug.cgi?id=60743
8075 Replace uses of docWidth/Height with documentRect.
8077 * WebView/WebFrame.mm:
8078 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
8080 2011-05-16 Yuzo Fujishima <yuzo@google.com>
8082 Reviewed by Antti Koivisto.
8084 Fix for Bug 43704 - Web font is printed as blank if it is not cached
8085 https://bugs.webkit.org/show_bug.cgi?id=43704
8087 * WebView/WebHTMLView.mm:
8088 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): Use ResourceCacheValidationSuppressor to allow stale resources in printing.
8090 2011-05-16 David Kilzer <ddkilzer@apple.com>
8092 <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
8093 <rdar://problem/9446430>
8095 Reviewed by Mark Rowe.
8097 * Configurations/Base.xcconfig: Fixed typo.
8099 2011-05-13 Jon Lee <jonlee@apple.com>
8101 Reviewed by Simon Fraser.
8103 Can't horizontally scroll iframes and overflow because wheel events are always accepted
8104 https://bugs.webkit.org/show_bug.cgi?id=60779
8106 * WebCoreSupport/WebChromeClient.h:
8107 (WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
8108 (WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
8110 2011-05-13 Sam Weinig <sam@webkit.org>
8112 Reviewed by Anders Carlsson.
8114 Prune #includes from FrameView.h (Part 2)
8115 https://bugs.webkit.org/show_bug.cgi?id=60748
8117 - Update files that were depending on FrameView.h #including Frame.h or
8120 * WebView/WebClipView.mm:
8121 * WebView/WebHTMLView.mm:
8122 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
8124 2011-05-12 Pratik Solanki <psolanki@apple.com>
8126 Reviewed by Antti Koivisto.
8128 Part of WebCore should use CFNetwork-based loader on Mac
8129 https://bugs.webkit.org/show_bug.cgi?id=51836
8131 Use CFRunLoop when using CFNetwork.
8133 * WebView/WebView.mm:
8134 (-[WebView scheduleInRunLoop:forMode:]):
8135 (-[WebView unscheduleFromRunLoop:forMode:]):
8137 2011-05-12 Pratik Solanki <psolanki@apple.com>
8139 Reviewed by Antti Koivisto.
8141 Part of WebCore should use CFNetwork-based loader on Mac
8142 https://bugs.webkit.org/show_bug.cgi?id=51836
8144 Include AuthenticationCF.h header file.
8146 * Misc/WebDownload.mm:
8147 * Plugins/WebBaseNetscapePluginView.mm:
8148 * WebCoreSupport/WebFrameLoaderClient.mm:
8150 2011-05-12 Adele Peterson <adele@apple.com>
8152 Reviewed by Darin Adler and Adam Barth.
8154 Fix for <rdar://problem/9253454> Solar Walk For Mac: Info window is blank (HTML5 parser)
8155 https://bugs.webkit.org/show_bug.cgi?id=60685
8157 Solar Walk uses a self closing title tag, so to match the behavior of the old parser,
8158 we use a UserScript to write the contents of the title element to the end of the document so it can be re-parsed.
8160 * Misc/SolarWalkQuirksUserScript.js: Added.
8161 * WebView/WebView.mm:
8162 (needsSolarWalkQuirksScript):
8163 (leakSolarWalkQuirksUserScriptContents):
8164 (-[WebView _injectSolarWalkQuirksScript]):
8165 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
8167 2011-05-12 Jia Pu <jpu@apple.com>
8169 Reviewed by Darin Adler.
8171 Regression caused by changeset 86281
8172 https://bugs.webkit.org/show_bug.cgi?id=60712
8173 <rdar://problem/9427970>
8175 Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
8176 So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
8177 returns. So we don't need to use the condition to coordinate between these two function. In fact,
8178 all callbacks are delivered on main thread. We don't really need any locking here.
8180 Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
8183 * WebCoreSupport/CorrectionPanel.h:
8184 * WebCoreSupport/CorrectionPanel.mm:
8185 (CorrectionPanel::CorrectionPanel):
8186 (CorrectionPanel::show):
8187 (CorrectionPanel::dismiss):
8188 (CorrectionPanel::dismissInternal):
8189 (CorrectionPanel::handleAcceptedReplacement):
8190 * WebCoreSupport/WebEditorClient.mm:
8191 (WebEditorClient::dismissCorrectionPanelSoon):
8193 2011-05-12 Patrick Gansterer <paroga@webkit.org>
8195 Reviewed by Adam Barth.
8197 Enable OwnPtr strict mode in PluginHalter
8198 https://bugs.webkit.org/show_bug.cgi?id=60681
8200 * WebView/WebView.mm:
8201 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
8203 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
8205 Reviewed by Darin Adler.
8207 String operator+ reallocates unnecessarily when concatting > 2 strings
8208 https://bugs.webkit.org/show_bug.cgi?id=58420
8210 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
8212 * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
8213 (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):
8215 2011-05-10 Tony Gentilcore <tonyg@chromium.org>
8217 Reviewed by Darin Adler.
8219 Perform some forward declarations suggested by include-what-you-use
8220 https://bugs.webkit.org/show_bug.cgi?id=60545
8222 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
8223 * WebView/WebFrame.mm:
8225 2011-05-11 Jia Pu <jpu@apple.com>
8227 Reviewed by Darin Adler.
8229 CorrectionPanel sometimes hangs in dismissSoon().
8230 https://bugs.webkit.org/show_bug.cgi?id=60599
8231 <rdar://problem/9313628>
8233 Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
8234 to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
8235 for condition checking.
8237 * WebCoreSupport/CorrectionPanel.h:
8238 * WebCoreSupport/CorrectionPanel.mm:
8239 (CorrectionPanel::CorrectionPanel):
8240 (CorrectionPanel::show):
8241 (CorrectionPanel::dismissSoon):
8242 (CorrectionPanel::dismissInternal):
8243 (CorrectionPanel::handleAcceptedReplacement):
8245 2011-05-10 Anton D'Auria <adauria@apple.com>
8247 Reviewed by David Levin.
8249 Add ApplicationCache API to get disk usage per origin
8250 https://bugs.webkit.org/show_bug.cgi?id=57127
8254 * WebCoreSupport/WebApplicationCache.h:
8255 * WebCoreSupport/WebApplicationCache.mm:
8256 (+[WebApplicationCache diskUsageForOrigin:]):
8258 2011-05-10 Anton D'Auria <adauria@apple.com>
8260 Reviewed by Alexey Proskuryakov.
8262 Add ApplicationCache API to get disk usage per origin
8263 https://bugs.webkit.org/show_bug.cgi?id=57127
8267 * WebCoreSupport/WebApplicationCache.h:
8268 * WebCoreSupport/WebApplicationCache.mm:
8269 (+[WebApplicationCache diskUsageForOrigin:]):
8271 2011-05-10 Beth Dakin <bdakin@apple.com>
8273 Reviewed by Darin Adler.
8275 https://bugs.webkit.org/show_bug.cgi?id=60582
8276 Crash switching overlay/non-overlay scrollbar preference still possible
8278 <rdar://problem/9323983>
8280 * WebCoreSupport/WebSystemInterface.mm:
8281 (InitWebCoreSystemInterface):
8283 2011-05-09 Jeremy Noble <jer.noble@apple.com>
8285 Reviewed by Darin Adler.
8287 Command-~/Exposé to another window while <video> is in full screen, breaks Safari, eventually leading to crash
8288 https://bugs.webkit.org/show_bug.cgi?id=60496
8290 When animating into and out of full screen, order out and back in the original webView window,
8291 disabling animations when necessary. The exitFullscreen method was targeting the wrong window,
8292 as the webView is hosted in the full screen window when we ask for it's parent window.
8294 * WebView/WebFullScreenController.mm:
8295 (-[WebFullScreenController windowDidEnterFullscreen:]):
8296 (-[WebFullScreenController exitFullscreen]):
8298 2011-05-04 Philippe Normand <pnormand@igalia.com>
8300 Reviewed by Dimitri Glazkov.
8302 Implement LayoutTestController::pseudoShadowId()
8303 https://bugs.webkit.org/show_bug.cgi?id=60034
8305 * DOM/WebDOMOperations.mm:
8306 (-[DOMElement _shadowPseudoId]):
8307 * DOM/WebDOMOperationsPrivate.h:
8309 2011-05-05 Dan Bernstein <mitz@apple.com>
8311 Reviewed by Simon Fraser.
8313 WebKit part of <rdar://problem/9155590> Broken animation in iAd producer
8315 * WebCoreSupport/WebSystemInterface.mm:
8316 (InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.
8318 2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
8320 Reviewed by Eric Seidel.
8322 Rename SelectionController to FrameSelection
8323 https://bugs.webkit.org/show_bug.cgi?id=60234
8325 * WebView/WebFrame.mm:
8326 (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
8327 * WebView/WebFrameInternal.h:
8328 * WebView/WebHTMLView.mm:
8329 * WebView/WebTextCompletionController.mm:
8330 (-[WebTextCompletionController doCompletion]):
8331 * WebView/WebView.mm:
8333 2011-05-04 Cris Neckar <cdn@chromium.org>
8335 Reviewed by Adam Barth.
8337 Expose WebView directly through ChromeClient.
8338 https://bugs.webkit.org/show_bug.cgi?id=49902
8340 * WebCoreSupport/WebChromeClient.h:
8341 (WebChromeClient::webView):
8342 * WebView/WebFrame.mm:
8345 2011-05-04 Tao Bai <michaelbai@chromium.org>
8347 Reviewed by David Kilzer.
8349 Populate touch-icon url to FrameLoaderClient
8350 https://bugs.webkit.org/show_bug.cgi?id=59143
8352 Respect the interface change in FrameLoaderClient.
8354 * Configurations/FeatureDefines.xcconfig:
8355 * WebCoreSupport/WebFrameLoaderClient.h:
8356 * WebCoreSupport/WebFrameLoaderClient.mm:
8357 (WebFrameLoaderClient::dispatchDidChangeIcons):
8359 2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
8361 Reviewed by Dimitri Glazkov.
8363 Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
8364 https://bugs.webkit.org/show_bug.cgi?id=58703
8366 * DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.
8368 2011-05-02 Adam Roben <aroben@apple.com>
8370 Take advantage of implicit conversion from nullptr_t to PassOwnPtr
8372 Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
8373 doesn't work, but should
8375 Reviewed by Adam Barth.
8377 * History/WebHistory.mm:
8378 * Plugins/WebNetscapePluginEventHandler.mm:
8379 * WebView/WebView.mm:
8381 2011-05-02 Brady Eidson <beidson@apple.com>
8383 Reviewed by Anders Carlsson.
8385 <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
8386 In Aperture, a WebView might be dealloc'ed before it finishes loading.
8388 * WebView/WebView.mm:
8389 (needsSelfRetainWhileLoadingQuirk):
8390 (-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
8391 (-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
8392 (-[WebView _didFailLoadWithError:forFrame:]): Ditto.
8393 (-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.
8395 2011-05-02 Adam Barth <abarth@webkit.org>
8397 Reviewed by David Levin.
8399 PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
8400 https://bugs.webkit.org/show_bug.cgi?id=59924
8402 * History/WebHistory.mm:
8403 (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
8404 * Plugins/WebBaseNetscapePluginView.mm:
8405 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
8406 * WebCoreSupport/WebFrameLoaderClient.mm:
8407 (WebFrameLoaderClient::savePlatformDataToCachedFrame):
8408 * WebView/WebView.mm:
8409 (-[WebView _injectMailQuirksScript]):
8410 (-[WebView _injectOutlookQuirksScript]):
8413 2011-05-02 Sam Weinig <sam@webkit.org>
8415 Reviewed by Adam Barth.
8417 Prune some #includes from DOMWindow.h
8418 https://bugs.webkit.org/show_bug.cgi?id=59907
8420 * Plugins/WebBaseNetscapePluginView.mm:
8421 * WebView/WebFrame.mm:
8422 Add now missing SecurityOrigin.h #includes.
8424 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
8426 Reviewed by Eric Seidel.
8428 Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
8429 https://bugs.webkit.org/show_bug.cgi?id=59837
8431 Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.
8433 * WebView/WebHTMLView.mm:
8434 (-[WebHTMLView menuForEvent:]):
8435 (-[WebHTMLView acceptsFirstMouse:]):
8436 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
8438 2011-05-01 Ryosuke Niwa <rniwa@webkit.org>
8440 Reviewed by Eric Seidel.
8442 Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
8443 https://bugs.webkit.org/show_bug.cgi?id=59835
8445 Moved currentKeyboardEvent.
8447 * WebView/WebHTMLView.mm:
8448 (currentKeyboardEvent):
8449 (-[WebHTMLView becomeFirstResponder]):
8451 2011-04-29 Dean Jackson <dino@apple.com>
8453 Reviewed by Simon Fraser.
8455 Add ENABLE macro for WebKitAnimation
8456 https://bugs.webkit.org/show_bug.cgi?id=59729
8458 Add new feature to toggle WebKit Animation API.
8460 * Configurations/FeatureDefines.xcconfig:
8462 2011-04-28 David Kilzer <ddkilzer@apple.com>
8464 <http://webkit.org/b/59758> Fix static analyzer warnings for missing assignment to 'self' in -init methods
8466 Reviewed by Anders Carlsson.
8468 * History/WebHistory.mm:
8469 (-[WebHistoryPrivate init]):
8470 * Misc/WebElementDictionary.mm:
8471 (-[WebElementDictionary initWithHitTestResult:]):
8472 * Misc/WebIconDatabase.mm:
8473 (-[WebIconDatabase init]):
8474 * Plugins/WebPluginController.mm:
8475 (-[WebPluginController initWithDocumentView:]):
8476 * Plugins/WebPluginRequest.m:
8477 (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
8478 * WebCoreSupport/WebEditorClient.mm:
8479 (-[WebEditCommand initWithEditCommand:]):
8480 * WebCoreSupport/WebJavaScriptTextInputPanel.m:
8481 (-[WebJavaScriptTextInputPanel initWithPrompt:text:]):
8482 * WebView/WebNavigationData.mm:
8483 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
8485 2011-04-28 David Levin <levin@chromium.org>
8487 Reviewed by Adam Barth.
8489 Remove IMAGE_RESIZER related code.
8490 https://bugs.webkit.org/show_bug.cgi?id=59735
8492 * Configurations/FeatureDefines.xcconfig:
8494 2011-04-28 Adam Barth <abarth@webkit.org>
8496 Reviewed by Eric Seidel.
8499 https://bugs.webkit.org/show_bug.cgi?id=59678
8501 Remove WML-related configuration options and private APIs.
8503 * Configurations/FeatureDefines.xcconfig:
8504 * WebCoreSupport/WebChromeClient.mm:
8505 (stringForMessageSource):
8506 * WebView/WebFramePrivate.h:
8507 * WebView/WebUIDelegatePrivate.h:
8509 2011-04-28 Brian Weinstein <bweinstein@apple.com>
8511 Reviewed by Timothy Hatcher.
8513 Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window
8514 https://bugs.webkit.org/show_bug.cgi?id=59747
8516 Restore functions that were removed in r85051. They were needed when the inspector is the frontmost window.
8517 Also update them to call _inspectedWebView.get() - since it's a RetainPtr now.
8519 * WebCoreSupport/WebInspectorClient.mm:
8520 (-[WebInspectorWindowController showWebInspector:]):
8521 (-[WebInspectorWindowController showErrorConsole:]):
8522 (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
8523 (-[WebInspectorWindowController toggleProfilingJavaScript:]):
8524 (-[WebInspectorWindowController validateUserInterfaceItem:]):
8526 2011-04-28 David Kilzer <ddkilzer@apple.com>
8528 <http://webkit.org/b/59725> -[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:] leaks a CALayer
8530 Reviewed by Dan Bernstein.
8532 * WebView/WebFullScreenController.mm:
8533 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
8534 Use a RetainPtr to hold the CALayer and to fix the leak.
8536 2011-04-28 David Kilzer <ddkilzer@apple.com>
8538 Follow-up fix: <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
8540 Addresses review comment from Darin Adler.
8542 * WebView/WebPDFView.mm:
8543 (-[WebPDFView menuForEvent:]): Use a local variable and -release
8544 instead of -autorelease.
8546 2011-04-28 Anders Carlsson <andersca@apple.com>
8548 Fix a thinko - separateRealmLabel is not an NSImageView.
8550 * Panels/WebAuthenticationPanel.h:
8552 2011-04-28 David Kilzer <ddkilzer@apple.com>
8554 <http://webkit.org/b/59727> -[WebPDFView menuForEvent:] leaks NSMenuItem objects
8556 Reviewed by Dan Bernstein.
8558 * WebView/WebPDFView.mm:
8559 (-[WebPDFView menuForEvent:]): Call -autorelease after copying
8560 each NSMenuItem. Regressed in r9566 for Bug 3711.
8562 2011-04-28 Enrica Casucci <enrica@apple.com>
8564 Reviewed by Beth Dakin.
8566 Momentum scroll tweak for WebKit.
8567 https://bugs.webkit.org/show_bug.cgi?id=59723
8568 <rdar://problem/9259933>
8570 * WebView/WebDynamicScrollBarsView.mm:
8571 (-[WebDynamicScrollBarsView scrollWheel:]): Changed constant.
8573 2011-04-27 Anders Carlsson <andersca@apple.com>
8575 Follow-up Leopard build fix.
8577 * Carbon/HIViewAdapter.m:
8578 (_webkit_NSView_setNeedsDisplayInRect):
8580 2011-04-27 Anders Carlsson <andersca@apple.com>
8582 More clang++ 32-bit build fixes.
8584 * Carbon/CarbonWindowAdapter.mm:
8585 (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
8586 (-[CarbonWindowAdapter setContentView:]):
8587 (-[CarbonWindowAdapter _handleContentBoundsChanged]):
8588 * Carbon/HIViewAdapter.m:
8589 (_webkit_NSView_setNeedsDisplayInRect):
8590 * Panels/WebAuthenticationPanel.h:
8591 * Plugins/WebBaseNetscapePluginView.mm:
8592 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
8593 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
8595 * WebCoreSupport/WebChromeClient.mm:
8596 (WebChromeClient::scrollRectIntoView):
8597 * WebCoreSupport/WebViewFactory.mm:
8598 (-[WebViewFactory accessibilityConvertScreenRect:]):
8599 * WebView/WebFrameView.mm:
8600 (-[WebFrameView _scrollToBeginningOfDocument]):
8601 (-[WebFrameView _scrollToEndOfDocument]):
8602 * WebView/WebFullScreenController.mm:
8603 (-[WebFullScreenController windowDidEnterFullscreen:]):
8604 * WebView/WebHTMLView.mm:
8605 (-[WebHTMLView _hitViewForEvent:]):
8606 (coreGraphicsScreenPointForAppKitScreenPoint):
8607 * WebView/WebPDFView.mm:
8608 (-[WebPDFView setScrollPoint:]):
8610 2011-04-27 Yury Semikhatsky <yurys@chromium.org>
8612 Reviewed by Pavel Feldman.
8614 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
8615 https://bugs.webkit.org/show_bug.cgi?id=44230
8617 Use RetainPtr access inspected view from the inspector one to avoid inspected view being deleted before
8618 inspector is closed.
8620 * WebCoreSupport/WebInspectorClient.mm: store reference to inspected view in RetainPtr. Despite the removed
8621 comment in initWithInspectedWebView this doesn't introduce cyclic reference since there are no retaining
8622 pointers to the WebInspectorWindowController from the inspected page or from the WebInspectorClient.
8623 There is only one reference to it from WebInspectorFrontendClient which is held by the inspector
8626 Drive-by fix: removed several unused methods which are currently implemented in mac/WebInspector/WebInspector.mm
8627 (-[WebInspectorWindowController initWithInspectedWebView:]):
8628 (-[WebInspectorWindowController close]):
8629 (-[WebInspectorWindowController showWindow:]):
8630 (-[WebInspectorWindowController setAttachedWindowHeight:]):
8631 (-[WebInspectorWindowController destroyInspectorView:]):
8633 2011-04-26 Sam Weinig <sam@webkit.org>
8635 Reviewed by David Hyatt.
8637 Remove Datagrid from the tree
8638 https://bugs.webkit.org/show_bug.cgi?id=59543
8640 * Configurations/FeatureDefines.xcconfig:
8643 2011-04-26 Dan Bernstein <mitz@apple.com>
8645 Reviewed by Mark Rowe.
8647 Choose the compiler based on the Xcode version for Snow Leopard debug builds.
8649 * Configurations/Base.xcconfig:
8650 * Configurations/CompilerVersion.xcconfig: Added.
8652 2011-04-25 Adam Barth <abarth@webkit.org>
8654 Reviewed by David Levin.
8656 WebKit2 should play nice with strict OwnPtrs
8657 https://bugs.webkit.org/show_bug.cgi?id=59426
8659 Fix include ordering.
8661 * WebView/WebDeviceOrientationProviderMock.mm:
8663 2011-04-25 Adam Barth <abarth@webkit.org>
8665 Reviewed by David Levin.
8667 WebKit1 should build cleanly with strict OwnPtrs
8668 https://bugs.webkit.org/show_bug.cgi?id=59424
8670 * History/WebHistoryItem.mm:
8671 (-[WebHistoryItem initFromDictionaryRepresentation:]):
8672 * Plugins/WebNetscapePluginEventHandler.h:
8673 * Plugins/WebNetscapePluginEventHandler.mm:
8674 (WebNetscapePluginEventHandler::create):
8675 * Plugins/WebNetscapePluginView.mm:
8676 (-[WebNetscapePluginView createPlugin]):
8677 * WebView/WebDeviceOrientationProviderMock.mm:
8678 * WebView/WebTextIterator.mm:
8679 (-[WebTextIterator initWithRange:]):
8681 2011-04-25 Jon Lee <jonlee@apple.com>
8683 Reviewed by Maciej Stachowiak.
8685 Overlay scroller hard to see on pages with dark background (59183)
8686 https://bugs.webkit.org/show_bug.cgi?id=59183
8687 <rdar://problem/8975367>
8689 * WebCoreSupport/WebSystemInterface.mm:
8690 (InitWebCoreSystemInterface): adding method to allow changing style
8692 2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
8694 Unreviewed, rolling out r84740.
8695 http://trac.webkit.org/changeset/84740
8696 https://bugs.webkit.org/show_bug.cgi?id=59290
8698 change breaks apple internal builds and is incorrect
8699 (Requested by smfr on #webkit).
8701 * WebCoreSupport/WebSystemInterface.mm:
8702 (InitWebCoreSystemInterface):
8704 2011-04-22 Jon Lee <jonlee@apple.com>
8706 Reviewed by Beth Dakin.
8708 Overlay scroller hard to see on pages with dark background (59183)
8709 https://bugs.webkit.org/show_bug.cgi?id=59183
8710 <rdar://problem/8975367>
8712 * WebCoreSupport/WebSystemInterface.mm:
8713 (InitWebCoreSystemInterface): adding method to allow changing style
8715 2011-04-19 Jer Noble <jer.noble@apple.com>
8717 Reviewed by Daniel Bates.
8719 Full Screen from within an <iframe> does not cause <iframe> to resize.
8720 https://bugs.webkit.org/show_bug.cgi?id=58638
8722 Tests: fullscreen/full-screen-frameset-allowed.html
8723 fullscreen/full-screen-frameset-not-allowed.html
8725 Return the _element's document instead of the WKView's document, which
8726 will be different in the case of elements within <iframe>s.
8728 * WebView/WebFullScreenController.mm:
8729 (-[WebFullScreenController _document]):
8731 2011-04-22 Jer Noble <jer.noble@apple.com>
8733 Reviewed by Maciej Stachowiak.
8735 Disable MediaPlayerPrivateAVFoundation when using old full screen mode.
8736 https://bugs.webkit.org/show_bug.cgi?id=59147
8738 Add a new user default preference, and plumb that preference down to WebCore
8739 Settings. Allow the fullScreenEnabled preference to override the new
8740 isAVFoundationEnabled preference, so that clients of the legacy full screen
8741 mode will continue to use that mode normally.
8743 * WebView/WebPreferenceKeysPrivate.h: Add new preference key.
8744 * WebView/WebPreferences.mm:
8745 (+[WebPreferences initialize]): Set the default value of new
8747 (-[WebPreferences setAVFoundationEnabled:]): Added.
8748 (-[WebPreferences isAVFoundationEnabled]): Added.
8749 * WebView/WebPreferencesPrivate.h:
8750 * WebView/WebView.mm:
8751 (-[WebView _preferencesChanged:]): Update the WebCore settings with the
8752 new values from WebPreferences.
8754 2011-04-22 Sam Weinig <sam@webkit.org>
8756 Reviewed by Gavin Barraclough.
8758 Remove remaining uses of deprecated version of toJS
8759 https://bugs.webkit.org/show_bug.cgi?id=59170
8761 * DOM/WebDOMOperations.mm:
8762 (-[DOMElement _shadowRoot:]):
8763 (-[DOMElement _ensureShadowRoot:]):
8764 Replace use of deprecated toJS overload with explicit call to deprecatedGlobalObjectForPrototype.
8766 2011-04-21 Maciej Stachowiak <mjs@apple.com>
8768 Reviewed by Adam Roben.
8770 Add a feature define to allow <details> and <summary> to be disabled
8771 https://bugs.webkit.org/show_bug.cgi?id=59118
8772 <rdar://problem/9257045>
8774 * Configurations/FeatureDefines.xcconfig:
8776 2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
8778 Reviewed by Sam Weinig.
8780 Add Frame* to the argument lists of canCopyCut and canPaste
8781 https://bugs.webkit.org/show_bug.cgi?id=59153
8783 * WebCoreSupport/WebEditorClient.h:
8784 * WebCoreSupport/WebEditorClient.mm:
8785 (WebEditorClient::canCopyCut):
8786 (WebEditorClient::canPaste):
8788 2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
8790 Unreviewed, rolling out r82052.
8791 http://trac.webkit.org/changeset/82052
8792 https://bugs.webkit.org/show_bug.cgi?id=59135
8794 New full screen api should be opt-in, not opt-out. (Requested
8795 by jernoble on #webkit).
8797 * WebView/WebPreferences.mm:
8798 (+[WebPreferences initialize]):
8800 2011-04-21 Beth Dakin <bdakin@apple.com>
8802 Reviewed by Dan Bernstein.
8804 https://bugs.webkit.org/show_bug.cgi?id=59048
8805 Need to track whether overlay scrollbar is currently visible and in lower-
8808 <rdar://problem/9211232>
8810 A new WebSystemInterface is needed for this.
8811 * WebCoreSupport/WebSystemInterface.mm:
8812 (InitWebCoreSystemInterface):
8814 2011-04-21 Dirk Schulze <krit@webkit.org>
8816 Reviewed by Nikolas Zimmermann.
8818 SVG feDropShadow implementation of SVG Filters 1.2
8819 https://bugs.webkit.org/show_bug.cgi?id=52513
8821 * MigrateHeaders.make:
8823 2011-04-20 Dominic Cooney <dominicc@chromium.org>
8825 Reviewed by Dimitri Glazkov.
8827 layoutTestController can create and destroy shadow DOM
8828 https://bugs.webkit.org/show_bug.cgi?id=59058
8830 Support for new methods in Mac DRT.
8832 * DOM/WebDOMOperations.mm:
8833 (-[DOMElement _ensureShadowRoot:]):
8834 (-[DOMElement _removeShadowRoot]):
8835 * DOM/WebDOMOperationsPrivate.h:
8837 2011-04-20 Eric Carlson <eric.carlson@apple.com>
8839 Reviewed by Dan Bernstein.
8841 Adopt QTKit API for listing and deleting file in its media cache.
8842 <rdar://problem/9130029>
8844 * WebCoreSupport/WebSystemInterface.mm:
8845 (InitWebCoreSystemInterface): Initialize new functions.
8847 2011-04-19 Matthew Delaney <mdelaney@apple.com>
8849 Reviewed by Simon Fraser.
8851 WebPreferences in WebKit1 should have CanvasUsesAcceleratedDrawing set to NO by default
8852 https://bugs.webkit.org/show_bug.cgi?id=58936
8854 * WebView/WebPreferences.mm:
8855 (+[WebPreferences initialize]):
8857 2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
8859 Reviewed by Pavel Feldman.
8861 Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
8862 https://bugs.webkit.org/show_bug.cgi?id=58883
8864 * WebCoreSupport/WebFrameLoaderClient.h:
8865 * WebCoreSupport/WebFrameLoaderClient.mm:
8866 (WebFrameLoaderClient::dispatchDidReceiveContentLength):
8868 2011-04-18 Jia Pu <jpu@apple.com>
8870 Reviewed by Mark Rowe.
8872 WebKit needs to stop importing <AppKit/NSTextChecker.h>
8873 https://bugs.webkit.org/show_bug.cgi?id=58798
8874 <rdar://problem/9294938>
8876 Use public header <AppKit/NSSpellChecker.h> instead.
8878 * WebCoreSupport/CorrectionPanel.h:
8879 * WebCoreSupport/CorrectionPanel.mm:
8880 (correctionIndicatorType):
8881 (CorrectionPanel::show):
8882 (CorrectionPanel::dismissInternal):
8883 (CorrectionPanel::handleAcceptedReplacement):
8884 * WebCoreSupport/WebEditorClient.mm:
8885 * WebView/WebView.mm:
8887 2011-04-17 Cameron Zwarich <zwarich@apple.com>
8889 Reviewed by Timothy Hatcher.
8891 Stop using -[NSString initWithContentsOfFile:]
8892 https://bugs.webkit.org/show_bug.cgi?id=58763
8894 -[NSString initWithContentsOfFile:] was deprecated in 10.4, so we should stop using it.
8896 * WebView/WebView.mm:
8897 (leakMailQuirksUserScriptContents):
8898 (leakOutlookQuirksUserScriptContents):
8900 2011-04-17 David Kilzer <ddkilzer@apple.com>
8902 <http://webkit.org/b/58463> Switch HTTP pipelining from user default to private setting
8903 <rdar://problem/9268729>
8905 Reviewed by Dan Bernstein.
8907 This replaces support for the WebKitEnableHTTPPipelining user
8908 default with methods on the WebCore::ResourceRequest class in
8909 WebCore, the WebView class in WebKit1, and the WebContext class
8910 in WebKit2. It also removes support for the
8911 WebKitForceHTTPPipeliningPriorityHigh user default which was not
8914 * WebView/WebView.mm:
8915 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added.
8916 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added.
8917 * WebView/WebViewPrivate.h:
8918 (+[WebView(WebPrivate) _HTTPPipeliningEnabled]): Added declaration.
8919 (+[WebView(WebPrivate) _setHTTPPipeliningEnabled:]): Added declaration.
8921 2011-04-17 Joseph Pecoraro <joepeck@webkit.org>
8923 Reviewed by Dan Bernstein.
8925 Assign to self in WebInspectorWindowController constructors
8926 https://bugs.webkit.org/show_bug.cgi?id=58749
8928 * WebCoreSupport/WebInspectorClient.mm:
8929 (-[WebInspectorWindowController init]):
8930 (-[WebInspectorWindowController initWithInspectedWebView:]):
8932 2011-04-17 Joseph Pecoraro <joepeck@webkit.org>
8934 Reviewed by Timothy Hatcher.
8936 Move WebNodeHighlighter into its own file
8937 https://bugs.webkit.org/show_bug.cgi?id=58746
8939 Extract this class into its own file alongside the
8940 other WebNodeHighlight files. In doing so do some
8941 cleanup on WebInspectorClient removing some methods
8942 that were never called.
8944 * WebCoreSupport/WebInspectorClient.mm:
8945 (WebInspectorClient::WebInspectorClient): style fix.
8946 * WebInspector/WebNodeHighlighter.h: Added.
8947 * WebInspector/WebNodeHighlighter.mm: Added.
8948 (-[WebNodeHighlighter initWithInspectedWebView:]): call super init.
8949 (-[WebNodeHighlighter dealloc]):
8950 (-[WebNodeHighlighter highlightNode:]):
8951 (-[WebNodeHighlighter hideHighlight]):
8952 (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
8953 (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
8955 2011-04-15 Jia Pu <jpu@apple.com>
8957 Reviewed by Dan Bernstein.
8959 [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
8960 https://bugs.webkit.org/show_bug.cgi?id=58717
8962 Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
8964 * WebCoreSupport/CorrectionPanel.mm:
8965 (CorrectionPanel::show):
8967 2011-04-15 Shishir Agrawal <shishir@chromium.org>
8969 Reviewed by James Robinson.
8971 Add a flag to guard Page Visibility API changes.
8972 https://bugs.webkit.org/show_bug.cgi?id=58464
8974 * Configurations/FeatureDefines.xcconfig:
8976 2011-04-15 Oliver Hunt <oliver@apple.com>
8978 GC allocate Structure
8979 https://bugs.webkit.org/show_bug.cgi?id=58483
8981 Rolling r83894 r83827 r83810 r83809 r83808 back in with
8982 a workaround for the gcc bug seen by the gtk bots
8984 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
8985 * Plugins/Hosted/ProxyInstance.mm:
8986 (WebKit::ProxyRuntimeMethod::createStructure):
8987 * Plugins/Hosted/ProxyRuntimeObject.h:
8988 (WebKit::ProxyRuntimeObject::createStructure):
8990 2011-04-14 Alexey Proskuryakov <ap@apple.com>
8992 Reviewed by Dan Bernstein.
8994 WebKit2: Password field input does not switch to ASCII-compatible source
8995 https://bugs.webkit.org/show_bug.cgi?id=58583
8996 <rdar://problem/9059651>
8998 Now that WebCore doesn't set secure input mode, WebKit has to. Happily, it already has the
8999 necessary logic, needed to return a nil text input context when in password fields.
9001 * WebView/WebHTMLView.mm:
9002 (-[WebHTMLView close]): If the view is still enforcing secure event mode, stop.
9003 (-[WebHTMLView windowDidBecomeKey:]): Call _updateSecureInputState.
9004 (-[WebHTMLView windowDidResignKey:]): Ditto.
9005 (-[WebHTMLView becomeFirstResponder]): Call _updateSecureInputState. It's a bit tricky
9006 because the first responder is still different an this point, so set a boolean variable to
9007 let _updateSecureInputState know what's going on.
9008 (-[WebHTMLView resignFirstResponder]): Disable secure event mode if it's on.
9009 (-[WebHTMLView _updateSecureInputState]): Update HIToolbox secure event input state and
9010 allowed input sources accorsing to current selection.
9011 (-[WebHTMLView _updateSelectionForInputManager]): Call _updateSecureInputState.
9013 2011-04-15 Sam Weinig <sam@webkit.org>
9015 Reviewed by Maciej Stachowiak.
9017 Make mac WebKit1 use the default localization strategy
9018 https://bugs.webkit.org/show_bug.cgi?id=58628
9020 * WebCoreSupport/WebPlatformStrategies.h:
9021 * WebCoreSupport/WebPlatformStrategies.mm:
9022 Remove the localization strategy code. The equivalent is now
9023 in WebCore/platform/DefaultLocalizationStrategy.cpp.
9025 2011-04-15 Anna Cavender <annacc@chromium.org>
9027 Reviewed by Eric Carlson.
9029 Renaming TRACK feature define to VIDEO_TRACK
9030 https://bugs.webkit.org/show_bug.cgi?id=53556
9032 * Configurations/FeatureDefines.xcconfig:
9034 2011-04-14 Pratik Solanki <psolanki@apple.com>
9036 Reviewed by David Kilzer.
9038 Set minimum priority for fast lane connections
9039 https://bugs.webkit.org/show_bug.cgi?id=58353
9041 * WebCoreSupport/WebSystemInterface.mm:
9042 (InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
9044 2011-04-13 Sam Weinig <sam@webkit.org>
9046 Reviewed by Gavin Barraclough.
9048 WebKit2 doesn't keep overlay scrollers shown while scroll gesture held
9049 <rdar://problem/9260518>
9051 * WebCoreSupport/WebSystemInterface.mm:
9052 (InitWebCoreSystemInterface):
9053 Initialize new WKSI functions.
9055 2011-04-13 David Kilzer <ddkilzer@apple.com>
9057 <http://webkit.org/b/58172> Fix -Wcast-align warning in WebBasePluginPackage.mm
9059 Reviewed by Anders Carlsson.
9061 Fixes the following warning with -Wcast-align enabled:
9063 Source/WebKit/mac/Plugins/WebBasePluginPackage.mm:402:21:{402:21-402:93}{402:39-402:93}: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct fat_arch *' increases required alignment from 1 to 4 [-Werror,-Wcast-align,3]
9064 archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));
9065 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
9067 * Plugins/WebBasePluginPackage.mm:
9068 (-[WebBasePluginPackage isNativeLibraryData:]): Added
9069 COMPILE_ASSERT() to make sure our pointer math is valid.
9070 Removed cast to (uint8_t*) and divide sizeof(struct fat_header)
9071 by sizeof(uint32_t) to fix the pointer math. Replaced C-style
9072 casts with reinterpret_cast.
9074 2011-04-12 Enrica Casucci <enrica@apple.com>
9076 Reviewed by Alexey Proskuryakov.
9078 Infinite recursion in WebHTMLView executeSavedKeypressCommands.
9079 https://bugs.webkit.org/show_bug.cgi?id=58382
9080 <rdar://problem/9239370>
9082 Execution of some editing commands could trigger a call to selectedRange that
9083 internally calls executeSavedKeypressCommands creating an infinite recursion.
9085 * WebView/WebHTMLView.mm:
9086 (-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
9087 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
9089 2011-04-12 Alice Liu <alice.liu@apple.com>
9091 Reviewed by Sam Weinig.
9093 https://bugs.webkit.org/show_bug.cgi?id=58292
9094 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
9096 * WebView/WebPreferenceKeysPrivate.h: Add preference key.
9097 * WebView/WebPreferences.mm:
9098 (+[WebPreferences initialize]): Initialize to false.
9099 (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
9100 (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
9101 * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
9102 * WebView/WebView.mm:
9103 (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes.
9105 2011-04-11 Alexey Proskuryakov <ap@apple.com>
9107 Reviewed by Maciej Stachowiak.
9109 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
9110 https://bugs.webkit.org/show_bug.cgi?id=58175
9111 <rdar://problem/9060555>
9113 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
9114 should be changed to match WebKit2.
9116 2011-04-06 Timothy Hatcher <timothy@apple.com>
9118 Fix a bug where the context menu does not show in PDF documents if there is no
9119 UI delegate or the UI delegate does not respond to the context menu selector.
9121 https://webkit.org/b/57958
9123 Reviewed by Darin Adler.
9125 * WebView/WebView.mm:
9126 (-[WebView _menuForElement:defaultItems:]): CallUIDelegate returns nil
9127 if UIDelegate is nil or doesn't respond to the selector. So check that
9128 here to distinguish between using defaultMenuItems or the delegate
9129 really returning nil to say "no context menu".
9131 2011-04-11 Jer Noble <jer.noble@apple.com>
9133 Unreviewed; roll out unintentional change to WebFullScreenController.mm.
9135 * WebView/WebFullScreenController.mm:
9136 (-[WebFullScreenController enterFullscreen:]):
9138 2011-04-08 Geoffrey Garen <ggaren@apple.com>
9140 Reviewed by Oliver Hunt.
9142 A few heap-related renames and file moves.
9144 WeakGCPtr<T> => Weak<T>
9145 Global<T> => Strong<T>
9147 collector/* => heap/*
9148 runtime/WeakGCPtr.h => heap/Weak.h
9150 (Eventually, even more files should move into the heap directory. Like
9151 Heap.h and Heap.cpp, for example.)
9153 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
9154 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
9155 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
9156 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
9157 (WebKit::NetscapePluginInstanceProxy::evaluate):
9158 * WebView/WebScriptDebugger.h:
9160 2011-04-08 Alexey Proskuryakov <ap@apple.com>
9162 Reviewed by Darin Adler.
9164 WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts
9165 https://bugs.webkit.org/show_bug.cgi?id=58175
9166 <rdar://problem/9060555>
9168 * WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a comment explaining how this
9169 should be changed to match WebKit2.
9171 2011-04-08 Alpha Lam <hclam@chromium.org>
9173 Unreviewed, rolling out r83335.
9174 http://trac.webkit.org/changeset/83335
9175 https://bugs.webkit.org/show_bug.cgi?id=53556
9177 GTK and QT bots are broken
9179 * Configurations/FeatureDefines.xcconfig:
9181 2011-04-07 Anna Cavender <annacc@chromium.org>
9183 Reviewed by Eric Carlson.
9185 Setup ENABLE(TRACK) feature define
9186 https://bugs.webkit.org/show_bug.cgi?id=53556
9188 * Configurations/FeatureDefines.xcconfig:
9190 2011-04-08 Maciej Stachowiak <mjs@apple.com>
9192 Reviewed by Darin Adler.
9194 -[WebView setPreferences:] can take a lot of time if loading lots of webviews at once
9195 https://bugs.webkit.org/show_bug.cgi?id=58128
9196 <rdar://problem/9244553>
9198 The root of the problem here was an O(N^2) issue - each WebView,
9199 upon having its preferences initialized, would broadcast a
9200 notification that was listened to by all other WebViews sharing
9203 To maintain the API contract, I split the notification into two,
9204 one that is for public API consumption, and the other which is for
9205 internal use only. Changes that don't need to be picked up by
9206 other WebViews broadcast the public notification only. And we
9207 avoid WebView broadcasting a notification just to get itself to
9210 * Misc/WebIconDatabase.mm:
9211 (-[WebIconDatabase _startUpIconDatabase]):
9212 (-[WebIconDatabase _shutDownIconDatabase]):
9213 * Plugins/WebBaseNetscapePluginView.mm:
9214 (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
9215 (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
9216 (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
9217 (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]):
9218 * WebView/WebPreferences.mm:
9219 (-[WebPreferences initWithIdentifier:]):
9220 (-[WebPreferences _setStringValue:forKey:]):
9221 (-[WebPreferences _setIntegerValue:forKey:]):
9222 (-[WebPreferences _setFloatValue:forKey:]):
9223 (-[WebPreferences _setBoolValue:forKey:]):
9224 (-[WebPreferences _setLongLongValue:forKey:]):
9225 (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
9226 (-[WebPreferences _postPreferencesChangedNotification]):
9227 (-[WebPreferences _postPreferencesChangedAPINotification]):
9228 * WebView/WebPreferencesPrivate.h:
9229 * WebView/WebView.mm:
9230 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
9231 (-[WebView _preferencesChangedNotification:]):
9232 (-[WebView _preferencesChanged:]):
9233 (-[WebView setUsesPageCache:]):
9234 (+[WebView initialize]):
9235 (-[WebView setPreferences:]):
9236 (-[WebView _keyboardUIMode]):
9237 * WebView/WebViewInternal.h:
9239 2011-04-07 Andrew Scherkus <scherkus@chromium.org>
9241 Revert ENABLE_TRACK patch due to compile failures.
9243 * Configurations/FeatureDefines.xcconfig:
9245 2011-04-07 Alexey Proskuryakov <ap@apple.com>
9247 Reviewed by Anders Carlsson.
9249 REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
9250 https://bugs.webkit.org/show_bug.cgi?id=58066
9251 <rdar://problem/8965302>
9253 * WebView/WebHTMLRepresentation.mm:
9254 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
9255 * WebView/WebHTMLView.mm:
9256 (-[WebHTMLView attributedSubstringFromRange:]):
9257 (-[WebHTMLView attributedString]):
9258 (-[WebHTMLView selectedAttributedString]):
9259 Updated for editingAttributedStringFromRange: now taking a WebCore::Range instead of DOMRange.
9261 2011-04-07 Andy Estes <aestes@apple.com>
9263 Reviewed by Darin Adler.
9265 REGRESSION (r64712): Microsoft Outlook 2011: original message contents
9266 not included when replying to an email.
9267 https://bugs.webkit.org/show_bug.cgi?id=57794
9269 Outlook populates a reply message by creating an empty WebView and
9270 using DOM API to populate the WebView's empty document with content
9271 from the original message. It expects the initial empty document to
9272 simply be "<html></html>", and it proceeds to dynamically create and
9273 append a BODY node and add the original message content as a child of
9274 that node. Outlook then takes the innerHTML of the frame's first body
9275 element and copies it into a *new* document that is displayed and
9276 edited in the reply message window.
9278 Due to implementing the HTML5 tree building algorithm in r64712,
9279 initial empty documents went from being "<html></html>" to being
9280 "<html><head></head><body></body></html>". Outlook still dynamically
9281 creates a BODY node to parent the original message content, but this
9282 BODY node duplicates the one created by the tree builder. When Outlook
9283 then takes the innerHTML of the first body element to populate the
9284 reply message window it gets the empty body element created by the
9285 parser, not the one it created with the original message content.
9287 Fix this by injecting a user script into the initial empty document
9288 that removes the HEAD and BODY nodes created by the parser. This
9289 ensures that the BODY created by Outlook is the only BODY in the
9292 * Misc/OutlookQuirksUserScript.js: Added.
9293 * WebView/WebView.mm:
9294 (leakMailQuirksUserScriptContents):
9295 (-[WebView _injectMailQuirksScript]):
9296 (needsOutlookQuirksScript):
9297 (leakOutlookQuirksUserScriptContents):
9298 (-[WebView _injectOutlookQuirksScript]):
9299 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
9301 2011-04-06 Dai Mikurube <dmikurube@chromium.org>
9303 Reviewed by David Levin.
9305 Add QUOTA build flag for unified quota API
9306 https://bugs.webkit.org/show_bug.cgi?id=57918
9308 * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
9310 2011-04-06 Robert Sesek <rsesek@chromium.org>
9312 Reviewed by Alexey Proskuryakov.
9314 Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
9315 https://bugs.webkit.org/show_bug.cgi?id=54969
9317 * WebView/WebFrame.mm:
9318 (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
9319 (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
9321 2011-04-05 Alexey Proskuryakov <ap@apple.com>
9323 Reviewed by Darin Adler.
9325 Move attributedStringFromRange down to WebCore
9326 https://bugs.webkit.org/show_bug.cgi?id=57905
9328 * Misc/WebNSAttributedStringExtras.h: Removed.
9329 * Misc/WebNSAttributedStringExtras.mm: Removed.
9330 * WebView/WebHTMLRepresentation.mm:
9331 (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
9332 * WebView/WebHTMLView.mm:
9333 (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
9334 (-[WebHTMLView attributedSubstringFromRange:]):
9335 (-[WebHTMLView attributedString]):
9336 (-[WebHTMLView selectedAttributedString]):
9337 * WebView/WebPDFView.mm:
9338 (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
9340 2011-04-04 MORITA Hajime <morrita@google.com>
9342 Reviewed by Ryosuke Niwa.
9344 [Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
9345 https://bugs.webkit.org/show_bug.cgi?id=56085
9347 Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
9348 NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
9349 for requestCheckingOfString method.
9351 * WebCoreSupport/WebEditorClient.h:
9352 * WebCoreSupport/WebEditorClient.mm:
9353 (toCoreTextCheckingResults):
9354 (WebEditorClient::checkTextOfParagraph):
9355 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
9356 (-[WebEditorSpellCheckResponder perform]):
9357 (WebEditorClient::requestCheckingOfString):
9358 * WebView/WebFrame.mm:
9359 (-[WebFrame markersForSelectionStartAsText]):
9360 * WebView/WebFramePrivate.h:
9362 2011-04-05 Anders Carlsson <andersca@apple.com>
9364 Didn't mean to land this.
9366 * Plugins/WebNetscapePluginView.mm:
9367 (-[WebNetscapePluginView getVariable:value:]):
9369 2011-04-04 David Kilzer <ddkilzer@apple.com>
9371 <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
9373 Reviewed by Alexey Proskuryakov.
9375 * WebCoreSupport/WebSystemInterface.mm:
9376 (InitWebCoreSystemInterface): Added initialization for
9377 wkSetHTTPPipeliningMaximumPriority().
9379 2011-04-04 Alexey Proskuryakov <ap@apple.com>
9381 Reviewed by Dan Bernstein.
9383 REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
9384 https://bugs.webkit.org/show_bug.cgi?id=51230
9385 <rdar://problem/8780989>
9387 * WebView/WebHTMLView.mm: (-[WebHTMLView flagsChanged:]): Moved Caps Lock handling from
9388 WebKits to WebCore, because WebKit shouldn't be smart.
9390 2011-04-01 Alexey Proskuryakov <ap@apple.com>
9392 Reviewed by Darin Adler.
9394 REGRESSION: Assertion failure when executing a complex custom key binding
9395 https://bugs.webkit.org/show_bug.cgi?id=57681
9397 * WebView/WebHTMLView.mm: (-[WebHTMLView hasMarkedText]): There is no need to execute saved
9398 commands when they can't possibly change the result.
9400 2011-04-01 Anders Carlsson <andersca@apple.com>
9402 Reviewed by Sam Weinig.
9404 Shockwave plug-in doesn't accept mouse events
9405 https://bugs.webkit.org/show_bug.cgi?id=57653
9406 <rdar://problem/8483273>
9408 Fix an unrelated bug found by the added test.
9410 * Plugins/WebBaseNetscapePluginView.mm:
9411 (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
9412 Make sure to always set destX and destY.
9414 2011-04-01 Alexey Proskuryakov <ap@apple.com>
9416 Reviewed by Darin Adler.
9418 Make WebKit2 text input handling more like WebKit1
9419 https://bugs.webkit.org/show_bug.cgi?id=57649
9421 * WebView/WebFrameInternal.h: Expose _convertToDOMRange for use in WebHTMLView.
9422 * WebView/WebHTMLView.mm:
9423 (-[WebHTMLView _executeSavedKeypressCommands]): Renamed, since these are not editor commands.
9424 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for the renamed _executeSavedKeypressCommands.
9425 (-[WebHTMLView characterIndexForPoint:]): Ditto.
9426 (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
9427 (-[WebHTMLView selectedRange]): Ditto.
9428 (-[WebHTMLView markedRange]): Ditto.
9429 (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
9430 (-[WebHTMLView hasMarkedText]): Ditto.
9431 (-[WebHTMLView unmarkText]): Ditto.
9432 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto. Changed the comment about the argument
9433 type into an assertion. Removed resetting interpretKeyEventsParameters to 0, as we shouldn't
9434 be able to call text input protocol methods from here (and we didn't even reset it back on
9435 return). Changed to retrieve all data before starting to apply actions to better match WK2 code.
9436 (-[WebHTMLView insertText:]): Ditto.
9438 2011-04-01 Timothy Hatcher <timothy@apple.com>
9440 Make momentum scroll event latching work in WebKit2 on Mac.
9442 <rdar://problem/8751861>
9444 Reviewed by Darin Adler.
9446 * WebCoreSupport/WebSystemInterface.mm:
9447 (InitWebCoreSystemInterface): Remove IsLatchingWheelEvent, add GetNSEventMomentumPhase.
9448 * WebView/WebDynamicScrollBarsView.mm:
9449 (-[WebDynamicScrollBarsView scrollWheel:]): Use WKGetNSEventMomentumPhase to set isLatchingEvent.
9451 2011-03-31 Darin Adler <darin@apple.com>
9453 Reviewed by Anders Carlsson.
9455 Assertion failure in -[WebHTMLView _handleStyleKeyEquivalent:]
9456 https://bugs.webkit.org/show_bug.cgi?id=26667
9458 * WebView/WebHTMLView.mm:
9459 (-[WebHTMLView _handleStyleKeyEquivalent:]): Handle the case where WebView is
9460 nil rather than asserting that it is non-nil. One case where WebView will be nil
9461 is when the frame is closed, but in any case where it is nil, the correct thing
9462 to do is to not try to handle the style key.
9464 2011-03-31 Alexey Proskuryakov <ap@apple.com>
9466 Patch by John Harvey, reviewed and tweaked by me.
9468 <rdar://problem/8644403> Should notify TSM that plug-ins would show a bottom input window for marked text.
9470 * Plugins/Hosted/WebTextInputWindowController.m:
9471 (-[WebTextInputPanel _interpretKeyEvent:string:]):
9473 2011-03-31 Evan Martin <evan@chromium.org>
9475 Reviewed by Eric Seidel.
9477 <title> should support dir attribute
9478 https://bugs.webkit.org/show_bug.cgi?id=50961
9480 Update to new FrameLoaderClient interface.
9482 * WebCoreSupport/WebFrameLoaderClient.h:
9483 * WebCoreSupport/WebFrameLoaderClient.mm:
9484 (WebFrameLoaderClient::dispatchDidReceiveTitle):
9485 (WebFrameLoaderClient::setTitle):
9487 2011-03-30 Dominic Cooney <dominicc@google.com>
9489 Reviewed by Dimitri Glazkov.
9491 Adds layoutTestController.shadowRoot accessor to Mac DRT.
9492 https://bugs.webkit.org/show_bug.cgi?id=57415
9494 * DOM/WebDOMOperations.mm:
9495 (-[DOMElement _shadowRoot:]):
9496 * DOM/WebDOMOperationsPrivate.h:
9498 2011-03-30 Alexey Proskuryakov <ap@apple.com>
9500 Reviewed by Darin Adler.
9502 WebHTMLView shouldn't resend noop: commands
9503 https://bugs.webkit.org/show_bug.cgi?id=57504
9504 <rdar://problem/9209390>
9506 * WebView/WebHTMLView.mm: (-[WebHTMLView _executeSavedEditingCommands]): Filter out NOOPs,
9507 which we get e.g. when handling Cmd-key combos.
9509 2011-03-30 Alexey Proskuryakov <ap@apple.com>
9511 Reviewed by Darin Adler.
9513 REGRESSION (r82320): Spacebar no longer pages down
9514 https://bugs.webkit.org/show_bug.cgi?id=57423
9515 <rdar://problem/9207702>
9517 Also includes some unrelated cleanup that I had in my tree.
9519 * WebView/WebHTMLView.mm:
9520 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
9521 being dispatched to the right frame.
9522 (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
9523 (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
9524 Even if this specific command hasn't been handled, that doesn't nullify side effects from
9526 (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
9527 bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
9528 another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
9529 going to look at it.
9531 2011-03-30 Sam Weinig <sam@webkit.org>
9533 Reviewed by Brady Eidson.
9535 WebKit2: Attempting to view css file from url causes it to download
9536 <rdar://problem/9102611>
9537 https://bugs.webkit.org/show_bug.cgi?id=57501
9539 * WebView/WebHTMLRepresentation.h:
9540 * WebView/WebHTMLRepresentation.mm:
9541 (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
9542 * WebView/WebHTMLView.mm:
9543 (+[WebHTMLView unsupportedTextMIMETypes]):
9544 Re-factor unsupportedTextMIMETypes to pull from WebCore's
9545 MIMETypeRegistry, so that the list can be shared with WebKit2.
9547 2011-03-29 Beth Dakin <bdakin@apple.com>
9549 Reviewed by Maciej Stachowiak.
9551 Fix for https://bugs.webkit.org/show_bug.cgi?id=57408
9552 webkit-min-device-pixel-ratio media query doesn't work post-SnowLeopard
9554 <rdar://problem/8665411>
9556 * Misc/WebNSControlExtras.m:
9557 (-[NSControl sizeToFitAndAdjustWindowHeight]):
9558 * WebCoreSupport/WebChromeClient.mm:
9559 (WebChromeClient::scaleFactor):
9560 * WebView/WebHTMLView.mm:
9561 (-[WebHTMLView viewDidMoveToWindow]):
9562 (-[WebHTMLView attachRootLayer:]):
9564 2011-03-29 Kent Tamura <tkent@chromium.org>
9566 Reviewed by Dimitri Glazkov.
9568 Make validation message bubble testable
9569 https://bugs.webkit.org/show_bug.cgi?id=57290
9571 * WebView/WebView.mm:
9572 (-[WebView _preferencesChangedNotification:]): Copy the private value of
9573 the timer magnification to WebCore::Settings.
9574 (-[WebView validationMessageTimerMagnification]): Added.
9575 (-[WebView setValidationMessageTimerMagnification:]): Added.
9576 * WebView/WebViewData.h: Declare a member for the timer magnification.
9577 * WebView/WebViewData.mm:
9578 (-[WebViewPrivate init]): Initialize the timer magnification.
9579 * WebView/WebViewPrivate.h:
9580 Declare a setter and a getter for the timer magnification.
9582 2011-03-29 Kent Tamura <tkent@chromium.org>
9584 Reviewed by Dimitri Glazkov.
9586 [Mac] Enable interactive-validation tests on Mac DRT
9587 https://bugs.webkit.org/show_bug.cgi?id=57308
9589 * WebView/WebView.mm:
9590 (-[WebView _preferencesChangedNotification:]):
9591 Convey a WebView flag for interactive validation to WebCore::Settings.
9592 (-[WebView interactiveFormValidationEnabled]): Added.
9593 (-[WebView setInteractiveFormValidationEnabled:]): Added.
9594 * WebView/WebViewData.h: Add interactiveFormValidationEnabled.
9595 * WebView/WebViewData.mm:
9596 (-[WebViewPrivate init]): Initialize interactiveFormValidationEnabled.
9597 * WebView/WebViewPrivate.h: Add setter and getter for interactiveFormValidationEnabled.
9599 2011-03-29 Timothy Hatcher <timothy@apple.com>
9601 Update the order of the context menu to better match AppKit on Mac.
9603 <rdar://problem/9054893>
9605 Reviewed by John Sullivan.
9607 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
9608 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Update the order of items.
9609 * WebCoreSupport/WebPlatformStrategies.h:
9610 * WebCoreSupport/WebPlatformStrategies.mm:
9611 (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): Added argument for selected string.
9613 2011-03-29 Alexey Proskuryakov <ap@apple.com>
9615 Reviewed by Darin Adler.
9617 https://bugs.webkit.org/show_bug.cgi?id=57379
9618 Clean up WK1 key event handling logic
9620 No bugs knowingly fixed, but this makes the code more consistent.
9622 * WebView/WebHTMLView.mm:
9623 (struct WebHTMLViewInterpretKeyEventsParameters): Renamed eventWasHandled to
9624 eventInterpretationHadSideEffects, because "handled" doesn't really mean much.
9625 (-[WebHTMLView _executeSavedEditingCommands]): Factored out from _interpretKeyEvent for use
9626 from other functions. We need to execute saved commands when an input method asks for current
9627 state, because providing stale state could confuse it.
9628 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Heavily commented, and updated for other
9630 (-[WebHTMLView characterIndexForPoint:]): Call _executeSavedEditingCommands, because otherwise,
9631 the answer would be stale.
9632 (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
9633 (-[WebHTMLView selectedRange]): Ditto.
9634 (-[WebHTMLView markedRange]): Ditto.
9635 (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
9636 (-[WebHTMLView hasMarkedText]): Ditto.
9637 (-[WebHTMLView unmarkText]): Call _executeSavedEditingCommands, because otherwise, we'd be
9638 operating on stale data. Also, updated for eventWasHandled renaming.
9639 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
9640 (-[WebHTMLView doCommandBySelector:]): Removed special handling for noop:. I verified that
9641 it's no longer needed for bug 14522, presumably due to WebCore level changes. It was also
9642 fragile, because there is no guarantee about when noop: is sent (also, a custom key binding
9643 could have a noop: as one of its commands, although that's hardly practical).
9644 Added the same "from input method" logic that we have in insertText: - I don't know of any
9645 IMs that call this method, but we clearly need to execute it as part of IM processing when
9646 there is marked text.
9647 (-[WebHTMLView insertText:]): Removed a confusing check for [text length]. Always set
9648 eventInterpretationHadSideEffects to true, becasue there is no reason to try multiple times
9649 if current selection isn't editable. This is different from doCommandBySelector:, where we
9650 need to give super class a chance to handle the event if our processing fails.
9651 Removed a nonsense "consumedByIM = true" assignment - we no longer need it now that the
9652 return value of _interpretKeyEvent is computed differently.
9654 2011-03-28 Adele Peterson <adele@apple.com>
9656 Reviewed by Eric Seidel.
9658 Fix for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
9659 https://bugs.webkit.org/show_bug.cgi?id=57173
9661 * WebView/WebFrame.mm:
9662 (-[WebFrame hasSpellingMarker:length:]): Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
9663 (-[WebFrame hasGrammarMarker:length:]): Call new selectionStartHasMarkerFor method.
9664 * WebView/WebFramePrivate.h: Add hasGrammarMarker so grammar marking can be tested.
9666 2011-03-28 Alexey Proskuryakov <ap@apple.com>
9668 Reviewed by Darin Adler.
9670 https://bugs.webkit.org/show_bug.cgi?id=57260
9671 Clean up text input code a little
9673 * WebCoreSupport/WebEditorClient.mm:
9674 (WebEditorClient::handleKeyboardEvent):
9675 (WebEditorClient::handleInputMethodKeydown):
9676 * WebView/WebHTMLViewInternal.h:
9677 Renamed _interceptEditingKeyEvent:shouldSaveCommand:, becasue it doesn't really intercept
9678 anything. It's just a version it interpretKeyEvents: that tells us whether it was handled,
9679 and also possibly saves resulting commands for later execution.
9681 * WebView/WebHTMLView.mm:
9682 (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Changed to use early return. Changed
9683 return value in case platformEvent is null to be less mysterious. Moved receivedNOOP from
9684 WebHTMLViewPrivate to WebHTMLViewInterpretKeyEventsParameters, as this is just part of event
9685 handling state, like the other booleans there. Don't call interpretKeyEvents: again simply
9686 because the first call resulted in no saved commands, becasue it's confusing and apparently
9687 useless (I couldn't find any broken behavior).
9688 (-[WebHTMLView unmarkText]): Cleaned upo BOOL vs. bool constants.
9689 (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
9690 (-[WebHTMLView doCommandBySelector:]): Ditto.
9691 (-[WebHTMLView insertText:]): Ditto.
9693 * WebView/WebViewInternal.h: There was no _interceptEditingKeyEvent:shouldSaveCommand:
9696 2011-03-27 Jer Noble <jer.noble@apple.com>
9698 Reviewed by Maciej Stachowiak.
9700 Full Screen: disable keyboard access by default
9701 https://bugs.webkit.org/show_bug.cgi?id=56684
9703 Take into account whether keyboard access was requested when deciding whether full
9704 screen mode is supported.
9706 * WebCoreSupport/WebChromeClient.h:
9707 * WebCoreSupport/WebChromeClient.mm:
9708 (WebChromeClient::supportsFullScreenForElement):
9709 * WebView/WebView.mm:
9710 (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
9711 * WebView/WebViewInternal.h:
9713 2011-03-26 Jer Noble <jer.noble@apple.com>
9715 Reviewed by Eric Carlson.
9717 Enable the Full Screen API by default in WebKit/mac and WebKit2
9718 https://bugs.webkit.org/show_bug.cgi?id=56956
9720 * WebView/WebPreferences.mm:
9721 (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
9723 2011-03-25 Andy Estes <aestes@apple.com>
9725 Reviewed by Adele Peterson.
9727 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
9728 https://bugs.webkit.org/show_bug.cgi?id=49016
9730 Update objectContentType() implementation to handle the
9731 shouldPreferPlugInsForImages flag.
9733 * WebCoreSupport/WebFrameLoaderClient.h:
9734 * WebCoreSupport/WebFrameLoaderClient.mm:
9735 (WebFrameLoaderClient::objectContentType):
9737 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
9739 Unreviewed, rolling out r81939.
9740 http://trac.webkit.org/changeset/81939
9741 https://bugs.webkit.org/show_bug.cgi?id=57084
9743 Rolling out 81939, as it's causing a number of app cache test
9744 failures. (Requested by jernoble on #webkit).
9746 * WebView/WebView.mm:
9747 (-[WebView _preferencesChangedNotification:]):
9749 2011-03-23 Jer Noble <jer.noble@apple.com>
9751 Reviewed by Maciej Stachowiak.
9753 Application Cache should save audio/ and video/ mime types as flat files
9754 https://bugs.webkit.org/show_bug.cgi?id=53784
9755 <rdar://problem/8932473>
9759 Initialize the AppCache Total size quotas with the values for WebKitPreferences
9762 * WebView/WebView.mm:
9763 (-[WebView _preferencesChangedNotification:]):
9765 2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
9767 Unreviewed, rolling out r81916 and r81917.
9768 http://trac.webkit.org/changeset/81916
9769 http://trac.webkit.org/changeset/81917
9770 https://bugs.webkit.org/show_bug.cgi?id=57071
9772 broke a test on platforms that do not have QuickTime installed
9773 (Requested by estes on #webkit).
9775 * WebCoreSupport/WebFrameLoaderClient.h:
9776 * WebCoreSupport/WebFrameLoaderClient.mm:
9777 (WebFrameLoaderClient::objectContentType):
9779 2011-03-24 Andy Estes <aestes@apple.com>
9781 Reviewed by Darin Adler.
9783 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
9784 https://bugs.webkit.org/show_bug.cgi?id=49016
9786 Update objectContentType() implementation to handle the
9787 shouldPreferPlugInsForImages flag.
9789 * WebCoreSupport/WebFrameLoaderClient.h:
9790 * WebCoreSupport/WebFrameLoaderClient.mm:
9791 (WebFrameLoaderClient::objectContentType):
9793 2011-03-24 Geoffrey Garen <ggaren@apple.com>
9795 Reviewed by Oliver Hunt.
9797 Ensure that all compilation takes place within a dynamic global object scope
9798 https://bugs.webkit.org/show_bug.cgi?id=57054
9800 * WebView/WebScriptDebugDelegate.mm:
9801 (-[WebScriptCallFrame evaluateWebScript:]): Updated for signature change.
9803 2011-03-24 Jia Pu <jpu@apple.com>
9805 Reviewed by Darin Adler.
9807 Dismissed reversion suggestion is incorrectly learned.
9808 https://bugs.webkit.org/show_bug.cgi?id=57039
9810 CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
9811 [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
9812 is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
9813 incorrect automatic learning.
9815 * WebCoreSupport/CorrectionPanel.mm:
9816 (CorrectionPanel::dismissInternal):
9818 2011-03-24 David Kilzer <ddkilzer@apple.com>
9820 <http://webkit.org/b/56993> ENABLE_PLUGIN_PROXY_FOR_VIDEO should be defined to 0 on Mac OS X
9822 Reviewed by Joseph Pecoraro.
9824 * Plugins/WebPluginContainerPrivate.h: Changed value of
9825 ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.
9827 2011-03-23 Jia Pu <jpu@apple.com>
9829 Reviewed by Darin Adler.
9831 Hook up new AppKit autocorrection UI with WK2.
9832 https://bugs.webkit.org/show_bug.cgi?id=56055
9833 <rdar://problem/8947463>
9835 Please see WebCore/ChangeLog for detail.
9837 * WebCoreSupport/CorrectionPanel.h: Added.
9838 (CorrectionPanel::isShowing):
9839 * WebCoreSupport/CorrectionPanel.mm: Added.
9840 (correctionBubbleType):
9841 (CorrectionPanel::CorrectionPanel):
9842 (CorrectionPanel::~CorrectionPanel):
9843 (CorrectionPanel::show):
9844 (CorrectionPanel::dismiss):
9845 (CorrectionPanel::dismissSoon):
9846 (CorrectionPanel::dismissInternal):
9847 (CorrectionPanel::recordAutocorrectionResponse):
9848 * WebCoreSupport/WebEditorClient.h:
9849 * WebCoreSupport/WebEditorClient.mm:
9850 (WebEditorClient::WebEditorClient):
9851 (WebEditorClient::showCorrectionPanel):
9852 (WebEditorClient::dismissCorrectionPanel):
9853 (WebEditorClient::dismissCorrectionPanelSoon):
9854 (WebEditorClient::recordAutocorrectionResponse):
9855 * WebView/WebView.mm:
9856 (-[WebView handleCorrectionPanelResult:]):
9857 * WebView/WebViewPrivate.h:
9859 2011-03-23 Enrica Casucci <enrica@apple.com>
9861 Reviewed by Alexey Proskuryakov.
9863 Services menu item to convert selected Simplified/Traditional Chinese Text is not working.
9864 https://bugs.webkit.org/show_bug.cgi?id=56974
9865 <rdar://problem/8284642>
9867 This fixes a regression introduced by http://trac.webkit.org/changeset/61794
9868 where readSelectionFromPasteboard was accidentally removed.
9869 This method and writeSelectionToPasteboard are needed to support Mac OS X
9872 * WebView/WebHTMLView.mm:
9873 (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
9874 (-[WebHTMLView readSelectionFromPasteboard:]): Added.
9876 2011-03-23 Brady Eidson <beidson@apple.com>
9878 Reviewed by Sam Weinig.
9880 Change IconDatabase opening to allow for arbitrary filenames
9881 https://bugs.webkit.org/show_bug.cgi?id=56977
9883 * Misc/WebIconDatabase.mm:
9884 (-[WebIconDatabase _startUpIconDatabase]):
9886 2011-03-22 Anton D'Auria <adauria@apple.com>
9888 Reviewed by Alexey Proskuryakov.
9890 Add +[WebApplicationCache getOriginsWithCache]
9891 https://bugs.webkit.org/show_bug.cgi?id=56722
9893 Call existing WebCore::ApplicationCacheStorage::getOriginsWithCache API.
9895 * WebCoreSupport/WebApplicationCache.h:
9896 * WebCoreSupport/WebApplicationCache.mm:
9897 (+[WebApplicationCache originsWithCache]):
9899 2011-03-22 Anders Carlsson <andersca@apple.com>
9901 Reviewed by Sam Weinig.
9903 OBJECT element with DivX source is always downloaded
9904 https://bugs.webkit.org/show_bug.cgi?id=56879
9906 * Plugins/WebBasePluginPackage.mm:
9907 (-[WebBasePluginPackage getPluginInfoFromPLists]):
9908 Always try to split every element in the "WebPluginExtensions" array, since the DivX plug-in
9909 specifies multiple file extensions in a single element.
9911 2011-03-22 Brady Eidson <beidson@apple.com>
9913 Reviewed by Sam Weinig.
9915 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
9916 WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
9918 Note that while the new client calls always come through on the main thread, our mechanisms to
9919 route dispatches to the main thread are still valid and will still work.
9921 Update to the new IconDatabaseClient interface:
9922 * WebCoreSupport/WebIconDatabaseClient.h:
9923 * WebCoreSupport/WebIconDatabaseClient.mm:
9924 (WebIconDatabaseClient::didRemoveAllIcons):
9925 (WebIconDatabaseClient::didImportIconURLForPageURL):
9926 (WebIconDatabaseClient::didImportIconDataForPageURL):
9927 (WebIconDatabaseClient::didChangeIconForPageURL):
9928 (WebIconDatabaseClient::didFinishURLImport):
9930 2011-03-22 Matthew Delaney <mdelaney@apple.com>
9932 Reviewed by Simon Fraser.
9934 Have WebKit push acceleratedDrawing preferences to settings
9935 https://bugs.webkit.org/show_bug.cgi?id=56792
9937 * WebView/WebView.mm:
9939 2011-03-21 Nate Chapin <japhet@chromium.org>
9941 Reviewed by Brady Eidson.
9943 Expose a preference to use caching quirks for QuickLook,
9944 and use it if the QuickLook framework is loaded.
9946 https://bugs.webkit.org/show_bug.cgi?id=38690
9948 * WebView/WebPreferenceKeysPrivate.h:
9949 * WebView/WebPreferences.mm:
9950 (useQuickLookQuirks):
9951 (+[WebPreferences initialize]):
9952 (-[WebPreferences useQuickLookResourceCachingQuirks]):
9953 * WebView/WebPreferencesPrivate.h:
9954 * WebView/WebView.mm:
9955 (-[WebView _preferencesChangedNotification:]):
9957 2011-03-21 Chris Fleizach <cfleizach@apple.com>
9959 Reviewed by Darin Adler.
9961 AX: showContextMenu not working in WK2
9962 https://bugs.webkit.org/show_bug.cgi?id=56734
9964 Implement showContextMenu() so accessibility related code can call this
9965 independent of whether WK1 or WK2 is running.
9967 * WebCoreSupport/WebChromeClient.h:
9968 * WebCoreSupport/WebChromeClient.mm:
9969 (WebChromeClient::showContextMenu):
9971 2011-03-21 Chang Shu <cshu@webkit.org>
9973 Reviewed by Alexey Proskuryakov.
9975 REGRESSION (r79953): Can't type in MS Outlook 2011
9976 https://bugs.webkit.org/show_bug.cgi?id=56665
9978 r79953 removed the WebView level editablity which is persistent no matter whether
9979 underlying document itself is changed and editability gets lost. The resolution is to
9980 set this WebView editable value to WebCore. This avoids the callback from WebCore to
9981 WebKit which was the main goal in r79953 to improve performance.
9983 * WebView/WebView.mm:
9984 (-[WebView setEditable:]):
9985 (-[WebView isEditable]):
9987 2011-03-19 Anton D'Auria <adauria@apple.com>
9989 Reviewed by Alexey Proskuryakov.
9991 ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
9992 https://bugs.webkit.org/show_bug.cgi?id=56415
9994 Use new ApplicationCache API to delete all cache for an origin.
9996 * WebCoreSupport/WebApplicationCache.h:
9997 * WebCoreSupport/WebApplicationCache.mm:
9998 (+[WebApplicationCache deleteOrigin:]):
10000 2011-03-17 Brady Eidson <beidson@apple.com>
10002 Reviewed by Sam Weinig.
10004 https://bugs.webkit.org/show_bug.cgi?id=56425
10005 More groundwork for WebKit2 IconDatabase
10007 Update already-used function names:
10008 * Misc/WebIconDatabase.mm:
10009 (-[WebIconDatabase iconForURL:withSize:cache:]):
10010 (-[WebIconDatabase iconURLForURL:]):
10011 * WebView/WebView.mm:
10012 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
10014 2011-03-18 Pavel Podivilov <podivilov@chromium.org>
10016 Reviewed by Yury Semikhatsky.
10018 Web Inspector: implement inspector session storage.
10019 https://bugs.webkit.org/show_bug.cgi?id=56643
10021 * WebCoreSupport/WebInspectorClient.h:
10022 * WebCoreSupport/WebInspectorClient.mm:
10023 (WebInspectorClient::saveSessionSetting):
10024 (WebInspectorClient::loadSessionSetting):
10025 (WebInspectorFrontendClient::saveSessionSetting):
10026 (WebInspectorFrontendClient::loadSessionSetting):
10027 (-[WebInspectorWindowController inspectorClient]):
10029 2011-03-17 Geoffrey Garen <ggaren@apple.com>
10031 Reviewed by Oliver Hunt.
10033 Fixed a leak seen on the buildbot.
10035 * WebCoreSupport/WebInspectorClient.mm:
10036 (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.
10038 2011-03-16 Jeff Johnson <github@lapcatsoftware.com>
10040 Reviewed by Alexey Proskuryakov.
10042 Logic error in -[WebHTMLView close]
10043 https://bugs.webkit.org/show_bug.cgi?id=56445
10045 Page is always nil at this point, because [self _webView] is nil,
10046 so the conditional code is never run.
10048 * WebView/WebHTMLView.mm:
10049 (-[WebHTMLView close]):
10051 2011-03-16 Chris Fleizach <cfleizach@apple.com>
10053 Reviewed by Darin Adler.
10055 WK2: Need to propagate enhanced accessibility flag from UI -> web process
10056 https://bugs.webkit.org/show_bug.cgi?id=56379
10058 * WebView/WebFrame.mm:
10059 (-[WebFrame accessibilityRoot]):
10061 2011-03-15 Oliver Hunt <oliver@apple.com>
10063 Reviewed by Geoffrey Garen.
10065 Make Structure creation require a JSGlobalData
10066 https://bugs.webkit.org/show_bug.cgi?id=56438
10068 Mechanical change to make all Structure creation use a JSGlobalData&
10070 * Plugins/Hosted/ProxyInstance.mm:
10071 (WebKit::ProxyRuntimeMethod::createStructure):
10072 * Plugins/Hosted/ProxyRuntimeObject.h:
10073 (WebKit::ProxyRuntimeObject::createStructure):
10075 2011-03-15 Alexey Proskuryakov <ap@apple.com>
10077 Forgot to save a modification to this file when committing.
10079 * WebCoreSupport/WebKeyGenerator.mm: Changed "Apple Computer" to "Apple" in copyright header.
10081 2011-03-15 Alexey Proskuryakov <ap@apple.com>
10083 Reviewed by Darin Adler.
10085 REGRESSION (WebKit2): keygen element doesn't work
10086 https://bugs.webkit.org/show_bug.cgi?id=56402
10087 <rdar://problem/9006545>
10089 * WebCoreSupport/WebKeyGenerator.h:
10090 * WebCoreSupport/WebKeyGenerator.m: Removed.
10091 * WebCoreSupport/WebKeyGenerator.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebKeyGenerator.m.
10092 (+[WebKeyGenerator sharedGenerator]):
10093 (toWebCertificateParseResult):
10094 WebCore no longer needs WebKeyGenerator. Safari still does need a part of it, so keeping
10095 this misnamed and misplaced code for now.
10097 * WebCoreSupport/WebPlatformStrategies.h:
10098 * WebCoreSupport/WebPlatformStrategies.mm:
10099 (WebPlatformStrategies::keygenMenuItem512):
10100 (WebPlatformStrategies::keygenMenuItem1024):
10101 (WebPlatformStrategies::keygenMenuItem2048):
10102 (WebPlatformStrategies::keygenKeychainItemName):
10103 Added strings used by keygen.
10105 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize a WebCore
10106 pointer to a function used by keygen.
10108 * WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): WebKeyGenerator can be lazily
10111 2011-03-15 Beth Dakin <bdakin@apple.com>
10113 Reviewed by Simon Fraser.
10115 WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6%
10117 New WebKitystemInterface function to force the scrollbars to flash
10118 * WebCoreSupport/WebSystemInterface.mm:
10119 (InitWebCoreSystemInterface):
10121 2011-03-15 Ilya Sherman <isherman@chromium.org>
10123 Reviewed by Tony Chang.
10125 Autofilled form elements are assigned fixed background color but not text color
10126 https://bugs.webkit.org/show_bug.cgi?id=48382
10128 * DOM/WebDOMOperations.mm:
10129 (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper).
10130 * DOM/WebDOMOperationsPrivate.h:
10132 2011-03-15 Adam Roben <aroben@apple.com>
10134 Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin
10136 Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in
10137 WebStorageTrackerClient::dispatchDidModifyOrigin
10139 Reviewed by Antti Koivisto.
10141 * Storage/WebStorageTrackerClient.mm:
10142 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed
10143 to us by dispatchDidModifyOrigin.
10144 (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an
10147 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
10149 Reviewed by Darin Adler.
10151 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
10152 info into the headers rather than in export symbol definition files, but disable it on
10153 all platforms initially so we can deal with port build issues one port at a time.
10155 https://bugs.webkit.org/show_bug.cgi?id=27551
10159 2011-03-14 Brady Eidson <beidson@apple.com>
10161 Reviewed by Anders Carlsson.
10163 https://bugs.webkit.org/show_bug.cgi?id=56320
10164 Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
10166 * History/WebHistoryItem.mm:
10167 (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
10169 2011-03-13 Pratik Solanki <psolanki@apple.com>
10171 Reviewed by Brady Eidson.
10173 Make adjustMIMETypeIfNecessary use CFNetwork directly
10174 https://bugs.webkit.org/show_bug.cgi?id=55912
10176 * WebCoreSupport/WebSystemInterface.mm:
10177 (InitWebCoreSystemInterface): Support for new WKSI functions.
10179 2011-03-12 Mark Rowe <mrowe@apple.com>
10181 Fix the 32-bit build.
10183 * Carbon/CarbonWindowAdapter.mm:
10184 (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
10185 (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
10187 2011-03-11 Brady Eidson <beidson@apple.com>
10189 Reviewed by Anders Carlsson
10191 <rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
10192 Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
10194 * Misc/WebIconDatabase.mm:
10195 (+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
10196 (-[WebIconDatabase _startUpIconDatabase]): Ditto.
10197 (importToWebCoreFormat):
10199 2011-03-11 Anton D'Auria <adauria@apple.com>
10201 Reviewed and landed by Brady Eidson.
10203 https://bugs.webkit.org/show_bug.cgi?id=51878
10204 Add WebKit1 API to view and delete local storage
10206 * Storage/WebStorageManager.mm: Added.
10207 (+[WebStorageManager sharedWebStorageManager]):
10208 (-[WebStorageManager origins]):
10209 (-[WebStorageManager deleteAllOrigins]):
10210 (-[WebStorageManager deleteOrigin:]):
10211 (-[WebStorageManager syncLocalStorage]):
10212 (-[WebStorageManager syncFileSystemAndTrackerDatabase]):
10213 (storageDirectoryPath):
10214 (WebKitInitializeStorageIfNecessary):
10215 * Storage/WebStorageManagerInternal.h: Added.
10216 * Storage/WebStorageManagerPrivate.h: Added.
10217 * Storage/WebStorageTrackerClient.h: Added.
10218 * Storage/WebStorageTrackerClient.mm: Added.
10219 (WebStorageTrackerClient::sharedWebStorageTrackerClient):
10220 (WebStorageTrackerClient::WebStorageTrackerClient):
10221 (WebStorageTrackerClient::~WebStorageTrackerClient):
10222 (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
10223 (WebStorageTrackerClient::dispatchDidModifyOrigin):
10224 * WebCoreSupport/WebSecurityOrigin.mm:
10225 (-[WebSecurityOrigin protocol]):
10226 (-[WebSecurityOrigin host]):
10227 (-[WebSecurityOrigin databaseIdentifier]):
10228 (-[WebSecurityOrigin domain]):
10229 (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
10230 * WebCoreSupport/WebSecurityOriginPrivate.h:
10232 * WebView/WebView.mm:
10233 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
10235 2011-03-10 Anders Carlsson <andersca@apple.com>
10237 Reviewed by Sam Weinig.
10239 <rdar://problem/9117047>
10240 Don't paint more than 60 times per second even when scrolling
10242 * WebView/WebClipView.mm:
10243 (-[WebClipView _immediateScrollToPoint:]):
10245 2011-03-09 Matthew Delaney <mdelaney@apple.com>
10247 Reviewed by Simon Fraser.
10249 Plumb through settings for accelerated drawing for canvas
10250 https://bugs.webkit.org/show_bug.cgi?id=56039
10252 * WebView/WebPreferenceKeysPrivate.h:
10253 * WebView/WebPreferences.mm:
10254 * WebView/WebPreferencesPrivate.h:
10256 2011-03-10 Ryosuke Niwa <rniwa@webkit.org>
10258 Reviewed by Tony Chang.
10260 VisiblePosition's next and previous should take an enum instead of a boolean
10261 https://bugs.webkit.org/show_bug.cgi?id=56135
10263 SelectionController::isAll now takes EditingBoundaryCrossingRule instead of
10264 StayInEditableContent.
10266 * WebView/WebView.mm:
10267 (-[WebView _selectionIsAll]):
10269 2011-03-09 Jessie Berlin <jberlin@apple.com>
10271 Reviewed by Adam Roben.
10273 Use the Cookie Storage from the Private Browsing Storage Session directly
10274 https://bugs.webkit.org/show_bug.cgi?id=55986
10276 * WebCoreSupport/WebSystemInterface.mm:
10277 (InitWebCoreSystemInterface):
10279 2011-03-08 Darin Adler <darin@apple.com>
10281 Reviewed by Timothy Hatcher.
10283 Promote a method used outside WebKit from internal to private
10284 https://bugs.webkit.org/show_bug.cgi?id=55949
10286 * Misc/WebNSPasteboardExtras.mm: Removed an unused category declaration.
10287 Minor tweak, not directly related to the rest of this patch.
10289 * WebView/WebFrame.mm:
10290 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Moved
10291 this method from the internal category into the private category.
10292 Streamlined the code a bit.
10294 * WebView/WebFrameInternal.h: Removed _computePageRects method.
10295 * WebView/WebFramePrivate.h: Added _computePageRects method.
10297 2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
10299 Reviewed by Darin Adler.
10301 selectionHasStyle and selectionStartHasStyle should use EditingStyle
10302 https://bugs.webkit.org/show_bug.cgi?id=55902
10304 selectionHasStyle now takes a property id and a value instead of a CSSMutableStyleDeclaration.
10306 * WebView/WebHTMLView.mm: Removed unused selectionHasStyle.
10307 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Calls Editor::selectionHasStyle.
10309 2011-03-07 Dan Bernstein <mitz@apple.com>
10311 LLVM Compiler build fix.
10313 * WebCoreSupport/WebEditorClient.mm:
10314 (WebEditorClient::checkGrammarOfString):
10316 2011-03-07 Chris Fleizach <cfleizach@apple.com>
10318 Reviewed by Beth Dakin.
10320 AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
10321 https://bugs.webkit.org/show_bug.cgi?id=55706
10323 Make sure WebDynamicScrollBarsView appear in the AX tree in WK1 (since this object
10324 returns the scroll bar objects).
10325 Make the accessibilityRoot object be the web area in WK1 because WebDynamicScrollBarsView
10326 will expect that as its child, instead of the WebCore ScrollView object.
10328 * WebView/WebDynamicScrollBarsView.mm:
10329 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
10330 * WebView/WebFrame.mm:
10331 (-[WebFrame accessibilityRoot]):
10333 2011-03-07 Sam Weinig <sam@webkit.org>
10335 Reviewed by Anders Carlsson.
10337 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
10338 https://bugs.webkit.org/show_bug.cgi?id=55827
10340 Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
10341 and pass the entire response, instead of just the MIMEType.
10343 * WebCoreSupport/WebFrameLoaderClient.h:
10344 * WebCoreSupport/WebFrameLoaderClient.mm:
10345 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
10347 2011-03-06 Dan Bernstein <mitz@apple.com>
10349 LLVM Compiler build fix.
10351 * DOM/WebDOMOperations.mm:
10352 (-[DOMHTMLInputElement _setValueForUser:]):
10354 2011-03-06 Jessie Berlin <jberlin@apple.com>
10356 Reviewed by Sam Weinig.
10358 WebKit2: Use CFNetwork Sessions API.
10359 https://bugs.webkit.org/show_bug.cgi?id=55435.
10361 When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
10362 Private Browsing Storage Session.
10364 * WebCoreSupport/WebSystemInterface.mm:
10365 (InitWebCoreSystemInterface):
10366 Add support for using the new WKSI functions in WebCore.
10368 2011-03-05 Ilya Sherman <isherman@chromium.org>
10370 Reviewed by Darin Adler.
10372 HTMLInputElement::setValue() should schedule change event when the element is focused
10373 In service of https://code.google.com/p/chromium/issues/detail?id=42716
10374 https://bugs.webkit.org/show_bug.cgi?id=53160
10376 * DOM/WebDOMOperations.mm:
10377 (-[DOMHTMLInputElement _setValueForUser:]): Expose HTMLInputElement::setValueForUser() to tests
10378 * DOM/WebDOMOperationsPrivate.h:
10379 * WebView/WebViewInternal.h:
10381 2011-03-04 Jia Pu <jpu@apple.com>
10383 Reviewed by Darin Adler.
10385 On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
10386 https://bugs.webkit.org/show_bug.cgi?id=55717
10387 <rdar://problem/9018127>
10389 With the change in WebCore, the bounding box passed into EditorClient::showCorrectionPanel()
10390 is already in window coordinate. We don't need to do further conversion anymore.
10392 * WebCoreSupport/WebEditorClient.mm:
10393 (WebEditorClient::showCorrectionPanel):
10395 2011-03-04 Jessie Berlin <jberlin@apple.com>
10397 Reviewed by Maciej Stachowiak.
10399 WebKit2: Use CFNetwork Sessions API.
10400 https://bugs.webkit.org/show_bug.cgi?id=55435.
10402 When Private Browsing is enabled, get the cached url response from the cache associated with
10403 the Private Browsing Storage Session.
10405 * WebView/WebView.mm:
10406 (-[WebView _cachedResponseForURL:]):
10408 2011-03-03 Anders Carlsson <andersca@apple.com>
10410 Reviewed by Sam Weinig.
10412 Get rid of Page::globalHistoryItem
10413 https://bugs.webkit.org/show_bug.cgi?id=55738
10415 * WebCoreSupport/WebFrameLoaderClient.h:
10416 * WebCoreSupport/WebFrameLoaderClient.mm:
10417 (WebFrameLoaderClient::updateGlobalHistoryItemForPage):
10418 Get the current history item and update it using -[WebView _setGlobalHistoryItem:].
10420 * WebView/WebView.mm:
10421 (-[WebView _globalHistoryItem]):
10422 (-[WebView _setGlobalHistoryItem:]):
10423 Set _globalHistoryItem ivar.
10425 * WebView/WebViewData.h:
10426 * WebView/WebViewData.mm:
10427 Add _globalHistoryItem ivar.
10429 2011-03-03 Brady Eidson <beidson@apple.com>
10431 Reviewed by Darin Adler.
10433 https://bugs.webkit.org/show_bug.cgi?id=55721
10434 Global IconDatabase should be returned by reference, not as a pointer
10436 * Misc/WebCoreStatistics.mm:
10437 (+[WebCoreStatistics iconPageURLMappingCount]):
10438 (+[WebCoreStatistics iconRetainedPageURLCount]):
10439 (+[WebCoreStatistics iconRecordCount]):
10440 (+[WebCoreStatistics iconsWithDataCount]):
10441 * Misc/WebIconDatabase.mm:
10442 (-[WebIconDatabase init]):
10443 (-[WebIconDatabase iconForURL:withSize:cache:]):
10444 (-[WebIconDatabase iconURLForURL:]):
10445 (-[WebIconDatabase defaultIconWithSize:]):
10446 (-[WebIconDatabase retainIconForURL:]):
10447 (-[WebIconDatabase releaseIconForURL:]):
10448 (-[WebIconDatabase isEnabled]):
10449 (-[WebIconDatabase setEnabled:]):
10450 (-[WebIconDatabase removeAllIcons]):
10451 (+[WebIconDatabase _checkIntegrityBeforeOpening]):
10452 (-[WebIconDatabase _startUpIconDatabase]):
10453 (-[WebIconDatabase _applicationWillTerminate:]):
10454 (-[WebIconDatabase _resetCachedWebPreferences:]):
10455 (importToWebCoreFormat):
10456 * WebView/WebView.mm:
10457 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
10459 2011-03-03 Jessie Berlin <jberlin@apple.com>
10461 Reviewed by Adam Roben.
10463 WebKit2: Use CFNetwork Sessions API.
10464 https://bugs.webkit.org/show_bug.cgi?id=55435.
10466 Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
10468 * WebCoreSupport/WebSystemInterface.mm:
10469 (InitWebCoreSystemInterface):
10470 Support using WKCopyRequestWithStorageSession in WebCore.
10472 2011-03-02 Alexey Proskuryakov <ap@apple.com>
10474 Reviewed by Darin Adler.
10476 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
10477 https://bugs.webkit.org/show_bug.cgi?id=55633
10478 <rdar://problem/8963023>
10480 * WebCoreSupport/WebChromeClient.h:
10481 * WebCoreSupport/WebChromeClient.mm:
10482 Removed tabsToLinks(). Mac WebKit already implements keyboardUIMode().
10484 * WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
10485 Removed an incorrect comment. We actually get a value of 2 on Snow Leopard, and we don't
10486 require both bits to be set. The rest of the comment might be wrong too, but I'm not sure,
10487 so I've preserved it.
10489 2011-03-02 Jessie Berlin <jberlin@apple.com>
10491 Rubber-stamped by Dan Bernstein.
10493 Fix crashes in private browsing tests in WK1 on Snow Leopard.
10495 * WebCoreSupport/WebSystemInterface.mm:
10496 (InitWebCoreSystemInterface):
10497 Put the INIT call for wkCreatePrivateStorageSession outside of the
10498 #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
10501 2011-03-02 Jessie Berlin <jberlin@apple.com>
10503 Reviewed by Adam Roben.
10505 WebKit2: Use CFNetwork Sessions API.
10506 https://bugs.webkit.org/show_bug.cgi?id=55435.
10508 Add the ability to create a Private Browsing Storage Session.
10510 * WebCoreSupport/WebSystemInterface.mm:
10511 (InitWebCoreSystemInterface):
10512 Support calling wkCreatePrivateStorageSession from WebCore.
10514 2011-03-02 Daniel Cheng <dcheng@chromium.org>
10516 Reviewed by David Levin.
10518 Add feature define for data transfer items
10519 https://bugs.webkit.org/show_bug.cgi?id=55510
10521 * Configurations/FeatureDefines.xcconfig:
10523 2011-03-02 Sam Weinig <sam@webkit.org>
10525 Reviewed by Anders Carlsson.
10527 Fix remaining localization issues by piping all localized strings through WebCore's
10528 localization bottleneck.
10529 <rdar://problem/8728860>
10531 * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
10532 (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
10533 * Misc/WebKitErrors.m:
10534 * Misc/WebLocalizableStringsInternal.h: Added.
10535 * Misc/WebLocalizableStringsInternal.mm: Added.
10536 (WebLocalizedStringInternal):
10537 * Panels/WebAuthenticationPanel.m:
10538 (-[WebAuthenticationPanel setUpForChallenge:]):
10539 * Plugins/Hosted/NetscapePluginHostManager.mm:
10540 (WebKit::NetscapePluginHostManager::spawnPluginHost):
10541 * WebCoreSupport/WebEditorClient.mm:
10542 (undoNameForEditAction):
10543 * WebCoreSupport/WebInspectorClient.mm:
10544 (WebInspectorFrontendClient::updateWindowTitle):
10545 (-[WebInspectorWindowController validateUserInterfaceItem:]):
10546 * WebCoreSupport/WebKeyGenerator.m:
10547 (-[WebKeyGenerator strengthMenuItemTitles]):
10548 (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
10549 * WebCoreSupport/WebPlatformStrategies.mm:
10550 * WebView/WebHTMLView.mm:
10551 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
10552 * WebView/WebPDFView.mm:
10553 (-[WebPDFView menuForEvent:]):
10555 2011-03-01 Brian Weinstein <bweinstein@apple.com>
10557 Reviewed by Adam Roben.
10559 Part of WebKit2: Need a way to send notifications to client when cookies change
10560 https://bugs.webkit.org/show_bug.cgi?id=55427
10561 <rdar://problem/9056027>
10563 Add stubs for CookiesStrategy on Mac WebKit1.
10565 * WebCoreSupport/WebPlatformStrategies.h:
10566 * WebCoreSupport/WebPlatformStrategies.mm:
10567 (WebPlatformStrategies::createCookiesStrategy):
10568 (WebPlatformStrategies::notifyCookiesChanged):
10570 2011-03-01 Philippe Normand <pnormand@igalia.com>
10572 Reviewed by Eric Carlson.
10574 [GStreamer] support in mac video fullscreen controller
10575 https://bugs.webkit.org/show_bug.cgi?id=52280
10577 Factored the code to configure the video overlay in a new private
10578 method of the controller and added GStreamer support to it.
10580 * WebView/WebVideoFullscreenController.h:
10581 * WebView/WebVideoFullscreenController.mm:
10582 (-[WebVideoFullscreenController setupVideoOverlay:]):
10583 (-[WebVideoFullscreenController windowDidLoad]):
10584 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
10585 (-[WebVideoFullscreenController windowDidExitFullscreen]):
10587 2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
10589 Reviewed by Timothy Hatcher.
10591 All Console Messages should be passed to ChromeClients.
10592 https://bugs.webkit.org/show_bug.cgi?id=54926
10594 Add a new private UIDelegate method, -webView:addMessageToConsole:withSource:,
10595 which supersedes -webView:addMessageToConsole if it exists. The new delegate
10596 does not filter to only JavaScript originated console messages. The old
10597 delegate is left around for clients that expect filtered messages, like
10598 DashCode and older versions of Safari.
10600 The dictionary message passed to the delegate now includes more information
10601 about the message source, type, and level.
10603 * WebCoreSupport/WebChromeClient.mm:
10604 (stringForMessageSource):
10605 (stringForMessageType):
10606 (stringForMessageLevel):
10607 (WebChromeClient::addMessageToConsole):
10608 * WebView/WebUIDelegatePrivate.h:
10610 2011-03-01 Levi Weintraub <leviw@chromium.org>
10612 Reviewed by Ryosuke Niwa.
10614 Stop instantiating legacy editing Positions in VisiblePosition
10615 https://bugs.webkit.org/show_bug.cgi?id=52919
10617 Changing usage of legacy VisiblePosition constructor. Since we were dealing
10618 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
10620 * WebView/WebFrame.mm:
10621 (-[WebFrame _caretRectAtPosition:affinity:]):
10622 * WebView/WebFrameInternal.h:
10623 * WebView/WebTextCompletionController.mm:
10624 (-[WebTextCompletionController doCompletion]):
10626 2011-03-01 Sam Weinig <sam@webkit.org>
10628 Reviewed by Timothy Hatcher.
10630 WebKit2 needs to be made localizable
10631 https://bugs.webkit.org/show_bug.cgi?id=55483
10633 * WebCoreSupport/WebPlatformStrategies.mm:
10634 Use WebCore's localizedString function instead of WebLocalizableStrings
10635 since WebCore is now responsible for localization.
10637 2011-02-25 Steve Block <steveblock@google.com>
10639 Reviewed by Jeremy Orlow.
10641 Bridge.h should not include BridgeJSC.h
10642 https://bugs.webkit.org/show_bug.cgi?id=55212
10644 Include BridgeJSC.h directly instead.
10646 * Plugins/Hosted/ProxyInstance.h:
10647 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
10649 2011-02-28 Chang Shu <cshu@webkit.org>
10651 Reviewed by Ryosuke Niwa.
10653 Remove the support of Frame::isContentEditable and its dependencies.
10654 https://bugs.webkit.org/show_bug.cgi?id=54292
10656 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
10658 * WebCoreSupport/WebEditorClient.h:
10659 * WebCoreSupport/WebEditorClient.mm:
10660 * WebView/WebView.mm:
10661 (-[WebView setEditable:]):
10662 (-[WebView isEditable]):
10663 * WebView/WebViewData.h:
10665 2011-02-28 Oliver Hunt <oliver@apple.com>
10667 Reviewed by Gavin Barraclough.
10669 Make ScopeChainNode GC allocated
10670 https://bugs.webkit.org/show_bug.cgi?id=55283
10672 More updates for the absence of the ScopeChain class
10674 * WebView/WebScriptDebugDelegate.mm:
10675 (-[WebScriptCallFrame scopeChain]):
10677 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
10679 Reviewed by Pavel Feldman.
10681 DumpRenderTree should reset frame opener between tests.
10682 https://bugs.webkit.org/show_bug.cgi?id=54874
10684 Added clearOpener method to WebFramePrivate.
10686 * WebView/WebFrame.mm:
10687 (-[WebFrame _clearOpener]):
10688 * WebView/WebFramePrivate.h:
10690 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
10692 Unreviewed, rolling out r79764.
10693 http://trac.webkit.org/changeset/79764
10694 https://bugs.webkit.org/show_bug.cgi?id=55295
10696 "broke Chromium builds" (Requested by rniwa on #webkit).
10698 * WebView/WebFrame.mm:
10699 * WebView/WebFramePrivate.h:
10701 2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
10703 Reviewed by David Kilzer.
10705 https://bugs.webkit.org/show_bug.cgi?id=48781
10707 Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
10709 Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
10710 should paint the default broken image when an image fails to load or decode. The method also passes the
10711 URL of the failed image.
10713 * WebCoreSupport/WebFrameLoaderClient.h:
10714 * WebCoreSupport/WebFrameLoaderClient.mm:
10715 (WebFrameLoaderClient::shouldPaintBrokenImage):
10716 * WebView/WebDelegateImplementationCaching.h:
10717 * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
10718 (CallResourceLoadDelegateReturningBoolean):
10719 * WebView/WebResourceLoadDelegatePrivate.h:
10720 * WebView/WebView.mm:
10721 (-[WebView _cacheResourceLoadDelegateImplementations]):
10723 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
10725 Reviewed by Pavel Feldman.
10727 DumpRenderTree should reset frame opener between tests.
10728 https://bugs.webkit.org/show_bug.cgi?id=54874
10730 Added clearOpener method to WebFramePrivate.
10732 * WebView/WebFrame.mm:
10733 (-[WebFrame _clearOpener]):
10734 * WebView/WebFramePrivate.h:
10736 2011-02-25 Mark Rowe <mrowe@apple.com>
10738 <rdar://problem/8902546> Build fix.
10740 * Misc/QuickDrawCompatibility.h:
10742 2011-02-24 Anders Carlsson <andersca@apple.com>
10746 * WebCoreSupport/WebKeyGenerator.m:
10747 (toWebCertificateParseResult):
10748 (-[WebKeyGenerator addCertificatesToKeychainFromData:]):
10749 * WebView/WebTextCompletionController.mm:
10751 2011-02-24 Peter Kasting <pkasting@google.com>
10753 Reviewed by Eric Seidel.
10755 Drop the "U; " encryption level from the User Agent string.
10756 https://bugs.webkit.org/show_bug.cgi?id=54566
10758 * WebView/WebView.mm:
10759 (+[WebView _standardUserAgentWithApplicationName:]):
10761 2011-02-24 Andrew Wilson <atwilson@chromium.org>
10763 Unreviewed, rolling out r79570.
10764 http://trac.webkit.org/changeset/79570
10765 https://bugs.webkit.org/show_bug.cgi?id=54874
10767 Breaks chromium build because glue/mocks/mock_web_frame.h/cc
10770 * WebView/WebFrame.mm:
10771 * WebView/WebFramePrivate.h:
10773 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
10775 Reviewed by Alexey Proskuryakov.
10777 DumpRenderTree should reset frame opener between tests.
10778 https://bugs.webkit.org/show_bug.cgi?id=54874
10780 Added clearOpener method to WebFramePrivate.
10782 * WebView/WebFrame.mm:
10783 (-[WebFrame _clearOpener]):
10784 * WebView/WebFramePrivate.h:
10786 2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
10788 Reviewed by Alexey Proskuryakov.
10790 Drop the language tag part from the User Agent string
10791 https://bugs.webkit.org/show_bug.cgi?id=54560
10793 * WebView/WebView.mm:
10794 (+[WebView _standardUserAgentWithApplicationName:]): Drop the
10797 2011-02-22 Brady Eidson <beidson@apple.com>
10799 Reviewed by Anders Carlsson.
10801 Part of <rdar://problem/8762042> and https://bugs.webkit.org/show_bug.cgi?id=54514
10802 API to view and delete Application Cache data by origin.
10804 * WebCoreSupport/WebApplicationCache.mm:
10805 (+[WebApplicationCache deleteAllApplicationCaches]): Move this implementation into WebCore itself.
10807 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
10809 Reviewed by Kent Tamura.
10811 Rename Position::node() to Position::deprecatedNode()
10812 https://bugs.webkit.org/show_bug.cgi?id=54622
10814 * WebView/WebFrame.mm:
10815 (-[WebFrame _smartDeleteRangeForProposedRange:]):
10817 2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
10819 Reviewed by Kent Tamura.
10821 Rename Position::node() to Position::deprecatedNode()
10822 https://bugs.webkit.org/show_bug.cgi?id=54622
10826 * WebView/WebFrame.mm:
10827 (-[WebFrame _smartDeleteRangeForProposedRange:]): Since newStart and newEnd are parent-anchored,
10828 use containerNode() and offsetInContainerNode() instead of deprecated member functions.
10830 2011-02-18 Gavin Barraclough <barraclough@apple.com>
10832 Reviewed by Sam Weinig.
10834 Bug 54786 - Devirtualize JSCell::classInfo()
10836 Instead of making a virtual function call, add a pointer to the ClassInfo
10839 This removes a virtual function call, and paves the way towards removing all
10840 the createStructure methods, and StructureFlags/AnonymousSlotCount properties
10841 (these should be able to move onto ClassInfo).
10843 Calls to Structure::create must now pass a pointer to the ClassInfo for the
10844 structure. All objects now have a ClassInfo pointer, non-object cell types
10847 Changes are most mechanical, involving three steps:
10848 * Remove virtual classInfo() methods.
10849 * Add &s_info parameter to calls to Structure::create.
10850 * Rename ClassInfo static members on classes from 'info' to 's_info',
10853 * Plugins/Hosted/ProxyInstance.mm:
10854 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
10855 (WebKit::ProxyRuntimeMethod::createStructure):
10856 * Plugins/Hosted/ProxyRuntimeObject.h:
10857 (WebKit::ProxyRuntimeObject::createStructure):
10858 * Plugins/Hosted/ProxyRuntimeObject.mm:
10859 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
10860 * WebView/WebView.mm:
10861 (aeDescFromJSValue):
10863 2011-02-19 Brian Ryner <bryner@chromium.org>
10865 Reviewed by Adam Barth.
10867 Add missing #include of DocumentLoader.h, needed since the transitive
10868 include through Document.h is removed.
10869 https://bugs.webkit.org/show_bug.cgi?id=50489
10871 * WebView/WebFrame.mm:
10873 2011-02-19 Charlie Reis <creis@chromium.org>
10875 Reviewed by Mihai Parparita.
10877 Ensure loading has stopped in HistoryController::goToItem
10878 https://bugs.webkit.org/show_bug.cgi?id=54517
10880 Add a FrameLoaderClient callback for whether to stop loading before goToItem.
10882 Test: http/tests/navigation/forward-to-fragment-fires-onload.html
10884 * WebCoreSupport/WebFrameLoaderClient.mm:
10885 (WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
10886 * WebCoreSupport/WebFrameLoaderClient.h:
10888 2011-02-16 David Hyatt <hyatt@apple.com>
10890 Reviewed by Dan Bernstein.
10892 https://bugs.webkit.org/show_bug.cgi?id=54244
10894 Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
10895 hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
10897 The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
10898 been changed as well.
10900 In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
10902 Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
10904 Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
10905 still have a precise floating point position.
10907 Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
10908 be rounding justification spacing in their font code.
10910 Many layout test results change on Mac, since rounding hacks were used there and are now gone.
10912 * Misc/WebKitNSStringExtras.mm:
10913 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
10914 (-[NSString _web_widthWithFont:]):
10916 2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
10918 Reviewed by Adam Roben.
10920 HTML5 <details> and <summary>: localized text
10921 https://bugs.webkit.org/show_bug.cgi?id=54260
10923 The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
10924 provide the default label to be used by a <details> tag that has no <summary> child.
10926 * WebCoreSupport/WebPlatformStrategies.h:
10927 * WebCoreSupport/WebPlatformStrategies.mm:
10928 (WebPlatformStrategies::defaultDetailsSummaryText):
10930 2011-02-16 Matthew Delaney <mdelaney@apple.com>
10932 Reviewed by Simon Fraser.
10934 Allow acceleratesDrawing for WebKit2
10935 https://bugs.webkit.org/show_bug.cgi?id=54511
10937 Plumb through preference for accelerated drawing.
10939 * WebView/WebPreferenceKeysPrivate.h:
10940 * WebView/WebPreferences.mm:
10941 (+[WebPreferences initialize]):
10942 (-[WebPreferences acceleratedDrawingEnabled]):
10943 (-[WebPreferences setAcceleratedDrawingEnabled:]):
10944 * WebView/WebPreferencesPrivate.h:
10946 2011-02-15 David Kilzer <ddkilzer@apple.com>
10948 <http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h
10950 Reviewed by Darin Adler.
10952 * WebView/WebDynamicScrollBarsView.h:
10953 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed
10955 * WebView/WebDynamicScrollBarsView.mm:
10956 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved
10957 implementation into correct category.
10958 * WebView/WebDynamicScrollBarsViewInternal.h:
10959 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added
10961 * WebView/WebHTMLView.mm: Included
10962 WebDynamicScrollBarsViewInternal.h instead of
10963 WebDynamicScrollBarsView.h.
10965 2011-02-14 Oliver Hunt <oliver@apple.com>
10967 Reviewed by Gavin Barraclough and Geoff Garen.
10969 Refactor handles and weak pointers to become nicer and more automatic
10970 https://bugs.webkit.org/show_bug.cgi?id=54415
10972 Update to use Global<> instead of ProtectedPtr, and refactored slightly
10973 to get global data to places it's needed for when we're assigning to
10976 * ForwardingHeaders/collector/handles/Global.h: Added.
10977 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
10978 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
10979 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
10980 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
10981 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
10982 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
10983 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
10984 (WebKit::NetscapePluginInstanceProxy::evaluate):
10985 (WebKit::NetscapePluginInstanceProxy::invoke):
10986 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
10987 (WebKit::NetscapePluginInstanceProxy::construct):
10988 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
10989 * WebView/WebScriptDebugger.h:
10990 * WebView/WebScriptDebugger.mm:
10991 (WebScriptDebugger::WebScriptDebugger):
10993 2011-02-15 Jia Pu <jpu@apple.com>
10995 Reviewed by Darin Adler.
10997 Autocorrection should respect undo.
10998 https://bugs.webkit.org/show_bug.cgi?id=52221
10999 <rdar://problem/8663399>
11001 Please see WebCore/ChangeLog for detailed description.
11003 * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient.
11005 * WebCoreSupport/WebEditorClient.mm:
11006 (WebEditorClient::recordAutocorrectionResponse): Ditto.
11008 * WebView/WebFrame.mm:
11009 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
11010 Adopted new signature of ReplaceSelectionCommand::create().
11012 2011-02-15 David Kilzer <ddkilzer@apple.com>
11014 <http://webkit.org/b/54485> Fix spelling of -inProgramaticScroll
11016 Reviewed by Darin Adler.
11018 * WebView/WebDynamicScrollBarsView.h:
11019 * WebView/WebDynamicScrollBarsView.mm:
11020 (-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
11021 -inProgramaticScroll.
11022 * WebView/WebHTMLView.mm:
11023 (-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
11025 2011-02-15 Kenneth Russell <kbr@google.com>
11027 Reviewed by Darin Fisher.
11029 Allow controlling minimum DOMTimer interval on a per-page basis
11030 https://bugs.webkit.org/show_bug.cgi?id=54312
11032 Added needed methods to implement LayoutTestController's new
11033 setMinimumTimerInterval method.
11035 * WebView/WebView.mm:
11036 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
11037 (+[WebView _defaultMinimumTimerInterval]):
11038 (-[WebView _setMinimumTimerInterval:]):
11039 * WebView/WebViewPrivate.h:
11041 2011-02-11 Geoffrey Garen <ggaren@apple.com>
11043 Reviewed by Oliver Hunt.
11045 A little more encapsulation for the heap: Removed CollectorHeapIterator
11046 https://bugs.webkit.org/show_bug.cgi?id=54298
11048 * Misc/WebCoreStatistics.mm:
11049 (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
11050 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Updated for new typedef.
11052 2011-02-10 Nate Chapin <japhet@chromium.org>
11054 Reviewed by Adam Barth.
11056 Update calls to DocumentWriter.
11057 https://bugs.webkit.org/show_bug.cgi?id=50489
11059 * WebView/WebFrame.mm:
11060 (-[WebFrame _canProvideDocumentSource]):
11062 2011-02-10 Chris Fleizach <cfleizach@apple.com>
11064 Reviewed by Anders Carlsson.
11066 AX: AX needs to stop using WebCoreViewFactory
11067 https://bugs.webkit.org/show_bug.cgi?id=54153
11069 * WebCoreSupport/WebSystemInterface.mm:
11070 (InitWebCoreSystemInterface):
11072 2011-02-10 Peter Varga <pvarga@webkit.org>
11074 Reviewed by Csaba Osztrogonác.
11076 Remove PCRE source from trunk
11077 https://bugs.webkit.org/show_bug.cgi?id=54188
11079 * ForwardingHeaders/pcre/pcre.h: Removed.
11081 2011-02-09 Pavel Feldman <pfeldman@chromium.org>
11083 Reviewed by Yury Semikhatsky.
11085 Web Inspector: follow up on InspectorAgent split -
11086 removing unnecessary methods from InspectorController.
11087 https://bugs.webkit.org/show_bug.cgi?id=54093
11089 * WebInspector/WebInspector.mm:
11090 (-[WebInspector showConsole:]):
11091 (-[WebInspector stopProfilingJavaScript:]):
11093 2011-02-08 Dan Bernstein <mitz@apple.com>
11095 Reviewed by Jon Honeycutt and Maciej Stachowiak.
11097 <rdar://problem/8959420> Find in Mail no longer cycles around
11099 * WebView/WebHTMLView.mm:
11100 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
11101 the wrap option according to the flag.
11103 2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
11105 Unreviewed, rolling out r77980.
11106 http://trac.webkit.org/changeset/77980
11107 https://bugs.webkit.org/show_bug.cgi?id=54043
11109 "Crashes on Windows and Linux..." (Requested by leviw on
11112 * WebView/WebFrame.mm:
11113 (-[WebFrame _caretRectAtNode:offset:affinity:]):
11114 * WebView/WebFrameInternal.h:
11115 * WebView/WebTextCompletionController.mm:
11116 (-[WebTextCompletionController doCompletion]):
11118 2011-02-08 Levi Weintraub <leviw@chromium.org>
11120 Reviewed by Ryosuke Niwa.
11122 Stop instantiating legacy editing Positions in VisiblePosition
11123 https://bugs.webkit.org/show_bug.cgi?id=52919
11125 Changing usage of legacy VisiblePosition constructor. Since we were dealing
11126 with positions from DOM Ranges, we're guaranteed a parent-anchored position.
11128 * WebView/WebFrame.mm:
11129 (-[WebFrame _caretRectAtPosition:affinity:]):
11130 * WebView/WebFrameInternal.h:
11131 * WebView/WebTextCompletionController.mm:
11132 (-[WebTextCompletionController doCompletion]):
11134 2011-02-08 Adam Barth <abarth@webkit.org>
11136 Reviewed by Eric Seidel.
11138 Remove orphan code from old parser
11139 https://bugs.webkit.org/show_bug.cgi?id=53984
11141 * WebCoreSupport/WebChromeClient.h:
11143 2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
11145 Reviewed by Yury Semikhatsky.
11147 Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
11149 https://bugs.webkit.org/show_bug.cgi?id=53169
11151 Minor change enforced by major changes in WebCore/inspector/InspectorController.
11153 * WebInspector/WebInspector.mm:
11154 (-[WebInspector isTimelineProfilingEnabled]):
11156 2011-02-07 Enrica Casucci <enrica@apple.com>
11158 Reviewed Adam Roben and Darin Adler.
11160 WebKit2: drag and drop support on Windows.
11161 https://bugs.webkit.org/show_bug.cgi?id=52775
11163 Removed createDragImageForLink from DragClient.
11165 * WebCoreSupport/WebDragClient.h:
11166 * WebCoreSupport/WebDragClient.mm:
11167 (WebDragClient::startDrag):
11169 2011-02-03 Yury Semikhatsky <yurys@chromium.org>
11171 Reviewed by Pavel Feldman.
11173 Web Inspector: remove settings related methods from InspectorClient
11174 https://bugs.webkit.org/show_bug.cgi?id=53686
11176 * WebCoreSupport/WebInspectorClient.h:
11177 * WebCoreSupport/WebInspectorClient.mm:
11178 (WebInspectorClient::openInspectorFrontend):
11179 (WebInspectorFrontendClient::WebInspectorFrontendClient):
11181 2011-02-03 James Kozianski <koz@chromium.org>
11183 Reviewed by Dimitri Glazkov.
11185 Add navigator.registerProtocolHandler behind a flag.
11186 https://bugs.webkit.org/show_bug.cgi?id=52609
11188 * Configurations/FeatureDefines.xcconfig:
11190 2011-02-03 Adam Langley <agl@chromium.org>
11192 Reviewed by Adam Barth.
11194 Plumb mixed script URL to FrameLoaderClient
11195 https://bugs.webkit.org/show_bug.cgi?id=52384
11197 Regressions covered by http/tests/security/mixedContent/*
11199 * WebCoreSupport/WebFrameLoaderClient.h:
11200 * WebCoreSupport/WebFrameLoaderClient.mm:
11201 (WebFrameLoaderClient::didRunInsecureContent):
11203 2011-02-03 Beth Dakin <bdakin@apple.com>
11205 Reviewed by Sam Weinig.
11207 Fix for <rdar://problem/8944544> Ability to animate track
11208 for WKPainter scrollers
11210 * WebCoreSupport/WebSystemInterface.mm:
11211 (InitWebCoreSystemInterface):
11213 2011-02-02 Mark Rowe <mrowe@apple.com>
11215 Reviewed by Beth Dakin.
11217 <rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().
11219 * WebCoreSupport/WebSystemInterface.mm:
11220 (InitWebCoreSystemInterface): Add some missing initializers.
11222 2011-02-02 Steve Lacey <sjl@chromium.org>
11224 Reviewed by Eric Carlson.
11226 Implement basic media statistics on media elements.
11227 https://bugs.webkit.org/show_bug.cgi?id=53322
11229 * Configurations/FeatureDefines.xcconfig:
11231 2011-02-01 Sam Weinig <sam@webkit.org>
11233 Reviewed by Beth Dakin.
11235 Part 2 for <rdar://problem/8492788>
11236 Adopt WKScrollbarPainterController
11238 Use header detection to define scrollbar painting controller #define.
11240 * WebCoreSupport/WebSystemInterface.mm:
11241 (InitWebCoreSystemInterface):
11243 2011-02-01 David Hyatt <hyatt@apple.com>
11245 Reviewed by Oliver Hunt.
11247 https://bugs.webkit.org/show_bug.cgi?id=53520
11249 Remove the physical terminology from IntRect and FloatRect.
11251 Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
11252 we need to update our terminology to be more accurate.
11254 I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
11255 renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
11256 even for flipped rectangles.
11258 * WebView/WebHTMLView.mm:
11259 (setNeedsDisplayInRect):
11261 2011-02-01 Beth Dakin <bdakin@apple.com>
11263 Reviewed by Sam Weinig.
11265 Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController
11267 * WebCoreSupport/WebSystemInterface.mm:
11268 (InitWebCoreSystemInterface):
11270 2011-02-01 Dave Hyatt <hyatt@apple.com>
11272 Reviewed by Darin Adler.
11274 https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
11275 with vertical text.
11277 Change printing functions to check writing-mode and properly swap width and height
11280 * WebView/WebDynamicScrollBarsView.mm:
11281 (-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):
11282 * WebView/WebFrame.mm:
11283 (-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
11284 * WebView/WebFrameInternal.h:
11285 * WebView/WebHTMLView.mm:
11286 (-[WebHTMLView _web_setPrintingModeRecursive]):
11287 (-[WebHTMLView _web_clearPrintingModeRecursive]):
11288 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
11289 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
11290 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
11291 (-[WebHTMLView _endPrintMode]):
11292 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
11293 (-[WebHTMLView _endScreenPaginationMode]):
11294 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
11295 (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
11296 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
11297 (-[WebHTMLView _scaleFactorForPrintOperation:]):
11298 (-[WebHTMLView setPageWidthForPrinting:]):
11299 (-[WebHTMLView knowsPageRange:]):
11301 2011-01-31 Oliver Hunt <oliver@apple.com>
11303 Convert markstack to a slot visitor API
11304 https://bugs.webkit.org/show_bug.cgi?id=53219
11306 rolling r77098, r77099, r77100, r77109, and
11307 r77111 back in, along with a few more Qt fix attempts.
11309 * WebView/WebScriptDebugDelegate.mm:
11310 (-[WebScriptCallFrame scopeChain]):
11312 2011-01-30 Csaba Osztrogonác <ossy@webkit.org>
11314 Unreviewed, rolling out r77098, r77099, r77100, r77109, and
11316 http://trac.webkit.org/changeset/77098
11317 http://trac.webkit.org/changeset/77099
11318 http://trac.webkit.org/changeset/77100
11319 http://trac.webkit.org/changeset/77109
11320 http://trac.webkit.org/changeset/77111
11321 https://bugs.webkit.org/show_bug.cgi?id=53219
11325 * WebView/WebScriptDebugDelegate.mm:
11326 (-[WebScriptCallFrame scopeChain]):
11328 2011-01-30 Oliver Hunt <oliver@apple.com>
11330 Convert markstack to a slot visitor API
11331 https://bugs.webkit.org/show_bug.cgi?id=53219
11333 rolling r77006 and r77020 back in.
11335 * WebView/WebScriptDebugDelegate.mm:
11336 (-[WebScriptCallFrame scopeChain]):
11338 2011-01-28 Geoffrey Garen <ggaren@apple.com>
11340 Reviewed by Maciej Stachowiak.
11342 Some more Heap cleanup.
11343 https://bugs.webkit.org/show_bug.cgi?id=53357
11345 Updated for JavaScriptCore changes.
11347 * Misc/WebCoreStatistics.mm:
11348 (+[WebCoreStatistics memoryStatistics]):
11350 2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>
11352 Unreviewed, rolling out r77006 and r77020.
11353 http://trac.webkit.org/changeset/77006
11354 http://trac.webkit.org/changeset/77020
11355 https://bugs.webkit.org/show_bug.cgi?id=53360
11357 "Broke Windows tests" (Requested by rniwa on #webkit).
11359 * WebView/WebScriptDebugDelegate.mm:
11360 (-[WebScriptCallFrame scopeChain]):
11362 2011-01-27 Oliver Hunt <oliver@apple.com>
11364 Reviewed by Geoffrey Garen.
11366 Convert markstack to a slot visitor API
11367 https://bugs.webkit.org/show_bug.cgi?id=53219
11369 Update to new marking api
11371 * WebView/WebScriptDebugDelegate.mm:
11372 (-[WebScriptCallFrame scopeChain]):
11374 2011-01-28 Dan Bernstein <mitz@apple.com>
11376 Reviewed by Sam Weinig.
11378 <select> can't display right-to-left (rtl) languages
11379 https://bugs.webkit.org/show_bug.cgi?id=19785
11381 * WebCoreSupport/WebChromeClient.h:
11382 * WebCoreSupport/WebChromeClient.mm:
11383 (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
11384 (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
11386 2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
11388 Unreviewed, rolling out r76891.
11389 http://trac.webkit.org/changeset/76891
11390 https://bugs.webkit.org/show_bug.cgi?id=53280
11392 Makes every layout test crash (Requested by othermaciej on
11395 * Misc/WebIconDatabase.mm:
11396 (-[ThreadEnabler threadEnablingSelector:]):
11397 (importToWebCoreFormat):
11399 2011-01-27 Nate Chapin <japhet@chromium.org>
11401 Reviewed by Adam Barth.
11403 Use Document::url() instead of FrameLoader::url().
11404 https://bugs.webkit.org/show_bug.cgi?id=41165
11406 * WebView/WebView.mm:
11407 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
11409 2011-01-27 Dan Bernstein <mitz@apple.com>
11411 Rubber-stamped by Anders Carlsson.
11413 Reverted an accidental change in r76561.
11415 * WebView/WebHTMLView.mm:
11417 2011-01-26 David Kilzer <ddkilzer@apple.com>
11419 <http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
11420 <rdar://problem/8821760>
11422 Reviewed by Antti Koivisto.
11424 * WebCoreSupport/WebSystemInterface.mm:
11425 (InitWebCoreSystemInterface): Added initialization for
11426 GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.
11428 2011-01-26 Beth Dakin <bdakin@apple.com>
11430 Reviewed by Darin Adler.
11432 Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
11433 when using WKScrollbars.
11435 * WebCoreSupport/WebSystemInterface.mm:
11436 (InitWebCoreSystemInterface):
11438 2011-01-25 Darin Adler <darin@apple.com>
11440 Reviewed by Anders Carlsson.
11442 WebKit is using CSBackupSetItemExcluded incorrectly
11443 https://bugs.webkit.org/show_bug.cgi?id=53095
11444 rdar://problem/8790540
11446 * Misc/WebIconDatabase.mm:
11447 (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded.
11448 It was incorrect, and this responsibility has been moved to WebCore.
11450 2011-01-24 Chris Marrin <cmarrin@apple.com>
11452 Reviewed by Eric Seidel.
11454 Change ENABLE_3D_CANVAS to ENABLE_WEBGL
11455 https://bugs.webkit.org/show_bug.cgi?id=53041
11457 * Configurations/FeatureDefines.xcconfig:
11459 2011-01-25 Yury Semikhatsky <yurys@chromium.org>
11461 Reviewed by Pavel Feldman.
11463 Web Inspector: remove "attached" state related methods from InspectorAgent
11464 https://bugs.webkit.org/show_bug.cgi?id=53086
11466 * WebCoreSupport/WebInspectorClient.h:
11467 * WebCoreSupport/WebInspectorClient.mm:
11468 (-[WebInspectorWindowController showWindow:]):
11469 (-[WebInspectorWindowController attach]):
11470 (-[WebInspectorWindowController detach]):
11472 2011-01-23 Dan Bernstein <mitz@apple.com>
11474 Reviewed by John Sullivan.
11476 <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
11478 * WebCoreSupport/WebChromeClient.mm:
11479 (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
11481 2011-01-22 Alexey Proskuryakov <ap@apple.com>
11483 Reviewed by Darin Adler.
11485 https://bugs.webkit.org/show_bug.cgi?id=52473
11486 Auto-scaling to avoid orphans is broken, remove dysfunctional code
11488 * WebView/WebHTMLView.mm:
11489 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
11490 (-[WebHTMLView _scaleFactorForPrintOperation:]):
11491 (-[WebHTMLView knowsPageRange:]):
11493 2011-01-21 Mark Rowe <mrowe@apple.com>
11495 Rubber-stamped by Jon Honeycutt.
11497 Fix the build when using Clang by removing some unused variables.
11499 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11500 (-[WebHostedNetscapePluginView updateAndSetWindow]):
11501 * WebView/WebFullScreenController.mm:
11502 (-[WebFullScreenController enterFullscreen:]):
11503 (-[WebFullScreenController exitFullscreen]):
11505 2011-01-21 Chris Rogers <crogers@google.com>
11507 Reviewed by Darin Fisher.
11509 Add run-time enable support for the web audio API
11510 https://bugs.webkit.org/show_bug.cgi?id=52741
11512 * WebView/WebPreferenceKeysPrivate.h:
11513 * WebView/WebPreferences.mm:
11514 (-[WebPreferences webAudioEnabled]):
11515 (-[WebPreferences setWebAudioEnabled:]):
11516 * WebView/WebPreferencesPrivate.h:
11517 * WebView/WebView.mm:
11518 (-[WebView _preferencesChangedNotification:]):
11520 2011-01-20 John Sullivan <sullivan@apple.com>
11522 Reviewed by Mark Rowe.
11524 Shift-tab doesn't cycle through fields in http authentication panel
11525 https://bugs.webkit.org/show_bug.cgi?id=52850
11527 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
11528 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
11529 Re-wired the key loop so that there aren't two views with the same nextKeyView.
11531 2011-01-20 Beth Dakin <bdakin@apple.com>
11533 Reviewed by Geoffrey Garen.
11535 Fix for <rdar://problem/8890255>
11537 Allow WebKitSystemInterface to draw scrollbars
11539 * WebCoreSupport/WebSystemInterface.mm:
11540 (InitWebCoreSystemInterface):
11542 2011-01-19 Simon Fraser <simon.fraser@apple.com>
11544 Reviewed by Sam Weinig.
11546 GraphicsLayers in subframes can get sync'd multiple times
11547 https://bugs.webkit.org/show_bug.cgi?id=52489
11549 * WebView/WebView.mm:
11550 (-[WebView _syncCompositingChanges]): syncCompositingStateRecursive()
11551 was renamed to syncCompositingStateIncludingSubframes().
11553 2011-01-19 Darin Adler <darin@apple.com>
11555 Reviewed by Sam Weinig.
11557 Would like script debugging protocol method to differentiate between caught and uncaught exceptions
11558 https://bugs.webkit.org/show_bug.cgi?id=52104
11559 rdar://problem/8704226
11561 * WebView/WebDelegateImplementationCaching.h:
11562 Fix type of second integer in CallScriptDebugDelegate function overload
11563 to be int to match the actual Objective-C method. Added a new overload
11564 that includes a BOOL in the right place. Added a boolean named
11565 exceptionWasRaisedExpectsHasHandlerFlag.
11567 * WebView/WebDelegateImplementationCaching.mm:
11568 (CallDelegate): Added overloads as above.
11569 (CallScriptDebugDelegate): Ditto.
11571 * WebView/WebScriptDebugDelegate.h: Added new method with the additional
11572 boolean argument. Marked the old method informally deprecated.
11574 * WebView/WebScriptDebugger.mm:
11575 (WebScriptDebugger::exception): Added code to call with or without the
11576 boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
11578 * WebView/WebView.mm:
11579 (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the
11580 exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not
11581 guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
11583 2011-01-19 Tony Gentilcore <tonyg@chromium.org>
11585 Reviewed by Mihai Parparita.
11587 Perform some forward declaration
11588 https://bugs.webkit.org/show_bug.cgi?id=52522
11590 * Misc/WebKitNSStringExtras.mm:
11592 2011-01-19 Pavel Podivilov <podivilov@chromium.org>
11594 Reviewed by Yury Semikhatsky.
11596 Web Inspector: [JSC] scripts have incorrect starting line (always 1).
11597 https://bugs.webkit.org/show_bug.cgi?id=52721
11599 * WebView/WebScriptDebugger.h:
11600 * WebView/WebScriptDebugger.mm:
11602 (WebScriptDebugger::sourceParsed):
11604 2011-01-19 Levi Weintraub <leviw@google.com>
11606 Reviewed by Ryosuke Niwa.
11608 Updating to use Position::parentAnchoredEquivalent instead of
11609 the old htmlediting rangeCompliantEquivalent.
11611 remove rangeCompliantEquivalent and replace it with Position methods
11612 https://bugs.webkit.org/show_bug.cgi?id=25057
11614 * WebView/WebFrame.mm:
11615 (-[WebFrame _smartDeleteRangeForProposedRange:]):
11617 2011-01-18 Chris Fleizach <cfleizach@apple.com>
11619 Reviewed by Darin Adler.
11621 REGRESSION: A problem with Voiceover and finding links
11622 https://bugs.webkit.org/show_bug.cgi?id=52324
11624 * WebView/WebDynamicScrollBarsView.mm:
11625 (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
11627 2011-01-17 David Kilzer <ddkilzer@apple.com>
11629 <http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project
11631 Reviewed by Dan Bernstein.
11633 * MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and
11634 DOMDocumentPrivate.h to the PrivateHeaders directory.
11636 2011-01-17 Enrica Casucci <enrica@apple.com>
11638 Reviewed by Alexey Proskuryakov.
11640 Drag and drop support: refactoring of image from link and image from selection
11641 https://bugs.webkit.org/show_bug.cgi?id=52496
11643 This work cleans up the Mac code and makes it more similar to the Windows implementation,
11644 avoiding the use of an NSView when the FrameView can be used.
11645 The refactoring is a necessary step towards the complete support of drag and drop
11648 * WebCoreSupport/WebDragClient.mm:
11649 (WebDragClient::createDragImageForLink): Added.
11650 * WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
11651 * WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
11653 2011-01-17 Pavel Feldman <pfeldman@chromium.org>
11655 Reviewed by Yury Semikhatsky.
11657 Web Inspector: simplify debugger enabling routine.
11658 https://bugs.webkit.org/show_bug.cgi?id=52472
11660 * WebInspector/WebInspector.mm:
11661 (-[WebInspector startDebuggingJavaScript:]):
11663 2011-01-16 Dan Bernstein <mitz@apple.com>
11665 Reviewed by Simon Fraser.
11667 Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
11668 https://bugs.webkit.org/show_bug.cgi?id=52550
11670 * Plugins/WebNetscapePluginView.mm:
11671 (-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
11672 that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.
11674 2011-01-16 Simon Fraser <simon.fraser@apple.com>
11676 Reviewed by Dan Bernstein.
11678 Issues with iframes and plugins when the WebView is scaled.
11679 <rdar://problem/6213380>
11681 When _scaleWebView has been called on a WebView, iframes
11682 in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
11683 This is caused by AppKit NSViews not playing nicely with the scale
11684 applied through style.
11686 Work around most of these issues by adjusting the bounds size
11687 of widgets to allow iframe contents to paint with the correct scale,
11688 and fix various places in the code where we relied on coordinate
11689 transforms via NSViews (which ignore CSS transforms).
11691 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11692 (-[WebHostedNetscapePluginView updateAndSetWindow]):
11693 * WebView/WebFrameView.mm:
11694 (-[WebFrameView setBoundsSize:]):
11696 2011-01-16 Beth Dakin <bdakin@apple.com>
11698 Reviewed by Kevin Decker.
11700 Fix for <rdar://problem/8871204>
11702 Don't try to save elasticity state. Just rely on
11703 NSScrollElasticityAutomatic to restore the correct state.
11704 * WebCoreSupport/WebFrameLoaderClient.h:
11705 * WebCoreSupport/WebFrameLoaderClient.mm:
11706 (WebFrameLoaderClient::WebFrameLoaderClient):
11707 (WebFrameLoaderClient::dispatchDidFirstLayout):
11708 (WebFrameLoaderClient::provisionalLoadStarted):
11710 2011-01-14 Simon Fraser <simon.fraser@apple.com>
11712 Reviewed by Dan Bernstein.
11714 Plugins render incorrectly with transformed ancestors
11715 https://bugs.webkit.org/show_bug.cgi?id=52507
11717 -[NSView visibleRect] gives the wrong answer if there are CSS transforms
11718 in the ancestor chain of a plugin.
11720 So use of this method with calls to -actualVisibleRectInWindow, which
11721 maps rects through the render tree to compute the correct rect,
11722 clipping via windowClipRect() if necessary.
11724 Not testable, because doing so relies on the behavior of some
11725 plugins, which stop rendering if setWindow passes an empty rect.
11727 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
11728 (-[WebHostedNetscapePluginView updateAndSetWindow]):
11729 * Plugins/WebBaseNetscapePluginView.h:
11730 * Plugins/WebBaseNetscapePluginView.mm:
11731 (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
11732 * Plugins/WebNetscapePluginView.mm:
11733 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
11735 2011-01-14 Yuzo Fujishima <yuzo@google.com>
11737 Reviewed by Antti Koivisto.
11739 Rename cache() to memoryCache()
11740 https://bugs.webkit.org/show_bug.cgi?id=52433
11742 * Misc/WebCache.mm:
11743 (+[WebCache statistics]):
11744 (+[WebCache setDisabled:]):
11745 (+[WebCache isDisabled]):
11746 * WebView/WebView.mm:
11747 (+[WebView _setCacheModel:]):
11749 2011-01-13 Geoffrey Garen <ggaren@apple.com>
11751 Reviewed by Oliver Hunt.
11753 Split out a MarkedSpace strategy object from Heap.
11754 https://bugs.webkit.org/show_bug.cgi?id=52421
11756 * Misc/WebCoreStatistics.mm:
11757 (+[WebCoreStatistics memoryStatistics]): Updated for class move.
11759 2011-01-14 Dan Bernstein <mitz@apple.com>
11761 Reviewed by Simon Fraser.
11763 WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
11765 * WebView/WebHTMLView.mm:
11766 (-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
11767 to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
11768 that the NSView tree doesn’t change from under AppKit as it traverses it.
11770 2011-01-14 Beth Dakin <bdakin@apple.com>
11772 Reviewed by Mark Rowe.
11774 Fix for <rdar://problem/7793902> Artifacts when scrolling
11775 page in Safari while page is loading
11777 Call setDrawsBackground:YES on the scrollView in
11778 dispatchDidFirstLayout() rather than waiting until
11779 frameLoadCompleted(). Also suspend scrolling elasticity
11780 between provisionalLoadStarted() and dispatchDidFirstLayout()
11781 * WebCoreSupport/WebFrameLoaderClient.h:
11782 * WebCoreSupport/WebFrameLoaderClient.mm:
11783 (WebFrameLoaderClient::WebFrameLoaderClient):
11784 (WebFrameLoaderClient::dispatchDidFirstLayout):
11785 (WebFrameLoaderClient::provisionalLoadStarted):
11787 2011-01-12 Enrica Casucci <enrica@apple.com>
11789 Reviewed by Darin Adler.
11791 WebKit2: Add support for drag and drop
11792 https://bugs.webkit.org/show_bug.cgi?id=52343
11793 <rdar://problem/7660558>
11795 The DragData class has been extended to provide
11796 additional context from the application (keyboard state, modal windows, etc.)
11797 as well as information of the drag pasteboard being used.
11798 These are the changes to align the behavior for WebKit.
11800 * WebView/WebView.mm:
11801 (-[WebView applicationFlags:]): Added.
11802 (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
11803 (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
11804 (-[WebView draggingExited:]): Added parameter to the DragData constructor.
11805 (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
11807 2011-01-12 Beth Dakin <bdakin@apple.com>
11809 Reviewed by Anders Carlsson.
11811 Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
11812 Expose fixed layout through WebKit SPI
11813 -and corresponding-
11814 <rdar://problem/8844464>
11816 And now with getters!
11817 * WebView/WebView.mm:
11818 (-[WebView _useFixedLayout]):
11819 (-[WebView _fixedLayoutSize]):
11820 * WebView/WebViewPrivate.h:
11822 2011-01-12 Beth Dakin <bdakin@apple.com>
11824 Reviewed by Anders Carlsson.
11826 Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
11827 fixed layout through WebKit SPI
11828 -and corresponding-
11829 <rdar://problem/8844464>
11831 * WebView/WebView.mm:
11832 (-[WebView _setUseFixedLayout:]):
11833 (-[WebView _setFixedLayoutSize:]):
11834 * WebView/WebViewPrivate.h:
11836 2011-01-07 Enrica Casucci <enrica@apple.com>
11838 Reviewed by Alexey Proskuryakov.
11840 Paste and drag and drop use different code paths to interact with the pasteboard.
11841 https://bugs.webkit.org/show_bug.cgi?id=52093
11842 The change consists in a refactoring of the code to have only one class that
11843 deals with the pasteboard on Mac.
11845 * WebCoreSupport/WebEditorClient.h:
11846 * WebCoreSupport/WebEditorClient.mm: Added two methods to provide to WebCore functionality
11847 exposed by NSURLExtras.
11848 (WebEditorClient::canonicalizeURL):
11849 (WebEditorClient::canonicalizeURLString):
11850 * WebCoreSupport/WebPasteboardHelper.h: Removed.
11851 * WebCoreSupport/WebPasteboardHelper.mm: Removed.
11852 * WebView/WebHTMLView.mm: Removed comment.
11853 * WebView/WebView.mm: The following methods have been changed to use the new DragData
11854 constructor that doesn't use the WebPasteboardHelper reference.
11855 (-[WebView draggingEntered:]):
11856 (-[WebView draggingUpdated:]):
11857 (-[WebView draggingExited:]):
11858 (-[WebView performDragOperation:]):
11860 2011-01-09 Tony Gentilcore <tonyg@chromium.org>
11862 Reviewed by Alexey Proskuryakov.
11864 Forward declare some headers where possible
11865 https://bugs.webkit.org/show_bug.cgi?id=52133
11867 * WebView/WebFrame.mm:
11869 2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
11871 Reviewed by Darin Fisher.
11873 https://bugs.webkit.org/show_bug.cgi?id=41441
11874 createWindow method should only do window-creating without URL navigation
11876 * WebCoreSupport/WebChromeClient.mm:
11877 (WebChromeClient::createWindow):
11879 2011-01-08 Dan Bernstein <mitz@apple.com>
11881 Try to fix the Leopard build.
11883 * WebView/WebFullScreenController.mm:
11885 2011-01-07 Jer Noble <jer.noble@apple.com>
11887 Yet another Leopard build fix: NSRect and CGRect are not inter-
11888 changable in 32-bit.
11890 * WebView/WebFullScreenController.mm:
11891 (-[WebFullScreenController exitFullscreen]):
11893 2011-01-07 Jer Noble <jer.noble@apple.com>
11895 Fix the Leopard build: Replace CoreAnimation SL-only functions
11896 with Leopard equivalents.
11898 * WebView/WebFullScreenController.mm:
11899 (+[CATransaction setDisableActions:]):
11900 (+[CATransaction setAnimationDuration:]):
11901 (-[WebFullScreenController _animationDuration]):
11902 (-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
11904 2010-12-21 Jer Noble <jer.noble@apple.com>
11906 Reviewed by Simon Fraser.
11908 Implement WebKit Full Screen support.
11909 https://bugs.webkit.org/show_bug.cgi?id=49481
11910 rdar://problem/8247444
11912 Support the new fullscreen Chrome client requests. WebView will pass
11913 through these requests to a WebFullscreenController.
11915 * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
11916 * WebView/WebView.mm:
11917 (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
11918 (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
11919 (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
11920 (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
11921 * WebView/WebViewData.h: Add ivar newFullscreenController.
11923 2010-12-17 Jer Noble <jer@kokode.apple.com>
11925 Reviewed by Simon Fraser.
11927 Implement WebKit Full Screen support.
11928 https://bugs.webkit.org/show_bug.cgi?id=49481
11929 rdar://problem/8247444
11931 This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
11932 Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
11933 window, and a custom CAAnimation animates that layer between the initial screen rect of the
11934 full screen element, to its final value. WebFullscreenController will swap the WebView out of
11935 its original window, and into the fullscreen window. The controller will replace the WebView
11936 with a placeholder view, so that if the placeholder moves or resized while the WebView is
11937 absent, the WebView will move back to the correct location when exiting fullscreen.
11939 * WebView/WebFullscreenController.h: Added.
11940 * WebView/WebFullscreenController.mm: Added.
11941 (-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
11942 (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
11943 (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
11944 (-[WebFullscreenController applicationDidResignActive:]):
11945 (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
11946 the new screen parameters.
11947 (-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element
11948 from its original screen rect into fullscreen.
11949 (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
11950 Set up the animation that will take the fullscreen element back into its original screen
11952 (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
11953 whether to disable screensaver and sleep.
11954 (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
11955 looking for HTMLVideoElements; returns whether any are found to be playing.
11956 (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
11958 (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
11959 (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
11960 (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
11961 (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
11962 (-[WebFullscreenWindow setRendererLayer:]): Ditto.
11963 (-[WebFullscreenWindow backgroundLayer]): Ditto.
11964 (-[WebFullscreenWindow animationView]): Ditto.
11965 (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
11966 (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
11968 2011-01-07 James Robinson <jamesr@chromium.org>
11970 Revert "Implement mozilla's animationTime property"
11971 https://bugs.webkit.org/show_bug.cgi?id=51952
11973 This approach isn't quite right.
11975 * WebView/WebHTMLView.mm:
11976 (-[WebHTMLView drawRect:]):
11977 * WebView/WebView.mm:
11978 (layerSyncRunLoopObserverCallBack):
11980 2011-01-06 Gavin Barraclough <barraclough@apple.com>
11982 Reviewed by Geoff Garen.
11984 Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
11986 The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
11987 destructor early, in order to release wrappers once we know we no longer intend to use them.
11988 Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
11989 lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
11990 A sequence of events that triggers the bug would look like this:
11992 (1) Create a DOMWrapperWorld.
11993 (2) Register a timer in the world.
11994 (3) Call unregisterWorld() on the world.
11995 (4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
11996 (5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
11997 called forgetWorld() none exists.
11998 (6) Attempt to add a wrapper to a NULL map.
12000 Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
12002 * WebView/WebScriptWorld.mm:
12003 (-[WebScriptWorld unregisterWorld]):
12005 2011-01-04 Chris Fleizach <cfleizach@apple.com>
12007 Reviewed by Sam Weinig.
12009 WK2: Support Accessibility
12010 https://bugs.webkit.org/show_bug.cgi?id=51859
12012 Use rootObject() method to get top of AX tree.
12014 * WebCoreSupport/WebFrameLoaderClient.h:
12015 (WebFrameLoaderClient::accessibilityRemoteObject):
12016 * WebView/WebFrame.mm:
12017 (-[WebFrame setAccessibleName:]):
12018 (-[WebFrame accessibilityRoot]):
12019 * WebView/WebFrameInternal.h:
12020 * WebView/WebFramePrivate.h:
12021 * WebView/WebHTMLView.mm:
12022 (-[WebHTMLView accessibilityAttributeValue:]):
12023 (-[WebHTMLView accessibilityFocusedUIElement]):
12024 (-[WebHTMLView accessibilityHitTest:]):
12025 (-[WebHTMLView _accessibilityParentForSubview:]):
12027 2011-01-04 David Kilzer <ddkilzer@apple.com>
12029 <http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name
12031 Reviewed by Eric Carlson.
12033 This originally broke in r61581. It is inside an
12034 ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
12037 * WebCoreSupport/WebFrameLoaderClient.mm: Call
12038 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
12039 use WebCore::PluginInfo.name instead of
12040 -[WebBasePluginPackage name].
12042 2011-01-02 Dan Bernstein <mitz@apple.com>
12044 Rubber-stamped by Simon Fraser.
12046 <rdar://problem/8812159> Update copyright strings
12050 2010-12-29 Dan Bernstein <mitz@apple.com>
12052 Reviewed by Ada Chan.
12054 <rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
12055 https://bugs.webkit.org/show_bug.cgi?id=51717
12057 Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
12058 protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.
12060 * WebView/WebDocumentInternal.h:
12061 * WebView/WebHTMLView.mm:
12062 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
12063 (-[WebHTMLView _findString:options:]):
12064 * WebView/WebView.mm:
12067 2010-12-28 Daniel Bates <dbates@rim.com>
12069 Reviewed by Sam Weinig.
12071 Substitute // MARK: for compiler-specific #pragma mark
12072 https://bugs.webkit.org/show_bug.cgi?id=51657
12074 For consistency, we should substitute "// MARK:" for compiler-
12075 specific "#pragma mark" in the source files for the Mac port.
12077 * History/WebHistory.mm:
12078 * Plugins/WebBaseNetscapePluginView.mm:
12079 * Plugins/WebNetscapePluginView.mm:
12080 * WebCoreSupport/WebInspectorClient.mm:
12081 * WebCoreSupport/WebSecurityOrigin.mm:
12082 * WebView/WebPDFView.mm:
12083 * WebView/WebVideoFullscreenController.mm:
12084 * WebView/WebVideoFullscreenHUDWindowController.mm:
12086 2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>
12088 Reviewed by Darin Adler.
12090 WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
12091 https://bugs.webkit.org/show_bug.cgi?id=38535
12093 WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result,
12094 if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
12095 WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top
12096 call frame from this stack when an exception throws because the saved top frame could be invalid.
12098 To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
12099 callEvent and returnEvent.
12101 * WebView/WebScriptDebugger.mm:
12102 (WebScriptDebugger::willExecuteProgram):
12103 (WebScriptDebugger::didExecuteProgram):
12105 2010-12-22 Sam Weinig <sam@webkit.org>
12107 Reviewed by Darin Adler.
12109 WebKit2 needs to mirror the frame tree in the UIProcess
12110 https://bugs.webkit.org/show_bug.cgi?id=51546
12112 - Add client functions to notify that a frame has been added or
12113 removed from the page cache.
12115 * WebCoreSupport/WebFrameLoaderClient.h:
12116 * WebCoreSupport/WebFrameLoaderClient.mm:
12117 (WebFrameLoaderClient::didSaveToPageCache):
12118 (WebFrameLoaderClient::didRestoreFromPageCache):
12120 2010-12-22 Ryosuke Niwa <rniwa@webkit.org>
12122 Reviewed by Eric Seidel.
12124 Editor.h doesn't need to include SelectionController.h
12125 https://bugs.webkit.org/show_bug.cgi?id=51441
12127 Renamed SelectionController::EDirection to SelectionDirection.
12129 * WebView/WebFrame.mm:
12130 (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
12131 Takes SelectionDirection instead of SelectionController::EDirection.
12132 * WebView/WebFrameInternal.h:
12133 * WebView/WebTextCompletionController.mm:
12134 (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
12136 2010-12-22 Simon Fraser <simon.fraser@apple.com>
12138 Reviewed by Darin Adler.
12140 Cache snapshots of plug-ins before painting, to avoid script running during painting
12141 https://bugs.webkit.org/show_bug.cgi?id=51493
12143 When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
12144 or when printing), plug-ins which otherwise use the CA rendering model
12145 are sent a paint event. Some plug-ins may run script while handling this event,
12146 or out of process plug-ins may process queued requests at this time. Running
12147 script while inside layout or painting can have bad consequences, because it
12148 can result in arbitrary changes to the render tree.
12150 This patch avoids sending plug-ins paint events inside of painting. Instead,
12151 we ask the plug-ins to cache a snapshot before we paint, and then the software
12152 paint simply draws that snapshot.
12154 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
12155 (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot,
12156 draw it. Also only send the snapshot message to the plugin proxy if we
12157 know we're snapshotting, since even if creating the snapshot image failed,
12158 we still don't want to call to the plug-in.
12160 * Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
12161 * Plugins/WebBaseNetscapePluginView.mm:
12162 (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it.
12163 (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
12165 * Plugins/WebNetscapePluginView.mm:
12166 (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
12167 * WebCoreSupport/WebFrameLoaderClient.mm:
12168 (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it
12169 to cache and clear the snapshots.
12171 2010-12-21 Cameron Zwarich <zwarich@apple.com>
12173 Reviewed by Darin Adler.
12175 -[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
12176 https://bugs.webkit.org/show_bug.cgi?id=51431
12177 <rdar://problem/8791757>
12179 * Plugins/WebBasePluginPackage.mm:
12180 (-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
12181 it doesn't underflow.
12183 2010-12-16 Ryosuke Niwa <rniwa@webkit.org>
12185 Reviewed by Cameron Zwarich.
12187 REGRESSION(r74172): 125 java tests fail on Mac
12188 https://bugs.webkit.org/show_bug.cgi?id=51214
12190 The regression was caused by an incorrectly adding sizeof(struct fat_header)
12191 to a pointer for uint32_t as supposed to uint8_t.
12193 Fixed the bug by explicitly casting it to uint8_t* before the addition.
12195 * Plugins/WebBasePluginPackage.mm:
12196 (-[WebBasePluginPackage isNativeLibraryData:]):
12198 2010-12-15 Cameron Zwarich <zwarich@apple.com>
12200 Reviewed by Darin Adler.
12202 Clang -Wcast-align gives an error in WebBasePluginPackage.mm
12203 https://bugs.webkit.org/show_bug.cgi?id=51144
12205 Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
12206 we were calling it on a byte array 32 bits at a time. While this is okay in practice,
12207 since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
12208 inline storage is at the beginning of the Vector, it is still better to fix this
12209 and silence the warning.
12211 * Plugins/WebBasePluginPackage.mm:
12212 (swapIntsInHeader):
12213 (-[WebBasePluginPackage isNativeLibraryData:]):
12215 2010-12-14 Mark Rowe <mrowe@apple.com>
12217 Reviewed by Sam Weinig.
12219 <http://webkit.org/b/51064> Reproducible crash inside WebCore::MediaPlayerPrivateQTKit::createQTMovie when loading <video>
12221 * History/WebHistoryItem.mm:
12222 (-[WebHistoryItem description]): Test whether the string is empty rather than incorrectly
12223 always including the target in the output.
12225 2010-12-13 Alexey Proskuryakov <ap@apple.com>
12227 Reviewed by Adam Barth.
12229 https://bugs.webkit.org/show_bug.cgi?id=50953
12230 DNS Prefetch should be an opt-in feature
12232 * WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default to false.
12234 2010-12-13 Mike Thole <mthole@apple.com>
12236 Rubber-stamped by John Sullivan.
12238 https://bugs.webkit.org/show_bug.cgi?id=50956
12239 WebAuthenticationPanel.nib appears to have a cut-off sentence
12241 Replace the sentence fragment in the sheet layout with "<-- do not localize -->" style text.
12242 The contents of this text field are updated dynamically before the sheet is displayed.
12244 * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
12245 * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
12247 2010-12-13 Antti Koivisto <antti@apple.com>
12249 Reviewed by Alexey Proskuryakov.
12251 https://bugs.webkit.org/show_bug.cgi?id=50758
12252 <rdar://problem/8722094>
12253 Defer loading print stylesheets
12255 Expose SPI for DRT for making resources load serially. This is useful for testing resource load order.
12257 * WebView/WebView.mm:
12258 (+[WebView _setLoadResourcesSerially:forHost:]):
12259 * WebView/WebViewPrivate.h:
12261 2010-12-09 Matthew Delaney <mdelaney@apple.com>
12263 Reviewed by Simon Fraser.
12265 Adopt new CG API for canvas
12266 https://bugs.webkit.org/show_bug.cgi?id=50591
12268 * WebCoreSupport/WebSystemInterface.mm:
12270 2010-10-28 MORITA Hajime <morrita@google.com>
12272 Reviewed by Ojan Vafai.
12274 spellcheck does not check pasted text
12275 https://bugs.webkit.org/show_bug.cgi?id=40092
12277 Added asynchronous spell checking API to WebEditorClient using
12278 -[NSSpellChecker requestCheckingOfString].
12279 Note that WebEditorSpellCheckResponder is a small class to receive
12280 requested spell-checking result. Note that this feature is
12281 disabled at default.
12283 Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
12284 enable the feature from LayoutTestController.
12286 * WebCoreSupport/WebEditorClient.h:
12287 * WebCoreSupport/WebEditorClient.mm:
12288 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
12289 (-[WebEditorSpellCheckResponder perform]):
12290 (toCoreSpellingResult):
12291 (-[WebEditorSpellCheckResponder WTF::WebCore::]):
12292 (WebEditorClient::requestCheckingOfString):
12293 * WebView/WebPreferenceKeysPrivate.h:
12294 * WebView/WebPreferences.mm:
12295 (+[WebPreferences initialize]):
12296 (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
12297 (-[WebPreferences asynchronousSpellCheckingEnabled]):
12298 * WebView/WebPreferencesPrivate.h:
12299 * WebView/WebView.mm:
12300 (-[WebView _preferencesChangedNotification:]):
12302 2010-12-09 Anders Carlsson <andersca@apple.com>
12304 Fix a bug uncovered by clang++.
12306 * WebView/WebHTMLView.mm:
12307 (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
12309 2010-12-09 Anders Carlsson <andersca@apple.com>
12311 Clang++ build fixes.
12313 Silence a couple of warnings.
12315 * WebView/WebFrame.mm:
12316 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
12317 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
12318 * WebView/WebTextCompletionController.mm:
12319 (-[WebTextCompletionController filterKeyDown:]):
12321 2010-12-09 David Hyatt <hyatt@apple.com>
12323 Reviewed by Dan Bernstein.
12325 https://bugs.webkit.org/show_bug.cgi?id=48545, Home/End, PgUp, PgDown should respect
12326 writing-mode. This first part of the patch just patches Mac WebKit 1 views.
12328 * WebView/WebFrameView.mm:
12329 (-[WebFrameView _isVerticalDocument]):
12330 (-[WebFrameView _isFlippedDocument]):
12331 (-[WebFrameView _scrollToEndOfDocument]):
12332 (-[WebFrameView _pageInBlockProgressionDirection:]):
12333 (-[WebFrameView scrollPageUp:]):
12334 (-[WebFrameView scrollPageDown:]):
12336 2010-12-08 Andy Estes <aestes@apple.com>
12338 Reviewed by Darin Adler.
12340 Enable pre-HTML5 parser quirks for Apple Mail.app
12341 https://bugs.webkit.org/show_bug.cgi?id=50727
12343 * WebView/WebView.mm:
12344 (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
12345 application is Mail.app.
12347 2010-12-08 Brian Weinstein <bweinstein@apple.com>
12349 Reviewed by John Sullivan.
12351 REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
12352 https://bugs.webkit.org/show_bug.cgi?id=50683
12354 If our context menu item already has an action, don't overwrite the action with the context menu
12357 * WebView/WebHTMLView.mm:
12358 (setMenuItemTarget):
12360 2010-12-08 Anders Carlsson <andersca@apple.com>
12362 Remove an unused variable.
12364 * WebView/WebDynamicScrollBarsView.mm:
12365 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
12367 2010-12-07 Brian Weinstein <bweinstein@apple.com>
12369 Reviewed by John Sullivan.
12371 Layering Violation in ContextMenu - member variable of type HitTestResult
12372 https://bugs.webkit.org/show_bug.cgi?id=50586
12374 Update users of ContextMenu and ContextMenuController to match where the new functions
12377 * WebCoreSupport/WebContextMenuClient.mm:
12378 (WebContextMenuClient::getCustomMenuFromDefaultItems):
12379 (WebContextMenuClient::contextMenuItemSelected):
12380 * WebView/WebHTMLView.mm:
12381 (-[WebMenuTarget validateMenuItem:]):
12383 2010-12-07 Brian Weinstein <bweinstein@apple.com>
12385 Reviewed by John Sullivan.
12387 Part of Layering Violation in ContextMenu
12388 https://bugs.webkit.org/show_bug.cgi?id=50586
12390 Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
12391 was a layering violation. Also, make sure we set the menu item targets for all menu
12392 items before showing them, because the ContextMenu constructor doesn't do that anymore.
12394 * WebView/WebHTMLView.mm:
12395 (+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
12396 (-[WebMenuTarget WebCore::]): Ditto.
12397 (-[WebMenuTarget setMenuController:WebCore::]): Ditto.
12398 (-[WebMenuTarget forwardContextMenuAction:]): Ditto.
12399 (-[WebMenuTarget validateMenuItem:]): Ditto.
12401 (setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
12402 (setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
12403 submenus), and calls setMenuItemTarget on them.
12404 (-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
12407 2010-12-06 Darin Adler <darin@apple.com>
12409 Reviewed by Sam Weinig.
12411 Pass security origin to make local file decision correctly
12412 https://bugs.webkit.org/show_bug.cgi?id=48603
12414 * WebView/WebPDFView.mm:
12415 (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
12417 2010-12-07 Martin Robinson <mrobinson@igalia.com>
12419 Unreviewed, rolling out r73392.
12420 http://trac.webkit.org/changeset/73392
12421 https://bugs.webkit.org/show_bug.cgi?id=50489
12423 This commit caused crashes on the GTK+ bots
12425 * WebView/WebFrame.mm:
12426 (-[WebFrame _canProvideDocumentSource]):
12428 2010-12-07 Kenichi Ishibashi <bashi@google.com>
12430 Reviewed by Kent Tamura.
12432 Let HTMLObjectElement be a form associated element
12433 https://bugs.webkit.org/show_bug.cgi?id=48821
12435 Modified to use FormAssociatedElement instead of HTMLFormControlElement.
12437 * WebView/WebHTMLRepresentation.mm:
12438 (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
12439 FormAssociatedElement instead of HTMLFormControlElement.
12440 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
12442 2010-12-06 Nate Chapin <japhet@chromium.org>
12444 Reviewed by Adam Barth.
12446 Update calls to DocumentWriter.
12447 https://bugs.webkit.org/show_bug.cgi?id=50489
12449 * WebView/WebFrame.mm:
12450 (-[WebFrame _canProvideDocumentSource]):
12452 2010-12-06 Chris Marrin <cmarrin@apple.com>
12454 Reviewed by Simon Fraser.
12456 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
12457 https://bugs.webkit.org/show_bug.cgi?id=49388
12459 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
12460 GraphicsLayer::platformLayer().
12462 * WebCoreSupport/WebChromeClient.mm:
12463 (WebChromeClient::attachRootGraphicsLayer):
12465 2010-12-04 Dan Bernstein <mitz@apple.com>
12467 Reviewed by Sam Weinig.
12469 WebKit part of <rdar://problem/8145955> Add text search API for counting/marking/highlighting matches in a range
12470 https://bugs.webkit.org/show_bug.cgi?id=50530
12472 * WebView/WebDocumentInternal.h: Added a DOMRange parameter to -countMatchesForText:options:limit:markMatches:
12473 * WebView/WebHTMLView.mm:
12474 (-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter,
12475 which is passed through to WebCore.
12476 * WebView/WebPDFView.mm:
12477 (isFrameInRange): Added this helper function.
12478 (-[WebPDFView countMatchesForText:inDOMRange:options:limit:markMatches:]): Added DOMRange parameter and
12479 a check if the frame is in the range.
12480 * WebView/WebView.mm:
12481 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Now calls the inDOMRange: version.
12482 (-[WebView countMatchesForText:inDOMRange:options:highlight:limit:markMatches:]): Added DOMRange
12483 parameter, which is passed to document views' -countMatchesForText:inDOMRange:options:limit:markMatches:.
12484 * WebView/WebViewPrivate.h:
12486 2010-12-03 Sam Weinig <sam@webkit.org>
12488 Reviewed by Maciej Stachowiak.
12490 Enable <a ping> for Mac/Windows/WebKit2 builds
12491 <rdar://problem/8504473>
12492 https://bugs.webkit.org/show_bug.cgi?id=50488
12494 * WebView/WebPreferences.mm:
12495 (+[WebPreferences initialize]): Enable "HyperlinkAuditing" by default.
12497 2010-12-03 Jia Pu <jpu@apple.com>
12499 Reviewed by Darin Adler.
12501 Need to move all code that applies correction into correction panel callback.
12502 https://bugs.webkit.org/show_bug.cgi?id=50426
12503 <rdar://problem/8720832>
12505 * WebCoreSupport/WebEditorClient.h: Adopted new signature of dismissCorrectionPanel.
12507 * WebCoreSupport/WebEditorClient.mm:
12508 (WebEditorClient::~WebEditorClient): Adopted new signature of dismissCorrectionPanel.
12509 (WebEditorClient::showCorrectionPanel): Added more user dictionary learning code.
12510 (WebEditorClient::dismissCorrectionPanel): Adopted new signature of dismissCorrectionPanel.
12512 2010-12-02 Simon Fraser <simon.fraser@apple.com>
12514 Revert r73217 and r73227 because of continued bustage.
12516 * WebCoreSupport/WebChromeClient.mm:
12517 (WebChromeClient::attachRootGraphicsLayer):
12519 2010-12-02 Chris Marrin <cmarrin@apple.com>
12521 Reviewed by Simon Fraser.
12523 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
12524 https://bugs.webkit.org/show_bug.cgi?id=49388
12526 Got rid of GraphicsLayer::nativeLayer() call, replacing it with
12527 GraphicsLayer::platformLayer().
12529 * WebCoreSupport/WebChromeClient.mm:
12530 (WebChromeClient::attachRootGraphicsLayer):
12532 2010-12-02 Mark Rowe <mrowe@apple.com>
12534 Reviewed by Beth Dakin.
12536 <rdar://problem/8708730> Objects reported as being leaked due to lack of autorelease pool
12538 * Misc/WebNSFileManagerExtras.m:
12539 (setMetaData): Create an autorelease pool for the duration of the thread body.
12541 2010-12-02 John Knottenbelt <jknotten@chromium.org>
12543 Reviewed by Steve Block.
12545 Move requestGeolocationPermissionForFrame to GeolocationClient
12546 https://bugs.webkit.org/show_bug.cgi?id=50061
12548 This change facilitates client-based geolocation implementation by
12549 bringing together permission control into the geolocation client
12552 Move method ChromeClient::requestGeolocationPermissionForFrame to
12553 GeolocationClient::requestPermission, and supporting class
12554 WebGeolocationPolicyListener. The moved code is unchanged except
12555 that requestPermission now takes only one argument (Geolocation*)
12556 and the Frame parameter is retrieved from the Geolocation object.
12558 * WebCoreSupport/WebChromeClient.h:
12559 * WebCoreSupport/WebChromeClient.mm:
12560 * WebCoreSupport/WebGeolocationClient.h:
12561 (WebGeolocationClient::cancelPermissionRequest):
12562 * WebCoreSupport/WebGeolocationClient.mm:
12563 (WebGeolocationClient::requestPermission):
12564 (-[WebGeolocationPolicyListener initWithGeolocation:]):
12565 (-[WebGeolocationPolicyListener allow]):
12566 (-[WebGeolocationPolicyListener deny]):
12568 2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
12570 Reviewed by Eric Carlson.
12572 Style Fixes in WebPluginController
12573 https://bugs.webkit.org/show_bug.cgi?id=50397
12575 * Plugins/WebPluginController.mm:
12576 (-[WebPluginController startAllPlugins]):
12577 (-[WebPluginController stopAllPlugins]):
12579 2010-12-02 John Sullivan <sullivan@apple.com>
12581 Reviewed by Adam Roben.
12583 Slightly speculative fix for:
12585 <rdar://problem/8712674>
12586 <https://bugs.webkit.org/show_bug.cgi?id=50393>
12587 setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
12589 * Panels/WebAuthenticationPanel.m:
12590 (-[WebAuthenticationPanel setUpForChallenge:]):
12591 If the realm is nil, use @"" instead.
12593 2010-12-01 Jia Pu <jpu@apple.com>
12595 Reviewed by Darin Adler.
12597 Support multiple correction candidates panel for misspelled word on Mac OS X.
12598 https://bugs.webkit.org/show_bug.cgi?id=50137
12599 <rdar://problem/8568059>
12601 This patch is for supporting multiple correction suggestion panel on Mac OS X.
12602 The behavior and implementation is similar to that of reversion candiate panel.
12604 * WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
12606 * WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class.
12607 Added code to handle new multiple suggestion canidate panel type.
12608 (WebEditorClient::showCorrectionPanel):
12609 (WebEditorClient::getGuessesForWord):
12611 2010-12-01 David Hyatt <hyatt@apple.com>
12613 Reviewed by Darin Adler.
12615 https://bugs.webkit.org/show_bug.cgi?id=46645
12617 Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
12618 recently added for horizontal RTL documents and applies it to writing modes as well. Now the
12619 scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
12621 This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
12622 makes them behave the same as the cross-platform code (allowing for cross-platform results to be
12625 * WebView/WebDynamicScrollBarsView.mm:
12626 (-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
12627 (-[WebDynamicScrollBarsView updateScrollers]):
12628 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
12629 (-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
12630 (-[WebDynamicScrollBarsView scrollOrigin]):
12631 * WebView/WebFrameView.mm:
12632 (-[WebFrameView _scrollToBeginningOfDocument]):
12633 (-[WebFrameView _scrollToEndOfDocument]):
12635 2010-11-29 Dan Bernstein <mitz@apple.com>
12637 Reviewed by Darin Adler.
12639 WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
12640 https://bugs.webkit.org/show_bug.cgi?id=50038
12641 Based on a patch from Darin Adler.
12643 * WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
12644 replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
12645 method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
12646 method. Made WebHTMLView conform to the new protocol.
12647 * WebView/WebHTMLView.mm:
12648 (coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
12649 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
12650 -findString:options:.
12651 (-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
12652 (-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
12653 * WebView/WebPDFView.mm:
12654 (-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
12655 * WebView/WebView.mm:
12656 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
12657 -countMatchesForText:options:highlight:limit:markMatches.
12658 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
12659 (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
12660 -findString:options:.
12661 (incrementFrame): Changed to use WebFindOptions.
12662 (findString): Added this helper method that performs the search using the best supported
12663 method for the document view.
12664 (-[WebView findString:options:]): Changed -searchFor::::: into this.
12665 (-[WebView canMarkAllTextMatches]):
12666 (-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
12668 (-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
12669 (-[WebView rectsForTextMatches]): Ditto.
12670 * WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
12671 of countMatchesForText:.
12673 2010-11-29 Jeremy Moskovich <jeremy@chromium.org>
12675 Reviewed by David Hyatt.
12677 Right-to-left pages should be scrollable to reveal left overflow.
12678 https://bugs.webkit.org/show_bug.cgi?id=23556
12680 Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
12681 Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
12682 pages with a left overflow.
12684 * WebView/WebDynamicScrollBarsView.h:
12685 * WebView/WebDynamicScrollBarsView.mm:
12686 (-[WebDynamicScrollBarsView inProgramaticScroll]):
12687 (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]):
12688 (-[WebDynamicScrollBarsView updateScrollers]):
12689 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
12690 (-[WebDynamicScrollBarsView setScrollOriginX:]):
12691 (-[WebDynamicScrollBarsView scrollOriginX]):
12692 * WebView/WebFrameView.mm:
12693 (-[WebFrameView _scrollToBeginningOfDocument]):
12694 (-[WebFrameView _scrollToEndOfDocument]):
12695 * WebView/WebHTMLView.mm:
12696 (-[WebHTMLView _frameOrBoundsChanged]):
12698 2010-11-22 Ryosuke Niwa <rniwa@webkit.org>
12700 Reviewed by Tony Chang.
12702 SelectionController::typingStyle() should return EditingStyle*
12703 https://bugs.webkit.org/show_bug.cgi?id=49813
12705 Changed the return value of SelectionController::typingStyle() to EditingStyle*.
12706 Also added SelectionController::copyTypingStyle() to copy the typing style
12707 as an instance of CSSMutableStyleDeclaration.
12709 No tests are added since this is no behavioral change.
12711 * WebView/WebFrame.mm:
12712 (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()
12714 2010-11-19 Michael Saboff <msaboff@apple.com>
12716 Reviewed by Sam Weinig
12718 Remove DOMSVGAnimatedPathData.h from all: target to fix build.
12720 * MigrateHeaders.make:
12722 2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>
12724 Reviewed by Dirk Schulze.
12726 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
12727 https://bugs.webkit.org/show_bug.cgi?id=49580
12729 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
12731 2010-11-18 Mark Rowe <mrowe@apple.com>
12733 Rubber-stamped by Adam Roben.
12735 <rdar://problem/8602509&8602717&8602724> Enable compaction support.
12737 * Configurations/WebKit.xcconfig:
12739 2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
12741 Unreviewed, rolling out r72288.
12742 http://trac.webkit.org/changeset/72288
12743 https://bugs.webkit.org/show_bug.cgi?id=49730
12745 'krit attempted to do that, but revert got stuck' (Requested
12746 by antonm on #webkit).
12748 * WebView/WebRenderLayer.mm:
12750 2010-11-17 Nikolas Zimmermann <nzimmermann@rim.com>
12752 Reviewed by Dirk Schulze.
12754 Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
12755 https://bugs.webkit.org/show_bug.cgi?id=49580
12757 * WebView/WebRenderLayer.mm: Add missing StyledElement.h include.
12759 2010-11-16 Stephanie Lewis <slewis@apple.com>
12761 Reviewed by Geoff Garen.
12763 <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
12765 Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
12766 every WebView, and the WebKit API doesn't support that ownership model.
12768 * WebView/WebDeviceOrientationProviderMock.h:
12769 * WebView/WebDeviceOrientationProviderMock.mm:
12770 (+[WebDeviceOrientationProviderMock shared]):
12772 2010-11-16 Dave Hyatt <hyatt@apple.com>
12774 Reviewed by Dan Bernstein.
12776 https://bugs.webkit.org/show_bug.cgi?id=11004
12778 font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
12779 Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
12780 since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
12781 of the constructor rather than using [NSFont pointSize].
12783 https://bugs.webkit.org/show_bug.cgi?id=49582
12785 Negative leading is not handled correctly. There are two bugs here. The first is that
12786 maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
12787 set them before so that we can allow them to be < 0.
12789 The second issue is that we should understand where fonts will end up relative to
12790 our baseline (excluding line height), and only allow those boxes to impact ascent and
12791 descent if the actual font box (without factoring in line height) is above or below the
12792 root line box baseline.
12794 Added fast/css/negative-leading.html
12796 These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
12798 * Misc/WebKitNSStringExtras.mm:
12799 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
12800 (-[NSString _web_widthWithFont:]):
12801 * Misc/WebStringTruncator.mm:
12803 * WebView/WebPreferences.mm:
12804 (+[WebPreferences initialize]):
12806 2010-11-16 Anders Carlsson <andersca@apple.com>
12810 * WebCoreSupport/WebFrameLoaderClient.mm:
12812 2010-11-14 Kent Tamura <tkent@chromium.org>
12814 Reviewed by Andreas Kling.
12816 KeyboardEvent::keyIdentifier() should return "const String&"
12817 https://bugs.webkit.org/show_bug.cgi?id=49426
12819 * WebCoreSupport/WebEditorClient.mm:
12820 (selectorForKeyEvent):
12821 Change the type of a variable to have keyIdentifier(); String -> const String&
12823 2010-11-12 John Knottenbelt <jknotten@chromium.org>
12825 Reviewed by Steve Block.
12827 Rename GeolocationControllerClient to GeolocationClient.
12828 https://bugs.webkit.org/show_bug.cgi?id=49259
12830 * WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h.
12831 (WebGeolocationClient::webView):
12832 (WebGeolocationClient::setEnableHighAccuracy):
12833 * WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm.
12834 (WebGeolocationClient::WebGeolocationClient):
12835 (WebGeolocationClient::geolocationDestroyed):
12836 (WebGeolocationClient::startUpdating):
12837 (WebGeolocationClient::stopUpdating):
12838 (WebGeolocationClient::lastPosition):
12840 * WebView/WebView.mm:
12841 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
12843 2010-11-10 Beth Dakin <bdakin@apple.com>
12845 Reviewed by Simon Fraser.
12847 Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
12848 -[WebView _scaleWebView:] should take and origin and scroll the
12850 -and corresponding-
12851 <rdar://problem/8643921>
12853 * WebView/WebView.mm:
12854 (-[WebView _scaleWebView:atOrigin:]):
12855 * WebView/WebViewPrivate.h:
12857 2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
12859 Reviewed by David Hyatt.
12861 HTML5 Ruby support should be mandatory feature
12862 https://bugs.webkit.org/show_bug.cgi?id=49272
12864 Remove Ruby as optional feature.
12866 * Configurations/FeatureDefines.xcconfig:
12868 2010-11-08 Ned Holbrook <nholbrook@apple.com>
12870 Reviewed by Adam Barth.
12872 Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
12873 https://bugs.webkit.org/show_bug.cgi?id=48886
12875 * WebCoreSupport/WebSystemInterface.mm:
12876 (InitWebCoreSystemInterface):
12878 2010-11-08 Nate Chapin <japhet@chromium.org>
12880 Unreviewed, build fix.
12882 Clumsy typo in r71562.
12884 * Plugins/Hosted/HostedNetscapePluginStream.mm:
12885 (WebKit::HostedNetscapePluginStream::start):
12887 2010-11-08 Nate Chapin <japhet@chromium.org>
12889 Reviewed by Alexey Proskuryakov.
12891 Interface changes in https://bugs.webkit.org/show_bug.cgi?id=27165
12893 * Plugins/Hosted/HostedNetscapePluginStream.mm:
12894 (WebKit::HostedNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
12895 * Plugins/WebNetscapePluginStream.mm:
12896 (WebNetscapePluginStream::start): Move duplicate code into NetscapePluginStreamLoader
12897 * WebView/WebView.mm:
12898 (-[WebView _dispatchPendingLoadRequests]): Use resourceLoadScheduler() instead of cache()->loader().
12900 2010-11-08 Anders Carlsson <andersca@apple.com>
12902 Reviewed by Dan Bernstein.
12904 Plug-in views should not assume that plugins are RenderEmbeddedObjects
12905 https://bugs.webkit.org/show_bug.cgi?id=49196
12906 <rdar://problem/8638467>
12908 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
12909 (-[WebHostedNetscapePluginView pluginHostDied]):
12911 2010-11-08 Alexey Proskuryakov <ap@apple.com>
12913 Reviewed by Darin Adler.
12915 https://bugs.webkit.org/show_bug.cgi?id=48685
12916 Notify UI process about focused frame
12918 Added an empty implementation of the new ChromeClient method.
12920 * WebCoreSupport/WebChromeClient.h:
12921 * WebCoreSupport/WebChromeClient.mm:
12922 (WebChromeClient::focusedFrameChanged):
12924 2010-11-08 Anders Carlsson <andersca@apple.com>
12928 * MigrateHeaders.make:
12930 2010-11-08 Anders Carlsson <andersca@apple.com>
12932 Reviewed by Adam Roben.
12934 Remove use of HIGetScaleFactor
12935 https://bugs.webkit.org/show_bug.cgi?id=49186
12936 <rdar://problem/8618410>
12938 Scale factors can vary on a display-by-display basis and it doesn't make sense
12939 to compute scale factor event coordinates like this.
12941 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
12944 2010-11-08 Simon Fraser <simon.fraser@apple.com>
12946 Reviewed by Sam Weinig.
12948 Allow applets to participate in accelerated compositing
12949 https://bugs.webkit.org/show_bug.cgi?id=49117
12950 <rdar://problem/8625819>
12952 If Java is being loaded via the Netscape Plugin API, create a
12953 NetscapePluginWidget so that it has an implementation of platformLayer().
12955 Also clean up by using early returns.
12957 * WebCoreSupport/WebFrameLoaderClient.mm:
12959 2010-11-07 Adam Barth <abarth@webkit.org>
12961 Reviewed by Eric Seidel.
12963 Rename Cache to MemoryCache
12964 https://bugs.webkit.org/show_bug.cgi?id=49159
12966 * Misc/WebCache.mm:
12967 (+[WebCache statistics]):
12968 * WebCoreSupport/WebDeviceOrientationClient.mm:
12969 (WebDeviceOrientationClient::setController):
12970 * WebView/WebView.mm:
12972 2010-11-05 Alexey Proskuryakov <ap@apple.com>
12974 Reviewed by Darin Adler.
12976 https://bugs.webkit.org/show_bug.cgi?id=49100
12977 ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]
12979 * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]):
12980 Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive
12981 (see bug comments), and there seems to be no harm in executing this function in that case.
12983 2010-11-05 Chris Marrin <cmarrin@apple.com>
12985 Reviewed by Simon Fraser.
12987 Move resumeAnimations/suspendAnimations from Frame to AnimationController.
12988 https://bugs.webkit.org/show_bug.cgi?id=49073
12990 * WebView/WebFrame.mm:
12991 (-[WebFrame _suspendAnimations]):
12992 (-[WebFrame _resumeAnimations]):
12994 2010-11-04 Alexey Proskuryakov <ap@apple.com>
12996 Reviewed by Darin Adler.
12998 https://bugs.webkit.org/show_bug.cgi?id=49008
12999 <rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp
13001 Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
13002 the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
13003 deleted during wait:
13005 - plugin was stopped (e.g. due to a DOM modification performed by another reply that came in
13008 We didn't recognize the latter.
13010 * Plugins/Hosted/NetscapePluginHostProxy.mm:
13011 (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
13012 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
13013 (WebKit::NetscapePluginInstanceProxy::waitForReply):
13014 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13015 (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
13017 2010-11-05 Chris Marrin <cmarrin@apple.com>
13019 Reviewed by Simon Fraser.
13021 Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
13022 https://bugs.webkit.org/show_bug.cgi?id=46945
13024 * WebView/WebFrame.mm:
13025 (-[WebFrame _suspendAnimations]):
13026 (-[WebFrame _resumeAnimations]):
13028 2010-11-04 Jia Pu <jpu@apple.com>
13030 Reviewed by Dan Bernstein.
13032 reversion bubble in WebViews
13033 https://bugs.webkit.org/show_bug.cgi?id=47630
13034 <rdar://problem/8530960>
13036 This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.
13038 * WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
13039 * WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code
13040 change to use new reversion API in AppKit.
13041 (WebEditorClient::WebEditorClient):
13042 (WebEditorClient::~WebEditorClient):
13043 (WebEditorClient::respondToChangedSelection):
13044 (WebEditorClient::showCorrectionPanel):
13045 (WebEditorClient::dismissCorrectionPanel):
13046 (WebEditorClient::isShowingCorrectionPanel):
13048 2010-11-04 Mike Thole <mthole@apple.com>
13050 Reviewed by Dan Bernstein.
13052 Title for images should use localized numerals
13053 https://bugs.webkit.org/show_bug.cgi?id=49017
13055 * WebCoreSupport/WebPlatformStrategies.mm:
13056 (WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.
13058 2010-11-02 Daniel Bates <dbates@rim.com>
13060 Reviewed by Adam Barth.
13062 For unnamed frames, window.name returns a generated name
13063 https://bugs.webkit.org/show_bug.cgi?id=6751
13067 Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.
13069 * WebView/WebFrame.mm:
13070 (-[WebFrame name]):
13072 2010-11-01 Brady Eidson <beidson@apple.com>
13074 Reviewed by Anders Carlsson.
13076 <rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
13077 Context menu support for WebKit 2.
13079 * WebCoreSupport/WebChromeClient.h:
13080 (WebChromeClient::showContextMenu):
13082 2010-10-29 Daniel Bates <dbates@rim.com>
13084 No review, rolling out 70971.
13085 http://trac.webkit.org/changeset/70971
13086 https://bugs.webkit.org/show_bug.cgi?id=6751
13088 Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
13089 it caused layout test failures on all bots. In particular, the
13090 child count in a generated frame name differs after this patch. We need
13091 to look into this further.
13093 * WebView/WebFrame.mm:
13094 (-[WebFrame name]):
13096 2010-10-28 Antonio Gomes <agomes@rim.com>
13098 Reviewed by Ojan Vafai.
13100 Needs a "LinuxEditingBehavior", perhaps with a better name
13101 https://bugs.webkit.org/show_bug.cgi?id=36627
13103 Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
13105 * WebView/WebFrame.mm:
13107 * WebView/WebPreferencesPrivate.h:
13109 2010-10-29 Daniel Bates <dbates@rim.com>
13111 Reviewed by Adam Barth.
13113 For unnamed frames, window.name returns a generated name
13114 https://bugs.webkit.org/show_bug.cgi?id=6751
13116 Modified Mac-port to use FrameTree::uniqueName().
13118 * WebView/WebFrame.mm:
13119 (-[WebFrame name]):
13121 2010-10-29 Darin Adler <darin@apple.com>
13123 Reviewed by Sam Weinig.
13125 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
13126 https://bugs.webkit.org/show_bug.cgi?id=48574
13128 * History/WebBackForwardList.mm:
13129 Use BackForwardListImpl.
13131 2010-10-29 Alexey Proskuryakov <ap@apple.com>
13133 Rubber-stamped by Sam Weinig.
13135 Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
13136 create views for subframes.
13138 * WebView/WebViewData.h: Double negation is better than a lie.
13140 2010-10-27 Jer Noble <jer.noble@apple.com>
13142 Reviewed by Darin Adler.
13144 Full screen video in Safari (still) exits full-screen if you switch to another
13145 app on a multi-display system.
13146 https://bugs.webkit.org/show_bug.cgi?id=47364
13147 <rdar://problem/8382299>
13149 The FullScreen window does not technically close when it deactivates, but the
13150 two NSWindows that make up the FullScreen feature should not hide when deactivated.
13152 * WebView/WebVideoFullscreenController.mm:
13153 (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate.
13154 (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
13155 * WebView/WebVideoFullscreenHUDWindowController.mm:
13156 (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
13158 2010-10-29 Alexey Proskuryakov <ap@apple.com>
13160 Reviewed by Darin Adler.
13162 https://bugs.webkit.org/show_bug.cgi?id=48576
13163 Let WebKit2 client know when a frame is a frameset
13165 Added a blank implementation of the new FrameLoaderClient method.
13167 * WebCoreSupport/WebFrameLoaderClient.h:
13168 * WebCoreSupport/WebFrameLoaderClient.mm:
13169 (WebFrameLoaderClient::dispatchDidBecomeFrameset):
13171 2010-10-29 Csaba Osztrogonác <ossy@webkit.org>
13173 Reviewed by Adam Roben and David Kilzer.
13175 Fix and cleanup of build systems
13176 https://bugs.webkit.org/show_bug.cgi?id=48342
13178 * Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.
13180 2010-10-28 Dan Bernstein <mitz@apple.com>
13182 Reviewed by Mark Rowe.
13184 LLVM compiler build fix
13186 * Misc/WebDownload.mm:
13187 (-[WebDownload initWithRequest:delegate:]): Changed the delegate type from id to
13188 id<NSURLDownloadDelegate> to match the method signature in NSURLDownload.
13190 2010-10-28 Ivan Krstić <ike@apple.com>
13192 Reviewed by Mark Rowe.
13194 Remove unused experimental proxied panel interface.
13195 <rdar://problem/7237059>
13197 * Plugins/Hosted/NetscapePluginHostManager.h:
13198 * Plugins/Hosted/NetscapePluginHostManager.mm:
13199 (WebKit::NetscapePluginHostManager::hostForPlugin):
13200 (WebKit::NetscapePluginHostManager::spawnPluginHost):
13201 (WebKit::NetscapePluginHostManager::instantiatePlugin):
13202 * Plugins/Hosted/NetscapePluginHostProxy.mm:
13203 * Plugins/Hosted/WebKitPluginClient.defs:
13204 * Plugins/Hosted/WebKitPluginHost.defs:
13205 * WebCoreSupport/WebSystemInterface.mm:
13206 (InitWebCoreSystemInterface):
13207 * WebView/WebPreferenceKeysPrivate.h:
13208 * WebView/WebPreferences.mm:
13209 (+[WebPreferences initialize]):
13210 * WebView/WebPreferencesPrivate.h:
13212 2010-10-27 Pratik Solanki <psolanki@apple.com>
13214 Reviewed by Darin Adler.
13216 Improve memSize calculation in [WebView _setCacheModel]
13217 https://bugs.webkit.org/show_bug.cgi?id=48484
13219 * WebView/WebView.mm:
13220 (roundUpToPowerOf2): Added. Utility function to calculate the nearest power of 2.
13221 (+[WebView _setCacheModel:]): Update memSize calculation to set it to the next
13222 bigger power of 2. Also update WebCore cache settings.
13224 2010-10-26 Darin Adler <darin@apple.com>
13226 Reviewed by Sam Weinig.
13228 WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
13229 https://bugs.webkit.org/show_bug.cgi?id=42322
13230 rdar://problem/8193631
13232 WebKitTestRunner needs to support layoutTestController.clearBackForwardList
13233 https://bugs.webkit.org/show_bug.cgi?id=42333
13234 rdar://problem/8193643
13236 * History/WebBackForwardList.mm:
13237 (core): Return BackForwardListImpl.
13238 (kit): Take BackForwardListImpl.
13239 (-[WebBackForwardList initWithBackForwardList:]): Use BackForwardListImpl.
13240 (-[WebBackForwardList dealloc]): Ditto.
13241 (-[WebBackForwardList finalize]): Ditto.
13242 (-[WebBackForwardList description]): Ditto.
13243 (-[WebBackForwardList setPageCacheSize:]): Ditto.
13244 (-[WebBackForwardList pageCacheSize]): Ditto.
13245 * History/WebBackForwardListInternal.h: Ditto.
13246 * WebView/WebFrameView.mm:
13247 (-[WebFrameView keyDown:]): Ditto.
13248 * WebView/WebView.mm:
13249 (-[WebView initWithCoder:]): Ditto.
13250 (-[WebView encodeWithCoder:]): Ditto.
13251 (-[WebView backForwardList]): Ditto.
13252 (-[WebView setMaintainsBackForwardList:]): Ditto.
13254 2010-10-27 Chris Rogers <crogers@google.com>
13256 Reviewed by Chris Marrin.
13258 Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
13259 https://bugs.webkit.org/show_bug.cgi?id=48279
13261 * Configurations/FeatureDefines.xcconfig:
13263 2010-10-27 Beth Dakin <bdakin@apple.com>
13265 Reviewed by Darin Adler.
13267 Fix for https://bugs.webkit.org/show_bug.cgi?id=48385 Add WebKit
13268 SPI to scale a WebView
13269 -and corresponding-
13270 <rdar://problem/8107667>
13272 This patch adds SPI to Mac WebKit that scales the page by the given
13275 * WebView/WebView.mm:
13276 (-[WebView _scaleWebView:]):
13277 (-[WebView _viewScaleFactor]):
13278 * WebView/WebViewPrivate.h:
13280 2010-10-27 Dan Bernstein <mitz@apple.com>
13282 Reviewed by Darin Adler.
13284 REGRESSION (r70335): Incorrect article layout in Safari Reader
13285 https://bugs.webkit.org/show_bug.cgi?id=48436
13287 * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITH_GET_MATCHED_CSS_RULES_RESTRICTIONS.
13288 * WebView/WebView.mm:
13289 (-[WebView _needsUnrestrictedGetMatchedCSSRules]): Added. Returns YES for Safari linked against
13290 versions of WebKit that did not have the cross-origin restrictions in getMatchedCSSRules().
13291 (-[WebView _preferencesChangedNotification:]): Call Settings::setCrossOriginCheckInGetMatchedCSSRulesDisabled()
13292 based on the above.
13294 2010-10-18 Jer Noble <jer.noble@apple.com>
13296 Reviewed by Eric Carlson.
13298 Safari fullscreen media element tickles when it should not.
13300 https://bugs.webkit.org/show_bug.cgi?id=47861
13302 * WebView/WebVideoFullscreenController.mm:
13303 (-[WebVideoFullscreenController updatePowerAssertions]):
13305 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
13307 Reviewed by Dmitry Titov.
13309 Resource tracking failure when trying to move a frame between documents
13310 https://bugs.webkit.org/show_bug.cgi?id=44713
13312 * WebCoreSupport/WebFrameLoaderClient.h:
13313 * WebCoreSupport/WebFrameLoaderClient.mm:
13314 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
13316 (WebFrameLoaderClient::transferLoadingResourceFromPage):
13317 Update resource tracking for a resource load that has been transferred
13320 2010-10-25 Oliver Hunt <oliver@apple.com>
13322 Reviewed by Gavin Barraclough.
13324 Remove exec and globalData arguments from jsNumber
13325 https://bugs.webkit.org/show_bug.cgi?id=48270
13327 Mechanical removal of exec parameter to jsNumber
13329 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13330 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
13331 * Plugins/Hosted/ProxyInstance.mm:
13332 (WebKit::ProxyInstance::numberValue):
13334 2010-10-24 Dan Bernstein <mitz@apple.com>
13336 Reviewed by Anders Carlsson.
13338 Expose HitTestResult::absoluteMediaURL() via WebKit API
13339 https://bugs.webkit.org/show_bug.cgi?id=48219
13341 * Misc/WebElementDictionary.mm:
13342 (+[WebElementDictionary initializeLookupTable]): Map WebElementMediaURLKey to
13344 (-[WebElementDictionary _absoluteMediaURL]): Added. Returns absoluteMediaURL().
13345 * WebKit.exp: Export WebElementMediaURLKey.
13346 * WebView/WebView.mm: Define WebElementMediaURLKey.
13347 * WebView/WebViewPrivate.h: Declare WebElementMediaURLKey.
13349 2010-10-24 Dan Bernstein <mitz@apple.com>
13351 Reviewed by Simon Fraser.
13353 Removed deprecated methods from the WebHTMLHighlighter private protocol.
13355 * WebCoreSupport/WebChromeClient.mm:
13356 (WebChromeClient::customHighlightRect): Call -highlightRectForLine:representedNode:
13358 (WebChromeClient::paintCustomHighlight): Call
13359 -paintHighlightForBox:onLine:behindText:entireLine:representedNode: unconditionally.
13360 * WebView/WebHTMLViewPrivate.h:
13362 2010-10-23 Xan Lopez <xlopez@igalia.com>
13364 Reviewed by Sam Weinig.
13366 Unify globalData APIs
13367 https://bugs.webkit.org/show_bug.cgi?id=47969
13369 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13370 (WebKit::NetscapePluginInstanceProxy::evaluate):
13371 (WebKit::NetscapePluginInstanceProxy::invoke):
13372 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
13373 (WebKit::NetscapePluginInstanceProxy::construct):
13374 * WebView/WebScriptDebugDelegate.mm:
13375 (-[WebScriptCallFrame evaluateWebScript:]):
13377 2010-10-23 David Kilzer <ddkilzer@apple.com>
13379 <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
13381 Reviewed by Sam Weinig.
13383 The only method defined in WebHTMLRepresentationInternal.h is
13384 also defined in WebHTMLRepresentation.h, so use that instead.
13386 * WebView/WebHTMLRepresentationInternal.h: Removed.
13388 2010-10-23 Alexey Proskuryakov <ap@apple.com>
13390 Reviewed by Anders Carlsson.
13392 https://bugs.webkit.org/show_bug.cgi?id=48083
13393 <rdar://problem/8489082> Need WebKit2 API for private browsing (48083)
13395 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Initialize the new method.
13397 2010-10-22 Sam Weinig <sam@webkit.org>
13399 Reviewed by Anders Carlsson.
13401 WebKit2 needs to pass the current event modifier flags when requesting a new window
13402 https://bugs.webkit.org/show_bug.cgi?id=48140
13404 * WebCoreSupport/WebChromeClient.h:
13405 * WebCoreSupport/WebChromeClient.mm:
13406 (WebChromeClient::createWindow):
13407 * WebCoreSupport/WebFrameLoaderClient.h:
13408 * WebCoreSupport/WebFrameLoaderClient.mm:
13409 (WebFrameLoaderClient::dispatchCreatePage):
13410 Add NavigationAction parameter.
13412 2010-10-21 Andy Estes <aestes@apple.com>
13414 Reviewed by Eric Carlson.
13416 WebKit shouldn't load a plug-in based on file extension if a MIME type
13418 https://bugs.webkit.org/show_bug.cgi?id=48046
13420 If a MIME type is specified in an object or embed element, and that MIME
13421 type isn't supported by an installed plug-in, WebKit shouldn't attempt
13422 to find a plug-in based on the file extension of the url attribute.
13423 Doing so can lead to cases where a plug-in is loaded that can't handle
13424 resources of the MIME type specified by the author.
13426 * WebCoreSupport/WebFrameLoaderClient.mm:
13427 (WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
13428 extension if MIME type is the empty string.
13430 2010-10-20 Simon Fraser <simon.fraser@apple.com>
13432 Reviewed by Dan Bernstein.
13434 Composited elements drawn twice when WebView is layer-backed
13435 https://bugs.webkit.org/show_bug.cgi?id=48024
13436 <rdar://problem/7916580>
13438 When drawing content in a layer-backed WebView, WebFrame's test
13439 for drawing to a bitmap succeeded, causing us to paint flattened
13440 compositing layers into the view. They would also be rendered
13441 by the normal compositing path, resulting in double rendering.
13443 Fix this by detecting when the WebHTMLView is being drawn into
13444 a layer, and avoiding flattening in that case.
13446 * WebView/WebFrame.mm:
13447 (-[WebFrame _showFlattenedCompositingLayers:]):
13448 (-[WebFrame _drawRect:contentsOnly:]):
13449 * WebView/WebHTMLView.mm:
13450 (-[WebHTMLView drawLayer:inContext:]):
13451 (-[WebHTMLView _web_isDrawingIntoLayer]):
13452 * WebView/WebHTMLViewInternal.h:
13454 2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
13456 Reviewed by David Levin.
13458 Repost the DatabaseTracker notifications to the main thread, if needed.
13459 https://bugs.webkit.org/show_bug.cgi?id=40655
13461 * Storage/WebDatabaseTrackerClient.mm:
13462 (DidModifyOriginData::dispatchToMainThread):
13463 (DidModifyOriginData::DidModifyOriginData):
13464 (DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
13465 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
13466 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
13468 2010-10-20 Simon Fraser <simon.fraser@apple.com>
13470 Reviewed by Darin Adler.
13472 REGRESSION(r67568-r67643): Some HTML/CSS renders upside down and backwards on Leopard
13473 https://bugs.webkit.org/show_bug.cgi?id=47369
13475 r46947 added code that limits the size of the layer-backed view on Leopard when
13476 the page height exceeds 4096px (later adjusted to 2048px in r48401).
13478 Later, r67576 altered the geometry flipping behavior to push the geometry flipping
13479 down into WebKit. However, the code that adjusts the hosting layer's sublayer transform
13480 to account for layer-backed view size-limiting was not fixed at the same time.
13481 This change corrects that.
13483 * WebView/WebHTMLView.mm:
13484 (-[WebHTMLView _updateLayerHostingViewPosition]):
13486 2010-10-19 Simon Fraser <simon.fraser@apple.com>
13488 Reviewed by Dan Bernstein.
13490 <rdar://problem/8508422> Compositing layers aren't always displayed correctly in layer-backed WebViews
13492 AppKit has some special code to prevent it meddling with view's layers
13493 under layer-backed WebViews. When a layer-backed WebView became composited,
13494 this caused our layer to remain zero-sized. Fix this by manually
13495 setting the geometry for our layer, if the WebHTMLView has a layer.
13497 This does not seem to be a problem if the WebView becomes layer-backed, or
13498 stops being layer-backed after the WebView starts using compositing.
13500 * WebView/WebHTMLView.mm:
13501 (-[WebHTMLView attachRootLayer:]):
13503 2010-10-20 Dirk Schulze <krit@webkit.org>
13505 Reviewed by Nikolas Zimmermann.
13507 Merge ColorSpace and ImageColorSpace enums
13508 https://bugs.webkit.org/show_bug.cgi?id=47922
13510 Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
13511 to follow webkit style rules.
13513 * Misc/WebKitNSStringExtras.mm:
13514 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
13516 2010-10-19 Alexey Proskuryakov <ap@apple.com>
13518 Reviewed by Anders Carlsson.
13520 https://bugs.webkit.org/show_bug.cgi?id=47933
13521 <rdar://problem/8494337> navigator.language doesn't work in WebKit2
13523 * Misc/WebNSUserDefaultsExtras.mm: Moved code for computing default language to WebCore.
13524 We need to keep _webkit_preferredLanguageCode for Safari.
13526 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
13527 Initialize wkCopyCFLocalizationPreferredName.
13529 * WebCoreSupport/WebViewFactory.mm: Removed defaultLanguage. WebCore was the only caller.
13531 2010-10-18 Alexey Proskuryakov <ap@apple.com>
13533 Reviewed by David Kilzer.
13535 https://bugs.webkit.org/show_bug.cgi?id=47864
13536 Convert WebNSUserDefaultsExtras.m to .mm
13538 Also, fixed some issues in the process:
13539 - removed locking, which was only necessary when this code was in Foundation;
13540 - fixed notification center observer to actually work (previously, it picked up changes
13541 when application preferences changed, not when system language did);
13542 - removed unused NSString category;
13545 * Misc/WebNSUserDefaultsExtras.m: Removed.
13546 * Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m.
13547 (createHTTPStyleLanguageCode):
13548 (+[NSUserDefaults _webkit_defaultsDidChange]):
13549 (addLanguageChangeObserver):
13550 (+[NSUserDefaults _webkit_preferredLanguageCode]):
13552 2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
13554 Reviewed by Eric Seidel.
13556 Switch to using the new Carbon NPAPI event declarations, and remove
13559 https://bugs.webkit.org/show_bug.cgi?id=40784
13561 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
13562 (WebNetscapePluginEventHandlerCarbon::mouseEntered):
13563 (WebNetscapePluginEventHandlerCarbon::mouseExited):
13564 (WebNetscapePluginEventHandlerCarbon::mouseMoved):
13565 (WebNetscapePluginEventHandlerCarbon::focusChanged):
13567 2010-10-18 Pavel Podivilov <podivilov@chromium.org>
13569 Reviewed by Timothy Hatcher.
13571 Web Inspector: disable private browsing for inspector
13572 https://bugs.webkit.org/show_bug.cgi?id=47827
13574 * WebCoreSupport/WebInspectorClient.mm:
13575 (-[WebInspectorWindowController init]):
13577 2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
13579 Reviewed by Pavel Feldman.
13581 Web Inspector: inspector settings/properties/states management
13582 should be extracted into separate class.
13584 We have a lot of flags/values in InspectorController.
13585 Some flags are persisting into profile.
13586 Others are part of inspector state for frontend.
13587 All these flags should keep their values after navigation.
13588 It'd be better to extract these flags/values into separate
13589 class which will care about theirs lifetime.
13591 https://bugs.webkit.org/show_bug.cgi?id=47275
13593 * WebCoreSupport/WebInspectorClient.mm:
13594 (-[WebInspectorWindowController showWindow:]):
13595 (-[WebInspectorWindowController attach]):
13596 (-[WebInspectorWindowController detach]):
13598 2010-10-13 Gavin Barraclough <barraclough@apple.com>
13600 Reviewed by Oliver Hunt.
13602 https://bugs.webkit.org/show_bug.cgi?id=43987
13603 Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
13604 to construct their internal result string. Remove ScriptString (this is now
13607 * WebCoreSupport/WebFrameLoaderClient.mm:
13609 2010-10-12 Andy Estes <aestes@apple.com>
13611 Rubber-stamped by Darin Adler.
13613 Check in some cleanup from the previous commit.
13615 * WebView/WebView.mm:
13616 (leakMailQuirksUserScriptPath): Renamed to indicate that this function
13618 (-[WebView _injectMailQuirksScript]): Moved a static initialization from
13619 a separate class method into the only method that used it and removed
13620 the now-unnecessary class method.
13622 2010-10-12 Eric Seidel <eric@webkit.org>
13624 Reviewed by Darin Adler.
13626 REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
13627 https://bugs.webkit.org/show_bug.cgi?id=45693
13629 Re-implement this former WebCore parser quirk as a
13630 Mac-only userscript-based quirk. As far as I can tell
13631 from Darin's description this should satisfy Mail's needs.
13633 * Misc/MailQuirksUserScript.js: Added.
13634 * WebView/WebView.mm:
13635 (+[WebView _mailQuirksUserScript]):
13636 (-[WebView _injectMailQuirksScript]):
13637 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
13639 2010-10-12 Simon Fraser <simon.fraser@apple.com>
13641 Reviewed by Sam Weinig.
13643 Add 'didDraw' callback for framerate tracking
13644 https://bugs.webkit.org/show_bug.cgi?id=47478
13646 Add a callback at the end of -[WebHTMLView drawRect:] so
13647 a delegate can get notified when a draw happens.
13649 * WebView/WebHTMLView.mm:
13650 (-[WebHTMLView drawRect:]):
13651 * WebView/WebUIDelegatePrivate.h:
13653 2010-10-11 Anders Carlsson <andersca@apple.com>
13655 Reviewed by Darin Adler.
13657 Remove WebIconFetcher from WebKit and IconFetcher from WebCore
13658 https://bugs.webkit.org/show_bug.cgi?id=47523
13660 Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
13662 * Misc/WebIconFetcher.h: Removed.
13663 * Misc/WebIconFetcher.mm: Removed.
13664 * Misc/WebIconFetcherInternal.h: Removed.
13665 * WebView/WebFrame.mm:
13666 * WebView/WebFramePrivate.h:
13668 2010-10-11 Jessie Berlin <jberlin@apple.com>
13670 Reviewed by Darin Adler.
13672 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
13673 representation of a WebKit1 WebSerializedJSValue.
13674 https://bugs.webkit.org/show_bug.cgi?id=47439
13676 * WebView/WebSerializedJSValue.mm:
13677 (-[WebSerializedJSValue internalRepresentation]):
13678 * WebView/WebSerializedJSValuePrivate.h:
13680 2010-10-07 Jessie Berlin <jberlin@apple.com>
13682 Reviewed by Sam Weinig.
13684 Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
13685 representation of a WebKit2 WebSerializedScriptValue.
13686 https://bugs.webkit.org/show_bug.cgi?id=47390
13688 * WebView/WebSerializedJSValue.mm:
13689 (-[WebSerializedJSValue initWithInternalRepresentation:]):
13690 Set the WebSerializedJSValuePrivate's WebCore::SerializedScriptValue to be the passed in
13691 internal representation.
13692 * WebView/WebSerializedJSValuePrivate.h: Added.
13694 2010-10-07 Antonio Gomes <agomes@rim.com>
13696 Reviewed by Simon Fraser.
13698 [Mac] [DRT] implement setSpatialNavigationEnabled
13699 https://bugs.webkit.org/show_bug.cgi?id=47291
13701 Added the needed bits to make it possible to enabled spatial navigation
13702 for the Mac port. For now it is being only used by DRT.
13704 * WebView/WebPreferenceKeysPrivate.h:
13705 * WebView/WebPreferences.mm:
13706 (+[WebPreferences initialize]):
13707 (-[WebPreferences isSpatialNavigationEnabled]):
13708 (-[WebPreferences setSpatialNavigationEnabled:]):
13709 * WebView/WebPreferencesPrivate.h:
13710 * WebView/WebView.mm:
13711 (-[WebView _preferencesChangedNotification:]):
13713 2010-10-07 Jer Noble <jer.noble@apple.com>
13715 Fix the Leopard 64-bit build.
13717 * Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the
13718 framework search path.
13719 * WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
13721 2010-10-06 Jer Noble <jer.noble@apple.com>
13723 Reviewed by Darin Adler.
13725 Screensaver starts while watching fullscreen playback.
13726 https://bugs.webkit.org/show_bug.cgi?id=47299
13727 <rdar://problem/8478956>
13729 To disable the Screen Saver, we need to periodically call UpdateSystemActivity().
13731 * WebView/WebVideoFullscreenController.h: Added _tickleTimer.
13732 * WebView/WebVideoFullscreenController.mm:
13733 (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer.
13734 (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer.
13735 (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer.
13736 (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity().
13737 (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer
13738 or _disableTickleTimer.
13740 2010-10-05 Philippe Normand <pnormand@igalia.com>
13742 Reviewed by Martin Robinson.
13744 check for ENABLE(GLIB_SUPPORT) in WebView
13745 https://bugs.webkit.org/show_bug.cgi?id=46788
13747 Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.
13749 * WebView/WebView.mm:
13750 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
13751 (-[WebView _close]):
13752 * WebView/WebViewData.h:
13753 * WebView/WebViewInternal.h:
13755 2010-10-01 Anders Carlsson <andersca@apple.com>
13757 Fix Snow Leopard build.
13759 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13760 (WebKit::NetscapePluginInstanceProxy::getProxy):
13762 2010-10-01 Anders Carlsson <andersca@apple.com>
13764 Reviewed by Dan Bernstein.
13766 Add proxy server query function proxyServersForURL and change the Mac plug-in code to use it
13767 https://bugs.webkit.org/show_bug.cgi?id=47022
13768 <rdar://problem/8504712>
13770 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13771 (WebKit::NetscapePluginInstanceProxy::getProxy):
13772 * Plugins/WebBaseNetscapePluginView.h:
13773 * Plugins/WebBaseNetscapePluginView.mm:
13774 * Plugins/WebNetscapePluginView.mm:
13775 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
13777 2010-09-30 Darin Adler <darin@apple.com>
13779 Reviewed by Sam Weinig.
13781 Remove remaining calls to deprecatedParseURL
13782 https://bugs.webkit.org/show_bug.cgi?id=26599
13784 * DOM/WebDOMOperations.mm:
13785 (-[DOMDocument URLWithAttributeString:]):
13786 * WebCoreSupport/WebFrameLoaderClient.mm:
13787 (WebFrameLoaderClient::createPlugin):
13788 Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
13790 2010-09-30 Anders Carlsson <andersca@apple.com>
13792 Reviewed by Darin Adler.
13794 -[DOMDocument _documentRange] throws an exception if there is no document element
13795 https://bugs.webkit.org/show_bug.cgi?id=46934
13796 <rdar://problem/8169260>
13798 If there is no document element, just return an empty range. Otherwise we'll try to call
13799 Range::selectNode with a null Node which will throw a NOT_FOUND exception.
13801 * DOM/WebDOMOperations.mm:
13802 (-[DOMDocument _documentRange]):
13804 2010-09-30 Chris Marrin <cmarrin@apple.com>
13806 Reviewed by Simon Fraser.
13808 Make 2D accelerated canvas rendering build on Mac
13809 https://bugs.webkit.org/show_bug.cgi?id=46007
13811 Added ACCELERATED_2D_CANVAS to FeatureDefines
13813 * Configurations/FeatureDefines.xcconfig:
13815 2010-09-30 Dan Bernstein <mitz@apple.com>
13817 Reviewed by John Sullivan.
13819 Add printing SPI allowing full control over shrink-to-fit
13820 https://bugs.webkit.org/show_bug.cgi?id=46877
13822 * WebView/WebHTMLView.mm:
13823 (-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.
13824 * WebView/WebHTMLViewPrivate.h:
13826 2010-09-28 Johnny Ding <jnd@chromium.org>
13828 Reviewed by Adam Barth.
13830 https://bugs.webkit.org/show_bug.cgi?id=41292
13831 Some windowed plugins did not handle events through EventHandler, so we
13832 never set right gesture state for those events.
13833 This change is to set right allowPopupsFromPlugin flag to current
13834 execution frame, so WeKit can always get right gesture state on Mac.
13835 From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
13836 process, that process passes the allowPopupsFromPlugin flag to
13837 WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
13838 NetscapePluginInstanceProxy::evaluate.
13840 * Plugins/WebNetscapePluginView.mm:
13841 (-[WebNetscapePluginView sendEvent:isDrawRect:]):
13843 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
13845 Reviewed by Dmitry Titov.
13847 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
13848 https://bugs.webkit.org/show_bug.cgi?id=46663
13850 * WebCoreSupport/WebFrameLoaderClient.h:
13851 * WebCoreSupport/WebFrameLoaderClient.mm:
13852 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
13854 2010-09-26 Antonio Gomes <agomes@rim.com>
13856 Reviewed by Kenneth Rohde Christiansen.
13858 DRT/Mac nodesFromRect support
13860 [Mac][DRT] Implement LayoutTestController::nodesFromRect
13861 https://bugs.webkit.org/show_bug.cgi?id=46580
13863 Implement nodesFromRect as a private method to access non-exposed Document
13864 methods, similarly to computedStyleIncludingVisitedInfo.
13866 * WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.
13867 These headers makes it possible to:
13868 1) Get a Document off of a JSDocument;
13869 2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
13870 gotten from Document::nodesFromRect to JS bindings.
13871 (-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):
13872 * WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the
13873 Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.
13875 2010-09-24 Jia Pu <jpu@apple.com>
13877 Reviewed by Dan Bernstein.
13879 automaticSpellingCorrectionEnabled isn't updated.
13880 https://bugs.webkit.org/show_bug.cgi?id=46486
13881 <rdar://problem/8475212>
13883 * WebView/WebView.mm:
13884 (+[WebView initialize]): Should update "automaticSpellingCorrectionEnabled"
13885 instead of "automaticTextReplacementEnabled".
13887 2010-09-23 Alexey Proskuryakov <ap@apple.com>
13889 Reviewed by Darin Adler.
13891 https://bugs.webkit.org/show_bug.cgi?id=46380
13892 REGRESSION: Crash when downloading a file
13894 Downloading cannot be tested in DRT.
13896 * Misc/WebNSFileManagerExtras.m: (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
13897 Don't copy null strings.
13899 2010-09-24 Ilya Tikhonovsky <loislo@chromium.org>
13901 Reviewed by Yury Semikhatsky.
13903 Web Inspector: CRASH at node highlight on MAC Safari.
13904 1) run-safari --debug
13906 3) open elements panel
13907 4) hover mouse over elements panel items multiple times
13909 Looks like it is a race condition. WebNodeHighlightView doesn't check
13910 the pointer to WebNodeHighligh object and it can be nil.
13912 https://bugs.webkit.org/show_bug.cgi?id=46261
13914 * WebInspector/WebNodeHighlightView.mm:
13915 (-[WebNodeHighlightView drawRect:]):
13917 2010-09-23 Andy Estes <aestes@apple.com>
13919 Reviewed by Darin Adler.
13921 REGRESSION (r61285): some Dashboard widgets are always invisible due to
13922 HTML parser changes.
13923 https://bugs.webkit.org/show_bug.cgi?id=46435
13925 Enable pre-HTML5 parser quirks if Dashboard is in backward compatibility
13928 * WebView/WebView.mm:
13929 (-[WebView _needsPreHTML5ParserQuirks]): Renamed from
13930 shouldUsePreHTML5ParserQuirks(). Return true if
13931 WebCore::Settings::usesDashboardCompatibilityMode() is true.
13932 (-[WebView _preferencesChangedNotification:]):
13933 (-[WebView _setDashboardBehavior:to:]): Enable pre-HTML5 parser quirks
13934 if Dashboard behavior is set to backward compatibility mode.
13936 2010-09-23 Matthew Delaney <mdelaney@apple.com>
13938 Reviewed by Simon Fraser.
13940 Reduce minimum DOMTimer interval
13941 https://bugs.webkit.org/show_bug.cgi?id=45362
13943 * WebView/WebView.mm:
13944 Updating set interval call to use Settings' static version inside
13945 one time init block.
13947 2010-09-22 Andy Estes <aestes@apple.com>
13949 Reviewed by Darin Adler.
13951 REGRESSION (r61285): Microsoft Entourage 2008 does not invoke My Day window
13952 https://bugs.webkit.org/show_bug.cgi?id=46334
13954 Microsoft My Day loads scripts using self-closing script tags, markup
13955 which is incompatible with the HTML5 parser. Enable parser quirks for
13958 * WebView/WebView.mm:
13959 (shouldUsePreHTML5ParserQuirks): Return true if the application is
13960 Microsoft My Day and was linked against a version of WebKit prior to the
13961 introduction of the HTML5 parser.
13963 2010-09-23 Nate Chapin <japhet@chromium.org>
13965 Reviewed by Darin Fisher.
13967 Add hyperlink auditing settings (i.e., <a ping>).
13968 https://bugs.webkit.org/show_bug.cgi?id=30458
13970 * WebView/WebPreferenceKeysPrivate.h:
13971 * WebView/WebPreferences.mm:
13972 (+[WebPreferences initialize]):
13973 (-[WebPreferences setMemoryInfoEnabled:]):
13974 (-[WebPreferences hyperlinkAuditingEnabled]):
13975 (-[WebPreferences setHyperlinkAuditingEnabled:]):
13976 * WebView/WebPreferencesPrivate.h:
13977 * WebView/WebView.mm:
13978 (-[WebView _preferencesChangedNotification:]):
13980 2010-09-22 Alexey Proskuryakov <ap@apple.com>
13982 Reviewed by Anders Carlsson.
13984 https://bugs.webkit.org/show_bug.cgi?id=43667
13985 ASSERT failure in NetscapePluginInstanceProxy::disconnectStream
13987 Test: plugins/get-javascript-url.html
13989 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
13990 (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): Add the stream to m_streams, just
13991 like any other one.
13993 2010-09-21 Darin Adler <darin@apple.com>
13995 Reviewed by Anders Carlsson.
13997 Fix some Objective-C GC problems and use RetainPtr instead of HardRetain/Release
13998 https://bugs.webkit.org/show_bug.cgi?id=46220
14000 * Misc/WebNSFileManagerExtras.m:
14001 (setMetaData): Use CFRelease instead of HardRelease.
14002 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Use CFStringCreateCopy
14003 instead of -[NSObject copy] combined with HardRetainWithNSRelease.
14005 2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
14007 Reviewed by Kenneth Rohde Christiansen.
14009 PluginStrategy should satisfy the needs of Qt
14010 https://bugs.webkit.org/show_bug.cgi?id=45857
14011 No new functionality so no new tests.
14013 * WebCoreSupport/WebPlatformStrategies.h:
14014 * WebCoreSupport/WebPlatformStrategies.mm:
14015 (WebPlatformStrategies::getPluginInfo):
14017 2010-09-22 Paul Knight <pknight@apple.com>
14019 Reviewed by Simon Fraser.
14021 -[WebView _scheduleCompositingLayerSync] should wake the run loop
14022 https://bugs.webkit.org/show_bug.cgi?id=46226
14024 Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.
14026 * WebView/WebView.mm:
14027 (-[WebView _scheduleCompositingLayerSync]):
14029 2010-09-21 Andy Estes <aestes@apple.com>
14031 Reviewed by Darin Adler.
14033 REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
14034 https://bugs.webkit.org/show_bug.cgi?id=46134
14036 AIM clients linked against versions of WebKit prior to the introduction
14037 of the HTML5 parser contain markup incompatible with the new parser.
14038 Enable parser quirks in this case to remain compatible with these
14041 * WebView/WebView.mm:
14042 (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
14043 application is AIM and was linked against a version of WebKit prior to
14044 the introduction of the HTML5 parser, or if the
14045 WebKitPreHTML5ParserQuirks WebPreference is enabled.
14046 (-[WebView _preferencesChangedNotification:]): Call
14047 WebCore::Settings::setUsePreHTML5ParserQuirks().
14049 2010-09-21 Steve Block <steveblock@google.com>
14051 Reviewed by Jeremy Orlow.
14053 DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
14054 https://bugs.webkit.org/show_bug.cgi?id=45891
14056 Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.
14058 * WebCoreSupport/WebDeviceOrientationClient.h:
14059 * WebCoreSupport/WebDeviceOrientationClient.mm:
14060 (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):
14062 2010-09-20 Philippe Normand <pnormand@igalia.com>
14064 Reviewed by Eric Carlson.
14066 [GTK] enhanced context menu for media elements
14067 https://bugs.webkit.org/show_bug.cgi?id=45021
14069 New localized strings for the media element context-menu.
14071 * WebCoreSupport/WebPlatformStrategies.h:
14072 * WebCoreSupport/WebPlatformStrategies.mm:
14073 (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
14074 (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
14075 (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
14076 (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
14077 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
14078 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
14079 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
14080 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
14081 (WebPlatformStrategies::contextMenuItemTagMediaPause):
14082 (WebPlatformStrategies::contextMenuItemTagMediaMute):
14084 2010-09-20 Andy Estes <aestes@apple.com>
14086 Reviewed by Adam Barth.
14088 REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
14089 https://bugs.webkit.org/show_bug.cgi?id=40961
14091 Implement WebKitUsePreHTML5ParserQuirks preference.
14093 * WebView/WebPreferenceKeysPrivate.h:
14094 * WebView/WebPreferences.mm:
14095 (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to
14097 (-[WebPreferences usePreHTML5ParserQuirks]):
14098 (-[WebPreferences setUsePreHTML5ParserQuirks:]):
14099 * WebView/WebPreferencesPrivate.h:
14100 * WebView/WebView.mm:
14101 (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings
14102 with the value of WebKitUsePreHTML5ParserQuirks when a preference
14105 2010-09-20 Enrica Casucci <enrica@apple.com>
14107 Reviewed by Sam Weinig.
14109 Pasteboard doesn't work in WebKit2.
14110 https://bugs.webkit.org/show_bug.cgi?id=42317
14111 <rdar://problem/7660537>
14113 Some changes to fix style inconsistencies.
14114 Added OBJC 2.0 style enumeration.
14116 * WebCoreSupport/WebEditorClient.h:
14117 * WebCoreSupport/WebEditorClient.mm:
14118 (WebEditorClient::userVisibleString):
14119 (createExcludedElementsForAttributedStringConversion):
14120 (WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
14121 a Vector of RefPtr.
14122 (WebEditorClient::setInsertionPasteboard):
14123 (WebEditorClient::pasteboardTypesForSelection):
14125 2010-09-17 David Hyatt <hyatt@apple.com>
14127 Reviewed by Simon Fraser.
14129 https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.
14131 Make printing store the page height in the RenderView and push that into the layout state to
14132 use the new pagination model. The old pagination model is retained because it is still used
14133 for embedded WebViews.
14135 * WebView/WebHTMLView.mm:
14136 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
14138 2010-09-17 Darin Adler <darin@apple.com>
14140 Reviewed by Sam Weinig.
14142 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
14143 https://bugs.webkit.org/show_bug.cgi?id=42863
14145 * WebView/WebView.mm:
14146 (-[WebView _setZoomMultiplier:isTextOnly:]):
14147 Call functions on Frame instead of FrameView.
14149 2010-09-17 Matthew Delaney <mdelaney@apple.com>
14151 Reviewed by Simon Fraser.
14153 Reduce minimum DOMTimer interval
14154 https://bugs.webkit.org/show_bug.cgi?id=45362
14156 * WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.
14158 2010-09-17 Chris Marrin <cmarrin@apple.com>
14160 Reviewed by Simon Fraser.
14162 Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
14163 https://bugs.webkit.org/show_bug.cgi?id=45911
14165 * WebView/WebPreferenceKeysPrivate.h:
14166 * WebView/WebPreferences.mm:
14167 (+[WebPreferences initialize]):
14168 (-[WebPreferences accelerated2dCanvasEnabled]):
14169 (-[WebPreferences setAccelerated2dCanvasEnabled:]):
14170 * WebView/WebPreferencesPrivate.h:
14171 * WebView/WebView.mm:
14172 (-[WebView _preferencesChangedNotification:]):
14174 2010-09-17 Jia Pu <jpu@apple.com>
14176 Reviewed by Dan Bernstein.
14178 WebKit should use system wide spell checking preference when application specific one isn't set.
14179 https://bugs.webkit.org/show_bug.cgi?id=45789
14180 <rdar://problem/8416041>
14182 * WebView/WebView.mm:
14183 (+[WebView initialize]): Use system wide autocorrection and text substitution preferences
14184 when the application level preferences are not set.
14186 2010-09-16 John Sullivan <sullivan@apple.com>
14188 Reviewed by Darin Adler.
14190 <rdar://problem/8395558>
14191 https://bugs.webkit.org/show_bug.cgi?id=45938
14192 _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it
14194 * WebView/WebHTMLView.mm:
14195 (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
14196 Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
14197 was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
14198 this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
14199 before enumerating it, to ensure that the selector can't mutate the array being enumerated.
14200 (-[WebHTMLView viewWillMoveToHostWindow:]):
14201 Updated for _web_makePluginSubviewsPerformSelector:: signature change.
14202 (-[WebHTMLView viewDidMoveToHostWindow]):
14205 2010-09-16 Darin Adler <darin@apple.com>
14207 Reviewed by Andreas Kling.
14209 Reduce use of HTMLInputElement::inputType so we can remove it later
14210 https://bugs.webkit.org/show_bug.cgi?id=45903
14212 * WebView/WebHTMLRepresentation.mm:
14213 (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField.
14214 (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
14216 2010-09-16 Patrick Gansterer <paroga@paroga.com>
14218 Reviewed by Darin Adler.
14220 Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
14221 https://bugs.webkit.org/show_bug.cgi?id=41510
14223 This prevents usage of nil value, which would cause an uncaught exception.
14225 * WebView/WebPreferences.mm:
14226 (-[WebPreferences setUserStyleSheetLocation:]):
14228 2010-09-16 Dan Bernstein <mitz@apple.com>
14230 Reverted the previous change because r67628 has been reverted.
14232 * WebCoreSupport/WebPlatformStrategies.h:
14233 * WebCoreSupport/WebPlatformStrategies.mm:
14235 2010-09-16 Dan Bernstein <mitz@apple.com>
14237 Build fix after r67628. Added context menu item localizable strings for the items
14238 added in r67628, following equivalent menu items in Mac OS X when possible. However,
14239 this set of menu items does not make much sense for Mac OS X, and this should be
14240 addressed separately.
14242 * WebCoreSupport/WebPlatformStrategies.h:
14243 * WebCoreSupport/WebPlatformStrategies.mm:
14244 (WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
14245 (WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
14246 (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
14247 (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
14248 (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
14249 (WebPlatformStrategies::contextMenuItemTagMediaPlay):
14250 (WebPlatformStrategies::contextMenuItemTagMediaPause):
14251 (WebPlatformStrategies::contextMenuItemTagMediaMute):
14252 (WebPlatformStrategies::contextMenuItemTagMediaUnMute):
14254 2010-09-16 Eric Uhrhane <ericu@chromium.org>
14256 Reviewed by Jian Li.
14258 Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
14259 https://bugs.webkit.org/show_bug.cgi?id=45798
14261 * Configurations/FeatureDefines.xcconfig:
14263 2010-09-15 Simon Fraser <simon.fraser@apple.com>
14265 Reviewed by Adam Roben.
14267 https://bugs.webkit.org/show_bug.cgi?id=44715
14268 maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac
14270 Move geometry flipping to platform-specific code.
14272 * WebView/WebHTMLView.mm:
14273 (-[WebHTMLView attachRootLayer:]):
14275 2010-09-14 Jia Pu <jpu@apple.com>
14277 Reviewed by Dan Bernstein.
14279 Only intercept ESC key press when autocorrection UI is visible.
14280 https://bugs.webkit.org/show_bug.cgi?id=45071
14282 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
14283 which provides an inteface to query whether autocorrection panel is shown.
14285 * WebCoreSupport/WebEditorClient.mm:
14286 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
14287 for invalid correction panel tag. Replaced -1 with this constant.
14288 (WebEditorClient::dismissCorrectionPanel): Ditto
14289 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
14291 2010-09-14 Mark Rowe <mrowe@apple.com>
14293 Reviewed by John Sullivan.
14295 Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.
14297 * Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
14298 * Misc/WebKitVersionChecks.m:
14299 (WebKitLinkedOnOrAfter):
14300 (setWebKitLinkTimeVersion): Set the overridden version.
14301 (WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.
14302 * WebView/WebPreferences.mm:
14303 (+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.
14304 * WebView/WebPreferencesPrivate.h:
14306 2010-09-14 Eric Seidel <eric@webkit.org>
14308 Unreviewed, reverting changes r67451 and r67451.
14309 Broke lots of builders.
14311 Only intercept ESC key press when autocorrection UI is visible.
14312 https://bugs.webkit.org/show_bug.cgi?id=45071
14314 * WebCoreSupport/WebEditorClient.h:
14315 * WebCoreSupport/WebEditorClient.mm:
14316 (WebEditorClient::WebEditorClient):
14317 (WebEditorClient::dismissCorrectionPanel):
14319 2010-09-14 Jia Pu <jpu@apple.com>
14321 Reviewed by Dan Bernstein.
14323 Only intercept ESC key press when autocorrection UI is visible.
14324 https://bugs.webkit.org/show_bug.cgi?id=45071
14326 * WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(),
14327 which provides an inteface to query whether autocorrection panel is shown.
14329 * WebCoreSupport/WebEditorClient.mm:
14330 (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,
14331 for invalid correction panel tag. Replaced -1 with this constant.
14332 (WebEditorClient::dismissCorrectionPanel): Ditto
14333 (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.
14335 2010-09-13 Darin Adler <darin@apple.com>
14337 Reviewed by Adam Barth.
14339 Preparation for eliminating deprecatedParseURL
14340 https://bugs.webkit.org/show_bug.cgi?id=45695
14342 * DOM/WebDOMOperations.mm:
14343 (-[DOMDocument webFrame]): Get rid of unneeded local variable.
14344 (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.
14346 2010-09-13 Enrica Casucci <enrica@apple.com>
14348 Reviewed by Sam Weinig.
14350 Paste should be implemented in WebCore like Copy and Cut for Mac also.
14351 https://bugs.webkit.org/show_bug.cgi?id=45494
14352 <rdar://problem/7660537>
14354 On the Mac platform, the implementation of the paste operation is all done
14355 at the WebKit level. In order to support it on WebKit2 it is necessary to
14356 refactor the code and move this functionality at the level of WebCore like
14357 we already have on Windows.
14358 The original code relies on some in AppKit functions that call back into
14359 WebKit causing problems in WebKit2. All this functionality has been moved
14360 at the level of the editor client where it can be dealt with appropriately.
14362 * WebCoreSupport/WebEditorClient.h:
14363 * WebCoreSupport/WebEditorClient.mm:
14364 (excludedElementsForAttributedStringConversion):
14365 (WebEditorClient::documentFragmentFromAttributedString): Added.
14366 (WebEditorClient::setInsertionPasteboard):
14367 * WebCoreSupport/WebFrameLoaderClient.h:
14368 * WebCoreSupport/WebFrameLoaderClient.mm:
14369 (WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
14370 of the editor client.
14371 * WebView/WebHTMLView.mm: Removed paste method.
14373 2010-09-13 John Sullivan <sullivan@apple.com>
14375 Reviewed by Adam Roben.
14377 https://bugs.webkit.org/show_bug.cgi?id=45677
14378 [WebView canMarkAllTextMatches] can crash if called after [WebView close]
14380 <rdar://problem/8404890>
14382 * WebView/WebView.mm:
14383 (-[WebView canMarkAllTextMatches]):
14384 Return NO immediately if the webview has already been closed. This was an overlooked
14385 case from the fix for 45175.
14387 2010-09-10 MORITA Hajime <morrita@google.com>
14389 Reviewed by Tony Chang.
14391 [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
14392 https://bugs.webkit.org/show_bug.cgi?id=45441
14394 Moved the actual logic of hasSpellingMarker into WebCore to share
14395 it with other ports.
14397 * WebView/WebFrame.mm:
14398 (-[WebFrame hasSpellingMarker:length:]):
14400 2010-09-11 Adam Barth <abarth@webkit.org>
14402 Reviewed by Sam Weinig.
14404 Make SecurityOrigin::canDisplay an instance function
14405 https://bugs.webkit.org/show_bug.cgi?id=45219
14407 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14408 (WebKit::NetscapePluginInstanceProxy::loadRequest):
14409 * Plugins/WebNetscapePluginStream.mm:
14410 (WebNetscapePluginStream::WebNetscapePluginStream):
14411 * Plugins/WebNetscapePluginView.mm:
14412 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
14413 * Plugins/WebPluginContainerCheck.mm:
14414 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
14415 * WebView/WebFrame.mm:
14416 (-[WebFrame _allowsFollowingLink:]):
14418 2010-09-10 Sam Weinig <sam@webkit.org>
14420 Reviewed by Darin Adler.
14422 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
14423 Precursor to <rdar://problem/7660657>
14424 https://bugs.webkit.org/show_bug.cgi?id=45522
14426 * WebView/WebView.mm:
14427 (-[WebView _preferencesChangedNotification:]):
14428 (-[WebView _setZoomMultiplier:isTextOnly:]):
14429 (-[WebView _realZoomMultiplierIsTextOnly]):
14430 * WebView/WebViewData.h:
14431 * WebView/WebViewData.mm:
14432 (-[WebViewPrivate init]):
14433 Move tracking of text only zoom here from WebCore.
14435 2010-09-10 Stephanie Lewis <slewis@apple.com>
14437 Reviewed by Alexey Proskuryakov.
14439 Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
14440 other implementation details of JavaScriptCore. Necessary to fix PPC build.
14442 https://bugs.webkit.org/show_bug.cgi?id=45528
14444 * Misc/WebCoreStatistics.mm:
14445 (+[WebCoreStatistics memoryStatistics]):
14447 2010-09-10 Darin Adler <darin@apple.com>
14449 Reviewed by Sam Weinig.
14451 Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
14452 https://bugs.webkit.org/show_bug.cgi?id=45582
14454 * MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
14456 * WebCoreSupport/WebChromeClient.mm:
14457 (WebChromeClient::dashboardRegionsChanged): Changed this to call
14458 -[WebView _dashboardRegions] so we don't have two copies of that code.
14460 * WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
14461 * WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
14463 * WebView/WebView.mm:
14464 (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.
14466 2010-09-10 Adam Barth <abarth@webkit.org>
14468 Reviewed by Darin Fisher.
14470 Move code from WebKit-layer to DocumentLoader
14471 https://bugs.webkit.org/show_bug.cgi?id=45569
14473 This code is the most confused, but now should be a bit cleaner.
14474 There's still a magical fake-setting for creating renderers that needs
14475 to be cleaned up, but we can do that in a separate patch.
14477 * WebView/WebFrame.mm:
14478 (-[WebFrame _commitData:]):
14479 * WebView/WebFrameInternal.h:
14480 * WebView/WebHTMLRepresentation.mm:
14481 (-[WebHTMLRepresentation receivedData:withDataSource:]):
14482 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
14484 2010-09-09 Darin Adler <darin@apple.com>
14486 Reviewed by Adam Barth.
14488 Move functions from Frame to SelectionController as planned
14489 https://bugs.webkit.org/show_bug.cgi?id=45508
14491 * WebView/WebFrame.mm:
14492 (-[WebFrame _selectionGranularity]):
14493 (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
14494 (-[WebFrame _typingStyle]):
14495 (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
14496 * WebView/WebHTMLRepresentation.mm:
14497 (-[WebHTMLRepresentation currentForm]):
14498 * WebView/WebHTMLView.mm:
14499 (-[WebHTMLView jumpToSelection:]):
14500 (-[WebHTMLView centerSelectionInVisibleArea:]):
14501 (-[WebHTMLView _canSmartCopyOrDelete]):
14502 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
14503 (-[WebHTMLView selectionRect]):
14504 (-[WebHTMLView selectionTextRects]):
14505 (-[WebHTMLView selectionImageRect]):
14506 * WebView/WebView.mm:
14507 (-[WebView setEditable:]):
14508 Call functions on selection().
14510 2010-09-10 Adam Barth <abarth@webkit.org>
14512 Reviewed by Eric Seidel.
14514 Main resource bytes shouldn't bounce through FrameLoader
14515 https://bugs.webkit.org/show_bug.cgi?id=45496
14517 Now return the bytes to the DocumentLoader.
14519 Previously, we were checking the document for null. However, Frame can
14520 never have a null document, so this check is no longer needed.
14522 * WebView/WebFrame.mm:
14523 (-[WebFrame _addData:]):
14525 2010-09-09 John Therrell <jtherrell@apple.com>
14527 Reviewed by Alexey Proskuryakov.
14529 Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes
14530 https://bugs.webkit.org/show_bug.cgi?id=45134
14532 Added ability to enable new JavaScriptCore statistics sampling and reporting for RegisterFile
14533 and ExecutableAllocator classes. Added reporting of JavaScriptCore's stack committed memory
14534 and JIT code committed memory statistics to WebCoreStatistics memoryStatistics.
14536 * Misc/WebCoreStatistics.mm:
14537 (+[WebCoreStatistics memoryStatistics]):
14538 Added statistics reporting for JSC RegisterFile and ExecutableAllocator.
14540 2010-09-09 Jer Noble <jer.noble@apple.com>
14542 Reviewed by Mark Rowe.
14544 Use of ENABLE macro in WebUIDelegatePrivate.h breaks use from outside WebKit
14545 <rdar://problem/8412657>
14547 * WebView/WebUIDelegatePrivate.h: Use ENABLE_FULLSCREEN_API instead of ENABLE(FULLSCREEN_API)
14549 2010-09-08 Darin Adler <darin@apple.com>
14551 Reviewed by Adam Barth.
14553 Move functions from Frame to Editor as planned
14554 https://bugs.webkit.org/show_bug.cgi?id=45218
14556 * WebView/WebFrame.mm:
14557 (-[WebFrame _selectedString]):
14558 (-[WebFrame _firstRectForDOMRange:]):
14559 (-[WebFrame _markDOMRange]):
14560 (-[WebFrame _setTypingStyle:withUndoAction:]):
14561 * WebView/WebHTMLRepresentation.mm:
14562 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
14563 * WebView/WebHTMLView.mm:
14564 (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
14565 (-[WebHTMLView toggleBaseWritingDirection:]):
14566 (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
14567 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
14568 (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
14569 (-[WebHTMLView markedTextMatchesAreHighlighted]):
14570 * WebView/WebView.mm:
14571 (-[WebView setEditable:]):
14572 Changed call sites to use editor().
14574 2010-09-08 MORITA Hajime <morrita@google.com>
14576 Reviewed by Ojan Vafai.
14578 spellcheck does not check pasted text
14579 https://bugs.webkit.org/show_bug.cgi?id=40092
14581 Implemented async spell-check APIs on WebEditorClient.
14582 The implementations are using [NSSpellChecker requestCheckingOfString]
14583 which is available only on Mac OS 10.6 or later.
14585 Note that [NSSpellChecker requestCheckingOfString] could invoke
14586 the callback block on on of their worker thread, so we need to
14587 return the result to the main thread where WebCore is running.
14588 For that purpose, we made WebEditorSpellCheckResponder class.
14590 Test: editing/spelling/spellcheck-pasted-text-001.html
14592 * WebCoreSupport/WebEditorClient.h:
14593 * WebCoreSupport/WebEditorClient.mm:
14594 (WebEditorClient::isAsynchronousSpellCheckingEnabled): Added.
14595 (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]): Added.
14596 (-[WebEditorSpellCheckResponder perform]): Added.
14597 (WebEditorClient::requestCheckingOfString): Added.
14598 * WebView/WebFramePrivate.h:
14600 2010-09-08 MORITA Hajime <morrita@google.com>
14602 Reviewed by Tony Chang.
14604 spelling underline gets lost on backspace
14605 https://bugs.webkit.org/show_bug.cgi?id=41423
14607 Switched to use a anchorNode of the selection instead of a focused
14608 node for finer control of node selection in spellingNode():
14609 With the focused node, we cannot select other nodes but the first
14610 child of that node. In some case, we need to inspect these.
14612 The API is only for LayoutTests, and the change is compatible for
14613 existing test cases.
14615 * WebView/WebFrame.mm:
14618 2010-09-08 Adam Barth <abarth@webkit.org>
14620 Rubber-stamped by Eric Seidel.
14622 Rename DocLoader to CachedResourceLoader because that's what it does.
14624 * WebView/WebFrame.mm:
14626 2010-09-07 Anders Carlsson <andersca@apple.com>
14628 Reviewed by Oliver Hunt.
14632 * Misc/WebLocalizableStrings.h:
14633 Fix a struct/tag mismatch.
14635 * WebView/WebDeviceOrientationProviderMock.mm:
14636 (-[WebDeviceOrientationProviderMock init]):
14637 Remove stray semicolon.
14639 * WebView/WebViewData.h:
14640 Remove unused class forward declaration.
14642 2010-09-07 Anders Carlsson <andersca@apple.com>
14644 Reviewed by Darin Adler.
14646 <rdar://problem/8381749> -Wcast-align warning emitted when building with clang
14648 Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.
14650 * Configurations/Base.xcconfig:
14652 2010-09-06 Adam Barth <abarth@webkit.org>
14654 Reviewed by Darin Adler.
14656 Rename SecurityOrigin::canLoad to canDisplay
14657 https://bugs.webkit.org/show_bug.cgi?id=45214
14659 Propagate name change.
14661 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
14662 (WebKit::NetscapePluginInstanceProxy::loadRequest):
14663 * Plugins/WebNetscapePluginStream.mm:
14664 (WebNetscapePluginStream::WebNetscapePluginStream):
14665 * Plugins/WebNetscapePluginView.mm:
14666 (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
14667 * Plugins/WebPluginContainerCheck.mm:
14668 (-[WebPluginContainerCheck _isForbiddenFileLoad]):
14669 * WebView/WebFrame.mm:
14670 (-[WebFrame _allowsFollowingLink:]):
14672 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
14674 Reviewed by Darin Adler.
14676 Add NetworkingContext to avoid layer violations
14677 https://bugs.webkit.org/show_bug.cgi?id=42292
14679 Add Mac's specific implementation of FrameNetworkingContext.
14681 * WebCoreSupport/WebFrameLoaderClient.h:
14682 * WebCoreSupport/WebFrameLoaderClient.mm:
14683 * WebCoreSupport/WebFrameNetworkingContext.mm:
14684 (WebFrameNetworkingContext::needsSiteSpecificQuirks):
14685 (WebFrameNetworkingContext::localFileContentSniffingEnabled):
14686 (WebFrameNetworkingContext::scheduledRunLoopPairs):
14687 (WebFrameNetworkingContext::blockedError):
14689 2010-09-03 John Sullivan <sullivan@apple.com>
14691 Reviewed by Dan Bernstein.
14693 https://bugs.webkit.org/show_bug.cgi?id=45175
14694 [WebView unmarkAllTextMatches] will crash if the webview is already closed
14696 Made this and related methods robust against being called when the WebView is closed.
14698 * WebView/WebView.mm:
14699 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
14700 Bail out if the WebView is closed.
14701 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
14703 (-[WebView unmarkAllTextMatches]):
14705 (-[WebView rectsForTextMatches]):
14708 2010-09-03 Hironori Bono <hbono@chromium.org>
14710 Reviewed by Kent Tamura.
14712 Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
14713 and implements it for Mac.
14714 https://bugs.webkit.org/show_bug.cgi?id=41832
14716 * WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:].
14718 (-[WebFrame hasSpellingMarker:length:]):
14719 * WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it.
14721 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
14723 Reviewed by Pavel Feldman.
14725 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
14726 https://bugs.webkit.org/show_bug.cgi?id=44230
14728 * WebCoreSupport/WebInspectorClient.h:
14729 * WebCoreSupport/WebInspectorClient.mm:
14730 (WebInspectorFrontendClient::closeWindow):
14731 (WebInspectorFrontendClient::disconnectFromBackend):
14732 (-[WebInspectorWindowController windowShouldClose:]):
14733 (-[WebInspectorWindowController destroyInspectorView:]):
14735 2010-09-02 Steve Block <steveblock@google.com>
14737 Reviewed by Adam Barth.
14739 Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
14740 https://bugs.webkit.org/show_bug.cgi?id=43181
14742 This patch hooks up the mock device orientation client on Mac for use
14745 The patch adds a new WebDeviceOrientationClient for Mac. This client acts
14746 as a proxy to either a real or mock device orientation provider, both of
14747 which implement a new WebDeviceOrientationProvider interface.
14749 The provider is created by the embedder and passed to the WebView, from
14750 where WebDeviceOrientationClient can access it.
14752 The mock provider, WebDeviceOrientationProviderMock, is a wrapper around
14753 the existing WebCore mock.
14755 * WebCoreSupport/WebDeviceOrientationClient.h: Added.
14756 * WebCoreSupport/WebDeviceOrientationClient.mm: Added.
14757 (WebDeviceOrientationClient::WebDeviceOrientationClient):
14758 (WebDeviceOrientationClient::setController):
14759 (WebDeviceOrientationClient::startUpdating):
14760 (WebDeviceOrientationClient::stopUpdating):
14761 (WebDeviceOrientationClient::lastOrientation):
14763 * WebView/WebDeviceOrientation.h: Added.
14764 * WebView/WebDeviceOrientation.mm: Added.
14765 (-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]):
14767 (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
14768 (-[WebDeviceOrientation dealloc]):
14769 * WebView/WebDeviceOrientationInternal.h: Added.
14770 * WebView/WebDeviceOrientationProvider.h: Added.
14771 * WebView/WebDeviceOrientationProviderMock.h: Added.
14772 * WebView/WebDeviceOrientationProviderMock.mm: Added.
14773 (-[WebDeviceOrientationProviderMockInternal setOrientation:]):
14774 (-[WebDeviceOrientationProviderMockInternal setController:]):
14775 (-[WebDeviceOrientationProviderMockInternal startUpdating]):
14776 (-[WebDeviceOrientationProviderMockInternal stopUpdating]):
14777 (-[WebDeviceOrientationProviderMockInternal lastOrientation]):
14778 (-[WebDeviceOrientationProviderMock init]):
14779 (-[WebDeviceOrientationProviderMock dealloc]):
14780 (-[WebDeviceOrientationProviderMock setOrientation:]):
14781 (-[WebDeviceOrientationProviderMock setController:]):
14782 (-[WebDeviceOrientationProviderMock startUpdating]):
14783 (-[WebDeviceOrientationProviderMock stopUpdating]):
14784 (-[WebDeviceOrientationProviderMock lastOrientation]):
14785 * WebView/WebDeviceOrientationProviderMockInternal.h: Added.
14786 * WebView/WebView.mm:
14787 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
14788 (-[WebView _setDeviceOrientationProvider:]):
14789 (-[WebView _deviceOrientationProvider]):
14790 * WebView/WebViewData.h:
14791 * WebView/WebViewPrivate.h:
14793 2010-09-01 Jia Pu <jpu@apple.com>
14795 Reviewed by Dan Bernstein.
14797 Add support for autocorrection UI on Mac OS X.
14798 https://bugs.webkit.org/show_bug.cgi?id=44958
14799 <rdar://problem/7326847>
14801 See detailed high level description in WebCore/ChangeLog.
14803 * WebCoreSupport/WebEditorClient.h: Added new member methods declared in
14804 EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object.
14806 * WebCoreSupport/WebEditorClient.mm:
14807 (WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag.
14808 (WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is
14809 dismissed before destroying the object.
14810 (WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes.
14811 (WebEditorClient::showCorrectionPanel): Show autocorrection UI.
14812 (WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI.
14814 2010-09-01 Mark Rowe <mrowe@apple.com>
14816 Reviewed by Adam Roben.
14818 <rdar://problem/8374711> WebKit needs to compile without access to QuickDraw private headers.
14820 * Carbon/HIViewAdapter.m:
14821 * Carbon/HIWebView.mm:
14822 * Misc/QuickDrawCompatibility.h: Added.
14823 * Plugins/WebNetscapePluginView.mm:
14825 2010-08-31 Dave Hyatt <hyatt@apple.com>
14827 Reviewed by Sam Weinig.
14829 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
14830 the former can occur in more places without having to do the latter.
14832 Eliminate Mac-specific code for style re-application and recursive layout/style updating in
14833 favor of the cross-platform code that all the other ports use.
14835 * Carbon/HIWebView.mm:
14837 * WebCoreSupport/WebFrameLoaderClient.mm:
14838 (WebFrameLoaderClient::forceLayout):
14839 * WebView/WebHTMLView.mm:
14840 (-[WebHTMLView _propagateDirtyRectsToOpaqueAncestors]):
14841 (-[WebHTMLView viewWillDraw]):
14842 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
14843 (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
14844 (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
14845 (-[WebHTMLView reapplyStyles]):
14846 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
14847 (-[WebHTMLView setNeedsToApplyStyles:]):
14848 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
14849 (-[WebHTMLView _layoutIfNeeded]):
14850 (-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):
14851 * WebView/WebHTMLViewInternal.h:
14852 * WebView/WebView.mm:
14853 (-[WebView _viewWillDrawInternal]):
14855 2010-08-31 Sam Weinig <sam@webkit.org>
14857 Reviewed by Darin Adler.
14859 Add ability to count text matches without marking
14860 https://bugs.webkit.org/show_bug.cgi?id=43996
14862 Safari needs to be able to count text matches without triggering lots of repainting.
14863 Rename markAllMatchesForText: to countMatchesForText: and add a markMatches:
14864 parameter. For backwards compatibility markAllMatchesForText: calls
14865 countMatchesForText: and passes YES for markMatches:.
14867 * WebView/WebDocumentInternal.h:
14868 * WebView/WebHTMLView.mm:
14869 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
14870 (-[WebHTMLView countMatchesForText:caseSensitive:limit:markMatches:]):
14871 * WebView/WebPDFView.mm:
14872 (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
14873 (-[WebPDFView countMatchesForText:caseSensitive:limit:markMatches:]):
14874 * WebView/WebView.mm:
14875 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
14876 (-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
14877 * WebView/WebViewPrivate.h:
14879 2010-08-31 Darin Adler <darin@apple.com>
14881 Reviewed by Anders Carlsson.
14883 * WebInspector/WebInspectorFrontend.mm:
14884 (-[WebInspectorFrontend initWithFrontendClient:]): Remove a stray semicolon.
14886 2010-08-30 Mark Rowe <mrowe@apple.com>
14888 Reviewed by Darin Adler.
14890 <rdar://problem/8369736> WebKit build fails.
14892 Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed.
14894 * Carbon/HIViewAdapter.m:
14895 * Carbon/HIWebView.mm:
14896 * Plugins/WebNetscapePluginView.mm:
14898 2010-08-30 Andy Estes <aestes@apple.com>
14900 Reviewed by Darin Adler.
14902 REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in.
14903 https://bugs.webkit.org/show_bug.cgi?id=44865
14905 After http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in
14906 for authentication fail to log in. This is due to a bug in AppleConnect that r66156
14907 exposed, but since this will have a significant impact on users of WebKit nightly
14908 builds, a plugin-specific hack should be added while the underlying issue is being
14911 * WebCoreSupport/WebFrameLoaderClient.mm:
14912 (WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase
14913 if the plugin is of type 'application/x-snkp'.
14915 2010-08-27 Jer Noble <jer.noble@apple.com>
14917 Reviewed by Eric Carlson.
14919 text/plain non-video files cause <video> to hang (while reading them?)
14920 https://bugs.webkit.org/show_bug.cgi?id=44212
14922 Add the new WebKitSystemInterface function WKQTMovieDisableComponent to
14923 the initialization routine.
14925 * WebCoreSupport/WebSystemInterface.mm:
14926 (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent.
14928 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
14930 Unreviewed, rolling out r66198.
14931 http://trac.webkit.org/changeset/66198
14932 https://bugs.webkit.org/show_bug.cgi?id=44856
14934 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
14936 * WebCoreSupport/WebInspectorClient.h:
14937 * WebCoreSupport/WebInspectorClient.mm:
14938 (WebInspectorFrontendClient::closeWindow):
14939 (-[WebInspectorWindowController windowShouldClose:]):
14940 (-[WebInspectorWindowController destroyInspectorView]):
14942 2010-08-28 Darin Adler <darin@apple.com>
14944 Reviewed by Sam Weinig.
14946 Make an internal method used by Apple Mail into SPI
14947 https://bugs.webkit.org/show_bug.cgi?id=44832
14948 rdar://problem/5748951
14950 * WebView/WebFrame.mm:
14951 (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
14952 from the internal section to the private section.
14953 * WebView/WebFrameInternal.h: Moved the method declaration out of here.
14954 * WebView/WebFramePrivate.h: Moved the method declaration in here.
14956 2010-08-27 Jer Noble <jer.noble@apple.com>
14958 Reviewed by Eric Carlson.
14960 Add JavaScript API to allow a page to go fullscreen.
14961 rdar://problem/6867795
14963 Added chrome client overrides which support entering and exiting full screen. A new preference has
14964 been added (setFullScreenEnabled:) to control at runtime whether full screen support is enabled
14965 (defaults to disabled). Added a new WebKitFullScreenListener callback object which notifies WebCore
14966 when the chrome has started/finished its full screen animation.
14968 * Configurations/FeatureDefines.xcconfig:
14969 * WebCoreSupport/WebChromeClient.h:
14970 * WebCoreSupport/WebChromeClient.mm:
14971 (WebChromeClient::supportsFullscreenForElement):
14972 (WebChromeClient::enterFullscreenForElement):
14973 (WebChromeClient::exitFullscreenForElement):
14974 (-[WebKitFullScreenListener initWithElement:]):
14975 (-[WebKitFullScreenListener webkitWillEnterFullScreen]):
14976 (-[WebKitFullScreenListener webkitDidEnterFullScreen]):
14977 (-[WebKitFullScreenListener webkitWillExitFullScreen]):
14978 (-[WebKitFullScreenListener webkitDidExitFullScreen]):
14979 * WebView/WebPreferenceKeysPrivate.h:
14980 * WebView/WebPreferences.h:
14981 * WebView/WebPreferences.mm:
14982 (+[WebPreferences initialize]):
14983 (-[WebPreferences setFullScreenEnabled:]):
14984 (-[WebPreferences fullScreenEnabled]):
14985 * WebView/WebUIDelegatePrivate.h:
14986 * WebView/WebView.mm:
14987 (-[WebView _preferencesChangedNotification:]):
14989 2010-08-27 David Hyatt <hyatt@apple.com>
14991 Reviewed by Simon Fraser.
14993 https://bugs.webkit.org/show_bug.cgi?id=44788, implement HTML5-compliant doctype switching.
14995 Rename the various modes to match the HTML5 specification:
14996 ParseMode -> CompatibilityMode
14997 CompatMode -> QuirksMode
14998 AlmostStrictMode -> LimitedQuirksMode
14999 StrictMode -> NoQuirksMode
15001 Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
15002 instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.
15004 Clean up user stylesheets to minimize style recalculation when the mode is switched.
15006 Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
15007 dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
15008 Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
15011 determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
15014 * WebView/WebView.mm:
15015 (-[WebView _preferencesChangedNotification:]):
15017 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
15019 Reviewed by Pavel Feldman.
15021 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
15022 https://bugs.webkit.org/show_bug.cgi?id=44230
15024 * WebCoreSupport/WebInspectorClient.h:
15025 * WebCoreSupport/WebInspectorClient.mm:
15026 (WebInspectorFrontendClient::closeWindow):
15027 (WebInspectorFrontendClient::disconnectFromBackend):
15028 (-[WebInspectorWindowController windowShouldClose:]):
15029 (-[WebInspectorWindowController destroyInspectorView:]):
15031 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
15033 Unreviewed. Revert r66103 since Qt tests are failing.
15035 * WebCoreSupport/WebInspectorClient.h:
15036 * WebCoreSupport/WebInspectorClient.mm:
15037 (WebInspectorFrontendClient::closeWindow):
15038 (-[WebInspectorWindowController windowShouldClose:]):
15039 (-[WebInspectorWindowController destroyInspectorView]):
15041 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
15043 Reviewed by Pavel Feldman.
15045 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
15046 https://bugs.webkit.org/show_bug.cgi?id=44230
15048 * WebCoreSupport/WebInspectorClient.h:
15049 * WebCoreSupport/WebInspectorClient.mm:
15050 (WebInspectorFrontendClient::closeWindow):
15051 (WebInspectorFrontendClient::disconnectFromBackend):
15052 (-[WebInspectorWindowController windowShouldClose:]):
15053 (-[WebInspectorWindowController destroyInspectorView:]):
15055 2010-08-24 Eric Seidel <eric@webkit.org>
15057 Reviewed by Adam Barth.
15059 Remove HTML5 parser testing infrastructure now that we don't need it
15060 https://bugs.webkit.org/show_bug.cgi?id=44581
15062 * WebView/WebPreferenceKeysPrivate.h:
15063 * WebView/WebPreferences.mm:
15064 (+[WebPreferences initialize]):
15065 * WebView/WebPreferencesPrivate.h:
15066 * WebView/WebView.mm:
15067 (-[WebView _preferencesChangedNotification:]):
15069 2010-08-24 Sam Weinig <sam@webkit.org>
15071 Reviewed by Oliver Hunt.
15073 Paste event fires twice for mac WebKit
15074 <rdar://problem/8094611>
15075 https://bugs.webkit.org/show_bug.cgi?id=44535
15077 The mac implementation of paste in WebKit was accidentally calling
15078 Editor::tryDHTMLPaste twice, once in -[WebHTMLView paste:] and once
15079 in Editor::pasteAsPlainText (which is called -[WebHTMLView paste:]).
15080 Use the new pasteAsPlainTextBypassingDHTML function to bypass the
15083 * WebView/WebHTMLView.mm:
15084 (-[WebHTMLView paste:]):
15086 2010-08-24 Daniel Cheng <dcheng@chromium.org>
15088 Reviewed by Eric Seidel.
15090 [chromium] Generate drag images for HTML elements and selections.
15091 https://bugs.webkit.org/show_bug.cgi?id=43449
15093 Fix up calls to Frame::nodeImage, which has a new signature.
15095 * Plugins/WebBaseNetscapePluginView.mm:
15096 (-[WebBaseNetscapePluginView halt]):
15098 2010-08-23 Mike Thole <mthole@apple.com>
15100 Reviewed by Dan Bernstein.
15102 WebPDFView should remove itself as the delegate of its PDFView before being dealloced
15103 https://bugs.webkit.org/show_bug.cgi?id=44441
15105 * WebView/WebPDFView.mm:
15106 (-[WebPDFView dealloc]): Set the PDFView's delegate to nil.
15108 2010-08-22 Daniel Bates <dbates@rim.com>
15110 Reviewed by Eric Seidel.
15112 Encapsulate document marker management into DocumentMarkerController
15113 https://bugs.webkit.org/show_bug.cgi?id=44383
15115 Modify call sites in the Apple Mac port to use DocumentMarkerController.
15117 No functionality was changed, so no new tests.
15119 * WebView/WebFrame.mm:
15120 (-[WebFrame _unmarkAllBadGrammar]):
15121 (-[WebFrame _unmarkAllMisspellings]):
15122 * WebView/WebHTMLView.mm:
15123 (-[WebHTMLView unmarkAllTextMatches]):
15124 (-[WebHTMLView rectsForTextMatches]):
15126 2010-08-19 David Kilzer <ddkilzer@apple.com>
15128 <http://webkit.org/b/44285> Fix compilation with NETSCAPE_PLUGIN_API disabled
15130 Reviewed by Joseph Pecoraro.
15132 * Plugins/Hosted/HostedNetscapePluginStream.mm: Changed
15133 USE(PLUGIN_HOST_PROCESS) to
15134 USE(PLUGIN_HOST_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API).
15135 * Plugins/Hosted/NetscapePluginHostManager.mm: Ditto.
15136 * Plugins/Hosted/NetscapePluginHostProxy.mm: Ditto.
15137 * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Ditto.
15138 * Plugins/Hosted/ProxyInstance.mm: Ditto.
15139 * Plugins/Hosted/WebHostedNetscapePluginView.mm: Ditto.
15140 * WebCoreSupport/WebChromeClient.mm: Ditto.
15141 (WebChromeClient::createWindow):
15142 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
15143 (WebFrameLoaderClient::dispatchCreatePage):
15144 * WebView/WebHTMLView.mm:
15145 (needsCursorRectsSupportAtPoint): Added #if
15146 ENABLE(NETSCAPE_PLUGIN_API) and #endif macros as needed.
15147 * WebView/WebView.mm:
15148 (+[WebView _isNodeHaltedPlugin:]): Ditto.
15149 (+[WebView _hasPluginForNodeBeenHalted:]): Ditto.
15150 (+[WebView _restartHaltedPluginForNode:]): Ditto.
15152 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
15154 Reviewed by Darin Adler.
15156 Add NetworkingContext to avoid layer violations
15157 https://bugs.webkit.org/show_bug.cgi?id=42292
15159 Preparation: Just add the files to the build system.
15161 * WebCoreSupport/WebFrameNetworkingContext.h: Added.
15162 Placeholder with tentative code that might be changed when landing
15164 * WebCoreSupport/WebFrameNetworkingContext.mm: Added.
15165 Empty placeholder for now.
15167 2010-08-17 Brady Eidson <beidson@apple.com>
15169 Reviewed by Sam Weinig.
15171 Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
15172 <rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
15174 * WebView/WebView.mm:
15175 (-[WebView canGoBack]): Return false if loads are deferred.
15176 (-[WebView canGoForward]): Ditto.
15178 2010-08-14 Joseph Pecoraro <joepeck@webkit.org>
15180 Reviewed by Pavel Feldman.
15182 Web Inspector: -[WebInspector attach] and detach should work
15183 https://bugs.webkit.org/show_bug.cgi?id=43924
15185 For actions that relate only to the Web Inspector's Frontend
15186 window (actions on the InspectorFrontendClient) the new Obj-C
15187 wrapper class WebInspectorFrontend can be used. For now, this
15188 is just attach and detach.
15190 * WebCoreSupport/WebInspectorClient.mm:
15191 (WebInspectorClient::openInspectorFrontend): setup and attach the WebInspectorFrontend to the WebInspector.
15192 * WebInspector/WebInspector.h:
15193 * WebInspector/WebInspector.mm:
15194 (-[WebInspector dealloc]):
15195 (-[WebInspector attach:]): delegate to the frontend.
15196 (-[WebInspector detach:]): delegate to the frontend.
15197 (-[WebInspector setFrontend:]):
15198 * WebInspector/WebInspectorFrontend.h: Added.
15199 * WebInspector/WebInspectorFrontend.mm: Added.
15200 (-[WebInspectorFrontend initWithFrontendClient:]):
15201 (-[WebInspectorFrontend attach]):
15202 (-[WebInspectorFrontend detach]):
15203 * WebInspector/WebInspectorPrivate.h:
15205 2010-08-13 Gavin Barraclough <barraclough@apple.com>
15207 Rubber stamped by Sam Weinig.
15208 Switch String::/UString::ascii() to return a CString.
15210 * Plugins/Hosted/ProxyInstance.mm:
15211 (WebKit::ProxyInstance::methodsNamed):
15212 (WebKit::ProxyInstance::fieldNamed):
15214 2010-08-13 Gavin Barraclough <barraclough@apple.com>
15216 Reviewed by Sam Weinig
15218 Unify UString::UTF8String() & String::utf8() methods,
15219 remove UString::cost() & make atArrayIndex a free function.
15221 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15222 (WebKit::NetscapePluginInstanceProxy::enumerate):
15224 2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
15226 Unreviewed, rolling out r65295.
15227 http://trac.webkit.org/changeset/65295
15228 https://bugs.webkit.org/show_bug.cgi?id=43950
15230 It broke 4 sputnik tests (Requested by Ossy on #webkit).
15232 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15233 (WebKit::NetscapePluginInstanceProxy::enumerate):
15235 2010-08-12 Gavin Barraclough <barraclough@apple.com>
15237 Reviewed by Sam Weinig
15239 Unify UString::UTF8String() & String::utf8() methods,
15240 remove UString::cost() & make atArrayIndex a free function.
15242 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
15243 (WebKit::NetscapePluginInstanceProxy::enumerate):
15245 2010-08-12 Jeremy Orlow <jorlow@chromium.org>
15248 https://bugs.webkit.org/show_bug.cgi?id=43794
15250 * WebView/WebView.mm:
15251 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
15252 (-[WebView _preferencesChangedNotification:]):
15254 2010-08-10 Jeremy Orlow <jorlow@chromium.org>
15256 Reviewed by Adam Barth.
15258 Some settings are linked to the PageGroup not the Page. Create a new class for those.
15259 https://bugs.webkit.org/show_bug.cgi?id=43794
15261 Change WebView to use the new GroupSettings class rather than Settings for the
15262 settings that moved. This is sub-optimal since the settings aren't really
15263 per-view, but we can't really change the API at this point.
15265 * WebView/WebView.mm:
15266 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
15267 (-[WebView _preferencesChangedNotification:]):
15269 2010-08-11 Gavin Barraclough <barraclough@apple.com>
15271 Rubber stamps by Darin Adler & Sam Weinig.
15273 Bug 43867 - Some UString cleanup
15275 Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
15276 Move string concatenation methods to a new header to simplify down UString.h. Remove is8Bit().
15278 * WebView/WebScriptDebugger.mm:
15281 2010-08-10 David Hyatt <hyatt@apple.com>
15283 Reviewed by Dan Bernstein.
15285 https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.
15287 Add SPI for entering and exiting screen pagination mode. This is similar to printing mode but it can be done for on-screen
15290 * WebView/WebHTMLView.mm:
15291 (-[WebHTMLView _web_setPrintingModeRecursive]):
15292 (-[WebHTMLView _web_clearPrintingModeRecursive]):
15293 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
15294 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
15295 (-[WebHTMLView _endPrintMode]):
15296 (-[WebHTMLView _isInScreenPaginationMode]):
15297 (-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
15298 (-[WebHTMLView _endScreenPaginationMode]):
15299 (-[WebHTMLView reapplyStyles]):
15300 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
15301 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
15302 (-[WebHTMLView setPageWidthForPrinting:]):
15303 * WebView/WebHTMLViewPrivate.h:
15305 2010-08-10 Gavin Barraclough <barraclough@apple.com>
15307 Build fix (update more includes)
15309 * Plugins/Hosted/NetscapePluginHostManager.h:
15311 2010-08-10 Chris Marrin <cmarrin@apple.com>
15313 Reviewed by Oliver Hunt.
15315 Add suspendAnimations/resumeAnimation API to DRT
15316 https://bugs.webkit.org/show_bug.cgi?id=43733
15318 Mac specific API. Plumbs suspendAnimations/resumeAnimations down to WebCore.
15320 * WebView/WebFrame.mm:
15321 (-[WebFrame _suspendAnimations]):
15322 (-[WebFrame _resumeAnimations]):
15323 * WebView/WebFramePrivate.h:
15325 2010-08-10 Gavin Barraclough <barraclough@apple.com>
15327 Rubber stamped by Sam Weinig
15329 Bug 43817 - Remove UString::Rep
15330 UString::Rep has for a long time been replaced by UStringImpl (Rep
15331 remaining as a typedef). UStringImpl has since been removed too
15332 (unified with StringImpl). Remove Rep, rename rep() to impl() and
15333 m_rep to m_impl. Also add impl() method to Identifier, and rename
15334 its UString member from _ustring to m_string.
15336 * Plugins/Hosted/ProxyInstance.mm:
15337 (WebKit::ProxyInstance::methodsNamed):
15338 (WebKit::ProxyInstance::fieldNamed):
15340 2010-08-06 Gavin Barraclough <barraclough@apple.com>
15342 Rubber stamped by Sam Weinig
15344 Bug 43594 - Add string forwards to Forward.h
15345 This allows us to remove forward declarations for these classes from
15346 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
15348 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
15349 * Plugins/WebBaseNetscapePluginView.h:
15350 * WebCoreSupport/WebFrameLoaderClient.h:
15351 * WebCoreSupport/WebIconDatabaseClient.h:
15352 * WebCoreSupport/WebPluginHalterClient.h:
15353 * WebView/WebViewInternal.h:
15355 2010-08-04 MORITA Hajime <morrita@google.com>
15357 Reviewed by Tony Chang.
15359 Pasting should fire textInput event.
15360 https://bugs.webkit.org/show_bug.cgi?id=42958
15362 On paste, invoke Editor instead of direct command invocation,
15363 which allows dispatching events before actual paste.
15365 * WebView/WebHTMLView.mm:
15366 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
15368 2010-08-06 Yongjun Zhang <yongjun_zhang@apple.com>
15370 Reviewed by Eric Seidel.
15372 add "const" to WebChromeClient::webView().
15373 https://bugs.webkit.org/show_bug.cgi?id=43631
15375 Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments
15376 is const method now, and calling webView() inside port-specific didReceiveViewportArguments
15377 implementation fails compiling if webView() is not const.
15379 * WebCoreSupport/WebChromeClient.h:
15380 (WebChromeClient::webView):
15382 2010-08-06 Jessie Berlin <jberlin@apple.com>
15384 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
15387 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
15388 * Plugins/WebBaseNetscapePluginView.h:
15389 * WebCoreSupport/WebFrameLoaderClient.h:
15390 * WebCoreSupport/WebIconDatabaseClient.h:
15391 * WebCoreSupport/WebPluginHalterClient.h:
15392 * WebView/WebViewInternal.h:
15394 2010-08-05 Joseph Pecoraro <joepeck@webkit.org>
15396 Reviewed by David Kilzer.
15398 Remove Invalid Asserts for Application Cache Quotas
15399 https://bugs.webkit.org/show_bug.cgi?id=43585
15401 Removed Invalid ASSERTs that would always happen for quotas
15402 that were not noQuota().
15404 * WebView/WebPreferences.mm:
15405 (-[WebPreferences applicationCacheTotalQuota]):
15406 (-[WebPreferences applicationCacheDefaultOriginQuota]):
15408 2010-08-05 Gavin Barraclough <barraclough@apple.com>
15410 Rubber stamped by Sam Weinig
15412 Bug 43594 - Add string forwards to Forward.h
15413 This allows us to remove forward declarations for these classes from
15414 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
15416 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
15417 * Plugins/WebBaseNetscapePluginView.h:
15418 * WebCoreSupport/WebFrameLoaderClient.h:
15419 * WebCoreSupport/WebIconDatabaseClient.h:
15420 * WebCoreSupport/WebPluginHalterClient.h:
15421 * WebView/WebViewInternal.h:
15423 2010-08-05 Jian Li <jianli@chromium.org>
15425 Reviewed by David Levin.
15427 Unify blob related feature defines to ENABLE(BLOB).
15428 https://bugs.webkit.org/show_bug.cgi?id=43081
15430 * Configurations/FeatureDefines.xcconfig:
15432 2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
15434 Reviewed by David Kilzer.
15436 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
15437 https://bugs.webkit.org/show_bug.cgi?id=40627
15439 Part 6 - LayoutTest and Cleanup
15441 * WebCoreSupport/WebApplicationCache.h:
15442 * WebCoreSupport/WebApplicationCache.mm:
15443 (+[WebApplicationCache setMaximumSize:]): refactor out deleting the application caches.
15444 (+[WebApplicationCache deleteAllApplicationCaches]): delete application caches.
15446 2010-08-03 Joseph Pecoraro <joepeck@webkit.org>
15448 Reviewed by David Kilzer.
15450 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
15451 https://bugs.webkit.org/show_bug.cgi?id=40627
15453 Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
15455 Per-Origin quotas exist for Databases and Application Caches. Clients
15456 given a WebSecurityOrigin have the ability to set the quota for any
15457 per-origin quota type. This puts quota management into an interface
15458 and WebSecurityOrigin allows access to quota managers for the
15459 different types of quotas.
15461 This also deprecates the old methods on WebSecurityOrigin. They are
15462 left in for now to prevent breaking older clients.
15464 The WebQuotaManager interface allows querying and modifying a
15465 per-origin quota. This is implemented for both Databases and
15466 Application Caches.
15468 * Misc/WebQuotaManager.h: Added. Interface for quota management (usage, quota, setQuota).
15469 * Storage/WebDatabaseQuotaManager.h: Added.
15470 * Storage/WebDatabaseQuotaManager.mm: Added.
15471 (-[WebDatabaseQuotaManager origin]):
15472 (-[WebDatabaseQuotaManager usage]):
15473 (-[WebDatabaseQuotaManager quota]):
15474 (-[WebDatabaseQuotaManager setQuota:]):
15475 * Storage/WebDatabaseSecurityOrigin.h: Removed.
15476 * Storage/WebDatabaseSecurityOrigin.mm: Removed.
15477 * WebCoreSupport/WebApplicationCacheQuotaManager.h: Added.
15478 * WebCoreSupport/WebApplicationCacheQuotaManager.mm: Added.
15479 (-[WebApplicationCacheQuotaManager origin]):
15480 (-[WebApplicationCacheQuotaManager usage]):
15481 (-[WebApplicationCacheQuotaManager quota]):
15482 (-[WebApplicationCacheQuotaManager setQuota:]):
15483 * WebCoreSupport/WebSecurityOriginPrivate.h: Added a category to access managers. Deprecated old methods.
15485 Remove the WebSecurityOrigin sub-classes. Managers are better.
15487 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Removed.
15488 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Removed.
15490 Create the managers lazily. Change old style calls to make use
15493 * WebCoreSupport/WebChromeClient.mm:
15494 (WebChromeClient::exceededDatabaseQuota):
15495 (WebChromeClient::reachedApplicationCacheOriginQuota):
15496 * WebCoreSupport/WebSecurityOrigin.mm:
15497 (-[WebSecurityOrigin applicationCacheQuotaManager]):
15498 (-[WebSecurityOrigin databaseQuotaManager]):
15499 (-[WebSecurityOrigin dealloc]): release the managers if they exist.
15501 2010-08-03 Alex Milowski <alex@milowski.com>
15503 Reviewed by Beth Dakin.
15505 Changed the ENABLE_MATHML value to enable MathML by default.
15507 * Configurations/FeatureDefines.xcconfig:
15509 2010-08-02 Brady Eidson <beidson@apple.com>
15511 Reviewed by Anders Carlsson.
15513 Add VisitedLinkStrategy for each platform to implement
15514 https://bugs.webkit.org/show_bug.cgi?id=43393
15516 * WebCoreSupport/WebPlatformStrategies.h:
15517 * WebCoreSupport/WebPlatformStrategies.mm:
15518 (WebPlatformStrategies::createVisitedLinkStrategy):
15519 (WebPlatformStrategies::isLinkVisited): Call back into PageGroup's visited links.
15520 (WebPlatformStrategies::addVisitedLink): Ditto.
15522 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
15524 Reviewed by Darin Fisher.
15526 PopupMenu refactoring in preparation to WebKit2
15527 https://bugs.webkit.org/show_bug.cgi?id=42592
15529 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
15530 instances, concrete classes that inherit from ChromeClient needed to be changed to
15531 implement the new methods.
15533 * WebCoreSupport/WebChromeClient.h:
15534 * WebCoreSupport/WebChromeClient.mm:
15535 (WebChromeClient::selectItemWritingDirectionIsNatural):
15536 (WebChromeClient::createPopupMenu):
15537 (WebChromeClient::createSearchPopupMenu):
15539 2010-08-02 Jeremy Orlow <jorlow@chromium.org>
15541 Speculative revert of 64425 due to Chromium instability
15542 https://bugs.webkit.org/show_bug.cgi?id=43347
15544 * WebCoreSupport/WebChromeClient.h:
15545 * WebCoreSupport/WebChromeClient.mm:
15547 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
15549 Reviewed by Darin Fisher.
15551 PopupMenu refactoring in preparation to WebKit2
15552 https://bugs.webkit.org/show_bug.cgi?id=42592
15554 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
15555 instances, concrete classes that inherit from ChromeClient needed to be changed to
15556 implement the new methods.
15558 * WebCoreSupport/WebChromeClient.h:
15559 * WebCoreSupport/WebChromeClient.mm:
15560 (WebChromeClient::selectItemWritingDirectionIsNatural):
15561 (WebChromeClient::createPopupMenu):
15562 (WebChromeClient::createSearchPopupMenu):
15564 2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
15566 Unreviewed, rolling out r64422.
15567 http://trac.webkit.org/changeset/64422
15568 https://bugs.webkit.org/show_bug.cgi?id=43304
15570 Build fixes are needed for Snow Leopard and Windows.
15571 (Requested by lca on #webkit).
15573 * WebCoreSupport/WebChromeClient.h:
15574 * WebCoreSupport/WebChromeClient.mm:
15576 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
15578 Reviewed by Darin Fisher.
15580 PopupMenu refactoring in preparation to WebKit2
15581 https://bugs.webkit.org/show_bug.cgi?id=42592
15583 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
15584 instances, concrete classes that inherit from ChromeClient needed to be changed to
15585 implement the new methods.
15587 * WebCoreSupport/WebChromeClient.h:
15588 * WebCoreSupport/WebChromeClient.mm:
15589 (WebChromeClient::selectItemWritingDirectionIsNatural):
15590 (WebChromeClient::createPopupMenu):
15591 (WebChromeClient::createSearchPopupMenu):
15593 2010-07-31 David Kilzer <ddkilzer@apple.com>
15595 <http://webkit.org/b/43300> Simplify variables in *.xcconfig files after adding iOS support
15597 Reviewed by Darin Adler.
15599 * Configurations/WebKit.xcconfig: Extracted
15600 PRODUCTION_FRAMEWORKS_DIR and PRODUCTION_ROOT variables.
15602 2010-07-30 Dan Bernstein <mitz@apple.com>
15604 Reviewed by Darin Adler.
15606 <rdar://problem/8257783> Short documents may print a second blank page
15607 https://bugs.webkit.org/show_bug.cgi?id=43271
15609 * WebView/WebHTMLView.mm:
15610 (-[WebHTMLView _web_setPrintingModeRecursive]): Updated for additional height parameter
15611 to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
15612 (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
15613 (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
15614 (-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]): Added height parameter,
15615 which is scaled and passed on to _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
15616 (-[WebHTMLView _endPrintMode]): Updated for additional height parameter to
15617 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:.
15618 (-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]): Added
15619 height parameter, which is passed on to FrameView::forceLayoutForPagination().
15620 (-[WebHTMLView layout]): Updated for additional height parameter.
15621 (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:]): Added height
15622 parameter, which is passed on to -layoutToMinimumPageWidth:height:maximumPageWidth:adjustViewSize:.
15623 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Updated for additional height
15625 (-[WebHTMLView setPageWidthForPrinting:]): Ditto.
15626 (-[WebHTMLView knowsPageRange:]): Pass the available height on the page on to
15627 _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize.
15628 * WebView/WebHTMLViewPrivate.h:
15630 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
15632 Fix for tests that broke after r64400. Tracking a more
15633 ideal solution in https://bugs.webkit.org/show_bug.cgi?id=40627
15635 Switch the interface back to (unsigned long long), and move
15636 the WebDatabaseSecurityOrigin implementation up into WebSecurityOrigin.
15637 The subclasses' implementations were not getting called.
15639 * Storage/WebDatabaseSecurityOrigin.mm:
15640 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm:
15641 (-[WebApplicationCacheSecurityOrigin quota]):
15642 (-[WebApplicationCacheSecurityOrigin setQuota:]):
15643 * WebCoreSupport/WebSecurityOrigin.mm:
15644 (-[WebSecurityOrigin usage]):
15645 (-[WebSecurityOrigin quota]):
15646 (-[WebSecurityOrigin setQuota:]):
15647 * WebCoreSupport/WebSecurityOriginPrivate.h:
15649 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
15651 Reviewed by David Kilzer.
15653 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
15654 https://bugs.webkit.org/show_bug.cgi?id=40627
15656 Part 4 - Client Notification when the Quota is Reached
15658 Notify the WebKit client when the per-origin quota is reached
15659 via a delegate method reachedApplicationCacheOriginQuota.
15661 Refactor the WebSecurityOrigin class to be generic enough to
15662 allow quota management of both Databases or Application Caches
15665 * Storage/WebDatabaseSecurityOrigin.h: Added.
15666 * Storage/WebDatabaseSecurityOrigin.mm: Added.
15667 (-[WebDatabaseSecurityOrigin quota]):
15668 (-[WebDatabaseSecurityOrigin setQuota:]):
15669 * WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Added.
15670 * WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Added.
15671 (-[WebApplicationCacheSecurityOrigin quota]):
15672 (-[WebApplicationCacheSecurityOrigin setQuota:]):
15673 * Storage/WebSecurityOrigin.mm: Removed. (Moved to WebCoreSupport)
15674 * Storage/WebSecurityOriginPrivate.h: Removed. (Moved to WebCoreSupport)
15675 * WebCoreSupport/WebSecurityOrigin.mm: Added.
15676 (-[WebSecurityOrigin usage]): to be implemented by subclasses.
15677 (-[WebSecurityOrigin quota]): to be implemented by subclasses.
15678 (-[WebSecurityOrigin setQuota:]): to be implemented by subclasses.
15679 * WebCoreSupport/WebSecurityOriginInternal.h: Renamed from WebKit/mac/Storage/WebSecurityOriginInternal.h.
15680 * WebCoreSupport/WebSecurityOriginPrivate.h: Added.
15682 Turn the notification into a WebUI Delegate to call. Following
15683 the example of Databases.
15685 * DefaultDelegates/WebDefaultUIDelegate.m:
15686 (-[WebDefaultUIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]):
15687 * WebCoreSupport/WebChromeClient.h:
15688 * WebCoreSupport/WebChromeClient.mm:
15689 (WebChromeClient::exceededDatabaseQuota): use the Databases Security Origin subclass.
15690 (WebChromeClient::reachedApplicationCacheOriginQuota): use the Application Cache Security Origin subclass.
15691 * WebView/WebUIDelegatePrivate.h:
15693 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
15695 Reviewed by David Kilzer.
15697 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
15698 https://bugs.webkit.org/show_bug.cgi?id=40627
15700 Part 1 - Add Total and Per-Origin Quota Preferences.
15702 Allow the application cache total size to be a preference, and
15703 add a new preference for the default per-origin quota.
15705 Storage quotas were int64_t (long long). Boilerplate for
15706 these types added for consistency.
15708 * Misc/WebNSDictionaryExtras.h:
15709 * Misc/WebNSDictionaryExtras.m:
15710 (-[NSMutableDictionary _webkit_setLongLong:forKey:]):
15711 * WebCoreSupport/WebApplicationCache.h: setters and accessors for WebCore's cacheStorage.
15712 * WebCoreSupport/WebApplicationCache.mm:
15713 (+[WebApplicationCache maximumSize:]):
15714 (+[WebApplicationCache setMaximumSize:]):
15715 (+[WebApplicationCache defaultOriginQuota]):
15716 (+[WebApplicationCache setDefaultOriginQuota:]):
15717 * WebView/WebPreferenceKeysPrivate.h:
15718 * WebView/WebPreferences.mm:
15719 (+[WebPreferences initialize]): defaults to noQuota for both preferences.
15720 (-[WebPreferences _longLongValueForKey:]):
15721 (-[WebPreferences _setLongLongValue:forKey:]):
15722 (-[WebPreferences applicationCacheTotalQuota]):
15723 (-[WebPreferences setApplicationCacheTotalQuota:]):
15724 (-[WebPreferences applicationCacheDefaultOriginQuota]):
15725 (-[WebPreferences setApplicationCacheDefaultOriginQuota:]):
15726 * WebView/WebPreferencesPrivate.h:
15727 * WebView/WebView.mm:
15728 (-[WebView _preferencesChangedNotification:]): respect updates to the preferences.
15730 2010-07-30 Andy Estes <aestes@apple.com>
15732 Reviewed by David Kilzer.
15734 Add Xcode support for compiling WebKit against iOS SDKs.
15735 https://bugs.webkit.org/show_bug.cgi?id=42796
15737 * Configurations/Base.xcconfig:
15738 * Configurations/DebugRelease.xcconfig:
15739 * Configurations/FeatureDefines.xcconfig:
15740 * Configurations/Version.xcconfig:
15741 * Configurations/WebKit.xcconfig:
15743 2010-07-26 Steve Block <steveblock@google.com>
15745 Reviewed by Jeremy Orlow.
15747 Page clients should be passed to Page constructor via structure of pointers
15748 https://bugs.webkit.org/show_bug.cgi?id=42834
15750 * WebView/WebView.mm:
15751 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
15753 2010-07-27 Kinuko Yasuda <kinuko@chromium.org>
15755 Reviewed by Ojan Vafai.
15757 Add FILE_SYSTEM build flag for FileSystem API
15758 https://bugs.webkit.org/show_bug.cgi?id=42915
15760 * Configurations/FeatureDefines.xcconfig:
15762 2010-07-27 Steve Block <steveblock@google.com>
15764 Reviewed by Jeremy Orlow.
15766 Client-based Geolocation does not pass enableHighAccuracy option to controller and client
15767 https://bugs.webkit.org/show_bug.cgi?id=40374
15769 Stub out setEnableHighAccuracy method for the Mac port.
15771 * WebCoreSupport/WebGeolocationControllerClient.h:
15772 (WebGeolocationControllerClient::setEnableHighAccuracy):
15774 2010-07-22 Sam Weinig <sam@webkit.org>
15776 Reviewed by Maciej Stachowiak.
15778 Fix for <rdar://problem/8222626>
15779 Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
15781 The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
15782 should migrate to a new function name eventually
15784 * WebCoreSupport/WebEditorClient.mm:
15785 (WebEditorClient::textDidChangeInTextField):
15787 2010-07-22 Sam Weinig <sam@webkit.org>
15789 Reviewed by Anders Carlsson.
15791 Patch for https://bugs.webkit.org/show_bug.cgi?id=42836
15792 Add localized strings stubs for WebKit2.
15794 - Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
15795 for localized strings.
15797 Gets us below 200 tests failing in WebKitTestRunner.
15799 * WebCoreSupport/WebContextMenuClient.mm:
15800 (fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory.
15801 * WebCoreSupport/WebPlatformStrategies.h:
15802 * WebCoreSupport/WebPlatformStrategies.mm:
15803 * WebCoreSupport/WebViewFactory.mm:
15805 2010-07-21 Brady Eidson <beidson@apple.com>
15807 Reviewed by Geoffrey Garen.
15809 Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
15810 https://bugs.webkit.org/show_bug.cgi?id=42783
15812 * WebView/WebView.mm:
15813 (+[WebView _registerURLSchemeAsSecure:]):
15814 (+[WebView registerURLSchemeAsLocal:]):
15816 2010-07-21 Simon Fraser <simon.fraser@apple.com>
15818 Reviewed by Anders Carlsson.
15820 Composited layers don't scroll in WebKit2
15821 https://bugs.webkit.org/show_bug.cgi?id=42771
15823 Prep work: FrameView::scrollPositionChanged() sounds like a generic "did scroll" bottleneck,
15824 but this is deceiving. It's only every called on one platform (Mac) when the NSScrollView gets
15825 scrolled, so rename it to FrameView::scrollPositionChangedViaPlatformWidget().
15827 * WebView/WebHTMLView.mm:
15828 (-[WebHTMLView _frameOrBoundsChanged]):
15830 2010-07-21 Eric Carlson <eric.carlson@apple.com>
15832 Reviewed by Simon Fraser.
15834 Update plug-in proxy backed <video> and <audio> elements.
15835 https://bugs.webkit.org/show_bug.cgi?id=42770
15836 <rdar://problem/7963467>
15838 * Plugins/WebPluginController.h:
15839 * Plugins/WebPluginController.mm:
15840 (-[WebPluginController dealloc]): Release _viewsNotInDocument.
15841 (-[WebPluginController stopAllPlugins]): Stop plug-ins not in the document.
15842 (-[WebPluginController pluginViewCreated:]): New, add a View (plug-in) to _viewsNotInDocument.
15843 (+[WebPluginController pluginViewHidden:]): New, remove the view (plug-in) from pluginViews.
15844 (-[WebPluginController addPlugin:]): Remove the new plug-in from _viewsNotInDocument.
15846 * WebCoreSupport/WebFrameLoaderClient.h:
15847 * WebCoreSupport/WebFrameLoaderClient.mm:
15848 (WebFrameLoaderClient::createPlugin): Remove PLUGIN_PROXY_FOR_VIDEO code, the media
15849 player proxy plug-in should never be allocated by this method.
15850 (WebFrameLoaderClient::createMediaPlayerProxyPlugin): New, allocate a media player proxy.
15852 * WebView/WebView.mm:
15853 (-[WebView _videoProxyPluginForMIMEType:]): New. Identical to _pluginForMIMEType except it doesn't
15854 consider the arePlugInsEnabled preference.
15855 * WebView/WebViewInternal.h:
15858 2010-07-19 Chris Marrin <cmarrin@apple.com>
15860 Reviewed by Darin Adler.
15862 https://bugs.webkit.org/show_bug.cgi?id=42118
15863 Disable WebGL on Leopard for now.
15865 LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
15866 GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
15867 SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
15868 software OpenGL driver on machines without this support.
15870 * Configurations/FeatureDefines.xcconfig:
15872 2010-07-18 Anders Carlsson <andersca@apple.com>
15874 Reviewed by Sam Weinig.
15876 Move PluginWidget to WebKit
15877 https://bugs.webkit.org/show_bug.cgi?id=42530
15879 * Plugins/WebBaseNetscapePluginView.h:
15880 * Plugins/WebBaseNetscapePluginView.mm:
15881 (-[WebBaseNetscapePluginView pluginLayer]):
15882 Add default pluginLayer implementation.
15884 * WebCoreSupport/WebFrameLoaderClient.mm:
15885 (PluginWidget::PluginWidget):
15886 (PluginWidget::invalidateRect):
15887 Move the guts of PluginWidget here from WebCore.
15889 (NetscapePluginWidget::platformLayer):
15890 Get the layer from the plug-in view.
15892 2010-07-18 David Kilzer <ddkilzer@apple.com>
15894 <http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods
15896 Reviewed by Dan Bernstein.
15898 * Carbon/CarbonWindowAdapter.mm:
15899 (-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]):
15900 (-[CarbonWindowAdapter _destroyRealWindow:]):
15901 (-[CarbonWindowAdapter _clearModalWindowLevel]):
15902 * Misc/WebIconDatabase.mm:
15903 (-[WebIconDatabase init]):
15904 * Misc/WebNSPasteboardExtras.mm:
15905 (-[NSFilePromiseDragSource initWithSource:]):
15906 * WebView/WebHTMLRepresentation.mm:
15907 (-[WebHTMLRepresentation init]):
15908 * WebView/WebPreferences.mm:
15909 (-[WebPreferences init]):
15910 * WebView/WebView.mm:
15911 (-[WebView UIDelegate]):
15912 (-[WebView resourceLoadDelegate]):
15913 (-[WebView downloadDelegate]):
15914 (-[WebView policyDelegate]):
15915 (-[WebView frameLoadDelegate]):
15917 2010-07-16 Zhe Su <suzhe@chromium.org>
15919 Reviewed by Darin Adler.
15921 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
15922 https://bugs.webkit.org/show_bug.cgi?id=42253
15924 Dummy implementation of EditorClient::willSetInputMethodState.
15926 * WebCoreSupport/WebEditorClient.h:
15927 * WebCoreSupport/WebEditorClient.mm:
15928 (WebEditorClient::willSetInputMethodState):
15930 2010-07-16 Dan Bernstein <mitz@apple.com>
15932 Reviewed by Sam Weinig.
15934 Part of <rdar://problem/7233974> Deprecate +[WebView _setShouldUseFontSmoothing:]
15935 https://bugs.webkit.org/show_bug.cgi?id=29355
15937 * Misc/WebKitNSStringExtras.h:
15938 * Misc/WebKitNSStringExtras.mm:
15939 (-[NSString _web_drawAtPoint:font:textColor:]): Now calls through to
15940 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing YES for the last
15942 (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Added
15943 allowingFontSmoothing:. If font smoothing is not allowed, sets the font smoothing
15944 mode to antialiased. Otherwise, sets it to auto.
15945 (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Instead of
15946 changing the font smoothing setting in the graphics context, call
15947 -_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing NO for the last
15950 2010-07-16 Anders Carlsson <andersca@apple.com>
15952 Reviewed by Sam Weinig.
15954 Remove semicolons from Objective-C method declarations.
15956 * WebView/WebRenderLayer.mm:
15957 (+[WebRenderLayer nameForLayer:]):
15958 (+[WebRenderLayer compositingInfoForLayer:]):
15960 2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
15962 Reviewed by Pavel Feldman.
15964 Make JS memory stats available via 'Performance' object (Web Timing).
15965 This statistics is populated only if 'WebKitMemoryInfoEnabled'
15968 'console.memory' is kept until Web Timing object becomes visible by
15969 default (currently it is hidden under compile-time flag). These stats
15970 are guarded with the same preference.
15972 https://bugs.webkit.org/show_bug.cgi?id=41617
15975 * WebView/WebPreferenceKeysPrivate.h:
15976 * WebView/WebPreferences.mm:
15977 (+[WebPreferences initialize]):
15978 (-[WebPreferences memoryInfoEnabled]):
15979 (-[WebPreferences setMemoryInfoEnabled:]):
15980 * WebView/WebPreferencesPrivate.h:
15981 * WebView/WebView.mm:
15982 (-[WebView _preferencesChangedNotification:]):
15984 2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>
15986 Reviewed by Darin Adler.
15988 Printing test results differ between machines, we should use ImageDiff instead
15989 https://bugs.webkit.org/show_bug.cgi?id=20011
15991 * Misc/WebCoreStatistics.h:
15992 * Misc/WebCoreStatistics.mm:
15993 (-[WebFrame printToCGContext:cgContext:pageWidthInPixels:]):
15995 2010-07-15 Daniel Bates <dbates@rim.com>
15997 Reviewed by Darin Adler.
15999 [Mac] Implement LayoutTestController::markerTextForListItem()
16000 https://bugs.webkit.org/show_bug.cgi?id=37929
16002 Implements support for markerTextForListItem in the Mac port.
16004 * DOM/WebDOMOperations.mm:
16005 (+[DOMElement _DOMElementFromJSContext]): Added.
16006 (-[DOMElement _markerTextForListItem]): Added.
16007 * DOM/WebDOMOperationsPrivate.h:
16009 2010-07-14 Simon Fraser <simon.fraser@apple.com>
16011 Fix non-ACCELERATED_COMPOSITING build.
16013 * WebView/WebRenderLayer.mm:
16014 (+[WebRenderLayer compositingInfoForLayer:]):
16016 2010-07-14 Simon Fraser <simon.fraser@apple.com>
16018 Reviewed by John Sullivan.
16020 <rdar://problem/8186963> Expose information about compositing layers.
16022 Use RenderLayerBacking::compositingLayerType() to add more information about compositing to
16023 WebRenderLayer, via a compositingInfo property. Also show element classnames.
16025 Also add separator items between the various z-order lists.
16027 * WebView/WebRenderLayer.h:
16028 * WebView/WebRenderLayer.mm:
16029 (+[WebRenderLayer nameForLayer:]):
16030 (+[WebRenderLayer compositingInfoForLayer:]):
16031 (-[WebRenderLayer initWithRenderLayer:]):
16032 (-[WebRenderLayer initWithName:]):
16033 (-[WebRenderLayer initWithWebFrame:]):
16034 (-[WebRenderLayer dealloc]):
16035 (-[WebRenderLayer buildDescendantLayers:]):
16036 (-[WebRenderLayer compositingInfo]):
16037 (-[WebRenderLayer isComposited]):
16038 (-[WebRenderLayer isSeparator]):
16040 2010-07-14 Darin Adler <darin@apple.com>
16042 Another try at fixing the Tiger build.
16044 Avoid non-ASCII in source files to keep Tiger compiler happy.
16046 * WebView/WebRenderLayer.mm:
16047 (+[WebRenderLayer nameForLayer:]): Use %C for the non-ASCII characters.
16049 2010-07-14 Sam Weinig <sam@webkit.org>
16051 Reviewed by Darin Adler.
16053 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
16054 Make changing Cursors work in WebKit2.
16056 * WebCoreSupport/WebChromeClient.h:
16057 * WebCoreSupport/WebChromeClient.mm:
16058 (WebChromeClient::setCursor):
16059 * WebView/WebView.mm:
16060 Implement cursor changing at the WebKit level for the sake of WebKit2.
16061 This functionality is being moved from WidgetMac.mm.
16062 (+[WebView _pointingHandCursor]):
16063 Update to use platformCursor() instead of impl().
16065 2010-07-13 Simon Fraser <simon.fraser@apple.com>
16069 Avoid non-ASCII in souce files to keep Tiger compiler happy.
16071 * WebView/WebRenderLayer.mm:
16072 (+[WebRenderLayer nameForLayer:]):
16074 2010-07-13 Simon Fraser <simon.fraser@apple.com>
16076 Reviewed by Dan Bernstein.
16078 <rdar://problem/8186963> Expose RenderLayer hierarchy via Obj-C for debugging.
16080 Add a WebRenderLayer class that reflects the RenderLayer tree into a hierarchy
16081 of Objective-C objects suitable for display in an outline view.
16083 * WebKit.exp: Export the WebRenderLayer Objective-C class.
16084 * WebView/WebRenderLayer.h: Added.
16085 * WebView/WebRenderLayer.mm: Added.
16087 2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
16089 Reviewed by Darin Adler.
16091 Prevent assertion/duplicate loads for non-deferred subtitute-data loads
16093 https://bugs.webkit.org/show_bug.cgi?id=30879
16095 MainResourceLoader uses the member m_initialRequest to store requests for future
16096 deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
16097 have to clear this request so that subsequent entries into the loader will not
16098 start yet another load.
16100 This can happen as a result of a PageGroupLoadDeferrer going out of scope when
16101 returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
16102 but only in the case of using both substitute-data and non-deferred main resource
16103 load together. That's why two new DRT functions were added:
16105 * queueLoadHTMLString()
16106 * setDeferMainResourceLoad()
16108 The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
16109 and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
16110 added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
16112 * WebView/WebDataSource.mm:
16113 (-[WebDataSource _setDeferMainResourceDataLoad:]):
16114 * WebView/WebDataSourcePrivate.h:
16116 2010-07-13 Philippe Normand <pnormand@igalia.com>
16118 Rubber-stamped by Xan Lopez.
16120 Updated the copyright headers of the files modified in r62476.
16122 * WebView/WebView.mm:
16123 * WebView/WebViewData.h:
16124 * WebView/WebViewInternal.h:
16126 2010-07-09 Alexey Proskuryakov <ap@apple.com>
16128 Reviewed by Darin Adler.
16130 https://bugs.webkit.org/show_bug.cgi?id=13075
16131 XMLHttpRequest with failed authentication should set status to 401
16133 https://bugs.webkit.org/show_bug.cgi?id=6871
16134 <rdar://problem/3363403> 401 error page is never shown
16136 * Panels/WebPanelAuthenticationHandler.m:
16137 (-[WebPanelAuthenticationHandler startAuthentication:window:]): Updated a comment - this
16138 code cancels loading, not authentication (canceling authentication means telling to
16139 continue without credentials).
16140 (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]): If there were
16141 no credentials provided, tell to continue without any. There may be alternative content
16144 2010-07-09 Leon Clarke <leonclarke@google.com>
16146 Reviewed by Adam Barth.
16148 add support for link prefetching
16149 https://bugs.webkit.org/show_bug.cgi?id=3652
16151 * Configurations/FeatureDefines.xcconfig:
16153 2010-07-08 Aaron Boodman <aa@chromium.org>
16155 Reviewed by Timothy Hatcher.
16157 Add the ability for user scripts and user styles to affect just the top frame.
16159 https://bugs.webkit.org/show_bug.cgi?id=41529
16161 * WebView/WebView.mm:
16162 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]):
16163 (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
16164 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]):
16165 (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
16166 * WebView/WebViewPrivate.h:
16168 2010-07-08 Adele Peterson <adele@apple.com>
16170 Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
16172 Fix for https://bugs.webkit.org/show_bug.cgi?id=41721
16173 <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
16175 Implement shouldMissingPluginMessageBeButton.
16177 * WebCoreSupport/WebChromeClient.h:
16178 * WebCoreSupport/WebChromeClient.mm:
16179 (WebChromeClient::shouldMissingPluginMessageBeButton):
16181 2010-07-08 Brady Eidson <beidson@apple.com>
16183 Reviewed by Tim Hatcher.
16185 <rdar://problem/8136327> - Crash in Entourage calling WebCache method from background thread
16187 * Misc/WebCache.mm:
16188 (+[WebCache setDisabled:]): Forward the call to the main thread if called from a background thread.
16190 * Misc/WebNSObjectExtras.h:
16191 * Misc/WebNSObjectExtras.mm:
16192 (+[NSObject _webkit_invokeOnMainThread]): Add a class version of the main thread invoker.
16194 2010-07-08 Mike Thole <mthole@apple.com>
16196 Reviewed by Darin Adler.
16198 Patch for https://bugs.webkit.org/show_bug.cgi?id=41896
16199 Crash under allScriptsInPDFDocument() in WebPDFDocumentExtras.mm for certain PDFs
16201 * WebView/WebPDFDocumentExtras.mm:
16202 (allScriptsInPDFDocument): Null-check 'data', as CGPDFStreamCopyData() may have returned 0.
16204 2010-07-08 Sam Weinig <sam@webkit.org>
16206 Reviewed by Anders Carlsson.
16208 Patch for https://bugs.webkit.org/show_bug.cgi?id=41826
16209 Convert BackForwardList to an abstract base class and add BackForwardListImpl
16210 as the concrete implementation of it.
16212 * History/WebBackForwardList.mm:
16213 (-[WebBackForwardList init]):
16214 (-[WebBackForwardList setPageCacheSize:]):
16215 (-[WebBackForwardList pageCacheSize]):
16217 2010-07-07 Sam Weinig <sam@webkit.org>
16219 Reviewed by Anders Carlsson.
16221 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
16222 Add basic piping for BackForwardControllerClient.
16224 * WebView/WebView.mm:
16225 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
16227 2010-07-07 Anders Carlsson <andersca@apple.com>
16229 Reviewed by Sam Weinig.
16231 Change requestURL to a KURL.
16232 https://bugs.webkit.org/show_bug.cgi?id=41775
16234 * Plugins/WebNetscapePluginStream.h:
16235 (WebNetscapePluginStream::setRequestURL):
16236 * Plugins/WebNetscapePluginStream.mm:
16237 (WebNetscapePluginStream::pluginCancelledConnectionError):
16238 (WebNetscapePluginStream::errorForReason):
16239 (WebNetscapePluginStream::startStream):
16240 (WebNetscapePluginStream::didReceiveResponse):
16241 (WebNetscapePluginStream::destroyStream):
16243 2010-07-07 Anders Carlsson <andersca@apple.com>
16245 Reviewed by Sam Weinig.
16247 Rename the WebBaseNetscapePluginStream.cpp and .h files to WebNetscapePluginStream.cpp and .h to match the class name.
16249 * Plugins/WebNetscapePluginStream.h: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.h.
16250 * Plugins/WebNetscapePluginStream.mm: Renamed from WebKit/mac/Plugins/WebBaseNetscapePluginStream.mm.
16252 2010-07-06 Steve Falkenburg <sfalken@apple.com>
16254 Reviewed by Simon Fraser.
16256 Expose URL matching from WebUserContentURLPattern
16257 https://bugs.webkit.org/show_bug.cgi?id=41726
16258 <rdar://problem/7910144>
16260 We previously had a way to construct WebUserContentURLPattern
16261 instances via WebKit, but no way for callers to perform matching.
16262 This patch adds the matchesURL functionality to allow for this.
16264 * Misc/WebUserContentURLPattern.h: Added matchesURL.
16265 * Misc/WebUserContentURLPattern.mm:
16266 (-[WebUserContentURLPattern matchesURL:]): Added. Calls through to WebCore::UserContentURLPattern::matches.
16268 2010-06-23 Philippe Normand <pnormand@igalia.com>
16270 Reviewed by Eric Carlson.
16272 [GStreamer] on Mac OS use a runloop observer to process the glib context iterations
16273 https://bugs.webkit.org/show_bug.cgi?id=35747
16275 If VIDEO and GSTREAMER are enabled, make the WebView start a
16276 runloop observer that will trigger the glib main context
16277 iterations. Those are needed by the GStreamer player only at the
16278 moment but could later be used for other GLib-dependant components
16281 * WebView/WebView.mm:
16282 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
16283 (-[WebView _close]):
16284 (-[WebView _clearGlibLoopObserver]):
16285 (glibContextIterationCallback):
16286 (-[WebView _scheduleGlibContextIterations]):
16287 * WebView/WebViewData.h:
16288 * WebView/WebViewInternal.h:
16290 2010-07-03 Jon Honeycutt <jhoneycutt@apple.com>
16292 The missing plug-in indicator should be clickable
16294 https://bugs.webkit.org/show_bug.cgi?id=41550
16295 <rdar://problem/8132162>
16297 From an original patch by Kevin Decker.
16299 Reviewed by Darin Adler.
16301 * WebCoreSupport/WebChromeClient.h:
16302 Declare an override of missingPluginButtonClicked().
16304 * WebCoreSupport/WebChromeClient.mm:
16305 (WebChromeClient::missingPluginButtonClicked):
16306 Call the UIDelegate's method.
16308 * WebView/WebUIDelegatePrivate.h:
16309 Declare didPressMissingPluginButton.
16311 2010-07-01 Timothy Hatcher <timothy@apple.com>
16313 Provide a WebView preference to disable DNS prefetching.
16315 https://bugs.webkit.org/show_bug.cgi?id=28825
16316 rdar://problem/7181249
16318 Reviewed by Darin Adler.
16320 * WebView/WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
16321 * WebView/WebPreferences.mm:
16322 (+[WebPreferences initialize]): Set WebKitDNSPrefetchingEnabledPreferenceKey to YES.
16323 (-[WebPreferences isDNSPrefetchingEnabled]): Added. Return WebKitDNSPrefetchingEnabledPreferenceKey's value.
16324 (-[WebPreferences setDNSPrefetchingEnabled:]): Added. Set WebKitDNSPrefetchingEnabledPreferenceKey's value.
16325 * WebView/WebPreferencesPrivate.h: Added isDNSPrefetchingEnabled and setDNSPrefetchingEnabled:.
16326 * WebView/WebView.mm:
16327 (-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setDNSPrefetchingEnabled.
16329 2010-07-01 Alexey Proskuryakov <ap@apple.com>
16331 Reviewed by Anders Carlsson.
16333 <rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
16334 REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction
16336 Strengthen m_inDestroy "swipe under the carpet" fix.
16338 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Added a long comment about m_inDestroy, and
16339 changed it to static.
16341 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
16342 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): m_inDestroy is now
16343 static, so we don't initialize it in constructor.
16344 (WebKit::NetscapePluginInstanceProxy::destroy): Assert that we aren't already destroying
16346 (WebKit::NetscapePluginInstanceProxy::evaluate): This function accidentally lacked an
16347 m_inDestroy check in r42789.
16349 2010-06-29 Zoltan Herczeg <zherczeg@webkit.org>
16351 Reviewed by Nikolas Zimmermann.
16353 Add ConvolveMatrixElement to MigrateHeaders.make
16354 https://bugs.webkit.org/show_bug.cgi?id=5861
16356 * MigrateHeaders.make:
16358 2010-06-23 John Gregg <johnnyg@google.com>
16360 Reviewed by Kent Tamura.
16362 add ENABLE_DIRECTORY_UPLOAD build support
16363 https://bugs.webkit.org/show_bug.cgi?id=41100
16365 * Configurations/FeatureDefines.xcconfig:
16367 2010-06-28 Eric Seidel <eric@webkit.org>
16369 Reviewed by Adam Barth.
16371 Make it possible to test the new HTML5 TreeBuilder
16372 https://bugs.webkit.org/show_bug.cgi?id=41276
16374 Adam was concerned that someone might make their port
16375 depend on this setting (I guess we had some trouble with that
16376 with the HTML5Parser setting), so I littered the code with warnings.
16378 test-html5-parser now tests this code path.
16380 * WebView/WebPreferenceKeysPrivate.h:
16381 * WebView/WebPreferences.mm:
16382 (+[WebPreferences initialize]):
16383 (-[WebPreferences html5TreeBuilderEnabled]):
16384 (-[WebPreferences setHTML5TreeBuilderEnabled:]):
16385 * WebView/WebPreferencesPrivate.h:
16386 * WebView/WebView.mm:
16387 (-[WebView _preferencesChangedNotification:]):
16389 2010-06-25 Yuzo Fujishima <yuzo@google.com>
16391 Reviewed by Shinichiro Hamaji.
16393 Improve default value handling for page format properties.
16394 https://bugs.webkit.org/show_bug.cgi?id=41150
16396 * Misc/WebCoreStatistics.h:
16397 * Misc/WebCoreStatistics.mm:
16398 (-[WebFrame pageSizeAndMarginsInPixels:pageNumber:width:height:marginTop:marginRight:marginBottom:]):
16400 2010-06-26 Tony Gentilcore <tonyg@chromium.org>
16402 Reviewed by Dimitri Glazkov.
16404 Add an ENABLE_WEB_TIMING option for enabling Web Timing support.
16405 https://bugs.webkit.org/show_bug.cgi?id=38924
16407 * Configurations/FeatureDefines.xcconfig:
16409 2010-06-24 Jer Noble <jer.noble@apple.com>
16411 Reviewed by Eric Carlson.
16413 Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
16414 https://bugs.webkit.org/show_bug.cgi?id=40939
16415 rdar://problem/7996172
16417 Take a IOKit power assertion when playing video in fullscreen mode. Release the
16418 assertion when paused in fullscreen mode, and when exiting fullscreen mode.
16420 * WebView/WebVideoFullscreenController.h:
16421 * WebView/WebVideoFullscreenController.mm:
16422 (-[WebVideoFullscreenController windowDidExitFullscreen]): Call updatePowerAssertions.
16423 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Call updatePowerAssertions.
16424 (-[WebVideoFullscreenController _disableIdleDisplaySleep]):
16425 (-[WebVideoFullscreenController _enableIdleDisplaySleep]):
16426 (-[WebVideoFullscreenController _disableIdleSystemSleep]):
16427 (-[WebVideoFullscreenController _enableIdleSystemSleep]):
16428 (-[WebVideoFullscreenController updatePowerAssertions]): Call _(enable|disable)Idle(System|Display)sleep depending on current playback rate and fullscreen status.
16429 (-[WebVideoFullscreenController rateChanged:]): Call updatePowerAssertions.
16431 2010-06-24 Jer Noble <jer.noble@apple.com>
16433 Reviewed by Darin Adler.
16435 Playing movie full screen on second monitor hides menu bar and title bar on main monitor
16436 https://bugs.webkit.org/show_bug.cgi?id=40933
16437 rdar://problem/7858452
16439 Remove all references to GetSystemUIMode and SetSystemUIMode. Replace these calls with
16440 [NSApplication setPresentationOptions:]. Do not auto-hide the menu bar if the fullscreen
16441 screen is does not contain the menu-bar. Do not auto-hide the dock if the fullscreen screen
16442 is both not the menu-bar screen and not the dock screen.
16444 * WebView/WebVideoFullscreenController.mm:
16445 (-[WebVideoFullscreenController windowDidLoad]): Register the applicationDidChangeScreenParameters: listener.
16446 (-[WebVideoFullscreenController windowDidExitFullscreen]): Calls updateMenuAndDockForFullscreen.
16447 (-[WebVideoFullscreenController windowDidEnterFullscreen]): Calls updateMenuAndDockForFullscreen.
16448 (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]): New notification handler; catches NSApplicationDidChangeScreenParameters.
16449 (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]): Hide/show the menu-bar and dock according to the fullscreen window's screen.
16451 2010-06-24 Jer Noble <jer.noble@apple.com>
16453 Reviewed by Eric Carlson.
16455 Full screen video in Safari exits full-screen if you switch to another app
16456 https://bugs.webkit.org/show_bug.cgi?id=40635
16457 rdar://problem/7885101
16459 Implement the following rules for exiting full screen when switching apps:
16460 1. If the system has a single screen, switching apps will cause Safari to exit full-screen.
16461 2. Otherwise, if the full-screen screen is the "main screen" (the one with the title bar),
16462 switching apps will cause Safari to exit full-screen.
16463 3. Overriding rules 1 & 2, if the full-screen screen is not on the "current space",
16464 switching apps will NOT cause Safari to exit full-screen.
16466 * WebView/WebVideoFullscreenController.mm:
16467 (-[WebVideoFullscreenController windowDidLoad]):
16468 (-[WebVideoFullscreenController applicationDidResignActive:]):
16470 2010-06-24 Adele Peterson <adele@apple.com>
16472 Reviewed by Sam Weinig.
16474 Updated fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
16475 https://bugs.webkit.org/show_bug.cgi?id=41085
16477 * WebView/WebHTMLView.mm: Use the WebCore command system for the pasteAsPlainText selector.
16478 Also remove internal methods that no one is using.
16480 2010-06-24 Damian Kaleta <dkaleta@apple.com>
16482 Reviewed by Sam Weinig.
16484 Added an ObjC wrapper to Node::renderRect(bool&).
16486 * DOM/WebDOMOperations.mm:
16487 (-[DOMNode _renderRect:]):
16488 * DOM/WebDOMOperationsPrivate.h:
16490 2010-06-24 Adele Peterson <adele@apple.com>
16492 Reviewed by Eric Carlson.
16494 Fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
16495 https://bugs.webkit.org/show_bug.cgi?id=41085
16497 * WebView/WebHTMLView.mm: (-[WebHTMLView pasteAsPlainText:]): Reuse code in WebCore
16498 which does everything done here and also fires paste events.
16500 2010-06-23 Yuzo Fujishima <yuzo@google.com>
16502 Reviewed by Shinichiro Hamaji.
16504 Implement page format data programming interface.
16505 Add methods for testing.
16506 https://bugs.webkit.org/show_bug.cgi?id=37538
16508 * Misc/WebCoreStatistics.h:
16509 * Misc/WebCoreStatistics.mm:
16510 (-[WebFrame isPageBoxVisible:]):
16511 (-[WebFrame pageAreaRectInPixels:]):
16512 (-[WebFrame preferredPageSizeInPixels:]):
16514 2010-06-22 Anders Carlsson <andersca@apple.com>
16516 Reviewed by Sam Weinig.
16518 Get rid of more USE_LIBDISPATCH code.
16520 * Plugins/Hosted/NetscapePluginHostProxy.h:
16522 2010-06-22 Anders Carlsson <andersca@apple.com>
16524 Reviewed by Sam Weinig.
16526 Get rid of the USE_LIBDISPATCH code.
16528 * Plugins/Hosted/NetscapePluginHostProxy.mm:
16529 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
16530 (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
16532 2010-06-22 Anders Carlsson <andersca@apple.com>
16534 Reviewed by Sam Weinig.
16536 Wean NetscapePluginHostManager of any knowledge about WebNetscapePluginPackage
16537 https://bugs.webkit.org/show_bug.cgi?id=41006
16539 * Plugins/Hosted/NetscapePluginHostManager.h:
16540 * Plugins/Hosted/NetscapePluginHostManager.mm:
16541 (WebKit::NetscapePluginHostManager::hostForPlugin):
16542 (WebKit::NetscapePluginHostManager::spawnPluginHost):
16543 (WebKit::NetscapePluginHostManager::instantiatePlugin):
16544 (WebKit::NetscapePluginHostManager::createPropertyListFile):
16545 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
16546 (-[WebHostedNetscapePluginView createPlugin]):
16547 * Plugins/WebNetscapePluginPackage.mm:
16548 (-[WebNetscapePluginPackage createPropertyListFile]):
16550 2010-06-21 Anders Carlsson <andersca@apple.com>
16552 Reviewed by Sam Weinig.
16554 Fix an off-by-one bug I introduced.
16556 * Plugins/WebNetscapePluginPackage.mm:
16557 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
16559 2010-06-21 Nate Chapin <japhet@chromium.org>
16561 Reviewed by Adam Barth.
16563 FrameLoader cleanup: Split high level subframe and plugin
16564 loading functions into a separate class.
16565 https://bugs.webkit.org/show_bug.cgi?id=40453
16567 * WebView/WebFrame.mm:
16568 (-[WebFrame _cacheabilityDictionary]):
16570 2010-06-21 Anders Carlsson <andersca@apple.com>
16572 Another Tiger build fix.
16574 * Plugins/WebNetscapePluginPackage.mm:
16575 (-[WebNetscapePluginPackage _tryLoad]):
16577 2010-06-21 Anders Carlsson <andersca@apple.com>
16579 Reviewed by Sam Weinig.
16581 More WebBasePluginPackage cleanup
16582 https://bugs.webkit.org/show_bug.cgi?id=40944
16584 * Plugins/Hosted/HostedNetscapePluginStream.mm:
16585 (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError):
16586 * Plugins/Hosted/NetscapePluginHostManager.mm:
16587 (WebKit::NetscapePluginHostManager::spawnPluginHost):
16588 * Plugins/WebBaseNetscapePluginStream.mm:
16589 (WebNetscapePluginStream::pluginCancelledConnectionError):
16590 * Plugins/WebBaseNetscapePluginView.mm:
16591 (WebHaltablePlugin::pluginName):
16592 * Plugins/WebBasePluginPackage.h:
16593 * Plugins/WebBasePluginPackage.mm:
16594 (-[WebBasePluginPackage initWithPath:]):
16595 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]):
16596 (-[WebBasePluginPackage getPluginInfoFromPLists]):
16597 (-[WebBasePluginPackage load]):
16598 (-[WebBasePluginPackage dealloc]):
16599 (-[WebBasePluginPackage finalize]):
16600 (-[WebBasePluginPackage pluginInfo]):
16601 (-[WebBasePluginPackage supportsExtension:]):
16602 (-[WebBasePluginPackage supportsMIMEType:WebCore::]):
16603 (-[WebBasePluginPackage MIMETypeForExtension:]):
16604 (-[WebBasePluginPackage isJavaPlugIn]):
16605 (-[WebBasePluginPackage versionNumber]):
16606 (-[WebBasePluginPackage WebCore::]):
16607 * Plugins/WebNetscapePluginPackage.mm:
16608 (-[WebNetscapePluginPackage openResourceFile]):
16609 (-[WebNetscapePluginPackage closeResourceFile:]):
16610 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
16611 (-[WebNetscapePluginPackage _initWithPath:]):
16612 (-[WebNetscapePluginPackage _applyDjVuWorkaround]):
16613 (-[WebNetscapePluginPackage _tryLoad]):
16614 (-[WebNetscapePluginPackage supportsSnapshotting]):
16615 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
16616 * Plugins/WebPluginDatabase.mm:
16617 (-[WebPluginDatabase refresh]):
16618 (-[WebPluginDatabase _removePlugin:]):
16619 * Plugins/WebPluginPackage.mm:
16620 (-[WebPluginPackage initWithPath:]):
16621 (-[WebPluginPackage load]):
16622 * WebCoreSupport/WebFrameLoaderClient.mm:
16623 (WebFrameLoaderClient::createPlugin):
16624 * WebCoreSupport/WebPlatformStrategies.mm:
16625 (WebPlatformStrategies::getPluginInfo):
16627 2010-06-21 Anders Carlsson <andersca@apple.com>
16629 Another PowerPC build fix.
16631 * Plugins/WebNetscapePluginPackage.mm:
16632 (-[WebNetscapePluginPackage openResourceFile]):
16633 (-[WebNetscapePluginPackage _tryLoad]):
16635 2010-06-21 Anders Carlsson <andersca@apple.com>
16637 Try to fix the PowerPC build.
16639 * Plugins/WebNetscapePluginPackage.mm:
16640 (-[WebNetscapePluginPackage _tryLoad]):
16642 2010-06-21 Nate Chapin <japhet@chromium.org>
16644 Reviewed by Adam Barth.
16646 Update relevant calls into FrameLoader to make use of
16647 FrameLoaderStateMachine.
16648 https://bugs.webkit.org/show_bug.cgi?id=39695
16650 * WebCoreSupport/WebFrameLoaderClient.mm:
16651 (WebFrameLoaderClient::transitionToCommittedForNewPage):
16652 * WebView/WebFrame.mm:
16653 (-[WebFrame _firstLayoutDone]):
16655 2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>
16657 Reviewed by Dan Bernstein.
16659 Chromium/Mac build fix.
16661 * WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other
16664 2010-06-21 Anders Carlsson <andersca@apple.com>
16666 Reviewed by Dan Bernstein.
16668 Make all of WebKit build with clang++
16670 * DefaultDelegates/WebDefaultPolicyDelegate.m:
16671 (-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
16672 * Plugins/Hosted/NetscapePluginHostManager.mm:
16673 * Plugins/WebBaseNetscapePluginView.mm:
16674 (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
16675 * WebView/WebDynamicScrollBarsView.mm:
16676 (-[WebDynamicScrollBarsView setSuppressLayout:]):
16677 * WebView/WebHTMLRepresentation.mm:
16678 * WebView/WebNavigationData.mm:
16679 (-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
16680 * WebView/WebPDFRepresentation.mm:
16681 (-[WebPDFRepresentation setDataSource:]):
16682 (-[WebPDFRepresentation receivedData:withDataSource:]):
16683 (-[WebPDFRepresentation receivedError:withDataSource:]):
16684 * WebView/WebResource.mm:
16685 (-[WebResource description]):
16686 * WebView/WebSerializedJSValue.mm:
16687 (-[WebSerializedJSValue initWithValue:context:exception:]):
16688 * WebView/WebVideoFullscreenController.mm:
16689 (-[WebVideoFullscreenController WebCore::]):
16690 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
16691 (-[WebVideoFullscreenController setDelegate:]):
16692 (-[WebVideoFullscreenController enterFullscreen:]):
16693 * WebView/WebView.mm:
16694 (-[WebView _openFrameInNewWindowFromMenu:]):
16695 (-[WebView _geolocationDidChangePosition:]):
16697 2010-06-21 Anders Carlsson <andersca@apple.com>
16699 Reviewed by Sam Weinig.
16701 Remove unused dictionary ivars from WebBasePluginPackage
16702 https://bugs.webkit.org/show_bug.cgi?id=40928
16704 * Plugins/WebBasePluginPackage.h:
16705 * Plugins/WebBasePluginPackage.mm:
16706 (-[WebBasePluginPackage getPluginInfoFromPLists]):
16707 (-[WebBasePluginPackage dealloc]):
16708 * Plugins/WebNetscapePluginPackage.mm:
16709 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
16711 2010-06-21 Dan Bernstein <mitz@apple.com>
16715 * WebCoreSupport/WebSystemInterface.mm:
16716 (InitWebCoreSystemInterface):
16718 2010-06-21 Dan Bernstein <mitz@apple.com>
16720 Reviewed by Darin Adler.
16722 WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties
16723 https://bugs.webkit.org/show_bug.cgi?id=10228
16725 * WebCoreSupport/WebSystemInterface.mm:
16726 (InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex.
16728 2010-06-21 Satish Sampath <satish@chromium.org>
16730 Reviewed by Steve Block.
16732 Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
16733 https://bugs.webkit.org/show_bug.cgi?id=40878
16735 * Configurations/FeatureDefines.xcconfig:
16737 2010-06-20 Anders Carlsson <andersca@apple.com>
16741 * Plugins/WebNetscapePluginPackage.mm:
16743 2010-06-20 Anders Carlsson <andersca@apple.com>
16745 Reviewed by Dan Bernstein.
16747 Get rid of the old MIMETypes getter method
16748 https://bugs.webkit.org/show_bug.cgi?id=40898
16750 * Plugins/WebBasePluginPackage.h:
16751 * Plugins/WebBasePluginPackage.mm:
16752 (-[WebBasePluginPackage supportsExtension:]):
16753 (-[WebBasePluginPackage supportsMIMEType:WebCore::]):
16754 (-[WebBasePluginPackage MIMETypeForExtension:]):
16755 * Plugins/WebPluginDatabase.mm:
16756 (-[WebPluginDatabase refresh]):
16757 (-[WebPluginDatabase _removePlugin:]):
16759 2010-06-20 Anders Carlsson <andersca@apple.com>
16761 Reviewed by Dan Bernstein.
16763 Remove bogus const qualifiers.
16765 * WebCoreSupport/WebPasteboardHelper.h:
16766 * WebCoreSupport/WebPasteboardHelper.mm:
16767 (WebPasteboardHelper::urlFromPasteboard):
16768 (WebPasteboardHelper::plainTextFromPasteboard):
16769 (WebPasteboardHelper::fragmentFromPasteboard):
16771 2010-06-20 Anders Carlsson <andersca@apple.com>
16773 Reviewed by Dan Bernstein.
16775 Get rid of the extensionToMIME mapping in WebBasePluginPackage
16776 https://bugs.webkit.org/show_bug.cgi?id=40897
16778 Instead of using the extensionToMIME mutable dictionary, use the MIME types vector.
16779 While this makes lookup of MIME types based on extensions linear instead of constant,
16780 the number of extensions per plug-in is too small for it to matter.
16782 * Plugins/WebBasePluginPackage.h:
16783 * Plugins/WebBasePluginPackage.mm:
16784 (-[WebBasePluginPackage initWithPath:]):
16785 (-[WebBasePluginPackage dealloc]):
16786 (-[WebBasePluginPackage supportsExtension:]):
16787 (-[WebBasePluginPackage MIMETypeForExtension:]):
16788 (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
16790 2010-06-20 Anders Carlsson <andersca@apple.com>
16792 Reviewed by Dan Bernstein.
16794 Add a MimeClassInfo Vector to WebBasePluginPackage
16795 https://bugs.webkit.org/show_bug.cgi?id=40896
16797 * Plugins/WebBasePluginPackage.h:
16798 * Plugins/WebBasePluginPackage.mm:
16799 (-[WebBasePluginPackage getPluginInfoFromPLists]):
16800 (-[WebBasePluginPackage WebCore::]):
16801 * Plugins/WebNetscapePluginPackage.mm:
16802 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
16803 * WebCoreSupport/WebPlatformStrategies.mm:
16804 (WebPlatformStrategies::getPluginInfo):
16806 2010-06-20 Anders Carlsson <andersca@apple.com>
16808 Reviewed by Dan Bernstein.
16810 Move the NSBundle ivar to WebPluginPackage
16811 https://bugs.webkit.org/show_bug.cgi?id=40894
16813 * Plugins/WebBasePluginPackage.h:
16814 * Plugins/WebBasePluginPackage.mm:
16815 (-[WebBasePluginPackage initWithPath:]):
16816 (-[WebBasePluginPackage _objectForInfoDictionaryKey:]):
16817 (-[WebBasePluginPackage getPluginInfoFromPLists]):
16818 (-[WebBasePluginPackage load]):
16819 (-[WebBasePluginPackage dealloc]):
16820 * Plugins/WebNetscapePluginPackage.mm:
16821 (-[WebNetscapePluginPackage _initWithPath:]):
16822 * Plugins/WebPluginPackage.h:
16823 * Plugins/WebPluginPackage.mm:
16824 (-[WebPluginPackage initWithPath:]):
16825 (-[WebPluginPackage dealloc]):
16826 (-[WebPluginPackage viewFactory]):
16827 (-[WebPluginPackage load]):
16829 2010-06-20 Anders Carlsson <andersca@apple.com>
16831 Reviewed by Sam Weinig.
16833 Remove -[WebBasePluginPackage bundle]
16834 https://bugs.webkit.org/show_bug.cgi?id=40892
16836 Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it.
16838 Move the supportsSnapshotting method over to the plug-in package.
16840 * Plugins/Hosted/NetscapePluginHostManager.mm:
16841 (WebKit::NetscapePluginHostManager::hostForPackage):
16842 * Plugins/WebBaseNetscapePluginView.mm:
16843 (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
16844 (-[WebBaseNetscapePluginView supportsSnapshotting]):
16845 * Plugins/WebBasePluginPackage.h:
16846 * Plugins/WebBasePluginPackage.mm:
16847 (-[WebBasePluginPackage isQuickTimePlugIn]):
16848 (-[WebBasePluginPackage isJavaPlugIn]):
16849 (-[WebBasePluginPackage WebCore::]):
16850 Call bundleIdentifier directly instead of asking the bundle
16851 * Plugins/WebNetscapePluginPackage.h:
16852 * Plugins/WebNetscapePluginPackage.mm:
16853 (-[WebNetscapePluginPackage supportsSnapshotting]):
16854 * Plugins/WebNetscapePluginView.mm:
16855 (-[WebNetscapePluginView setAttributeKeys:andValues:]):
16856 (-[WebNetscapePluginView _createPlugin]):
16857 * Plugins/WebPluginDatabase.mm:
16860 2010-06-20 Anders Carlsson <andersca@apple.com>
16862 Reviewed by Dan Bernstein.
16864 Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
16865 https://bugs.webkit.org/show_bug.cgi?id=40869
16867 Re-land r61459, with extra null-checks in WebFrameLoaderClient.
16869 * Plugins/Hosted/NetscapePluginHostManager.mm:
16870 (WebKit::NetscapePluginHostManager::spawnPluginHost):
16871 * Plugins/WebBasePluginPackage.h:
16872 * Plugins/WebBasePluginPackage.mm:
16873 (-[WebBasePluginPackage initWithPath:]):
16874 (-[WebBasePluginPackage getPluginInfoFromPLists]):
16875 (-[WebBasePluginPackage dealloc]):
16876 (-[WebBasePluginPackage name]):
16877 (-[WebBasePluginPackage path]):
16878 (-[WebBasePluginPackage filename]):
16879 (-[WebBasePluginPackage pluginDescription]):
16880 (-[WebBasePluginPackage description]):
16881 (-[WebBasePluginPackage isJavaPlugIn]):
16882 * Plugins/WebNetscapePluginPackage.mm:
16883 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
16884 (-[WebNetscapePluginPackage _tryLoad]):
16885 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
16886 * Plugins/WebPluginPackage.mm:
16887 (-[WebPluginPackage load]):
16888 * WebCoreSupport/WebFrameLoaderClient.mm:
16889 (WebFrameLoaderClient::createPlugin):
16891 2010-06-18 Adam Barth <abarth@webkit.org>
16893 Unreviewed, rolling out r61459.
16894 http://trac.webkit.org/changeset/61459
16895 https://bugs.webkit.org/show_bug.cgi?id=40869
16897 Seems to have broken two tests on the Tiger buildbot:
16899 dom/html/level2/html/AppletsCollection.html
16900 plugins/qt-qwidget-plugin.html
16902 Anders wasn't on #webkit...
16904 * Plugins/Hosted/NetscapePluginHostManager.mm:
16905 (WebKit::NetscapePluginHostManager::spawnPluginHost):
16906 * Plugins/WebBasePluginPackage.h:
16907 * Plugins/WebBasePluginPackage.mm:
16908 (-[WebBasePluginPackage initWithPath:]):
16909 (-[WebBasePluginPackage getPluginInfoFromPLists]):
16910 (-[WebBasePluginPackage dealloc]):
16911 (-[WebBasePluginPackage name]):
16912 (-[WebBasePluginPackage path]):
16913 (-[WebBasePluginPackage filename]):
16914 (-[WebBasePluginPackage pluginDescription]):
16915 (-[WebBasePluginPackage setName:]):
16916 (-[WebBasePluginPackage setPath:]):
16917 (-[WebBasePluginPackage setPluginDescription:]):
16918 (-[WebBasePluginPackage description]):
16919 (-[WebBasePluginPackage isJavaPlugIn]):
16920 * Plugins/WebNetscapePluginPackage.mm:
16921 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
16922 (-[WebNetscapePluginPackage _tryLoad]):
16923 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
16924 * Plugins/WebPluginPackage.mm:
16925 (-[WebPluginPackage load]):
16927 2010-06-18 Anders Carlsson <andersca@apple.com>
16931 * Plugins/WebBasePluginPackage.mm:
16932 (-[WebBasePluginPackage isJavaPlugIn]):
16934 2010-06-18 Anders Carlsson <andersca@apple.com>
16936 Reviewed by Sam Weinig.
16938 Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
16939 https://bugs.webkit.org/show_bug.cgi?id=40869
16941 * Plugins/Hosted/NetscapePluginHostManager.mm:
16942 (WebKit::NetscapePluginHostManager::spawnPluginHost):
16943 * Plugins/WebBasePluginPackage.h:
16944 * Plugins/WebBasePluginPackage.mm:
16945 (-[WebBasePluginPackage initWithPath:]):
16946 (-[WebBasePluginPackage getPluginInfoFromPLists]):
16947 (-[WebBasePluginPackage dealloc]):
16948 (-[WebBasePluginPackage name]):
16949 (-[WebBasePluginPackage path]):
16950 (-[WebBasePluginPackage filename]):
16951 (-[WebBasePluginPackage pluginDescription]):
16952 (-[WebBasePluginPackage description]):
16953 (-[WebBasePluginPackage isJavaPlugIn]):
16954 * Plugins/WebNetscapePluginPackage.mm:
16955 (-[WebNetscapePluginPackage getPluginInfoFromResources]):
16956 (-[WebNetscapePluginPackage _tryLoad]):
16957 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
16958 * Plugins/WebPluginPackage.mm:
16959 (-[WebPluginPackage load]):
16961 2010-06-18 Anders Carlsson <andersca@apple.com>
16963 Reviewed by Sam Weinig.
16965 Rename WebPluginPackage.m to make it an Objective-C++ file.
16967 * Plugins/WebPluginPackage.m: Removed.
16968 * Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m.
16970 2010-06-18 Anders Carlsson <andersca@apple.com>
16972 Reviewed by Sam Weinig.
16974 Get rid of the NSEnumerators from WebBasePluginPackage
16975 https://bugs.webkit.org/show_bug.cgi?id=40868
16977 * Plugins/WebBasePluginPackage.h:
16978 * Plugins/WebBasePluginPackage.mm:
16979 (-[WebBasePluginPackage MIMETypes]):
16980 (-[WebBasePluginPackage supportsExtension:]):
16981 (-[WebBasePluginPackage supportsMIMEType:]):
16982 * Plugins/WebPluginDatabase.mm:
16983 (-[WebPluginDatabase pluginForMIMEType:]):
16984 (-[WebPluginDatabase pluginForExtension:]):
16985 (-[WebPluginDatabase refresh]):
16986 (-[WebPluginDatabase _removePlugin:]):
16987 * WebCoreSupport/WebPlatformStrategies.mm:
16988 (WebPlatformStrategies::getPluginInfo):
16990 2010-06-18 Anders Carlsson <andersca@apple.com>
16992 Reviewed by Sam Weinig.
16994 Make WebCoreSystemInterface.h a C++ only header
16995 https://bugs.webkit.org/show_bug.cgi?id=40867
16997 * WebCoreSupport/WebSystemInterface.h:
16998 * WebCoreSupport/WebSystemInterface.m: Removed.
16999 * WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m.
17001 2010-06-18 Anders Carlsson <andersca@apple.com>
17003 Reviewed by Sam Weinig.
17005 Clean up WebPluginDatabase.mm
17006 https://bugs.webkit.org/show_bug.cgi?id=40866
17008 * Plugins/WebBasePluginPackage.h:
17009 * Plugins/WebBasePluginPackage.mm:
17010 (pathByResolvingSymlinksAndAliases):
17011 (-[WebBasePluginPackage initWithPath:]):
17012 Change an instance method into a static function.
17014 * Plugins/WebPluginDatabase.mm:
17015 (PluginPackageCandidates::PluginPackageCandidates):
17016 (PluginPackageCandidates::update):
17017 (PluginPackageCandidates::bestCandidate):
17018 Add a new PluginPackageCandidates class.
17020 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
17021 Use PluginPackageCandidates here.
17023 2010-06-18 Anders Carlsson <andersca@apple.com>
17027 * WebCoreSupport/WebPlatformStrategies.mm:
17029 2010-06-18 Anders Carlsson <andersca@apple.com>
17031 Reviewed by Darin Adler.
17033 Get rid of PluginDataMac.mm and use the plug-in strategy instead
17034 https://bugs.webkit.org/show_bug.cgi?id=40860
17036 * Plugins/WebBasePluginPackage.h:
17037 * WebCoreSupport/WebPlatformStrategies.h:
17038 * WebCoreSupport/WebPlatformStrategies.mm:
17039 (WebPlatformStrategies::createPluginStrategy):
17040 (WebPlatformStrategies::refreshPlugins):
17041 (WebPlatformStrategies::getPluginInfo):
17042 * WebCoreSupport/WebViewFactory.mm:
17044 2010-06-18 Anders Carlsson <andersca@apple.com>
17046 Reviewed by Dan Bernstein.
17048 Add stubbed out WebPlatformStrategies class to WebKit.
17049 https://bugs.webkit.org/show_bug.cgi?id=40851
17051 * WebCoreSupport/WebPlatformStrategies.h: Added.
17052 * WebCoreSupport/WebPlatformStrategies.mm: Added.
17053 (WebPlatformStrategies::initialize):
17054 (WebPlatformStrategies::WebPlatformStrategies):
17055 (WebPlatformStrategies::createPluginStrategy):
17056 * WebView/WebView.mm:
17057 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
17059 2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
17061 Reviewed by Adam Barth.
17063 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
17064 https://bugs.webkit.org/show_bug.cgi?id=39041
17066 * WebView/WebView.mm:
17067 (-[WebView _preferencesChangedNotification:]):
17069 2010-06-17 Darin Adler <darin@apple.com>
17071 Reviewed by Sam Weinig.
17073 Use adoptRef and create functions in more code paths
17074 https://bugs.webkit.org/show_bug.cgi?id=40760
17076 * Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer
17077 be an inline function.
17079 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
17080 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
17081 Moved the call to addPluginInstance out of here.
17082 (WebKit::NetscapePluginInstanceProxy::create): Move it in here.
17083 This makes sure we call adoptRef on the new proxy before any caller
17086 2010-06-16 Eric Seidel <eric@webkit.org>
17088 Reviewed by Adam Barth.
17090 Enable HTML5 Parser in Safari on Mac
17091 https://bugs.webkit.org/show_bug.cgi?id=40739
17093 The HTML5 parser is probably off on all webkit ports.
17094 We should either flip the meaning of the default so that
17095 "false" means HTML5 on all ports, or we'll have to write
17096 more code like this for all the other ports.
17098 * WebView/WebPreferences.mm:
17099 (+[WebPreferences initialize]):
17101 2010-06-15 Mark Rowe <mrowe@apple.com>
17103 Reviewed by Sam Weinig.
17105 Don't leak WebGeolocationPositionInternal and GeolocationPosition instances for every WebGeolocationPosition created.
17107 * WebView/WebGeolocationPosition.mm:
17108 (-[WebGeolocationPosition dealloc]): Implement -dealloc and release our WebGeolocationPositionInternal instance.
17110 2010-06-10 Yuzo Fujishima <yuzo@google.com>
17112 Reviewed by Shinichiro Hamaji.
17114 Implement render style selection for pages to support CSS3 Paged Media.
17115 https://bugs.webkit.org/show_bug.cgi?id=35961
17117 * Misc/WebCoreStatistics.h:
17118 * Misc/WebCoreStatistics.mm:
17119 (-[WebFrame pageProperty:propertyName:]):
17121 2010-06-15 Darin Adler <darin@apple.com>
17123 Reviewed by Adam Barth.
17125 Move functions out of Frame class that were marked "move to Chrome"
17126 https://bugs.webkit.org/show_bug.cgi?id=39636
17128 * WebView/WebView.mm:
17129 (-[WebView shouldClose]): Call shouldClose on FrameLoader instead of
17130 going through Frame.
17132 2010-06-15 Anders Carlsson <andersca@apple.com>
17134 Reviewed by Dan Bernstein.
17136 Remove getPluginInfoFromBundleAndMIMEDictionary:
17138 * Plugins/WebBasePluginPackage.mm:
17140 2010-06-15 Anders Carlsson <andersca@apple.com>
17142 Reviewed by Dan Bernstein.
17144 Fold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller.
17146 * Plugins/WebBasePluginPackage.mm:
17147 (-[WebBasePluginPackage getPluginInfoFromPLists]):
17149 2010-06-11 Simon Fraser <simon.fraser@apple.com>
17151 Reviewed by Darin Adler.
17153 <rdar://problem/8084721> Pages using accelerated compositing fail to update correctly in Carbon apps
17155 The run loop observer used to commit compositing layer changes does not do
17156 updates if [window viewsNeedDisplay] is true, because this indicates that a delayed window
17157 update is pending (added in r58623).
17159 However, Carbon apps don't use the NSWindow updating mechanism, so [window viewsNeedDisplay] always returns YES.
17160 This caused us to never sync compositing layers.
17162 So detect if the current window is wrapping a carbon window, and in that case consult the root
17163 HIView to detect if display is pending.
17165 * WebView/WebView.mm:
17166 (layerSyncRunLoopObserverCallBack):
17168 2010-06-15 Dan Bernstein <mitz@apple.com>
17170 Reviewed by John Sullivan.
17172 <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email
17174 Test: platform/mac/editing/input/NSBackgroundColor-transparent.html
17176 r50796 changed the initial background color from invalid to transparent. As a result,
17177 NSAttributedStrings returned from +_web_attributedStringFromRange started including the
17178 NSBackgroundColor attribute, with a transparent color as the value. This caused problems for
17179 components in the system that ignore the alpha component, turning the color into opaque black.
17181 * Misc/WebNSAttributedStringExtras.mm:
17182 (+[NSAttributedString _web_attributedStringFromRange:]): Change to not include the background
17183 and foreground color attributes if the color are transparent.
17185 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
17187 Reviewed by Pavel Feldman.
17189 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
17190 data from inspected page to WebInspector as JSON string via http. The native
17191 serialization to JSON string is supported by InspectorValue's classes. This patch
17192 has the implementation of sendMessageToFrontend function. WebKit version of it still
17193 uses ScriptFunctionCall and will be switched to another transport a little bit later.
17194 https://bugs.webkit.org/show_bug.cgi?id=40134
17196 * WebCoreSupport/WebInspectorClient.h:
17197 * WebCoreSupport/WebInspectorClient.mm:
17198 (WebInspectorClient::WebInspectorClient):
17199 (WebInspectorClient::openInspectorFrontend):
17201 2010-06-10 David Hyatt <hyatt@apple.com>
17203 Reviewed by John Sullivan.
17205 https://bugs.webkit.org/show_bug.cgi?id=40441, back out the original fix for 29601, since it has broken continuous
17206 wheel delta values.
17208 * WebView/WebDynamicScrollBarsView.mm:
17209 (-[WebDynamicScrollBarsView scrollWheel:]):
17211 2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
17213 Unreviewed, rolling out r60889.
17214 http://trac.webkit.org/changeset/60889
17215 https://bugs.webkit.org/show_bug.cgi?id=40365
17217 gtk bot has some kind of memory corruption (Requested by
17218 loislo on #webkit).
17220 * WebCoreSupport/WebInspectorClient.h:
17221 * WebCoreSupport/WebInspectorClient.mm:
17222 (WebInspectorClient::WebInspectorClient):
17223 (WebInspectorClient::openInspectorFrontend):
17224 (-[WebInspectorWindowController destroyInspectorView]):
17226 2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
17228 Reviewed by Pavel Feldman.
17230 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
17231 data from inspected page to WebInspector as JSON string via http. The native
17232 serialization to JSON string is supported by InspectorValue's classes. This patch
17233 has the implementation of sendMessageToFrontend function. WebKit version of it still
17234 uses ScriptFunctionCall and will be switched to another transport a little bit later.
17235 https://bugs.webkit.org/show_bug.cgi?id=40134
17237 * WebCoreSupport/WebInspectorClient.h:
17238 * WebCoreSupport/WebInspectorClient.mm:
17239 (WebInspectorClient::WebInspectorClient):
17240 (WebInspectorClient::openInspectorFrontend):
17242 2010-06-08 Mark Rowe <mrowe@apple.com>
17244 Reviewed by Adele Peterson.
17246 <rdar://problem/8072136> REGRESSION (r56051): Inspect Element context menu does nothing in applications linked against 10.4 SDK
17248 * WebCoreSupport/WebContextMenuClient.mm:
17249 (fixMenusReceivedFromOldClients): Fix up the tag on the Inspect Element menu item. This ensures that even if the
17250 context menu layout doesn't match our expectations that the menu item will continue to trigger the web inspector.
17252 2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
17254 Reviewed by Ojan Vafai and Darin Adler.
17256 Refactor platform dependent editing behavior code out of Settings
17257 https://bugs.webkit.org/show_bug.cgi?id=39854
17259 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
17260 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
17262 * WebView/WebFrame.mm:
17264 * WebView/WebFrameInternal.h:
17265 * WebView/WebView.mm:
17266 (-[WebView _preferencesChangedNotification:]):
17268 2010-06-06 MORITA Hajime <morrita@google.com>
17270 Unreviewd, follow up to r60820
17272 https://bugs.webkit.org/show_bug.cgi?id=40219
17273 [Mac] ENABLE_METER_TAG should be enabled
17275 Added ENABLE_METER_TAG.
17277 * Configurations/FeatureDefines.xcconfig:
17279 2010-06-06 Gavin Barraclough <barraclough@apple.com>
17281 Reviewed by Sam Weinig.
17283 Bug 40214 - Clean up error construction / throwing in JSC.
17285 The one egregious insanity here is that creating an error requires
17286 a VM-entry-esqe-host call (the string argument is wrapped as a JS
17287 object & pushed on the RegisterFile, then unwrapped back to a
17288 UString). Changing this also means you only require a global
17289 object, not an ExecState, to create an error.
17291 The methods to create error objects are also parameterized
17292 requiring a switch on the type, which can be made cleaner and
17293 faster by moving to a separate method per error type. Code to add
17294 divot information to error had been duplicated, and is coalesced
17295 back into a single function.
17297 Convenience methods added to create & throw type & syntax error
17298 with a default error message, since this is a common case.
17300 Also, errors are currently thrown either using
17301 "throwError(exec, error)" or "exec->setException(error)" - unify
17302 on the former, since this is more commonly used. Add
17303 "throwVMError(exec, error)" equivalents, as a convenience for
17304 cases where the result was being wrapped in "JSValue::encode(...)".
17306 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
17307 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
17308 * Plugins/Hosted/ProxyInstance.mm:
17309 (WebKit::ProxyInstance::invokeMethod):
17311 2010-06-02 Gavin Barraclough <barraclough@apple.com>
17313 Reviewed by Oliver Hunt.
17315 Bug 40094 - The return type of NativeFunction should be EncodedJSValue
17316 On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not.
17318 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
17319 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
17320 (WebKit::NetscapePluginInstanceProxy::invoke):
17322 2010-06-02 Sterling Swigart <sswigart@google.com>
17324 Reviewed by David Levin.
17326 Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
17327 https://bugs.webkit.org/show_bug.cgi?id=39906
17329 * Configurations/FeatureDefines.xcconfig:
17331 2010-06-01 David Hyatt <hyatt@apple.com>
17333 Reviewed by Anders Carlsson.
17335 Add a preference for paginating during layout (the new model for computing page breaks).
17337 * WebView/WebPreferenceKeysPrivate.h:
17338 * WebView/WebPreferences.mm:
17339 (-[WebPreferences paginateDuringLayoutEnabled]):
17340 (-[WebPreferences setPaginateDuringLayoutEnabled:]):
17341 * WebView/WebPreferencesPrivate.h:
17342 * WebView/WebView.mm:
17343 (-[WebView _preferencesChangedNotification:]):
17345 2010-06-01 Kevin Decker <kdecker@apple.com>
17347 Reviewed by Simon Fraser.
17349 https://bugs.webkit.org/show_bug.cgi?id=40025
17350 <rdar://problem/8046273> All Flash content crashes after installing CS5 Design Premium.
17352 * Plugins/WebBaseNetscapePluginView.mm:
17353 (-[WebBaseNetscapePluginView supportsSnapshotting]): Do not support snapshotting Flash 10.1 if
17354 the version is less than 10.1.53.60.
17356 2010-06-01 Alexey Proskuryakov <ap@apple.com>
17358 Reviewed by Sam Weinig.
17360 https://bugs.webkit.org/show_bug.cgi?id=39434
17361 REGRESSION (r59811): Geolocation callbacks cannot be created
17363 Removing unused WebGeolocationMock.
17365 * WebCoreSupport/WebGeolocationMock.mm: Removed.
17366 * WebCoreSupport/WebGeolocationMockPrivate.h: Removed.
17369 2010-05-30 Darin Adler <darin@apple.com>
17371 Reviewed by Sam Weinig.
17373 Make more HTML DOM members private, especially constructors, third and final batch
17374 https://bugs.webkit.org/show_bug.cgi?id=39916
17376 * WebView/WebHTMLRepresentation.mm:
17377 (-[WebHTMLRepresentation elementWithName:inForm:]): Use the new HTMLFormElement
17378 function, associatedElements, rather than getting directly at a data member
17379 named formElements.
17380 (-[WebHTMLRepresentation controlsInForm:]): Ditto.
17382 2010-05-28 Geoffrey Garen <ggaren@apple.com>
17384 Reviewed by Sam Weinig, Gavin Barraclough, Oliver Hunt.
17386 Simplified the host calling convention.
17388 PART ONE: Functional code changes.
17392 PART TWO: Global search and replace.
17394 In the areas below, I used global search-and-replace to change
17395 (ExecState*, JSObject*, JSValue, const ArgList&) => (ExecState*)
17396 args.size() => exec->argumentCount()
17397 args.at(i) => exec->argument(i)
17399 * Plugins/Hosted/ProxyInstance.h:
17400 * Plugins/Hosted/ProxyInstance.mm:
17401 (WebKit::ProxyInstance::invoke):
17402 (WebKit::ProxyInstance::invokeMethod):
17403 (WebKit::ProxyInstance::invokeDefaultMethod):
17405 2010-05-27 Beth Dakin <bdakin@apple.com>
17407 Reviewed by Simon Fraser.
17409 Change z-component to 1.
17411 * WebView/WebHTMLView.mm:
17412 (-[WebHTMLView viewDidMoveToWindow]):
17413 (-[WebHTMLView attachRootLayer:]):
17415 2010-05-26 Simon Fraser <simon.fraser@apple.com>
17417 Reviewed by Beth Dakin and Darin Adler.
17419 Fix for <rdar://problem/7464703> HiDPI: [Layers] Compositing layers
17420 do not scale properly when running with a resolution independent
17423 Apply the userSpaceScaleFactor as a scale on the layerHostingView.
17425 * WebView/WebHTMLView.mm:
17426 (-[WebHTMLView viewDidMoveToWindow]):
17427 (-[WebHTMLView attachRootLayer:]):
17429 2010-05-25 Alexey Proskuryakov <ap@apple.com>
17431 Reviewed by Darin Adler.
17433 https://bugs.webkit.org/show_bug.cgi?id=39621
17434 <rdar://problem/8009738> Extreme memory growth on DOM Hanoi test
17436 Removed formStateDidChange support, which is not needed by any client.
17438 * WebCoreSupport/WebChromeClient.h:
17439 (WebChromeClient::formStateDidChange):
17440 * WebCoreSupport/WebChromeClient.mm:
17441 * WebView/WebUIDelegatePrivate.h:
17443 2010-05-25 Brady Eidson <beidson@apple.com>
17445 Reviewed by Darin Adler.
17447 Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms)
17448 <rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486
17450 * Storage/WebDatabaseManager.mm:
17451 (WebKitInitializeDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on
17452 an already created tracker that already has its origins populated.
17454 2010-05-24 Darin Adler <darin@apple.com>
17456 Reviewed by Eric Seidel.
17458 Move view-related functions from Frame to FrameView
17459 https://bugs.webkit.org/show_bug.cgi?id=39366
17461 * WebView/WebView.mm:
17462 (-[WebView _setZoomMultiplier:isTextOnly:]): Call function on FrameView.
17463 (-[WebView setEditable:]): Get rid of call to empty function,
17464 removeEditingStyleFromBodyElement.
17466 2010-05-21 David Hyatt <hyatt@apple.com>
17468 Reviewed by Dan Bernstein.
17470 https://bugs.webkit.org/show_bug.cgi?id=39420
17472 Make sure everyone who needs to is using visitedDependentColor rather than accessing styles
17475 * Misc/WebNSAttributedStringExtras.mm:
17476 (+[NSAttributedString _web_attributedStringFromRange:]):
17477 * WebView/WebFrame.mm:
17478 (-[WebFrame _bodyBackgroundColor]):
17480 2010-05-21 Oliver Hunt <oliver@apple.com>
17482 Reviewed by Geoffrey Garen.
17484 All callable objects should have a global object reference
17485 https://bugs.webkit.org/show_bug.cgi?id=39495
17487 Update the plugin proxy to handle the need for global object.
17489 * Plugins/Hosted/ProxyInstance.mm:
17490 (WebKit::ProxyInstance::newRuntimeObject):
17491 (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
17492 (WebKit::ProxyInstance::getMethod):
17493 * Plugins/Hosted/ProxyRuntimeObject.h:
17494 * Plugins/Hosted/ProxyRuntimeObject.mm:
17495 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
17497 2010-05-21 Steve Block <steveblock@google.com>
17499 Reviewed by Jeremy Orlow.
17501 Add DeviceOrientation and DeviceOrientationClient
17502 https://bugs.webkit.org/show_bug.cgi?id=39479
17504 * WebView/WebView.mm:
17505 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
17507 2010-05-20 Mike Thole <mthole@apple.com>
17509 Reviewed by Dave Hyatt.
17511 When using a scale factor > 1, scrollbars sometimes appear when not necessary
17512 https://bugs.webkit.org/show_bug.cgi?id=39458
17514 * WebView/WebDynamicScrollBarsView.mm:
17515 (-[WebDynamicScrollBarsView updateScrollers]): Round up non-integral sizes from AppKit
17516 so that they can be compared against the integral document size.
17518 2010-05-20 Kevin Decker <kdecker@apple.com>
17520 Reviewed by Anders Carlsson.
17522 https://bugs.webkit.org/show_bug.cgi?id=39441
17523 <rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click
17524 <rdar://problem/7986109> Youtube video controller UI entirely missing
17525 <rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region)
17527 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
17528 (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and
17529 it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale
17530 factors this assumption is false. Accordingly we now convert to the window contentView
17531 coordinate system when computing bounds in "window" and the visible rect.
17532 * Plugins/WebNetscapePluginView.mm:
17533 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto.
17535 2010-05-20 Steve Block <steveblock@google.com>
17537 Reviewed by Jeremy Orlow.
17539 Provide bindings for DeviceOrientation
17540 https://bugs.webkit.org/show_bug.cgi?id=39210
17542 Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.
17544 * Configurations/FeatureDefines.xcconfig:
17546 2010-05-20 Martin Robinson <mrobinson@webkit.org>
17548 Reviewed by Ojan Vafai.
17550 Expose the editing behavior setting in DRT to test all editing code paths
17551 https://bugs.webkit.org/show_bug.cgi?id=38603
17553 * WebView/WebFrame.mm:
17555 * WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum.
17556 * WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting.
17557 * WebView/WebPreferences.mm:
17558 (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style.
17559 (-[WebPreferences editingBehavior]): Added.
17560 (-[WebPreferences setEditingBehavior:]): Added.
17561 * WebView/WebPreferencesPrivate.h: Added the new API points to the private API.
17562 * WebView/WebView.mm:
17563 (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting.
17565 2010-05-19 Anders Carlsson <andersca@apple.com>
17567 Reviewed by Kevin Decker and Simon Fraser.
17569 <rdar://problem/8004528>
17570 REGRESSION: Coordinate system for Core Animation NPAPI plug-ins is flipped with accelerated compositing turned on
17572 When needed, create a new CALayer and set it's geometry to be flipped. Add the plug-in layer as a sublayer and then return
17573 the newly created layer.
17575 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
17576 (-[WebHostedNetscapePluginView createPlugin]):
17577 * Plugins/WebNetscapePluginView.mm:
17578 (-[WebNetscapePluginView createPlugin]):
17580 2010-05-18 Tony Chang <tony@chromium.org>
17582 Reviewed by Darin Adler.
17584 https://bugs.webkit.org/show_bug.cgi?id=24943
17585 Command-B and Command-I do not generate keydown events in contentEditable regions.
17587 Manual test because performKeyEquivalent is not called by DRT.
17589 Test: manual-tests/style-keypress-events.html
17591 * WebView/WebHTMLView.mm:
17592 (-[WebHTMLView performKeyEquivalent:]): Move style key handling until after webcore gets a chance to handle the event
17594 2010-05-18 Daniel Cheng <dcheng@chromium.org>
17596 Reviewed by Darin Adler, Jian Li.
17598 DragData::asURL() shouldn't do file validity checks
17599 https://bugs.webkit.org/show_bug.cgi?id=38711
17601 Change [NSPasteboard _web_bestURL] to still return a file URL for paths
17602 that don't exist. Callers who care about the existence of the file or
17603 whether or not it is a directory should check themselves when they
17604 want to use the file. The directory check has been left in for now,
17605 since the Mac implementation of ResourceHandle, which uses this function
17606 indirectly via DragController::performDrag) handles directories somewhat
17607 non-intuitively: it opens the parent directory in the Finder, rather
17608 than opening the directory itself.
17610 * Misc/WebNSPasteboardExtras.mm:
17611 (-[NSPasteboard _web_bestURL]):
17613 2010-05-18 Eric Seidel <eric@webkit.org>
17615 Reviewed by Adam Barth (and Maciej Stachowiak).
17617 Make it possible to enable the new HTML5Tokenizer for testing
17618 https://bugs.webkit.org/show_bug.cgi?id=39275
17620 Expose the WebCore::Settings::html5ParserEnabled as a private WebKit setting.
17622 * WebView/WebPreferenceKeysPrivate.h:
17623 * WebView/WebPreferences.mm:
17624 (-[WebPreferences html5ParserEnabled]):
17625 (-[WebPreferences setHTML5ParserEnabled:]):
17626 * WebView/WebPreferencesPrivate.h:
17627 * WebView/WebView.mm:
17628 (-[WebView _preferencesChangedNotification:]):
17630 2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
17632 Unreviewed, rolling out r59652.
17633 http://trac.webkit.org/changeset/59652
17634 https://bugs.webkit.org/show_bug.cgi?id=39268
17636 file-input-files-access test is broken on Mac (Requested by
17637 dcheng on #webkit).
17639 * Misc/WebNSPasteboardExtras.mm:
17640 (-[NSPasteboard _web_bestURL]):
17642 2010-05-17 Daniel Cheng <dcheng@chromium.org>
17644 Reviewed by Darin Adler.
17646 DragData::asURL() shouldn't do file validity checks
17647 https://bugs.webkit.org/show_bug.cgi?id=38711
17649 Change [NSPasteboard _web_bestURL] to still return a file URL for paths
17650 that don't exist. Callers who care about the existence of the file or
17651 whether or not it is a directory should check themselves when they
17652 want to use the file. The directory check has been left in for now,
17653 since the Mac implementation of ResourceHandle, which uses this function
17654 indirectly via DragController::performDrag) handles directories somewhat
17655 non-intuitively: it opens the parent directory in the Finder, rather
17656 than opening the directory itself.
17658 * Misc/WebNSPasteboardExtras.mm:
17659 (-[NSPasteboard _web_bestURL]):
17661 2010-05-14 Stephanie Lewis <slewis@apple.com>
17663 Rubber-stamped by Mark Rowe.
17665 Update order files.
17669 2010-05-13 Timothy Hatcher <timothy@apple.com>
17671 Allow reporting exceptions that occur when using JavaScriptCore APIs
17672 to the Web Inspector.
17674 <rdar://problem/7975410>
17676 Reviewed by Sam Weinig.
17678 * WebView/WebView.mm:
17679 (+[WebView _reportException:inContext:]): Call WebCore::reportException after checking
17680 that the global object is a DOMWindow.
17681 * WebView/WebViewPrivate.h: Added _reportException:inContext:.
17683 2010-05-13 Alexey Proskuryakov <ap@apple.com>
17685 Reviewed by Darin Adler.
17687 https://bugs.webkit.org/show_bug.cgi?id=39089
17688 <rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode
17690 Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
17691 investigate a more extensible solution when there are more, and we know what the
17692 typical restictions are.
17694 * Misc/WebNSURLExtras.mm:
17695 (allCharactersAllowedByTLDRules):
17696 (-[NSString _web_mapHostNameWithRange:encode:makeString:]):
17698 2010-05-12 Simon Fraser <simon.fraser@apple.com>
17700 Reviewed by David Hyatt.
17702 Composited plug-ins can cause missed painting
17703 https://bugs.webkit.org/show_bug.cgi?id=39033
17704 <rdar://problem/7972478>
17706 Eagerly enable compositing mode via the enclosing FrameView when the plug-in tells us it wants
17709 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
17710 (-[WebHostedNetscapePluginView createPlugin]):
17711 * Plugins/WebNetscapePluginView.mm:
17712 (-[WebNetscapePluginView createPlugin]):
17714 2010-05-12 Jer Noble <jer.noble@apple.com>
17716 Reviewed by Darin Adler.
17718 Bug 38689: #34005 will break fullscreen video playback
17719 https://bugs.webkit.org/show_bug.cgi?id=38689
17721 Use the new definition of PlatformMedia to check the actual type
17722 returned by MediaPlayer.
17724 * WebView/WebVideoFullscreenController.mm:
17725 (-[WebVideoFullscreenController windowDidLoad]):
17727 2010-05-11 Mark Rowe <mrowe@apple.com>
17731 In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
17732 The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
17733 that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
17734 in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
17735 and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
17736 function in WebCore being called.
17738 We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
17739 other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
17742 * Configurations/FeatureDefines.xcconfig:
17744 2010-05-10 Simon Fraser <simon.fraser@apple.com>
17746 Reviewed by Anders Carlsson.
17748 Allow compositing layers to be connected across iframe boundaries on Mac
17749 https://bugs.webkit.org/show_bug.cgi?id=38856
17751 When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers"
17752 flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused
17753 content to show up in both compositing layers, and the painted background inside the iframe.
17755 Fix by taking the flattening state from the parent frame, if there is one. For the root
17756 frame, we continue to look to see if we're painting into a bitmap.
17758 * WebView/WebFrame.mm:
17759 (-[WebFrame _drawRect:contentsOnly:]):
17761 2010-05-10 Timothy Hatcher <timothy@apple.com>
17763 Fix a crash when closing a WebView while the Web Inspector is open.
17765 <rdar://problem/7966830>
17767 Reviewed by Mark Rowe.
17769 * WebCoreSupport/WebInspectorClient.mm:
17770 (-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.
17771 * WebView/WebView.mm:
17772 (-[WebView _close]): Null out _private->page before deleting the page, so code called
17773 during destruction don't access a half deleted Page object.
17775 2010-05-10 Anders Carlsson <andersca@apple.com>
17777 Unbreak the world. (Fix Mac builds).
17779 * Plugins/Hosted/WebKitPluginHostTypes.h:
17781 2010-05-10 Anders Carlsson <andersca@apple.com>
17783 Reviewed by Simon Fraser.
17785 Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
17786 use accelerated compositing and not layer backed views.
17788 * Plugins/Hosted/WebKitPluginHostTypes.h:
17790 2010-05-07 Anders Carlsson <andersca@apple.com>
17792 Reviewed by Sam Weinig and Simon Fraser.
17794 <rdar://problem/7947356>
17795 QT Plug-in in hardware-accelerated WebKit is missing the controller
17797 Replace the useSoftwareRenderer boolean with an enum that lets the plug-in host opt into using a layer
17798 backed NSView instead of inserting the layer into the WebCore layer hierarchy.
17800 * Plugins/Hosted/NetscapePluginHostManager.mm:
17801 (WebKit::NetscapePluginHostManager::instantiatePlugin):
17802 * Plugins/Hosted/NetscapePluginHostProxy.mm:
17803 (WKPCInstantiatePluginReply):
17804 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
17805 (WebKit::NetscapePluginInstanceProxy::rendererType):
17806 (WebKit::NetscapePluginInstanceProxy::setRendererType):
17807 (WebKit::NetscapePluginInstanceProxy::InstantiatePluginReply::InstantiatePluginReply):
17808 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
17809 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
17810 Replace the useSoftwareRenderer boolean everywhere with the RendererType enum.
17812 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
17813 (-[WebHostedNetscapePluginView createPlugin]):
17814 Only go into full compositing mode when the renderer type returned is UseAcceleratedCompositing.
17815 Otherwise, use a layer backed NSView.
17817 * Plugins/Hosted/WebKitPluginHostTypes.h:
17818 Add a RendererType enum.
17820 2010-05-06 Anders Carlsson <andersca@apple.com>
17822 Reviewed by Darin Adler and Dan Bernstein..
17824 REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
17825 https://bugs.webkit.org/show_bug.cgi?id=38698
17826 <rdar://problem/7942075>
17828 When the plug-in database is initialized, we will register all the MIME types it supports with the global
17829 WebView dictionary. When plug-ins are disabled for a single web view, the MIME types still need to be
17830 in the global mapping (because other web views might still have plug-ins enabled).
17832 Prior to r51617 we would always look at the plug-in database to determine that the MIME type belongs to a
17833 plug-in, but now we won't even touch the plug-in database when plug-ins are disabled.
17835 In order to fix this, a new set of registered MIME types that are known to be plug-ins is added. When
17836 +[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:] is called and allowingPlugins is FALSE
17837 we check if the MIME type is a known plug-in MIME type and return false in that case.
17839 * Plugins/WebPluginDatabase.mm:
17840 (-[WebPluginDatabase refresh]):
17841 (-[WebPluginDatabase _removePlugin:]):
17842 * WebView/WebView.mm:
17843 (knownPluginMIMETypes):
17844 (+[WebView _registerPluginMIMEType:]):
17845 (+[WebView _unregisterPluginMIMEType:]):
17846 (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
17847 * WebView/WebViewInternal.h:
17849 2010-05-06 Dan Bernstein <mitz@apple.com>
17851 Reviewed by Simon Fraser.
17853 <rdar://problem/7951285> REGRESSION (r58847): Composited iframe content obscures Safari's application chrome
17855 Fixed this other regression from r58847. The regression was caused by overriding -visibleRect to
17856 return the WebClipView’s full bounds. AppKit uses -visibleRect to determine the geometry
17857 of the surface for the child WebFrameView. The fix is to restrict the special behavior of
17858 -[WebClipView visibleRect] to when AppKit is consulting it for the purpose of invalidating
17859 areas while scrolling.
17861 * WebView/WebClipView.h:
17862 * WebView/WebClipView.mm:
17863 (-[WebClipView visibleRect]): If the WebClipView is not scrolling, always return
17864 [super visibleRect].
17865 (-[WebClipView _immediateScrollToPoint:]): Override this internal NSClipView method
17866 to set a flag telling -visibleRect that the view is scrolling.
17867 * WebView/WebView.mm:
17868 (layerSyncRunLoopObserverCallBack): Ensure that screen updates, disabled by AppKit
17869 when it thinks an upcoming window flush will re-enable them, are enabled here in
17870 case the -setNeedsDisplayInRect: override has prevented the window from needing to be
17873 2010-05-06 Steve Block <steveblock@google.com>
17875 Reviewed by Eric Seidel.
17877 MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
17878 https://bugs.webkit.org/show_bug.cgi?id=38544
17880 * WebCoreSupport/WebFrameLoaderClient.h:
17881 * WebCoreSupport/WebFrameLoaderClient.mm:
17883 2010-05-05 Dan Bernstein <mitz@apple.com>
17885 Reviewed by Mark Rowe.
17887 Fixed a crash when closing Top Sites after r58847.
17889 * WebView/WebFrameView.mm:
17890 (-[WebFrameView webFrame]): Null-check _private.
17892 2010-05-05 Dan Bernstein <mitz@apple.com>
17894 Rubber-stamped by Mark Rowe.
17896 Fixed test crashes after r58847.
17898 * WebView/WebHTMLView.mm:
17899 (setNeedsDisplayInRect): Null-check the frame.
17901 2010-05-05 Dan Bernstein <mitz@apple.com>
17903 Reviewed by Simon Fraser.
17905 <rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
17906 https://bugs.webkit.org/show_bug.cgi?id=38427
17908 * WebView/WebClipView.m: Renamed to WebClipView.mm.
17909 * WebView/WebClipView.mm:
17910 (-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in
17911 composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to
17912 AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy.
17913 Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping.
17914 * WebView/WebHTMLView.mm:
17915 (setCursor): Style tweak.
17916 (setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:],
17917 so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation
17918 is routed back through the WebCore FrameView, which propagates it to the layer.
17919 (+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in.
17920 (-[WebHTMLView visibleRect]): Removed whitespace.
17921 * WebView/WebView.mm:
17922 (layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout
17923 in preparation for the displaying of compositing layers.
17925 2010-05-05 John Sullivan <sullivan@apple.com>
17927 <rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened
17929 Reviewed by Mark Rowe.
17931 * WebView/WebView.mm:
17932 (+[WebView closeAllWebViews]):
17933 Make copy of allWebViewsSet to avoid mutating it while iterating through it.
17935 2010-05-04 Simon Fraser <simon.fraser@apple.com>
17937 Reviewed by Dan Bernstein.
17939 Improve check for drawing into the window that was added in r58623
17940 https://bugs.webkit.org/show_bug.cgi?id=38562
17942 Rather than assuming that any non-bitmap context is the window's context,
17943 compare the current graphics context with -[NSWindow graphicsContext] to
17944 determine that we're drawing into the window.
17946 * WebView/WebHTMLView.mm:
17947 (-[WebHTMLView drawRect:]):
17949 2010-05-04 Ada Chan <adachan@apple.com>
17951 Reviewed by David Kilzer.
17953 https://bugs.webkit.org/show_bug.cgi?id=38555
17955 Small code refactoring: move the logic to figure out the path to the
17956 databases directory to another method.
17958 * Storage/WebDatabaseManager.mm:
17959 (databasesDirectoryPath):
17960 (WebKitInitializeDatabasesIfNecessary):
17962 2010-05-04 Beth Dakin <bdakin@apple.com>
17964 Reviewed by Mike Thole.
17966 Fix for <rdar://problem/7818509> Crash occurs when exiting Safari
17968 We can avoid this crash if we call [self _removeFromAllWebViewsSet]
17969 even in the case when we are doing a fastDocumentTeardown. This is
17970 a much safer approach.
17971 * WebView/WebView.mm:
17972 (-[WebView _close]):
17974 2010-05-03 Abhishek Arya <inferno@chromium.org>
17976 Reviewed by Adam Barth.
17978 Add support for controlling clipboard access from javascript.
17979 Clipboard access from javascript is disabled by default.
17980 https://bugs.webkit.org/show_bug.cgi?id=27751
17982 * WebView/WebPreferenceKeysPrivate.h:
17983 * WebView/WebPreferences.mm:
17984 (+[WebPreferences initialize]):
17985 (-[WebPreferences javaScriptCanAccessClipboard]):
17986 (-[WebPreferences setJavaScriptCanAccessClipboard:]):
17987 * WebView/WebPreferencesPrivate.h:
17988 * WebView/WebView.mm:
17989 (-[WebView _preferencesChangedNotification:]):
17991 2010-05-03 Jens Alfke <snej@chromium.org>
17993 Reviewed by Darin Fisher.
17995 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
17996 https://bugs.webkit.org/show_bug.cgi?id=38397
17998 No tests (functionality is exposed only through native WebKit API.)
18000 * WebCoreSupport/WebFrameLoaderClient.h:
18001 (WebFrameLoaderClient::dispatchWillSendSubmitEvent):
18003 2010-04-30 Simon Fraser <simon.fraser@apple.com>
18005 Reviewed by Dan Bernstein.
18007 <rdar://problem/7477071> REGRESSION: Bad flicker when wheel-scrolling Google Maps, iPad gallery and other sites
18009 Sites that frequently toggle content in and out of compositing layers (like http://www.tumblr.com/boothed)
18010 can cause flickering because of unsychronized compositing layer and view-based updates. There were two
18013 1. On SnowLeopard, AppKit can throttle window updates, thus breaking an assumption that
18014 NSView drawing will happen on the runloop cycle after a repaint. This provided a window
18015 for the layerSyncRunLoopObserver to fire and commit layer changes too early.
18017 Fix this by having the layerSyncRunLoopObserver in WebView check to see if a display is pending,
18018 and not commit layer changes in that case. We'll commit layer changes later when we
18021 2. The change in r49269 was wrong; it was attempting to fix an issue that was actually caused
18022 by -drawRects: coming in for page snapshots. The correct approach is to avoid hitting the
18023 synchronization and update disabling code in WebHTMLView for draws that are not to the screen.
18025 * WebView/WebHTMLView.mm:
18026 (-[WebHTMLView drawRect:]):
18027 * WebView/WebView.mm:
18028 (layerSyncRunLoopObserverCallBack):
18029 (-[WebView _scheduleCompositingLayerSync]):
18031 2010-04-30 Anders Carlsson <andersca@apple.com>
18033 Part of the previous part (forgot to save).
18035 * Plugins/WebNetscapePluginView.mm:
18036 (-[WebNetscapePluginView stopTimers]):
18037 (-[WebNetscapePluginView startTimers]):
18038 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
18039 (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
18040 (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]):
18041 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
18042 (-[WebNetscapePluginView unscheduleTimer:]):
18043 (-[WebNetscapePluginView getVariable:forURL:value:length:]):
18044 (-[WebNetscapePluginView setVariable:forURL:value:length:]):
18046 2010-04-30 Anders Carlsson <andersca@apple.com>
18048 Reviewed by Darin Adler.
18050 Use C99 integer types in more places.
18052 * Plugins/WebNetscapePluginView.mm:
18055 2010-04-30 Anders Carlsson <andersca@apple.com>
18059 * Plugins/WebBaseNetscapePluginStream.h:
18060 * Plugins/WebBaseNetscapePluginStream.mm:
18061 (WebNetscapePluginStream::startStream):
18063 2010-04-30 Anders Carlsson <andersca@apple.com>
18065 Another 32-bit build fix.
18067 * Plugins/WebNetscapePluginView.mm:
18068 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
18070 2010-04-30 Anders Carlsson <andersca@apple.com>
18072 Fix 32-bit build (again).
18074 * Plugins/WebNetscapeContainerCheckContextInfo.h:
18075 * Plugins/WebNetscapeContainerCheckContextInfo.mm:
18076 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
18077 (-[WebNetscapeContainerCheckContextInfo checkRequestID]):
18078 (-[WebNetscapeContainerCheckContextInfo callback]):
18079 * Plugins/WebNetscapePluginPackage.h:
18081 2010-04-30 Anders Carlsson <andersca@apple.com>
18085 * Plugins/WebNetscapeContainerCheckContextInfo.h:
18086 * Plugins/WebNetscapeContainerCheckContextInfo.mm:
18087 (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
18088 * Plugins/WebNetscapeContainerCheckPrivate.h:
18089 * Plugins/WebNetscapePluginPackage.mm:
18090 (functionPointerForTVector):
18091 * Plugins/WebNetscapePluginView.mm:
18092 (PluginTimer::PluginTimer):
18093 (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
18094 (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
18096 2010-04-30 Anders Carlsson <andersca@apple.com>
18098 Reviewed by Timothy Hatcher.
18100 Next step towards fixing
18102 https://bugs.webkit.org/show_bug.cgi?id=20784
18103 move npapi.h to C99 integer types
18105 Use the C99 types everywhere. The "old" types are still around but will be removed
18106 in a subsequent commit.
18108 * Plugins/WebBaseNetscapePluginStream.h:
18109 * Plugins/WebBaseNetscapePluginStream.mm:
18110 (WebNetscapePluginStream::deliverData):
18111 * Plugins/WebNetscapePluginView.h:
18112 * Plugins/WebNetscapePluginView.mm:
18113 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
18114 (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]):
18115 * Plugins/npapi.mm:
18118 (NPN_PostURLNotify):
18121 (NPN_ScheduleTimer):
18122 (NPN_UnscheduleTimer):
18123 (NPN_GetValueForURL):
18124 (NPN_SetValueForURL):
18125 (NPN_GetAuthenticationInfo):
18126 (WKN_CheckIfAllowedToLoadURL):
18127 (WKN_CancelCheckIfAllowedToLoadURL):
18129 2010-04-29 Anders Carlsson <andersca@apple.com>
18131 Reviewed by Dan Bernstein.
18134 https://bugs.webkit.org/show_bug.cgi?id=20784
18135 move npapi.h to C99 integer types.
18137 * MigrateHeaders.make:
18139 2010-04-28 Mike Thole <mthole@apple.com>
18141 Reviewed by David Kilzer.
18143 Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
18144 can be inspected before attempting to authenticate against it
18145 https://bugs.webkit.org/show_bug.cgi?id=38271
18147 * WebCoreSupport/WebFrameLoaderClient.h:
18148 * WebCoreSupport/WebFrameLoaderClient.mm:
18149 (WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
18150 Added. If the resource load delegate implements the callback, use its answer. If it does
18151 not, then only send authentication challenges for pre-10.6 protection spaces, which matches
18152 CFNetwork's default behavior.
18153 * WebView/WebDelegateImplementationCaching.h:
18154 * WebView/WebDelegateImplementationCaching.mm:
18155 (CallResourceLoadDelegateReturningBoolean): Added case for passing three objects.
18156 * WebView/WebResourceLoadDelegatePrivate.h:
18157 Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:
18158 * WebView/WebView.mm:
18159 (-[WebView _cacheResourceLoadDelegateImplementations]):
18161 2010-04-28 Simon Fraser <simon.fraser@apple.com>
18163 Reviewed by Sam Weinig.
18165 <rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing()
18167 Ensure that the WebView +initialize method initializes threading, so that things are correctly
18168 initialized when the first call into the WebKit framework is via a WebView class method.
18170 * WebView/WebView.mm:
18171 (+[WebView initialize]):
18173 2010-04-28 Darin Adler <darin@apple.com>
18175 Reviewed by Adele Peterson.
18177 REGRESSION: Autoscroll does not work in Mail messages
18178 https://bugs.webkit.org/show_bug.cgi?id=38267
18179 rdar://problem/7559799
18181 The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
18182 view had gotten broken in multiple ways. For some reason, a combination of bugs made it
18183 partly work until around r48064. This brings it back.
18185 * WebCoreSupport/WebChromeClient.mm:
18186 (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view
18187 rather than the WebView itself. This logic may not be correct for the case where
18188 usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later.
18190 2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>
18192 Reviewed by Darin Adler and Eric Seidel.
18194 Add layoutTestController.setPrinting()
18195 https://bugs.webkit.org/show_bug.cgi?id=37203
18197 * Misc/WebCoreStatistics.h:
18198 * Misc/WebCoreStatistics.mm:
18199 (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):
18201 2010-04-25 Sam Weinig <sam@webkit.org>
18203 Reviewed by Maciej Stachowiak.
18205 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
18206 Disentangle initializing the main thread from initializing threading
18208 Calls initializeMainThreadToProcessMainThread since there is no way to ensure
18209 that the initialize method will be called on the main thread.
18211 * Carbon/CarbonWindowAdapter.mm:
18212 (+[CarbonWindowAdapter initialize]): Add call to initializeMainThreadToProcessMainThread.
18213 * History/WebBackForwardList.mm:
18214 (+[WebBackForwardList initialize]): Ditto.
18215 * History/WebHistoryItem.mm:
18216 (+[WebHistoryItem initialize]): Ditto.
18217 * Misc/WebElementDictionary.mm:
18218 (+[WebElementDictionary initialize]): Ditto.
18219 * Misc/WebIconDatabase.mm:
18220 (+[WebIconDatabase initialize]): Ditto.
18221 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
18222 (+[WebHostedNetscapePluginView initialize]): Ditto.
18223 * Plugins/WebBaseNetscapePluginView.mm:
18224 (+[WebBaseNetscapePluginView initialize]): Ditto.
18225 * Plugins/WebBasePluginPackage.mm:
18226 (+[WebBasePluginPackage initialize]): Ditto.
18227 * Plugins/WebNetscapePluginView.mm:
18228 (+[WebNetscapePluginView initialize]): Ditto.
18229 * WebCoreSupport/WebEditorClient.mm:
18230 (+[WebEditCommand initialize]): Ditto.
18231 * WebCoreSupport/WebFrameLoaderClient.mm:
18232 (+[WebFramePolicyListener initialize]): Ditto.
18233 * WebView/WebArchive.mm:
18234 (+[WebArchivePrivate initialize]): Ditto.
18235 * WebView/WebDataSource.mm:
18236 (+[WebDataSourcePrivate initialize]): Ditto.
18237 * WebView/WebHTMLView.mm:
18238 (+[WebHTMLViewPrivate initialize]): Ditto.
18239 (+[WebHTMLView initialize]): Ditto.
18240 * WebView/WebResource.mm:
18241 (+[WebResourcePrivate initialize]): Ditto.
18242 * WebView/WebTextIterator.mm:
18243 (+[WebTextIteratorPrivate initialize]): Ditto.
18244 * WebView/WebView.mm:
18245 * WebView/WebViewData.mm: Ditto.
18246 (+[WebViewPrivate initialize]): Ditto.
18248 2010-04-24 Dan Bernstein <mitz@apple.com>
18250 Reviewed by Darin Adler.
18252 <rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME types
18253 https://bugs.webkit.org/show_bug.cgi?id=38085
18255 WebView was calling -_webView in a few places where it should have just used itself. It never
18256 makes sense for WebView to call -_webView on itself, and these calls look like they were copied
18257 from similar code in WebHTMLView, WebFrameView and WebDataSource, where -_webView has a different,
18260 * WebView/WebView.mm:
18261 (-[WebView drawSingleRect:]): Replaced [self _webView] with self.
18262 (-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Replaced [[self _webView] preferences]
18263 with _private->preferences.
18264 (-[WebView _canShowMIMEType:]): Ditto.
18266 2010-04-23 Simon Fraser <simon.fraser@apple.com>
18268 Reviewed by Anders Carlsson.
18270 <rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint
18272 When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling
18273 NPPrint with a GWorldPtr, since Flash prefers the CGContext path.
18275 * Plugins/WebNetscapePluginView.mm:
18276 (-[WebNetscapePluginView drawRect:]):
18278 2010-04-22 David Kilzer <ddkilzer@apple.com>
18280 <http://webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call to JSC::initializeThreading()
18282 Reviewed by Timothy Hatcher.
18284 Every other Objective-C class that calls
18285 WebCoreObjCFinalizeOnMainThread(self) in +initialize also calls
18286 JSC::initializeThreading(). The WebTextIteratorPrivate class
18287 was the only one missing this call.
18289 * WebView/WebTextIterator.mm:
18290 (+[WebTextIteratorPrivate initialize]): Added call to
18291 JSC::initializeThreading().
18293 2010-04-22 Alexey Proskuryakov <ap@apple.com>
18295 Rubber-stamped by Mark Rowe.
18297 <rdar://problem/7805969> REGRESSION: iTunes unable to play trailers
18299 Undo the changes made for https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>)
18300 for now. Clients rely on the old behavior, so a fix that changes it will need to account for
18303 * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL
18304 instead of baseURL again.
18306 2010-04-22 Dave Moore <davemoore@chromium.org>
18308 Reviewed by Dimitri Glazkov.
18310 Added notification when the favicons for a page are changed
18312 The Document object will notify the frame loader, which will
18313 notify the client. Implementations of FrameLoaderClient will
18314 have to add one method; dispatchDidChangeIcons().
18316 https://bugs.webkit.org/show_bug.cgi?id=33812
18318 * WebCoreSupport/WebFrameLoaderClient.h:
18319 * WebCoreSupport/WebFrameLoaderClient.mm:
18320 (WebFrameLoaderClient::dispatchDidChangeIcons):
18322 2010-04-22 Adam Barth <abarth@webkit.org>
18324 Unreviewed, rolling out r58069.
18325 http://trac.webkit.org/changeset/58069
18326 https://bugs.webkit.org/show_bug.cgi?id=27751
18328 Broke compile on Windows.
18330 * WebView/WebPreferenceKeysPrivate.h:
18331 * WebView/WebPreferences.mm:
18332 (+[WebPreferences initialize]):
18333 * WebView/WebPreferencesPrivate.h:
18334 * WebView/WebView.mm:
18335 (-[WebView _preferencesChangedNotification:]):
18337 2010-04-22 Abhishek Arya <inferno@chromium.org>
18339 Reviewed by Adam Barth.
18341 Add support for controlling clipboard access from javascript.
18342 Clipboard access from javascript is disabled by default.
18343 https://bugs.webkit.org/show_bug.cgi?id=27751
18345 * WebView/WebPreferenceKeysPrivate.h:
18346 * WebView/WebPreferences.mm:
18347 (+[WebPreferences initialize]):
18348 (-[WebPreferences javaScriptCanAccessClipboard]):
18349 (-[WebPreferences setJavaScriptCanAccessClipboard:]):
18350 * WebView/WebPreferencesPrivate.h:
18351 * WebView/WebView.mm:
18352 (-[WebView _preferencesChangedNotification:]):
18354 2010-04-21 Alexey Proskuryakov <ap@apple.com>
18356 Reviewed by Shinichiro Hamaji.
18358 https://bugs.webkit.org/show_bug.cgi?id=37964
18359 Fix a typo in comments - Korean encoding name is windows-949, not windows-939
18361 * WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
18363 2010-04-21 Mark Rowe <mrowe@apple.com>
18367 * Plugins/WebPluginController.mm: Add an #import that is necessary on Tiger.
18369 2010-04-21 Mark Rowe <mrowe@apple.com>
18371 Reviewed by Eric Carlson.
18373 <rdar://problem/7313430> Many crashes in Safari inside Flip4Mac below -[NSAlert didEndAlert:returnCode:contextInfo:]
18375 Existing versions of the Flip4Mac WebKit plug-in have an object lifetime bug related to an NSAlert that is
18376 used to notify the user about updates to the plug-in. This bug can result in Safari crashing if the page
18377 containing the plug-in navigates while the alert is displayed (<rdar://problem/7313430>).
18379 The gist of the bug is thus: Flip4Mac sets an instance of the TSUpdateCheck class as the modal delegate of the
18380 NSAlert instance. This TSUpdateCheck instance itself has a delegate. The delegate is set to the WmvPlugin
18381 instance which is the NSView subclass that is exposed to WebKit as the plug-in view. Since this relationship
18382 is that of delegates the TSUpdateCheck does not retain the WmvPlugin. This leads to a bug if the WmvPlugin
18383 instance is destroyed before the TSUpdateCheck instance as the TSUpdateCheck instance will be left with a
18384 pointer to a stale object. This will happen if a page containing the Flip4Mac plug-in triggers a navigation
18385 while the update sheet is visible as the WmvPlugin instance is removed from the view hierarchy and there are
18386 no other references to keep the object alive.
18388 We work around this bug by patching the following two messages:
18390 1) -[NSAlert beginSheetModalForWindow:modalDelegate:didEndSelector:contextInfo:]
18391 2) -[TSUpdateCheck alertDidEnd:returnCode:contextInfo:]
18393 Our override of 1) detects whether it is Flip4Mac's update sheet triggering the alert by checking whether the
18394 modal delegate is an instance of TSUpdateCheck. If it is, it retains the modal delegate's delegate.
18396 Our override of 2) then autoreleases the delegate, balancing the retain we added in 1).
18398 These two overrides have the effect of ensuring that the WmvPlugin instance will always outlive the TSUpdateCheck
18399 instance, preventing the TSUpdateCheck instance from accessing a stale delegate pointer and crashing the application.
18401 * Plugins/WebPluginController.mm:
18402 (-[WebPluginController addPlugin:]): Check whether the plug-in being instantiated is the Flip4Mac plug-in and
18403 install our workaround if it is.
18404 (isKindOfClass): Helper function that checks whether the given object is an instance of the named class.
18405 (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_): Autorelease the delegate.
18406 (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_): Retain the modal delegate's
18407 delegate if this NSAlert belongs to the Flip4Mac plug-in.
18408 (installFlip4MacPlugInWorkaroundIfNecessary): Swizzle the necessary methods. We swizzle the TSUpdateCheck methods
18409 first since it is possible that in some versions of Flip4Mac the TSUpdateCheck class may not exist or may not have
18410 the method we're interested in. In that case we want to bail out before patching any methods.
18412 2010-04-20 Mark Rowe <mrowe@apple.com>
18414 Reviewed by Maciej Stachowiak.
18416 <rdar://problem/7856151> REGRESSION: NPP_Destroy is not called when page navigates when plug-in is displaying modal dialog
18418 An interaction between the plug-in host and WebKit was resulting in WKPCSetModal being called while
18419 NetscapePluginInstanceProxy was waiting on a reply to the GetScriptableNPObject message. This resulted
18420 in calls to stop the plug-in being deferred due to the presence of plug-in code up the stack. This
18421 could lead to crashes as it was possible for the plug-in view to be deallocated during the modal runloop.
18423 * Plugins/Hosted/NetscapePluginHostProxy.mm:
18424 (WKPCInvalidateRect):
18425 (WKPCSetModal): Defer the handling of setModal until the next runloop iteration if the host proxy
18426 is already processing requests. This ensures that there will be no plug-in code on the stack when
18427 the modal runloop is entered, which allows the plug-in to be stopped when the page is navigated while
18428 a modal dialog is displayed.
18430 2010-04-20 Adam Barth <abarth@webkit.org>
18432 Reviewed by Eric Seidel.
18434 Factor DocumentWriter out of FrameLoader
18435 https://bugs.webkit.org/show_bug.cgi?id=37175
18437 Update these callsites because the method moved to DocumentWriter.
18439 * WebView/WebFrame.mm:
18440 (-[WebFrame _canProvideDocumentSource]):
18441 (-[WebFrame _receivedData:textEncodingName:]):
18443 2010-04-20 Kent Tamura <tkent@chromium.org>
18445 Reviewed by Darin Adler.
18447 Change a parameter type of chooseIconForFiles()
18448 https://bugs.webkit.org/show_bug.cgi?id=37504
18450 * WebCoreSupport/WebChromeClient.h:
18451 * WebCoreSupport/WebChromeClient.mm:
18452 (WebChromeClient::chooseIconForFiles):
18454 2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
18456 Unreviewed, rolling out r57892.
18457 http://trac.webkit.org/changeset/57892
18458 https://bugs.webkit.org/show_bug.cgi?id=37864
18460 Caused an assertion in Mac builds (Requested by smfr on
18463 * WebView/WebFrame.mm:
18464 (-[WebFrame _getVisibleRect:]):
18465 * WebView/WebFrameView.mm:
18466 (-[WebFrameView _install]):
18468 2010-04-20 Simon Fraser <simon.fraser@apple.com>
18470 Reviewed by Dan Bernstein.
18472 Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
18473 https://bugs.webkit.org/show_bug.cgi?id=37741
18475 Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
18476 RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().
18478 * WebView/WebFrame.mm:
18479 (-[WebFrame _getVisibleRect:]):
18480 * WebView/WebFrameView.mm:
18481 (-[WebFrameView _install]):
18483 2010-04-19 Dan Bernstein <mitz@apple.com>
18485 Reviewed by Sam Weinig.
18487 Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
18488 printing width as SPI.
18490 * WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.
18492 2010-04-15 Gavin Barraclough <barraclough@apple.com>
18494 Reviewed by Sam Weinig & Oliver Hunt.
18496 https://bugs.webkit.org/show_bug.cgi?id=37675
18497 Remove casts/constructors to/from JSC::UString type from WebCore::String
18499 WebCore's strings should not know about JSC::UString, this should be abstracted
18500 away in the bindings. Add explicit conversion methods rather than relying on
18501 overloaded cast operators / constructors being implicitly called.
18503 This patch only changes the class String, once this has landed StringImpl, and
18504 hopefully AtomicString too, should follow suit.
18506 * Plugins/Hosted/NetscapePluginHostProxy.mm:
18507 (identifierFromIdentifierRep):
18508 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18509 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
18510 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
18511 * Plugins/Hosted/ProxyInstance.mm:
18512 (WebKit::ProxyInstance::getPropertyNames):
18513 * WebView/WebFrame.mm:
18514 (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
18515 (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
18516 * WebView/WebScriptDebugDelegate.mm:
18517 (-[WebScriptCallFrame evaluateWebScript:]):
18518 * WebView/WebScriptDebugger.mm:
18520 * WebView/WebView.mm:
18521 (aeDescFromJSValue):
18523 2010-04-16 Dan Bernstein <mitz@apple.com>
18525 Reviewed by John Sullivan.
18527 Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
18528 printing width as SPI.
18530 * WebView/WebHTMLView.mm:
18531 Replaced two macros with constants.
18532 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
18533 (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
18534 * WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and
18535 _WebHTMLViewPrintingMaximumShrinkFactor.
18537 2010-04-15 Mark Rowe <mrowe@apple.com>
18539 Reviewed by Sam Weinig.
18541 <rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors when included in plain Objective-C files.
18543 * WebView/WebDynamicScrollBarsView.h:
18545 2010-04-15 Adam Roben <aroben@apple.com>
18547 Export WebUserContentURLPattern from WebKit
18549 Rubber-stamped by Mark Rowe.
18553 2010-04-15 Dan Bernstein <mitz@apple.com>
18555 Reviewed by Simon Fraser.
18557 Made consecutive calls to -[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:] work
18558 without intermediate calls -[WebHTMLView _endPrintMode].
18560 * WebView/WebHTMLView.mm:
18561 (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
18563 2010-04-15 Adam Roben <aroben@apple.com>
18565 Expose UserContentURLPattern as WebKit SPI
18567 Fixes <http://webkit.org/b/37354>.
18569 Reviewed by Tim Hatcher.
18571 * Misc/WebUserContentURLPattern.h: Added.
18573 * Misc/WebUserContentURLPattern.mm: Added.
18574 (-[WebUserContentURLPattern initWithPatternString:]): Initialize
18575 _private and then parse the passed-in string into a
18576 UserContentURLPattern.
18577 (-[WebUserContentURLPattern dealloc]): Release _private.
18579 (-[WebUserContentURLPattern isValid]):
18580 (-[WebUserContentURLPattern scheme]):
18581 (-[WebUserContentURLPattern host]):
18582 (-[WebUserContentURLPattern matchesSubdomains]):
18583 Call through to UserContentURLPattern.
18585 2010-04-13 Geoffrey Garen <ggaren@apple.com>
18587 Reviewed by Oliver Hunt.
18589 Separated a DOMWrapperWorld's behavior of keeping wrappers alive from
18590 its own lifetime, so a DOMWrapperWorld's controller can throw away
18591 its wrappers even before its refcount reaches 0.
18593 * WebView/WebScriptWorld.h:
18594 * WebView/WebScriptWorld.mm:
18595 (-[WebScriptWorld unregisterWorld]): Exported this function through WebKit.
18597 2010-04-12 Timothy Hatcher <timothy@apple.com>
18599 SecurityOrigin needs a way to remove individual OriginAccessEntries
18600 https://bugs.webkit.org/show_bug.cgi?id=37449
18602 Reviewed by Dave Hyatt.
18604 * WebView/WebView.mm:
18605 (+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
18606 Call SecurityOrigin::removeOriginAccessWhitelistEntry.
18607 * WebView/WebViewPrivate.h: Added _removeOriginAccessWhitelistEntryWithSourceOrigin.
18609 2010-04-13 Timothy Hatcher <timothy@apple.com>
18611 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
18612 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
18614 SecurityOrigin needs a way to remove individual OriginAccessEntries
18615 https://bugs.webkit.org/show_bug.cgi?id=37449
18617 Reviewed by Dave Hyatt.
18619 * WebView/WebView.mm:
18620 (+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
18621 (+[WebView _resetOriginAccessWhitelists]):
18622 * WebView/WebViewPrivate.h:
18624 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
18626 Unreviewed, rolling out r57468.
18627 http://trac.webkit.org/changeset/57468
18628 https://bugs.webkit.org/show_bug.cgi?id=37433
18630 Broke the world... Must have applied the patch wrong
18631 (Requested by abarth on #webkit).
18633 * WebView/WebFrame.mm:
18634 (-[WebFrame _canProvideDocumentSource]):
18635 (-[WebFrame _receivedData:textEncodingName:]):
18637 2010-04-11 Adam Barth <abarth@webkit.org>
18639 Reviewed by Eric Seidel.
18641 Factor DocumentWriter out of FrameLoader
18642 https://bugs.webkit.org/show_bug.cgi?id=37175
18644 Update these callsites because the method moved to DocumentWriter.
18646 * WebView/WebFrame.mm:
18647 (-[WebFrame _canProvideDocumentSource]):
18648 (-[WebFrame _receivedData:textEncodingName:]):
18650 2010-04-10 Mark Rowe <mrowe@apple.com>
18652 Reviewed by Dan Bernstein.
18654 <rdar://problem/7845305> Further adoption of formal protocols for delegates.
18656 Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places.
18658 * Misc/EmptyProtocolDefinitions.h: Removed.
18659 * Misc/WebDownload.mm:
18662 2010-04-09 Jer Noble <jer.noble@apple.com>
18664 Reviewed by Darin Adler.
18666 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
18667 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
18669 * WebView/WebVideoFullscreenController.mm:
18670 (-[WebVideoFullscreenController windowDidLoad]):
18671 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
18673 2010-04-09 Alexey Proskuryakov <ap@apple.com>
18675 Reviewed by Maciej Stachowiak.
18677 https://bugs.webkit.org/show_bug.cgi?id=24572
18678 XMLHttpRequest.statusText returns always "OK" on Mac
18680 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
18682 2010-04-09 Eric Seidel <eric@webkit.org>
18684 Unreviewed, rolling out r57343.
18685 http://trac.webkit.org/changeset/57343
18686 https://bugs.webkit.org/show_bug.cgi?id=37311
18688 Broke Tiger compile.
18690 * WebView/WebVideoFullscreenController.mm:
18691 (-[WebVideoFullscreenController windowDidLoad]):
18692 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
18694 2010-04-09 Dan Bernstein <mitz@apple.com>
18696 Reviewed by Darin Adler.
18698 <rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window
18700 * WebView/WebDynamicScrollBarsView.mm:
18701 (-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private.
18703 2010-04-09 Jer Noble <jer.noble@apple.com>
18705 Reviewed by Darin Adler.
18707 Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
18708 https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>
18710 * WebView/WebVideoFullscreenController.mm:
18711 (-[WebVideoFullscreenController windowDidLoad]):
18712 (-[WebVideoFullscreenController setMediaElement:WebCore::]):
18714 2010-04-08 Mark Rowe <mrowe@apple.com>
18716 Reviewed by John Sullivan.
18718 <rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]
18720 In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
18721 This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
18722 size and layout of their subclasses is baked in at compile time. This results in instances
18723 being allocated that are smaller than the new code expects, and may result in the new instance
18724 variables sharing the same memory space as any instance variables that the subclass defines.
18726 We can avoid this problem by having the class contain only a single member that acts as a pointer
18727 to a heap-allocated structure that acts as storage for the real instance variables. This makes
18728 us free to add instance variables in the future without risk of changing the size of the class.
18729 To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
18730 are able to run against older versions of WebKit we pad the class out to its previous size. This
18731 results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
18732 with both versions of the code.
18734 This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
18735 instance variables of its superclass. However, this is a private header and no known subclasses
18736 of WebDynamicScrollBarsView access superclass instance variables in this fashion.
18738 * WebView/WebDynamicScrollBarsView.h:
18739 * WebView/WebDynamicScrollBarsView.mm:
18740 (-[WebDynamicScrollBarsView initWithFrame:]):
18741 (-[WebDynamicScrollBarsView dealloc]):
18742 (-[WebDynamicScrollBarsView finalize]):
18743 (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
18744 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
18745 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
18746 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
18747 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
18748 (-[WebDynamicScrollBarsView verticalScrollingAllowed]):
18749 (-[WebDynamicScrollBarsView contentViewFrame]):
18750 (-[WebDynamicScrollBarsView tile]):
18751 (-[WebDynamicScrollBarsView setSuppressLayout:]):
18752 (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
18753 (-[WebDynamicScrollBarsView updateScrollers]):
18754 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
18755 (-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
18756 (-[WebDynamicScrollBarsView allowsVerticalScrolling]):
18757 (-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
18758 (-[WebDynamicScrollBarsView horizontalScrollingMode]):
18759 (-[WebDynamicScrollBarsView verticalScrollingMode]):
18760 (-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
18761 (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
18762 (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
18763 (-[WebDynamicScrollBarsView setScrollingModesLocked:]):
18764 (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
18765 (-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
18766 (-[WebDynamicScrollBarsView scrollWheel:]):
18768 2010-04-07 David Hyatt <hyatt@apple.com>
18770 Reviewed by Oliver Hunt.
18772 https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS
18774 Add SPI so that layout tests can access computed style including :visited information.
18776 * WebView/WebRenderNode.mm:
18778 * WebView/WebView.mm:
18779 (-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
18780 * WebView/WebViewInternal.h:
18781 * WebView/WebViewPrivate.h:
18783 2010-04-07 Dan Bernstein <mitz@apple.com>
18785 Reviewed by Adele Peterson.
18787 Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
18788 https://bugs.webkit.org/show_bug.cgi?id=37246
18790 * Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
18791 * Misc/WebNSPrintOperationExtras.m:
18792 (-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
18794 (-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
18796 * WebView/WebHTMLView.mm:
18797 (-[WebHTMLView _isInPrintMode]): Added this accessor.
18798 (-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
18799 computes the layout widths and enters printing mode into this private method.
18800 (-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
18801 (-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
18802 (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
18804 (-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
18805 (-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
18806 -[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
18808 (-[WebHTMLView beginDocument]): Updated for rename.
18809 (-[WebHTMLView endDocument]): Ditto.
18810 * WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,
18811 -_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.
18813 2010-04-07 Andrey Kosyakov <caseq@chromium.org>
18815 Reviewed by Yury Semikhatsky.
18817 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
18818 https://bugs.webkit.org/show_bug.cgi?id=36949
18820 * WebCoreSupport/WebFrameLoaderClient.h:
18821 * WebCoreSupport/WebFrameLoaderClient.mm:
18823 2010-04-06 Dan Bernstein <mitz@apple.com>
18825 Tiger build fix after r57184.
18827 * WebView/WebHTMLViewPrivate.h:
18829 2010-04-06 Dan Bernstein <mitz@apple.com>
18831 Tiger build fix after r57184.
18833 * WebView/WebHTMLViewPrivate.h:
18835 2010-04-06 Adam Barth <abarth@webkit.org>
18839 Speculative build fix for Tiger.
18841 * WebView/WebHTMLViewPrivate.h:
18843 2010-04-06 Dan Bernstein <mitz@apple.com>
18845 Reviewed by Sam Weinig and Anders Carlsson.
18847 Expose WebHTMLView’s page breaking logic as SPI.
18849 * WebView/WebHTMLView.mm:
18850 (-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
18851 (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:
18852 * WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:
18854 2010-04-06 Mark Rowe <mrowe@apple.com>
18856 Add an #if in order to make Tiger happy.
18858 * WebView/WebViewData.mm:
18859 (-[WebViewPrivate init]):
18861 2010-04-06 Mark Rowe <mrowe@apple.com>
18865 * WebView/WebViewData.mm:
18866 (-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.
18868 2010-04-05 Mark Rowe <mrowe@apple.com>
18870 Reviewed by Adele Peterson.
18872 Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
18873 REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI
18875 * WebView/WebHTMLView.mm:
18876 (-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
18877 manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.
18879 2010-04-05 Alexey Proskuryakov <ap@apple.com>
18881 Reviewed by Darin Adler.
18883 https://bugs.webkit.org/show_bug.cgi?id=37111
18884 <rdar://problem/7790327> Draw replacement text when plug-in host crashes
18886 * Plugins/Hosted/WebHostedNetscapePluginView.h: Removed _pluginDied - it was only used
18887 for drawing replacement icon, and this information is now in WebCore.
18888 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
18889 (-[WebHostedNetscapePluginView pluginHostDied]): Tell RenderEmbeddedObject that the plug-in
18891 (-[WebHostedNetscapePluginView drawRect:]): Removed the case for crashed plug-in host. It is
18892 handled by WebCore now.
18894 * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory crashedPluginText]): Added a string
18895 for plug-in failure.
18897 2010-04-03 yael aharon <yael.aharon@nokia.com>
18899 Reviewed by Darin Adler.
18901 Enable HTMLProgressElement for Safari on OSX
18902 https://bugs.webkit.org/show_bug.cgi?id=36961
18904 * Configurations/FeatureDefines.xcconfig:
18906 2010-04-02 Jer Noble <jer.noble@apple.com>
18908 Reviewed by Eric Carlson.
18910 https://bugs.webkit.org/show_bug.cgi?id=36624
18911 Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.
18913 * WebCoreSupport/WebSystemInterface.m:
18914 (InitWebCoreSystemInterface):
18916 2010-04-02 Alexey Proskuryakov <ap@apple.com>
18918 Reviewed by Darin Adler.
18920 https://bugs.webkit.org/show_bug.cgi?id=37043
18921 Java regression tests spam stderr about being unable to set status message
18923 With this change, there is still spam about "Attempt to access JavaScript from destroyed
18924 applet, type 9." I haven't investigated if that indicates a problem or not.
18926 * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]):
18927 Removed check for _documentView. We don't seem to care.
18929 2010-04-01 Kinuko Yasuda <kinuko@chromium.org>
18931 Reviewed by Dmitry Titov.
18933 Add FileThread for async file operation support in FileReader and FileWriter
18934 https://bugs.webkit.org/show_bug.cgi?id=36896
18936 Add FILE_READER or FILE_WRITER feature defines.
18938 * Configurations/FeatureDefines.xcconfig:
18940 2010-04-01 Ada Chan <adachan@apple.com>
18942 Reviewed by Darin Adler.
18944 Change WebDatabaseManager::deleteOrigin() to return true if there are no errors in deleting the origin.
18945 Ditto for WebDatabaseManager::deleteDatabase().
18947 https://bugs.webkit.org/show_bug.cgi?id=36988
18949 * Storage/WebDatabaseManager.mm:
18950 (-[WebDatabaseManager deleteOrigin:]):
18951 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
18952 * Storage/WebDatabaseManagerPrivate.h:
18954 2010-04-01 Alexey Proskuryakov <ap@apple.com>
18956 Reviewed by Darin Adler.
18958 https://bugs.webkit.org/show_bug.cgi?id=36976
18959 <rdar://problem/7817498>
18960 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
18962 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18963 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): The HashTable assertions aren't
18964 there to catch potential future attempts to store empty/deleted values before these happen -
18965 it's actually wrong to try to look up these values. Added an early return.
18966 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Ditto.
18968 2010-04-01 Chris Marrin <cmarrin@apple.com>
18970 Reviewed by Simon Fraser.
18972 Added layerTreeAsText function to DRT (for Mac)
18973 https://bugs.webkit.org/show_bug.cgi?id=36782
18975 This is the WebKit side for Mac. It plumbs the
18976 call from WebCore to DRT.
18978 * WebView/WebFrame.mm:WebKit (Mac) side of plumbing
18979 (-[WebFrame _layerTreeAsText]):
18980 * WebView/WebFramePrivate.h:
18982 2010-04-01 Alexey Proskuryakov <ap@apple.com>
18984 Reviewed by Oliver Hunt.
18986 https://bugs.webkit.org/show_bug.cgi?id=36976
18987 <rdar://problem/7817498>
18988 REGRESSION(r54783): Silverlight plug-in causes Safari to crash if JavaScript is disabled
18990 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
18991 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Use find() instead of get(),
18992 because the latter fails with an assertion when looking up 0 or -1.
18993 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Be prepared for unexpected
18994 object IDs coming from plug-in host.
18996 2010-03-31 Chris Fleizach <cfleizach@apple.com>
18998 Reviewed by Darin Adler.
19000 Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
19001 https://bugs.webkit.org/show_bug.cgi?id=36845
19003 Provide a way through WebKit to set an accessible label that describes the web area.
19005 * WebView/WebFrame.mm:
19006 (-[WebFrame setAccessibleName:]):
19007 * WebView/WebFramePrivate.h:
19009 2010-03-31 Marcus Bulach <bulach@chromium.org>
19011 Reviewed by Jeremy Orlow.
19013 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
19014 https://bugs.webkit.org/show_bug.cgi?id=35031
19016 * WebCoreSupport/WebChromeClient.h:
19017 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
19019 2010-03-30 Gavin Barraclough <barraclough@apple.com>
19021 Rubber stamped by Sam Weinig.
19023 https://bugs.webkit.org/show_bug.cgi?id=36866
19024 Move CString to WTF
19026 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19027 (WebKit::NetscapePluginInstanceProxy::getCookies):
19028 (WebKit::NetscapePluginInstanceProxy::getProxy):
19029 (WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo):
19030 (WebKit::NetscapePluginInstanceProxy::resolveURL):
19031 * Plugins/WebBaseNetscapePluginView.h:
19032 * Plugins/WebBaseNetscapePluginView.mm:
19033 * Plugins/WebNetscapePluginView.mm:
19034 (-[WebNetscapePluginView resolveURL:forTarget:]):
19036 2010-03-30 John Sullivan <sullivan@apple.com>
19038 Reviewed by Dan Bernstein.
19040 https://bugs.webkit.org/show_bug.cgi?id=36848
19041 <rdar://problem/7362913>
19042 Menu items appropriate only for rich-content editing can appear in plain-text contexts
19044 * WebView/WebHTMLView.mm:
19045 (-[WebHTMLView validRequestorForSendType:returnType:]):
19046 Don't return self for non-string content if _canEditRichly is false.
19048 2010-03-29 Alexey Proskuryakov <ap@apple.com>
19050 Reviewed by Darin Adler.
19052 https://bugs.webkit.org/show_bug.cgi?id=36791
19053 Add assertions for instance proxy validity
19055 Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw
19056 pointer to one across complicated function calls, relying on the caller to protect the
19059 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
19060 (WebKit::NetscapePluginInstanceProxy::renderContextID):
19061 (WebKit::NetscapePluginInstanceProxy::pluginView):
19062 (WebKit::NetscapePluginInstanceProxy::hostProxy):
19064 2010-03-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
19066 Reviewed by David Kilzer.
19068 Explicit guards for ENABLE_GEOLOCATION
19069 https://bugs.webkit.org/show_bug.cgi?id=25756
19071 * WebCoreSupport/WebGeolocationMock.mm:
19072 (-[WebGeolocationMock setError:code:]): Make the body conditional on
19073 ENABLE(GEOLOCATION)
19074 (-[WebGeolocationMock setPosition:]): Ditto.
19076 2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
19078 Reviewed by Antti Koivisto.
19080 Change method name due to it dealing with both flattening
19081 of frame sets and inner frames.
19083 * WebView/WebPreferenceKeysPrivate.h:
19084 * WebView/WebPreferences.mm:
19085 (+[WebPreferences initialize]):
19086 (-[WebPreferences isFrameFlatteningEnabled]):
19087 (-[WebPreferences setFrameFlatteningEnabled:]):
19088 * WebView/WebPreferencesPrivate.h:
19089 * WebView/WebView.mm:
19090 (-[WebView _preferencesChangedNotification:]):
19092 2010-03-27 Darin Adler <darin@apple.com>
19094 * Misc/WebNSFileManagerExtras.m:
19095 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
19096 Removed stray "!". How did that get in there?
19098 2010-03-27 Darin Adler <darin@apple.com>
19100 Reviewed by Mark Rowe.
19102 WebKit NSFileManager methods don't handle broken symlinks correctly.
19103 Part of <rdar://problem/7574046>.
19105 * Misc/WebNSFileManagerExtras.h: Removed unused defines and methods.
19106 * Misc/WebNSFileManagerExtras.m: Removed unused methods.
19107 (fileExists): Added. For use instead of fileExistsAtPath: for cases where we'd like
19108 to treat a broken symlink as a file that does indeed exist.
19109 (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use fileExists.
19111 2010-03-25 Alexey Proskuryakov <ap@apple.com>
19113 Reviewed by Mark Rowe.
19115 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in
19116 a way that works in a function that doesn't have a pluginID argument for some reason.
19118 2010-03-25 Simon Fraser <simon.fraser@apple.com>
19120 Build fix: no review.
19122 Another c_str() -> data().
19124 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19125 (WebKit::NetscapePluginInstanceProxy::enumerate):
19127 2010-03-25 Alexey Proskuryakov <ap@apple.com>
19129 Reviewed by Mark Rowe.
19131 Correctness fix after r56493.
19133 * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update
19134 our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees
19135 that the host proxy won't go away while the open panel is up.
19137 2010-03-24 Mark Rowe <mrowe@apple.com>
19139 Build fix after r56474.
19141 * Plugins/Hosted/NetscapePluginHostProxy.mm:
19142 (WKPCRunSyncOpenPanel):
19144 2010-03-24 Alexey Proskuryakov <ap@apple.com>
19146 Reviewed by Anders Carlsson.
19148 https://bugs.webkit.org/show_bug.cgi?id=36563
19149 A plug-in makes Safari crash on http://www.itscodingtime.com/
19151 * Plugins/Hosted/NetscapePluginHostProxy.h:
19152 (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't
19153 beautifully systemic, but helped catch a bug, and may help catch more.
19154 (WebKit::NetscapePluginHostProxy::clientPort): Ditto.
19155 (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a
19156 static. This doesn't change behavior much, but helps avoid writing into deallocated memory.
19158 * Plugins/Hosted/NetscapePluginHostProxy.mm:
19159 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests
19161 (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests
19162 after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there
19163 wasn't much time for some other object to be allocated at this address.
19164 (WKPCEvaluate): Refetch host proxy, as it may have been destroyed.
19165 (WKPCInvoke): Ditto.
19166 (WKPCInvokeDefault): Ditto.
19167 (WKPCGetProperty): Ditto.
19168 (WKPCSetProperty): Ditto.
19169 (WKPCRemoveProperty): Ditto.
19170 (WKPCHasProperty): Ditto.
19171 (WKPCHasMethod): Ditto.
19172 (WKPCEnumerate): Ditto.
19173 (WKPCRunSyncOpenPanel): Ditto.
19175 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19176 (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the
19177 "event loop" if host proxy went away while processing a request.
19179 2010-03-24 Hayato Ito <hayato@chromium.org>
19181 Reviewed by Shinichiro Hamaji.
19183 Refactor computePageRects so that Mac can make use of it.
19184 https://bugs.webkit.org/show_bug.cgi?id=36159
19186 Refactoring only, so no new tests.
19188 * WebView/WebFrame.mm:
19189 (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):
19191 2010-03-24 Kent Tamura <tkent@chromium.org>
19193 Reviewed by Darin Adler.
19195 Make Icon::createIconForFiles() optional.
19196 https://bugs.webkit.org/show_bug.cgi?id=35072
19198 - Rename iconForFiles() to chooseIconForFiles().
19199 - Call Icon::createIconForFiles() from chooseIconForFiles().
19201 * WebCoreSupport/WebChromeClient.h:
19202 * WebCoreSupport/WebChromeClient.mm:
19203 (WebChromeClient::chooseIconForFiles):
19205 2010-03-23 Dan Bernstein <mitz@apple.com>
19207 Reverted accidental change from r56429.
19209 * WebCoreSupport/WebContextMenuClient.mm:
19210 (WebContextMenuClient::getCustomMenuFromDefaultItems):
19212 2010-03-23 Dan Bernstein <mitz@apple.com>
19214 Reviewed by John Sullivan.
19217 <rdar://problem/7197736> Plug-in clip rect does not update when overflow
19219 https://bugs.webkit.org/show_bug.cgi?id=36479.
19221 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
19222 (-[WebHostedNetscapePluginView visibleRectDidChange]): Added. Calls
19223 WKSyncSurfaceToView().
19224 * Plugins/WebBaseNetscapePluginView.h:
19225 * Plugins/WebBaseNetscapePluginView.mm:
19226 (-[WebBaseNetscapePluginView _windowClipRect]): Changed to use Widget::windowClipRect().
19227 (-[WebBaseNetscapePluginView visibleRectDidChange]): Added. Invokes -renewGState.
19229 2010-03-22 Kevin Decker <kdecker@apple.com>
19231 Reviewed by Simon Fraser.
19233 https://bugs.webkit.org/show_bug.cgi?id=36328
19235 This patch entirely WebNullPluginView.
19237 * Plugins/WebNetscapePluginView.mm:
19238 * Plugins/WebNullPluginView.h: Removed.
19239 * Plugins/WebNullPluginView.mm: Removed.
19240 * Resources/nullplugin.tiff: Removed.
19241 * WebCoreSupport/WebFrameLoaderClient.mm:
19242 (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
19244 2010-03-22 Alexey Proskuryakov <ap@apple.com>
19246 Reviewed by John Sullivan.
19248 https://bugs.webkit.org/show_bug.cgi?id=36455
19249 Make WebKit more resistant against plug-in crashes
19251 No tests, because crashing on build bots isn't good, even if it's only helper processes
19254 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
19255 (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function
19256 needs it after waiting for reply. Some callers used to do this, but not all, and we really
19257 shouldn't depend on callers here.
19259 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19260 (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy,
19261 because this function doesn't use it after waiting for reply.
19262 (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.
19264 * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy
19265 null check for another code path.
19267 2010-03-22 Kevin Decker <kdecker@apple.com>
19269 Reviewed by John Sullivan.
19271 https://bugs.webkit.org/show_bug.cgi?id=36328
19273 * WebCoreSupport/WebViewFactory.mm:
19274 (-[WebViewFactory missingPluginText]): Added.
19276 2010-03-18 Alexey Proskuryakov <ap@apple.com>
19278 Reviewed by Darin Adler.
19280 https://bugs.webkit.org/show_bug.cgi?id=36337
19281 Log an error when an OOP plug-in sends an unknown object id
19283 Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look
19284 temporary or redundant.
19286 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19287 (WebKit::NetscapePluginInstanceProxy::evaluate):
19288 (WebKit::NetscapePluginInstanceProxy::invoke):
19289 (WebKit::NetscapePluginInstanceProxy::invokeDefault):
19290 (WebKit::NetscapePluginInstanceProxy::construct):
19291 (WebKit::NetscapePluginInstanceProxy::getProperty):
19292 (WebKit::NetscapePluginInstanceProxy::setProperty):
19293 (WebKit::NetscapePluginInstanceProxy::removeProperty):
19294 (WebKit::NetscapePluginInstanceProxy::hasProperty):
19295 (WebKit::NetscapePluginInstanceProxy::hasMethod):
19296 (WebKit::NetscapePluginInstanceProxy::enumerate):
19298 2010-03-16 Alexey Proskuryakov <ap@apple.com>
19300 Reviewed by Darin Adler.
19302 https://bugs.webkit.org/show_bug.cgi?id=36184
19303 YouTube video resizing doesn't work with OOP plug-ins
19305 Test: plugins/resize-from-plugin.html
19307 We were calling _WKPHResizePluginInstance synchronously or asynchronously, depending on
19308 whether the size has changed. But sync and async messages are not necessarily delivered in
19309 order - plug-in host listens only to the former while waiting for a response to a message it
19310 sent (a call to invoke() in this case).
19312 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
19313 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19314 (WebKit::NetscapePluginInstanceProxy::resize):
19315 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
19316 (-[WebHostedNetscapePluginView updateAndSetWindow]):
19318 2010-03-16 Yury Semikhatsky <yurys@chromium.org>
19320 Reviewed by Pavel Feldman.
19322 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
19324 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
19325 https://bugs.webkit.org/show_bug.cgi?id=35036
19327 * WebCoreSupport/WebInspectorClient.h:
19328 * WebCoreSupport/WebInspectorClient.mm:
19329 (WebInspectorClient::WebInspectorClient):
19330 (WebInspectorClient::inspectorDestroyed):
19331 (WebInspectorClient::openInspectorFrontend):
19332 (WebInspectorClient::highlight):
19333 (WebInspectorClient::hideHighlight):
19334 (WebInspectorFrontendClient::WebInspectorFrontendClient):
19335 (WebInspectorFrontendClient::frontendLoaded):
19336 (WebInspectorFrontendClient::localizedStringsURL):
19337 (WebInspectorFrontendClient::hiddenPanels):
19338 (WebInspectorFrontendClient::bringToFront):
19339 (WebInspectorFrontendClient::closeWindow):
19340 (WebInspectorFrontendClient::attachWindow):
19341 (WebInspectorFrontendClient::detachWindow):
19342 (WebInspectorFrontendClient::setAttachedWindowHeight):
19343 (WebInspectorFrontendClient::inspectedURLChanged):
19344 (WebInspectorFrontendClient::updateWindowTitle):
19345 (-[WebInspectorWindowController dealloc]):
19346 (-[WebInspectorWindowController windowShouldClose:]):
19347 (-[WebInspectorWindowController close]):
19348 (-[WebInspectorWindowController showWindow:]):
19349 (-[WebInspectorWindowController attach]):
19350 (-[WebInspectorWindowController detach]):
19351 (-[WebInspectorWindowController attached]):
19352 (-[WebInspectorWindowController setFrontendClient:]):
19353 (-[WebInspectorWindowController destroyInspectorView]):
19354 (-[WebNodeHighlighter initWithInspectedWebView:]):
19355 (-[WebNodeHighlighter dealloc]):
19356 (-[WebNodeHighlighter highlightNode:]):
19357 (-[WebNodeHighlighter hideHighlight]):
19358 (-[WebNodeHighlighter didAttachWebNodeHighlight:]):
19359 (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
19360 * WebInspector/WebInspector.mm:
19361 (-[WebInspector attach:]):
19362 (-[WebInspector detach:]):
19364 2010-03-15 Andy Estes <aestes@apple.com>
19366 Reviewed by John Sullivan.
19368 Updated call to WKGetWheelEventDeltas() to match new method signature.
19370 https://bugs.webkit.org/show_bug.cgi?id=29601
19371 <rdar://problem/7453254>
19373 * WebView/WebDynamicScrollBarsView.mm:
19374 (-[WebDynamicScrollBarsView scrollWheel:]):
19376 2010-03-15 John Sullivan <sullivan@apple.com>
19378 Reviewed by Adam Roben.
19380 -[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
19381 <https://bugs.webkit.org/show_bug.cgi?id=36125>
19383 * WebView/WebDynamicScrollBarsView.h:
19384 Added instance variables horizontalScrollingAllowedButScrollerHidden and
19385 verticalScrollingAllowedButScrollerHidden. Renamed instance variables
19386 hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity.
19387 Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed.
19390 * WebView/WebDynamicScrollBarsView.mm:
19391 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
19392 Updated for instance variable renaming.
19393 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
19395 (-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
19396 New method, returns YES if the scroller is showing or the only reason that the scroller
19397 is not showing is that setAlwaysHideHorizontalScrolling has been called.
19398 (-[WebDynamicScrollBarsView verticalScrollingAllowed]):
19399 New method, returns YES if the scroller is showing or the only reason that the scroller
19400 is not showing is that setAlwaysHideVerticalScrolling has been called.
19401 (-[WebDynamicScrollBarsView updateScrollers]):
19402 Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden
19403 and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account
19404 in the early-return code path, to avoid taking it into account twice in the regular code path.
19406 * WebView/WebFrameView.mm:
19407 (-[WebFrameView _scrollToBeginningOfDocument]):
19408 Use _isScrollable instead of _hasScrollBars.
19409 (-[WebFrameView _scrollToEndOfDocument]):
19411 (-[WebFrameView scrollToBeginningOfDocument:]):
19412 Use _largestScrollableChild instead of _largestChildWithScrollBars.
19413 (-[WebFrameView scrollToEndOfDocument:]):
19415 (-[WebFrameView _pageVertically:]):
19416 Use _isScrollable and _largestScrollableChild instead of _hasScrollBars
19417 and _largestChildWithScrollBars.
19418 (-[WebFrameView _pageHorizontally:]):
19420 (-[WebFrameView _scrollLineVertically:]):
19422 (-[WebFrameView _scrollLineHorizontally:]):
19424 (-[WebFrameView keyDown:]):
19425 Use _largestScrollableChild instead of _largestChildWithScrollBars.
19426 (-[WebFrameView _isScrollable]):
19427 New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and
19428 -[WebDynamicScrollBarsView verticalScrollingAllowed]
19429 (-[WebFrameView _largestScrollableChild]):
19430 New method, like _largestChildWithScrollBars but uses _isScrollable.
19431 (-[WebFrameView _hasScrollBars]):
19432 Added a comment that this is no longer used by Safari, and can thus probably be
19433 deleted once we no longer want to support it for nightly build compatibility with
19434 old versions of Safari.
19435 (-[WebFrameView _largestChildWithScrollBars]):
19438 * WebView/WebFrameViewPrivate.h:
19439 Declared -_isScrollable and -_largestScrollableChild. Added comments to
19440 _hasScrollBars and _largestChildWithScrollBars saying that they are no longer
19441 used by Safari, and can thus probably be deleted once we no longer want to
19442 support them for nightly build compatibility with old versions of Safari.
19444 2010-03-15 John Sullivan <sullivan@apple.com>
19446 Method name and parameter name mistakes from recent SPI addition
19447 <https://bugs.webkit.org/show_bug.cgi?id=36119>
19449 Reviewed by Dan Bernstein.
19451 * WebView/WebDynamicScrollBarsView.h:
19452 Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX".
19454 * WebView/WebDynamicScrollBarsView.mm:
19455 (-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
19456 Updated for renamed instance variable and method.
19457 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
19458 Changed parameter name from shouldBeVisible to shouldBeHidden.
19459 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
19461 (-[WebDynamicScrollBarsView contentViewFrame]):
19462 Updated for renamed instance variable.
19463 (-[WebDynamicScrollBarsView tile]):
19465 (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
19468 * WebView/WebFrame.mm:
19469 (-[WebFrame setAllowsScrollersToOverlapContent:]):
19470 Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView.
19472 * WebView/WebFramePrivate.h:
19473 Renamed method name from "setAllowXXX" to "setAllowsXXX".
19475 2010-03-14 Darin Adler <darin@apple.com>
19477 Reviewed by Mark Rowe.
19479 Remove unneeded dependency on non-string identifier for an NSTableColumn
19480 https://bugs.webkit.org/show_bug.cgi?id=36106
19482 * WebView/WebTextCompletionController.mm:
19483 (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier:
19484 because the table has only one column and that column does not need an identifier.
19486 2010-03-12 Beth Dakin <bdakin@apple.com>
19488 Reviewed by Simon Fraser.
19490 Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
19491 API naming is inconsistent
19492 -and corresponding-
19493 <rdar://problem/7729165>
19495 This patch changes all occurrences of "fullScreen" to the more
19496 popular "fullscreen."
19498 * Plugins/Hosted/NetscapePluginHostProxy.h:
19499 (WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):
19500 * Plugins/Hosted/NetscapePluginHostProxy.mm:
19501 (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
19502 (WebKit::NetscapePluginHostProxy::didEnterFullscreen):
19503 (WebKit::NetscapePluginHostProxy::didExitFullscreen):
19504 (WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
19505 (WKPCSetFullscreenWindowIsShowing):
19506 * Plugins/Hosted/WebKitPluginClient.defs:
19507 * Plugins/WebNetscapePluginView.mm:
19508 (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
19509 (-[WebNetscapePluginView _createPlugin]):
19510 (-[WebNetscapePluginView _destroyPlugin]):
19511 * WebView/WebVideoFullscreenHUDWindowController.mm:
19512 (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
19514 2010-03-12 Andy Estes <aestes@apple.com>
19516 Reviewed by Brady Eidson.
19518 Expose WebPDFView's underlying PDFDocument.
19520 https://bugs.webkit.org/show_bug.cgi?id=36045
19522 * WebView/WebDocumentPrivate.h: Create a new protocol called
19524 * WebView/WebPDFView.h: Have WebPDFView implement said protocol.
19525 * WebView/WebPDFView.mm:
19526 (-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
19527 PDFDocument by implementing -(PDFDocument*)PDFDocument from
19530 2010-03-12 Andy Estes <aestes@apple.com>
19532 Reviewed by Brady Eidson.
19534 Remove an unused method.
19536 https://bugs.webkit.org/show_bug.cgi?id=35940
19538 * Plugins/WebPluginController.mm:
19539 removed - (void)showURL:(NSURL *) inFrame:(NSString *)
19541 2010-03-11 Mark Rowe <mrowe@apple.com>
19543 Reviewed by David Kilzer.
19545 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
19547 Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
19549 * Configurations/Base.xcconfig:
19551 2010-03-11 Mark Rowe <mrowe@apple.com>
19553 Reviewed by Tim Hatcher.
19555 <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
19557 Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
19558 current Mac OS X version unless otherwise specified.
19560 Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
19562 Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
19563 may not be usable when targetting a different Mac OS X version.
19565 Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
19566 MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
19568 * Configurations/Base.xcconfig:
19569 * Configurations/DebugRelease.xcconfig:
19570 * Configurations/FeatureDefines.xcconfig:
19571 * Configurations/Version.xcconfig:
19573 2010-03-11 Anders Carlsson <andersca@apple.com>
19575 Reviewed by David Hyatt.
19577 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
19579 * WebCoreSupport/WebChromeClient.h:
19580 * WebCoreSupport/WebChromeClient.mm:
19582 2010-03-11 Alexey Proskuryakov <ap@apple.com>
19584 Reviewed by Geoff Garen.
19586 https://bugs.webkit.org/show_bug.cgi?id=35965
19587 <rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in
19589 Test: plugins/round-trip-npobject.html
19591 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19592 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is
19593 now a separate ProxyRuntimeObject class for proxy pbjects.
19594 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
19596 * Plugins/Hosted/ProxyInstance.mm:
19597 (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in
19598 could have crashed while we were waiting for response.
19599 (WebKit::ProxyInstance::setFieldValue): Ditto.
19601 2010-03-10 Simon Fraser <simon.fraser@apple.com>
19603 Reviewed by Darin Adler.
19605 https://bugs.webkit.org/show_bug.cgi?id=35975
19606 <rdar://problem/7739922> Flash 10.1b crashes when generating snapshots
19608 Do a version check before sending a drawRect event to a Flash plugin,
19609 since 10.1.d51 has a bug that crashes when called this way.
19611 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
19612 (-[WebHostedNetscapePluginView drawRect:]):
19613 * Plugins/WebBaseNetscapePluginView.h:
19614 * Plugins/WebBaseNetscapePluginView.mm:
19615 (-[WebBaseNetscapePluginView supportsSnapshotting]):
19616 * Plugins/WebNetscapePluginView.mm:
19617 (-[WebNetscapePluginView drawRect:]):
19619 2010-03-10 John Sullivan <sullivan@apple.com>
19621 Reviewed by Tim Hatcher.
19623 <rdar://problem/7735387> input type other than text won't work with autofill
19624 <https://bugs.webkit.org/show_bug.cgi?id=35963>
19626 * WebView/WebHTMLRepresentation.mm:
19627 (-[WebHTMLRepresentation elementDoesAutoComplete:]):
19628 Return true for any text field that's not a password, rather than only
19631 2010-03-09 Brady Eidson <beidson@apple.com>
19633 Reviewed by Tim Hatcher.
19635 REGRESSION: WebInspector docking busted on Windows
19636 <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
19638 * WebCoreSupport/WebInspectorClient.mm:
19639 (-[WebInspectorWindowController showWindow:]): Use the InspectorController:: copy of the should attach settings key.
19640 (-[WebInspectorWindowController attach]): Ditto.
19641 (-[WebInspectorWindowController detach]): Ditto.
19643 2010-03-09 Geoffrey Garen <ggaren@apple.com>
19645 Reviewed by Darin Adler.
19647 Updated for FastMalloc reporting changes.
19649 * Misc/WebCoreStatistics.mm:
19650 (+[WebCoreStatistics memoryStatistics]):
19652 2010-03-08 Simon Fraser <simon.fraser@apple.com>
19654 Reviewed by Mark Rowe.
19656 Move the new method to the end of the MIG definitions file, to avoid breaking
19657 compatibility between WebKit and older versions of WebKitPluginHost.
19659 * Plugins/Hosted/WebKitPluginHost.defs:
19661 2010-03-08 Simon Fraser <simon.fraser@apple.com>
19663 Reviewed by Kevin Decker.
19665 <rdar://problem/7714340> Need to grab image snapshot of Core Animation plugins
19667 Allow plug-ins using the Core Animation drawing model to be captured when doing a flattening paint,
19668 by sending them a drawRect event as if they were software-painting.
19670 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
19671 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19672 (WebKit::NetscapePluginInstanceProxy::snapshot):
19673 New snapshot() method that calls over to the plugin host, and then draws the image that comes back.
19675 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
19676 (-[WebHostedNetscapePluginView drawRect:]): If we don't have a software renderer, but we're doing
19677 a flattening paint, then call the snapshot method.
19679 * Plugins/Hosted/WebKitPluginHost.defs: Added snapshot method.
19681 * Plugins/WebBaseNetscapePluginView.h:
19682 * Plugins/WebBaseNetscapePluginView.mm:
19683 (-[WebBaseNetscapePluginView inFlatteningPaint]):
19684 New utility method that asks the FrameView whether the current paint behavior is
19687 * Plugins/WebNetscapePluginView.mm:
19688 (-[WebNetscapePluginView drawRect:]): If the plug-in is using CA but this is a flattening
19689 paint, go ahead and send a drawRect event to the plug-in.
19691 2010-03-08 Darin Adler <darin@apple.com>
19693 Reviewed by Dan Bernstein.
19695 Fix crash when you quit inside an unload handler.
19696 rdar://problem/6958347
19698 Test: manual-tests/quit-inside-unload.html
19700 * WebView/WebView.mm:
19701 (-[WebView _closeWithFastTeardown]): Removed code to set
19702 _private->closed since _close now does this earlier, before
19703 calling this method.
19704 (-[WebView _close]): Moved code to set _private->closed to the
19705 top of this method.
19706 (-[WebView setHostWindow:]): Rewrote the code that forbade
19707 setting the host window after closing so that it only forbids
19708 non-nil host windows. That way, the code to clear away the host
19709 window can run safely after setting _private->closed, yet client
19710 code cannot set a new host window after closing.
19712 2010-03-08 Darin Adler <darin@apple.com>
19714 Roll out a file I checked in by accident.
19716 * WebView/WebView.mm: Back to previous version.
19718 2010-03-08 Chris Marrin <cmarrin@apple.com>
19720 Reviewed by Darin Adler.
19722 Turn on HW accel on Leopard even if coreVideoHas7228836Fix() is false, when WebGL is enabled
19723 https://bugs.webkit.org/show_bug.cgi?id=35759
19725 This allows WebGL to work on Leopard without the fix. It exposes these users to the crash
19726 that happens because of the CoreVideo bug, but it limits the exposure to those who have
19727 chosen to enable WebGL.
19729 * WebView/WebView.mm:
19730 (-[WebView _preferencesChangedNotification:]):
19732 2010-03-02 Adam Treat <atreat@rim.com>
19734 Reviewed by Dave Hyatt.
19736 Adapt the mac port to the refactoring of repaint methods.
19738 https://bugs.webkit.org/show_bug.cgi?id=34214
19740 * WebCoreSupport/WebChromeClient.h:
19741 * WebCoreSupport/WebChromeClient.mm:
19742 (WebChromeClient::invalidateContents):
19743 (WebChromeClient::invalidateWindow):
19744 (WebChromeClient::invalidateContentsAndWindow):
19745 (WebChromeClient::invalidateContentsForSlowScroll):
19747 2010-03-08 Jian Li <jianli@chromium.org>
19749 Reviewed by Dmitry Titov.
19751 Blob.slice support.
19752 https://bugs.webkit.org/show_bug.cgi?id=32993
19754 Add ENABLE_BLOB_SLICE feature define.
19756 * Configurations/FeatureDefines.xcconfig:
19758 2010-03-08 Eric Uhrhane <ericu@chromium.org>
19760 Reviewed by David Levin.
19762 Remove the now-redundant Settings fields for the Database
19763 https://bugs.webkit.org/show_bug.cgi?id=35763
19765 No new tests; this code isn't called.
19767 * WebView/WebView.mm: Remove the call into Settings.
19768 (-[WebView _preferencesChangedNotification:]):
19770 2010-03-07 Mark Rowe <mrowe@apple.com>
19772 Rubber-stamped by Cameron Zwarich.
19774 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
19776 * Misc/WebIconDatabase.mm:
19778 2010-03-07 Mark Rowe <mrowe@apple.com>
19780 Rubber-stamped by Cameron Zwarich.
19782 Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.
19784 * Misc/WebNSPasteboardExtras.mm:
19786 2010-03-04 Mark Rowe <mrowe@apple.com>
19788 Reviewed by Sam Weinig.
19790 <rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h
19792 * MigrateHeaders.make: Migrate DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h.
19794 2010-03-04 Mark Rowe <mrowe@apple.com>
19796 Reviewed by Sam Weinig.
19798 Use a framework-style include to pull in WebInspector.h for consistency
19799 with other parts of WebKit.
19801 * WebInspector/WebInspectorPrivate.h:
19803 2010-03-04 Brady Eidson <beidson@apple.com>
19805 Reviewed by Geoff Garen.
19807 REGRESSION (31281): -[WebArchive initWithCoder:] leaks
19808 <rdar://problem/7702420> and https://bugs.webkit.org/show_bug.cgi?id=35534
19810 * WebView/WebArchive.mm:
19811 (-[WebArchive initWithCoder:]): Don't retain objects we don't own.
19813 2010-03-03 Alexey Proskuryakov <ap@apple.com>
19815 Reviewed by Timothy Hatcher.
19817 https://bugs.webkit.org/show_bug.cgi?id=35692
19818 <rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView
19820 * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
19821 Retain the challenge, just like it's done for sheet.
19823 2010-03-02 Eric Uhrhane <ericu@chromium.org>
19825 Reviewed by David Levin.
19827 Move database enable bit fully out of settings
19828 This is stage one of a three-stage commit [webkit, then chromium, then
19829 webkit again]. In this change I'm adding calls to
19830 Database::setIsAvailable inside Settings::setDatabaseEnabled and
19831 anywhere else that called it, and switching webkit fully over to using
19832 that flag [added in a previous checkin]. Phase two will remove
19833 Chromium's use of Settings for the Database, and phase three will remove
19834 the Setting for the Database enable entirely, leaving only
19835 Database::isAvailable/setIsAvailable.
19837 No new tests; tested by existing storage tests.
19839 https://bugs.webkit.org/show_bug.cgi?id=35310
19841 * WebView/WebView.mm: Added a call to Database::setIsAvailable.
19842 (-[WebView _preferencesChangedNotification:]):
19844 2010-03-02 Adam Roben <aroben@apple.com>
19846 Add -[WebView _registerURLSchemeAsSecure:]
19848 Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose
19849 SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
19851 Reviewed by Tim Hatcher.
19853 * WebView/WebView.mm:
19854 (+[WebView _registerURLSchemeAsSecure:]):
19855 * WebView/WebViewPrivate.h:
19856 Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
19858 2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
19860 Reviewed by Adam Barth.
19862 Adapt to the new ZoomMode enum.
19863 https://bugs.webkit.org/show_bug.cgi?id=35347
19865 * WebView/WebView.mm:
19866 (-[WebView _preferencesChangedNotification:]):
19867 (-[WebView _setZoomMultiplier:isTextOnly:]):
19868 (-[WebView _realZoomMultiplierIsTextOnly]):
19870 2010-02-27 Jing Jin <jjin@apple.com>
19872 Reviewed by Timothy Hatcher.
19874 Move implementation of Bug 35449 into WebFramePrivate.
19876 * WebView/WebFrame.h:
19877 * WebView/WebFrame.mm:
19878 (-[WebFrame setAllowScrollersToOverlapContent:]):
19879 (-[WebFrame setAlwaysHideHorizontalScroller:]):
19880 (-[WebFrame setAlwaysHideVerticalScroller:]):
19881 * WebView/WebFramePrivate.h:
19883 2010-02-26 Jing Jin <jjin@apple.com>
19885 Reviewed by Timothy Hatcher.
19887 https://bugs.webkit.org/show_bug.cgi?id=35449
19888 Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.
19890 * WebView/WebDynamicScrollBarsView.h:
19891 * WebView/WebDynamicScrollBarsView.mm:
19892 (-[WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]): Allows scrollbars to
19893 overlap with the document and re-layouts the document.
19894 (-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): Hides the horizontal scrollbar.
19895 (-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): Hides the vertical scrollbar.
19896 (-[WebDynamicScrollBarsView contentViewFrame]): Calculates the appropriate frame based
19897 on allowScrollersToOverlapContent.
19898 (-[WebDynamicScrollBarsView tile]): If allowScrollersToOverlapContent is YES, set the
19899 contentView's frame so it overlaps with the scrollbar.
19900 (-[WebDynamicScrollBarsView updateScrollers]): Take into account hideHorizontalScroller
19901 and hideVerticalScroller.
19902 (-[WebDynamicScrollBarsView reflectScrolledClipView:]): set drawsBackground to NO when
19903 scrollbars are overlapping with content, so we don't get trails during scrollbar draw updates.
19904 * WebView/WebDynamicScrollBarsViewInternal.h:
19905 * WebView/WebFrame.h:
19906 * WebView/WebFrame.mm:
19907 (-[WebFrame setAllowScrollersToOverlapContent:]): Hook for [WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]
19908 (-[WebFrame setAlwaysHideHorizontalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]
19909 (-[WebFrame setAlwaysHideVerticalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]
19911 2010-02-26 Gavin Barraclough <barraclough@apple.com>
19913 Reviewed by Alexey Proskuryakov.
19915 Bug 35401 - Fix handling of errors in handling calls over bridge,
19916 where base object bridge-type does not match method bridge-type.
19918 The code assumes users will only attempt to invoke a Java method
19919 on a Java base object, etc.
19920 Add language specific subclasses of RuntimeMethod, and pass the
19921 RuntimeMethod into invokeMethod, so we can typecheck before
19922 casting. Throw an exception on type mismatch.
19924 * Plugins/Hosted/ProxyInstance.h:
19925 * Plugins/Hosted/ProxyInstance.mm:
19926 (WebKit::PluginRuntimeMethod::PluginRuntimeMethod): new class to distinguish this type of RuntimeMethod.
19927 (WebKit::ProxyInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
19928 (WebKit::ProxyInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
19930 2010-02-25 Alexey Proskuryakov <ap@apple.com>
19932 Reviewed by Geoffrey Garen.
19934 https://bugs.webkit.org/show_bug.cgi?id=35394
19935 <rdar://problem/7685262> Make passing objects between Java and plug-ins work
19937 Added a ProxyInstance implementation of RuntimeObject.
19939 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19940 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
19941 * Plugins/Hosted/ProxyInstance.h:
19942 * Plugins/Hosted/ProxyInstance.mm:
19943 (WebKit::ProxyInstance::newRuntimeObject):
19944 (WebKit::ProxyInstance::getClass):
19945 * Plugins/Hosted/ProxyRuntimeObject.h: Added.
19946 (WebKit::ProxyRuntimeObject::classInfo):
19947 * Plugins/Hosted/ProxyRuntimeObject.mm: Added.
19948 (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
19949 (WebKit::ProxyRuntimeObject::~ProxyRuntimeObject):
19950 (WebKit::ProxyRuntimeObject::getInternalProxyInstance):
19952 2010-02-24 Adam Barth <abarth@webkit.org>
19954 Reviewed by Darin Fisher.
19956 [Chromium API] Disambiguate allowJavaScript from didNotAllowScript
19957 https://bugs.webkit.org/show_bug.cgi?id=35205
19959 Make these two callsites explicit about not running script immediately.
19961 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
19962 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
19963 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
19965 2010-02-23 Brady Eidson <beidson@apple.com>
19967 Reviewed by Tim Hatcher and Pavel Feldman.
19969 Regression (r55107) - WebInspector docking is busted.
19970 https://bugs.webkit.org/show_bug.cgi?id=35274
19972 * WebCoreSupport/WebInspectorClient.mm:
19973 (-[WebInspectorWindowController showWindow:]): Swap the order of the "should attach?" check
19974 to get the expected behavior.
19976 2010-02-23 Dan Bernstein <mitz@apple.com>
19978 Reviewed by Simon Fraser.
19980 <rdar://problem/7611158> Incomplete repaint of YouTube timeline thumb while scrolling
19981 https://bugs.webkit.org/show_bug.cgi?id=34381
19983 Test: fast/repaint/repaint-during-scroll.html
19985 NSClipView offsets any rects marked as needing display during scrolling
19986 by the scroll offset. Compensate for this when -setNeedsDisplay: is called
19989 * WebView/WebHTMLView.mm:
19990 (-[WebHTMLView _frameOrBoundsChanged]): Set inScrollPositionChanged to YES
19991 around to call to FrameView::scrollPositionChanged().
19992 (-[WebHTMLView setNeedsDisplayInRect:]): When called beneath
19993 scrollPositionChanged(), adjust the rect by the inverse of the scroll offset.
19995 2010-02-23 Steve Block <steveblock@google.com>
19997 Reviewed by Darin Adler.
19999 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
20000 https://bugs.webkit.org/show_bug.cgi?id=34962
20002 This method is required so that a Geolocation object can cancel an
20003 asynchronous permission request. This allows the chrome client to cancel
20004 any UI it is showing for the permission request.
20006 * WebCoreSupport/WebChromeClient.h:
20007 (WebChromeClient::cancelGeolocationPermissionRequestForFrame):
20009 2010-02-22 Alexey Proskuryakov <ap@apple.com>
20011 Rubber-stamped by Geoff Garen.
20013 Rename RuntimeObjectImp to RuntimeObject.
20015 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
20016 (WebKit::NetscapePluginInstanceProxy::addValueToArray):
20017 (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
20018 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
20020 2010-02-22 Brady Eidson <beidson@apple.com>
20022 Reviewed by Tim Hatcher.
20024 Disable WebView docking to views that are too small.
20025 <rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
20027 * WebCoreSupport/WebInspectorClient.mm:
20028 (-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector
20029 window attached if WebCore says it shouldn't be attached.
20031 2010-02-22 Simon Fraser <simon.fraser@apple.com>
20033 Reviewed by John Sullivan.
20035 <rdar://problem/7285392>
20036 On Leopard, we have to disable hardware acceleration if we detect that the
20037 installed Core Video framework has bug <rdar://problem/7228836>.
20039 * WebView/WebView.mm:
20040 (coreVideoHas7228836Fix):
20041 (-[WebView _preferencesChangedNotification:]):
20043 2010-02-21 Dan Bernstein <mitz@apple.com>
20045 Reviewed by Darin Adler.
20047 False warnings about needing layout in
20048 -[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
20049 https://bugs.webkit.org/show_bug.cgi?id=35218
20051 * WebView/WebHTMLView.mm:
20052 (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
20053 Suppress the warning and the forced layout if the view is not being drawn
20054 in this display operation.
20056 2010-02-21 Kevin Decker <kdecker@apple.com>
20058 Reviewed by Sam Weinig.
20060 plugInViewWithArguments: API sends wrong parameter for WebPlugInBaseURLKey
20061 https://bugs.webkit.org/show_bug.cgi?id=35215
20062 <rdar://problem/7673157>
20064 The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters
20065 is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing
20066 the plug-in's view. Instead of sending the base URL, code in WebFrameLoaderClient::createPlugin
20067 would incorrectly pass the source URL of the plug-in resource.
20069 * WebCoreSupport/WebFrameLoaderClient.mm:
20070 (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the
20071 real base URL for the WebPlugInBaseURLKey key.
20073 2010-02-19 Maciej Stachowiak <mjs@apple.com>
20075 Reviewed by David Levin.
20077 Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
20078 https://bugs.webkit.org/show_bug.cgi?id=35147
20080 * Configurations/FeatureDefines.xcconfig:
20082 2010-02-19 Alexey Proskuryakov <ap@apple.com>
20084 Reviewed by Maciej Stachowiak.
20086 https://bugs.webkit.org/show_bug.cgi?id=35132
20087 <rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)
20089 * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
20090 (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse
20091 move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout
20092 resorting to techniques such as fast firing timers.
20094 * Plugins/WebNetscapePluginView.mm:
20095 (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally,
20096 but those that don't just need to get an arrow cursor (matching Firefox). This means that
20097 e.g. a plugin inside <A> won't get a finger mouse pointer.
20099 * Plugins/WebHostedNetscapePluginView.mm:
20100 (-[WebNetscapePluginView handleMouseEntered:]):
20101 (-[WebNetscapePluginView handleMouseExited:]):
20102 Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on
20103 mouse exit, which it needed to do.
20105 * WebView/WebHTMLView.mm:
20106 (needsCursorRectsSupportAtPoint):
20108 (resetCursorRects):
20109 Make sure that the same workaround we have for Web content also applies to Netscape plug-ins,
20110 as AppKit would reset the mouse pointer to arrow if given a chance.
20111 (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent
20112 confusion - the method we override is completely different.
20113 (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.
20115 2010-02-19 Simon Fraser <simon.fraser@apple.com>
20117 Reviewed by Dan Bernstein.
20119 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
20121 Followup to avoid capturing compositing layers twice in snapshots. Add private
20122 methods to WebView to specify whether drawing the WebView into an image will
20123 include flattened compositing layers (the default behavior) or not.
20125 * WebView/WebFrame.mm:
20126 (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we
20129 * WebView/WebViewPrivate.h: New methods.
20130 * WebView/WebView.mm: Ditto.
20131 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
20132 (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]):
20133 (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):
20135 * WebView/WebViewData.h: New member variable.
20137 2010-02-19 Alexey Proskuryakov <ap@apple.com>
20139 Reviewed by Dan Bernstein.
20141 https://bugs.webkit.org/show_bug.cgi?id=35165
20142 plugins/set-status.html fails on Windows bot
20144 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
20145 (WebKit::NetscapePluginInstanceProxy::status):
20146 * Plugins/WebNetscapePluginView.mm:
20147 (-[WebNetscapePluginView status:]):
20148 Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as
20149 empty ones to chrome.
20151 2010-02-18 Simon Fraser <simon.fraser@apple.com>
20153 Reviewed by Dan Bernstein.
20155 <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article
20157 Add logic to determine when painting via the software rendering path will give an equivalent
20158 result to the accelerated compositing presentation. This tests for the presence of 3D transforms.
20160 Also have -[WebFrame _drawRect:contentsOnly:] set the PaintBehaviorFlattenCompositingLayers
20161 paint behavior when painting into a bitmap context, so that snapshots contain composited layers.
20163 * WebView/WebFrame.mm:
20164 (-[WebFrame _drawRect:contentsOnly:]): Set the PaintBehaviorFlattenCompositingLayers flag
20165 when painting into a bitmap context.
20166 * WebView/WebView.mm:
20167 (-[WebView _isSoftwareRenderable]): Returns YES if all frames can be software-rendered.
20168 * WebView/WebViewPrivate.h: New _isSoftwareRenderable method.
20170 2010-02-18 Alexey Proskuryakov <ap@apple.com>
20172 Reviewed by Dan Bernstein.
20174 https://bugs.webkit.org/show_bug.cgi?id=35134
20175 <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
20177 Test: plugins/set-status.html
20179 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
20180 (WebKit::NetscapePluginInstanceProxy::status):
20181 (WebKit::NetscapePluginInstanceProxy::loadURL):
20182 Added null checks for CFStringCreateWithCString arguments.
20184 2010-02-17 Dmitry Titov <dimich@chromium.org>
20186 Reviewed by David Levin, Darin Fisher, Simon Hausmann.
20188 When a live iframe element is moved between pages, it still depends on the old page.
20189 https://bugs.webkit.org/show_bug.cgi?id=34382
20191 * WebCoreSupport/WebFrameLoaderClient.h:
20192 * WebCoreSupport/WebFrameLoaderClient.mm:
20193 Added empty implementation of a new virtual method.
20195 (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
20197 2010-02-17 Kent Tamura <tkent@chromium.org>
20199 Reviewed by Eric Seidel.
20201 Introduces new Icon loading interface in order to support
20202 asynchronous loading.
20203 https://bugs.webkit.org/show_bug.cgi?id=32054
20205 Add an empty implementation of ChromeClient::iconForFiles().
20207 * WebCoreSupport/WebChromeClient.h:
20208 * WebCoreSupport/WebChromeClient.mm:
20209 (WebChromeClient::iconForFiles):
20211 2010-02-17 Timothy Hatcher <timothy@apple.com>
20213 Add a way for WebView and its dependancies to be selectively included
20214 in WebKitStatistics leak tracking. By default WebView is not included and
20215 you need to subclass WebView and implement +isIncludedInWebKitStatistics
20218 rdar://problem/7567677&7572900
20219 https://webkit.org/b/35045
20221 Reviewed by Adam Roben.
20223 * WebView/WebDataSource.mm:
20224 (-[WebDataSource _initWithDocumentLoader:]): Increment WebDataSourceCount if the WebFrame is included in statistics.
20225 (-[WebDataSource dealloc]): Only --WebDataSourceCount if _private->includedInWebKitStatistics is YES.
20226 (-[WebDataSource finalize]): Ditto.
20227 * WebView/WebFrame.mm:
20228 (-[WebFrame _isIncludedInWebKitStatistics]): Return _private->includedInWebKitStatistics.
20229 (-[WebFrame _initWithWebFrameView:webView:]): Increment WebFrameCount if the WebView's class is included in statistics.
20230 (-[WebFrame dealloc]): Only --WebFrameCount if _private->includedInWebKitStatistics is YES.
20231 (-[WebFrame finalize]): Ditto.
20232 * WebView/WebFrameInternal.h:
20233 * WebView/WebFrameView.mm:
20234 (-[WebFrameView _setWebFrame:]): Increment WebFrameViewCount if the WebFrame is included in statistics.
20235 (-[WebFrameView initWithFrame:]): Move ++WebFrameViewCount from here since we don't
20236 know what WebFrame we belong to yet.
20237 (-[WebFrameView dealloc]): Only --WebFrameViewCount if _private->includedInWebKitStatistics is YES.
20238 (-[WebFrameView finalize]): Ditto.
20239 * WebView/WebHTMLRepresentation.mm:
20240 (-[WebHTMLRepresentation init]): Move ++WebHTMLRepresentationCount from here since we don't
20241 know what WebFrame we belong to yet.
20242 (-[WebHTMLRepresentation dealloc]): Only --WebHTMLRepresentationCount if _private->includedInWebKitStatistics is YES.
20243 (-[WebHTMLRepresentation finalize]): Ditto.
20244 (-[WebHTMLRepresentation setDataSource:]): Increment WebHTMLRepresentationCount if the WebFrame of the dataSource is
20245 included in statistics.
20246 * WebView/WebView.mm:
20247 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
20248 (-[WebView dealloc]):
20249 (+[WebView shouldIncludeInWebKitStatistics]): Return NO, so any WebView wont be included.
20250 Subclasses that care can return YES to be included.
20251 * WebView/WebViewInternal.h:
20253 2010-02-16 Darin Adler <darin@apple.com>
20255 Reviewed by Sam Weinig.
20257 Generalize delayed plug-in start for background tabs for use for other media
20258 https://bugs.webkit.org/show_bug.cgi?id=34981
20260 * WebView/WebHTMLView.mm:
20261 (-[WebHTMLView viewWillMoveToWindow:]): Added comment.
20262 (-[WebHTMLView viewDidMoveToWindow]): Ditto.
20264 * WebView/WebView.mm:
20265 (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
20266 Call setCanStartMedia right away so that if this view is not in a window, it
20267 will not start any media.
20268 (-[WebView viewWillMoveToWindow:]): Call setCanStartMedia(false) when moving
20269 to a window of nil.
20270 (-[WebView viewDidMoveToWindow]): Call setCanStartMedia(true) when moved to
20271 a window that is non-nil.
20273 2010-02-16 Eric Carlson <eric.carlson@apple.com>
20275 Reviewed by Simon Fraser.
20277 https://bugs.webkit.org/show_bug.cgi?id=34988
20278 WebHTMLView.mm has two -willRemoveSubview: methods
20280 * WebView/WebHTMLView.mm:
20281 (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method.
20283 2010-02-16 Alexey Proskuryakov <ap@apple.com>
20285 Reviewed by Geoffrey Garen and Kevin Decker.
20287 https://bugs.webkit.org/show_bug.cgi?id=34989
20288 <rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content
20290 This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited
20291 in the former case, and adjustCursor in the latter).
20293 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
20294 (-[WebHostedNetscapePluginView handleMouseEntered:]):
20295 (-[WebHostedNetscapePluginView handleMouseExited:]):
20296 * Plugins/WebBaseNetscapePluginView.h:
20297 * Plugins/WebBaseNetscapePluginView.mm:
20298 (-[WebBaseNetscapePluginView handleMouseEntered:]):
20299 (-[WebBaseNetscapePluginView handleMouseExited:]):
20300 * Plugins/WebNetscapePluginView.h:
20301 * Plugins/WebNetscapePluginView.mm:
20302 (-[WebNetscapePluginView handleMouseEntered:]):
20303 (-[WebNetscapePluginView handleMouseExited:]):
20304 AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to
20305 notify plug-in views of mouse entered/exited as part of DOM event dispatch.
20307 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides
20308 mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event
20309 handler. Other mouse events are passed down by EventHandler.
20311 2010-02-15 Alexey Proskuryakov <ap@apple.com>
20313 More build fixing (for what is actually a 64-bit failure, as 32-bit apparently includes
20314 headers that aren't included in 64-bit).
20316 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
20317 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
20318 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::contains):
20319 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get):
20320 Move inline functions to .cpp; also made the class Noncopyable.
20322 2010-02-15 Alexey Proskuryakov <ap@apple.com>
20324 Mac release build fix attempt.
20326 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
20327 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
20328 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::~LocalObjectMap):
20329 Implement destructor in .cpp file, where necessary headers are already included.
20331 2010-02-12 Alexey Proskuryakov <ap@apple.com>
20333 Reviewed by Kevin Decker.
20335 <rdar://problem/7130641> Browser objects identity is not preserved by Safari
20337 Out of process part.
20339 To avoid excessive IPC, plugin process doesn't send each NPObject release/retain call to
20340 Safari. It only sends one when the last one is removed, and it can destroy the proxy
20343 However, the browser may be sending the same object out to plug-in as a function call
20344 argument at the same time - neither side can know what the other one is up to. The solution
20345 is to make the "destroying object" call return a boolean result, making it possible for
20346 the browser to make plugin host keep the proxy with zero refcount for a little longer.
20348 * Plugins/Hosted/NetscapePluginHostProxy.mm:
20349 (WKPCForgetBrowserObject): This function (that used to be named ReleaseObject) is only
20350 called when plug-in releases all of its references, so renamed it. Its boolean result
20351 is returned as call success or failure.
20353 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
20354 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap): Made the numeric ID to JSObject map
20357 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
20358 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): This method is tricky
20359 in that it creates objects with refcount of 1, but doesn't increase refcount when returning
20360 found objects. This extra count accounts for the "reference" kept by plugin process.
20361 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain): Only retaining for the
20362 duration of calls out to plug-in, which means that refcount is almost always equal to 1.
20363 Note that we can't use "++" here, due to how std::pair works!
20364 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release): Ditto.
20365 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::clear): Clear all references when
20367 (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): Like release(), but only
20368 functional when recount is 1 (meaning that the object is not being sent out to plug-in at
20370 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Updated for other changes.
20371 (WebKit::NetscapePluginInstanceProxy::cleanup): Ditto.
20372 (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): Ditto.
20373 (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): Ditto.
20374 (WebKit::NetscapePluginInstanceProxy::forgetBrowserObjectID): Ditto.
20375 (WebKit::NetscapePluginInstanceProxy::evaluate): Ditto.
20376 (WebKit::NetscapePluginInstanceProxy::invoke): Ditto.
20377 (WebKit::NetscapePluginInstanceProxy::invokeDefault): Ditto.
20378 (WebKit::NetscapePluginInstanceProxy::construct): Ditto.
20379 (WebKit::NetscapePluginInstanceProxy::getProperty): Ditto.
20380 (WebKit::NetscapePluginInstanceProxy::setProperty): Ditto.
20381 (WebKit::NetscapePluginInstanceProxy::removeProperty): Ditto.
20382 (WebKit::NetscapePluginInstanceProxy::hasProperty): Ditto.
20383 (WebKit::NetscapePluginInstanceProxy::hasMethod): Ditto.
20384 (WebKit::NetscapePluginInstanceProxy::enumerate): Ditto.
20385 (WebKit::NetscapePluginInstanceProxy::addValueToArray): Ditto.
20386 (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
20387 (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Helper for calling retain when
20388 making calls out to plug-in. No-op for objects that aren't wrapped to be sent (i.e. for
20389 objects wrapping ProxyInstance wrappers for plug-in objects being sent bak).
20390 (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
20392 * Plugins/Hosted/ProxyInstance.mm:
20393 (WebKit::ProxyInstance::invoke): Retain/release arguments during call.
20394 (WebKit::ProxyInstance::setFieldValue): Ditto.
20396 * Plugins/Hosted/WebKitPluginClient.defs: Renamed PCReleaseObject to PCForgetBrowserObject.
20398 2010-02-12 Darin Adler <darin@apple.com>
20400 Reviewed by Sam Weinig.
20402 Removed unneeded custom implementation of isDescendantOf.
20404 * Plugins/WebBaseNetscapePluginView.mm:
20405 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Use the
20406 -[NSView isDescendantOf:] method instead of our own method
20407 named superviewsHaveSuperviews.
20409 2010-02-12 Dan Bernstein <mitz@apple.com>
20411 Reviewed by Darin Adler.
20413 <rdar://problem/7615234> REGRESSION (r48586): Loading an HTML page causes
20414 PDFKit to be loaded
20416 * WebView/WebPDFDocumentExtras.h: Removed the category declaration and
20417 addWebPDFDocumentExtras(). Declare allScriptsInPDFDocument().
20418 * WebView/WebPDFDocumentExtras.mm:
20419 (allScriptsInPDFDocument): Changed the -_web_allScripts method into this function.
20420 * WebView/WebPDFRepresentation.mm: Removed +initialize.
20421 (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use
20422 allScriptsInPDFDocument() instead of -_web_allScripts.
20424 2010-02-10 Geoffrey Garen <ggaren@apple.com>
20426 Reviewed by Oliver Hunt.
20428 Exported some new JavaScript heap introspection.
20430 * Misc/WebCoreStatistics.h:
20431 * Misc/WebCoreStatistics.mm:
20432 (+[WebCoreStatistics javaScriptObjectTypeCounts]): Just like
20433 javaScriptProtectedObjectTypeCounts, except this function enumerates all
20434 live objects, not just protected objects.
20436 2010-02-08 Maciej Stachowiak <mjs@apple.com>
20438 Reviewed by Cameron Zwarich.
20440 Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
20441 https://bugs.webkit.org/show_bug.cgi?id=34698
20443 * Configurations/FeatureDefines.xcconfig:
20445 2010-02-09 Alexey Proskuryakov <ap@apple.com>
20447 Reviewed by Geoffrey Garen.
20449 https://bugs.webkit.org/show_bug.cgi?id=34490
20450 WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions
20452 * ForwardingHeaders/wtf/ValueCheck.h: Added.
20454 2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
20456 Reviewed by Kenneth Rohde Christiansen.
20458 Support frameset flattening
20459 https://bugs.webkit.org/show_bug.cgi?id=32717
20461 Add support for enabling/disabling FrameSet Flattening on the Mac port.
20463 * WebView/WebPreferenceKeysPrivate.h:
20464 * WebView/WebPreferences.mm:
20465 (+[WebPreferences initialize]):
20466 (-[WebPreferences isFrameSetFlatteningEnabled]):
20467 (-[WebPreferences setFrameSetFlatteningEnabled:]):
20468 * WebView/WebPreferencesPrivate.h:
20469 * WebView/WebView.mm:
20470 (-[WebView _preferencesChangedNotification:]):
20472 2010-02-09 Alexey Proskuryakov <ap@apple.com>
20474 Reviewed by Anders Carlsson.
20476 https://bugs.webkit.org/show_bug.cgi?id=34771
20477 A stray mouse moved event is sent to plug-ins after mouse exit
20479 * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): A mouseout
20480 DOM event is dispatched while handling NSMouseMoved - but we shouldn't be sending a
20481 mouse moved event to plug-ins at this point.
20483 2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
20485 Reviewed by Darin Adler.
20487 Provide a way to get total number of pages to be printed
20488 https://bugs.webkit.org/show_bug.cgi?id=34699
20490 * Misc/WebCoreStatistics.h:
20491 * Misc/WebCoreStatistics.mm:
20492 (-[WebFrame numberOfPages:pageWidthInPixels:]):
20494 2010-02-08 Alexey Proskuryakov <ap@apple.com>
20496 Reviewed by Darin Adler.
20498 https://bugs.webkit.org/show_bug.cgi?id=34727
20499 Assertion crashes and freezes when plug-in property access results in an exception
20501 * Plugins/Hosted/WebKitPluginClient.defs: Made PCSetProperty and PCRemoveProperty async.
20502 A plug-in can call back whil processing this call (e.g. for NPN_SetException), so we need
20503 to listen for messages while waiting for reply.
20505 * Plugins/Hosted/NetscapePluginHostProxy.mm:
20506 (WKPCEvaluate): If there is no instance proxy, return KERN_FAILURE. This improves consistency
20507 between method implementations, and leaves us with one less IPC call to make in failure case
20508 (returning false with KERN_SUCCESS and returning KERN_FAILURE looks the same from plugin
20510 (WKPCInvoke): Ditto.
20511 (WKPCInvokeDefault): Ditto.
20512 (WKPCGetProperty): Ditto.
20513 (WKPCSetProperty): Send a reply once done.
20514 (WKPCRemoveProperty): Ditto.
20515 (WKPCHasProperty): If there is no instance proxy, return KERN_FAILURE.
20516 (WKPCHasMethod): Ditto.
20517 (WKPCEnumerate): Ditto.
20519 2010-02-08 Alexey Proskuryakov <ap@apple.com>
20521 Reviewed by Anders Carlsson.
20523 <rdar://problem/6530010> OOP: Support NPN_SetException
20525 Tested by plugins/netscape-throw-exception.html (removed it from skipped list).
20527 * Plugins/Hosted/NetscapePluginHostProxy.mm:
20528 (WKPCSetException):
20529 * Plugins/Hosted/NetscapePluginInstanceProxy.h:
20530 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
20531 (WebKit::globalExceptionString):
20532 (WebKit::NetscapePluginInstanceProxy::setGlobalException):
20533 (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
20534 * Plugins/Hosted/ProxyInstance.mm:
20535 (WebKit::ProxyInstance::invoke):
20536 (WebKit::ProxyInstance::getPropertyNames):
20537 (WebKit::ProxyInstance::fieldValue):
20538 (WebKit::ProxyInstance::setFieldValue):
20539 * Plugins/Hosted/WebKitPluginClient.defs:
20540 Route exception string to a global that's checked after calling into plug-in (just like in
20543 2010-02-05 Kevin Decker <kdecker@apple.com>
20545 Reviewed by Mark Rowe.
20547 https://bugs.webkit.org/show_bug.cgi?id=34661
20548 <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden
20550 * Plugins/Hosted/WebHostedNetscapePluginView.mm:
20551 (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
20552 * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
20553 * Plugins/WebBaseNetscapePluginView.mm:
20554 (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView.
20555 (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
20556 * Plugins/WebNetscapePluginView.mm:
20557 (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
20559 2010-02-04 Mark Rowe <mrowe@apple.com>
20561 Rubber-stamped by Dan Bernstein.
20563 Fix the ability to #include <WebKit/DOMFile.h>.
20565 * MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
20567 2010-02-04 John Sullivan <sullivan@apple.com>
20569 https://bugs.webkit.org/show_bug.cgi?id=34611
20570 WebLocalizedString() could use an assertion that it is being called on the main thread
20572 Reviewed by Tim Hatcher.
20574 * Misc/WebLocalizableStrings.m: Removed.
20575 * Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
20576 Renamed to use .mm extension so it can include a C++ header.
20577 (WebLocalizedString):
20578 Added an assertion that this is being called on the main thread.
20580 2010-02-04 Dan Bernstein <mitz@apple.com>
20582 Reviewed by Simon Fraser.
20584 REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
20585 https://bugs.webkit.org/show_bug.cgi?id=34371
20587 * WebView/WebFrameView.mm:
20588 (-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
20589 constants, and cap the scroll distance.
20590 (-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
20591 cScrollbarPixelsPerLineStep.
20592 (-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
20593 constants, and cap the scroll distance.
20595 2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
20597 Reviewed by Eric Seidel.
20599 Provide a way to get page number with layoutTestController
20600 https://bugs.webkit.org/show_bug.cgi?id=33840
20602 * Misc/WebCoreStatistics.h:
20603 * Misc/WebCoreStatistics.mm:
20604 (-[WebFrame pageNumberForElement:element:pageWidth:]):
20606 2010-01-29 Gavin Barraclough <barraclough@apple.com>
20608 Reviewed by Sam Weinig + Oliver Hunt.
20610 Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
20612 Pass processeing user gensture flag to media play/pause methods.
20614 * WebView/WebVideoFullscreenHUDWindowController.mm:
20615 (-[WebVideoFullscreenHUDWindowController setPlaying:]):
20617 2010-02-01 Dan Bernstein <mitz@apple.com>
20619 Reviewed by Anders Carlsson.
20621 <rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()
20623 The crash was caused by having two streams with a streamID of 1.
20625 * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
20626 (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
20627 correctly increments m_currentURLRequestID to account for the manual stream.
20628 (WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
20629 null it out instead of trying to remove it from the map. Added an assertion.
20630 (WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.
20632 == Rolled over to ChangeLog-2010-01-29 ==