1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
6 """Top-level presubmit script for Skia.
8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
9 for more details about the presubmit API built into gcl.
20 REVERT_CL_SUBJECT_PREFIX = 'Revert '
22 SKIA_TREE_STATUS_URL = 'http://skia-tree-status.appspot.com'
24 # Please add the complete email address here (and not just 'xyz@' or 'xyz').
28 'bsalomon@chromium.org',
29 'bsalomon@google.com',
30 'djsollen@chromium.org',
31 'djsollen@google.com',
34 AUTHORS_FILE_NAME = 'AUTHORS'
36 DOCS_PREVIEW_URL = 'https://skia.org/?cl='
39 def _CheckChangeHasEol(input_api, output_api, source_file_filter=None):
40 """Checks that files end with atleast one \n (LF)."""
42 for f in input_api.AffectedSourceFiles(source_file_filter):
43 contents = input_api.ReadFile(f, 'rb')
44 # Check that the file ends in atleast one newline character.
45 if len(contents) > 1 and contents[-1:] != '\n':
46 eof_files.append(f.LocalPath())
49 return [output_api.PresubmitPromptWarning(
50 'These files should end in a newline character:',
55 def _PythonChecks(input_api, output_api):
56 """Run checks on any modified Python files."""
57 pylint_disabled_warnings = (
58 'F0401', # Unable to import.
59 'E0611', # No name in module.
60 'W0232', # Class has no __init__ method.
61 'E1002', # Use of super on an old style class.
62 'W0403', # Relative import used.
63 'R0201', # Method could be a function.
64 'E1003', # Using class name in super.
65 'W0613', # Unused argument.
67 # Run Pylint on only the modified python files. Unfortunately it still runs
68 # Pylint on the whole file instead of just the modified lines.
69 affected_python_files = []
70 for affected_file in input_api.AffectedSourceFiles(None):
71 affected_file_path = affected_file.LocalPath()
72 if affected_file_path.endswith('.py'):
73 affected_python_files.append(affected_file_path)
74 return input_api.canned_checks.RunPylint(
75 input_api, output_api,
76 disabled_warnings=pylint_disabled_warnings,
77 white_list=affected_python_files)
80 def _CommonChecks(input_api, output_api):
81 """Presubmit checks common to upload and commit."""
83 sources = lambda x: (x.LocalPath().endswith('.h') or
84 x.LocalPath().endswith('.gypi') or
85 x.LocalPath().endswith('.gyp') or
86 x.LocalPath().endswith('.py') or
87 x.LocalPath().endswith('.sh') or
88 x.LocalPath().endswith('.cpp'))
91 input_api, output_api, source_file_filter=sources))
92 results.extend(_PythonChecks(input_api, output_api))
96 def CheckChangeOnUpload(input_api, output_api):
97 """Presubmit checks for the change on upload.
99 The following are the presubmit checks:
100 * Check change has one and only one EOL.
103 results.extend(_CommonChecks(input_api, output_api))
107 def _CheckTreeStatus(input_api, output_api, json_url):
108 """Check whether to allow commit.
111 input_api: input related apis.
112 output_api: output related apis.
113 json_url: url to download json style status.
115 tree_status_results = input_api.canned_checks.CheckTreeIsOpen(
116 input_api, output_api, json_url=json_url)
117 if not tree_status_results:
118 # Check for caution state only if tree is not closed.
119 connection = input_api.urllib2.urlopen(json_url)
120 status = input_api.json.loads(connection.read())
122 if ('caution' in status['message'].lower() and
123 os.isatty(sys.stdout.fileno())):
124 # Display a prompt only if we are in an interactive shell. Without this
125 # check the commit queue behaves incorrectly because it considers
126 # prompts to be failures.
127 short_text = 'Tree state is: ' + status['general_state']
128 long_text = status['message'] + '\n' + json_url
129 tree_status_results.append(
130 output_api.PresubmitPromptWarning(
131 message=short_text, long_text=long_text))
133 # Tree status is closed. Put in message about contacting sheriff.
134 connection = input_api.urllib2.urlopen(
135 SKIA_TREE_STATUS_URL + '/current-sheriff')
136 sheriff_details = input_api.json.loads(connection.read())
138 tree_status_results[0]._message += (
139 '\n\nPlease contact the current Skia sheriff (%s) if you are trying '
140 'to submit a build fix\nand do not know how to submit because the '
141 'tree is closed') % sheriff_details['username']
142 return tree_status_results
145 def _CheckOwnerIsInAuthorsFile(input_api, output_api):
147 issue = input_api.change.issue
148 if issue and input_api.rietveld:
149 issue_properties = input_api.rietveld.get_issue_properties(
150 issue=int(issue), messages=False)
151 owner_email = issue_properties['owner_email']
155 for line in open(AUTHORS_FILE_NAME):
156 if not line.startswith('#'):
157 authors_content += line
158 email_fnmatches = re.findall('<(.*)>', authors_content)
159 for email_fnmatch in email_fnmatches:
160 if fnmatch.fnmatch(owner_email, email_fnmatch):
161 # Found a match, the user is in the AUTHORS file break out of the loop
164 # TODO(rmistry): Remove the below CLA messaging once a CLA checker has
165 # been added to the CQ.
167 output_api.PresubmitError(
168 'The email %s is not in Skia\'s AUTHORS file.\n'
169 'Issue owner, this CL must include an addition to the Skia AUTHORS '
171 'Googler reviewers, please check that the AUTHORS entry '
172 'corresponds to an email address in http://goto/cla-signers. If it '
173 'does not then ask the issue owner to sign the CLA at '
174 'https://developers.google.com/open-source/cla/individual '
176 'https://developers.google.com/open-source/cla/corporate '
180 # Do not fail if authors file cannot be found.
181 traceback.print_exc()
182 input_api.logging.error('AUTHORS file not found!')
187 def _CheckLGTMsForPublicAPI(input_api, output_api):
188 """Check LGTMs for public API changes.
190 For public API files make sure there is an LGTM from the list of owners in
194 requires_owner_check = False
195 for affected_file in input_api.AffectedFiles():
196 affected_file_path = affected_file.LocalPath()
197 file_path, file_ext = os.path.splitext(affected_file_path)
198 # We only care about files that end in .h and are under the top-level
200 if file_ext == '.h' and 'include' == file_path.split(os.path.sep)[0]:
201 requires_owner_check = True
203 if not requires_owner_check:
206 lgtm_from_owner = False
207 issue = input_api.change.issue
208 if issue and input_api.rietveld:
209 issue_properties = input_api.rietveld.get_issue_properties(
210 issue=int(issue), messages=True)
211 if re.match(REVERT_CL_SUBJECT_PREFIX, issue_properties['subject'], re.I):
212 # It is a revert CL, ignore the public api owners check.
215 match = re.search(r'^TBR=(.*)$', issue_properties['description'], re.M)
217 tbr_entries = match.group(1).strip().split(',')
218 for owner in PUBLIC_API_OWNERS:
219 if owner in tbr_entries or owner.split('@')[0] in tbr_entries:
220 # If an owner is specified in the TBR= line then ignore the public
224 if issue_properties['owner_email'] in PUBLIC_API_OWNERS:
225 # An owner created the CL that is an automatic LGTM.
226 lgtm_from_owner = True
228 messages = issue_properties.get('messages')
230 for message in messages:
231 if (message['sender'] in PUBLIC_API_OWNERS and
232 'lgtm' in message['text'].lower()):
233 # Found an lgtm in a message from an owner.
234 lgtm_from_owner = True
237 if not lgtm_from_owner:
239 output_api.PresubmitError(
240 'Since the CL is editing public API, you must have an LGTM from '
241 'one of: %s' % str(PUBLIC_API_OWNERS)))
245 def PostUploadHook(cl, change, output_api):
246 """git cl upload will call this hook after the issue is created/modified.
248 This hook does the following:
249 * Adds a link to preview docs changes if there are any docs changes in the CL.
250 * Adds 'NOTRY=true' if the CL contains only docs changes.
251 * Adds 'NOTREECHECKS=true' for non master branch changes since they do not
252 need to be gated on the master branch's tree.
253 * Adds 'NOTRY=true' for non master branch changes since trybots do not yet
258 atleast_one_docs_change = False
259 all_docs_changes = True
260 for affected_file in change.AffectedFiles():
261 affected_file_path = affected_file.LocalPath()
262 file_path, _ = os.path.splitext(affected_file_path)
263 if 'site' == file_path.split(os.path.sep)[0]:
264 atleast_one_docs_change = True
266 all_docs_changes = False
267 if atleast_one_docs_change and not all_docs_changes:
271 rietveld_obj = cl.RpcServer()
272 if issue and rietveld_obj:
273 original_description = rietveld_obj.get_description(issue)
274 new_description = original_description
276 # If the change includes only doc changes then add NOTRY=true in the
277 # CL's description if it does not exist yet.
278 if all_docs_changes and not re.search(
279 r'^NOTRY=true$', new_description, re.M | re.I):
280 new_description += '\nNOTRY=true'
282 output_api.PresubmitNotifyResult(
283 'This change has only doc changes. Automatically added '
284 '\'NOTRY=true\' to the CL\'s description'))
286 # If there is atleast one docs change then add preview link in the CL's
287 # description if it does not already exist there.
288 if atleast_one_docs_change and not re.search(
289 r'^DOCS_PREVIEW=.*', new_description, re.M | re.I):
290 # Automatically add a link to where the docs can be previewed.
291 new_description += '\nDOCS_PREVIEW= %s%s' % (DOCS_PREVIEW_URL, issue)
293 output_api.PresubmitNotifyResult(
294 'Automatically added a link to preview the docs changes to the '
295 'CL\'s description'))
297 # If the target ref is not master then add NOTREECHECKS=true and NOTRY=true
298 # to the CL's description if it does not already exist there.
299 target_ref = rietveld_obj.get_issue_properties(issue, False).get(
301 if target_ref != 'refs/heads/master':
303 r'^NOTREECHECKS=true$', new_description, re.M | re.I):
304 new_description += "\nNOTREECHECKS=true"
306 output_api.PresubmitNotifyResult(
307 'Branch changes do not need to rely on the master branch\'s '
308 'tree status. Automatically added \'NOTREECHECKS=true\' to the '
309 'CL\'s description'))
311 r'^NOTRY=true$', new_description, re.M | re.I):
312 new_description += "\nNOTRY=true"
314 output_api.PresubmitNotifyResult(
315 'Trybots do not yet work for non-master branches. '
316 'Automatically added \'NOTRY=true\' to the CL\'s description'))
319 # If the description has changed update it.
320 if new_description != original_description:
321 rietveld_obj.update_description(issue, new_description)
326 def CheckChangeOnCommit(input_api, output_api):
327 """Presubmit checks for the change on commit.
329 The following are the presubmit checks:
330 * Check change has one and only one EOL.
331 * Ensures that the Skia tree is open in
332 http://skia-tree-status.appspot.com/. Shows a warning if it is in 'Caution'
333 state and an error if it is in 'Closed' state.
336 results.extend(_CommonChecks(input_api, output_api))
338 _CheckTreeStatus(input_api, output_api, json_url=(
339 SKIA_TREE_STATUS_URL + '/banner-status?format=json')))
340 results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
341 results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api))