1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
6 """Top-level presubmit script for Skia.
8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
9 for more details about the presubmit API built into gcl.
21 REVERT_CL_SUBJECT_PREFIX = 'Revert '
23 SKIA_TREE_STATUS_URL = 'http://skia-tree-status.appspot.com'
25 CQ_KEYWORDS_THAT_NEED_APPENDING = ('CQ_INCLUDE_TRYBOTS', 'CQ_EXTRA_TRYBOTS',
26 'CQ_EXCLUDE_TRYBOTS', 'CQ_TRYBOTS')
28 # Please add the complete email address here (and not just 'xyz@' or 'xyz').
32 'bsalomon@chromium.org',
33 'bsalomon@google.com',
34 'djsollen@chromium.org',
35 'djsollen@google.com',
38 AUTHORS_FILE_NAME = 'AUTHORS'
40 DOCS_PREVIEW_URL = 'https://skia.org/?cl='
43 def _CheckChangeHasEol(input_api, output_api, source_file_filter=None):
44 """Checks that files end with atleast one \n (LF)."""
46 for f in input_api.AffectedSourceFiles(source_file_filter):
47 contents = input_api.ReadFile(f, 'rb')
48 # Check that the file ends in atleast one newline character.
49 if len(contents) > 1 and contents[-1:] != '\n':
50 eof_files.append(f.LocalPath())
53 return [output_api.PresubmitPromptWarning(
54 'These files should end in a newline character:',
59 def _PythonChecks(input_api, output_api):
60 """Run checks on any modified Python files."""
61 pylint_disabled_warnings = (
62 'F0401', # Unable to import.
63 'E0611', # No name in module.
64 'W0232', # Class has no __init__ method.
65 'E1002', # Use of super on an old style class.
66 'W0403', # Relative import used.
67 'R0201', # Method could be a function.
68 'E1003', # Using class name in super.
69 'W0613', # Unused argument.
71 # Run Pylint on only the modified python files. Unfortunately it still runs
72 # Pylint on the whole file instead of just the modified lines.
73 affected_python_files = []
74 for affected_file in input_api.AffectedSourceFiles(None):
75 affected_file_path = affected_file.LocalPath()
76 if affected_file_path.endswith('.py'):
77 affected_python_files.append(affected_file_path)
78 return input_api.canned_checks.RunPylint(
79 input_api, output_api,
80 disabled_warnings=pylint_disabled_warnings,
81 white_list=affected_python_files)
84 def _IfDefChecks(input_api, output_api):
85 """Ensures if/ifdef are not before includes. See skbug/3362 for details."""
86 comment_block_start_pattern = re.compile('^\s*\/\*.*$')
87 comment_block_middle_pattern = re.compile('^\s+\*.*')
88 comment_block_end_pattern = re.compile('^\s+\*\/.*$')
89 single_line_comment_pattern = re.compile('^\s*//.*$')
91 return (comment_block_start_pattern.match(line) or
92 comment_block_middle_pattern.match(line) or
93 comment_block_end_pattern.match(line) or
94 single_line_comment_pattern.match(line))
96 empty_line_pattern = re.compile('^\s*$')
97 def is_empty_line(line):
98 return empty_line_pattern.match(line)
101 for affected_file in input_api.AffectedSourceFiles(None):
102 affected_file_path = affected_file.LocalPath()
103 if affected_file_path.endswith('.cpp') or affected_file_path.endswith('.h'):
104 f = open(affected_file_path)
105 for line in f.xreadlines():
106 if is_comment(line) or is_empty_line(line):
108 # The below will be the first real line after comments and newlines.
109 if line.startswith('#if 0 '):
111 elif line.startswith('#if ') or line.startswith('#ifdef '):
112 failing_files.append(affected_file_path)
118 output_api.PresubmitError(
119 'The following files have #if or #ifdef before includes:\n%s\n\n'
120 'See skbug.com/3362 for why this should be fixed.' %
121 '\n'.join(failing_files)))
125 def _CopyrightChecks(input_api, output_api, source_file_filter=None):
127 year_pattern = r'\d{4}'
128 year_range_pattern = r'%s(-%s)?' % (year_pattern, year_pattern)
129 years_pattern = r'%s(,%s)*,?' % (year_range_pattern, year_range_pattern)
130 copyright_pattern = (
131 r'Copyright (\([cC]\) )?%s \w+' % years_pattern)
133 for affected_file in input_api.AffectedSourceFiles(source_file_filter):
134 if 'third_party' in affected_file.LocalPath():
136 contents = input_api.ReadFile(affected_file, 'rb')
137 if not re.search(copyright_pattern, contents):
138 results.append(output_api.PresubmitError(
139 '%s is missing a correct copyright header.' % affected_file))
143 def _CommonChecks(input_api, output_api):
144 """Presubmit checks common to upload and commit."""
146 sources = lambda x: (x.LocalPath().endswith('.h') or
147 x.LocalPath().endswith('.gypi') or
148 x.LocalPath().endswith('.gyp') or
149 x.LocalPath().endswith('.py') or
150 x.LocalPath().endswith('.sh') or
151 x.LocalPath().endswith('.m') or
152 x.LocalPath().endswith('.mm') or
153 x.LocalPath().endswith('.go') or
154 x.LocalPath().endswith('.c') or
155 x.LocalPath().endswith('.cc') or
156 x.LocalPath().endswith('.cpp'))
159 input_api, output_api, source_file_filter=sources))
160 results.extend(_PythonChecks(input_api, output_api))
161 results.extend(_IfDefChecks(input_api, output_api))
162 results.extend(_CopyrightChecks(input_api, output_api,
163 source_file_filter=sources))
167 def CheckChangeOnUpload(input_api, output_api):
168 """Presubmit checks for the change on upload.
170 The following are the presubmit checks:
171 * Check change has one and only one EOL.
174 results.extend(_CommonChecks(input_api, output_api))
178 def _CheckTreeStatus(input_api, output_api, json_url):
179 """Check whether to allow commit.
182 input_api: input related apis.
183 output_api: output related apis.
184 json_url: url to download json style status.
186 tree_status_results = input_api.canned_checks.CheckTreeIsOpen(
187 input_api, output_api, json_url=json_url)
188 if not tree_status_results:
189 # Check for caution state only if tree is not closed.
190 connection = input_api.urllib2.urlopen(json_url)
191 status = input_api.json.loads(connection.read())
193 if ('caution' in status['message'].lower() and
194 os.isatty(sys.stdout.fileno())):
195 # Display a prompt only if we are in an interactive shell. Without this
196 # check the commit queue behaves incorrectly because it considers
197 # prompts to be failures.
198 short_text = 'Tree state is: ' + status['general_state']
199 long_text = status['message'] + '\n' + json_url
200 tree_status_results.append(
201 output_api.PresubmitPromptWarning(
202 message=short_text, long_text=long_text))
204 # Tree status is closed. Put in message about contacting sheriff.
205 connection = input_api.urllib2.urlopen(
206 SKIA_TREE_STATUS_URL + '/current-sheriff')
207 sheriff_details = input_api.json.loads(connection.read())
209 tree_status_results[0]._message += (
210 '\n\nPlease contact the current Skia sheriff (%s) if you are trying '
211 'to submit a build fix\nand do not know how to submit because the '
212 'tree is closed') % sheriff_details['username']
213 return tree_status_results
216 def _CheckOwnerIsInAuthorsFile(input_api, output_api):
218 issue = input_api.change.issue
219 if issue and input_api.rietveld:
220 issue_properties = input_api.rietveld.get_issue_properties(
221 issue=int(issue), messages=False)
222 owner_email = issue_properties['owner_email']
226 for line in open(AUTHORS_FILE_NAME):
227 if not line.startswith('#'):
228 authors_content += line
229 email_fnmatches = re.findall('<(.*)>', authors_content)
230 for email_fnmatch in email_fnmatches:
231 if fnmatch.fnmatch(owner_email, email_fnmatch):
232 # Found a match, the user is in the AUTHORS file break out of the loop
235 # TODO(rmistry): Remove the below CLA messaging once a CLA checker has
236 # been added to the CQ.
238 output_api.PresubmitError(
239 'The email %s is not in Skia\'s AUTHORS file.\n'
240 'Issue owner, this CL must include an addition to the Skia AUTHORS '
242 'Googler reviewers, please check that the AUTHORS entry '
243 'corresponds to an email address in http://goto/cla-signers. If it '
244 'does not then ask the issue owner to sign the CLA at '
245 'https://developers.google.com/open-source/cla/individual '
247 'https://developers.google.com/open-source/cla/corporate '
251 # Do not fail if authors file cannot be found.
252 traceback.print_exc()
253 input_api.logging.error('AUTHORS file not found!')
258 def _CheckLGTMsForPublicAPI(input_api, output_api):
259 """Check LGTMs for public API changes.
261 For public API files make sure there is an LGTM from the list of owners in
265 requires_owner_check = False
266 for affected_file in input_api.AffectedFiles():
267 affected_file_path = affected_file.LocalPath()
268 file_path, file_ext = os.path.splitext(affected_file_path)
269 # We only care about files that end in .h and are under the top-level
271 if file_ext == '.h' and 'include' == file_path.split(os.path.sep)[0]:
272 requires_owner_check = True
274 if not requires_owner_check:
277 lgtm_from_owner = False
278 issue = input_api.change.issue
279 if issue and input_api.rietveld:
280 issue_properties = input_api.rietveld.get_issue_properties(
281 issue=int(issue), messages=True)
282 if re.match(REVERT_CL_SUBJECT_PREFIX, issue_properties['subject'], re.I):
283 # It is a revert CL, ignore the public api owners check.
286 # TODO(rmistry): Stop checking for COMMIT=false once crbug/470609 is
288 if issue_properties['cq_dry_run'] or re.search(
289 r'^COMMIT=false$', issue_properties['description'], re.M):
290 # Ignore public api owners check for dry run CLs since they are not
291 # going to be committed.
294 match = re.search(r'^TBR=(.*)$', issue_properties['description'], re.M)
296 tbr_entries = match.group(1).strip().split(',')
297 for owner in PUBLIC_API_OWNERS:
298 if owner in tbr_entries or owner.split('@')[0] in tbr_entries:
299 # If an owner is specified in the TBR= line then ignore the public
303 if issue_properties['owner_email'] in PUBLIC_API_OWNERS:
304 # An owner created the CL that is an automatic LGTM.
305 lgtm_from_owner = True
307 messages = issue_properties.get('messages')
309 for message in messages:
310 if (message['sender'] in PUBLIC_API_OWNERS and
311 'lgtm' in message['text'].lower()):
312 # Found an lgtm in a message from an owner.
313 lgtm_from_owner = True
316 if not lgtm_from_owner:
318 output_api.PresubmitError(
319 'Since the CL is editing public API, you must have an LGTM from '
320 'one of: %s' % str(PUBLIC_API_OWNERS)))
324 def PostUploadHook(cl, change, output_api):
325 """git cl upload will call this hook after the issue is created/modified.
327 This hook does the following:
328 * Adds a link to preview docs changes if there are any docs changes in the CL.
329 * Adds 'NOTRY=true' if the CL contains only docs changes.
330 * Adds 'NOTREECHECKS=true' for non master branch changes since they do not
331 need to be gated on the master branch's tree.
332 * Adds 'NOTRY=true' for non master branch changes since trybots do not yet
337 atleast_one_docs_change = False
338 all_docs_changes = True
339 for affected_file in change.AffectedFiles():
340 affected_file_path = affected_file.LocalPath()
341 file_path, _ = os.path.splitext(affected_file_path)
342 if 'site' == file_path.split(os.path.sep)[0]:
343 atleast_one_docs_change = True
345 all_docs_changes = False
346 if atleast_one_docs_change and not all_docs_changes:
350 rietveld_obj = cl.RpcServer()
351 if issue and rietveld_obj:
352 original_description = rietveld_obj.get_description(issue)
353 new_description = original_description
355 # If the change includes only doc changes then add NOTRY=true in the
356 # CL's description if it does not exist yet.
357 if all_docs_changes and not re.search(
358 r'^NOTRY=true$', new_description, re.M | re.I):
359 new_description += '\nNOTRY=true'
361 output_api.PresubmitNotifyResult(
362 'This change has only doc changes. Automatically added '
363 '\'NOTRY=true\' to the CL\'s description'))
365 # If there is atleast one docs change then add preview link in the CL's
366 # description if it does not already exist there.
367 if atleast_one_docs_change and not re.search(
368 r'^DOCS_PREVIEW=.*', new_description, re.M | re.I):
369 # Automatically add a link to where the docs can be previewed.
370 new_description += '\nDOCS_PREVIEW= %s%s' % (DOCS_PREVIEW_URL, issue)
372 output_api.PresubmitNotifyResult(
373 'Automatically added a link to preview the docs changes to the '
374 'CL\'s description'))
376 # If the target ref is not master then add NOTREECHECKS=true and NOTRY=true
377 # to the CL's description if it does not already exist there.
378 target_ref = rietveld_obj.get_issue_properties(issue, False).get(
380 if target_ref != 'refs/heads/master':
382 r'^NOTREECHECKS=true$', new_description, re.M | re.I):
383 new_description += "\nNOTREECHECKS=true"
385 output_api.PresubmitNotifyResult(
386 'Branch changes do not need to rely on the master branch\'s '
387 'tree status. Automatically added \'NOTREECHECKS=true\' to the '
388 'CL\'s description'))
390 r'^NOTRY=true$', new_description, re.M | re.I):
391 new_description += "\nNOTRY=true"
393 output_api.PresubmitNotifyResult(
394 'Trybots do not yet work for non-master branches. '
395 'Automatically added \'NOTRY=true\' to the CL\'s description'))
397 # Read and process the HASHTAGS file.
398 hashtags_fullpath = os.path.join(change._local_root, 'HASHTAGS')
399 with open(hashtags_fullpath, 'rb') as hashtags_csv:
400 hashtags_reader = csv.reader(hashtags_csv, delimiter=',')
401 for row in hashtags_reader:
402 if not row or row[0].startswith('#'):
403 # Ignore empty lines and comments
406 # Search for the hashtag in the description.
407 if re.search('#%s' % hashtag, new_description, re.M | re.I):
408 for mapped_text in row[1:]:
409 # Special case handling for CQ_KEYWORDS_THAT_NEED_APPENDING.
410 appended_description = _HandleAppendingCQKeywords(
411 hashtag, mapped_text, new_description, results, output_api)
412 if appended_description:
413 new_description = appended_description
416 # Add the mapped text if it does not already exist in the
419 r'^%s$' % mapped_text, new_description, re.M | re.I):
420 new_description += '\n%s' % mapped_text
422 output_api.PresubmitNotifyResult(
423 'Found \'#%s\', automatically added \'%s\' to the CL\'s '
424 'description' % (hashtag, mapped_text)))
426 # If the description has changed update it.
427 if new_description != original_description:
428 rietveld_obj.update_description(issue, new_description)
433 def _HandleAppendingCQKeywords(hashtag, keyword_and_value, description,
434 results, output_api):
435 """Handles the CQ keywords that need appending if specified in hashtags."""
436 keyword = keyword_and_value.split('=')[0]
437 if keyword in CQ_KEYWORDS_THAT_NEED_APPENDING:
438 # If the keyword is already in the description then append to it.
440 r'^%s=(.*)$' % keyword, description, re.M | re.I)
442 old_values = match.group(1).split(';')
443 new_value = keyword_and_value.split('=')[1]
444 if new_value in old_values:
445 # Do not need to do anything here.
447 # Update the description with the new values.
448 new_description = description.replace(
449 match.group(0), "%s;%s" % (match.group(0), new_value))
451 output_api.PresubmitNotifyResult(
452 'Found \'#%s\', automatically appended \'%s\' to %s in '
453 'the CL\'s description' % (hashtag, new_value, keyword)))
454 return new_description
458 def CheckChangeOnCommit(input_api, output_api):
459 """Presubmit checks for the change on commit.
461 The following are the presubmit checks:
462 * Check change has one and only one EOL.
463 * Ensures that the Skia tree is open in
464 http://skia-tree-status.appspot.com/. Shows a warning if it is in 'Caution'
465 state and an error if it is in 'Closed' state.
468 results.extend(_CommonChecks(input_api, output_api))
470 _CheckTreeStatus(input_api, output_api, json_url=(
471 SKIA_TREE_STATUS_URL + '/banner-status?format=json')))
472 results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
473 results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api))